1 2012-03-11 Chong Yidong <cyd@gnu.org>
3 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5 2012-03-10 Chong Yidong <cyd@gnu.org>
7 * frame.c (other_visible_frames): Don't assume the selected frame
8 is visible (Bug#10955).
10 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
12 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
14 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
16 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
17 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
20 2012-03-03 Glenn Morris <rgm@gnu.org>
22 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
24 2012-03-02 Eli Zaretskii <eliz@gnu.org>
26 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
27 position past the first glyph_row that ends at ZV. (Bug#10902)
28 (redisplay_window, next_element_from_string): Fix typos in
30 (redisplay_window): Pass to move_it_vertically the margin in
31 pixels, not in screen lines.
33 2012-03-02 Glenn Morris <rgm@gnu.org>
35 * buffer.c (buffer-list-update-hook): Doc fix.
37 2012-02-29 Eli Zaretskii <eliz@gnu.org>
39 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
40 push_it before setting up the iterator for the first overlay
41 string, even if we have an empty string loaded.
42 (next_overlay_string): If there's an empty string on the iterator
43 stack, pop the stack. (Bug#10903)
45 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
47 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
48 Suggested by Stefan Monnier in
49 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
50 * alloc.c (widen_to_Lisp_Object): New static function.
51 (mark_memory): Also mark Lisp_Objects by fetching pointer words
52 and widening them to Lisp_Objects. This would work even if
53 USE_LSB_TAG is defined and wide integers are used, which might
54 happen in a future version of Emacs.
56 2012-02-25 Chong Yidong <cyd@gnu.org>
58 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
61 * xselect.c (Fx_selection_exists_p): Doc fix.
62 (x_clipboard_manager_save_all): Print an informative message
63 before saving to clipboard manager.
65 2012-02-24 Chong Yidong <cyd@gnu.org>
67 * keyboard.c (process_special_events): Handle all X selection
68 requests in kbd_buffer, not just the next one (Bug#8869).
70 2012-02-23 Chong Yidong <cyd@gnu.org>
72 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
73 call when setting menu-bar-lines and tool-bar-lines parameters.
74 (unwind_create_frame_1): New helper function.
76 * window.c (inhibit_window_configuration_change_hook): New var.
77 (run_window_configuration_change_hook): Obey it.
78 (syms_of_window): Initialize it.
80 2012-02-22 Chong Yidong <cyd@gnu.org>
82 * xterm.c (x_draw_image_relief): Add missing type check for
83 Vtool_bar_button_margin (Bug#10743).
85 2012-02-21 Chong Yidong <cyd@gnu.org>
87 * fileio.c (Vfile_name_handler_alist): Doc fix.
89 * buffer.c (Fget_file_buffer): Protect against invalid file
92 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
94 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
95 when computing $valmask.
97 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
98 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
99 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
100 It's useless in that case, and it can cause problems on hosts
101 that allocate halves of EMACS_INT values separately.
102 Reported by Dan Horák. Diagnosed by Andreas Schwab in
103 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
104 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
105 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
106 it avoids undefined behavior on hosts where shifting right by more
107 than the word width has undefined behavior.
109 2012-02-19 Chong Yidong <cyd@gnu.org>
111 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
112 (Funhandled_file_name_directory, Ffile_name_as_directory)
113 (Fdirectory_file_name, Fexpand_file_name)
114 (Fsubstitute_in_file_name): Protect against invalid file handler
115 return values (Bug#10845).
117 2012-02-18 Eli Zaretskii <eliz@gnu.org>
119 * .gdbinit (pitx): Fix incorrect references to fields of the
122 2012-02-17 Chong Yidong <cyd@gnu.org>
124 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
126 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
128 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
129 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
131 2012-02-15 Chong Yidong <cyd@gnu.org>
133 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
134 marked as special. Also, starting docstrings with * is obsolete.
136 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
138 * gnutls.c (emacs_gnutls_write): Fix last change.
140 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
142 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
145 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
147 * keymap.c (Fsingle_key_description): Handle char ranges.
149 2012-02-12 Chong Yidong <cyd@gnu.org>
151 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
152 as that creates a dangerous corner case.
154 * window.c (Fdelete_window_internal): Invalidate the mouse
155 highlight (Bug#9904).
157 2012-02-12 Glenn Morris <rgm@gnu.org>
159 * xselect.c (Fx_own_selection_internal)
160 (Fx_get_selection_internal, Fx_disown_selection_internal)
161 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
162 * nsselect.m (Fx_own_selection_internal)
163 (Fx_disown_selection_internal, Fx_selection_exists_p)
164 (Fx_selection_owner_p, Fx_get_selection_internal):
165 Sync docs and argument specs with the xselect.c versions.
167 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
169 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
171 2012-02-11 Eli Zaretskii <eliz@gnu.org>
173 * w32select.c (Fx_selection_exists_p): Sync doc string and
174 argument list with xselect.c. (Bug#10783)
176 * w16select.c (Fx_selection_exists_p): Sync doc string and
177 argument list with xselect.c. (Bug#10783)
179 2012-02-10 Glenn Morris <rgm@gnu.org>
181 * fns.c (Fsecure_hash): Doc fix.
183 2012-02-09 Kenichi Handa <handa@m17n.org>
185 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
187 2012-02-07 Chong Yidong <cyd@gnu.org>
189 * buffer.c (Fbuffer_local_variables)
190 (buffer_lisp_local_variables): Handle unbound vars correctly;
191 don't let Qunbound leak into Lisp.
193 2012-02-07 Glenn Morris <rgm@gnu.org>
195 * image.c (Fimagemagick_types): Doc fix.
197 * image.c (imagemagick-render-type): Change it from a lisp object
198 to an integer. Move the doc here from the lisp manual.
199 Treat all values not equal to 0 the same.
201 2012-02-06 Chong Yidong <cyd@gnu.org>
203 * doc.c (store_function_docstring): Avoid applying docstring of
204 alias to base function (Bug#2603).
206 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
208 * .gdbinit (pp1, pv1): Remove redundant defines.
211 2012-02-04 Chong Yidong <cyd@gnu.org>
213 * nsterm.m: Declare a global (Bug#10694).
215 2012-02-04 Eli Zaretskii <eliz@gnu.org>
217 * w32.c (get_emacs_configuration_options):
218 Include --enable-checking, if specified, in the return value.
220 2012-02-04 Martin Rudalics <rudalics@gmx.at>
222 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
223 after rounding frame sizes. (Bug#9723)
225 2012-02-04 Eli Zaretskii <eliz@gnu.org>
227 * keyboard.c (adjust_point_for_property): Don't position point
228 before BEGV. (Bug#10696)
230 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
232 Handle overflow when computing char display width (Bug#9496).
233 * character.c (char_width): Return EMACS_INT, not int.
234 (char_width, c_string_width): Check for overflow when
235 computing the width; this is possible now that individual
236 characters can have unbounded width. Problem introduced
237 by merge from Emacs 23 on 2012-01-19.
239 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
241 * dbusbind.c (Fdbus_register_method): Mention the return value
242 :ignore in the docstring.
244 2012-02-02 Glenn Morris <rgm@gnu.org>
246 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
248 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
249 Unconditionally set to t. (Bug#10673)
250 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
251 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
252 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
254 2012-02-02 Kenichi Handa <handa@m17n.org>
256 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
257 0, do not call append_composite_glyph.
259 2012-02-02 Kenichi Handa <handa@m17n.org>
261 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
263 (x_produce_glyphs): If the component of a composition is a null
264 string, set it->pixel_width to 1 to avoid zero-width glyph.
266 2012-02-01 Eli Zaretskii <eliz@gnu.org>
268 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
269 first 2 arguments are identical. This makes inserting large
270 output from a subprocess an order of magnitude faster on
271 MS-Windows, where all sbrk'ed memory is always contiguous.
273 2012-01-31 Glenn Morris <rgm@gnu.org>
275 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
276 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
277 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
279 2012-01-29 Glenn Morris <rgm@gnu.org>
281 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
283 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
285 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
287 2012-01-28 Chong Yidong <cyd@gnu.org>
289 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
291 2012-01-26 Chong Yidong <cyd@gnu.org>
293 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
295 * search.c (Fsearch_forward, Fsearch_backward): Document negative
296 repeat counts (Bug#10507).
298 2012-01-26 Glenn Morris <rgm@gnu.org>
300 * lread.c (syms_of_lread): Doc fix.
302 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
304 * coding.c (encode_designation_at_bol): Change return value to
307 2012-01-25 Chong Yidong <cyd@gnu.org>
309 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
311 2012-01-21 Chong Yidong <cyd@gnu.org>
313 * floatfns.c (Fcopysign): Make the second argument non-optional,
314 since nil is not allowed anyway.
316 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
318 * process.c (read_process_output): Use p instead of XPROCESS (proc).
319 (send_process): Likewise.
321 2012-01-19 Martin Rudalics <rudalics@gmx.at>
323 * window.c (save_window_save, Fcurrent_window_configuration)
324 (Vwindow_persistent_parameters): Do not use Qstate.
327 2012-01-19 Kenichi Handa <handa@m17n.org>
329 * character.c (char_width): New function.
330 (Fchar_width, c_string_width, lisp_string_width):
331 Use char_width (Bug#9496).
333 2012-01-16 Martin Rudalics <rudalics@gmx.at>
335 * window.c (Vwindow_persistent_parameters): New variable.
336 (Fset_window_configuration, save_window_save): Handle persistent
339 2012-01-14 Eli Zaretskii <eliz@gnu.org>
341 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
342 thrashing the stack of the thread. (Bug#9087)
344 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
346 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
348 2012-01-11 Eli Zaretskii <eliz@gnu.org>
350 * xdisp.c (rows_from_pos_range): Handle the case where the
351 highlight ends on a newline. (Bug#10464)
352 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
353 he end column for display of highlight that ends on a newline
356 2012-01-11 Glenn Morris <rgm@gnu.org>
358 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
359 from load-path also when installation-directory is nil. (Bug#10208)
361 2012-01-10 Glenn Morris <rgm@gnu.org>
363 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
365 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
366 Update template values to be closer to their typical values these days.
368 2012-01-09 Eli Zaretskii <eliz@gnu.org>
370 * xdisp.c (rows_from_pos_range): Accept additional argument
371 DISP_STRING, and accept any glyph in a row whose object is that
372 string as eligible for mouse highlight. Fixes mouse highlight of
373 display strings from overlays. (Bug#10464)
375 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
377 emacs: fix an auto-save permissions race condition (Bug#10400)
378 * fileio.c (auto_saving_dir_umask): New static var.
379 (Fmake_directory_internal): Use it.
380 (do_auto_save_make_dir): Set it, instead of invoking chmod after
381 creating the directory. The old code temporarily assigns
382 too-generous permissions to the directory.
383 (do_auto_save_eh): Clear it.
384 (Fdo_auto_save): Catch all errors, not just file errors, so
385 that the var is always cleared.
387 2012-01-07 Eli Zaretskii <eliz@gnu.org>
389 * search.c (scan_buffer): Pass character positions to
390 know_region_cache, not byte positions. (Bug#6540)
392 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
394 * w32.c (sys_rename): Report EXDEV when rename of a directory
395 fails because the target is on another logical disk. (Bug#10284)
397 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
399 * xterm.c (x_embed_request_focus): New function.
401 * xterm.h: Add prototype.
403 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
405 2012-01-05 Glenn Morris <rgm@gnu.org>
407 * emacs.c (emacs_copyright): Update short copyright year to 2012.
409 2012-01-01 Eli Zaretskii <eliz@gnu.org>
411 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
412 Load gnutls_transport_set_lowat only if GnuTLS version is below
414 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
415 GnuTLS versions below 2.11.1.
417 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
419 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
420 to the doc string advising against its use for altering the way
421 windows are scrolled.
423 2011-12-28 Kenichi Handa <handa@m17n.org>
425 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
426 coding-system ASCII compatible only when it does not produce BOM
427 on encoding (Bug#10383).
429 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
431 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
433 (create_and_show_popup_menu): Always use menu_position_func for
436 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
438 * callint.c (Fcall_interactively): Don't truncate prompt string.
440 2011-12-23 Eli Zaretskii <eliz@gnu.org>
442 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
443 property that ends at ZV, so that the bidi iteration could be
444 resumed from there (after widening). (Bug#10360)
446 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
448 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
450 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
452 * nsterm.m (x_free_frame_resources):
453 Release f->output_data.ns->miniimage.
454 (ns_index_color): Fix indentation. Do not retain
455 color_table->colors[i].
457 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
460 * nsfns.m (x_set_background_color): Assign return value from
461 ns_index_color to face-background instead of NSColor*.
462 (ns_implicitly_set_icon_type): Fix indentation.
463 Change assignment in for loop to comparison.
465 * emacs.c (ns_pool): New variable.
466 (main): Assign ns_pool.
467 (Fkill_emacs): Call ns_release_autorelease_pool.
469 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
470 autorelease fdesc, release fdAttrs and tdict.
471 (ns_get_covering_families): Release charset.
472 (ns_findfonts): Release NSFontDescriptor created with new.
473 (ns_uni_to_glyphs): Fix indentation.
474 (setString): Release attrStr before assigning new value.
476 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
478 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
480 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
481 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
483 2011-12-18 David Reitter <reitter@cmu.edu>
485 * nsterm.m (ns_term_init): Subscribe for notifications
486 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
487 to method trackingNotification in EmacsMenu.
489 * nsmenu.m (trackingMenu): New variable.
490 (trackingNotification): New method (from Aquamacs).
491 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
492 from Aquamacs (Bug#7030).
494 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
496 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
497 (symbol_to_nsstring): Fix indentation.
498 (ns_symbol_to_pb): New function.
499 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
500 (Fns_rotate_cut_buffers_internal): Remove.
501 (Fns_store_selection_internal): Rename from
502 Fns_store_cut_buffer_internal.
503 (ns_get_foreign_selection, Fx_own_selection_internal)
504 (Fx_disown_selection_internal, Fx_selection_exists_p)
505 (Fns_get_selection_internal, Fns_store_selection_internal):
506 Use ns_symbol_to_pb and check if return value is nil.
507 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
508 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
509 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
510 renamed to Sns_store_selection_internal.
511 (ns_handle_selection_request): Move code to Fx_own_selection_internal
512 and remove this function.
513 (ns_handle_selection_clear): Remove, never used.
514 (Fx_own_selection_internal): Move code from ns_handle_selection_request
517 2011-12-17 Ken Brown <kbrown@cornell.edu>
519 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
520 GID is unknown (Bug#10257).
522 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
524 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
525 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
526 which caused a build failure on GNU/Linux IA-64. This problem was
527 introduced by my 2011-10-07 patch.
529 2011-12-15 Juri Linkov <juri@jurta.org>
531 * image.c (imagemagick_error): New function. (Bug#10112)
532 (imagemagick_load_image): Comment out `MagickSetResolution' call.
533 Use `imagemagick_error' where ImageMagick functions return
535 (Fimagemagick_types): Add `Fnreverse' to return the list in the
538 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
540 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
541 fill background (Bug#8992).
543 2011-12-13 Martin Rudalics <rudalics@gmx.at>
545 * window.c (Vwindow_combination_resize)
546 (Vwindow_combination_limit): Use t instead of non-nil in
548 (Vrecenter_redisplay): Add first sentence of doc-string on
550 (Frecenter): Fix doc-string typo.
552 2011-12-11 Kenichi Handa <handa@m17n.org>
554 * coding.c (Funencodable_char_position): Pay attention to the
555 buffer text relocation (Bug#9389).
557 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
559 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
560 gtk_init (Bug#10100).
562 2011-12-10 Eli Zaretskii <eliz@gnu.org>
564 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
565 IT->string is nil. (Bug#10263)
567 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
569 * nsterm.h (x_free_frame_resources): Declare.
571 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
572 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
574 * nsterm.h (ns_get_defaults_value): Declare.
576 * nsterm.m (ns_default): Call ns_get_defaults_value.
578 2011-12-09 Eli Zaretskii <eliz@gnu.org>
580 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
583 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
585 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
586 that where the value of an _OBJC_* symbol points to is in the .bss
589 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
591 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
592 after the loop to call ccl_driver at least once (Bug#8619).
594 2011-12-08 Kenichi Handa <handa@m17n.org>
596 * ftfont.c (get_adstyle_property): Fix previous change
599 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
601 * w32.c (init_environment): If no_site_lisp, remove site-lisp
602 dirs from the default value of EMACSLOADPATH (bug#10208).
604 2011-12-07 Glenn Morris <rgm@gnu.org>
606 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
607 installation and source directories as well. (Bug#10208)
609 2011-12-06 Chong Yidong <cyd@gnu.org>
611 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
613 2011-12-06 Glenn Morris <rgm@gnu.org>
615 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
616 as an error, not just -1. (Bug#10217)
618 2011-12-05 Chong Yidong <cyd@gnu.org>
620 * keyboard.c (process_special_events): New function.
621 (swallow_events, Finput_pending_p): Use it (Bug#10195).
623 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
625 * coding.c (encode_designation_at_bol): Don't use uninitialized
626 local variable (Bug#9318).
628 2011-12-05 Kenichi Handa <handa@m17n.org>
630 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
631 return Qnil (Bug#8046, Bug#10193).
633 2011-12-05 Kenichi Handa <handa@m17n.org>
635 * coding.c (encode_designation_at_bol): New args charbuf_end and
636 dst. Return the number of produced bytes. Callers changed.
637 (coding_set_source): Return how many bytes coding->source was
639 (coding_set_destination): Return how many bytes
640 coding->destination was relocated.
641 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
642 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
644 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
646 * coding.c (CODING_CHAR_CHARSET_P): New macro.
647 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
650 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
652 The following changes are to fix Bug#9318.
654 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
655 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
656 (encode_coding_iso_2022, encode_coding_sjis)
657 (encode_coding_big5, encode_coding_charset): Use the above macros.
659 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
661 * lisp.h (process_quit_flag): Fix external declaration.
663 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
665 Don't macro-inline non-performance-critical code.
666 * eval.c (process_quit_flag): New function.
667 * lisp.h (QUIT): Use it.
669 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
671 * nsfns.m (get_geometry_from_preferences): New function.
672 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
674 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
676 * emacs.c (Qkill_emacs): Define.
677 (syms_of_emacs): Initialize it.
678 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
679 Qquit_flag to `kill-emacs' instead.
680 (quit_throw_to_read_char): Add parameter `from_signal'.
681 All callers changed. Call Fkill_emacs if requested and safe.
682 * lisp.h (QUIT): Call Fkill_emacs if requested.
684 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
686 * widget.c (update_wm_hints): Return if wmshell is null.
687 (widget_update_wm_size_hints): New function.
689 * widget.h (widget_update_wm_size_hints): Declare.
691 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
692 widget_update_wm_size_hints (Bug#10104).
694 2011-12-03 Eli Zaretskii <eliz@gnu.org>
696 * xdisp.c (handle_invisible_prop): If the invisible text ends just
697 before a newline, prepare the bidi iterator for consuming the
698 newline, and keep the current paragraph direction. (Bug#10183)
699 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
701 2011-12-02 Juri Linkov <juri@jurta.org>
703 * search.c (Fword_search_regexp): New Lisp function created from
704 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
705 (Fword_search_backward, Fword_search_forward)
706 (Fword_search_backward_lax, Fword_search_forward_lax):
707 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
708 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
710 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
712 * fileio.c (Finsert_file_contents): Move after-change-function call
713 to before the "handled:" label, since all "goto handled" appear in
714 cases where the *-change-functions have already been properly called
717 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
719 * keyboard.c (interrupt_signal): Don't call kill-emacs when
720 waiting for input. (Bug#10169)
722 2011-11-30 Eli Zaretskii <eliz@gnu.org>
724 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
725 verifies glyph row's hash code--we have just reallocated the
726 glyphs, so their contents can be complete garbage. (Bug#10164)
728 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
730 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
732 2011-11-30 Eli Zaretskii <eliz@gnu.org>
734 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
735 attributes are tested _before_ calling verify_row_hash, to protect
736 against GCC re-ordering of the tests. (Bug#10164)
738 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
740 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
742 * xterm.c (handle_one_xevent): Only set async_visible and friends
743 if net_wm_state_hidden_seen is non-zero (Bug#10002)
744 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
745 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
747 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
749 Remove GCPRO-related macros that exist only to avoid shadowing locals.
750 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
751 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
752 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
753 All uses changed to use GCPRO1 etc.
754 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
755 Revert to old implementation (i.e., before 2011-03-11).
757 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
759 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
760 of scroll runs so as to avoid assigning disabled bogus rows and
761 unnecessary graphics copy operations.
763 2011-11-27 Eli Zaretskii <eliz@gnu.org>
765 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
766 (snprintf) [_MSC_VER]: Redirect to _snprintf.
767 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
768 (malloc, free, realloc, calloc): Redirect to e_* only when
771 * lisp.h (GCTYPEBITS): Move before first use.
772 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
773 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
774 this macro definition.
776 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
779 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
781 * gtkutil.c (xg_create_frame_widgets):
782 Call gtk_window_set_has_resize_grip (FALSE) if that function is
783 present with Gtk+ 2.0.
785 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
787 * fileio.c (Finsert_file_contents): Undo previous change; see
788 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
790 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
792 Rename locals to avoid shadowing.
793 * fileio.c (Finsert_file_contents):
794 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
795 * process.c (wait_reading_process_output):
796 Rename inner 'proc' to 'p' to avoid shadowing.
797 Indent for consistency with usual Emacs style.
799 2011-11-25 Eli Zaretskii <eliz@gnu.org>
801 * xdisp.c (redisplay_window): If cursor row is not fully visible
802 after recentering, and scroll-conservatively is set to a large
803 number, scroll window by a few more lines to make the cursor fully
804 visible and out of scroll-margin. (Bug#10105)
805 (start_display): Don't move to the next line if the display should
806 start at a newline that is part of a display vector or an overlay
809 2011-11-24 Juri Linkov <juri@jurta.org>
811 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
812 after the `MagickPingImage' call. (Bug#10112)
814 2011-11-23 Chong Yidong <cyd@gnu.org>
816 * window.c (Fcoordinates_in_window_p): Accept only live windows.
818 2011-11-23 Martin Rudalics <rudalics@gmx.at>
820 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
821 making another buffer current. (Bug#10114)
823 2011-11-23 Glenn Morris <rgm@gnu.org>
825 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
827 2011-11-23 Chong Yidong <cyd@gnu.org>
829 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
832 2011-11-22 Eli Zaretskii <eliz@gnu.org>
834 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
835 and header-lines, as they don't have one computed for them.
838 * .gdbinit (prow): Make displayed values more self-explaining.
841 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
843 * process.c (wait_reading_process_output): Fix asynchrounous
844 GnuTLS socket handling on some versions of the GnuTLS library.
845 (wait_reading_process_output): Add comment and URL.
847 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
849 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
851 2011-11-21 Chong Yidong <cyd@gnu.org>
853 * window.c (Fnext_window, Fprevious_window): Doc fix.
855 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
857 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
859 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
861 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
863 2011-11-20 Martin Rudalics <rudalics@gmx.at>
865 * window.c (Fset_window_combination_limit): Rename argument
867 (Vwindow_combination_limit): Remove "status" from doc-string.
869 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
871 * m/ibms390.h: Remove.
872 * m/ibms390x.h: Don't include "ibms390.h".
874 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
876 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
877 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
879 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
881 * casetab.c (Fset_case_table):
882 * charset.c (Fcharset_after): Fix typos.
884 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
886 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
887 Otherwise, valgrind does not work on some platforms.
888 Problem reported by Andreas Schwab in
889 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
890 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
891 is set, removing the need for VIRT_ADDRESS_VARIES.
892 (PURE_P): Use a more-efficient implementation that needs just one
893 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
894 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
895 to 4 (xorl, subq, cmpq, setbe).
896 * alloc.c (pure): Always extern now, since that's the
897 VIRT_ADDR_VARIES behavior.
898 (PURE_POINTER_P): Use a single comparison, not two, for
899 consistency with the new puresize.h.
900 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
901 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
902 Remove VIRT_ADDR_VARIES no longer needed.
904 2011-11-19 Eli Zaretskii <eliz@gnu.org>
906 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
907 (erase_phys_cursor, update_window_cursor, show_mouse_face)
908 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
909 behave as if the cursor position were at the window margin.
911 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
912 and the cursor position is out of bounds, behave as if the cursor
913 position were at the window margin. (Bug#10075)
915 2011-11-18 Chong Yidong <cyd@gnu.org>
917 * window.c (Fwindow_combination_limit): Make first argument
918 non-optional, since it is meaningless for live windows like the
921 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
923 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
925 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
927 * intervals.c: Fix grafting over the whole buffer (bug#10071).
928 (graft_intervals_into_buffer): Simplify.
930 2011-11-18 Eli Zaretskii <eliz@gnu.org>
932 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
933 hash values of the two rows.
934 (copy_row_except_pointers): Preserve the used[] arrays and the
935 hash values of the two rows. (Bug#10035)
936 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
938 * xdisp.c (row_hash): New function, body extracted from
939 compute_line_metrics.
940 (compute_line_metrics): Call row_hash, instead of computing the
943 * dispnew.c (verify_row_hash): Call row_hash for computing the
944 hash code of a row, instead of duplicating code from xdisp.c.
946 * dispextern.h (row_hash): Add prototype.
948 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
950 * frame.c (delete_frame): Don't delete the terminal when the last
951 X frame is closed if emacs is built with GTK toolkit.
953 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
955 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
957 2011-11-17 Martin Rudalics <rudalics@gmx.at>
959 * window.c (Vwindow_splits): Rename to
960 Vwindow_combination_resize. Suggested by Juri Linkov.
961 (Fsplit_window_internal): Use Vwindow_combination_resize instead
964 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
966 * nsfns.m (Fns_font_name):
967 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
969 2011-11-16 Martin Rudalics <rudalics@gmx.at>
971 * window.h (window): Rename slot "nest" to "combination_limit".
972 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
973 (Fset_window_nest): Rename to Fset_window_combination_limit.
974 (Vwindow_nest): Rename to Vwindow_combination_limit.
975 (recombine_windows, make_parent_window, make_window)
976 (Fsplit_window_internal, saved_window)
977 (Fset_window_configuration, save_window_save): Rename all
978 occurrences of window_nest to window_combination_limit.
980 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
982 * image.c (imagemagick_load_image): Fix typo.
984 2011-11-14 Eli Zaretskii <eliz@gnu.org>
986 * xdisp.c (display_line): Move the call to
987 highlight_trailing_whitespace before the call to
988 compute_line_metrics, since the latter needs to see the final
989 faces of all the glyphs to compute ROW's hash value.
990 Fixes assertion violations in row_equal_p. (Bug#10035)
992 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
994 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
995 just return (bug#10044).
997 2011-11-12 Eli Zaretskii <eliz@gnu.org>
999 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1000 with user-defined heap size. Bump the default size of the temacs
1001 heap to 27MB, to avoid memory warning when running temacs.
1002 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1004 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1005 current_matrix and desired_matrix. (Bug#9990)
1006 (verify_row_hash) [XASSERTS]: New function.
1007 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1008 that the hash value of glyph rows is correct.
1010 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1012 * window.h (window): Remove splits slot.
1013 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1014 (Fdelete_other_windows_internal, make_parent_window)
1015 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1016 (Fset_window_configuration, save_window_save): Don't deal with
1017 split status of windows.
1018 (saved_window): Remove splits slot.
1019 (Vwindow_splits): Rewrite doc-string.
1021 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1023 * xfns.c (unwind_create_frame):
1024 * nsfns.m (unwind_create_frame):
1025 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1026 Vframe_list (Bug#9999).
1028 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1030 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1032 2011-11-11 Kenichi Handa <handa@m17n.org>
1034 * callproc.c (Fcall_process): Set the member dst_multibyte of
1037 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1039 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1040 avoid a crash (bug#9496).
1042 2011-11-09 Chong Yidong <cyd@gnu.org>
1044 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1045 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1047 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1049 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1051 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1053 Avoid some portability problems by eschewing 'extern inline' functions.
1054 The trivial performance wins aren't worth the portability hassles; see
1055 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1057 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1058 (window_box_width, window_box_left, window_box_left_offset)
1059 (window_box_right, window_box_right_offset): Undo previous change,
1060 by removing the "extern"s.
1061 * intervals.c (adjust_intervals_for_insertion)
1062 (adjust_intervals_for_deletion): Undo previous change,
1063 making these static again.
1064 (offset_intervals, temp_set_point_both, temp_set_point)
1065 (copy_intervals_to_string): No longer inline.
1066 * xdisp.c (window_text_bottom_y, window_box_width)
1067 (window_box_height, window_box_left_offset)
1068 (window_box_right_offset, window_box_left, window_box_right)
1069 (window_box): No longer inline.
1071 2011-11-08 Chong Yidong <cyd@gnu.org>
1073 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1074 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1075 Signal an error if not a live window.
1076 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1077 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1079 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1081 * lisp.h (syms_of_abbrev): Remove declaration.
1082 Reported by CHENG Gao <chenggao@royau.me>.
1084 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1086 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1087 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1088 of temacs in GUI mode.
1090 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1092 * window.h: Declare delete_all_child_windows instead of
1093 delete_all_subwindows.
1094 * window.c (Fwindow_nest, Fset_window_nest)
1095 (Fset_window_new_total, Fset_window_new_normal)
1096 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1097 (delete_all_subwindows): Rename to delete_all_child_windows.
1098 (Fdelete_other_windows_internal, Fset_window_configuration):
1099 Call delete_all_child_windows instead of delete_all_subwindows.
1100 * frame.c (delete_frame): Call delete_all_child_windows instead
1101 of delete_all_subwindows.
1103 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1105 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1106 This is also needed for porting to any host where GC_MARK_STACK is
1107 not GC_MAKE_GCPROS_NOOPS.
1108 (which_symbols): Use it.
1110 2011-11-07 Kenichi Handa <handa@m17n.org>
1112 * coding.c (coding_set_destination): Check coding->src_pos only
1113 when coding->src_object is a buffer (bug#9910).
1115 * process.c (send_process): Set the member src_multibyte of coding
1116 to 0 (bug#9911) when sending a unibyte text.
1118 * callproc.c (Fcall_process): Set the member src_multibyte of
1119 process_coding to 0 (bug#9912).
1121 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1123 * xmenu.c (cleanup_widget_value_tree): New function.
1124 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1125 calling free_menubar_widget_value_tree directly (Bug#9830).
1127 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1129 Fix some portability problems with 'inline'.
1130 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1131 (window_box_width, window_box_left, window_box_left_offset)
1132 (window_box_right, window_box_right_offset): Declare extern.
1133 Otherwise, these inline functions do not conform to C99 and
1134 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1135 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1136 * intervals.c (adjust_intervals_for_insertion)
1137 (adjust_intervals_for_deletion): Now extern, because otherwise the
1138 extern inline functions 'offset_intervals' couldn't refer to it.
1139 (static_offset_intervals): Remove.
1140 (offset_intervals): Rewrite using the old contents of
1141 static_offset_intervals. The old version didn't conform to C99
1142 because an extern inline function contained a reference to an
1143 identifier with static linkage.
1145 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1147 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1150 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1152 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1153 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1154 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1155 return Qleft_to_right.
1157 2011-11-06 Chong Yidong <cyd@gnu.org>
1159 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1160 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1161 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1162 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1163 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1164 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1165 (Fwindow_vscroll): Doc fix.
1166 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1167 argument, since it makes no sense to pass a live window and for
1168 consistency with window-child.
1170 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1172 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1175 2011-11-05 Jason Rumney <jasonr@gnu.org>
1177 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1178 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1180 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1181 bitwise arithmetic preventing use of unicode-sip and non-truetype
1184 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1186 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1189 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1190 initialization code to keep similarity to xfns.c after changes
1193 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1195 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1196 (unwind_create_frame): New function (Bug#9943).
1197 (Fx_create_frame): Restructure code to be more similar to the one in
1198 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1199 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1200 Move terminal->reference_count++ just before making the frame official
1203 * nsterm.m (x_free_frame_resources): New function.
1204 (x_destroy_window): Move code to x_free_frame_resources.
1206 * xfns.c (unwind_create_frame): Fix comment.
1207 (Fx_create_frame, x_create_tip_frame):
1208 Move terminal->reference_count++ just before making the frame
1209 official. Move initialization of image_cache_refcount and
1210 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1212 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1214 Support MSVC build with newer versions of Visual Studio.
1215 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1216 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1219 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1220 which are not supported by MSVC.
1221 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1222 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1224 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1226 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1228 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1230 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1232 Support MSVC build with newer versions of Visual Studio.
1233 * w32.c: Don't include w32api.h for MSVC.
1234 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1236 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1237 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1238 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1239 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1241 (alloca) [_MSC_VER]: Define to _alloca.
1243 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1245 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1247 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1249 * xdisp.c (note_mouse_highlight): If either of
1250 previous/next-single-property-change returns nil, treat that as
1251 the beginning or the end of the buffer. (Bug#9955)
1253 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1255 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1256 label is not null (Bug#9951).
1257 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1260 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1262 * window.c (Fwindow_body_size): Mention in the doc string that the
1263 return value is in frame's canonical units. (Bug#9949)
1265 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1267 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1269 * w32fns.c (unwind_create_frame): If needed, free the glyph
1270 matrices of the partially constructed frame. (Bug#9943)
1271 * xfns.c (unwind_create_frame): Likewise.
1273 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1275 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1276 Don't stop backward scan on the continuation glyph, even though
1277 its CHARPOS is positive.
1278 (mouse_face_from_buffer_pos, note_mouse_highlight):
1279 Rename cover_string to disp_string.
1281 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1283 * window.c (temp_output_buffer_show): Don't use
1284 Vtemp_buffer_show_specifiers.
1285 (Vtemp_buffer_show_specifiers): Remove unused variable.
1287 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1289 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1290 past the beginning of the current glyph matrix.
1292 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1294 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1295 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1296 HAVE_GTK3 (Bug#9869).
1298 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1299 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1301 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1303 * xterm.c: Declare x_handle_net_wm_state to return int.
1304 (handle_one_xevent): Check if we are iconified but don't have
1305 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1306 (get_current_wm_state): Return non-zero if not hidden,
1307 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1308 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1309 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1310 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1312 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1314 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1315 so that this new function doesn't get optimized away by a
1316 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1318 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1320 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1322 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1324 Fix the `xbytecode' command.
1325 * .gdbinit (xprintbytestr): New command.
1326 (xwhichsymbols): Rename from `which'; all callers changed.
1327 (xbytecode): Print the byte-code string as well.
1329 2011-10-29 Kim Storm <storm@cua.dk>
1331 * alloc.c (which_symbols): New function.
1333 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1335 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1338 2011-10-29 Glenn Morris <rgm@gnu.org>
1340 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1341 Not clear what it was for, and it causes various bugs. (Bug#9839)
1343 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1345 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1346 possible random value that matches one of those tested as
1347 condition to clear the mouse face.
1349 2011-10-28 Chong Yidong <cyd@gnu.org>
1351 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1353 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1355 * window.c (make_window): Initialize phys_cursor_on_p.
1357 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1359 * lisp.h (struct Lisp_Symbol): Update comments.
1361 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1363 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1365 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1367 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1368 <oslsachem@gmail.com> for helping to debug this.
1370 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1371 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1372 (g_b_init_get_glyph_outline_w): New static variables.
1373 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1374 (GetGlyphOutlineW_Proc): New typedefs.
1375 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1376 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1378 (w32font_open_internal, compute_metrics):
1379 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1380 instead of calling the "wide" APIs directly.
1382 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1384 * w32.h (syms_of_w32font): Add prototype.
1386 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1388 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1389 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1390 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1391 (Fmove_to_window_line): Doc fix.
1393 2011-10-27 Chong Yidong <cyd@gnu.org>
1395 * process.c (make_process): Set gnutls_state to NULL.
1397 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1398 non-NULL, regardless of GNUTLS_INITSTAGE.
1399 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1400 an error. Set process slots as soon as we allocate them.
1402 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1404 2011-10-27 Chong Yidong <cyd@gnu.org>
1406 * gnutls.c (emacs_gnutls_deinit): New function.
1407 Deallocate credentials structures as well as calling gnutls_deinit.
1408 (Fgnutls_deinit, Fgnutls_boot): Use it.
1410 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1411 (deactivate_process): Call emacs_gnutls_deinit.
1413 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1415 * image.c (x_create_x_image_and_pixmap):
1416 * w32.c (sys_rename, w32_delayed_load):
1417 * w32font.c (fill_in_logfont):
1418 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1420 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1422 * w32fns.c (w32_default_color_map): New function,
1423 extracted from Fw32_default_color_map.
1424 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1426 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1428 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1430 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1432 * keyboard.c (test_undefined): New function (bug#9751).
1433 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1435 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1437 * sysdep.c (init_sys_modes): Fix the check for the controlling
1438 terminal (Bug#6649).
1440 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1442 * dispextern.h (struct bidi_it): New member next_en_type.
1444 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1445 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1446 current character, check also for next_en_type being WEAK_EN.
1447 (bidi_resolve_weak): Don't enter the expensive loop if the current
1448 position is before next_en_pos. Record the bidi type of the first
1449 non-ET, non-BN character we find, in addition to its position.
1450 (bidi_level_of_next_char): Invalidate next_en_type when
1451 next_en_pos is over-stepped.
1453 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1455 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1456 * editfns.c: Rewrite current-time-zone so that it invokes
1457 the equivalent of (format-time-string "%Z") to get the time zone name.
1458 This fixes a bug when the time zone name contains characters that
1459 need converting from the system time locale to Emacs internal format.
1460 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1461 that patch fixed format-time-string to do the conversion, but
1462 I forgot to fix current-time-zone.
1463 (format_time_string): New function, containing most of
1464 what Fformat_time_string used to contain.
1465 (Fformat_time_string): Rewrite in terms of format_time_string.
1466 This doesn't change this function's behavior.
1467 (current-time-zone): Rewrite to use format_time_string.
1468 This fixes the bug reported by Michael Schierl in
1469 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1470 Jason Rumney's 2007-06-07 change worked around this bug, but
1472 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1474 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1476 * xdisp.c (start_display): If the character at POS is displayed
1477 via a display vector, reset IT->current.dpvec_index to zero.
1478 (try_window_reusing_current_matrix): If a line ends in a display
1479 vector or the next line starts in a display vector, continue
1480 redrawing the window even though the character position of
1481 start_row was reached.
1484 2011-10-18 Chong Yidong <cyd@gnu.org>
1486 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1487 with nobreak-char-display too.
1489 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1491 Fix part 3 of bug#9771.
1492 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1493 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1494 non-neutral characters if the current character is a paragraph
1495 separator (a.k.a. Newline). This avoids running the same
1496 expensive loop twice, once when we consume the preceding newline
1497 and the other time when the line actually needs to be displayed.
1498 Avoid the loop when we see neutrals on the base embedding level
1499 following a character whose directionality is the same as the
1500 paragraph's. This avoids running the expensive loop when a line
1501 ends in a long sequence of neutrals, like control characters.
1502 Add assertion against STRONG_AL type. Slightly rearrange code
1503 that determines the type of a neutral given the first non-neutral
1505 (bidi_level_of_next_char): Set next_en_pos to zero when
1506 invalidating its info.
1508 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1510 * xdisp.c (push_display_prop): Determine whether to record string
1511 or buffer position by IT->string, not by IT->method. Allow
1512 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1513 (move_it_vertically_backward): Don't look for character position
1514 immediately after the newline when in a continuation line.
1517 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1519 * window.c (coordinates_in_window): Rewrite and delabelize
1520 vertical border check. (Bug#5357) (Bug#9618)
1522 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1524 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1525 errors in XSetWindowBorder (bug#9310).
1527 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1529 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1530 avoid crash when xmalloc overrun checking is enabled.
1532 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1534 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1535 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1536 cursor motion with <left> and <right> arrow keys.
1538 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1539 some callers set that themselves.
1541 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1543 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1544 display string and the previous row comes from the same string and
1545 is empty. (Bug#9739) (Bug#9738)
1547 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1549 * doc.c (get_doc_string): Encode file name (bug#9735).
1551 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1553 * bidi.c (bidi_level_of_next_char):
1554 * xdisp.c (get_visually_first_element): Remove old incorrect
1555 comments regarding the Unicode Line Separator character.
1557 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1559 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1561 * alloc.c (Fgc_status): Do not access beyond zombies array
1562 boundary if nzombies > MAX_ZOMBIES.
1563 * alloc.c (dump_zombies): Add missing format specifier.
1565 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1567 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1568 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1570 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1571 Some packages use them to denote characters with modifiers.
1573 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1575 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1576 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1577 matching a pp-number. Rename parameter var to var1.
1579 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1581 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1583 2011-10-08 Glenn Morris <rgm@gnu.org>
1585 * callint.c (Fcall_interactively): Give a more explicit error for the
1586 'c' case with a non-character input. (Bug#8479)
1588 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1590 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1592 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1593 lines that are hscrolled on the left.
1595 * dispnew.c (buffer_posn_from_coords): Account for a possible
1596 presence of header-line. (Bug#4426)
1598 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1600 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1601 Don't advertise functionality which we discourage or doesn't work.
1603 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1605 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1606 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1607 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1608 this makes Emacs dump core during garbage collection on rare
1609 occasions. sizeof is obviously inferior to offsetof here, so
1610 stick with offsetof.
1611 (GC_POINTER_ALIGNMENT): New macro.
1612 (mark_memory): Omit 3rd (offset) arg; caller changed.
1613 Don't assume EMACS_INT alignment is the same as pointer alignment.
1615 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1617 * keyboard.c (read_key_sequence_remapped): New var.
1618 (read_key_sequence): Compute remapping in the right buffer.
1619 (command_loop_1): Use read_key_sequence's remapping directly.
1621 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1623 * dired.c (file_name_completion): Don't expand file name.
1624 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1625 before checking file name handler.
1627 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1628 they've been requested explicitly (bug#9591).
1630 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1632 * keymap.c (Fsingle_key_description): Use make_specified_string
1633 instead of build_string to build string from push_key_description.
1636 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1638 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1639 This fixes a Y2038 bug on 64-bit hosts.
1640 * buffer.c (reset_buffer):
1641 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1642 (Fclear_buffer_auto_save_failure):
1643 Use 0, not -1, to represent an unset failure time, since time_t
1644 might not be signed.
1646 Remove dependency on glibc malloc internals.
1647 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1648 Move back here from lisp.h, but with their new implementations.
1649 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1650 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1651 * charset.c (charset_table_init): New static var.
1652 (syms_of_charset): Use it instead of xmalloc. This removes a
1653 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1654 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1655 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1656 Move back to alloc.c.
1657 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1658 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1660 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1662 * nsterm.m (windowDidResize): Call x_set_window_size only when
1663 ns_in_resize is true. Otherwise set pixelwidth/height and
1664 call change_frame_size (Bug#9628).
1666 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1668 Port --enable-checking=all to Fedora 14 x86-64.
1669 * charset.c (syms_of_charset): Also account for glibc malloc's
1670 internal overhead when calculating the initial malloc maximum.
1672 Port --enable-checking=all to Fedora 14 x86.
1673 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1675 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1676 (overrun_check_realloc, overrun_check_free):
1677 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1678 That way, xmalloc returns a properly-aligned pointer even if
1679 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1680 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1681 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1682 into account when calculating the initial malloc maximum.
1683 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1684 Move here from alloc.c, so that charset.c can use it too.
1685 Properly align; the old code wasn't right for common 32-bit hosts
1686 when configured with --enable-checking=all.
1687 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1688 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1690 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1692 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1695 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1697 * xdisp.c (compute_display_string_end): If there's no display
1698 string at CHARPOS, return -1.
1700 * bidi.c (bidi_fetch_char): When compute_display_string_end
1701 returns a negative value, treat the character as a normal
1702 character not covered by a display string. (Bug#9624)
1704 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1706 * lread.c (Fread_from_string): Fix typo in docstring.
1708 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1710 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1711 newline, reseat the iterator instead of bidi-iterating there one
1712 character at a time. (Bug#9610)
1713 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1714 TO_CHARPOS if the bidi iterator is at base embedding level.
1716 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1718 * lread.c (readevalloop): Use correct code for NBSP.
1719 (read1): Likewise. (Bug#9608)
1721 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1723 * dbusbind.c (Fdbus_register_signal): When service is not
1724 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1726 2011-09-25 Glenn Morris <rgm@gnu.org>
1728 * buffer.c (truncate-lines): Doc fix.
1730 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1732 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1733 (Fset_window_next_buffers): Doc fix.
1735 2011-09-24 Glenn Morris <rgm@gnu.org>
1737 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1739 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1741 Fix minor problems found by static checking.
1742 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1743 * indent.c (Fvertical_motion): Fix == vs = typo.
1745 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1747 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1748 Default value is now t. Doc fix.
1750 * indent.c (Fvertical_motion): Compute and apply the overshoot
1751 logic when moving up, not only when moving down. Fix the
1752 confusing name and values of the it_overshoot_expected variable;
1753 logic changes accordingly. (Bug#9254) (Bug#9549)
1755 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1756 CHARPOS is covered by a display string which includes newlines.
1757 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1758 is covered by a display string with embedded newlines.
1760 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1762 * dbusbind.c (Fdbus_register_signal): Add match rule to
1763 Vdbus_registered_objects_table. (Bug#9581)
1764 (Fdbus_register_method, Vdbus_registered_objects_table):
1767 2011-09-24 Jim Meyering <meyering@redhat.com>
1769 do not ignore write error for any output size
1770 The previous change was incomplete.
1771 While it makes emacs --batch detect the vast majority of stdout
1772 write failures, errors were still ignored whenever the output size is
1773 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1774 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1775 && echo FAIL: ignored write error
1776 FAIL: ignored write error
1777 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1778 && echo FAIL: ignored write error
1779 FAIL: ignored write error
1780 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1782 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1784 * emacs.c (Fkill_emacs): In noninteractive mode exit
1785 non-successfully if a write error occurred on stdout. (Bug#9574)
1787 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1789 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1792 * dispextern.h (struct it): Update the comment documenting what
1795 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1797 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1798 a display string, extend search for cursor position to end of row.
1799 (find_row_edges): If the row ends in a newline from a display
1800 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1801 Handle the case of a display string with multiple newlines.
1802 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1803 non-empty line. Fixes confusing cursor motion with arrow keys at
1804 the beginning of a line that starts with whitespace.
1806 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1808 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1811 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1813 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1816 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1818 * xdisp.c (display_line): Record maximum and minimum buffer
1819 positions even if no glyphs were produced (e.g., by a zero-width
1820 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1821 buffer positions that will be removed from the glyph row because
1823 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1824 column is beyond frame width: don't subtract 1 "pixel" when
1825 computing width of the stretch.
1826 (reseat_at_next_visible_line_start): Undo the change made on
1827 2011-09-17 that saved paragraph information and restored it after
1828 the call to `reseat'. (Bug#9545)
1830 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1832 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1833 and turn window cursor on if cleared (Bug#9415).
1835 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1837 * search.c (boyer_moore): Take unibyte characters from pattern
1838 literally. (Bug#9458)
1840 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1842 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1844 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1846 Fix minor problem found by static checking.
1847 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1848 initialized, to pacify gcc -Wuninitialized.
1850 * fileio.c: Report proper errno when syscall falls.
1851 (Finsert_file_contents): Save and restore errno,
1852 so that report_file_error outputs the correct diagnostic.
1853 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1855 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1857 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1859 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1861 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1862 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1864 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1866 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1867 about the current paragraph and restore it after the call to reseat.
1869 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1870 (bidi_find_paragraph_start): Search back for paragraph beginning
1871 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1872 (bidi_move_to_visually_next): Only trigger paragraph-related
1873 computations when the last character is a newline or at EOB, not
1874 just any NEUTRAL_B. (Bug#9470)
1876 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1877 truncated lines if point is covered by a display string. (Bug#9524)
1879 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1881 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1882 (cons_to_x_long): New function.
1883 (lisp_data_to_selection_data): Use it. Correct the test for
1884 short-versus-long data; it was negated. Break out of vector
1885 loop, for efficiency, when a long datum is discovered.
1887 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1889 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1891 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1893 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1894 GCC PR/17406) by declaring this function with external scope.
1896 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1898 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1899 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1901 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1903 * editfns.c (Fformat): Correctly handle text properties on "%%".
1905 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1907 * xterm.c (x_draw_composite_glyph_string_foreground):
1908 * w32term.c (x_draw_composite_glyph_string_foreground):
1909 * term.c (encode_terminal_code):
1910 * composite.c (composition_update_it, get_composition_id):
1911 * xdisp.c (get_next_display_element)
1912 (fill_composite_glyph_string): Add comments about special meaning
1913 of TAB characters in a composition.
1915 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1917 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1918 This occurs when processing a multibyte format.
1919 Problem reported by Wolfgang Jenker.
1921 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1923 * xdisp.c (try_cursor_movement): Only check for exact match if
1924 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1926 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1928 Remove unused external symbols.
1929 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1930 * xdisp.c (calc_pixel_width_or_height): Now static.
1931 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1932 * indent.c (check_display_width):
1933 * w32term.c: Fix comment to match code.
1934 * xterm.c, xterm.h (x_catching_errors): Remove.
1936 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1938 * xselect.c: Use signed conversions more consistently (Bug#9498).
1939 (selection_data_to_lisp_data): Assume incoming selection data are
1940 signed integers, not unsigned. This is to be consistent with
1941 outgoing selection data, which was modified to use signed integers
1942 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1943 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1944 expects long, not unsigned long.
1946 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1948 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1949 computation of loop end. Reported by Johan Bockgård
1952 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1954 * frame.c (Fother_visible_frames_p): Function deleted.
1956 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1958 * indent.c (compute_motion): Process display vector front to back
1959 rather than the other way around. (Bug#2496)
1961 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1963 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1965 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1967 * minibuf.c (Fread_from_minibuffer): Doc fix.
1969 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1971 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1972 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1974 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1976 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1977 value for non-existent files.
1979 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1981 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1982 set its "size" to -1. This will set the modtime_size field of
1983 the corresponding buffer to -1, which is what
1984 verify-visited-file-modtime expects for files that do not exist.
1987 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1989 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1991 * lisp.h: ... from here. push_key_description is no longer
1992 defined in keyboard.c, so its declaration should not be in
1993 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1994 logically belongs with push_key_description.
1996 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1998 * buffer.h: Include <sys/types.h> instead of <time.h>.
1999 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2000 Problem reported by Herbert J. Skuhra.
2002 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2004 * xml.c (parse_region): Make the parsing work for
2005 non-comment-starting XML files again (bug#9144).
2007 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2009 * image.c (gif_load): Fix calculation of bottom and right corner.
2012 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2014 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2015 redisplay in small windows.
2017 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2019 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2021 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2023 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2024 Operate on live windows only.
2026 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2028 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2030 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2032 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2033 only under bidi iteration.
2035 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2037 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2039 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2041 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2042 Without this fix, the command to link temacs failed due to an
2043 undefined symbol __builtin_isnan. This is because
2044 /usr/include/iso/math_c99.h #defines isnan(x) to
2045 __builtin_isnan(x), but the bundled gcc, which identifies itself
2046 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2048 * floatfns.c (isnan): #undef, and then #define to a clone of
2050 (Fisnan): Always define, since it's always available now.
2051 (syms_of_floatfns): Always define isnan at the Lisp level.
2053 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2055 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2057 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2059 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2060 The previous code assumed that file offsets (off_t values) fit in
2061 EMACS_INT variables, which is not true on typical 32-bit hosts.
2062 The code messed up by falsely reporting buffer overflow in cases
2063 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2064 when "big" contains more than 2**29 bytes, even though this
2065 inserts just one byte and does not overflow the buffer.
2066 (Finsert_file_contents): Store file offsets as off_t
2067 values, not as EMACS_INT values. Check for overflow when
2068 converting between EMACS_INT and off_t. When checking for
2069 buffer overflow or for overlap, take the offsets into account.
2070 Don't use EMACS_INT for small values where int suffices.
2071 When checking for overlap, fix a typo: ZV was used where
2072 ZV_BYTE was intended.
2073 (Fwrite_region): Don't assume off_t fits into 'long'.
2074 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2076 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2078 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2080 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2082 sprintf-related integer and memory overflow issues (Bug#9412).
2084 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2085 (esprintf, exprintf, evxprintf): New functions.
2086 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2087 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2088 (modify_event_symbol): Do not assume that the length of
2089 name_alist_or_stem is safe to alloca and fits in int.
2090 (Fexecute_extended_command): Likewise for function name and binding.
2091 (Frecursion_depth): Wrap around reliably on integer overflow.
2092 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2093 since some callers pass EMACS_INT values.
2094 (Fsingle_key_description): Don't crash if symbol name contains more
2095 than MAX_ALLOCA bytes.
2096 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2097 (get_minibuffer): Arg is now EMACS_INT, not int.
2098 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2099 (esprintf, exprintf, evxprintf): New decls.
2100 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2102 * dbusbind.c (signature_cat): New function.
2103 (xd_signature, Fdbus_register_signal):
2104 Do not overrun buffer; instead, report string overflow.
2106 * dispnew.c (add_window_display_history): Don't overrun buffer.
2107 Truncate instead; this is OK since it's just a log.
2109 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2110 even if the time zone offset is outlandishly large.
2111 Don't mishandle offset == INT_MIN.
2113 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2114 when creating daemon; the previous buffer-overflow check was incorrect.
2116 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2117 which has the guts of the old verror function.
2119 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2120 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2122 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2123 (font_unparse_xlfd): Don't blindly alloca long strings.
2124 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2125 fits in int, when using sprintf. Use single snprintf to count
2126 length of string rather than counting it via multiple sprintfs;
2127 that's simpler and more reliable.
2128 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2129 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2130 sprintf, in case result does not fit in int.
2132 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2133 (fontset_from_font): Print it.
2135 * frame.c (tty_frame_count): Now printmax_t, not int.
2136 (make_terminal_frame, set_term_frame_name): Print it.
2137 (x_report_frame_params): In X, window IDs are unsigned long,
2138 not signed long, so print them as unsigned.
2139 (validate_x_resource_name): Check for implausibly long names,
2140 and don't assume name length fits in 'int'.
2141 (x_get_resource_string): Don't blindly alloca invocation name;
2142 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2145 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2146 (xg_check_special_colors, xg_set_geometry):
2147 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2149 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2150 Use esprintf, not sprintf, in case result does not fit in int.
2152 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2153 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2154 it as a large positive number.
2155 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2156 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2158 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2159 in case result does not fit in int.
2161 * print.c (float_to_string): Detect width overflow more reliably.
2162 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2163 buffer overrun. Don't assume list length fits in 'int'. Treat
2164 print length of 0 as 0, not as infinity; to be consistent with other
2165 uses of print length in this function. Don't overflow print length
2166 index. Don't assume hash table size fits in 'long', or that
2167 vectorlike size fits in 'unsigned long'.
2169 * process.c (make_process): Use printmax_t, not int, to format
2170 process-name gensyms.
2172 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2174 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2175 to avoid potential buffer overrun.
2177 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2178 if X resource line is longer than 512 bytes.
2180 * xfns.c (x_window): Make sprintf buffer a bit bigger
2181 to avoid potential buffer overrun.
2183 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2185 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2187 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2189 Integer overflow fixes for scrolling, etc.
2190 Without these, Emacs silently mishandles large integers sometimes.
2191 For example, "C-u 4294967297 M-x recenter" was treated as if
2192 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2194 * xdisp.c (try_window_id): Check Emacs fixnum range before
2195 converting to 'int'.
2197 * window.c (window_scroll_line_based, Frecenter):
2198 Check that an Emacs fixnum is in range before assigning it to 'int'.
2199 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2200 values converted from Emacs fixnums.
2201 (Frecenter): Don't wrap around a line count if it is out of 'int'
2202 range; instead, treat it as an extreme value.
2203 (Fset_window_configuration, compare_window_configurations):
2204 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2206 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2207 that can exceed INT_MAX. Check that EMACS_INT value is in range
2208 before assigning it to the (possibly-narrower) index.
2209 (match_limit): Don't assume that a fixnum can fit in 'int'.
2211 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2214 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2215 (Fvertical_motion): Don't wrap around LINES values that don't fit
2216 in 'int'. Instead, treat them as extreme values. This is good
2217 enough for windows, which can't have more than INT_MAX lines anyway.
2219 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2221 * Require libxml/parser.h to avoid compilation warning.
2223 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2225 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2226 since this reportedly can destroy thread storage.
2228 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2230 * syntax.c (find_defun_start): Update all cache variables if
2231 exiting early (Bug#9401).
2233 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2235 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2237 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2238 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2239 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2241 * term.c (tty_append_glyph): New function.
2242 (produce_stretch_glyph): Static function and its prototype deleted.
2244 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2247 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2249 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2250 when checking :margin (Bug#9390).
2251 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2252 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2253 so that the name doesn't mislead. All uses changed.
2255 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2257 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2260 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2262 * xdisp.c (move_it_to): Don't bail out early when reaching
2263 position beyond to_charpos, if we are scanning backwards.
2264 (move_it_vertically_backward): When DY == 0, make sure we get to
2265 the first character in the line after the newline.
2267 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2269 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2270 (ccl_driver): Do not generate an out-of-range pointer.
2271 (Fccl_execute_on_string): Remove unnecessary check for
2272 integer overflow, noted by Stefan Monnier in
2273 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2274 Remove a FIXME that didn't need fixing.
2275 Simplify the newly-introduced buffer reallocation code.
2277 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2279 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2281 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2283 Integer and memory overflow issues (Bug#9196).
2285 * doc.c (get_doc_string): Rework so that
2286 get_doc_string_buffer_size is the actual buffer size, rather than
2287 being 1 less than the actual buffer size; this makes xpalloc more
2290 * image.c (x_allocate_bitmap_record, cache_image):
2291 * xselect.c (Fx_register_dnd_atom):
2292 Simplify previous changes by using xpalloc.
2294 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2295 since either will do and ptrdiff_t is convenient with xpalloc.
2297 * charset.c (charset_table_size)
2298 (struct charset_sort_data.priority): Now ptrdiff_t.
2299 (charset_compare): Don't overflow if priorities differ greatly.
2300 (Fsort_charsets): Don't assume list length fits in int.
2301 Check for size-calculation overflow when allocating sort data.
2302 (syms_of_charset): Allocate an initial charset table that is
2303 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2305 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2307 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2308 The actual value is always <= INT_MAX, and leaving it unsigned made
2309 overflow checking harder.
2311 * dispextern.h (struct glyph_matrix.rows_allocated)
2312 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2313 with xpalloc. The values are still always <= INT_MAX.
2315 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2317 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2318 (SAFE_NALLOCA): New macro.
2320 * region-cache.c (struct boundary.pos, find_cache_boundary)
2321 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2322 (set_cache_region, invalidate_region_cache)
2323 (revalidate_region_cache, know_region_cache, region_cache_forward)
2324 (region_cache_backward, pp_cache):
2325 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2326 so that ptrdiff_t * can be passed to xpalloc.
2327 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2328 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2329 (pp_cache): Don't assume cache_len fits in int.
2330 * region-cache.h: Adjust extern decls to match.
2332 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2333 EMACS_INT, since either will do, for xpalloc.
2335 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2336 (xnmalloc, xnrealloc, xpalloc): New functions.
2338 * bidi.c (bidi_shelve_header_size): New constant.
2339 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2340 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2342 * bidi.c (bidi_cache_shrink):
2343 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2345 Don't update size of array until after memory allocation succeeds,
2346 because xmalloc/xrealloc may not return.
2347 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2348 now that we have proper integer overflow checking.
2349 (record_overlay_string, overlay_strings): Catch overflows when
2350 calculating size of overlay_str_buf.
2352 * callproc.c (Fcall_process): Check for size overflow when
2353 calculating size of args2.
2354 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2355 Normally we prefer signed values, but sticking with ptrdiff_t would
2356 require adding more-complicated checks.
2358 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2359 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2360 Redo buffer-overflow calculations to avoid integer overflow.
2361 Add a FIXME comment where memory seems to be over-allocated.
2363 * character.c (Fstring): Check for size-calculation overflow.
2365 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2366 unnecessary integer overflow. Check for size overflow.
2367 (encode_coding_object): Don't update size until xmalloc succeeds.
2369 * composite.c (get_composition_id): Check for overflow in glyph
2370 length calculations.
2372 Integer and memory overflow fixes for display code.
2373 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2374 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2375 (scrolling_window): Check for overflow in size calculations.
2376 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2377 Don't assume glyph table len fits in int.
2378 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2379 (row_table_size): Now ptrdiff_t, not int.
2380 (scrolling_window): Avoid overflow in size calculations.
2381 Don't update size until allocation succeeds.
2382 * fns.c (concat): Check for overflow in size calculations.
2383 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2384 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2385 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2387 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2388 (get_doc_string): Check for size calculation overflow.
2389 Don't update size until allocation succeeds.
2390 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2391 EMACS_INT, where ptrdiff_t will do.
2392 (Fsubstitute_command_keys): Check for string overflow.
2394 * editfns.c (set_time_zone_rule): Don't assume environment length
2396 (message_length): Now ptrdiff_t, not int.
2397 (Fmessage_box): Don't update size until allocation succeeds.
2398 Don't assume message length fits in int.
2399 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2401 * emacs.c (main): Do not reallocate argv, since there is a null at
2402 the end that can be overwritten, and this way there's no need to
2403 worry about size-calculation overflow.
2404 (sort_args): Check for size-calculation overflow.
2406 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2408 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2410 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2411 (x_set_scroll_bar_width, x_figure_window_size):
2412 Check for integer overflow.
2413 (x_set_alpha): Do not assume XINT fits in int.
2415 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2416 This is for the members text_lines, text_cols, total_lines, total_cols,
2417 where the system imposes an 'int' limit.
2419 * fringe.c (Fdefine_fringe_bitmap):
2420 Don't update size until alloc works.
2422 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2423 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2425 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2426 Check for size-calculation overflow.
2427 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2428 do, as we prefer signed integers.
2429 (id_to_widget.max_size, id_to_widget.used)
2430 (xg_store_widget_in_map, xg_remove_widget_from_map)
2431 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2432 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2433 Use and return ptrdiff_t, not int.
2434 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2435 * gtkutil.h: Change prototypes to match the above.
2437 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2438 are duplicate now that they've been promoted to lisp.h.
2439 (x_allocate_bitmap_record, x_alloc_image_color)
2440 (make_image_cache, cache_image, xpm_load):
2441 Don't update size until alloc is done.
2442 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2444 Check for size calculation overflow.
2445 (ct_colors_allocated_max): New constant.
2446 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2449 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2450 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2451 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2452 Use ptrdiff_t, not int, to count maps.
2453 (read_char_minibuf_menu_prompt): Check for overflow in size
2454 calculations. Don't update size until allocation succeeds.
2455 Redo calculations to avoid overflow.
2456 * keyboard.h: Change prototypes to match the above.
2458 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2460 (current_minor_maps): Check for size calculation overflow.
2461 * keymap.h: Change prototypes to match the above.
2463 * lread.c (read1, init_obarray): Don't update size until alloc done.
2465 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2466 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2468 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2469 Now ptrdiff_t, not int.
2470 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2471 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2473 * process.c (Fnetwork_interface_list): Check for overflow
2474 in size calculation.
2476 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2478 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2479 overflow. Don't bother calling xmalloc when xrealloc will do.
2481 * search.c (Freplace_match): Check for size calculation overflow.
2482 (Fset_match_data): Don't assume list lengths fit in 'int'.
2484 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2485 for command line length. Do not attempt to address one before the
2486 beginning of an array, as that's not portable.
2488 * term.c (max_frame_lines): Remove; unused.
2489 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2491 (encode_terminal_code, calculate_costs): Check for size
2492 calculation overflow.
2493 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2494 table lengths and related sizes. Don't update size until alloc
2495 done. Redo calculations to avoid overflow.
2496 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2498 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2499 subtracting pointers.
2500 (gobble_line): Check for overflow more carefully. Don't update size
2503 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2504 Don't update size until alloc done.
2505 Redo size calculations to avoid overflow.
2506 Check for size calculation overflow.
2507 (main) [DEBUG]: Fix typo in invoking tparam1.
2509 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2510 Use ptrdiff_t, not int, for sizes.
2511 (store_mode_line_noprop_char): Don't update size until alloc done.
2513 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2514 Use ptrdiff_t, not int, for sizes.
2515 (Finternal_make_lisp_face, cache_face):
2516 Check for size calculation overflow.
2517 (cache_face): Treat size calculation overflows as if they were
2518 memory exhaustion (the usual treatment), rather than aborting.
2520 * xfns.c (x_encode_text, x_set_name_internal)
2521 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2522 sizes, since they can exceed INT_MAX in size. Check for size
2523 calculation overflow.
2525 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2526 (xg_select): Check for size calculation overflow.
2527 Don't update size until alloc done.
2529 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2530 as sprintf is limited to int lengths.
2532 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2533 (X_LONG_MIN): New macros.
2534 Use them to make the following changes clearer.
2535 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2536 This change doesn't affect the value now, but it may help remind
2537 future maintainers not to raise the value too much later.
2538 (SELECTION_QUANTUM): Remove, replacing with ...
2539 (selection_quantum): ... new function, which avoids overflow.
2541 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2542 assumption that selection length fits in 'int'.
2543 (x_reply_selection_request, x_handle_selection_request)
2544 (x_get_window_property, receive_incremental_selection)
2545 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2546 (lisp_data_to_selection_data, clean_local_selection_data):
2547 Use ptrdiff_t, not int, to record length of selection.
2548 (x_reply_selection_request, x_get_window_property)
2549 (receive_incremental_selection, x_property_data_to_lisp):
2550 Redo calculations to avoid overflow.
2551 (x_reply_selection_request): When sending hint, ceiling it at
2552 X_LONG_MAX rather than relying on wraparound overflow to send
2554 (x_get_window_property, receive_incremental_selection)
2555 (lisp_data_to_selection_data, x_property_data_to_lisp):
2556 Check for size-calculation overflow.
2557 (x_get_window_property, receive_incremental_selection)
2558 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2559 Don't store size until memory allocation succeeds.
2560 (x_get_window_property): Plug memory leak on memory exhaustion.
2561 Don't double-block input; malloc is safe here. Don't assume 2**34
2562 - 4 fits in unsigned long. Add an xassert to check
2563 XGetWindowProperty overflow. Be more careful about overflow
2564 calculations, and distinguish size from memory overflow better.
2565 (receive_incremental_selection): When tracing, don't assume
2566 unsigned int is less than INT_MAX.
2567 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2568 harmful) conversions of unsigned short to int.
2569 (lisp_data_to_selection_data): Don't assume that integers
2570 in the range -65535 through -1 fit in an X unsigned short.
2571 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2572 result parameters unless successful. Rely on cons_to_unsigned
2573 to report problems with elements; the old code wasn't right anyway.
2574 (x_check_property_data): Check for int overflow; we cannot use
2575 a wider type due to X limits.
2576 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2578 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2580 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2581 (x_term_init): Check for size calculation overflow.
2582 (x_color_cells): Don't store size until memory allocation succeeds.
2583 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2584 Don't assume alloca size is less than MAX_ALLOCA.
2585 (x_term_init): Don't assume length fits in int (sprintf is limited
2588 Use ptrdiff_t for composition IDs.
2589 * character.c (lisp_string_width):
2590 * composite.c (composition_table_size, n_compositions)
2591 (get_composition_id, composition_gstring_from_id):
2592 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2593 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2594 * window.c (Frecenter):
2595 Use ptrdiff_t, not int, for composition IDs.
2596 * composite.c (get_composition_id): Check for integer overflow.
2597 * composite.h: Adjust prototypes to match the above changes.
2599 Use ptrdiff_t for hash table indexes.
2600 * category.c (hash_get_category_set):
2601 * ccl.c (ccl_driver):
2602 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2603 * coding.c (coding_system_charset_list, detect_coding_system):
2604 * coding.h (struct coding_system.id):
2605 * composite.c (get_composition_id, gstring_lookup_cache):
2606 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2607 * image.c (xpm_get_color_table_h):
2608 * lisp.h (hash_lookup, hash_put):
2609 * minibuf.c (Ftest_completion):
2610 Use ptrdiff_t for hash table indexes, not int (which is too
2611 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2612 32-bit --with-wide-int hosts).
2614 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2615 Add a FIXME comment about memory leaks.
2616 (syms_of_charset): Don't assume xmalloc returns.
2618 Don't assume that stated character widths fit in int.
2619 * character.c (Fchar_width, c_string_width, lisp_string_width):
2620 * character.h (CHAR_WIDTH):
2621 * indent.c (MULTIBYTE_BYTES_WIDTH):
2622 Use sanitize_char_width to avoid undefined and/or bad behavior
2623 with outlandish widths.
2624 * character.h (sanitize_tab_width): Rename from sanitize_width,
2625 now that we have two such functions. All uses changed.
2626 (sanitize_char_width): New inline function.
2628 Don't assume that tab-width fits in int.
2629 * character.h (sanitize_width): New inline function.
2630 (SANE_TAB_WIDTH): New macro.
2631 (ASCII_CHAR_WIDTH): Use it.
2632 * indent.c (sane_tab_width): Remove. All uses replaced by
2633 SANE_TAB_WIDTH (current_buffer).
2634 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2636 * fileio.c: Integer overflow issues with file modes.
2637 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2639 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2640 Remove unreachable code.
2641 (read_hex, load_charset_map_from_file): Check for integer overflow.
2643 * xterm.c: Don't go over XClientMessageEvent limit.
2644 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2645 (x_send_scroll_bar_event): Likewise. Check that the size does not
2646 exceed limits imposed by XClientMessageEvent, as well as the usual
2647 ptrdiff_t and size_t limits.
2649 * keyboard.c: Overflow, signedness and related fixes.
2650 (make_lispy_movement): Use same integer type in forward decl
2651 that is used in the definition.
2652 (read_key_sequence, keyremap_step):
2653 Change bufsize argument back to int, undoing my 2011-03-30 change.
2654 We prefer signed types, and int is wide enough here.
2655 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2656 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2657 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2658 length, not size_t. Use ptrdiff_t for index, not int.
2659 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2660 possibility of integer overflow.
2662 Overflow, signedness and related fixes for images.
2664 * dispextern.h (struct it.stack[0].u.image.image_id)
2665 (struct_it.image_id, struct image.id, struct image_cache.size)
2666 (struct image_cache.used, struct image_cache.ref_count):
2667 * gtkutil.c (update_frame_tool_bar):
2668 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2669 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2670 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2671 * nsmenu.m (update_frame_tool_bar):
2672 * xdisp.c (calc_pixel_width_or_height):
2673 * xfns.c (image_cache_refcount):
2674 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2675 on typical 64-bit hosts.
2677 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2678 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2679 Omit unnecessary casts to int.
2680 (parse_image_spec): Check that integers fall into 'int' range
2681 when the callers expect that.
2682 (image_ascent): Redo ascent calculation to avoid int overflow.
2683 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2684 (lookup_image): Remove unnecessary tests.
2685 (xbm_image_p): Locals are now of int, not EMACS_INT,
2686 since parse_image_check makes sure they fit into int.
2687 (png_load, gif_load, svg_load_image):
2688 Prefer int to unsigned where either will do.
2689 (tiff_handler): New function, combining the cores of the
2690 old tiff_error_handler and tiff_warning_handler.
2691 This function is rewritten to use vsnprintf and thereby avoid
2692 stack buffer overflows. It uses only the features of vsnprintf
2693 that are common to both POSIX and native Microsoft.
2694 (tiff_error_handler, tiff_warning_handler): Use it.
2695 (tiff_load, gif_load, imagemagick_load_image):
2696 Don't assume :index value fits in 'int'.
2697 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2698 (imagemagick_load_image): Check that crop parameters fit into
2699 the integer types that MagickCropImage accepts. Don't assume
2700 Vimagemagick_render_type has a nonnegative value. Don't assume
2701 size_t fits in 'long'.
2702 (gs_load): Use printmax_t to print the widest integers possible.
2703 Check for integer overflow when computing image height and width.
2705 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2707 * xdisp.c (redisplay_window): Don't force window start if point
2708 will be invisible in the resulting window. (Bug#9324)
2710 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2712 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2713 the display spec is of the form `(space ...)'.
2714 (handle_display_spec): Return the value returned by
2715 handle_single_display_spec, not just 1 or zero.
2716 (handle_single_display_spec): If the display spec is of the form
2717 `(space ...)', and specifies display in the text area, return 2
2719 (try_cursor_movement): Check for the need to scroll more
2720 accurately, and prefer exact match for point under bidi.
2721 Don't advance `row' beyond the last row of the window.
2723 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2724 into disp_prop; all users changed.
2726 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2727 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2728 for the text covered by the display property.
2730 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2732 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2733 Change return value to nil.
2734 (Frecord_buffer): Delete unused function.
2736 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2738 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2739 buffers, return left-to-right.
2740 (set_cursor_from_row): Consider candidate row a win if its glyph
2741 represents a newline and point is on that newline. Fixes cursor
2742 positioning on the newline at EOL of R2L text within L2R
2743 paragraph, and vice versa.
2744 (try_cursor_movement): Check continued rows, in addition to
2745 continuation rows. Fixes unwarranted scroll when point enters a
2746 continued line of R2L text within an L2R paragraph, or vice versa.
2747 (cursor_row_p): Consider the case of point being equal to
2748 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2749 from the end of a short line to the beginning of a continued line
2750 of R2L text within L2R paragraph.
2751 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2752 composed characters.
2754 * bidi.c (bidi_check_type): Use xassert.
2755 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2758 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2760 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2763 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2765 * nsfont.m (ns_otf_to_script): Fix typo.
2767 2011-08-22 Kenichi Handa <handa@m17n.org>
2769 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2770 extra slot even if the purpose is char-code-property-table.
2772 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2774 * xdisp.c (redisplay_window): When computing centering_position,
2775 account for the height of the header line. (Bug#8874)
2777 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2778 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2779 candidate is selected by the mouse, and that candidate has a
2780 composed character under the mouse.
2782 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2783 coordinates reported by pos-visible-in-window-p for a composed
2784 character in column zero.
2786 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2788 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2790 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2792 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2793 consider it a hit if to_charpos is anywhere in the range of the
2794 composed buffer positions.
2796 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2798 * image.c (gif_load): Don't assume that each subimage has the same
2799 dimensions as the base image. Handle disposal method that is
2800 "undefined" by the gif spec (Bug#9335).
2802 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2804 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2805 (Fcondition_case): Document `debug' symbol in error handler.
2807 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2809 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2810 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2811 from an Org mode buffer to a Speedbar frame.
2813 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2814 a composition, take its buffer position from IT->cmp_it.charpos.
2815 Fixes cursor positioning at the beginning of a line that begins
2816 with a composed character.
2818 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2820 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2821 character bidirectional type, use STRONG_L instead. Fixes crashes
2822 in a buffer produced by `describe-categories'.
2824 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2825 members before the level stack, so they would be saved and
2826 restored when copying iterator state. Fixes incorrect reordering
2827 around TABs covered by display properties.
2829 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2831 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2833 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2835 * eval.c (internal_condition_case, internal_condition_case_1)
2836 (internal_condition_case_2, internal_condition_case_n):
2837 Remove unnecessary aborts (Bug#9081).
2839 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2841 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2842 has no `load' handler, try opening the file locally. (Bug#9311)
2844 2011-08-16 Ken Brown <kbrown@cornell.edu>
2846 * gmalloc.c: Expand comment.
2848 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2850 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2851 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2853 2011-08-16 Ken Brown <kbrown@cornell.edu>
2855 Fix memory allocation problems in Cygwin build (Bug#9273).
2857 * unexcw.c ( __malloc_initialized): Declare external variable.
2858 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2860 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2862 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2864 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2866 [CYGWIN] (special_realloc): New function.
2867 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2868 requests to realloc storage in the static heap.
2870 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2872 * bidi.c (bidi_initialize): Remove unused local.
2874 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2877 * biditype.h: Remove file.
2878 * makefile.w32-in ($(BLD)/bidi.$(O)):
2879 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2881 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2883 * chartab.c: Improve commentary for the uniprop_table API.
2885 * bidi.c (bidi_paragraph_init): Support zero value of
2886 bidi_ignore_explicit_marks_for_paragraph_level.
2887 (bidi_initialize): Use uniprop_table instead of including
2888 biditype.h and bidimirror.h.
2890 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2891 coordinates of the iterator when restoring from ppos_it.
2894 2011-08-14 Kenichi Handa <handa@m17n.org>
2896 * process.c (create_process): Call setup_process_coding_systems
2897 after the pid of the process is set to -1 (Bug#8162).
2899 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2901 * xdisp.c (move_it_in_display_line_to): Don't invoke
2902 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2903 ppos_it. Fixes vertical cursor motion when line beginning is
2904 covered by an image. (Bug#9296)
2906 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2908 * nsterm.h (ns_run_ascript): Declare.
2909 (NSAPP_DATA2_RUNASSCRIPT): Define.
2911 * nsfns.m (as_script, as_result, as_status): New static variables.
2912 (ns_run_ascript): New function.
2913 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2914 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2915 the event loop. Get status from as_status (Bug#7276).
2917 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2918 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2919 the event loop (Bug#7276).
2921 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2923 * gnutls.c (QCgnutls_bootprop_priority)
2924 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2925 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2926 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2927 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2928 (QCgnutls_bootprop_verify_hostname_error)
2929 (QCgnutls_bootprop_callbacks_verify): Rename from
2930 Qgnutls_bootprop_..., all uses changed.
2932 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2935 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2937 * xfaces.c (Qframe_set_background_mode): Now static.
2938 * dispextern.h (Qframe_set_background_mode): Remove decl.
2940 * process.c (Fnetwork_interface_info): Declare local only if needed.
2942 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2944 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2945 (Fnetwork_interface_list): Allocate in increments of bytes instead
2946 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2947 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2949 (struct ifflag_def): notrailers is smart on OSX.
2950 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2951 Get hardware address with getifaddrs if available.
2953 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2955 * xdisp.c (iterate_out_of_display_property): xassert that
2956 IT->position is set to within IT->object's boundaries. Break from
2957 the loop as soon as EOB is reached; avoids infloops in redisplay
2958 when IT->position is set up wrongly due to some bug.
2959 Set IT->current to match the bidi iterator unconditionally.
2960 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2961 entry. Force push_it to save on the stack the current
2962 buffer/string position, to be restored by pop_it. Fix flags in
2963 the iterator structure wrt the object coming from a display
2964 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2965 properties. (Bug#9284)
2967 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2969 * fontset.c (fontset_get_font_group): Add proper type checks.
2972 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2974 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2975 and LC_VERSION_MIN_MACOSX.
2976 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2977 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2979 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2981 * xdisp.c (forward_to_next_line_start): Allow to use the
2982 no-display-properties-and-no-overlays under bidi display.
2983 Set disp_pos in the bidi iterator to avoid searches for display
2984 properties and overlays.
2986 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2988 * editfns.c (Fset_time_zone_rule): Document relationship with the
2991 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2992 the font entity extracted from the cache (Bug#8109).
2994 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2996 * composite.c (autocmp_chars): Don't reset point. That is done by
2997 restore_point_unwind (Bug#5984).
2999 2011-08-07 Juri Linkov <juri@jurta.org>
3001 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3002 to show the arg `TIME' instead of `TIMEVAL'.
3004 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3006 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3007 display property strides EOL and includes a newline, as in
3008 longlines-mode. (Bug#9254)
3009 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3010 word-wrap under bidirectional display. (Bug#9224)
3012 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3013 is non-zero, even if the data buffer is NULL. Fixes a crash in
3014 vertical-motion with longlines-mode. (Bug#9254)
3016 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3018 * bidi.c <bidi_cache_total_alloc>: Now static.
3019 (bidi_initialize): Initialize bidi_cache_total_alloc.
3021 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3024 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3025 amount allocated this far in `bidi_cache_total_alloc'.
3026 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3027 non-zero, only free the data buffer without restoring the cache
3028 contents. All callers changed.
3030 * dispextern.h (bidi_unshelve_cache): Update prototype.
3032 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3033 (move_it_in_display_line, move_it_to)
3034 (move_it_vertically_backward, move_it_by_lines): Replace the call
3035 to xfree to an equivalent call to bidi_unshelve_cache.
3036 (move_it_in_display_line_to): Fix logic of returning
3037 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3039 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3041 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3042 came from a string character with a `cursor' property. (Bug#9229)
3044 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3046 * Makefile.in (LIB_PTHREAD): New variable.
3047 (LIBES): Add LIB_PTHREAD (Bug#9216).
3049 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3050 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3052 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3054 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3056 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3058 * xterm.c (x_find_topmost_parent): New function.
3059 (x_set_frame_alpha): Find topmost parent window with
3060 x_find_topmost_parent and set the property there also (bug#9181).
3061 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3063 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3065 * callproc.c (Fcall_process): Avoid vfork clobbering
3066 the local vars buffer, coding_systems, current_dir.
3068 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3070 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3072 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3074 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3075 so that it is not optimized away.
3077 * xdisp.c (compute_display_string_pos): Remove unused local.
3079 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3081 Fix slow cursor motion and scrolling in large buffers with
3082 selective display, like Org Mode buffers. (Bug#9218)
3084 * dispextern.h (struct bidi_it): New member disp_prop_p.
3086 * xdisp.c: Remove one-slot cache of display string positions.
3087 (compute_display_string_pos): Accept an additional argument
3088 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3089 for a display string or property. If found, set DISP_PROP_P
3092 * bidi.c (bidi_fetch_char): Accept an additional argument
3093 DISP_PROP_P, and pass it to compute_display_string_pos.
3094 Only handle text covered by a display string if DISP_PROP_P is returned
3095 non-zero. All callers of bidi_fetch_char changed.
3097 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3099 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3101 2010-12-03 Don March <don@ohspite.net>
3103 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3104 last character M-[char] is translated to ESC [char] (bug#7541).
3106 2011-08-02 Kenichi Handa <handa@m17n.org>
3108 * lisp.h (uniprop_table): Extern it.
3110 * chartab.c (uniprop_table): Make it non-static.
3112 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3114 * xdisp.c (forward_to_next_line_start): Accept additional argument
3115 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3117 (reseat_at_next_visible_line_start): Use the bidi iterator state
3118 returned by forward_to_next_line_start to restore the state of
3119 it->bidi_it after backing up to previous newline. (Bug#9212)
3121 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3123 * regex.c (re_comp): Protoize.
3124 (re_exec): Fix return type.
3125 (regexec): Fix type of `ret'. (Bug#9203)
3127 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3129 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3130 This is needed if max-image-size is a floating-point number.
3132 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3134 * print.c (print_object): Print empty symbol as ##.
3136 * lread.c (read1): Read ## as empty symbol.
3138 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3140 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3141 setting frame foreground color (Bug#9175).
3142 (x_set_background_color): Likewise.
3144 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3145 contents (Bug#9176).
3146 (EmacsTooltip -init): Remove bezels and add shadows to
3149 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3150 or scroll bar (Bug#8470).
3152 * nsfont.m (nsfont_open): Remove assignment to voffset and
3153 unnecessary vars hshink, expand, hd, full_height, min_height.
3154 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3156 * nsterm.h (nsfont_info): Remove voffset field.
3158 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3160 Implement strike-through and overline on NextStep (Bug#8863).
3162 * nsfont.m (nsfont_open): Use underline position provided by font,
3163 instead of hard-coded value of 2.
3164 (nsfont_draw): Call ns_draw_text_decoration instead.
3166 * nsterm.h: Add declaration for ns_draw_text_decoration.
3168 * nsterm.m (ns_draw_text_decoration): New function for drawing
3169 underline, overline, and strike-through.
3170 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3171 ns_draw_text_decoration. Change treatment of cursor drawing to
3172 accommodate underlining, etc.
3174 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3176 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3179 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3181 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3182 Without this fix, if a signal arrives just after memory fills up,
3183 'malloc' might be invoked reentrantly.
3185 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3186 In other words, assume that every image size is allowed, on non-X
3187 hosts. This assumption is probably wrong, but it lets Emacs compile.
3189 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3191 * regex.c (re_iswctype): Convert return values to boolean.
3193 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3195 * xdisp.c (compute_display_string_pos): Don't use cached display
3196 string position if the buffer had its restriction changed.
3199 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3201 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3203 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3205 Integer signedness and overflow and related fixes. (Bug#9079)
3207 * bidi.c: Integer size and overflow fixes.
3208 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3209 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3210 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3211 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3212 (bidi_find_other_level_edge):
3213 Use ptrdiff_t instead of EMACS_INT where either will do.
3214 This works better on 32-bit hosts configured --with-wide-int.
3215 (bidi_cache_ensure_space): Check for size-calculation overflow.
3216 Use % rather than repeated addition, for better worst-case speed.
3217 Don't set bidi_cache_size until after xrealloc returns, because it
3219 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3220 (bidi_cache_ensure_space): Also check that the bidi cache size
3221 does not exceed that of the largest Lisp string or buffer. See Eli
3222 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3224 * alloc.c (__malloc_size_t): Remove.
3225 All uses replaced by size_t. See Andreas Schwab's note
3226 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3228 * image.c: Improve checking for integer overflow.
3229 (check_image_size): Assume that f is nonnull, since
3230 it is always nonnull in practice. This is one less thing to
3231 worry about when checking for integer overflow later.
3232 (x_check_image_size): New function, which checks for integer
3233 overflow issues inside X.
3234 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3235 This removes the need for a memory_full check.
3236 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3237 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3238 (xbm_read_bitmap_data): Change locals back to 'int', since
3239 their values must fit in 'int'.
3240 (xpm_load_image, png_load, tiff_load):
3241 Invoke x_create_x_image_and_pixmap earlier,
3242 to avoid much needless work if the image is too large.
3243 (tiff_load): Treat overly large images as if
3244 x_create_x_image_and_pixmap failed, not as malloc failures.
3245 (gs_load): Use x_check_image_size.
3247 * gtkutil.c: Omit integer casts.
3248 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3249 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3251 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3253 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3254 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3255 would wrongly return t on a 64-bit host.
3257 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3258 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3259 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3260 and therefore cause GCC to emit a bogus diagnostic in some cases.
3262 * image.c: Integer signedness and overflow and related fixes.
3263 This is not an exhaustive set of fixes, but it's time to
3264 record what I've got.
3265 (lookup_pixel_color, check_image_size): Remove redundant decls.
3266 (check_image_size): Don't assume that arbitrary EMACS_INT values
3267 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3268 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3269 (tiff_load, imagemagick_load_image):
3270 Check for overflow in size calculations.
3271 (x_create_x_image_and_pixmap): Remove unnecessary test for
3272 xmalloc returning NULL; that can't happen.
3273 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3274 (xpm_color_bucket): Use better integer hashing function.
3275 (xpm_cache_color): Don't possibly over-allocate memory.
3276 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3277 (gif_memory_source):
3278 Use ptrdiff_t, not int or size_t, to record sizes.
3279 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3280 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3281 either works, as we prefer signed integers.
3282 (tiff_read_from_memory, tiff_write_from_memory):
3283 Return tsize_t, not size_t, since that's what the TIFF API wants.
3284 (tiff_read_from_memory): Don't fail simply because the read would
3285 go past EOF; instead, return a short read.
3286 (tiff_load): Omit no-longer-needed casts.
3287 (Fimagemagick_types): Don't assume size fits into 'int'.
3289 Improve hashing quality when configured --with-wide-int.
3290 * fns.c (hash_string): New function, taken from sxhash_string.
3291 Do not discard information about ASCII character case; this
3292 discarding is no longer needed.
3293 (sxhash-string): Use it. Change sig to match it. Caller changed.
3294 * lisp.h: Declare it.
3295 * lread.c (hash_string): Remove, since we now use fns.c's version.
3296 The fns.c version returns a wider integer if --with-wide-int is
3297 specified, so this should help the quality of the hashing a bit.
3299 * emacs.c: Integer overflow minor fix.
3300 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3301 Define only if GNU_LINUX.
3302 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3304 * dispnew.c: Integer signedness and overflow fixes.
3305 Remove unnecessary forward decls, that were a maintenance hassle.
3306 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3308 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3309 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3310 (prepare_desired_row, line_draw_cost):
3311 Use int, not unsigned, where either works.
3312 (save_current_matrix, restore_current_matrix):
3313 Use ptrdiff_t, not size_t, where either works.
3314 (init_display): Check for overflow more accurately, and without
3315 relying on undefined behavior.
3317 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3318 Remove, replacing with the new symbols in lisp.h. All uses changed.
3319 * fileio.c (make_temp_name):
3320 * filelock.c (lock_file_1, lock_file):
3321 * xdisp.c (message_dolog):
3322 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3323 Use pMd etc. instead.
3324 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3325 replacing the pWIDE etc. symbols removed from editfns.c.
3327 * keyboard.h (num_input_events): Now uintmax_t.
3328 This is (very slightly) less likely to mess up due to wraparound.
3331 * buffer.c: Integer signedness fixes.
3332 (alloc_buffer_text, enlarge_buffer_text):
3333 Use ptrdiff_t rather than size_t when either will do, as we prefer
3336 * alloc.c: Integer signedness and overflow fixes.
3337 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3338 (__malloc_size_t): Default to size_t, not to int.
3339 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3340 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3341 Prefer ptrdiff_t to size_t when either would do, as we prefer
3343 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3344 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3345 Now const. Initialize with values that are in range even if char
3347 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3348 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3349 These functions do the right thing with sizes > 2**32.
3350 (check_depth): Now ptrdiff_t, not int.
3351 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3352 Adjust to new way of storing sizes. Check for size overflow bugs
3354 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3355 slightly wrong anyway, as it missed one instance of
3356 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3357 (refill_memory_reserve): Omit needless cast to size_t.
3358 (mark_object_loop_halt): Mark as externally visible.
3360 * xselect.c: Integer signedness and overflow fixes.
3361 (Fx_register_dnd_atom, x_handle_dnd_message):
3362 Use ptrdiff_t, not size_t, since we prefer signed.
3363 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3364 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3365 x_dnd_atoms_size and x_dnd_atoms_length.
3367 * doprnt.c: Prefer signed to unsigned when either works.
3369 * doprnt.c (doprnt):
3371 * xdisp.c (vmessage):
3372 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3373 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3374 prefer signed arithmetic to avoid comparison confusion.
3375 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3376 but is a bit tricky.
3378 Assume freestanding C89 headers, string.h, stdlib.h.
3379 * data.c, doprnt.c, floatfns.c, print.c:
3380 Include float.h unconditionally.
3381 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3382 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3383 * regex.c: Likewise for stddef.h, string.h.
3384 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3385 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3386 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3387 (STDC_HEADERS): Remove obsolete defines.
3388 * sysdep.c: Include limits.h unconditionally.
3390 Assume support for memcmp, memcpy, memmove, memset.
3391 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3392 * regex.c (memcmp, memcpy):
3393 Remove; we assume C89 now.
3395 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3396 (__malloc_safe_bcopy): Remove; no longer needed.
3398 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3399 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3400 well either way, and we prefer signed to unsigned.
3402 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3404 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3405 closes the connection while we're reading (bug#9182).
3407 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3409 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3410 are specified (Bug#9168).
3412 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3414 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3415 Found by GCC static checking and --with-wide-int on a 32-bit host.
3417 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3419 * xdisp.c (compute_display_string_pos): Fix logic of caching
3420 previous display string position. Initialize cached_prev_pos to
3421 -1. Fixes slow-down at the beginning of a buffer.
3423 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3425 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3426 for attrs[LFACE_FONTSET_INDEX].
3428 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3430 * xml.c (parse_region): Remove unused local
3431 that was recently introduced.
3433 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3435 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3436 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3438 * xdisp.c (move_it_in_display_line_to): Record the best matching
3439 position for TO_CHARPOS while scanning the line, and restore it on
3440 exit if none of the characters scanned was an exact match.
3441 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3442 when exact match is impossible due to invisible text, and the
3443 lines are truncated.
3445 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3447 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3450 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3452 Fix a significant slow-down of cursor motion with C-n, C-p,
3453 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3454 auto-repeat under bidi redisplay in fontified buffers.
3455 * xdisp.c (compute_stop_pos_backwards): New function.
3456 (next_element_from_buffer): Call compute_stop_pos_backwards to
3457 find a suitable prev_stop when we find ourselves before
3459 (reseat): Don't look for prev_stop, as that could mean a very long
3461 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3462 <cached_disp_overlay_modiff>: Cache for last found display string
3464 (compute_display_string_pos): Return the cached position if asked
3465 about the same buffer in the same area of character positions, and
3466 the buffer wasn't changed since the time the display string
3467 position was cached.
3469 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3471 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3472 is an integer, which is important for empty lines. (Bug#9149)
3474 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3476 * frame.c (Fmodify_frame_parameters): In tty case, update the
3477 default face if necessary (Bug#4238).
3479 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3481 * editfns.c (Fstring_to_char): No need to explain what a character
3482 is in the docstring (Bug#6576).
3484 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3486 * xml.c (parse_region): Make sure we always return a tree.
3488 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3490 * xml.c (parse_region): If a document contains only comments,
3493 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3495 * xml.c (make_dom): Return comments, too.
3497 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3500 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3501 and the surrounding thread.
3502 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3503 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3504 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3506 * s/openbsd.h (BROKEN_SIGIO): Define.
3507 * unexelf.c (unexec) [__OpenBSD__]:
3508 Don't update the .mdebug section of the Alpha COFF symbol table.
3510 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3512 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3515 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3517 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3518 This fixes some race conditions on the permissions of any newly
3521 * alloc.c (valid_pointer_p): Use pipe, not open.
3522 This fixes some permissions issues when debugging.
3524 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3525 If fchown fails to set both uid and gid, try to set just gid,
3526 as that is sometimes allowed. Adjust the file's mode to eliminate
3527 setuid or setgid bits that are inappropriate if fchown fails.
3529 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3531 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3532 to compare Lisp_Objects.
3533 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3534 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3535 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3537 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3539 * lread.c (read_integer): Unread even EOF character.
3540 (read1): Likewise. Properly record start position of symbol.
3542 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3543 symbol character follows.
3545 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3547 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3548 This works around a problem with the previous change to Fcopy_file.
3549 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3550 and without this change, GCC might complain about discarding
3551 fchown's return value.
3553 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3555 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3557 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3559 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3561 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3563 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3564 it's used from the C level.
3566 * process.c: Use the same condition for POLL_FOR_INPUT in both
3567 keyboard.c and process.c (bug#1858).
3569 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3571 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3572 (Fgnutls_boot): Use it.
3574 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3576 * doc.c (Fsubstitute_command_keys): Revert last change.
3578 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3580 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3581 quotes the next character, and doesn't affect other longer
3582 sequences (bug#8935).
3584 * lread.c (syms_of_lread): Clarify that is isn't only
3585 `eval-buffer' and `eval-defun' that's affected by
3586 `lexical-binding' (bug#8460).
3588 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3590 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3591 bidi redisplay when a line includes both an image and is truncated.
3593 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3595 Fix minor problems found by static checking.
3596 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3597 (elsz): Now a signed constant, not a size_t var. We prefer signed
3598 types to unsigned, to avoid integer comparison confusion. Without
3599 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3600 "cannot optimize loop, the loop counter may overflow", a symptom
3602 * indent.c (Fvertical_motion): Mark locals as initialized.
3603 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3605 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3607 * search.c (Fre_search_backward): Mention `case-fold-search' in
3608 all the re_search_* functions (bug#8138).
3610 * keyboard.c (Fopen_dribble_file): Document when the file is
3613 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3615 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3618 Support bidi reordering of display and overlay strings.
3619 * xdisp.c (compute_display_string_pos)
3620 (compute_display_string_end): Accept additional argument STRING.
3621 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3622 (reseat_to_string): Initialize bidi_it->string.s and
3623 bidi_it->string.schars.
3624 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3625 NULL (avoids a crash in bidi_paragraph_init).
3626 Initialize itb.string.lstring.
3627 (init_iterator): Call bidi_init_it only of a valid
3628 buffer position was specified. Initialize paragraph_embedding to
3630 (reseat_to_string): Initialize the bidi iterator.
3631 (display_string): If we need to ignore text properties of
3632 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3633 original value of -1 will not work with bidi.)
3634 (compute_display_string_pos): First arg is now struct
3635 `text_pos *'; all callers changed. Support display properties on
3637 (compute_display_string_end): Support display properties on Lisp
3639 (init_iterator, reseat_1, reseat_to_string): Initialize the
3640 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3641 when iterating on a string not from display properties).
3642 (compute_display_string_pos, compute_display_string_end):
3643 Fix calculation of the object to scan. Fixes an error when using
3645 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3646 base_level_stop; instead, set base_level_stop to BEGV.
3647 Fixes crashes in vertical-motion.
3648 (next_element_from_buffer): Improve commentary for when
3649 the iterator is before prev_stop.
3650 (init_iterator): Initialize bidi_p from the default value of
3651 bidi-display-reordering, not from buffer-local value. Use the
3652 buffer-local value only if initializing for buffer iteration.
3653 (handle_invisible_prop): Support invisible properties on strings
3654 that are being bidi-reordered.
3655 (set_iterator_to_next): Support bidi reordering of C strings and
3657 (next_element_from_string): Support bidi reordering of Lisp
3659 (handle_stop_backwards): Support Lisp strings as well.
3660 (display_string): Support display of R2L glyph rows.
3661 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3662 (init_iterator): Don't initialize it->bidi_p for strings
3664 (reseat_to_string): Initialize it->bidi_p for strings here.
3665 (next_element_from_string, next_element_from_c_string)
3666 (next_element_from_buffer): Add xassert's for correspondence
3667 between IT's object being iterated and it->bidi_it.string
3669 (face_before_or_after_it_pos): Support bidi iteration.
3670 (next_element_from_c_string): Handle the case of the first string
3671 character that is not the first one in the visual order.
3672 (get_visually_first_element): New function, refactored from common
3673 parts of next_element_from_buffer, next_element_from_string, and
3674 next_element_from_c_string.
3675 (tool_bar_lines_needed, redisplay_tool_bar)
3676 (display_menu_bar): Force left-to-right direction. Add a FIXME
3677 comment for making that be controlled by a user option.
3678 (push_it, pop_it): Save and restore the state of the
3679 bidi iterator. Save and restore the bidi_p flag.
3680 (pop_it): Iterate out of display property for string iteration as
3682 (iterate_out_of_display_property): Support iteration over strings.
3683 (handle_single_display_spec): Set up it->bidi_it for iteration
3684 over a display string, and call bidi_init_it.
3685 (handle_single_display_spec, next_overlay_string)
3686 (get_overlay_strings_1, push_display_prop): Set up the bidi
3687 iterator for displaying display or overlay strings.
3688 (forward_to_next_line_start): Don't use the shortcut if
3690 (back_to_previous_visible_line_start): If handle_display_prop
3691 pushed the iterator stack, restore the internal state of the bidi
3692 iterator by calling bidi_pop_it same number of times.
3693 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3694 and we are bidi-iterating, don't decrement the iterator position;
3695 instead, set the first_elt flag in the bidi iterator, to produce
3697 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3698 (push_display_prop): xassert that we are iterating a buffer.
3699 (push_it, pop_it): Save and restore paragraph_embedding member.
3700 (handle_single_display_spec, next_overlay_string)
3701 (get_overlay_strings_1, reseat_1, reseat_to_string)
3702 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3703 correctly. Don't assume unibyte strings are not bidi-reordered.
3704 (compute_display_string_pos)
3705 (compute_display_string_end): Fix handling the case of C string.
3706 (push_it, pop_it): Save and restore from_disp_prop_p.
3707 (handle_single_display_spec, push_display_prop): Set the
3708 from_disp_prop_p flag.
3709 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3710 (pop_it): Call iterate_out_of_display_property only if we are
3711 popping after iteration over a string that came from a display
3712 property. Fix a typo in popping stretch info. Add an assertion
3713 for verifying that the iterator position is in sync with the bidi
3715 (handle_single_display_spec, get_overlay_strings_1)
3716 (push_display_prop): Fix initialization of paragraph direction for
3717 string when that of the parent object is not yet determined.
3718 (reseat_1): Call bidi_init_it to resync the bidi
3719 iterator with IT's position. (Bug#7616)
3720 (find_row_edges): If ROW->start.pos gives position
3721 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3722 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3723 Reset the from_disp_prop_p flag.
3724 (SAVE_IT, RESTORE_IT): New macros.
3725 (pos_visible_p, face_before_or_after_it_pos)
3726 (back_to_previous_visible_line_start)
3727 (move_it_in_display_line_to, move_it_in_display_line)
3728 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3729 (try_scrolling, redisplay_window, display_line): Use them when
3730 saving a temporary copy of the iterator and restoring it back.
3731 (back_to_previous_visible_line_start, reseat_1)
3732 (init_iterator): Empty the bidi cache "stack".
3733 (move_it_in_display_line_to): If iterator ended up at
3734 EOL, but we never saw any buffer positions smaller than
3735 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3736 motion in bidi-reordered lines.
3737 (move_it_in_display_line_to): Record prev_method and prev_pos
3738 immediately before the call to set_iterator_to_next. Fixes cursor
3739 motion in bidi-reordered lines with stretch glyphs and strings
3740 displayed in margins. (Bug#8133) (Bug#8867)
3741 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3743 (pos_visible_p): Support positions in bidi-reordered lines.
3744 Save and restore bidi cache.
3746 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3747 (bidi_paragraph_info): Delete unused struct.
3748 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3749 (bidi_cache_start): New variable.
3750 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3752 (bidi_cache_fetch_state, bidi_cache_search)
3753 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3754 (bidi_cache_find, bidi_peek_at_next_level)
3755 (bidi_level_of_next_char, bidi_find_other_level_edge)
3756 (bidi_move_to_visually_next): Compare cache index with
3757 bidi_cache_start rather than with zero.
3758 (bidi_fetch_char): Accept new argument STRING; all callers
3759 changed. Support iteration over a string. Support strings with
3760 display properties. Support unibyte strings. Fix the type of
3761 `len' according to what STRING_CHAR_AND_LENGTH expects.
3762 (bidi_paragraph_init, bidi_resolve_explicit_1)
3763 (bidi_resolve_explicit, bidi_resolve_weak)
3764 (bidi_level_of_next_char, bidi_move_to_visually_next):
3765 Support iteration over a string.
3766 (bidi_set_sor_type, bidi_resolve_explicit_1)
3767 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3768 can now be zero (for strings); special values 0 and -1 were
3769 changed to -1 and -2, respectively.
3770 (bidi_char_at_pos): New function.
3771 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3772 Call it instead of FETCH_MULTIBYTE_CHAR.
3773 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3774 initialized to valid values.
3775 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3777 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3778 the test for valid cached positions. Fix the logic for looking up
3779 the sentinel state in the cache. GCPRO the Lisp string we are
3781 (bidi_push_it, bidi_pop_it): New functions.
3782 (bidi_initialize): Initialize the bidi cache start stack pointer.
3783 (bidi_cache_ensure_space): New function, refactored from part of
3784 bidi_cache_iterator_state. Don't assume the required size is just
3785 one BIDI_CACHE_CHUNK away.
3786 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3787 (bidi_count_bytes, bidi_char_at_pos): New functions.
3788 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3789 always valid if bidi_cache_idx is valid.
3790 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3791 is valid if it's going to be used.
3792 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3793 (bidi_cache_fetch_state, bidi_cache_search)
3794 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3795 (bidi_cache_iterator_state, bidi_cache_find)
3796 (bidi_find_other_level_edge, bidi_cache_start_stack):
3797 All variables related to cache indices are now EMACS_INT.
3799 * dispextern.h (struct bidi_string_data): New structure.
3800 (struct bidi_it): New member `string'. Make flag members be 1-bit
3801 fields, and put them last in the struct.
3802 (compute_display_string_pos, compute_display_string_end):
3804 (bidi_push_it, bidi_pop_it): Add prototypes.
3805 (struct iterator_stack_entry): New members bidi_p,
3806 paragraph_embedding, and from_disp_prop_p.
3807 (struct it): Member bidi_p is now a bit field 1 bit wide.
3808 (bidi_shelve_cache, bidi_unshelve_cache):
3811 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3812 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3813 and vector-like objects.
3815 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3816 cache around display iteration.
3818 * window.c (Fwindow_end, window_scroll_pixel_based)
3819 (displayed_window_lines, Frecenter): Save and restore the bidi
3820 cache around display iteration.
3822 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3824 * editfns.c (Fdelete_region): Clarify the use of the named
3825 parameters (bug#6788).
3827 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3829 * indent.c (Fvertical_motion): Set and restore w->pointm when
3830 saving and restoring the window's buffer (Bug#9006).
3832 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3834 * editfns.c (Fstring_to_char): Clarify just what is returned
3835 (bug#6576). Text by Eli Zaretskii.
3837 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3839 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3841 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3843 * buffer.c (mmap_find): Fix a typo.
3845 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3847 Fix execution of x selection hooks.
3848 * xselect.c (Qx_lost_selection_functions)
3849 (Qx_sent_selection_functions): New vars.
3850 (syms_of_xselect): DEFSYM them.
3851 (x_handle_selection_request): Pass Qx_sent_selection_functions
3852 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3853 (x_handle_selection_clear,x_clear_frame_selections):
3854 Pass Qx_lost_selection_functions rather than
3855 Vx_lost_selection_functions to Frun_hook_with_args.
3857 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3859 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3860 The old code sometimes used this field without initializing it.
3862 * alloc.c (gc_sweep): Don't read past end of array.
3863 In theory, the old code could also have corrupted Emacs internals,
3864 though it'd be very unlikely.
3866 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3868 * character.c (Fcharacterp): Don't advertise optional ignored
3869 argument. (Bug#4026)
3871 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3873 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3876 * window.c (Fset_window_start): Doc fix (bug#4199).
3877 (Fset_window_hscroll): Ditto.
3879 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3881 Fix minor new problems caught by GCC 4.6.1.
3882 * term.c (init_tty): Remove unused local.
3883 * xsettings.c (store_monospaced_changed): Define this function only
3884 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3887 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3889 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3891 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3893 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3894 are the mini-buffer and the echo area (bug#3320).
3896 * term.c (init_tty): Remove support for supdup, c10 and perq
3897 terminals, which are no longer supported (bug#1482).
3899 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3901 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3903 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3905 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3906 for non-popups (Bug#3642).
3908 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3910 * alloc.c (reset_malloc_hooks): Protoize.
3911 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3912 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3913 * cm.c (losecursor): Likewise.
3914 * data.c (fmod): Likewise.
3915 * dispnew.c (swap_glyphs_in_rows): Likewise.
3916 * emacs.c (memory_warning_signal): Likewise.
3917 * floatfns.c (float_error): Likewise.
3918 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3919 (otf_open, font_otf_capability, generate_otf_features)
3920 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3922 * image.c (pbm_read_file): Likewise.
3923 * indent.c (string_display_width): Likewise.
3924 * intervals.c (check_for_interval, search_for_interval)
3925 (inc_interval_count, count_intervals, root_interval)
3926 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3927 * lread.c (defalias): Likewise.
3928 * ralloc.c (r_alloc_check): Likewise.
3929 * regex.c (set_image_of_range_1, set_image_of_range)
3930 (regex_grow_registers): Likewise.
3931 * sysdep.c (strerror): Likewise.
3932 * termcap.c (valid_filename_p, tprint, main): Likewise.
3933 * tparam.c (main): Likewise.
3934 * unexhp9k800.c (run_time_remap, save_data_space)
3935 (update_file_ptrs, read_header, write_header, calculate_checksum)
3936 (copy_file, copy_rest, display_header): Likewise.
3937 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3939 * xdisp.c (check_it): Likewise.
3940 * xfaces.c (register_color, unregister_color, unregister_colors):
3942 * xfns.c (print_fontset_result): Likewise.
3943 * xrdb.c (member, fatal, main): Likewise.
3945 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3947 Fix minor problems found by static checking (Bug#9031).
3948 * chartab.c (char_table_set_range, map_sub_char_table):
3949 Remove unused locals.
3950 (uniprop_table): Now static.
3951 * composite.c (_work_char): Remove unused static var.
3953 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3955 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3957 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3959 * gtkutil.c (qttip_cb): Remove code without function.
3961 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3963 * w32.c (pthread_sigmask): New stub.
3965 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3967 Use pthread_sigmask, not sigprocmask (Bug#9010).
3968 sigprocmask is portable only for single-threaded applications, and
3969 Emacs can be multi-threaded when it uses GTK.
3970 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3972 * callproc.c (Fcall_process):
3973 * process.c (create_process):
3974 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3975 Use pthread_sigmask, not sigprocmask.
3977 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3979 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3980 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3983 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3985 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3986 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3987 (xg_hide_tooltip): Fix comment.
3989 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3990 in registerServicesMenuSendTypes.
3991 (validRequestorForSendType): Don't check ns_return_types.
3993 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3996 2011-07-08 Jason Rumney <jasonr@gnu.org>
3998 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3999 SH_SHOW for hidden windows (Bug#5482).
4001 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4002 frame struct members of non-existent frames (Bug#6284).
4004 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4006 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4007 variable firstTime not needed on OSX >= 10.6.
4008 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4009 >= 10.5. Use setKnobProportion, setDoubleValue.
4011 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4012 (MAC_OS_X_VERSION_10_5): Define if not defined.
4013 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4014 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4015 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4017 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4018 cString and lossyCString on OSX >= 10.4
4020 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4021 sizeToFit on OSX >= 10.2.
4023 * nsimage.m (allocInitFromFile): Don't use deprecated method
4024 bestRepresentationForDevice on OSX >= 10.6.
4026 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4029 * emacs.c: Declare unexec_init_emacs_zone.
4031 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4033 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4035 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4036 on svcsMenu (Bug#8842).
4038 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4040 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4042 * nsterm.m (QUTF8_STRING): Declare.
4043 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4044 (validRequestorForSendType): Return type is (id).
4045 Change indexOfObjectIdenticalTo to indexOfObject.
4046 Check if we have local selection before returning self (Bug#8842).
4047 (writeSelectionToPasteboard): Put local selection into paste board
4048 if we have a local selection (Bug#8842).
4049 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4051 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4052 (ns_get_local_selection): Declare.
4054 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4056 * keymap.c (describe_map_tree): Don't insert a double newline at
4057 the end of the buffer (bug#1169) and return whether we inserted
4060 * callint.c (Fcall_interactively): Change "reading args" to
4061 "providing args" to try to clarify what it does (bug#1010).
4063 2011-07-07 Kenichi Handa <handa@m17n.org>
4065 * composite.c (composition_compute_stop_pos): Ignore a static
4066 composition starting before CHARPOS (Bug#8915).
4068 * xdisp.c (handle_composition_prop): Likewise.
4070 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4072 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4075 2011-07-07 Kenichi Handa <handa@m17n.org>
4077 * character.h (unicode_category_t): New enum type.
4079 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4080 (Qchar_code_property_table): New variable.
4081 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4082 (UNIPROP_COMPRESSED_FORM_P): New macros.
4083 (char_table_ascii): Uncompress the compressed values.
4084 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4085 Uncompress the compressed values.
4086 (sub_char_table_ref_and_range): Likewise.
4087 (char_table_ref_and_range): Uncompress the compressed values.
4088 (sub_char_table_set): New arg is_uniprop. Callers changed.
4089 Uncompress the compressed values.
4090 (sub_char_table_set_range): Args changed. Callers changed.
4091 (char_table_set_range): Adjuted for the above change.
4092 (map_sub_char_table): Delete args default_val and parent. Add arg
4093 top. Give decoded values to a Lisp function.
4094 (map_char_table): Adjust for the above change. Give decoded
4095 values to a Lisp function. Gcpro more variables.
4096 (uniprop_table_uncompress)
4097 (uniprop_decode_value_run_length): New functions.
4098 (uniprop_decoder, uniprop_decoder_count): New variables.
4099 (uniprop_get_decoder, uniprop_encode_value_character)
4100 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4102 (uniprop_encoder, uniprop_encoder_count): New variables.
4103 (uniprop_get_encoder, uniprop_table)
4104 (Funicode_property_table_internal, Fget_unicode_property_internal)
4105 (Fput_unicode_property_internal): New functions.
4106 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4107 Sunicode_property_table_internal, Sget_unicode_property_internal,
4108 and Sput_unicode_property_internal. Defvar_lisp
4109 char-code-property-alist.
4111 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4112 Vunicode_category_table.
4114 * font.c (font_range): Adjust for the change of
4115 Vunicode_category_table.
4117 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4119 * m/iris4d.h: Remove file, move contents ...
4120 * s/irix6-5.h: ... here.
4122 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4124 Remove unportable assumption about struct layout (Bug#8884).
4125 * alloc.c (mark_buffer):
4126 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4127 (clone_per_buffer_values): Don't assume that
4128 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4129 This isn't true in general, and it's particularly not true
4130 if Emacs is configured with --with-wide-int.
4131 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4132 New macros, used in the buffer.c change.
4134 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4136 * xsettings.c: Use both GConf and GSettings if both are available.
4137 (store_config_changed_event): Add comment.
4138 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4139 (store_tool_bar_style_changed): New functions.
4140 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4141 (struct xsettings): Move font inside HAVE_XFT.
4142 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4143 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4144 Move inside HAVE_XFT.
4145 (something_changed_gsettingsCB): Rename from something_changedCB.
4146 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4148 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4149 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4150 (something_changed_gconfCB): Rename from something_changedCB.
4151 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4152 (parse_settings): Move check for font inside HAVE_XFT.
4153 (read_settings, apply_xft_settings): Add comment.
4154 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4155 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4156 call store_font_name_changed.
4157 (xft_settings_event): Add comment.
4158 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4159 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4160 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4161 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4162 (xsettings_initialize): Call init_gsettings last.
4163 (xsettings_get_system_font, xsettings_get_system_normal_font):
4166 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4168 Random fixes. E.g., (random) never returned negative values.
4169 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4170 subseconds part to the entropy, as that's a bit more random.
4171 Prefer signed to unsigned, since the signedness doesn't matter and
4172 in general we prefer signed. When given a limit, use a
4173 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4174 latter isn't right if USE_2_TAGS_FOR_INTS.
4175 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4176 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4178 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4180 * textprop.c (text_property_stickiness):
4181 Obey Vtext_property_default_nonsticky.
4182 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4183 * w32fns.c (syms_of_w32fns):
4184 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4186 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4188 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4189 This is more efficient than Ffile_directory_p and avoids a minor race.
4191 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4193 * buffer.c (Foverlay_put): Say what the return value is
4196 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4197 is a directory before asking whether to use the file name
4199 (barf_or_query_if_file_exists): Make the "File is a directory"
4200 error be more correct.
4202 * fns.c (Frequire): Remove the mention of the .gz files, since
4203 that's installation-specific, but keep the mention of
4204 `get-load-suffixes'.
4206 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4208 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4209 Report string overflow if the output is too long.
4211 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4213 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4214 (syms_of_gnutls): Remove duplicate DEFSYM for
4215 Qgnutls_bootprop_verify_hostname_error, an error for
4216 Qgnutls_bootprop_verify_error (which is no longer used).
4218 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4219 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4220 Also (re)move comments that are misplaced or no longer relevant.
4222 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4224 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4226 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4228 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4229 and background color parameters if they have been changed.
4231 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4233 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4235 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4237 * xsettings.c (SYSTEM_FONT): Define only when used.
4238 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4240 * keymap.c (access_keymap_1): Now static.
4242 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4244 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4245 leave any prefix arg for the up event (Bug#1586).
4247 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4249 * lread.c (syms_of_lread): Mention single symbols defined by
4250 `defvar' or `defconst' (bug#7154).
4252 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4253 (Frequire): Mention get-load-suffixes.
4255 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4257 * window.h (window): Remove clone_number slot.
4258 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4260 (make_parent_window, make_window, saved_window)
4261 (Fset_window_configuration, save_window_save): Don't deal with
4263 * buffer.c (Qclone_number): Remove declaration.
4264 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4266 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4268 Add multiple inheritance to keymaps.
4269 * keymap.c (Fmake_composed_keymap): New function.
4270 (Fset_keymap_parent): Simplify.
4271 (fix_submap_inheritance): Remove.
4272 (access_keymap_1): New function extracted from access_keymap to handle
4273 embedded parents and handle lists of maps.
4274 (access_keymap): Use it.
4275 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4276 (Fcopy_keymap): Handle embedded parents.
4277 (Fcommand_remapping, define_as_prefix): Simplify.
4278 (Fkey_binding): Simplify.
4279 (syms_of_keymap): Move minibuffer-local-completion-map,
4280 minibuffer-local-filename-completion-map,
4281 minibuffer-local-must-match-map, and
4282 minibuffer-local-filename-must-match-map to Elisp.
4283 (syms_of_keymap): Defsubr make-composed-keymap.
4284 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4285 (parse_menu_item): Trivial simplification.
4287 2011-07-01 Glenn Morris <rgm@gnu.org>
4289 * Makefile.in (SETTINGS_LIBS): Fix typo.
4291 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4293 * coding.c (Fencode_coding_string): Record the last coding system
4294 used, as the function doc string says (bug#8738).
4296 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4298 * xsettings.c (store_monospaced_changed): Take new font as arg and
4299 check for change against current_mono_font.
4300 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4301 (emacs_settings_constructor, emacs_settings_get_property)
4302 (emacs_settings_set_property, emacs_settings_class_init)
4303 (emacs_settings_init, gsettings_obj): Remove.
4304 (something_changedCB): New function for HAVE_GSETTINGS.
4305 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4306 with value as argument.
4307 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4308 g_settings_new (Bug#8967). Do not create gsettings_obj.
4309 Remove calls to g_settings_bind. Connect something_changedCB to
4312 * xgselect.c: Add defined (HAVE_GSETTINGS).
4313 (xgselect_initialize): Ditto.
4315 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4316 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4319 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4321 * eval.c (struct backtrace): Simplify and port the data structure.
4322 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4323 signed bit field, as this assumption is not portable and it makes
4324 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4325 "char debug_on_exit : 1" as this is not portable either; instead,
4326 use the portable "unsigned int debug_on_exit : 1". Remove unused
4327 member evalargs. Remove obsolete comments about cc bombing out.
4329 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4331 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4332 Let HAVE_GSETTINGS override HAVE_GCONF.
4333 (store_monospaced_changed): New function.
4334 (EMACS_SETTINGS): A new type derived from GObject to handle
4335 GSettings notifications.
4336 (emacs_settings_constructor, emacs_settings_get_property)
4337 (emacs_settings_set_property, emacs_settings_class_init):
4339 (gsettings_client, gsettings_obj): New variables.
4340 (GSETTINGS_SCHEMA): New define.
4341 (something_changedCB): Call store_monospaced_changed.
4342 (init_gsettings): New function.
4343 (xsettings_initialize): Call init_gsettings.
4344 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4347 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4350 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4352 * window.c (resize_root_window, grow_mini_window)
4353 (shrink_mini_window): Rename Qresize_root_window to
4354 Qwindow_resize_root_window and Qresize_root_window_vertically to
4355 Qwindow_resize_root_window_vertically.
4357 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4359 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4361 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4363 * makefile.w32-in: Redesign dependencies so they reflect more
4364 clearly which files are directly included by each source file,
4365 and not through other includes.
4367 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4369 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4370 (sort_overlays, overlay_strings): When an overlay's clone number
4371 matches the window's clone number process the overlay even if
4372 the overlay's window property doesn't match the current window.
4374 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4375 (Fwindow_hchild): Rename to Fwindow_left_child.
4376 (Fwindow_next): Rename to Fwindow_next_sibling.
4377 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4378 (resize_window_check): Rename to window_resize_check.
4379 (resize_window_apply): Rename to window_resize_apply.
4380 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4381 (Fdelete_other_windows_internal, resize_frame_windows)
4382 (Fsplit_window_internal, Fdelete_window_internal)
4383 (grow_mini_window, shrink_mini_window)
4384 (Fresize_mini_window_internal): Fix callers accordingly.
4386 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4388 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4389 (emacs_fixed_set_min_size): Remove.
4390 (emacs_fixed_new): Take frame as argument.
4392 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4393 (_EmacsFixedPrivate): Remove minwidth/height.
4394 Add struct frame *f.
4395 (emacs_fixed_init): Initialize priv->f.
4396 (get_parent_class, emacs_fixed_set_min_size): Remove.
4397 (emacs_fixed_new): Set priv->f to argument.
4398 (emacs_fixed_get_preferred_width)
4399 (emacs_fixed_get_preferred_height): Use min_width/height from
4400 frames size_hint to set minimum and natural (Bug#8919).
4401 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4402 and use min_width/height from frames size_hint to set
4403 min_width/height (Bug#8919).
4405 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4406 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4409 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4411 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4412 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4415 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4417 * process.c (wait_reading_process_output): Bypass select if
4418 waiting for a cell while ignoring keyboard input, and input is
4419 pending. Suggested by Jan Djärv (Bug#8869).
4421 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4423 Use gnulib's dup2 module instead of rolling our own.
4424 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4426 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4428 * dispnew.c (scrolling_window): Before scrolling, turn off a
4429 mouse-highlight in the window being scrolled.
4431 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4433 Move DEFSYM to lisp.h and use everywhere.
4435 * character.h (DEFSYM): Move declaration...
4436 * lisp.h (DEFSYM): ...here.
4442 * w32select.c: Don't include character.h.
4444 * alloc.c (syms_of_alloc):
4445 * buffer.c (syms_of_buffer):
4446 * bytecode.c (syms_of_bytecode):
4447 * callint.c (syms_of_callint):
4448 * casefiddle.c (syms_of_casefiddle):
4449 * casetab.c (init_casetab_once):
4450 * category.c (init_category_once, syms_of_category):
4451 * ccl.c (syms_of_ccl):
4452 * cmds.c (syms_of_cmds):
4453 * composite.c (syms_of_composite):
4454 * dbusbind.c (syms_of_dbusbind):
4455 * dired.c (syms_of_dired):
4456 * dispnew.c (syms_of_display):
4457 * doc.c (syms_of_doc):
4458 * editfns.c (syms_of_editfns):
4459 * emacs.c (syms_of_emacs):
4460 * eval.c (syms_of_eval):
4461 * fileio.c (syms_of_fileio):
4462 * fns.c (syms_of_fns):
4463 * frame.c (syms_of_frame):
4464 * fringe.c (syms_of_fringe):
4465 * insdel.c (syms_of_insdel):
4466 * keymap.c (syms_of_keymap):
4467 * lread.c (init_obarray, syms_of_lread):
4468 * macros.c (syms_of_macros):
4469 * msdos.c (syms_of_msdos):
4470 * print.c (syms_of_print):
4471 * process.c (syms_of_process):
4472 * search.c (syms_of_search):
4473 * sound.c (syms_of_sound):
4474 * syntax.c (init_syntax_once, syms_of_syntax):
4475 * terminal.c (syms_of_terminal):
4476 * textprop.c (syms_of_textprop):
4477 * undo.c (syms_of_undo):
4478 * w32.c (globals_of_w32):
4479 * window.c (syms_of_window):
4480 * xdisp.c (syms_of_xdisp):
4481 * xfaces.c (syms_of_xfaces):
4482 * xfns.c (syms_of_xfns):
4483 * xmenu.c (syms_of_xmenu):
4484 * xsettings.c (syms_of_xsettings):
4485 * xterm.c (syms_of_xterm): Use DEFSYM.
4487 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4489 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4491 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4493 Integer and buffer overflow fixes (Bug#8873).
4495 * print.c (printchar, strout): Check for string overflow.
4496 (PRINTPREPARE, printchar, strout):
4497 Don't set size unless allocation succeeds.
4499 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4500 for sizes. Check for string overflow more accurately.
4501 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4503 * macros.c: Integer and buffer overflow fixes.
4504 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4505 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4506 Use ptrdiff_t, not int, for sizes.
4507 Don't increment bufsize until after realloc succeeds.
4508 Check for size-calculation overflow.
4509 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4511 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4513 * lread.c: Integer overflow fixes.
4514 (read_integer): Radix is now EMACS_INT, not int,
4515 to improve quality of diagnostics for out-of-range radices.
4516 Calculate buffer size correctly for out-of-range radices.
4517 (read1): Check for integer overflow in radices, and in
4518 read-circle numbers.
4519 (read_escape): Avoid int overflow.
4520 (Fload, openp, read_buffer_size, read1)
4521 (substitute_object_recurse, read_vector, read_list, map_obarray):
4522 Use ptrdiff_t, not int, for sizes.
4523 (read1): Use EMACS_INT, not int, for sizes.
4524 Check for size overflow.
4526 * image.c (cache_image): Check for size arithmetic overflow.
4528 * lread.c: Integer overflow issues.
4529 (saved_doc_string_size, saved_doc_string_length)
4530 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4531 Now ptrdiff_t, not int.
4532 (read1): Don't assume doc string length fits in int. Check for
4533 out-of-range doc string lengths.
4534 (read_list): Don't assume file position fits in int.
4535 (read_escape): Check for hex character overflow.
4537 2011-06-22 Leo Liu <sdl.web@gmail.com>
4539 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4540 Move to minibuffer.el.
4542 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4544 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4545 The following patches are for when GLYPH_DEBUG && !XASSERT.
4546 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4547 * dispnew.c (flush_stdout):
4548 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4549 Mark as externally visible.
4550 * dispnew.c (check_window_matrix_pointers): Now static.
4551 * dispnew.c (window_to_frame_vpos):
4552 * xfns.c (unwind_create_frame):
4553 * xterm.c (x_check_font): Remove unused local.
4554 * scroll.c (CHECK_BOUNDS):
4555 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4556 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4557 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4558 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4559 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4561 (debug_method_add): Use va_list and vsprintf rather than relying
4562 on undefined behavior with wrong number of arguments.
4563 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4564 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4565 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4566 since we're not interested in debugging glyphs with old libraries.
4567 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4568 GCC 4.6.0's static checking.
4570 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4572 Integer overflow and signedness fixes (Bug#8873).
4573 A few related buffer overrun fixes, too.
4575 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4577 * dispextern.h (struct face.stipple):
4578 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4579 (x_bitmap_mask, x_allocate_bitmap_record)
4580 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4581 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4582 (x_create_bitmap_from_xpm_data):
4583 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4584 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4586 * xfaces.c (load_pixmap):
4587 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4588 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4589 (.bitmaps_last, struct x_output.icon_bitmap):
4590 Use ptrdiff_t, not int, for bitmap indexes.
4591 (x_allocate_bitmap_record): Check for size overflow.
4592 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4594 Use ptrdiff_t, not int, for overlay counts.
4595 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4596 * editfns.c (overlays_around, get_pos_property):
4597 * textprop.c (get_char_property_and_overlay):
4598 * xdisp.c (next_overlay_change, note_mouse_highlight):
4599 * xfaces.c (face_at_buffer_position):
4600 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4601 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4602 (Fnext_overlay_change, Fprevious_overlay_change)
4603 (mouse_face_overlay_overlaps, Foverlays_in):
4604 Use ptrdiff_t, not int, for sizes.
4605 (overlays_at, overlays_in): Check for size-calculation overflow.
4607 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4609 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4610 (x_session_initialize): Do not assume string length fits in int.
4612 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4613 This is unlikely, but can occur if DPI is outlandish.
4615 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4616 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4618 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4619 * xrdb.c (magic_file_p, search_magic_path):
4620 Omit last arg SUFFIX; it was always 0. All callers changed.
4621 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4623 * xfont.c (xfont_match): Avoid need for strlen.
4625 * xfns.c: Don't assume strlen fits in int.
4626 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4628 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4629 not unsigned long, as we prefer signed integers. All callers changed.
4630 Detect integer overflow in repeat count.
4631 (message_dolog): Don't assume print length fits in 39 bytes.
4632 (display_mode_element): Don't assume strlen fits in int.
4634 * termcap.c: Don't assume sizes fit in int and never overflow.
4635 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4636 (gobble_line): Check for size-calculation overflow.
4638 * minibuf.c (Fread_buffer):
4639 * lread.c (intern, intern_c_string):
4640 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4641 Don't assume string length fits in int.
4643 * keyboard.c (parse_tool_bar_item):
4644 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4646 * font.c: Don't assume string length fits in int.
4647 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4648 Use ptrdiff_t, not int.
4649 (font_intern_prop): Don't assume string length fits in int.
4650 Don't assume integer property fits in fixnum.
4651 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4653 * filelock.c: Fix some buffer overrun and integer overflow issues.
4654 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4655 Reformulate so as not to need the command string.
4656 Invoke gzip -cd rather than gunzip, as it's more portable.
4657 (lock_info_type, lock_file_1, lock_file):
4658 Don't assume pid_t and time_t fit in unsigned long.
4659 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4660 (current_lock_owner): Prefer signed type for sizes.
4661 Use memcpy, not strncpy, where memcpy is what is really wanted.
4662 Don't assume (via atoi) that time_t and pid_t fit in int.
4663 Check for time_t and/or pid_t out of range, e.g., via a network share.
4664 Don't alloca where an auto var works fine.
4666 * fileio.c: Fix some integer overflow issues.
4667 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4668 Don't assume string length fits in int.
4669 (directory_file_name): Don't assume string length fits in long.
4670 (make_temp_name): Don't assume pid fits in int, or that its print
4671 length is less than 20.
4673 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4675 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4677 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4679 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4680 We prefer signed integers, even for size calculations.
4682 * emacs.c: Don't assume string length fits in 'int'.
4683 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4684 (main): Don't invoke strlen when not needed.
4686 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4687 (XD_DEBUG_MESSAGE): Don't waste a byte.
4689 * callproc.c (getenv_internal_1, getenv_internal)
4691 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4693 * lread.c (invalid_syntax): Omit length argument.
4694 All uses changed. This doesn't fix a bug, but it simplifies the
4695 code away from its former Hollerith-constant appearance, and it's
4696 one less 'int' to worry about when looking at integer-overflow issues.
4697 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4699 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4700 This didn't break anything, but it didn't help either.
4701 It's confusing to put a bogus integer in a place where the actual
4702 value does not matter.
4703 (LIST_END_P): Remove unused macro and its bogus comment.
4704 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4706 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4707 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4709 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4710 We prefer signed types, and the value cannot exceed the EMACS_INT
4711 range anyway (because otherwise the length would not be representable).
4712 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4713 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4714 This avoids a GCC warning when WIDE_EMACS_INT.
4716 * indent.c (sane_tab_width): New function.
4717 (current_column, scan_for_column, Findent_to, position_indentation)
4718 (compute_motion): Use it. This is just for clarity.
4719 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4721 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4723 * lisp.h (lint_assume): New macro.
4724 * composite.c (composition_gstring_put_cache):
4725 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4727 * editfns.c, insdel.c:
4728 Omit unnecessary forward decls, to simplify future changes.
4730 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4732 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4734 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4735 Use much-faster test for byte-length change.
4736 Don't assume string byte-length fits in 'int'.
4737 Check that character arg fits in 'int'.
4738 (mapcar1): Declare byte as byte, for clarity.
4740 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4742 * fns.c (concat): Catch string overflow earlier.
4743 Do not rely on integer wraparound.
4745 * dispextern.h (struct it.overlay_strings_charpos)
4746 (struct it.selective): Now EMACS_INT, not int.
4747 * xdisp.c (forward_to_next_line_start)
4748 (back_to_previous_visible_line_start)
4749 (reseat_at_next_visible_line_start, next_element_from_buffer):
4750 Don't arbitrarily truncate the value of 'selective' to int.
4752 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4754 * composite.c: Don't truncate sizes to 'int'.
4755 (composition_gstring_p, composition_reseat_it)
4756 (composition_adjust_point): Use EMACS_INT, not int.
4757 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4758 not EMACS_UINT, for indexes.
4760 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4762 * buffer.c: Include <verify.h>.
4763 (struct sortvec.priority, struct sortstr.priority):
4764 Now EMACS_INT, not int.
4765 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4766 (struct sortstr.size, record_overlay_string)
4767 (struct sortstrlist.size, struct sortlist.used):
4768 Don't truncate size to int.
4769 (record_overlay_string): Check for size-calculation overflow.
4770 (init_buffer_once): Check at compile-time, not run-time.
4772 2011-06-22 Jim Meyering <meyering@redhat.com>
4774 Don't leak an XBM-image-sized buffer
4775 * image.c (xbm_load): Free the image buffer after using it.
4777 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4780 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4781 that Sun C diagnosed.
4782 * fns.c (secure_hash): Fix pointer signedness issue.
4783 * intervals.c (static_offset_intervals): New function.
4784 (offset_intervals): Use it.
4786 2011-06-21 Leo Liu <sdl.web@gmail.com>
4789 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4792 * fns.c (secure_hash): Rename from crypto_hash_function and change
4793 the first arg to accept symbols.
4794 (Fsecure_hash): New primitive.
4795 (syms_of_fns): New symbols.
4797 2011-06-20 Deniz Dogan <deniz@dogan.se>
4799 * process.c (Fset_process_buffer): Clarify return value in
4802 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4804 * dispnew.c (add_window_display_history): Use BVAR.
4806 * xdisp.c (debug_method_add): Use BVAR.
4807 (check_window_end, dump_glyph_matrix, dump_glyph)
4808 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4810 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4813 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4814 check till after the cache is created in init_frame_faces.
4816 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4818 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4820 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4822 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4823 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4824 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4826 Improve buffer-overflow checking (Bug#8873).
4827 * fileio.c (Finsert_file_contents):
4828 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4829 Remove the old (too-loose) buffer overflow checks.
4830 They weren't needed, since make_gap checks for buffer overflow.
4831 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4832 The old code merely checked for Emacs fixnum overflow, and relied
4833 on undefined (wraparound) behavior. The new code avoids undefined
4834 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4836 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4837 Tune. Don't use wider integers than needed. Don't use alloca.
4838 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4840 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4842 * insdel.c, lisp.h (buffer_overflow): New function.
4843 (insert_from_buffer_1, replace_range, replace_range_2):
4844 * insdel.c (make_gap_larger):
4845 * editfns.c (Finsert_char):
4846 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4848 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4850 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4852 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4854 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4855 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4857 * fileio.c: Don't assume EMACS_INT fits in off_t.
4858 (emacs_lseek): New static function.
4859 (Finsert_file_contents, Fwrite_region): Use it.
4860 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4862 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4864 * fns.c: Don't overflow int when computing a list length.
4865 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4866 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4867 truncation on 64-bit hosts. Check for QUIT every
4868 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4869 faster and is responsive enough.
4870 (Flength): Report an error instead of overflowing an integer.
4871 (Fsafe_length): Return a float if the value is not representable
4872 as a fixnum. This shouldn't happen except in contrived situations.
4873 (Fnthcdr, Fsort): Don't assume list length fits in int.
4874 (Fcopy_sequence): Don't assume vector length fits in int.
4876 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4877 (header_size, word_size): New constants.
4878 (allocate_vectorlike): Don't check size overflow here.
4879 (allocate_vector): Check it here instead, since this is the only
4880 caller of allocate_vectorlike that could cause overflow.
4881 Check that the new vector's length is representable as a fixnum.
4883 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4884 The previous code was bogus. For example, next_almost_prime (32)
4885 returned 39, which is undesirable as it is a multiple of 3; and
4886 next_almost_prime (24) returned 25, which is a multiple of 5 so
4887 why was the code bothering to check for multiples of 7?
4889 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4891 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4893 Variadic C functions now count arguments with ptrdiff_t.
4894 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4895 Back then I didn't know that the Emacs coding style prefers signed int.
4896 Also, in the meantime I found a few more instances where arguments
4897 were being counted with int, which may truncate counts on 64-bit
4898 machines, or EMACS_INT, which may be unnecessarily wide.
4899 * lisp.h (struct Lisp_Subr.function.aMANY)
4900 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4901 Arg counts are now ptrdiff_t, not size_t.
4902 All variadic functions and their callers changed accordingly.
4903 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4904 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4905 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4906 * callint.c (Fcall_interactively): Check arg count for overflow,
4907 to avoid potential buffer overrun. Use signed char, not 'int',
4908 for 'varies' array, so that we needn't bother to check its size
4909 calculation for overflow.
4910 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4911 * eval.c (apply_lambda):
4912 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4913 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4914 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4916 * callint.c (Fcall_interactively): Don't use index var as event count.
4918 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4919 * mem-limits.h (SIZE): Remove; no longer used.
4921 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4923 Remove unnecessary casts.
4924 * xterm.c (x_term_init):
4925 * xfns.c (x_set_border_pixel):
4926 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4927 These aren't needed now that we assume ANSI C.
4929 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4930 It's more likely to cause problems (due to unsigned overflow)
4933 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4935 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4937 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4939 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4941 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4943 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4945 GLYPH_CODE_FACE returns EMACS_INT, not int.
4946 * dispextern.h (merge_faces):
4947 * xfaces.c (merge_faces):
4948 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4949 Don't assume EMACS_INT fits in int.
4951 * character.h (CHAR_VALID_P): Remove unused parameter.
4952 * fontset.c, lisp.h, xdisp.c: All uses changed.
4954 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4956 * fns.c (concat): Minor tuning based on overflow analysis.
4957 This doesn't fix any bugs. Use int to hold character, instead
4958 of constantly refetching from Emacs object. Use XFASTINT, not
4959 XINT, for value known to be a character. Don't bother comparing
4960 a single byte to 0400, as it's always less.
4962 * floatfns.c (Fexpt):
4963 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4965 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4968 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4970 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4971 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4972 incorrectly succeed when S was a string, because 4294967386 was
4973 truncated before it was used.
4975 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4976 Otherwise, an out-of-range integer could cause undefined behavior
4979 * composite.c: Use int, not EMACS_INT, for characters.
4980 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4981 EMACS_INT, for values that are known to be in character range.
4982 This doesn't fix any bugs but is the usual style inside Emacs and
4983 may generate better code on 32-bit machines.
4985 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4986 This is for reasons similar to the recent CHAR_STRING fix.
4987 * charset.c (Fencode_char): Check that character arg is actually
4988 a character. Pass an int to ENCODE_CHAR.
4989 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4990 wider than 'int', as a compile-time check to prevent future regressions
4993 * character.c (char_string): Remove unnecessary casts.
4995 Make sure a 64-bit char is never passed to CHAR_STRING.
4996 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4997 by silently ignoring the top 32 bits, allowing some values
4998 that were far too large to be valid characters.
4999 * character.h: Include <verify.h>.
5000 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5001 arguments are no wider than unsigned, as a compile-time check
5002 to prevent future regressions in this area.
5004 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5005 (Fsubst_char_in_region):
5007 * xdisp.c (decode_mode_spec_coding):
5008 Adjust to CHAR_STRING's new requirement.
5009 * editfns.c (Finsert_char, Fsubst_char_in_region):
5010 * fns.c (concat): Check that character args are actually
5011 characters. Without this test, these functions did the wrong
5012 thing with wildly out-of-range values on 64-bit hosts.
5014 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5015 These casts should not be needed on 32-bit hosts, either.
5016 * keyboard.c (read_char):
5017 * lread.c (Fload): Remove casts to unsigned.
5019 * lisp.h (UNSIGNED_CMP): New macro.
5020 This fixes comparison bugs on 64-bit hosts.
5021 (ASCII_CHAR_P): Use it.
5022 * casefiddle.c (casify_object):
5023 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5024 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5025 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5026 * dispextern.h (FACE_FROM_ID):
5027 * keyboard.c (read_char): Use UNSIGNED_CMP.
5029 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5030 not to EMACS_INT, to avoid GCC warning.
5032 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5034 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5035 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5036 isn't needed on 32-bit machines.
5038 * buffer.c (Fgenerate_new_buffer_name):
5039 Use EMACS_INT for count, not int.
5040 (advance_to_char_boundary): Return EMACS_INT, not int.
5042 * data.c (Qcompiled_function): Now static.
5044 * window.c (window_body_lines): Now static.
5046 * image.c (gif_load): Rename local to avoid shadowing.
5048 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5049 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5050 * alloc.c (make_save_value): Integer argument is now of type
5052 (mark_object): Use ptrdiff_t, not int.
5053 * lisp.h (pD): New macro.
5054 * print.c (print_object): Use it.
5056 * alloc.c: Use EMACS_INT, not int, to count objects.
5057 (total_conses, total_markers, total_symbols, total_vector_size)
5058 (total_free_conses, total_free_markers, total_free_symbols)
5059 (total_free_floats, total_floats, total_free_intervals)
5060 (total_intervals, total_strings, total_free_strings):
5061 Now EMACS_INT, not int. All uses changed.
5062 (Fgarbage_collect): Compute overall total using a double, so that
5063 integer overflow is less likely to be a problem. Check for overflow
5064 when converting back to an integer.
5065 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5066 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5067 These were 'int' variables that could overflow on 64-bit hosts;
5068 they were never used, so remove them instead of repairing them.
5069 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5070 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5071 Previously, this ceilinged at INT_MAX, but that doesn't work on
5073 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5075 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5076 (allocate_vectorlike): Check for ptrdiff_t overflow.
5077 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5078 when a (possibly-narrower) signed value would do just as well.
5079 We prefer using signed arithmetic, to avoid comparison confusion.
5081 * alloc.c: Catch some string size overflows that we were missing.
5082 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5083 for convenience in STRING_BYTES_MAX.
5084 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5085 The definition here is exact; the one in lisp.h was approximate.
5086 (allocate_string_data): Check for string overflow. This catches
5087 some instances we weren't catching before. Also, it catches
5088 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5089 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5090 and ptrdiff_t and EMACS_INT are both 64 bits.
5092 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5093 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5094 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5096 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5098 * alloc.c (Fmake_string): Check for out-of-range init.
5100 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5102 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5104 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5106 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5107 xg_get_default_scrollbar_width.
5109 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5110 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5111 (style_changed_cb): Call update_theme_scrollbar_width and call
5112 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5113 all frames (Bug#8505).
5114 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5115 Call gtk_window_set_resizable if HAVE_GTK3.
5116 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5117 and height if HAVE_GTK3 (Bug#8505).
5118 (scroll_bar_width_for_theme): New variable.
5119 (update_theme_scrollbar_width): New function.
5120 (xg_get_default_scrollbar_width): Move code to
5121 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5122 (xg_initialize): Call update_theme_scrollbar_width.
5124 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5126 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5128 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5130 * frame.c (make_frame): Call other_buffer_safely instead of
5133 * window.c (temp_output_buffer_show): Call display_buffer with
5134 second argument Vtemp_buffer_show_specifiers and reset latter
5135 immediately after the call.
5136 (Vtemp_buffer_show_specifiers): New variable.
5137 (auto_window_vscroll_p, next_screen_context_lines)
5138 (Vscroll_preserve_screen_position): Remove leading asterisks from
5141 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5143 Fix minor problems found by GCC 4.6.0 static checking.
5144 * buffer.c (Qclone_number): Remove for now, as it's unused.
5145 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5146 (record_buffer): Remove unused local.
5147 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5148 (set_frame_buffer_list): Remove; unused.
5149 * frame.h (other_visible_frames): Remove decl.
5150 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5151 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5152 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5154 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5155 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5156 Define only if HAVE_GPM.
5157 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5158 (update_hints_inhibit): Remove; never set. All uses removed.
5159 * widgetprv.h (emacsFrameClassRec): Remove decl.
5160 * window.c (delete_deletable_window): Now returns void, since it
5161 wasn't returning anything.
5162 (compare_window_configurations): Remove unused locals.
5163 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5164 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5165 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5166 the same widths as pointers. This follows up on the 2011-05-06 patch.
5167 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5168 * xterm.h: Likewise.
5169 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5171 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5173 * makefile.w32-in: Update dependencies.
5174 (LISP_H): Add lib/intprops.h.
5176 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5178 * image.c (gif_load): Add animation frame delay to the metadata.
5179 (syms_of_image): Use DEFSYM. New symbol `delay'.
5181 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5183 * window.c (delete_deletable_window): Re-add.
5184 (Fset_window_configuration): Rewrite to handle dead buffers and
5185 consequently deletable windows.
5186 (window_tree, Fwindow_tree): Remove. Supply functionality in
5188 (compare_window_configurations): Simplify code.
5190 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5192 * image.c (imagemagick_load_image): Fix type mismatch.
5193 (Fimagemagick_types): Likewise.
5195 * window.h (replace_buffer_in_windows): Declare.
5197 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5199 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5200 Qclone_number. Remove external declaration of Qdelete_window.
5201 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5203 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5204 Run Qbuffer_list_update_hook if allowed.
5205 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5206 buffer list implementation.
5207 (other_buffer_safely): New function.
5208 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5209 calls to replace_buffer_in_windows and
5210 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5212 (record_buffer): Inhibit quitting and rewrite using quittable
5213 functions. Run Qbuffer_list_update_hook if allowed.
5214 (Frecord_buffer, Funrecord_buffer): New functions.
5215 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5216 Move switch-to-buffer to window.el.
5217 (bury-buffer): Move to window.el.
5218 (Vbuffer_list_update_hook): New variable.
5220 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5223 * window.h (resize_frame_windows): Move up in code.
5224 (Fwindow_frame): Remove EXFUN.
5225 (replace_buffer_in_all_windows): Remove prototype.
5226 (replace_buffer_in_windows_safely): Add prototype.
5228 * window.c: Declare Qdelete_window static again. Move down
5229 declaration of select_count.
5230 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5231 (Fother_window): Move to window.el.
5232 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5233 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5234 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5236 (replace_buffer_in_windows): Implement by calling
5237 Qreplace_buffer_in_windows.
5238 (replace_buffer_in_all_windows): Remove with some functionality
5239 moved into replace_buffer_in_windows_safely.
5240 (replace_buffer_in_windows_safely): New function.
5241 (select_window_norecord, select_frame_norecord): Move in front
5242 of run_window_configuration_change_hook. Remove now obsolete
5244 (Fset_window_buffer): Rewrite doc-string.
5245 Call Qrecord_window_buffer.
5246 (keys_of_window): Move binding for other-window to window.el.
5248 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5250 * dispextern.h (struct image): Replace data member, whose int_val
5251 and ptr_val fields were not used by anything, with a single
5254 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5255 (gif_clear_image, gif_load, imagemagick_load_image)
5256 (gs_clear_image, gs_load): Callers changed.
5258 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5260 * buffer.h: Include <time.h>, for time_t.
5261 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5263 Fix minor problems found by static checking.
5265 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5267 Make identifiers static if they are not used in other modules.
5268 * data.c (Qcompiled_function, Qframe, Qvector):
5269 * image.c (QimageMagick, Qsvg):
5270 * minibuf.c (Qmetadata):
5271 * window.c (resize_window_check, resize_root_window): Now static.
5272 * window.h (resize_window_check, resize_root_window): Remove decls.
5274 * window.c (window_deletion_count, delete_deletable_window):
5276 (window_body_lines): Now static.
5277 (Fdelete_other_windows_internal): Mark vars as initialized.
5278 Make sure 'resize_failed' is initialized.
5279 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5280 (resize_window_apply): Remove unused local.
5281 * window.h (delete_deletable_window): Remove decl.
5283 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5284 (imagemagick_load_image): Fix pointer signedness problem by changing
5285 last arg from unsigned char * to char *. All uses changed.
5286 Also, fix a local for similar reasons.
5287 Remove unused locals. Remove locals to avoid shadowing.
5288 (fn_rsvg_handle_free): Remove; unused.
5289 (svg_load, svg_load_image): Fix pointer signedness problem.
5290 (imagemagick_load_image): Don't use garbage pointer image_wand.
5292 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5294 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5296 * image.c (gif_load): Fix omitted cast error introduced by
5299 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5301 * window.h (resize_proportionally, orig_total_lines)
5302 (orig_top_line): Remove from window structure.
5303 (set_window_height, set_window_width, change_window_heights)
5304 (Fdelete_window): Remove prototypes.
5305 (resize_frame_windows): Remove duplicate declaration.
5307 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5309 * window.h (resize_frame_windows, resize_window_check)
5310 (delete_deletable_window, resize_root_window)
5311 (resize_frame_windows): Declare prototypes.
5313 * window.c (resize_window_apply): Make definition be "static" to
5314 match the prototype.
5316 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5318 * window.c: Remove declarations of Qwindow_size_fixed,
5319 window_min_size_1, window_min_size_2, window_min_size,
5320 size_window, window_fixed_size_p, enlarge_window, delete_window.
5321 Remove static from declaration of Qdelete_window, it's
5322 temporarily needed by Fbury_buffer.
5323 (replace_window): Don't assign orig_top_line and
5325 (Fdelete_window, delete_window): Remove. Window deletion is
5326 handled by window.el.
5327 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5328 Replace Fdelete_window calls with calls to Qdelete_window.
5329 (Fdelete_other_windows): Remove. Deleting other windows is
5330 handled by window.el.
5331 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5332 handled in window.el.
5333 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5334 Window minimum sizes are handled in window.el.
5335 (shrink_windows, size_window, set_window_height)
5336 (set_window_width, change_window_heights, window_height)
5337 (window_width, CURBEG, CURSIZE, enlarge_window)
5338 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5339 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5340 handled in window.el.
5341 (make_dummy_parent): Rename to make_parent_window and give it a
5342 second argument horflag.
5343 (make_window): Don't set resize_proportionally any more.
5344 (Fsplit_window): Remove. Windows are split in window.el.
5345 (save_restore_action, save_restore_orig_size)
5346 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5347 Resize mini windows in window.el.
5348 (grow_mini_window, shrink_mini_window): Implement by calling
5349 Qresize_root_window_vertically, resize_window_check and
5350 resize_window_apply.
5351 (saved_window, Fset_window_configuration, save_window_save):
5352 Do not handle orig_top_line, orig_total_lines, and
5353 resize_proportionally.
5354 (window_min_height, window_min_width): Move to window.el.
5355 (keys_of_window): Move bindings for delete-other-windows,
5356 split-window, delete-window and enlarge-window to window.el.
5358 * buffer.c: Temporarily extern Qdelete_window.
5359 (Fbury_buffer): Temporarily call Qdelete_window instead of
5360 Fdelete_window (Fbury_buffer will move to window.el soon).
5362 * frame.c (set_menu_bar_lines_1): Remove code handling
5363 orig_top_line and orig_total_lines.
5365 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5366 set_window_height but set heights directly.
5367 (change_frame_size_1): Use resize_frame_windows.
5369 * xdisp.c (init_xdisp): Don't use set_window_height but set
5372 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5373 Use resize_frame_windows instead of change_window_heights and run
5374 run_window_configuration_change_hook.
5376 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5377 instead of change_window_heights and run
5378 run_window_configuration_change_hook.
5380 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5382 * window.c (replace_window): Rename second argument REPLACEMENT to
5383 NEW. New third argument SETFLAG. Rewrite.
5384 (delete_window, make_dummy_parent): Call replace_window with
5386 (window_list_1): Move down in code.
5387 (run_window_configuration_change_hook): Move set_buffer part
5388 before select_frame_norecord part in order to unwind correctly.
5389 Rename count1 to count.
5390 (recombine_windows, delete_deletable_window, resize_root_window)
5391 (Fdelete_other_windows_internal)
5392 (Frun_window_configuration_change_hook, make_parent_window)
5393 (resize_window_check, resize_window_apply, Fresize_window_apply)
5394 (resize_frame_windows, Fsplit_window_internal)
5395 (Fdelete_window_internal, Fresize_mini_window_internal):
5397 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5399 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5401 * window.h (window): Add some new members to window structure -
5402 normal_lines, normal_cols, new_total, new_normal, clone_number,
5403 splits, nest, prev_buffers, next_buffers.
5404 (WINDOW_TOTAL_SIZE): Move here from window.c.
5405 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5407 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5409 (make_dummy_parent): Set new members of windows structure.
5410 (make_window): Move down in code. Handle new members of window
5412 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5413 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5414 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5415 (Fset_window_prev_buffers, Fwindow_next_buffers)
5416 (Fset_window_next_buffers, Fset_window_clone_number):
5418 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5419 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5421 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5422 Argument WINDOW can be now internal window too.
5423 (Fwindow_use_time): Move up in code.
5424 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5426 (Fset_window_configuration, saved_window)
5427 (Fcurrent_window_configuration, save_window_save): Handle new
5428 members of window structure.
5429 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5430 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5431 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5432 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5433 Qget_mru_window, Qresize_root_window,
5434 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5435 Qauto_buffer_name; staticpro them.
5437 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5439 * window.c (Fwindow_total_size, Fwindow_left_column)
5440 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5441 (Fwindow_list_1): New functions.
5442 (window_box_text_cols): Replace with window_body_cols.
5443 (Fwindow_width, Fscroll_left, Fscroll_right):
5444 Use window_body_cols instead of window_box_text_cols.
5445 (delete_window, Fset_window_configuration):
5446 Call delete_all_subwindows with window as argument.
5447 (delete_all_subwindows): Take a window as argument and not a
5449 (window_loop): Remove handling of GET_LRU_WINDOW and
5451 (Fget_lru_window, Fget_largest_window): Move to window.el.
5453 * window.h: Extern window_body_cols instead of
5454 window_box_text_cols. delete_all_subwindows now takes a
5455 Lisp_Object as argument.
5457 * indent.c (compute_motion, Fcompute_motion):
5458 Use window_body_cols instead of window_box_text_cols.
5460 * frame.c (delete_frame): Call delete_all_subwindows with root
5463 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5465 * fns.c (Fputhash): Document return value.
5467 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5469 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5471 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5473 Cons<->int and similar integer overflow fixes (Bug#8794).
5475 Check for overflow when converting integer to cons and back.
5476 * charset.c (Fdefine_charset_internal, Fdecode_char):
5477 Use cons_to_unsigned to catch overflow.
5478 (Fencode_char): Use INTEGER_TO_CONS.
5479 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5480 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5481 * data.c (long_to_cons, cons_to_long): Remove.
5482 (cons_to_unsigned, cons_to_signed): New functions.
5483 These signal an error for invalid or out-of-range values.
5484 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5485 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5486 * font.c (Ffont_variation_glyphs):
5487 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5488 * lisp.h: Include <intprops.h>.
5489 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5490 (cons_to_signed, cons_to_unsigned): New decls.
5491 (long_to_cons, cons_to_long): Remove decls.
5492 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5493 (Fprimitive_undo): Use CONS_TO_INTEGER.
5494 * xfns.c (Fx_window_property): Likewise.
5495 * xselect.c: Include <limits.h>.
5496 (x_own_selection, selection_data_to_lisp_data):
5497 Use INTEGER_TO_CONS.
5498 (x_handle_selection_request, x_handle_selection_clear)
5499 (x_get_foreign_selection, Fx_disown_selection_internal)
5500 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5501 (lisp_data_to_selection_data): Use cons_to_unsigned.
5502 (x_fill_property_data): Use cons_to_signed.
5503 Report values out of range.
5505 Check for buffer and string overflow more precisely.
5506 * buffer.h (BUF_BYTES_MAX): New macro.
5507 * lisp.h (STRING_BYTES_MAX): New macro.
5508 * alloc.c (Fmake_string):
5509 * character.c (string_escape_byte8):
5510 * coding.c (coding_alloc_by_realloc):
5511 * doprnt.c (doprnt):
5512 * editfns.c (Fformat):
5514 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5515 since they may not be the same number.
5516 * editfns.c (Finsert_char):
5517 * fileio.c (Finsert_file_contents):
5518 Likewise for BUF_BYTES_MAX.
5520 * image.c: Use ptrdiff_t, not int, for sizes.
5521 (slurp_file): Switch from int to ptrdiff_t.
5523 (slurp_file): Check that file size fits in both size_t (for
5524 malloc) and ptrdiff_t (for sanity and safety).
5526 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5527 if b->modtime has its maximal value.
5529 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5531 Don't assume time_t can fit into int.
5532 * buffer.h (struct buffer.modtime): Now time_t, not int.
5533 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5534 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5536 Minor fixes for signed vs unsigned integers.
5537 * character.h (MAYBE_UNIFY_CHAR):
5538 * charset.c (maybe_unify_char):
5539 * keyboard.c (read_char, reorder_modifiers):
5540 XINT -> XFASTINT, since the integer must be nonnegative.
5541 * ftfont.c (ftfont_spec_pattern):
5542 * keymap.c (access_keymap, silly_event_symbol_error):
5543 XUINT -> XFASTINT, since the integer must be nonnegative.
5544 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5545 since it makes no difference and we prefer signed.
5546 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5547 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5550 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5552 * window.h (Fwindow_frame): Declare.
5554 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5556 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5557 (SPARE_MEMORY): Always define.
5558 (LARGE_REQUEST): Remove.
5559 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5561 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5563 * lisp.h: Move EXFUNS for Fframe_root_window,
5564 Fframe_first_window and Fset_frame_selected_window to window.h.
5566 * window.h: Move EXFUNS for Fframe_root_window,
5567 Fframe_first_window and Fset_frame_selected_window here from
5570 * frame.c (Fwindow_frame, Fframe_first_window)
5571 (Fframe_root_window, Fframe_selected_window)
5572 (Fset_frame_selected_window): Move to window.c.
5573 (Factive_minibuffer_window): Move to minibuf.c.
5574 (Fother_visible_frames_p): New function.
5576 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5578 * window.c (decode_window, decode_any_window): Move up in code.
5579 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5580 (inhibit_frame_unsplittable): Remove unused variable.
5581 (Fwindow_buffer): Move up and rewrite doc-string.
5582 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5583 (Fwindow_prev): New functions.
5584 (Fwindow_frame): Move here from frame.c. Accept any window as
5586 (Fframe_root_window, Fframe_first_window)
5587 (Fframe_selected_window): Move here from frame.c. Accept frame
5588 or arbitrary window as argument. Update doc-strings.
5589 (Fminibuffer_window): Move up in code.
5590 (Fwindow_minibuffer_p): Move up in code and simplify.
5591 (Fset_frame_selected_window): Move here from frame.c.
5593 (Fselected_window, select_window, Fselect_window): Move up in
5594 code. Minor doc-string fixes.
5596 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5598 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5599 Do not assume that spare memory exists; that assumption is valid
5600 only if SYSTEM_MALLOC.
5601 (LARGE_REQUEST): New macro, so that the issue of large requests
5602 is separated from the issue of spare memory.
5604 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5606 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5609 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5611 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5614 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5616 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5618 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5620 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5621 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5623 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5625 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5627 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5629 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5630 (x_clipboard_manager_save): Add return value.
5631 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5633 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5634 Obey Vx_select_enable_clipboard_manager. Catch errors in
5635 x_clipboard_manager_save (Bug#8779).
5636 (Vx_select_enable_clipboard_manager): New variable.
5637 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5639 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5641 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5643 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5645 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5646 in the current matrix if keep_current_p is non-zero.
5648 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5650 * bidi.c (bidi_level_of_next_char): Fix last change.
5652 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5654 Support bidi reordering of text covered by display properties.
5656 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5657 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5658 (bidi_cache_search, bidi_cache_iterator_state)
5659 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5660 (bidi_level_of_next_char, bidi_move_to_visually_next):
5661 Support character positions inside a run of characters covered by a
5663 (bidi_paragraph_init, bidi_resolve_explicit_1)
5664 (bidi_level_of_next_char): Call bidi_fetch_char and
5665 bidi_fetch_char_advance instead of FETCH_CHAR and
5667 (bidi_init_it): Initialize new members.
5668 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5670 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5671 instead of using explicit *_CHAR codes.
5672 (bidi_resolve_explicit, bidi_resolve_weak):
5673 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5674 bidirectional text is supported only in multibyte buffers.
5675 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5676 it to initialize the frame_window_p member of struct bidi_it.
5677 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5678 (bidi_resolve_explicit, bidi_resolve_weak)
5679 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5680 bidi_it->nchars is non-positive.
5681 (bidi_level_of_next_char): Don't try to lookup the cache for the
5682 next/previous character if nothing is cached there yet, or if we
5683 were just reseat()'ed to a new position.
5685 * xdisp.c (set_cursor_from_row): Set start and stop points
5686 according to the row's direction when priming the loop that looks
5687 for the glyph on which to display cursor.
5688 (single_display_spec_intangible_p): Function deleted.
5689 (display_prop_intangible_p): Reimplement to call
5690 handle_display_spec instead of single_display_spec_intangible_p.
5691 Accept 3 additional arguments needed by handle_display_spec.
5692 This fixes incorrect cursor motion across display property with complex
5693 values: lists, `(when COND...)' forms, etc.
5694 (single_display_spec_string_p): Support property values that are
5695 lists with the argument STRING its top-level element.
5696 (display_prop_string_p): Fix the condition for processing a
5697 property that is a list to be consistent with handle_display_spec.
5698 (handle_display_spec): New function, refactored from the
5699 last portion of handle_display_prop.
5700 (compute_display_string_pos): Accept additional argument
5701 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5702 value of a `display' property is a "replacing spec".
5703 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5704 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5705 the display property, but just return a value indicating whether
5706 the display property will replace the characters it covers.
5707 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5708 frame_window_p members of struct bidi_it.
5709 (compute_display_string_pos, compute_display_string_end):
5711 (push_it): Accept second argument POSITION, where pop_it should
5712 jump to continue iteration.
5713 (reseat_1): Initialize bidi_it.disp_pos.
5715 * keyboard.c (adjust_point_for_property): Adjust the call to
5716 display_prop_intangible_p to its new signature.
5718 * dispextern.h (struct bidi_it): New member frame_window_p.
5719 (bidi_init_it): Update prototypes.
5720 (display_prop_intangible_p): Update prototype.
5721 (compute_display_string_pos, compute_display_string_end):
5723 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5726 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5728 Malloc failure behavior now depends on size of allocation.
5729 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5730 * lisp.h: Change signatures accordingly.
5731 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5732 All callers changed. (Bug#8762)
5734 * gnutls.c: Use Emacs's memory allocators.
5735 Without this change, the gnutls library would invoke malloc etc.
5736 directly, which causes problems on non-SYNC_INPUT hosts, and which
5737 runs afoul of improving memory_full behavior. (Bug#8761)
5738 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5739 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5740 xfree instead of the default malloc, realloc, free.
5741 (Fgnutls_boot): No need to check for memory allocation failure,
5742 since xmalloc does that for us.
5744 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5745 * category.c (hash_get_category_set):
5746 * ccl.c (ccl_driver):
5747 * charset.c (Fdefine_charset_internal):
5748 * charset.h (struct charset.hash_index):
5749 * composite.c (get_composition_id, gstring_lookup_cache)
5750 (composition_gstring_put_cache):
5751 * composite.h (struct composition.hash_index):
5752 * dispextern.h (struct image.hash):
5753 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5754 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5755 (hashfn_equal, hashfn_user_defined, make_hash_table)
5756 (maybe_resize_hash_table, hash_lookup, hash_put)
5757 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5758 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5759 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5760 * image.c (make_image, search_image_cache, lookup_image)
5761 (xpm_put_color_table_h):
5762 * lisp.h (struct Lisp_Hash_Table):
5763 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5764 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5765 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5766 * alloc.c (allocate_vectorlike):
5767 Check for overflow in vector size calculations.
5768 * ccl.c (ccl_driver):
5769 Check for overflow when converting EMACS_INT to int.
5770 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5771 need to be updated by these changes.
5772 * fns.c (make_hash_table, maybe_resize_hash_table):
5773 Check for integer overflow with large hash tables.
5774 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5775 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5776 (SXHASH_REDUCE): New macro.
5777 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5778 Use it instead of discarding useful hash info with large hash values.
5779 (sxhash_float): New function.
5780 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5781 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5782 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5783 Rewrite to use FIXNUM_BITS, as this simplifies things.
5784 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5785 Adjust signatures to match updated version of code.
5786 (consing_since_gc): Now EMACS_INT, since a single hash table can
5787 use more than INT_MAX bytes.
5789 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5791 Make it possible to build with GCC-4.6+ -O2 -flto.
5793 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5795 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5797 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5798 Call minibuffer-inactive-mode.
5800 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5802 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5803 Update dependencies.
5805 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5807 * data.c (init_data): Remove code for UTS, this system is not
5810 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5812 Don't force ./temacs to start in terminal mode.
5814 * frame.c (make_initial_frame): Initialize faces in all cases, not
5815 only when CANNOT_DUMP is defined.
5816 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5818 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5820 * dispnew.c (add_window_display_history): Use const for the string
5821 pointer. Remove declaration, not needed.
5823 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5825 Use 'inline', not 'INLINE'.
5826 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5827 * alloc.c, fontset.c (INLINE): Remove.
5828 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5829 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5830 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5831 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5832 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5834 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5836 Make it possible to run ./temacs.
5838 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5839 syms_of_callproc does the same thing. Remove test for
5840 "initialized", do it in the caller.
5841 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5843 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5845 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5846 (read_minibuf): Use get_minibuffer.
5847 (syms_of_minibuf): Use DEFSYM.
5848 (Qmetadata): New var.
5849 * data.c (Qbuffer): Don't make it static.
5850 (syms_of_data): Use DEFSYM.
5852 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5854 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5855 (CCL_CODE_MIN): New macro.
5857 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5859 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5861 * eval.c (Qdebug): Now static.
5862 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5863 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5864 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5866 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5868 * image.c: Various fixes to ImageMagick code comments.
5869 (Fimagemagick_types): Doc fix.
5871 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5873 Minor fixes prompted by GCC 4.6.0 warnings.
5875 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5877 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5878 (x_clipboard_manager_save_all): Move extern decl to ...
5879 * xterm.h: ... here, so that it can be checked for consistency.
5881 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5883 * xselect.c (x_clipboard_manager_save_frame)
5884 (x_clipboard_manager_save_all): New functions.
5885 (Fx_clipboard_manager_save): Lisp function deleted.
5887 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5888 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5890 * xterm.h: Update prototype.
5892 2011-05-28 William Xu <william.xwl@gmail.com>
5894 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5897 2011-05-28 Jim Meyering <meyering@redhat.com>
5899 Avoid a sign-extension bug in crypto_hash_function.
5900 * fns.c (to_uchar): Define.
5901 (crypto_hash_function): Use it to convert some newly-signed
5902 variables to unsigned, to avoid sign-extension bugs. For example,
5903 without this change, (md5 "truc") would evaluate to
5904 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5905 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5906 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5908 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5910 Integer overflow fixes.
5912 * dbusbind.c: Serial number integer overflow fixes.
5913 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5914 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5915 to hold a serial number that is too large for a fixnum.
5916 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5917 Check for serial numbers out of range. Decode any serial number
5918 that was so large that it became a float. (Bug#8722)
5920 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5921 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5922 Use XFASTINT rather than XUINT when numbers are nonnegative.
5923 (xd_append_arg, Fdbus_method_return_internal):
5924 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5925 arguments, check that Lisp number is nonnegative, rather than
5926 silently wrapping negative numbers around. (Bug#8722)
5927 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5930 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5932 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5934 ccl: Add integer overflow checks.
5935 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5936 (IN_INT_RANGE): New macros.
5937 (ccl_driver): Use them to check for integer overflow when
5938 decoding a CCL program. Many of the new checks are whether XINT (x)
5939 fits in int; it doesn't always, on 64-bit hosts. The new version
5940 doesn't catch all possible integer overflows, but it's an
5941 improvement. (Bug#8719)
5943 * alloc.c (make_event_array): Use XINT, not XUINT.
5944 There's no need for unsigned here.
5946 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5947 This follows up to the 2011-05-06 change that substituted uintptr_t
5948 for EMACS_INT. This case wasn't caught back then.
5950 Rework Fformat to avoid integer overflow issues.
5951 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5952 now (part of C89). Include <verify.h>.
5953 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5954 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5955 (Fformat): Avoid the prepass trying to compute sizes; it was only
5956 approximate and thus did not catch overflow reliably. Instead, walk
5957 through the format just once, formatting and computing sizes as we go,
5958 checking for integer overflow at every step, and allocating a larger
5959 buffer as needed. Keep track separately whether the format is
5960 multibyte. Keep only the most-recently calculated precision, rather
5961 than them all. Record whether each argument has been converted to
5962 string. Use EMACS_INT, not int, for byte and char and arg counts.
5963 Support field widths and precisions larger than INT_MAX. Avoid
5964 sprintf's undefined behavior with conversion specifications such as %#d
5965 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5966 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5967 formatting out-of-range floating point numbers with int
5970 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5972 * data.c: Avoid integer truncation in expressions involving floats.
5973 * data.c: Include <intprops.h>.
5974 (arith_driver): When there's an integer overflow in an expression
5975 involving floating point, convert the integers to floating point
5976 so that the resulting value does not suffer from catastrophic
5977 integer truncation. For example, on a 64-bit host (* 4
5978 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5979 Do not rely on undefined behavior after integer overflow.
5981 merge count_size_as_multibyte, parse_str_to_multibyte
5982 * character.c, character.h (count_size_as_multibyte):
5983 Rename from parse_str_to_multibyte; all uses changed.
5984 Check for integer overflow.
5985 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5986 since it's now a duplicate of the other. This is more of
5987 a character than a buffer op, so better that it's in character.c.
5988 * fns.c, print.c: Adjust to above changes.
5990 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5992 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5994 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5996 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5997 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5998 (x_clipboard_manager_save): Now static.
5999 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6001 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6002 (crypto_hash_function): Now static.
6003 Fix pointer signedness problems. Avoid unnecessary initializations.
6005 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6007 * termhooks.h (Vselection_alist): Make it terminal-local.
6009 * terminal.c (create_terminal): Initialize it.
6011 * xselect.c: Support for clipboard managers.
6012 (Vselection_alist): Move to termhooks.h as terminal-local var.
6013 (LOCAL_SELECTION): New macro.
6014 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6015 (symbol_to_x_atom): Remove gratuitous arg.
6016 (x_handle_selection_request, lisp_data_to_selection_data)
6017 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6018 (x_own_selection, x_get_local_selection, x_convert_selection):
6019 New arg, specifying work frame. Use terminal-local Vselection_alist.
6020 (some_frame_on_display): Delete unused function.
6021 (Fx_own_selection_internal, Fx_get_selection_internal)
6022 (Fx_disown_selection_internal, Fx_selection_owner_p)
6023 (Fx_selection_exists_p): New optional frame arg.
6024 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6025 (x_handle_selection_clear): Don't treat other terminals with the
6026 same keyboard specially. Use the terminal-local Vselection_alist.
6027 (x_clear_frame_selections): Use Frun_hook_with_args.
6029 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6031 * xterm.h: Add support for those atoms.
6033 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6035 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6036 (converted_selections, conversion_fail_tag): New global variables.
6037 (x_selection_request_lisp_error): Free the above.
6038 (x_get_local_selection): Remove unnecessary code.
6039 (x_reply_selection_request): Args changed; handle arbitrary array
6040 of converted selections stored in converted_selections.
6041 Separate the XChangeProperty and SelectionNotify steps.
6042 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6043 (x_convert_selection): New function.
6044 (x_handle_selection_event): Simplify.
6045 (x_get_foreign_selection): Don't ignore incoming requests while
6046 waiting for an answer; this will fail when we implement
6047 SAVE_TARGETS, and seems unnecessary anyway.
6048 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6049 (Vx_sent_selection_functions): Doc fix.
6051 2011-05-26 Leo Liu <sdl.web@gmail.com>
6053 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6055 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6057 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6059 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6060 for fringe update if it has periodic bitmap.
6061 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6062 and fringe_bitmap_periodic_p.
6064 * fringe.c (get_fringe_bitmap_data): New function.
6065 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6066 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6067 row. Mark glyph row for fringe update if periodicity changed.
6069 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6070 for fringe update unless it has periodic bitmap.
6072 2011-05-25 Kenichi Handa <handa@m17n.org>
6074 * xdisp.c (get_next_display_element): Set correct it->face_id for
6075 a static composition.
6077 2011-05-24 Leo Liu <sdl.web@gmail.com>
6080 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6082 * fns.c (crypto_hash_function, Fsha1): New function.
6083 (Fmd5): Use crypto_hash_function.
6084 (syms_of_fns): Add Ssha1.
6086 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6088 * gnutls.c: Remove unused macros.
6089 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6090 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6091 Remove macros that are defined and never used.
6092 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6094 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6096 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6097 (Fx_get_selection_internal): Minor cleanup.
6098 (Fx_own_selection_internal): Rename arguments for consistency with
6101 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6103 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6105 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6107 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6109 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6111 * dispnew.c (scrolling_window): Don't exclude the case that the
6112 last enabled row in the desired matrix touches the bottom boundary.
6114 2011-05-21 Glenn Morris <rgm@gnu.org>
6116 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6117 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6118 and add some more files.
6120 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6122 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6123 report_file_error introduced by the change from 2011-05-07.
6125 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6127 * systime.h (Time): Define only if emacs is defined.
6128 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6129 where the include path doesn't have X11/X.h by default. See
6130 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6132 2011-05-20 Kenichi Handa <handa@m17n.org>
6134 * composite.c (find_automatic_composition): Fix previous change.
6136 2011-05-20 Glenn Morris <rgm@gnu.org>
6138 * lisp.mk: New file, split from Makefile.in.
6139 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6140 (shortlisp): Remove.
6141 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6143 2011-05-19 Glenn Morris <rgm@gnu.org>
6145 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6146 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6147 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6148 (lisp): Set the order to that of loadup.el.
6149 (shortlisp): Make it a copy of $lisp.
6150 (SOME_MACHINE_LISP): Remove.
6151 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6152 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6154 2011-05-18 Kenichi Handa <handa@m17n.org>
6156 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6157 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6158 (find_automatic_composition): Mostly rewrite for efficiency.
6160 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6162 * makefile.w32-in: Update dependencies.
6164 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6166 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6167 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6169 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6171 Fix some integer overflow issues, such as string length overflow.
6173 * insdel.c (count_size_as_multibyte): Check for string overflow.
6175 * character.c (lisp_string_width): Check for string overflow.
6176 Use EMACS_INT, not int, for string indexes and lengths; in
6177 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6178 the resulting string length overflows an EMACS_INT; instead,
6179 report a string overflow if no precision given. When checking for
6180 precision exhaustion, use a check that cannot possibly have
6181 integer overflow. (Bug#8675)
6182 * character.h (lisp_string_width): Adjust to new signature.
6184 * alloc.c (string_overflow): New function.
6185 (Fmake_string): Use it. This doesn't change behavior, but saves
6186 a few bytes and will simplify future changes.
6187 * character.c (string_escape_byte8): Likewise.
6188 * lisp.h (string_overflow): New decl.
6190 Fixups, following up to the user-interface timestamp change.
6191 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6192 for UI timestamps, instead of unsigned long.
6193 * msdos.c (mouse_get_pos): Likewise.
6194 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6195 * w32gui.h (Time): Define by including "systime.h" rather than by
6196 declaring it ourselves. (Bug#8664)
6198 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6199 * image.c (clear_image_cache): Likewise.
6201 * term.c (term_mouse_position): Don't assume time_t wraparound.
6203 Be more systematic about user-interface timestamps.
6204 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6205 and sometimes 'EMACS_UINT', to represent these timestamps.
6206 This change causes it to use 'Time' uniformly, as that's what X uses.
6207 This makes the code easier to follow, and makes it easier to catch
6208 integer overflow bugs such as Bug#8664.
6209 * frame.c (Fmouse_position, Fmouse_pixel_position):
6210 Use Time, not unsigned long, for user-interface timestamps.
6211 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6212 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6213 * keyboard.h (last_event_timestamp): Likewise.
6214 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6215 * menu.h (xmenu_show): Likewise.
6216 * term.c (term_mouse_position): Likewise.
6217 * termhooks.h (struct input_event.timestamp): Likewise.
6218 (struct terminal.mouse_position_hook): Likewise.
6219 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6220 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6221 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6222 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6224 * menu.h, termhooks.h: Include "systime.h", for Time.
6226 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6227 Don't assume that the difference between two unsigned long values
6228 can fit into an integer. At this point, we know button_down_time
6229 <= event->timestamp, so the difference must be nonnegative, so
6230 there's no need to cast the result if double-click-time is
6231 nonnegative, as it should be; check that it's nonnegative, just in
6232 case. This bug is triggered when events are more than 2**31 ms
6233 apart (about 25 days). (Bug#8664)
6235 * xselect.c (last_event_timestamp): Remove duplicate decl.
6236 (x_own_selection): Remove needless cast to unsigned long.
6238 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6239 that always fit in int. Use a sentinel instead of a counter, to
6240 avoid a temp and to allay GCC's concerns about possible int overflow.
6241 * frame.h (struct frame): Use int for menu_bar_items_used
6242 instead of EMACS_INT, since it always fits in int.
6244 * menu.c (grow_menu_items): Check for int overflow.
6246 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6248 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6249 Before, the code was not consistent. These values cannot exceed
6250 2**31 - 1 so there's no need to make them unsigned.
6251 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6252 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6253 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6255 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6257 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6258 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6259 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6260 presumably because the widths might not match.
6262 * window.c (size_window): Avoid needless test at loop start.
6264 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6266 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6268 2011-05-12 Drew Adams <drew.adams@oracle.com>
6270 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6272 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6274 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6275 `width' to `bar_area_x' and `bar_area_width', respectively.
6276 (x_scroll_run): Take account of fringe background extension.
6278 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6279 Rename local vars `left' and `width' to `bar_area_x' and
6280 `bar_area_width', respectively.
6281 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6282 background extension.
6284 2011-05-10 Jim Meyering <meyering@redhat.com>
6286 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6288 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6290 * image.c (Finit_image_library): Return t for built-in image types,
6291 like pbm and xbm. (Bug#8640)
6293 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6295 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6297 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6299 * w32console.c (Fset_screen_color): Doc fix.
6300 (Fget_screen_color): New function.
6301 (syms_of_ntterm): Defsubr it.
6303 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6304 unlink the temporary file if Fcall_process didn't create it in the
6306 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6307 child process will be redirected to a file specified with `:file'.
6308 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6309 cue to call_process_cleanup not to close that handle.
6311 2011-05-07 Ben Key <bkey76@gmail.com>
6313 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6314 one of two shell specific rules, either bootstrap-temacs-CMD or
6315 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6316 to the previous implementation of the bootstrap-temacs rule.
6317 The bootstrap-temacs-CMD rule is similar to the previous
6318 implementation of the bootstrap-temacs rule except that it
6319 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6322 These changes, along with some changes to nt/configure.bat,
6323 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6324 earlier fix to add support for --cflags and --ldflags options
6325 that include quotes so that it works whether make uses cmd or
6328 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6330 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6331 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6333 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6334 a string. Handle both cases.
6335 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6336 (Fdbus_register_method): Use Qinvalid_function.
6338 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6340 * makefile.w32-in: Update dependencies.
6341 (LISP_H): Add inttypes.h and stdin.h.
6342 (PROCESS_H): Add unistd.h.
6344 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6346 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6347 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6349 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6351 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6353 * term.c (vfatal): Remove stray call to va_end.
6354 It's not needed and the C Standard doesn't allow it here anyway.
6356 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6357 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6359 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6362 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6364 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6366 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6368 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6370 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6372 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6373 * charset.c (Fdefine_charset_internal): Don't initialize
6374 charset.code_space[15]. The value was garbage, on hosts with
6375 32-bit int (Bug#8600).
6377 * lread.c (read_integer): Be more consistent with string-to-number.
6378 Use string_to_number to do the actual conversion; this avoids
6379 rounding errors and fixes some other screwups. Without this fix,
6380 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6381 (digit_to_number): Move earlier, for benefit of read_integer.
6382 Return -1 if the digit is out of range for the base, -2 if it is
6383 not a digit in any supported base. (Bug#8602)
6385 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6387 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6388 to match comment at start of function. This also removes a
6389 GCC warning about overflow in a 32+64-bit port.
6391 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6393 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6394 Reported by Stefan Monnier in
6395 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6396 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6397 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6399 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6400 (EMACS_UINTPTR): Likewise, with uintptr_t.
6402 * lisp.h: Prefer 64-bit EMACS_INT if available.
6403 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6404 on 32-bit hosts that have 64-bit int, so that they can access
6406 However, temporarily disable this change unless the temporary
6407 symbol WIDE_EMACS_INT is defined.
6409 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6411 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6412 This removes an assumption that EMACS_INT and long are the same
6413 width as pointers. The assumption is true for Emacs porting targets
6414 now, but we want to make other targets possible.
6415 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6416 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6417 In the rest of the code, change types of integers that hold casted
6418 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6419 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6420 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6421 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6422 No need to cast type when ORing.
6423 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6424 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6425 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6426 assume EMACS_INT is the same width as char *.
6427 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6428 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6429 Remove no-longer-needed casts.
6430 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6431 (xg_tool_bar_help_callback, xg_make_tool_item):
6432 Use EMACS_INTPTR to hold an integer
6433 that will be cast to void *; this can avoid a GCC warning
6434 if EMACS_INT is not the same width as void *.
6435 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6436 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6437 (current_message_1, set_message_1):
6438 Use a local to convert to proper width without a cast.
6439 * xmenu.c (dialog_selection_callback): Likewise.
6441 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6442 Also, don't assume VALBITS / RAND_BITS is less than 5,
6443 and don't rely on undefined behavior when shifting a 1 left into
6445 * lisp.h (get_random): Change signature to match.
6447 * lread.c (hash_string): Use size_t, not int, for hash computation.
6448 Normally we prefer signed values; but hashing is special, because
6449 it's better to use unsigned division on hash table sizes so that
6450 the remainder is nonnegative. Also, size_t is the natural width
6451 for hashing into memory. The previous code used 'int', which doesn't
6452 retain enough info to hash well into very large tables.
6453 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6455 * dbusbind.c: Don't possibly lose pointer info when converting.
6456 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6457 Use XPNTR rather than XHASH, so that the high-order bits of
6458 the pointer aren't lost when converting through void *.
6460 * eval.c (Fautoload): Don't double-shift a pointer.
6462 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6464 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6466 * gnutls.c (DEF_GNUTLS_FN):
6467 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6469 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6471 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6474 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6476 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6477 New version that can reserve upto 2GB of heap space.
6479 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6481 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6483 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6485 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6486 `gnutls_certificate_set_x509_key_file'.
6488 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6490 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6491 Update dependencies.
6493 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6495 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6496 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6497 Remove unused parameter `fildes'.
6498 * process.c (read_process_output, send_process): Don't pass it.
6500 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6502 Fix previous change: the library cache is defined in w32.c.
6503 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6504 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6506 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6508 Implement dynamic loading of GnuTLS on Windows.
6510 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6511 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6512 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6515 * gnutls.c (Qgnutls_dll): Define.
6516 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6517 (gnutls_*): Declare function pointers.
6518 (init_gnutls_functions): New function to initialize function pointers.
6519 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6520 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6521 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6522 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6523 (emacs_gnutls_write, emacs_gnutls_read)
6524 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6525 (Fgnutls_available_p): New function.
6526 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6527 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6528 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6530 * image.c: Include w32.h.
6531 (Vimage_type_cache): Delete.
6532 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6533 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6534 (w32_delayed_load): Move to w32.c.
6536 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6538 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6539 (w32_delayed_load): Move from image.c. When loading a library, record
6540 its filename in the :loaded-from property of the library id.
6541 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6542 Initialize and staticpro them.
6543 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6545 * process.c: Include lisp.h before w32.h, not after.
6546 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6547 instead of gnutls_record_check_pending.
6549 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6551 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6553 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6554 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6557 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6559 * xterm.c (x_set_frame_alpha): Do not set property on anything
6560 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6562 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6564 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6566 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6568 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6569 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6570 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6571 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6572 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6573 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6574 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6575 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6576 (Qgnutls_bootprop_callbacks_verify): Make static.
6578 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6580 * callproc.c: Indentation fixup.
6582 * sysdep.c (wait_for_termination_1): Make static.
6583 (wait_for_termination, interruptible_wait_for_termination):
6584 Move after wait_for_termination_1.
6586 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6588 * sysdep.c (interruptible_wait_for_termination): New function
6589 which is like wait_for_termination, but allows keyboard
6592 * callproc.c (Fcall_process): Add (:file "file") as an option for
6594 (Fcall_process_region): Ditto.
6596 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6598 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6599 rather than `XVECTOR (FOO)->size'.
6601 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6602 inttypes.h, as a gnulib replacement is used if it not available in
6605 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6607 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6608 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6609 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6611 * coding.c (coding_alloc_by_realloc): Error out if destination
6612 will grow beyond MOST_POSITIVE_FIXNUM.
6613 (decode_coding_emacs_mule): Abort if there isn't enough place in
6614 charbuf for the composition carryover bytes. Reserve an extra
6615 space for up to 2 characters produced in a loop.
6616 (decode_coding_iso_2022): Abort if there isn't enough place in
6617 charbuf for the composition carryover bytes.
6619 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6621 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6622 aborting when %lld or %lll format is passed.
6623 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6624 %llo or %llx format is passed. (Bug#8545)
6626 * window.c (window_scroll_line_based): Use a marker instead of
6627 simple variables to record original value of point. (Bug#7952)
6629 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6630 produced by %s or %c overflows available buffer space. (Bug#8545)
6632 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6634 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6635 (SIZE_MAX): Move defn after all includes, as they might #define it.
6637 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6639 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6641 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6643 * keyboard.c (Qdelayed_warnings_hook): Define.
6644 (command_loop_1): Run `delayed-warnings-hook'
6645 if Vdelayed_warnings_list is non-nil.
6646 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6647 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6649 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6651 * doprnt.c (doprnt): Don't return value smaller than the buffer
6652 size if the message was truncated. (Bug#8545).
6654 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6656 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6657 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6659 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6661 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6663 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6665 * makefile.w32-in: Update dependencies.
6667 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6669 Improve `doprnt' and its usage. (Bug#8545)
6670 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6671 `format_end'. Remove support for %l as a conversion specifier.
6672 Don't use xrealloc. Improve diagnostics when the %l size modifier
6673 is used. Update the commentary.
6675 * eval.c (verror): Simplify calculation of size_t.
6677 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6680 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6682 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6685 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6687 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6688 This makes this file independent of the recent pseudovector change.
6690 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6692 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6694 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6695 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6696 Remove unused local.
6697 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6699 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6700 GCC 4.6.0 optimizes based on type-based alias analysis.
6701 For example, if b is of type struct buffer * and v of type struct
6702 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6703 != &v->size, and therefore "v->size = 1; b->size = 2; return
6704 v->size;" must therefore return 1. This assumption is incorrect
6705 for Emacs, since it type-puns struct Lisp_Vector * with many other
6706 types. To fix this problem, this patch adds a new type struct
6707 vectorlike_header that documents the constraints on layout of vectors
6708 and pseudovectors, and helps optimizing compilers not get fooled
6709 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6710 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6711 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6713 (XSETPVECTYPE): Rewrite in terms of new macro.
6714 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6715 This is a bit clearer, and further avoids the possibility of
6716 undesirable aliasing.
6717 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6718 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6719 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6720 since Lisp_Subr is a special case (no "next" field).
6721 (ASIZE): Now uses header.size rather than size.
6722 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6723 to avoid the hassle of writing XVECTOR (foo)->header.size.
6724 (struct vectorlike_header): New type.
6725 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6726 object, to help avoid aliasing.
6727 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6728 (SUBRP): Likewise, since Lisp_Subr is a special case.
6729 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6730 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6731 (struct Lisp_Hash_Table): Combine first two members into a single
6732 struct vectorlike_header member. All uses of "size" and "next" members
6733 changed to be "header.size" and "header.next".
6734 * buffer.h (struct buffer): Likewise.
6735 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6736 * frame.h (struct frame): Likewise.
6737 * process.h (struct Lisp_Process): Likewise.
6738 * termhooks.h (struct terminal): Likewise.
6739 * window.c (struct save_window_data, struct saved_window): Likewise.
6740 * window.h (struct window): Likewise.
6741 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6742 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6743 * buffer.c (init_buffer_once): Likewise.
6744 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6746 * process.c (Fformat_network_address): Use local var for size,
6749 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6751 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6752 * data.c (atof): Remove decl; no longer used or needed.
6753 (digit_to_number): Move to lread.c.
6754 (Fstring_to_number): Use new string_to_number function, to be
6755 consistent with how the Lisp reader treats infinities and NaNs.
6756 Do not assume that floating-point numbers represent EMACS_INT
6757 without losing information; this is not true on most 64-bit hosts.
6758 Avoid double-rounding errors, by insisting on integers when
6759 parsing non-base-10 numbers, as the documentation specifies.
6760 * lisp.h (string_to_number): New decl, replacing ...
6761 (isfloat_string): Remove.
6762 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6763 (read1): Do not accept +. and -. as integers; this
6764 appears to have been a coding error. Similarly, do not accept
6765 strings like +-1e0 as floating point numbers. Do not report
6766 overflow for integer overflows unless the base is not 10 which
6767 means we have no simple and reliable way to continue.
6768 Break out the floating-point parsing into a new
6769 function string_to_number, so that Fstring_to_number parses
6770 floating point numbers consistently with the Lisp reader.
6771 (digit_to_number): Move here from data.c. Make it static inline.
6772 (E_CHAR, EXP_INT): Remove, replacing with ...
6773 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6774 (string_to_number): New function, replacing isfloat_string.
6775 This function checks for valid syntax and produces the resulting
6776 Lisp float number too. Rework it so that string-to-number
6777 no longer mishandles examples like "1.0e+". Use strtoumax,
6778 so that overflow for non-base-10 numbers is reported only when
6779 there's no portable and simple way to convert to floating point.
6781 * textprop.c (set_text_properties_1): Rewrite for clarity,
6782 and to avoid GCC warning about integer overflow.
6784 * intervals.h (struct interval): Use EMACS_INT for members
6785 where EMACS_UINT might cause problems. See
6786 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6787 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6788 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6790 (offset_intervals): Tell GCC not to worry about length overflow
6791 when negating a negative length.
6793 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6794 (overrun_check_free): Likewise.
6796 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6797 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6800 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6801 (gnutls_make_error): Rename local to avoid shadowing.
6802 (gnutls_emacs_global_deinit): ifdef out; not used.
6803 (Fgnutls_boot): Use const for pointer to readonly storage.
6804 Comment out unused local. Fix pointer signedness problems.
6806 * lread.c (openp): Don't stuff size_t into an 'int'.
6807 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6808 about possible signed overflow.
6810 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6811 (GDK_KEY_g): Don't define if already defined.
6812 (xg_prepare_tooltip): Avoid pointer signedness problem.
6813 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6815 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6816 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6818 * xfns.c (Fx_window_property): Simplify a bit,
6819 to make a bit faster and to avoid GCC 4.6.0 warning.
6820 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6822 * fns.c (internal_equal): Don't assume size_t fits in int.
6824 * alloc.c (compact_small_strings): Tighten assertion a little.
6826 Replace pEd with more-general pI, and fix some printf arg casts.
6827 * lisp.h (pI): New macro, generalizing old pEd macro to other
6828 conversion specifiers. For example, use "...%"pI"d..." rather
6829 than "...%"pEd"...".
6830 (pEd): Remove. All uses replaced with similar uses of pI.
6831 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6832 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6833 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6834 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6835 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6836 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6837 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6839 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6840 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6841 * print.c (safe_debug_print, print_object): Likewise.
6842 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6844 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6845 avoiding the 0 flag, which is not portable.
6846 * process.c (Fmake_network_process): Use pI to avoid cast.
6847 * region-cache.c (pp_cache): Likewise.
6848 * xdisp.c (decode_mode_spec): Likewise.
6849 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6850 behavior on 64-bit hosts with printf arg.
6851 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6852 (x_stop_queuing_selection_requests): Likewise.
6853 (x_get_window_property): Don't truncate byte count to an 'int'
6856 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6857 here, since it parses constructs like leading '-' and spaces,
6858 which are not wanted; and it overflows with large numbers.
6859 Instead, simply match F[0-9]+, which is what is wanted anyway.
6861 * alloc.c: Remove unportable assumptions about struct layout.
6862 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6863 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6864 (allocate_vectorlike, make_pure_vector): Use the new macros,
6865 plus offsetof, to remove unportable assumptions about struct layout.
6866 These assumptions hold on all porting targets that I know of, but
6867 they are not guaranteed, they're easy to remove, and removing them
6868 makes further changes easier.
6870 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6871 This doesn't fix a bug but makes the code clearer.
6872 (string_overrun_cookie): Now const. Use initializers that
6873 don't formally overflow signed char, to avoid warnings.
6874 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6875 can cause Emacs to crash when string overrun checking is enabled.
6876 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6877 multiple of sizeof (EMACS_INT); it need not be, if
6878 alignof(EMACS_INT) < sizeof (EMACS_INT).
6879 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6881 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6883 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6885 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6887 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6888 supposed to be handshaking. (Bug#8556)
6889 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6891 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6893 * lisp.h (Qdebug): List symbol.
6894 * eval.c (Qdebug): Restore global linkage.
6895 * keyboard.c (debug-on-event): New variable.
6896 (handle_user_signal): Break into debugger when debug-on-event
6897 matches the current signal symbol.
6899 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6901 * alloc.c (check_sblock, check_string_bytes)
6902 (check_string_free_list): Convert to standard C.
6904 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6906 * w32.c (emacs_gnutls_push): Fix typo.
6908 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6910 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6911 "cast to pointer from integer of different size".
6913 Improve doprnt and its use in verror. (Bug#8545)
6914 * doprnt.c (doprnt): Document the set of format control sequences
6915 supported by the function. Use SAFE_ALLOCA instead of always
6918 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6919 is one byte too soon. Don't use xrealloc; instead xfree and
6922 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6924 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6927 * gnutls.c: Renamed global_initialized to
6928 gnutls_global_initialized. Added internals for the
6929 :verify-hostname-error, :verify-error, and :verify-flags
6930 parameters of `gnutls-boot' and documented those parameters in the
6931 docstring. Start callback support.
6932 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6933 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6934 on error. Return error code.
6935 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6936 (emacs_gnutls_read): Likewise.
6937 (Fgnutls_boot): Return handshake error code.
6938 (emacs_gnutls_handle_error): New function.
6939 (wsaerror_to_errno): Likewise.
6941 * w32.h (emacs_gnutls_pull): Add prototype.
6942 (emacs_gnutls_push): Likewise.
6944 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6945 (emacs_gnutls_push): Likewise.
6947 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6949 * process.c (wait_reading_process_output): Check if GnuTLS
6950 buffered some data internally if no FDs are set for TLS
6953 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6954 (LIBS): Link to USER_LIBS.
6955 ($(BLD)/gnutls.$(0)): New target.
6957 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6959 * xdisp.c (handle_single_display_spec): Rename the
6960 display_replaced_before_p argument into display_replaced_p, to
6961 make it consistent with the commentary. Fix typos in the
6964 * textprop.c (syms_of_textprop): Remove dead code.
6965 (copy_text_properties): Delete obsolete commentary about an
6966 interface that was deleted long ago. Fix typos in the description
6969 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6970 to changes in oldXMenu/XMenu.h from 2011-04-16.
6971 <menu_help_message, prev_menu_help_message>: Constify.
6972 (IT_menu_make_room): menu->help_text is now `const char **';
6975 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6976 to changes in oldXMenu/XMenu.h from 2011-04-16.
6977 (struct XMenu): Declare `help_text' `const char **'.
6979 * xfaces.c <Qunspecified>: Make extern again.
6981 * syntax.c: Include sys/types.h before including regex.h, as
6984 * doc.c (get_doc_string): Improve the format passed to `error'.
6986 * doprnt.c (doprnt): Improve commentary.
6988 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6990 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6993 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6994 changes in globals.h immediately force recompilation.
6995 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6996 $(CURDIR)/s/ms-w32.h.
6997 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6999 * character.c (Fchar_direction): Function deleted.
7000 (syms_of_character): Don't defsubr it.
7001 <char-direction-table>: Deleted.
7003 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7005 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7006 * doprnt.c: Include limits.h.
7007 (SIZE_MAX): New macro.
7008 (doprnt): Return a size_t value. 2nd arg is now size_t.
7009 Many local variables are now size_t instead of int or unsigned.
7010 Improve overflow protection. Support `l' modifier for integer
7011 conversions. Support %l conversion. Don't assume an EMACS_INT
7012 argument for integer conversions and for %c.
7014 * lisp.h (doprnt): Restore prototype.
7016 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7019 * Makefile.in (base_obj): Add back doprnt.o.
7021 * deps.mk (doprnt.o): Add back prerequisites.
7022 (callint.o): Depend on character.h.
7024 * eval.c (internal_lisp_condition_case): Include the handler
7025 representation in the error message.
7026 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7027 when breaking from the loop.
7029 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7031 * callint.c (Fcall_interactively): When displaying error message
7032 about invalid control letter, pass the character's codepoint, not
7033 a pointer to its multibyte form. Improve display of the character
7034 in octal and display also its hex code.
7036 * character.c (char_string): Use %x to display the (unsigned)
7037 codepoint of an invalid character, to avoid displaying a bogus
7040 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7041 `error', not SYMBOL_NAME itself.
7043 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7044 character arguments to `error'.
7046 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7047 to `error' in error message about FINAL_CHAR argument. Make sure
7048 FINAL_CHAR is a character, and use %c when it is passed as
7049 argument to `error'.
7051 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7053 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7055 * w32.c: Include <time.h>.
7056 (sys_localtime): New function.
7058 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7060 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7062 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7064 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7066 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7069 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7071 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7072 gl_state.e_property when gl_state.object is Qt.
7074 * insdel.c (make_gap_larger): Remove limitation of buffer size
7077 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7079 * xdisp.c (lookup_glyphless_char_display)
7080 (produce_glyphless_glyph): Handle cons cell entry in
7081 glyphless-char-display.
7082 (Vglyphless_char_display): Document it.
7084 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7085 glyphless-char-display.
7087 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7089 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7091 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7093 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7094 definition for no-X builds.
7096 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7098 Static checks with GCC 4.6.0 and non-default toolkits.
7100 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7102 * process.c (keyboard_bit_set): Define only if SIGIO.
7103 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7104 (send_process): Repair possible setjmp clobbering.
7106 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7108 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7110 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7112 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7113 Define only if needed.
7115 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7116 by pacifying GCC about it. Maybe it's time to retire it?
7117 * xfaces.c (USG, __TIMEVAL__): Likewise.
7119 * dispextern.h (struct redisplay_interface): Rename param
7121 * termhooks.h (struct terminal): Likewise.
7122 * xterm.c (xembed_send_message): Likewise.
7124 * insdel.c (make_gap_smaller): Define only if
7125 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7127 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7130 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7131 so that we aren't warned about unused symbols.
7133 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7135 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7137 * xfns.c (x_real_positions): Mark locals as initialized.
7139 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7141 * xterm.c: Fix problems found by static analysis with other toolkits.
7142 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7143 (x_dispatch_event): Declare static if USE_GTK, and
7144 define if USE_GTK || USE_X_TOOLKIT.
7145 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7146 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7147 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7148 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7150 * xmenu.c (menu_help_callback): Pointer type fixes.
7151 Use const pointers when pointing at readonly data. Avoid pointer
7153 (FALSE): Remove unused macro.
7154 (update_frame_menubar): Remove unused decl.
7156 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7158 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7159 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7160 (single_menu_item): Rename local to avoid shadowing.
7162 * keyboard.c (make_lispy_event): Remove unused local var.
7164 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7165 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7167 * bitmaps: Change bitmaps from unsigned char back to the X11
7168 compatible char. Avoid the old compiler warnings about
7169 out-of-range initializers by using, for example, '\xab' rather
7172 * xgselect.c (xgselect_initialize): Check vs interface
7173 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7175 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7177 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7178 to read-only memory.
7180 * fns.c (vector): Remove; this old hack is no longer needed.
7182 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7184 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7186 * xrdb.c (x_load_resources): Omit unused local.
7188 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7189 (x_window): Rename locals to avoid shadowing.
7190 (USG): Use the kludged USG macro, to pacify gcc.
7192 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7193 (x_term_init): Remove local to avoid shadowing.
7195 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7197 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7198 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7200 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7202 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7204 Fix regex.c, syntax.c and friends for buffers > 2GB.
7205 * syntax.h (struct gl_state_s): Declare character position members
7208 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7210 * textprop.c (verify_interval_modification, interval_of):
7211 Declare arguments EMACS_INT.
7213 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7216 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7218 * indent.c (Fvertical_motion): Local variable it_start is now
7221 * regex.c (re_match, re_match_2, re_match_2_internal)
7222 (bcmp_translate, regcomp, regexec, print_double_string)
7223 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7224 (re_compile_pattern, re_exec): Declare arguments and local
7225 variables `size_t' and `ssize_t' and return values `regoff_t', as
7227 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7228 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7229 <compile_stack_type>: `size' and `avail' are now `size_t'.
7231 * regex.h <regoff_t>: Use ssize_t, not int.
7232 (re_search, re_search_2, re_match, re_match_2): Arguments that
7233 specify buffer/string position and length are now ssize_t and
7234 size_t. Return type is regoff_t.
7236 2011-04-16 Ben Key <bkey76@gmail.com>
7238 * nsfont.m: Fixed bugs in ns_get_family and
7239 ns_descriptor_to_entity that were caused by using free to
7240 deallocate memory blocks that were allocated by xmalloc (via
7241 xstrdup). This caused Emacs to crash when compiled with
7242 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7243 --enable-checking=xmallocoverrun). xfree is now used to
7244 deallocate these memory blocks.
7246 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7248 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7250 emacs_write: Accept and return EMACS_INT for sizes.
7251 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7253 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7254 Accept and return EMACS_INT.
7255 (emacs_gnutls_write): Return the number of bytes written on
7257 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7258 (emacs_read, emacs_write): Remove check for negative size, as the
7259 Emacs source code has been audited now.
7260 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7261 (emacs_read, emacs_write): Use it.
7262 * process.c (send_process): Adjust to the new signatures of
7263 emacs_write and emacs_gnutls_write. Do not attempt to store
7264 a byte offset into an 'int'; it might overflow.
7265 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7267 * sound.c: Don't assume sizes fit in 'int'.
7268 (struct sound_device.period_size, alsa_period_size):
7269 Return EMACS_INT, not int.
7270 (struct sound_device.write, vox_write, alsa_write):
7271 Accept EMACS_INT, not int.
7272 (wav_play, au_play): Use EMACS_INT to store sizes and to
7273 record read return values.
7275 2011-04-15 Ben Key <bkey76@gmail.com>
7277 * keyboard.c (Qundefined): Don't declare static since it is used
7279 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7280 static since they are used in nsfont.m.
7282 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7284 * process.c (Qprocessp): Don't declare static.
7285 * lisp.h (Qprocessp): Declare again.
7287 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7289 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7291 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7293 Improve C-level modularity by making more things 'static'.
7295 Don't publish debugger-only interfaces to other modules.
7296 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7297 (verify_bytepos, count_markers): Move decls to the only modules
7299 * region-cache.h (pp_cache): Likewise.
7300 * window.h (check_all_windows): Likewise.
7301 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7303 * sysdep.c (croak): Now static, if
7304 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7305 * syssignal.h (croak): Declare only if not static.
7307 * alloc.c (refill_memory_reserve): Now static if
7308 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7309 * lisp.h (refill_memory_reserve): Declare only if not static.
7311 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7312 Define only if USE_LUCID.
7314 * xrdb.c (x_customization_string, x_rm_string): Now static.
7316 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7317 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7319 * xdisp.c (draw_row_with_mouse_face): Now static.
7320 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7322 * window.h (check_all_windows): Mark externally visible.
7324 * window.c (window_deletion_count): Now static.
7326 * undo.c: Make symbols static if they're not exported.
7327 (last_undo_buffer, last_boundary_position, pending_boundary):
7330 * textprop.c (interval_insert_behind_hooks): Now static.
7331 (interval_insert_in_front_hooks): Likewise.
7333 * term.c: Make symbols static if they're not exported.
7334 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7335 (max_frame_lines, tty_set_terminal_modes):
7336 (tty_reset_terminal_modes, tty_turn_off_highlight):
7337 (get_tty_terminal): Now static.
7338 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7339 * termhooks.h (term_mouse_moveto): Do not declare if
7341 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7342 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7344 * sysdep.c: Make symbols static if they're not exported.
7345 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7347 (sigprocmask_set, full_mask): Remove; unused.
7348 (wait_debugging): Mark as visible.
7349 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7350 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7352 * syntax.c (syntax_temp): Define only if !__GNUC__.
7354 * sound.c (current_sound_device, current_sound): Now static.
7356 * search.c (searchbufs, searchbuf_head): Now static.
7358 * scroll.c (scroll_cost): Remove; unused.
7359 * dispextern.h (scroll_cost): Remove decl.
7361 * region-cache.h (pp_cache): Mark as externally visible.
7363 * process.c: Make symbols static if they're not exported.
7364 (process_tick, update_tick, create_process, chan_process):
7365 (Vprocess_alist, proc_buffered_char, datagram_access):
7366 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7367 (deactivate_process): Mark defn as static, as well as decl.
7368 * lisp.h (create_process): Remove decl.
7369 * process.h (chan_process, Vprocess_alist): Remove decls.
7371 * print.c: Make symbols static if they're not exported.
7372 (print_depth, new_backquote_output, being_printed, print_buffer):
7373 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7374 (print_interval, print_number_index, initial_stderr_stream):
7376 * lisp.h (Fprinc): Remove decl.
7377 (debug_output_compilation_hack): Mark as externally visible.
7379 * sysdep.c (croak): Move decl from here to syssignal.h.
7380 * syssignal.h (croak): Put it here, so the API can be checked when
7381 'croak' is called from dissociate_if_controlling_tty.
7383 * minibuf.c: Make symbols static if they're not exported.
7384 (minibuf_save_list, choose_minibuf_frame): Now static.
7385 * lisp.h (choose_minibuf_frame): Remove decl.
7387 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7389 * lread.c: Make symbols static if they're not exported.
7390 (read_objects, initial_obarray, oblookup_last_bucket_number):
7392 (make_symbol): Remove; unused.
7393 * lisp.h (initial_obarray, make_symbol): Remove decls.
7395 * keyboard.c: Make symbols static if they're not exported.
7396 (single_kboard, recent_keys_index, total_keys, recent_keys):
7397 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7398 (this_single_command_key_start, echoing, last_auto_save):
7399 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7400 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7401 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7402 (Vlispy_mouse_stem, double_click_count):
7404 (force_auto_save_soon): Define only if SIGDANGER.
7405 (ignore_mouse_drag_p): Now static if
7406 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7407 (print_help): Remove; unused.
7408 (stop_character, last_timer_event): Mark as externally visible.
7409 * keyboard.h (ignore_mouse_drag_p): Declare only if
7410 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7411 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7412 * lisp.h (echoing): Remove decl.
7413 (force_auto_save_soon): Declare only if SIGDANGER.
7414 * xdisp.c (redisplay_window): Simplify code, to make it more
7415 obvious that ignore_mouse_drag_p is not accessed if !defined
7416 USE_GTK && !defined HAVE_NS.
7418 * intervals.c: Make symbols static if they're not exported.
7419 (merge_properties_sticky, merge_interval_right, delete_interval):
7421 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7423 * insdel.c: Make symbols static if they're not exported.
7424 However, leave prepare_to_modify_buffer alone. It's never
7425 called from outside this function, but that appears to be a bug.
7426 (combine_after_change_list, combine_after_change_buffer):
7427 (adjust_after_replace, signal_before_change): Now static.
7428 (adjust_after_replace_noundo): Remove; unused.
7429 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7430 (signal_before_change): Remove decls.
7432 * indent.c (val_compute_motion, val_vmotion): Now static.
7434 * image.c: Make symbols static if they're not exported.
7435 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7437 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7438 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7440 * fringe.c (standard_bitmaps): Now static.
7441 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7443 * frame.c: Make symbols static if they're not exported.
7444 (x_report_frame_params, make_terminal_frame): Now static.
7445 (get_frame_param): Now static, unless HAVE_NS.
7446 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7447 (x_get_resource_string): Remove; not used.
7448 * frame.h (make_terminal_frame, x_report_frame_params):
7449 (x_get_resource_string); Remove decls.
7450 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7451 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7453 * font.c, fontset.c: Make symbols static if they're not exported.
7454 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7455 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7456 * font.c (font_close_object): Now static.
7457 * font.h (font_close_object): Remove.
7458 * fontset.c (FONTSET_OBJLIST): Remove.
7459 (free_realized_fontset) #if-0 the body, which does nothing.
7460 (face_suitable_for_char_p): #if-0, as it's never called.
7461 * fontset.h (face_suitable_for_char_p): Remove decl.
7462 * xfaces.c (face_at_string_position):
7463 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7464 since 0 is always ASCII.
7466 * fns.c (weak_hash_tables): Now static.
7468 * fileio.c: Make symbols static if they're not exported.
7469 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7470 (Vwrite_region_annotation_buffers): Now static.
7472 * eval.c: Make symbols static if they're not exported.
7473 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7474 * lisp.h (backtrace_list): Remove decl.
7476 * emacs.c: Make symbols static if they're not exported.
7477 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7478 (fatal_error_code, fatal_error_signal_hook, standard_args):
7480 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7481 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7482 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7483 * lisp.h (fatal_error_signal_hook): Remove decl.
7484 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7486 * editfns.c: Move a (normally-unused) function to its only use.
7487 * editfns.c, lisp.h (get_operating_system_release): Remove.
7488 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7489 worth the hassle of breaking this out.
7491 * xterm.c: Make symbols static if they're not exported.
7492 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7493 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7494 (x_destroy_window, x_delete_display):
7496 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7497 (x_mouse_leave): Remove; unused.
7498 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7499 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7500 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7502 (x_mouse_leave): Declare only if WINDOWSNT.
7503 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7504 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7507 * ftxfont.c: Make symbols static if they're not exported.
7508 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7510 * font.h (ftxfont_driver): Likewise.
7512 * xfns.c: Make symbols static if they're not exported.
7513 (x_last_font_name, x_display_info_for_name):
7514 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7515 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7516 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7517 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7518 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7519 (last_show_tip_args): Now static.
7520 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7521 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7522 (x_screen_planes): Remove; unused.
7523 * dispextern.h (x_screen_planes): Remove decl.
7525 * dispnew.c: Make symbols static if they're not exported.
7526 * dispextern.h (redraw_garbaged_frames, scrolling):
7527 (increment_row_positions): Remove.
7528 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7529 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7531 (redraw_garbaged_frames): Remove; unused.
7533 * xfaces.c: Make symbols static if they're not exported.
7534 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7536 * xterm.h (defined_color): Remove decls.
7537 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7538 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7539 (menu_face_changed_default, defined_color, free_realized_face):
7540 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7541 (ascii_face_of_lisp_face): Remove; unused.
7543 * xdisp.c: Make symbols static if they're not exported.
7544 * dispextern.h (scratch_glyph_row, window_box_edges):
7545 (glyph_to_pixel_coords, set_cursor_from_row):
7546 (get_next_display_element, set_iterator_to_next):
7547 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7548 (show_mouse_face): Remove decls
7549 * frame.h (message_buf_print): Likewise.
7550 * lisp.h (pop_message, set_message, check_point_in_composition):
7552 * xterm.h (set_vertical_scroll_bar): Likewise.
7553 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7554 (message_buf_print, scratch_glyph_row, displayed_buffer):
7555 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7556 (get_next_display_element, show_mouse_face, window_box_edges):
7557 (frame_to_window_pixel_xy, check_point_in_composition):
7558 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7559 (glyph_to_pixel_coords): Remove; unused.
7561 * dired.c (file_name_completion): Now static.
7563 * dbusbind.c (xd_in_read_queued_messages): Now static.
7565 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7566 * data.c (circular_list_error): Remove.
7568 * commands.h (last_point_position, last_point_position_buffer):
7569 (last_point_position_window): Remove decls.
7570 * keyboard.c: Make these variables static.
7572 * coding.h (coding, code_convert_region, encode_coding_gap):
7574 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7575 (iso_code_class, detect_coding, code_convert_region): Now static.
7576 (encode_coding_gap): Remove; unused.
7578 * chartab.c (chartab_chars, chartab_bits): Now static.
7580 * charset.h (charset_iso_8859_1): Remove decl.
7581 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7584 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7585 * ccl.c (Vccl_program_table): Now static.
7586 (check_ccl_update): Remove; unused.
7588 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7589 * category.h: ... from here.
7590 * category.c (check_category_table, set_category_set): Now static.
7592 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7593 * lisp.h: Remove these decls.
7595 * buffer.c (buffer_count): Remove unused var.
7597 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7598 so that it's not optimized away.
7599 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7600 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7601 exported only to the debugger.
7603 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7604 * atimer.h (run_all_atimers): Remove; not exported.
7606 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7607 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7608 was inaccessible from Lisp.
7609 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7610 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7612 alloc.c: Import and export fewer symbols, and remove unused items.
7613 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7615 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7616 it's not optimized away by whole-program optimization.
7617 (message_enable_multibyte, free_misc): Remove.
7618 (catchlist, handlerlist, mark_backtrace):
7619 Declare only if BYTE_MARK_STACK.
7620 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7621 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7622 (message_enable_multibyte): Remove decl.
7623 (free_misc, interval_free_list, float_block, float_block_index):
7624 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7625 (cons_free_list, last_marked_index):
7627 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7628 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7629 (mark_backtrace): Define only if BYTE_MARK_STACK.
7630 * xdisp.c (message_enable_multibyte): Now static.
7632 Declare Lisp_Object Q* variables to be 'static' if not exported.
7633 This makes it easier for human readers (and static analyzers)
7634 to see whether these variables are used from other modules.
7635 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7636 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7637 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7638 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7639 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7640 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7641 * xmenu.c, xselect.c:
7642 Declare Q* vars static if they are not used in other modules.
7643 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7644 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7645 Remove decls of unexported vars.
7646 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7648 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7650 Make Emacs functions such as Fatom 'static' by default.
7651 This makes it easier for human readers (and static analyzers)
7652 to see whether these functions can be called from other modules.
7653 DEFUN now defines a static function. To make the function external
7654 so that it can be used in other C modules, use the new macro DEFUE.
7655 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7656 (Finit_image_library):
7657 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7658 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7659 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7660 Remove decls, since these functions are now static.
7661 (Funintern, Fget_internal_run_time): New decls, since these functions
7662 were already external.
7664 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7665 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7666 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7667 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7668 * keyboard.c, keymap.c, lread.c:
7669 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7670 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7671 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7672 Mark functions with DEFUE instead of DEFUN,
7673 if they are used in other modules.
7674 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7675 decls for now-static functions.
7676 * buffer.h (Fdelete_overlay): Remove decl.
7677 * callproc.c (Fgetenv_internal): Mark as internal.
7678 * composite.c (Fremove_list_of_text_properties): Remove decl.
7679 (Fcomposition_get_gstring): New forward static decl.
7680 * composite.h (Fcomposite_get_gstring): Remove decl.
7681 * dired.c (Ffile_attributes): New forward static decl.
7682 * doc.c (Fdocumntation_property): New forward static decl.
7683 * eval.c (Ffetch_bytecode): New forward static decl.
7684 (Funintern): Remove extern decl; now in .h file where it belongs.
7685 * fileio.c (Fmake_symbolic_link): New forward static decl.
7686 * image.c (Finit_image_library): New forward static decl.
7687 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7688 * intervals.h (Fprevious_property_change):
7689 (Fremove_list_of_text_properties): Remove decls.
7690 * keyboard.c (Fthis_command_keys): Remove decl.
7691 (Fcommand_execute): New forward static decl.
7692 * keymap.c (Flookup_key): New forward static decl.
7693 (Fcopy_keymap): Now static.
7694 * keymap.h (Flookup_key): Remove decl.
7695 * process.c (Fget_process): New forward static decl.
7696 (Fprocess_datagram_address): Mark as internal.
7697 * syntax.c (Fsyntax_table_p): New forward static decl.
7698 (skip_chars): Remove duplicate decl.
7699 * textprop.c (Fprevious_property_change): New forward static decl.
7700 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7702 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7703 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7705 * editfns.c (Fformat): Remove unreachable code.
7707 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7709 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7712 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7714 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7715 when at ZV. (Bug#8487)
7717 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7719 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7721 * keyboard.c (parse_tool_bar_item): Likewise.
7722 * sound.c (sound_cleanup, alsa_close): Likewise.
7723 * termcap.c (tgetent): Likewise.
7724 * xfns.c (x_default_font_parameter): Likewise.
7725 * xsettings.c (read_and_apply_settings): Likewise.
7727 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7728 (overrun_check_free): Protoize.
7730 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7732 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7733 since callers should never pass a negative size.
7734 Change the signature to match that of plain 'read' and 'write'; see
7735 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7736 * lisp.h: Update prototypes of emacs_write and emacs_read.
7738 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7740 * xdisp.c (redisplay_window): Don't try to determine the character
7741 position of the scroll margin if the window start point w->startp
7742 is outside the buffer's accessible region. (Bug#8468)
7744 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7746 Fix write-region and its subroutines for buffers > 2GB.
7747 * fileio.c (a_write, e_write): Modify declaration of arguments and
7748 local variables to support buffers larger than 2GB.
7749 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7751 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7752 argument, local variables, and return value.
7754 * lisp.h: Update prototypes of emacs_write and emacs_read.
7756 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7758 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7760 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7762 Fix more problems found by GCC 4.6.0's static checks.
7764 * xdisp.c (vmessage): Use a better test for character truncation.
7766 * charset.c (load_charset_map): <, not <=, for optimization,
7767 and to avoid potential problems with integer overflow.
7768 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7769 * casetab.c (set_identity, shuffle): Likewise.
7770 * editfns.c (Fformat): Likewise.
7771 * syntax.c (skip_chars): Likewise.
7773 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7774 This also lets GCC 4.6.0 generate slightly better loop code.
7776 * callint.c (Fcall_interactively): <, not <=, for optimization.
7777 (Fcall_interactively): Count the number of arguments produced,
7778 not the number of arguments given. This is simpler and lets GCC
7779 4.6.0 generate slightly better code.
7781 * ftfont.c: Distingish more carefully between FcChar8 and char.
7782 The previous code passed unsigned char * to a functions like
7783 strlen and xstrcasecmp that expect char *, which does not
7784 conform to the C standard.
7785 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7786 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7787 char * when the C standard requires it.
7789 * keyboard.c (read_char): Remove unused var.
7791 * eval.c: Port to Windows vsnprintf (Bug#8435).
7793 (SIZE_MAX): Define if the headers do not.
7794 (verror): Do not give up if vsnprintf returns a negative count.
7795 Instead, grow the buffer. This ports to Windows vsnprintf, which
7796 does not conform to C99. Problem reported by Eli Zaretskii.
7797 Also, simplify the allocation scheme, by avoiding the need for
7798 calling realloc, and removing the ALLOCATED variable.
7800 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7802 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7803 But keep the doprint source code for now, as we might revamp it
7804 and use it again (Bug#8435).
7805 * lisp.h (doprnt): Remove.
7806 * Makefile.in (base_obj): Remove doprnt.o.
7807 * deps.mk (doprnt.o): Remove.
7809 error: Print 32- and 64-bit integers portably (Bug#8435).
7810 Without this change, on typical 64-bit hosts error ("...%d...", N)
7811 was used to print both 32- and 64-bit integers N, which relied on
7813 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7814 * lisp.h (error, verror): Mark as printf-like functions.
7815 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7816 Report overflow in size calculations when allocating printf buffer.
7817 Do not truncate output string at its first null byte.
7818 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7819 Truncate the output at a character boundary, since vsnprintf does not
7821 * charset.c (check_iso_charset_parameter): Convert internal
7822 character to string before calling 'error', since %c now has the
7824 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7825 overflow when computing char to be passed to 'error'. Do not
7826 pass Lisp_Object to 'error'; pass the integer instead.
7827 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7828 formatted with plain %d.
7830 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7832 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7834 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7836 * xterm.c (x_catch_errors): Remove duplicate declaration.
7838 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7840 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7842 2011-04-10 Jim Meyering <meyering@redhat.com>
7844 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7845 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7846 return ssize_t not "int", and use size_t as the buffer length.
7847 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7848 * gnutls.h: Update declarations.
7849 * process.c (read_process_output): Use ssize_t, to match.
7850 (send_process): Likewise.
7852 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7854 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7856 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7858 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7859 Use unsigned char, to match FcChar8 type definition.
7861 * xterm.c (handle_one_xevent):
7862 * xmenu.c (create_and_show_popup_menu):
7863 * xselect.c (x_decline_selection_request)
7864 (x_reply_selection_request): Avoid type-punned deref of X events.
7866 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7868 Fix some uses of `int' instead of EMACS_INT.
7869 * search.c (string_match_1, fast_string_match)
7870 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7871 (scan_buffer, find_next_newline_no_quit)
7872 (find_before_next_newline, search_command, Freplace_match)
7873 (Fmatch_data): Make some `int' variables be EMACS_INT.
7875 * xdisp.c (display_count_lines): 3rd argument and return value now
7876 EMACS_INT. All callers changed.
7877 (pint2hrstr): Last argument is now EMACS_INT.
7879 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7880 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7881 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7882 (decode_coding_utf_16, decode_coding_emacs_mule)
7883 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7884 (decode_coding_ccl, decode_coding_charset)
7885 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7886 (decode_coding_iso_2022, decode_coding_emacs_mule)
7887 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7888 <char_offset, last_offset>: Declare EMACS_INT.
7889 (encode_coding_utf_8, encode_coding_utf_16)
7890 (encode_coding_emacs_mule, encode_invocation_designation)
7891 (encode_designation_at_bol, encode_coding_iso_2022)
7892 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7893 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7895 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7896 (encode_invocation_designation): Last argument P_NCHARS is now
7898 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7899 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7901 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7904 * ccl.c (Fccl_execute_on_string): Declare some variables
7907 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7909 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7911 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7913 * process.c (Fformat_network_address): Doc fix.
7915 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7917 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7919 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7921 * keyboard.c (read_char): Call Lisp function help-form-show,
7922 instead of using internal_with_output_to_temp_buffer.
7923 (Qhelp_form_show): New var.
7924 (syms_of_keyboard): Use DEFSYM macro.
7926 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7928 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7930 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7932 * process.c (Flist_processes): Remove to Lisp.
7933 (list_processes_1): Delete.
7935 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7937 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7939 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7941 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7943 Fix more problems found by GCC 4.6.0's static checks.
7945 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7947 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7949 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7951 * xdisp.c (vmessage): Mark as a printf-like function.
7953 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7955 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7957 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7958 printf-like functions.
7959 (tiff_load): Add casts to remove these marks before passing them
7960 to system-supplied API.
7962 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7964 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7965 This avoids several warnings with gcc -Wstrict-overflow.
7966 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7967 directly, rather than having caller test rule sign. This avoids
7968 some unnecessary tests.
7969 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7970 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7971 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7973 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7974 (xfont_open): Avoid unnecessary tests.
7976 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7978 * composite.h, composite.c (composition_gstring_put_cache):
7979 Use EMACS_INT, not int, for length.
7981 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7982 breaking out part of COMPOSITION_DECODE_RULE.
7983 (COMPOSITION_DECODE_RULE): Use it.
7984 * composite.c (get_composition_id): Remove unused local vars,
7985 by using the new macro.
7987 * textprop.c (set_text_properties_1): Change while to do-while,
7988 since the condition is always true at first.
7990 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7991 (interval_deletion_adjustment): Return unsigned value.
7994 * process.c (list_processes_1, create_pty, read_process_output):
7995 (exec_sentinel): Remove vars that were set but not used.
7996 (create_pty): Remove unnecessary "volatile"s.
7997 (Fnetwork_interface_info): Avoid possibility of int overflow.
7998 (read_process_output): Do adaptive read buffering even if carryover.
7999 (read_process_output): Simplify nbytes computation if buffered.
8001 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8003 * syntax.c (scan_words): Remove var that was set but not used.
8004 (update_syntax_table): Use unsigned instead of int.
8006 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8007 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8008 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8010 * print.c (print_error_message): Avoid int overflow.
8012 * font.c (font_list_entities): Redo for clarity,
8013 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8015 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8016 (font_score): Avoid potential overflow in diff calculation.
8018 * fns.c (substring_both): Remove var that is set but not used.
8019 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8021 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8023 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8024 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8025 can always succeed if overflow has undefined behavior.
8027 * search.c (boyer_moore, wordify): Remove vars set but not used.
8028 (wordify): Omit three unnecessary tests.
8030 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8031 All callers changed. This avoids the need for an unused var.
8033 * casefiddle.c (casify_region): Remove var that is set but not used.
8035 * dired.c (file_name_completion): Remove var that is set but not used.
8037 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8039 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8040 (Finsert_file_contents): Remove unnecessary code checking fd.
8042 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8043 Check for integer overflow on size calculations.
8045 * buffer.c (Fprevious_overlay_change): Remove var that is set
8048 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8049 Remove vars that are set but not used.
8050 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8051 (timer_check_2): Mark vars as initialized.
8053 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8055 * image.c (lookup_image): Remove var that is set but not used.
8056 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8058 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8059 that are set but not used.
8061 * xfns.c (make_invisible_cursor): Don't return garbage
8062 if XCreateBitmapFromData fails (Bug#8410).
8064 * xselect.c (x_get_local_selection, x_handle_property_notify):
8065 Remove vars that are set but not used.
8067 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8068 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8070 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8071 Remove var that is set but not used.
8072 (scroll_bar_windows_size): Now size_t, not int.
8073 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8076 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8077 (map_tty_color) [!defined MSDOS]: Likewise.
8079 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8081 * coding.c: Remove vars that are set but not used.
8082 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8083 All callers changed.
8084 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8085 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8086 (decode_coding_charset): Remove vars that are set but not used.
8088 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8089 that is set but not used.
8091 * print.c (print_object): Remove var that is set but not used.
8093 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8094 The gnulib version avoids calling malloc in the usual case,
8095 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8096 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8097 * filelock.c (current_lock_owner): Likewise.
8098 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8099 * sysdep.c: Include allocator.h, careadlinkat.h.
8100 (emacs_no_realloc_allocator): New static constant.
8101 (emacs_readlink): New function.
8102 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8103 ../lib/careadlinkat.h.
8105 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8107 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8108 first non-nil return value).
8110 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8112 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8113 if not defined (Bug#8403).
8115 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8117 * xdisp.c (display_count_lines): Remove parameter `start',
8118 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8119 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8120 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8121 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8122 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8123 and thereabouts. All callers changed.
8124 (get_per_char_metric): Remove parameter `f', unused since
8125 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8127 2011-04-02 Jim Meyering <meyering@redhat.com>
8129 do not dereference NULL upon failed strdup
8130 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8131 (ns_get_family): Likewise.
8133 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8135 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8137 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8139 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8142 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8144 Add lexical binding.
8146 * window.c (Ftemp_output_buffer_show): New fun.
8147 (Fsave_window_excursion):
8148 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8150 * lread.c (lisp_file_lexically_bound_p): New function.
8151 (Fload): Bind Qlexical_binding.
8152 (readevalloop): Remove `evalfun' arg.
8153 Bind Qinternal_interpreter_environment.
8154 (Feval_buffer): Bind Qlexical_binding.
8155 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8157 (syms_of_lread): Declare `lexical-binding'.
8159 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8161 * keyboard.c (eval_dyn): New fun.
8162 (menu_item_eval_property): Use it.
8164 * image.c (parse_image_spec): Use Ffunctionp.
8166 * fns.c (concat, mapcar1): Accept byte-code-functions.
8168 * eval.c (Fsetq): Handle lexical vars.
8169 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8170 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8171 (FletX, Flet): Obey lexical binding.
8172 (Fcommandp): Handle closures.
8173 (Feval): New `lexical' arg.
8174 (eval_sub): New function extracted from Feval. Use it almost
8175 everywhere where Feval was used. Look up vars in lexical env.
8177 (Ffunctionp): Move from subr.el.
8178 (Ffuncall): Handle closures.
8179 (apply_lambda): Remove `eval_flags'.
8180 (funcall_lambda): Handle closures and new byte-code-functions.
8181 (Fspecial_variable_p): New function.
8182 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8183 but without exporting it to Lisp.
8185 * doc.c (Fdocumentation, store_function_docstring):
8186 * data.c (Finteractive_form): Handle closures.
8188 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8191 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8193 (exec_byte_code): New function extracted from Fbyte_code to handle new
8194 calling convention for byte-code-functions. Add new byte-codes.
8196 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8198 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8200 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8202 * xdisp.c (redisplay_internal): Fix prototype.
8204 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8206 * xdisp.c (SCROLL_LIMIT): New macro.
8207 (try_scrolling): Use it when setting scroll_limit.
8208 Limit scrolling to 100 screen lines.
8209 (redisplay_window): Even when falling back on "recentering",
8210 position point in the window according to scroll-conservatively,
8211 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8213 (try_scrolling): When point is above the window, allow searching
8214 as far as scroll_max, or one screenful, to compute vertical
8215 distance from PT to the scroll margin position. This prevents
8216 try_scrolling from unnecessarily failing when
8217 scroll-conservatively is set to a value slightly larger than the
8218 window height. Clean up the case of PT below the margin at bottom
8219 of window: scroll_max can no longer be INT_MAX. When aggressive
8220 scrolling is in use, don't let point enter the opposite scroll
8221 margin as result of the scroll.
8222 (syms_of_xdisp) <scroll-conservatively>: Document the
8223 threshold of 100 lines for never-recentering scrolling.
8225 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8227 * dispextern.h (move_it_by_lines):
8228 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8229 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8230 (message_log_check_duplicate): Remove parameters `prev_bol' and
8231 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8232 (redisplay_internal): Remove parameter `preserve_echo_area',
8233 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8235 * indent.c (Fvertical_motion):
8236 * window.c (window_scroll_pixel_based, Frecenter):
8237 Don't pass `need_y_p' to `move_it_by_lines'.
8239 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8241 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8242 steal a few bits to be more compact.
8243 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8244 Remove unneeded casts.
8246 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8248 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8250 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8251 binding" message (bug#7967).
8253 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8255 Fix more problems found by GCC 4.6.0's static checks.
8257 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8258 Remove unused local var.
8260 * editfns.c (Fmessage_box): Remove unused local var.
8262 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8263 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8264 Omit unused local vars.
8265 * window.c (shrink_windows): Omit unused local var.
8266 * menu.c (digest_single_submenu): Omit unused local var.
8267 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8268 Omit unused local var.
8270 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8271 Don't assume string length fits in int.
8272 (keyremap_step, read_key_sequence): Use size_t for sizes.
8273 (read_key_sequence): Don't check last_real_key_start redundantly.
8275 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8276 instead of alloca (Bug#8344).
8278 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8279 (Fbacktrace_frame): Don't assume nframes fits in int.
8281 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8283 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8286 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8288 * cm.c (calccost): Turn while-do into do-while, for clarity.
8290 * keyboard.c (syms_of_keyboard): Use the same style as later
8291 in this function when indexing through an array. This also
8292 works around GCC bug 48267.
8294 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8296 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8298 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8299 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8301 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8302 This avoids undefined behavior on integer overflow, and is a bit
8303 more convenient anyway since it is compared to a size_t variable.
8305 Variadic C functions now count arguments with size_t, not int.
8306 This avoids an unnecessary limitation on 64-bit machines, which
8307 caused (substring ...) to crash on large vectors (Bug#8344).
8308 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8309 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8310 All variadic functions and their callers changed accordingly.
8311 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8312 * data.c (arith_driver, float_arith_driver): Likewise.
8313 * editfns.c (general_insert_function): Likewise.
8314 * eval.c (struct backtrace.nargs, interactive_p)
8315 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8316 (funcall_lambda, mark_backtrace): Likewise.
8317 * fns.c (concat): Likewise.
8318 * frame.c (x_set_frame_parameters): Likewise.
8319 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8320 0 if not found, not -1. All callers changed.
8322 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8323 (stack_copy_size): Now size_t, not int.
8324 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8326 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8328 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8329 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8330 All callers changed.
8332 * lisp.h (multibyte_char_to_unibyte):
8333 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8334 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8335 * character.h (CHAR_TO_BYTE8):
8336 * cmds.c (internal_self_insert):
8337 * editfns.c (general_insert_function):
8338 * keymap.c (push_key_description):
8339 * search.c (Freplace_match):
8340 * xdisp.c (message_dolog, set_message_1): All callers changed.
8342 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8344 * keyboard.c (safe_run_hook_funcall): New function.
8345 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8346 don't set the hook to nil, but remove the offending function instead.
8347 (Qcommand_hook_internal): Remove, unused.
8348 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8349 Vcommand_hook_internal.
8351 * eval.c (enum run_hooks_condition): Remove.
8352 (funcall_nil, funcall_not): New functions.
8353 (run_hook_with_args): Call each function through a `funcall' argument.
8354 Remove `cond' argument, now redundant.
8355 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8356 (Frun_hook_with_args_until_failure): Adjust accordingly.
8357 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8359 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8361 * dispextern.h (string_buffer_position): Remove declaration.
8363 * print.c (strout): Remove parameter `multibyte', unused since
8364 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8366 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8367 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8368 All callers changed.
8370 * w32.c (_wsa_errlist): Use braces for struct initializers.
8372 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8373 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8374 All callers changed.
8375 (string_buffer_position): Likewise. Also, make static (it's never
8376 used outside xdisp.c).
8377 (cursor_row_p): Remove parameter `w', unused since
8378 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8379 (decode_mode_spec): Remove parameter `precision', introduced during
8380 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8381 All callers changed.
8383 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8385 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8387 2011-03-27 Anders Lindgren <andlind@gmail.com>
8389 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8390 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8391 (ns_update_auto_hide_menu_bar): New functions.
8392 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8393 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8394 ns_constrain_all_frames.
8395 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8396 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8398 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8400 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8402 2011-03-27 Glenn Morris <rgm@gnu.org>
8404 * syssignal.h: Replace RETSIGTYPE with void.
8405 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8406 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8407 Replace SIGTYPE with void everywhere.
8408 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8409 * s/template.h (SIGTYPE): Remove commented out definition.
8411 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8413 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8414 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8416 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8418 * w32.c (read_unc_volume): Use parameter `henum', instead of
8419 global variable `wget_enum_handle'.
8421 * keymap.c (describe_vector): Remove parameters `indices' and
8422 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8423 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8425 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8427 * keyboard.c (timer_check): Remove parameter `do_it_now',
8428 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8429 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8430 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8432 * keyboard.c (read_char):
8433 * w32menu.c (w32_menu_display_help):
8434 * xmenu.c (show_help_event, menu_help_callback):
8435 Adjust calls to `show_help_echo'.
8437 * gtkutil.c (xg_maybe_add_timer):
8438 * keyboard.c (readable_events):
8439 * process.c (wait_reading_process_output):
8440 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8442 * insdel.c (adjust_markers_gap_motion):
8443 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8444 (gap_left, gap_right): Don't call it.
8446 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8448 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8449 incurred during fontification.
8451 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8453 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8454 (DEFVAR_PER_BUFFER): Don't pass it.
8456 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8457 (scrolling_window): Don't pass it.
8459 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8461 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8463 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8465 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8466 of variables specific to SELinux and computation of `encoded_absname'.
8468 * image.c (XPutPixel): Remove unused variable `height'.
8470 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8472 * unexw32.c (get_section_info): Remove unused variable `section'.
8474 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8475 (system_process_attributes): Remove unused variable `sess'.
8476 (sys_read): Remove unused variable `err'.
8478 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8479 (w32_wnd_proc): Remove unused variable `isdead'.
8480 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8481 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8482 (x_create_tip_frame): Remove unused variable `tem'.
8484 * w32inevt.c (w32_console_read_socket):
8485 Remove unused variable `no_events'.
8487 * w32term.c (x_draw_composite_glyph_string_foreground):
8488 Remove unused variable `width'.
8490 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8492 * w32term.c (x_set_glyph_string_clipping):
8493 Don't pass uninitialized region to CombineRgn.
8495 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8497 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8498 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8499 (Fx_close_connection): Remove unused variable `i'.
8501 * w32font.c (w32font_draw): Return number of glyphs.
8502 (w32font_open_internal): Remove unused variable `i'.
8503 (w32font_driver): Add missing initializer.
8505 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8506 (fill_in_menu): Remove unused variable `items_added'.
8508 * w32term.c (last_mouse_press_frame): Remove static global variable.
8509 (w32_clip_to_row): Remove unused variable `f'.
8510 (x_delete_terminal): Remove unused variable `i'.
8512 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8513 (NOTHING): Remove unused static global variable.
8514 (uniscribe_check_otf): Remove unused variable `table'.
8515 (uniscribe_font_driver): Add missing initializers.
8517 2011-03-23 Julien Danjou <julien@danjou.info>
8519 * term.c (Fsuspend_tty, Fresume_tty):
8520 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8521 * window.c (temp_output_buffer_show):
8522 * insdel.c (signal_before_change):
8523 * frame.c (Fhandle_switch_frame):
8524 * fileio.c (Fdo_auto_save):
8525 * emacs.c (Fkill_emacs):
8526 * editfns.c (save_excursion_restore):
8527 * cmds.c (internal_self_insert):
8528 * callint.c (Fcall_interactively):
8529 * buffer.c (Fkill_all_local_variables):
8530 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8532 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8533 unconditionally since it does the check itself.
8535 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8537 Fix more problems found by GCC 4.5.2's static checks.
8539 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8540 the first time through the loop, since we know p0 < p1 then.
8541 This also avoids a gcc -Wstrict-overflow warning.
8543 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8544 leading to a memory leak, possible in functions like
8545 load_charset_map_from_file that can allocate an unbounded number
8546 of objects (Bug#8318).
8548 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8549 that could (at least in theory) be that large.
8551 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8552 This is less likely to overflow, and avoids undefined behavior if
8553 overflow does occur. All callers changed. Use strtoul to scan
8554 for the unsigned long integer.
8555 (pint2hrstr): Simplify and tune code slightly.
8556 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8558 * scroll.c (do_scrolling): Work around GCC bug 48228.
8559 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8561 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8562 This also avoids a warning with gcc -Wstrict-overflow.
8563 (validate_x_resource_name): Simplify count usage.
8564 This also avoids a warning with gcc -Wstrict-overflow.
8566 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8569 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8571 * process.c (Fmake_network_process): Use socklen_t, not int,
8572 where POSIX says socklen_t is required in portable programs.
8573 This fixes a porting bug on hosts like 64-bit HP-UX, where
8574 socklen_t is wider than int (Bug#8277).
8575 (Fmake_network_process, server_accept_connection):
8576 (wait_reading_process_output, read_process_output):
8579 * process.c: Rename or move locals to avoid shadowing.
8580 (list_processes_1, Fmake_network_process):
8581 (read_process_output_error_handler, exec_sentinel_error_handler):
8582 Rename or move locals.
8583 (Fmake_network_process): Define label "retry_connect" only if needed.
8584 (Fnetwork_interface_info): Fix pointer signedness.
8585 (process_send_signal): Add cast to avoid pointer signedness problem.
8586 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8587 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8589 Make tparam.h and terminfo.c consistent.
8590 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8591 Include tparam.h instead, since it declares them.
8592 * cm.h (PC): Remove extern decl; tparam.h now does this.
8593 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8594 * terminfo.c: Include tparam.h, to check interfaces.
8595 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8596 (tparam): Adjust signature to match interface in tparam.h;
8597 this removes some undefined behavior. Check that outstring and len
8598 are zero, which they always are with Emacs.
8599 * tparam.h (PC, BC, UP): New extern decls.
8601 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8602 (xftfont_open): Rename locals to avoid shadowing.
8604 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8605 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8606 (OTF_TAG_SYM): Omit macro if not needed.
8607 (ftfont_list): Remove unused local.
8608 (get_adstyle_property, ftfont_pattern_entity):
8609 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8610 Rename locals to avoid shadowing.
8612 * xfont.c (xfont_list_family): Mark var as initialized.
8614 * xml.c (make_dom): Now static.
8616 * composite.c (composition_compute_stop_pos): Rename local to
8618 (composition_reseat_it): Remove unused locals.
8619 (find_automatic_composition, composition_adjust_point): Likewise.
8620 (composition_update_it): Mark var as initialized.
8621 (find_automatic_composition): Mark vars as initialized,
8622 with a FIXME (Bug#8290).
8624 character.h: Rename locals to avoid shadowing.
8625 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8626 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8627 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8628 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8631 * textprop.c (property_change_between_p): Remove; unused.
8633 * intervals.c (interval_start_pos): Now static.
8635 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8637 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8638 Rename locals to avoid shadowing.
8640 * sound.c (wav_play, au_play, Fplay_sound_internal):
8641 Fix pointer signedness.
8642 (alsa_choose_format): Remove unused local var.
8643 (wav_play): Initialize a variable to 0, to prevent undefined
8644 behavior (Bug#8278).
8646 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8648 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8650 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8651 clobbering (Bug#8298).
8652 * sysdep.c (sys_subshell): Likewise.
8653 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8655 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8656 This should get cleaned up, so that child_setup has the
8657 same signature on all platforms.
8659 * callproc.c (call_process_cleanup): Now static.
8660 (relocate_fd): Rename locals to avoid shadowing.
8662 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8664 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8665 not to be necessary, and produces flickering.
8667 2011-03-20 Glenn Morris <rgm@gnu.org>
8669 * config.in: Remove file.
8671 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8673 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8674 are now in src/globals.h.
8675 (syms_of_minibuf): Remove spurious & from previous change.
8677 2011-03-20 Leo Liu <sdl.web@gmail.com>
8679 * minibuf.c (completing-read-function): New variable.
8680 (completing-read-default): Rename from completing-read.
8681 (completing-read): Call completing-read-function.
8683 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8685 * xfaces.c (Fx_load_color_file):
8686 Read color file from absolute filename (bug#8250).
8688 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8690 * makefile.w32-in: Update dependencies.
8692 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8694 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8696 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8698 Fix more problems found by GCC 4.5.2's static checks.
8700 * process.c (make_serial_process_unwind, send_process_trap):
8701 (sigchld_handler): Now static.
8703 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8704 That way, the code declares only the vars that it needs.
8705 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8706 * s/cygwin.h (PTY_ITERATION): Likewise.
8707 * s/darwin.h (PTY_ITERATION): Likewise.
8708 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8710 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8711 * process.c (allocate_pty): Don't declare stb unless it's needed.
8713 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8714 (CONSTANTLIM): Remove; unused.
8715 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8716 Define only if needed.
8718 * unexelf.c (unexec): Name an expression,
8719 to avoid gcc -Wbad-function-cast warning.
8720 Use a different way to cause a compilation error if anyone uses
8721 n rather than nn, a way that does not involve shadowing.
8722 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8724 * deps.mk (unexalpha.o): Remove; unused.
8726 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8727 * unexec.h: New file.
8728 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8729 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8731 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8732 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8733 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8734 Change as necessary to match prototype in unexec.h.
8736 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8738 (back_comment, skip_chars): Mark vars as initialized.
8740 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8741 Rename locals to avoid shadowing.
8743 * lread.c (read1): Rewrite so as not to use empty "else".
8744 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8746 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8748 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8749 warning when compiling print.c.
8751 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8752 instead of using an uninitialized var.
8753 (font_sort_entities): Mark var as initialized.
8755 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8757 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8758 pointers to constants.
8759 (font_parse_fcname): Remove unused vars.
8760 (font_delete_unmatched): Now static.
8761 (font_get_spec): Remove; unused.
8762 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8763 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8764 Rename or move locals to avoid shadowing.
8766 * fns.c (require_nesting_list, require_unwind): Now static.
8767 (Ffillarray): Rename locals to avoid shadowing.
8769 * floatfns.c (domain_error2): Define only if needed.
8770 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8772 * alloc.c (mark_backtrace): Move decl from here ...
8773 * lisp.h: ... to here, so that it can be checked.
8775 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8776 (Fdefvar): Rewrite so as not to use empty "else".
8777 (lisp_indirect_variable): Name an expression,
8778 to avoid gcc -Wbad-function-cast warning.
8779 (Fdefvar): Rename locals to avoid shadowing.
8781 * callint.c (quotify_arg, quotify_args): Now static.
8782 (Fcall_interactively): Rename locals to avoid shadowing.
8783 Use const pointer when appropriate.
8785 * lisp.h (get_system_name, get_operating_system_release):
8786 Move decls here, to check interfaces.
8787 * process.c (get_operating_system_release): Move decl to lisp.h.
8788 * xrdb.c (get_system_name): Likewise.
8789 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8790 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8791 some of which prompt warnings from gcc -Wbad-function-cast.
8792 (Fformat_time_string, Fencode_time, Finsert_char):
8793 (Ftranslate_region_internal, Fformat):
8794 Rename or remove local vars to avoid shadowing.
8795 (Ftranslate_region_internal): Mark var as initialized.
8797 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8800 * lisp.h (eassert): Check that the argument compiles, even if
8801 ENABLE_CHECKING is not defined.
8803 * data.c (Findirect_variable): Name an expression, to avoid
8804 gcc -Wbad-function-cast warning.
8805 (default_value, arithcompare, arith_driver, arith_error): Now static.
8806 (store_symval_forwarding): Rename local to avoid shadowing.
8807 (Fmake_variable_buffer_local, Fmake_local_variable):
8808 Mark variables as initialized.
8809 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8811 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8812 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8813 Rename locals to avoid shadowing.
8814 (mark_stack): Move local variables into the #ifdef region where
8816 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8817 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8819 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8820 (GC_STRING_CHARS): Remove; not used.
8821 (Fmemory_limit): Cast sbrk's returned value to char *.
8823 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8824 avoids undefined behavior in theory.
8826 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8828 Use functions, not macros, for up- and down-casing (Bug#8254).
8829 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8830 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8831 to use the following functions instead of these macros.
8832 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8833 EMACS_INT, since callers assume the returned value fits in int.
8834 (upcase1): Likewise, for UPCASE_TABLE.
8835 (uppercasep, lowercasep, upcase): New static inline functions.
8836 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8837 the race-condition problem in the old DOWNCASE.
8839 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8840 Rename locals to avoid shadowing.
8841 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8842 (regex_compile, re_search_2, re_match_2_internal):
8843 Remove unused local vars.
8844 (FREE_VAR): Rewrite so as not to use empty "else",
8845 which gcc can warn about.
8846 (regex_compile, re_match_2_internal): Mark locals as initialized.
8847 (RETALLOC_IF): Define only if needed.
8848 (WORDCHAR_P): Likewise. This one is never needed, but is used
8849 only in a comment talking about a compiler bug, so put inside
8850 the #if 0 of that comment.
8851 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8852 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8855 * search.c (boyer_moore): Rename locals to avoid shadowing.
8856 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8857 (PREV_CHAR_BOUNDARY): Likewise.
8859 * search.c (simple_search): Remove unused var.
8861 * dired.c (compile_pattern): Move decl from here ...
8862 * lisp.h: ... to here, so that it can be checked.
8863 (struct re_registers): New forward decl.
8865 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8867 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8869 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8870 Rename locals to avoid shadowing.
8871 (Fvertical_motion): Mark locals as initialized.
8873 * casefiddle.c (casify_object, casify_region): Now static.
8874 (casify_region): Mark local as initialized.
8876 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8878 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8879 New macros, so that the caller can use some names other than
8880 gcpro1, gcpro2, etc.
8881 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8883 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8884 argument, for consistency with GCPRO2_VAR, etc: it is now the
8885 prefix of the variable, not the variable itself. All uses
8887 * dired.c (directory_files_internal, file_name_completion):
8888 Rename locals to avoid shadowing.
8890 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8891 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8892 dired.c's scmp function, had undefined behavior.
8893 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8894 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8895 * buffer.h: ... to here, because these macros use current_buffer,
8896 and the new implementation with inline functions needs to have
8897 current_buffer in scope now, rather than later when the macros
8899 (downcase, upcase1): New static inline functions.
8900 (DOWNCASE, UPCASE1): Reimplement using these functions.
8901 This avoids undefined behavior in expressions like
8902 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8903 from race conditions in accessing the global variables
8904 case_temp1 and case_temp2.
8905 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8906 * lisp.h (case_temp1, case_temp2): Remove their decls.
8907 * character.h (ASCII_CHAR_P): Move from here ...
8908 * lisp.h: ... to here, so that the inline functions mentioned
8911 * dired.c (directory_files_internal_unwind): Now static.
8913 * fileio.c (file_name_as_directory, directory_file_name):
8914 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8916 (file_name_as_directory): Use const pointers when appropriate.
8917 (Fexpand_file_name): Likewise. In particular, newdir might
8918 point at constant storage, so make it a const pointer.
8919 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8920 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8922 (Fset_file_times, Finsert_file_contents, auto_save_error):
8923 Rename locals to avoid shadowing.
8925 * minibuf.c (choose_minibuf_frame_1): Now static.
8926 (Ftry_completion, Fall_completions): Rename or remove locals
8929 * marker.c (bytepos_to_charpos): Remove; unused.
8931 * lisp.h (verify_bytepos, count_markers): New decls,
8932 so that gcc does not warn that these functions aren't declared.
8934 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8935 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8936 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8937 (copy_text): Remove unused local var.
8939 * filelock.c (within_one_second): Now static.
8940 (lock_file_1): Rename local to avoid shadowing.
8942 * buffer.c (fix_overlays_before): Mark locals as initialized.
8943 (fix_start_end_in_overlays): Likewise. This function should be
8944 simplified by using pointers-to-pointers, but that's a different
8946 (switch_to_buffer_1): Now static.
8947 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8948 (report_overlay_modification): Rename locals to avoid shadowing.
8950 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8951 Fix pointer signedness issue.
8952 (sys_subshell): Mark local as volatile if checking for lint,
8953 to suppress a gcc -Wclobbered warning that does not seem to be right.
8954 (MAXPATHLEN): Define only if needed.
8956 * process.c (serial_open, serial_configure): Move decls from here ...
8957 * systty.h: ... to here, so that they can be checked.
8959 * fns.c (get_random, seed_random): Move extern decls from here ...
8960 * lisp.h: ... to here, so that they can be checked.
8962 * sysdep.c (reset_io): Now static.
8963 (wait_for_termination_signal): Remove; unused.
8965 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8966 (copy_keymap_item, append_key, push_text_char_description):
8968 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8969 (DENSE_TABLE_SIZE): Remove; unused.
8970 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8971 (describe_map_tree):
8972 Rename locals to avoid shadowing.
8974 * keyboard.c: Declare functions static if they are not used elsewhere.
8975 (echo_char, echo_dash, cmd_error, top_level_2):
8976 (poll_for_input, handle_async_input): Now static.
8977 (read_char, kbd_buffer_get_event, make_lispy_position):
8978 (make_lispy_event, make_lispy_movement, apply_modifiers):
8979 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8980 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8981 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8982 (read_key_sequence, read_char): Mark locals as initialized.
8983 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8985 * keyboard.h (make_ctrl_char): New decl.
8986 (mark_kboards): Move decl here ...
8987 * alloc.c (mark_kboards): ... from here.
8989 * lisp.h (force_auto_save_soon): New decl.
8991 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8992 (DEFINE_DUMMY_FUNCTION): New macro.
8993 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8995 (main): Add casts to avoid warnings
8996 if GCC considers string literals to be constants.
8998 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9000 * dbusbind.c: Pointer signedness fixes.
9001 (xd_signature, xd_append_arg, xd_initialize):
9002 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9003 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9004 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9005 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9007 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9008 if GCC considers string literals to be constants.
9009 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9011 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9013 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9014 (print_preprocess, print_object): New macro to fix last change.
9016 * print.c (print_preprocess): Don't forget font objects.
9018 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9020 * emacs.c (USAGE3): Doc fixes.
9022 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9024 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9027 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9029 * lisp.h (VWindow_system, Qfile_name_history):
9030 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9031 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9032 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9034 * w32select.c: Don't #include "keyboard.h".
9035 (run_protected): Add extern declaration for waiting_for_input.
9037 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9038 * w32console.c (detect_input_pending, read_input_pending)
9039 (encode_terminal_code):
9040 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9041 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9042 (w32_system_caret_y, Qfile_name_history):
9043 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9044 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9045 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9046 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9047 * w32proc.c (Qlocal, report_file_error):
9048 * w32term.c (Vwindow_system, updating_frame):
9049 * w32uniscribe.c (initialized, uniscribe_font_driver):
9050 Remove unneeded extern declarations.
9052 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9054 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9056 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9058 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9059 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9060 These macros can no longer be used for assignment.
9062 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9063 Assign struct members directly, instead of using BUF_BEGV etc.
9064 (record_buffer_markers, fetch_buffer_markers): New functions for
9065 recording and fetching special buffer markers.
9066 (set_buffer_internal_1, set_buffer_temp): Use them.
9068 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9070 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9072 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9073 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9075 * xdisp.c (hscroll_window_tree):
9076 (reconsider_clip_changes): Use PT instead of BUF_PT.
9078 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9080 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9081 $(EMACS_ROOT)/lib/intprops.h.
9083 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9085 Fix more problems found by GCC 4.5.2's static checks.
9087 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9088 to unsigned char * to avoid compiler diagnostic.
9089 (xg_free_frame_widgets): Make it clear that a local variable is
9090 needed only if USE_GTK_TOOLTIP.
9091 (gdk_window_get_screen): Make it clear that this macro is needed
9092 only if USE_GTK_TOOLTIP.
9093 (int_gtk_range_get_value): New function, which avoids a diagnostic
9094 from gcc -Wbad-function-cast.
9095 (xg_set_toolkit_scroll_bar_thumb): Use it.
9096 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9097 diagnostic from gcc -Wbad-function-cast.
9098 (get_utf8_string, xg_get_file_with_chooser):
9099 Rename locals to avoid shadowing.
9100 (create_dialog): Move locals to avoid shadowing.
9102 * xgselect.c (xg_select): Remove unused var.
9104 * image.c (four_corners_best): Mark locals as initialized.
9105 (gif_load): Initialize transparent_p to zero (Bug#8238).
9106 Mark another local as initialized.
9107 (my_png_error, my_error_exit): Mark with NO_RETURN.
9109 * image.c (clear_image_cache): Now static.
9110 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9111 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9112 (x_edge_detection): Remove unnecessary cast that
9113 gcc -Wbad-function-cast diagnoses.
9114 (gif_load): Fix pointer signedness.
9115 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9116 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9118 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9120 Improve quality of tests for time stamp overflow.
9121 For example, without this patch (encode-time 0 0 0 1 1
9122 1152921504606846976) returns the obviously-bogus value (-948597
9123 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9124 reports time overflow. See
9125 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9126 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9127 * editfns.c: Include limits.h and intprops.h.
9128 (TIME_T_MIN, TIME_T_MAX): New macros.
9129 (time_overflow): Move earlier, to before first use.
9130 (hi_time, lo_time): New functions, for an accurate test for
9132 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9133 (Fget_internal_run_time): Don't assume time_t fits in int.
9134 (make_time): Use list2 instead of Fcons twice.
9135 (Fdecode_time): More accurate test for out-of-range times.
9136 (check_tm_member): New function.
9137 (Fencode_time): Use it, to test for out-of-range times.
9138 (lisp_time_argument): Don't rely on undefined left-shift and
9139 right-shift behavior when checking for time stamp overflow.
9141 * editfns.c (time_overflow): New function, refactoring common code.
9142 (Fformat_time_string, Fdecode_time, Fencode_time):
9143 (Fcurrent_time_string): Use it.
9145 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9146 * dired.c (make_time): Move to ...
9147 * editfns.c (make_time): ... here.
9148 * systime.h: Note the move.
9150 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9152 * fringe.c (update_window_fringes): Remove unused variables.
9154 * unexmacosx.c (copy_data_segment): Also copy __got section.
9157 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9159 * termcap.c [MSDOS]: Include "msdos.h".
9160 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9161 Constify `char *' arguments and their references according to
9162 prototypes in tparam.h.
9164 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9166 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9167 Adapt all references accordingly.
9169 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9171 2011-03-11 Tom Tromey <tromey@redhat.com>
9173 * buffer.c (syms_of_buffer): Remove obsolete comment.
9175 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9177 * termhooks.h (encode_terminal_code): Declare prototype.
9179 * msdos.c (encode_terminal_code): Don't declare prototype.
9181 * term.c (encode_terminal_code): Now external again, used by
9182 w32console.c and msdos.c.
9184 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9185 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9187 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9189 Fix some minor problems found by GCC 4.5.2's static checks.
9191 * fringe.c (update_window_fringes): Mark locals as initialized
9193 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9195 * alloc.c (mark_fringe_data): Move decl from here ...
9196 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9197 to check its interface.
9198 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9200 * fontset.c (free_realized_fontset): Now static.
9201 (Fset_fontset_font): Rename local to avoid shadowing.
9202 (fontset_font): Mark local as initialized.
9203 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9205 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9207 * xselect.c (x_disown_buffer_selections): Remove; not used.
9208 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9209 (x_own_selection, Fx_disown_selection_internal): Rename locals
9211 (x_handle_dnd_message): Remove local to avoid shadowing.
9213 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9214 so that the caller can use some name other than gcpro1.
9215 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9216 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9217 (Fx_backspace_delete_keys_p):
9218 Use them to avoid shadowing, and rename vars to avoid shadowing.
9219 (x_decode_color, x_set_name, x_window): Now static.
9220 (Fx_create_frame): Add braces to silence GCC warning.
9221 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9222 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9223 Remove unused locals.
9224 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9225 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9226 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9229 * xterm.h (x_mouse_leave): New decl.
9231 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9232 Remove unused functions.
9233 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9234 (x_calc_absolute_position): Now static.
9235 (XTread_socket): Don't define label "out" unless it's used.
9236 Don't declare local "event" unless it's used.
9237 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9238 unless they are used.
9239 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9240 (x_fatal_error_signal): Remove; not used.
9241 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9242 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9243 (x_error_catcher, x_connection_closed, x_error_handler):
9244 (x_error_quitter, xembed_send_message, x_iconify_frame):
9245 (my_log_handler): Rename locals to avoid shadowing.
9246 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9247 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9249 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9250 Rename or move locals to avoid shadowing.
9251 (tty_defined_color, merge_face_heights): Now static.
9252 (free_realized_faces_for_fontset): Remove; not used.
9253 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9254 does not deduce is never used uninitialized.
9255 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9256 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9258 * terminal.c (store_terminal_param): Now static.
9260 * xmenu.c (menu_highlight_callback): Now static.
9261 (set_frame_menubar): Remove unused local.
9262 (xmenu_show): Rename parameter to avoid shadowing.
9263 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9264 since they might point to immutable storage.
9265 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9266 since it's unused otherwise.
9268 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9269 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9270 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9271 avoids a gcc -Wuninitialized diagnostic.
9272 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9273 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9274 does not deduce are never used uninitialized.
9276 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9278 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9279 * window.c (window_loop, size_window):
9280 (run_window_configuration_change_hook, enlarge_window): Likewise.
9282 * window.c (display_buffer): Now static.
9283 (size_window): Mark variables that gcc -Wuninitialized
9284 does not deduce are never used uninitialized.
9285 * window.h (check_all_windows): New decl, to forestall
9286 gcc -Wmissing-prototypes diagnostic.
9287 * dispextern.h (bidi_dump_cached_states): Likewise.
9289 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9291 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9293 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9294 and to avoid gcc -Wuninitialized warning.
9295 (load_charset_map): Mark variables that gcc -Wuninitialized
9296 does not deduce are never used uninitialized.
9297 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9299 * coding.c (coding_set_source, coding_set_destination):
9300 Use "else { /* comment */ }" rather than "else /* comment */;"
9301 for clarity, and to avoid gcc -Wempty-body warning.
9302 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9303 a block, when the outer 'i' will do.
9304 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9305 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9306 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9307 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9308 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9309 Rename locals to avoid shadowing.
9310 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9311 * coding.c (emacs_mule_char, encode_invocation_designation):
9312 Now static, since they're not used elsewhere.
9313 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9314 (decode_coding_object, encode_coding_object, detect_coding_system):
9315 (decode_coding_emacs_mule): Mark variables that gcc
9316 -Wuninitialized does not deduce are never used uninitialized.
9317 (detect_coding_iso_2022): Initialize a local variable that might
9318 be used uninitialized. Leave a FIXME because it's not clear that
9319 this initialization is needed. (Bug#8211)
9320 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9321 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9322 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9323 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9324 Remove unused macros.
9326 * category.c (hash_get_category_set): Remove unused local var.
9327 (copy_category_table): Now static, since it's not used elsewhere.
9328 * character.c (string_count_byte8): Likewise.
9330 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9331 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9333 * chartab.c (copy_sub_char_table): Now static, since it's not used
9335 (sub_char_table_ref_and_range, char_table_ref_and_range):
9336 Rename locals to avoid shadowing.
9337 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9339 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9340 (BIDI_BOB): Remove unused macro.
9342 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9343 deduce are never used uninitialized.
9344 * term.c (encode_terminal_code): Likewise.
9346 * term.c (encode_terminal_code): Now static. Remove unused local.
9348 * tparam.h: New file.
9349 * term.c, tparam.h: Include it.
9350 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9351 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9352 Move these decls to tparam.h, and make them agree with what
9353 is actually in tparam.c. The previous trick of using incompatible
9354 decls in different modules does not conform to the C standard.
9355 All callers of tparam changed to use tparam's actual API.
9356 * tparam.c (tparam1, tparam, tgoto):
9357 Use const pointers where appropriate.
9359 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9360 * cm.h (struct cm): Likewise.
9361 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9362 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9363 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9364 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9365 (turn_on_face, init_tty): Likewise.
9366 * termchar.h (struct tty_display_info): Likewise.
9368 * term.c (term_mouse_position): Rename local to avoid shadowing.
9370 * alloc.c (mark_ttys): Move decl from here ...
9371 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9373 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9375 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9377 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9379 * search.c (compile_pattern_1): Remove argument regp, unused since
9380 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9381 (compile_pattern): Don't pass it.
9383 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9385 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9386 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9388 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9390 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9392 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9393 gdk_window_get_screen, gdk_window_get_geometry,
9394 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9395 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9396 (xg_get_pixbuf_from_pixmap): New function.
9397 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9398 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9399 Call xg_get_pixbuf_from_pixmap instead of
9400 gdk_pixbuf_get_from_drawable.
9401 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9402 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9403 (xg_check_special_colors): Use GtkStyleContext and its functions
9405 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9406 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9407 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9408 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9409 Call gtk_widget_get_preferred_size.
9410 (xg_frame_resized): gdk_window_get_geometry only takes 5
9412 (xg_win_to_widget, xg_event_is_for_menubar):
9413 Call gdk_x11_window_lookup_for_display.
9414 (xg_set_widget_bg): New function.
9415 (delete_cb): New function.
9416 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9417 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9418 (xg_set_background_color): Call xg_set_widget_bg.
9419 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9420 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9421 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9422 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9424 (update_frame_tool_bar): Call gtk_widget_hide.
9425 (xg_initialize): Use GDK_KEY_g.
9427 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9429 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9431 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9432 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9433 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9435 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9437 * w32xfns.c (select_palette): Check success of RealizePalette against
9438 GDI_ERROR, not zero.
9440 See ChangeLog.11 for earlier changes.
9446 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9448 This file is part of GNU Emacs.
9450 GNU Emacs is free software: you can redistribute it and/or modify
9451 it under the terms of the GNU General Public License as published by
9452 the Free Software Foundation, either version 3 of the License, or
9453 (at your option) any later version.
9455 GNU Emacs is distributed in the hope that it will be useful,
9456 but WITHOUT ANY WARRANTY; without even the implied warranty of
9457 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9458 GNU General Public License for more details.
9460 You should have received a copy of the GNU General Public License
9461 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.