Fix bug #11068 with window display when default face was remapped.
[bpt/emacs.git] / src / ChangeLog
1 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (append_space_for_newline): If the default face was
4 remapped, use the remapped face for the appended newline.
5 (extend_face_to_end_of_line): Use the remapped default face for
6 extending the face to the end of the line.
7 (display_line): Call extend_face_to_end_of_line when the default
8 face was remapped. (Bug#11068)
9
10 2012-03-29 Eli Zaretskii <eliz@gnu.org>
11
12 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
13
14 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
15
16 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
17
18 2012-03-27 Glenn Morris <rgm@gnu.org>
19
20 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
21 Doc fixes.
22
23 2012-03-26 Kenichi Handa <handa@m17n.org>
24
25 * dispextern.h (struct glyph): Fix previous change. Change the
26 bit length of glyphless.ch to 25 (Bug#11082).
27
28 2012-03-26 Chong Yidong <cyd@gnu.org>
29
30 * keyboard.c (Vselection_inhibit_update_commands): New variable.
31 (command_loop_1): Use it; inhibit selection update for
32 handle-select-window too (Bug#8996).
33
34 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
35
36 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
37
38 2012-03-25 Kenichi Handa <handa@m17n.org>
39
40 * dispextern.h (struct glyph): Change the bit length of
41 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
42
43 2012-03-24 Eli Zaretskii <eliz@gnu.org>
44
45 * s/ms-w32.h (tzname): Include time.h before redirecting to
46 _tzname. Fixes the MSVC build. (Bug#9960)
47
48 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
49
50 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
51 characters.
52
53 * xterm.c (XTread_socket): Only modify handling_signal if
54 !SYNC_INPUT. (Bug#11080)
55
56 2012-03-23 Eli Zaretskii <eliz@gnu.org>
57
58 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
59 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
60 when fetching a multibyte character consumes more bytes than
61 CHAR_BYTES returns, due to unification of CJK characters in
62 string_char. (Bug#11073)
63
64 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
65
66 * process.c (wait_reading_process_output): Handle pty disconnect
67 by refraining from sending oneself a SIGCHLD (bug#10933).
68
69 2012-03-22 Chong Yidong <cyd@gnu.org>
70
71 * dispextern.h (struct it): New member string_from_prefix_prop_p.
72
73 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
74 Mark string as coming from a prefix property.
75 (handle_face_prop): Use default face for prefix strings (Bug#4281).
76 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
77
78 2012-03-21 Chong Yidong <cyd@gnu.org>
79
80 * xfaces.c (Vface_remapping_alist): Doc fix.
81
82 2012-03-20 Eli Zaretskii <eliz@gnu.org>
83
84 * w32proc.c (Fw32_set_console_codepage)
85 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
86 Doc fixes.
87
88 2012-03-20 Chong Yidong <cyd@gnu.org>
89
90 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
91 to reflect default non-nil value of redisplay-dont-pause.
92
93 2012-03-19 Kenichi Handa <handa@m17n.org>
94
95 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
96 it fit in a valid range (Bug#11003).
97
98 2012-03-18 Eli Zaretskii <eliz@gnu.org>
99
100 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
101 that is not from display property, accept the row as a "cursor
102 row" if one of the string's character has a non-nil `cursor'
103 property. Fixes cursor positioning when there are newlines in
104 overlay strings, e.g. in icomplete.el. (Bug#11035)
105
106 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
107
108 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
109
110 2012-03-12 Chong Yidong <cyd@gnu.org>
111
112 * eval.c (inhibit_lisp_code): Rename from
113 inhibit_window_configuration_change_hook; move from window.c.
114
115 * xfns.c (unwind_create_frame_1, Fx_create_frame):
116 * window.c (run_window_configuration_change_hook)
117 (syms_of_window): Callers changed.
118
119 2012-03-11 Chong Yidong <cyd@gnu.org>
120
121 * keymap.c (Fkey_description): Doc fix (Bug#9700).
122
123 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
124
125 2012-03-10 Chong Yidong <cyd@gnu.org>
126
127 * frame.c (other_visible_frames): Don't assume the selected frame
128 is visible (Bug#10955).
129
130 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
131
132 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
133
134 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
135
136 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
137 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
138 zero (Bug#10954).
139
140 2012-03-03 Glenn Morris <rgm@gnu.org>
141
142 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
143
144 2012-03-02 Eli Zaretskii <eliz@gnu.org>
145
146 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
147 position past the first glyph_row that ends at ZV. (Bug#10902)
148 (redisplay_window, next_element_from_string): Fix typos in
149 comments.
150 (redisplay_window): Pass to move_it_vertically the margin in
151 pixels, not in screen lines.
152
153 2012-03-02 Glenn Morris <rgm@gnu.org>
154
155 * buffer.c (buffer-list-update-hook): Doc fix.
156
157 2012-02-29 Eli Zaretskii <eliz@gnu.org>
158
159 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
160 push_it before setting up the iterator for the first overlay
161 string, even if we have an empty string loaded.
162 (next_overlay_string): If there's an empty string on the iterator
163 stack, pop the stack. (Bug#10903)
164
165 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
166
167 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
168 Suggested by Stefan Monnier in
169 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
170 * alloc.c (widen_to_Lisp_Object): New static function.
171 (mark_memory): Also mark Lisp_Objects by fetching pointer words
172 and widening them to Lisp_Objects. This would work even if
173 USE_LSB_TAG is defined and wide integers are used, which might
174 happen in a future version of Emacs.
175
176 2012-02-25 Chong Yidong <cyd@gnu.org>
177
178 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
179 Doc fix.
180
181 * xselect.c (Fx_selection_exists_p): Doc fix.
182 (x_clipboard_manager_save_all): Print an informative message
183 before saving to clipboard manager.
184
185 2012-02-24 Chong Yidong <cyd@gnu.org>
186
187 * keyboard.c (process_special_events): Handle all X selection
188 requests in kbd_buffer, not just the next one (Bug#8869).
189
190 2012-02-23 Chong Yidong <cyd@gnu.org>
191
192 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
193 call when setting menu-bar-lines and tool-bar-lines parameters.
194 (unwind_create_frame_1): New helper function.
195
196 * window.c (inhibit_window_configuration_change_hook): New var.
197 (run_window_configuration_change_hook): Obey it.
198 (syms_of_window): Initialize it.
199
200 2012-02-22 Chong Yidong <cyd@gnu.org>
201
202 * xterm.c (x_draw_image_relief): Add missing type check for
203 Vtool_bar_button_margin (Bug#10743).
204
205 2012-02-21 Chong Yidong <cyd@gnu.org>
206
207 * fileio.c (Vfile_name_handler_alist): Doc fix.
208
209 * buffer.c (Fget_file_buffer): Protect against invalid file
210 handler return value.
211
212 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
213
214 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
215 when computing $valmask.
216
217 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
218 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
219 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
220 It's useless in that case, and it can cause problems on hosts
221 that allocate halves of EMACS_INT values separately.
222 Reported by Dan Horák. Diagnosed by Andreas Schwab in
223 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
224 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
225 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
226 it avoids undefined behavior on hosts where shifting right by more
227 than the word width has undefined behavior.
228
229 2012-02-19 Chong Yidong <cyd@gnu.org>
230
231 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
232 (Funhandled_file_name_directory, Ffile_name_as_directory)
233 (Fdirectory_file_name, Fexpand_file_name)
234 (Fsubstitute_in_file_name): Protect against invalid file handler
235 return values (Bug#10845).
236
237 2012-02-18 Eli Zaretskii <eliz@gnu.org>
238
239 * .gdbinit (pitx): Fix incorrect references to fields of the
240 iterator stack.
241
242 2012-02-17 Chong Yidong <cyd@gnu.org>
243
244 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
245
246 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
247
248 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
249 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
250
251 2012-02-15 Chong Yidong <cyd@gnu.org>
252
253 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
254 marked as special. Also, starting docstrings with * is obsolete.
255
256 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
257
258 * gnutls.c (emacs_gnutls_write): Fix last change.
259
260 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
261
262 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
263 send_process.
264
265 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
266
267 * keymap.c (Fsingle_key_description): Handle char ranges.
268
269 2012-02-12 Chong Yidong <cyd@gnu.org>
270
271 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
272 as that creates a dangerous corner case.
273
274 * window.c (Fdelete_window_internal): Invalidate the mouse
275 highlight (Bug#9904).
276
277 2012-02-12 Glenn Morris <rgm@gnu.org>
278
279 * xselect.c (Fx_own_selection_internal)
280 (Fx_get_selection_internal, Fx_disown_selection_internal)
281 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
282 * nsselect.m (Fx_own_selection_internal)
283 (Fx_disown_selection_internal, Fx_selection_exists_p)
284 (Fx_selection_owner_p, Fx_get_selection_internal):
285 Sync docs and argument specs with the xselect.c versions.
286
287 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
288
289 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
290
291 2012-02-11 Eli Zaretskii <eliz@gnu.org>
292
293 * w32select.c (Fx_selection_exists_p): Sync doc string and
294 argument list with xselect.c. (Bug#10783)
295
296 * w16select.c (Fx_selection_exists_p): Sync doc string and
297 argument list with xselect.c. (Bug#10783)
298
299 2012-02-10 Glenn Morris <rgm@gnu.org>
300
301 * fns.c (Fsecure_hash): Doc fix.
302
303 2012-02-09 Kenichi Handa <handa@m17n.org>
304
305 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
306
307 2012-02-07 Chong Yidong <cyd@gnu.org>
308
309 * buffer.c (Fbuffer_local_variables)
310 (buffer_lisp_local_variables): Handle unbound vars correctly;
311 don't let Qunbound leak into Lisp.
312
313 2012-02-07 Glenn Morris <rgm@gnu.org>
314
315 * image.c (Fimagemagick_types): Doc fix.
316
317 * image.c (imagemagick-render-type): Change it from a lisp object
318 to an integer. Move the doc here from the lisp manual.
319 Treat all values not equal to 0 the same.
320
321 2012-02-06 Chong Yidong <cyd@gnu.org>
322
323 * doc.c (store_function_docstring): Avoid applying docstring of
324 alias to base function (Bug#2603).
325
326 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
327
328 * .gdbinit (pp1, pv1): Remove redundant defines.
329 (pr): Use pp.
330
331 2012-02-04 Chong Yidong <cyd@gnu.org>
332
333 * nsterm.m: Declare a global (Bug#10694).
334
335 2012-02-04 Eli Zaretskii <eliz@gnu.org>
336
337 * w32.c (get_emacs_configuration_options):
338 Include --enable-checking, if specified, in the return value.
339
340 2012-02-04 Martin Rudalics <rudalics@gmx.at>
341
342 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
343 after rounding frame sizes. (Bug#9723)
344
345 2012-02-04 Eli Zaretskii <eliz@gnu.org>
346
347 * keyboard.c (adjust_point_for_property): Don't position point
348 before BEGV. (Bug#10696)
349
350 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
351
352 Handle overflow when computing char display width (Bug#9496).
353 * character.c (char_width): Return EMACS_INT, not int.
354 (char_width, c_string_width): Check for overflow when
355 computing the width; this is possible now that individual
356 characters can have unbounded width. Problem introduced
357 by merge from Emacs 23 on 2012-01-19.
358
359 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
360
361 * dbusbind.c (Fdbus_register_method): Mention the return value
362 :ignore in the docstring.
363
364 2012-02-02 Glenn Morris <rgm@gnu.org>
365
366 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
367
368 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
369 Unconditionally set to t. (Bug#10673)
370 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
371 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
372 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
373
374 2012-02-02 Kenichi Handa <handa@m17n.org>
375
376 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
377 0, do not call append_composite_glyph.
378
379 2012-02-02 Kenichi Handa <handa@m17n.org>
380
381 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
382 NULL (Bug#6988).
383 (x_produce_glyphs): If the component of a composition is a null
384 string, set it->pixel_width to 1 to avoid zero-width glyph.
385
386 2012-02-01 Eli Zaretskii <eliz@gnu.org>
387
388 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
389 first 2 arguments are identical. This makes inserting large
390 output from a subprocess an order of magnitude faster on
391 MS-Windows, where all sbrk'ed memory is always contiguous.
392
393 2012-01-31 Glenn Morris <rgm@gnu.org>
394
395 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
396 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
397 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
398
399 2012-01-29 Glenn Morris <rgm@gnu.org>
400
401 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
402
403 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
404
405 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
406
407 2012-01-28 Chong Yidong <cyd@gnu.org>
408
409 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
410
411 2012-01-26 Chong Yidong <cyd@gnu.org>
412
413 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
414
415 * search.c (Fsearch_forward, Fsearch_backward): Document negative
416 repeat counts (Bug#10507).
417
418 2012-01-26 Glenn Morris <rgm@gnu.org>
419
420 * lread.c (syms_of_lread): Doc fix.
421
422 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
423
424 * coding.c (encode_designation_at_bol): Change return value to
425 EMACS_INT.
426
427 2012-01-25 Chong Yidong <cyd@gnu.org>
428
429 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
430
431 2012-01-21 Chong Yidong <cyd@gnu.org>
432
433 * floatfns.c (Fcopysign): Make the second argument non-optional,
434 since nil is not allowed anyway.
435
436 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
437
438 * process.c (read_process_output): Use p instead of XPROCESS (proc).
439 (send_process): Likewise.
440
441 2012-01-19 Martin Rudalics <rudalics@gmx.at>
442
443 * window.c (save_window_save, Fcurrent_window_configuration)
444 (Vwindow_persistent_parameters): Do not use Qstate.
445 Rewrite doc-strings.
446
447 2012-01-19 Kenichi Handa <handa@m17n.org>
448
449 * character.c (char_width): New function.
450 (Fchar_width, c_string_width, lisp_string_width):
451 Use char_width (Bug#9496).
452
453 2012-01-16 Martin Rudalics <rudalics@gmx.at>
454
455 * window.c (Vwindow_persistent_parameters): New variable.
456 (Fset_window_configuration, save_window_save): Handle persistent
457 window parameters.
458
459 2012-01-14 Eli Zaretskii <eliz@gnu.org>
460
461 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
462 thrashing the stack of the thread. (Bug#9087)
463
464 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
465
466 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
467
468 2012-01-11 Eli Zaretskii <eliz@gnu.org>
469
470 * xdisp.c (rows_from_pos_range): Handle the case where the
471 highlight ends on a newline. (Bug#10464)
472 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
473 he end column for display of highlight that ends on a newline
474 before a R2L line.
475
476 2012-01-11 Glenn Morris <rgm@gnu.org>
477
478 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
479 from load-path also when installation-directory is nil. (Bug#10208)
480
481 2012-01-10 Glenn Morris <rgm@gnu.org>
482
483 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
484
485 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
486 Update template values to be closer to their typical values these days.
487
488 2012-01-09 Eli Zaretskii <eliz@gnu.org>
489
490 * xdisp.c (rows_from_pos_range): Accept additional argument
491 DISP_STRING, and accept any glyph in a row whose object is that
492 string as eligible for mouse highlight. Fixes mouse highlight of
493 display strings from overlays. (Bug#10464)
494
495 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
496
497 emacs: fix an auto-save permissions race condition (Bug#10400)
498 * fileio.c (auto_saving_dir_umask): New static var.
499 (Fmake_directory_internal): Use it.
500 (do_auto_save_make_dir): Set it, instead of invoking chmod after
501 creating the directory. The old code temporarily assigns
502 too-generous permissions to the directory.
503 (do_auto_save_eh): Clear it.
504 (Fdo_auto_save): Catch all errors, not just file errors, so
505 that the var is always cleared.
506
507 2012-01-07 Eli Zaretskii <eliz@gnu.org>
508
509 * search.c (scan_buffer): Pass character positions to
510 know_region_cache, not byte positions. (Bug#6540)
511
512 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
513
514 * w32.c (sys_rename): Report EXDEV when rename of a directory
515 fails because the target is on another logical disk. (Bug#10284)
516
517 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
518
519 * xterm.c (x_embed_request_focus): New function.
520
521 * xterm.h: Add prototype.
522
523 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
524
525 2012-01-05 Glenn Morris <rgm@gnu.org>
526
527 * emacs.c (emacs_copyright): Update short copyright year to 2012.
528
529 2012-01-01 Eli Zaretskii <eliz@gnu.org>
530
531 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
532 Load gnutls_transport_set_lowat only if GnuTLS version is below
533 2.11.1.
534 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
535 GnuTLS versions below 2.11.1.
536
537 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
538
539 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
540 to the doc string advising against its use for altering the way
541 windows are scrolled.
542
543 2011-12-28 Kenichi Handa <handa@m17n.org>
544
545 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
546 coding-system ASCII compatible only when it does not produce BOM
547 on encoding (Bug#10383).
548
549 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
550
551 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
552 can scroll.
553 (create_and_show_popup_menu): Always use menu_position_func for
554 Gtk3 (Bug#10361).
555
556 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
557
558 * callint.c (Fcall_interactively): Don't truncate prompt string.
559
560 2011-12-23 Eli Zaretskii <eliz@gnu.org>
561
562 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
563 property that ends at ZV, so that the bidi iteration could be
564 resumed from there (after widening). (Bug#10360)
565
566 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
567
568 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
569
570 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
571
572 * nsterm.m (x_free_frame_resources):
573 Release f->output_data.ns->miniimage.
574 (ns_index_color): Fix indentation. Do not retain
575 color_table->colors[i].
576
577 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
578 before returning.
579
580 * nsfns.m (x_set_background_color): Assign return value from
581 ns_index_color to face-background instead of NSColor*.
582 (ns_implicitly_set_icon_type): Fix indentation.
583 Change assignment in for loop to comparison.
584
585 * emacs.c (ns_pool): New variable.
586 (main): Assign ns_pool.
587 (Fkill_emacs): Call ns_release_autorelease_pool.
588
589 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
590 autorelease fdesc, release fdAttrs and tdict.
591 (ns_get_covering_families): Release charset.
592 (ns_findfonts): Release NSFontDescriptor created with new.
593 (ns_uni_to_glyphs): Fix indentation.
594 (setString): Release attrStr before assigning new value.
595
596 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
597
598 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
599 and NS_IMPL_COCOA.
600 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
601 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
602
603 2011-12-18 David Reitter <reitter@cmu.edu>
604
605 * nsterm.m (ns_term_init): Subscribe for notifications
606 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
607 to method trackingNotification in EmacsMenu.
608
609 * nsmenu.m (trackingMenu): New variable.
610 (trackingNotification): New method (from Aquamacs).
611 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
612 from Aquamacs (Bug#7030).
613
614 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
615
616 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
617 (symbol_to_nsstring): Fix indentation.
618 (ns_symbol_to_pb): New function.
619 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
620 (Fns_rotate_cut_buffers_internal): Remove.
621 (Fns_store_selection_internal): Rename from
622 Fns_store_cut_buffer_internal.
623 (ns_get_foreign_selection, Fx_own_selection_internal)
624 (Fx_disown_selection_internal, Fx_selection_exists_p)
625 (Fns_get_selection_internal, Fns_store_selection_internal):
626 Use ns_symbol_to_pb and check if return value is nil.
627 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
628 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
629 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
630 renamed to Sns_store_selection_internal.
631 (ns_handle_selection_request): Move code to Fx_own_selection_internal
632 and remove this function.
633 (ns_handle_selection_clear): Remove, never used.
634 (Fx_own_selection_internal): Move code from ns_handle_selection_request
635 here.
636
637 2011-12-17 Ken Brown <kbrown@cornell.edu>
638
639 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
640 GID is unknown (Bug#10257).
641
642 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
643
644 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
645 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
646 which caused a build failure on GNU/Linux IA-64. This problem was
647 introduced by my 2011-10-07 patch.
648
649 2011-12-15 Juri Linkov <juri@jurta.org>
650
651 * image.c (imagemagick_error): New function. (Bug#10112)
652 (imagemagick_load_image): Comment out `MagickSetResolution' call.
653 Use `imagemagick_error' where ImageMagick functions return
654 `MagickFalse'.
655 (Fimagemagick_types): Add `Fnreverse' to return the list in the
656 proper order.
657
658 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
659
660 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
661 fill background (Bug#8992).
662
663 2011-12-13 Martin Rudalics <rudalics@gmx.at>
664
665 * window.c (Vwindow_combination_resize)
666 (Vwindow_combination_limit): Use t instead of non-nil in
667 doc-strings.
668 (Vrecenter_redisplay): Add first sentence of doc-string on
669 separate line.
670 (Frecenter): Fix doc-string typo.
671
672 2011-12-11 Kenichi Handa <handa@m17n.org>
673
674 * coding.c (Funencodable_char_position): Pay attention to the
675 buffer text relocation (Bug#9389).
676
677 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
678
679 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
680 gtk_init (Bug#10100).
681
682 2011-12-10 Eli Zaretskii <eliz@gnu.org>
683
684 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
685 IT->string is nil. (Bug#10263)
686
687 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
688
689 * nsterm.h (x_free_frame_resources): Declare.
690
691 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
692 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
693
694 * nsterm.h (ns_get_defaults_value): Declare.
695
696 * nsterm.m (ns_default): Call ns_get_defaults_value.
697
698 2011-12-09 Eli Zaretskii <eliz@gnu.org>
699
700 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
701 (Bug#10170)
702
703 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
704
705 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
706 that where the value of an _OBJC_* symbol points to is in the .bss
707 section (Bug#10240).
708
709 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
710
711 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
712 after the loop to call ccl_driver at least once (Bug#8619).
713
714 2011-12-08 Kenichi Handa <handa@m17n.org>
715
716 * ftfont.c (get_adstyle_property): Fix previous change
717 (Bug#10233).
718
719 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
720
721 * w32.c (init_environment): If no_site_lisp, remove site-lisp
722 dirs from the default value of EMACSLOADPATH (bug#10208).
723
724 2011-12-07 Glenn Morris <rgm@gnu.org>
725
726 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
727 installation and source directories as well. (Bug#10208)
728
729 2011-12-06 Chong Yidong <cyd@gnu.org>
730
731 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
732
733 2011-12-06 Glenn Morris <rgm@gnu.org>
734
735 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
736 as an error, not just -1. (Bug#10217)
737
738 2011-12-05 Chong Yidong <cyd@gnu.org>
739
740 * keyboard.c (process_special_events): New function.
741 (swallow_events, Finput_pending_p): Use it (Bug#10195).
742
743 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
744
745 * coding.c (encode_designation_at_bol): Don't use uninitialized
746 local variable (Bug#9318).
747
748 2011-12-05 Kenichi Handa <handa@m17n.org>
749
750 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
751 return Qnil (Bug#8046, Bug#10193).
752
753 2011-12-05 Kenichi Handa <handa@m17n.org>
754
755 * coding.c (encode_designation_at_bol): New args charbuf_end and
756 dst. Return the number of produced bytes. Callers changed.
757 (coding_set_source): Return how many bytes coding->source was
758 relocated.
759 (coding_set_destination): Return how many bytes
760 coding->destination was relocated.
761 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
762 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
763
764 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
765
766 * coding.c (CODING_CHAR_CHARSET_P): New macro.
767 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
768 macro (Bug#9318).
769
770 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
771
772 The following changes are to fix Bug#9318.
773
774 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
775 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
776 (encode_coding_iso_2022, encode_coding_sjis)
777 (encode_coding_big5, encode_coding_charset): Use the above macros.
778
779 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
780
781 * lisp.h (process_quit_flag): Fix external declaration.
782
783 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
784
785 Don't macro-inline non-performance-critical code.
786 * eval.c (process_quit_flag): New function.
787 * lisp.h (QUIT): Use it.
788
789 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
790
791 * nsfns.m (get_geometry_from_preferences): New function.
792 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
793
794 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
795
796 * emacs.c (Qkill_emacs): Define.
797 (syms_of_emacs): Initialize it.
798 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
799 Qquit_flag to `kill-emacs' instead.
800 (quit_throw_to_read_char): Add parameter `from_signal'.
801 All callers changed. Call Fkill_emacs if requested and safe.
802 * lisp.h (QUIT): Call Fkill_emacs if requested.
803
804 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
805
806 * widget.c (update_wm_hints): Return if wmshell is null.
807 (widget_update_wm_size_hints): New function.
808
809 * widget.h (widget_update_wm_size_hints): Declare.
810
811 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
812 widget_update_wm_size_hints (Bug#10104).
813
814 2011-12-03 Eli Zaretskii <eliz@gnu.org>
815
816 * xdisp.c (handle_invisible_prop): If the invisible text ends just
817 before a newline, prepare the bidi iterator for consuming the
818 newline, and keep the current paragraph direction. (Bug#10183)
819 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
820
821 2011-12-02 Juri Linkov <juri@jurta.org>
822
823 * search.c (Fword_search_regexp): New Lisp function created from
824 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
825 (Fword_search_backward, Fword_search_forward)
826 (Fword_search_backward_lax, Fword_search_forward_lax):
827 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
828 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
829
830 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
831
832 * fileio.c (Finsert_file_contents): Move after-change-function call
833 to before the "handled:" label, since all "goto handled" appear in
834 cases where the *-change-functions have already been properly called
835 (bug#10117).
836
837 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
838
839 * keyboard.c (interrupt_signal): Don't call kill-emacs when
840 waiting for input. (Bug#10169)
841
842 2011-11-30 Eli Zaretskii <eliz@gnu.org>
843
844 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
845 verifies glyph row's hash code--we have just reallocated the
846 glyphs, so their contents can be complete garbage. (Bug#10164)
847
848 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
849
850 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
851
852 2011-11-30 Eli Zaretskii <eliz@gnu.org>
853
854 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
855 attributes are tested _before_ calling verify_row_hash, to protect
856 against GCC re-ordering of the tests. (Bug#10164)
857
858 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
859
860 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
861
862 * xterm.c (handle_one_xevent): Only set async_visible and friends
863 if net_wm_state_hidden_seen is non-zero (Bug#10002)
864 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
865 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
866
867 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
868
869 Remove GCPRO-related macros that exist only to avoid shadowing locals.
870 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
871 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
872 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
873 All uses changed to use GCPRO1 etc.
874 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
875 Revert to old implementation (i.e., before 2011-03-11).
876
877 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
878
879 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
880 of scroll runs so as to avoid assigning disabled bogus rows and
881 unnecessary graphics copy operations.
882
883 2011-11-27 Eli Zaretskii <eliz@gnu.org>
884
885 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
886 (snprintf) [_MSC_VER]: Redirect to _snprintf.
887 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
888 (malloc, free, realloc, calloc): Redirect to e_* only when
889 compiling Emacs.
890
891 * lisp.h (GCTYPEBITS): Move before first use.
892 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
893 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
894 this macro definition.
895
896 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
897 _MSC_VER.
898
899 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
900
901 * gtkutil.c (xg_create_frame_widgets):
902 Call gtk_window_set_has_resize_grip (FALSE) if that function is
903 present with Gtk+ 2.0.
904
905 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
906
907 * fileio.c (Finsert_file_contents): Undo previous change; see
908 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
909
910 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
911
912 Rename locals to avoid shadowing.
913 * fileio.c (Finsert_file_contents):
914 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
915 * process.c (wait_reading_process_output):
916 Rename inner 'proc' to 'p' to avoid shadowing.
917 Indent for consistency with usual Emacs style.
918
919 2011-11-25 Eli Zaretskii <eliz@gnu.org>
920
921 * xdisp.c (redisplay_window): If cursor row is not fully visible
922 after recentering, and scroll-conservatively is set to a large
923 number, scroll window by a few more lines to make the cursor fully
924 visible and out of scroll-margin. (Bug#10105)
925 (start_display): Don't move to the next line if the display should
926 start at a newline that is part of a display vector or an overlay
927 string. (Bug#10119)
928
929 2011-11-24 Juri Linkov <juri@jurta.org>
930
931 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
932 after the `MagickPingImage' call. (Bug#10112)
933
934 2011-11-23 Chong Yidong <cyd@gnu.org>
935
936 * window.c (Fcoordinates_in_window_p): Accept only live windows.
937
938 2011-11-23 Martin Rudalics <rudalics@gmx.at>
939
940 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
941 making another buffer current. (Bug#10114)
942
943 2011-11-23 Glenn Morris <rgm@gnu.org>
944
945 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
946
947 2011-11-23 Chong Yidong <cyd@gnu.org>
948
949 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
950 using it (Bug#5984).
951
952 2011-11-22 Eli Zaretskii <eliz@gnu.org>
953
954 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
955 and header-lines, as they don't have one computed for them.
956 (Bug#10098)
957
958 * .gdbinit (prow): Make displayed values more self-explaining.
959 Add row's hash code.
960
961 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
962
963 * process.c (wait_reading_process_output): Fix asynchrounous
964 GnuTLS socket handling on some versions of the GnuTLS library.
965 (wait_reading_process_output): Add comment and URL.
966
967 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
968
969 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
970
971 2011-11-21 Chong Yidong <cyd@gnu.org>
972
973 * window.c (Fnext_window, Fprevious_window): Doc fix.
974
975 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
976
977 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
978
979 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
980
981 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
982
983 2011-11-20 Martin Rudalics <rudalics@gmx.at>
984
985 * window.c (Fset_window_combination_limit): Rename argument
986 STATUS to LIMIT.
987 (Vwindow_combination_limit): Remove "status" from doc-string.
988
989 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
990
991 * m/ibms390.h: Remove.
992 * m/ibms390x.h: Don't include "ibms390.h".
993
994 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
995
996 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
997 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
998
999 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1000
1001 * casetab.c (Fset_case_table):
1002 * charset.c (Fcharset_after): Fix typos.
1003
1004 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1005
1006 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1007 Otherwise, valgrind does not work on some platforms.
1008 Problem reported by Andreas Schwab in
1009 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1010 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1011 is set, removing the need for VIRT_ADDRESS_VARIES.
1012 (PURE_P): Use a more-efficient implementation that needs just one
1013 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1014 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1015 to 4 (xorl, subq, cmpq, setbe).
1016 * alloc.c (pure): Always extern now, since that's the
1017 VIRT_ADDR_VARIES behavior.
1018 (PURE_POINTER_P): Use a single comparison, not two, for
1019 consistency with the new puresize.h.
1020 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1021 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1022 Remove VIRT_ADDR_VARIES no longer needed.
1023
1024 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1025
1026 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1027 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1028 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1029 behave as if the cursor position were at the window margin.
1030
1031 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1032 and the cursor position is out of bounds, behave as if the cursor
1033 position were at the window margin. (Bug#10075)
1034
1035 2011-11-18 Chong Yidong <cyd@gnu.org>
1036
1037 * window.c (Fwindow_combination_limit): Make first argument
1038 non-optional, since it is meaningless for live windows like the
1039 selected window.
1040
1041 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1042
1043 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1044
1045 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1046
1047 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1048 (graft_intervals_into_buffer): Simplify.
1049
1050 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1051
1052 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1053 hash values of the two rows.
1054 (copy_row_except_pointers): Preserve the used[] arrays and the
1055 hash values of the two rows. (Bug#10035)
1056 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1057
1058 * xdisp.c (row_hash): New function, body extracted from
1059 compute_line_metrics.
1060 (compute_line_metrics): Call row_hash, instead of computing the
1061 hash code inline.
1062
1063 * dispnew.c (verify_row_hash): Call row_hash for computing the
1064 hash code of a row, instead of duplicating code from xdisp.c.
1065
1066 * dispextern.h (row_hash): Add prototype.
1067
1068 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1069
1070 * frame.c (delete_frame): Don't delete the terminal when the last
1071 X frame is closed if emacs is built with GTK toolkit.
1072
1073 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1074
1075 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1076
1077 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1078
1079 * window.c (Vwindow_splits): Rename to
1080 Vwindow_combination_resize. Suggested by Juri Linkov.
1081 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1082 of Vwindow_splits.
1083
1084 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1085
1086 * nsfns.m (Fns_font_name):
1087 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1088
1089 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1090
1091 * window.h (window): Rename slot "nest" to "combination_limit".
1092 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1093 (Fset_window_nest): Rename to Fset_window_combination_limit.
1094 (Vwindow_nest): Rename to Vwindow_combination_limit.
1095 (recombine_windows, make_parent_window, make_window)
1096 (Fsplit_window_internal, saved_window)
1097 (Fset_window_configuration, save_window_save): Rename all
1098 occurrences of window_nest to window_combination_limit.
1099
1100 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1101
1102 * image.c (imagemagick_load_image): Fix typo.
1103
1104 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1105
1106 * xdisp.c (display_line): Move the call to
1107 highlight_trailing_whitespace before the call to
1108 compute_line_metrics, since the latter needs to see the final
1109 faces of all the glyphs to compute ROW's hash value.
1110 Fixes assertion violations in row_equal_p. (Bug#10035)
1111
1112 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1113
1114 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1115 just return (bug#10044).
1116
1117 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1118
1119 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1120 with user-defined heap size. Bump the default size of the temacs
1121 heap to 27MB, to avoid memory warning when running temacs.
1122 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1123
1124 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1125 current_matrix and desired_matrix. (Bug#9990)
1126 (verify_row_hash) [XASSERTS]: New function.
1127 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1128 that the hash value of glyph rows is correct.
1129
1130 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1131
1132 * window.h (window): Remove splits slot.
1133 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1134 (Fdelete_other_windows_internal, make_parent_window)
1135 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1136 (Fset_window_configuration, save_window_save): Don't deal with
1137 split status of windows.
1138 (saved_window): Remove splits slot.
1139 (Vwindow_splits): Rewrite doc-string.
1140
1141 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1142
1143 * xfns.c (unwind_create_frame):
1144 * nsfns.m (unwind_create_frame):
1145 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1146 Vframe_list (Bug#9999).
1147
1148 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1149
1150 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1151
1152 2011-11-11 Kenichi Handa <handa@m17n.org>
1153
1154 * callproc.c (Fcall_process): Set the member dst_multibyte of
1155 process_coding.
1156
1157 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1158
1159 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1160 avoid a crash (bug#9496).
1161
1162 2011-11-09 Chong Yidong <cyd@gnu.org>
1163
1164 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1165 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1166
1167 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1168
1169 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1170
1171 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1172
1173 Avoid some portability problems by eschewing 'extern inline' functions.
1174 The trivial performance wins aren't worth the portability hassles; see
1175 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1176 et seq.
1177 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1178 (window_box_width, window_box_left, window_box_left_offset)
1179 (window_box_right, window_box_right_offset): Undo previous change,
1180 by removing the "extern"s.
1181 * intervals.c (adjust_intervals_for_insertion)
1182 (adjust_intervals_for_deletion): Undo previous change,
1183 making these static again.
1184 (offset_intervals, temp_set_point_both, temp_set_point)
1185 (copy_intervals_to_string): No longer inline.
1186 * xdisp.c (window_text_bottom_y, window_box_width)
1187 (window_box_height, window_box_left_offset)
1188 (window_box_right_offset, window_box_left, window_box_right)
1189 (window_box): No longer inline.
1190
1191 2011-11-08 Chong Yidong <cyd@gnu.org>
1192
1193 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1194 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1195 Signal an error if not a live window.
1196 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1197 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1198
1199 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1200
1201 * lisp.h (syms_of_abbrev): Remove declaration.
1202 Reported by CHENG Gao <chenggao@royau.me>.
1203
1204 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1205
1206 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1207 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1208 of temacs in GUI mode.
1209
1210 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1211
1212 * window.h: Declare delete_all_child_windows instead of
1213 delete_all_subwindows.
1214 * window.c (Fwindow_nest, Fset_window_nest)
1215 (Fset_window_new_total, Fset_window_new_normal)
1216 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1217 (delete_all_subwindows): Rename to delete_all_child_windows.
1218 (Fdelete_other_windows_internal, Fset_window_configuration):
1219 Call delete_all_child_windows instead of delete_all_subwindows.
1220 * frame.c (delete_frame): Call delete_all_child_windows instead
1221 of delete_all_subwindows.
1222
1223 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1224
1225 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1226 This is also needed for porting to any host where GC_MARK_STACK is
1227 not GC_MAKE_GCPROS_NOOPS.
1228 (which_symbols): Use it.
1229
1230 2011-11-07 Kenichi Handa <handa@m17n.org>
1231
1232 * coding.c (coding_set_destination): Check coding->src_pos only
1233 when coding->src_object is a buffer (bug#9910).
1234
1235 * process.c (send_process): Set the member src_multibyte of coding
1236 to 0 (bug#9911) when sending a unibyte text.
1237
1238 * callproc.c (Fcall_process): Set the member src_multibyte of
1239 process_coding to 0 (bug#9912).
1240
1241 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1242
1243 * xmenu.c (cleanup_widget_value_tree): New function.
1244 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1245 calling free_menubar_widget_value_tree directly (Bug#9830).
1246
1247 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 Fix some portability problems with 'inline'.
1250 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1251 (window_box_width, window_box_left, window_box_left_offset)
1252 (window_box_right, window_box_right_offset): Declare extern.
1253 Otherwise, these inline functions do not conform to C99 and
1254 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1255 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1256 * intervals.c (adjust_intervals_for_insertion)
1257 (adjust_intervals_for_deletion): Now extern, because otherwise the
1258 extern inline functions 'offset_intervals' couldn't refer to it.
1259 (static_offset_intervals): Remove.
1260 (offset_intervals): Rewrite using the old contents of
1261 static_offset_intervals. The old version didn't conform to C99
1262 because an extern inline function contained a reference to an
1263 identifier with static linkage.
1264
1265 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1266
1267 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1268 GC.
1269
1270 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1271
1272 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1273 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1274 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1275 return Qleft_to_right.
1276
1277 2011-11-06 Chong Yidong <cyd@gnu.org>
1278
1279 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1280 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1281 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1282 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1283 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1284 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1285 (Fwindow_vscroll): Doc fix.
1286 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1287 argument, since it makes no sense to pass a live window and for
1288 consistency with window-child.
1289
1290 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1291
1292 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1293 support MSVC.
1294
1295 2011-11-05 Jason Rumney <jasonr@gnu.org>
1296
1297 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1298 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1299 fonts (Bug#6029).
1300 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1301 bitwise arithmetic preventing use of unicode-sip and non-truetype
1302 opentype fonts.
1303
1304 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1305
1306 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1307 "emacs"-only part.
1308
1309 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1310 initialization code to keep similarity to xfns.c after changes
1311 from 2011-11-05.
1312
1313 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1314
1315 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1316 (unwind_create_frame): New function (Bug#9943).
1317 (Fx_create_frame): Restructure code to be more similar to the one in
1318 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1319 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1320 Move terminal->reference_count++ just before making the frame official
1321 (Bug#9943).
1322
1323 * nsterm.m (x_free_frame_resources): New function.
1324 (x_destroy_window): Move code to x_free_frame_resources.
1325
1326 * xfns.c (unwind_create_frame): Fix comment.
1327 (Fx_create_frame, x_create_tip_frame):
1328 Move terminal->reference_count++ just before making the frame
1329 official. Move initialization of image_cache_refcount and
1330 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1331
1332 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1333
1334 Support MSVC build with newer versions of Visual Studio.
1335 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1336 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1337 nt/gmake.defs.
1338
1339 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1340 which are not supported by MSVC.
1341 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1342 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1343 bitfields.
1344 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1345 types in bitfields.
1346 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1347
1348 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1349
1350 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1351
1352 Support MSVC build with newer versions of Visual Studio.
1353 * w32.c: Don't include w32api.h for MSVC.
1354 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1355
1356 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1357 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1358 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1359 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1360 e_* cousins.
1361 (alloca) [_MSC_VER]: Define to _alloca.
1362
1363 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1364
1365 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1366
1367 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1368
1369 * xdisp.c (note_mouse_highlight): If either of
1370 previous/next-single-property-change returns nil, treat that as
1371 the beginning or the end of the buffer. (Bug#9955)
1372
1373 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1374
1375 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1376 label is not null (Bug#9951).
1377 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1378 may be NULL.
1379
1380 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1381
1382 * window.c (Fwindow_body_size): Mention in the doc string that the
1383 return value is in frame's canonical units. (Bug#9949)
1384
1385 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1386
1387 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1388
1389 * w32fns.c (unwind_create_frame): If needed, free the glyph
1390 matrices of the partially constructed frame. (Bug#9943)
1391 * xfns.c (unwind_create_frame): Likewise.
1392
1393 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1394
1395 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1396 Don't stop backward scan on the continuation glyph, even though
1397 its CHARPOS is positive.
1398 (mouse_face_from_buffer_pos, note_mouse_highlight):
1399 Rename cover_string to disp_string.
1400
1401 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1402
1403 * window.c (temp_output_buffer_show): Don't use
1404 Vtemp_buffer_show_specifiers.
1405 (Vtemp_buffer_show_specifiers): Remove unused variable.
1406
1407 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1408
1409 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1410 past the beginning of the current glyph matrix.
1411
1412 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1413
1414 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1415 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1416 HAVE_GTK3 (Bug#9869).
1417
1418 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1419 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1420
1421 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1422
1423 * xterm.c: Declare x_handle_net_wm_state to return int.
1424 (handle_one_xevent): Check if we are iconified but don't have
1425 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1426 (get_current_wm_state): Return non-zero if not hidden,
1427 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1428 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1429 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1430 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1431
1432 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1433
1434 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1435 so that this new function doesn't get optimized away by a
1436 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1437
1438 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1439
1440 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1441
1442 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1443
1444 Fix the `xbytecode' command.
1445 * .gdbinit (xprintbytestr): New command.
1446 (xwhichsymbols): Rename from `which'; all callers changed.
1447 (xbytecode): Print the byte-code string as well.
1448
1449 2011-10-29 Kim Storm <storm@cua.dk>
1450
1451 * alloc.c (which_symbols): New function.
1452
1453 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1454
1455 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1456 line. (Bug#9903)
1457
1458 2011-10-29 Glenn Morris <rgm@gnu.org>
1459
1460 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1461 Not clear what it was for, and it causes various bugs. (Bug#9839)
1462
1463 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1464
1465 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1466 possible random value that matches one of those tested as
1467 condition to clear the mouse face.
1468
1469 2011-10-28 Chong Yidong <cyd@gnu.org>
1470
1471 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1472
1473 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1474
1475 * window.c (make_window): Initialize phys_cursor_on_p.
1476
1477 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1478
1479 * lisp.h (struct Lisp_Symbol): Update comments.
1480
1481 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1482
1483 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1484
1485 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1486
1487 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1488 <oslsachem@gmail.com> for helping to debug this.
1489
1490 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1491 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1492 (g_b_init_get_glyph_outline_w): New static variables.
1493 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1494 (GetGlyphOutlineW_Proc): New typedefs.
1495 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1496 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1497 New functions.
1498 (w32font_open_internal, compute_metrics):
1499 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1500 instead of calling the "wide" APIs directly.
1501
1502 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1503
1504 * w32.h (syms_of_w32font): Add prototype.
1505
1506 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1507
1508 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1509 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1510 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1511 (Fmove_to_window_line): Doc fix.
1512
1513 2011-10-27 Chong Yidong <cyd@gnu.org>
1514
1515 * process.c (make_process): Set gnutls_state to NULL.
1516
1517 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1518 non-NULL, regardless of GNUTLS_INITSTAGE.
1519 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1520 an error. Set process slots as soon as we allocate them.
1521
1522 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1523
1524 2011-10-27 Chong Yidong <cyd@gnu.org>
1525
1526 * gnutls.c (emacs_gnutls_deinit): New function.
1527 Deallocate credentials structures as well as calling gnutls_deinit.
1528 (Fgnutls_deinit, Fgnutls_boot): Use it.
1529
1530 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1531 (deactivate_process): Call emacs_gnutls_deinit.
1532
1533 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1534
1535 * image.c (x_create_x_image_and_pixmap):
1536 * w32.c (sys_rename, w32_delayed_load):
1537 * w32font.c (fill_in_logfont):
1538 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1539
1540 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1541
1542 * w32fns.c (w32_default_color_map): New function,
1543 extracted from Fw32_default_color_map.
1544 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1545
1546 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1547
1548 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1549
1550 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1551
1552 * keyboard.c (test_undefined): New function (bug#9751).
1553 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1554
1555 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1556
1557 * sysdep.c (init_sys_modes): Fix the check for the controlling
1558 terminal (Bug#6649).
1559
1560 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1561
1562 * dispextern.h (struct bidi_it): New member next_en_type.
1563
1564 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1565 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1566 current character, check also for next_en_type being WEAK_EN.
1567 (bidi_resolve_weak): Don't enter the expensive loop if the current
1568 position is before next_en_pos. Record the bidi type of the first
1569 non-ET, non-BN character we find, in addition to its position.
1570 (bidi_level_of_next_char): Invalidate next_en_type when
1571 next_en_pos is over-stepped.
1572
1573 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1574
1575 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1576 * editfns.c: Rewrite current-time-zone so that it invokes
1577 the equivalent of (format-time-string "%Z") to get the time zone name.
1578 This fixes a bug when the time zone name contains characters that
1579 need converting from the system time locale to Emacs internal format.
1580 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1581 that patch fixed format-time-string to do the conversion, but
1582 I forgot to fix current-time-zone.
1583 (format_time_string): New function, containing most of
1584 what Fformat_time_string used to contain.
1585 (Fformat_time_string): Rewrite in terms of format_time_string.
1586 This doesn't change this function's behavior.
1587 (current-time-zone): Rewrite to use format_time_string.
1588 This fixes the bug reported by Michael Schierl in
1589 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1590 Jason Rumney's 2007-06-07 change worked around this bug, but
1591 didn't fix it.
1592 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1593
1594 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1595
1596 * xdisp.c (start_display): If the character at POS is displayed
1597 via a display vector, reset IT->current.dpvec_index to zero.
1598 (try_window_reusing_current_matrix): If a line ends in a display
1599 vector or the next line starts in a display vector, continue
1600 redrawing the window even though the character position of
1601 start_row was reached.
1602 (Bug#9771, part 2)
1603
1604 2011-10-18 Chong Yidong <cyd@gnu.org>
1605
1606 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1607 with nobreak-char-display too.
1608
1609 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1610
1611 Fix part 3 of bug#9771.
1612 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1613 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1614 non-neutral characters if the current character is a paragraph
1615 separator (a.k.a. Newline). This avoids running the same
1616 expensive loop twice, once when we consume the preceding newline
1617 and the other time when the line actually needs to be displayed.
1618 Avoid the loop when we see neutrals on the base embedding level
1619 following a character whose directionality is the same as the
1620 paragraph's. This avoids running the expensive loop when a line
1621 ends in a long sequence of neutrals, like control characters.
1622 Add assertion against STRONG_AL type. Slightly rearrange code
1623 that determines the type of a neutral given the first non-neutral
1624 that follows it.
1625 (bidi_level_of_next_char): Set next_en_pos to zero when
1626 invalidating its info.
1627
1628 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1629
1630 * xdisp.c (push_display_prop): Determine whether to record string
1631 or buffer position by IT->string, not by IT->method. Allow
1632 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1633 (move_it_vertically_backward): Don't look for character position
1634 immediately after the newline when in a continuation line.
1635 (Bug#9771, part 1)
1636
1637 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1638
1639 * window.c (coordinates_in_window): Rewrite and delabelize
1640 vertical border check. (Bug#5357) (Bug#9618)
1641
1642 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1643
1644 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1645 errors in XSetWindowBorder (bug#9310).
1646
1647 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1648
1649 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1650 avoid crash when xmalloc overrun checking is enabled.
1651
1652 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1653
1654 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1655 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1656 cursor motion with <left> and <right> arrow keys.
1657
1658 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1659 some callers set that themselves.
1660
1661 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1662
1663 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1664 display string and the previous row comes from the same string and
1665 is empty. (Bug#9739) (Bug#9738)
1666
1667 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1668
1669 * doc.c (get_doc_string): Encode file name (bug#9735).
1670
1671 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1672
1673 * bidi.c (bidi_level_of_next_char):
1674 * xdisp.c (get_visually_first_element): Remove old incorrect
1675 comments regarding the Unicode Line Separator character.
1676
1677 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1678
1679 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1680
1681 * alloc.c (Fgc_status): Do not access beyond zombies array
1682 boundary if nzombies > MAX_ZOMBIES.
1683 * alloc.c (dump_zombies): Add missing format specifier.
1684
1685 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1686
1687 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1688 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1689
1690 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1691 Some packages use them to denote characters with modifiers.
1692
1693 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1694
1695 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1696 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1697 matching a pp-number. Rename parameter var to var1.
1698
1699 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1700
1701 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1702
1703 2011-10-08 Glenn Morris <rgm@gnu.org>
1704
1705 * callint.c (Fcall_interactively): Give a more explicit error for the
1706 'c' case with a non-character input. (Bug#8479)
1707
1708 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1709
1710 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1711 lines.
1712 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1713 lines that are hscrolled on the left.
1714
1715 * dispnew.c (buffer_posn_from_coords): Account for a possible
1716 presence of header-line. (Bug#4426)
1717
1718 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1719
1720 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1721 Don't advertise functionality which we discourage or doesn't work.
1722
1723 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1724
1725 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1726 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1727 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1728 this makes Emacs dump core during garbage collection on rare
1729 occasions. sizeof is obviously inferior to offsetof here, so
1730 stick with offsetof.
1731 (GC_POINTER_ALIGNMENT): New macro.
1732 (mark_memory): Omit 3rd (offset) arg; caller changed.
1733 Don't assume EMACS_INT alignment is the same as pointer alignment.
1734
1735 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1736
1737 * keyboard.c (read_key_sequence_remapped): New var.
1738 (read_key_sequence): Compute remapping in the right buffer.
1739 (command_loop_1): Use read_key_sequence's remapping directly.
1740
1741 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1742
1743 * dired.c (file_name_completion): Don't expand file name.
1744 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1745 before checking file name handler.
1746
1747 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1748 they've been requested explicitly (bug#9591).
1749
1750 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1751
1752 * keymap.c (Fsingle_key_description): Use make_specified_string
1753 instead of build_string to build string from push_key_description.
1754 (Bug#5193)
1755
1756 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1757
1758 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1759 This fixes a Y2038 bug on 64-bit hosts.
1760 * buffer.c (reset_buffer):
1761 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1762 (Fclear_buffer_auto_save_failure):
1763 Use 0, not -1, to represent an unset failure time, since time_t
1764 might not be signed.
1765
1766 Remove dependency on glibc malloc internals.
1767 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1768 Move back here from lisp.h, but with their new implementations.
1769 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1770 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1771 * charset.c (charset_table_init): New static var.
1772 (syms_of_charset): Use it instead of xmalloc. This removes a
1773 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1774 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1775 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1776 Move back to alloc.c.
1777 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1778 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1779
1780 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1781
1782 * nsterm.m (windowDidResize): Call x_set_window_size only when
1783 ns_in_resize is true. Otherwise set pixelwidth/height and
1784 call change_frame_size (Bug#9628).
1785
1786 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 Port --enable-checking=all to Fedora 14 x86-64.
1789 * charset.c (syms_of_charset): Also account for glibc malloc's
1790 internal overhead when calculating the initial malloc maximum.
1791
1792 Port --enable-checking=all to Fedora 14 x86.
1793 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1794 Move to lisp.h.
1795 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1796 (overrun_check_realloc, overrun_check_free):
1797 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1798 That way, xmalloc returns a properly-aligned pointer even if
1799 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1800 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1801 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1802 into account when calculating the initial malloc maximum.
1803 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1804 Move here from alloc.c, so that charset.c can use it too.
1805 Properly align; the old code wasn't right for common 32-bit hosts
1806 when configured with --enable-checking=all.
1807 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1808 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1809
1810 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1811
1812 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1813 use EDOM.
1814
1815 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1816
1817 * xdisp.c (compute_display_string_end): If there's no display
1818 string at CHARPOS, return -1.
1819
1820 * bidi.c (bidi_fetch_char): When compute_display_string_end
1821 returns a negative value, treat the character as a normal
1822 character not covered by a display string. (Bug#9624)
1823
1824 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1825
1826 * lread.c (Fread_from_string): Fix typo in docstring.
1827
1828 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1829
1830 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1831 newline, reseat the iterator instead of bidi-iterating there one
1832 character at a time. (Bug#9610)
1833 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1834 TO_CHARPOS if the bidi iterator is at base embedding level.
1835
1836 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1837
1838 * lread.c (readevalloop): Use correct code for NBSP.
1839 (read1): Likewise. (Bug#9608)
1840
1841 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1842
1843 * dbusbind.c (Fdbus_register_signal): When service is not
1844 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1845
1846 2011-09-25 Glenn Morris <rgm@gnu.org>
1847
1848 * buffer.c (truncate-lines): Doc fix.
1849
1850 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1851
1852 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1853 (Fset_window_next_buffers): Doc fix.
1854
1855 2011-09-24 Glenn Morris <rgm@gnu.org>
1856
1857 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1858
1859 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1860
1861 Fix minor problems found by static checking.
1862 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1863 * indent.c (Fvertical_motion): Fix == vs = typo.
1864
1865 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1866
1867 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1868 Default value is now t. Doc fix.
1869
1870 * indent.c (Fvertical_motion): Compute and apply the overshoot
1871 logic when moving up, not only when moving down. Fix the
1872 confusing name and values of the it_overshoot_expected variable;
1873 logic changes accordingly. (Bug#9254) (Bug#9549)
1874
1875 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1876 CHARPOS is covered by a display string which includes newlines.
1877 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1878 is covered by a display string with embedded newlines.
1879
1880 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1881
1882 * dbusbind.c (Fdbus_register_signal): Add match rule to
1883 Vdbus_registered_objects_table. (Bug#9581)
1884 (Fdbus_register_method, Vdbus_registered_objects_table):
1885 Fix docstring.
1886
1887 2011-09-24 Jim Meyering <meyering@redhat.com>
1888
1889 do not ignore write error for any output size
1890 The previous change was incomplete.
1891 While it makes emacs --batch detect the vast majority of stdout
1892 write failures, errors were still ignored whenever the output size is
1893 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1894 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1895 && echo FAIL: ignored write error
1896 FAIL: ignored write error
1897 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1898 && echo FAIL: ignored write error
1899 FAIL: ignored write error
1900 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1901
1902 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1903
1904 * emacs.c (Fkill_emacs): In noninteractive mode exit
1905 non-successfully if a write error occurred on stdout. (Bug#9574)
1906
1907 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1908
1909 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1910 the xassert test.
1911
1912 * dispextern.h (struct it): Update the comment documenting what
1913 can it->OBJECT be.
1914
1915 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1916
1917 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1918 a display string, extend search for cursor position to end of row.
1919 (find_row_edges): If the row ends in a newline from a display
1920 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1921 Handle the case of a display string with multiple newlines.
1922 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1923 non-empty line. Fixes confusing cursor motion with arrow keys at
1924 the beginning of a line that starts with whitespace.
1925
1926 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1927
1928 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1929 (bug#9493).
1930
1931 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1932
1933 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1934 boolean (Bug#9154).
1935
1936 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1937
1938 * xdisp.c (display_line): Record maximum and minimum buffer
1939 positions even if no glyphs were produced (e.g., by a zero-width
1940 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1941 buffer positions that will be removed from the glyph row because
1942 they don't fit.
1943 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1944 column is beyond frame width: don't subtract 1 "pixel" when
1945 computing width of the stretch.
1946 (reseat_at_next_visible_line_start): Undo the change made on
1947 2011-09-17 that saved paragraph information and restored it after
1948 the call to `reseat'. (Bug#9545)
1949
1950 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1951
1952 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1953 and turn window cursor on if cleared (Bug#9415).
1954
1955 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1956
1957 * search.c (boyer_moore): Take unibyte characters from pattern
1958 literally. (Bug#9458)
1959
1960 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1961
1962 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1963
1964 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1965
1966 Fix minor problem found by static checking.
1967 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1968 initialized, to pacify gcc -Wuninitialized.
1969
1970 * fileio.c: Report proper errno when syscall falls.
1971 (Finsert_file_contents): Save and restore errno,
1972 so that report_file_error outputs the correct diagnostic.
1973 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1974
1975 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1976
1977 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1978
1979 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1980
1981 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1982 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1983
1984 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1985
1986 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1987 about the current paragraph and restore it after the call to reseat.
1988
1989 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1990 (bidi_find_paragraph_start): Search back for paragraph beginning
1991 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1992 (bidi_move_to_visually_next): Only trigger paragraph-related
1993 computations when the last character is a newline or at EOB, not
1994 just any NEUTRAL_B. (Bug#9470)
1995
1996 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1997 truncated lines if point is covered by a display string. (Bug#9524)
1998
1999 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2002 (cons_to_x_long): New function.
2003 (lisp_data_to_selection_data): Use it. Correct the test for
2004 short-versus-long data; it was negated. Break out of vector
2005 loop, for efficiency, when a long datum is discovered.
2006
2007 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2008
2009 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2010
2011 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2012
2013 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2014 GCC PR/17406) by declaring this function with external scope.
2015
2016 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2017
2018 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2019 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2020
2021 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2022
2023 * editfns.c (Fformat): Correctly handle text properties on "%%".
2024
2025 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2026
2027 * xterm.c (x_draw_composite_glyph_string_foreground):
2028 * w32term.c (x_draw_composite_glyph_string_foreground):
2029 * term.c (encode_terminal_code):
2030 * composite.c (composition_update_it, get_composition_id):
2031 * xdisp.c (get_next_display_element)
2032 (fill_composite_glyph_string): Add comments about special meaning
2033 of TAB characters in a composition.
2034
2035 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2036
2037 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2038 This occurs when processing a multibyte format.
2039 Problem reported by Wolfgang Jenker.
2040
2041 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2042
2043 * xdisp.c (try_cursor_movement): Only check for exact match if
2044 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2045
2046 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2047
2048 Remove unused external symbols.
2049 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2050 * xdisp.c (calc_pixel_width_or_height): Now static.
2051 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2052 * indent.c (check_display_width):
2053 * w32term.c: Fix comment to match code.
2054 * xterm.c, xterm.h (x_catching_errors): Remove.
2055
2056 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2057
2058 * xselect.c: Use signed conversions more consistently (Bug#9498).
2059 (selection_data_to_lisp_data): Assume incoming selection data are
2060 signed integers, not unsigned. This is to be consistent with
2061 outgoing selection data, which was modified to use signed integers
2062 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2063 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2064 expects long, not unsigned long.
2065
2066 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2067
2068 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2069 computation of loop end. Reported by Johan Bockgård
2070 <bojohan@gnu.org>.
2071
2072 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2073
2074 * frame.c (Fother_visible_frames_p): Function deleted.
2075
2076 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2077
2078 * indent.c (compute_motion): Process display vector front to back
2079 rather than the other way around. (Bug#2496)
2080
2081 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2082
2083 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2084
2085 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2086
2087 * minibuf.c (Fread_from_minibuffer): Doc fix.
2088
2089 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2090
2091 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2092 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2093
2094 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2095
2096 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2097 value for non-existent files.
2098
2099 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2100
2101 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2102 set its "size" to -1. This will set the modtime_size field of
2103 the corresponding buffer to -1, which is what
2104 verify-visited-file-modtime expects for files that do not exist.
2105 (Bug#9139)
2106
2107 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2108
2109 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2110 here ...
2111 * lisp.h: ... from here. push_key_description is no longer
2112 defined in keyboard.c, so its declaration should not be in
2113 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2114 logically belongs with push_key_description.
2115
2116 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2117
2118 * buffer.h: Include <sys/types.h> instead of <time.h>.
2119 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2120 Problem reported by Herbert J. Skuhra.
2121
2122 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2123
2124 * xml.c (parse_region): Make the parsing work for
2125 non-comment-starting XML files again (bug#9144).
2126
2127 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2128
2129 * image.c (gif_load): Fix calculation of bottom and right corner.
2130 (Bug#9468)
2131
2132 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2133
2134 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2135 redisplay in small windows.
2136
2137 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2138
2139 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2140
2141 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2142
2143 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2144 Operate on live windows only.
2145
2146 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2147
2148 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2149
2150 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2151
2152 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2153 only under bidi iteration.
2154
2155 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2156
2157 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2158
2159 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2160
2161 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2162 Without this fix, the command to link temacs failed due to an
2163 undefined symbol __builtin_isnan. This is because
2164 /usr/include/iso/math_c99.h #defines isnan(x) to
2165 __builtin_isnan(x), but the bundled gcc, which identifies itself
2166 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2167 a __builtin_isnan.
2168 * floatfns.c (isnan): #undef, and then #define to a clone of
2169 what's in data.c.
2170 (Fisnan): Always define, since it's always available now.
2171 (syms_of_floatfns): Always define isnan at the Lisp level.
2172
2173 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2174
2175 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2176
2177 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2178
2179 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2180 The previous code assumed that file offsets (off_t values) fit in
2181 EMACS_INT variables, which is not true on typical 32-bit hosts.
2182 The code messed up by falsely reporting buffer overflow in cases
2183 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2184 when "big" contains more than 2**29 bytes, even though this
2185 inserts just one byte and does not overflow the buffer.
2186 (Finsert_file_contents): Store file offsets as off_t
2187 values, not as EMACS_INT values. Check for overflow when
2188 converting between EMACS_INT and off_t. When checking for
2189 buffer overflow or for overlap, take the offsets into account.
2190 Don't use EMACS_INT for small values where int suffices.
2191 When checking for overlap, fix a typo: ZV was used where
2192 ZV_BYTE was intended.
2193 (Fwrite_region): Don't assume off_t fits into 'long'.
2194 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2195
2196 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2197
2198 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2199
2200 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2201
2202 sprintf-related integer and memory overflow issues (Bug#9412).
2203
2204 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2205 (esprintf, exprintf, evxprintf): New functions.
2206 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2207 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2208 (modify_event_symbol): Do not assume that the length of
2209 name_alist_or_stem is safe to alloca and fits in int.
2210 (Fexecute_extended_command): Likewise for function name and binding.
2211 (Frecursion_depth): Wrap around reliably on integer overflow.
2212 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2213 since some callers pass EMACS_INT values.
2214 (Fsingle_key_description): Don't crash if symbol name contains more
2215 than MAX_ALLOCA bytes.
2216 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2217 (get_minibuffer): Arg is now EMACS_INT, not int.
2218 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2219 (esprintf, exprintf, evxprintf): New decls.
2220 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2221
2222 * dbusbind.c (signature_cat): New function.
2223 (xd_signature, Fdbus_register_signal):
2224 Do not overrun buffer; instead, report string overflow.
2225
2226 * dispnew.c (add_window_display_history): Don't overrun buffer.
2227 Truncate instead; this is OK since it's just a log.
2228
2229 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2230 even if the time zone offset is outlandishly large.
2231 Don't mishandle offset == INT_MIN.
2232
2233 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2234 when creating daemon; the previous buffer-overflow check was incorrect.
2235
2236 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2237 which has the guts of the old verror function.
2238
2239 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2240 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2241
2242 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2243 (font_unparse_xlfd): Don't blindly alloca long strings.
2244 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2245 fits in int, when using sprintf. Use single snprintf to count
2246 length of string rather than counting it via multiple sprintfs;
2247 that's simpler and more reliable.
2248 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2249 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2250 sprintf, in case result does not fit in int.
2251
2252 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2253 (fontset_from_font): Print it.
2254
2255 * frame.c (tty_frame_count): Now printmax_t, not int.
2256 (make_terminal_frame, set_term_frame_name): Print it.
2257 (x_report_frame_params): In X, window IDs are unsigned long,
2258 not signed long, so print them as unsigned.
2259 (validate_x_resource_name): Check for implausibly long names,
2260 and don't assume name length fits in 'int'.
2261 (x_get_resource_string): Don't blindly alloca invocation name;
2262 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2263 not fit in int.
2264
2265 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2266 (xg_check_special_colors, xg_set_geometry):
2267 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2268
2269 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2270 Use esprintf, not sprintf, in case result does not fit in int.
2271
2272 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2273 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2274 it as a large positive number.
2275 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2276 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2277
2278 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2279 in case result does not fit in int.
2280
2281 * print.c (float_to_string): Detect width overflow more reliably.
2282 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2283 buffer overrun. Don't assume list length fits in 'int'. Treat
2284 print length of 0 as 0, not as infinity; to be consistent with other
2285 uses of print length in this function. Don't overflow print length
2286 index. Don't assume hash table size fits in 'long', or that
2287 vectorlike size fits in 'unsigned long'.
2288
2289 * process.c (make_process): Use printmax_t, not int, to format
2290 process-name gensyms.
2291
2292 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2293
2294 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2295 to avoid potential buffer overrun.
2296
2297 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2298 if X resource line is longer than 512 bytes.
2299
2300 * xfns.c (x_window): Make sprintf buffer a bit bigger
2301 to avoid potential buffer overrun.
2302
2303 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2304
2305 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2306
2307 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2308
2309 Integer overflow fixes for scrolling, etc.
2310 Without these, Emacs silently mishandles large integers sometimes.
2311 For example, "C-u 4294967297 M-x recenter" was treated as if
2312 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2313
2314 * xdisp.c (try_window_id): Check Emacs fixnum range before
2315 converting to 'int'.
2316
2317 * window.c (window_scroll_line_based, Frecenter):
2318 Check that an Emacs fixnum is in range before assigning it to 'int'.
2319 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2320 values converted from Emacs fixnums.
2321 (Frecenter): Don't wrap around a line count if it is out of 'int'
2322 range; instead, treat it as an extreme value.
2323 (Fset_window_configuration, compare_window_configurations):
2324 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2325
2326 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2327 that can exceed INT_MAX. Check that EMACS_INT value is in range
2328 before assigning it to the (possibly-narrower) index.
2329 (match_limit): Don't assume that a fixnum can fit in 'int'.
2330
2331 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2332 exceed INT_MAX.
2333
2334 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2335 (Fvertical_motion): Don't wrap around LINES values that don't fit
2336 in 'int'. Instead, treat them as extreme values. This is good
2337 enough for windows, which can't have more than INT_MAX lines anyway.
2338
2339 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2340
2341 * Require libxml/parser.h to avoid compilation warning.
2342
2343 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2344
2345 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2346 since this reportedly can destroy thread storage.
2347
2348 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2349
2350 * syntax.c (find_defun_start): Update all cache variables if
2351 exiting early (Bug#9401).
2352
2353 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2354
2355 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2356
2357 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2358 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2359 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2360
2361 * term.c (tty_append_glyph): New function.
2362 (produce_stretch_glyph): Static function and its prototype deleted.
2363
2364 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2365 Add prototypes.
2366
2367 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2368
2369 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2370 when checking :margin (Bug#9390).
2371 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2372 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2373 so that the name doesn't mislead. All uses changed.
2374
2375 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2376
2377 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2378 set_tty_hooks.
2379
2380 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2381
2382 * xdisp.c (move_it_to): Don't bail out early when reaching
2383 position beyond to_charpos, if we are scanning backwards.
2384 (move_it_vertically_backward): When DY == 0, make sure we get to
2385 the first character in the line after the newline.
2386
2387 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2388
2389 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2390 (ccl_driver): Do not generate an out-of-range pointer.
2391 (Fccl_execute_on_string): Remove unnecessary check for
2392 integer overflow, noted by Stefan Monnier in
2393 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2394 Remove a FIXME that didn't need fixing.
2395 Simplify the newly-introduced buffer reallocation code.
2396
2397 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2398
2399 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2400
2401 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2402
2403 Integer and memory overflow issues (Bug#9196).
2404
2405 * doc.c (get_doc_string): Rework so that
2406 get_doc_string_buffer_size is the actual buffer size, rather than
2407 being 1 less than the actual buffer size; this makes xpalloc more
2408 convenient.
2409
2410 * image.c (x_allocate_bitmap_record, cache_image):
2411 * xselect.c (Fx_register_dnd_atom):
2412 Simplify previous changes by using xpalloc.
2413
2414 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2415 since either will do and ptrdiff_t is convenient with xpalloc.
2416
2417 * charset.c (charset_table_size)
2418 (struct charset_sort_data.priority): Now ptrdiff_t.
2419 (charset_compare): Don't overflow if priorities differ greatly.
2420 (Fsort_charsets): Don't assume list length fits in int.
2421 Check for size-calculation overflow when allocating sort data.
2422 (syms_of_charset): Allocate an initial charset table that is
2423 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2424
2425 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2426
2427 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2428 The actual value is always <= INT_MAX, and leaving it unsigned made
2429 overflow checking harder.
2430
2431 * dispextern.h (struct glyph_matrix.rows_allocated)
2432 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2433 with xpalloc. The values are still always <= INT_MAX.
2434
2435 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2436
2437 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2438 (SAFE_NALLOCA): New macro.
2439
2440 * region-cache.c (struct boundary.pos, find_cache_boundary)
2441 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2442 (set_cache_region, invalidate_region_cache)
2443 (revalidate_region_cache, know_region_cache, region_cache_forward)
2444 (region_cache_backward, pp_cache):
2445 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2446 so that ptrdiff_t * can be passed to xpalloc.
2447 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2448 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2449 (pp_cache): Don't assume cache_len fits in int.
2450 * region-cache.h: Adjust extern decls to match.
2451
2452 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2453 EMACS_INT, since either will do, for xpalloc.
2454
2455 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2456 (xnmalloc, xnrealloc, xpalloc): New functions.
2457
2458 * bidi.c (bidi_shelve_header_size): New constant.
2459 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2460 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2461
2462 * bidi.c (bidi_cache_shrink):
2463 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2464 (overlay_strings):
2465 Don't update size of array until after memory allocation succeeds,
2466 because xmalloc/xrealloc may not return.
2467 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2468 now that we have proper integer overflow checking.
2469 (record_overlay_string, overlay_strings): Catch overflows when
2470 calculating size of overlay_str_buf.
2471
2472 * callproc.c (Fcall_process): Check for size overflow when
2473 calculating size of args2.
2474 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2475 Normally we prefer signed values, but sticking with ptrdiff_t would
2476 require adding more-complicated checks.
2477
2478 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2479 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2480 Redo buffer-overflow calculations to avoid integer overflow.
2481 Add a FIXME comment where memory seems to be over-allocated.
2482
2483 * character.c (Fstring): Check for size-calculation overflow.
2484
2485 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2486 unnecessary integer overflow. Check for size overflow.
2487 (encode_coding_object): Don't update size until xmalloc succeeds.
2488
2489 * composite.c (get_composition_id): Check for overflow in glyph
2490 length calculations.
2491
2492 Integer and memory overflow fixes for display code.
2493 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2494 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2495 (scrolling_window): Check for overflow in size calculations.
2496 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2497 Don't assume glyph table len fits in int.
2498 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2499 (row_table_size): Now ptrdiff_t, not int.
2500 (scrolling_window): Avoid overflow in size calculations.
2501 Don't update size until allocation succeeds.
2502 * fns.c (concat): Check for overflow in size calculations.
2503 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2504 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2505 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2506
2507 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2508 (get_doc_string): Check for size calculation overflow.
2509 Don't update size until allocation succeeds.
2510 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2511 EMACS_INT, where ptrdiff_t will do.
2512 (Fsubstitute_command_keys): Check for string overflow.
2513
2514 * editfns.c (set_time_zone_rule): Don't assume environment length
2515 fits in int.
2516 (message_length): Now ptrdiff_t, not int.
2517 (Fmessage_box): Don't update size until allocation succeeds.
2518 Don't assume message length fits in int.
2519 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2520
2521 * emacs.c (main): Do not reallocate argv, since there is a null at
2522 the end that can be overwritten, and this way there's no need to
2523 worry about size-calculation overflow.
2524 (sort_args): Check for size-calculation overflow.
2525
2526 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2527 alloc succeeds.
2528 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2529
2530 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2531 (x_set_scroll_bar_width, x_figure_window_size):
2532 Check for integer overflow.
2533 (x_set_alpha): Do not assume XINT fits in int.
2534
2535 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2536 This is for the members text_lines, text_cols, total_lines, total_cols,
2537 where the system imposes an 'int' limit.
2538
2539 * fringe.c (Fdefine_fringe_bitmap):
2540 Don't update size until alloc works.
2541
2542 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2543 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2544
2545 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2546 Check for size-calculation overflow.
2547 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2548 do, as we prefer signed integers.
2549 (id_to_widget.max_size, id_to_widget.used)
2550 (xg_store_widget_in_map, xg_remove_widget_from_map)
2551 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2552 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2553 Use and return ptrdiff_t, not int.
2554 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2555 * gtkutil.h: Change prototypes to match the above.
2556
2557 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2558 are duplicate now that they've been promoted to lisp.h.
2559 (x_allocate_bitmap_record, x_alloc_image_color)
2560 (make_image_cache, cache_image, xpm_load):
2561 Don't update size until alloc is done.
2562 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2563 (x_detect_edges):
2564 Check for size calculation overflow.
2565 (ct_colors_allocated_max): New constant.
2566 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2567 overflow.
2568
2569 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2570 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2571 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2572 Use ptrdiff_t, not int, to count maps.
2573 (read_char_minibuf_menu_prompt): Check for overflow in size
2574 calculations. Don't update size until allocation succeeds.
2575 Redo calculations to avoid overflow.
2576 * keyboard.h: Change prototypes to match the above.
2577
2578 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2579 to count maps.
2580 (current_minor_maps): Check for size calculation overflow.
2581 * keymap.h: Change prototypes to match the above.
2582
2583 * lread.c (read1, init_obarray): Don't update size until alloc done.
2584
2585 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2586 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2587
2588 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2589 Now ptrdiff_t, not int.
2590 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2591 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2592
2593 * process.c (Fnetwork_interface_list): Check for overflow
2594 in size calculation.
2595
2596 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2597
2598 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2599 overflow. Don't bother calling xmalloc when xrealloc will do.
2600
2601 * search.c (Freplace_match): Check for size calculation overflow.
2602 (Fset_match_data): Don't assume list lengths fit in 'int'.
2603
2604 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2605 for command line length. Do not attempt to address one before the
2606 beginning of an array, as that's not portable.
2607
2608 * term.c (max_frame_lines): Remove; unused.
2609 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2610 not int.
2611 (encode_terminal_code, calculate_costs): Check for size
2612 calculation overflow.
2613 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2614 table lengths and related sizes. Don't update size until alloc
2615 done. Redo calculations to avoid overflow.
2616 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2617
2618 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2619 subtracting pointers.
2620 (gobble_line): Check for overflow more carefully. Don't update size
2621 until alloc done.
2622
2623 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2624 Don't update size until alloc done.
2625 Redo size calculations to avoid overflow.
2626 Check for size calculation overflow.
2627 (main) [DEBUG]: Fix typo in invoking tparam1.
2628
2629 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2630 Use ptrdiff_t, not int, for sizes.
2631 (store_mode_line_noprop_char): Don't update size until alloc done.
2632
2633 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2634 Use ptrdiff_t, not int, for sizes.
2635 (Finternal_make_lisp_face, cache_face):
2636 Check for size calculation overflow.
2637 (cache_face): Treat size calculation overflows as if they were
2638 memory exhaustion (the usual treatment), rather than aborting.
2639
2640 * xfns.c (x_encode_text, x_set_name_internal)
2641 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2642 sizes, since they can exceed INT_MAX in size. Check for size
2643 calculation overflow.
2644
2645 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2646 (xg_select): Check for size calculation overflow.
2647 Don't update size until alloc done.
2648
2649 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2650 as sprintf is limited to int lengths.
2651
2652 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2653 (X_LONG_MIN): New macros.
2654 Use them to make the following changes clearer.
2655 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2656 This change doesn't affect the value now, but it may help remind
2657 future maintainers not to raise the value too much later.
2658 (SELECTION_QUANTUM): Remove, replacing with ...
2659 (selection_quantum): ... new function, which avoids overflow.
2660 All uses changed.
2661 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2662 assumption that selection length fits in 'int'.
2663 (x_reply_selection_request, x_handle_selection_request)
2664 (x_get_window_property, receive_incremental_selection)
2665 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2666 (lisp_data_to_selection_data, clean_local_selection_data):
2667 Use ptrdiff_t, not int, to record length of selection.
2668 (x_reply_selection_request, x_get_window_property)
2669 (receive_incremental_selection, x_property_data_to_lisp):
2670 Redo calculations to avoid overflow.
2671 (x_reply_selection_request): When sending hint, ceiling it at
2672 X_LONG_MAX rather than relying on wraparound overflow to send
2673 something.
2674 (x_get_window_property, receive_incremental_selection)
2675 (lisp_data_to_selection_data, x_property_data_to_lisp):
2676 Check for size-calculation overflow.
2677 (x_get_window_property, receive_incremental_selection)
2678 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2679 Don't store size until memory allocation succeeds.
2680 (x_get_window_property): Plug memory leak on memory exhaustion.
2681 Don't double-block input; malloc is safe here. Don't assume 2**34
2682 - 4 fits in unsigned long. Add an xassert to check
2683 XGetWindowProperty overflow. Be more careful about overflow
2684 calculations, and distinguish size from memory overflow better.
2685 (receive_incremental_selection): When tracing, don't assume
2686 unsigned int is less than INT_MAX.
2687 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2688 harmful) conversions of unsigned short to int.
2689 (lisp_data_to_selection_data): Don't assume that integers
2690 in the range -65535 through -1 fit in an X unsigned short.
2691 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2692 result parameters unless successful. Rely on cons_to_unsigned
2693 to report problems with elements; the old code wasn't right anyway.
2694 (x_check_property_data): Check for int overflow; we cannot use
2695 a wider type due to X limits.
2696 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2697
2698 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2699
2700 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2701 (x_term_init): Check for size calculation overflow.
2702 (x_color_cells): Don't store size until memory allocation succeeds.
2703 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2704 Don't assume alloca size is less than MAX_ALLOCA.
2705 (x_term_init): Don't assume length fits in int (sprintf is limited
2706 to int size).
2707
2708 Use ptrdiff_t for composition IDs.
2709 * character.c (lisp_string_width):
2710 * composite.c (composition_table_size, n_compositions)
2711 (get_composition_id, composition_gstring_from_id):
2712 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2713 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2714 * window.c (Frecenter):
2715 Use ptrdiff_t, not int, for composition IDs.
2716 * composite.c (get_composition_id): Check for integer overflow.
2717 * composite.h: Adjust prototypes to match the above changes.
2718
2719 Use ptrdiff_t for hash table indexes.
2720 * category.c (hash_get_category_set):
2721 * ccl.c (ccl_driver):
2722 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2723 * coding.c (coding_system_charset_list, detect_coding_system):
2724 * coding.h (struct coding_system.id):
2725 * composite.c (get_composition_id, gstring_lookup_cache):
2726 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2727 * image.c (xpm_get_color_table_h):
2728 * lisp.h (hash_lookup, hash_put):
2729 * minibuf.c (Ftest_completion):
2730 Use ptrdiff_t for hash table indexes, not int (which is too
2731 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2732 32-bit --with-wide-int hosts).
2733
2734 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2735 Add a FIXME comment about memory leaks.
2736 (syms_of_charset): Don't assume xmalloc returns.
2737
2738 Don't assume that stated character widths fit in int.
2739 * character.c (Fchar_width, c_string_width, lisp_string_width):
2740 * character.h (CHAR_WIDTH):
2741 * indent.c (MULTIBYTE_BYTES_WIDTH):
2742 Use sanitize_char_width to avoid undefined and/or bad behavior
2743 with outlandish widths.
2744 * character.h (sanitize_tab_width): Rename from sanitize_width,
2745 now that we have two such functions. All uses changed.
2746 (sanitize_char_width): New inline function.
2747
2748 Don't assume that tab-width fits in int.
2749 * character.h (sanitize_width): New inline function.
2750 (SANE_TAB_WIDTH): New macro.
2751 (ASCII_CHAR_WIDTH): Use it.
2752 * indent.c (sane_tab_width): Remove. All uses replaced by
2753 SANE_TAB_WIDTH (current_buffer).
2754 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2755
2756 * fileio.c: Integer overflow issues with file modes.
2757 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2758
2759 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2760 Remove unreachable code.
2761 (read_hex, load_charset_map_from_file): Check for integer overflow.
2762
2763 * xterm.c: Don't go over XClientMessageEvent limit.
2764 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2765 (x_send_scroll_bar_event): Likewise. Check that the size does not
2766 exceed limits imposed by XClientMessageEvent, as well as the usual
2767 ptrdiff_t and size_t limits.
2768
2769 * keyboard.c: Overflow, signedness and related fixes.
2770 (make_lispy_movement): Use same integer type in forward decl
2771 that is used in the definition.
2772 (read_key_sequence, keyremap_step):
2773 Change bufsize argument back to int, undoing my 2011-03-30 change.
2774 We prefer signed types, and int is wide enough here.
2775 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2776 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2777 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2778 length, not size_t. Use ptrdiff_t for index, not int.
2779 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2780 possibility of integer overflow.
2781
2782 Overflow, signedness and related fixes for images.
2783
2784 * dispextern.h (struct it.stack[0].u.image.image_id)
2785 (struct_it.image_id, struct image.id, struct image_cache.size)
2786 (struct image_cache.used, struct image_cache.ref_count):
2787 * gtkutil.c (update_frame_tool_bar):
2788 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2789 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2790 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2791 * nsmenu.m (update_frame_tool_bar):
2792 * xdisp.c (calc_pixel_width_or_height):
2793 * xfns.c (image_cache_refcount):
2794 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2795 on typical 64-bit hosts.
2796
2797 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2798 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2799 Omit unnecessary casts to int.
2800 (parse_image_spec): Check that integers fall into 'int' range
2801 when the callers expect that.
2802 (image_ascent): Redo ascent calculation to avoid int overflow.
2803 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2804 (lookup_image): Remove unnecessary tests.
2805 (xbm_image_p): Locals are now of int, not EMACS_INT,
2806 since parse_image_check makes sure they fit into int.
2807 (png_load, gif_load, svg_load_image):
2808 Prefer int to unsigned where either will do.
2809 (tiff_handler): New function, combining the cores of the
2810 old tiff_error_handler and tiff_warning_handler.
2811 This function is rewritten to use vsnprintf and thereby avoid
2812 stack buffer overflows. It uses only the features of vsnprintf
2813 that are common to both POSIX and native Microsoft.
2814 (tiff_error_handler, tiff_warning_handler): Use it.
2815 (tiff_load, gif_load, imagemagick_load_image):
2816 Don't assume :index value fits in 'int'.
2817 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2818 (imagemagick_load_image): Check that crop parameters fit into
2819 the integer types that MagickCropImage accepts. Don't assume
2820 Vimagemagick_render_type has a nonnegative value. Don't assume
2821 size_t fits in 'long'.
2822 (gs_load): Use printmax_t to print the widest integers possible.
2823 Check for integer overflow when computing image height and width.
2824
2825 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2826
2827 * xdisp.c (redisplay_window): Don't force window start if point
2828 will be invisible in the resulting window. (Bug#9324)
2829
2830 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2831
2832 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2833 the display spec is of the form `(space ...)'.
2834 (handle_display_spec): Return the value returned by
2835 handle_single_display_spec, not just 1 or zero.
2836 (handle_single_display_spec): If the display spec is of the form
2837 `(space ...)', and specifies display in the text area, return 2
2838 rather than 1.
2839 (try_cursor_movement): Check for the need to scroll more
2840 accurately, and prefer exact match for point under bidi.
2841 Don't advance `row' beyond the last row of the window.
2842
2843 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2844 into disp_prop; all users changed.
2845
2846 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2847 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2848 for the text covered by the display property.
2849
2850 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2851
2852 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2853 Change return value to nil.
2854 (Frecord_buffer): Delete unused function.
2855
2856 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2857
2858 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2859 buffers, return left-to-right.
2860 (set_cursor_from_row): Consider candidate row a win if its glyph
2861 represents a newline and point is on that newline. Fixes cursor
2862 positioning on the newline at EOL of R2L text within L2R
2863 paragraph, and vice versa.
2864 (try_cursor_movement): Check continued rows, in addition to
2865 continuation rows. Fixes unwarranted scroll when point enters a
2866 continued line of R2L text within an L2R paragraph, or vice versa.
2867 (cursor_row_p): Consider the case of point being equal to
2868 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2869 from the end of a short line to the beginning of a continued line
2870 of R2L text within L2R paragraph.
2871 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2872 composed characters.
2873
2874 * bidi.c (bidi_check_type): Use xassert.
2875 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2876 members.
2877
2878 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2879
2880 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2881 a character.
2882
2883 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2884
2885 * nsfont.m (ns_otf_to_script): Fix typo.
2886
2887 2011-08-22 Kenichi Handa <handa@m17n.org>
2888
2889 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2890 extra slot even if the purpose is char-code-property-table.
2891
2892 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2893
2894 * xdisp.c (redisplay_window): When computing centering_position,
2895 account for the height of the header line. (Bug#8874)
2896
2897 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2898 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2899 candidate is selected by the mouse, and that candidate has a
2900 composed character under the mouse.
2901
2902 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2903 coordinates reported by pos-visible-in-window-p for a composed
2904 character in column zero.
2905
2906 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2907
2908 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2909
2910 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2911
2912 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2913 consider it a hit if to_charpos is anywhere in the range of the
2914 composed buffer positions.
2915
2916 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2917
2918 * image.c (gif_load): Don't assume that each subimage has the same
2919 dimensions as the base image. Handle disposal method that is
2920 "undefined" by the gif spec (Bug#9335).
2921
2922 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2923
2924 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2925 (Fcondition_case): Document `debug' symbol in error handler.
2926
2927 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2928
2929 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2930 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2931 from an Org mode buffer to a Speedbar frame.
2932
2933 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2934 a composition, take its buffer position from IT->cmp_it.charpos.
2935 Fixes cursor positioning at the beginning of a line that begins
2936 with a composed character.
2937
2938 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2939
2940 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2941 character bidirectional type, use STRONG_L instead. Fixes crashes
2942 in a buffer produced by `describe-categories'.
2943
2944 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2945 members before the level stack, so they would be saved and
2946 restored when copying iterator state. Fixes incorrect reordering
2947 around TABs covered by display properties.
2948
2949 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2950
2951 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2952
2953 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2954
2955 * eval.c (internal_condition_case, internal_condition_case_1)
2956 (internal_condition_case_2, internal_condition_case_n):
2957 Remove unnecessary aborts (Bug#9081).
2958
2959 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2960
2961 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2962 has no `load' handler, try opening the file locally. (Bug#9311)
2963
2964 2011-08-16 Ken Brown <kbrown@cornell.edu>
2965
2966 * gmalloc.c: Expand comment.
2967
2968 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2969
2970 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2971 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2972
2973 2011-08-16 Ken Brown <kbrown@cornell.edu>
2974
2975 Fix memory allocation problems in Cygwin build (Bug#9273).
2976
2977 * unexcw.c ( __malloc_initialized): Declare external variable.
2978 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2979
2980 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2981 New variables.
2982 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2983 dumped emacs.
2984 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2985 in the static heap.
2986 [CYGWIN] (special_realloc): New function.
2987 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2988 requests to realloc storage in the static heap.
2989
2990 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2991
2992 * bidi.c (bidi_initialize): Remove unused local.
2993
2994 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2995
2996 * bidimirror.h:
2997 * biditype.h: Remove file.
2998 * makefile.w32-in ($(BLD)/bidi.$(O)):
2999 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3000
3001 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3002
3003 * chartab.c: Improve commentary for the uniprop_table API.
3004
3005 * bidi.c (bidi_paragraph_init): Support zero value of
3006 bidi_ignore_explicit_marks_for_paragraph_level.
3007 (bidi_initialize): Use uniprop_table instead of including
3008 biditype.h and bidimirror.h.
3009
3010 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3011 coordinates of the iterator when restoring from ppos_it.
3012 (Bug#9296)
3013
3014 2011-08-14 Kenichi Handa <handa@m17n.org>
3015
3016 * process.c (create_process): Call setup_process_coding_systems
3017 after the pid of the process is set to -1 (Bug#8162).
3018
3019 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3020
3021 * xdisp.c (move_it_in_display_line_to): Don't invoke
3022 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3023 ppos_it. Fixes vertical cursor motion when line beginning is
3024 covered by an image. (Bug#9296)
3025
3026 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3027
3028 * nsterm.h (ns_run_ascript): Declare.
3029 (NSAPP_DATA2_RUNASSCRIPT): Define.
3030
3031 * nsfns.m (as_script, as_result, as_status): New static variables.
3032 (ns_run_ascript): New function.
3033 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3034 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3035 the event loop. Get status from as_status (Bug#7276).
3036
3037 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3038 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3039 the event loop (Bug#7276).
3040
3041 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3042
3043 * gnutls.c (QCgnutls_bootprop_priority)
3044 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3045 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3046 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3047 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3048 (QCgnutls_bootprop_verify_hostname_error)
3049 (QCgnutls_bootprop_callbacks_verify): Rename from
3050 Qgnutls_bootprop_..., all uses changed.
3051
3052 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3053 uses changed.
3054
3055 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3056
3057 * xfaces.c (Qframe_set_background_mode): Now static.
3058 * dispextern.h (Qframe_set_background_mode): Remove decl.
3059
3060 * process.c (Fnetwork_interface_info): Declare local only if needed.
3061
3062 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3063
3064 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3065 (Fnetwork_interface_list): Allocate in increments of bytes instead
3066 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3067 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3068 sockaddr.
3069 (struct ifflag_def): notrailers is smart on OSX.
3070 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3071 Get hardware address with getifaddrs if available.
3072
3073 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3074
3075 * xdisp.c (iterate_out_of_display_property): xassert that
3076 IT->position is set to within IT->object's boundaries. Break from
3077 the loop as soon as EOB is reached; avoids infloops in redisplay
3078 when IT->position is set up wrongly due to some bug.
3079 Set IT->current to match the bidi iterator unconditionally.
3080 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3081 entry. Force push_it to save on the stack the current
3082 buffer/string position, to be restored by pop_it. Fix flags in
3083 the iterator structure wrt the object coming from a display
3084 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3085 properties. (Bug#9284)
3086
3087 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3088
3089 * fontset.c (fontset_get_font_group): Add proper type checks.
3090 (Bug#9172)
3091
3092 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3093
3094 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3095 and LC_VERSION_MIN_MACOSX.
3096 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3097 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3098
3099 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3100
3101 * xdisp.c (forward_to_next_line_start): Allow to use the
3102 no-display-properties-and-no-overlays under bidi display.
3103 Set disp_pos in the bidi iterator to avoid searches for display
3104 properties and overlays.
3105
3106 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3107
3108 * editfns.c (Fset_time_zone_rule): Document relationship with the
3109 setenv function.
3110
3111 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3112 the font entity extracted from the cache (Bug#8109).
3113
3114 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3115
3116 * composite.c (autocmp_chars): Don't reset point. That is done by
3117 restore_point_unwind (Bug#5984).
3118
3119 2011-08-07 Juri Linkov <juri@jurta.org>
3120
3121 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3122 to show the arg `TIME' instead of `TIMEVAL'.
3123
3124 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3125
3126 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3127 display property strides EOL and includes a newline, as in
3128 longlines-mode. (Bug#9254)
3129 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3130 word-wrap under bidirectional display. (Bug#9224)
3131
3132 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3133 is non-zero, even if the data buffer is NULL. Fixes a crash in
3134 vertical-motion with longlines-mode. (Bug#9254)
3135
3136 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3137
3138 * bidi.c <bidi_cache_total_alloc>: Now static.
3139 (bidi_initialize): Initialize bidi_cache_total_alloc.
3140
3141 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3142 cache. (Bug#9221)
3143
3144 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3145 amount allocated this far in `bidi_cache_total_alloc'.
3146 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3147 non-zero, only free the data buffer without restoring the cache
3148 contents. All callers changed.
3149
3150 * dispextern.h (bidi_unshelve_cache): Update prototype.
3151
3152 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3153 (move_it_in_display_line, move_it_to)
3154 (move_it_vertically_backward, move_it_by_lines): Replace the call
3155 to xfree to an equivalent call to bidi_unshelve_cache.
3156 (move_it_in_display_line_to): Fix logic of returning
3157 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3158
3159 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3160
3161 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3162 came from a string character with a `cursor' property. (Bug#9229)
3163
3164 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3165
3166 * Makefile.in (LIB_PTHREAD): New variable.
3167 (LIBES): Add LIB_PTHREAD (Bug#9216).
3168
3169 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3170 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3171
3172 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3173
3174 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3175
3176 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3177
3178 * xterm.c (x_find_topmost_parent): New function.
3179 (x_set_frame_alpha): Find topmost parent window with
3180 x_find_topmost_parent and set the property there also (bug#9181).
3181 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3182
3183 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 * callproc.c (Fcall_process): Avoid vfork clobbering
3186 the local vars buffer, coding_systems, current_dir.
3187
3188 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3189
3190 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3191
3192 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3193
3194 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3195 so that it is not optimized away.
3196
3197 * xdisp.c (compute_display_string_pos): Remove unused local.
3198
3199 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3200
3201 Fix slow cursor motion and scrolling in large buffers with
3202 selective display, like Org Mode buffers. (Bug#9218)
3203
3204 * dispextern.h (struct bidi_it): New member disp_prop_p.
3205
3206 * xdisp.c: Remove one-slot cache of display string positions.
3207 (compute_display_string_pos): Accept an additional argument
3208 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3209 for a display string or property. If found, set DISP_PROP_P
3210 non-zero.
3211
3212 * bidi.c (bidi_fetch_char): Accept an additional argument
3213 DISP_PROP_P, and pass it to compute_display_string_pos.
3214 Only handle text covered by a display string if DISP_PROP_P is returned
3215 non-zero. All callers of bidi_fetch_char changed.
3216
3217 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3218
3219 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3220
3221 2010-12-03 Don March <don@ohspite.net>
3222
3223 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3224 last character M-[char] is translated to ESC [char] (bug#7541).
3225
3226 2011-08-02 Kenichi Handa <handa@m17n.org>
3227
3228 * lisp.h (uniprop_table): Extern it.
3229
3230 * chartab.c (uniprop_table): Make it non-static.
3231
3232 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3233
3234 * xdisp.c (forward_to_next_line_start): Accept additional argument
3235 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3236 on the newline.
3237 (reseat_at_next_visible_line_start): Use the bidi iterator state
3238 returned by forward_to_next_line_start to restore the state of
3239 it->bidi_it after backing up to previous newline. (Bug#9212)
3240
3241 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3242
3243 * regex.c (re_comp): Protoize.
3244 (re_exec): Fix return type.
3245 (regexec): Fix type of `ret'. (Bug#9203)
3246
3247 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3248
3249 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3250 This is needed if max-image-size is a floating-point number.
3251
3252 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3253
3254 * print.c (print_object): Print empty symbol as ##.
3255
3256 * lread.c (read1): Read ## as empty symbol.
3257
3258 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3259
3260 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3261 setting frame foreground color (Bug#9175).
3262 (x_set_background_color): Likewise.
3263
3264 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3265 contents (Bug#9176).
3266 (EmacsTooltip -init): Remove bezels and add shadows to
3267 tooltip windows.
3268
3269 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3270 or scroll bar (Bug#8470).
3271
3272 * nsfont.m (nsfont_open): Remove assignment to voffset and
3273 unnecessary vars hshink, expand, hd, full_height, min_height.
3274 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3275
3276 * nsterm.h (nsfont_info): Remove voffset field.
3277
3278 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3279
3280 Implement strike-through and overline on NextStep (Bug#8863).
3281
3282 * nsfont.m (nsfont_open): Use underline position provided by font,
3283 instead of hard-coded value of 2.
3284 (nsfont_draw): Call ns_draw_text_decoration instead.
3285
3286 * nsterm.h: Add declaration for ns_draw_text_decoration.
3287
3288 * nsterm.m (ns_draw_text_decoration): New function for drawing
3289 underline, overline, and strike-through.
3290 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3291 ns_draw_text_decoration. Change treatment of cursor drawing to
3292 accommodate underlining, etc.
3293
3294 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3295
3296 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3297 default.
3298
3299 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3300
3301 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3302 Without this fix, if a signal arrives just after memory fills up,
3303 'malloc' might be invoked reentrantly.
3304
3305 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3306 In other words, assume that every image size is allowed, on non-X
3307 hosts. This assumption is probably wrong, but it lets Emacs compile.
3308
3309 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3310
3311 * regex.c (re_iswctype): Convert return values to boolean.
3312
3313 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3314
3315 * xdisp.c (compute_display_string_pos): Don't use cached display
3316 string position if the buffer had its restriction changed.
3317 (Bug#9184)
3318
3319 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3320
3321 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3322
3323 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3324
3325 Integer signedness and overflow and related fixes. (Bug#9079)
3326
3327 * bidi.c: Integer size and overflow fixes.
3328 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3329 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3330 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3331 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3332 (bidi_find_other_level_edge):
3333 Use ptrdiff_t instead of EMACS_INT where either will do.
3334 This works better on 32-bit hosts configured --with-wide-int.
3335 (bidi_cache_ensure_space): Check for size-calculation overflow.
3336 Use % rather than repeated addition, for better worst-case speed.
3337 Don't set bidi_cache_size until after xrealloc returns, because it
3338 might not return.
3339 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3340 (bidi_cache_ensure_space): Also check that the bidi cache size
3341 does not exceed that of the largest Lisp string or buffer. See Eli
3342 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3343
3344 * alloc.c (__malloc_size_t): Remove.
3345 All uses replaced by size_t. See Andreas Schwab's note
3346 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3347
3348 * image.c: Improve checking for integer overflow.
3349 (check_image_size): Assume that f is nonnull, since
3350 it is always nonnull in practice. This is one less thing to
3351 worry about when checking for integer overflow later.
3352 (x_check_image_size): New function, which checks for integer
3353 overflow issues inside X.
3354 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3355 This removes the need for a memory_full check.
3356 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3357 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3358 (xbm_read_bitmap_data): Change locals back to 'int', since
3359 their values must fit in 'int'.
3360 (xpm_load_image, png_load, tiff_load):
3361 Invoke x_create_x_image_and_pixmap earlier,
3362 to avoid much needless work if the image is too large.
3363 (tiff_load): Treat overly large images as if
3364 x_create_x_image_and_pixmap failed, not as malloc failures.
3365 (gs_load): Use x_check_image_size.
3366
3367 * gtkutil.c: Omit integer casts.
3368 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3369 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3370
3371 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3372
3373 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3374 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3375 would wrongly return t on a 64-bit host.
3376
3377 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3378 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3379 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3380 and therefore cause GCC to emit a bogus diagnostic in some cases.
3381
3382 * image.c: Integer signedness and overflow and related fixes.
3383 This is not an exhaustive set of fixes, but it's time to
3384 record what I've got.
3385 (lookup_pixel_color, check_image_size): Remove redundant decls.
3386 (check_image_size): Don't assume that arbitrary EMACS_INT values
3387 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3388 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3389 (tiff_load, imagemagick_load_image):
3390 Check for overflow in size calculations.
3391 (x_create_x_image_and_pixmap): Remove unnecessary test for
3392 xmalloc returning NULL; that can't happen.
3393 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3394 (xpm_color_bucket): Use better integer hashing function.
3395 (xpm_cache_color): Don't possibly over-allocate memory.
3396 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3397 (gif_memory_source):
3398 Use ptrdiff_t, not int or size_t, to record sizes.
3399 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3400 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3401 either works, as we prefer signed integers.
3402 (tiff_read_from_memory, tiff_write_from_memory):
3403 Return tsize_t, not size_t, since that's what the TIFF API wants.
3404 (tiff_read_from_memory): Don't fail simply because the read would
3405 go past EOF; instead, return a short read.
3406 (tiff_load): Omit no-longer-needed casts.
3407 (Fimagemagick_types): Don't assume size fits into 'int'.
3408
3409 Improve hashing quality when configured --with-wide-int.
3410 * fns.c (hash_string): New function, taken from sxhash_string.
3411 Do not discard information about ASCII character case; this
3412 discarding is no longer needed.
3413 (sxhash-string): Use it. Change sig to match it. Caller changed.
3414 * lisp.h: Declare it.
3415 * lread.c (hash_string): Remove, since we now use fns.c's version.
3416 The fns.c version returns a wider integer if --with-wide-int is
3417 specified, so this should help the quality of the hashing a bit.
3418
3419 * emacs.c: Integer overflow minor fix.
3420 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3421 Define only if GNU_LINUX.
3422 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3423
3424 * dispnew.c: Integer signedness and overflow fixes.
3425 Remove unnecessary forward decls, that were a maintenance hassle.
3426 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3427 All uses changed.
3428 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3429 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3430 (prepare_desired_row, line_draw_cost):
3431 Use int, not unsigned, where either works.
3432 (save_current_matrix, restore_current_matrix):
3433 Use ptrdiff_t, not size_t, where either works.
3434 (init_display): Check for overflow more accurately, and without
3435 relying on undefined behavior.
3436
3437 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3438 Remove, replacing with the new symbols in lisp.h. All uses changed.
3439 * fileio.c (make_temp_name):
3440 * filelock.c (lock_file_1, lock_file):
3441 * xdisp.c (message_dolog):
3442 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3443 Use pMd etc. instead.
3444 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3445 replacing the pWIDE etc. symbols removed from editfns.c.
3446
3447 * keyboard.h (num_input_events): Now uintmax_t.
3448 This is (very slightly) less likely to mess up due to wraparound.
3449 All uses changed.
3450
3451 * buffer.c: Integer signedness fixes.
3452 (alloc_buffer_text, enlarge_buffer_text):
3453 Use ptrdiff_t rather than size_t when either will do, as we prefer
3454 signed integers.
3455
3456 * alloc.c: Integer signedness and overflow fixes.
3457 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3458 (__malloc_size_t): Default to size_t, not to int.
3459 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3460 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3461 Prefer ptrdiff_t to size_t when either would do, as we prefer
3462 signed integers.
3463 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3464 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3465 Now const. Initialize with values that are in range even if char
3466 is signed.
3467 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3468 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3469 These functions do the right thing with sizes > 2**32.
3470 (check_depth): Now ptrdiff_t, not int.
3471 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3472 Adjust to new way of storing sizes. Check for size overflow bugs
3473 in rest of code.
3474 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3475 slightly wrong anyway, as it missed one instance of
3476 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3477 (refill_memory_reserve): Omit needless cast to size_t.
3478 (mark_object_loop_halt): Mark as externally visible.
3479
3480 * xselect.c: Integer signedness and overflow fixes.
3481 (Fx_register_dnd_atom, x_handle_dnd_message):
3482 Use ptrdiff_t, not size_t, since we prefer signed.
3483 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3484 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3485 x_dnd_atoms_size and x_dnd_atoms_length.
3486
3487 * doprnt.c: Prefer signed to unsigned when either works.
3488 * eval.c (verror):
3489 * doprnt.c (doprnt):
3490 * lisp.h (doprnt):
3491 * xdisp.c (vmessage):
3492 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3493 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3494 prefer signed arithmetic to avoid comparison confusion.
3495 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3496 but is a bit tricky.
3497
3498 Assume freestanding C89 headers, string.h, stdlib.h.
3499 * data.c, doprnt.c, floatfns.c, print.c:
3500 Include float.h unconditionally.
3501 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3502 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3503 * regex.c: Likewise for stddef.h, string.h.
3504 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3505 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3506 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3507 (STDC_HEADERS): Remove obsolete defines.
3508 * sysdep.c: Include limits.h unconditionally.
3509
3510 Assume support for memcmp, memcpy, memmove, memset.
3511 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3512 * regex.c (memcmp, memcpy):
3513 Remove; we assume C89 now.
3514
3515 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3516 (__malloc_safe_bcopy): Remove; no longer needed.
3517
3518 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3519 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3520 well either way, and we prefer signed to unsigned.
3521
3522 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3523
3524 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3525 closes the connection while we're reading (bug#9182).
3526
3527 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3528
3529 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3530 are specified (Bug#9168).
3531
3532 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3533
3534 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3535 Found by GCC static checking and --with-wide-int on a 32-bit host.
3536
3537 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3538
3539 * xdisp.c (compute_display_string_pos): Fix logic of caching
3540 previous display string position. Initialize cached_prev_pos to
3541 -1. Fixes slow-down at the beginning of a buffer.
3542
3543 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3544
3545 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3546 for attrs[LFACE_FONTSET_INDEX].
3547
3548 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3549
3550 * xml.c (parse_region): Remove unused local
3551 that was recently introduced.
3552
3553 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3554
3555 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3556 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3557
3558 * xdisp.c (move_it_in_display_line_to): Record the best matching
3559 position for TO_CHARPOS while scanning the line, and restore it on
3560 exit if none of the characters scanned was an exact match.
3561 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3562 when exact match is impossible due to invisible text, and the
3563 lines are truncated.
3564
3565 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3566
3567 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3568 for OSX >= 10.7.
3569
3570 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3571
3572 Fix a significant slow-down of cursor motion with C-n, C-p,
3573 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3574 auto-repeat under bidi redisplay in fontified buffers.
3575 * xdisp.c (compute_stop_pos_backwards): New function.
3576 (next_element_from_buffer): Call compute_stop_pos_backwards to
3577 find a suitable prev_stop when we find ourselves before
3578 base_level_stop.
3579 (reseat): Don't look for prev_stop, as that could mean a very long
3580 run.
3581 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3582 <cached_disp_overlay_modiff>: Cache for last found display string
3583 position.
3584 (compute_display_string_pos): Return the cached position if asked
3585 about the same buffer in the same area of character positions, and
3586 the buffer wasn't changed since the time the display string
3587 position was cached.
3588
3589 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3590
3591 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3592 is an integer, which is important for empty lines. (Bug#9149)
3593
3594 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3595
3596 * frame.c (Fmodify_frame_parameters): In tty case, update the
3597 default face if necessary (Bug#4238).
3598
3599 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3600
3601 * editfns.c (Fstring_to_char): No need to explain what a character
3602 is in the docstring (Bug#6576).
3603
3604 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3605
3606 * xml.c (parse_region): Make sure we always return a tree.
3607
3608 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3609
3610 * xml.c (parse_region): If a document contains only comments,
3611 return that, too.
3612
3613 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3614
3615 * xml.c (make_dom): Return comments, too.
3616
3617 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3618
3619 Port to OpenBSD.
3620 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3621 and the surrounding thread.
3622 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3623 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3624 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3625 timer goes off.
3626 * s/openbsd.h (BROKEN_SIGIO): Define.
3627 * unexelf.c (unexec) [__OpenBSD__]:
3628 Don't update the .mdebug section of the Alpha COFF symbol table.
3629
3630 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3631
3632 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3633 (bug#8460).
3634
3635 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3636
3637 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3638 This fixes some race conditions on the permissions of any newly
3639 created file.
3640
3641 * alloc.c (valid_pointer_p): Use pipe, not open.
3642 This fixes some permissions issues when debugging.
3643
3644 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3645 If fchown fails to set both uid and gid, try to set just gid,
3646 as that is sometimes allowed. Adjust the file's mode to eliminate
3647 setuid or setgid bits that are inappropriate if fchown fails.
3648
3649 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3650
3651 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3652 to compare Lisp_Objects.
3653 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3654 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3655 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3656
3657 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3658
3659 * lread.c (read_integer): Unread even EOF character.
3660 (read1): Likewise. Properly record start position of symbol.
3661
3662 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3663 symbol character follows.
3664
3665 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3666
3667 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3668 This works around a problem with the previous change to Fcopy_file.
3669 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3670 and without this change, GCC might complain about discarding
3671 fchown's return value.
3672
3673 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3674
3675 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3676
3677 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3678
3679 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3680
3681 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3682
3683 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3684 it's used from the C level.
3685
3686 * process.c: Use the same condition for POLL_FOR_INPUT in both
3687 keyboard.c and process.c (bug#1858).
3688
3689 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3690
3691 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3692 (Fgnutls_boot): Use it.
3693
3694 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3695
3696 * doc.c (Fsubstitute_command_keys): Revert last change.
3697
3698 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3699
3700 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3701 quotes the next character, and doesn't affect other longer
3702 sequences (bug#8935).
3703
3704 * lread.c (syms_of_lread): Clarify that is isn't only
3705 `eval-buffer' and `eval-defun' that's affected by
3706 `lexical-binding' (bug#8460).
3707
3708 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3709
3710 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3711 bidi redisplay when a line includes both an image and is truncated.
3712
3713 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3714
3715 Fix minor problems found by static checking.
3716 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3717 (elsz): Now a signed constant, not a size_t var. We prefer signed
3718 types to unsigned, to avoid integer comparison confusion. Without
3719 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3720 "cannot optimize loop, the loop counter may overflow", a symptom
3721 of the confusion.
3722 * indent.c (Fvertical_motion): Mark locals as initialized.
3723 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3724
3725 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3726
3727 * search.c (Fre_search_backward): Mention `case-fold-search' in
3728 all the re_search_* functions (bug#8138).
3729
3730 * keyboard.c (Fopen_dribble_file): Document when the file is
3731 closed (bug#8056).
3732
3733 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3734
3735 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3736 bidi_cache_idx.
3737
3738 Support bidi reordering of display and overlay strings.
3739 * xdisp.c (compute_display_string_pos)
3740 (compute_display_string_end): Accept additional argument STRING.
3741 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3742 (reseat_to_string): Initialize bidi_it->string.s and
3743 bidi_it->string.schars.
3744 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3745 NULL (avoids a crash in bidi_paragraph_init).
3746 Initialize itb.string.lstring.
3747 (init_iterator): Call bidi_init_it only of a valid
3748 buffer position was specified. Initialize paragraph_embedding to
3749 L2R.
3750 (reseat_to_string): Initialize the bidi iterator.
3751 (display_string): If we need to ignore text properties of
3752 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3753 original value of -1 will not work with bidi.)
3754 (compute_display_string_pos): First arg is now struct
3755 `text_pos *'; all callers changed. Support display properties on
3756 Lisp strings.
3757 (compute_display_string_end): Support display properties on Lisp
3758 strings.
3759 (init_iterator, reseat_1, reseat_to_string): Initialize the
3760 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3761 when iterating on a string not from display properties).
3762 (compute_display_string_pos, compute_display_string_end):
3763 Fix calculation of the object to scan. Fixes an error when using
3764 arrow keys.
3765 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3766 base_level_stop; instead, set base_level_stop to BEGV.
3767 Fixes crashes in vertical-motion.
3768 (next_element_from_buffer): Improve commentary for when
3769 the iterator is before prev_stop.
3770 (init_iterator): Initialize bidi_p from the default value of
3771 bidi-display-reordering, not from buffer-local value. Use the
3772 buffer-local value only if initializing for buffer iteration.
3773 (handle_invisible_prop): Support invisible properties on strings
3774 that are being bidi-reordered.
3775 (set_iterator_to_next): Support bidi reordering of C strings and
3776 Lisp strings.
3777 (next_element_from_string): Support bidi reordering of Lisp
3778 strings.
3779 (handle_stop_backwards): Support Lisp strings as well.
3780 (display_string): Support display of R2L glyph rows.
3781 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3782 (init_iterator): Don't initialize it->bidi_p for strings
3783 here.
3784 (reseat_to_string): Initialize it->bidi_p for strings here.
3785 (next_element_from_string, next_element_from_c_string)
3786 (next_element_from_buffer): Add xassert's for correspondence
3787 between IT's object being iterated and it->bidi_it.string
3788 structure.
3789 (face_before_or_after_it_pos): Support bidi iteration.
3790 (next_element_from_c_string): Handle the case of the first string
3791 character that is not the first one in the visual order.
3792 (get_visually_first_element): New function, refactored from common
3793 parts of next_element_from_buffer, next_element_from_string, and
3794 next_element_from_c_string.
3795 (tool_bar_lines_needed, redisplay_tool_bar)
3796 (display_menu_bar): Force left-to-right direction. Add a FIXME
3797 comment for making that be controlled by a user option.
3798 (push_it, pop_it): Save and restore the state of the
3799 bidi iterator. Save and restore the bidi_p flag.
3800 (pop_it): Iterate out of display property for string iteration as
3801 well.
3802 (iterate_out_of_display_property): Support iteration over strings.
3803 (handle_single_display_spec): Set up it->bidi_it for iteration
3804 over a display string, and call bidi_init_it.
3805 (handle_single_display_spec, next_overlay_string)
3806 (get_overlay_strings_1, push_display_prop): Set up the bidi
3807 iterator for displaying display or overlay strings.
3808 (forward_to_next_line_start): Don't use the shortcut if
3809 bidi-iterating.
3810 (back_to_previous_visible_line_start): If handle_display_prop
3811 pushed the iterator stack, restore the internal state of the bidi
3812 iterator by calling bidi_pop_it same number of times.
3813 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3814 and we are bidi-iterating, don't decrement the iterator position;
3815 instead, set the first_elt flag in the bidi iterator, to produce
3816 the same effect.
3817 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3818 (push_display_prop): xassert that we are iterating a buffer.
3819 (push_it, pop_it): Save and restore paragraph_embedding member.
3820 (handle_single_display_spec, next_overlay_string)
3821 (get_overlay_strings_1, reseat_1, reseat_to_string)
3822 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3823 correctly. Don't assume unibyte strings are not bidi-reordered.
3824 (compute_display_string_pos)
3825 (compute_display_string_end): Fix handling the case of C string.
3826 (push_it, pop_it): Save and restore from_disp_prop_p.
3827 (handle_single_display_spec, push_display_prop): Set the
3828 from_disp_prop_p flag.
3829 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3830 (pop_it): Call iterate_out_of_display_property only if we are
3831 popping after iteration over a string that came from a display
3832 property. Fix a typo in popping stretch info. Add an assertion
3833 for verifying that the iterator position is in sync with the bidi
3834 iterator.
3835 (handle_single_display_spec, get_overlay_strings_1)
3836 (push_display_prop): Fix initialization of paragraph direction for
3837 string when that of the parent object is not yet determined.
3838 (reseat_1): Call bidi_init_it to resync the bidi
3839 iterator with IT's position. (Bug#7616)
3840 (find_row_edges): If ROW->start.pos gives position
3841 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3842 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3843 Reset the from_disp_prop_p flag.
3844 (SAVE_IT, RESTORE_IT): New macros.
3845 (pos_visible_p, face_before_or_after_it_pos)
3846 (back_to_previous_visible_line_start)
3847 (move_it_in_display_line_to, move_it_in_display_line)
3848 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3849 (try_scrolling, redisplay_window, display_line): Use them when
3850 saving a temporary copy of the iterator and restoring it back.
3851 (back_to_previous_visible_line_start, reseat_1)
3852 (init_iterator): Empty the bidi cache "stack".
3853 (move_it_in_display_line_to): If iterator ended up at
3854 EOL, but we never saw any buffer positions smaller than
3855 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3856 motion in bidi-reordered lines.
3857 (move_it_in_display_line_to): Record prev_method and prev_pos
3858 immediately before the call to set_iterator_to_next. Fixes cursor
3859 motion in bidi-reordered lines with stretch glyphs and strings
3860 displayed in margins. (Bug#8133) (Bug#8867)
3861 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3862 TO_CHARPOS.
3863 (pos_visible_p): Support positions in bidi-reordered lines.
3864 Save and restore bidi cache.
3865
3866 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3867 (bidi_paragraph_info): Delete unused struct.
3868 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3869 (bidi_cache_start): New variable.
3870 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3871 to zero.
3872 (bidi_cache_fetch_state, bidi_cache_search)
3873 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3874 (bidi_cache_find, bidi_peek_at_next_level)
3875 (bidi_level_of_next_char, bidi_find_other_level_edge)
3876 (bidi_move_to_visually_next): Compare cache index with
3877 bidi_cache_start rather than with zero.
3878 (bidi_fetch_char): Accept new argument STRING; all callers
3879 changed. Support iteration over a string. Support strings with
3880 display properties. Support unibyte strings. Fix the type of
3881 `len' according to what STRING_CHAR_AND_LENGTH expects.
3882 (bidi_paragraph_init, bidi_resolve_explicit_1)
3883 (bidi_resolve_explicit, bidi_resolve_weak)
3884 (bidi_level_of_next_char, bidi_move_to_visually_next):
3885 Support iteration over a string.
3886 (bidi_set_sor_type, bidi_resolve_explicit_1)
3887 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3888 can now be zero (for strings); special values 0 and -1 were
3889 changed to -1 and -2, respectively.
3890 (bidi_char_at_pos): New function.
3891 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3892 Call it instead of FETCH_MULTIBYTE_CHAR.
3893 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3894 initialized to valid values.
3895 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3896 values.
3897 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3898 the test for valid cached positions. Fix the logic for looking up
3899 the sentinel state in the cache. GCPRO the Lisp string we are
3900 iterating.
3901 (bidi_push_it, bidi_pop_it): New functions.
3902 (bidi_initialize): Initialize the bidi cache start stack pointer.
3903 (bidi_cache_ensure_space): New function, refactored from part of
3904 bidi_cache_iterator_state. Don't assume the required size is just
3905 one BIDI_CACHE_CHUNK away.
3906 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3907 (bidi_count_bytes, bidi_char_at_pos): New functions.
3908 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3909 always valid if bidi_cache_idx is valid.
3910 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3911 is valid if it's going to be used.
3912 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3913 (bidi_cache_fetch_state, bidi_cache_search)
3914 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3915 (bidi_cache_iterator_state, bidi_cache_find)
3916 (bidi_find_other_level_edge, bidi_cache_start_stack):
3917 All variables related to cache indices are now EMACS_INT.
3918
3919 * dispextern.h (struct bidi_string_data): New structure.
3920 (struct bidi_it): New member `string'. Make flag members be 1-bit
3921 fields, and put them last in the struct.
3922 (compute_display_string_pos, compute_display_string_end):
3923 Update prototypes.
3924 (bidi_push_it, bidi_pop_it): Add prototypes.
3925 (struct iterator_stack_entry): New members bidi_p,
3926 paragraph_embedding, and from_disp_prop_p.
3927 (struct it): Member bidi_p is now a bit field 1 bit wide.
3928 (bidi_shelve_cache, bidi_unshelve_cache):
3929 Declare prototypes.
3930
3931 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3932 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3933 and vector-like objects.
3934
3935 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3936 cache around display iteration.
3937
3938 * window.c (Fwindow_end, window_scroll_pixel_based)
3939 (displayed_window_lines, Frecenter): Save and restore the bidi
3940 cache around display iteration.
3941
3942 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3943
3944 * editfns.c (Fdelete_region): Clarify the use of the named
3945 parameters (bug#6788).
3946
3947 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3948
3949 * indent.c (Fvertical_motion): Set and restore w->pointm when
3950 saving and restoring the window's buffer (Bug#9006).
3951
3952 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3953
3954 * editfns.c (Fstring_to_char): Clarify just what is returned
3955 (bug#6576). Text by Eli Zaretskii.
3956
3957 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3958
3959 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3960
3961 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3962
3963 * buffer.c (mmap_find): Fix a typo.
3964
3965 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3966
3967 Fix execution of x selection hooks.
3968 * xselect.c (Qx_lost_selection_functions)
3969 (Qx_sent_selection_functions): New vars.
3970 (syms_of_xselect): DEFSYM them.
3971 (x_handle_selection_request): Pass Qx_sent_selection_functions
3972 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3973 (x_handle_selection_clear,x_clear_frame_selections):
3974 Pass Qx_lost_selection_functions rather than
3975 Vx_lost_selection_functions to Frun_hook_with_args.
3976
3977 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3978
3979 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3980 The old code sometimes used this field without initializing it.
3981
3982 * alloc.c (gc_sweep): Don't read past end of array.
3983 In theory, the old code could also have corrupted Emacs internals,
3984 though it'd be very unlikely.
3985
3986 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3987
3988 * character.c (Fcharacterp): Don't advertise optional ignored
3989 argument. (Bug#4026)
3990
3991 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3992
3993 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3994 key" (bug#4257).
3995
3996 * window.c (Fset_window_start): Doc fix (bug#4199).
3997 (Fset_window_hscroll): Ditto.
3998
3999 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4000
4001 Fix minor new problems caught by GCC 4.6.1.
4002 * term.c (init_tty): Remove unused local.
4003 * xsettings.c (store_monospaced_changed): Define this function only
4004 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4005 not used otherwise.
4006
4007 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4008
4009 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4010
4011 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4012
4013 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4014 are the mini-buffer and the echo area (bug#3320).
4015
4016 * term.c (init_tty): Remove support for supdup, c10 and perq
4017 terminals, which are no longer supported (bug#1482).
4018
4019 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4020
4021 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4022
4023 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4024
4025 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4026 for non-popups (Bug#3642).
4027
4028 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4029
4030 * alloc.c (reset_malloc_hooks): Protoize.
4031 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4032 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4033 * cm.c (losecursor): Likewise.
4034 * data.c (fmod): Likewise.
4035 * dispnew.c (swap_glyphs_in_rows): Likewise.
4036 * emacs.c (memory_warning_signal): Likewise.
4037 * floatfns.c (float_error): Likewise.
4038 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4039 (otf_open, font_otf_capability, generate_otf_features)
4040 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4041 Likewise.
4042 * image.c (pbm_read_file): Likewise.
4043 * indent.c (string_display_width): Likewise.
4044 * intervals.c (check_for_interval, search_for_interval)
4045 (inc_interval_count, count_intervals, root_interval)
4046 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4047 * lread.c (defalias): Likewise.
4048 * ralloc.c (r_alloc_check): Likewise.
4049 * regex.c (set_image_of_range_1, set_image_of_range)
4050 (regex_grow_registers): Likewise.
4051 * sysdep.c (strerror): Likewise.
4052 * termcap.c (valid_filename_p, tprint, main): Likewise.
4053 * tparam.c (main): Likewise.
4054 * unexhp9k800.c (run_time_remap, save_data_space)
4055 (update_file_ptrs, read_header, write_header, calculate_checksum)
4056 (copy_file, copy_rest, display_header): Likewise.
4057 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4058 Likewise.
4059 * xdisp.c (check_it): Likewise.
4060 * xfaces.c (register_color, unregister_color, unregister_colors):
4061 Likewise.
4062 * xfns.c (print_fontset_result): Likewise.
4063 * xrdb.c (member, fatal, main): Likewise.
4064
4065 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4066
4067 Fix minor problems found by static checking (Bug#9031).
4068 * chartab.c (char_table_set_range, map_sub_char_table):
4069 Remove unused locals.
4070 (uniprop_table): Now static.
4071 * composite.c (_work_char): Remove unused static var.
4072
4073 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4074
4075 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4076
4077 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4078
4079 * gtkutil.c (qttip_cb): Remove code without function.
4080
4081 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4082
4083 * w32.c (pthread_sigmask): New stub.
4084
4085 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4086
4087 Use pthread_sigmask, not sigprocmask (Bug#9010).
4088 sigprocmask is portable only for single-threaded applications, and
4089 Emacs can be multi-threaded when it uses GTK.
4090 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4091 (LIBES): Use it.
4092 * callproc.c (Fcall_process):
4093 * process.c (create_process):
4094 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4095 Use pthread_sigmask, not sigprocmask.
4096
4097 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4098
4099 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4100 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4101 wrong (Bug#8591).
4102
4103 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4104
4105 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4106 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4107 (xg_hide_tooltip): Fix comment.
4108
4109 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4110 in registerServicesMenuSendTypes.
4111 (validRequestorForSendType): Don't check ns_return_types.
4112
4113 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4114 ns_return_type.
4115
4116 2011-07-08 Jason Rumney <jasonr@gnu.org>
4117
4118 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4119 SH_SHOW for hidden windows (Bug#5482).
4120
4121 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4122 frame struct members of non-existent frames (Bug#6284).
4123
4124 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4125
4126 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4127 variable firstTime not needed on OSX >= 10.6.
4128 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4129 >= 10.5. Use setKnobProportion, setDoubleValue.
4130
4131 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4132 (MAC_OS_X_VERSION_10_5): Define if not defined.
4133 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4134 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4135 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4136
4137 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4138 cString and lossyCString on OSX >= 10.4
4139
4140 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4141 sizeToFit on OSX >= 10.2.
4142
4143 * nsimage.m (allocInitFromFile): Don't use deprecated method
4144 bestRepresentationForDevice on OSX >= 10.6.
4145
4146 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4147 to avoid warning.
4148
4149 * emacs.c: Declare unexec_init_emacs_zone.
4150
4151 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4152
4153 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4154
4155 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4156 on svcsMenu (Bug#8842).
4157
4158 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4159 ns_return_types.
4160 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4161
4162 * nsterm.m (QUTF8_STRING): Declare.
4163 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4164 (validRequestorForSendType): Return type is (id).
4165 Change indexOfObjectIdenticalTo to indexOfObject.
4166 Check if we have local selection before returning self (Bug#8842).
4167 (writeSelectionToPasteboard): Put local selection into paste board
4168 if we have a local selection (Bug#8842).
4169 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4170
4171 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4172 (ns_get_local_selection): Declare.
4173
4174 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4175
4176 * keymap.c (describe_map_tree): Don't insert a double newline at
4177 the end of the buffer (bug#1169) and return whether we inserted
4178 something.
4179
4180 * callint.c (Fcall_interactively): Change "reading args" to
4181 "providing args" to try to clarify what it does (bug#1010).
4182
4183 2011-07-07 Kenichi Handa <handa@m17n.org>
4184
4185 * composite.c (composition_compute_stop_pos): Ignore a static
4186 composition starting before CHARPOS (Bug#8915).
4187
4188 * xdisp.c (handle_composition_prop): Likewise.
4189
4190 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4191
4192 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4193 (Bug#9015)
4194
4195 2011-07-07 Kenichi Handa <handa@m17n.org>
4196
4197 * character.h (unicode_category_t): New enum type.
4198
4199 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4200 (Qchar_code_property_table): New variable.
4201 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4202 (UNIPROP_COMPRESSED_FORM_P): New macros.
4203 (char_table_ascii): Uncompress the compressed values.
4204 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4205 Uncompress the compressed values.
4206 (sub_char_table_ref_and_range): Likewise.
4207 (char_table_ref_and_range): Uncompress the compressed values.
4208 (sub_char_table_set): New arg is_uniprop. Callers changed.
4209 Uncompress the compressed values.
4210 (sub_char_table_set_range): Args changed. Callers changed.
4211 (char_table_set_range): Adjuted for the above change.
4212 (map_sub_char_table): Delete args default_val and parent. Add arg
4213 top. Give decoded values to a Lisp function.
4214 (map_char_table): Adjust for the above change. Give decoded
4215 values to a Lisp function. Gcpro more variables.
4216 (uniprop_table_uncompress)
4217 (uniprop_decode_value_run_length): New functions.
4218 (uniprop_decoder, uniprop_decoder_count): New variables.
4219 (uniprop_get_decoder, uniprop_encode_value_character)
4220 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4221 New functions.
4222 (uniprop_encoder, uniprop_encoder_count): New variables.
4223 (uniprop_get_encoder, uniprop_table)
4224 (Funicode_property_table_internal, Fget_unicode_property_internal)
4225 (Fput_unicode_property_internal): New functions.
4226 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4227 Sunicode_property_table_internal, Sget_unicode_property_internal,
4228 and Sput_unicode_property_internal. Defvar_lisp
4229 char-code-property-alist.
4230
4231 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4232 Vunicode_category_table.
4233
4234 * font.c (font_range): Adjust for the change of
4235 Vunicode_category_table.
4236
4237 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4238
4239 * m/iris4d.h: Remove file, move contents ...
4240 * s/irix6-5.h: ... here.
4241
4242 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4243
4244 Remove unportable assumption about struct layout (Bug#8884).
4245 * alloc.c (mark_buffer):
4246 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4247 (clone_per_buffer_values): Don't assume that
4248 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4249 This isn't true in general, and it's particularly not true
4250 if Emacs is configured with --with-wide-int.
4251 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4252 New macros, used in the buffer.c change.
4253
4254 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4255
4256 * xsettings.c: Use both GConf and GSettings if both are available.
4257 (store_config_changed_event): Add comment.
4258 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4259 (store_tool_bar_style_changed): New functions.
4260 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4261 (struct xsettings): Move font inside HAVE_XFT.
4262 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4263 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4264 Move inside HAVE_XFT.
4265 (something_changed_gsettingsCB): Rename from something_changedCB.
4266 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4267 also.
4268 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4269 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4270 (something_changed_gconfCB): Rename from something_changedCB.
4271 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4272 (parse_settings): Move check for font inside HAVE_XFT.
4273 (read_settings, apply_xft_settings): Add comment.
4274 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4275 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4276 call store_font_name_changed.
4277 (xft_settings_event): Add comment.
4278 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4279 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4280 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4281 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4282 (xsettings_initialize): Call init_gsettings last.
4283 (xsettings_get_system_font, xsettings_get_system_normal_font):
4284 Add comment.
4285
4286 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4287
4288 Random fixes. E.g., (random) never returned negative values.
4289 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4290 subseconds part to the entropy, as that's a bit more random.
4291 Prefer signed to unsigned, since the signedness doesn't matter and
4292 in general we prefer signed. When given a limit, use a
4293 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4294 latter isn't right if USE_2_TAGS_FOR_INTS.
4295 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4296 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4297
4298 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4299
4300 * textprop.c (text_property_stickiness):
4301 Obey Vtext_property_default_nonsticky.
4302 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4303 * w32fns.c (syms_of_w32fns):
4304 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4305
4306 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4307
4308 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4309 This is more efficient than Ffile_directory_p and avoids a minor race.
4310
4311 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4312
4313 * buffer.c (Foverlay_put): Say what the return value is
4314 (bug#7835).
4315
4316 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4317 is a directory before asking whether to use the file name
4318 (bug#7564).
4319 (barf_or_query_if_file_exists): Make the "File is a directory"
4320 error be more correct.
4321
4322 * fns.c (Frequire): Remove the mention of the .gz files, since
4323 that's installation-specific, but keep the mention of
4324 `get-load-suffixes'.
4325
4326 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4329 Report string overflow if the output is too long.
4330
4331 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4332
4333 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4334 (syms_of_gnutls): Remove duplicate DEFSYM for
4335 Qgnutls_bootprop_verify_hostname_error, an error for
4336 Qgnutls_bootprop_verify_error (which is no longer used).
4337
4338 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4339 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4340 Also (re)move comments that are misplaced or no longer relevant.
4341
4342 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4343
4344 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4345
4346 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4347
4348 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4349 and background color parameters if they have been changed.
4350
4351 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4352
4353 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4354
4355 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4356
4357 * xsettings.c (SYSTEM_FONT): Define only when used.
4358 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4359
4360 * keymap.c (access_keymap_1): Now static.
4361
4362 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4363
4364 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4365 leave any prefix arg for the up event (Bug#1586).
4366
4367 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4368
4369 * lread.c (syms_of_lread): Mention single symbols defined by
4370 `defvar' or `defconst' (bug#7154).
4371
4372 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4373 (Frequire): Mention get-load-suffixes.
4374
4375 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4376
4377 * window.h (window): Remove clone_number slot.
4378 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4379 Remove.
4380 (make_parent_window, make_window, saved_window)
4381 (Fset_window_configuration, save_window_save): Don't deal with
4382 clone numbers.
4383 * buffer.c (Qclone_number): Remove declaration.
4384 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4385
4386 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4387
4388 Add multiple inheritance to keymaps.
4389 * keymap.c (Fmake_composed_keymap): New function.
4390 (Fset_keymap_parent): Simplify.
4391 (fix_submap_inheritance): Remove.
4392 (access_keymap_1): New function extracted from access_keymap to handle
4393 embedded parents and handle lists of maps.
4394 (access_keymap): Use it.
4395 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4396 (Fcopy_keymap): Handle embedded parents.
4397 (Fcommand_remapping, define_as_prefix): Simplify.
4398 (Fkey_binding): Simplify.
4399 (syms_of_keymap): Move minibuffer-local-completion-map,
4400 minibuffer-local-filename-completion-map,
4401 minibuffer-local-must-match-map, and
4402 minibuffer-local-filename-must-match-map to Elisp.
4403 (syms_of_keymap): Defsubr make-composed-keymap.
4404 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4405 (parse_menu_item): Trivial simplification.
4406
4407 2011-07-01 Glenn Morris <rgm@gnu.org>
4408
4409 * Makefile.in (SETTINGS_LIBS): Fix typo.
4410
4411 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4412
4413 * coding.c (Fencode_coding_string): Record the last coding system
4414 used, as the function doc string says (bug#8738).
4415
4416 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4417
4418 * xsettings.c (store_monospaced_changed): Take new font as arg and
4419 check for change against current_mono_font.
4420 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4421 (emacs_settings_constructor, emacs_settings_get_property)
4422 (emacs_settings_set_property, emacs_settings_class_init)
4423 (emacs_settings_init, gsettings_obj): Remove.
4424 (something_changedCB): New function for HAVE_GSETTINGS.
4425 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4426 with value as argument.
4427 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4428 g_settings_new (Bug#8967). Do not create gsettings_obj.
4429 Remove calls to g_settings_bind. Connect something_changedCB to
4430 "changed".
4431
4432 * xgselect.c: Add defined (HAVE_GSETTINGS).
4433 (xgselect_initialize): Ditto.
4434
4435 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4436 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4437 xg_select.
4438
4439 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4440
4441 * eval.c (struct backtrace): Simplify and port the data structure.
4442 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4443 signed bit field, as this assumption is not portable and it makes
4444 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4445 "char debug_on_exit : 1" as this is not portable either; instead,
4446 use the portable "unsigned int debug_on_exit : 1". Remove unused
4447 member evalargs. Remove obsolete comments about cc bombing out.
4448
4449 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4450
4451 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4452 Let HAVE_GSETTINGS override HAVE_GCONF.
4453 (store_monospaced_changed): New function.
4454 (EMACS_SETTINGS): A new type derived from GObject to handle
4455 GSettings notifications.
4456 (emacs_settings_constructor, emacs_settings_get_property)
4457 (emacs_settings_set_property, emacs_settings_class_init):
4458 New functions.
4459 (gsettings_client, gsettings_obj): New variables.
4460 (GSETTINGS_SCHEMA): New define.
4461 (something_changedCB): Call store_monospaced_changed.
4462 (init_gsettings): New function.
4463 (xsettings_initialize): Call init_gsettings.
4464 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4465 to NULL.
4466
4467 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4468 GCONF_CFLAGS/LIBS.
4469
4470 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4471
4472 * window.c (resize_root_window, grow_mini_window)
4473 (shrink_mini_window): Rename Qresize_root_window to
4474 Qwindow_resize_root_window and Qresize_root_window_vertically to
4475 Qwindow_resize_root_window_vertically.
4476
4477 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4478
4479 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4480
4481 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4482
4483 * makefile.w32-in: Redesign dependencies so they reflect more
4484 clearly which files are directly included by each source file,
4485 and not through other includes.
4486
4487 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4488
4489 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4490 (sort_overlays, overlay_strings): When an overlay's clone number
4491 matches the window's clone number process the overlay even if
4492 the overlay's window property doesn't match the current window.
4493
4494 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4495 (Fwindow_hchild): Rename to Fwindow_left_child.
4496 (Fwindow_next): Rename to Fwindow_next_sibling.
4497 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4498 (resize_window_check): Rename to window_resize_check.
4499 (resize_window_apply): Rename to window_resize_apply.
4500 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4501 (Fdelete_other_windows_internal, resize_frame_windows)
4502 (Fsplit_window_internal, Fdelete_window_internal)
4503 (grow_mini_window, shrink_mini_window)
4504 (Fresize_mini_window_internal): Fix callers accordingly.
4505
4506 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4507
4508 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4509 (emacs_fixed_set_min_size): Remove.
4510 (emacs_fixed_new): Take frame as argument.
4511
4512 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4513 (_EmacsFixedPrivate): Remove minwidth/height.
4514 Add struct frame *f.
4515 (emacs_fixed_init): Initialize priv->f.
4516 (get_parent_class, emacs_fixed_set_min_size): Remove.
4517 (emacs_fixed_new): Set priv->f to argument.
4518 (emacs_fixed_get_preferred_width)
4519 (emacs_fixed_get_preferred_height): Use min_width/height from
4520 frames size_hint to set minimum and natural (Bug#8919).
4521 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4522 and use min_width/height from frames size_hint to set
4523 min_width/height (Bug#8919).
4524
4525 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4526 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4527 Fix indentation.
4528
4529 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4530
4531 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4532 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4533 called at ZV.
4534
4535 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4536
4537 * process.c (wait_reading_process_output): Bypass select if
4538 waiting for a cell while ignoring keyboard input, and input is
4539 pending. Suggested by Jan Djärv (Bug#8869).
4540
4541 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4542
4543 Use gnulib's dup2 module instead of rolling our own.
4544 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4545
4546 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4547
4548 * dispnew.c (scrolling_window): Before scrolling, turn off a
4549 mouse-highlight in the window being scrolled.
4550
4551 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4552
4553 Move DEFSYM to lisp.h and use everywhere.
4554
4555 * character.h (DEFSYM): Move declaration...
4556 * lisp.h (DEFSYM): ...here.
4557
4558 * gnutls.c:
4559 * minibuf.c:
4560 * w32menu.c:
4561 * w32proc.c:
4562 * w32select.c: Don't include character.h.
4563
4564 * alloc.c (syms_of_alloc):
4565 * buffer.c (syms_of_buffer):
4566 * bytecode.c (syms_of_bytecode):
4567 * callint.c (syms_of_callint):
4568 * casefiddle.c (syms_of_casefiddle):
4569 * casetab.c (init_casetab_once):
4570 * category.c (init_category_once, syms_of_category):
4571 * ccl.c (syms_of_ccl):
4572 * cmds.c (syms_of_cmds):
4573 * composite.c (syms_of_composite):
4574 * dbusbind.c (syms_of_dbusbind):
4575 * dired.c (syms_of_dired):
4576 * dispnew.c (syms_of_display):
4577 * doc.c (syms_of_doc):
4578 * editfns.c (syms_of_editfns):
4579 * emacs.c (syms_of_emacs):
4580 * eval.c (syms_of_eval):
4581 * fileio.c (syms_of_fileio):
4582 * fns.c (syms_of_fns):
4583 * frame.c (syms_of_frame):
4584 * fringe.c (syms_of_fringe):
4585 * insdel.c (syms_of_insdel):
4586 * keymap.c (syms_of_keymap):
4587 * lread.c (init_obarray, syms_of_lread):
4588 * macros.c (syms_of_macros):
4589 * msdos.c (syms_of_msdos):
4590 * print.c (syms_of_print):
4591 * process.c (syms_of_process):
4592 * search.c (syms_of_search):
4593 * sound.c (syms_of_sound):
4594 * syntax.c (init_syntax_once, syms_of_syntax):
4595 * terminal.c (syms_of_terminal):
4596 * textprop.c (syms_of_textprop):
4597 * undo.c (syms_of_undo):
4598 * w32.c (globals_of_w32):
4599 * window.c (syms_of_window):
4600 * xdisp.c (syms_of_xdisp):
4601 * xfaces.c (syms_of_xfaces):
4602 * xfns.c (syms_of_xfns):
4603 * xmenu.c (syms_of_xmenu):
4604 * xsettings.c (syms_of_xsettings):
4605 * xterm.c (syms_of_xterm): Use DEFSYM.
4606
4607 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4608
4609 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4610
4611 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4612
4613 Integer and buffer overflow fixes (Bug#8873).
4614
4615 * print.c (printchar, strout): Check for string overflow.
4616 (PRINTPREPARE, printchar, strout):
4617 Don't set size unless allocation succeeds.
4618
4619 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4620 for sizes. Check for string overflow more accurately.
4621 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4622
4623 * macros.c: Integer and buffer overflow fixes.
4624 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4625 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4626 Use ptrdiff_t, not int, for sizes.
4627 Don't increment bufsize until after realloc succeeds.
4628 Check for size-calculation overflow.
4629 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4630
4631 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4632
4633 * lread.c: Integer overflow fixes.
4634 (read_integer): Radix is now EMACS_INT, not int,
4635 to improve quality of diagnostics for out-of-range radices.
4636 Calculate buffer size correctly for out-of-range radices.
4637 (read1): Check for integer overflow in radices, and in
4638 read-circle numbers.
4639 (read_escape): Avoid int overflow.
4640 (Fload, openp, read_buffer_size, read1)
4641 (substitute_object_recurse, read_vector, read_list, map_obarray):
4642 Use ptrdiff_t, not int, for sizes.
4643 (read1): Use EMACS_INT, not int, for sizes.
4644 Check for size overflow.
4645
4646 * image.c (cache_image): Check for size arithmetic overflow.
4647
4648 * lread.c: Integer overflow issues.
4649 (saved_doc_string_size, saved_doc_string_length)
4650 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4651 Now ptrdiff_t, not int.
4652 (read1): Don't assume doc string length fits in int. Check for
4653 out-of-range doc string lengths.
4654 (read_list): Don't assume file position fits in int.
4655 (read_escape): Check for hex character overflow.
4656
4657 2011-06-22 Leo Liu <sdl.web@gmail.com>
4658
4659 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4660 Move to minibuffer.el.
4661
4662 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4663
4664 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4665 The following patches are for when GLYPH_DEBUG && !XASSERT.
4666 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4667 * dispnew.c (flush_stdout):
4668 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4669 Mark as externally visible.
4670 * dispnew.c (check_window_matrix_pointers): Now static.
4671 * dispnew.c (window_to_frame_vpos):
4672 * xfns.c (unwind_create_frame):
4673 * xterm.c (x_check_font): Remove unused local.
4674 * scroll.c (CHECK_BOUNDS):
4675 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4676 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4677 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4678 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4679 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4680 Now static.
4681 (debug_method_add): Use va_list and vsprintf rather than relying
4682 on undefined behavior with wrong number of arguments.
4683 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4684 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4685 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4686 since we're not interested in debugging glyphs with old libraries.
4687 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4688 GCC 4.6.0's static checking.
4689
4690 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4691
4692 Integer overflow and signedness fixes (Bug#8873).
4693 A few related buffer overrun fixes, too.
4694
4695 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4696
4697 * dispextern.h (struct face.stipple):
4698 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4699 (x_bitmap_mask, x_allocate_bitmap_record)
4700 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4701 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4702 (x_create_bitmap_from_xpm_data):
4703 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4704 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4705 (.bitmaps_last):
4706 * xfaces.c (load_pixmap):
4707 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4708 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4709 (.bitmaps_last, struct x_output.icon_bitmap):
4710 Use ptrdiff_t, not int, for bitmap indexes.
4711 (x_allocate_bitmap_record): Check for size overflow.
4712 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4713
4714 Use ptrdiff_t, not int, for overlay counts.
4715 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4716 * editfns.c (overlays_around, get_pos_property):
4717 * textprop.c (get_char_property_and_overlay):
4718 * xdisp.c (next_overlay_change, note_mouse_highlight):
4719 * xfaces.c (face_at_buffer_position):
4720 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4721 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4722 (Fnext_overlay_change, Fprevious_overlay_change)
4723 (mouse_face_overlay_overlaps, Foverlays_in):
4724 Use ptrdiff_t, not int, for sizes.
4725 (overlays_at, overlays_in): Check for size-calculation overflow.
4726
4727 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4728
4729 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4730 (x_session_initialize): Do not assume string length fits in int.
4731
4732 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4733 This is unlikely, but can occur if DPI is outlandish.
4734
4735 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4736 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4737
4738 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4739 * xrdb.c (magic_file_p, search_magic_path):
4740 Omit last arg SUFFIX; it was always 0. All callers changed.
4741 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4742
4743 * xfont.c (xfont_match): Avoid need for strlen.
4744
4745 * xfns.c: Don't assume strlen fits in int.
4746 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4747
4748 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4749 not unsigned long, as we prefer signed integers. All callers changed.
4750 Detect integer overflow in repeat count.
4751 (message_dolog): Don't assume print length fits in 39 bytes.
4752 (display_mode_element): Don't assume strlen fits in int.
4753
4754 * termcap.c: Don't assume sizes fit in int and never overflow.
4755 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4756 (gobble_line): Check for size-calculation overflow.
4757
4758 * minibuf.c (Fread_buffer):
4759 * lread.c (intern, intern_c_string):
4760 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4761 Don't assume string length fits in int.
4762
4763 * keyboard.c (parse_tool_bar_item):
4764 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4765
4766 * font.c: Don't assume string length fits in int.
4767 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4768 Use ptrdiff_t, not int.
4769 (font_intern_prop): Don't assume string length fits in int.
4770 Don't assume integer property fits in fixnum.
4771 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4772
4773 * filelock.c: Fix some buffer overrun and integer overflow issues.
4774 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4775 Reformulate so as not to need the command string.
4776 Invoke gzip -cd rather than gunzip, as it's more portable.
4777 (lock_info_type, lock_file_1, lock_file):
4778 Don't assume pid_t and time_t fit in unsigned long.
4779 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4780 (current_lock_owner): Prefer signed type for sizes.
4781 Use memcpy, not strncpy, where memcpy is what is really wanted.
4782 Don't assume (via atoi) that time_t and pid_t fit in int.
4783 Check for time_t and/or pid_t out of range, e.g., via a network share.
4784 Don't alloca where an auto var works fine.
4785
4786 * fileio.c: Fix some integer overflow issues.
4787 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4788 Don't assume string length fits in int.
4789 (directory_file_name): Don't assume string length fits in long.
4790 (make_temp_name): Don't assume pid fits in int, or that its print
4791 length is less than 20.
4792
4793 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4794
4795 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4796
4797 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4798
4799 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4800 We prefer signed integers, even for size calculations.
4801
4802 * emacs.c: Don't assume string length fits in 'int'.
4803 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4804 (main): Don't invoke strlen when not needed.
4805
4806 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4807 (XD_DEBUG_MESSAGE): Don't waste a byte.
4808
4809 * callproc.c (getenv_internal_1, getenv_internal)
4810 (Fgetenv_internal):
4811 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4812
4813 * lread.c (invalid_syntax): Omit length argument.
4814 All uses changed. This doesn't fix a bug, but it simplifies the
4815 code away from its former Hollerith-constant appearance, and it's
4816 one less 'int' to worry about when looking at integer-overflow issues.
4817 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4818
4819 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4820 This didn't break anything, but it didn't help either.
4821 It's confusing to put a bogus integer in a place where the actual
4822 value does not matter.
4823 (LIST_END_P): Remove unused macro and its bogus comment.
4824 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4825
4826 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4827 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4828 implementation.
4829 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4830 We prefer signed types, and the value cannot exceed the EMACS_INT
4831 range anyway (because otherwise the length would not be representable).
4832 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4833 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4834 This avoids a GCC warning when WIDE_EMACS_INT.
4835
4836 * indent.c (sane_tab_width): New function.
4837 (current_column, scan_for_column, Findent_to, position_indentation)
4838 (compute_motion): Use it. This is just for clarity.
4839 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4840
4841 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4842
4843 * lisp.h (lint_assume): New macro.
4844 * composite.c (composition_gstring_put_cache):
4845 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4846
4847 * editfns.c, insdel.c:
4848 Omit unnecessary forward decls, to simplify future changes.
4849
4850 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4851
4852 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4853
4854 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4855 Use much-faster test for byte-length change.
4856 Don't assume string byte-length fits in 'int'.
4857 Check that character arg fits in 'int'.
4858 (mapcar1): Declare byte as byte, for clarity.
4859
4860 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4861
4862 * fns.c (concat): Catch string overflow earlier.
4863 Do not rely on integer wraparound.
4864
4865 * dispextern.h (struct it.overlay_strings_charpos)
4866 (struct it.selective): Now EMACS_INT, not int.
4867 * xdisp.c (forward_to_next_line_start)
4868 (back_to_previous_visible_line_start)
4869 (reseat_at_next_visible_line_start, next_element_from_buffer):
4870 Don't arbitrarily truncate the value of 'selective' to int.
4871
4872 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4873
4874 * composite.c: Don't truncate sizes to 'int'.
4875 (composition_gstring_p, composition_reseat_it)
4876 (composition_adjust_point): Use EMACS_INT, not int.
4877 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4878 not EMACS_UINT, for indexes.
4879
4880 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4881
4882 * buffer.c: Include <verify.h>.
4883 (struct sortvec.priority, struct sortstr.priority):
4884 Now EMACS_INT, not int.
4885 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4886 (struct sortstr.size, record_overlay_string)
4887 (struct sortstrlist.size, struct sortlist.used):
4888 Don't truncate size to int.
4889 (record_overlay_string): Check for size-calculation overflow.
4890 (init_buffer_once): Check at compile-time, not run-time.
4891
4892 2011-06-22 Jim Meyering <meyering@redhat.com>
4893
4894 Don't leak an XBM-image-sized buffer
4895 * image.c (xbm_load): Free the image buffer after using it.
4896
4897 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4898
4899 Port to Sun C.
4900 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4901 that Sun C diagnosed.
4902 * fns.c (secure_hash): Fix pointer signedness issue.
4903 * intervals.c (static_offset_intervals): New function.
4904 (offset_intervals): Use it.
4905
4906 2011-06-21 Leo Liu <sdl.web@gmail.com>
4907
4908 * deps.mk (fns.o):
4909 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4910 sha512.h.
4911
4912 * fns.c (secure_hash): Rename from crypto_hash_function and change
4913 the first arg to accept symbols.
4914 (Fsecure_hash): New primitive.
4915 (syms_of_fns): New symbols.
4916
4917 2011-06-20 Deniz Dogan <deniz@dogan.se>
4918
4919 * process.c (Fset_process_buffer): Clarify return value in
4920 docstring.
4921
4922 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4923
4924 * dispnew.c (add_window_display_history): Use BVAR.
4925
4926 * xdisp.c (debug_method_add): Use BVAR.
4927 (check_window_end, dump_glyph_matrix, dump_glyph)
4928 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4929
4930 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4931 Likewise.
4932
4933 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4934 check till after the cache is created in init_frame_faces.
4935
4936 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4937
4938 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4939
4940 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4941
4942 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4943 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4944 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4945
4946 Improve buffer-overflow checking (Bug#8873).
4947 * fileio.c (Finsert_file_contents):
4948 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4949 Remove the old (too-loose) buffer overflow checks.
4950 They weren't needed, since make_gap checks for buffer overflow.
4951 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4952 The old code merely checked for Emacs fixnum overflow, and relied
4953 on undefined (wraparound) behavior. The new code avoids undefined
4954 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4955
4956 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4957 Tune. Don't use wider integers than needed. Don't use alloca.
4958 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4959
4960 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4961
4962 * insdel.c, lisp.h (buffer_overflow): New function.
4963 (insert_from_buffer_1, replace_range, replace_range_2):
4964 * insdel.c (make_gap_larger):
4965 * editfns.c (Finsert_char):
4966 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4967
4968 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4969
4970 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4971
4972 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4973
4974 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4975 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4976
4977 * fileio.c: Don't assume EMACS_INT fits in off_t.
4978 (emacs_lseek): New static function.
4979 (Finsert_file_contents, Fwrite_region): Use it.
4980 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4981
4982 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4983
4984 * fns.c: Don't overflow int when computing a list length.
4985 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4986 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4987 truncation on 64-bit hosts. Check for QUIT every
4988 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4989 faster and is responsive enough.
4990 (Flength): Report an error instead of overflowing an integer.
4991 (Fsafe_length): Return a float if the value is not representable
4992 as a fixnum. This shouldn't happen except in contrived situations.
4993 (Fnthcdr, Fsort): Don't assume list length fits in int.
4994 (Fcopy_sequence): Don't assume vector length fits in int.
4995
4996 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4997 (header_size, word_size): New constants.
4998 (allocate_vectorlike): Don't check size overflow here.
4999 (allocate_vector): Check it here instead, since this is the only
5000 caller of allocate_vectorlike that could cause overflow.
5001 Check that the new vector's length is representable as a fixnum.
5002
5003 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5004 The previous code was bogus. For example, next_almost_prime (32)
5005 returned 39, which is undesirable as it is a multiple of 3; and
5006 next_almost_prime (24) returned 25, which is a multiple of 5 so
5007 why was the code bothering to check for multiples of 7?
5008
5009 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5010
5011 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5012
5013 Variadic C functions now count arguments with ptrdiff_t.
5014 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5015 Back then I didn't know that the Emacs coding style prefers signed int.
5016 Also, in the meantime I found a few more instances where arguments
5017 were being counted with int, which may truncate counts on 64-bit
5018 machines, or EMACS_INT, which may be unnecessarily wide.
5019 * lisp.h (struct Lisp_Subr.function.aMANY)
5020 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5021 Arg counts are now ptrdiff_t, not size_t.
5022 All variadic functions and their callers changed accordingly.
5023 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5024 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5025 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5026 * callint.c (Fcall_interactively): Check arg count for overflow,
5027 to avoid potential buffer overrun. Use signed char, not 'int',
5028 for 'varies' array, so that we needn't bother to check its size
5029 calculation for overflow.
5030 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5031 * eval.c (apply_lambda):
5032 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5033 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5034 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5035
5036 * callint.c (Fcall_interactively): Don't use index var as event count.
5037
5038 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5039 * mem-limits.h (SIZE): Remove; no longer used.
5040
5041 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5042
5043 Remove unnecessary casts.
5044 * xterm.c (x_term_init):
5045 * xfns.c (x_set_border_pixel):
5046 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5047 These aren't needed now that we assume ANSI C.
5048
5049 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5050 It's more likely to cause problems (due to unsigned overflow)
5051 than to cure them.
5052
5053 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5054
5055 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5056
5057 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5058
5059 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5060
5061 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5062
5063 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5064
5065 GLYPH_CODE_FACE returns EMACS_INT, not int.
5066 * dispextern.h (merge_faces):
5067 * xfaces.c (merge_faces):
5068 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5069 Don't assume EMACS_INT fits in int.
5070
5071 * character.h (CHAR_VALID_P): Remove unused parameter.
5072 * fontset.c, lisp.h, xdisp.c: All uses changed.
5073
5074 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5075
5076 * fns.c (concat): Minor tuning based on overflow analysis.
5077 This doesn't fix any bugs. Use int to hold character, instead
5078 of constantly refetching from Emacs object. Use XFASTINT, not
5079 XINT, for value known to be a character. Don't bother comparing
5080 a single byte to 0400, as it's always less.
5081
5082 * floatfns.c (Fexpt):
5083 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5084
5085 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5086 for characters.
5087
5088 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5089
5090 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5091 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5092 incorrectly succeed when S was a string, because 4294967386 was
5093 truncated before it was used.
5094
5095 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5096 Otherwise, an out-of-range integer could cause undefined behavior
5097 on a 64-bit host.
5098
5099 * composite.c: Use int, not EMACS_INT, for characters.
5100 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5101 EMACS_INT, for values that are known to be in character range.
5102 This doesn't fix any bugs but is the usual style inside Emacs and
5103 may generate better code on 32-bit machines.
5104
5105 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5106 This is for reasons similar to the recent CHAR_STRING fix.
5107 * charset.c (Fencode_char): Check that character arg is actually
5108 a character. Pass an int to ENCODE_CHAR.
5109 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5110 wider than 'int', as a compile-time check to prevent future regressions
5111 in this area.
5112
5113 * character.c (char_string): Remove unnecessary casts.
5114
5115 Make sure a 64-bit char is never passed to CHAR_STRING.
5116 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5117 by silently ignoring the top 32 bits, allowing some values
5118 that were far too large to be valid characters.
5119 * character.h: Include <verify.h>.
5120 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5121 arguments are no wider than unsigned, as a compile-time check
5122 to prevent future regressions in this area.
5123 * data.c (Faset):
5124 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5125 (Fsubst_char_in_region):
5126 * fns.c (concat):
5127 * xdisp.c (decode_mode_spec_coding):
5128 Adjust to CHAR_STRING's new requirement.
5129 * editfns.c (Finsert_char, Fsubst_char_in_region):
5130 * fns.c (concat): Check that character args are actually
5131 characters. Without this test, these functions did the wrong
5132 thing with wildly out-of-range values on 64-bit hosts.
5133
5134 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5135 These casts should not be needed on 32-bit hosts, either.
5136 * keyboard.c (read_char):
5137 * lread.c (Fload): Remove casts to unsigned.
5138
5139 * lisp.h (UNSIGNED_CMP): New macro.
5140 This fixes comparison bugs on 64-bit hosts.
5141 (ASCII_CHAR_P): Use it.
5142 * casefiddle.c (casify_object):
5143 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5144 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5145 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5146 * dispextern.h (FACE_FROM_ID):
5147 * keyboard.c (read_char): Use UNSIGNED_CMP.
5148
5149 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5150 not to EMACS_INT, to avoid GCC warning.
5151
5152 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5153
5154 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5155 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5156 isn't needed on 32-bit machines.
5157
5158 * buffer.c (Fgenerate_new_buffer_name):
5159 Use EMACS_INT for count, not int.
5160 (advance_to_char_boundary): Return EMACS_INT, not int.
5161
5162 * data.c (Qcompiled_function): Now static.
5163
5164 * window.c (window_body_lines): Now static.
5165
5166 * image.c (gif_load): Rename local to avoid shadowing.
5167
5168 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5169 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5170 * alloc.c (make_save_value): Integer argument is now of type
5171 ptrdiff_t, not int.
5172 (mark_object): Use ptrdiff_t, not int.
5173 * lisp.h (pD): New macro.
5174 * print.c (print_object): Use it.
5175
5176 * alloc.c: Use EMACS_INT, not int, to count objects.
5177 (total_conses, total_markers, total_symbols, total_vector_size)
5178 (total_free_conses, total_free_markers, total_free_symbols)
5179 (total_free_floats, total_floats, total_free_intervals)
5180 (total_intervals, total_strings, total_free_strings):
5181 Now EMACS_INT, not int. All uses changed.
5182 (Fgarbage_collect): Compute overall total using a double, so that
5183 integer overflow is less likely to be a problem. Check for overflow
5184 when converting back to an integer.
5185 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5186 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5187 These were 'int' variables that could overflow on 64-bit hosts;
5188 they were never used, so remove them instead of repairing them.
5189 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5190 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5191 Previously, this ceilinged at INT_MAX, but that doesn't work on
5192 64-bit machines.
5193 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5194
5195 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5196 (allocate_vectorlike): Check for ptrdiff_t overflow.
5197 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5198 when a (possibly-narrower) signed value would do just as well.
5199 We prefer using signed arithmetic, to avoid comparison confusion.
5200
5201 * alloc.c: Catch some string size overflows that we were missing.
5202 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5203 for convenience in STRING_BYTES_MAX.
5204 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5205 The definition here is exact; the one in lisp.h was approximate.
5206 (allocate_string_data): Check for string overflow. This catches
5207 some instances we weren't catching before. Also, it catches
5208 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5209 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5210 and ptrdiff_t and EMACS_INT are both 64 bits.
5211
5212 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5213 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5214 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5215
5216 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5217
5218 * alloc.c (Fmake_string): Check for out-of-range init.
5219
5220 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5221
5222 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5223
5224 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5225
5226 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5227 xg_get_default_scrollbar_width.
5228
5229 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5230 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5231 (style_changed_cb): Call update_theme_scrollbar_width and call
5232 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5233 all frames (Bug#8505).
5234 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5235 Call gtk_window_set_resizable if HAVE_GTK3.
5236 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5237 and height if HAVE_GTK3 (Bug#8505).
5238 (scroll_bar_width_for_theme): New variable.
5239 (update_theme_scrollbar_width): New function.
5240 (xg_get_default_scrollbar_width): Move code to
5241 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5242 (xg_initialize): Call update_theme_scrollbar_width.
5243
5244 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5245
5246 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5247
5248 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5249
5250 * frame.c (make_frame): Call other_buffer_safely instead of
5251 other_buffer.
5252
5253 * window.c (temp_output_buffer_show): Call display_buffer with
5254 second argument Vtemp_buffer_show_specifiers and reset latter
5255 immediately after the call.
5256 (Vtemp_buffer_show_specifiers): New variable.
5257 (auto_window_vscroll_p, next_screen_context_lines)
5258 (Vscroll_preserve_screen_position): Remove leading asterisks from
5259 doc-strings.
5260
5261 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5262
5263 Fix minor problems found by GCC 4.6.0 static checking.
5264 * buffer.c (Qclone_number): Remove for now, as it's unused.
5265 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5266 (record_buffer): Remove unused local.
5267 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5268 (set_frame_buffer_list): Remove; unused.
5269 * frame.h (other_visible_frames): Remove decl.
5270 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5271 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5272 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5273 if HAVE_GPM.
5274 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5275 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5276 Define only if HAVE_GPM.
5277 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5278 (update_hints_inhibit): Remove; never set. All uses removed.
5279 * widgetprv.h (emacsFrameClassRec): Remove decl.
5280 * window.c (delete_deletable_window): Now returns void, since it
5281 wasn't returning anything.
5282 (compare_window_configurations): Remove unused locals.
5283 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5284 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5285 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5286 the same widths as pointers. This follows up on the 2011-05-06 patch.
5287 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5288 * xterm.h: Likewise.
5289 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5290
5291 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5292
5293 * makefile.w32-in: Update dependencies.
5294 (LISP_H): Add lib/intprops.h.
5295
5296 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5297
5298 * image.c (gif_load): Add animation frame delay to the metadata.
5299 (syms_of_image): Use DEFSYM. New symbol `delay'.
5300
5301 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5302
5303 * window.c (delete_deletable_window): Re-add.
5304 (Fset_window_configuration): Rewrite to handle dead buffers and
5305 consequently deletable windows.
5306 (window_tree, Fwindow_tree): Remove. Supply functionality in
5307 window.el.
5308 (compare_window_configurations): Simplify code.
5309
5310 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5311
5312 * image.c (imagemagick_load_image): Fix type mismatch.
5313 (Fimagemagick_types): Likewise.
5314
5315 * window.h (replace_buffer_in_windows): Declare.
5316
5317 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5318
5319 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5320 Qclone_number. Remove external declaration of Qdelete_window.
5321 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5322 code.
5323 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5324 Run Qbuffer_list_update_hook if allowed.
5325 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5326 buffer list implementation.
5327 (other_buffer_safely): New function.
5328 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5329 calls to replace_buffer_in_windows and
5330 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5331 if allowed.
5332 (record_buffer): Inhibit quitting and rewrite using quittable
5333 functions. Run Qbuffer_list_update_hook if allowed.
5334 (Frecord_buffer, Funrecord_buffer): New functions.
5335 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5336 Move switch-to-buffer to window.el.
5337 (bury-buffer): Move to window.el.
5338 (Vbuffer_list_update_hook): New variable.
5339
5340 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5341 section.
5342
5343 * window.h (resize_frame_windows): Move up in code.
5344 (Fwindow_frame): Remove EXFUN.
5345 (replace_buffer_in_all_windows): Remove prototype.
5346 (replace_buffer_in_windows_safely): Add prototype.
5347
5348 * window.c: Declare Qdelete_window static again. Move down
5349 declaration of select_count.
5350 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5351 (Fother_window): Move to window.el.
5352 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5353 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5354 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5355 window.el.
5356 (replace_buffer_in_windows): Implement by calling
5357 Qreplace_buffer_in_windows.
5358 (replace_buffer_in_all_windows): Remove with some functionality
5359 moved into replace_buffer_in_windows_safely.
5360 (replace_buffer_in_windows_safely): New function.
5361 (select_window_norecord, select_frame_norecord): Move in front
5362 of run_window_configuration_change_hook. Remove now obsolete
5363 declarations.
5364 (Fset_window_buffer): Rewrite doc-string.
5365 Call Qrecord_window_buffer.
5366 (keys_of_window): Move binding for other-window to window.el.
5367
5368 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5369
5370 * dispextern.h (struct image): Replace data member, whose int_val
5371 and ptr_val fields were not used by anything, with a single
5372 lisp_val object.
5373
5374 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5375 (gif_clear_image, gif_load, imagemagick_load_image)
5376 (gs_clear_image, gs_load): Callers changed.
5377
5378 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5379
5380 * buffer.h: Include <time.h>, for time_t.
5381 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5382
5383 Fix minor problems found by static checking.
5384
5385 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5386
5387 Make identifiers static if they are not used in other modules.
5388 * data.c (Qcompiled_function, Qframe, Qvector):
5389 * image.c (QimageMagick, Qsvg):
5390 * minibuf.c (Qmetadata):
5391 * window.c (resize_window_check, resize_root_window): Now static.
5392 * window.h (resize_window_check, resize_root_window): Remove decls.
5393
5394 * window.c (window_deletion_count, delete_deletable_window):
5395 Remove; unused.
5396 (window_body_lines): Now static.
5397 (Fdelete_other_windows_internal): Mark vars as initialized.
5398 Make sure 'resize_failed' is initialized.
5399 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5400 (resize_window_apply): Remove unused local.
5401 * window.h (delete_deletable_window): Remove decl.
5402
5403 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5404 (imagemagick_load_image): Fix pointer signedness problem by changing
5405 last arg from unsigned char * to char *. All uses changed.
5406 Also, fix a local for similar reasons.
5407 Remove unused locals. Remove locals to avoid shadowing.
5408 (fn_rsvg_handle_free): Remove; unused.
5409 (svg_load, svg_load_image): Fix pointer signedness problem.
5410 (imagemagick_load_image): Don't use garbage pointer image_wand.
5411
5412 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5413
5414 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5415
5416 * image.c (gif_load): Fix omitted cast error introduced by
5417 2011-06-06 change.
5418
5419 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5420
5421 * window.h (resize_proportionally, orig_total_lines)
5422 (orig_top_line): Remove from window structure.
5423 (set_window_height, set_window_width, change_window_heights)
5424 (Fdelete_window): Remove prototypes.
5425 (resize_frame_windows): Remove duplicate declaration.
5426
5427 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5428
5429 * window.h (resize_frame_windows, resize_window_check)
5430 (delete_deletable_window, resize_root_window)
5431 (resize_frame_windows): Declare prototypes.
5432
5433 * window.c (resize_window_apply): Make definition be "static" to
5434 match the prototype.
5435
5436 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5437
5438 * window.c: Remove declarations of Qwindow_size_fixed,
5439 window_min_size_1, window_min_size_2, window_min_size,
5440 size_window, window_fixed_size_p, enlarge_window, delete_window.
5441 Remove static from declaration of Qdelete_window, it's
5442 temporarily needed by Fbury_buffer.
5443 (replace_window): Don't assign orig_top_line and
5444 orig_total_lines.
5445 (Fdelete_window, delete_window): Remove. Window deletion is
5446 handled by window.el.
5447 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5448 Replace Fdelete_window calls with calls to Qdelete_window.
5449 (Fdelete_other_windows): Remove. Deleting other windows is
5450 handled by window.el.
5451 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5452 handled in window.el.
5453 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5454 Window minimum sizes are handled in window.el.
5455 (shrink_windows, size_window, set_window_height)
5456 (set_window_width, change_window_heights, window_height)
5457 (window_width, CURBEG, CURSIZE, enlarge_window)
5458 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5459 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5460 handled in window.el.
5461 (make_dummy_parent): Rename to make_parent_window and give it a
5462 second argument horflag.
5463 (make_window): Don't set resize_proportionally any more.
5464 (Fsplit_window): Remove. Windows are split in window.el.
5465 (save_restore_action, save_restore_orig_size)
5466 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5467 Resize mini windows in window.el.
5468 (grow_mini_window, shrink_mini_window): Implement by calling
5469 Qresize_root_window_vertically, resize_window_check and
5470 resize_window_apply.
5471 (saved_window, Fset_window_configuration, save_window_save):
5472 Do not handle orig_top_line, orig_total_lines, and
5473 resize_proportionally.
5474 (window_min_height, window_min_width): Move to window.el.
5475 (keys_of_window): Move bindings for delete-other-windows,
5476 split-window, delete-window and enlarge-window to window.el.
5477
5478 * buffer.c: Temporarily extern Qdelete_window.
5479 (Fbury_buffer): Temporarily call Qdelete_window instead of
5480 Fdelete_window (Fbury_buffer will move to window.el soon).
5481
5482 * frame.c (set_menu_bar_lines_1): Remove code handling
5483 orig_top_line and orig_total_lines.
5484
5485 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5486 set_window_height but set heights directly.
5487 (change_frame_size_1): Use resize_frame_windows.
5488
5489 * xdisp.c (init_xdisp): Don't use set_window_height but set
5490 heights directly.
5491
5492 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5493 Use resize_frame_windows instead of change_window_heights and run
5494 run_window_configuration_change_hook.
5495
5496 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5497 instead of change_window_heights and run
5498 run_window_configuration_change_hook.
5499
5500 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5501
5502 * window.c (replace_window): Rename second argument REPLACEMENT to
5503 NEW. New third argument SETFLAG. Rewrite.
5504 (delete_window, make_dummy_parent): Call replace_window with
5505 third argument 1.
5506 (window_list_1): Move down in code.
5507 (run_window_configuration_change_hook): Move set_buffer part
5508 before select_frame_norecord part in order to unwind correctly.
5509 Rename count1 to count.
5510 (recombine_windows, delete_deletable_window, resize_root_window)
5511 (Fdelete_other_windows_internal)
5512 (Frun_window_configuration_change_hook, make_parent_window)
5513 (resize_window_check, resize_window_apply, Fresize_window_apply)
5514 (resize_frame_windows, Fsplit_window_internal)
5515 (Fdelete_window_internal, Fresize_mini_window_internal):
5516 New functions.
5517 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5518
5519 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5520
5521 * window.h (window): Add some new members to window structure -
5522 normal_lines, normal_cols, new_total, new_normal, clone_number,
5523 splits, nest, prev_buffers, next_buffers.
5524 (WINDOW_TOTAL_SIZE): Move here from window.c.
5525 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5526
5527 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5528 Remove.
5529 (make_dummy_parent): Set new members of windows structure.
5530 (make_window): Move down in code. Handle new members of window
5531 structure.
5532 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5533 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5534 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5535 (Fset_window_prev_buffers, Fwindow_next_buffers)
5536 (Fset_window_next_buffers, Fset_window_clone_number):
5537 New functions.
5538 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5539 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5540 Doc-string fixes.
5541 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5542 Argument WINDOW can be now internal window too.
5543 (Fwindow_use_time): Move up in code.
5544 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5545 Rewrite doc-string.
5546 (Fset_window_configuration, saved_window)
5547 (Fcurrent_window_configuration, save_window_save): Handle new
5548 members of window structure.
5549 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5550 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5551 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5552 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5553 Qget_mru_window, Qresize_root_window,
5554 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5555 Qauto_buffer_name; staticpro them.
5556
5557 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5558
5559 * window.c (Fwindow_total_size, Fwindow_left_column)
5560 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5561 (Fwindow_list_1): New functions.
5562 (window_box_text_cols): Replace with window_body_cols.
5563 (Fwindow_width, Fscroll_left, Fscroll_right):
5564 Use window_body_cols instead of window_box_text_cols.
5565 (delete_window, Fset_window_configuration):
5566 Call delete_all_subwindows with window as argument.
5567 (delete_all_subwindows): Take a window as argument and not a
5568 structure. Rewrite.
5569 (window_loop): Remove handling of GET_LRU_WINDOW and
5570 GET_LARGEST_WINDOW.
5571 (Fget_lru_window, Fget_largest_window): Move to window.el.
5572
5573 * window.h: Extern window_body_cols instead of
5574 window_box_text_cols. delete_all_subwindows now takes a
5575 Lisp_Object as argument.
5576
5577 * indent.c (compute_motion, Fcompute_motion):
5578 Use window_body_cols instead of window_box_text_cols.
5579
5580 * frame.c (delete_frame): Call delete_all_subwindows with root
5581 window as argument.
5582
5583 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5584
5585 * fns.c (Fputhash): Document return value.
5586
5587 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5588
5589 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5590
5591 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5592
5593 Cons<->int and similar integer overflow fixes (Bug#8794).
5594
5595 Check for overflow when converting integer to cons and back.
5596 * charset.c (Fdefine_charset_internal, Fdecode_char):
5597 Use cons_to_unsigned to catch overflow.
5598 (Fencode_char): Use INTEGER_TO_CONS.
5599 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5600 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5601 * data.c (long_to_cons, cons_to_long): Remove.
5602 (cons_to_unsigned, cons_to_signed): New functions.
5603 These signal an error for invalid or out-of-range values.
5604 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5605 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5606 * font.c (Ffont_variation_glyphs):
5607 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5608 * lisp.h: Include <intprops.h>.
5609 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5610 (cons_to_signed, cons_to_unsigned): New decls.
5611 (long_to_cons, cons_to_long): Remove decls.
5612 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5613 (Fprimitive_undo): Use CONS_TO_INTEGER.
5614 * xfns.c (Fx_window_property): Likewise.
5615 * xselect.c: Include <limits.h>.
5616 (x_own_selection, selection_data_to_lisp_data):
5617 Use INTEGER_TO_CONS.
5618 (x_handle_selection_request, x_handle_selection_clear)
5619 (x_get_foreign_selection, Fx_disown_selection_internal)
5620 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5621 (lisp_data_to_selection_data): Use cons_to_unsigned.
5622 (x_fill_property_data): Use cons_to_signed.
5623 Report values out of range.
5624
5625 Check for buffer and string overflow more precisely.
5626 * buffer.h (BUF_BYTES_MAX): New macro.
5627 * lisp.h (STRING_BYTES_MAX): New macro.
5628 * alloc.c (Fmake_string):
5629 * character.c (string_escape_byte8):
5630 * coding.c (coding_alloc_by_realloc):
5631 * doprnt.c (doprnt):
5632 * editfns.c (Fformat):
5633 * eval.c (verror):
5634 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5635 since they may not be the same number.
5636 * editfns.c (Finsert_char):
5637 * fileio.c (Finsert_file_contents):
5638 Likewise for BUF_BYTES_MAX.
5639
5640 * image.c: Use ptrdiff_t, not int, for sizes.
5641 (slurp_file): Switch from int to ptrdiff_t.
5642 All uses changed.
5643 (slurp_file): Check that file size fits in both size_t (for
5644 malloc) and ptrdiff_t (for sanity and safety).
5645
5646 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5647 if b->modtime has its maximal value.
5648
5649 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5650
5651 Don't assume time_t can fit into int.
5652 * buffer.h (struct buffer.modtime): Now time_t, not int.
5653 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5654 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5655
5656 Minor fixes for signed vs unsigned integers.
5657 * character.h (MAYBE_UNIFY_CHAR):
5658 * charset.c (maybe_unify_char):
5659 * keyboard.c (read_char, reorder_modifiers):
5660 XINT -> XFASTINT, since the integer must be nonnegative.
5661 * ftfont.c (ftfont_spec_pattern):
5662 * keymap.c (access_keymap, silly_event_symbol_error):
5663 XUINT -> XFASTINT, since the integer must be nonnegative.
5664 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5665 since it makes no difference and we prefer signed.
5666 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5667 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5668 nonnegative.
5669
5670 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5671
5672 * window.h (Fwindow_frame): Declare.
5673
5674 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5675
5676 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5677 (SPARE_MEMORY): Always define.
5678 (LARGE_REQUEST): Remove.
5679 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5680
5681 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5682
5683 * lisp.h: Move EXFUNS for Fframe_root_window,
5684 Fframe_first_window and Fset_frame_selected_window to window.h.
5685
5686 * window.h: Move EXFUNS for Fframe_root_window,
5687 Fframe_first_window and Fset_frame_selected_window here from
5688 lisp.h.
5689
5690 * frame.c (Fwindow_frame, Fframe_first_window)
5691 (Fframe_root_window, Fframe_selected_window)
5692 (Fset_frame_selected_window): Move to window.c.
5693 (Factive_minibuffer_window): Move to minibuf.c.
5694 (Fother_visible_frames_p): New function.
5695
5696 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5697
5698 * window.c (decode_window, decode_any_window): Move up in code.
5699 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5700 (inhibit_frame_unsplittable): Remove unused variable.
5701 (Fwindow_buffer): Move up and rewrite doc-string.
5702 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5703 (Fwindow_prev): New functions.
5704 (Fwindow_frame): Move here from frame.c. Accept any window as
5705 argument.
5706 (Fframe_root_window, Fframe_first_window)
5707 (Fframe_selected_window): Move here from frame.c. Accept frame
5708 or arbitrary window as argument. Update doc-strings.
5709 (Fminibuffer_window): Move up in code.
5710 (Fwindow_minibuffer_p): Move up in code and simplify.
5711 (Fset_frame_selected_window): Move here from frame.c.
5712 Marginal rewrite.
5713 (Fselected_window, select_window, Fselect_window): Move up in
5714 code. Minor doc-string fixes.
5715
5716 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5717
5718 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5719 Do not assume that spare memory exists; that assumption is valid
5720 only if SYSTEM_MALLOC.
5721 (LARGE_REQUEST): New macro, so that the issue of large requests
5722 is separated from the issue of spare memory.
5723
5724 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5725
5726 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5727 format. (Bug#8806)
5728
5729 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5730
5731 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5732 before statements.
5733
5734 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5735
5736 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5737
5738 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5739
5740 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5741 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5742
5743 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5744
5745 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5746
5747 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5748
5749 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5750 (x_clipboard_manager_save): Add return value.
5751 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5752 New error handlers.
5753 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5754 Obey Vx_select_enable_clipboard_manager. Catch errors in
5755 x_clipboard_manager_save (Bug#8779).
5756 (Vx_select_enable_clipboard_manager): New variable.
5757 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5758
5759 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5760
5761 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5762
5763 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5764
5765 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5766 in the current matrix if keep_current_p is non-zero.
5767
5768 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5769
5770 * bidi.c (bidi_level_of_next_char): Fix last change.
5771
5772 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5773
5774 Support bidi reordering of text covered by display properties.
5775
5776 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5777 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5778 (bidi_cache_search, bidi_cache_iterator_state)
5779 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5780 (bidi_level_of_next_char, bidi_move_to_visually_next):
5781 Support character positions inside a run of characters covered by a
5782 display string.
5783 (bidi_paragraph_init, bidi_resolve_explicit_1)
5784 (bidi_level_of_next_char): Call bidi_fetch_char and
5785 bidi_fetch_char_advance instead of FETCH_CHAR and
5786 FETCH_CHAR_ADVANCE.
5787 (bidi_init_it): Initialize new members.
5788 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5789 definitions.
5790 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5791 instead of using explicit *_CHAR codes.
5792 (bidi_resolve_explicit, bidi_resolve_weak):
5793 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5794 bidirectional text is supported only in multibyte buffers.
5795 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5796 it to initialize the frame_window_p member of struct bidi_it.
5797 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5798 (bidi_resolve_explicit, bidi_resolve_weak)
5799 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5800 bidi_it->nchars is non-positive.
5801 (bidi_level_of_next_char): Don't try to lookup the cache for the
5802 next/previous character if nothing is cached there yet, or if we
5803 were just reseat()'ed to a new position.
5804
5805 * xdisp.c (set_cursor_from_row): Set start and stop points
5806 according to the row's direction when priming the loop that looks
5807 for the glyph on which to display cursor.
5808 (single_display_spec_intangible_p): Function deleted.
5809 (display_prop_intangible_p): Reimplement to call
5810 handle_display_spec instead of single_display_spec_intangible_p.
5811 Accept 3 additional arguments needed by handle_display_spec.
5812 This fixes incorrect cursor motion across display property with complex
5813 values: lists, `(when COND...)' forms, etc.
5814 (single_display_spec_string_p): Support property values that are
5815 lists with the argument STRING its top-level element.
5816 (display_prop_string_p): Fix the condition for processing a
5817 property that is a list to be consistent with handle_display_spec.
5818 (handle_display_spec): New function, refactored from the
5819 last portion of handle_display_prop.
5820 (compute_display_string_pos): Accept additional argument
5821 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5822 value of a `display' property is a "replacing spec".
5823 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5824 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5825 the display property, but just return a value indicating whether
5826 the display property will replace the characters it covers.
5827 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5828 frame_window_p members of struct bidi_it.
5829 (compute_display_string_pos, compute_display_string_end):
5830 New functions.
5831 (push_it): Accept second argument POSITION, where pop_it should
5832 jump to continue iteration.
5833 (reseat_1): Initialize bidi_it.disp_pos.
5834
5835 * keyboard.c (adjust_point_for_property): Adjust the call to
5836 display_prop_intangible_p to its new signature.
5837
5838 * dispextern.h (struct bidi_it): New member frame_window_p.
5839 (bidi_init_it): Update prototypes.
5840 (display_prop_intangible_p): Update prototype.
5841 (compute_display_string_pos, compute_display_string_end):
5842 Declare prototypes.
5843 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5844 EMACS_INT.
5845
5846 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5847
5848 Malloc failure behavior now depends on size of allocation.
5849 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5850 * lisp.h: Change signatures accordingly.
5851 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5852 All callers changed. (Bug#8762)
5853
5854 * gnutls.c: Use Emacs's memory allocators.
5855 Without this change, the gnutls library would invoke malloc etc.
5856 directly, which causes problems on non-SYNC_INPUT hosts, and which
5857 runs afoul of improving memory_full behavior. (Bug#8761)
5858 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5859 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5860 xfree instead of the default malloc, realloc, free.
5861 (Fgnutls_boot): No need to check for memory allocation failure,
5862 since xmalloc does that for us.
5863
5864 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5865 * category.c (hash_get_category_set):
5866 * ccl.c (ccl_driver):
5867 * charset.c (Fdefine_charset_internal):
5868 * charset.h (struct charset.hash_index):
5869 * composite.c (get_composition_id, gstring_lookup_cache)
5870 (composition_gstring_put_cache):
5871 * composite.h (struct composition.hash_index):
5872 * dispextern.h (struct image.hash):
5873 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5874 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5875 (hashfn_equal, hashfn_user_defined, make_hash_table)
5876 (maybe_resize_hash_table, hash_lookup, hash_put)
5877 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5878 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5879 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5880 * image.c (make_image, search_image_cache, lookup_image)
5881 (xpm_put_color_table_h):
5882 * lisp.h (struct Lisp_Hash_Table):
5883 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5884 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5885 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5886 * alloc.c (allocate_vectorlike):
5887 Check for overflow in vector size calculations.
5888 * ccl.c (ccl_driver):
5889 Check for overflow when converting EMACS_INT to int.
5890 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5891 need to be updated by these changes.
5892 * fns.c (make_hash_table, maybe_resize_hash_table):
5893 Check for integer overflow with large hash tables.
5894 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5895 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5896 (SXHASH_REDUCE): New macro.
5897 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5898 Use it instead of discarding useful hash info with large hash values.
5899 (sxhash_float): New function.
5900 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5901 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5902 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5903 Rewrite to use FIXNUM_BITS, as this simplifies things.
5904 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5905 Adjust signatures to match updated version of code.
5906 (consing_since_gc): Now EMACS_INT, since a single hash table can
5907 use more than INT_MAX bytes.
5908
5909 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5910
5911 Make it possible to build with GCC-4.6+ -O2 -flto.
5912
5913 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5914
5915 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5916
5917 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5918 Call minibuffer-inactive-mode.
5919
5920 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5921
5922 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5923 Update dependencies.
5924
5925 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5926
5927 * data.c (init_data): Remove code for UTS, this system is not
5928 supported anymore.
5929
5930 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5931
5932 Don't force ./temacs to start in terminal mode.
5933
5934 * frame.c (make_initial_frame): Initialize faces in all cases, not
5935 only when CANNOT_DUMP is defined.
5936 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5937
5938 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5939
5940 * dispnew.c (add_window_display_history): Use const for the string
5941 pointer. Remove declaration, not needed.
5942
5943 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5944
5945 Use 'inline', not 'INLINE'.
5946 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5947 * alloc.c, fontset.c (INLINE): Remove.
5948 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5949 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5950 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5951 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5952 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5953
5954 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5955
5956 Make it possible to run ./temacs.
5957
5958 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5959 syms_of_callproc does the same thing. Remove test for
5960 "initialized", do it in the caller.
5961 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5962
5963 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5964
5965 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5966 (read_minibuf): Use get_minibuffer.
5967 (syms_of_minibuf): Use DEFSYM.
5968 (Qmetadata): New var.
5969 * data.c (Qbuffer): Don't make it static.
5970 (syms_of_data): Use DEFSYM.
5971
5972 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5973
5974 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5975 (CCL_CODE_MIN): New macro.
5976
5977 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5978
5979 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5980
5981 * eval.c (Qdebug): Now static.
5982 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5983 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5984 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5985
5986 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5987
5988 * image.c: Various fixes to ImageMagick code comments.
5989 (Fimagemagick_types): Doc fix.
5990
5991 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5992
5993 Minor fixes prompted by GCC 4.6.0 warnings.
5994
5995 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5996
5997 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5998 (x_clipboard_manager_save_all): Move extern decl to ...
5999 * xterm.h: ... here, so that it can be checked for consistency.
6000
6001 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6002
6003 * xselect.c (x_clipboard_manager_save_frame)
6004 (x_clipboard_manager_save_all): New functions.
6005 (Fx_clipboard_manager_save): Lisp function deleted.
6006
6007 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6008 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6009
6010 * xterm.h: Update prototype.
6011
6012 2011-05-28 William Xu <william.xwl@gmail.com>
6013
6014 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6015 exiting (Bug#8239).
6016
6017 2011-05-28 Jim Meyering <meyering@redhat.com>
6018
6019 Avoid a sign-extension bug in crypto_hash_function.
6020 * fns.c (to_uchar): Define.
6021 (crypto_hash_function): Use it to convert some newly-signed
6022 variables to unsigned, to avoid sign-extension bugs. For example,
6023 without this change, (md5 "truc") would evaluate to
6024 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6025 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6026 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6027
6028 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6029
6030 Integer overflow fixes.
6031
6032 * dbusbind.c: Serial number integer overflow fixes.
6033 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6034 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6035 to hold a serial number that is too large for a fixnum.
6036 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6037 Check for serial numbers out of range. Decode any serial number
6038 that was so large that it became a float. (Bug#8722)
6039
6040 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6041 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6042 Use XFASTINT rather than XUINT when numbers are nonnegative.
6043 (xd_append_arg, Fdbus_method_return_internal):
6044 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6045 arguments, check that Lisp number is nonnegative, rather than
6046 silently wrapping negative numbers around. (Bug#8722)
6047 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6048 (Bug#8722)
6049
6050 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6051
6052 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6053
6054 ccl: Add integer overflow checks.
6055 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6056 (IN_INT_RANGE): New macros.
6057 (ccl_driver): Use them to check for integer overflow when
6058 decoding a CCL program. Many of the new checks are whether XINT (x)
6059 fits in int; it doesn't always, on 64-bit hosts. The new version
6060 doesn't catch all possible integer overflows, but it's an
6061 improvement. (Bug#8719)
6062
6063 * alloc.c (make_event_array): Use XINT, not XUINT.
6064 There's no need for unsigned here.
6065
6066 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6067 This follows up to the 2011-05-06 change that substituted uintptr_t
6068 for EMACS_INT. This case wasn't caught back then.
6069
6070 Rework Fformat to avoid integer overflow issues.
6071 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6072 now (part of C89). Include <verify.h>.
6073 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6074 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6075 (Fformat): Avoid the prepass trying to compute sizes; it was only
6076 approximate and thus did not catch overflow reliably. Instead, walk
6077 through the format just once, formatting and computing sizes as we go,
6078 checking for integer overflow at every step, and allocating a larger
6079 buffer as needed. Keep track separately whether the format is
6080 multibyte. Keep only the most-recently calculated precision, rather
6081 than them all. Record whether each argument has been converted to
6082 string. Use EMACS_INT, not int, for byte and char and arg counts.
6083 Support field widths and precisions larger than INT_MAX. Avoid
6084 sprintf's undefined behavior with conversion specifications such as %#d
6085 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6086 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6087 formatting out-of-range floating point numbers with int
6088 formats. (Bug#8668)
6089
6090 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6091
6092 * data.c: Avoid integer truncation in expressions involving floats.
6093 * data.c: Include <intprops.h>.
6094 (arith_driver): When there's an integer overflow in an expression
6095 involving floating point, convert the integers to floating point
6096 so that the resulting value does not suffer from catastrophic
6097 integer truncation. For example, on a 64-bit host (* 4
6098 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6099 Do not rely on undefined behavior after integer overflow.
6100
6101 merge count_size_as_multibyte, parse_str_to_multibyte
6102 * character.c, character.h (count_size_as_multibyte):
6103 Rename from parse_str_to_multibyte; all uses changed.
6104 Check for integer overflow.
6105 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6106 since it's now a duplicate of the other. This is more of
6107 a character than a buffer op, so better that it's in character.c.
6108 * fns.c, print.c: Adjust to above changes.
6109
6110 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6111
6112 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6113
6114 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6115
6116 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6117 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6118 (x_clipboard_manager_save): Now static.
6119 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6120
6121 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6122 (crypto_hash_function): Now static.
6123 Fix pointer signedness problems. Avoid unnecessary initializations.
6124
6125 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6126
6127 * termhooks.h (Vselection_alist): Make it terminal-local.
6128
6129 * terminal.c (create_terminal): Initialize it.
6130
6131 * xselect.c: Support for clipboard managers.
6132 (Vselection_alist): Move to termhooks.h as terminal-local var.
6133 (LOCAL_SELECTION): New macro.
6134 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6135 (symbol_to_x_atom): Remove gratuitous arg.
6136 (x_handle_selection_request, lisp_data_to_selection_data)
6137 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6138 (x_own_selection, x_get_local_selection, x_convert_selection):
6139 New arg, specifying work frame. Use terminal-local Vselection_alist.
6140 (some_frame_on_display): Delete unused function.
6141 (Fx_own_selection_internal, Fx_get_selection_internal)
6142 (Fx_disown_selection_internal, Fx_selection_owner_p)
6143 (Fx_selection_exists_p): New optional frame arg.
6144 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6145 (x_handle_selection_clear): Don't treat other terminals with the
6146 same keyboard specially. Use the terminal-local Vselection_alist.
6147 (x_clear_frame_selections): Use Frun_hook_with_args.
6148
6149 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6150
6151 * xterm.h: Add support for those atoms.
6152
6153 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6154
6155 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6156 (converted_selections, conversion_fail_tag): New global variables.
6157 (x_selection_request_lisp_error): Free the above.
6158 (x_get_local_selection): Remove unnecessary code.
6159 (x_reply_selection_request): Args changed; handle arbitrary array
6160 of converted selections stored in converted_selections.
6161 Separate the XChangeProperty and SelectionNotify steps.
6162 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6163 (x_convert_selection): New function.
6164 (x_handle_selection_event): Simplify.
6165 (x_get_foreign_selection): Don't ignore incoming requests while
6166 waiting for an answer; this will fail when we implement
6167 SAVE_TARGETS, and seems unnecessary anyway.
6168 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6169 (Vx_sent_selection_functions): Doc fix.
6170
6171 2011-05-26 Leo Liu <sdl.web@gmail.com>
6172
6173 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6174
6175 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6176
6177 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6178
6179 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6180 for fringe update if it has periodic bitmap.
6181 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6182 and fringe_bitmap_periodic_p.
6183
6184 * fringe.c (get_fringe_bitmap_data): New function.
6185 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6186 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6187 row. Mark glyph row for fringe update if periodicity changed.
6188
6189 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6190 for fringe update unless it has periodic bitmap.
6191
6192 2011-05-25 Kenichi Handa <handa@m17n.org>
6193
6194 * xdisp.c (get_next_display_element): Set correct it->face_id for
6195 a static composition.
6196
6197 2011-05-24 Leo Liu <sdl.web@gmail.com>
6198
6199 * deps.mk (fns.o):
6200 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6201
6202 * fns.c (crypto_hash_function, Fsha1): New function.
6203 (Fmd5): Use crypto_hash_function.
6204 (syms_of_fns): Add Ssha1.
6205
6206 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6207
6208 * gnutls.c: Remove unused macros.
6209 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6210 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6211 Remove macros that are defined and never used.
6212 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6213
6214 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6215
6216 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6217 (Fx_get_selection_internal): Minor cleanup.
6218 (Fx_own_selection_internal): Rename arguments for consistency with
6219 select.el.
6220
6221 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6222
6223 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6224
6225 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6226
6227 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6228
6229 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6230
6231 * dispnew.c (scrolling_window): Don't exclude the case that the
6232 last enabled row in the desired matrix touches the bottom boundary.
6233
6234 2011-05-21 Glenn Morris <rgm@gnu.org>
6235
6236 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6237 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6238 and add some more files.
6239
6240 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6241
6242 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6243 report_file_error introduced by the change from 2011-05-07.
6244
6245 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6246
6247 * systime.h (Time): Define only if emacs is defined.
6248 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6249 where the include path doesn't have X11/X.h by default. See
6250 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6251
6252 2011-05-20 Kenichi Handa <handa@m17n.org>
6253
6254 * composite.c (find_automatic_composition): Fix previous change.
6255
6256 2011-05-20 Glenn Morris <rgm@gnu.org>
6257
6258 * lisp.mk: New file, split from Makefile.in.
6259 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6260 (shortlisp): Remove.
6261 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6262
6263 2011-05-19 Glenn Morris <rgm@gnu.org>
6264
6265 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6266 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6267 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6268 (lisp): Set the order to that of loadup.el.
6269 (shortlisp): Make it a copy of $lisp.
6270 (SOME_MACHINE_LISP): Remove.
6271 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6272 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6273
6274 2011-05-18 Kenichi Handa <handa@m17n.org>
6275
6276 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6277 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6278 (find_automatic_composition): Mostly rewrite for efficiency.
6279
6280 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6281
6282 * makefile.w32-in: Update dependencies.
6283
6284 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6285
6286 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6287 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6288
6289 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6290
6291 Fix some integer overflow issues, such as string length overflow.
6292
6293 * insdel.c (count_size_as_multibyte): Check for string overflow.
6294
6295 * character.c (lisp_string_width): Check for string overflow.
6296 Use EMACS_INT, not int, for string indexes and lengths; in
6297 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6298 the resulting string length overflows an EMACS_INT; instead,
6299 report a string overflow if no precision given. When checking for
6300 precision exhaustion, use a check that cannot possibly have
6301 integer overflow. (Bug#8675)
6302 * character.h (lisp_string_width): Adjust to new signature.
6303
6304 * alloc.c (string_overflow): New function.
6305 (Fmake_string): Use it. This doesn't change behavior, but saves
6306 a few bytes and will simplify future changes.
6307 * character.c (string_escape_byte8): Likewise.
6308 * lisp.h (string_overflow): New decl.
6309
6310 Fixups, following up to the user-interface timestamp change.
6311 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6312 for UI timestamps, instead of unsigned long.
6313 * msdos.c (mouse_get_pos): Likewise.
6314 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6315 * w32gui.h (Time): Define by including "systime.h" rather than by
6316 declaring it ourselves. (Bug#8664)
6317
6318 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6319 * image.c (clear_image_cache): Likewise.
6320
6321 * term.c (term_mouse_position): Don't assume time_t wraparound.
6322
6323 Be more systematic about user-interface timestamps.
6324 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6325 and sometimes 'EMACS_UINT', to represent these timestamps.
6326 This change causes it to use 'Time' uniformly, as that's what X uses.
6327 This makes the code easier to follow, and makes it easier to catch
6328 integer overflow bugs such as Bug#8664.
6329 * frame.c (Fmouse_position, Fmouse_pixel_position):
6330 Use Time, not unsigned long, for user-interface timestamps.
6331 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6332 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6333 * keyboard.h (last_event_timestamp): Likewise.
6334 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6335 * menu.h (xmenu_show): Likewise.
6336 * term.c (term_mouse_position): Likewise.
6337 * termhooks.h (struct input_event.timestamp): Likewise.
6338 (struct terminal.mouse_position_hook): Likewise.
6339 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6340 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6341 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6342 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6343 what it was before.
6344 * menu.h, termhooks.h: Include "systime.h", for Time.
6345
6346 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6347 Don't assume that the difference between two unsigned long values
6348 can fit into an integer. At this point, we know button_down_time
6349 <= event->timestamp, so the difference must be nonnegative, so
6350 there's no need to cast the result if double-click-time is
6351 nonnegative, as it should be; check that it's nonnegative, just in
6352 case. This bug is triggered when events are more than 2**31 ms
6353 apart (about 25 days). (Bug#8664)
6354
6355 * xselect.c (last_event_timestamp): Remove duplicate decl.
6356 (x_own_selection): Remove needless cast to unsigned long.
6357
6358 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6359 that always fit in int. Use a sentinel instead of a counter, to
6360 avoid a temp and to allay GCC's concerns about possible int overflow.
6361 * frame.h (struct frame): Use int for menu_bar_items_used
6362 instead of EMACS_INT, since it always fits in int.
6363
6364 * menu.c (grow_menu_items): Check for int overflow.
6365
6366 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6367
6368 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6369 Before, the code was not consistent. These values cannot exceed
6370 2**31 - 1 so there's no need to make them unsigned.
6371 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6372 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6373 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6374 as modifiers.
6375 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6376
6377 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6378 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6379 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6380 presumably because the widths might not match.
6381
6382 * window.c (size_window): Avoid needless test at loop start.
6383
6384 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6385
6386 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6387
6388 2011-05-12 Drew Adams <drew.adams@oracle.com>
6389
6390 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6391
6392 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6393
6394 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6395 `width' to `bar_area_x' and `bar_area_width', respectively.
6396 (x_scroll_run): Take account of fringe background extension.
6397
6398 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6399 Rename local vars `left' and `width' to `bar_area_x' and
6400 `bar_area_width', respectively.
6401 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6402 background extension.
6403
6404 2011-05-10 Jim Meyering <meyering@redhat.com>
6405
6406 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6407
6408 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6409
6410 * image.c (Finit_image_library): Return t for built-in image types,
6411 like pbm and xbm. (Bug#8640)
6412
6413 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6414
6415 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6416
6417 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6418
6419 * w32console.c (Fset_screen_color): Doc fix.
6420 (Fget_screen_color): New function.
6421 (syms_of_ntterm): Defsubr it.
6422
6423 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6424 unlink the temporary file if Fcall_process didn't create it in the
6425 first place.
6426 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6427 child process will be redirected to a file specified with `:file'.
6428 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6429 cue to call_process_cleanup not to close that handle.
6430
6431 2011-05-07 Ben Key <bkey76@gmail.com>
6432
6433 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6434 one of two shell specific rules, either bootstrap-temacs-CMD or
6435 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6436 to the previous implementation of the bootstrap-temacs rule.
6437 The bootstrap-temacs-CMD rule is similar to the previous
6438 implementation of the bootstrap-temacs rule except that it
6439 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6440 variable.
6441
6442 These changes, along with some changes to nt/configure.bat,
6443 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6444 earlier fix to add support for --cflags and --ldflags options
6445 that include quotes so that it works whether make uses cmd or
6446 sh as the shell.
6447
6448 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6449
6450 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6451 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6452 is a constant.
6453 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6454 a string. Handle both cases.
6455 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6456 (Fdbus_register_method): Use Qinvalid_function.
6457
6458 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6459
6460 * makefile.w32-in: Update dependencies.
6461 (LISP_H): Add inttypes.h and stdin.h.
6462 (PROCESS_H): Add unistd.h.
6463
6464 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6465
6466 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6467 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6468
6469 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6470
6471 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6472
6473 * term.c (vfatal): Remove stray call to va_end.
6474 It's not needed and the C Standard doesn't allow it here anyway.
6475
6476 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6477 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6478
6479 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6480 bytes.
6481
6482 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6483
6484 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6485
6486 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6487
6488 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6489
6490 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6491
6492 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6493 * charset.c (Fdefine_charset_internal): Don't initialize
6494 charset.code_space[15]. The value was garbage, on hosts with
6495 32-bit int (Bug#8600).
6496
6497 * lread.c (read_integer): Be more consistent with string-to-number.
6498 Use string_to_number to do the actual conversion; this avoids
6499 rounding errors and fixes some other screwups. Without this fix,
6500 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6501 (digit_to_number): Move earlier, for benefit of read_integer.
6502 Return -1 if the digit is out of range for the base, -2 if it is
6503 not a digit in any supported base. (Bug#8602)
6504
6505 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6506
6507 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6508 to match comment at start of function. This also removes a
6509 GCC warning about overflow in a 32+64-bit port.
6510
6511 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6512
6513 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6514 Reported by Stefan Monnier in
6515 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6516 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6517 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6518
6519 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6520 (EMACS_UINTPTR): Likewise, with uintptr_t.
6521
6522 * lisp.h: Prefer 64-bit EMACS_INT if available.
6523 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6524 on 32-bit hosts that have 64-bit int, so that they can access
6525 large files.
6526 However, temporarily disable this change unless the temporary
6527 symbol WIDE_EMACS_INT is defined.
6528
6529 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6530
6531 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6532 This removes an assumption that EMACS_INT and long are the same
6533 width as pointers. The assumption is true for Emacs porting targets
6534 now, but we want to make other targets possible.
6535 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6536 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6537 In the rest of the code, change types of integers that hold casted
6538 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6539 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6540 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6541 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6542 No need to cast type when ORing.
6543 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6544 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6545 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6546 assume EMACS_INT is the same width as char *.
6547 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6548 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6549 Remove no-longer-needed casts.
6550 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6551 (xg_tool_bar_help_callback, xg_make_tool_item):
6552 Use EMACS_INTPTR to hold an integer
6553 that will be cast to void *; this can avoid a GCC warning
6554 if EMACS_INT is not the same width as void *.
6555 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6556 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6557 (current_message_1, set_message_1):
6558 Use a local to convert to proper width without a cast.
6559 * xmenu.c (dialog_selection_callback): Likewise.
6560
6561 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6562 Also, don't assume VALBITS / RAND_BITS is less than 5,
6563 and don't rely on undefined behavior when shifting a 1 left into
6564 the sign bit.
6565 * lisp.h (get_random): Change signature to match.
6566
6567 * lread.c (hash_string): Use size_t, not int, for hash computation.
6568 Normally we prefer signed values; but hashing is special, because
6569 it's better to use unsigned division on hash table sizes so that
6570 the remainder is nonnegative. Also, size_t is the natural width
6571 for hashing into memory. The previous code used 'int', which doesn't
6572 retain enough info to hash well into very large tables.
6573 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6574
6575 * dbusbind.c: Don't possibly lose pointer info when converting.
6576 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6577 Use XPNTR rather than XHASH, so that the high-order bits of
6578 the pointer aren't lost when converting through void *.
6579
6580 * eval.c (Fautoload): Don't double-shift a pointer.
6581
6582 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6583
6584 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6585
6586 * gnutls.c (DEF_GNUTLS_FN):
6587 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6588
6589 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6590
6591 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6592 marker. (Bug#8610)
6593
6594 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6595
6596 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6597 New version that can reserve upto 2GB of heap space.
6598
6599 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6600
6601 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6602
6603 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6604
6605 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6606 `gnutls_certificate_set_x509_key_file'.
6607
6608 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6609
6610 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6611 Update dependencies.
6612
6613 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6614
6615 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6616 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6617 Remove unused parameter `fildes'.
6618 * process.c (read_process_output, send_process): Don't pass it.
6619
6620 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6621
6622 Fix previous change: the library cache is defined in w32.c.
6623 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6624 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6625
6626 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6627
6628 Implement dynamic loading of GnuTLS on Windows.
6629
6630 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6631 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6632 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6633 Declare.
6634
6635 * gnutls.c (Qgnutls_dll): Define.
6636 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6637 (gnutls_*): Declare function pointers.
6638 (init_gnutls_functions): New function to initialize function pointers.
6639 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6640 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6641 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6642 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6643 (emacs_gnutls_write, emacs_gnutls_read)
6644 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6645 (Fgnutls_available_p): New function.
6646 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6647 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6648 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6649
6650 * image.c: Include w32.h.
6651 (Vimage_type_cache): Delete.
6652 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6653 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6654 (w32_delayed_load): Move to w32.c.
6655
6656 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6657
6658 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6659 (w32_delayed_load): Move from image.c. When loading a library, record
6660 its filename in the :loaded-from property of the library id.
6661 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6662 Initialize and staticpro them.
6663 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6664
6665 * process.c: Include lisp.h before w32.h, not after.
6666 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6667 instead of gnutls_record_check_pending.
6668
6669 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6670
6671 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6672
6673 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6674 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6675 as passed in.
6676
6677 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6678
6679 * xterm.c (x_set_frame_alpha): Do not set property on anything
6680 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6681
6682 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6683
6684 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6685
6686 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6687
6688 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6689 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6690 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6691 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6692 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6693 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6694 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6695 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6696 (Qgnutls_bootprop_callbacks_verify): Make static.
6697
6698 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6699
6700 * callproc.c: Indentation fixup.
6701
6702 * sysdep.c (wait_for_termination_1): Make static.
6703 (wait_for_termination, interruptible_wait_for_termination):
6704 Move after wait_for_termination_1.
6705
6706 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6707
6708 * sysdep.c (interruptible_wait_for_termination): New function
6709 which is like wait_for_termination, but allows keyboard
6710 interruptions.
6711
6712 * callproc.c (Fcall_process): Add (:file "file") as an option for
6713 the STDOUT buffer.
6714 (Fcall_process_region): Ditto.
6715
6716 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6717
6718 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6719 rather than `XVECTOR (FOO)->size'.
6720
6721 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6722 inttypes.h, as a gnulib replacement is used if it not available in
6723 system headers.
6724
6725 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6726
6727 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6728 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6729 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6730
6731 * coding.c (coding_alloc_by_realloc): Error out if destination
6732 will grow beyond MOST_POSITIVE_FIXNUM.
6733 (decode_coding_emacs_mule): Abort if there isn't enough place in
6734 charbuf for the composition carryover bytes. Reserve an extra
6735 space for up to 2 characters produced in a loop.
6736 (decode_coding_iso_2022): Abort if there isn't enough place in
6737 charbuf for the composition carryover bytes.
6738
6739 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6740
6741 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6742 aborting when %lld or %lll format is passed.
6743 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6744 %llo or %llx format is passed. (Bug#8545)
6745
6746 * window.c (window_scroll_line_based): Use a marker instead of
6747 simple variables to record original value of point. (Bug#7952)
6748
6749 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6750 produced by %s or %c overflows available buffer space. (Bug#8545)
6751
6752 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6753
6754 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6755 (SIZE_MAX): Move defn after all includes, as they might #define it.
6756
6757 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6758
6759 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6760
6761 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6762
6763 * keyboard.c (Qdelayed_warnings_hook): Define.
6764 (command_loop_1): Run `delayed-warnings-hook'
6765 if Vdelayed_warnings_list is non-nil.
6766 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6767 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6768
6769 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6770
6771 * doprnt.c (doprnt): Don't return value smaller than the buffer
6772 size if the message was truncated. (Bug#8545).
6773
6774 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6775
6776 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6777 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6778
6779 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6780
6781 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6782
6783 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6784
6785 * makefile.w32-in: Update dependencies.
6786
6787 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6788
6789 Improve `doprnt' and its usage. (Bug#8545)
6790 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6791 `format_end'. Remove support for %l as a conversion specifier.
6792 Don't use xrealloc. Improve diagnostics when the %l size modifier
6793 is used. Update the commentary.
6794
6795 * eval.c (verror): Simplify calculation of size_t.
6796
6797 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6798 messages.
6799
6800 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6801
6802 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6803 change.
6804
6805 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6806
6807 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6808 This makes this file independent of the recent pseudovector change.
6809
6810 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6811
6812 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6813
6814 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6815 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6816 Remove unused local.
6817 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6818
6819 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6820 GCC 4.6.0 optimizes based on type-based alias analysis.
6821 For example, if b is of type struct buffer * and v of type struct
6822 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6823 != &v->size, and therefore "v->size = 1; b->size = 2; return
6824 v->size;" must therefore return 1. This assumption is incorrect
6825 for Emacs, since it type-puns struct Lisp_Vector * with many other
6826 types. To fix this problem, this patch adds a new type struct
6827 vectorlike_header that documents the constraints on layout of vectors
6828 and pseudovectors, and helps optimizing compilers not get fooled
6829 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6830 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6831 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6832 the size member.
6833 (XSETPVECTYPE): Rewrite in terms of new macro.
6834 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6835 This is a bit clearer, and further avoids the possibility of
6836 undesirable aliasing.
6837 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6838 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6839 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6840 since Lisp_Subr is a special case (no "next" field).
6841 (ASIZE): Now uses header.size rather than size.
6842 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6843 to avoid the hassle of writing XVECTOR (foo)->header.size.
6844 (struct vectorlike_header): New type.
6845 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6846 object, to help avoid aliasing.
6847 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6848 (SUBRP): Likewise, since Lisp_Subr is a special case.
6849 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6850 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6851 (struct Lisp_Hash_Table): Combine first two members into a single
6852 struct vectorlike_header member. All uses of "size" and "next" members
6853 changed to be "header.size" and "header.next".
6854 * buffer.h (struct buffer): Likewise.
6855 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6856 * frame.h (struct frame): Likewise.
6857 * process.h (struct Lisp_Process): Likewise.
6858 * termhooks.h (struct terminal): Likewise.
6859 * window.c (struct save_window_data, struct saved_window): Likewise.
6860 * window.h (struct window): Likewise.
6861 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6862 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6863 * buffer.c (init_buffer_once): Likewise.
6864 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6865 special case.
6866 * process.c (Fformat_network_address): Use local var for size,
6867 for brevity.
6868
6869 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6870
6871 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6872 * data.c (atof): Remove decl; no longer used or needed.
6873 (digit_to_number): Move to lread.c.
6874 (Fstring_to_number): Use new string_to_number function, to be
6875 consistent with how the Lisp reader treats infinities and NaNs.
6876 Do not assume that floating-point numbers represent EMACS_INT
6877 without losing information; this is not true on most 64-bit hosts.
6878 Avoid double-rounding errors, by insisting on integers when
6879 parsing non-base-10 numbers, as the documentation specifies.
6880 * lisp.h (string_to_number): New decl, replacing ...
6881 (isfloat_string): Remove.
6882 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6883 (read1): Do not accept +. and -. as integers; this
6884 appears to have been a coding error. Similarly, do not accept
6885 strings like +-1e0 as floating point numbers. Do not report
6886 overflow for integer overflows unless the base is not 10 which
6887 means we have no simple and reliable way to continue.
6888 Break out the floating-point parsing into a new
6889 function string_to_number, so that Fstring_to_number parses
6890 floating point numbers consistently with the Lisp reader.
6891 (digit_to_number): Move here from data.c. Make it static inline.
6892 (E_CHAR, EXP_INT): Remove, replacing with ...
6893 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6894 (string_to_number): New function, replacing isfloat_string.
6895 This function checks for valid syntax and produces the resulting
6896 Lisp float number too. Rework it so that string-to-number
6897 no longer mishandles examples like "1.0e+". Use strtoumax,
6898 so that overflow for non-base-10 numbers is reported only when
6899 there's no portable and simple way to convert to floating point.
6900
6901 * textprop.c (set_text_properties_1): Rewrite for clarity,
6902 and to avoid GCC warning about integer overflow.
6903
6904 * intervals.h (struct interval): Use EMACS_INT for members
6905 where EMACS_UINT might cause problems. See
6906 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6907 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6908 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6909 All uses changed.
6910 (offset_intervals): Tell GCC not to worry about length overflow
6911 when negating a negative length.
6912
6913 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6914 (overrun_check_free): Likewise.
6915
6916 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6917 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6918 word size.
6919
6920 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6921 (gnutls_make_error): Rename local to avoid shadowing.
6922 (gnutls_emacs_global_deinit): ifdef out; not used.
6923 (Fgnutls_boot): Use const for pointer to readonly storage.
6924 Comment out unused local. Fix pointer signedness problems.
6925
6926 * lread.c (openp): Don't stuff size_t into an 'int'.
6927 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6928 about possible signed overflow.
6929
6930 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6931 (GDK_KEY_g): Don't define if already defined.
6932 (xg_prepare_tooltip): Avoid pointer signedness problem.
6933 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6934
6935 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6936 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6937
6938 * xfns.c (Fx_window_property): Simplify a bit,
6939 to make a bit faster and to avoid GCC 4.6.0 warning.
6940 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6941
6942 * fns.c (internal_equal): Don't assume size_t fits in int.
6943
6944 * alloc.c (compact_small_strings): Tighten assertion a little.
6945
6946 Replace pEd with more-general pI, and fix some printf arg casts.
6947 * lisp.h (pI): New macro, generalizing old pEd macro to other
6948 conversion specifiers. For example, use "...%"pI"d..." rather
6949 than "...%"pEd"...".
6950 (pEd): Remove. All uses replaced with similar uses of pI.
6951 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6952 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6953 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6954 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6955 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6956 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6957 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6958 64-bit hosts.
6959 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6960 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6961 * print.c (safe_debug_print, print_object): Likewise.
6962 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6963 to int.
6964 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6965 avoiding the 0 flag, which is not portable.
6966 * process.c (Fmake_network_process): Use pI to avoid cast.
6967 * region-cache.c (pp_cache): Likewise.
6968 * xdisp.c (decode_mode_spec): Likewise.
6969 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6970 behavior on 64-bit hosts with printf arg.
6971 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6972 (x_stop_queuing_selection_requests): Likewise.
6973 (x_get_window_property): Don't truncate byte count to an 'int'
6974 when tracing.
6975
6976 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6977 here, since it parses constructs like leading '-' and spaces,
6978 which are not wanted; and it overflows with large numbers.
6979 Instead, simply match F[0-9]+, which is what is wanted anyway.
6980
6981 * alloc.c: Remove unportable assumptions about struct layout.
6982 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6983 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6984 (allocate_vectorlike, make_pure_vector): Use the new macros,
6985 plus offsetof, to remove unportable assumptions about struct layout.
6986 These assumptions hold on all porting targets that I know of, but
6987 they are not guaranteed, they're easy to remove, and removing them
6988 makes further changes easier.
6989
6990 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6991 This doesn't fix a bug but makes the code clearer.
6992 (string_overrun_cookie): Now const. Use initializers that
6993 don't formally overflow signed char, to avoid warnings.
6994 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6995 can cause Emacs to crash when string overrun checking is enabled.
6996 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6997 multiple of sizeof (EMACS_INT); it need not be, if
6998 alignof(EMACS_INT) < sizeof (EMACS_INT).
6999 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7000
7001 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7002
7003 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7004
7005 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7006
7007 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7008 supposed to be handshaking. (Bug#8556)
7009 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7010
7011 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7012
7013 * lisp.h (Qdebug): List symbol.
7014 * eval.c (Qdebug): Restore global linkage.
7015 * keyboard.c (debug-on-event): New variable.
7016 (handle_user_signal): Break into debugger when debug-on-event
7017 matches the current signal symbol.
7018
7019 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7020
7021 * alloc.c (check_sblock, check_string_bytes)
7022 (check_string_free_list): Convert to standard C.
7023
7024 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7025
7026 * w32.c (emacs_gnutls_push): Fix typo.
7027
7028 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7029
7030 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7031 "cast to pointer from integer of different size".
7032
7033 Improve doprnt and its use in verror. (Bug#8545)
7034 * doprnt.c (doprnt): Document the set of format control sequences
7035 supported by the function. Use SAFE_ALLOCA instead of always
7036 using `alloca'.
7037
7038 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7039 is one byte too soon. Don't use xrealloc; instead xfree and
7040 xmalloc anew.
7041
7042 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7043
7044 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7045 callbacks stage.
7046
7047 * gnutls.c: Renamed global_initialized to
7048 gnutls_global_initialized. Added internals for the
7049 :verify-hostname-error, :verify-error, and :verify-flags
7050 parameters of `gnutls-boot' and documented those parameters in the
7051 docstring. Start callback support.
7052 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7053 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7054 on error. Return error code.
7055 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7056 (emacs_gnutls_read): Likewise.
7057 (Fgnutls_boot): Return handshake error code.
7058 (emacs_gnutls_handle_error): New function.
7059 (wsaerror_to_errno): Likewise.
7060
7061 * w32.h (emacs_gnutls_pull): Add prototype.
7062 (emacs_gnutls_push): Likewise.
7063
7064 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7065 (emacs_gnutls_push): Likewise.
7066
7067 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7068
7069 * process.c (wait_reading_process_output): Check if GnuTLS
7070 buffered some data internally if no FDs are set for TLS
7071 connections.
7072
7073 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7074 (LIBS): Link to USER_LIBS.
7075 ($(BLD)/gnutls.$(0)): New target.
7076
7077 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7078
7079 * xdisp.c (handle_single_display_spec): Rename the
7080 display_replaced_before_p argument into display_replaced_p, to
7081 make it consistent with the commentary. Fix typos in the
7082 commentary.
7083
7084 * textprop.c (syms_of_textprop): Remove dead code.
7085 (copy_text_properties): Delete obsolete commentary about an
7086 interface that was deleted long ago. Fix typos in the description
7087 of arguments.
7088
7089 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7090 to changes in oldXMenu/XMenu.h from 2011-04-16.
7091 <menu_help_message, prev_menu_help_message>: Constify.
7092 (IT_menu_make_room): menu->help_text is now `const char **';
7093 adjust.
7094
7095 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7096 to changes in oldXMenu/XMenu.h from 2011-04-16.
7097 (struct XMenu): Declare `help_text' `const char **'.
7098
7099 * xfaces.c <Qunspecified>: Make extern again.
7100
7101 * syntax.c: Include sys/types.h before including regex.h, as
7102 required by Posix.
7103
7104 * doc.c (get_doc_string): Improve the format passed to `error'.
7105
7106 * doprnt.c (doprnt): Improve commentary.
7107
7108 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7109
7110 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7111 them with etags.
7112
7113 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7114 changes in globals.h immediately force recompilation.
7115 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7116 $(CURDIR)/s/ms-w32.h.
7117 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7118
7119 * character.c (Fchar_direction): Function deleted.
7120 (syms_of_character): Don't defsubr it.
7121 <char-direction-table>: Deleted.
7122
7123 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7124
7125 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7126 * doprnt.c: Include limits.h.
7127 (SIZE_MAX): New macro.
7128 (doprnt): Return a size_t value. 2nd arg is now size_t.
7129 Many local variables are now size_t instead of int or unsigned.
7130 Improve overflow protection. Support `l' modifier for integer
7131 conversions. Support %l conversion. Don't assume an EMACS_INT
7132 argument for integer conversions and for %c.
7133
7134 * lisp.h (doprnt): Restore prototype.
7135
7136 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7137 $(SRC)/character.h.
7138
7139 * Makefile.in (base_obj): Add back doprnt.o.
7140
7141 * deps.mk (doprnt.o): Add back prerequisites.
7142 (callint.o): Depend on character.h.
7143
7144 * eval.c (internal_lisp_condition_case): Include the handler
7145 representation in the error message.
7146 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7147 when breaking from the loop.
7148
7149 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7150
7151 * callint.c (Fcall_interactively): When displaying error message
7152 about invalid control letter, pass the character's codepoint, not
7153 a pointer to its multibyte form. Improve display of the character
7154 in octal and display also its hex code.
7155
7156 * character.c (char_string): Use %x to display the (unsigned)
7157 codepoint of an invalid character, to avoid displaying a bogus
7158 negative value.
7159
7160 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7161 `error', not SYMBOL_NAME itself.
7162
7163 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7164 character arguments to `error'.
7165
7166 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7167 to `error' in error message about FINAL_CHAR argument. Make sure
7168 FINAL_CHAR is a character, and use %c when it is passed as
7169 argument to `error'.
7170
7171 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7172
7173 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7174
7175 * w32.c: Include <time.h>.
7176 (sys_localtime): New function.
7177
7178 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7179
7180 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7181
7182 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7183
7184 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7185
7186 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7187 zombies (Bug#8467).
7188
7189 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7190
7191 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7192 gl_state.e_property when gl_state.object is Qt.
7193
7194 * insdel.c (make_gap_larger): Remove limitation of buffer size
7195 to <= INT_MAX.
7196
7197 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7198
7199 * xdisp.c (lookup_glyphless_char_display)
7200 (produce_glyphless_glyph): Handle cons cell entry in
7201 glyphless-char-display.
7202 (Vglyphless_char_display): Document it.
7203
7204 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7205 glyphless-char-display.
7206
7207 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7208
7209 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7210
7211 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7212
7213 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7214 definition for no-X builds.
7215
7216 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7217
7218 Static checks with GCC 4.6.0 and non-default toolkits.
7219
7220 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7221
7222 * process.c (keyboard_bit_set): Define only if SIGIO.
7223 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7224 (send_process): Repair possible setjmp clobbering.
7225
7226 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7227
7228 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7229
7230 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7231
7232 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7233 Define only if needed.
7234
7235 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7236 by pacifying GCC about it. Maybe it's time to retire it?
7237 * xfaces.c (USG, __TIMEVAL__): Likewise.
7238
7239 * dispextern.h (struct redisplay_interface): Rename param
7240 to avoid shadowing.
7241 * termhooks.h (struct terminal): Likewise.
7242 * xterm.c (xembed_send_message): Likewise.
7243
7244 * insdel.c (make_gap_smaller): Define only if
7245 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7246
7247 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7248 it.
7249
7250 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7251 so that we aren't warned about unused symbols.
7252
7253 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7254
7255 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7256
7257 * xfns.c (x_real_positions): Mark locals as initialized.
7258
7259 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7260
7261 * xterm.c: Fix problems found by static analysis with other toolkits.
7262 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7263 (x_dispatch_event): Declare static if USE_GTK, and
7264 define if USE_GTK || USE_X_TOOLKIT.
7265 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7266 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7267 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7268 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7269
7270 * xmenu.c (menu_help_callback): Pointer type fixes.
7271 Use const pointers when pointing at readonly data. Avoid pointer
7272 signedness clashes.
7273 (FALSE): Remove unused macro.
7274 (update_frame_menubar): Remove unused decl.
7275
7276 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7277
7278 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7279 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7280 (single_menu_item): Rename local to avoid shadowing.
7281
7282 * keyboard.c (make_lispy_event): Remove unused local var.
7283
7284 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7285 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7286
7287 * bitmaps: Change bitmaps from unsigned char back to the X11
7288 compatible char. Avoid the old compiler warnings about
7289 out-of-range initializers by using, for example, '\xab' rather
7290 than 0xab.
7291
7292 * xgselect.c (xgselect_initialize): Check vs interface
7293 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7294
7295 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7296
7297 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7298 to read-only memory.
7299
7300 * fns.c (vector): Remove; this old hack is no longer needed.
7301
7302 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7303 Remove unused var.
7304 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7305
7306 * xrdb.c (x_load_resources): Omit unused local.
7307
7308 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7309 (x_window): Rename locals to avoid shadowing.
7310 (USG): Use the kludged USG macro, to pacify gcc.
7311
7312 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7313 (x_term_init): Remove local to avoid shadowing.
7314
7315 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7316
7317 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7318 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7319
7320 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7321
7322 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7323
7324 Fix regex.c, syntax.c and friends for buffers > 2GB.
7325 * syntax.h (struct gl_state_s): Declare character position members
7326 EMACS_INT.
7327
7328 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7329
7330 * textprop.c (verify_interval_modification, interval_of):
7331 Declare arguments EMACS_INT.
7332
7333 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7334 EMACS_INT.
7335
7336 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7337
7338 * indent.c (Fvertical_motion): Local variable it_start is now
7339 EMACS_INT.
7340
7341 * regex.c (re_match, re_match_2, re_match_2_internal)
7342 (bcmp_translate, regcomp, regexec, print_double_string)
7343 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7344 (re_compile_pattern, re_exec): Declare arguments and local
7345 variables `size_t' and `ssize_t' and return values `regoff_t', as
7346 appropriate.
7347 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7348 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7349 <compile_stack_type>: `size' and `avail' are now `size_t'.
7350
7351 * regex.h <regoff_t>: Use ssize_t, not int.
7352 (re_search, re_search_2, re_match, re_match_2): Arguments that
7353 specify buffer/string position and length are now ssize_t and
7354 size_t. Return type is regoff_t.
7355
7356 2011-04-16 Ben Key <bkey76@gmail.com>
7357
7358 * nsfont.m: Fixed bugs in ns_get_family and
7359 ns_descriptor_to_entity that were caused by using free to
7360 deallocate memory blocks that were allocated by xmalloc (via
7361 xstrdup). This caused Emacs to crash when compiled with
7362 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7363 --enable-checking=xmallocoverrun). xfree is now used to
7364 deallocate these memory blocks.
7365
7366 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7367
7368 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7369
7370 emacs_write: Accept and return EMACS_INT for sizes.
7371 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7372 et seq.
7373 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7374 Accept and return EMACS_INT.
7375 (emacs_gnutls_write): Return the number of bytes written on
7376 partial writes.
7377 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7378 (emacs_read, emacs_write): Remove check for negative size, as the
7379 Emacs source code has been audited now.
7380 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7381 (emacs_read, emacs_write): Use it.
7382 * process.c (send_process): Adjust to the new signatures of
7383 emacs_write and emacs_gnutls_write. Do not attempt to store
7384 a byte offset into an 'int'; it might overflow.
7385 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7386
7387 * sound.c: Don't assume sizes fit in 'int'.
7388 (struct sound_device.period_size, alsa_period_size):
7389 Return EMACS_INT, not int.
7390 (struct sound_device.write, vox_write, alsa_write):
7391 Accept EMACS_INT, not int.
7392 (wav_play, au_play): Use EMACS_INT to store sizes and to
7393 record read return values.
7394
7395 2011-04-15 Ben Key <bkey76@gmail.com>
7396
7397 * keyboard.c (Qundefined): Don't declare static since it is used
7398 in nsfns.m.
7399 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7400 static since they are used in nsfont.m.
7401
7402 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7403
7404 * process.c (Qprocessp): Don't declare static.
7405 * lisp.h (Qprocessp): Declare again.
7406
7407 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7408
7409 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7410
7411 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7412
7413 Improve C-level modularity by making more things 'static'.
7414
7415 Don't publish debugger-only interfaces to other modules.
7416 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7417 (verify_bytepos, count_markers): Move decls to the only modules
7418 that need them.
7419 * region-cache.h (pp_cache): Likewise.
7420 * window.h (check_all_windows): Likewise.
7421 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7422
7423 * sysdep.c (croak): Now static, if
7424 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7425 * syssignal.h (croak): Declare only if not static.
7426
7427 * alloc.c (refill_memory_reserve): Now static if
7428 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7429 * lisp.h (refill_memory_reserve): Declare only if not static.
7430
7431 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7432 Define only if USE_LUCID.
7433
7434 * xrdb.c (x_customization_string, x_rm_string): Now static.
7435
7436 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7437 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7438
7439 * xdisp.c (draw_row_with_mouse_face): Now static.
7440 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7441
7442 * window.h (check_all_windows): Mark externally visible.
7443
7444 * window.c (window_deletion_count): Now static.
7445
7446 * undo.c: Make symbols static if they're not exported.
7447 (last_undo_buffer, last_boundary_position, pending_boundary):
7448 Now static.
7449
7450 * textprop.c (interval_insert_behind_hooks): Now static.
7451 (interval_insert_in_front_hooks): Likewise.
7452
7453 * term.c: Make symbols static if they're not exported.
7454 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7455 (max_frame_lines, tty_set_terminal_modes):
7456 (tty_reset_terminal_modes, tty_turn_off_highlight):
7457 (get_tty_terminal): Now static.
7458 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7459 * termhooks.h (term_mouse_moveto): Do not declare if
7460 HAVE_WINDOW_SYSTEM.
7461 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7462 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7463
7464 * sysdep.c: Make symbols static if they're not exported.
7465 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7466 Now static.
7467 (sigprocmask_set, full_mask): Remove; unused.
7468 (wait_debugging): Mark as visible.
7469 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7470 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7471
7472 * syntax.c (syntax_temp): Define only if !__GNUC__.
7473
7474 * sound.c (current_sound_device, current_sound): Now static.
7475
7476 * search.c (searchbufs, searchbuf_head): Now static.
7477
7478 * scroll.c (scroll_cost): Remove; unused.
7479 * dispextern.h (scroll_cost): Remove decl.
7480
7481 * region-cache.h (pp_cache): Mark as externally visible.
7482
7483 * process.c: Make symbols static if they're not exported.
7484 (process_tick, update_tick, create_process, chan_process):
7485 (Vprocess_alist, proc_buffered_char, datagram_access):
7486 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7487 (deactivate_process): Mark defn as static, as well as decl.
7488 * lisp.h (create_process): Remove decl.
7489 * process.h (chan_process, Vprocess_alist): Remove decls.
7490
7491 * print.c: Make symbols static if they're not exported.
7492 (print_depth, new_backquote_output, being_printed, print_buffer):
7493 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7494 (print_interval, print_number_index, initial_stderr_stream):
7495 Now static.
7496 * lisp.h (Fprinc): Remove decl.
7497 (debug_output_compilation_hack): Mark as externally visible.
7498
7499 * sysdep.c (croak): Move decl from here to syssignal.h.
7500 * syssignal.h (croak): Put it here, so the API can be checked when
7501 'croak' is called from dissociate_if_controlling_tty.
7502
7503 * minibuf.c: Make symbols static if they're not exported.
7504 (minibuf_save_list, choose_minibuf_frame): Now static.
7505 * lisp.h (choose_minibuf_frame): Remove decl.
7506
7507 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7508
7509 * lread.c: Make symbols static if they're not exported.
7510 (read_objects, initial_obarray, oblookup_last_bucket_number):
7511 Now static.
7512 (make_symbol): Remove; unused.
7513 * lisp.h (initial_obarray, make_symbol): Remove decls.
7514
7515 * keyboard.c: Make symbols static if they're not exported.
7516 (single_kboard, recent_keys_index, total_keys, recent_keys):
7517 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7518 (this_single_command_key_start, echoing, last_auto_save):
7519 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7520 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7521 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7522 (Vlispy_mouse_stem, double_click_count):
7523 Now static.
7524 (force_auto_save_soon): Define only if SIGDANGER.
7525 (ignore_mouse_drag_p): Now static if
7526 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7527 (print_help): Remove; unused.
7528 (stop_character, last_timer_event): Mark as externally visible.
7529 * keyboard.h (ignore_mouse_drag_p): Declare only if
7530 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7531 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7532 * lisp.h (echoing): Remove decl.
7533 (force_auto_save_soon): Declare only if SIGDANGER.
7534 * xdisp.c (redisplay_window): Simplify code, to make it more
7535 obvious that ignore_mouse_drag_p is not accessed if !defined
7536 USE_GTK && !defined HAVE_NS.
7537
7538 * intervals.c: Make symbols static if they're not exported.
7539 (merge_properties_sticky, merge_interval_right, delete_interval):
7540 Now static.
7541 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7542
7543 * insdel.c: Make symbols static if they're not exported.
7544 However, leave prepare_to_modify_buffer alone. It's never
7545 called from outside this function, but that appears to be a bug.
7546 (combine_after_change_list, combine_after_change_buffer):
7547 (adjust_after_replace, signal_before_change): Now static.
7548 (adjust_after_replace_noundo): Remove; unused.
7549 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7550 (signal_before_change): Remove decls.
7551
7552 * indent.c (val_compute_motion, val_vmotion): Now static.
7553
7554 * image.c: Make symbols static if they're not exported.
7555 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7556 if USE_GTK.
7557 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7558 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7559
7560 * fringe.c (standard_bitmaps): Now static.
7561 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7562
7563 * frame.c: Make symbols static if they're not exported.
7564 (x_report_frame_params, make_terminal_frame): Now static.
7565 (get_frame_param): Now static, unless HAVE_NS.
7566 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7567 (x_get_resource_string): Remove; not used.
7568 * frame.h (make_terminal_frame, x_report_frame_params):
7569 (x_get_resource_string); Remove decls.
7570 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7571 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7572
7573 * font.c, fontset.c: Make symbols static if they're not exported.
7574 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7575 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7576 * font.c (font_close_object): Now static.
7577 * font.h (font_close_object): Remove.
7578 * fontset.c (FONTSET_OBJLIST): Remove.
7579 (free_realized_fontset) #if-0 the body, which does nothing.
7580 (face_suitable_for_char_p): #if-0, as it's never called.
7581 * fontset.h (face_suitable_for_char_p): Remove decl.
7582 * xfaces.c (face_at_string_position):
7583 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7584 since 0 is always ASCII.
7585
7586 * fns.c (weak_hash_tables): Now static.
7587
7588 * fileio.c: Make symbols static if they're not exported.
7589 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7590 (Vwrite_region_annotation_buffers): Now static.
7591
7592 * eval.c: Make symbols static if they're not exported.
7593 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7594 * lisp.h (backtrace_list): Remove decl.
7595
7596 * emacs.c: Make symbols static if they're not exported.
7597 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7598 (fatal_error_code, fatal_error_signal_hook, standard_args):
7599 Now static.
7600 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7601 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7602 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7603 * lisp.h (fatal_error_signal_hook): Remove decl.
7604 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7605
7606 * editfns.c: Move a (normally-unused) function to its only use.
7607 * editfns.c, lisp.h (get_operating_system_release): Remove.
7608 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7609 worth the hassle of breaking this out.
7610
7611 * xterm.c: Make symbols static if they're not exported.
7612 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7613 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7614 (x_destroy_window, x_delete_display):
7615 Now static.
7616 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7617 (x_mouse_leave): Remove; unused.
7618 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7619 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7620 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7621 Remove decls.
7622 (x_mouse_leave): Declare only if WINDOWSNT.
7623 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7624 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7625 USE_X_TOOLKIT.
7626
7627 * ftxfont.c: Make symbols static if they're not exported.
7628 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7629 HAVE_FREETYPE.
7630 * font.h (ftxfont_driver): Likewise.
7631
7632 * xfns.c: Make symbols static if they're not exported.
7633 (x_last_font_name, x_display_info_for_name):
7634 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7635 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7636 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7637 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7638 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7639 (last_show_tip_args): Now static.
7640 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7641 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7642 (x_screen_planes): Remove; unused.
7643 * dispextern.h (x_screen_planes): Remove decl.
7644
7645 * dispnew.c: Make symbols static if they're not exported.
7646 * dispextern.h (redraw_garbaged_frames, scrolling):
7647 (increment_row_positions): Remove.
7648 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7649 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7650 Now static.
7651 (redraw_garbaged_frames): Remove; unused.
7652
7653 * xfaces.c: Make symbols static if they're not exported.
7654 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7655 Remove decls.
7656 * xterm.h (defined_color): Remove decls.
7657 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7658 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7659 (menu_face_changed_default, defined_color, free_realized_face):
7660 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7661 (ascii_face_of_lisp_face): Remove; unused.
7662
7663 * xdisp.c: Make symbols static if they're not exported.
7664 * dispextern.h (scratch_glyph_row, window_box_edges):
7665 (glyph_to_pixel_coords, set_cursor_from_row):
7666 (get_next_display_element, set_iterator_to_next):
7667 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7668 (show_mouse_face): Remove decls
7669 * frame.h (message_buf_print): Likewise.
7670 * lisp.h (pop_message, set_message, check_point_in_composition):
7671 Likewise.
7672 * xterm.h (set_vertical_scroll_bar): Likewise.
7673 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7674 (message_buf_print, scratch_glyph_row, displayed_buffer):
7675 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7676 (get_next_display_element, show_mouse_face, window_box_edges):
7677 (frame_to_window_pixel_xy, check_point_in_composition):
7678 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7679 (glyph_to_pixel_coords): Remove; unused.
7680
7681 * dired.c (file_name_completion): Now static.
7682
7683 * dbusbind.c (xd_in_read_queued_messages): Now static.
7684
7685 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7686 * data.c (circular_list_error): Remove.
7687
7688 * commands.h (last_point_position, last_point_position_buffer):
7689 (last_point_position_window): Remove decls.
7690 * keyboard.c: Make these variables static.
7691
7692 * coding.h (coding, code_convert_region, encode_coding_gap):
7693 Remove decls.
7694 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7695 (iso_code_class, detect_coding, code_convert_region): Now static.
7696 (encode_coding_gap): Remove; unused.
7697
7698 * chartab.c (chartab_chars, chartab_bits): Now static.
7699
7700 * charset.h (charset_iso_8859_1): Remove decl.
7701 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7702 Now static.
7703
7704 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7705 * ccl.c (Vccl_program_table): Now static.
7706 (check_ccl_update): Remove; unused.
7707
7708 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7709 * category.h: ... from here.
7710 * category.c (check_category_table, set_category_set): Now static.
7711
7712 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7713 * lisp.h: Remove these decls.
7714
7715 * buffer.c (buffer_count): Remove unused var.
7716
7717 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7718 so that it's not optimized away.
7719 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7720 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7721 exported only to the debugger.
7722
7723 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7724 * atimer.h (run_all_atimers): Remove; not exported.
7725
7726 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7727 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7728 was inaccessible from Lisp.
7729 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7730 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7731
7732 alloc.c: Import and export fewer symbols, and remove unused items.
7733 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7734 is defined.
7735 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7736 it's not optimized away by whole-program optimization.
7737 (message_enable_multibyte, free_misc): Remove.
7738 (catchlist, handlerlist, mark_backtrace):
7739 Declare only if BYTE_MARK_STACK.
7740 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7741 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7742 (message_enable_multibyte): Remove decl.
7743 (free_misc, interval_free_list, float_block, float_block_index):
7744 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7745 (cons_free_list, last_marked_index):
7746 Now static.
7747 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7748 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7749 (mark_backtrace): Define only if BYTE_MARK_STACK.
7750 * xdisp.c (message_enable_multibyte): Now static.
7751
7752 Declare Lisp_Object Q* variables to be 'static' if not exported.
7753 This makes it easier for human readers (and static analyzers)
7754 to see whether these variables are used from other modules.
7755 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7756 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7757 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7758 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7759 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7760 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7761 * xmenu.c, xselect.c:
7762 Declare Q* vars static if they are not used in other modules.
7763 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7764 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7765 Remove decls of unexported vars.
7766 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7767
7768 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7769
7770 Make Emacs functions such as Fatom 'static' by default.
7771 This makes it easier for human readers (and static analyzers)
7772 to see whether these functions can be called from other modules.
7773 DEFUN now defines a static function. To make the function external
7774 so that it can be used in other C modules, use the new macro DEFUE.
7775 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7776 (Finit_image_library):
7777 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7778 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7779 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7780 Remove decls, since these functions are now static.
7781 (Funintern, Fget_internal_run_time): New decls, since these functions
7782 were already external.
7783
7784 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7785 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7786 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7787 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7788 * keyboard.c, keymap.c, lread.c:
7789 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7790 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7791 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7792 Mark functions with DEFUE instead of DEFUN,
7793 if they are used in other modules.
7794 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7795 decls for now-static functions.
7796 * buffer.h (Fdelete_overlay): Remove decl.
7797 * callproc.c (Fgetenv_internal): Mark as internal.
7798 * composite.c (Fremove_list_of_text_properties): Remove decl.
7799 (Fcomposition_get_gstring): New forward static decl.
7800 * composite.h (Fcomposite_get_gstring): Remove decl.
7801 * dired.c (Ffile_attributes): New forward static decl.
7802 * doc.c (Fdocumntation_property): New forward static decl.
7803 * eval.c (Ffetch_bytecode): New forward static decl.
7804 (Funintern): Remove extern decl; now in .h file where it belongs.
7805 * fileio.c (Fmake_symbolic_link): New forward static decl.
7806 * image.c (Finit_image_library): New forward static decl.
7807 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7808 * intervals.h (Fprevious_property_change):
7809 (Fremove_list_of_text_properties): Remove decls.
7810 * keyboard.c (Fthis_command_keys): Remove decl.
7811 (Fcommand_execute): New forward static decl.
7812 * keymap.c (Flookup_key): New forward static decl.
7813 (Fcopy_keymap): Now static.
7814 * keymap.h (Flookup_key): Remove decl.
7815 * process.c (Fget_process): New forward static decl.
7816 (Fprocess_datagram_address): Mark as internal.
7817 * syntax.c (Fsyntax_table_p): New forward static decl.
7818 (skip_chars): Remove duplicate decl.
7819 * textprop.c (Fprevious_property_change): New forward static decl.
7820 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7821 Now internal.
7822 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7823 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7824
7825 * editfns.c (Fformat): Remove unreachable code.
7826
7827 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7828
7829 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7830 change. (Bug#8496)
7831
7832 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7833
7834 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7835 when at ZV. (Bug#8487)
7836
7837 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7838
7839 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7840 (Bug#8437)
7841 * keyboard.c (parse_tool_bar_item): Likewise.
7842 * sound.c (sound_cleanup, alsa_close): Likewise.
7843 * termcap.c (tgetent): Likewise.
7844 * xfns.c (x_default_font_parameter): Likewise.
7845 * xsettings.c (read_and_apply_settings): Likewise.
7846
7847 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7848 (overrun_check_free): Protoize.
7849
7850 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7851
7852 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7853 since callers should never pass a negative size.
7854 Change the signature to match that of plain 'read' and 'write'; see
7855 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7856 * lisp.h: Update prototypes of emacs_write and emacs_read.
7857
7858 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7859
7860 * xdisp.c (redisplay_window): Don't try to determine the character
7861 position of the scroll margin if the window start point w->startp
7862 is outside the buffer's accessible region. (Bug#8468)
7863
7864 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7865
7866 Fix write-region and its subroutines for buffers > 2GB.
7867 * fileio.c (a_write, e_write): Modify declaration of arguments and
7868 local variables to support buffers larger than 2GB.
7869 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7870
7871 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7872 argument, local variables, and return value.
7873
7874 * lisp.h: Update prototypes of emacs_write and emacs_read.
7875
7876 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7877
7878 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7879
7880 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7881
7882 Fix more problems found by GCC 4.6.0's static checks.
7883
7884 * xdisp.c (vmessage): Use a better test for character truncation.
7885
7886 * charset.c (load_charset_map): <, not <=, for optimization,
7887 and to avoid potential problems with integer overflow.
7888 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7889 * casetab.c (set_identity, shuffle): Likewise.
7890 * editfns.c (Fformat): Likewise.
7891 * syntax.c (skip_chars): Likewise.
7892
7893 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7894 This also lets GCC 4.6.0 generate slightly better loop code.
7895
7896 * callint.c (Fcall_interactively): <, not <=, for optimization.
7897 (Fcall_interactively): Count the number of arguments produced,
7898 not the number of arguments given. This is simpler and lets GCC
7899 4.6.0 generate slightly better code.
7900
7901 * ftfont.c: Distingish more carefully between FcChar8 and char.
7902 The previous code passed unsigned char * to a functions like
7903 strlen and xstrcasecmp that expect char *, which does not
7904 conform to the C standard.
7905 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7906 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7907 char * when the C standard requires it.
7908
7909 * keyboard.c (read_char): Remove unused var.
7910
7911 * eval.c: Port to Windows vsnprintf (Bug#8435).
7912 Include <limits.h>.
7913 (SIZE_MAX): Define if the headers do not.
7914 (verror): Do not give up if vsnprintf returns a negative count.
7915 Instead, grow the buffer. This ports to Windows vsnprintf, which
7916 does not conform to C99. Problem reported by Eli Zaretskii.
7917 Also, simplify the allocation scheme, by avoiding the need for
7918 calling realloc, and removing the ALLOCATED variable.
7919
7920 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7921
7922 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7923 But keep the doprint source code for now, as we might revamp it
7924 and use it again (Bug#8435).
7925 * lisp.h (doprnt): Remove.
7926 * Makefile.in (base_obj): Remove doprnt.o.
7927 * deps.mk (doprnt.o): Remove.
7928
7929 error: Print 32- and 64-bit integers portably (Bug#8435).
7930 Without this change, on typical 64-bit hosts error ("...%d...", N)
7931 was used to print both 32- and 64-bit integers N, which relied on
7932 undefined behavior.
7933 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7934 * lisp.h (error, verror): Mark as printf-like functions.
7935 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7936 Report overflow in size calculations when allocating printf buffer.
7937 Do not truncate output string at its first null byte.
7938 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7939 Truncate the output at a character boundary, since vsnprintf does not
7940 do that.
7941 * charset.c (check_iso_charset_parameter): Convert internal
7942 character to string before calling 'error', since %c now has the
7943 printf meaning.
7944 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7945 overflow when computing char to be passed to 'error'. Do not
7946 pass Lisp_Object to 'error'; pass the integer instead.
7947 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7948 formatted with plain %d.
7949
7950 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7951
7952 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7953
7954 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7955
7956 * xterm.c (x_catch_errors): Remove duplicate declaration.
7957
7958 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7959
7960 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7961
7962 2011-04-10 Jim Meyering <meyering@redhat.com>
7963
7964 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7965 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7966 return ssize_t not "int", and use size_t as the buffer length.
7967 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7968 * gnutls.h: Update declarations.
7969 * process.c (read_process_output): Use ssize_t, to match.
7970 (send_process): Likewise.
7971
7972 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7973
7974 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7975
7976 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7977
7978 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7979 Use unsigned char, to match FcChar8 type definition.
7980
7981 * xterm.c (handle_one_xevent):
7982 * xmenu.c (create_and_show_popup_menu):
7983 * xselect.c (x_decline_selection_request)
7984 (x_reply_selection_request): Avoid type-punned deref of X events.
7985
7986 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7987
7988 Fix some uses of `int' instead of EMACS_INT.
7989 * search.c (string_match_1, fast_string_match)
7990 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7991 (scan_buffer, find_next_newline_no_quit)
7992 (find_before_next_newline, search_command, Freplace_match)
7993 (Fmatch_data): Make some `int' variables be EMACS_INT.
7994
7995 * xdisp.c (display_count_lines): 3rd argument and return value now
7996 EMACS_INT. All callers changed.
7997 (pint2hrstr): Last argument is now EMACS_INT.
7998
7999 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8000 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8001 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8002 (decode_coding_utf_16, decode_coding_emacs_mule)
8003 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8004 (decode_coding_ccl, decode_coding_charset)
8005 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8006 (decode_coding_iso_2022, decode_coding_emacs_mule)
8007 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8008 <char_offset, last_offset>: Declare EMACS_INT.
8009 (encode_coding_utf_8, encode_coding_utf_16)
8010 (encode_coding_emacs_mule, encode_invocation_designation)
8011 (encode_designation_at_bol, encode_coding_iso_2022)
8012 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8013 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8014 Declare EMACS_INT.
8015 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8016 (encode_invocation_designation): Last argument P_NCHARS is now
8017 EMACS_INT.
8018 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8019 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8020
8021 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8022 All users changed.
8023
8024 * ccl.c (Fccl_execute_on_string): Declare some variables
8025 EMACS_INT.
8026
8027 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8028
8029 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8030
8031 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8032
8033 * process.c (Fformat_network_address): Doc fix.
8034
8035 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8036
8037 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8038
8039 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8040
8041 * keyboard.c (read_char): Call Lisp function help-form-show,
8042 instead of using internal_with_output_to_temp_buffer.
8043 (Qhelp_form_show): New var.
8044 (syms_of_keyboard): Use DEFSYM macro.
8045
8046 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8047
8048 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8049
8050 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8051
8052 * process.c (Flist_processes): Remove to Lisp.
8053 (list_processes_1): Delete.
8054
8055 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8056
8057 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8058
8059 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8060
8061 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8062
8063 Fix more problems found by GCC 4.6.0's static checks.
8064
8065 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8066
8067 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8068
8069 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8070
8071 * xdisp.c (vmessage): Mark as a printf-like function.
8072
8073 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8074
8075 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8076
8077 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8078 printf-like functions.
8079 (tiff_load): Add casts to remove these marks before passing them
8080 to system-supplied API.
8081
8082 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8083
8084 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8085 This avoids several warnings with gcc -Wstrict-overflow.
8086 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8087 directly, rather than having caller test rule sign. This avoids
8088 some unnecessary tests.
8089 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8090 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8091 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8092
8093 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8094 (xfont_open): Avoid unnecessary tests.
8095
8096 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8097
8098 * composite.h, composite.c (composition_gstring_put_cache):
8099 Use EMACS_INT, not int, for length.
8100
8101 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8102 breaking out part of COMPOSITION_DECODE_RULE.
8103 (COMPOSITION_DECODE_RULE): Use it.
8104 * composite.c (get_composition_id): Remove unused local vars,
8105 by using the new macro.
8106
8107 * textprop.c (set_text_properties_1): Change while to do-while,
8108 since the condition is always true at first.
8109
8110 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8111 (interval_deletion_adjustment): Return unsigned value.
8112 All uses changed.
8113
8114 * process.c (list_processes_1, create_pty, read_process_output):
8115 (exec_sentinel): Remove vars that were set but not used.
8116 (create_pty): Remove unnecessary "volatile"s.
8117 (Fnetwork_interface_info): Avoid possibility of int overflow.
8118 (read_process_output): Do adaptive read buffering even if carryover.
8119 (read_process_output): Simplify nbytes computation if buffered.
8120
8121 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8122
8123 * syntax.c (scan_words): Remove var that was set but not used.
8124 (update_syntax_table): Use unsigned instead of int.
8125
8126 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8127 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8128 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8129
8130 * print.c (print_error_message): Avoid int overflow.
8131
8132 * font.c (font_list_entities): Redo for clarity,
8133 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8134
8135 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8136 (font_score): Avoid potential overflow in diff calculation.
8137
8138 * fns.c (substring_both): Remove var that is set but not used.
8139 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8140
8141 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8142
8143 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8144 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8145 can always succeed if overflow has undefined behavior.
8146
8147 * search.c (boyer_moore, wordify): Remove vars set but not used.
8148 (wordify): Omit three unnecessary tests.
8149
8150 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8151 All callers changed. This avoids the need for an unused var.
8152
8153 * casefiddle.c (casify_region): Remove var that is set but not used.
8154
8155 * dired.c (file_name_completion): Remove var that is set but not used.
8156
8157 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8158
8159 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8160 (Finsert_file_contents): Remove unnecessary code checking fd.
8161
8162 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8163 Check for integer overflow on size calculations.
8164
8165 * buffer.c (Fprevious_overlay_change): Remove var that is set
8166 but not used.
8167
8168 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8169 Remove vars that are set but not used.
8170 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8171 (timer_check_2): Mark vars as initialized.
8172
8173 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8174
8175 * image.c (lookup_image): Remove var that is set but not used.
8176 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8177
8178 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8179 that are set but not used.
8180
8181 * xfns.c (make_invisible_cursor): Don't return garbage
8182 if XCreateBitmapFromData fails (Bug#8410).
8183
8184 * xselect.c (x_get_local_selection, x_handle_property_notify):
8185 Remove vars that are set but not used.
8186
8187 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8188 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8189
8190 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8191 Remove var that is set but not used.
8192 (scroll_bar_windows_size): Now size_t, not int.
8193 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8194 Check for overflow.
8195
8196 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8197 (map_tty_color) [!defined MSDOS]: Likewise.
8198
8199 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8200
8201 * coding.c: Remove vars that are set but not used.
8202 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8203 All callers changed.
8204 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8205 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8206 (decode_coding_charset): Remove vars that are set but not used.
8207
8208 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8209 that is set but not used.
8210
8211 * print.c (print_object): Remove var that is set but not used.
8212
8213 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8214 The gnulib version avoids calling malloc in the usual case,
8215 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8216 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8217 * filelock.c (current_lock_owner): Likewise.
8218 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8219 * sysdep.c: Include allocator.h, careadlinkat.h.
8220 (emacs_no_realloc_allocator): New static constant.
8221 (emacs_readlink): New function.
8222 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8223 ../lib/careadlinkat.h.
8224
8225 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8226
8227 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8228 first non-nil return value).
8229
8230 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8231
8232 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8233 if not defined (Bug#8403).
8234
8235 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8236
8237 * xdisp.c (display_count_lines): Remove parameter `start',
8238 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8239 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8240 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8241 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8242 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8243 and thereabouts. All callers changed.
8244 (get_per_char_metric): Remove parameter `f', unused since
8245 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8246
8247 2011-04-02 Jim Meyering <meyering@redhat.com>
8248
8249 do not dereference NULL upon failed strdup
8250 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8251 (ns_get_family): Likewise.
8252
8253 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8254
8255 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8256
8257 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8258
8259 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8260 later (Bug#8403).
8261
8262 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8263
8264 Add lexical binding.
8265
8266 * window.c (Ftemp_output_buffer_show): New fun.
8267 (Fsave_window_excursion):
8268 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8269
8270 * lread.c (lisp_file_lexically_bound_p): New function.
8271 (Fload): Bind Qlexical_binding.
8272 (readevalloop): Remove `evalfun' arg.
8273 Bind Qinternal_interpreter_environment.
8274 (Feval_buffer): Bind Qlexical_binding.
8275 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8276 Mark as dynamic.
8277 (syms_of_lread): Declare `lexical-binding'.
8278
8279 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8280
8281 * keyboard.c (eval_dyn): New fun.
8282 (menu_item_eval_property): Use it.
8283
8284 * image.c (parse_image_spec): Use Ffunctionp.
8285
8286 * fns.c (concat, mapcar1): Accept byte-code-functions.
8287
8288 * eval.c (Fsetq): Handle lexical vars.
8289 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8290 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8291 (FletX, Flet): Obey lexical binding.
8292 (Fcommandp): Handle closures.
8293 (Feval): New `lexical' arg.
8294 (eval_sub): New function extracted from Feval. Use it almost
8295 everywhere where Feval was used. Look up vars in lexical env.
8296 Handle closures.
8297 (Ffunctionp): Move from subr.el.
8298 (Ffuncall): Handle closures.
8299 (apply_lambda): Remove `eval_flags'.
8300 (funcall_lambda): Handle closures and new byte-code-functions.
8301 (Fspecial_variable_p): New function.
8302 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8303 but without exporting it to Lisp.
8304
8305 * doc.c (Fdocumentation, store_function_docstring):
8306 * data.c (Finteractive_form): Handle closures.
8307
8308 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8309 interactive spec.
8310
8311 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8312 New byte-codes.
8313 (exec_byte_code): New function extracted from Fbyte_code to handle new
8314 calling convention for byte-code-functions. Add new byte-codes.
8315
8316 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8317
8318 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8319
8320 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8321
8322 * xdisp.c (redisplay_internal): Fix prototype.
8323
8324 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8325
8326 * xdisp.c (SCROLL_LIMIT): New macro.
8327 (try_scrolling): Use it when setting scroll_limit.
8328 Limit scrolling to 100 screen lines.
8329 (redisplay_window): Even when falling back on "recentering",
8330 position point in the window according to scroll-conservatively,
8331 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8332
8333 (try_scrolling): When point is above the window, allow searching
8334 as far as scroll_max, or one screenful, to compute vertical
8335 distance from PT to the scroll margin position. This prevents
8336 try_scrolling from unnecessarily failing when
8337 scroll-conservatively is set to a value slightly larger than the
8338 window height. Clean up the case of PT below the margin at bottom
8339 of window: scroll_max can no longer be INT_MAX. When aggressive
8340 scrolling is in use, don't let point enter the opposite scroll
8341 margin as result of the scroll.
8342 (syms_of_xdisp) <scroll-conservatively>: Document the
8343 threshold of 100 lines for never-recentering scrolling.
8344
8345 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8346
8347 * dispextern.h (move_it_by_lines):
8348 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8349 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8350 (message_log_check_duplicate): Remove parameters `prev_bol' and
8351 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8352 (redisplay_internal): Remove parameter `preserve_echo_area',
8353 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8354
8355 * indent.c (Fvertical_motion):
8356 * window.c (window_scroll_pixel_based, Frecenter):
8357 Don't pass `need_y_p' to `move_it_by_lines'.
8358
8359 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8360
8361 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8362 steal a few bits to be more compact.
8363 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8364 Remove unneeded casts.
8365
8366 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8367
8368 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8369
8370 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8371 binding" message (bug#7967).
8372
8373 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8374
8375 Fix more problems found by GCC 4.6.0's static checks.
8376
8377 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8378 Remove unused local var.
8379
8380 * editfns.c (Fmessage_box): Remove unused local var.
8381
8382 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8383 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8384 Omit unused local vars.
8385 * window.c (shrink_windows): Omit unused local var.
8386 * menu.c (digest_single_submenu): Omit unused local var.
8387 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8388 Omit unused local var.
8389
8390 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8391 Don't assume string length fits in int.
8392 (keyremap_step, read_key_sequence): Use size_t for sizes.
8393 (read_key_sequence): Don't check last_real_key_start redundantly.
8394
8395 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8396 instead of alloca (Bug#8344).
8397
8398 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8399 (Fbacktrace_frame): Don't assume nframes fits in int.
8400
8401 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8402
8403 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8404 concerns.
8405
8406 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8407
8408 * cm.c (calccost): Turn while-do into do-while, for clarity.
8409
8410 * keyboard.c (syms_of_keyboard): Use the same style as later
8411 in this function when indexing through an array. This also
8412 works around GCC bug 48267.
8413
8414 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8415
8416 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8417
8418 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8419 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8420
8421 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8422 This avoids undefined behavior on integer overflow, and is a bit
8423 more convenient anyway since it is compared to a size_t variable.
8424
8425 Variadic C functions now count arguments with size_t, not int.
8426 This avoids an unnecessary limitation on 64-bit machines, which
8427 caused (substring ...) to crash on large vectors (Bug#8344).
8428 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8429 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8430 All variadic functions and their callers changed accordingly.
8431 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8432 * data.c (arith_driver, float_arith_driver): Likewise.
8433 * editfns.c (general_insert_function): Likewise.
8434 * eval.c (struct backtrace.nargs, interactive_p)
8435 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8436 (funcall_lambda, mark_backtrace): Likewise.
8437 * fns.c (concat): Likewise.
8438 * frame.c (x_set_frame_parameters): Likewise.
8439 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8440 0 if not found, not -1. All callers changed.
8441
8442 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8443 (stack_copy_size): Now size_t, not int.
8444 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8445
8446 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8447
8448 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8449 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8450 All callers changed.
8451
8452 * lisp.h (multibyte_char_to_unibyte):
8453 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8454 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8455 * character.h (CHAR_TO_BYTE8):
8456 * cmds.c (internal_self_insert):
8457 * editfns.c (general_insert_function):
8458 * keymap.c (push_key_description):
8459 * search.c (Freplace_match):
8460 * xdisp.c (message_dolog, set_message_1): All callers changed.
8461
8462 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8463
8464 * keyboard.c (safe_run_hook_funcall): New function.
8465 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8466 don't set the hook to nil, but remove the offending function instead.
8467 (Qcommand_hook_internal): Remove, unused.
8468 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8469 Vcommand_hook_internal.
8470
8471 * eval.c (enum run_hooks_condition): Remove.
8472 (funcall_nil, funcall_not): New functions.
8473 (run_hook_with_args): Call each function through a `funcall' argument.
8474 Remove `cond' argument, now redundant.
8475 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8476 (Frun_hook_with_args_until_failure): Adjust accordingly.
8477 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8478
8479 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8480
8481 * dispextern.h (string_buffer_position): Remove declaration.
8482
8483 * print.c (strout): Remove parameter `multibyte', unused since
8484 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8485
8486 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8487 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8488 All callers changed.
8489
8490 * w32.c (_wsa_errlist): Use braces for struct initializers.
8491
8492 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8493 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8494 All callers changed.
8495 (string_buffer_position): Likewise. Also, make static (it's never
8496 used outside xdisp.c).
8497 (cursor_row_p): Remove parameter `w', unused since
8498 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8499 (decode_mode_spec): Remove parameter `precision', introduced during
8500 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8501 All callers changed.
8502
8503 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8504
8505 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8506
8507 2011-03-27 Anders Lindgren <andlind@gmail.com>
8508
8509 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8510 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8511 (ns_update_auto_hide_menu_bar): New functions.
8512 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8513 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8514 ns_constrain_all_frames.
8515 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8516 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8517
8518 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8519
8520 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8521
8522 2011-03-27 Glenn Morris <rgm@gnu.org>
8523
8524 * syssignal.h: Replace RETSIGTYPE with void.
8525 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8526 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8527 Replace SIGTYPE with void everywhere.
8528 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8529 * s/template.h (SIGTYPE): Remove commented out definition.
8530
8531 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8532
8533 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8534 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8535
8536 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8537
8538 * w32.c (read_unc_volume): Use parameter `henum', instead of
8539 global variable `wget_enum_handle'.
8540
8541 * keymap.c (describe_vector): Remove parameters `indices' and
8542 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8543 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8544
8545 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8546
8547 * keyboard.c (timer_check): Remove parameter `do_it_now',
8548 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8549 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8550 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8551
8552 * keyboard.c (read_char):
8553 * w32menu.c (w32_menu_display_help):
8554 * xmenu.c (show_help_event, menu_help_callback):
8555 Adjust calls to `show_help_echo'.
8556
8557 * gtkutil.c (xg_maybe_add_timer):
8558 * keyboard.c (readable_events):
8559 * process.c (wait_reading_process_output):
8560 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8561
8562 * insdel.c (adjust_markers_gap_motion):
8563 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8564 (gap_left, gap_right): Don't call it.
8565
8566 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8567
8568 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8569 incurred during fontification.
8570
8571 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8572
8573 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8574 (DEFVAR_PER_BUFFER): Don't pass it.
8575
8576 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8577 (scrolling_window): Don't pass it.
8578
8579 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8580
8581 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8582
8583 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8584 and `suffix'.
8585 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8586 of variables specific to SELinux and computation of `encoded_absname'.
8587
8588 * image.c (XPutPixel): Remove unused variable `height'.
8589
8590 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8591
8592 * unexw32.c (get_section_info): Remove unused variable `section'.
8593
8594 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8595 (system_process_attributes): Remove unused variable `sess'.
8596 (sys_read): Remove unused variable `err'.
8597
8598 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8599 (w32_wnd_proc): Remove unused variable `isdead'.
8600 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8601 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8602 (x_create_tip_frame): Remove unused variable `tem'.
8603
8604 * w32inevt.c (w32_console_read_socket):
8605 Remove unused variable `no_events'.
8606
8607 * w32term.c (x_draw_composite_glyph_string_foreground):
8608 Remove unused variable `width'.
8609
8610 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8611
8612 * w32term.c (x_set_glyph_string_clipping):
8613 Don't pass uninitialized region to CombineRgn.
8614
8615 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8616
8617 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8618 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8619 (Fx_close_connection): Remove unused variable `i'.
8620
8621 * w32font.c (w32font_draw): Return number of glyphs.
8622 (w32font_open_internal): Remove unused variable `i'.
8623 (w32font_driver): Add missing initializer.
8624
8625 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8626 (fill_in_menu): Remove unused variable `items_added'.
8627
8628 * w32term.c (last_mouse_press_frame): Remove static global variable.
8629 (w32_clip_to_row): Remove unused variable `f'.
8630 (x_delete_terminal): Remove unused variable `i'.
8631
8632 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8633 (NOTHING): Remove unused static global variable.
8634 (uniscribe_check_otf): Remove unused variable `table'.
8635 (uniscribe_font_driver): Add missing initializers.
8636
8637 2011-03-23 Julien Danjou <julien@danjou.info>
8638
8639 * term.c (Fsuspend_tty, Fresume_tty):
8640 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8641 * window.c (temp_output_buffer_show):
8642 * insdel.c (signal_before_change):
8643 * frame.c (Fhandle_switch_frame):
8644 * fileio.c (Fdo_auto_save):
8645 * emacs.c (Fkill_emacs):
8646 * editfns.c (save_excursion_restore):
8647 * cmds.c (internal_self_insert):
8648 * callint.c (Fcall_interactively):
8649 * buffer.c (Fkill_all_local_variables):
8650 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8651 Use Frun_hooks.
8652 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8653 unconditionally since it does the check itself.
8654
8655 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8656
8657 Fix more problems found by GCC 4.5.2's static checks.
8658
8659 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8660 the first time through the loop, since we know p0 < p1 then.
8661 This also avoids a gcc -Wstrict-overflow warning.
8662
8663 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8664 leading to a memory leak, possible in functions like
8665 load_charset_map_from_file that can allocate an unbounded number
8666 of objects (Bug#8318).
8667
8668 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8669 that could (at least in theory) be that large.
8670
8671 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8672 This is less likely to overflow, and avoids undefined behavior if
8673 overflow does occur. All callers changed. Use strtoul to scan
8674 for the unsigned long integer.
8675 (pint2hrstr): Simplify and tune code slightly.
8676 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8677
8678 * scroll.c (do_scrolling): Work around GCC bug 48228.
8679 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8680
8681 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8682 This also avoids a warning with gcc -Wstrict-overflow.
8683 (validate_x_resource_name): Simplify count usage.
8684 This also avoids a warning with gcc -Wstrict-overflow.
8685
8686 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8687 fail (Bug#8306).
8688
8689 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8690
8691 * process.c (Fmake_network_process): Use socklen_t, not int,
8692 where POSIX says socklen_t is required in portable programs.
8693 This fixes a porting bug on hosts like 64-bit HP-UX, where
8694 socklen_t is wider than int (Bug#8277).
8695 (Fmake_network_process, server_accept_connection):
8696 (wait_reading_process_output, read_process_output):
8697 Likewise.
8698
8699 * process.c: Rename or move locals to avoid shadowing.
8700 (list_processes_1, Fmake_network_process):
8701 (read_process_output_error_handler, exec_sentinel_error_handler):
8702 Rename or move locals.
8703 (Fmake_network_process): Define label "retry_connect" only if needed.
8704 (Fnetwork_interface_info): Fix pointer signedness.
8705 (process_send_signal): Add cast to avoid pointer signedness problem.
8706 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8707 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8708
8709 Make tparam.h and terminfo.c consistent.
8710 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8711 Include tparam.h instead, since it declares them.
8712 * cm.h (PC): Remove extern decl; tparam.h now does this.
8713 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8714 * terminfo.c: Include tparam.h, to check interfaces.
8715 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8716 (tparam): Adjust signature to match interface in tparam.h;
8717 this removes some undefined behavior. Check that outstring and len
8718 are zero, which they always are with Emacs.
8719 * tparam.h (PC, BC, UP): New extern decls.
8720
8721 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8722 (xftfont_open): Rename locals to avoid shadowing.
8723
8724 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8725 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8726 (OTF_TAG_SYM): Omit macro if not needed.
8727 (ftfont_list): Remove unused local.
8728 (get_adstyle_property, ftfont_pattern_entity):
8729 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8730 Rename locals to avoid shadowing.
8731
8732 * xfont.c (xfont_list_family): Mark var as initialized.
8733
8734 * xml.c (make_dom): Now static.
8735
8736 * composite.c (composition_compute_stop_pos): Rename local to
8737 avoid shadowing.
8738 (composition_reseat_it): Remove unused locals.
8739 (find_automatic_composition, composition_adjust_point): Likewise.
8740 (composition_update_it): Mark var as initialized.
8741 (find_automatic_composition): Mark vars as initialized,
8742 with a FIXME (Bug#8290).
8743
8744 character.h: Rename locals to avoid shadowing.
8745 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8746 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8747 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8748 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8749 to avoid shadowing.
8750
8751 * textprop.c (property_change_between_p): Remove; unused.
8752
8753 * intervals.c (interval_start_pos): Now static.
8754
8755 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8756
8757 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8758 Rename locals to avoid shadowing.
8759
8760 * sound.c (wav_play, au_play, Fplay_sound_internal):
8761 Fix pointer signedness.
8762 (alsa_choose_format): Remove unused local var.
8763 (wav_play): Initialize a variable to 0, to prevent undefined
8764 behavior (Bug#8278).
8765
8766 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8767
8768 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8769
8770 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8771 clobbering (Bug#8298).
8772 * sysdep.c (sys_subshell): Likewise.
8773 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8774
8775 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8776 This should get cleaned up, so that child_setup has the
8777 same signature on all platforms.
8778
8779 * callproc.c (call_process_cleanup): Now static.
8780 (relocate_fd): Rename locals to avoid shadowing.
8781
8782 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8783
8784 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8785 not to be necessary, and produces flickering.
8786
8787 2011-03-20 Glenn Morris <rgm@gnu.org>
8788
8789 * config.in: Remove file.
8790
8791 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8792
8793 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8794 are now in src/globals.h.
8795 (syms_of_minibuf): Remove spurious & from previous change.
8796
8797 2011-03-20 Leo Liu <sdl.web@gmail.com>
8798
8799 * minibuf.c (completing-read-function): New variable.
8800 (completing-read-default): Rename from completing-read.
8801 (completing-read): Call completing-read-function.
8802
8803 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8804
8805 * xfaces.c (Fx_load_color_file):
8806 Read color file from absolute filename (bug#8250).
8807
8808 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8809
8810 * makefile.w32-in: Update dependencies.
8811
8812 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8813
8814 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8815
8816 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8817
8818 Fix more problems found by GCC 4.5.2's static checks.
8819
8820 * process.c (make_serial_process_unwind, send_process_trap):
8821 (sigchld_handler): Now static.
8822
8823 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8824 That way, the code declares only the vars that it needs.
8825 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8826 * s/cygwin.h (PTY_ITERATION): Likewise.
8827 * s/darwin.h (PTY_ITERATION): Likewise.
8828 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8829
8830 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8831 * process.c (allocate_pty): Don't declare stb unless it's needed.
8832
8833 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8834 (CONSTANTLIM): Remove; unused.
8835 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8836 Define only if needed.
8837
8838 * unexelf.c (unexec): Name an expression,
8839 to avoid gcc -Wbad-function-cast warning.
8840 Use a different way to cause a compilation error if anyone uses
8841 n rather than nn, a way that does not involve shadowing.
8842 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8843
8844 * deps.mk (unexalpha.o): Remove; unused.
8845
8846 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8847 * unexec.h: New file.
8848 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8849 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8850 Depend on unexec.h.
8851 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8852 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8853 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8854 Change as necessary to match prototype in unexec.h.
8855
8856 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8857 shadowing.
8858 (back_comment, skip_chars): Mark vars as initialized.
8859
8860 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8861 Rename locals to avoid shadowing.
8862
8863 * lread.c (read1): Rewrite so as not to use empty "else".
8864 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8865
8866 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8867
8868 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8869 warning when compiling print.c.
8870
8871 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8872 instead of using an uninitialized var.
8873 (font_sort_entities): Mark var as initialized.
8874
8875 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8876
8877 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8878 pointers to constants.
8879 (font_parse_fcname): Remove unused vars.
8880 (font_delete_unmatched): Now static.
8881 (font_get_spec): Remove; unused.
8882 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8883 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8884 Rename or move locals to avoid shadowing.
8885
8886 * fns.c (require_nesting_list, require_unwind): Now static.
8887 (Ffillarray): Rename locals to avoid shadowing.
8888
8889 * floatfns.c (domain_error2): Define only if needed.
8890 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8891
8892 * alloc.c (mark_backtrace): Move decl from here ...
8893 * lisp.h: ... to here, so that it can be checked.
8894
8895 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8896 (Fdefvar): Rewrite so as not to use empty "else".
8897 (lisp_indirect_variable): Name an expression,
8898 to avoid gcc -Wbad-function-cast warning.
8899 (Fdefvar): Rename locals to avoid shadowing.
8900
8901 * callint.c (quotify_arg, quotify_args): Now static.
8902 (Fcall_interactively): Rename locals to avoid shadowing.
8903 Use const pointer when appropriate.
8904
8905 * lisp.h (get_system_name, get_operating_system_release):
8906 Move decls here, to check interfaces.
8907 * process.c (get_operating_system_release): Move decl to lisp.h.
8908 * xrdb.c (get_system_name): Likewise.
8909 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8910 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8911 some of which prompt warnings from gcc -Wbad-function-cast.
8912 (Fformat_time_string, Fencode_time, Finsert_char):
8913 (Ftranslate_region_internal, Fformat):
8914 Rename or remove local vars to avoid shadowing.
8915 (Ftranslate_region_internal): Mark var as initialized.
8916
8917 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8918 avoid shadowing.
8919
8920 * lisp.h (eassert): Check that the argument compiles, even if
8921 ENABLE_CHECKING is not defined.
8922
8923 * data.c (Findirect_variable): Name an expression, to avoid
8924 gcc -Wbad-function-cast warning.
8925 (default_value, arithcompare, arith_driver, arith_error): Now static.
8926 (store_symval_forwarding): Rename local to avoid shadowing.
8927 (Fmake_variable_buffer_local, Fmake_local_variable):
8928 Mark variables as initialized.
8929 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8930
8931 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8932 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8933 Rename locals to avoid shadowing.
8934 (mark_stack): Move local variables into the #ifdef region where
8935 they're used.
8936 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8937 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8938 needed otherwise.
8939 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8940 (GC_STRING_CHARS): Remove; not used.
8941 (Fmemory_limit): Cast sbrk's returned value to char *.
8942
8943 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8944 avoids undefined behavior in theory.
8945
8946 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8947
8948 Use functions, not macros, for up- and down-casing (Bug#8254).
8949 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8950 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8951 to use the following functions instead of these macros.
8952 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8953 EMACS_INT, since callers assume the returned value fits in int.
8954 (upcase1): Likewise, for UPCASE_TABLE.
8955 (uppercasep, lowercasep, upcase): New static inline functions.
8956 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8957 the race-condition problem in the old DOWNCASE.
8958
8959 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8960 Rename locals to avoid shadowing.
8961 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8962 (regex_compile, re_search_2, re_match_2_internal):
8963 Remove unused local vars.
8964 (FREE_VAR): Rewrite so as not to use empty "else",
8965 which gcc can warn about.
8966 (regex_compile, re_match_2_internal): Mark locals as initialized.
8967 (RETALLOC_IF): Define only if needed.
8968 (WORDCHAR_P): Likewise. This one is never needed, but is used
8969 only in a comment talking about a compiler bug, so put inside
8970 the #if 0 of that comment.
8971 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8972 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8973 Remove; unused.
8974
8975 * search.c (boyer_moore): Rename locals to avoid shadowing.
8976 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8977 (PREV_CHAR_BOUNDARY): Likewise.
8978
8979 * search.c (simple_search): Remove unused var.
8980
8981 * dired.c (compile_pattern): Move decl from here ...
8982 * lisp.h: ... to here, so that it can be checked.
8983 (struct re_registers): New forward decl.
8984
8985 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8986
8987 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8988 All uses changed.
8989 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8990 Rename locals to avoid shadowing.
8991 (Fvertical_motion): Mark locals as initialized.
8992
8993 * casefiddle.c (casify_object, casify_region): Now static.
8994 (casify_region): Mark local as initialized.
8995
8996 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8997
8998 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8999 New macros, so that the caller can use some names other than
9000 gcpro1, gcpro2, etc.
9001 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9002 of the new macros.
9003 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9004 argument, for consistency with GCPRO2_VAR, etc: it is now the
9005 prefix of the variable, not the variable itself. All uses
9006 changed.
9007 * dired.c (directory_files_internal, file_name_completion):
9008 Rename locals to avoid shadowing.
9009
9010 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9011 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9012 dired.c's scmp function, had undefined behavior.
9013 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9014 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9015 * buffer.h: ... to here, because these macros use current_buffer,
9016 and the new implementation with inline functions needs to have
9017 current_buffer in scope now, rather than later when the macros
9018 are used.
9019 (downcase, upcase1): New static inline functions.
9020 (DOWNCASE, UPCASE1): Reimplement using these functions.
9021 This avoids undefined behavior in expressions like
9022 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9023 from race conditions in accessing the global variables
9024 case_temp1 and case_temp2.
9025 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9026 * lisp.h (case_temp1, case_temp2): Remove their decls.
9027 * character.h (ASCII_CHAR_P): Move from here ...
9028 * lisp.h: ... to here, so that the inline functions mentioned
9029 above can use them.
9030
9031 * dired.c (directory_files_internal_unwind): Now static.
9032
9033 * fileio.c (file_name_as_directory, directory_file_name):
9034 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9035 Now static.
9036 (file_name_as_directory): Use const pointers when appropriate.
9037 (Fexpand_file_name): Likewise. In particular, newdir might
9038 point at constant storage, so make it a const pointer.
9039 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9040 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9041 signedness issues.
9042 (Fset_file_times, Finsert_file_contents, auto_save_error):
9043 Rename locals to avoid shadowing.
9044
9045 * minibuf.c (choose_minibuf_frame_1): Now static.
9046 (Ftry_completion, Fall_completions): Rename or remove locals
9047 to avoid shadowing.
9048
9049 * marker.c (bytepos_to_charpos): Remove; unused.
9050
9051 * lisp.h (verify_bytepos, count_markers): New decls,
9052 so that gcc does not warn that these functions aren't declared.
9053
9054 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9055 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9056 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9057 (copy_text): Remove unused local var.
9058
9059 * filelock.c (within_one_second): Now static.
9060 (lock_file_1): Rename local to avoid shadowing.
9061
9062 * buffer.c (fix_overlays_before): Mark locals as initialized.
9063 (fix_start_end_in_overlays): Likewise. This function should be
9064 simplified by using pointers-to-pointers, but that's a different
9065 matter.
9066 (switch_to_buffer_1): Now static.
9067 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9068 (report_overlay_modification): Rename locals to avoid shadowing.
9069
9070 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9071 Fix pointer signedness issue.
9072 (sys_subshell): Mark local as volatile if checking for lint,
9073 to suppress a gcc -Wclobbered warning that does not seem to be right.
9074 (MAXPATHLEN): Define only if needed.
9075
9076 * process.c (serial_open, serial_configure): Move decls from here ...
9077 * systty.h: ... to here, so that they can be checked.
9078
9079 * fns.c (get_random, seed_random): Move extern decls from here ...
9080 * lisp.h: ... to here, so that they can be checked.
9081
9082 * sysdep.c (reset_io): Now static.
9083 (wait_for_termination_signal): Remove; unused.
9084
9085 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9086 (copy_keymap_item, append_key, push_text_char_description):
9087 Now static.
9088 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9089 (DENSE_TABLE_SIZE): Remove; unused.
9090 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9091 (describe_map_tree):
9092 Rename locals to avoid shadowing.
9093
9094 * keyboard.c: Declare functions static if they are not used elsewhere.
9095 (echo_char, echo_dash, cmd_error, top_level_2):
9096 (poll_for_input, handle_async_input): Now static.
9097 (read_char, kbd_buffer_get_event, make_lispy_position):
9098 (make_lispy_event, make_lispy_movement, apply_modifiers):
9099 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9100 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9101 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9102 (read_key_sequence, read_char): Mark locals as initialized.
9103 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9104
9105 * keyboard.h (make_ctrl_char): New decl.
9106 (mark_kboards): Move decl here ...
9107 * alloc.c (mark_kboards): ... from here.
9108
9109 * lisp.h (force_auto_save_soon): New decl.
9110
9111 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9112 (DEFINE_DUMMY_FUNCTION): New macro.
9113 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9114 Use it.
9115 (main): Add casts to avoid warnings
9116 if GCC considers string literals to be constants.
9117
9118 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9119
9120 * dbusbind.c: Pointer signedness fixes.
9121 (xd_signature, xd_append_arg, xd_initialize):
9122 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9123 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9124 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9125 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9126
9127 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9128 if GCC considers string literals to be constants.
9129 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9130
9131 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9132
9133 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9134 (print_preprocess, print_object): New macro to fix last change.
9135
9136 * print.c (print_preprocess): Don't forget font objects.
9137
9138 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9139
9140 * emacs.c (USAGE3): Doc fixes.
9141
9142 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9143
9144 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9145 structure.
9146
9147 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9148
9149 * lisp.h (VWindow_system, Qfile_name_history):
9150 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9151 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9152 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9153
9154 * w32select.c: Don't #include "keyboard.h".
9155 (run_protected): Add extern declaration for waiting_for_input.
9156
9157 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9158 * w32console.c (detect_input_pending, read_input_pending)
9159 (encode_terminal_code):
9160 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9161 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9162 (w32_system_caret_y, Qfile_name_history):
9163 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9164 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9165 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9166 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9167 * w32proc.c (Qlocal, report_file_error):
9168 * w32term.c (Vwindow_system, updating_frame):
9169 * w32uniscribe.c (initialized, uniscribe_font_driver):
9170 Remove unneeded extern declarations.
9171
9172 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9173
9174 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9175
9176 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9177
9178 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9179 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9180 These macros can no longer be used for assignment.
9181
9182 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9183 Assign struct members directly, instead of using BUF_BEGV etc.
9184 (record_buffer_markers, fetch_buffer_markers): New functions for
9185 recording and fetching special buffer markers.
9186 (set_buffer_internal_1, set_buffer_temp): Use them.
9187
9188 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9189
9190 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9191
9192 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9193 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9194
9195 * xdisp.c (hscroll_window_tree):
9196 (reconsider_clip_changes): Use PT instead of BUF_PT.
9197
9198 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9199
9200 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9201 $(EMACS_ROOT)/lib/intprops.h.
9202
9203 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9204
9205 Fix more problems found by GCC 4.5.2's static checks.
9206
9207 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9208 to unsigned char * to avoid compiler diagnostic.
9209 (xg_free_frame_widgets): Make it clear that a local variable is
9210 needed only if USE_GTK_TOOLTIP.
9211 (gdk_window_get_screen): Make it clear that this macro is needed
9212 only if USE_GTK_TOOLTIP.
9213 (int_gtk_range_get_value): New function, which avoids a diagnostic
9214 from gcc -Wbad-function-cast.
9215 (xg_set_toolkit_scroll_bar_thumb): Use it.
9216 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9217 diagnostic from gcc -Wbad-function-cast.
9218 (get_utf8_string, xg_get_file_with_chooser):
9219 Rename locals to avoid shadowing.
9220 (create_dialog): Move locals to avoid shadowing.
9221
9222 * xgselect.c (xg_select): Remove unused var.
9223
9224 * image.c (four_corners_best): Mark locals as initialized.
9225 (gif_load): Initialize transparent_p to zero (Bug#8238).
9226 Mark another local as initialized.
9227 (my_png_error, my_error_exit): Mark with NO_RETURN.
9228
9229 * image.c (clear_image_cache): Now static.
9230 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9231 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9232 (x_edge_detection): Remove unnecessary cast that
9233 gcc -Wbad-function-cast diagnoses.
9234 (gif_load): Fix pointer signedness.
9235 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9236 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9237
9238 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9239
9240 Improve quality of tests for time stamp overflow.
9241 For example, without this patch (encode-time 0 0 0 1 1
9242 1152921504606846976) returns the obviously-bogus value (-948597
9243 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9244 reports time overflow. See
9245 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9246 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9247 * editfns.c: Include limits.h and intprops.h.
9248 (TIME_T_MIN, TIME_T_MAX): New macros.
9249 (time_overflow): Move earlier, to before first use.
9250 (hi_time, lo_time): New functions, for an accurate test for
9251 out-of-range times.
9252 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9253 (Fget_internal_run_time): Don't assume time_t fits in int.
9254 (make_time): Use list2 instead of Fcons twice.
9255 (Fdecode_time): More accurate test for out-of-range times.
9256 (check_tm_member): New function.
9257 (Fencode_time): Use it, to test for out-of-range times.
9258 (lisp_time_argument): Don't rely on undefined left-shift and
9259 right-shift behavior when checking for time stamp overflow.
9260
9261 * editfns.c (time_overflow): New function, refactoring common code.
9262 (Fformat_time_string, Fdecode_time, Fencode_time):
9263 (Fcurrent_time_string): Use it.
9264
9265 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9266 * dired.c (make_time): Move to ...
9267 * editfns.c (make_time): ... here.
9268 * systime.h: Note the move.
9269
9270 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9271
9272 * fringe.c (update_window_fringes): Remove unused variables.
9273
9274 * unexmacosx.c (copy_data_segment): Also copy __got section.
9275 (Bug#8223)
9276
9277 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9278
9279 * termcap.c [MSDOS]: Include "msdos.h".
9280 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9281 Constify `char *' arguments and their references according to
9282 prototypes in tparam.h.
9283
9284 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9285
9286 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9287 Adapt all references accordingly.
9288
9289 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9290
9291 2011-03-11 Tom Tromey <tromey@redhat.com>
9292
9293 * buffer.c (syms_of_buffer): Remove obsolete comment.
9294
9295 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9296
9297 * termhooks.h (encode_terminal_code): Declare prototype.
9298
9299 * msdos.c (encode_terminal_code): Don't declare prototype.
9300
9301 * term.c (encode_terminal_code): Now external again, used by
9302 w32console.c and msdos.c.
9303
9304 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9305 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9306
9307 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9308
9309 Fix some minor problems found by GCC 4.5.2's static checks.
9310
9311 * fringe.c (update_window_fringes): Mark locals as initialized
9312 (Bug#8227).
9313 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9314
9315 * alloc.c (mark_fringe_data): Move decl from here ...
9316 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9317 to check its interface.
9318 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9319
9320 * fontset.c (free_realized_fontset): Now static.
9321 (Fset_fontset_font): Rename local to avoid shadowing.
9322 (fontset_font): Mark local as initialized.
9323 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9324
9325 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9326
9327 * xselect.c (x_disown_buffer_selections): Remove; not used.
9328 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9329 (x_own_selection, Fx_disown_selection_internal): Rename locals
9330 to avoid shadowing.
9331 (x_handle_dnd_message): Remove local to avoid shadowing.
9332
9333 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9334 so that the caller can use some name other than gcpro1.
9335 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9336 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9337 (Fx_backspace_delete_keys_p):
9338 Use them to avoid shadowing, and rename vars to avoid shadowing.
9339 (x_decode_color, x_set_name, x_window): Now static.
9340 (Fx_create_frame): Add braces to silence GCC warning.
9341 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9342 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9343 Remove unused locals.
9344 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9345 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9346 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9347 macros.
9348
9349 * xterm.h (x_mouse_leave): New decl.
9350
9351 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9352 Remove unused functions.
9353 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9354 (x_calc_absolute_position): Now static.
9355 (XTread_socket): Don't define label "out" unless it's used.
9356 Don't declare local "event" unless it's used.
9357 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9358 unless they are used.
9359 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9360 (x_fatal_error_signal): Remove; not used.
9361 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9362 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9363 (x_error_catcher, x_connection_closed, x_error_handler):
9364 (x_error_quitter, xembed_send_message, x_iconify_frame):
9365 (my_log_handler): Rename locals to avoid shadowing.
9366 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9367 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9368
9369 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9370 Rename or move locals to avoid shadowing.
9371 (tty_defined_color, merge_face_heights): Now static.
9372 (free_realized_faces_for_fontset): Remove; not used.
9373 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9374 does not deduce is never used uninitialized.
9375 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9376 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9377
9378 * terminal.c (store_terminal_param): Now static.
9379
9380 * xmenu.c (menu_highlight_callback): Now static.
9381 (set_frame_menubar): Remove unused local.
9382 (xmenu_show): Rename parameter to avoid shadowing.
9383 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9384 since they might point to immutable storage.
9385 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9386 since it's unused otherwise.
9387
9388 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9389 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9390 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9391 avoids a gcc -Wuninitialized diagnostic.
9392 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9393 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9394 does not deduce are never used uninitialized.
9395
9396 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9397
9398 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9399 * window.c (window_loop, size_window):
9400 (run_window_configuration_change_hook, enlarge_window): Likewise.
9401
9402 * window.c (display_buffer): Now static.
9403 (size_window): Mark variables that gcc -Wuninitialized
9404 does not deduce are never used uninitialized.
9405 * window.h (check_all_windows): New decl, to forestall
9406 gcc -Wmissing-prototypes diagnostic.
9407 * dispextern.h (bidi_dump_cached_states): Likewise.
9408
9409 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9410 shadowing.
9411 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9412 Include <limits.h>.
9413 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9414 and to avoid gcc -Wuninitialized warning.
9415 (load_charset_map): Mark variables that gcc -Wuninitialized
9416 does not deduce are never used uninitialized.
9417 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9418
9419 * coding.c (coding_set_source, coding_set_destination):
9420 Use "else { /* comment */ }" rather than "else /* comment */;"
9421 for clarity, and to avoid gcc -Wempty-body warning.
9422 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9423 a block, when the outer 'i' will do.
9424 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9425 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9426 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9427 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9428 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9429 Rename locals to avoid shadowing.
9430 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9431 * coding.c (emacs_mule_char, encode_invocation_designation):
9432 Now static, since they're not used elsewhere.
9433 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9434 (decode_coding_object, encode_coding_object, detect_coding_system):
9435 (decode_coding_emacs_mule): Mark variables that gcc
9436 -Wuninitialized does not deduce are never used uninitialized.
9437 (detect_coding_iso_2022): Initialize a local variable that might
9438 be used uninitialized. Leave a FIXME because it's not clear that
9439 this initialization is needed. (Bug#8211)
9440 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9441 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9442 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9443 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9444 Remove unused macros.
9445
9446 * category.c (hash_get_category_set): Remove unused local var.
9447 (copy_category_table): Now static, since it's not used elsewhere.
9448 * character.c (string_count_byte8): Likewise.
9449
9450 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9451 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9452
9453 * chartab.c (copy_sub_char_table): Now static, since it's not used
9454 elsewhere.
9455 (sub_char_table_ref_and_range, char_table_ref_and_range):
9456 Rename locals to avoid shadowing.
9457 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9458
9459 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9460 (BIDI_BOB): Remove unused macro.
9461
9462 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9463 deduce are never used uninitialized.
9464 * term.c (encode_terminal_code): Likewise.
9465
9466 * term.c (encode_terminal_code): Now static. Remove unused local.
9467
9468 * tparam.h: New file.
9469 * term.c, tparam.h: Include it.
9470 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9471 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9472 Move these decls to tparam.h, and make them agree with what
9473 is actually in tparam.c. The previous trick of using incompatible
9474 decls in different modules does not conform to the C standard.
9475 All callers of tparam changed to use tparam's actual API.
9476 * tparam.c (tparam1, tparam, tgoto):
9477 Use const pointers where appropriate.
9478
9479 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9480 * cm.h (struct cm): Likewise.
9481 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9482 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9483 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9484 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9485 (turn_on_face, init_tty): Likewise.
9486 * termchar.h (struct tty_display_info): Likewise.
9487
9488 * term.c (term_mouse_position): Rename local to avoid shadowing.
9489
9490 * alloc.c (mark_ttys): Move decl from here ...
9491 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9492
9493 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9494
9495 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9496
9497 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9498
9499 * search.c (compile_pattern_1): Remove argument regp, unused since
9500 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9501 (compile_pattern): Don't pass it.
9502
9503 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9504
9505 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9506 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9507 for ! HAVE_GTK3.
9508 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9509
9510 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9511
9512 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9513 gdk_window_get_screen, gdk_window_get_geometry,
9514 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9515 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9516 (xg_get_pixbuf_from_pixmap): New function.
9517 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9518 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9519 Call xg_get_pixbuf_from_pixmap instead of
9520 gdk_pixbuf_get_from_drawable.
9521 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9522 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9523 (xg_check_special_colors): Use GtkStyleContext and its functions
9524 for HAVE_GTK3.
9525 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9526 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9527 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9528 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9529 Call gtk_widget_get_preferred_size.
9530 (xg_frame_resized): gdk_window_get_geometry only takes 5
9531 parameters.
9532 (xg_win_to_widget, xg_event_is_for_menubar):
9533 Call gdk_x11_window_lookup_for_display.
9534 (xg_set_widget_bg): New function.
9535 (delete_cb): New function.
9536 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9537 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9538 (xg_set_background_color): Call xg_set_widget_bg.
9539 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9540 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9541 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9542 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9543 if ! HAVE_GTK3.
9544 (update_frame_tool_bar): Call gtk_widget_hide.
9545 (xg_initialize): Use GDK_KEY_g.
9546
9547 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9548 if ! HAVE_GTK3
9549 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9550
9551 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9552 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9553 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9554
9555 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9556
9557 * w32xfns.c (select_palette): Check success of RealizePalette against
9558 GDI_ERROR, not zero.
9559
9560 See ChangeLog.11 for earlier changes.
9561
9562 ;; Local Variables:
9563 ;; coding: utf-8
9564 ;; End:
9565
9566 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9567
9568 This file is part of GNU Emacs.
9569
9570 GNU Emacs is free software: you can redistribute it and/or modify
9571 it under the terms of the GNU General Public License as published by
9572 the Free Software Foundation, either version 3 of the License, or
9573 (at your option) any later version.
9574
9575 GNU Emacs is distributed in the hope that it will be useful,
9576 but WITHOUT ANY WARRANTY; without even the implied warranty of
9577 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9578 GNU General Public License for more details.
9579
9580 You should have received a copy of the GNU General Public License
9581 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.