1 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3 * indent.c (Fvertical_motion): Set and restore w->pointm when
4 saving and restoring the window's buffer (Bug#9006).
6 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8 * editfns.c (Fstring_to_char): Clarify just what is returned
9 (bug#6576). Text by Eli Zaretskii.
11 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
13 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
15 2011-07-13 Eli Zaretskii <eliz@gnu.org>
17 * buffer.c (mmap_find): Fix a typo.
19 2011-07-13 Johan Bockgård <bojohan@gnu.org>
21 Fix execution of x selection hooks.
22 * xselect.c (Qx_lost_selection_functions)
23 (Qx_sent_selection_functions): New vars.
24 (syms_of_xselect): DEFSYM them.
25 (x_handle_selection_request): Pass Qx_sent_selection_functions
26 rather than Vx_sent_selection_functions to Frun_hook_with_args.
27 (x_handle_selection_clear,x_clear_frame_selections):
28 Pass Qx_lost_selection_functions rather than
29 Vx_lost_selection_functions to Frun_hook_with_args.
31 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
33 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
34 The old code sometimes used this field without initializing it.
36 * alloc.c (gc_sweep): Don't read past end of array.
37 In theory, the old code could also have corrupted Emacs internals,
38 though it'd be very unlikely.
40 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
42 * character.c (Fcharacterp): Don't advertise optional ignored
45 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
47 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
50 * window.c (Fset_window_start): Doc fix (bug#4199).
51 (Fset_window_hscroll): Ditto.
53 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
55 Fix minor new problems caught by GCC 4.6.1.
56 * term.c (init_tty): Remove unused local.
57 * xsettings.c (store_monospaced_changed): Define this function only
58 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
61 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
63 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
65 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
67 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
68 are the mini-buffer and the echo area (bug#3320).
70 * term.c (init_tty): Remove support for supdup, c10 and perq
71 terminals, which are no longer supported (bug#1482).
73 2011-07-10 Johan Bockgård <bojohan@gnu.org>
75 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
77 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
79 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
80 for non-popups (Bug#3642).
82 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
84 * alloc.c (reset_malloc_hooks): Protoize.
85 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
86 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
87 * cm.c (losecursor): Likewise.
88 * data.c (fmod): Likewise.
89 * dispnew.c (swap_glyphs_in_rows): Likewise.
90 * emacs.c (memory_warning_signal): Likewise.
91 * floatfns.c (float_error): Likewise.
92 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
93 (otf_open, font_otf_capability, generate_otf_features)
94 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
96 * image.c (pbm_read_file): Likewise.
97 * indent.c (string_display_width): Likewise.
98 * intervals.c (check_for_interval, search_for_interval)
99 (inc_interval_count, count_intervals, root_interval)
100 (adjust_intervals_for_insertion, make_new_interval): Likewise.
101 * lread.c (defalias): Likewise.
102 * ralloc.c (r_alloc_check): Likewise.
103 * regex.c (set_image_of_range_1, set_image_of_range)
104 (regex_grow_registers): Likewise.
105 * sysdep.c (strerror): Likewise.
106 * termcap.c (valid_filename_p, tprint, main): Likewise.
107 * tparam.c (main): Likewise.
108 * unexhp9k800.c (run_time_remap, save_data_space)
109 (update_file_ptrs, read_header, write_header, calculate_checksum)
110 (copy_file, copy_rest, display_header): Likewise.
111 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
113 * xdisp.c (check_it): Likewise.
114 * xfaces.c (register_color, unregister_color, unregister_colors):
116 * xfns.c (print_fontset_result): Likewise.
117 * xrdb.c (member, fatal, main): Likewise.
119 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
121 Fix minor problems found by static checking (Bug#9031).
122 * chartab.c (char_table_set_range, map_sub_char_table):
123 Remove unused locals.
124 (uniprop_table): Now static.
125 * composite.c (_work_char): Remove unused static var.
127 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
129 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
131 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
133 * gtkutil.c (qttip_cb): Remove code without function.
135 2011-07-09 Eli Zaretskii <eliz@gnu.org>
137 * w32.c (pthread_sigmask): New stub.
139 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
141 Use pthread_sigmask, not sigprocmask (Bug#9010).
142 sigprocmask is portable only for single-threaded applications, and
143 Emacs can be multi-threaded when it uses GTK.
144 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
146 * callproc.c (Fcall_process):
147 * process.c (create_process):
148 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
149 Use pthread_sigmask, not sigprocmask.
151 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
153 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
154 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
157 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
159 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
160 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
161 (xg_hide_tooltip): Fix comment.
163 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
164 in registerServicesMenuSendTypes.
165 (validRequestorForSendType): Don't check ns_return_types.
167 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
170 2011-07-08 Jason Rumney <jasonr@gnu.org>
172 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
173 frame struct members of non-existent frames (Bug#6284).
175 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
177 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
178 variable firstTime not needed on OSX >= 10.6.
179 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
180 >= 10.5. Use setKnobProportion, setDoubleValue.
182 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
183 (MAC_OS_X_VERSION_10_5): Define if not defined.
184 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
185 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
186 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
188 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
189 cString and lossyCString on OSX >= 10.4
191 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
192 sizeToFit on OSX >= 10.2.
194 * nsimage.m (allocInitFromFile): Don't use deprecated method
195 bestRepresentationForDevice on OSX >= 10.6.
197 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
200 * emacs.c: Declare unexec_init_emacs_zone.
202 * nsgui.h: Fix compiler warning about gnulib redefining verify.
204 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
206 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
207 on svcsMenu (Bug#8842).
209 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
211 (Fns_list_services): Just return Qnil on 10.6, code not working there.
213 * nsterm.m (QUTF8_STRING): Declare.
214 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
215 (validRequestorForSendType): Return type is (id).
216 Change indexOfObjectIdenticalTo to indexOfObject.
217 Check if we have local selection before returning self (Bug#8842).
218 (writeSelectionToPasteboard): Put local selection into paste board
219 if we have a local selection (Bug#8842).
220 (syms_of_nsterm): DEFSYM QUTF8_STRING.
222 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
223 (ns_get_local_selection): Declare.
225 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
227 * keymap.c (describe_map_tree): Don't insert a double newline at
228 the end of the buffer (bug#1169) and return whether we inserted
231 * callint.c (Fcall_interactively): Change "reading args" to
232 "providing args" to try to clarify what it does (bug#1010).
234 2011-07-07 Kenichi Handa <handa@m17n.org>
236 * composite.c (composition_compute_stop_pos): Ignore a static
237 composition starting before CHARPOS (Bug#8915).
239 * xdisp.c (handle_composition_prop): Likewise.
241 2011-07-07 Eli Zaretskii <eliz@gnu.org>
243 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
246 2011-07-07 Kenichi Handa <handa@m17n.org>
248 * character.h (unicode_category_t): New enum type.
250 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
251 (Qchar_code_property_table): New variable.
252 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
253 (UNIPROP_COMPRESSED_FORM_P): New macros.
254 (char_table_ascii): Uncompress the compressed values.
255 (sub_char_table_ref): New arg is_uniprop. Callers changed.
256 Uncompress the compressed values.
257 (sub_char_table_ref_and_range): Likewise.
258 (char_table_ref_and_range): Uncompress the compressed values.
259 (sub_char_table_set): New arg is_uniprop. Callers changed.
260 Uncompress the compressed values.
261 (sub_char_table_set_range): Args changed. Callers changed.
262 (char_table_set_range): Adjuted for the above change.
263 (map_sub_char_table): Delete args default_val and parent. Add arg
264 top. Give decoded values to a Lisp function.
265 (map_char_table): Adjusted for the above change. Give decoded
266 values to a Lisp function. Gcpro more variables.
267 (uniprop_table_uncompress)
268 (uniprop_decode_value_run_length): New functions.
269 (uniprop_decoder, uniprop_decoder_count): New variables.
270 (uniprop_get_decoder, uniprop_encode_value_character)
271 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
273 (uniprop_encoder, uniprop_encoder_count): New variables.
274 (uniprop_get_encoder, uniprop_table)
275 (Funicode_property_table_internal, Fget_unicode_property_internal)
276 (Fput_unicode_property_internal): New functions.
277 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
278 Sunicode_property_table_internal, Sget_unicode_property_internal,
279 and Sput_unicode_property_internal. Defvar_lisp
280 char-code-property-alist.
282 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
283 Vunicode_category_table.
285 * font.c (font_range): Adjusted for the change of
286 Vunicode_category_table.
288 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
290 * m/iris4d.h: Remove file, move contents ...
291 * s/irix6-5.h: ... here.
293 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
295 Remove unportable assumption about struct layout (Bug#8884).
296 * alloc.c (mark_buffer):
297 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
298 (clone_per_buffer_values): Don't assume that
299 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
300 This isn't true in general, and it's particularly not true
301 if Emacs is configured with --with-wide-int.
302 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
303 New macros, used in the buffer.c change.
305 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
307 * xsettings.c: Use both GConf and GSettings if both are available.
308 (store_config_changed_event): Add comment.
309 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
310 (store_tool_bar_style_changed): New functions.
311 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
312 (struct xsettings): Move font inside HAVE_XFT.
313 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
314 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
315 Move inside HAVE_XFT.
316 (something_changed_gsettingsCB): Renamed from something_changedCB.
317 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
319 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
320 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
321 (something_changed_gconfCB): Renamed from something_changedCB.
322 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
323 (parse_settings): Move check for font inside HAVE_XFT.
324 (read_settings, apply_xft_settings): Add comment.
325 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
326 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
327 call store_font_name_changed.
328 (xft_settings_event): Add comment.
329 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
330 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
331 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
332 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
333 (xsettings_initialize): Call init_gsettings last.
334 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
337 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
339 Random fixes. E.g., (random) never returned negative values.
340 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
341 subseconds part to the entropy, as that's a bit more random.
342 Prefer signed to unsigned, since the signedness doesn't matter and
343 in general we prefer signed. When given a limit, use a
344 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
345 latter isn't right if USE_2_TAGS_FOR_INTS.
346 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
347 not 0..VALMASK. Don't discard "excess" bits that random () returns.
349 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
351 * textprop.c (text_property_stickiness):
352 Obey Vtext_property_default_nonsticky.
353 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
354 * w32fns.c (syms_of_w32fns):
355 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
357 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
359 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
360 This is more efficient than Ffile_directory_p and avoids a minor race.
362 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
364 * buffer.c (Foverlay_put): Say what the return value is
367 * fileio.c (barf_or_query_if_file_exists): Check first if the file
368 is a directory before asking whether to use the file name
370 (barf_or_query_if_file_exists): Make the "File is a directory"
371 error be more correct.
373 * fns.c (Frequire): Remove the mention of the .gz files, since
374 that's installation-specific, but keep the mention of
377 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
379 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
380 Report string overflow if the output is too long.
382 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
384 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
385 (syms_of_gnutls): Remove duplicate DEFSYM for
386 Qgnutls_bootprop_verify_hostname_error, an error for
387 Qgnutls_bootprop_verify_error (which is no longer used).
389 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
390 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
391 Also (re)move comments that are misplaced or no longer relevant.
393 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
395 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
397 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
399 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
400 and background color parameters if they have been changed.
402 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
404 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
406 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
408 * xsettings.c (SYSTEM_FONT): Define only when used.
409 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
411 * keymap.c (access_keymap_1): Now static.
413 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
415 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
416 leave any prefix arg for the up event (Bug#1586).
418 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
420 * lread.c (syms_of_lread): Mention single symbols defined by
421 `defvar' or `defconst' (bug#7154).
423 * fns.c (Frequire): Mention .el.gz files (bug#7314).
424 (Frequire): Mention get-load-suffixes.
426 2011-07-02 Martin Rudalics <rudalics@gmx.at>
428 * window.h (window): Remove clone_number slot.
429 * window.c (Fwindow_clone_number, Fset_window_clone_number):
431 (make_parent_window, make_window, saved_window)
432 (Fset_window_configuration, save_window_save): Don't deal with
434 * buffer.c (Qclone_number): Remove declaration.
435 (sort_overlays, overlay_strings): Don't deal with clone numbers.
437 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
439 Add multiple inheritance to keymaps.
440 * keymap.c (Fmake_composed_keymap): New function.
441 (Fset_keymap_parent): Simplify.
442 (fix_submap_inheritance): Remove.
443 (access_keymap_1): New function extracted from access_keymap to handle
444 embedded parents and handle lists of maps.
445 (access_keymap): Use it.
446 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
447 (Fcopy_keymap): Handle embedded parents.
448 (Fcommand_remapping, define_as_prefix): Simplify.
449 (Fkey_binding): Simplify.
450 (syms_of_keymap): Move minibuffer-local-completion-map,
451 minibuffer-local-filename-completion-map,
452 minibuffer-local-must-match-map, and
453 minibuffer-local-filename-must-match-map to Elisp.
454 (syms_of_keymap): Defsubr make-composed-keymap.
455 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
456 (parse_menu_item): Trivial simplification.
458 2011-07-01 Glenn Morris <rgm@gnu.org>
460 * Makefile.in (SETTINGS_LIBS): Fix typo.
462 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
464 * coding.c (Fencode_coding_string): Record the last coding system
465 used, as the function doc string says (bug#8738).
467 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
469 * xsettings.c (store_monospaced_changed): Take new font as arg and
470 check for change against current_mono_font.
471 (EMACS_TYPE_SETTINGS): Remove this and related defines.
472 (emacs_settings_constructor, emacs_settings_get_property)
473 (emacs_settings_set_property, emacs_settings_class_init)
474 (emacs_settings_init, gsettings_obj): Remove.
475 (something_changedCB): New function for HAVE_GSETTINGS.
476 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
477 with value as argument.
478 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
479 g_settings_new (Bug#8967). Do not create gsettings_obj.
480 Remove calls to g_settings_bind. Connect something_changedCB to
483 * xgselect.c: Add defined (HAVE_GSETTINGS).
484 (xgselect_initialize): Ditto.
486 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
487 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
490 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
492 * eval.c (struct backtrace): Simplify and port the data structure.
493 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
494 signed bit field, as this assumption is not portable and it makes
495 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
496 "char debug_on_exit : 1" as this is not portable either; instead,
497 use the portable "unsigned int debug_on_exit : 1". Remove unused
498 member evalargs. Remove obsolete comments about cc bombing out.
500 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
502 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
503 Let HAVE_GSETTINGS override HAVE_GCONF.
504 (store_monospaced_changed): New function.
505 (EMACS_SETTINGS): A new type derived from GObject to handle
506 GSettings notifications.
507 (emacs_settings_constructor, emacs_settings_get_property)
508 (emacs_settings_set_property, emacs_settings_class_init):
510 (gsettings_client, gsettings_obj): New variables.
511 (GSETTINGS_SCHEMA): New define.
512 (something_changedCB): Call store_monospaced_changed.
513 (init_gsettings): New function.
514 (xsettings_initialize): Call init_gsettings.
515 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
518 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
521 2011-06-29 Martin Rudalics <rudalics@gmx.at>
523 * window.c (resize_root_window, grow_mini_window)
524 (shrink_mini_window): Rename Qresize_root_window to
525 Qwindow_resize_root_window and Qresize_root_window_vertically to
526 Qwindow_resize_root_window_vertically.
528 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
530 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
532 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
534 * makefile.w32-in: Redesign dependencies so they reflect more
535 clearly which files are directly included by each source file,
536 and not through other includes.
538 2011-06-27 Martin Rudalics <rudalics@gmx.at>
540 * buffer.c (Qclone_number): Declare static and DEFSYM it.
541 (sort_overlays, overlay_strings): When an overlay's clone number
542 matches the window's clone number process the overlay even if
543 the overlay's window property doesn't match the current window.
545 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
546 (Fwindow_hchild): Rename to Fwindow_left_child.
547 (Fwindow_next): Rename to Fwindow_next_sibling.
548 (Fwindow_prev): Rename to Fwindow_prev_sibling.
549 (resize_window_check): Rename to window_resize_check.
550 (resize_window_apply): Rename to window_resize_apply.
551 (Fresize_window_apply): Rename to Fwindow_resize_apply.
552 (Fdelete_other_windows_internal, resize_frame_windows)
553 (Fsplit_window_internal, Fdelete_window_internal)
554 (grow_mini_window, shrink_mini_window)
555 (Fresize_mini_window_internal): Fix callers accordingly.
557 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
559 * emacsgtkfixed.h: State that this is only used with Gtk+3.
560 (emacs_fixed_set_min_size): Remove.
561 (emacs_fixed_new): Take frame as argument.
563 * emacsgtkfixed.c: State that this is only used with Gtk+3.
564 (_EmacsFixedPrivate): Remove minwidth/height.
566 (emacs_fixed_init): Initialize priv->f.
567 (get_parent_class, emacs_fixed_set_min_size): Remove.
568 (emacs_fixed_new): Set priv->f to argument.
569 (emacs_fixed_get_preferred_width)
570 (emacs_fixed_get_preferred_height): Use min_width/height from
571 frames size_hint to set minimum and natural (Bug#8919).
572 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
573 and use min_width/height from frames size_hint to set
574 min_width/height (Bug#8919).
576 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
577 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
580 2011-06-26 Eli Zaretskii <eliz@gnu.org>
582 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
583 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
586 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
588 * process.c (wait_reading_process_output): Bypass select if
589 waiting for a cell while ignoring keyboard input, and input is
590 pending. Suggested by Jan Djärv (Bug#8869).
592 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
594 Use gnulib's dup2 module instead of rolling our own.
595 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
597 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
599 * dispnew.c (scrolling_window): Before scrolling, turn off a
600 mouse-highlight in the window being scrolled.
602 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
604 Move DEFSYM to lisp.h and use everywhere.
606 * character.h (DEFSYM): Move declaration...
607 * lisp.h (DEFSYM): ...here.
613 * w32select.c: Don't include character.h.
615 * alloc.c (syms_of_alloc):
616 * buffer.c (syms_of_buffer):
617 * bytecode.c (syms_of_bytecode):
618 * callint.c (syms_of_callint):
619 * casefiddle.c (syms_of_casefiddle):
620 * casetab.c (init_casetab_once):
621 * category.c (init_category_once, syms_of_category):
622 * ccl.c (syms_of_ccl):
623 * cmds.c (syms_of_cmds):
624 * composite.c (syms_of_composite):
625 * dbusbind.c (syms_of_dbusbind):
626 * dired.c (syms_of_dired):
627 * dispnew.c (syms_of_display):
628 * doc.c (syms_of_doc):
629 * editfns.c (syms_of_editfns):
630 * emacs.c (syms_of_emacs):
631 * eval.c (syms_of_eval):
632 * fileio.c (syms_of_fileio):
633 * fns.c (syms_of_fns):
634 * frame.c (syms_of_frame):
635 * fringe.c (syms_of_fringe):
636 * insdel.c (syms_of_insdel):
637 * keymap.c (syms_of_keymap):
638 * lread.c (init_obarray, syms_of_lread):
639 * macros.c (syms_of_macros):
640 * msdos.c (syms_of_msdos):
641 * print.c (syms_of_print):
642 * process.c (syms_of_process):
643 * search.c (syms_of_search):
644 * sound.c (syms_of_sound):
645 * syntax.c (init_syntax_once, syms_of_syntax):
646 * terminal.c (syms_of_terminal):
647 * textprop.c (syms_of_textprop):
648 * undo.c (syms_of_undo):
649 * w32.c (globals_of_w32):
650 * window.c (syms_of_window):
651 * xdisp.c (syms_of_xdisp):
652 * xfaces.c (syms_of_xfaces):
653 * xfns.c (syms_of_xfns):
654 * xmenu.c (syms_of_xmenu):
655 * xsettings.c (syms_of_xsettings):
656 * xterm.c (syms_of_xterm): Use DEFSYM.
658 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
660 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
662 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
664 Integer and buffer overflow fixes (Bug#8873).
666 * print.c (printchar, strout): Check for string overflow.
667 (PRINTPREPARE, printchar, strout):
668 Don't set size unless allocation succeeds.
670 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
671 for sizes. Check for string overflow more accurately.
672 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
674 * macros.c: Integer and buffer overflow fixes.
675 * keyboard.h (struct keyboard.kbd_macro_bufsize):
676 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
677 Use ptrdiff_t, not int, for sizes.
678 Don't increment bufsize until after realloc succeeds.
679 Check for size-calculation overflow.
680 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
682 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
684 * lread.c: Integer overflow fixes.
685 (read_integer): Radix is now EMACS_INT, not int,
686 to improve quality of diagnostics for out-of-range radices.
687 Calculate buffer size correctly for out-of-range radices.
688 (read1): Check for integer overflow in radices, and in
690 (read_escape): Avoid int overflow.
691 (Fload, openp, read_buffer_size, read1)
692 (substitute_object_recurse, read_vector, read_list, map_obarray):
693 Use ptrdiff_t, not int, for sizes.
694 (read1): Use EMACS_INT, not int, for sizes.
695 Check for size overflow.
697 * image.c (cache_image): Check for size arithmetic overflow.
699 * lread.c: Integer overflow issues.
700 (saved_doc_string_size, saved_doc_string_length)
701 (prev_saved_doc_string_size, prev_saved_doc_string_length):
702 Now ptrdiff_t, not int.
703 (read1): Don't assume doc string length fits in int. Check for
704 out-of-range doc string lengths.
705 (read_list): Don't assume file position fits in int.
706 (read_escape): Check for hex character overflow.
708 2011-06-22 Leo Liu <sdl.web@gmail.com>
710 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
711 Move to minibuffer.el.
713 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
715 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
716 The following patches are for when GLYPH_DEBUG && !XASSERT.
717 * dispextern.h (trace_redisplay_p, dump_glyph_string):
718 * dispnew.c (flush_stdout):
719 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
720 Mark as externally visible.
721 * dispnew.c (check_window_matrix_pointers): Now static.
722 * dispnew.c (window_to_frame_vpos):
723 * xfns.c (unwind_create_frame):
724 * xterm.c (x_check_font): Remove unused local.
725 * scroll.c (CHECK_BOUNDS):
726 * xfaces.c (cache_fache): Rename local to avoid shadowing.
727 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
728 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
729 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
730 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
732 (debug_method_add): Use va_list and vsprintf rather than relying
733 on undefined behavior with wrong number of arguments.
734 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
735 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
736 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
737 since we're not interested in debugging glyphs with old libraries.
738 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
739 GCC 4.6.0's static checking.
741 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
743 Integer overflow and signedness fixes (Bug#8873).
744 A few related buffer overrun fixes, too.
746 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
748 * dispextern.h (struct face.stipple):
749 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
750 (x_bitmap_mask, x_allocate_bitmap_record)
751 (x_create_bitmap_from_data, x_create_bitmap_from_file)
752 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
753 (x_create_bitmap_from_xpm_data):
754 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
755 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
757 * xfaces.c (load_pixmap):
758 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
759 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
760 (.bitmaps_last, struct x_output.icon_bitmap):
761 Use ptrdiff_t, not int, for bitmap indexes.
762 (x_allocate_bitmap_record): Check for size overflow.
763 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
765 Use ptrdiff_t, not int, for overlay counts.
766 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
767 * editfns.c (overlays_around, get_pos_property):
768 * textprop.c (get_char_property_and_overlay):
769 * xdisp.c (next_overlay_change, note_mouse_highlight):
770 * xfaces.c (face_at_buffer_position):
771 * buffer.c (OVERLAY_COUNT_MAX): New macro.
772 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
773 (Fnext_overlay_change, Fprevious_overlay_change)
774 (mouse_face_overlay_overlaps, Foverlays_in):
775 Use ptrdiff_t, not int, for sizes.
776 (overlays_at, overlays_in): Check for size-calculation overflow.
778 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
780 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
781 (x_session_initialize): Do not assume string length fits in int.
783 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
784 This is unlikely, but can occur if DPI is outlandish.
786 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
787 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
789 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
790 * xrdb.c (magic_file_p, search_magic_path):
791 Omit last arg SUFFIX; it was always 0. All callers changed.
792 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
794 * xfont.c (xfont_match): Avoid need for strlen.
796 * xfns.c: Don't assume strlen fits in int.
797 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
799 * xdisp.c (message_log_check_duplicate): Return intmax_t,
800 not unsigned long, as we prefer signed integers. All callers changed.
801 Detect integer overflow in repeat count.
802 (message_dolog): Don't assume print length fits in 39 bytes.
803 (display_mode_element): Don't assume strlen fits in int.
805 * termcap.c: Don't assume sizes fit in int and never overflow.
806 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
807 (gobble_line): Check for size-calculation overflow.
809 * minibuf.c (Fread_buffer):
810 * lread.c (intern, intern_c_string):
811 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
812 Don't assume string length fits in int.
814 * keyboard.c (parse_tool_bar_item):
815 * gtkutil.c (style_changed_cb): Avoid need for strlen.
817 * font.c: Don't assume string length fits in int.
818 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
819 Use ptrdiff_t, not int.
820 (font_intern_prop): Don't assume string length fits in int.
821 Don't assume integer property fits in fixnum.
822 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
824 * filelock.c: Fix some buffer overrun and integer overflow issues.
825 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
826 Reformulate so as not to need the command string.
827 Invoke gzip -cd rather than gunzip, as it's more portable.
828 (lock_info_type, lock_file_1, lock_file):
829 Don't assume pid_t and time_t fit in unsigned long.
830 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
831 (current_lock_owner): Prefer signed type for sizes.
832 Use memcpy, not strncpy, where memcpy is what is really wanted.
833 Don't assume (via atoi) that time_t and pid_t fit in int.
834 Check for time_t and/or pid_t out of range, e.g., via a network share.
835 Don't alloca where an auto var works fine.
837 * fileio.c: Fix some integer overflow issues.
838 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
839 Don't assume string length fits in int.
840 (directory_file_name): Don't assume string length fits in long.
841 (make_temp_name): Don't assume pid fits in int, or that its print
842 length is less than 20.
844 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
846 * coding.c (make_subsidiaries): Don't assume string length fits in int.
848 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
850 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
851 We prefer signed integers, even for size calculations.
853 * emacs.c: Don't assume string length fits in 'int'.
854 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
855 (main): Don't invoke strlen when not needed.
857 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
858 (XD_DEBUG_MESSAGE): Don't waste a byte.
860 * callproc.c (getenv_internal_1, getenv_internal)
862 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
864 * lread.c (invalid_syntax): Omit length argument.
865 All uses changed. This doesn't fix a bug, but it simplifies the
866 code away from its former Hollerith-constant appearance, and it's
867 one less 'int' to worry about when looking at integer-overflow issues.
868 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
870 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
871 This didn't break anything, but it didn't help either.
872 It's confusing to put a bogus integer in a place where the actual
873 value does not matter.
874 (LIST_END_P): Remove unused macro and its bogus comment.
875 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
877 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
878 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
880 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
881 We prefer signed types, and the value cannot exceed the EMACS_INT
882 range anyway (because otherwise the length would not be representable).
883 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
884 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
885 This avoids a GCC warning when WIDE_EMACS_INT.
887 * indent.c (sane_tab_width): New function.
888 (current_column, scan_for_column, Findent_to, position_indentation)
889 (compute_motion): Use it. This is just for clarity.
890 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
892 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
894 * lisp.h (lint_assume): New macro.
895 * composite.c (composition_gstring_put_cache):
896 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
898 * editfns.c, insdel.c:
899 Omit unnecessary forward decls, to simplify future changes.
901 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
903 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
905 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
906 Use much-faster test for byte-length change.
907 Don't assume string byte-length fits in 'int'.
908 Check that character arg fits in 'int'.
909 (mapcar1): Declare byte as byte, for clarity.
911 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
913 * fns.c (concat): Catch string overflow earlier.
914 Do not rely on integer wraparound.
916 * dispextern.h (struct it.overlay_strings_charpos)
917 (struct it.selective): Now EMACS_INT, not int.
918 * xdisp.c (forward_to_next_line_start)
919 (back_to_previous_visible_line_start)
920 (reseat_at_next_visible_line_start, next_element_from_buffer):
921 Don't arbitrarily truncate the value of 'selective' to int.
923 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
925 * composite.c: Don't truncate sizes to 'int'.
926 (composition_gstring_p, composition_reseat_it)
927 (composition_adjust_point): Use EMACS_INT, not int.
928 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
929 not EMACS_UINT, for indexes.
931 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
933 * buffer.c: Include <verify.h>.
934 (struct sortvec.priority, struct sortstr.priority):
935 Now EMACS_INT, not int.
936 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
937 (struct sortstr.size, record_overlay_string)
938 (struct sortstrlist.size, struct sortlist.used):
939 Don't truncate size to int.
940 (record_overlay_string): Check for size-calculation overflow.
941 (init_buffer_once): Check at compile-time, not run-time.
943 2011-06-22 Jim Meyering <meyering@redhat.com>
945 Don't leak an XBM-image-sized buffer
946 * image.c (xbm_load): Free the image buffer after using it.
948 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
951 * composite.c (find_automatic_composition): Omit needless 'return 0;'
952 that Sun C diagnosed.
953 * fns.c (secure_hash): Fix pointer signedness issue.
954 * intervals.c (static_offset_intervals): New function.
955 (offset_intervals): Use it.
957 2011-06-21 Leo Liu <sdl.web@gmail.com>
960 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
963 * fns.c (secure_hash): Rename from crypto_hash_function and change
964 the first arg to accept symbols.
965 (Fsecure_hash): New primitive.
966 (syms_of_fns): New symbols.
968 2011-06-20 Deniz Dogan <deniz@dogan.se>
970 * process.c (Fset_process_buffer): Clarify return value in
973 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
975 * dispnew.c (add_window_display_history): Use BVAR.
977 * xdisp.c (debug_method_add): Use BVAR.
978 (check_window_end, dump_glyph_matrix, dump_glyph)
979 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
981 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
984 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
985 check till after the cache is created in init_frame_faces.
987 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
989 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
991 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
993 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
994 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
995 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
997 Improve buffer-overflow checking (Bug#8873).
998 * fileio.c (Finsert_file_contents):
999 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1000 Remove the old (too-loose) buffer overflow checks.
1001 They weren't needed, since make_gap checks for buffer overflow.
1002 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1003 The old code merely checked for Emacs fixnum overflow, and relied
1004 on undefined (wraparound) behavior. The new code avoids undefined
1005 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1007 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1008 Tune. Don't use wider integers than needed. Don't use alloca.
1009 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1011 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1013 * insdel.c, lisp.h (buffer_overflow): New function.
1014 (insert_from_buffer_1, replace_range, replace_range_2):
1015 * insdel.c (make_gap_larger):
1016 * editfns.c (Finsert_char):
1017 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1019 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1021 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1023 Integer overflow and signedness fixes (Bug#8873).
1025 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1026 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1028 * fileio.c: Don't assume EMACS_INT fits in off_t.
1029 (emacs_lseek): New static function.
1030 (Finsert_file_contents, Fwrite_region): Use it.
1031 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1033 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1035 * fns.c: Don't overflow int when computing a list length.
1036 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1037 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1038 truncation on 64-bit hosts. Check for QUIT every
1039 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1040 faster and is responsive enough.
1041 (Flength): Report an error instead of overflowing an integer.
1042 (Fsafe_length): Return a float if the value is not representable
1043 as a fixnum. This shouldn't happen except in contrived situations.
1044 (Fnthcdr, Fsort): Don't assume list length fits in int.
1045 (Fcopy_sequence): Don't assume vector length fits in int.
1047 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1048 (header_size, word_size): New constants.
1049 (allocate_vectorlike): Don't check size overflow here.
1050 (allocate_vector): Check it here instead, since this is the only
1051 caller of allocate_vectorlike that could cause overflow.
1052 Check that the new vector's length is representable as a fixnum.
1054 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1055 The previous code was bogus. For example, next_almost_prime (32)
1056 returned 39, which is undesirable as it is a multiple of 3; and
1057 next_almost_prime (24) returned 25, which is a multiple of 5 so
1058 why was the code bothering to check for multiples of 7?
1060 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1062 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1064 Variadic C functions now count arguments with ptrdiff_t.
1065 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1066 Back then I didn't know that the Emacs coding style prefers signed int.
1067 Also, in the meantime I found a few more instances where arguments
1068 were being counted with int, which may truncate counts on 64-bit
1069 machines, or EMACS_INT, which may be unnecessarily wide.
1070 * lisp.h (struct Lisp_Subr.function.aMANY)
1071 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1072 Arg counts are now ptrdiff_t, not size_t.
1073 All variadic functions and their callers changed accordingly.
1074 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1075 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1076 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1077 * callint.c (Fcall_interactively): Check arg count for overflow,
1078 to avoid potential buffer overrun. Use signed char, not 'int',
1079 for 'varies' array, so that we needn't bother to check its size
1080 calculation for overflow.
1081 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1082 * eval.c (apply_lambda):
1083 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1084 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1085 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1087 * callint.c (Fcall_interactively): Don't use index var as event count.
1089 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1090 * mem-limits.h (SIZE): Remove; no longer used.
1092 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1094 Remove unnecessary casts.
1095 * xterm.c (x_term_init):
1096 * xfns.c (x_set_border_pixel):
1097 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1098 These aren't needed now that we assume ANSI C.
1100 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1101 It's more likely to cause problems (due to unsigned overflow)
1104 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1106 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1108 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1110 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1112 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1114 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1116 GLYPH_CODE_FACE returns EMACS_INT, not int.
1117 * dispextern.h (merge_faces):
1118 * xfaces.c (merge_faces):
1119 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1120 Don't assume EMACS_INT fits in int.
1122 * character.h (CHAR_VALID_P): Remove unused parameter.
1123 * fontset.c, lisp.h, xdisp.c: All uses changed.
1125 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1127 * fns.c (concat): Minor tuning based on overflow analysis.
1128 This doesn't fix any bugs. Use int to hold character, instead
1129 of constantly refetching from Emacs object. Use XFASTINT, not
1130 XINT, for value known to be a character. Don't bother comparing
1131 a single byte to 0400, as it's always less.
1133 * floatfns.c (Fexpt):
1134 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1136 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1139 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1141 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1142 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1143 incorrectly succeed when S was a string, because 4294967386 was
1144 truncated before it was used.
1146 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1147 Otherwise, an out-of-range integer could cause undefined behavior
1150 * composite.c: Use int, not EMACS_INT, for characters.
1151 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1152 EMACS_INT, for values that are known to be in character range.
1153 This doesn't fix any bugs but is the usual style inside Emacs and
1154 may generate better code on 32-bit machines.
1156 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1157 This is for reasons similar to the recent CHAR_STRING fix.
1158 * charset.c (Fencode_char): Check that character arg is actually
1159 a character. Pass an int to ENCODE_CHAR.
1160 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1161 wider than 'int', as a compile-time check to prevent future regressions
1164 * character.c (char_string): Remove unnecessary casts.
1166 Make sure a 64-bit char is never passed to CHAR_STRING.
1167 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1168 by silently ignoring the top 32 bits, allowing some values
1169 that were far too large to be valid characters.
1170 * character.h: Include <verify.h>.
1171 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1172 arguments are no wider than unsigned, as a compile-time check
1173 to prevent future regressions in this area.
1175 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1176 (Fsubst_char_in_region):
1178 * xdisp.c (decode_mode_spec_coding):
1179 Adjust to CHAR_STRING's new requirement.
1180 * editfns.c (Finsert_char, Fsubst_char_in_region):
1181 * fns.c (concat): Check that character args are actually
1182 characters. Without this test, these functions did the wrong
1183 thing with wildly out-of-range values on 64-bit hosts.
1185 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1186 These casts should not be needed on 32-bit hosts, either.
1187 * keyboard.c (read_char):
1188 * lread.c (Fload): Remove casts to unsigned.
1190 * lisp.h (UNSIGNED_CMP): New macro.
1191 This fixes comparison bugs on 64-bit hosts.
1192 (ASCII_CHAR_P): Use it.
1193 * casefiddle.c (casify_object):
1194 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1195 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1196 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1197 * dispextern.h (FACE_FROM_ID):
1198 * keyboard.c (read_char): Use UNSIGNED_CMP.
1200 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1201 not to EMACS_INT, to avoid GCC warning.
1203 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1205 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1206 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1207 isn't needed on 32-bit machines.
1209 * buffer.c (Fgenerate_new_buffer_name):
1210 Use EMACS_INT for count, not int.
1211 (advance_to_char_boundary): Return EMACS_INT, not int.
1213 * data.c (Qcompiled_function): Now static.
1215 * window.c (window_body_lines): Now static.
1217 * image.c (gif_load): Rename local to avoid shadowing.
1219 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1220 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1221 * alloc.c (make_save_value): Integer argument is now of type
1223 (mark_object): Use ptrdiff_t, not int.
1224 * lisp.h (pD): New macro.
1225 * print.c (print_object): Use it.
1227 * alloc.c: Use EMACS_INT, not int, to count objects.
1228 (total_conses, total_markers, total_symbols, total_vector_size)
1229 (total_free_conses, total_free_markers, total_free_symbols)
1230 (total_free_floats, total_floats, total_free_intervals)
1231 (total_intervals, total_strings, total_free_strings):
1232 Now EMACS_INT, not int. All uses changed.
1233 (Fgarbage_collect): Compute overall total using a double, so that
1234 integer overflow is less likely to be a problem. Check for overflow
1235 when converting back to an integer.
1236 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1237 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1238 These were 'int' variables that could overflow on 64-bit hosts;
1239 they were never used, so remove them instead of repairing them.
1240 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1241 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1242 Previously, this ceilinged at INT_MAX, but that doesn't work on
1244 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1246 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1247 (allocate_vectorlike): Check for ptrdiff_t overflow.
1248 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1249 when a (possibly-narrower) signed value would do just as well.
1250 We prefer using signed arithmetic, to avoid comparison confusion.
1252 * alloc.c: Catch some string size overflows that we were missing.
1253 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1254 for convenience in STRING_BYTES_MAX.
1255 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1256 The definition here is exact; the one in lisp.h was approximate.
1257 (allocate_string_data): Check for string overflow. This catches
1258 some instances we weren't catching before. Also, it catches
1259 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1260 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1261 and ptrdiff_t and EMACS_INT are both 64 bits.
1263 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1264 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1265 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1267 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1269 * alloc.c (Fmake_string): Check for out-of-range init.
1271 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1273 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1275 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1277 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1278 xg_get_default_scrollbar_width.
1280 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1281 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1282 (style_changed_cb): Call update_theme_scrollbar_width and call
1283 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1284 all frames (Bug#8505).
1285 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1286 Call gtk_window_set_resizable if HAVE_GTK3.
1287 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1288 and height if HAVE_GTK3 (Bug#8505).
1289 (scroll_bar_width_for_theme): New variable.
1290 (update_theme_scrollbar_width): New function.
1291 (xg_get_default_scrollbar_width): Move code to
1292 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1293 (xg_initialize): Call update_theme_scrollbar_width.
1295 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1297 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1299 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1301 * frame.c (make_frame): Call other_buffer_safely instead of
1304 * window.c (temp_output_buffer_show): Call display_buffer with
1305 second argument Vtemp_buffer_show_specifiers and reset latter
1306 immediately after the call.
1307 (Vtemp_buffer_show_specifiers): New variable.
1308 (auto_window_vscroll_p, next_screen_context_lines)
1309 (Vscroll_preserve_screen_position): Remove leading asterisks from
1312 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1314 Fix minor problems found by GCC 4.6.0 static checking.
1315 * buffer.c (Qclone_number): Remove for now, as it's unused.
1316 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1317 (record_buffer): Remove unused local.
1318 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1319 (set_frame_buffer_list): Remove; unused.
1320 * frame.h (other_visible_frames): Remove decl.
1321 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1322 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1323 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1325 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1326 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1327 Define only if HAVE_GPM.
1328 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1329 (update_hints_inhibit): Remove; never set. All uses removed.
1330 * widgetprv.h (emacsFrameClassRec): Remove decl.
1331 * window.c (delete_deletable_window): Now returns void, since it
1332 wasn't returning anything.
1333 (compare_window_configurations): Remove unused locals.
1334 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1335 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1336 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1337 the same widths as pointers. This follows up on the 2011-05-06 patch.
1338 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1339 * xterm.h: Likewise.
1340 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1342 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1344 * makefile.w32-in: Update dependencies.
1345 (LISP_H): Add lib/intprops.h.
1347 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1349 * image.c (gif_load): Add animation frame delay to the metadata.
1350 (syms_of_image): Use DEFSYM. New symbol `delay'.
1352 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1354 * window.c (delete_deletable_window): Re-add.
1355 (Fset_window_configuration): Rewrite to handle dead buffers and
1356 consequently deletable windows.
1357 (window_tree, Fwindow_tree): Remove. Supply functionality in
1359 (compare_window_configurations): Simplify code.
1361 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1363 * image.c (imagemagick_load_image): Fix type mismatch.
1364 (Fimagemagick_types): Likewise.
1366 * window.h (replace_buffer_in_windows): Declare.
1368 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1370 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1371 Qclone_number. Remove external declaration of Qdelete_window.
1372 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1374 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1375 Qbuffer_list_update_hook if allowed.
1376 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1377 buffer list implementation.
1378 (other_buffer_safely): New function.
1379 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1380 calls to replace_buffer_in_windows and
1381 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1383 (record_buffer): Inhibit quitting and rewrite using quittable
1384 functions. Run Qbuffer_list_update_hook if allowed.
1385 (Frecord_buffer, Funrecord_buffer): New functions.
1386 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1387 switch-to-buffer to window.el.
1388 (bury-buffer): Move to window.el.
1389 (Vbuffer_list_update_hook): New variable.
1391 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1394 * window.h (resize_frame_windows): Move up in code.
1395 (Fwindow_frame): Remove EXFUN.
1396 (replace_buffer_in_all_windows): Remove prototype.
1397 (replace_buffer_in_windows_safely): Add prototype.
1399 * window.c: Declare Qdelete_window static again. Move down
1400 declaration of select_count.
1401 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1402 (Fother_window): Move to window.el.
1403 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1404 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1405 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1407 (replace_buffer_in_windows): Implement by calling
1408 Qreplace_buffer_in_windows.
1409 (replace_buffer_in_all_windows): Remove with some functionality
1410 moved into replace_buffer_in_windows_safely.
1411 (replace_buffer_in_windows_safely): New function.
1412 (select_window_norecord, select_frame_norecord): Move in front
1413 of run_window_configuration_change_hook. Remove now obsolete
1415 (Fset_window_buffer): Rewrite doc-string. Call
1416 Qrecord_window_buffer.
1417 (keys_of_window): Move binding for other-window to window.el.
1419 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1421 * dispextern.h (struct image): Replace data member, whose int_val
1422 and ptr_val fields were not used by anything, with a single
1425 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1426 (gif_clear_image, gif_load, imagemagick_load_image)
1427 (gs_clear_image, gs_load): Callers changed.
1429 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1431 * buffer.h: Include <time.h>, for time_t.
1432 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1434 Fix minor problems found by static checking.
1436 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1438 Make identifiers static if they are not used in other modules.
1439 * data.c (Qcompiled_function, Qframe, Qvector):
1440 * image.c (QimageMagick, Qsvg):
1441 * minibuf.c (Qmetadata):
1442 * window.c (resize_window_check, resize_root_window): Now static.
1443 * window.h (resize_window_check, resize_root_window): Remove decls.
1445 * window.c (window_deletion_count, delete_deletable_window):
1447 (window_body_lines): Now static.
1448 (Fdelete_other_windows_internal): Mark vars as initialized.
1449 Make sure 'resize_failed' is initialized.
1450 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1451 (resize_window_apply): Remove unused local.
1452 * window.h (delete_deletable_window): Remove decl.
1454 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1455 (imagemagick_load_image): Fix pointer signedness problem by changing
1456 last arg from unsigned char * to char *. All uses changed.
1457 Also, fix a local for similar reasons.
1458 Remove unused locals. Remove locals to avoid shadowing.
1459 (fn_rsvg_handle_free): Remove; unused.
1460 (svg_load, svg_load_image): Fix pointer signedness problem.
1461 (imagemagick_load_image): Don't use garbage pointer image_wand.
1463 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1465 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1467 * image.c (gif_load): Fix omitted cast error introduced by
1470 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1472 * window.h (resize_proportionally, orig_total_lines)
1473 (orig_top_line): Remove from window structure.
1474 (set_window_height, set_window_width, change_window_heights)
1475 (Fdelete_window): Remove prototypes.
1476 (resize_frame_windows): Remove duplicate declaration.
1478 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1480 * window.h (resize_frame_windows, resize_window_check)
1481 (delete_deletable_window, resize_root_window)
1482 (resize_frame_windows): Declare prototypes.
1484 * window.c (resize_window_apply): Make definition be "static" to
1485 match the prototype.
1487 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1489 * window.c: Remove declarations of Qwindow_size_fixed,
1490 window_min_size_1, window_min_size_2, window_min_size,
1491 size_window, window_fixed_size_p, enlarge_window, delete_window.
1492 Remove static from declaration of Qdelete_window, it's
1493 temporarily needed by Fbury_buffer.
1494 (replace_window): Don't assign orig_top_line and
1496 (Fdelete_window, delete_window): Remove. Window deletion is
1497 handled by window.el.
1498 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1499 Fdelete_window calls with calls to Qdelete_window.
1500 (Fdelete_other_windows): Remove. Deleting other windows is
1501 handled by window.el.
1502 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1503 handled in window.el.
1504 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1505 Window minimum sizes are handled in window.el.
1506 (shrink_windows, size_window, set_window_height)
1507 (set_window_width, change_window_heights, window_height)
1508 (window_width, CURBEG, CURSIZE, enlarge_window)
1509 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1510 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1511 handled in window.el.
1512 (make_dummy_parent): Rename to make_parent_window and give it a
1513 second argument horflag.
1514 (make_window): Don't set resize_proportionally any more.
1515 (Fsplit_window): Remove. Windows are split in window.el.
1516 (save_restore_action, save_restore_orig_size)
1517 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1518 Resize mini windows in window.el.
1519 (grow_mini_window, shrink_mini_window): Implement by calling
1520 Qresize_root_window_vertically, resize_window_check and
1521 resize_window_apply.
1522 (saved_window, Fset_window_configuration, save_window_save): Do
1523 not handle orig_top_line, orig_total_lines, and
1524 resize_proportionally.
1525 (window_min_height, window_min_width): Move to window.el.
1526 (keys_of_window): Move bindings for delete-other-windows,
1527 split-window, delete-window and enlarge-window to window.el.
1529 * buffer.c: Temporarily extern Qdelete_window.
1530 (Fbury_buffer): Temporarily call Qdelete_window instead of
1531 Fdelete_window (Fbury_buffer will move to window.el soon).
1533 * frame.c (set_menu_bar_lines_1): Remove code handling
1534 orig_top_line and orig_total_lines.
1536 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1537 set_window_height but set heights directly.
1538 (change_frame_size_1): Use resize_frame_windows.
1540 * xdisp.c (init_xdisp): Don't use set_window_height but set
1543 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1544 resize_frame_windows instead of change_window_heights and run
1545 run_window_configuration_change_hook.
1547 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1548 instead of change_window_heights and run
1549 run_window_configuration_change_hook.
1551 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1553 * window.c (replace_window): Rename second argument REPLACEMENT to
1554 NEW. New third argument SETFLAG. Rewrite.
1555 (delete_window, make_dummy_parent): Call replace_window with
1557 (window_list_1): Move down in code.
1558 (run_window_configuration_change_hook): Move set_buffer part
1559 before select_frame_norecord part in order to unwind correctly.
1560 Rename count1 to count.
1561 (recombine_windows, delete_deletable_window, resize_root_window)
1562 (Fdelete_other_windows_internal)
1563 (Frun_window_configuration_change_hook, make_parent_window)
1564 (resize_window_check, resize_window_apply, Fresize_window_apply)
1565 (resize_frame_windows, Fsplit_window_internal)
1566 (Fdelete_window_internal, Fresize_mini_window_internal): New
1568 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1570 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1572 * window.h (window): Add some new members to window structure -
1573 normal_lines, normal_cols, new_total, new_normal, clone_number,
1574 splits, nest, prev_buffers, next_buffers.
1575 (WINDOW_TOTAL_SIZE): Move here from window.c.
1576 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1578 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1580 (make_dummy_parent): Set new members of windows structure.
1581 (make_window): Move down in code. Handle new members of window
1583 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1584 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1585 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1586 (Fset_window_prev_buffers, Fwindow_next_buffers)
1587 (Fset_window_next_buffers, Fset_window_clone_number): New
1589 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1590 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1592 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1593 Argument WINDOW can be now internal window too.
1594 (Fwindow_use_time): Move up in code.
1595 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1597 (Fset_window_configuration, saved_window)
1598 (Fcurrent_window_configuration, save_window_save): Handle new
1599 members of window structure.
1600 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1601 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1602 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1603 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1604 Qget_mru_window, Qresize_root_window,
1605 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1606 Qauto_buffer_name; staticpro them.
1608 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1610 * window.c (Fwindow_total_size, Fwindow_left_column)
1611 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1612 (Fwindow_list_1): New functions.
1613 (window_box_text_cols): Replace with window_body_cols.
1614 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1615 window_body_cols instead of window_box_text_cols.
1616 (delete_window, Fset_window_configuration): Call
1617 delete_all_subwindows with window as argument.
1618 (delete_all_subwindows): Take a window as argument and not a
1620 (window_loop): Remove handling of GET_LRU_WINDOW and
1622 (Fget_lru_window, Fget_largest_window): Move to window.el.
1624 * window.h: Extern window_body_cols instead of
1625 window_box_text_cols. delete_all_subwindows now takes a
1626 Lisp_Object as argument.
1628 * indent.c (compute_motion, Fcompute_motion): Use
1629 window_body_cols instead of window_box_text_cols.
1631 * frame.c (delete_frame): Call delete_all_subwindows with root
1634 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1636 * fns.c (Fputhash): Document return value.
1638 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1640 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1642 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1644 Cons<->int and similar integer overflow fixes (Bug#8794).
1646 Check for overflow when converting integer to cons and back.
1647 * charset.c (Fdefine_charset_internal, Fdecode_char):
1648 Use cons_to_unsigned to catch overflow.
1649 (Fencode_char): Use INTEGER_TO_CONS.
1650 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1651 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1652 * data.c (long_to_cons, cons_to_long): Remove.
1653 (cons_to_unsigned, cons_to_signed): New functions.
1654 These signal an error for invalid or out-of-range values.
1655 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1656 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1657 * font.c (Ffont_variation_glyphs):
1658 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1659 * lisp.h: Include <intprops.h>.
1660 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1661 (cons_to_signed, cons_to_unsigned): New decls.
1662 (long_to_cons, cons_to_long): Remove decls.
1663 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1664 (Fprimitive_undo): Use CONS_TO_INTEGER.
1665 * xfns.c (Fx_window_property): Likewise.
1666 * xselect.c: Include <limits.h>.
1667 (x_own_selection, selection_data_to_lisp_data):
1668 Use INTEGER_TO_CONS.
1669 (x_handle_selection_request, x_handle_selection_clear)
1670 (x_get_foreign_selection, Fx_disown_selection_internal)
1671 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1672 (lisp_data_to_selection_data): Use cons_to_unsigned.
1673 (x_fill_property_data): Use cons_to_signed.
1674 Report values out of range.
1676 Check for buffer and string overflow more precisely.
1677 * buffer.h (BUF_BYTES_MAX): New macro.
1678 * lisp.h (STRING_BYTES_MAX): New macro.
1679 * alloc.c (Fmake_string):
1680 * character.c (string_escape_byte8):
1681 * coding.c (coding_alloc_by_realloc):
1682 * doprnt.c (doprnt):
1683 * editfns.c (Fformat):
1685 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1686 since they may not be the same number.
1687 * editfns.c (Finsert_char):
1688 * fileio.c (Finsert_file_contents):
1689 Likewise for BUF_BYTES_MAX.
1691 * image.c: Use ptrdiff_t, not int, for sizes.
1692 (slurp_file): Switch from int to ptrdiff_t.
1694 (slurp_file): Check that file size fits in both size_t (for
1695 malloc) and ptrdiff_t (for sanity and safety).
1697 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1698 if b->modtime has its maximal value.
1700 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1702 Don't assume time_t can fit into int.
1703 * buffer.h (struct buffer.modtime): Now time_t, not int.
1704 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1705 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1707 Minor fixes for signed vs unsigned integers.
1708 * character.h (MAYBE_UNIFY_CHAR):
1709 * charset.c (maybe_unify_char):
1710 * keyboard.c (read_char, reorder_modifiers):
1711 XINT -> XFASTINT, since the integer must be nonnegative.
1712 * ftfont.c (ftfont_spec_pattern):
1713 * keymap.c (access_keymap, silly_event_symbol_error):
1714 XUINT -> XFASTINT, since the integer must be nonnegative.
1715 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1716 since it makes no difference and we prefer signed.
1717 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1718 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1721 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1723 * window.h (Fwindow_frame): Declare.
1725 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1727 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1728 (SPARE_MEMORY): Always define.
1729 (LARGE_REQUEST): Remove.
1730 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1732 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1734 * lisp.h: Move EXFUNS for Fframe_root_window,
1735 Fframe_first_window and Fset_frame_selected_window to window.h.
1737 * window.h: Move EXFUNS for Fframe_root_window,
1738 Fframe_first_window and Fset_frame_selected_window here from
1741 * frame.c (Fwindow_frame, Fframe_first_window)
1742 (Fframe_root_window, Fframe_selected_window)
1743 (Fset_frame_selected_window): Move to window.c.
1744 (Factive_minibuffer_window): Move to minibuf.c.
1745 (Fother_visible_frames_p): New function.
1747 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1749 * window.c (decode_window, decode_any_window): Move up in code.
1750 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1751 (inhibit_frame_unsplittable): Remove unused variable.
1752 (Fwindow_buffer): Move up and rewrite doc-string.
1753 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1754 (Fwindow_prev): New functions.
1755 (Fwindow_frame): Move here from frame.c. Accept any window as
1757 (Fframe_root_window, Fframe_first_window)
1758 (Fframe_selected_window): Move here from frame.c. Accept frame
1759 or arbitrary window as argument. Update doc-strings.
1760 (Fminibuffer_window): Move up in code.
1761 (Fwindow_minibuffer_p): Move up in code and simplify.
1762 (Fset_frame_selected_window): Move here from frame.c.
1764 (Fselected_window, select_window, Fselect_window): Move up in
1765 code. Minor doc-string fixes.
1767 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1769 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1770 Do not assume that spare memory exists; that assumption is valid
1771 only if SYSTEM_MALLOC.
1772 (LARGE_REQUEST): New macro, so that the issue of large requests
1773 is separated from the issue of spare memory.
1775 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1777 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1780 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1782 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1785 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1787 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1789 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1791 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1792 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1794 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1796 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1798 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1800 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1801 (x_clipboard_manager_save): Add return value.
1802 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1804 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1805 Obey Vx_select_enable_clipboard_manager. Catch errors in
1806 x_clipboard_manager_save (Bug#8779).
1807 (Vx_select_enable_clipboard_manager): New variable.
1808 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1810 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1812 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1814 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1816 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1817 in the current matrix if keep_current_p is non-zero.
1819 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1821 * bidi.c (bidi_level_of_next_char): Fix last change.
1823 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1825 Support bidi reordering of text covered by display properties.
1827 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1828 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1829 (bidi_cache_search, bidi_cache_iterator_state)
1830 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1831 (bidi_level_of_next_char, bidi_move_to_visually_next):
1832 Support character positions inside a run of characters covered by a
1834 (bidi_paragraph_init, bidi_resolve_explicit_1)
1835 (bidi_level_of_next_char): Call bidi_fetch_char and
1836 bidi_fetch_char_advance instead of FETCH_CHAR and
1838 (bidi_init_it): Initialize new members.
1839 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1841 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1842 instead of using explicit *_CHAR codes.
1843 (bidi_resolve_explicit, bidi_resolve_weak):
1844 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1845 bidirectional text is supported only in multibyte buffers.
1846 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1847 it to initialize the frame_window_p member of struct bidi_it.
1848 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1849 (bidi_resolve_explicit, bidi_resolve_weak)
1850 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1851 bidi_it->nchars is non-positive.
1852 (bidi_level_of_next_char): Don't try to lookup the cache for the
1853 next/previous character if nothing is cached there yet, or if we
1854 were just reseat()'ed to a new position.
1856 * xdisp.c (set_cursor_from_row): Set start and stop points
1857 according to the row's direction when priming the loop that looks
1858 for the glyph on which to display cursor.
1859 (single_display_spec_intangible_p): Function deleted.
1860 (display_prop_intangible_p): Reimplement to call
1861 handle_display_spec instead of single_display_spec_intangible_p.
1862 Accept 3 additional arguments needed by handle_display_spec.
1863 This fixes incorrect cursor motion across display property with complex
1864 values: lists, `(when COND...)' forms, etc.
1865 (single_display_spec_string_p): Support property values that are
1866 lists with the argument STRING its top-level element.
1867 (display_prop_string_p): Fix the condition for processing a
1868 property that is a list to be consistent with handle_display_spec.
1869 (handle_display_spec): New function, refactored from the
1870 last portion of handle_display_prop.
1871 (compute_display_string_pos): Accept additional argument
1872 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1873 value of a `display' property is a "replacing spec".
1874 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1875 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1876 the display property, but just return a value indicating whether
1877 the display property will replace the characters it covers.
1878 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1879 frame_window_p members of struct bidi_it.
1880 (compute_display_string_pos, compute_display_string_end):
1882 (push_it): Accept second argument POSITION, where pop_it should
1883 jump to continue iteration.
1884 (reseat_1): Initialize bidi_it.disp_pos.
1886 * keyboard.c (adjust_point_for_property): Adjust the call to
1887 display_prop_intangible_p to its new signature.
1889 * dispextern.h (struct bidi_it): New member frame_window_p.
1890 (bidi_init_it): Update prototypes.
1891 (display_prop_intangible_p): Update prototype.
1892 (compute_display_string_pos, compute_display_string_end):
1894 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1897 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1899 Malloc failure behavior now depends on size of allocation.
1900 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1901 * lisp.h: Change signatures accordingly.
1902 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1903 All callers changed. (Bug#8762)
1905 * gnutls.c: Use Emacs's memory allocators.
1906 Without this change, the gnutls library would invoke malloc etc.
1907 directly, which causes problems on non-SYNC_INPUT hosts, and which
1908 runs afoul of improving memory_full behavior. (Bug#8761)
1909 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1910 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1911 xfree instead of the default malloc, realloc, free.
1912 (Fgnutls_boot): No need to check for memory allocation failure,
1913 since xmalloc does that for us.
1915 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1916 * category.c (hash_get_category_set):
1917 * ccl.c (ccl_driver):
1918 * charset.c (Fdefine_charset_internal):
1919 * charset.h (struct charset.hash_index):
1920 * composite.c (get_composition_id, gstring_lookup_cache)
1921 (composition_gstring_put_cache):
1922 * composite.h (struct composition.hash_index):
1923 * dispextern.h (struct image.hash):
1924 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1925 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1926 (hashfn_equal, hashfn_user_defined, make_hash_table)
1927 (maybe_resize_hash_table, hash_lookup, hash_put)
1928 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1929 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1930 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1931 * image.c (make_image, search_image_cache, lookup_image)
1932 (xpm_put_color_table_h):
1933 * lisp.h (struct Lisp_Hash_Table):
1934 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1935 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1936 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1937 * alloc.c (allocate_vectorlike):
1938 Check for overflow in vector size calculations.
1939 * ccl.c (ccl_driver):
1940 Check for overflow when converting EMACS_INT to int.
1941 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1942 need to be updated by these changes.
1943 * fns.c (make_hash_table, maybe_resize_hash_table):
1944 Check for integer overflow with large hash tables.
1945 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1946 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1947 (SXHASH_REDUCE): New macro.
1948 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1949 Use it instead of discarding useful hash info with large hash values.
1950 (sxhash_float): New function.
1951 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1952 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1953 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1954 Rewrite to use FIXNUM_BITS, as this simplifies things.
1955 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1956 Adjust signatures to match updated version of code.
1957 (consing_since_gc): Now EMACS_INT, since a single hash table can
1958 use more than INT_MAX bytes.
1960 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1962 Make it possible to build with GCC-4.6+ -O2 -flto.
1964 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1966 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1968 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1969 Call minibuffer-inactive-mode.
1971 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1973 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1974 Update dependencies.
1976 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1978 * data.c (init_data): Remove code for UTS, this system is not
1981 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1983 Don't force ./temacs to start in terminal mode.
1985 * frame.c (make_initial_frame): Initialize faces in all cases, not
1986 only when CANNOT_DUMP is defined.
1987 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1989 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1991 * dispnew.c (add_window_display_history): Use const for the string
1992 pointer. Remove declaration, not needed.
1994 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1996 Use 'inline', not 'INLINE'.
1997 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1998 * alloc.c, fontset.c (INLINE): Remove.
1999 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2000 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2001 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2002 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2003 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2005 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2007 Make it possible to run ./temacs.
2009 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2010 syms_of_callproc does the same thing. Remove test for
2011 "initialized", do it in the caller.
2012 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2014 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2016 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2017 (read_minibuf): Use get_minibuffer.
2018 (syms_of_minibuf): Use DEFSYM.
2019 (Qmetadata): New var.
2020 * data.c (Qbuffer): Don't make it static.
2021 (syms_of_data): Use DEFSYM.
2023 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2025 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2026 (CCL_CODE_MIN): New macro.
2028 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2030 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2032 * eval.c (Qdebug): Now static.
2033 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2034 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2035 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2037 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2039 * image.c: Various fixes to ImageMagick code comments.
2040 (Fimagemagick_types): Doc fix.
2042 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2044 Minor fixes prompted by GCC 4.6.0 warnings.
2046 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2048 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2049 (x_clipboard_manager_save_all): Move extern decl to ...
2050 * xterm.h: ... here, so that it can be checked for consistency.
2052 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2054 * xselect.c (x_clipboard_manager_save_frame)
2055 (x_clipboard_manager_save_all): New functions.
2056 (Fx_clipboard_manager_save): Lisp function deleted.
2058 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2059 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2061 * xterm.h: Update prototype.
2063 2011-05-28 William Xu <william.xwl@gmail.com>
2065 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2068 2011-05-28 Jim Meyering <meyering@redhat.com>
2070 Avoid a sign-extension bug in crypto_hash_function.
2071 * fns.c (to_uchar): Define.
2072 (crypto_hash_function): Use it to convert some newly-signed
2073 variables to unsigned, to avoid sign-extension bugs. For example,
2074 without this change, (md5 "truc") would evaluate to
2075 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2076 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2077 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2079 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2081 Integer overflow fixes.
2083 * dbusbind.c: Serial number integer overflow fixes.
2084 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2085 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2086 to hold a serial number that is too large for a fixnum.
2087 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2088 Check for serial numbers out of range. Decode any serial number
2089 that was so large that it became a float. (Bug#8722)
2091 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2092 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2093 Use XFASTINT rather than XUINT when numbers are nonnegative.
2094 (xd_append_arg, Fdbus_method_return_internal):
2095 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2096 arguments, check that Lisp number is nonnegative, rather than
2097 silently wrapping negative numbers around. (Bug#8722)
2098 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2101 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2103 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2105 ccl: add integer overflow checks
2106 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2107 (IN_INT_RANGE): New macros.
2108 (ccl_driver): Use them to check for integer overflow when
2109 decoding a CCL program. Many of the new checks are whether XINT (x)
2110 fits in int; it doesn't always, on 64-bit hosts. The new version
2111 doesn't catch all possible integer overflows, but it's an
2112 improvement. (Bug#8719)
2114 * alloc.c (make_event_array): Use XINT, not XUINT.
2115 There's no need for unsigned here.
2117 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2118 This follows up to the 2011-05-06 change that substituted uintptr_t
2119 for EMACS_INT. This case wasn't caught back then.
2121 Rework Fformat to avoid integer overflow issues.
2122 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2123 now (part of C89). Include <verify.h>.
2124 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2125 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2126 (Fformat): Avoid the prepass trying to compute sizes; it was only
2127 approximate and thus did not catch overflow reliably. Instead, walk
2128 through the format just once, formatting and computing sizes as we go,
2129 checking for integer overflow at every step, and allocating a larger
2130 buffer as needed. Keep track separately whether the format is
2131 multibyte. Keep only the most-recently calculated precision, rather
2132 than them all. Record whether each argument has been converted to
2133 string. Use EMACS_INT, not int, for byte and char and arg counts.
2134 Support field widths and precisions larger than INT_MAX. Avoid
2135 sprintf's undefined behavior with conversion specifications such as %#d
2136 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2137 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2138 formatting out-of-range floating point numbers with int
2141 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2143 * data.c: Avoid integer truncation in expressions involving floats.
2144 * data.c: Include <intprops.h>.
2145 (arith_driver): When there's an integer overflow in an expression
2146 involving floating point, convert the integers to floating point
2147 so that the resulting value does not suffer from catastrophic
2148 integer truncation. For example, on a 64-bit host (* 4
2149 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2150 Do not rely on undefined behavior after integer overflow.
2152 merge count_size_as_multibyte, parse_str_to_multibyte
2153 * character.c, character.h (count_size_as_multibyte):
2154 Rename from parse_str_to_multibyte; all uses changed.
2155 Check for integer overflow.
2156 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2157 since it's now a duplicate of the other. This is more of
2158 a character than a buffer op, so better that it's in character.c.
2159 * fns.c, print.c: Adjust to above changes.
2161 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2163 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2165 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2167 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2168 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2169 (x_clipboard_manager_save): Now static.
2170 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2172 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2173 (crypto_hash_function): Now static.
2174 Fix pointer signedness problems. Avoid unnecessary initializations.
2176 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2178 * termhooks.h (Vselection_alist): Make it terminal-local.
2180 * terminal.c (create_terminal): Initialize it.
2182 * xselect.c: Support for clipboard managers.
2183 (Vselection_alist): Move to termhooks.h as terminal-local var.
2184 (LOCAL_SELECTION): New macro.
2185 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2186 (symbol_to_x_atom): Remove gratuitous arg.
2187 (x_handle_selection_request, lisp_data_to_selection_data)
2188 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2189 (x_own_selection, x_get_local_selection, x_convert_selection):
2190 New arg, specifying work frame. Use terminal-local Vselection_alist.
2191 (some_frame_on_display): Delete unused function.
2192 (Fx_own_selection_internal, Fx_get_selection_internal)
2193 (Fx_disown_selection_internal, Fx_selection_owner_p)
2194 (Fx_selection_exists_p): New optional frame arg.
2195 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2196 (x_handle_selection_clear): Don't treat other terminals with the
2197 same keyboard specially. Use the terminal-local Vselection_alist.
2198 (x_clear_frame_selections): Use Frun_hook_with_args.
2200 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2202 * xterm.h: Add support for those atoms.
2204 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2206 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2207 (converted_selections, conversion_fail_tag): New global variables.
2208 (x_selection_request_lisp_error): Free the above.
2209 (x_get_local_selection): Remove unnecessary code.
2210 (x_reply_selection_request): Args changed; handle arbitrary array
2211 of converted selections stored in converted_selections.
2212 Separate the XChangeProperty and SelectionNotify steps.
2213 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2214 (x_convert_selection): New function.
2215 (x_handle_selection_event): Simplify.
2216 (x_get_foreign_selection): Don't ignore incoming requests while
2217 waiting for an answer; this will fail when we implement
2218 SAVE_TARGETS, and seems unnecessary anyway.
2219 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2220 (Vx_sent_selection_functions): Doc fix.
2222 2011-05-26 Leo Liu <sdl.web@gmail.com>
2224 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2226 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2228 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2230 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2231 for fringe update if it has periodic bitmap.
2232 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2233 and fringe_bitmap_periodic_p.
2235 * fringe.c (get_fringe_bitmap_data): New function.
2236 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2237 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2238 row. Mark glyph row for fringe update if periodicity changed.
2240 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2241 for fringe update unless it has periodic bitmap.
2243 2011-05-25 Kenichi Handa <handa@m17n.org>
2245 * xdisp.c (get_next_display_element): Set correct it->face_id for
2246 a static composition.
2248 2011-05-24 Leo Liu <sdl.web@gmail.com>
2251 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2253 * fns.c (crypto_hash_function, Fsha1): New function.
2254 (Fmd5): Use crypto_hash_function.
2255 (syms_of_fns): Add Ssha1.
2257 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2259 * gnutls.c: Remove unused macros.
2260 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2261 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2262 Remove macros that are defined and never used.
2263 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2265 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2267 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2268 (Fx_get_selection_internal): Minor cleanup.
2269 (Fx_own_selection_internal): Rename arguments for consistency with
2272 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2274 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2276 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2278 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2280 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2282 * dispnew.c (scrolling_window): Don't exclude the case that the
2283 last enabled row in the desired matrix touches the bottom boundary.
2285 2011-05-21 Glenn Morris <rgm@gnu.org>
2287 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2288 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2289 and add some more files.
2291 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2293 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2294 report_file_error introduced by the change from 2011-05-07.
2296 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2298 * systime.h (Time): Define only if emacs is defined.
2299 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2300 where the include path doesn't have X11/X.h by default. See
2301 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2303 2011-05-20 Kenichi Handa <handa@m17n.org>
2305 * composite.c (find_automatic_composition): Fix previous change.
2307 2011-05-20 Glenn Morris <rgm@gnu.org>
2309 * lisp.mk: New file, split from Makefile.in.
2310 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2311 (shortlisp): Remove.
2312 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2314 2011-05-19 Glenn Morris <rgm@gnu.org>
2316 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2317 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2318 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2319 (lisp): Set the order to that of loadup.el.
2320 (shortlisp): Make it a copy of $lisp.
2321 (SOME_MACHINE_LISP): Remove.
2322 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2323 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2325 2011-05-18 Kenichi Handa <handa@m17n.org>
2327 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2328 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2329 (find_automatic_composition): Mostly rewrite for efficiency.
2331 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2333 * makefile.w32-in: Update dependencies.
2335 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2337 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2338 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2340 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2342 Fix some integer overflow issues, such as string length overflow.
2344 * insdel.c (count_size_as_multibyte): Check for string overflow.
2346 * character.c (lisp_string_width): Check for string overflow.
2347 Use EMACS_INT, not int, for string indexes and lengths; in
2348 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2349 the resulting string length overflows an EMACS_INT; instead,
2350 report a string overflow if no precision given. When checking for
2351 precision exhaustion, use a check that cannot possibly have
2352 integer overflow. (Bug#8675)
2353 * character.h (lisp_string_width): Adjust to new signature.
2355 * alloc.c (string_overflow): New function.
2356 (Fmake_string): Use it. This doesn't change behavior, but saves
2357 a few bytes and will simplify future changes.
2358 * character.c (string_escape_byte8): Likewise.
2359 * lisp.h (string_overflow): New decl.
2361 Fixups, following up to the user-interface timestamp change.
2362 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2363 for UI timestamps, instead of unsigned long.
2364 * msdos.c (mouse_get_pos): Likewise.
2365 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2366 * w32gui.h (Time): Define by including "systime.h" rather than by
2367 declaring it ourselves. (Bug#8664)
2369 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2370 * image.c (clear_image_cache): Likewise.
2372 * term.c (term_mouse_position): Don't assume time_t wraparound.
2374 Be more systematic about user-interface timestamps.
2375 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2376 and sometimes 'EMACS_UINT', to represent these timestamps.
2377 This change causes it to use 'Time' uniformly, as that's what X uses.
2378 This makes the code easier to follow, and makes it easier to catch
2379 integer overflow bugs such as Bug#8664.
2380 * frame.c (Fmouse_position, Fmouse_pixel_position):
2381 Use Time, not unsigned long, for user-interface timestamps.
2382 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2383 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2384 * keyboard.h (last_event_timestamp): Likewise.
2385 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2386 * menu.h (xmenu_show): Likewise.
2387 * term.c (term_mouse_position): Likewise.
2388 * termhooks.h (struct input_event.timestamp): Likewise.
2389 (struct terminal.mouse_position_hook): Likewise.
2390 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2391 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2392 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2393 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2395 * menu.h, termhooks.h: Include "systime.h", for Time.
2397 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2398 Don't assume that the difference between two unsigned long values
2399 can fit into an integer. At this point, we know button_down_time
2400 <= event->timestamp, so the difference must be nonnegative, so
2401 there's no need to cast the result if double-click-time is
2402 nonnegative, as it should be; check that it's nonnegative, just in
2403 case. This bug is triggered when events are more than 2**31 ms
2404 apart (about 25 days). (Bug#8664)
2406 * xselect.c (last_event_timestamp): Remove duplicate decl.
2407 (x_own_selection): Remove needless cast to unsigned long.
2409 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2410 that always fit in int. Use a sentinel instead of a counter, to
2411 avoid a temp and to allay GCC's concerns about possible int overflow.
2412 * frame.h (struct frame): Use int for menu_bar_items_used
2413 instead of EMACS_INT, since it always fits in int.
2415 * menu.c (grow_menu_items): Check for int overflow.
2417 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2419 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2420 Before, the code was not consistent. These values cannot exceed
2421 2**31 - 1 so there's no need to make them unsigned.
2422 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2423 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2424 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2426 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2428 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2429 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2430 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2431 presumably because the widths might not match.
2433 * window.c (size_window): Avoid needless test at loop start.
2435 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2437 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2439 2011-05-12 Drew Adams <drew.adams@oracle.com>
2441 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2443 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2445 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2446 `width' to `bar_area_x' and `bar_area_width', respectively.
2447 (x_scroll_run): Take account of fringe background extension.
2449 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2450 Rename local vars `left' and `width' to `bar_area_x' and
2451 `bar_area_width', respectively.
2452 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2453 background extension.
2455 2011-05-10 Jim Meyering <meyering@redhat.com>
2457 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2459 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2461 * image.c (Finit_image_library): Return t for built-in image types,
2462 like pbm and xbm. (Bug#8640)
2464 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2466 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2468 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2470 * w32console.c (Fset_screen_color): Doc fix.
2471 (Fget_screen_color): New function.
2472 (syms_of_ntterm): Defsubr it.
2474 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2475 unlink the temporary file if Fcall_process didn't create it in the
2477 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2478 child process will be redirected to a file specified with `:file'.
2479 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2480 cue to call_process_cleanup not to close that handle.
2482 2011-05-07 Ben Key <bkey76@gmail.com>
2484 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2485 one of two shell specific rules, either bootstrap-temacs-CMD or
2486 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2487 to the previous implementation of the bootstrap-temacs rule.
2488 The bootstrap-temacs-CMD rule is similar to the previous
2489 implementation of the bootstrap-temacs rule except that it
2490 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2493 These changes, along with some changes to nt/configure.bat,
2494 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2495 earlier fix to add support for --cflags and --ldflags options
2496 that include quotes so that it works whether make uses cmd or
2499 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2501 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2502 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2504 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2505 a string. Handle both cases.
2506 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2507 (Fdbus_register_method): Use Qinvalid_function.
2509 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2511 * makefile.w32-in: Update dependencies.
2512 (LISP_H): Add inttypes.h and stdin.h.
2513 (PROCESS_H): Add unistd.h.
2515 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2517 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2518 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2520 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2522 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2524 * term.c (vfatal): Remove stray call to va_end.
2525 It's not needed and the C Standard doesn't allow it here anyway.
2527 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2528 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2530 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2533 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2535 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2537 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2539 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2541 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2543 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2544 * charset.c (Fdefine_charset_internal): Don't initialize
2545 charset.code_space[15]. The value was garbage, on hosts with
2546 32-bit int (Bug#8600).
2548 * lread.c (read_integer): Be more consistent with string-to-number.
2549 Use string_to_number to do the actual conversion; this avoids
2550 rounding errors and fixes some other screwups. Without this fix,
2551 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2552 (digit_to_number): Move earlier, for benefit of read_integer.
2553 Return -1 if the digit is out of range for the base, -2 if it is
2554 not a digit in any supported base. (Bug#8602)
2556 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2558 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2559 to match comment at start of function. This also removes a
2560 GCC warning about overflow in a 32+64-bit port.
2562 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2564 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2565 Reported by Stefan Monnier in
2566 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2567 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2568 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2570 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2571 (EMACS_UINTPTR): Likewise, with uintptr_t.
2573 * lisp.h: Prefer 64-bit EMACS_INT if available.
2574 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2575 on 32-bit hosts that have 64-bit int, so that they can access
2577 However, temporarily disable this change unless the temporary
2578 symbol WIDE_EMACS_INT is defined.
2580 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2582 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2583 This removes an assumption that EMACS_INT and long are the same
2584 width as pointers. The assumption is true for Emacs porting targets
2585 now, but we want to make other targets possible.
2586 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2587 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2588 In the rest of the code, change types of integers that hold casted
2589 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2590 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2591 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2592 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2593 No need to cast type when ORing.
2594 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2595 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2596 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2597 assume EMACS_INT is the same width as char *.
2598 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2599 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2600 Remove no-longer-needed casts.
2601 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2602 (xg_tool_bar_help_callback, xg_make_tool_item):
2603 Use EMACS_INTPTR to hold an integer
2604 that will be cast to void *; this can avoid a GCC warning
2605 if EMACS_INT is not the same width as void *.
2606 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2607 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2608 (current_message_1, set_message_1):
2609 Use a local to convert to proper width without a cast.
2610 * xmenu.c (dialog_selection_callback): Likewise.
2612 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2613 Also, don't assume VALBITS / RAND_BITS is less than 5,
2614 and don't rely on undefined behavior when shifting a 1 left into
2616 * lisp.h (get_random): Change signature to match.
2618 * lread.c (hash_string): Use size_t, not int, for hash computation.
2619 Normally we prefer signed values; but hashing is special, because
2620 it's better to use unsigned division on hash table sizes so that
2621 the remainder is nonnegative. Also, size_t is the natural width
2622 for hashing into memory. The previous code used 'int', which doesn't
2623 retain enough info to hash well into very large tables.
2624 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2626 * dbusbind.c: Don't possibly lose pointer info when converting.
2627 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2628 Use XPNTR rather than XHASH, so that the high-order bits of
2629 the pointer aren't lost when converting through void *.
2631 * eval.c (Fautoload): Don't double-shift a pointer.
2633 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2635 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2637 * gnutls.c (DEF_GNUTLS_FN):
2638 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2640 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2642 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2645 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2647 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2648 New version that can reserve upto 2GB of heap space.
2650 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2652 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2654 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2656 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2657 `gnutls_certificate_set_x509_key_file'.
2659 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2661 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2662 Update dependencies.
2664 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2666 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2667 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2668 Remove unused parameter `fildes'.
2669 * process.c (read_process_output, send_process): Don't pass it.
2671 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2673 Fix previous change: the library cache is defined in w32.c.
2674 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2675 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2677 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2679 Implement dynamic loading of GnuTLS on Windows.
2681 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2682 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2683 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2686 * gnutls.c (Qgnutls_dll): Define.
2687 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2688 (gnutls_*): Declare function pointers.
2689 (init_gnutls_functions): New function to initialize function pointers.
2690 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2691 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2692 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2693 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2694 (emacs_gnutls_write, emacs_gnutls_read)
2695 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2696 (Fgnutls_available_p): New function.
2697 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2698 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2699 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2701 * image.c: Include w32.h.
2702 (Vimage_type_cache): Delete.
2703 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2704 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2705 (w32_delayed_load): Move to w32.c.
2707 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2709 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2710 (w32_delayed_load): Move from image.c. When loading a library, record
2711 its filename in the :loaded-from property of the library id.
2712 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2713 Initialize and staticpro them.
2714 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2716 * process.c: Include lisp.h before w32.h, not after.
2717 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2718 instead of gnutls_record_check_pending.
2720 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2722 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2724 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2725 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2728 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2730 * xterm.c (x_set_frame_alpha): Do not set property on anything
2731 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2733 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2735 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2737 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2739 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2740 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2741 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2742 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2743 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2744 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2745 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2746 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2747 (Qgnutls_bootprop_callbacks_verify): Make static.
2749 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2751 * callproc.c: Indentation fixup.
2753 * sysdep.c (wait_for_termination_1): Make static.
2754 (wait_for_termination, interruptible_wait_for_termination):
2755 Move after wait_for_termination_1.
2757 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2759 * sysdep.c (interruptible_wait_for_termination): New function
2760 which is like wait_for_termination, but allows keyboard
2763 * callproc.c (Fcall_process): Add (:file "file") as an option for
2765 (Fcall_process_region): Ditto.
2767 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2769 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2770 rather than `XVECTOR (FOO)->size'.
2772 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2773 inttypes.h, as a gnulib replacement is used if it not available in
2776 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2778 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2779 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2780 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2782 * coding.c (coding_alloc_by_realloc): Error out if destination
2783 will grow beyond MOST_POSITIVE_FIXNUM.
2784 (decode_coding_emacs_mule): Abort if there isn't enough place in
2785 charbuf for the composition carryover bytes. Reserve an extra
2786 space for up to 2 characters produced in a loop.
2787 (decode_coding_iso_2022): Abort if there isn't enough place in
2788 charbuf for the composition carryover bytes.
2790 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2792 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2793 aborting when %lld or %lll format is passed.
2794 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2795 %llo or %llx format is passed. (Bug#8545)
2797 * window.c (window_scroll_line_based): Use a marker instead of
2798 simple variables to record original value of point. (Bug#7952)
2800 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2801 produced by %s or %c overflows available buffer space. (Bug#8545)
2803 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2805 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2806 (SIZE_MAX): Move defn after all includes, as they might #define it.
2808 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2810 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2812 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2814 * keyboard.c (Qdelayed_warnings_hook): Define.
2815 (command_loop_1): Run `delayed-warnings-hook'
2816 if Vdelayed_warnings_list is non-nil.
2817 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2818 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2820 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2822 * doprnt.c (doprnt): Don't return value smaller than the buffer
2823 size if the message was truncated. (Bug#8545).
2825 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2827 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2828 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2830 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2832 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2834 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2836 * makefile.w32-in: Update dependencies.
2838 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2840 Improve `doprnt' and its usage. (Bug#8545)
2841 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2842 `format_end'. Remove support for %l as a conversion specifier.
2843 Don't use xrealloc. Improve diagnostics when the %l size modifier
2844 is used. Update the commentary.
2846 * eval.c (verror): Simplify calculation of size_t.
2848 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2851 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2853 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2856 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2858 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2859 This makes this file independent of the recent pseudovector change.
2861 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2863 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2865 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2866 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2867 Remove unused local.
2868 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2870 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2871 GCC 4.6.0 optimizes based on type-based alias analysis.
2872 For example, if b is of type struct buffer * and v of type struct
2873 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2874 != &v->size, and therefore "v->size = 1; b->size = 2; return
2875 v->size;" must therefore return 1. This assumption is incorrect
2876 for Emacs, since it type-puns struct Lisp_Vector * with many other
2877 types. To fix this problem, this patch adds a new type struct
2878 vectorlike_header that documents the constraints on layout of vectors
2879 and pseudovectors, and helps optimizing compilers not get fooled
2880 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2881 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2882 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2884 (XSETPVECTYPE): Rewrite in terms of new macro.
2885 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2886 This is a bit clearer, and further avoids the possibility of
2887 undesirable aliasing.
2888 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2889 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2890 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2891 since Lisp_Subr is a special case (no "next" field).
2892 (ASIZE): Now uses header.size rather than size.
2893 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2894 to avoid the hassle of writing XVECTOR (foo)->header.size.
2895 (struct vectorlike_header): New type.
2896 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2897 object, to help avoid aliasing.
2898 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2899 (SUBRP): Likewise, since Lisp_Subr is a special case.
2900 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2901 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2902 (struct Lisp_Hash_Table): Combine first two members into a single
2903 struct vectorlike_header member. All uses of "size" and "next" members
2904 changed to be "header.size" and "header.next".
2905 * buffer.h (struct buffer): Likewise.
2906 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2907 * frame.h (struct frame): Likewise.
2908 * process.h (struct Lisp_Process): Likewise.
2909 * termhooks.h (struct terminal): Likewise.
2910 * window.c (struct save_window_data, struct saved_window): Likewise.
2911 * window.h (struct window): Likewise.
2912 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2913 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2914 * buffer.c (init_buffer_once): Likewise.
2915 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2917 * process.c (Fformat_network_address): Use local var for size,
2920 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2922 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2923 * data.c (atof): Remove decl; no longer used or needed.
2924 (digit_to_number): Move to lread.c.
2925 (Fstring_to_number): Use new string_to_number function, to be
2926 consistent with how the Lisp reader treats infinities and NaNs.
2927 Do not assume that floating-point numbers represent EMACS_INT
2928 without losing information; this is not true on most 64-bit hosts.
2929 Avoid double-rounding errors, by insisting on integers when
2930 parsing non-base-10 numbers, as the documentation specifies.
2931 * lisp.h (string_to_number): New decl, replacing ...
2932 (isfloat_string): Remove.
2933 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2934 (read1): Do not accept +. and -. as integers; this
2935 appears to have been a coding error. Similarly, do not accept
2936 strings like +-1e0 as floating point numbers. Do not report
2937 overflow for integer overflows unless the base is not 10 which
2938 means we have no simple and reliable way to continue.
2939 Break out the floating-point parsing into a new
2940 function string_to_number, so that Fstring_to_number parses
2941 floating point numbers consistently with the Lisp reader.
2942 (digit_to_number): Move here from data.c. Make it static inline.
2943 (E_CHAR, EXP_INT): Remove, replacing with ...
2944 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2945 (string_to_number): New function, replacing isfloat_string.
2946 This function checks for valid syntax and produces the resulting
2947 Lisp float number too. Rework it so that string-to-number
2948 no longer mishandles examples like "1.0e+". Use strtoumax,
2949 so that overflow for non-base-10 numbers is reported only when
2950 there's no portable and simple way to convert to floating point.
2952 * textprop.c (set_text_properties_1): Rewrite for clarity,
2953 and to avoid GCC warning about integer overflow.
2955 * intervals.h (struct interval): Use EMACS_INT for members
2956 where EMACS_UINT might cause problems. See
2957 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2958 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2959 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2961 (offset_intervals): Tell GCC not to worry about length overflow
2962 when negating a negative length.
2964 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2965 (overrun_check_free): Likewise.
2967 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2968 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2971 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2972 (gnutls_make_error): Rename local to avoid shadowing.
2973 (gnutls_emacs_global_deinit): ifdef out; not used.
2974 (Fgnutls_boot): Use const for pointer to readonly storage.
2975 Comment out unused local. Fix pointer signedness problems.
2977 * lread.c (openp): Don't stuff size_t into an 'int'.
2978 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2979 about possible signed overflow.
2981 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2982 (GDK_KEY_g): Don't define if already defined.
2983 (xg_prepare_tooltip): Avoid pointer signedness problem.
2984 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2986 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2987 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2989 * xfns.c (Fx_window_property): Simplify a bit,
2990 to make a bit faster and to avoid GCC 4.6.0 warning.
2991 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2993 * fns.c (internal_equal): Don't assume size_t fits in int.
2995 * alloc.c (compact_small_strings): Tighten assertion a little.
2997 Replace pEd with more-general pI, and fix some printf arg casts.
2998 * lisp.h (pI): New macro, generalizing old pEd macro to other
2999 conversion specifiers. For example, use "...%"pI"d..." rather
3000 than "...%"pEd"...".
3001 (pEd): Remove. All uses replaced with similar uses of pI.
3002 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3003 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3004 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3005 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3006 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3007 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3008 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3010 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3011 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3012 * print.c (safe_debug_print, print_object): Likewise.
3013 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3015 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3016 avoiding the 0 flag, which is not portable.
3017 * process.c (Fmake_network_process): Use pI to avoid cast.
3018 * region-cache.c (pp_cache): Likewise.
3019 * xdisp.c (decode_mode_spec): Likewise.
3020 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3021 behavior on 64-bit hosts with printf arg.
3022 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3023 (x_stop_queuing_selection_requests): Likewise.
3024 (x_get_window_property): Don't truncate byte count to an 'int'
3027 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3028 here, since it parses constructs like leading '-' and spaces,
3029 which are not wanted; and it overflows with large numbers.
3030 Instead, simply match F[0-9]+, which is what is wanted anyway.
3032 * alloc.c: Remove unportable assumptions about struct layout.
3033 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3034 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3035 (allocate_vectorlike, make_pure_vector): Use the new macros,
3036 plus offsetof, to remove unportable assumptions about struct layout.
3037 These assumptions hold on all porting targets that I know of, but
3038 they are not guaranteed, they're easy to remove, and removing them
3039 makes further changes easier.
3041 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3042 This doesn't fix a bug but makes the code clearer.
3043 (string_overrun_cookie): Now const. Use initializers that
3044 don't formally overflow signed char, to avoid warnings.
3045 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3046 can cause Emacs to crash when string overrun checking is enabled.
3047 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3048 multiple of sizeof (EMACS_INT); it need not be, if
3049 alignof(EMACS_INT) < sizeof (EMACS_INT).
3050 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3052 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3054 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3056 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3058 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3059 supposed to be handshaking. (Bug#8556)
3060 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3062 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3064 * lisp.h (Qdebug): List symbol.
3065 * eval.c (Qdebug): Restore global linkage.
3066 * keyboard.c (debug-on-event): New variable.
3067 (handle_user_signal): Break into debugger when debug-on-event
3068 matches the current signal symbol.
3070 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3072 * alloc.c (check_sblock, check_string_bytes)
3073 (check_string_free_list): Convert to standard C.
3075 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3077 * w32.c (emacs_gnutls_push): Fix typo.
3079 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3081 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3082 "cast to pointer from integer of different size".
3084 Improve doprnt and its use in verror. (Bug#8545)
3085 * doprnt.c (doprnt): Document the set of format control sequences
3086 supported by the function. Use SAFE_ALLOCA instead of always
3089 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3090 is one byte too soon. Don't use xrealloc; instead xfree and
3093 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3095 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3098 * gnutls.c: Renamed global_initialized to
3099 gnutls_global_initialized. Added internals for the
3100 :verify-hostname-error, :verify-error, and :verify-flags
3101 parameters of `gnutls-boot' and documented those parameters in the
3102 docstring. Start callback support.
3103 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3104 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3105 on error. Return error code.
3106 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3107 (emacs_gnutls_read): Likewise.
3108 (Fgnutls_boot): Return handshake error code.
3109 (emacs_gnutls_handle_error): New function.
3110 (wsaerror_to_errno): Likewise.
3112 * w32.h (emacs_gnutls_pull): Add prototype.
3113 (emacs_gnutls_push): Likewise.
3115 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3116 (emacs_gnutls_push): Likewise.
3118 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3120 * process.c (wait_reading_process_output): Check if GnuTLS
3121 buffered some data internally if no FDs are set for TLS
3124 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3125 (LIBS): Link to USER_LIBS.
3126 ($(BLD)/gnutls.$(0)): New target.
3128 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3130 * xdisp.c (handle_single_display_spec): Rename the
3131 display_replaced_before_p argument into display_replaced_p, to
3132 make it consistent with the commentary. Fix typos in the
3135 * textprop.c (syms_of_textprop): Remove dead code.
3136 (copy_text_properties): Delete obsolete commentary about an
3137 interface that was deleted long ago. Fix typos in the description
3140 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3141 to changes in oldXMenu/XMenu.h from 2011-04-16.
3142 <menu_help_message, prev_menu_help_message>: Constify.
3143 (IT_menu_make_room): menu->help_text is now `const char **';
3146 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3147 to changes in oldXMenu/XMenu.h from 2011-04-16.
3148 (struct XMenu): Declare `help_text' `const char **'.
3150 * xfaces.c <Qunspecified>: Make extern again.
3152 * syntax.c: Include sys/types.h before including regex.h, as
3155 * doc.c (get_doc_string): Improve the format passed to `error'.
3157 * doprnt.c (doprnt): Improve commentary.
3159 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3161 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3164 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3165 changes in globals.h immediately force recompilation.
3166 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3167 $(CURDIR)/s/ms-w32.h.
3168 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3170 * character.c (Fchar_direction): Function deleted.
3171 (syms_of_character): Don't defsubr it.
3172 <char-direction-table>: Deleted.
3174 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3176 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3177 * doprnt.c: Include limits.h.
3178 (SIZE_MAX): New macro.
3179 (doprnt): Return a size_t value. 2nd arg is now size_t.
3180 Many local variables are now size_t instead of int or unsigned.
3181 Improve overflow protection. Support `l' modifier for integer
3182 conversions. Support %l conversion. Don't assume an EMACS_INT
3183 argument for integer conversions and for %c.
3185 * lisp.h (doprnt): Restore prototype.
3187 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3190 * Makefile.in (base_obj): Add back doprnt.o.
3192 * deps.mk (doprnt.o): Add back prerequisites.
3193 (callint.o): Depend on character.h.
3195 * eval.c (internal_lisp_condition_case): Include the handler
3196 representation in the error message.
3197 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3198 when breaking from the loop.
3200 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3202 * callint.c (Fcall_interactively): When displaying error message
3203 about invalid control letter, pass the character's codepoint, not
3204 a pointer to its multibyte form. Improve display of the character
3205 in octal and display also its hex code.
3207 * character.c (char_string): Use %x to display the (unsigned)
3208 codepoint of an invalid character, to avoid displaying a bogus
3211 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3212 `error', not SYMBOL_NAME itself.
3214 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3215 character arguments to `error'.
3217 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3218 to `error' in error message about FINAL_CHAR argument. Make sure
3219 FINAL_CHAR is a character, and use %c when it is passed as
3220 argument to `error'.
3222 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3224 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3226 * w32.c: Include <time.h>.
3227 (sys_localtime): New function.
3229 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3231 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3233 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3235 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3237 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3240 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3242 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3243 gl_state.e_property when gl_state.object is Qt.
3245 * insdel.c (make_gap_larger): Remove limitation of buffer size
3248 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3250 * xdisp.c (lookup_glyphless_char_display)
3251 (produce_glyphless_glyph): Handle cons cell entry in
3252 glyphless-char-display.
3253 (Vglyphless_char_display): Document it.
3255 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3256 glyphless-char-display.
3258 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3260 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3262 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3264 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3265 definition for no-X builds.
3267 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3269 Static checks with GCC 4.6.0 and non-default toolkits.
3271 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3273 * process.c (keyboard_bit_set): Define only if SIGIO.
3274 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3275 (send_process): Repair possible setjmp clobbering.
3277 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3279 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3281 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3283 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3284 Define only if needed.
3286 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3287 by pacifying GCC about it. Maybe it's time to retire it?
3288 * xfaces.c (USG, __TIMEVAL__): Likewise.
3290 * dispextern.h (struct redisplay_interface): Rename param
3292 * termhooks.h (struct terminal): Likewise.
3293 * xterm.c (xembed_send_message): Likewise.
3295 * insdel.c (make_gap_smaller): Define only if
3296 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3298 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3301 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3302 so that we aren't warned about unused symbols.
3304 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3306 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3308 * xfns.c (x_real_positions): Mark locals as initialized.
3310 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3312 * xterm.c: Fix problems found by static analysis with other toolkits.
3313 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3314 (x_dispatch_event): Declare static if USE_GTK, and
3315 define if USE_GTK || USE_X_TOOLKIT.
3316 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3317 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3318 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3319 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3321 * xmenu.c (menu_help_callback): Pointer type fixes.
3322 Use const pointers when pointing at readonly data. Avoid pointer
3324 (FALSE): Remove unused macro.
3325 (update_frame_menubar): Remove unused decl.
3327 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3329 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3330 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3331 (single_menu_item): Rename local to avoid shadowing.
3333 * keyboard.c (make_lispy_event): Remove unused local var.
3335 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3336 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3338 * bitmaps: Change bitmaps from unsigned char back to the X11
3339 compatible char. Avoid the old compiler warnings about
3340 out-of-range initializers by using, for example, '\xab' rather
3343 * xgselect.c (xgselect_initialize): Check vs interface
3344 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3346 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3348 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3349 to read-only memory.
3351 * fns.c (vector): Remove; this old hack is no longer needed.
3353 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3355 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3357 * xrdb.c (x_load_resources): Omit unused local.
3359 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3360 (x_window): Rename locals to avoid shadowing.
3361 (USG): Use the kludged USG macro, to pacify gcc.
3363 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3364 (x_term_init): Remove local to avoid shadowing.
3366 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3368 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3369 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3371 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3373 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3375 Fix regex.c, syntax.c and friends for buffers > 2GB.
3376 * syntax.h (struct gl_state_s): Declare character position members
3379 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3381 * textprop.c (verify_interval_modification, interval_of):
3382 Declare arguments EMACS_INT.
3384 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3387 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3389 * indent.c (Fvertical_motion): Local variable it_start is now
3392 * regex.c (re_match, re_match_2, re_match_2_internal)
3393 (bcmp_translate, regcomp, regexec, print_double_string)
3394 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3395 (re_compile_pattern, re_exec): Declare arguments and local
3396 variables `size_t' and `ssize_t' and return values `regoff_t', as
3398 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3399 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3400 <compile_stack_type>: `size' and `avail' are now `size_t'.
3402 * regex.h <regoff_t>: Use ssize_t, not int.
3403 (re_search, re_search_2, re_match, re_match_2): Arguments that
3404 specify buffer/string position and length are now ssize_t and
3405 size_t. Return type is regoff_t.
3407 2011-04-16 Ben Key <bkey76@gmail.com>
3409 * nsfont.m: Fixed bugs in ns_get_family and
3410 ns_descriptor_to_entity that were caused by using free to
3411 deallocate memory blocks that were allocated by xmalloc (via
3412 xstrdup). This caused Emacs to crash when compiled with
3413 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3414 --enable-checking=xmallocoverrun). xfree is now used to
3415 deallocate these memory blocks.
3417 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3419 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3421 emacs_write: Accept and return EMACS_INT for sizes.
3422 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3424 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3425 Accept and return EMACS_INT.
3426 (emacs_gnutls_write): Return the number of bytes written on
3428 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3429 (emacs_read, emacs_write): Remove check for negative size, as the
3430 Emacs source code has been audited now.
3431 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3432 (emacs_read, emacs_write): Use it.
3433 * process.c (send_process): Adjust to the new signatures of
3434 emacs_write and emacs_gnutls_write. Do not attempt to store
3435 a byte offset into an 'int'; it might overflow.
3436 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3438 * sound.c: Don't assume sizes fit in 'int'.
3439 (struct sound_device.period_size, alsa_period_size):
3440 Return EMACS_INT, not int.
3441 (struct sound_device.write, vox_write, alsa_write):
3442 Accept EMACS_INT, not int.
3443 (wav_play, au_play): Use EMACS_INT to store sizes and to
3444 record read return values.
3446 2011-04-15 Ben Key <bkey76@gmail.com>
3448 * keyboard.c (Qundefined): Don't declare static since it is used
3450 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3451 static since they are used in nsfont.m.
3453 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3455 * process.c (Qprocessp): Don't declare static.
3456 * lisp.h (Qprocessp): Declare again.
3458 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3460 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3462 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3464 Improve C-level modularity by making more things 'static'.
3466 Don't publish debugger-only interfaces to other modules.
3467 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3468 (verify_bytepos, count_markers): Move decls to the only modules
3470 * region-cache.h (pp_cache): Likewise.
3471 * window.h (check_all_windows): Likewise.
3472 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3474 * sysdep.c (croak): Now static, if
3475 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3476 * syssignal.h (croak): Declare only if not static.
3478 * alloc.c (refill_memory_reserve): Now static if
3479 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3480 * lisp.h (refill_memory_reserve): Declare only if not static.
3482 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3483 Define only if USE_LUCID.
3485 * xrdb.c (x_customization_string, x_rm_string): Now static.
3487 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3488 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3490 * xdisp.c (draw_row_with_mouse_face): Now static.
3491 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3493 * window.h (check_all_windows): Mark externally visible.
3495 * window.c (window_deletion_count): Now static.
3497 * undo.c: Make symbols static if they're not exported.
3498 (last_undo_buffer, last_boundary_position, pending_boundary):
3501 * textprop.c (interval_insert_behind_hooks): Now static.
3502 (interval_insert_in_front_hooks): Likewise.
3504 * term.c: Make symbols static if they're not exported.
3505 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3506 (max_frame_lines, tty_set_terminal_modes):
3507 (tty_reset_terminal_modes, tty_turn_off_highlight):
3508 (get_tty_terminal): Now static.
3509 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3510 * termhooks.h (term_mouse_moveto): Do not declare if
3512 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3513 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3515 * sysdep.c: Make symbols static if they're not exported.
3516 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3518 (sigprocmask_set, full_mask): Remove; unused.
3519 (wait_debugging): Mark as visible.
3520 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3521 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3523 * syntax.c (syntax_temp): Define only if !__GNUC__.
3525 * sound.c (current_sound_device, current_sound): Now static.
3527 * search.c (searchbufs, searchbuf_head): Now static.
3529 * scroll.c (scroll_cost): Remove; unused.
3530 * dispextern.h (scroll_cost): Remove decl.
3532 * region-cache.h (pp_cache): Mark as externally visible.
3534 * process.c: Make symbols static if they're not exported.
3535 (process_tick, update_tick, create_process, chan_process):
3536 (Vprocess_alist, proc_buffered_char, datagram_access):
3537 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3538 (deactivate_process): Mark defn as static, as well as decl.
3539 * lisp.h (create_process): Remove decl.
3540 * process.h (chan_process, Vprocess_alist): Remove decls.
3542 * print.c: Make symbols static if they're not exported.
3543 (print_depth, new_backquote_output, being_printed, print_buffer):
3544 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3545 (print_interval, print_number_index, initial_stderr_stream):
3547 * lisp.h (Fprinc): Remove decl.
3548 (debug_output_compilation_hack): Mark as externally visible.
3550 * sysdep.c (croak): Move decl from here to syssignal.h.
3551 * syssignal.h (croak): Put it here, so the API can be checked when
3552 'croak' is called from dissociate_if_controlling_tty.
3554 * minibuf.c: Make symbols static if they're not exported.
3555 (minibuf_save_list, choose_minibuf_frame): Now static.
3556 * lisp.h (choose_minibuf_frame): Remove decl.
3558 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3560 * lread.c: Make symbols static if they're not exported.
3561 (read_objects, initial_obarray, oblookup_last_bucket_number):
3563 (make_symbol): Remove; unused.
3564 * lisp.h (initial_obarray, make_symbol): Remove decls.
3566 * keyboard.c: Make symbols static if they're not exported.
3567 (single_kboard, recent_keys_index, total_keys, recent_keys):
3568 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3569 (this_single_command_key_start, echoing, last_auto_save):
3570 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3571 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3572 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3573 (Vlispy_mouse_stem, double_click_count):
3575 (force_auto_save_soon): Define only if SIGDANGER.
3576 (ignore_mouse_drag_p): Now static if
3577 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3578 (print_help): Remove; unused.
3579 (stop_character, last_timer_event): Mark as externally visible.
3580 * keyboard.h (ignore_mouse_drag_p): Declare only if
3581 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3582 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3583 * lisp.h (echoing): Remove decl.
3584 (force_auto_save_soon): Declare only if SIGDANGER.
3585 * xdisp.c (redisplay_window): Simplify code, to make it more
3586 obvious that ignore_mouse_drag_p is not accessed if !defined
3587 USE_GTK && !defined HAVE_NS.
3589 * intervals.c: Make symbols static if they're not exported.
3590 (merge_properties_sticky, merge_interval_right, delete_interval):
3592 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3594 * insdel.c: Make symbols static if they're not exported.
3595 However, leave prepare_to_modify_buffer alone. It's never
3596 called from outside this function, but that appears to be a bug.
3597 (combine_after_change_list, combine_after_change_buffer):
3598 (adjust_after_replace, signal_before_change): Now static.
3599 (adjust_after_replace_noundo): Remove; unused.
3600 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3601 (signal_before_change): Remove decls.
3603 * indent.c (val_compute_motion, val_vmotion): Now static.
3605 * image.c: Make symbols static if they're not exported.
3606 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3608 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3609 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3611 * fringe.c (standard_bitmaps): Now static.
3612 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3614 * frame.c: Make symbols static if they're not exported.
3615 (x_report_frame_params, make_terminal_frame): Now static.
3616 (get_frame_param): Now static, unless HAVE_NS.
3617 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3618 (x_get_resource_string): Remove; not used.
3619 * frame.h (make_terminal_frame, x_report_frame_params):
3620 (x_get_resource_string); Remove decls.
3621 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3622 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3624 * font.c, fontset.c: Make symbols static if they're not exported.
3625 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3626 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3627 * font.c (font_close_object): Now static.
3628 * font.h (font_close_object): Remove.
3629 * fontset.c (FONTSET_OBJLIST): Remove.
3630 (free_realized_fontset) #if-0 the body, which does nothing.
3631 (face_suitable_for_char_p): #if-0, as it's never called.
3632 * fontset.h (face_suitable_for_char_p): Remove decl.
3633 * xfaces.c (face_at_string_position):
3634 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3635 since 0 is always ASCII.
3637 * fns.c (weak_hash_tables): Now static.
3639 * fileio.c: Make symbols static if they're not exported.
3640 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3641 (Vwrite_region_annotation_buffers): Now static.
3643 * eval.c: Make symbols static if they're not exported.
3644 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3645 * lisp.h (backtrace_list): Remove decl.
3647 * emacs.c: Make symbols static if they're not exported.
3648 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3649 (fatal_error_code, fatal_error_signal_hook, standard_args):
3651 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3652 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3653 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3654 * lisp.h (fatal_error_signal_hook): Remove decl.
3655 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3657 * editfns.c: Move a (normally-unused) function to its only use.
3658 * editfns.c, lisp.h (get_operating_system_release): Remove.
3659 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3660 worth the hassle of breaking this out.
3662 * xterm.c: Make symbols static if they're not exported.
3663 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3664 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3665 (x_destroy_window, x_delete_display):
3667 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3668 (x_mouse_leave): Remove; unused.
3669 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3670 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3671 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3673 (x_mouse_leave): Declare only if WINDOWSNT.
3674 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3675 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3678 * ftxfont.c: Make symbols static if they're not exported.
3679 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3681 * font.h (ftxfont_driver): Likewise.
3683 * xfns.c: Make symbols static if they're not exported.
3684 (x_last_font_name, x_display_info_for_name):
3685 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3686 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3687 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3688 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3689 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3690 (last_show_tip_args): Now static.
3691 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3692 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3693 (x_screen_planes): Remove; unused.
3694 * dispextern.h (x_screen_planes): Remove decl.
3696 * dispnew.c: Make symbols static if they're not exported.
3697 * dispextern.h (redraw_garbaged_frames, scrolling):
3698 (increment_row_positions): Remove.
3699 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3700 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3702 (redraw_garbaged_frames): Remove; unused.
3704 * xfaces.c: Make symbols static if they're not exported.
3705 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3707 * xterm.h (defined_color): Remove decls.
3708 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3709 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3710 (menu_face_changed_default, defined_color, free_realized_face):
3711 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3712 (ascii_face_of_lisp_face): Remove; unused.
3714 * xdisp.c: Make symbols static if they're not exported.
3715 * dispextern.h (scratch_glyph_row, window_box_edges):
3716 (glyph_to_pixel_coords, set_cursor_from_row):
3717 (get_next_display_element, set_iterator_to_next):
3718 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3719 (show_mouse_face): Remove decls
3720 * frame.h (message_buf_print): Likewise.
3721 * lisp.h (pop_message, set_message, check_point_in_composition):
3723 * xterm.h (set_vertical_scroll_bar): Likewise.
3724 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3725 (message_buf_print, scratch_glyph_row, displayed_buffer):
3726 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3727 (get_next_display_element, show_mouse_face, window_box_edges):
3728 (frame_to_window_pixel_xy, check_point_in_composition):
3729 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3730 (glyph_to_pixel_coords): Remove; unused.
3732 * dired.c (file_name_completion): Now static.
3734 * dbusbind.c (xd_in_read_queued_messages): Now static.
3736 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3737 * data.c (circular_list_error): Remove.
3739 * commands.h (last_point_position, last_point_position_buffer):
3740 (last_point_position_window): Remove decls.
3741 * keyboard.c: Make these variables static.
3743 * coding.h (coding, code_convert_region, encode_coding_gap):
3745 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3746 (iso_code_class, detect_coding, code_convert_region): Now static.
3747 (encode_coding_gap): Remove; unused.
3749 * chartab.c (chartab_chars, chartab_bits): Now static.
3751 * charset.h (charset_iso_8859_1): Remove decl.
3752 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3755 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3756 * ccl.c (Vccl_program_table): Now static.
3757 (check_ccl_update): Remove; unused.
3759 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3760 * category.h: ... from here.
3761 * category.c (check_category_table, set_category_set): Now static.
3763 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3764 * lisp.h: Remove these decls.
3766 * buffer.c (buffer_count): Remove unused var.
3768 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3769 so that it's not optimized away.
3770 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3771 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3772 exported only to the debugger.
3774 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3775 * atimer.h (run_all_atimers): Remove; not exported.
3777 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3778 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3779 was inaccessible from Lisp.
3780 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3781 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3783 alloc.c: Import and export fewer symbols, and remove unused items.
3784 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3786 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3787 it's not optimized away by whole-program optimization.
3788 (message_enable_multibyte, free_misc): Remove.
3789 (catchlist, handlerlist, mark_backtrace):
3790 Declare only if BYTE_MARK_STACK.
3791 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3792 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3793 (message_enable_multibyte): Remove decl.
3794 (free_misc, interval_free_list, float_block, float_block_index):
3795 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3796 (cons_free_list, last_marked_index):
3798 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3799 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3800 (mark_backtrace): Define only if BYTE_MARK_STACK.
3801 * xdisp.c (message_enable_multibyte): Now static.
3803 Declare Lisp_Object Q* variables to be 'static' if not exported.
3804 This makes it easier for human readers (and static analyzers)
3805 to see whether these variables are used from other modules.
3806 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3807 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3808 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3809 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3810 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3811 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3812 * xmenu.c, xselect.c:
3813 Declare Q* vars static if they are not used in other modules.
3814 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3815 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3816 Remove decls of unexported vars.
3817 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3819 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3821 Make Emacs functions such as Fatom 'static' by default.
3822 This makes it easier for human readers (and static analyzers)
3823 to see whether these functions can be called from other modules.
3824 DEFUN now defines a static function. To make the function external
3825 so that it can be used in other C modules, use the new macro DEFUE.
3826 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3827 (Finit_image_library):
3828 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3829 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3830 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3831 Remove decls, since these functions are now static.
3832 (Funintern, Fget_internal_run_time): New decls, since these functions
3833 were already external.
3835 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3836 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3837 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3838 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3839 * keyboard.c, keymap.c, lread.c:
3840 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3841 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3842 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3843 Mark functions with DEFUE instead of DEFUN,
3844 if they are used in other modules.
3845 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3846 decls for now-static functions.
3847 * buffer.h (Fdelete_overlay): Remove decl.
3848 * callproc.c (Fgetenv_internal): Mark as internal.
3849 * composite.c (Fremove_list_of_text_properties): Remove decl.
3850 (Fcomposition_get_gstring): New forward static decl.
3851 * composite.h (Fcomposite_get_gstring): Remove decl.
3852 * dired.c (Ffile_attributes): New forward static decl.
3853 * doc.c (Fdocumntation_property): New forward static decl.
3854 * eval.c (Ffetch_bytecode): New forward static decl.
3855 (Funintern): Remove extern decl; now in .h file where it belongs.
3856 * fileio.c (Fmake_symbolic_link): New forward static decl.
3857 * image.c (Finit_image_library): New forward static decl.
3858 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3859 * intervals.h (Fprevious_property_change):
3860 (Fremove_list_of_text_properties): Remove decls.
3861 * keyboard.c (Fthis_command_keys): Remove decl.
3862 (Fcommand_execute): New forward static decl.
3863 * keymap.c (Flookup_key): New forward static decl.
3864 (Fcopy_keymap): Now static.
3865 * keymap.h (Flookup_key): Remove decl.
3866 * process.c (Fget_process): New forward static decl.
3867 (Fprocess_datagram_address): Mark as internal.
3868 * syntax.c (Fsyntax_table_p): New forward static decl.
3869 (skip_chars): Remove duplicate decl.
3870 * textprop.c (Fprevious_property_change): New forward static decl.
3871 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3873 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3874 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3876 * editfns.c (Fformat): Remove unreachable code.
3878 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3880 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3883 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3885 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3886 when at ZV. (Bug#8487)
3888 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3890 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3892 * keyboard.c (parse_tool_bar_item): Likewise.
3893 * sound.c (sound_cleanup, alsa_close): Likewise.
3894 * termcap.c (tgetent): Likewise.
3895 * xfns.c (x_default_font_parameter): Likewise.
3896 * xsettings.c (read_and_apply_settings): Likewise.
3898 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3899 (overrun_check_free): Protoize.
3901 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3903 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3904 since callers should never pass a negative size.
3905 Change the signature to match that of plain 'read' and 'write'; see
3906 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3907 * lisp.h: Update prototypes of emacs_write and emacs_read.
3909 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3911 * xdisp.c (redisplay_window): Don't try to determine the character
3912 position of the scroll margin if the window start point w->startp
3913 is outside the buffer's accessible region. (Bug#8468)
3915 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3917 Fix write-region and its subroutines for buffers > 2GB.
3918 * fileio.c (a_write, e_write): Modify declaration of arguments and
3919 local variables to support buffers larger than 2GB.
3920 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3922 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3923 argument, local variables, and return value.
3925 * lisp.h: Update prototypes of emacs_write and emacs_read.
3927 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3929 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3931 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3933 Fix more problems found by GCC 4.6.0's static checks.
3935 * xdisp.c (vmessage): Use a better test for character truncation.
3937 * charset.c (load_charset_map): <, not <=, for optimization,
3938 and to avoid potential problems with integer overflow.
3939 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3940 * casetab.c (set_identity, shuffle): Likewise.
3941 * editfns.c (Fformat): Likewise.
3942 * syntax.c (skip_chars): Likewise.
3944 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3945 This also lets GCC 4.6.0 generate slightly better loop code.
3947 * callint.c (Fcall_interactively): <, not <=, for optimization.
3948 (Fcall_interactively): Count the number of arguments produced,
3949 not the number of arguments given. This is simpler and lets GCC
3950 4.6.0 generate slightly better code.
3952 * ftfont.c: Distingish more carefully between FcChar8 and char.
3953 The previous code passed unsigned char * to a functions like
3954 strlen and xstrcasecmp that expect char *, which does not
3955 conform to the C standard.
3956 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3957 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3958 char * when the C standard requires it.
3960 * keyboard.c (read_char): Remove unused var.
3962 * eval.c: Port to Windows vsnprintf (Bug#8435).
3964 (SIZE_MAX): Define if the headers do not.
3965 (verror): Do not give up if vsnprintf returns a negative count.
3966 Instead, grow the buffer. This ports to Windows vsnprintf, which
3967 does not conform to C99. Problem reported by Eli Zaretskii.
3968 Also, simplify the allocation scheme, by avoiding the need for
3969 calling realloc, and removing the ALLOCATED variable.
3971 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3973 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3974 But keep the doprint source code for now, as we might revamp it
3975 and use it again (Bug#8435).
3976 * lisp.h (doprnt): Remove.
3977 * Makefile.in (base_obj): Remove doprnt.o.
3978 * deps.mk (doprnt.o): Remove.
3980 error: Print 32- and 64-bit integers portably (Bug#8435).
3981 Without this change, on typical 64-bit hosts error ("...%d...", N)
3982 was used to print both 32- and 64-bit integers N, which relied on
3984 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3986 * lisp.h (error, verror): Mark as printf-like functions.
3987 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3988 Report overflow in size calculations when allocating printf buffer.
3989 Do not truncate output string at its first null byte.
3990 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3991 Truncate the output at a character boundary, since vsnprintf does not
3993 * charset.c (check_iso_charset_parameter): Convert internal
3994 character to string before calling 'error', since %c now has the
3996 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3997 overflow when computing char to be passed to 'error'. Do not
3998 pass Lisp_Object to 'error'; pass the integer instead.
3999 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4000 formatted with plain %d.
4002 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4004 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4006 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4008 * xterm.c (x_catch_errors): Remove duplicate declaration.
4010 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4012 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4014 2011-04-10 Jim Meyering <meyering@redhat.com>
4016 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4017 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4018 return ssize_t not "int", and use size_t as the buffer length.
4019 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4020 * gnutls.h: Update declarations.
4021 * process.c (read_process_output): Use ssize_t, to match.
4022 (send_process): Likewise.
4024 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4026 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4028 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4030 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4031 Use unsigned char, to match FcChar8 type definition.
4033 * xterm.c (handle_one_xevent):
4034 * xmenu.c (create_and_show_popup_menu):
4035 * xselect.c (x_decline_selection_request)
4036 (x_reply_selection_request): Avoid type-punned deref of X events.
4038 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4040 Fix some uses of `int' instead of EMACS_INT.
4041 * search.c (string_match_1, fast_string_match)
4042 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4043 (scan_buffer, find_next_newline_no_quit)
4044 (find_before_next_newline, search_command, Freplace_match)
4045 (Fmatch_data): Make some `int' variables be EMACS_INT.
4047 * xdisp.c (display_count_lines): 3rd argument and return value now
4048 EMACS_INT. All callers changed.
4049 (pint2hrstr): Last argument is now EMACS_INT.
4051 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4052 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4053 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4054 (decode_coding_utf_16, decode_coding_emacs_mule)
4055 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4056 (decode_coding_ccl, decode_coding_charset)
4057 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4058 (decode_coding_iso_2022, decode_coding_emacs_mule)
4059 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4060 <char_offset, last_offset>: Declare EMACS_INT.
4061 (encode_coding_utf_8, encode_coding_utf_16)
4062 (encode_coding_emacs_mule, encode_invocation_designation)
4063 (encode_designation_at_bol, encode_coding_iso_2022)
4064 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4065 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4067 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4068 (encode_invocation_designation): Last argument P_NCHARS is now
4070 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4071 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4073 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4076 * ccl.c (Fccl_execute_on_string): Declare some variables
4079 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4081 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4083 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4085 * process.c (Fformat_network_address): Doc fix.
4087 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4089 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4091 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4093 * keyboard.c (read_char): Call Lisp function help-form-show,
4094 instead of using internal_with_output_to_temp_buffer.
4095 (Qhelp_form_show): New var.
4096 (syms_of_keyboard): Use DEFSYM macro.
4098 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4100 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4102 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4104 * process.c (Flist_processes): Remove to Lisp.
4105 (list_processes_1): Delete.
4107 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4109 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4111 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4113 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4115 Fix more problems found by GCC 4.6.0's static checks.
4117 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4119 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4121 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4123 * xdisp.c (vmessage): Mark as a printf-like function.
4125 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4127 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4129 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4130 printf-like functions.
4131 (tiff_load): Add casts to remove these marks before passing them
4132 to system-supplied API.
4134 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4136 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4137 This avoids several warnings with gcc -Wstrict-overflow.
4138 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4139 directly, rather than having caller test rule sign. This avoids
4140 some unnecessary tests.
4141 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4142 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4143 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4145 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4146 (xfont_open): Avoid unnecessary tests.
4148 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4150 * composite.h, composite.c (composition_gstring_put_cache):
4151 Use EMACS_INT, not int, for length.
4153 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4154 breaking out part of COMPOSITION_DECODE_RULE.
4155 (COMPOSITION_DECODE_RULE): Use it.
4156 * composite.c (get_composition_id): Remove unused local vars,
4157 by using the new macro.
4159 * textprop.c (set_text_properties_1): Change while to do-while,
4160 since the condition is always true at first.
4162 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4163 (interval_deletion_adjustment): Return unsigned value.
4166 * process.c (list_processes_1, create_pty, read_process_output):
4167 (exec_sentinel): Remove vars that were set but not used.
4168 (create_pty): Remove unnecessary "volatile"s.
4169 (Fnetwork_interface_info): Avoid possibility of int overflow.
4170 (read_process_output): Do adaptive read buffering even if carryover.
4171 (read_process_output): Simplify nbytes computation if buffered.
4173 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4175 * syntax.c (scan_words): Remove var that was set but not used.
4176 (update_syntax_table): Use unsigned instead of int.
4178 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4179 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4180 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4182 * print.c (print_error_message): Avoid int overflow.
4184 * font.c (font_list_entities): Redo for clarity,
4185 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4187 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4188 (font_score): Avoid potential overflow in diff calculation.
4190 * fns.c (substring_both): Remove var that is set but not used.
4191 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4193 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4195 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4196 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4197 can always succeed if overflow has undefined behavior.
4199 * search.c (boyer_moore, wordify): Remove vars set but not used.
4200 (wordify): Omit three unnecessary tests.
4202 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4203 All callers changed. This avoids the need for an unused var.
4205 * casefiddle.c (casify_region): Remove var that is set but not used.
4207 * dired.c (file_name_completion): Remove var that is set but not used.
4209 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4211 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4212 (Finsert_file_contents): Remove unnecessary code checking fd.
4214 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4215 Check for integer overflow on size calculations.
4217 * buffer.c (Fprevious_overlay_change): Remove var that is set
4220 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4221 Remove vars that are set but not used.
4222 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4223 (timer_check_2): Mark vars as initialized.
4225 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4227 * image.c (lookup_image): Remove var that is set but not used.
4228 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4230 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4231 that are set but not used.
4233 * xfns.c (make_invisible_cursor): Don't return garbage
4234 if XCreateBitmapFromData fails (Bug#8410).
4236 * xselect.c (x_get_local_selection, x_handle_property_notify):
4237 Remove vars that are set but not used.
4239 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4240 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4242 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4243 Remove var that is set but not used.
4244 (scroll_bar_windows_size): Now size_t, not int.
4245 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4248 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4249 (map_tty_color) [!defined MSDOS]: Likewise.
4251 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4253 * coding.c: Remove vars that are set but not used.
4254 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4255 All callers changed.
4256 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4257 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4258 (decode_coding_charset): Remove vars that are set but not used.
4260 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4261 that is set but not used.
4263 * print.c (print_object): Remove var that is set but not used.
4265 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4266 The gnulib version avoids calling malloc in the usual case,
4267 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4268 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4269 * filelock.c (current_lock_owner): Likewise.
4270 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4271 * sysdep.c: Include allocator.h, careadlinkat.h.
4272 (emacs_no_realloc_allocator): New static constant.
4273 (emacs_readlink): New function.
4274 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4275 ../lib/careadlinkat.h.
4277 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4279 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4280 first non-nil return value).
4282 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4284 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4285 if not defined (Bug#8403).
4287 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4289 * xdisp.c (display_count_lines): Remove parameter `start',
4290 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4291 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4292 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4293 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4294 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4295 and thereabouts. All callers changed.
4296 (get_per_char_metric): Remove parameter `f', unused since
4297 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4299 2011-04-02 Jim Meyering <meyering@redhat.com>
4301 do not dereference NULL upon failed strdup
4302 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4303 (ns_get_family): Likewise.
4305 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4307 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4309 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4311 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4314 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4316 Add lexical binding.
4318 * window.c (Ftemp_output_buffer_show): New fun.
4319 (Fsave_window_excursion):
4320 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4322 * lread.c (lisp_file_lexically_bound_p): New function.
4323 (Fload): Bind Qlexical_binding.
4324 (readevalloop): Remove `evalfun' arg.
4325 Bind Qinternal_interpreter_environment.
4326 (Feval_buffer): Bind Qlexical_binding.
4327 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4329 (syms_of_lread): Declare `lexical-binding'.
4331 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4333 * keyboard.c (eval_dyn): New fun.
4334 (menu_item_eval_property): Use it.
4336 * image.c (parse_image_spec): Use Ffunctionp.
4338 * fns.c (concat, mapcar1): Accept byte-code-functions.
4340 * eval.c (Fsetq): Handle lexical vars.
4341 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4342 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4343 (FletX, Flet): Obey lexical binding.
4344 (Fcommandp): Handle closures.
4345 (Feval): New `lexical' arg.
4346 (eval_sub): New function extracted from Feval. Use it almost
4347 everywhere where Feval was used. Look up vars in lexical env.
4349 (Ffunctionp): Move from subr.el.
4350 (Ffuncall): Handle closures.
4351 (apply_lambda): Remove `eval_flags'.
4352 (funcall_lambda): Handle closures and new byte-code-functions.
4353 (Fspecial_variable_p): New function.
4354 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4355 but without exporting it to Lisp.
4357 * doc.c (Fdocumentation, store_function_docstring):
4358 * data.c (Finteractive_form): Handle closures.
4360 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4363 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4365 (exec_byte_code): New function extracted from Fbyte_code to handle new
4366 calling convention for byte-code-functions. Add new byte-codes.
4368 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4370 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4372 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4374 * xdisp.c (redisplay_internal): Fix prototype.
4376 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4378 * xdisp.c (SCROLL_LIMIT): New macro.
4379 (try_scrolling): Use it when setting scroll_limit.
4380 Limit scrolling to 100 screen lines.
4381 (redisplay_window): Even when falling back on "recentering",
4382 position point in the window according to scroll-conservatively,
4383 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4385 (try_scrolling): When point is above the window, allow searching
4386 as far as scroll_max, or one screenful, to compute vertical
4387 distance from PT to the scroll margin position. This prevents
4388 try_scrolling from unnecessarily failing when
4389 scroll-conservatively is set to a value slightly larger than the
4390 window height. Clean up the case of PT below the margin at bottom
4391 of window: scroll_max can no longer be INT_MAX. When aggressive
4392 scrolling is in use, don't let point enter the opposite scroll
4393 margin as result of the scroll.
4394 (syms_of_xdisp) <scroll-conservatively>: Document the
4395 threshold of 100 lines for never-recentering scrolling.
4397 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4399 * dispextern.h (move_it_by_lines):
4400 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4401 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4402 (message_log_check_duplicate): Remove parameters `prev_bol' and
4403 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4404 (redisplay_internal): Remove parameter `preserve_echo_area',
4405 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4407 * indent.c (Fvertical_motion):
4408 * window.c (window_scroll_pixel_based, Frecenter):
4409 Don't pass `need_y_p' to `move_it_by_lines'.
4411 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4413 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4414 steal a few bits to be more compact.
4415 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4416 Remove unneeded casts.
4418 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4420 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4422 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4423 binding" message (bug#7967).
4425 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4427 Fix more problems found by GCC 4.6.0's static checks.
4429 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4430 Remove unused local var.
4432 * editfns.c (Fmessage_box): Remove unused local var.
4434 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4435 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4436 Omit unused local vars.
4437 * window.c (shrink_windows): Omit unused local var.
4438 * menu.c (digest_single_submenu): Omit unused local var.
4439 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4440 Omit unused local var.
4442 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4443 Don't assume string length fits in int.
4444 (keyremap_step, read_key_sequence): Use size_t for sizes.
4445 (read_key_sequence): Don't check last_real_key_start redundantly.
4447 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4448 instead of alloca (Bug#8344).
4450 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4451 (Fbacktrace_frame): Don't assume nframes fits in int.
4453 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4455 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4458 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4460 * cm.c (calccost): Turn while-do into do-while, for clarity.
4462 * keyboard.c (syms_of_keyboard): Use the same style as later
4463 in this function when indexing through an array. This also
4464 works around GCC bug 48267.
4466 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4468 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4470 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4471 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4473 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4474 This avoids undefined behavior on integer overflow, and is a bit
4475 more convenient anyway since it is compared to a size_t variable.
4477 Variadic C functions now count arguments with size_t, not int.
4478 This avoids an unnecessary limitation on 64-bit machines, which
4479 caused (substring ...) to crash on large vectors (Bug#8344).
4480 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4481 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4482 All variadic functions and their callers changed accordingly.
4483 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4484 * data.c (arith_driver, float_arith_driver): Likewise.
4485 * editfns.c (general_insert_function): Likewise.
4486 * eval.c (struct backtrace.nargs, interactive_p)
4487 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4488 (funcall_lambda, mark_backtrace): Likewise.
4489 * fns.c (concat): Likewise.
4490 * frame.c (x_set_frame_parameters): Likewise.
4491 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4492 0 if not found, not -1. All callers changed.
4494 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4495 (stack_copy_size): Now size_t, not int.
4496 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4498 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4500 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4501 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4502 All callers changed.
4504 * lisp.h (multibyte_char_to_unibyte):
4505 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4506 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4507 * character.h (CHAR_TO_BYTE8):
4508 * cmds.c (internal_self_insert):
4509 * editfns.c (general_insert_function):
4510 * keymap.c (push_key_description):
4511 * search.c (Freplace_match):
4512 * xdisp.c (message_dolog, set_message_1): All callers changed.
4514 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4516 * keyboard.c (safe_run_hook_funcall): New function.
4517 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4518 don't set the hook to nil, but remove the offending function instead.
4519 (Qcommand_hook_internal): Remove, unused.
4520 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4521 Vcommand_hook_internal.
4523 * eval.c (enum run_hooks_condition): Remove.
4524 (funcall_nil, funcall_not): New functions.
4525 (run_hook_with_args): Call each function through a `funcall' argument.
4526 Remove `cond' argument, now redundant.
4527 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4528 (Frun_hook_with_args_until_failure): Adjust accordingly.
4529 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4531 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4533 * dispextern.h (string_buffer_position): Remove declaration.
4535 * print.c (strout): Remove parameter `multibyte', unused since
4536 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4538 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4539 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4540 All callers changed.
4542 * w32.c (_wsa_errlist): Use braces for struct initializers.
4544 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4545 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4546 All callers changed.
4547 (string_buffer_position): Likewise. Also, make static (it's never
4548 used outside xdisp.c).
4549 (cursor_row_p): Remove parameter `w', unused since
4550 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4551 (decode_mode_spec): Remove parameter `precision', introduced during
4552 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4553 All callers changed.
4555 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4557 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4559 2011-03-27 Anders Lindgren <andlind@gmail.com>
4561 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4562 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4563 (ns_update_auto_hide_menu_bar): New functions.
4564 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4565 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4566 ns_constrain_all_frames.
4567 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4568 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4570 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4572 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4574 2011-03-27 Glenn Morris <rgm@gnu.org>
4576 * syssignal.h: Replace RETSIGTYPE with void.
4577 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4578 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4579 Replace SIGTYPE with void everywhere.
4580 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4581 * s/template.h (SIGTYPE): Remove commented out definition.
4583 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4585 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4586 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4588 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4590 * w32.c (read_unc_volume): Use parameter `henum', instead of
4591 global variable `wget_enum_handle'.
4593 * keymap.c (describe_vector): Remove parameters `indices' and
4594 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4595 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4597 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4599 * keyboard.c (timer_check): Remove parameter `do_it_now',
4600 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4601 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4602 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4604 * keyboard.c (read_char):
4605 * w32menu.c (w32_menu_display_help):
4606 * xmenu.c (show_help_event, menu_help_callback):
4607 Adjust calls to `show_help_echo'.
4609 * gtkutil.c (xg_maybe_add_timer):
4610 * keyboard.c (readable_events):
4611 * process.c (wait_reading_process_output):
4612 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4614 * insdel.c (adjust_markers_gap_motion):
4615 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4616 (gap_left, gap_right): Don't call it.
4618 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4620 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4621 incurred during fontification.
4623 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4625 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4626 (DEFVAR_PER_BUFFER): Don't pass it.
4628 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4629 (scrolling_window): Don't pass it.
4631 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4633 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4635 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4637 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4638 of variables specific to SELinux and computation of `encoded_absname'.
4640 * image.c (XPutPixel): Remove unused variable `height'.
4642 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4644 * unexw32.c (get_section_info): Remove unused variable `section'.
4646 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4647 (system_process_attributes): Remove unused variable `sess'.
4648 (sys_read): Remove unused variable `err'.
4650 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4651 (w32_wnd_proc): Remove unused variable `isdead'.
4652 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4653 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4654 (x_create_tip_frame): Remove unused variable `tem'.
4656 * w32inevt.c (w32_console_read_socket):
4657 Remove unused variable `no_events'.
4659 * w32term.c (x_draw_composite_glyph_string_foreground):
4660 Remove unused variable `width'.
4662 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4664 * w32term.c (x_set_glyph_string_clipping):
4665 Don't pass uninitialized region to CombineRgn.
4667 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4669 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4670 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4671 (Fx_close_connection): Remove unused variable `i'.
4673 * w32font.c (w32font_draw): Return number of glyphs.
4674 (w32font_open_internal): Remove unused variable `i'.
4675 (w32font_driver): Add missing initializer.
4677 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4678 (fill_in_menu): Remove unused variable `items_added'.
4680 * w32term.c (last_mouse_press_frame): Remove static global variable.
4681 (w32_clip_to_row): Remove unused variable `f'.
4682 (x_delete_terminal): Remove unused variable `i'.
4684 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4685 (NOTHING): Remove unused static global variable.
4686 (uniscribe_check_otf): Remove unused variable `table'.
4687 (uniscribe_font_driver): Add missing initializers.
4689 2011-03-23 Julien Danjou <julien@danjou.info>
4691 * term.c (Fsuspend_tty, Fresume_tty):
4692 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4693 * window.c (temp_output_buffer_show):
4694 * insdel.c (signal_before_change):
4695 * frame.c (Fhandle_switch_frame):
4696 * fileio.c (Fdo_auto_save):
4697 * emacs.c (Fkill_emacs):
4698 * editfns.c (save_excursion_restore):
4699 * cmds.c (internal_self_insert):
4700 * callint.c (Fcall_interactively):
4701 * buffer.c (Fkill_all_local_variables):
4702 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4704 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4705 unconditionnaly since it does the check itself.
4707 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4709 Fix more problems found by GCC 4.5.2's static checks.
4711 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4712 the first time through the loop, since we know p0 < p1 then.
4713 This also avoids a gcc -Wstrict-overflow warning.
4715 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4716 leading to a memory leak, possible in functions like
4717 load_charset_map_from_file that can allocate an unbounded number
4718 of objects (Bug#8318).
4720 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4721 that could (at least in theory) be that large.
4723 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4724 This is less likely to overflow, and avoids undefined behavior if
4725 overflow does occur. All callers changed. Use strtoul to scan
4726 for the unsigned long integer.
4727 (pint2hrstr): Simplify and tune code slightly.
4728 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4730 * scroll.c (do_scrolling): Work around GCC bug 48228.
4731 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4733 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4734 This also avoids a warning with gcc -Wstrict-overflow.
4735 (validate_x_resource_name): Simplify count usage.
4736 This also avoids a warning with gcc -Wstrict-overflow.
4738 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4741 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4743 * process.c (Fmake_network_process): Use socklen_t, not int,
4744 where POSIX says socklen_t is required in portable programs.
4745 This fixes a porting bug on hosts like 64-bit HP-UX, where
4746 socklen_t is wider than int (Bug#8277).
4747 (Fmake_network_process, server_accept_connection):
4748 (wait_reading_process_output, read_process_output):
4751 * process.c: Rename or move locals to avoid shadowing.
4752 (list_processes_1, Fmake_network_process):
4753 (read_process_output_error_handler, exec_sentinel_error_handler):
4754 Rename or move locals.
4755 (Fmake_network_process): Define label "retry_connect" only if needed.
4756 (Fnetwork_interface_info): Fix pointer signedness.
4757 (process_send_signal): Add cast to avoid pointer signedness problem.
4758 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4759 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4761 Make tparam.h and terminfo.c consistent.
4762 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4763 Include tparam.h instead, since it declares them.
4764 * cm.h (PC): Remove extern decl; tparam.h now does this.
4765 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4766 * terminfo.c: Include tparam.h, to check interfaces.
4767 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4768 (tparam): Adjust signature to match interface in tparam.h;
4769 this removes some undefined behavior. Check that outstring and len
4770 are zero, which they always are with Emacs.
4771 * tparam.h (PC, BC, UP): New extern decls.
4773 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4774 (xftfont_open): Rename locals to avoid shadowing.
4776 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4777 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4778 (OTF_TAG_SYM): Omit macro if not needed.
4779 (ftfont_list): Remove unused local.
4780 (get_adstyle_property, ftfont_pattern_entity):
4781 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4782 Rename locals to avoid shadowing.
4784 * xfont.c (xfont_list_family): Mark var as initialized.
4786 * xml.c (make_dom): Now static.
4788 * composite.c (composition_compute_stop_pos): Rename local to
4790 (composition_reseat_it): Remove unused locals.
4791 (find_automatic_composition, composition_adjust_point): Likewise.
4792 (composition_update_it): Mark var as initialized.
4793 (find_automatic_composition): Mark vars as initialized,
4794 with a FIXME (Bug#8290).
4796 character.h: Rename locals to avoid shadowing.
4797 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4798 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4799 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4800 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4803 * textprop.c (property_change_between_p): Remove; unused.
4805 * intervals.c (interval_start_pos): Now static.
4807 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4809 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4810 Rename locals to avoid shadowing.
4812 * sound.c (wav_play, au_play, Fplay_sound_internal):
4813 Fix pointer signedness.
4814 (alsa_choose_format): Remove unused local var.
4815 (wav_play): Initialize a variable to 0, to prevent undefined
4816 behavior (Bug#8278).
4818 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4820 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4822 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4823 clobbering (Bug#8298).
4824 * sysdep.c (sys_subshell): Likewise.
4825 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4827 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4828 This should get cleaned up, so that child_setup has the
4829 same signature on all platforms.
4831 * callproc.c (call_process_cleanup): Now static.
4832 (relocate_fd): Rename locals to avoid shadowing.
4834 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4836 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4837 not to be necessary, and produces flickering.
4839 2011-03-20 Glenn Morris <rgm@gnu.org>
4841 * config.in: Remove file.
4843 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4845 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4846 are now in src/globals.h.
4847 (syms_of_minibuf): Remove spurious & from previous change.
4849 2011-03-20 Leo <sdl.web@gmail.com>
4851 * minibuf.c (completing-read-function): New variable.
4852 (completing-read-default): Rename from completing-read.
4853 (completing-read): Call completing-read-function.
4855 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4857 * xfaces.c (Fx_load_color_file):
4858 Read color file from absolute filename (bug#8250).
4860 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4862 * makefile.w32-in: Update dependencies.
4864 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4866 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4868 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4870 Fix more problems found by GCC 4.5.2's static checks.
4872 * process.c (make_serial_process_unwind, send_process_trap):
4873 (sigchld_handler): Now static.
4875 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4876 That way, the code declares only the vars that it needs.
4877 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4878 * s/cygwin.h (PTY_ITERATION): Likewise.
4879 * s/darwin.h (PTY_ITERATION): Likewise.
4880 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4882 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4883 * process.c (allocate_pty): Don't declare stb unless it's needed.
4885 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4886 (CONSTANTLIM): Remove; unused.
4887 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4888 Define only if needed.
4890 * unexelf.c (unexec): Name an expression,
4891 to avoid gcc -Wbad-function-cast warning.
4892 Use a different way to cause a compilation error if anyone uses
4893 n rather than nn, a way that does not involve shadowing.
4894 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4896 * deps.mk (unexalpha.o): Remove; unused.
4898 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4899 * unexec.h: New file.
4900 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4901 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4903 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4904 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4905 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4906 Change as necessary to match prototype in unexec.h.
4908 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4910 (back_comment, skip_chars): Mark vars as initialized.
4912 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4913 Rename locals to avoid shadowing.
4915 * lread.c (read1): Rewrite so as not to use empty "else".
4916 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4918 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4920 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4921 warning when compiling print.c.
4923 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4924 instead of using an uninitialized var.
4925 (font_sort_entities): Mark var as initialized.
4927 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4929 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4930 pointers to constants.
4931 (font_parse_fcname): Remove unused vars.
4932 (font_delete_unmatched): Now static.
4933 (font_get_spec): Remove; unused.
4934 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4935 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4936 Rename or move locals to avoid shadowing.
4938 * fns.c (require_nesting_list, require_unwind): Now static.
4939 (Ffillarray): Rename locals to avoid shadowing.
4941 * floatfns.c (domain_error2): Define only if needed.
4942 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4944 * alloc.c (mark_backtrace): Move decl from here ...
4945 * lisp.h: ... to here, so that it can be checked.
4947 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4948 (Fdefvar): Rewrite so as not to use empty "else".
4949 (lisp_indirect_variable): Name an expression,
4950 to avoid gcc -Wbad-function-cast warning.
4951 (Fdefvar): Rename locals to avoid shadowing.
4953 * callint.c (quotify_arg, quotify_args): Now static.
4954 (Fcall_interactively): Rename locals to avoid shadowing.
4955 Use const pointer when appropriate.
4957 * lisp.h (get_system_name, get_operating_system_release):
4958 Move decls here, to check interfaces.
4959 * process.c (get_operating_system_release): Move decl to lisp.h.
4960 * xrdb.c (get_system_name): Likewise.
4961 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4962 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4963 some of which prompt warnings from gcc -Wbad-function-cast.
4964 (Fformat_time_string, Fencode_time, Finsert_char):
4965 (Ftranslate_region_internal, Fformat):
4966 Rename or remove local vars to avoid shadowing.
4967 (Ftranslate_region_internal): Mark var as initialized.
4969 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4972 * lisp.h (eassert): Check that the argument compiles, even if
4973 ENABLE_CHECKING is not defined.
4975 * data.c (Findirect_variable): Name an expression, to avoid
4976 gcc -Wbad-function-cast warning.
4977 (default_value, arithcompare, arith_driver, arith_error): Now static.
4978 (store_symval_forwarding): Rename local to avoid shadowing.
4979 (Fmake_variable_buffer_local, Fmake_local_variable):
4980 Mark variables as initialized.
4981 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4983 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4984 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4985 Rename locals to avoid shadowing.
4986 (mark_stack): Move local variables into the #ifdef region where
4988 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4989 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4991 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4992 (GC_STRING_CHARS): Remove; not used.
4993 (Fmemory_limit): Cast sbrk's returned value to char *.
4995 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4996 avoids undefined behavior in theory.
4998 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5000 Use functions, not macros, for up- and down-casing (Bug#8254).
5001 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5002 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5003 to use the following functions instead of these macros.
5004 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5005 EMACS_INT, since callers assume the returned value fits in int.
5006 (upcase1): Likewise, for UPCASE_TABLE.
5007 (uppercasep, lowercasep, upcase): New static inline functions.
5008 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5009 the race-condition problem in the old DOWNCASE.
5011 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5012 Rename locals to avoid shadowing.
5013 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5014 (regex_compile, re_search_2, re_match_2_internal):
5015 Remove unused local vars.
5016 (FREE_VAR): Rewrite so as not to use empty "else",
5017 which gcc can warn about.
5018 (regex_compile, re_match_2_internal): Mark locals as initialized.
5019 (RETALLOC_IF): Define only if needed.
5020 (WORDCHAR_P): Likewise. This one is never needed, but is used
5021 only in a comment talking about a compiler bug, so put inside
5022 the #if 0 of that comment.
5023 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5024 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5027 * search.c (boyer_moore): Rename locals to avoid shadowing.
5028 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5029 (PREV_CHAR_BOUNDARY): Likewise.
5031 * search.c (simple_search): Remove unused var.
5033 * dired.c (compile_pattern): Move decl from here ...
5034 * lisp.h: ... to here, so that it can be checked.
5035 (struct re_registers): New forward decl.
5037 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5039 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5041 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5042 Rename locals to avoid shadowing.
5043 (Fvertical_motion): Mark locals as initialized.
5045 * casefiddle.c (casify_object, casify_region): Now static.
5046 (casify_region): Mark local as initialized.
5048 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5050 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5051 New macros, so that the caller can use some names other than
5052 gcpro1, gcpro2, etc.
5053 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5055 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5056 argument, for consistency with GCPRO2_VAR, etc: it is now the
5057 prefix of the variable, not the variable itself. All uses
5059 * dired.c (directory_files_internal, file_name_completion):
5060 Rename locals to avoid shadowing.
5062 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5063 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5064 dired.c's scmp function, had undefined behavior.
5065 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5066 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5067 * buffer.h: ... to here, because these macros use current_buffer,
5068 and the new implementation with inline functions needs to have
5069 current_buffer in scope now, rather than later when the macros
5071 (downcase, upcase1): New static inline functions.
5072 (DOWNCASE, UPCASE1): Reimplement using these functions.
5073 This avoids undefined behavior in expressions like
5074 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5075 from race conditions in accessing the global variables
5076 case_temp1 and case_temp2.
5077 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5078 * lisp.h (case_temp1, case_temp2): Remove their decls.
5079 * character.h (ASCII_CHAR_P): Move from here ...
5080 * lisp.h: ... to here, so that the inline functions mentioned
5083 * dired.c (directory_files_internal_unwind): Now static.
5085 * fileio.c (file_name_as_directory, directory_file_name):
5086 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5088 (file_name_as_directory): Use const pointers when appropriate.
5089 (Fexpand_file_name): Likewise. In particular, newdir might
5090 point at constant storage, so make it a const pointer.
5091 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5092 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5094 (Fset_file_times, Finsert_file_contents, auto_save_error):
5095 Rename locals to avoid shadowing.
5097 * minibuf.c (choose_minibuf_frame_1): Now static.
5098 (Ftry_completion, Fall_completions): Rename or remove locals
5101 * marker.c (bytepos_to_charpos): Remove; unused.
5103 * lisp.h (verify_bytepos, count_markers): New decls,
5104 so that gcc does not warn that these functions aren't declared.
5106 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5107 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5108 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5109 (copy_text): Remove unused local var.
5111 * filelock.c (within_one_second): Now static.
5112 (lock_file_1): Rename local to avoid shadowing.
5114 * buffer.c (fix_overlays_before): Mark locals as initialized.
5115 (fix_start_end_in_overlays): Likewise. This function should be
5116 simplified by using pointers-to-pointers, but that's a different
5118 (switch_to_buffer_1): Now static.
5119 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5120 (report_overlay_modification): Rename locals to avoid shadowing.
5122 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5123 Fix pointer signedness issue.
5124 (sys_subshell): Mark local as volatile if checking for lint,
5125 to suppress a gcc -Wclobbered warning that does not seem to be right.
5126 (MAXPATHLEN): Define only if needed.
5128 * process.c (serial_open, serial_configure): Move decls from here ...
5129 * systty.h: ... to here, so that they can be checked.
5131 * fns.c (get_random, seed_random): Move extern decls from here ...
5132 * lisp.h: ... to here, so that they can be checked.
5134 * sysdep.c (reset_io): Now static.
5135 (wait_for_termination_signal): Remove; unused.
5137 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5138 (copy_keymap_item, append_key, push_text_char_description):
5140 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5141 (DENSE_TABLE_SIZE): Remove; unused.
5142 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5143 (describe_map_tree):
5144 Rename locals to avoid shadowing.
5146 * keyboard.c: Declare functions static if they are not used elsewhere.
5147 (echo_char, echo_dash, cmd_error, top_level_2):
5148 (poll_for_input, handle_async_input): Now static.
5149 (read_char, kbd_buffer_get_event, make_lispy_position):
5150 (make_lispy_event, make_lispy_movement, apply_modifiers):
5151 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5152 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5153 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5154 (read_key_sequence, read_char): Mark locals as initialized.
5155 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5157 * keyboard.h (make_ctrl_char): New decl.
5158 (mark_kboards): Move decl here ...
5159 * alloc.c (mark_kboards): ... from here.
5161 * lisp.h (force_auto_save_soon): New decl.
5163 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5164 (DEFINE_DUMMY_FUNCTION): New macro.
5165 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5167 (main): Add casts to avoid warnings
5168 if GCC considers string literals to be constants.
5170 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5172 * dbusbind.c: Pointer signedness fixes.
5173 (xd_signature, xd_append_arg, xd_initialize):
5174 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5175 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5176 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5177 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5179 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5180 if GCC considers string literals to be constants.
5181 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5183 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5185 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5186 (print_preprocess, print_object): New macro to fix last change.
5188 * print.c (print_preprocess): Don't forget font objects.
5190 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5192 * emacs.c (USAGE3): Doc fixes.
5194 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5196 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5199 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5201 * lisp.h (VWindow_system, Qfile_name_history):
5202 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5203 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5204 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5206 * w32select.c: Don't #include "keyboard.h".
5207 (run_protected): Add extern declaration for waiting_for_input.
5209 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5210 * w32console.c (detect_input_pending, read_input_pending)
5211 (encode_terminal_code):
5212 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5213 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5214 (w32_system_caret_y, Qfile_name_history):
5215 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5216 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5217 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5218 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5219 * w32proc.c (Qlocal, report_file_error):
5220 * w32term.c (Vwindow_system, updating_frame):
5221 * w32uniscribe.c (initialized, uniscribe_font_driver):
5222 Remove unneeded extern declarations.
5224 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5226 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5228 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5230 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5231 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5232 These macros can no longer be used for assignment.
5234 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5235 Assign struct members directly, instead of using BUF_BEGV etc.
5236 (record_buffer_markers, fetch_buffer_markers): New functions for
5237 recording and fetching special buffer markers.
5238 (set_buffer_internal_1, set_buffer_temp): Use them.
5240 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5242 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5244 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5245 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5247 * xdisp.c (hscroll_window_tree):
5248 (reconsider_clip_changes): Use PT instead of BUF_PT.
5250 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5252 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5253 $(EMACS_ROOT)/lib/intprops.h.
5255 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5257 Fix more problems found by GCC 4.5.2's static checks.
5259 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5260 to unsigned char * to avoid compiler diagnostic.
5261 (xg_free_frame_widgets): Make it clear that a local variable is
5262 needed only if USE_GTK_TOOLTIP.
5263 (gdk_window_get_screen): Make it clear that this macro is needed
5264 only if USE_GTK_TOOLTIP.
5265 (int_gtk_range_get_value): New function, which avoids a diagnostic
5266 from gcc -Wbad-function-cast.
5267 (xg_set_toolkit_scroll_bar_thumb): Use it.
5268 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5269 diagnostic from gcc -Wbad-function-cast.
5270 (get_utf8_string, xg_get_file_with_chooser):
5271 Rename locals to avoid shadowing.
5272 (create_dialog): Move locals to avoid shadowing.
5274 * xgselect.c (xg_select): Remove unused var.
5276 * image.c (four_corners_best): Mark locals as initialized.
5277 (gif_load): Initialize transparent_p to zero (Bug#8238).
5278 Mark another local as initialized.
5279 (my_png_error, my_error_exit): Mark with NO_RETURN.
5281 * image.c (clear_image_cache): Now static.
5282 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5283 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5284 (x_edge_detection): Remove unnecessary cast that
5285 gcc -Wbad-function-cast diagnoses.
5286 (gif_load): Fix pointer signedness.
5287 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5288 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5290 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5292 Improve quality of tests for time stamp overflow.
5293 For example, without this patch (encode-time 0 0 0 1 1
5294 1152921504606846976) returns the obviously-bogus value (-948597
5295 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5296 reports time overflow. See
5297 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5298 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5299 * editfns.c: Include limits.h and intprops.h.
5300 (TIME_T_MIN, TIME_T_MAX): New macros.
5301 (time_overflow): Move earlier, to before first use.
5302 (hi_time, lo_time): New functions, for an accurate test for
5304 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5305 (Fget_internal_run_time): Don't assume time_t fits in int.
5306 (make_time): Use list2 instead of Fcons twice.
5307 (Fdecode_time): More accurate test for out-of-range times.
5308 (check_tm_member): New function.
5309 (Fencode_time): Use it, to test for out-of-range times.
5310 (lisp_time_argument): Don't rely on undefined left-shift and
5311 right-shift behavior when checking for time stamp overflow.
5313 * editfns.c (time_overflow): New function, refactoring common code.
5314 (Fformat_time_string, Fdecode_time, Fencode_time):
5315 (Fcurrent_time_string): Use it.
5317 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5318 * dired.c (make_time): Move to ...
5319 * editfns.c (make_time): ... here.
5320 * systime.h: Note the move.
5322 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5324 * fringe.c (update_window_fringes): Remove unused variables.
5326 * unexmacosx.c (copy_data_segment): Also copy __got section.
5329 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5331 * termcap.c [MSDOS]: Include "msdos.h".
5332 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5333 Constify `char *' arguments and their references according to
5334 prototypes in tparam.h.
5336 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5338 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5339 Adapt all references accordingly.
5341 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5343 2011-03-11 Tom Tromey <tromey@redhat.com>
5345 * buffer.c (syms_of_buffer): Remove obsolete comment.
5347 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5349 * termhooks.h (encode_terminal_code): Declare prototype.
5351 * msdos.c (encode_terminal_code): Don't declare prototype.
5353 * term.c (encode_terminal_code): Now external again, used by
5354 w32console.c and msdos.c.
5356 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5357 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5359 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5361 Fix some minor problems found by GCC 4.5.2's static checks.
5363 * fringe.c (update_window_fringes): Mark locals as initialized
5365 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5367 * alloc.c (mark_fringe_data): Move decl from here ...
5368 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5369 to check its interface.
5370 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5372 * fontset.c (free_realized_fontset): Now static.
5373 (Fset_fontset_font): Rename local to avoid shadowing.
5374 (fontset_font): Mark local as initialized.
5375 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5377 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5379 * xselect.c (x_disown_buffer_selections): Remove; not used.
5380 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5381 (x_own_selection, Fx_disown_selection_internal): Rename locals
5383 (x_handle_dnd_message): Remove local to avoid shadowing.
5385 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5386 so that the caller can use some name other than gcpro1.
5387 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5388 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5389 (Fx_backspace_delete_keys_p):
5390 Use them to avoid shadowing, and rename vars to avoid shadowing.
5391 (x_decode_color, x_set_name, x_window): Now static.
5392 (Fx_create_frame): Add braces to silence GCC warning.
5393 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5394 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5395 Remove unused locals.
5396 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5397 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5398 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5401 * xterm.h (x_mouse_leave): New decl.
5403 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5404 Remove unused functions.
5405 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5406 (x_calc_absolute_position): Now static.
5407 (XTread_socket): Don't define label "out" unless it's used.
5408 Don't declare local "event" unless it's used.
5409 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5410 unless they are used.
5411 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5412 (x_fatal_error_signal): Remove; not used.
5413 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5414 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5415 (x_error_catcher, x_connection_closed, x_error_handler):
5416 (x_error_quitter, xembed_send_message, x_iconify_frame):
5417 (my_log_handler): Rename locals to avoid shadowing.
5418 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5419 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5421 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5422 Rename or move locals to avoid shadowing.
5423 (tty_defined_color, merge_face_heights): Now static.
5424 (free_realized_faces_for_fontset): Remove; not used.
5425 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5426 does not deduce is never used uninitialized.
5427 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5428 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5430 * terminal.c (store_terminal_param): Now static.
5432 * xmenu.c (menu_highlight_callback): Now static.
5433 (set_frame_menubar): Remove unused local.
5434 (xmenu_show): Rename parameter to avoid shadowing.
5435 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5436 since they might point to immutable storage.
5437 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5438 since it's unused otherwise.
5440 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5441 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5442 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5443 avoids a gcc -Wuninitialized diagnostic.
5444 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5445 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5446 does not deduce are never used uninitialized.
5448 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5450 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5451 * window.c (window_loop, size_window):
5452 (run_window_configuration_change_hook, enlarge_window): Likewise.
5454 * window.c (display_buffer): Now static.
5455 (size_window): Mark variables that gcc -Wuninitialized
5456 does not deduce are never used uninitialized.
5457 * window.h (check_all_windows): New decl, to forestall
5458 gcc -Wmissing-prototypes diagnostic.
5459 * dispextern.h (bidi_dump_cached_states): Likewise.
5461 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5463 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5465 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5466 and to avoid gcc -Wuninitialized warning.
5467 (load_charset_map): Mark variables that gcc -Wuninitialized
5468 does not deduce are never used uninitialized.
5469 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5471 * coding.c (coding_set_source, coding_set_destination):
5472 Use "else { /* comment */ }" rather than "else /* comment */;"
5473 for clarity, and to avoid gcc -Wempty-body warning.
5474 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5475 a block, when the outer 'i' will do.
5476 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5477 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5478 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5479 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5480 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5481 Rename locals to avoid shadowing.
5482 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5483 * coding.c (emacs_mule_char, encode_invocation_designation):
5484 Now static, since they're not used elsewhere.
5485 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5486 (decode_coding_object, encode_coding_object, detect_coding_system):
5487 (decode_coding_emacs_mule): Mark variables that gcc
5488 -Wuninitialized does not deduce are never used uninitialized.
5489 (detect_coding_iso_2022): Initialize a local variable that might
5490 be used uninitialized. Leave a FIXME because it's not clear that
5491 this initialization is needed. (Bug#8211)
5492 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5493 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5494 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5495 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5496 Remove unused macros.
5498 * category.c (hash_get_category_set): Remove unused local var.
5499 (copy_category_table): Now static, since it's not used elsewhere.
5500 * character.c (string_count_byte8): Likewise.
5502 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5503 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5505 * chartab.c (copy_sub_char_table): Now static, since it's not used
5507 (sub_char_table_ref_and_range, char_table_ref_and_range):
5508 Rename locals to avoid shadowing.
5509 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5511 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5512 (BIDI_BOB): Remove unused macro.
5514 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5515 deduce are never used uninitialized.
5516 * term.c (encode_terminal_code): Likewise.
5518 * term.c (encode_terminal_code): Now static. Remove unused local.
5520 * tparam.h: New file.
5521 * term.c, tparam.h: Include it.
5522 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5523 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5524 Move these decls to tparam.h, and make them agree with what
5525 is actually in tparam.c. The previous trick of using incompatible
5526 decls in different modules does not conform to the C standard.
5527 All callers of tparam changed to use tparam's actual API.
5528 * tparam.c (tparam1, tparam, tgoto):
5529 Use const pointers where appropriate.
5531 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5532 * cm.h (struct cm): Likewise.
5533 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5534 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5535 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5536 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5537 (turn_on_face, init_tty): Likewise.
5538 * termchar.h (struct tty_display_info): Likewise.
5540 * term.c (term_mouse_position): Rename local to avoid shadowing.
5542 * alloc.c (mark_ttys): Move decl from here ...
5543 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5545 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5547 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5549 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5551 * search.c (compile_pattern_1): Remove argument regp, unused since
5552 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5553 (compile_pattern): Don't pass it.
5555 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5557 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5558 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5560 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5562 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5564 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5565 gdk_window_get_screen, gdk_window_get_geometry,
5566 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5567 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5568 (xg_get_pixbuf_from_pixmap): New function.
5569 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5570 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5571 Call xg_get_pixbuf_from_pixmap instead of
5572 gdk_pixbuf_get_from_drawable.
5573 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5574 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5575 (xg_check_special_colors): Use GtkStyleContext and its functions
5577 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5578 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5579 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5580 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5581 Call gtk_widget_get_preferred_size.
5582 (xg_frame_resized): gdk_window_get_geometry only takes 5
5584 (xg_win_to_widget, xg_event_is_for_menubar):
5585 Call gdk_x11_window_lookup_for_display.
5586 (xg_set_widget_bg): New function.
5587 (delete_cb): New function.
5588 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5589 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5590 (xg_set_background_color): Call xg_set_widget_bg.
5591 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5592 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5593 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5594 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5596 (update_frame_tool_bar): Call gtk_widget_hide.
5597 (xg_initialize): Use GDK_KEY_g.
5599 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5601 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5603 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5604 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5605 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5607 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5609 * w32xfns.c (select_palette): Check success of RealizePalette against
5610 GDI_ERROR, not zero.
5612 See ChangeLog.11 for earlier changes.
5618 Copyright (C) 2011 Free Software Foundation, Inc.
5620 This file is part of GNU Emacs.
5622 GNU Emacs is free software: you can redistribute it and/or modify
5623 it under the terms of the GNU General Public License as published by
5624 the Free Software Foundation, either version 3 of the License, or
5625 (at your option) any later version.
5627 GNU Emacs is distributed in the hope that it will be useful,
5628 but WITHOUT ANY WARRANTY; without even the implied warranty of
5629 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5630 GNU General Public License for more details.
5632 You should have received a copy of the GNU General Public License
5633 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.