Avoid the use of snprintf.
[bpt/emacs.git] / src / ChangeLog
1 2011-08-31 Paul Eggert <eggert@cs.ucla.edu>
2
3 Avoid the use of snprintf.
4 * font.c (APPEND_SNPRINTF): Remove.
5 (font_unparse_xlfd):
6 * xterm.c (x_io_error_quitter):
7 Use esnprintf, not snprintf. That way, we don't have to worry
8 about porting to ancient platforms that lack snprintf.
9 (x_term_init): Use sprintf, not snprintf.
10
11 2011-08-30 Paul Eggert <eggert@cs.ucla.edu>
12
13 sprintf-related integer and memory overflow issues (Bug#9412).
14
15 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
16 (esprintf, esnprintf, exprintf, evxprintf): New functions.
17 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
18 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
19 (modify_event_symbol): Do not assume that the length of
20 name_alist_or_stem is safe to alloca and fits in int.
21 (Fexecute_extended_command): Likewise for function name and binding.
22 (Frecursion_depth): Wrap around reliably on integer overflow.
23 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
24 since some callers pass EMACS_INT values.
25 (Fsingle_key_description): Don't crash if symbol name contains more
26 than MAX_ALLOCA bytes.
27 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
28 (get_minibuffer): Arg is now EMACS_INT, not int.
29 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
30 (esprintf, esnprintf, exprintf, evxprintf): New decls.
31 * window.h (command_loop_level, minibuf_level): Reflect API changes.
32
33 * dbusbind.c (signature_cat): New function.
34 (xd_signature, Fdbus_register_signal):
35 Do not overrun buffer; instead, report string overflow.
36
37 * dispnew.c (add_window_display_history): Don't overrun buffer.
38 Truncate instead; this is OK since it's just a log.
39
40 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
41 even if the time zone offset is outlandishly large.
42 Don't mishandle offset == INT_MIN.
43
44 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
45 when creating daemon; the previous buffer-overflow check was incorrect.
46
47 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
48 which has the guts of the old verror function.
49
50 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
51 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
52
53 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
54 (font_unparse_xlfd): Don't blindly alloca long strings.
55 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
56 fits in int, when using sprintf. Use single snprintf to count
57 length of string rather than counting it via multiple sprintfs;
58 that's simpler and more reliable.
59 (APPEND_SPRINTF): New macro.
60 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
61 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
62 sprintf, in case result does not fit in int.
63
64 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
65 (fontset_from_font): Print it.
66
67 * frame.c (tty_frame_count): Now printmax_t, not int.
68 (make_terminal_frame, set_term_frame_name): Print it.
69 (x_report_frame_params): In X, window IDs are unsigned long,
70 not signed long, so print them as unsigned.
71 (validate_x_resource_name): Check for implausibly long names,
72 and don't assume name length fits in 'int'.
73 (x_get_resource_string): Don't blindly alloca invocation name;
74 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
75 not fit in int.
76
77 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
78 (xg_check_special_colors, xg_set_geometry):
79 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
80
81 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
82 Use esprintf, not sprintf, in case result does not fit in int.
83
84 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
85 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
86 it as a large positive number.
87 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
88 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
89
90 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
91 in case result does not fit in int.
92
93 * print.c (float_to_string): Detect width overflow more reliably.
94 (print_object): Make sprintf buffer a bit bigger, to avoid potential
95 buffer overrun. Don't assume list length fits in 'int'. Treat
96 print length of 0 as 0, not as infinity; to be consistent with other
97 uses of print length in this function. Don't overflow print length
98 index. Don't assume hash table size fits in 'long', or that
99 vectorlike size fits in 'unsigned long'.
100
101 * process.c (make_process): Use printmax_t, not int, to format
102 process-name gensyms.
103
104 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
105 to avoid potential buffer overrun.
106
107 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
108 if X resource line is longer than 512 bytes.
109
110 * xfns.c (x_window): Make sprintf buffer a bit bigger
111 to avoid potential buffer overrun.
112
113 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
114
115 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
116
117 2011-08-30 Eli Zaretskii <eliz@gnu.org>
118
119 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
120
121 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
122 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
123 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
124
125 * term.c (tty_append_glyph): New function.
126 (produce_stretch_glyph): Static function and its prototype deleted.
127
128 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
129 prototypes.
130
131 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
132
133 * image.c (parse_image_spec): Check for nonnegative, not for positive,
134 when checking :margin (Bug#9390).
135 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
136 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
137 so that the name doesn't mislead. All uses changed.
138
139 2011-08-28 Johan Bockgård <bojohan@gnu.org>
140
141 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
142 set_tty_hooks.
143
144 2011-08-27 Eli Zaretskii <eliz@gnu.org>
145
146 * xdisp.c (move_it_to): Don't bail out early when reaching
147 position beyond to_charpos, if we are scanning backwards.
148 (move_it_vertically_backward): When DY == 0, make sure we get to
149 the first character in the line after the newline.
150
151 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
152
153 * ccl.c: Improve and simplify overflow checking (Bug#9196).
154 (ccl_driver): Do not generate an out-of-range pointer.
155 (Fccl_execute_on_string): Remove unnecessary check for
156 integer overflow, noted by Stefan Monnier in
157 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
158 Remove a FIXME that didn't need fixing.
159 Simplify the newly-introduced buffer reallocation code.
160
161 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
162
163 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
164
165 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
166
167 Integer and memory overflow issues (Bug#9196).
168
169 * doc.c (get_doc_string): Rework so that
170 get_doc_string_buffer_size is the actual buffer size, rather than
171 being 1 less than the actual buffer size; this makes xpalloc more
172 convenient.
173
174 * image.c (x_allocate_bitmap_record, cache_image):
175 * xselect.c (Fx_register_dnd_atom):
176 Simplify previous changes by using xpalloc.
177
178 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
179 since either will do and ptrdiff_t is convenient with xpalloc.
180
181 * charset.c (charset_table_size)
182 (struct charset_sort_data.priority): Now ptrdiff_t.
183 (charset_compare): Don't overflow if priorities differ greatly.
184 (Fsort_charsets): Don't assume list length fits in int.
185 Check for size-calculation overflow when allocating sort data.
186 (syms_of_charset): Allocate an initial charset table that is
187 just under 64 KiB, to avoid problems with glibc malloc and mmap.
188
189 * cmds.c (internal_self_insert): Check for size-calculation overflow.
190
191 * composite.h (struct composition.glyph_len): Now int, not unsigned.
192 The actual value is always <= INT_MAX, and leaving it unsigned made
193 overflow checking harder.
194
195 * dispextern.h (struct glyph_matrix.rows_allocated)
196 (struct face_cache.size): Now ptrdiff_t, for convenience in use
197 with xpalloc. The values are still always <= INT_MAX.
198
199 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
200
201 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
202 (SAFE_NALLOCA): New macro.
203
204 * region-cache.c (struct boundary.pos, find_cache_boundary)
205 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
206 (set_cache_region, invalidate_region_cache)
207 (revalidate_region_cache, know_region_cache, region_cache_forward)
208 (region_cache_backward, pp_cache):
209 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
210 so that ptrdiff_t * can be passed to xpalloc.
211 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
212 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
213 (pp_cache): Don't assume cache_len fits in int.
214 * region-cache.h: Adjust extern decls to match.
215
216 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
217 EMACS_INT, since either will do, for xpalloc.
218
219 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
220 (xnmalloc, xnrealloc, xpalloc): New functions.
221
222 * bidi.c (bidi_shelve_header_size): New constant.
223 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
224 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
225
226 * bidi.c (bidi_cache_shrink):
227 * buffer.c (overlays_at, overlays_in, record_overlay_string)
228 (overlay_strings):
229 Don't update size of array until after memory allocation succeeds,
230 because xmalloc/xrealloc may not return.
231 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
232 now that we have proper integer overflow checking.
233 (record_overlay_string, overlay_strings): Catch overflows when
234 calculating size of overlay_str_buf.
235
236 * callproc.c (Fcall_process): Check for size overflow when
237 calculating size of args2.
238 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
239 Normally we prefer signed values, but sticking with ptrdiff_t would
240 require adding more-complicated checks.
241
242 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
243 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
244 Redo buffer-overflow calculations to avoid integer overflow.
245 Add a FIXME comment where memory seems to be over-allocated.
246
247 * character.c (Fstring): Check for size-calculation overflow.
248
249 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
250 unnecessary integer overflow. Check for size overflow.
251 (encode_coding_object): Don't update size until xmalloc succeeds.
252
253 * composite.c (get_composition_id): Check for overflow in glyph
254 length calculations.
255
256 Integer and memory overflow fixes for display code.
257 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
258 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
259 (scrolling_window): Check for overflow in size calculations.
260 (line_draw_cost, realloc_glyph_pool, add_row_entry):
261 Don't assume glyph table len fits in int.
262 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
263 (row_table_size): Now ptrdiff_t, not int.
264 (scrolling_window): Avoid overflow in size calculations.
265 Don't update size until allocation succeeds.
266 * fns.c (concat): Check for overflow in size calculations.
267 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
268 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
269 (NEXT_ALMOST_PRIME_LIMIT): New constant.
270
271 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
272 (get_doc_string): Check for size calculation overflow.
273 Don't update size until allocation succeeds.
274 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
275 EMACS_INT, where ptrdiff_t will do.
276 (Fsubstitute_command_keys): Check for string overflow.
277
278 * editfns.c (set_time_zone_rule): Don't assume environment length
279 fits in int.
280 (message_length): Now ptrdiff_t, not int.
281 (Fmessage_box): Don't update size until allocation succeeds.
282 Don't assume message length fits in int.
283 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
284
285 * emacs.c (main): Do not reallocate argv, since there is a null at
286 the end that can be overwritten, and this way there's no need to
287 worry about size-calculation overflow.
288 (sort_args): Check for size-calculation overflow.
289
290 * eval.c (init_eval_once, grow_specpdl): Don't update size until
291 alloc succeeds.
292 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
293
294 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
295 (x_set_scroll_bar_width, x_figure_window_size):
296 Check for integer overflow.
297 (x_set_alpha): Do not assume XINT fits in int.
298
299 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
300 This is for the members text_lines, text_cols, total_lines, total_cols,
301 where the system imposes an 'int' limit.
302
303 * fringe.c (Fdefine_fringe_bitmap):
304 Don't update size until alloc works.
305
306 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
307 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
308
309 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
310 Check for size-calculation overflow.
311 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
312 do, as we prefer signed integers.
313 (id_to_widget.max_size, id_to_widget.used)
314 (xg_store_widget_in_map, xg_remove_widget_from_map)
315 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
316 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
317 Use and return ptrdiff_t, not int.
318 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
319 * gtkutil.h: Change prototypes to match the above.
320
321 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
322 are duplicate now that they've been promoted to lisp.h.
323 (x_allocate_bitmap_record, x_alloc_image_color)
324 (make_image_cache, cache_image, xpm_load):
325 Don't update size until alloc is done.
326 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
327 (x_detect_edges):
328 Check for size calculation overflow.
329 (ct_colors_allocated_max): New constant.
330 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
331 overflow.
332
333 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
334 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
335 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
336 Use ptrdiff_t, not int, to count maps.
337 (read_char_minibuf_menu_prompt): Check for overflow in size
338 calculations. Don't update size until allocation succeeds. Redo
339 calculations to avoid overflow.
340 * keyboard.h: Change prototypes to match the above.
341
342 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
343 to count maps.
344 (current_minor_maps): Check for size calculation overflow.
345 * keymap.h: Change prototypes to match the above.
346
347 * lread.c (read1, init_obarray): Don't update size until alloc done.
348
349 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
350 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
351
352 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
353 Now ptrdiff_t, not int.
354 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
355 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
356
357 * process.c (Fnetwork_interface_list): Check for overflow
358 in size calculation.
359
360 * region-cache.c (move_cache_gap): Check for size calculation overflow.
361
362 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
363 overflow. Don't bother calling xmalloc when xrealloc will do.
364
365 * search.c (Freplace_match): Check for size calculation overflow.
366 (Fset_match_data): Don't assume list lengths fit in 'int'.
367
368 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
369 for command line length. Do not attempt to address one before the
370 beginning of an array, as that's not portable.
371
372 * term.c (max_frame_lines): Remove; unused.
373 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
374 not int.
375 (encode_terminal_code, calculate_costs): Check for size
376 calculation overflow.
377 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
378 table lengths and related sizes. Don't update size until alloc
379 done. Redo calculations to avoid overflow.
380 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
381
382 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
383 subtracting pointers.
384 (gobble_line): Check for overflow more carefully. Don't update size
385 until alloc done.
386
387 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
388 Don't update size until alloc done.
389 Redo size calculations to avoid overflow.
390 Check for size calculation overflow.
391 (main) [DEBUG]: Fix typo in invoking tparam1.
392
393 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
394 Use ptrdiff_t, not int, for sizes.
395 (store_mode_line_noprop_char): Don't update size until alloc done.
396
397 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
398 Use ptrdiff_t, not int, for sizes.
399 (Finternal_make_lisp_face, cache_face):
400 Check for size calculation overflow.
401 (cache_face): Treat size calculation overflows as if they were
402 memory exhaustion (the usual treatment), rather than aborting.
403
404 * xfns.c (x_encode_text, x_set_name_internal)
405 (Fx_change_window_property): Use ptrdiff_t, not int, to count
406 sizes, since they can exceed INT_MAX in size. Check for size
407 calculation overflow.
408
409 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
410 (xg_select): Check for size calculation overflow.
411 Don't update size until alloc done.
412
413 * xrdb.c (get_environ_db): Don't assume path length fits in int,
414 as sprintf is limited to int lengths.
415
416 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
417 (X_LONG_MIN): New macros.
418 Use them to make the following changes clearer.
419 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
420 This change doesn't affect the value now, but it may help remind
421 future maintainers not to raise the value too much later.
422 (SELECTION_QUANTUM): Remove, replacing with ...
423 (selection_quantum): ... new function, which avoids overflow.
424 All uses changed.
425 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
426 assumption that selection length fits in 'int'.
427 (x_reply_selection_request, x_handle_selection_request)
428 (x_get_window_property, receive_incremental_selection)
429 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
430 (lisp_data_to_selection_data, clean_local_selection_data):
431 Use ptrdiff_t, not int, to record length of selection.
432 (x_reply_selection_request, x_get_window_property)
433 (receive_incremental_selection, x_property_data_to_lisp):
434 Redo calculations to avoid overflow.
435 (x_reply_selection_request): When sending hint, ceiling it at
436 X_LONG_MAX rather than relying on wraparound overflow to send
437 something.
438 (x_get_window_property, receive_incremental_selection)
439 (lisp_data_to_selection_data, x_property_data_to_lisp):
440 Check for size-calculation overflow.
441 (x_get_window_property, receive_incremental_selection)
442 (lisp_data_to_selection_data, Fx_register_dnd_atom):
443 Don't store size until memory allocation succeeds.
444 (x_get_window_property): Plug memory leak on memory exhaustion.
445 Don't double-block input; malloc is safe here. Don't assume 2**34
446 - 4 fits in unsigned long. Add an xassert to check
447 XGetWindowProperty overflow. Be more careful about overflow
448 calculations, and distinguish size from memory overflow better.
449 (receive_incremental_selection): When tracing, don't assume
450 unsigned int is less than INT_MAX.
451 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
452 harmful) conversions of unsigned short to int.
453 (lisp_data_to_selection_data): Don't assume that integers
454 in the range -65535 through -1 fit in an X unsigned short.
455 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
456 result parameters unless successful. Rely on cons_to_unsigned
457 to report problems with elements; the old code wasn't right anyway.
458 (x_check_property_data): Check for int overflow; we cannot use
459 a wider type due to X limits.
460 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
461
462 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
463
464 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
465 (x_term_init): Check for size calculation overflow.
466 (x_color_cells): Don't store size until memory allocation succeeds.
467 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
468 Don't assume alloca size is less than MAX_ALLOCA.
469 (x_term_init): Don't assume length fits in int (sprintf is limited
470 to int size).
471
472 Use ptrdiff_t for composition IDs.
473 * character.c (lisp_string_width):
474 * composite.c (composition_table_size, n_compositions)
475 (get_composition_id, composition_gstring_from_id):
476 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
477 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
478 * window.c (Frecenter):
479 Use ptrdiff_t, not int, for composition IDs.
480 * composite.c (get_composition_id): Check for integer overflow.
481 * composite.h: Adjust prototypes to match the above changes.
482
483 Use ptrdiff_t for hash table indexes.
484 * category.c (hash_get_category_set):
485 * ccl.c (ccl_driver):
486 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
487 * coding.c (coding_system_charset_list, detect_coding_system):
488 * coding.h (struct coding_system.id):
489 * composite.c (get_composition_id, gstring_lookup_cache):
490 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
491 * image.c (xpm_get_color_table_h):
492 * lisp.h (hash_lookup, hash_put):
493 * minibuf.c (Ftest_completion):
494 Use ptrdiff_t for hash table indexes, not int (which is too
495 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
496 32-bit --with-wide-int hosts).
497
498 * charset.c (Fdefine_charset_internal): Check for integer overflow.
499 Add a FIXME comment about memory leaks.
500 (syms_of_charset): Don't assume xmalloc returns.
501
502 Don't assume that stated character widths fit in int.
503 * character.c (Fchar_width, c_string_width, lisp_string_width):
504 * character.h (CHAR_WIDTH):
505 * indent.c (MULTIBYTE_BYTES_WIDTH):
506 Use sanitize_char_width to avoid undefined and/or bad behavior
507 with outlandish widths.
508 * character.h (sanitize_tab_width): Renamed from sanitize_width,
509 now that we have two such functions. All uses changed.
510 (sanitize_char_width): New inline function.
511
512 Don't assume that tab-width fits in int.
513 * character.h (sanitize_width): New inline function.
514 (SANE_TAB_WIDTH): New macro.
515 (ASCII_CHAR_WIDTH): Use it.
516 * indent.c (sane_tab_width): Remove. All uses replaced by
517 SANE_TAB_WIDTH (current_buffer).
518 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
519
520 * fileio.c: Integer overflow issues with file modes.
521 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
522
523 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
524 Remove unreachable code.
525 (read_hex, load_charset_map_from_file): Check for integer overflow.
526
527 * xterm.c: don't go over XClientMessageEvent limit
528 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
529 (x_send_scroll_bar_event): Likewise. Check that the size does not
530 exceed limits imposed by XClientMessageEvent, as well as the usual
531 ptrdiff_t and size_t limits.
532
533 * keyboard.c: Overflow, signedness and related fixes.
534 (make_lispy_movement): Use same integer type in forward decl
535 that is used in the definition.
536 (read_key_sequence, keyremap_step):
537 Change bufsize argument back to int, undoing my 2011-03-30 change.
538 We prefer signed types, and int is wide enough here.
539 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
540 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
541 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
542 length, not size_t. Use ptrdiff_t for index, not int.
543 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
544 possibility of integer overflow.
545
546 Overflow, signedness and related fixes for images.
547
548 * dispextern.h (struct it.stack[0].u.image.image_id)
549 (struct_it.image_id, struct image.id, struct image_cache.size)
550 (struct image_cache.used, struct image_cache.ref_count):
551 * gtkutil.c (update_frame_tool_bar):
552 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
553 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
554 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
555 * nsmenu.m (update_frame_tool_bar):
556 * xdisp.c (calc_pixel_width_or_height):
557 * xfns.c (image_cache_refcount):
558 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
559 on typical 64-bit hosts.
560
561 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
562 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
563 Omit unnecessary casts to int.
564 (parse_image_spec): Check that integers fall into 'int' range
565 when the callers expect that.
566 (image_ascent): Redo ascent calculation to avoid int overflow.
567 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
568 (lookup_image): Remove unnecessary tests.
569 (xbm_image_p): Locals are now of int, not EMACS_INT,
570 since parse_image_check makes sure they fit into int.
571 (png_load, gif_load, svg_load_image):
572 Prefer int to unsigned where either will do.
573 (tiff_handler): New function, combining the cores of the
574 old tiff_error_handler and tiff_warning_handler. This
575 function is rewritten to use vsnprintf and thereby avoid
576 stack buffer overflows. It uses only the features of vsnprintf
577 that are common to both POSIX and native Microsoft.
578 (tiff_error_handler, tiff_warning_handler): Use it.
579 (tiff_load, gif_load, imagemagick_load_image):
580 Don't assume :index value fits in 'int'.
581 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
582 (imagemagick_load_image): Check that crop parameters fit into
583 the integer types that MagickCropImage accepts. Don't assume
584 Vimagemagick_render_type has a nonnegative value. Don't assume
585 size_t fits in 'long'.
586 (gs_load): Use printmax_t to print the widest integers possible.
587 Check for integer overflow when computing image height and width.
588
589 2011-08-26 Eli Zaretskii <eliz@gnu.org>
590
591 * xdisp.c (redisplay_window): Don't force window start if point
592 will be invisible in the resulting window. (Bug#9324)
593
594 2011-08-25 Eli Zaretskii <eliz@gnu.org>
595
596 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
597 the display spec is of the form `(space ...)'.
598 (handle_display_spec): Return the value returned by
599 handle_single_display_spec, not just 1 or zero.
600 (handle_single_display_spec): If the display spec is of the form
601 `(space ...)', and specifies display in the text area, return 2
602 rather than 1.
603 (try_cursor_movement): Check for the need to scroll more
604 accurately, and prefer exact match for point under bidi. Don't
605 advance `row' beyond the last row of the window.
606
607 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
608 into disp_prop; all users changed.
609
610 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
611 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
612 for the text covered by the display property.
613
614 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
615
616 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
617 Change return value to nil.
618 (Frecord_buffer): Delete unused function.
619
620 2011-08-24 Eli Zaretskii <eliz@gnu.org>
621
622 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
623 buffers, return left-to-right.
624 (set_cursor_from_row): Consider candidate row a win if its glyph
625 represents a newline and point is on that newline. Fixes cursor
626 positioning on the newline at EOL of R2L text within L2R
627 paragraph, and vice versa.
628 (try_cursor_movement): Check continued rows, in addition to
629 continuation rows. Fixes unwarranted scroll when point enters a
630 continued line of R2L text within an L2R paragraph, or vice versa.
631 (cursor_row_p): Consider the case of point being equal to
632 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
633 from the end of a short line to the beginning of a continued line
634 of R2L text within L2R paragraph.
635 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
636 composed characters.
637
638 * bidi.c (bidi_check_type): Use xassert.
639 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
640 members.
641
642 2011-08-23 Eli Zaretskii <eliz@gnu.org>
643
644 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
645 a character.
646
647 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
648
649 * nsfont.m (ns_otf_to_script): Fix typo.
650
651 2011-08-22 Kenichi Handa <handa@m17n.org>
652
653 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
654 extra slot even if the purpose is char-code-property-table.
655
656 2011-08-23 Eli Zaretskii <eliz@gnu.org>
657
658 * xdisp.c (redisplay_window): When computing centering_position,
659 account for the height of the header line. (Bug#8874)
660
661 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
662 instead of CHAR_TO_BYTE. Fixes a crash when a completion
663 candidate is selected by the mouse, and that candidate has a
664 composed character under the mouse.
665
666 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
667 coordinates reported by pos-visible-in-window-p for a composed
668 character in column zero.
669
670 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
671
672 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
673
674 2011-08-22 Eli Zaretskii <eliz@gnu.org>
675
676 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
677 consider it a hit if to_charpos is anywhere in the range of the
678 composed buffer positions.
679
680 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
681
682 * image.c (gif_load): Don't assume that each subimage has the same
683 dimensions as the base image. Handle disposal method that is
684 "undefined" by the gif spec (Bug#9335).
685
686 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
687
688 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
689 (Fcondition_case): Document `debug' symbol in error handler.
690
691 2011-08-19 Eli Zaretskii <eliz@gnu.org>
692
693 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
694 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
695 from an Org mode buffer to a Speedbar frame.
696
697 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
698 a composition, take its buffer position from IT->cmp_it.charpos.
699 Fixes cursor positioning at the beginning of a line that begins
700 with a composed character.
701
702 2011-08-18 Eli Zaretskii <eliz@gnu.org>
703
704 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
705 character bidirectional type, use STRONG_L instead. Fixes crashes
706 in a buffer produced by `describe-categories'.
707
708 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
709 members before the level stack, so they would be saved and
710 restored when copying iterator state. Fixes incorrect reordering
711 around TABs covered by display properties.
712
713 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
714
715 * process.c (Fnetwork_interface_list): Correctly determine buffer
716 size.
717
718 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
719
720 * eval.c (internal_condition_case, internal_condition_case_1)
721 (internal_condition_case_2, internal_condition_case_n):
722 Remove unnecessary aborts (Bug#9081).
723
724 2011-08-17 Eli Zaretskii <eliz@gnu.org>
725
726 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
727 has no `load' handler, try opening the file locally. (Bug#9311)
728
729 2011-08-16 Ken Brown <kbrown@cornell.edu>
730
731 * gmalloc.c: Expand comment.
732
733 2011-08-16 Eli Zaretskii <eliz@gnu.org>
734
735 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
736 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
737
738 2011-08-16 Ken Brown <kbrown@cornell.edu>
739
740 Fix memory allocation problems in Cygwin build (Bug#9273).
741
742 * unexcw.c ( __malloc_initialized): Declare external variable.
743 (fixup_executable): Force the dumped emacs to reinitialize malloc.
744
745 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
746 New variables.
747 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
748 dumped emacs.
749 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
750 in the static heap.
751 [CYGWIN] (special_realloc): New function.
752 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
753 requests to realloc storage in the static heap.
754
755 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
756
757 * bidi.c (bidi_initialize): Remove unused local.
758
759 2011-08-15 Eli Zaretskii <eliz@gnu.org>
760
761 * biditype.h: File removed.
762
763 * bidimirror.h: File removed.
764
765 * deps.mk (bidi.o): Remove biditype.h and
766 bidimirror.h.
767
768 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
769 bidimirror.h.
770
771 * dispextern.h: Fix a typo in the comment to bidi_type_t.
772
773 * chartab.c: Improve commentary for the uniprop_table API.
774
775 * bidi.c (bidi_paragraph_init): Support zero value of
776 bidi_ignore_explicit_marks_for_paragraph_level.
777 (bidi_initialize): Use uniprop_table instead of including
778 biditype.h and bidimirror.h.
779
780 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
781 coordinates of the iterator when restoring from ppos_it.
782 (Bug#9296)
783
784 2011-08-14 Kenichi Handa <handa@m17n.org>
785
786 * process.c (create_process): Call setup_process_coding_systems
787 after the pid of the process is set to -1 (Bug#8162).
788
789 2011-08-14 Eli Zaretskii <eliz@gnu.org>
790
791 * xdisp.c (move_it_in_display_line_to): Don't invoke
792 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
793 ppos_it. Fixes vertical cursor motion when line beginning is
794 covered by an image. (Bug#9296)
795
796 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
797
798 * nsterm.h (ns_run_ascript): Declare.
799 (NSAPP_DATA2_RUNASSCRIPT): Define.
800
801 * nsfns.m (as_script, as_result, as_status): New static variables.
802 (ns_run_ascript): New function.
803 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
804 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
805 the event loop. Get status from as_status (Bug#7276).
806
807 * nsterm.m (sendEvent): If event is NSApplicationDefined and
808 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
809 the event loop (Bug#7276).
810
811 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
812
813 * gnutls.c (QCgnutls_bootprop_priority)
814 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
815 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
816 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
817 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
818 (QCgnutls_bootprop_verify_hostname_error)
819 (QCgnutls_bootprop_callbacks_verify): Rename from
820 Qgnutls_bootprop_..., all uses changed.
821
822 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
823 uses changed.
824
825 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
826
827 * xfaces.c (Qframe_set_background_mode): Now static.
828 * dispextern.h (Qframe_set_background_mode): Remove decl.
829
830 * process.c (Fnetwork_interface_info): Declare local only if needed.
831
832 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
833
834 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
835 (Fnetwork_interface_list): Allocate in increments of bytes instead
836 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
837 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
838 sockaddr.
839 (struct ifflag_def): notrailers is smart on OSX.
840 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
841 Get hardware address with getifaddrs if available.
842
843 2011-08-12 Eli Zaretskii <eliz@gnu.org>
844
845 * xdisp.c (iterate_out_of_display_property): xassert that
846 IT->position is set to within IT->object's boundaries. Break from
847 the loop as soon as EOB is reached; avoids infloops in redisplay
848 when IT->position is set up wrongly due to some bug.
849 Set IT->current to match the bidi iterator unconditionally.
850 (push_display_prop): Allow GET_FROM_STRING as IT->method on
851 entry. Force push_it to save on the stack the current
852 buffer/string position, to be restored by pop_it. Fix flags in
853 the iterator structure wrt the object coming from a display
854 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
855 properties. (Bug#9284)
856
857 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
858
859 * fontset.c (fontset_get_font_group): Add proper type checks.
860 (Bug#9172)
861
862 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
863
864 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
865 and LC_VERSION_MIN_MACOSX.
866 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
867 (dump_it) [LC_FUNCTION_STARTS]: Use it.
868
869 2011-08-08 Eli Zaretskii <eliz@gnu.org>
870
871 * xdisp.c (forward_to_next_line_start): Allow to use the
872 no-display-properties-and-no-overlays under bidi display.
873 Set disp_pos in the bidi iterator to avoid searches for display
874 properties and overlays.
875
876 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
877
878 * editfns.c (Fset_time_zone_rule): Document relationship with the
879 setenv function.
880
881 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
882 the font entity extracted from the cache (Bug#8109).
883
884 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
885
886 * composite.c (autocmp_chars): Don't reset point. That is done by
887 restore_point_unwind (Bug#5984).
888
889 2011-08-07 Juri Linkov <juri@jurta.org>
890
891 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
892 to show the arg `TIME' instead of `TIMEVAL'.
893
894 2011-08-06 Eli Zaretskii <eliz@gnu.org>
895
896 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
897 display property strides EOL and includes a newline, as in
898 longlines-mode. (Bug#9254)
899 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
900 word-wrap under bidirectional display. (Bug#9224)
901
902 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
903 is non-zero, even if the data buffer is NULL. Fixes a crash in
904 vertical-motion with longlines-mode. (Bug#9254)
905
906 2011-08-05 Eli Zaretskii <eliz@gnu.org>
907
908 * bidi.c <bidi_cache_total_alloc>: Now static.
909 (bidi_initialize): Initialize bidi_cache_total_alloc.
910
911 * xdisp.c (display_line): Release buffer allocated for shelved bidi
912 cache. (Bug#9221)
913
914 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
915 amount allocated this far in `bidi_cache_total_alloc'.
916 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
917 non-zero, only free the data buffer without restoring the cache
918 contents. All callers changed.
919
920 * dispextern.h (bidi_unshelve_cache): Update prototype.
921
922 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
923 (move_it_in_display_line, move_it_to)
924 (move_it_vertically_backward, move_it_by_lines): Replace the call
925 to xfree to an equivalent call to bidi_unshelve_cache.
926 (move_it_in_display_line_to): Fix logic of returning
927 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
928
929 2011-08-05 Eli Zaretskii <eliz@gnu.org>
930
931 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
932 came from a string character with a `cursor' property. (Bug#9229)
933
934 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
935
936 * Makefile.in (LIB_PTHREAD): New variable.
937 (LIBES): Add LIB_PTHREAD (Bug#9216).
938
939 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
940 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
941
942 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
943
944 * regex.c (re_iswctype): Remove some redundant boolean
945 conversions.
946
947 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
948
949 * xterm.c (x_find_topmost_parent): New function.
950 (x_set_frame_alpha): Find topmost parent window with
951 x_find_topmost_parent and set the property there also (bug#9181).
952 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
953
954 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
955
956 * callproc.c (Fcall_process): Avoid vfork clobbering
957 the local vars buffer, coding_systems, current_dir.
958
959 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
960
961 * keymap.c (Fmake_composed_keymap): Move to subr.el.
962
963 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
964
965 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
966 so that it is not optimized away.
967
968 * xdisp.c (compute_display_string_pos): Remove unused local.
969
970 2011-08-02 Eli Zaretskii <eliz@gnu.org>
971
972 Fix slow cursor motion and scrolling in large buffers with
973 selective display, like Org Mode buffers. (Bug#9218)
974
975 * dispextern.h (struct bidi_it): New member disp_prop_p.
976
977 * xdisp.c: Remove one-slot cache of display string positions.
978 (compute_display_string_pos): Accept an additional argument
979 DISP_PROP_P; callers changed. Scan at most 5K characters forward
980 for a display string or property. If found, set DISP_PROP_P
981 non-zero.
982
983 * bidi.c (bidi_fetch_char): Accept an additional argument
984 DISP_PROP_P, and pass it to compute_display_string_pos.
985 Only handle text covered by a display string if DISP_PROP_P is returned
986 non-zero. All callers of bidi_fetch_char changed.
987
988 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
989
990 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
991
992 2010-12-03 Don March <don@ohspite.net>
993
994 * keymap.c (Fdefine_key): Fix non-prefix key error message when
995 last character M-[char] is translated to ESC [char] (bug#7541).
996
997 2011-08-02 Kenichi Handa <handa@m17n.org>
998
999 * lisp.h (uniprop_table): Extern it.
1000
1001 * chartab.c (uniprop_table): Make it non-static.
1002
1003 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1004
1005 * xdisp.c (forward_to_next_line_start): Accept additional argument
1006 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1007 on the newline.
1008 (reseat_at_next_visible_line_start): Use the bidi iterator state
1009 returned by forward_to_next_line_start to restore the state of
1010 it->bidi_it after backing up to previous newline. (Bug#9212)
1011
1012 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1013
1014 * regex.c (re_comp): Protoize.
1015 (re_exec): Fix return type.
1016 (regexec): Fix type of `ret'. (Bug#9203)
1017
1018 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
1019
1020 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1021 This is needed if max-image-size is a floating-point number.
1022
1023 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1024
1025 * print.c (print_object): Print empty symbol as ##.
1026
1027 * lread.c (read1): Read ## as empty symbol.
1028
1029 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1030
1031 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1032 setting frame foreground color (Bug#9175).
1033 (x_set_background_color): Likewise.
1034
1035 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1036 contents (Bug#9176).
1037 (EmacsTooltip -init): Remove bezels and add shadows to
1038 tooltip windows.
1039
1040 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1041 or scroll bar (Bug#8470).
1042
1043 * nsfont.m (nsfont_open): Remove assignment to voffset and
1044 unnecessary vars hshink, expand, hd, full_height, min_height.
1045 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1046
1047 * nsterm.h (nsfont_info): Remove voffset field.
1048
1049 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1050
1051 Implement strike-through and overline on NextStep (Bug#8863).
1052
1053 * nsfont.m (nsfont_open): Use underline position provided by font,
1054 instead of hard-coded value of 2.
1055 (nsfont_draw): Call ns_draw_text_decoration instead.
1056
1057 * nsterm.h: Add declaration for ns_draw_text_decoration.
1058
1059 * nsterm.m (ns_draw_text_decoration): New function for drawing
1060 underline, overline, and strike-through.
1061 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1062 ns_draw_text_decoration. Change treatment of cursor drawing to
1063 accomodate underlining, etc.
1064
1065 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1066
1067 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1068 default.
1069
1070 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1071
1072 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1073 Without this fix, if a signal arrives just after memory fills up,
1074 'malloc' might be invoked reentrantly.
1075
1076 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1077 In other words, assume that every image size is allowed, on non-X
1078 hosts. This assumption is probably wrong, but it lets Emacs compile.
1079
1080 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1081
1082 * regex.c (re_iswctype): Convert return values to boolean.
1083
1084 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1085
1086 * xdisp.c (compute_display_string_pos): Don't use cached display
1087 string position if the buffer had its restriction changed.
1088 (Bug#9184)
1089
1090 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1091
1092 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1093
1094 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1095
1096 Integer signedness and overflow and related fixes. (Bug#9079)
1097
1098 * bidi.c: Integer size and overflow fixes.
1099 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1100 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1101 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1102 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1103 (bidi_find_other_level_edge):
1104 Use ptrdiff_t instead of EMACS_INT where either will do.
1105 This works better on 32-bit hosts configured --with-wide-int.
1106 (bidi_cache_ensure_space): Check for size-calculation overflow.
1107 Use % rather than repeated addition, for better worst-case speed.
1108 Don't set bidi_cache_size until after xrealloc returns, because it
1109 might not return.
1110 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1111 (bidi_cache_ensure_space): Also check that the bidi cache size
1112 does not exceed that of the largest Lisp string or buffer. See Eli
1113 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1114
1115 * alloc.c (__malloc_size_t): Remove.
1116 All uses replaced by size_t. See Andreas Schwab's note
1117 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1118
1119 * image.c: Improve checking for integer overflow.
1120 (check_image_size): Assume that f is nonnull, since
1121 it is always nonnull in practice. This is one less thing to
1122 worry about when checking for integer overflow later.
1123 (x_check_image_size): New function, which checks for integer
1124 overflow issues inside X.
1125 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1126 This removes the need for a memory_full check.
1127 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1128 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1129 (xbm_read_bitmap_data): Change locals back to 'int', since
1130 their values must fit in 'int'.
1131 (xpm_load_image, png_load, tiff_load):
1132 Invoke x_create_x_image_and_pixmap earlier,
1133 to avoid much needless work if the image is too large.
1134 (tiff_load): Treat overly large images as if
1135 x_create_x_image_and_pixmap failed, not as malloc failures.
1136 (gs_load): Use x_check_image_size.
1137
1138 * gtkutil.c: Omit integer casts.
1139 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1140 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1141
1142 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1143
1144 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1145 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1146 would wrongly return t on a 64-bit host.
1147
1148 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1149 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1150 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1151 and therefore cause GCC to emit a bogus diagnostic in some cases.
1152
1153 * image.c: Integer signedness and overflow and related fixes.
1154 This is not an exhaustive set of fixes, but it's time to
1155 record what I've got.
1156 (lookup_pixel_color, check_image_size): Remove redundant decls.
1157 (check_image_size): Don't assume that arbitrary EMACS_INT values
1158 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1159 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1160 (tiff_load, imagemagick_load_image):
1161 Check for overflow in size calculations.
1162 (x_create_x_image_and_pixmap): Remove unnecessary test for
1163 xmalloc returning NULL; that can't happen.
1164 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1165 (xpm_color_bucket): Use better integer hashing function.
1166 (xpm_cache_color): Don't possibly over-allocate memory.
1167 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1168 (gif_memory_source):
1169 Use ptrdiff_t, not int or size_t, to record sizes.
1170 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1171 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1172 either works, as we prefer signed integers.
1173 (tiff_read_from_memory, tiff_write_from_memory):
1174 Return tsize_t, not size_t, since that's what the TIFF API wants.
1175 (tiff_read_from_memory): Don't fail simply because the read would
1176 go past EOF; instead, return a short read.
1177 (tiff_load): Omit no-longer-needed casts.
1178 (Fimagemagick_types): Don't assume size fits into 'int'.
1179
1180 Improve hashing quality when configured --with-wide-int.
1181 * fns.c (hash_string): New function, taken from sxhash_string.
1182 Do not discard information about ASCII character case; this
1183 discarding is no longer needed.
1184 (sxhash-string): Use it. Change sig to match it. Caller changed.
1185 * lisp.h: Declare it.
1186 * lread.c (hash_string): Remove, since we now use fns.c's version.
1187 The fns.c version returns a wider integer if --with-wide-int is
1188 specified, so this should help the quality of the hashing a bit.
1189
1190 * emacs.c: Integer overflow minor fix.
1191 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1192 Define only if GNU_LINUX.
1193 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1194
1195 * dispnew.c: Integer signedness and overflow fixes.
1196 Remove unnecessary forward decls, that were a maintenance hassle.
1197 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1198 All uses changed.
1199 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1200 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1201 (prepare_desired_row, line_draw_cost):
1202 Use int, not unsigned, where either works.
1203 (save_current_matrix, restore_current_matrix):
1204 Use ptrdiff_t, not size_t, where either works.
1205 (init_display): Check for overflow more accurately, and without
1206 relying on undefined behavior.
1207
1208 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1209 Remove, replacing with the new symbols in lisp.h. All uses changed.
1210 * fileio.c (make_temp_name):
1211 * filelock.c (lock_file_1, lock_file):
1212 * xdisp.c (message_dolog):
1213 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1214 Use pMd etc. instead.
1215 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1216 replacing the pWIDE etc. symbols removed from editfns.c.
1217
1218 * keyboard.h (num_input_events): Now uintmax_t.
1219 This is (very slightly) less likely to mess up due to wraparound.
1220 All uses changed.
1221
1222 * buffer.c: Integer signedness fixes.
1223 (alloc_buffer_text, enlarge_buffer_text):
1224 Use ptrdiff_t rather than size_t when either will do, as we prefer
1225 signed integers.
1226
1227 * alloc.c: Integer signedness and overflow fixes.
1228 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1229 (__malloc_size_t): Default to size_t, not to int.
1230 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1231 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1232 Prefer ptrdiff_t to size_t when either would do, as we prefer
1233 signed integers.
1234 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1235 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1236 Now const. Initialize with values that are in range even if char
1237 is signed.
1238 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1239 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1240 These functions do the right thing with sizes > 2**32.
1241 (check_depth): Now ptrdiff_t, not int.
1242 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1243 Adjust to new way of storing sizes. Check for size overflow bugs
1244 in rest of code.
1245 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1246 slightly wrong anyway, as it missed one instance of
1247 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1248 (refill_memory_reserve): Omit needless cast to size_t.
1249 (mark_object_loop_halt): Mark as externally visible.
1250
1251 * xselect.c: Integer signedness and overflow fixes.
1252 (Fx_register_dnd_atom, x_handle_dnd_message):
1253 Use ptrdiff_t, not size_t, since we prefer signed.
1254 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1255 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1256 x_dnd_atoms_size and x_dnd_atoms_length.
1257
1258 * doprnt.c: Prefer signed to unsigned when either works.
1259 * eval.c (verror):
1260 * doprnt.c (doprnt):
1261 * lisp.h (doprnt):
1262 * xdisp.c (vmessage):
1263 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1264 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1265 prefer signed arithmetic to avoid comparison confusion.
1266 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1267 but is a bit tricky.
1268
1269 Assume freestanding C89 headers, string.h, stdlib.h.
1270 * data.c, doprnt.c, floatfns.c, print.c:
1271 Include float.h unconditionally.
1272 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1273 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1274 * regex.c: Likewise for stddef.h, string.h.
1275 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1276 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1277 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1278 (STDC_HEADERS): Remove obsolete defines.
1279 * sysdep.c: Include limits.h unconditionally.
1280
1281 Assume support for memcmp, memcpy, memmove, memset.
1282 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1283 * regex.c (memcmp, memcpy):
1284 Remove; we assume C89 now.
1285
1286 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1287 (__malloc_safe_bcopy): Remove; no longer needed.
1288
1289 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1290 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1291 well either way, and we prefer signed to unsigned.
1292
1293 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1294
1295 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1296 closes the connection while we're reading (bug#9182).
1297
1298 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1299
1300 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1301 are specified (Bug#9168).
1302
1303 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1304
1305 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1306 Found by GCC static checking and --with-wide-int on a 32-bit host.
1307
1308 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1309
1310 * xdisp.c (compute_display_string_pos): Fix logic of caching
1311 previous display string position. Initialize cached_prev_pos to
1312 -1. Fixes slow-down at the beginning of a buffer.
1313
1314 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1315
1316 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1317 for attrs[LFACE_FONTSET_INDEX].
1318
1319 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 * xml.c (parse_region): Remove unused local
1322 that was recently introduced.
1323
1324 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1325
1326 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1327 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1328
1329 * xdisp.c (move_it_in_display_line_to): Record the best matching
1330 position for TO_CHARPOS while scanning the line, and restore it on
1331 exit if none of the characters scanned was an exact match.
1332 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1333 when exact match is impossible due to invisible text, and the
1334 lines are truncated.
1335
1336 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1337
1338 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1339 for OSX >= 10.7.
1340
1341 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1342
1343 Fix a significant slow-down of cursor motion with C-n, C-p,
1344 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1345 auto-repeat under bidi redisplay in fontified buffers.
1346 * xdisp.c (compute_stop_pos_backwards): New function.
1347 (next_element_from_buffer): Call compute_stop_pos_backwards to
1348 find a suitable prev_stop when we find ourselves before
1349 base_level_stop.
1350 (reseat): Don't look for prev_stop, as that could mean a very long
1351 run.
1352 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1353 <cached_disp_overlay_modiff>: Cache for last found display string
1354 position.
1355 (compute_display_string_pos): Return the cached position if asked
1356 about the same buffer in the same area of character positions, and
1357 the buffer wasn't changed since the time the display string
1358 position was cached.
1359
1360 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1361
1362 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1363 is an integer, which is important for empty lines. (Bug#9149)
1364
1365 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1366
1367 * frame.c (Fmodify_frame_parameters): In tty case, update the
1368 default face if necessary (Bug#4238).
1369
1370 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1371
1372 * editfns.c (Fstring_to_char): No need to explain what a character
1373 is in the docstring (Bug#6576).
1374
1375 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1376
1377 * xml.c (parse_region): Make sure we always return a tree.
1378
1379 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1380
1381 * xml.c (parse_region): If a document contains only comments,
1382 return that, too.
1383
1384 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1385
1386 * xml.c (make_dom): Return comments, too.
1387
1388 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1389
1390 Port to OpenBSD.
1391 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1392 and the surrounding thread.
1393 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1394 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1395 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1396 timer goes off.
1397 * s/openbsd.h (BROKEN_SIGIO): Define.
1398 * unexelf.c (unexec) [__OpenBSD__]:
1399 Don't update the .mdebug section of the Alpha COFF symbol table.
1400
1401 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1402
1403 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1404 (bug#8460).
1405
1406 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1407
1408 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1409 This fixes some race conditions on the permissions of any newly
1410 created file.
1411
1412 * alloc.c (valid_pointer_p): Use pipe, not open.
1413 This fixes some permissions issues when debugging.
1414
1415 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1416 If fchown fails to set both uid and gid, try to set just gid,
1417 as that is sometimes allowed. Adjust the file's mode to eliminate
1418 setuid or setgid bits that are inappropriate if fchown fails.
1419
1420 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1421
1422 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1423 to compare Lisp_Objects.
1424 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1425 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1426 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1427
1428 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1429
1430 * lread.c (read_integer): Unread even EOF character.
1431 (read1): Likewise. Properly record start position of symbol.
1432
1433 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1434 symbol character follows.
1435
1436 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1437
1438 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1439 This works around a problem with the previous change to Fcopy_file.
1440 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1441 and without this change, GCC might complain about discarding
1442 fchown's return value.
1443
1444 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1445
1446 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1447
1448 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1449
1450 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1451
1452 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1453
1454 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1455 it's used from the C level.
1456
1457 * process.c: Use the same condition for POLL_FOR_INPUT in both
1458 keyboard.c and process.c (bug#1858).
1459
1460 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1461
1462 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1463 (Fgnutls_boot): Use it.
1464
1465 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1466
1467 * doc.c (Fsubstitute_command_keys): Revert last change.
1468
1469 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1470
1471 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1472 quotes the next character, and doesn't affect other longer
1473 sequences (bug#8935).
1474
1475 * lread.c (syms_of_lread): Clarify that is isn't only
1476 `eval-buffer' and `eval-defun' that's affected by
1477 `lexical-binding' (bug#8460).
1478
1479 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1480
1481 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1482 bidi redisplay when a line includes both an image and is
1483 truncated.
1484
1485 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1486
1487 Fix minor problems found by static checking.
1488 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1489 (elsz): Now a signed constant, not a size_t var. We prefer signed
1490 types to unsigned, to avoid integer comparison confusion. Without
1491 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1492 "cannot optimize loop, the loop counter may overflow", a symptom
1493 of the confusion.
1494 * indent.c (Fvertical_motion): Mark locals as initialized.
1495 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1496
1497 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1498
1499 * search.c (Fre_search_backward): Mention `case-fold-search' in
1500 all the re_search_* functions (bug#8138).
1501
1502 * keyboard.c (Fopen_dribble_file): Document when the file is
1503 closed (bug#8056).
1504
1505 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1506
1507 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1508 bidi_cache_idx.
1509
1510 Support bidi reordering of display and overlay strings.
1511 * xdisp.c (compute_display_string_pos)
1512 (compute_display_string_end): Accept additional argument STRING.
1513 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1514 (reseat_to_string): Initialize bidi_it->string.s and
1515 bidi_it->string.schars.
1516 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1517 NULL (avoids a crash in bidi_paragraph_init).
1518 Initialize itb.string.lstring.
1519 (init_iterator): Call bidi_init_it only of a valid
1520 buffer position was specified. Initialize paragraph_embedding to
1521 L2R.
1522 (reseat_to_string): Initialize the bidi iterator.
1523 (display_string): If we need to ignore text properties of
1524 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1525 original value of -1 will not work with bidi.)
1526 (compute_display_string_pos): First arg is now struct
1527 `text_pos *'; all callers changed. Support display properties on
1528 Lisp strings.
1529 (compute_display_string_end): Support display properties on Lisp
1530 strings.
1531 (init_iterator, reseat_1, reseat_to_string): Initialize the
1532 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1533 when iterating on a string not from display properties).
1534 (compute_display_string_pos, compute_display_string_end):
1535 Fix calculation of the object to scan. Fixes an error when using
1536 arrow keys.
1537 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1538 base_level_stop; instead, set base_level_stop to BEGV.
1539 Fixes crashes in vertical-motion.
1540 (next_element_from_buffer): Improve commentary for when
1541 the iterator is before prev_stop.
1542 (init_iterator): Initialize bidi_p from the default value of
1543 bidi-display-reordering, not from buffer-local value. Use the
1544 buffer-local value only if initializing for buffer iteration.
1545 (handle_invisible_prop): Support invisible properties on strings
1546 that are being bidi-reordered.
1547 (set_iterator_to_next): Support bidi reordering of C strings and
1548 Lisp strings.
1549 (next_element_from_string): Support bidi reordering of Lisp
1550 strings.
1551 (handle_stop_backwards): Support Lisp strings as well.
1552 (display_string): Support display of R2L glyph rows.
1553 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1554 (init_iterator): Don't initialize it->bidi_p for strings
1555 here.
1556 (reseat_to_string): Initialize it->bidi_p for strings here.
1557 (next_element_from_string, next_element_from_c_string)
1558 (next_element_from_buffer): Add xassert's for correspondence
1559 between IT's object being iterated and it->bidi_it.string
1560 structure.
1561 (face_before_or_after_it_pos): Support bidi iteration.
1562 (next_element_from_c_string): Handle the case of the first string
1563 character that is not the first one in the visual order.
1564 (get_visually_first_element): New function, refactored from common
1565 parts of next_element_from_buffer, next_element_from_string, and
1566 next_element_from_c_string.
1567 (tool_bar_lines_needed, redisplay_tool_bar)
1568 (display_menu_bar): Force left-to-right direction. Add a FIXME
1569 comment for making that be controlled by a user option.
1570 (push_it, pop_it): Save and restore the state of the
1571 bidi iterator. Save and restore the bidi_p flag.
1572 (pop_it): Iterate out of display property for string iteration as
1573 well.
1574 (iterate_out_of_display_property): Support iteration over strings.
1575 (handle_single_display_spec): Set up it->bidi_it for iteration
1576 over a display string, and call bidi_init_it.
1577 (handle_single_display_spec, next_overlay_string)
1578 (get_overlay_strings_1, push_display_prop): Set up the bidi
1579 iterator for displaying display or overlay strings.
1580 (forward_to_next_line_start): Don't use the shortcut if
1581 bidi-iterating.
1582 (back_to_previous_visible_line_start): If handle_display_prop
1583 pushed the iterator stack, restore the internal state of the bidi
1584 iterator by calling bidi_pop_it same number of times.
1585 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1586 and we are bidi-iterating, don't decrement the iterator position;
1587 instead, set the first_elt flag in the bidi iterator, to produce
1588 the same effect.
1589 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1590 (push_display_prop): xassert that we are iterating a buffer.
1591 (push_it, pop_it): Save and restore paragraph_embedding member.
1592 (handle_single_display_spec, next_overlay_string)
1593 (get_overlay_strings_1, reseat_1, reseat_to_string)
1594 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1595 correctly. Don't assume unibyte strings are not bidi-reordered.
1596 (compute_display_string_pos)
1597 (compute_display_string_end): Fix handling the case of C string.
1598 (push_it, pop_it): Save and restore from_disp_prop_p.
1599 (handle_single_display_spec, push_display_prop): Set the
1600 from_disp_prop_p flag.
1601 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1602 (pop_it): Call iterate_out_of_display_property only if we are
1603 popping after iteration over a string that came from a display
1604 property. Fix a typo in popping stretch info. Add an assertion
1605 for verifying that the iterator position is in sync with the bidi
1606 iterator.
1607 (handle_single_display_spec, get_overlay_strings_1)
1608 (push_display_prop): Fix initialization of paragraph direction for
1609 string when that of the parent object is not yet determined.
1610 (reseat_1): Call bidi_init_it to resync the bidi
1611 iterator with IT's position. (Bug#7616)
1612 (find_row_edges): If ROW->start.pos gives position
1613 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1614 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1615 Reset the from_disp_prop_p flag.
1616 (SAVE_IT, RESTORE_IT): New macros.
1617 (pos_visible_p, face_before_or_after_it_pos)
1618 (back_to_previous_visible_line_start)
1619 (move_it_in_display_line_to, move_it_in_display_line)
1620 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1621 (try_scrolling, redisplay_window, display_line): Use them when
1622 saving a temporary copy of the iterator and restoring it back.
1623 (back_to_previous_visible_line_start, reseat_1)
1624 (init_iterator): Empty the bidi cache "stack".
1625 (move_it_in_display_line_to): If iterator ended up at
1626 EOL, but we never saw any buffer positions smaller than
1627 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1628 motion in bidi-reordered lines.
1629 (move_it_in_display_line_to): Record prev_method and prev_pos
1630 immediately before the call to set_iterator_to_next. Fixes cursor
1631 motion in bidi-reordered lines with stretch glyphs and strings
1632 displayed in margins. (Bug#8133) (Bug#8867)
1633 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1634 TO_CHARPOS.
1635 (pos_visible_p): Support positions in bidi-reordered lines.
1636 Save and restore bidi cache.
1637
1638 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1639 (bidi_paragraph_info): Delete unused struct.
1640 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1641 (bidi_cache_start): New variable.
1642 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1643 to zero.
1644 (bidi_cache_fetch_state, bidi_cache_search)
1645 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1646 (bidi_cache_find, bidi_peek_at_next_level)
1647 (bidi_level_of_next_char, bidi_find_other_level_edge)
1648 (bidi_move_to_visually_next): Compare cache index with
1649 bidi_cache_start rather than with zero.
1650 (bidi_fetch_char): Accept new argument STRING; all callers
1651 changed. Support iteration over a string. Support strings with
1652 display properties. Support unibyte strings. Fix the type of
1653 `len' according to what STRING_CHAR_AND_LENGTH expects.
1654 (bidi_paragraph_init, bidi_resolve_explicit_1)
1655 (bidi_resolve_explicit, bidi_resolve_weak)
1656 (bidi_level_of_next_char, bidi_move_to_visually_next):
1657 Support iteration over a string.
1658 (bidi_set_sor_type, bidi_resolve_explicit_1)
1659 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1660 can now be zero (for strings); special values 0 and -1 were
1661 changed to -1 and -2, respectively.
1662 (bidi_char_at_pos): New function.
1663 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1664 Call it instead of FETCH_MULTIBYTE_CHAR.
1665 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1666 initialized to valid values.
1667 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1668 values.
1669 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1670 the test for valid cached positions. Fix the logic for looking up
1671 the sentinel state in the cache. GCPRO the Lisp string we are
1672 iterating.
1673 (bidi_push_it, bidi_pop_it): New functions.
1674 (bidi_initialize): Initialize the bidi cache start stack pointer.
1675 (bidi_cache_ensure_space): New function, refactored from part of
1676 bidi_cache_iterator_state. Don't assume the required size is just
1677 one BIDI_CACHE_CHUNK away.
1678 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1679 (bidi_count_bytes, bidi_char_at_pos): New functions.
1680 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1681 always valid if bidi_cache_idx is valid.
1682 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1683 is valid if it's going to be used.
1684 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1685 (bidi_cache_fetch_state, bidi_cache_search)
1686 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1687 (bidi_cache_iterator_state, bidi_cache_find)
1688 (bidi_find_other_level_edge, bidi_cache_start_stack):
1689 All variables related to cache indices are now EMACS_INT.
1690
1691 * dispextern.h (struct bidi_string_data): New structure.
1692 (struct bidi_it): New member `string'. Make flag members be 1-bit
1693 fields, and put them last in the struct.
1694 (compute_display_string_pos, compute_display_string_end):
1695 Update prototypes.
1696 (bidi_push_it, bidi_pop_it): Add prototypes.
1697 (struct iterator_stack_entry): New members bidi_p,
1698 paragraph_embedding, and from_disp_prop_p.
1699 (struct it): Member bidi_p is now a bit field 1 bit wide.
1700 (bidi_shelve_cache, bidi_unshelve_cache):
1701 Declare prototypes.
1702
1703 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1704 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1705 and vector-like objects.
1706
1707 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1708 cache around display iteration.
1709
1710 * window.c (Fwindow_end, window_scroll_pixel_based)
1711 (displayed_window_lines, Frecenter): Save and restore the bidi
1712 cache around display iteration.
1713
1714 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1715
1716 * editfns.c (Fdelete_region): Clarify the use of the named
1717 parameters (bug#6788).
1718
1719 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1720
1721 * indent.c (Fvertical_motion): Set and restore w->pointm when
1722 saving and restoring the window's buffer (Bug#9006).
1723
1724 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1725
1726 * editfns.c (Fstring_to_char): Clarify just what is returned
1727 (bug#6576). Text by Eli Zaretskii.
1728
1729 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1730
1731 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1732
1733 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1734
1735 * buffer.c (mmap_find): Fix a typo.
1736
1737 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1738
1739 Fix execution of x selection hooks.
1740 * xselect.c (Qx_lost_selection_functions)
1741 (Qx_sent_selection_functions): New vars.
1742 (syms_of_xselect): DEFSYM them.
1743 (x_handle_selection_request): Pass Qx_sent_selection_functions
1744 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1745 (x_handle_selection_clear,x_clear_frame_selections):
1746 Pass Qx_lost_selection_functions rather than
1747 Vx_lost_selection_functions to Frun_hook_with_args.
1748
1749 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1750
1751 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1752 The old code sometimes used this field without initializing it.
1753
1754 * alloc.c (gc_sweep): Don't read past end of array.
1755 In theory, the old code could also have corrupted Emacs internals,
1756 though it'd be very unlikely.
1757
1758 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1759
1760 * character.c (Fcharacterp): Don't advertise optional ignored
1761 argument. (Bug#4026)
1762
1763 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1764
1765 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1766 key" (bug#4257).
1767
1768 * window.c (Fset_window_start): Doc fix (bug#4199).
1769 (Fset_window_hscroll): Ditto.
1770
1771 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 Fix minor new problems caught by GCC 4.6.1.
1774 * term.c (init_tty): Remove unused local.
1775 * xsettings.c (store_monospaced_changed): Define this function only
1776 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1777 not used otherwise.
1778
1779 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1780
1781 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1782
1783 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1784
1785 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1786 are the mini-buffer and the echo area (bug#3320).
1787
1788 * term.c (init_tty): Remove support for supdup, c10 and perq
1789 terminals, which are no longer supported (bug#1482).
1790
1791 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1792
1793 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1794
1795 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1796
1797 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1798 for non-popups (Bug#3642).
1799
1800 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1801
1802 * alloc.c (reset_malloc_hooks): Protoize.
1803 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1804 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1805 * cm.c (losecursor): Likewise.
1806 * data.c (fmod): Likewise.
1807 * dispnew.c (swap_glyphs_in_rows): Likewise.
1808 * emacs.c (memory_warning_signal): Likewise.
1809 * floatfns.c (float_error): Likewise.
1810 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1811 (otf_open, font_otf_capability, generate_otf_features)
1812 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1813 Likewise.
1814 * image.c (pbm_read_file): Likewise.
1815 * indent.c (string_display_width): Likewise.
1816 * intervals.c (check_for_interval, search_for_interval)
1817 (inc_interval_count, count_intervals, root_interval)
1818 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1819 * lread.c (defalias): Likewise.
1820 * ralloc.c (r_alloc_check): Likewise.
1821 * regex.c (set_image_of_range_1, set_image_of_range)
1822 (regex_grow_registers): Likewise.
1823 * sysdep.c (strerror): Likewise.
1824 * termcap.c (valid_filename_p, tprint, main): Likewise.
1825 * tparam.c (main): Likewise.
1826 * unexhp9k800.c (run_time_remap, save_data_space)
1827 (update_file_ptrs, read_header, write_header, calculate_checksum)
1828 (copy_file, copy_rest, display_header): Likewise.
1829 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1830 Likewise.
1831 * xdisp.c (check_it): Likewise.
1832 * xfaces.c (register_color, unregister_color, unregister_colors):
1833 Likewise.
1834 * xfns.c (print_fontset_result): Likewise.
1835 * xrdb.c (member, fatal, main): Likewise.
1836
1837 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1838
1839 Fix minor problems found by static checking (Bug#9031).
1840 * chartab.c (char_table_set_range, map_sub_char_table):
1841 Remove unused locals.
1842 (uniprop_table): Now static.
1843 * composite.c (_work_char): Remove unused static var.
1844
1845 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1846
1847 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1848
1849 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1850
1851 * gtkutil.c (qttip_cb): Remove code without function.
1852
1853 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1854
1855 * w32.c (pthread_sigmask): New stub.
1856
1857 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 Use pthread_sigmask, not sigprocmask (Bug#9010).
1860 sigprocmask is portable only for single-threaded applications, and
1861 Emacs can be multi-threaded when it uses GTK.
1862 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1863 (LIBES): Use it.
1864 * callproc.c (Fcall_process):
1865 * process.c (create_process):
1866 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1867 Use pthread_sigmask, not sigprocmask.
1868
1869 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1870
1871 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1872 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1873 wrong (Bug#8591).
1874
1875 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1876
1877 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1878 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1879 (xg_hide_tooltip): Fix comment.
1880
1881 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1882 in registerServicesMenuSendTypes.
1883 (validRequestorForSendType): Don't check ns_return_types.
1884
1885 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1886 ns_return_type.
1887
1888 2011-07-08 Jason Rumney <jasonr@gnu.org>
1889
1890 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1891 frame struct members of non-existent frames (Bug#6284).
1892
1893 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1894
1895 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1896 variable firstTime not needed on OSX >= 10.6.
1897 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1898 >= 10.5. Use setKnobProportion, setDoubleValue.
1899
1900 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1901 (MAC_OS_X_VERSION_10_5): Define if not defined.
1902 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1903 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1904 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1905
1906 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1907 cString and lossyCString on OSX >= 10.4
1908
1909 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1910 sizeToFit on OSX >= 10.2.
1911
1912 * nsimage.m (allocInitFromFile): Don't use deprecated method
1913 bestRepresentationForDevice on OSX >= 10.6.
1914
1915 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1916 to avoid warning.
1917
1918 * emacs.c: Declare unexec_init_emacs_zone.
1919
1920 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1921
1922 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1923
1924 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1925 on svcsMenu (Bug#8842).
1926
1927 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1928 ns_return_types.
1929 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1930
1931 * nsterm.m (QUTF8_STRING): Declare.
1932 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1933 (validRequestorForSendType): Return type is (id).
1934 Change indexOfObjectIdenticalTo to indexOfObject.
1935 Check if we have local selection before returning self (Bug#8842).
1936 (writeSelectionToPasteboard): Put local selection into paste board
1937 if we have a local selection (Bug#8842).
1938 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1939
1940 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1941 (ns_get_local_selection): Declare.
1942
1943 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1944
1945 * keymap.c (describe_map_tree): Don't insert a double newline at
1946 the end of the buffer (bug#1169) and return whether we inserted
1947 something.
1948
1949 * callint.c (Fcall_interactively): Change "reading args" to
1950 "providing args" to try to clarify what it does (bug#1010).
1951
1952 2011-07-07 Kenichi Handa <handa@m17n.org>
1953
1954 * composite.c (composition_compute_stop_pos): Ignore a static
1955 composition starting before CHARPOS (Bug#8915).
1956
1957 * xdisp.c (handle_composition_prop): Likewise.
1958
1959 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1960
1961 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1962 (Bug#9015)
1963
1964 2011-07-07 Kenichi Handa <handa@m17n.org>
1965
1966 * character.h (unicode_category_t): New enum type.
1967
1968 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1969 (Qchar_code_property_table): New variable.
1970 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1971 (UNIPROP_COMPRESSED_FORM_P): New macros.
1972 (char_table_ascii): Uncompress the compressed values.
1973 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1974 Uncompress the compressed values.
1975 (sub_char_table_ref_and_range): Likewise.
1976 (char_table_ref_and_range): Uncompress the compressed values.
1977 (sub_char_table_set): New arg is_uniprop. Callers changed.
1978 Uncompress the compressed values.
1979 (sub_char_table_set_range): Args changed. Callers changed.
1980 (char_table_set_range): Adjuted for the above change.
1981 (map_sub_char_table): Delete args default_val and parent. Add arg
1982 top. Give decoded values to a Lisp function.
1983 (map_char_table): Adjust for the above change. Give decoded
1984 values to a Lisp function. Gcpro more variables.
1985 (uniprop_table_uncompress)
1986 (uniprop_decode_value_run_length): New functions.
1987 (uniprop_decoder, uniprop_decoder_count): New variables.
1988 (uniprop_get_decoder, uniprop_encode_value_character)
1989 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1990 New functions.
1991 (uniprop_encoder, uniprop_encoder_count): New variables.
1992 (uniprop_get_encoder, uniprop_table)
1993 (Funicode_property_table_internal, Fget_unicode_property_internal)
1994 (Fput_unicode_property_internal): New functions.
1995 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1996 Sunicode_property_table_internal, Sget_unicode_property_internal,
1997 and Sput_unicode_property_internal. Defvar_lisp
1998 char-code-property-alist.
1999
2000 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2001 Vunicode_category_table.
2002
2003 * font.c (font_range): Adjust for the change of
2004 Vunicode_category_table.
2005
2006 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2007
2008 * m/iris4d.h: Remove file, move contents ...
2009 * s/irix6-5.h: ... here.
2010
2011 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2012
2013 Remove unportable assumption about struct layout (Bug#8884).
2014 * alloc.c (mark_buffer):
2015 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2016 (clone_per_buffer_values): Don't assume that
2017 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2018 This isn't true in general, and it's particularly not true
2019 if Emacs is configured with --with-wide-int.
2020 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2021 New macros, used in the buffer.c change.
2022
2023 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2024
2025 * xsettings.c: Use both GConf and GSettings if both are available.
2026 (store_config_changed_event): Add comment.
2027 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2028 (store_tool_bar_style_changed): New functions.
2029 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2030 (struct xsettings): Move font inside HAVE_XFT.
2031 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2032 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2033 Move inside HAVE_XFT.
2034 (something_changed_gsettingsCB): Rename from something_changedCB.
2035 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2036 also.
2037 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2038 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2039 (something_changed_gconfCB): Rename from something_changedCB.
2040 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2041 (parse_settings): Move check for font inside HAVE_XFT.
2042 (read_settings, apply_xft_settings): Add comment.
2043 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2044 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2045 call store_font_name_changed.
2046 (xft_settings_event): Add comment.
2047 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2048 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2049 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2050 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2051 (xsettings_initialize): Call init_gsettings last.
2052 (xsettings_get_system_font, xsettings_get_system_normal_font):
2053 Add comment.
2054
2055 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2056
2057 Random fixes. E.g., (random) never returned negative values.
2058 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2059 subseconds part to the entropy, as that's a bit more random.
2060 Prefer signed to unsigned, since the signedness doesn't matter and
2061 in general we prefer signed. When given a limit, use a
2062 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2063 latter isn't right if USE_2_TAGS_FOR_INTS.
2064 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2065 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2066
2067 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2068
2069 * textprop.c (text_property_stickiness):
2070 Obey Vtext_property_default_nonsticky.
2071 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2072 * w32fns.c (syms_of_w32fns):
2073 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2074
2075 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2078 This is more efficient than Ffile_directory_p and avoids a minor race.
2079
2080 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2081
2082 * buffer.c (Foverlay_put): Say what the return value is
2083 (bug#7835).
2084
2085 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2086 is a directory before asking whether to use the file name
2087 (bug#7564).
2088 (barf_or_query_if_file_exists): Make the "File is a directory"
2089 error be more correct.
2090
2091 * fns.c (Frequire): Remove the mention of the .gz files, since
2092 that's installation-specific, but keep the mention of
2093 `get-load-suffixes'.
2094
2095 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2096
2097 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2098 Report string overflow if the output is too long.
2099
2100 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2101
2102 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2103 (syms_of_gnutls): Remove duplicate DEFSYM for
2104 Qgnutls_bootprop_verify_hostname_error, an error for
2105 Qgnutls_bootprop_verify_error (which is no longer used).
2106
2107 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2108 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2109 Also (re)move comments that are misplaced or no longer relevant.
2110
2111 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2112
2113 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2114
2115 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2116
2117 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2118 and background color parameters if they have been changed.
2119
2120 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2121
2122 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2123
2124 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2125
2126 * xsettings.c (SYSTEM_FONT): Define only when used.
2127 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2128
2129 * keymap.c (access_keymap_1): Now static.
2130
2131 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2132
2133 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2134 leave any prefix arg for the up event (Bug#1586).
2135
2136 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2137
2138 * lread.c (syms_of_lread): Mention single symbols defined by
2139 `defvar' or `defconst' (bug#7154).
2140
2141 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2142 (Frequire): Mention get-load-suffixes.
2143
2144 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2145
2146 * window.h (window): Remove clone_number slot.
2147 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2148 Remove.
2149 (make_parent_window, make_window, saved_window)
2150 (Fset_window_configuration, save_window_save): Don't deal with
2151 clone numbers.
2152 * buffer.c (Qclone_number): Remove declaration.
2153 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2154
2155 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2156
2157 Add multiple inheritance to keymaps.
2158 * keymap.c (Fmake_composed_keymap): New function.
2159 (Fset_keymap_parent): Simplify.
2160 (fix_submap_inheritance): Remove.
2161 (access_keymap_1): New function extracted from access_keymap to handle
2162 embedded parents and handle lists of maps.
2163 (access_keymap): Use it.
2164 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2165 (Fcopy_keymap): Handle embedded parents.
2166 (Fcommand_remapping, define_as_prefix): Simplify.
2167 (Fkey_binding): Simplify.
2168 (syms_of_keymap): Move minibuffer-local-completion-map,
2169 minibuffer-local-filename-completion-map,
2170 minibuffer-local-must-match-map, and
2171 minibuffer-local-filename-must-match-map to Elisp.
2172 (syms_of_keymap): Defsubr make-composed-keymap.
2173 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2174 (parse_menu_item): Trivial simplification.
2175
2176 2011-07-01 Glenn Morris <rgm@gnu.org>
2177
2178 * Makefile.in (SETTINGS_LIBS): Fix typo.
2179
2180 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2181
2182 * coding.c (Fencode_coding_string): Record the last coding system
2183 used, as the function doc string says (bug#8738).
2184
2185 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2186
2187 * xsettings.c (store_monospaced_changed): Take new font as arg and
2188 check for change against current_mono_font.
2189 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2190 (emacs_settings_constructor, emacs_settings_get_property)
2191 (emacs_settings_set_property, emacs_settings_class_init)
2192 (emacs_settings_init, gsettings_obj): Remove.
2193 (something_changedCB): New function for HAVE_GSETTINGS.
2194 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2195 with value as argument.
2196 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2197 g_settings_new (Bug#8967). Do not create gsettings_obj.
2198 Remove calls to g_settings_bind. Connect something_changedCB to
2199 "changed".
2200
2201 * xgselect.c: Add defined (HAVE_GSETTINGS).
2202 (xgselect_initialize): Ditto.
2203
2204 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2205 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2206 xg_select.
2207
2208 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2209
2210 * eval.c (struct backtrace): Simplify and port the data structure.
2211 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2212 signed bit field, as this assumption is not portable and it makes
2213 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2214 "char debug_on_exit : 1" as this is not portable either; instead,
2215 use the portable "unsigned int debug_on_exit : 1". Remove unused
2216 member evalargs. Remove obsolete comments about cc bombing out.
2217
2218 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2219
2220 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2221 Let HAVE_GSETTINGS override HAVE_GCONF.
2222 (store_monospaced_changed): New function.
2223 (EMACS_SETTINGS): A new type derived from GObject to handle
2224 GSettings notifications.
2225 (emacs_settings_constructor, emacs_settings_get_property)
2226 (emacs_settings_set_property, emacs_settings_class_init):
2227 New functions.
2228 (gsettings_client, gsettings_obj): New variables.
2229 (GSETTINGS_SCHEMA): New define.
2230 (something_changedCB): Call store_monospaced_changed.
2231 (init_gsettings): New function.
2232 (xsettings_initialize): Call init_gsettings.
2233 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2234 to NULL.
2235
2236 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2237 GCONF_CFLAGS/LIBS.
2238
2239 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2240
2241 * window.c (resize_root_window, grow_mini_window)
2242 (shrink_mini_window): Rename Qresize_root_window to
2243 Qwindow_resize_root_window and Qresize_root_window_vertically to
2244 Qwindow_resize_root_window_vertically.
2245
2246 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2247
2248 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2249
2250 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2251
2252 * makefile.w32-in: Redesign dependencies so they reflect more
2253 clearly which files are directly included by each source file,
2254 and not through other includes.
2255
2256 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2257
2258 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2259 (sort_overlays, overlay_strings): When an overlay's clone number
2260 matches the window's clone number process the overlay even if
2261 the overlay's window property doesn't match the current window.
2262
2263 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2264 (Fwindow_hchild): Rename to Fwindow_left_child.
2265 (Fwindow_next): Rename to Fwindow_next_sibling.
2266 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2267 (resize_window_check): Rename to window_resize_check.
2268 (resize_window_apply): Rename to window_resize_apply.
2269 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2270 (Fdelete_other_windows_internal, resize_frame_windows)
2271 (Fsplit_window_internal, Fdelete_window_internal)
2272 (grow_mini_window, shrink_mini_window)
2273 (Fresize_mini_window_internal): Fix callers accordingly.
2274
2275 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2276
2277 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2278 (emacs_fixed_set_min_size): Remove.
2279 (emacs_fixed_new): Take frame as argument.
2280
2281 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2282 (_EmacsFixedPrivate): Remove minwidth/height.
2283 Add struct frame *f.
2284 (emacs_fixed_init): Initialize priv->f.
2285 (get_parent_class, emacs_fixed_set_min_size): Remove.
2286 (emacs_fixed_new): Set priv->f to argument.
2287 (emacs_fixed_get_preferred_width)
2288 (emacs_fixed_get_preferred_height): Use min_width/height from
2289 frames size_hint to set minimum and natural (Bug#8919).
2290 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2291 and use min_width/height from frames size_hint to set
2292 min_width/height (Bug#8919).
2293
2294 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2295 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2296 Fix indentation.
2297
2298 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2299
2300 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2301 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2302 called at ZV.
2303
2304 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2305
2306 * process.c (wait_reading_process_output): Bypass select if
2307 waiting for a cell while ignoring keyboard input, and input is
2308 pending. Suggested by Jan Djärv (Bug#8869).
2309
2310 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 Use gnulib's dup2 module instead of rolling our own.
2313 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2314
2315 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2316
2317 * dispnew.c (scrolling_window): Before scrolling, turn off a
2318 mouse-highlight in the window being scrolled.
2319
2320 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2321
2322 Move DEFSYM to lisp.h and use everywhere.
2323
2324 * character.h (DEFSYM): Move declaration...
2325 * lisp.h (DEFSYM): ...here.
2326
2327 * gnutls.c:
2328 * minibuf.c:
2329 * w32menu.c:
2330 * w32proc.c:
2331 * w32select.c: Don't include character.h.
2332
2333 * alloc.c (syms_of_alloc):
2334 * buffer.c (syms_of_buffer):
2335 * bytecode.c (syms_of_bytecode):
2336 * callint.c (syms_of_callint):
2337 * casefiddle.c (syms_of_casefiddle):
2338 * casetab.c (init_casetab_once):
2339 * category.c (init_category_once, syms_of_category):
2340 * ccl.c (syms_of_ccl):
2341 * cmds.c (syms_of_cmds):
2342 * composite.c (syms_of_composite):
2343 * dbusbind.c (syms_of_dbusbind):
2344 * dired.c (syms_of_dired):
2345 * dispnew.c (syms_of_display):
2346 * doc.c (syms_of_doc):
2347 * editfns.c (syms_of_editfns):
2348 * emacs.c (syms_of_emacs):
2349 * eval.c (syms_of_eval):
2350 * fileio.c (syms_of_fileio):
2351 * fns.c (syms_of_fns):
2352 * frame.c (syms_of_frame):
2353 * fringe.c (syms_of_fringe):
2354 * insdel.c (syms_of_insdel):
2355 * keymap.c (syms_of_keymap):
2356 * lread.c (init_obarray, syms_of_lread):
2357 * macros.c (syms_of_macros):
2358 * msdos.c (syms_of_msdos):
2359 * print.c (syms_of_print):
2360 * process.c (syms_of_process):
2361 * search.c (syms_of_search):
2362 * sound.c (syms_of_sound):
2363 * syntax.c (init_syntax_once, syms_of_syntax):
2364 * terminal.c (syms_of_terminal):
2365 * textprop.c (syms_of_textprop):
2366 * undo.c (syms_of_undo):
2367 * w32.c (globals_of_w32):
2368 * window.c (syms_of_window):
2369 * xdisp.c (syms_of_xdisp):
2370 * xfaces.c (syms_of_xfaces):
2371 * xfns.c (syms_of_xfns):
2372 * xmenu.c (syms_of_xmenu):
2373 * xsettings.c (syms_of_xsettings):
2374 * xterm.c (syms_of_xterm): Use DEFSYM.
2375
2376 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2377
2378 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2379
2380 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2381
2382 Integer and buffer overflow fixes (Bug#8873).
2383
2384 * print.c (printchar, strout): Check for string overflow.
2385 (PRINTPREPARE, printchar, strout):
2386 Don't set size unless allocation succeeds.
2387
2388 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2389 for sizes. Check for string overflow more accurately.
2390 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2391
2392 * macros.c: Integer and buffer overflow fixes.
2393 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2394 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2395 Use ptrdiff_t, not int, for sizes.
2396 Don't increment bufsize until after realloc succeeds.
2397 Check for size-calculation overflow.
2398 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2399
2400 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2401
2402 * lread.c: Integer overflow fixes.
2403 (read_integer): Radix is now EMACS_INT, not int,
2404 to improve quality of diagnostics for out-of-range radices.
2405 Calculate buffer size correctly for out-of-range radices.
2406 (read1): Check for integer overflow in radices, and in
2407 read-circle numbers.
2408 (read_escape): Avoid int overflow.
2409 (Fload, openp, read_buffer_size, read1)
2410 (substitute_object_recurse, read_vector, read_list, map_obarray):
2411 Use ptrdiff_t, not int, for sizes.
2412 (read1): Use EMACS_INT, not int, for sizes.
2413 Check for size overflow.
2414
2415 * image.c (cache_image): Check for size arithmetic overflow.
2416
2417 * lread.c: Integer overflow issues.
2418 (saved_doc_string_size, saved_doc_string_length)
2419 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2420 Now ptrdiff_t, not int.
2421 (read1): Don't assume doc string length fits in int. Check for
2422 out-of-range doc string lengths.
2423 (read_list): Don't assume file position fits in int.
2424 (read_escape): Check for hex character overflow.
2425
2426 2011-06-22 Leo Liu <sdl.web@gmail.com>
2427
2428 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2429 Move to minibuffer.el.
2430
2431 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2432
2433 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2434 The following patches are for when GLYPH_DEBUG && !XASSERT.
2435 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2436 * dispnew.c (flush_stdout):
2437 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2438 Mark as externally visible.
2439 * dispnew.c (check_window_matrix_pointers): Now static.
2440 * dispnew.c (window_to_frame_vpos):
2441 * xfns.c (unwind_create_frame):
2442 * xterm.c (x_check_font): Remove unused local.
2443 * scroll.c (CHECK_BOUNDS):
2444 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2445 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2446 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2447 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2448 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2449 Now static.
2450 (debug_method_add): Use va_list and vsprintf rather than relying
2451 on undefined behavior with wrong number of arguments.
2452 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2453 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2454 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2455 since we're not interested in debugging glyphs with old libraries.
2456 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2457 GCC 4.6.0's static checking.
2458
2459 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2460
2461 Integer overflow and signedness fixes (Bug#8873).
2462 A few related buffer overrun fixes, too.
2463
2464 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2465
2466 * dispextern.h (struct face.stipple):
2467 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2468 (x_bitmap_mask, x_allocate_bitmap_record)
2469 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2470 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2471 (x_create_bitmap_from_xpm_data):
2472 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2473 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2474 (.bitmaps_last):
2475 * xfaces.c (load_pixmap):
2476 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2477 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2478 (.bitmaps_last, struct x_output.icon_bitmap):
2479 Use ptrdiff_t, not int, for bitmap indexes.
2480 (x_allocate_bitmap_record): Check for size overflow.
2481 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2482
2483 Use ptrdiff_t, not int, for overlay counts.
2484 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2485 * editfns.c (overlays_around, get_pos_property):
2486 * textprop.c (get_char_property_and_overlay):
2487 * xdisp.c (next_overlay_change, note_mouse_highlight):
2488 * xfaces.c (face_at_buffer_position):
2489 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2490 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2491 (Fnext_overlay_change, Fprevious_overlay_change)
2492 (mouse_face_overlay_overlaps, Foverlays_in):
2493 Use ptrdiff_t, not int, for sizes.
2494 (overlays_at, overlays_in): Check for size-calculation overflow.
2495
2496 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2497
2498 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2499 (x_session_initialize): Do not assume string length fits in int.
2500
2501 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2502 This is unlikely, but can occur if DPI is outlandish.
2503
2504 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2505 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2506
2507 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2508 * xrdb.c (magic_file_p, search_magic_path):
2509 Omit last arg SUFFIX; it was always 0. All callers changed.
2510 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2511
2512 * xfont.c (xfont_match): Avoid need for strlen.
2513
2514 * xfns.c: Don't assume strlen fits in int.
2515 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2516
2517 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2518 not unsigned long, as we prefer signed integers. All callers changed.
2519 Detect integer overflow in repeat count.
2520 (message_dolog): Don't assume print length fits in 39 bytes.
2521 (display_mode_element): Don't assume strlen fits in int.
2522
2523 * termcap.c: Don't assume sizes fit in int and never overflow.
2524 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2525 (gobble_line): Check for size-calculation overflow.
2526
2527 * minibuf.c (Fread_buffer):
2528 * lread.c (intern, intern_c_string):
2529 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2530 Don't assume string length fits in int.
2531
2532 * keyboard.c (parse_tool_bar_item):
2533 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2534
2535 * font.c: Don't assume string length fits in int.
2536 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2537 Use ptrdiff_t, not int.
2538 (font_intern_prop): Don't assume string length fits in int.
2539 Don't assume integer property fits in fixnum.
2540 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2541
2542 * filelock.c: Fix some buffer overrun and integer overflow issues.
2543 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2544 Reformulate so as not to need the command string.
2545 Invoke gzip -cd rather than gunzip, as it's more portable.
2546 (lock_info_type, lock_file_1, lock_file):
2547 Don't assume pid_t and time_t fit in unsigned long.
2548 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2549 (current_lock_owner): Prefer signed type for sizes.
2550 Use memcpy, not strncpy, where memcpy is what is really wanted.
2551 Don't assume (via atoi) that time_t and pid_t fit in int.
2552 Check for time_t and/or pid_t out of range, e.g., via a network share.
2553 Don't alloca where an auto var works fine.
2554
2555 * fileio.c: Fix some integer overflow issues.
2556 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2557 Don't assume string length fits in int.
2558 (directory_file_name): Don't assume string length fits in long.
2559 (make_temp_name): Don't assume pid fits in int, or that its print
2560 length is less than 20.
2561
2562 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2563
2564 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2565
2566 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2567
2568 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2569 We prefer signed integers, even for size calculations.
2570
2571 * emacs.c: Don't assume string length fits in 'int'.
2572 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2573 (main): Don't invoke strlen when not needed.
2574
2575 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2576 (XD_DEBUG_MESSAGE): Don't waste a byte.
2577
2578 * callproc.c (getenv_internal_1, getenv_internal)
2579 (Fgetenv_internal):
2580 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2581
2582 * lread.c (invalid_syntax): Omit length argument.
2583 All uses changed. This doesn't fix a bug, but it simplifies the
2584 code away from its former Hollerith-constant appearance, and it's
2585 one less 'int' to worry about when looking at integer-overflow issues.
2586 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2587
2588 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2589 This didn't break anything, but it didn't help either.
2590 It's confusing to put a bogus integer in a place where the actual
2591 value does not matter.
2592 (LIST_END_P): Remove unused macro and its bogus comment.
2593 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2594
2595 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2596 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2597 implementation.
2598 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2599 We prefer signed types, and the value cannot exceed the EMACS_INT
2600 range anyway (because otherwise the length would not be representable).
2601 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2602 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2603 This avoids a GCC warning when WIDE_EMACS_INT.
2604
2605 * indent.c (sane_tab_width): New function.
2606 (current_column, scan_for_column, Findent_to, position_indentation)
2607 (compute_motion): Use it. This is just for clarity.
2608 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2609
2610 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2611
2612 * lisp.h (lint_assume): New macro.
2613 * composite.c (composition_gstring_put_cache):
2614 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2615
2616 * editfns.c, insdel.c:
2617 Omit unnecessary forward decls, to simplify future changes.
2618
2619 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2620
2621 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2622
2623 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2624 Use much-faster test for byte-length change.
2625 Don't assume string byte-length fits in 'int'.
2626 Check that character arg fits in 'int'.
2627 (mapcar1): Declare byte as byte, for clarity.
2628
2629 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2630
2631 * fns.c (concat): Catch string overflow earlier.
2632 Do not rely on integer wraparound.
2633
2634 * dispextern.h (struct it.overlay_strings_charpos)
2635 (struct it.selective): Now EMACS_INT, not int.
2636 * xdisp.c (forward_to_next_line_start)
2637 (back_to_previous_visible_line_start)
2638 (reseat_at_next_visible_line_start, next_element_from_buffer):
2639 Don't arbitrarily truncate the value of 'selective' to int.
2640
2641 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2642
2643 * composite.c: Don't truncate sizes to 'int'.
2644 (composition_gstring_p, composition_reseat_it)
2645 (composition_adjust_point): Use EMACS_INT, not int.
2646 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2647 not EMACS_UINT, for indexes.
2648
2649 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2650
2651 * buffer.c: Include <verify.h>.
2652 (struct sortvec.priority, struct sortstr.priority):
2653 Now EMACS_INT, not int.
2654 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2655 (struct sortstr.size, record_overlay_string)
2656 (struct sortstrlist.size, struct sortlist.used):
2657 Don't truncate size to int.
2658 (record_overlay_string): Check for size-calculation overflow.
2659 (init_buffer_once): Check at compile-time, not run-time.
2660
2661 2011-06-22 Jim Meyering <meyering@redhat.com>
2662
2663 Don't leak an XBM-image-sized buffer
2664 * image.c (xbm_load): Free the image buffer after using it.
2665
2666 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2667
2668 Port to Sun C.
2669 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2670 that Sun C diagnosed.
2671 * fns.c (secure_hash): Fix pointer signedness issue.
2672 * intervals.c (static_offset_intervals): New function.
2673 (offset_intervals): Use it.
2674
2675 2011-06-21 Leo Liu <sdl.web@gmail.com>
2676
2677 * deps.mk (fns.o):
2678 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2679 sha512.h.
2680
2681 * fns.c (secure_hash): Rename from crypto_hash_function and change
2682 the first arg to accept symbols.
2683 (Fsecure_hash): New primitive.
2684 (syms_of_fns): New symbols.
2685
2686 2011-06-20 Deniz Dogan <deniz@dogan.se>
2687
2688 * process.c (Fset_process_buffer): Clarify return value in
2689 docstring.
2690
2691 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2692
2693 * dispnew.c (add_window_display_history): Use BVAR.
2694
2695 * xdisp.c (debug_method_add): Use BVAR.
2696 (check_window_end, dump_glyph_matrix, dump_glyph)
2697 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2698
2699 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2700 Likewise.
2701
2702 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2703 check till after the cache is created in init_frame_faces.
2704
2705 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2706
2707 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2708
2709 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2710
2711 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2712 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2713 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2714
2715 Improve buffer-overflow checking (Bug#8873).
2716 * fileio.c (Finsert_file_contents):
2717 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2718 Remove the old (too-loose) buffer overflow checks.
2719 They weren't needed, since make_gap checks for buffer overflow.
2720 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2721 The old code merely checked for Emacs fixnum overflow, and relied
2722 on undefined (wraparound) behavior. The new code avoids undefined
2723 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2724
2725 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2726 Tune. Don't use wider integers than needed. Don't use alloca.
2727 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2728
2729 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2730
2731 * insdel.c, lisp.h (buffer_overflow): New function.
2732 (insert_from_buffer_1, replace_range, replace_range_2):
2733 * insdel.c (make_gap_larger):
2734 * editfns.c (Finsert_char):
2735 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2736
2737 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2738
2739 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2740
2741 Integer overflow and signedness fixes (Bug#8873).
2742
2743 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2744 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2745
2746 * fileio.c: Don't assume EMACS_INT fits in off_t.
2747 (emacs_lseek): New static function.
2748 (Finsert_file_contents, Fwrite_region): Use it.
2749 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2750
2751 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2752
2753 * fns.c: Don't overflow int when computing a list length.
2754 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2755 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2756 truncation on 64-bit hosts. Check for QUIT every
2757 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2758 faster and is responsive enough.
2759 (Flength): Report an error instead of overflowing an integer.
2760 (Fsafe_length): Return a float if the value is not representable
2761 as a fixnum. This shouldn't happen except in contrived situations.
2762 (Fnthcdr, Fsort): Don't assume list length fits in int.
2763 (Fcopy_sequence): Don't assume vector length fits in int.
2764
2765 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2766 (header_size, word_size): New constants.
2767 (allocate_vectorlike): Don't check size overflow here.
2768 (allocate_vector): Check it here instead, since this is the only
2769 caller of allocate_vectorlike that could cause overflow.
2770 Check that the new vector's length is representable as a fixnum.
2771
2772 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2773 The previous code was bogus. For example, next_almost_prime (32)
2774 returned 39, which is undesirable as it is a multiple of 3; and
2775 next_almost_prime (24) returned 25, which is a multiple of 5 so
2776 why was the code bothering to check for multiples of 7?
2777
2778 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2779
2780 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2781
2782 Variadic C functions now count arguments with ptrdiff_t.
2783 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2784 Back then I didn't know that the Emacs coding style prefers signed int.
2785 Also, in the meantime I found a few more instances where arguments
2786 were being counted with int, which may truncate counts on 64-bit
2787 machines, or EMACS_INT, which may be unnecessarily wide.
2788 * lisp.h (struct Lisp_Subr.function.aMANY)
2789 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2790 Arg counts are now ptrdiff_t, not size_t.
2791 All variadic functions and their callers changed accordingly.
2792 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2793 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2794 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2795 * callint.c (Fcall_interactively): Check arg count for overflow,
2796 to avoid potential buffer overrun. Use signed char, not 'int',
2797 for 'varies' array, so that we needn't bother to check its size
2798 calculation for overflow.
2799 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2800 * eval.c (apply_lambda):
2801 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2802 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2803 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2804
2805 * callint.c (Fcall_interactively): Don't use index var as event count.
2806
2807 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2808 * mem-limits.h (SIZE): Remove; no longer used.
2809
2810 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2811
2812 Remove unnecessary casts.
2813 * xterm.c (x_term_init):
2814 * xfns.c (x_set_border_pixel):
2815 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2816 These aren't needed now that we assume ANSI C.
2817
2818 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2819 It's more likely to cause problems (due to unsigned overflow)
2820 than to cure them.
2821
2822 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2823
2824 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2825
2826 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2827
2828 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2829
2830 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2831
2832 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2833
2834 GLYPH_CODE_FACE returns EMACS_INT, not int.
2835 * dispextern.h (merge_faces):
2836 * xfaces.c (merge_faces):
2837 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2838 Don't assume EMACS_INT fits in int.
2839
2840 * character.h (CHAR_VALID_P): Remove unused parameter.
2841 * fontset.c, lisp.h, xdisp.c: All uses changed.
2842
2843 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2844
2845 * fns.c (concat): Minor tuning based on overflow analysis.
2846 This doesn't fix any bugs. Use int to hold character, instead
2847 of constantly refetching from Emacs object. Use XFASTINT, not
2848 XINT, for value known to be a character. Don't bother comparing
2849 a single byte to 0400, as it's always less.
2850
2851 * floatfns.c (Fexpt):
2852 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2853
2854 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2855 for characters.
2856
2857 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2858
2859 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2860 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2861 incorrectly succeed when S was a string, because 4294967386 was
2862 truncated before it was used.
2863
2864 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2865 Otherwise, an out-of-range integer could cause undefined behavior
2866 on a 64-bit host.
2867
2868 * composite.c: Use int, not EMACS_INT, for characters.
2869 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2870 EMACS_INT, for values that are known to be in character range.
2871 This doesn't fix any bugs but is the usual style inside Emacs and
2872 may generate better code on 32-bit machines.
2873
2874 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2875 This is for reasons similar to the recent CHAR_STRING fix.
2876 * charset.c (Fencode_char): Check that character arg is actually
2877 a character. Pass an int to ENCODE_CHAR.
2878 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2879 wider than 'int', as a compile-time check to prevent future regressions
2880 in this area.
2881
2882 * character.c (char_string): Remove unnecessary casts.
2883
2884 Make sure a 64-bit char is never passed to CHAR_STRING.
2885 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2886 by silently ignoring the top 32 bits, allowing some values
2887 that were far too large to be valid characters.
2888 * character.h: Include <verify.h>.
2889 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2890 arguments are no wider than unsigned, as a compile-time check
2891 to prevent future regressions in this area.
2892 * data.c (Faset):
2893 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2894 (Fsubst_char_in_region):
2895 * fns.c (concat):
2896 * xdisp.c (decode_mode_spec_coding):
2897 Adjust to CHAR_STRING's new requirement.
2898 * editfns.c (Finsert_char, Fsubst_char_in_region):
2899 * fns.c (concat): Check that character args are actually
2900 characters. Without this test, these functions did the wrong
2901 thing with wildly out-of-range values on 64-bit hosts.
2902
2903 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2904 These casts should not be needed on 32-bit hosts, either.
2905 * keyboard.c (read_char):
2906 * lread.c (Fload): Remove casts to unsigned.
2907
2908 * lisp.h (UNSIGNED_CMP): New macro.
2909 This fixes comparison bugs on 64-bit hosts.
2910 (ASCII_CHAR_P): Use it.
2911 * casefiddle.c (casify_object):
2912 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2913 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2914 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2915 * dispextern.h (FACE_FROM_ID):
2916 * keyboard.c (read_char): Use UNSIGNED_CMP.
2917
2918 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2919 not to EMACS_INT, to avoid GCC warning.
2920
2921 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2922
2923 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2924 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2925 isn't needed on 32-bit machines.
2926
2927 * buffer.c (Fgenerate_new_buffer_name):
2928 Use EMACS_INT for count, not int.
2929 (advance_to_char_boundary): Return EMACS_INT, not int.
2930
2931 * data.c (Qcompiled_function): Now static.
2932
2933 * window.c (window_body_lines): Now static.
2934
2935 * image.c (gif_load): Rename local to avoid shadowing.
2936
2937 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2938 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2939 * alloc.c (make_save_value): Integer argument is now of type
2940 ptrdiff_t, not int.
2941 (mark_object): Use ptrdiff_t, not int.
2942 * lisp.h (pD): New macro.
2943 * print.c (print_object): Use it.
2944
2945 * alloc.c: Use EMACS_INT, not int, to count objects.
2946 (total_conses, total_markers, total_symbols, total_vector_size)
2947 (total_free_conses, total_free_markers, total_free_symbols)
2948 (total_free_floats, total_floats, total_free_intervals)
2949 (total_intervals, total_strings, total_free_strings):
2950 Now EMACS_INT, not int. All uses changed.
2951 (Fgarbage_collect): Compute overall total using a double, so that
2952 integer overflow is less likely to be a problem. Check for overflow
2953 when converting back to an integer.
2954 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2955 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2956 These were 'int' variables that could overflow on 64-bit hosts;
2957 they were never used, so remove them instead of repairing them.
2958 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2959 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2960 Previously, this ceilinged at INT_MAX, but that doesn't work on
2961 64-bit machines.
2962 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2963
2964 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2965 (allocate_vectorlike): Check for ptrdiff_t overflow.
2966 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2967 when a (possibly-narrower) signed value would do just as well.
2968 We prefer using signed arithmetic, to avoid comparison confusion.
2969
2970 * alloc.c: Catch some string size overflows that we were missing.
2971 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2972 for convenience in STRING_BYTES_MAX.
2973 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2974 The definition here is exact; the one in lisp.h was approximate.
2975 (allocate_string_data): Check for string overflow. This catches
2976 some instances we weren't catching before. Also, it catches
2977 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2978 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2979 and ptrdiff_t and EMACS_INT are both 64 bits.
2980
2981 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2982 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2983 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2984
2985 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2986
2987 * alloc.c (Fmake_string): Check for out-of-range init.
2988
2989 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2990
2991 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2992
2993 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2994
2995 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2996 xg_get_default_scrollbar_width.
2997
2998 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2999 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3000 (style_changed_cb): Call update_theme_scrollbar_width and call
3001 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3002 all frames (Bug#8505).
3003 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3004 Call gtk_window_set_resizable if HAVE_GTK3.
3005 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3006 and height if HAVE_GTK3 (Bug#8505).
3007 (scroll_bar_width_for_theme): New variable.
3008 (update_theme_scrollbar_width): New function.
3009 (xg_get_default_scrollbar_width): Move code to
3010 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3011 (xg_initialize): Call update_theme_scrollbar_width.
3012
3013 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3014
3015 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3016
3017 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3018
3019 * frame.c (make_frame): Call other_buffer_safely instead of
3020 other_buffer.
3021
3022 * window.c (temp_output_buffer_show): Call display_buffer with
3023 second argument Vtemp_buffer_show_specifiers and reset latter
3024 immediately after the call.
3025 (Vtemp_buffer_show_specifiers): New variable.
3026 (auto_window_vscroll_p, next_screen_context_lines)
3027 (Vscroll_preserve_screen_position): Remove leading asterisks from
3028 doc-strings.
3029
3030 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3031
3032 Fix minor problems found by GCC 4.6.0 static checking.
3033 * buffer.c (Qclone_number): Remove for now, as it's unused.
3034 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3035 (record_buffer): Remove unused local.
3036 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3037 (set_frame_buffer_list): Remove; unused.
3038 * frame.h (other_visible_frames): Remove decl.
3039 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3040 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3041 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3042 if HAVE_GPM.
3043 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3044 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3045 Define only if HAVE_GPM.
3046 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3047 (update_hints_inhibit): Remove; never set. All uses removed.
3048 * widgetprv.h (emacsFrameClassRec): Remove decl.
3049 * window.c (delete_deletable_window): Now returns void, since it
3050 wasn't returning anything.
3051 (compare_window_configurations): Remove unused locals.
3052 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3053 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3054 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3055 the same widths as pointers. This follows up on the 2011-05-06 patch.
3056 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3057 * xterm.h: Likewise.
3058 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3059
3060 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3061
3062 * makefile.w32-in: Update dependencies.
3063 (LISP_H): Add lib/intprops.h.
3064
3065 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3066
3067 * image.c (gif_load): Add animation frame delay to the metadata.
3068 (syms_of_image): Use DEFSYM. New symbol `delay'.
3069
3070 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3071
3072 * window.c (delete_deletable_window): Re-add.
3073 (Fset_window_configuration): Rewrite to handle dead buffers and
3074 consequently deletable windows.
3075 (window_tree, Fwindow_tree): Remove. Supply functionality in
3076 window.el.
3077 (compare_window_configurations): Simplify code.
3078
3079 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3080
3081 * image.c (imagemagick_load_image): Fix type mismatch.
3082 (Fimagemagick_types): Likewise.
3083
3084 * window.h (replace_buffer_in_windows): Declare.
3085
3086 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3087
3088 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3089 Qclone_number. Remove external declaration of Qdelete_window.
3090 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3091 code.
3092 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3093 Run Qbuffer_list_update_hook if allowed.
3094 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3095 buffer list implementation.
3096 (other_buffer_safely): New function.
3097 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3098 calls to replace_buffer_in_windows and
3099 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3100 if allowed.
3101 (record_buffer): Inhibit quitting and rewrite using quittable
3102 functions. Run Qbuffer_list_update_hook if allowed.
3103 (Frecord_buffer, Funrecord_buffer): New functions.
3104 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3105 Move switch-to-buffer to window.el.
3106 (bury-buffer): Move to window.el.
3107 (Vbuffer_list_update_hook): New variable.
3108
3109 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3110 section.
3111
3112 * window.h (resize_frame_windows): Move up in code.
3113 (Fwindow_frame): Remove EXFUN.
3114 (replace_buffer_in_all_windows): Remove prototype.
3115 (replace_buffer_in_windows_safely): Add prototype.
3116
3117 * window.c: Declare Qdelete_window static again. Move down
3118 declaration of select_count.
3119 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3120 (Fother_window): Move to window.el.
3121 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3122 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3123 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3124 window.el.
3125 (replace_buffer_in_windows): Implement by calling
3126 Qreplace_buffer_in_windows.
3127 (replace_buffer_in_all_windows): Remove with some functionality
3128 moved into replace_buffer_in_windows_safely.
3129 (replace_buffer_in_windows_safely): New function.
3130 (select_window_norecord, select_frame_norecord): Move in front
3131 of run_window_configuration_change_hook. Remove now obsolete
3132 declarations.
3133 (Fset_window_buffer): Rewrite doc-string.
3134 Call Qrecord_window_buffer.
3135 (keys_of_window): Move binding for other-window to window.el.
3136
3137 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3138
3139 * dispextern.h (struct image): Replace data member, whose int_val
3140 and ptr_val fields were not used by anything, with a single
3141 lisp_val object.
3142
3143 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3144 (gif_clear_image, gif_load, imagemagick_load_image)
3145 (gs_clear_image, gs_load): Callers changed.
3146
3147 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 * buffer.h: Include <time.h>, for time_t.
3150 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3151
3152 Fix minor problems found by static checking.
3153
3154 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3155
3156 Make identifiers static if they are not used in other modules.
3157 * data.c (Qcompiled_function, Qframe, Qvector):
3158 * image.c (QimageMagick, Qsvg):
3159 * minibuf.c (Qmetadata):
3160 * window.c (resize_window_check, resize_root_window): Now static.
3161 * window.h (resize_window_check, resize_root_window): Remove decls.
3162
3163 * window.c (window_deletion_count, delete_deletable_window):
3164 Remove; unused.
3165 (window_body_lines): Now static.
3166 (Fdelete_other_windows_internal): Mark vars as initialized.
3167 Make sure 'resize_failed' is initialized.
3168 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3169 (resize_window_apply): Remove unused local.
3170 * window.h (delete_deletable_window): Remove decl.
3171
3172 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3173 (imagemagick_load_image): Fix pointer signedness problem by changing
3174 last arg from unsigned char * to char *. All uses changed.
3175 Also, fix a local for similar reasons.
3176 Remove unused locals. Remove locals to avoid shadowing.
3177 (fn_rsvg_handle_free): Remove; unused.
3178 (svg_load, svg_load_image): Fix pointer signedness problem.
3179 (imagemagick_load_image): Don't use garbage pointer image_wand.
3180
3181 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3182
3183 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3184
3185 * image.c (gif_load): Fix omitted cast error introduced by
3186 2011-06-06 change.
3187
3188 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3189
3190 * window.h (resize_proportionally, orig_total_lines)
3191 (orig_top_line): Remove from window structure.
3192 (set_window_height, set_window_width, change_window_heights)
3193 (Fdelete_window): Remove prototypes.
3194 (resize_frame_windows): Remove duplicate declaration.
3195
3196 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3197
3198 * window.h (resize_frame_windows, resize_window_check)
3199 (delete_deletable_window, resize_root_window)
3200 (resize_frame_windows): Declare prototypes.
3201
3202 * window.c (resize_window_apply): Make definition be "static" to
3203 match the prototype.
3204
3205 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3206
3207 * window.c: Remove declarations of Qwindow_size_fixed,
3208 window_min_size_1, window_min_size_2, window_min_size,
3209 size_window, window_fixed_size_p, enlarge_window, delete_window.
3210 Remove static from declaration of Qdelete_window, it's
3211 temporarily needed by Fbury_buffer.
3212 (replace_window): Don't assign orig_top_line and
3213 orig_total_lines.
3214 (Fdelete_window, delete_window): Remove. Window deletion is
3215 handled by window.el.
3216 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3217 Replace Fdelete_window calls with calls to Qdelete_window.
3218 (Fdelete_other_windows): Remove. Deleting other windows is
3219 handled by window.el.
3220 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3221 handled in window.el.
3222 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3223 Window minimum sizes are handled in window.el.
3224 (shrink_windows, size_window, set_window_height)
3225 (set_window_width, change_window_heights, window_height)
3226 (window_width, CURBEG, CURSIZE, enlarge_window)
3227 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3228 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3229 handled in window.el.
3230 (make_dummy_parent): Rename to make_parent_window and give it a
3231 second argument horflag.
3232 (make_window): Don't set resize_proportionally any more.
3233 (Fsplit_window): Remove. Windows are split in window.el.
3234 (save_restore_action, save_restore_orig_size)
3235 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3236 Resize mini windows in window.el.
3237 (grow_mini_window, shrink_mini_window): Implement by calling
3238 Qresize_root_window_vertically, resize_window_check and
3239 resize_window_apply.
3240 (saved_window, Fset_window_configuration, save_window_save):
3241 Do not handle orig_top_line, orig_total_lines, and
3242 resize_proportionally.
3243 (window_min_height, window_min_width): Move to window.el.
3244 (keys_of_window): Move bindings for delete-other-windows,
3245 split-window, delete-window and enlarge-window to window.el.
3246
3247 * buffer.c: Temporarily extern Qdelete_window.
3248 (Fbury_buffer): Temporarily call Qdelete_window instead of
3249 Fdelete_window (Fbury_buffer will move to window.el soon).
3250
3251 * frame.c (set_menu_bar_lines_1): Remove code handling
3252 orig_top_line and orig_total_lines.
3253
3254 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3255 set_window_height but set heights directly.
3256 (change_frame_size_1): Use resize_frame_windows.
3257
3258 * xdisp.c (init_xdisp): Don't use set_window_height but set
3259 heights directly.
3260
3261 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3262 Use resize_frame_windows instead of change_window_heights and run
3263 run_window_configuration_change_hook.
3264
3265 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3266 instead of change_window_heights and run
3267 run_window_configuration_change_hook.
3268
3269 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3270
3271 * window.c (replace_window): Rename second argument REPLACEMENT to
3272 NEW. New third argument SETFLAG. Rewrite.
3273 (delete_window, make_dummy_parent): Call replace_window with
3274 third argument 1.
3275 (window_list_1): Move down in code.
3276 (run_window_configuration_change_hook): Move set_buffer part
3277 before select_frame_norecord part in order to unwind correctly.
3278 Rename count1 to count.
3279 (recombine_windows, delete_deletable_window, resize_root_window)
3280 (Fdelete_other_windows_internal)
3281 (Frun_window_configuration_change_hook, make_parent_window)
3282 (resize_window_check, resize_window_apply, Fresize_window_apply)
3283 (resize_frame_windows, Fsplit_window_internal)
3284 (Fdelete_window_internal, Fresize_mini_window_internal):
3285 New functions.
3286 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3287
3288 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3289
3290 * window.h (window): Add some new members to window structure -
3291 normal_lines, normal_cols, new_total, new_normal, clone_number,
3292 splits, nest, prev_buffers, next_buffers.
3293 (WINDOW_TOTAL_SIZE): Move here from window.c.
3294 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3295
3296 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3297 Remove.
3298 (make_dummy_parent): Set new members of windows structure.
3299 (make_window): Move down in code. Handle new members of window
3300 structure.
3301 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3302 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3303 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3304 (Fset_window_prev_buffers, Fwindow_next_buffers)
3305 (Fset_window_next_buffers, Fset_window_clone_number):
3306 New functions.
3307 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3308 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3309 Doc-string fixes.
3310 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3311 Argument WINDOW can be now internal window too.
3312 (Fwindow_use_time): Move up in code.
3313 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3314 Rewrite doc-string.
3315 (Fset_window_configuration, saved_window)
3316 (Fcurrent_window_configuration, save_window_save): Handle new
3317 members of window structure.
3318 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3319 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3320 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3321 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3322 Qget_mru_window, Qresize_root_window,
3323 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3324 Qauto_buffer_name; staticpro them.
3325
3326 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3327
3328 * window.c (Fwindow_total_size, Fwindow_left_column)
3329 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3330 (Fwindow_list_1): New functions.
3331 (window_box_text_cols): Replace with window_body_cols.
3332 (Fwindow_width, Fscroll_left, Fscroll_right):
3333 Use window_body_cols instead of window_box_text_cols.
3334 (delete_window, Fset_window_configuration):
3335 Call delete_all_subwindows with window as argument.
3336 (delete_all_subwindows): Take a window as argument and not a
3337 structure. Rewrite.
3338 (window_loop): Remove handling of GET_LRU_WINDOW and
3339 GET_LARGEST_WINDOW.
3340 (Fget_lru_window, Fget_largest_window): Move to window.el.
3341
3342 * window.h: Extern window_body_cols instead of
3343 window_box_text_cols. delete_all_subwindows now takes a
3344 Lisp_Object as argument.
3345
3346 * indent.c (compute_motion, Fcompute_motion):
3347 Use window_body_cols instead of window_box_text_cols.
3348
3349 * frame.c (delete_frame): Call delete_all_subwindows with root
3350 window as argument.
3351
3352 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3353
3354 * fns.c (Fputhash): Document return value.
3355
3356 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3357
3358 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3359
3360 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3361
3362 Cons<->int and similar integer overflow fixes (Bug#8794).
3363
3364 Check for overflow when converting integer to cons and back.
3365 * charset.c (Fdefine_charset_internal, Fdecode_char):
3366 Use cons_to_unsigned to catch overflow.
3367 (Fencode_char): Use INTEGER_TO_CONS.
3368 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3369 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3370 * data.c (long_to_cons, cons_to_long): Remove.
3371 (cons_to_unsigned, cons_to_signed): New functions.
3372 These signal an error for invalid or out-of-range values.
3373 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3374 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3375 * font.c (Ffont_variation_glyphs):
3376 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3377 * lisp.h: Include <intprops.h>.
3378 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3379 (cons_to_signed, cons_to_unsigned): New decls.
3380 (long_to_cons, cons_to_long): Remove decls.
3381 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3382 (Fprimitive_undo): Use CONS_TO_INTEGER.
3383 * xfns.c (Fx_window_property): Likewise.
3384 * xselect.c: Include <limits.h>.
3385 (x_own_selection, selection_data_to_lisp_data):
3386 Use INTEGER_TO_CONS.
3387 (x_handle_selection_request, x_handle_selection_clear)
3388 (x_get_foreign_selection, Fx_disown_selection_internal)
3389 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3390 (lisp_data_to_selection_data): Use cons_to_unsigned.
3391 (x_fill_property_data): Use cons_to_signed.
3392 Report values out of range.
3393
3394 Check for buffer and string overflow more precisely.
3395 * buffer.h (BUF_BYTES_MAX): New macro.
3396 * lisp.h (STRING_BYTES_MAX): New macro.
3397 * alloc.c (Fmake_string):
3398 * character.c (string_escape_byte8):
3399 * coding.c (coding_alloc_by_realloc):
3400 * doprnt.c (doprnt):
3401 * editfns.c (Fformat):
3402 * eval.c (verror):
3403 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3404 since they may not be the same number.
3405 * editfns.c (Finsert_char):
3406 * fileio.c (Finsert_file_contents):
3407 Likewise for BUF_BYTES_MAX.
3408
3409 * image.c: Use ptrdiff_t, not int, for sizes.
3410 (slurp_file): Switch from int to ptrdiff_t.
3411 All uses changed.
3412 (slurp_file): Check that file size fits in both size_t (for
3413 malloc) and ptrdiff_t (for sanity and safety).
3414
3415 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3416 if b->modtime has its maximal value.
3417
3418 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3419
3420 Don't assume time_t can fit into int.
3421 * buffer.h (struct buffer.modtime): Now time_t, not int.
3422 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3423 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3424
3425 Minor fixes for signed vs unsigned integers.
3426 * character.h (MAYBE_UNIFY_CHAR):
3427 * charset.c (maybe_unify_char):
3428 * keyboard.c (read_char, reorder_modifiers):
3429 XINT -> XFASTINT, since the integer must be nonnegative.
3430 * ftfont.c (ftfont_spec_pattern):
3431 * keymap.c (access_keymap, silly_event_symbol_error):
3432 XUINT -> XFASTINT, since the integer must be nonnegative.
3433 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3434 since it makes no difference and we prefer signed.
3435 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3436 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3437 nonnegative.
3438
3439 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3440
3441 * window.h (Fwindow_frame): Declare.
3442
3443 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3444
3445 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3446 (SPARE_MEMORY): Always define.
3447 (LARGE_REQUEST): Remove.
3448 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3449
3450 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3451
3452 * lisp.h: Move EXFUNS for Fframe_root_window,
3453 Fframe_first_window and Fset_frame_selected_window to window.h.
3454
3455 * window.h: Move EXFUNS for Fframe_root_window,
3456 Fframe_first_window and Fset_frame_selected_window here from
3457 lisp.h.
3458
3459 * frame.c (Fwindow_frame, Fframe_first_window)
3460 (Fframe_root_window, Fframe_selected_window)
3461 (Fset_frame_selected_window): Move to window.c.
3462 (Factive_minibuffer_window): Move to minibuf.c.
3463 (Fother_visible_frames_p): New function.
3464
3465 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3466
3467 * window.c (decode_window, decode_any_window): Move up in code.
3468 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3469 (inhibit_frame_unsplittable): Remove unused variable.
3470 (Fwindow_buffer): Move up and rewrite doc-string.
3471 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3472 (Fwindow_prev): New functions.
3473 (Fwindow_frame): Move here from frame.c. Accept any window as
3474 argument.
3475 (Fframe_root_window, Fframe_first_window)
3476 (Fframe_selected_window): Move here from frame.c. Accept frame
3477 or arbitrary window as argument. Update doc-strings.
3478 (Fminibuffer_window): Move up in code.
3479 (Fwindow_minibuffer_p): Move up in code and simplify.
3480 (Fset_frame_selected_window): Move here from frame.c.
3481 Marginal rewrite.
3482 (Fselected_window, select_window, Fselect_window): Move up in
3483 code. Minor doc-string fixes.
3484
3485 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3486
3487 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3488 Do not assume that spare memory exists; that assumption is valid
3489 only if SYSTEM_MALLOC.
3490 (LARGE_REQUEST): New macro, so that the issue of large requests
3491 is separated from the issue of spare memory.
3492
3493 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3494
3495 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3496 format. (Bug#8806)
3497
3498 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3499
3500 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3501 before statements.
3502
3503 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3504
3505 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3506
3507 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3508
3509 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3510 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3511
3512 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3513
3514 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3515
3516 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3517
3518 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3519 (x_clipboard_manager_save): Add return value.
3520 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3521 New error handlers.
3522 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3523 Obey Vx_select_enable_clipboard_manager. Catch errors in
3524 x_clipboard_manager_save (Bug#8779).
3525 (Vx_select_enable_clipboard_manager): New variable.
3526 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3527
3528 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3529
3530 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3531
3532 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3533
3534 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3535 in the current matrix if keep_current_p is non-zero.
3536
3537 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3538
3539 * bidi.c (bidi_level_of_next_char): Fix last change.
3540
3541 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3542
3543 Support bidi reordering of text covered by display properties.
3544
3545 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3546 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3547 (bidi_cache_search, bidi_cache_iterator_state)
3548 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3549 (bidi_level_of_next_char, bidi_move_to_visually_next):
3550 Support character positions inside a run of characters covered by a
3551 display string.
3552 (bidi_paragraph_init, bidi_resolve_explicit_1)
3553 (bidi_level_of_next_char): Call bidi_fetch_char and
3554 bidi_fetch_char_advance instead of FETCH_CHAR and
3555 FETCH_CHAR_ADVANCE.
3556 (bidi_init_it): Initialize new members.
3557 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3558 definitions.
3559 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3560 instead of using explicit *_CHAR codes.
3561 (bidi_resolve_explicit, bidi_resolve_weak):
3562 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3563 bidirectional text is supported only in multibyte buffers.
3564 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3565 it to initialize the frame_window_p member of struct bidi_it.
3566 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3567 (bidi_resolve_explicit, bidi_resolve_weak)
3568 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3569 bidi_it->nchars is non-positive.
3570 (bidi_level_of_next_char): Don't try to lookup the cache for the
3571 next/previous character if nothing is cached there yet, or if we
3572 were just reseat()'ed to a new position.
3573
3574 * xdisp.c (set_cursor_from_row): Set start and stop points
3575 according to the row's direction when priming the loop that looks
3576 for the glyph on which to display cursor.
3577 (single_display_spec_intangible_p): Function deleted.
3578 (display_prop_intangible_p): Reimplement to call
3579 handle_display_spec instead of single_display_spec_intangible_p.
3580 Accept 3 additional arguments needed by handle_display_spec.
3581 This fixes incorrect cursor motion across display property with complex
3582 values: lists, `(when COND...)' forms, etc.
3583 (single_display_spec_string_p): Support property values that are
3584 lists with the argument STRING its top-level element.
3585 (display_prop_string_p): Fix the condition for processing a
3586 property that is a list to be consistent with handle_display_spec.
3587 (handle_display_spec): New function, refactored from the
3588 last portion of handle_display_prop.
3589 (compute_display_string_pos): Accept additional argument
3590 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3591 value of a `display' property is a "replacing spec".
3592 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3593 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3594 the display property, but just return a value indicating whether
3595 the display property will replace the characters it covers.
3596 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3597 frame_window_p members of struct bidi_it.
3598 (compute_display_string_pos, compute_display_string_end):
3599 New functions.
3600 (push_it): Accept second argument POSITION, where pop_it should
3601 jump to continue iteration.
3602 (reseat_1): Initialize bidi_it.disp_pos.
3603
3604 * keyboard.c (adjust_point_for_property): Adjust the call to
3605 display_prop_intangible_p to its new signature.
3606
3607 * dispextern.h (struct bidi_it): New member frame_window_p.
3608 (bidi_init_it): Update prototypes.
3609 (display_prop_intangible_p): Update prototype.
3610 (compute_display_string_pos, compute_display_string_end):
3611 Declare prototypes.
3612 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3613 EMACS_INT.
3614
3615 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3616
3617 Malloc failure behavior now depends on size of allocation.
3618 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3619 * lisp.h: Change signatures accordingly.
3620 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3621 All callers changed. (Bug#8762)
3622
3623 * gnutls.c: Use Emacs's memory allocators.
3624 Without this change, the gnutls library would invoke malloc etc.
3625 directly, which causes problems on non-SYNC_INPUT hosts, and which
3626 runs afoul of improving memory_full behavior. (Bug#8761)
3627 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3628 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3629 xfree instead of the default malloc, realloc, free.
3630 (Fgnutls_boot): No need to check for memory allocation failure,
3631 since xmalloc does that for us.
3632
3633 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3634 * category.c (hash_get_category_set):
3635 * ccl.c (ccl_driver):
3636 * charset.c (Fdefine_charset_internal):
3637 * charset.h (struct charset.hash_index):
3638 * composite.c (get_composition_id, gstring_lookup_cache)
3639 (composition_gstring_put_cache):
3640 * composite.h (struct composition.hash_index):
3641 * dispextern.h (struct image.hash):
3642 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3643 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3644 (hashfn_equal, hashfn_user_defined, make_hash_table)
3645 (maybe_resize_hash_table, hash_lookup, hash_put)
3646 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3647 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3648 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3649 * image.c (make_image, search_image_cache, lookup_image)
3650 (xpm_put_color_table_h):
3651 * lisp.h (struct Lisp_Hash_Table):
3652 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3653 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3654 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3655 * alloc.c (allocate_vectorlike):
3656 Check for overflow in vector size calculations.
3657 * ccl.c (ccl_driver):
3658 Check for overflow when converting EMACS_INT to int.
3659 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3660 need to be updated by these changes.
3661 * fns.c (make_hash_table, maybe_resize_hash_table):
3662 Check for integer overflow with large hash tables.
3663 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3664 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3665 (SXHASH_REDUCE): New macro.
3666 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3667 Use it instead of discarding useful hash info with large hash values.
3668 (sxhash_float): New function.
3669 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3670 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3671 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3672 Rewrite to use FIXNUM_BITS, as this simplifies things.
3673 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3674 Adjust signatures to match updated version of code.
3675 (consing_since_gc): Now EMACS_INT, since a single hash table can
3676 use more than INT_MAX bytes.
3677
3678 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3679
3680 Make it possible to build with GCC-4.6+ -O2 -flto.
3681
3682 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3683
3684 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3685
3686 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3687 Call minibuffer-inactive-mode.
3688
3689 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3690
3691 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3692 Update dependencies.
3693
3694 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3695
3696 * data.c (init_data): Remove code for UTS, this system is not
3697 supported anymore.
3698
3699 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3700
3701 Don't force ./temacs to start in terminal mode.
3702
3703 * frame.c (make_initial_frame): Initialize faces in all cases, not
3704 only when CANNOT_DUMP is defined.
3705 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3706
3707 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3708
3709 * dispnew.c (add_window_display_history): Use const for the string
3710 pointer. Remove declaration, not needed.
3711
3712 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3713
3714 Use 'inline', not 'INLINE'.
3715 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3716 * alloc.c, fontset.c (INLINE): Remove.
3717 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3718 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3719 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3720 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3721 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3722
3723 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3724
3725 Make it possible to run ./temacs.
3726
3727 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3728 syms_of_callproc does the same thing. Remove test for
3729 "initialized", do it in the caller.
3730 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3731
3732 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3733
3734 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3735 (read_minibuf): Use get_minibuffer.
3736 (syms_of_minibuf): Use DEFSYM.
3737 (Qmetadata): New var.
3738 * data.c (Qbuffer): Don't make it static.
3739 (syms_of_data): Use DEFSYM.
3740
3741 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3742
3743 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3744 (CCL_CODE_MIN): New macro.
3745
3746 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3747
3748 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3749
3750 * eval.c (Qdebug): Now static.
3751 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3752 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3753 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3754
3755 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3756
3757 * image.c: Various fixes to ImageMagick code comments.
3758 (Fimagemagick_types): Doc fix.
3759
3760 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3761
3762 Minor fixes prompted by GCC 4.6.0 warnings.
3763
3764 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3765
3766 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3767 (x_clipboard_manager_save_all): Move extern decl to ...
3768 * xterm.h: ... here, so that it can be checked for consistency.
3769
3770 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3771
3772 * xselect.c (x_clipboard_manager_save_frame)
3773 (x_clipboard_manager_save_all): New functions.
3774 (Fx_clipboard_manager_save): Lisp function deleted.
3775
3776 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3777 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3778
3779 * xterm.h: Update prototype.
3780
3781 2011-05-28 William Xu <william.xwl@gmail.com>
3782
3783 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3784 exiting (Bug#8239).
3785
3786 2011-05-28 Jim Meyering <meyering@redhat.com>
3787
3788 Avoid a sign-extension bug in crypto_hash_function.
3789 * fns.c (to_uchar): Define.
3790 (crypto_hash_function): Use it to convert some newly-signed
3791 variables to unsigned, to avoid sign-extension bugs. For example,
3792 without this change, (md5 "truc") would evaluate to
3793 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3794 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3795 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3796
3797 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3798
3799 Integer overflow fixes.
3800
3801 * dbusbind.c: Serial number integer overflow fixes.
3802 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3803 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3804 to hold a serial number that is too large for a fixnum.
3805 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3806 Check for serial numbers out of range. Decode any serial number
3807 that was so large that it became a float. (Bug#8722)
3808
3809 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3810 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3811 Use XFASTINT rather than XUINT when numbers are nonnegative.
3812 (xd_append_arg, Fdbus_method_return_internal):
3813 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3814 arguments, check that Lisp number is nonnegative, rather than
3815 silently wrapping negative numbers around. (Bug#8722)
3816 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3817 (Bug#8722)
3818
3819 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3820
3821 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3822
3823 ccl: add integer overflow checks
3824 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3825 (IN_INT_RANGE): New macros.
3826 (ccl_driver): Use them to check for integer overflow when
3827 decoding a CCL program. Many of the new checks are whether XINT (x)
3828 fits in int; it doesn't always, on 64-bit hosts. The new version
3829 doesn't catch all possible integer overflows, but it's an
3830 improvement. (Bug#8719)
3831
3832 * alloc.c (make_event_array): Use XINT, not XUINT.
3833 There's no need for unsigned here.
3834
3835 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3836 This follows up to the 2011-05-06 change that substituted uintptr_t
3837 for EMACS_INT. This case wasn't caught back then.
3838
3839 Rework Fformat to avoid integer overflow issues.
3840 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3841 now (part of C89). Include <verify.h>.
3842 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3843 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3844 (Fformat): Avoid the prepass trying to compute sizes; it was only
3845 approximate and thus did not catch overflow reliably. Instead, walk
3846 through the format just once, formatting and computing sizes as we go,
3847 checking for integer overflow at every step, and allocating a larger
3848 buffer as needed. Keep track separately whether the format is
3849 multibyte. Keep only the most-recently calculated precision, rather
3850 than them all. Record whether each argument has been converted to
3851 string. Use EMACS_INT, not int, for byte and char and arg counts.
3852 Support field widths and precisions larger than INT_MAX. Avoid
3853 sprintf's undefined behavior with conversion specifications such as %#d
3854 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3855 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3856 formatting out-of-range floating point numbers with int
3857 formats. (Bug#8668)
3858
3859 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3860
3861 * data.c: Avoid integer truncation in expressions involving floats.
3862 * data.c: Include <intprops.h>.
3863 (arith_driver): When there's an integer overflow in an expression
3864 involving floating point, convert the integers to floating point
3865 so that the resulting value does not suffer from catastrophic
3866 integer truncation. For example, on a 64-bit host (* 4
3867 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3868 Do not rely on undefined behavior after integer overflow.
3869
3870 merge count_size_as_multibyte, parse_str_to_multibyte
3871 * character.c, character.h (count_size_as_multibyte):
3872 Rename from parse_str_to_multibyte; all uses changed.
3873 Check for integer overflow.
3874 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3875 since it's now a duplicate of the other. This is more of
3876 a character than a buffer op, so better that it's in character.c.
3877 * fns.c, print.c: Adjust to above changes.
3878
3879 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3880
3881 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3882
3883 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3884
3885 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3886 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3887 (x_clipboard_manager_save): Now static.
3888 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3889
3890 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3891 (crypto_hash_function): Now static.
3892 Fix pointer signedness problems. Avoid unnecessary initializations.
3893
3894 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3895
3896 * termhooks.h (Vselection_alist): Make it terminal-local.
3897
3898 * terminal.c (create_terminal): Initialize it.
3899
3900 * xselect.c: Support for clipboard managers.
3901 (Vselection_alist): Move to termhooks.h as terminal-local var.
3902 (LOCAL_SELECTION): New macro.
3903 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3904 (symbol_to_x_atom): Remove gratuitous arg.
3905 (x_handle_selection_request, lisp_data_to_selection_data)
3906 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3907 (x_own_selection, x_get_local_selection, x_convert_selection):
3908 New arg, specifying work frame. Use terminal-local Vselection_alist.
3909 (some_frame_on_display): Delete unused function.
3910 (Fx_own_selection_internal, Fx_get_selection_internal)
3911 (Fx_disown_selection_internal, Fx_selection_owner_p)
3912 (Fx_selection_exists_p): New optional frame arg.
3913 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3914 (x_handle_selection_clear): Don't treat other terminals with the
3915 same keyboard specially. Use the terminal-local Vselection_alist.
3916 (x_clear_frame_selections): Use Frun_hook_with_args.
3917
3918 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3919
3920 * xterm.h: Add support for those atoms.
3921
3922 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3923
3924 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3925 (converted_selections, conversion_fail_tag): New global variables.
3926 (x_selection_request_lisp_error): Free the above.
3927 (x_get_local_selection): Remove unnecessary code.
3928 (x_reply_selection_request): Args changed; handle arbitrary array
3929 of converted selections stored in converted_selections.
3930 Separate the XChangeProperty and SelectionNotify steps.
3931 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3932 (x_convert_selection): New function.
3933 (x_handle_selection_event): Simplify.
3934 (x_get_foreign_selection): Don't ignore incoming requests while
3935 waiting for an answer; this will fail when we implement
3936 SAVE_TARGETS, and seems unnecessary anyway.
3937 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3938 (Vx_sent_selection_functions): Doc fix.
3939
3940 2011-05-26 Leo Liu <sdl.web@gmail.com>
3941
3942 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3943
3944 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3945
3946 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3947
3948 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3949 for fringe update if it has periodic bitmap.
3950 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3951 and fringe_bitmap_periodic_p.
3952
3953 * fringe.c (get_fringe_bitmap_data): New function.
3954 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3955 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3956 row. Mark glyph row for fringe update if periodicity changed.
3957
3958 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3959 for fringe update unless it has periodic bitmap.
3960
3961 2011-05-25 Kenichi Handa <handa@m17n.org>
3962
3963 * xdisp.c (get_next_display_element): Set correct it->face_id for
3964 a static composition.
3965
3966 2011-05-24 Leo Liu <sdl.web@gmail.com>
3967
3968 * deps.mk (fns.o):
3969 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3970
3971 * fns.c (crypto_hash_function, Fsha1): New function.
3972 (Fmd5): Use crypto_hash_function.
3973 (syms_of_fns): Add Ssha1.
3974
3975 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3976
3977 * gnutls.c: Remove unused macros.
3978 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3979 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3980 Remove macros that are defined and never used.
3981 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3982
3983 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3984
3985 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3986 (Fx_get_selection_internal): Minor cleanup.
3987 (Fx_own_selection_internal): Rename arguments for consistency with
3988 select.el.
3989
3990 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3991
3992 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3993
3994 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3995
3996 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3997
3998 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3999
4000 * dispnew.c (scrolling_window): Don't exclude the case that the
4001 last enabled row in the desired matrix touches the bottom boundary.
4002
4003 2011-05-21 Glenn Morris <rgm@gnu.org>
4004
4005 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4006 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4007 and add some more files.
4008
4009 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4010
4011 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4012 report_file_error introduced by the change from 2011-05-07.
4013
4014 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4015
4016 * systime.h (Time): Define only if emacs is defined.
4017 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4018 where the include path doesn't have X11/X.h by default. See
4019 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4020
4021 2011-05-20 Kenichi Handa <handa@m17n.org>
4022
4023 * composite.c (find_automatic_composition): Fix previous change.
4024
4025 2011-05-20 Glenn Morris <rgm@gnu.org>
4026
4027 * lisp.mk: New file, split from Makefile.in.
4028 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4029 (shortlisp): Remove.
4030 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4031
4032 2011-05-19 Glenn Morris <rgm@gnu.org>
4033
4034 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4035 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4036 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4037 (lisp): Set the order to that of loadup.el.
4038 (shortlisp): Make it a copy of $lisp.
4039 (SOME_MACHINE_LISP): Remove.
4040 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4041 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4042
4043 2011-05-18 Kenichi Handa <handa@m17n.org>
4044
4045 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4046 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4047 (find_automatic_composition): Mostly rewrite for efficiency.
4048
4049 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4050
4051 * makefile.w32-in: Update dependencies.
4052
4053 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4054
4055 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4056 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4057
4058 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4059
4060 Fix some integer overflow issues, such as string length overflow.
4061
4062 * insdel.c (count_size_as_multibyte): Check for string overflow.
4063
4064 * character.c (lisp_string_width): Check for string overflow.
4065 Use EMACS_INT, not int, for string indexes and lengths; in
4066 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4067 the resulting string length overflows an EMACS_INT; instead,
4068 report a string overflow if no precision given. When checking for
4069 precision exhaustion, use a check that cannot possibly have
4070 integer overflow. (Bug#8675)
4071 * character.h (lisp_string_width): Adjust to new signature.
4072
4073 * alloc.c (string_overflow): New function.
4074 (Fmake_string): Use it. This doesn't change behavior, but saves
4075 a few bytes and will simplify future changes.
4076 * character.c (string_escape_byte8): Likewise.
4077 * lisp.h (string_overflow): New decl.
4078
4079 Fixups, following up to the user-interface timestamp change.
4080 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4081 for UI timestamps, instead of unsigned long.
4082 * msdos.c (mouse_get_pos): Likewise.
4083 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4084 * w32gui.h (Time): Define by including "systime.h" rather than by
4085 declaring it ourselves. (Bug#8664)
4086
4087 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4088 * image.c (clear_image_cache): Likewise.
4089
4090 * term.c (term_mouse_position): Don't assume time_t wraparound.
4091
4092 Be more systematic about user-interface timestamps.
4093 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4094 and sometimes 'EMACS_UINT', to represent these timestamps.
4095 This change causes it to use 'Time' uniformly, as that's what X uses.
4096 This makes the code easier to follow, and makes it easier to catch
4097 integer overflow bugs such as Bug#8664.
4098 * frame.c (Fmouse_position, Fmouse_pixel_position):
4099 Use Time, not unsigned long, for user-interface timestamps.
4100 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4101 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4102 * keyboard.h (last_event_timestamp): Likewise.
4103 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4104 * menu.h (xmenu_show): Likewise.
4105 * term.c (term_mouse_position): Likewise.
4106 * termhooks.h (struct input_event.timestamp): Likewise.
4107 (struct terminal.mouse_position_hook): Likewise.
4108 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4109 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4110 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4111 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4112 what it was before.
4113 * menu.h, termhooks.h: Include "systime.h", for Time.
4114
4115 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4116 Don't assume that the difference between two unsigned long values
4117 can fit into an integer. At this point, we know button_down_time
4118 <= event->timestamp, so the difference must be nonnegative, so
4119 there's no need to cast the result if double-click-time is
4120 nonnegative, as it should be; check that it's nonnegative, just in
4121 case. This bug is triggered when events are more than 2**31 ms
4122 apart (about 25 days). (Bug#8664)
4123
4124 * xselect.c (last_event_timestamp): Remove duplicate decl.
4125 (x_own_selection): Remove needless cast to unsigned long.
4126
4127 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4128 that always fit in int. Use a sentinel instead of a counter, to
4129 avoid a temp and to allay GCC's concerns about possible int overflow.
4130 * frame.h (struct frame): Use int for menu_bar_items_used
4131 instead of EMACS_INT, since it always fits in int.
4132
4133 * menu.c (grow_menu_items): Check for int overflow.
4134
4135 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4136
4137 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4138 Before, the code was not consistent. These values cannot exceed
4139 2**31 - 1 so there's no need to make them unsigned.
4140 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4141 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4142 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4143 as modifiers.
4144 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4145
4146 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4147 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4148 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4149 presumably because the widths might not match.
4150
4151 * window.c (size_window): Avoid needless test at loop start.
4152
4153 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4154
4155 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4156
4157 2011-05-12 Drew Adams <drew.adams@oracle.com>
4158
4159 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4160
4161 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4162
4163 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4164 `width' to `bar_area_x' and `bar_area_width', respectively.
4165 (x_scroll_run): Take account of fringe background extension.
4166
4167 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4168 Rename local vars `left' and `width' to `bar_area_x' and
4169 `bar_area_width', respectively.
4170 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4171 background extension.
4172
4173 2011-05-10 Jim Meyering <meyering@redhat.com>
4174
4175 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4176
4177 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4178
4179 * image.c (Finit_image_library): Return t for built-in image types,
4180 like pbm and xbm. (Bug#8640)
4181
4182 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4183
4184 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4185
4186 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4187
4188 * w32console.c (Fset_screen_color): Doc fix.
4189 (Fget_screen_color): New function.
4190 (syms_of_ntterm): Defsubr it.
4191
4192 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4193 unlink the temporary file if Fcall_process didn't create it in the
4194 first place.
4195 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4196 child process will be redirected to a file specified with `:file'.
4197 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4198 cue to call_process_cleanup not to close that handle.
4199
4200 2011-05-07 Ben Key <bkey76@gmail.com>
4201
4202 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4203 one of two shell specific rules, either bootstrap-temacs-CMD or
4204 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4205 to the previous implementation of the bootstrap-temacs rule.
4206 The bootstrap-temacs-CMD rule is similar to the previous
4207 implementation of the bootstrap-temacs rule except that it
4208 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4209 variable.
4210
4211 These changes, along with some changes to nt/configure.bat,
4212 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4213 earlier fix to add support for --cflags and --ldflags options
4214 that include quotes so that it works whether make uses cmd or
4215 sh as the shell.
4216
4217 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4218
4219 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4220 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4221 is a constant.
4222 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4223 a string. Handle both cases.
4224 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4225 (Fdbus_register_method): Use Qinvalid_function.
4226
4227 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4228
4229 * makefile.w32-in: Update dependencies.
4230 (LISP_H): Add inttypes.h and stdin.h.
4231 (PROCESS_H): Add unistd.h.
4232
4233 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4234
4235 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4236 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4237
4238 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4239
4240 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4241
4242 * term.c (vfatal): Remove stray call to va_end.
4243 It's not needed and the C Standard doesn't allow it here anyway.
4244
4245 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4246 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4247
4248 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4249 bytes.
4250
4251 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4252
4253 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4254
4255 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4256
4257 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4258
4259 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4260
4261 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4262 * charset.c (Fdefine_charset_internal): Don't initialize
4263 charset.code_space[15]. The value was garbage, on hosts with
4264 32-bit int (Bug#8600).
4265
4266 * lread.c (read_integer): Be more consistent with string-to-number.
4267 Use string_to_number to do the actual conversion; this avoids
4268 rounding errors and fixes some other screwups. Without this fix,
4269 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4270 (digit_to_number): Move earlier, for benefit of read_integer.
4271 Return -1 if the digit is out of range for the base, -2 if it is
4272 not a digit in any supported base. (Bug#8602)
4273
4274 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4275
4276 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4277 to match comment at start of function. This also removes a
4278 GCC warning about overflow in a 32+64-bit port.
4279
4280 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4281
4282 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4283 Reported by Stefan Monnier in
4284 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4285 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4286 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4287
4288 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4289 (EMACS_UINTPTR): Likewise, with uintptr_t.
4290
4291 * lisp.h: Prefer 64-bit EMACS_INT if available.
4292 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4293 on 32-bit hosts that have 64-bit int, so that they can access
4294 large files.
4295 However, temporarily disable this change unless the temporary
4296 symbol WIDE_EMACS_INT is defined.
4297
4298 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4299
4300 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4301 This removes an assumption that EMACS_INT and long are the same
4302 width as pointers. The assumption is true for Emacs porting targets
4303 now, but we want to make other targets possible.
4304 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4305 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4306 In the rest of the code, change types of integers that hold casted
4307 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4308 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4309 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4310 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4311 No need to cast type when ORing.
4312 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4313 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4314 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4315 assume EMACS_INT is the same width as char *.
4316 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4317 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4318 Remove no-longer-needed casts.
4319 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4320 (xg_tool_bar_help_callback, xg_make_tool_item):
4321 Use EMACS_INTPTR to hold an integer
4322 that will be cast to void *; this can avoid a GCC warning
4323 if EMACS_INT is not the same width as void *.
4324 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4325 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4326 (current_message_1, set_message_1):
4327 Use a local to convert to proper width without a cast.
4328 * xmenu.c (dialog_selection_callback): Likewise.
4329
4330 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4331 Also, don't assume VALBITS / RAND_BITS is less than 5,
4332 and don't rely on undefined behavior when shifting a 1 left into
4333 the sign bit.
4334 * lisp.h (get_random): Change signature to match.
4335
4336 * lread.c (hash_string): Use size_t, not int, for hash computation.
4337 Normally we prefer signed values; but hashing is special, because
4338 it's better to use unsigned division on hash table sizes so that
4339 the remainder is nonnegative. Also, size_t is the natural width
4340 for hashing into memory. The previous code used 'int', which doesn't
4341 retain enough info to hash well into very large tables.
4342 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4343
4344 * dbusbind.c: Don't possibly lose pointer info when converting.
4345 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4346 Use XPNTR rather than XHASH, so that the high-order bits of
4347 the pointer aren't lost when converting through void *.
4348
4349 * eval.c (Fautoload): Don't double-shift a pointer.
4350
4351 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4352
4353 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4354
4355 * gnutls.c (DEF_GNUTLS_FN):
4356 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4357
4358 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4359
4360 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4361 marker. (Bug#8610)
4362
4363 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4364
4365 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4366 New version that can reserve upto 2GB of heap space.
4367
4368 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4369
4370 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4371
4372 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4373
4374 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4375 `gnutls_certificate_set_x509_key_file'.
4376
4377 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4378
4379 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4380 Update dependencies.
4381
4382 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4383
4384 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4385 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4386 Remove unused parameter `fildes'.
4387 * process.c (read_process_output, send_process): Don't pass it.
4388
4389 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4390
4391 Fix previous change: the library cache is defined in w32.c.
4392 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4393 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4394
4395 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4396
4397 Implement dynamic loading of GnuTLS on Windows.
4398
4399 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4400 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4401 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4402 Declare.
4403
4404 * gnutls.c (Qgnutls_dll): Define.
4405 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4406 (gnutls_*): Declare function pointers.
4407 (init_gnutls_functions): New function to initialize function pointers.
4408 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4409 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4410 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4411 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4412 (emacs_gnutls_write, emacs_gnutls_read)
4413 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4414 (Fgnutls_available_p): New function.
4415 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4416 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4417 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4418
4419 * image.c: Include w32.h.
4420 (Vimage_type_cache): Delete.
4421 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4422 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4423 (w32_delayed_load): Move to w32.c.
4424
4425 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4426
4427 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4428 (w32_delayed_load): Move from image.c. When loading a library, record
4429 its filename in the :loaded-from property of the library id.
4430 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4431 Initialize and staticpro them.
4432 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4433
4434 * process.c: Include lisp.h before w32.h, not after.
4435 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4436 instead of gnutls_record_check_pending.
4437
4438 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4439
4440 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4441
4442 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4443 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4444 as passed in.
4445
4446 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4447
4448 * xterm.c (x_set_frame_alpha): Do not set property on anything
4449 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4450
4451 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4452
4453 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4454
4455 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4456
4457 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4458 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4459 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4460 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4461 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4462 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4463 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4464 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4465 (Qgnutls_bootprop_callbacks_verify): Make static.
4466
4467 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4468
4469 * callproc.c: Indentation fixup.
4470
4471 * sysdep.c (wait_for_termination_1): Make static.
4472 (wait_for_termination, interruptible_wait_for_termination):
4473 Move after wait_for_termination_1.
4474
4475 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4476
4477 * sysdep.c (interruptible_wait_for_termination): New function
4478 which is like wait_for_termination, but allows keyboard
4479 interruptions.
4480
4481 * callproc.c (Fcall_process): Add (:file "file") as an option for
4482 the STDOUT buffer.
4483 (Fcall_process_region): Ditto.
4484
4485 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4486
4487 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4488 rather than `XVECTOR (FOO)->size'.
4489
4490 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4491 inttypes.h, as a gnulib replacement is used if it not available in
4492 system headers.
4493
4494 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4495
4496 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4497 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4498 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4499
4500 * coding.c (coding_alloc_by_realloc): Error out if destination
4501 will grow beyond MOST_POSITIVE_FIXNUM.
4502 (decode_coding_emacs_mule): Abort if there isn't enough place in
4503 charbuf for the composition carryover bytes. Reserve an extra
4504 space for up to 2 characters produced in a loop.
4505 (decode_coding_iso_2022): Abort if there isn't enough place in
4506 charbuf for the composition carryover bytes.
4507
4508 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4509
4510 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4511 aborting when %lld or %lll format is passed.
4512 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4513 %llo or %llx format is passed. (Bug#8545)
4514
4515 * window.c (window_scroll_line_based): Use a marker instead of
4516 simple variables to record original value of point. (Bug#7952)
4517
4518 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4519 produced by %s or %c overflows available buffer space. (Bug#8545)
4520
4521 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4522
4523 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4524 (SIZE_MAX): Move defn after all includes, as they might #define it.
4525
4526 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4527
4528 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4529
4530 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4531
4532 * keyboard.c (Qdelayed_warnings_hook): Define.
4533 (command_loop_1): Run `delayed-warnings-hook'
4534 if Vdelayed_warnings_list is non-nil.
4535 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4536 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4537
4538 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4539
4540 * doprnt.c (doprnt): Don't return value smaller than the buffer
4541 size if the message was truncated. (Bug#8545).
4542
4543 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4544
4545 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4546 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4547
4548 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4549
4550 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4551
4552 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4553
4554 * makefile.w32-in: Update dependencies.
4555
4556 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4557
4558 Improve `doprnt' and its usage. (Bug#8545)
4559 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4560 `format_end'. Remove support for %l as a conversion specifier.
4561 Don't use xrealloc. Improve diagnostics when the %l size modifier
4562 is used. Update the commentary.
4563
4564 * eval.c (verror): Simplify calculation of size_t.
4565
4566 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4567 messages.
4568
4569 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4570
4571 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4572 change.
4573
4574 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4575
4576 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4577 This makes this file independent of the recent pseudovector change.
4578
4579 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4580
4581 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4582
4583 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4584 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4585 Remove unused local.
4586 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4587
4588 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4589 GCC 4.6.0 optimizes based on type-based alias analysis.
4590 For example, if b is of type struct buffer * and v of type struct
4591 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4592 != &v->size, and therefore "v->size = 1; b->size = 2; return
4593 v->size;" must therefore return 1. This assumption is incorrect
4594 for Emacs, since it type-puns struct Lisp_Vector * with many other
4595 types. To fix this problem, this patch adds a new type struct
4596 vectorlike_header that documents the constraints on layout of vectors
4597 and pseudovectors, and helps optimizing compilers not get fooled
4598 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4599 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4600 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4601 the size member.
4602 (XSETPVECTYPE): Rewrite in terms of new macro.
4603 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4604 This is a bit clearer, and further avoids the possibility of
4605 undesirable aliasing.
4606 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4607 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4608 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4609 since Lisp_Subr is a special case (no "next" field).
4610 (ASIZE): Now uses header.size rather than size.
4611 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4612 to avoid the hassle of writing XVECTOR (foo)->header.size.
4613 (struct vectorlike_header): New type.
4614 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4615 object, to help avoid aliasing.
4616 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4617 (SUBRP): Likewise, since Lisp_Subr is a special case.
4618 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4619 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4620 (struct Lisp_Hash_Table): Combine first two members into a single
4621 struct vectorlike_header member. All uses of "size" and "next" members
4622 changed to be "header.size" and "header.next".
4623 * buffer.h (struct buffer): Likewise.
4624 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4625 * frame.h (struct frame): Likewise.
4626 * process.h (struct Lisp_Process): Likewise.
4627 * termhooks.h (struct terminal): Likewise.
4628 * window.c (struct save_window_data, struct saved_window): Likewise.
4629 * window.h (struct window): Likewise.
4630 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4631 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4632 * buffer.c (init_buffer_once): Likewise.
4633 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4634 special case.
4635 * process.c (Fformat_network_address): Use local var for size,
4636 for brevity.
4637
4638 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4639
4640 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4641 * data.c (atof): Remove decl; no longer used or needed.
4642 (digit_to_number): Move to lread.c.
4643 (Fstring_to_number): Use new string_to_number function, to be
4644 consistent with how the Lisp reader treats infinities and NaNs.
4645 Do not assume that floating-point numbers represent EMACS_INT
4646 without losing information; this is not true on most 64-bit hosts.
4647 Avoid double-rounding errors, by insisting on integers when
4648 parsing non-base-10 numbers, as the documentation specifies.
4649 * lisp.h (string_to_number): New decl, replacing ...
4650 (isfloat_string): Remove.
4651 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4652 (read1): Do not accept +. and -. as integers; this
4653 appears to have been a coding error. Similarly, do not accept
4654 strings like +-1e0 as floating point numbers. Do not report
4655 overflow for integer overflows unless the base is not 10 which
4656 means we have no simple and reliable way to continue.
4657 Break out the floating-point parsing into a new
4658 function string_to_number, so that Fstring_to_number parses
4659 floating point numbers consistently with the Lisp reader.
4660 (digit_to_number): Move here from data.c. Make it static inline.
4661 (E_CHAR, EXP_INT): Remove, replacing with ...
4662 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4663 (string_to_number): New function, replacing isfloat_string.
4664 This function checks for valid syntax and produces the resulting
4665 Lisp float number too. Rework it so that string-to-number
4666 no longer mishandles examples like "1.0e+". Use strtoumax,
4667 so that overflow for non-base-10 numbers is reported only when
4668 there's no portable and simple way to convert to floating point.
4669
4670 * textprop.c (set_text_properties_1): Rewrite for clarity,
4671 and to avoid GCC warning about integer overflow.
4672
4673 * intervals.h (struct interval): Use EMACS_INT for members
4674 where EMACS_UINT might cause problems. See
4675 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4676 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4677 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4678 All uses changed.
4679 (offset_intervals): Tell GCC not to worry about length overflow
4680 when negating a negative length.
4681
4682 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4683 (overrun_check_free): Likewise.
4684
4685 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4686 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4687 word size.
4688
4689 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4690 (gnutls_make_error): Rename local to avoid shadowing.
4691 (gnutls_emacs_global_deinit): ifdef out; not used.
4692 (Fgnutls_boot): Use const for pointer to readonly storage.
4693 Comment out unused local. Fix pointer signedness problems.
4694
4695 * lread.c (openp): Don't stuff size_t into an 'int'.
4696 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4697 about possible signed overflow.
4698
4699 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4700 (GDK_KEY_g): Don't define if already defined.
4701 (xg_prepare_tooltip): Avoid pointer signedness problem.
4702 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4703
4704 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4705 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4706
4707 * xfns.c (Fx_window_property): Simplify a bit,
4708 to make a bit faster and to avoid GCC 4.6.0 warning.
4709 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4710
4711 * fns.c (internal_equal): Don't assume size_t fits in int.
4712
4713 * alloc.c (compact_small_strings): Tighten assertion a little.
4714
4715 Replace pEd with more-general pI, and fix some printf arg casts.
4716 * lisp.h (pI): New macro, generalizing old pEd macro to other
4717 conversion specifiers. For example, use "...%"pI"d..." rather
4718 than "...%"pEd"...".
4719 (pEd): Remove. All uses replaced with similar uses of pI.
4720 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4721 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4722 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4723 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4724 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4725 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4726 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4727 64-bit hosts.
4728 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4729 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4730 * print.c (safe_debug_print, print_object): Likewise.
4731 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4732 to int.
4733 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4734 avoiding the 0 flag, which is not portable.
4735 * process.c (Fmake_network_process): Use pI to avoid cast.
4736 * region-cache.c (pp_cache): Likewise.
4737 * xdisp.c (decode_mode_spec): Likewise.
4738 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4739 behavior on 64-bit hosts with printf arg.
4740 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4741 (x_stop_queuing_selection_requests): Likewise.
4742 (x_get_window_property): Don't truncate byte count to an 'int'
4743 when tracing.
4744
4745 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4746 here, since it parses constructs like leading '-' and spaces,
4747 which are not wanted; and it overflows with large numbers.
4748 Instead, simply match F[0-9]+, which is what is wanted anyway.
4749
4750 * alloc.c: Remove unportable assumptions about struct layout.
4751 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4752 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4753 (allocate_vectorlike, make_pure_vector): Use the new macros,
4754 plus offsetof, to remove unportable assumptions about struct layout.
4755 These assumptions hold on all porting targets that I know of, but
4756 they are not guaranteed, they're easy to remove, and removing them
4757 makes further changes easier.
4758
4759 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4760 This doesn't fix a bug but makes the code clearer.
4761 (string_overrun_cookie): Now const. Use initializers that
4762 don't formally overflow signed char, to avoid warnings.
4763 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4764 can cause Emacs to crash when string overrun checking is enabled.
4765 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4766 multiple of sizeof (EMACS_INT); it need not be, if
4767 alignof(EMACS_INT) < sizeof (EMACS_INT).
4768 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4769
4770 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4771
4772 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4773
4774 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4775
4776 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4777 supposed to be handshaking. (Bug#8556)
4778 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4779
4780 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4781
4782 * lisp.h (Qdebug): List symbol.
4783 * eval.c (Qdebug): Restore global linkage.
4784 * keyboard.c (debug-on-event): New variable.
4785 (handle_user_signal): Break into debugger when debug-on-event
4786 matches the current signal symbol.
4787
4788 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4789
4790 * alloc.c (check_sblock, check_string_bytes)
4791 (check_string_free_list): Convert to standard C.
4792
4793 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4794
4795 * w32.c (emacs_gnutls_push): Fix typo.
4796
4797 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4798
4799 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4800 "cast to pointer from integer of different size".
4801
4802 Improve doprnt and its use in verror. (Bug#8545)
4803 * doprnt.c (doprnt): Document the set of format control sequences
4804 supported by the function. Use SAFE_ALLOCA instead of always
4805 using `alloca'.
4806
4807 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4808 is one byte too soon. Don't use xrealloc; instead xfree and
4809 xmalloc anew.
4810
4811 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4812
4813 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4814 callbacks stage.
4815
4816 * gnutls.c: Renamed global_initialized to
4817 gnutls_global_initialized. Added internals for the
4818 :verify-hostname-error, :verify-error, and :verify-flags
4819 parameters of `gnutls-boot' and documented those parameters in the
4820 docstring. Start callback support.
4821 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4822 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4823 on error. Return error code.
4824 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4825 (emacs_gnutls_read): Likewise.
4826 (Fgnutls_boot): Return handshake error code.
4827 (emacs_gnutls_handle_error): New function.
4828 (wsaerror_to_errno): Likewise.
4829
4830 * w32.h (emacs_gnutls_pull): Add prototype.
4831 (emacs_gnutls_push): Likewise.
4832
4833 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4834 (emacs_gnutls_push): Likewise.
4835
4836 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4837
4838 * process.c (wait_reading_process_output): Check if GnuTLS
4839 buffered some data internally if no FDs are set for TLS
4840 connections.
4841
4842 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4843 (LIBS): Link to USER_LIBS.
4844 ($(BLD)/gnutls.$(0)): New target.
4845
4846 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4847
4848 * xdisp.c (handle_single_display_spec): Rename the
4849 display_replaced_before_p argument into display_replaced_p, to
4850 make it consistent with the commentary. Fix typos in the
4851 commentary.
4852
4853 * textprop.c (syms_of_textprop): Remove dead code.
4854 (copy_text_properties): Delete obsolete commentary about an
4855 interface that was deleted long ago. Fix typos in the description
4856 of arguments.
4857
4858 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4859 to changes in oldXMenu/XMenu.h from 2011-04-16.
4860 <menu_help_message, prev_menu_help_message>: Constify.
4861 (IT_menu_make_room): menu->help_text is now `const char **';
4862 adjust.
4863
4864 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4865 to changes in oldXMenu/XMenu.h from 2011-04-16.
4866 (struct XMenu): Declare `help_text' `const char **'.
4867
4868 * xfaces.c <Qunspecified>: Make extern again.
4869
4870 * syntax.c: Include sys/types.h before including regex.h, as
4871 required by Posix.
4872
4873 * doc.c (get_doc_string): Improve the format passed to `error'.
4874
4875 * doprnt.c (doprnt): Improve commentary.
4876
4877 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4878
4879 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4880 them with etags.
4881
4882 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4883 changes in globals.h immediately force recompilation.
4884 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4885 $(CURDIR)/s/ms-w32.h.
4886 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4887
4888 * character.c (Fchar_direction): Function deleted.
4889 (syms_of_character): Don't defsubr it.
4890 <char-direction-table>: Deleted.
4891
4892 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4893
4894 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4895 * doprnt.c: Include limits.h.
4896 (SIZE_MAX): New macro.
4897 (doprnt): Return a size_t value. 2nd arg is now size_t.
4898 Many local variables are now size_t instead of int or unsigned.
4899 Improve overflow protection. Support `l' modifier for integer
4900 conversions. Support %l conversion. Don't assume an EMACS_INT
4901 argument for integer conversions and for %c.
4902
4903 * lisp.h (doprnt): Restore prototype.
4904
4905 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4906 $(SRC)/character.h.
4907
4908 * Makefile.in (base_obj): Add back doprnt.o.
4909
4910 * deps.mk (doprnt.o): Add back prerequisites.
4911 (callint.o): Depend on character.h.
4912
4913 * eval.c (internal_lisp_condition_case): Include the handler
4914 representation in the error message.
4915 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4916 when breaking from the loop.
4917
4918 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4919
4920 * callint.c (Fcall_interactively): When displaying error message
4921 about invalid control letter, pass the character's codepoint, not
4922 a pointer to its multibyte form. Improve display of the character
4923 in octal and display also its hex code.
4924
4925 * character.c (char_string): Use %x to display the (unsigned)
4926 codepoint of an invalid character, to avoid displaying a bogus
4927 negative value.
4928
4929 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4930 `error', not SYMBOL_NAME itself.
4931
4932 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4933 character arguments to `error'.
4934
4935 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4936 to `error' in error message about FINAL_CHAR argument. Make sure
4937 FINAL_CHAR is a character, and use %c when it is passed as
4938 argument to `error'.
4939
4940 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4941
4942 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4943
4944 * w32.c: Include <time.h>.
4945 (sys_localtime): New function.
4946
4947 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4948
4949 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4950
4951 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4952
4953 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4954
4955 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4956 zombies (Bug#8467).
4957
4958 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4959
4960 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4961 gl_state.e_property when gl_state.object is Qt.
4962
4963 * insdel.c (make_gap_larger): Remove limitation of buffer size
4964 to <= INT_MAX.
4965
4966 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4967
4968 * xdisp.c (lookup_glyphless_char_display)
4969 (produce_glyphless_glyph): Handle cons cell entry in
4970 glyphless-char-display.
4971 (Vglyphless_char_display): Document it.
4972
4973 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4974 glyphless-char-display.
4975
4976 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4977
4978 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4979
4980 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4981
4982 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4983 definition for no-X builds.
4984
4985 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4986
4987 Static checks with GCC 4.6.0 and non-default toolkits.
4988
4989 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4990
4991 * process.c (keyboard_bit_set): Define only if SIGIO.
4992 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4993 (send_process): Repair possible setjmp clobbering.
4994
4995 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4996
4997 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4998
4999 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5000
5001 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5002 Define only if needed.
5003
5004 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5005 by pacifying GCC about it. Maybe it's time to retire it?
5006 * xfaces.c (USG, __TIMEVAL__): Likewise.
5007
5008 * dispextern.h (struct redisplay_interface): Rename param
5009 to avoid shadowing.
5010 * termhooks.h (struct terminal): Likewise.
5011 * xterm.c (xembed_send_message): Likewise.
5012
5013 * insdel.c (make_gap_smaller): Define only if
5014 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5015
5016 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5017 it.
5018
5019 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5020 so that we aren't warned about unused symbols.
5021
5022 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5023
5024 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5025
5026 * xfns.c (x_real_positions): Mark locals as initialized.
5027
5028 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5029
5030 * xterm.c: Fix problems found by static analysis with other toolkits.
5031 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5032 (x_dispatch_event): Declare static if USE_GTK, and
5033 define if USE_GTK || USE_X_TOOLKIT.
5034 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5035 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5036 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5037 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5038
5039 * xmenu.c (menu_help_callback): Pointer type fixes.
5040 Use const pointers when pointing at readonly data. Avoid pointer
5041 signedness clashes.
5042 (FALSE): Remove unused macro.
5043 (update_frame_menubar): Remove unused decl.
5044
5045 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5046
5047 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5048 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5049 (single_menu_item): Rename local to avoid shadowing.
5050
5051 * keyboard.c (make_lispy_event): Remove unused local var.
5052
5053 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5054 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5055
5056 * bitmaps: Change bitmaps from unsigned char back to the X11
5057 compatible char. Avoid the old compiler warnings about
5058 out-of-range initializers by using, for example, '\xab' rather
5059 than 0xab.
5060
5061 * xgselect.c (xgselect_initialize): Check vs interface
5062 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5063
5064 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5065
5066 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5067 to read-only memory.
5068
5069 * fns.c (vector): Remove; this old hack is no longer needed.
5070
5071 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5072 Remove unused var.
5073 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5074
5075 * xrdb.c (x_load_resources): Omit unused local.
5076
5077 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5078 (x_window): Rename locals to avoid shadowing.
5079 (USG): Use the kludged USG macro, to pacify gcc.
5080
5081 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5082 (x_term_init): Remove local to avoid shadowing.
5083
5084 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5085
5086 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5087 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5088
5089 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5090
5091 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5092
5093 Fix regex.c, syntax.c and friends for buffers > 2GB.
5094 * syntax.h (struct gl_state_s): Declare character position members
5095 EMACS_INT.
5096
5097 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5098
5099 * textprop.c (verify_interval_modification, interval_of):
5100 Declare arguments EMACS_INT.
5101
5102 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5103 EMACS_INT.
5104
5105 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5106
5107 * indent.c (Fvertical_motion): Local variable it_start is now
5108 EMACS_INT.
5109
5110 * regex.c (re_match, re_match_2, re_match_2_internal)
5111 (bcmp_translate, regcomp, regexec, print_double_string)
5112 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5113 (re_compile_pattern, re_exec): Declare arguments and local
5114 variables `size_t' and `ssize_t' and return values `regoff_t', as
5115 appropriate.
5116 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5117 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5118 <compile_stack_type>: `size' and `avail' are now `size_t'.
5119
5120 * regex.h <regoff_t>: Use ssize_t, not int.
5121 (re_search, re_search_2, re_match, re_match_2): Arguments that
5122 specify buffer/string position and length are now ssize_t and
5123 size_t. Return type is regoff_t.
5124
5125 2011-04-16 Ben Key <bkey76@gmail.com>
5126
5127 * nsfont.m: Fixed bugs in ns_get_family and
5128 ns_descriptor_to_entity that were caused by using free to
5129 deallocate memory blocks that were allocated by xmalloc (via
5130 xstrdup). This caused Emacs to crash when compiled with
5131 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5132 --enable-checking=xmallocoverrun). xfree is now used to
5133 deallocate these memory blocks.
5134
5135 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5136
5137 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5138
5139 emacs_write: Accept and return EMACS_INT for sizes.
5140 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5141 et seq.
5142 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5143 Accept and return EMACS_INT.
5144 (emacs_gnutls_write): Return the number of bytes written on
5145 partial writes.
5146 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5147 (emacs_read, emacs_write): Remove check for negative size, as the
5148 Emacs source code has been audited now.
5149 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5150 (emacs_read, emacs_write): Use it.
5151 * process.c (send_process): Adjust to the new signatures of
5152 emacs_write and emacs_gnutls_write. Do not attempt to store
5153 a byte offset into an 'int'; it might overflow.
5154 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5155
5156 * sound.c: Don't assume sizes fit in 'int'.
5157 (struct sound_device.period_size, alsa_period_size):
5158 Return EMACS_INT, not int.
5159 (struct sound_device.write, vox_write, alsa_write):
5160 Accept EMACS_INT, not int.
5161 (wav_play, au_play): Use EMACS_INT to store sizes and to
5162 record read return values.
5163
5164 2011-04-15 Ben Key <bkey76@gmail.com>
5165
5166 * keyboard.c (Qundefined): Don't declare static since it is used
5167 in nsfns.m.
5168 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5169 static since they are used in nsfont.m.
5170
5171 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5172
5173 * process.c (Qprocessp): Don't declare static.
5174 * lisp.h (Qprocessp): Declare again.
5175
5176 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5177
5178 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5179
5180 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5181
5182 Improve C-level modularity by making more things 'static'.
5183
5184 Don't publish debugger-only interfaces to other modules.
5185 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5186 (verify_bytepos, count_markers): Move decls to the only modules
5187 that need them.
5188 * region-cache.h (pp_cache): Likewise.
5189 * window.h (check_all_windows): Likewise.
5190 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5191
5192 * sysdep.c (croak): Now static, if
5193 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5194 * syssignal.h (croak): Declare only if not static.
5195
5196 * alloc.c (refill_memory_reserve): Now static if
5197 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5198 * lisp.h (refill_memory_reserve): Declare only if not static.
5199
5200 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5201 Define only if USE_LUCID.
5202
5203 * xrdb.c (x_customization_string, x_rm_string): Now static.
5204
5205 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5206 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5207
5208 * xdisp.c (draw_row_with_mouse_face): Now static.
5209 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5210
5211 * window.h (check_all_windows): Mark externally visible.
5212
5213 * window.c (window_deletion_count): Now static.
5214
5215 * undo.c: Make symbols static if they're not exported.
5216 (last_undo_buffer, last_boundary_position, pending_boundary):
5217 Now static.
5218
5219 * textprop.c (interval_insert_behind_hooks): Now static.
5220 (interval_insert_in_front_hooks): Likewise.
5221
5222 * term.c: Make symbols static if they're not exported.
5223 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5224 (max_frame_lines, tty_set_terminal_modes):
5225 (tty_reset_terminal_modes, tty_turn_off_highlight):
5226 (get_tty_terminal): Now static.
5227 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5228 * termhooks.h (term_mouse_moveto): Do not declare if
5229 HAVE_WINDOW_SYSTEM.
5230 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5231 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5232
5233 * sysdep.c: Make symbols static if they're not exported.
5234 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5235 Now static.
5236 (sigprocmask_set, full_mask): Remove; unused.
5237 (wait_debugging): Mark as visible.
5238 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5239 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5240
5241 * syntax.c (syntax_temp): Define only if !__GNUC__.
5242
5243 * sound.c (current_sound_device, current_sound): Now static.
5244
5245 * search.c (searchbufs, searchbuf_head): Now static.
5246
5247 * scroll.c (scroll_cost): Remove; unused.
5248 * dispextern.h (scroll_cost): Remove decl.
5249
5250 * region-cache.h (pp_cache): Mark as externally visible.
5251
5252 * process.c: Make symbols static if they're not exported.
5253 (process_tick, update_tick, create_process, chan_process):
5254 (Vprocess_alist, proc_buffered_char, datagram_access):
5255 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5256 (deactivate_process): Mark defn as static, as well as decl.
5257 * lisp.h (create_process): Remove decl.
5258 * process.h (chan_process, Vprocess_alist): Remove decls.
5259
5260 * print.c: Make symbols static if they're not exported.
5261 (print_depth, new_backquote_output, being_printed, print_buffer):
5262 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5263 (print_interval, print_number_index, initial_stderr_stream):
5264 Now static.
5265 * lisp.h (Fprinc): Remove decl.
5266 (debug_output_compilation_hack): Mark as externally visible.
5267
5268 * sysdep.c (croak): Move decl from here to syssignal.h.
5269 * syssignal.h (croak): Put it here, so the API can be checked when
5270 'croak' is called from dissociate_if_controlling_tty.
5271
5272 * minibuf.c: Make symbols static if they're not exported.
5273 (minibuf_save_list, choose_minibuf_frame): Now static.
5274 * lisp.h (choose_minibuf_frame): Remove decl.
5275
5276 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5277
5278 * lread.c: Make symbols static if they're not exported.
5279 (read_objects, initial_obarray, oblookup_last_bucket_number):
5280 Now static.
5281 (make_symbol): Remove; unused.
5282 * lisp.h (initial_obarray, make_symbol): Remove decls.
5283
5284 * keyboard.c: Make symbols static if they're not exported.
5285 (single_kboard, recent_keys_index, total_keys, recent_keys):
5286 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5287 (this_single_command_key_start, echoing, last_auto_save):
5288 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5289 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5290 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5291 (Vlispy_mouse_stem, double_click_count):
5292 Now static.
5293 (force_auto_save_soon): Define only if SIGDANGER.
5294 (ignore_mouse_drag_p): Now static if
5295 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5296 (print_help): Remove; unused.
5297 (stop_character, last_timer_event): Mark as externally visible.
5298 * keyboard.h (ignore_mouse_drag_p): Declare only if
5299 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5300 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5301 * lisp.h (echoing): Remove decl.
5302 (force_auto_save_soon): Declare only if SIGDANGER.
5303 * xdisp.c (redisplay_window): Simplify code, to make it more
5304 obvious that ignore_mouse_drag_p is not accessed if !defined
5305 USE_GTK && !defined HAVE_NS.
5306
5307 * intervals.c: Make symbols static if they're not exported.
5308 (merge_properties_sticky, merge_interval_right, delete_interval):
5309 Now static.
5310 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5311
5312 * insdel.c: Make symbols static if they're not exported.
5313 However, leave prepare_to_modify_buffer alone. It's never
5314 called from outside this function, but that appears to be a bug.
5315 (combine_after_change_list, combine_after_change_buffer):
5316 (adjust_after_replace, signal_before_change): Now static.
5317 (adjust_after_replace_noundo): Remove; unused.
5318 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5319 (signal_before_change): Remove decls.
5320
5321 * indent.c (val_compute_motion, val_vmotion): Now static.
5322
5323 * image.c: Make symbols static if they're not exported.
5324 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5325 if USE_GTK.
5326 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5327 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5328
5329 * fringe.c (standard_bitmaps): Now static.
5330 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5331
5332 * frame.c: Make symbols static if they're not exported.
5333 (x_report_frame_params, make_terminal_frame): Now static.
5334 (get_frame_param): Now static, unless HAVE_NS.
5335 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5336 (x_get_resource_string): Remove; not used.
5337 * frame.h (make_terminal_frame, x_report_frame_params):
5338 (x_get_resource_string); Remove decls.
5339 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5340 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5341
5342 * font.c, fontset.c: Make symbols static if they're not exported.
5343 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5344 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5345 * font.c (font_close_object): Now static.
5346 * font.h (font_close_object): Remove.
5347 * fontset.c (FONTSET_OBJLIST): Remove.
5348 (free_realized_fontset) #if-0 the body, which does nothing.
5349 (face_suitable_for_char_p): #if-0, as it's never called.
5350 * fontset.h (face_suitable_for_char_p): Remove decl.
5351 * xfaces.c (face_at_string_position):
5352 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5353 since 0 is always ASCII.
5354
5355 * fns.c (weak_hash_tables): Now static.
5356
5357 * fileio.c: Make symbols static if they're not exported.
5358 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5359 (Vwrite_region_annotation_buffers): Now static.
5360
5361 * eval.c: Make symbols static if they're not exported.
5362 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5363 * lisp.h (backtrace_list): Remove decl.
5364
5365 * emacs.c: Make symbols static if they're not exported.
5366 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5367 (fatal_error_code, fatal_error_signal_hook, standard_args):
5368 Now static.
5369 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5370 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5371 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5372 * lisp.h (fatal_error_signal_hook): Remove decl.
5373 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5374
5375 * editfns.c: Move a (normally-unused) function to its only use.
5376 * editfns.c, lisp.h (get_operating_system_release): Remove.
5377 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5378 worth the hassle of breaking this out.
5379
5380 * xterm.c: Make symbols static if they're not exported.
5381 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5382 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5383 (x_destroy_window, x_delete_display):
5384 Now static.
5385 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5386 (x_mouse_leave): Remove; unused.
5387 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5388 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5389 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5390 Remove decls.
5391 (x_mouse_leave): Declare only if WINDOWSNT.
5392 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5393 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5394 USE_X_TOOLKIT.
5395
5396 * ftxfont.c: Make symbols static if they're not exported.
5397 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5398 HAVE_FREETYPE.
5399 * font.h (ftxfont_driver): Likewise.
5400
5401 * xfns.c: Make symbols static if they're not exported.
5402 (x_last_font_name, x_display_info_for_name):
5403 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5404 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5405 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5406 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5407 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5408 (last_show_tip_args): Now static.
5409 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5410 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5411 (x_screen_planes): Remove; unused.
5412 * dispextern.h (x_screen_planes): Remove decl.
5413
5414 * dispnew.c: Make symbols static if they're not exported.
5415 * dispextern.h (redraw_garbaged_frames, scrolling):
5416 (increment_row_positions): Remove.
5417 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5418 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5419 Now static.
5420 (redraw_garbaged_frames): Remove; unused.
5421
5422 * xfaces.c: Make symbols static if they're not exported.
5423 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5424 Remove decls.
5425 * xterm.h (defined_color): Remove decls.
5426 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5427 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5428 (menu_face_changed_default, defined_color, free_realized_face):
5429 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5430 (ascii_face_of_lisp_face): Remove; unused.
5431
5432 * xdisp.c: Make symbols static if they're not exported.
5433 * dispextern.h (scratch_glyph_row, window_box_edges):
5434 (glyph_to_pixel_coords, set_cursor_from_row):
5435 (get_next_display_element, set_iterator_to_next):
5436 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5437 (show_mouse_face): Remove decls
5438 * frame.h (message_buf_print): Likewise.
5439 * lisp.h (pop_message, set_message, check_point_in_composition):
5440 Likewise.
5441 * xterm.h (set_vertical_scroll_bar): Likewise.
5442 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5443 (message_buf_print, scratch_glyph_row, displayed_buffer):
5444 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5445 (get_next_display_element, show_mouse_face, window_box_edges):
5446 (frame_to_window_pixel_xy, check_point_in_composition):
5447 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5448 (glyph_to_pixel_coords): Remove; unused.
5449
5450 * dired.c (file_name_completion): Now static.
5451
5452 * dbusbind.c (xd_in_read_queued_messages): Now static.
5453
5454 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5455 * data.c (circular_list_error): Remove.
5456
5457 * commands.h (last_point_position, last_point_position_buffer):
5458 (last_point_position_window): Remove decls.
5459 * keyboard.c: Make these variables static.
5460
5461 * coding.h (coding, code_convert_region, encode_coding_gap):
5462 Remove decls.
5463 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5464 (iso_code_class, detect_coding, code_convert_region): Now static.
5465 (encode_coding_gap): Remove; unused.
5466
5467 * chartab.c (chartab_chars, chartab_bits): Now static.
5468
5469 * charset.h (charset_iso_8859_1): Remove decl.
5470 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5471 Now static.
5472
5473 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5474 * ccl.c (Vccl_program_table): Now static.
5475 (check_ccl_update): Remove; unused.
5476
5477 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5478 * category.h: ... from here.
5479 * category.c (check_category_table, set_category_set): Now static.
5480
5481 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5482 * lisp.h: Remove these decls.
5483
5484 * buffer.c (buffer_count): Remove unused var.
5485
5486 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5487 so that it's not optimized away.
5488 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5489 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5490 exported only to the debugger.
5491
5492 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5493 * atimer.h (run_all_atimers): Remove; not exported.
5494
5495 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5496 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5497 was inaccessible from Lisp.
5498 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5499 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5500
5501 alloc.c: Import and export fewer symbols, and remove unused items.
5502 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5503 is defined.
5504 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5505 it's not optimized away by whole-program optimization.
5506 (message_enable_multibyte, free_misc): Remove.
5507 (catchlist, handlerlist, mark_backtrace):
5508 Declare only if BYTE_MARK_STACK.
5509 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5510 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5511 (message_enable_multibyte): Remove decl.
5512 (free_misc, interval_free_list, float_block, float_block_index):
5513 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5514 (cons_free_list, last_marked_index):
5515 Now static.
5516 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5517 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5518 (mark_backtrace): Define only if BYTE_MARK_STACK.
5519 * xdisp.c (message_enable_multibyte): Now static.
5520
5521 Declare Lisp_Object Q* variables to be 'static' if not exported.
5522 This makes it easier for human readers (and static analyzers)
5523 to see whether these variables are used from other modules.
5524 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5525 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5526 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5527 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5528 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5529 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5530 * xmenu.c, xselect.c:
5531 Declare Q* vars static if they are not used in other modules.
5532 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5533 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5534 Remove decls of unexported vars.
5535 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5536
5537 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5538
5539 Make Emacs functions such as Fatom 'static' by default.
5540 This makes it easier for human readers (and static analyzers)
5541 to see whether these functions can be called from other modules.
5542 DEFUN now defines a static function. To make the function external
5543 so that it can be used in other C modules, use the new macro DEFUE.
5544 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5545 (Finit_image_library):
5546 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5547 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5548 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5549 Remove decls, since these functions are now static.
5550 (Funintern, Fget_internal_run_time): New decls, since these functions
5551 were already external.
5552
5553 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5554 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5555 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5556 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5557 * keyboard.c, keymap.c, lread.c:
5558 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5559 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5560 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5561 Mark functions with DEFUE instead of DEFUN,
5562 if they are used in other modules.
5563 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5564 decls for now-static functions.
5565 * buffer.h (Fdelete_overlay): Remove decl.
5566 * callproc.c (Fgetenv_internal): Mark as internal.
5567 * composite.c (Fremove_list_of_text_properties): Remove decl.
5568 (Fcomposition_get_gstring): New forward static decl.
5569 * composite.h (Fcomposite_get_gstring): Remove decl.
5570 * dired.c (Ffile_attributes): New forward static decl.
5571 * doc.c (Fdocumntation_property): New forward static decl.
5572 * eval.c (Ffetch_bytecode): New forward static decl.
5573 (Funintern): Remove extern decl; now in .h file where it belongs.
5574 * fileio.c (Fmake_symbolic_link): New forward static decl.
5575 * image.c (Finit_image_library): New forward static decl.
5576 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5577 * intervals.h (Fprevious_property_change):
5578 (Fremove_list_of_text_properties): Remove decls.
5579 * keyboard.c (Fthis_command_keys): Remove decl.
5580 (Fcommand_execute): New forward static decl.
5581 * keymap.c (Flookup_key): New forward static decl.
5582 (Fcopy_keymap): Now static.
5583 * keymap.h (Flookup_key): Remove decl.
5584 * process.c (Fget_process): New forward static decl.
5585 (Fprocess_datagram_address): Mark as internal.
5586 * syntax.c (Fsyntax_table_p): New forward static decl.
5587 (skip_chars): Remove duplicate decl.
5588 * textprop.c (Fprevious_property_change): New forward static decl.
5589 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5590 Now internal.
5591 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5592 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5593
5594 * editfns.c (Fformat): Remove unreachable code.
5595
5596 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5597
5598 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5599 change. (Bug#8496)
5600
5601 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5602
5603 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5604 when at ZV. (Bug#8487)
5605
5606 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5607
5608 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5609 (Bug#8437)
5610 * keyboard.c (parse_tool_bar_item): Likewise.
5611 * sound.c (sound_cleanup, alsa_close): Likewise.
5612 * termcap.c (tgetent): Likewise.
5613 * xfns.c (x_default_font_parameter): Likewise.
5614 * xsettings.c (read_and_apply_settings): Likewise.
5615
5616 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5617 (overrun_check_free): Protoize.
5618
5619 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5620
5621 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5622 since callers should never pass a negative size.
5623 Change the signature to match that of plain 'read' and 'write'; see
5624 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5625 * lisp.h: Update prototypes of emacs_write and emacs_read.
5626
5627 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5628
5629 * xdisp.c (redisplay_window): Don't try to determine the character
5630 position of the scroll margin if the window start point w->startp
5631 is outside the buffer's accessible region. (Bug#8468)
5632
5633 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5634
5635 Fix write-region and its subroutines for buffers > 2GB.
5636 * fileio.c (a_write, e_write): Modify declaration of arguments and
5637 local variables to support buffers larger than 2GB.
5638 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5639
5640 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5641 argument, local variables, and return value.
5642
5643 * lisp.h: Update prototypes of emacs_write and emacs_read.
5644
5645 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5646
5647 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5648
5649 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5650
5651 Fix more problems found by GCC 4.6.0's static checks.
5652
5653 * xdisp.c (vmessage): Use a better test for character truncation.
5654
5655 * charset.c (load_charset_map): <, not <=, for optimization,
5656 and to avoid potential problems with integer overflow.
5657 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5658 * casetab.c (set_identity, shuffle): Likewise.
5659 * editfns.c (Fformat): Likewise.
5660 * syntax.c (skip_chars): Likewise.
5661
5662 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5663 This also lets GCC 4.6.0 generate slightly better loop code.
5664
5665 * callint.c (Fcall_interactively): <, not <=, for optimization.
5666 (Fcall_interactively): Count the number of arguments produced,
5667 not the number of arguments given. This is simpler and lets GCC
5668 4.6.0 generate slightly better code.
5669
5670 * ftfont.c: Distingish more carefully between FcChar8 and char.
5671 The previous code passed unsigned char * to a functions like
5672 strlen and xstrcasecmp that expect char *, which does not
5673 conform to the C standard.
5674 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5675 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5676 char * when the C standard requires it.
5677
5678 * keyboard.c (read_char): Remove unused var.
5679
5680 * eval.c: Port to Windows vsnprintf (Bug#8435).
5681 Include <limits.h>.
5682 (SIZE_MAX): Define if the headers do not.
5683 (verror): Do not give up if vsnprintf returns a negative count.
5684 Instead, grow the buffer. This ports to Windows vsnprintf, which
5685 does not conform to C99. Problem reported by Eli Zaretskii.
5686 Also, simplify the allocation scheme, by avoiding the need for
5687 calling realloc, and removing the ALLOCATED variable.
5688
5689 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5690
5691 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5692 But keep the doprint source code for now, as we might revamp it
5693 and use it again (Bug#8435).
5694 * lisp.h (doprnt): Remove.
5695 * Makefile.in (base_obj): Remove doprnt.o.
5696 * deps.mk (doprnt.o): Remove.
5697
5698 error: Print 32- and 64-bit integers portably (Bug#8435).
5699 Without this change, on typical 64-bit hosts error ("...%d...", N)
5700 was used to print both 32- and 64-bit integers N, which relied on
5701 undefined behavior.
5702 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5703 New macro.
5704 * lisp.h (error, verror): Mark as printf-like functions.
5705 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5706 Report overflow in size calculations when allocating printf buffer.
5707 Do not truncate output string at its first null byte.
5708 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5709 Truncate the output at a character boundary, since vsnprintf does not
5710 do that.
5711 * charset.c (check_iso_charset_parameter): Convert internal
5712 character to string before calling 'error', since %c now has the
5713 printf meaning.
5714 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5715 overflow when computing char to be passed to 'error'. Do not
5716 pass Lisp_Object to 'error'; pass the integer instead.
5717 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5718 formatted with plain %d.
5719
5720 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5721
5722 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5723
5724 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5725
5726 * xterm.c (x_catch_errors): Remove duplicate declaration.
5727
5728 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5729
5730 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5731
5732 2011-04-10 Jim Meyering <meyering@redhat.com>
5733
5734 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5735 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5736 return ssize_t not "int", and use size_t as the buffer length.
5737 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5738 * gnutls.h: Update declarations.
5739 * process.c (read_process_output): Use ssize_t, to match.
5740 (send_process): Likewise.
5741
5742 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5743
5744 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5745
5746 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5747
5748 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5749 Use unsigned char, to match FcChar8 type definition.
5750
5751 * xterm.c (handle_one_xevent):
5752 * xmenu.c (create_and_show_popup_menu):
5753 * xselect.c (x_decline_selection_request)
5754 (x_reply_selection_request): Avoid type-punned deref of X events.
5755
5756 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5757
5758 Fix some uses of `int' instead of EMACS_INT.
5759 * search.c (string_match_1, fast_string_match)
5760 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5761 (scan_buffer, find_next_newline_no_quit)
5762 (find_before_next_newline, search_command, Freplace_match)
5763 (Fmatch_data): Make some `int' variables be EMACS_INT.
5764
5765 * xdisp.c (display_count_lines): 3rd argument and return value now
5766 EMACS_INT. All callers changed.
5767 (pint2hrstr): Last argument is now EMACS_INT.
5768
5769 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5770 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5771 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5772 (decode_coding_utf_16, decode_coding_emacs_mule)
5773 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5774 (decode_coding_ccl, decode_coding_charset)
5775 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5776 (decode_coding_iso_2022, decode_coding_emacs_mule)
5777 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5778 <char_offset, last_offset>: Declare EMACS_INT.
5779 (encode_coding_utf_8, encode_coding_utf_16)
5780 (encode_coding_emacs_mule, encode_invocation_designation)
5781 (encode_designation_at_bol, encode_coding_iso_2022)
5782 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5783 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5784 Declare EMACS_INT.
5785 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5786 (encode_invocation_designation): Last argument P_NCHARS is now
5787 EMACS_INT.
5788 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5789 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5790
5791 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5792 All users changed.
5793
5794 * ccl.c (Fccl_execute_on_string): Declare some variables
5795 EMACS_INT.
5796
5797 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5798
5799 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5800
5801 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5802
5803 * process.c (Fformat_network_address): Doc fix.
5804
5805 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5806
5807 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5808
5809 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5810
5811 * keyboard.c (read_char): Call Lisp function help-form-show,
5812 instead of using internal_with_output_to_temp_buffer.
5813 (Qhelp_form_show): New var.
5814 (syms_of_keyboard): Use DEFSYM macro.
5815
5816 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5817
5818 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5819
5820 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5821
5822 * process.c (Flist_processes): Remove to Lisp.
5823 (list_processes_1): Delete.
5824
5825 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5826
5827 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5828
5829 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5830
5831 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5832
5833 Fix more problems found by GCC 4.6.0's static checks.
5834
5835 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5836
5837 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5838
5839 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5840
5841 * xdisp.c (vmessage): Mark as a printf-like function.
5842
5843 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5844
5845 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5846
5847 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5848 printf-like functions.
5849 (tiff_load): Add casts to remove these marks before passing them
5850 to system-supplied API.
5851
5852 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5853
5854 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5855 This avoids several warnings with gcc -Wstrict-overflow.
5856 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5857 directly, rather than having caller test rule sign. This avoids
5858 some unnecessary tests.
5859 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5860 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5861 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5862
5863 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5864 (xfont_open): Avoid unnecessary tests.
5865
5866 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5867
5868 * composite.h, composite.c (composition_gstring_put_cache):
5869 Use EMACS_INT, not int, for length.
5870
5871 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5872 breaking out part of COMPOSITION_DECODE_RULE.
5873 (COMPOSITION_DECODE_RULE): Use it.
5874 * composite.c (get_composition_id): Remove unused local vars,
5875 by using the new macro.
5876
5877 * textprop.c (set_text_properties_1): Change while to do-while,
5878 since the condition is always true at first.
5879
5880 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5881 (interval_deletion_adjustment): Return unsigned value.
5882 All uses changed.
5883
5884 * process.c (list_processes_1, create_pty, read_process_output):
5885 (exec_sentinel): Remove vars that were set but not used.
5886 (create_pty): Remove unnecessary "volatile"s.
5887 (Fnetwork_interface_info): Avoid possibility of int overflow.
5888 (read_process_output): Do adaptive read buffering even if carryover.
5889 (read_process_output): Simplify nbytes computation if buffered.
5890
5891 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5892
5893 * syntax.c (scan_words): Remove var that was set but not used.
5894 (update_syntax_table): Use unsigned instead of int.
5895
5896 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5897 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5898 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5899
5900 * print.c (print_error_message): Avoid int overflow.
5901
5902 * font.c (font_list_entities): Redo for clarity,
5903 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5904
5905 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5906 (font_score): Avoid potential overflow in diff calculation.
5907
5908 * fns.c (substring_both): Remove var that is set but not used.
5909 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5910
5911 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5912
5913 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5914 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5915 can always succeed if overflow has undefined behavior.
5916
5917 * search.c (boyer_moore, wordify): Remove vars set but not used.
5918 (wordify): Omit three unnecessary tests.
5919
5920 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5921 All callers changed. This avoids the need for an unused var.
5922
5923 * casefiddle.c (casify_region): Remove var that is set but not used.
5924
5925 * dired.c (file_name_completion): Remove var that is set but not used.
5926
5927 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5928
5929 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5930 (Finsert_file_contents): Remove unnecessary code checking fd.
5931
5932 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5933 Check for integer overflow on size calculations.
5934
5935 * buffer.c (Fprevious_overlay_change): Remove var that is set
5936 but not used.
5937
5938 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5939 Remove vars that are set but not used.
5940 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5941 (timer_check_2): Mark vars as initialized.
5942
5943 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5944
5945 * image.c (lookup_image): Remove var that is set but not used.
5946 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5947
5948 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5949 that are set but not used.
5950
5951 * xfns.c (make_invisible_cursor): Don't return garbage
5952 if XCreateBitmapFromData fails (Bug#8410).
5953
5954 * xselect.c (x_get_local_selection, x_handle_property_notify):
5955 Remove vars that are set but not used.
5956
5957 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5958 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5959
5960 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5961 Remove var that is set but not used.
5962 (scroll_bar_windows_size): Now size_t, not int.
5963 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5964 Check for overflow.
5965
5966 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5967 (map_tty_color) [!defined MSDOS]: Likewise.
5968
5969 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5970
5971 * coding.c: Remove vars that are set but not used.
5972 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5973 All callers changed.
5974 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5975 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5976 (decode_coding_charset): Remove vars that are set but not used.
5977
5978 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5979 that is set but not used.
5980
5981 * print.c (print_object): Remove var that is set but not used.
5982
5983 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5984 The gnulib version avoids calling malloc in the usual case,
5985 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5986 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5987 * filelock.c (current_lock_owner): Likewise.
5988 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5989 * sysdep.c: Include allocator.h, careadlinkat.h.
5990 (emacs_no_realloc_allocator): New static constant.
5991 (emacs_readlink): New function.
5992 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5993 ../lib/careadlinkat.h.
5994
5995 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5996
5997 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5998 first non-nil return value).
5999
6000 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6001
6002 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6003 if not defined (Bug#8403).
6004
6005 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6006
6007 * xdisp.c (display_count_lines): Remove parameter `start',
6008 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6009 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6010 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6011 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6012 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6013 and thereabouts. All callers changed.
6014 (get_per_char_metric): Remove parameter `f', unused since
6015 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6016
6017 2011-04-02 Jim Meyering <meyering@redhat.com>
6018
6019 do not dereference NULL upon failed strdup
6020 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6021 (ns_get_family): Likewise.
6022
6023 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6024
6025 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6026
6027 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6028
6029 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6030 later (Bug#8403).
6031
6032 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6033
6034 Add lexical binding.
6035
6036 * window.c (Ftemp_output_buffer_show): New fun.
6037 (Fsave_window_excursion):
6038 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6039
6040 * lread.c (lisp_file_lexically_bound_p): New function.
6041 (Fload): Bind Qlexical_binding.
6042 (readevalloop): Remove `evalfun' arg.
6043 Bind Qinternal_interpreter_environment.
6044 (Feval_buffer): Bind Qlexical_binding.
6045 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6046 Mark as dynamic.
6047 (syms_of_lread): Declare `lexical-binding'.
6048
6049 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6050
6051 * keyboard.c (eval_dyn): New fun.
6052 (menu_item_eval_property): Use it.
6053
6054 * image.c (parse_image_spec): Use Ffunctionp.
6055
6056 * fns.c (concat, mapcar1): Accept byte-code-functions.
6057
6058 * eval.c (Fsetq): Handle lexical vars.
6059 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6060 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6061 (FletX, Flet): Obey lexical binding.
6062 (Fcommandp): Handle closures.
6063 (Feval): New `lexical' arg.
6064 (eval_sub): New function extracted from Feval. Use it almost
6065 everywhere where Feval was used. Look up vars in lexical env.
6066 Handle closures.
6067 (Ffunctionp): Move from subr.el.
6068 (Ffuncall): Handle closures.
6069 (apply_lambda): Remove `eval_flags'.
6070 (funcall_lambda): Handle closures and new byte-code-functions.
6071 (Fspecial_variable_p): New function.
6072 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6073 but without exporting it to Lisp.
6074
6075 * doc.c (Fdocumentation, store_function_docstring):
6076 * data.c (Finteractive_form): Handle closures.
6077
6078 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6079 interactive spec.
6080
6081 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6082 New byte-codes.
6083 (exec_byte_code): New function extracted from Fbyte_code to handle new
6084 calling convention for byte-code-functions. Add new byte-codes.
6085
6086 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6087
6088 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6089
6090 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6091
6092 * xdisp.c (redisplay_internal): Fix prototype.
6093
6094 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6095
6096 * xdisp.c (SCROLL_LIMIT): New macro.
6097 (try_scrolling): Use it when setting scroll_limit.
6098 Limit scrolling to 100 screen lines.
6099 (redisplay_window): Even when falling back on "recentering",
6100 position point in the window according to scroll-conservatively,
6101 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6102
6103 (try_scrolling): When point is above the window, allow searching
6104 as far as scroll_max, or one screenful, to compute vertical
6105 distance from PT to the scroll margin position. This prevents
6106 try_scrolling from unnecessarily failing when
6107 scroll-conservatively is set to a value slightly larger than the
6108 window height. Clean up the case of PT below the margin at bottom
6109 of window: scroll_max can no longer be INT_MAX. When aggressive
6110 scrolling is in use, don't let point enter the opposite scroll
6111 margin as result of the scroll.
6112 (syms_of_xdisp) <scroll-conservatively>: Document the
6113 threshold of 100 lines for never-recentering scrolling.
6114
6115 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6116
6117 * dispextern.h (move_it_by_lines):
6118 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6119 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6120 (message_log_check_duplicate): Remove parameters `prev_bol' and
6121 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6122 (redisplay_internal): Remove parameter `preserve_echo_area',
6123 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6124
6125 * indent.c (Fvertical_motion):
6126 * window.c (window_scroll_pixel_based, Frecenter):
6127 Don't pass `need_y_p' to `move_it_by_lines'.
6128
6129 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6130
6131 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6132 steal a few bits to be more compact.
6133 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6134 Remove unneeded casts.
6135
6136 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6137
6138 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6139
6140 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6141 binding" message (bug#7967).
6142
6143 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6144
6145 Fix more problems found by GCC 4.6.0's static checks.
6146
6147 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6148 Remove unused local var.
6149
6150 * editfns.c (Fmessage_box): Remove unused local var.
6151
6152 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6153 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6154 Omit unused local vars.
6155 * window.c (shrink_windows): Omit unused local var.
6156 * menu.c (digest_single_submenu): Omit unused local var.
6157 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6158 Omit unused local var.
6159
6160 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6161 Don't assume string length fits in int.
6162 (keyremap_step, read_key_sequence): Use size_t for sizes.
6163 (read_key_sequence): Don't check last_real_key_start redundantly.
6164
6165 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6166 instead of alloca (Bug#8344).
6167
6168 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6169 (Fbacktrace_frame): Don't assume nframes fits in int.
6170
6171 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6172
6173 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6174 concerns.
6175
6176 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6177
6178 * cm.c (calccost): Turn while-do into do-while, for clarity.
6179
6180 * keyboard.c (syms_of_keyboard): Use the same style as later
6181 in this function when indexing through an array. This also
6182 works around GCC bug 48267.
6183
6184 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6185
6186 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6187
6188 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6189 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6190
6191 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6192 This avoids undefined behavior on integer overflow, and is a bit
6193 more convenient anyway since it is compared to a size_t variable.
6194
6195 Variadic C functions now count arguments with size_t, not int.
6196 This avoids an unnecessary limitation on 64-bit machines, which
6197 caused (substring ...) to crash on large vectors (Bug#8344).
6198 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6199 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6200 All variadic functions and their callers changed accordingly.
6201 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6202 * data.c (arith_driver, float_arith_driver): Likewise.
6203 * editfns.c (general_insert_function): Likewise.
6204 * eval.c (struct backtrace.nargs, interactive_p)
6205 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6206 (funcall_lambda, mark_backtrace): Likewise.
6207 * fns.c (concat): Likewise.
6208 * frame.c (x_set_frame_parameters): Likewise.
6209 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6210 0 if not found, not -1. All callers changed.
6211
6212 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6213 (stack_copy_size): Now size_t, not int.
6214 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6215
6216 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6217
6218 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6219 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6220 All callers changed.
6221
6222 * lisp.h (multibyte_char_to_unibyte):
6223 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6224 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6225 * character.h (CHAR_TO_BYTE8):
6226 * cmds.c (internal_self_insert):
6227 * editfns.c (general_insert_function):
6228 * keymap.c (push_key_description):
6229 * search.c (Freplace_match):
6230 * xdisp.c (message_dolog, set_message_1): All callers changed.
6231
6232 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6233
6234 * keyboard.c (safe_run_hook_funcall): New function.
6235 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6236 don't set the hook to nil, but remove the offending function instead.
6237 (Qcommand_hook_internal): Remove, unused.
6238 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6239 Vcommand_hook_internal.
6240
6241 * eval.c (enum run_hooks_condition): Remove.
6242 (funcall_nil, funcall_not): New functions.
6243 (run_hook_with_args): Call each function through a `funcall' argument.
6244 Remove `cond' argument, now redundant.
6245 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6246 (Frun_hook_with_args_until_failure): Adjust accordingly.
6247 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6248
6249 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6250
6251 * dispextern.h (string_buffer_position): Remove declaration.
6252
6253 * print.c (strout): Remove parameter `multibyte', unused since
6254 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6255
6256 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6257 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6258 All callers changed.
6259
6260 * w32.c (_wsa_errlist): Use braces for struct initializers.
6261
6262 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6263 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6264 All callers changed.
6265 (string_buffer_position): Likewise. Also, make static (it's never
6266 used outside xdisp.c).
6267 (cursor_row_p): Remove parameter `w', unused since
6268 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6269 (decode_mode_spec): Remove parameter `precision', introduced during
6270 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6271 All callers changed.
6272
6273 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6274
6275 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6276
6277 2011-03-27 Anders Lindgren <andlind@gmail.com>
6278
6279 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6280 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6281 (ns_update_auto_hide_menu_bar): New functions.
6282 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6283 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6284 ns_constrain_all_frames.
6285 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6286 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6287
6288 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6289
6290 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6291
6292 2011-03-27 Glenn Morris <rgm@gnu.org>
6293
6294 * syssignal.h: Replace RETSIGTYPE with void.
6295 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6296 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6297 Replace SIGTYPE with void everywhere.
6298 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6299 * s/template.h (SIGTYPE): Remove commented out definition.
6300
6301 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6302
6303 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6304 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6305
6306 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6307
6308 * w32.c (read_unc_volume): Use parameter `henum', instead of
6309 global variable `wget_enum_handle'.
6310
6311 * keymap.c (describe_vector): Remove parameters `indices' and
6312 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6313 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6314
6315 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6316
6317 * keyboard.c (timer_check): Remove parameter `do_it_now',
6318 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6319 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6320 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6321
6322 * keyboard.c (read_char):
6323 * w32menu.c (w32_menu_display_help):
6324 * xmenu.c (show_help_event, menu_help_callback):
6325 Adjust calls to `show_help_echo'.
6326
6327 * gtkutil.c (xg_maybe_add_timer):
6328 * keyboard.c (readable_events):
6329 * process.c (wait_reading_process_output):
6330 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6331
6332 * insdel.c (adjust_markers_gap_motion):
6333 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6334 (gap_left, gap_right): Don't call it.
6335
6336 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6337
6338 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6339 incurred during fontification.
6340
6341 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6342
6343 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6344 (DEFVAR_PER_BUFFER): Don't pass it.
6345
6346 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6347 (scrolling_window): Don't pass it.
6348
6349 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6350
6351 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6352
6353 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6354 and `suffix'.
6355 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6356 of variables specific to SELinux and computation of `encoded_absname'.
6357
6358 * image.c (XPutPixel): Remove unused variable `height'.
6359
6360 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6361
6362 * unexw32.c (get_section_info): Remove unused variable `section'.
6363
6364 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6365 (system_process_attributes): Remove unused variable `sess'.
6366 (sys_read): Remove unused variable `err'.
6367
6368 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6369 (w32_wnd_proc): Remove unused variable `isdead'.
6370 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6371 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6372 (x_create_tip_frame): Remove unused variable `tem'.
6373
6374 * w32inevt.c (w32_console_read_socket):
6375 Remove unused variable `no_events'.
6376
6377 * w32term.c (x_draw_composite_glyph_string_foreground):
6378 Remove unused variable `width'.
6379
6380 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6381
6382 * w32term.c (x_set_glyph_string_clipping):
6383 Don't pass uninitialized region to CombineRgn.
6384
6385 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6386
6387 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6388 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6389 (Fx_close_connection): Remove unused variable `i'.
6390
6391 * w32font.c (w32font_draw): Return number of glyphs.
6392 (w32font_open_internal): Remove unused variable `i'.
6393 (w32font_driver): Add missing initializer.
6394
6395 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6396 (fill_in_menu): Remove unused variable `items_added'.
6397
6398 * w32term.c (last_mouse_press_frame): Remove static global variable.
6399 (w32_clip_to_row): Remove unused variable `f'.
6400 (x_delete_terminal): Remove unused variable `i'.
6401
6402 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6403 (NOTHING): Remove unused static global variable.
6404 (uniscribe_check_otf): Remove unused variable `table'.
6405 (uniscribe_font_driver): Add missing initializers.
6406
6407 2011-03-23 Julien Danjou <julien@danjou.info>
6408
6409 * term.c (Fsuspend_tty, Fresume_tty):
6410 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6411 * window.c (temp_output_buffer_show):
6412 * insdel.c (signal_before_change):
6413 * frame.c (Fhandle_switch_frame):
6414 * fileio.c (Fdo_auto_save):
6415 * emacs.c (Fkill_emacs):
6416 * editfns.c (save_excursion_restore):
6417 * cmds.c (internal_self_insert):
6418 * callint.c (Fcall_interactively):
6419 * buffer.c (Fkill_all_local_variables):
6420 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6421 Use Frun_hooks.
6422 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6423 unconditionnaly since it does the check itself.
6424
6425 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6426
6427 Fix more problems found by GCC 4.5.2's static checks.
6428
6429 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6430 the first time through the loop, since we know p0 < p1 then.
6431 This also avoids a gcc -Wstrict-overflow warning.
6432
6433 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6434 leading to a memory leak, possible in functions like
6435 load_charset_map_from_file that can allocate an unbounded number
6436 of objects (Bug#8318).
6437
6438 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6439 that could (at least in theory) be that large.
6440
6441 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6442 This is less likely to overflow, and avoids undefined behavior if
6443 overflow does occur. All callers changed. Use strtoul to scan
6444 for the unsigned long integer.
6445 (pint2hrstr): Simplify and tune code slightly.
6446 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6447
6448 * scroll.c (do_scrolling): Work around GCC bug 48228.
6449 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6450
6451 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6452 This also avoids a warning with gcc -Wstrict-overflow.
6453 (validate_x_resource_name): Simplify count usage.
6454 This also avoids a warning with gcc -Wstrict-overflow.
6455
6456 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6457 fail (Bug#8306).
6458
6459 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6460
6461 * process.c (Fmake_network_process): Use socklen_t, not int,
6462 where POSIX says socklen_t is required in portable programs.
6463 This fixes a porting bug on hosts like 64-bit HP-UX, where
6464 socklen_t is wider than int (Bug#8277).
6465 (Fmake_network_process, server_accept_connection):
6466 (wait_reading_process_output, read_process_output):
6467 Likewise.
6468
6469 * process.c: Rename or move locals to avoid shadowing.
6470 (list_processes_1, Fmake_network_process):
6471 (read_process_output_error_handler, exec_sentinel_error_handler):
6472 Rename or move locals.
6473 (Fmake_network_process): Define label "retry_connect" only if needed.
6474 (Fnetwork_interface_info): Fix pointer signedness.
6475 (process_send_signal): Add cast to avoid pointer signedness problem.
6476 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6477 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6478
6479 Make tparam.h and terminfo.c consistent.
6480 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6481 Include tparam.h instead, since it declares them.
6482 * cm.h (PC): Remove extern decl; tparam.h now does this.
6483 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6484 * terminfo.c: Include tparam.h, to check interfaces.
6485 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6486 (tparam): Adjust signature to match interface in tparam.h;
6487 this removes some undefined behavior. Check that outstring and len
6488 are zero, which they always are with Emacs.
6489 * tparam.h (PC, BC, UP): New extern decls.
6490
6491 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6492 (xftfont_open): Rename locals to avoid shadowing.
6493
6494 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6495 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6496 (OTF_TAG_SYM): Omit macro if not needed.
6497 (ftfont_list): Remove unused local.
6498 (get_adstyle_property, ftfont_pattern_entity):
6499 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6500 Rename locals to avoid shadowing.
6501
6502 * xfont.c (xfont_list_family): Mark var as initialized.
6503
6504 * xml.c (make_dom): Now static.
6505
6506 * composite.c (composition_compute_stop_pos): Rename local to
6507 avoid shadowing.
6508 (composition_reseat_it): Remove unused locals.
6509 (find_automatic_composition, composition_adjust_point): Likewise.
6510 (composition_update_it): Mark var as initialized.
6511 (find_automatic_composition): Mark vars as initialized,
6512 with a FIXME (Bug#8290).
6513
6514 character.h: Rename locals to avoid shadowing.
6515 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6516 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6517 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6518 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6519 to avoid shadowing.
6520
6521 * textprop.c (property_change_between_p): Remove; unused.
6522
6523 * intervals.c (interval_start_pos): Now static.
6524
6525 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6526
6527 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6528 Rename locals to avoid shadowing.
6529
6530 * sound.c (wav_play, au_play, Fplay_sound_internal):
6531 Fix pointer signedness.
6532 (alsa_choose_format): Remove unused local var.
6533 (wav_play): Initialize a variable to 0, to prevent undefined
6534 behavior (Bug#8278).
6535
6536 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6537
6538 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6539
6540 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6541 clobbering (Bug#8298).
6542 * sysdep.c (sys_subshell): Likewise.
6543 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6544
6545 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6546 This should get cleaned up, so that child_setup has the
6547 same signature on all platforms.
6548
6549 * callproc.c (call_process_cleanup): Now static.
6550 (relocate_fd): Rename locals to avoid shadowing.
6551
6552 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6553
6554 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6555 not to be necessary, and produces flickering.
6556
6557 2011-03-20 Glenn Morris <rgm@gnu.org>
6558
6559 * config.in: Remove file.
6560
6561 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6562
6563 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6564 are now in src/globals.h.
6565 (syms_of_minibuf): Remove spurious & from previous change.
6566
6567 2011-03-20 Leo <sdl.web@gmail.com>
6568
6569 * minibuf.c (completing-read-function): New variable.
6570 (completing-read-default): Rename from completing-read.
6571 (completing-read): Call completing-read-function.
6572
6573 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6574
6575 * xfaces.c (Fx_load_color_file):
6576 Read color file from absolute filename (bug#8250).
6577
6578 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6579
6580 * makefile.w32-in: Update dependencies.
6581
6582 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6583
6584 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6585
6586 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6587
6588 Fix more problems found by GCC 4.5.2's static checks.
6589
6590 * process.c (make_serial_process_unwind, send_process_trap):
6591 (sigchld_handler): Now static.
6592
6593 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6594 That way, the code declares only the vars that it needs.
6595 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6596 * s/cygwin.h (PTY_ITERATION): Likewise.
6597 * s/darwin.h (PTY_ITERATION): Likewise.
6598 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6599
6600 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6601 * process.c (allocate_pty): Don't declare stb unless it's needed.
6602
6603 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6604 (CONSTANTLIM): Remove; unused.
6605 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6606 Define only if needed.
6607
6608 * unexelf.c (unexec): Name an expression,
6609 to avoid gcc -Wbad-function-cast warning.
6610 Use a different way to cause a compilation error if anyone uses
6611 n rather than nn, a way that does not involve shadowing.
6612 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6613
6614 * deps.mk (unexalpha.o): Remove; unused.
6615
6616 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6617 * unexec.h: New file.
6618 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6619 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6620 Depend on unexec.h.
6621 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6622 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6623 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6624 Change as necessary to match prototype in unexec.h.
6625
6626 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6627 shadowing.
6628 (back_comment, skip_chars): Mark vars as initialized.
6629
6630 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6631 Rename locals to avoid shadowing.
6632
6633 * lread.c (read1): Rewrite so as not to use empty "else".
6634 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6635
6636 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6637
6638 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6639 warning when compiling print.c.
6640
6641 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6642 instead of using an uninitialized var.
6643 (font_sort_entities): Mark var as initialized.
6644
6645 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6646
6647 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6648 pointers to constants.
6649 (font_parse_fcname): Remove unused vars.
6650 (font_delete_unmatched): Now static.
6651 (font_get_spec): Remove; unused.
6652 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6653 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6654 Rename or move locals to avoid shadowing.
6655
6656 * fns.c (require_nesting_list, require_unwind): Now static.
6657 (Ffillarray): Rename locals to avoid shadowing.
6658
6659 * floatfns.c (domain_error2): Define only if needed.
6660 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6661
6662 * alloc.c (mark_backtrace): Move decl from here ...
6663 * lisp.h: ... to here, so that it can be checked.
6664
6665 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6666 (Fdefvar): Rewrite so as not to use empty "else".
6667 (lisp_indirect_variable): Name an expression,
6668 to avoid gcc -Wbad-function-cast warning.
6669 (Fdefvar): Rename locals to avoid shadowing.
6670
6671 * callint.c (quotify_arg, quotify_args): Now static.
6672 (Fcall_interactively): Rename locals to avoid shadowing.
6673 Use const pointer when appropriate.
6674
6675 * lisp.h (get_system_name, get_operating_system_release):
6676 Move decls here, to check interfaces.
6677 * process.c (get_operating_system_release): Move decl to lisp.h.
6678 * xrdb.c (get_system_name): Likewise.
6679 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6680 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6681 some of which prompt warnings from gcc -Wbad-function-cast.
6682 (Fformat_time_string, Fencode_time, Finsert_char):
6683 (Ftranslate_region_internal, Fformat):
6684 Rename or remove local vars to avoid shadowing.
6685 (Ftranslate_region_internal): Mark var as initialized.
6686
6687 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6688 avoid shadowing.
6689
6690 * lisp.h (eassert): Check that the argument compiles, even if
6691 ENABLE_CHECKING is not defined.
6692
6693 * data.c (Findirect_variable): Name an expression, to avoid
6694 gcc -Wbad-function-cast warning.
6695 (default_value, arithcompare, arith_driver, arith_error): Now static.
6696 (store_symval_forwarding): Rename local to avoid shadowing.
6697 (Fmake_variable_buffer_local, Fmake_local_variable):
6698 Mark variables as initialized.
6699 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6700
6701 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6702 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6703 Rename locals to avoid shadowing.
6704 (mark_stack): Move local variables into the #ifdef region where
6705 they're used.
6706 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6707 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6708 needed otherwise.
6709 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6710 (GC_STRING_CHARS): Remove; not used.
6711 (Fmemory_limit): Cast sbrk's returned value to char *.
6712
6713 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6714 avoids undefined behavior in theory.
6715
6716 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6717
6718 Use functions, not macros, for up- and down-casing (Bug#8254).
6719 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6720 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6721 to use the following functions instead of these macros.
6722 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6723 EMACS_INT, since callers assume the returned value fits in int.
6724 (upcase1): Likewise, for UPCASE_TABLE.
6725 (uppercasep, lowercasep, upcase): New static inline functions.
6726 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6727 the race-condition problem in the old DOWNCASE.
6728
6729 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6730 Rename locals to avoid shadowing.
6731 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6732 (regex_compile, re_search_2, re_match_2_internal):
6733 Remove unused local vars.
6734 (FREE_VAR): Rewrite so as not to use empty "else",
6735 which gcc can warn about.
6736 (regex_compile, re_match_2_internal): Mark locals as initialized.
6737 (RETALLOC_IF): Define only if needed.
6738 (WORDCHAR_P): Likewise. This one is never needed, but is used
6739 only in a comment talking about a compiler bug, so put inside
6740 the #if 0 of that comment.
6741 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6742 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6743 Remove; unused.
6744
6745 * search.c (boyer_moore): Rename locals to avoid shadowing.
6746 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6747 (PREV_CHAR_BOUNDARY): Likewise.
6748
6749 * search.c (simple_search): Remove unused var.
6750
6751 * dired.c (compile_pattern): Move decl from here ...
6752 * lisp.h: ... to here, so that it can be checked.
6753 (struct re_registers): New forward decl.
6754
6755 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6756
6757 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6758 All uses changed.
6759 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6760 Rename locals to avoid shadowing.
6761 (Fvertical_motion): Mark locals as initialized.
6762
6763 * casefiddle.c (casify_object, casify_region): Now static.
6764 (casify_region): Mark local as initialized.
6765
6766 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6767
6768 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6769 New macros, so that the caller can use some names other than
6770 gcpro1, gcpro2, etc.
6771 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6772 of the new macros.
6773 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6774 argument, for consistency with GCPRO2_VAR, etc: it is now the
6775 prefix of the variable, not the variable itself. All uses
6776 changed.
6777 * dired.c (directory_files_internal, file_name_completion):
6778 Rename locals to avoid shadowing.
6779
6780 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6781 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6782 dired.c's scmp function, had undefined behavior.
6783 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6784 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6785 * buffer.h: ... to here, because these macros use current_buffer,
6786 and the new implementation with inline functions needs to have
6787 current_buffer in scope now, rather than later when the macros
6788 are used.
6789 (downcase, upcase1): New static inline functions.
6790 (DOWNCASE, UPCASE1): Reimplement using these functions.
6791 This avoids undefined behavior in expressions like
6792 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6793 from race conditions in accessing the global variables
6794 case_temp1 and case_temp2.
6795 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6796 * lisp.h (case_temp1, case_temp2): Remove their decls.
6797 * character.h (ASCII_CHAR_P): Move from here ...
6798 * lisp.h: ... to here, so that the inline functions mentioned
6799 above can use them.
6800
6801 * dired.c (directory_files_internal_unwind): Now static.
6802
6803 * fileio.c (file_name_as_directory, directory_file_name):
6804 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6805 Now static.
6806 (file_name_as_directory): Use const pointers when appropriate.
6807 (Fexpand_file_name): Likewise. In particular, newdir might
6808 point at constant storage, so make it a const pointer.
6809 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6810 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6811 signedness issues.
6812 (Fset_file_times, Finsert_file_contents, auto_save_error):
6813 Rename locals to avoid shadowing.
6814
6815 * minibuf.c (choose_minibuf_frame_1): Now static.
6816 (Ftry_completion, Fall_completions): Rename or remove locals
6817 to avoid shadowing.
6818
6819 * marker.c (bytepos_to_charpos): Remove; unused.
6820
6821 * lisp.h (verify_bytepos, count_markers): New decls,
6822 so that gcc does not warn that these functions aren't declared.
6823
6824 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6825 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6826 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6827 (copy_text): Remove unused local var.
6828
6829 * filelock.c (within_one_second): Now static.
6830 (lock_file_1): Rename local to avoid shadowing.
6831
6832 * buffer.c (fix_overlays_before): Mark locals as initialized.
6833 (fix_start_end_in_overlays): Likewise. This function should be
6834 simplified by using pointers-to-pointers, but that's a different
6835 matter.
6836 (switch_to_buffer_1): Now static.
6837 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6838 (report_overlay_modification): Rename locals to avoid shadowing.
6839
6840 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6841 Fix pointer signedness issue.
6842 (sys_subshell): Mark local as volatile if checking for lint,
6843 to suppress a gcc -Wclobbered warning that does not seem to be right.
6844 (MAXPATHLEN): Define only if needed.
6845
6846 * process.c (serial_open, serial_configure): Move decls from here ...
6847 * systty.h: ... to here, so that they can be checked.
6848
6849 * fns.c (get_random, seed_random): Move extern decls from here ...
6850 * lisp.h: ... to here, so that they can be checked.
6851
6852 * sysdep.c (reset_io): Now static.
6853 (wait_for_termination_signal): Remove; unused.
6854
6855 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6856 (copy_keymap_item, append_key, push_text_char_description):
6857 Now static.
6858 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6859 (DENSE_TABLE_SIZE): Remove; unused.
6860 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6861 (describe_map_tree):
6862 Rename locals to avoid shadowing.
6863
6864 * keyboard.c: Declare functions static if they are not used elsewhere.
6865 (echo_char, echo_dash, cmd_error, top_level_2):
6866 (poll_for_input, handle_async_input): Now static.
6867 (read_char, kbd_buffer_get_event, make_lispy_position):
6868 (make_lispy_event, make_lispy_movement, apply_modifiers):
6869 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6870 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6871 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6872 (read_key_sequence, read_char): Mark locals as initialized.
6873 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6874
6875 * keyboard.h (make_ctrl_char): New decl.
6876 (mark_kboards): Move decl here ...
6877 * alloc.c (mark_kboards): ... from here.
6878
6879 * lisp.h (force_auto_save_soon): New decl.
6880
6881 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6882 (DEFINE_DUMMY_FUNCTION): New macro.
6883 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6884 Use it.
6885 (main): Add casts to avoid warnings
6886 if GCC considers string literals to be constants.
6887
6888 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6889
6890 * dbusbind.c: Pointer signedness fixes.
6891 (xd_signature, xd_append_arg, xd_initialize):
6892 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6893 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6894 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6895 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6896
6897 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6898 if GCC considers string literals to be constants.
6899 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6900
6901 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6902
6903 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6904 (print_preprocess, print_object): New macro to fix last change.
6905
6906 * print.c (print_preprocess): Don't forget font objects.
6907
6908 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6909
6910 * emacs.c (USAGE3): Doc fixes.
6911
6912 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6913
6914 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6915 structure.
6916
6917 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6918
6919 * lisp.h (VWindow_system, Qfile_name_history):
6920 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6921 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6922 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6923
6924 * w32select.c: Don't #include "keyboard.h".
6925 (run_protected): Add extern declaration for waiting_for_input.
6926
6927 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6928 * w32console.c (detect_input_pending, read_input_pending)
6929 (encode_terminal_code):
6930 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6931 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6932 (w32_system_caret_y, Qfile_name_history):
6933 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6934 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6935 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6936 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6937 * w32proc.c (Qlocal, report_file_error):
6938 * w32term.c (Vwindow_system, updating_frame):
6939 * w32uniscribe.c (initialized, uniscribe_font_driver):
6940 Remove unneeded extern declarations.
6941
6942 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6943
6944 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6945
6946 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6947
6948 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6949 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6950 These macros can no longer be used for assignment.
6951
6952 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6953 Assign struct members directly, instead of using BUF_BEGV etc.
6954 (record_buffer_markers, fetch_buffer_markers): New functions for
6955 recording and fetching special buffer markers.
6956 (set_buffer_internal_1, set_buffer_temp): Use them.
6957
6958 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6959
6960 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6961
6962 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6963 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6964
6965 * xdisp.c (hscroll_window_tree):
6966 (reconsider_clip_changes): Use PT instead of BUF_PT.
6967
6968 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6969
6970 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6971 $(EMACS_ROOT)/lib/intprops.h.
6972
6973 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6974
6975 Fix more problems found by GCC 4.5.2's static checks.
6976
6977 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6978 to unsigned char * to avoid compiler diagnostic.
6979 (xg_free_frame_widgets): Make it clear that a local variable is
6980 needed only if USE_GTK_TOOLTIP.
6981 (gdk_window_get_screen): Make it clear that this macro is needed
6982 only if USE_GTK_TOOLTIP.
6983 (int_gtk_range_get_value): New function, which avoids a diagnostic
6984 from gcc -Wbad-function-cast.
6985 (xg_set_toolkit_scroll_bar_thumb): Use it.
6986 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6987 diagnostic from gcc -Wbad-function-cast.
6988 (get_utf8_string, xg_get_file_with_chooser):
6989 Rename locals to avoid shadowing.
6990 (create_dialog): Move locals to avoid shadowing.
6991
6992 * xgselect.c (xg_select): Remove unused var.
6993
6994 * image.c (four_corners_best): Mark locals as initialized.
6995 (gif_load): Initialize transparent_p to zero (Bug#8238).
6996 Mark another local as initialized.
6997 (my_png_error, my_error_exit): Mark with NO_RETURN.
6998
6999 * image.c (clear_image_cache): Now static.
7000 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7001 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7002 (x_edge_detection): Remove unnecessary cast that
7003 gcc -Wbad-function-cast diagnoses.
7004 (gif_load): Fix pointer signedness.
7005 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7006 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7007
7008 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7009
7010 Improve quality of tests for time stamp overflow.
7011 For example, without this patch (encode-time 0 0 0 1 1
7012 1152921504606846976) returns the obviously-bogus value (-948597
7013 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7014 reports time overflow. See
7015 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7016 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7017 * editfns.c: Include limits.h and intprops.h.
7018 (TIME_T_MIN, TIME_T_MAX): New macros.
7019 (time_overflow): Move earlier, to before first use.
7020 (hi_time, lo_time): New functions, for an accurate test for
7021 out-of-range times.
7022 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7023 (Fget_internal_run_time): Don't assume time_t fits in int.
7024 (make_time): Use list2 instead of Fcons twice.
7025 (Fdecode_time): More accurate test for out-of-range times.
7026 (check_tm_member): New function.
7027 (Fencode_time): Use it, to test for out-of-range times.
7028 (lisp_time_argument): Don't rely on undefined left-shift and
7029 right-shift behavior when checking for time stamp overflow.
7030
7031 * editfns.c (time_overflow): New function, refactoring common code.
7032 (Fformat_time_string, Fdecode_time, Fencode_time):
7033 (Fcurrent_time_string): Use it.
7034
7035 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7036 * dired.c (make_time): Move to ...
7037 * editfns.c (make_time): ... here.
7038 * systime.h: Note the move.
7039
7040 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7041
7042 * fringe.c (update_window_fringes): Remove unused variables.
7043
7044 * unexmacosx.c (copy_data_segment): Also copy __got section.
7045 (Bug#8223)
7046
7047 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7048
7049 * termcap.c [MSDOS]: Include "msdos.h".
7050 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7051 Constify `char *' arguments and their references according to
7052 prototypes in tparam.h.
7053
7054 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7055
7056 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7057 Adapt all references accordingly.
7058
7059 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7060
7061 2011-03-11 Tom Tromey <tromey@redhat.com>
7062
7063 * buffer.c (syms_of_buffer): Remove obsolete comment.
7064
7065 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7066
7067 * termhooks.h (encode_terminal_code): Declare prototype.
7068
7069 * msdos.c (encode_terminal_code): Don't declare prototype.
7070
7071 * term.c (encode_terminal_code): Now external again, used by
7072 w32console.c and msdos.c.
7073
7074 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7075 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7076
7077 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7078
7079 Fix some minor problems found by GCC 4.5.2's static checks.
7080
7081 * fringe.c (update_window_fringes): Mark locals as initialized
7082 (Bug#8227).
7083 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7084
7085 * alloc.c (mark_fringe_data): Move decl from here ...
7086 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7087 to check its interface.
7088 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7089
7090 * fontset.c (free_realized_fontset): Now static.
7091 (Fset_fontset_font): Rename local to avoid shadowing.
7092 (fontset_font): Mark local as initialized.
7093 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7094
7095 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7096
7097 * xselect.c (x_disown_buffer_selections): Remove; not used.
7098 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7099 (x_own_selection, Fx_disown_selection_internal): Rename locals
7100 to avoid shadowing.
7101 (x_handle_dnd_message): Remove local to avoid shadowing.
7102
7103 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7104 so that the caller can use some name other than gcpro1.
7105 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7106 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7107 (Fx_backspace_delete_keys_p):
7108 Use them to avoid shadowing, and rename vars to avoid shadowing.
7109 (x_decode_color, x_set_name, x_window): Now static.
7110 (Fx_create_frame): Add braces to silence GCC warning.
7111 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7112 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7113 Remove unused locals.
7114 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7115 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7116 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7117 macros.
7118
7119 * xterm.h (x_mouse_leave): New decl.
7120
7121 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7122 Remove unused functions.
7123 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7124 (x_calc_absolute_position): Now static.
7125 (XTread_socket): Don't define label "out" unless it's used.
7126 Don't declare local "event" unless it's used.
7127 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7128 unless they are used.
7129 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7130 (x_fatal_error_signal): Remove; not used.
7131 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7132 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7133 (x_error_catcher, x_connection_closed, x_error_handler):
7134 (x_error_quitter, xembed_send_message, x_iconify_frame):
7135 (my_log_handler): Rename locals to avoid shadowing.
7136 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7137 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7138
7139 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7140 Rename or move locals to avoid shadowing.
7141 (tty_defined_color, merge_face_heights): Now static.
7142 (free_realized_faces_for_fontset): Remove; not used.
7143 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7144 does not deduce is never used uninitialized.
7145 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7146 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7147
7148 * terminal.c (store_terminal_param): Now static.
7149
7150 * xmenu.c (menu_highlight_callback): Now static.
7151 (set_frame_menubar): Remove unused local.
7152 (xmenu_show): Rename parameter to avoid shadowing.
7153 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7154 since they might point to immutable storage.
7155 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7156 since it's unused otherwise.
7157
7158 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7159 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7160 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7161 avoids a gcc -Wuninitialized diagnostic.
7162 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7163 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7164 does not deduce are never used uninitialized.
7165
7166 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7167
7168 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7169 * window.c (window_loop, size_window):
7170 (run_window_configuration_change_hook, enlarge_window): Likewise.
7171
7172 * window.c (display_buffer): Now static.
7173 (size_window): Mark variables that gcc -Wuninitialized
7174 does not deduce are never used uninitialized.
7175 * window.h (check_all_windows): New decl, to forestall
7176 gcc -Wmissing-prototypes diagnostic.
7177 * dispextern.h (bidi_dump_cached_states): Likewise.
7178
7179 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7180 shadowing.
7181 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7182 Include <limits.h>.
7183 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7184 and to avoid gcc -Wuninitialized warning.
7185 (load_charset_map): Mark variables that gcc -Wuninitialized
7186 does not deduce are never used uninitialized.
7187 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7188
7189 * coding.c (coding_set_source, coding_set_destination):
7190 Use "else { /* comment */ }" rather than "else /* comment */;"
7191 for clarity, and to avoid gcc -Wempty-body warning.
7192 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7193 a block, when the outer 'i' will do.
7194 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7195 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7196 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7197 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7198 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7199 Rename locals to avoid shadowing.
7200 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7201 * coding.c (emacs_mule_char, encode_invocation_designation):
7202 Now static, since they're not used elsewhere.
7203 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7204 (decode_coding_object, encode_coding_object, detect_coding_system):
7205 (decode_coding_emacs_mule): Mark variables that gcc
7206 -Wuninitialized does not deduce are never used uninitialized.
7207 (detect_coding_iso_2022): Initialize a local variable that might
7208 be used uninitialized. Leave a FIXME because it's not clear that
7209 this initialization is needed. (Bug#8211)
7210 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7211 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7212 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7213 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7214 Remove unused macros.
7215
7216 * category.c (hash_get_category_set): Remove unused local var.
7217 (copy_category_table): Now static, since it's not used elsewhere.
7218 * character.c (string_count_byte8): Likewise.
7219
7220 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7221 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7222
7223 * chartab.c (copy_sub_char_table): Now static, since it's not used
7224 elsewhere.
7225 (sub_char_table_ref_and_range, char_table_ref_and_range):
7226 Rename locals to avoid shadowing.
7227 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7228
7229 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7230 (BIDI_BOB): Remove unused macro.
7231
7232 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7233 deduce are never used uninitialized.
7234 * term.c (encode_terminal_code): Likewise.
7235
7236 * term.c (encode_terminal_code): Now static. Remove unused local.
7237
7238 * tparam.h: New file.
7239 * term.c, tparam.h: Include it.
7240 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7241 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7242 Move these decls to tparam.h, and make them agree with what
7243 is actually in tparam.c. The previous trick of using incompatible
7244 decls in different modules does not conform to the C standard.
7245 All callers of tparam changed to use tparam's actual API.
7246 * tparam.c (tparam1, tparam, tgoto):
7247 Use const pointers where appropriate.
7248
7249 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7250 * cm.h (struct cm): Likewise.
7251 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7252 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7253 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7254 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7255 (turn_on_face, init_tty): Likewise.
7256 * termchar.h (struct tty_display_info): Likewise.
7257
7258 * term.c (term_mouse_position): Rename local to avoid shadowing.
7259
7260 * alloc.c (mark_ttys): Move decl from here ...
7261 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7262
7263 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7264
7265 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7266
7267 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7268
7269 * search.c (compile_pattern_1): Remove argument regp, unused since
7270 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7271 (compile_pattern): Don't pass it.
7272
7273 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7274
7275 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7276 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7277 for ! HAVE_GTK3.
7278 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7279
7280 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7281
7282 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7283 gdk_window_get_screen, gdk_window_get_geometry,
7284 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7285 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7286 (xg_get_pixbuf_from_pixmap): New function.
7287 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7288 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7289 Call xg_get_pixbuf_from_pixmap instead of
7290 gdk_pixbuf_get_from_drawable.
7291 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7292 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7293 (xg_check_special_colors): Use GtkStyleContext and its functions
7294 for HAVE_GTK3.
7295 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7296 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7297 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7298 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7299 Call gtk_widget_get_preferred_size.
7300 (xg_frame_resized): gdk_window_get_geometry only takes 5
7301 parameters.
7302 (xg_win_to_widget, xg_event_is_for_menubar):
7303 Call gdk_x11_window_lookup_for_display.
7304 (xg_set_widget_bg): New function.
7305 (delete_cb): New function.
7306 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7307 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7308 (xg_set_background_color): Call xg_set_widget_bg.
7309 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7310 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7311 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7312 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7313 if ! HAVE_GTK3.
7314 (update_frame_tool_bar): Call gtk_widget_hide.
7315 (xg_initialize): Use GDK_KEY_g.
7316
7317 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7318 if ! HAVE_GTK3
7319 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7320
7321 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7322 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7323 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7324
7325 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7326
7327 * w32xfns.c (select_palette): Check success of RealizePalette against
7328 GDI_ERROR, not zero.
7329
7330 See ChangeLog.11 for earlier changes.
7331
7332 ;; Local Variables:
7333 ;; coding: utf-8
7334 ;; End:
7335
7336 Copyright (C) 2011 Free Software Foundation, Inc.
7337
7338 This file is part of GNU Emacs.
7339
7340 GNU Emacs is free software: you can redistribute it and/or modify
7341 it under the terms of the GNU General Public License as published by
7342 the Free Software Foundation, either version 3 of the License, or
7343 (at your option) any later version.
7344
7345 GNU Emacs is distributed in the hope that it will be useful,
7346 but WITHOUT ANY WARRANTY; without even the implied warranty of
7347 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7348 GNU General Public License for more details.
7349
7350 You should have received a copy of the GNU General Public License
7351 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.