1 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
3 * nsterm.m (keyDown): Interpret flags without left/right bits
4 as the left key (Bug#11670).
6 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
8 Remove empty and useless init functions.
9 * lisp.h (init_character_once, init_fns, init_image)
10 (init_filelock, init_sound): Remove prototype.
11 * character.c (init_character_once): Remove.
12 * filelock.c (init_filelock): Likewise.
13 * fns.c (init_fns): Likewise.
14 * image.c (init_image): Likewise.
15 * sound.c (init_sound): Likewise.
16 * emacs.c (main): Adjust accordingly.
18 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
20 * gtkutil.h: Tiny cleanups.
21 (use_old_gtk_file_dialog): Remove useless declaration.
22 (xg_uses_old_file_dialog): Add suggested const attribute.
24 2012-07-15 Eli Zaretskii <eliz@gnu.org>
26 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
27 (bidi_paragraph_init): Use it to limit search forward for a strong
28 directional character in abnormally large paragraphs full of
29 neutral or weak characters. (Bug#11943)
31 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
33 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
34 the toolbar (Bug#9451).
35 (xg_make_tool_item): Give the widget event box a transparent
38 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
40 Cleanup basic allocation variables and functions.
41 * alloc.c (ignore_warnings, init_intervals, init_float)
42 (init_cons, init_symbol, init_marker): Remove.
43 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
44 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
45 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
46 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
47 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
48 (staticidx, init_alloc_once, init_strings, free_ablock):
49 Remove redundant initialization.
50 * fns.c (init_weak_hash_tables): Remove.
51 * lisp.h (init_weak_hash_tables): Remove prototype.
53 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
55 Use zero_vector where appropriate.
56 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
58 * lisp.h (zero_vector): New declaration.
59 * font.c (null_vector): Remove.
60 (syms_of_font): Remove initialization and staticpro.
61 (font_list_entities, font_find_for_lface): Change to use zero_vector.
62 * keymap.c (Faccessible_keymaps): Likewise.
64 2012-07-15 Leo Liu <sdl.web@gmail.com>
66 * fringe.c: Fix typo in comments.
68 2012-07-14 Leo Liu <sdl.web@gmail.com>
70 * fringe.c: Add a new bitmap exclamation-mark.
72 2012-07-14 Eli Zaretskii <eliz@gnu.org>
74 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
76 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
77 (HAVE_MENUS): Don't define, defined by editing config.in with
79 (GMALLOC_INHIBIT_VALLOC): Don't define.
80 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
82 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
84 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
86 2012-07-14 Glenn Morris <rgm@gnu.org>
88 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
89 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
90 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
92 2012-07-13 Glenn Morris <rgm@gnu.org>
94 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
96 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
97 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
99 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
101 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
102 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
103 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
104 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
106 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
107 as boolean expression.
108 (x_set_window_size): Remove unused variable toolbar.
109 (ns_get_color_default, ns_mod_to_lisp): Remove.
110 (ns_mouse_position): Remove unused variables xchar and ychar.
111 (ns_compute_glyph_string_overhangs): Remove unused variable face.
112 (ns_set_vertical_scroll_bar): Remove unused variable count.
113 (ns_delete_terminal): Remove unused variable i.
114 (ns_term_init): Remove unused variables r, g and b.
115 (mouseDown): Remove unused variable window.
116 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
117 (initFrameFromEmacs): Remove unused variable vbextra.
118 (mouseEntered): Remove unused variables p and dpyinfo.
119 (mouseExited): Remove unused variables p and r.
120 (ns_define_frame_cursor, ns_clear_frame_area)
121 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
122 (menuDown): Assign [sender tag] to variable and cast the variable.
124 * nsterm.h (menuDown): Add id as type to argument sender.
125 (ns_display_info_for_name): Add Lisp_Object argument.
126 (ns_term_init): Add Lisp_Object argument.
127 (ns_map_event_to_object): Add void argument.
128 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
129 prototype with arguments and only declare if __OBJC__.
130 (nxatoms_of_nsselect): Add void argument.
131 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
132 (ns_alloc_autorelease_pool): Add void argument.
133 (ns_release_autorelease_pool): Add void* argument.
134 (ns_get_defaults_value): Add const char* argument.
136 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
137 (initFromContents): Use SSDATA where appropriate.
138 (ns_update_menubar): Add braces to ambigous if-else.
139 (initWithTitle): Put () around assignment in if statement.
140 (ns_menu_show): Remove unused variables window and keymap.
141 (update_frame_tool_bar): Remove unused variable selected_p.
142 (initWithContentRect): Remove unused variable this_cmd_name.
144 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
146 (setXBMColor): Remove unused variable len.
147 (setPixmapData): Put () around assignment in loop statement.
149 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
150 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
152 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
153 around assignment in loop statement.
154 (nsfont_open): Remove unused variable i.
155 (nsfont_open): Remove unused variable len.
156 (nsfont_draw): Remove unused variable cs.
158 * nsfns.m (x_set_icon_name, ns_set_name_internal)
159 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
160 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
161 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
162 (Fns_font_name, Fns_perform_service)
163 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
164 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
165 (ns_set_name): Remove unused variable view.
166 (x_set_menu_bar_lines): Remove unused variable olines.
167 (x_set_tool_bar_lines): Remove unused variable root_window.
168 (Fns_list_colors): Put () around assignment in while statement.
169 (Fns_perform_service): Remove unused variable len.
170 (Fns_display_usable_bounds): Remove unused variable top.
171 (syms_of_nsfns): Remove unused variable i.
173 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
176 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
178 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
179 and free it with DestroyExceptionInfo (Bug#11558).
181 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
183 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
184 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
185 Set here, not in nt/config.nt.
187 2012-07-13 Eli Zaretskii <eliz@gnu.org>
189 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
190 cursor overflow into the last glyph on display line when the right
191 fringe is off. (Bug#11832)
193 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
195 * xdisp.c (produce_special_glyphs): Now static.
196 * dispextern.h (produce_special_glyphs): Remove decl.
198 2012-07-13 Glenn Morris <rgm@gnu.org>
200 * s/bsd-common, s/cygwin.h: Remove empty files.
201 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
203 * s/usg5-4-common.h (USG, USG5):
204 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
205 * s/sol2-6.h (SOLARIS2):
206 * s/irix6-5.h (IRIX6_5):
207 * s/hpux10-20.h (USG, USG5, HPUX):
208 * s/gnu-linux.h (USG, GNU_LINUX):
209 * s/freebsd.h (BSD_SYSTEM):
210 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
211 * s/cygwin.h (CYGWIN):
212 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
213 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
215 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
217 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
219 2012-07-13 Glenn Morris <rgm@gnu.org>
221 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
223 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
225 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
226 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
228 2012-07-12 Glenn Morris <rgm@gnu.org>
230 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
232 * process.c (init_process_emacs): Rename from init_process.
233 The old name is also the name of a Mach system call.
234 * lisp.h, emacs.c: Update for this name change.
235 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
238 2012-07-12 Eli Zaretskii <eliz@gnu.org>
240 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
241 memmove call that removes glyphs covered by the left truncation
242 glyph. Improve commentary.
243 (display_line): Fix display of continuation glyphs on GUI frames
244 when the right fringe is turned off and variable-size fonts are
245 used in the window. Move the code that appends a stretch glyph to
246 produce_special_glyphs, so that it could be used for truncation
247 and continuation glyphs alike.
248 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
249 glyph of a suitably computed width, to align the special glyphs at
250 the window margin. Code moved from display_line. (Bug#11832)
252 2012-07-12 Glenn Morris <rgm@gnu.org>
254 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
256 * s/gnu-linux.h, s/hpux10-20.h:
257 Do not unconditionally define HAVE_XRMSETDATABASE.
259 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
261 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
263 Fix typos that broke OS X build.
264 Reported by Randal L. Schwartz in
265 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
266 * nsterm.m (ns_timeout): Add missing local decl.
267 (ns_get_color): snprintf -> sprintf, to fix typo.
269 2012-07-12 Glenn Morris <rgm@gnu.org>
271 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
272 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
273 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
274 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
276 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
277 Move PTY_OPEN to configure.
279 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
280 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
281 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
283 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
285 Use empty_unibyte_string where applicable.
286 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
287 * lread.c (read1): Likewise.
288 * xsettings.c (syms_of_xsettings): Likewise.
290 2012-07-12 Glenn Morris <rgm@gnu.org>
292 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
293 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
294 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
295 * s/hpux10-20.h (RUN_TIME_REMAP):
296 * s/bsd-common.h (TABDLY): Move to configure.
298 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
300 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
302 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
303 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
305 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
307 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
308 * s/template.h: Move NARROWPROTO to configure.
310 2012-07-11 Glenn Morris <rgm@gnu.org>
312 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
313 unused since 2011-01-17 change to systty.h.
315 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
316 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
317 Move HAVE_PTYS and HAVE_SOCKETS to configure.
319 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
321 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
323 2012-07-11 Glenn Morris <rgm@gnu.org>
325 * s/darwin.h, s/gnu-linux.h, s/template.h:
326 Move INTERRUPT_INPUT to configure.
328 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
330 Minor adjustments to interning code.
331 * lisp.h (intern, intern_c_string): Redefine as static inline
332 wrappers for intern_1 and intern_c_string_1, respectively.
333 (intern_1, intern_c_string_1): Rename prototypes.
334 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
336 * font.c (font_intern_prop): Likewise. Adjust comment.
337 * w32font.c (intern_font_name): Likewise.
339 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
341 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
343 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
344 of Fcar/Fcdr if possible.
345 * font.c (check_otf_features): Likewise.
346 * fontset.c (Fnew_fontset): Likewise.
347 * gnutls.c (Fgnutls_boot): Likewise.
348 * minibuf.c (read_minibuf): Likewise.
349 * msdos.c (IT_set_frame_parameters): Likewise.
350 * xmenu.c (Fx_popup_dialog): Likewise.
351 * w32menu.c (Fx_popup_dialog): Likewise.
353 2012-07-11 Glenn Morris <rgm@gnu.org>
355 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
356 since nothing has defined it on these platforms.
358 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
359 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
361 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
362 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
363 Move CLASH_DETECTION to configure.
365 * s/gnu.h: Remove file, which is now empty.
367 * s/gnu.h, s/gnu-linux.h:
368 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
370 2012-07-11 John Wiegley <johnw@newartisans.com>
372 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
373 function attribute, so we only use it if it exists in the
376 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
378 Avoid call to strlen in fast_c_string_match_ignore_case.
379 * search.c (fast_c_string_match_ignore_case): Change to use
380 length argument. Adjust users accordingly.
381 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
383 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
386 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
387 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
390 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
393 * s/hpux10-20.h (HAVE_PERROR): Remove.
394 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
395 Remove dummy definition, as this problem was obsolete long ago.
398 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
400 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
402 Avoid calls to strlen in font processing functions.
403 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
404 (font_open_by_name): Change to use length argument. Adjust
406 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
408 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
409 Change to return ptrdiff_t.
410 (xfont_list_pattern, xfont_match): Use length returned by
411 xfont_decode_coding_xlfd.
412 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
414 2012-07-11 Glenn Morris <rgm@gnu.org>
416 * s/darwin.h, s/freebsd.h, s/netbsd.h:
417 Move DONT_REOPEN_PTY to configure.
419 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
420 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
422 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
424 Remove "#define unix" that is no longer needed (Bug#11905).
425 * s/aix4-2.h (unix): Remove; no longer needed.
427 EMACS_TIME simplification (Bug#11875).
428 This replaces macros (which typically do not work in GDB)
429 with functions, typedefs and enums, making the code easier to debug.
430 The functional style also makes code easier to read and maintain.
431 * systime.h: Include <sys/time.h> on all hosts, not just if
432 WINDOWSNT, since 'struct timeval' is needed in general.
433 (EMACS_TIME): Now a typedef, not a macro.
434 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
436 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
437 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
438 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
439 (EMACS_TIME_LE): Now functions, not macros.
440 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
441 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
442 which are not functions. All uses rewritten to use:
443 (make_emacs_time): New function.
444 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
445 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
446 not functions. All uses rewritten to use the following, respectively:
447 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
448 (add_emacs_time, sub_emacs_time): New functions.
449 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
450 * fileio.c (Fcopy_file):
451 * xterm.c (XTflash): Get the current time closer to when it's used.
452 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
454 * bytecode.c (targets): Suppress -Woverride-init warnings.
456 Simplify by avoiding confusing use of strncpy etc.
457 * doc.c (Fsnarf_documentation):
458 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
459 * frame.c (Fmake_terminal_frame):
460 * gtkutil.c (get_utf8_string):
462 * nsmenu.m (ns_update_menubar):
463 * regex.c (regerror):
464 Prefer memcpy to strncpy and strncat when either will do.
465 * fileio.c (Fsubstitute_in_file_name):
466 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
467 (menu_separator_name_p):
468 * nsmenu.m (ns_update_menubar):
469 Prefer memcmp to strncmp when either will do.
470 * nsterm.m: Include <ftoastr.h>.
472 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
473 Prefer snprintf to strncpy.
474 * nsterm.m (ns_term_init):
475 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
476 * nsterm.m (ns_term_init):
477 Avoid the need for strncpy, by using build_string or
478 make_unibyte_string directly. Use dtoastr, not snprintf.
479 * process.c (Fmake_network_process): Diagnose service names that
480 are too long, rather than silently truncating them or creating
481 non-null-terminated names.
482 (Fnetwork_interface_info): Likewise, for interface names.
483 * sysdep.c (system_process_attributes) [GNU_LINUX]:
484 Prefer sprintf to strncat.
485 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
486 Prefer vsnprintf to vsprintf + strncpy.
488 2012-07-10 Glenn Morris <rgm@gnu.org>
490 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
491 Clarify fallback case.
493 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
495 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
496 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
497 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
498 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
499 where argument type is known to be a Lisp_Cons.
501 2012-07-10 Tom Tromey <tromey@redhat.com>
503 * bytecode.c (BYTE_CODE_THREADED): New macro.
504 (BYTE_CODES): New macro. Replaces all old byte-code defines.
505 (enum byte_code_op): New type.
506 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
507 (exec_byte_code): Use them. Use token threading when applicable.
509 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
511 Optimize pure C strings initialization.
512 * lisp.h (make_pure_string): Fix prototype.
513 (build_pure_c_string): New function, defined as static inline. This
514 provides a better opportunity to optimize away calls to strlen when
515 the function is called with compile-time constant argument.
516 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
517 argument, adjust users accordingly. Use build_pure_c_string where
519 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
520 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
521 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
523 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
525 Avoid calls to strlen in miscellaneous functions.
526 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
527 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
528 * lread.c (openp): Likewise.
530 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
532 Avoid calls to strlen in path processing functions.
533 * fileio.c (file_name_as_directory): Add comment. Change to add
534 srclen argument and return the length of result. Adjust users
536 (directory_file_name): Fix comment. Change to add srclen argument,
537 swap 1st and 2nd arguments to obey the common convention. Adjust
539 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
541 2012-07-10 Glenn Morris <rgm@gnu.org>
543 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
544 Move PENDING_OUTPUT_COUNT definition to configure.
546 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
547 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
548 * s/gnu.h (DATA_START): Move definitions to configure.
550 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
551 We include usg5-4-common.h, which defines them both.
553 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
554 O_RDONLY already includes it).
556 Stop ns builds setting the EMACSLOADPATH environment variable.
557 * nsterm.m (ns_load_path): Rename from ns_init_paths.
558 Now it does not set EMACSLOADPATH, just returns the load-path string.
559 * nsterm.h: Update accordingly.
560 * lread.c [HAVE_NS]: Include nsterm.h.
561 (init_lread) [HAVE_NS]: Use ns_load_path.
562 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
564 2012-07-09 Glenn Morris <rgm@gnu.org>
566 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
567 since the included bsd-common.h does so.
569 Stop ns builds setting the EMACSPATH environment variable.
570 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
571 (ns_init_paths): Do not set EMACSPATH.
572 * nsterm.h (ns_exec_path): Add it.
573 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
576 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
578 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
580 * process.c (wait_reading_process_output): 'waitchannels' was unset
581 when read_kbd || !NILP (wait_for_cell); fix this.
583 Add GCC-style 'const' attribute to functions that can use it.
584 * character.h (char_resolve_modifier_mask):
585 * keyboard.h (make_ctrl_char):
586 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
587 (init_character_once, next_almost_prime, init_fns, init_image)
588 (flush_pending_output, init_sound):
589 * mem-limits.h (start_of_data):
590 * menu.h (finish_menu_items):
592 * emacs.c (DEFINE_DUMMY_FUNCTION):
593 Declare the dummy function with ATTRIBUTE_CONST.
594 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
595 Add decls with ATTRIBUTE_CONST.
597 Minor improvements to make_formatted_string.
598 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
599 where int is good enough, as vsprintf returns an int.
600 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
602 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
604 Use make_formatted_string to avoid double length calculation.
605 * lisp.h (make_formatted_string): New prototype.
606 * alloc.c (make_formatted_string): New function.
607 * buffer.c (Fgenerate_new_buffer_name): Use it.
608 * dbus.c (syms_of_dbusbind): Likewise.
609 * editfns.c (Fcurrent_time_zone): Likewise.
610 * filelock.c (get_boot_time): Likewise.
611 * frame.c (make_terminal_frame, set_term_frame_name)
612 (x_report_frame_params): Likewise.
613 * image.c (gs_load): Likewise.
614 * minibuf.c (get_minibuffer): Likewise.
615 * msdos.c (dos_set_window_size): Likewise.
616 * process.c (make_process): Likewise.
617 * xdisp.c (ensure_echo_area_buffers): Likewise.
618 * xsettings.c (apply_xft_settings): Likewise.
620 2012-07-09 Glenn Morris <rgm@gnu.org>
622 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
623 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
624 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
625 * nsterm.h (ns_etc_directory): Add it.
626 * callproc.c [HAVE_NS]: Include nsterm.h.
627 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
629 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
631 Move marker debugging code under MARKER_DEBUG.
632 * marker.c (MARKER_DEBUG): Move marker debugging code under
633 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
634 for bootstrap with --enable-checking (~3x slowdown reported
635 by Juanma Barranquero <lekktu@gmail.com>).
636 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
638 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
640 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
641 See <http://bugs.gnu.org/11825#29>.
643 2012-07-08 Eli Zaretskii <eliz@gnu.org>
645 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
646 has no font, use the frame's font. (Bug#11813)
647 (display_line): Add commentary about displaying truncation glyphs
649 (produce_special_glyphs): Move here from term.c.
651 * term.c (produce_special_glyphs): Move to xdisp.c.
653 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
656 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
658 * xdisp.c (display_line): Avoid warning about implicit declaration
661 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
663 * lisp.h: Remove empty conditional.
665 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
667 * lread.c (load_path_check): Now static.
669 Fix some minor --with-ns problems found by static checking.
670 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
671 (x_set_font) [!HAVE_X_WINDOWS]:
672 * image.c (xpm_load_image) [HAVE_NS]:
673 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
674 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
676 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
677 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
678 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
679 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
680 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
681 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
682 Fix pointer signedness problem.
683 * xfaces.c (FRAME_X_FONT_TABLE):
684 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
686 2012-07-07 Glenn Morris <rgm@gnu.org>
688 * lread.c (load_path_check): New function, split from init_lread.
689 (init_lread): Reorganize. Motivation:
690 If EMACSLOADPATH is set, check/warn about that rather than the
691 defaults, which we are not going to use. Hence we can remove
692 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
693 Don't warn if site-lisp directories are missing.
694 If not installed, start from a blank load-path, since
695 PATH_LOADSEARCH refers to the eventual installation directories.
697 2012-07-07 Eli Zaretskii <eliz@gnu.org>
699 Support truncation and continuation glyphs on GUI frames, when
700 fringes are disabled. (Bug#11832)
701 * xdisp.c (init_iterator): Get dimensions of truncation and
702 continuation glyphs even if on GUI frames. Adjust
703 it->last_visible_x on GUI frames when the left or right fringes,
705 (start_display, move_it_in_display_line_to): Handle the case of a
706 GUI frame without a fringe to display continuation or truncation
708 (insert_left_trunc_glyphs): Support GUI frames: make sure
709 truncation glyphs overwrite enough glyphs from the current line to
710 have sufficient space in pixels.
711 (display_line): Support truncation and continuation glyphs on GUI
712 frames. If some spare pixels are left on the line after inserting
713 the truncation glyphs, fill that space with a stretch glyph of a
714 suitably computed width.
716 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
717 produce_glyphs, to support GUI sessions.
719 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
721 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
723 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
725 Do not require float-time's arg to fit in time_t (Bug#11825).
726 This works better on hosts where time_t is unsigned, and where
727 float-time is applied to the (negative) difference between two times.
728 * editfns.c (decode_time_components): Last arg is now double *,
729 not int *, and means to store all the result as a double, without
730 worrying about whether the seconds part fits in time_t.
732 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
734 (Ffloat_time): Do not fail merely because the specified time falls
735 outside of time_t range.
737 2012-07-07 Glenn Morris <rgm@gnu.org>
739 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
740 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
741 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
743 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
745 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
748 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
750 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
752 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
753 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
754 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
755 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
756 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
757 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
759 * xfont.c (compare_font_names): Redo to omit the need for casts.
761 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
763 * xfns.c (Fx_change_window_property): Doc fix.
764 * w32fns.c (Fx_change_window_property): Doc fix.
766 * w32fns.c (Fx_window_property): Accept the same arguments as the
767 X Windows version. Doc fix.
768 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
770 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
771 Eli Zaretskii <eliz@gnu.org>
773 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
774 Windows-specific code from nt/config.nt moved here.
775 Obsolete settings removed.
777 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
779 * process.c: Avoid unnecessary calls to gettime.
780 (wait_reading_process_output): Don't get the time of day
781 when gobbling data immediately and not waiting, as there's no need
782 for it in that case. This removes a FIXME.
784 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
786 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
787 is defined (Bug#11768).
789 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
791 Fix marker debugging code.
792 * marker.c (byte_char_debug_check): Do not perform the check
793 if buffer is not multibyte.
794 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
795 Call byte_char_debug_check with correct arguments.
797 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
799 Compile marker debugging code only if ENABLE_CHECKING is defined.
800 * marker.c (byte_char_debug_check, count_markers):
801 Use only if ENABLE_CHECKING is defined.
802 (byte_debug_flag): Remove.
803 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
804 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
806 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
808 Avoid code repetition in marker-related functions.
809 * marker.c (attach_marker): New function.
810 (Fset_marker, set_marker_restricted, set_marker_both)
811 (set_marker_restricted_both): Use it.
812 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
813 Consistently rename charno to charpos.
814 (marker_position): Add eassert.
815 (marker_byte_position): Convert to eassert.
817 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
819 Simplify list operations in unchain_overlay and unchain_marker.
820 * buffer.c (unchain_overlay): Simplify. Add comment.
821 * marker.c (unchain_marker): Simplify. Fix comments.
823 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
825 Introduce fast path for the widely used marker operation.
826 * alloc.c (build_marker): New function.
827 * lisp.h (build_marker): New prototype.
828 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
829 * composite.c (autocmp_chars): Likewise.
830 * editfns.c (buildmark): Remove.
831 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
832 (save_restriction_save): Use build_marker.
833 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
834 * window.c (save_window_save): Likewise.
836 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
838 Do not use Fdelete_overlay in delete_all_overlays
839 to avoid redundant calls to unchain_overlay.
840 * buffer.c (drop_overlay): New function.
841 (delete_all_overlays, Fdelete_overlay): Use it.
842 * minibuf.c (get_minibuffer): Fix comment.
844 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
846 Port to OpenBSD 5.1 amd64.
847 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
848 This is needed for OpenBSD, and should be harmless on all BSD systems.
849 Also, include <sys/sysctl.h>, as it should be available on all
850 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
851 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
852 use p_pid member, not kp_proc.pid.
854 2012-07-06 Glenn Morris <rgm@gnu.org>
856 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
858 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
860 More xmalloc and related cleanup.
861 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
862 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
863 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
864 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
865 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
866 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
867 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
868 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
869 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
871 Omit needless casts involving void * pointers and allocation.
872 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
873 as the former is more robust if P's type is changed.
874 Prefer xzalloc to xmalloc + memset 0.
875 Simplify malloc-or-realloc to realloc.
876 Don't worry about xmalloc returning a null pointer.
877 Prefer xstrdup to xmalloc + strcpy.
878 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
880 * keyboard.c (apply_modifiers_uncached): Prefer local array to
881 alloca of a constant.
883 2012-07-05 Eli Zaretskii <eliz@gnu.org>
885 * xdisp.c (display_line): Fix horizontal pixel coordinates when
886 hscroll is larger than the line width. Fixes long and futile
887 looping inside extend_face_to_end_of_line (on a TTY) producing
888 glyphs that are not needed and thrown away.
890 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
892 * marker.c (set_marker_restricted_both): Simplify by using
895 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
897 * editfns.c (region_limit): Simplify by using clip_to_bounds.
899 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
901 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
902 not defined (Bug#11768).
903 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
904 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
905 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
906 followed by gtk_box_set_homogeneous (Bug#11768).
907 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
908 (update_theme_scrollbar_width, xg_create_scroll_bar):
909 Use gtk_scrollbar_new (Bug#11768).
910 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
911 (is_box_type): New function (Bug#11768).
912 (xg_tool_item_stale_p): Call is_box_type.
913 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
914 with default display (Bug#11768).
916 2012-07-05 Eli Zaretskii <eliz@gnu.org>
918 * xdisp.c (window_hscroll_limited): New function.
919 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
920 coordinates when window's hscroll is set to insanely large
923 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
925 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
926 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
928 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
931 * lisp.h (xzalloc): New prototype. Omit needless casts.
932 * alloc.c (xzalloc): New function. Omit needless casts.
933 * charset.c: Omit needless casts. Convert all calls to
934 xmalloc with following memset to xzalloc.
935 * dispnew.c: Likewise.
936 * fringe.c: Likewise.
940 * w32fns.c: Likewise.
941 * w32font.c: Likewise.
942 * w32term.c: Likewise.
943 * xfaces.c: Likewise.
946 * atimer.c: Omit needless casts.
947 * buffer.c: Likewise.
948 * callproc.c: Likewise.
950 * coding.c: Likewise.
951 * composite.c: Likewise.
953 * doprnt.c: Likewise.
954 * editfns.c: Likewise.
957 * filelock.c: Likewise.
959 * gtkutil.c: Likewise.
960 * keyboard.c: Likewise.
963 * minibuf.c: Likewise.
966 * process.c: Likewise.
967 * region-cache.c: Likewise.
968 * search.c: Likewise.
969 * sysdep.c: Likewise.
970 * termcap.c: Likewise.
971 * terminal.c: Likewise.
972 * tparam.c: Likewise.
973 * w16select.c: Likewise.
975 * w32reg.c: Likewise.
976 * w32select.c: Likewise.
977 * w32uniscribe.c: Likewise.
978 * widget.c: Likewise.
982 * xselect.c: Likewise.
984 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
986 * fileio.c (time_error_value): Check the right error number.
987 Problem reported by Troels Nielsen in
988 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
990 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
992 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
993 This should be fixed in a better way; see Eli Zaretskii in
994 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
995 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
997 * fileio.c (time_error_value): Rename from special_mtime.
998 The old name's problems were noted by Eli Zaretskii in
999 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1001 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1002 This variable's comment says Emacs needs at least one GDB-visible
1003 symbol of type enum pvec_type, to work around GDB problems.
1004 The symbol's value doesn't matter.
1006 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1007 that causes compilation to fail on pre-C99 compilers.
1009 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1011 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1012 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1014 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1016 * buffer.c (init_buffer_once): Fix initialization of
1017 headers for buffer_defaults and buffer_local_symbols.
1018 Reported by Juanma Barranquero <lekktu@gmail.com>.
1020 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1022 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1023 * lisp.h (enum pvec_type): Use fewer bits.
1024 (PSEUDOVECTOR_SIZE_BITS): New constant.
1025 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1026 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1027 change in pvec_type.
1028 (PSEUDOVECTOR_TYPEP): New macro.
1029 (TYPED_PSEUDOVECTORP): Use it.
1030 * fns.c (internal_equal): Adapt code to extract pvectype.
1031 * emacs.c (gdb_pvec_type): Update type.
1032 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1033 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1034 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1035 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1036 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1037 abusing vector->header.next.nbytes.
1038 (live_vector_p): Use PVEC_TYPE.
1039 (mark_object): Adapt code to extract pvectype. Use switch.
1041 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1043 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1044 Tighten new eassert a bit.
1046 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1048 Fix compilation with --enable-gcc-warnings and -O1
1050 * doprnt.c (doprnt): Change type of tem to int, initialize
1051 to avoid compiler warning. Add eassert.
1052 * search.c (simple_search): Initialize match_byte to avoid
1053 compiler warning. Add eassert.
1055 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1057 Avoid weird behavior with large horizontal scrolls.
1058 Without this change, for example, large hscroll values would
1059 mess up Emacs's display on Fedora 15 x86, presumably due to
1060 overflows in int calculations in the display code.
1061 Also, if buffers had long lines, Emacs would freeze.
1062 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1063 (set_window_hscroll): New function, containing the old guts of
1064 Fset_window_hscroll. Return the clipped value.
1065 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1066 This avoids the need to check against PTRDIFF_MAX.
1068 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1070 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1072 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1074 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1076 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1077 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1078 since GCC 4.4.6 issues a bogus warning for them.
1080 Fix bugs in file timestamp newness comparisons.
1081 * fileio.c (Ffile_newer_than_file_p):
1082 * lread.c (Fload): Use full timestamp resolution of files,
1083 not just the 1-second resolution, so that files that are only
1084 slightly newer still count as newer.
1085 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1086 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1088 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1090 * fileio.c: Improve handling of file time marker. (Bug#11852)
1091 (special_mtime): New function.
1092 (Finsert_file_contents, Fverify_visited_file_modtime):
1093 Use it to set special mtime values consistently.
1095 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1097 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1098 marker for non-existing file. (Bug#11852)
1100 2012-07-03 Glenn Morris <rgm@gnu.org>
1102 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1103 and did not make it into globals.h).
1105 2012-07-03 Tom Tromey <tromey@redhat.com>
1107 * window.c (Fset_window_margins, Fset_window_fringes)
1108 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1109 * textprop.c (Fprevious_property_change): No longer static.
1110 * syntax.c (Fsyntax_table_p): No longer static.
1111 * process.c (Fget_process, Fprocess_datagram_address): No longer
1113 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1114 * keyboard.c (Fcommand_execute): No longer static.
1116 * insdel.c (Fcombine_after_change_execute): No longer static.
1117 * image.c (Finit_image_library): No longer static.
1118 * fileio.c (Fmake_symbolic_link): No longer static.
1119 * eval.c (Ffetch_bytecode): No longer static.
1120 * editfns.c (Fuser_full_name): No longer static.
1121 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1123 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1125 * dired.c (Ffile_attributes): No longer static.
1126 * composite.c (Fcomposition_get_gstring): No longer static.
1127 * callproc.c (Fgetenv_internal): No longer static.
1129 * ccl.h: Remove EXFUNs.
1130 * buffer.h: Remove EXFUNs.
1131 * dispextern.h: Remove EXFUNs.
1132 * intervals.h: Remove EXFUNs.
1133 * fontset.h: Remove EXFUN.
1134 * font.h: Remove EXFUNs.
1135 * dosfns.c (system_process_attributes): Remove EXFUN.
1136 * keymap.h: Remove EXFUNs.
1137 * lisp.h: Remove EXFUNs.
1138 * w32term.h: Remove EXFUNs.
1139 * window.h: Remove EXFUNs.
1140 * xsettings.h: Remove EXFUN.
1141 * xterm.h: Remove EXFUN.
1143 2012-07-03 Glenn Morris <rgm@gnu.org>
1145 * lisp.h (Frandom): Make it visible to C.
1146 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1147 buffer for invisible buffers. (Bug#1229)
1149 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1151 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1152 values which aren't power of 2.
1153 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1154 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1157 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1159 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1161 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1163 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1165 * alloc.c (allocate_vector_block): Remove redundant
1166 calls to mallopt if DOUG_LEA_MALLOC is defined.
1167 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1168 avoid calls to mallopt if zero_vector is returned.
1170 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1172 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1173 is enabled, avoid dereferencing NULL current_sblock if
1176 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1178 Cleanup basic buffer management.
1179 * buffer.h (struct buffer): Change layout to use generic vector
1180 marking code. Fix some comments. Change type of 'clip_changed'
1181 to bitfield. Remove unused #ifndef old.
1182 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1183 (GET_OVERLAYS_AT): Fix indentation.
1184 (for_each_per_buffer_object_at): New macro.
1185 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1186 (Fbuffer_local_variables): Use it.
1187 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1188 * alloc.c (allocate_buffer): Adjust to match new layout of
1189 struct buffer. Fix comment.
1190 (mark_overlay): New function.
1191 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1192 Lisp area of struct buffer.
1193 (mark_object): Use it. Adjust marking of misc objects
1194 and related comments.
1196 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1198 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1199 wrapper that is not needed because the wrapped code is a no-op (zero
1200 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1201 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1203 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1205 * alloc.c (mark_buffer): Simplify. Remove prototype.
1206 (mark_object): Add comment. Reorganize marking of vector-like
1207 objects. Use CHECK_LIVE for all vector-like objects except buffers
1208 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1209 redundant calls to mark_vectorlike for bool vectors.
1211 2012-06-30 Glenn Morris <rgm@gnu.org>
1213 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1215 * epaths.in (PATH_SITELOADSEARCH): New.
1216 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1217 This is rather than relying on --enable-locallisppath elements
1218 having "site-lisp" in their names. (Bug#10208#25, 11658)
1220 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1222 * w32proc.c (sys_select): Accept and ignore one more argument.
1224 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1226 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1227 (pselect) [!MS_DOS]: Redirect to sys_select.
1229 * sysdep.c: Don't include dos.h and dosfns.h.
1231 * process.c (sys_select):
1232 * msdos.c (sys_select): Accept one more argument and ignore it.
1234 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1235 adapt data types and code to that.
1238 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1239 which clashes with the gnulib function of the same name.
1241 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1243 * font.c (font_style_to_value, font_style_symbolic)
1244 (font_prop_validate_style): Add type checks for values in
1247 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1249 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1252 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1254 * xdisp.c (try_window_id): Undo last change.
1256 * w32.c (getwd): Adjust commentary about startup_dir.
1257 (init_environment): Always call sys_access, even in non-MSVC
1258 builds. Don't chdir to the directory of the Emacs executable.
1259 This undoes code from 1997 which was justified by the need to
1260 "avoid conflicts when removing and renaming directories". But its
1261 downside was that every relative file name was being interpreted
1262 relative to the directory of the Emacs executable, which can never
1263 be TRT. In particular, it broke sys_access when called with
1264 relative file names.
1265 (sys_access): Map GetLastError to errno.
1267 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1269 * window.h (struct window): Change type of 'fringes_outside_margins'
1270 to bitfield. Fix comment. Adjust users accordingly.
1271 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1273 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1276 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1278 * gnutls.c (emacs_gnutls_handshake):
1279 Add QUIT to make the loop interruptible.
1281 2012-06-29 Glenn Morris <rgm@gnu.org>
1283 * charset.c (init_charset): Make lack of etc/charsets fatal.
1285 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1287 * editfns.c (region_limit): Fix type mismatch.
1289 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1291 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1292 undefined. Convert from xassert to eassert.
1293 * nsmenu.m: Convert from xassert to eassert.
1294 * nsterm.m: Likewise.
1296 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1298 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1300 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1302 Avoid integer overflow on scroll-left and scroll-right.
1303 * window.c (HSCROLL_MAX): New macro.
1304 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1305 overflow when requested scroll falls outside ptrdiff_t range.
1307 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1309 * window.h (struct window): Change type of 'hscroll',
1310 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1311 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1312 Adjust users accordingly.
1313 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1314 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1315 from EMACS_INT to ptrdiff_t.
1316 (make_window): Omit redundant initialization.
1318 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1320 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1322 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1324 * window.h (struct window): Change type of 'use_time' and
1325 'sequence_number' from Lisp_Object to int.
1326 * frame.c (make_frame): Adjust users accordingly.
1327 * print.c (print_object): Likewise.
1328 * window.c (select_window, Fwindow_use_time, make_parent_window)
1329 (make_window): Likewise.
1331 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1333 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1334 enabled with --enable-checking=[all,glyphs] configure option.
1335 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1336 adjust comments accordingly.
1337 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1338 undefined, adjust comments accordingly.
1339 * image.c: Likewise.
1340 * scroll.c: Likewise.
1341 * w32fns.c: Likewise.
1342 * w32term.c: Likewise.
1343 * xdisp.c: Likewise.
1344 * xfaces.c: Likewise.
1346 * xterm.c: Likewise.
1348 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1350 Generalize run-time debugging checks.
1351 * dispextern.h (XASSERTS): Remove.
1352 * fontset.c (xassert): Remove.
1353 Convert from xassert to eassert.
1354 * alloc.c: Convert from xassert to eassert.
1356 * dispnew.c: Likewise.
1358 * fringe.c: Likewise.
1359 * ftfont.c: Likewise.
1360 * gtkutil.c: Likewise.
1361 * image.c: Likewise.
1362 * keyboard.c: Likewise.
1364 * process.c: Likewise.
1365 * scroll.c: Likewise.
1366 * sound.c: Likewise.
1368 * w32console.c: Likewise.
1369 * w32fns.c: Likewise.
1370 * w32term.c: Likewise.
1371 * window.c: Likewise.
1372 * xdisp.c: Likewise.
1373 * xfaces.c: Likewise.
1375 * xselect.c: Likewise.
1376 * xterm.c: Likewise.
1378 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1380 * fns.c (maybe_resize_hash_table): Output message when growing the
1383 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1385 * alloc.c (allocate_string_data): Remove dead code.
1386 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1387 avoid GCC warning about unused macro.
1389 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1391 * alloc.c (allocate_string): Omit intervals initialization.
1392 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1393 as in make_pure_string and make_pure_c_string.
1395 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1397 * alloc.c (allocate_string): Fix last change.
1399 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1401 * alloc.c (allocate_string): Remove two redundant calls
1402 to memset, add explicit initialization where appropriate.
1404 2012-06-27 Glenn Morris <rgm@gnu.org>
1406 * lisp.mk (lisp): Remove paths.elc.
1408 2012-06-27 Chong Yidong <cyd@gnu.org>
1410 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1412 2012-06-26 John Wiegley <johnw@newartisans.com>
1414 * unexmacosx.c (copy_data_segment): Add two section names used
1415 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1417 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1418 when building with Clang.
1420 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1422 * eval.c (Fapply): Allow calling it with a single argument.
1424 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1426 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1427 _stricmp and _strnicmp.
1428 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1430 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1432 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1434 (allocate_process): Likewise for new process.
1435 (allocate_terminal): Change to use offsetof.
1436 (allocate_frame): Likewise.
1437 * frame.c (make_frame): Omit redundant initialization.
1438 * window.c (make_parent_window): Use memset.
1439 (make_window): Omit redundant initialization.
1440 * process.c (make_process): Omit redundant initialization.
1441 * terminal.c (create_terminal): Likewise.
1443 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1445 * term.c (delete_tty): Remove redundant call to memset.
1447 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1449 * alloc.c: Remove build_string.
1450 * lisp.h: Define build_string as static inline. This provides
1451 a better opportunity to optimize away calls to strlen when the
1452 function is called with compile-time constant argument.
1453 * image.c (imagemagick_error): Convert to build_string.
1454 * w32proc.c (sys_spawnve): Likewise.
1455 * xterm.c (x_term_init): Likewise.
1457 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1459 Use sprintf return value instead of invoking strlen on result.
1460 In the old days this wasn't portable, since some sprintf
1461 implementations returned char *. But they died out years ago and
1462 Emacs already assumes sprintf returns int.
1463 Similarly for float_to_string.
1464 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1465 * ccl.c (ccl_driver):
1466 * character.c (string_escape_byte8):
1467 * data.c (Fnumber_to_string):
1468 * doprnt.c (doprnt):
1469 * print.c (print_object):
1470 * xdisp.c (message_dolog):
1471 * xfns.c (syms_of_xfns):
1472 Use sprintf or float_to_string result to avoid need to call strlen.
1473 * data.c (Fnumber_to_string):
1474 Use make_unibyte_string, since the string must be ASCII.
1475 * lisp.h, print.c (float_to_string): Now returns int length.
1476 * term.c (produce_glyphless_glyph):
1477 Use sprintf result rather than recomputing it.
1479 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1480 * Makefile.in (ALL_CFLAGS):
1481 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1482 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1484 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1486 * dispextern.h (xstrcasecmp): Define to library function
1487 strcasecmp if available.
1488 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1490 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1492 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1493 Avoid comma operator.
1494 * menu.c (push_submenu_start, push_submenu_end)
1495 (push_left_right_boundary, push_menu_pane): Likewise.
1496 * msdos.c (dos_rawgetc): Likewise.
1498 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1500 * xfns.c (xic_create_fontsetname): Remove redundant calls
1503 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1505 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1506 sprintf already null-terminates its output.
1508 * xfns.c (x_window): Remove redundant cast.
1510 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1512 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1513 `const char *' to `char *' to avoid compiler warning.
1515 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1517 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1518 instead of truncating it to 63 (admittedly a generous limit).
1520 * process.c: Fix spelling and caps in comments.
1522 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1524 * emacs.c (setpgrp): Remove definition, unused.
1525 * sysdep.c (setpgrp): Remove definition, not used in this file.
1527 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1529 * makefile.w32-in: Update dependencies.
1531 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1533 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1534 (SYSTIME_H): Add nt/inc/sys/time.h.
1536 * systime.h [WINDOWSNT]: Include sys/time.h.
1538 * s/ms-w32.h (struct timespec): Definition moved from
1539 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1541 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1543 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1544 * buffer.h (buffer_slot_type_mismatch):
1545 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1546 * eval.c (unwind_to_catch):
1547 * image.c (my_png_error, my_error_exit):
1548 * keyboard.c (quit_throw_to_read_char, user_error)
1549 (Fexit_recursive_edit, Fabort_recursive_edit):
1550 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1551 (wrong_type_argument, buffer_overflow, __executable_start)
1552 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1553 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1554 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1556 (child_setup) [!DOS_NT]:
1557 * lread.c (end_of_file_error, invalid_syntax):
1558 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1559 * puresize.h (pure_write_error):
1560 * search.c (matcher_overflow):
1561 * sound.c (sound_perror, alsa_sound_perror):
1562 * sysdep.c, syssignal.h (croak):
1563 * term.c (maybe_fatal, vfatal):
1564 * textprop.c (text_read_only):
1565 * undo.c (user_error):
1566 * unexmacosx.c (unexec_error):
1567 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1568 Use _Noreturn rather than NO_RETURN.
1569 No need for separate decl merely because of _Noreturn.
1570 * sound.c (sound_warning, parse_sound):
1571 Remove unnecessary forward decls.
1573 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1575 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1576 * lisp.h (WAIT_READING_MAX): New macro.
1577 * dispnew.c (Fsleep_for, sit_for):
1578 * keyboard.c (kbd_buffer_get_event):
1579 * process.c (Faccept_process_output):
1580 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1581 This improves on the previous patch, which introduced a bug
1582 when time_t is unsigned and as wide as intmax_t.
1583 See <http://bugs.gnu.org/9000#51>.
1585 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1587 * dispnew.c (sit_for, Fsleep_for):
1588 * keyboard.c (kbd_buffer_get_event):
1589 * process.c (Faccept_process_output): Avoid compiler warnings when
1590 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1592 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1594 * makefile.w32-in: Update dependencies.
1596 * w32.c (ltime): Add return type and declare static.
1597 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1599 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1601 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1602 Privately reported by Herbert J. Skuhra.
1603 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1605 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1606 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1608 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1610 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1611 last argument of make_unibyte_string.
1613 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1614 language ID in the event parameters.
1616 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1617 event.code, not the obscure "character set ID".
1619 2012-06-23 Chong Yidong <cyd@gnu.org>
1621 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1623 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1625 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1626 * w32.c (fdutimens): New function.
1628 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1630 * s/ms-w32.h (pselect): Redirect to sys_select.
1632 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1634 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1635 in the logic of incrementing and decrementing the value of
1636 use_relocatable_buffers.
1638 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1640 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1641 Privately reported by Herbert J. Skuhra.
1642 [__FreeBSD__]: Remove "*/" typo after "#include".
1643 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1644 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1645 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1646 Don't assume EMACS_TIME and struct timeval are the same type.
1648 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1650 Support higher-resolution time stamps (Bug#9000).
1651 The time stamps are only nanosecond-resolution at the C level,
1652 since that's the best that any real-world system supports now.
1653 But they are picosecond-resolution at the Lisp level, as that's
1654 easy, and leaves room for future OS improvements.
1656 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1659 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1660 Don't get current time unless it's needed.
1662 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1663 now provides it if it's absent.
1664 (start_atimer): Port to higher-res time stamps.
1665 Check for time stamp overflow. Don't get current time more
1666 often than is needed.
1668 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1669 Include systime.h, not time.h.
1670 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1672 * dired.c: Include stat-time.h.
1673 (Ffile-attributes): File times now have higher resolution.
1675 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1676 (struct image): Timestamp now has higher resolution.
1678 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1679 has at least microseconds now. All uses removed.
1680 (update_frame, update_single_window, update_window, update_frame_1)
1681 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1683 * editfns.c (time_overflow): Now extern.
1684 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1685 (float-time, Fformat_time_string, Fcurrent_time_string)
1686 (Fcurrent_time_zone): Accept and generate higher-resolution
1688 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1689 (decode_time_components, lisp_seconds_argument): New functions.
1690 (make_time): Now static.
1691 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1692 Report an error if the time is invalid, rather than having the caller
1695 * fileio.c: Include <stat-time.h>
1696 (Fcopy_file): Copy higher-resolution time stamps.
1697 Prefer to set the time stamp via a file descriptor if that works.
1698 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1699 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1700 (Fvisited_file_modtime, Fset_visited_file_modtime):
1701 Support higher-resolution time stamps.
1703 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1705 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1707 * image.c (prepare_image_for_display, clear_image_cache)
1708 (lookup_image): Port to higer-resolution time stamps.
1710 * keyboard.c (start_polling, bind_polling_period):
1711 Check for time stamp overflow.
1712 (read_char, kbd_buffer_get_event, timer_start_idle)
1713 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1714 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1715 Port to higher-resolution time stamps. Do not assume time_t is signed.
1716 (decode_timer): New function. Timers are now vectors of length 9,
1717 not 8, to accommodate the picosecond component.
1718 (timer_check_2): Use it.
1720 * nsterm.m (select_timeout, timeval_subtract): Remove.
1721 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1722 as they're a bit more accurate and handle overflow better.
1723 (ns_select): Change prototype to be compatible with pselect.
1724 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1725 * nsterm.h (ns_select): Adjust prototype.
1727 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1728 us-resolution time stamps.
1729 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1731 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1733 * lisp.h (time_overflow): New decl.
1734 (wait_reading_process_output): First arg is now intmax_t, not int,
1735 to accommodate larger waits.
1737 * process.h (struct Lisp_Process.read_output_delay):
1738 Now counts nanoseconds, not microseconds.
1739 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1741 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1742 (wait_reading_process_output):
1743 Port to ns-resolution time stamps.
1744 (Faccept_process_output, wait_reading_process_output):
1745 Check for time stamp overflow. Do not assume time_t is signed.
1746 (select_wrapper): Remove; we now use pselect.
1747 (Fprocess_attributes): Now generates ns-resolution time stamps.
1749 * sysdep.c: Include utimens.h. Don't include utime.h
1750 or worry about struct utimbuf; gnulib does that for us now.
1751 (gettimeofday): Remove; gnulib provides a substitute.
1752 (make_timeval): New function.
1753 (set_file_times): Now sets ns-resolution time stamps.
1754 New arg FD; all uses changed.
1755 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1756 (system_process_attributes):
1757 Now returns ns-resolution time stamp. All uses changed.
1758 Check for time stamp overflow.
1760 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1761 provides a substitute now.
1763 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1764 since it guarantees struct timespec.
1765 (EMACS_TIME): Now struct timespec, so that we can support
1766 ns-resolution time stamps.
1767 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1768 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1769 (EMACS_USECS): Remove.
1770 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1771 so multiply the arg by 1000 before storing it.
1772 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1774 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1775 Port to ns-resolution time stamps.
1776 (EMACS_TIME_NEG_P): Remove; replaced by....
1777 (EMACS_TIME_SIGN): New macro.
1778 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1779 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1780 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1781 (make_timeval, make_lisp_time, decode_time_components): New decls.
1782 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1783 that it mishandled time_t overflow. You can't compare by subtracting!
1784 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1785 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1787 * term.c: Include <sys/time.h>.
1788 (timeval_to_Time): New function, for proper overflow wraparound.
1789 (term_mouse_position, term_mouse_click): Use it.
1791 * undo.c (record_first_change): Support higher-resolution time stamps
1793 (Fprimitive_undo): Use them when restoring time stamps.
1795 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1796 (w32_get_internal_run_time):
1797 Port to higher-resolution Emacs time stamps.
1798 (ltime): Now accepts single 64-bit integer, as that's more convenient
1801 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1803 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1804 for compatibility with pselect. Support ns-resolution time stamps.
1806 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1808 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1809 Check for time stamp overflow, and support ns-resolution time stamps.
1811 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1812 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1813 (timeval_subtract): Remove; no longer needed.
1814 (XTflash, XTring_bell, x_wait_for_event):
1815 Port to ns-resolution time stamps. Don't assume time_t is signed.
1817 2012-06-22 Chong Yidong <cyd@gnu.org>
1819 * xdisp.c (x_consider_frame_title): Revert last change.
1821 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1823 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1824 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1825 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1826 staticidx goes up to 1597 out of 1600 = 0x640.)
1828 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1830 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1831 Otherwise, the umask might be mistakenly 0 while handling input signals.
1833 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1835 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1837 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1839 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1840 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1841 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1842 access to `contents' member of Lisp_Vector objects with AREF and ASET
1845 2012-06-19 Chong Yidong <cyd@gnu.org>
1847 * frame.c (delete_frame): When selecting a frame on a different
1848 text terminal, do not alter the terminal's top-frame.
1850 * xdisp.c (format_mode_line_unwind_data): Record the target
1851 frame's selected window and its terminal's top-frame.
1852 (unwind_format_mode_line): Restore them.
1853 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1855 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1856 since tty frames can be explicitly named.
1857 (prepare_menu_bars): Likewise.
1859 * term.c (Ftty_top_frame): New function.
1861 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1863 Port byte-code-meter to modern targets.
1864 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1865 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1866 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1867 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1868 (METER_1, METER_2): Simplify.
1870 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1872 * data.c (Fdefalias): Return `symbol' (bug#11686).
1874 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1876 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1877 gets killed during executing of this function (Bug#11665).
1878 Try to always return Qt when the buffer has been actually killed.
1879 (Vkill_buffer_query_functions): In doc-string say that functions
1880 run by this hook should not change the current buffer.
1882 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1884 Fix recently-introduced process.c problems found by static checking.
1885 * process.c (write_queue_push, write_queue_pop, send_process):
1886 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1887 (write_queue_pop): Fix pointer signedness problem.
1888 (send_process): Remove unused local.
1890 2012-06-17 Chong Yidong <cyd@gnu.org>
1892 * xdisp.c (redisplay_internal): No need to redisplay terminal
1893 frames that are not on top.
1895 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1897 * process.c (make_process): Initialize write_queue.
1898 (write_queue_push, write_queue_pop): New functions.
1899 (send_process): Use them to maintain correct ordering of process
1902 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1904 * lisp.h (eassert): Assume C89 or later.
1905 This removes the need for CHECK.
1906 (CHECK): Remove. Its comments about always evaluating its
1907 argument were confusing, as 'eassert' typically does not evaluate
1910 * coding.c (produce_chars): Use ptrdiff_t, not int.
1912 * xterm.c (x_draw_underwave): Check for integer overflow.
1913 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1915 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1917 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1918 referenced (Bug#11583).
1920 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1922 Implement wave-style variant of underlining.
1923 * dispextern.h (face_underline_type): New enum.
1924 (face): Add field for underline type.
1925 * nsterm.m (ns_draw_underwave): New function.
1926 (ns_draw_text_decoration): Use it.
1927 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1929 (x_draw_glyph_string): Use them.
1930 * xfaces.c (Qline, Qwave): New Lisp objects.
1931 (check_lface_attrs, merge_face_ref)
1932 (Finternal_set_lisp_face_attribute, realize_x_face):
1933 Handle wave-style underline face attributes.
1934 * xterm.c (x_draw_underwave): New function.
1935 (x_draw_glyph_string): Use it.
1937 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1939 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1940 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1941 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1942 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1943 ($(BLD)/w32select.$(O)): Update dependencies.
1945 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1947 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1948 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1949 * character.c (_fetch_multibyte_char_p): Remove.
1950 * alloc.c: Include "character.h" before "buffer.h".
1952 * buffer.c: Likewise.
1953 * bytecode.c: Likewise.
1954 * callint.c: Likewise.
1955 * callproc.c: Likewise.
1956 * casefiddle.c: Likewise.
1957 * casetab.c: Likewise.
1958 * category.c: Likewise.
1960 * coding.c: Likewise.
1961 * composite.c: Likewise.
1962 * dired.c: Likewise.
1963 * dispnew.c: Likewise.
1965 * dosfns.c: Likewise.
1966 * editfns.c: Likewise.
1967 * emacs.c: Likewise.
1968 * fileio.c: Likewise.
1969 * filelock.c: Likewise.
1971 * fontset.c: Likewise.
1972 * fringe.c: Likewise.
1973 * indent.c: Likewise.
1974 * insdel.c: Likewise.
1975 * intervals.c: Likewise.
1976 * keyboard.c: Likewise.
1977 * keymap.c: Likewise.
1978 * lread.c: Likewise.
1979 * macros.c: Likewise.
1980 * marker.c: Likewise.
1981 * minibuf.c: Likewise.
1982 * nsfns.m: Likewise.
1983 * nsmenu.m: Likewise.
1984 * print.c: Likewise.
1985 * process.c: Likewise.
1986 * regex.c: Likewise.
1987 * region-cache.c: Likewise.
1988 * search.c: Likewise.
1989 * syntax.c: Likewise.
1991 * textprop.c: Likewise.
1993 * unexsol.c: Likewise.
1994 * w16select.c: Likewise.
1995 * w32fns.c: Likewise.
1996 * w32menu.c: Likewise.
1997 * window.c: Likewise.
1998 * xdisp.c: Likewise.
2000 * xmenu.c: Likewise.
2002 * xselect.c: Likewise.
2004 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2006 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2007 If all the glyphs of the glyph row came from strings, and we have no
2008 cursor positioning clues, put the cursor on the first glyph of the
2010 (handle_face_prop): Use chunk-relative overlay string index when
2011 indexing into it->string_overlays array. (Bug#11653)
2012 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2013 the rightmost. (Bug#11720)
2015 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2017 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2018 (CATEGORY_MEMBER): Enforce 1/0 value.
2019 * category.c (_temp_category_set): Remove.
2021 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2023 * window.c (Fdelete_other_windows_internal)
2024 (Fdelete_window_internal): Don't access frame's mouse highlight
2025 info of the initial frame. (Bug#11677)
2027 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2029 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2030 Assume USE_2_TAGS_FOR_INTS.
2031 (xreload): Adjust $tagmask width to match recent lisp.h change.
2033 Simplify lisp.h in minor ways that should not affect code.
2034 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2035 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2036 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2037 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2038 (INTTYPEBITS): New macro, for clarity.
2039 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2040 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2041 Simplify now that USE_LSB_TAG is always defined.
2042 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2043 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2045 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2047 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2049 2012-06-13 Glenn Morris <rgm@gnu.org>
2051 * s/bsd-common.h (BSD4_3):
2052 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2054 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2056 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2059 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2061 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2062 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2063 * alloc.c (widen_to_Lisp_Object): Remove.
2064 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2065 * frame.c (delete_frame): Remove outdated comment.
2066 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2067 USE_LISP_UNION_TYPE.
2068 (Fw32_unregister_hot_key): Likewise.
2069 (Fw32_toggle_lock_key): Likewise.
2070 * w32menu.c (add_menu_item): Likewise.
2071 (w32_menu_display_help): Use XIL instead of checking
2072 USE_LISP_UNION_TYPE.
2073 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2074 (init_heap): Likewise.
2075 * w32term.c (w32_read_socket): Update comment.
2077 2012-06-13 Glenn Morris <rgm@gnu.org>
2079 * s/usg5-4-common.h, src/s/unixware.h:
2080 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2082 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2084 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2086 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2087 * alloc.c (make_number) [!defined make_number]:
2088 Remove, as lisp.h always defines this now.
2089 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2090 (roundup_size): Verify that it is a power of 2.
2091 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2092 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2093 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2094 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2095 USE_LSB_TAG now is always defined to be either 0 or 1.
2097 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2098 code works fine either way, and efficiency is not a concern here,
2099 as the union type is for debugging, not for production.
2100 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2101 Use an inline function on all platforms when using the union type,
2102 since this is simpler and 'static inline' can be used portably
2104 (LISP_INITIALLY_ZERO): New macro.
2105 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2106 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2108 2012-06-12 Glenn Morris <rgm@gnu.org>
2110 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2112 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2114 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2115 Move BROKEN_SIGIO to configure.
2117 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2118 Move NO_TERMIO to configure.
2120 2012-06-12 Chong Yidong <cyd@gnu.org>
2122 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2123 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2124 MagickExportImagePixels is undefined.
2126 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2128 * image.c (imagemagick_load_image): Remove unused label.
2130 2012-06-11 Glenn Morris <rgm@gnu.org>
2132 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2133 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2134 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2135 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2137 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2139 * alloc.c (make_byte_code): New function.
2140 (Fmake_byte_code): Use it. Don't purify here.
2141 * lread.c (read1): Use it as well to avoid extra allocation.
2143 2012-06-11 Chong Yidong <cyd@gnu.org>
2145 * image.c (imagemagick_load_image): Implement transparency.
2147 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2149 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2150 account for preceding backslashes. (Bug#11663)
2152 2012-06-09 Chong Yidong <cyd@gnu.org>
2154 * term.c: Support italics in capable terminals (Bug#9652).
2155 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2156 (turn_on_face): Output using TS_enter_italic_mode if available.
2157 Don't handle unused blinking and alt-charset cases.
2158 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2159 and tty_alt_charset_p cases.
2160 (tty_capable_p, init_tty): Support italics.
2162 * termchar.h (struct tty_display_info): Add field for italics.
2163 Remove unused blink field.
2165 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2168 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2169 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2170 tty_alt_charset_p. Add tty_italic_p.
2172 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2174 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2175 dbus_type_is_basic if available.
2176 (xd_extract_signed, xd_extract_unsigned): Rename from
2177 extract_signed and extract_unsigned, respectively. Adapt callers.
2179 2012-06-09 Chong Yidong <cyd@gnu.org>
2181 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2183 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2186 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2188 * xdisp.c (vmessage): Treat frame message as multibyte.
2189 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2190 would generate the diagnostic "Making \302\247 buffer-local while
2193 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2195 * dispnew.c (showing_window_margins_p): Undo last change, which
2196 was done due to an inadvertent commit.
2197 (adjust_frame_glyphs_for_frame_redisplay): Do call
2198 showing_window_margins_p.
2200 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2202 * eval.c (Fmake_var_non_special): New primitive.
2203 (syms_of_eval): Defsubr it.
2204 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2206 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2208 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2209 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2211 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2213 * alloc.c (allocate_vectorlike): Fix last change.
2215 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2217 Block-based vector allocation of small vectors.
2218 * lisp.h (struct vectorlike_header): New field `nbytes',
2219 adjust comment accordingly.
2220 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2221 to denote vector blocks. Adjust users (live_vector_p,
2222 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2223 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2224 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2225 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2226 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2227 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2228 (roundup_size): New constant.
2229 (struct vector_block): New data type.
2230 (vector_blocks, vector_free_lists, zero_vector): New variables.
2231 (all_vectors): Rename to `large_vectors'.
2232 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2233 (sweep_vectors): New functions.
2234 (allocate_vectorlike): Return `zero_vector' as the only vector of
2235 0 items. Allocate new vector from block if vector size is less than
2236 or equal to VBLOCK_BYTES_MAX.
2237 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2238 (init_alloc_once): Add call to init_vectors.
2240 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2242 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2244 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2246 * doprnt.c (doprnt): Truncate multibyte char correctly.
2247 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2248 would mishandle a string argument "Xc" if X was a multibyte
2249 character of length 2: it would truncate after X's first byte
2250 rather than including all of X.
2252 2012-06-06 Chong Yidong <cyd@gnu.org>
2254 * buffer.c (word_wrap): Doc fix.
2256 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2258 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2260 2012-06-03 Glenn Morris <rgm@gnu.org>
2262 * xdisp.c (tool-bar-style): Doc fix.
2264 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2266 * Makefile.in (PAXCTL): Define.
2267 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2268 binary via PaX flags if the paxctl utility is available.
2269 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2270 Restore PaX flags to their default. (Bug#11398)
2272 2012-06-03 Chong Yidong <cyd@gnu.org>
2274 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2277 2012-06-03 Chong Yidong <cyd@gnu.org>
2279 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2280 (note_mode_line_or_margin_highlight): If there is no help echo,
2281 use mode-line-default-help-echo. Handle the case where the mouse
2282 position is past the end of the mode line string.
2284 * buffer.c (buffer_local_value_1): New function, split from
2285 Fbuffer_local_value; can return Qunbound.
2286 (Fbuffer_local_value): Use it.
2287 (Vmode_line_format): Docstring tweaks.
2289 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2291 * sysdep.c (system_process_attributes): Improve comment.
2293 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2295 * keyboard.c: Export real-this-command to Elisp.
2296 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2297 and DEFVAR it. Update all users.
2299 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2301 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2303 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2304 Convert pctcpu and pctmem to Lisp float properly.
2305 Let the compiler fold better, as 100.0/0x8000 is exact.
2307 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2309 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2312 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2314 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2316 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2318 For a 'struct window', replace some Lisp_Object fields to
2319 bitfields where appropriate, remove unused fields.
2320 * window.h (struct window): Remove unused 'last_mark_x' and
2321 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2322 change it's type from Lisp_Object to bitfield.
2323 Change type of 'force_start', 'optional_new_start',
2324 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2325 fields from Lisp_Object to bitfield. Adjust users accordingly.
2327 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2329 Pacify gcc -Wdouble-precision when using Xaw.
2330 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2331 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2332 Use 'float' consistently, rather than 'float' in most places
2333 and 'double' in a couple of places.
2335 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2337 * xdisp.c (handle_stop): Detect whether we have overlay strings
2338 loaded by testing it->current.overlay_string_index to be
2339 non-negative, instead of checking whether n_overlay_strings is
2340 positive. (Bug#11587)
2342 2012-05-31 Chong Yidong <cyd@gnu.org>
2344 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2346 * doc.c (Fsubstitute_command_keys): Doc fix.
2348 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2350 * search.c (search_buffer): Remove calls to
2351 r_alloc_inhibit_buffer_relocation, as it is now called by
2352 maybe_unify_char, which was the cause of relocation of buffer text
2355 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2357 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2358 for the duration of call to load_charset, to avoid problems with
2359 callers of maybe_unify_char that access buffer text through C
2362 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2363 decrement the inhibition flag, instead of just setting or
2366 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2368 Remove obsolete '#define static' cruft.
2369 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2370 This #undef was "temporary" in 2000; it is no longer needed
2371 now that '#define static' has gone away.
2372 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2373 (gray_bitmap_bits): Remove; no longer needed.
2374 All uses replaced with definiens.
2375 * xterm.c: Include "bitmaps/gray.xbm".
2377 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2379 Clean up __executable_start, monstartup when --enable-profiling.
2380 The following changes affect the code only when profiling.
2381 * dispnew.c (__executable_start): Rename from safe_bcopy.
2382 Define only on platforms that need it.
2383 * emacs.c: Include <sys/gmon.h> when profiling.
2384 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2385 (__executable_start): Remove decl, since lisp.h does it now.
2386 (safe_bcopy): Remove decl; no longer has that name.
2387 (main): Coalesce #if into single bit of code, for simplicity.
2388 Cast pointers to uintptr_t, since standard libraries want integers
2390 * lisp.h (__executable_start): New decl.
2392 2012-05-31 Glenn Morris <rgm@gnu.org>
2394 * image.c (Fimagemagick_types): Doc fix.
2396 2012-05-30 Jim Meyering <meyering@redhat.com>
2398 * callproc.c (Fcall_process_region): Include directory component
2399 in mkstemp error message (Bug#11586).
2401 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2403 * alloc.c, lisp.h (make_pure_vector): Now static.
2405 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2407 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2408 Move to byte-run.el.
2409 (Fautoload): Do the hash-doc more carefully.
2410 * data.c (Fdefalias): Purify definition, except for keymaps.
2411 (Qdefun): Move from eval.c.
2412 * lisp.h (Qdefun): Remove.
2413 * lread.c (read1): Tiny simplification.
2415 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2417 Do not create empty overlays with the evaporate property (Bug#9642).
2418 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2419 Bug#9642, but explicitly check that the buffer the overlay would
2420 be moved to is live and rearrange lines to make sure that errors
2421 will not put the overlay in an inconsistent state.
2422 (Fdelete_overlay): Cosmetics.
2424 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2426 * w32term.c (my_bring_window_to_top): New function.
2427 (x_raise_frame): Use handle returned by DeferWindowPos, which
2428 could be different from the original one.
2429 Call my_bring_window_to_top instead of my_set_foreground_window.
2432 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2433 by calling BringWindowToTop.
2435 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2436 (WM_EMACS_END): Increase by one.
2438 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2440 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2441 This avoids undefined behavior that might cause the eassert
2442 to not catch an out-of-range value.
2444 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2446 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2447 Update dependencies.
2449 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2451 * bidi.c (bidi_mirror_char): Fix last change.
2453 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2455 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2456 when referring to sectname field in printf format.
2458 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2460 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2461 Only r_alloc_inhibit_buffer_relocation needed to be added;
2462 the others were already declared.
2464 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2465 before checking whether it's out of range. Put the check inside
2467 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2469 2012-05-27 Ken Brown <kbrown@cornell.edu>
2471 * callproc.c (Fcall_process): Restore a line that was accidentally
2472 commented out in the 2011-02-13 change (bug#11547).
2474 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2476 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2477 defined on ralloc.c.
2479 * buffer.c [REL_ALLOC]: Remove prototypes of
2480 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2481 they are now on lisp.h.
2483 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2485 * search.c (search_buffer): Use it to inhibit relocation of buffer
2486 text while re_search_2 is doing its job, because re_search_2 is
2487 passed C pointers to buffer text. (Bug#11519)
2489 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2492 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2493 state after an additional call to move_it_in_display_line_to, keep
2494 the values of it->max_ascent and it->max_descent found for the
2496 (pos_visible_p): Revert the comparison against bottom_y to what it
2497 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2500 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2502 Fix coding-related core dumps with gcc -ftrapv.
2503 The code was computing A - B, where A and B are pointers, and B is
2504 random garbage. This can lead to core dumps on platforms that
2505 have special pointer registers, and it also leads to core dumps on
2506 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2507 A - B only when B is initialized properly.
2508 * coding.c (coding_set_source, coding_set_destination): Return void.
2509 (coding_change_source, coding_change_destinations): New functions,
2510 with the old behaviors of coding_set_source and coding_set_destination.
2511 All callers that need an offset changed to use these new functions.
2513 2012-05-26 Glenn Morris <rgm@gnu.org>
2515 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2517 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2519 Extend mouse support on W32 text-mode console.
2520 * xdisp.c (draw_row_with_mouse_face):
2521 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2523 * w32console.c: Include window.h.
2524 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2526 (initialize_w32_display): Initialize mouse-highlight data.
2528 * w32inevt.c: Include termchar.h and window.h.
2529 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2530 moves, call note_mouse_highlight. If help_echo changed, call
2531 gen_help_event to produce help-echo message in the echo area.
2532 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2535 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2537 * lread.c (read1): Simplify slightly to avoid an overflow warning
2538 with GCC 4.7.0 on x86-64.
2540 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2542 * bidi.c (bidi_mirror_char): Revert last change: an int is
2543 definitely wide enough here.
2545 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2547 Fix integer width and related bugs (Bug#9874).
2548 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2549 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2550 (string_bytes, check_sblock, allocate_string_data):
2551 (compact_small_strings, Fmake_bool_vector, make_string)
2552 (make_unibyte_string, make_multibyte_string)
2553 (make_string_from_bytes, make_specified_string)
2554 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2555 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2558 (allocate_pseudovector):
2559 Use int, not EMACS_INT, where int is wide enough.
2560 (inhibit_garbage_collection, Fgarbage_collect):
2561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2562 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2563 int might not be wide enough.
2564 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2565 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2566 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2567 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2568 (bidi_level_of_next_char, bidi_move_to_visually_next):
2569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2570 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2571 (Fkill_buffer, Fset_buffer_major_mode)
2572 (advance_to_char_boundary, Fbuffer_swap_text)
2573 (Fset_buffer_multibyte, overlays_at, overlays_in)
2574 (overlay_touches_p, struct sortvec, record_overlay_string)
2575 (overlay_strings, recenter_overlay_lists)
2576 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2577 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2578 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2579 (Foverlay_recenter, last_overlay_modification_hooks_used)
2580 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2582 (validate_region): Omit unnecessary test for b <= e,
2583 since that's guaranteed by the previous test.
2584 (adjust_overlays_for_delete): Avoid pos + length overflow.
2585 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2586 (report_overlay_modification):
2587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2588 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2589 Omit pointer cast, which isn't needed anyway, and doesn't work
2590 after the EMACS_INT -> ptrdiff_t change.
2591 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2592 * buffer.h: Adjust decls to match defn changes elsewhere.
2593 (struct buffer_text, struct buffer):
2594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2595 Use EMACS_INT, not int, where int might not be wide enough.
2596 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2597 not int, to avoid needless 32-bit limit on 64-bit hosts.
2598 (exec_byte_code): Use tighter memory-full test, one that checks
2599 for alloca overflow. Don't compute the address of the object just
2600 before an array, as that's not portable. Use EMACS_INT, not
2601 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2602 * callint.c (Fcall_interactively):
2603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2604 * callproc.c (call_process_kill, Fcall_process):
2605 Don't assume pid_t fits into an Emacs fixnum.
2606 (call_process_cleanup, Fcall_process, child_setup):
2607 Don't assume pid_t fits into int.
2608 (call_process_cleanup, Fcall_process, delete_temp_file)
2609 (Fcall_process_region):
2610 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2611 (Fcall_process): Simplify handling of volatile integers.
2612 Use int, not EMACS_INT, where int will do.
2613 * casefiddle.c (casify_object, casify_region, operate_on_word)
2614 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2616 (casify_object): Avoid integer overflow when overallocating buffer.
2617 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2618 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2619 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2620 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2621 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2622 integers are now checked earlier. All uses replaced with XINT.
2624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2625 For CCL_MapSingle, check that content and value are in int range.
2626 (ccl_driver, Fregister_code_conversion_map):
2627 Check that Vcode_version_map_vector is a vector.
2628 (resolve_symbol_ccl_program): Check that vector header is in range.
2629 Always copy the vector, so that we can check its contents reliably
2630 now rather than having to recheck each instruction as it's being
2631 executed. Check that vector words fit in 'int'.
2632 (ccl_get_compiled_code, Fregister_ccl_program)
2633 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2634 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2635 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2636 contents are in range.
2637 (Fccl_execute_on_string): Check that status is in range.
2638 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2639 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2640 Accept and return EMACS_INT, not int, because callers can pass values
2642 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2643 (multibyte_chars_in_text, parse_str_as_multibyte)
2644 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2645 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2646 (string_escape_byte8, Fget_byte):
2647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2648 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2649 avoid mishandling large integers.
2650 * character.h: Adjust decls to match defn changes elsewhere.
2651 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2652 (Ffind_charset_region):
2653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2654 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2655 (load_charset_map_from_vector, Fdefine_charset_internal):
2656 Don't assume fixnum fits in int.
2657 (load_charset_map_from_vector, Fmap_charset_chars):
2658 Remove now-unnecessary CHECK_NATNUMs.
2659 (Fdefine_charset_internal): Check ranges here, more carefully.
2660 Don't rely on undefined behavior with signed left shift overflow.
2661 Don't assume unsigned int fits into fixnum, or that fixnum fits
2662 into unsigned int. Don't require max_code to be a valid fixnum;
2663 that's not true for gb10830 4-byte on a 32-bit host. Allow
2664 invalid_code to be a cons, for the same reason. Require code_offset
2665 to be a character. Avoid int overflow if max_char is close
2667 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2668 this is intended anyway and avoids some undefined behavior.
2669 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2670 INDEX_TO_CODE_POINT, as that's what it expects.
2671 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2672 * charset.h (DECODE_CHAR): Return int, not unsigned;
2673 this is what was intended anyway, and it avoids undefined behavior.
2674 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2675 integer-overflow issues.
2676 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2677 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2678 where the argument is EMACS_INT, and this behavior is not intended.
2679 * chartab.c (Fmake_char_table, Fset_char_table_range)
2680 (uniprop_get_decoder, uniprop_get_encoder):
2681 Don't assume fixnum fits in int.
2682 * cmds.c (move_point): New function, that does the gist of
2683 Fforward_char and Fbackward_char, but does so while checking
2684 for integer overflow more accurately.
2685 (Fforward_char, Fbackward_char): Use it.
2686 (Fforward_line, Fend_of_line, internal_self_insert)
2687 (internal_self_insert):
2688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2689 Fix a FIXME, by checking for integer overflow when calculating
2690 target_clm and actual_clm.
2691 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2692 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2693 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2694 (coding_alloc_by_making_gap, alloc_destination)
2695 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2696 (encode_coding_utf_16, detect_coding_emacs_mule)
2697 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2698 (detect_coding_iso_2022, decode_coding_iso_2022)
2699 (encode_invocation_designation, encode_designation_at_bol)
2700 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2701 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2702 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2703 (encode_coding_ccl, encode_coding_raw_text)
2704 (detect_coding_charset, decode_coding_charset)
2705 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2706 (produce_composition, produce_charset, produce_annotation)
2707 (decode_coding, handle_composition_annotation)
2708 (handle_charset_annotation, consume_chars, decode_coding_gap)
2709 (decode_coding_object, encode_coding_object, detect_coding_system)
2710 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2711 (code_convert_region, code_convert_string)
2712 (Fdefine_coding_system_internal)
2713 (coding_set_source, coding_set_destination):
2714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2715 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2716 (Fdefine_coding_system_internal):
2717 Don't assume fixnums fit in int.
2718 (decode_coding_gap, decode_coding_object, encode_coding_object)
2719 (Fread_coding_system, Fdetect_coding_region)
2720 (Funencodable_char_position, Fcheck_coding_systems_region)
2721 (get_translation, handle_composition_annotation, consume_chars):
2722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2723 (consume_chars): Rewrite to not calculate an address outside buffer.
2724 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2725 Don't access memory outside of the args array.
2726 (Fdefine_coding_system_internal): Check for charset-id overflow.
2727 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2728 result of ENCODE_CHAR.
2729 * coding.h: Adjust decls to match defn changes elsewhere.
2730 (struct coding_system):
2731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2732 * composite.c (get_composition_id, find_composition)
2733 (run_composition_function, update_compositions)
2734 (compose_text, composition_gstring_put_cache)
2735 (composition_gstring_p, composition_gstring_width)
2736 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2737 (composition_compute_stop_pos, composition_reseat_it)
2738 (composition_update_it, struct position_record)
2739 (find_automatic_composition, composition_adjust_point)
2740 (Fcomposition_get_gstring, Ffind_composition_internal):
2741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2742 (update_compositions):
2743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2744 * composite.h: Adjust decls to match defn changes elsewhere.
2745 (struct composition):
2746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2747 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2748 Do not attempt to compute the address of the object just before a
2749 buffer; this is not portable.
2751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2752 (Faset): Use int, not EMACS_INT, where int is wide enough.
2753 (Fstring_to_number): Don't assume fixnums fit in int.
2754 (Frem): Don't assume arg is nonnegative.
2755 * dbusbind.c (xd_append_arg): Check for integers out of range.
2756 (Fdbus_call_method): Don't overflow the timeout int.
2757 (extract_signed, extract_unsigned): New functions.
2758 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2759 (xd_get_connection_references): Return ptrdiff_t, not int.
2761 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2762 (xd_read_message_1):
2763 Use int, not unsigned, where the dbus API uses int.
2764 (Fdbus_message_internal): Don't overflow mtype.
2765 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2766 * dired.c (directory_files_internal, file_name_completion, scmp)
2767 (file_name_completion_stat):
2768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2769 (file_name_completion): Don't overflow matchcount.
2770 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2771 * dispextern.h: Adjust decls to match defn changes elsewhere.
2772 (struct text_pos, struct glyph, struct bidi_saved_info)
2773 (struct bidi_string_data, struct bidi_it, struct composition_it)
2775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2776 (struct display_pos, struct composition_it, struct it):
2777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2778 * dispnew.c (increment_matrix_positions)
2779 (increment_row_positions, mode_line_string)
2780 (marginal_area_string):
2781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2782 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2784 (duration_to_sec_usec): New function, to check for overflow better.
2785 (Fsleep_for, sit_for): Use it.
2786 * doc.c (get_doc_string, store_function_docstring):
2787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2788 (get_doc_string, Fsnarf_documentation):
2789 Use int, not EMACS_INT, where int is wide enough.
2791 Use SAFE_ALLOCA, not alloca.
2792 Check for overflow when converting EMACS_INT to off_t.
2793 * doprnt.c (doprnt):
2794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2795 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2796 Don't assume uid_t fits into fixnum.
2797 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2798 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2799 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2800 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2801 (general_insert_function)
2802 (Finsert_char, make_buffer_string, make_buffer_string_both)
2803 (update_buffer_properties, Fbuffer_substring)
2804 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2805 (Fsubst_char_in_region, check_translation)
2806 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2807 (transpose_markers, Ftranspose_regions):
2808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2809 (clip_to_bounds): Move to lisp.h as an inline function).
2810 (Fconstrain_to_field): Don't assume integers are nonnegative.
2811 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2812 (Fsubst_char_in_region, Fsave_restriction):
2813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2814 (Femacs_pid): Don't assume pid_t fits into fixnum.
2815 (lo_time): Use int, not EMACS_INT, when int suffices.
2816 (lisp_time_argument): Check for usec out of range.
2817 (Fencode_time): Don't assume fixnum fits in int.
2818 (Fuser_login_name, Fuser_full_name): Signal an error
2819 if a uid argument is out of range, rather than relying on
2821 (Fformat_time_string): Remove now-unnecessary check.
2822 lisp_time_argument checks for out-of-range usec now.
2823 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2824 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2825 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2826 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2827 (init_cmdargs, Fdump_emacs):
2828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2829 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2830 the bottom (typically) 32 bits of the fixnum.
2831 * eval.c (specpdl_size, call_debugger):
2832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2833 (when_entered_debugger, Fbacktrace_debug):
2834 Don't assume fixnum can fit in int.
2835 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2836 the object just before a buffer; this is not portable.
2837 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2838 (grow_specpdl, unbind_to):
2839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2840 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2841 (grow_specpdl): Simplify allocation by using xpalloc.
2842 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2843 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2844 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2846 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2849 (Fcopy_file, non_regular_nbytes, read_non_regular)
2850 (Finsert_file_contents):
2851 Use int, not EMACS_INT, where int is wide enough.
2852 (READ_BUF_SIZE): Verify that it fits in int.
2853 (Finsert_file_contents): Check that counts are in proper range,
2854 rather than assuming fixnums fit into ptrdiff_t etc.
2855 Don't assume fixnums fit into int.
2856 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2857 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2858 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2859 (string_char_to_byte, string_byte_to_char)
2860 (string_make_multibyte, string_to_multibyte)
2861 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2862 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2863 (substring_both, Fdelete, internal_equal, Ffillarray)
2864 (Fclear_string, mapcar1)
2865 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2866 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2867 (larger_vector, make_hash_table, maybe_resize_hash_table)
2868 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2869 (Fmaphash, secure_hash):
2870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2871 (concat): Check for string index and length overflow.
2872 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2875 (larger_vector): New API (vec, incr_min, size_max) replaces old
2876 one (vec, new_size, init). This catches size overflow.
2877 INIT was removed because it was always Qnil.
2878 All callers changed.
2879 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2880 the upper bound on a hash table index size.
2881 (make_hash_table, maybe_resize_hash_table): Use it.
2882 (secure_hash): Computer start_byte and end_byte only after
2883 they're known to be in ptrdiff_t range.
2884 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2885 (Ffont_get_glyphs, Ffont_at):
2886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2887 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2888 (Flist_fonts, Fopen_font):
2889 Don't assume fixnum can fit in int.
2890 (check_gstring): Don't assume index can fit in int.
2891 (font_match_p): Check that fixnum is a character, not a nonnegative
2892 fixnum, since the later code needs to stuff it into an int.
2893 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2894 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2895 conversion overflow issues.
2896 (Fopen_font): Check for integer out of range.
2897 (Ffont_get_glyphs): Don't assume index can fit in int.
2898 * font.h: Adjust decls to match defn changes elsewhere.
2899 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2901 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2902 printmax_t, where ptrdiff_t is wide enough.
2903 (Finternal_char_font):
2904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2905 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2906 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2907 (Fset_frame_position, x_set_frame_parameters)
2908 (x_set_line_spacing, x_set_border_width)
2909 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2910 Check that fixnums are in proper range for system types.
2911 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2912 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2913 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2914 Use SAFE_ALLOCA_LISP, not alloca.
2915 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2916 intptr_t is wide enough.
2917 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2918 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2919 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2920 Check for fixnum out of range.
2921 * ftfont.c (ftfont_list): Don't assume index fits in int.
2922 Check that fixnums are in proper range for system types.
2923 (ftfont_shape_by_flt):
2924 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2925 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2927 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2928 Check that fixnums are in proper range for system types.
2929 * gnutls.h: Adjust decls to match defn changes elsewhere.
2930 * gtkutil.c (xg_dialog_run):
2931 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2932 (update_frame_tool_bar):
2933 Check that fixnums are in proper range for system types.
2934 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2935 (lookup_image): Check that fixnums are in range for system types.
2936 * indent.c (last_known_column, last_known_column_point):
2937 (current_column_bol_cache):
2938 (skip_invisible, current_column, check_display_width):
2939 (check_display_width, scan_for_column, current_column_1)
2940 (Findent_to, Fcurrent_indentation, position_indentation)
2941 (indented_beyond_p, Fmove_to_column, compute_motion):
2942 (Fcompute_motion, Fvertical_motion):
2943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2944 (last_known_column_modified): Use EMACS_INT, not int.
2945 (check_display_width):
2947 Check that fixnums and floats are in proper range for system types.
2948 (compute_motion): Don't assume index or fixnum fits in int.
2949 (compute_motion, Fcompute_motion):
2950 Use int, not EMACS_INT, when it is wide enough.
2951 (vmotion): Omit local var start_hpos that is always 0; that way
2952 we don't need to worry about overflow in expressions involving it.
2953 * indent.h: Adjust decls to match defn changes elsewhere.
2955 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2956 Use int, not EMACS_INT, where int is wide enough.
2957 Remove unused members ovstring_chars_done and tab_offset;
2959 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2960 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2961 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2962 (make_gap, copy_text, insert, insert_and_inherit)
2963 (insert_before_markers, insert_before_markers_and_inherit)
2964 (insert_1, count_combining_before, count_combining_after)
2965 (insert_1_both, insert_from_string)
2966 (insert_from_string_before_markers, insert_from_string_1)
2967 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2968 (adjust_after_replace, adjust_after_insert, replace_range)
2969 (replace_range_2, del_range, del_range_1, del_range_byte)
2970 (del_range_both, del_range_2, modify_region)
2971 (prepare_to_modify_buffer, signal_before_change)
2972 (signal_after_change, Fcombine_after_change_execute):
2973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2974 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2975 (balance_an_interval, split_interval_right, split_interval_left)
2976 (find_interval, next_interval, update_interval)
2977 (adjust_intervals_for_insertion, delete_node, delete_interval)
2978 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2979 (static_offset_intervals, offset_intervals)
2980 (merge_interval_right, merge_interval_left, make_new_interval)
2981 (graft_intervals_into_buffer, temp_set_point_both)
2982 (temp_set_point, set_point, adjust_for_invis_intang)
2983 (set_point_both, move_if_not_intangible, get_property_and_range)
2984 (get_local_map, copy_intervals, copy_intervals_to_string)
2985 (compare_string_intervals, set_intervals_multibyte_1):
2986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2987 * intervals.h: Adjust decls to match defn changes elsewhere.
2989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2990 * keyboard.c (this_command_key_count, this_single_command_key_start)
2991 (before_command_key_count, before_command_echo_length, echo_now)
2992 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2993 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2994 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2995 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2997 (last_non_minibuf_size, last_point_position, echo_truncate)
2998 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2999 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3000 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3001 (stuff_buffered_input):
3002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3003 (last_auto_save, command_loop_1, read_char):
3004 Use EMACS_INT, not int, to avoid integer overflow.
3005 (record_char): Avoid overflow in total_keys computation.
3006 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3007 * keyboard.h: Adjust decls to match defn changes elsewhere.
3008 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3009 (Fkey_description, Fdescribe_vector, Flookup_key):
3010 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3011 (click_position): New function, to check that positions are in range.
3012 (Fcurrent_active_maps):
3014 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3015 (Faccessible_keymaps, Fkey_description):
3016 (preferred_sequence_p):
3017 Don't assume fixnum can fit into int.
3018 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3019 Check for integer overflow in size calculations.
3020 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3021 avoid mishandling large integers.
3022 * lisp.h: Adjust decls to match defn changes elsewhere.
3023 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3024 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3025 (struct Lisp_Marker):
3026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3027 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3028 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3029 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3030 All callers changed.
3031 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3032 Assume the arg has valid form, since it always does.
3033 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3034 unsigned integer system type.
3035 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3036 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3038 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3039 (duration_to_sec_usec): New decl.
3040 * lread.c (read_from_string_index, read_from_string_index_byte)
3041 (read_from_string_limit, readchar, unreadchar, openp)
3042 (read_internal_start, read1, oblookup):
3043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3044 (Fload, readevalloop, Feval_buffer, Feval_region):
3045 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3046 (openp): Check for out-of-range argument to 'access'.
3047 (read1): Use int, not EMACS_INT, where int is wide enough.
3048 Don't assume fixnum fits into int.
3049 Fix off-by-one error that can read outside a buffer.
3050 (read_filtered_event): Use duration_to_sec_usec
3051 to do proper overflow checking on durations.
3052 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3053 in size calculation.
3054 (Fexecute_kbd_macro):
3055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3056 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3057 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3058 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3059 (set_marker_both, set_marker_restricted_both, marker_position)
3060 (marker_byte_position, Fbuffer_has_markers_at):
3061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3062 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3063 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3064 It now merely ensures that the menu is large enough, without
3065 necessarily growing it, as this avoids some integer overflow issues.
3066 All callers changed.
3067 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3068 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3069 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3070 Use SAFE_ALLOCA_LISP, not alloca.
3071 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3072 to EMACS_INT. Check that fixnums are in proper range for system types.
3073 * minibuf.c (minibuf_prompt_width, string_to_object)
3074 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3075 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3077 (get_minibuffer, read_minibuf_unwind):
3078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3079 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3080 this simplifies overflow checking. All callers changed.
3081 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3083 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3084 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3085 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3086 Check that fixnums are in proper range for system types.
3087 (Fx_create_frame, Fx_show_tip):
3088 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3089 * nsfont.m (ns_findfonts, nsfont_list_family):
3090 Don't assume fixnum fits in long.
3091 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3092 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3093 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3095 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3096 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3097 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3098 (PRINTDECLARE, PRINTPREPARE):
3099 (strout, print_string):
3100 (print, print_preprocess, print_check_string_charset_prop)
3102 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3104 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3105 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3106 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3107 (printchar, strout): Use xpalloc to catch size calculation overflow.
3108 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3109 (print_error_message): Use SAFE_ALLOCA, not alloca.
3110 (print_object): Use int, not EMACS_INT, where int is wide enough.
3111 (print_depth, new_backquote_output, print_number_index):
3112 Use ptrdiff_t, not int, where int might not be wide enough.
3113 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3114 (Fset_process_window_size, Fformat_network_address)
3115 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3117 Check that fixnums are in proper range for system types.
3118 (Fsignal_process): Simplify by avoiding a goto.
3119 Check for process-ids out of pid_t range rather than relying on
3121 (process_tick, update_tick): Use EMACS_INT, not int.
3122 (Fformat_network_address, read_process_output, send_process)
3123 (Fprocess_send_region, status_notify):
3124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3125 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3126 (wait_reading_process_output, read_process_output, exec_sentinel):
3127 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3128 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3129 (Faccept_process_output): Use duration_to_sec_usec to do proper
3130 overflow checking on durations.
3131 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3132 Don't assume pid_t fits in int.
3133 * process.h (struct Lisp_Process): Members tick and update_tick
3134 are now of type EMACS_INT, not int.
3135 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3136 configured --with-wide-int.
3137 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3138 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3139 * search.c (looking_at_1, string_match_1):
3140 (fast_string_match, fast_c_string_match_ignore_case)
3141 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3142 (scan_newline, find_before_next_newline, search_command)
3143 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3144 (set_search_regs, wordify):
3147 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3148 (string_match_1, search_buffer, set_search_regs):
3150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3151 (wordify): Check for overflow in size calculation.
3152 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3153 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3154 Check that fixnums are in proper range for system types.
3155 * sound.c (struct sound_device)
3156 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3158 (Fplay_sound_internal):
3159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3160 * syntax.c (struct lisp_parse_state, find_start_modiff)
3161 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3162 (Fparse_partial_sexp):
3163 Don't assume fixnums can fit in int.
3164 (struct lisp_parse_state, find_start_pos, find_start_value)
3165 (find_start_value_byte, find_start_begv)
3166 (update_syntax_table, char_quoted, dec_bytepos)
3167 (find_defun_start, prev_char_comend_first, back_comment):
3168 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3169 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3171 (Finternal_describe_syntax_value): Check that match_lisp is a
3172 character, not an integer, since the code stuffs it into int.
3173 (scan_words, scan_sexps_forward):
3174 Check that fixnums are in proper range for system types.
3176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3177 (scan_sexps_forward):
3178 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3179 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3180 * syntax.h: Adjust decls to match defn changes elsewhere.
3181 (struct gl_state_s):
3182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3183 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3184 MOST_POSITIVE_FIXNUM.
3185 * sysdep.c (wait_for_termination_1, wait_for_termination)
3186 (interruptible_wait_for_termination, mkdir):
3187 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3188 (emacs_read, emacs_write):
3189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3190 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3191 and double all fit in int.
3192 * term.c (set_tty_color_mode):
3193 Check that fixnums are in proper range for system types.
3194 * termhooks.h (struct input_event):
3195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3196 * textprop.c (validate_interval_range, interval_of)
3197 (Fadd_text_properties, set_text_properties_1)
3198 (Fremove_text_properties, Fremove_list_of_text_properties)
3199 (Ftext_property_any, Ftext_property_not_all)
3200 (copy_text_properties, text_property_list, extend_property_ranges)
3201 (verify_interval_modification):
3202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3203 (Fnext_single_char_property_change)
3204 (Fprevious_single_char_property_change):
3205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3206 (copy_text_properties):
3207 Check for integer overflow in index calculation.
3208 * undo.c (last_boundary_position, record_point, record_insert)
3209 (record_delete, record_marker_adjustment, record_change)
3210 (record_property_change):
3211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3212 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3214 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3215 (Fx_hide_tip, Fx_file_dialog):
3216 * w32menu.c (set_frame_menubar):
3217 Use ptrdiff_t, not int, for consistency with rest of code.
3218 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3219 (select_window, Fdelete_other_windows_internal)
3220 (window_scroll_pixel_based, window_scroll_line_based)
3221 (Frecenter, Fset_window_configuration):
3222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3223 (Fset_window_hscroll, run_window_configuration_change_hook)
3224 (set_window_buffer, temp_output_buffer_show, scroll_command)
3225 (Fscroll_other_window, Frecenter):
3226 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3227 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3228 Don't assume fixnum fits in int.
3229 (Fset_window_scroll_bars):
3230 Check that fixnums are in proper range for system types.
3231 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3232 (string_pos, c_string_pos, number_of_chars, init_iterator)
3233 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3234 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3235 (compute_display_string_end, handle_face_prop)
3236 (face_before_or_after_it_pos, handle_invisible_prop)
3237 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3238 (display_prop_intangible_p, string_buffer_position_lim)
3239 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3240 (get_overlay_strings_1, get_overlay_strings)
3241 (iterate_out_of_display_property, forward_to_next_line_start)
3242 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3243 (get_next_display_element, set_iterator_to_next)
3244 (get_visually_first_element, compute_stop_pos_backwards)
3245 (handle_stop_backwards, next_element_from_buffer)
3246 (move_it_in_display_line_to, move_it_in_display_line)
3247 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3248 (add_to_log, message_dolog, message_log_check_duplicate)
3249 (message2, message2_nolog, message3, message3_nolog
3250 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3251 (current_message_1, truncate_echo_area, truncate_message_1)
3252 (set_message, set_message_1, store_mode_line_noprop)
3253 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3254 (text_outside_line_unchanged_p, check_point_in_composition)
3255 (reconsider_clip_changes)
3256 (redisplay_internal, set_cursor_from_row, try_scrolling)
3257 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3258 (redisplay_window, find_last_unchanged_at_beg_row)
3259 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3260 (trailing_whitespace_p, find_row_edges, display_line)
3261 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3262 (display_mode_element, store_mode_line_string)
3263 (pint2str, pint2hrstr, decode_mode_spec)
3264 (display_count_lines, display_string, draw_glyphs)
3265 (x_produce_glyphs, x_insert_glyphs)
3266 (rows_from_pos_range, mouse_face_from_buffer_pos)
3267 (fast_find_string_pos, mouse_face_from_string_pos)
3268 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3270 (safe_call, init_from_display_pos, handle_fontified_prop)
3271 (handle_single_display_spec, load_overlay_strings)
3272 (with_echo_area_buffer, setup_echo_area_for_printing)
3273 (display_echo_area, echo_area_display)
3274 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3275 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3276 (redisplay_window, dump_glyph_row, display_mode_line)
3277 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3278 (handle_display_spec, display_prop_string_p):
3279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3280 (handle_single_display_spec, build_desired_tool_bar_string)
3281 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3282 (get_specified_cursor_type):
3283 Check that fixnums are in proper range for system types.
3284 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3285 (Flookup_image_map):
3286 Don't assume fixnums fit in int.
3287 (compare_overlay_entries):
3288 Avoid mishandling comparisons due to subtraction overflow.
3289 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3290 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3291 (handle_tool_bar_click):
3292 Use int, not unsigned, since we prefer signed and the signedness
3293 doesn't matter here.
3294 (get_next_display_element, next_element_from_display_vector):
3295 Use int, not EMACS_INT, when int is wide enough.
3296 (start_hourglass): Use duration_to_sec_usec to do proper
3297 overflow checking on durations.
3298 * xfaces.c (Fbitmap_spec_p):
3299 Check that fixnums are in proper range for system types.
3300 (compare_fonts_by_sort_order):
3301 Avoid mishandling comparisons due to subtraction overflow.
3302 (Fx_family_fonts, realize_basic_faces):
3303 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3305 Don't assume fixnum fits in int.
3306 Use SAFE_ALLOCA_LISP, not alloca.
3307 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3308 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3309 (face_at_buffer_position, face_for_overlay_string)
3310 (face_at_string_position):
3311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3312 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3313 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3315 Check that fixnums are in proper range for system types.
3316 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3317 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3319 (Fx_change_window_property): Don't assume fixnums fit in int.
3320 * xfont.c (xfont_chars_supported):
3321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3322 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3323 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3325 * xml.c (parse_region):
3326 * xrdb.c (magic_file_p):
3327 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3328 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3329 (x_get_local_selection, x_reply_selection_request)
3330 (x_handle_selection_request, wait_for_property_change):
3331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3332 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3333 short is wide enough.
3334 (x_send_client_event): Don't assume fixnum fits in int.
3335 * xterm.c (x_x_to_emacs_modifiers):
3336 Don't assume EMACS_INT overflows nicely into int.
3337 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3339 (handle_one_xevent): NATNUMP can eval its arg twice.
3340 (x_connection_closed):
3341 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3342 * xterm.h: Adjust decls to match defn changes elsewhere.
3343 (struct scroll_bar): Use struct vectorlike_header
3344 rather than rolling our own approximation.
3345 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3347 2012-05-25 Glenn Morris <rgm@gnu.org>
3349 * lisp.mk (lisp): Update for more files being compiled now.
3351 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3353 * lread.c: Remove `read_pure' which makes no difference.
3354 (read_pure): Remove var.
3355 (unreadpure): Remove function.
3356 (readevalloop): Don't call read_list with -1 flag.
3357 (read1, read_vector): Don't test read_pure any more.
3358 (read_list): Simplify.
3360 * fileio.c, character.h: Minor style tweaks.
3362 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3364 * window.h (clip_changed): Remove useless declaration.
3366 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3368 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3369 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3371 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3374 This directory predates autoconf and is no longer needed nowadays.
3375 Move its few remaining bits of functionality to where they're needed.
3376 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3377 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3378 * m/template.h: Remove.
3379 * Makefile.in (M_FILE): Remove. All uses removed.
3380 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3381 * lisp.h (USE_LSB_TAG):
3382 * mem-limits.h (EXCEEDS_LISP_PTR):
3383 Use VAL_MAX, not VALBITS, in #if.
3384 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3385 (EMACS_UINT): Define unconditionally now.
3386 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3387 (BITS_PER_EMACS_INT): New constants, replacing
3388 what used to be in config.h, but not useful in #if.
3389 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3390 define them any more.
3391 (VAL_MAX): New macro.
3393 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3394 BITS_PER_EMACS_INT, in #if.
3395 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3396 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3397 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3398 * s/ms-w32.h (DATA_START):
3399 Move here from removed file m/intel386.h.
3400 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3401 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3403 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3405 Assume C89 or later.
3406 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3407 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3409 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3410 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3411 * textprop.c, tparam.c (NULL): Remove.
3412 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3413 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3414 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3415 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3416 * xterm.c (input_signal_count): Assume volatile works.
3418 2012-05-21 Ken Brown <kbrown@cornell.edu>
3420 * xgselect.c (xg_select): Fix first argument in call to 'select'
3423 2012-05-20 Ken Brown <kbrown@cornell.edu>
3425 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3426 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3428 2012-05-19 Ken Brown <kbrown@cornell.edu>
3430 * xfns.c (x_in_use): Remove `static' qualifier.
3431 * xterm.h (x_in_use): Declare.
3432 * xgselect.c: Include xterm.h.
3433 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3434 and `display_arg' (bug#9754).
3436 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3438 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3440 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3441 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3443 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3445 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3447 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3448 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3450 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3451 reference to image_cache->refcount.
3452 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3454 2012-05-17 Juri Linkov <juri@jurta.org>
3456 * search.c (Fword_search_regexp, Fword_search_backward)
3457 (Fword_search_forward, Fword_search_backward_lax)
3458 (Fword_search_forward_lax): Move functions to isearch.el
3459 (bug#10145, bug#11381).
3461 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3463 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3465 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3467 * lread.c (init_obarray): Declare Qt and Qnil as special.
3469 2012-05-14 Glenn Morris <rgm@gnu.org>
3471 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3472 Put "libexec" before "bin", for the sake of init_callproc_1.
3474 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3476 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3478 * unexaix.c: Port to more-recent AIX compilers.
3479 (report_error, report_error_1, make_hdr, copy_sym)
3480 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3481 Make arguments const char *, not char *, to avoid violations of C
3482 standard and to fix some AIX warnings reported by Gilles Pion.
3484 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3486 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3487 already have overlays loaded.
3488 (handle_single_display_spec): Before returning without displaying
3489 fringe bitmap, synchronize the bidi iterator with the main display
3490 iterator, by calling iterate_out_of_display_property.
3491 (iterate_out_of_display_property): Detect buffer iteration by
3492 testing that it->string is a Lisp string.
3493 (get_next_display_element): When the current object is exhausted,
3494 and there's something on it->stack, call set_iterator_to_next to
3495 proceed with what's on the stack, instead of returning zero.
3496 (set_iterator_to_next): If called at the end of a Lisp string,
3497 proceed to consider_string_end without incrementing string
3498 position. Don't increment display vector index past the end of
3499 the display vector. (Bug#11417)
3500 (pos_visible_p): Don't report a position visible when move_it_to
3501 stopped at the last line of window, which happens to be scanned
3502 backwards by the bidi iteration. (Bug#11464)
3504 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3506 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3507 and right-margin display specs even if the spec is invalid or we
3508 are on a TTY, and thus unable to display on the fringes.
3509 That's because the text with the property will not be displayed anyway,
3510 so we need to signal to the caller that this is a "replacing"
3511 display spec. This fixes display when the spec is invalid or we
3514 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3516 * unexaix.c (make_hdr): Fix typo in prototype.
3517 This bug broke the build on AIX. Problem reported by Gilles Pion.
3519 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3521 * keyboard.c (kbd_buffer_get_event): Read special events also in
3522 batch mode. (Bug#11415)
3524 2012-05-12 Glenn Morris <rgm@gnu.org>
3526 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3528 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3530 * lisp.mk (lisp): Add newcomment.elc.
3532 2012-05-12 Glenn Morris <rgm@gnu.org>
3534 * Makefile.in (MKDIR_P): New, set by configure.
3535 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3537 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3539 Remove unused function hourglass_started.
3540 * dispextern.h (hourglass_started):
3541 * w32fns.c (hourglass_started):
3542 * xdisp.c (hourglass_started): Remove.
3544 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3546 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3547 Update dependencies.
3549 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3551 * xgselect.c (xg_select): Put maxfds+1 into a var.
3552 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3554 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3556 2012-05-10 Dave Abrahams <dave@boostpro.com>
3558 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3559 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3561 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3563 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3564 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3565 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3566 Initialize xd_registered_buses.
3568 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3570 Untag more efficiently if USE_LSB_TAG.
3571 This is based on a proposal by YAMAMOTO Mitsuharu in
3572 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3573 For an admittedly artificial (nth 8000 longlist) benchmark on
3574 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3575 Emacs's overall text size by 1%.
3576 * lisp.h (XUNTAG): New macro.
3577 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3578 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3579 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3580 * eval.c (Fautoload):
3581 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3582 * frame.h (XFRAME): Use XUNTAG.
3584 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3585 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3586 Remove unportable assumptions about print widths of types like
3588 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3589 intptr_t when converting between pointer and integer, to avoid GCC
3590 warnings about wrong width.
3592 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3594 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3595 stack for each reader_thread, instead of defaulting to 8MB
3596 determined by the linker. This avoids failures in creating
3597 subprocesses on Windows 7, see the discussion in this thread:
3598 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3600 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3602 Fix up display of the *Minibuf-0* buffer in the mini window.
3603 * keyboard.c (read_char): Don't clear the echo area if there's no
3605 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3606 contents of *Minibuf-0*) if there's no message displayed in its stead.
3608 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3610 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3613 2012-05-06 Chong Yidong <cyd@gnu.org>
3615 * lisp.mk (lisp): Update.
3617 2012-05-05 Jim Meyering <meyering@redhat.com>
3619 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3621 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3623 * data.c (PUT_ERROR): New macro.
3624 (syms_of_data): Use it. Add new error type `user-error'.
3625 * undo.c (user_error): New function.
3626 (Fprimitive_undo): Use it.
3627 * print.c (print_error_message): Adjust print style for `user-error'.
3628 * keyboard.c (user_error): New function.
3629 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3631 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3633 Do not limit current-time-string to years 1000..9999.
3634 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3635 (Fcurrent_time_string): Support any year that is supported by the
3636 underlying localtime representation. Don't use asctime, as it
3637 has undefined behavior for years outside the range -999..9999.
3639 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3641 Fix race conditions involving setenv, gmtime, localtime, asctime.
3642 Without this fix, interrupts could mess up code that uses these
3643 nonreentrant functions, since setting TZ invalidates existing
3644 tm_zone or tzname values, and since most of these functions return
3645 pointers to static storage.
3646 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3647 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3648 Grow the critical sections to include not just invoking
3649 localtime/gmtime, but also accessing these functions' results
3650 including their tm_zone values if any, and any related TZ setting.
3651 (format_time_string): Last arg is now struct tm *, not struct tm **,
3652 so that the struct tm is saved in the critical section.
3653 All callers changed. Simplify allocation of initial buffer, partly
3654 motivated by the fact that memory allocation needs to be outside
3655 the critical section.
3657 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3659 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3660 with RESET_INTERVAL.
3662 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3663 Remove duplicated buffer name initialization.
3665 2012-05-02 Jim Meyering <jim@meyering.net>
3667 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3669 * xfns.c (x_window): Use xstrdup (Bug#11375).
3671 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3673 * xdisp.c (pos_visible_p): If already at a newline from the
3674 display string before the 'while' loop, don't walk back the glyphs
3675 from it3.glyph_row. Solves assertion violation when the display
3676 string begins with a newline (egg.el). (Bug#11367)
3678 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3680 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3683 2012-05-01 Glenn Morris <rgm@gnu.org>
3685 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3686 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3687 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3688 All were removed before 23.1.
3690 * dispnew.c: Remove HAVE_LIBNCURSES test;
3691 it is always true on relevant platforms.
3693 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3694 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3696 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3698 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3700 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3701 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3704 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3706 Do not avoid creating empty evaporating overlays (Bug#9642).
3707 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3708 That is, do not delete an evaporating overlay if it becomes
3709 empty after its bounds are adjusted to fit within its buffer.
3710 This fix caused other problems, and I'm reverting it until we get
3711 to the bottom of them.
3713 2012-04-27 Chong Yidong <cyd@gnu.org>
3715 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3717 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3719 * xdisp.c (pos_visible_p): If the window start position is beyond
3720 ZV, start the display from buffer beginning. Prevents assertion
3721 violation in init_iterator when the minibuffer window is scrolled
3724 * window.c (window_scroll_pixel_based): Likewise.
3726 2012-04-27 Chong Yidong <cyd@gnu.org>
3728 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3730 2012-04-27 Glenn Morris <rgm@gnu.org>
3732 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3733 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3735 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3737 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3738 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3740 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3742 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3743 display element, check also the underlying string or buffer
3744 character. (Bug#11341)
3746 * w32menu.c: Include w32heap.h.
3747 (add_menu_item): If the call to AppendMenuW (via
3748 unicode_append_menu) fails, disable Unicode menus only if we are
3749 running on Windows 9X/Me.
3751 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3753 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3754 (xgetint): Add missing shift for LSB tags.
3756 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3758 * keyboard.c (read_char): Don't wipe echo area for select window
3759 events: These might get delayed via `mouse-autoselect-window'
3762 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3764 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3765 manipulation of :loaded-from data.
3767 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3769 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3770 now a cons (bug#11311).
3772 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3774 Do not create empty overlays with the evaporate property (Bug#9642).
3775 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3776 if it becomes empty after its bounds are adjusted to fit within
3777 its buffer. Without this fix, in a nonempty buffer (let ((o
3778 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3779 yields an empty overlay that has the evaporate property, which is
3780 not supposed to happen.
3782 Fix minor GTK3 problems found by static checking.
3783 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3784 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3785 (struct _EmacsFixedClass, emacs_fixed_get_type):
3786 Move decls here from emacsgtkfixed.h, since they needn't be public.
3787 (emacs_fixed_get_type): Now static.
3788 (emacs_fixed_class_init): Omit unused local.
3789 (emacs_fixed_child_type): Remove; unused.
3790 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3791 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3792 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3793 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3794 (EMACS_FIXED_GET_CLASS): Remove; unused.
3795 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3797 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3798 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3800 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3802 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3803 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3804 (__malloc_size_t, __malloc_ptrdiff_t):
3805 Remove. All uses removed, replaced by the definiens if needed,
3806 since we can assume C89 or better now.
3807 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3808 (protect_malloc_state, align, get_contiguous_space)
3809 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3810 (malloc_atfork_handler_child, malloc_enable_thread)
3811 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3812 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3813 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3814 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3815 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3816 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3817 Define using prototypes, not old style.
3818 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3819 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3820 (align): Don't assume that signed integer overflow wraps around.
3821 Omit unused local var.
3822 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3823 (_free_internal_nolock, memalign, mallochook, reallochook):
3824 Omit no-longer-needed casts.
3825 (valloc): Use getpagesize, not __getpagesize.
3826 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3827 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3829 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3831 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3833 Move functions from C to Lisp. Make non-blocking method calls
3834 the default. Implement further D-Bus standard interfaces.
3836 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3837 (QCdbus_request_name_allow_replacement)
3838 (QCdbus_request_name_replace_existing)
3839 (QCdbus_request_name_do_not_queue)
3840 (QCdbus_request_name_reply_primary_owner)
3841 (QCdbus_request_name_reply_in_queue)
3842 (QCdbus_request_name_reply_exists)
3843 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3844 (QCdbus_registered_serial, QCdbus_registered_method)
3845 (QCdbus_registered_signal): New Lisp objects.
3846 (XD_DEBUG_MESSAGE): Use sizeof.
3847 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3848 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3849 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3850 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3851 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3852 (xd_signature, xd_append_arg): Allow float for integer types.
3853 (xd_get_connection_references): New function.
3854 (xd_get_connection_address): Rename from xd_initialize.
3855 Return cached address.
3856 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3857 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3859 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3860 Return number of refcounts.
3861 (Fdbus_get_unique_name): Make stronger parameter check.
3862 (Fdbus_message_internal): New defun.
3863 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3864 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3865 (Fdbus_send_signal, Fdbus_register_service)
3866 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3867 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3868 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3869 (Vdbus_compiled_version, Vdbus_runtime_version)
3870 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3871 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3872 (Vdbus_message_type_signal): New defvars.
3873 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3876 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3878 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3879 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3880 Do not assume ptrdiff_t is the same width as 'int'.
3882 * alloc.c: Handle unusual debugging option combinations.
3883 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3884 since the two debugging options are incompatible.
3885 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3887 (mem_init, mem_insert, mem_insert_fixup):
3888 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3889 (NEED_MEM_INSERT): Remove; no longer needed.
3891 2012-04-22 Leo Liu <sdl.web@gmail.com>
3893 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3895 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3897 * sysdep.c [__FreeBSD__]: Minor cleanups.
3898 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3899 Use Emacs indenting style more consistently. Avoid some casts.
3900 Use 'double' consistently rather than mixing 'float' and 'double'.
3902 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3904 * sysdep.c (list_system_processes, system_process_attributes):
3905 Add implementation for FreeBSD (Bug#5243).
3907 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3909 * lisp.mk (lisp): Update.
3911 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3913 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3914 It is never used otherwise.
3916 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3918 * print.c (print_preprocess): Only check print_depth if print-circle
3920 (print_object): Check for cycles even when print-circle is nil and
3921 print-gensym is t, but only check print_depth if print-circle is nil.
3923 2012-04-20 Chong Yidong <cyd@gnu.org>
3925 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3926 set the status to "failed" and ensure that sentinel is run.
3928 2012-04-20 Glenn Morris <rgm@gnu.org>
3930 * process.c (Fset_process_inherit_coding_system_flag)
3931 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3932 (Fmake_network_process, Fmake_serial_process): Doc fix.
3934 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3936 * xdisp.c (string_buffer_position_lim): Limit starting position to
3938 (set_cursor_from_row): If called for a mode-line or header-line
3939 row, return zero immediately.
3940 (try_cursor_movement): If inside continuation line, don't back up
3941 farther than the first row after the header line, if any.
3942 Don't consider the header-line row as "partially visible", even if
3943 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3945 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3947 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3950 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3951 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3953 configure: new option --enable-gcc-warnings (Bug#11207)
3954 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3955 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3956 (ALL_CFLAGS): Use new macros rather than old.
3957 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3958 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3959 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3960 -Wunused-result, -Wunused-variable. This should go away once
3961 the Emacs and Gnulib regex code is merged.
3962 (xmalloc, xrealloc): Now static.
3964 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3966 * dired.c (Fsystem_groups): Remove unused local.
3968 2012-04-17 Glenn Morris <rgm@gnu.org>
3970 * dired.c (Fsystem_users): Doc fix.
3972 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3974 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3975 (syms_of_dired): Add them.
3977 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3979 Fix minor alloc.c problems found by static checking.
3980 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3981 New extern decls, to avoid calling undeclared functions.
3982 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3983 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3984 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3985 (NEED_MEM_INSERT): New macro.
3986 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3987 Remove one incorrect comment and fix another.
3989 Fix minor ralloc.c problems found by static checking.
3990 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3991 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3992 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3993 (r_alloc_sbrk): Now static.
3995 Improve ralloc.c interface checking.
3996 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3997 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3998 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3999 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4000 [REL_ALLOC]: ... to here, to check interface.
4001 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4002 Remove decls. This fixes an "It stinks!".
4004 * alloc.c (which_symbols): Fix alignment issue / type clash.
4006 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4008 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4009 (struct Lisp_Misc_Any): Likewise.
4010 (struct Lisp_Free): Likewise.
4011 * alloc.c (union aligned_Lisp_Symbol): Define.
4012 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4013 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4014 (union aligned_Lisp_Misc): Define.
4015 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4016 aligned_Lisp_Misc instead of union Lisp_Misc.
4017 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4019 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4021 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4022 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4023 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4024 * s/netbsd.h, s/sol2-6.h:
4025 Remove definition of GC_MARK_STACK, since the default now works.
4026 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4027 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4028 no longer the default.
4029 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4031 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4033 * lread.c (lisp_file_lexically_bound_p):
4034 Fix hang at ";-*-\n" (bug#11238).
4036 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4038 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4039 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4041 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4043 * nsterm.m (constrainFrameRect): Always constrain when there is only
4044 one screen (Bug#10962).
4046 2012-04-13 Ken Brown <kbrown@cornell.edu>
4048 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4050 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4052 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4054 2012-04-11 Daniel Colascione <dancol@dancol.org>
4056 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4057 against is gone. It's better to use vfork now so that when Cygwin
4058 gains a new, working vfork, we use it automatically (bug#10398).
4060 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4062 * window.c (save_window_save): Obey window-point-insertion-type.
4064 2012-04-11 Glenn Morris <rgm@gnu.org>
4066 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4068 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4070 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4072 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4074 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4075 (force_quit_count): New var.
4076 (handle_interrupt): Use it.
4078 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4080 * w32.c (w32_delayed_load): Record the full path of the library
4081 being loaded (bug#10424).
4083 2012-04-09 Glenn Morris <rgm@gnu.org>
4085 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4086 not just in the obarray, before snarfing them. (Bug#11036)
4088 * Makefile.in ($(leimdir)/leim-list.el):
4089 Pass EMACS rather than BUILT_EMACS.
4091 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4093 * process.c (make_process):
4094 * process.h: Add integer `gnutls_handshakes_tried' member to
4097 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4098 Add convenience `GNUTLS_LOG2i' macro.
4100 * gnutls.c (gnutls_log_function2i): Convenience log function.
4101 (emacs_gnutls_read): Use new log functions,
4102 `gnutls_handshakes_tried' process member, and
4103 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4104 attempts per process (connection).
4106 2012-04-09 Chong Yidong <cyd@gnu.org>
4108 * eval.c (Fuser_variable_p, user_variable_p_eh)
4109 (lisp_indirect_variable): Functions deleted.
4110 (Fdefvar): Caller changed.
4112 * callint.c (Finteractive, Fcall_interactively):
4113 * minibuf.c (Fread_variable): Callers changed.
4115 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4117 * xdisp.c (set_cursor_from_row): If the display string appears in
4118 the buffer at position that is closer to point than the position
4119 after the display string, display the cursor on the first glyph of
4120 the display string. Fixes cursor display when a 'display' text
4121 property immediately follows invisible text. (Bug#11094)
4123 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4125 composite.c: use 'double' consistently
4126 * composite.c (get_composition_id): Use 'double' consistently
4127 instead of converting 'float' to 'double' and vice versa; this is
4128 easier to understand and avoids a GCC warning.
4130 2012-04-09 Glenn Morris <rgm@gnu.org>
4132 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4133 preparation for dumping it with emacs. (Bug#4789)
4134 (leimdir): New variable.
4135 ($(leimdir)/leim-list.el): New rule.
4136 (emacs$(EXEEXT)): Depend on leim-list.el.
4138 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4139 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4140 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4142 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4144 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4147 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4149 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4150 Remove unused local variable.
4152 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4154 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4155 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4156 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4157 objects, as mark_maybe_pointer will catch them otherwise.
4158 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4159 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4161 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4163 Fix typo that broke non-Windows builds.
4164 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4166 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4168 Support building on MS-Windows with libxml2.
4170 * makefile.w32-in (OBJ2): Add xml.$(O).
4171 (GLOBAL_SOURCES): Add xml.c.
4172 ($(BLD)/xml.$(O)): New dependency list.
4174 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4175 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4176 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4177 [!WINDOWSNT]: New macros.
4178 (init_libxml2_functions, libxml2_loaded_p): New functions.
4179 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4180 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4181 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4182 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4184 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4185 Call init_libxml2_functions before calling libxml2 functions.
4186 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4188 * emacs.c: Don't include libxml/parser.h.
4189 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4190 xmlCleanupParser directly.
4192 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4194 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4196 * indent.c (Fvertical_motion): If there is a display string at
4197 point, use it.vpos to compute how many lines to backtrack after
4198 move_it_to point. (Bug#11133)
4200 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4202 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4203 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4204 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4205 macros related to unification of CJK characters. For the details,
4206 see the discussion following the message here:
4207 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4209 2012-04-04 Chong Yidong <cyd@gnu.org>
4211 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4213 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4215 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4216 instead of alloca. (Bug#11138)
4218 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4220 * w32menu.c (is_simple_dialog): Properly check lisp types.
4223 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4225 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4226 position we get to after a call to move_it_to fails the
4227 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4228 only if we wind up in a string from display property. (Bug#11063)
4230 * window.c (Fdelete_other_windows_internal): Invalidate the row
4231 and column information about mouse highlight, so that redisplay
4232 restores it after reallocating the glyph matrices. (Bug#7464)
4234 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4235 string comes from a `display' text property, use the buffer
4236 position of that property as if we actually saw that position in
4238 (move_it_by_lines): Remove the assertion that
4239 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4240 violated when there's a before-string at the beginning of a line.
4243 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4245 * xdisp.c (append_space_for_newline): If the default face was
4246 remapped, use the remapped face for the appended newline.
4247 (extend_face_to_end_of_line): Use the remapped default face for
4248 extending the face to the end of the line.
4249 (display_line): Call extend_face_to_end_of_line when the default
4250 face was remapped. (Bug#11068)
4252 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4254 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4256 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4258 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4260 2012-03-27 Glenn Morris <rgm@gnu.org>
4262 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4265 2012-03-26 Kenichi Handa <handa@m17n.org>
4267 * dispextern.h (struct glyph): Fix previous change. Change the
4268 bit length of glyphless.ch to 25 (Bug#11082).
4270 2012-03-26 Chong Yidong <cyd@gnu.org>
4272 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4273 (command_loop_1): Use it; inhibit selection update for
4274 handle-select-window too (Bug#8996).
4276 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4278 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4280 2012-03-25 Kenichi Handa <handa@m17n.org>
4282 * dispextern.h (struct glyph): Change the bit length of
4283 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4285 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4287 * s/ms-w32.h (tzname): Include time.h before redirecting to
4288 _tzname. Fixes the MSVC build. (Bug#9960)
4290 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4292 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4295 * xterm.c (XTread_socket): Only modify handling_signal if
4296 !SYNC_INPUT. (Bug#11080)
4298 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4300 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4301 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4302 when fetching a multibyte character consumes more bytes than
4303 CHAR_BYTES returns, due to unification of CJK characters in
4304 string_char. (Bug#11073)
4306 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4308 * process.c (wait_reading_process_output): Handle pty disconnect
4309 by refraining from sending oneself a SIGCHLD (bug#10933).
4311 2012-03-22 Chong Yidong <cyd@gnu.org>
4313 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4315 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4316 Mark string as coming from a prefix property.
4317 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4318 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4320 2012-03-21 Chong Yidong <cyd@gnu.org>
4322 * xfaces.c (Vface_remapping_alist): Doc fix.
4324 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4326 * w32proc.c (Fw32_set_console_codepage)
4327 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4330 2012-03-20 Chong Yidong <cyd@gnu.org>
4332 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4333 to reflect default non-nil value of redisplay-dont-pause.
4335 2012-03-19 Kenichi Handa <handa@m17n.org>
4337 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4338 it fit in a valid range (Bug#11003).
4340 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4342 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4343 that is not from display property, accept the row as a "cursor
4344 row" if one of the string's character has a non-nil `cursor'
4345 property. Fixes cursor positioning when there are newlines in
4346 overlay strings, e.g. in icomplete.el. (Bug#11035)
4348 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4350 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4352 2012-03-12 Chong Yidong <cyd@gnu.org>
4354 * eval.c (inhibit_lisp_code): Rename from
4355 inhibit_window_configuration_change_hook; move from window.c.
4357 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4358 * window.c (run_window_configuration_change_hook)
4359 (syms_of_window): Callers changed.
4361 2012-03-11 Chong Yidong <cyd@gnu.org>
4363 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4365 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4367 2012-03-10 Chong Yidong <cyd@gnu.org>
4369 * frame.c (other_visible_frames): Don't assume the selected frame
4370 is visible (Bug#10955).
4372 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4374 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4376 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4378 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4379 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4382 2012-03-03 Glenn Morris <rgm@gnu.org>
4384 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4386 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4388 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4389 position past the first glyph_row that ends at ZV. (Bug#10902)
4390 (redisplay_window, next_element_from_string): Fix typos in
4392 (redisplay_window): Pass to move_it_vertically the margin in
4393 pixels, not in screen lines.
4395 2012-03-02 Glenn Morris <rgm@gnu.org>
4397 * buffer.c (buffer-list-update-hook): Doc fix.
4399 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4401 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4402 push_it before setting up the iterator for the first overlay
4403 string, even if we have an empty string loaded.
4404 (next_overlay_string): If there's an empty string on the iterator
4405 stack, pop the stack. (Bug#10903)
4407 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4409 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4410 Suggested by Stefan Monnier in
4411 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4412 * alloc.c (widen_to_Lisp_Object): New static function.
4413 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4414 and widening them to Lisp_Objects. This would work even if
4415 USE_LSB_TAG is defined and wide integers are used, which might
4416 happen in a future version of Emacs.
4418 2012-02-25 Chong Yidong <cyd@gnu.org>
4420 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4423 * xselect.c (Fx_selection_exists_p): Doc fix.
4424 (x_clipboard_manager_save_all): Print an informative message
4425 before saving to clipboard manager.
4427 2012-02-24 Chong Yidong <cyd@gnu.org>
4429 * keyboard.c (process_special_events): Handle all X selection
4430 requests in kbd_buffer, not just the next one (Bug#8869).
4432 2012-02-23 Chong Yidong <cyd@gnu.org>
4434 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4435 call when setting menu-bar-lines and tool-bar-lines parameters.
4436 (unwind_create_frame_1): New helper function.
4438 * window.c (inhibit_window_configuration_change_hook): New var.
4439 (run_window_configuration_change_hook): Obey it.
4440 (syms_of_window): Initialize it.
4442 2012-02-22 Chong Yidong <cyd@gnu.org>
4444 * xterm.c (x_draw_image_relief): Add missing type check for
4445 Vtool_bar_button_margin (Bug#10743).
4447 2012-02-21 Chong Yidong <cyd@gnu.org>
4449 * fileio.c (Vfile_name_handler_alist): Doc fix.
4451 * buffer.c (Fget_file_buffer): Protect against invalid file
4452 handler return value.
4454 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4456 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4457 when computing $valmask.
4459 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4460 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4461 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4462 It's useless in that case, and it can cause problems on hosts
4463 that allocate halves of EMACS_INT values separately.
4464 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4465 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4466 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4467 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4468 it avoids undefined behavior on hosts where shifting right by more
4469 than the word width has undefined behavior.
4471 2012-02-19 Chong Yidong <cyd@gnu.org>
4473 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4474 (Funhandled_file_name_directory, Ffile_name_as_directory)
4475 (Fdirectory_file_name, Fexpand_file_name)
4476 (Fsubstitute_in_file_name): Protect against invalid file handler
4477 return values (Bug#10845).
4479 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4481 * .gdbinit (pitx): Fix incorrect references to fields of the
4484 2012-02-17 Chong Yidong <cyd@gnu.org>
4486 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4488 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4490 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4491 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4493 2012-02-15 Chong Yidong <cyd@gnu.org>
4495 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4496 marked as special. Also, starting docstrings with * is obsolete.
4498 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4500 * gnutls.c (emacs_gnutls_write): Fix last change.
4502 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4504 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4507 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4509 * keymap.c (Fsingle_key_description): Handle char ranges.
4511 2012-02-12 Chong Yidong <cyd@gnu.org>
4513 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4514 as that creates a dangerous corner case.
4516 * window.c (Fdelete_window_internal): Invalidate the mouse
4517 highlight (Bug#9904).
4519 2012-02-12 Glenn Morris <rgm@gnu.org>
4521 * xselect.c (Fx_own_selection_internal)
4522 (Fx_get_selection_internal, Fx_disown_selection_internal)
4523 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4524 * nsselect.m (Fx_own_selection_internal)
4525 (Fx_disown_selection_internal, Fx_selection_exists_p)
4526 (Fx_selection_owner_p, Fx_get_selection_internal):
4527 Sync docs and argument specs with the xselect.c versions.
4529 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4531 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4533 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4535 * w32select.c (Fx_selection_exists_p): Sync doc string and
4536 argument list with xselect.c. (Bug#10783)
4538 * w16select.c (Fx_selection_exists_p): Sync doc string and
4539 argument list with xselect.c. (Bug#10783)
4541 2012-02-10 Glenn Morris <rgm@gnu.org>
4543 * fns.c (Fsecure_hash): Doc fix.
4545 2012-02-09 Kenichi Handa <handa@m17n.org>
4547 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4549 2012-02-07 Chong Yidong <cyd@gnu.org>
4551 * buffer.c (Fbuffer_local_variables)
4552 (buffer_lisp_local_variables): Handle unbound vars correctly;
4553 don't let Qunbound leak into Lisp.
4555 2012-02-07 Glenn Morris <rgm@gnu.org>
4557 * image.c (Fimagemagick_types): Doc fix.
4559 * image.c (imagemagick-render-type): Change it from a lisp object
4560 to an integer. Move the doc here from the lisp manual.
4561 Treat all values not equal to 0 the same.
4563 2012-02-06 Chong Yidong <cyd@gnu.org>
4565 * doc.c (store_function_docstring): Avoid applying docstring of
4566 alias to base function (Bug#2603).
4568 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4570 * .gdbinit (pp1, pv1): Remove redundant defines.
4573 2012-02-04 Chong Yidong <cyd@gnu.org>
4575 * nsterm.m: Declare a global (Bug#10694).
4577 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4579 * w32.c (get_emacs_configuration_options):
4580 Include --enable-checking, if specified, in the return value.
4582 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4584 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4585 after rounding frame sizes. (Bug#9723)
4587 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4589 * keyboard.c (adjust_point_for_property): Don't position point
4590 before BEGV. (Bug#10696)
4592 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4594 Handle overflow when computing char display width (Bug#9496).
4595 * character.c (char_width): Return EMACS_INT, not int.
4596 (char_width, c_string_width): Check for overflow when
4597 computing the width; this is possible now that individual
4598 characters can have unbounded width. Problem introduced
4599 by merge from Emacs 23 on 2012-01-19.
4601 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4603 * dbusbind.c (Fdbus_register_method): Mention the return value
4604 :ignore in the docstring.
4606 2012-02-02 Glenn Morris <rgm@gnu.org>
4608 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4610 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4611 Unconditionally set to t. (Bug#10673)
4612 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4613 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4614 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4616 2012-02-02 Kenichi Handa <handa@m17n.org>
4618 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4619 0, do not call append_composite_glyph.
4621 2012-02-02 Kenichi Handa <handa@m17n.org>
4623 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4625 (x_produce_glyphs): If the component of a composition is a null
4626 string, set it->pixel_width to 1 to avoid zero-width glyph.
4628 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4630 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4631 first 2 arguments are identical. This makes inserting large
4632 output from a subprocess an order of magnitude faster on
4633 MS-Windows, where all sbrk'ed memory is always contiguous.
4635 2012-01-31 Glenn Morris <rgm@gnu.org>
4637 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4638 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4639 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4641 2012-01-29 Glenn Morris <rgm@gnu.org>
4643 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4645 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4647 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4649 2012-01-28 Chong Yidong <cyd@gnu.org>
4651 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4653 2012-01-26 Chong Yidong <cyd@gnu.org>
4655 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4657 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4658 repeat counts (Bug#10507).
4660 2012-01-26 Glenn Morris <rgm@gnu.org>
4662 * lread.c (syms_of_lread): Doc fix.
4664 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4666 * coding.c (encode_designation_at_bol): Change return value to
4669 2012-01-25 Chong Yidong <cyd@gnu.org>
4671 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4673 2012-01-21 Chong Yidong <cyd@gnu.org>
4675 * floatfns.c (Fcopysign): Make the second argument non-optional,
4676 since nil is not allowed anyway.
4678 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4680 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4681 (send_process): Likewise.
4683 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4685 * window.c (save_window_save, Fcurrent_window_configuration)
4686 (Vwindow_persistent_parameters): Do not use Qstate.
4687 Rewrite doc-strings.
4689 2012-01-19 Kenichi Handa <handa@m17n.org>
4691 * character.c (char_width): New function.
4692 (Fchar_width, c_string_width, lisp_string_width):
4693 Use char_width (Bug#9496).
4695 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4697 * window.c (Vwindow_persistent_parameters): New variable.
4698 (Fset_window_configuration, save_window_save): Handle persistent
4701 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4703 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4704 thrashing the stack of the thread. (Bug#9087)
4706 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4708 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4710 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4712 * xdisp.c (rows_from_pos_range): Handle the case where the
4713 highlight ends on a newline. (Bug#10464)
4714 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4715 he end column for display of highlight that ends on a newline
4718 2012-01-11 Glenn Morris <rgm@gnu.org>
4720 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4721 from load-path also when installation-directory is nil. (Bug#10208)
4723 2012-01-10 Glenn Morris <rgm@gnu.org>
4725 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4727 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4728 Update template values to be closer to their typical values these days.
4730 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4732 * xdisp.c (rows_from_pos_range): Accept additional argument
4733 DISP_STRING, and accept any glyph in a row whose object is that
4734 string as eligible for mouse highlight. Fixes mouse highlight of
4735 display strings from overlays. (Bug#10464)
4737 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4739 emacs: fix an auto-save permissions race condition (Bug#10400)
4740 * fileio.c (auto_saving_dir_umask): New static var.
4741 (Fmake_directory_internal): Use it.
4742 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4743 creating the directory. The old code temporarily assigns
4744 too-generous permissions to the directory.
4745 (do_auto_save_eh): Clear it.
4746 (Fdo_auto_save): Catch all errors, not just file errors, so
4747 that the var is always cleared.
4749 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4751 * search.c (scan_buffer): Pass character positions to
4752 know_region_cache, not byte positions. (Bug#6540)
4754 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4756 * w32.c (sys_rename): Report EXDEV when rename of a directory
4757 fails because the target is on another logical disk. (Bug#10284)
4759 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4761 * xterm.c (x_embed_request_focus): New function.
4763 * xterm.h: Add prototype.
4765 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4767 2012-01-05 Glenn Morris <rgm@gnu.org>
4769 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4771 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4773 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4774 Load gnutls_transport_set_lowat only if GnuTLS version is below
4776 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4777 GnuTLS versions below 2.11.1.
4779 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4781 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4782 to the doc string advising against its use for altering the way
4783 windows are scrolled.
4785 2011-12-28 Kenichi Handa <handa@m17n.org>
4787 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4788 coding-system ASCII compatible only when it does not produce BOM
4789 on encoding (Bug#10383).
4791 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4793 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4795 (create_and_show_popup_menu): Always use menu_position_func for
4798 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4800 * callint.c (Fcall_interactively): Don't truncate prompt string.
4802 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4804 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4805 property that ends at ZV, so that the bidi iteration could be
4806 resumed from there (after widening). (Bug#10360)
4808 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4810 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4812 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4814 * nsterm.m (x_free_frame_resources):
4815 Release f->output_data.ns->miniimage.
4816 (ns_index_color): Fix indentation. Do not retain
4817 color_table->colors[i].
4819 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4822 * nsfns.m (x_set_background_color): Assign return value from
4823 ns_index_color to face-background instead of NSColor*.
4824 (ns_implicitly_set_icon_type): Fix indentation.
4825 Change assignment in for loop to comparison.
4827 * emacs.c (ns_pool): New variable.
4828 (main): Assign ns_pool.
4829 (Fkill_emacs): Call ns_release_autorelease_pool.
4831 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4832 autorelease fdesc, release fdAttrs and tdict.
4833 (ns_get_covering_families): Release charset.
4834 (ns_findfonts): Release NSFontDescriptor created with new.
4835 (ns_uni_to_glyphs): Fix indentation.
4836 (setString): Release attrStr before assigning new value.
4838 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4840 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4842 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4843 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4845 2011-12-18 David Reitter <reitter@cmu.edu>
4847 * nsterm.m (ns_term_init): Subscribe for notifications
4848 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4849 to method trackingNotification in EmacsMenu.
4851 * nsmenu.m (trackingMenu): New variable.
4852 (trackingNotification): New method (from Aquamacs).
4853 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4854 from Aquamacs (Bug#7030).
4856 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4858 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4859 (symbol_to_nsstring): Fix indentation.
4860 (ns_symbol_to_pb): New function.
4861 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4862 (Fns_rotate_cut_buffers_internal): Remove.
4863 (Fns_store_selection_internal): Rename from
4864 Fns_store_cut_buffer_internal.
4865 (ns_get_foreign_selection, Fx_own_selection_internal)
4866 (Fx_disown_selection_internal, Fx_selection_exists_p)
4867 (Fns_get_selection_internal, Fns_store_selection_internal):
4868 Use ns_symbol_to_pb and check if return value is nil.
4869 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4870 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4871 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4872 renamed to Sns_store_selection_internal.
4873 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4874 and remove this function.
4875 (ns_handle_selection_clear): Remove, never used.
4876 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4879 2011-12-17 Ken Brown <kbrown@cornell.edu>
4881 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4882 GID is unknown (Bug#10257).
4884 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4886 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4887 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4888 which caused a build failure on GNU/Linux IA-64. This problem was
4889 introduced by my 2011-10-07 patch.
4891 2011-12-15 Juri Linkov <juri@jurta.org>
4893 * image.c (imagemagick_error): New function. (Bug#10112)
4894 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4895 Use `imagemagick_error' where ImageMagick functions return
4897 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4900 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4902 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4903 fill background (Bug#8992).
4905 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4907 * window.c (Vwindow_combination_resize)
4908 (Vwindow_combination_limit): Use t instead of non-nil in
4910 (Vrecenter_redisplay): Add first sentence of doc-string on
4912 (Frecenter): Fix doc-string typo.
4914 2011-12-11 Kenichi Handa <handa@m17n.org>
4916 * coding.c (Funencodable_char_position): Pay attention to the
4917 buffer text relocation (Bug#9389).
4919 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4921 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4922 gtk_init (Bug#10100).
4924 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4926 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4927 IT->string is nil. (Bug#10263)
4929 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4931 * nsterm.h (x_free_frame_resources): Declare.
4933 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4934 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4936 * nsterm.h (ns_get_defaults_value): Declare.
4938 * nsterm.m (ns_default): Call ns_get_defaults_value.
4940 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4942 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4945 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4947 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4948 that where the value of an _OBJC_* symbol points to is in the .bss
4949 section (Bug#10240).
4951 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4953 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4954 after the loop to call ccl_driver at least once (Bug#8619).
4956 2011-12-08 Kenichi Handa <handa@m17n.org>
4958 * ftfont.c (get_adstyle_property): Fix previous change
4961 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4963 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4964 dirs from the default value of EMACSLOADPATH (bug#10208).
4966 2011-12-07 Glenn Morris <rgm@gnu.org>
4968 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4969 installation and source directories as well. (Bug#10208)
4971 2011-12-06 Chong Yidong <cyd@gnu.org>
4973 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4975 2011-12-06 Glenn Morris <rgm@gnu.org>
4977 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4978 as an error, not just -1. (Bug#10217)
4980 2011-12-05 Chong Yidong <cyd@gnu.org>
4982 * keyboard.c (process_special_events): New function.
4983 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4985 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4987 * coding.c (encode_designation_at_bol): Don't use uninitialized
4988 local variable (Bug#9318).
4990 2011-12-05 Kenichi Handa <handa@m17n.org>
4992 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4993 return Qnil (Bug#8046, Bug#10193).
4995 2011-12-05 Kenichi Handa <handa@m17n.org>
4997 * coding.c (encode_designation_at_bol): New args charbuf_end and
4998 dst. Return the number of produced bytes. Callers changed.
4999 (coding_set_source): Return how many bytes coding->source was
5001 (coding_set_destination): Return how many bytes
5002 coding->destination was relocated.
5003 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5004 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5006 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5008 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5009 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5012 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5014 The following changes are to fix Bug#9318.
5016 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5017 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5018 (encode_coding_iso_2022, encode_coding_sjis)
5019 (encode_coding_big5, encode_coding_charset): Use the above macros.
5021 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5023 * lisp.h (process_quit_flag): Fix external declaration.
5025 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5027 Don't macro-inline non-performance-critical code.
5028 * eval.c (process_quit_flag): New function.
5029 * lisp.h (QUIT): Use it.
5031 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5033 * nsfns.m (get_geometry_from_preferences): New function.
5034 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5036 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5038 * emacs.c (Qkill_emacs): Define.
5039 (syms_of_emacs): Initialize it.
5040 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5041 Qquit_flag to `kill-emacs' instead.
5042 (quit_throw_to_read_char): Add parameter `from_signal'.
5043 All callers changed. Call Fkill_emacs if requested and safe.
5044 * lisp.h (QUIT): Call Fkill_emacs if requested.
5046 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5048 * widget.c (update_wm_hints): Return if wmshell is null.
5049 (widget_update_wm_size_hints): New function.
5051 * widget.h (widget_update_wm_size_hints): Declare.
5053 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5054 widget_update_wm_size_hints (Bug#10104).
5056 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5058 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5059 before a newline, prepare the bidi iterator for consuming the
5060 newline, and keep the current paragraph direction. (Bug#10183)
5061 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5063 2011-12-02 Juri Linkov <juri@jurta.org>
5065 * search.c (Fword_search_regexp): New Lisp function created from
5066 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5067 (Fword_search_backward, Fword_search_forward)
5068 (Fword_search_backward_lax, Fword_search_forward_lax):
5069 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5070 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5072 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5074 * fileio.c (Finsert_file_contents): Move after-change-function call
5075 to before the "handled:" label, since all "goto handled" appear in
5076 cases where the *-change-functions have already been properly called
5079 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5081 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5082 waiting for input. (Bug#10169)
5084 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5086 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5087 verifies glyph row's hash code--we have just reallocated the
5088 glyphs, so their contents can be complete garbage. (Bug#10164)
5090 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5092 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5094 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5096 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5097 attributes are tested _before_ calling verify_row_hash, to protect
5098 against GCC re-ordering of the tests. (Bug#10164)
5100 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5102 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5104 * xterm.c (handle_one_xevent): Only set async_visible and friends
5105 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5106 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5107 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5109 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5111 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5112 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5113 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5114 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5115 All uses changed to use GCPRO1 etc.
5116 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5117 Revert to old implementation (i.e., before 2011-03-11).
5119 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5121 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5122 of scroll runs so as to avoid assigning disabled bogus rows and
5123 unnecessary graphics copy operations.
5125 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5127 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5128 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5129 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5130 (malloc, free, realloc, calloc): Redirect to e_* only when
5133 * lisp.h (GCTYPEBITS): Move before first use.
5134 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5135 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5136 this macro definition.
5138 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5141 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5143 * gtkutil.c (xg_create_frame_widgets):
5144 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5145 present with Gtk+ 2.0.
5147 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5149 * fileio.c (Finsert_file_contents): Undo previous change; see
5150 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5152 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5154 Rename locals to avoid shadowing.
5155 * fileio.c (Finsert_file_contents):
5156 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5157 * process.c (wait_reading_process_output):
5158 Rename inner 'proc' to 'p' to avoid shadowing.
5159 Indent for consistency with usual Emacs style.
5161 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5163 * xdisp.c (redisplay_window): If cursor row is not fully visible
5164 after recentering, and scroll-conservatively is set to a large
5165 number, scroll window by a few more lines to make the cursor fully
5166 visible and out of scroll-margin. (Bug#10105)
5167 (start_display): Don't move to the next line if the display should
5168 start at a newline that is part of a display vector or an overlay
5171 2011-11-24 Juri Linkov <juri@jurta.org>
5173 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5174 after the `MagickPingImage' call. (Bug#10112)
5176 2011-11-23 Chong Yidong <cyd@gnu.org>
5178 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5180 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5182 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5183 making another buffer current. (Bug#10114)
5185 2011-11-23 Glenn Morris <rgm@gnu.org>
5187 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5189 2011-11-23 Chong Yidong <cyd@gnu.org>
5191 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5192 using it (Bug#5984).
5194 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5196 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5197 and header-lines, as they don't have one computed for them.
5200 * .gdbinit (prow): Make displayed values more self-explaining.
5201 Add row's hash code.
5203 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5205 * process.c (wait_reading_process_output): Fix asynchrounous
5206 GnuTLS socket handling on some versions of the GnuTLS library.
5207 (wait_reading_process_output): Add comment and URL.
5209 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5211 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5213 2011-11-21 Chong Yidong <cyd@gnu.org>
5215 * window.c (Fnext_window, Fprevious_window): Doc fix.
5217 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5219 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5221 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5223 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5225 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5227 * window.c (Fset_window_combination_limit): Rename argument
5229 (Vwindow_combination_limit): Remove "status" from doc-string.
5231 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5233 * m/ibms390.h: Remove.
5234 * m/ibms390x.h: Don't include "ibms390.h".
5236 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5238 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5239 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5241 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5243 * casetab.c (Fset_case_table):
5244 * charset.c (Fcharset_after): Fix typos.
5246 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5248 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5249 Otherwise, valgrind does not work on some platforms.
5250 Problem reported by Andreas Schwab in
5251 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5252 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5253 is set, removing the need for VIRT_ADDRESS_VARIES.
5254 (PURE_P): Use a more-efficient implementation that needs just one
5255 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5256 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5257 to 4 (xorl, subq, cmpq, setbe).
5258 * alloc.c (pure): Always extern now, since that's the
5259 VIRT_ADDR_VARIES behavior.
5260 (PURE_POINTER_P): Use a single comparison, not two, for
5261 consistency with the new puresize.h.
5262 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5263 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5264 Remove VIRT_ADDR_VARIES no longer needed.
5266 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5268 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5269 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5270 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5271 behave as if the cursor position were at the window margin.
5273 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5274 and the cursor position is out of bounds, behave as if the cursor
5275 position were at the window margin. (Bug#10075)
5277 2011-11-18 Chong Yidong <cyd@gnu.org>
5279 * window.c (Fwindow_combination_limit): Make first argument
5280 non-optional, since it is meaningless for live windows like the
5283 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5285 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5287 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5289 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5290 (graft_intervals_into_buffer): Simplify.
5292 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5294 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5295 hash values of the two rows.
5296 (copy_row_except_pointers): Preserve the used[] arrays and the
5297 hash values of the two rows. (Bug#10035)
5298 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5300 * xdisp.c (row_hash): New function, body extracted from
5301 compute_line_metrics.
5302 (compute_line_metrics): Call row_hash, instead of computing the
5305 * dispnew.c (verify_row_hash): Call row_hash for computing the
5306 hash code of a row, instead of duplicating code from xdisp.c.
5308 * dispextern.h (row_hash): Add prototype.
5310 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5312 * frame.c (delete_frame): Don't delete the terminal when the last
5313 X frame is closed if emacs is built with GTK toolkit.
5315 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5317 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5319 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5321 * window.c (Vwindow_splits): Rename to
5322 Vwindow_combination_resize. Suggested by Juri Linkov.
5323 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5326 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5328 * nsfns.m (Fns_font_name):
5329 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5331 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5333 * window.h (window): Rename slot "nest" to "combination_limit".
5334 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5335 (Fset_window_nest): Rename to Fset_window_combination_limit.
5336 (Vwindow_nest): Rename to Vwindow_combination_limit.
5337 (recombine_windows, make_parent_window, make_window)
5338 (Fsplit_window_internal, saved_window)
5339 (Fset_window_configuration, save_window_save): Rename all
5340 occurrences of window_nest to window_combination_limit.
5342 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5344 * image.c (imagemagick_load_image): Fix typo.
5346 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5348 * xdisp.c (display_line): Move the call to
5349 highlight_trailing_whitespace before the call to
5350 compute_line_metrics, since the latter needs to see the final
5351 faces of all the glyphs to compute ROW's hash value.
5352 Fixes assertion violations in row_equal_p. (Bug#10035)
5354 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5356 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5357 just return (bug#10044).
5359 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5361 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5362 with user-defined heap size. Bump the default size of the temacs
5363 heap to 27MB, to avoid memory warning when running temacs.
5364 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5366 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5367 current_matrix and desired_matrix. (Bug#9990)
5368 (verify_row_hash) [XASSERTS]: New function.
5369 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5370 that the hash value of glyph rows is correct.
5372 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5374 * window.h (window): Remove splits slot.
5375 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5376 (Fdelete_other_windows_internal, make_parent_window)
5377 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5378 (Fset_window_configuration, save_window_save): Don't deal with
5379 split status of windows.
5380 (saved_window): Remove splits slot.
5381 (Vwindow_splits): Rewrite doc-string.
5383 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5385 * xfns.c (unwind_create_frame):
5386 * nsfns.m (unwind_create_frame):
5387 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5388 Vframe_list (Bug#9999).
5390 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5392 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5394 2011-11-11 Kenichi Handa <handa@m17n.org>
5396 * callproc.c (Fcall_process): Set the member dst_multibyte of
5399 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5401 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5402 avoid a crash (bug#9496).
5404 2011-11-09 Chong Yidong <cyd@gnu.org>
5406 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5407 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5409 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5411 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5413 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5415 Avoid some portability problems by eschewing 'extern inline' functions.
5416 The trivial performance wins aren't worth the portability hassles; see
5417 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5419 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5420 (window_box_width, window_box_left, window_box_left_offset)
5421 (window_box_right, window_box_right_offset): Undo previous change,
5422 by removing the "extern"s.
5423 * intervals.c (adjust_intervals_for_insertion)
5424 (adjust_intervals_for_deletion): Undo previous change,
5425 making these static again.
5426 (offset_intervals, temp_set_point_both, temp_set_point)
5427 (copy_intervals_to_string): No longer inline.
5428 * xdisp.c (window_text_bottom_y, window_box_width)
5429 (window_box_height, window_box_left_offset)
5430 (window_box_right_offset, window_box_left, window_box_right)
5431 (window_box): No longer inline.
5433 2011-11-08 Chong Yidong <cyd@gnu.org>
5435 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5436 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5437 Signal an error if not a live window.
5438 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5439 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5441 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5443 * lisp.h (syms_of_abbrev): Remove declaration.
5444 Reported by CHENG Gao <chenggao@royau.me>.
5446 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5448 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5449 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5450 of temacs in GUI mode.
5452 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5454 * window.h: Declare delete_all_child_windows instead of
5455 delete_all_subwindows.
5456 * window.c (Fwindow_nest, Fset_window_nest)
5457 (Fset_window_new_total, Fset_window_new_normal)
5458 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5459 (delete_all_subwindows): Rename to delete_all_child_windows.
5460 (Fdelete_other_windows_internal, Fset_window_configuration):
5461 Call delete_all_child_windows instead of delete_all_subwindows.
5462 * frame.c (delete_frame): Call delete_all_child_windows instead
5463 of delete_all_subwindows.
5465 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5467 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5468 This is also needed for porting to any host where GC_MARK_STACK is
5469 not GC_MAKE_GCPROS_NOOPS.
5470 (which_symbols): Use it.
5472 2011-11-07 Kenichi Handa <handa@m17n.org>
5474 * coding.c (coding_set_destination): Check coding->src_pos only
5475 when coding->src_object is a buffer (bug#9910).
5477 * process.c (send_process): Set the member src_multibyte of coding
5478 to 0 (bug#9911) when sending a unibyte text.
5480 * callproc.c (Fcall_process): Set the member src_multibyte of
5481 process_coding to 0 (bug#9912).
5483 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5485 * xmenu.c (cleanup_widget_value_tree): New function.
5486 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5487 calling free_menubar_widget_value_tree directly (Bug#9830).
5489 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5491 Fix some portability problems with 'inline'.
5492 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5493 (window_box_width, window_box_left, window_box_left_offset)
5494 (window_box_right, window_box_right_offset): Declare extern.
5495 Otherwise, these inline functions do not conform to C99 and
5496 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5497 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5498 * intervals.c (adjust_intervals_for_insertion)
5499 (adjust_intervals_for_deletion): Now extern, because otherwise the
5500 extern inline functions 'offset_intervals' couldn't refer to it.
5501 (static_offset_intervals): Remove.
5502 (offset_intervals): Rewrite using the old contents of
5503 static_offset_intervals. The old version didn't conform to C99
5504 because an extern inline function contained a reference to an
5505 identifier with static linkage.
5507 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5509 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5512 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5514 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5515 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5516 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5517 return Qleft_to_right.
5519 2011-11-06 Chong Yidong <cyd@gnu.org>
5521 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5522 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5523 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5524 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5525 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5526 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5527 (Fwindow_vscroll): Doc fix.
5528 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5529 argument, since it makes no sense to pass a live window and for
5530 consistency with window-child.
5532 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5534 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5537 2011-11-05 Jason Rumney <jasonr@gnu.org>
5539 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5540 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5542 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5543 bitwise arithmetic preventing use of unicode-sip and non-truetype
5546 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5548 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5551 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5552 initialization code to keep similarity to xfns.c after changes
5555 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5557 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5558 (unwind_create_frame): New function (Bug#9943).
5559 (Fx_create_frame): Restructure code to be more similar to the one in
5560 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5561 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5562 Move terminal->reference_count++ just before making the frame official
5565 * nsterm.m (x_free_frame_resources): New function.
5566 (x_destroy_window): Move code to x_free_frame_resources.
5568 * xfns.c (unwind_create_frame): Fix comment.
5569 (Fx_create_frame, x_create_tip_frame):
5570 Move terminal->reference_count++ just before making the frame
5571 official. Move initialization of image_cache_refcount and
5572 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5574 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5576 Support MSVC build with newer versions of Visual Studio.
5577 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5578 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5581 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5582 which are not supported by MSVC.
5583 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5584 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5586 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5588 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5590 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5592 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5594 Support MSVC build with newer versions of Visual Studio.
5595 * w32.c: Don't include w32api.h for MSVC.
5596 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5598 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5599 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5600 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5601 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5603 (alloca) [_MSC_VER]: Define to _alloca.
5605 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5607 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5609 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5611 * xdisp.c (note_mouse_highlight): If either of
5612 previous/next-single-property-change returns nil, treat that as
5613 the beginning or the end of the buffer. (Bug#9955)
5615 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5617 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5618 label is not null (Bug#9951).
5619 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5622 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5624 * window.c (Fwindow_body_size): Mention in the doc string that the
5625 return value is in frame's canonical units. (Bug#9949)
5627 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5629 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5631 * w32fns.c (unwind_create_frame): If needed, free the glyph
5632 matrices of the partially constructed frame. (Bug#9943)
5633 * xfns.c (unwind_create_frame): Likewise.
5635 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5637 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5638 Don't stop backward scan on the continuation glyph, even though
5639 its CHARPOS is positive.
5640 (mouse_face_from_buffer_pos, note_mouse_highlight):
5641 Rename cover_string to disp_string.
5643 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5645 * window.c (temp_output_buffer_show): Don't use
5646 Vtemp_buffer_show_specifiers.
5647 (Vtemp_buffer_show_specifiers): Remove unused variable.
5649 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5651 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5652 past the beginning of the current glyph matrix.
5654 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5656 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5657 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5658 HAVE_GTK3 (Bug#9869).
5660 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5661 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5663 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5665 * xterm.c: Declare x_handle_net_wm_state to return int.
5666 (handle_one_xevent): Check if we are iconified but don't have
5667 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5668 (get_current_wm_state): Return non-zero if not hidden,
5669 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5670 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5671 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5672 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5674 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5676 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5677 so that this new function doesn't get optimized away by a
5678 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5680 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5682 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5684 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5686 Fix the `xbytecode' command.
5687 * .gdbinit (xprintbytestr): New command.
5688 (xwhichsymbols): Rename from `which'; all callers changed.
5689 (xbytecode): Print the byte-code string as well.
5691 2011-10-29 Kim Storm <storm@cua.dk>
5693 * alloc.c (which_symbols): New function.
5695 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5697 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5700 2011-10-29 Glenn Morris <rgm@gnu.org>
5702 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5703 Not clear what it was for, and it causes various bugs. (Bug#9839)
5705 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5707 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5708 possible random value that matches one of those tested as
5709 condition to clear the mouse face.
5711 2011-10-28 Chong Yidong <cyd@gnu.org>
5713 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5715 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5717 * window.c (make_window): Initialize phys_cursor_on_p.
5719 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5721 * lisp.h (struct Lisp_Symbol): Update comments.
5723 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5725 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5727 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5729 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5730 <oslsachem@gmail.com> for helping to debug this.
5732 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5733 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5734 (g_b_init_get_glyph_outline_w): New static variables.
5735 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5736 (GetGlyphOutlineW_Proc): New typedefs.
5737 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5738 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5740 (w32font_open_internal, compute_metrics):
5741 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5742 instead of calling the "wide" APIs directly.
5744 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5746 * w32.h (syms_of_w32font): Add prototype.
5748 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5750 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5751 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5752 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5753 (Fmove_to_window_line): Doc fix.
5755 2011-10-27 Chong Yidong <cyd@gnu.org>
5757 * process.c (make_process): Set gnutls_state to NULL.
5759 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5760 non-NULL, regardless of GNUTLS_INITSTAGE.
5761 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5762 an error. Set process slots as soon as we allocate them.
5764 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5766 2011-10-27 Chong Yidong <cyd@gnu.org>
5768 * gnutls.c (emacs_gnutls_deinit): New function.
5769 Deallocate credentials structures as well as calling gnutls_deinit.
5770 (Fgnutls_deinit, Fgnutls_boot): Use it.
5772 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5773 (deactivate_process): Call emacs_gnutls_deinit.
5775 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5777 * image.c (x_create_x_image_and_pixmap):
5778 * w32.c (sys_rename, w32_delayed_load):
5779 * w32font.c (fill_in_logfont):
5780 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5782 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5784 * w32fns.c (w32_default_color_map): New function,
5785 extracted from Fw32_default_color_map.
5786 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5788 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5790 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5792 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5794 * keyboard.c (test_undefined): New function (bug#9751).
5795 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5797 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5799 * sysdep.c (init_sys_modes): Fix the check for the controlling
5800 terminal (Bug#6649).
5802 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5804 * dispextern.h (struct bidi_it): New member next_en_type.
5806 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5807 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5808 current character, check also for next_en_type being WEAK_EN.
5809 (bidi_resolve_weak): Don't enter the expensive loop if the current
5810 position is before next_en_pos. Record the bidi type of the first
5811 non-ET, non-BN character we find, in addition to its position.
5812 (bidi_level_of_next_char): Invalidate next_en_type when
5813 next_en_pos is over-stepped.
5815 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5817 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5818 * editfns.c: Rewrite current-time-zone so that it invokes
5819 the equivalent of (format-time-string "%Z") to get the time zone name.
5820 This fixes a bug when the time zone name contains characters that
5821 need converting from the system time locale to Emacs internal format.
5822 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5823 that patch fixed format-time-string to do the conversion, but
5824 I forgot to fix current-time-zone.
5825 (format_time_string): New function, containing most of
5826 what Fformat_time_string used to contain.
5827 (Fformat_time_string): Rewrite in terms of format_time_string.
5828 This doesn't change this function's behavior.
5829 (current-time-zone): Rewrite to use format_time_string.
5830 This fixes the bug reported by Michael Schierl in
5831 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5832 Jason Rumney's 2007-06-07 change worked around this bug, but
5834 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5836 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5838 * xdisp.c (start_display): If the character at POS is displayed
5839 via a display vector, reset IT->current.dpvec_index to zero.
5840 (try_window_reusing_current_matrix): If a line ends in a display
5841 vector or the next line starts in a display vector, continue
5842 redrawing the window even though the character position of
5843 start_row was reached.
5846 2011-10-18 Chong Yidong <cyd@gnu.org>
5848 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5849 with nobreak-char-display too.
5851 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5853 Fix part 3 of bug#9771.
5854 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5855 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5856 non-neutral characters if the current character is a paragraph
5857 separator (a.k.a. Newline). This avoids running the same
5858 expensive loop twice, once when we consume the preceding newline
5859 and the other time when the line actually needs to be displayed.
5860 Avoid the loop when we see neutrals on the base embedding level
5861 following a character whose directionality is the same as the
5862 paragraph's. This avoids running the expensive loop when a line
5863 ends in a long sequence of neutrals, like control characters.
5864 Add assertion against STRONG_AL type. Slightly rearrange code
5865 that determines the type of a neutral given the first non-neutral
5867 (bidi_level_of_next_char): Set next_en_pos to zero when
5868 invalidating its info.
5870 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5872 * xdisp.c (push_display_prop): Determine whether to record string
5873 or buffer position by IT->string, not by IT->method. Allow
5874 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5875 (move_it_vertically_backward): Don't look for character position
5876 immediately after the newline when in a continuation line.
5879 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5881 * window.c (coordinates_in_window): Rewrite and delabelize
5882 vertical border check. (Bug#5357) (Bug#9618)
5884 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5886 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5887 errors in XSetWindowBorder (bug#9310).
5889 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5891 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5892 avoid crash when xmalloc overrun checking is enabled.
5894 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5896 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5897 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5898 cursor motion with <left> and <right> arrow keys.
5900 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5901 some callers set that themselves.
5903 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5905 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5906 display string and the previous row comes from the same string and
5907 is empty. (Bug#9739) (Bug#9738)
5909 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5911 * doc.c (get_doc_string): Encode file name (bug#9735).
5913 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5915 * bidi.c (bidi_level_of_next_char):
5916 * xdisp.c (get_visually_first_element): Remove old incorrect
5917 comments regarding the Unicode Line Separator character.
5919 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5921 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5923 * alloc.c (Fgc_status): Do not access beyond zombies array
5924 boundary if nzombies > MAX_ZOMBIES.
5925 * alloc.c (dump_zombies): Add missing format specifier.
5927 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5929 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5930 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5932 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5933 Some packages use them to denote characters with modifiers.
5935 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5937 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5938 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5939 matching a pp-number. Rename parameter var to var1.
5941 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5943 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5945 2011-10-08 Glenn Morris <rgm@gnu.org>
5947 * callint.c (Fcall_interactively): Give a more explicit error for the
5948 'c' case with a non-character input. (Bug#8479)
5950 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5952 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5954 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5955 lines that are hscrolled on the left.
5957 * dispnew.c (buffer_posn_from_coords): Account for a possible
5958 presence of header-line. (Bug#4426)
5960 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5962 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5963 Don't advertise functionality which we discourage or doesn't work.
5965 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5967 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5968 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5969 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5970 this makes Emacs dump core during garbage collection on rare
5971 occasions. sizeof is obviously inferior to offsetof here, so
5972 stick with offsetof.
5973 (GC_POINTER_ALIGNMENT): New macro.
5974 (mark_memory): Omit 3rd (offset) arg; caller changed.
5975 Don't assume EMACS_INT alignment is the same as pointer alignment.
5977 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5979 * keyboard.c (read_key_sequence_remapped): New var.
5980 (read_key_sequence): Compute remapping in the right buffer.
5981 (command_loop_1): Use read_key_sequence's remapping directly.
5983 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5985 * dired.c (file_name_completion): Don't expand file name.
5986 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5987 before checking file name handler.
5989 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5990 they've been requested explicitly (bug#9591).
5992 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5994 * keymap.c (Fsingle_key_description): Use make_specified_string
5995 instead of build_string to build string from push_key_description.
5998 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6000 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6001 This fixes a Y2038 bug on 64-bit hosts.
6002 * buffer.c (reset_buffer):
6003 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6004 (Fclear_buffer_auto_save_failure):
6005 Use 0, not -1, to represent an unset failure time, since time_t
6006 might not be signed.
6008 Remove dependency on glibc malloc internals.
6009 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6010 Move back here from lisp.h, but with their new implementations.
6011 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6012 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6013 * charset.c (charset_table_init): New static var.
6014 (syms_of_charset): Use it instead of xmalloc. This removes a
6015 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6016 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6017 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6018 Move back to alloc.c.
6019 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6020 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6022 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6024 * nsterm.m (windowDidResize): Call x_set_window_size only when
6025 ns_in_resize is true. Otherwise set pixelwidth/height and
6026 call change_frame_size (Bug#9628).
6028 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6030 Port --enable-checking=all to Fedora 14 x86-64.
6031 * charset.c (syms_of_charset): Also account for glibc malloc's
6032 internal overhead when calculating the initial malloc maximum.
6034 Port --enable-checking=all to Fedora 14 x86.
6035 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6037 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6038 (overrun_check_realloc, overrun_check_free):
6039 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6040 That way, xmalloc returns a properly-aligned pointer even if
6041 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6042 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6043 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6044 into account when calculating the initial malloc maximum.
6045 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6046 Move here from alloc.c, so that charset.c can use it too.
6047 Properly align; the old code wasn't right for common 32-bit hosts
6048 when configured with --enable-checking=all.
6049 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6050 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6052 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6054 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6057 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6059 * xdisp.c (compute_display_string_end): If there's no display
6060 string at CHARPOS, return -1.
6062 * bidi.c (bidi_fetch_char): When compute_display_string_end
6063 returns a negative value, treat the character as a normal
6064 character not covered by a display string. (Bug#9624)
6066 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6068 * lread.c (Fread_from_string): Fix typo in docstring.
6070 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6072 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6073 newline, reseat the iterator instead of bidi-iterating there one
6074 character at a time. (Bug#9610)
6075 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6076 TO_CHARPOS if the bidi iterator is at base embedding level.
6078 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6080 * lread.c (readevalloop): Use correct code for NBSP.
6081 (read1): Likewise. (Bug#9608)
6083 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6085 * dbusbind.c (Fdbus_register_signal): When service is not
6086 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6088 2011-09-25 Glenn Morris <rgm@gnu.org>
6090 * buffer.c (truncate-lines): Doc fix.
6092 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6094 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6095 (Fset_window_next_buffers): Doc fix.
6097 2011-09-24 Glenn Morris <rgm@gnu.org>
6099 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6101 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6103 Fix minor problems found by static checking.
6104 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6105 * indent.c (Fvertical_motion): Fix == vs = typo.
6107 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6109 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6110 Default value is now t. Doc fix.
6112 * indent.c (Fvertical_motion): Compute and apply the overshoot
6113 logic when moving up, not only when moving down. Fix the
6114 confusing name and values of the it_overshoot_expected variable;
6115 logic changes accordingly. (Bug#9254) (Bug#9549)
6117 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6118 CHARPOS is covered by a display string which includes newlines.
6119 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6120 is covered by a display string with embedded newlines.
6122 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6124 * dbusbind.c (Fdbus_register_signal): Add match rule to
6125 Vdbus_registered_objects_table. (Bug#9581)
6126 (Fdbus_register_method, Vdbus_registered_objects_table):
6129 2011-09-24 Jim Meyering <meyering@redhat.com>
6131 do not ignore write error for any output size
6132 The previous change was incomplete.
6133 While it makes emacs --batch detect the vast majority of stdout
6134 write failures, errors were still ignored whenever the output size is
6135 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6136 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6137 && echo FAIL: ignored write error
6138 FAIL: ignored write error
6139 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6140 && echo FAIL: ignored write error
6141 FAIL: ignored write error
6142 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6144 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6146 * emacs.c (Fkill_emacs): In noninteractive mode exit
6147 non-successfully if a write error occurred on stdout. (Bug#9574)
6149 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6151 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6154 * dispextern.h (struct it): Update the comment documenting what
6157 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6159 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6160 a display string, extend search for cursor position to end of row.
6161 (find_row_edges): If the row ends in a newline from a display
6162 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6163 Handle the case of a display string with multiple newlines.
6164 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6165 non-empty line. Fixes confusing cursor motion with arrow keys at
6166 the beginning of a line that starts with whitespace.
6168 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6170 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6173 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6175 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6178 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6180 * xdisp.c (display_line): Record maximum and minimum buffer
6181 positions even if no glyphs were produced (e.g., by a zero-width
6182 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6183 buffer positions that will be removed from the glyph row because
6185 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6186 column is beyond frame width: don't subtract 1 "pixel" when
6187 computing width of the stretch.
6188 (reseat_at_next_visible_line_start): Undo the change made on
6189 2011-09-17 that saved paragraph information and restored it after
6190 the call to `reseat'. (Bug#9545)
6192 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6194 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6195 and turn window cursor on if cleared (Bug#9415).
6197 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6199 * search.c (boyer_moore): Take unibyte characters from pattern
6200 literally. (Bug#9458)
6202 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6204 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6206 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6208 Fix minor problem found by static checking.
6209 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6210 initialized, to pacify gcc -Wuninitialized.
6212 * fileio.c: Report proper errno when syscall falls.
6213 (Finsert_file_contents): Save and restore errno,
6214 so that report_file_error outputs the correct diagnostic.
6215 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6217 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6219 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6221 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6223 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6224 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6226 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6228 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6229 about the current paragraph and restore it after the call to reseat.
6231 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6232 (bidi_find_paragraph_start): Search back for paragraph beginning
6233 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6234 (bidi_move_to_visually_next): Only trigger paragraph-related
6235 computations when the last character is a newline or at EOB, not
6236 just any NEUTRAL_B. (Bug#9470)
6238 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6239 truncated lines if point is covered by a display string. (Bug#9524)
6241 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6243 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6244 (cons_to_x_long): New function.
6245 (lisp_data_to_selection_data): Use it. Correct the test for
6246 short-versus-long data; it was negated. Break out of vector
6247 loop, for efficiency, when a long datum is discovered.
6249 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6251 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6253 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6255 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6256 GCC PR/17406) by declaring this function with external scope.
6258 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6260 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6261 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6263 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6265 * editfns.c (Fformat): Correctly handle text properties on "%%".
6267 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6269 * xterm.c (x_draw_composite_glyph_string_foreground):
6270 * w32term.c (x_draw_composite_glyph_string_foreground):
6271 * term.c (encode_terminal_code):
6272 * composite.c (composition_update_it, get_composition_id):
6273 * xdisp.c (get_next_display_element)
6274 (fill_composite_glyph_string): Add comments about special meaning
6275 of TAB characters in a composition.
6277 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6279 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6280 This occurs when processing a multibyte format.
6281 Problem reported by Wolfgang Jenker.
6283 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6285 * xdisp.c (try_cursor_movement): Only check for exact match if
6286 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6288 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6290 Remove unused external symbols.
6291 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6292 * xdisp.c (calc_pixel_width_or_height): Now static.
6293 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6294 * indent.c (check_display_width):
6295 * w32term.c: Fix comment to match code.
6296 * xterm.c, xterm.h (x_catching_errors): Remove.
6298 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6300 * xselect.c: Use signed conversions more consistently (Bug#9498).
6301 (selection_data_to_lisp_data): Assume incoming selection data are
6302 signed integers, not unsigned. This is to be consistent with
6303 outgoing selection data, which was modified to use signed integers
6304 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6305 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6306 expects long, not unsigned long.
6308 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6310 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6311 computation of loop end. Reported by Johan Bockgård
6314 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6316 * frame.c (Fother_visible_frames_p): Function deleted.
6318 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6320 * indent.c (compute_motion): Process display vector front to back
6321 rather than the other way around. (Bug#2496)
6323 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6325 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6327 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6329 * minibuf.c (Fread_from_minibuffer): Doc fix.
6331 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6333 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6334 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6336 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6338 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6339 value for non-existent files.
6341 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6343 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6344 set its "size" to -1. This will set the modtime_size field of
6345 the corresponding buffer to -1, which is what
6346 verify-visited-file-modtime expects for files that do not exist.
6349 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6351 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6353 * lisp.h: ... from here. push_key_description is no longer
6354 defined in keyboard.c, so its declaration should not be in
6355 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6356 logically belongs with push_key_description.
6358 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6360 * buffer.h: Include <sys/types.h> instead of <time.h>.
6361 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6362 Problem reported by Herbert J. Skuhra.
6364 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6366 * xml.c (parse_region): Make the parsing work for
6367 non-comment-starting XML files again (bug#9144).
6369 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6371 * image.c (gif_load): Fix calculation of bottom and right corner.
6374 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6376 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6377 redisplay in small windows.
6379 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6381 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6383 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6385 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6386 Operate on live windows only.
6388 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6390 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6392 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6394 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6395 only under bidi iteration.
6397 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6399 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6401 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6403 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6404 Without this fix, the command to link temacs failed due to an
6405 undefined symbol __builtin_isnan. This is because
6406 /usr/include/iso/math_c99.h #defines isnan(x) to
6407 __builtin_isnan(x), but the bundled gcc, which identifies itself
6408 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6410 * floatfns.c (isnan): #undef, and then #define to a clone of
6412 (Fisnan): Always define, since it's always available now.
6413 (syms_of_floatfns): Always define isnan at the Lisp level.
6415 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6417 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6419 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6421 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6422 The previous code assumed that file offsets (off_t values) fit in
6423 EMACS_INT variables, which is not true on typical 32-bit hosts.
6424 The code messed up by falsely reporting buffer overflow in cases
6425 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6426 when "big" contains more than 2**29 bytes, even though this
6427 inserts just one byte and does not overflow the buffer.
6428 (Finsert_file_contents): Store file offsets as off_t
6429 values, not as EMACS_INT values. Check for overflow when
6430 converting between EMACS_INT and off_t. When checking for
6431 buffer overflow or for overlap, take the offsets into account.
6432 Don't use EMACS_INT for small values where int suffices.
6433 When checking for overlap, fix a typo: ZV was used where
6434 ZV_BYTE was intended.
6435 (Fwrite_region): Don't assume off_t fits into 'long'.
6436 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6438 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6440 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6442 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6444 sprintf-related integer and memory overflow issues (Bug#9412).
6446 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6447 (esprintf, exprintf, evxprintf): New functions.
6448 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6449 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6450 (modify_event_symbol): Do not assume that the length of
6451 name_alist_or_stem is safe to alloca and fits in int.
6452 (Fexecute_extended_command): Likewise for function name and binding.
6453 (Frecursion_depth): Wrap around reliably on integer overflow.
6454 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6455 since some callers pass EMACS_INT values.
6456 (Fsingle_key_description): Don't crash if symbol name contains more
6457 than MAX_ALLOCA bytes.
6458 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6459 (get_minibuffer): Arg is now EMACS_INT, not int.
6460 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6461 (esprintf, exprintf, evxprintf): New decls.
6462 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6464 * dbusbind.c (signature_cat): New function.
6465 (xd_signature, Fdbus_register_signal):
6466 Do not overrun buffer; instead, report string overflow.
6468 * dispnew.c (add_window_display_history): Don't overrun buffer.
6469 Truncate instead; this is OK since it's just a log.
6471 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6472 even if the time zone offset is outlandishly large.
6473 Don't mishandle offset == INT_MIN.
6475 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6476 when creating daemon; the previous buffer-overflow check was incorrect.
6478 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6479 which has the guts of the old verror function.
6481 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6482 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6484 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6485 (font_unparse_xlfd): Don't blindly alloca long strings.
6486 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6487 fits in int, when using sprintf. Use single snprintf to count
6488 length of string rather than counting it via multiple sprintfs;
6489 that's simpler and more reliable.
6490 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6491 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6492 sprintf, in case result does not fit in int.
6494 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6495 (fontset_from_font): Print it.
6497 * frame.c (tty_frame_count): Now printmax_t, not int.
6498 (make_terminal_frame, set_term_frame_name): Print it.
6499 (x_report_frame_params): In X, window IDs are unsigned long,
6500 not signed long, so print them as unsigned.
6501 (validate_x_resource_name): Check for implausibly long names,
6502 and don't assume name length fits in 'int'.
6503 (x_get_resource_string): Don't blindly alloca invocation name;
6504 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6507 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6508 (xg_check_special_colors, xg_set_geometry):
6509 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6511 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6512 Use esprintf, not sprintf, in case result does not fit in int.
6514 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6515 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6516 it as a large positive number.
6517 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6518 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6520 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6521 in case result does not fit in int.
6523 * print.c (float_to_string): Detect width overflow more reliably.
6524 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6525 buffer overrun. Don't assume list length fits in 'int'. Treat
6526 print length of 0 as 0, not as infinity; to be consistent with other
6527 uses of print length in this function. Don't overflow print length
6528 index. Don't assume hash table size fits in 'long', or that
6529 vectorlike size fits in 'unsigned long'.
6531 * process.c (make_process): Use printmax_t, not int, to format
6532 process-name gensyms.
6534 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6536 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6537 to avoid potential buffer overrun.
6539 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6540 if X resource line is longer than 512 bytes.
6542 * xfns.c (x_window): Make sprintf buffer a bit bigger
6543 to avoid potential buffer overrun.
6545 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6547 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6549 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6551 Integer overflow fixes for scrolling, etc.
6552 Without these, Emacs silently mishandles large integers sometimes.
6553 For example, "C-u 4294967297 M-x recenter" was treated as if
6554 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6556 * xdisp.c (try_window_id): Check Emacs fixnum range before
6557 converting to 'int'.
6559 * window.c (window_scroll_line_based, Frecenter):
6560 Check that an Emacs fixnum is in range before assigning it to 'int'.
6561 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6562 values converted from Emacs fixnums.
6563 (Frecenter): Don't wrap around a line count if it is out of 'int'
6564 range; instead, treat it as an extreme value.
6565 (Fset_window_configuration, compare_window_configurations):
6566 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6568 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6569 that can exceed INT_MAX. Check that EMACS_INT value is in range
6570 before assigning it to the (possibly-narrower) index.
6571 (match_limit): Don't assume that a fixnum can fit in 'int'.
6573 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6576 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6577 (Fvertical_motion): Don't wrap around LINES values that don't fit
6578 in 'int'. Instead, treat them as extreme values. This is good
6579 enough for windows, which can't have more than INT_MAX lines anyway.
6581 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6583 * Require libxml/parser.h to avoid compilation warning.
6585 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6587 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6588 since this reportedly can destroy thread storage.
6590 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6592 * syntax.c (find_defun_start): Update all cache variables if
6593 exiting early (Bug#9401).
6595 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6597 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6599 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6600 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6601 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6603 * term.c (tty_append_glyph): New function.
6604 (produce_stretch_glyph): Static function and its prototype deleted.
6606 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6609 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6611 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6612 when checking :margin (Bug#9390).
6613 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6614 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6615 so that the name doesn't mislead. All uses changed.
6617 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6619 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6622 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6624 * xdisp.c (move_it_to): Don't bail out early when reaching
6625 position beyond to_charpos, if we are scanning backwards.
6626 (move_it_vertically_backward): When DY == 0, make sure we get to
6627 the first character in the line after the newline.
6629 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6631 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6632 (ccl_driver): Do not generate an out-of-range pointer.
6633 (Fccl_execute_on_string): Remove unnecessary check for
6634 integer overflow, noted by Stefan Monnier in
6635 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6636 Remove a FIXME that didn't need fixing.
6637 Simplify the newly-introduced buffer reallocation code.
6639 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6641 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6643 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6645 Integer and memory overflow issues (Bug#9196).
6647 * doc.c (get_doc_string): Rework so that
6648 get_doc_string_buffer_size is the actual buffer size, rather than
6649 being 1 less than the actual buffer size; this makes xpalloc more
6652 * image.c (x_allocate_bitmap_record, cache_image):
6653 * xselect.c (Fx_register_dnd_atom):
6654 Simplify previous changes by using xpalloc.
6656 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6657 since either will do and ptrdiff_t is convenient with xpalloc.
6659 * charset.c (charset_table_size)
6660 (struct charset_sort_data.priority): Now ptrdiff_t.
6661 (charset_compare): Don't overflow if priorities differ greatly.
6662 (Fsort_charsets): Don't assume list length fits in int.
6663 Check for size-calculation overflow when allocating sort data.
6664 (syms_of_charset): Allocate an initial charset table that is
6665 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6667 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6669 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6670 The actual value is always <= INT_MAX, and leaving it unsigned made
6671 overflow checking harder.
6673 * dispextern.h (struct glyph_matrix.rows_allocated)
6674 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6675 with xpalloc. The values are still always <= INT_MAX.
6677 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6679 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6680 (SAFE_NALLOCA): New macro.
6682 * region-cache.c (struct boundary.pos, find_cache_boundary)
6683 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6684 (set_cache_region, invalidate_region_cache)
6685 (revalidate_region_cache, know_region_cache, region_cache_forward)
6686 (region_cache_backward, pp_cache):
6687 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6688 so that ptrdiff_t * can be passed to xpalloc.
6689 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6690 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6691 (pp_cache): Don't assume cache_len fits in int.
6692 * region-cache.h: Adjust extern decls to match.
6694 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6695 EMACS_INT, since either will do, for xpalloc.
6697 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6698 (xnmalloc, xnrealloc, xpalloc): New functions.
6700 * bidi.c (bidi_shelve_header_size): New constant.
6701 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6702 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6704 * bidi.c (bidi_cache_shrink):
6705 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6707 Don't update size of array until after memory allocation succeeds,
6708 because xmalloc/xrealloc may not return.
6709 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6710 now that we have proper integer overflow checking.
6711 (record_overlay_string, overlay_strings): Catch overflows when
6712 calculating size of overlay_str_buf.
6714 * callproc.c (Fcall_process): Check for size overflow when
6715 calculating size of args2.
6716 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6717 Normally we prefer signed values, but sticking with ptrdiff_t would
6718 require adding more-complicated checks.
6720 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6721 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6722 Redo buffer-overflow calculations to avoid integer overflow.
6723 Add a FIXME comment where memory seems to be over-allocated.
6725 * character.c (Fstring): Check for size-calculation overflow.
6727 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6728 unnecessary integer overflow. Check for size overflow.
6729 (encode_coding_object): Don't update size until xmalloc succeeds.
6731 * composite.c (get_composition_id): Check for overflow in glyph
6732 length calculations.
6734 Integer and memory overflow fixes for display code.
6735 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6736 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6737 (scrolling_window): Check for overflow in size calculations.
6738 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6739 Don't assume glyph table len fits in int.
6740 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6741 (row_table_size): Now ptrdiff_t, not int.
6742 (scrolling_window): Avoid overflow in size calculations.
6743 Don't update size until allocation succeeds.
6744 * fns.c (concat): Check for overflow in size calculations.
6745 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6746 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6747 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6749 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6750 (get_doc_string): Check for size calculation overflow.
6751 Don't update size until allocation succeeds.
6752 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6753 EMACS_INT, where ptrdiff_t will do.
6754 (Fsubstitute_command_keys): Check for string overflow.
6756 * editfns.c (set_time_zone_rule): Don't assume environment length
6758 (message_length): Now ptrdiff_t, not int.
6759 (Fmessage_box): Don't update size until allocation succeeds.
6760 Don't assume message length fits in int.
6761 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6763 * emacs.c (main): Do not reallocate argv, since there is a null at
6764 the end that can be overwritten, and this way there's no need to
6765 worry about size-calculation overflow.
6766 (sort_args): Check for size-calculation overflow.
6768 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6770 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6772 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6773 (x_set_scroll_bar_width, x_figure_window_size):
6774 Check for integer overflow.
6775 (x_set_alpha): Do not assume XINT fits in int.
6777 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6778 This is for the members text_lines, text_cols, total_lines, total_cols,
6779 where the system imposes an 'int' limit.
6781 * fringe.c (Fdefine_fringe_bitmap):
6782 Don't update size until alloc works.
6784 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6785 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6787 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6788 Check for size-calculation overflow.
6789 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6790 do, as we prefer signed integers.
6791 (id_to_widget.max_size, id_to_widget.used)
6792 (xg_store_widget_in_map, xg_remove_widget_from_map)
6793 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6794 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6795 Use and return ptrdiff_t, not int.
6796 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6797 * gtkutil.h: Change prototypes to match the above.
6799 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6800 are duplicate now that they've been promoted to lisp.h.
6801 (x_allocate_bitmap_record, x_alloc_image_color)
6802 (make_image_cache, cache_image, xpm_load):
6803 Don't update size until alloc is done.
6804 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6806 Check for size calculation overflow.
6807 (ct_colors_allocated_max): New constant.
6808 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6811 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6812 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6813 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6814 Use ptrdiff_t, not int, to count maps.
6815 (read_char_minibuf_menu_prompt): Check for overflow in size
6816 calculations. Don't update size until allocation succeeds.
6817 Redo calculations to avoid overflow.
6818 * keyboard.h: Change prototypes to match the above.
6820 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6822 (current_minor_maps): Check for size calculation overflow.
6823 * keymap.h: Change prototypes to match the above.
6825 * lread.c (read1, init_obarray): Don't update size until alloc done.
6827 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6828 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6830 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6831 Now ptrdiff_t, not int.
6832 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6833 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6835 * process.c (Fnetwork_interface_list): Check for overflow
6836 in size calculation.
6838 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6840 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6841 overflow. Don't bother calling xmalloc when xrealloc will do.
6843 * search.c (Freplace_match): Check for size calculation overflow.
6844 (Fset_match_data): Don't assume list lengths fit in 'int'.
6846 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6847 for command line length. Do not attempt to address one before the
6848 beginning of an array, as that's not portable.
6850 * term.c (max_frame_lines): Remove; unused.
6851 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6853 (encode_terminal_code, calculate_costs): Check for size
6854 calculation overflow.
6855 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6856 table lengths and related sizes. Don't update size until alloc
6857 done. Redo calculations to avoid overflow.
6858 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6860 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6861 subtracting pointers.
6862 (gobble_line): Check for overflow more carefully. Don't update size
6865 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6866 Don't update size until alloc done.
6867 Redo size calculations to avoid overflow.
6868 Check for size calculation overflow.
6869 (main) [DEBUG]: Fix typo in invoking tparam1.
6871 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6872 Use ptrdiff_t, not int, for sizes.
6873 (store_mode_line_noprop_char): Don't update size until alloc done.
6875 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6876 Use ptrdiff_t, not int, for sizes.
6877 (Finternal_make_lisp_face, cache_face):
6878 Check for size calculation overflow.
6879 (cache_face): Treat size calculation overflows as if they were
6880 memory exhaustion (the usual treatment), rather than aborting.
6882 * xfns.c (x_encode_text, x_set_name_internal)
6883 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6884 sizes, since they can exceed INT_MAX in size. Check for size
6885 calculation overflow.
6887 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6888 (xg_select): Check for size calculation overflow.
6889 Don't update size until alloc done.
6891 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6892 as sprintf is limited to int lengths.
6894 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6895 (X_LONG_MIN): New macros.
6896 Use them to make the following changes clearer.
6897 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6898 This change doesn't affect the value now, but it may help remind
6899 future maintainers not to raise the value too much later.
6900 (SELECTION_QUANTUM): Remove, replacing with ...
6901 (selection_quantum): ... new function, which avoids overflow.
6903 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6904 assumption that selection length fits in 'int'.
6905 (x_reply_selection_request, x_handle_selection_request)
6906 (x_get_window_property, receive_incremental_selection)
6907 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6908 (lisp_data_to_selection_data, clean_local_selection_data):
6909 Use ptrdiff_t, not int, to record length of selection.
6910 (x_reply_selection_request, x_get_window_property)
6911 (receive_incremental_selection, x_property_data_to_lisp):
6912 Redo calculations to avoid overflow.
6913 (x_reply_selection_request): When sending hint, ceiling it at
6914 X_LONG_MAX rather than relying on wraparound overflow to send
6916 (x_get_window_property, receive_incremental_selection)
6917 (lisp_data_to_selection_data, x_property_data_to_lisp):
6918 Check for size-calculation overflow.
6919 (x_get_window_property, receive_incremental_selection)
6920 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6921 Don't store size until memory allocation succeeds.
6922 (x_get_window_property): Plug memory leak on memory exhaustion.
6923 Don't double-block input; malloc is safe here. Don't assume 2**34
6924 - 4 fits in unsigned long. Add an xassert to check
6925 XGetWindowProperty overflow. Be more careful about overflow
6926 calculations, and distinguish size from memory overflow better.
6927 (receive_incremental_selection): When tracing, don't assume
6928 unsigned int is less than INT_MAX.
6929 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6930 harmful) conversions of unsigned short to int.
6931 (lisp_data_to_selection_data): Don't assume that integers
6932 in the range -65535 through -1 fit in an X unsigned short.
6933 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6934 result parameters unless successful. Rely on cons_to_unsigned
6935 to report problems with elements; the old code wasn't right anyway.
6936 (x_check_property_data): Check for int overflow; we cannot use
6937 a wider type due to X limits.
6938 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6940 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6942 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6943 (x_term_init): Check for size calculation overflow.
6944 (x_color_cells): Don't store size until memory allocation succeeds.
6945 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6946 Don't assume alloca size is less than MAX_ALLOCA.
6947 (x_term_init): Don't assume length fits in int (sprintf is limited
6950 Use ptrdiff_t for composition IDs.
6951 * character.c (lisp_string_width):
6952 * composite.c (composition_table_size, n_compositions)
6953 (get_composition_id, composition_gstring_from_id):
6954 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6955 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6956 * window.c (Frecenter):
6957 Use ptrdiff_t, not int, for composition IDs.
6958 * composite.c (get_composition_id): Check for integer overflow.
6959 * composite.h: Adjust prototypes to match the above changes.
6961 Use ptrdiff_t for hash table indexes.
6962 * category.c (hash_get_category_set):
6963 * ccl.c (ccl_driver):
6964 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6965 * coding.c (coding_system_charset_list, detect_coding_system):
6966 * coding.h (struct coding_system.id):
6967 * composite.c (get_composition_id, gstring_lookup_cache):
6968 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6969 * image.c (xpm_get_color_table_h):
6970 * lisp.h (hash_lookup, hash_put):
6971 * minibuf.c (Ftest_completion):
6972 Use ptrdiff_t for hash table indexes, not int (which is too
6973 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6974 32-bit --with-wide-int hosts).
6976 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6977 Add a FIXME comment about memory leaks.
6978 (syms_of_charset): Don't assume xmalloc returns.
6980 Don't assume that stated character widths fit in int.
6981 * character.c (Fchar_width, c_string_width, lisp_string_width):
6982 * character.h (CHAR_WIDTH):
6983 * indent.c (MULTIBYTE_BYTES_WIDTH):
6984 Use sanitize_char_width to avoid undefined and/or bad behavior
6985 with outlandish widths.
6986 * character.h (sanitize_tab_width): Rename from sanitize_width,
6987 now that we have two such functions. All uses changed.
6988 (sanitize_char_width): New inline function.
6990 Don't assume that tab-width fits in int.
6991 * character.h (sanitize_width): New inline function.
6992 (SANE_TAB_WIDTH): New macro.
6993 (ASCII_CHAR_WIDTH): Use it.
6994 * indent.c (sane_tab_width): Remove. All uses replaced by
6995 SANE_TAB_WIDTH (current_buffer).
6996 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6998 * fileio.c: Integer overflow issues with file modes.
6999 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7001 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7002 Remove unreachable code.
7003 (read_hex, load_charset_map_from_file): Check for integer overflow.
7005 * xterm.c: Don't go over XClientMessageEvent limit.
7006 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7007 (x_send_scroll_bar_event): Likewise. Check that the size does not
7008 exceed limits imposed by XClientMessageEvent, as well as the usual
7009 ptrdiff_t and size_t limits.
7011 * keyboard.c: Overflow, signedness and related fixes.
7012 (make_lispy_movement): Use same integer type in forward decl
7013 that is used in the definition.
7014 (read_key_sequence, keyremap_step):
7015 Change bufsize argument back to int, undoing my 2011-03-30 change.
7016 We prefer signed types, and int is wide enough here.
7017 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7018 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7019 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7020 length, not size_t. Use ptrdiff_t for index, not int.
7021 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7022 possibility of integer overflow.
7024 Overflow, signedness and related fixes for images.
7026 * dispextern.h (struct it.stack[0].u.image.image_id)
7027 (struct_it.image_id, struct image.id, struct image_cache.size)
7028 (struct image_cache.used, struct image_cache.ref_count):
7029 * gtkutil.c (update_frame_tool_bar):
7030 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7031 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7032 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7033 * nsmenu.m (update_frame_tool_bar):
7034 * xdisp.c (calc_pixel_width_or_height):
7035 * xfns.c (image_cache_refcount):
7036 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7037 on typical 64-bit hosts.
7039 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7040 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7041 Omit unnecessary casts to int.
7042 (parse_image_spec): Check that integers fall into 'int' range
7043 when the callers expect that.
7044 (image_ascent): Redo ascent calculation to avoid int overflow.
7045 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7046 (lookup_image): Remove unnecessary tests.
7047 (xbm_image_p): Locals are now of int, not EMACS_INT,
7048 since parse_image_check makes sure they fit into int.
7049 (png_load, gif_load, svg_load_image):
7050 Prefer int to unsigned where either will do.
7051 (tiff_handler): New function, combining the cores of the
7052 old tiff_error_handler and tiff_warning_handler.
7053 This function is rewritten to use vsnprintf and thereby avoid
7054 stack buffer overflows. It uses only the features of vsnprintf
7055 that are common to both POSIX and native Microsoft.
7056 (tiff_error_handler, tiff_warning_handler): Use it.
7057 (tiff_load, gif_load, imagemagick_load_image):
7058 Don't assume :index value fits in 'int'.
7059 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7060 (imagemagick_load_image): Check that crop parameters fit into
7061 the integer types that MagickCropImage accepts. Don't assume
7062 Vimagemagick_render_type has a nonnegative value. Don't assume
7063 size_t fits in 'long'.
7064 (gs_load): Use printmax_t to print the widest integers possible.
7065 Check for integer overflow when computing image height and width.
7067 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7069 * xdisp.c (redisplay_window): Don't force window start if point
7070 will be invisible in the resulting window. (Bug#9324)
7072 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7074 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7075 the display spec is of the form `(space ...)'.
7076 (handle_display_spec): Return the value returned by
7077 handle_single_display_spec, not just 1 or zero.
7078 (handle_single_display_spec): If the display spec is of the form
7079 `(space ...)', and specifies display in the text area, return 2
7081 (try_cursor_movement): Check for the need to scroll more
7082 accurately, and prefer exact match for point under bidi.
7083 Don't advance `row' beyond the last row of the window.
7085 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7086 into disp_prop; all users changed.
7088 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7089 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7090 for the text covered by the display property.
7092 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7094 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7095 Change return value to nil.
7096 (Frecord_buffer): Delete unused function.
7098 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7100 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7101 buffers, return left-to-right.
7102 (set_cursor_from_row): Consider candidate row a win if its glyph
7103 represents a newline and point is on that newline. Fixes cursor
7104 positioning on the newline at EOL of R2L text within L2R
7105 paragraph, and vice versa.
7106 (try_cursor_movement): Check continued rows, in addition to
7107 continuation rows. Fixes unwarranted scroll when point enters a
7108 continued line of R2L text within an L2R paragraph, or vice versa.
7109 (cursor_row_p): Consider the case of point being equal to
7110 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7111 from the end of a short line to the beginning of a continued line
7112 of R2L text within L2R paragraph.
7113 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7114 composed characters.
7116 * bidi.c (bidi_check_type): Use xassert.
7117 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7120 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7122 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7125 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7127 * nsfont.m (ns_otf_to_script): Fix typo.
7129 2011-08-22 Kenichi Handa <handa@m17n.org>
7131 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7132 extra slot even if the purpose is char-code-property-table.
7134 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7136 * xdisp.c (redisplay_window): When computing centering_position,
7137 account for the height of the header line. (Bug#8874)
7139 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7140 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7141 candidate is selected by the mouse, and that candidate has a
7142 composed character under the mouse.
7144 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7145 coordinates reported by pos-visible-in-window-p for a composed
7146 character in column zero.
7148 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7150 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7152 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7154 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7155 consider it a hit if to_charpos is anywhere in the range of the
7156 composed buffer positions.
7158 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7160 * image.c (gif_load): Don't assume that each subimage has the same
7161 dimensions as the base image. Handle disposal method that is
7162 "undefined" by the gif spec (Bug#9335).
7164 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7166 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7167 (Fcondition_case): Document `debug' symbol in error handler.
7169 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7171 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7172 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7173 from an Org mode buffer to a Speedbar frame.
7175 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7176 a composition, take its buffer position from IT->cmp_it.charpos.
7177 Fixes cursor positioning at the beginning of a line that begins
7178 with a composed character.
7180 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7182 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7183 character bidirectional type, use STRONG_L instead. Fixes crashes
7184 in a buffer produced by `describe-categories'.
7186 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7187 members before the level stack, so they would be saved and
7188 restored when copying iterator state. Fixes incorrect reordering
7189 around TABs covered by display properties.
7191 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7193 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7195 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7197 * eval.c (internal_condition_case, internal_condition_case_1)
7198 (internal_condition_case_2, internal_condition_case_n):
7199 Remove unnecessary aborts (Bug#9081).
7201 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7203 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7204 has no `load' handler, try opening the file locally. (Bug#9311)
7206 2011-08-16 Ken Brown <kbrown@cornell.edu>
7208 * gmalloc.c: Expand comment.
7210 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7212 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7213 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7215 2011-08-16 Ken Brown <kbrown@cornell.edu>
7217 Fix memory allocation problems in Cygwin build (Bug#9273).
7219 * unexcw.c ( __malloc_initialized): Declare external variable.
7220 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7222 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7224 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7226 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7228 [CYGWIN] (special_realloc): New function.
7229 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7230 requests to realloc storage in the static heap.
7232 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7234 * bidi.c (bidi_initialize): Remove unused local.
7236 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7239 * biditype.h: Remove file.
7240 * makefile.w32-in ($(BLD)/bidi.$(O)):
7241 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7243 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7245 * chartab.c: Improve commentary for the uniprop_table API.
7247 * bidi.c (bidi_paragraph_init): Support zero value of
7248 bidi_ignore_explicit_marks_for_paragraph_level.
7249 (bidi_initialize): Use uniprop_table instead of including
7250 biditype.h and bidimirror.h.
7252 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7253 coordinates of the iterator when restoring from ppos_it.
7256 2011-08-14 Kenichi Handa <handa@m17n.org>
7258 * process.c (create_process): Call setup_process_coding_systems
7259 after the pid of the process is set to -1 (Bug#8162).
7261 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7263 * xdisp.c (move_it_in_display_line_to): Don't invoke
7264 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7265 ppos_it. Fixes vertical cursor motion when line beginning is
7266 covered by an image. (Bug#9296)
7268 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7270 * nsterm.h (ns_run_ascript): Declare.
7271 (NSAPP_DATA2_RUNASSCRIPT): Define.
7273 * nsfns.m (as_script, as_result, as_status): New static variables.
7274 (ns_run_ascript): New function.
7275 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7276 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7277 the event loop. Get status from as_status (Bug#7276).
7279 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7280 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7281 the event loop (Bug#7276).
7283 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7285 * gnutls.c (QCgnutls_bootprop_priority)
7286 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7287 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7288 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7289 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7290 (QCgnutls_bootprop_verify_hostname_error)
7291 (QCgnutls_bootprop_callbacks_verify): Rename from
7292 Qgnutls_bootprop_..., all uses changed.
7294 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7297 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7299 * xfaces.c (Qframe_set_background_mode): Now static.
7300 * dispextern.h (Qframe_set_background_mode): Remove decl.
7302 * process.c (Fnetwork_interface_info): Declare local only if needed.
7304 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7306 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7307 (Fnetwork_interface_list): Allocate in increments of bytes instead
7308 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7309 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7311 (struct ifflag_def): notrailers is smart on OSX.
7312 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7313 Get hardware address with getifaddrs if available.
7315 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7317 * xdisp.c (iterate_out_of_display_property): xassert that
7318 IT->position is set to within IT->object's boundaries. Break from
7319 the loop as soon as EOB is reached; avoids infloops in redisplay
7320 when IT->position is set up wrongly due to some bug.
7321 Set IT->current to match the bidi iterator unconditionally.
7322 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7323 entry. Force push_it to save on the stack the current
7324 buffer/string position, to be restored by pop_it. Fix flags in
7325 the iterator structure wrt the object coming from a display
7326 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7327 properties. (Bug#9284)
7329 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7331 * fontset.c (fontset_get_font_group): Add proper type checks.
7334 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7336 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7337 and LC_VERSION_MIN_MACOSX.
7338 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7339 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7341 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7343 * xdisp.c (forward_to_next_line_start): Allow to use the
7344 no-display-properties-and-no-overlays under bidi display.
7345 Set disp_pos in the bidi iterator to avoid searches for display
7346 properties and overlays.
7348 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7350 * editfns.c (Fset_time_zone_rule): Document relationship with the
7353 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7354 the font entity extracted from the cache (Bug#8109).
7356 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7358 * composite.c (autocmp_chars): Don't reset point. That is done by
7359 restore_point_unwind (Bug#5984).
7361 2011-08-07 Juri Linkov <juri@jurta.org>
7363 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7364 to show the arg `TIME' instead of `TIMEVAL'.
7366 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7368 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7369 display property strides EOL and includes a newline, as in
7370 longlines-mode. (Bug#9254)
7371 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7372 word-wrap under bidirectional display. (Bug#9224)
7374 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7375 is non-zero, even if the data buffer is NULL. Fixes a crash in
7376 vertical-motion with longlines-mode. (Bug#9254)
7378 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7380 * bidi.c <bidi_cache_total_alloc>: Now static.
7381 (bidi_initialize): Initialize bidi_cache_total_alloc.
7383 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7386 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7387 amount allocated this far in `bidi_cache_total_alloc'.
7388 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7389 non-zero, only free the data buffer without restoring the cache
7390 contents. All callers changed.
7392 * dispextern.h (bidi_unshelve_cache): Update prototype.
7394 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7395 (move_it_in_display_line, move_it_to)
7396 (move_it_vertically_backward, move_it_by_lines): Replace the call
7397 to xfree to an equivalent call to bidi_unshelve_cache.
7398 (move_it_in_display_line_to): Fix logic of returning
7399 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7401 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7403 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7404 came from a string character with a `cursor' property. (Bug#9229)
7406 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7408 * Makefile.in (LIB_PTHREAD): New variable.
7409 (LIBES): Add LIB_PTHREAD (Bug#9216).
7411 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7412 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7414 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7416 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7418 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7420 * xterm.c (x_find_topmost_parent): New function.
7421 (x_set_frame_alpha): Find topmost parent window with
7422 x_find_topmost_parent and set the property there also (bug#9181).
7423 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7425 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7427 * callproc.c (Fcall_process): Avoid vfork clobbering
7428 the local vars buffer, coding_systems, current_dir.
7430 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7432 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7434 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7436 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7437 so that it is not optimized away.
7439 * xdisp.c (compute_display_string_pos): Remove unused local.
7441 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7443 Fix slow cursor motion and scrolling in large buffers with
7444 selective display, like Org Mode buffers. (Bug#9218)
7446 * dispextern.h (struct bidi_it): New member disp_prop_p.
7448 * xdisp.c: Remove one-slot cache of display string positions.
7449 (compute_display_string_pos): Accept an additional argument
7450 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7451 for a display string or property. If found, set DISP_PROP_P
7454 * bidi.c (bidi_fetch_char): Accept an additional argument
7455 DISP_PROP_P, and pass it to compute_display_string_pos.
7456 Only handle text covered by a display string if DISP_PROP_P is returned
7457 non-zero. All callers of bidi_fetch_char changed.
7459 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7461 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7463 2010-12-03 Don March <don@ohspite.net>
7465 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7466 last character M-[char] is translated to ESC [char] (bug#7541).
7468 2011-08-02 Kenichi Handa <handa@m17n.org>
7470 * lisp.h (uniprop_table): Extern it.
7472 * chartab.c (uniprop_table): Make it non-static.
7474 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7476 * xdisp.c (forward_to_next_line_start): Accept additional argument
7477 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7479 (reseat_at_next_visible_line_start): Use the bidi iterator state
7480 returned by forward_to_next_line_start to restore the state of
7481 it->bidi_it after backing up to previous newline. (Bug#9212)
7483 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7485 * regex.c (re_comp): Protoize.
7486 (re_exec): Fix return type.
7487 (regexec): Fix type of `ret'. (Bug#9203)
7489 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7491 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7492 This is needed if max-image-size is a floating-point number.
7494 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7496 * print.c (print_object): Print empty symbol as ##.
7498 * lread.c (read1): Read ## as empty symbol.
7500 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7502 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7503 setting frame foreground color (Bug#9175).
7504 (x_set_background_color): Likewise.
7506 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7507 contents (Bug#9176).
7508 (EmacsTooltip -init): Remove bezels and add shadows to
7511 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7512 or scroll bar (Bug#8470).
7514 * nsfont.m (nsfont_open): Remove assignment to voffset and
7515 unnecessary vars hshink, expand, hd, full_height, min_height.
7516 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7518 * nsterm.h (nsfont_info): Remove voffset field.
7520 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7522 Implement strike-through and overline on NextStep (Bug#8863).
7524 * nsfont.m (nsfont_open): Use underline position provided by font,
7525 instead of hard-coded value of 2.
7526 (nsfont_draw): Call ns_draw_text_decoration instead.
7528 * nsterm.h: Add declaration for ns_draw_text_decoration.
7530 * nsterm.m (ns_draw_text_decoration): New function for drawing
7531 underline, overline, and strike-through.
7532 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7533 ns_draw_text_decoration. Change treatment of cursor drawing to
7534 accommodate underlining, etc.
7536 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7538 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7541 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7543 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7544 Without this fix, if a signal arrives just after memory fills up,
7545 'malloc' might be invoked reentrantly.
7547 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7548 In other words, assume that every image size is allowed, on non-X
7549 hosts. This assumption is probably wrong, but it lets Emacs compile.
7551 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7553 * regex.c (re_iswctype): Convert return values to boolean.
7555 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7557 * xdisp.c (compute_display_string_pos): Don't use cached display
7558 string position if the buffer had its restriction changed.
7561 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7563 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7565 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7567 Integer signedness and overflow and related fixes. (Bug#9079)
7569 * bidi.c: Integer size and overflow fixes.
7570 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7571 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7572 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7573 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7574 (bidi_find_other_level_edge):
7575 Use ptrdiff_t instead of EMACS_INT where either will do.
7576 This works better on 32-bit hosts configured --with-wide-int.
7577 (bidi_cache_ensure_space): Check for size-calculation overflow.
7578 Use % rather than repeated addition, for better worst-case speed.
7579 Don't set bidi_cache_size until after xrealloc returns, because it
7581 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7582 (bidi_cache_ensure_space): Also check that the bidi cache size
7583 does not exceed that of the largest Lisp string or buffer. See Eli
7584 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7586 * alloc.c (__malloc_size_t): Remove.
7587 All uses replaced by size_t. See Andreas Schwab's note
7588 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7590 * image.c: Improve checking for integer overflow.
7591 (check_image_size): Assume that f is nonnull, since
7592 it is always nonnull in practice. This is one less thing to
7593 worry about when checking for integer overflow later.
7594 (x_check_image_size): New function, which checks for integer
7595 overflow issues inside X.
7596 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7597 This removes the need for a memory_full check.
7598 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7599 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7600 (xbm_read_bitmap_data): Change locals back to 'int', since
7601 their values must fit in 'int'.
7602 (xpm_load_image, png_load, tiff_load):
7603 Invoke x_create_x_image_and_pixmap earlier,
7604 to avoid much needless work if the image is too large.
7605 (tiff_load): Treat overly large images as if
7606 x_create_x_image_and_pixmap failed, not as malloc failures.
7607 (gs_load): Use x_check_image_size.
7609 * gtkutil.c: Omit integer casts.
7610 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7611 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7613 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7615 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7616 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7617 would wrongly return t on a 64-bit host.
7619 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7620 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7621 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7622 and therefore cause GCC to emit a bogus diagnostic in some cases.
7624 * image.c: Integer signedness and overflow and related fixes.
7625 This is not an exhaustive set of fixes, but it's time to
7626 record what I've got.
7627 (lookup_pixel_color, check_image_size): Remove redundant decls.
7628 (check_image_size): Don't assume that arbitrary EMACS_INT values
7629 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7630 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7631 (tiff_load, imagemagick_load_image):
7632 Check for overflow in size calculations.
7633 (x_create_x_image_and_pixmap): Remove unnecessary test for
7634 xmalloc returning NULL; that can't happen.
7635 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7636 (xpm_color_bucket): Use better integer hashing function.
7637 (xpm_cache_color): Don't possibly over-allocate memory.
7638 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7639 (gif_memory_source):
7640 Use ptrdiff_t, not int or size_t, to record sizes.
7641 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7642 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7643 either works, as we prefer signed integers.
7644 (tiff_read_from_memory, tiff_write_from_memory):
7645 Return tsize_t, not size_t, since that's what the TIFF API wants.
7646 (tiff_read_from_memory): Don't fail simply because the read would
7647 go past EOF; instead, return a short read.
7648 (tiff_load): Omit no-longer-needed casts.
7649 (Fimagemagick_types): Don't assume size fits into 'int'.
7651 Improve hashing quality when configured --with-wide-int.
7652 * fns.c (hash_string): New function, taken from sxhash_string.
7653 Do not discard information about ASCII character case; this
7654 discarding is no longer needed.
7655 (sxhash-string): Use it. Change sig to match it. Caller changed.
7656 * lisp.h: Declare it.
7657 * lread.c (hash_string): Remove, since we now use fns.c's version.
7658 The fns.c version returns a wider integer if --with-wide-int is
7659 specified, so this should help the quality of the hashing a bit.
7661 * emacs.c: Integer overflow minor fix.
7662 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7663 Define only if GNU_LINUX.
7664 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7666 * dispnew.c: Integer signedness and overflow fixes.
7667 Remove unnecessary forward decls, that were a maintenance hassle.
7668 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7670 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7671 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7672 (prepare_desired_row, line_draw_cost):
7673 Use int, not unsigned, where either works.
7674 (save_current_matrix, restore_current_matrix):
7675 Use ptrdiff_t, not size_t, where either works.
7676 (init_display): Check for overflow more accurately, and without
7677 relying on undefined behavior.
7679 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7680 Remove, replacing with the new symbols in lisp.h. All uses changed.
7681 * fileio.c (make_temp_name):
7682 * filelock.c (lock_file_1, lock_file):
7683 * xdisp.c (message_dolog):
7684 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7685 Use pMd etc. instead.
7686 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7687 replacing the pWIDE etc. symbols removed from editfns.c.
7689 * keyboard.h (num_input_events): Now uintmax_t.
7690 This is (very slightly) less likely to mess up due to wraparound.
7693 * buffer.c: Integer signedness fixes.
7694 (alloc_buffer_text, enlarge_buffer_text):
7695 Use ptrdiff_t rather than size_t when either will do, as we prefer
7698 * alloc.c: Integer signedness and overflow fixes.
7699 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7700 (__malloc_size_t): Default to size_t, not to int.
7701 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7702 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7703 Prefer ptrdiff_t to size_t when either would do, as we prefer
7705 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7706 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7707 Now const. Initialize with values that are in range even if char
7709 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7710 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7711 These functions do the right thing with sizes > 2**32.
7712 (check_depth): Now ptrdiff_t, not int.
7713 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7714 Adjust to new way of storing sizes. Check for size overflow bugs
7716 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7717 slightly wrong anyway, as it missed one instance of
7718 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7719 (refill_memory_reserve): Omit needless cast to size_t.
7720 (mark_object_loop_halt): Mark as externally visible.
7722 * xselect.c: Integer signedness and overflow fixes.
7723 (Fx_register_dnd_atom, x_handle_dnd_message):
7724 Use ptrdiff_t, not size_t, since we prefer signed.
7725 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7726 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7727 x_dnd_atoms_size and x_dnd_atoms_length.
7729 * doprnt.c: Prefer signed to unsigned when either works.
7731 * doprnt.c (doprnt):
7733 * xdisp.c (vmessage):
7734 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7735 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7736 prefer signed arithmetic to avoid comparison confusion.
7737 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7738 but is a bit tricky.
7740 Assume freestanding C89 headers, string.h, stdlib.h.
7741 * data.c, doprnt.c, floatfns.c, print.c:
7742 Include float.h unconditionally.
7743 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7744 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7745 * regex.c: Likewise for stddef.h, string.h.
7746 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7747 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7748 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7749 (STDC_HEADERS): Remove obsolete defines.
7750 * sysdep.c: Include limits.h unconditionally.
7752 Assume support for memcmp, memcpy, memmove, memset.
7753 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7754 * regex.c (memcmp, memcpy):
7755 Remove; we assume C89 now.
7757 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7758 (__malloc_safe_bcopy): Remove; no longer needed.
7760 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7761 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7762 well either way, and we prefer signed to unsigned.
7764 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7766 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7767 closes the connection while we're reading (bug#9182).
7769 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7771 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7772 are specified (Bug#9168).
7774 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7776 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7777 Found by GCC static checking and --with-wide-int on a 32-bit host.
7779 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7781 * xdisp.c (compute_display_string_pos): Fix logic of caching
7782 previous display string position. Initialize cached_prev_pos to
7783 -1. Fixes slow-down at the beginning of a buffer.
7785 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7787 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7788 for attrs[LFACE_FONTSET_INDEX].
7790 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7792 * xml.c (parse_region): Remove unused local
7793 that was recently introduced.
7795 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7797 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7798 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7800 * xdisp.c (move_it_in_display_line_to): Record the best matching
7801 position for TO_CHARPOS while scanning the line, and restore it on
7802 exit if none of the characters scanned was an exact match.
7803 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7804 when exact match is impossible due to invisible text, and the
7805 lines are truncated.
7807 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7809 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7812 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7814 Fix a significant slow-down of cursor motion with C-n, C-p,
7815 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7816 auto-repeat under bidi redisplay in fontified buffers.
7817 * xdisp.c (compute_stop_pos_backwards): New function.
7818 (next_element_from_buffer): Call compute_stop_pos_backwards to
7819 find a suitable prev_stop when we find ourselves before
7821 (reseat): Don't look for prev_stop, as that could mean a very long
7823 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7824 <cached_disp_overlay_modiff>: Cache for last found display string
7826 (compute_display_string_pos): Return the cached position if asked
7827 about the same buffer in the same area of character positions, and
7828 the buffer wasn't changed since the time the display string
7829 position was cached.
7831 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7833 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7834 is an integer, which is important for empty lines. (Bug#9149)
7836 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7838 * frame.c (Fmodify_frame_parameters): In tty case, update the
7839 default face if necessary (Bug#4238).
7841 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7843 * editfns.c (Fstring_to_char): No need to explain what a character
7844 is in the docstring (Bug#6576).
7846 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7848 * xml.c (parse_region): Make sure we always return a tree.
7850 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7852 * xml.c (parse_region): If a document contains only comments,
7855 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7857 * xml.c (make_dom): Return comments, too.
7859 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7862 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7863 and the surrounding thread.
7864 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7865 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7866 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7868 * s/openbsd.h (BROKEN_SIGIO): Define.
7869 * unexelf.c (unexec) [__OpenBSD__]:
7870 Don't update the .mdebug section of the Alpha COFF symbol table.
7872 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7874 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7877 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7879 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7880 This fixes some race conditions on the permissions of any newly
7883 * alloc.c (valid_pointer_p): Use pipe, not open.
7884 This fixes some permissions issues when debugging.
7886 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7887 If fchown fails to set both uid and gid, try to set just gid,
7888 as that is sometimes allowed. Adjust the file's mode to eliminate
7889 setuid or setgid bits that are inappropriate if fchown fails.
7891 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7893 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7894 to compare Lisp_Objects.
7895 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7896 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7897 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7899 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7901 * lread.c (read_integer): Unread even EOF character.
7902 (read1): Likewise. Properly record start position of symbol.
7904 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7905 symbol character follows.
7907 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7909 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7910 This works around a problem with the previous change to Fcopy_file.
7911 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7912 and without this change, GCC might complain about discarding
7913 fchown's return value.
7915 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7917 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7919 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7921 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7923 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7925 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7926 it's used from the C level.
7928 * process.c: Use the same condition for POLL_FOR_INPUT in both
7929 keyboard.c and process.c (bug#1858).
7931 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7933 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7934 (Fgnutls_boot): Use it.
7936 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7938 * doc.c (Fsubstitute_command_keys): Revert last change.
7940 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7942 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7943 quotes the next character, and doesn't affect other longer
7944 sequences (bug#8935).
7946 * lread.c (syms_of_lread): Clarify that is isn't only
7947 `eval-buffer' and `eval-defun' that's affected by
7948 `lexical-binding' (bug#8460).
7950 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7952 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7953 bidi redisplay when a line includes both an image and is truncated.
7955 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7957 Fix minor problems found by static checking.
7958 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7959 (elsz): Now a signed constant, not a size_t var. We prefer signed
7960 types to unsigned, to avoid integer comparison confusion. Without
7961 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7962 "cannot optimize loop, the loop counter may overflow", a symptom
7964 * indent.c (Fvertical_motion): Mark locals as initialized.
7965 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7967 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7969 * search.c (Fre_search_backward): Mention `case-fold-search' in
7970 all the re_search_* functions (bug#8138).
7972 * keyboard.c (Fopen_dribble_file): Document when the file is
7975 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7977 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7980 Support bidi reordering of display and overlay strings.
7981 * xdisp.c (compute_display_string_pos)
7982 (compute_display_string_end): Accept additional argument STRING.
7983 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7984 (reseat_to_string): Initialize bidi_it->string.s and
7985 bidi_it->string.schars.
7986 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7987 NULL (avoids a crash in bidi_paragraph_init).
7988 Initialize itb.string.lstring.
7989 (init_iterator): Call bidi_init_it only of a valid
7990 buffer position was specified. Initialize paragraph_embedding to
7992 (reseat_to_string): Initialize the bidi iterator.
7993 (display_string): If we need to ignore text properties of
7994 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7995 original value of -1 will not work with bidi.)
7996 (compute_display_string_pos): First arg is now struct
7997 `text_pos *'; all callers changed. Support display properties on
7999 (compute_display_string_end): Support display properties on Lisp
8001 (init_iterator, reseat_1, reseat_to_string): Initialize the
8002 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8003 when iterating on a string not from display properties).
8004 (compute_display_string_pos, compute_display_string_end):
8005 Fix calculation of the object to scan. Fixes an error when using
8007 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8008 base_level_stop; instead, set base_level_stop to BEGV.
8009 Fixes crashes in vertical-motion.
8010 (next_element_from_buffer): Improve commentary for when
8011 the iterator is before prev_stop.
8012 (init_iterator): Initialize bidi_p from the default value of
8013 bidi-display-reordering, not from buffer-local value. Use the
8014 buffer-local value only if initializing for buffer iteration.
8015 (handle_invisible_prop): Support invisible properties on strings
8016 that are being bidi-reordered.
8017 (set_iterator_to_next): Support bidi reordering of C strings and
8019 (next_element_from_string): Support bidi reordering of Lisp
8021 (handle_stop_backwards): Support Lisp strings as well.
8022 (display_string): Support display of R2L glyph rows.
8023 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8024 (init_iterator): Don't initialize it->bidi_p for strings
8026 (reseat_to_string): Initialize it->bidi_p for strings here.
8027 (next_element_from_string, next_element_from_c_string)
8028 (next_element_from_buffer): Add xassert's for correspondence
8029 between IT's object being iterated and it->bidi_it.string
8031 (face_before_or_after_it_pos): Support bidi iteration.
8032 (next_element_from_c_string): Handle the case of the first string
8033 character that is not the first one in the visual order.
8034 (get_visually_first_element): New function, refactored from common
8035 parts of next_element_from_buffer, next_element_from_string, and
8036 next_element_from_c_string.
8037 (tool_bar_lines_needed, redisplay_tool_bar)
8038 (display_menu_bar): Force left-to-right direction. Add a FIXME
8039 comment for making that be controlled by a user option.
8040 (push_it, pop_it): Save and restore the state of the
8041 bidi iterator. Save and restore the bidi_p flag.
8042 (pop_it): Iterate out of display property for string iteration as
8044 (iterate_out_of_display_property): Support iteration over strings.
8045 (handle_single_display_spec): Set up it->bidi_it for iteration
8046 over a display string, and call bidi_init_it.
8047 (handle_single_display_spec, next_overlay_string)
8048 (get_overlay_strings_1, push_display_prop): Set up the bidi
8049 iterator for displaying display or overlay strings.
8050 (forward_to_next_line_start): Don't use the shortcut if
8052 (back_to_previous_visible_line_start): If handle_display_prop
8053 pushed the iterator stack, restore the internal state of the bidi
8054 iterator by calling bidi_pop_it same number of times.
8055 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8056 and we are bidi-iterating, don't decrement the iterator position;
8057 instead, set the first_elt flag in the bidi iterator, to produce
8059 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8060 (push_display_prop): xassert that we are iterating a buffer.
8061 (push_it, pop_it): Save and restore paragraph_embedding member.
8062 (handle_single_display_spec, next_overlay_string)
8063 (get_overlay_strings_1, reseat_1, reseat_to_string)
8064 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8065 correctly. Don't assume unibyte strings are not bidi-reordered.
8066 (compute_display_string_pos)
8067 (compute_display_string_end): Fix handling the case of C string.
8068 (push_it, pop_it): Save and restore from_disp_prop_p.
8069 (handle_single_display_spec, push_display_prop): Set the
8070 from_disp_prop_p flag.
8071 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8072 (pop_it): Call iterate_out_of_display_property only if we are
8073 popping after iteration over a string that came from a display
8074 property. Fix a typo in popping stretch info. Add an assertion
8075 for verifying that the iterator position is in sync with the bidi
8077 (handle_single_display_spec, get_overlay_strings_1)
8078 (push_display_prop): Fix initialization of paragraph direction for
8079 string when that of the parent object is not yet determined.
8080 (reseat_1): Call bidi_init_it to resync the bidi
8081 iterator with IT's position. (Bug#7616)
8082 (find_row_edges): If ROW->start.pos gives position
8083 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8084 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8085 Reset the from_disp_prop_p flag.
8086 (SAVE_IT, RESTORE_IT): New macros.
8087 (pos_visible_p, face_before_or_after_it_pos)
8088 (back_to_previous_visible_line_start)
8089 (move_it_in_display_line_to, move_it_in_display_line)
8090 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8091 (try_scrolling, redisplay_window, display_line): Use them when
8092 saving a temporary copy of the iterator and restoring it back.
8093 (back_to_previous_visible_line_start, reseat_1)
8094 (init_iterator): Empty the bidi cache "stack".
8095 (move_it_in_display_line_to): If iterator ended up at
8096 EOL, but we never saw any buffer positions smaller than
8097 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8098 motion in bidi-reordered lines.
8099 (move_it_in_display_line_to): Record prev_method and prev_pos
8100 immediately before the call to set_iterator_to_next. Fixes cursor
8101 motion in bidi-reordered lines with stretch glyphs and strings
8102 displayed in margins. (Bug#8133) (Bug#8867)
8103 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8105 (pos_visible_p): Support positions in bidi-reordered lines.
8106 Save and restore bidi cache.
8108 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8109 (bidi_paragraph_info): Delete unused struct.
8110 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8111 (bidi_cache_start): New variable.
8112 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8114 (bidi_cache_fetch_state, bidi_cache_search)
8115 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8116 (bidi_cache_find, bidi_peek_at_next_level)
8117 (bidi_level_of_next_char, bidi_find_other_level_edge)
8118 (bidi_move_to_visually_next): Compare cache index with
8119 bidi_cache_start rather than with zero.
8120 (bidi_fetch_char): Accept new argument STRING; all callers
8121 changed. Support iteration over a string. Support strings with
8122 display properties. Support unibyte strings. Fix the type of
8123 `len' according to what STRING_CHAR_AND_LENGTH expects.
8124 (bidi_paragraph_init, bidi_resolve_explicit_1)
8125 (bidi_resolve_explicit, bidi_resolve_weak)
8126 (bidi_level_of_next_char, bidi_move_to_visually_next):
8127 Support iteration over a string.
8128 (bidi_set_sor_type, bidi_resolve_explicit_1)
8129 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8130 can now be zero (for strings); special values 0 and -1 were
8131 changed to -1 and -2, respectively.
8132 (bidi_char_at_pos): New function.
8133 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8134 Call it instead of FETCH_MULTIBYTE_CHAR.
8135 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8136 initialized to valid values.
8137 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8139 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8140 the test for valid cached positions. Fix the logic for looking up
8141 the sentinel state in the cache. GCPRO the Lisp string we are
8143 (bidi_push_it, bidi_pop_it): New functions.
8144 (bidi_initialize): Initialize the bidi cache start stack pointer.
8145 (bidi_cache_ensure_space): New function, refactored from part of
8146 bidi_cache_iterator_state. Don't assume the required size is just
8147 one BIDI_CACHE_CHUNK away.
8148 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8149 (bidi_count_bytes, bidi_char_at_pos): New functions.
8150 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8151 always valid if bidi_cache_idx is valid.
8152 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8153 is valid if it's going to be used.
8154 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8155 (bidi_cache_fetch_state, bidi_cache_search)
8156 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8157 (bidi_cache_iterator_state, bidi_cache_find)
8158 (bidi_find_other_level_edge, bidi_cache_start_stack):
8159 All variables related to cache indices are now EMACS_INT.
8161 * dispextern.h (struct bidi_string_data): New structure.
8162 (struct bidi_it): New member `string'. Make flag members be 1-bit
8163 fields, and put them last in the struct.
8164 (compute_display_string_pos, compute_display_string_end):
8166 (bidi_push_it, bidi_pop_it): Add prototypes.
8167 (struct iterator_stack_entry): New members bidi_p,
8168 paragraph_embedding, and from_disp_prop_p.
8169 (struct it): Member bidi_p is now a bit field 1 bit wide.
8170 (bidi_shelve_cache, bidi_unshelve_cache):
8173 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8174 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8175 and vector-like objects.
8177 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8178 cache around display iteration.
8180 * window.c (Fwindow_end, window_scroll_pixel_based)
8181 (displayed_window_lines, Frecenter): Save and restore the bidi
8182 cache around display iteration.
8184 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8186 * editfns.c (Fdelete_region): Clarify the use of the named
8187 parameters (bug#6788).
8189 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8191 * indent.c (Fvertical_motion): Set and restore w->pointm when
8192 saving and restoring the window's buffer (Bug#9006).
8194 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8196 * editfns.c (Fstring_to_char): Clarify just what is returned
8197 (bug#6576). Text by Eli Zaretskii.
8199 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8201 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8203 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8205 * buffer.c (mmap_find): Fix a typo.
8207 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8209 Fix execution of x selection hooks.
8210 * xselect.c (Qx_lost_selection_functions)
8211 (Qx_sent_selection_functions): New vars.
8212 (syms_of_xselect): DEFSYM them.
8213 (x_handle_selection_request): Pass Qx_sent_selection_functions
8214 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8215 (x_handle_selection_clear,x_clear_frame_selections):
8216 Pass Qx_lost_selection_functions rather than
8217 Vx_lost_selection_functions to Frun_hook_with_args.
8219 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8221 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8222 The old code sometimes used this field without initializing it.
8224 * alloc.c (gc_sweep): Don't read past end of array.
8225 In theory, the old code could also have corrupted Emacs internals,
8226 though it'd be very unlikely.
8228 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8230 * character.c (Fcharacterp): Don't advertise optional ignored
8231 argument. (Bug#4026)
8233 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8235 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8238 * window.c (Fset_window_start): Doc fix (bug#4199).
8239 (Fset_window_hscroll): Ditto.
8241 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8243 Fix minor new problems caught by GCC 4.6.1.
8244 * term.c (init_tty): Remove unused local.
8245 * xsettings.c (store_monospaced_changed): Define this function only
8246 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8249 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8251 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8253 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8255 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8256 are the mini-buffer and the echo area (bug#3320).
8258 * term.c (init_tty): Remove support for supdup, c10 and perq
8259 terminals, which are no longer supported (bug#1482).
8261 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8263 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8265 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8267 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8268 for non-popups (Bug#3642).
8270 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8272 * alloc.c (reset_malloc_hooks): Protoize.
8273 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8274 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8275 * cm.c (losecursor): Likewise.
8276 * data.c (fmod): Likewise.
8277 * dispnew.c (swap_glyphs_in_rows): Likewise.
8278 * emacs.c (memory_warning_signal): Likewise.
8279 * floatfns.c (float_error): Likewise.
8280 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8281 (otf_open, font_otf_capability, generate_otf_features)
8282 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8284 * image.c (pbm_read_file): Likewise.
8285 * indent.c (string_display_width): Likewise.
8286 * intervals.c (check_for_interval, search_for_interval)
8287 (inc_interval_count, count_intervals, root_interval)
8288 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8289 * lread.c (defalias): Likewise.
8290 * ralloc.c (r_alloc_check): Likewise.
8291 * regex.c (set_image_of_range_1, set_image_of_range)
8292 (regex_grow_registers): Likewise.
8293 * sysdep.c (strerror): Likewise.
8294 * termcap.c (valid_filename_p, tprint, main): Likewise.
8295 * tparam.c (main): Likewise.
8296 * unexhp9k800.c (run_time_remap, save_data_space)
8297 (update_file_ptrs, read_header, write_header, calculate_checksum)
8298 (copy_file, copy_rest, display_header): Likewise.
8299 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8301 * xdisp.c (check_it): Likewise.
8302 * xfaces.c (register_color, unregister_color, unregister_colors):
8304 * xfns.c (print_fontset_result): Likewise.
8305 * xrdb.c (member, fatal, main): Likewise.
8307 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8309 Fix minor problems found by static checking (Bug#9031).
8310 * chartab.c (char_table_set_range, map_sub_char_table):
8311 Remove unused locals.
8312 (uniprop_table): Now static.
8313 * composite.c (_work_char): Remove unused static var.
8315 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8317 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8319 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8321 * gtkutil.c (qttip_cb): Remove code without function.
8323 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8325 * w32.c (pthread_sigmask): New stub.
8327 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8329 Use pthread_sigmask, not sigprocmask (Bug#9010).
8330 sigprocmask is portable only for single-threaded applications, and
8331 Emacs can be multi-threaded when it uses GTK.
8332 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8334 * callproc.c (Fcall_process):
8335 * process.c (create_process):
8336 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8337 Use pthread_sigmask, not sigprocmask.
8339 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8341 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8342 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8345 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8347 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8348 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8349 (xg_hide_tooltip): Fix comment.
8351 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8352 in registerServicesMenuSendTypes.
8353 (validRequestorForSendType): Don't check ns_return_types.
8355 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8358 2011-07-08 Jason Rumney <jasonr@gnu.org>
8360 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8361 SH_SHOW for hidden windows (Bug#5482).
8363 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8364 frame struct members of non-existent frames (Bug#6284).
8366 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8368 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8369 variable firstTime not needed on OSX >= 10.6.
8370 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8371 >= 10.5. Use setKnobProportion, setDoubleValue.
8373 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8374 (MAC_OS_X_VERSION_10_5): Define if not defined.
8375 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8376 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8377 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8379 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8380 cString and lossyCString on OSX >= 10.4.
8382 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8383 sizeToFit on OSX >= 10.2.
8385 * nsimage.m (allocInitFromFile): Don't use deprecated method
8386 bestRepresentationForDevice on OSX >= 10.6.
8388 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8391 * emacs.c: Declare unexec_init_emacs_zone.
8393 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8395 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8397 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8398 on svcsMenu (Bug#8842).
8400 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8402 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8404 * nsterm.m (QUTF8_STRING): Declare.
8405 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8406 (validRequestorForSendType): Return type is (id).
8407 Change indexOfObjectIdenticalTo to indexOfObject.
8408 Check if we have local selection before returning self (Bug#8842).
8409 (writeSelectionToPasteboard): Put local selection into paste board
8410 if we have a local selection (Bug#8842).
8411 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8413 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8414 (ns_get_local_selection): Declare.
8416 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8418 * keymap.c (describe_map_tree): Don't insert a double newline at
8419 the end of the buffer (bug#1169) and return whether we inserted
8422 * callint.c (Fcall_interactively): Change "reading args" to
8423 "providing args" to try to clarify what it does (bug#1010).
8425 2011-07-07 Kenichi Handa <handa@m17n.org>
8427 * composite.c (composition_compute_stop_pos): Ignore a static
8428 composition starting before CHARPOS (Bug#8915).
8430 * xdisp.c (handle_composition_prop): Likewise.
8432 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8434 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8437 2011-07-07 Kenichi Handa <handa@m17n.org>
8439 * character.h (unicode_category_t): New enum type.
8441 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8442 (Qchar_code_property_table): New variable.
8443 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8444 (UNIPROP_COMPRESSED_FORM_P): New macros.
8445 (char_table_ascii): Uncompress the compressed values.
8446 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8447 Uncompress the compressed values.
8448 (sub_char_table_ref_and_range): Likewise.
8449 (char_table_ref_and_range): Uncompress the compressed values.
8450 (sub_char_table_set): New arg is_uniprop. Callers changed.
8451 Uncompress the compressed values.
8452 (sub_char_table_set_range): Args changed. Callers changed.
8453 (char_table_set_range): Adjuted for the above change.
8454 (map_sub_char_table): Delete args default_val and parent. Add arg
8455 top. Give decoded values to a Lisp function.
8456 (map_char_table): Adjust for the above change. Give decoded
8457 values to a Lisp function. Gcpro more variables.
8458 (uniprop_table_uncompress)
8459 (uniprop_decode_value_run_length): New functions.
8460 (uniprop_decoder, uniprop_decoder_count): New variables.
8461 (uniprop_get_decoder, uniprop_encode_value_character)
8462 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8464 (uniprop_encoder, uniprop_encoder_count): New variables.
8465 (uniprop_get_encoder, uniprop_table)
8466 (Funicode_property_table_internal, Fget_unicode_property_internal)
8467 (Fput_unicode_property_internal): New functions.
8468 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8469 Sunicode_property_table_internal, Sget_unicode_property_internal,
8470 and Sput_unicode_property_internal. Defvar_lisp
8471 char-code-property-alist.
8473 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8474 Vunicode_category_table.
8476 * font.c (font_range): Adjust for the change of
8477 Vunicode_category_table.
8479 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8481 * m/iris4d.h: Remove file, move contents ...
8482 * s/irix6-5.h: ... here.
8484 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8486 Remove unportable assumption about struct layout (Bug#8884).
8487 * alloc.c (mark_buffer):
8488 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8489 (clone_per_buffer_values): Don't assume that
8490 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8491 This isn't true in general, and it's particularly not true
8492 if Emacs is configured with --with-wide-int.
8493 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8494 New macros, used in the buffer.c change.
8496 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8498 * xsettings.c: Use both GConf and GSettings if both are available.
8499 (store_config_changed_event): Add comment.
8500 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8501 (store_tool_bar_style_changed): New functions.
8502 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8503 (struct xsettings): Move font inside HAVE_XFT.
8504 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8505 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8506 Move inside HAVE_XFT.
8507 (something_changed_gsettingsCB): Rename from something_changedCB.
8508 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8510 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8511 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8512 (something_changed_gconfCB): Rename from something_changedCB.
8513 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8514 (parse_settings): Move check for font inside HAVE_XFT.
8515 (read_settings, apply_xft_settings): Add comment.
8516 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8517 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8518 call store_font_name_changed.
8519 (xft_settings_event): Add comment.
8520 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8521 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8522 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8523 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8524 (xsettings_initialize): Call init_gsettings last.
8525 (xsettings_get_system_font, xsettings_get_system_normal_font):
8528 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8530 Random fixes. E.g., (random) never returned negative values.
8531 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8532 subseconds part to the entropy, as that's a bit more random.
8533 Prefer signed to unsigned, since the signedness doesn't matter and
8534 in general we prefer signed. When given a limit, use a
8535 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8536 latter isn't right if USE_2_TAGS_FOR_INTS.
8537 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8538 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8540 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8542 * textprop.c (text_property_stickiness):
8543 Obey Vtext_property_default_nonsticky.
8544 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8545 * w32fns.c (syms_of_w32fns):
8546 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8548 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8550 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8551 This is more efficient than Ffile_directory_p and avoids a minor race.
8553 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8555 * buffer.c (Foverlay_put): Say what the return value is
8558 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8559 is a directory before asking whether to use the file name
8561 (barf_or_query_if_file_exists): Make the "File is a directory"
8562 error be more correct.
8564 * fns.c (Frequire): Remove the mention of the .gz files, since
8565 that's installation-specific, but keep the mention of
8566 `get-load-suffixes'.
8568 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8570 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8571 Report string overflow if the output is too long.
8573 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8575 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8576 (syms_of_gnutls): Remove duplicate DEFSYM for
8577 Qgnutls_bootprop_verify_hostname_error, an error for
8578 Qgnutls_bootprop_verify_error (which is no longer used).
8580 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8581 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8582 Also (re)move comments that are misplaced or no longer relevant.
8584 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8586 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8588 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8590 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8591 and background color parameters if they have been changed.
8593 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8595 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8597 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8599 * xsettings.c (SYSTEM_FONT): Define only when used.
8600 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8602 * keymap.c (access_keymap_1): Now static.
8604 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8606 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8607 leave any prefix arg for the up event (Bug#1586).
8609 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8611 * lread.c (syms_of_lread): Mention single symbols defined by
8612 `defvar' or `defconst' (bug#7154).
8614 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8615 (Frequire): Mention get-load-suffixes.
8617 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8619 * window.h (window): Remove clone_number slot.
8620 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8622 (make_parent_window, make_window, saved_window)
8623 (Fset_window_configuration, save_window_save): Don't deal with
8625 * buffer.c (Qclone_number): Remove declaration.
8626 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8628 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8630 Add multiple inheritance to keymaps.
8631 * keymap.c (Fmake_composed_keymap): New function.
8632 (Fset_keymap_parent): Simplify.
8633 (fix_submap_inheritance): Remove.
8634 (access_keymap_1): New function extracted from access_keymap to handle
8635 embedded parents and handle lists of maps.
8636 (access_keymap): Use it.
8637 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8638 (Fcopy_keymap): Handle embedded parents.
8639 (Fcommand_remapping, define_as_prefix): Simplify.
8640 (Fkey_binding): Simplify.
8641 (syms_of_keymap): Move minibuffer-local-completion-map,
8642 minibuffer-local-filename-completion-map,
8643 minibuffer-local-must-match-map, and
8644 minibuffer-local-filename-must-match-map to Elisp.
8645 (syms_of_keymap): Defsubr make-composed-keymap.
8646 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8647 (parse_menu_item): Trivial simplification.
8649 2011-07-01 Glenn Morris <rgm@gnu.org>
8651 * Makefile.in (SETTINGS_LIBS): Fix typo.
8653 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8655 * coding.c (Fencode_coding_string): Record the last coding system
8656 used, as the function doc string says (bug#8738).
8658 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8660 * xsettings.c (store_monospaced_changed): Take new font as arg and
8661 check for change against current_mono_font.
8662 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8663 (emacs_settings_constructor, emacs_settings_get_property)
8664 (emacs_settings_set_property, emacs_settings_class_init)
8665 (emacs_settings_init, gsettings_obj): Remove.
8666 (something_changedCB): New function for HAVE_GSETTINGS.
8667 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8668 with value as argument.
8669 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8670 g_settings_new (Bug#8967). Do not create gsettings_obj.
8671 Remove calls to g_settings_bind. Connect something_changedCB to
8674 * xgselect.c: Add defined (HAVE_GSETTINGS).
8675 (xgselect_initialize): Ditto.
8677 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8678 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8681 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8683 * eval.c (struct backtrace): Simplify and port the data structure.
8684 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8685 signed bit field, as this assumption is not portable and it makes
8686 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8687 "char debug_on_exit : 1" as this is not portable either; instead,
8688 use the portable "unsigned int debug_on_exit : 1". Remove unused
8689 member evalargs. Remove obsolete comments about cc bombing out.
8691 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8693 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8694 Let HAVE_GSETTINGS override HAVE_GCONF.
8695 (store_monospaced_changed): New function.
8696 (EMACS_SETTINGS): A new type derived from GObject to handle
8697 GSettings notifications.
8698 (emacs_settings_constructor, emacs_settings_get_property)
8699 (emacs_settings_set_property, emacs_settings_class_init):
8701 (gsettings_client, gsettings_obj): New variables.
8702 (GSETTINGS_SCHEMA): New define.
8703 (something_changedCB): Call store_monospaced_changed.
8704 (init_gsettings): New function.
8705 (xsettings_initialize): Call init_gsettings.
8706 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8709 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8712 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8714 * window.c (resize_root_window, grow_mini_window)
8715 (shrink_mini_window): Rename Qresize_root_window to
8716 Qwindow_resize_root_window and Qresize_root_window_vertically to
8717 Qwindow_resize_root_window_vertically.
8719 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8721 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8723 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8725 * makefile.w32-in: Redesign dependencies so they reflect more
8726 clearly which files are directly included by each source file,
8727 and not through other includes.
8729 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8731 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8732 (sort_overlays, overlay_strings): When an overlay's clone number
8733 matches the window's clone number process the overlay even if
8734 the overlay's window property doesn't match the current window.
8736 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8737 (Fwindow_hchild): Rename to Fwindow_left_child.
8738 (Fwindow_next): Rename to Fwindow_next_sibling.
8739 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8740 (resize_window_check): Rename to window_resize_check.
8741 (resize_window_apply): Rename to window_resize_apply.
8742 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8743 (Fdelete_other_windows_internal, resize_frame_windows)
8744 (Fsplit_window_internal, Fdelete_window_internal)
8745 (grow_mini_window, shrink_mini_window)
8746 (Fresize_mini_window_internal): Fix callers accordingly.
8748 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8750 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8751 (emacs_fixed_set_min_size): Remove.
8752 (emacs_fixed_new): Take frame as argument.
8754 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8755 (_EmacsFixedPrivate): Remove minwidth/height.
8756 Add struct frame *f.
8757 (emacs_fixed_init): Initialize priv->f.
8758 (get_parent_class, emacs_fixed_set_min_size): Remove.
8759 (emacs_fixed_new): Set priv->f to argument.
8760 (emacs_fixed_get_preferred_width)
8761 (emacs_fixed_get_preferred_height): Use min_width/height from
8762 frames size_hint to set minimum and natural (Bug#8919).
8763 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8764 and use min_width/height from frames size_hint to set
8765 min_width/height (Bug#8919).
8767 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8768 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8771 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8773 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8774 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8777 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8779 * process.c (wait_reading_process_output): Bypass select if
8780 waiting for a cell while ignoring keyboard input, and input is
8781 pending. Suggested by Jan Djärv (Bug#8869).
8783 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8785 Use gnulib's dup2 module instead of rolling our own.
8786 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8788 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8790 * dispnew.c (scrolling_window): Before scrolling, turn off a
8791 mouse-highlight in the window being scrolled.
8793 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8795 Move DEFSYM to lisp.h and use everywhere.
8797 * character.h (DEFSYM): Move declaration...
8798 * lisp.h (DEFSYM): ...here.
8804 * w32select.c: Don't include character.h.
8806 * alloc.c (syms_of_alloc):
8807 * buffer.c (syms_of_buffer):
8808 * bytecode.c (syms_of_bytecode):
8809 * callint.c (syms_of_callint):
8810 * casefiddle.c (syms_of_casefiddle):
8811 * casetab.c (init_casetab_once):
8812 * category.c (init_category_once, syms_of_category):
8813 * ccl.c (syms_of_ccl):
8814 * cmds.c (syms_of_cmds):
8815 * composite.c (syms_of_composite):
8816 * dbusbind.c (syms_of_dbusbind):
8817 * dired.c (syms_of_dired):
8818 * dispnew.c (syms_of_display):
8819 * doc.c (syms_of_doc):
8820 * editfns.c (syms_of_editfns):
8821 * emacs.c (syms_of_emacs):
8822 * eval.c (syms_of_eval):
8823 * fileio.c (syms_of_fileio):
8824 * fns.c (syms_of_fns):
8825 * frame.c (syms_of_frame):
8826 * fringe.c (syms_of_fringe):
8827 * insdel.c (syms_of_insdel):
8828 * keymap.c (syms_of_keymap):
8829 * lread.c (init_obarray, syms_of_lread):
8830 * macros.c (syms_of_macros):
8831 * msdos.c (syms_of_msdos):
8832 * print.c (syms_of_print):
8833 * process.c (syms_of_process):
8834 * search.c (syms_of_search):
8835 * sound.c (syms_of_sound):
8836 * syntax.c (init_syntax_once, syms_of_syntax):
8837 * terminal.c (syms_of_terminal):
8838 * textprop.c (syms_of_textprop):
8839 * undo.c (syms_of_undo):
8840 * w32.c (globals_of_w32):
8841 * window.c (syms_of_window):
8842 * xdisp.c (syms_of_xdisp):
8843 * xfaces.c (syms_of_xfaces):
8844 * xfns.c (syms_of_xfns):
8845 * xmenu.c (syms_of_xmenu):
8846 * xsettings.c (syms_of_xsettings):
8847 * xterm.c (syms_of_xterm): Use DEFSYM.
8849 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8851 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8853 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8855 Integer and buffer overflow fixes (Bug#8873).
8857 * print.c (printchar, strout): Check for string overflow.
8858 (PRINTPREPARE, printchar, strout):
8859 Don't set size unless allocation succeeds.
8861 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8862 for sizes. Check for string overflow more accurately.
8863 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8865 * macros.c: Integer and buffer overflow fixes.
8866 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8867 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8868 Use ptrdiff_t, not int, for sizes.
8869 Don't increment bufsize until after realloc succeeds.
8870 Check for size-calculation overflow.
8871 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8873 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8875 * lread.c: Integer overflow fixes.
8876 (read_integer): Radix is now EMACS_INT, not int,
8877 to improve quality of diagnostics for out-of-range radices.
8878 Calculate buffer size correctly for out-of-range radices.
8879 (read1): Check for integer overflow in radices, and in
8880 read-circle numbers.
8881 (read_escape): Avoid int overflow.
8882 (Fload, openp, read_buffer_size, read1)
8883 (substitute_object_recurse, read_vector, read_list, map_obarray):
8884 Use ptrdiff_t, not int, for sizes.
8885 (read1): Use EMACS_INT, not int, for sizes.
8886 Check for size overflow.
8888 * image.c (cache_image): Check for size arithmetic overflow.
8890 * lread.c: Integer overflow issues.
8891 (saved_doc_string_size, saved_doc_string_length)
8892 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8893 Now ptrdiff_t, not int.
8894 (read1): Don't assume doc string length fits in int. Check for
8895 out-of-range doc string lengths.
8896 (read_list): Don't assume file position fits in int.
8897 (read_escape): Check for hex character overflow.
8899 2011-06-22 Leo Liu <sdl.web@gmail.com>
8901 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8902 Move to minibuffer.el.
8904 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8906 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8907 The following patches are for when GLYPH_DEBUG && !XASSERT.
8908 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8909 * dispnew.c (flush_stdout):
8910 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8911 Mark as externally visible.
8912 * dispnew.c (check_window_matrix_pointers): Now static.
8913 * dispnew.c (window_to_frame_vpos):
8914 * xfns.c (unwind_create_frame):
8915 * xterm.c (x_check_font): Remove unused local.
8916 * scroll.c (CHECK_BOUNDS):
8917 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8918 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8919 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8920 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8921 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8923 (debug_method_add): Use va_list and vsprintf rather than relying
8924 on undefined behavior with wrong number of arguments.
8925 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8926 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8927 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8928 since we're not interested in debugging glyphs with old libraries.
8929 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8930 GCC 4.6.0's static checking.
8932 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8934 Integer overflow and signedness fixes (Bug#8873).
8935 A few related buffer overrun fixes, too.
8937 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8939 * dispextern.h (struct face.stipple):
8940 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8941 (x_bitmap_mask, x_allocate_bitmap_record)
8942 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8943 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8944 (x_create_bitmap_from_xpm_data):
8945 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8946 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8948 * xfaces.c (load_pixmap):
8949 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8950 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8951 (.bitmaps_last, struct x_output.icon_bitmap):
8952 Use ptrdiff_t, not int, for bitmap indexes.
8953 (x_allocate_bitmap_record): Check for size overflow.
8954 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8956 Use ptrdiff_t, not int, for overlay counts.
8957 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8958 * editfns.c (overlays_around, get_pos_property):
8959 * textprop.c (get_char_property_and_overlay):
8960 * xdisp.c (next_overlay_change, note_mouse_highlight):
8961 * xfaces.c (face_at_buffer_position):
8962 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8963 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8964 (Fnext_overlay_change, Fprevious_overlay_change)
8965 (mouse_face_overlay_overlaps, Foverlays_in):
8966 Use ptrdiff_t, not int, for sizes.
8967 (overlays_at, overlays_in): Check for size-calculation overflow.
8969 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8971 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8972 (x_session_initialize): Do not assume string length fits in int.
8974 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8975 This is unlikely, but can occur if DPI is outlandish.
8977 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8978 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8980 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8981 * xrdb.c (magic_file_p, search_magic_path):
8982 Omit last arg SUFFIX; it was always 0. All callers changed.
8983 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8985 * xfont.c (xfont_match): Avoid need for strlen.
8987 * xfns.c: Don't assume strlen fits in int.
8988 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8990 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8991 not unsigned long, as we prefer signed integers. All callers changed.
8992 Detect integer overflow in repeat count.
8993 (message_dolog): Don't assume print length fits in 39 bytes.
8994 (display_mode_element): Don't assume strlen fits in int.
8996 * termcap.c: Don't assume sizes fit in int and never overflow.
8997 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8998 (gobble_line): Check for size-calculation overflow.
9000 * minibuf.c (Fread_buffer):
9001 * lread.c (intern, intern_c_string):
9002 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9003 Don't assume string length fits in int.
9005 * keyboard.c (parse_tool_bar_item):
9006 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9008 * font.c: Don't assume string length fits in int.
9009 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9010 Use ptrdiff_t, not int.
9011 (font_intern_prop): Don't assume string length fits in int.
9012 Don't assume integer property fits in fixnum.
9013 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9015 * filelock.c: Fix some buffer overrun and integer overflow issues.
9016 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9017 Reformulate so as not to need the command string.
9018 Invoke gzip -cd rather than gunzip, as it's more portable.
9019 (lock_info_type, lock_file_1, lock_file):
9020 Don't assume pid_t and time_t fit in unsigned long.
9021 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9022 (current_lock_owner): Prefer signed type for sizes.
9023 Use memcpy, not strncpy, where memcpy is what is really wanted.
9024 Don't assume (via atoi) that time_t and pid_t fit in int.
9025 Check for time_t and/or pid_t out of range, e.g., via a network share.
9026 Don't alloca where an auto var works fine.
9028 * fileio.c: Fix some integer overflow issues.
9029 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9030 Don't assume string length fits in int.
9031 (directory_file_name): Don't assume string length fits in long.
9032 (make_temp_name): Don't assume pid fits in int, or that its print
9033 length is less than 20.
9035 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9037 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9039 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9041 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9042 We prefer signed integers, even for size calculations.
9044 * emacs.c: Don't assume string length fits in 'int'.
9045 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9046 (main): Don't invoke strlen when not needed.
9048 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9049 (XD_DEBUG_MESSAGE): Don't waste a byte.
9051 * callproc.c (getenv_internal_1, getenv_internal)
9053 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9055 * lread.c (invalid_syntax): Omit length argument.
9056 All uses changed. This doesn't fix a bug, but it simplifies the
9057 code away from its former Hollerith-constant appearance, and it's
9058 one less 'int' to worry about when looking at integer-overflow issues.
9059 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9061 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9062 This didn't break anything, but it didn't help either.
9063 It's confusing to put a bogus integer in a place where the actual
9064 value does not matter.
9065 (LIST_END_P): Remove unused macro and its bogus comment.
9066 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9068 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9069 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9071 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9072 We prefer signed types, and the value cannot exceed the EMACS_INT
9073 range anyway (because otherwise the length would not be representable).
9074 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9075 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9076 This avoids a GCC warning when WIDE_EMACS_INT.
9078 * indent.c (sane_tab_width): New function.
9079 (current_column, scan_for_column, Findent_to, position_indentation)
9080 (compute_motion): Use it. This is just for clarity.
9081 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9083 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9085 * lisp.h (lint_assume): New macro.
9086 * composite.c (composition_gstring_put_cache):
9087 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9089 * editfns.c, insdel.c:
9090 Omit unnecessary forward decls, to simplify future changes.
9092 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9094 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9096 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9097 Use much-faster test for byte-length change.
9098 Don't assume string byte-length fits in 'int'.
9099 Check that character arg fits in 'int'.
9100 (mapcar1): Declare byte as byte, for clarity.
9102 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9104 * fns.c (concat): Catch string overflow earlier.
9105 Do not rely on integer wraparound.
9107 * dispextern.h (struct it.overlay_strings_charpos)
9108 (struct it.selective): Now EMACS_INT, not int.
9109 * xdisp.c (forward_to_next_line_start)
9110 (back_to_previous_visible_line_start)
9111 (reseat_at_next_visible_line_start, next_element_from_buffer):
9112 Don't arbitrarily truncate the value of 'selective' to int.
9114 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9116 * composite.c: Don't truncate sizes to 'int'.
9117 (composition_gstring_p, composition_reseat_it)
9118 (composition_adjust_point): Use EMACS_INT, not int.
9119 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9120 not EMACS_UINT, for indexes.
9122 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9124 * buffer.c: Include <verify.h>.
9125 (struct sortvec.priority, struct sortstr.priority):
9126 Now EMACS_INT, not int.
9127 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9128 (struct sortstr.size, record_overlay_string)
9129 (struct sortstrlist.size, struct sortlist.used):
9130 Don't truncate size to int.
9131 (record_overlay_string): Check for size-calculation overflow.
9132 (init_buffer_once): Check at compile-time, not run-time.
9134 2011-06-22 Jim Meyering <meyering@redhat.com>
9136 Don't leak an XBM-image-sized buffer
9137 * image.c (xbm_load): Free the image buffer after using it.
9139 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9142 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9143 that Sun C diagnosed.
9144 * fns.c (secure_hash): Fix pointer signedness issue.
9145 * intervals.c (static_offset_intervals): New function.
9146 (offset_intervals): Use it.
9148 2011-06-21 Leo Liu <sdl.web@gmail.com>
9151 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9154 * fns.c (secure_hash): Rename from crypto_hash_function and change
9155 the first arg to accept symbols.
9156 (Fsecure_hash): New primitive.
9157 (syms_of_fns): New symbols.
9159 2011-06-20 Deniz Dogan <deniz@dogan.se>
9161 * process.c (Fset_process_buffer): Clarify return value in
9164 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9166 * dispnew.c (add_window_display_history): Use BVAR.
9168 * xdisp.c (debug_method_add): Use BVAR.
9169 (check_window_end, dump_glyph_matrix, dump_glyph)
9170 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9172 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9175 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9176 check till after the cache is created in init_frame_faces.
9178 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9180 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9182 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9184 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9185 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9186 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9188 Improve buffer-overflow checking (Bug#8873).
9189 * fileio.c (Finsert_file_contents):
9190 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9191 Remove the old (too-loose) buffer overflow checks.
9192 They weren't needed, since make_gap checks for buffer overflow.
9193 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9194 The old code merely checked for Emacs fixnum overflow, and relied
9195 on undefined (wraparound) behavior. The new code avoids undefined
9196 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9198 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9199 Tune. Don't use wider integers than needed. Don't use alloca.
9200 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9202 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9204 * insdel.c, lisp.h (buffer_overflow): New function.
9205 (insert_from_buffer_1, replace_range, replace_range_2):
9206 * insdel.c (make_gap_larger):
9207 * editfns.c (Finsert_char):
9208 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9210 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9212 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9214 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9216 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9217 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9219 * fileio.c: Don't assume EMACS_INT fits in off_t.
9220 (emacs_lseek): New static function.
9221 (Finsert_file_contents, Fwrite_region): Use it.
9222 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9224 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9226 * fns.c: Don't overflow int when computing a list length.
9227 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9228 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9229 truncation on 64-bit hosts. Check for QUIT every
9230 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9231 faster and is responsive enough.
9232 (Flength): Report an error instead of overflowing an integer.
9233 (Fsafe_length): Return a float if the value is not representable
9234 as a fixnum. This shouldn't happen except in contrived situations.
9235 (Fnthcdr, Fsort): Don't assume list length fits in int.
9236 (Fcopy_sequence): Don't assume vector length fits in int.
9238 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9239 (header_size, word_size): New constants.
9240 (allocate_vectorlike): Don't check size overflow here.
9241 (allocate_vector): Check it here instead, since this is the only
9242 caller of allocate_vectorlike that could cause overflow.
9243 Check that the new vector's length is representable as a fixnum.
9245 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9246 The previous code was bogus. For example, next_almost_prime (32)
9247 returned 39, which is undesirable as it is a multiple of 3; and
9248 next_almost_prime (24) returned 25, which is a multiple of 5 so
9249 why was the code bothering to check for multiples of 7?
9251 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9253 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9255 Variadic C functions now count arguments with ptrdiff_t.
9256 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9257 Back then I didn't know that the Emacs coding style prefers signed int.
9258 Also, in the meantime I found a few more instances where arguments
9259 were being counted with int, which may truncate counts on 64-bit
9260 machines, or EMACS_INT, which may be unnecessarily wide.
9261 * lisp.h (struct Lisp_Subr.function.aMANY)
9262 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9263 Arg counts are now ptrdiff_t, not size_t.
9264 All variadic functions and their callers changed accordingly.
9265 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9266 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9267 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9268 * callint.c (Fcall_interactively): Check arg count for overflow,
9269 to avoid potential buffer overrun. Use signed char, not 'int',
9270 for 'varies' array, so that we needn't bother to check its size
9271 calculation for overflow.
9272 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9273 * eval.c (apply_lambda):
9274 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9275 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9276 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9278 * callint.c (Fcall_interactively): Don't use index var as event count.
9280 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9281 * mem-limits.h (SIZE): Remove; no longer used.
9283 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9285 Remove unnecessary casts.
9286 * xterm.c (x_term_init):
9287 * xfns.c (x_set_border_pixel):
9288 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9289 These aren't needed now that we assume ANSI C.
9291 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9292 It's more likely to cause problems (due to unsigned overflow)
9295 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9297 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9299 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9301 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9303 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9305 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9307 GLYPH_CODE_FACE returns EMACS_INT, not int.
9308 * dispextern.h (merge_faces):
9309 * xfaces.c (merge_faces):
9310 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9311 Don't assume EMACS_INT fits in int.
9313 * character.h (CHAR_VALID_P): Remove unused parameter.
9314 * fontset.c, lisp.h, xdisp.c: All uses changed.
9316 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9318 * fns.c (concat): Minor tuning based on overflow analysis.
9319 This doesn't fix any bugs. Use int to hold character, instead
9320 of constantly refetching from Emacs object. Use XFASTINT, not
9321 XINT, for value known to be a character. Don't bother comparing
9322 a single byte to 0400, as it's always less.
9324 * floatfns.c (Fexpt):
9325 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9327 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9330 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9332 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9333 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9334 incorrectly succeed when S was a string, because 4294967386 was
9335 truncated before it was used.
9337 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9338 Otherwise, an out-of-range integer could cause undefined behavior
9341 * composite.c: Use int, not EMACS_INT, for characters.
9342 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9343 EMACS_INT, for values that are known to be in character range.
9344 This doesn't fix any bugs but is the usual style inside Emacs and
9345 may generate better code on 32-bit machines.
9347 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9348 This is for reasons similar to the recent CHAR_STRING fix.
9349 * charset.c (Fencode_char): Check that character arg is actually
9350 a character. Pass an int to ENCODE_CHAR.
9351 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9352 wider than 'int', as a compile-time check to prevent future regressions
9355 * character.c (char_string): Remove unnecessary casts.
9357 Make sure a 64-bit char is never passed to CHAR_STRING.
9358 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9359 by silently ignoring the top 32 bits, allowing some values
9360 that were far too large to be valid characters.
9361 * character.h: Include <verify.h>.
9362 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9363 arguments are no wider than unsigned, as a compile-time check
9364 to prevent future regressions in this area.
9366 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9367 (Fsubst_char_in_region):
9369 * xdisp.c (decode_mode_spec_coding):
9370 Adjust to CHAR_STRING's new requirement.
9371 * editfns.c (Finsert_char, Fsubst_char_in_region):
9372 * fns.c (concat): Check that character args are actually
9373 characters. Without this test, these functions did the wrong
9374 thing with wildly out-of-range values on 64-bit hosts.
9376 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9377 These casts should not be needed on 32-bit hosts, either.
9378 * keyboard.c (read_char):
9379 * lread.c (Fload): Remove casts to unsigned.
9381 * lisp.h (UNSIGNED_CMP): New macro.
9382 This fixes comparison bugs on 64-bit hosts.
9383 (ASCII_CHAR_P): Use it.
9384 * casefiddle.c (casify_object):
9385 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9386 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9387 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9388 * dispextern.h (FACE_FROM_ID):
9389 * keyboard.c (read_char): Use UNSIGNED_CMP.
9391 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9392 not to EMACS_INT, to avoid GCC warning.
9394 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9396 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9397 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9398 isn't needed on 32-bit machines.
9400 * buffer.c (Fgenerate_new_buffer_name):
9401 Use EMACS_INT for count, not int.
9402 (advance_to_char_boundary): Return EMACS_INT, not int.
9404 * data.c (Qcompiled_function): Now static.
9406 * window.c (window_body_lines): Now static.
9408 * image.c (gif_load): Rename local to avoid shadowing.
9410 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9411 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9412 * alloc.c (make_save_value): Integer argument is now of type
9414 (mark_object): Use ptrdiff_t, not int.
9415 * lisp.h (pD): New macro.
9416 * print.c (print_object): Use it.
9418 * alloc.c: Use EMACS_INT, not int, to count objects.
9419 (total_conses, total_markers, total_symbols, total_vector_size)
9420 (total_free_conses, total_free_markers, total_free_symbols)
9421 (total_free_floats, total_floats, total_free_intervals)
9422 (total_intervals, total_strings, total_free_strings):
9423 Now EMACS_INT, not int. All uses changed.
9424 (Fgarbage_collect): Compute overall total using a double, so that
9425 integer overflow is less likely to be a problem. Check for overflow
9426 when converting back to an integer.
9427 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9428 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9429 These were 'int' variables that could overflow on 64-bit hosts;
9430 they were never used, so remove them instead of repairing them.
9431 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9432 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9433 Previously, this ceilinged at INT_MAX, but that doesn't work on
9435 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9437 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9438 (allocate_vectorlike): Check for ptrdiff_t overflow.
9439 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9440 when a (possibly-narrower) signed value would do just as well.
9441 We prefer using signed arithmetic, to avoid comparison confusion.
9443 * alloc.c: Catch some string size overflows that we were missing.
9444 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9445 for convenience in STRING_BYTES_MAX.
9446 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9447 The definition here is exact; the one in lisp.h was approximate.
9448 (allocate_string_data): Check for string overflow. This catches
9449 some instances we weren't catching before. Also, it catches
9450 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9451 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9452 and ptrdiff_t and EMACS_INT are both 64 bits.
9454 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9455 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9456 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9458 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9460 * alloc.c (Fmake_string): Check for out-of-range init.
9462 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9464 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9466 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9468 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9469 xg_get_default_scrollbar_width.
9471 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9472 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9473 (style_changed_cb): Call update_theme_scrollbar_width and call
9474 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9475 all frames (Bug#8505).
9476 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9477 Call gtk_window_set_resizable if HAVE_GTK3.
9478 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9479 and height if HAVE_GTK3 (Bug#8505).
9480 (scroll_bar_width_for_theme): New variable.
9481 (update_theme_scrollbar_width): New function.
9482 (xg_get_default_scrollbar_width): Move code to
9483 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9484 (xg_initialize): Call update_theme_scrollbar_width.
9486 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9488 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9490 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9492 * frame.c (make_frame): Call other_buffer_safely instead of
9495 * window.c (temp_output_buffer_show): Call display_buffer with
9496 second argument Vtemp_buffer_show_specifiers and reset latter
9497 immediately after the call.
9498 (Vtemp_buffer_show_specifiers): New variable.
9499 (auto_window_vscroll_p, next_screen_context_lines)
9500 (Vscroll_preserve_screen_position): Remove leading asterisks from
9503 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9505 Fix minor problems found by GCC 4.6.0 static checking.
9506 * buffer.c (Qclone_number): Remove for now, as it's unused.
9507 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9508 (record_buffer): Remove unused local.
9509 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9510 (set_frame_buffer_list): Remove; unused.
9511 * frame.h (other_visible_frames): Remove decl.
9512 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9513 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9514 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9516 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9517 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9518 Define only if HAVE_GPM.
9519 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9520 (update_hints_inhibit): Remove; never set. All uses removed.
9521 * widgetprv.h (emacsFrameClassRec): Remove decl.
9522 * window.c (delete_deletable_window): Now returns void, since it
9523 wasn't returning anything.
9524 (compare_window_configurations): Remove unused locals.
9525 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9526 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9527 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9528 the same widths as pointers. This follows up on the 2011-05-06 patch.
9529 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9530 * xterm.h: Likewise.
9531 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9533 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9535 * makefile.w32-in: Update dependencies.
9536 (LISP_H): Add lib/intprops.h.
9538 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9540 * image.c (gif_load): Add animation frame delay to the metadata.
9541 (syms_of_image): Use DEFSYM. New symbol `delay'.
9543 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9545 * window.c (delete_deletable_window): Re-add.
9546 (Fset_window_configuration): Rewrite to handle dead buffers and
9547 consequently deletable windows.
9548 (window_tree, Fwindow_tree): Remove. Supply functionality in
9550 (compare_window_configurations): Simplify code.
9552 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9554 * image.c (imagemagick_load_image): Fix type mismatch.
9555 (Fimagemagick_types): Likewise.
9557 * window.h (replace_buffer_in_windows): Declare.
9559 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9561 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9562 Qclone_number. Remove external declaration of Qdelete_window.
9563 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9565 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9566 Run Qbuffer_list_update_hook if allowed.
9567 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9568 buffer list implementation.
9569 (other_buffer_safely): New function.
9570 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9571 calls to replace_buffer_in_windows and
9572 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9574 (record_buffer): Inhibit quitting and rewrite using quittable
9575 functions. Run Qbuffer_list_update_hook if allowed.
9576 (Frecord_buffer, Funrecord_buffer): New functions.
9577 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9578 Move switch-to-buffer to window.el.
9579 (bury-buffer): Move to window.el.
9580 (Vbuffer_list_update_hook): New variable.
9582 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9585 * window.h (resize_frame_windows): Move up in code.
9586 (Fwindow_frame): Remove EXFUN.
9587 (replace_buffer_in_all_windows): Remove prototype.
9588 (replace_buffer_in_windows_safely): Add prototype.
9590 * window.c: Declare Qdelete_window static again. Move down
9591 declaration of select_count.
9592 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9593 (Fother_window): Move to window.el.
9594 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9595 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9596 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9598 (replace_buffer_in_windows): Implement by calling
9599 Qreplace_buffer_in_windows.
9600 (replace_buffer_in_all_windows): Remove with some functionality
9601 moved into replace_buffer_in_windows_safely.
9602 (replace_buffer_in_windows_safely): New function.
9603 (select_window_norecord, select_frame_norecord): Move in front
9604 of run_window_configuration_change_hook. Remove now obsolete
9606 (Fset_window_buffer): Rewrite doc-string.
9607 Call Qrecord_window_buffer.
9608 (keys_of_window): Move binding for other-window to window.el.
9610 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9612 * dispextern.h (struct image): Replace data member, whose int_val
9613 and ptr_val fields were not used by anything, with a single
9616 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9617 (gif_clear_image, gif_load, imagemagick_load_image)
9618 (gs_clear_image, gs_load): Callers changed.
9620 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9622 * buffer.h: Include <time.h>, for time_t.
9623 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9625 Fix minor problems found by static checking.
9627 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9629 Make identifiers static if they are not used in other modules.
9630 * data.c (Qcompiled_function, Qframe, Qvector):
9631 * image.c (QimageMagick, Qsvg):
9632 * minibuf.c (Qmetadata):
9633 * window.c (resize_window_check, resize_root_window): Now static.
9634 * window.h (resize_window_check, resize_root_window): Remove decls.
9636 * window.c (window_deletion_count, delete_deletable_window):
9638 (window_body_lines): Now static.
9639 (Fdelete_other_windows_internal): Mark vars as initialized.
9640 Make sure 'resize_failed' is initialized.
9641 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9642 (resize_window_apply): Remove unused local.
9643 * window.h (delete_deletable_window): Remove decl.
9645 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9646 (imagemagick_load_image): Fix pointer signedness problem by changing
9647 last arg from unsigned char * to char *. All uses changed.
9648 Also, fix a local for similar reasons.
9649 Remove unused locals. Remove locals to avoid shadowing.
9650 (fn_rsvg_handle_free): Remove; unused.
9651 (svg_load, svg_load_image): Fix pointer signedness problem.
9652 (imagemagick_load_image): Don't use garbage pointer image_wand.
9654 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9656 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9658 * image.c (gif_load): Fix omitted cast error introduced by
9661 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9663 * window.h (resize_proportionally, orig_total_lines)
9664 (orig_top_line): Remove from window structure.
9665 (set_window_height, set_window_width, change_window_heights)
9666 (Fdelete_window): Remove prototypes.
9667 (resize_frame_windows): Remove duplicate declaration.
9669 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9671 * window.h (resize_frame_windows, resize_window_check)
9672 (delete_deletable_window, resize_root_window)
9673 (resize_frame_windows): Declare prototypes.
9675 * window.c (resize_window_apply): Make definition be "static" to
9676 match the prototype.
9678 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9680 * window.c: Remove declarations of Qwindow_size_fixed,
9681 window_min_size_1, window_min_size_2, window_min_size,
9682 size_window, window_fixed_size_p, enlarge_window, delete_window.
9683 Remove static from declaration of Qdelete_window, it's
9684 temporarily needed by Fbury_buffer.
9685 (replace_window): Don't assign orig_top_line and
9687 (Fdelete_window, delete_window): Remove. Window deletion is
9688 handled by window.el.
9689 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9690 Replace Fdelete_window calls with calls to Qdelete_window.
9691 (Fdelete_other_windows): Remove. Deleting other windows is
9692 handled by window.el.
9693 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9694 handled in window.el.
9695 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9696 Window minimum sizes are handled in window.el.
9697 (shrink_windows, size_window, set_window_height)
9698 (set_window_width, change_window_heights, window_height)
9699 (window_width, CURBEG, CURSIZE, enlarge_window)
9700 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9701 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9702 handled in window.el.
9703 (make_dummy_parent): Rename to make_parent_window and give it a
9704 second argument horflag.
9705 (make_window): Don't set resize_proportionally any more.
9706 (Fsplit_window): Remove. Windows are split in window.el.
9707 (save_restore_action, save_restore_orig_size)
9708 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9709 Resize mini windows in window.el.
9710 (grow_mini_window, shrink_mini_window): Implement by calling
9711 Qresize_root_window_vertically, resize_window_check and
9712 resize_window_apply.
9713 (saved_window, Fset_window_configuration, save_window_save):
9714 Do not handle orig_top_line, orig_total_lines, and
9715 resize_proportionally.
9716 (window_min_height, window_min_width): Move to window.el.
9717 (keys_of_window): Move bindings for delete-other-windows,
9718 split-window, delete-window and enlarge-window to window.el.
9720 * buffer.c: Temporarily extern Qdelete_window.
9721 (Fbury_buffer): Temporarily call Qdelete_window instead of
9722 Fdelete_window (Fbury_buffer will move to window.el soon).
9724 * frame.c (set_menu_bar_lines_1): Remove code handling
9725 orig_top_line and orig_total_lines.
9727 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9728 set_window_height but set heights directly.
9729 (change_frame_size_1): Use resize_frame_windows.
9731 * xdisp.c (init_xdisp): Don't use set_window_height but set
9734 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9735 Use resize_frame_windows instead of change_window_heights and run
9736 run_window_configuration_change_hook.
9738 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9739 instead of change_window_heights and run
9740 run_window_configuration_change_hook.
9742 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9744 * window.c (replace_window): Rename second argument REPLACEMENT to
9745 NEW. New third argument SETFLAG. Rewrite.
9746 (delete_window, make_dummy_parent): Call replace_window with
9748 (window_list_1): Move down in code.
9749 (run_window_configuration_change_hook): Move set_buffer part
9750 before select_frame_norecord part in order to unwind correctly.
9751 Rename count1 to count.
9752 (recombine_windows, delete_deletable_window, resize_root_window)
9753 (Fdelete_other_windows_internal)
9754 (Frun_window_configuration_change_hook, make_parent_window)
9755 (resize_window_check, resize_window_apply, Fresize_window_apply)
9756 (resize_frame_windows, Fsplit_window_internal)
9757 (Fdelete_window_internal, Fresize_mini_window_internal):
9759 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9761 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9763 * window.h (window): Add some new members to window structure -
9764 normal_lines, normal_cols, new_total, new_normal, clone_number,
9765 splits, nest, prev_buffers, next_buffers.
9766 (WINDOW_TOTAL_SIZE): Move here from window.c.
9767 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9769 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9771 (make_dummy_parent): Set new members of windows structure.
9772 (make_window): Move down in code. Handle new members of window
9774 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9775 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9776 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9777 (Fset_window_prev_buffers, Fwindow_next_buffers)
9778 (Fset_window_next_buffers, Fset_window_clone_number):
9780 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9781 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9783 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9784 Argument WINDOW can be now internal window too.
9785 (Fwindow_use_time): Move up in code.
9786 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9788 (Fset_window_configuration, saved_window)
9789 (Fcurrent_window_configuration, save_window_save): Handle new
9790 members of window structure.
9791 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9792 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9793 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9794 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9795 Qget_mru_window, Qresize_root_window,
9796 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9797 Qauto_buffer_name; staticpro them.
9799 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9801 * window.c (Fwindow_total_size, Fwindow_left_column)
9802 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9803 (Fwindow_list_1): New functions.
9804 (window_box_text_cols): Replace with window_body_cols.
9805 (Fwindow_width, Fscroll_left, Fscroll_right):
9806 Use window_body_cols instead of window_box_text_cols.
9807 (delete_window, Fset_window_configuration):
9808 Call delete_all_subwindows with window as argument.
9809 (delete_all_subwindows): Take a window as argument and not a
9811 (window_loop): Remove handling of GET_LRU_WINDOW and
9813 (Fget_lru_window, Fget_largest_window): Move to window.el.
9815 * window.h: Extern window_body_cols instead of
9816 window_box_text_cols. delete_all_subwindows now takes a
9817 Lisp_Object as argument.
9819 * indent.c (compute_motion, Fcompute_motion):
9820 Use window_body_cols instead of window_box_text_cols.
9822 * frame.c (delete_frame): Call delete_all_subwindows with root
9825 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9827 * fns.c (Fputhash): Document return value.
9829 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9831 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9833 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9835 Cons<->int and similar integer overflow fixes (Bug#8794).
9837 Check for overflow when converting integer to cons and back.
9838 * charset.c (Fdefine_charset_internal, Fdecode_char):
9839 Use cons_to_unsigned to catch overflow.
9840 (Fencode_char): Use INTEGER_TO_CONS.
9841 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9842 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9843 * data.c (long_to_cons, cons_to_long): Remove.
9844 (cons_to_unsigned, cons_to_signed): New functions.
9845 These signal an error for invalid or out-of-range values.
9846 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9847 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9848 * font.c (Ffont_variation_glyphs):
9849 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9850 * lisp.h: Include <intprops.h>.
9851 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9852 (cons_to_signed, cons_to_unsigned): New decls.
9853 (long_to_cons, cons_to_long): Remove decls.
9854 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9855 (Fprimitive_undo): Use CONS_TO_INTEGER.
9856 * xfns.c (Fx_window_property): Likewise.
9857 * xselect.c: Include <limits.h>.
9858 (x_own_selection, selection_data_to_lisp_data):
9859 Use INTEGER_TO_CONS.
9860 (x_handle_selection_request, x_handle_selection_clear)
9861 (x_get_foreign_selection, Fx_disown_selection_internal)
9862 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9863 (lisp_data_to_selection_data): Use cons_to_unsigned.
9864 (x_fill_property_data): Use cons_to_signed.
9865 Report values out of range.
9867 Check for buffer and string overflow more precisely.
9868 * buffer.h (BUF_BYTES_MAX): New macro.
9869 * lisp.h (STRING_BYTES_MAX): New macro.
9870 * alloc.c (Fmake_string):
9871 * character.c (string_escape_byte8):
9872 * coding.c (coding_alloc_by_realloc):
9873 * doprnt.c (doprnt):
9874 * editfns.c (Fformat):
9876 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9877 since they may not be the same number.
9878 * editfns.c (Finsert_char):
9879 * fileio.c (Finsert_file_contents):
9880 Likewise for BUF_BYTES_MAX.
9882 * image.c: Use ptrdiff_t, not int, for sizes.
9883 (slurp_file): Switch from int to ptrdiff_t.
9885 (slurp_file): Check that file size fits in both size_t (for
9886 malloc) and ptrdiff_t (for sanity and safety).
9888 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9889 if b->modtime has its maximal value.
9891 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9893 Don't assume time_t can fit into int.
9894 * buffer.h (struct buffer.modtime): Now time_t, not int.
9895 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9896 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9898 Minor fixes for signed vs unsigned integers.
9899 * character.h (MAYBE_UNIFY_CHAR):
9900 * charset.c (maybe_unify_char):
9901 * keyboard.c (read_char, reorder_modifiers):
9902 XINT -> XFASTINT, since the integer must be nonnegative.
9903 * ftfont.c (ftfont_spec_pattern):
9904 * keymap.c (access_keymap, silly_event_symbol_error):
9905 XUINT -> XFASTINT, since the integer must be nonnegative.
9906 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9907 since it makes no difference and we prefer signed.
9908 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9909 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9912 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9914 * window.h (Fwindow_frame): Declare.
9916 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9918 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9919 (SPARE_MEMORY): Always define.
9920 (LARGE_REQUEST): Remove.
9921 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9923 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9925 * lisp.h: Move EXFUNS for Fframe_root_window,
9926 Fframe_first_window and Fset_frame_selected_window to window.h.
9928 * window.h: Move EXFUNS for Fframe_root_window,
9929 Fframe_first_window and Fset_frame_selected_window here from
9932 * frame.c (Fwindow_frame, Fframe_first_window)
9933 (Fframe_root_window, Fframe_selected_window)
9934 (Fset_frame_selected_window): Move to window.c.
9935 (Factive_minibuffer_window): Move to minibuf.c.
9936 (Fother_visible_frames_p): New function.
9938 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9940 * window.c (decode_window, decode_any_window): Move up in code.
9941 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9942 (inhibit_frame_unsplittable): Remove unused variable.
9943 (Fwindow_buffer): Move up and rewrite doc-string.
9944 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9945 (Fwindow_prev): New functions.
9946 (Fwindow_frame): Move here from frame.c. Accept any window as
9948 (Fframe_root_window, Fframe_first_window)
9949 (Fframe_selected_window): Move here from frame.c. Accept frame
9950 or arbitrary window as argument. Update doc-strings.
9951 (Fminibuffer_window): Move up in code.
9952 (Fwindow_minibuffer_p): Move up in code and simplify.
9953 (Fset_frame_selected_window): Move here from frame.c.
9955 (Fselected_window, select_window, Fselect_window): Move up in
9956 code. Minor doc-string fixes.
9958 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9960 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9961 Do not assume that spare memory exists; that assumption is valid
9962 only if SYSTEM_MALLOC.
9963 (LARGE_REQUEST): New macro, so that the issue of large requests
9964 is separated from the issue of spare memory.
9966 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9968 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9971 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9973 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9976 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9978 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9980 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9982 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9983 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9985 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9987 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9989 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9991 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9992 (x_clipboard_manager_save): Add return value.
9993 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9995 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9996 Obey Vx_select_enable_clipboard_manager. Catch errors in
9997 x_clipboard_manager_save (Bug#8779).
9998 (Vx_select_enable_clipboard_manager): New variable.
9999 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10001 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10003 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10005 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10007 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10008 in the current matrix if keep_current_p is non-zero.
10010 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10012 * bidi.c (bidi_level_of_next_char): Fix last change.
10014 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10016 Support bidi reordering of text covered by display properties.
10018 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10019 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10020 (bidi_cache_search, bidi_cache_iterator_state)
10021 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10022 (bidi_level_of_next_char, bidi_move_to_visually_next):
10023 Support character positions inside a run of characters covered by a
10025 (bidi_paragraph_init, bidi_resolve_explicit_1)
10026 (bidi_level_of_next_char): Call bidi_fetch_char and
10027 bidi_fetch_char_advance instead of FETCH_CHAR and
10028 FETCH_CHAR_ADVANCE.
10029 (bidi_init_it): Initialize new members.
10030 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10032 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10033 instead of using explicit *_CHAR codes.
10034 (bidi_resolve_explicit, bidi_resolve_weak):
10035 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10036 bidirectional text is supported only in multibyte buffers.
10037 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10038 it to initialize the frame_window_p member of struct bidi_it.
10039 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10040 (bidi_resolve_explicit, bidi_resolve_weak)
10041 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10042 bidi_it->nchars is non-positive.
10043 (bidi_level_of_next_char): Don't try to lookup the cache for the
10044 next/previous character if nothing is cached there yet, or if we
10045 were just reseat()'ed to a new position.
10047 * xdisp.c (set_cursor_from_row): Set start and stop points
10048 according to the row's direction when priming the loop that looks
10049 for the glyph on which to display cursor.
10050 (single_display_spec_intangible_p): Function deleted.
10051 (display_prop_intangible_p): Reimplement to call
10052 handle_display_spec instead of single_display_spec_intangible_p.
10053 Accept 3 additional arguments needed by handle_display_spec.
10054 This fixes incorrect cursor motion across display property with complex
10055 values: lists, `(when COND...)' forms, etc.
10056 (single_display_spec_string_p): Support property values that are
10057 lists with the argument STRING its top-level element.
10058 (display_prop_string_p): Fix the condition for processing a
10059 property that is a list to be consistent with handle_display_spec.
10060 (handle_display_spec): New function, refactored from the
10061 last portion of handle_display_prop.
10062 (compute_display_string_pos): Accept additional argument
10063 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10064 value of a `display' property is a "replacing spec".
10065 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10066 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10067 the display property, but just return a value indicating whether
10068 the display property will replace the characters it covers.
10069 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10070 frame_window_p members of struct bidi_it.
10071 (compute_display_string_pos, compute_display_string_end):
10073 (push_it): Accept second argument POSITION, where pop_it should
10074 jump to continue iteration.
10075 (reseat_1): Initialize bidi_it.disp_pos.
10077 * keyboard.c (adjust_point_for_property): Adjust the call to
10078 display_prop_intangible_p to its new signature.
10080 * dispextern.h (struct bidi_it): New member frame_window_p.
10081 (bidi_init_it): Update prototypes.
10082 (display_prop_intangible_p): Update prototype.
10083 (compute_display_string_pos, compute_display_string_end):
10084 Declare prototypes.
10085 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10088 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10090 Malloc failure behavior now depends on size of allocation.
10091 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10092 * lisp.h: Change signatures accordingly.
10093 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10094 All callers changed. (Bug#8762)
10096 * gnutls.c: Use Emacs's memory allocators.
10097 Without this change, the gnutls library would invoke malloc etc.
10098 directly, which causes problems on non-SYNC_INPUT hosts, and which
10099 runs afoul of improving memory_full behavior. (Bug#8761)
10100 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10101 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10102 xfree instead of the default malloc, realloc, free.
10103 (Fgnutls_boot): No need to check for memory allocation failure,
10104 since xmalloc does that for us.
10106 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10107 * category.c (hash_get_category_set):
10108 * ccl.c (ccl_driver):
10109 * charset.c (Fdefine_charset_internal):
10110 * charset.h (struct charset.hash_index):
10111 * composite.c (get_composition_id, gstring_lookup_cache)
10112 (composition_gstring_put_cache):
10113 * composite.h (struct composition.hash_index):
10114 * dispextern.h (struct image.hash):
10115 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10116 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10117 (hashfn_equal, hashfn_user_defined, make_hash_table)
10118 (maybe_resize_hash_table, hash_lookup, hash_put)
10119 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10120 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10121 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10122 * image.c (make_image, search_image_cache, lookup_image)
10123 (xpm_put_color_table_h):
10124 * lisp.h (struct Lisp_Hash_Table):
10125 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10126 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10127 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10128 * alloc.c (allocate_vectorlike):
10129 Check for overflow in vector size calculations.
10130 * ccl.c (ccl_driver):
10131 Check for overflow when converting EMACS_INT to int.
10132 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10133 need to be updated by these changes.
10134 * fns.c (make_hash_table, maybe_resize_hash_table):
10135 Check for integer overflow with large hash tables.
10136 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10137 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10138 (SXHASH_REDUCE): New macro.
10139 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10140 Use it instead of discarding useful hash info with large hash values.
10141 (sxhash_float): New function.
10142 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10143 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10144 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10145 Rewrite to use FIXNUM_BITS, as this simplifies things.
10146 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10147 Adjust signatures to match updated version of code.
10148 (consing_since_gc): Now EMACS_INT, since a single hash table can
10149 use more than INT_MAX bytes.
10151 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10153 Make it possible to build with GCC-4.6+ -O2 -flto.
10155 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10157 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10159 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10160 Call minibuffer-inactive-mode.
10162 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10164 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10165 Update dependencies.
10167 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10169 * data.c (init_data): Remove code for UTS, this system is not
10172 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10174 Don't force ./temacs to start in terminal mode.
10176 * frame.c (make_initial_frame): Initialize faces in all cases, not
10177 only when CANNOT_DUMP is defined.
10178 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10180 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10182 * dispnew.c (add_window_display_history): Use const for the string
10183 pointer. Remove declaration, not needed.
10185 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10187 Use 'inline', not 'INLINE'.
10188 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10189 * alloc.c, fontset.c (INLINE): Remove.
10190 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10191 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10192 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10193 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10194 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10196 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10198 Make it possible to run ./temacs.
10200 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10201 syms_of_callproc does the same thing. Remove test for
10202 "initialized", do it in the caller.
10203 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10205 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10207 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10208 (read_minibuf): Use get_minibuffer.
10209 (syms_of_minibuf): Use DEFSYM.
10210 (Qmetadata): New var.
10211 * data.c (Qbuffer): Don't make it static.
10212 (syms_of_data): Use DEFSYM.
10214 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10216 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10217 (CCL_CODE_MIN): New macro.
10219 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10221 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10223 * eval.c (Qdebug): Now static.
10224 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10225 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10226 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10228 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10230 * image.c: Various fixes to ImageMagick code comments.
10231 (Fimagemagick_types): Doc fix.
10233 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10235 Minor fixes prompted by GCC 4.6.0 warnings.
10237 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10239 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10240 (x_clipboard_manager_save_all): Move extern decl to ...
10241 * xterm.h: ... here, so that it can be checked for consistency.
10243 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10245 * xselect.c (x_clipboard_manager_save_frame)
10246 (x_clipboard_manager_save_all): New functions.
10247 (Fx_clipboard_manager_save): Lisp function deleted.
10249 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10250 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10252 * xterm.h: Update prototype.
10254 2011-05-28 William Xu <william.xwl@gmail.com>
10256 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10257 exiting (Bug#8239).
10259 2011-05-28 Jim Meyering <meyering@redhat.com>
10261 Avoid a sign-extension bug in crypto_hash_function.
10262 * fns.c (to_uchar): Define.
10263 (crypto_hash_function): Use it to convert some newly-signed
10264 variables to unsigned, to avoid sign-extension bugs. For example,
10265 without this change, (md5 "truc") would evaluate to
10266 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10267 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10268 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10270 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10272 Integer overflow fixes.
10274 * dbusbind.c: Serial number integer overflow fixes.
10275 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10276 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10277 to hold a serial number that is too large for a fixnum.
10278 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10279 Check for serial numbers out of range. Decode any serial number
10280 that was so large that it became a float. (Bug#8722)
10282 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10283 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10284 Use XFASTINT rather than XUINT when numbers are nonnegative.
10285 (xd_append_arg, Fdbus_method_return_internal):
10286 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10287 arguments, check that Lisp number is nonnegative, rather than
10288 silently wrapping negative numbers around. (Bug#8722)
10289 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10292 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10294 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10296 ccl: Add integer overflow checks.
10297 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10298 (IN_INT_RANGE): New macros.
10299 (ccl_driver): Use them to check for integer overflow when
10300 decoding a CCL program. Many of the new checks are whether XINT (x)
10301 fits in int; it doesn't always, on 64-bit hosts. The new version
10302 doesn't catch all possible integer overflows, but it's an
10303 improvement. (Bug#8719)
10305 * alloc.c (make_event_array): Use XINT, not XUINT.
10306 There's no need for unsigned here.
10308 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10309 This follows up to the 2011-05-06 change that substituted uintptr_t
10310 for EMACS_INT. This case wasn't caught back then.
10312 Rework Fformat to avoid integer overflow issues.
10313 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10314 now (part of C89). Include <verify.h>.
10315 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10316 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10317 (Fformat): Avoid the prepass trying to compute sizes; it was only
10318 approximate and thus did not catch overflow reliably. Instead, walk
10319 through the format just once, formatting and computing sizes as we go,
10320 checking for integer overflow at every step, and allocating a larger
10321 buffer as needed. Keep track separately whether the format is
10322 multibyte. Keep only the most-recently calculated precision, rather
10323 than them all. Record whether each argument has been converted to
10324 string. Use EMACS_INT, not int, for byte and char and arg counts.
10325 Support field widths and precisions larger than INT_MAX. Avoid
10326 sprintf's undefined behavior with conversion specifications such as %#d
10327 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10328 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10329 formatting out-of-range floating point numbers with int
10330 formats. (Bug#8668)
10332 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10334 * data.c: Avoid integer truncation in expressions involving floats.
10335 * data.c: Include <intprops.h>.
10336 (arith_driver): When there's an integer overflow in an expression
10337 involving floating point, convert the integers to floating point
10338 so that the resulting value does not suffer from catastrophic
10339 integer truncation. For example, on a 64-bit host (* 4
10340 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10341 Do not rely on undefined behavior after integer overflow.
10343 merge count_size_as_multibyte, parse_str_to_multibyte
10344 * character.c, character.h (count_size_as_multibyte):
10345 Rename from parse_str_to_multibyte; all uses changed.
10346 Check for integer overflow.
10347 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10348 since it's now a duplicate of the other. This is more of
10349 a character than a buffer op, so better that it's in character.c.
10350 * fns.c, print.c: Adjust to above changes.
10352 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10354 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10356 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10358 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10359 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10360 (x_clipboard_manager_save): Now static.
10361 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10363 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10364 (crypto_hash_function): Now static.
10365 Fix pointer signedness problems. Avoid unnecessary initializations.
10367 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10369 * termhooks.h (Vselection_alist): Make it terminal-local.
10371 * terminal.c (create_terminal): Initialize it.
10373 * xselect.c: Support for clipboard managers.
10374 (Vselection_alist): Move to termhooks.h as terminal-local var.
10375 (LOCAL_SELECTION): New macro.
10376 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10377 (symbol_to_x_atom): Remove gratuitous arg.
10378 (x_handle_selection_request, lisp_data_to_selection_data)
10379 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10380 (x_own_selection, x_get_local_selection, x_convert_selection):
10381 New arg, specifying work frame. Use terminal-local Vselection_alist.
10382 (some_frame_on_display): Delete unused function.
10383 (Fx_own_selection_internal, Fx_get_selection_internal)
10384 (Fx_disown_selection_internal, Fx_selection_owner_p)
10385 (Fx_selection_exists_p): New optional frame arg.
10386 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10387 (x_handle_selection_clear): Don't treat other terminals with the
10388 same keyboard specially. Use the terminal-local Vselection_alist.
10389 (x_clear_frame_selections): Use Frun_hook_with_args.
10391 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10393 * xterm.h: Add support for those atoms.
10395 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10397 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10398 (converted_selections, conversion_fail_tag): New global variables.
10399 (x_selection_request_lisp_error): Free the above.
10400 (x_get_local_selection): Remove unnecessary code.
10401 (x_reply_selection_request): Args changed; handle arbitrary array
10402 of converted selections stored in converted_selections.
10403 Separate the XChangeProperty and SelectionNotify steps.
10404 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10405 (x_convert_selection): New function.
10406 (x_handle_selection_event): Simplify.
10407 (x_get_foreign_selection): Don't ignore incoming requests while
10408 waiting for an answer; this will fail when we implement
10409 SAVE_TARGETS, and seems unnecessary anyway.
10410 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10411 (Vx_sent_selection_functions): Doc fix.
10413 2011-05-26 Leo Liu <sdl.web@gmail.com>
10415 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10417 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10419 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10421 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10422 for fringe update if it has periodic bitmap.
10423 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10424 and fringe_bitmap_periodic_p.
10426 * fringe.c (get_fringe_bitmap_data): New function.
10427 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10428 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10429 row. Mark glyph row for fringe update if periodicity changed.
10431 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10432 for fringe update unless it has periodic bitmap.
10434 2011-05-25 Kenichi Handa <handa@m17n.org>
10436 * xdisp.c (get_next_display_element): Set correct it->face_id for
10437 a static composition.
10439 2011-05-24 Leo Liu <sdl.web@gmail.com>
10442 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10444 * fns.c (crypto_hash_function, Fsha1): New function.
10445 (Fmd5): Use crypto_hash_function.
10446 (syms_of_fns): Add Ssha1.
10448 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10450 * gnutls.c: Remove unused macros.
10451 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10452 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10453 Remove macros that are defined and never used.
10454 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10456 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10458 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10459 (Fx_get_selection_internal): Minor cleanup.
10460 (Fx_own_selection_internal): Rename arguments for consistency with
10463 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10465 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10467 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10469 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10471 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10473 * dispnew.c (scrolling_window): Don't exclude the case that the
10474 last enabled row in the desired matrix touches the bottom boundary.
10476 2011-05-21 Glenn Morris <rgm@gnu.org>
10478 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10479 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10480 and add some more files.
10482 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10484 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10485 report_file_error introduced by the change from 2011-05-07.
10487 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10489 * systime.h (Time): Define only if emacs is defined.
10490 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10491 where the include path doesn't have X11/X.h by default. See
10492 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10494 2011-05-20 Kenichi Handa <handa@m17n.org>
10496 * composite.c (find_automatic_composition): Fix previous change.
10498 2011-05-20 Glenn Morris <rgm@gnu.org>
10500 * lisp.mk: New file, split from Makefile.in.
10501 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10502 (shortlisp): Remove.
10503 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10505 2011-05-19 Glenn Morris <rgm@gnu.org>
10507 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10508 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10509 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10510 (lisp): Set the order to that of loadup.el.
10511 (shortlisp): Make it a copy of $lisp.
10512 (SOME_MACHINE_LISP): Remove.
10513 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10514 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10516 2011-05-18 Kenichi Handa <handa@m17n.org>
10518 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10519 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10520 (find_automatic_composition): Mostly rewrite for efficiency.
10522 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10524 * makefile.w32-in: Update dependencies.
10526 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10528 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10529 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10531 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10533 Fix some integer overflow issues, such as string length overflow.
10535 * insdel.c (count_size_as_multibyte): Check for string overflow.
10537 * character.c (lisp_string_width): Check for string overflow.
10538 Use EMACS_INT, not int, for string indexes and lengths; in
10539 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10540 the resulting string length overflows an EMACS_INT; instead,
10541 report a string overflow if no precision given. When checking for
10542 precision exhaustion, use a check that cannot possibly have
10543 integer overflow. (Bug#8675)
10544 * character.h (lisp_string_width): Adjust to new signature.
10546 * alloc.c (string_overflow): New function.
10547 (Fmake_string): Use it. This doesn't change behavior, but saves
10548 a few bytes and will simplify future changes.
10549 * character.c (string_escape_byte8): Likewise.
10550 * lisp.h (string_overflow): New decl.
10552 Fixups, following up to the user-interface timestamp change.
10553 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10554 for UI timestamps, instead of unsigned long.
10555 * msdos.c (mouse_get_pos): Likewise.
10556 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10557 * w32gui.h (Time): Define by including "systime.h" rather than by
10558 declaring it ourselves. (Bug#8664)
10560 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10561 * image.c (clear_image_cache): Likewise.
10563 * term.c (term_mouse_position): Don't assume time_t wraparound.
10565 Be more systematic about user-interface timestamps.
10566 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10567 and sometimes 'EMACS_UINT', to represent these timestamps.
10568 This change causes it to use 'Time' uniformly, as that's what X uses.
10569 This makes the code easier to follow, and makes it easier to catch
10570 integer overflow bugs such as Bug#8664.
10571 * frame.c (Fmouse_position, Fmouse_pixel_position):
10572 Use Time, not unsigned long, for user-interface timestamps.
10573 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10574 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10575 * keyboard.h (last_event_timestamp): Likewise.
10576 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10577 * menu.h (xmenu_show): Likewise.
10578 * term.c (term_mouse_position): Likewise.
10579 * termhooks.h (struct input_event.timestamp): Likewise.
10580 (struct terminal.mouse_position_hook): Likewise.
10581 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10582 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10583 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10584 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10585 what it was before.
10586 * menu.h, termhooks.h: Include "systime.h", for Time.
10588 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10589 Don't assume that the difference between two unsigned long values
10590 can fit into an integer. At this point, we know button_down_time
10591 <= event->timestamp, so the difference must be nonnegative, so
10592 there's no need to cast the result if double-click-time is
10593 nonnegative, as it should be; check that it's nonnegative, just in
10594 case. This bug is triggered when events are more than 2**31 ms
10595 apart (about 25 days). (Bug#8664)
10597 * xselect.c (last_event_timestamp): Remove duplicate decl.
10598 (x_own_selection): Remove needless cast to unsigned long.
10600 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10601 that always fit in int. Use a sentinel instead of a counter, to
10602 avoid a temp and to allay GCC's concerns about possible int overflow.
10603 * frame.h (struct frame): Use int for menu_bar_items_used
10604 instead of EMACS_INT, since it always fits in int.
10606 * menu.c (grow_menu_items): Check for int overflow.
10608 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10610 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10611 Before, the code was not consistent. These values cannot exceed
10612 2**31 - 1 so there's no need to make them unsigned.
10613 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10614 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10615 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10617 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10619 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10620 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10621 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10622 presumably because the widths might not match.
10624 * window.c (size_window): Avoid needless test at loop start.
10626 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10628 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10630 2011-05-12 Drew Adams <drew.adams@oracle.com>
10632 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10634 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10636 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10637 `width' to `bar_area_x' and `bar_area_width', respectively.
10638 (x_scroll_run): Take account of fringe background extension.
10640 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10641 Rename local vars `left' and `width' to `bar_area_x' and
10642 `bar_area_width', respectively.
10643 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10644 background extension.
10646 2011-05-10 Jim Meyering <meyering@redhat.com>
10648 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10650 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10652 * image.c (Finit_image_library): Return t for built-in image types,
10653 like pbm and xbm. (Bug#8640)
10655 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10657 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10659 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10661 * w32console.c (Fset_screen_color): Doc fix.
10662 (Fget_screen_color): New function.
10663 (syms_of_ntterm): Defsubr it.
10665 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10666 unlink the temporary file if Fcall_process didn't create it in the
10668 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10669 child process will be redirected to a file specified with `:file'.
10670 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10671 cue to call_process_cleanup not to close that handle.
10673 2011-05-07 Ben Key <bkey76@gmail.com>
10675 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10676 one of two shell specific rules, either bootstrap-temacs-CMD or
10677 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10678 to the previous implementation of the bootstrap-temacs rule.
10679 The bootstrap-temacs-CMD rule is similar to the previous
10680 implementation of the bootstrap-temacs rule except that it
10681 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10684 These changes, along with some changes to nt/configure.bat,
10685 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10686 earlier fix to add support for --cflags and --ldflags options
10687 that include quotes so that it works whether make uses cmd or
10690 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10692 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10693 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10695 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10696 a string. Handle both cases.
10697 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10698 (Fdbus_register_method): Use Qinvalid_function.
10700 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10702 * makefile.w32-in: Update dependencies.
10703 (LISP_H): Add inttypes.h and stdin.h.
10704 (PROCESS_H): Add unistd.h.
10706 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10708 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10709 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10711 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10713 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10715 * term.c (vfatal): Remove stray call to va_end.
10716 It's not needed and the C Standard doesn't allow it here anyway.
10718 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10719 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10721 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10724 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10726 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10728 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10730 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10732 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10734 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10735 * charset.c (Fdefine_charset_internal): Don't initialize
10736 charset.code_space[15]. The value was garbage, on hosts with
10737 32-bit int (Bug#8600).
10739 * lread.c (read_integer): Be more consistent with string-to-number.
10740 Use string_to_number to do the actual conversion; this avoids
10741 rounding errors and fixes some other screwups. Without this fix,
10742 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10743 (digit_to_number): Move earlier, for benefit of read_integer.
10744 Return -1 if the digit is out of range for the base, -2 if it is
10745 not a digit in any supported base. (Bug#8602)
10747 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10749 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10750 to match comment at start of function. This also removes a
10751 GCC warning about overflow in a 32+64-bit port.
10753 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10755 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10756 Reported by Stefan Monnier in
10757 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10758 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10759 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10761 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10762 (EMACS_UINTPTR): Likewise, with uintptr_t.
10764 * lisp.h: Prefer 64-bit EMACS_INT if available.
10765 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10766 on 32-bit hosts that have 64-bit int, so that they can access
10768 However, temporarily disable this change unless the temporary
10769 symbol WIDE_EMACS_INT is defined.
10771 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10773 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10774 This removes an assumption that EMACS_INT and long are the same
10775 width as pointers. The assumption is true for Emacs porting targets
10776 now, but we want to make other targets possible.
10777 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10778 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10779 In the rest of the code, change types of integers that hold casted
10780 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10781 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10782 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10783 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10784 No need to cast type when ORing.
10785 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10786 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10787 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10788 assume EMACS_INT is the same width as char *.
10789 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10790 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10791 Remove no-longer-needed casts.
10792 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10793 (xg_tool_bar_help_callback, xg_make_tool_item):
10794 Use EMACS_INTPTR to hold an integer
10795 that will be cast to void *; this can avoid a GCC warning
10796 if EMACS_INT is not the same width as void *.
10797 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10798 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10799 (current_message_1, set_message_1):
10800 Use a local to convert to proper width without a cast.
10801 * xmenu.c (dialog_selection_callback): Likewise.
10803 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10804 Also, don't assume VALBITS / RAND_BITS is less than 5,
10805 and don't rely on undefined behavior when shifting a 1 left into
10807 * lisp.h (get_random): Change signature to match.
10809 * lread.c (hash_string): Use size_t, not int, for hash computation.
10810 Normally we prefer signed values; but hashing is special, because
10811 it's better to use unsigned division on hash table sizes so that
10812 the remainder is nonnegative. Also, size_t is the natural width
10813 for hashing into memory. The previous code used 'int', which doesn't
10814 retain enough info to hash well into very large tables.
10815 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10817 * dbusbind.c: Don't possibly lose pointer info when converting.
10818 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10819 Use XPNTR rather than XHASH, so that the high-order bits of
10820 the pointer aren't lost when converting through void *.
10822 * eval.c (Fautoload): Don't double-shift a pointer.
10824 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10826 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10828 * gnutls.c (DEF_GNUTLS_FN):
10829 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10831 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10833 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10836 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10838 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10839 New version that can reserve upto 2GB of heap space.
10841 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10843 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10845 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10847 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10848 `gnutls_certificate_set_x509_key_file'.
10850 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10852 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10853 Update dependencies.
10855 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10857 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10858 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10859 Remove unused parameter `fildes'.
10860 * process.c (read_process_output, send_process): Don't pass it.
10862 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10864 Fix previous change: the library cache is defined in w32.c.
10865 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10866 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10868 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10870 Implement dynamic loading of GnuTLS on Windows.
10872 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10873 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10874 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10877 * gnutls.c (Qgnutls_dll): Define.
10878 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10879 (gnutls_*): Declare function pointers.
10880 (init_gnutls_functions): New function to initialize function pointers.
10881 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10882 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10883 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10884 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10885 (emacs_gnutls_write, emacs_gnutls_read)
10886 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10887 (Fgnutls_available_p): New function.
10888 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10889 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10890 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10892 * image.c: Include w32.h.
10893 (Vimage_type_cache): Delete.
10894 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10895 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10896 (w32_delayed_load): Move to w32.c.
10898 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10900 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10901 (w32_delayed_load): Move from image.c. When loading a library, record
10902 its filename in the :loaded-from property of the library id.
10903 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10904 Initialize and staticpro them.
10905 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10907 * process.c: Include lisp.h before w32.h, not after.
10908 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10909 instead of gnutls_record_check_pending.
10911 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10913 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10915 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10916 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10919 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10921 * xterm.c (x_set_frame_alpha): Do not set property on anything
10922 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10924 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10926 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10928 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10930 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10931 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10932 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10933 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10934 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10935 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10936 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10937 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10938 (Qgnutls_bootprop_callbacks_verify): Make static.
10940 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10942 * callproc.c: Indentation fixup.
10944 * sysdep.c (wait_for_termination_1): Make static.
10945 (wait_for_termination, interruptible_wait_for_termination):
10946 Move after wait_for_termination_1.
10948 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10950 * sysdep.c (interruptible_wait_for_termination): New function
10951 which is like wait_for_termination, but allows keyboard
10954 * callproc.c (Fcall_process): Add (:file "file") as an option for
10956 (Fcall_process_region): Ditto.
10958 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10960 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10961 rather than `XVECTOR (FOO)->size'.
10963 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10964 inttypes.h, as a gnulib replacement is used if it not available in
10967 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10969 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10970 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10971 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10973 * coding.c (coding_alloc_by_realloc): Error out if destination
10974 will grow beyond MOST_POSITIVE_FIXNUM.
10975 (decode_coding_emacs_mule): Abort if there isn't enough place in
10976 charbuf for the composition carryover bytes. Reserve an extra
10977 space for up to 2 characters produced in a loop.
10978 (decode_coding_iso_2022): Abort if there isn't enough place in
10979 charbuf for the composition carryover bytes.
10981 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10983 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10984 aborting when %lld or %lll format is passed.
10985 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10986 %llo or %llx format is passed. (Bug#8545)
10988 * window.c (window_scroll_line_based): Use a marker instead of
10989 simple variables to record original value of point. (Bug#7952)
10991 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10992 produced by %s or %c overflows available buffer space. (Bug#8545)
10994 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10996 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10997 (SIZE_MAX): Move defn after all includes, as they might #define it.
10999 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11001 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11003 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11005 * keyboard.c (Qdelayed_warnings_hook): Define.
11006 (command_loop_1): Run `delayed-warnings-hook'
11007 if Vdelayed_warnings_list is non-nil.
11008 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11009 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11011 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11013 * doprnt.c (doprnt): Don't return value smaller than the buffer
11014 size if the message was truncated. (Bug#8545).
11016 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11018 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11019 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11021 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11023 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11025 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11027 * makefile.w32-in: Update dependencies.
11029 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11031 Improve `doprnt' and its usage. (Bug#8545)
11032 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11033 `format_end'. Remove support for %l as a conversion specifier.
11034 Don't use xrealloc. Improve diagnostics when the %l size modifier
11035 is used. Update the commentary.
11037 * eval.c (verror): Simplify calculation of size_t.
11039 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11042 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11044 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11047 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11049 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11050 This makes this file independent of the recent pseudovector change.
11052 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11054 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11056 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11057 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11058 Remove unused local.
11059 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11061 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11062 GCC 4.6.0 optimizes based on type-based alias analysis.
11063 For example, if b is of type struct buffer * and v of type struct
11064 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11065 != &v->size, and therefore "v->size = 1; b->size = 2; return
11066 v->size;" must therefore return 1. This assumption is incorrect
11067 for Emacs, since it type-puns struct Lisp_Vector * with many other
11068 types. To fix this problem, this patch adds a new type struct
11069 vectorlike_header that documents the constraints on layout of vectors
11070 and pseudovectors, and helps optimizing compilers not get fooled
11071 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11072 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11073 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11075 (XSETPVECTYPE): Rewrite in terms of new macro.
11076 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11077 This is a bit clearer, and further avoids the possibility of
11078 undesirable aliasing.
11079 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11080 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11081 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11082 since Lisp_Subr is a special case (no "next" field).
11083 (ASIZE): Now uses header.size rather than size.
11084 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11085 to avoid the hassle of writing XVECTOR (foo)->header.size.
11086 (struct vectorlike_header): New type.
11087 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11088 object, to help avoid aliasing.
11089 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11090 (SUBRP): Likewise, since Lisp_Subr is a special case.
11091 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11092 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11093 (struct Lisp_Hash_Table): Combine first two members into a single
11094 struct vectorlike_header member. All uses of "size" and "next" members
11095 changed to be "header.size" and "header.next".
11096 * buffer.h (struct buffer): Likewise.
11097 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11098 * frame.h (struct frame): Likewise.
11099 * process.h (struct Lisp_Process): Likewise.
11100 * termhooks.h (struct terminal): Likewise.
11101 * window.c (struct save_window_data, struct saved_window): Likewise.
11102 * window.h (struct window): Likewise.
11103 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11104 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11105 * buffer.c (init_buffer_once): Likewise.
11106 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11108 * process.c (Fformat_network_address): Use local var for size,
11111 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11113 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11114 * data.c (atof): Remove decl; no longer used or needed.
11115 (digit_to_number): Move to lread.c.
11116 (Fstring_to_number): Use new string_to_number function, to be
11117 consistent with how the Lisp reader treats infinities and NaNs.
11118 Do not assume that floating-point numbers represent EMACS_INT
11119 without losing information; this is not true on most 64-bit hosts.
11120 Avoid double-rounding errors, by insisting on integers when
11121 parsing non-base-10 numbers, as the documentation specifies.
11122 * lisp.h (string_to_number): New decl, replacing ...
11123 (isfloat_string): Remove.
11124 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11125 (read1): Do not accept +. and -. as integers; this
11126 appears to have been a coding error. Similarly, do not accept
11127 strings like +-1e0 as floating point numbers. Do not report
11128 overflow for integer overflows unless the base is not 10 which
11129 means we have no simple and reliable way to continue.
11130 Break out the floating-point parsing into a new
11131 function string_to_number, so that Fstring_to_number parses
11132 floating point numbers consistently with the Lisp reader.
11133 (digit_to_number): Move here from data.c. Make it static inline.
11134 (E_CHAR, EXP_INT): Remove, replacing with ...
11135 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11136 (string_to_number): New function, replacing isfloat_string.
11137 This function checks for valid syntax and produces the resulting
11138 Lisp float number too. Rework it so that string-to-number
11139 no longer mishandles examples like "1.0e+". Use strtoumax,
11140 so that overflow for non-base-10 numbers is reported only when
11141 there's no portable and simple way to convert to floating point.
11143 * textprop.c (set_text_properties_1): Rewrite for clarity,
11144 and to avoid GCC warning about integer overflow.
11146 * intervals.h (struct interval): Use EMACS_INT for members
11147 where EMACS_UINT might cause problems. See
11148 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11149 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11150 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11152 (offset_intervals): Tell GCC not to worry about length overflow
11153 when negating a negative length.
11155 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11156 (overrun_check_free): Likewise.
11158 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11159 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11162 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11163 (gnutls_make_error): Rename local to avoid shadowing.
11164 (gnutls_emacs_global_deinit): ifdef out; not used.
11165 (Fgnutls_boot): Use const for pointer to readonly storage.
11166 Comment out unused local. Fix pointer signedness problems.
11168 * lread.c (openp): Don't stuff size_t into an 'int'.
11169 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11170 about possible signed overflow.
11172 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11173 (GDK_KEY_g): Don't define if already defined.
11174 (xg_prepare_tooltip): Avoid pointer signedness problem.
11175 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11177 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11178 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11180 * xfns.c (Fx_window_property): Simplify a bit,
11181 to make a bit faster and to avoid GCC 4.6.0 warning.
11182 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11184 * fns.c (internal_equal): Don't assume size_t fits in int.
11186 * alloc.c (compact_small_strings): Tighten assertion a little.
11188 Replace pEd with more-general pI, and fix some printf arg casts.
11189 * lisp.h (pI): New macro, generalizing old pEd macro to other
11190 conversion specifiers. For example, use "...%"pI"d..." rather
11191 than "...%"pEd"...".
11192 (pEd): Remove. All uses replaced with similar uses of pI.
11193 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11194 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11195 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11196 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11197 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11198 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11199 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11201 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11202 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11203 * print.c (safe_debug_print, print_object): Likewise.
11204 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11206 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11207 avoiding the 0 flag, which is not portable.
11208 * process.c (Fmake_network_process): Use pI to avoid cast.
11209 * region-cache.c (pp_cache): Likewise.
11210 * xdisp.c (decode_mode_spec): Likewise.
11211 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11212 behavior on 64-bit hosts with printf arg.
11213 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11214 (x_stop_queuing_selection_requests): Likewise.
11215 (x_get_window_property): Don't truncate byte count to an 'int'
11218 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11219 here, since it parses constructs like leading '-' and spaces,
11220 which are not wanted; and it overflows with large numbers.
11221 Instead, simply match F[0-9]+, which is what is wanted anyway.
11223 * alloc.c: Remove unportable assumptions about struct layout.
11224 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11225 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11226 (allocate_vectorlike, make_pure_vector): Use the new macros,
11227 plus offsetof, to remove unportable assumptions about struct layout.
11228 These assumptions hold on all porting targets that I know of, but
11229 they are not guaranteed, they're easy to remove, and removing them
11230 makes further changes easier.
11232 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11233 This doesn't fix a bug but makes the code clearer.
11234 (string_overrun_cookie): Now const. Use initializers that
11235 don't formally overflow signed char, to avoid warnings.
11236 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11237 can cause Emacs to crash when string overrun checking is enabled.
11238 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11239 multiple of sizeof (EMACS_INT); it need not be, if
11240 alignof(EMACS_INT) < sizeof (EMACS_INT).
11241 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11243 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11245 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11247 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11249 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11250 supposed to be handshaking. (Bug#8556)
11251 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11253 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11255 * lisp.h (Qdebug): List symbol.
11256 * eval.c (Qdebug): Restore global linkage.
11257 * keyboard.c (debug-on-event): New variable.
11258 (handle_user_signal): Break into debugger when debug-on-event
11259 matches the current signal symbol.
11261 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11263 * alloc.c (check_sblock, check_string_bytes)
11264 (check_string_free_list): Convert to standard C.
11266 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11268 * w32.c (emacs_gnutls_push): Fix typo.
11270 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11272 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11273 "cast to pointer from integer of different size".
11275 Improve doprnt and its use in verror. (Bug#8545)
11276 * doprnt.c (doprnt): Document the set of format control sequences
11277 supported by the function. Use SAFE_ALLOCA instead of always
11280 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11281 is one byte too soon. Don't use xrealloc; instead xfree and
11284 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11286 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11289 * gnutls.c: Renamed global_initialized to
11290 gnutls_global_initialized. Added internals for the
11291 :verify-hostname-error, :verify-error, and :verify-flags
11292 parameters of `gnutls-boot' and documented those parameters in the
11293 docstring. Start callback support.
11294 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11295 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11296 on error. Return error code.
11297 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11298 (emacs_gnutls_read): Likewise.
11299 (Fgnutls_boot): Return handshake error code.
11300 (emacs_gnutls_handle_error): New function.
11301 (wsaerror_to_errno): Likewise.
11303 * w32.h (emacs_gnutls_pull): Add prototype.
11304 (emacs_gnutls_push): Likewise.
11306 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11307 (emacs_gnutls_push): Likewise.
11309 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11311 * process.c (wait_reading_process_output): Check if GnuTLS
11312 buffered some data internally if no FDs are set for TLS
11315 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11316 (LIBS): Link to USER_LIBS.
11317 ($(BLD)/gnutls.$(0)): New target.
11319 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11321 * xdisp.c (handle_single_display_spec): Rename the
11322 display_replaced_before_p argument into display_replaced_p, to
11323 make it consistent with the commentary. Fix typos in the
11326 * textprop.c (syms_of_textprop): Remove dead code.
11327 (copy_text_properties): Delete obsolete commentary about an
11328 interface that was deleted long ago. Fix typos in the description
11331 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11332 to changes in oldXMenu/XMenu.h from 2011-04-16.
11333 <menu_help_message, prev_menu_help_message>: Constify.
11334 (IT_menu_make_room): menu->help_text is now `const char **';
11337 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11338 to changes in oldXMenu/XMenu.h from 2011-04-16.
11339 (struct XMenu): Declare `help_text' `const char **'.
11341 * xfaces.c <Qunspecified>: Make extern again.
11343 * syntax.c: Include sys/types.h before including regex.h, as
11346 * doc.c (get_doc_string): Improve the format passed to `error'.
11348 * doprnt.c (doprnt): Improve commentary.
11350 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11352 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11355 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11356 changes in globals.h immediately force recompilation.
11357 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11358 $(CURDIR)/s/ms-w32.h.
11359 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11361 * character.c (Fchar_direction): Function deleted.
11362 (syms_of_character): Don't defsubr it.
11363 <char-direction-table>: Deleted.
11365 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11367 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11368 * doprnt.c: Include limits.h.
11369 (SIZE_MAX): New macro.
11370 (doprnt): Return a size_t value. 2nd arg is now size_t.
11371 Many local variables are now size_t instead of int or unsigned.
11372 Improve overflow protection. Support `l' modifier for integer
11373 conversions. Support %l conversion. Don't assume an EMACS_INT
11374 argument for integer conversions and for %c.
11376 * lisp.h (doprnt): Restore prototype.
11378 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11379 $(SRC)/character.h.
11381 * Makefile.in (base_obj): Add back doprnt.o.
11383 * deps.mk (doprnt.o): Add back prerequisites.
11384 (callint.o): Depend on character.h.
11386 * eval.c (internal_lisp_condition_case): Include the handler
11387 representation in the error message.
11388 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11389 when breaking from the loop.
11391 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11393 * callint.c (Fcall_interactively): When displaying error message
11394 about invalid control letter, pass the character's codepoint, not
11395 a pointer to its multibyte form. Improve display of the character
11396 in octal and display also its hex code.
11398 * character.c (char_string): Use %x to display the (unsigned)
11399 codepoint of an invalid character, to avoid displaying a bogus
11402 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11403 `error', not SYMBOL_NAME itself.
11405 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11406 character arguments to `error'.
11408 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11409 to `error' in error message about FINAL_CHAR argument. Make sure
11410 FINAL_CHAR is a character, and use %c when it is passed as
11411 argument to `error'.
11413 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11415 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11417 * w32.c: Include <time.h>.
11418 (sys_localtime): New function.
11420 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11422 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11424 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11426 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11428 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11429 zombies (Bug#8467).
11431 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11433 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11434 gl_state.e_property when gl_state.object is Qt.
11436 * insdel.c (make_gap_larger): Remove limitation of buffer size
11439 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11441 * xdisp.c (lookup_glyphless_char_display)
11442 (produce_glyphless_glyph): Handle cons cell entry in
11443 glyphless-char-display.
11444 (Vglyphless_char_display): Document it.
11446 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11447 glyphless-char-display.
11449 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11451 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11453 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11455 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11456 definition for no-X builds.
11458 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11460 Static checks with GCC 4.6.0 and non-default toolkits.
11462 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11464 * process.c (keyboard_bit_set): Define only if SIGIO.
11465 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11466 (send_process): Repair possible setjmp clobbering.
11468 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11470 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11472 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11474 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11475 Define only if needed.
11477 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11478 by pacifying GCC about it. Maybe it's time to retire it?
11479 * xfaces.c (USG, __TIMEVAL__): Likewise.
11481 * dispextern.h (struct redisplay_interface): Rename param
11482 to avoid shadowing.
11483 * termhooks.h (struct terminal): Likewise.
11484 * xterm.c (xembed_send_message): Likewise.
11486 * insdel.c (make_gap_smaller): Define only if
11487 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11489 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11492 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11493 so that we aren't warned about unused symbols.
11495 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11497 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11499 * xfns.c (x_real_positions): Mark locals as initialized.
11501 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11503 * xterm.c: Fix problems found by static analysis with other toolkits.
11504 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11505 (x_dispatch_event): Declare static if USE_GTK, and
11506 define if USE_GTK || USE_X_TOOLKIT.
11507 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11508 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11509 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11510 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11512 * xmenu.c (menu_help_callback): Pointer type fixes.
11513 Use const pointers when pointing at readonly data. Avoid pointer
11514 signedness clashes.
11515 (FALSE): Remove unused macro.
11516 (update_frame_menubar): Remove unused decl.
11518 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11520 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11521 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11522 (single_menu_item): Rename local to avoid shadowing.
11524 * keyboard.c (make_lispy_event): Remove unused local var.
11526 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11527 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11529 * bitmaps: Change bitmaps from unsigned char back to the X11
11530 compatible char. Avoid the old compiler warnings about
11531 out-of-range initializers by using, for example, '\xab' rather
11534 * xgselect.c (xgselect_initialize): Check vs interface
11535 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11537 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11539 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11540 to read-only memory.
11542 * fns.c (vector): Remove; this old hack is no longer needed.
11544 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11546 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11548 * xrdb.c (x_load_resources): Omit unused local.
11550 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11551 (x_window): Rename locals to avoid shadowing.
11552 (USG): Use the kludged USG macro, to pacify gcc.
11554 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11555 (x_term_init): Remove local to avoid shadowing.
11557 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11559 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11560 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11562 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11564 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11566 Fix regex.c, syntax.c and friends for buffers > 2GB.
11567 * syntax.h (struct gl_state_s): Declare character position members
11570 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11572 * textprop.c (verify_interval_modification, interval_of):
11573 Declare arguments EMACS_INT.
11575 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11578 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11580 * indent.c (Fvertical_motion): Local variable it_start is now
11583 * regex.c (re_match, re_match_2, re_match_2_internal)
11584 (bcmp_translate, regcomp, regexec, print_double_string)
11585 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11586 (re_compile_pattern, re_exec): Declare arguments and local
11587 variables `size_t' and `ssize_t' and return values `regoff_t', as
11589 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11590 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11591 <compile_stack_type>: `size' and `avail' are now `size_t'.
11593 * regex.h <regoff_t>: Use ssize_t, not int.
11594 (re_search, re_search_2, re_match, re_match_2): Arguments that
11595 specify buffer/string position and length are now ssize_t and
11596 size_t. Return type is regoff_t.
11598 2011-04-16 Ben Key <bkey76@gmail.com>
11600 * nsfont.m: Fixed bugs in ns_get_family and
11601 ns_descriptor_to_entity that were caused by using free to
11602 deallocate memory blocks that were allocated by xmalloc (via
11603 xstrdup). This caused Emacs to crash when compiled with
11604 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11605 --enable-checking=xmallocoverrun). xfree is now used to
11606 deallocate these memory blocks.
11608 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11610 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11612 emacs_write: Accept and return EMACS_INT for sizes.
11613 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11615 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11616 Accept and return EMACS_INT.
11617 (emacs_gnutls_write): Return the number of bytes written on
11619 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11620 (emacs_read, emacs_write): Remove check for negative size, as the
11621 Emacs source code has been audited now.
11622 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11623 (emacs_read, emacs_write): Use it.
11624 * process.c (send_process): Adjust to the new signatures of
11625 emacs_write and emacs_gnutls_write. Do not attempt to store
11626 a byte offset into an 'int'; it might overflow.
11627 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11629 * sound.c: Don't assume sizes fit in 'int'.
11630 (struct sound_device.period_size, alsa_period_size):
11631 Return EMACS_INT, not int.
11632 (struct sound_device.write, vox_write, alsa_write):
11633 Accept EMACS_INT, not int.
11634 (wav_play, au_play): Use EMACS_INT to store sizes and to
11635 record read return values.
11637 2011-04-15 Ben Key <bkey76@gmail.com>
11639 * keyboard.c (Qundefined): Don't declare static since it is used
11641 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11642 static since they are used in nsfont.m.
11644 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11646 * process.c (Qprocessp): Don't declare static.
11647 * lisp.h (Qprocessp): Declare again.
11649 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11651 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11653 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11655 Improve C-level modularity by making more things 'static'.
11657 Don't publish debugger-only interfaces to other modules.
11658 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11659 (verify_bytepos, count_markers): Move decls to the only modules
11661 * region-cache.h (pp_cache): Likewise.
11662 * window.h (check_all_windows): Likewise.
11663 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11665 * sysdep.c (croak): Now static, if
11666 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11667 * syssignal.h (croak): Declare only if not static.
11669 * alloc.c (refill_memory_reserve): Now static if
11670 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11671 * lisp.h (refill_memory_reserve): Declare only if not static.
11673 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11674 Define only if USE_LUCID.
11676 * xrdb.c (x_customization_string, x_rm_string): Now static.
11678 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11679 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11681 * xdisp.c (draw_row_with_mouse_face): Now static.
11682 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11684 * window.h (check_all_windows): Mark externally visible.
11686 * window.c (window_deletion_count): Now static.
11688 * undo.c: Make symbols static if they're not exported.
11689 (last_undo_buffer, last_boundary_position, pending_boundary):
11692 * textprop.c (interval_insert_behind_hooks): Now static.
11693 (interval_insert_in_front_hooks): Likewise.
11695 * term.c: Make symbols static if they're not exported.
11696 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11697 (max_frame_lines, tty_set_terminal_modes):
11698 (tty_reset_terminal_modes, tty_turn_off_highlight):
11699 (get_tty_terminal): Now static.
11700 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11701 * termhooks.h (term_mouse_moveto): Do not declare if
11702 HAVE_WINDOW_SYSTEM.
11703 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11704 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11706 * sysdep.c: Make symbols static if they're not exported.
11707 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11709 (sigprocmask_set, full_mask): Remove; unused.
11710 (wait_debugging): Mark as visible.
11711 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11712 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11714 * syntax.c (syntax_temp): Define only if !__GNUC__.
11716 * sound.c (current_sound_device, current_sound): Now static.
11718 * search.c (searchbufs, searchbuf_head): Now static.
11720 * scroll.c (scroll_cost): Remove; unused.
11721 * dispextern.h (scroll_cost): Remove decl.
11723 * region-cache.h (pp_cache): Mark as externally visible.
11725 * process.c: Make symbols static if they're not exported.
11726 (process_tick, update_tick, create_process, chan_process):
11727 (Vprocess_alist, proc_buffered_char, datagram_access):
11728 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11729 (deactivate_process): Mark defn as static, as well as decl.
11730 * lisp.h (create_process): Remove decl.
11731 * process.h (chan_process, Vprocess_alist): Remove decls.
11733 * print.c: Make symbols static if they're not exported.
11734 (print_depth, new_backquote_output, being_printed, print_buffer):
11735 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11736 (print_interval, print_number_index, initial_stderr_stream):
11738 * lisp.h (Fprinc): Remove decl.
11739 (debug_output_compilation_hack): Mark as externally visible.
11741 * sysdep.c (croak): Move decl from here to syssignal.h.
11742 * syssignal.h (croak): Put it here, so the API can be checked when
11743 'croak' is called from dissociate_if_controlling_tty.
11745 * minibuf.c: Make symbols static if they're not exported.
11746 (minibuf_save_list, choose_minibuf_frame): Now static.
11747 * lisp.h (choose_minibuf_frame): Remove decl.
11749 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11751 * lread.c: Make symbols static if they're not exported.
11752 (read_objects, initial_obarray, oblookup_last_bucket_number):
11754 (make_symbol): Remove; unused.
11755 * lisp.h (initial_obarray, make_symbol): Remove decls.
11757 * keyboard.c: Make symbols static if they're not exported.
11758 (single_kboard, recent_keys_index, total_keys, recent_keys):
11759 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11760 (this_single_command_key_start, echoing, last_auto_save):
11761 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11762 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11763 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11764 (Vlispy_mouse_stem, double_click_count):
11766 (force_auto_save_soon): Define only if SIGDANGER.
11767 (ignore_mouse_drag_p): Now static if
11768 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11769 (print_help): Remove; unused.
11770 (stop_character, last_timer_event): Mark as externally visible.
11771 * keyboard.h (ignore_mouse_drag_p): Declare only if
11772 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11773 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11774 * lisp.h (echoing): Remove decl.
11775 (force_auto_save_soon): Declare only if SIGDANGER.
11776 * xdisp.c (redisplay_window): Simplify code, to make it more
11777 obvious that ignore_mouse_drag_p is not accessed if !defined
11778 USE_GTK && !defined HAVE_NS.
11780 * intervals.c: Make symbols static if they're not exported.
11781 (merge_properties_sticky, merge_interval_right, delete_interval):
11783 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11785 * insdel.c: Make symbols static if they're not exported.
11786 However, leave prepare_to_modify_buffer alone. It's never
11787 called from outside this function, but that appears to be a bug.
11788 (combine_after_change_list, combine_after_change_buffer):
11789 (adjust_after_replace, signal_before_change): Now static.
11790 (adjust_after_replace_noundo): Remove; unused.
11791 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11792 (signal_before_change): Remove decls.
11794 * indent.c (val_compute_motion, val_vmotion): Now static.
11796 * image.c: Make symbols static if they're not exported.
11797 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11799 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11800 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11802 * fringe.c (standard_bitmaps): Now static.
11803 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11805 * frame.c: Make symbols static if they're not exported.
11806 (x_report_frame_params, make_terminal_frame): Now static.
11807 (get_frame_param): Now static, unless HAVE_NS.
11808 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11809 (x_get_resource_string): Remove; not used.
11810 * frame.h (make_terminal_frame, x_report_frame_params):
11811 (x_get_resource_string); Remove decls.
11812 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11813 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11815 * font.c, fontset.c: Make symbols static if they're not exported.
11816 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11817 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11818 * font.c (font_close_object): Now static.
11819 * font.h (font_close_object): Remove.
11820 * fontset.c (FONTSET_OBJLIST): Remove.
11821 (free_realized_fontset) #if-0 the body, which does nothing.
11822 (face_suitable_for_char_p): #if-0, as it's never called.
11823 * fontset.h (face_suitable_for_char_p): Remove decl.
11824 * xfaces.c (face_at_string_position):
11825 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11826 since 0 is always ASCII.
11828 * fns.c (weak_hash_tables): Now static.
11830 * fileio.c: Make symbols static if they're not exported.
11831 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11832 (Vwrite_region_annotation_buffers): Now static.
11834 * eval.c: Make symbols static if they're not exported.
11835 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11836 * lisp.h (backtrace_list): Remove decl.
11838 * emacs.c: Make symbols static if they're not exported.
11839 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11840 (fatal_error_code, fatal_error_signal_hook, standard_args):
11842 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11843 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11844 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11845 * lisp.h (fatal_error_signal_hook): Remove decl.
11846 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11848 * editfns.c: Move a (normally-unused) function to its only use.
11849 * editfns.c, lisp.h (get_operating_system_release): Remove.
11850 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11851 worth the hassle of breaking this out.
11853 * xterm.c: Make symbols static if they're not exported.
11854 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11855 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11856 (x_destroy_window, x_delete_display):
11858 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11859 (x_mouse_leave): Remove; unused.
11860 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11861 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11862 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11864 (x_mouse_leave): Declare only if WINDOWSNT.
11865 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11866 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11869 * ftxfont.c: Make symbols static if they're not exported.
11870 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11872 * font.h (ftxfont_driver): Likewise.
11874 * xfns.c: Make symbols static if they're not exported.
11875 (x_last_font_name, x_display_info_for_name):
11876 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11877 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11878 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11879 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11880 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11881 (last_show_tip_args): Now static.
11882 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11883 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11884 (x_screen_planes): Remove; unused.
11885 * dispextern.h (x_screen_planes): Remove decl.
11887 * dispnew.c: Make symbols static if they're not exported.
11888 * dispextern.h (redraw_garbaged_frames, scrolling):
11889 (increment_row_positions): Remove.
11890 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11891 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11893 (redraw_garbaged_frames): Remove; unused.
11895 * xfaces.c: Make symbols static if they're not exported.
11896 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11898 * xterm.h (defined_color): Remove decls.
11899 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11900 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11901 (menu_face_changed_default, defined_color, free_realized_face):
11902 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11903 (ascii_face_of_lisp_face): Remove; unused.
11905 * xdisp.c: Make symbols static if they're not exported.
11906 * dispextern.h (scratch_glyph_row, window_box_edges):
11907 (glyph_to_pixel_coords, set_cursor_from_row):
11908 (get_next_display_element, set_iterator_to_next):
11909 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11910 (show_mouse_face): Remove decls
11911 * frame.h (message_buf_print): Likewise.
11912 * lisp.h (pop_message, set_message, check_point_in_composition):
11914 * xterm.h (set_vertical_scroll_bar): Likewise.
11915 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11916 (message_buf_print, scratch_glyph_row, displayed_buffer):
11917 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11918 (get_next_display_element, show_mouse_face, window_box_edges):
11919 (frame_to_window_pixel_xy, check_point_in_composition):
11920 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11921 (glyph_to_pixel_coords): Remove; unused.
11923 * dired.c (file_name_completion): Now static.
11925 * dbusbind.c (xd_in_read_queued_messages): Now static.
11927 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11928 * data.c (circular_list_error): Remove.
11930 * commands.h (last_point_position, last_point_position_buffer):
11931 (last_point_position_window): Remove decls.
11932 * keyboard.c: Make these variables static.
11934 * coding.h (coding, code_convert_region, encode_coding_gap):
11936 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11937 (iso_code_class, detect_coding, code_convert_region): Now static.
11938 (encode_coding_gap): Remove; unused.
11940 * chartab.c (chartab_chars, chartab_bits): Now static.
11942 * charset.h (charset_iso_8859_1): Remove decl.
11943 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11946 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11947 * ccl.c (Vccl_program_table): Now static.
11948 (check_ccl_update): Remove; unused.
11950 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11951 * category.h: ... from here.
11952 * category.c (check_category_table, set_category_set): Now static.
11954 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11955 * lisp.h: Remove these decls.
11957 * buffer.c (buffer_count): Remove unused var.
11959 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11960 so that it's not optimized away.
11961 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11962 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11963 exported only to the debugger.
11965 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11966 * atimer.h (run_all_atimers): Remove; not exported.
11968 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11969 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11970 was inaccessible from Lisp.
11971 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11972 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11974 alloc.c: Import and export fewer symbols, and remove unused items.
11975 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11977 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11978 it's not optimized away by whole-program optimization.
11979 (message_enable_multibyte, free_misc): Remove.
11980 (catchlist, handlerlist, mark_backtrace):
11981 Declare only if BYTE_MARK_STACK.
11982 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11983 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11984 (message_enable_multibyte): Remove decl.
11985 (free_misc, interval_free_list, float_block, float_block_index):
11986 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11987 (cons_free_list, last_marked_index):
11989 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11990 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11991 (mark_backtrace): Define only if BYTE_MARK_STACK.
11992 * xdisp.c (message_enable_multibyte): Now static.
11994 Declare Lisp_Object Q* variables to be 'static' if not exported.
11995 This makes it easier for human readers (and static analyzers)
11996 to see whether these variables are used from other modules.
11997 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11998 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11999 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12000 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12001 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12002 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12003 * xmenu.c, xselect.c:
12004 Declare Q* vars static if they are not used in other modules.
12005 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12006 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12007 Remove decls of unexported vars.
12008 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12010 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12012 Make Emacs functions such as Fatom 'static' by default.
12013 This makes it easier for human readers (and static analyzers)
12014 to see whether these functions can be called from other modules.
12015 DEFUN now defines a static function. To make the function external
12016 so that it can be used in other C modules, use the new macro DEFUE.
12017 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12018 (Finit_image_library):
12019 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12020 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12021 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12022 Remove decls, since these functions are now static.
12023 (Funintern, Fget_internal_run_time): New decls, since these functions
12024 were already external.
12026 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12027 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12028 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12029 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12030 * keyboard.c, keymap.c, lread.c:
12031 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12032 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12033 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12034 Mark functions with DEFUE instead of DEFUN,
12035 if they are used in other modules.
12036 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12037 decls for now-static functions.
12038 * buffer.h (Fdelete_overlay): Remove decl.
12039 * callproc.c (Fgetenv_internal): Mark as internal.
12040 * composite.c (Fremove_list_of_text_properties): Remove decl.
12041 (Fcomposition_get_gstring): New forward static decl.
12042 * composite.h (Fcomposite_get_gstring): Remove decl.
12043 * dired.c (Ffile_attributes): New forward static decl.
12044 * doc.c (Fdocumntation_property): New forward static decl.
12045 * eval.c (Ffetch_bytecode): New forward static decl.
12046 (Funintern): Remove extern decl; now in .h file where it belongs.
12047 * fileio.c (Fmake_symbolic_link): New forward static decl.
12048 * image.c (Finit_image_library): New forward static decl.
12049 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12050 * intervals.h (Fprevious_property_change):
12051 (Fremove_list_of_text_properties): Remove decls.
12052 * keyboard.c (Fthis_command_keys): Remove decl.
12053 (Fcommand_execute): New forward static decl.
12054 * keymap.c (Flookup_key): New forward static decl.
12055 (Fcopy_keymap): Now static.
12056 * keymap.h (Flookup_key): Remove decl.
12057 * process.c (Fget_process): New forward static decl.
12058 (Fprocess_datagram_address): Mark as internal.
12059 * syntax.c (Fsyntax_table_p): New forward static decl.
12060 (skip_chars): Remove duplicate decl.
12061 * textprop.c (Fprevious_property_change): New forward static decl.
12062 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12064 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12065 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12067 * editfns.c (Fformat): Remove unreachable code.
12069 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12071 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12074 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12076 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12077 when at ZV. (Bug#8487)
12079 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12081 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12083 * keyboard.c (parse_tool_bar_item): Likewise.
12084 * sound.c (sound_cleanup, alsa_close): Likewise.
12085 * termcap.c (tgetent): Likewise.
12086 * xfns.c (x_default_font_parameter): Likewise.
12087 * xsettings.c (read_and_apply_settings): Likewise.
12089 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12090 (overrun_check_free): Protoize.
12092 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12094 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12095 since callers should never pass a negative size.
12096 Change the signature to match that of plain 'read' and 'write'; see
12097 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12098 * lisp.h: Update prototypes of emacs_write and emacs_read.
12100 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12102 * xdisp.c (redisplay_window): Don't try to determine the character
12103 position of the scroll margin if the window start point w->startp
12104 is outside the buffer's accessible region. (Bug#8468)
12106 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12108 Fix write-region and its subroutines for buffers > 2GB.
12109 * fileio.c (a_write, e_write): Modify declaration of arguments and
12110 local variables to support buffers larger than 2GB.
12111 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12113 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12114 argument, local variables, and return value.
12116 * lisp.h: Update prototypes of emacs_write and emacs_read.
12118 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12120 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12122 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12124 Fix more problems found by GCC 4.6.0's static checks.
12126 * xdisp.c (vmessage): Use a better test for character truncation.
12128 * charset.c (load_charset_map): <, not <=, for optimization,
12129 and to avoid potential problems with integer overflow.
12130 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12131 * casetab.c (set_identity, shuffle): Likewise.
12132 * editfns.c (Fformat): Likewise.
12133 * syntax.c (skip_chars): Likewise.
12135 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12136 This also lets GCC 4.6.0 generate slightly better loop code.
12138 * callint.c (Fcall_interactively): <, not <=, for optimization.
12139 (Fcall_interactively): Count the number of arguments produced,
12140 not the number of arguments given. This is simpler and lets GCC
12141 4.6.0 generate slightly better code.
12143 * ftfont.c: Distingish more carefully between FcChar8 and char.
12144 The previous code passed unsigned char * to a functions like
12145 strlen and xstrcasecmp that expect char *, which does not
12146 conform to the C standard.
12147 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12148 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12149 char * when the C standard requires it.
12151 * keyboard.c (read_char): Remove unused var.
12153 * eval.c: Port to Windows vsnprintf (Bug#8435).
12154 Include <limits.h>.
12155 (SIZE_MAX): Define if the headers do not.
12156 (verror): Do not give up if vsnprintf returns a negative count.
12157 Instead, grow the buffer. This ports to Windows vsnprintf, which
12158 does not conform to C99. Problem reported by Eli Zaretskii.
12159 Also, simplify the allocation scheme, by avoiding the need for
12160 calling realloc, and removing the ALLOCATED variable.
12162 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12164 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12165 But keep the doprint source code for now, as we might revamp it
12166 and use it again (Bug#8435).
12167 * lisp.h (doprnt): Remove.
12168 * Makefile.in (base_obj): Remove doprnt.o.
12169 * deps.mk (doprnt.o): Remove.
12171 error: Print 32- and 64-bit integers portably (Bug#8435).
12172 Without this change, on typical 64-bit hosts error ("...%d...", N)
12173 was used to print both 32- and 64-bit integers N, which relied on
12174 undefined behavior.
12175 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12176 * lisp.h (error, verror): Mark as printf-like functions.
12177 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12178 Report overflow in size calculations when allocating printf buffer.
12179 Do not truncate output string at its first null byte.
12180 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12181 Truncate the output at a character boundary, since vsnprintf does not
12183 * charset.c (check_iso_charset_parameter): Convert internal
12184 character to string before calling 'error', since %c now has the
12186 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12187 overflow when computing char to be passed to 'error'. Do not
12188 pass Lisp_Object to 'error'; pass the integer instead.
12189 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12190 formatted with plain %d.
12192 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12194 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12196 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12198 * xterm.c (x_catch_errors): Remove duplicate declaration.
12200 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12202 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12204 2011-04-10 Jim Meyering <meyering@redhat.com>
12206 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12207 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12208 return ssize_t not "int", and use size_t as the buffer length.
12209 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12210 * gnutls.h: Update declarations.
12211 * process.c (read_process_output): Use ssize_t, to match.
12212 (send_process): Likewise.
12214 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12216 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12218 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12220 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12221 Use unsigned char, to match FcChar8 type definition.
12223 * xterm.c (handle_one_xevent):
12224 * xmenu.c (create_and_show_popup_menu):
12225 * xselect.c (x_decline_selection_request)
12226 (x_reply_selection_request): Avoid type-punned deref of X events.
12228 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12230 Fix some uses of `int' instead of EMACS_INT.
12231 * search.c (string_match_1, fast_string_match)
12232 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12233 (scan_buffer, find_next_newline_no_quit)
12234 (find_before_next_newline, search_command, Freplace_match)
12235 (Fmatch_data): Make some `int' variables be EMACS_INT.
12237 * xdisp.c (display_count_lines): 3rd argument and return value now
12238 EMACS_INT. All callers changed.
12239 (pint2hrstr): Last argument is now EMACS_INT.
12241 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12242 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12243 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12244 (decode_coding_utf_16, decode_coding_emacs_mule)
12245 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12246 (decode_coding_ccl, decode_coding_charset)
12247 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12248 (decode_coding_iso_2022, decode_coding_emacs_mule)
12249 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12250 <char_offset, last_offset>: Declare EMACS_INT.
12251 (encode_coding_utf_8, encode_coding_utf_16)
12252 (encode_coding_emacs_mule, encode_invocation_designation)
12253 (encode_designation_at_bol, encode_coding_iso_2022)
12254 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12255 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12257 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12258 (encode_invocation_designation): Last argument P_NCHARS is now
12260 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12261 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12263 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12266 * ccl.c (Fccl_execute_on_string): Declare some variables
12269 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12271 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12273 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12275 * process.c (Fformat_network_address): Doc fix.
12277 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12279 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12281 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12283 * keyboard.c (read_char): Call Lisp function help-form-show,
12284 instead of using internal_with_output_to_temp_buffer.
12285 (Qhelp_form_show): New var.
12286 (syms_of_keyboard): Use DEFSYM macro.
12288 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12290 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12292 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12294 * process.c (Flist_processes): Remove to Lisp.
12295 (list_processes_1): Delete.
12297 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12299 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12301 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12303 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12305 Fix more problems found by GCC 4.6.0's static checks.
12307 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12309 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12311 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12313 * xdisp.c (vmessage): Mark as a printf-like function.
12315 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12317 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12319 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12320 printf-like functions.
12321 (tiff_load): Add casts to remove these marks before passing them
12322 to system-supplied API.
12324 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12326 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12327 This avoids several warnings with gcc -Wstrict-overflow.
12328 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12329 directly, rather than having caller test rule sign. This avoids
12330 some unnecessary tests.
12331 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12332 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12333 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12335 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12336 (xfont_open): Avoid unnecessary tests.
12338 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12340 * composite.h, composite.c (composition_gstring_put_cache):
12341 Use EMACS_INT, not int, for length.
12343 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12344 breaking out part of COMPOSITION_DECODE_RULE.
12345 (COMPOSITION_DECODE_RULE): Use it.
12346 * composite.c (get_composition_id): Remove unused local vars,
12347 by using the new macro.
12349 * textprop.c (set_text_properties_1): Change while to do-while,
12350 since the condition is always true at first.
12352 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12353 (interval_deletion_adjustment): Return unsigned value.
12356 * process.c (list_processes_1, create_pty, read_process_output):
12357 (exec_sentinel): Remove vars that were set but not used.
12358 (create_pty): Remove unnecessary "volatile"s.
12359 (Fnetwork_interface_info): Avoid possibility of int overflow.
12360 (read_process_output): Do adaptive read buffering even if carryover.
12361 (read_process_output): Simplify nbytes computation if buffered.
12363 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12365 * syntax.c (scan_words): Remove var that was set but not used.
12366 (update_syntax_table): Use unsigned instead of int.
12368 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12369 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12370 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12372 * print.c (print_error_message): Avoid int overflow.
12374 * font.c (font_list_entities): Redo for clarity,
12375 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12377 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12378 (font_score): Avoid potential overflow in diff calculation.
12380 * fns.c (substring_both): Remove var that is set but not used.
12381 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12383 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12385 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12386 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12387 can always succeed if overflow has undefined behavior.
12389 * search.c (boyer_moore, wordify): Remove vars set but not used.
12390 (wordify): Omit three unnecessary tests.
12392 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12393 All callers changed. This avoids the need for an unused var.
12395 * casefiddle.c (casify_region): Remove var that is set but not used.
12397 * dired.c (file_name_completion): Remove var that is set but not used.
12399 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12401 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12402 (Finsert_file_contents): Remove unnecessary code checking fd.
12404 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12405 Check for integer overflow on size calculations.
12407 * buffer.c (Fprevious_overlay_change): Remove var that is set
12410 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12411 Remove vars that are set but not used.
12412 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12413 (timer_check_2): Mark vars as initialized.
12415 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12417 * image.c (lookup_image): Remove var that is set but not used.
12418 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12420 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12421 that are set but not used.
12423 * xfns.c (make_invisible_cursor): Don't return garbage
12424 if XCreateBitmapFromData fails (Bug#8410).
12426 * xselect.c (x_get_local_selection, x_handle_property_notify):
12427 Remove vars that are set but not used.
12429 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12430 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12432 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12433 Remove var that is set but not used.
12434 (scroll_bar_windows_size): Now size_t, not int.
12435 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12436 Check for overflow.
12438 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12439 (map_tty_color) [!defined MSDOS]: Likewise.
12441 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12443 * coding.c: Remove vars that are set but not used.
12444 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12445 All callers changed.
12446 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12447 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12448 (decode_coding_charset): Remove vars that are set but not used.
12450 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12451 that is set but not used.
12453 * print.c (print_object): Remove var that is set but not used.
12455 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12456 The gnulib version avoids calling malloc in the usual case,
12457 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12458 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12459 * filelock.c (current_lock_owner): Likewise.
12460 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12461 * sysdep.c: Include allocator.h, careadlinkat.h.
12462 (emacs_no_realloc_allocator): New static constant.
12463 (emacs_readlink): New function.
12464 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12465 ../lib/careadlinkat.h.
12467 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12469 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12470 first non-nil return value).
12472 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12474 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12475 if not defined (Bug#8403).
12477 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12479 * xdisp.c (display_count_lines): Remove parameter `start',
12480 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12481 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12482 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12483 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12484 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12485 and thereabouts. All callers changed.
12486 (get_per_char_metric): Remove parameter `f', unused since
12487 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12489 2011-04-02 Jim Meyering <meyering@redhat.com>
12491 do not dereference NULL upon failed strdup
12492 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12493 (ns_get_family): Likewise.
12495 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12497 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12499 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12501 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12504 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12506 Add lexical binding.
12508 * window.c (Ftemp_output_buffer_show): New fun.
12509 (Fsave_window_excursion):
12510 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12512 * lread.c (lisp_file_lexically_bound_p): New function.
12513 (Fload): Bind Qlexical_binding.
12514 (readevalloop): Remove `evalfun' arg.
12515 Bind Qinternal_interpreter_environment.
12516 (Feval_buffer): Bind Qlexical_binding.
12517 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12519 (syms_of_lread): Declare `lexical-binding'.
12521 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12523 * keyboard.c (eval_dyn): New fun.
12524 (menu_item_eval_property): Use it.
12526 * image.c (parse_image_spec): Use Ffunctionp.
12528 * fns.c (concat, mapcar1): Accept byte-code-functions.
12530 * eval.c (Fsetq): Handle lexical vars.
12531 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12532 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12533 (FletX, Flet): Obey lexical binding.
12534 (Fcommandp): Handle closures.
12535 (Feval): New `lexical' arg.
12536 (eval_sub): New function extracted from Feval. Use it almost
12537 everywhere where Feval was used. Look up vars in lexical env.
12539 (Ffunctionp): Move from subr.el.
12540 (Ffuncall): Handle closures.
12541 (apply_lambda): Remove `eval_flags'.
12542 (funcall_lambda): Handle closures and new byte-code-functions.
12543 (Fspecial_variable_p): New function.
12544 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12545 but without exporting it to Lisp.
12547 * doc.c (Fdocumentation, store_function_docstring):
12548 * data.c (Finteractive_form): Handle closures.
12550 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12553 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12555 (exec_byte_code): New function extracted from Fbyte_code to handle new
12556 calling convention for byte-code-functions. Add new byte-codes.
12558 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12560 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12562 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12564 * xdisp.c (redisplay_internal): Fix prototype.
12566 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12568 * xdisp.c (SCROLL_LIMIT): New macro.
12569 (try_scrolling): Use it when setting scroll_limit.
12570 Limit scrolling to 100 screen lines.
12571 (redisplay_window): Even when falling back on "recentering",
12572 position point in the window according to scroll-conservatively,
12573 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12575 (try_scrolling): When point is above the window, allow searching
12576 as far as scroll_max, or one screenful, to compute vertical
12577 distance from PT to the scroll margin position. This prevents
12578 try_scrolling from unnecessarily failing when
12579 scroll-conservatively is set to a value slightly larger than the
12580 window height. Clean up the case of PT below the margin at bottom
12581 of window: scroll_max can no longer be INT_MAX. When aggressive
12582 scrolling is in use, don't let point enter the opposite scroll
12583 margin as result of the scroll.
12584 (syms_of_xdisp) <scroll-conservatively>: Document the
12585 threshold of 100 lines for never-recentering scrolling.
12587 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12589 * dispextern.h (move_it_by_lines):
12590 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12591 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12592 (message_log_check_duplicate): Remove parameters `prev_bol' and
12593 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12594 (redisplay_internal): Remove parameter `preserve_echo_area',
12595 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12597 * indent.c (Fvertical_motion):
12598 * window.c (window_scroll_pixel_based, Frecenter):
12599 Don't pass `need_y_p' to `move_it_by_lines'.
12601 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12603 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12604 steal a few bits to be more compact.
12605 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12606 Remove unneeded casts.
12608 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12610 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12612 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12613 binding" message (bug#7967).
12615 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12617 Fix more problems found by GCC 4.6.0's static checks.
12619 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12620 Remove unused local var.
12622 * editfns.c (Fmessage_box): Remove unused local var.
12624 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12625 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12626 Omit unused local vars.
12627 * window.c (shrink_windows): Omit unused local var.
12628 * menu.c (digest_single_submenu): Omit unused local var.
12629 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12630 Omit unused local var.
12632 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12633 Don't assume string length fits in int.
12634 (keyremap_step, read_key_sequence): Use size_t for sizes.
12635 (read_key_sequence): Don't check last_real_key_start redundantly.
12637 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12638 instead of alloca (Bug#8344).
12640 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12641 (Fbacktrace_frame): Don't assume nframes fits in int.
12643 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12645 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12648 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12650 * cm.c (calccost): Turn while-do into do-while, for clarity.
12652 * keyboard.c (syms_of_keyboard): Use the same style as later
12653 in this function when indexing through an array. This also
12654 works around GCC bug 48267.
12656 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12658 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12660 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12661 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12663 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12664 This avoids undefined behavior on integer overflow, and is a bit
12665 more convenient anyway since it is compared to a size_t variable.
12667 Variadic C functions now count arguments with size_t, not int.
12668 This avoids an unnecessary limitation on 64-bit machines, which
12669 caused (substring ...) to crash on large vectors (Bug#8344).
12670 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12671 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12672 All variadic functions and their callers changed accordingly.
12673 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12674 * data.c (arith_driver, float_arith_driver): Likewise.
12675 * editfns.c (general_insert_function): Likewise.
12676 * eval.c (struct backtrace.nargs, interactive_p)
12677 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12678 (funcall_lambda, mark_backtrace): Likewise.
12679 * fns.c (concat): Likewise.
12680 * frame.c (x_set_frame_parameters): Likewise.
12681 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12682 0 if not found, not -1. All callers changed.
12684 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12685 (stack_copy_size): Now size_t, not int.
12686 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12688 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12690 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12691 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12692 All callers changed.
12694 * lisp.h (multibyte_char_to_unibyte):
12695 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12696 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12697 * character.h (CHAR_TO_BYTE8):
12698 * cmds.c (internal_self_insert):
12699 * editfns.c (general_insert_function):
12700 * keymap.c (push_key_description):
12701 * search.c (Freplace_match):
12702 * xdisp.c (message_dolog, set_message_1): All callers changed.
12704 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12706 * keyboard.c (safe_run_hook_funcall): New function.
12707 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12708 don't set the hook to nil, but remove the offending function instead.
12709 (Qcommand_hook_internal): Remove, unused.
12710 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12711 Vcommand_hook_internal.
12713 * eval.c (enum run_hooks_condition): Remove.
12714 (funcall_nil, funcall_not): New functions.
12715 (run_hook_with_args): Call each function through a `funcall' argument.
12716 Remove `cond' argument, now redundant.
12717 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12718 (Frun_hook_with_args_until_failure): Adjust accordingly.
12719 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12721 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12723 * dispextern.h (string_buffer_position): Remove declaration.
12725 * print.c (strout): Remove parameter `multibyte', unused since
12726 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12728 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12729 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12730 All callers changed.
12732 * w32.c (_wsa_errlist): Use braces for struct initializers.
12734 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12735 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12736 All callers changed.
12737 (string_buffer_position): Likewise. Also, make static (it's never
12738 used outside xdisp.c).
12739 (cursor_row_p): Remove parameter `w', unused since
12740 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12741 (decode_mode_spec): Remove parameter `precision', introduced during
12742 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12743 All callers changed.
12745 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12747 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12749 2011-03-27 Anders Lindgren <andlind@gmail.com>
12751 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12752 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12753 (ns_update_auto_hide_menu_bar): New functions.
12754 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12755 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12756 ns_constrain_all_frames.
12757 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12758 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12760 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12762 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12764 2011-03-27 Glenn Morris <rgm@gnu.org>
12766 * syssignal.h: Replace RETSIGTYPE with void.
12767 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12768 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12769 Replace SIGTYPE with void everywhere.
12770 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12771 * s/template.h (SIGTYPE): Remove commented out definition.
12773 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12775 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12776 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12778 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12780 * w32.c (read_unc_volume): Use parameter `henum', instead of
12781 global variable `wget_enum_handle'.
12783 * keymap.c (describe_vector): Remove parameters `indices' and
12784 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12785 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12787 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12789 * keyboard.c (timer_check): Remove parameter `do_it_now',
12790 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12791 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12792 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12794 * keyboard.c (read_char):
12795 * w32menu.c (w32_menu_display_help):
12796 * xmenu.c (show_help_event, menu_help_callback):
12797 Adjust calls to `show_help_echo'.
12799 * gtkutil.c (xg_maybe_add_timer):
12800 * keyboard.c (readable_events):
12801 * process.c (wait_reading_process_output):
12802 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12804 * insdel.c (adjust_markers_gap_motion):
12805 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12806 (gap_left, gap_right): Don't call it.
12808 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12810 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12811 incurred during fontification.
12813 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12815 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12816 (DEFVAR_PER_BUFFER): Don't pass it.
12818 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12819 (scrolling_window): Don't pass it.
12821 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12823 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12825 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12827 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12828 of variables specific to SELinux and computation of `encoded_absname'.
12830 * image.c (XPutPixel): Remove unused variable `height'.
12832 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12834 * unexw32.c (get_section_info): Remove unused variable `section'.
12836 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12837 (system_process_attributes): Remove unused variable `sess'.
12838 (sys_read): Remove unused variable `err'.
12840 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12841 (w32_wnd_proc): Remove unused variable `isdead'.
12842 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12843 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12844 (x_create_tip_frame): Remove unused variable `tem'.
12846 * w32inevt.c (w32_console_read_socket):
12847 Remove unused variable `no_events'.
12849 * w32term.c (x_draw_composite_glyph_string_foreground):
12850 Remove unused variable `width'.
12852 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12854 * w32term.c (x_set_glyph_string_clipping):
12855 Don't pass uninitialized region to CombineRgn.
12857 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12859 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12860 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12861 (Fx_close_connection): Remove unused variable `i'.
12863 * w32font.c (w32font_draw): Return number of glyphs.
12864 (w32font_open_internal): Remove unused variable `i'.
12865 (w32font_driver): Add missing initializer.
12867 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12868 (fill_in_menu): Remove unused variable `items_added'.
12870 * w32term.c (last_mouse_press_frame): Remove static global variable.
12871 (w32_clip_to_row): Remove unused variable `f'.
12872 (x_delete_terminal): Remove unused variable `i'.
12874 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12875 (NOTHING): Remove unused static global variable.
12876 (uniscribe_check_otf): Remove unused variable `table'.
12877 (uniscribe_font_driver): Add missing initializers.
12879 2011-03-23 Julien Danjou <julien@danjou.info>
12881 * term.c (Fsuspend_tty, Fresume_tty):
12882 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12883 * window.c (temp_output_buffer_show):
12884 * insdel.c (signal_before_change):
12885 * frame.c (Fhandle_switch_frame):
12886 * fileio.c (Fdo_auto_save):
12887 * emacs.c (Fkill_emacs):
12888 * editfns.c (save_excursion_restore):
12889 * cmds.c (internal_self_insert):
12890 * callint.c (Fcall_interactively):
12891 * buffer.c (Fkill_all_local_variables):
12892 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12894 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12895 unconditionally since it does the check itself.
12897 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12899 Fix more problems found by GCC 4.5.2's static checks.
12901 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12902 the first time through the loop, since we know p0 < p1 then.
12903 This also avoids a gcc -Wstrict-overflow warning.
12905 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12906 leading to a memory leak, possible in functions like
12907 load_charset_map_from_file that can allocate an unbounded number
12908 of objects (Bug#8318).
12910 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12911 that could (at least in theory) be that large.
12913 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12914 This is less likely to overflow, and avoids undefined behavior if
12915 overflow does occur. All callers changed. Use strtoul to scan
12916 for the unsigned long integer.
12917 (pint2hrstr): Simplify and tune code slightly.
12918 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12920 * scroll.c (do_scrolling): Work around GCC bug 48228.
12921 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12923 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12924 This also avoids a warning with gcc -Wstrict-overflow.
12925 (validate_x_resource_name): Simplify count usage.
12926 This also avoids a warning with gcc -Wstrict-overflow.
12928 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12931 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12933 * process.c (Fmake_network_process): Use socklen_t, not int,
12934 where POSIX says socklen_t is required in portable programs.
12935 This fixes a porting bug on hosts like 64-bit HP-UX, where
12936 socklen_t is wider than int (Bug#8277).
12937 (Fmake_network_process, server_accept_connection):
12938 (wait_reading_process_output, read_process_output):
12941 * process.c: Rename or move locals to avoid shadowing.
12942 (list_processes_1, Fmake_network_process):
12943 (read_process_output_error_handler, exec_sentinel_error_handler):
12944 Rename or move locals.
12945 (Fmake_network_process): Define label "retry_connect" only if needed.
12946 (Fnetwork_interface_info): Fix pointer signedness.
12947 (process_send_signal): Add cast to avoid pointer signedness problem.
12948 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12949 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12951 Make tparam.h and terminfo.c consistent.
12952 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12953 Include tparam.h instead, since it declares them.
12954 * cm.h (PC): Remove extern decl; tparam.h now does this.
12955 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12956 * terminfo.c: Include tparam.h, to check interfaces.
12957 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12958 (tparam): Adjust signature to match interface in tparam.h;
12959 this removes some undefined behavior. Check that outstring and len
12960 are zero, which they always are with Emacs.
12961 * tparam.h (PC, BC, UP): New extern decls.
12963 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12964 (xftfont_open): Rename locals to avoid shadowing.
12966 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12967 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12968 (OTF_TAG_SYM): Omit macro if not needed.
12969 (ftfont_list): Remove unused local.
12970 (get_adstyle_property, ftfont_pattern_entity):
12971 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12972 Rename locals to avoid shadowing.
12974 * xfont.c (xfont_list_family): Mark var as initialized.
12976 * xml.c (make_dom): Now static.
12978 * composite.c (composition_compute_stop_pos): Rename local to
12980 (composition_reseat_it): Remove unused locals.
12981 (find_automatic_composition, composition_adjust_point): Likewise.
12982 (composition_update_it): Mark var as initialized.
12983 (find_automatic_composition): Mark vars as initialized,
12984 with a FIXME (Bug#8290).
12986 character.h: Rename locals to avoid shadowing.
12987 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12988 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12989 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12990 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12991 to avoid shadowing.
12993 * textprop.c (property_change_between_p): Remove; unused.
12995 * intervals.c (interval_start_pos): Now static.
12997 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12999 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13000 Rename locals to avoid shadowing.
13002 * sound.c (wav_play, au_play, Fplay_sound_internal):
13003 Fix pointer signedness.
13004 (alsa_choose_format): Remove unused local var.
13005 (wav_play): Initialize a variable to 0, to prevent undefined
13006 behavior (Bug#8278).
13008 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13010 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13012 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13013 clobbering (Bug#8298).
13014 * sysdep.c (sys_subshell): Likewise.
13015 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13017 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13018 This should get cleaned up, so that child_setup has the
13019 same signature on all platforms.
13021 * callproc.c (call_process_cleanup): Now static.
13022 (relocate_fd): Rename locals to avoid shadowing.
13024 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13026 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13027 not to be necessary, and produces flickering.
13029 2011-03-20 Glenn Morris <rgm@gnu.org>
13031 * config.in: Remove file.
13033 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13035 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13036 are now in src/globals.h.
13037 (syms_of_minibuf): Remove spurious & from previous change.
13039 2011-03-20 Leo Liu <sdl.web@gmail.com>
13041 * minibuf.c (completing-read-function): New variable.
13042 (completing-read-default): Rename from completing-read.
13043 (completing-read): Call completing-read-function.
13045 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13047 * xfaces.c (Fx_load_color_file):
13048 Read color file from absolute filename (bug#8250).
13050 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13052 * makefile.w32-in: Update dependencies.
13054 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13056 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13058 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13060 Fix more problems found by GCC 4.5.2's static checks.
13062 * process.c (make_serial_process_unwind, send_process_trap):
13063 (sigchld_handler): Now static.
13065 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13066 That way, the code declares only the vars that it needs.
13067 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13068 * s/cygwin.h (PTY_ITERATION): Likewise.
13069 * s/darwin.h (PTY_ITERATION): Likewise.
13070 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13072 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13073 * process.c (allocate_pty): Don't declare stb unless it's needed.
13075 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13076 (CONSTANTLIM): Remove; unused.
13077 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13078 Define only if needed.
13080 * unexelf.c (unexec): Name an expression,
13081 to avoid gcc -Wbad-function-cast warning.
13082 Use a different way to cause a compilation error if anyone uses
13083 n rather than nn, a way that does not involve shadowing.
13084 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13086 * deps.mk (unexalpha.o): Remove; unused.
13088 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13089 * unexec.h: New file.
13090 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13091 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13092 Depend on unexec.h.
13093 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13094 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13095 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13096 Change as necessary to match prototype in unexec.h.
13098 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13100 (back_comment, skip_chars): Mark vars as initialized.
13102 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13103 Rename locals to avoid shadowing.
13105 * lread.c (read1): Rewrite so as not to use empty "else".
13106 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13108 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13110 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13111 warning when compiling print.c.
13113 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13114 instead of using an uninitialized var.
13115 (font_sort_entities): Mark var as initialized.
13117 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13119 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13120 pointers to constants.
13121 (font_parse_fcname): Remove unused vars.
13122 (font_delete_unmatched): Now static.
13123 (font_get_spec): Remove; unused.
13124 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13125 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13126 Rename or move locals to avoid shadowing.
13128 * fns.c (require_nesting_list, require_unwind): Now static.
13129 (Ffillarray): Rename locals to avoid shadowing.
13131 * floatfns.c (domain_error2): Define only if needed.
13132 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13134 * alloc.c (mark_backtrace): Move decl from here ...
13135 * lisp.h: ... to here, so that it can be checked.
13137 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13138 (Fdefvar): Rewrite so as not to use empty "else".
13139 (lisp_indirect_variable): Name an expression,
13140 to avoid gcc -Wbad-function-cast warning.
13141 (Fdefvar): Rename locals to avoid shadowing.
13143 * callint.c (quotify_arg, quotify_args): Now static.
13144 (Fcall_interactively): Rename locals to avoid shadowing.
13145 Use const pointer when appropriate.
13147 * lisp.h (get_system_name, get_operating_system_release):
13148 Move decls here, to check interfaces.
13149 * process.c (get_operating_system_release): Move decl to lisp.h.
13150 * xrdb.c (get_system_name): Likewise.
13151 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13152 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13153 some of which prompt warnings from gcc -Wbad-function-cast.
13154 (Fformat_time_string, Fencode_time, Finsert_char):
13155 (Ftranslate_region_internal, Fformat):
13156 Rename or remove local vars to avoid shadowing.
13157 (Ftranslate_region_internal): Mark var as initialized.
13159 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13162 * lisp.h (eassert): Check that the argument compiles, even if
13163 ENABLE_CHECKING is not defined.
13165 * data.c (Findirect_variable): Name an expression, to avoid
13166 gcc -Wbad-function-cast warning.
13167 (default_value, arithcompare, arith_driver, arith_error): Now static.
13168 (store_symval_forwarding): Rename local to avoid shadowing.
13169 (Fmake_variable_buffer_local, Fmake_local_variable):
13170 Mark variables as initialized.
13171 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13173 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13174 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13175 Rename locals to avoid shadowing.
13176 (mark_stack): Move local variables into the #ifdef region where
13178 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13179 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13181 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13182 (GC_STRING_CHARS): Remove; not used.
13183 (Fmemory_limit): Cast sbrk's returned value to char *.
13185 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13186 avoids undefined behavior in theory.
13188 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13190 Use functions, not macros, for up- and down-casing (Bug#8254).
13191 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13192 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13193 to use the following functions instead of these macros.
13194 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13195 EMACS_INT, since callers assume the returned value fits in int.
13196 (upcase1): Likewise, for UPCASE_TABLE.
13197 (uppercasep, lowercasep, upcase): New static inline functions.
13198 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13199 the race-condition problem in the old DOWNCASE.
13201 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13202 Rename locals to avoid shadowing.
13203 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13204 (regex_compile, re_search_2, re_match_2_internal):
13205 Remove unused local vars.
13206 (FREE_VAR): Rewrite so as not to use empty "else",
13207 which gcc can warn about.
13208 (regex_compile, re_match_2_internal): Mark locals as initialized.
13209 (RETALLOC_IF): Define only if needed.
13210 (WORDCHAR_P): Likewise. This one is never needed, but is used
13211 only in a comment talking about a compiler bug, so put inside
13212 the #if 0 of that comment.
13213 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13214 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13217 * search.c (boyer_moore): Rename locals to avoid shadowing.
13218 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13219 (PREV_CHAR_BOUNDARY): Likewise.
13221 * search.c (simple_search): Remove unused var.
13223 * dired.c (compile_pattern): Move decl from here ...
13224 * lisp.h: ... to here, so that it can be checked.
13225 (struct re_registers): New forward decl.
13227 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13229 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13231 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13232 Rename locals to avoid shadowing.
13233 (Fvertical_motion): Mark locals as initialized.
13235 * casefiddle.c (casify_object, casify_region): Now static.
13236 (casify_region): Mark local as initialized.
13238 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13240 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13241 New macros, so that the caller can use some names other than
13242 gcpro1, gcpro2, etc.
13243 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13245 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13246 argument, for consistency with GCPRO2_VAR, etc: it is now the
13247 prefix of the variable, not the variable itself. All uses
13249 * dired.c (directory_files_internal, file_name_completion):
13250 Rename locals to avoid shadowing.
13252 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13253 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13254 dired.c's scmp function, had undefined behavior.
13255 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13256 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13257 * buffer.h: ... to here, because these macros use current_buffer,
13258 and the new implementation with inline functions needs to have
13259 current_buffer in scope now, rather than later when the macros
13261 (downcase, upcase1): New static inline functions.
13262 (DOWNCASE, UPCASE1): Reimplement using these functions.
13263 This avoids undefined behavior in expressions like
13264 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13265 from race conditions in accessing the global variables
13266 case_temp1 and case_temp2.
13267 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13268 * lisp.h (case_temp1, case_temp2): Remove their decls.
13269 * character.h (ASCII_CHAR_P): Move from here ...
13270 * lisp.h: ... to here, so that the inline functions mentioned
13271 above can use them.
13273 * dired.c (directory_files_internal_unwind): Now static.
13275 * fileio.c (file_name_as_directory, directory_file_name):
13276 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13278 (file_name_as_directory): Use const pointers when appropriate.
13279 (Fexpand_file_name): Likewise. In particular, newdir might
13280 point at constant storage, so make it a const pointer.
13281 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13282 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13284 (Fset_file_times, Finsert_file_contents, auto_save_error):
13285 Rename locals to avoid shadowing.
13287 * minibuf.c (choose_minibuf_frame_1): Now static.
13288 (Ftry_completion, Fall_completions): Rename or remove locals
13289 to avoid shadowing.
13291 * marker.c (bytepos_to_charpos): Remove; unused.
13293 * lisp.h (verify_bytepos, count_markers): New decls,
13294 so that gcc does not warn that these functions aren't declared.
13296 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13297 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13298 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13299 (copy_text): Remove unused local var.
13301 * filelock.c (within_one_second): Now static.
13302 (lock_file_1): Rename local to avoid shadowing.
13304 * buffer.c (fix_overlays_before): Mark locals as initialized.
13305 (fix_start_end_in_overlays): Likewise. This function should be
13306 simplified by using pointers-to-pointers, but that's a different
13308 (switch_to_buffer_1): Now static.
13309 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13310 (report_overlay_modification): Rename locals to avoid shadowing.
13312 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13313 Fix pointer signedness issue.
13314 (sys_subshell): Mark local as volatile if checking for lint,
13315 to suppress a gcc -Wclobbered warning that does not seem to be right.
13316 (MAXPATHLEN): Define only if needed.
13318 * process.c (serial_open, serial_configure): Move decls from here ...
13319 * systty.h: ... to here, so that they can be checked.
13321 * fns.c (get_random, seed_random): Move extern decls from here ...
13322 * lisp.h: ... to here, so that they can be checked.
13324 * sysdep.c (reset_io): Now static.
13325 (wait_for_termination_signal): Remove; unused.
13327 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13328 (copy_keymap_item, append_key, push_text_char_description):
13330 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13331 (DENSE_TABLE_SIZE): Remove; unused.
13332 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13333 (describe_map_tree):
13334 Rename locals to avoid shadowing.
13336 * keyboard.c: Declare functions static if they are not used elsewhere.
13337 (echo_char, echo_dash, cmd_error, top_level_2):
13338 (poll_for_input, handle_async_input): Now static.
13339 (read_char, kbd_buffer_get_event, make_lispy_position):
13340 (make_lispy_event, make_lispy_movement, apply_modifiers):
13341 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13342 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13343 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13344 (read_key_sequence, read_char): Mark locals as initialized.
13345 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13347 * keyboard.h (make_ctrl_char): New decl.
13348 (mark_kboards): Move decl here ...
13349 * alloc.c (mark_kboards): ... from here.
13351 * lisp.h (force_auto_save_soon): New decl.
13353 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13354 (DEFINE_DUMMY_FUNCTION): New macro.
13355 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13357 (main): Add casts to avoid warnings
13358 if GCC considers string literals to be constants.
13360 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13362 * dbusbind.c: Pointer signedness fixes.
13363 (xd_signature, xd_append_arg, xd_initialize):
13364 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13365 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13366 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13367 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13369 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13370 if GCC considers string literals to be constants.
13371 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13373 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13375 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13376 (print_preprocess, print_object): New macro to fix last change.
13378 * print.c (print_preprocess): Don't forget font objects.
13380 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13382 * emacs.c (USAGE3): Doc fixes.
13384 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13386 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13389 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13391 * lisp.h (VWindow_system, Qfile_name_history):
13392 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13393 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13394 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13396 * w32select.c: Don't #include "keyboard.h".
13397 (run_protected): Add extern declaration for waiting_for_input.
13399 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13400 * w32console.c (detect_input_pending, read_input_pending)
13401 (encode_terminal_code):
13402 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13403 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13404 (w32_system_caret_y, Qfile_name_history):
13405 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13406 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13407 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13408 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13409 * w32proc.c (Qlocal, report_file_error):
13410 * w32term.c (Vwindow_system, updating_frame):
13411 * w32uniscribe.c (initialized, uniscribe_font_driver):
13412 Remove unneeded extern declarations.
13414 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13416 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13418 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13420 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13421 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13422 These macros can no longer be used for assignment.
13424 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13425 Assign struct members directly, instead of using BUF_BEGV etc.
13426 (record_buffer_markers, fetch_buffer_markers): New functions for
13427 recording and fetching special buffer markers.
13428 (set_buffer_internal_1, set_buffer_temp): Use them.
13430 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13432 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13434 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13435 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13437 * xdisp.c (hscroll_window_tree):
13438 (reconsider_clip_changes): Use PT instead of BUF_PT.
13440 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13442 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13443 $(EMACS_ROOT)/lib/intprops.h.
13445 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13447 Fix more problems found by GCC 4.5.2's static checks.
13449 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13450 to unsigned char * to avoid compiler diagnostic.
13451 (xg_free_frame_widgets): Make it clear that a local variable is
13452 needed only if USE_GTK_TOOLTIP.
13453 (gdk_window_get_screen): Make it clear that this macro is needed
13454 only if USE_GTK_TOOLTIP.
13455 (int_gtk_range_get_value): New function, which avoids a diagnostic
13456 from gcc -Wbad-function-cast.
13457 (xg_set_toolkit_scroll_bar_thumb): Use it.
13458 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13459 diagnostic from gcc -Wbad-function-cast.
13460 (get_utf8_string, xg_get_file_with_chooser):
13461 Rename locals to avoid shadowing.
13462 (create_dialog): Move locals to avoid shadowing.
13464 * xgselect.c (xg_select): Remove unused var.
13466 * image.c (four_corners_best): Mark locals as initialized.
13467 (gif_load): Initialize transparent_p to zero (Bug#8238).
13468 Mark another local as initialized.
13469 (my_png_error, my_error_exit): Mark with NO_RETURN.
13471 * image.c (clear_image_cache): Now static.
13472 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13473 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13474 (x_edge_detection): Remove unnecessary cast that
13475 gcc -Wbad-function-cast diagnoses.
13476 (gif_load): Fix pointer signedness.
13477 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13478 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13480 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13482 Improve quality of tests for time stamp overflow.
13483 For example, without this patch (encode-time 0 0 0 1 1
13484 1152921504606846976) returns the obviously-bogus value (-948597
13485 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13486 reports time overflow. See
13487 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13488 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13489 * editfns.c: Include limits.h and intprops.h.
13490 (TIME_T_MIN, TIME_T_MAX): New macros.
13491 (time_overflow): Move earlier, to before first use.
13492 (hi_time, lo_time): New functions, for an accurate test for
13493 out-of-range times.
13494 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13495 (Fget_internal_run_time): Don't assume time_t fits in int.
13496 (make_time): Use list2 instead of Fcons twice.
13497 (Fdecode_time): More accurate test for out-of-range times.
13498 (check_tm_member): New function.
13499 (Fencode_time): Use it, to test for out-of-range times.
13500 (lisp_time_argument): Don't rely on undefined left-shift and
13501 right-shift behavior when checking for time stamp overflow.
13503 * editfns.c (time_overflow): New function, refactoring common code.
13504 (Fformat_time_string, Fdecode_time, Fencode_time):
13505 (Fcurrent_time_string): Use it.
13507 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13508 * dired.c (make_time): Move to ...
13509 * editfns.c (make_time): ... here.
13510 * systime.h: Note the move.
13512 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13514 * fringe.c (update_window_fringes): Remove unused variables.
13516 * unexmacosx.c (copy_data_segment): Also copy __got section.
13519 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13521 * termcap.c [MSDOS]: Include "msdos.h".
13522 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13523 Constify `char *' arguments and their references according to
13524 prototypes in tparam.h.
13526 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13528 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13529 Adapt all references accordingly.
13531 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13533 2011-03-11 Tom Tromey <tromey@redhat.com>
13535 * buffer.c (syms_of_buffer): Remove obsolete comment.
13537 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13539 * termhooks.h (encode_terminal_code): Declare prototype.
13541 * msdos.c (encode_terminal_code): Don't declare prototype.
13543 * term.c (encode_terminal_code): Now external again, used by
13544 w32console.c and msdos.c.
13546 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13547 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13549 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13551 Fix some minor problems found by GCC 4.5.2's static checks.
13553 * fringe.c (update_window_fringes): Mark locals as initialized
13555 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13557 * alloc.c (mark_fringe_data): Move decl from here ...
13558 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13559 to check its interface.
13560 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13562 * fontset.c (free_realized_fontset): Now static.
13563 (Fset_fontset_font): Rename local to avoid shadowing.
13564 (fontset_font): Mark local as initialized.
13565 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13567 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13569 * xselect.c (x_disown_buffer_selections): Remove; not used.
13570 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13571 (x_own_selection, Fx_disown_selection_internal): Rename locals
13572 to avoid shadowing.
13573 (x_handle_dnd_message): Remove local to avoid shadowing.
13575 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13576 so that the caller can use some name other than gcpro1.
13577 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13578 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13579 (Fx_backspace_delete_keys_p):
13580 Use them to avoid shadowing, and rename vars to avoid shadowing.
13581 (x_decode_color, x_set_name, x_window): Now static.
13582 (Fx_create_frame): Add braces to silence GCC warning.
13583 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13584 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13585 Remove unused locals.
13586 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13587 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13588 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13591 * xterm.h (x_mouse_leave): New decl.
13593 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13594 Remove unused functions.
13595 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13596 (x_calc_absolute_position): Now static.
13597 (XTread_socket): Don't define label "out" unless it's used.
13598 Don't declare local "event" unless it's used.
13599 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13600 unless they are used.
13601 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13602 (x_fatal_error_signal): Remove; not used.
13603 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13604 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13605 (x_error_catcher, x_connection_closed, x_error_handler):
13606 (x_error_quitter, xembed_send_message, x_iconify_frame):
13607 (my_log_handler): Rename locals to avoid shadowing.
13608 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13609 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13611 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13612 Rename or move locals to avoid shadowing.
13613 (tty_defined_color, merge_face_heights): Now static.
13614 (free_realized_faces_for_fontset): Remove; not used.
13615 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13616 does not deduce is never used uninitialized.
13617 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13618 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13620 * terminal.c (store_terminal_param): Now static.
13622 * xmenu.c (menu_highlight_callback): Now static.
13623 (set_frame_menubar): Remove unused local.
13624 (xmenu_show): Rename parameter to avoid shadowing.
13625 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13626 since they might point to immutable storage.
13627 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13628 since it's unused otherwise.
13630 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13631 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13632 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13633 avoids a gcc -Wuninitialized diagnostic.
13634 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13635 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13636 does not deduce are never used uninitialized.
13638 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13640 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13641 * window.c (window_loop, size_window):
13642 (run_window_configuration_change_hook, enlarge_window): Likewise.
13644 * window.c (display_buffer): Now static.
13645 (size_window): Mark variables that gcc -Wuninitialized
13646 does not deduce are never used uninitialized.
13647 * window.h (check_all_windows): New decl, to forestall
13648 gcc -Wmissing-prototypes diagnostic.
13649 * dispextern.h (bidi_dump_cached_states): Likewise.
13651 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13653 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13654 Include <limits.h>.
13655 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13656 and to avoid gcc -Wuninitialized warning.
13657 (load_charset_map): Mark variables that gcc -Wuninitialized
13658 does not deduce are never used uninitialized.
13659 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13661 * coding.c (coding_set_source, coding_set_destination):
13662 Use "else { /* comment */ }" rather than "else /* comment */;"
13663 for clarity, and to avoid gcc -Wempty-body warning.
13664 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13665 a block, when the outer 'i' will do.
13666 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13667 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13668 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13669 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13670 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13671 Rename locals to avoid shadowing.
13672 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13673 * coding.c (emacs_mule_char, encode_invocation_designation):
13674 Now static, since they're not used elsewhere.
13675 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13676 (decode_coding_object, encode_coding_object, detect_coding_system):
13677 (decode_coding_emacs_mule): Mark variables that gcc
13678 -Wuninitialized does not deduce are never used uninitialized.
13679 (detect_coding_iso_2022): Initialize a local variable that might
13680 be used uninitialized. Leave a FIXME because it's not clear that
13681 this initialization is needed. (Bug#8211)
13682 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13683 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13684 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13685 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13686 Remove unused macros.
13688 * category.c (hash_get_category_set): Remove unused local var.
13689 (copy_category_table): Now static, since it's not used elsewhere.
13690 * character.c (string_count_byte8): Likewise.
13692 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13693 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13695 * chartab.c (copy_sub_char_table): Now static, since it's not used
13697 (sub_char_table_ref_and_range, char_table_ref_and_range):
13698 Rename locals to avoid shadowing.
13699 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13701 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13702 (BIDI_BOB): Remove unused macro.
13704 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13705 deduce are never used uninitialized.
13706 * term.c (encode_terminal_code): Likewise.
13708 * term.c (encode_terminal_code): Now static. Remove unused local.
13710 * tparam.h: New file.
13711 * term.c, tparam.h: Include it.
13712 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13713 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13714 Move these decls to tparam.h, and make them agree with what
13715 is actually in tparam.c. The previous trick of using incompatible
13716 decls in different modules does not conform to the C standard.
13717 All callers of tparam changed to use tparam's actual API.
13718 * tparam.c (tparam1, tparam, tgoto):
13719 Use const pointers where appropriate.
13721 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13722 * cm.h (struct cm): Likewise.
13723 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13724 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13725 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13726 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13727 (turn_on_face, init_tty): Likewise.
13728 * termchar.h (struct tty_display_info): Likewise.
13730 * term.c (term_mouse_position): Rename local to avoid shadowing.
13732 * alloc.c (mark_ttys): Move decl from here ...
13733 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13735 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13737 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13739 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13741 * search.c (compile_pattern_1): Remove argument regp, unused since
13742 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13743 (compile_pattern): Don't pass it.
13745 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13747 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13748 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13750 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13752 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13754 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13755 gdk_window_get_screen, gdk_window_get_geometry,
13756 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13757 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13758 (xg_get_pixbuf_from_pixmap): New function.
13759 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13760 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13761 Call xg_get_pixbuf_from_pixmap instead of
13762 gdk_pixbuf_get_from_drawable.
13763 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13764 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13765 (xg_check_special_colors): Use GtkStyleContext and its functions
13767 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13768 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13769 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13770 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13771 Call gtk_widget_get_preferred_size.
13772 (xg_frame_resized): gdk_window_get_geometry only takes 5
13774 (xg_win_to_widget, xg_event_is_for_menubar):
13775 Call gdk_x11_window_lookup_for_display.
13776 (xg_set_widget_bg): New function.
13777 (delete_cb): New function.
13778 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13779 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13780 (xg_set_background_color): Call xg_set_widget_bg.
13781 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13782 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13783 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13784 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13786 (update_frame_tool_bar): Call gtk_widget_hide.
13787 (xg_initialize): Use GDK_KEY_g.
13789 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13791 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13793 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13794 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13795 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13797 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13799 * w32xfns.c (select_palette): Check success of RealizePalette against
13800 GDI_ERROR, not zero.
13802 See ChangeLog.11 for earlier changes.
13804 ;; Local Variables:
13808 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13810 This file is part of GNU Emacs.
13812 GNU Emacs is free software: you can redistribute it and/or modify
13813 it under the terms of the GNU General Public License as published by
13814 the Free Software Foundation, either version 3 of the License, or
13815 (at your option) any later version.
13817 GNU Emacs is distributed in the hope that it will be useful,
13818 but WITHOUT ANY WARRANTY; without even the implied warranty of
13819 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13820 GNU General Public License for more details.
13822 You should have received a copy of the GNU General Public License
13823 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
HCoop / bpt / emacs.git / blob