1 2012-07-14 Eli Zaretskii <eliz@gnu.org>
3 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
5 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
6 (HAVE_MENUS): Don't define, defined by editing config.in with
8 (GMALLOC_INHIBIT_VALLOC): Don't define.
9 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
11 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
13 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
15 2012-07-14 Glenn Morris <rgm@gnu.org>
17 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
18 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
19 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
21 2012-07-13 Glenn Morris <rgm@gnu.org>
23 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
25 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
26 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
28 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
30 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
31 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
32 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
33 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
35 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
36 as boolean expression.
37 (x_set_window_size): Remove unused variable toolbar.
38 (ns_get_color_default, ns_mod_to_lisp): Remove.
39 (ns_mouse_position): Remove unused variables xchar and ychar.
40 (ns_compute_glyph_string_overhangs): Remove unused variable face.
41 (ns_set_vertical_scroll_bar): Remove unused variable count.
42 (ns_delete_terminal): Remove unused variable i.
43 (ns_term_init): Remove unused variables r, g and b.
44 (mouseDown): Remove unused variable window.
45 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
46 (initFrameFromEmacs): Remove unused variable vbextra.
47 (mouseEntered): Remove unused variables p and dpyinfo.
48 (mouseExited): Remove unused variables p and r.
49 (ns_define_frame_cursor, ns_clear_frame_area)
50 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
51 (menuDown): Assign [sender tag] to variable and cast the variable.
53 * nsterm.h (menuDown): Add id as type to argument sender.
54 (ns_display_info_for_name): Add Lisp_Object argument.
55 (ns_term_init): Add Lisp_Object argument.
56 (ns_map_event_to_object): Add void argument.
57 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
58 prototype with arguments and only declare if __OBJC__.
59 (nxatoms_of_nsselect): Add void argument.
60 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
61 (ns_alloc_autorelease_pool): Add void argument.
62 (ns_release_autorelease_pool): Add void* argument.
63 (ns_get_defaults_value): Add const char* argument.
65 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
66 (initFromContents): Use SSDATA where appropriate.
67 (ns_update_menubar): Add braces to ambigous if-else.
68 (initWithTitle): Put () around assignment in if statement.
69 (ns_menu_show): Remove unused variables window and keymap.
70 (update_frame_tool_bar): Remove unused variable selected_p.
71 (initWithContentRect): Remove unused variable this_cmd_name.
73 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
75 (setXBMColor): Remove unused variable len.
76 (setPixmapData): Put () around assignment in loop statement.
78 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
79 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
81 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
82 around assignment in loop statement.
83 (nsfont_open): Remove unused variable i.
84 (nsfont_open): Remove unused variable len.
85 (nsfont_draw): Remove unused variable cs.
87 * nsfns.m (x_set_icon_name, ns_set_name_internal)
88 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
89 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
90 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
91 (Fns_font_name, Fns_perform_service)
92 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
93 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
94 (ns_set_name): Remove unused variable view.
95 (x_set_menu_bar_lines): Remove unused variable olines.
96 (x_set_tool_bar_lines): Remove unused variable root_window.
97 (Fns_list_colors): Put () around assignment in while statement.
98 (Fns_perform_service): Remove unused variable len.
99 (Fns_display_usable_bounds): Remove unused variable top.
100 (syms_of_nsfns): Remove unused variable i.
102 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
105 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
107 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
108 and free it with DestroyExceptionInfo (Bug#11558).
110 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
112 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
113 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
114 Set here, not in nt/config.nt.
116 2012-07-13 Eli Zaretskii <eliz@gnu.org>
118 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
119 cursor overflow into the last glyph on display line when the right
120 fringe is off. (Bug#11832)
122 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
124 * xdisp.c (produce_special_glyphs): Now static.
125 * dispextern.h (produce_special_glyphs): Remove decl.
127 2012-07-13 Glenn Morris <rgm@gnu.org>
129 * s/bsd-common, s/cygwin.h: Remove empty files.
130 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
132 * s/usg5-4-common.h (USG, USG5):
133 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
134 * s/sol2-6.h (SOLARIS2):
135 * s/irix6-5.h (IRIX6_5):
136 * s/hpux10-20.h (USG, USG5, HPUX):
137 * s/gnu-linux.h (USG, GNU_LINUX):
138 * s/freebsd.h (BSD_SYSTEM):
139 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
140 * s/cygwin.h (CYGWIN):
141 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
142 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
144 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
146 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
148 2012-07-13 Glenn Morris <rgm@gnu.org>
150 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
152 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
154 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
155 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
157 2012-07-12 Glenn Morris <rgm@gnu.org>
159 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
161 * process.c (init_process_emacs): Rename from init_process.
162 The old name is also the name of a Mach system call.
163 * lisp.h, emacs.c: Update for this name change.
164 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
167 2012-07-12 Eli Zaretskii <eliz@gnu.org>
169 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
170 memmove call that removes glyphs covered by the left truncation
171 glyph. Improve commentary.
172 (display_line): Fix display of continuation glyphs on GUI frames
173 when the right fringe is turned off and variable-size fonts are
174 used in the window. Move the code that appends a stretch glyph to
175 produce_special_glyphs, so that it could be used for truncation
176 and continuation glyphs alike.
177 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
178 glyph of a suitably computed width, to align the special glyphs at
179 the window margin. Code moved from display_line. (Bug#11832)
181 2012-07-12 Glenn Morris <rgm@gnu.org>
183 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
185 * s/gnu-linux.h, s/hpux10-20.h:
186 Do not unconditionally define HAVE_XRMSETDATABASE.
188 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
190 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
192 Fix typos that broke OS X build.
193 Reported by Randal L. Schwartz in
194 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
195 * nsterm.m (ns_timeout): Add missing local decl.
196 (ns_get_color): snprintf -> sprintf, to fix typo.
198 2012-07-12 Glenn Morris <rgm@gnu.org>
200 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
201 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
202 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
203 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
205 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
206 Move PTY_OPEN to configure.
208 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
209 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
210 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
212 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
214 Use empty_unibyte_string where applicable.
215 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
216 * lread.c (read1): Likewise.
217 * xsettings.c (syms_of_xsettings): Likewise.
219 2012-07-12 Glenn Morris <rgm@gnu.org>
221 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
222 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
223 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
224 * s/hpux10-20.h (RUN_TIME_REMAP):
225 * s/bsd-common.h (TABDLY): Move to configure.
227 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
229 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
231 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
232 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
234 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
236 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
237 * s/template.h: Move NARROWPROTO to configure.
239 2012-07-11 Glenn Morris <rgm@gnu.org>
241 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
242 unused since 2011-01-17 change to systty.h.
244 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
245 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
246 Move HAVE_PTYS and HAVE_SOCKETS to configure.
248 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
250 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
252 2012-07-11 Glenn Morris <rgm@gnu.org>
254 * s/darwin.h, s/gnu-linux.h, s/template.h:
255 Move INTERRUPT_INPUT to configure.
257 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
259 Minor adjustments to interning code.
260 * lisp.h (intern, intern_c_string): Redefine as static inline
261 wrappers for intern_1 and intern_c_string_1, respectively.
262 (intern_1, intern_c_string_1): Rename prototypes.
263 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
265 * font.c (font_intern_prop): Likewise. Adjust comment.
266 * w32font.c (intern_font_name): Likewise.
268 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
270 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
272 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
273 of Fcar/Fcdr if possible.
274 * font.c (check_otf_features): Likewise.
275 * fontset.c (Fnew_fontset): Likewise.
276 * gnutls.c (Fgnutls_boot): Likewise.
277 * minibuf.c (read_minibuf): Likewise.
278 * msdos.c (IT_set_frame_parameters): Likewise.
279 * xmenu.c (Fx_popup_dialog): Likewise.
280 * w32menu.c (Fx_popup_dialog): Likewise.
282 2012-07-11 Glenn Morris <rgm@gnu.org>
284 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
285 since nothing has defined it on these platforms.
287 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
288 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
290 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
291 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
292 Move CLASH_DETECTION to configure.
294 * s/gnu.h: Remove file, which is now empty.
296 * s/gnu.h, s/gnu-linux.h:
297 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
299 2012-07-11 John Wiegley <johnw@newartisans.com>
301 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
302 function attribute, so we only use it if it exists in the
305 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
307 Avoid call to strlen in fast_c_string_match_ignore_case.
308 * search.c (fast_c_string_match_ignore_case): Change to use
309 length argument. Adjust users accordingly.
310 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
312 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
315 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
316 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
319 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
322 * s/hpux10-20.h (HAVE_PERROR): Remove.
323 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
324 Remove dummy definition, as this problem was obsolete long ago.
327 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
329 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
331 Avoid calls to strlen in font processing functions.
332 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
333 (font_open_by_name): Change to use length argument. Adjust
335 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
337 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
338 Change to return ptrdiff_t.
339 (xfont_list_pattern, xfont_match): Use length returned by
340 xfont_decode_coding_xlfd.
341 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
343 2012-07-11 Glenn Morris <rgm@gnu.org>
345 * s/darwin.h, s/freebsd.h, s/netbsd.h:
346 Move DONT_REOPEN_PTY to configure.
348 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
349 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
351 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
353 Remove "#define unix" that is no longer needed (Bug#11905).
354 * s/aix4-2.h (unix): Remove; no longer needed.
356 EMACS_TIME simplification (Bug#11875).
357 This replaces macros (which typically do not work in GDB)
358 with functions, typedefs and enums, making the code easier to debug.
359 The functional style also makes code easier to read and maintain.
360 * systime.h: Include <sys/time.h> on all hosts, not just if
361 WINDOWSNT, since 'struct timeval' is needed in general.
362 (EMACS_TIME): Now a typedef, not a macro.
363 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
365 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
366 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
367 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
368 (EMACS_TIME_LE): Now functions, not macros.
369 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
370 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
371 which are not functions. All uses rewritten to use:
372 (make_emacs_time): New function.
373 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
374 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
375 not functions. All uses rewritten to use the following, respectively:
376 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
377 (add_emacs_time, sub_emacs_time): New functions.
378 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
379 * fileio.c (Fcopy_file):
380 * xterm.c (XTflash): Get the current time closer to when it's used.
381 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
383 * bytecode.c (targets): Suppress -Woverride-init warnings.
385 Simplify by avoiding confusing use of strncpy etc.
386 * doc.c (Fsnarf_documentation):
387 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
388 * frame.c (Fmake_terminal_frame):
389 * gtkutil.c (get_utf8_string):
391 * nsmenu.m (ns_update_menubar):
392 * regex.c (regerror):
393 Prefer memcpy to strncpy and strncat when either will do.
394 * fileio.c (Fsubstitute_in_file_name):
395 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
396 (menu_separator_name_p):
397 * nsmenu.m (ns_update_menubar):
398 Prefer memcmp to strncmp when either will do.
399 * nsterm.m: Include <ftoastr.h>.
401 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
402 Prefer snprintf to strncpy.
403 * nsterm.m (ns_term_init):
404 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
405 * nsterm.m (ns_term_init):
406 Avoid the need for strncpy, by using build_string or
407 make_unibyte_string directly. Use dtoastr, not snprintf.
408 * process.c (Fmake_network_process): Diagnose service names that
409 are too long, rather than silently truncating them or creating
410 non-null-terminated names.
411 (Fnetwork_interface_info): Likewise, for interface names.
412 * sysdep.c (system_process_attributes) [GNU_LINUX]:
413 Prefer sprintf to strncat.
414 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
415 Prefer vsnprintf to vsprintf + strncpy.
417 2012-07-10 Glenn Morris <rgm@gnu.org>
419 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
420 Clarify fallback case.
422 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
424 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
425 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
426 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
427 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
428 where argument type is known to be a Lisp_Cons.
430 2012-07-10 Tom Tromey <tromey@redhat.com>
432 * bytecode.c (BYTE_CODE_THREADED): New macro.
433 (BYTE_CODES): New macro. Replaces all old byte-code defines.
434 (enum byte_code_op): New type.
435 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
436 (exec_byte_code): Use them. Use token threading when applicable.
438 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
440 Optimize pure C strings initialization.
441 * lisp.h (make_pure_string): Fix prototype.
442 (build_pure_c_string): New function, defined as static inline. This
443 provides a better opportunity to optimize away calls to strlen when
444 the function is called with compile-time constant argument.
445 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
446 argument, adjust users accordingly. Use build_pure_c_string where
448 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
449 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
450 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
452 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
454 Avoid calls to strlen in miscellaneous functions.
455 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
456 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
457 * lread.c (openp): Likewise.
459 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
461 Avoid calls to strlen in path processing functions.
462 * fileio.c (file_name_as_directory): Add comment. Change to add
463 srclen argument and return the length of result. Adjust users
465 (directory_file_name): Fix comment. Change to add srclen argument,
466 swap 1st and 2nd arguments to obey the common convention. Adjust
468 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
470 2012-07-10 Glenn Morris <rgm@gnu.org>
472 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
473 Move PENDING_OUTPUT_COUNT definition to configure.
475 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
476 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
477 * s/gnu.h (DATA_START): Move definitions to configure.
479 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
480 We include usg5-4-common.h, which defines them both.
482 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
483 O_RDONLY already includes it).
485 Stop ns builds setting the EMACSLOADPATH environment variable.
486 * nsterm.m (ns_load_path): Rename from ns_init_paths.
487 Now it does not set EMACSLOADPATH, just returns the load-path string.
488 * nsterm.h: Update accordingly.
489 * lread.c [HAVE_NS]: Include nsterm.h.
490 (init_lread) [HAVE_NS]: Use ns_load_path.
491 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
493 2012-07-09 Glenn Morris <rgm@gnu.org>
495 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
496 since the included bsd-common.h does so.
498 Stop ns builds setting the EMACSPATH environment variable.
499 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
500 (ns_init_paths): Do not set EMACSPATH.
501 * nsterm.h (ns_exec_path): Add it.
502 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
505 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
507 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
509 * process.c (wait_reading_process_output): 'waitchannels' was unset
510 when read_kbd || !NILP (wait_for_cell); fix this.
512 Add GCC-style 'const' attribute to functions that can use it.
513 * character.h (char_resolve_modifier_mask):
514 * keyboard.h (make_ctrl_char):
515 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
516 (init_character_once, next_almost_prime, init_fns, init_image)
517 (flush_pending_output, init_sound):
518 * mem-limits.h (start_of_data):
519 * menu.h (finish_menu_items):
521 * emacs.c (DEFINE_DUMMY_FUNCTION):
522 Declare the dummy function with ATTRIBUTE_CONST.
523 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
524 Add decls with ATTRIBUTE_CONST.
526 Minor improvements to make_formatted_string.
527 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
528 where int is good enough, as vsprintf returns an int.
529 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
531 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
533 Use make_formatted_string to avoid double length calculation.
534 * lisp.h (make_formatted_string): New prototype.
535 * alloc.c (make_formatted_string): New function.
536 * buffer.c (Fgenerate_new_buffer_name): Use it.
537 * dbus.c (syms_of_dbusbind): Likewise.
538 * editfns.c (Fcurrent_time_zone): Likewise.
539 * filelock.c (get_boot_time): Likewise.
540 * frame.c (make_terminal_frame, set_term_frame_name)
541 (x_report_frame_params): Likewise.
542 * image.c (gs_load): Likewise.
543 * minibuf.c (get_minibuffer): Likewise.
544 * msdos.c (dos_set_window_size): Likewise.
545 * process.c (make_process): Likewise.
546 * xdisp.c (ensure_echo_area_buffers): Likewise.
547 * xsettings.c (apply_xft_settings): Likewise.
549 2012-07-09 Glenn Morris <rgm@gnu.org>
551 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
552 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
553 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
554 * nsterm.h (ns_etc_directory): Add it.
555 * callproc.c [HAVE_NS]: Include nsterm.h.
556 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
558 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
560 Move marker debugging code under MARKER_DEBUG.
561 * marker.c (MARKER_DEBUG): Move marker debugging code under
562 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
563 for bootstrap with --enable-checking (~3x slowdown reported
564 by Juanma Barranquero <lekktu@gmail.com>).
565 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
567 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
569 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
570 See <http://bugs.gnu.org/11825#29>.
572 2012-07-08 Eli Zaretskii <eliz@gnu.org>
574 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
575 has no font, use the frame's font. (Bug#11813)
576 (display_line): Add commentary about displaying truncation glyphs
578 (produce_special_glyphs): Move here from term.c.
580 * term.c (produce_special_glyphs): Move to xdisp.c.
582 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
585 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
587 * xdisp.c (display_line): Avoid warning about implicit declaration
590 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
592 * lisp.h: Remove empty conditional.
594 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
596 * lread.c (load_path_check): Now static.
598 Fix some minor --with-ns problems found by static checking.
599 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
600 (x_set_font) [!HAVE_X_WINDOWS]:
601 * image.c (xpm_load_image) [HAVE_NS]:
602 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
603 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
605 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
606 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
607 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
608 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
609 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
610 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
611 Fix pointer signedness problem.
612 * xfaces.c (FRAME_X_FONT_TABLE):
613 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
615 2012-07-07 Glenn Morris <rgm@gnu.org>
617 * lread.c (load_path_check): New function, split from init_lread.
618 (init_lread): Reorganize. Motivation:
619 If EMACSLOADPATH is set, check/warn about that rather than the
620 defaults, which we are not going to use. Hence we can remove
621 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
622 Don't warn if site-lisp directories are missing.
623 If not installed, start from a blank load-path, since
624 PATH_LOADSEARCH refers to the eventual installation directories.
626 2012-07-07 Eli Zaretskii <eliz@gnu.org>
628 Support truncation and continuation glyphs on GUI frames, when
629 fringes are disabled. (Bug#11832)
630 * xdisp.c (init_iterator): Get dimensions of truncation and
631 continuation glyphs even if on GUI frames. Adjust
632 it->last_visible_x on GUI frames when the left or right fringes,
634 (start_display, move_it_in_display_line_to): Handle the case of a
635 GUI frame without a fringe to display continuation or truncation
637 (insert_left_trunc_glyphs): Support GUI frames: make sure
638 truncation glyphs overwrite enough glyphs from the current line to
639 have sufficient space in pixels.
640 (display_line): Support truncation and continuation glyphs on GUI
641 frames. If some spare pixels are left on the line after inserting
642 the truncation glyphs, fill that space with a stretch glyph of a
643 suitably computed width.
645 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
646 produce_glyphs, to support GUI sessions.
648 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
650 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
652 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
654 Do not require float-time's arg to fit in time_t (Bug#11825).
655 This works better on hosts where time_t is unsigned, and where
656 float-time is applied to the (negative) difference between two times.
657 * editfns.c (decode_time_components): Last arg is now double *,
658 not int *, and means to store all the result as a double, without
659 worrying about whether the seconds part fits in time_t.
661 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
663 (Ffloat_time): Do not fail merely because the specified time falls
664 outside of time_t range.
666 2012-07-07 Glenn Morris <rgm@gnu.org>
668 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
669 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
670 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
672 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
674 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
677 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
679 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
681 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
682 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
683 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
684 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
685 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
686 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
688 * xfont.c (compare_font_names): Redo to omit the need for casts.
690 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
692 * xfns.c (Fx_change_window_property): Doc fix.
693 * w32fns.c (Fx_change_window_property): Doc fix.
695 * w32fns.c (Fx_window_property): Accept the same arguments as the
696 X Windows version. Doc fix.
697 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
699 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
700 Eli Zaretskii <eliz@gnu.org>
702 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
703 Windows-specific code from nt/config.nt moved here.
704 Obsolete settings removed.
706 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
708 * process.c: Avoid unnecessary calls to gettime.
709 (wait_reading_process_output): Don't get the time of day
710 when gobbling data immediately and not waiting, as there's no need
711 for it in that case. This removes a FIXME.
713 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
715 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
716 is defined (Bug#11768).
718 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
720 Fix marker debugging code.
721 * marker.c (byte_char_debug_check): Do not perform the check
722 if buffer is not multibyte.
723 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
724 Call byte_char_debug_check with correct arguments.
726 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
728 Compile marker debugging code only if ENABLE_CHECKING is defined.
729 * marker.c (byte_char_debug_check, count_markers):
730 Use only if ENABLE_CHECKING is defined.
731 (byte_debug_flag): Remove.
732 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
733 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
735 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
737 Avoid code repetition in marker-related functions.
738 * marker.c (attach_marker): New function.
739 (Fset_marker, set_marker_restricted, set_marker_both)
740 (set_marker_restricted_both): Use it.
741 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
742 Consistently rename charno to charpos.
743 (marker_position): Add eassert.
744 (marker_byte_position): Convert to eassert.
746 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
748 Simplify list operations in unchain_overlay and unchain_marker.
749 * buffer.c (unchain_overlay): Simplify. Add comment.
750 * marker.c (unchain_marker): Simplify. Fix comments.
752 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
754 Introduce fast path for the widely used marker operation.
755 * alloc.c (build_marker): New function.
756 * lisp.h (build_marker): New prototype.
757 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
758 * composite.c (autocmp_chars): Likewise.
759 * editfns.c (buildmark): Remove.
760 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
761 (save_restriction_save): Use build_marker.
762 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
763 * window.c (save_window_save): Likewise.
765 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
767 Do not use Fdelete_overlay in delete_all_overlays
768 to avoid redundant calls to unchain_overlay.
769 * buffer.c (drop_overlay): New function.
770 (delete_all_overlays, Fdelete_overlay): Use it.
771 * minibuf.c (get_minibuffer): Fix comment.
773 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
775 Port to OpenBSD 5.1 amd64.
776 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
777 This is needed for OpenBSD, and should be harmless on all BSD systems.
778 Also, include <sys/sysctl.h>, as it should be available on all
779 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
780 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
781 use p_pid member, not kp_proc.pid.
783 2012-07-06 Glenn Morris <rgm@gnu.org>
785 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
787 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
789 More xmalloc and related cleanup.
790 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
791 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
792 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
793 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
794 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
795 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
796 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
797 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
798 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
800 Omit needless casts involving void * pointers and allocation.
801 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
802 as the former is more robust if P's type is changed.
803 Prefer xzalloc to xmalloc + memset 0.
804 Simplify malloc-or-realloc to realloc.
805 Don't worry about xmalloc returning a null pointer.
806 Prefer xstrdup to xmalloc + strcpy.
807 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
809 * keyboard.c (apply_modifiers_uncached): Prefer local array to
810 alloca of a constant.
812 2012-07-05 Eli Zaretskii <eliz@gnu.org>
814 * xdisp.c (display_line): Fix horizontal pixel coordinates when
815 hscroll is larger than the line width. Fixes long and futile
816 looping inside extend_face_to_end_of_line (on a TTY) producing
817 glyphs that are not needed and thrown away.
819 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
821 * marker.c (set_marker_restricted_both): Simplify by using
824 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
826 * editfns.c (region_limit): Simplify by using clip_to_bounds.
828 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
830 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
831 not defined (Bug#11768).
832 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
833 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
834 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
835 followed by gtk_box_set_homogeneous (Bug#11768).
836 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
837 (update_theme_scrollbar_width, xg_create_scroll_bar):
838 Use gtk_scrollbar_new (Bug#11768).
839 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
840 (is_box_type): New function (Bug#11768).
841 (xg_tool_item_stale_p): Call is_box_type.
842 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
843 with default display (Bug#11768).
845 2012-07-05 Eli Zaretskii <eliz@gnu.org>
847 * xdisp.c (window_hscroll_limited): New function.
848 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
849 coordinates when window's hscroll is set to insanely large
852 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
854 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
855 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
857 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
860 * lisp.h (xzalloc): New prototype. Omit needless casts.
861 * alloc.c (xzalloc): New function. Omit needless casts.
862 * charset.c: Omit needless casts. Convert all calls to
863 xmalloc with following memset to xzalloc.
864 * dispnew.c: Likewise.
865 * fringe.c: Likewise.
869 * w32fns.c: Likewise.
870 * w32font.c: Likewise.
871 * w32term.c: Likewise.
872 * xfaces.c: Likewise.
875 * atimer.c: Omit needless casts.
876 * buffer.c: Likewise.
877 * callproc.c: Likewise.
879 * coding.c: Likewise.
880 * composite.c: Likewise.
882 * doprnt.c: Likewise.
883 * editfns.c: Likewise.
886 * filelock.c: Likewise.
888 * gtkutil.c: Likewise.
889 * keyboard.c: Likewise.
892 * minibuf.c: Likewise.
895 * process.c: Likewise.
896 * region-cache.c: Likewise.
897 * search.c: Likewise.
898 * sysdep.c: Likewise.
899 * termcap.c: Likewise.
900 * terminal.c: Likewise.
901 * tparam.c: Likewise.
902 * w16select.c: Likewise.
904 * w32reg.c: Likewise.
905 * w32select.c: Likewise.
906 * w32uniscribe.c: Likewise.
907 * widget.c: Likewise.
911 * xselect.c: Likewise.
913 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
915 * fileio.c (time_error_value): Check the right error number.
916 Problem reported by Troels Nielsen in
917 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
919 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
921 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
922 This should be fixed in a better way; see Eli Zaretskii in
923 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
924 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
926 * fileio.c (time_error_value): Rename from special_mtime.
927 The old name's problems were noted by Eli Zaretskii in
928 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
930 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
931 This variable's comment says Emacs needs at least one GDB-visible
932 symbol of type enum pvec_type, to work around GDB problems.
933 The symbol's value doesn't matter.
935 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
936 that causes compilation to fail on pre-C99 compilers.
938 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
940 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
941 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
943 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
945 * buffer.c (init_buffer_once): Fix initialization of
946 headers for buffer_defaults and buffer_local_symbols.
947 Reported by Juanma Barranquero <lekktu@gmail.com>.
949 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
951 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
952 * lisp.h (enum pvec_type): Use fewer bits.
953 (PSEUDOVECTOR_SIZE_BITS): New constant.
954 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
955 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
957 (PSEUDOVECTOR_TYPEP): New macro.
958 (TYPED_PSEUDOVECTORP): Use it.
959 * fns.c (internal_equal): Adapt code to extract pvectype.
960 * emacs.c (gdb_pvec_type): Update type.
961 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
962 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
963 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
964 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
965 (sweep_vectors): Use it. Use local var `total_bytes' instead of
966 abusing vector->header.next.nbytes.
967 (live_vector_p): Use PVEC_TYPE.
968 (mark_object): Adapt code to extract pvectype. Use switch.
970 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
972 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
973 Tighten new eassert a bit.
975 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
977 Fix compilation with --enable-gcc-warnings and -O1
979 * doprnt.c (doprnt): Change type of tem to int, initialize
980 to avoid compiler warning. Add eassert.
981 * search.c (simple_search): Initialize match_byte to avoid
982 compiler warning. Add eassert.
984 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
986 Avoid weird behavior with large horizontal scrolls.
987 Without this change, for example, large hscroll values would
988 mess up Emacs's display on Fedora 15 x86, presumably due to
989 overflows in int calculations in the display code.
990 Also, if buffers had long lines, Emacs would freeze.
991 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
992 (set_window_hscroll): New function, containing the old guts of
993 Fset_window_hscroll. Return the clipped value.
994 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
995 This avoids the need to check against PTRDIFF_MAX.
997 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
999 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1001 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1003 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1005 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1006 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1007 since GCC 4.4.6 issues a bogus warning for them.
1009 Fix bugs in file timestamp newness comparisons.
1010 * fileio.c (Ffile_newer_than_file_p):
1011 * lread.c (Fload): Use full timestamp resolution of files,
1012 not just the 1-second resolution, so that files that are only
1013 slightly newer still count as newer.
1014 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1015 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1017 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1019 * fileio.c: Improve handling of file time marker. (Bug#11852)
1020 (special_mtime): New function.
1021 (Finsert_file_contents, Fverify_visited_file_modtime):
1022 Use it to set special mtime values consistently.
1024 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1026 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1027 marker for non-existing file. (Bug#11852)
1029 2012-07-03 Glenn Morris <rgm@gnu.org>
1031 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1032 and did not make it into globals.h).
1034 2012-07-03 Tom Tromey <tromey@redhat.com>
1036 * window.c (Fset_window_margins, Fset_window_fringes)
1037 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1038 * textprop.c (Fprevious_property_change): No longer static.
1039 * syntax.c (Fsyntax_table_p): No longer static.
1040 * process.c (Fget_process, Fprocess_datagram_address): No longer
1042 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1043 * keyboard.c (Fcommand_execute): No longer static.
1045 * insdel.c (Fcombine_after_change_execute): No longer static.
1046 * image.c (Finit_image_library): No longer static.
1047 * fileio.c (Fmake_symbolic_link): No longer static.
1048 * eval.c (Ffetch_bytecode): No longer static.
1049 * editfns.c (Fuser_full_name): No longer static.
1050 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1052 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1054 * dired.c (Ffile_attributes): No longer static.
1055 * composite.c (Fcomposition_get_gstring): No longer static.
1056 * callproc.c (Fgetenv_internal): No longer static.
1058 * ccl.h: Remove EXFUNs.
1059 * buffer.h: Remove EXFUNs.
1060 * dispextern.h: Remove EXFUNs.
1061 * intervals.h: Remove EXFUNs.
1062 * fontset.h: Remove EXFUN.
1063 * font.h: Remove EXFUNs.
1064 * dosfns.c (system_process_attributes): Remove EXFUN.
1065 * keymap.h: Remove EXFUNs.
1066 * lisp.h: Remove EXFUNs.
1067 * w32term.h: Remove EXFUNs.
1068 * window.h: Remove EXFUNs.
1069 * xsettings.h: Remove EXFUN.
1070 * xterm.h: Remove EXFUN.
1072 2012-07-03 Glenn Morris <rgm@gnu.org>
1074 * lisp.h (Frandom): Make it visible to C.
1075 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1076 buffer for invisible buffers. (Bug#1229)
1078 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1080 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1081 values which aren't power of 2.
1082 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1083 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1086 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1088 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1090 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1092 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1094 * alloc.c (allocate_vector_block): Remove redundant
1095 calls to mallopt if DOUG_LEA_MALLOC is defined.
1096 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1097 avoid calls to mallopt if zero_vector is returned.
1099 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1101 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1102 is enabled, avoid dereferencing NULL current_sblock if
1105 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1107 Cleanup basic buffer management.
1108 * buffer.h (struct buffer): Change layout to use generic vector
1109 marking code. Fix some comments. Change type of 'clip_changed'
1110 to bitfield. Remove unused #ifndef old.
1111 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1112 (GET_OVERLAYS_AT): Fix indentation.
1113 (for_each_per_buffer_object_at): New macro.
1114 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1115 (Fbuffer_local_variables): Use it.
1116 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1117 * alloc.c (allocate_buffer): Adjust to match new layout of
1118 struct buffer. Fix comment.
1119 (mark_overlay): New function.
1120 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1121 Lisp area of struct buffer.
1122 (mark_object): Use it. Adjust marking of misc objects
1123 and related comments.
1125 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1127 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1128 wrapper that is not needed because the wrapped code is a no-op (zero
1129 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1130 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1132 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1134 * alloc.c (mark_buffer): Simplify. Remove prototype.
1135 (mark_object): Add comment. Reorganize marking of vector-like
1136 objects. Use CHECK_LIVE for all vector-like objects except buffers
1137 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1138 redundant calls to mark_vectorlike for bool vectors.
1140 2012-06-30 Glenn Morris <rgm@gnu.org>
1142 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1144 * epaths.in (PATH_SITELOADSEARCH): New.
1145 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1146 This is rather than relying on --enable-locallisppath elements
1147 having "site-lisp" in their names. (Bug#10208#25, 11658)
1149 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1151 * w32proc.c (sys_select): Accept and ignore one more argument.
1153 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1155 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1156 (pselect) [!MS_DOS]: Redirect to sys_select.
1158 * sysdep.c: Don't include dos.h and dosfns.h.
1160 * process.c (sys_select):
1161 * msdos.c (sys_select): Accept one more argument and ignore it.
1163 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1164 adapt data types and code to that.
1167 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1168 which clashes with the gnulib function of the same name.
1170 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1172 * font.c (font_style_to_value, font_style_symbolic)
1173 (font_prop_validate_style): Add type checks for values in
1176 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1178 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1181 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1183 * xdisp.c (try_window_id): Undo last change.
1185 * w32.c (getwd): Adjust commentary about startup_dir.
1186 (init_environment): Always call sys_access, even in non-MSVC
1187 builds. Don't chdir to the directory of the Emacs executable.
1188 This undoes code from 1997 which was justified by the need to
1189 "avoid conflicts when removing and renaming directories". But its
1190 downside was that every relative file name was being interpreted
1191 relative to the directory of the Emacs executable, which can never
1192 be TRT. In particular, it broke sys_access when called with
1193 relative file names.
1194 (sys_access): Map GetLastError to errno.
1196 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1198 * window.h (struct window): Change type of 'fringes_outside_margins'
1199 to bitfield. Fix comment. Adjust users accordingly.
1200 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1202 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1205 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1207 * gnutls.c (emacs_gnutls_handshake):
1208 Add QUIT to make the loop interruptible.
1210 2012-06-29 Glenn Morris <rgm@gnu.org>
1212 * charset.c (init_charset): Make lack of etc/charsets fatal.
1214 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1216 * editfns.c (region_limit): Fix type mismatch.
1218 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1220 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1221 undefined. Convert from xassert to eassert.
1222 * nsmenu.m: Convert from xassert to eassert.
1223 * nsterm.m: Likewise.
1225 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1227 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1229 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1231 Avoid integer overflow on scroll-left and scroll-right.
1232 * window.c (HSCROLL_MAX): New macro.
1233 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1234 overflow when requested scroll falls outside ptrdiff_t range.
1236 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1238 * window.h (struct window): Change type of 'hscroll',
1239 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1240 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1241 Adjust users accordingly.
1242 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1243 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1244 from EMACS_INT to ptrdiff_t.
1245 (make_window): Omit redundant initialization.
1247 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1249 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1251 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1253 * window.h (struct window): Change type of 'use_time' and
1254 'sequence_number' from Lisp_Object to int.
1255 * frame.c (make_frame): Adjust users accordingly.
1256 * print.c (print_object): Likewise.
1257 * window.c (select_window, Fwindow_use_time, make_parent_window)
1258 (make_window): Likewise.
1260 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1262 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1263 enabled with --enable-checking=[all,glyphs] configure option.
1264 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1265 adjust comments accordingly.
1266 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1267 undefined, adjust comments accordingly.
1268 * image.c: Likewise.
1269 * scroll.c: Likewise.
1270 * w32fns.c: Likewise.
1271 * w32term.c: Likewise.
1272 * xdisp.c: Likewise.
1273 * xfaces.c: Likewise.
1275 * xterm.c: Likewise.
1277 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1279 Generalize run-time debugging checks.
1280 * dispextern.h (XASSERTS): Remove.
1281 * fontset.c (xassert): Remove.
1282 Convert from xassert to eassert.
1283 * alloc.c: Convert from xassert to eassert.
1285 * dispnew.c: Likewise.
1287 * fringe.c: Likewise.
1288 * ftfont.c: Likewise.
1289 * gtkutil.c: Likewise.
1290 * image.c: Likewise.
1291 * keyboard.c: Likewise.
1293 * process.c: Likewise.
1294 * scroll.c: Likewise.
1295 * sound.c: Likewise.
1297 * w32console.c: Likewise.
1298 * w32fns.c: Likewise.
1299 * w32term.c: Likewise.
1300 * window.c: Likewise.
1301 * xdisp.c: Likewise.
1302 * xfaces.c: Likewise.
1304 * xselect.c: Likewise.
1305 * xterm.c: Likewise.
1307 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1309 * fns.c (maybe_resize_hash_table): Output message when growing the
1312 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1314 * alloc.c (allocate_string_data): Remove dead code.
1315 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1316 avoid GCC warning about unused macro.
1318 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1320 * alloc.c (allocate_string): Omit intervals initialization.
1321 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1322 as in make_pure_string and make_pure_c_string.
1324 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1326 * alloc.c (allocate_string): Fix last change.
1328 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1330 * alloc.c (allocate_string): Remove two redundant calls
1331 to memset, add explicit initialization where appropriate.
1333 2012-06-27 Glenn Morris <rgm@gnu.org>
1335 * lisp.mk (lisp): Remove paths.elc.
1337 2012-06-27 Chong Yidong <cyd@gnu.org>
1339 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1341 2012-06-26 John Wiegley <johnw@newartisans.com>
1343 * unexmacosx.c (copy_data_segment): Add two section names used
1344 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1346 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1347 when building with Clang.
1349 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1351 * eval.c (Fapply): Allow calling it with a single argument.
1353 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1355 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1356 _stricmp and _strnicmp.
1357 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1359 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1361 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1363 (allocate_process): Likewise for new process.
1364 (allocate_terminal): Change to use offsetof.
1365 (allocate_frame): Likewise.
1366 * frame.c (make_frame): Omit redundant initialization.
1367 * window.c (make_parent_window): Use memset.
1368 (make_window): Omit redundant initialization.
1369 * process.c (make_process): Omit redundant initialization.
1370 * terminal.c (create_terminal): Likewise.
1372 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1374 * term.c (delete_tty): Remove redundant call to memset.
1376 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1378 * alloc.c: Remove build_string.
1379 * lisp.h: Define build_string as static inline. This provides
1380 a better opportunity to optimize away calls to strlen when the
1381 function is called with compile-time constant argument.
1382 * image.c (imagemagick_error): Convert to build_string.
1383 * w32proc.c (sys_spawnve): Likewise.
1384 * xterm.c (x_term_init): Likewise.
1386 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1388 Use sprintf return value instead of invoking strlen on result.
1389 In the old days this wasn't portable, since some sprintf
1390 implementations returned char *. But they died out years ago and
1391 Emacs already assumes sprintf returns int.
1392 Similarly for float_to_string.
1393 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1394 * ccl.c (ccl_driver):
1395 * character.c (string_escape_byte8):
1396 * data.c (Fnumber_to_string):
1397 * doprnt.c (doprnt):
1398 * print.c (print_object):
1399 * xdisp.c (message_dolog):
1400 * xfns.c (syms_of_xfns):
1401 Use sprintf or float_to_string result to avoid need to call strlen.
1402 * data.c (Fnumber_to_string):
1403 Use make_unibyte_string, since the string must be ASCII.
1404 * lisp.h, print.c (float_to_string): Now returns int length.
1405 * term.c (produce_glyphless_glyph):
1406 Use sprintf result rather than recomputing it.
1408 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1409 * Makefile.in (ALL_CFLAGS):
1410 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1411 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1413 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1415 * dispextern.h (xstrcasecmp): Define to library function
1416 strcasecmp if available.
1417 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1419 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1421 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1422 Avoid comma operator.
1423 * menu.c (push_submenu_start, push_submenu_end)
1424 (push_left_right_boundary, push_menu_pane): Likewise.
1425 * msdos.c (dos_rawgetc): Likewise.
1427 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1429 * xfns.c (xic_create_fontsetname): Remove redundant calls
1432 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1434 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1435 sprintf already null-terminates its output.
1437 * xfns.c (x_window): Remove redundant cast.
1439 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1441 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1442 `const char *' to `char *' to avoid compiler warning.
1444 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1446 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1447 instead of truncating it to 63 (admittedly a generous limit).
1449 * process.c: Fix spelling and caps in comments.
1451 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1453 * emacs.c (setpgrp): Remove definition, unused.
1454 * sysdep.c (setpgrp): Remove definition, not used in this file.
1456 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1458 * makefile.w32-in: Update dependencies.
1460 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1462 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1463 (SYSTIME_H): Add nt/inc/sys/time.h.
1465 * systime.h [WINDOWSNT]: Include sys/time.h.
1467 * s/ms-w32.h (struct timespec): Definition moved from
1468 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1470 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1472 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1473 * buffer.h (buffer_slot_type_mismatch):
1474 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1475 * eval.c (unwind_to_catch):
1476 * image.c (my_png_error, my_error_exit):
1477 * keyboard.c (quit_throw_to_read_char, user_error)
1478 (Fexit_recursive_edit, Fabort_recursive_edit):
1479 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1480 (wrong_type_argument, buffer_overflow, __executable_start)
1481 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1482 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1483 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1485 (child_setup) [!DOS_NT]:
1486 * lread.c (end_of_file_error, invalid_syntax):
1487 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1488 * puresize.h (pure_write_error):
1489 * search.c (matcher_overflow):
1490 * sound.c (sound_perror, alsa_sound_perror):
1491 * sysdep.c, syssignal.h (croak):
1492 * term.c (maybe_fatal, vfatal):
1493 * textprop.c (text_read_only):
1494 * undo.c (user_error):
1495 * unexmacosx.c (unexec_error):
1496 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1497 Use _Noreturn rather than NO_RETURN.
1498 No need for separate decl merely because of _Noreturn.
1499 * sound.c (sound_warning, parse_sound):
1500 Remove unnecessary forward decls.
1502 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1504 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1505 * lisp.h (WAIT_READING_MAX): New macro.
1506 * dispnew.c (Fsleep_for, sit_for):
1507 * keyboard.c (kbd_buffer_get_event):
1508 * process.c (Faccept_process_output):
1509 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1510 This improves on the previous patch, which introduced a bug
1511 when time_t is unsigned and as wide as intmax_t.
1512 See <http://bugs.gnu.org/9000#51>.
1514 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1516 * dispnew.c (sit_for, Fsleep_for):
1517 * keyboard.c (kbd_buffer_get_event):
1518 * process.c (Faccept_process_output): Avoid compiler warnings when
1519 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1521 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1523 * makefile.w32-in: Update dependencies.
1525 * w32.c (ltime): Add return type and declare static.
1526 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1528 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1530 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1531 Privately reported by Herbert J. Skuhra.
1532 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1534 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1535 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1537 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1539 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1540 last argument of make_unibyte_string.
1542 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1543 language ID in the event parameters.
1545 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1546 event.code, not the obscure "character set ID".
1548 2012-06-23 Chong Yidong <cyd@gnu.org>
1550 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1552 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1554 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1555 * w32.c (fdutimens): New function.
1557 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1559 * s/ms-w32.h (pselect): Redirect to sys_select.
1561 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1563 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1564 in the logic of incrementing and decrementing the value of
1565 use_relocatable_buffers.
1567 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1569 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1570 Privately reported by Herbert J. Skuhra.
1571 [__FreeBSD__]: Remove "*/" typo after "#include".
1572 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1573 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1574 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1575 Don't assume EMACS_TIME and struct timeval are the same type.
1577 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1579 Support higher-resolution time stamps (Bug#9000).
1580 The time stamps are only nanosecond-resolution at the C level,
1581 since that's the best that any real-world system supports now.
1582 But they are picosecond-resolution at the Lisp level, as that's
1583 easy, and leaves room for future OS improvements.
1585 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1588 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1589 Don't get current time unless it's needed.
1591 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1592 now provides it if it's absent.
1593 (start_atimer): Port to higher-res time stamps.
1594 Check for time stamp overflow. Don't get current time more
1595 often than is needed.
1597 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1598 Include systime.h, not time.h.
1599 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1601 * dired.c: Include stat-time.h.
1602 (Ffile-attributes): File times now have higher resolution.
1604 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1605 (struct image): Timestamp now has higher resolution.
1607 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1608 has at least microseconds now. All uses removed.
1609 (update_frame, update_single_window, update_window, update_frame_1)
1610 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1612 * editfns.c (time_overflow): Now extern.
1613 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1614 (float-time, Fformat_time_string, Fcurrent_time_string)
1615 (Fcurrent_time_zone): Accept and generate higher-resolution
1617 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1618 (decode_time_components, lisp_seconds_argument): New functions.
1619 (make_time): Now static.
1620 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1621 Report an error if the time is invalid, rather than having the caller
1624 * fileio.c: Include <stat-time.h>
1625 (Fcopy_file): Copy higher-resolution time stamps.
1626 Prefer to set the time stamp via a file descriptor if that works.
1627 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1628 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1629 (Fvisited_file_modtime, Fset_visited_file_modtime):
1630 Support higher-resolution time stamps.
1632 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1634 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1636 * image.c (prepare_image_for_display, clear_image_cache)
1637 (lookup_image): Port to higer-resolution time stamps.
1639 * keyboard.c (start_polling, bind_polling_period):
1640 Check for time stamp overflow.
1641 (read_char, kbd_buffer_get_event, timer_start_idle)
1642 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1643 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1644 Port to higher-resolution time stamps. Do not assume time_t is signed.
1645 (decode_timer): New function. Timers are now vectors of length 9,
1646 not 8, to accommodate the picosecond component.
1647 (timer_check_2): Use it.
1649 * nsterm.m (select_timeout, timeval_subtract): Remove.
1650 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1651 as they're a bit more accurate and handle overflow better.
1652 (ns_select): Change prototype to be compatible with pselect.
1653 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1654 * nsterm.h (ns_select): Adjust prototype.
1656 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1657 us-resolution time stamps.
1658 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1660 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1662 * lisp.h (time_overflow): New decl.
1663 (wait_reading_process_output): First arg is now intmax_t, not int,
1664 to accommodate larger waits.
1666 * process.h (struct Lisp_Process.read_output_delay):
1667 Now counts nanoseconds, not microseconds.
1668 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1670 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1671 (wait_reading_process_output):
1672 Port to ns-resolution time stamps.
1673 (Faccept_process_output, wait_reading_process_output):
1674 Check for time stamp overflow. Do not assume time_t is signed.
1675 (select_wrapper): Remove; we now use pselect.
1676 (Fprocess_attributes): Now generates ns-resolution time stamps.
1678 * sysdep.c: Include utimens.h. Don't include utime.h
1679 or worry about struct utimbuf; gnulib does that for us now.
1680 (gettimeofday): Remove; gnulib provides a substitute.
1681 (make_timeval): New function.
1682 (set_file_times): Now sets ns-resolution time stamps.
1683 New arg FD; all uses changed.
1684 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1685 (system_process_attributes):
1686 Now returns ns-resolution time stamp. All uses changed.
1687 Check for time stamp overflow.
1689 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1690 provides a substitute now.
1692 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1693 since it guarantees struct timespec.
1694 (EMACS_TIME): Now struct timespec, so that we can support
1695 ns-resolution time stamps.
1696 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1697 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1698 (EMACS_USECS): Remove.
1699 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1700 so multiply the arg by 1000 before storing it.
1701 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1703 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1704 Port to ns-resolution time stamps.
1705 (EMACS_TIME_NEG_P): Remove; replaced by....
1706 (EMACS_TIME_SIGN): New macro.
1707 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1708 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1709 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1710 (make_timeval, make_lisp_time, decode_time_components): New decls.
1711 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1712 that it mishandled time_t overflow. You can't compare by subtracting!
1713 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1714 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1716 * term.c: Include <sys/time.h>.
1717 (timeval_to_Time): New function, for proper overflow wraparound.
1718 (term_mouse_position, term_mouse_click): Use it.
1720 * undo.c (record_first_change): Support higher-resolution time stamps
1722 (Fprimitive_undo): Use them when restoring time stamps.
1724 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1725 (w32_get_internal_run_time):
1726 Port to higher-resolution Emacs time stamps.
1727 (ltime): Now accepts single 64-bit integer, as that's more convenient
1730 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1732 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1733 for compatibility with pselect. Support ns-resolution time stamps.
1735 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1737 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1738 Check for time stamp overflow, and support ns-resolution time stamps.
1740 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1741 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1742 (timeval_subtract): Remove; no longer needed.
1743 (XTflash, XTring_bell, x_wait_for_event):
1744 Port to ns-resolution time stamps. Don't assume time_t is signed.
1746 2012-06-22 Chong Yidong <cyd@gnu.org>
1748 * xdisp.c (x_consider_frame_title): Revert last change.
1750 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1752 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1753 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1754 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1755 staticidx goes up to 1597 out of 1600 = 0x640.)
1757 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1759 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1760 Otherwise, the umask might be mistakenly 0 while handling input signals.
1762 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1764 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1766 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1768 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1769 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1770 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1771 access to `contents' member of Lisp_Vector objects with AREF and ASET
1774 2012-06-19 Chong Yidong <cyd@gnu.org>
1776 * frame.c (delete_frame): When selecting a frame on a different
1777 text terminal, do not alter the terminal's top-frame.
1779 * xdisp.c (format_mode_line_unwind_data): Record the target
1780 frame's selected window and its terminal's top-frame.
1781 (unwind_format_mode_line): Restore them.
1782 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1784 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1785 since tty frames can be explicitly named.
1786 (prepare_menu_bars): Likewise.
1788 * term.c (Ftty_top_frame): New function.
1790 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1792 Port byte-code-meter to modern targets.
1793 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1794 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1795 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1796 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1797 (METER_1, METER_2): Simplify.
1799 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1801 * data.c (Fdefalias): Return `symbol' (bug#11686).
1803 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1805 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1806 gets killed during executing of this function (Bug#11665).
1807 Try to always return Qt when the buffer has been actually killed.
1808 (Vkill_buffer_query_functions): In doc-string say that functions
1809 run by this hook should not change the current buffer.
1811 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1813 Fix recently-introduced process.c problems found by static checking.
1814 * process.c (write_queue_push, write_queue_pop, send_process):
1815 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1816 (write_queue_pop): Fix pointer signedness problem.
1817 (send_process): Remove unused local.
1819 2012-06-17 Chong Yidong <cyd@gnu.org>
1821 * xdisp.c (redisplay_internal): No need to redisplay terminal
1822 frames that are not on top.
1824 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1826 * process.c (make_process): Initialize write_queue.
1827 (write_queue_push, write_queue_pop): New functions.
1828 (send_process): Use them to maintain correct ordering of process
1831 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1833 * lisp.h (eassert): Assume C89 or later.
1834 This removes the need for CHECK.
1835 (CHECK): Remove. Its comments about always evaluating its
1836 argument were confusing, as 'eassert' typically does not evaluate
1839 * coding.c (produce_chars): Use ptrdiff_t, not int.
1841 * xterm.c (x_draw_underwave): Check for integer overflow.
1842 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1844 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1846 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1847 referenced (Bug#11583).
1849 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1851 Implement wave-style variant of underlining.
1852 * dispextern.h (face_underline_type): New enum.
1853 (face): Add field for underline type.
1854 * nsterm.m (ns_draw_underwave): New function.
1855 (ns_draw_text_decoration): Use it.
1856 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1858 (x_draw_glyph_string): Use them.
1859 * xfaces.c (Qline, Qwave): New Lisp objects.
1860 (check_lface_attrs, merge_face_ref)
1861 (Finternal_set_lisp_face_attribute, realize_x_face):
1862 Handle wave-style underline face attributes.
1863 * xterm.c (x_draw_underwave): New function.
1864 (x_draw_glyph_string): Use it.
1866 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1868 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1869 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1870 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1871 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1872 ($(BLD)/w32select.$(O)): Update dependencies.
1874 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1876 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1877 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1878 * character.c (_fetch_multibyte_char_p): Remove.
1879 * alloc.c: Include "character.h" before "buffer.h".
1881 * buffer.c: Likewise.
1882 * bytecode.c: Likewise.
1883 * callint.c: Likewise.
1884 * callproc.c: Likewise.
1885 * casefiddle.c: Likewise.
1886 * casetab.c: Likewise.
1887 * category.c: Likewise.
1889 * coding.c: Likewise.
1890 * composite.c: Likewise.
1891 * dired.c: Likewise.
1892 * dispnew.c: Likewise.
1894 * dosfns.c: Likewise.
1895 * editfns.c: Likewise.
1896 * emacs.c: Likewise.
1897 * fileio.c: Likewise.
1898 * filelock.c: Likewise.
1900 * fontset.c: Likewise.
1901 * fringe.c: Likewise.
1902 * indent.c: Likewise.
1903 * insdel.c: Likewise.
1904 * intervals.c: Likewise.
1905 * keyboard.c: Likewise.
1906 * keymap.c: Likewise.
1907 * lread.c: Likewise.
1908 * macros.c: Likewise.
1909 * marker.c: Likewise.
1910 * minibuf.c: Likewise.
1911 * nsfns.m: Likewise.
1912 * nsmenu.m: Likewise.
1913 * print.c: Likewise.
1914 * process.c: Likewise.
1915 * regex.c: Likewise.
1916 * region-cache.c: Likewise.
1917 * search.c: Likewise.
1918 * syntax.c: Likewise.
1920 * textprop.c: Likewise.
1922 * unexsol.c: Likewise.
1923 * w16select.c: Likewise.
1924 * w32fns.c: Likewise.
1925 * w32menu.c: Likewise.
1926 * window.c: Likewise.
1927 * xdisp.c: Likewise.
1929 * xmenu.c: Likewise.
1931 * xselect.c: Likewise.
1933 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1935 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1936 If all the glyphs of the glyph row came from strings, and we have no
1937 cursor positioning clues, put the cursor on the first glyph of the
1939 (handle_face_prop): Use chunk-relative overlay string index when
1940 indexing into it->string_overlays array. (Bug#11653)
1941 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1942 the rightmost. (Bug#11720)
1944 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1946 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1947 (CATEGORY_MEMBER): Enforce 1/0 value.
1948 * category.c (_temp_category_set): Remove.
1950 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1952 * window.c (Fdelete_other_windows_internal)
1953 (Fdelete_window_internal): Don't access frame's mouse highlight
1954 info of the initial frame. (Bug#11677)
1956 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1958 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1959 Assume USE_2_TAGS_FOR_INTS.
1960 (xreload): Adjust $tagmask width to match recent lisp.h change.
1962 Simplify lisp.h in minor ways that should not affect code.
1963 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1964 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1965 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1966 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1967 (INTTYPEBITS): New macro, for clarity.
1968 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1969 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1970 Simplify now that USE_LSB_TAG is always defined.
1971 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1972 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1974 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1976 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1978 2012-06-13 Glenn Morris <rgm@gnu.org>
1980 * s/bsd-common.h (BSD4_3):
1981 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1983 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1985 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1988 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1990 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1991 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1992 * alloc.c (widen_to_Lisp_Object): Remove.
1993 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1994 * frame.c (delete_frame): Remove outdated comment.
1995 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1996 USE_LISP_UNION_TYPE.
1997 (Fw32_unregister_hot_key): Likewise.
1998 (Fw32_toggle_lock_key): Likewise.
1999 * w32menu.c (add_menu_item): Likewise.
2000 (w32_menu_display_help): Use XIL instead of checking
2001 USE_LISP_UNION_TYPE.
2002 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2003 (init_heap): Likewise.
2004 * w32term.c (w32_read_socket): Update comment.
2006 2012-06-13 Glenn Morris <rgm@gnu.org>
2008 * s/usg5-4-common.h, src/s/unixware.h:
2009 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2011 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2013 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2015 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2016 * alloc.c (make_number) [!defined make_number]:
2017 Remove, as lisp.h always defines this now.
2018 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2019 (roundup_size): Verify that it is a power of 2.
2020 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2021 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2022 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2023 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2024 USE_LSB_TAG now is always defined to be either 0 or 1.
2026 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2027 code works fine either way, and efficiency is not a concern here,
2028 as the union type is for debugging, not for production.
2029 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2030 Use an inline function on all platforms when using the union type,
2031 since this is simpler and 'static inline' can be used portably
2033 (LISP_INITIALLY_ZERO): New macro.
2034 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2035 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2037 2012-06-12 Glenn Morris <rgm@gnu.org>
2039 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2041 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2043 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2044 Move BROKEN_SIGIO to configure.
2046 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2047 Move NO_TERMIO to configure.
2049 2012-06-12 Chong Yidong <cyd@gnu.org>
2051 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2052 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2053 MagickExportImagePixels is undefined.
2055 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2057 * image.c (imagemagick_load_image): Remove unused label.
2059 2012-06-11 Glenn Morris <rgm@gnu.org>
2061 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2062 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2063 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2064 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2066 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2068 * alloc.c (make_byte_code): New function.
2069 (Fmake_byte_code): Use it. Don't purify here.
2070 * lread.c (read1): Use it as well to avoid extra allocation.
2072 2012-06-11 Chong Yidong <cyd@gnu.org>
2074 * image.c (imagemagick_load_image): Implement transparency.
2076 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2078 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2079 account for preceding backslashes. (Bug#11663)
2081 2012-06-09 Chong Yidong <cyd@gnu.org>
2083 * term.c: Support italics in capable terminals (Bug#9652).
2084 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2085 (turn_on_face): Output using TS_enter_italic_mode if available.
2086 Don't handle unused blinking and alt-charset cases.
2087 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2088 and tty_alt_charset_p cases.
2089 (tty_capable_p, init_tty): Support italics.
2091 * termchar.h (struct tty_display_info): Add field for italics.
2092 Remove unused blink field.
2094 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2097 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2098 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2099 tty_alt_charset_p. Add tty_italic_p.
2101 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2103 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2104 dbus_type_is_basic if available.
2105 (xd_extract_signed, xd_extract_unsigned): Rename from
2106 extract_signed and extract_unsigned, respectively. Adapt callers.
2108 2012-06-09 Chong Yidong <cyd@gnu.org>
2110 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2112 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2115 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2117 * xdisp.c (vmessage): Treat frame message as multibyte.
2118 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2119 would generate the diagnostic "Making \302\247 buffer-local while
2122 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2124 * dispnew.c (showing_window_margins_p): Undo last change, which
2125 was done due to an inadvertent commit.
2126 (adjust_frame_glyphs_for_frame_redisplay): Do call
2127 showing_window_margins_p.
2129 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2131 * eval.c (Fmake_var_non_special): New primitive.
2132 (syms_of_eval): Defsubr it.
2133 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2135 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2137 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2138 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2140 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2142 * alloc.c (allocate_vectorlike): Fix last change.
2144 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2146 Block-based vector allocation of small vectors.
2147 * lisp.h (struct vectorlike_header): New field `nbytes',
2148 adjust comment accordingly.
2149 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2150 to denote vector blocks. Adjust users (live_vector_p,
2151 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2152 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2153 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2154 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2155 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2156 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2157 (roundup_size): New constant.
2158 (struct vector_block): New data type.
2159 (vector_blocks, vector_free_lists, zero_vector): New variables.
2160 (all_vectors): Rename to `large_vectors'.
2161 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2162 (sweep_vectors): New functions.
2163 (allocate_vectorlike): Return `zero_vector' as the only vector of
2164 0 items. Allocate new vector from block if vector size is less than
2165 or equal to VBLOCK_BYTES_MAX.
2166 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2167 (init_alloc_once): Add call to init_vectors.
2169 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2171 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2173 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2175 * doprnt.c (doprnt): Truncate multibyte char correctly.
2176 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2177 would mishandle a string argument "Xc" if X was a multibyte
2178 character of length 2: it would truncate after X's first byte
2179 rather than including all of X.
2181 2012-06-06 Chong Yidong <cyd@gnu.org>
2183 * buffer.c (word_wrap): Doc fix.
2185 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2187 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2189 2012-06-03 Glenn Morris <rgm@gnu.org>
2191 * xdisp.c (tool-bar-style): Doc fix.
2193 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2195 * Makefile.in (PAXCTL): Define.
2196 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2197 binary via PaX flags if the paxctl utility is available.
2198 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2199 Restore PaX flags to their default. (Bug#11398)
2201 2012-06-03 Chong Yidong <cyd@gnu.org>
2203 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2206 2012-06-03 Chong Yidong <cyd@gnu.org>
2208 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2209 (note_mode_line_or_margin_highlight): If there is no help echo,
2210 use mode-line-default-help-echo. Handle the case where the mouse
2211 position is past the end of the mode line string.
2213 * buffer.c (buffer_local_value_1): New function, split from
2214 Fbuffer_local_value; can return Qunbound.
2215 (Fbuffer_local_value): Use it.
2216 (Vmode_line_format): Docstring tweaks.
2218 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2220 * sysdep.c (system_process_attributes): Improve comment.
2222 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2224 * keyboard.c: Export real-this-command to Elisp.
2225 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2226 and DEFVAR it. Update all users.
2228 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2230 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2232 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2233 Convert pctcpu and pctmem to Lisp float properly.
2234 Let the compiler fold better, as 100.0/0x8000 is exact.
2236 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2238 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2241 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2243 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2245 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2247 For a 'struct window', replace some Lisp_Object fields to
2248 bitfields where appropriate, remove unused fields.
2249 * window.h (struct window): Remove unused 'last_mark_x' and
2250 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2251 change it's type from Lisp_Object to bitfield.
2252 Change type of 'force_start', 'optional_new_start',
2253 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2254 fields from Lisp_Object to bitfield. Adjust users accordingly.
2256 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2258 Pacify gcc -Wdouble-precision when using Xaw.
2259 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2260 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2261 Use 'float' consistently, rather than 'float' in most places
2262 and 'double' in a couple of places.
2264 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2266 * xdisp.c (handle_stop): Detect whether we have overlay strings
2267 loaded by testing it->current.overlay_string_index to be
2268 non-negative, instead of checking whether n_overlay_strings is
2269 positive. (Bug#11587)
2271 2012-05-31 Chong Yidong <cyd@gnu.org>
2273 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2275 * doc.c (Fsubstitute_command_keys): Doc fix.
2277 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2279 * search.c (search_buffer): Remove calls to
2280 r_alloc_inhibit_buffer_relocation, as it is now called by
2281 maybe_unify_char, which was the cause of relocation of buffer text
2284 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2286 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2287 for the duration of call to load_charset, to avoid problems with
2288 callers of maybe_unify_char that access buffer text through C
2291 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2292 decrement the inhibition flag, instead of just setting or
2295 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2297 Remove obsolete '#define static' cruft.
2298 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2299 This #undef was "temporary" in 2000; it is no longer needed
2300 now that '#define static' has gone away.
2301 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2302 (gray_bitmap_bits): Remove; no longer needed.
2303 All uses replaced with definiens.
2304 * xterm.c: Include "bitmaps/gray.xbm".
2306 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2308 Clean up __executable_start, monstartup when --enable-profiling.
2309 The following changes affect the code only when profiling.
2310 * dispnew.c (__executable_start): Rename from safe_bcopy.
2311 Define only on platforms that need it.
2312 * emacs.c: Include <sys/gmon.h> when profiling.
2313 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2314 (__executable_start): Remove decl, since lisp.h does it now.
2315 (safe_bcopy): Remove decl; no longer has that name.
2316 (main): Coalesce #if into single bit of code, for simplicity.
2317 Cast pointers to uintptr_t, since standard libraries want integers
2319 * lisp.h (__executable_start): New decl.
2321 2012-05-31 Glenn Morris <rgm@gnu.org>
2323 * image.c (Fimagemagick_types): Doc fix.
2325 2012-05-30 Jim Meyering <meyering@redhat.com>
2327 * callproc.c (Fcall_process_region): Include directory component
2328 in mkstemp error message (Bug#11586).
2330 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2332 * alloc.c, lisp.h (make_pure_vector): Now static.
2334 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2336 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2337 Move to byte-run.el.
2338 (Fautoload): Do the hash-doc more carefully.
2339 * data.c (Fdefalias): Purify definition, except for keymaps.
2340 (Qdefun): Move from eval.c.
2341 * lisp.h (Qdefun): Remove.
2342 * lread.c (read1): Tiny simplification.
2344 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2346 Do not create empty overlays with the evaporate property (Bug#9642).
2347 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2348 Bug#9642, but explicitly check that the buffer the overlay would
2349 be moved to is live and rearrange lines to make sure that errors
2350 will not put the overlay in an inconsistent state.
2351 (Fdelete_overlay): Cosmetics.
2353 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2355 * w32term.c (my_bring_window_to_top): New function.
2356 (x_raise_frame): Use handle returned by DeferWindowPos, which
2357 could be different from the original one.
2358 Call my_bring_window_to_top instead of my_set_foreground_window.
2361 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2362 by calling BringWindowToTop.
2364 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2365 (WM_EMACS_END): Increase by one.
2367 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2369 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2370 This avoids undefined behavior that might cause the eassert
2371 to not catch an out-of-range value.
2373 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2375 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2376 Update dependencies.
2378 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2380 * bidi.c (bidi_mirror_char): Fix last change.
2382 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2384 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2385 when referring to sectname field in printf format.
2387 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2389 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2390 Only r_alloc_inhibit_buffer_relocation needed to be added;
2391 the others were already declared.
2393 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2394 before checking whether it's out of range. Put the check inside
2396 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2398 2012-05-27 Ken Brown <kbrown@cornell.edu>
2400 * callproc.c (Fcall_process): Restore a line that was accidentally
2401 commented out in the 2011-02-13 change (bug#11547).
2403 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2405 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2406 defined on ralloc.c.
2408 * buffer.c [REL_ALLOC]: Remove prototypes of
2409 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2410 they are now on lisp.h.
2412 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2414 * search.c (search_buffer): Use it to inhibit relocation of buffer
2415 text while re_search_2 is doing its job, because re_search_2 is
2416 passed C pointers to buffer text. (Bug#11519)
2418 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2421 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2422 state after an additional call to move_it_in_display_line_to, keep
2423 the values of it->max_ascent and it->max_descent found for the
2425 (pos_visible_p): Revert the comparison against bottom_y to what it
2426 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2429 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2431 Fix coding-related core dumps with gcc -ftrapv.
2432 The code was computing A - B, where A and B are pointers, and B is
2433 random garbage. This can lead to core dumps on platforms that
2434 have special pointer registers, and it also leads to core dumps on
2435 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2436 A - B only when B is initialized properly.
2437 * coding.c (coding_set_source, coding_set_destination): Return void.
2438 (coding_change_source, coding_change_destinations): New functions,
2439 with the old behaviors of coding_set_source and coding_set_destination.
2440 All callers that need an offset changed to use these new functions.
2442 2012-05-26 Glenn Morris <rgm@gnu.org>
2444 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2446 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2448 Extend mouse support on W32 text-mode console.
2449 * xdisp.c (draw_row_with_mouse_face):
2450 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2452 * w32console.c: Include window.h.
2453 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2455 (initialize_w32_display): Initialize mouse-highlight data.
2457 * w32inevt.c: Include termchar.h and window.h.
2458 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2459 moves, call note_mouse_highlight. If help_echo changed, call
2460 gen_help_event to produce help-echo message in the echo area.
2461 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2464 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2466 * lread.c (read1): Simplify slightly to avoid an overflow warning
2467 with GCC 4.7.0 on x86-64.
2469 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2471 * bidi.c (bidi_mirror_char): Revert last change: an int is
2472 definitely wide enough here.
2474 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2476 Fix integer width and related bugs (Bug#9874).
2477 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2478 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2479 (string_bytes, check_sblock, allocate_string_data):
2480 (compact_small_strings, Fmake_bool_vector, make_string)
2481 (make_unibyte_string, make_multibyte_string)
2482 (make_string_from_bytes, make_specified_string)
2483 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2484 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2487 (allocate_pseudovector):
2488 Use int, not EMACS_INT, where int is wide enough.
2489 (inhibit_garbage_collection, Fgarbage_collect):
2490 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2491 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2492 int might not be wide enough.
2493 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2494 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2495 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2496 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2497 (bidi_level_of_next_char, bidi_move_to_visually_next):
2498 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2499 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2500 (Fkill_buffer, Fset_buffer_major_mode)
2501 (advance_to_char_boundary, Fbuffer_swap_text)
2502 (Fset_buffer_multibyte, overlays_at, overlays_in)
2503 (overlay_touches_p, struct sortvec, record_overlay_string)
2504 (overlay_strings, recenter_overlay_lists)
2505 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2506 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2507 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2508 (Foverlay_recenter, last_overlay_modification_hooks_used)
2509 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2511 (validate_region): Omit unnecessary test for b <= e,
2512 since that's guaranteed by the previous test.
2513 (adjust_overlays_for_delete): Avoid pos + length overflow.
2514 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2515 (report_overlay_modification):
2516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2517 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2518 Omit pointer cast, which isn't needed anyway, and doesn't work
2519 after the EMACS_INT -> ptrdiff_t change.
2520 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2521 * buffer.h: Adjust decls to match defn changes elsewhere.
2522 (struct buffer_text, struct buffer):
2523 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2524 Use EMACS_INT, not int, where int might not be wide enough.
2525 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2526 not int, to avoid needless 32-bit limit on 64-bit hosts.
2527 (exec_byte_code): Use tighter memory-full test, one that checks
2528 for alloca overflow. Don't compute the address of the object just
2529 before an array, as that's not portable. Use EMACS_INT, not
2530 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2531 * callint.c (Fcall_interactively):
2532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2533 * callproc.c (call_process_kill, Fcall_process):
2534 Don't assume pid_t fits into an Emacs fixnum.
2535 (call_process_cleanup, Fcall_process, child_setup):
2536 Don't assume pid_t fits into int.
2537 (call_process_cleanup, Fcall_process, delete_temp_file)
2538 (Fcall_process_region):
2539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2540 (Fcall_process): Simplify handling of volatile integers.
2541 Use int, not EMACS_INT, where int will do.
2542 * casefiddle.c (casify_object, casify_region, operate_on_word)
2543 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2545 (casify_object): Avoid integer overflow when overallocating buffer.
2546 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2547 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2548 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2549 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2550 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2551 integers are now checked earlier. All uses replaced with XINT.
2553 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2554 For CCL_MapSingle, check that content and value are in int range.
2555 (ccl_driver, Fregister_code_conversion_map):
2556 Check that Vcode_version_map_vector is a vector.
2557 (resolve_symbol_ccl_program): Check that vector header is in range.
2558 Always copy the vector, so that we can check its contents reliably
2559 now rather than having to recheck each instruction as it's being
2560 executed. Check that vector words fit in 'int'.
2561 (ccl_get_compiled_code, Fregister_ccl_program)
2562 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2563 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2564 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2565 contents are in range.
2566 (Fccl_execute_on_string): Check that status is in range.
2567 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2568 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2569 Accept and return EMACS_INT, not int, because callers can pass values
2571 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2572 (multibyte_chars_in_text, parse_str_as_multibyte)
2573 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2574 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2575 (string_escape_byte8, Fget_byte):
2576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2577 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2578 avoid mishandling large integers.
2579 * character.h: Adjust decls to match defn changes elsewhere.
2580 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2581 (Ffind_charset_region):
2582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2583 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2584 (load_charset_map_from_vector, Fdefine_charset_internal):
2585 Don't assume fixnum fits in int.
2586 (load_charset_map_from_vector, Fmap_charset_chars):
2587 Remove now-unnecessary CHECK_NATNUMs.
2588 (Fdefine_charset_internal): Check ranges here, more carefully.
2589 Don't rely on undefined behavior with signed left shift overflow.
2590 Don't assume unsigned int fits into fixnum, or that fixnum fits
2591 into unsigned int. Don't require max_code to be a valid fixnum;
2592 that's not true for gb10830 4-byte on a 32-bit host. Allow
2593 invalid_code to be a cons, for the same reason. Require code_offset
2594 to be a character. Avoid int overflow if max_char is close
2596 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2597 this is intended anyway and avoids some undefined behavior.
2598 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2599 INDEX_TO_CODE_POINT, as that's what it expects.
2600 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2601 * charset.h (DECODE_CHAR): Return int, not unsigned;
2602 this is what was intended anyway, and it avoids undefined behavior.
2603 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2604 integer-overflow issues.
2605 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2606 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2607 where the argument is EMACS_INT, and this behavior is not intended.
2608 * chartab.c (Fmake_char_table, Fset_char_table_range)
2609 (uniprop_get_decoder, uniprop_get_encoder):
2610 Don't assume fixnum fits in int.
2611 * cmds.c (move_point): New function, that does the gist of
2612 Fforward_char and Fbackward_char, but does so while checking
2613 for integer overflow more accurately.
2614 (Fforward_char, Fbackward_char): Use it.
2615 (Fforward_line, Fend_of_line, internal_self_insert)
2616 (internal_self_insert):
2617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2618 Fix a FIXME, by checking for integer overflow when calculating
2619 target_clm and actual_clm.
2620 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2621 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2622 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2623 (coding_alloc_by_making_gap, alloc_destination)
2624 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2625 (encode_coding_utf_16, detect_coding_emacs_mule)
2626 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2627 (detect_coding_iso_2022, decode_coding_iso_2022)
2628 (encode_invocation_designation, encode_designation_at_bol)
2629 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2630 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2631 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2632 (encode_coding_ccl, encode_coding_raw_text)
2633 (detect_coding_charset, decode_coding_charset)
2634 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2635 (produce_composition, produce_charset, produce_annotation)
2636 (decode_coding, handle_composition_annotation)
2637 (handle_charset_annotation, consume_chars, decode_coding_gap)
2638 (decode_coding_object, encode_coding_object, detect_coding_system)
2639 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2640 (code_convert_region, code_convert_string)
2641 (Fdefine_coding_system_internal)
2642 (coding_set_source, coding_set_destination):
2643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2644 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2645 (Fdefine_coding_system_internal):
2646 Don't assume fixnums fit in int.
2647 (decode_coding_gap, decode_coding_object, encode_coding_object)
2648 (Fread_coding_system, Fdetect_coding_region)
2649 (Funencodable_char_position, Fcheck_coding_systems_region)
2650 (get_translation, handle_composition_annotation, consume_chars):
2651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2652 (consume_chars): Rewrite to not calculate an address outside buffer.
2653 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2654 Don't access memory outside of the args array.
2655 (Fdefine_coding_system_internal): Check for charset-id overflow.
2656 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2657 result of ENCODE_CHAR.
2658 * coding.h: Adjust decls to match defn changes elsewhere.
2659 (struct coding_system):
2660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2661 * composite.c (get_composition_id, find_composition)
2662 (run_composition_function, update_compositions)
2663 (compose_text, composition_gstring_put_cache)
2664 (composition_gstring_p, composition_gstring_width)
2665 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2666 (composition_compute_stop_pos, composition_reseat_it)
2667 (composition_update_it, struct position_record)
2668 (find_automatic_composition, composition_adjust_point)
2669 (Fcomposition_get_gstring, Ffind_composition_internal):
2670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2671 (update_compositions):
2672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2673 * composite.h: Adjust decls to match defn changes elsewhere.
2674 (struct composition):
2675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2676 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2677 Do not attempt to compute the address of the object just before a
2678 buffer; this is not portable.
2680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2681 (Faset): Use int, not EMACS_INT, where int is wide enough.
2682 (Fstring_to_number): Don't assume fixnums fit in int.
2683 (Frem): Don't assume arg is nonnegative.
2684 * dbusbind.c (xd_append_arg): Check for integers out of range.
2685 (Fdbus_call_method): Don't overflow the timeout int.
2686 (extract_signed, extract_unsigned): New functions.
2687 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2688 (xd_get_connection_references): Return ptrdiff_t, not int.
2690 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2691 (xd_read_message_1):
2692 Use int, not unsigned, where the dbus API uses int.
2693 (Fdbus_message_internal): Don't overflow mtype.
2694 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2695 * dired.c (directory_files_internal, file_name_completion, scmp)
2696 (file_name_completion_stat):
2697 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2698 (file_name_completion): Don't overflow matchcount.
2699 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2700 * dispextern.h: Adjust decls to match defn changes elsewhere.
2701 (struct text_pos, struct glyph, struct bidi_saved_info)
2702 (struct bidi_string_data, struct bidi_it, struct composition_it)
2704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2705 (struct display_pos, struct composition_it, struct it):
2706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2707 * dispnew.c (increment_matrix_positions)
2708 (increment_row_positions, mode_line_string)
2709 (marginal_area_string):
2710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2711 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2713 (duration_to_sec_usec): New function, to check for overflow better.
2714 (Fsleep_for, sit_for): Use it.
2715 * doc.c (get_doc_string, store_function_docstring):
2716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2717 (get_doc_string, Fsnarf_documentation):
2718 Use int, not EMACS_INT, where int is wide enough.
2720 Use SAFE_ALLOCA, not alloca.
2721 Check for overflow when converting EMACS_INT to off_t.
2722 * doprnt.c (doprnt):
2723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2724 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2725 Don't assume uid_t fits into fixnum.
2726 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2727 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2728 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2729 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2730 (general_insert_function)
2731 (Finsert_char, make_buffer_string, make_buffer_string_both)
2732 (update_buffer_properties, Fbuffer_substring)
2733 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2734 (Fsubst_char_in_region, check_translation)
2735 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2736 (transpose_markers, Ftranspose_regions):
2737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2738 (clip_to_bounds): Move to lisp.h as an inline function).
2739 (Fconstrain_to_field): Don't assume integers are nonnegative.
2740 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2741 (Fsubst_char_in_region, Fsave_restriction):
2742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2743 (Femacs_pid): Don't assume pid_t fits into fixnum.
2744 (lo_time): Use int, not EMACS_INT, when int suffices.
2745 (lisp_time_argument): Check for usec out of range.
2746 (Fencode_time): Don't assume fixnum fits in int.
2747 (Fuser_login_name, Fuser_full_name): Signal an error
2748 if a uid argument is out of range, rather than relying on
2750 (Fformat_time_string): Remove now-unnecessary check.
2751 lisp_time_argument checks for out-of-range usec now.
2752 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2753 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2754 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2755 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2756 (init_cmdargs, Fdump_emacs):
2757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2758 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2759 the bottom (typically) 32 bits of the fixnum.
2760 * eval.c (specpdl_size, call_debugger):
2761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2762 (when_entered_debugger, Fbacktrace_debug):
2763 Don't assume fixnum can fit in int.
2764 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2765 the object just before a buffer; this is not portable.
2766 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2767 (grow_specpdl, unbind_to):
2768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2769 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2770 (grow_specpdl): Simplify allocation by using xpalloc.
2771 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2772 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2773 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2775 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2777 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2778 (Fcopy_file, non_regular_nbytes, read_non_regular)
2779 (Finsert_file_contents):
2780 Use int, not EMACS_INT, where int is wide enough.
2781 (READ_BUF_SIZE): Verify that it fits in int.
2782 (Finsert_file_contents): Check that counts are in proper range,
2783 rather than assuming fixnums fit into ptrdiff_t etc.
2784 Don't assume fixnums fit into int.
2785 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2786 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2787 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2788 (string_char_to_byte, string_byte_to_char)
2789 (string_make_multibyte, string_to_multibyte)
2790 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2791 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2792 (substring_both, Fdelete, internal_equal, Ffillarray)
2793 (Fclear_string, mapcar1)
2794 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2795 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2796 (larger_vector, make_hash_table, maybe_resize_hash_table)
2797 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2798 (Fmaphash, secure_hash):
2799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2800 (concat): Check for string index and length overflow.
2801 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2803 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2804 (larger_vector): New API (vec, incr_min, size_max) replaces old
2805 one (vec, new_size, init). This catches size overflow.
2806 INIT was removed because it was always Qnil.
2807 All callers changed.
2808 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2809 the upper bound on a hash table index size.
2810 (make_hash_table, maybe_resize_hash_table): Use it.
2811 (secure_hash): Computer start_byte and end_byte only after
2812 they're known to be in ptrdiff_t range.
2813 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2814 (Ffont_get_glyphs, Ffont_at):
2815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2816 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2817 (Flist_fonts, Fopen_font):
2818 Don't assume fixnum can fit in int.
2819 (check_gstring): Don't assume index can fit in int.
2820 (font_match_p): Check that fixnum is a character, not a nonnegative
2821 fixnum, since the later code needs to stuff it into an int.
2822 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2823 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2824 conversion overflow issues.
2825 (Fopen_font): Check for integer out of range.
2826 (Ffont_get_glyphs): Don't assume index can fit in int.
2827 * font.h: Adjust decls to match defn changes elsewhere.
2828 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2830 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2831 printmax_t, where ptrdiff_t is wide enough.
2832 (Finternal_char_font):
2833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2834 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2835 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2836 (Fset_frame_position, x_set_frame_parameters)
2837 (x_set_line_spacing, x_set_border_width)
2838 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2839 Check that fixnums are in proper range for system types.
2840 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2842 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2843 Use SAFE_ALLOCA_LISP, not alloca.
2844 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2845 intptr_t is wide enough.
2846 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2847 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2848 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2849 Check for fixnum out of range.
2850 * ftfont.c (ftfont_list): Don't assume index fits in int.
2851 Check that fixnums are in proper range for system types.
2852 (ftfont_shape_by_flt):
2853 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2854 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2855 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2856 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2857 Check that fixnums are in proper range for system types.
2858 * gnutls.h: Adjust decls to match defn changes elsewhere.
2859 * gtkutil.c (xg_dialog_run):
2860 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2861 (update_frame_tool_bar):
2862 Check that fixnums are in proper range for system types.
2863 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2864 (lookup_image): Check that fixnums are in range for system types.
2865 * indent.c (last_known_column, last_known_column_point):
2866 (current_column_bol_cache):
2867 (skip_invisible, current_column, check_display_width):
2868 (check_display_width, scan_for_column, current_column_1)
2869 (Findent_to, Fcurrent_indentation, position_indentation)
2870 (indented_beyond_p, Fmove_to_column, compute_motion):
2871 (Fcompute_motion, Fvertical_motion):
2872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2873 (last_known_column_modified): Use EMACS_INT, not int.
2874 (check_display_width):
2876 Check that fixnums and floats are in proper range for system types.
2877 (compute_motion): Don't assume index or fixnum fits in int.
2878 (compute_motion, Fcompute_motion):
2879 Use int, not EMACS_INT, when it is wide enough.
2880 (vmotion): Omit local var start_hpos that is always 0; that way
2881 we don't need to worry about overflow in expressions involving it.
2882 * indent.h: Adjust decls to match defn changes elsewhere.
2884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2885 Use int, not EMACS_INT, where int is wide enough.
2886 Remove unused members ovstring_chars_done and tab_offset;
2888 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2889 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2890 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2891 (make_gap, copy_text, insert, insert_and_inherit)
2892 (insert_before_markers, insert_before_markers_and_inherit)
2893 (insert_1, count_combining_before, count_combining_after)
2894 (insert_1_both, insert_from_string)
2895 (insert_from_string_before_markers, insert_from_string_1)
2896 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2897 (adjust_after_replace, adjust_after_insert, replace_range)
2898 (replace_range_2, del_range, del_range_1, del_range_byte)
2899 (del_range_both, del_range_2, modify_region)
2900 (prepare_to_modify_buffer, signal_before_change)
2901 (signal_after_change, Fcombine_after_change_execute):
2902 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2903 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2904 (balance_an_interval, split_interval_right, split_interval_left)
2905 (find_interval, next_interval, update_interval)
2906 (adjust_intervals_for_insertion, delete_node, delete_interval)
2907 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2908 (static_offset_intervals, offset_intervals)
2909 (merge_interval_right, merge_interval_left, make_new_interval)
2910 (graft_intervals_into_buffer, temp_set_point_both)
2911 (temp_set_point, set_point, adjust_for_invis_intang)
2912 (set_point_both, move_if_not_intangible, get_property_and_range)
2913 (get_local_map, copy_intervals, copy_intervals_to_string)
2914 (compare_string_intervals, set_intervals_multibyte_1):
2915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2916 * intervals.h: Adjust decls to match defn changes elsewhere.
2918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2919 * keyboard.c (this_command_key_count, this_single_command_key_start)
2920 (before_command_key_count, before_command_echo_length, echo_now)
2921 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2922 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2923 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2924 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2926 (last_non_minibuf_size, last_point_position, echo_truncate)
2927 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2928 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2929 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2930 (stuff_buffered_input):
2931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2932 (last_auto_save, command_loop_1, read_char):
2933 Use EMACS_INT, not int, to avoid integer overflow.
2934 (record_char): Avoid overflow in total_keys computation.
2935 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2936 * keyboard.h: Adjust decls to match defn changes elsewhere.
2937 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2938 (Fkey_description, Fdescribe_vector, Flookup_key):
2939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2940 (click_position): New function, to check that positions are in range.
2941 (Fcurrent_active_maps):
2943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2944 (Faccessible_keymaps, Fkey_description):
2945 (preferred_sequence_p):
2946 Don't assume fixnum can fit into int.
2947 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2948 Check for integer overflow in size calculations.
2949 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2950 avoid mishandling large integers.
2951 * lisp.h: Adjust decls to match defn changes elsewhere.
2952 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2953 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2954 (struct Lisp_Marker):
2955 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2956 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2957 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2958 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2959 All callers changed.
2960 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2961 Assume the arg has valid form, since it always does.
2962 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2963 unsigned integer system type.
2964 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2965 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2966 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2967 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2968 (duration_to_sec_usec): New decl.
2969 * lread.c (read_from_string_index, read_from_string_index_byte)
2970 (read_from_string_limit, readchar, unreadchar, openp)
2971 (read_internal_start, read1, oblookup):
2972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2973 (Fload, readevalloop, Feval_buffer, Feval_region):
2974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2975 (openp): Check for out-of-range argument to 'access'.
2976 (read1): Use int, not EMACS_INT, where int is wide enough.
2977 Don't assume fixnum fits into int.
2978 Fix off-by-one error that can read outside a buffer.
2979 (read_filtered_event): Use duration_to_sec_usec
2980 to do proper overflow checking on durations.
2981 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2982 in size calculation.
2983 (Fexecute_kbd_macro):
2984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2985 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2986 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2987 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2988 (set_marker_both, set_marker_restricted_both, marker_position)
2989 (marker_byte_position, Fbuffer_has_markers_at):
2990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2991 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2992 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2993 It now merely ensures that the menu is large enough, without
2994 necessarily growing it, as this avoids some integer overflow issues.
2995 All callers changed.
2996 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2997 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2998 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2999 Use SAFE_ALLOCA_LISP, not alloca.
3000 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3001 to EMACS_INT. Check that fixnums are in proper range for system types.
3002 * minibuf.c (minibuf_prompt_width, string_to_object)
3003 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3004 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3005 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3006 (get_minibuffer, read_minibuf_unwind):
3007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3008 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3009 this simplifies overflow checking. All callers changed.
3010 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3012 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3013 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3014 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3015 Check that fixnums are in proper range for system types.
3016 (Fx_create_frame, Fx_show_tip):
3017 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3018 * nsfont.m (ns_findfonts, nsfont_list_family):
3019 Don't assume fixnum fits in long.
3020 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3021 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3022 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3024 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3026 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3027 (PRINTDECLARE, PRINTPREPARE):
3028 (strout, print_string):
3029 (print, print_preprocess, print_check_string_charset_prop)
3031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3033 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3035 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3036 (printchar, strout): Use xpalloc to catch size calculation overflow.
3037 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3038 (print_error_message): Use SAFE_ALLOCA, not alloca.
3039 (print_object): Use int, not EMACS_INT, where int is wide enough.
3040 (print_depth, new_backquote_output, print_number_index):
3041 Use ptrdiff_t, not int, where int might not be wide enough.
3042 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3043 (Fset_process_window_size, Fformat_network_address)
3044 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3046 Check that fixnums are in proper range for system types.
3047 (Fsignal_process): Simplify by avoiding a goto.
3048 Check for process-ids out of pid_t range rather than relying on
3050 (process_tick, update_tick): Use EMACS_INT, not int.
3051 (Fformat_network_address, read_process_output, send_process)
3052 (Fprocess_send_region, status_notify):
3053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3054 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3055 (wait_reading_process_output, read_process_output, exec_sentinel):
3056 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3057 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3058 (Faccept_process_output): Use duration_to_sec_usec to do proper
3059 overflow checking on durations.
3060 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3061 Don't assume pid_t fits in int.
3062 * process.h (struct Lisp_Process): Members tick and update_tick
3063 are now of type EMACS_INT, not int.
3064 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3065 configured --with-wide-int.
3066 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3067 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3068 * search.c (looking_at_1, string_match_1):
3069 (fast_string_match, fast_c_string_match_ignore_case)
3070 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3071 (scan_newline, find_before_next_newline, search_command)
3072 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3073 (set_search_regs, wordify):
3076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3077 (string_match_1, search_buffer, set_search_regs):
3079 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3080 (wordify): Check for overflow in size calculation.
3081 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3082 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3083 Check that fixnums are in proper range for system types.
3084 * sound.c (struct sound_device)
3085 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3086 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3087 (Fplay_sound_internal):
3088 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3089 * syntax.c (struct lisp_parse_state, find_start_modiff)
3090 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3091 (Fparse_partial_sexp):
3092 Don't assume fixnums can fit in int.
3093 (struct lisp_parse_state, find_start_pos, find_start_value)
3094 (find_start_value_byte, find_start_begv)
3095 (update_syntax_table, char_quoted, dec_bytepos)
3096 (find_defun_start, prev_char_comend_first, back_comment):
3097 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3098 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3099 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3100 (Finternal_describe_syntax_value): Check that match_lisp is a
3101 character, not an integer, since the code stuffs it into int.
3102 (scan_words, scan_sexps_forward):
3103 Check that fixnums are in proper range for system types.
3105 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3106 (scan_sexps_forward):
3107 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3108 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3109 * syntax.h: Adjust decls to match defn changes elsewhere.
3110 (struct gl_state_s):
3111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3112 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3113 MOST_POSITIVE_FIXNUM.
3114 * sysdep.c (wait_for_termination_1, wait_for_termination)
3115 (interruptible_wait_for_termination, mkdir):
3116 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3117 (emacs_read, emacs_write):
3118 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3119 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3120 and double all fit in int.
3121 * term.c (set_tty_color_mode):
3122 Check that fixnums are in proper range for system types.
3123 * termhooks.h (struct input_event):
3124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3125 * textprop.c (validate_interval_range, interval_of)
3126 (Fadd_text_properties, set_text_properties_1)
3127 (Fremove_text_properties, Fremove_list_of_text_properties)
3128 (Ftext_property_any, Ftext_property_not_all)
3129 (copy_text_properties, text_property_list, extend_property_ranges)
3130 (verify_interval_modification):
3131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3132 (Fnext_single_char_property_change)
3133 (Fprevious_single_char_property_change):
3134 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3135 (copy_text_properties):
3136 Check for integer overflow in index calculation.
3137 * undo.c (last_boundary_position, record_point, record_insert)
3138 (record_delete, record_marker_adjustment, record_change)
3139 (record_property_change):
3140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3141 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3143 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3144 (Fx_hide_tip, Fx_file_dialog):
3145 * w32menu.c (set_frame_menubar):
3146 Use ptrdiff_t, not int, for consistency with rest of code.
3147 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3148 (select_window, Fdelete_other_windows_internal)
3149 (window_scroll_pixel_based, window_scroll_line_based)
3150 (Frecenter, Fset_window_configuration):
3151 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3152 (Fset_window_hscroll, run_window_configuration_change_hook)
3153 (set_window_buffer, temp_output_buffer_show, scroll_command)
3154 (Fscroll_other_window, Frecenter):
3155 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3156 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3157 Don't assume fixnum fits in int.
3158 (Fset_window_scroll_bars):
3159 Check that fixnums are in proper range for system types.
3160 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3161 (string_pos, c_string_pos, number_of_chars, init_iterator)
3162 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3163 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3164 (compute_display_string_end, handle_face_prop)
3165 (face_before_or_after_it_pos, handle_invisible_prop)
3166 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3167 (display_prop_intangible_p, string_buffer_position_lim)
3168 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3169 (get_overlay_strings_1, get_overlay_strings)
3170 (iterate_out_of_display_property, forward_to_next_line_start)
3171 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3172 (get_next_display_element, set_iterator_to_next)
3173 (get_visually_first_element, compute_stop_pos_backwards)
3174 (handle_stop_backwards, next_element_from_buffer)
3175 (move_it_in_display_line_to, move_it_in_display_line)
3176 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3177 (add_to_log, message_dolog, message_log_check_duplicate)
3178 (message2, message2_nolog, message3, message3_nolog
3179 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3180 (current_message_1, truncate_echo_area, truncate_message_1)
3181 (set_message, set_message_1, store_mode_line_noprop)
3182 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3183 (text_outside_line_unchanged_p, check_point_in_composition)
3184 (reconsider_clip_changes)
3185 (redisplay_internal, set_cursor_from_row, try_scrolling)
3186 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3187 (redisplay_window, find_last_unchanged_at_beg_row)
3188 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3189 (trailing_whitespace_p, find_row_edges, display_line)
3190 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3191 (display_mode_element, store_mode_line_string)
3192 (pint2str, pint2hrstr, decode_mode_spec)
3193 (display_count_lines, display_string, draw_glyphs)
3194 (x_produce_glyphs, x_insert_glyphs)
3195 (rows_from_pos_range, mouse_face_from_buffer_pos)
3196 (fast_find_string_pos, mouse_face_from_string_pos)
3197 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3199 (safe_call, init_from_display_pos, handle_fontified_prop)
3200 (handle_single_display_spec, load_overlay_strings)
3201 (with_echo_area_buffer, setup_echo_area_for_printing)
3202 (display_echo_area, echo_area_display)
3203 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3204 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3205 (redisplay_window, dump_glyph_row, display_mode_line)
3206 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3207 (handle_display_spec, display_prop_string_p):
3208 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3209 (handle_single_display_spec, build_desired_tool_bar_string)
3210 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3211 (get_specified_cursor_type):
3212 Check that fixnums are in proper range for system types.
3213 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3214 (Flookup_image_map):
3215 Don't assume fixnums fit in int.
3216 (compare_overlay_entries):
3217 Avoid mishandling comparisons due to subtraction overflow.
3218 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3219 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3220 (handle_tool_bar_click):
3221 Use int, not unsigned, since we prefer signed and the signedness
3222 doesn't matter here.
3223 (get_next_display_element, next_element_from_display_vector):
3224 Use int, not EMACS_INT, when int is wide enough.
3225 (start_hourglass): Use duration_to_sec_usec to do proper
3226 overflow checking on durations.
3227 * xfaces.c (Fbitmap_spec_p):
3228 Check that fixnums are in proper range for system types.
3229 (compare_fonts_by_sort_order):
3230 Avoid mishandling comparisons due to subtraction overflow.
3231 (Fx_family_fonts, realize_basic_faces):
3232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3234 Don't assume fixnum fits in int.
3235 Use SAFE_ALLOCA_LISP, not alloca.
3236 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3237 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3238 (face_at_buffer_position, face_for_overlay_string)
3239 (face_at_string_position):
3240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3241 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3242 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3244 Check that fixnums are in proper range for system types.
3245 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3246 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3248 (Fx_change_window_property): Don't assume fixnums fit in int.
3249 * xfont.c (xfont_chars_supported):
3250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3251 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3252 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3253 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3254 * xml.c (parse_region):
3255 * xrdb.c (magic_file_p):
3256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3257 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3258 (x_get_local_selection, x_reply_selection_request)
3259 (x_handle_selection_request, wait_for_property_change):
3260 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3261 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3262 short is wide enough.
3263 (x_send_client_event): Don't assume fixnum fits in int.
3264 * xterm.c (x_x_to_emacs_modifiers):
3265 Don't assume EMACS_INT overflows nicely into int.
3266 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3268 (handle_one_xevent): NATNUMP can eval its arg twice.
3269 (x_connection_closed):
3270 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3271 * xterm.h: Adjust decls to match defn changes elsewhere.
3272 (struct scroll_bar): Use struct vectorlike_header
3273 rather than rolling our own approximation.
3274 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3276 2012-05-25 Glenn Morris <rgm@gnu.org>
3278 * lisp.mk (lisp): Update for more files being compiled now.
3280 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3282 * lread.c: Remove `read_pure' which makes no difference.
3283 (read_pure): Remove var.
3284 (unreadpure): Remove function.
3285 (readevalloop): Don't call read_list with -1 flag.
3286 (read1, read_vector): Don't test read_pure any more.
3287 (read_list): Simplify.
3289 * fileio.c, character.h: Minor style tweaks.
3291 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3293 * window.h (clip_changed): Remove useless declaration.
3295 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3297 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3298 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3300 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3303 This directory predates autoconf and is no longer needed nowadays.
3304 Move its few remaining bits of functionality to where they're needed.
3305 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3306 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3307 * m/template.h: Remove.
3308 * Makefile.in (M_FILE): Remove. All uses removed.
3309 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3310 * lisp.h (USE_LSB_TAG):
3311 * mem-limits.h (EXCEEDS_LISP_PTR):
3312 Use VAL_MAX, not VALBITS, in #if.
3313 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3314 (EMACS_UINT): Define unconditionally now.
3315 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3316 (BITS_PER_EMACS_INT): New constants, replacing
3317 what used to be in config.h, but not useful in #if.
3318 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3319 define them any more.
3320 (VAL_MAX): New macro.
3322 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3323 BITS_PER_EMACS_INT, in #if.
3324 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3325 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3326 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3327 * s/ms-w32.h (DATA_START):
3328 Move here from removed file m/intel386.h.
3329 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3330 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3332 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3334 Assume C89 or later.
3335 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3336 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3338 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3339 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3340 * textprop.c, tparam.c (NULL): Remove.
3341 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3342 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3343 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3344 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3345 * xterm.c (input_signal_count): Assume volatile works.
3347 2012-05-21 Ken Brown <kbrown@cornell.edu>
3349 * xgselect.c (xg_select): Fix first argument in call to 'select'
3352 2012-05-20 Ken Brown <kbrown@cornell.edu>
3354 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3355 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3357 2012-05-19 Ken Brown <kbrown@cornell.edu>
3359 * xfns.c (x_in_use): Remove `static' qualifier.
3360 * xterm.h (x_in_use): Declare.
3361 * xgselect.c: Include xterm.h.
3362 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3363 and `display_arg' (bug#9754).
3365 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3367 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3369 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3370 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3372 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3374 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3376 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3377 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3379 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3380 reference to image_cache->refcount.
3381 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3383 2012-05-17 Juri Linkov <juri@jurta.org>
3385 * search.c (Fword_search_regexp, Fword_search_backward)
3386 (Fword_search_forward, Fword_search_backward_lax)
3387 (Fword_search_forward_lax): Move functions to isearch.el
3388 (bug#10145, bug#11381).
3390 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3392 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3394 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3396 * lread.c (init_obarray): Declare Qt and Qnil as special.
3398 2012-05-14 Glenn Morris <rgm@gnu.org>
3400 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3401 Put "libexec" before "bin", for the sake of init_callproc_1.
3403 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3405 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3407 * unexaix.c: Port to more-recent AIX compilers.
3408 (report_error, report_error_1, make_hdr, copy_sym)
3409 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3410 Make arguments const char *, not char *, to avoid violations of C
3411 standard and to fix some AIX warnings reported by Gilles Pion.
3413 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3415 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3416 already have overlays loaded.
3417 (handle_single_display_spec): Before returning without displaying
3418 fringe bitmap, synchronize the bidi iterator with the main display
3419 iterator, by calling iterate_out_of_display_property.
3420 (iterate_out_of_display_property): Detect buffer iteration by
3421 testing that it->string is a Lisp string.
3422 (get_next_display_element): When the current object is exhausted,
3423 and there's something on it->stack, call set_iterator_to_next to
3424 proceed with what's on the stack, instead of returning zero.
3425 (set_iterator_to_next): If called at the end of a Lisp string,
3426 proceed to consider_string_end without incrementing string
3427 position. Don't increment display vector index past the end of
3428 the display vector. (Bug#11417)
3429 (pos_visible_p): Don't report a position visible when move_it_to
3430 stopped at the last line of window, which happens to be scanned
3431 backwards by the bidi iteration. (Bug#11464)
3433 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3435 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3436 and right-margin display specs even if the spec is invalid or we
3437 are on a TTY, and thus unable to display on the fringes.
3438 That's because the text with the property will not be displayed anyway,
3439 so we need to signal to the caller that this is a "replacing"
3440 display spec. This fixes display when the spec is invalid or we
3443 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3445 * unexaix.c (make_hdr): Fix typo in prototype.
3446 This bug broke the build on AIX. Problem reported by Gilles Pion.
3448 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3450 * keyboard.c (kbd_buffer_get_event): Read special events also in
3451 batch mode. (Bug#11415)
3453 2012-05-12 Glenn Morris <rgm@gnu.org>
3455 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3457 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3459 * lisp.mk (lisp): Add newcomment.elc.
3461 2012-05-12 Glenn Morris <rgm@gnu.org>
3463 * Makefile.in (MKDIR_P): New, set by configure.
3464 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3466 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3468 Remove unused function hourglass_started.
3469 * dispextern.h (hourglass_started):
3470 * w32fns.c (hourglass_started):
3471 * xdisp.c (hourglass_started): Remove.
3473 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3475 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3476 Update dependencies.
3478 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3480 * xgselect.c (xg_select): Put maxfds+1 into a var.
3481 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3483 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3485 2012-05-10 Dave Abrahams <dave@boostpro.com>
3487 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3488 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3490 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3492 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3493 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3494 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3495 Initialize xd_registered_buses.
3497 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3499 Untag more efficiently if USE_LSB_TAG.
3500 This is based on a proposal by YAMAMOTO Mitsuharu in
3501 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3502 For an admittedly artificial (nth 8000 longlist) benchmark on
3503 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3504 Emacs's overall text size by 1%.
3505 * lisp.h (XUNTAG): New macro.
3506 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3507 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3508 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3509 * eval.c (Fautoload):
3510 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3511 * frame.h (XFRAME): Use XUNTAG.
3513 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3514 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3515 Remove unportable assumptions about print widths of types like
3517 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3518 intptr_t when converting between pointer and integer, to avoid GCC
3519 warnings about wrong width.
3521 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3523 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3524 stack for each reader_thread, instead of defaulting to 8MB
3525 determined by the linker. This avoids failures in creating
3526 subprocesses on Windows 7, see the discussion in this thread:
3527 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3529 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3531 Fix up display of the *Minibuf-0* buffer in the mini window.
3532 * keyboard.c (read_char): Don't clear the echo area if there's no
3534 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3535 contents of *Minibuf-0*) if there's no message displayed in its stead.
3537 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3539 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3542 2012-05-06 Chong Yidong <cyd@gnu.org>
3544 * lisp.mk (lisp): Update.
3546 2012-05-05 Jim Meyering <meyering@redhat.com>
3548 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3550 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3552 * data.c (PUT_ERROR): New macro.
3553 (syms_of_data): Use it. Add new error type `user-error'.
3554 * undo.c (user_error): New function.
3555 (Fprimitive_undo): Use it.
3556 * print.c (print_error_message): Adjust print style for `user-error'.
3557 * keyboard.c (user_error): New function.
3558 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3560 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3562 Do not limit current-time-string to years 1000..9999.
3563 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3564 (Fcurrent_time_string): Support any year that is supported by the
3565 underlying localtime representation. Don't use asctime, as it
3566 has undefined behavior for years outside the range -999..9999.
3568 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3570 Fix race conditions involving setenv, gmtime, localtime, asctime.
3571 Without this fix, interrupts could mess up code that uses these
3572 nonreentrant functions, since setting TZ invalidates existing
3573 tm_zone or tzname values, and since most of these functions return
3574 pointers to static storage.
3575 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3576 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3577 Grow the critical sections to include not just invoking
3578 localtime/gmtime, but also accessing these functions' results
3579 including their tm_zone values if any, and any related TZ setting.
3580 (format_time_string): Last arg is now struct tm *, not struct tm **,
3581 so that the struct tm is saved in the critical section.
3582 All callers changed. Simplify allocation of initial buffer, partly
3583 motivated by the fact that memory allocation needs to be outside
3584 the critical section.
3586 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3588 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3589 with RESET_INTERVAL.
3591 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3592 Remove duplicated buffer name initialization.
3594 2012-05-02 Jim Meyering <jim@meyering.net>
3596 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3598 * xfns.c (x_window): Use xstrdup (Bug#11375).
3600 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3602 * xdisp.c (pos_visible_p): If already at a newline from the
3603 display string before the 'while' loop, don't walk back the glyphs
3604 from it3.glyph_row. Solves assertion violation when the display
3605 string begins with a newline (egg.el). (Bug#11367)
3607 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3609 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3612 2012-05-01 Glenn Morris <rgm@gnu.org>
3614 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3615 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3616 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3617 All were removed before 23.1.
3619 * dispnew.c: Remove HAVE_LIBNCURSES test;
3620 it is always true on relevant platforms.
3622 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3623 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3625 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3627 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3629 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3630 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3633 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3635 Do not avoid creating empty evaporating overlays (Bug#9642).
3636 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3637 That is, do not delete an evaporating overlay if it becomes
3638 empty after its bounds are adjusted to fit within its buffer.
3639 This fix caused other problems, and I'm reverting it until we get
3640 to the bottom of them.
3642 2012-04-27 Chong Yidong <cyd@gnu.org>
3644 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3646 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3648 * xdisp.c (pos_visible_p): If the window start position is beyond
3649 ZV, start the display from buffer beginning. Prevents assertion
3650 violation in init_iterator when the minibuffer window is scrolled
3653 * window.c (window_scroll_pixel_based): Likewise.
3655 2012-04-27 Chong Yidong <cyd@gnu.org>
3657 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3659 2012-04-27 Glenn Morris <rgm@gnu.org>
3661 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3662 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3664 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3666 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3667 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3669 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3671 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3672 display element, check also the underlying string or buffer
3673 character. (Bug#11341)
3675 * w32menu.c: Include w32heap.h.
3676 (add_menu_item): If the call to AppendMenuW (via
3677 unicode_append_menu) fails, disable Unicode menus only if we are
3678 running on Windows 9X/Me.
3680 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3682 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3683 (xgetint): Add missing shift for LSB tags.
3685 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3687 * keyboard.c (read_char): Don't wipe echo area for select window
3688 events: These might get delayed via `mouse-autoselect-window'
3691 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3693 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3694 manipulation of :loaded-from data.
3696 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3698 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3699 now a cons (bug#11311).
3701 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3703 Do not create empty overlays with the evaporate property (Bug#9642).
3704 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3705 if it becomes empty after its bounds are adjusted to fit within
3706 its buffer. Without this fix, in a nonempty buffer (let ((o
3707 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3708 yields an empty overlay that has the evaporate property, which is
3709 not supposed to happen.
3711 Fix minor GTK3 problems found by static checking.
3712 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3713 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3714 (struct _EmacsFixedClass, emacs_fixed_get_type):
3715 Move decls here from emacsgtkfixed.h, since they needn't be public.
3716 (emacs_fixed_get_type): Now static.
3717 (emacs_fixed_class_init): Omit unused local.
3718 (emacs_fixed_child_type): Remove; unused.
3719 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3720 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3721 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3722 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3723 (EMACS_FIXED_GET_CLASS): Remove; unused.
3724 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3726 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3727 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3729 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3731 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3732 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3733 (__malloc_size_t, __malloc_ptrdiff_t):
3734 Remove. All uses removed, replaced by the definiens if needed,
3735 since we can assume C89 or better now.
3736 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3737 (protect_malloc_state, align, get_contiguous_space)
3738 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3739 (malloc_atfork_handler_child, malloc_enable_thread)
3740 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3741 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3742 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3743 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3744 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3745 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3746 Define using prototypes, not old style.
3747 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3748 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3749 (align): Don't assume that signed integer overflow wraps around.
3750 Omit unused local var.
3751 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3752 (_free_internal_nolock, memalign, mallochook, reallochook):
3753 Omit no-longer-needed casts.
3754 (valloc): Use getpagesize, not __getpagesize.
3755 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3756 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3758 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3760 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3762 Move functions from C to Lisp. Make non-blocking method calls
3763 the default. Implement further D-Bus standard interfaces.
3765 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3766 (QCdbus_request_name_allow_replacement)
3767 (QCdbus_request_name_replace_existing)
3768 (QCdbus_request_name_do_not_queue)
3769 (QCdbus_request_name_reply_primary_owner)
3770 (QCdbus_request_name_reply_in_queue)
3771 (QCdbus_request_name_reply_exists)
3772 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3773 (QCdbus_registered_serial, QCdbus_registered_method)
3774 (QCdbus_registered_signal): New Lisp objects.
3775 (XD_DEBUG_MESSAGE): Use sizeof.
3776 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3777 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3778 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3779 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3780 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3781 (xd_signature, xd_append_arg): Allow float for integer types.
3782 (xd_get_connection_references): New function.
3783 (xd_get_connection_address): Rename from xd_initialize.
3784 Return cached address.
3785 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3786 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3788 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3789 Return number of refcounts.
3790 (Fdbus_get_unique_name): Make stronger parameter check.
3791 (Fdbus_message_internal): New defun.
3792 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3793 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3794 (Fdbus_send_signal, Fdbus_register_service)
3795 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3796 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3797 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3798 (Vdbus_compiled_version, Vdbus_runtime_version)
3799 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3800 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3801 (Vdbus_message_type_signal): New defvars.
3802 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3805 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3807 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3808 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3809 Do not assume ptrdiff_t is the same width as 'int'.
3811 * alloc.c: Handle unusual debugging option combinations.
3812 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3813 since the two debugging options are incompatible.
3814 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3816 (mem_init, mem_insert, mem_insert_fixup):
3817 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3818 (NEED_MEM_INSERT): Remove; no longer needed.
3820 2012-04-22 Leo Liu <sdl.web@gmail.com>
3822 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3824 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3826 * sysdep.c [__FreeBSD__]: Minor cleanups.
3827 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3828 Use Emacs indenting style more consistently. Avoid some casts.
3829 Use 'double' consistently rather than mixing 'float' and 'double'.
3831 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3833 * sysdep.c (list_system_processes, system_process_attributes):
3834 Add implementation for FreeBSD (Bug#5243).
3836 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3838 * lisp.mk (lisp): Update.
3840 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3842 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3843 It is never used otherwise.
3845 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3847 * print.c (print_preprocess): Only check print_depth if print-circle
3849 (print_object): Check for cycles even when print-circle is nil and
3850 print-gensym is t, but only check print_depth if print-circle is nil.
3852 2012-04-20 Chong Yidong <cyd@gnu.org>
3854 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3855 set the status to "failed" and ensure that sentinel is run.
3857 2012-04-20 Glenn Morris <rgm@gnu.org>
3859 * process.c (Fset_process_inherit_coding_system_flag)
3860 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3861 (Fmake_network_process, Fmake_serial_process): Doc fix.
3863 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3865 * xdisp.c (string_buffer_position_lim): Limit starting position to
3867 (set_cursor_from_row): If called for a mode-line or header-line
3868 row, return zero immediately.
3869 (try_cursor_movement): If inside continuation line, don't back up
3870 farther than the first row after the header line, if any.
3871 Don't consider the header-line row as "partially visible", even if
3872 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3874 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3876 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3879 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3880 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3882 configure: new option --enable-gcc-warnings (Bug#11207)
3883 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3884 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3885 (ALL_CFLAGS): Use new macros rather than old.
3886 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3887 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3888 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3889 -Wunused-result, -Wunused-variable. This should go away once
3890 the Emacs and Gnulib regex code is merged.
3891 (xmalloc, xrealloc): Now static.
3893 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3895 * dired.c (Fsystem_groups): Remove unused local.
3897 2012-04-17 Glenn Morris <rgm@gnu.org>
3899 * dired.c (Fsystem_users): Doc fix.
3901 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3903 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3904 (syms_of_dired): Add them.
3906 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3908 Fix minor alloc.c problems found by static checking.
3909 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3910 New extern decls, to avoid calling undeclared functions.
3911 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3912 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3913 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3914 (NEED_MEM_INSERT): New macro.
3915 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3916 Remove one incorrect comment and fix another.
3918 Fix minor ralloc.c problems found by static checking.
3919 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3920 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3921 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3922 (r_alloc_sbrk): Now static.
3924 Improve ralloc.c interface checking.
3925 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3926 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3927 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3928 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3929 [REL_ALLOC]: ... to here, to check interface.
3930 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3931 Remove decls. This fixes an "It stinks!".
3933 * alloc.c (which_symbols): Fix alignment issue / type clash.
3935 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3937 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3938 (struct Lisp_Misc_Any): Likewise.
3939 (struct Lisp_Free): Likewise.
3940 * alloc.c (union aligned_Lisp_Symbol): Define.
3941 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3942 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3943 (union aligned_Lisp_Misc): Define.
3944 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3945 aligned_Lisp_Misc instead of union Lisp_Misc.
3946 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3948 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3950 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3951 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3952 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3953 * s/netbsd.h, s/sol2-6.h:
3954 Remove definition of GC_MARK_STACK, since the default now works.
3955 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3956 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3957 no longer the default.
3958 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3960 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3962 * lread.c (lisp_file_lexically_bound_p):
3963 Fix hang at ";-*-\n" (bug#11238).
3965 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3967 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3968 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3970 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3972 * nsterm.m (constrainFrameRect): Always constrain when there is only
3973 one screen (Bug#10962).
3975 2012-04-13 Ken Brown <kbrown@cornell.edu>
3977 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3979 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3981 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3983 2012-04-11 Daniel Colascione <dancol@dancol.org>
3985 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3986 against is gone. It's better to use vfork now so that when Cygwin
3987 gains a new, working vfork, we use it automatically (bug#10398).
3989 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3991 * window.c (save_window_save): Obey window-point-insertion-type.
3993 2012-04-11 Glenn Morris <rgm@gnu.org>
3995 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3997 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3999 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4001 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4003 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4004 (force_quit_count): New var.
4005 (handle_interrupt): Use it.
4007 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4009 * w32.c (w32_delayed_load): Record the full path of the library
4010 being loaded (bug#10424).
4012 2012-04-09 Glenn Morris <rgm@gnu.org>
4014 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4015 not just in the obarray, before snarfing them. (Bug#11036)
4017 * Makefile.in ($(leimdir)/leim-list.el):
4018 Pass EMACS rather than BUILT_EMACS.
4020 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4022 * process.c (make_process):
4023 * process.h: Add integer `gnutls_handshakes_tried' member to
4026 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4027 Add convenience `GNUTLS_LOG2i' macro.
4029 * gnutls.c (gnutls_log_function2i): Convenience log function.
4030 (emacs_gnutls_read): Use new log functions,
4031 `gnutls_handshakes_tried' process member, and
4032 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4033 attempts per process (connection).
4035 2012-04-09 Chong Yidong <cyd@gnu.org>
4037 * eval.c (Fuser_variable_p, user_variable_p_eh)
4038 (lisp_indirect_variable): Functions deleted.
4039 (Fdefvar): Caller changed.
4041 * callint.c (Finteractive, Fcall_interactively):
4042 * minibuf.c (Fread_variable): Callers changed.
4044 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4046 * xdisp.c (set_cursor_from_row): If the display string appears in
4047 the buffer at position that is closer to point than the position
4048 after the display string, display the cursor on the first glyph of
4049 the display string. Fixes cursor display when a 'display' text
4050 property immediately follows invisible text. (Bug#11094)
4052 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4054 composite.c: use 'double' consistently
4055 * composite.c (get_composition_id): Use 'double' consistently
4056 instead of converting 'float' to 'double' and vice versa; this is
4057 easier to understand and avoids a GCC warning.
4059 2012-04-09 Glenn Morris <rgm@gnu.org>
4061 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4062 preparation for dumping it with emacs. (Bug#4789)
4063 (leimdir): New variable.
4064 ($(leimdir)/leim-list.el): New rule.
4065 (emacs$(EXEEXT)): Depend on leim-list.el.
4067 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4068 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4069 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4071 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4073 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4076 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4078 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4079 Remove unused local variable.
4081 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4083 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4084 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4085 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4086 objects, as mark_maybe_pointer will catch them otherwise.
4087 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4088 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4090 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4092 Fix typo that broke non-Windows builds.
4093 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4095 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4097 Support building on MS-Windows with libxml2.
4099 * makefile.w32-in (OBJ2): Add xml.$(O).
4100 (GLOBAL_SOURCES): Add xml.c.
4101 ($(BLD)/xml.$(O)): New dependency list.
4103 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4104 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4105 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4106 [!WINDOWSNT]: New macros.
4107 (init_libxml2_functions, libxml2_loaded_p): New functions.
4108 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4109 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4110 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4111 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4113 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4114 Call init_libxml2_functions before calling libxml2 functions.
4115 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4117 * emacs.c: Don't include libxml/parser.h.
4118 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4119 xmlCleanupParser directly.
4121 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4123 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4125 * indent.c (Fvertical_motion): If there is a display string at
4126 point, use it.vpos to compute how many lines to backtrack after
4127 move_it_to point. (Bug#11133)
4129 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4131 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4132 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4133 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4134 macros related to unification of CJK characters. For the details,
4135 see the discussion following the message here:
4136 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4138 2012-04-04 Chong Yidong <cyd@gnu.org>
4140 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4142 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4144 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4145 instead of alloca. (Bug#11138)
4147 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4149 * w32menu.c (is_simple_dialog): Properly check lisp types.
4152 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4154 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4155 position we get to after a call to move_it_to fails the
4156 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4157 only if we wind up in a string from display property. (Bug#11063)
4159 * window.c (Fdelete_other_windows_internal): Invalidate the row
4160 and column information about mouse highlight, so that redisplay
4161 restores it after reallocating the glyph matrices. (Bug#7464)
4163 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4164 string comes from a `display' text property, use the buffer
4165 position of that property as if we actually saw that position in
4167 (move_it_by_lines): Remove the assertion that
4168 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4169 violated when there's a before-string at the beginning of a line.
4172 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4174 * xdisp.c (append_space_for_newline): If the default face was
4175 remapped, use the remapped face for the appended newline.
4176 (extend_face_to_end_of_line): Use the remapped default face for
4177 extending the face to the end of the line.
4178 (display_line): Call extend_face_to_end_of_line when the default
4179 face was remapped. (Bug#11068)
4181 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4183 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4185 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4187 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4189 2012-03-27 Glenn Morris <rgm@gnu.org>
4191 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4194 2012-03-26 Kenichi Handa <handa@m17n.org>
4196 * dispextern.h (struct glyph): Fix previous change. Change the
4197 bit length of glyphless.ch to 25 (Bug#11082).
4199 2012-03-26 Chong Yidong <cyd@gnu.org>
4201 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4202 (command_loop_1): Use it; inhibit selection update for
4203 handle-select-window too (Bug#8996).
4205 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4207 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4209 2012-03-25 Kenichi Handa <handa@m17n.org>
4211 * dispextern.h (struct glyph): Change the bit length of
4212 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4214 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4216 * s/ms-w32.h (tzname): Include time.h before redirecting to
4217 _tzname. Fixes the MSVC build. (Bug#9960)
4219 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4221 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4224 * xterm.c (XTread_socket): Only modify handling_signal if
4225 !SYNC_INPUT. (Bug#11080)
4227 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4229 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4230 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4231 when fetching a multibyte character consumes more bytes than
4232 CHAR_BYTES returns, due to unification of CJK characters in
4233 string_char. (Bug#11073)
4235 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4237 * process.c (wait_reading_process_output): Handle pty disconnect
4238 by refraining from sending oneself a SIGCHLD (bug#10933).
4240 2012-03-22 Chong Yidong <cyd@gnu.org>
4242 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4244 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4245 Mark string as coming from a prefix property.
4246 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4247 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4249 2012-03-21 Chong Yidong <cyd@gnu.org>
4251 * xfaces.c (Vface_remapping_alist): Doc fix.
4253 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4255 * w32proc.c (Fw32_set_console_codepage)
4256 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4259 2012-03-20 Chong Yidong <cyd@gnu.org>
4261 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4262 to reflect default non-nil value of redisplay-dont-pause.
4264 2012-03-19 Kenichi Handa <handa@m17n.org>
4266 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4267 it fit in a valid range (Bug#11003).
4269 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4271 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4272 that is not from display property, accept the row as a "cursor
4273 row" if one of the string's character has a non-nil `cursor'
4274 property. Fixes cursor positioning when there are newlines in
4275 overlay strings, e.g. in icomplete.el. (Bug#11035)
4277 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4279 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4281 2012-03-12 Chong Yidong <cyd@gnu.org>
4283 * eval.c (inhibit_lisp_code): Rename from
4284 inhibit_window_configuration_change_hook; move from window.c.
4286 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4287 * window.c (run_window_configuration_change_hook)
4288 (syms_of_window): Callers changed.
4290 2012-03-11 Chong Yidong <cyd@gnu.org>
4292 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4294 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4296 2012-03-10 Chong Yidong <cyd@gnu.org>
4298 * frame.c (other_visible_frames): Don't assume the selected frame
4299 is visible (Bug#10955).
4301 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4303 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4305 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4307 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4308 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4311 2012-03-03 Glenn Morris <rgm@gnu.org>
4313 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4315 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4317 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4318 position past the first glyph_row that ends at ZV. (Bug#10902)
4319 (redisplay_window, next_element_from_string): Fix typos in
4321 (redisplay_window): Pass to move_it_vertically the margin in
4322 pixels, not in screen lines.
4324 2012-03-02 Glenn Morris <rgm@gnu.org>
4326 * buffer.c (buffer-list-update-hook): Doc fix.
4328 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4330 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4331 push_it before setting up the iterator for the first overlay
4332 string, even if we have an empty string loaded.
4333 (next_overlay_string): If there's an empty string on the iterator
4334 stack, pop the stack. (Bug#10903)
4336 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4338 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4339 Suggested by Stefan Monnier in
4340 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4341 * alloc.c (widen_to_Lisp_Object): New static function.
4342 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4343 and widening them to Lisp_Objects. This would work even if
4344 USE_LSB_TAG is defined and wide integers are used, which might
4345 happen in a future version of Emacs.
4347 2012-02-25 Chong Yidong <cyd@gnu.org>
4349 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4352 * xselect.c (Fx_selection_exists_p): Doc fix.
4353 (x_clipboard_manager_save_all): Print an informative message
4354 before saving to clipboard manager.
4356 2012-02-24 Chong Yidong <cyd@gnu.org>
4358 * keyboard.c (process_special_events): Handle all X selection
4359 requests in kbd_buffer, not just the next one (Bug#8869).
4361 2012-02-23 Chong Yidong <cyd@gnu.org>
4363 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4364 call when setting menu-bar-lines and tool-bar-lines parameters.
4365 (unwind_create_frame_1): New helper function.
4367 * window.c (inhibit_window_configuration_change_hook): New var.
4368 (run_window_configuration_change_hook): Obey it.
4369 (syms_of_window): Initialize it.
4371 2012-02-22 Chong Yidong <cyd@gnu.org>
4373 * xterm.c (x_draw_image_relief): Add missing type check for
4374 Vtool_bar_button_margin (Bug#10743).
4376 2012-02-21 Chong Yidong <cyd@gnu.org>
4378 * fileio.c (Vfile_name_handler_alist): Doc fix.
4380 * buffer.c (Fget_file_buffer): Protect against invalid file
4381 handler return value.
4383 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4385 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4386 when computing $valmask.
4388 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4389 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4390 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4391 It's useless in that case, and it can cause problems on hosts
4392 that allocate halves of EMACS_INT values separately.
4393 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4394 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4395 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4396 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4397 it avoids undefined behavior on hosts where shifting right by more
4398 than the word width has undefined behavior.
4400 2012-02-19 Chong Yidong <cyd@gnu.org>
4402 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4403 (Funhandled_file_name_directory, Ffile_name_as_directory)
4404 (Fdirectory_file_name, Fexpand_file_name)
4405 (Fsubstitute_in_file_name): Protect against invalid file handler
4406 return values (Bug#10845).
4408 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4410 * .gdbinit (pitx): Fix incorrect references to fields of the
4413 2012-02-17 Chong Yidong <cyd@gnu.org>
4415 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4417 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4419 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4420 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4422 2012-02-15 Chong Yidong <cyd@gnu.org>
4424 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4425 marked as special. Also, starting docstrings with * is obsolete.
4427 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4429 * gnutls.c (emacs_gnutls_write): Fix last change.
4431 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4433 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4436 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4438 * keymap.c (Fsingle_key_description): Handle char ranges.
4440 2012-02-12 Chong Yidong <cyd@gnu.org>
4442 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4443 as that creates a dangerous corner case.
4445 * window.c (Fdelete_window_internal): Invalidate the mouse
4446 highlight (Bug#9904).
4448 2012-02-12 Glenn Morris <rgm@gnu.org>
4450 * xselect.c (Fx_own_selection_internal)
4451 (Fx_get_selection_internal, Fx_disown_selection_internal)
4452 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4453 * nsselect.m (Fx_own_selection_internal)
4454 (Fx_disown_selection_internal, Fx_selection_exists_p)
4455 (Fx_selection_owner_p, Fx_get_selection_internal):
4456 Sync docs and argument specs with the xselect.c versions.
4458 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4460 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4462 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4464 * w32select.c (Fx_selection_exists_p): Sync doc string and
4465 argument list with xselect.c. (Bug#10783)
4467 * w16select.c (Fx_selection_exists_p): Sync doc string and
4468 argument list with xselect.c. (Bug#10783)
4470 2012-02-10 Glenn Morris <rgm@gnu.org>
4472 * fns.c (Fsecure_hash): Doc fix.
4474 2012-02-09 Kenichi Handa <handa@m17n.org>
4476 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4478 2012-02-07 Chong Yidong <cyd@gnu.org>
4480 * buffer.c (Fbuffer_local_variables)
4481 (buffer_lisp_local_variables): Handle unbound vars correctly;
4482 don't let Qunbound leak into Lisp.
4484 2012-02-07 Glenn Morris <rgm@gnu.org>
4486 * image.c (Fimagemagick_types): Doc fix.
4488 * image.c (imagemagick-render-type): Change it from a lisp object
4489 to an integer. Move the doc here from the lisp manual.
4490 Treat all values not equal to 0 the same.
4492 2012-02-06 Chong Yidong <cyd@gnu.org>
4494 * doc.c (store_function_docstring): Avoid applying docstring of
4495 alias to base function (Bug#2603).
4497 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4499 * .gdbinit (pp1, pv1): Remove redundant defines.
4502 2012-02-04 Chong Yidong <cyd@gnu.org>
4504 * nsterm.m: Declare a global (Bug#10694).
4506 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4508 * w32.c (get_emacs_configuration_options):
4509 Include --enable-checking, if specified, in the return value.
4511 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4513 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4514 after rounding frame sizes. (Bug#9723)
4516 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4518 * keyboard.c (adjust_point_for_property): Don't position point
4519 before BEGV. (Bug#10696)
4521 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4523 Handle overflow when computing char display width (Bug#9496).
4524 * character.c (char_width): Return EMACS_INT, not int.
4525 (char_width, c_string_width): Check for overflow when
4526 computing the width; this is possible now that individual
4527 characters can have unbounded width. Problem introduced
4528 by merge from Emacs 23 on 2012-01-19.
4530 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4532 * dbusbind.c (Fdbus_register_method): Mention the return value
4533 :ignore in the docstring.
4535 2012-02-02 Glenn Morris <rgm@gnu.org>
4537 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4539 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4540 Unconditionally set to t. (Bug#10673)
4541 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4542 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4543 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4545 2012-02-02 Kenichi Handa <handa@m17n.org>
4547 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4548 0, do not call append_composite_glyph.
4550 2012-02-02 Kenichi Handa <handa@m17n.org>
4552 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4554 (x_produce_glyphs): If the component of a composition is a null
4555 string, set it->pixel_width to 1 to avoid zero-width glyph.
4557 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4559 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4560 first 2 arguments are identical. This makes inserting large
4561 output from a subprocess an order of magnitude faster on
4562 MS-Windows, where all sbrk'ed memory is always contiguous.
4564 2012-01-31 Glenn Morris <rgm@gnu.org>
4566 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4567 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4568 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4570 2012-01-29 Glenn Morris <rgm@gnu.org>
4572 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4574 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4576 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4578 2012-01-28 Chong Yidong <cyd@gnu.org>
4580 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4582 2012-01-26 Chong Yidong <cyd@gnu.org>
4584 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4586 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4587 repeat counts (Bug#10507).
4589 2012-01-26 Glenn Morris <rgm@gnu.org>
4591 * lread.c (syms_of_lread): Doc fix.
4593 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4595 * coding.c (encode_designation_at_bol): Change return value to
4598 2012-01-25 Chong Yidong <cyd@gnu.org>
4600 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4602 2012-01-21 Chong Yidong <cyd@gnu.org>
4604 * floatfns.c (Fcopysign): Make the second argument non-optional,
4605 since nil is not allowed anyway.
4607 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4609 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4610 (send_process): Likewise.
4612 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4614 * window.c (save_window_save, Fcurrent_window_configuration)
4615 (Vwindow_persistent_parameters): Do not use Qstate.
4616 Rewrite doc-strings.
4618 2012-01-19 Kenichi Handa <handa@m17n.org>
4620 * character.c (char_width): New function.
4621 (Fchar_width, c_string_width, lisp_string_width):
4622 Use char_width (Bug#9496).
4624 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4626 * window.c (Vwindow_persistent_parameters): New variable.
4627 (Fset_window_configuration, save_window_save): Handle persistent
4630 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4632 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4633 thrashing the stack of the thread. (Bug#9087)
4635 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4637 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4639 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4641 * xdisp.c (rows_from_pos_range): Handle the case where the
4642 highlight ends on a newline. (Bug#10464)
4643 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4644 he end column for display of highlight that ends on a newline
4647 2012-01-11 Glenn Morris <rgm@gnu.org>
4649 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4650 from load-path also when installation-directory is nil. (Bug#10208)
4652 2012-01-10 Glenn Morris <rgm@gnu.org>
4654 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4656 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4657 Update template values to be closer to their typical values these days.
4659 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4661 * xdisp.c (rows_from_pos_range): Accept additional argument
4662 DISP_STRING, and accept any glyph in a row whose object is that
4663 string as eligible for mouse highlight. Fixes mouse highlight of
4664 display strings from overlays. (Bug#10464)
4666 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4668 emacs: fix an auto-save permissions race condition (Bug#10400)
4669 * fileio.c (auto_saving_dir_umask): New static var.
4670 (Fmake_directory_internal): Use it.
4671 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4672 creating the directory. The old code temporarily assigns
4673 too-generous permissions to the directory.
4674 (do_auto_save_eh): Clear it.
4675 (Fdo_auto_save): Catch all errors, not just file errors, so
4676 that the var is always cleared.
4678 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4680 * search.c (scan_buffer): Pass character positions to
4681 know_region_cache, not byte positions. (Bug#6540)
4683 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4685 * w32.c (sys_rename): Report EXDEV when rename of a directory
4686 fails because the target is on another logical disk. (Bug#10284)
4688 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4690 * xterm.c (x_embed_request_focus): New function.
4692 * xterm.h: Add prototype.
4694 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4696 2012-01-05 Glenn Morris <rgm@gnu.org>
4698 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4700 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4702 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4703 Load gnutls_transport_set_lowat only if GnuTLS version is below
4705 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4706 GnuTLS versions below 2.11.1.
4708 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4710 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4711 to the doc string advising against its use for altering the way
4712 windows are scrolled.
4714 2011-12-28 Kenichi Handa <handa@m17n.org>
4716 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4717 coding-system ASCII compatible only when it does not produce BOM
4718 on encoding (Bug#10383).
4720 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4722 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4724 (create_and_show_popup_menu): Always use menu_position_func for
4727 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4729 * callint.c (Fcall_interactively): Don't truncate prompt string.
4731 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4733 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4734 property that ends at ZV, so that the bidi iteration could be
4735 resumed from there (after widening). (Bug#10360)
4737 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4739 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4741 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4743 * nsterm.m (x_free_frame_resources):
4744 Release f->output_data.ns->miniimage.
4745 (ns_index_color): Fix indentation. Do not retain
4746 color_table->colors[i].
4748 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4751 * nsfns.m (x_set_background_color): Assign return value from
4752 ns_index_color to face-background instead of NSColor*.
4753 (ns_implicitly_set_icon_type): Fix indentation.
4754 Change assignment in for loop to comparison.
4756 * emacs.c (ns_pool): New variable.
4757 (main): Assign ns_pool.
4758 (Fkill_emacs): Call ns_release_autorelease_pool.
4760 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4761 autorelease fdesc, release fdAttrs and tdict.
4762 (ns_get_covering_families): Release charset.
4763 (ns_findfonts): Release NSFontDescriptor created with new.
4764 (ns_uni_to_glyphs): Fix indentation.
4765 (setString): Release attrStr before assigning new value.
4767 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4769 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4771 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4772 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4774 2011-12-18 David Reitter <reitter@cmu.edu>
4776 * nsterm.m (ns_term_init): Subscribe for notifications
4777 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4778 to method trackingNotification in EmacsMenu.
4780 * nsmenu.m (trackingMenu): New variable.
4781 (trackingNotification): New method (from Aquamacs).
4782 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4783 from Aquamacs (Bug#7030).
4785 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4787 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4788 (symbol_to_nsstring): Fix indentation.
4789 (ns_symbol_to_pb): New function.
4790 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4791 (Fns_rotate_cut_buffers_internal): Remove.
4792 (Fns_store_selection_internal): Rename from
4793 Fns_store_cut_buffer_internal.
4794 (ns_get_foreign_selection, Fx_own_selection_internal)
4795 (Fx_disown_selection_internal, Fx_selection_exists_p)
4796 (Fns_get_selection_internal, Fns_store_selection_internal):
4797 Use ns_symbol_to_pb and check if return value is nil.
4798 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4799 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4800 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4801 renamed to Sns_store_selection_internal.
4802 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4803 and remove this function.
4804 (ns_handle_selection_clear): Remove, never used.
4805 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4808 2011-12-17 Ken Brown <kbrown@cornell.edu>
4810 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4811 GID is unknown (Bug#10257).
4813 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4815 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4816 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4817 which caused a build failure on GNU/Linux IA-64. This problem was
4818 introduced by my 2011-10-07 patch.
4820 2011-12-15 Juri Linkov <juri@jurta.org>
4822 * image.c (imagemagick_error): New function. (Bug#10112)
4823 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4824 Use `imagemagick_error' where ImageMagick functions return
4826 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4829 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4831 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4832 fill background (Bug#8992).
4834 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4836 * window.c (Vwindow_combination_resize)
4837 (Vwindow_combination_limit): Use t instead of non-nil in
4839 (Vrecenter_redisplay): Add first sentence of doc-string on
4841 (Frecenter): Fix doc-string typo.
4843 2011-12-11 Kenichi Handa <handa@m17n.org>
4845 * coding.c (Funencodable_char_position): Pay attention to the
4846 buffer text relocation (Bug#9389).
4848 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4850 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4851 gtk_init (Bug#10100).
4853 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4855 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4856 IT->string is nil. (Bug#10263)
4858 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4860 * nsterm.h (x_free_frame_resources): Declare.
4862 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4863 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4865 * nsterm.h (ns_get_defaults_value): Declare.
4867 * nsterm.m (ns_default): Call ns_get_defaults_value.
4869 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4871 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4874 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4876 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4877 that where the value of an _OBJC_* symbol points to is in the .bss
4878 section (Bug#10240).
4880 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4882 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4883 after the loop to call ccl_driver at least once (Bug#8619).
4885 2011-12-08 Kenichi Handa <handa@m17n.org>
4887 * ftfont.c (get_adstyle_property): Fix previous change
4890 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4892 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4893 dirs from the default value of EMACSLOADPATH (bug#10208).
4895 2011-12-07 Glenn Morris <rgm@gnu.org>
4897 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4898 installation and source directories as well. (Bug#10208)
4900 2011-12-06 Chong Yidong <cyd@gnu.org>
4902 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4904 2011-12-06 Glenn Morris <rgm@gnu.org>
4906 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4907 as an error, not just -1. (Bug#10217)
4909 2011-12-05 Chong Yidong <cyd@gnu.org>
4911 * keyboard.c (process_special_events): New function.
4912 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4914 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4916 * coding.c (encode_designation_at_bol): Don't use uninitialized
4917 local variable (Bug#9318).
4919 2011-12-05 Kenichi Handa <handa@m17n.org>
4921 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4922 return Qnil (Bug#8046, Bug#10193).
4924 2011-12-05 Kenichi Handa <handa@m17n.org>
4926 * coding.c (encode_designation_at_bol): New args charbuf_end and
4927 dst. Return the number of produced bytes. Callers changed.
4928 (coding_set_source): Return how many bytes coding->source was
4930 (coding_set_destination): Return how many bytes
4931 coding->destination was relocated.
4932 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4933 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4935 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4937 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4938 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4941 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4943 The following changes are to fix Bug#9318.
4945 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4946 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4947 (encode_coding_iso_2022, encode_coding_sjis)
4948 (encode_coding_big5, encode_coding_charset): Use the above macros.
4950 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4952 * lisp.h (process_quit_flag): Fix external declaration.
4954 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4956 Don't macro-inline non-performance-critical code.
4957 * eval.c (process_quit_flag): New function.
4958 * lisp.h (QUIT): Use it.
4960 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4962 * nsfns.m (get_geometry_from_preferences): New function.
4963 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4965 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4967 * emacs.c (Qkill_emacs): Define.
4968 (syms_of_emacs): Initialize it.
4969 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4970 Qquit_flag to `kill-emacs' instead.
4971 (quit_throw_to_read_char): Add parameter `from_signal'.
4972 All callers changed. Call Fkill_emacs if requested and safe.
4973 * lisp.h (QUIT): Call Fkill_emacs if requested.
4975 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4977 * widget.c (update_wm_hints): Return if wmshell is null.
4978 (widget_update_wm_size_hints): New function.
4980 * widget.h (widget_update_wm_size_hints): Declare.
4982 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4983 widget_update_wm_size_hints (Bug#10104).
4985 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4987 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4988 before a newline, prepare the bidi iterator for consuming the
4989 newline, and keep the current paragraph direction. (Bug#10183)
4990 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4992 2011-12-02 Juri Linkov <juri@jurta.org>
4994 * search.c (Fword_search_regexp): New Lisp function created from
4995 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4996 (Fword_search_backward, Fword_search_forward)
4997 (Fword_search_backward_lax, Fword_search_forward_lax):
4998 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4999 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5001 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5003 * fileio.c (Finsert_file_contents): Move after-change-function call
5004 to before the "handled:" label, since all "goto handled" appear in
5005 cases where the *-change-functions have already been properly called
5008 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5010 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5011 waiting for input. (Bug#10169)
5013 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5015 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5016 verifies glyph row's hash code--we have just reallocated the
5017 glyphs, so their contents can be complete garbage. (Bug#10164)
5019 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5021 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5023 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5025 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5026 attributes are tested _before_ calling verify_row_hash, to protect
5027 against GCC re-ordering of the tests. (Bug#10164)
5029 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5031 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5033 * xterm.c (handle_one_xevent): Only set async_visible and friends
5034 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5035 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5036 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5038 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5040 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5041 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5042 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5043 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5044 All uses changed to use GCPRO1 etc.
5045 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5046 Revert to old implementation (i.e., before 2011-03-11).
5048 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5050 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5051 of scroll runs so as to avoid assigning disabled bogus rows and
5052 unnecessary graphics copy operations.
5054 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5056 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5057 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5058 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5059 (malloc, free, realloc, calloc): Redirect to e_* only when
5062 * lisp.h (GCTYPEBITS): Move before first use.
5063 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5064 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5065 this macro definition.
5067 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5070 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5072 * gtkutil.c (xg_create_frame_widgets):
5073 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5074 present with Gtk+ 2.0.
5076 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5078 * fileio.c (Finsert_file_contents): Undo previous change; see
5079 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5081 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5083 Rename locals to avoid shadowing.
5084 * fileio.c (Finsert_file_contents):
5085 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5086 * process.c (wait_reading_process_output):
5087 Rename inner 'proc' to 'p' to avoid shadowing.
5088 Indent for consistency with usual Emacs style.
5090 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5092 * xdisp.c (redisplay_window): If cursor row is not fully visible
5093 after recentering, and scroll-conservatively is set to a large
5094 number, scroll window by a few more lines to make the cursor fully
5095 visible and out of scroll-margin. (Bug#10105)
5096 (start_display): Don't move to the next line if the display should
5097 start at a newline that is part of a display vector or an overlay
5100 2011-11-24 Juri Linkov <juri@jurta.org>
5102 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5103 after the `MagickPingImage' call. (Bug#10112)
5105 2011-11-23 Chong Yidong <cyd@gnu.org>
5107 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5109 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5111 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5112 making another buffer current. (Bug#10114)
5114 2011-11-23 Glenn Morris <rgm@gnu.org>
5116 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5118 2011-11-23 Chong Yidong <cyd@gnu.org>
5120 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5121 using it (Bug#5984).
5123 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5125 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5126 and header-lines, as they don't have one computed for them.
5129 * .gdbinit (prow): Make displayed values more self-explaining.
5130 Add row's hash code.
5132 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5134 * process.c (wait_reading_process_output): Fix asynchrounous
5135 GnuTLS socket handling on some versions of the GnuTLS library.
5136 (wait_reading_process_output): Add comment and URL.
5138 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5140 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5142 2011-11-21 Chong Yidong <cyd@gnu.org>
5144 * window.c (Fnext_window, Fprevious_window): Doc fix.
5146 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5148 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5150 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5152 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5154 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5156 * window.c (Fset_window_combination_limit): Rename argument
5158 (Vwindow_combination_limit): Remove "status" from doc-string.
5160 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5162 * m/ibms390.h: Remove.
5163 * m/ibms390x.h: Don't include "ibms390.h".
5165 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5167 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5168 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5170 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5172 * casetab.c (Fset_case_table):
5173 * charset.c (Fcharset_after): Fix typos.
5175 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5177 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5178 Otherwise, valgrind does not work on some platforms.
5179 Problem reported by Andreas Schwab in
5180 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5181 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5182 is set, removing the need for VIRT_ADDRESS_VARIES.
5183 (PURE_P): Use a more-efficient implementation that needs just one
5184 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5185 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5186 to 4 (xorl, subq, cmpq, setbe).
5187 * alloc.c (pure): Always extern now, since that's the
5188 VIRT_ADDR_VARIES behavior.
5189 (PURE_POINTER_P): Use a single comparison, not two, for
5190 consistency with the new puresize.h.
5191 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5192 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5193 Remove VIRT_ADDR_VARIES no longer needed.
5195 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5197 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5198 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5199 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5200 behave as if the cursor position were at the window margin.
5202 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5203 and the cursor position is out of bounds, behave as if the cursor
5204 position were at the window margin. (Bug#10075)
5206 2011-11-18 Chong Yidong <cyd@gnu.org>
5208 * window.c (Fwindow_combination_limit): Make first argument
5209 non-optional, since it is meaningless for live windows like the
5212 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5214 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5216 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5218 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5219 (graft_intervals_into_buffer): Simplify.
5221 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5223 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5224 hash values of the two rows.
5225 (copy_row_except_pointers): Preserve the used[] arrays and the
5226 hash values of the two rows. (Bug#10035)
5227 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5229 * xdisp.c (row_hash): New function, body extracted from
5230 compute_line_metrics.
5231 (compute_line_metrics): Call row_hash, instead of computing the
5234 * dispnew.c (verify_row_hash): Call row_hash for computing the
5235 hash code of a row, instead of duplicating code from xdisp.c.
5237 * dispextern.h (row_hash): Add prototype.
5239 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5241 * frame.c (delete_frame): Don't delete the terminal when the last
5242 X frame is closed if emacs is built with GTK toolkit.
5244 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5246 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5248 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5250 * window.c (Vwindow_splits): Rename to
5251 Vwindow_combination_resize. Suggested by Juri Linkov.
5252 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5255 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5257 * nsfns.m (Fns_font_name):
5258 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5260 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5262 * window.h (window): Rename slot "nest" to "combination_limit".
5263 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5264 (Fset_window_nest): Rename to Fset_window_combination_limit.
5265 (Vwindow_nest): Rename to Vwindow_combination_limit.
5266 (recombine_windows, make_parent_window, make_window)
5267 (Fsplit_window_internal, saved_window)
5268 (Fset_window_configuration, save_window_save): Rename all
5269 occurrences of window_nest to window_combination_limit.
5271 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5273 * image.c (imagemagick_load_image): Fix typo.
5275 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5277 * xdisp.c (display_line): Move the call to
5278 highlight_trailing_whitespace before the call to
5279 compute_line_metrics, since the latter needs to see the final
5280 faces of all the glyphs to compute ROW's hash value.
5281 Fixes assertion violations in row_equal_p. (Bug#10035)
5283 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5285 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5286 just return (bug#10044).
5288 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5290 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5291 with user-defined heap size. Bump the default size of the temacs
5292 heap to 27MB, to avoid memory warning when running temacs.
5293 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5295 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5296 current_matrix and desired_matrix. (Bug#9990)
5297 (verify_row_hash) [XASSERTS]: New function.
5298 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5299 that the hash value of glyph rows is correct.
5301 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5303 * window.h (window): Remove splits slot.
5304 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5305 (Fdelete_other_windows_internal, make_parent_window)
5306 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5307 (Fset_window_configuration, save_window_save): Don't deal with
5308 split status of windows.
5309 (saved_window): Remove splits slot.
5310 (Vwindow_splits): Rewrite doc-string.
5312 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5314 * xfns.c (unwind_create_frame):
5315 * nsfns.m (unwind_create_frame):
5316 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5317 Vframe_list (Bug#9999).
5319 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5321 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5323 2011-11-11 Kenichi Handa <handa@m17n.org>
5325 * callproc.c (Fcall_process): Set the member dst_multibyte of
5328 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5330 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5331 avoid a crash (bug#9496).
5333 2011-11-09 Chong Yidong <cyd@gnu.org>
5335 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5336 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5338 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5340 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5342 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5344 Avoid some portability problems by eschewing 'extern inline' functions.
5345 The trivial performance wins aren't worth the portability hassles; see
5346 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5348 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5349 (window_box_width, window_box_left, window_box_left_offset)
5350 (window_box_right, window_box_right_offset): Undo previous change,
5351 by removing the "extern"s.
5352 * intervals.c (adjust_intervals_for_insertion)
5353 (adjust_intervals_for_deletion): Undo previous change,
5354 making these static again.
5355 (offset_intervals, temp_set_point_both, temp_set_point)
5356 (copy_intervals_to_string): No longer inline.
5357 * xdisp.c (window_text_bottom_y, window_box_width)
5358 (window_box_height, window_box_left_offset)
5359 (window_box_right_offset, window_box_left, window_box_right)
5360 (window_box): No longer inline.
5362 2011-11-08 Chong Yidong <cyd@gnu.org>
5364 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5365 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5366 Signal an error if not a live window.
5367 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5368 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5370 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5372 * lisp.h (syms_of_abbrev): Remove declaration.
5373 Reported by CHENG Gao <chenggao@royau.me>.
5375 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5377 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5378 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5379 of temacs in GUI mode.
5381 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5383 * window.h: Declare delete_all_child_windows instead of
5384 delete_all_subwindows.
5385 * window.c (Fwindow_nest, Fset_window_nest)
5386 (Fset_window_new_total, Fset_window_new_normal)
5387 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5388 (delete_all_subwindows): Rename to delete_all_child_windows.
5389 (Fdelete_other_windows_internal, Fset_window_configuration):
5390 Call delete_all_child_windows instead of delete_all_subwindows.
5391 * frame.c (delete_frame): Call delete_all_child_windows instead
5392 of delete_all_subwindows.
5394 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5396 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5397 This is also needed for porting to any host where GC_MARK_STACK is
5398 not GC_MAKE_GCPROS_NOOPS.
5399 (which_symbols): Use it.
5401 2011-11-07 Kenichi Handa <handa@m17n.org>
5403 * coding.c (coding_set_destination): Check coding->src_pos only
5404 when coding->src_object is a buffer (bug#9910).
5406 * process.c (send_process): Set the member src_multibyte of coding
5407 to 0 (bug#9911) when sending a unibyte text.
5409 * callproc.c (Fcall_process): Set the member src_multibyte of
5410 process_coding to 0 (bug#9912).
5412 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5414 * xmenu.c (cleanup_widget_value_tree): New function.
5415 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5416 calling free_menubar_widget_value_tree directly (Bug#9830).
5418 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5420 Fix some portability problems with 'inline'.
5421 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5422 (window_box_width, window_box_left, window_box_left_offset)
5423 (window_box_right, window_box_right_offset): Declare extern.
5424 Otherwise, these inline functions do not conform to C99 and
5425 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5426 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5427 * intervals.c (adjust_intervals_for_insertion)
5428 (adjust_intervals_for_deletion): Now extern, because otherwise the
5429 extern inline functions 'offset_intervals' couldn't refer to it.
5430 (static_offset_intervals): Remove.
5431 (offset_intervals): Rewrite using the old contents of
5432 static_offset_intervals. The old version didn't conform to C99
5433 because an extern inline function contained a reference to an
5434 identifier with static linkage.
5436 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5438 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5441 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5443 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5444 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5445 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5446 return Qleft_to_right.
5448 2011-11-06 Chong Yidong <cyd@gnu.org>
5450 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5451 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5452 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5453 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5454 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5455 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5456 (Fwindow_vscroll): Doc fix.
5457 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5458 argument, since it makes no sense to pass a live window and for
5459 consistency with window-child.
5461 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5463 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5466 2011-11-05 Jason Rumney <jasonr@gnu.org>
5468 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5469 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5471 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5472 bitwise arithmetic preventing use of unicode-sip and non-truetype
5475 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5477 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5480 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5481 initialization code to keep similarity to xfns.c after changes
5484 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5486 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5487 (unwind_create_frame): New function (Bug#9943).
5488 (Fx_create_frame): Restructure code to be more similar to the one in
5489 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5490 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5491 Move terminal->reference_count++ just before making the frame official
5494 * nsterm.m (x_free_frame_resources): New function.
5495 (x_destroy_window): Move code to x_free_frame_resources.
5497 * xfns.c (unwind_create_frame): Fix comment.
5498 (Fx_create_frame, x_create_tip_frame):
5499 Move terminal->reference_count++ just before making the frame
5500 official. Move initialization of image_cache_refcount and
5501 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5503 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5505 Support MSVC build with newer versions of Visual Studio.
5506 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5507 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5510 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5511 which are not supported by MSVC.
5512 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5513 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5515 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5517 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5519 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5521 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5523 Support MSVC build with newer versions of Visual Studio.
5524 * w32.c: Don't include w32api.h for MSVC.
5525 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5527 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5528 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5529 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5530 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5532 (alloca) [_MSC_VER]: Define to _alloca.
5534 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5536 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5538 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5540 * xdisp.c (note_mouse_highlight): If either of
5541 previous/next-single-property-change returns nil, treat that as
5542 the beginning or the end of the buffer. (Bug#9955)
5544 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5546 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5547 label is not null (Bug#9951).
5548 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5551 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5553 * window.c (Fwindow_body_size): Mention in the doc string that the
5554 return value is in frame's canonical units. (Bug#9949)
5556 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5558 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5560 * w32fns.c (unwind_create_frame): If needed, free the glyph
5561 matrices of the partially constructed frame. (Bug#9943)
5562 * xfns.c (unwind_create_frame): Likewise.
5564 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5566 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5567 Don't stop backward scan on the continuation glyph, even though
5568 its CHARPOS is positive.
5569 (mouse_face_from_buffer_pos, note_mouse_highlight):
5570 Rename cover_string to disp_string.
5572 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5574 * window.c (temp_output_buffer_show): Don't use
5575 Vtemp_buffer_show_specifiers.
5576 (Vtemp_buffer_show_specifiers): Remove unused variable.
5578 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5580 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5581 past the beginning of the current glyph matrix.
5583 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5585 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5586 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5587 HAVE_GTK3 (Bug#9869).
5589 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5590 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5592 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5594 * xterm.c: Declare x_handle_net_wm_state to return int.
5595 (handle_one_xevent): Check if we are iconified but don't have
5596 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5597 (get_current_wm_state): Return non-zero if not hidden,
5598 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5599 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5600 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5601 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5603 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5605 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5606 so that this new function doesn't get optimized away by a
5607 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5609 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5611 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5613 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5615 Fix the `xbytecode' command.
5616 * .gdbinit (xprintbytestr): New command.
5617 (xwhichsymbols): Rename from `which'; all callers changed.
5618 (xbytecode): Print the byte-code string as well.
5620 2011-10-29 Kim Storm <storm@cua.dk>
5622 * alloc.c (which_symbols): New function.
5624 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5626 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5629 2011-10-29 Glenn Morris <rgm@gnu.org>
5631 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5632 Not clear what it was for, and it causes various bugs. (Bug#9839)
5634 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5636 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5637 possible random value that matches one of those tested as
5638 condition to clear the mouse face.
5640 2011-10-28 Chong Yidong <cyd@gnu.org>
5642 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5644 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5646 * window.c (make_window): Initialize phys_cursor_on_p.
5648 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5650 * lisp.h (struct Lisp_Symbol): Update comments.
5652 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5654 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5656 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5658 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5659 <oslsachem@gmail.com> for helping to debug this.
5661 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5662 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5663 (g_b_init_get_glyph_outline_w): New static variables.
5664 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5665 (GetGlyphOutlineW_Proc): New typedefs.
5666 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5667 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5669 (w32font_open_internal, compute_metrics):
5670 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5671 instead of calling the "wide" APIs directly.
5673 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5675 * w32.h (syms_of_w32font): Add prototype.
5677 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5679 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5680 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5681 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5682 (Fmove_to_window_line): Doc fix.
5684 2011-10-27 Chong Yidong <cyd@gnu.org>
5686 * process.c (make_process): Set gnutls_state to NULL.
5688 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5689 non-NULL, regardless of GNUTLS_INITSTAGE.
5690 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5691 an error. Set process slots as soon as we allocate them.
5693 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5695 2011-10-27 Chong Yidong <cyd@gnu.org>
5697 * gnutls.c (emacs_gnutls_deinit): New function.
5698 Deallocate credentials structures as well as calling gnutls_deinit.
5699 (Fgnutls_deinit, Fgnutls_boot): Use it.
5701 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5702 (deactivate_process): Call emacs_gnutls_deinit.
5704 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5706 * image.c (x_create_x_image_and_pixmap):
5707 * w32.c (sys_rename, w32_delayed_load):
5708 * w32font.c (fill_in_logfont):
5709 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5711 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5713 * w32fns.c (w32_default_color_map): New function,
5714 extracted from Fw32_default_color_map.
5715 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5717 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5719 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5721 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5723 * keyboard.c (test_undefined): New function (bug#9751).
5724 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5726 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5728 * sysdep.c (init_sys_modes): Fix the check for the controlling
5729 terminal (Bug#6649).
5731 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5733 * dispextern.h (struct bidi_it): New member next_en_type.
5735 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5736 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5737 current character, check also for next_en_type being WEAK_EN.
5738 (bidi_resolve_weak): Don't enter the expensive loop if the current
5739 position is before next_en_pos. Record the bidi type of the first
5740 non-ET, non-BN character we find, in addition to its position.
5741 (bidi_level_of_next_char): Invalidate next_en_type when
5742 next_en_pos is over-stepped.
5744 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5746 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5747 * editfns.c: Rewrite current-time-zone so that it invokes
5748 the equivalent of (format-time-string "%Z") to get the time zone name.
5749 This fixes a bug when the time zone name contains characters that
5750 need converting from the system time locale to Emacs internal format.
5751 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5752 that patch fixed format-time-string to do the conversion, but
5753 I forgot to fix current-time-zone.
5754 (format_time_string): New function, containing most of
5755 what Fformat_time_string used to contain.
5756 (Fformat_time_string): Rewrite in terms of format_time_string.
5757 This doesn't change this function's behavior.
5758 (current-time-zone): Rewrite to use format_time_string.
5759 This fixes the bug reported by Michael Schierl in
5760 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5761 Jason Rumney's 2007-06-07 change worked around this bug, but
5763 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5765 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5767 * xdisp.c (start_display): If the character at POS is displayed
5768 via a display vector, reset IT->current.dpvec_index to zero.
5769 (try_window_reusing_current_matrix): If a line ends in a display
5770 vector or the next line starts in a display vector, continue
5771 redrawing the window even though the character position of
5772 start_row was reached.
5775 2011-10-18 Chong Yidong <cyd@gnu.org>
5777 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5778 with nobreak-char-display too.
5780 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5782 Fix part 3 of bug#9771.
5783 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5784 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5785 non-neutral characters if the current character is a paragraph
5786 separator (a.k.a. Newline). This avoids running the same
5787 expensive loop twice, once when we consume the preceding newline
5788 and the other time when the line actually needs to be displayed.
5789 Avoid the loop when we see neutrals on the base embedding level
5790 following a character whose directionality is the same as the
5791 paragraph's. This avoids running the expensive loop when a line
5792 ends in a long sequence of neutrals, like control characters.
5793 Add assertion against STRONG_AL type. Slightly rearrange code
5794 that determines the type of a neutral given the first non-neutral
5796 (bidi_level_of_next_char): Set next_en_pos to zero when
5797 invalidating its info.
5799 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5801 * xdisp.c (push_display_prop): Determine whether to record string
5802 or buffer position by IT->string, not by IT->method. Allow
5803 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5804 (move_it_vertically_backward): Don't look for character position
5805 immediately after the newline when in a continuation line.
5808 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5810 * window.c (coordinates_in_window): Rewrite and delabelize
5811 vertical border check. (Bug#5357) (Bug#9618)
5813 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5815 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5816 errors in XSetWindowBorder (bug#9310).
5818 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5820 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5821 avoid crash when xmalloc overrun checking is enabled.
5823 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5825 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5826 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5827 cursor motion with <left> and <right> arrow keys.
5829 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5830 some callers set that themselves.
5832 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5834 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5835 display string and the previous row comes from the same string and
5836 is empty. (Bug#9739) (Bug#9738)
5838 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5840 * doc.c (get_doc_string): Encode file name (bug#9735).
5842 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5844 * bidi.c (bidi_level_of_next_char):
5845 * xdisp.c (get_visually_first_element): Remove old incorrect
5846 comments regarding the Unicode Line Separator character.
5848 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5850 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5852 * alloc.c (Fgc_status): Do not access beyond zombies array
5853 boundary if nzombies > MAX_ZOMBIES.
5854 * alloc.c (dump_zombies): Add missing format specifier.
5856 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5858 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5859 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5861 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5862 Some packages use them to denote characters with modifiers.
5864 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5866 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5867 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5868 matching a pp-number. Rename parameter var to var1.
5870 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5872 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5874 2011-10-08 Glenn Morris <rgm@gnu.org>
5876 * callint.c (Fcall_interactively): Give a more explicit error for the
5877 'c' case with a non-character input. (Bug#8479)
5879 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5881 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5883 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5884 lines that are hscrolled on the left.
5886 * dispnew.c (buffer_posn_from_coords): Account for a possible
5887 presence of header-line. (Bug#4426)
5889 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5891 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5892 Don't advertise functionality which we discourage or doesn't work.
5894 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5896 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5897 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5898 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5899 this makes Emacs dump core during garbage collection on rare
5900 occasions. sizeof is obviously inferior to offsetof here, so
5901 stick with offsetof.
5902 (GC_POINTER_ALIGNMENT): New macro.
5903 (mark_memory): Omit 3rd (offset) arg; caller changed.
5904 Don't assume EMACS_INT alignment is the same as pointer alignment.
5906 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5908 * keyboard.c (read_key_sequence_remapped): New var.
5909 (read_key_sequence): Compute remapping in the right buffer.
5910 (command_loop_1): Use read_key_sequence's remapping directly.
5912 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5914 * dired.c (file_name_completion): Don't expand file name.
5915 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5916 before checking file name handler.
5918 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5919 they've been requested explicitly (bug#9591).
5921 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5923 * keymap.c (Fsingle_key_description): Use make_specified_string
5924 instead of build_string to build string from push_key_description.
5927 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5929 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5930 This fixes a Y2038 bug on 64-bit hosts.
5931 * buffer.c (reset_buffer):
5932 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5933 (Fclear_buffer_auto_save_failure):
5934 Use 0, not -1, to represent an unset failure time, since time_t
5935 might not be signed.
5937 Remove dependency on glibc malloc internals.
5938 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5939 Move back here from lisp.h, but with their new implementations.
5940 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5941 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5942 * charset.c (charset_table_init): New static var.
5943 (syms_of_charset): Use it instead of xmalloc. This removes a
5944 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5945 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5946 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5947 Move back to alloc.c.
5948 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5949 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5951 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5953 * nsterm.m (windowDidResize): Call x_set_window_size only when
5954 ns_in_resize is true. Otherwise set pixelwidth/height and
5955 call change_frame_size (Bug#9628).
5957 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5959 Port --enable-checking=all to Fedora 14 x86-64.
5960 * charset.c (syms_of_charset): Also account for glibc malloc's
5961 internal overhead when calculating the initial malloc maximum.
5963 Port --enable-checking=all to Fedora 14 x86.
5964 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5966 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5967 (overrun_check_realloc, overrun_check_free):
5968 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5969 That way, xmalloc returns a properly-aligned pointer even if
5970 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5971 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5972 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5973 into account when calculating the initial malloc maximum.
5974 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5975 Move here from alloc.c, so that charset.c can use it too.
5976 Properly align; the old code wasn't right for common 32-bit hosts
5977 when configured with --enable-checking=all.
5978 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5979 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5981 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5983 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5986 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5988 * xdisp.c (compute_display_string_end): If there's no display
5989 string at CHARPOS, return -1.
5991 * bidi.c (bidi_fetch_char): When compute_display_string_end
5992 returns a negative value, treat the character as a normal
5993 character not covered by a display string. (Bug#9624)
5995 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5997 * lread.c (Fread_from_string): Fix typo in docstring.
5999 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6001 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6002 newline, reseat the iterator instead of bidi-iterating there one
6003 character at a time. (Bug#9610)
6004 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6005 TO_CHARPOS if the bidi iterator is at base embedding level.
6007 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6009 * lread.c (readevalloop): Use correct code for NBSP.
6010 (read1): Likewise. (Bug#9608)
6012 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6014 * dbusbind.c (Fdbus_register_signal): When service is not
6015 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6017 2011-09-25 Glenn Morris <rgm@gnu.org>
6019 * buffer.c (truncate-lines): Doc fix.
6021 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6023 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6024 (Fset_window_next_buffers): Doc fix.
6026 2011-09-24 Glenn Morris <rgm@gnu.org>
6028 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6030 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6032 Fix minor problems found by static checking.
6033 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6034 * indent.c (Fvertical_motion): Fix == vs = typo.
6036 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6038 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6039 Default value is now t. Doc fix.
6041 * indent.c (Fvertical_motion): Compute and apply the overshoot
6042 logic when moving up, not only when moving down. Fix the
6043 confusing name and values of the it_overshoot_expected variable;
6044 logic changes accordingly. (Bug#9254) (Bug#9549)
6046 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6047 CHARPOS is covered by a display string which includes newlines.
6048 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6049 is covered by a display string with embedded newlines.
6051 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6053 * dbusbind.c (Fdbus_register_signal): Add match rule to
6054 Vdbus_registered_objects_table. (Bug#9581)
6055 (Fdbus_register_method, Vdbus_registered_objects_table):
6058 2011-09-24 Jim Meyering <meyering@redhat.com>
6060 do not ignore write error for any output size
6061 The previous change was incomplete.
6062 While it makes emacs --batch detect the vast majority of stdout
6063 write failures, errors were still ignored whenever the output size is
6064 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6065 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6066 && echo FAIL: ignored write error
6067 FAIL: ignored write error
6068 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6069 && echo FAIL: ignored write error
6070 FAIL: ignored write error
6071 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6073 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6075 * emacs.c (Fkill_emacs): In noninteractive mode exit
6076 non-successfully if a write error occurred on stdout. (Bug#9574)
6078 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6080 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6083 * dispextern.h (struct it): Update the comment documenting what
6086 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6088 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6089 a display string, extend search for cursor position to end of row.
6090 (find_row_edges): If the row ends in a newline from a display
6091 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6092 Handle the case of a display string with multiple newlines.
6093 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6094 non-empty line. Fixes confusing cursor motion with arrow keys at
6095 the beginning of a line that starts with whitespace.
6097 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6099 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6102 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6104 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6107 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6109 * xdisp.c (display_line): Record maximum and minimum buffer
6110 positions even if no glyphs were produced (e.g., by a zero-width
6111 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6112 buffer positions that will be removed from the glyph row because
6114 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6115 column is beyond frame width: don't subtract 1 "pixel" when
6116 computing width of the stretch.
6117 (reseat_at_next_visible_line_start): Undo the change made on
6118 2011-09-17 that saved paragraph information and restored it after
6119 the call to `reseat'. (Bug#9545)
6121 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6123 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6124 and turn window cursor on if cleared (Bug#9415).
6126 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6128 * search.c (boyer_moore): Take unibyte characters from pattern
6129 literally. (Bug#9458)
6131 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6133 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6135 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6137 Fix minor problem found by static checking.
6138 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6139 initialized, to pacify gcc -Wuninitialized.
6141 * fileio.c: Report proper errno when syscall falls.
6142 (Finsert_file_contents): Save and restore errno,
6143 so that report_file_error outputs the correct diagnostic.
6144 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6146 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6148 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6150 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6152 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6153 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6155 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6157 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6158 about the current paragraph and restore it after the call to reseat.
6160 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6161 (bidi_find_paragraph_start): Search back for paragraph beginning
6162 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6163 (bidi_move_to_visually_next): Only trigger paragraph-related
6164 computations when the last character is a newline or at EOB, not
6165 just any NEUTRAL_B. (Bug#9470)
6167 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6168 truncated lines if point is covered by a display string. (Bug#9524)
6170 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6172 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6173 (cons_to_x_long): New function.
6174 (lisp_data_to_selection_data): Use it. Correct the test for
6175 short-versus-long data; it was negated. Break out of vector
6176 loop, for efficiency, when a long datum is discovered.
6178 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6180 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6182 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6184 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6185 GCC PR/17406) by declaring this function with external scope.
6187 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6189 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6190 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6192 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6194 * editfns.c (Fformat): Correctly handle text properties on "%%".
6196 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6198 * xterm.c (x_draw_composite_glyph_string_foreground):
6199 * w32term.c (x_draw_composite_glyph_string_foreground):
6200 * term.c (encode_terminal_code):
6201 * composite.c (composition_update_it, get_composition_id):
6202 * xdisp.c (get_next_display_element)
6203 (fill_composite_glyph_string): Add comments about special meaning
6204 of TAB characters in a composition.
6206 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6208 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6209 This occurs when processing a multibyte format.
6210 Problem reported by Wolfgang Jenker.
6212 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6214 * xdisp.c (try_cursor_movement): Only check for exact match if
6215 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6217 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6219 Remove unused external symbols.
6220 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6221 * xdisp.c (calc_pixel_width_or_height): Now static.
6222 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6223 * indent.c (check_display_width):
6224 * w32term.c: Fix comment to match code.
6225 * xterm.c, xterm.h (x_catching_errors): Remove.
6227 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6229 * xselect.c: Use signed conversions more consistently (Bug#9498).
6230 (selection_data_to_lisp_data): Assume incoming selection data are
6231 signed integers, not unsigned. This is to be consistent with
6232 outgoing selection data, which was modified to use signed integers
6233 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6234 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6235 expects long, not unsigned long.
6237 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6239 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6240 computation of loop end. Reported by Johan Bockgård
6243 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6245 * frame.c (Fother_visible_frames_p): Function deleted.
6247 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6249 * indent.c (compute_motion): Process display vector front to back
6250 rather than the other way around. (Bug#2496)
6252 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6254 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6256 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6258 * minibuf.c (Fread_from_minibuffer): Doc fix.
6260 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6262 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6263 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6265 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6267 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6268 value for non-existent files.
6270 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6272 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6273 set its "size" to -1. This will set the modtime_size field of
6274 the corresponding buffer to -1, which is what
6275 verify-visited-file-modtime expects for files that do not exist.
6278 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6280 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6282 * lisp.h: ... from here. push_key_description is no longer
6283 defined in keyboard.c, so its declaration should not be in
6284 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6285 logically belongs with push_key_description.
6287 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6289 * buffer.h: Include <sys/types.h> instead of <time.h>.
6290 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6291 Problem reported by Herbert J. Skuhra.
6293 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6295 * xml.c (parse_region): Make the parsing work for
6296 non-comment-starting XML files again (bug#9144).
6298 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6300 * image.c (gif_load): Fix calculation of bottom and right corner.
6303 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6305 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6306 redisplay in small windows.
6308 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6310 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6312 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6314 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6315 Operate on live windows only.
6317 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6319 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6321 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6323 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6324 only under bidi iteration.
6326 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6328 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6330 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6332 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6333 Without this fix, the command to link temacs failed due to an
6334 undefined symbol __builtin_isnan. This is because
6335 /usr/include/iso/math_c99.h #defines isnan(x) to
6336 __builtin_isnan(x), but the bundled gcc, which identifies itself
6337 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6339 * floatfns.c (isnan): #undef, and then #define to a clone of
6341 (Fisnan): Always define, since it's always available now.
6342 (syms_of_floatfns): Always define isnan at the Lisp level.
6344 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6346 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6348 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6350 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6351 The previous code assumed that file offsets (off_t values) fit in
6352 EMACS_INT variables, which is not true on typical 32-bit hosts.
6353 The code messed up by falsely reporting buffer overflow in cases
6354 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6355 when "big" contains more than 2**29 bytes, even though this
6356 inserts just one byte and does not overflow the buffer.
6357 (Finsert_file_contents): Store file offsets as off_t
6358 values, not as EMACS_INT values. Check for overflow when
6359 converting between EMACS_INT and off_t. When checking for
6360 buffer overflow or for overlap, take the offsets into account.
6361 Don't use EMACS_INT for small values where int suffices.
6362 When checking for overlap, fix a typo: ZV was used where
6363 ZV_BYTE was intended.
6364 (Fwrite_region): Don't assume off_t fits into 'long'.
6365 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6367 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6369 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6371 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6373 sprintf-related integer and memory overflow issues (Bug#9412).
6375 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6376 (esprintf, exprintf, evxprintf): New functions.
6377 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6378 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6379 (modify_event_symbol): Do not assume that the length of
6380 name_alist_or_stem is safe to alloca and fits in int.
6381 (Fexecute_extended_command): Likewise for function name and binding.
6382 (Frecursion_depth): Wrap around reliably on integer overflow.
6383 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6384 since some callers pass EMACS_INT values.
6385 (Fsingle_key_description): Don't crash if symbol name contains more
6386 than MAX_ALLOCA bytes.
6387 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6388 (get_minibuffer): Arg is now EMACS_INT, not int.
6389 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6390 (esprintf, exprintf, evxprintf): New decls.
6391 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6393 * dbusbind.c (signature_cat): New function.
6394 (xd_signature, Fdbus_register_signal):
6395 Do not overrun buffer; instead, report string overflow.
6397 * dispnew.c (add_window_display_history): Don't overrun buffer.
6398 Truncate instead; this is OK since it's just a log.
6400 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6401 even if the time zone offset is outlandishly large.
6402 Don't mishandle offset == INT_MIN.
6404 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6405 when creating daemon; the previous buffer-overflow check was incorrect.
6407 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6408 which has the guts of the old verror function.
6410 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6411 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6413 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6414 (font_unparse_xlfd): Don't blindly alloca long strings.
6415 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6416 fits in int, when using sprintf. Use single snprintf to count
6417 length of string rather than counting it via multiple sprintfs;
6418 that's simpler and more reliable.
6419 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6420 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6421 sprintf, in case result does not fit in int.
6423 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6424 (fontset_from_font): Print it.
6426 * frame.c (tty_frame_count): Now printmax_t, not int.
6427 (make_terminal_frame, set_term_frame_name): Print it.
6428 (x_report_frame_params): In X, window IDs are unsigned long,
6429 not signed long, so print them as unsigned.
6430 (validate_x_resource_name): Check for implausibly long names,
6431 and don't assume name length fits in 'int'.
6432 (x_get_resource_string): Don't blindly alloca invocation name;
6433 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6436 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6437 (xg_check_special_colors, xg_set_geometry):
6438 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6440 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6441 Use esprintf, not sprintf, in case result does not fit in int.
6443 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6444 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6445 it as a large positive number.
6446 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6447 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6449 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6450 in case result does not fit in int.
6452 * print.c (float_to_string): Detect width overflow more reliably.
6453 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6454 buffer overrun. Don't assume list length fits in 'int'. Treat
6455 print length of 0 as 0, not as infinity; to be consistent with other
6456 uses of print length in this function. Don't overflow print length
6457 index. Don't assume hash table size fits in 'long', or that
6458 vectorlike size fits in 'unsigned long'.
6460 * process.c (make_process): Use printmax_t, not int, to format
6461 process-name gensyms.
6463 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6465 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6466 to avoid potential buffer overrun.
6468 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6469 if X resource line is longer than 512 bytes.
6471 * xfns.c (x_window): Make sprintf buffer a bit bigger
6472 to avoid potential buffer overrun.
6474 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6476 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6478 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6480 Integer overflow fixes for scrolling, etc.
6481 Without these, Emacs silently mishandles large integers sometimes.
6482 For example, "C-u 4294967297 M-x recenter" was treated as if
6483 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6485 * xdisp.c (try_window_id): Check Emacs fixnum range before
6486 converting to 'int'.
6488 * window.c (window_scroll_line_based, Frecenter):
6489 Check that an Emacs fixnum is in range before assigning it to 'int'.
6490 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6491 values converted from Emacs fixnums.
6492 (Frecenter): Don't wrap around a line count if it is out of 'int'
6493 range; instead, treat it as an extreme value.
6494 (Fset_window_configuration, compare_window_configurations):
6495 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6497 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6498 that can exceed INT_MAX. Check that EMACS_INT value is in range
6499 before assigning it to the (possibly-narrower) index.
6500 (match_limit): Don't assume that a fixnum can fit in 'int'.
6502 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6505 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6506 (Fvertical_motion): Don't wrap around LINES values that don't fit
6507 in 'int'. Instead, treat them as extreme values. This is good
6508 enough for windows, which can't have more than INT_MAX lines anyway.
6510 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6512 * Require libxml/parser.h to avoid compilation warning.
6514 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6516 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6517 since this reportedly can destroy thread storage.
6519 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6521 * syntax.c (find_defun_start): Update all cache variables if
6522 exiting early (Bug#9401).
6524 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6526 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6528 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6529 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6530 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6532 * term.c (tty_append_glyph): New function.
6533 (produce_stretch_glyph): Static function and its prototype deleted.
6535 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6538 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6540 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6541 when checking :margin (Bug#9390).
6542 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6543 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6544 so that the name doesn't mislead. All uses changed.
6546 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6548 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6551 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6553 * xdisp.c (move_it_to): Don't bail out early when reaching
6554 position beyond to_charpos, if we are scanning backwards.
6555 (move_it_vertically_backward): When DY == 0, make sure we get to
6556 the first character in the line after the newline.
6558 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6560 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6561 (ccl_driver): Do not generate an out-of-range pointer.
6562 (Fccl_execute_on_string): Remove unnecessary check for
6563 integer overflow, noted by Stefan Monnier in
6564 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6565 Remove a FIXME that didn't need fixing.
6566 Simplify the newly-introduced buffer reallocation code.
6568 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6570 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6572 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6574 Integer and memory overflow issues (Bug#9196).
6576 * doc.c (get_doc_string): Rework so that
6577 get_doc_string_buffer_size is the actual buffer size, rather than
6578 being 1 less than the actual buffer size; this makes xpalloc more
6581 * image.c (x_allocate_bitmap_record, cache_image):
6582 * xselect.c (Fx_register_dnd_atom):
6583 Simplify previous changes by using xpalloc.
6585 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6586 since either will do and ptrdiff_t is convenient with xpalloc.
6588 * charset.c (charset_table_size)
6589 (struct charset_sort_data.priority): Now ptrdiff_t.
6590 (charset_compare): Don't overflow if priorities differ greatly.
6591 (Fsort_charsets): Don't assume list length fits in int.
6592 Check for size-calculation overflow when allocating sort data.
6593 (syms_of_charset): Allocate an initial charset table that is
6594 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6596 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6598 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6599 The actual value is always <= INT_MAX, and leaving it unsigned made
6600 overflow checking harder.
6602 * dispextern.h (struct glyph_matrix.rows_allocated)
6603 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6604 with xpalloc. The values are still always <= INT_MAX.
6606 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6608 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6609 (SAFE_NALLOCA): New macro.
6611 * region-cache.c (struct boundary.pos, find_cache_boundary)
6612 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6613 (set_cache_region, invalidate_region_cache)
6614 (revalidate_region_cache, know_region_cache, region_cache_forward)
6615 (region_cache_backward, pp_cache):
6616 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6617 so that ptrdiff_t * can be passed to xpalloc.
6618 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6619 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6620 (pp_cache): Don't assume cache_len fits in int.
6621 * region-cache.h: Adjust extern decls to match.
6623 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6624 EMACS_INT, since either will do, for xpalloc.
6626 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6627 (xnmalloc, xnrealloc, xpalloc): New functions.
6629 * bidi.c (bidi_shelve_header_size): New constant.
6630 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6631 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6633 * bidi.c (bidi_cache_shrink):
6634 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6636 Don't update size of array until after memory allocation succeeds,
6637 because xmalloc/xrealloc may not return.
6638 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6639 now that we have proper integer overflow checking.
6640 (record_overlay_string, overlay_strings): Catch overflows when
6641 calculating size of overlay_str_buf.
6643 * callproc.c (Fcall_process): Check for size overflow when
6644 calculating size of args2.
6645 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6646 Normally we prefer signed values, but sticking with ptrdiff_t would
6647 require adding more-complicated checks.
6649 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6650 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6651 Redo buffer-overflow calculations to avoid integer overflow.
6652 Add a FIXME comment where memory seems to be over-allocated.
6654 * character.c (Fstring): Check for size-calculation overflow.
6656 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6657 unnecessary integer overflow. Check for size overflow.
6658 (encode_coding_object): Don't update size until xmalloc succeeds.
6660 * composite.c (get_composition_id): Check for overflow in glyph
6661 length calculations.
6663 Integer and memory overflow fixes for display code.
6664 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6665 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6666 (scrolling_window): Check for overflow in size calculations.
6667 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6668 Don't assume glyph table len fits in int.
6669 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6670 (row_table_size): Now ptrdiff_t, not int.
6671 (scrolling_window): Avoid overflow in size calculations.
6672 Don't update size until allocation succeeds.
6673 * fns.c (concat): Check for overflow in size calculations.
6674 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6675 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6676 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6678 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6679 (get_doc_string): Check for size calculation overflow.
6680 Don't update size until allocation succeeds.
6681 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6682 EMACS_INT, where ptrdiff_t will do.
6683 (Fsubstitute_command_keys): Check for string overflow.
6685 * editfns.c (set_time_zone_rule): Don't assume environment length
6687 (message_length): Now ptrdiff_t, not int.
6688 (Fmessage_box): Don't update size until allocation succeeds.
6689 Don't assume message length fits in int.
6690 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6692 * emacs.c (main): Do not reallocate argv, since there is a null at
6693 the end that can be overwritten, and this way there's no need to
6694 worry about size-calculation overflow.
6695 (sort_args): Check for size-calculation overflow.
6697 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6699 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6701 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6702 (x_set_scroll_bar_width, x_figure_window_size):
6703 Check for integer overflow.
6704 (x_set_alpha): Do not assume XINT fits in int.
6706 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6707 This is for the members text_lines, text_cols, total_lines, total_cols,
6708 where the system imposes an 'int' limit.
6710 * fringe.c (Fdefine_fringe_bitmap):
6711 Don't update size until alloc works.
6713 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6714 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6716 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6717 Check for size-calculation overflow.
6718 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6719 do, as we prefer signed integers.
6720 (id_to_widget.max_size, id_to_widget.used)
6721 (xg_store_widget_in_map, xg_remove_widget_from_map)
6722 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6723 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6724 Use and return ptrdiff_t, not int.
6725 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6726 * gtkutil.h: Change prototypes to match the above.
6728 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6729 are duplicate now that they've been promoted to lisp.h.
6730 (x_allocate_bitmap_record, x_alloc_image_color)
6731 (make_image_cache, cache_image, xpm_load):
6732 Don't update size until alloc is done.
6733 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6735 Check for size calculation overflow.
6736 (ct_colors_allocated_max): New constant.
6737 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6740 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6741 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6742 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6743 Use ptrdiff_t, not int, to count maps.
6744 (read_char_minibuf_menu_prompt): Check for overflow in size
6745 calculations. Don't update size until allocation succeeds.
6746 Redo calculations to avoid overflow.
6747 * keyboard.h: Change prototypes to match the above.
6749 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6751 (current_minor_maps): Check for size calculation overflow.
6752 * keymap.h: Change prototypes to match the above.
6754 * lread.c (read1, init_obarray): Don't update size until alloc done.
6756 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6757 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6759 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6760 Now ptrdiff_t, not int.
6761 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6762 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6764 * process.c (Fnetwork_interface_list): Check for overflow
6765 in size calculation.
6767 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6769 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6770 overflow. Don't bother calling xmalloc when xrealloc will do.
6772 * search.c (Freplace_match): Check for size calculation overflow.
6773 (Fset_match_data): Don't assume list lengths fit in 'int'.
6775 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6776 for command line length. Do not attempt to address one before the
6777 beginning of an array, as that's not portable.
6779 * term.c (max_frame_lines): Remove; unused.
6780 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6782 (encode_terminal_code, calculate_costs): Check for size
6783 calculation overflow.
6784 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6785 table lengths and related sizes. Don't update size until alloc
6786 done. Redo calculations to avoid overflow.
6787 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6789 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6790 subtracting pointers.
6791 (gobble_line): Check for overflow more carefully. Don't update size
6794 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6795 Don't update size until alloc done.
6796 Redo size calculations to avoid overflow.
6797 Check for size calculation overflow.
6798 (main) [DEBUG]: Fix typo in invoking tparam1.
6800 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6801 Use ptrdiff_t, not int, for sizes.
6802 (store_mode_line_noprop_char): Don't update size until alloc done.
6804 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6805 Use ptrdiff_t, not int, for sizes.
6806 (Finternal_make_lisp_face, cache_face):
6807 Check for size calculation overflow.
6808 (cache_face): Treat size calculation overflows as if they were
6809 memory exhaustion (the usual treatment), rather than aborting.
6811 * xfns.c (x_encode_text, x_set_name_internal)
6812 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6813 sizes, since they can exceed INT_MAX in size. Check for size
6814 calculation overflow.
6816 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6817 (xg_select): Check for size calculation overflow.
6818 Don't update size until alloc done.
6820 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6821 as sprintf is limited to int lengths.
6823 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6824 (X_LONG_MIN): New macros.
6825 Use them to make the following changes clearer.
6826 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6827 This change doesn't affect the value now, but it may help remind
6828 future maintainers not to raise the value too much later.
6829 (SELECTION_QUANTUM): Remove, replacing with ...
6830 (selection_quantum): ... new function, which avoids overflow.
6832 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6833 assumption that selection length fits in 'int'.
6834 (x_reply_selection_request, x_handle_selection_request)
6835 (x_get_window_property, receive_incremental_selection)
6836 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6837 (lisp_data_to_selection_data, clean_local_selection_data):
6838 Use ptrdiff_t, not int, to record length of selection.
6839 (x_reply_selection_request, x_get_window_property)
6840 (receive_incremental_selection, x_property_data_to_lisp):
6841 Redo calculations to avoid overflow.
6842 (x_reply_selection_request): When sending hint, ceiling it at
6843 X_LONG_MAX rather than relying on wraparound overflow to send
6845 (x_get_window_property, receive_incremental_selection)
6846 (lisp_data_to_selection_data, x_property_data_to_lisp):
6847 Check for size-calculation overflow.
6848 (x_get_window_property, receive_incremental_selection)
6849 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6850 Don't store size until memory allocation succeeds.
6851 (x_get_window_property): Plug memory leak on memory exhaustion.
6852 Don't double-block input; malloc is safe here. Don't assume 2**34
6853 - 4 fits in unsigned long. Add an xassert to check
6854 XGetWindowProperty overflow. Be more careful about overflow
6855 calculations, and distinguish size from memory overflow better.
6856 (receive_incremental_selection): When tracing, don't assume
6857 unsigned int is less than INT_MAX.
6858 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6859 harmful) conversions of unsigned short to int.
6860 (lisp_data_to_selection_data): Don't assume that integers
6861 in the range -65535 through -1 fit in an X unsigned short.
6862 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6863 result parameters unless successful. Rely on cons_to_unsigned
6864 to report problems with elements; the old code wasn't right anyway.
6865 (x_check_property_data): Check for int overflow; we cannot use
6866 a wider type due to X limits.
6867 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6869 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6871 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6872 (x_term_init): Check for size calculation overflow.
6873 (x_color_cells): Don't store size until memory allocation succeeds.
6874 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6875 Don't assume alloca size is less than MAX_ALLOCA.
6876 (x_term_init): Don't assume length fits in int (sprintf is limited
6879 Use ptrdiff_t for composition IDs.
6880 * character.c (lisp_string_width):
6881 * composite.c (composition_table_size, n_compositions)
6882 (get_composition_id, composition_gstring_from_id):
6883 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6884 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6885 * window.c (Frecenter):
6886 Use ptrdiff_t, not int, for composition IDs.
6887 * composite.c (get_composition_id): Check for integer overflow.
6888 * composite.h: Adjust prototypes to match the above changes.
6890 Use ptrdiff_t for hash table indexes.
6891 * category.c (hash_get_category_set):
6892 * ccl.c (ccl_driver):
6893 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6894 * coding.c (coding_system_charset_list, detect_coding_system):
6895 * coding.h (struct coding_system.id):
6896 * composite.c (get_composition_id, gstring_lookup_cache):
6897 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6898 * image.c (xpm_get_color_table_h):
6899 * lisp.h (hash_lookup, hash_put):
6900 * minibuf.c (Ftest_completion):
6901 Use ptrdiff_t for hash table indexes, not int (which is too
6902 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6903 32-bit --with-wide-int hosts).
6905 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6906 Add a FIXME comment about memory leaks.
6907 (syms_of_charset): Don't assume xmalloc returns.
6909 Don't assume that stated character widths fit in int.
6910 * character.c (Fchar_width, c_string_width, lisp_string_width):
6911 * character.h (CHAR_WIDTH):
6912 * indent.c (MULTIBYTE_BYTES_WIDTH):
6913 Use sanitize_char_width to avoid undefined and/or bad behavior
6914 with outlandish widths.
6915 * character.h (sanitize_tab_width): Rename from sanitize_width,
6916 now that we have two such functions. All uses changed.
6917 (sanitize_char_width): New inline function.
6919 Don't assume that tab-width fits in int.
6920 * character.h (sanitize_width): New inline function.
6921 (SANE_TAB_WIDTH): New macro.
6922 (ASCII_CHAR_WIDTH): Use it.
6923 * indent.c (sane_tab_width): Remove. All uses replaced by
6924 SANE_TAB_WIDTH (current_buffer).
6925 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6927 * fileio.c: Integer overflow issues with file modes.
6928 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6930 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6931 Remove unreachable code.
6932 (read_hex, load_charset_map_from_file): Check for integer overflow.
6934 * xterm.c: Don't go over XClientMessageEvent limit.
6935 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6936 (x_send_scroll_bar_event): Likewise. Check that the size does not
6937 exceed limits imposed by XClientMessageEvent, as well as the usual
6938 ptrdiff_t and size_t limits.
6940 * keyboard.c: Overflow, signedness and related fixes.
6941 (make_lispy_movement): Use same integer type in forward decl
6942 that is used in the definition.
6943 (read_key_sequence, keyremap_step):
6944 Change bufsize argument back to int, undoing my 2011-03-30 change.
6945 We prefer signed types, and int is wide enough here.
6946 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6947 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6948 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6949 length, not size_t. Use ptrdiff_t for index, not int.
6950 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6951 possibility of integer overflow.
6953 Overflow, signedness and related fixes for images.
6955 * dispextern.h (struct it.stack[0].u.image.image_id)
6956 (struct_it.image_id, struct image.id, struct image_cache.size)
6957 (struct image_cache.used, struct image_cache.ref_count):
6958 * gtkutil.c (update_frame_tool_bar):
6959 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6960 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6961 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6962 * nsmenu.m (update_frame_tool_bar):
6963 * xdisp.c (calc_pixel_width_or_height):
6964 * xfns.c (image_cache_refcount):
6965 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6966 on typical 64-bit hosts.
6968 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6969 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6970 Omit unnecessary casts to int.
6971 (parse_image_spec): Check that integers fall into 'int' range
6972 when the callers expect that.
6973 (image_ascent): Redo ascent calculation to avoid int overflow.
6974 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6975 (lookup_image): Remove unnecessary tests.
6976 (xbm_image_p): Locals are now of int, not EMACS_INT,
6977 since parse_image_check makes sure they fit into int.
6978 (png_load, gif_load, svg_load_image):
6979 Prefer int to unsigned where either will do.
6980 (tiff_handler): New function, combining the cores of the
6981 old tiff_error_handler and tiff_warning_handler.
6982 This function is rewritten to use vsnprintf and thereby avoid
6983 stack buffer overflows. It uses only the features of vsnprintf
6984 that are common to both POSIX and native Microsoft.
6985 (tiff_error_handler, tiff_warning_handler): Use it.
6986 (tiff_load, gif_load, imagemagick_load_image):
6987 Don't assume :index value fits in 'int'.
6988 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6989 (imagemagick_load_image): Check that crop parameters fit into
6990 the integer types that MagickCropImage accepts. Don't assume
6991 Vimagemagick_render_type has a nonnegative value. Don't assume
6992 size_t fits in 'long'.
6993 (gs_load): Use printmax_t to print the widest integers possible.
6994 Check for integer overflow when computing image height and width.
6996 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6998 * xdisp.c (redisplay_window): Don't force window start if point
6999 will be invisible in the resulting window. (Bug#9324)
7001 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7003 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7004 the display spec is of the form `(space ...)'.
7005 (handle_display_spec): Return the value returned by
7006 handle_single_display_spec, not just 1 or zero.
7007 (handle_single_display_spec): If the display spec is of the form
7008 `(space ...)', and specifies display in the text area, return 2
7010 (try_cursor_movement): Check for the need to scroll more
7011 accurately, and prefer exact match for point under bidi.
7012 Don't advance `row' beyond the last row of the window.
7014 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7015 into disp_prop; all users changed.
7017 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7018 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7019 for the text covered by the display property.
7021 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7023 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7024 Change return value to nil.
7025 (Frecord_buffer): Delete unused function.
7027 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7029 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7030 buffers, return left-to-right.
7031 (set_cursor_from_row): Consider candidate row a win if its glyph
7032 represents a newline and point is on that newline. Fixes cursor
7033 positioning on the newline at EOL of R2L text within L2R
7034 paragraph, and vice versa.
7035 (try_cursor_movement): Check continued rows, in addition to
7036 continuation rows. Fixes unwarranted scroll when point enters a
7037 continued line of R2L text within an L2R paragraph, or vice versa.
7038 (cursor_row_p): Consider the case of point being equal to
7039 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7040 from the end of a short line to the beginning of a continued line
7041 of R2L text within L2R paragraph.
7042 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7043 composed characters.
7045 * bidi.c (bidi_check_type): Use xassert.
7046 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7049 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7051 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7054 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7056 * nsfont.m (ns_otf_to_script): Fix typo.
7058 2011-08-22 Kenichi Handa <handa@m17n.org>
7060 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7061 extra slot even if the purpose is char-code-property-table.
7063 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7065 * xdisp.c (redisplay_window): When computing centering_position,
7066 account for the height of the header line. (Bug#8874)
7068 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7069 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7070 candidate is selected by the mouse, and that candidate has a
7071 composed character under the mouse.
7073 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7074 coordinates reported by pos-visible-in-window-p for a composed
7075 character in column zero.
7077 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7079 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7081 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7083 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7084 consider it a hit if to_charpos is anywhere in the range of the
7085 composed buffer positions.
7087 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7089 * image.c (gif_load): Don't assume that each subimage has the same
7090 dimensions as the base image. Handle disposal method that is
7091 "undefined" by the gif spec (Bug#9335).
7093 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7095 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7096 (Fcondition_case): Document `debug' symbol in error handler.
7098 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7100 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7101 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7102 from an Org mode buffer to a Speedbar frame.
7104 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7105 a composition, take its buffer position from IT->cmp_it.charpos.
7106 Fixes cursor positioning at the beginning of a line that begins
7107 with a composed character.
7109 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7111 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7112 character bidirectional type, use STRONG_L instead. Fixes crashes
7113 in a buffer produced by `describe-categories'.
7115 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7116 members before the level stack, so they would be saved and
7117 restored when copying iterator state. Fixes incorrect reordering
7118 around TABs covered by display properties.
7120 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7122 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7124 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7126 * eval.c (internal_condition_case, internal_condition_case_1)
7127 (internal_condition_case_2, internal_condition_case_n):
7128 Remove unnecessary aborts (Bug#9081).
7130 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7132 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7133 has no `load' handler, try opening the file locally. (Bug#9311)
7135 2011-08-16 Ken Brown <kbrown@cornell.edu>
7137 * gmalloc.c: Expand comment.
7139 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7141 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7142 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7144 2011-08-16 Ken Brown <kbrown@cornell.edu>
7146 Fix memory allocation problems in Cygwin build (Bug#9273).
7148 * unexcw.c ( __malloc_initialized): Declare external variable.
7149 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7151 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7153 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7155 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7157 [CYGWIN] (special_realloc): New function.
7158 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7159 requests to realloc storage in the static heap.
7161 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7163 * bidi.c (bidi_initialize): Remove unused local.
7165 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7168 * biditype.h: Remove file.
7169 * makefile.w32-in ($(BLD)/bidi.$(O)):
7170 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7172 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7174 * chartab.c: Improve commentary for the uniprop_table API.
7176 * bidi.c (bidi_paragraph_init): Support zero value of
7177 bidi_ignore_explicit_marks_for_paragraph_level.
7178 (bidi_initialize): Use uniprop_table instead of including
7179 biditype.h and bidimirror.h.
7181 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7182 coordinates of the iterator when restoring from ppos_it.
7185 2011-08-14 Kenichi Handa <handa@m17n.org>
7187 * process.c (create_process): Call setup_process_coding_systems
7188 after the pid of the process is set to -1 (Bug#8162).
7190 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7192 * xdisp.c (move_it_in_display_line_to): Don't invoke
7193 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7194 ppos_it. Fixes vertical cursor motion when line beginning is
7195 covered by an image. (Bug#9296)
7197 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7199 * nsterm.h (ns_run_ascript): Declare.
7200 (NSAPP_DATA2_RUNASSCRIPT): Define.
7202 * nsfns.m (as_script, as_result, as_status): New static variables.
7203 (ns_run_ascript): New function.
7204 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7205 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7206 the event loop. Get status from as_status (Bug#7276).
7208 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7209 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7210 the event loop (Bug#7276).
7212 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7214 * gnutls.c (QCgnutls_bootprop_priority)
7215 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7216 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7217 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7218 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7219 (QCgnutls_bootprop_verify_hostname_error)
7220 (QCgnutls_bootprop_callbacks_verify): Rename from
7221 Qgnutls_bootprop_..., all uses changed.
7223 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7226 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7228 * xfaces.c (Qframe_set_background_mode): Now static.
7229 * dispextern.h (Qframe_set_background_mode): Remove decl.
7231 * process.c (Fnetwork_interface_info): Declare local only if needed.
7233 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7235 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7236 (Fnetwork_interface_list): Allocate in increments of bytes instead
7237 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7238 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7240 (struct ifflag_def): notrailers is smart on OSX.
7241 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7242 Get hardware address with getifaddrs if available.
7244 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7246 * xdisp.c (iterate_out_of_display_property): xassert that
7247 IT->position is set to within IT->object's boundaries. Break from
7248 the loop as soon as EOB is reached; avoids infloops in redisplay
7249 when IT->position is set up wrongly due to some bug.
7250 Set IT->current to match the bidi iterator unconditionally.
7251 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7252 entry. Force push_it to save on the stack the current
7253 buffer/string position, to be restored by pop_it. Fix flags in
7254 the iterator structure wrt the object coming from a display
7255 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7256 properties. (Bug#9284)
7258 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7260 * fontset.c (fontset_get_font_group): Add proper type checks.
7263 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7265 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7266 and LC_VERSION_MIN_MACOSX.
7267 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7268 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7270 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7272 * xdisp.c (forward_to_next_line_start): Allow to use the
7273 no-display-properties-and-no-overlays under bidi display.
7274 Set disp_pos in the bidi iterator to avoid searches for display
7275 properties and overlays.
7277 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7279 * editfns.c (Fset_time_zone_rule): Document relationship with the
7282 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7283 the font entity extracted from the cache (Bug#8109).
7285 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7287 * composite.c (autocmp_chars): Don't reset point. That is done by
7288 restore_point_unwind (Bug#5984).
7290 2011-08-07 Juri Linkov <juri@jurta.org>
7292 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7293 to show the arg `TIME' instead of `TIMEVAL'.
7295 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7297 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7298 display property strides EOL and includes a newline, as in
7299 longlines-mode. (Bug#9254)
7300 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7301 word-wrap under bidirectional display. (Bug#9224)
7303 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7304 is non-zero, even if the data buffer is NULL. Fixes a crash in
7305 vertical-motion with longlines-mode. (Bug#9254)
7307 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7309 * bidi.c <bidi_cache_total_alloc>: Now static.
7310 (bidi_initialize): Initialize bidi_cache_total_alloc.
7312 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7315 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7316 amount allocated this far in `bidi_cache_total_alloc'.
7317 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7318 non-zero, only free the data buffer without restoring the cache
7319 contents. All callers changed.
7321 * dispextern.h (bidi_unshelve_cache): Update prototype.
7323 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7324 (move_it_in_display_line, move_it_to)
7325 (move_it_vertically_backward, move_it_by_lines): Replace the call
7326 to xfree to an equivalent call to bidi_unshelve_cache.
7327 (move_it_in_display_line_to): Fix logic of returning
7328 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7330 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7332 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7333 came from a string character with a `cursor' property. (Bug#9229)
7335 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7337 * Makefile.in (LIB_PTHREAD): New variable.
7338 (LIBES): Add LIB_PTHREAD (Bug#9216).
7340 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7341 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7343 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7345 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7347 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7349 * xterm.c (x_find_topmost_parent): New function.
7350 (x_set_frame_alpha): Find topmost parent window with
7351 x_find_topmost_parent and set the property there also (bug#9181).
7352 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7354 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7356 * callproc.c (Fcall_process): Avoid vfork clobbering
7357 the local vars buffer, coding_systems, current_dir.
7359 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7361 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7363 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7365 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7366 so that it is not optimized away.
7368 * xdisp.c (compute_display_string_pos): Remove unused local.
7370 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7372 Fix slow cursor motion and scrolling in large buffers with
7373 selective display, like Org Mode buffers. (Bug#9218)
7375 * dispextern.h (struct bidi_it): New member disp_prop_p.
7377 * xdisp.c: Remove one-slot cache of display string positions.
7378 (compute_display_string_pos): Accept an additional argument
7379 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7380 for a display string or property. If found, set DISP_PROP_P
7383 * bidi.c (bidi_fetch_char): Accept an additional argument
7384 DISP_PROP_P, and pass it to compute_display_string_pos.
7385 Only handle text covered by a display string if DISP_PROP_P is returned
7386 non-zero. All callers of bidi_fetch_char changed.
7388 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7390 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7392 2010-12-03 Don March <don@ohspite.net>
7394 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7395 last character M-[char] is translated to ESC [char] (bug#7541).
7397 2011-08-02 Kenichi Handa <handa@m17n.org>
7399 * lisp.h (uniprop_table): Extern it.
7401 * chartab.c (uniprop_table): Make it non-static.
7403 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7405 * xdisp.c (forward_to_next_line_start): Accept additional argument
7406 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7408 (reseat_at_next_visible_line_start): Use the bidi iterator state
7409 returned by forward_to_next_line_start to restore the state of
7410 it->bidi_it after backing up to previous newline. (Bug#9212)
7412 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7414 * regex.c (re_comp): Protoize.
7415 (re_exec): Fix return type.
7416 (regexec): Fix type of `ret'. (Bug#9203)
7418 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7420 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7421 This is needed if max-image-size is a floating-point number.
7423 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7425 * print.c (print_object): Print empty symbol as ##.
7427 * lread.c (read1): Read ## as empty symbol.
7429 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7431 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7432 setting frame foreground color (Bug#9175).
7433 (x_set_background_color): Likewise.
7435 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7436 contents (Bug#9176).
7437 (EmacsTooltip -init): Remove bezels and add shadows to
7440 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7441 or scroll bar (Bug#8470).
7443 * nsfont.m (nsfont_open): Remove assignment to voffset and
7444 unnecessary vars hshink, expand, hd, full_height, min_height.
7445 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7447 * nsterm.h (nsfont_info): Remove voffset field.
7449 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7451 Implement strike-through and overline on NextStep (Bug#8863).
7453 * nsfont.m (nsfont_open): Use underline position provided by font,
7454 instead of hard-coded value of 2.
7455 (nsfont_draw): Call ns_draw_text_decoration instead.
7457 * nsterm.h: Add declaration for ns_draw_text_decoration.
7459 * nsterm.m (ns_draw_text_decoration): New function for drawing
7460 underline, overline, and strike-through.
7461 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7462 ns_draw_text_decoration. Change treatment of cursor drawing to
7463 accommodate underlining, etc.
7465 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7467 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7470 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7472 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7473 Without this fix, if a signal arrives just after memory fills up,
7474 'malloc' might be invoked reentrantly.
7476 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7477 In other words, assume that every image size is allowed, on non-X
7478 hosts. This assumption is probably wrong, but it lets Emacs compile.
7480 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7482 * regex.c (re_iswctype): Convert return values to boolean.
7484 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7486 * xdisp.c (compute_display_string_pos): Don't use cached display
7487 string position if the buffer had its restriction changed.
7490 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7492 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7494 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7496 Integer signedness and overflow and related fixes. (Bug#9079)
7498 * bidi.c: Integer size and overflow fixes.
7499 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7500 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7501 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7502 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7503 (bidi_find_other_level_edge):
7504 Use ptrdiff_t instead of EMACS_INT where either will do.
7505 This works better on 32-bit hosts configured --with-wide-int.
7506 (bidi_cache_ensure_space): Check for size-calculation overflow.
7507 Use % rather than repeated addition, for better worst-case speed.
7508 Don't set bidi_cache_size until after xrealloc returns, because it
7510 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7511 (bidi_cache_ensure_space): Also check that the bidi cache size
7512 does not exceed that of the largest Lisp string or buffer. See Eli
7513 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7515 * alloc.c (__malloc_size_t): Remove.
7516 All uses replaced by size_t. See Andreas Schwab's note
7517 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7519 * image.c: Improve checking for integer overflow.
7520 (check_image_size): Assume that f is nonnull, since
7521 it is always nonnull in practice. This is one less thing to
7522 worry about when checking for integer overflow later.
7523 (x_check_image_size): New function, which checks for integer
7524 overflow issues inside X.
7525 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7526 This removes the need for a memory_full check.
7527 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7528 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7529 (xbm_read_bitmap_data): Change locals back to 'int', since
7530 their values must fit in 'int'.
7531 (xpm_load_image, png_load, tiff_load):
7532 Invoke x_create_x_image_and_pixmap earlier,
7533 to avoid much needless work if the image is too large.
7534 (tiff_load): Treat overly large images as if
7535 x_create_x_image_and_pixmap failed, not as malloc failures.
7536 (gs_load): Use x_check_image_size.
7538 * gtkutil.c: Omit integer casts.
7539 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7540 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7542 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7544 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7545 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7546 would wrongly return t on a 64-bit host.
7548 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7549 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7550 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7551 and therefore cause GCC to emit a bogus diagnostic in some cases.
7553 * image.c: Integer signedness and overflow and related fixes.
7554 This is not an exhaustive set of fixes, but it's time to
7555 record what I've got.
7556 (lookup_pixel_color, check_image_size): Remove redundant decls.
7557 (check_image_size): Don't assume that arbitrary EMACS_INT values
7558 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7559 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7560 (tiff_load, imagemagick_load_image):
7561 Check for overflow in size calculations.
7562 (x_create_x_image_and_pixmap): Remove unnecessary test for
7563 xmalloc returning NULL; that can't happen.
7564 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7565 (xpm_color_bucket): Use better integer hashing function.
7566 (xpm_cache_color): Don't possibly over-allocate memory.
7567 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7568 (gif_memory_source):
7569 Use ptrdiff_t, not int or size_t, to record sizes.
7570 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7571 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7572 either works, as we prefer signed integers.
7573 (tiff_read_from_memory, tiff_write_from_memory):
7574 Return tsize_t, not size_t, since that's what the TIFF API wants.
7575 (tiff_read_from_memory): Don't fail simply because the read would
7576 go past EOF; instead, return a short read.
7577 (tiff_load): Omit no-longer-needed casts.
7578 (Fimagemagick_types): Don't assume size fits into 'int'.
7580 Improve hashing quality when configured --with-wide-int.
7581 * fns.c (hash_string): New function, taken from sxhash_string.
7582 Do not discard information about ASCII character case; this
7583 discarding is no longer needed.
7584 (sxhash-string): Use it. Change sig to match it. Caller changed.
7585 * lisp.h: Declare it.
7586 * lread.c (hash_string): Remove, since we now use fns.c's version.
7587 The fns.c version returns a wider integer if --with-wide-int is
7588 specified, so this should help the quality of the hashing a bit.
7590 * emacs.c: Integer overflow minor fix.
7591 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7592 Define only if GNU_LINUX.
7593 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7595 * dispnew.c: Integer signedness and overflow fixes.
7596 Remove unnecessary forward decls, that were a maintenance hassle.
7597 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7599 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7600 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7601 (prepare_desired_row, line_draw_cost):
7602 Use int, not unsigned, where either works.
7603 (save_current_matrix, restore_current_matrix):
7604 Use ptrdiff_t, not size_t, where either works.
7605 (init_display): Check for overflow more accurately, and without
7606 relying on undefined behavior.
7608 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7609 Remove, replacing with the new symbols in lisp.h. All uses changed.
7610 * fileio.c (make_temp_name):
7611 * filelock.c (lock_file_1, lock_file):
7612 * xdisp.c (message_dolog):
7613 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7614 Use pMd etc. instead.
7615 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7616 replacing the pWIDE etc. symbols removed from editfns.c.
7618 * keyboard.h (num_input_events): Now uintmax_t.
7619 This is (very slightly) less likely to mess up due to wraparound.
7622 * buffer.c: Integer signedness fixes.
7623 (alloc_buffer_text, enlarge_buffer_text):
7624 Use ptrdiff_t rather than size_t when either will do, as we prefer
7627 * alloc.c: Integer signedness and overflow fixes.
7628 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7629 (__malloc_size_t): Default to size_t, not to int.
7630 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7631 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7632 Prefer ptrdiff_t to size_t when either would do, as we prefer
7634 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7635 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7636 Now const. Initialize with values that are in range even if char
7638 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7639 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7640 These functions do the right thing with sizes > 2**32.
7641 (check_depth): Now ptrdiff_t, not int.
7642 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7643 Adjust to new way of storing sizes. Check for size overflow bugs
7645 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7646 slightly wrong anyway, as it missed one instance of
7647 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7648 (refill_memory_reserve): Omit needless cast to size_t.
7649 (mark_object_loop_halt): Mark as externally visible.
7651 * xselect.c: Integer signedness and overflow fixes.
7652 (Fx_register_dnd_atom, x_handle_dnd_message):
7653 Use ptrdiff_t, not size_t, since we prefer signed.
7654 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7655 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7656 x_dnd_atoms_size and x_dnd_atoms_length.
7658 * doprnt.c: Prefer signed to unsigned when either works.
7660 * doprnt.c (doprnt):
7662 * xdisp.c (vmessage):
7663 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7664 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7665 prefer signed arithmetic to avoid comparison confusion.
7666 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7667 but is a bit tricky.
7669 Assume freestanding C89 headers, string.h, stdlib.h.
7670 * data.c, doprnt.c, floatfns.c, print.c:
7671 Include float.h unconditionally.
7672 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7673 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7674 * regex.c: Likewise for stddef.h, string.h.
7675 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7676 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7677 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7678 (STDC_HEADERS): Remove obsolete defines.
7679 * sysdep.c: Include limits.h unconditionally.
7681 Assume support for memcmp, memcpy, memmove, memset.
7682 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7683 * regex.c (memcmp, memcpy):
7684 Remove; we assume C89 now.
7686 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7687 (__malloc_safe_bcopy): Remove; no longer needed.
7689 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7690 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7691 well either way, and we prefer signed to unsigned.
7693 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7695 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7696 closes the connection while we're reading (bug#9182).
7698 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7700 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7701 are specified (Bug#9168).
7703 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7705 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7706 Found by GCC static checking and --with-wide-int on a 32-bit host.
7708 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7710 * xdisp.c (compute_display_string_pos): Fix logic of caching
7711 previous display string position. Initialize cached_prev_pos to
7712 -1. Fixes slow-down at the beginning of a buffer.
7714 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7716 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7717 for attrs[LFACE_FONTSET_INDEX].
7719 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7721 * xml.c (parse_region): Remove unused local
7722 that was recently introduced.
7724 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7726 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7727 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7729 * xdisp.c (move_it_in_display_line_to): Record the best matching
7730 position for TO_CHARPOS while scanning the line, and restore it on
7731 exit if none of the characters scanned was an exact match.
7732 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7733 when exact match is impossible due to invisible text, and the
7734 lines are truncated.
7736 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7738 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7741 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7743 Fix a significant slow-down of cursor motion with C-n, C-p,
7744 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7745 auto-repeat under bidi redisplay in fontified buffers.
7746 * xdisp.c (compute_stop_pos_backwards): New function.
7747 (next_element_from_buffer): Call compute_stop_pos_backwards to
7748 find a suitable prev_stop when we find ourselves before
7750 (reseat): Don't look for prev_stop, as that could mean a very long
7752 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7753 <cached_disp_overlay_modiff>: Cache for last found display string
7755 (compute_display_string_pos): Return the cached position if asked
7756 about the same buffer in the same area of character positions, and
7757 the buffer wasn't changed since the time the display string
7758 position was cached.
7760 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7762 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7763 is an integer, which is important for empty lines. (Bug#9149)
7765 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7767 * frame.c (Fmodify_frame_parameters): In tty case, update the
7768 default face if necessary (Bug#4238).
7770 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7772 * editfns.c (Fstring_to_char): No need to explain what a character
7773 is in the docstring (Bug#6576).
7775 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7777 * xml.c (parse_region): Make sure we always return a tree.
7779 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7781 * xml.c (parse_region): If a document contains only comments,
7784 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7786 * xml.c (make_dom): Return comments, too.
7788 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7791 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7792 and the surrounding thread.
7793 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7794 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7795 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7797 * s/openbsd.h (BROKEN_SIGIO): Define.
7798 * unexelf.c (unexec) [__OpenBSD__]:
7799 Don't update the .mdebug section of the Alpha COFF symbol table.
7801 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7803 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7806 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7808 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7809 This fixes some race conditions on the permissions of any newly
7812 * alloc.c (valid_pointer_p): Use pipe, not open.
7813 This fixes some permissions issues when debugging.
7815 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7816 If fchown fails to set both uid and gid, try to set just gid,
7817 as that is sometimes allowed. Adjust the file's mode to eliminate
7818 setuid or setgid bits that are inappropriate if fchown fails.
7820 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7822 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7823 to compare Lisp_Objects.
7824 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7825 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7826 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7828 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7830 * lread.c (read_integer): Unread even EOF character.
7831 (read1): Likewise. Properly record start position of symbol.
7833 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7834 symbol character follows.
7836 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7838 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7839 This works around a problem with the previous change to Fcopy_file.
7840 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7841 and without this change, GCC might complain about discarding
7842 fchown's return value.
7844 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7846 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7848 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7850 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7852 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7854 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7855 it's used from the C level.
7857 * process.c: Use the same condition for POLL_FOR_INPUT in both
7858 keyboard.c and process.c (bug#1858).
7860 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7862 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7863 (Fgnutls_boot): Use it.
7865 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7867 * doc.c (Fsubstitute_command_keys): Revert last change.
7869 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7871 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7872 quotes the next character, and doesn't affect other longer
7873 sequences (bug#8935).
7875 * lread.c (syms_of_lread): Clarify that is isn't only
7876 `eval-buffer' and `eval-defun' that's affected by
7877 `lexical-binding' (bug#8460).
7879 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7881 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7882 bidi redisplay when a line includes both an image and is truncated.
7884 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7886 Fix minor problems found by static checking.
7887 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7888 (elsz): Now a signed constant, not a size_t var. We prefer signed
7889 types to unsigned, to avoid integer comparison confusion. Without
7890 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7891 "cannot optimize loop, the loop counter may overflow", a symptom
7893 * indent.c (Fvertical_motion): Mark locals as initialized.
7894 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7896 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7898 * search.c (Fre_search_backward): Mention `case-fold-search' in
7899 all the re_search_* functions (bug#8138).
7901 * keyboard.c (Fopen_dribble_file): Document when the file is
7904 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7906 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7909 Support bidi reordering of display and overlay strings.
7910 * xdisp.c (compute_display_string_pos)
7911 (compute_display_string_end): Accept additional argument STRING.
7912 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7913 (reseat_to_string): Initialize bidi_it->string.s and
7914 bidi_it->string.schars.
7915 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7916 NULL (avoids a crash in bidi_paragraph_init).
7917 Initialize itb.string.lstring.
7918 (init_iterator): Call bidi_init_it only of a valid
7919 buffer position was specified. Initialize paragraph_embedding to
7921 (reseat_to_string): Initialize the bidi iterator.
7922 (display_string): If we need to ignore text properties of
7923 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7924 original value of -1 will not work with bidi.)
7925 (compute_display_string_pos): First arg is now struct
7926 `text_pos *'; all callers changed. Support display properties on
7928 (compute_display_string_end): Support display properties on Lisp
7930 (init_iterator, reseat_1, reseat_to_string): Initialize the
7931 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7932 when iterating on a string not from display properties).
7933 (compute_display_string_pos, compute_display_string_end):
7934 Fix calculation of the object to scan. Fixes an error when using
7936 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7937 base_level_stop; instead, set base_level_stop to BEGV.
7938 Fixes crashes in vertical-motion.
7939 (next_element_from_buffer): Improve commentary for when
7940 the iterator is before prev_stop.
7941 (init_iterator): Initialize bidi_p from the default value of
7942 bidi-display-reordering, not from buffer-local value. Use the
7943 buffer-local value only if initializing for buffer iteration.
7944 (handle_invisible_prop): Support invisible properties on strings
7945 that are being bidi-reordered.
7946 (set_iterator_to_next): Support bidi reordering of C strings and
7948 (next_element_from_string): Support bidi reordering of Lisp
7950 (handle_stop_backwards): Support Lisp strings as well.
7951 (display_string): Support display of R2L glyph rows.
7952 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7953 (init_iterator): Don't initialize it->bidi_p for strings
7955 (reseat_to_string): Initialize it->bidi_p for strings here.
7956 (next_element_from_string, next_element_from_c_string)
7957 (next_element_from_buffer): Add xassert's for correspondence
7958 between IT's object being iterated and it->bidi_it.string
7960 (face_before_or_after_it_pos): Support bidi iteration.
7961 (next_element_from_c_string): Handle the case of the first string
7962 character that is not the first one in the visual order.
7963 (get_visually_first_element): New function, refactored from common
7964 parts of next_element_from_buffer, next_element_from_string, and
7965 next_element_from_c_string.
7966 (tool_bar_lines_needed, redisplay_tool_bar)
7967 (display_menu_bar): Force left-to-right direction. Add a FIXME
7968 comment for making that be controlled by a user option.
7969 (push_it, pop_it): Save and restore the state of the
7970 bidi iterator. Save and restore the bidi_p flag.
7971 (pop_it): Iterate out of display property for string iteration as
7973 (iterate_out_of_display_property): Support iteration over strings.
7974 (handle_single_display_spec): Set up it->bidi_it for iteration
7975 over a display string, and call bidi_init_it.
7976 (handle_single_display_spec, next_overlay_string)
7977 (get_overlay_strings_1, push_display_prop): Set up the bidi
7978 iterator for displaying display or overlay strings.
7979 (forward_to_next_line_start): Don't use the shortcut if
7981 (back_to_previous_visible_line_start): If handle_display_prop
7982 pushed the iterator stack, restore the internal state of the bidi
7983 iterator by calling bidi_pop_it same number of times.
7984 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7985 and we are bidi-iterating, don't decrement the iterator position;
7986 instead, set the first_elt flag in the bidi iterator, to produce
7988 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7989 (push_display_prop): xassert that we are iterating a buffer.
7990 (push_it, pop_it): Save and restore paragraph_embedding member.
7991 (handle_single_display_spec, next_overlay_string)
7992 (get_overlay_strings_1, reseat_1, reseat_to_string)
7993 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7994 correctly. Don't assume unibyte strings are not bidi-reordered.
7995 (compute_display_string_pos)
7996 (compute_display_string_end): Fix handling the case of C string.
7997 (push_it, pop_it): Save and restore from_disp_prop_p.
7998 (handle_single_display_spec, push_display_prop): Set the
7999 from_disp_prop_p flag.
8000 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8001 (pop_it): Call iterate_out_of_display_property only if we are
8002 popping after iteration over a string that came from a display
8003 property. Fix a typo in popping stretch info. Add an assertion
8004 for verifying that the iterator position is in sync with the bidi
8006 (handle_single_display_spec, get_overlay_strings_1)
8007 (push_display_prop): Fix initialization of paragraph direction for
8008 string when that of the parent object is not yet determined.
8009 (reseat_1): Call bidi_init_it to resync the bidi
8010 iterator with IT's position. (Bug#7616)
8011 (find_row_edges): If ROW->start.pos gives position
8012 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8013 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8014 Reset the from_disp_prop_p flag.
8015 (SAVE_IT, RESTORE_IT): New macros.
8016 (pos_visible_p, face_before_or_after_it_pos)
8017 (back_to_previous_visible_line_start)
8018 (move_it_in_display_line_to, move_it_in_display_line)
8019 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8020 (try_scrolling, redisplay_window, display_line): Use them when
8021 saving a temporary copy of the iterator and restoring it back.
8022 (back_to_previous_visible_line_start, reseat_1)
8023 (init_iterator): Empty the bidi cache "stack".
8024 (move_it_in_display_line_to): If iterator ended up at
8025 EOL, but we never saw any buffer positions smaller than
8026 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8027 motion in bidi-reordered lines.
8028 (move_it_in_display_line_to): Record prev_method and prev_pos
8029 immediately before the call to set_iterator_to_next. Fixes cursor
8030 motion in bidi-reordered lines with stretch glyphs and strings
8031 displayed in margins. (Bug#8133) (Bug#8867)
8032 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8034 (pos_visible_p): Support positions in bidi-reordered lines.
8035 Save and restore bidi cache.
8037 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8038 (bidi_paragraph_info): Delete unused struct.
8039 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8040 (bidi_cache_start): New variable.
8041 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8043 (bidi_cache_fetch_state, bidi_cache_search)
8044 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8045 (bidi_cache_find, bidi_peek_at_next_level)
8046 (bidi_level_of_next_char, bidi_find_other_level_edge)
8047 (bidi_move_to_visually_next): Compare cache index with
8048 bidi_cache_start rather than with zero.
8049 (bidi_fetch_char): Accept new argument STRING; all callers
8050 changed. Support iteration over a string. Support strings with
8051 display properties. Support unibyte strings. Fix the type of
8052 `len' according to what STRING_CHAR_AND_LENGTH expects.
8053 (bidi_paragraph_init, bidi_resolve_explicit_1)
8054 (bidi_resolve_explicit, bidi_resolve_weak)
8055 (bidi_level_of_next_char, bidi_move_to_visually_next):
8056 Support iteration over a string.
8057 (bidi_set_sor_type, bidi_resolve_explicit_1)
8058 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8059 can now be zero (for strings); special values 0 and -1 were
8060 changed to -1 and -2, respectively.
8061 (bidi_char_at_pos): New function.
8062 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8063 Call it instead of FETCH_MULTIBYTE_CHAR.
8064 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8065 initialized to valid values.
8066 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8068 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8069 the test for valid cached positions. Fix the logic for looking up
8070 the sentinel state in the cache. GCPRO the Lisp string we are
8072 (bidi_push_it, bidi_pop_it): New functions.
8073 (bidi_initialize): Initialize the bidi cache start stack pointer.
8074 (bidi_cache_ensure_space): New function, refactored from part of
8075 bidi_cache_iterator_state. Don't assume the required size is just
8076 one BIDI_CACHE_CHUNK away.
8077 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8078 (bidi_count_bytes, bidi_char_at_pos): New functions.
8079 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8080 always valid if bidi_cache_idx is valid.
8081 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8082 is valid if it's going to be used.
8083 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8084 (bidi_cache_fetch_state, bidi_cache_search)
8085 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8086 (bidi_cache_iterator_state, bidi_cache_find)
8087 (bidi_find_other_level_edge, bidi_cache_start_stack):
8088 All variables related to cache indices are now EMACS_INT.
8090 * dispextern.h (struct bidi_string_data): New structure.
8091 (struct bidi_it): New member `string'. Make flag members be 1-bit
8092 fields, and put them last in the struct.
8093 (compute_display_string_pos, compute_display_string_end):
8095 (bidi_push_it, bidi_pop_it): Add prototypes.
8096 (struct iterator_stack_entry): New members bidi_p,
8097 paragraph_embedding, and from_disp_prop_p.
8098 (struct it): Member bidi_p is now a bit field 1 bit wide.
8099 (bidi_shelve_cache, bidi_unshelve_cache):
8102 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8103 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8104 and vector-like objects.
8106 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8107 cache around display iteration.
8109 * window.c (Fwindow_end, window_scroll_pixel_based)
8110 (displayed_window_lines, Frecenter): Save and restore the bidi
8111 cache around display iteration.
8113 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8115 * editfns.c (Fdelete_region): Clarify the use of the named
8116 parameters (bug#6788).
8118 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8120 * indent.c (Fvertical_motion): Set and restore w->pointm when
8121 saving and restoring the window's buffer (Bug#9006).
8123 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8125 * editfns.c (Fstring_to_char): Clarify just what is returned
8126 (bug#6576). Text by Eli Zaretskii.
8128 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8130 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8132 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8134 * buffer.c (mmap_find): Fix a typo.
8136 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8138 Fix execution of x selection hooks.
8139 * xselect.c (Qx_lost_selection_functions)
8140 (Qx_sent_selection_functions): New vars.
8141 (syms_of_xselect): DEFSYM them.
8142 (x_handle_selection_request): Pass Qx_sent_selection_functions
8143 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8144 (x_handle_selection_clear,x_clear_frame_selections):
8145 Pass Qx_lost_selection_functions rather than
8146 Vx_lost_selection_functions to Frun_hook_with_args.
8148 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8150 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8151 The old code sometimes used this field without initializing it.
8153 * alloc.c (gc_sweep): Don't read past end of array.
8154 In theory, the old code could also have corrupted Emacs internals,
8155 though it'd be very unlikely.
8157 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8159 * character.c (Fcharacterp): Don't advertise optional ignored
8160 argument. (Bug#4026)
8162 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8164 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8167 * window.c (Fset_window_start): Doc fix (bug#4199).
8168 (Fset_window_hscroll): Ditto.
8170 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8172 Fix minor new problems caught by GCC 4.6.1.
8173 * term.c (init_tty): Remove unused local.
8174 * xsettings.c (store_monospaced_changed): Define this function only
8175 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8178 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8180 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8182 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8184 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8185 are the mini-buffer and the echo area (bug#3320).
8187 * term.c (init_tty): Remove support for supdup, c10 and perq
8188 terminals, which are no longer supported (bug#1482).
8190 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8192 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8194 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8196 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8197 for non-popups (Bug#3642).
8199 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8201 * alloc.c (reset_malloc_hooks): Protoize.
8202 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8203 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8204 * cm.c (losecursor): Likewise.
8205 * data.c (fmod): Likewise.
8206 * dispnew.c (swap_glyphs_in_rows): Likewise.
8207 * emacs.c (memory_warning_signal): Likewise.
8208 * floatfns.c (float_error): Likewise.
8209 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8210 (otf_open, font_otf_capability, generate_otf_features)
8211 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8213 * image.c (pbm_read_file): Likewise.
8214 * indent.c (string_display_width): Likewise.
8215 * intervals.c (check_for_interval, search_for_interval)
8216 (inc_interval_count, count_intervals, root_interval)
8217 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8218 * lread.c (defalias): Likewise.
8219 * ralloc.c (r_alloc_check): Likewise.
8220 * regex.c (set_image_of_range_1, set_image_of_range)
8221 (regex_grow_registers): Likewise.
8222 * sysdep.c (strerror): Likewise.
8223 * termcap.c (valid_filename_p, tprint, main): Likewise.
8224 * tparam.c (main): Likewise.
8225 * unexhp9k800.c (run_time_remap, save_data_space)
8226 (update_file_ptrs, read_header, write_header, calculate_checksum)
8227 (copy_file, copy_rest, display_header): Likewise.
8228 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8230 * xdisp.c (check_it): Likewise.
8231 * xfaces.c (register_color, unregister_color, unregister_colors):
8233 * xfns.c (print_fontset_result): Likewise.
8234 * xrdb.c (member, fatal, main): Likewise.
8236 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8238 Fix minor problems found by static checking (Bug#9031).
8239 * chartab.c (char_table_set_range, map_sub_char_table):
8240 Remove unused locals.
8241 (uniprop_table): Now static.
8242 * composite.c (_work_char): Remove unused static var.
8244 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8246 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8248 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8250 * gtkutil.c (qttip_cb): Remove code without function.
8252 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8254 * w32.c (pthread_sigmask): New stub.
8256 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8258 Use pthread_sigmask, not sigprocmask (Bug#9010).
8259 sigprocmask is portable only for single-threaded applications, and
8260 Emacs can be multi-threaded when it uses GTK.
8261 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8263 * callproc.c (Fcall_process):
8264 * process.c (create_process):
8265 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8266 Use pthread_sigmask, not sigprocmask.
8268 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8270 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8271 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8274 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8276 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8277 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8278 (xg_hide_tooltip): Fix comment.
8280 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8281 in registerServicesMenuSendTypes.
8282 (validRequestorForSendType): Don't check ns_return_types.
8284 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8287 2011-07-08 Jason Rumney <jasonr@gnu.org>
8289 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8290 SH_SHOW for hidden windows (Bug#5482).
8292 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8293 frame struct members of non-existent frames (Bug#6284).
8295 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8297 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8298 variable firstTime not needed on OSX >= 10.6.
8299 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8300 >= 10.5. Use setKnobProportion, setDoubleValue.
8302 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8303 (MAC_OS_X_VERSION_10_5): Define if not defined.
8304 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8305 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8306 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8308 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8309 cString and lossyCString on OSX >= 10.4.
8311 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8312 sizeToFit on OSX >= 10.2.
8314 * nsimage.m (allocInitFromFile): Don't use deprecated method
8315 bestRepresentationForDevice on OSX >= 10.6.
8317 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8320 * emacs.c: Declare unexec_init_emacs_zone.
8322 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8324 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8326 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8327 on svcsMenu (Bug#8842).
8329 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8331 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8333 * nsterm.m (QUTF8_STRING): Declare.
8334 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8335 (validRequestorForSendType): Return type is (id).
8336 Change indexOfObjectIdenticalTo to indexOfObject.
8337 Check if we have local selection before returning self (Bug#8842).
8338 (writeSelectionToPasteboard): Put local selection into paste board
8339 if we have a local selection (Bug#8842).
8340 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8342 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8343 (ns_get_local_selection): Declare.
8345 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8347 * keymap.c (describe_map_tree): Don't insert a double newline at
8348 the end of the buffer (bug#1169) and return whether we inserted
8351 * callint.c (Fcall_interactively): Change "reading args" to
8352 "providing args" to try to clarify what it does (bug#1010).
8354 2011-07-07 Kenichi Handa <handa@m17n.org>
8356 * composite.c (composition_compute_stop_pos): Ignore a static
8357 composition starting before CHARPOS (Bug#8915).
8359 * xdisp.c (handle_composition_prop): Likewise.
8361 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8363 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8366 2011-07-07 Kenichi Handa <handa@m17n.org>
8368 * character.h (unicode_category_t): New enum type.
8370 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8371 (Qchar_code_property_table): New variable.
8372 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8373 (UNIPROP_COMPRESSED_FORM_P): New macros.
8374 (char_table_ascii): Uncompress the compressed values.
8375 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8376 Uncompress the compressed values.
8377 (sub_char_table_ref_and_range): Likewise.
8378 (char_table_ref_and_range): Uncompress the compressed values.
8379 (sub_char_table_set): New arg is_uniprop. Callers changed.
8380 Uncompress the compressed values.
8381 (sub_char_table_set_range): Args changed. Callers changed.
8382 (char_table_set_range): Adjuted for the above change.
8383 (map_sub_char_table): Delete args default_val and parent. Add arg
8384 top. Give decoded values to a Lisp function.
8385 (map_char_table): Adjust for the above change. Give decoded
8386 values to a Lisp function. Gcpro more variables.
8387 (uniprop_table_uncompress)
8388 (uniprop_decode_value_run_length): New functions.
8389 (uniprop_decoder, uniprop_decoder_count): New variables.
8390 (uniprop_get_decoder, uniprop_encode_value_character)
8391 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8393 (uniprop_encoder, uniprop_encoder_count): New variables.
8394 (uniprop_get_encoder, uniprop_table)
8395 (Funicode_property_table_internal, Fget_unicode_property_internal)
8396 (Fput_unicode_property_internal): New functions.
8397 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8398 Sunicode_property_table_internal, Sget_unicode_property_internal,
8399 and Sput_unicode_property_internal. Defvar_lisp
8400 char-code-property-alist.
8402 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8403 Vunicode_category_table.
8405 * font.c (font_range): Adjust for the change of
8406 Vunicode_category_table.
8408 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8410 * m/iris4d.h: Remove file, move contents ...
8411 * s/irix6-5.h: ... here.
8413 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8415 Remove unportable assumption about struct layout (Bug#8884).
8416 * alloc.c (mark_buffer):
8417 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8418 (clone_per_buffer_values): Don't assume that
8419 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8420 This isn't true in general, and it's particularly not true
8421 if Emacs is configured with --with-wide-int.
8422 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8423 New macros, used in the buffer.c change.
8425 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8427 * xsettings.c: Use both GConf and GSettings if both are available.
8428 (store_config_changed_event): Add comment.
8429 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8430 (store_tool_bar_style_changed): New functions.
8431 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8432 (struct xsettings): Move font inside HAVE_XFT.
8433 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8434 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8435 Move inside HAVE_XFT.
8436 (something_changed_gsettingsCB): Rename from something_changedCB.
8437 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8439 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8440 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8441 (something_changed_gconfCB): Rename from something_changedCB.
8442 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8443 (parse_settings): Move check for font inside HAVE_XFT.
8444 (read_settings, apply_xft_settings): Add comment.
8445 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8446 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8447 call store_font_name_changed.
8448 (xft_settings_event): Add comment.
8449 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8450 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8451 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8452 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8453 (xsettings_initialize): Call init_gsettings last.
8454 (xsettings_get_system_font, xsettings_get_system_normal_font):
8457 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8459 Random fixes. E.g., (random) never returned negative values.
8460 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8461 subseconds part to the entropy, as that's a bit more random.
8462 Prefer signed to unsigned, since the signedness doesn't matter and
8463 in general we prefer signed. When given a limit, use a
8464 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8465 latter isn't right if USE_2_TAGS_FOR_INTS.
8466 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8467 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8469 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8471 * textprop.c (text_property_stickiness):
8472 Obey Vtext_property_default_nonsticky.
8473 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8474 * w32fns.c (syms_of_w32fns):
8475 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8477 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8479 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8480 This is more efficient than Ffile_directory_p and avoids a minor race.
8482 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8484 * buffer.c (Foverlay_put): Say what the return value is
8487 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8488 is a directory before asking whether to use the file name
8490 (barf_or_query_if_file_exists): Make the "File is a directory"
8491 error be more correct.
8493 * fns.c (Frequire): Remove the mention of the .gz files, since
8494 that's installation-specific, but keep the mention of
8495 `get-load-suffixes'.
8497 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8499 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8500 Report string overflow if the output is too long.
8502 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8504 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8505 (syms_of_gnutls): Remove duplicate DEFSYM for
8506 Qgnutls_bootprop_verify_hostname_error, an error for
8507 Qgnutls_bootprop_verify_error (which is no longer used).
8509 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8510 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8511 Also (re)move comments that are misplaced or no longer relevant.
8513 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8515 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8517 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8519 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8520 and background color parameters if they have been changed.
8522 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8524 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8526 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8528 * xsettings.c (SYSTEM_FONT): Define only when used.
8529 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8531 * keymap.c (access_keymap_1): Now static.
8533 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8535 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8536 leave any prefix arg for the up event (Bug#1586).
8538 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8540 * lread.c (syms_of_lread): Mention single symbols defined by
8541 `defvar' or `defconst' (bug#7154).
8543 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8544 (Frequire): Mention get-load-suffixes.
8546 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8548 * window.h (window): Remove clone_number slot.
8549 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8551 (make_parent_window, make_window, saved_window)
8552 (Fset_window_configuration, save_window_save): Don't deal with
8554 * buffer.c (Qclone_number): Remove declaration.
8555 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8557 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8559 Add multiple inheritance to keymaps.
8560 * keymap.c (Fmake_composed_keymap): New function.
8561 (Fset_keymap_parent): Simplify.
8562 (fix_submap_inheritance): Remove.
8563 (access_keymap_1): New function extracted from access_keymap to handle
8564 embedded parents and handle lists of maps.
8565 (access_keymap): Use it.
8566 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8567 (Fcopy_keymap): Handle embedded parents.
8568 (Fcommand_remapping, define_as_prefix): Simplify.
8569 (Fkey_binding): Simplify.
8570 (syms_of_keymap): Move minibuffer-local-completion-map,
8571 minibuffer-local-filename-completion-map,
8572 minibuffer-local-must-match-map, and
8573 minibuffer-local-filename-must-match-map to Elisp.
8574 (syms_of_keymap): Defsubr make-composed-keymap.
8575 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8576 (parse_menu_item): Trivial simplification.
8578 2011-07-01 Glenn Morris <rgm@gnu.org>
8580 * Makefile.in (SETTINGS_LIBS): Fix typo.
8582 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8584 * coding.c (Fencode_coding_string): Record the last coding system
8585 used, as the function doc string says (bug#8738).
8587 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8589 * xsettings.c (store_monospaced_changed): Take new font as arg and
8590 check for change against current_mono_font.
8591 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8592 (emacs_settings_constructor, emacs_settings_get_property)
8593 (emacs_settings_set_property, emacs_settings_class_init)
8594 (emacs_settings_init, gsettings_obj): Remove.
8595 (something_changedCB): New function for HAVE_GSETTINGS.
8596 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8597 with value as argument.
8598 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8599 g_settings_new (Bug#8967). Do not create gsettings_obj.
8600 Remove calls to g_settings_bind. Connect something_changedCB to
8603 * xgselect.c: Add defined (HAVE_GSETTINGS).
8604 (xgselect_initialize): Ditto.
8606 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8607 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8610 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8612 * eval.c (struct backtrace): Simplify and port the data structure.
8613 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8614 signed bit field, as this assumption is not portable and it makes
8615 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8616 "char debug_on_exit : 1" as this is not portable either; instead,
8617 use the portable "unsigned int debug_on_exit : 1". Remove unused
8618 member evalargs. Remove obsolete comments about cc bombing out.
8620 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8622 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8623 Let HAVE_GSETTINGS override HAVE_GCONF.
8624 (store_monospaced_changed): New function.
8625 (EMACS_SETTINGS): A new type derived from GObject to handle
8626 GSettings notifications.
8627 (emacs_settings_constructor, emacs_settings_get_property)
8628 (emacs_settings_set_property, emacs_settings_class_init):
8630 (gsettings_client, gsettings_obj): New variables.
8631 (GSETTINGS_SCHEMA): New define.
8632 (something_changedCB): Call store_monospaced_changed.
8633 (init_gsettings): New function.
8634 (xsettings_initialize): Call init_gsettings.
8635 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8638 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8641 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8643 * window.c (resize_root_window, grow_mini_window)
8644 (shrink_mini_window): Rename Qresize_root_window to
8645 Qwindow_resize_root_window and Qresize_root_window_vertically to
8646 Qwindow_resize_root_window_vertically.
8648 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8650 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8652 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8654 * makefile.w32-in: Redesign dependencies so they reflect more
8655 clearly which files are directly included by each source file,
8656 and not through other includes.
8658 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8660 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8661 (sort_overlays, overlay_strings): When an overlay's clone number
8662 matches the window's clone number process the overlay even if
8663 the overlay's window property doesn't match the current window.
8665 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8666 (Fwindow_hchild): Rename to Fwindow_left_child.
8667 (Fwindow_next): Rename to Fwindow_next_sibling.
8668 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8669 (resize_window_check): Rename to window_resize_check.
8670 (resize_window_apply): Rename to window_resize_apply.
8671 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8672 (Fdelete_other_windows_internal, resize_frame_windows)
8673 (Fsplit_window_internal, Fdelete_window_internal)
8674 (grow_mini_window, shrink_mini_window)
8675 (Fresize_mini_window_internal): Fix callers accordingly.
8677 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8679 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8680 (emacs_fixed_set_min_size): Remove.
8681 (emacs_fixed_new): Take frame as argument.
8683 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8684 (_EmacsFixedPrivate): Remove minwidth/height.
8685 Add struct frame *f.
8686 (emacs_fixed_init): Initialize priv->f.
8687 (get_parent_class, emacs_fixed_set_min_size): Remove.
8688 (emacs_fixed_new): Set priv->f to argument.
8689 (emacs_fixed_get_preferred_width)
8690 (emacs_fixed_get_preferred_height): Use min_width/height from
8691 frames size_hint to set minimum and natural (Bug#8919).
8692 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8693 and use min_width/height from frames size_hint to set
8694 min_width/height (Bug#8919).
8696 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8697 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8700 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8702 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8703 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8706 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8708 * process.c (wait_reading_process_output): Bypass select if
8709 waiting for a cell while ignoring keyboard input, and input is
8710 pending. Suggested by Jan Djärv (Bug#8869).
8712 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8714 Use gnulib's dup2 module instead of rolling our own.
8715 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8717 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8719 * dispnew.c (scrolling_window): Before scrolling, turn off a
8720 mouse-highlight in the window being scrolled.
8722 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8724 Move DEFSYM to lisp.h and use everywhere.
8726 * character.h (DEFSYM): Move declaration...
8727 * lisp.h (DEFSYM): ...here.
8733 * w32select.c: Don't include character.h.
8735 * alloc.c (syms_of_alloc):
8736 * buffer.c (syms_of_buffer):
8737 * bytecode.c (syms_of_bytecode):
8738 * callint.c (syms_of_callint):
8739 * casefiddle.c (syms_of_casefiddle):
8740 * casetab.c (init_casetab_once):
8741 * category.c (init_category_once, syms_of_category):
8742 * ccl.c (syms_of_ccl):
8743 * cmds.c (syms_of_cmds):
8744 * composite.c (syms_of_composite):
8745 * dbusbind.c (syms_of_dbusbind):
8746 * dired.c (syms_of_dired):
8747 * dispnew.c (syms_of_display):
8748 * doc.c (syms_of_doc):
8749 * editfns.c (syms_of_editfns):
8750 * emacs.c (syms_of_emacs):
8751 * eval.c (syms_of_eval):
8752 * fileio.c (syms_of_fileio):
8753 * fns.c (syms_of_fns):
8754 * frame.c (syms_of_frame):
8755 * fringe.c (syms_of_fringe):
8756 * insdel.c (syms_of_insdel):
8757 * keymap.c (syms_of_keymap):
8758 * lread.c (init_obarray, syms_of_lread):
8759 * macros.c (syms_of_macros):
8760 * msdos.c (syms_of_msdos):
8761 * print.c (syms_of_print):
8762 * process.c (syms_of_process):
8763 * search.c (syms_of_search):
8764 * sound.c (syms_of_sound):
8765 * syntax.c (init_syntax_once, syms_of_syntax):
8766 * terminal.c (syms_of_terminal):
8767 * textprop.c (syms_of_textprop):
8768 * undo.c (syms_of_undo):
8769 * w32.c (globals_of_w32):
8770 * window.c (syms_of_window):
8771 * xdisp.c (syms_of_xdisp):
8772 * xfaces.c (syms_of_xfaces):
8773 * xfns.c (syms_of_xfns):
8774 * xmenu.c (syms_of_xmenu):
8775 * xsettings.c (syms_of_xsettings):
8776 * xterm.c (syms_of_xterm): Use DEFSYM.
8778 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8780 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8782 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8784 Integer and buffer overflow fixes (Bug#8873).
8786 * print.c (printchar, strout): Check for string overflow.
8787 (PRINTPREPARE, printchar, strout):
8788 Don't set size unless allocation succeeds.
8790 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8791 for sizes. Check for string overflow more accurately.
8792 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8794 * macros.c: Integer and buffer overflow fixes.
8795 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8796 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8797 Use ptrdiff_t, not int, for sizes.
8798 Don't increment bufsize until after realloc succeeds.
8799 Check for size-calculation overflow.
8800 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8802 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8804 * lread.c: Integer overflow fixes.
8805 (read_integer): Radix is now EMACS_INT, not int,
8806 to improve quality of diagnostics for out-of-range radices.
8807 Calculate buffer size correctly for out-of-range radices.
8808 (read1): Check for integer overflow in radices, and in
8809 read-circle numbers.
8810 (read_escape): Avoid int overflow.
8811 (Fload, openp, read_buffer_size, read1)
8812 (substitute_object_recurse, read_vector, read_list, map_obarray):
8813 Use ptrdiff_t, not int, for sizes.
8814 (read1): Use EMACS_INT, not int, for sizes.
8815 Check for size overflow.
8817 * image.c (cache_image): Check for size arithmetic overflow.
8819 * lread.c: Integer overflow issues.
8820 (saved_doc_string_size, saved_doc_string_length)
8821 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8822 Now ptrdiff_t, not int.
8823 (read1): Don't assume doc string length fits in int. Check for
8824 out-of-range doc string lengths.
8825 (read_list): Don't assume file position fits in int.
8826 (read_escape): Check for hex character overflow.
8828 2011-06-22 Leo Liu <sdl.web@gmail.com>
8830 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8831 Move to minibuffer.el.
8833 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8835 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8836 The following patches are for when GLYPH_DEBUG && !XASSERT.
8837 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8838 * dispnew.c (flush_stdout):
8839 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8840 Mark as externally visible.
8841 * dispnew.c (check_window_matrix_pointers): Now static.
8842 * dispnew.c (window_to_frame_vpos):
8843 * xfns.c (unwind_create_frame):
8844 * xterm.c (x_check_font): Remove unused local.
8845 * scroll.c (CHECK_BOUNDS):
8846 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8847 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8848 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8849 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8850 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8852 (debug_method_add): Use va_list and vsprintf rather than relying
8853 on undefined behavior with wrong number of arguments.
8854 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8855 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8856 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8857 since we're not interested in debugging glyphs with old libraries.
8858 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8859 GCC 4.6.0's static checking.
8861 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8863 Integer overflow and signedness fixes (Bug#8873).
8864 A few related buffer overrun fixes, too.
8866 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8868 * dispextern.h (struct face.stipple):
8869 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8870 (x_bitmap_mask, x_allocate_bitmap_record)
8871 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8872 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8873 (x_create_bitmap_from_xpm_data):
8874 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8875 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8877 * xfaces.c (load_pixmap):
8878 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8879 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8880 (.bitmaps_last, struct x_output.icon_bitmap):
8881 Use ptrdiff_t, not int, for bitmap indexes.
8882 (x_allocate_bitmap_record): Check for size overflow.
8883 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8885 Use ptrdiff_t, not int, for overlay counts.
8886 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8887 * editfns.c (overlays_around, get_pos_property):
8888 * textprop.c (get_char_property_and_overlay):
8889 * xdisp.c (next_overlay_change, note_mouse_highlight):
8890 * xfaces.c (face_at_buffer_position):
8891 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8892 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8893 (Fnext_overlay_change, Fprevious_overlay_change)
8894 (mouse_face_overlay_overlaps, Foverlays_in):
8895 Use ptrdiff_t, not int, for sizes.
8896 (overlays_at, overlays_in): Check for size-calculation overflow.
8898 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8900 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8901 (x_session_initialize): Do not assume string length fits in int.
8903 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8904 This is unlikely, but can occur if DPI is outlandish.
8906 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8907 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8909 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8910 * xrdb.c (magic_file_p, search_magic_path):
8911 Omit last arg SUFFIX; it was always 0. All callers changed.
8912 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8914 * xfont.c (xfont_match): Avoid need for strlen.
8916 * xfns.c: Don't assume strlen fits in int.
8917 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8919 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8920 not unsigned long, as we prefer signed integers. All callers changed.
8921 Detect integer overflow in repeat count.
8922 (message_dolog): Don't assume print length fits in 39 bytes.
8923 (display_mode_element): Don't assume strlen fits in int.
8925 * termcap.c: Don't assume sizes fit in int and never overflow.
8926 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8927 (gobble_line): Check for size-calculation overflow.
8929 * minibuf.c (Fread_buffer):
8930 * lread.c (intern, intern_c_string):
8931 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8932 Don't assume string length fits in int.
8934 * keyboard.c (parse_tool_bar_item):
8935 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8937 * font.c: Don't assume string length fits in int.
8938 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8939 Use ptrdiff_t, not int.
8940 (font_intern_prop): Don't assume string length fits in int.
8941 Don't assume integer property fits in fixnum.
8942 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8944 * filelock.c: Fix some buffer overrun and integer overflow issues.
8945 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8946 Reformulate so as not to need the command string.
8947 Invoke gzip -cd rather than gunzip, as it's more portable.
8948 (lock_info_type, lock_file_1, lock_file):
8949 Don't assume pid_t and time_t fit in unsigned long.
8950 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8951 (current_lock_owner): Prefer signed type for sizes.
8952 Use memcpy, not strncpy, where memcpy is what is really wanted.
8953 Don't assume (via atoi) that time_t and pid_t fit in int.
8954 Check for time_t and/or pid_t out of range, e.g., via a network share.
8955 Don't alloca where an auto var works fine.
8957 * fileio.c: Fix some integer overflow issues.
8958 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8959 Don't assume string length fits in int.
8960 (directory_file_name): Don't assume string length fits in long.
8961 (make_temp_name): Don't assume pid fits in int, or that its print
8962 length is less than 20.
8964 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8966 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8968 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8970 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8971 We prefer signed integers, even for size calculations.
8973 * emacs.c: Don't assume string length fits in 'int'.
8974 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8975 (main): Don't invoke strlen when not needed.
8977 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8978 (XD_DEBUG_MESSAGE): Don't waste a byte.
8980 * callproc.c (getenv_internal_1, getenv_internal)
8982 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8984 * lread.c (invalid_syntax): Omit length argument.
8985 All uses changed. This doesn't fix a bug, but it simplifies the
8986 code away from its former Hollerith-constant appearance, and it's
8987 one less 'int' to worry about when looking at integer-overflow issues.
8988 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8990 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8991 This didn't break anything, but it didn't help either.
8992 It's confusing to put a bogus integer in a place where the actual
8993 value does not matter.
8994 (LIST_END_P): Remove unused macro and its bogus comment.
8995 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8997 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8998 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9000 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9001 We prefer signed types, and the value cannot exceed the EMACS_INT
9002 range anyway (because otherwise the length would not be representable).
9003 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9004 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9005 This avoids a GCC warning when WIDE_EMACS_INT.
9007 * indent.c (sane_tab_width): New function.
9008 (current_column, scan_for_column, Findent_to, position_indentation)
9009 (compute_motion): Use it. This is just for clarity.
9010 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9012 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9014 * lisp.h (lint_assume): New macro.
9015 * composite.c (composition_gstring_put_cache):
9016 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9018 * editfns.c, insdel.c:
9019 Omit unnecessary forward decls, to simplify future changes.
9021 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9023 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9025 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9026 Use much-faster test for byte-length change.
9027 Don't assume string byte-length fits in 'int'.
9028 Check that character arg fits in 'int'.
9029 (mapcar1): Declare byte as byte, for clarity.
9031 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9033 * fns.c (concat): Catch string overflow earlier.
9034 Do not rely on integer wraparound.
9036 * dispextern.h (struct it.overlay_strings_charpos)
9037 (struct it.selective): Now EMACS_INT, not int.
9038 * xdisp.c (forward_to_next_line_start)
9039 (back_to_previous_visible_line_start)
9040 (reseat_at_next_visible_line_start, next_element_from_buffer):
9041 Don't arbitrarily truncate the value of 'selective' to int.
9043 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9045 * composite.c: Don't truncate sizes to 'int'.
9046 (composition_gstring_p, composition_reseat_it)
9047 (composition_adjust_point): Use EMACS_INT, not int.
9048 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9049 not EMACS_UINT, for indexes.
9051 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9053 * buffer.c: Include <verify.h>.
9054 (struct sortvec.priority, struct sortstr.priority):
9055 Now EMACS_INT, not int.
9056 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9057 (struct sortstr.size, record_overlay_string)
9058 (struct sortstrlist.size, struct sortlist.used):
9059 Don't truncate size to int.
9060 (record_overlay_string): Check for size-calculation overflow.
9061 (init_buffer_once): Check at compile-time, not run-time.
9063 2011-06-22 Jim Meyering <meyering@redhat.com>
9065 Don't leak an XBM-image-sized buffer
9066 * image.c (xbm_load): Free the image buffer after using it.
9068 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9071 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9072 that Sun C diagnosed.
9073 * fns.c (secure_hash): Fix pointer signedness issue.
9074 * intervals.c (static_offset_intervals): New function.
9075 (offset_intervals): Use it.
9077 2011-06-21 Leo Liu <sdl.web@gmail.com>
9080 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9083 * fns.c (secure_hash): Rename from crypto_hash_function and change
9084 the first arg to accept symbols.
9085 (Fsecure_hash): New primitive.
9086 (syms_of_fns): New symbols.
9088 2011-06-20 Deniz Dogan <deniz@dogan.se>
9090 * process.c (Fset_process_buffer): Clarify return value in
9093 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9095 * dispnew.c (add_window_display_history): Use BVAR.
9097 * xdisp.c (debug_method_add): Use BVAR.
9098 (check_window_end, dump_glyph_matrix, dump_glyph)
9099 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9101 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9104 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9105 check till after the cache is created in init_frame_faces.
9107 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9109 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9111 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9113 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9114 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9115 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9117 Improve buffer-overflow checking (Bug#8873).
9118 * fileio.c (Finsert_file_contents):
9119 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9120 Remove the old (too-loose) buffer overflow checks.
9121 They weren't needed, since make_gap checks for buffer overflow.
9122 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9123 The old code merely checked for Emacs fixnum overflow, and relied
9124 on undefined (wraparound) behavior. The new code avoids undefined
9125 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9127 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9128 Tune. Don't use wider integers than needed. Don't use alloca.
9129 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9131 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9133 * insdel.c, lisp.h (buffer_overflow): New function.
9134 (insert_from_buffer_1, replace_range, replace_range_2):
9135 * insdel.c (make_gap_larger):
9136 * editfns.c (Finsert_char):
9137 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9139 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9141 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9143 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9145 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9146 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9148 * fileio.c: Don't assume EMACS_INT fits in off_t.
9149 (emacs_lseek): New static function.
9150 (Finsert_file_contents, Fwrite_region): Use it.
9151 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9153 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9155 * fns.c: Don't overflow int when computing a list length.
9156 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9157 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9158 truncation on 64-bit hosts. Check for QUIT every
9159 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9160 faster and is responsive enough.
9161 (Flength): Report an error instead of overflowing an integer.
9162 (Fsafe_length): Return a float if the value is not representable
9163 as a fixnum. This shouldn't happen except in contrived situations.
9164 (Fnthcdr, Fsort): Don't assume list length fits in int.
9165 (Fcopy_sequence): Don't assume vector length fits in int.
9167 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9168 (header_size, word_size): New constants.
9169 (allocate_vectorlike): Don't check size overflow here.
9170 (allocate_vector): Check it here instead, since this is the only
9171 caller of allocate_vectorlike that could cause overflow.
9172 Check that the new vector's length is representable as a fixnum.
9174 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9175 The previous code was bogus. For example, next_almost_prime (32)
9176 returned 39, which is undesirable as it is a multiple of 3; and
9177 next_almost_prime (24) returned 25, which is a multiple of 5 so
9178 why was the code bothering to check for multiples of 7?
9180 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9182 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9184 Variadic C functions now count arguments with ptrdiff_t.
9185 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9186 Back then I didn't know that the Emacs coding style prefers signed int.
9187 Also, in the meantime I found a few more instances where arguments
9188 were being counted with int, which may truncate counts on 64-bit
9189 machines, or EMACS_INT, which may be unnecessarily wide.
9190 * lisp.h (struct Lisp_Subr.function.aMANY)
9191 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9192 Arg counts are now ptrdiff_t, not size_t.
9193 All variadic functions and their callers changed accordingly.
9194 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9195 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9196 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9197 * callint.c (Fcall_interactively): Check arg count for overflow,
9198 to avoid potential buffer overrun. Use signed char, not 'int',
9199 for 'varies' array, so that we needn't bother to check its size
9200 calculation for overflow.
9201 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9202 * eval.c (apply_lambda):
9203 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9204 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9205 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9207 * callint.c (Fcall_interactively): Don't use index var as event count.
9209 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9210 * mem-limits.h (SIZE): Remove; no longer used.
9212 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9214 Remove unnecessary casts.
9215 * xterm.c (x_term_init):
9216 * xfns.c (x_set_border_pixel):
9217 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9218 These aren't needed now that we assume ANSI C.
9220 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9221 It's more likely to cause problems (due to unsigned overflow)
9224 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9226 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9228 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9230 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9232 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9234 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9236 GLYPH_CODE_FACE returns EMACS_INT, not int.
9237 * dispextern.h (merge_faces):
9238 * xfaces.c (merge_faces):
9239 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9240 Don't assume EMACS_INT fits in int.
9242 * character.h (CHAR_VALID_P): Remove unused parameter.
9243 * fontset.c, lisp.h, xdisp.c: All uses changed.
9245 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9247 * fns.c (concat): Minor tuning based on overflow analysis.
9248 This doesn't fix any bugs. Use int to hold character, instead
9249 of constantly refetching from Emacs object. Use XFASTINT, not
9250 XINT, for value known to be a character. Don't bother comparing
9251 a single byte to 0400, as it's always less.
9253 * floatfns.c (Fexpt):
9254 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9256 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9259 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9261 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9262 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9263 incorrectly succeed when S was a string, because 4294967386 was
9264 truncated before it was used.
9266 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9267 Otherwise, an out-of-range integer could cause undefined behavior
9270 * composite.c: Use int, not EMACS_INT, for characters.
9271 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9272 EMACS_INT, for values that are known to be in character range.
9273 This doesn't fix any bugs but is the usual style inside Emacs and
9274 may generate better code on 32-bit machines.
9276 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9277 This is for reasons similar to the recent CHAR_STRING fix.
9278 * charset.c (Fencode_char): Check that character arg is actually
9279 a character. Pass an int to ENCODE_CHAR.
9280 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9281 wider than 'int', as a compile-time check to prevent future regressions
9284 * character.c (char_string): Remove unnecessary casts.
9286 Make sure a 64-bit char is never passed to CHAR_STRING.
9287 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9288 by silently ignoring the top 32 bits, allowing some values
9289 that were far too large to be valid characters.
9290 * character.h: Include <verify.h>.
9291 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9292 arguments are no wider than unsigned, as a compile-time check
9293 to prevent future regressions in this area.
9295 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9296 (Fsubst_char_in_region):
9298 * xdisp.c (decode_mode_spec_coding):
9299 Adjust to CHAR_STRING's new requirement.
9300 * editfns.c (Finsert_char, Fsubst_char_in_region):
9301 * fns.c (concat): Check that character args are actually
9302 characters. Without this test, these functions did the wrong
9303 thing with wildly out-of-range values on 64-bit hosts.
9305 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9306 These casts should not be needed on 32-bit hosts, either.
9307 * keyboard.c (read_char):
9308 * lread.c (Fload): Remove casts to unsigned.
9310 * lisp.h (UNSIGNED_CMP): New macro.
9311 This fixes comparison bugs on 64-bit hosts.
9312 (ASCII_CHAR_P): Use it.
9313 * casefiddle.c (casify_object):
9314 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9315 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9316 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9317 * dispextern.h (FACE_FROM_ID):
9318 * keyboard.c (read_char): Use UNSIGNED_CMP.
9320 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9321 not to EMACS_INT, to avoid GCC warning.
9323 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9325 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9326 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9327 isn't needed on 32-bit machines.
9329 * buffer.c (Fgenerate_new_buffer_name):
9330 Use EMACS_INT for count, not int.
9331 (advance_to_char_boundary): Return EMACS_INT, not int.
9333 * data.c (Qcompiled_function): Now static.
9335 * window.c (window_body_lines): Now static.
9337 * image.c (gif_load): Rename local to avoid shadowing.
9339 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9340 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9341 * alloc.c (make_save_value): Integer argument is now of type
9343 (mark_object): Use ptrdiff_t, not int.
9344 * lisp.h (pD): New macro.
9345 * print.c (print_object): Use it.
9347 * alloc.c: Use EMACS_INT, not int, to count objects.
9348 (total_conses, total_markers, total_symbols, total_vector_size)
9349 (total_free_conses, total_free_markers, total_free_symbols)
9350 (total_free_floats, total_floats, total_free_intervals)
9351 (total_intervals, total_strings, total_free_strings):
9352 Now EMACS_INT, not int. All uses changed.
9353 (Fgarbage_collect): Compute overall total using a double, so that
9354 integer overflow is less likely to be a problem. Check for overflow
9355 when converting back to an integer.
9356 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9357 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9358 These were 'int' variables that could overflow on 64-bit hosts;
9359 they were never used, so remove them instead of repairing them.
9360 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9361 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9362 Previously, this ceilinged at INT_MAX, but that doesn't work on
9364 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9366 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9367 (allocate_vectorlike): Check for ptrdiff_t overflow.
9368 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9369 when a (possibly-narrower) signed value would do just as well.
9370 We prefer using signed arithmetic, to avoid comparison confusion.
9372 * alloc.c: Catch some string size overflows that we were missing.
9373 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9374 for convenience in STRING_BYTES_MAX.
9375 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9376 The definition here is exact; the one in lisp.h was approximate.
9377 (allocate_string_data): Check for string overflow. This catches
9378 some instances we weren't catching before. Also, it catches
9379 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9380 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9381 and ptrdiff_t and EMACS_INT are both 64 bits.
9383 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9384 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9385 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9387 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9389 * alloc.c (Fmake_string): Check for out-of-range init.
9391 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9393 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9395 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9397 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9398 xg_get_default_scrollbar_width.
9400 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9401 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9402 (style_changed_cb): Call update_theme_scrollbar_width and call
9403 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9404 all frames (Bug#8505).
9405 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9406 Call gtk_window_set_resizable if HAVE_GTK3.
9407 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9408 and height if HAVE_GTK3 (Bug#8505).
9409 (scroll_bar_width_for_theme): New variable.
9410 (update_theme_scrollbar_width): New function.
9411 (xg_get_default_scrollbar_width): Move code to
9412 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9413 (xg_initialize): Call update_theme_scrollbar_width.
9415 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9417 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9419 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9421 * frame.c (make_frame): Call other_buffer_safely instead of
9424 * window.c (temp_output_buffer_show): Call display_buffer with
9425 second argument Vtemp_buffer_show_specifiers and reset latter
9426 immediately after the call.
9427 (Vtemp_buffer_show_specifiers): New variable.
9428 (auto_window_vscroll_p, next_screen_context_lines)
9429 (Vscroll_preserve_screen_position): Remove leading asterisks from
9432 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9434 Fix minor problems found by GCC 4.6.0 static checking.
9435 * buffer.c (Qclone_number): Remove for now, as it's unused.
9436 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9437 (record_buffer): Remove unused local.
9438 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9439 (set_frame_buffer_list): Remove; unused.
9440 * frame.h (other_visible_frames): Remove decl.
9441 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9442 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9443 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9445 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9446 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9447 Define only if HAVE_GPM.
9448 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9449 (update_hints_inhibit): Remove; never set. All uses removed.
9450 * widgetprv.h (emacsFrameClassRec): Remove decl.
9451 * window.c (delete_deletable_window): Now returns void, since it
9452 wasn't returning anything.
9453 (compare_window_configurations): Remove unused locals.
9454 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9455 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9456 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9457 the same widths as pointers. This follows up on the 2011-05-06 patch.
9458 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9459 * xterm.h: Likewise.
9460 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9462 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9464 * makefile.w32-in: Update dependencies.
9465 (LISP_H): Add lib/intprops.h.
9467 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9469 * image.c (gif_load): Add animation frame delay to the metadata.
9470 (syms_of_image): Use DEFSYM. New symbol `delay'.
9472 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9474 * window.c (delete_deletable_window): Re-add.
9475 (Fset_window_configuration): Rewrite to handle dead buffers and
9476 consequently deletable windows.
9477 (window_tree, Fwindow_tree): Remove. Supply functionality in
9479 (compare_window_configurations): Simplify code.
9481 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9483 * image.c (imagemagick_load_image): Fix type mismatch.
9484 (Fimagemagick_types): Likewise.
9486 * window.h (replace_buffer_in_windows): Declare.
9488 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9490 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9491 Qclone_number. Remove external declaration of Qdelete_window.
9492 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9494 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9495 Run Qbuffer_list_update_hook if allowed.
9496 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9497 buffer list implementation.
9498 (other_buffer_safely): New function.
9499 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9500 calls to replace_buffer_in_windows and
9501 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9503 (record_buffer): Inhibit quitting and rewrite using quittable
9504 functions. Run Qbuffer_list_update_hook if allowed.
9505 (Frecord_buffer, Funrecord_buffer): New functions.
9506 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9507 Move switch-to-buffer to window.el.
9508 (bury-buffer): Move to window.el.
9509 (Vbuffer_list_update_hook): New variable.
9511 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9514 * window.h (resize_frame_windows): Move up in code.
9515 (Fwindow_frame): Remove EXFUN.
9516 (replace_buffer_in_all_windows): Remove prototype.
9517 (replace_buffer_in_windows_safely): Add prototype.
9519 * window.c: Declare Qdelete_window static again. Move down
9520 declaration of select_count.
9521 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9522 (Fother_window): Move to window.el.
9523 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9524 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9525 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9527 (replace_buffer_in_windows): Implement by calling
9528 Qreplace_buffer_in_windows.
9529 (replace_buffer_in_all_windows): Remove with some functionality
9530 moved into replace_buffer_in_windows_safely.
9531 (replace_buffer_in_windows_safely): New function.
9532 (select_window_norecord, select_frame_norecord): Move in front
9533 of run_window_configuration_change_hook. Remove now obsolete
9535 (Fset_window_buffer): Rewrite doc-string.
9536 Call Qrecord_window_buffer.
9537 (keys_of_window): Move binding for other-window to window.el.
9539 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9541 * dispextern.h (struct image): Replace data member, whose int_val
9542 and ptr_val fields were not used by anything, with a single
9545 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9546 (gif_clear_image, gif_load, imagemagick_load_image)
9547 (gs_clear_image, gs_load): Callers changed.
9549 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9551 * buffer.h: Include <time.h>, for time_t.
9552 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9554 Fix minor problems found by static checking.
9556 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9558 Make identifiers static if they are not used in other modules.
9559 * data.c (Qcompiled_function, Qframe, Qvector):
9560 * image.c (QimageMagick, Qsvg):
9561 * minibuf.c (Qmetadata):
9562 * window.c (resize_window_check, resize_root_window): Now static.
9563 * window.h (resize_window_check, resize_root_window): Remove decls.
9565 * window.c (window_deletion_count, delete_deletable_window):
9567 (window_body_lines): Now static.
9568 (Fdelete_other_windows_internal): Mark vars as initialized.
9569 Make sure 'resize_failed' is initialized.
9570 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9571 (resize_window_apply): Remove unused local.
9572 * window.h (delete_deletable_window): Remove decl.
9574 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9575 (imagemagick_load_image): Fix pointer signedness problem by changing
9576 last arg from unsigned char * to char *. All uses changed.
9577 Also, fix a local for similar reasons.
9578 Remove unused locals. Remove locals to avoid shadowing.
9579 (fn_rsvg_handle_free): Remove; unused.
9580 (svg_load, svg_load_image): Fix pointer signedness problem.
9581 (imagemagick_load_image): Don't use garbage pointer image_wand.
9583 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9585 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9587 * image.c (gif_load): Fix omitted cast error introduced by
9590 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9592 * window.h (resize_proportionally, orig_total_lines)
9593 (orig_top_line): Remove from window structure.
9594 (set_window_height, set_window_width, change_window_heights)
9595 (Fdelete_window): Remove prototypes.
9596 (resize_frame_windows): Remove duplicate declaration.
9598 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9600 * window.h (resize_frame_windows, resize_window_check)
9601 (delete_deletable_window, resize_root_window)
9602 (resize_frame_windows): Declare prototypes.
9604 * window.c (resize_window_apply): Make definition be "static" to
9605 match the prototype.
9607 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9609 * window.c: Remove declarations of Qwindow_size_fixed,
9610 window_min_size_1, window_min_size_2, window_min_size,
9611 size_window, window_fixed_size_p, enlarge_window, delete_window.
9612 Remove static from declaration of Qdelete_window, it's
9613 temporarily needed by Fbury_buffer.
9614 (replace_window): Don't assign orig_top_line and
9616 (Fdelete_window, delete_window): Remove. Window deletion is
9617 handled by window.el.
9618 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9619 Replace Fdelete_window calls with calls to Qdelete_window.
9620 (Fdelete_other_windows): Remove. Deleting other windows is
9621 handled by window.el.
9622 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9623 handled in window.el.
9624 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9625 Window minimum sizes are handled in window.el.
9626 (shrink_windows, size_window, set_window_height)
9627 (set_window_width, change_window_heights, window_height)
9628 (window_width, CURBEG, CURSIZE, enlarge_window)
9629 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9630 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9631 handled in window.el.
9632 (make_dummy_parent): Rename to make_parent_window and give it a
9633 second argument horflag.
9634 (make_window): Don't set resize_proportionally any more.
9635 (Fsplit_window): Remove. Windows are split in window.el.
9636 (save_restore_action, save_restore_orig_size)
9637 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9638 Resize mini windows in window.el.
9639 (grow_mini_window, shrink_mini_window): Implement by calling
9640 Qresize_root_window_vertically, resize_window_check and
9641 resize_window_apply.
9642 (saved_window, Fset_window_configuration, save_window_save):
9643 Do not handle orig_top_line, orig_total_lines, and
9644 resize_proportionally.
9645 (window_min_height, window_min_width): Move to window.el.
9646 (keys_of_window): Move bindings for delete-other-windows,
9647 split-window, delete-window and enlarge-window to window.el.
9649 * buffer.c: Temporarily extern Qdelete_window.
9650 (Fbury_buffer): Temporarily call Qdelete_window instead of
9651 Fdelete_window (Fbury_buffer will move to window.el soon).
9653 * frame.c (set_menu_bar_lines_1): Remove code handling
9654 orig_top_line and orig_total_lines.
9656 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9657 set_window_height but set heights directly.
9658 (change_frame_size_1): Use resize_frame_windows.
9660 * xdisp.c (init_xdisp): Don't use set_window_height but set
9663 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9664 Use resize_frame_windows instead of change_window_heights and run
9665 run_window_configuration_change_hook.
9667 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9668 instead of change_window_heights and run
9669 run_window_configuration_change_hook.
9671 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9673 * window.c (replace_window): Rename second argument REPLACEMENT to
9674 NEW. New third argument SETFLAG. Rewrite.
9675 (delete_window, make_dummy_parent): Call replace_window with
9677 (window_list_1): Move down in code.
9678 (run_window_configuration_change_hook): Move set_buffer part
9679 before select_frame_norecord part in order to unwind correctly.
9680 Rename count1 to count.
9681 (recombine_windows, delete_deletable_window, resize_root_window)
9682 (Fdelete_other_windows_internal)
9683 (Frun_window_configuration_change_hook, make_parent_window)
9684 (resize_window_check, resize_window_apply, Fresize_window_apply)
9685 (resize_frame_windows, Fsplit_window_internal)
9686 (Fdelete_window_internal, Fresize_mini_window_internal):
9688 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9690 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9692 * window.h (window): Add some new members to window structure -
9693 normal_lines, normal_cols, new_total, new_normal, clone_number,
9694 splits, nest, prev_buffers, next_buffers.
9695 (WINDOW_TOTAL_SIZE): Move here from window.c.
9696 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9698 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9700 (make_dummy_parent): Set new members of windows structure.
9701 (make_window): Move down in code. Handle new members of window
9703 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9704 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9705 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9706 (Fset_window_prev_buffers, Fwindow_next_buffers)
9707 (Fset_window_next_buffers, Fset_window_clone_number):
9709 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9710 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9712 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9713 Argument WINDOW can be now internal window too.
9714 (Fwindow_use_time): Move up in code.
9715 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9717 (Fset_window_configuration, saved_window)
9718 (Fcurrent_window_configuration, save_window_save): Handle new
9719 members of window structure.
9720 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9721 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9722 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9723 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9724 Qget_mru_window, Qresize_root_window,
9725 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9726 Qauto_buffer_name; staticpro them.
9728 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9730 * window.c (Fwindow_total_size, Fwindow_left_column)
9731 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9732 (Fwindow_list_1): New functions.
9733 (window_box_text_cols): Replace with window_body_cols.
9734 (Fwindow_width, Fscroll_left, Fscroll_right):
9735 Use window_body_cols instead of window_box_text_cols.
9736 (delete_window, Fset_window_configuration):
9737 Call delete_all_subwindows with window as argument.
9738 (delete_all_subwindows): Take a window as argument and not a
9740 (window_loop): Remove handling of GET_LRU_WINDOW and
9742 (Fget_lru_window, Fget_largest_window): Move to window.el.
9744 * window.h: Extern window_body_cols instead of
9745 window_box_text_cols. delete_all_subwindows now takes a
9746 Lisp_Object as argument.
9748 * indent.c (compute_motion, Fcompute_motion):
9749 Use window_body_cols instead of window_box_text_cols.
9751 * frame.c (delete_frame): Call delete_all_subwindows with root
9754 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9756 * fns.c (Fputhash): Document return value.
9758 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9760 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9762 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9764 Cons<->int and similar integer overflow fixes (Bug#8794).
9766 Check for overflow when converting integer to cons and back.
9767 * charset.c (Fdefine_charset_internal, Fdecode_char):
9768 Use cons_to_unsigned to catch overflow.
9769 (Fencode_char): Use INTEGER_TO_CONS.
9770 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9771 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9772 * data.c (long_to_cons, cons_to_long): Remove.
9773 (cons_to_unsigned, cons_to_signed): New functions.
9774 These signal an error for invalid or out-of-range values.
9775 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9776 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9777 * font.c (Ffont_variation_glyphs):
9778 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9779 * lisp.h: Include <intprops.h>.
9780 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9781 (cons_to_signed, cons_to_unsigned): New decls.
9782 (long_to_cons, cons_to_long): Remove decls.
9783 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9784 (Fprimitive_undo): Use CONS_TO_INTEGER.
9785 * xfns.c (Fx_window_property): Likewise.
9786 * xselect.c: Include <limits.h>.
9787 (x_own_selection, selection_data_to_lisp_data):
9788 Use INTEGER_TO_CONS.
9789 (x_handle_selection_request, x_handle_selection_clear)
9790 (x_get_foreign_selection, Fx_disown_selection_internal)
9791 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9792 (lisp_data_to_selection_data): Use cons_to_unsigned.
9793 (x_fill_property_data): Use cons_to_signed.
9794 Report values out of range.
9796 Check for buffer and string overflow more precisely.
9797 * buffer.h (BUF_BYTES_MAX): New macro.
9798 * lisp.h (STRING_BYTES_MAX): New macro.
9799 * alloc.c (Fmake_string):
9800 * character.c (string_escape_byte8):
9801 * coding.c (coding_alloc_by_realloc):
9802 * doprnt.c (doprnt):
9803 * editfns.c (Fformat):
9805 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9806 since they may not be the same number.
9807 * editfns.c (Finsert_char):
9808 * fileio.c (Finsert_file_contents):
9809 Likewise for BUF_BYTES_MAX.
9811 * image.c: Use ptrdiff_t, not int, for sizes.
9812 (slurp_file): Switch from int to ptrdiff_t.
9814 (slurp_file): Check that file size fits in both size_t (for
9815 malloc) and ptrdiff_t (for sanity and safety).
9817 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9818 if b->modtime has its maximal value.
9820 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9822 Don't assume time_t can fit into int.
9823 * buffer.h (struct buffer.modtime): Now time_t, not int.
9824 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9825 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9827 Minor fixes for signed vs unsigned integers.
9828 * character.h (MAYBE_UNIFY_CHAR):
9829 * charset.c (maybe_unify_char):
9830 * keyboard.c (read_char, reorder_modifiers):
9831 XINT -> XFASTINT, since the integer must be nonnegative.
9832 * ftfont.c (ftfont_spec_pattern):
9833 * keymap.c (access_keymap, silly_event_symbol_error):
9834 XUINT -> XFASTINT, since the integer must be nonnegative.
9835 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9836 since it makes no difference and we prefer signed.
9837 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9838 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9841 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9843 * window.h (Fwindow_frame): Declare.
9845 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9847 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9848 (SPARE_MEMORY): Always define.
9849 (LARGE_REQUEST): Remove.
9850 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9852 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9854 * lisp.h: Move EXFUNS for Fframe_root_window,
9855 Fframe_first_window and Fset_frame_selected_window to window.h.
9857 * window.h: Move EXFUNS for Fframe_root_window,
9858 Fframe_first_window and Fset_frame_selected_window here from
9861 * frame.c (Fwindow_frame, Fframe_first_window)
9862 (Fframe_root_window, Fframe_selected_window)
9863 (Fset_frame_selected_window): Move to window.c.
9864 (Factive_minibuffer_window): Move to minibuf.c.
9865 (Fother_visible_frames_p): New function.
9867 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9869 * window.c (decode_window, decode_any_window): Move up in code.
9870 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9871 (inhibit_frame_unsplittable): Remove unused variable.
9872 (Fwindow_buffer): Move up and rewrite doc-string.
9873 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9874 (Fwindow_prev): New functions.
9875 (Fwindow_frame): Move here from frame.c. Accept any window as
9877 (Fframe_root_window, Fframe_first_window)
9878 (Fframe_selected_window): Move here from frame.c. Accept frame
9879 or arbitrary window as argument. Update doc-strings.
9880 (Fminibuffer_window): Move up in code.
9881 (Fwindow_minibuffer_p): Move up in code and simplify.
9882 (Fset_frame_selected_window): Move here from frame.c.
9884 (Fselected_window, select_window, Fselect_window): Move up in
9885 code. Minor doc-string fixes.
9887 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9889 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9890 Do not assume that spare memory exists; that assumption is valid
9891 only if SYSTEM_MALLOC.
9892 (LARGE_REQUEST): New macro, so that the issue of large requests
9893 is separated from the issue of spare memory.
9895 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9897 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9900 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9902 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9905 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9907 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9909 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9911 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9912 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9914 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9916 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9918 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9920 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9921 (x_clipboard_manager_save): Add return value.
9922 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9924 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9925 Obey Vx_select_enable_clipboard_manager. Catch errors in
9926 x_clipboard_manager_save (Bug#8779).
9927 (Vx_select_enable_clipboard_manager): New variable.
9928 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9930 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9932 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9934 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9936 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9937 in the current matrix if keep_current_p is non-zero.
9939 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9941 * bidi.c (bidi_level_of_next_char): Fix last change.
9943 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9945 Support bidi reordering of text covered by display properties.
9947 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9948 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9949 (bidi_cache_search, bidi_cache_iterator_state)
9950 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9951 (bidi_level_of_next_char, bidi_move_to_visually_next):
9952 Support character positions inside a run of characters covered by a
9954 (bidi_paragraph_init, bidi_resolve_explicit_1)
9955 (bidi_level_of_next_char): Call bidi_fetch_char and
9956 bidi_fetch_char_advance instead of FETCH_CHAR and
9958 (bidi_init_it): Initialize new members.
9959 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9961 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9962 instead of using explicit *_CHAR codes.
9963 (bidi_resolve_explicit, bidi_resolve_weak):
9964 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9965 bidirectional text is supported only in multibyte buffers.
9966 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9967 it to initialize the frame_window_p member of struct bidi_it.
9968 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9969 (bidi_resolve_explicit, bidi_resolve_weak)
9970 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9971 bidi_it->nchars is non-positive.
9972 (bidi_level_of_next_char): Don't try to lookup the cache for the
9973 next/previous character if nothing is cached there yet, or if we
9974 were just reseat()'ed to a new position.
9976 * xdisp.c (set_cursor_from_row): Set start and stop points
9977 according to the row's direction when priming the loop that looks
9978 for the glyph on which to display cursor.
9979 (single_display_spec_intangible_p): Function deleted.
9980 (display_prop_intangible_p): Reimplement to call
9981 handle_display_spec instead of single_display_spec_intangible_p.
9982 Accept 3 additional arguments needed by handle_display_spec.
9983 This fixes incorrect cursor motion across display property with complex
9984 values: lists, `(when COND...)' forms, etc.
9985 (single_display_spec_string_p): Support property values that are
9986 lists with the argument STRING its top-level element.
9987 (display_prop_string_p): Fix the condition for processing a
9988 property that is a list to be consistent with handle_display_spec.
9989 (handle_display_spec): New function, refactored from the
9990 last portion of handle_display_prop.
9991 (compute_display_string_pos): Accept additional argument
9992 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9993 value of a `display' property is a "replacing spec".
9994 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9995 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9996 the display property, but just return a value indicating whether
9997 the display property will replace the characters it covers.
9998 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9999 frame_window_p members of struct bidi_it.
10000 (compute_display_string_pos, compute_display_string_end):
10002 (push_it): Accept second argument POSITION, where pop_it should
10003 jump to continue iteration.
10004 (reseat_1): Initialize bidi_it.disp_pos.
10006 * keyboard.c (adjust_point_for_property): Adjust the call to
10007 display_prop_intangible_p to its new signature.
10009 * dispextern.h (struct bidi_it): New member frame_window_p.
10010 (bidi_init_it): Update prototypes.
10011 (display_prop_intangible_p): Update prototype.
10012 (compute_display_string_pos, compute_display_string_end):
10013 Declare prototypes.
10014 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10017 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10019 Malloc failure behavior now depends on size of allocation.
10020 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10021 * lisp.h: Change signatures accordingly.
10022 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10023 All callers changed. (Bug#8762)
10025 * gnutls.c: Use Emacs's memory allocators.
10026 Without this change, the gnutls library would invoke malloc etc.
10027 directly, which causes problems on non-SYNC_INPUT hosts, and which
10028 runs afoul of improving memory_full behavior. (Bug#8761)
10029 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10030 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10031 xfree instead of the default malloc, realloc, free.
10032 (Fgnutls_boot): No need to check for memory allocation failure,
10033 since xmalloc does that for us.
10035 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10036 * category.c (hash_get_category_set):
10037 * ccl.c (ccl_driver):
10038 * charset.c (Fdefine_charset_internal):
10039 * charset.h (struct charset.hash_index):
10040 * composite.c (get_composition_id, gstring_lookup_cache)
10041 (composition_gstring_put_cache):
10042 * composite.h (struct composition.hash_index):
10043 * dispextern.h (struct image.hash):
10044 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10045 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10046 (hashfn_equal, hashfn_user_defined, make_hash_table)
10047 (maybe_resize_hash_table, hash_lookup, hash_put)
10048 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10049 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10050 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10051 * image.c (make_image, search_image_cache, lookup_image)
10052 (xpm_put_color_table_h):
10053 * lisp.h (struct Lisp_Hash_Table):
10054 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10055 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10056 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10057 * alloc.c (allocate_vectorlike):
10058 Check for overflow in vector size calculations.
10059 * ccl.c (ccl_driver):
10060 Check for overflow when converting EMACS_INT to int.
10061 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10062 need to be updated by these changes.
10063 * fns.c (make_hash_table, maybe_resize_hash_table):
10064 Check for integer overflow with large hash tables.
10065 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10066 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10067 (SXHASH_REDUCE): New macro.
10068 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10069 Use it instead of discarding useful hash info with large hash values.
10070 (sxhash_float): New function.
10071 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10072 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10073 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10074 Rewrite to use FIXNUM_BITS, as this simplifies things.
10075 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10076 Adjust signatures to match updated version of code.
10077 (consing_since_gc): Now EMACS_INT, since a single hash table can
10078 use more than INT_MAX bytes.
10080 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10082 Make it possible to build with GCC-4.6+ -O2 -flto.
10084 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10086 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10088 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10089 Call minibuffer-inactive-mode.
10091 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10093 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10094 Update dependencies.
10096 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10098 * data.c (init_data): Remove code for UTS, this system is not
10101 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10103 Don't force ./temacs to start in terminal mode.
10105 * frame.c (make_initial_frame): Initialize faces in all cases, not
10106 only when CANNOT_DUMP is defined.
10107 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10109 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10111 * dispnew.c (add_window_display_history): Use const for the string
10112 pointer. Remove declaration, not needed.
10114 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10116 Use 'inline', not 'INLINE'.
10117 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10118 * alloc.c, fontset.c (INLINE): Remove.
10119 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10120 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10121 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10122 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10123 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10125 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10127 Make it possible to run ./temacs.
10129 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10130 syms_of_callproc does the same thing. Remove test for
10131 "initialized", do it in the caller.
10132 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10134 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10136 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10137 (read_minibuf): Use get_minibuffer.
10138 (syms_of_minibuf): Use DEFSYM.
10139 (Qmetadata): New var.
10140 * data.c (Qbuffer): Don't make it static.
10141 (syms_of_data): Use DEFSYM.
10143 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10145 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10146 (CCL_CODE_MIN): New macro.
10148 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10150 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10152 * eval.c (Qdebug): Now static.
10153 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10154 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10155 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10157 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10159 * image.c: Various fixes to ImageMagick code comments.
10160 (Fimagemagick_types): Doc fix.
10162 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10164 Minor fixes prompted by GCC 4.6.0 warnings.
10166 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10168 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10169 (x_clipboard_manager_save_all): Move extern decl to ...
10170 * xterm.h: ... here, so that it can be checked for consistency.
10172 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10174 * xselect.c (x_clipboard_manager_save_frame)
10175 (x_clipboard_manager_save_all): New functions.
10176 (Fx_clipboard_manager_save): Lisp function deleted.
10178 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10179 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10181 * xterm.h: Update prototype.
10183 2011-05-28 William Xu <william.xwl@gmail.com>
10185 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10186 exiting (Bug#8239).
10188 2011-05-28 Jim Meyering <meyering@redhat.com>
10190 Avoid a sign-extension bug in crypto_hash_function.
10191 * fns.c (to_uchar): Define.
10192 (crypto_hash_function): Use it to convert some newly-signed
10193 variables to unsigned, to avoid sign-extension bugs. For example,
10194 without this change, (md5 "truc") would evaluate to
10195 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10196 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10197 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10199 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10201 Integer overflow fixes.
10203 * dbusbind.c: Serial number integer overflow fixes.
10204 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10205 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10206 to hold a serial number that is too large for a fixnum.
10207 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10208 Check for serial numbers out of range. Decode any serial number
10209 that was so large that it became a float. (Bug#8722)
10211 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10212 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10213 Use XFASTINT rather than XUINT when numbers are nonnegative.
10214 (xd_append_arg, Fdbus_method_return_internal):
10215 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10216 arguments, check that Lisp number is nonnegative, rather than
10217 silently wrapping negative numbers around. (Bug#8722)
10218 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10221 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10223 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10225 ccl: Add integer overflow checks.
10226 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10227 (IN_INT_RANGE): New macros.
10228 (ccl_driver): Use them to check for integer overflow when
10229 decoding a CCL program. Many of the new checks are whether XINT (x)
10230 fits in int; it doesn't always, on 64-bit hosts. The new version
10231 doesn't catch all possible integer overflows, but it's an
10232 improvement. (Bug#8719)
10234 * alloc.c (make_event_array): Use XINT, not XUINT.
10235 There's no need for unsigned here.
10237 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10238 This follows up to the 2011-05-06 change that substituted uintptr_t
10239 for EMACS_INT. This case wasn't caught back then.
10241 Rework Fformat to avoid integer overflow issues.
10242 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10243 now (part of C89). Include <verify.h>.
10244 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10245 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10246 (Fformat): Avoid the prepass trying to compute sizes; it was only
10247 approximate and thus did not catch overflow reliably. Instead, walk
10248 through the format just once, formatting and computing sizes as we go,
10249 checking for integer overflow at every step, and allocating a larger
10250 buffer as needed. Keep track separately whether the format is
10251 multibyte. Keep only the most-recently calculated precision, rather
10252 than them all. Record whether each argument has been converted to
10253 string. Use EMACS_INT, not int, for byte and char and arg counts.
10254 Support field widths and precisions larger than INT_MAX. Avoid
10255 sprintf's undefined behavior with conversion specifications such as %#d
10256 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10257 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10258 formatting out-of-range floating point numbers with int
10259 formats. (Bug#8668)
10261 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10263 * data.c: Avoid integer truncation in expressions involving floats.
10264 * data.c: Include <intprops.h>.
10265 (arith_driver): When there's an integer overflow in an expression
10266 involving floating point, convert the integers to floating point
10267 so that the resulting value does not suffer from catastrophic
10268 integer truncation. For example, on a 64-bit host (* 4
10269 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10270 Do not rely on undefined behavior after integer overflow.
10272 merge count_size_as_multibyte, parse_str_to_multibyte
10273 * character.c, character.h (count_size_as_multibyte):
10274 Rename from parse_str_to_multibyte; all uses changed.
10275 Check for integer overflow.
10276 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10277 since it's now a duplicate of the other. This is more of
10278 a character than a buffer op, so better that it's in character.c.
10279 * fns.c, print.c: Adjust to above changes.
10281 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10283 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10285 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10287 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10288 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10289 (x_clipboard_manager_save): Now static.
10290 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10292 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10293 (crypto_hash_function): Now static.
10294 Fix pointer signedness problems. Avoid unnecessary initializations.
10296 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10298 * termhooks.h (Vselection_alist): Make it terminal-local.
10300 * terminal.c (create_terminal): Initialize it.
10302 * xselect.c: Support for clipboard managers.
10303 (Vselection_alist): Move to termhooks.h as terminal-local var.
10304 (LOCAL_SELECTION): New macro.
10305 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10306 (symbol_to_x_atom): Remove gratuitous arg.
10307 (x_handle_selection_request, lisp_data_to_selection_data)
10308 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10309 (x_own_selection, x_get_local_selection, x_convert_selection):
10310 New arg, specifying work frame. Use terminal-local Vselection_alist.
10311 (some_frame_on_display): Delete unused function.
10312 (Fx_own_selection_internal, Fx_get_selection_internal)
10313 (Fx_disown_selection_internal, Fx_selection_owner_p)
10314 (Fx_selection_exists_p): New optional frame arg.
10315 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10316 (x_handle_selection_clear): Don't treat other terminals with the
10317 same keyboard specially. Use the terminal-local Vselection_alist.
10318 (x_clear_frame_selections): Use Frun_hook_with_args.
10320 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10322 * xterm.h: Add support for those atoms.
10324 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10326 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10327 (converted_selections, conversion_fail_tag): New global variables.
10328 (x_selection_request_lisp_error): Free the above.
10329 (x_get_local_selection): Remove unnecessary code.
10330 (x_reply_selection_request): Args changed; handle arbitrary array
10331 of converted selections stored in converted_selections.
10332 Separate the XChangeProperty and SelectionNotify steps.
10333 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10334 (x_convert_selection): New function.
10335 (x_handle_selection_event): Simplify.
10336 (x_get_foreign_selection): Don't ignore incoming requests while
10337 waiting for an answer; this will fail when we implement
10338 SAVE_TARGETS, and seems unnecessary anyway.
10339 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10340 (Vx_sent_selection_functions): Doc fix.
10342 2011-05-26 Leo Liu <sdl.web@gmail.com>
10344 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10346 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10348 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10350 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10351 for fringe update if it has periodic bitmap.
10352 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10353 and fringe_bitmap_periodic_p.
10355 * fringe.c (get_fringe_bitmap_data): New function.
10356 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10357 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10358 row. Mark glyph row for fringe update if periodicity changed.
10360 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10361 for fringe update unless it has periodic bitmap.
10363 2011-05-25 Kenichi Handa <handa@m17n.org>
10365 * xdisp.c (get_next_display_element): Set correct it->face_id for
10366 a static composition.
10368 2011-05-24 Leo Liu <sdl.web@gmail.com>
10371 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10373 * fns.c (crypto_hash_function, Fsha1): New function.
10374 (Fmd5): Use crypto_hash_function.
10375 (syms_of_fns): Add Ssha1.
10377 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10379 * gnutls.c: Remove unused macros.
10380 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10381 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10382 Remove macros that are defined and never used.
10383 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10385 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10387 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10388 (Fx_get_selection_internal): Minor cleanup.
10389 (Fx_own_selection_internal): Rename arguments for consistency with
10392 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10394 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10396 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10398 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10400 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10402 * dispnew.c (scrolling_window): Don't exclude the case that the
10403 last enabled row in the desired matrix touches the bottom boundary.
10405 2011-05-21 Glenn Morris <rgm@gnu.org>
10407 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10408 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10409 and add some more files.
10411 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10413 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10414 report_file_error introduced by the change from 2011-05-07.
10416 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10418 * systime.h (Time): Define only if emacs is defined.
10419 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10420 where the include path doesn't have X11/X.h by default. See
10421 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10423 2011-05-20 Kenichi Handa <handa@m17n.org>
10425 * composite.c (find_automatic_composition): Fix previous change.
10427 2011-05-20 Glenn Morris <rgm@gnu.org>
10429 * lisp.mk: New file, split from Makefile.in.
10430 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10431 (shortlisp): Remove.
10432 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10434 2011-05-19 Glenn Morris <rgm@gnu.org>
10436 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10437 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10438 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10439 (lisp): Set the order to that of loadup.el.
10440 (shortlisp): Make it a copy of $lisp.
10441 (SOME_MACHINE_LISP): Remove.
10442 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10443 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10445 2011-05-18 Kenichi Handa <handa@m17n.org>
10447 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10448 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10449 (find_automatic_composition): Mostly rewrite for efficiency.
10451 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10453 * makefile.w32-in: Update dependencies.
10455 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10457 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10458 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10460 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10462 Fix some integer overflow issues, such as string length overflow.
10464 * insdel.c (count_size_as_multibyte): Check for string overflow.
10466 * character.c (lisp_string_width): Check for string overflow.
10467 Use EMACS_INT, not int, for string indexes and lengths; in
10468 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10469 the resulting string length overflows an EMACS_INT; instead,
10470 report a string overflow if no precision given. When checking for
10471 precision exhaustion, use a check that cannot possibly have
10472 integer overflow. (Bug#8675)
10473 * character.h (lisp_string_width): Adjust to new signature.
10475 * alloc.c (string_overflow): New function.
10476 (Fmake_string): Use it. This doesn't change behavior, but saves
10477 a few bytes and will simplify future changes.
10478 * character.c (string_escape_byte8): Likewise.
10479 * lisp.h (string_overflow): New decl.
10481 Fixups, following up to the user-interface timestamp change.
10482 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10483 for UI timestamps, instead of unsigned long.
10484 * msdos.c (mouse_get_pos): Likewise.
10485 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10486 * w32gui.h (Time): Define by including "systime.h" rather than by
10487 declaring it ourselves. (Bug#8664)
10489 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10490 * image.c (clear_image_cache): Likewise.
10492 * term.c (term_mouse_position): Don't assume time_t wraparound.
10494 Be more systematic about user-interface timestamps.
10495 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10496 and sometimes 'EMACS_UINT', to represent these timestamps.
10497 This change causes it to use 'Time' uniformly, as that's what X uses.
10498 This makes the code easier to follow, and makes it easier to catch
10499 integer overflow bugs such as Bug#8664.
10500 * frame.c (Fmouse_position, Fmouse_pixel_position):
10501 Use Time, not unsigned long, for user-interface timestamps.
10502 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10503 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10504 * keyboard.h (last_event_timestamp): Likewise.
10505 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10506 * menu.h (xmenu_show): Likewise.
10507 * term.c (term_mouse_position): Likewise.
10508 * termhooks.h (struct input_event.timestamp): Likewise.
10509 (struct terminal.mouse_position_hook): Likewise.
10510 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10511 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10512 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10513 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10514 what it was before.
10515 * menu.h, termhooks.h: Include "systime.h", for Time.
10517 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10518 Don't assume that the difference between two unsigned long values
10519 can fit into an integer. At this point, we know button_down_time
10520 <= event->timestamp, so the difference must be nonnegative, so
10521 there's no need to cast the result if double-click-time is
10522 nonnegative, as it should be; check that it's nonnegative, just in
10523 case. This bug is triggered when events are more than 2**31 ms
10524 apart (about 25 days). (Bug#8664)
10526 * xselect.c (last_event_timestamp): Remove duplicate decl.
10527 (x_own_selection): Remove needless cast to unsigned long.
10529 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10530 that always fit in int. Use a sentinel instead of a counter, to
10531 avoid a temp and to allay GCC's concerns about possible int overflow.
10532 * frame.h (struct frame): Use int for menu_bar_items_used
10533 instead of EMACS_INT, since it always fits in int.
10535 * menu.c (grow_menu_items): Check for int overflow.
10537 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10539 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10540 Before, the code was not consistent. These values cannot exceed
10541 2**31 - 1 so there's no need to make them unsigned.
10542 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10543 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10544 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10546 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10548 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10549 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10550 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10551 presumably because the widths might not match.
10553 * window.c (size_window): Avoid needless test at loop start.
10555 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10557 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10559 2011-05-12 Drew Adams <drew.adams@oracle.com>
10561 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10563 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10565 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10566 `width' to `bar_area_x' and `bar_area_width', respectively.
10567 (x_scroll_run): Take account of fringe background extension.
10569 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10570 Rename local vars `left' and `width' to `bar_area_x' and
10571 `bar_area_width', respectively.
10572 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10573 background extension.
10575 2011-05-10 Jim Meyering <meyering@redhat.com>
10577 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10579 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10581 * image.c (Finit_image_library): Return t for built-in image types,
10582 like pbm and xbm. (Bug#8640)
10584 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10586 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10588 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10590 * w32console.c (Fset_screen_color): Doc fix.
10591 (Fget_screen_color): New function.
10592 (syms_of_ntterm): Defsubr it.
10594 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10595 unlink the temporary file if Fcall_process didn't create it in the
10597 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10598 child process will be redirected to a file specified with `:file'.
10599 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10600 cue to call_process_cleanup not to close that handle.
10602 2011-05-07 Ben Key <bkey76@gmail.com>
10604 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10605 one of two shell specific rules, either bootstrap-temacs-CMD or
10606 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10607 to the previous implementation of the bootstrap-temacs rule.
10608 The bootstrap-temacs-CMD rule is similar to the previous
10609 implementation of the bootstrap-temacs rule except that it
10610 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10613 These changes, along with some changes to nt/configure.bat,
10614 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10615 earlier fix to add support for --cflags and --ldflags options
10616 that include quotes so that it works whether make uses cmd or
10619 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10621 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10622 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10624 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10625 a string. Handle both cases.
10626 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10627 (Fdbus_register_method): Use Qinvalid_function.
10629 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10631 * makefile.w32-in: Update dependencies.
10632 (LISP_H): Add inttypes.h and stdin.h.
10633 (PROCESS_H): Add unistd.h.
10635 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10637 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10638 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10640 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10642 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10644 * term.c (vfatal): Remove stray call to va_end.
10645 It's not needed and the C Standard doesn't allow it here anyway.
10647 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10648 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10650 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10653 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10655 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10657 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10659 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10661 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10663 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10664 * charset.c (Fdefine_charset_internal): Don't initialize
10665 charset.code_space[15]. The value was garbage, on hosts with
10666 32-bit int (Bug#8600).
10668 * lread.c (read_integer): Be more consistent with string-to-number.
10669 Use string_to_number to do the actual conversion; this avoids
10670 rounding errors and fixes some other screwups. Without this fix,
10671 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10672 (digit_to_number): Move earlier, for benefit of read_integer.
10673 Return -1 if the digit is out of range for the base, -2 if it is
10674 not a digit in any supported base. (Bug#8602)
10676 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10678 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10679 to match comment at start of function. This also removes a
10680 GCC warning about overflow in a 32+64-bit port.
10682 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10684 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10685 Reported by Stefan Monnier in
10686 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10687 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10688 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10690 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10691 (EMACS_UINTPTR): Likewise, with uintptr_t.
10693 * lisp.h: Prefer 64-bit EMACS_INT if available.
10694 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10695 on 32-bit hosts that have 64-bit int, so that they can access
10697 However, temporarily disable this change unless the temporary
10698 symbol WIDE_EMACS_INT is defined.
10700 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10702 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10703 This removes an assumption that EMACS_INT and long are the same
10704 width as pointers. The assumption is true for Emacs porting targets
10705 now, but we want to make other targets possible.
10706 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10707 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10708 In the rest of the code, change types of integers that hold casted
10709 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10710 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10711 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10712 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10713 No need to cast type when ORing.
10714 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10715 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10716 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10717 assume EMACS_INT is the same width as char *.
10718 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10719 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10720 Remove no-longer-needed casts.
10721 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10722 (xg_tool_bar_help_callback, xg_make_tool_item):
10723 Use EMACS_INTPTR to hold an integer
10724 that will be cast to void *; this can avoid a GCC warning
10725 if EMACS_INT is not the same width as void *.
10726 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10727 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10728 (current_message_1, set_message_1):
10729 Use a local to convert to proper width without a cast.
10730 * xmenu.c (dialog_selection_callback): Likewise.
10732 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10733 Also, don't assume VALBITS / RAND_BITS is less than 5,
10734 and don't rely on undefined behavior when shifting a 1 left into
10736 * lisp.h (get_random): Change signature to match.
10738 * lread.c (hash_string): Use size_t, not int, for hash computation.
10739 Normally we prefer signed values; but hashing is special, because
10740 it's better to use unsigned division on hash table sizes so that
10741 the remainder is nonnegative. Also, size_t is the natural width
10742 for hashing into memory. The previous code used 'int', which doesn't
10743 retain enough info to hash well into very large tables.
10744 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10746 * dbusbind.c: Don't possibly lose pointer info when converting.
10747 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10748 Use XPNTR rather than XHASH, so that the high-order bits of
10749 the pointer aren't lost when converting through void *.
10751 * eval.c (Fautoload): Don't double-shift a pointer.
10753 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10755 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10757 * gnutls.c (DEF_GNUTLS_FN):
10758 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10760 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10762 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10765 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10767 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10768 New version that can reserve upto 2GB of heap space.
10770 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10772 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10774 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10776 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10777 `gnutls_certificate_set_x509_key_file'.
10779 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10781 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10782 Update dependencies.
10784 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10786 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10787 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10788 Remove unused parameter `fildes'.
10789 * process.c (read_process_output, send_process): Don't pass it.
10791 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10793 Fix previous change: the library cache is defined in w32.c.
10794 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10795 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10797 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10799 Implement dynamic loading of GnuTLS on Windows.
10801 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10802 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10803 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10806 * gnutls.c (Qgnutls_dll): Define.
10807 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10808 (gnutls_*): Declare function pointers.
10809 (init_gnutls_functions): New function to initialize function pointers.
10810 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10811 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10812 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10813 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10814 (emacs_gnutls_write, emacs_gnutls_read)
10815 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10816 (Fgnutls_available_p): New function.
10817 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10818 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10819 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10821 * image.c: Include w32.h.
10822 (Vimage_type_cache): Delete.
10823 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10824 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10825 (w32_delayed_load): Move to w32.c.
10827 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10829 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10830 (w32_delayed_load): Move from image.c. When loading a library, record
10831 its filename in the :loaded-from property of the library id.
10832 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10833 Initialize and staticpro them.
10834 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10836 * process.c: Include lisp.h before w32.h, not after.
10837 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10838 instead of gnutls_record_check_pending.
10840 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10842 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10844 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10845 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10848 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10850 * xterm.c (x_set_frame_alpha): Do not set property on anything
10851 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10853 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10855 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10857 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10859 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10860 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10861 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10862 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10863 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10864 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10865 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10866 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10867 (Qgnutls_bootprop_callbacks_verify): Make static.
10869 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10871 * callproc.c: Indentation fixup.
10873 * sysdep.c (wait_for_termination_1): Make static.
10874 (wait_for_termination, interruptible_wait_for_termination):
10875 Move after wait_for_termination_1.
10877 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10879 * sysdep.c (interruptible_wait_for_termination): New function
10880 which is like wait_for_termination, but allows keyboard
10883 * callproc.c (Fcall_process): Add (:file "file") as an option for
10885 (Fcall_process_region): Ditto.
10887 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10889 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10890 rather than `XVECTOR (FOO)->size'.
10892 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10893 inttypes.h, as a gnulib replacement is used if it not available in
10896 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10898 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10899 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10900 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10902 * coding.c (coding_alloc_by_realloc): Error out if destination
10903 will grow beyond MOST_POSITIVE_FIXNUM.
10904 (decode_coding_emacs_mule): Abort if there isn't enough place in
10905 charbuf for the composition carryover bytes. Reserve an extra
10906 space for up to 2 characters produced in a loop.
10907 (decode_coding_iso_2022): Abort if there isn't enough place in
10908 charbuf for the composition carryover bytes.
10910 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10912 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10913 aborting when %lld or %lll format is passed.
10914 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10915 %llo or %llx format is passed. (Bug#8545)
10917 * window.c (window_scroll_line_based): Use a marker instead of
10918 simple variables to record original value of point. (Bug#7952)
10920 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10921 produced by %s or %c overflows available buffer space. (Bug#8545)
10923 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10925 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10926 (SIZE_MAX): Move defn after all includes, as they might #define it.
10928 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10930 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10932 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10934 * keyboard.c (Qdelayed_warnings_hook): Define.
10935 (command_loop_1): Run `delayed-warnings-hook'
10936 if Vdelayed_warnings_list is non-nil.
10937 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10938 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10940 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10942 * doprnt.c (doprnt): Don't return value smaller than the buffer
10943 size if the message was truncated. (Bug#8545).
10945 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10947 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10948 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10950 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10952 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10954 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10956 * makefile.w32-in: Update dependencies.
10958 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10960 Improve `doprnt' and its usage. (Bug#8545)
10961 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10962 `format_end'. Remove support for %l as a conversion specifier.
10963 Don't use xrealloc. Improve diagnostics when the %l size modifier
10964 is used. Update the commentary.
10966 * eval.c (verror): Simplify calculation of size_t.
10968 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10971 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10973 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10976 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10978 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10979 This makes this file independent of the recent pseudovector change.
10981 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10983 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10985 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10986 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10987 Remove unused local.
10988 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10990 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10991 GCC 4.6.0 optimizes based on type-based alias analysis.
10992 For example, if b is of type struct buffer * and v of type struct
10993 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10994 != &v->size, and therefore "v->size = 1; b->size = 2; return
10995 v->size;" must therefore return 1. This assumption is incorrect
10996 for Emacs, since it type-puns struct Lisp_Vector * with many other
10997 types. To fix this problem, this patch adds a new type struct
10998 vectorlike_header that documents the constraints on layout of vectors
10999 and pseudovectors, and helps optimizing compilers not get fooled
11000 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11001 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11002 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11004 (XSETPVECTYPE): Rewrite in terms of new macro.
11005 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11006 This is a bit clearer, and further avoids the possibility of
11007 undesirable aliasing.
11008 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11009 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11010 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11011 since Lisp_Subr is a special case (no "next" field).
11012 (ASIZE): Now uses header.size rather than size.
11013 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11014 to avoid the hassle of writing XVECTOR (foo)->header.size.
11015 (struct vectorlike_header): New type.
11016 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11017 object, to help avoid aliasing.
11018 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11019 (SUBRP): Likewise, since Lisp_Subr is a special case.
11020 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11021 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11022 (struct Lisp_Hash_Table): Combine first two members into a single
11023 struct vectorlike_header member. All uses of "size" and "next" members
11024 changed to be "header.size" and "header.next".
11025 * buffer.h (struct buffer): Likewise.
11026 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11027 * frame.h (struct frame): Likewise.
11028 * process.h (struct Lisp_Process): Likewise.
11029 * termhooks.h (struct terminal): Likewise.
11030 * window.c (struct save_window_data, struct saved_window): Likewise.
11031 * window.h (struct window): Likewise.
11032 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11033 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11034 * buffer.c (init_buffer_once): Likewise.
11035 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11037 * process.c (Fformat_network_address): Use local var for size,
11040 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11042 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11043 * data.c (atof): Remove decl; no longer used or needed.
11044 (digit_to_number): Move to lread.c.
11045 (Fstring_to_number): Use new string_to_number function, to be
11046 consistent with how the Lisp reader treats infinities and NaNs.
11047 Do not assume that floating-point numbers represent EMACS_INT
11048 without losing information; this is not true on most 64-bit hosts.
11049 Avoid double-rounding errors, by insisting on integers when
11050 parsing non-base-10 numbers, as the documentation specifies.
11051 * lisp.h (string_to_number): New decl, replacing ...
11052 (isfloat_string): Remove.
11053 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11054 (read1): Do not accept +. and -. as integers; this
11055 appears to have been a coding error. Similarly, do not accept
11056 strings like +-1e0 as floating point numbers. Do not report
11057 overflow for integer overflows unless the base is not 10 which
11058 means we have no simple and reliable way to continue.
11059 Break out the floating-point parsing into a new
11060 function string_to_number, so that Fstring_to_number parses
11061 floating point numbers consistently with the Lisp reader.
11062 (digit_to_number): Move here from data.c. Make it static inline.
11063 (E_CHAR, EXP_INT): Remove, replacing with ...
11064 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11065 (string_to_number): New function, replacing isfloat_string.
11066 This function checks for valid syntax and produces the resulting
11067 Lisp float number too. Rework it so that string-to-number
11068 no longer mishandles examples like "1.0e+". Use strtoumax,
11069 so that overflow for non-base-10 numbers is reported only when
11070 there's no portable and simple way to convert to floating point.
11072 * textprop.c (set_text_properties_1): Rewrite for clarity,
11073 and to avoid GCC warning about integer overflow.
11075 * intervals.h (struct interval): Use EMACS_INT for members
11076 where EMACS_UINT might cause problems. See
11077 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11078 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11079 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11081 (offset_intervals): Tell GCC not to worry about length overflow
11082 when negating a negative length.
11084 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11085 (overrun_check_free): Likewise.
11087 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11088 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11091 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11092 (gnutls_make_error): Rename local to avoid shadowing.
11093 (gnutls_emacs_global_deinit): ifdef out; not used.
11094 (Fgnutls_boot): Use const for pointer to readonly storage.
11095 Comment out unused local. Fix pointer signedness problems.
11097 * lread.c (openp): Don't stuff size_t into an 'int'.
11098 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11099 about possible signed overflow.
11101 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11102 (GDK_KEY_g): Don't define if already defined.
11103 (xg_prepare_tooltip): Avoid pointer signedness problem.
11104 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11106 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11107 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11109 * xfns.c (Fx_window_property): Simplify a bit,
11110 to make a bit faster and to avoid GCC 4.6.0 warning.
11111 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11113 * fns.c (internal_equal): Don't assume size_t fits in int.
11115 * alloc.c (compact_small_strings): Tighten assertion a little.
11117 Replace pEd with more-general pI, and fix some printf arg casts.
11118 * lisp.h (pI): New macro, generalizing old pEd macro to other
11119 conversion specifiers. For example, use "...%"pI"d..." rather
11120 than "...%"pEd"...".
11121 (pEd): Remove. All uses replaced with similar uses of pI.
11122 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11123 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11124 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11125 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11126 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11127 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11128 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11130 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11131 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11132 * print.c (safe_debug_print, print_object): Likewise.
11133 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11135 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11136 avoiding the 0 flag, which is not portable.
11137 * process.c (Fmake_network_process): Use pI to avoid cast.
11138 * region-cache.c (pp_cache): Likewise.
11139 * xdisp.c (decode_mode_spec): Likewise.
11140 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11141 behavior on 64-bit hosts with printf arg.
11142 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11143 (x_stop_queuing_selection_requests): Likewise.
11144 (x_get_window_property): Don't truncate byte count to an 'int'
11147 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11148 here, since it parses constructs like leading '-' and spaces,
11149 which are not wanted; and it overflows with large numbers.
11150 Instead, simply match F[0-9]+, which is what is wanted anyway.
11152 * alloc.c: Remove unportable assumptions about struct layout.
11153 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11154 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11155 (allocate_vectorlike, make_pure_vector): Use the new macros,
11156 plus offsetof, to remove unportable assumptions about struct layout.
11157 These assumptions hold on all porting targets that I know of, but
11158 they are not guaranteed, they're easy to remove, and removing them
11159 makes further changes easier.
11161 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11162 This doesn't fix a bug but makes the code clearer.
11163 (string_overrun_cookie): Now const. Use initializers that
11164 don't formally overflow signed char, to avoid warnings.
11165 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11166 can cause Emacs to crash when string overrun checking is enabled.
11167 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11168 multiple of sizeof (EMACS_INT); it need not be, if
11169 alignof(EMACS_INT) < sizeof (EMACS_INT).
11170 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11172 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11174 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11176 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11178 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11179 supposed to be handshaking. (Bug#8556)
11180 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11182 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11184 * lisp.h (Qdebug): List symbol.
11185 * eval.c (Qdebug): Restore global linkage.
11186 * keyboard.c (debug-on-event): New variable.
11187 (handle_user_signal): Break into debugger when debug-on-event
11188 matches the current signal symbol.
11190 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11192 * alloc.c (check_sblock, check_string_bytes)
11193 (check_string_free_list): Convert to standard C.
11195 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11197 * w32.c (emacs_gnutls_push): Fix typo.
11199 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11201 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11202 "cast to pointer from integer of different size".
11204 Improve doprnt and its use in verror. (Bug#8545)
11205 * doprnt.c (doprnt): Document the set of format control sequences
11206 supported by the function. Use SAFE_ALLOCA instead of always
11209 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11210 is one byte too soon. Don't use xrealloc; instead xfree and
11213 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11215 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11218 * gnutls.c: Renamed global_initialized to
11219 gnutls_global_initialized. Added internals for the
11220 :verify-hostname-error, :verify-error, and :verify-flags
11221 parameters of `gnutls-boot' and documented those parameters in the
11222 docstring. Start callback support.
11223 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11224 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11225 on error. Return error code.
11226 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11227 (emacs_gnutls_read): Likewise.
11228 (Fgnutls_boot): Return handshake error code.
11229 (emacs_gnutls_handle_error): New function.
11230 (wsaerror_to_errno): Likewise.
11232 * w32.h (emacs_gnutls_pull): Add prototype.
11233 (emacs_gnutls_push): Likewise.
11235 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11236 (emacs_gnutls_push): Likewise.
11238 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11240 * process.c (wait_reading_process_output): Check if GnuTLS
11241 buffered some data internally if no FDs are set for TLS
11244 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11245 (LIBS): Link to USER_LIBS.
11246 ($(BLD)/gnutls.$(0)): New target.
11248 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11250 * xdisp.c (handle_single_display_spec): Rename the
11251 display_replaced_before_p argument into display_replaced_p, to
11252 make it consistent with the commentary. Fix typos in the
11255 * textprop.c (syms_of_textprop): Remove dead code.
11256 (copy_text_properties): Delete obsolete commentary about an
11257 interface that was deleted long ago. Fix typos in the description
11260 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11261 to changes in oldXMenu/XMenu.h from 2011-04-16.
11262 <menu_help_message, prev_menu_help_message>: Constify.
11263 (IT_menu_make_room): menu->help_text is now `const char **';
11266 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11267 to changes in oldXMenu/XMenu.h from 2011-04-16.
11268 (struct XMenu): Declare `help_text' `const char **'.
11270 * xfaces.c <Qunspecified>: Make extern again.
11272 * syntax.c: Include sys/types.h before including regex.h, as
11275 * doc.c (get_doc_string): Improve the format passed to `error'.
11277 * doprnt.c (doprnt): Improve commentary.
11279 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11281 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11284 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11285 changes in globals.h immediately force recompilation.
11286 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11287 $(CURDIR)/s/ms-w32.h.
11288 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11290 * character.c (Fchar_direction): Function deleted.
11291 (syms_of_character): Don't defsubr it.
11292 <char-direction-table>: Deleted.
11294 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11296 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11297 * doprnt.c: Include limits.h.
11298 (SIZE_MAX): New macro.
11299 (doprnt): Return a size_t value. 2nd arg is now size_t.
11300 Many local variables are now size_t instead of int or unsigned.
11301 Improve overflow protection. Support `l' modifier for integer
11302 conversions. Support %l conversion. Don't assume an EMACS_INT
11303 argument for integer conversions and for %c.
11305 * lisp.h (doprnt): Restore prototype.
11307 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11308 $(SRC)/character.h.
11310 * Makefile.in (base_obj): Add back doprnt.o.
11312 * deps.mk (doprnt.o): Add back prerequisites.
11313 (callint.o): Depend on character.h.
11315 * eval.c (internal_lisp_condition_case): Include the handler
11316 representation in the error message.
11317 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11318 when breaking from the loop.
11320 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11322 * callint.c (Fcall_interactively): When displaying error message
11323 about invalid control letter, pass the character's codepoint, not
11324 a pointer to its multibyte form. Improve display of the character
11325 in octal and display also its hex code.
11327 * character.c (char_string): Use %x to display the (unsigned)
11328 codepoint of an invalid character, to avoid displaying a bogus
11331 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11332 `error', not SYMBOL_NAME itself.
11334 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11335 character arguments to `error'.
11337 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11338 to `error' in error message about FINAL_CHAR argument. Make sure
11339 FINAL_CHAR is a character, and use %c when it is passed as
11340 argument to `error'.
11342 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11344 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11346 * w32.c: Include <time.h>.
11347 (sys_localtime): New function.
11349 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11351 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11353 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11355 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11357 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11358 zombies (Bug#8467).
11360 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11362 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11363 gl_state.e_property when gl_state.object is Qt.
11365 * insdel.c (make_gap_larger): Remove limitation of buffer size
11368 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11370 * xdisp.c (lookup_glyphless_char_display)
11371 (produce_glyphless_glyph): Handle cons cell entry in
11372 glyphless-char-display.
11373 (Vglyphless_char_display): Document it.
11375 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11376 glyphless-char-display.
11378 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11380 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11382 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11384 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11385 definition for no-X builds.
11387 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11389 Static checks with GCC 4.6.0 and non-default toolkits.
11391 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11393 * process.c (keyboard_bit_set): Define only if SIGIO.
11394 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11395 (send_process): Repair possible setjmp clobbering.
11397 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11399 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11401 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11403 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11404 Define only if needed.
11406 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11407 by pacifying GCC about it. Maybe it's time to retire it?
11408 * xfaces.c (USG, __TIMEVAL__): Likewise.
11410 * dispextern.h (struct redisplay_interface): Rename param
11411 to avoid shadowing.
11412 * termhooks.h (struct terminal): Likewise.
11413 * xterm.c (xembed_send_message): Likewise.
11415 * insdel.c (make_gap_smaller): Define only if
11416 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11418 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11421 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11422 so that we aren't warned about unused symbols.
11424 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11426 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11428 * xfns.c (x_real_positions): Mark locals as initialized.
11430 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11432 * xterm.c: Fix problems found by static analysis with other toolkits.
11433 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11434 (x_dispatch_event): Declare static if USE_GTK, and
11435 define if USE_GTK || USE_X_TOOLKIT.
11436 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11437 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11438 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11439 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11441 * xmenu.c (menu_help_callback): Pointer type fixes.
11442 Use const pointers when pointing at readonly data. Avoid pointer
11443 signedness clashes.
11444 (FALSE): Remove unused macro.
11445 (update_frame_menubar): Remove unused decl.
11447 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11449 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11450 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11451 (single_menu_item): Rename local to avoid shadowing.
11453 * keyboard.c (make_lispy_event): Remove unused local var.
11455 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11456 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11458 * bitmaps: Change bitmaps from unsigned char back to the X11
11459 compatible char. Avoid the old compiler warnings about
11460 out-of-range initializers by using, for example, '\xab' rather
11463 * xgselect.c (xgselect_initialize): Check vs interface
11464 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11466 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11468 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11469 to read-only memory.
11471 * fns.c (vector): Remove; this old hack is no longer needed.
11473 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11475 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11477 * xrdb.c (x_load_resources): Omit unused local.
11479 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11480 (x_window): Rename locals to avoid shadowing.
11481 (USG): Use the kludged USG macro, to pacify gcc.
11483 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11484 (x_term_init): Remove local to avoid shadowing.
11486 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11488 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11489 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11491 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11493 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11495 Fix regex.c, syntax.c and friends for buffers > 2GB.
11496 * syntax.h (struct gl_state_s): Declare character position members
11499 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11501 * textprop.c (verify_interval_modification, interval_of):
11502 Declare arguments EMACS_INT.
11504 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11507 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11509 * indent.c (Fvertical_motion): Local variable it_start is now
11512 * regex.c (re_match, re_match_2, re_match_2_internal)
11513 (bcmp_translate, regcomp, regexec, print_double_string)
11514 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11515 (re_compile_pattern, re_exec): Declare arguments and local
11516 variables `size_t' and `ssize_t' and return values `regoff_t', as
11518 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11519 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11520 <compile_stack_type>: `size' and `avail' are now `size_t'.
11522 * regex.h <regoff_t>: Use ssize_t, not int.
11523 (re_search, re_search_2, re_match, re_match_2): Arguments that
11524 specify buffer/string position and length are now ssize_t and
11525 size_t. Return type is regoff_t.
11527 2011-04-16 Ben Key <bkey76@gmail.com>
11529 * nsfont.m: Fixed bugs in ns_get_family and
11530 ns_descriptor_to_entity that were caused by using free to
11531 deallocate memory blocks that were allocated by xmalloc (via
11532 xstrdup). This caused Emacs to crash when compiled with
11533 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11534 --enable-checking=xmallocoverrun). xfree is now used to
11535 deallocate these memory blocks.
11537 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11539 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11541 emacs_write: Accept and return EMACS_INT for sizes.
11542 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11544 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11545 Accept and return EMACS_INT.
11546 (emacs_gnutls_write): Return the number of bytes written on
11548 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11549 (emacs_read, emacs_write): Remove check for negative size, as the
11550 Emacs source code has been audited now.
11551 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11552 (emacs_read, emacs_write): Use it.
11553 * process.c (send_process): Adjust to the new signatures of
11554 emacs_write and emacs_gnutls_write. Do not attempt to store
11555 a byte offset into an 'int'; it might overflow.
11556 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11558 * sound.c: Don't assume sizes fit in 'int'.
11559 (struct sound_device.period_size, alsa_period_size):
11560 Return EMACS_INT, not int.
11561 (struct sound_device.write, vox_write, alsa_write):
11562 Accept EMACS_INT, not int.
11563 (wav_play, au_play): Use EMACS_INT to store sizes and to
11564 record read return values.
11566 2011-04-15 Ben Key <bkey76@gmail.com>
11568 * keyboard.c (Qundefined): Don't declare static since it is used
11570 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11571 static since they are used in nsfont.m.
11573 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11575 * process.c (Qprocessp): Don't declare static.
11576 * lisp.h (Qprocessp): Declare again.
11578 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11580 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11582 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11584 Improve C-level modularity by making more things 'static'.
11586 Don't publish debugger-only interfaces to other modules.
11587 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11588 (verify_bytepos, count_markers): Move decls to the only modules
11590 * region-cache.h (pp_cache): Likewise.
11591 * window.h (check_all_windows): Likewise.
11592 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11594 * sysdep.c (croak): Now static, if
11595 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11596 * syssignal.h (croak): Declare only if not static.
11598 * alloc.c (refill_memory_reserve): Now static if
11599 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11600 * lisp.h (refill_memory_reserve): Declare only if not static.
11602 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11603 Define only if USE_LUCID.
11605 * xrdb.c (x_customization_string, x_rm_string): Now static.
11607 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11608 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11610 * xdisp.c (draw_row_with_mouse_face): Now static.
11611 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11613 * window.h (check_all_windows): Mark externally visible.
11615 * window.c (window_deletion_count): Now static.
11617 * undo.c: Make symbols static if they're not exported.
11618 (last_undo_buffer, last_boundary_position, pending_boundary):
11621 * textprop.c (interval_insert_behind_hooks): Now static.
11622 (interval_insert_in_front_hooks): Likewise.
11624 * term.c: Make symbols static if they're not exported.
11625 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11626 (max_frame_lines, tty_set_terminal_modes):
11627 (tty_reset_terminal_modes, tty_turn_off_highlight):
11628 (get_tty_terminal): Now static.
11629 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11630 * termhooks.h (term_mouse_moveto): Do not declare if
11631 HAVE_WINDOW_SYSTEM.
11632 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11633 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11635 * sysdep.c: Make symbols static if they're not exported.
11636 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11638 (sigprocmask_set, full_mask): Remove; unused.
11639 (wait_debugging): Mark as visible.
11640 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11641 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11643 * syntax.c (syntax_temp): Define only if !__GNUC__.
11645 * sound.c (current_sound_device, current_sound): Now static.
11647 * search.c (searchbufs, searchbuf_head): Now static.
11649 * scroll.c (scroll_cost): Remove; unused.
11650 * dispextern.h (scroll_cost): Remove decl.
11652 * region-cache.h (pp_cache): Mark as externally visible.
11654 * process.c: Make symbols static if they're not exported.
11655 (process_tick, update_tick, create_process, chan_process):
11656 (Vprocess_alist, proc_buffered_char, datagram_access):
11657 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11658 (deactivate_process): Mark defn as static, as well as decl.
11659 * lisp.h (create_process): Remove decl.
11660 * process.h (chan_process, Vprocess_alist): Remove decls.
11662 * print.c: Make symbols static if they're not exported.
11663 (print_depth, new_backquote_output, being_printed, print_buffer):
11664 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11665 (print_interval, print_number_index, initial_stderr_stream):
11667 * lisp.h (Fprinc): Remove decl.
11668 (debug_output_compilation_hack): Mark as externally visible.
11670 * sysdep.c (croak): Move decl from here to syssignal.h.
11671 * syssignal.h (croak): Put it here, so the API can be checked when
11672 'croak' is called from dissociate_if_controlling_tty.
11674 * minibuf.c: Make symbols static if they're not exported.
11675 (minibuf_save_list, choose_minibuf_frame): Now static.
11676 * lisp.h (choose_minibuf_frame): Remove decl.
11678 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11680 * lread.c: Make symbols static if they're not exported.
11681 (read_objects, initial_obarray, oblookup_last_bucket_number):
11683 (make_symbol): Remove; unused.
11684 * lisp.h (initial_obarray, make_symbol): Remove decls.
11686 * keyboard.c: Make symbols static if they're not exported.
11687 (single_kboard, recent_keys_index, total_keys, recent_keys):
11688 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11689 (this_single_command_key_start, echoing, last_auto_save):
11690 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11691 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11692 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11693 (Vlispy_mouse_stem, double_click_count):
11695 (force_auto_save_soon): Define only if SIGDANGER.
11696 (ignore_mouse_drag_p): Now static if
11697 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11698 (print_help): Remove; unused.
11699 (stop_character, last_timer_event): Mark as externally visible.
11700 * keyboard.h (ignore_mouse_drag_p): Declare only if
11701 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11702 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11703 * lisp.h (echoing): Remove decl.
11704 (force_auto_save_soon): Declare only if SIGDANGER.
11705 * xdisp.c (redisplay_window): Simplify code, to make it more
11706 obvious that ignore_mouse_drag_p is not accessed if !defined
11707 USE_GTK && !defined HAVE_NS.
11709 * intervals.c: Make symbols static if they're not exported.
11710 (merge_properties_sticky, merge_interval_right, delete_interval):
11712 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11714 * insdel.c: Make symbols static if they're not exported.
11715 However, leave prepare_to_modify_buffer alone. It's never
11716 called from outside this function, but that appears to be a bug.
11717 (combine_after_change_list, combine_after_change_buffer):
11718 (adjust_after_replace, signal_before_change): Now static.
11719 (adjust_after_replace_noundo): Remove; unused.
11720 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11721 (signal_before_change): Remove decls.
11723 * indent.c (val_compute_motion, val_vmotion): Now static.
11725 * image.c: Make symbols static if they're not exported.
11726 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11728 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11729 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11731 * fringe.c (standard_bitmaps): Now static.
11732 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11734 * frame.c: Make symbols static if they're not exported.
11735 (x_report_frame_params, make_terminal_frame): Now static.
11736 (get_frame_param): Now static, unless HAVE_NS.
11737 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11738 (x_get_resource_string): Remove; not used.
11739 * frame.h (make_terminal_frame, x_report_frame_params):
11740 (x_get_resource_string); Remove decls.
11741 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11742 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11744 * font.c, fontset.c: Make symbols static if they're not exported.
11745 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11746 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11747 * font.c (font_close_object): Now static.
11748 * font.h (font_close_object): Remove.
11749 * fontset.c (FONTSET_OBJLIST): Remove.
11750 (free_realized_fontset) #if-0 the body, which does nothing.
11751 (face_suitable_for_char_p): #if-0, as it's never called.
11752 * fontset.h (face_suitable_for_char_p): Remove decl.
11753 * xfaces.c (face_at_string_position):
11754 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11755 since 0 is always ASCII.
11757 * fns.c (weak_hash_tables): Now static.
11759 * fileio.c: Make symbols static if they're not exported.
11760 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11761 (Vwrite_region_annotation_buffers): Now static.
11763 * eval.c: Make symbols static if they're not exported.
11764 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11765 * lisp.h (backtrace_list): Remove decl.
11767 * emacs.c: Make symbols static if they're not exported.
11768 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11769 (fatal_error_code, fatal_error_signal_hook, standard_args):
11771 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11772 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11773 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11774 * lisp.h (fatal_error_signal_hook): Remove decl.
11775 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11777 * editfns.c: Move a (normally-unused) function to its only use.
11778 * editfns.c, lisp.h (get_operating_system_release): Remove.
11779 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11780 worth the hassle of breaking this out.
11782 * xterm.c: Make symbols static if they're not exported.
11783 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11784 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11785 (x_destroy_window, x_delete_display):
11787 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11788 (x_mouse_leave): Remove; unused.
11789 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11790 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11791 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11793 (x_mouse_leave): Declare only if WINDOWSNT.
11794 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11795 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11798 * ftxfont.c: Make symbols static if they're not exported.
11799 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11801 * font.h (ftxfont_driver): Likewise.
11803 * xfns.c: Make symbols static if they're not exported.
11804 (x_last_font_name, x_display_info_for_name):
11805 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11806 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11807 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11808 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11809 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11810 (last_show_tip_args): Now static.
11811 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11812 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11813 (x_screen_planes): Remove; unused.
11814 * dispextern.h (x_screen_planes): Remove decl.
11816 * dispnew.c: Make symbols static if they're not exported.
11817 * dispextern.h (redraw_garbaged_frames, scrolling):
11818 (increment_row_positions): Remove.
11819 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11820 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11822 (redraw_garbaged_frames): Remove; unused.
11824 * xfaces.c: Make symbols static if they're not exported.
11825 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11827 * xterm.h (defined_color): Remove decls.
11828 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11829 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11830 (menu_face_changed_default, defined_color, free_realized_face):
11831 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11832 (ascii_face_of_lisp_face): Remove; unused.
11834 * xdisp.c: Make symbols static if they're not exported.
11835 * dispextern.h (scratch_glyph_row, window_box_edges):
11836 (glyph_to_pixel_coords, set_cursor_from_row):
11837 (get_next_display_element, set_iterator_to_next):
11838 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11839 (show_mouse_face): Remove decls
11840 * frame.h (message_buf_print): Likewise.
11841 * lisp.h (pop_message, set_message, check_point_in_composition):
11843 * xterm.h (set_vertical_scroll_bar): Likewise.
11844 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11845 (message_buf_print, scratch_glyph_row, displayed_buffer):
11846 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11847 (get_next_display_element, show_mouse_face, window_box_edges):
11848 (frame_to_window_pixel_xy, check_point_in_composition):
11849 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11850 (glyph_to_pixel_coords): Remove; unused.
11852 * dired.c (file_name_completion): Now static.
11854 * dbusbind.c (xd_in_read_queued_messages): Now static.
11856 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11857 * data.c (circular_list_error): Remove.
11859 * commands.h (last_point_position, last_point_position_buffer):
11860 (last_point_position_window): Remove decls.
11861 * keyboard.c: Make these variables static.
11863 * coding.h (coding, code_convert_region, encode_coding_gap):
11865 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11866 (iso_code_class, detect_coding, code_convert_region): Now static.
11867 (encode_coding_gap): Remove; unused.
11869 * chartab.c (chartab_chars, chartab_bits): Now static.
11871 * charset.h (charset_iso_8859_1): Remove decl.
11872 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11875 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11876 * ccl.c (Vccl_program_table): Now static.
11877 (check_ccl_update): Remove; unused.
11879 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11880 * category.h: ... from here.
11881 * category.c (check_category_table, set_category_set): Now static.
11883 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11884 * lisp.h: Remove these decls.
11886 * buffer.c (buffer_count): Remove unused var.
11888 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11889 so that it's not optimized away.
11890 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11891 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11892 exported only to the debugger.
11894 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11895 * atimer.h (run_all_atimers): Remove; not exported.
11897 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11898 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11899 was inaccessible from Lisp.
11900 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11901 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11903 alloc.c: Import and export fewer symbols, and remove unused items.
11904 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11906 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11907 it's not optimized away by whole-program optimization.
11908 (message_enable_multibyte, free_misc): Remove.
11909 (catchlist, handlerlist, mark_backtrace):
11910 Declare only if BYTE_MARK_STACK.
11911 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11912 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11913 (message_enable_multibyte): Remove decl.
11914 (free_misc, interval_free_list, float_block, float_block_index):
11915 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11916 (cons_free_list, last_marked_index):
11918 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11919 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11920 (mark_backtrace): Define only if BYTE_MARK_STACK.
11921 * xdisp.c (message_enable_multibyte): Now static.
11923 Declare Lisp_Object Q* variables to be 'static' if not exported.
11924 This makes it easier for human readers (and static analyzers)
11925 to see whether these variables are used from other modules.
11926 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11927 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11928 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11929 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11930 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11931 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11932 * xmenu.c, xselect.c:
11933 Declare Q* vars static if they are not used in other modules.
11934 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11935 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11936 Remove decls of unexported vars.
11937 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11939 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11941 Make Emacs functions such as Fatom 'static' by default.
11942 This makes it easier for human readers (and static analyzers)
11943 to see whether these functions can be called from other modules.
11944 DEFUN now defines a static function. To make the function external
11945 so that it can be used in other C modules, use the new macro DEFUE.
11946 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11947 (Finit_image_library):
11948 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11949 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11950 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11951 Remove decls, since these functions are now static.
11952 (Funintern, Fget_internal_run_time): New decls, since these functions
11953 were already external.
11955 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11956 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11957 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11958 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11959 * keyboard.c, keymap.c, lread.c:
11960 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11961 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11962 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11963 Mark functions with DEFUE instead of DEFUN,
11964 if they are used in other modules.
11965 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11966 decls for now-static functions.
11967 * buffer.h (Fdelete_overlay): Remove decl.
11968 * callproc.c (Fgetenv_internal): Mark as internal.
11969 * composite.c (Fremove_list_of_text_properties): Remove decl.
11970 (Fcomposition_get_gstring): New forward static decl.
11971 * composite.h (Fcomposite_get_gstring): Remove decl.
11972 * dired.c (Ffile_attributes): New forward static decl.
11973 * doc.c (Fdocumntation_property): New forward static decl.
11974 * eval.c (Ffetch_bytecode): New forward static decl.
11975 (Funintern): Remove extern decl; now in .h file where it belongs.
11976 * fileio.c (Fmake_symbolic_link): New forward static decl.
11977 * image.c (Finit_image_library): New forward static decl.
11978 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11979 * intervals.h (Fprevious_property_change):
11980 (Fremove_list_of_text_properties): Remove decls.
11981 * keyboard.c (Fthis_command_keys): Remove decl.
11982 (Fcommand_execute): New forward static decl.
11983 * keymap.c (Flookup_key): New forward static decl.
11984 (Fcopy_keymap): Now static.
11985 * keymap.h (Flookup_key): Remove decl.
11986 * process.c (Fget_process): New forward static decl.
11987 (Fprocess_datagram_address): Mark as internal.
11988 * syntax.c (Fsyntax_table_p): New forward static decl.
11989 (skip_chars): Remove duplicate decl.
11990 * textprop.c (Fprevious_property_change): New forward static decl.
11991 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11993 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11994 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11996 * editfns.c (Fformat): Remove unreachable code.
11998 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12000 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12003 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12005 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12006 when at ZV. (Bug#8487)
12008 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12010 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12012 * keyboard.c (parse_tool_bar_item): Likewise.
12013 * sound.c (sound_cleanup, alsa_close): Likewise.
12014 * termcap.c (tgetent): Likewise.
12015 * xfns.c (x_default_font_parameter): Likewise.
12016 * xsettings.c (read_and_apply_settings): Likewise.
12018 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12019 (overrun_check_free): Protoize.
12021 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12023 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12024 since callers should never pass a negative size.
12025 Change the signature to match that of plain 'read' and 'write'; see
12026 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12027 * lisp.h: Update prototypes of emacs_write and emacs_read.
12029 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12031 * xdisp.c (redisplay_window): Don't try to determine the character
12032 position of the scroll margin if the window start point w->startp
12033 is outside the buffer's accessible region. (Bug#8468)
12035 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12037 Fix write-region and its subroutines for buffers > 2GB.
12038 * fileio.c (a_write, e_write): Modify declaration of arguments and
12039 local variables to support buffers larger than 2GB.
12040 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12042 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12043 argument, local variables, and return value.
12045 * lisp.h: Update prototypes of emacs_write and emacs_read.
12047 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12049 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12051 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12053 Fix more problems found by GCC 4.6.0's static checks.
12055 * xdisp.c (vmessage): Use a better test for character truncation.
12057 * charset.c (load_charset_map): <, not <=, for optimization,
12058 and to avoid potential problems with integer overflow.
12059 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12060 * casetab.c (set_identity, shuffle): Likewise.
12061 * editfns.c (Fformat): Likewise.
12062 * syntax.c (skip_chars): Likewise.
12064 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12065 This also lets GCC 4.6.0 generate slightly better loop code.
12067 * callint.c (Fcall_interactively): <, not <=, for optimization.
12068 (Fcall_interactively): Count the number of arguments produced,
12069 not the number of arguments given. This is simpler and lets GCC
12070 4.6.0 generate slightly better code.
12072 * ftfont.c: Distingish more carefully between FcChar8 and char.
12073 The previous code passed unsigned char * to a functions like
12074 strlen and xstrcasecmp that expect char *, which does not
12075 conform to the C standard.
12076 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12077 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12078 char * when the C standard requires it.
12080 * keyboard.c (read_char): Remove unused var.
12082 * eval.c: Port to Windows vsnprintf (Bug#8435).
12083 Include <limits.h>.
12084 (SIZE_MAX): Define if the headers do not.
12085 (verror): Do not give up if vsnprintf returns a negative count.
12086 Instead, grow the buffer. This ports to Windows vsnprintf, which
12087 does not conform to C99. Problem reported by Eli Zaretskii.
12088 Also, simplify the allocation scheme, by avoiding the need for
12089 calling realloc, and removing the ALLOCATED variable.
12091 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12093 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12094 But keep the doprint source code for now, as we might revamp it
12095 and use it again (Bug#8435).
12096 * lisp.h (doprnt): Remove.
12097 * Makefile.in (base_obj): Remove doprnt.o.
12098 * deps.mk (doprnt.o): Remove.
12100 error: Print 32- and 64-bit integers portably (Bug#8435).
12101 Without this change, on typical 64-bit hosts error ("...%d...", N)
12102 was used to print both 32- and 64-bit integers N, which relied on
12103 undefined behavior.
12104 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12105 * lisp.h (error, verror): Mark as printf-like functions.
12106 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12107 Report overflow in size calculations when allocating printf buffer.
12108 Do not truncate output string at its first null byte.
12109 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12110 Truncate the output at a character boundary, since vsnprintf does not
12112 * charset.c (check_iso_charset_parameter): Convert internal
12113 character to string before calling 'error', since %c now has the
12115 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12116 overflow when computing char to be passed to 'error'. Do not
12117 pass Lisp_Object to 'error'; pass the integer instead.
12118 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12119 formatted with plain %d.
12121 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12123 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12125 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12127 * xterm.c (x_catch_errors): Remove duplicate declaration.
12129 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12131 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12133 2011-04-10 Jim Meyering <meyering@redhat.com>
12135 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12136 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12137 return ssize_t not "int", and use size_t as the buffer length.
12138 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12139 * gnutls.h: Update declarations.
12140 * process.c (read_process_output): Use ssize_t, to match.
12141 (send_process): Likewise.
12143 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12145 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12147 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12149 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12150 Use unsigned char, to match FcChar8 type definition.
12152 * xterm.c (handle_one_xevent):
12153 * xmenu.c (create_and_show_popup_menu):
12154 * xselect.c (x_decline_selection_request)
12155 (x_reply_selection_request): Avoid type-punned deref of X events.
12157 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12159 Fix some uses of `int' instead of EMACS_INT.
12160 * search.c (string_match_1, fast_string_match)
12161 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12162 (scan_buffer, find_next_newline_no_quit)
12163 (find_before_next_newline, search_command, Freplace_match)
12164 (Fmatch_data): Make some `int' variables be EMACS_INT.
12166 * xdisp.c (display_count_lines): 3rd argument and return value now
12167 EMACS_INT. All callers changed.
12168 (pint2hrstr): Last argument is now EMACS_INT.
12170 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12171 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12172 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12173 (decode_coding_utf_16, decode_coding_emacs_mule)
12174 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12175 (decode_coding_ccl, decode_coding_charset)
12176 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12177 (decode_coding_iso_2022, decode_coding_emacs_mule)
12178 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12179 <char_offset, last_offset>: Declare EMACS_INT.
12180 (encode_coding_utf_8, encode_coding_utf_16)
12181 (encode_coding_emacs_mule, encode_invocation_designation)
12182 (encode_designation_at_bol, encode_coding_iso_2022)
12183 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12184 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12186 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12187 (encode_invocation_designation): Last argument P_NCHARS is now
12189 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12190 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12192 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12195 * ccl.c (Fccl_execute_on_string): Declare some variables
12198 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12200 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12202 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12204 * process.c (Fformat_network_address): Doc fix.
12206 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12208 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12210 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12212 * keyboard.c (read_char): Call Lisp function help-form-show,
12213 instead of using internal_with_output_to_temp_buffer.
12214 (Qhelp_form_show): New var.
12215 (syms_of_keyboard): Use DEFSYM macro.
12217 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12219 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12221 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12223 * process.c (Flist_processes): Remove to Lisp.
12224 (list_processes_1): Delete.
12226 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12228 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12230 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12232 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12234 Fix more problems found by GCC 4.6.0's static checks.
12236 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12238 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12240 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12242 * xdisp.c (vmessage): Mark as a printf-like function.
12244 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12246 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12248 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12249 printf-like functions.
12250 (tiff_load): Add casts to remove these marks before passing them
12251 to system-supplied API.
12253 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12255 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12256 This avoids several warnings with gcc -Wstrict-overflow.
12257 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12258 directly, rather than having caller test rule sign. This avoids
12259 some unnecessary tests.
12260 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12261 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12262 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12264 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12265 (xfont_open): Avoid unnecessary tests.
12267 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12269 * composite.h, composite.c (composition_gstring_put_cache):
12270 Use EMACS_INT, not int, for length.
12272 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12273 breaking out part of COMPOSITION_DECODE_RULE.
12274 (COMPOSITION_DECODE_RULE): Use it.
12275 * composite.c (get_composition_id): Remove unused local vars,
12276 by using the new macro.
12278 * textprop.c (set_text_properties_1): Change while to do-while,
12279 since the condition is always true at first.
12281 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12282 (interval_deletion_adjustment): Return unsigned value.
12285 * process.c (list_processes_1, create_pty, read_process_output):
12286 (exec_sentinel): Remove vars that were set but not used.
12287 (create_pty): Remove unnecessary "volatile"s.
12288 (Fnetwork_interface_info): Avoid possibility of int overflow.
12289 (read_process_output): Do adaptive read buffering even if carryover.
12290 (read_process_output): Simplify nbytes computation if buffered.
12292 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12294 * syntax.c (scan_words): Remove var that was set but not used.
12295 (update_syntax_table): Use unsigned instead of int.
12297 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12298 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12299 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12301 * print.c (print_error_message): Avoid int overflow.
12303 * font.c (font_list_entities): Redo for clarity,
12304 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12306 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12307 (font_score): Avoid potential overflow in diff calculation.
12309 * fns.c (substring_both): Remove var that is set but not used.
12310 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12312 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12314 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12315 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12316 can always succeed if overflow has undefined behavior.
12318 * search.c (boyer_moore, wordify): Remove vars set but not used.
12319 (wordify): Omit three unnecessary tests.
12321 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12322 All callers changed. This avoids the need for an unused var.
12324 * casefiddle.c (casify_region): Remove var that is set but not used.
12326 * dired.c (file_name_completion): Remove var that is set but not used.
12328 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12330 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12331 (Finsert_file_contents): Remove unnecessary code checking fd.
12333 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12334 Check for integer overflow on size calculations.
12336 * buffer.c (Fprevious_overlay_change): Remove var that is set
12339 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12340 Remove vars that are set but not used.
12341 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12342 (timer_check_2): Mark vars as initialized.
12344 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12346 * image.c (lookup_image): Remove var that is set but not used.
12347 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12349 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12350 that are set but not used.
12352 * xfns.c (make_invisible_cursor): Don't return garbage
12353 if XCreateBitmapFromData fails (Bug#8410).
12355 * xselect.c (x_get_local_selection, x_handle_property_notify):
12356 Remove vars that are set but not used.
12358 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12359 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12361 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12362 Remove var that is set but not used.
12363 (scroll_bar_windows_size): Now size_t, not int.
12364 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12365 Check for overflow.
12367 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12368 (map_tty_color) [!defined MSDOS]: Likewise.
12370 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12372 * coding.c: Remove vars that are set but not used.
12373 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12374 All callers changed.
12375 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12376 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12377 (decode_coding_charset): Remove vars that are set but not used.
12379 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12380 that is set but not used.
12382 * print.c (print_object): Remove var that is set but not used.
12384 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12385 The gnulib version avoids calling malloc in the usual case,
12386 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12387 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12388 * filelock.c (current_lock_owner): Likewise.
12389 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12390 * sysdep.c: Include allocator.h, careadlinkat.h.
12391 (emacs_no_realloc_allocator): New static constant.
12392 (emacs_readlink): New function.
12393 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12394 ../lib/careadlinkat.h.
12396 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12398 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12399 first non-nil return value).
12401 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12403 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12404 if not defined (Bug#8403).
12406 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12408 * xdisp.c (display_count_lines): Remove parameter `start',
12409 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12410 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12411 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12412 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12413 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12414 and thereabouts. All callers changed.
12415 (get_per_char_metric): Remove parameter `f', unused since
12416 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12418 2011-04-02 Jim Meyering <meyering@redhat.com>
12420 do not dereference NULL upon failed strdup
12421 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12422 (ns_get_family): Likewise.
12424 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12426 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12428 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12430 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12433 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12435 Add lexical binding.
12437 * window.c (Ftemp_output_buffer_show): New fun.
12438 (Fsave_window_excursion):
12439 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12441 * lread.c (lisp_file_lexically_bound_p): New function.
12442 (Fload): Bind Qlexical_binding.
12443 (readevalloop): Remove `evalfun' arg.
12444 Bind Qinternal_interpreter_environment.
12445 (Feval_buffer): Bind Qlexical_binding.
12446 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12448 (syms_of_lread): Declare `lexical-binding'.
12450 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12452 * keyboard.c (eval_dyn): New fun.
12453 (menu_item_eval_property): Use it.
12455 * image.c (parse_image_spec): Use Ffunctionp.
12457 * fns.c (concat, mapcar1): Accept byte-code-functions.
12459 * eval.c (Fsetq): Handle lexical vars.
12460 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12461 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12462 (FletX, Flet): Obey lexical binding.
12463 (Fcommandp): Handle closures.
12464 (Feval): New `lexical' arg.
12465 (eval_sub): New function extracted from Feval. Use it almost
12466 everywhere where Feval was used. Look up vars in lexical env.
12468 (Ffunctionp): Move from subr.el.
12469 (Ffuncall): Handle closures.
12470 (apply_lambda): Remove `eval_flags'.
12471 (funcall_lambda): Handle closures and new byte-code-functions.
12472 (Fspecial_variable_p): New function.
12473 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12474 but without exporting it to Lisp.
12476 * doc.c (Fdocumentation, store_function_docstring):
12477 * data.c (Finteractive_form): Handle closures.
12479 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12482 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12484 (exec_byte_code): New function extracted from Fbyte_code to handle new
12485 calling convention for byte-code-functions. Add new byte-codes.
12487 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12489 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12491 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12493 * xdisp.c (redisplay_internal): Fix prototype.
12495 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12497 * xdisp.c (SCROLL_LIMIT): New macro.
12498 (try_scrolling): Use it when setting scroll_limit.
12499 Limit scrolling to 100 screen lines.
12500 (redisplay_window): Even when falling back on "recentering",
12501 position point in the window according to scroll-conservatively,
12502 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12504 (try_scrolling): When point is above the window, allow searching
12505 as far as scroll_max, or one screenful, to compute vertical
12506 distance from PT to the scroll margin position. This prevents
12507 try_scrolling from unnecessarily failing when
12508 scroll-conservatively is set to a value slightly larger than the
12509 window height. Clean up the case of PT below the margin at bottom
12510 of window: scroll_max can no longer be INT_MAX. When aggressive
12511 scrolling is in use, don't let point enter the opposite scroll
12512 margin as result of the scroll.
12513 (syms_of_xdisp) <scroll-conservatively>: Document the
12514 threshold of 100 lines for never-recentering scrolling.
12516 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12518 * dispextern.h (move_it_by_lines):
12519 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12520 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12521 (message_log_check_duplicate): Remove parameters `prev_bol' and
12522 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12523 (redisplay_internal): Remove parameter `preserve_echo_area',
12524 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12526 * indent.c (Fvertical_motion):
12527 * window.c (window_scroll_pixel_based, Frecenter):
12528 Don't pass `need_y_p' to `move_it_by_lines'.
12530 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12532 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12533 steal a few bits to be more compact.
12534 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12535 Remove unneeded casts.
12537 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12539 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12541 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12542 binding" message (bug#7967).
12544 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12546 Fix more problems found by GCC 4.6.0's static checks.
12548 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12549 Remove unused local var.
12551 * editfns.c (Fmessage_box): Remove unused local var.
12553 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12554 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12555 Omit unused local vars.
12556 * window.c (shrink_windows): Omit unused local var.
12557 * menu.c (digest_single_submenu): Omit unused local var.
12558 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12559 Omit unused local var.
12561 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12562 Don't assume string length fits in int.
12563 (keyremap_step, read_key_sequence): Use size_t for sizes.
12564 (read_key_sequence): Don't check last_real_key_start redundantly.
12566 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12567 instead of alloca (Bug#8344).
12569 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12570 (Fbacktrace_frame): Don't assume nframes fits in int.
12572 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12574 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12577 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12579 * cm.c (calccost): Turn while-do into do-while, for clarity.
12581 * keyboard.c (syms_of_keyboard): Use the same style as later
12582 in this function when indexing through an array. This also
12583 works around GCC bug 48267.
12585 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12587 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12589 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12590 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12592 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12593 This avoids undefined behavior on integer overflow, and is a bit
12594 more convenient anyway since it is compared to a size_t variable.
12596 Variadic C functions now count arguments with size_t, not int.
12597 This avoids an unnecessary limitation on 64-bit machines, which
12598 caused (substring ...) to crash on large vectors (Bug#8344).
12599 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12600 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12601 All variadic functions and their callers changed accordingly.
12602 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12603 * data.c (arith_driver, float_arith_driver): Likewise.
12604 * editfns.c (general_insert_function): Likewise.
12605 * eval.c (struct backtrace.nargs, interactive_p)
12606 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12607 (funcall_lambda, mark_backtrace): Likewise.
12608 * fns.c (concat): Likewise.
12609 * frame.c (x_set_frame_parameters): Likewise.
12610 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12611 0 if not found, not -1. All callers changed.
12613 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12614 (stack_copy_size): Now size_t, not int.
12615 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12617 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12619 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12620 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12621 All callers changed.
12623 * lisp.h (multibyte_char_to_unibyte):
12624 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12625 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12626 * character.h (CHAR_TO_BYTE8):
12627 * cmds.c (internal_self_insert):
12628 * editfns.c (general_insert_function):
12629 * keymap.c (push_key_description):
12630 * search.c (Freplace_match):
12631 * xdisp.c (message_dolog, set_message_1): All callers changed.
12633 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12635 * keyboard.c (safe_run_hook_funcall): New function.
12636 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12637 don't set the hook to nil, but remove the offending function instead.
12638 (Qcommand_hook_internal): Remove, unused.
12639 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12640 Vcommand_hook_internal.
12642 * eval.c (enum run_hooks_condition): Remove.
12643 (funcall_nil, funcall_not): New functions.
12644 (run_hook_with_args): Call each function through a `funcall' argument.
12645 Remove `cond' argument, now redundant.
12646 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12647 (Frun_hook_with_args_until_failure): Adjust accordingly.
12648 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12650 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12652 * dispextern.h (string_buffer_position): Remove declaration.
12654 * print.c (strout): Remove parameter `multibyte', unused since
12655 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12657 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12658 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12659 All callers changed.
12661 * w32.c (_wsa_errlist): Use braces for struct initializers.
12663 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12664 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12665 All callers changed.
12666 (string_buffer_position): Likewise. Also, make static (it's never
12667 used outside xdisp.c).
12668 (cursor_row_p): Remove parameter `w', unused since
12669 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12670 (decode_mode_spec): Remove parameter `precision', introduced during
12671 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12672 All callers changed.
12674 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12676 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12678 2011-03-27 Anders Lindgren <andlind@gmail.com>
12680 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12681 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12682 (ns_update_auto_hide_menu_bar): New functions.
12683 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12684 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12685 ns_constrain_all_frames.
12686 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12687 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12689 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12691 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12693 2011-03-27 Glenn Morris <rgm@gnu.org>
12695 * syssignal.h: Replace RETSIGTYPE with void.
12696 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12697 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12698 Replace SIGTYPE with void everywhere.
12699 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12700 * s/template.h (SIGTYPE): Remove commented out definition.
12702 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12704 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12705 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12707 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12709 * w32.c (read_unc_volume): Use parameter `henum', instead of
12710 global variable `wget_enum_handle'.
12712 * keymap.c (describe_vector): Remove parameters `indices' and
12713 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12714 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12716 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12718 * keyboard.c (timer_check): Remove parameter `do_it_now',
12719 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12720 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12721 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12723 * keyboard.c (read_char):
12724 * w32menu.c (w32_menu_display_help):
12725 * xmenu.c (show_help_event, menu_help_callback):
12726 Adjust calls to `show_help_echo'.
12728 * gtkutil.c (xg_maybe_add_timer):
12729 * keyboard.c (readable_events):
12730 * process.c (wait_reading_process_output):
12731 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12733 * insdel.c (adjust_markers_gap_motion):
12734 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12735 (gap_left, gap_right): Don't call it.
12737 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12739 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12740 incurred during fontification.
12742 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12744 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12745 (DEFVAR_PER_BUFFER): Don't pass it.
12747 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12748 (scrolling_window): Don't pass it.
12750 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12752 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12754 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12756 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12757 of variables specific to SELinux and computation of `encoded_absname'.
12759 * image.c (XPutPixel): Remove unused variable `height'.
12761 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12763 * unexw32.c (get_section_info): Remove unused variable `section'.
12765 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12766 (system_process_attributes): Remove unused variable `sess'.
12767 (sys_read): Remove unused variable `err'.
12769 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12770 (w32_wnd_proc): Remove unused variable `isdead'.
12771 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12772 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12773 (x_create_tip_frame): Remove unused variable `tem'.
12775 * w32inevt.c (w32_console_read_socket):
12776 Remove unused variable `no_events'.
12778 * w32term.c (x_draw_composite_glyph_string_foreground):
12779 Remove unused variable `width'.
12781 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12783 * w32term.c (x_set_glyph_string_clipping):
12784 Don't pass uninitialized region to CombineRgn.
12786 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12788 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12789 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12790 (Fx_close_connection): Remove unused variable `i'.
12792 * w32font.c (w32font_draw): Return number of glyphs.
12793 (w32font_open_internal): Remove unused variable `i'.
12794 (w32font_driver): Add missing initializer.
12796 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12797 (fill_in_menu): Remove unused variable `items_added'.
12799 * w32term.c (last_mouse_press_frame): Remove static global variable.
12800 (w32_clip_to_row): Remove unused variable `f'.
12801 (x_delete_terminal): Remove unused variable `i'.
12803 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12804 (NOTHING): Remove unused static global variable.
12805 (uniscribe_check_otf): Remove unused variable `table'.
12806 (uniscribe_font_driver): Add missing initializers.
12808 2011-03-23 Julien Danjou <julien@danjou.info>
12810 * term.c (Fsuspend_tty, Fresume_tty):
12811 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12812 * window.c (temp_output_buffer_show):
12813 * insdel.c (signal_before_change):
12814 * frame.c (Fhandle_switch_frame):
12815 * fileio.c (Fdo_auto_save):
12816 * emacs.c (Fkill_emacs):
12817 * editfns.c (save_excursion_restore):
12818 * cmds.c (internal_self_insert):
12819 * callint.c (Fcall_interactively):
12820 * buffer.c (Fkill_all_local_variables):
12821 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12823 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12824 unconditionally since it does the check itself.
12826 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12828 Fix more problems found by GCC 4.5.2's static checks.
12830 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12831 the first time through the loop, since we know p0 < p1 then.
12832 This also avoids a gcc -Wstrict-overflow warning.
12834 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12835 leading to a memory leak, possible in functions like
12836 load_charset_map_from_file that can allocate an unbounded number
12837 of objects (Bug#8318).
12839 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12840 that could (at least in theory) be that large.
12842 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12843 This is less likely to overflow, and avoids undefined behavior if
12844 overflow does occur. All callers changed. Use strtoul to scan
12845 for the unsigned long integer.
12846 (pint2hrstr): Simplify and tune code slightly.
12847 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12849 * scroll.c (do_scrolling): Work around GCC bug 48228.
12850 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12852 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12853 This also avoids a warning with gcc -Wstrict-overflow.
12854 (validate_x_resource_name): Simplify count usage.
12855 This also avoids a warning with gcc -Wstrict-overflow.
12857 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12860 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12862 * process.c (Fmake_network_process): Use socklen_t, not int,
12863 where POSIX says socklen_t is required in portable programs.
12864 This fixes a porting bug on hosts like 64-bit HP-UX, where
12865 socklen_t is wider than int (Bug#8277).
12866 (Fmake_network_process, server_accept_connection):
12867 (wait_reading_process_output, read_process_output):
12870 * process.c: Rename or move locals to avoid shadowing.
12871 (list_processes_1, Fmake_network_process):
12872 (read_process_output_error_handler, exec_sentinel_error_handler):
12873 Rename or move locals.
12874 (Fmake_network_process): Define label "retry_connect" only if needed.
12875 (Fnetwork_interface_info): Fix pointer signedness.
12876 (process_send_signal): Add cast to avoid pointer signedness problem.
12877 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12878 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12880 Make tparam.h and terminfo.c consistent.
12881 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12882 Include tparam.h instead, since it declares them.
12883 * cm.h (PC): Remove extern decl; tparam.h now does this.
12884 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12885 * terminfo.c: Include tparam.h, to check interfaces.
12886 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12887 (tparam): Adjust signature to match interface in tparam.h;
12888 this removes some undefined behavior. Check that outstring and len
12889 are zero, which they always are with Emacs.
12890 * tparam.h (PC, BC, UP): New extern decls.
12892 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12893 (xftfont_open): Rename locals to avoid shadowing.
12895 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12896 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12897 (OTF_TAG_SYM): Omit macro if not needed.
12898 (ftfont_list): Remove unused local.
12899 (get_adstyle_property, ftfont_pattern_entity):
12900 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12901 Rename locals to avoid shadowing.
12903 * xfont.c (xfont_list_family): Mark var as initialized.
12905 * xml.c (make_dom): Now static.
12907 * composite.c (composition_compute_stop_pos): Rename local to
12909 (composition_reseat_it): Remove unused locals.
12910 (find_automatic_composition, composition_adjust_point): Likewise.
12911 (composition_update_it): Mark var as initialized.
12912 (find_automatic_composition): Mark vars as initialized,
12913 with a FIXME (Bug#8290).
12915 character.h: Rename locals to avoid shadowing.
12916 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12917 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12918 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12919 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12920 to avoid shadowing.
12922 * textprop.c (property_change_between_p): Remove; unused.
12924 * intervals.c (interval_start_pos): Now static.
12926 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12928 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12929 Rename locals to avoid shadowing.
12931 * sound.c (wav_play, au_play, Fplay_sound_internal):
12932 Fix pointer signedness.
12933 (alsa_choose_format): Remove unused local var.
12934 (wav_play): Initialize a variable to 0, to prevent undefined
12935 behavior (Bug#8278).
12937 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12939 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12941 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12942 clobbering (Bug#8298).
12943 * sysdep.c (sys_subshell): Likewise.
12944 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12946 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12947 This should get cleaned up, so that child_setup has the
12948 same signature on all platforms.
12950 * callproc.c (call_process_cleanup): Now static.
12951 (relocate_fd): Rename locals to avoid shadowing.
12953 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12955 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12956 not to be necessary, and produces flickering.
12958 2011-03-20 Glenn Morris <rgm@gnu.org>
12960 * config.in: Remove file.
12962 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12964 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12965 are now in src/globals.h.
12966 (syms_of_minibuf): Remove spurious & from previous change.
12968 2011-03-20 Leo Liu <sdl.web@gmail.com>
12970 * minibuf.c (completing-read-function): New variable.
12971 (completing-read-default): Rename from completing-read.
12972 (completing-read): Call completing-read-function.
12974 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12976 * xfaces.c (Fx_load_color_file):
12977 Read color file from absolute filename (bug#8250).
12979 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12981 * makefile.w32-in: Update dependencies.
12983 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12985 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12987 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12989 Fix more problems found by GCC 4.5.2's static checks.
12991 * process.c (make_serial_process_unwind, send_process_trap):
12992 (sigchld_handler): Now static.
12994 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12995 That way, the code declares only the vars that it needs.
12996 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12997 * s/cygwin.h (PTY_ITERATION): Likewise.
12998 * s/darwin.h (PTY_ITERATION): Likewise.
12999 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13001 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13002 * process.c (allocate_pty): Don't declare stb unless it's needed.
13004 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13005 (CONSTANTLIM): Remove; unused.
13006 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13007 Define only if needed.
13009 * unexelf.c (unexec): Name an expression,
13010 to avoid gcc -Wbad-function-cast warning.
13011 Use a different way to cause a compilation error if anyone uses
13012 n rather than nn, a way that does not involve shadowing.
13013 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13015 * deps.mk (unexalpha.o): Remove; unused.
13017 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13018 * unexec.h: New file.
13019 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13020 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13021 Depend on unexec.h.
13022 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13023 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13024 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13025 Change as necessary to match prototype in unexec.h.
13027 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13029 (back_comment, skip_chars): Mark vars as initialized.
13031 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13032 Rename locals to avoid shadowing.
13034 * lread.c (read1): Rewrite so as not to use empty "else".
13035 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13037 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13039 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13040 warning when compiling print.c.
13042 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13043 instead of using an uninitialized var.
13044 (font_sort_entities): Mark var as initialized.
13046 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13048 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13049 pointers to constants.
13050 (font_parse_fcname): Remove unused vars.
13051 (font_delete_unmatched): Now static.
13052 (font_get_spec): Remove; unused.
13053 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13054 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13055 Rename or move locals to avoid shadowing.
13057 * fns.c (require_nesting_list, require_unwind): Now static.
13058 (Ffillarray): Rename locals to avoid shadowing.
13060 * floatfns.c (domain_error2): Define only if needed.
13061 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13063 * alloc.c (mark_backtrace): Move decl from here ...
13064 * lisp.h: ... to here, so that it can be checked.
13066 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13067 (Fdefvar): Rewrite so as not to use empty "else".
13068 (lisp_indirect_variable): Name an expression,
13069 to avoid gcc -Wbad-function-cast warning.
13070 (Fdefvar): Rename locals to avoid shadowing.
13072 * callint.c (quotify_arg, quotify_args): Now static.
13073 (Fcall_interactively): Rename locals to avoid shadowing.
13074 Use const pointer when appropriate.
13076 * lisp.h (get_system_name, get_operating_system_release):
13077 Move decls here, to check interfaces.
13078 * process.c (get_operating_system_release): Move decl to lisp.h.
13079 * xrdb.c (get_system_name): Likewise.
13080 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13081 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13082 some of which prompt warnings from gcc -Wbad-function-cast.
13083 (Fformat_time_string, Fencode_time, Finsert_char):
13084 (Ftranslate_region_internal, Fformat):
13085 Rename or remove local vars to avoid shadowing.
13086 (Ftranslate_region_internal): Mark var as initialized.
13088 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13091 * lisp.h (eassert): Check that the argument compiles, even if
13092 ENABLE_CHECKING is not defined.
13094 * data.c (Findirect_variable): Name an expression, to avoid
13095 gcc -Wbad-function-cast warning.
13096 (default_value, arithcompare, arith_driver, arith_error): Now static.
13097 (store_symval_forwarding): Rename local to avoid shadowing.
13098 (Fmake_variable_buffer_local, Fmake_local_variable):
13099 Mark variables as initialized.
13100 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13102 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13103 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13104 Rename locals to avoid shadowing.
13105 (mark_stack): Move local variables into the #ifdef region where
13107 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13108 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13110 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13111 (GC_STRING_CHARS): Remove; not used.
13112 (Fmemory_limit): Cast sbrk's returned value to char *.
13114 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13115 avoids undefined behavior in theory.
13117 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13119 Use functions, not macros, for up- and down-casing (Bug#8254).
13120 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13121 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13122 to use the following functions instead of these macros.
13123 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13124 EMACS_INT, since callers assume the returned value fits in int.
13125 (upcase1): Likewise, for UPCASE_TABLE.
13126 (uppercasep, lowercasep, upcase): New static inline functions.
13127 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13128 the race-condition problem in the old DOWNCASE.
13130 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13131 Rename locals to avoid shadowing.
13132 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13133 (regex_compile, re_search_2, re_match_2_internal):
13134 Remove unused local vars.
13135 (FREE_VAR): Rewrite so as not to use empty "else",
13136 which gcc can warn about.
13137 (regex_compile, re_match_2_internal): Mark locals as initialized.
13138 (RETALLOC_IF): Define only if needed.
13139 (WORDCHAR_P): Likewise. This one is never needed, but is used
13140 only in a comment talking about a compiler bug, so put inside
13141 the #if 0 of that comment.
13142 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13143 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13146 * search.c (boyer_moore): Rename locals to avoid shadowing.
13147 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13148 (PREV_CHAR_BOUNDARY): Likewise.
13150 * search.c (simple_search): Remove unused var.
13152 * dired.c (compile_pattern): Move decl from here ...
13153 * lisp.h: ... to here, so that it can be checked.
13154 (struct re_registers): New forward decl.
13156 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13158 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13160 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13161 Rename locals to avoid shadowing.
13162 (Fvertical_motion): Mark locals as initialized.
13164 * casefiddle.c (casify_object, casify_region): Now static.
13165 (casify_region): Mark local as initialized.
13167 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13169 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13170 New macros, so that the caller can use some names other than
13171 gcpro1, gcpro2, etc.
13172 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13174 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13175 argument, for consistency with GCPRO2_VAR, etc: it is now the
13176 prefix of the variable, not the variable itself. All uses
13178 * dired.c (directory_files_internal, file_name_completion):
13179 Rename locals to avoid shadowing.
13181 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13182 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13183 dired.c's scmp function, had undefined behavior.
13184 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13185 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13186 * buffer.h: ... to here, because these macros use current_buffer,
13187 and the new implementation with inline functions needs to have
13188 current_buffer in scope now, rather than later when the macros
13190 (downcase, upcase1): New static inline functions.
13191 (DOWNCASE, UPCASE1): Reimplement using these functions.
13192 This avoids undefined behavior in expressions like
13193 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13194 from race conditions in accessing the global variables
13195 case_temp1 and case_temp2.
13196 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13197 * lisp.h (case_temp1, case_temp2): Remove their decls.
13198 * character.h (ASCII_CHAR_P): Move from here ...
13199 * lisp.h: ... to here, so that the inline functions mentioned
13200 above can use them.
13202 * dired.c (directory_files_internal_unwind): Now static.
13204 * fileio.c (file_name_as_directory, directory_file_name):
13205 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13207 (file_name_as_directory): Use const pointers when appropriate.
13208 (Fexpand_file_name): Likewise. In particular, newdir might
13209 point at constant storage, so make it a const pointer.
13210 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13211 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13213 (Fset_file_times, Finsert_file_contents, auto_save_error):
13214 Rename locals to avoid shadowing.
13216 * minibuf.c (choose_minibuf_frame_1): Now static.
13217 (Ftry_completion, Fall_completions): Rename or remove locals
13218 to avoid shadowing.
13220 * marker.c (bytepos_to_charpos): Remove; unused.
13222 * lisp.h (verify_bytepos, count_markers): New decls,
13223 so that gcc does not warn that these functions aren't declared.
13225 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13226 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13227 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13228 (copy_text): Remove unused local var.
13230 * filelock.c (within_one_second): Now static.
13231 (lock_file_1): Rename local to avoid shadowing.
13233 * buffer.c (fix_overlays_before): Mark locals as initialized.
13234 (fix_start_end_in_overlays): Likewise. This function should be
13235 simplified by using pointers-to-pointers, but that's a different
13237 (switch_to_buffer_1): Now static.
13238 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13239 (report_overlay_modification): Rename locals to avoid shadowing.
13241 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13242 Fix pointer signedness issue.
13243 (sys_subshell): Mark local as volatile if checking for lint,
13244 to suppress a gcc -Wclobbered warning that does not seem to be right.
13245 (MAXPATHLEN): Define only if needed.
13247 * process.c (serial_open, serial_configure): Move decls from here ...
13248 * systty.h: ... to here, so that they can be checked.
13250 * fns.c (get_random, seed_random): Move extern decls from here ...
13251 * lisp.h: ... to here, so that they can be checked.
13253 * sysdep.c (reset_io): Now static.
13254 (wait_for_termination_signal): Remove; unused.
13256 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13257 (copy_keymap_item, append_key, push_text_char_description):
13259 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13260 (DENSE_TABLE_SIZE): Remove; unused.
13261 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13262 (describe_map_tree):
13263 Rename locals to avoid shadowing.
13265 * keyboard.c: Declare functions static if they are not used elsewhere.
13266 (echo_char, echo_dash, cmd_error, top_level_2):
13267 (poll_for_input, handle_async_input): Now static.
13268 (read_char, kbd_buffer_get_event, make_lispy_position):
13269 (make_lispy_event, make_lispy_movement, apply_modifiers):
13270 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13271 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13272 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13273 (read_key_sequence, read_char): Mark locals as initialized.
13274 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13276 * keyboard.h (make_ctrl_char): New decl.
13277 (mark_kboards): Move decl here ...
13278 * alloc.c (mark_kboards): ... from here.
13280 * lisp.h (force_auto_save_soon): New decl.
13282 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13283 (DEFINE_DUMMY_FUNCTION): New macro.
13284 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13286 (main): Add casts to avoid warnings
13287 if GCC considers string literals to be constants.
13289 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13291 * dbusbind.c: Pointer signedness fixes.
13292 (xd_signature, xd_append_arg, xd_initialize):
13293 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13294 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13295 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13296 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13298 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13299 if GCC considers string literals to be constants.
13300 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13302 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13304 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13305 (print_preprocess, print_object): New macro to fix last change.
13307 * print.c (print_preprocess): Don't forget font objects.
13309 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13311 * emacs.c (USAGE3): Doc fixes.
13313 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13315 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13318 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13320 * lisp.h (VWindow_system, Qfile_name_history):
13321 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13322 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13323 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13325 * w32select.c: Don't #include "keyboard.h".
13326 (run_protected): Add extern declaration for waiting_for_input.
13328 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13329 * w32console.c (detect_input_pending, read_input_pending)
13330 (encode_terminal_code):
13331 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13332 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13333 (w32_system_caret_y, Qfile_name_history):
13334 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13335 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13336 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13337 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13338 * w32proc.c (Qlocal, report_file_error):
13339 * w32term.c (Vwindow_system, updating_frame):
13340 * w32uniscribe.c (initialized, uniscribe_font_driver):
13341 Remove unneeded extern declarations.
13343 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13345 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13347 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13349 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13350 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13351 These macros can no longer be used for assignment.
13353 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13354 Assign struct members directly, instead of using BUF_BEGV etc.
13355 (record_buffer_markers, fetch_buffer_markers): New functions for
13356 recording and fetching special buffer markers.
13357 (set_buffer_internal_1, set_buffer_temp): Use them.
13359 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13361 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13363 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13364 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13366 * xdisp.c (hscroll_window_tree):
13367 (reconsider_clip_changes): Use PT instead of BUF_PT.
13369 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13371 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13372 $(EMACS_ROOT)/lib/intprops.h.
13374 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13376 Fix more problems found by GCC 4.5.2's static checks.
13378 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13379 to unsigned char * to avoid compiler diagnostic.
13380 (xg_free_frame_widgets): Make it clear that a local variable is
13381 needed only if USE_GTK_TOOLTIP.
13382 (gdk_window_get_screen): Make it clear that this macro is needed
13383 only if USE_GTK_TOOLTIP.
13384 (int_gtk_range_get_value): New function, which avoids a diagnostic
13385 from gcc -Wbad-function-cast.
13386 (xg_set_toolkit_scroll_bar_thumb): Use it.
13387 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13388 diagnostic from gcc -Wbad-function-cast.
13389 (get_utf8_string, xg_get_file_with_chooser):
13390 Rename locals to avoid shadowing.
13391 (create_dialog): Move locals to avoid shadowing.
13393 * xgselect.c (xg_select): Remove unused var.
13395 * image.c (four_corners_best): Mark locals as initialized.
13396 (gif_load): Initialize transparent_p to zero (Bug#8238).
13397 Mark another local as initialized.
13398 (my_png_error, my_error_exit): Mark with NO_RETURN.
13400 * image.c (clear_image_cache): Now static.
13401 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13402 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13403 (x_edge_detection): Remove unnecessary cast that
13404 gcc -Wbad-function-cast diagnoses.
13405 (gif_load): Fix pointer signedness.
13406 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13407 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13409 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13411 Improve quality of tests for time stamp overflow.
13412 For example, without this patch (encode-time 0 0 0 1 1
13413 1152921504606846976) returns the obviously-bogus value (-948597
13414 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13415 reports time overflow. See
13416 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13417 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13418 * editfns.c: Include limits.h and intprops.h.
13419 (TIME_T_MIN, TIME_T_MAX): New macros.
13420 (time_overflow): Move earlier, to before first use.
13421 (hi_time, lo_time): New functions, for an accurate test for
13422 out-of-range times.
13423 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13424 (Fget_internal_run_time): Don't assume time_t fits in int.
13425 (make_time): Use list2 instead of Fcons twice.
13426 (Fdecode_time): More accurate test for out-of-range times.
13427 (check_tm_member): New function.
13428 (Fencode_time): Use it, to test for out-of-range times.
13429 (lisp_time_argument): Don't rely on undefined left-shift and
13430 right-shift behavior when checking for time stamp overflow.
13432 * editfns.c (time_overflow): New function, refactoring common code.
13433 (Fformat_time_string, Fdecode_time, Fencode_time):
13434 (Fcurrent_time_string): Use it.
13436 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13437 * dired.c (make_time): Move to ...
13438 * editfns.c (make_time): ... here.
13439 * systime.h: Note the move.
13441 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13443 * fringe.c (update_window_fringes): Remove unused variables.
13445 * unexmacosx.c (copy_data_segment): Also copy __got section.
13448 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13450 * termcap.c [MSDOS]: Include "msdos.h".
13451 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13452 Constify `char *' arguments and their references according to
13453 prototypes in tparam.h.
13455 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13457 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13458 Adapt all references accordingly.
13460 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13462 2011-03-11 Tom Tromey <tromey@redhat.com>
13464 * buffer.c (syms_of_buffer): Remove obsolete comment.
13466 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13468 * termhooks.h (encode_terminal_code): Declare prototype.
13470 * msdos.c (encode_terminal_code): Don't declare prototype.
13472 * term.c (encode_terminal_code): Now external again, used by
13473 w32console.c and msdos.c.
13475 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13476 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13478 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13480 Fix some minor problems found by GCC 4.5.2's static checks.
13482 * fringe.c (update_window_fringes): Mark locals as initialized
13484 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13486 * alloc.c (mark_fringe_data): Move decl from here ...
13487 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13488 to check its interface.
13489 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13491 * fontset.c (free_realized_fontset): Now static.
13492 (Fset_fontset_font): Rename local to avoid shadowing.
13493 (fontset_font): Mark local as initialized.
13494 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13496 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13498 * xselect.c (x_disown_buffer_selections): Remove; not used.
13499 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13500 (x_own_selection, Fx_disown_selection_internal): Rename locals
13501 to avoid shadowing.
13502 (x_handle_dnd_message): Remove local to avoid shadowing.
13504 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13505 so that the caller can use some name other than gcpro1.
13506 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13507 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13508 (Fx_backspace_delete_keys_p):
13509 Use them to avoid shadowing, and rename vars to avoid shadowing.
13510 (x_decode_color, x_set_name, x_window): Now static.
13511 (Fx_create_frame): Add braces to silence GCC warning.
13512 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13513 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13514 Remove unused locals.
13515 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13516 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13517 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13520 * xterm.h (x_mouse_leave): New decl.
13522 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13523 Remove unused functions.
13524 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13525 (x_calc_absolute_position): Now static.
13526 (XTread_socket): Don't define label "out" unless it's used.
13527 Don't declare local "event" unless it's used.
13528 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13529 unless they are used.
13530 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13531 (x_fatal_error_signal): Remove; not used.
13532 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13533 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13534 (x_error_catcher, x_connection_closed, x_error_handler):
13535 (x_error_quitter, xembed_send_message, x_iconify_frame):
13536 (my_log_handler): Rename locals to avoid shadowing.
13537 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13538 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13540 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13541 Rename or move locals to avoid shadowing.
13542 (tty_defined_color, merge_face_heights): Now static.
13543 (free_realized_faces_for_fontset): Remove; not used.
13544 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13545 does not deduce is never used uninitialized.
13546 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13547 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13549 * terminal.c (store_terminal_param): Now static.
13551 * xmenu.c (menu_highlight_callback): Now static.
13552 (set_frame_menubar): Remove unused local.
13553 (xmenu_show): Rename parameter to avoid shadowing.
13554 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13555 since they might point to immutable storage.
13556 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13557 since it's unused otherwise.
13559 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13560 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13561 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13562 avoids a gcc -Wuninitialized diagnostic.
13563 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13564 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13565 does not deduce are never used uninitialized.
13567 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13569 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13570 * window.c (window_loop, size_window):
13571 (run_window_configuration_change_hook, enlarge_window): Likewise.
13573 * window.c (display_buffer): Now static.
13574 (size_window): Mark variables that gcc -Wuninitialized
13575 does not deduce are never used uninitialized.
13576 * window.h (check_all_windows): New decl, to forestall
13577 gcc -Wmissing-prototypes diagnostic.
13578 * dispextern.h (bidi_dump_cached_states): Likewise.
13580 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13582 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13583 Include <limits.h>.
13584 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13585 and to avoid gcc -Wuninitialized warning.
13586 (load_charset_map): Mark variables that gcc -Wuninitialized
13587 does not deduce are never used uninitialized.
13588 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13590 * coding.c (coding_set_source, coding_set_destination):
13591 Use "else { /* comment */ }" rather than "else /* comment */;"
13592 for clarity, and to avoid gcc -Wempty-body warning.
13593 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13594 a block, when the outer 'i' will do.
13595 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13596 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13597 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13598 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13599 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13600 Rename locals to avoid shadowing.
13601 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13602 * coding.c (emacs_mule_char, encode_invocation_designation):
13603 Now static, since they're not used elsewhere.
13604 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13605 (decode_coding_object, encode_coding_object, detect_coding_system):
13606 (decode_coding_emacs_mule): Mark variables that gcc
13607 -Wuninitialized does not deduce are never used uninitialized.
13608 (detect_coding_iso_2022): Initialize a local variable that might
13609 be used uninitialized. Leave a FIXME because it's not clear that
13610 this initialization is needed. (Bug#8211)
13611 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13612 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13613 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13614 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13615 Remove unused macros.
13617 * category.c (hash_get_category_set): Remove unused local var.
13618 (copy_category_table): Now static, since it's not used elsewhere.
13619 * character.c (string_count_byte8): Likewise.
13621 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13622 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13624 * chartab.c (copy_sub_char_table): Now static, since it's not used
13626 (sub_char_table_ref_and_range, char_table_ref_and_range):
13627 Rename locals to avoid shadowing.
13628 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13630 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13631 (BIDI_BOB): Remove unused macro.
13633 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13634 deduce are never used uninitialized.
13635 * term.c (encode_terminal_code): Likewise.
13637 * term.c (encode_terminal_code): Now static. Remove unused local.
13639 * tparam.h: New file.
13640 * term.c, tparam.h: Include it.
13641 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13642 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13643 Move these decls to tparam.h, and make them agree with what
13644 is actually in tparam.c. The previous trick of using incompatible
13645 decls in different modules does not conform to the C standard.
13646 All callers of tparam changed to use tparam's actual API.
13647 * tparam.c (tparam1, tparam, tgoto):
13648 Use const pointers where appropriate.
13650 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13651 * cm.h (struct cm): Likewise.
13652 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13653 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13654 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13655 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13656 (turn_on_face, init_tty): Likewise.
13657 * termchar.h (struct tty_display_info): Likewise.
13659 * term.c (term_mouse_position): Rename local to avoid shadowing.
13661 * alloc.c (mark_ttys): Move decl from here ...
13662 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13664 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13666 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13668 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13670 * search.c (compile_pattern_1): Remove argument regp, unused since
13671 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13672 (compile_pattern): Don't pass it.
13674 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13676 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13677 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13679 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13681 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13683 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13684 gdk_window_get_screen, gdk_window_get_geometry,
13685 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13686 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13687 (xg_get_pixbuf_from_pixmap): New function.
13688 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13689 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13690 Call xg_get_pixbuf_from_pixmap instead of
13691 gdk_pixbuf_get_from_drawable.
13692 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13693 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13694 (xg_check_special_colors): Use GtkStyleContext and its functions
13696 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13697 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13698 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13699 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13700 Call gtk_widget_get_preferred_size.
13701 (xg_frame_resized): gdk_window_get_geometry only takes 5
13703 (xg_win_to_widget, xg_event_is_for_menubar):
13704 Call gdk_x11_window_lookup_for_display.
13705 (xg_set_widget_bg): New function.
13706 (delete_cb): New function.
13707 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13708 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13709 (xg_set_background_color): Call xg_set_widget_bg.
13710 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13711 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13712 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13713 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13715 (update_frame_tool_bar): Call gtk_widget_hide.
13716 (xg_initialize): Use GDK_KEY_g.
13718 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13720 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13722 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13723 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13724 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13726 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13728 * w32xfns.c (select_palette): Check success of RealizePalette against
13729 GDI_ERROR, not zero.
13731 See ChangeLog.11 for earlier changes.
13733 ;; Local Variables:
13737 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13739 This file is part of GNU Emacs.
13741 GNU Emacs is free software: you can redistribute it and/or modify
13742 it under the terms of the GNU General Public License as published by
13743 the Free Software Foundation, either version 3 of the License, or
13744 (at your option) any later version.
13746 GNU Emacs is distributed in the hope that it will be useful,
13747 but WITHOUT ANY WARRANTY; without even the implied warranty of
13748 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13749 GNU General Public License for more details.
13751 You should have received a copy of the GNU General Public License
13752 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
HCoop / bpt / emacs.git / blob