Fix current-bidi-paragraph-direction and its doc.
[bpt/emacs.git] / src / ChangeLog
1 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4 buffers, return left-to-right.
5
6 * bidi.c (bidi_check_type): Use xassert.
7 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8 members.
9
10 2011-08-23 Eli Zaretskii <eliz@gnu.org>
11
12 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
13 a character.
14
15 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
16
17 * nsfont.m (ns_otf_to_script): Fix typo.
18
19 2011-08-22 Kenichi Handa <handa@m17n.org>
20
21 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
22 extra slot even if the purpose is char-code-property-table.
23
24 2011-08-23 Eli Zaretskii <eliz@gnu.org>
25
26 * xdisp.c (redisplay_window): When computing centering_position,
27 account for the height of the header line. (Bug#8874)
28
29 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
30 instead of CHAR_TO_BYTE. Fixes a crash when a completion
31 candidate is selected by the mouse, and that candidate has a
32 composed character under the mouse.
33
34 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
35 coordinates reported by pos-visible-in-window-p for a composed
36 character in column zero.
37
38 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
39
40 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
41
42 2011-08-22 Eli Zaretskii <eliz@gnu.org>
43
44 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
45 consider it a hit if to_charpos is anywhere in the range of the
46 composed buffer positions.
47
48 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
49
50 * image.c (gif_load): Don't assume that each subimage has the same
51 dimensions as the base image. Handle disposal method that is
52 "undefined" by the gif spec (Bug#9335).
53
54 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
55
56 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
57 (Fcondition_case): Document `debug' symbol in error handler.
58
59 2011-08-19 Eli Zaretskii <eliz@gnu.org>
60
61 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
62 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
63 from an Org mode buffer to a Speedbar frame.
64
65 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
66 a composition, take its buffer position from IT->cmp_it.charpos.
67 Fixes cursor positioning at the beginning of a line that begins
68 with a composed character.
69
70 2011-08-18 Eli Zaretskii <eliz@gnu.org>
71
72 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
73 character bidirectional type, use STRONG_L instead. Fixes crashes
74 in a buffer produced by `describe-categories'.
75
76 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
77 members before the level stack, so they would be saved and
78 restored when copying iterator state. Fixes incorrect reordering
79 around TABs covered by display properties.
80
81 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
82
83 * process.c (Fnetwork_interface_list): Correctly determine buffer
84 size.
85
86 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
87
88 * eval.c (internal_condition_case, internal_condition_case_1)
89 (internal_condition_case_2, internal_condition_case_n):
90 Remove unnecessary aborts (Bug#9081).
91
92 2011-08-17 Eli Zaretskii <eliz@gnu.org>
93
94 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
95 has no `load' handler, try opening the file locally. (Bug#9311)
96
97 2011-08-16 Ken Brown <kbrown@cornell.edu>
98
99 * gmalloc.c: Expand comment.
100
101 2011-08-16 Eli Zaretskii <eliz@gnu.org>
102
103 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
104 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
105
106 2011-08-16 Ken Brown <kbrown@cornell.edu>
107
108 Fix memory allocation problems in Cygwin build (Bug#9273).
109
110 * unexcw.c ( __malloc_initialized): Declare external variable.
111 (fixup_executable): Force the dumped emacs to reinitialize malloc.
112
113 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
114 New variables.
115 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
116 dumped emacs.
117 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
118 in the static heap.
119 [CYGWIN] (special_realloc): New function.
120 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
121 requests to realloc storage in the static heap.
122
123 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
124
125 * bidi.c (bidi_initialize): Remove unused local.
126
127 2011-08-15 Eli Zaretskii <eliz@gnu.org>
128
129 * biditype.h: File removed.
130
131 * bidimirror.h: File removed.
132
133 * deps.mk (bidi.o): Remove biditype.h and
134 bidimirror.h.
135
136 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
137 bidimirror.h.
138
139 * dispextern.h: Fix a typo in the comment to bidi_type_t.
140
141 * chartab.c: Improve commentary for the uniprop_table API.
142
143 * bidi.c (bidi_paragraph_init): Support zero value of
144 bidi_ignore_explicit_marks_for_paragraph_level.
145 (bidi_initialize): Use uniprop_table instead of including
146 biditype.h and bidimirror.h.
147
148 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
149 coordinates of the iterator when restoring from ppos_it.
150 (Bug#9296)
151
152 2011-08-14 Kenichi Handa <handa@m17n.org>
153
154 * process.c (create_process): Call setup_process_coding_systems
155 after the pid of the process is set to -1 (Bug#8162).
156
157 2011-08-14 Eli Zaretskii <eliz@gnu.org>
158
159 * xdisp.c (move_it_in_display_line_to): Don't invoke
160 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
161 ppos_it. Fixes vertical cursor motion when line beginning is
162 covered by an image. (Bug#9296)
163
164 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
165
166 * nsterm.h (ns_run_ascript): Declare.
167 (NSAPP_DATA2_RUNASSCRIPT): Define.
168
169 * nsfns.m (as_script, as_result, as_status): New static variables.
170 (ns_run_ascript): New function.
171 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
172 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
173 the event loop. Get status from as_status (Bug#7276).
174
175 * nsterm.m (sendEvent): If event is NSApplicationDefined and
176 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
177 the event loop (Bug#7276).
178
179 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
180
181 * gnutls.c (QCgnutls_bootprop_priority)
182 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
183 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
184 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
185 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
186 (QCgnutls_bootprop_verify_hostname_error)
187 (QCgnutls_bootprop_callbacks_verify): Rename from
188 Qgnutls_bootprop_..., all uses changed.
189
190 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
191 uses changed.
192
193 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
194
195 * xfaces.c (Qframe_set_background_mode): Now static.
196 * dispextern.h (Qframe_set_background_mode): Remove decl.
197
198 * process.c (Fnetwork_interface_info): Declare local only if needed.
199
200 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
201
202 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
203 (Fnetwork_interface_list): Allocate in increments of bytes instead
204 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
205 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
206 sockaddr.
207 (struct ifflag_def): notrailers is smart on OSX.
208 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
209 Get hardware address with getifaddrs if available.
210
211 2011-08-12 Eli Zaretskii <eliz@gnu.org>
212
213 * xdisp.c (iterate_out_of_display_property): xassert that
214 IT->position is set to within IT->object's boundaries. Break from
215 the loop as soon as EOB is reached; avoids infloops in redisplay
216 when IT->position is set up wrongly due to some bug.
217 Set IT->current to match the bidi iterator unconditionally.
218 (push_display_prop): Allow GET_FROM_STRING as IT->method on
219 entry. Force push_it to save on the stack the current
220 buffer/string position, to be restored by pop_it. Fix flags in
221 the iterator structure wrt the object coming from a display
222 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
223 properties. (Bug#9284)
224
225 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
226
227 * fontset.c (fontset_get_font_group): Add proper type checks.
228 (Bug#9172)
229
230 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
231
232 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
233 and LC_VERSION_MIN_MACOSX.
234 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
235 (dump_it) [LC_FUNCTION_STARTS]: Use it.
236
237 2011-08-08 Eli Zaretskii <eliz@gnu.org>
238
239 * xdisp.c (forward_to_next_line_start): Allow to use the
240 no-display-properties-and-no-overlays under bidi display.
241 Set disp_pos in the bidi iterator to avoid searches for display
242 properties and overlays.
243
244 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
245
246 * editfns.c (Fset_time_zone_rule): Document relationship with the
247 setenv function.
248
249 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
250 the font entity extracted from the cache (Bug#8109).
251
252 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
253
254 * composite.c (autocmp_chars): Don't reset point. That is done by
255 restore_point_unwind (Bug#5984).
256
257 2011-08-07 Juri Linkov <juri@jurta.org>
258
259 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
260 to show the arg `TIME' instead of `TIMEVAL'.
261
262 2011-08-06 Eli Zaretskii <eliz@gnu.org>
263
264 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
265 display property strides EOL and includes a newline, as in
266 longlines-mode. (Bug#9254)
267 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
268 word-wrap under bidirectional display. (Bug#9224)
269
270 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
271 is non-zero, even if the data buffer is NULL. Fixes a crash in
272 vertical-motion with longlines-mode. (Bug#9254)
273
274 2011-08-05 Eli Zaretskii <eliz@gnu.org>
275
276 * bidi.c <bidi_cache_total_alloc>: Now static.
277 (bidi_initialize): Initialize bidi_cache_total_alloc.
278
279 * xdisp.c (display_line): Release buffer allocated for shelved bidi
280 cache. (Bug#9221)
281
282 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
283 amount allocated this far in `bidi_cache_total_alloc'.
284 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
285 non-zero, only free the data buffer without restoring the cache
286 contents. All callers changed.
287
288 * dispextern.h (bidi_unshelve_cache): Update prototype.
289
290 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
291 (move_it_in_display_line, move_it_to)
292 (move_it_vertically_backward, move_it_by_lines): Replace the call
293 to xfree to an equivalent call to bidi_unshelve_cache.
294 (move_it_in_display_line_to): Fix logic of returning
295 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
296
297 2011-08-05 Eli Zaretskii <eliz@gnu.org>
298
299 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
300 came from a string character with a `cursor' property. (Bug#9229)
301
302 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
303
304 * Makefile.in (LIB_PTHREAD): New variable.
305 (LIBES): Add LIB_PTHREAD (Bug#9216).
306
307 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
308 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
309
310 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
311
312 * regex.c (re_iswctype): Remove some redundant boolean
313 conversions.
314
315 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
316
317 * xterm.c (x_find_topmost_parent): New function.
318 (x_set_frame_alpha): Find topmost parent window with
319 x_find_topmost_parent and set the property there also (bug#9181).
320 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
321
322 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
323
324 * callproc.c (Fcall_process): Avoid vfork clobbering
325 the local vars buffer, coding_systems, current_dir.
326
327 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
328
329 * keymap.c (Fmake_composed_keymap): Move to subr.el.
330
331 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
332
333 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
334 so that it is not optimized away.
335
336 * xdisp.c (compute_display_string_pos): Remove unused local.
337
338 2011-08-02 Eli Zaretskii <eliz@gnu.org>
339
340 Fix slow cursor motion and scrolling in large buffers with
341 selective display, like Org Mode buffers. (Bug#9218)
342
343 * dispextern.h (struct bidi_it): New member disp_prop_p.
344
345 * xdisp.c: Remove one-slot cache of display string positions.
346 (compute_display_string_pos): Accept an additional argument
347 DISP_PROP_P; callers changed. Scan at most 5K characters forward
348 for a display string or property. If found, set DISP_PROP_P
349 non-zero.
350
351 * bidi.c (bidi_fetch_char): Accept an additional argument
352 DISP_PROP_P, and pass it to compute_display_string_pos.
353 Only handle text covered by a display string if DISP_PROP_P is returned
354 non-zero. All callers of bidi_fetch_char changed.
355
356 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
357
358 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
359
360 2010-12-03 Don March <don@ohspite.net>
361
362 * keymap.c (Fdefine_key): Fix non-prefix key error message when
363 last character M-[char] is translated to ESC [char] (bug#7541).
364
365 2011-08-02 Kenichi Handa <handa@m17n.org>
366
367 * lisp.h (uniprop_table): Extern it.
368
369 * chartab.c (uniprop_table): Make it non-static.
370
371 2011-08-01 Eli Zaretskii <eliz@gnu.org>
372
373 * xdisp.c (forward_to_next_line_start): Accept additional argument
374 BIDI_IT_PREV, and store into it the state of the bidi iterator had
375 on the newline.
376 (reseat_at_next_visible_line_start): Use the bidi iterator state
377 returned by forward_to_next_line_start to restore the state of
378 it->bidi_it after backing up to previous newline. (Bug#9212)
379
380 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
381
382 * regex.c (re_comp): Protoize.
383 (re_exec): Fix return type.
384 (regexec): Fix type of `ret'. (Bug#9203)
385
386 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
387
388 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
389 This is needed if max-image-size is a floating-point number.
390
391 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
392
393 * print.c (print_object): Print empty symbol as ##.
394
395 * lread.c (read1): Read ## as empty symbol.
396
397 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
398
399 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
400 setting frame foreground color (Bug#9175).
401 (x_set_background_color): Likewise.
402
403 * nsmenu.m (-setText): Size tooltip dimensions precisely to
404 contents (Bug#9176).
405 (EmacsTooltip -init): Remove bezels and add shadows to
406 tooltip windows.
407
408 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
409 or scroll bar (Bug#8470).
410
411 * nsfont.m (nsfont_open): Remove assignment to voffset and
412 unnecessary vars hshink, expand, hd, full_height, min_height.
413 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
414
415 * nsterm.h (nsfont_info): Remove voffset field.
416
417 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
418
419 Implement strike-through and overline on NextStep (Bug#8863).
420
421 * nsfont.m (nsfont_open): Use underline position provided by font,
422 instead of hard-coded value of 2.
423 (nsfont_draw): Call ns_draw_text_decoration instead.
424
425 * nsterm.h: Add declaration for ns_draw_text_decoration.
426
427 * nsterm.m (ns_draw_text_decoration): New function for drawing
428 underline, overline, and strike-through.
429 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
430 ns_draw_text_decoration. Change treatment of cursor drawing to
431 accomodate underlining, etc.
432
433 2011-07-28 Eli Zaretskii <eliz@gnu.org>
434
435 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
436 default.
437
438 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
439
440 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
441 Without this fix, if a signal arrives just after memory fills up,
442 'malloc' might be invoked reentrantly.
443
444 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
445 In other words, assume that every image size is allowed, on non-X
446 hosts. This assumption is probably wrong, but it lets Emacs compile.
447
448 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
449
450 * regex.c (re_iswctype): Convert return values to boolean.
451
452 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
453
454 * xdisp.c (compute_display_string_pos): Don't use cached display
455 string position if the buffer had its restriction changed.
456 (Bug#9184)
457
458 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
459
460 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
461
462 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
463
464 Integer signedness and overflow and related fixes. (Bug#9079)
465
466 * bidi.c: Integer size and overflow fixes.
467 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
468 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
469 (bidi_cache_find_level_change, bidi_cache_ensure_space)
470 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
471 (bidi_find_other_level_edge):
472 Use ptrdiff_t instead of EMACS_INT where either will do.
473 This works better on 32-bit hosts configured --with-wide-int.
474 (bidi_cache_ensure_space): Check for size-calculation overflow.
475 Use % rather than repeated addition, for better worst-case speed.
476 Don't set bidi_cache_size until after xrealloc returns, because it
477 might not return.
478 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
479 (bidi_cache_ensure_space): Also check that the bidi cache size
480 does not exceed that of the largest Lisp string or buffer. See Eli
481 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
482
483 * alloc.c (__malloc_size_t): Remove.
484 All uses replaced by size_t. See Andreas Schwab's note
485 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
486
487 * image.c: Improve checking for integer overflow.
488 (check_image_size): Assume that f is nonnull, since
489 it is always nonnull in practice. This is one less thing to
490 worry about when checking for integer overflow later.
491 (x_check_image_size): New function, which checks for integer
492 overflow issues inside X.
493 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
494 This removes the need for a memory_full check.
495 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
496 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
497 (xbm_read_bitmap_data): Change locals back to 'int', since
498 their values must fit in 'int'.
499 (xpm_load_image, png_load, tiff_load):
500 Invoke x_create_x_image_and_pixmap earlier,
501 to avoid much needless work if the image is too large.
502 (tiff_load): Treat overly large images as if
503 x_create_x_image_and_pixmap failed, not as malloc failures.
504 (gs_load): Use x_check_image_size.
505
506 * gtkutil.c: Omit integer casts.
507 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
508 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
509
510 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
511
512 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
513 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
514 would wrongly return t on a 64-bit host.
515
516 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
517 The plain *_OVERFLOW macros run afoul of GCC bug 49705
518 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
519 and therefore cause GCC to emit a bogus diagnostic in some cases.
520
521 * image.c: Integer signedness and overflow and related fixes.
522 This is not an exhaustive set of fixes, but it's time to
523 record what I've got.
524 (lookup_pixel_color, check_image_size): Remove redundant decls.
525 (check_image_size): Don't assume that arbitrary EMACS_INT values
526 fit in 'int', or that arbitrary 'double' values fit in 'int'.
527 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
528 (tiff_load, imagemagick_load_image):
529 Check for overflow in size calculations.
530 (x_create_x_image_and_pixmap): Remove unnecessary test for
531 xmalloc returning NULL; that can't happen.
532 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
533 (xpm_color_bucket): Use better integer hashing function.
534 (xpm_cache_color): Don't possibly over-allocate memory.
535 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
536 (gif_memory_source):
537 Use ptrdiff_t, not int or size_t, to record sizes.
538 (png_load): Don't assume values greater than 2**31 fit in 'int'.
539 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
540 either works, as we prefer signed integers.
541 (tiff_read_from_memory, tiff_write_from_memory):
542 Return tsize_t, not size_t, since that's what the TIFF API wants.
543 (tiff_read_from_memory): Don't fail simply because the read would
544 go past EOF; instead, return a short read.
545 (tiff_load): Omit no-longer-needed casts.
546 (Fimagemagick_types): Don't assume size fits into 'int'.
547
548 Improve hashing quality when configured --with-wide-int.
549 * fns.c (hash_string): New function, taken from sxhash_string.
550 Do not discard information about ASCII character case; this
551 discarding is no longer needed.
552 (sxhash-string): Use it. Change sig to match it. Caller changed.
553 * lisp.h: Declare it.
554 * lread.c (hash_string): Remove, since we now use fns.c's version.
555 The fns.c version returns a wider integer if --with-wide-int is
556 specified, so this should help the quality of the hashing a bit.
557
558 * emacs.c: Integer overflow minor fix.
559 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
560 Define only if GNU_LINUX.
561 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
562
563 * dispnew.c: Integer signedness and overflow fixes.
564 Remove unnecessary forward decls, that were a maintenance hassle.
565 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
566 All uses changed.
567 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
568 (scrolling_window): Use ptrdiff_t, not int, for byte count.
569 (prepare_desired_row, line_draw_cost):
570 Use int, not unsigned, where either works.
571 (save_current_matrix, restore_current_matrix):
572 Use ptrdiff_t, not size_t, where either works.
573 (init_display): Check for overflow more accurately, and without
574 relying on undefined behavior.
575
576 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
577 Remove, replacing with the new symbols in lisp.h. All uses changed.
578 * fileio.c (make_temp_name):
579 * filelock.c (lock_file_1, lock_file):
580 * xdisp.c (message_dolog):
581 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
582 Use pMd etc. instead.
583 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
584 replacing the pWIDE etc. symbols removed from editfns.c.
585
586 * keyboard.h (num_input_events): Now uintmax_t.
587 This is (very slightly) less likely to mess up due to wraparound.
588 All uses changed.
589
590 * buffer.c: Integer signedness fixes.
591 (alloc_buffer_text, enlarge_buffer_text):
592 Use ptrdiff_t rather than size_t when either will do, as we prefer
593 signed integers.
594
595 * alloc.c: Integer signedness and overflow fixes.
596 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
597 (__malloc_size_t): Default to size_t, not to int.
598 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
599 (Fgarbage_collect, mark_object_loop_halt, mark_object):
600 Prefer ptrdiff_t to size_t when either would do, as we prefer
601 signed integers.
602 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
603 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
604 Now const. Initialize with values that are in range even if char
605 is signed.
606 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
607 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
608 These functions do the right thing with sizes > 2**32.
609 (check_depth): Now ptrdiff_t, not int.
610 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
611 Adjust to new way of storing sizes. Check for size overflow bugs
612 in rest of code.
613 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
614 slightly wrong anyway, as it missed one instance of
615 XMALLOC_OVERRUN_CHECK_OVERHEAD.
616 (refill_memory_reserve): Omit needless cast to size_t.
617 (mark_object_loop_halt): Mark as externally visible.
618
619 * xselect.c: Integer signedness and overflow fixes.
620 (Fx_register_dnd_atom, x_handle_dnd_message):
621 Use ptrdiff_t, not size_t, since we prefer signed.
622 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
623 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
624 x_dnd_atoms_size and x_dnd_atoms_length.
625
626 * doprnt.c: Prefer signed to unsigned when either works.
627 * eval.c (verror):
628 * doprnt.c (doprnt):
629 * lisp.h (doprnt):
630 * xdisp.c (vmessage):
631 Use ptrdiff_t, not size_t, when using or implementing doprnt,
632 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
633 prefer signed arithmetic to avoid comparison confusion.
634 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
635 but is a bit tricky.
636
637 Assume freestanding C89 headers, string.h, stdlib.h.
638 * data.c, doprnt.c, floatfns.c, print.c:
639 Include float.h unconditionally.
640 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
641 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
642 * regex.c: Likewise for stddef.h, string.h.
643 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
644 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
645 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
646 (STDC_HEADERS): Remove obsolete defines.
647 * sysdep.c: Include limits.h unconditionally.
648
649 Assume support for memcmp, memcpy, memmove, memset.
650 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
651 * regex.c (memcmp, memcpy):
652 Remove; we assume C89 now.
653
654 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
655 (__malloc_safe_bcopy): Remove; no longer needed.
656
657 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
658 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
659 well either way, and we prefer signed to unsigned.
660
661 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
662
663 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
664 closes the connection while we're reading (bug#9182).
665
666 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
667
668 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
669 are specified (Bug#9168).
670
671 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
672
673 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
674 Found by GCC static checking and --with-wide-int on a 32-bit host.
675
676 2011-07-25 Eli Zaretskii <eliz@gnu.org>
677
678 * xdisp.c (compute_display_string_pos): Fix logic of caching
679 previous display string position. Initialize cached_prev_pos to
680 -1. Fixes slow-down at the beginning of a buffer.
681
682 2011-07-24 Eli Zaretskii <eliz@gnu.org>
683
684 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
685 for attrs[LFACE_FONTSET_INDEX].
686
687 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
688
689 * xml.c (parse_region): Remove unused local
690 that was recently introduced.
691
692 2011-07-23 Eli Zaretskii <eliz@gnu.org>
693
694 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
695 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
696
697 * xdisp.c (move_it_in_display_line_to): Record the best matching
698 position for TO_CHARPOS while scanning the line, and restore it on
699 exit if none of the characters scanned was an exact match.
700 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
701 when exact match is impossible due to invisible text, and the
702 lines are truncated.
703
704 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
705
706 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
707 for OSX >= 10.7.
708
709 2011-07-22 Eli Zaretskii <eliz@gnu.org>
710
711 Fix a significant slow-down of cursor motion with C-n, C-p,
712 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
713 auto-repeat under bidi redisplay in fontified buffers.
714 * xdisp.c (compute_stop_pos_backwards): New function.
715 (next_element_from_buffer): Call compute_stop_pos_backwards to
716 find a suitable prev_stop when we find ourselves before
717 base_level_stop.
718 (reseat): Don't look for prev_stop, as that could mean a very long
719 run.
720 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
721 <cached_disp_overlay_modiff>: Cache for last found display string
722 position.
723 (compute_display_string_pos): Return the cached position if asked
724 about the same buffer in the same area of character positions, and
725 the buffer wasn't changed since the time the display string
726 position was cached.
727
728 2011-07-22 Eli Zaretskii <eliz@gnu.org>
729
730 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
731 is an integer, which is important for empty lines. (Bug#9149)
732
733 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
734
735 * frame.c (Fmodify_frame_parameters): In tty case, update the
736 default face if necessary (Bug#4238).
737
738 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
739
740 * editfns.c (Fstring_to_char): No need to explain what a character
741 is in the docstring (Bug#6576).
742
743 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
744
745 * xml.c (parse_region): Make sure we always return a tree.
746
747 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
748
749 * xml.c (parse_region): If a document contains only comments,
750 return that, too.
751
752 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
753
754 * xml.c (make_dom): Return comments, too.
755
756 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
757
758 Port to OpenBSD.
759 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
760 and the surrounding thread.
761 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
762 rather than fgets, and retry after EINTR. Otherwise, 'emacs
763 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
764 timer goes off.
765 * s/openbsd.h (BROKEN_SIGIO): Define.
766 * unexelf.c (unexec) [__OpenBSD__]:
767 Don't update the .mdebug section of the Alpha COFF symbol table.
768
769 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
770
771 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
772 (bug#8460).
773
774 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
775
776 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
777 This fixes some race conditions on the permissions of any newly
778 created file.
779
780 * alloc.c (valid_pointer_p): Use pipe, not open.
781 This fixes some permissions issues when debugging.
782
783 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
784 If fchown fails to set both uid and gid, try to set just gid,
785 as that is sometimes allowed. Adjust the file's mode to eliminate
786 setuid or setgid bits that are inappropriate if fchown fails.
787
788 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
789
790 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
791 to compare Lisp_Objects.
792 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
793 global_gnutls_log_level, don't mistake it for a Lisp_Object.
794 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
795
796 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
797
798 * lread.c (read_integer): Unread even EOF character.
799 (read1): Likewise. Properly record start position of symbol.
800
801 * lread.c (read1): Read `#:' as empty uninterned symbol if no
802 symbol character follows.
803
804 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
805
806 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
807 This works around a problem with the previous change to Fcopy_file.
808 Recent glibc declares fchown with __attribute__((warn_unused_result)),
809 and without this change, GCC might complain about discarding
810 fchown's return value.
811
812 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
813
814 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
815
816 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
817
818 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
819
820 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
821
822 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
823 it's used from the C level.
824
825 * process.c: Use the same condition for POLL_FOR_INPUT in both
826 keyboard.c and process.c (bug#1858).
827
828 2011-07-09 Lawrence Mitchell <wence@gmx.li>
829
830 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
831 (Fgnutls_boot): Use it.
832
833 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
834
835 * doc.c (Fsubstitute_command_keys): Revert last change.
836
837 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
838
839 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
840 quotes the next character, and doesn't affect other longer
841 sequences (bug#8935).
842
843 * lread.c (syms_of_lread): Clarify that is isn't only
844 `eval-buffer' and `eval-defun' that's affected by
845 `lexical-binding' (bug#8460).
846
847 2011-07-15 Eli Zaretskii <eliz@gnu.org>
848
849 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
850 bidi redisplay when a line includes both an image and is
851 truncated.
852
853 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
854
855 Fix minor problems found by static checking.
856 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
857 (elsz): Now a signed constant, not a size_t var. We prefer signed
858 types to unsigned, to avoid integer comparison confusion. Without
859 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
860 "cannot optimize loop, the loop counter may overflow", a symptom
861 of the confusion.
862 * indent.c (Fvertical_motion): Mark locals as initialized.
863 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
864
865 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
866
867 * search.c (Fre_search_backward): Mention `case-fold-search' in
868 all the re_search_* functions (bug#8138).
869
870 * keyboard.c (Fopen_dribble_file): Document when the file is
871 closed (bug#8056).
872
873 2011-07-14 Eli Zaretskii <eliz@gnu.org>
874
875 * bidi.c (bidi_dump_cached_states): Fix format of displaying
876 bidi_cache_idx.
877
878 Support bidi reordering of display and overlay strings.
879 * xdisp.c (compute_display_string_pos)
880 (compute_display_string_end): Accept additional argument STRING.
881 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
882 (reseat_to_string): Initialize bidi_it->string.s and
883 bidi_it->string.schars.
884 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
885 NULL (avoids a crash in bidi_paragraph_init).
886 Initialize itb.string.lstring.
887 (init_iterator): Call bidi_init_it only of a valid
888 buffer position was specified. Initialize paragraph_embedding to
889 L2R.
890 (reseat_to_string): Initialize the bidi iterator.
891 (display_string): If we need to ignore text properties of
892 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
893 original value of -1 will not work with bidi.)
894 (compute_display_string_pos): First arg is now struct
895 `text_pos *'; all callers changed. Support display properties on
896 Lisp strings.
897 (compute_display_string_end): Support display properties on Lisp
898 strings.
899 (init_iterator, reseat_1, reseat_to_string): Initialize the
900 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
901 when iterating on a string not from display properties).
902 (compute_display_string_pos, compute_display_string_end):
903 Fix calculation of the object to scan. Fixes an error when using
904 arrow keys.
905 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
906 base_level_stop; instead, set base_level_stop to BEGV.
907 Fixes crashes in vertical-motion.
908 (next_element_from_buffer): Improve commentary for when
909 the iterator is before prev_stop.
910 (init_iterator): Initialize bidi_p from the default value of
911 bidi-display-reordering, not from buffer-local value. Use the
912 buffer-local value only if initializing for buffer iteration.
913 (handle_invisible_prop): Support invisible properties on strings
914 that are being bidi-reordered.
915 (set_iterator_to_next): Support bidi reordering of C strings and
916 Lisp strings.
917 (next_element_from_string): Support bidi reordering of Lisp
918 strings.
919 (handle_stop_backwards): Support Lisp strings as well.
920 (display_string): Support display of R2L glyph rows.
921 Use IT_STRING_CHARPOS when displaying from a Lisp string.
922 (init_iterator): Don't initialize it->bidi_p for strings
923 here.
924 (reseat_to_string): Initialize it->bidi_p for strings here.
925 (next_element_from_string, next_element_from_c_string)
926 (next_element_from_buffer): Add xassert's for correspondence
927 between IT's object being iterated and it->bidi_it.string
928 structure.
929 (face_before_or_after_it_pos): Support bidi iteration.
930 (next_element_from_c_string): Handle the case of the first string
931 character that is not the first one in the visual order.
932 (get_visually_first_element): New function, refactored from common
933 parts of next_element_from_buffer, next_element_from_string, and
934 next_element_from_c_string.
935 (tool_bar_lines_needed, redisplay_tool_bar)
936 (display_menu_bar): Force left-to-right direction. Add a FIXME
937 comment for making that be controlled by a user option.
938 (push_it, pop_it): Save and restore the state of the
939 bidi iterator. Save and restore the bidi_p flag.
940 (pop_it): Iterate out of display property for string iteration as
941 well.
942 (iterate_out_of_display_property): Support iteration over strings.
943 (handle_single_display_spec): Set up it->bidi_it for iteration
944 over a display string, and call bidi_init_it.
945 (handle_single_display_spec, next_overlay_string)
946 (get_overlay_strings_1, push_display_prop): Set up the bidi
947 iterator for displaying display or overlay strings.
948 (forward_to_next_line_start): Don't use the shortcut if
949 bidi-iterating.
950 (back_to_previous_visible_line_start): If handle_display_prop
951 pushed the iterator stack, restore the internal state of the bidi
952 iterator by calling bidi_pop_it same number of times.
953 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
954 and we are bidi-iterating, don't decrement the iterator position;
955 instead, set the first_elt flag in the bidi iterator, to produce
956 the same effect.
957 (reseat_1): Remove redundant setting of string_from_display_prop_p.
958 (push_display_prop): xassert that we are iterating a buffer.
959 (push_it, pop_it): Save and restore paragraph_embedding member.
960 (handle_single_display_spec, next_overlay_string)
961 (get_overlay_strings_1, reseat_1, reseat_to_string)
962 (push_display_prop): Set up the `unibyte' member of bidi_it.string
963 correctly. Don't assume unibyte strings are not bidi-reordered.
964 (compute_display_string_pos)
965 (compute_display_string_end): Fix handling the case of C string.
966 (push_it, pop_it): Save and restore from_disp_prop_p.
967 (handle_single_display_spec, push_display_prop): Set the
968 from_disp_prop_p flag.
969 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
970 (pop_it): Call iterate_out_of_display_property only if we are
971 popping after iteration over a string that came from a display
972 property. Fix a typo in popping stretch info. Add an assertion
973 for verifying that the iterator position is in sync with the bidi
974 iterator.
975 (handle_single_display_spec, get_overlay_strings_1)
976 (push_display_prop): Fix initialization of paragraph direction for
977 string when that of the parent object is not yet determined.
978 (reseat_1): Call bidi_init_it to resync the bidi
979 iterator with IT's position. (Bug#7616)
980 (find_row_edges): If ROW->start.pos gives position
981 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
982 (handle_stop, back_to_previous_visible_line_start, reseat_1):
983 Reset the from_disp_prop_p flag.
984 (SAVE_IT, RESTORE_IT): New macros.
985 (pos_visible_p, face_before_or_after_it_pos)
986 (back_to_previous_visible_line_start)
987 (move_it_in_display_line_to, move_it_in_display_line)
988 (move_it_to, move_it_vertically_backward, move_it_by_lines)
989 (try_scrolling, redisplay_window, display_line): Use them when
990 saving a temporary copy of the iterator and restoring it back.
991 (back_to_previous_visible_line_start, reseat_1)
992 (init_iterator): Empty the bidi cache "stack".
993 (move_it_in_display_line_to): If iterator ended up at
994 EOL, but we never saw any buffer positions smaller than
995 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
996 motion in bidi-reordered lines.
997 (move_it_in_display_line_to): Record prev_method and prev_pos
998 immediately before the call to set_iterator_to_next. Fixes cursor
999 motion in bidi-reordered lines with stretch glyphs and strings
1000 displayed in margins. (Bug#8133) (Bug#8867)
1001 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1002 TO_CHARPOS.
1003 (pos_visible_p): Support positions in bidi-reordered lines.
1004 Save and restore bidi cache.
1005
1006 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1007 (bidi_paragraph_info): Delete unused struct.
1008 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1009 (bidi_cache_start): New variable.
1010 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1011 to zero.
1012 (bidi_cache_fetch_state, bidi_cache_search)
1013 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1014 (bidi_cache_find, bidi_peek_at_next_level)
1015 (bidi_level_of_next_char, bidi_find_other_level_edge)
1016 (bidi_move_to_visually_next): Compare cache index with
1017 bidi_cache_start rather than with zero.
1018 (bidi_fetch_char): Accept new argument STRING; all callers
1019 changed. Support iteration over a string. Support strings with
1020 display properties. Support unibyte strings. Fix the type of
1021 `len' according to what STRING_CHAR_AND_LENGTH expects.
1022 (bidi_paragraph_init, bidi_resolve_explicit_1)
1023 (bidi_resolve_explicit, bidi_resolve_weak)
1024 (bidi_level_of_next_char, bidi_move_to_visually_next):
1025 Support iteration over a string.
1026 (bidi_set_sor_type, bidi_resolve_explicit_1)
1027 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1028 can now be zero (for strings); special values 0 and -1 were
1029 changed to -1 and -2, respectively.
1030 (bidi_char_at_pos): New function.
1031 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1032 Call it instead of FETCH_MULTIBYTE_CHAR.
1033 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1034 initialized to valid values.
1035 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1036 values.
1037 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1038 the test for valid cached positions. Fix the logic for looking up
1039 the sentinel state in the cache. GCPRO the Lisp string we are
1040 iterating.
1041 (bidi_push_it, bidi_pop_it): New functions.
1042 (bidi_initialize): Initialize the bidi cache start stack pointer.
1043 (bidi_cache_ensure_space): New function, refactored from part of
1044 bidi_cache_iterator_state. Don't assume the required size is just
1045 one BIDI_CACHE_CHUNK away.
1046 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1047 (bidi_count_bytes, bidi_char_at_pos): New functions.
1048 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1049 always valid if bidi_cache_idx is valid.
1050 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1051 is valid if it's going to be used.
1052 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1053 (bidi_cache_fetch_state, bidi_cache_search)
1054 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1055 (bidi_cache_iterator_state, bidi_cache_find)
1056 (bidi_find_other_level_edge, bidi_cache_start_stack):
1057 All variables related to cache indices are now EMACS_INT.
1058
1059 * dispextern.h (struct bidi_string_data): New structure.
1060 (struct bidi_it): New member `string'. Make flag members be 1-bit
1061 fields, and put them last in the struct.
1062 (compute_display_string_pos, compute_display_string_end):
1063 Update prototypes.
1064 (bidi_push_it, bidi_pop_it): Add prototypes.
1065 (struct iterator_stack_entry): New members bidi_p,
1066 paragraph_embedding, and from_disp_prop_p.
1067 (struct it): Member bidi_p is now a bit field 1 bit wide.
1068 (bidi_shelve_cache, bidi_unshelve_cache):
1069 Declare prototypes.
1070
1071 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1072 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1073 and vector-like objects.
1074
1075 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1076 cache around display iteration.
1077
1078 * window.c (Fwindow_end, window_scroll_pixel_based)
1079 (displayed_window_lines, Frecenter): Save and restore the bidi
1080 cache around display iteration.
1081
1082 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1083
1084 * editfns.c (Fdelete_region): Clarify the use of the named
1085 parameters (bug#6788).
1086
1087 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1088
1089 * indent.c (Fvertical_motion): Set and restore w->pointm when
1090 saving and restoring the window's buffer (Bug#9006).
1091
1092 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1093
1094 * editfns.c (Fstring_to_char): Clarify just what is returned
1095 (bug#6576). Text by Eli Zaretskii.
1096
1097 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1098
1099 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1100
1101 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1102
1103 * buffer.c (mmap_find): Fix a typo.
1104
1105 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1106
1107 Fix execution of x selection hooks.
1108 * xselect.c (Qx_lost_selection_functions)
1109 (Qx_sent_selection_functions): New vars.
1110 (syms_of_xselect): DEFSYM them.
1111 (x_handle_selection_request): Pass Qx_sent_selection_functions
1112 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1113 (x_handle_selection_clear,x_clear_frame_selections):
1114 Pass Qx_lost_selection_functions rather than
1115 Vx_lost_selection_functions to Frun_hook_with_args.
1116
1117 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1118
1119 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1120 The old code sometimes used this field without initializing it.
1121
1122 * alloc.c (gc_sweep): Don't read past end of array.
1123 In theory, the old code could also have corrupted Emacs internals,
1124 though it'd be very unlikely.
1125
1126 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1127
1128 * character.c (Fcharacterp): Don't advertise optional ignored
1129 argument. (Bug#4026)
1130
1131 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1132
1133 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1134 key" (bug#4257).
1135
1136 * window.c (Fset_window_start): Doc fix (bug#4199).
1137 (Fset_window_hscroll): Ditto.
1138
1139 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1140
1141 Fix minor new problems caught by GCC 4.6.1.
1142 * term.c (init_tty): Remove unused local.
1143 * xsettings.c (store_monospaced_changed): Define this function only
1144 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1145 not used otherwise.
1146
1147 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1148
1149 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1150
1151 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1152
1153 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1154 are the mini-buffer and the echo area (bug#3320).
1155
1156 * term.c (init_tty): Remove support for supdup, c10 and perq
1157 terminals, which are no longer supported (bug#1482).
1158
1159 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1160
1161 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1162
1163 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1164
1165 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1166 for non-popups (Bug#3642).
1167
1168 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1169
1170 * alloc.c (reset_malloc_hooks): Protoize.
1171 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1172 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1173 * cm.c (losecursor): Likewise.
1174 * data.c (fmod): Likewise.
1175 * dispnew.c (swap_glyphs_in_rows): Likewise.
1176 * emacs.c (memory_warning_signal): Likewise.
1177 * floatfns.c (float_error): Likewise.
1178 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1179 (otf_open, font_otf_capability, generate_otf_features)
1180 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1181 Likewise.
1182 * image.c (pbm_read_file): Likewise.
1183 * indent.c (string_display_width): Likewise.
1184 * intervals.c (check_for_interval, search_for_interval)
1185 (inc_interval_count, count_intervals, root_interval)
1186 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1187 * lread.c (defalias): Likewise.
1188 * ralloc.c (r_alloc_check): Likewise.
1189 * regex.c (set_image_of_range_1, set_image_of_range)
1190 (regex_grow_registers): Likewise.
1191 * sysdep.c (strerror): Likewise.
1192 * termcap.c (valid_filename_p, tprint, main): Likewise.
1193 * tparam.c (main): Likewise.
1194 * unexhp9k800.c (run_time_remap, save_data_space)
1195 (update_file_ptrs, read_header, write_header, calculate_checksum)
1196 (copy_file, copy_rest, display_header): Likewise.
1197 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1198 Likewise.
1199 * xdisp.c (check_it): Likewise.
1200 * xfaces.c (register_color, unregister_color, unregister_colors):
1201 Likewise.
1202 * xfns.c (print_fontset_result): Likewise.
1203 * xrdb.c (member, fatal, main): Likewise.
1204
1205 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1206
1207 Fix minor problems found by static checking (Bug#9031).
1208 * chartab.c (char_table_set_range, map_sub_char_table):
1209 Remove unused locals.
1210 (uniprop_table): Now static.
1211 * composite.c (_work_char): Remove unused static var.
1212
1213 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1214
1215 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1216
1217 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1218
1219 * gtkutil.c (qttip_cb): Remove code without function.
1220
1221 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1222
1223 * w32.c (pthread_sigmask): New stub.
1224
1225 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1226
1227 Use pthread_sigmask, not sigprocmask (Bug#9010).
1228 sigprocmask is portable only for single-threaded applications, and
1229 Emacs can be multi-threaded when it uses GTK.
1230 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1231 (LIBES): Use it.
1232 * callproc.c (Fcall_process):
1233 * process.c (create_process):
1234 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1235 Use pthread_sigmask, not sigprocmask.
1236
1237 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1238
1239 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1240 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1241 wrong (Bug#8591).
1242
1243 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1244
1245 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1246 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1247 (xg_hide_tooltip): Fix comment.
1248
1249 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1250 in registerServicesMenuSendTypes.
1251 (validRequestorForSendType): Don't check ns_return_types.
1252
1253 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1254 ns_return_type.
1255
1256 2011-07-08 Jason Rumney <jasonr@gnu.org>
1257
1258 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1259 frame struct members of non-existent frames (Bug#6284).
1260
1261 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1262
1263 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1264 variable firstTime not needed on OSX >= 10.6.
1265 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1266 >= 10.5. Use setKnobProportion, setDoubleValue.
1267
1268 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1269 (MAC_OS_X_VERSION_10_5): Define if not defined.
1270 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1271 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1272 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1273
1274 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1275 cString and lossyCString on OSX >= 10.4
1276
1277 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1278 sizeToFit on OSX >= 10.2.
1279
1280 * nsimage.m (allocInitFromFile): Don't use deprecated method
1281 bestRepresentationForDevice on OSX >= 10.6.
1282
1283 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1284 to avoid warning.
1285
1286 * emacs.c: Declare unexec_init_emacs_zone.
1287
1288 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1289
1290 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1291
1292 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1293 on svcsMenu (Bug#8842).
1294
1295 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1296 ns_return_types.
1297 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1298
1299 * nsterm.m (QUTF8_STRING): Declare.
1300 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1301 (validRequestorForSendType): Return type is (id).
1302 Change indexOfObjectIdenticalTo to indexOfObject.
1303 Check if we have local selection before returning self (Bug#8842).
1304 (writeSelectionToPasteboard): Put local selection into paste board
1305 if we have a local selection (Bug#8842).
1306 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1307
1308 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1309 (ns_get_local_selection): Declare.
1310
1311 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1312
1313 * keymap.c (describe_map_tree): Don't insert a double newline at
1314 the end of the buffer (bug#1169) and return whether we inserted
1315 something.
1316
1317 * callint.c (Fcall_interactively): Change "reading args" to
1318 "providing args" to try to clarify what it does (bug#1010).
1319
1320 2011-07-07 Kenichi Handa <handa@m17n.org>
1321
1322 * composite.c (composition_compute_stop_pos): Ignore a static
1323 composition starting before CHARPOS (Bug#8915).
1324
1325 * xdisp.c (handle_composition_prop): Likewise.
1326
1327 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1328
1329 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1330 (Bug#9015)
1331
1332 2011-07-07 Kenichi Handa <handa@m17n.org>
1333
1334 * character.h (unicode_category_t): New enum type.
1335
1336 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1337 (Qchar_code_property_table): New variable.
1338 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1339 (UNIPROP_COMPRESSED_FORM_P): New macros.
1340 (char_table_ascii): Uncompress the compressed values.
1341 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1342 Uncompress the compressed values.
1343 (sub_char_table_ref_and_range): Likewise.
1344 (char_table_ref_and_range): Uncompress the compressed values.
1345 (sub_char_table_set): New arg is_uniprop. Callers changed.
1346 Uncompress the compressed values.
1347 (sub_char_table_set_range): Args changed. Callers changed.
1348 (char_table_set_range): Adjuted for the above change.
1349 (map_sub_char_table): Delete args default_val and parent. Add arg
1350 top. Give decoded values to a Lisp function.
1351 (map_char_table): Adjust for the above change. Give decoded
1352 values to a Lisp function. Gcpro more variables.
1353 (uniprop_table_uncompress)
1354 (uniprop_decode_value_run_length): New functions.
1355 (uniprop_decoder, uniprop_decoder_count): New variables.
1356 (uniprop_get_decoder, uniprop_encode_value_character)
1357 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1358 New functions.
1359 (uniprop_encoder, uniprop_encoder_count): New variables.
1360 (uniprop_get_encoder, uniprop_table)
1361 (Funicode_property_table_internal, Fget_unicode_property_internal)
1362 (Fput_unicode_property_internal): New functions.
1363 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1364 Sunicode_property_table_internal, Sget_unicode_property_internal,
1365 and Sput_unicode_property_internal. Defvar_lisp
1366 char-code-property-alist.
1367
1368 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1369 Vunicode_category_table.
1370
1371 * font.c (font_range): Adjust for the change of
1372 Vunicode_category_table.
1373
1374 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1375
1376 * m/iris4d.h: Remove file, move contents ...
1377 * s/irix6-5.h: ... here.
1378
1379 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1380
1381 Remove unportable assumption about struct layout (Bug#8884).
1382 * alloc.c (mark_buffer):
1383 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1384 (clone_per_buffer_values): Don't assume that
1385 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1386 This isn't true in general, and it's particularly not true
1387 if Emacs is configured with --with-wide-int.
1388 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1389 New macros, used in the buffer.c change.
1390
1391 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1392
1393 * xsettings.c: Use both GConf and GSettings if both are available.
1394 (store_config_changed_event): Add comment.
1395 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1396 (store_tool_bar_style_changed): New functions.
1397 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1398 (struct xsettings): Move font inside HAVE_XFT.
1399 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1400 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1401 Move inside HAVE_XFT.
1402 (something_changed_gsettingsCB): Rename from something_changedCB.
1403 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1404 also.
1405 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1406 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1407 (something_changed_gconfCB): Rename from something_changedCB.
1408 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1409 (parse_settings): Move check for font inside HAVE_XFT.
1410 (read_settings, apply_xft_settings): Add comment.
1411 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1412 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1413 call store_font_name_changed.
1414 (xft_settings_event): Add comment.
1415 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1416 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1417 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1418 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1419 (xsettings_initialize): Call init_gsettings last.
1420 (xsettings_get_system_font, xsettings_get_system_normal_font):
1421 Add comment.
1422
1423 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1424
1425 Random fixes. E.g., (random) never returned negative values.
1426 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1427 subseconds part to the entropy, as that's a bit more random.
1428 Prefer signed to unsigned, since the signedness doesn't matter and
1429 in general we prefer signed. When given a limit, use a
1430 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1431 latter isn't right if USE_2_TAGS_FOR_INTS.
1432 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1433 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1434
1435 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1436
1437 * textprop.c (text_property_stickiness):
1438 Obey Vtext_property_default_nonsticky.
1439 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1440 * w32fns.c (syms_of_w32fns):
1441 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1442
1443 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1444
1445 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1446 This is more efficient than Ffile_directory_p and avoids a minor race.
1447
1448 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1449
1450 * buffer.c (Foverlay_put): Say what the return value is
1451 (bug#7835).
1452
1453 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1454 is a directory before asking whether to use the file name
1455 (bug#7564).
1456 (barf_or_query_if_file_exists): Make the "File is a directory"
1457 error be more correct.
1458
1459 * fns.c (Frequire): Remove the mention of the .gz files, since
1460 that's installation-specific, but keep the mention of
1461 `get-load-suffixes'.
1462
1463 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1464
1465 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1466 Report string overflow if the output is too long.
1467
1468 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1469
1470 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1471 (syms_of_gnutls): Remove duplicate DEFSYM for
1472 Qgnutls_bootprop_verify_hostname_error, an error for
1473 Qgnutls_bootprop_verify_error (which is no longer used).
1474
1475 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1476 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1477 Also (re)move comments that are misplaced or no longer relevant.
1478
1479 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1480
1481 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1482
1483 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1484
1485 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1486 and background color parameters if they have been changed.
1487
1488 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1489
1490 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1491
1492 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 * xsettings.c (SYSTEM_FONT): Define only when used.
1495 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1496
1497 * keymap.c (access_keymap_1): Now static.
1498
1499 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1500
1501 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1502 leave any prefix arg for the up event (Bug#1586).
1503
1504 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1505
1506 * lread.c (syms_of_lread): Mention single symbols defined by
1507 `defvar' or `defconst' (bug#7154).
1508
1509 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1510 (Frequire): Mention get-load-suffixes.
1511
1512 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1513
1514 * window.h (window): Remove clone_number slot.
1515 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1516 Remove.
1517 (make_parent_window, make_window, saved_window)
1518 (Fset_window_configuration, save_window_save): Don't deal with
1519 clone numbers.
1520 * buffer.c (Qclone_number): Remove declaration.
1521 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1522
1523 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1524
1525 Add multiple inheritance to keymaps.
1526 * keymap.c (Fmake_composed_keymap): New function.
1527 (Fset_keymap_parent): Simplify.
1528 (fix_submap_inheritance): Remove.
1529 (access_keymap_1): New function extracted from access_keymap to handle
1530 embedded parents and handle lists of maps.
1531 (access_keymap): Use it.
1532 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1533 (Fcopy_keymap): Handle embedded parents.
1534 (Fcommand_remapping, define_as_prefix): Simplify.
1535 (Fkey_binding): Simplify.
1536 (syms_of_keymap): Move minibuffer-local-completion-map,
1537 minibuffer-local-filename-completion-map,
1538 minibuffer-local-must-match-map, and
1539 minibuffer-local-filename-must-match-map to Elisp.
1540 (syms_of_keymap): Defsubr make-composed-keymap.
1541 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1542 (parse_menu_item): Trivial simplification.
1543
1544 2011-07-01 Glenn Morris <rgm@gnu.org>
1545
1546 * Makefile.in (SETTINGS_LIBS): Fix typo.
1547
1548 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1549
1550 * coding.c (Fencode_coding_string): Record the last coding system
1551 used, as the function doc string says (bug#8738).
1552
1553 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1554
1555 * xsettings.c (store_monospaced_changed): Take new font as arg and
1556 check for change against current_mono_font.
1557 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1558 (emacs_settings_constructor, emacs_settings_get_property)
1559 (emacs_settings_set_property, emacs_settings_class_init)
1560 (emacs_settings_init, gsettings_obj): Remove.
1561 (something_changedCB): New function for HAVE_GSETTINGS.
1562 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1563 with value as argument.
1564 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1565 g_settings_new (Bug#8967). Do not create gsettings_obj.
1566 Remove calls to g_settings_bind. Connect something_changedCB to
1567 "changed".
1568
1569 * xgselect.c: Add defined (HAVE_GSETTINGS).
1570 (xgselect_initialize): Ditto.
1571
1572 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1573 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1574 xg_select.
1575
1576 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1577
1578 * eval.c (struct backtrace): Simplify and port the data structure.
1579 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1580 signed bit field, as this assumption is not portable and it makes
1581 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1582 "char debug_on_exit : 1" as this is not portable either; instead,
1583 use the portable "unsigned int debug_on_exit : 1". Remove unused
1584 member evalargs. Remove obsolete comments about cc bombing out.
1585
1586 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1587
1588 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1589 Let HAVE_GSETTINGS override HAVE_GCONF.
1590 (store_monospaced_changed): New function.
1591 (EMACS_SETTINGS): A new type derived from GObject to handle
1592 GSettings notifications.
1593 (emacs_settings_constructor, emacs_settings_get_property)
1594 (emacs_settings_set_property, emacs_settings_class_init):
1595 New functions.
1596 (gsettings_client, gsettings_obj): New variables.
1597 (GSETTINGS_SCHEMA): New define.
1598 (something_changedCB): Call store_monospaced_changed.
1599 (init_gsettings): New function.
1600 (xsettings_initialize): Call init_gsettings.
1601 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1602 to NULL.
1603
1604 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1605 GCONF_CFLAGS/LIBS.
1606
1607 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1608
1609 * window.c (resize_root_window, grow_mini_window)
1610 (shrink_mini_window): Rename Qresize_root_window to
1611 Qwindow_resize_root_window and Qresize_root_window_vertically to
1612 Qwindow_resize_root_window_vertically.
1613
1614 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1615
1616 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1617
1618 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1619
1620 * makefile.w32-in: Redesign dependencies so they reflect more
1621 clearly which files are directly included by each source file,
1622 and not through other includes.
1623
1624 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1625
1626 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1627 (sort_overlays, overlay_strings): When an overlay's clone number
1628 matches the window's clone number process the overlay even if
1629 the overlay's window property doesn't match the current window.
1630
1631 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1632 (Fwindow_hchild): Rename to Fwindow_left_child.
1633 (Fwindow_next): Rename to Fwindow_next_sibling.
1634 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1635 (resize_window_check): Rename to window_resize_check.
1636 (resize_window_apply): Rename to window_resize_apply.
1637 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1638 (Fdelete_other_windows_internal, resize_frame_windows)
1639 (Fsplit_window_internal, Fdelete_window_internal)
1640 (grow_mini_window, shrink_mini_window)
1641 (Fresize_mini_window_internal): Fix callers accordingly.
1642
1643 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1644
1645 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1646 (emacs_fixed_set_min_size): Remove.
1647 (emacs_fixed_new): Take frame as argument.
1648
1649 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1650 (_EmacsFixedPrivate): Remove minwidth/height.
1651 Add struct frame *f.
1652 (emacs_fixed_init): Initialize priv->f.
1653 (get_parent_class, emacs_fixed_set_min_size): Remove.
1654 (emacs_fixed_new): Set priv->f to argument.
1655 (emacs_fixed_get_preferred_width)
1656 (emacs_fixed_get_preferred_height): Use min_width/height from
1657 frames size_hint to set minimum and natural (Bug#8919).
1658 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1659 and use min_width/height from frames size_hint to set
1660 min_width/height (Bug#8919).
1661
1662 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1663 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1664 Fix indentation.
1665
1666 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1667
1668 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1669 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1670 called at ZV.
1671
1672 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1673
1674 * process.c (wait_reading_process_output): Bypass select if
1675 waiting for a cell while ignoring keyboard input, and input is
1676 pending. Suggested by Jan Djärv (Bug#8869).
1677
1678 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1679
1680 Use gnulib's dup2 module instead of rolling our own.
1681 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1682
1683 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1684
1685 * dispnew.c (scrolling_window): Before scrolling, turn off a
1686 mouse-highlight in the window being scrolled.
1687
1688 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1689
1690 Move DEFSYM to lisp.h and use everywhere.
1691
1692 * character.h (DEFSYM): Move declaration...
1693 * lisp.h (DEFSYM): ...here.
1694
1695 * gnutls.c:
1696 * minibuf.c:
1697 * w32menu.c:
1698 * w32proc.c:
1699 * w32select.c: Don't include character.h.
1700
1701 * alloc.c (syms_of_alloc):
1702 * buffer.c (syms_of_buffer):
1703 * bytecode.c (syms_of_bytecode):
1704 * callint.c (syms_of_callint):
1705 * casefiddle.c (syms_of_casefiddle):
1706 * casetab.c (init_casetab_once):
1707 * category.c (init_category_once, syms_of_category):
1708 * ccl.c (syms_of_ccl):
1709 * cmds.c (syms_of_cmds):
1710 * composite.c (syms_of_composite):
1711 * dbusbind.c (syms_of_dbusbind):
1712 * dired.c (syms_of_dired):
1713 * dispnew.c (syms_of_display):
1714 * doc.c (syms_of_doc):
1715 * editfns.c (syms_of_editfns):
1716 * emacs.c (syms_of_emacs):
1717 * eval.c (syms_of_eval):
1718 * fileio.c (syms_of_fileio):
1719 * fns.c (syms_of_fns):
1720 * frame.c (syms_of_frame):
1721 * fringe.c (syms_of_fringe):
1722 * insdel.c (syms_of_insdel):
1723 * keymap.c (syms_of_keymap):
1724 * lread.c (init_obarray, syms_of_lread):
1725 * macros.c (syms_of_macros):
1726 * msdos.c (syms_of_msdos):
1727 * print.c (syms_of_print):
1728 * process.c (syms_of_process):
1729 * search.c (syms_of_search):
1730 * sound.c (syms_of_sound):
1731 * syntax.c (init_syntax_once, syms_of_syntax):
1732 * terminal.c (syms_of_terminal):
1733 * textprop.c (syms_of_textprop):
1734 * undo.c (syms_of_undo):
1735 * w32.c (globals_of_w32):
1736 * window.c (syms_of_window):
1737 * xdisp.c (syms_of_xdisp):
1738 * xfaces.c (syms_of_xfaces):
1739 * xfns.c (syms_of_xfns):
1740 * xmenu.c (syms_of_xmenu):
1741 * xsettings.c (syms_of_xsettings):
1742 * xterm.c (syms_of_xterm): Use DEFSYM.
1743
1744 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1745
1746 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1747
1748 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1749
1750 Integer and buffer overflow fixes (Bug#8873).
1751
1752 * print.c (printchar, strout): Check for string overflow.
1753 (PRINTPREPARE, printchar, strout):
1754 Don't set size unless allocation succeeds.
1755
1756 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1757 for sizes. Check for string overflow more accurately.
1758 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1759
1760 * macros.c: Integer and buffer overflow fixes.
1761 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1762 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1763 Use ptrdiff_t, not int, for sizes.
1764 Don't increment bufsize until after realloc succeeds.
1765 Check for size-calculation overflow.
1766 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1767
1768 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1769
1770 * lread.c: Integer overflow fixes.
1771 (read_integer): Radix is now EMACS_INT, not int,
1772 to improve quality of diagnostics for out-of-range radices.
1773 Calculate buffer size correctly for out-of-range radices.
1774 (read1): Check for integer overflow in radices, and in
1775 read-circle numbers.
1776 (read_escape): Avoid int overflow.
1777 (Fload, openp, read_buffer_size, read1)
1778 (substitute_object_recurse, read_vector, read_list, map_obarray):
1779 Use ptrdiff_t, not int, for sizes.
1780 (read1): Use EMACS_INT, not int, for sizes.
1781 Check for size overflow.
1782
1783 * image.c (cache_image): Check for size arithmetic overflow.
1784
1785 * lread.c: Integer overflow issues.
1786 (saved_doc_string_size, saved_doc_string_length)
1787 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1788 Now ptrdiff_t, not int.
1789 (read1): Don't assume doc string length fits in int. Check for
1790 out-of-range doc string lengths.
1791 (read_list): Don't assume file position fits in int.
1792 (read_escape): Check for hex character overflow.
1793
1794 2011-06-22 Leo Liu <sdl.web@gmail.com>
1795
1796 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1797 Move to minibuffer.el.
1798
1799 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1802 The following patches are for when GLYPH_DEBUG && !XASSERT.
1803 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1804 * dispnew.c (flush_stdout):
1805 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1806 Mark as externally visible.
1807 * dispnew.c (check_window_matrix_pointers): Now static.
1808 * dispnew.c (window_to_frame_vpos):
1809 * xfns.c (unwind_create_frame):
1810 * xterm.c (x_check_font): Remove unused local.
1811 * scroll.c (CHECK_BOUNDS):
1812 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1813 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1814 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1815 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1816 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1817 Now static.
1818 (debug_method_add): Use va_list and vsprintf rather than relying
1819 on undefined behavior with wrong number of arguments.
1820 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1821 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1822 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1823 since we're not interested in debugging glyphs with old libraries.
1824 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1825 GCC 4.6.0's static checking.
1826
1827 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1828
1829 Integer overflow and signedness fixes (Bug#8873).
1830 A few related buffer overrun fixes, too.
1831
1832 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1833
1834 * dispextern.h (struct face.stipple):
1835 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1836 (x_bitmap_mask, x_allocate_bitmap_record)
1837 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1838 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1839 (x_create_bitmap_from_xpm_data):
1840 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1841 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1842 (.bitmaps_last):
1843 * xfaces.c (load_pixmap):
1844 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1845 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1846 (.bitmaps_last, struct x_output.icon_bitmap):
1847 Use ptrdiff_t, not int, for bitmap indexes.
1848 (x_allocate_bitmap_record): Check for size overflow.
1849 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1850
1851 Use ptrdiff_t, not int, for overlay counts.
1852 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1853 * editfns.c (overlays_around, get_pos_property):
1854 * textprop.c (get_char_property_and_overlay):
1855 * xdisp.c (next_overlay_change, note_mouse_highlight):
1856 * xfaces.c (face_at_buffer_position):
1857 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1858 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1859 (Fnext_overlay_change, Fprevious_overlay_change)
1860 (mouse_face_overlay_overlaps, Foverlays_in):
1861 Use ptrdiff_t, not int, for sizes.
1862 (overlays_at, overlays_in): Check for size-calculation overflow.
1863
1864 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1865
1866 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1867 (x_session_initialize): Do not assume string length fits in int.
1868
1869 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1870 This is unlikely, but can occur if DPI is outlandish.
1871
1872 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1873 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1874
1875 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1876 * xrdb.c (magic_file_p, search_magic_path):
1877 Omit last arg SUFFIX; it was always 0. All callers changed.
1878 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1879
1880 * xfont.c (xfont_match): Avoid need for strlen.
1881
1882 * xfns.c: Don't assume strlen fits in int.
1883 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1884
1885 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1886 not unsigned long, as we prefer signed integers. All callers changed.
1887 Detect integer overflow in repeat count.
1888 (message_dolog): Don't assume print length fits in 39 bytes.
1889 (display_mode_element): Don't assume strlen fits in int.
1890
1891 * termcap.c: Don't assume sizes fit in int and never overflow.
1892 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1893 (gobble_line): Check for size-calculation overflow.
1894
1895 * minibuf.c (Fread_buffer):
1896 * lread.c (intern, intern_c_string):
1897 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1898 Don't assume string length fits in int.
1899
1900 * keyboard.c (parse_tool_bar_item):
1901 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1902
1903 * font.c: Don't assume string length fits in int.
1904 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1905 Use ptrdiff_t, not int.
1906 (font_intern_prop): Don't assume string length fits in int.
1907 Don't assume integer property fits in fixnum.
1908 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1909
1910 * filelock.c: Fix some buffer overrun and integer overflow issues.
1911 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1912 Reformulate so as not to need the command string.
1913 Invoke gzip -cd rather than gunzip, as it's more portable.
1914 (lock_info_type, lock_file_1, lock_file):
1915 Don't assume pid_t and time_t fit in unsigned long.
1916 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1917 (current_lock_owner): Prefer signed type for sizes.
1918 Use memcpy, not strncpy, where memcpy is what is really wanted.
1919 Don't assume (via atoi) that time_t and pid_t fit in int.
1920 Check for time_t and/or pid_t out of range, e.g., via a network share.
1921 Don't alloca where an auto var works fine.
1922
1923 * fileio.c: Fix some integer overflow issues.
1924 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1925 Don't assume string length fits in int.
1926 (directory_file_name): Don't assume string length fits in long.
1927 (make_temp_name): Don't assume pid fits in int, or that its print
1928 length is less than 20.
1929
1930 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1931
1932 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1933
1934 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1935
1936 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1937 We prefer signed integers, even for size calculations.
1938
1939 * emacs.c: Don't assume string length fits in 'int'.
1940 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1941 (main): Don't invoke strlen when not needed.
1942
1943 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1944 (XD_DEBUG_MESSAGE): Don't waste a byte.
1945
1946 * callproc.c (getenv_internal_1, getenv_internal)
1947 (Fgetenv_internal):
1948 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1949
1950 * lread.c (invalid_syntax): Omit length argument.
1951 All uses changed. This doesn't fix a bug, but it simplifies the
1952 code away from its former Hollerith-constant appearance, and it's
1953 one less 'int' to worry about when looking at integer-overflow issues.
1954 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1955
1956 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1957 This didn't break anything, but it didn't help either.
1958 It's confusing to put a bogus integer in a place where the actual
1959 value does not matter.
1960 (LIST_END_P): Remove unused macro and its bogus comment.
1961 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1962
1963 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1964 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1965 implementation.
1966 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1967 We prefer signed types, and the value cannot exceed the EMACS_INT
1968 range anyway (because otherwise the length would not be representable).
1969 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1970 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1971 This avoids a GCC warning when WIDE_EMACS_INT.
1972
1973 * indent.c (sane_tab_width): New function.
1974 (current_column, scan_for_column, Findent_to, position_indentation)
1975 (compute_motion): Use it. This is just for clarity.
1976 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1977
1978 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1979
1980 * lisp.h (lint_assume): New macro.
1981 * composite.c (composition_gstring_put_cache):
1982 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1983
1984 * editfns.c, insdel.c:
1985 Omit unnecessary forward decls, to simplify future changes.
1986
1987 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1988
1989 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1990
1991 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1992 Use much-faster test for byte-length change.
1993 Don't assume string byte-length fits in 'int'.
1994 Check that character arg fits in 'int'.
1995 (mapcar1): Declare byte as byte, for clarity.
1996
1997 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1998
1999 * fns.c (concat): Catch string overflow earlier.
2000 Do not rely on integer wraparound.
2001
2002 * dispextern.h (struct it.overlay_strings_charpos)
2003 (struct it.selective): Now EMACS_INT, not int.
2004 * xdisp.c (forward_to_next_line_start)
2005 (back_to_previous_visible_line_start)
2006 (reseat_at_next_visible_line_start, next_element_from_buffer):
2007 Don't arbitrarily truncate the value of 'selective' to int.
2008
2009 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2010
2011 * composite.c: Don't truncate sizes to 'int'.
2012 (composition_gstring_p, composition_reseat_it)
2013 (composition_adjust_point): Use EMACS_INT, not int.
2014 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2015 not EMACS_UINT, for indexes.
2016
2017 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2018
2019 * buffer.c: Include <verify.h>.
2020 (struct sortvec.priority, struct sortstr.priority):
2021 Now EMACS_INT, not int.
2022 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2023 (struct sortstr.size, record_overlay_string)
2024 (struct sortstrlist.size, struct sortlist.used):
2025 Don't truncate size to int.
2026 (record_overlay_string): Check for size-calculation overflow.
2027 (init_buffer_once): Check at compile-time, not run-time.
2028
2029 2011-06-22 Jim Meyering <meyering@redhat.com>
2030
2031 Don't leak an XBM-image-sized buffer
2032 * image.c (xbm_load): Free the image buffer after using it.
2033
2034 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2035
2036 Port to Sun C.
2037 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2038 that Sun C diagnosed.
2039 * fns.c (secure_hash): Fix pointer signedness issue.
2040 * intervals.c (static_offset_intervals): New function.
2041 (offset_intervals): Use it.
2042
2043 2011-06-21 Leo Liu <sdl.web@gmail.com>
2044
2045 * deps.mk (fns.o):
2046 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2047 sha512.h.
2048
2049 * fns.c (secure_hash): Rename from crypto_hash_function and change
2050 the first arg to accept symbols.
2051 (Fsecure_hash): New primitive.
2052 (syms_of_fns): New symbols.
2053
2054 2011-06-20 Deniz Dogan <deniz@dogan.se>
2055
2056 * process.c (Fset_process_buffer): Clarify return value in
2057 docstring.
2058
2059 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2060
2061 * dispnew.c (add_window_display_history): Use BVAR.
2062
2063 * xdisp.c (debug_method_add): Use BVAR.
2064 (check_window_end, dump_glyph_matrix, dump_glyph)
2065 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2066
2067 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2068 Likewise.
2069
2070 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2071 check till after the cache is created in init_frame_faces.
2072
2073 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2074
2075 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2076
2077 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2078
2079 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2080 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2081 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2082
2083 Improve buffer-overflow checking (Bug#8873).
2084 * fileio.c (Finsert_file_contents):
2085 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2086 Remove the old (too-loose) buffer overflow checks.
2087 They weren't needed, since make_gap checks for buffer overflow.
2088 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2089 The old code merely checked for Emacs fixnum overflow, and relied
2090 on undefined (wraparound) behavior. The new code avoids undefined
2091 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2092
2093 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2094 Tune. Don't use wider integers than needed. Don't use alloca.
2095 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2096
2097 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2098
2099 * insdel.c, lisp.h (buffer_overflow): New function.
2100 (insert_from_buffer_1, replace_range, replace_range_2):
2101 * insdel.c (make_gap_larger):
2102 * editfns.c (Finsert_char):
2103 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2104
2105 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2106
2107 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2108
2109 Integer overflow and signedness fixes (Bug#8873).
2110
2111 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2112 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2113
2114 * fileio.c: Don't assume EMACS_INT fits in off_t.
2115 (emacs_lseek): New static function.
2116 (Finsert_file_contents, Fwrite_region): Use it.
2117 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2118
2119 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2120
2121 * fns.c: Don't overflow int when computing a list length.
2122 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2123 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2124 truncation on 64-bit hosts. Check for QUIT every
2125 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2126 faster and is responsive enough.
2127 (Flength): Report an error instead of overflowing an integer.
2128 (Fsafe_length): Return a float if the value is not representable
2129 as a fixnum. This shouldn't happen except in contrived situations.
2130 (Fnthcdr, Fsort): Don't assume list length fits in int.
2131 (Fcopy_sequence): Don't assume vector length fits in int.
2132
2133 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2134 (header_size, word_size): New constants.
2135 (allocate_vectorlike): Don't check size overflow here.
2136 (allocate_vector): Check it here instead, since this is the only
2137 caller of allocate_vectorlike that could cause overflow.
2138 Check that the new vector's length is representable as a fixnum.
2139
2140 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2141 The previous code was bogus. For example, next_almost_prime (32)
2142 returned 39, which is undesirable as it is a multiple of 3; and
2143 next_almost_prime (24) returned 25, which is a multiple of 5 so
2144 why was the code bothering to check for multiples of 7?
2145
2146 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2147
2148 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2149
2150 Variadic C functions now count arguments with ptrdiff_t.
2151 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2152 Back then I didn't know that the Emacs coding style prefers signed int.
2153 Also, in the meantime I found a few more instances where arguments
2154 were being counted with int, which may truncate counts on 64-bit
2155 machines, or EMACS_INT, which may be unnecessarily wide.
2156 * lisp.h (struct Lisp_Subr.function.aMANY)
2157 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2158 Arg counts are now ptrdiff_t, not size_t.
2159 All variadic functions and their callers changed accordingly.
2160 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2161 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2162 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2163 * callint.c (Fcall_interactively): Check arg count for overflow,
2164 to avoid potential buffer overrun. Use signed char, not 'int',
2165 for 'varies' array, so that we needn't bother to check its size
2166 calculation for overflow.
2167 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2168 * eval.c (apply_lambda):
2169 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2170 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2171 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2172
2173 * callint.c (Fcall_interactively): Don't use index var as event count.
2174
2175 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2176 * mem-limits.h (SIZE): Remove; no longer used.
2177
2178 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2179
2180 Remove unnecessary casts.
2181 * xterm.c (x_term_init):
2182 * xfns.c (x_set_border_pixel):
2183 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2184 These aren't needed now that we assume ANSI C.
2185
2186 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2187 It's more likely to cause problems (due to unsigned overflow)
2188 than to cure them.
2189
2190 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2191
2192 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2193
2194 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2195
2196 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2197
2198 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2199
2200 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2201
2202 GLYPH_CODE_FACE returns EMACS_INT, not int.
2203 * dispextern.h (merge_faces):
2204 * xfaces.c (merge_faces):
2205 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2206 Don't assume EMACS_INT fits in int.
2207
2208 * character.h (CHAR_VALID_P): Remove unused parameter.
2209 * fontset.c, lisp.h, xdisp.c: All uses changed.
2210
2211 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2212
2213 * fns.c (concat): Minor tuning based on overflow analysis.
2214 This doesn't fix any bugs. Use int to hold character, instead
2215 of constantly refetching from Emacs object. Use XFASTINT, not
2216 XINT, for value known to be a character. Don't bother comparing
2217 a single byte to 0400, as it's always less.
2218
2219 * floatfns.c (Fexpt):
2220 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2221
2222 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2223 for characters.
2224
2225 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2226
2227 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2228 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2229 incorrectly succeed when S was a string, because 4294967386 was
2230 truncated before it was used.
2231
2232 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2233 Otherwise, an out-of-range integer could cause undefined behavior
2234 on a 64-bit host.
2235
2236 * composite.c: Use int, not EMACS_INT, for characters.
2237 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2238 EMACS_INT, for values that are known to be in character range.
2239 This doesn't fix any bugs but is the usual style inside Emacs and
2240 may generate better code on 32-bit machines.
2241
2242 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2243 This is for reasons similar to the recent CHAR_STRING fix.
2244 * charset.c (Fencode_char): Check that character arg is actually
2245 a character. Pass an int to ENCODE_CHAR.
2246 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2247 wider than 'int', as a compile-time check to prevent future regressions
2248 in this area.
2249
2250 * character.c (char_string): Remove unnecessary casts.
2251
2252 Make sure a 64-bit char is never passed to CHAR_STRING.
2253 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2254 by silently ignoring the top 32 bits, allowing some values
2255 that were far too large to be valid characters.
2256 * character.h: Include <verify.h>.
2257 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2258 arguments are no wider than unsigned, as a compile-time check
2259 to prevent future regressions in this area.
2260 * data.c (Faset):
2261 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2262 (Fsubst_char_in_region):
2263 * fns.c (concat):
2264 * xdisp.c (decode_mode_spec_coding):
2265 Adjust to CHAR_STRING's new requirement.
2266 * editfns.c (Finsert_char, Fsubst_char_in_region):
2267 * fns.c (concat): Check that character args are actually
2268 characters. Without this test, these functions did the wrong
2269 thing with wildly out-of-range values on 64-bit hosts.
2270
2271 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2272 These casts should not be needed on 32-bit hosts, either.
2273 * keyboard.c (read_char):
2274 * lread.c (Fload): Remove casts to unsigned.
2275
2276 * lisp.h (UNSIGNED_CMP): New macro.
2277 This fixes comparison bugs on 64-bit hosts.
2278 (ASCII_CHAR_P): Use it.
2279 * casefiddle.c (casify_object):
2280 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2281 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2282 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2283 * dispextern.h (FACE_FROM_ID):
2284 * keyboard.c (read_char): Use UNSIGNED_CMP.
2285
2286 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2287 not to EMACS_INT, to avoid GCC warning.
2288
2289 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2290
2291 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2292 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2293 isn't needed on 32-bit machines.
2294
2295 * buffer.c (Fgenerate_new_buffer_name):
2296 Use EMACS_INT for count, not int.
2297 (advance_to_char_boundary): Return EMACS_INT, not int.
2298
2299 * data.c (Qcompiled_function): Now static.
2300
2301 * window.c (window_body_lines): Now static.
2302
2303 * image.c (gif_load): Rename local to avoid shadowing.
2304
2305 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2306 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2307 * alloc.c (make_save_value): Integer argument is now of type
2308 ptrdiff_t, not int.
2309 (mark_object): Use ptrdiff_t, not int.
2310 * lisp.h (pD): New macro.
2311 * print.c (print_object): Use it.
2312
2313 * alloc.c: Use EMACS_INT, not int, to count objects.
2314 (total_conses, total_markers, total_symbols, total_vector_size)
2315 (total_free_conses, total_free_markers, total_free_symbols)
2316 (total_free_floats, total_floats, total_free_intervals)
2317 (total_intervals, total_strings, total_free_strings):
2318 Now EMACS_INT, not int. All uses changed.
2319 (Fgarbage_collect): Compute overall total using a double, so that
2320 integer overflow is less likely to be a problem. Check for overflow
2321 when converting back to an integer.
2322 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2323 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2324 These were 'int' variables that could overflow on 64-bit hosts;
2325 they were never used, so remove them instead of repairing them.
2326 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2327 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2328 Previously, this ceilinged at INT_MAX, but that doesn't work on
2329 64-bit machines.
2330 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2331
2332 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2333 (allocate_vectorlike): Check for ptrdiff_t overflow.
2334 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2335 when a (possibly-narrower) signed value would do just as well.
2336 We prefer using signed arithmetic, to avoid comparison confusion.
2337
2338 * alloc.c: Catch some string size overflows that we were missing.
2339 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2340 for convenience in STRING_BYTES_MAX.
2341 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2342 The definition here is exact; the one in lisp.h was approximate.
2343 (allocate_string_data): Check for string overflow. This catches
2344 some instances we weren't catching before. Also, it catches
2345 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2346 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2347 and ptrdiff_t and EMACS_INT are both 64 bits.
2348
2349 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2350 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2351 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2352
2353 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2354
2355 * alloc.c (Fmake_string): Check for out-of-range init.
2356
2357 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2358
2359 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2360
2361 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2362
2363 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2364 xg_get_default_scrollbar_width.
2365
2366 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2367 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2368 (style_changed_cb): Call update_theme_scrollbar_width and call
2369 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2370 all frames (Bug#8505).
2371 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2372 Call gtk_window_set_resizable if HAVE_GTK3.
2373 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2374 and height if HAVE_GTK3 (Bug#8505).
2375 (scroll_bar_width_for_theme): New variable.
2376 (update_theme_scrollbar_width): New function.
2377 (xg_get_default_scrollbar_width): Move code to
2378 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2379 (xg_initialize): Call update_theme_scrollbar_width.
2380
2381 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2382
2383 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2384
2385 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2386
2387 * frame.c (make_frame): Call other_buffer_safely instead of
2388 other_buffer.
2389
2390 * window.c (temp_output_buffer_show): Call display_buffer with
2391 second argument Vtemp_buffer_show_specifiers and reset latter
2392 immediately after the call.
2393 (Vtemp_buffer_show_specifiers): New variable.
2394 (auto_window_vscroll_p, next_screen_context_lines)
2395 (Vscroll_preserve_screen_position): Remove leading asterisks from
2396 doc-strings.
2397
2398 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 Fix minor problems found by GCC 4.6.0 static checking.
2401 * buffer.c (Qclone_number): Remove for now, as it's unused.
2402 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2403 (record_buffer): Remove unused local.
2404 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2405 (set_frame_buffer_list): Remove; unused.
2406 * frame.h (other_visible_frames): Remove decl.
2407 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2408 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2409 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2410 if HAVE_GPM.
2411 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2412 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2413 Define only if HAVE_GPM.
2414 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2415 (update_hints_inhibit): Remove; never set. All uses removed.
2416 * widgetprv.h (emacsFrameClassRec): Remove decl.
2417 * window.c (delete_deletable_window): Now returns void, since it
2418 wasn't returning anything.
2419 (compare_window_configurations): Remove unused locals.
2420 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2421 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2422 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2423 the same widths as pointers. This follows up on the 2011-05-06 patch.
2424 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2425 * xterm.h: Likewise.
2426 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2427
2428 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2429
2430 * makefile.w32-in: Update dependencies.
2431 (LISP_H): Add lib/intprops.h.
2432
2433 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2434
2435 * image.c (gif_load): Add animation frame delay to the metadata.
2436 (syms_of_image): Use DEFSYM. New symbol `delay'.
2437
2438 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2439
2440 * window.c (delete_deletable_window): Re-add.
2441 (Fset_window_configuration): Rewrite to handle dead buffers and
2442 consequently deletable windows.
2443 (window_tree, Fwindow_tree): Remove. Supply functionality in
2444 window.el.
2445 (compare_window_configurations): Simplify code.
2446
2447 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2448
2449 * image.c (imagemagick_load_image): Fix type mismatch.
2450 (Fimagemagick_types): Likewise.
2451
2452 * window.h (replace_buffer_in_windows): Declare.
2453
2454 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2455
2456 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2457 Qclone_number. Remove external declaration of Qdelete_window.
2458 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2459 code.
2460 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2461 Run Qbuffer_list_update_hook if allowed.
2462 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2463 buffer list implementation.
2464 (other_buffer_safely): New function.
2465 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2466 calls to replace_buffer_in_windows and
2467 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2468 if allowed.
2469 (record_buffer): Inhibit quitting and rewrite using quittable
2470 functions. Run Qbuffer_list_update_hook if allowed.
2471 (Frecord_buffer, Funrecord_buffer): New functions.
2472 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2473 Move switch-to-buffer to window.el.
2474 (bury-buffer): Move to window.el.
2475 (Vbuffer_list_update_hook): New variable.
2476
2477 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2478 section.
2479
2480 * window.h (resize_frame_windows): Move up in code.
2481 (Fwindow_frame): Remove EXFUN.
2482 (replace_buffer_in_all_windows): Remove prototype.
2483 (replace_buffer_in_windows_safely): Add prototype.
2484
2485 * window.c: Declare Qdelete_window static again. Move down
2486 declaration of select_count.
2487 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2488 (Fother_window): Move to window.el.
2489 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2490 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2491 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2492 window.el.
2493 (replace_buffer_in_windows): Implement by calling
2494 Qreplace_buffer_in_windows.
2495 (replace_buffer_in_all_windows): Remove with some functionality
2496 moved into replace_buffer_in_windows_safely.
2497 (replace_buffer_in_windows_safely): New function.
2498 (select_window_norecord, select_frame_norecord): Move in front
2499 of run_window_configuration_change_hook. Remove now obsolete
2500 declarations.
2501 (Fset_window_buffer): Rewrite doc-string.
2502 Call Qrecord_window_buffer.
2503 (keys_of_window): Move binding for other-window to window.el.
2504
2505 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2506
2507 * dispextern.h (struct image): Replace data member, whose int_val
2508 and ptr_val fields were not used by anything, with a single
2509 lisp_val object.
2510
2511 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2512 (gif_clear_image, gif_load, imagemagick_load_image)
2513 (gs_clear_image, gs_load): Callers changed.
2514
2515 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2516
2517 * buffer.h: Include <time.h>, for time_t.
2518 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2519
2520 Fix minor problems found by static checking.
2521
2522 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2523
2524 Make identifiers static if they are not used in other modules.
2525 * data.c (Qcompiled_function, Qframe, Qvector):
2526 * image.c (QimageMagick, Qsvg):
2527 * minibuf.c (Qmetadata):
2528 * window.c (resize_window_check, resize_root_window): Now static.
2529 * window.h (resize_window_check, resize_root_window): Remove decls.
2530
2531 * window.c (window_deletion_count, delete_deletable_window):
2532 Remove; unused.
2533 (window_body_lines): Now static.
2534 (Fdelete_other_windows_internal): Mark vars as initialized.
2535 Make sure 'resize_failed' is initialized.
2536 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2537 (resize_window_apply): Remove unused local.
2538 * window.h (delete_deletable_window): Remove decl.
2539
2540 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2541 (imagemagick_load_image): Fix pointer signedness problem by changing
2542 last arg from unsigned char * to char *. All uses changed.
2543 Also, fix a local for similar reasons.
2544 Remove unused locals. Remove locals to avoid shadowing.
2545 (fn_rsvg_handle_free): Remove; unused.
2546 (svg_load, svg_load_image): Fix pointer signedness problem.
2547 (imagemagick_load_image): Don't use garbage pointer image_wand.
2548
2549 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2550
2551 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2552
2553 * image.c (gif_load): Fix omitted cast error introduced by
2554 2011-06-06 change.
2555
2556 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2557
2558 * window.h (resize_proportionally, orig_total_lines)
2559 (orig_top_line): Remove from window structure.
2560 (set_window_height, set_window_width, change_window_heights)
2561 (Fdelete_window): Remove prototypes.
2562 (resize_frame_windows): Remove duplicate declaration.
2563
2564 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2565
2566 * window.h (resize_frame_windows, resize_window_check)
2567 (delete_deletable_window, resize_root_window)
2568 (resize_frame_windows): Declare prototypes.
2569
2570 * window.c (resize_window_apply): Make definition be "static" to
2571 match the prototype.
2572
2573 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2574
2575 * window.c: Remove declarations of Qwindow_size_fixed,
2576 window_min_size_1, window_min_size_2, window_min_size,
2577 size_window, window_fixed_size_p, enlarge_window, delete_window.
2578 Remove static from declaration of Qdelete_window, it's
2579 temporarily needed by Fbury_buffer.
2580 (replace_window): Don't assign orig_top_line and
2581 orig_total_lines.
2582 (Fdelete_window, delete_window): Remove. Window deletion is
2583 handled by window.el.
2584 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2585 Replace Fdelete_window calls with calls to Qdelete_window.
2586 (Fdelete_other_windows): Remove. Deleting other windows is
2587 handled by window.el.
2588 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2589 handled in window.el.
2590 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2591 Window minimum sizes are handled in window.el.
2592 (shrink_windows, size_window, set_window_height)
2593 (set_window_width, change_window_heights, window_height)
2594 (window_width, CURBEG, CURSIZE, enlarge_window)
2595 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2596 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2597 handled in window.el.
2598 (make_dummy_parent): Rename to make_parent_window and give it a
2599 second argument horflag.
2600 (make_window): Don't set resize_proportionally any more.
2601 (Fsplit_window): Remove. Windows are split in window.el.
2602 (save_restore_action, save_restore_orig_size)
2603 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2604 Resize mini windows in window.el.
2605 (grow_mini_window, shrink_mini_window): Implement by calling
2606 Qresize_root_window_vertically, resize_window_check and
2607 resize_window_apply.
2608 (saved_window, Fset_window_configuration, save_window_save):
2609 Do not handle orig_top_line, orig_total_lines, and
2610 resize_proportionally.
2611 (window_min_height, window_min_width): Move to window.el.
2612 (keys_of_window): Move bindings for delete-other-windows,
2613 split-window, delete-window and enlarge-window to window.el.
2614
2615 * buffer.c: Temporarily extern Qdelete_window.
2616 (Fbury_buffer): Temporarily call Qdelete_window instead of
2617 Fdelete_window (Fbury_buffer will move to window.el soon).
2618
2619 * frame.c (set_menu_bar_lines_1): Remove code handling
2620 orig_top_line and orig_total_lines.
2621
2622 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2623 set_window_height but set heights directly.
2624 (change_frame_size_1): Use resize_frame_windows.
2625
2626 * xdisp.c (init_xdisp): Don't use set_window_height but set
2627 heights directly.
2628
2629 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2630 Use resize_frame_windows instead of change_window_heights and run
2631 run_window_configuration_change_hook.
2632
2633 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2634 instead of change_window_heights and run
2635 run_window_configuration_change_hook.
2636
2637 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2638
2639 * window.c (replace_window): Rename second argument REPLACEMENT to
2640 NEW. New third argument SETFLAG. Rewrite.
2641 (delete_window, make_dummy_parent): Call replace_window with
2642 third argument 1.
2643 (window_list_1): Move down in code.
2644 (run_window_configuration_change_hook): Move set_buffer part
2645 before select_frame_norecord part in order to unwind correctly.
2646 Rename count1 to count.
2647 (recombine_windows, delete_deletable_window, resize_root_window)
2648 (Fdelete_other_windows_internal)
2649 (Frun_window_configuration_change_hook, make_parent_window)
2650 (resize_window_check, resize_window_apply, Fresize_window_apply)
2651 (resize_frame_windows, Fsplit_window_internal)
2652 (Fdelete_window_internal, Fresize_mini_window_internal):
2653 New functions.
2654 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2655
2656 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2657
2658 * window.h (window): Add some new members to window structure -
2659 normal_lines, normal_cols, new_total, new_normal, clone_number,
2660 splits, nest, prev_buffers, next_buffers.
2661 (WINDOW_TOTAL_SIZE): Move here from window.c.
2662 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2663
2664 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2665 Remove.
2666 (make_dummy_parent): Set new members of windows structure.
2667 (make_window): Move down in code. Handle new members of window
2668 structure.
2669 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2670 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2671 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2672 (Fset_window_prev_buffers, Fwindow_next_buffers)
2673 (Fset_window_next_buffers, Fset_window_clone_number):
2674 New functions.
2675 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2676 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2677 Doc-string fixes.
2678 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2679 Argument WINDOW can be now internal window too.
2680 (Fwindow_use_time): Move up in code.
2681 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2682 Rewrite doc-string.
2683 (Fset_window_configuration, saved_window)
2684 (Fcurrent_window_configuration, save_window_save): Handle new
2685 members of window structure.
2686 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2687 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2688 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2689 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2690 Qget_mru_window, Qresize_root_window,
2691 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2692 Qauto_buffer_name; staticpro them.
2693
2694 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2695
2696 * window.c (Fwindow_total_size, Fwindow_left_column)
2697 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2698 (Fwindow_list_1): New functions.
2699 (window_box_text_cols): Replace with window_body_cols.
2700 (Fwindow_width, Fscroll_left, Fscroll_right):
2701 Use window_body_cols instead of window_box_text_cols.
2702 (delete_window, Fset_window_configuration):
2703 Call delete_all_subwindows with window as argument.
2704 (delete_all_subwindows): Take a window as argument and not a
2705 structure. Rewrite.
2706 (window_loop): Remove handling of GET_LRU_WINDOW and
2707 GET_LARGEST_WINDOW.
2708 (Fget_lru_window, Fget_largest_window): Move to window.el.
2709
2710 * window.h: Extern window_body_cols instead of
2711 window_box_text_cols. delete_all_subwindows now takes a
2712 Lisp_Object as argument.
2713
2714 * indent.c (compute_motion, Fcompute_motion):
2715 Use window_body_cols instead of window_box_text_cols.
2716
2717 * frame.c (delete_frame): Call delete_all_subwindows with root
2718 window as argument.
2719
2720 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2721
2722 * fns.c (Fputhash): Document return value.
2723
2724 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2725
2726 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2727
2728 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2729
2730 Cons<->int and similar integer overflow fixes (Bug#8794).
2731
2732 Check for overflow when converting integer to cons and back.
2733 * charset.c (Fdefine_charset_internal, Fdecode_char):
2734 Use cons_to_unsigned to catch overflow.
2735 (Fencode_char): Use INTEGER_TO_CONS.
2736 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2737 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2738 * data.c (long_to_cons, cons_to_long): Remove.
2739 (cons_to_unsigned, cons_to_signed): New functions.
2740 These signal an error for invalid or out-of-range values.
2741 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2742 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2743 * font.c (Ffont_variation_glyphs):
2744 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2745 * lisp.h: Include <intprops.h>.
2746 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2747 (cons_to_signed, cons_to_unsigned): New decls.
2748 (long_to_cons, cons_to_long): Remove decls.
2749 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2750 (Fprimitive_undo): Use CONS_TO_INTEGER.
2751 * xfns.c (Fx_window_property): Likewise.
2752 * xselect.c: Include <limits.h>.
2753 (x_own_selection, selection_data_to_lisp_data):
2754 Use INTEGER_TO_CONS.
2755 (x_handle_selection_request, x_handle_selection_clear)
2756 (x_get_foreign_selection, Fx_disown_selection_internal)
2757 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2758 (lisp_data_to_selection_data): Use cons_to_unsigned.
2759 (x_fill_property_data): Use cons_to_signed.
2760 Report values out of range.
2761
2762 Check for buffer and string overflow more precisely.
2763 * buffer.h (BUF_BYTES_MAX): New macro.
2764 * lisp.h (STRING_BYTES_MAX): New macro.
2765 * alloc.c (Fmake_string):
2766 * character.c (string_escape_byte8):
2767 * coding.c (coding_alloc_by_realloc):
2768 * doprnt.c (doprnt):
2769 * editfns.c (Fformat):
2770 * eval.c (verror):
2771 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2772 since they may not be the same number.
2773 * editfns.c (Finsert_char):
2774 * fileio.c (Finsert_file_contents):
2775 Likewise for BUF_BYTES_MAX.
2776
2777 * image.c: Use ptrdiff_t, not int, for sizes.
2778 (slurp_file): Switch from int to ptrdiff_t.
2779 All uses changed.
2780 (slurp_file): Check that file size fits in both size_t (for
2781 malloc) and ptrdiff_t (for sanity and safety).
2782
2783 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2784 if b->modtime has its maximal value.
2785
2786 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2787
2788 Don't assume time_t can fit into int.
2789 * buffer.h (struct buffer.modtime): Now time_t, not int.
2790 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2791 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2792
2793 Minor fixes for signed vs unsigned integers.
2794 * character.h (MAYBE_UNIFY_CHAR):
2795 * charset.c (maybe_unify_char):
2796 * keyboard.c (read_char, reorder_modifiers):
2797 XINT -> XFASTINT, since the integer must be nonnegative.
2798 * ftfont.c (ftfont_spec_pattern):
2799 * keymap.c (access_keymap, silly_event_symbol_error):
2800 XUINT -> XFASTINT, since the integer must be nonnegative.
2801 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2802 since it makes no difference and we prefer signed.
2803 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2804 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2805 nonnegative.
2806
2807 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2808
2809 * window.h (Fwindow_frame): Declare.
2810
2811 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2812
2813 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2814 (SPARE_MEMORY): Always define.
2815 (LARGE_REQUEST): Remove.
2816 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2817
2818 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2819
2820 * lisp.h: Move EXFUNS for Fframe_root_window,
2821 Fframe_first_window and Fset_frame_selected_window to window.h.
2822
2823 * window.h: Move EXFUNS for Fframe_root_window,
2824 Fframe_first_window and Fset_frame_selected_window here from
2825 lisp.h.
2826
2827 * frame.c (Fwindow_frame, Fframe_first_window)
2828 (Fframe_root_window, Fframe_selected_window)
2829 (Fset_frame_selected_window): Move to window.c.
2830 (Factive_minibuffer_window): Move to minibuf.c.
2831 (Fother_visible_frames_p): New function.
2832
2833 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2834
2835 * window.c (decode_window, decode_any_window): Move up in code.
2836 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2837 (inhibit_frame_unsplittable): Remove unused variable.
2838 (Fwindow_buffer): Move up and rewrite doc-string.
2839 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2840 (Fwindow_prev): New functions.
2841 (Fwindow_frame): Move here from frame.c. Accept any window as
2842 argument.
2843 (Fframe_root_window, Fframe_first_window)
2844 (Fframe_selected_window): Move here from frame.c. Accept frame
2845 or arbitrary window as argument. Update doc-strings.
2846 (Fminibuffer_window): Move up in code.
2847 (Fwindow_minibuffer_p): Move up in code and simplify.
2848 (Fset_frame_selected_window): Move here from frame.c.
2849 Marginal rewrite.
2850 (Fselected_window, select_window, Fselect_window): Move up in
2851 code. Minor doc-string fixes.
2852
2853 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2854
2855 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2856 Do not assume that spare memory exists; that assumption is valid
2857 only if SYSTEM_MALLOC.
2858 (LARGE_REQUEST): New macro, so that the issue of large requests
2859 is separated from the issue of spare memory.
2860
2861 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2862
2863 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2864 format. (Bug#8806)
2865
2866 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2867
2868 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2869 before statements.
2870
2871 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2872
2873 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2874
2875 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2876
2877 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2878 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2879
2880 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2881
2882 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2883
2884 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2885
2886 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2887 (x_clipboard_manager_save): Add return value.
2888 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2889 New error handlers.
2890 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2891 Obey Vx_select_enable_clipboard_manager. Catch errors in
2892 x_clipboard_manager_save (Bug#8779).
2893 (Vx_select_enable_clipboard_manager): New variable.
2894 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2895
2896 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2897
2898 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2899
2900 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2901
2902 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2903 in the current matrix if keep_current_p is non-zero.
2904
2905 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2906
2907 * bidi.c (bidi_level_of_next_char): Fix last change.
2908
2909 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2910
2911 Support bidi reordering of text covered by display properties.
2912
2913 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2914 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2915 (bidi_cache_search, bidi_cache_iterator_state)
2916 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2917 (bidi_level_of_next_char, bidi_move_to_visually_next):
2918 Support character positions inside a run of characters covered by a
2919 display string.
2920 (bidi_paragraph_init, bidi_resolve_explicit_1)
2921 (bidi_level_of_next_char): Call bidi_fetch_char and
2922 bidi_fetch_char_advance instead of FETCH_CHAR and
2923 FETCH_CHAR_ADVANCE.
2924 (bidi_init_it): Initialize new members.
2925 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2926 definitions.
2927 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2928 instead of using explicit *_CHAR codes.
2929 (bidi_resolve_explicit, bidi_resolve_weak):
2930 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2931 bidirectional text is supported only in multibyte buffers.
2932 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2933 it to initialize the frame_window_p member of struct bidi_it.
2934 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2935 (bidi_resolve_explicit, bidi_resolve_weak)
2936 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2937 bidi_it->nchars is non-positive.
2938 (bidi_level_of_next_char): Don't try to lookup the cache for the
2939 next/previous character if nothing is cached there yet, or if we
2940 were just reseat()'ed to a new position.
2941
2942 * xdisp.c (set_cursor_from_row): Set start and stop points
2943 according to the row's direction when priming the loop that looks
2944 for the glyph on which to display cursor.
2945 (single_display_spec_intangible_p): Function deleted.
2946 (display_prop_intangible_p): Reimplement to call
2947 handle_display_spec instead of single_display_spec_intangible_p.
2948 Accept 3 additional arguments needed by handle_display_spec.
2949 This fixes incorrect cursor motion across display property with complex
2950 values: lists, `(when COND...)' forms, etc.
2951 (single_display_spec_string_p): Support property values that are
2952 lists with the argument STRING its top-level element.
2953 (display_prop_string_p): Fix the condition for processing a
2954 property that is a list to be consistent with handle_display_spec.
2955 (handle_display_spec): New function, refactored from the
2956 last portion of handle_display_prop.
2957 (compute_display_string_pos): Accept additional argument
2958 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2959 value of a `display' property is a "replacing spec".
2960 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2961 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2962 the display property, but just return a value indicating whether
2963 the display property will replace the characters it covers.
2964 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2965 frame_window_p members of struct bidi_it.
2966 (compute_display_string_pos, compute_display_string_end):
2967 New functions.
2968 (push_it): Accept second argument POSITION, where pop_it should
2969 jump to continue iteration.
2970 (reseat_1): Initialize bidi_it.disp_pos.
2971
2972 * keyboard.c (adjust_point_for_property): Adjust the call to
2973 display_prop_intangible_p to its new signature.
2974
2975 * dispextern.h (struct bidi_it): New member frame_window_p.
2976 (bidi_init_it): Update prototypes.
2977 (display_prop_intangible_p): Update prototype.
2978 (compute_display_string_pos, compute_display_string_end):
2979 Declare prototypes.
2980 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2981 EMACS_INT.
2982
2983 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2984
2985 Malloc failure behavior now depends on size of allocation.
2986 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2987 * lisp.h: Change signatures accordingly.
2988 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2989 All callers changed. (Bug#8762)
2990
2991 * gnutls.c: Use Emacs's memory allocators.
2992 Without this change, the gnutls library would invoke malloc etc.
2993 directly, which causes problems on non-SYNC_INPUT hosts, and which
2994 runs afoul of improving memory_full behavior. (Bug#8761)
2995 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2996 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2997 xfree instead of the default malloc, realloc, free.
2998 (Fgnutls_boot): No need to check for memory allocation failure,
2999 since xmalloc does that for us.
3000
3001 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3002 * category.c (hash_get_category_set):
3003 * ccl.c (ccl_driver):
3004 * charset.c (Fdefine_charset_internal):
3005 * charset.h (struct charset.hash_index):
3006 * composite.c (get_composition_id, gstring_lookup_cache)
3007 (composition_gstring_put_cache):
3008 * composite.h (struct composition.hash_index):
3009 * dispextern.h (struct image.hash):
3010 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3011 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3012 (hashfn_equal, hashfn_user_defined, make_hash_table)
3013 (maybe_resize_hash_table, hash_lookup, hash_put)
3014 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3015 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3016 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3017 * image.c (make_image, search_image_cache, lookup_image)
3018 (xpm_put_color_table_h):
3019 * lisp.h (struct Lisp_Hash_Table):
3020 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3021 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3022 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3023 * alloc.c (allocate_vectorlike):
3024 Check for overflow in vector size calculations.
3025 * ccl.c (ccl_driver):
3026 Check for overflow when converting EMACS_INT to int.
3027 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3028 need to be updated by these changes.
3029 * fns.c (make_hash_table, maybe_resize_hash_table):
3030 Check for integer overflow with large hash tables.
3031 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3032 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3033 (SXHASH_REDUCE): New macro.
3034 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3035 Use it instead of discarding useful hash info with large hash values.
3036 (sxhash_float): New function.
3037 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3038 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3039 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3040 Rewrite to use FIXNUM_BITS, as this simplifies things.
3041 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3042 Adjust signatures to match updated version of code.
3043 (consing_since_gc): Now EMACS_INT, since a single hash table can
3044 use more than INT_MAX bytes.
3045
3046 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3047
3048 Make it possible to build with GCC-4.6+ -O2 -flto.
3049
3050 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3051
3052 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3053
3054 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3055 Call minibuffer-inactive-mode.
3056
3057 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3058
3059 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3060 Update dependencies.
3061
3062 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3063
3064 * data.c (init_data): Remove code for UTS, this system is not
3065 supported anymore.
3066
3067 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3068
3069 Don't force ./temacs to start in terminal mode.
3070
3071 * frame.c (make_initial_frame): Initialize faces in all cases, not
3072 only when CANNOT_DUMP is defined.
3073 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3074
3075 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3076
3077 * dispnew.c (add_window_display_history): Use const for the string
3078 pointer. Remove declaration, not needed.
3079
3080 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3081
3082 Use 'inline', not 'INLINE'.
3083 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3084 * alloc.c, fontset.c (INLINE): Remove.
3085 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3086 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3087 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3088 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3089 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3090
3091 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3092
3093 Make it possible to run ./temacs.
3094
3095 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3096 syms_of_callproc does the same thing. Remove test for
3097 "initialized", do it in the caller.
3098 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3099
3100 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3101
3102 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3103 (read_minibuf): Use get_minibuffer.
3104 (syms_of_minibuf): Use DEFSYM.
3105 (Qmetadata): New var.
3106 * data.c (Qbuffer): Don't make it static.
3107 (syms_of_data): Use DEFSYM.
3108
3109 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3110
3111 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3112 (CCL_CODE_MIN): New macro.
3113
3114 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3115
3116 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3117
3118 * eval.c (Qdebug): Now static.
3119 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3120 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3121 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3122
3123 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3124
3125 * image.c: Various fixes to ImageMagick code comments.
3126 (Fimagemagick_types): Doc fix.
3127
3128 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3129
3130 Minor fixes prompted by GCC 4.6.0 warnings.
3131
3132 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3133
3134 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3135 (x_clipboard_manager_save_all): Move extern decl to ...
3136 * xterm.h: ... here, so that it can be checked for consistency.
3137
3138 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3139
3140 * xselect.c (x_clipboard_manager_save_frame)
3141 (x_clipboard_manager_save_all): New functions.
3142 (Fx_clipboard_manager_save): Lisp function deleted.
3143
3144 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3145 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3146
3147 * xterm.h: Update prototype.
3148
3149 2011-05-28 William Xu <william.xwl@gmail.com>
3150
3151 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3152 exiting (Bug#8239).
3153
3154 2011-05-28 Jim Meyering <meyering@redhat.com>
3155
3156 Avoid a sign-extension bug in crypto_hash_function.
3157 * fns.c (to_uchar): Define.
3158 (crypto_hash_function): Use it to convert some newly-signed
3159 variables to unsigned, to avoid sign-extension bugs. For example,
3160 without this change, (md5 "truc") would evaluate to
3161 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3162 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3163 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3164
3165 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3166
3167 Integer overflow fixes.
3168
3169 * dbusbind.c: Serial number integer overflow fixes.
3170 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3171 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3172 to hold a serial number that is too large for a fixnum.
3173 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3174 Check for serial numbers out of range. Decode any serial number
3175 that was so large that it became a float. (Bug#8722)
3176
3177 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3178 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3179 Use XFASTINT rather than XUINT when numbers are nonnegative.
3180 (xd_append_arg, Fdbus_method_return_internal):
3181 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3182 arguments, check that Lisp number is nonnegative, rather than
3183 silently wrapping negative numbers around. (Bug#8722)
3184 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3185 (Bug#8722)
3186
3187 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3188
3189 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3190
3191 ccl: add integer overflow checks
3192 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3193 (IN_INT_RANGE): New macros.
3194 (ccl_driver): Use them to check for integer overflow when
3195 decoding a CCL program. Many of the new checks are whether XINT (x)
3196 fits in int; it doesn't always, on 64-bit hosts. The new version
3197 doesn't catch all possible integer overflows, but it's an
3198 improvement. (Bug#8719)
3199
3200 * alloc.c (make_event_array): Use XINT, not XUINT.
3201 There's no need for unsigned here.
3202
3203 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3204 This follows up to the 2011-05-06 change that substituted uintptr_t
3205 for EMACS_INT. This case wasn't caught back then.
3206
3207 Rework Fformat to avoid integer overflow issues.
3208 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3209 now (part of C89). Include <verify.h>.
3210 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3211 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3212 (Fformat): Avoid the prepass trying to compute sizes; it was only
3213 approximate and thus did not catch overflow reliably. Instead, walk
3214 through the format just once, formatting and computing sizes as we go,
3215 checking for integer overflow at every step, and allocating a larger
3216 buffer as needed. Keep track separately whether the format is
3217 multibyte. Keep only the most-recently calculated precision, rather
3218 than them all. Record whether each argument has been converted to
3219 string. Use EMACS_INT, not int, for byte and char and arg counts.
3220 Support field widths and precisions larger than INT_MAX. Avoid
3221 sprintf's undefined behavior with conversion specifications such as %#d
3222 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3223 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3224 formatting out-of-range floating point numbers with int
3225 formats. (Bug#8668)
3226
3227 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3228
3229 * data.c: Avoid integer truncation in expressions involving floats.
3230 * data.c: Include <intprops.h>.
3231 (arith_driver): When there's an integer overflow in an expression
3232 involving floating point, convert the integers to floating point
3233 so that the resulting value does not suffer from catastrophic
3234 integer truncation. For example, on a 64-bit host (* 4
3235 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3236 Do not rely on undefined behavior after integer overflow.
3237
3238 merge count_size_as_multibyte, parse_str_to_multibyte
3239 * character.c, character.h (count_size_as_multibyte):
3240 Rename from parse_str_to_multibyte; all uses changed.
3241 Check for integer overflow.
3242 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3243 since it's now a duplicate of the other. This is more of
3244 a character than a buffer op, so better that it's in character.c.
3245 * fns.c, print.c: Adjust to above changes.
3246
3247 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3248
3249 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3250
3251 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3252
3253 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3254 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3255 (x_clipboard_manager_save): Now static.
3256 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3257
3258 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3259 (crypto_hash_function): Now static.
3260 Fix pointer signedness problems. Avoid unnecessary initializations.
3261
3262 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3263
3264 * termhooks.h (Vselection_alist): Make it terminal-local.
3265
3266 * terminal.c (create_terminal): Initialize it.
3267
3268 * xselect.c: Support for clipboard managers.
3269 (Vselection_alist): Move to termhooks.h as terminal-local var.
3270 (LOCAL_SELECTION): New macro.
3271 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3272 (symbol_to_x_atom): Remove gratuitous arg.
3273 (x_handle_selection_request, lisp_data_to_selection_data)
3274 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3275 (x_own_selection, x_get_local_selection, x_convert_selection):
3276 New arg, specifying work frame. Use terminal-local Vselection_alist.
3277 (some_frame_on_display): Delete unused function.
3278 (Fx_own_selection_internal, Fx_get_selection_internal)
3279 (Fx_disown_selection_internal, Fx_selection_owner_p)
3280 (Fx_selection_exists_p): New optional frame arg.
3281 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3282 (x_handle_selection_clear): Don't treat other terminals with the
3283 same keyboard specially. Use the terminal-local Vselection_alist.
3284 (x_clear_frame_selections): Use Frun_hook_with_args.
3285
3286 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3287
3288 * xterm.h: Add support for those atoms.
3289
3290 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3291
3292 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3293 (converted_selections, conversion_fail_tag): New global variables.
3294 (x_selection_request_lisp_error): Free the above.
3295 (x_get_local_selection): Remove unnecessary code.
3296 (x_reply_selection_request): Args changed; handle arbitrary array
3297 of converted selections stored in converted_selections.
3298 Separate the XChangeProperty and SelectionNotify steps.
3299 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3300 (x_convert_selection): New function.
3301 (x_handle_selection_event): Simplify.
3302 (x_get_foreign_selection): Don't ignore incoming requests while
3303 waiting for an answer; this will fail when we implement
3304 SAVE_TARGETS, and seems unnecessary anyway.
3305 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3306 (Vx_sent_selection_functions): Doc fix.
3307
3308 2011-05-26 Leo Liu <sdl.web@gmail.com>
3309
3310 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3311
3312 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3313
3314 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3315
3316 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3317 for fringe update if it has periodic bitmap.
3318 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3319 and fringe_bitmap_periodic_p.
3320
3321 * fringe.c (get_fringe_bitmap_data): New function.
3322 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3323 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3324 row. Mark glyph row for fringe update if periodicity changed.
3325
3326 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3327 for fringe update unless it has periodic bitmap.
3328
3329 2011-05-25 Kenichi Handa <handa@m17n.org>
3330
3331 * xdisp.c (get_next_display_element): Set correct it->face_id for
3332 a static composition.
3333
3334 2011-05-24 Leo Liu <sdl.web@gmail.com>
3335
3336 * deps.mk (fns.o):
3337 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3338
3339 * fns.c (crypto_hash_function, Fsha1): New function.
3340 (Fmd5): Use crypto_hash_function.
3341 (syms_of_fns): Add Ssha1.
3342
3343 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 * gnutls.c: Remove unused macros.
3346 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3347 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3348 Remove macros that are defined and never used.
3349 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3350
3351 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3352
3353 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3354 (Fx_get_selection_internal): Minor cleanup.
3355 (Fx_own_selection_internal): Rename arguments for consistency with
3356 select.el.
3357
3358 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3359
3360 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3361
3362 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3363
3364 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3365
3366 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3367
3368 * dispnew.c (scrolling_window): Don't exclude the case that the
3369 last enabled row in the desired matrix touches the bottom boundary.
3370
3371 2011-05-21 Glenn Morris <rgm@gnu.org>
3372
3373 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3374 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3375 and add some more files.
3376
3377 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3378
3379 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3380 report_file_error introduced by the change from 2011-05-07.
3381
3382 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 * systime.h (Time): Define only if emacs is defined.
3385 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3386 where the include path doesn't have X11/X.h by default. See
3387 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3388
3389 2011-05-20 Kenichi Handa <handa@m17n.org>
3390
3391 * composite.c (find_automatic_composition): Fix previous change.
3392
3393 2011-05-20 Glenn Morris <rgm@gnu.org>
3394
3395 * lisp.mk: New file, split from Makefile.in.
3396 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3397 (shortlisp): Remove.
3398 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3399
3400 2011-05-19 Glenn Morris <rgm@gnu.org>
3401
3402 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3403 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3404 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3405 (lisp): Set the order to that of loadup.el.
3406 (shortlisp): Make it a copy of $lisp.
3407 (SOME_MACHINE_LISP): Remove.
3408 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3409 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3410
3411 2011-05-18 Kenichi Handa <handa@m17n.org>
3412
3413 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3414 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3415 (find_automatic_composition): Mostly rewrite for efficiency.
3416
3417 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3418
3419 * makefile.w32-in: Update dependencies.
3420
3421 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3422
3423 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3424 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3425
3426 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3427
3428 Fix some integer overflow issues, such as string length overflow.
3429
3430 * insdel.c (count_size_as_multibyte): Check for string overflow.
3431
3432 * character.c (lisp_string_width): Check for string overflow.
3433 Use EMACS_INT, not int, for string indexes and lengths; in
3434 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3435 the resulting string length overflows an EMACS_INT; instead,
3436 report a string overflow if no precision given. When checking for
3437 precision exhaustion, use a check that cannot possibly have
3438 integer overflow. (Bug#8675)
3439 * character.h (lisp_string_width): Adjust to new signature.
3440
3441 * alloc.c (string_overflow): New function.
3442 (Fmake_string): Use it. This doesn't change behavior, but saves
3443 a few bytes and will simplify future changes.
3444 * character.c (string_escape_byte8): Likewise.
3445 * lisp.h (string_overflow): New decl.
3446
3447 Fixups, following up to the user-interface timestamp change.
3448 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3449 for UI timestamps, instead of unsigned long.
3450 * msdos.c (mouse_get_pos): Likewise.
3451 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3452 * w32gui.h (Time): Define by including "systime.h" rather than by
3453 declaring it ourselves. (Bug#8664)
3454
3455 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3456 * image.c (clear_image_cache): Likewise.
3457
3458 * term.c (term_mouse_position): Don't assume time_t wraparound.
3459
3460 Be more systematic about user-interface timestamps.
3461 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3462 and sometimes 'EMACS_UINT', to represent these timestamps.
3463 This change causes it to use 'Time' uniformly, as that's what X uses.
3464 This makes the code easier to follow, and makes it easier to catch
3465 integer overflow bugs such as Bug#8664.
3466 * frame.c (Fmouse_position, Fmouse_pixel_position):
3467 Use Time, not unsigned long, for user-interface timestamps.
3468 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3469 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3470 * keyboard.h (last_event_timestamp): Likewise.
3471 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3472 * menu.h (xmenu_show): Likewise.
3473 * term.c (term_mouse_position): Likewise.
3474 * termhooks.h (struct input_event.timestamp): Likewise.
3475 (struct terminal.mouse_position_hook): Likewise.
3476 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3477 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3478 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3479 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3480 what it was before.
3481 * menu.h, termhooks.h: Include "systime.h", for Time.
3482
3483 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3484 Don't assume that the difference between two unsigned long values
3485 can fit into an integer. At this point, we know button_down_time
3486 <= event->timestamp, so the difference must be nonnegative, so
3487 there's no need to cast the result if double-click-time is
3488 nonnegative, as it should be; check that it's nonnegative, just in
3489 case. This bug is triggered when events are more than 2**31 ms
3490 apart (about 25 days). (Bug#8664)
3491
3492 * xselect.c (last_event_timestamp): Remove duplicate decl.
3493 (x_own_selection): Remove needless cast to unsigned long.
3494
3495 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3496 that always fit in int. Use a sentinel instead of a counter, to
3497 avoid a temp and to allay GCC's concerns about possible int overflow.
3498 * frame.h (struct frame): Use int for menu_bar_items_used
3499 instead of EMACS_INT, since it always fits in int.
3500
3501 * menu.c (grow_menu_items): Check for int overflow.
3502
3503 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3504
3505 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3506 Before, the code was not consistent. These values cannot exceed
3507 2**31 - 1 so there's no need to make them unsigned.
3508 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3509 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3510 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3511 as modifiers.
3512 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3513
3514 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3515 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3516 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3517 presumably because the widths might not match.
3518
3519 * window.c (size_window): Avoid needless test at loop start.
3520
3521 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3522
3523 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3524
3525 2011-05-12 Drew Adams <drew.adams@oracle.com>
3526
3527 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3528
3529 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3530
3531 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3532 `width' to `bar_area_x' and `bar_area_width', respectively.
3533 (x_scroll_run): Take account of fringe background extension.
3534
3535 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3536 Rename local vars `left' and `width' to `bar_area_x' and
3537 `bar_area_width', respectively.
3538 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3539 background extension.
3540
3541 2011-05-10 Jim Meyering <meyering@redhat.com>
3542
3543 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3544
3545 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3546
3547 * image.c (Finit_image_library): Return t for built-in image types,
3548 like pbm and xbm. (Bug#8640)
3549
3550 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3551
3552 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3553
3554 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3555
3556 * w32console.c (Fset_screen_color): Doc fix.
3557 (Fget_screen_color): New function.
3558 (syms_of_ntterm): Defsubr it.
3559
3560 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3561 unlink the temporary file if Fcall_process didn't create it in the
3562 first place.
3563 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3564 child process will be redirected to a file specified with `:file'.
3565 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3566 cue to call_process_cleanup not to close that handle.
3567
3568 2011-05-07 Ben Key <bkey76@gmail.com>
3569
3570 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3571 one of two shell specific rules, either bootstrap-temacs-CMD or
3572 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3573 to the previous implementation of the bootstrap-temacs rule.
3574 The bootstrap-temacs-CMD rule is similar to the previous
3575 implementation of the bootstrap-temacs rule except that it
3576 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3577 variable.
3578
3579 These changes, along with some changes to nt/configure.bat,
3580 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3581 earlier fix to add support for --cflags and --ldflags options
3582 that include quotes so that it works whether make uses cmd or
3583 sh as the shell.
3584
3585 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3586
3587 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3588 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3589 is a constant.
3590 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3591 a string. Handle both cases.
3592 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3593 (Fdbus_register_method): Use Qinvalid_function.
3594
3595 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3596
3597 * makefile.w32-in: Update dependencies.
3598 (LISP_H): Add inttypes.h and stdin.h.
3599 (PROCESS_H): Add unistd.h.
3600
3601 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3602
3603 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3604 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3605
3606 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3607
3608 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3609
3610 * term.c (vfatal): Remove stray call to va_end.
3611 It's not needed and the C Standard doesn't allow it here anyway.
3612
3613 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3614 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3615
3616 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3617 bytes.
3618
3619 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3620
3621 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3622
3623 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3624
3625 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3626
3627 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3628
3629 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3630 * charset.c (Fdefine_charset_internal): Don't initialize
3631 charset.code_space[15]. The value was garbage, on hosts with
3632 32-bit int (Bug#8600).
3633
3634 * lread.c (read_integer): Be more consistent with string-to-number.
3635 Use string_to_number to do the actual conversion; this avoids
3636 rounding errors and fixes some other screwups. Without this fix,
3637 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3638 (digit_to_number): Move earlier, for benefit of read_integer.
3639 Return -1 if the digit is out of range for the base, -2 if it is
3640 not a digit in any supported base. (Bug#8602)
3641
3642 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3643
3644 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3645 to match comment at start of function. This also removes a
3646 GCC warning about overflow in a 32+64-bit port.
3647
3648 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3649
3650 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3651 Reported by Stefan Monnier in
3652 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3653 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3654 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3655
3656 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3657 (EMACS_UINTPTR): Likewise, with uintptr_t.
3658
3659 * lisp.h: Prefer 64-bit EMACS_INT if available.
3660 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3661 on 32-bit hosts that have 64-bit int, so that they can access
3662 large files.
3663 However, temporarily disable this change unless the temporary
3664 symbol WIDE_EMACS_INT is defined.
3665
3666 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3667
3668 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3669 This removes an assumption that EMACS_INT and long are the same
3670 width as pointers. The assumption is true for Emacs porting targets
3671 now, but we want to make other targets possible.
3672 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3673 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3674 In the rest of the code, change types of integers that hold casted
3675 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3676 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3677 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3678 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3679 No need to cast type when ORing.
3680 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3681 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3682 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3683 assume EMACS_INT is the same width as char *.
3684 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3685 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3686 Remove no-longer-needed casts.
3687 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3688 (xg_tool_bar_help_callback, xg_make_tool_item):
3689 Use EMACS_INTPTR to hold an integer
3690 that will be cast to void *; this can avoid a GCC warning
3691 if EMACS_INT is not the same width as void *.
3692 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3693 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3694 (current_message_1, set_message_1):
3695 Use a local to convert to proper width without a cast.
3696 * xmenu.c (dialog_selection_callback): Likewise.
3697
3698 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3699 Also, don't assume VALBITS / RAND_BITS is less than 5,
3700 and don't rely on undefined behavior when shifting a 1 left into
3701 the sign bit.
3702 * lisp.h (get_random): Change signature to match.
3703
3704 * lread.c (hash_string): Use size_t, not int, for hash computation.
3705 Normally we prefer signed values; but hashing is special, because
3706 it's better to use unsigned division on hash table sizes so that
3707 the remainder is nonnegative. Also, size_t is the natural width
3708 for hashing into memory. The previous code used 'int', which doesn't
3709 retain enough info to hash well into very large tables.
3710 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3711
3712 * dbusbind.c: Don't possibly lose pointer info when converting.
3713 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3714 Use XPNTR rather than XHASH, so that the high-order bits of
3715 the pointer aren't lost when converting through void *.
3716
3717 * eval.c (Fautoload): Don't double-shift a pointer.
3718
3719 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3720
3721 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3722
3723 * gnutls.c (DEF_GNUTLS_FN):
3724 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3725
3726 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3727
3728 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3729 marker. (Bug#8610)
3730
3731 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3732
3733 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3734 New version that can reserve upto 2GB of heap space.
3735
3736 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3737
3738 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3739
3740 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3741
3742 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3743 `gnutls_certificate_set_x509_key_file'.
3744
3745 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3746
3747 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3748 Update dependencies.
3749
3750 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3751
3752 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3753 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3754 Remove unused parameter `fildes'.
3755 * process.c (read_process_output, send_process): Don't pass it.
3756
3757 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3758
3759 Fix previous change: the library cache is defined in w32.c.
3760 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3761 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3762
3763 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3764
3765 Implement dynamic loading of GnuTLS on Windows.
3766
3767 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3768 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3769 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3770 Declare.
3771
3772 * gnutls.c (Qgnutls_dll): Define.
3773 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3774 (gnutls_*): Declare function pointers.
3775 (init_gnutls_functions): New function to initialize function pointers.
3776 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3777 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3778 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3779 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3780 (emacs_gnutls_write, emacs_gnutls_read)
3781 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3782 (Fgnutls_available_p): New function.
3783 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3784 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3785 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3786
3787 * image.c: Include w32.h.
3788 (Vimage_type_cache): Delete.
3789 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3790 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3791 (w32_delayed_load): Move to w32.c.
3792
3793 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3794
3795 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3796 (w32_delayed_load): Move from image.c. When loading a library, record
3797 its filename in the :loaded-from property of the library id.
3798 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3799 Initialize and staticpro them.
3800 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3801
3802 * process.c: Include lisp.h before w32.h, not after.
3803 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3804 instead of gnutls_record_check_pending.
3805
3806 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3807
3808 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3809
3810 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3811 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3812 as passed in.
3813
3814 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3815
3816 * xterm.c (x_set_frame_alpha): Do not set property on anything
3817 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3818
3819 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3820
3821 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3822
3823 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3824
3825 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3826 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3827 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3828 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3829 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3830 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3831 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3832 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3833 (Qgnutls_bootprop_callbacks_verify): Make static.
3834
3835 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3836
3837 * callproc.c: Indentation fixup.
3838
3839 * sysdep.c (wait_for_termination_1): Make static.
3840 (wait_for_termination, interruptible_wait_for_termination):
3841 Move after wait_for_termination_1.
3842
3843 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3844
3845 * sysdep.c (interruptible_wait_for_termination): New function
3846 which is like wait_for_termination, but allows keyboard
3847 interruptions.
3848
3849 * callproc.c (Fcall_process): Add (:file "file") as an option for
3850 the STDOUT buffer.
3851 (Fcall_process_region): Ditto.
3852
3853 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3854
3855 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3856 rather than `XVECTOR (FOO)->size'.
3857
3858 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3859 inttypes.h, as a gnulib replacement is used if it not available in
3860 system headers.
3861
3862 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3863
3864 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3865 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3866 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3867
3868 * coding.c (coding_alloc_by_realloc): Error out if destination
3869 will grow beyond MOST_POSITIVE_FIXNUM.
3870 (decode_coding_emacs_mule): Abort if there isn't enough place in
3871 charbuf for the composition carryover bytes. Reserve an extra
3872 space for up to 2 characters produced in a loop.
3873 (decode_coding_iso_2022): Abort if there isn't enough place in
3874 charbuf for the composition carryover bytes.
3875
3876 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3877
3878 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3879 aborting when %lld or %lll format is passed.
3880 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3881 %llo or %llx format is passed. (Bug#8545)
3882
3883 * window.c (window_scroll_line_based): Use a marker instead of
3884 simple variables to record original value of point. (Bug#7952)
3885
3886 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3887 produced by %s or %c overflows available buffer space. (Bug#8545)
3888
3889 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3890
3891 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3892 (SIZE_MAX): Move defn after all includes, as they might #define it.
3893
3894 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3895
3896 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3897
3898 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3899
3900 * keyboard.c (Qdelayed_warnings_hook): Define.
3901 (command_loop_1): Run `delayed-warnings-hook'
3902 if Vdelayed_warnings_list is non-nil.
3903 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3904 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3905
3906 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3907
3908 * doprnt.c (doprnt): Don't return value smaller than the buffer
3909 size if the message was truncated. (Bug#8545).
3910
3911 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3912
3913 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3914 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3915
3916 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3917
3918 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3919
3920 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3921
3922 * makefile.w32-in: Update dependencies.
3923
3924 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3925
3926 Improve `doprnt' and its usage. (Bug#8545)
3927 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3928 `format_end'. Remove support for %l as a conversion specifier.
3929 Don't use xrealloc. Improve diagnostics when the %l size modifier
3930 is used. Update the commentary.
3931
3932 * eval.c (verror): Simplify calculation of size_t.
3933
3934 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3935 messages.
3936
3937 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3938
3939 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3940 change.
3941
3942 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3943
3944 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3945 This makes this file independent of the recent pseudovector change.
3946
3947 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3948
3949 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3950
3951 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3952 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3953 Remove unused local.
3954 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3955
3956 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3957 GCC 4.6.0 optimizes based on type-based alias analysis.
3958 For example, if b is of type struct buffer * and v of type struct
3959 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3960 != &v->size, and therefore "v->size = 1; b->size = 2; return
3961 v->size;" must therefore return 1. This assumption is incorrect
3962 for Emacs, since it type-puns struct Lisp_Vector * with many other
3963 types. To fix this problem, this patch adds a new type struct
3964 vectorlike_header that documents the constraints on layout of vectors
3965 and pseudovectors, and helps optimizing compilers not get fooled
3966 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3967 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3968 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3969 the size member.
3970 (XSETPVECTYPE): Rewrite in terms of new macro.
3971 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3972 This is a bit clearer, and further avoids the possibility of
3973 undesirable aliasing.
3974 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3975 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3976 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3977 since Lisp_Subr is a special case (no "next" field).
3978 (ASIZE): Now uses header.size rather than size.
3979 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3980 to avoid the hassle of writing XVECTOR (foo)->header.size.
3981 (struct vectorlike_header): New type.
3982 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3983 object, to help avoid aliasing.
3984 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3985 (SUBRP): Likewise, since Lisp_Subr is a special case.
3986 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3987 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3988 (struct Lisp_Hash_Table): Combine first two members into a single
3989 struct vectorlike_header member. All uses of "size" and "next" members
3990 changed to be "header.size" and "header.next".
3991 * buffer.h (struct buffer): Likewise.
3992 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3993 * frame.h (struct frame): Likewise.
3994 * process.h (struct Lisp_Process): Likewise.
3995 * termhooks.h (struct terminal): Likewise.
3996 * window.c (struct save_window_data, struct saved_window): Likewise.
3997 * window.h (struct window): Likewise.
3998 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3999 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4000 * buffer.c (init_buffer_once): Likewise.
4001 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4002 special case.
4003 * process.c (Fformat_network_address): Use local var for size,
4004 for brevity.
4005
4006 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4007
4008 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4009 * data.c (atof): Remove decl; no longer used or needed.
4010 (digit_to_number): Move to lread.c.
4011 (Fstring_to_number): Use new string_to_number function, to be
4012 consistent with how the Lisp reader treats infinities and NaNs.
4013 Do not assume that floating-point numbers represent EMACS_INT
4014 without losing information; this is not true on most 64-bit hosts.
4015 Avoid double-rounding errors, by insisting on integers when
4016 parsing non-base-10 numbers, as the documentation specifies.
4017 * lisp.h (string_to_number): New decl, replacing ...
4018 (isfloat_string): Remove.
4019 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4020 (read1): Do not accept +. and -. as integers; this
4021 appears to have been a coding error. Similarly, do not accept
4022 strings like +-1e0 as floating point numbers. Do not report
4023 overflow for integer overflows unless the base is not 10 which
4024 means we have no simple and reliable way to continue.
4025 Break out the floating-point parsing into a new
4026 function string_to_number, so that Fstring_to_number parses
4027 floating point numbers consistently with the Lisp reader.
4028 (digit_to_number): Move here from data.c. Make it static inline.
4029 (E_CHAR, EXP_INT): Remove, replacing with ...
4030 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4031 (string_to_number): New function, replacing isfloat_string.
4032 This function checks for valid syntax and produces the resulting
4033 Lisp float number too. Rework it so that string-to-number
4034 no longer mishandles examples like "1.0e+". Use strtoumax,
4035 so that overflow for non-base-10 numbers is reported only when
4036 there's no portable and simple way to convert to floating point.
4037
4038 * textprop.c (set_text_properties_1): Rewrite for clarity,
4039 and to avoid GCC warning about integer overflow.
4040
4041 * intervals.h (struct interval): Use EMACS_INT for members
4042 where EMACS_UINT might cause problems. See
4043 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4044 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4045 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4046 All uses changed.
4047 (offset_intervals): Tell GCC not to worry about length overflow
4048 when negating a negative length.
4049
4050 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4051 (overrun_check_free): Likewise.
4052
4053 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4054 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4055 word size.
4056
4057 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4058 (gnutls_make_error): Rename local to avoid shadowing.
4059 (gnutls_emacs_global_deinit): ifdef out; not used.
4060 (Fgnutls_boot): Use const for pointer to readonly storage.
4061 Comment out unused local. Fix pointer signedness problems.
4062
4063 * lread.c (openp): Don't stuff size_t into an 'int'.
4064 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4065 about possible signed overflow.
4066
4067 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4068 (GDK_KEY_g): Don't define if already defined.
4069 (xg_prepare_tooltip): Avoid pointer signedness problem.
4070 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4071
4072 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4073 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4074
4075 * xfns.c (Fx_window_property): Simplify a bit,
4076 to make a bit faster and to avoid GCC 4.6.0 warning.
4077 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4078
4079 * fns.c (internal_equal): Don't assume size_t fits in int.
4080
4081 * alloc.c (compact_small_strings): Tighten assertion a little.
4082
4083 Replace pEd with more-general pI, and fix some printf arg casts.
4084 * lisp.h (pI): New macro, generalizing old pEd macro to other
4085 conversion specifiers. For example, use "...%"pI"d..." rather
4086 than "...%"pEd"...".
4087 (pEd): Remove. All uses replaced with similar uses of pI.
4088 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4089 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4090 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4091 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4092 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4093 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4094 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4095 64-bit hosts.
4096 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4097 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4098 * print.c (safe_debug_print, print_object): Likewise.
4099 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4100 to int.
4101 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4102 avoiding the 0 flag, which is not portable.
4103 * process.c (Fmake_network_process): Use pI to avoid cast.
4104 * region-cache.c (pp_cache): Likewise.
4105 * xdisp.c (decode_mode_spec): Likewise.
4106 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4107 behavior on 64-bit hosts with printf arg.
4108 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4109 (x_stop_queuing_selection_requests): Likewise.
4110 (x_get_window_property): Don't truncate byte count to an 'int'
4111 when tracing.
4112
4113 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4114 here, since it parses constructs like leading '-' and spaces,
4115 which are not wanted; and it overflows with large numbers.
4116 Instead, simply match F[0-9]+, which is what is wanted anyway.
4117
4118 * alloc.c: Remove unportable assumptions about struct layout.
4119 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4120 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4121 (allocate_vectorlike, make_pure_vector): Use the new macros,
4122 plus offsetof, to remove unportable assumptions about struct layout.
4123 These assumptions hold on all porting targets that I know of, but
4124 they are not guaranteed, they're easy to remove, and removing them
4125 makes further changes easier.
4126
4127 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4128 This doesn't fix a bug but makes the code clearer.
4129 (string_overrun_cookie): Now const. Use initializers that
4130 don't formally overflow signed char, to avoid warnings.
4131 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4132 can cause Emacs to crash when string overrun checking is enabled.
4133 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4134 multiple of sizeof (EMACS_INT); it need not be, if
4135 alignof(EMACS_INT) < sizeof (EMACS_INT).
4136 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4137
4138 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4139
4140 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4141
4142 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4143
4144 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4145 supposed to be handshaking. (Bug#8556)
4146 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4147
4148 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4149
4150 * lisp.h (Qdebug): List symbol.
4151 * eval.c (Qdebug): Restore global linkage.
4152 * keyboard.c (debug-on-event): New variable.
4153 (handle_user_signal): Break into debugger when debug-on-event
4154 matches the current signal symbol.
4155
4156 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4157
4158 * alloc.c (check_sblock, check_string_bytes)
4159 (check_string_free_list): Convert to standard C.
4160
4161 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4162
4163 * w32.c (emacs_gnutls_push): Fix typo.
4164
4165 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4166
4167 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4168 "cast to pointer from integer of different size".
4169
4170 Improve doprnt and its use in verror. (Bug#8545)
4171 * doprnt.c (doprnt): Document the set of format control sequences
4172 supported by the function. Use SAFE_ALLOCA instead of always
4173 using `alloca'.
4174
4175 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4176 is one byte too soon. Don't use xrealloc; instead xfree and
4177 xmalloc anew.
4178
4179 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4180
4181 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4182 callbacks stage.
4183
4184 * gnutls.c: Renamed global_initialized to
4185 gnutls_global_initialized. Added internals for the
4186 :verify-hostname-error, :verify-error, and :verify-flags
4187 parameters of `gnutls-boot' and documented those parameters in the
4188 docstring. Start callback support.
4189 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4190 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4191 on error. Return error code.
4192 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4193 (emacs_gnutls_read): Likewise.
4194 (Fgnutls_boot): Return handshake error code.
4195 (emacs_gnutls_handle_error): New function.
4196 (wsaerror_to_errno): Likewise.
4197
4198 * w32.h (emacs_gnutls_pull): Add prototype.
4199 (emacs_gnutls_push): Likewise.
4200
4201 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4202 (emacs_gnutls_push): Likewise.
4203
4204 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4205
4206 * process.c (wait_reading_process_output): Check if GnuTLS
4207 buffered some data internally if no FDs are set for TLS
4208 connections.
4209
4210 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4211 (LIBS): Link to USER_LIBS.
4212 ($(BLD)/gnutls.$(0)): New target.
4213
4214 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4215
4216 * xdisp.c (handle_single_display_spec): Rename the
4217 display_replaced_before_p argument into display_replaced_p, to
4218 make it consistent with the commentary. Fix typos in the
4219 commentary.
4220
4221 * textprop.c (syms_of_textprop): Remove dead code.
4222 (copy_text_properties): Delete obsolete commentary about an
4223 interface that was deleted long ago. Fix typos in the description
4224 of arguments.
4225
4226 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4227 to changes in oldXMenu/XMenu.h from 2011-04-16.
4228 <menu_help_message, prev_menu_help_message>: Constify.
4229 (IT_menu_make_room): menu->help_text is now `const char **';
4230 adjust.
4231
4232 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4233 to changes in oldXMenu/XMenu.h from 2011-04-16.
4234 (struct XMenu): Declare `help_text' `const char **'.
4235
4236 * xfaces.c <Qunspecified>: Make extern again.
4237
4238 * syntax.c: Include sys/types.h before including regex.h, as
4239 required by Posix.
4240
4241 * doc.c (get_doc_string): Improve the format passed to `error'.
4242
4243 * doprnt.c (doprnt): Improve commentary.
4244
4245 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4246
4247 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4248 them with etags.
4249
4250 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4251 changes in globals.h immediately force recompilation.
4252 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4253 $(CURDIR)/s/ms-w32.h.
4254 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4255
4256 * character.c (Fchar_direction): Function deleted.
4257 (syms_of_character): Don't defsubr it.
4258 <char-direction-table>: Deleted.
4259
4260 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4261
4262 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4263 * doprnt.c: Include limits.h.
4264 (SIZE_MAX): New macro.
4265 (doprnt): Return a size_t value. 2nd arg is now size_t.
4266 Many local variables are now size_t instead of int or unsigned.
4267 Improve overflow protection. Support `l' modifier for integer
4268 conversions. Support %l conversion. Don't assume an EMACS_INT
4269 argument for integer conversions and for %c.
4270
4271 * lisp.h (doprnt): Restore prototype.
4272
4273 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4274 $(SRC)/character.h.
4275
4276 * Makefile.in (base_obj): Add back doprnt.o.
4277
4278 * deps.mk (doprnt.o): Add back prerequisites.
4279 (callint.o): Depend on character.h.
4280
4281 * eval.c (internal_lisp_condition_case): Include the handler
4282 representation in the error message.
4283 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4284 when breaking from the loop.
4285
4286 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4287
4288 * callint.c (Fcall_interactively): When displaying error message
4289 about invalid control letter, pass the character's codepoint, not
4290 a pointer to its multibyte form. Improve display of the character
4291 in octal and display also its hex code.
4292
4293 * character.c (char_string): Use %x to display the (unsigned)
4294 codepoint of an invalid character, to avoid displaying a bogus
4295 negative value.
4296
4297 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4298 `error', not SYMBOL_NAME itself.
4299
4300 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4301 character arguments to `error'.
4302
4303 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4304 to `error' in error message about FINAL_CHAR argument. Make sure
4305 FINAL_CHAR is a character, and use %c when it is passed as
4306 argument to `error'.
4307
4308 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4309
4310 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4311
4312 * w32.c: Include <time.h>.
4313 (sys_localtime): New function.
4314
4315 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4316
4317 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4318
4319 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4320
4321 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4322
4323 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4324 zombies (Bug#8467).
4325
4326 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4327
4328 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4329 gl_state.e_property when gl_state.object is Qt.
4330
4331 * insdel.c (make_gap_larger): Remove limitation of buffer size
4332 to <= INT_MAX.
4333
4334 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4335
4336 * xdisp.c (lookup_glyphless_char_display)
4337 (produce_glyphless_glyph): Handle cons cell entry in
4338 glyphless-char-display.
4339 (Vglyphless_char_display): Document it.
4340
4341 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4342 glyphless-char-display.
4343
4344 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4345
4346 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4347
4348 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4349
4350 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4351 definition for no-X builds.
4352
4353 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4354
4355 Static checks with GCC 4.6.0 and non-default toolkits.
4356
4357 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4358
4359 * process.c (keyboard_bit_set): Define only if SIGIO.
4360 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4361 (send_process): Repair possible setjmp clobbering.
4362
4363 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4364
4365 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4366
4367 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4368
4369 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4370 Define only if needed.
4371
4372 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4373 by pacifying GCC about it. Maybe it's time to retire it?
4374 * xfaces.c (USG, __TIMEVAL__): Likewise.
4375
4376 * dispextern.h (struct redisplay_interface): Rename param
4377 to avoid shadowing.
4378 * termhooks.h (struct terminal): Likewise.
4379 * xterm.c (xembed_send_message): Likewise.
4380
4381 * insdel.c (make_gap_smaller): Define only if
4382 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4383
4384 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4385 it.
4386
4387 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4388 so that we aren't warned about unused symbols.
4389
4390 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4391
4392 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4393
4394 * xfns.c (x_real_positions): Mark locals as initialized.
4395
4396 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4397
4398 * xterm.c: Fix problems found by static analysis with other toolkits.
4399 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4400 (x_dispatch_event): Declare static if USE_GTK, and
4401 define if USE_GTK || USE_X_TOOLKIT.
4402 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4403 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4404 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4405 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4406
4407 * xmenu.c (menu_help_callback): Pointer type fixes.
4408 Use const pointers when pointing at readonly data. Avoid pointer
4409 signedness clashes.
4410 (FALSE): Remove unused macro.
4411 (update_frame_menubar): Remove unused decl.
4412
4413 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4414
4415 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4416 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4417 (single_menu_item): Rename local to avoid shadowing.
4418
4419 * keyboard.c (make_lispy_event): Remove unused local var.
4420
4421 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4422 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4423
4424 * bitmaps: Change bitmaps from unsigned char back to the X11
4425 compatible char. Avoid the old compiler warnings about
4426 out-of-range initializers by using, for example, '\xab' rather
4427 than 0xab.
4428
4429 * xgselect.c (xgselect_initialize): Check vs interface
4430 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4431
4432 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4433
4434 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4435 to read-only memory.
4436
4437 * fns.c (vector): Remove; this old hack is no longer needed.
4438
4439 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4440 Remove unused var.
4441 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4442
4443 * xrdb.c (x_load_resources): Omit unused local.
4444
4445 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4446 (x_window): Rename locals to avoid shadowing.
4447 (USG): Use the kludged USG macro, to pacify gcc.
4448
4449 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4450 (x_term_init): Remove local to avoid shadowing.
4451
4452 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4453
4454 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4455 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4456
4457 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4458
4459 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4460
4461 Fix regex.c, syntax.c and friends for buffers > 2GB.
4462 * syntax.h (struct gl_state_s): Declare character position members
4463 EMACS_INT.
4464
4465 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4466
4467 * textprop.c (verify_interval_modification, interval_of):
4468 Declare arguments EMACS_INT.
4469
4470 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4471 EMACS_INT.
4472
4473 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4474
4475 * indent.c (Fvertical_motion): Local variable it_start is now
4476 EMACS_INT.
4477
4478 * regex.c (re_match, re_match_2, re_match_2_internal)
4479 (bcmp_translate, regcomp, regexec, print_double_string)
4480 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4481 (re_compile_pattern, re_exec): Declare arguments and local
4482 variables `size_t' and `ssize_t' and return values `regoff_t', as
4483 appropriate.
4484 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4485 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4486 <compile_stack_type>: `size' and `avail' are now `size_t'.
4487
4488 * regex.h <regoff_t>: Use ssize_t, not int.
4489 (re_search, re_search_2, re_match, re_match_2): Arguments that
4490 specify buffer/string position and length are now ssize_t and
4491 size_t. Return type is regoff_t.
4492
4493 2011-04-16 Ben Key <bkey76@gmail.com>
4494
4495 * nsfont.m: Fixed bugs in ns_get_family and
4496 ns_descriptor_to_entity that were caused by using free to
4497 deallocate memory blocks that were allocated by xmalloc (via
4498 xstrdup). This caused Emacs to crash when compiled with
4499 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4500 --enable-checking=xmallocoverrun). xfree is now used to
4501 deallocate these memory blocks.
4502
4503 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4504
4505 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4506
4507 emacs_write: Accept and return EMACS_INT for sizes.
4508 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4509 et seq.
4510 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4511 Accept and return EMACS_INT.
4512 (emacs_gnutls_write): Return the number of bytes written on
4513 partial writes.
4514 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4515 (emacs_read, emacs_write): Remove check for negative size, as the
4516 Emacs source code has been audited now.
4517 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4518 (emacs_read, emacs_write): Use it.
4519 * process.c (send_process): Adjust to the new signatures of
4520 emacs_write and emacs_gnutls_write. Do not attempt to store
4521 a byte offset into an 'int'; it might overflow.
4522 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4523
4524 * sound.c: Don't assume sizes fit in 'int'.
4525 (struct sound_device.period_size, alsa_period_size):
4526 Return EMACS_INT, not int.
4527 (struct sound_device.write, vox_write, alsa_write):
4528 Accept EMACS_INT, not int.
4529 (wav_play, au_play): Use EMACS_INT to store sizes and to
4530 record read return values.
4531
4532 2011-04-15 Ben Key <bkey76@gmail.com>
4533
4534 * keyboard.c (Qundefined): Don't declare static since it is used
4535 in nsfns.m.
4536 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4537 static since they are used in nsfont.m.
4538
4539 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4540
4541 * process.c (Qprocessp): Don't declare static.
4542 * lisp.h (Qprocessp): Declare again.
4543
4544 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4545
4546 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4547
4548 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4549
4550 Improve C-level modularity by making more things 'static'.
4551
4552 Don't publish debugger-only interfaces to other modules.
4553 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4554 (verify_bytepos, count_markers): Move decls to the only modules
4555 that need them.
4556 * region-cache.h (pp_cache): Likewise.
4557 * window.h (check_all_windows): Likewise.
4558 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4559
4560 * sysdep.c (croak): Now static, if
4561 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4562 * syssignal.h (croak): Declare only if not static.
4563
4564 * alloc.c (refill_memory_reserve): Now static if
4565 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4566 * lisp.h (refill_memory_reserve): Declare only if not static.
4567
4568 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4569 Define only if USE_LUCID.
4570
4571 * xrdb.c (x_customization_string, x_rm_string): Now static.
4572
4573 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4574 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4575
4576 * xdisp.c (draw_row_with_mouse_face): Now static.
4577 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4578
4579 * window.h (check_all_windows): Mark externally visible.
4580
4581 * window.c (window_deletion_count): Now static.
4582
4583 * undo.c: Make symbols static if they're not exported.
4584 (last_undo_buffer, last_boundary_position, pending_boundary):
4585 Now static.
4586
4587 * textprop.c (interval_insert_behind_hooks): Now static.
4588 (interval_insert_in_front_hooks): Likewise.
4589
4590 * term.c: Make symbols static if they're not exported.
4591 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4592 (max_frame_lines, tty_set_terminal_modes):
4593 (tty_reset_terminal_modes, tty_turn_off_highlight):
4594 (get_tty_terminal): Now static.
4595 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4596 * termhooks.h (term_mouse_moveto): Do not declare if
4597 HAVE_WINDOW_SYSTEM.
4598 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4599 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4600
4601 * sysdep.c: Make symbols static if they're not exported.
4602 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4603 Now static.
4604 (sigprocmask_set, full_mask): Remove; unused.
4605 (wait_debugging): Mark as visible.
4606 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4607 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4608
4609 * syntax.c (syntax_temp): Define only if !__GNUC__.
4610
4611 * sound.c (current_sound_device, current_sound): Now static.
4612
4613 * search.c (searchbufs, searchbuf_head): Now static.
4614
4615 * scroll.c (scroll_cost): Remove; unused.
4616 * dispextern.h (scroll_cost): Remove decl.
4617
4618 * region-cache.h (pp_cache): Mark as externally visible.
4619
4620 * process.c: Make symbols static if they're not exported.
4621 (process_tick, update_tick, create_process, chan_process):
4622 (Vprocess_alist, proc_buffered_char, datagram_access):
4623 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4624 (deactivate_process): Mark defn as static, as well as decl.
4625 * lisp.h (create_process): Remove decl.
4626 * process.h (chan_process, Vprocess_alist): Remove decls.
4627
4628 * print.c: Make symbols static if they're not exported.
4629 (print_depth, new_backquote_output, being_printed, print_buffer):
4630 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4631 (print_interval, print_number_index, initial_stderr_stream):
4632 Now static.
4633 * lisp.h (Fprinc): Remove decl.
4634 (debug_output_compilation_hack): Mark as externally visible.
4635
4636 * sysdep.c (croak): Move decl from here to syssignal.h.
4637 * syssignal.h (croak): Put it here, so the API can be checked when
4638 'croak' is called from dissociate_if_controlling_tty.
4639
4640 * minibuf.c: Make symbols static if they're not exported.
4641 (minibuf_save_list, choose_minibuf_frame): Now static.
4642 * lisp.h (choose_minibuf_frame): Remove decl.
4643
4644 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4645
4646 * lread.c: Make symbols static if they're not exported.
4647 (read_objects, initial_obarray, oblookup_last_bucket_number):
4648 Now static.
4649 (make_symbol): Remove; unused.
4650 * lisp.h (initial_obarray, make_symbol): Remove decls.
4651
4652 * keyboard.c: Make symbols static if they're not exported.
4653 (single_kboard, recent_keys_index, total_keys, recent_keys):
4654 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4655 (this_single_command_key_start, echoing, last_auto_save):
4656 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4657 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4658 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4659 (Vlispy_mouse_stem, double_click_count):
4660 Now static.
4661 (force_auto_save_soon): Define only if SIGDANGER.
4662 (ignore_mouse_drag_p): Now static if
4663 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4664 (print_help): Remove; unused.
4665 (stop_character, last_timer_event): Mark as externally visible.
4666 * keyboard.h (ignore_mouse_drag_p): Declare only if
4667 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4668 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4669 * lisp.h (echoing): Remove decl.
4670 (force_auto_save_soon): Declare only if SIGDANGER.
4671 * xdisp.c (redisplay_window): Simplify code, to make it more
4672 obvious that ignore_mouse_drag_p is not accessed if !defined
4673 USE_GTK && !defined HAVE_NS.
4674
4675 * intervals.c: Make symbols static if they're not exported.
4676 (merge_properties_sticky, merge_interval_right, delete_interval):
4677 Now static.
4678 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4679
4680 * insdel.c: Make symbols static if they're not exported.
4681 However, leave prepare_to_modify_buffer alone. It's never
4682 called from outside this function, but that appears to be a bug.
4683 (combine_after_change_list, combine_after_change_buffer):
4684 (adjust_after_replace, signal_before_change): Now static.
4685 (adjust_after_replace_noundo): Remove; unused.
4686 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4687 (signal_before_change): Remove decls.
4688
4689 * indent.c (val_compute_motion, val_vmotion): Now static.
4690
4691 * image.c: Make symbols static if they're not exported.
4692 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4693 if USE_GTK.
4694 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4695 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4696
4697 * fringe.c (standard_bitmaps): Now static.
4698 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4699
4700 * frame.c: Make symbols static if they're not exported.
4701 (x_report_frame_params, make_terminal_frame): Now static.
4702 (get_frame_param): Now static, unless HAVE_NS.
4703 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4704 (x_get_resource_string): Remove; not used.
4705 * frame.h (make_terminal_frame, x_report_frame_params):
4706 (x_get_resource_string); Remove decls.
4707 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4708 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4709
4710 * font.c, fontset.c: Make symbols static if they're not exported.
4711 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4712 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4713 * font.c (font_close_object): Now static.
4714 * font.h (font_close_object): Remove.
4715 * fontset.c (FONTSET_OBJLIST): Remove.
4716 (free_realized_fontset) #if-0 the body, which does nothing.
4717 (face_suitable_for_char_p): #if-0, as it's never called.
4718 * fontset.h (face_suitable_for_char_p): Remove decl.
4719 * xfaces.c (face_at_string_position):
4720 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4721 since 0 is always ASCII.
4722
4723 * fns.c (weak_hash_tables): Now static.
4724
4725 * fileio.c: Make symbols static if they're not exported.
4726 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4727 (Vwrite_region_annotation_buffers): Now static.
4728
4729 * eval.c: Make symbols static if they're not exported.
4730 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4731 * lisp.h (backtrace_list): Remove decl.
4732
4733 * emacs.c: Make symbols static if they're not exported.
4734 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4735 (fatal_error_code, fatal_error_signal_hook, standard_args):
4736 Now static.
4737 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4738 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4739 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4740 * lisp.h (fatal_error_signal_hook): Remove decl.
4741 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4742
4743 * editfns.c: Move a (normally-unused) function to its only use.
4744 * editfns.c, lisp.h (get_operating_system_release): Remove.
4745 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4746 worth the hassle of breaking this out.
4747
4748 * xterm.c: Make symbols static if they're not exported.
4749 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4750 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4751 (x_destroy_window, x_delete_display):
4752 Now static.
4753 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4754 (x_mouse_leave): Remove; unused.
4755 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4756 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4757 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4758 Remove decls.
4759 (x_mouse_leave): Declare only if WINDOWSNT.
4760 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4761 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4762 USE_X_TOOLKIT.
4763
4764 * ftxfont.c: Make symbols static if they're not exported.
4765 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4766 HAVE_FREETYPE.
4767 * font.h (ftxfont_driver): Likewise.
4768
4769 * xfns.c: Make symbols static if they're not exported.
4770 (x_last_font_name, x_display_info_for_name):
4771 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4772 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4773 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4774 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4775 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4776 (last_show_tip_args): Now static.
4777 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4778 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4779 (x_screen_planes): Remove; unused.
4780 * dispextern.h (x_screen_planes): Remove decl.
4781
4782 * dispnew.c: Make symbols static if they're not exported.
4783 * dispextern.h (redraw_garbaged_frames, scrolling):
4784 (increment_row_positions): Remove.
4785 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4786 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4787 Now static.
4788 (redraw_garbaged_frames): Remove; unused.
4789
4790 * xfaces.c: Make symbols static if they're not exported.
4791 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4792 Remove decls.
4793 * xterm.h (defined_color): Remove decls.
4794 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4795 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4796 (menu_face_changed_default, defined_color, free_realized_face):
4797 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4798 (ascii_face_of_lisp_face): Remove; unused.
4799
4800 * xdisp.c: Make symbols static if they're not exported.
4801 * dispextern.h (scratch_glyph_row, window_box_edges):
4802 (glyph_to_pixel_coords, set_cursor_from_row):
4803 (get_next_display_element, set_iterator_to_next):
4804 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4805 (show_mouse_face): Remove decls
4806 * frame.h (message_buf_print): Likewise.
4807 * lisp.h (pop_message, set_message, check_point_in_composition):
4808 Likewise.
4809 * xterm.h (set_vertical_scroll_bar): Likewise.
4810 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4811 (message_buf_print, scratch_glyph_row, displayed_buffer):
4812 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4813 (get_next_display_element, show_mouse_face, window_box_edges):
4814 (frame_to_window_pixel_xy, check_point_in_composition):
4815 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4816 (glyph_to_pixel_coords): Remove; unused.
4817
4818 * dired.c (file_name_completion): Now static.
4819
4820 * dbusbind.c (xd_in_read_queued_messages): Now static.
4821
4822 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4823 * data.c (circular_list_error): Remove.
4824
4825 * commands.h (last_point_position, last_point_position_buffer):
4826 (last_point_position_window): Remove decls.
4827 * keyboard.c: Make these variables static.
4828
4829 * coding.h (coding, code_convert_region, encode_coding_gap):
4830 Remove decls.
4831 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4832 (iso_code_class, detect_coding, code_convert_region): Now static.
4833 (encode_coding_gap): Remove; unused.
4834
4835 * chartab.c (chartab_chars, chartab_bits): Now static.
4836
4837 * charset.h (charset_iso_8859_1): Remove decl.
4838 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4839 Now static.
4840
4841 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4842 * ccl.c (Vccl_program_table): Now static.
4843 (check_ccl_update): Remove; unused.
4844
4845 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4846 * category.h: ... from here.
4847 * category.c (check_category_table, set_category_set): Now static.
4848
4849 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4850 * lisp.h: Remove these decls.
4851
4852 * buffer.c (buffer_count): Remove unused var.
4853
4854 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4855 so that it's not optimized away.
4856 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4857 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4858 exported only to the debugger.
4859
4860 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4861 * atimer.h (run_all_atimers): Remove; not exported.
4862
4863 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4864 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4865 was inaccessible from Lisp.
4866 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4867 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4868
4869 alloc.c: Import and export fewer symbols, and remove unused items.
4870 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4871 is defined.
4872 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4873 it's not optimized away by whole-program optimization.
4874 (message_enable_multibyte, free_misc): Remove.
4875 (catchlist, handlerlist, mark_backtrace):
4876 Declare only if BYTE_MARK_STACK.
4877 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4878 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4879 (message_enable_multibyte): Remove decl.
4880 (free_misc, interval_free_list, float_block, float_block_index):
4881 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4882 (cons_free_list, last_marked_index):
4883 Now static.
4884 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4885 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4886 (mark_backtrace): Define only if BYTE_MARK_STACK.
4887 * xdisp.c (message_enable_multibyte): Now static.
4888
4889 Declare Lisp_Object Q* variables to be 'static' if not exported.
4890 This makes it easier for human readers (and static analyzers)
4891 to see whether these variables are used from other modules.
4892 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4893 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4894 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4895 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4896 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4897 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4898 * xmenu.c, xselect.c:
4899 Declare Q* vars static if they are not used in other modules.
4900 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4901 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4902 Remove decls of unexported vars.
4903 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4904
4905 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4906
4907 Make Emacs functions such as Fatom 'static' by default.
4908 This makes it easier for human readers (and static analyzers)
4909 to see whether these functions can be called from other modules.
4910 DEFUN now defines a static function. To make the function external
4911 so that it can be used in other C modules, use the new macro DEFUE.
4912 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4913 (Finit_image_library):
4914 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4915 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4916 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4917 Remove decls, since these functions are now static.
4918 (Funintern, Fget_internal_run_time): New decls, since these functions
4919 were already external.
4920
4921 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4922 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4923 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4924 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4925 * keyboard.c, keymap.c, lread.c:
4926 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4927 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4928 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4929 Mark functions with DEFUE instead of DEFUN,
4930 if they are used in other modules.
4931 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4932 decls for now-static functions.
4933 * buffer.h (Fdelete_overlay): Remove decl.
4934 * callproc.c (Fgetenv_internal): Mark as internal.
4935 * composite.c (Fremove_list_of_text_properties): Remove decl.
4936 (Fcomposition_get_gstring): New forward static decl.
4937 * composite.h (Fcomposite_get_gstring): Remove decl.
4938 * dired.c (Ffile_attributes): New forward static decl.
4939 * doc.c (Fdocumntation_property): New forward static decl.
4940 * eval.c (Ffetch_bytecode): New forward static decl.
4941 (Funintern): Remove extern decl; now in .h file where it belongs.
4942 * fileio.c (Fmake_symbolic_link): New forward static decl.
4943 * image.c (Finit_image_library): New forward static decl.
4944 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4945 * intervals.h (Fprevious_property_change):
4946 (Fremove_list_of_text_properties): Remove decls.
4947 * keyboard.c (Fthis_command_keys): Remove decl.
4948 (Fcommand_execute): New forward static decl.
4949 * keymap.c (Flookup_key): New forward static decl.
4950 (Fcopy_keymap): Now static.
4951 * keymap.h (Flookup_key): Remove decl.
4952 * process.c (Fget_process): New forward static decl.
4953 (Fprocess_datagram_address): Mark as internal.
4954 * syntax.c (Fsyntax_table_p): New forward static decl.
4955 (skip_chars): Remove duplicate decl.
4956 * textprop.c (Fprevious_property_change): New forward static decl.
4957 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4958 Now internal.
4959 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4960 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4961
4962 * editfns.c (Fformat): Remove unreachable code.
4963
4964 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4965
4966 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4967 change. (Bug#8496)
4968
4969 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4970
4971 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4972 when at ZV. (Bug#8487)
4973
4974 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4975
4976 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4977 (Bug#8437)
4978 * keyboard.c (parse_tool_bar_item): Likewise.
4979 * sound.c (sound_cleanup, alsa_close): Likewise.
4980 * termcap.c (tgetent): Likewise.
4981 * xfns.c (x_default_font_parameter): Likewise.
4982 * xsettings.c (read_and_apply_settings): Likewise.
4983
4984 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4985 (overrun_check_free): Protoize.
4986
4987 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4988
4989 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4990 since callers should never pass a negative size.
4991 Change the signature to match that of plain 'read' and 'write'; see
4992 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4993 * lisp.h: Update prototypes of emacs_write and emacs_read.
4994
4995 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4996
4997 * xdisp.c (redisplay_window): Don't try to determine the character
4998 position of the scroll margin if the window start point w->startp
4999 is outside the buffer's accessible region. (Bug#8468)
5000
5001 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5002
5003 Fix write-region and its subroutines for buffers > 2GB.
5004 * fileio.c (a_write, e_write): Modify declaration of arguments and
5005 local variables to support buffers larger than 2GB.
5006 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5007
5008 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5009 argument, local variables, and return value.
5010
5011 * lisp.h: Update prototypes of emacs_write and emacs_read.
5012
5013 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5014
5015 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5016
5017 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5018
5019 Fix more problems found by GCC 4.6.0's static checks.
5020
5021 * xdisp.c (vmessage): Use a better test for character truncation.
5022
5023 * charset.c (load_charset_map): <, not <=, for optimization,
5024 and to avoid potential problems with integer overflow.
5025 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5026 * casetab.c (set_identity, shuffle): Likewise.
5027 * editfns.c (Fformat): Likewise.
5028 * syntax.c (skip_chars): Likewise.
5029
5030 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5031 This also lets GCC 4.6.0 generate slightly better loop code.
5032
5033 * callint.c (Fcall_interactively): <, not <=, for optimization.
5034 (Fcall_interactively): Count the number of arguments produced,
5035 not the number of arguments given. This is simpler and lets GCC
5036 4.6.0 generate slightly better code.
5037
5038 * ftfont.c: Distingish more carefully between FcChar8 and char.
5039 The previous code passed unsigned char * to a functions like
5040 strlen and xstrcasecmp that expect char *, which does not
5041 conform to the C standard.
5042 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5043 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5044 char * when the C standard requires it.
5045
5046 * keyboard.c (read_char): Remove unused var.
5047
5048 * eval.c: Port to Windows vsnprintf (Bug#8435).
5049 Include <limits.h>.
5050 (SIZE_MAX): Define if the headers do not.
5051 (verror): Do not give up if vsnprintf returns a negative count.
5052 Instead, grow the buffer. This ports to Windows vsnprintf, which
5053 does not conform to C99. Problem reported by Eli Zaretskii.
5054 Also, simplify the allocation scheme, by avoiding the need for
5055 calling realloc, and removing the ALLOCATED variable.
5056
5057 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5058
5059 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5060 But keep the doprint source code for now, as we might revamp it
5061 and use it again (Bug#8435).
5062 * lisp.h (doprnt): Remove.
5063 * Makefile.in (base_obj): Remove doprnt.o.
5064 * deps.mk (doprnt.o): Remove.
5065
5066 error: Print 32- and 64-bit integers portably (Bug#8435).
5067 Without this change, on typical 64-bit hosts error ("...%d...", N)
5068 was used to print both 32- and 64-bit integers N, which relied on
5069 undefined behavior.
5070 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5071 New macro.
5072 * lisp.h (error, verror): Mark as printf-like functions.
5073 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5074 Report overflow in size calculations when allocating printf buffer.
5075 Do not truncate output string at its first null byte.
5076 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5077 Truncate the output at a character boundary, since vsnprintf does not
5078 do that.
5079 * charset.c (check_iso_charset_parameter): Convert internal
5080 character to string before calling 'error', since %c now has the
5081 printf meaning.
5082 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5083 overflow when computing char to be passed to 'error'. Do not
5084 pass Lisp_Object to 'error'; pass the integer instead.
5085 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5086 formatted with plain %d.
5087
5088 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5089
5090 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5091
5092 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5093
5094 * xterm.c (x_catch_errors): Remove duplicate declaration.
5095
5096 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5097
5098 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5099
5100 2011-04-10 Jim Meyering <meyering@redhat.com>
5101
5102 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5103 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5104 return ssize_t not "int", and use size_t as the buffer length.
5105 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5106 * gnutls.h: Update declarations.
5107 * process.c (read_process_output): Use ssize_t, to match.
5108 (send_process): Likewise.
5109
5110 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5111
5112 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5113
5114 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5115
5116 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5117 Use unsigned char, to match FcChar8 type definition.
5118
5119 * xterm.c (handle_one_xevent):
5120 * xmenu.c (create_and_show_popup_menu):
5121 * xselect.c (x_decline_selection_request)
5122 (x_reply_selection_request): Avoid type-punned deref of X events.
5123
5124 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5125
5126 Fix some uses of `int' instead of EMACS_INT.
5127 * search.c (string_match_1, fast_string_match)
5128 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5129 (scan_buffer, find_next_newline_no_quit)
5130 (find_before_next_newline, search_command, Freplace_match)
5131 (Fmatch_data): Make some `int' variables be EMACS_INT.
5132
5133 * xdisp.c (display_count_lines): 3rd argument and return value now
5134 EMACS_INT. All callers changed.
5135 (pint2hrstr): Last argument is now EMACS_INT.
5136
5137 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5138 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5139 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5140 (decode_coding_utf_16, decode_coding_emacs_mule)
5141 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5142 (decode_coding_ccl, decode_coding_charset)
5143 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5144 (decode_coding_iso_2022, decode_coding_emacs_mule)
5145 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5146 <char_offset, last_offset>: Declare EMACS_INT.
5147 (encode_coding_utf_8, encode_coding_utf_16)
5148 (encode_coding_emacs_mule, encode_invocation_designation)
5149 (encode_designation_at_bol, encode_coding_iso_2022)
5150 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5151 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5152 Declare EMACS_INT.
5153 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5154 (encode_invocation_designation): Last argument P_NCHARS is now
5155 EMACS_INT.
5156 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5157 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5158
5159 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5160 All users changed.
5161
5162 * ccl.c (Fccl_execute_on_string): Declare some variables
5163 EMACS_INT.
5164
5165 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5166
5167 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5168
5169 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5170
5171 * process.c (Fformat_network_address): Doc fix.
5172
5173 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5174
5175 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5176
5177 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5178
5179 * keyboard.c (read_char): Call Lisp function help-form-show,
5180 instead of using internal_with_output_to_temp_buffer.
5181 (Qhelp_form_show): New var.
5182 (syms_of_keyboard): Use DEFSYM macro.
5183
5184 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5185
5186 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5187
5188 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5189
5190 * process.c (Flist_processes): Remove to Lisp.
5191 (list_processes_1): Delete.
5192
5193 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5194
5195 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5196
5197 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5198
5199 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5200
5201 Fix more problems found by GCC 4.6.0's static checks.
5202
5203 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5204
5205 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5206
5207 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5208
5209 * xdisp.c (vmessage): Mark as a printf-like function.
5210
5211 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5212
5213 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5214
5215 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5216 printf-like functions.
5217 (tiff_load): Add casts to remove these marks before passing them
5218 to system-supplied API.
5219
5220 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5221
5222 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5223 This avoids several warnings with gcc -Wstrict-overflow.
5224 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5225 directly, rather than having caller test rule sign. This avoids
5226 some unnecessary tests.
5227 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5228 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5229 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5230
5231 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5232 (xfont_open): Avoid unnecessary tests.
5233
5234 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5235
5236 * composite.h, composite.c (composition_gstring_put_cache):
5237 Use EMACS_INT, not int, for length.
5238
5239 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5240 breaking out part of COMPOSITION_DECODE_RULE.
5241 (COMPOSITION_DECODE_RULE): Use it.
5242 * composite.c (get_composition_id): Remove unused local vars,
5243 by using the new macro.
5244
5245 * textprop.c (set_text_properties_1): Change while to do-while,
5246 since the condition is always true at first.
5247
5248 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5249 (interval_deletion_adjustment): Return unsigned value.
5250 All uses changed.
5251
5252 * process.c (list_processes_1, create_pty, read_process_output):
5253 (exec_sentinel): Remove vars that were set but not used.
5254 (create_pty): Remove unnecessary "volatile"s.
5255 (Fnetwork_interface_info): Avoid possibility of int overflow.
5256 (read_process_output): Do adaptive read buffering even if carryover.
5257 (read_process_output): Simplify nbytes computation if buffered.
5258
5259 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5260
5261 * syntax.c (scan_words): Remove var that was set but not used.
5262 (update_syntax_table): Use unsigned instead of int.
5263
5264 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5265 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5266 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5267
5268 * print.c (print_error_message): Avoid int overflow.
5269
5270 * font.c (font_list_entities): Redo for clarity,
5271 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5272
5273 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5274 (font_score): Avoid potential overflow in diff calculation.
5275
5276 * fns.c (substring_both): Remove var that is set but not used.
5277 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5278
5279 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5280
5281 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5282 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5283 can always succeed if overflow has undefined behavior.
5284
5285 * search.c (boyer_moore, wordify): Remove vars set but not used.
5286 (wordify): Omit three unnecessary tests.
5287
5288 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5289 All callers changed. This avoids the need for an unused var.
5290
5291 * casefiddle.c (casify_region): Remove var that is set but not used.
5292
5293 * dired.c (file_name_completion): Remove var that is set but not used.
5294
5295 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5296
5297 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5298 (Finsert_file_contents): Remove unnecessary code checking fd.
5299
5300 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5301 Check for integer overflow on size calculations.
5302
5303 * buffer.c (Fprevious_overlay_change): Remove var that is set
5304 but not used.
5305
5306 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5307 Remove vars that are set but not used.
5308 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5309 (timer_check_2): Mark vars as initialized.
5310
5311 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5312
5313 * image.c (lookup_image): Remove var that is set but not used.
5314 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5315
5316 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5317 that are set but not used.
5318
5319 * xfns.c (make_invisible_cursor): Don't return garbage
5320 if XCreateBitmapFromData fails (Bug#8410).
5321
5322 * xselect.c (x_get_local_selection, x_handle_property_notify):
5323 Remove vars that are set but not used.
5324
5325 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5326 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5327
5328 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5329 Remove var that is set but not used.
5330 (scroll_bar_windows_size): Now size_t, not int.
5331 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5332 Check for overflow.
5333
5334 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5335 (map_tty_color) [!defined MSDOS]: Likewise.
5336
5337 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5338
5339 * coding.c: Remove vars that are set but not used.
5340 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5341 All callers changed.
5342 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5343 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5344 (decode_coding_charset): Remove vars that are set but not used.
5345
5346 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5347 that is set but not used.
5348
5349 * print.c (print_object): Remove var that is set but not used.
5350
5351 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5352 The gnulib version avoids calling malloc in the usual case,
5353 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5354 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5355 * filelock.c (current_lock_owner): Likewise.
5356 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5357 * sysdep.c: Include allocator.h, careadlinkat.h.
5358 (emacs_no_realloc_allocator): New static constant.
5359 (emacs_readlink): New function.
5360 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5361 ../lib/careadlinkat.h.
5362
5363 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5364
5365 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5366 first non-nil return value).
5367
5368 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5369
5370 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5371 if not defined (Bug#8403).
5372
5373 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5374
5375 * xdisp.c (display_count_lines): Remove parameter `start',
5376 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5377 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5378 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5379 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5380 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5381 and thereabouts. All callers changed.
5382 (get_per_char_metric): Remove parameter `f', unused since
5383 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5384
5385 2011-04-02 Jim Meyering <meyering@redhat.com>
5386
5387 do not dereference NULL upon failed strdup
5388 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5389 (ns_get_family): Likewise.
5390
5391 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5392
5393 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5394
5395 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5396
5397 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5398 later (Bug#8403).
5399
5400 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5401
5402 Add lexical binding.
5403
5404 * window.c (Ftemp_output_buffer_show): New fun.
5405 (Fsave_window_excursion):
5406 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5407
5408 * lread.c (lisp_file_lexically_bound_p): New function.
5409 (Fload): Bind Qlexical_binding.
5410 (readevalloop): Remove `evalfun' arg.
5411 Bind Qinternal_interpreter_environment.
5412 (Feval_buffer): Bind Qlexical_binding.
5413 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5414 Mark as dynamic.
5415 (syms_of_lread): Declare `lexical-binding'.
5416
5417 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5418
5419 * keyboard.c (eval_dyn): New fun.
5420 (menu_item_eval_property): Use it.
5421
5422 * image.c (parse_image_spec): Use Ffunctionp.
5423
5424 * fns.c (concat, mapcar1): Accept byte-code-functions.
5425
5426 * eval.c (Fsetq): Handle lexical vars.
5427 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5428 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5429 (FletX, Flet): Obey lexical binding.
5430 (Fcommandp): Handle closures.
5431 (Feval): New `lexical' arg.
5432 (eval_sub): New function extracted from Feval. Use it almost
5433 everywhere where Feval was used. Look up vars in lexical env.
5434 Handle closures.
5435 (Ffunctionp): Move from subr.el.
5436 (Ffuncall): Handle closures.
5437 (apply_lambda): Remove `eval_flags'.
5438 (funcall_lambda): Handle closures and new byte-code-functions.
5439 (Fspecial_variable_p): New function.
5440 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5441 but without exporting it to Lisp.
5442
5443 * doc.c (Fdocumentation, store_function_docstring):
5444 * data.c (Finteractive_form): Handle closures.
5445
5446 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5447 interactive spec.
5448
5449 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5450 New byte-codes.
5451 (exec_byte_code): New function extracted from Fbyte_code to handle new
5452 calling convention for byte-code-functions. Add new byte-codes.
5453
5454 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5455
5456 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5457
5458 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5459
5460 * xdisp.c (redisplay_internal): Fix prototype.
5461
5462 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5463
5464 * xdisp.c (SCROLL_LIMIT): New macro.
5465 (try_scrolling): Use it when setting scroll_limit.
5466 Limit scrolling to 100 screen lines.
5467 (redisplay_window): Even when falling back on "recentering",
5468 position point in the window according to scroll-conservatively,
5469 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5470
5471 (try_scrolling): When point is above the window, allow searching
5472 as far as scroll_max, or one screenful, to compute vertical
5473 distance from PT to the scroll margin position. This prevents
5474 try_scrolling from unnecessarily failing when
5475 scroll-conservatively is set to a value slightly larger than the
5476 window height. Clean up the case of PT below the margin at bottom
5477 of window: scroll_max can no longer be INT_MAX. When aggressive
5478 scrolling is in use, don't let point enter the opposite scroll
5479 margin as result of the scroll.
5480 (syms_of_xdisp) <scroll-conservatively>: Document the
5481 threshold of 100 lines for never-recentering scrolling.
5482
5483 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5484
5485 * dispextern.h (move_it_by_lines):
5486 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5487 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5488 (message_log_check_duplicate): Remove parameters `prev_bol' and
5489 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5490 (redisplay_internal): Remove parameter `preserve_echo_area',
5491 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5492
5493 * indent.c (Fvertical_motion):
5494 * window.c (window_scroll_pixel_based, Frecenter):
5495 Don't pass `need_y_p' to `move_it_by_lines'.
5496
5497 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5498
5499 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5500 steal a few bits to be more compact.
5501 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5502 Remove unneeded casts.
5503
5504 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5505
5506 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5507
5508 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5509 binding" message (bug#7967).
5510
5511 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5512
5513 Fix more problems found by GCC 4.6.0's static checks.
5514
5515 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5516 Remove unused local var.
5517
5518 * editfns.c (Fmessage_box): Remove unused local var.
5519
5520 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5521 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5522 Omit unused local vars.
5523 * window.c (shrink_windows): Omit unused local var.
5524 * menu.c (digest_single_submenu): Omit unused local var.
5525 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5526 Omit unused local var.
5527
5528 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5529 Don't assume string length fits in int.
5530 (keyremap_step, read_key_sequence): Use size_t for sizes.
5531 (read_key_sequence): Don't check last_real_key_start redundantly.
5532
5533 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5534 instead of alloca (Bug#8344).
5535
5536 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5537 (Fbacktrace_frame): Don't assume nframes fits in int.
5538
5539 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5540
5541 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5542 concerns.
5543
5544 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5545
5546 * cm.c (calccost): Turn while-do into do-while, for clarity.
5547
5548 * keyboard.c (syms_of_keyboard): Use the same style as later
5549 in this function when indexing through an array. This also
5550 works around GCC bug 48267.
5551
5552 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5553
5554 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5555
5556 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5557 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5558
5559 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5560 This avoids undefined behavior on integer overflow, and is a bit
5561 more convenient anyway since it is compared to a size_t variable.
5562
5563 Variadic C functions now count arguments with size_t, not int.
5564 This avoids an unnecessary limitation on 64-bit machines, which
5565 caused (substring ...) to crash on large vectors (Bug#8344).
5566 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5567 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5568 All variadic functions and their callers changed accordingly.
5569 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5570 * data.c (arith_driver, float_arith_driver): Likewise.
5571 * editfns.c (general_insert_function): Likewise.
5572 * eval.c (struct backtrace.nargs, interactive_p)
5573 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5574 (funcall_lambda, mark_backtrace): Likewise.
5575 * fns.c (concat): Likewise.
5576 * frame.c (x_set_frame_parameters): Likewise.
5577 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5578 0 if not found, not -1. All callers changed.
5579
5580 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5581 (stack_copy_size): Now size_t, not int.
5582 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5583
5584 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5585
5586 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5587 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5588 All callers changed.
5589
5590 * lisp.h (multibyte_char_to_unibyte):
5591 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5592 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5593 * character.h (CHAR_TO_BYTE8):
5594 * cmds.c (internal_self_insert):
5595 * editfns.c (general_insert_function):
5596 * keymap.c (push_key_description):
5597 * search.c (Freplace_match):
5598 * xdisp.c (message_dolog, set_message_1): All callers changed.
5599
5600 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5601
5602 * keyboard.c (safe_run_hook_funcall): New function.
5603 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5604 don't set the hook to nil, but remove the offending function instead.
5605 (Qcommand_hook_internal): Remove, unused.
5606 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5607 Vcommand_hook_internal.
5608
5609 * eval.c (enum run_hooks_condition): Remove.
5610 (funcall_nil, funcall_not): New functions.
5611 (run_hook_with_args): Call each function through a `funcall' argument.
5612 Remove `cond' argument, now redundant.
5613 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5614 (Frun_hook_with_args_until_failure): Adjust accordingly.
5615 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5616
5617 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5618
5619 * dispextern.h (string_buffer_position): Remove declaration.
5620
5621 * print.c (strout): Remove parameter `multibyte', unused since
5622 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5623
5624 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5625 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5626 All callers changed.
5627
5628 * w32.c (_wsa_errlist): Use braces for struct initializers.
5629
5630 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5631 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5632 All callers changed.
5633 (string_buffer_position): Likewise. Also, make static (it's never
5634 used outside xdisp.c).
5635 (cursor_row_p): Remove parameter `w', unused since
5636 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5637 (decode_mode_spec): Remove parameter `precision', introduced during
5638 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5639 All callers changed.
5640
5641 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5642
5643 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5644
5645 2011-03-27 Anders Lindgren <andlind@gmail.com>
5646
5647 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5648 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5649 (ns_update_auto_hide_menu_bar): New functions.
5650 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5651 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5652 ns_constrain_all_frames.
5653 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5654 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5655
5656 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5657
5658 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5659
5660 2011-03-27 Glenn Morris <rgm@gnu.org>
5661
5662 * syssignal.h: Replace RETSIGTYPE with void.
5663 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5664 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5665 Replace SIGTYPE with void everywhere.
5666 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5667 * s/template.h (SIGTYPE): Remove commented out definition.
5668
5669 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5670
5671 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5672 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5673
5674 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5675
5676 * w32.c (read_unc_volume): Use parameter `henum', instead of
5677 global variable `wget_enum_handle'.
5678
5679 * keymap.c (describe_vector): Remove parameters `indices' and
5680 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5681 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5682
5683 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5684
5685 * keyboard.c (timer_check): Remove parameter `do_it_now',
5686 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5687 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5688 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5689
5690 * keyboard.c (read_char):
5691 * w32menu.c (w32_menu_display_help):
5692 * xmenu.c (show_help_event, menu_help_callback):
5693 Adjust calls to `show_help_echo'.
5694
5695 * gtkutil.c (xg_maybe_add_timer):
5696 * keyboard.c (readable_events):
5697 * process.c (wait_reading_process_output):
5698 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5699
5700 * insdel.c (adjust_markers_gap_motion):
5701 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5702 (gap_left, gap_right): Don't call it.
5703
5704 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5705
5706 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5707 incurred during fontification.
5708
5709 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5710
5711 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5712 (DEFVAR_PER_BUFFER): Don't pass it.
5713
5714 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5715 (scrolling_window): Don't pass it.
5716
5717 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5718
5719 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5720
5721 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5722 and `suffix'.
5723 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5724 of variables specific to SELinux and computation of `encoded_absname'.
5725
5726 * image.c (XPutPixel): Remove unused variable `height'.
5727
5728 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5729
5730 * unexw32.c (get_section_info): Remove unused variable `section'.
5731
5732 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5733 (system_process_attributes): Remove unused variable `sess'.
5734 (sys_read): Remove unused variable `err'.
5735
5736 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5737 (w32_wnd_proc): Remove unused variable `isdead'.
5738 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5739 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5740 (x_create_tip_frame): Remove unused variable `tem'.
5741
5742 * w32inevt.c (w32_console_read_socket):
5743 Remove unused variable `no_events'.
5744
5745 * w32term.c (x_draw_composite_glyph_string_foreground):
5746 Remove unused variable `width'.
5747
5748 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5749
5750 * w32term.c (x_set_glyph_string_clipping):
5751 Don't pass uninitialized region to CombineRgn.
5752
5753 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5754
5755 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5756 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5757 (Fx_close_connection): Remove unused variable `i'.
5758
5759 * w32font.c (w32font_draw): Return number of glyphs.
5760 (w32font_open_internal): Remove unused variable `i'.
5761 (w32font_driver): Add missing initializer.
5762
5763 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5764 (fill_in_menu): Remove unused variable `items_added'.
5765
5766 * w32term.c (last_mouse_press_frame): Remove static global variable.
5767 (w32_clip_to_row): Remove unused variable `f'.
5768 (x_delete_terminal): Remove unused variable `i'.
5769
5770 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5771 (NOTHING): Remove unused static global variable.
5772 (uniscribe_check_otf): Remove unused variable `table'.
5773 (uniscribe_font_driver): Add missing initializers.
5774
5775 2011-03-23 Julien Danjou <julien@danjou.info>
5776
5777 * term.c (Fsuspend_tty, Fresume_tty):
5778 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5779 * window.c (temp_output_buffer_show):
5780 * insdel.c (signal_before_change):
5781 * frame.c (Fhandle_switch_frame):
5782 * fileio.c (Fdo_auto_save):
5783 * emacs.c (Fkill_emacs):
5784 * editfns.c (save_excursion_restore):
5785 * cmds.c (internal_self_insert):
5786 * callint.c (Fcall_interactively):
5787 * buffer.c (Fkill_all_local_variables):
5788 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5789 Use Frun_hooks.
5790 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5791 unconditionnaly since it does the check itself.
5792
5793 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5794
5795 Fix more problems found by GCC 4.5.2's static checks.
5796
5797 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5798 the first time through the loop, since we know p0 < p1 then.
5799 This also avoids a gcc -Wstrict-overflow warning.
5800
5801 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5802 leading to a memory leak, possible in functions like
5803 load_charset_map_from_file that can allocate an unbounded number
5804 of objects (Bug#8318).
5805
5806 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5807 that could (at least in theory) be that large.
5808
5809 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5810 This is less likely to overflow, and avoids undefined behavior if
5811 overflow does occur. All callers changed. Use strtoul to scan
5812 for the unsigned long integer.
5813 (pint2hrstr): Simplify and tune code slightly.
5814 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5815
5816 * scroll.c (do_scrolling): Work around GCC bug 48228.
5817 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5818
5819 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5820 This also avoids a warning with gcc -Wstrict-overflow.
5821 (validate_x_resource_name): Simplify count usage.
5822 This also avoids a warning with gcc -Wstrict-overflow.
5823
5824 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5825 fail (Bug#8306).
5826
5827 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5828
5829 * process.c (Fmake_network_process): Use socklen_t, not int,
5830 where POSIX says socklen_t is required in portable programs.
5831 This fixes a porting bug on hosts like 64-bit HP-UX, where
5832 socklen_t is wider than int (Bug#8277).
5833 (Fmake_network_process, server_accept_connection):
5834 (wait_reading_process_output, read_process_output):
5835 Likewise.
5836
5837 * process.c: Rename or move locals to avoid shadowing.
5838 (list_processes_1, Fmake_network_process):
5839 (read_process_output_error_handler, exec_sentinel_error_handler):
5840 Rename or move locals.
5841 (Fmake_network_process): Define label "retry_connect" only if needed.
5842 (Fnetwork_interface_info): Fix pointer signedness.
5843 (process_send_signal): Add cast to avoid pointer signedness problem.
5844 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5845 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5846
5847 Make tparam.h and terminfo.c consistent.
5848 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5849 Include tparam.h instead, since it declares them.
5850 * cm.h (PC): Remove extern decl; tparam.h now does this.
5851 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5852 * terminfo.c: Include tparam.h, to check interfaces.
5853 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5854 (tparam): Adjust signature to match interface in tparam.h;
5855 this removes some undefined behavior. Check that outstring and len
5856 are zero, which they always are with Emacs.
5857 * tparam.h (PC, BC, UP): New extern decls.
5858
5859 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5860 (xftfont_open): Rename locals to avoid shadowing.
5861
5862 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5863 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5864 (OTF_TAG_SYM): Omit macro if not needed.
5865 (ftfont_list): Remove unused local.
5866 (get_adstyle_property, ftfont_pattern_entity):
5867 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5868 Rename locals to avoid shadowing.
5869
5870 * xfont.c (xfont_list_family): Mark var as initialized.
5871
5872 * xml.c (make_dom): Now static.
5873
5874 * composite.c (composition_compute_stop_pos): Rename local to
5875 avoid shadowing.
5876 (composition_reseat_it): Remove unused locals.
5877 (find_automatic_composition, composition_adjust_point): Likewise.
5878 (composition_update_it): Mark var as initialized.
5879 (find_automatic_composition): Mark vars as initialized,
5880 with a FIXME (Bug#8290).
5881
5882 character.h: Rename locals to avoid shadowing.
5883 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5884 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5885 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5886 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5887 to avoid shadowing.
5888
5889 * textprop.c (property_change_between_p): Remove; unused.
5890
5891 * intervals.c (interval_start_pos): Now static.
5892
5893 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5894
5895 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5896 Rename locals to avoid shadowing.
5897
5898 * sound.c (wav_play, au_play, Fplay_sound_internal):
5899 Fix pointer signedness.
5900 (alsa_choose_format): Remove unused local var.
5901 (wav_play): Initialize a variable to 0, to prevent undefined
5902 behavior (Bug#8278).
5903
5904 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5905
5906 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5907
5908 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5909 clobbering (Bug#8298).
5910 * sysdep.c (sys_subshell): Likewise.
5911 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5912
5913 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5914 This should get cleaned up, so that child_setup has the
5915 same signature on all platforms.
5916
5917 * callproc.c (call_process_cleanup): Now static.
5918 (relocate_fd): Rename locals to avoid shadowing.
5919
5920 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5921
5922 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5923 not to be necessary, and produces flickering.
5924
5925 2011-03-20 Glenn Morris <rgm@gnu.org>
5926
5927 * config.in: Remove file.
5928
5929 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5930
5931 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5932 are now in src/globals.h.
5933 (syms_of_minibuf): Remove spurious & from previous change.
5934
5935 2011-03-20 Leo <sdl.web@gmail.com>
5936
5937 * minibuf.c (completing-read-function): New variable.
5938 (completing-read-default): Rename from completing-read.
5939 (completing-read): Call completing-read-function.
5940
5941 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5942
5943 * xfaces.c (Fx_load_color_file):
5944 Read color file from absolute filename (bug#8250).
5945
5946 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5947
5948 * makefile.w32-in: Update dependencies.
5949
5950 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5951
5952 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5953
5954 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5955
5956 Fix more problems found by GCC 4.5.2's static checks.
5957
5958 * process.c (make_serial_process_unwind, send_process_trap):
5959 (sigchld_handler): Now static.
5960
5961 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5962 That way, the code declares only the vars that it needs.
5963 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5964 * s/cygwin.h (PTY_ITERATION): Likewise.
5965 * s/darwin.h (PTY_ITERATION): Likewise.
5966 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5967
5968 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5969 * process.c (allocate_pty): Don't declare stb unless it's needed.
5970
5971 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5972 (CONSTANTLIM): Remove; unused.
5973 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5974 Define only if needed.
5975
5976 * unexelf.c (unexec): Name an expression,
5977 to avoid gcc -Wbad-function-cast warning.
5978 Use a different way to cause a compilation error if anyone uses
5979 n rather than nn, a way that does not involve shadowing.
5980 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5981
5982 * deps.mk (unexalpha.o): Remove; unused.
5983
5984 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5985 * unexec.h: New file.
5986 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5987 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5988 Depend on unexec.h.
5989 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5990 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5991 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5992 Change as necessary to match prototype in unexec.h.
5993
5994 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5995 shadowing.
5996 (back_comment, skip_chars): Mark vars as initialized.
5997
5998 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5999 Rename locals to avoid shadowing.
6000
6001 * lread.c (read1): Rewrite so as not to use empty "else".
6002 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6003
6004 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6005
6006 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6007 warning when compiling print.c.
6008
6009 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6010 instead of using an uninitialized var.
6011 (font_sort_entities): Mark var as initialized.
6012
6013 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6014
6015 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6016 pointers to constants.
6017 (font_parse_fcname): Remove unused vars.
6018 (font_delete_unmatched): Now static.
6019 (font_get_spec): Remove; unused.
6020 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6021 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6022 Rename or move locals to avoid shadowing.
6023
6024 * fns.c (require_nesting_list, require_unwind): Now static.
6025 (Ffillarray): Rename locals to avoid shadowing.
6026
6027 * floatfns.c (domain_error2): Define only if needed.
6028 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6029
6030 * alloc.c (mark_backtrace): Move decl from here ...
6031 * lisp.h: ... to here, so that it can be checked.
6032
6033 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6034 (Fdefvar): Rewrite so as not to use empty "else".
6035 (lisp_indirect_variable): Name an expression,
6036 to avoid gcc -Wbad-function-cast warning.
6037 (Fdefvar): Rename locals to avoid shadowing.
6038
6039 * callint.c (quotify_arg, quotify_args): Now static.
6040 (Fcall_interactively): Rename locals to avoid shadowing.
6041 Use const pointer when appropriate.
6042
6043 * lisp.h (get_system_name, get_operating_system_release):
6044 Move decls here, to check interfaces.
6045 * process.c (get_operating_system_release): Move decl to lisp.h.
6046 * xrdb.c (get_system_name): Likewise.
6047 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6048 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6049 some of which prompt warnings from gcc -Wbad-function-cast.
6050 (Fformat_time_string, Fencode_time, Finsert_char):
6051 (Ftranslate_region_internal, Fformat):
6052 Rename or remove local vars to avoid shadowing.
6053 (Ftranslate_region_internal): Mark var as initialized.
6054
6055 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6056 avoid shadowing.
6057
6058 * lisp.h (eassert): Check that the argument compiles, even if
6059 ENABLE_CHECKING is not defined.
6060
6061 * data.c (Findirect_variable): Name an expression, to avoid
6062 gcc -Wbad-function-cast warning.
6063 (default_value, arithcompare, arith_driver, arith_error): Now static.
6064 (store_symval_forwarding): Rename local to avoid shadowing.
6065 (Fmake_variable_buffer_local, Fmake_local_variable):
6066 Mark variables as initialized.
6067 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6068
6069 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6070 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6071 Rename locals to avoid shadowing.
6072 (mark_stack): Move local variables into the #ifdef region where
6073 they're used.
6074 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6075 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6076 needed otherwise.
6077 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6078 (GC_STRING_CHARS): Remove; not used.
6079 (Fmemory_limit): Cast sbrk's returned value to char *.
6080
6081 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6082 avoids undefined behavior in theory.
6083
6084 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6085
6086 Use functions, not macros, for up- and down-casing (Bug#8254).
6087 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6088 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6089 to use the following functions instead of these macros.
6090 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6091 EMACS_INT, since callers assume the returned value fits in int.
6092 (upcase1): Likewise, for UPCASE_TABLE.
6093 (uppercasep, lowercasep, upcase): New static inline functions.
6094 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6095 the race-condition problem in the old DOWNCASE.
6096
6097 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6098 Rename locals to avoid shadowing.
6099 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6100 (regex_compile, re_search_2, re_match_2_internal):
6101 Remove unused local vars.
6102 (FREE_VAR): Rewrite so as not to use empty "else",
6103 which gcc can warn about.
6104 (regex_compile, re_match_2_internal): Mark locals as initialized.
6105 (RETALLOC_IF): Define only if needed.
6106 (WORDCHAR_P): Likewise. This one is never needed, but is used
6107 only in a comment talking about a compiler bug, so put inside
6108 the #if 0 of that comment.
6109 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6110 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6111 Remove; unused.
6112
6113 * search.c (boyer_moore): Rename locals to avoid shadowing.
6114 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6115 (PREV_CHAR_BOUNDARY): Likewise.
6116
6117 * search.c (simple_search): Remove unused var.
6118
6119 * dired.c (compile_pattern): Move decl from here ...
6120 * lisp.h: ... to here, so that it can be checked.
6121 (struct re_registers): New forward decl.
6122
6123 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6124
6125 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6126 All uses changed.
6127 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6128 Rename locals to avoid shadowing.
6129 (Fvertical_motion): Mark locals as initialized.
6130
6131 * casefiddle.c (casify_object, casify_region): Now static.
6132 (casify_region): Mark local as initialized.
6133
6134 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6135
6136 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6137 New macros, so that the caller can use some names other than
6138 gcpro1, gcpro2, etc.
6139 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6140 of the new macros.
6141 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6142 argument, for consistency with GCPRO2_VAR, etc: it is now the
6143 prefix of the variable, not the variable itself. All uses
6144 changed.
6145 * dired.c (directory_files_internal, file_name_completion):
6146 Rename locals to avoid shadowing.
6147
6148 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6149 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6150 dired.c's scmp function, had undefined behavior.
6151 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6152 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6153 * buffer.h: ... to here, because these macros use current_buffer,
6154 and the new implementation with inline functions needs to have
6155 current_buffer in scope now, rather than later when the macros
6156 are used.
6157 (downcase, upcase1): New static inline functions.
6158 (DOWNCASE, UPCASE1): Reimplement using these functions.
6159 This avoids undefined behavior in expressions like
6160 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6161 from race conditions in accessing the global variables
6162 case_temp1 and case_temp2.
6163 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6164 * lisp.h (case_temp1, case_temp2): Remove their decls.
6165 * character.h (ASCII_CHAR_P): Move from here ...
6166 * lisp.h: ... to here, so that the inline functions mentioned
6167 above can use them.
6168
6169 * dired.c (directory_files_internal_unwind): Now static.
6170
6171 * fileio.c (file_name_as_directory, directory_file_name):
6172 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6173 Now static.
6174 (file_name_as_directory): Use const pointers when appropriate.
6175 (Fexpand_file_name): Likewise. In particular, newdir might
6176 point at constant storage, so make it a const pointer.
6177 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6178 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6179 signedness issues.
6180 (Fset_file_times, Finsert_file_contents, auto_save_error):
6181 Rename locals to avoid shadowing.
6182
6183 * minibuf.c (choose_minibuf_frame_1): Now static.
6184 (Ftry_completion, Fall_completions): Rename or remove locals
6185 to avoid shadowing.
6186
6187 * marker.c (bytepos_to_charpos): Remove; unused.
6188
6189 * lisp.h (verify_bytepos, count_markers): New decls,
6190 so that gcc does not warn that these functions aren't declared.
6191
6192 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6193 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6194 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6195 (copy_text): Remove unused local var.
6196
6197 * filelock.c (within_one_second): Now static.
6198 (lock_file_1): Rename local to avoid shadowing.
6199
6200 * buffer.c (fix_overlays_before): Mark locals as initialized.
6201 (fix_start_end_in_overlays): Likewise. This function should be
6202 simplified by using pointers-to-pointers, but that's a different
6203 matter.
6204 (switch_to_buffer_1): Now static.
6205 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6206 (report_overlay_modification): Rename locals to avoid shadowing.
6207
6208 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6209 Fix pointer signedness issue.
6210 (sys_subshell): Mark local as volatile if checking for lint,
6211 to suppress a gcc -Wclobbered warning that does not seem to be right.
6212 (MAXPATHLEN): Define only if needed.
6213
6214 * process.c (serial_open, serial_configure): Move decls from here ...
6215 * systty.h: ... to here, so that they can be checked.
6216
6217 * fns.c (get_random, seed_random): Move extern decls from here ...
6218 * lisp.h: ... to here, so that they can be checked.
6219
6220 * sysdep.c (reset_io): Now static.
6221 (wait_for_termination_signal): Remove; unused.
6222
6223 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6224 (copy_keymap_item, append_key, push_text_char_description):
6225 Now static.
6226 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6227 (DENSE_TABLE_SIZE): Remove; unused.
6228 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6229 (describe_map_tree):
6230 Rename locals to avoid shadowing.
6231
6232 * keyboard.c: Declare functions static if they are not used elsewhere.
6233 (echo_char, echo_dash, cmd_error, top_level_2):
6234 (poll_for_input, handle_async_input): Now static.
6235 (read_char, kbd_buffer_get_event, make_lispy_position):
6236 (make_lispy_event, make_lispy_movement, apply_modifiers):
6237 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6238 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6239 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6240 (read_key_sequence, read_char): Mark locals as initialized.
6241 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6242
6243 * keyboard.h (make_ctrl_char): New decl.
6244 (mark_kboards): Move decl here ...
6245 * alloc.c (mark_kboards): ... from here.
6246
6247 * lisp.h (force_auto_save_soon): New decl.
6248
6249 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6250 (DEFINE_DUMMY_FUNCTION): New macro.
6251 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6252 Use it.
6253 (main): Add casts to avoid warnings
6254 if GCC considers string literals to be constants.
6255
6256 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6257
6258 * dbusbind.c: Pointer signedness fixes.
6259 (xd_signature, xd_append_arg, xd_initialize):
6260 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6261 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6262 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6263 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6264
6265 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6266 if GCC considers string literals to be constants.
6267 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6268
6269 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6270
6271 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6272 (print_preprocess, print_object): New macro to fix last change.
6273
6274 * print.c (print_preprocess): Don't forget font objects.
6275
6276 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6277
6278 * emacs.c (USAGE3): Doc fixes.
6279
6280 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6281
6282 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6283 structure.
6284
6285 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6286
6287 * lisp.h (VWindow_system, Qfile_name_history):
6288 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6289 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6290 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6291
6292 * w32select.c: Don't #include "keyboard.h".
6293 (run_protected): Add extern declaration for waiting_for_input.
6294
6295 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6296 * w32console.c (detect_input_pending, read_input_pending)
6297 (encode_terminal_code):
6298 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6299 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6300 (w32_system_caret_y, Qfile_name_history):
6301 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6302 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6303 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6304 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6305 * w32proc.c (Qlocal, report_file_error):
6306 * w32term.c (Vwindow_system, updating_frame):
6307 * w32uniscribe.c (initialized, uniscribe_font_driver):
6308 Remove unneeded extern declarations.
6309
6310 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6311
6312 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6313
6314 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6315
6316 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6317 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6318 These macros can no longer be used for assignment.
6319
6320 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6321 Assign struct members directly, instead of using BUF_BEGV etc.
6322 (record_buffer_markers, fetch_buffer_markers): New functions for
6323 recording and fetching special buffer markers.
6324 (set_buffer_internal_1, set_buffer_temp): Use them.
6325
6326 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6327
6328 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6329
6330 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6331 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6332
6333 * xdisp.c (hscroll_window_tree):
6334 (reconsider_clip_changes): Use PT instead of BUF_PT.
6335
6336 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6337
6338 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6339 $(EMACS_ROOT)/lib/intprops.h.
6340
6341 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6342
6343 Fix more problems found by GCC 4.5.2's static checks.
6344
6345 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6346 to unsigned char * to avoid compiler diagnostic.
6347 (xg_free_frame_widgets): Make it clear that a local variable is
6348 needed only if USE_GTK_TOOLTIP.
6349 (gdk_window_get_screen): Make it clear that this macro is needed
6350 only if USE_GTK_TOOLTIP.
6351 (int_gtk_range_get_value): New function, which avoids a diagnostic
6352 from gcc -Wbad-function-cast.
6353 (xg_set_toolkit_scroll_bar_thumb): Use it.
6354 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6355 diagnostic from gcc -Wbad-function-cast.
6356 (get_utf8_string, xg_get_file_with_chooser):
6357 Rename locals to avoid shadowing.
6358 (create_dialog): Move locals to avoid shadowing.
6359
6360 * xgselect.c (xg_select): Remove unused var.
6361
6362 * image.c (four_corners_best): Mark locals as initialized.
6363 (gif_load): Initialize transparent_p to zero (Bug#8238).
6364 Mark another local as initialized.
6365 (my_png_error, my_error_exit): Mark with NO_RETURN.
6366
6367 * image.c (clear_image_cache): Now static.
6368 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6369 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6370 (x_edge_detection): Remove unnecessary cast that
6371 gcc -Wbad-function-cast diagnoses.
6372 (gif_load): Fix pointer signedness.
6373 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6374 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6375
6376 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6377
6378 Improve quality of tests for time stamp overflow.
6379 For example, without this patch (encode-time 0 0 0 1 1
6380 1152921504606846976) returns the obviously-bogus value (-948597
6381 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6382 reports time overflow. See
6383 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6384 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6385 * editfns.c: Include limits.h and intprops.h.
6386 (TIME_T_MIN, TIME_T_MAX): New macros.
6387 (time_overflow): Move earlier, to before first use.
6388 (hi_time, lo_time): New functions, for an accurate test for
6389 out-of-range times.
6390 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6391 (Fget_internal_run_time): Don't assume time_t fits in int.
6392 (make_time): Use list2 instead of Fcons twice.
6393 (Fdecode_time): More accurate test for out-of-range times.
6394 (check_tm_member): New function.
6395 (Fencode_time): Use it, to test for out-of-range times.
6396 (lisp_time_argument): Don't rely on undefined left-shift and
6397 right-shift behavior when checking for time stamp overflow.
6398
6399 * editfns.c (time_overflow): New function, refactoring common code.
6400 (Fformat_time_string, Fdecode_time, Fencode_time):
6401 (Fcurrent_time_string): Use it.
6402
6403 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6404 * dired.c (make_time): Move to ...
6405 * editfns.c (make_time): ... here.
6406 * systime.h: Note the move.
6407
6408 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6409
6410 * fringe.c (update_window_fringes): Remove unused variables.
6411
6412 * unexmacosx.c (copy_data_segment): Also copy __got section.
6413 (Bug#8223)
6414
6415 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6416
6417 * termcap.c [MSDOS]: Include "msdos.h".
6418 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6419 Constify `char *' arguments and their references according to
6420 prototypes in tparam.h.
6421
6422 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6423
6424 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6425 Adapt all references accordingly.
6426
6427 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6428
6429 2011-03-11 Tom Tromey <tromey@redhat.com>
6430
6431 * buffer.c (syms_of_buffer): Remove obsolete comment.
6432
6433 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6434
6435 * termhooks.h (encode_terminal_code): Declare prototype.
6436
6437 * msdos.c (encode_terminal_code): Don't declare prototype.
6438
6439 * term.c (encode_terminal_code): Now external again, used by
6440 w32console.c and msdos.c.
6441
6442 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6443 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6444
6445 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6446
6447 Fix some minor problems found by GCC 4.5.2's static checks.
6448
6449 * fringe.c (update_window_fringes): Mark locals as initialized
6450 (Bug#8227).
6451 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6452
6453 * alloc.c (mark_fringe_data): Move decl from here ...
6454 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6455 to check its interface.
6456 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6457
6458 * fontset.c (free_realized_fontset): Now static.
6459 (Fset_fontset_font): Rename local to avoid shadowing.
6460 (fontset_font): Mark local as initialized.
6461 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6462
6463 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6464
6465 * xselect.c (x_disown_buffer_selections): Remove; not used.
6466 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6467 (x_own_selection, Fx_disown_selection_internal): Rename locals
6468 to avoid shadowing.
6469 (x_handle_dnd_message): Remove local to avoid shadowing.
6470
6471 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6472 so that the caller can use some name other than gcpro1.
6473 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6474 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6475 (Fx_backspace_delete_keys_p):
6476 Use them to avoid shadowing, and rename vars to avoid shadowing.
6477 (x_decode_color, x_set_name, x_window): Now static.
6478 (Fx_create_frame): Add braces to silence GCC warning.
6479 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6480 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6481 Remove unused locals.
6482 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6483 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6484 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6485 macros.
6486
6487 * xterm.h (x_mouse_leave): New decl.
6488
6489 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6490 Remove unused functions.
6491 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6492 (x_calc_absolute_position): Now static.
6493 (XTread_socket): Don't define label "out" unless it's used.
6494 Don't declare local "event" unless it's used.
6495 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6496 unless they are used.
6497 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6498 (x_fatal_error_signal): Remove; not used.
6499 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6500 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6501 (x_error_catcher, x_connection_closed, x_error_handler):
6502 (x_error_quitter, xembed_send_message, x_iconify_frame):
6503 (my_log_handler): Rename locals to avoid shadowing.
6504 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6505 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6506
6507 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6508 Rename or move locals to avoid shadowing.
6509 (tty_defined_color, merge_face_heights): Now static.
6510 (free_realized_faces_for_fontset): Remove; not used.
6511 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6512 does not deduce is never used uninitialized.
6513 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6514 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6515
6516 * terminal.c (store_terminal_param): Now static.
6517
6518 * xmenu.c (menu_highlight_callback): Now static.
6519 (set_frame_menubar): Remove unused local.
6520 (xmenu_show): Rename parameter to avoid shadowing.
6521 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6522 since they might point to immutable storage.
6523 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6524 since it's unused otherwise.
6525
6526 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6527 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6528 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6529 avoids a gcc -Wuninitialized diagnostic.
6530 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6531 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6532 does not deduce are never used uninitialized.
6533
6534 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6535
6536 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6537 * window.c (window_loop, size_window):
6538 (run_window_configuration_change_hook, enlarge_window): Likewise.
6539
6540 * window.c (display_buffer): Now static.
6541 (size_window): Mark variables that gcc -Wuninitialized
6542 does not deduce are never used uninitialized.
6543 * window.h (check_all_windows): New decl, to forestall
6544 gcc -Wmissing-prototypes diagnostic.
6545 * dispextern.h (bidi_dump_cached_states): Likewise.
6546
6547 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6548 shadowing.
6549 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6550 Include <limits.h>.
6551 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6552 and to avoid gcc -Wuninitialized warning.
6553 (load_charset_map): Mark variables that gcc -Wuninitialized
6554 does not deduce are never used uninitialized.
6555 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6556
6557 * coding.c (coding_set_source, coding_set_destination):
6558 Use "else { /* comment */ }" rather than "else /* comment */;"
6559 for clarity, and to avoid gcc -Wempty-body warning.
6560 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6561 a block, when the outer 'i' will do.
6562 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6563 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6564 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6565 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6566 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6567 Rename locals to avoid shadowing.
6568 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6569 * coding.c (emacs_mule_char, encode_invocation_designation):
6570 Now static, since they're not used elsewhere.
6571 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6572 (decode_coding_object, encode_coding_object, detect_coding_system):
6573 (decode_coding_emacs_mule): Mark variables that gcc
6574 -Wuninitialized does not deduce are never used uninitialized.
6575 (detect_coding_iso_2022): Initialize a local variable that might
6576 be used uninitialized. Leave a FIXME because it's not clear that
6577 this initialization is needed. (Bug#8211)
6578 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6579 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6580 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6581 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6582 Remove unused macros.
6583
6584 * category.c (hash_get_category_set): Remove unused local var.
6585 (copy_category_table): Now static, since it's not used elsewhere.
6586 * character.c (string_count_byte8): Likewise.
6587
6588 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6589 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6590
6591 * chartab.c (copy_sub_char_table): Now static, since it's not used
6592 elsewhere.
6593 (sub_char_table_ref_and_range, char_table_ref_and_range):
6594 Rename locals to avoid shadowing.
6595 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6596
6597 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6598 (BIDI_BOB): Remove unused macro.
6599
6600 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6601 deduce are never used uninitialized.
6602 * term.c (encode_terminal_code): Likewise.
6603
6604 * term.c (encode_terminal_code): Now static. Remove unused local.
6605
6606 * tparam.h: New file.
6607 * term.c, tparam.h: Include it.
6608 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6609 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6610 Move these decls to tparam.h, and make them agree with what
6611 is actually in tparam.c. The previous trick of using incompatible
6612 decls in different modules does not conform to the C standard.
6613 All callers of tparam changed to use tparam's actual API.
6614 * tparam.c (tparam1, tparam, tgoto):
6615 Use const pointers where appropriate.
6616
6617 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6618 * cm.h (struct cm): Likewise.
6619 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6620 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6621 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6622 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6623 (turn_on_face, init_tty): Likewise.
6624 * termchar.h (struct tty_display_info): Likewise.
6625
6626 * term.c (term_mouse_position): Rename local to avoid shadowing.
6627
6628 * alloc.c (mark_ttys): Move decl from here ...
6629 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6630
6631 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6632
6633 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6634
6635 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6636
6637 * search.c (compile_pattern_1): Remove argument regp, unused since
6638 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6639 (compile_pattern): Don't pass it.
6640
6641 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6642
6643 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6644 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6645 for ! HAVE_GTK3.
6646 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6647
6648 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6649
6650 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6651 gdk_window_get_screen, gdk_window_get_geometry,
6652 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6653 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6654 (xg_get_pixbuf_from_pixmap): New function.
6655 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6656 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6657 Call xg_get_pixbuf_from_pixmap instead of
6658 gdk_pixbuf_get_from_drawable.
6659 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6660 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6661 (xg_check_special_colors): Use GtkStyleContext and its functions
6662 for HAVE_GTK3.
6663 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6664 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6665 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6666 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6667 Call gtk_widget_get_preferred_size.
6668 (xg_frame_resized): gdk_window_get_geometry only takes 5
6669 parameters.
6670 (xg_win_to_widget, xg_event_is_for_menubar):
6671 Call gdk_x11_window_lookup_for_display.
6672 (xg_set_widget_bg): New function.
6673 (delete_cb): New function.
6674 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6675 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6676 (xg_set_background_color): Call xg_set_widget_bg.
6677 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6678 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6679 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6680 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6681 if ! HAVE_GTK3.
6682 (update_frame_tool_bar): Call gtk_widget_hide.
6683 (xg_initialize): Use GDK_KEY_g.
6684
6685 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6686 if ! HAVE_GTK3
6687 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6688
6689 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6690 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6691 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6692
6693 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6694
6695 * w32xfns.c (select_palette): Check success of RealizePalette against
6696 GDI_ERROR, not zero.
6697
6698 See ChangeLog.11 for earlier changes.
6699
6700 ;; Local Variables:
6701 ;; coding: utf-8
6702 ;; End:
6703
6704 Copyright (C) 2011 Free Software Foundation, Inc.
6705
6706 This file is part of GNU Emacs.
6707
6708 GNU Emacs is free software: you can redistribute it and/or modify
6709 it under the terms of the GNU General Public License as published by
6710 the Free Software Foundation, either version 3 of the License, or
6711 (at your option) any later version.
6712
6713 GNU Emacs is distributed in the hope that it will be useful,
6714 but WITHOUT ANY WARRANTY; without even the implied warranty of
6715 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6716 GNU General Public License for more details.
6717
6718 You should have received a copy of the GNU General Public License
6719 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.