1 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5 2012-01-11 Eli Zaretskii <eliz@gnu.org>
7 * xdisp.c (rows_from_pos_range): Handle the case where the
8 highlight ends on a newline. (Bug#10464)
9 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
10 he end column for display of highlight that ends on a newline
13 2012-01-11 Glenn Morris <rgm@gnu.org>
15 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
16 from load-path also when installation-directory is nil. (Bug#10208)
18 2012-01-10 Glenn Morris <rgm@gnu.org>
20 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
22 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
23 Update template values to be closer to their typical values these days.
25 2012-01-09 Eli Zaretskii <eliz@gnu.org>
27 * xdisp.c (rows_from_pos_range): Accept additional argument
28 DISP_STRING, and accept any glyph in a row whose object is that
29 string as eligible for mouse highlight. Fixes mouse highlight of
30 display strings from overlays. (Bug#10464)
32 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
34 emacs: fix an auto-save permissions race condition (Bug#10400)
35 * fileio.c (auto_saving_dir_umask): New static var.
36 (Fmake_directory_internal): Use it.
37 (do_auto_save_make_dir): Set it, instead of invoking chmod after
38 creating the directory. The old code temporarily assigns
39 too-generous permissions to the directory.
40 (do_auto_save_eh): Clear it.
41 (Fdo_auto_save): Catch all errors, not just file errors, so
42 that the var is always cleared.
44 2012-01-07 Eli Zaretskii <eliz@gnu.org>
46 * search.c (scan_buffer): Pass character positions to
47 know_region_cache, not byte positions. (Bug#6540)
49 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
51 * w32.c (sys_rename): Report EXDEV when rename of a directory
52 fails because the target is on another logical disk. (Bug#10284)
54 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
56 * xterm.c (x_embed_request_focus): New function.
58 * xterm.h: Add prototype.
60 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
62 2012-01-05 Glenn Morris <rgm@gnu.org>
64 * emacs.c (emacs_copyright): Update short copyright year to 2012.
66 2012-01-01 Eli Zaretskii <eliz@gnu.org>
68 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
69 Load gnutls_transport_set_lowat only if GnuTLS version is below
71 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
72 GnuTLS versions below 2.11.1.
74 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
76 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
77 to the doc string advising against its use for altering the way
80 2011-12-28 Kenichi Handa <handa@m17n.org>
82 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
83 coding-system ASCII compatible only when it does not produce BOM
84 on encoding (Bug#10383).
86 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
88 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
90 (create_and_show_popup_menu): Always use menu_position_func for
93 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
95 * callint.c (Fcall_interactively): Don't truncate prompt string.
97 2011-12-23 Eli Zaretskii <eliz@gnu.org>
99 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
100 property that ends at ZV, so that the bidi iteration could be
101 resumed from there (after widening). (Bug#10360)
103 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
105 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
107 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
109 * nsterm.m (x_free_frame_resources):
110 Release f->output_data.ns->miniimage.
111 (ns_index_color): Fix indentation. Do not retain
112 color_table->colors[i].
114 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
117 * nsfns.m (x_set_background_color): Assign return value from
118 ns_index_color to face-background instead of NSColor*.
119 (ns_implicitly_set_icon_type): Fix indentation.
120 Change assignment in for loop to comparison.
122 * emacs.c (ns_pool): New variable.
123 (main): Assign ns_pool.
124 (Fkill_emacs): Call ns_release_autorelease_pool.
126 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
127 autorelease fdesc, release fdAttrs and tdict.
128 (ns_get_covering_families): Release charset.
129 (ns_findfonts): Release NSFontDescriptor created with new.
130 (ns_uni_to_glyphs): Fix indentation.
131 (setString): Release attrStr before assigning new value.
133 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
135 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
137 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
138 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
140 2011-12-18 David Reitter <reitter@cmu.edu>
142 * nsterm.m (ns_term_init): Subscribe for notifications
143 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
144 to method trackingNotification in EmacsMenu.
146 * nsmenu.m (trackingMenu): New variable.
147 (trackingNotification): New method (from Aquamacs).
148 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
149 from Aquamacs (Bug#7030).
151 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
153 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
154 (symbol_to_nsstring): Fix indentation.
155 (ns_symbol_to_pb): New function.
156 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
157 (Fns_rotate_cut_buffers_internal): Removed.
158 (Fns_store_selection_internal): Renamed from
159 Fns_store_cut_buffer_internal.
160 (ns_get_foreign_selection, Fx_own_selection_internal)
161 (Fx_disown_selection_internal, Fx_selection_exists_p)
162 (Fns_get_selection_internal, Fns_store_selection_internal):
163 Use ns_symbol_to_pb and check if return value is nil.
164 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
165 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
166 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
167 renamed to Sns_store_selection_internal.
168 (ns_handle_selection_request): Move code to Fx_own_selection_internal
169 and remove this function.
170 (ns_handle_selection_clear): Remove, never used.
171 (Fx_own_selection_internal): Move code from ns_handle_selection_request
174 2011-12-17 Ken Brown <kbrown@cornell.edu>
176 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
177 GID is unknown (Bug#10257).
179 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
181 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
182 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
183 which caused a build failure on GNU/Linux IA-64. This problem was
184 introduced by my 2011-10-07 patch.
186 2011-12-15 Juri Linkov <juri@jurta.org>
188 * image.c (imagemagick_error): New function. (Bug#10112)
189 (imagemagick_load_image): Comment out `MagickSetResolution' call.
190 Use `imagemagick_error' where ImageMagick functions return
192 (Fimagemagick_types): Add `Fnreverse' to return the list in the
195 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
197 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
198 fill background (Bug#8992).
200 2011-12-13 Martin Rudalics <rudalics@gmx.at>
202 * window.c (Vwindow_combination_resize)
203 (Vwindow_combination_limit): Use t instead of non-nil in
205 (Vrecenter_redisplay): Add first sentence of doc-string on
207 (Frecenter): Fix doc-string typo.
209 2011-12-11 Kenichi Handa <handa@m17n.org>
211 * coding.c (Funencodable_char_position): Pay attention to the
212 buffer text relocation (Bug#9389).
214 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
216 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
217 gtk_init (Bug#10100).
219 2011-12-10 Eli Zaretskii <eliz@gnu.org>
221 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
222 IT->string is nil. (Bug#10263)
224 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
226 * nsterm.h (x_free_frame_resources): Declare.
228 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
229 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
231 * nsterm.h (ns_get_defaults_value): Declare.
233 * nsterm.m (ns_default): Call ns_get_defaults_value.
235 2011-12-09 Eli Zaretskii <eliz@gnu.org>
237 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
240 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
242 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
243 that where the value of an _OBJC_* symbol points to is in the .bss
246 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
248 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
249 after the loop to call ccl_driver at least once (Bug#8619).
251 2011-12-08 Kenichi Handa <handa@m17n.org>
253 * ftfont.c (get_adstyle_property): Fix previous change
256 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
258 * w32.c (init_environment): If no_site_lisp, remove site-lisp
259 dirs from the default value of EMACSLOADPATH (bug#10208).
261 2011-12-07 Glenn Morris <rgm@gnu.org>
263 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
264 installation and source directories as well. (Bug#10208)
266 2011-12-06 Chong Yidong <cyd@gnu.org>
268 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
270 2011-12-06 Glenn Morris <rgm@gnu.org>
272 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
273 as an error, not just -1. (Bug#10217)
275 2011-12-05 Chong Yidong <cyd@gnu.org>
277 * keyboard.c (process_special_events): New function.
278 (swallow_events, Finput_pending_p): Use it (Bug#10195).
280 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
282 * coding.c (encode_designation_at_bol): Don't use uninitialized
283 local variable (Bug#9318).
285 2011-12-05 Kenichi Handa <handa@m17n.org>
287 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
288 return Qnil (Bug#8046, Bug#10193).
290 2011-12-05 Kenichi Handa <handa@m17n.org>
292 * coding.c (encode_designation_at_bol): New args charbuf_end and
293 dst. Return the number of produced bytes. Callers changed.
294 (coding_set_source): Return how many bytes coding->source was
296 (coding_set_destination): Return how many bytes
297 coding->destination was relocated.
298 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
299 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
301 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
303 * coding.c (CODING_CHAR_CHARSET_P): New macro.
304 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
307 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
309 The following changes are to fix Bug#9318.
311 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
312 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
313 (encode_coding_iso_2022, encode_coding_sjis)
314 (encode_coding_big5, encode_coding_charset): Use the above macros.
316 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
318 * lisp.h (process_quit_flag): Fix external declaration.
320 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
322 Don't macro-inline non-performance-critical code.
323 * eval.c (process_quit_flag): New function.
324 * lisp.h (QUIT): Use it.
326 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
328 * nsfns.m (get_geometry_from_preferences): New function.
329 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
331 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
333 * emacs.c (Qkill_emacs): Define.
334 (syms_of_emacs): Initialize it.
335 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
336 Qquit_flag to `kill-emacs' instead.
337 (quit_throw_to_read_char): Add parameter `from_signal'.
338 All callers changed. Call Fkill_emacs if requested and safe.
339 * lisp.h (QUIT): Call Fkill_emacs if requested.
341 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
343 * widget.c (update_wm_hints): Return if wmshell is null.
344 (widget_update_wm_size_hints): New function.
346 * widget.h (widget_update_wm_size_hints): Declare.
348 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
349 widget_update_wm_size_hints (Bug#10104).
351 2011-12-03 Eli Zaretskii <eliz@gnu.org>
353 * xdisp.c (handle_invisible_prop): If the invisible text ends just
354 before a newline, prepare the bidi iterator for consuming the
355 newline, and keep the current paragraph direction. (Bug#10183)
356 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
358 2011-12-02 Juri Linkov <juri@jurta.org>
360 * search.c (Fword_search_regexp): New Lisp function created from
361 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
362 (Fword_search_backward, Fword_search_forward)
363 (Fword_search_backward_lax, Fword_search_forward_lax):
364 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
365 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
367 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
369 * fileio.c (Finsert_file_contents): Move after-change-function call
370 to before the "handled:" label, since all "goto handled" appear in
371 cases where the *-change-functions have already been properly called
374 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
376 * keyboard.c (interrupt_signal): Don't call kill-emacs when
377 waiting for input. (Bug#10169)
379 2011-11-30 Eli Zaretskii <eliz@gnu.org>
381 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
382 verifies glyph row's hash code--we have just reallocated the
383 glyphs, so their contents can be complete garbage. (Bug#10164)
385 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
387 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
389 2011-11-30 Eli Zaretskii <eliz@gnu.org>
391 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
392 attributes are tested _before_ calling verify_row_hash, to protect
393 against GCC re-ordering of the tests. (Bug#10164)
395 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
397 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
399 * xterm.c (handle_one_xevent): Only set async_visible and friends
400 if net_wm_state_hidden_seen is non-zero (Bug#10002)
401 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
402 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
404 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
406 Remove GCPRO-related macros that exist only to avoid shadowing locals.
407 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
408 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
409 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
410 All uses changed to use GCPRO1 etc.
411 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
412 Revert to old implementation (i.e., before 2011-03-11).
414 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
416 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
417 of scroll runs so as to avoid assigning disabled bogus rows and
418 unnecessary graphics copy operations.
420 2011-11-27 Eli Zaretskii <eliz@gnu.org>
422 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
423 (snprintf) [_MSC_VER]: Redirect to _snprintf.
424 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
425 (malloc, free, realloc, calloc): Redirect to e_* only when
428 * lisp.h (GCTYPEBITS): Move before first use.
429 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
430 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
431 this macro definition.
433 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
436 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
438 * gtkutil.c (xg_create_frame_widgets):
439 Call gtk_window_set_has_resize_grip (FALSE) if that function is
440 present with Gtk+ 2.0.
442 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
444 * fileio.c (Finsert_file_contents): Undo previous change; see
445 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
447 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
449 Rename locals to avoid shadowing.
450 * fileio.c (Finsert_file_contents):
451 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
452 * process.c (wait_reading_process_output):
453 Rename inner 'proc' to 'p' to avoid shadowing.
454 Indent for consistency with usual Emacs style.
456 2011-11-25 Eli Zaretskii <eliz@gnu.org>
458 * xdisp.c (redisplay_window): If cursor row is not fully visible
459 after recentering, and scroll-conservatively is set to a large
460 number, scroll window by a few more lines to make the cursor fully
461 visible and out of scroll-margin. (Bug#10105)
462 (start_display): Don't move to the next line if the display should
463 start at a newline that is part of a display vector or an overlay
466 2011-11-24 Juri Linkov <juri@jurta.org>
468 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
469 after the `MagickPingImage' call. (Bug#10112)
471 2011-11-23 Chong Yidong <cyd@gnu.org>
473 * window.c (Fcoordinates_in_window_p): Accept only live windows.
475 2011-11-23 Martin Rudalics <rudalics@gmx.at>
477 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
478 making another buffer current. (Bug#10114)
480 2011-11-23 Glenn Morris <rgm@gnu.org>
482 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
484 2011-11-23 Chong Yidong <cyd@gnu.org>
486 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
489 2011-11-22 Eli Zaretskii <eliz@gnu.org>
491 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
492 and header-lines, as they don't have one computed for them.
495 * .gdbinit (prow): Make displayed values more self-explaining.
498 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
500 * process.c (wait_reading_process_output): Fix asynchrounous
501 GnuTLS socket handling on some versions of the GnuTLS library.
502 (wait_reading_process_output): Add comment and URL.
504 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
506 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
508 2011-11-21 Chong Yidong <cyd@gnu.org>
510 * window.c (Fnext_window, Fprevious_window): Doc fix.
512 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
514 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
516 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
518 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
520 2011-11-20 Martin Rudalics <rudalics@gmx.at>
522 * window.c (Fset_window_combination_limit): Rename argument
524 (Vwindow_combination_limit): Remove "status" from doc-string.
526 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
528 * m/ibms390.h: Remove.
529 * m/ibms390x.h: Don't include "ibms390.h".
531 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
533 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
534 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
536 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
538 * casetab.c (Fset_case_table):
539 * charset.c (Fcharset_after): Fix typos.
541 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
543 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
544 Otherwise, valgrind does not work on some platforms.
545 Problem reported by Andreas Schwab in
546 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
547 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
548 is set, removing the need for VIRT_ADDRESS_VARIES.
549 (PURE_P): Use a more-efficient implementation that needs just one
550 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
551 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
552 to 4 (xorl, subq, cmpq, setbe).
553 * alloc.c (pure): Always extern now, since that's the
554 VIRT_ADDR_VARIES behavior.
555 (PURE_POINTER_P): Use a single comparison, not two, for
556 consistency with the new puresize.h.
557 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
558 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
559 Remove VIRT_ADDR_VARIES no longer needed.
561 2011-11-19 Eli Zaretskii <eliz@gnu.org>
563 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
564 (erase_phys_cursor, update_window_cursor, show_mouse_face)
565 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
566 behave as if the cursor position were at the window margin.
568 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
569 and the cursor position is out of bounds, behave as if the cursor
570 position were at the window margin. (Bug#10075)
572 2011-11-18 Chong Yidong <cyd@gnu.org>
574 * window.c (Fwindow_combination_limit): Make first argument
575 non-optional, since it is meaningless for live windows like the
578 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
580 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
582 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
584 * intervals.c: Fix grafting over the whole buffer (bug#10071).
585 (graft_intervals_into_buffer): Simplify.
587 2011-11-18 Eli Zaretskii <eliz@gnu.org>
589 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
590 hash values of the two rows.
591 (copy_row_except_pointers): Preserve the used[] arrays and the
592 hash values of the two rows. (Bug#10035)
593 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
595 * xdisp.c (row_hash): New function, body extracted from
596 compute_line_metrics.
597 (compute_line_metrics): Call row_hash, instead of computing the
600 * dispnew.c (verify_row_hash): Call row_hash for computing the
601 hash code of a row, instead of duplicating code from xdisp.c.
603 * dispextern.h (row_hash): Add prototype.
605 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
607 * frame.c (delete_frame): Don't delete the terminal when the last
608 X frame is closed if emacs is built with GTK toolkit.
610 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
612 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
614 2011-11-17 Martin Rudalics <rudalics@gmx.at>
616 * window.c (Vwindow_splits): Rename to
617 Vwindow_combination_resize. Suggested by Juri Linkov.
618 (Fsplit_window_internal): Use Vwindow_combination_resize instead
621 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
623 * nsfns.m (Fns_font_name):
624 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
626 2011-11-16 Martin Rudalics <rudalics@gmx.at>
628 * window.h (window): Rename slot "nest" to "combination_limit".
629 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
630 (Fset_window_nest): Rename to Fset_window_combination_limit.
631 (Vwindow_nest): Rename to Vwindow_combination_limit.
632 (recombine_windows, make_parent_window, make_window)
633 (Fsplit_window_internal, saved_window)
634 (Fset_window_configuration, save_window_save): Rename all
635 occurrences of window_nest to window_combination_limit.
637 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
639 * image.c (imagemagick_load_image): Fix typo.
641 2011-11-14 Eli Zaretskii <eliz@gnu.org>
643 * xdisp.c (display_line): Move the call to
644 highlight_trailing_whitespace before the call to
645 compute_line_metrics, since the latter needs to see the final
646 faces of all the glyphs to compute ROW's hash value.
647 Fixes assertion violations in row_equal_p. (Bug#10035)
649 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
651 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
652 just return (bug#10044).
654 2011-11-12 Eli Zaretskii <eliz@gnu.org>
656 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
657 with user-defined heap size. Bump the default size of the temacs
658 heap to 27MB, to avoid memory warning when running temacs.
659 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
661 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
662 current_matrix and desired_matrix. (Bug#9990)
663 (verify_row_hash) [XASSERTS]: New function.
664 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
665 that the hash value of glyph rows is correct.
667 2011-11-12 Martin Rudalics <rudalics@gmx.at>
669 * window.h (window): Remove splits slot.
670 * window.c (Fwindow_splits, Fset_window_splits): Remove.
671 (Fdelete_other_windows_internal, make_parent_window)
672 (make_window, Fsplit_window_internal, Fdelete_window_internal)
673 (Fset_window_configuration, save_window_save): Don't deal with
674 split status of windows.
675 (saved_window): Remove splits slot.
676 (Vwindow_splits): Rewrite doc-string.
678 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
680 * xfns.c (unwind_create_frame):
681 * nsfns.m (unwind_create_frame):
682 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
683 Vframe_list (Bug#9999).
685 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
687 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
689 2011-11-11 Kenichi Handa <handa@m17n.org>
691 * callproc.c (Fcall_process): Set the member dst_multibyte of
694 2011-11-11 Johan Bockgård <bojohan@gnu.org>
696 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
697 avoid a crash (bug#9496).
699 2011-11-09 Chong Yidong <cyd@gnu.org>
701 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
702 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
704 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
706 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
708 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
710 Avoid some portability problems by eschewing 'extern inline' functions.
711 The trivial performance wins aren't worth the portability hassles; see
712 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
714 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
715 (window_box_width, window_box_left, window_box_left_offset)
716 (window_box_right, window_box_right_offset): Undo previous change,
717 by removing the "extern"s.
718 * intervals.c (adjust_intervals_for_insertion)
719 (adjust_intervals_for_deletion): Undo previous change,
720 making these static again.
721 (offset_intervals, temp_set_point_both, temp_set_point)
722 (copy_intervals_to_string): No longer inline.
723 * xdisp.c (window_text_bottom_y, window_box_width)
724 (window_box_height, window_box_left_offset)
725 (window_box_right_offset, window_box_left, window_box_right)
726 (window_box): No longer inline.
728 2011-11-08 Chong Yidong <cyd@gnu.org>
730 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
731 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
732 Signal an error if not a live window.
733 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
734 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
736 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
738 * lisp.h (syms_of_abbrev): Remove declaration.
739 Reported by CHENG Gao <chenggao@royau.me>.
741 2011-11-07 Eli Zaretskii <eliz@gnu.org>
743 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
744 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
745 of temacs in GUI mode.
747 2011-11-07 Martin Rudalics <rudalics@gmx.at>
749 * window.h: Declare delete_all_child_windows instead of
750 delete_all_subwindows.
751 * window.c (Fwindow_nest, Fset_window_nest)
752 (Fset_window_new_total, Fset_window_new_normal)
753 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
754 (delete_all_subwindows): Rename to delete_all_child_windows.
755 (Fdelete_other_windows_internal, Fset_window_configuration):
756 Call delete_all_child_windows instead of delete_all_subwindows.
757 * frame.c (delete_frame): Call delete_all_child_windows instead
758 of delete_all_subwindows.
760 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
762 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
763 This is also needed for porting to any host where GC_MARK_STACK is
764 not GC_MAKE_GCPROS_NOOPS.
765 (which_symbols): Use it.
767 2011-11-07 Kenichi Handa <handa@m17n.org>
769 * coding.c (coding_set_destination): Check coding->src_pos only
770 when coding->src_object is a buffer (bug#9910).
772 * process.c (send_process): Set the member src_multibyte of coding
773 to 0 (bug#9911) when sending a unibyte text.
775 * callproc.c (Fcall_process): Set the member src_multibyte of
776 process_coding to 0 (bug#9912).
778 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
780 * xmenu.c (cleanup_widget_value_tree): New function.
781 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
782 calling free_menubar_widget_value_tree directly (Bug#9830).
784 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
786 Fix some portability problems with 'inline'.
787 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
788 (window_box_width, window_box_left, window_box_left_offset)
789 (window_box_right, window_box_right_offset): Declare extern.
790 Otherwise, these inline functions do not conform to C99 and
791 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
792 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
793 * intervals.c (adjust_intervals_for_insertion)
794 (adjust_intervals_for_deletion): Now extern, because otherwise the
795 extern inline functions 'offset_intervals' couldn't refer to it.
796 (static_offset_intervals): Remove.
797 (offset_intervals): Rewrite using the old contents of
798 static_offset_intervals. The old version didn't conform to C99
799 because an extern inline function contained a reference to an
800 identifier with static linkage.
802 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
804 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
807 2011-11-06 Eli Zaretskii <eliz@gnu.org>
809 * xdisp.c (init_iterator, reseat_to_string): Don't set the
810 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
811 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
812 return Qleft_to_right.
814 2011-11-06 Chong Yidong <cyd@gnu.org>
816 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
817 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
818 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
819 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
820 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
821 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
822 (Fwindow_vscroll): Doc fix.
823 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
824 argument, since it makes no sense to pass a live window and for
825 consistency with window-child.
827 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
829 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
832 2011-11-05 Jason Rumney <jasonr@gnu.org>
834 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
835 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
837 (add_font_entity_to_list): Fix logic errors in mixed boolean and
838 bitwise arithmetic preventing use of unicode-sip and non-truetype
841 2011-11-05 Eli Zaretskii <eliz@gnu.org>
843 * s/ms-w32.h (fstat, stat, utime): Move redirections to
846 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
847 initialization code to keep similarity to xfns.c after changes
850 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
852 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
853 (unwind_create_frame): New function (Bug#9943).
854 (Fx_create_frame): Restructure code to be more similar to the one in
855 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
856 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
857 Move terminal->reference_count++ just before making the frame official
860 * nsterm.m (x_free_frame_resources): New function.
861 (x_destroy_window): Move code to x_free_frame_resources.
863 * xfns.c (unwind_create_frame): Fix comment.
864 (Fx_create_frame, x_create_tip_frame):
865 Move terminal->reference_count++ just before making the frame
866 official. Move initialization of image_cache_refcount and
867 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
869 2011-11-05 Eli Zaretskii <eliz@gnu.org>
871 Support MSVC build with newer versions of Visual Studio.
872 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
873 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
876 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
877 which are not supported by MSVC.
878 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
879 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
881 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
883 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
885 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
887 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
889 Support MSVC build with newer versions of Visual Studio.
890 * w32.c: Don't include w32api.h for MSVC.
891 (init_environment) [_MSC_VER]: Call sys_access, not _access.
893 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
894 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
895 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
896 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
898 (alloca) [_MSC_VER]: Define to _alloca.
900 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
902 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
904 2011-11-04 Eli Zaretskii <eliz@gnu.org>
906 * xdisp.c (note_mouse_highlight): If either of
907 previous/next-single-property-change returns nil, treat that as
908 the beginning or the end of the buffer. (Bug#9955)
910 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
912 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
913 label is not null (Bug#9951).
914 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
917 2011-11-04 Eli Zaretskii <eliz@gnu.org>
919 * window.c (Fwindow_body_size): Mention in the doc string that the
920 return value is in frame's canonical units. (Bug#9949)
922 2011-11-03 Eli Zaretskii <eliz@gnu.org>
924 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
926 * w32fns.c (unwind_create_frame): If needed, free the glyph
927 matrices of the partially constructed frame. (Bug#9943)
928 * xfns.c (unwind_create_frame): Likewise.
930 2011-11-01 Eli Zaretskii <eliz@gnu.org>
932 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
933 Don't stop backward scan on the continuation glyph, even though
934 its CHARPOS is positive.
935 (mouse_face_from_buffer_pos, note_mouse_highlight):
936 Rename cover_string to disp_string.
938 2011-11-01 Martin Rudalics <rudalics@gmx.at>
940 * window.c (temp_output_buffer_show): Don't use
941 Vtemp_buffer_show_specifiers.
942 (Vtemp_buffer_show_specifiers): Remove unused variable.
944 2011-10-30 Eli Zaretskii <eliz@gnu.org>
946 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
947 past the beginning of the current glyph matrix.
949 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
951 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
952 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
953 HAVE_GTK3 (Bug#9869).
955 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
956 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
958 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
960 * xterm.c: Declare x_handle_net_wm_state to return int.
961 (handle_one_xevent): Check if we are iconified but don't have
962 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
963 (get_current_wm_state): Return non-zero if not hidden,
964 check for _NET_WM_STATE_HIDDEN (Bug#9893).
965 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
966 (x_handle_net_wm_state): Return what get_current_wm_state returns.
967 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
969 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
971 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
972 so that this new function doesn't get optimized away by a
973 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
975 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
977 * frame.h (MOUSE_HL_INFO): Remove excess parens.
979 2011-10-29 Eli Zaretskii <eliz@gnu.org>
981 Fix the `xbytecode' command.
982 * .gdbinit (xprintbytestr): New command.
983 (xwhichsymbols): Rename from `which'; all callers changed.
984 (xbytecode): Print the byte-code string as well.
986 2011-10-29 Kim Storm <storm@cua.dk>
988 * alloc.c (which_symbols): New function.
990 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
992 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
995 2011-10-29 Glenn Morris <rgm@gnu.org>
997 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
998 Not clear what it was for, and it causes various bugs. (Bug#9839)
1000 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1002 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1003 possible random value that matches one of those tested as
1004 condition to clear the mouse face.
1006 2011-10-28 Chong Yidong <cyd@gnu.org>
1008 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1010 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1012 * window.c (make_window): Initialize phys_cursor_on_p.
1014 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1016 * lisp.h (struct Lisp_Symbol): Update comments.
1018 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1020 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1022 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1024 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1025 <oslsachem@gmail.com> for helping to debug this.
1027 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1028 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1029 (g_b_init_get_glyph_outline_w): New static variables.
1030 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1031 (GetGlyphOutlineW_Proc): New typedefs.
1032 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1033 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1035 (w32font_open_internal, compute_metrics):
1036 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1037 instead of calling the "wide" APIs directly.
1039 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1041 * w32.h (syms_of_w32font): Add prototype.
1043 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1045 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1046 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1047 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1048 (Fmove_to_window_line): Doc fix.
1050 2011-10-27 Chong Yidong <cyd@gnu.org>
1052 * process.c (make_process): Set gnutls_state to NULL.
1054 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1055 non-NULL, regardless of GNUTLS_INITSTAGE.
1056 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1057 an error. Set process slots as soon as we allocate them.
1059 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1061 2011-10-27 Chong Yidong <cyd@gnu.org>
1063 * gnutls.c (emacs_gnutls_deinit): New function.
1064 Deallocate credentials structures as well as calling gnutls_deinit.
1065 (Fgnutls_deinit, Fgnutls_boot): Use it.
1067 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1068 (deactivate_process): Call emacs_gnutls_deinit.
1070 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1072 * image.c (x_create_x_image_and_pixmap):
1073 * w32.c (sys_rename, w32_delayed_load):
1074 * w32font.c (fill_in_logfont):
1075 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1077 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1079 * w32fns.c (w32_default_color_map): New function,
1080 extracted from Fw32_default_color_map.
1081 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1083 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1085 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1087 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1089 * keyboard.c (test_undefined): New function (bug#9751).
1090 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1092 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1094 * sysdep.c (init_sys_modes): Fix the check for the controlling
1095 terminal (Bug#6649).
1097 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1099 * dispextern.h (struct bidi_it): New member next_en_type.
1101 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1102 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1103 current character, check also for next_en_type being WEAK_EN.
1104 (bidi_resolve_weak): Don't enter the expensive loop if the current
1105 position is before next_en_pos. Record the bidi type of the first
1106 non-ET, non-BN character we find, in addition to its position.
1107 (bidi_level_of_next_char): Invalidate next_en_type when
1108 next_en_pos is over-stepped.
1110 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1112 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1113 * editfns.c: Rewrite current-time-zone so that it invokes
1114 the equivalent of (format-time-string "%Z") to get the time zone name.
1115 This fixes a bug when the time zone name contains characters that
1116 need converting from the system time locale to Emacs internal format.
1117 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1118 that patch fixed format-time-string to do the conversion, but
1119 I forgot to fix current-time-zone.
1120 (format_time_string): New function, containing most of
1121 what Fformat_time_string used to contain.
1122 (Fformat_time_string): Rewrite in terms of format_time_string.
1123 This doesn't change this function's behavior.
1124 (current-time-zone): Rewrite to use format_time_string.
1125 This fixes the bug reported by Michael Schierl in
1126 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1127 Jason Rumney's 2007-06-07 change worked around this bug, but
1129 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1131 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1133 * xdisp.c (start_display): If the character at POS is displayed
1134 via a display vector, reset IT->current.dpvec_index to zero.
1135 (try_window_reusing_current_matrix): If a line ends in a display
1136 vector or the next line starts in a display vector, continue
1137 redrawing the window even though the character position of
1138 start_row was reached.
1141 2011-10-18 Chong Yidong <cyd@gnu.org>
1143 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1144 with nobreak-char-display too.
1146 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1148 Fix part 3 of bug#9771.
1149 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1150 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1151 non-neutral characters if the current character is a paragraph
1152 separator (a.k.a. Newline). This avoids running the same
1153 expensive loop twice, once when we consume the preceding newline
1154 and the other time when the line actually needs to be displayed.
1155 Avoid the loop when we see neutrals on the base embedding level
1156 following a character whose directionality is the same as the
1157 paragraph's. This avoids running the expensive loop when a line
1158 ends in a long sequence of neutrals, like control characters.
1159 Add assertion against STRONG_AL type. Slightly rearrange code
1160 that determines the type of a neutral given the first non-neutral
1162 (bidi_level_of_next_char): Set next_en_pos to zero when
1163 invalidating its info.
1165 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1167 * xdisp.c (push_display_prop): Determine whether to record string
1168 or buffer position by IT->string, not by IT->method. Allow
1169 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1170 (move_it_vertically_backward): Don't look for character position
1171 immediately after the newline when in a continuation line.
1174 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1176 * window.c (coordinates_in_window): Rewrite and delabelize
1177 vertical border check. (Bug#5357) (Bug#9618)
1179 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1181 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1182 errors in XSetWindowBorder (bug#9310).
1184 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1186 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1187 avoid crash when xmalloc overrun checking is enabled.
1189 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1191 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1192 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1193 cursor motion with <left> and <right> arrow keys.
1195 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1196 some callers set that themselves.
1198 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1200 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1201 display string and the previous row comes from the same string and
1202 is empty. (Bug#9739) (Bug#9738)
1204 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1206 * doc.c (get_doc_string): Encode file name (bug#9735).
1208 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1210 * bidi.c (bidi_level_of_next_char):
1211 * xdisp.c (get_visually_first_element): Remove old incorrect
1212 comments regarding the Unicode Line Separator character.
1214 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1216 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1218 * alloc.c (Fgc_status): Do not access beyond zombies array
1219 boundary if nzombies > MAX_ZOMBIES.
1220 * alloc.c (dump_zombies): Add missing format specifier.
1222 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1224 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1225 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1227 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1228 Some packages use them to denote characters with modifiers.
1230 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1232 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1233 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1234 matching a pp-number. Rename parameter var to var1.
1236 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1238 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1240 2011-10-08 Glenn Morris <rgm@gnu.org>
1242 * callint.c (Fcall_interactively): Give a more explicit error for the
1243 'c' case with a non-character input. (Bug#8479)
1245 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1247 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1249 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1250 lines that are hscrolled on the left.
1252 * dispnew.c (buffer_posn_from_coords): Account for a possible
1253 presence of header-line. (Bug#4426)
1255 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1257 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1258 Don't advertise functionality which we discourage or doesn't work.
1260 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1262 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1263 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1264 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1265 this makes Emacs dump core during garbage collection on rare
1266 occasions. sizeof is obviously inferior to offsetof here, so
1267 stick with offsetof.
1268 (GC_POINTER_ALIGNMENT): New macro.
1269 (mark_memory): Omit 3rd (offset) arg; caller changed.
1270 Don't assume EMACS_INT alignment is the same as pointer alignment.
1272 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1274 * keyboard.c (read_key_sequence_remapped): New var.
1275 (read_key_sequence): Compute remapping in the right buffer.
1276 (command_loop_1): Use read_key_sequence's remapping directly.
1278 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1280 * dired.c (file_name_completion): Don't expand file name.
1281 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1282 before checking file name handler.
1284 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1285 they've been requested explicitly (bug#9591).
1287 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1289 * keymap.c (Fsingle_key_description): Use make_specified_string
1290 instead of build_string to build string from push_key_description.
1293 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1295 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1296 This fixes a Y2038 bug on 64-bit hosts.
1297 * buffer.c (reset_buffer):
1298 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1299 (Fclear_buffer_auto_save_failure):
1300 Use 0, not -1, to represent an unset failure time, since time_t
1301 might not be signed.
1303 Remove dependency on glibc malloc internals.
1304 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1305 Move back here from lisp.h, but with their new implementations.
1306 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1307 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1308 * charset.c (charset_table_init): New static var.
1309 (syms_of_charset): Use it instead of xmalloc. This removes a
1310 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1311 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1312 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1313 Move back to alloc.c.
1314 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1315 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1317 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1319 * nsterm.m (windowDidResize): Call x_set_window_size only when
1320 ns_in_resize is true. Otherwise set pixelwidth/height and
1321 call change_frame_size (Bug#9628).
1323 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1325 Port --enable-checking=all to Fedora 14 x86-64.
1326 * charset.c (syms_of_charset): Also account for glibc malloc's
1327 internal overhead when calculating the initial malloc maximum.
1329 Port --enable-checking=all to Fedora 14 x86.
1330 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1332 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1333 (overrun_check_realloc, overrun_check_free):
1334 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1335 That way, xmalloc returns a properly-aligned pointer even if
1336 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1337 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1338 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1339 into account when calculating the initial malloc maximum.
1340 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1341 Move here from alloc.c, so that charset.c can use it too.
1342 Properly align; the old code wasn't right for common 32-bit hosts
1343 when configured with --enable-checking=all.
1344 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1345 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1347 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1349 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1352 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1354 * xdisp.c (compute_display_string_end): If there's no display
1355 string at CHARPOS, return -1.
1357 * bidi.c (bidi_fetch_char): When compute_display_string_end
1358 returns a negative value, treat the character as a normal
1359 character not covered by a display string. (Bug#9624)
1361 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1363 * lread.c (Fread_from_string): Fix typo in docstring.
1365 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1367 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1368 newline, reseat the iterator instead of bidi-iterating there one
1369 character at a time. (Bug#9610)
1370 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1371 TO_CHARPOS if the bidi iterator is at base embedding level.
1373 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1375 * lread.c (readevalloop): Use correct code for NBSP.
1376 (read1): Likewise. (Bug#9608)
1378 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1380 * dbusbind.c (Fdbus_register_signal): When service is not
1381 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1383 2011-09-25 Glenn Morris <rgm@gnu.org>
1385 * buffer.c (truncate-lines): Doc fix.
1387 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1389 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1390 (Fset_window_next_buffers): Doc fix.
1392 2011-09-24 Glenn Morris <rgm@gnu.org>
1394 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1396 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1398 Fix minor problems found by static checking.
1399 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1400 * indent.c (Fvertical_motion): Fix == vs = typo.
1402 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1404 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1405 Default value is now t. Doc fix.
1407 * indent.c (Fvertical_motion): Compute and apply the overshoot
1408 logic when moving up, not only when moving down. Fix the
1409 confusing name and values of the it_overshoot_expected variable;
1410 logic changes accordingly. (Bug#9254) (Bug#9549)
1412 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1413 CHARPOS is covered by a display string which includes newlines.
1414 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1415 is covered by a display string with embedded newlines.
1417 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1419 * dbusbind.c (Fdbus_register_signal): Add match rule to
1420 Vdbus_registered_objects_table. (Bug#9581)
1421 (Fdbus_register_method, Vdbus_registered_objects_table):
1424 2011-09-24 Jim Meyering <meyering@redhat.com>
1426 do not ignore write error for any output size
1427 The previous change was incomplete.
1428 While it makes emacs --batch detect the vast majority of stdout
1429 write failures, errors were still ignored whenever the output size is
1430 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1431 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1432 && echo FAIL: ignored write error
1433 FAIL: ignored write error
1434 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1435 && echo FAIL: ignored write error
1436 FAIL: ignored write error
1437 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1439 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1441 * emacs.c (Fkill_emacs): In noninteractive mode exit
1442 non-successfully if a write error occurred on stdout. (Bug#9574)
1444 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1446 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1449 * dispextern.h (struct it): Update the comment documenting what
1452 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1454 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1455 a display string, extend search for cursor position to end of row.
1456 (find_row_edges): If the row ends in a newline from a display
1457 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1458 Handle the case of a display string with multiple newlines.
1459 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1460 non-empty line. Fixes confusing cursor motion with arrow keys at
1461 the beginning of a line that starts with whitespace.
1463 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1465 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1468 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1470 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1473 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1475 * xdisp.c (display_line): Record maximum and minimum buffer
1476 positions even if no glyphs were produced (e.g., by a zero-width
1477 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1478 buffer positions that will be removed from the glyph row because
1480 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1481 column is beyond frame width: don't subtract 1 "pixel" when
1482 computing width of the stretch.
1483 (reseat_at_next_visible_line_start): Undo the change made on
1484 2011-09-17 that saved paragraph information and restored it after
1485 the call to `reseat'. (Bug#9545)
1487 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1489 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1490 and turn window cursor on if cleared (Bug#9415).
1492 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1494 * search.c (boyer_moore): Take unibyte characters from pattern
1495 literally. (Bug#9458)
1497 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1499 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1501 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1503 Fix minor problem found by static checking.
1504 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1505 initialized, to pacify gcc -Wuninitialized.
1507 * fileio.c: Report proper errno when syscall falls.
1508 (Finsert_file_contents): Save and restore errno,
1509 so that report_file_error outputs the correct diagnostic.
1510 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1512 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1514 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1516 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1518 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1519 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1521 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1523 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1524 about the current paragraph and restore it after the call to reseat.
1526 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1527 (bidi_find_paragraph_start): Search back for paragraph beginning
1528 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1529 (bidi_move_to_visually_next): Only trigger paragraph-related
1530 computations when the last character is a newline or at EOB, not
1531 just any NEUTRAL_B. (Bug#9470)
1533 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1534 truncated lines if point is covered by a display string. (Bug#9524)
1536 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1538 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1539 (cons_to_x_long): New function.
1540 (lisp_data_to_selection_data): Use it. Correct the test for
1541 short-versus-long data; it was negated. Break out of vector
1542 loop, for efficiency, when a long datum is discovered.
1544 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1546 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1548 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1550 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1551 GCC PR/17406) by declaring this function with external scope.
1553 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1555 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1556 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1558 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1560 * editfns.c (Fformat): Correctly handle text properties on "%%".
1562 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1564 * xterm.c (x_draw_composite_glyph_string_foreground):
1565 * w32term.c (x_draw_composite_glyph_string_foreground):
1566 * term.c (encode_terminal_code):
1567 * composite.c (composition_update_it, get_composition_id):
1568 * xdisp.c (get_next_display_element)
1569 (fill_composite_glyph_string): Add comments about special meaning
1570 of TAB characters in a composition.
1572 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1574 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1575 This occurs when processing a multibyte format.
1576 Problem reported by Wolfgang Jenker.
1578 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1580 * xdisp.c (try_cursor_movement): Only check for exact match if
1581 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1583 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1585 Remove unused external symbols.
1586 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1587 * xdisp.c (calc_pixel_width_or_height): Now static.
1588 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1589 * indent.c (check_display_width):
1590 * w32term.c: Fix comment to match code.
1591 * xterm.c, xterm.h (x_catching_errors): Remove.
1593 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1595 * xselect.c: Use signed conversions more consistently (Bug#9498).
1596 (selection_data_to_lisp_data): Assume incoming selection data are
1597 signed integers, not unsigned. This is to be consistent with
1598 outgoing selection data, which was modified to use signed integers
1599 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1600 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1601 expects long, not unsigned long.
1603 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1605 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1606 computation of loop end. Reported by Johan Bockgård
1609 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1611 * frame.c (Fother_visible_frames_p): Function deleted.
1613 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1615 * indent.c (compute_motion): Process display vector front to back
1616 rather than the other way around. (Bug#2496)
1618 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1620 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1622 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1624 * minibuf.c (Fread_from_minibuffer): Doc fix.
1626 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1628 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1629 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1631 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1633 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1634 value for non-existent files.
1636 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1638 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1639 set its "size" to -1. This will set the modtime_size field of
1640 the corresponding buffer to -1, which is what
1641 verify-visited-file-modtime expects for files that do not exist.
1644 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1646 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1648 * lisp.h: ... from here. push_key_description is no longer
1649 defined in keyboard.c, so its declaration should not be in
1650 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1651 logically belongs with push_key_description.
1653 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1655 * buffer.h: Include <sys/types.h> instead of <time.h>.
1656 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1657 Problem reported by Herbert J. Skuhra.
1659 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1661 * xml.c (parse_region): Make the parsing work for
1662 non-comment-starting XML files again (bug#9144).
1664 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1666 * image.c (gif_load): Fix calculation of bottom and right corner.
1669 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1671 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1672 redisplay in small windows.
1674 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1676 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1678 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1680 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1681 Operate on live windows only.
1683 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1685 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1687 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1689 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1690 only under bidi iteration.
1692 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1694 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1696 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1698 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1699 Without this fix, the command to link temacs failed due to an
1700 undefined symbol __builtin_isnan. This is because
1701 /usr/include/iso/math_c99.h #defines isnan(x) to
1702 __builtin_isnan(x), but the bundled gcc, which identifies itself
1703 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1705 * floatfns.c (isnan): #undef, and then #define to a clone of
1707 (Fisnan): Always define, since it's always available now.
1708 (syms_of_floatfns): Always define isnan at the Lisp level.
1710 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1712 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1714 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1716 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1717 The previous code assumed that file offsets (off_t values) fit in
1718 EMACS_INT variables, which is not true on typical 32-bit hosts.
1719 The code messed up by falsely reporting buffer overflow in cases
1720 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1721 when "big" contains more than 2**29 bytes, even though this
1722 inserts just one byte and does not overflow the buffer.
1723 (Finsert_file_contents): Store file offsets as off_t
1724 values, not as EMACS_INT values. Check for overflow when
1725 converting between EMACS_INT and off_t. When checking for
1726 buffer overflow or for overlap, take the offsets into account.
1727 Don't use EMACS_INT for small values where int suffices.
1728 When checking for overlap, fix a typo: ZV was used where
1729 ZV_BYTE was intended.
1730 (Fwrite_region): Don't assume off_t fits into 'long'.
1731 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1733 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1735 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1737 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1739 sprintf-related integer and memory overflow issues (Bug#9412).
1741 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1742 (esprintf, exprintf, evxprintf): New functions.
1743 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1744 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1745 (modify_event_symbol): Do not assume that the length of
1746 name_alist_or_stem is safe to alloca and fits in int.
1747 (Fexecute_extended_command): Likewise for function name and binding.
1748 (Frecursion_depth): Wrap around reliably on integer overflow.
1749 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1750 since some callers pass EMACS_INT values.
1751 (Fsingle_key_description): Don't crash if symbol name contains more
1752 than MAX_ALLOCA bytes.
1753 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1754 (get_minibuffer): Arg is now EMACS_INT, not int.
1755 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1756 (esprintf, exprintf, evxprintf): New decls.
1757 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1759 * dbusbind.c (signature_cat): New function.
1760 (xd_signature, Fdbus_register_signal):
1761 Do not overrun buffer; instead, report string overflow.
1763 * dispnew.c (add_window_display_history): Don't overrun buffer.
1764 Truncate instead; this is OK since it's just a log.
1766 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1767 even if the time zone offset is outlandishly large.
1768 Don't mishandle offset == INT_MIN.
1770 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1771 when creating daemon; the previous buffer-overflow check was incorrect.
1773 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1774 which has the guts of the old verror function.
1776 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1777 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1779 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1780 (font_unparse_xlfd): Don't blindly alloca long strings.
1781 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1782 fits in int, when using sprintf. Use single snprintf to count
1783 length of string rather than counting it via multiple sprintfs;
1784 that's simpler and more reliable.
1785 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1786 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1787 sprintf, in case result does not fit in int.
1789 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1790 (fontset_from_font): Print it.
1792 * frame.c (tty_frame_count): Now printmax_t, not int.
1793 (make_terminal_frame, set_term_frame_name): Print it.
1794 (x_report_frame_params): In X, window IDs are unsigned long,
1795 not signed long, so print them as unsigned.
1796 (validate_x_resource_name): Check for implausibly long names,
1797 and don't assume name length fits in 'int'.
1798 (x_get_resource_string): Don't blindly alloca invocation name;
1799 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1802 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1803 (xg_check_special_colors, xg_set_geometry):
1804 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1806 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1807 Use esprintf, not sprintf, in case result does not fit in int.
1809 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1810 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1811 it as a large positive number.
1812 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1813 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1815 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1816 in case result does not fit in int.
1818 * print.c (float_to_string): Detect width overflow more reliably.
1819 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1820 buffer overrun. Don't assume list length fits in 'int'. Treat
1821 print length of 0 as 0, not as infinity; to be consistent with other
1822 uses of print length in this function. Don't overflow print length
1823 index. Don't assume hash table size fits in 'long', or that
1824 vectorlike size fits in 'unsigned long'.
1826 * process.c (make_process): Use printmax_t, not int, to format
1827 process-name gensyms.
1829 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1831 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1832 to avoid potential buffer overrun.
1834 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1835 if X resource line is longer than 512 bytes.
1837 * xfns.c (x_window): Make sprintf buffer a bit bigger
1838 to avoid potential buffer overrun.
1840 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1842 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1844 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1846 Integer overflow fixes for scrolling, etc.
1847 Without these, Emacs silently mishandles large integers sometimes.
1848 For example, "C-u 4294967297 M-x recenter" was treated as if
1849 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1851 * xdisp.c (try_window_id): Check Emacs fixnum range before
1852 converting to 'int'.
1854 * window.c (window_scroll_line_based, Frecenter):
1855 Check that an Emacs fixnum is in range before assigning it to 'int'.
1856 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1857 values converted from Emacs fixnums.
1858 (Frecenter): Don't wrap around a line count if it is out of 'int'
1859 range; instead, treat it as an extreme value.
1860 (Fset_window_configuration, compare_window_configurations):
1861 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1863 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1864 that can exceed INT_MAX. Check that EMACS_INT value is in range
1865 before assigning it to the (possibly-narrower) index.
1866 (match_limit): Don't assume that a fixnum can fit in 'int'.
1868 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1871 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1872 (Fvertical_motion): Don't wrap around LINES values that don't fit
1873 in 'int'. Instead, treat them as extreme values. This is good
1874 enough for windows, which can't have more than INT_MAX lines anyway.
1876 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1878 * Require libxml/parser.h to avoid compilation warning.
1880 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1882 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1883 since this reportedly can destroy thread storage.
1885 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1887 * syntax.c (find_defun_start): Update all cache variables if
1888 exiting early (Bug#9401).
1890 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1892 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1894 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1895 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1896 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1898 * term.c (tty_append_glyph): New function.
1899 (produce_stretch_glyph): Static function and its prototype deleted.
1901 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1904 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1906 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1907 when checking :margin (Bug#9390).
1908 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1909 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1910 so that the name doesn't mislead. All uses changed.
1912 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1914 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1917 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1919 * xdisp.c (move_it_to): Don't bail out early when reaching
1920 position beyond to_charpos, if we are scanning backwards.
1921 (move_it_vertically_backward): When DY == 0, make sure we get to
1922 the first character in the line after the newline.
1924 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1926 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1927 (ccl_driver): Do not generate an out-of-range pointer.
1928 (Fccl_execute_on_string): Remove unnecessary check for
1929 integer overflow, noted by Stefan Monnier in
1930 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1931 Remove a FIXME that didn't need fixing.
1932 Simplify the newly-introduced buffer reallocation code.
1934 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1936 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1938 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1940 Integer and memory overflow issues (Bug#9196).
1942 * doc.c (get_doc_string): Rework so that
1943 get_doc_string_buffer_size is the actual buffer size, rather than
1944 being 1 less than the actual buffer size; this makes xpalloc more
1947 * image.c (x_allocate_bitmap_record, cache_image):
1948 * xselect.c (Fx_register_dnd_atom):
1949 Simplify previous changes by using xpalloc.
1951 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1952 since either will do and ptrdiff_t is convenient with xpalloc.
1954 * charset.c (charset_table_size)
1955 (struct charset_sort_data.priority): Now ptrdiff_t.
1956 (charset_compare): Don't overflow if priorities differ greatly.
1957 (Fsort_charsets): Don't assume list length fits in int.
1958 Check for size-calculation overflow when allocating sort data.
1959 (syms_of_charset): Allocate an initial charset table that is
1960 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1962 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1964 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1965 The actual value is always <= INT_MAX, and leaving it unsigned made
1966 overflow checking harder.
1968 * dispextern.h (struct glyph_matrix.rows_allocated)
1969 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1970 with xpalloc. The values are still always <= INT_MAX.
1972 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1974 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1975 (SAFE_NALLOCA): New macro.
1977 * region-cache.c (struct boundary.pos, find_cache_boundary)
1978 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1979 (set_cache_region, invalidate_region_cache)
1980 (revalidate_region_cache, know_region_cache, region_cache_forward)
1981 (region_cache_backward, pp_cache):
1982 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1983 so that ptrdiff_t * can be passed to xpalloc.
1984 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1985 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1986 (pp_cache): Don't assume cache_len fits in int.
1987 * region-cache.h: Adjust extern decls to match.
1989 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1990 EMACS_INT, since either will do, for xpalloc.
1992 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1993 (xnmalloc, xnrealloc, xpalloc): New functions.
1995 * bidi.c (bidi_shelve_header_size): New constant.
1996 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1997 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1999 * bidi.c (bidi_cache_shrink):
2000 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2002 Don't update size of array until after memory allocation succeeds,
2003 because xmalloc/xrealloc may not return.
2004 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2005 now that we have proper integer overflow checking.
2006 (record_overlay_string, overlay_strings): Catch overflows when
2007 calculating size of overlay_str_buf.
2009 * callproc.c (Fcall_process): Check for size overflow when
2010 calculating size of args2.
2011 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2012 Normally we prefer signed values, but sticking with ptrdiff_t would
2013 require adding more-complicated checks.
2015 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2016 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2017 Redo buffer-overflow calculations to avoid integer overflow.
2018 Add a FIXME comment where memory seems to be over-allocated.
2020 * character.c (Fstring): Check for size-calculation overflow.
2022 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2023 unnecessary integer overflow. Check for size overflow.
2024 (encode_coding_object): Don't update size until xmalloc succeeds.
2026 * composite.c (get_composition_id): Check for overflow in glyph
2027 length calculations.
2029 Integer and memory overflow fixes for display code.
2030 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2031 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2032 (scrolling_window): Check for overflow in size calculations.
2033 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2034 Don't assume glyph table len fits in int.
2035 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2036 (row_table_size): Now ptrdiff_t, not int.
2037 (scrolling_window): Avoid overflow in size calculations.
2038 Don't update size until allocation succeeds.
2039 * fns.c (concat): Check for overflow in size calculations.
2040 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2041 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2042 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2044 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2045 (get_doc_string): Check for size calculation overflow.
2046 Don't update size until allocation succeeds.
2047 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2048 EMACS_INT, where ptrdiff_t will do.
2049 (Fsubstitute_command_keys): Check for string overflow.
2051 * editfns.c (set_time_zone_rule): Don't assume environment length
2053 (message_length): Now ptrdiff_t, not int.
2054 (Fmessage_box): Don't update size until allocation succeeds.
2055 Don't assume message length fits in int.
2056 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2058 * emacs.c (main): Do not reallocate argv, since there is a null at
2059 the end that can be overwritten, and this way there's no need to
2060 worry about size-calculation overflow.
2061 (sort_args): Check for size-calculation overflow.
2063 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2065 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2067 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2068 (x_set_scroll_bar_width, x_figure_window_size):
2069 Check for integer overflow.
2070 (x_set_alpha): Do not assume XINT fits in int.
2072 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2073 This is for the members text_lines, text_cols, total_lines, total_cols,
2074 where the system imposes an 'int' limit.
2076 * fringe.c (Fdefine_fringe_bitmap):
2077 Don't update size until alloc works.
2079 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2080 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2082 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2083 Check for size-calculation overflow.
2084 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2085 do, as we prefer signed integers.
2086 (id_to_widget.max_size, id_to_widget.used)
2087 (xg_store_widget_in_map, xg_remove_widget_from_map)
2088 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2089 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2090 Use and return ptrdiff_t, not int.
2091 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2092 * gtkutil.h: Change prototypes to match the above.
2094 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2095 are duplicate now that they've been promoted to lisp.h.
2096 (x_allocate_bitmap_record, x_alloc_image_color)
2097 (make_image_cache, cache_image, xpm_load):
2098 Don't update size until alloc is done.
2099 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2101 Check for size calculation overflow.
2102 (ct_colors_allocated_max): New constant.
2103 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2106 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2107 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2108 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2109 Use ptrdiff_t, not int, to count maps.
2110 (read_char_minibuf_menu_prompt): Check for overflow in size
2111 calculations. Don't update size until allocation succeeds.
2112 Redo calculations to avoid overflow.
2113 * keyboard.h: Change prototypes to match the above.
2115 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2117 (current_minor_maps): Check for size calculation overflow.
2118 * keymap.h: Change prototypes to match the above.
2120 * lread.c (read1, init_obarray): Don't update size until alloc done.
2122 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2123 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2125 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2126 Now ptrdiff_t, not int.
2127 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2128 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2130 * process.c (Fnetwork_interface_list): Check for overflow
2131 in size calculation.
2133 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2135 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2136 overflow. Don't bother calling xmalloc when xrealloc will do.
2138 * search.c (Freplace_match): Check for size calculation overflow.
2139 (Fset_match_data): Don't assume list lengths fit in 'int'.
2141 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2142 for command line length. Do not attempt to address one before the
2143 beginning of an array, as that's not portable.
2145 * term.c (max_frame_lines): Remove; unused.
2146 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2148 (encode_terminal_code, calculate_costs): Check for size
2149 calculation overflow.
2150 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2151 table lengths and related sizes. Don't update size until alloc
2152 done. Redo calculations to avoid overflow.
2153 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2155 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2156 subtracting pointers.
2157 (gobble_line): Check for overflow more carefully. Don't update size
2160 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2161 Don't update size until alloc done.
2162 Redo size calculations to avoid overflow.
2163 Check for size calculation overflow.
2164 (main) [DEBUG]: Fix typo in invoking tparam1.
2166 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2167 Use ptrdiff_t, not int, for sizes.
2168 (store_mode_line_noprop_char): Don't update size until alloc done.
2170 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2171 Use ptrdiff_t, not int, for sizes.
2172 (Finternal_make_lisp_face, cache_face):
2173 Check for size calculation overflow.
2174 (cache_face): Treat size calculation overflows as if they were
2175 memory exhaustion (the usual treatment), rather than aborting.
2177 * xfns.c (x_encode_text, x_set_name_internal)
2178 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2179 sizes, since they can exceed INT_MAX in size. Check for size
2180 calculation overflow.
2182 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2183 (xg_select): Check for size calculation overflow.
2184 Don't update size until alloc done.
2186 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2187 as sprintf is limited to int lengths.
2189 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2190 (X_LONG_MIN): New macros.
2191 Use them to make the following changes clearer.
2192 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2193 This change doesn't affect the value now, but it may help remind
2194 future maintainers not to raise the value too much later.
2195 (SELECTION_QUANTUM): Remove, replacing with ...
2196 (selection_quantum): ... new function, which avoids overflow.
2198 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2199 assumption that selection length fits in 'int'.
2200 (x_reply_selection_request, x_handle_selection_request)
2201 (x_get_window_property, receive_incremental_selection)
2202 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2203 (lisp_data_to_selection_data, clean_local_selection_data):
2204 Use ptrdiff_t, not int, to record length of selection.
2205 (x_reply_selection_request, x_get_window_property)
2206 (receive_incremental_selection, x_property_data_to_lisp):
2207 Redo calculations to avoid overflow.
2208 (x_reply_selection_request): When sending hint, ceiling it at
2209 X_LONG_MAX rather than relying on wraparound overflow to send
2211 (x_get_window_property, receive_incremental_selection)
2212 (lisp_data_to_selection_data, x_property_data_to_lisp):
2213 Check for size-calculation overflow.
2214 (x_get_window_property, receive_incremental_selection)
2215 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2216 Don't store size until memory allocation succeeds.
2217 (x_get_window_property): Plug memory leak on memory exhaustion.
2218 Don't double-block input; malloc is safe here. Don't assume 2**34
2219 - 4 fits in unsigned long. Add an xassert to check
2220 XGetWindowProperty overflow. Be more careful about overflow
2221 calculations, and distinguish size from memory overflow better.
2222 (receive_incremental_selection): When tracing, don't assume
2223 unsigned int is less than INT_MAX.
2224 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2225 harmful) conversions of unsigned short to int.
2226 (lisp_data_to_selection_data): Don't assume that integers
2227 in the range -65535 through -1 fit in an X unsigned short.
2228 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2229 result parameters unless successful. Rely on cons_to_unsigned
2230 to report problems with elements; the old code wasn't right anyway.
2231 (x_check_property_data): Check for int overflow; we cannot use
2232 a wider type due to X limits.
2233 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2235 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2237 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2238 (x_term_init): Check for size calculation overflow.
2239 (x_color_cells): Don't store size until memory allocation succeeds.
2240 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2241 Don't assume alloca size is less than MAX_ALLOCA.
2242 (x_term_init): Don't assume length fits in int (sprintf is limited
2245 Use ptrdiff_t for composition IDs.
2246 * character.c (lisp_string_width):
2247 * composite.c (composition_table_size, n_compositions)
2248 (get_composition_id, composition_gstring_from_id):
2249 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2250 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2251 * window.c (Frecenter):
2252 Use ptrdiff_t, not int, for composition IDs.
2253 * composite.c (get_composition_id): Check for integer overflow.
2254 * composite.h: Adjust prototypes to match the above changes.
2256 Use ptrdiff_t for hash table indexes.
2257 * category.c (hash_get_category_set):
2258 * ccl.c (ccl_driver):
2259 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2260 * coding.c (coding_system_charset_list, detect_coding_system):
2261 * coding.h (struct coding_system.id):
2262 * composite.c (get_composition_id, gstring_lookup_cache):
2263 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2264 * image.c (xpm_get_color_table_h):
2265 * lisp.h (hash_lookup, hash_put):
2266 * minibuf.c (Ftest_completion):
2267 Use ptrdiff_t for hash table indexes, not int (which is too
2268 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2269 32-bit --with-wide-int hosts).
2271 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2272 Add a FIXME comment about memory leaks.
2273 (syms_of_charset): Don't assume xmalloc returns.
2275 Don't assume that stated character widths fit in int.
2276 * character.c (Fchar_width, c_string_width, lisp_string_width):
2277 * character.h (CHAR_WIDTH):
2278 * indent.c (MULTIBYTE_BYTES_WIDTH):
2279 Use sanitize_char_width to avoid undefined and/or bad behavior
2280 with outlandish widths.
2281 * character.h (sanitize_tab_width): Rename from sanitize_width,
2282 now that we have two such functions. All uses changed.
2283 (sanitize_char_width): New inline function.
2285 Don't assume that tab-width fits in int.
2286 * character.h (sanitize_width): New inline function.
2287 (SANE_TAB_WIDTH): New macro.
2288 (ASCII_CHAR_WIDTH): Use it.
2289 * indent.c (sane_tab_width): Remove. All uses replaced by
2290 SANE_TAB_WIDTH (current_buffer).
2291 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2293 * fileio.c: Integer overflow issues with file modes.
2294 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2296 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2297 Remove unreachable code.
2298 (read_hex, load_charset_map_from_file): Check for integer overflow.
2300 * xterm.c: don't go over XClientMessageEvent limit
2301 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2302 (x_send_scroll_bar_event): Likewise. Check that the size does not
2303 exceed limits imposed by XClientMessageEvent, as well as the usual
2304 ptrdiff_t and size_t limits.
2306 * keyboard.c: Overflow, signedness and related fixes.
2307 (make_lispy_movement): Use same integer type in forward decl
2308 that is used in the definition.
2309 (read_key_sequence, keyremap_step):
2310 Change bufsize argument back to int, undoing my 2011-03-30 change.
2311 We prefer signed types, and int is wide enough here.
2312 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2313 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2314 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2315 length, not size_t. Use ptrdiff_t for index, not int.
2316 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2317 possibility of integer overflow.
2319 Overflow, signedness and related fixes for images.
2321 * dispextern.h (struct it.stack[0].u.image.image_id)
2322 (struct_it.image_id, struct image.id, struct image_cache.size)
2323 (struct image_cache.used, struct image_cache.ref_count):
2324 * gtkutil.c (update_frame_tool_bar):
2325 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2326 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2327 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2328 * nsmenu.m (update_frame_tool_bar):
2329 * xdisp.c (calc_pixel_width_or_height):
2330 * xfns.c (image_cache_refcount):
2331 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2332 on typical 64-bit hosts.
2334 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2335 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2336 Omit unnecessary casts to int.
2337 (parse_image_spec): Check that integers fall into 'int' range
2338 when the callers expect that.
2339 (image_ascent): Redo ascent calculation to avoid int overflow.
2340 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2341 (lookup_image): Remove unnecessary tests.
2342 (xbm_image_p): Locals are now of int, not EMACS_INT,
2343 since parse_image_check makes sure they fit into int.
2344 (png_load, gif_load, svg_load_image):
2345 Prefer int to unsigned where either will do.
2346 (tiff_handler): New function, combining the cores of the
2347 old tiff_error_handler and tiff_warning_handler.
2348 This function is rewritten to use vsnprintf and thereby avoid
2349 stack buffer overflows. It uses only the features of vsnprintf
2350 that are common to both POSIX and native Microsoft.
2351 (tiff_error_handler, tiff_warning_handler): Use it.
2352 (tiff_load, gif_load, imagemagick_load_image):
2353 Don't assume :index value fits in 'int'.
2354 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2355 (imagemagick_load_image): Check that crop parameters fit into
2356 the integer types that MagickCropImage accepts. Don't assume
2357 Vimagemagick_render_type has a nonnegative value. Don't assume
2358 size_t fits in 'long'.
2359 (gs_load): Use printmax_t to print the widest integers possible.
2360 Check for integer overflow when computing image height and width.
2362 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2364 * xdisp.c (redisplay_window): Don't force window start if point
2365 will be invisible in the resulting window. (Bug#9324)
2367 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2369 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2370 the display spec is of the form `(space ...)'.
2371 (handle_display_spec): Return the value returned by
2372 handle_single_display_spec, not just 1 or zero.
2373 (handle_single_display_spec): If the display spec is of the form
2374 `(space ...)', and specifies display in the text area, return 2
2376 (try_cursor_movement): Check for the need to scroll more
2377 accurately, and prefer exact match for point under bidi.
2378 Don't advance `row' beyond the last row of the window.
2380 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2381 into disp_prop; all users changed.
2383 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2384 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2385 for the text covered by the display property.
2387 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2389 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2390 Change return value to nil.
2391 (Frecord_buffer): Delete unused function.
2393 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2395 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2396 buffers, return left-to-right.
2397 (set_cursor_from_row): Consider candidate row a win if its glyph
2398 represents a newline and point is on that newline. Fixes cursor
2399 positioning on the newline at EOL of R2L text within L2R
2400 paragraph, and vice versa.
2401 (try_cursor_movement): Check continued rows, in addition to
2402 continuation rows. Fixes unwarranted scroll when point enters a
2403 continued line of R2L text within an L2R paragraph, or vice versa.
2404 (cursor_row_p): Consider the case of point being equal to
2405 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2406 from the end of a short line to the beginning of a continued line
2407 of R2L text within L2R paragraph.
2408 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2409 composed characters.
2411 * bidi.c (bidi_check_type): Use xassert.
2412 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2415 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2417 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2420 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2422 * nsfont.m (ns_otf_to_script): Fix typo.
2424 2011-08-22 Kenichi Handa <handa@m17n.org>
2426 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2427 extra slot even if the purpose is char-code-property-table.
2429 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2431 * xdisp.c (redisplay_window): When computing centering_position,
2432 account for the height of the header line. (Bug#8874)
2434 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2435 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2436 candidate is selected by the mouse, and that candidate has a
2437 composed character under the mouse.
2439 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2440 coordinates reported by pos-visible-in-window-p for a composed
2441 character in column zero.
2443 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2445 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2447 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2449 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2450 consider it a hit if to_charpos is anywhere in the range of the
2451 composed buffer positions.
2453 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2455 * image.c (gif_load): Don't assume that each subimage has the same
2456 dimensions as the base image. Handle disposal method that is
2457 "undefined" by the gif spec (Bug#9335).
2459 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2461 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2462 (Fcondition_case): Document `debug' symbol in error handler.
2464 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2466 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2467 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2468 from an Org mode buffer to a Speedbar frame.
2470 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2471 a composition, take its buffer position from IT->cmp_it.charpos.
2472 Fixes cursor positioning at the beginning of a line that begins
2473 with a composed character.
2475 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2477 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2478 character bidirectional type, use STRONG_L instead. Fixes crashes
2479 in a buffer produced by `describe-categories'.
2481 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2482 members before the level stack, so they would be saved and
2483 restored when copying iterator state. Fixes incorrect reordering
2484 around TABs covered by display properties.
2486 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2488 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2490 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2492 * eval.c (internal_condition_case, internal_condition_case_1)
2493 (internal_condition_case_2, internal_condition_case_n):
2494 Remove unnecessary aborts (Bug#9081).
2496 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2498 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2499 has no `load' handler, try opening the file locally. (Bug#9311)
2501 2011-08-16 Ken Brown <kbrown@cornell.edu>
2503 * gmalloc.c: Expand comment.
2505 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2507 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2508 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2510 2011-08-16 Ken Brown <kbrown@cornell.edu>
2512 Fix memory allocation problems in Cygwin build (Bug#9273).
2514 * unexcw.c ( __malloc_initialized): Declare external variable.
2515 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2517 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2519 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2521 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2523 [CYGWIN] (special_realloc): New function.
2524 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2525 requests to realloc storage in the static heap.
2527 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2529 * bidi.c (bidi_initialize): Remove unused local.
2531 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2534 * biditype.h: Remove file.
2535 * makefile.w32-in ($(BLD)/bidi.$(O)):
2536 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2538 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2540 * chartab.c: Improve commentary for the uniprop_table API.
2542 * bidi.c (bidi_paragraph_init): Support zero value of
2543 bidi_ignore_explicit_marks_for_paragraph_level.
2544 (bidi_initialize): Use uniprop_table instead of including
2545 biditype.h and bidimirror.h.
2547 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2548 coordinates of the iterator when restoring from ppos_it.
2551 2011-08-14 Kenichi Handa <handa@m17n.org>
2553 * process.c (create_process): Call setup_process_coding_systems
2554 after the pid of the process is set to -1 (Bug#8162).
2556 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2558 * xdisp.c (move_it_in_display_line_to): Don't invoke
2559 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2560 ppos_it. Fixes vertical cursor motion when line beginning is
2561 covered by an image. (Bug#9296)
2563 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2565 * nsterm.h (ns_run_ascript): Declare.
2566 (NSAPP_DATA2_RUNASSCRIPT): Define.
2568 * nsfns.m (as_script, as_result, as_status): New static variables.
2569 (ns_run_ascript): New function.
2570 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2571 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2572 the event loop. Get status from as_status (Bug#7276).
2574 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2575 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2576 the event loop (Bug#7276).
2578 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2580 * gnutls.c (QCgnutls_bootprop_priority)
2581 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2582 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2583 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2584 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2585 (QCgnutls_bootprop_verify_hostname_error)
2586 (QCgnutls_bootprop_callbacks_verify): Rename from
2587 Qgnutls_bootprop_..., all uses changed.
2589 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2592 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2594 * xfaces.c (Qframe_set_background_mode): Now static.
2595 * dispextern.h (Qframe_set_background_mode): Remove decl.
2597 * process.c (Fnetwork_interface_info): Declare local only if needed.
2599 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2601 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2602 (Fnetwork_interface_list): Allocate in increments of bytes instead
2603 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2604 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2606 (struct ifflag_def): notrailers is smart on OSX.
2607 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2608 Get hardware address with getifaddrs if available.
2610 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2612 * xdisp.c (iterate_out_of_display_property): xassert that
2613 IT->position is set to within IT->object's boundaries. Break from
2614 the loop as soon as EOB is reached; avoids infloops in redisplay
2615 when IT->position is set up wrongly due to some bug.
2616 Set IT->current to match the bidi iterator unconditionally.
2617 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2618 entry. Force push_it to save on the stack the current
2619 buffer/string position, to be restored by pop_it. Fix flags in
2620 the iterator structure wrt the object coming from a display
2621 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2622 properties. (Bug#9284)
2624 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2626 * fontset.c (fontset_get_font_group): Add proper type checks.
2629 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2631 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2632 and LC_VERSION_MIN_MACOSX.
2633 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2634 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2636 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2638 * xdisp.c (forward_to_next_line_start): Allow to use the
2639 no-display-properties-and-no-overlays under bidi display.
2640 Set disp_pos in the bidi iterator to avoid searches for display
2641 properties and overlays.
2643 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2645 * editfns.c (Fset_time_zone_rule): Document relationship with the
2648 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2649 the font entity extracted from the cache (Bug#8109).
2651 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2653 * composite.c (autocmp_chars): Don't reset point. That is done by
2654 restore_point_unwind (Bug#5984).
2656 2011-08-07 Juri Linkov <juri@jurta.org>
2658 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2659 to show the arg `TIME' instead of `TIMEVAL'.
2661 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2663 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2664 display property strides EOL and includes a newline, as in
2665 longlines-mode. (Bug#9254)
2666 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2667 word-wrap under bidirectional display. (Bug#9224)
2669 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2670 is non-zero, even if the data buffer is NULL. Fixes a crash in
2671 vertical-motion with longlines-mode. (Bug#9254)
2673 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2675 * bidi.c <bidi_cache_total_alloc>: Now static.
2676 (bidi_initialize): Initialize bidi_cache_total_alloc.
2678 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2681 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2682 amount allocated this far in `bidi_cache_total_alloc'.
2683 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2684 non-zero, only free the data buffer without restoring the cache
2685 contents. All callers changed.
2687 * dispextern.h (bidi_unshelve_cache): Update prototype.
2689 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2690 (move_it_in_display_line, move_it_to)
2691 (move_it_vertically_backward, move_it_by_lines): Replace the call
2692 to xfree to an equivalent call to bidi_unshelve_cache.
2693 (move_it_in_display_line_to): Fix logic of returning
2694 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2696 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2698 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2699 came from a string character with a `cursor' property. (Bug#9229)
2701 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2703 * Makefile.in (LIB_PTHREAD): New variable.
2704 (LIBES): Add LIB_PTHREAD (Bug#9216).
2706 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2707 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2709 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2711 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2713 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2715 * xterm.c (x_find_topmost_parent): New function.
2716 (x_set_frame_alpha): Find topmost parent window with
2717 x_find_topmost_parent and set the property there also (bug#9181).
2718 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2720 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2722 * callproc.c (Fcall_process): Avoid vfork clobbering
2723 the local vars buffer, coding_systems, current_dir.
2725 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2727 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2729 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2731 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2732 so that it is not optimized away.
2734 * xdisp.c (compute_display_string_pos): Remove unused local.
2736 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2738 Fix slow cursor motion and scrolling in large buffers with
2739 selective display, like Org Mode buffers. (Bug#9218)
2741 * dispextern.h (struct bidi_it): New member disp_prop_p.
2743 * xdisp.c: Remove one-slot cache of display string positions.
2744 (compute_display_string_pos): Accept an additional argument
2745 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2746 for a display string or property. If found, set DISP_PROP_P
2749 * bidi.c (bidi_fetch_char): Accept an additional argument
2750 DISP_PROP_P, and pass it to compute_display_string_pos.
2751 Only handle text covered by a display string if DISP_PROP_P is returned
2752 non-zero. All callers of bidi_fetch_char changed.
2754 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2756 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2758 2010-12-03 Don March <don@ohspite.net>
2760 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2761 last character M-[char] is translated to ESC [char] (bug#7541).
2763 2011-08-02 Kenichi Handa <handa@m17n.org>
2765 * lisp.h (uniprop_table): Extern it.
2767 * chartab.c (uniprop_table): Make it non-static.
2769 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2771 * xdisp.c (forward_to_next_line_start): Accept additional argument
2772 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2774 (reseat_at_next_visible_line_start): Use the bidi iterator state
2775 returned by forward_to_next_line_start to restore the state of
2776 it->bidi_it after backing up to previous newline. (Bug#9212)
2778 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2780 * regex.c (re_comp): Protoize.
2781 (re_exec): Fix return type.
2782 (regexec): Fix type of `ret'. (Bug#9203)
2784 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2786 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2787 This is needed if max-image-size is a floating-point number.
2789 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2791 * print.c (print_object): Print empty symbol as ##.
2793 * lread.c (read1): Read ## as empty symbol.
2795 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2797 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2798 setting frame foreground color (Bug#9175).
2799 (x_set_background_color): Likewise.
2801 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2802 contents (Bug#9176).
2803 (EmacsTooltip -init): Remove bezels and add shadows to
2806 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2807 or scroll bar (Bug#8470).
2809 * nsfont.m (nsfont_open): Remove assignment to voffset and
2810 unnecessary vars hshink, expand, hd, full_height, min_height.
2811 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2813 * nsterm.h (nsfont_info): Remove voffset field.
2815 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2817 Implement strike-through and overline on NextStep (Bug#8863).
2819 * nsfont.m (nsfont_open): Use underline position provided by font,
2820 instead of hard-coded value of 2.
2821 (nsfont_draw): Call ns_draw_text_decoration instead.
2823 * nsterm.h: Add declaration for ns_draw_text_decoration.
2825 * nsterm.m (ns_draw_text_decoration): New function for drawing
2826 underline, overline, and strike-through.
2827 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2828 ns_draw_text_decoration. Change treatment of cursor drawing to
2829 accommodate underlining, etc.
2831 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2833 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2836 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2838 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2839 Without this fix, if a signal arrives just after memory fills up,
2840 'malloc' might be invoked reentrantly.
2842 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2843 In other words, assume that every image size is allowed, on non-X
2844 hosts. This assumption is probably wrong, but it lets Emacs compile.
2846 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2848 * regex.c (re_iswctype): Convert return values to boolean.
2850 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2852 * xdisp.c (compute_display_string_pos): Don't use cached display
2853 string position if the buffer had its restriction changed.
2856 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2858 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2860 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2862 Integer signedness and overflow and related fixes. (Bug#9079)
2864 * bidi.c: Integer size and overflow fixes.
2865 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2866 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2867 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2868 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2869 (bidi_find_other_level_edge):
2870 Use ptrdiff_t instead of EMACS_INT where either will do.
2871 This works better on 32-bit hosts configured --with-wide-int.
2872 (bidi_cache_ensure_space): Check for size-calculation overflow.
2873 Use % rather than repeated addition, for better worst-case speed.
2874 Don't set bidi_cache_size until after xrealloc returns, because it
2876 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2877 (bidi_cache_ensure_space): Also check that the bidi cache size
2878 does not exceed that of the largest Lisp string or buffer. See Eli
2879 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2881 * alloc.c (__malloc_size_t): Remove.
2882 All uses replaced by size_t. See Andreas Schwab's note
2883 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2885 * image.c: Improve checking for integer overflow.
2886 (check_image_size): Assume that f is nonnull, since
2887 it is always nonnull in practice. This is one less thing to
2888 worry about when checking for integer overflow later.
2889 (x_check_image_size): New function, which checks for integer
2890 overflow issues inside X.
2891 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2892 This removes the need for a memory_full check.
2893 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2894 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2895 (xbm_read_bitmap_data): Change locals back to 'int', since
2896 their values must fit in 'int'.
2897 (xpm_load_image, png_load, tiff_load):
2898 Invoke x_create_x_image_and_pixmap earlier,
2899 to avoid much needless work if the image is too large.
2900 (tiff_load): Treat overly large images as if
2901 x_create_x_image_and_pixmap failed, not as malloc failures.
2902 (gs_load): Use x_check_image_size.
2904 * gtkutil.c: Omit integer casts.
2905 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2906 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2908 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2910 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2911 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2912 would wrongly return t on a 64-bit host.
2914 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2915 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2916 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2917 and therefore cause GCC to emit a bogus diagnostic in some cases.
2919 * image.c: Integer signedness and overflow and related fixes.
2920 This is not an exhaustive set of fixes, but it's time to
2921 record what I've got.
2922 (lookup_pixel_color, check_image_size): Remove redundant decls.
2923 (check_image_size): Don't assume that arbitrary EMACS_INT values
2924 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2925 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2926 (tiff_load, imagemagick_load_image):
2927 Check for overflow in size calculations.
2928 (x_create_x_image_and_pixmap): Remove unnecessary test for
2929 xmalloc returning NULL; that can't happen.
2930 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2931 (xpm_color_bucket): Use better integer hashing function.
2932 (xpm_cache_color): Don't possibly over-allocate memory.
2933 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2934 (gif_memory_source):
2935 Use ptrdiff_t, not int or size_t, to record sizes.
2936 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2937 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2938 either works, as we prefer signed integers.
2939 (tiff_read_from_memory, tiff_write_from_memory):
2940 Return tsize_t, not size_t, since that's what the TIFF API wants.
2941 (tiff_read_from_memory): Don't fail simply because the read would
2942 go past EOF; instead, return a short read.
2943 (tiff_load): Omit no-longer-needed casts.
2944 (Fimagemagick_types): Don't assume size fits into 'int'.
2946 Improve hashing quality when configured --with-wide-int.
2947 * fns.c (hash_string): New function, taken from sxhash_string.
2948 Do not discard information about ASCII character case; this
2949 discarding is no longer needed.
2950 (sxhash-string): Use it. Change sig to match it. Caller changed.
2951 * lisp.h: Declare it.
2952 * lread.c (hash_string): Remove, since we now use fns.c's version.
2953 The fns.c version returns a wider integer if --with-wide-int is
2954 specified, so this should help the quality of the hashing a bit.
2956 * emacs.c: Integer overflow minor fix.
2957 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2958 Define only if GNU_LINUX.
2959 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2961 * dispnew.c: Integer signedness and overflow fixes.
2962 Remove unnecessary forward decls, that were a maintenance hassle.
2963 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2965 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2966 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2967 (prepare_desired_row, line_draw_cost):
2968 Use int, not unsigned, where either works.
2969 (save_current_matrix, restore_current_matrix):
2970 Use ptrdiff_t, not size_t, where either works.
2971 (init_display): Check for overflow more accurately, and without
2972 relying on undefined behavior.
2974 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2975 Remove, replacing with the new symbols in lisp.h. All uses changed.
2976 * fileio.c (make_temp_name):
2977 * filelock.c (lock_file_1, lock_file):
2978 * xdisp.c (message_dolog):
2979 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2980 Use pMd etc. instead.
2981 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2982 replacing the pWIDE etc. symbols removed from editfns.c.
2984 * keyboard.h (num_input_events): Now uintmax_t.
2985 This is (very slightly) less likely to mess up due to wraparound.
2988 * buffer.c: Integer signedness fixes.
2989 (alloc_buffer_text, enlarge_buffer_text):
2990 Use ptrdiff_t rather than size_t when either will do, as we prefer
2993 * alloc.c: Integer signedness and overflow fixes.
2994 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2995 (__malloc_size_t): Default to size_t, not to int.
2996 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2997 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2998 Prefer ptrdiff_t to size_t when either would do, as we prefer
3000 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3001 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3002 Now const. Initialize with values that are in range even if char
3004 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3005 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3006 These functions do the right thing with sizes > 2**32.
3007 (check_depth): Now ptrdiff_t, not int.
3008 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3009 Adjust to new way of storing sizes. Check for size overflow bugs
3011 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3012 slightly wrong anyway, as it missed one instance of
3013 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3014 (refill_memory_reserve): Omit needless cast to size_t.
3015 (mark_object_loop_halt): Mark as externally visible.
3017 * xselect.c: Integer signedness and overflow fixes.
3018 (Fx_register_dnd_atom, x_handle_dnd_message):
3019 Use ptrdiff_t, not size_t, since we prefer signed.
3020 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3021 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3022 x_dnd_atoms_size and x_dnd_atoms_length.
3024 * doprnt.c: Prefer signed to unsigned when either works.
3026 * doprnt.c (doprnt):
3028 * xdisp.c (vmessage):
3029 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3030 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3031 prefer signed arithmetic to avoid comparison confusion.
3032 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3033 but is a bit tricky.
3035 Assume freestanding C89 headers, string.h, stdlib.h.
3036 * data.c, doprnt.c, floatfns.c, print.c:
3037 Include float.h unconditionally.
3038 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3039 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3040 * regex.c: Likewise for stddef.h, string.h.
3041 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3042 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3043 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3044 (STDC_HEADERS): Remove obsolete defines.
3045 * sysdep.c: Include limits.h unconditionally.
3047 Assume support for memcmp, memcpy, memmove, memset.
3048 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3049 * regex.c (memcmp, memcpy):
3050 Remove; we assume C89 now.
3052 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3053 (__malloc_safe_bcopy): Remove; no longer needed.
3055 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3056 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3057 well either way, and we prefer signed to unsigned.
3059 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3061 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3062 closes the connection while we're reading (bug#9182).
3064 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3066 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3067 are specified (Bug#9168).
3069 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3071 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3072 Found by GCC static checking and --with-wide-int on a 32-bit host.
3074 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3076 * xdisp.c (compute_display_string_pos): Fix logic of caching
3077 previous display string position. Initialize cached_prev_pos to
3078 -1. Fixes slow-down at the beginning of a buffer.
3080 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3082 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3083 for attrs[LFACE_FONTSET_INDEX].
3085 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3087 * xml.c (parse_region): Remove unused local
3088 that was recently introduced.
3090 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3092 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3093 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3095 * xdisp.c (move_it_in_display_line_to): Record the best matching
3096 position for TO_CHARPOS while scanning the line, and restore it on
3097 exit if none of the characters scanned was an exact match.
3098 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3099 when exact match is impossible due to invisible text, and the
3100 lines are truncated.
3102 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3104 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3107 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3109 Fix a significant slow-down of cursor motion with C-n, C-p,
3110 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3111 auto-repeat under bidi redisplay in fontified buffers.
3112 * xdisp.c (compute_stop_pos_backwards): New function.
3113 (next_element_from_buffer): Call compute_stop_pos_backwards to
3114 find a suitable prev_stop when we find ourselves before
3116 (reseat): Don't look for prev_stop, as that could mean a very long
3118 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3119 <cached_disp_overlay_modiff>: Cache for last found display string
3121 (compute_display_string_pos): Return the cached position if asked
3122 about the same buffer in the same area of character positions, and
3123 the buffer wasn't changed since the time the display string
3124 position was cached.
3126 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3128 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3129 is an integer, which is important for empty lines. (Bug#9149)
3131 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3133 * frame.c (Fmodify_frame_parameters): In tty case, update the
3134 default face if necessary (Bug#4238).
3136 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3138 * editfns.c (Fstring_to_char): No need to explain what a character
3139 is in the docstring (Bug#6576).
3141 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3143 * xml.c (parse_region): Make sure we always return a tree.
3145 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3147 * xml.c (parse_region): If a document contains only comments,
3150 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3152 * xml.c (make_dom): Return comments, too.
3154 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3157 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3158 and the surrounding thread.
3159 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3160 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3161 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3163 * s/openbsd.h (BROKEN_SIGIO): Define.
3164 * unexelf.c (unexec) [__OpenBSD__]:
3165 Don't update the .mdebug section of the Alpha COFF symbol table.
3167 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3169 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3172 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3174 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3175 This fixes some race conditions on the permissions of any newly
3178 * alloc.c (valid_pointer_p): Use pipe, not open.
3179 This fixes some permissions issues when debugging.
3181 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3182 If fchown fails to set both uid and gid, try to set just gid,
3183 as that is sometimes allowed. Adjust the file's mode to eliminate
3184 setuid or setgid bits that are inappropriate if fchown fails.
3186 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3188 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3189 to compare Lisp_Objects.
3190 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3191 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3192 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3194 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3196 * lread.c (read_integer): Unread even EOF character.
3197 (read1): Likewise. Properly record start position of symbol.
3199 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3200 symbol character follows.
3202 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3204 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3205 This works around a problem with the previous change to Fcopy_file.
3206 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3207 and without this change, GCC might complain about discarding
3208 fchown's return value.
3210 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3212 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3214 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3216 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3218 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3220 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3221 it's used from the C level.
3223 * process.c: Use the same condition for POLL_FOR_INPUT in both
3224 keyboard.c and process.c (bug#1858).
3226 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3228 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3229 (Fgnutls_boot): Use it.
3231 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3233 * doc.c (Fsubstitute_command_keys): Revert last change.
3235 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3237 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3238 quotes the next character, and doesn't affect other longer
3239 sequences (bug#8935).
3241 * lread.c (syms_of_lread): Clarify that is isn't only
3242 `eval-buffer' and `eval-defun' that's affected by
3243 `lexical-binding' (bug#8460).
3245 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3247 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3248 bidi redisplay when a line includes both an image and is truncated.
3250 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3252 Fix minor problems found by static checking.
3253 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3254 (elsz): Now a signed constant, not a size_t var. We prefer signed
3255 types to unsigned, to avoid integer comparison confusion. Without
3256 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3257 "cannot optimize loop, the loop counter may overflow", a symptom
3259 * indent.c (Fvertical_motion): Mark locals as initialized.
3260 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3262 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3264 * search.c (Fre_search_backward): Mention `case-fold-search' in
3265 all the re_search_* functions (bug#8138).
3267 * keyboard.c (Fopen_dribble_file): Document when the file is
3270 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3272 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3275 Support bidi reordering of display and overlay strings.
3276 * xdisp.c (compute_display_string_pos)
3277 (compute_display_string_end): Accept additional argument STRING.
3278 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3279 (reseat_to_string): Initialize bidi_it->string.s and
3280 bidi_it->string.schars.
3281 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3282 NULL (avoids a crash in bidi_paragraph_init).
3283 Initialize itb.string.lstring.
3284 (init_iterator): Call bidi_init_it only of a valid
3285 buffer position was specified. Initialize paragraph_embedding to
3287 (reseat_to_string): Initialize the bidi iterator.
3288 (display_string): If we need to ignore text properties of
3289 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3290 original value of -1 will not work with bidi.)
3291 (compute_display_string_pos): First arg is now struct
3292 `text_pos *'; all callers changed. Support display properties on
3294 (compute_display_string_end): Support display properties on Lisp
3296 (init_iterator, reseat_1, reseat_to_string): Initialize the
3297 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3298 when iterating on a string not from display properties).
3299 (compute_display_string_pos, compute_display_string_end):
3300 Fix calculation of the object to scan. Fixes an error when using
3302 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3303 base_level_stop; instead, set base_level_stop to BEGV.
3304 Fixes crashes in vertical-motion.
3305 (next_element_from_buffer): Improve commentary for when
3306 the iterator is before prev_stop.
3307 (init_iterator): Initialize bidi_p from the default value of
3308 bidi-display-reordering, not from buffer-local value. Use the
3309 buffer-local value only if initializing for buffer iteration.
3310 (handle_invisible_prop): Support invisible properties on strings
3311 that are being bidi-reordered.
3312 (set_iterator_to_next): Support bidi reordering of C strings and
3314 (next_element_from_string): Support bidi reordering of Lisp
3316 (handle_stop_backwards): Support Lisp strings as well.
3317 (display_string): Support display of R2L glyph rows.
3318 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3319 (init_iterator): Don't initialize it->bidi_p for strings
3321 (reseat_to_string): Initialize it->bidi_p for strings here.
3322 (next_element_from_string, next_element_from_c_string)
3323 (next_element_from_buffer): Add xassert's for correspondence
3324 between IT's object being iterated and it->bidi_it.string
3326 (face_before_or_after_it_pos): Support bidi iteration.
3327 (next_element_from_c_string): Handle the case of the first string
3328 character that is not the first one in the visual order.
3329 (get_visually_first_element): New function, refactored from common
3330 parts of next_element_from_buffer, next_element_from_string, and
3331 next_element_from_c_string.
3332 (tool_bar_lines_needed, redisplay_tool_bar)
3333 (display_menu_bar): Force left-to-right direction. Add a FIXME
3334 comment for making that be controlled by a user option.
3335 (push_it, pop_it): Save and restore the state of the
3336 bidi iterator. Save and restore the bidi_p flag.
3337 (pop_it): Iterate out of display property for string iteration as
3339 (iterate_out_of_display_property): Support iteration over strings.
3340 (handle_single_display_spec): Set up it->bidi_it for iteration
3341 over a display string, and call bidi_init_it.
3342 (handle_single_display_spec, next_overlay_string)
3343 (get_overlay_strings_1, push_display_prop): Set up the bidi
3344 iterator for displaying display or overlay strings.
3345 (forward_to_next_line_start): Don't use the shortcut if
3347 (back_to_previous_visible_line_start): If handle_display_prop
3348 pushed the iterator stack, restore the internal state of the bidi
3349 iterator by calling bidi_pop_it same number of times.
3350 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3351 and we are bidi-iterating, don't decrement the iterator position;
3352 instead, set the first_elt flag in the bidi iterator, to produce
3354 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3355 (push_display_prop): xassert that we are iterating a buffer.
3356 (push_it, pop_it): Save and restore paragraph_embedding member.
3357 (handle_single_display_spec, next_overlay_string)
3358 (get_overlay_strings_1, reseat_1, reseat_to_string)
3359 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3360 correctly. Don't assume unibyte strings are not bidi-reordered.
3361 (compute_display_string_pos)
3362 (compute_display_string_end): Fix handling the case of C string.
3363 (push_it, pop_it): Save and restore from_disp_prop_p.
3364 (handle_single_display_spec, push_display_prop): Set the
3365 from_disp_prop_p flag.
3366 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3367 (pop_it): Call iterate_out_of_display_property only if we are
3368 popping after iteration over a string that came from a display
3369 property. Fix a typo in popping stretch info. Add an assertion
3370 for verifying that the iterator position is in sync with the bidi
3372 (handle_single_display_spec, get_overlay_strings_1)
3373 (push_display_prop): Fix initialization of paragraph direction for
3374 string when that of the parent object is not yet determined.
3375 (reseat_1): Call bidi_init_it to resync the bidi
3376 iterator with IT's position. (Bug#7616)
3377 (find_row_edges): If ROW->start.pos gives position
3378 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3379 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3380 Reset the from_disp_prop_p flag.
3381 (SAVE_IT, RESTORE_IT): New macros.
3382 (pos_visible_p, face_before_or_after_it_pos)
3383 (back_to_previous_visible_line_start)
3384 (move_it_in_display_line_to, move_it_in_display_line)
3385 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3386 (try_scrolling, redisplay_window, display_line): Use them when
3387 saving a temporary copy of the iterator and restoring it back.
3388 (back_to_previous_visible_line_start, reseat_1)
3389 (init_iterator): Empty the bidi cache "stack".
3390 (move_it_in_display_line_to): If iterator ended up at
3391 EOL, but we never saw any buffer positions smaller than
3392 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3393 motion in bidi-reordered lines.
3394 (move_it_in_display_line_to): Record prev_method and prev_pos
3395 immediately before the call to set_iterator_to_next. Fixes cursor
3396 motion in bidi-reordered lines with stretch glyphs and strings
3397 displayed in margins. (Bug#8133) (Bug#8867)
3398 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3400 (pos_visible_p): Support positions in bidi-reordered lines.
3401 Save and restore bidi cache.
3403 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3404 (bidi_paragraph_info): Delete unused struct.
3405 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3406 (bidi_cache_start): New variable.
3407 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3409 (bidi_cache_fetch_state, bidi_cache_search)
3410 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3411 (bidi_cache_find, bidi_peek_at_next_level)
3412 (bidi_level_of_next_char, bidi_find_other_level_edge)
3413 (bidi_move_to_visually_next): Compare cache index with
3414 bidi_cache_start rather than with zero.
3415 (bidi_fetch_char): Accept new argument STRING; all callers
3416 changed. Support iteration over a string. Support strings with
3417 display properties. Support unibyte strings. Fix the type of
3418 `len' according to what STRING_CHAR_AND_LENGTH expects.
3419 (bidi_paragraph_init, bidi_resolve_explicit_1)
3420 (bidi_resolve_explicit, bidi_resolve_weak)
3421 (bidi_level_of_next_char, bidi_move_to_visually_next):
3422 Support iteration over a string.
3423 (bidi_set_sor_type, bidi_resolve_explicit_1)
3424 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3425 can now be zero (for strings); special values 0 and -1 were
3426 changed to -1 and -2, respectively.
3427 (bidi_char_at_pos): New function.
3428 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3429 Call it instead of FETCH_MULTIBYTE_CHAR.
3430 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3431 initialized to valid values.
3432 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3434 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3435 the test for valid cached positions. Fix the logic for looking up
3436 the sentinel state in the cache. GCPRO the Lisp string we are
3438 (bidi_push_it, bidi_pop_it): New functions.
3439 (bidi_initialize): Initialize the bidi cache start stack pointer.
3440 (bidi_cache_ensure_space): New function, refactored from part of
3441 bidi_cache_iterator_state. Don't assume the required size is just
3442 one BIDI_CACHE_CHUNK away.
3443 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3444 (bidi_count_bytes, bidi_char_at_pos): New functions.
3445 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3446 always valid if bidi_cache_idx is valid.
3447 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3448 is valid if it's going to be used.
3449 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3450 (bidi_cache_fetch_state, bidi_cache_search)
3451 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3452 (bidi_cache_iterator_state, bidi_cache_find)
3453 (bidi_find_other_level_edge, bidi_cache_start_stack):
3454 All variables related to cache indices are now EMACS_INT.
3456 * dispextern.h (struct bidi_string_data): New structure.
3457 (struct bidi_it): New member `string'. Make flag members be 1-bit
3458 fields, and put them last in the struct.
3459 (compute_display_string_pos, compute_display_string_end):
3461 (bidi_push_it, bidi_pop_it): Add prototypes.
3462 (struct iterator_stack_entry): New members bidi_p,
3463 paragraph_embedding, and from_disp_prop_p.
3464 (struct it): Member bidi_p is now a bit field 1 bit wide.
3465 (bidi_shelve_cache, bidi_unshelve_cache):
3468 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3469 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3470 and vector-like objects.
3472 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3473 cache around display iteration.
3475 * window.c (Fwindow_end, window_scroll_pixel_based)
3476 (displayed_window_lines, Frecenter): Save and restore the bidi
3477 cache around display iteration.
3479 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3481 * editfns.c (Fdelete_region): Clarify the use of the named
3482 parameters (bug#6788).
3484 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3486 * indent.c (Fvertical_motion): Set and restore w->pointm when
3487 saving and restoring the window's buffer (Bug#9006).
3489 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3491 * editfns.c (Fstring_to_char): Clarify just what is returned
3492 (bug#6576). Text by Eli Zaretskii.
3494 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3496 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3498 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3500 * buffer.c (mmap_find): Fix a typo.
3502 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3504 Fix execution of x selection hooks.
3505 * xselect.c (Qx_lost_selection_functions)
3506 (Qx_sent_selection_functions): New vars.
3507 (syms_of_xselect): DEFSYM them.
3508 (x_handle_selection_request): Pass Qx_sent_selection_functions
3509 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3510 (x_handle_selection_clear,x_clear_frame_selections):
3511 Pass Qx_lost_selection_functions rather than
3512 Vx_lost_selection_functions to Frun_hook_with_args.
3514 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3516 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3517 The old code sometimes used this field without initializing it.
3519 * alloc.c (gc_sweep): Don't read past end of array.
3520 In theory, the old code could also have corrupted Emacs internals,
3521 though it'd be very unlikely.
3523 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3525 * character.c (Fcharacterp): Don't advertise optional ignored
3526 argument. (Bug#4026)
3528 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3530 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3533 * window.c (Fset_window_start): Doc fix (bug#4199).
3534 (Fset_window_hscroll): Ditto.
3536 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3538 Fix minor new problems caught by GCC 4.6.1.
3539 * term.c (init_tty): Remove unused local.
3540 * xsettings.c (store_monospaced_changed): Define this function only
3541 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3544 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3546 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3548 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3550 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3551 are the mini-buffer and the echo area (bug#3320).
3553 * term.c (init_tty): Remove support for supdup, c10 and perq
3554 terminals, which are no longer supported (bug#1482).
3556 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3558 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3560 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3562 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3563 for non-popups (Bug#3642).
3565 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3567 * alloc.c (reset_malloc_hooks): Protoize.
3568 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3569 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3570 * cm.c (losecursor): Likewise.
3571 * data.c (fmod): Likewise.
3572 * dispnew.c (swap_glyphs_in_rows): Likewise.
3573 * emacs.c (memory_warning_signal): Likewise.
3574 * floatfns.c (float_error): Likewise.
3575 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3576 (otf_open, font_otf_capability, generate_otf_features)
3577 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3579 * image.c (pbm_read_file): Likewise.
3580 * indent.c (string_display_width): Likewise.
3581 * intervals.c (check_for_interval, search_for_interval)
3582 (inc_interval_count, count_intervals, root_interval)
3583 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3584 * lread.c (defalias): Likewise.
3585 * ralloc.c (r_alloc_check): Likewise.
3586 * regex.c (set_image_of_range_1, set_image_of_range)
3587 (regex_grow_registers): Likewise.
3588 * sysdep.c (strerror): Likewise.
3589 * termcap.c (valid_filename_p, tprint, main): Likewise.
3590 * tparam.c (main): Likewise.
3591 * unexhp9k800.c (run_time_remap, save_data_space)
3592 (update_file_ptrs, read_header, write_header, calculate_checksum)
3593 (copy_file, copy_rest, display_header): Likewise.
3594 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3596 * xdisp.c (check_it): Likewise.
3597 * xfaces.c (register_color, unregister_color, unregister_colors):
3599 * xfns.c (print_fontset_result): Likewise.
3600 * xrdb.c (member, fatal, main): Likewise.
3602 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3604 Fix minor problems found by static checking (Bug#9031).
3605 * chartab.c (char_table_set_range, map_sub_char_table):
3606 Remove unused locals.
3607 (uniprop_table): Now static.
3608 * composite.c (_work_char): Remove unused static var.
3610 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3612 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3614 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3616 * gtkutil.c (qttip_cb): Remove code without function.
3618 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3620 * w32.c (pthread_sigmask): New stub.
3622 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3624 Use pthread_sigmask, not sigprocmask (Bug#9010).
3625 sigprocmask is portable only for single-threaded applications, and
3626 Emacs can be multi-threaded when it uses GTK.
3627 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3629 * callproc.c (Fcall_process):
3630 * process.c (create_process):
3631 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3632 Use pthread_sigmask, not sigprocmask.
3634 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3636 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3637 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3640 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3642 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3643 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3644 (xg_hide_tooltip): Fix comment.
3646 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3647 in registerServicesMenuSendTypes.
3648 (validRequestorForSendType): Don't check ns_return_types.
3650 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3653 2011-07-08 Jason Rumney <jasonr@gnu.org>
3655 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3656 SH_SHOW for hidden windows (Bug#5482).
3658 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3659 frame struct members of non-existent frames (Bug#6284).
3661 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3663 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3664 variable firstTime not needed on OSX >= 10.6.
3665 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3666 >= 10.5. Use setKnobProportion, setDoubleValue.
3668 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3669 (MAC_OS_X_VERSION_10_5): Define if not defined.
3670 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3671 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3672 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3674 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3675 cString and lossyCString on OSX >= 10.4
3677 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3678 sizeToFit on OSX >= 10.2.
3680 * nsimage.m (allocInitFromFile): Don't use deprecated method
3681 bestRepresentationForDevice on OSX >= 10.6.
3683 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3686 * emacs.c: Declare unexec_init_emacs_zone.
3688 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3690 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3692 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3693 on svcsMenu (Bug#8842).
3695 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3697 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3699 * nsterm.m (QUTF8_STRING): Declare.
3700 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3701 (validRequestorForSendType): Return type is (id).
3702 Change indexOfObjectIdenticalTo to indexOfObject.
3703 Check if we have local selection before returning self (Bug#8842).
3704 (writeSelectionToPasteboard): Put local selection into paste board
3705 if we have a local selection (Bug#8842).
3706 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3708 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3709 (ns_get_local_selection): Declare.
3711 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3713 * keymap.c (describe_map_tree): Don't insert a double newline at
3714 the end of the buffer (bug#1169) and return whether we inserted
3717 * callint.c (Fcall_interactively): Change "reading args" to
3718 "providing args" to try to clarify what it does (bug#1010).
3720 2011-07-07 Kenichi Handa <handa@m17n.org>
3722 * composite.c (composition_compute_stop_pos): Ignore a static
3723 composition starting before CHARPOS (Bug#8915).
3725 * xdisp.c (handle_composition_prop): Likewise.
3727 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3729 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3732 2011-07-07 Kenichi Handa <handa@m17n.org>
3734 * character.h (unicode_category_t): New enum type.
3736 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3737 (Qchar_code_property_table): New variable.
3738 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3739 (UNIPROP_COMPRESSED_FORM_P): New macros.
3740 (char_table_ascii): Uncompress the compressed values.
3741 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3742 Uncompress the compressed values.
3743 (sub_char_table_ref_and_range): Likewise.
3744 (char_table_ref_and_range): Uncompress the compressed values.
3745 (sub_char_table_set): New arg is_uniprop. Callers changed.
3746 Uncompress the compressed values.
3747 (sub_char_table_set_range): Args changed. Callers changed.
3748 (char_table_set_range): Adjuted for the above change.
3749 (map_sub_char_table): Delete args default_val and parent. Add arg
3750 top. Give decoded values to a Lisp function.
3751 (map_char_table): Adjust for the above change. Give decoded
3752 values to a Lisp function. Gcpro more variables.
3753 (uniprop_table_uncompress)
3754 (uniprop_decode_value_run_length): New functions.
3755 (uniprop_decoder, uniprop_decoder_count): New variables.
3756 (uniprop_get_decoder, uniprop_encode_value_character)
3757 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3759 (uniprop_encoder, uniprop_encoder_count): New variables.
3760 (uniprop_get_encoder, uniprop_table)
3761 (Funicode_property_table_internal, Fget_unicode_property_internal)
3762 (Fput_unicode_property_internal): New functions.
3763 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3764 Sunicode_property_table_internal, Sget_unicode_property_internal,
3765 and Sput_unicode_property_internal. Defvar_lisp
3766 char-code-property-alist.
3768 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3769 Vunicode_category_table.
3771 * font.c (font_range): Adjust for the change of
3772 Vunicode_category_table.
3774 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3776 * m/iris4d.h: Remove file, move contents ...
3777 * s/irix6-5.h: ... here.
3779 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3781 Remove unportable assumption about struct layout (Bug#8884).
3782 * alloc.c (mark_buffer):
3783 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3784 (clone_per_buffer_values): Don't assume that
3785 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3786 This isn't true in general, and it's particularly not true
3787 if Emacs is configured with --with-wide-int.
3788 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3789 New macros, used in the buffer.c change.
3791 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3793 * xsettings.c: Use both GConf and GSettings if both are available.
3794 (store_config_changed_event): Add comment.
3795 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3796 (store_tool_bar_style_changed): New functions.
3797 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3798 (struct xsettings): Move font inside HAVE_XFT.
3799 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3800 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3801 Move inside HAVE_XFT.
3802 (something_changed_gsettingsCB): Rename from something_changedCB.
3803 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3805 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3806 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3807 (something_changed_gconfCB): Rename from something_changedCB.
3808 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3809 (parse_settings): Move check for font inside HAVE_XFT.
3810 (read_settings, apply_xft_settings): Add comment.
3811 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3812 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3813 call store_font_name_changed.
3814 (xft_settings_event): Add comment.
3815 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3816 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3817 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3818 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3819 (xsettings_initialize): Call init_gsettings last.
3820 (xsettings_get_system_font, xsettings_get_system_normal_font):
3823 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3825 Random fixes. E.g., (random) never returned negative values.
3826 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3827 subseconds part to the entropy, as that's a bit more random.
3828 Prefer signed to unsigned, since the signedness doesn't matter and
3829 in general we prefer signed. When given a limit, use a
3830 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3831 latter isn't right if USE_2_TAGS_FOR_INTS.
3832 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3833 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3835 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3837 * textprop.c (text_property_stickiness):
3838 Obey Vtext_property_default_nonsticky.
3839 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3840 * w32fns.c (syms_of_w32fns):
3841 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3843 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3845 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3846 This is more efficient than Ffile_directory_p and avoids a minor race.
3848 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3850 * buffer.c (Foverlay_put): Say what the return value is
3853 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3854 is a directory before asking whether to use the file name
3856 (barf_or_query_if_file_exists): Make the "File is a directory"
3857 error be more correct.
3859 * fns.c (Frequire): Remove the mention of the .gz files, since
3860 that's installation-specific, but keep the mention of
3861 `get-load-suffixes'.
3863 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3865 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3866 Report string overflow if the output is too long.
3868 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3870 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3871 (syms_of_gnutls): Remove duplicate DEFSYM for
3872 Qgnutls_bootprop_verify_hostname_error, an error for
3873 Qgnutls_bootprop_verify_error (which is no longer used).
3875 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3876 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3877 Also (re)move comments that are misplaced or no longer relevant.
3879 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3881 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3883 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3885 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3886 and background color parameters if they have been changed.
3888 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3890 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3892 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3894 * xsettings.c (SYSTEM_FONT): Define only when used.
3895 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3897 * keymap.c (access_keymap_1): Now static.
3899 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3901 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3902 leave any prefix arg for the up event (Bug#1586).
3904 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3906 * lread.c (syms_of_lread): Mention single symbols defined by
3907 `defvar' or `defconst' (bug#7154).
3909 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3910 (Frequire): Mention get-load-suffixes.
3912 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3914 * window.h (window): Remove clone_number slot.
3915 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3917 (make_parent_window, make_window, saved_window)
3918 (Fset_window_configuration, save_window_save): Don't deal with
3920 * buffer.c (Qclone_number): Remove declaration.
3921 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3923 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3925 Add multiple inheritance to keymaps.
3926 * keymap.c (Fmake_composed_keymap): New function.
3927 (Fset_keymap_parent): Simplify.
3928 (fix_submap_inheritance): Remove.
3929 (access_keymap_1): New function extracted from access_keymap to handle
3930 embedded parents and handle lists of maps.
3931 (access_keymap): Use it.
3932 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3933 (Fcopy_keymap): Handle embedded parents.
3934 (Fcommand_remapping, define_as_prefix): Simplify.
3935 (Fkey_binding): Simplify.
3936 (syms_of_keymap): Move minibuffer-local-completion-map,
3937 minibuffer-local-filename-completion-map,
3938 minibuffer-local-must-match-map, and
3939 minibuffer-local-filename-must-match-map to Elisp.
3940 (syms_of_keymap): Defsubr make-composed-keymap.
3941 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3942 (parse_menu_item): Trivial simplification.
3944 2011-07-01 Glenn Morris <rgm@gnu.org>
3946 * Makefile.in (SETTINGS_LIBS): Fix typo.
3948 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3950 * coding.c (Fencode_coding_string): Record the last coding system
3951 used, as the function doc string says (bug#8738).
3953 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3955 * xsettings.c (store_monospaced_changed): Take new font as arg and
3956 check for change against current_mono_font.
3957 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3958 (emacs_settings_constructor, emacs_settings_get_property)
3959 (emacs_settings_set_property, emacs_settings_class_init)
3960 (emacs_settings_init, gsettings_obj): Remove.
3961 (something_changedCB): New function for HAVE_GSETTINGS.
3962 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3963 with value as argument.
3964 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3965 g_settings_new (Bug#8967). Do not create gsettings_obj.
3966 Remove calls to g_settings_bind. Connect something_changedCB to
3969 * xgselect.c: Add defined (HAVE_GSETTINGS).
3970 (xgselect_initialize): Ditto.
3972 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3973 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3976 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3978 * eval.c (struct backtrace): Simplify and port the data structure.
3979 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3980 signed bit field, as this assumption is not portable and it makes
3981 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3982 "char debug_on_exit : 1" as this is not portable either; instead,
3983 use the portable "unsigned int debug_on_exit : 1". Remove unused
3984 member evalargs. Remove obsolete comments about cc bombing out.
3986 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3988 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3989 Let HAVE_GSETTINGS override HAVE_GCONF.
3990 (store_monospaced_changed): New function.
3991 (EMACS_SETTINGS): A new type derived from GObject to handle
3992 GSettings notifications.
3993 (emacs_settings_constructor, emacs_settings_get_property)
3994 (emacs_settings_set_property, emacs_settings_class_init):
3996 (gsettings_client, gsettings_obj): New variables.
3997 (GSETTINGS_SCHEMA): New define.
3998 (something_changedCB): Call store_monospaced_changed.
3999 (init_gsettings): New function.
4000 (xsettings_initialize): Call init_gsettings.
4001 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4004 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4007 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4009 * window.c (resize_root_window, grow_mini_window)
4010 (shrink_mini_window): Rename Qresize_root_window to
4011 Qwindow_resize_root_window and Qresize_root_window_vertically to
4012 Qwindow_resize_root_window_vertically.
4014 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4016 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4018 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4020 * makefile.w32-in: Redesign dependencies so they reflect more
4021 clearly which files are directly included by each source file,
4022 and not through other includes.
4024 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4026 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4027 (sort_overlays, overlay_strings): When an overlay's clone number
4028 matches the window's clone number process the overlay even if
4029 the overlay's window property doesn't match the current window.
4031 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4032 (Fwindow_hchild): Rename to Fwindow_left_child.
4033 (Fwindow_next): Rename to Fwindow_next_sibling.
4034 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4035 (resize_window_check): Rename to window_resize_check.
4036 (resize_window_apply): Rename to window_resize_apply.
4037 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4038 (Fdelete_other_windows_internal, resize_frame_windows)
4039 (Fsplit_window_internal, Fdelete_window_internal)
4040 (grow_mini_window, shrink_mini_window)
4041 (Fresize_mini_window_internal): Fix callers accordingly.
4043 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4045 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4046 (emacs_fixed_set_min_size): Remove.
4047 (emacs_fixed_new): Take frame as argument.
4049 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4050 (_EmacsFixedPrivate): Remove minwidth/height.
4051 Add struct frame *f.
4052 (emacs_fixed_init): Initialize priv->f.
4053 (get_parent_class, emacs_fixed_set_min_size): Remove.
4054 (emacs_fixed_new): Set priv->f to argument.
4055 (emacs_fixed_get_preferred_width)
4056 (emacs_fixed_get_preferred_height): Use min_width/height from
4057 frames size_hint to set minimum and natural (Bug#8919).
4058 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4059 and use min_width/height from frames size_hint to set
4060 min_width/height (Bug#8919).
4062 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4063 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4066 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4068 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4069 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4072 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4074 * process.c (wait_reading_process_output): Bypass select if
4075 waiting for a cell while ignoring keyboard input, and input is
4076 pending. Suggested by Jan Djärv (Bug#8869).
4078 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4080 Use gnulib's dup2 module instead of rolling our own.
4081 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4083 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4085 * dispnew.c (scrolling_window): Before scrolling, turn off a
4086 mouse-highlight in the window being scrolled.
4088 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4090 Move DEFSYM to lisp.h and use everywhere.
4092 * character.h (DEFSYM): Move declaration...
4093 * lisp.h (DEFSYM): ...here.
4099 * w32select.c: Don't include character.h.
4101 * alloc.c (syms_of_alloc):
4102 * buffer.c (syms_of_buffer):
4103 * bytecode.c (syms_of_bytecode):
4104 * callint.c (syms_of_callint):
4105 * casefiddle.c (syms_of_casefiddle):
4106 * casetab.c (init_casetab_once):
4107 * category.c (init_category_once, syms_of_category):
4108 * ccl.c (syms_of_ccl):
4109 * cmds.c (syms_of_cmds):
4110 * composite.c (syms_of_composite):
4111 * dbusbind.c (syms_of_dbusbind):
4112 * dired.c (syms_of_dired):
4113 * dispnew.c (syms_of_display):
4114 * doc.c (syms_of_doc):
4115 * editfns.c (syms_of_editfns):
4116 * emacs.c (syms_of_emacs):
4117 * eval.c (syms_of_eval):
4118 * fileio.c (syms_of_fileio):
4119 * fns.c (syms_of_fns):
4120 * frame.c (syms_of_frame):
4121 * fringe.c (syms_of_fringe):
4122 * insdel.c (syms_of_insdel):
4123 * keymap.c (syms_of_keymap):
4124 * lread.c (init_obarray, syms_of_lread):
4125 * macros.c (syms_of_macros):
4126 * msdos.c (syms_of_msdos):
4127 * print.c (syms_of_print):
4128 * process.c (syms_of_process):
4129 * search.c (syms_of_search):
4130 * sound.c (syms_of_sound):
4131 * syntax.c (init_syntax_once, syms_of_syntax):
4132 * terminal.c (syms_of_terminal):
4133 * textprop.c (syms_of_textprop):
4134 * undo.c (syms_of_undo):
4135 * w32.c (globals_of_w32):
4136 * window.c (syms_of_window):
4137 * xdisp.c (syms_of_xdisp):
4138 * xfaces.c (syms_of_xfaces):
4139 * xfns.c (syms_of_xfns):
4140 * xmenu.c (syms_of_xmenu):
4141 * xsettings.c (syms_of_xsettings):
4142 * xterm.c (syms_of_xterm): Use DEFSYM.
4144 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4146 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4148 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4150 Integer and buffer overflow fixes (Bug#8873).
4152 * print.c (printchar, strout): Check for string overflow.
4153 (PRINTPREPARE, printchar, strout):
4154 Don't set size unless allocation succeeds.
4156 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4157 for sizes. Check for string overflow more accurately.
4158 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4160 * macros.c: Integer and buffer overflow fixes.
4161 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4162 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4163 Use ptrdiff_t, not int, for sizes.
4164 Don't increment bufsize until after realloc succeeds.
4165 Check for size-calculation overflow.
4166 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4168 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4170 * lread.c: Integer overflow fixes.
4171 (read_integer): Radix is now EMACS_INT, not int,
4172 to improve quality of diagnostics for out-of-range radices.
4173 Calculate buffer size correctly for out-of-range radices.
4174 (read1): Check for integer overflow in radices, and in
4175 read-circle numbers.
4176 (read_escape): Avoid int overflow.
4177 (Fload, openp, read_buffer_size, read1)
4178 (substitute_object_recurse, read_vector, read_list, map_obarray):
4179 Use ptrdiff_t, not int, for sizes.
4180 (read1): Use EMACS_INT, not int, for sizes.
4181 Check for size overflow.
4183 * image.c (cache_image): Check for size arithmetic overflow.
4185 * lread.c: Integer overflow issues.
4186 (saved_doc_string_size, saved_doc_string_length)
4187 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4188 Now ptrdiff_t, not int.
4189 (read1): Don't assume doc string length fits in int. Check for
4190 out-of-range doc string lengths.
4191 (read_list): Don't assume file position fits in int.
4192 (read_escape): Check for hex character overflow.
4194 2011-06-22 Leo Liu <sdl.web@gmail.com>
4196 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4197 Move to minibuffer.el.
4199 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4201 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4202 The following patches are for when GLYPH_DEBUG && !XASSERT.
4203 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4204 * dispnew.c (flush_stdout):
4205 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4206 Mark as externally visible.
4207 * dispnew.c (check_window_matrix_pointers): Now static.
4208 * dispnew.c (window_to_frame_vpos):
4209 * xfns.c (unwind_create_frame):
4210 * xterm.c (x_check_font): Remove unused local.
4211 * scroll.c (CHECK_BOUNDS):
4212 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4213 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4214 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4215 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4216 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4218 (debug_method_add): Use va_list and vsprintf rather than relying
4219 on undefined behavior with wrong number of arguments.
4220 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4221 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4222 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4223 since we're not interested in debugging glyphs with old libraries.
4224 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4225 GCC 4.6.0's static checking.
4227 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4229 Integer overflow and signedness fixes (Bug#8873).
4230 A few related buffer overrun fixes, too.
4232 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4234 * dispextern.h (struct face.stipple):
4235 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4236 (x_bitmap_mask, x_allocate_bitmap_record)
4237 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4238 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4239 (x_create_bitmap_from_xpm_data):
4240 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4241 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4243 * xfaces.c (load_pixmap):
4244 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4245 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4246 (.bitmaps_last, struct x_output.icon_bitmap):
4247 Use ptrdiff_t, not int, for bitmap indexes.
4248 (x_allocate_bitmap_record): Check for size overflow.
4249 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4251 Use ptrdiff_t, not int, for overlay counts.
4252 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4253 * editfns.c (overlays_around, get_pos_property):
4254 * textprop.c (get_char_property_and_overlay):
4255 * xdisp.c (next_overlay_change, note_mouse_highlight):
4256 * xfaces.c (face_at_buffer_position):
4257 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4258 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4259 (Fnext_overlay_change, Fprevious_overlay_change)
4260 (mouse_face_overlay_overlaps, Foverlays_in):
4261 Use ptrdiff_t, not int, for sizes.
4262 (overlays_at, overlays_in): Check for size-calculation overflow.
4264 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4266 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4267 (x_session_initialize): Do not assume string length fits in int.
4269 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4270 This is unlikely, but can occur if DPI is outlandish.
4272 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4273 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4275 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4276 * xrdb.c (magic_file_p, search_magic_path):
4277 Omit last arg SUFFIX; it was always 0. All callers changed.
4278 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4280 * xfont.c (xfont_match): Avoid need for strlen.
4282 * xfns.c: Don't assume strlen fits in int.
4283 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4285 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4286 not unsigned long, as we prefer signed integers. All callers changed.
4287 Detect integer overflow in repeat count.
4288 (message_dolog): Don't assume print length fits in 39 bytes.
4289 (display_mode_element): Don't assume strlen fits in int.
4291 * termcap.c: Don't assume sizes fit in int and never overflow.
4292 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4293 (gobble_line): Check for size-calculation overflow.
4295 * minibuf.c (Fread_buffer):
4296 * lread.c (intern, intern_c_string):
4297 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4298 Don't assume string length fits in int.
4300 * keyboard.c (parse_tool_bar_item):
4301 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4303 * font.c: Don't assume string length fits in int.
4304 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4305 Use ptrdiff_t, not int.
4306 (font_intern_prop): Don't assume string length fits in int.
4307 Don't assume integer property fits in fixnum.
4308 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4310 * filelock.c: Fix some buffer overrun and integer overflow issues.
4311 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4312 Reformulate so as not to need the command string.
4313 Invoke gzip -cd rather than gunzip, as it's more portable.
4314 (lock_info_type, lock_file_1, lock_file):
4315 Don't assume pid_t and time_t fit in unsigned long.
4316 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4317 (current_lock_owner): Prefer signed type for sizes.
4318 Use memcpy, not strncpy, where memcpy is what is really wanted.
4319 Don't assume (via atoi) that time_t and pid_t fit in int.
4320 Check for time_t and/or pid_t out of range, e.g., via a network share.
4321 Don't alloca where an auto var works fine.
4323 * fileio.c: Fix some integer overflow issues.
4324 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4325 Don't assume string length fits in int.
4326 (directory_file_name): Don't assume string length fits in long.
4327 (make_temp_name): Don't assume pid fits in int, or that its print
4328 length is less than 20.
4330 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4332 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4334 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4336 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4337 We prefer signed integers, even for size calculations.
4339 * emacs.c: Don't assume string length fits in 'int'.
4340 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4341 (main): Don't invoke strlen when not needed.
4343 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4344 (XD_DEBUG_MESSAGE): Don't waste a byte.
4346 * callproc.c (getenv_internal_1, getenv_internal)
4348 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4350 * lread.c (invalid_syntax): Omit length argument.
4351 All uses changed. This doesn't fix a bug, but it simplifies the
4352 code away from its former Hollerith-constant appearance, and it's
4353 one less 'int' to worry about when looking at integer-overflow issues.
4354 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4356 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4357 This didn't break anything, but it didn't help either.
4358 It's confusing to put a bogus integer in a place where the actual
4359 value does not matter.
4360 (LIST_END_P): Remove unused macro and its bogus comment.
4361 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4363 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4364 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4366 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4367 We prefer signed types, and the value cannot exceed the EMACS_INT
4368 range anyway (because otherwise the length would not be representable).
4369 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4370 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4371 This avoids a GCC warning when WIDE_EMACS_INT.
4373 * indent.c (sane_tab_width): New function.
4374 (current_column, scan_for_column, Findent_to, position_indentation)
4375 (compute_motion): Use it. This is just for clarity.
4376 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4378 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4380 * lisp.h (lint_assume): New macro.
4381 * composite.c (composition_gstring_put_cache):
4382 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4384 * editfns.c, insdel.c:
4385 Omit unnecessary forward decls, to simplify future changes.
4387 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4389 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4391 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4392 Use much-faster test for byte-length change.
4393 Don't assume string byte-length fits in 'int'.
4394 Check that character arg fits in 'int'.
4395 (mapcar1): Declare byte as byte, for clarity.
4397 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4399 * fns.c (concat): Catch string overflow earlier.
4400 Do not rely on integer wraparound.
4402 * dispextern.h (struct it.overlay_strings_charpos)
4403 (struct it.selective): Now EMACS_INT, not int.
4404 * xdisp.c (forward_to_next_line_start)
4405 (back_to_previous_visible_line_start)
4406 (reseat_at_next_visible_line_start, next_element_from_buffer):
4407 Don't arbitrarily truncate the value of 'selective' to int.
4409 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4411 * composite.c: Don't truncate sizes to 'int'.
4412 (composition_gstring_p, composition_reseat_it)
4413 (composition_adjust_point): Use EMACS_INT, not int.
4414 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4415 not EMACS_UINT, for indexes.
4417 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4419 * buffer.c: Include <verify.h>.
4420 (struct sortvec.priority, struct sortstr.priority):
4421 Now EMACS_INT, not int.
4422 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4423 (struct sortstr.size, record_overlay_string)
4424 (struct sortstrlist.size, struct sortlist.used):
4425 Don't truncate size to int.
4426 (record_overlay_string): Check for size-calculation overflow.
4427 (init_buffer_once): Check at compile-time, not run-time.
4429 2011-06-22 Jim Meyering <meyering@redhat.com>
4431 Don't leak an XBM-image-sized buffer
4432 * image.c (xbm_load): Free the image buffer after using it.
4434 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4437 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4438 that Sun C diagnosed.
4439 * fns.c (secure_hash): Fix pointer signedness issue.
4440 * intervals.c (static_offset_intervals): New function.
4441 (offset_intervals): Use it.
4443 2011-06-21 Leo Liu <sdl.web@gmail.com>
4446 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4449 * fns.c (secure_hash): Rename from crypto_hash_function and change
4450 the first arg to accept symbols.
4451 (Fsecure_hash): New primitive.
4452 (syms_of_fns): New symbols.
4454 2011-06-20 Deniz Dogan <deniz@dogan.se>
4456 * process.c (Fset_process_buffer): Clarify return value in
4459 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4461 * dispnew.c (add_window_display_history): Use BVAR.
4463 * xdisp.c (debug_method_add): Use BVAR.
4464 (check_window_end, dump_glyph_matrix, dump_glyph)
4465 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4467 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4470 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4471 check till after the cache is created in init_frame_faces.
4473 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4475 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4477 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4479 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4480 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4481 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4483 Improve buffer-overflow checking (Bug#8873).
4484 * fileio.c (Finsert_file_contents):
4485 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4486 Remove the old (too-loose) buffer overflow checks.
4487 They weren't needed, since make_gap checks for buffer overflow.
4488 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4489 The old code merely checked for Emacs fixnum overflow, and relied
4490 on undefined (wraparound) behavior. The new code avoids undefined
4491 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4493 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4494 Tune. Don't use wider integers than needed. Don't use alloca.
4495 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4497 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4499 * insdel.c, lisp.h (buffer_overflow): New function.
4500 (insert_from_buffer_1, replace_range, replace_range_2):
4501 * insdel.c (make_gap_larger):
4502 * editfns.c (Finsert_char):
4503 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4505 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4507 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4509 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4511 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4512 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4514 * fileio.c: Don't assume EMACS_INT fits in off_t.
4515 (emacs_lseek): New static function.
4516 (Finsert_file_contents, Fwrite_region): Use it.
4517 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4519 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4521 * fns.c: Don't overflow int when computing a list length.
4522 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4523 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4524 truncation on 64-bit hosts. Check for QUIT every
4525 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4526 faster and is responsive enough.
4527 (Flength): Report an error instead of overflowing an integer.
4528 (Fsafe_length): Return a float if the value is not representable
4529 as a fixnum. This shouldn't happen except in contrived situations.
4530 (Fnthcdr, Fsort): Don't assume list length fits in int.
4531 (Fcopy_sequence): Don't assume vector length fits in int.
4533 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4534 (header_size, word_size): New constants.
4535 (allocate_vectorlike): Don't check size overflow here.
4536 (allocate_vector): Check it here instead, since this is the only
4537 caller of allocate_vectorlike that could cause overflow.
4538 Check that the new vector's length is representable as a fixnum.
4540 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4541 The previous code was bogus. For example, next_almost_prime (32)
4542 returned 39, which is undesirable as it is a multiple of 3; and
4543 next_almost_prime (24) returned 25, which is a multiple of 5 so
4544 why was the code bothering to check for multiples of 7?
4546 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4548 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4550 Variadic C functions now count arguments with ptrdiff_t.
4551 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4552 Back then I didn't know that the Emacs coding style prefers signed int.
4553 Also, in the meantime I found a few more instances where arguments
4554 were being counted with int, which may truncate counts on 64-bit
4555 machines, or EMACS_INT, which may be unnecessarily wide.
4556 * lisp.h (struct Lisp_Subr.function.aMANY)
4557 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4558 Arg counts are now ptrdiff_t, not size_t.
4559 All variadic functions and their callers changed accordingly.
4560 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4561 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4562 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4563 * callint.c (Fcall_interactively): Check arg count for overflow,
4564 to avoid potential buffer overrun. Use signed char, not 'int',
4565 for 'varies' array, so that we needn't bother to check its size
4566 calculation for overflow.
4567 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4568 * eval.c (apply_lambda):
4569 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4570 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4571 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4573 * callint.c (Fcall_interactively): Don't use index var as event count.
4575 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4576 * mem-limits.h (SIZE): Remove; no longer used.
4578 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4580 Remove unnecessary casts.
4581 * xterm.c (x_term_init):
4582 * xfns.c (x_set_border_pixel):
4583 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4584 These aren't needed now that we assume ANSI C.
4586 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4587 It's more likely to cause problems (due to unsigned overflow)
4590 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4592 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4594 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4596 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4598 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4600 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4602 GLYPH_CODE_FACE returns EMACS_INT, not int.
4603 * dispextern.h (merge_faces):
4604 * xfaces.c (merge_faces):
4605 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4606 Don't assume EMACS_INT fits in int.
4608 * character.h (CHAR_VALID_P): Remove unused parameter.
4609 * fontset.c, lisp.h, xdisp.c: All uses changed.
4611 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4613 * fns.c (concat): Minor tuning based on overflow analysis.
4614 This doesn't fix any bugs. Use int to hold character, instead
4615 of constantly refetching from Emacs object. Use XFASTINT, not
4616 XINT, for value known to be a character. Don't bother comparing
4617 a single byte to 0400, as it's always less.
4619 * floatfns.c (Fexpt):
4620 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4622 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4625 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4627 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4628 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4629 incorrectly succeed when S was a string, because 4294967386 was
4630 truncated before it was used.
4632 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4633 Otherwise, an out-of-range integer could cause undefined behavior
4636 * composite.c: Use int, not EMACS_INT, for characters.
4637 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4638 EMACS_INT, for values that are known to be in character range.
4639 This doesn't fix any bugs but is the usual style inside Emacs and
4640 may generate better code on 32-bit machines.
4642 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4643 This is for reasons similar to the recent CHAR_STRING fix.
4644 * charset.c (Fencode_char): Check that character arg is actually
4645 a character. Pass an int to ENCODE_CHAR.
4646 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4647 wider than 'int', as a compile-time check to prevent future regressions
4650 * character.c (char_string): Remove unnecessary casts.
4652 Make sure a 64-bit char is never passed to CHAR_STRING.
4653 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4654 by silently ignoring the top 32 bits, allowing some values
4655 that were far too large to be valid characters.
4656 * character.h: Include <verify.h>.
4657 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4658 arguments are no wider than unsigned, as a compile-time check
4659 to prevent future regressions in this area.
4661 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4662 (Fsubst_char_in_region):
4664 * xdisp.c (decode_mode_spec_coding):
4665 Adjust to CHAR_STRING's new requirement.
4666 * editfns.c (Finsert_char, Fsubst_char_in_region):
4667 * fns.c (concat): Check that character args are actually
4668 characters. Without this test, these functions did the wrong
4669 thing with wildly out-of-range values on 64-bit hosts.
4671 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4672 These casts should not be needed on 32-bit hosts, either.
4673 * keyboard.c (read_char):
4674 * lread.c (Fload): Remove casts to unsigned.
4676 * lisp.h (UNSIGNED_CMP): New macro.
4677 This fixes comparison bugs on 64-bit hosts.
4678 (ASCII_CHAR_P): Use it.
4679 * casefiddle.c (casify_object):
4680 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4681 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4682 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4683 * dispextern.h (FACE_FROM_ID):
4684 * keyboard.c (read_char): Use UNSIGNED_CMP.
4686 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4687 not to EMACS_INT, to avoid GCC warning.
4689 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4691 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4692 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4693 isn't needed on 32-bit machines.
4695 * buffer.c (Fgenerate_new_buffer_name):
4696 Use EMACS_INT for count, not int.
4697 (advance_to_char_boundary): Return EMACS_INT, not int.
4699 * data.c (Qcompiled_function): Now static.
4701 * window.c (window_body_lines): Now static.
4703 * image.c (gif_load): Rename local to avoid shadowing.
4705 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4706 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4707 * alloc.c (make_save_value): Integer argument is now of type
4709 (mark_object): Use ptrdiff_t, not int.
4710 * lisp.h (pD): New macro.
4711 * print.c (print_object): Use it.
4713 * alloc.c: Use EMACS_INT, not int, to count objects.
4714 (total_conses, total_markers, total_symbols, total_vector_size)
4715 (total_free_conses, total_free_markers, total_free_symbols)
4716 (total_free_floats, total_floats, total_free_intervals)
4717 (total_intervals, total_strings, total_free_strings):
4718 Now EMACS_INT, not int. All uses changed.
4719 (Fgarbage_collect): Compute overall total using a double, so that
4720 integer overflow is less likely to be a problem. Check for overflow
4721 when converting back to an integer.
4722 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4723 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4724 These were 'int' variables that could overflow on 64-bit hosts;
4725 they were never used, so remove them instead of repairing them.
4726 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4727 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4728 Previously, this ceilinged at INT_MAX, but that doesn't work on
4730 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4732 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4733 (allocate_vectorlike): Check for ptrdiff_t overflow.
4734 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4735 when a (possibly-narrower) signed value would do just as well.
4736 We prefer using signed arithmetic, to avoid comparison confusion.
4738 * alloc.c: Catch some string size overflows that we were missing.
4739 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4740 for convenience in STRING_BYTES_MAX.
4741 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4742 The definition here is exact; the one in lisp.h was approximate.
4743 (allocate_string_data): Check for string overflow. This catches
4744 some instances we weren't catching before. Also, it catches
4745 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4746 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4747 and ptrdiff_t and EMACS_INT are both 64 bits.
4749 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4750 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4751 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4753 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4755 * alloc.c (Fmake_string): Check for out-of-range init.
4757 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4759 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4761 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4763 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4764 xg_get_default_scrollbar_width.
4766 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4767 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4768 (style_changed_cb): Call update_theme_scrollbar_width and call
4769 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4770 all frames (Bug#8505).
4771 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4772 Call gtk_window_set_resizable if HAVE_GTK3.
4773 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4774 and height if HAVE_GTK3 (Bug#8505).
4775 (scroll_bar_width_for_theme): New variable.
4776 (update_theme_scrollbar_width): New function.
4777 (xg_get_default_scrollbar_width): Move code to
4778 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4779 (xg_initialize): Call update_theme_scrollbar_width.
4781 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4783 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4785 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4787 * frame.c (make_frame): Call other_buffer_safely instead of
4790 * window.c (temp_output_buffer_show): Call display_buffer with
4791 second argument Vtemp_buffer_show_specifiers and reset latter
4792 immediately after the call.
4793 (Vtemp_buffer_show_specifiers): New variable.
4794 (auto_window_vscroll_p, next_screen_context_lines)
4795 (Vscroll_preserve_screen_position): Remove leading asterisks from
4798 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4800 Fix minor problems found by GCC 4.6.0 static checking.
4801 * buffer.c (Qclone_number): Remove for now, as it's unused.
4802 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4803 (record_buffer): Remove unused local.
4804 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4805 (set_frame_buffer_list): Remove; unused.
4806 * frame.h (other_visible_frames): Remove decl.
4807 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4808 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4809 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4811 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4812 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4813 Define only if HAVE_GPM.
4814 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4815 (update_hints_inhibit): Remove; never set. All uses removed.
4816 * widgetprv.h (emacsFrameClassRec): Remove decl.
4817 * window.c (delete_deletable_window): Now returns void, since it
4818 wasn't returning anything.
4819 (compare_window_configurations): Remove unused locals.
4820 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4821 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4822 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4823 the same widths as pointers. This follows up on the 2011-05-06 patch.
4824 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4825 * xterm.h: Likewise.
4826 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4828 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4830 * makefile.w32-in: Update dependencies.
4831 (LISP_H): Add lib/intprops.h.
4833 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4835 * image.c (gif_load): Add animation frame delay to the metadata.
4836 (syms_of_image): Use DEFSYM. New symbol `delay'.
4838 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4840 * window.c (delete_deletable_window): Re-add.
4841 (Fset_window_configuration): Rewrite to handle dead buffers and
4842 consequently deletable windows.
4843 (window_tree, Fwindow_tree): Remove. Supply functionality in
4845 (compare_window_configurations): Simplify code.
4847 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4849 * image.c (imagemagick_load_image): Fix type mismatch.
4850 (Fimagemagick_types): Likewise.
4852 * window.h (replace_buffer_in_windows): Declare.
4854 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4856 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4857 Qclone_number. Remove external declaration of Qdelete_window.
4858 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4860 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4861 Run Qbuffer_list_update_hook if allowed.
4862 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4863 buffer list implementation.
4864 (other_buffer_safely): New function.
4865 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4866 calls to replace_buffer_in_windows and
4867 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4869 (record_buffer): Inhibit quitting and rewrite using quittable
4870 functions. Run Qbuffer_list_update_hook if allowed.
4871 (Frecord_buffer, Funrecord_buffer): New functions.
4872 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4873 Move switch-to-buffer to window.el.
4874 (bury-buffer): Move to window.el.
4875 (Vbuffer_list_update_hook): New variable.
4877 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4880 * window.h (resize_frame_windows): Move up in code.
4881 (Fwindow_frame): Remove EXFUN.
4882 (replace_buffer_in_all_windows): Remove prototype.
4883 (replace_buffer_in_windows_safely): Add prototype.
4885 * window.c: Declare Qdelete_window static again. Move down
4886 declaration of select_count.
4887 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4888 (Fother_window): Move to window.el.
4889 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4890 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4891 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4893 (replace_buffer_in_windows): Implement by calling
4894 Qreplace_buffer_in_windows.
4895 (replace_buffer_in_all_windows): Remove with some functionality
4896 moved into replace_buffer_in_windows_safely.
4897 (replace_buffer_in_windows_safely): New function.
4898 (select_window_norecord, select_frame_norecord): Move in front
4899 of run_window_configuration_change_hook. Remove now obsolete
4901 (Fset_window_buffer): Rewrite doc-string.
4902 Call Qrecord_window_buffer.
4903 (keys_of_window): Move binding for other-window to window.el.
4905 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4907 * dispextern.h (struct image): Replace data member, whose int_val
4908 and ptr_val fields were not used by anything, with a single
4911 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4912 (gif_clear_image, gif_load, imagemagick_load_image)
4913 (gs_clear_image, gs_load): Callers changed.
4915 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4917 * buffer.h: Include <time.h>, for time_t.
4918 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4920 Fix minor problems found by static checking.
4922 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4924 Make identifiers static if they are not used in other modules.
4925 * data.c (Qcompiled_function, Qframe, Qvector):
4926 * image.c (QimageMagick, Qsvg):
4927 * minibuf.c (Qmetadata):
4928 * window.c (resize_window_check, resize_root_window): Now static.
4929 * window.h (resize_window_check, resize_root_window): Remove decls.
4931 * window.c (window_deletion_count, delete_deletable_window):
4933 (window_body_lines): Now static.
4934 (Fdelete_other_windows_internal): Mark vars as initialized.
4935 Make sure 'resize_failed' is initialized.
4936 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4937 (resize_window_apply): Remove unused local.
4938 * window.h (delete_deletable_window): Remove decl.
4940 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4941 (imagemagick_load_image): Fix pointer signedness problem by changing
4942 last arg from unsigned char * to char *. All uses changed.
4943 Also, fix a local for similar reasons.
4944 Remove unused locals. Remove locals to avoid shadowing.
4945 (fn_rsvg_handle_free): Remove; unused.
4946 (svg_load, svg_load_image): Fix pointer signedness problem.
4947 (imagemagick_load_image): Don't use garbage pointer image_wand.
4949 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4951 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4953 * image.c (gif_load): Fix omitted cast error introduced by
4956 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4958 * window.h (resize_proportionally, orig_total_lines)
4959 (orig_top_line): Remove from window structure.
4960 (set_window_height, set_window_width, change_window_heights)
4961 (Fdelete_window): Remove prototypes.
4962 (resize_frame_windows): Remove duplicate declaration.
4964 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4966 * window.h (resize_frame_windows, resize_window_check)
4967 (delete_deletable_window, resize_root_window)
4968 (resize_frame_windows): Declare prototypes.
4970 * window.c (resize_window_apply): Make definition be "static" to
4971 match the prototype.
4973 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4975 * window.c: Remove declarations of Qwindow_size_fixed,
4976 window_min_size_1, window_min_size_2, window_min_size,
4977 size_window, window_fixed_size_p, enlarge_window, delete_window.
4978 Remove static from declaration of Qdelete_window, it's
4979 temporarily needed by Fbury_buffer.
4980 (replace_window): Don't assign orig_top_line and
4982 (Fdelete_window, delete_window): Remove. Window deletion is
4983 handled by window.el.
4984 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4985 Replace Fdelete_window calls with calls to Qdelete_window.
4986 (Fdelete_other_windows): Remove. Deleting other windows is
4987 handled by window.el.
4988 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4989 handled in window.el.
4990 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4991 Window minimum sizes are handled in window.el.
4992 (shrink_windows, size_window, set_window_height)
4993 (set_window_width, change_window_heights, window_height)
4994 (window_width, CURBEG, CURSIZE, enlarge_window)
4995 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4996 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4997 handled in window.el.
4998 (make_dummy_parent): Rename to make_parent_window and give it a
4999 second argument horflag.
5000 (make_window): Don't set resize_proportionally any more.
5001 (Fsplit_window): Remove. Windows are split in window.el.
5002 (save_restore_action, save_restore_orig_size)
5003 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5004 Resize mini windows in window.el.
5005 (grow_mini_window, shrink_mini_window): Implement by calling
5006 Qresize_root_window_vertically, resize_window_check and
5007 resize_window_apply.
5008 (saved_window, Fset_window_configuration, save_window_save):
5009 Do not handle orig_top_line, orig_total_lines, and
5010 resize_proportionally.
5011 (window_min_height, window_min_width): Move to window.el.
5012 (keys_of_window): Move bindings for delete-other-windows,
5013 split-window, delete-window and enlarge-window to window.el.
5015 * buffer.c: Temporarily extern Qdelete_window.
5016 (Fbury_buffer): Temporarily call Qdelete_window instead of
5017 Fdelete_window (Fbury_buffer will move to window.el soon).
5019 * frame.c (set_menu_bar_lines_1): Remove code handling
5020 orig_top_line and orig_total_lines.
5022 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5023 set_window_height but set heights directly.
5024 (change_frame_size_1): Use resize_frame_windows.
5026 * xdisp.c (init_xdisp): Don't use set_window_height but set
5029 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5030 Use resize_frame_windows instead of change_window_heights and run
5031 run_window_configuration_change_hook.
5033 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5034 instead of change_window_heights and run
5035 run_window_configuration_change_hook.
5037 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5039 * window.c (replace_window): Rename second argument REPLACEMENT to
5040 NEW. New third argument SETFLAG. Rewrite.
5041 (delete_window, make_dummy_parent): Call replace_window with
5043 (window_list_1): Move down in code.
5044 (run_window_configuration_change_hook): Move set_buffer part
5045 before select_frame_norecord part in order to unwind correctly.
5046 Rename count1 to count.
5047 (recombine_windows, delete_deletable_window, resize_root_window)
5048 (Fdelete_other_windows_internal)
5049 (Frun_window_configuration_change_hook, make_parent_window)
5050 (resize_window_check, resize_window_apply, Fresize_window_apply)
5051 (resize_frame_windows, Fsplit_window_internal)
5052 (Fdelete_window_internal, Fresize_mini_window_internal):
5054 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5056 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5058 * window.h (window): Add some new members to window structure -
5059 normal_lines, normal_cols, new_total, new_normal, clone_number,
5060 splits, nest, prev_buffers, next_buffers.
5061 (WINDOW_TOTAL_SIZE): Move here from window.c.
5062 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5064 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5066 (make_dummy_parent): Set new members of windows structure.
5067 (make_window): Move down in code. Handle new members of window
5069 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5070 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5071 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5072 (Fset_window_prev_buffers, Fwindow_next_buffers)
5073 (Fset_window_next_buffers, Fset_window_clone_number):
5075 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5076 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5078 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5079 Argument WINDOW can be now internal window too.
5080 (Fwindow_use_time): Move up in code.
5081 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5083 (Fset_window_configuration, saved_window)
5084 (Fcurrent_window_configuration, save_window_save): Handle new
5085 members of window structure.
5086 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5087 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5088 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5089 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5090 Qget_mru_window, Qresize_root_window,
5091 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5092 Qauto_buffer_name; staticpro them.
5094 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5096 * window.c (Fwindow_total_size, Fwindow_left_column)
5097 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5098 (Fwindow_list_1): New functions.
5099 (window_box_text_cols): Replace with window_body_cols.
5100 (Fwindow_width, Fscroll_left, Fscroll_right):
5101 Use window_body_cols instead of window_box_text_cols.
5102 (delete_window, Fset_window_configuration):
5103 Call delete_all_subwindows with window as argument.
5104 (delete_all_subwindows): Take a window as argument and not a
5106 (window_loop): Remove handling of GET_LRU_WINDOW and
5108 (Fget_lru_window, Fget_largest_window): Move to window.el.
5110 * window.h: Extern window_body_cols instead of
5111 window_box_text_cols. delete_all_subwindows now takes a
5112 Lisp_Object as argument.
5114 * indent.c (compute_motion, Fcompute_motion):
5115 Use window_body_cols instead of window_box_text_cols.
5117 * frame.c (delete_frame): Call delete_all_subwindows with root
5120 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5122 * fns.c (Fputhash): Document return value.
5124 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5126 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5128 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5130 Cons<->int and similar integer overflow fixes (Bug#8794).
5132 Check for overflow when converting integer to cons and back.
5133 * charset.c (Fdefine_charset_internal, Fdecode_char):
5134 Use cons_to_unsigned to catch overflow.
5135 (Fencode_char): Use INTEGER_TO_CONS.
5136 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5137 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5138 * data.c (long_to_cons, cons_to_long): Remove.
5139 (cons_to_unsigned, cons_to_signed): New functions.
5140 These signal an error for invalid or out-of-range values.
5141 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5142 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5143 * font.c (Ffont_variation_glyphs):
5144 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5145 * lisp.h: Include <intprops.h>.
5146 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5147 (cons_to_signed, cons_to_unsigned): New decls.
5148 (long_to_cons, cons_to_long): Remove decls.
5149 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5150 (Fprimitive_undo): Use CONS_TO_INTEGER.
5151 * xfns.c (Fx_window_property): Likewise.
5152 * xselect.c: Include <limits.h>.
5153 (x_own_selection, selection_data_to_lisp_data):
5154 Use INTEGER_TO_CONS.
5155 (x_handle_selection_request, x_handle_selection_clear)
5156 (x_get_foreign_selection, Fx_disown_selection_internal)
5157 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5158 (lisp_data_to_selection_data): Use cons_to_unsigned.
5159 (x_fill_property_data): Use cons_to_signed.
5160 Report values out of range.
5162 Check for buffer and string overflow more precisely.
5163 * buffer.h (BUF_BYTES_MAX): New macro.
5164 * lisp.h (STRING_BYTES_MAX): New macro.
5165 * alloc.c (Fmake_string):
5166 * character.c (string_escape_byte8):
5167 * coding.c (coding_alloc_by_realloc):
5168 * doprnt.c (doprnt):
5169 * editfns.c (Fformat):
5171 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5172 since they may not be the same number.
5173 * editfns.c (Finsert_char):
5174 * fileio.c (Finsert_file_contents):
5175 Likewise for BUF_BYTES_MAX.
5177 * image.c: Use ptrdiff_t, not int, for sizes.
5178 (slurp_file): Switch from int to ptrdiff_t.
5180 (slurp_file): Check that file size fits in both size_t (for
5181 malloc) and ptrdiff_t (for sanity and safety).
5183 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5184 if b->modtime has its maximal value.
5186 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5188 Don't assume time_t can fit into int.
5189 * buffer.h (struct buffer.modtime): Now time_t, not int.
5190 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5191 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5193 Minor fixes for signed vs unsigned integers.
5194 * character.h (MAYBE_UNIFY_CHAR):
5195 * charset.c (maybe_unify_char):
5196 * keyboard.c (read_char, reorder_modifiers):
5197 XINT -> XFASTINT, since the integer must be nonnegative.
5198 * ftfont.c (ftfont_spec_pattern):
5199 * keymap.c (access_keymap, silly_event_symbol_error):
5200 XUINT -> XFASTINT, since the integer must be nonnegative.
5201 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5202 since it makes no difference and we prefer signed.
5203 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5204 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5207 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5209 * window.h (Fwindow_frame): Declare.
5211 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5213 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5214 (SPARE_MEMORY): Always define.
5215 (LARGE_REQUEST): Remove.
5216 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5218 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5220 * lisp.h: Move EXFUNS for Fframe_root_window,
5221 Fframe_first_window and Fset_frame_selected_window to window.h.
5223 * window.h: Move EXFUNS for Fframe_root_window,
5224 Fframe_first_window and Fset_frame_selected_window here from
5227 * frame.c (Fwindow_frame, Fframe_first_window)
5228 (Fframe_root_window, Fframe_selected_window)
5229 (Fset_frame_selected_window): Move to window.c.
5230 (Factive_minibuffer_window): Move to minibuf.c.
5231 (Fother_visible_frames_p): New function.
5233 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5235 * window.c (decode_window, decode_any_window): Move up in code.
5236 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5237 (inhibit_frame_unsplittable): Remove unused variable.
5238 (Fwindow_buffer): Move up and rewrite doc-string.
5239 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5240 (Fwindow_prev): New functions.
5241 (Fwindow_frame): Move here from frame.c. Accept any window as
5243 (Fframe_root_window, Fframe_first_window)
5244 (Fframe_selected_window): Move here from frame.c. Accept frame
5245 or arbitrary window as argument. Update doc-strings.
5246 (Fminibuffer_window): Move up in code.
5247 (Fwindow_minibuffer_p): Move up in code and simplify.
5248 (Fset_frame_selected_window): Move here from frame.c.
5250 (Fselected_window, select_window, Fselect_window): Move up in
5251 code. Minor doc-string fixes.
5253 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5255 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5256 Do not assume that spare memory exists; that assumption is valid
5257 only if SYSTEM_MALLOC.
5258 (LARGE_REQUEST): New macro, so that the issue of large requests
5259 is separated from the issue of spare memory.
5261 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5263 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5266 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5268 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5271 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5273 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5275 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5277 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5278 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5280 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5282 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5284 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5286 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5287 (x_clipboard_manager_save): Add return value.
5288 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5290 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5291 Obey Vx_select_enable_clipboard_manager. Catch errors in
5292 x_clipboard_manager_save (Bug#8779).
5293 (Vx_select_enable_clipboard_manager): New variable.
5294 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5296 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5298 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5300 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5302 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5303 in the current matrix if keep_current_p is non-zero.
5305 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5307 * bidi.c (bidi_level_of_next_char): Fix last change.
5309 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5311 Support bidi reordering of text covered by display properties.
5313 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5314 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5315 (bidi_cache_search, bidi_cache_iterator_state)
5316 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5317 (bidi_level_of_next_char, bidi_move_to_visually_next):
5318 Support character positions inside a run of characters covered by a
5320 (bidi_paragraph_init, bidi_resolve_explicit_1)
5321 (bidi_level_of_next_char): Call bidi_fetch_char and
5322 bidi_fetch_char_advance instead of FETCH_CHAR and
5324 (bidi_init_it): Initialize new members.
5325 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5327 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5328 instead of using explicit *_CHAR codes.
5329 (bidi_resolve_explicit, bidi_resolve_weak):
5330 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5331 bidirectional text is supported only in multibyte buffers.
5332 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5333 it to initialize the frame_window_p member of struct bidi_it.
5334 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5335 (bidi_resolve_explicit, bidi_resolve_weak)
5336 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5337 bidi_it->nchars is non-positive.
5338 (bidi_level_of_next_char): Don't try to lookup the cache for the
5339 next/previous character if nothing is cached there yet, or if we
5340 were just reseat()'ed to a new position.
5342 * xdisp.c (set_cursor_from_row): Set start and stop points
5343 according to the row's direction when priming the loop that looks
5344 for the glyph on which to display cursor.
5345 (single_display_spec_intangible_p): Function deleted.
5346 (display_prop_intangible_p): Reimplement to call
5347 handle_display_spec instead of single_display_spec_intangible_p.
5348 Accept 3 additional arguments needed by handle_display_spec.
5349 This fixes incorrect cursor motion across display property with complex
5350 values: lists, `(when COND...)' forms, etc.
5351 (single_display_spec_string_p): Support property values that are
5352 lists with the argument STRING its top-level element.
5353 (display_prop_string_p): Fix the condition for processing a
5354 property that is a list to be consistent with handle_display_spec.
5355 (handle_display_spec): New function, refactored from the
5356 last portion of handle_display_prop.
5357 (compute_display_string_pos): Accept additional argument
5358 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5359 value of a `display' property is a "replacing spec".
5360 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5361 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5362 the display property, but just return a value indicating whether
5363 the display property will replace the characters it covers.
5364 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5365 frame_window_p members of struct bidi_it.
5366 (compute_display_string_pos, compute_display_string_end):
5368 (push_it): Accept second argument POSITION, where pop_it should
5369 jump to continue iteration.
5370 (reseat_1): Initialize bidi_it.disp_pos.
5372 * keyboard.c (adjust_point_for_property): Adjust the call to
5373 display_prop_intangible_p to its new signature.
5375 * dispextern.h (struct bidi_it): New member frame_window_p.
5376 (bidi_init_it): Update prototypes.
5377 (display_prop_intangible_p): Update prototype.
5378 (compute_display_string_pos, compute_display_string_end):
5380 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5383 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5385 Malloc failure behavior now depends on size of allocation.
5386 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5387 * lisp.h: Change signatures accordingly.
5388 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5389 All callers changed. (Bug#8762)
5391 * gnutls.c: Use Emacs's memory allocators.
5392 Without this change, the gnutls library would invoke malloc etc.
5393 directly, which causes problems on non-SYNC_INPUT hosts, and which
5394 runs afoul of improving memory_full behavior. (Bug#8761)
5395 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5396 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5397 xfree instead of the default malloc, realloc, free.
5398 (Fgnutls_boot): No need to check for memory allocation failure,
5399 since xmalloc does that for us.
5401 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5402 * category.c (hash_get_category_set):
5403 * ccl.c (ccl_driver):
5404 * charset.c (Fdefine_charset_internal):
5405 * charset.h (struct charset.hash_index):
5406 * composite.c (get_composition_id, gstring_lookup_cache)
5407 (composition_gstring_put_cache):
5408 * composite.h (struct composition.hash_index):
5409 * dispextern.h (struct image.hash):
5410 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5411 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5412 (hashfn_equal, hashfn_user_defined, make_hash_table)
5413 (maybe_resize_hash_table, hash_lookup, hash_put)
5414 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5415 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5416 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5417 * image.c (make_image, search_image_cache, lookup_image)
5418 (xpm_put_color_table_h):
5419 * lisp.h (struct Lisp_Hash_Table):
5420 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5421 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5422 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5423 * alloc.c (allocate_vectorlike):
5424 Check for overflow in vector size calculations.
5425 * ccl.c (ccl_driver):
5426 Check for overflow when converting EMACS_INT to int.
5427 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5428 need to be updated by these changes.
5429 * fns.c (make_hash_table, maybe_resize_hash_table):
5430 Check for integer overflow with large hash tables.
5431 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5432 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5433 (SXHASH_REDUCE): New macro.
5434 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5435 Use it instead of discarding useful hash info with large hash values.
5436 (sxhash_float): New function.
5437 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5438 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5439 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5440 Rewrite to use FIXNUM_BITS, as this simplifies things.
5441 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5442 Adjust signatures to match updated version of code.
5443 (consing_since_gc): Now EMACS_INT, since a single hash table can
5444 use more than INT_MAX bytes.
5446 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5448 Make it possible to build with GCC-4.6+ -O2 -flto.
5450 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5452 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5454 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5455 Call minibuffer-inactive-mode.
5457 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5459 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5460 Update dependencies.
5462 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5464 * data.c (init_data): Remove code for UTS, this system is not
5467 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5469 Don't force ./temacs to start in terminal mode.
5471 * frame.c (make_initial_frame): Initialize faces in all cases, not
5472 only when CANNOT_DUMP is defined.
5473 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5475 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5477 * dispnew.c (add_window_display_history): Use const for the string
5478 pointer. Remove declaration, not needed.
5480 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5482 Use 'inline', not 'INLINE'.
5483 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5484 * alloc.c, fontset.c (INLINE): Remove.
5485 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5486 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5487 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5488 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5489 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5491 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5493 Make it possible to run ./temacs.
5495 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5496 syms_of_callproc does the same thing. Remove test for
5497 "initialized", do it in the caller.
5498 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5500 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5502 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5503 (read_minibuf): Use get_minibuffer.
5504 (syms_of_minibuf): Use DEFSYM.
5505 (Qmetadata): New var.
5506 * data.c (Qbuffer): Don't make it static.
5507 (syms_of_data): Use DEFSYM.
5509 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5511 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5512 (CCL_CODE_MIN): New macro.
5514 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5516 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5518 * eval.c (Qdebug): Now static.
5519 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5520 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5521 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5523 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5525 * image.c: Various fixes to ImageMagick code comments.
5526 (Fimagemagick_types): Doc fix.
5528 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5530 Minor fixes prompted by GCC 4.6.0 warnings.
5532 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5534 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5535 (x_clipboard_manager_save_all): Move extern decl to ...
5536 * xterm.h: ... here, so that it can be checked for consistency.
5538 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5540 * xselect.c (x_clipboard_manager_save_frame)
5541 (x_clipboard_manager_save_all): New functions.
5542 (Fx_clipboard_manager_save): Lisp function deleted.
5544 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5545 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5547 * xterm.h: Update prototype.
5549 2011-05-28 William Xu <william.xwl@gmail.com>
5551 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5554 2011-05-28 Jim Meyering <meyering@redhat.com>
5556 Avoid a sign-extension bug in crypto_hash_function.
5557 * fns.c (to_uchar): Define.
5558 (crypto_hash_function): Use it to convert some newly-signed
5559 variables to unsigned, to avoid sign-extension bugs. For example,
5560 without this change, (md5 "truc") would evaluate to
5561 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5562 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5563 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5565 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5567 Integer overflow fixes.
5569 * dbusbind.c: Serial number integer overflow fixes.
5570 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5571 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5572 to hold a serial number that is too large for a fixnum.
5573 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5574 Check for serial numbers out of range. Decode any serial number
5575 that was so large that it became a float. (Bug#8722)
5577 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5578 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5579 Use XFASTINT rather than XUINT when numbers are nonnegative.
5580 (xd_append_arg, Fdbus_method_return_internal):
5581 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5582 arguments, check that Lisp number is nonnegative, rather than
5583 silently wrapping negative numbers around. (Bug#8722)
5584 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5587 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5589 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5591 ccl: add integer overflow checks
5592 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5593 (IN_INT_RANGE): New macros.
5594 (ccl_driver): Use them to check for integer overflow when
5595 decoding a CCL program. Many of the new checks are whether XINT (x)
5596 fits in int; it doesn't always, on 64-bit hosts. The new version
5597 doesn't catch all possible integer overflows, but it's an
5598 improvement. (Bug#8719)
5600 * alloc.c (make_event_array): Use XINT, not XUINT.
5601 There's no need for unsigned here.
5603 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5604 This follows up to the 2011-05-06 change that substituted uintptr_t
5605 for EMACS_INT. This case wasn't caught back then.
5607 Rework Fformat to avoid integer overflow issues.
5608 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5609 now (part of C89). Include <verify.h>.
5610 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5611 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5612 (Fformat): Avoid the prepass trying to compute sizes; it was only
5613 approximate and thus did not catch overflow reliably. Instead, walk
5614 through the format just once, formatting and computing sizes as we go,
5615 checking for integer overflow at every step, and allocating a larger
5616 buffer as needed. Keep track separately whether the format is
5617 multibyte. Keep only the most-recently calculated precision, rather
5618 than them all. Record whether each argument has been converted to
5619 string. Use EMACS_INT, not int, for byte and char and arg counts.
5620 Support field widths and precisions larger than INT_MAX. Avoid
5621 sprintf's undefined behavior with conversion specifications such as %#d
5622 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5623 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5624 formatting out-of-range floating point numbers with int
5627 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5629 * data.c: Avoid integer truncation in expressions involving floats.
5630 * data.c: Include <intprops.h>.
5631 (arith_driver): When there's an integer overflow in an expression
5632 involving floating point, convert the integers to floating point
5633 so that the resulting value does not suffer from catastrophic
5634 integer truncation. For example, on a 64-bit host (* 4
5635 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5636 Do not rely on undefined behavior after integer overflow.
5638 merge count_size_as_multibyte, parse_str_to_multibyte
5639 * character.c, character.h (count_size_as_multibyte):
5640 Rename from parse_str_to_multibyte; all uses changed.
5641 Check for integer overflow.
5642 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5643 since it's now a duplicate of the other. This is more of
5644 a character than a buffer op, so better that it's in character.c.
5645 * fns.c, print.c: Adjust to above changes.
5647 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5649 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5651 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5653 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5654 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5655 (x_clipboard_manager_save): Now static.
5656 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5658 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5659 (crypto_hash_function): Now static.
5660 Fix pointer signedness problems. Avoid unnecessary initializations.
5662 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5664 * termhooks.h (Vselection_alist): Make it terminal-local.
5666 * terminal.c (create_terminal): Initialize it.
5668 * xselect.c: Support for clipboard managers.
5669 (Vselection_alist): Move to termhooks.h as terminal-local var.
5670 (LOCAL_SELECTION): New macro.
5671 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5672 (symbol_to_x_atom): Remove gratuitous arg.
5673 (x_handle_selection_request, lisp_data_to_selection_data)
5674 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5675 (x_own_selection, x_get_local_selection, x_convert_selection):
5676 New arg, specifying work frame. Use terminal-local Vselection_alist.
5677 (some_frame_on_display): Delete unused function.
5678 (Fx_own_selection_internal, Fx_get_selection_internal)
5679 (Fx_disown_selection_internal, Fx_selection_owner_p)
5680 (Fx_selection_exists_p): New optional frame arg.
5681 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5682 (x_handle_selection_clear): Don't treat other terminals with the
5683 same keyboard specially. Use the terminal-local Vselection_alist.
5684 (x_clear_frame_selections): Use Frun_hook_with_args.
5686 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5688 * xterm.h: Add support for those atoms.
5690 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5692 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5693 (converted_selections, conversion_fail_tag): New global variables.
5694 (x_selection_request_lisp_error): Free the above.
5695 (x_get_local_selection): Remove unnecessary code.
5696 (x_reply_selection_request): Args changed; handle arbitrary array
5697 of converted selections stored in converted_selections.
5698 Separate the XChangeProperty and SelectionNotify steps.
5699 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5700 (x_convert_selection): New function.
5701 (x_handle_selection_event): Simplify.
5702 (x_get_foreign_selection): Don't ignore incoming requests while
5703 waiting for an answer; this will fail when we implement
5704 SAVE_TARGETS, and seems unnecessary anyway.
5705 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5706 (Vx_sent_selection_functions): Doc fix.
5708 2011-05-26 Leo Liu <sdl.web@gmail.com>
5710 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5712 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5714 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5716 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5717 for fringe update if it has periodic bitmap.
5718 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5719 and fringe_bitmap_periodic_p.
5721 * fringe.c (get_fringe_bitmap_data): New function.
5722 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5723 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5724 row. Mark glyph row for fringe update if periodicity changed.
5726 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5727 for fringe update unless it has periodic bitmap.
5729 2011-05-25 Kenichi Handa <handa@m17n.org>
5731 * xdisp.c (get_next_display_element): Set correct it->face_id for
5732 a static composition.
5734 2011-05-24 Leo Liu <sdl.web@gmail.com>
5737 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5739 * fns.c (crypto_hash_function, Fsha1): New function.
5740 (Fmd5): Use crypto_hash_function.
5741 (syms_of_fns): Add Ssha1.
5743 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5745 * gnutls.c: Remove unused macros.
5746 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5747 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5748 Remove macros that are defined and never used.
5749 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5751 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5753 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5754 (Fx_get_selection_internal): Minor cleanup.
5755 (Fx_own_selection_internal): Rename arguments for consistency with
5758 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5760 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5762 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5764 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5766 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5768 * dispnew.c (scrolling_window): Don't exclude the case that the
5769 last enabled row in the desired matrix touches the bottom boundary.
5771 2011-05-21 Glenn Morris <rgm@gnu.org>
5773 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5774 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5775 and add some more files.
5777 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5779 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5780 report_file_error introduced by the change from 2011-05-07.
5782 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5784 * systime.h (Time): Define only if emacs is defined.
5785 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5786 where the include path doesn't have X11/X.h by default. See
5787 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5789 2011-05-20 Kenichi Handa <handa@m17n.org>
5791 * composite.c (find_automatic_composition): Fix previous change.
5793 2011-05-20 Glenn Morris <rgm@gnu.org>
5795 * lisp.mk: New file, split from Makefile.in.
5796 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5797 (shortlisp): Remove.
5798 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5800 2011-05-19 Glenn Morris <rgm@gnu.org>
5802 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5803 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5804 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5805 (lisp): Set the order to that of loadup.el.
5806 (shortlisp): Make it a copy of $lisp.
5807 (SOME_MACHINE_LISP): Remove.
5808 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5809 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5811 2011-05-18 Kenichi Handa <handa@m17n.org>
5813 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5814 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5815 (find_automatic_composition): Mostly rewrite for efficiency.
5817 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5819 * makefile.w32-in: Update dependencies.
5821 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5823 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5824 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5826 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5828 Fix some integer overflow issues, such as string length overflow.
5830 * insdel.c (count_size_as_multibyte): Check for string overflow.
5832 * character.c (lisp_string_width): Check for string overflow.
5833 Use EMACS_INT, not int, for string indexes and lengths; in
5834 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5835 the resulting string length overflows an EMACS_INT; instead,
5836 report a string overflow if no precision given. When checking for
5837 precision exhaustion, use a check that cannot possibly have
5838 integer overflow. (Bug#8675)
5839 * character.h (lisp_string_width): Adjust to new signature.
5841 * alloc.c (string_overflow): New function.
5842 (Fmake_string): Use it. This doesn't change behavior, but saves
5843 a few bytes and will simplify future changes.
5844 * character.c (string_escape_byte8): Likewise.
5845 * lisp.h (string_overflow): New decl.
5847 Fixups, following up to the user-interface timestamp change.
5848 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5849 for UI timestamps, instead of unsigned long.
5850 * msdos.c (mouse_get_pos): Likewise.
5851 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5852 * w32gui.h (Time): Define by including "systime.h" rather than by
5853 declaring it ourselves. (Bug#8664)
5855 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5856 * image.c (clear_image_cache): Likewise.
5858 * term.c (term_mouse_position): Don't assume time_t wraparound.
5860 Be more systematic about user-interface timestamps.
5861 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5862 and sometimes 'EMACS_UINT', to represent these timestamps.
5863 This change causes it to use 'Time' uniformly, as that's what X uses.
5864 This makes the code easier to follow, and makes it easier to catch
5865 integer overflow bugs such as Bug#8664.
5866 * frame.c (Fmouse_position, Fmouse_pixel_position):
5867 Use Time, not unsigned long, for user-interface timestamps.
5868 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5869 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5870 * keyboard.h (last_event_timestamp): Likewise.
5871 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5872 * menu.h (xmenu_show): Likewise.
5873 * term.c (term_mouse_position): Likewise.
5874 * termhooks.h (struct input_event.timestamp): Likewise.
5875 (struct terminal.mouse_position_hook): Likewise.
5876 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5877 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5878 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5879 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5881 * menu.h, termhooks.h: Include "systime.h", for Time.
5883 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5884 Don't assume that the difference between two unsigned long values
5885 can fit into an integer. At this point, we know button_down_time
5886 <= event->timestamp, so the difference must be nonnegative, so
5887 there's no need to cast the result if double-click-time is
5888 nonnegative, as it should be; check that it's nonnegative, just in
5889 case. This bug is triggered when events are more than 2**31 ms
5890 apart (about 25 days). (Bug#8664)
5892 * xselect.c (last_event_timestamp): Remove duplicate decl.
5893 (x_own_selection): Remove needless cast to unsigned long.
5895 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5896 that always fit in int. Use a sentinel instead of a counter, to
5897 avoid a temp and to allay GCC's concerns about possible int overflow.
5898 * frame.h (struct frame): Use int for menu_bar_items_used
5899 instead of EMACS_INT, since it always fits in int.
5901 * menu.c (grow_menu_items): Check for int overflow.
5903 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5905 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5906 Before, the code was not consistent. These values cannot exceed
5907 2**31 - 1 so there's no need to make them unsigned.
5908 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5909 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5910 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5912 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5914 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5915 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5916 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5917 presumably because the widths might not match.
5919 * window.c (size_window): Avoid needless test at loop start.
5921 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5923 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5925 2011-05-12 Drew Adams <drew.adams@oracle.com>
5927 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5929 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5931 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5932 `width' to `bar_area_x' and `bar_area_width', respectively.
5933 (x_scroll_run): Take account of fringe background extension.
5935 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5936 Rename local vars `left' and `width' to `bar_area_x' and
5937 `bar_area_width', respectively.
5938 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5939 background extension.
5941 2011-05-10 Jim Meyering <meyering@redhat.com>
5943 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5945 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5947 * image.c (Finit_image_library): Return t for built-in image types,
5948 like pbm and xbm. (Bug#8640)
5950 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5952 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5954 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5956 * w32console.c (Fset_screen_color): Doc fix.
5957 (Fget_screen_color): New function.
5958 (syms_of_ntterm): Defsubr it.
5960 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5961 unlink the temporary file if Fcall_process didn't create it in the
5963 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5964 child process will be redirected to a file specified with `:file'.
5965 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5966 cue to call_process_cleanup not to close that handle.
5968 2011-05-07 Ben Key <bkey76@gmail.com>
5970 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5971 one of two shell specific rules, either bootstrap-temacs-CMD or
5972 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5973 to the previous implementation of the bootstrap-temacs rule.
5974 The bootstrap-temacs-CMD rule is similar to the previous
5975 implementation of the bootstrap-temacs rule except that it
5976 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5979 These changes, along with some changes to nt/configure.bat,
5980 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5981 earlier fix to add support for --cflags and --ldflags options
5982 that include quotes so that it works whether make uses cmd or
5985 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5987 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5988 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5990 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5991 a string. Handle both cases.
5992 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5993 (Fdbus_register_method): Use Qinvalid_function.
5995 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5997 * makefile.w32-in: Update dependencies.
5998 (LISP_H): Add inttypes.h and stdin.h.
5999 (PROCESS_H): Add unistd.h.
6001 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6003 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6004 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6006 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6008 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6010 * term.c (vfatal): Remove stray call to va_end.
6011 It's not needed and the C Standard doesn't allow it here anyway.
6013 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6014 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6016 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6019 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6021 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6023 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6025 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6027 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6029 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6030 * charset.c (Fdefine_charset_internal): Don't initialize
6031 charset.code_space[15]. The value was garbage, on hosts with
6032 32-bit int (Bug#8600).
6034 * lread.c (read_integer): Be more consistent with string-to-number.
6035 Use string_to_number to do the actual conversion; this avoids
6036 rounding errors and fixes some other screwups. Without this fix,
6037 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6038 (digit_to_number): Move earlier, for benefit of read_integer.
6039 Return -1 if the digit is out of range for the base, -2 if it is
6040 not a digit in any supported base. (Bug#8602)
6042 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6044 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6045 to match comment at start of function. This also removes a
6046 GCC warning about overflow in a 32+64-bit port.
6048 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6050 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6051 Reported by Stefan Monnier in
6052 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6053 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6054 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6056 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6057 (EMACS_UINTPTR): Likewise, with uintptr_t.
6059 * lisp.h: Prefer 64-bit EMACS_INT if available.
6060 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6061 on 32-bit hosts that have 64-bit int, so that they can access
6063 However, temporarily disable this change unless the temporary
6064 symbol WIDE_EMACS_INT is defined.
6066 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6068 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6069 This removes an assumption that EMACS_INT and long are the same
6070 width as pointers. The assumption is true for Emacs porting targets
6071 now, but we want to make other targets possible.
6072 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6073 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6074 In the rest of the code, change types of integers that hold casted
6075 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6076 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6077 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6078 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6079 No need to cast type when ORing.
6080 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6081 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6082 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6083 assume EMACS_INT is the same width as char *.
6084 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6085 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6086 Remove no-longer-needed casts.
6087 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6088 (xg_tool_bar_help_callback, xg_make_tool_item):
6089 Use EMACS_INTPTR to hold an integer
6090 that will be cast to void *; this can avoid a GCC warning
6091 if EMACS_INT is not the same width as void *.
6092 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6093 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6094 (current_message_1, set_message_1):
6095 Use a local to convert to proper width without a cast.
6096 * xmenu.c (dialog_selection_callback): Likewise.
6098 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6099 Also, don't assume VALBITS / RAND_BITS is less than 5,
6100 and don't rely on undefined behavior when shifting a 1 left into
6102 * lisp.h (get_random): Change signature to match.
6104 * lread.c (hash_string): Use size_t, not int, for hash computation.
6105 Normally we prefer signed values; but hashing is special, because
6106 it's better to use unsigned division on hash table sizes so that
6107 the remainder is nonnegative. Also, size_t is the natural width
6108 for hashing into memory. The previous code used 'int', which doesn't
6109 retain enough info to hash well into very large tables.
6110 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6112 * dbusbind.c: Don't possibly lose pointer info when converting.
6113 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6114 Use XPNTR rather than XHASH, so that the high-order bits of
6115 the pointer aren't lost when converting through void *.
6117 * eval.c (Fautoload): Don't double-shift a pointer.
6119 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6121 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6123 * gnutls.c (DEF_GNUTLS_FN):
6124 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6126 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6128 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6131 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6133 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6134 New version that can reserve upto 2GB of heap space.
6136 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6138 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6140 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6142 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6143 `gnutls_certificate_set_x509_key_file'.
6145 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6147 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6148 Update dependencies.
6150 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6152 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6153 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6154 Remove unused parameter `fildes'.
6155 * process.c (read_process_output, send_process): Don't pass it.
6157 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6159 Fix previous change: the library cache is defined in w32.c.
6160 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6161 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6163 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6165 Implement dynamic loading of GnuTLS on Windows.
6167 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6168 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6169 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6172 * gnutls.c (Qgnutls_dll): Define.
6173 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6174 (gnutls_*): Declare function pointers.
6175 (init_gnutls_functions): New function to initialize function pointers.
6176 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6177 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6178 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6179 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6180 (emacs_gnutls_write, emacs_gnutls_read)
6181 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6182 (Fgnutls_available_p): New function.
6183 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6184 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6185 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6187 * image.c: Include w32.h.
6188 (Vimage_type_cache): Delete.
6189 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6190 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6191 (w32_delayed_load): Move to w32.c.
6193 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6195 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6196 (w32_delayed_load): Move from image.c. When loading a library, record
6197 its filename in the :loaded-from property of the library id.
6198 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6199 Initialize and staticpro them.
6200 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6202 * process.c: Include lisp.h before w32.h, not after.
6203 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6204 instead of gnutls_record_check_pending.
6206 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6208 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6210 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6211 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6214 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6216 * xterm.c (x_set_frame_alpha): Do not set property on anything
6217 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6219 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6221 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6223 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6225 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6226 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6227 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6228 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6229 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6230 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6231 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6232 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6233 (Qgnutls_bootprop_callbacks_verify): Make static.
6235 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6237 * callproc.c: Indentation fixup.
6239 * sysdep.c (wait_for_termination_1): Make static.
6240 (wait_for_termination, interruptible_wait_for_termination):
6241 Move after wait_for_termination_1.
6243 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6245 * sysdep.c (interruptible_wait_for_termination): New function
6246 which is like wait_for_termination, but allows keyboard
6249 * callproc.c (Fcall_process): Add (:file "file") as an option for
6251 (Fcall_process_region): Ditto.
6253 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6255 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6256 rather than `XVECTOR (FOO)->size'.
6258 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6259 inttypes.h, as a gnulib replacement is used if it not available in
6262 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6264 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6265 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6266 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6268 * coding.c (coding_alloc_by_realloc): Error out if destination
6269 will grow beyond MOST_POSITIVE_FIXNUM.
6270 (decode_coding_emacs_mule): Abort if there isn't enough place in
6271 charbuf for the composition carryover bytes. Reserve an extra
6272 space for up to 2 characters produced in a loop.
6273 (decode_coding_iso_2022): Abort if there isn't enough place in
6274 charbuf for the composition carryover bytes.
6276 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6278 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6279 aborting when %lld or %lll format is passed.
6280 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6281 %llo or %llx format is passed. (Bug#8545)
6283 * window.c (window_scroll_line_based): Use a marker instead of
6284 simple variables to record original value of point. (Bug#7952)
6286 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6287 produced by %s or %c overflows available buffer space. (Bug#8545)
6289 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6291 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6292 (SIZE_MAX): Move defn after all includes, as they might #define it.
6294 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6296 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6298 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6300 * keyboard.c (Qdelayed_warnings_hook): Define.
6301 (command_loop_1): Run `delayed-warnings-hook'
6302 if Vdelayed_warnings_list is non-nil.
6303 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6304 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6306 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6308 * doprnt.c (doprnt): Don't return value smaller than the buffer
6309 size if the message was truncated. (Bug#8545).
6311 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6313 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6314 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6316 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6318 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6320 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6322 * makefile.w32-in: Update dependencies.
6324 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6326 Improve `doprnt' and its usage. (Bug#8545)
6327 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6328 `format_end'. Remove support for %l as a conversion specifier.
6329 Don't use xrealloc. Improve diagnostics when the %l size modifier
6330 is used. Update the commentary.
6332 * eval.c (verror): Simplify calculation of size_t.
6334 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6337 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6339 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6342 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6344 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6345 This makes this file independent of the recent pseudovector change.
6347 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6349 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6351 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6352 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6353 Remove unused local.
6354 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6356 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6357 GCC 4.6.0 optimizes based on type-based alias analysis.
6358 For example, if b is of type struct buffer * and v of type struct
6359 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6360 != &v->size, and therefore "v->size = 1; b->size = 2; return
6361 v->size;" must therefore return 1. This assumption is incorrect
6362 for Emacs, since it type-puns struct Lisp_Vector * with many other
6363 types. To fix this problem, this patch adds a new type struct
6364 vectorlike_header that documents the constraints on layout of vectors
6365 and pseudovectors, and helps optimizing compilers not get fooled
6366 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6367 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6368 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6370 (XSETPVECTYPE): Rewrite in terms of new macro.
6371 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6372 This is a bit clearer, and further avoids the possibility of
6373 undesirable aliasing.
6374 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6375 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6376 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6377 since Lisp_Subr is a special case (no "next" field).
6378 (ASIZE): Now uses header.size rather than size.
6379 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6380 to avoid the hassle of writing XVECTOR (foo)->header.size.
6381 (struct vectorlike_header): New type.
6382 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6383 object, to help avoid aliasing.
6384 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6385 (SUBRP): Likewise, since Lisp_Subr is a special case.
6386 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6387 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6388 (struct Lisp_Hash_Table): Combine first two members into a single
6389 struct vectorlike_header member. All uses of "size" and "next" members
6390 changed to be "header.size" and "header.next".
6391 * buffer.h (struct buffer): Likewise.
6392 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6393 * frame.h (struct frame): Likewise.
6394 * process.h (struct Lisp_Process): Likewise.
6395 * termhooks.h (struct terminal): Likewise.
6396 * window.c (struct save_window_data, struct saved_window): Likewise.
6397 * window.h (struct window): Likewise.
6398 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6399 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6400 * buffer.c (init_buffer_once): Likewise.
6401 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6403 * process.c (Fformat_network_address): Use local var for size,
6406 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6408 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6409 * data.c (atof): Remove decl; no longer used or needed.
6410 (digit_to_number): Move to lread.c.
6411 (Fstring_to_number): Use new string_to_number function, to be
6412 consistent with how the Lisp reader treats infinities and NaNs.
6413 Do not assume that floating-point numbers represent EMACS_INT
6414 without losing information; this is not true on most 64-bit hosts.
6415 Avoid double-rounding errors, by insisting on integers when
6416 parsing non-base-10 numbers, as the documentation specifies.
6417 * lisp.h (string_to_number): New decl, replacing ...
6418 (isfloat_string): Remove.
6419 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6420 (read1): Do not accept +. and -. as integers; this
6421 appears to have been a coding error. Similarly, do not accept
6422 strings like +-1e0 as floating point numbers. Do not report
6423 overflow for integer overflows unless the base is not 10 which
6424 means we have no simple and reliable way to continue.
6425 Break out the floating-point parsing into a new
6426 function string_to_number, so that Fstring_to_number parses
6427 floating point numbers consistently with the Lisp reader.
6428 (digit_to_number): Move here from data.c. Make it static inline.
6429 (E_CHAR, EXP_INT): Remove, replacing with ...
6430 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6431 (string_to_number): New function, replacing isfloat_string.
6432 This function checks for valid syntax and produces the resulting
6433 Lisp float number too. Rework it so that string-to-number
6434 no longer mishandles examples like "1.0e+". Use strtoumax,
6435 so that overflow for non-base-10 numbers is reported only when
6436 there's no portable and simple way to convert to floating point.
6438 * textprop.c (set_text_properties_1): Rewrite for clarity,
6439 and to avoid GCC warning about integer overflow.
6441 * intervals.h (struct interval): Use EMACS_INT for members
6442 where EMACS_UINT might cause problems. See
6443 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6444 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6445 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6447 (offset_intervals): Tell GCC not to worry about length overflow
6448 when negating a negative length.
6450 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6451 (overrun_check_free): Likewise.
6453 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6454 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6457 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6458 (gnutls_make_error): Rename local to avoid shadowing.
6459 (gnutls_emacs_global_deinit): ifdef out; not used.
6460 (Fgnutls_boot): Use const for pointer to readonly storage.
6461 Comment out unused local. Fix pointer signedness problems.
6463 * lread.c (openp): Don't stuff size_t into an 'int'.
6464 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6465 about possible signed overflow.
6467 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6468 (GDK_KEY_g): Don't define if already defined.
6469 (xg_prepare_tooltip): Avoid pointer signedness problem.
6470 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6472 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6473 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6475 * xfns.c (Fx_window_property): Simplify a bit,
6476 to make a bit faster and to avoid GCC 4.6.0 warning.
6477 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6479 * fns.c (internal_equal): Don't assume size_t fits in int.
6481 * alloc.c (compact_small_strings): Tighten assertion a little.
6483 Replace pEd with more-general pI, and fix some printf arg casts.
6484 * lisp.h (pI): New macro, generalizing old pEd macro to other
6485 conversion specifiers. For example, use "...%"pI"d..." rather
6486 than "...%"pEd"...".
6487 (pEd): Remove. All uses replaced with similar uses of pI.
6488 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6489 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6490 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6491 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6492 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6493 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6494 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6496 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6497 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6498 * print.c (safe_debug_print, print_object): Likewise.
6499 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6501 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6502 avoiding the 0 flag, which is not portable.
6503 * process.c (Fmake_network_process): Use pI to avoid cast.
6504 * region-cache.c (pp_cache): Likewise.
6505 * xdisp.c (decode_mode_spec): Likewise.
6506 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6507 behavior on 64-bit hosts with printf arg.
6508 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6509 (x_stop_queuing_selection_requests): Likewise.
6510 (x_get_window_property): Don't truncate byte count to an 'int'
6513 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6514 here, since it parses constructs like leading '-' and spaces,
6515 which are not wanted; and it overflows with large numbers.
6516 Instead, simply match F[0-9]+, which is what is wanted anyway.
6518 * alloc.c: Remove unportable assumptions about struct layout.
6519 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6520 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6521 (allocate_vectorlike, make_pure_vector): Use the new macros,
6522 plus offsetof, to remove unportable assumptions about struct layout.
6523 These assumptions hold on all porting targets that I know of, but
6524 they are not guaranteed, they're easy to remove, and removing them
6525 makes further changes easier.
6527 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6528 This doesn't fix a bug but makes the code clearer.
6529 (string_overrun_cookie): Now const. Use initializers that
6530 don't formally overflow signed char, to avoid warnings.
6531 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6532 can cause Emacs to crash when string overrun checking is enabled.
6533 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6534 multiple of sizeof (EMACS_INT); it need not be, if
6535 alignof(EMACS_INT) < sizeof (EMACS_INT).
6536 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6538 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6540 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6542 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6544 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6545 supposed to be handshaking. (Bug#8556)
6546 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6548 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6550 * lisp.h (Qdebug): List symbol.
6551 * eval.c (Qdebug): Restore global linkage.
6552 * keyboard.c (debug-on-event): New variable.
6553 (handle_user_signal): Break into debugger when debug-on-event
6554 matches the current signal symbol.
6556 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6558 * alloc.c (check_sblock, check_string_bytes)
6559 (check_string_free_list): Convert to standard C.
6561 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6563 * w32.c (emacs_gnutls_push): Fix typo.
6565 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6567 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6568 "cast to pointer from integer of different size".
6570 Improve doprnt and its use in verror. (Bug#8545)
6571 * doprnt.c (doprnt): Document the set of format control sequences
6572 supported by the function. Use SAFE_ALLOCA instead of always
6575 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6576 is one byte too soon. Don't use xrealloc; instead xfree and
6579 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6581 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6584 * gnutls.c: Renamed global_initialized to
6585 gnutls_global_initialized. Added internals for the
6586 :verify-hostname-error, :verify-error, and :verify-flags
6587 parameters of `gnutls-boot' and documented those parameters in the
6588 docstring. Start callback support.
6589 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6590 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6591 on error. Return error code.
6592 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6593 (emacs_gnutls_read): Likewise.
6594 (Fgnutls_boot): Return handshake error code.
6595 (emacs_gnutls_handle_error): New function.
6596 (wsaerror_to_errno): Likewise.
6598 * w32.h (emacs_gnutls_pull): Add prototype.
6599 (emacs_gnutls_push): Likewise.
6601 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6602 (emacs_gnutls_push): Likewise.
6604 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6606 * process.c (wait_reading_process_output): Check if GnuTLS
6607 buffered some data internally if no FDs are set for TLS
6610 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6611 (LIBS): Link to USER_LIBS.
6612 ($(BLD)/gnutls.$(0)): New target.
6614 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6616 * xdisp.c (handle_single_display_spec): Rename the
6617 display_replaced_before_p argument into display_replaced_p, to
6618 make it consistent with the commentary. Fix typos in the
6621 * textprop.c (syms_of_textprop): Remove dead code.
6622 (copy_text_properties): Delete obsolete commentary about an
6623 interface that was deleted long ago. Fix typos in the description
6626 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6627 to changes in oldXMenu/XMenu.h from 2011-04-16.
6628 <menu_help_message, prev_menu_help_message>: Constify.
6629 (IT_menu_make_room): menu->help_text is now `const char **';
6632 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6633 to changes in oldXMenu/XMenu.h from 2011-04-16.
6634 (struct XMenu): Declare `help_text' `const char **'.
6636 * xfaces.c <Qunspecified>: Make extern again.
6638 * syntax.c: Include sys/types.h before including regex.h, as
6641 * doc.c (get_doc_string): Improve the format passed to `error'.
6643 * doprnt.c (doprnt): Improve commentary.
6645 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6647 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6650 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6651 changes in globals.h immediately force recompilation.
6652 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6653 $(CURDIR)/s/ms-w32.h.
6654 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6656 * character.c (Fchar_direction): Function deleted.
6657 (syms_of_character): Don't defsubr it.
6658 <char-direction-table>: Deleted.
6660 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6662 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6663 * doprnt.c: Include limits.h.
6664 (SIZE_MAX): New macro.
6665 (doprnt): Return a size_t value. 2nd arg is now size_t.
6666 Many local variables are now size_t instead of int or unsigned.
6667 Improve overflow protection. Support `l' modifier for integer
6668 conversions. Support %l conversion. Don't assume an EMACS_INT
6669 argument for integer conversions and for %c.
6671 * lisp.h (doprnt): Restore prototype.
6673 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6676 * Makefile.in (base_obj): Add back doprnt.o.
6678 * deps.mk (doprnt.o): Add back prerequisites.
6679 (callint.o): Depend on character.h.
6681 * eval.c (internal_lisp_condition_case): Include the handler
6682 representation in the error message.
6683 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6684 when breaking from the loop.
6686 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6688 * callint.c (Fcall_interactively): When displaying error message
6689 about invalid control letter, pass the character's codepoint, not
6690 a pointer to its multibyte form. Improve display of the character
6691 in octal and display also its hex code.
6693 * character.c (char_string): Use %x to display the (unsigned)
6694 codepoint of an invalid character, to avoid displaying a bogus
6697 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6698 `error', not SYMBOL_NAME itself.
6700 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6701 character arguments to `error'.
6703 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6704 to `error' in error message about FINAL_CHAR argument. Make sure
6705 FINAL_CHAR is a character, and use %c when it is passed as
6706 argument to `error'.
6708 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6710 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6712 * w32.c: Include <time.h>.
6713 (sys_localtime): New function.
6715 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6717 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6719 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6721 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6723 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6726 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6728 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6729 gl_state.e_property when gl_state.object is Qt.
6731 * insdel.c (make_gap_larger): Remove limitation of buffer size
6734 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6736 * xdisp.c (lookup_glyphless_char_display)
6737 (produce_glyphless_glyph): Handle cons cell entry in
6738 glyphless-char-display.
6739 (Vglyphless_char_display): Document it.
6741 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6742 glyphless-char-display.
6744 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6746 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6748 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6750 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6751 definition for no-X builds.
6753 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6755 Static checks with GCC 4.6.0 and non-default toolkits.
6757 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6759 * process.c (keyboard_bit_set): Define only if SIGIO.
6760 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6761 (send_process): Repair possible setjmp clobbering.
6763 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6765 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6767 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6769 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6770 Define only if needed.
6772 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6773 by pacifying GCC about it. Maybe it's time to retire it?
6774 * xfaces.c (USG, __TIMEVAL__): Likewise.
6776 * dispextern.h (struct redisplay_interface): Rename param
6778 * termhooks.h (struct terminal): Likewise.
6779 * xterm.c (xembed_send_message): Likewise.
6781 * insdel.c (make_gap_smaller): Define only if
6782 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6784 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6787 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6788 so that we aren't warned about unused symbols.
6790 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6792 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6794 * xfns.c (x_real_positions): Mark locals as initialized.
6796 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6798 * xterm.c: Fix problems found by static analysis with other toolkits.
6799 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6800 (x_dispatch_event): Declare static if USE_GTK, and
6801 define if USE_GTK || USE_X_TOOLKIT.
6802 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6803 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6804 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6805 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6807 * xmenu.c (menu_help_callback): Pointer type fixes.
6808 Use const pointers when pointing at readonly data. Avoid pointer
6810 (FALSE): Remove unused macro.
6811 (update_frame_menubar): Remove unused decl.
6813 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6815 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6816 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6817 (single_menu_item): Rename local to avoid shadowing.
6819 * keyboard.c (make_lispy_event): Remove unused local var.
6821 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6822 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6824 * bitmaps: Change bitmaps from unsigned char back to the X11
6825 compatible char. Avoid the old compiler warnings about
6826 out-of-range initializers by using, for example, '\xab' rather
6829 * xgselect.c (xgselect_initialize): Check vs interface
6830 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6832 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6834 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6835 to read-only memory.
6837 * fns.c (vector): Remove; this old hack is no longer needed.
6839 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6841 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6843 * xrdb.c (x_load_resources): Omit unused local.
6845 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6846 (x_window): Rename locals to avoid shadowing.
6847 (USG): Use the kludged USG macro, to pacify gcc.
6849 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6850 (x_term_init): Remove local to avoid shadowing.
6852 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6854 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6855 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6857 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6859 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6861 Fix regex.c, syntax.c and friends for buffers > 2GB.
6862 * syntax.h (struct gl_state_s): Declare character position members
6865 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6867 * textprop.c (verify_interval_modification, interval_of):
6868 Declare arguments EMACS_INT.
6870 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6873 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6875 * indent.c (Fvertical_motion): Local variable it_start is now
6878 * regex.c (re_match, re_match_2, re_match_2_internal)
6879 (bcmp_translate, regcomp, regexec, print_double_string)
6880 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6881 (re_compile_pattern, re_exec): Declare arguments and local
6882 variables `size_t' and `ssize_t' and return values `regoff_t', as
6884 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6885 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6886 <compile_stack_type>: `size' and `avail' are now `size_t'.
6888 * regex.h <regoff_t>: Use ssize_t, not int.
6889 (re_search, re_search_2, re_match, re_match_2): Arguments that
6890 specify buffer/string position and length are now ssize_t and
6891 size_t. Return type is regoff_t.
6893 2011-04-16 Ben Key <bkey76@gmail.com>
6895 * nsfont.m: Fixed bugs in ns_get_family and
6896 ns_descriptor_to_entity that were caused by using free to
6897 deallocate memory blocks that were allocated by xmalloc (via
6898 xstrdup). This caused Emacs to crash when compiled with
6899 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6900 --enable-checking=xmallocoverrun). xfree is now used to
6901 deallocate these memory blocks.
6903 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6905 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6907 emacs_write: Accept and return EMACS_INT for sizes.
6908 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6910 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6911 Accept and return EMACS_INT.
6912 (emacs_gnutls_write): Return the number of bytes written on
6914 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6915 (emacs_read, emacs_write): Remove check for negative size, as the
6916 Emacs source code has been audited now.
6917 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6918 (emacs_read, emacs_write): Use it.
6919 * process.c (send_process): Adjust to the new signatures of
6920 emacs_write and emacs_gnutls_write. Do not attempt to store
6921 a byte offset into an 'int'; it might overflow.
6922 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6924 * sound.c: Don't assume sizes fit in 'int'.
6925 (struct sound_device.period_size, alsa_period_size):
6926 Return EMACS_INT, not int.
6927 (struct sound_device.write, vox_write, alsa_write):
6928 Accept EMACS_INT, not int.
6929 (wav_play, au_play): Use EMACS_INT to store sizes and to
6930 record read return values.
6932 2011-04-15 Ben Key <bkey76@gmail.com>
6934 * keyboard.c (Qundefined): Don't declare static since it is used
6936 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6937 static since they are used in nsfont.m.
6939 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6941 * process.c (Qprocessp): Don't declare static.
6942 * lisp.h (Qprocessp): Declare again.
6944 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6946 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6948 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6950 Improve C-level modularity by making more things 'static'.
6952 Don't publish debugger-only interfaces to other modules.
6953 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6954 (verify_bytepos, count_markers): Move decls to the only modules
6956 * region-cache.h (pp_cache): Likewise.
6957 * window.h (check_all_windows): Likewise.
6958 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6960 * sysdep.c (croak): Now static, if
6961 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6962 * syssignal.h (croak): Declare only if not static.
6964 * alloc.c (refill_memory_reserve): Now static if
6965 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6966 * lisp.h (refill_memory_reserve): Declare only if not static.
6968 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6969 Define only if USE_LUCID.
6971 * xrdb.c (x_customization_string, x_rm_string): Now static.
6973 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6974 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6976 * xdisp.c (draw_row_with_mouse_face): Now static.
6977 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6979 * window.h (check_all_windows): Mark externally visible.
6981 * window.c (window_deletion_count): Now static.
6983 * undo.c: Make symbols static if they're not exported.
6984 (last_undo_buffer, last_boundary_position, pending_boundary):
6987 * textprop.c (interval_insert_behind_hooks): Now static.
6988 (interval_insert_in_front_hooks): Likewise.
6990 * term.c: Make symbols static if they're not exported.
6991 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6992 (max_frame_lines, tty_set_terminal_modes):
6993 (tty_reset_terminal_modes, tty_turn_off_highlight):
6994 (get_tty_terminal): Now static.
6995 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6996 * termhooks.h (term_mouse_moveto): Do not declare if
6998 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6999 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7001 * sysdep.c: Make symbols static if they're not exported.
7002 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7004 (sigprocmask_set, full_mask): Remove; unused.
7005 (wait_debugging): Mark as visible.
7006 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7007 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7009 * syntax.c (syntax_temp): Define only if !__GNUC__.
7011 * sound.c (current_sound_device, current_sound): Now static.
7013 * search.c (searchbufs, searchbuf_head): Now static.
7015 * scroll.c (scroll_cost): Remove; unused.
7016 * dispextern.h (scroll_cost): Remove decl.
7018 * region-cache.h (pp_cache): Mark as externally visible.
7020 * process.c: Make symbols static if they're not exported.
7021 (process_tick, update_tick, create_process, chan_process):
7022 (Vprocess_alist, proc_buffered_char, datagram_access):
7023 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7024 (deactivate_process): Mark defn as static, as well as decl.
7025 * lisp.h (create_process): Remove decl.
7026 * process.h (chan_process, Vprocess_alist): Remove decls.
7028 * print.c: Make symbols static if they're not exported.
7029 (print_depth, new_backquote_output, being_printed, print_buffer):
7030 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7031 (print_interval, print_number_index, initial_stderr_stream):
7033 * lisp.h (Fprinc): Remove decl.
7034 (debug_output_compilation_hack): Mark as externally visible.
7036 * sysdep.c (croak): Move decl from here to syssignal.h.
7037 * syssignal.h (croak): Put it here, so the API can be checked when
7038 'croak' is called from dissociate_if_controlling_tty.
7040 * minibuf.c: Make symbols static if they're not exported.
7041 (minibuf_save_list, choose_minibuf_frame): Now static.
7042 * lisp.h (choose_minibuf_frame): Remove decl.
7044 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7046 * lread.c: Make symbols static if they're not exported.
7047 (read_objects, initial_obarray, oblookup_last_bucket_number):
7049 (make_symbol): Remove; unused.
7050 * lisp.h (initial_obarray, make_symbol): Remove decls.
7052 * keyboard.c: Make symbols static if they're not exported.
7053 (single_kboard, recent_keys_index, total_keys, recent_keys):
7054 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7055 (this_single_command_key_start, echoing, last_auto_save):
7056 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7057 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7058 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7059 (Vlispy_mouse_stem, double_click_count):
7061 (force_auto_save_soon): Define only if SIGDANGER.
7062 (ignore_mouse_drag_p): Now static if
7063 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7064 (print_help): Remove; unused.
7065 (stop_character, last_timer_event): Mark as externally visible.
7066 * keyboard.h (ignore_mouse_drag_p): Declare only if
7067 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7068 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7069 * lisp.h (echoing): Remove decl.
7070 (force_auto_save_soon): Declare only if SIGDANGER.
7071 * xdisp.c (redisplay_window): Simplify code, to make it more
7072 obvious that ignore_mouse_drag_p is not accessed if !defined
7073 USE_GTK && !defined HAVE_NS.
7075 * intervals.c: Make symbols static if they're not exported.
7076 (merge_properties_sticky, merge_interval_right, delete_interval):
7078 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7080 * insdel.c: Make symbols static if they're not exported.
7081 However, leave prepare_to_modify_buffer alone. It's never
7082 called from outside this function, but that appears to be a bug.
7083 (combine_after_change_list, combine_after_change_buffer):
7084 (adjust_after_replace, signal_before_change): Now static.
7085 (adjust_after_replace_noundo): Remove; unused.
7086 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7087 (signal_before_change): Remove decls.
7089 * indent.c (val_compute_motion, val_vmotion): Now static.
7091 * image.c: Make symbols static if they're not exported.
7092 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7094 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7095 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7097 * fringe.c (standard_bitmaps): Now static.
7098 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7100 * frame.c: Make symbols static if they're not exported.
7101 (x_report_frame_params, make_terminal_frame): Now static.
7102 (get_frame_param): Now static, unless HAVE_NS.
7103 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7104 (x_get_resource_string): Remove; not used.
7105 * frame.h (make_terminal_frame, x_report_frame_params):
7106 (x_get_resource_string); Remove decls.
7107 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7108 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7110 * font.c, fontset.c: Make symbols static if they're not exported.
7111 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7112 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7113 * font.c (font_close_object): Now static.
7114 * font.h (font_close_object): Remove.
7115 * fontset.c (FONTSET_OBJLIST): Remove.
7116 (free_realized_fontset) #if-0 the body, which does nothing.
7117 (face_suitable_for_char_p): #if-0, as it's never called.
7118 * fontset.h (face_suitable_for_char_p): Remove decl.
7119 * xfaces.c (face_at_string_position):
7120 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7121 since 0 is always ASCII.
7123 * fns.c (weak_hash_tables): Now static.
7125 * fileio.c: Make symbols static if they're not exported.
7126 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7127 (Vwrite_region_annotation_buffers): Now static.
7129 * eval.c: Make symbols static if they're not exported.
7130 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7131 * lisp.h (backtrace_list): Remove decl.
7133 * emacs.c: Make symbols static if they're not exported.
7134 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7135 (fatal_error_code, fatal_error_signal_hook, standard_args):
7137 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7138 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7139 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7140 * lisp.h (fatal_error_signal_hook): Remove decl.
7141 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7143 * editfns.c: Move a (normally-unused) function to its only use.
7144 * editfns.c, lisp.h (get_operating_system_release): Remove.
7145 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7146 worth the hassle of breaking this out.
7148 * xterm.c: Make symbols static if they're not exported.
7149 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7150 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7151 (x_destroy_window, x_delete_display):
7153 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7154 (x_mouse_leave): Remove; unused.
7155 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7156 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7157 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7159 (x_mouse_leave): Declare only if WINDOWSNT.
7160 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7161 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7164 * ftxfont.c: Make symbols static if they're not exported.
7165 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7167 * font.h (ftxfont_driver): Likewise.
7169 * xfns.c: Make symbols static if they're not exported.
7170 (x_last_font_name, x_display_info_for_name):
7171 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7172 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7173 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7174 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7175 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7176 (last_show_tip_args): Now static.
7177 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7178 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7179 (x_screen_planes): Remove; unused.
7180 * dispextern.h (x_screen_planes): Remove decl.
7182 * dispnew.c: Make symbols static if they're not exported.
7183 * dispextern.h (redraw_garbaged_frames, scrolling):
7184 (increment_row_positions): Remove.
7185 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7186 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7188 (redraw_garbaged_frames): Remove; unused.
7190 * xfaces.c: Make symbols static if they're not exported.
7191 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7193 * xterm.h (defined_color): Remove decls.
7194 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7195 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7196 (menu_face_changed_default, defined_color, free_realized_face):
7197 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7198 (ascii_face_of_lisp_face): Remove; unused.
7200 * xdisp.c: Make symbols static if they're not exported.
7201 * dispextern.h (scratch_glyph_row, window_box_edges):
7202 (glyph_to_pixel_coords, set_cursor_from_row):
7203 (get_next_display_element, set_iterator_to_next):
7204 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7205 (show_mouse_face): Remove decls
7206 * frame.h (message_buf_print): Likewise.
7207 * lisp.h (pop_message, set_message, check_point_in_composition):
7209 * xterm.h (set_vertical_scroll_bar): Likewise.
7210 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7211 (message_buf_print, scratch_glyph_row, displayed_buffer):
7212 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7213 (get_next_display_element, show_mouse_face, window_box_edges):
7214 (frame_to_window_pixel_xy, check_point_in_composition):
7215 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7216 (glyph_to_pixel_coords): Remove; unused.
7218 * dired.c (file_name_completion): Now static.
7220 * dbusbind.c (xd_in_read_queued_messages): Now static.
7222 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7223 * data.c (circular_list_error): Remove.
7225 * commands.h (last_point_position, last_point_position_buffer):
7226 (last_point_position_window): Remove decls.
7227 * keyboard.c: Make these variables static.
7229 * coding.h (coding, code_convert_region, encode_coding_gap):
7231 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7232 (iso_code_class, detect_coding, code_convert_region): Now static.
7233 (encode_coding_gap): Remove; unused.
7235 * chartab.c (chartab_chars, chartab_bits): Now static.
7237 * charset.h (charset_iso_8859_1): Remove decl.
7238 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7241 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7242 * ccl.c (Vccl_program_table): Now static.
7243 (check_ccl_update): Remove; unused.
7245 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7246 * category.h: ... from here.
7247 * category.c (check_category_table, set_category_set): Now static.
7249 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7250 * lisp.h: Remove these decls.
7252 * buffer.c (buffer_count): Remove unused var.
7254 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7255 so that it's not optimized away.
7256 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7257 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7258 exported only to the debugger.
7260 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7261 * atimer.h (run_all_atimers): Remove; not exported.
7263 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7264 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7265 was inaccessible from Lisp.
7266 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7267 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7269 alloc.c: Import and export fewer symbols, and remove unused items.
7270 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7272 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7273 it's not optimized away by whole-program optimization.
7274 (message_enable_multibyte, free_misc): Remove.
7275 (catchlist, handlerlist, mark_backtrace):
7276 Declare only if BYTE_MARK_STACK.
7277 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7278 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7279 (message_enable_multibyte): Remove decl.
7280 (free_misc, interval_free_list, float_block, float_block_index):
7281 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7282 (cons_free_list, last_marked_index):
7284 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7285 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7286 (mark_backtrace): Define only if BYTE_MARK_STACK.
7287 * xdisp.c (message_enable_multibyte): Now static.
7289 Declare Lisp_Object Q* variables to be 'static' if not exported.
7290 This makes it easier for human readers (and static analyzers)
7291 to see whether these variables are used from other modules.
7292 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7293 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7294 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7295 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7296 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7297 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7298 * xmenu.c, xselect.c:
7299 Declare Q* vars static if they are not used in other modules.
7300 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7301 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7302 Remove decls of unexported vars.
7303 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7305 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7307 Make Emacs functions such as Fatom 'static' by default.
7308 This makes it easier for human readers (and static analyzers)
7309 to see whether these functions can be called from other modules.
7310 DEFUN now defines a static function. To make the function external
7311 so that it can be used in other C modules, use the new macro DEFUE.
7312 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7313 (Finit_image_library):
7314 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7315 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7316 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7317 Remove decls, since these functions are now static.
7318 (Funintern, Fget_internal_run_time): New decls, since these functions
7319 were already external.
7321 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7322 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7323 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7324 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7325 * keyboard.c, keymap.c, lread.c:
7326 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7327 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7328 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7329 Mark functions with DEFUE instead of DEFUN,
7330 if they are used in other modules.
7331 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7332 decls for now-static functions.
7333 * buffer.h (Fdelete_overlay): Remove decl.
7334 * callproc.c (Fgetenv_internal): Mark as internal.
7335 * composite.c (Fremove_list_of_text_properties): Remove decl.
7336 (Fcomposition_get_gstring): New forward static decl.
7337 * composite.h (Fcomposite_get_gstring): Remove decl.
7338 * dired.c (Ffile_attributes): New forward static decl.
7339 * doc.c (Fdocumntation_property): New forward static decl.
7340 * eval.c (Ffetch_bytecode): New forward static decl.
7341 (Funintern): Remove extern decl; now in .h file where it belongs.
7342 * fileio.c (Fmake_symbolic_link): New forward static decl.
7343 * image.c (Finit_image_library): New forward static decl.
7344 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7345 * intervals.h (Fprevious_property_change):
7346 (Fremove_list_of_text_properties): Remove decls.
7347 * keyboard.c (Fthis_command_keys): Remove decl.
7348 (Fcommand_execute): New forward static decl.
7349 * keymap.c (Flookup_key): New forward static decl.
7350 (Fcopy_keymap): Now static.
7351 * keymap.h (Flookup_key): Remove decl.
7352 * process.c (Fget_process): New forward static decl.
7353 (Fprocess_datagram_address): Mark as internal.
7354 * syntax.c (Fsyntax_table_p): New forward static decl.
7355 (skip_chars): Remove duplicate decl.
7356 * textprop.c (Fprevious_property_change): New forward static decl.
7357 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7359 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7360 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7362 * editfns.c (Fformat): Remove unreachable code.
7364 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7366 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7369 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7371 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7372 when at ZV. (Bug#8487)
7374 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7376 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7378 * keyboard.c (parse_tool_bar_item): Likewise.
7379 * sound.c (sound_cleanup, alsa_close): Likewise.
7380 * termcap.c (tgetent): Likewise.
7381 * xfns.c (x_default_font_parameter): Likewise.
7382 * xsettings.c (read_and_apply_settings): Likewise.
7384 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7385 (overrun_check_free): Protoize.
7387 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7389 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7390 since callers should never pass a negative size.
7391 Change the signature to match that of plain 'read' and 'write'; see
7392 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7393 * lisp.h: Update prototypes of emacs_write and emacs_read.
7395 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7397 * xdisp.c (redisplay_window): Don't try to determine the character
7398 position of the scroll margin if the window start point w->startp
7399 is outside the buffer's accessible region. (Bug#8468)
7401 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7403 Fix write-region and its subroutines for buffers > 2GB.
7404 * fileio.c (a_write, e_write): Modify declaration of arguments and
7405 local variables to support buffers larger than 2GB.
7406 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7408 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7409 argument, local variables, and return value.
7411 * lisp.h: Update prototypes of emacs_write and emacs_read.
7413 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7415 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7417 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7419 Fix more problems found by GCC 4.6.0's static checks.
7421 * xdisp.c (vmessage): Use a better test for character truncation.
7423 * charset.c (load_charset_map): <, not <=, for optimization,
7424 and to avoid potential problems with integer overflow.
7425 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7426 * casetab.c (set_identity, shuffle): Likewise.
7427 * editfns.c (Fformat): Likewise.
7428 * syntax.c (skip_chars): Likewise.
7430 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7431 This also lets GCC 4.6.0 generate slightly better loop code.
7433 * callint.c (Fcall_interactively): <, not <=, for optimization.
7434 (Fcall_interactively): Count the number of arguments produced,
7435 not the number of arguments given. This is simpler and lets GCC
7436 4.6.0 generate slightly better code.
7438 * ftfont.c: Distingish more carefully between FcChar8 and char.
7439 The previous code passed unsigned char * to a functions like
7440 strlen and xstrcasecmp that expect char *, which does not
7441 conform to the C standard.
7442 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7443 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7444 char * when the C standard requires it.
7446 * keyboard.c (read_char): Remove unused var.
7448 * eval.c: Port to Windows vsnprintf (Bug#8435).
7450 (SIZE_MAX): Define if the headers do not.
7451 (verror): Do not give up if vsnprintf returns a negative count.
7452 Instead, grow the buffer. This ports to Windows vsnprintf, which
7453 does not conform to C99. Problem reported by Eli Zaretskii.
7454 Also, simplify the allocation scheme, by avoiding the need for
7455 calling realloc, and removing the ALLOCATED variable.
7457 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7459 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7460 But keep the doprint source code for now, as we might revamp it
7461 and use it again (Bug#8435).
7462 * lisp.h (doprnt): Remove.
7463 * Makefile.in (base_obj): Remove doprnt.o.
7464 * deps.mk (doprnt.o): Remove.
7466 error: Print 32- and 64-bit integers portably (Bug#8435).
7467 Without this change, on typical 64-bit hosts error ("...%d...", N)
7468 was used to print both 32- and 64-bit integers N, which relied on
7470 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7472 * lisp.h (error, verror): Mark as printf-like functions.
7473 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7474 Report overflow in size calculations when allocating printf buffer.
7475 Do not truncate output string at its first null byte.
7476 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7477 Truncate the output at a character boundary, since vsnprintf does not
7479 * charset.c (check_iso_charset_parameter): Convert internal
7480 character to string before calling 'error', since %c now has the
7482 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7483 overflow when computing char to be passed to 'error'. Do not
7484 pass Lisp_Object to 'error'; pass the integer instead.
7485 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7486 formatted with plain %d.
7488 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7490 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7492 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7494 * xterm.c (x_catch_errors): Remove duplicate declaration.
7496 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7498 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7500 2011-04-10 Jim Meyering <meyering@redhat.com>
7502 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7503 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7504 return ssize_t not "int", and use size_t as the buffer length.
7505 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7506 * gnutls.h: Update declarations.
7507 * process.c (read_process_output): Use ssize_t, to match.
7508 (send_process): Likewise.
7510 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7512 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7514 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7516 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7517 Use unsigned char, to match FcChar8 type definition.
7519 * xterm.c (handle_one_xevent):
7520 * xmenu.c (create_and_show_popup_menu):
7521 * xselect.c (x_decline_selection_request)
7522 (x_reply_selection_request): Avoid type-punned deref of X events.
7524 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7526 Fix some uses of `int' instead of EMACS_INT.
7527 * search.c (string_match_1, fast_string_match)
7528 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7529 (scan_buffer, find_next_newline_no_quit)
7530 (find_before_next_newline, search_command, Freplace_match)
7531 (Fmatch_data): Make some `int' variables be EMACS_INT.
7533 * xdisp.c (display_count_lines): 3rd argument and return value now
7534 EMACS_INT. All callers changed.
7535 (pint2hrstr): Last argument is now EMACS_INT.
7537 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7538 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7539 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7540 (decode_coding_utf_16, decode_coding_emacs_mule)
7541 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7542 (decode_coding_ccl, decode_coding_charset)
7543 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7544 (decode_coding_iso_2022, decode_coding_emacs_mule)
7545 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7546 <char_offset, last_offset>: Declare EMACS_INT.
7547 (encode_coding_utf_8, encode_coding_utf_16)
7548 (encode_coding_emacs_mule, encode_invocation_designation)
7549 (encode_designation_at_bol, encode_coding_iso_2022)
7550 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7551 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7553 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7554 (encode_invocation_designation): Last argument P_NCHARS is now
7556 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7557 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7559 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7562 * ccl.c (Fccl_execute_on_string): Declare some variables
7565 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7567 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7569 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7571 * process.c (Fformat_network_address): Doc fix.
7573 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7575 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7577 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7579 * keyboard.c (read_char): Call Lisp function help-form-show,
7580 instead of using internal_with_output_to_temp_buffer.
7581 (Qhelp_form_show): New var.
7582 (syms_of_keyboard): Use DEFSYM macro.
7584 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7586 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7588 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7590 * process.c (Flist_processes): Remove to Lisp.
7591 (list_processes_1): Delete.
7593 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7595 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7597 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7599 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7601 Fix more problems found by GCC 4.6.0's static checks.
7603 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7605 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7607 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7609 * xdisp.c (vmessage): Mark as a printf-like function.
7611 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7613 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7615 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7616 printf-like functions.
7617 (tiff_load): Add casts to remove these marks before passing them
7618 to system-supplied API.
7620 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7622 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7623 This avoids several warnings with gcc -Wstrict-overflow.
7624 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7625 directly, rather than having caller test rule sign. This avoids
7626 some unnecessary tests.
7627 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7628 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7629 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7631 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7632 (xfont_open): Avoid unnecessary tests.
7634 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7636 * composite.h, composite.c (composition_gstring_put_cache):
7637 Use EMACS_INT, not int, for length.
7639 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7640 breaking out part of COMPOSITION_DECODE_RULE.
7641 (COMPOSITION_DECODE_RULE): Use it.
7642 * composite.c (get_composition_id): Remove unused local vars,
7643 by using the new macro.
7645 * textprop.c (set_text_properties_1): Change while to do-while,
7646 since the condition is always true at first.
7648 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7649 (interval_deletion_adjustment): Return unsigned value.
7652 * process.c (list_processes_1, create_pty, read_process_output):
7653 (exec_sentinel): Remove vars that were set but not used.
7654 (create_pty): Remove unnecessary "volatile"s.
7655 (Fnetwork_interface_info): Avoid possibility of int overflow.
7656 (read_process_output): Do adaptive read buffering even if carryover.
7657 (read_process_output): Simplify nbytes computation if buffered.
7659 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7661 * syntax.c (scan_words): Remove var that was set but not used.
7662 (update_syntax_table): Use unsigned instead of int.
7664 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7665 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7666 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7668 * print.c (print_error_message): Avoid int overflow.
7670 * font.c (font_list_entities): Redo for clarity,
7671 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7673 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7674 (font_score): Avoid potential overflow in diff calculation.
7676 * fns.c (substring_both): Remove var that is set but not used.
7677 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7679 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7681 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7682 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7683 can always succeed if overflow has undefined behavior.
7685 * search.c (boyer_moore, wordify): Remove vars set but not used.
7686 (wordify): Omit three unnecessary tests.
7688 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7689 All callers changed. This avoids the need for an unused var.
7691 * casefiddle.c (casify_region): Remove var that is set but not used.
7693 * dired.c (file_name_completion): Remove var that is set but not used.
7695 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7697 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7698 (Finsert_file_contents): Remove unnecessary code checking fd.
7700 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7701 Check for integer overflow on size calculations.
7703 * buffer.c (Fprevious_overlay_change): Remove var that is set
7706 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7707 Remove vars that are set but not used.
7708 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7709 (timer_check_2): Mark vars as initialized.
7711 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7713 * image.c (lookup_image): Remove var that is set but not used.
7714 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7716 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7717 that are set but not used.
7719 * xfns.c (make_invisible_cursor): Don't return garbage
7720 if XCreateBitmapFromData fails (Bug#8410).
7722 * xselect.c (x_get_local_selection, x_handle_property_notify):
7723 Remove vars that are set but not used.
7725 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7726 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7728 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7729 Remove var that is set but not used.
7730 (scroll_bar_windows_size): Now size_t, not int.
7731 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7734 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7735 (map_tty_color) [!defined MSDOS]: Likewise.
7737 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7739 * coding.c: Remove vars that are set but not used.
7740 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7741 All callers changed.
7742 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7743 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7744 (decode_coding_charset): Remove vars that are set but not used.
7746 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7747 that is set but not used.
7749 * print.c (print_object): Remove var that is set but not used.
7751 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7752 The gnulib version avoids calling malloc in the usual case,
7753 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7754 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7755 * filelock.c (current_lock_owner): Likewise.
7756 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7757 * sysdep.c: Include allocator.h, careadlinkat.h.
7758 (emacs_no_realloc_allocator): New static constant.
7759 (emacs_readlink): New function.
7760 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7761 ../lib/careadlinkat.h.
7763 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7765 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7766 first non-nil return value).
7768 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7770 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7771 if not defined (Bug#8403).
7773 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7775 * xdisp.c (display_count_lines): Remove parameter `start',
7776 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7777 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7778 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7779 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7780 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7781 and thereabouts. All callers changed.
7782 (get_per_char_metric): Remove parameter `f', unused since
7783 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7785 2011-04-02 Jim Meyering <meyering@redhat.com>
7787 do not dereference NULL upon failed strdup
7788 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7789 (ns_get_family): Likewise.
7791 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7793 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7795 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7797 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7800 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7802 Add lexical binding.
7804 * window.c (Ftemp_output_buffer_show): New fun.
7805 (Fsave_window_excursion):
7806 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7808 * lread.c (lisp_file_lexically_bound_p): New function.
7809 (Fload): Bind Qlexical_binding.
7810 (readevalloop): Remove `evalfun' arg.
7811 Bind Qinternal_interpreter_environment.
7812 (Feval_buffer): Bind Qlexical_binding.
7813 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7815 (syms_of_lread): Declare `lexical-binding'.
7817 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7819 * keyboard.c (eval_dyn): New fun.
7820 (menu_item_eval_property): Use it.
7822 * image.c (parse_image_spec): Use Ffunctionp.
7824 * fns.c (concat, mapcar1): Accept byte-code-functions.
7826 * eval.c (Fsetq): Handle lexical vars.
7827 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7828 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7829 (FletX, Flet): Obey lexical binding.
7830 (Fcommandp): Handle closures.
7831 (Feval): New `lexical' arg.
7832 (eval_sub): New function extracted from Feval. Use it almost
7833 everywhere where Feval was used. Look up vars in lexical env.
7835 (Ffunctionp): Move from subr.el.
7836 (Ffuncall): Handle closures.
7837 (apply_lambda): Remove `eval_flags'.
7838 (funcall_lambda): Handle closures and new byte-code-functions.
7839 (Fspecial_variable_p): New function.
7840 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7841 but without exporting it to Lisp.
7843 * doc.c (Fdocumentation, store_function_docstring):
7844 * data.c (Finteractive_form): Handle closures.
7846 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7849 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7851 (exec_byte_code): New function extracted from Fbyte_code to handle new
7852 calling convention for byte-code-functions. Add new byte-codes.
7854 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7856 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7858 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7860 * xdisp.c (redisplay_internal): Fix prototype.
7862 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7864 * xdisp.c (SCROLL_LIMIT): New macro.
7865 (try_scrolling): Use it when setting scroll_limit.
7866 Limit scrolling to 100 screen lines.
7867 (redisplay_window): Even when falling back on "recentering",
7868 position point in the window according to scroll-conservatively,
7869 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7871 (try_scrolling): When point is above the window, allow searching
7872 as far as scroll_max, or one screenful, to compute vertical
7873 distance from PT to the scroll margin position. This prevents
7874 try_scrolling from unnecessarily failing when
7875 scroll-conservatively is set to a value slightly larger than the
7876 window height. Clean up the case of PT below the margin at bottom
7877 of window: scroll_max can no longer be INT_MAX. When aggressive
7878 scrolling is in use, don't let point enter the opposite scroll
7879 margin as result of the scroll.
7880 (syms_of_xdisp) <scroll-conservatively>: Document the
7881 threshold of 100 lines for never-recentering scrolling.
7883 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7885 * dispextern.h (move_it_by_lines):
7886 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7887 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7888 (message_log_check_duplicate): Remove parameters `prev_bol' and
7889 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7890 (redisplay_internal): Remove parameter `preserve_echo_area',
7891 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7893 * indent.c (Fvertical_motion):
7894 * window.c (window_scroll_pixel_based, Frecenter):
7895 Don't pass `need_y_p' to `move_it_by_lines'.
7897 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7899 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7900 steal a few bits to be more compact.
7901 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7902 Remove unneeded casts.
7904 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7906 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7908 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7909 binding" message (bug#7967).
7911 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7913 Fix more problems found by GCC 4.6.0's static checks.
7915 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7916 Remove unused local var.
7918 * editfns.c (Fmessage_box): Remove unused local var.
7920 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7921 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7922 Omit unused local vars.
7923 * window.c (shrink_windows): Omit unused local var.
7924 * menu.c (digest_single_submenu): Omit unused local var.
7925 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7926 Omit unused local var.
7928 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7929 Don't assume string length fits in int.
7930 (keyremap_step, read_key_sequence): Use size_t for sizes.
7931 (read_key_sequence): Don't check last_real_key_start redundantly.
7933 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7934 instead of alloca (Bug#8344).
7936 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7937 (Fbacktrace_frame): Don't assume nframes fits in int.
7939 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7941 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7944 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7946 * cm.c (calccost): Turn while-do into do-while, for clarity.
7948 * keyboard.c (syms_of_keyboard): Use the same style as later
7949 in this function when indexing through an array. This also
7950 works around GCC bug 48267.
7952 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7954 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7956 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7957 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7959 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7960 This avoids undefined behavior on integer overflow, and is a bit
7961 more convenient anyway since it is compared to a size_t variable.
7963 Variadic C functions now count arguments with size_t, not int.
7964 This avoids an unnecessary limitation on 64-bit machines, which
7965 caused (substring ...) to crash on large vectors (Bug#8344).
7966 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7967 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7968 All variadic functions and their callers changed accordingly.
7969 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7970 * data.c (arith_driver, float_arith_driver): Likewise.
7971 * editfns.c (general_insert_function): Likewise.
7972 * eval.c (struct backtrace.nargs, interactive_p)
7973 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7974 (funcall_lambda, mark_backtrace): Likewise.
7975 * fns.c (concat): Likewise.
7976 * frame.c (x_set_frame_parameters): Likewise.
7977 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7978 0 if not found, not -1. All callers changed.
7980 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7981 (stack_copy_size): Now size_t, not int.
7982 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7984 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7986 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7987 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7988 All callers changed.
7990 * lisp.h (multibyte_char_to_unibyte):
7991 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7992 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7993 * character.h (CHAR_TO_BYTE8):
7994 * cmds.c (internal_self_insert):
7995 * editfns.c (general_insert_function):
7996 * keymap.c (push_key_description):
7997 * search.c (Freplace_match):
7998 * xdisp.c (message_dolog, set_message_1): All callers changed.
8000 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8002 * keyboard.c (safe_run_hook_funcall): New function.
8003 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8004 don't set the hook to nil, but remove the offending function instead.
8005 (Qcommand_hook_internal): Remove, unused.
8006 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8007 Vcommand_hook_internal.
8009 * eval.c (enum run_hooks_condition): Remove.
8010 (funcall_nil, funcall_not): New functions.
8011 (run_hook_with_args): Call each function through a `funcall' argument.
8012 Remove `cond' argument, now redundant.
8013 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8014 (Frun_hook_with_args_until_failure): Adjust accordingly.
8015 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8017 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8019 * dispextern.h (string_buffer_position): Remove declaration.
8021 * print.c (strout): Remove parameter `multibyte', unused since
8022 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8024 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8025 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8026 All callers changed.
8028 * w32.c (_wsa_errlist): Use braces for struct initializers.
8030 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8031 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8032 All callers changed.
8033 (string_buffer_position): Likewise. Also, make static (it's never
8034 used outside xdisp.c).
8035 (cursor_row_p): Remove parameter `w', unused since
8036 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8037 (decode_mode_spec): Remove parameter `precision', introduced during
8038 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8039 All callers changed.
8041 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8043 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8045 2011-03-27 Anders Lindgren <andlind@gmail.com>
8047 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8048 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8049 (ns_update_auto_hide_menu_bar): New functions.
8050 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8051 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8052 ns_constrain_all_frames.
8053 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8054 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8056 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8058 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8060 2011-03-27 Glenn Morris <rgm@gnu.org>
8062 * syssignal.h: Replace RETSIGTYPE with void.
8063 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8064 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8065 Replace SIGTYPE with void everywhere.
8066 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8067 * s/template.h (SIGTYPE): Remove commented out definition.
8069 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8071 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8072 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8074 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8076 * w32.c (read_unc_volume): Use parameter `henum', instead of
8077 global variable `wget_enum_handle'.
8079 * keymap.c (describe_vector): Remove parameters `indices' and
8080 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8081 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8083 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8085 * keyboard.c (timer_check): Remove parameter `do_it_now',
8086 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8087 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8088 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8090 * keyboard.c (read_char):
8091 * w32menu.c (w32_menu_display_help):
8092 * xmenu.c (show_help_event, menu_help_callback):
8093 Adjust calls to `show_help_echo'.
8095 * gtkutil.c (xg_maybe_add_timer):
8096 * keyboard.c (readable_events):
8097 * process.c (wait_reading_process_output):
8098 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8100 * insdel.c (adjust_markers_gap_motion):
8101 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8102 (gap_left, gap_right): Don't call it.
8104 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8106 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8107 incurred during fontification.
8109 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8111 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8112 (DEFVAR_PER_BUFFER): Don't pass it.
8114 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8115 (scrolling_window): Don't pass it.
8117 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8119 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8121 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8123 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8124 of variables specific to SELinux and computation of `encoded_absname'.
8126 * image.c (XPutPixel): Remove unused variable `height'.
8128 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8130 * unexw32.c (get_section_info): Remove unused variable `section'.
8132 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8133 (system_process_attributes): Remove unused variable `sess'.
8134 (sys_read): Remove unused variable `err'.
8136 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8137 (w32_wnd_proc): Remove unused variable `isdead'.
8138 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8139 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8140 (x_create_tip_frame): Remove unused variable `tem'.
8142 * w32inevt.c (w32_console_read_socket):
8143 Remove unused variable `no_events'.
8145 * w32term.c (x_draw_composite_glyph_string_foreground):
8146 Remove unused variable `width'.
8148 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8150 * w32term.c (x_set_glyph_string_clipping):
8151 Don't pass uninitialized region to CombineRgn.
8153 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8155 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8156 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8157 (Fx_close_connection): Remove unused variable `i'.
8159 * w32font.c (w32font_draw): Return number of glyphs.
8160 (w32font_open_internal): Remove unused variable `i'.
8161 (w32font_driver): Add missing initializer.
8163 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8164 (fill_in_menu): Remove unused variable `items_added'.
8166 * w32term.c (last_mouse_press_frame): Remove static global variable.
8167 (w32_clip_to_row): Remove unused variable `f'.
8168 (x_delete_terminal): Remove unused variable `i'.
8170 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8171 (NOTHING): Remove unused static global variable.
8172 (uniscribe_check_otf): Remove unused variable `table'.
8173 (uniscribe_font_driver): Add missing initializers.
8175 2011-03-23 Julien Danjou <julien@danjou.info>
8177 * term.c (Fsuspend_tty, Fresume_tty):
8178 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8179 * window.c (temp_output_buffer_show):
8180 * insdel.c (signal_before_change):
8181 * frame.c (Fhandle_switch_frame):
8182 * fileio.c (Fdo_auto_save):
8183 * emacs.c (Fkill_emacs):
8184 * editfns.c (save_excursion_restore):
8185 * cmds.c (internal_self_insert):
8186 * callint.c (Fcall_interactively):
8187 * buffer.c (Fkill_all_local_variables):
8188 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8190 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8191 unconditionally since it does the check itself.
8193 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8195 Fix more problems found by GCC 4.5.2's static checks.
8197 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8198 the first time through the loop, since we know p0 < p1 then.
8199 This also avoids a gcc -Wstrict-overflow warning.
8201 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8202 leading to a memory leak, possible in functions like
8203 load_charset_map_from_file that can allocate an unbounded number
8204 of objects (Bug#8318).
8206 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8207 that could (at least in theory) be that large.
8209 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8210 This is less likely to overflow, and avoids undefined behavior if
8211 overflow does occur. All callers changed. Use strtoul to scan
8212 for the unsigned long integer.
8213 (pint2hrstr): Simplify and tune code slightly.
8214 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8216 * scroll.c (do_scrolling): Work around GCC bug 48228.
8217 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8219 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8220 This also avoids a warning with gcc -Wstrict-overflow.
8221 (validate_x_resource_name): Simplify count usage.
8222 This also avoids a warning with gcc -Wstrict-overflow.
8224 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8227 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8229 * process.c (Fmake_network_process): Use socklen_t, not int,
8230 where POSIX says socklen_t is required in portable programs.
8231 This fixes a porting bug on hosts like 64-bit HP-UX, where
8232 socklen_t is wider than int (Bug#8277).
8233 (Fmake_network_process, server_accept_connection):
8234 (wait_reading_process_output, read_process_output):
8237 * process.c: Rename or move locals to avoid shadowing.
8238 (list_processes_1, Fmake_network_process):
8239 (read_process_output_error_handler, exec_sentinel_error_handler):
8240 Rename or move locals.
8241 (Fmake_network_process): Define label "retry_connect" only if needed.
8242 (Fnetwork_interface_info): Fix pointer signedness.
8243 (process_send_signal): Add cast to avoid pointer signedness problem.
8244 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8245 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8247 Make tparam.h and terminfo.c consistent.
8248 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8249 Include tparam.h instead, since it declares them.
8250 * cm.h (PC): Remove extern decl; tparam.h now does this.
8251 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8252 * terminfo.c: Include tparam.h, to check interfaces.
8253 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8254 (tparam): Adjust signature to match interface in tparam.h;
8255 this removes some undefined behavior. Check that outstring and len
8256 are zero, which they always are with Emacs.
8257 * tparam.h (PC, BC, UP): New extern decls.
8259 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8260 (xftfont_open): Rename locals to avoid shadowing.
8262 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8263 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8264 (OTF_TAG_SYM): Omit macro if not needed.
8265 (ftfont_list): Remove unused local.
8266 (get_adstyle_property, ftfont_pattern_entity):
8267 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8268 Rename locals to avoid shadowing.
8270 * xfont.c (xfont_list_family): Mark var as initialized.
8272 * xml.c (make_dom): Now static.
8274 * composite.c (composition_compute_stop_pos): Rename local to
8276 (composition_reseat_it): Remove unused locals.
8277 (find_automatic_composition, composition_adjust_point): Likewise.
8278 (composition_update_it): Mark var as initialized.
8279 (find_automatic_composition): Mark vars as initialized,
8280 with a FIXME (Bug#8290).
8282 character.h: Rename locals to avoid shadowing.
8283 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8284 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8285 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8286 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8289 * textprop.c (property_change_between_p): Remove; unused.
8291 * intervals.c (interval_start_pos): Now static.
8293 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8295 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8296 Rename locals to avoid shadowing.
8298 * sound.c (wav_play, au_play, Fplay_sound_internal):
8299 Fix pointer signedness.
8300 (alsa_choose_format): Remove unused local var.
8301 (wav_play): Initialize a variable to 0, to prevent undefined
8302 behavior (Bug#8278).
8304 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8306 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8308 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8309 clobbering (Bug#8298).
8310 * sysdep.c (sys_subshell): Likewise.
8311 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8313 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8314 This should get cleaned up, so that child_setup has the
8315 same signature on all platforms.
8317 * callproc.c (call_process_cleanup): Now static.
8318 (relocate_fd): Rename locals to avoid shadowing.
8320 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8322 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8323 not to be necessary, and produces flickering.
8325 2011-03-20 Glenn Morris <rgm@gnu.org>
8327 * config.in: Remove file.
8329 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8331 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8332 are now in src/globals.h.
8333 (syms_of_minibuf): Remove spurious & from previous change.
8335 2011-03-20 Leo Liu <sdl.web@gmail.com>
8337 * minibuf.c (completing-read-function): New variable.
8338 (completing-read-default): Rename from completing-read.
8339 (completing-read): Call completing-read-function.
8341 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8343 * xfaces.c (Fx_load_color_file):
8344 Read color file from absolute filename (bug#8250).
8346 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8348 * makefile.w32-in: Update dependencies.
8350 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8352 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8354 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8356 Fix more problems found by GCC 4.5.2's static checks.
8358 * process.c (make_serial_process_unwind, send_process_trap):
8359 (sigchld_handler): Now static.
8361 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8362 That way, the code declares only the vars that it needs.
8363 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8364 * s/cygwin.h (PTY_ITERATION): Likewise.
8365 * s/darwin.h (PTY_ITERATION): Likewise.
8366 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8368 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8369 * process.c (allocate_pty): Don't declare stb unless it's needed.
8371 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8372 (CONSTANTLIM): Remove; unused.
8373 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8374 Define only if needed.
8376 * unexelf.c (unexec): Name an expression,
8377 to avoid gcc -Wbad-function-cast warning.
8378 Use a different way to cause a compilation error if anyone uses
8379 n rather than nn, a way that does not involve shadowing.
8380 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8382 * deps.mk (unexalpha.o): Remove; unused.
8384 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8385 * unexec.h: New file.
8386 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8387 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8389 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8390 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8391 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8392 Change as necessary to match prototype in unexec.h.
8394 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8396 (back_comment, skip_chars): Mark vars as initialized.
8398 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8399 Rename locals to avoid shadowing.
8401 * lread.c (read1): Rewrite so as not to use empty "else".
8402 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8404 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8406 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8407 warning when compiling print.c.
8409 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8410 instead of using an uninitialized var.
8411 (font_sort_entities): Mark var as initialized.
8413 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8415 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8416 pointers to constants.
8417 (font_parse_fcname): Remove unused vars.
8418 (font_delete_unmatched): Now static.
8419 (font_get_spec): Remove; unused.
8420 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8421 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8422 Rename or move locals to avoid shadowing.
8424 * fns.c (require_nesting_list, require_unwind): Now static.
8425 (Ffillarray): Rename locals to avoid shadowing.
8427 * floatfns.c (domain_error2): Define only if needed.
8428 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8430 * alloc.c (mark_backtrace): Move decl from here ...
8431 * lisp.h: ... to here, so that it can be checked.
8433 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8434 (Fdefvar): Rewrite so as not to use empty "else".
8435 (lisp_indirect_variable): Name an expression,
8436 to avoid gcc -Wbad-function-cast warning.
8437 (Fdefvar): Rename locals to avoid shadowing.
8439 * callint.c (quotify_arg, quotify_args): Now static.
8440 (Fcall_interactively): Rename locals to avoid shadowing.
8441 Use const pointer when appropriate.
8443 * lisp.h (get_system_name, get_operating_system_release):
8444 Move decls here, to check interfaces.
8445 * process.c (get_operating_system_release): Move decl to lisp.h.
8446 * xrdb.c (get_system_name): Likewise.
8447 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8448 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8449 some of which prompt warnings from gcc -Wbad-function-cast.
8450 (Fformat_time_string, Fencode_time, Finsert_char):
8451 (Ftranslate_region_internal, Fformat):
8452 Rename or remove local vars to avoid shadowing.
8453 (Ftranslate_region_internal): Mark var as initialized.
8455 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8458 * lisp.h (eassert): Check that the argument compiles, even if
8459 ENABLE_CHECKING is not defined.
8461 * data.c (Findirect_variable): Name an expression, to avoid
8462 gcc -Wbad-function-cast warning.
8463 (default_value, arithcompare, arith_driver, arith_error): Now static.
8464 (store_symval_forwarding): Rename local to avoid shadowing.
8465 (Fmake_variable_buffer_local, Fmake_local_variable):
8466 Mark variables as initialized.
8467 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8469 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8470 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8471 Rename locals to avoid shadowing.
8472 (mark_stack): Move local variables into the #ifdef region where
8474 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8475 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8477 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8478 (GC_STRING_CHARS): Remove; not used.
8479 (Fmemory_limit): Cast sbrk's returned value to char *.
8481 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8482 avoids undefined behavior in theory.
8484 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8486 Use functions, not macros, for up- and down-casing (Bug#8254).
8487 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8488 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8489 to use the following functions instead of these macros.
8490 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8491 EMACS_INT, since callers assume the returned value fits in int.
8492 (upcase1): Likewise, for UPCASE_TABLE.
8493 (uppercasep, lowercasep, upcase): New static inline functions.
8494 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8495 the race-condition problem in the old DOWNCASE.
8497 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8498 Rename locals to avoid shadowing.
8499 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8500 (regex_compile, re_search_2, re_match_2_internal):
8501 Remove unused local vars.
8502 (FREE_VAR): Rewrite so as not to use empty "else",
8503 which gcc can warn about.
8504 (regex_compile, re_match_2_internal): Mark locals as initialized.
8505 (RETALLOC_IF): Define only if needed.
8506 (WORDCHAR_P): Likewise. This one is never needed, but is used
8507 only in a comment talking about a compiler bug, so put inside
8508 the #if 0 of that comment.
8509 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8510 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8513 * search.c (boyer_moore): Rename locals to avoid shadowing.
8514 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8515 (PREV_CHAR_BOUNDARY): Likewise.
8517 * search.c (simple_search): Remove unused var.
8519 * dired.c (compile_pattern): Move decl from here ...
8520 * lisp.h: ... to here, so that it can be checked.
8521 (struct re_registers): New forward decl.
8523 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8525 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8527 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8528 Rename locals to avoid shadowing.
8529 (Fvertical_motion): Mark locals as initialized.
8531 * casefiddle.c (casify_object, casify_region): Now static.
8532 (casify_region): Mark local as initialized.
8534 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8536 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8537 New macros, so that the caller can use some names other than
8538 gcpro1, gcpro2, etc.
8539 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8541 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8542 argument, for consistency with GCPRO2_VAR, etc: it is now the
8543 prefix of the variable, not the variable itself. All uses
8545 * dired.c (directory_files_internal, file_name_completion):
8546 Rename locals to avoid shadowing.
8548 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8549 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8550 dired.c's scmp function, had undefined behavior.
8551 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8552 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8553 * buffer.h: ... to here, because these macros use current_buffer,
8554 and the new implementation with inline functions needs to have
8555 current_buffer in scope now, rather than later when the macros
8557 (downcase, upcase1): New static inline functions.
8558 (DOWNCASE, UPCASE1): Reimplement using these functions.
8559 This avoids undefined behavior in expressions like
8560 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8561 from race conditions in accessing the global variables
8562 case_temp1 and case_temp2.
8563 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8564 * lisp.h (case_temp1, case_temp2): Remove their decls.
8565 * character.h (ASCII_CHAR_P): Move from here ...
8566 * lisp.h: ... to here, so that the inline functions mentioned
8569 * dired.c (directory_files_internal_unwind): Now static.
8571 * fileio.c (file_name_as_directory, directory_file_name):
8572 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8574 (file_name_as_directory): Use const pointers when appropriate.
8575 (Fexpand_file_name): Likewise. In particular, newdir might
8576 point at constant storage, so make it a const pointer.
8577 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8578 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8580 (Fset_file_times, Finsert_file_contents, auto_save_error):
8581 Rename locals to avoid shadowing.
8583 * minibuf.c (choose_minibuf_frame_1): Now static.
8584 (Ftry_completion, Fall_completions): Rename or remove locals
8587 * marker.c (bytepos_to_charpos): Remove; unused.
8589 * lisp.h (verify_bytepos, count_markers): New decls,
8590 so that gcc does not warn that these functions aren't declared.
8592 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8593 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8594 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8595 (copy_text): Remove unused local var.
8597 * filelock.c (within_one_second): Now static.
8598 (lock_file_1): Rename local to avoid shadowing.
8600 * buffer.c (fix_overlays_before): Mark locals as initialized.
8601 (fix_start_end_in_overlays): Likewise. This function should be
8602 simplified by using pointers-to-pointers, but that's a different
8604 (switch_to_buffer_1): Now static.
8605 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8606 (report_overlay_modification): Rename locals to avoid shadowing.
8608 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8609 Fix pointer signedness issue.
8610 (sys_subshell): Mark local as volatile if checking for lint,
8611 to suppress a gcc -Wclobbered warning that does not seem to be right.
8612 (MAXPATHLEN): Define only if needed.
8614 * process.c (serial_open, serial_configure): Move decls from here ...
8615 * systty.h: ... to here, so that they can be checked.
8617 * fns.c (get_random, seed_random): Move extern decls from here ...
8618 * lisp.h: ... to here, so that they can be checked.
8620 * sysdep.c (reset_io): Now static.
8621 (wait_for_termination_signal): Remove; unused.
8623 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8624 (copy_keymap_item, append_key, push_text_char_description):
8626 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8627 (DENSE_TABLE_SIZE): Remove; unused.
8628 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8629 (describe_map_tree):
8630 Rename locals to avoid shadowing.
8632 * keyboard.c: Declare functions static if they are not used elsewhere.
8633 (echo_char, echo_dash, cmd_error, top_level_2):
8634 (poll_for_input, handle_async_input): Now static.
8635 (read_char, kbd_buffer_get_event, make_lispy_position):
8636 (make_lispy_event, make_lispy_movement, apply_modifiers):
8637 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8638 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8639 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8640 (read_key_sequence, read_char): Mark locals as initialized.
8641 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8643 * keyboard.h (make_ctrl_char): New decl.
8644 (mark_kboards): Move decl here ...
8645 * alloc.c (mark_kboards): ... from here.
8647 * lisp.h (force_auto_save_soon): New decl.
8649 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8650 (DEFINE_DUMMY_FUNCTION): New macro.
8651 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8653 (main): Add casts to avoid warnings
8654 if GCC considers string literals to be constants.
8656 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8658 * dbusbind.c: Pointer signedness fixes.
8659 (xd_signature, xd_append_arg, xd_initialize):
8660 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8661 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8662 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8663 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8665 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8666 if GCC considers string literals to be constants.
8667 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8669 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8671 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8672 (print_preprocess, print_object): New macro to fix last change.
8674 * print.c (print_preprocess): Don't forget font objects.
8676 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8678 * emacs.c (USAGE3): Doc fixes.
8680 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8682 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8685 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8687 * lisp.h (VWindow_system, Qfile_name_history):
8688 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8689 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8690 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8692 * w32select.c: Don't #include "keyboard.h".
8693 (run_protected): Add extern declaration for waiting_for_input.
8695 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8696 * w32console.c (detect_input_pending, read_input_pending)
8697 (encode_terminal_code):
8698 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8699 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8700 (w32_system_caret_y, Qfile_name_history):
8701 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8702 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8703 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8704 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8705 * w32proc.c (Qlocal, report_file_error):
8706 * w32term.c (Vwindow_system, updating_frame):
8707 * w32uniscribe.c (initialized, uniscribe_font_driver):
8708 Remove unneeded extern declarations.
8710 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8712 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8714 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8716 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8717 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8718 These macros can no longer be used for assignment.
8720 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8721 Assign struct members directly, instead of using BUF_BEGV etc.
8722 (record_buffer_markers, fetch_buffer_markers): New functions for
8723 recording and fetching special buffer markers.
8724 (set_buffer_internal_1, set_buffer_temp): Use them.
8726 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8728 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8730 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8731 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8733 * xdisp.c (hscroll_window_tree):
8734 (reconsider_clip_changes): Use PT instead of BUF_PT.
8736 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8738 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8739 $(EMACS_ROOT)/lib/intprops.h.
8741 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8743 Fix more problems found by GCC 4.5.2's static checks.
8745 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8746 to unsigned char * to avoid compiler diagnostic.
8747 (xg_free_frame_widgets): Make it clear that a local variable is
8748 needed only if USE_GTK_TOOLTIP.
8749 (gdk_window_get_screen): Make it clear that this macro is needed
8750 only if USE_GTK_TOOLTIP.
8751 (int_gtk_range_get_value): New function, which avoids a diagnostic
8752 from gcc -Wbad-function-cast.
8753 (xg_set_toolkit_scroll_bar_thumb): Use it.
8754 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8755 diagnostic from gcc -Wbad-function-cast.
8756 (get_utf8_string, xg_get_file_with_chooser):
8757 Rename locals to avoid shadowing.
8758 (create_dialog): Move locals to avoid shadowing.
8760 * xgselect.c (xg_select): Remove unused var.
8762 * image.c (four_corners_best): Mark locals as initialized.
8763 (gif_load): Initialize transparent_p to zero (Bug#8238).
8764 Mark another local as initialized.
8765 (my_png_error, my_error_exit): Mark with NO_RETURN.
8767 * image.c (clear_image_cache): Now static.
8768 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8769 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8770 (x_edge_detection): Remove unnecessary cast that
8771 gcc -Wbad-function-cast diagnoses.
8772 (gif_load): Fix pointer signedness.
8773 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8774 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8776 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8778 Improve quality of tests for time stamp overflow.
8779 For example, without this patch (encode-time 0 0 0 1 1
8780 1152921504606846976) returns the obviously-bogus value (-948597
8781 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8782 reports time overflow. See
8783 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8784 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8785 * editfns.c: Include limits.h and intprops.h.
8786 (TIME_T_MIN, TIME_T_MAX): New macros.
8787 (time_overflow): Move earlier, to before first use.
8788 (hi_time, lo_time): New functions, for an accurate test for
8790 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8791 (Fget_internal_run_time): Don't assume time_t fits in int.
8792 (make_time): Use list2 instead of Fcons twice.
8793 (Fdecode_time): More accurate test for out-of-range times.
8794 (check_tm_member): New function.
8795 (Fencode_time): Use it, to test for out-of-range times.
8796 (lisp_time_argument): Don't rely on undefined left-shift and
8797 right-shift behavior when checking for time stamp overflow.
8799 * editfns.c (time_overflow): New function, refactoring common code.
8800 (Fformat_time_string, Fdecode_time, Fencode_time):
8801 (Fcurrent_time_string): Use it.
8803 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8804 * dired.c (make_time): Move to ...
8805 * editfns.c (make_time): ... here.
8806 * systime.h: Note the move.
8808 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8810 * fringe.c (update_window_fringes): Remove unused variables.
8812 * unexmacosx.c (copy_data_segment): Also copy __got section.
8815 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8817 * termcap.c [MSDOS]: Include "msdos.h".
8818 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8819 Constify `char *' arguments and their references according to
8820 prototypes in tparam.h.
8822 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8824 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8825 Adapt all references accordingly.
8827 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8829 2011-03-11 Tom Tromey <tromey@redhat.com>
8831 * buffer.c (syms_of_buffer): Remove obsolete comment.
8833 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8835 * termhooks.h (encode_terminal_code): Declare prototype.
8837 * msdos.c (encode_terminal_code): Don't declare prototype.
8839 * term.c (encode_terminal_code): Now external again, used by
8840 w32console.c and msdos.c.
8842 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8843 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8845 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8847 Fix some minor problems found by GCC 4.5.2's static checks.
8849 * fringe.c (update_window_fringes): Mark locals as initialized
8851 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8853 * alloc.c (mark_fringe_data): Move decl from here ...
8854 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8855 to check its interface.
8856 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8858 * fontset.c (free_realized_fontset): Now static.
8859 (Fset_fontset_font): Rename local to avoid shadowing.
8860 (fontset_font): Mark local as initialized.
8861 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8863 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8865 * xselect.c (x_disown_buffer_selections): Remove; not used.
8866 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8867 (x_own_selection, Fx_disown_selection_internal): Rename locals
8869 (x_handle_dnd_message): Remove local to avoid shadowing.
8871 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8872 so that the caller can use some name other than gcpro1.
8873 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8874 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8875 (Fx_backspace_delete_keys_p):
8876 Use them to avoid shadowing, and rename vars to avoid shadowing.
8877 (x_decode_color, x_set_name, x_window): Now static.
8878 (Fx_create_frame): Add braces to silence GCC warning.
8879 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8880 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8881 Remove unused locals.
8882 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8883 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8884 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8887 * xterm.h (x_mouse_leave): New decl.
8889 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8890 Remove unused functions.
8891 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8892 (x_calc_absolute_position): Now static.
8893 (XTread_socket): Don't define label "out" unless it's used.
8894 Don't declare local "event" unless it's used.
8895 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8896 unless they are used.
8897 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8898 (x_fatal_error_signal): Remove; not used.
8899 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8900 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8901 (x_error_catcher, x_connection_closed, x_error_handler):
8902 (x_error_quitter, xembed_send_message, x_iconify_frame):
8903 (my_log_handler): Rename locals to avoid shadowing.
8904 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8905 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8907 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8908 Rename or move locals to avoid shadowing.
8909 (tty_defined_color, merge_face_heights): Now static.
8910 (free_realized_faces_for_fontset): Remove; not used.
8911 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8912 does not deduce is never used uninitialized.
8913 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8914 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8916 * terminal.c (store_terminal_param): Now static.
8918 * xmenu.c (menu_highlight_callback): Now static.
8919 (set_frame_menubar): Remove unused local.
8920 (xmenu_show): Rename parameter to avoid shadowing.
8921 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8922 since they might point to immutable storage.
8923 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8924 since it's unused otherwise.
8926 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8927 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8928 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8929 avoids a gcc -Wuninitialized diagnostic.
8930 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8931 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8932 does not deduce are never used uninitialized.
8934 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8936 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8937 * window.c (window_loop, size_window):
8938 (run_window_configuration_change_hook, enlarge_window): Likewise.
8940 * window.c (display_buffer): Now static.
8941 (size_window): Mark variables that gcc -Wuninitialized
8942 does not deduce are never used uninitialized.
8943 * window.h (check_all_windows): New decl, to forestall
8944 gcc -Wmissing-prototypes diagnostic.
8945 * dispextern.h (bidi_dump_cached_states): Likewise.
8947 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8949 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8951 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8952 and to avoid gcc -Wuninitialized warning.
8953 (load_charset_map): Mark variables that gcc -Wuninitialized
8954 does not deduce are never used uninitialized.
8955 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8957 * coding.c (coding_set_source, coding_set_destination):
8958 Use "else { /* comment */ }" rather than "else /* comment */;"
8959 for clarity, and to avoid gcc -Wempty-body warning.
8960 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8961 a block, when the outer 'i' will do.
8962 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8963 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8964 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8965 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8966 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8967 Rename locals to avoid shadowing.
8968 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8969 * coding.c (emacs_mule_char, encode_invocation_designation):
8970 Now static, since they're not used elsewhere.
8971 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8972 (decode_coding_object, encode_coding_object, detect_coding_system):
8973 (decode_coding_emacs_mule): Mark variables that gcc
8974 -Wuninitialized does not deduce are never used uninitialized.
8975 (detect_coding_iso_2022): Initialize a local variable that might
8976 be used uninitialized. Leave a FIXME because it's not clear that
8977 this initialization is needed. (Bug#8211)
8978 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8979 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8980 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8981 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8982 Remove unused macros.
8984 * category.c (hash_get_category_set): Remove unused local var.
8985 (copy_category_table): Now static, since it's not used elsewhere.
8986 * character.c (string_count_byte8): Likewise.
8988 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8989 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8991 * chartab.c (copy_sub_char_table): Now static, since it's not used
8993 (sub_char_table_ref_and_range, char_table_ref_and_range):
8994 Rename locals to avoid shadowing.
8995 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8997 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8998 (BIDI_BOB): Remove unused macro.
9000 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9001 deduce are never used uninitialized.
9002 * term.c (encode_terminal_code): Likewise.
9004 * term.c (encode_terminal_code): Now static. Remove unused local.
9006 * tparam.h: New file.
9007 * term.c, tparam.h: Include it.
9008 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9009 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9010 Move these decls to tparam.h, and make them agree with what
9011 is actually in tparam.c. The previous trick of using incompatible
9012 decls in different modules does not conform to the C standard.
9013 All callers of tparam changed to use tparam's actual API.
9014 * tparam.c (tparam1, tparam, tgoto):
9015 Use const pointers where appropriate.
9017 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9018 * cm.h (struct cm): Likewise.
9019 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9020 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9021 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9022 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9023 (turn_on_face, init_tty): Likewise.
9024 * termchar.h (struct tty_display_info): Likewise.
9026 * term.c (term_mouse_position): Rename local to avoid shadowing.
9028 * alloc.c (mark_ttys): Move decl from here ...
9029 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9031 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9033 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9035 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9037 * search.c (compile_pattern_1): Remove argument regp, unused since
9038 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9039 (compile_pattern): Don't pass it.
9041 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9043 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9044 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9046 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9048 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9050 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9051 gdk_window_get_screen, gdk_window_get_geometry,
9052 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9053 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9054 (xg_get_pixbuf_from_pixmap): New function.
9055 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9056 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9057 Call xg_get_pixbuf_from_pixmap instead of
9058 gdk_pixbuf_get_from_drawable.
9059 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9060 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9061 (xg_check_special_colors): Use GtkStyleContext and its functions
9063 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9064 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9065 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9066 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9067 Call gtk_widget_get_preferred_size.
9068 (xg_frame_resized): gdk_window_get_geometry only takes 5
9070 (xg_win_to_widget, xg_event_is_for_menubar):
9071 Call gdk_x11_window_lookup_for_display.
9072 (xg_set_widget_bg): New function.
9073 (delete_cb): New function.
9074 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9075 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9076 (xg_set_background_color): Call xg_set_widget_bg.
9077 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9078 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9079 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9080 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9082 (update_frame_tool_bar): Call gtk_widget_hide.
9083 (xg_initialize): Use GDK_KEY_g.
9085 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9087 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9089 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9090 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9091 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9093 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9095 * w32xfns.c (select_palette): Check success of RealizePalette against
9096 GDI_ERROR, not zero.
9098 See ChangeLog.11 for earlier changes.
9104 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9106 This file is part of GNU Emacs.
9108 GNU Emacs is free software: you can redistribute it and/or modify
9109 it under the terms of the GNU General Public License as published by
9110 the Free Software Foundation, either version 3 of the License, or
9111 (at your option) any later version.
9113 GNU Emacs is distributed in the hope that it will be useful,
9114 but WITHOUT ANY WARRANTY; without even the implied warranty of
9115 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9116 GNU General Public License for more details.
9118 You should have received a copy of the GNU General Public License
9119 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.