1 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3 * gtkutil.c (xg_create_frame_widgets): Call
4 gtk_window_set_has_resize_grip (FALSE) if that function is
7 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9 * fileio.c (Finsert_file_contents): Undo previous change; see
10 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
12 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
14 Rename locals to avoid shadowing.
15 * fileio.c (Finsert_file_contents):
16 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
17 * process.c (wait_reading_process_output):
18 Rename inner 'proc' to 'p' to avoid shadowing.
19 Indent for consistency with usual Emacs style.
21 2011-11-25 Eli Zaretskii <eliz@gnu.org>
23 * xdisp.c (redisplay_window): If cursor row is not fully visible
24 after recentering, and scroll-conservatively is set to a large
25 number, scroll window by a few more lines to make the cursor fully
26 visible and out of scroll-margin. (Bug#10105)
27 (start_display): Don't move to the next line if the display should
28 start at a newline that is part of a display vector or an overlay
31 2011-11-24 Juri Linkov <juri@jurta.org>
33 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
34 after the `MagickPingImage' call. (Bug#10112)
36 2011-11-23 Chong Yidong <cyd@gnu.org>
38 * window.c (Fcoordinates_in_window_p): Accept only live windows.
40 2011-11-23 Martin Rudalics <rudalics@gmx.at>
42 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
43 making another buffer current. (Bug#10114)
45 2011-11-23 Glenn Morris <rgm@gnu.org>
47 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
49 2011-11-23 Chong Yidong <cyd@gnu.org>
51 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
54 2011-11-22 Eli Zaretskii <eliz@gnu.org>
56 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
57 and header-lines, as they don't have one computed for them.
60 * .gdbinit (prow): Make displayed values more self-explaining.
63 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
65 * process.c (wait_reading_process_output): Fix asynchrounous
66 GnuTLS socket handling on some versions of the GnuTLS library.
67 (wait_reading_process_output): Add comment and URL.
69 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
71 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
73 2011-11-21 Chong Yidong <cyd@gnu.org>
75 * window.c (Fnext_window, Fprevious_window): Doc fix.
77 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
79 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
81 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
83 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
85 2011-11-20 Martin Rudalics <rudalics@gmx.at>
87 * window.c (Fset_window_combination_limit): Rename argument
89 (Vwindow_combination_limit): Remove "status" from doc-string.
91 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
93 * m/ibms390.h: Remove.
94 * m/ibms390x.h: Don't include "ibms390.h".
96 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
98 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
99 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
101 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
103 * casetab.c (Fset_case_table):
104 * charset.c (Fcharset_after): Fix typos.
106 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
108 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
109 Otherwise, valgrind does not work on some platforms.
110 Problem reported by Andreas Schwab in
111 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
112 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
113 is set, removing the need for VIRT_ADDRESS_VARIES.
114 (PURE_P): Use a more-efficient implementation that needs just one
115 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
116 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
117 to 4 (xorl, subq, cmpq, setbe).
118 * alloc.c (pure): Always extern now, since that's the
119 VIRT_ADDR_VARIES behavior.
120 (PURE_POINTER_P): Use a single comparison, not two, for
121 consistency with the new puresize.h.
122 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
123 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
124 Remove VIRT_ADDR_VARIES no longer needed.
126 2011-11-19 Eli Zaretskii <eliz@gnu.org>
128 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
129 (erase_phys_cursor, update_window_cursor, show_mouse_face)
130 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
131 behave as if the cursor position were at the window margin.
133 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
134 and the cursor position is out of bounds, behave as if the cursor
135 position were at the window margin. (Bug#10075)
137 2011-11-18 Chong Yidong <cyd@gnu.org>
139 * window.c (Fwindow_combination_limit): Make first argument
140 non-optional, since it is meaningless for live windows like the
143 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
145 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
147 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
149 * intervals.c: Fix grafting over the whole buffer (bug#10071).
150 (graft_intervals_into_buffer): Simplify.
152 2011-11-18 Eli Zaretskii <eliz@gnu.org>
154 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
155 hash values of the two rows.
156 (copy_row_except_pointers): Preserve the used[] arrays and the
157 hash values of the two rows. (Bug#10035)
158 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
160 * xdisp.c (row_hash): New function, body extracted from
161 compute_line_metrics.
162 (compute_line_metrics): Call row_hash, instead of computing the
165 * dispnew.c (verify_row_hash): Call row_hash for computing the
166 hash code of a row, instead of duplicating code from xdisp.c.
168 * dispextern.h (row_hash): Add prototype.
170 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
172 * frame.c (delete_frame): Don't delete the terminal when the last
173 X frame is closed if emacs is built with GTK toolkit.
175 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
177 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
179 2011-11-17 Martin Rudalics <rudalics@gmx.at>
181 * window.c (Vwindow_splits): Rename to
182 Vwindow_combination_resize. Suggested by Juri Linkov.
183 (Fsplit_window_internal): Use Vwindow_combination_resize instead
186 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
188 * nsfns.m (Fns_font_name):
189 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
191 2011-11-16 Martin Rudalics <rudalics@gmx.at>
193 * window.h (window): Rename slot "nest" to "combination_limit".
194 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
195 (Fset_window_nest): Rename to Fset_window_combination_limit.
196 (Vwindow_nest): Rename to Vwindow_combination_limit.
197 (recombine_windows, make_parent_window, make_window)
198 (Fsplit_window_internal, saved_window)
199 (Fset_window_configuration, save_window_save): Rename all
200 occurrences of window_nest to window_combination_limit.
202 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
204 * image.c (imagemagick_load_image): Fix typo.
206 2011-11-14 Eli Zaretskii <eliz@gnu.org>
208 * xdisp.c (display_line): Move the call to
209 highlight_trailing_whitespace before the call to
210 compute_line_metrics, since the latter needs to see the final
211 faces of all the glyphs to compute ROW's hash value. Fixes
212 assertion violations in row_equal_p. (Bug#10035)
214 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
216 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
217 just return (bug#10044).
219 2011-11-12 Eli Zaretskii <eliz@gnu.org>
221 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
222 with user-defined heap size. Bump the default size of the temacs
223 heap to 27MB, to avoid memory warning when running temacs.
224 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
226 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
227 current_matrix and desired_matrix. (Bug#9990)
228 (verify_row_hash) [XASSERTS]: New function.
229 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
230 that the hash value of glyph rows is correct.
232 2011-11-12 Martin Rudalics <rudalics@gmx.at>
234 * window.h (window): Remove splits slot.
235 * window.c (Fwindow_splits, Fset_window_splits): Remove.
236 (Fdelete_other_windows_internal, make_parent_window)
237 (make_window, Fsplit_window_internal, Fdelete_window_internal)
238 (Fset_window_configuration, save_window_save): Don't deal with
239 split status of windows.
240 (saved_window): Remove splits slot.
241 (Vwindow_splits): Rewrite doc-string.
243 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
245 * xfns.c (unwind_create_frame):
246 * nsfns.m (unwind_create_frame):
247 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
248 Vframe_list (Bug#9999).
250 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
252 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
254 2011-11-11 Kenichi Handa <handa@m17n.org>
256 * callproc.c (Fcall_process): Set the member dst_multibyte of
259 2011-11-11 Johan Bockgård <bojohan@gnu.org>
261 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
262 avoid a crash (bug#9496).
264 2011-11-09 Chong Yidong <cyd@gnu.org>
266 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
267 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
269 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
271 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
273 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
275 Avoid some portability problems by eschewing 'extern inline' functions.
276 The trivial performance wins aren't worth the portability hassles; see
277 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
279 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
280 (window_box_width, window_box_left, window_box_left_offset)
281 (window_box_right, window_box_right_offset): Undo previous change,
282 by removing the "extern"s.
283 * intervals.c (adjust_intervals_for_insertion)
284 (adjust_intervals_for_deletion): Undo previous change,
285 making these static again.
286 (offset_intervals, temp_set_point_both, temp_set_point)
287 (copy_intervals_to_string): No longer inline.
288 * xdisp.c (window_text_bottom_y, window_box_width)
289 (window_box_height, window_box_left_offset)
290 (window_box_right_offset, window_box_left, window_box_right)
291 (window_box): No longer inline.
293 2011-11-08 Chong Yidong <cyd@gnu.org>
295 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
296 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
297 an error if not a live window.
298 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
299 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
301 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
303 * lisp.h (syms_of_abbrev): Remove declaration.
304 Reported by CHENG Gao <chenggao@royau.me>.
306 2011-11-07 Eli Zaretskii <eliz@gnu.org>
308 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
309 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
310 of temacs in GUI mode.
312 2011-11-07 Martin Rudalics <rudalics@gmx.at>
314 * window.h: Declare delete_all_child_windows instead of
315 delete_all_subwindows.
316 * window.c (Fwindow_nest, Fset_window_nest)
317 (Fset_window_new_total, Fset_window_new_normal)
318 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
319 (delete_all_subwindows): Rename to delete_all_child_windows.
320 (Fdelete_other_windows_internal, Fset_window_configuration):
321 Call delete_all_child_windows instead of delete_all_subwindows.
322 * frame.c (delete_frame): Call delete_all_child_windows instead
323 of delete_all_subwindows.
325 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
327 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
328 This is also needed for porting to any host where GC_MARK_STACK is
329 not GC_MAKE_GCPROS_NOOPS.
330 (which_symbols): Use it.
332 2011-11-07 Kenichi Handa <handa@m17n.org>
334 * coding.c (coding_set_destination): Check coding->src_pos only
335 when coding->src_object is a buffer (bug#9910).
337 * process.c (send_process): Set the member src_multibyte of coding
338 to 0 (bug#9911) when sending a unibyte text.
340 * callproc.c (Fcall_process): Set the member src_multibyte of
341 process_coding to 0 (bug#9912).
343 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
345 * xmenu.c (cleanup_widget_value_tree): New function.
346 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
347 calling free_menubar_widget_value_tree directly (Bug#9830).
349 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
351 Fix some portability problems with 'inline'.
352 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
353 (window_box_width, window_box_left, window_box_left_offset)
354 (window_box_right, window_box_right_offset): Declare extern.
355 Otherwise, these inline functions do not conform to C99 and
356 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
357 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
358 * intervals.c (adjust_intervals_for_insertion)
359 (adjust_intervals_for_deletion): Now extern, because otherwise the
360 extern inline functions 'offset_intervals' couldn't refer to it.
361 (static_offset_intervals): Remove.
362 (offset_intervals): Rewrite using the old contents of
363 static_offset_intervals. The old version didn't conform to C99
364 because an extern inline function contained a reference to an
365 identifier with static linkage.
367 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
369 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
372 2011-11-06 Eli Zaretskii <eliz@gnu.org>
374 * xdisp.c (init_iterator, reseat_to_string): Don't set the
375 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
376 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
377 return Qleft_to_right.
379 2011-11-06 Chong Yidong <cyd@gnu.org>
381 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
382 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
383 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
384 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
385 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
386 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
387 (Fwindow_vscroll): Doc fix.
388 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
389 argument, since it makes no sense to pass a live window and for
390 consistency with window-child.
392 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
394 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
397 2011-11-05 Jason Rumney <jasonr@gnu.org>
399 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
400 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
402 (add_font_entity_to_list): Fix logic errors in mixed boolean and
403 bitwise arithmetic preventing use of unicode-sip and non-truetype
406 2011-11-05 Eli Zaretskii <eliz@gnu.org>
408 * s/ms-w32.h (fstat, stat, utime): Move redirections to
411 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
412 initialization code to keep similarity to xfns.c after changes
415 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
417 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
418 (unwind_create_frame): New function (Bug#9943).
419 (Fx_create_frame): Restructure code to be more similar to the one in
420 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
421 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
422 Move terminal->reference_count++ just before making the frame official
425 * nsterm.m (x_free_frame_resources): New function.
426 (x_destroy_window): Move code to x_free_frame_resources.
428 * xfns.c (unwind_create_frame): Fix comment.
429 (Fx_create_frame, x_create_tip_frame): Move
430 terminal->reference_count++ just before making the frame
431 official. Move initialization of image_cache_refcount and
432 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
434 2011-11-05 Eli Zaretskii <eliz@gnu.org>
436 Support MSVC build with newer versions of Visual Studio.
437 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
438 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
441 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
442 which are not supported by MSVC.
443 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
444 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
446 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
448 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
450 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
452 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
454 Support MSVC build with newer versions of Visual Studio.
455 * w32.c: Don't include w32api.h for MSVC.
456 (init_environment) [_MSC_VER]: Call sys_access, not _access.
458 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
459 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
460 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
461 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
463 (alloca) [_MSC_VER]: Define to _alloca.
465 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
467 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
469 2011-11-04 Eli Zaretskii <eliz@gnu.org>
471 * xdisp.c (note_mouse_highlight): If either of
472 previous/next-single-property-change returns nil, treat that as
473 the beginning or the end of the buffer. (Bug#9955)
475 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
477 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
478 label is not null (Bug#9951).
479 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
482 2011-11-04 Eli Zaretskii <eliz@gnu.org>
484 * window.c (Fwindow_body_size): Mention in the doc string that the
485 return value is in frame's canonical units. (Bug#9949)
487 2011-11-03 Eli Zaretskii <eliz@gnu.org>
489 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
491 * w32fns.c (unwind_create_frame): If needed, free the glyph
492 matrices of the partially constructed frame. (Bug#9943)
493 * xfns.c (unwind_create_frame): Likewise.
495 2011-11-01 Eli Zaretskii <eliz@gnu.org>
497 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
498 Don't stop backward scan on the continuation glyph, even though
499 its CHARPOS is positive.
500 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
501 cover_string to disp_string.
503 2011-11-01 Martin Rudalics <rudalics@gmx.at>
505 * window.c (temp_output_buffer_show): Don't use
506 Vtemp_buffer_show_specifiers.
507 (Vtemp_buffer_show_specifiers): Remove unused variable.
509 2011-10-30 Eli Zaretskii <eliz@gnu.org>
511 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
512 past the beginning of the current glyph matrix.
514 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
516 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
517 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
518 HAVE_GTK3 (Bug#9869).
520 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
521 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
523 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
525 * xterm.c: Declare x_handle_net_wm_state to return int.
526 (handle_one_xevent): Check if we are iconified but don't have
527 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
528 (get_current_wm_state): Return non-zero if not hidden,
529 check for _NET_WM_STATE_HIDDEN (Bug#9893).
530 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
531 (x_handle_net_wm_state): Return what get_current_wm_state returns.
532 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
534 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
536 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
537 so that this new function doesn't get optimized away by a
538 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
540 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
542 * frame.h (MOUSE_HL_INFO): Remove excess parens.
544 2011-10-29 Eli Zaretskii <eliz@gnu.org>
546 Fix the `xbytecode' command.
547 * .gdbinit (xprintbytestr): New command.
548 (xwhichsymbols): Rename from `which'; all callers changed.
549 (xbytecode): Print the byte-code string as well.
551 2011-10-29 Kim Storm <storm@cua.dk>
553 * alloc.c (which_symbols): New function.
555 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
557 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
560 2011-10-29 Glenn Morris <rgm@gnu.org>
562 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
563 Not clear what it was for, and it causes various bugs. (Bug#9839)
565 2011-10-28 Eli Zaretskii <eliz@gnu.org>
567 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
568 possible random value that matches one of those tested as
569 condition to clear the mouse face.
571 2011-10-28 Chong Yidong <cyd@gnu.org>
573 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
575 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
577 * window.c (make_window): Initialize phys_cursor_on_p.
579 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
581 * lisp.h (struct Lisp_Symbol): Update comments.
583 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
585 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
587 2011-10-28 Eli Zaretskii <eliz@gnu.org>
589 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
590 <oslsachem@gmail.com> for helping to debug this.
592 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
593 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
594 (g_b_init_get_glyph_outline_w): New static variables.
595 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
596 (GetGlyphOutlineW_Proc): New typedefs.
597 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
598 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
600 (w32font_open_internal, compute_metrics):
601 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
602 instead of calling the "wide" APIs directly.
604 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
606 * w32.h (syms_of_w32font): Add prototype.
608 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
610 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
611 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
612 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
613 (Fmove_to_window_line): Doc fix.
615 2011-10-27 Chong Yidong <cyd@gnu.org>
617 * process.c (make_process): Set gnutls_state to NULL.
619 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
620 non-NULL, regardless of GNUTLS_INITSTAGE.
621 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
622 an error. Set process slots as soon as we allocate them.
624 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
626 2011-10-27 Chong Yidong <cyd@gnu.org>
628 * gnutls.c (emacs_gnutls_deinit): New function.
629 Deallocate credentials structures as well as calling gnutls_deinit.
630 (Fgnutls_deinit, Fgnutls_boot): Use it.
632 * process.c (make_process): Initialize GnuTLS credentials to NULL.
633 (deactivate_process): Call emacs_gnutls_deinit.
635 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
637 * image.c (x_create_x_image_and_pixmap):
638 * w32.c (sys_rename, w32_delayed_load):
639 * w32font.c (fill_in_logfont):
640 * w32reg.c (x_get_string_resource): Silence compiler warnings.
642 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
644 * w32fns.c (w32_default_color_map): New function,
645 extracted from Fw32_default_color_map.
646 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
648 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
650 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
652 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
654 * keyboard.c (test_undefined): New function (bug#9751).
655 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
657 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
659 * sysdep.c (init_sys_modes): Fix the check for the controlling
662 2011-10-20 Eli Zaretskii <eliz@gnu.org>
664 * dispextern.h (struct bidi_it): New member next_en_type.
666 * bidi.c (bidi_line_init): Initialize the next_en_type member.
667 (bidi_resolve_explicit_1): When next_en_pos is valid for the
668 current character, check also for next_en_type being WEAK_EN.
669 (bidi_resolve_weak): Don't enter the expensive loop if the current
670 position is before next_en_pos. Record the bidi type of the first
671 non-ET, non-BN character we find, in addition to its position.
672 (bidi_level_of_next_char): Invalidate next_en_type when
673 next_en_pos is over-stepped.
675 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
677 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
678 * editfns.c: Rewrite current-time-zone so that it invokes
679 the equivalent of (format-time-string "%Z") to get the time zone name.
680 This fixes a bug when the time zone name contains characters that
681 need converting from the system time locale to Emacs internal format.
682 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
683 that patch fixed format-time-string to do the conversion, but
684 I forgot to fix current-time-zone.
685 (format_time_string): New function, containing most of
686 what Fformat_time_string used to contain.
687 (Fformat_time_string): Rewrite in terms of format_time_string.
688 This doesn't change this function's behavior.
689 (current-time-zone): Rewrite to use format_time_string.
690 This fixes the bug reported by Michael Schierl in
691 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
692 Jason Rumney's 2007-06-07 change worked around this bug, but
694 * systime.h (tzname, timezone): Remove no-longer-used declarations.
696 2011-10-19 Eli Zaretskii <eliz@gnu.org>
698 * xdisp.c (start_display): If the character at POS is displayed
699 via a display vector, reset IT->current.dpvec_index to zero.
700 (try_window_reusing_current_matrix): If a line ends in a display
701 vector or the next line starts in a display vector, continue
702 redrawing the window even though the character position of
703 start_row was reached.
706 2011-10-18 Chong Yidong <cyd@gnu.org>
708 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
709 with nobreak-char-display too.
711 2011-10-18 Eli Zaretskii <eliz@gnu.org>
713 Fix part 3 of bug#9771.
714 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
715 (bidi_resolve_neutral): Don't enter the expensive loop looking for
716 non-neutral characters if the current character is a paragraph
717 separator (a.k.a. Newline). This avoids running the same
718 expensive loop twice, once when we consume the preceding newline
719 and the other time when the line actually needs to be displayed.
720 Avoid the loop when we see neutrals on the base embedding level
721 following a character whose directionality is the same as the
722 paragraph's. This avoids running the expensive loop when a line
723 ends in a long sequence of neutrals, like control characters.
724 Add assertion against STRONG_AL type. Slightly rearrange code
725 that determines the type of a neutral given the first non-neutral
727 (bidi_level_of_next_char): Set next_en_pos to zero when
728 invalidating its info.
730 2011-10-17 Eli Zaretskii <eliz@gnu.org>
732 * xdisp.c (push_display_prop): Determine whether to record string
733 or buffer position by IT->string, not by IT->method. Allow
734 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
735 (move_it_vertically_backward): Don't look for character position
736 immediately after the newline when in a continuation line.
739 2011-10-15 Martin Rudalics <rudalics@gmx.at>
741 * window.c (coordinates_in_window): Rewrite and delabelize
742 vertical border check. (Bug#5357) (Bug#9618)
744 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
746 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
747 errors in XSetWindowBorder (bug#9310).
749 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
751 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
752 avoid crash when xmalloc overrun checking is enabled.
754 2011-10-13 Eli Zaretskii <eliz@gnu.org>
756 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
757 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
758 cursor motion with <left> and <right> arrow keys.
760 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
761 some callers set that themselves.
763 2011-10-12 Eli Zaretskii <eliz@gnu.org>
765 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
766 display string and the previous row comes from the same string and
767 is empty. (Bug#9739) (Bug#9738)
769 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
771 * doc.c (get_doc_string): Encode file name (bug#9735).
773 2011-10-12 Eli Zaretskii <eliz@gnu.org>
775 * bidi.c (bidi_level_of_next_char):
776 * xdisp.c (get_visually_first_element): Remove old incorrect
777 comments regarding the Unicode Line Separator character.
779 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
781 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
783 * alloc.c (Fgc_status): Do not access beyond zombies array
784 boundary if nzombies > MAX_ZOMBIES.
785 * alloc.c (dump_zombies): Add missing format specifier.
787 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
789 * xdisp.c (set_cursor_from_row): Simplify conditionals,
790 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
792 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
793 Some packages use them to denote characters with modifiers.
795 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
797 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
798 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
799 matching a pp-number. Rename parameter var to var1.
801 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
803 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
805 2011-10-08 Glenn Morris <rgm@gnu.org>
807 * callint.c (Fcall_interactively): Give a more explicit error for the
808 'c' case with a non-character input. (Bug#8479)
810 2011-10-08 Eli Zaretskii <eliz@gnu.org>
812 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
814 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
815 lines that are hscrolled on the left.
817 * dispnew.c (buffer_posn_from_coords): Account for a possible
818 presence of header-line. (Bug#4426)
820 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
822 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
823 Don't advertise functionality which we discourage or doesn't work.
825 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
827 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
828 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
829 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
830 this makes Emacs dump core during garbage collection on rare
831 occasions. sizeof is obviously inferior to offsetof here, so
833 (GC_POINTER_ALIGNMENT): New macro.
834 (mark_memory): Omit 3rd (offset) arg; caller changed.
835 Don't assume EMACS_INT alignment is the same as pointer alignment.
837 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
839 * keyboard.c (read_key_sequence_remapped): New var.
840 (read_key_sequence): Compute remapping in the right buffer.
841 (command_loop_1): Use read_key_sequence's remapping directly.
843 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
845 * dired.c (file_name_completion): Don't expand file name.
846 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
847 before checking file name handler.
849 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
850 they've been requested explicitly (bug#9591).
852 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
854 * keymap.c (Fsingle_key_description): Use make_specified_string
855 instead of build_string to build string from push_key_description.
858 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
860 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
861 This fixes a Y2038 bug on 64-bit hosts.
862 * buffer.c (reset_buffer):
863 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
864 (Fclear_buffer_auto_save_failure):
865 Use 0, not -1, to represent an unset failure time, since time_t
868 Remove dependency on glibc malloc internals.
869 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
870 Move back here from lisp.h, but with their new implementations.
871 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
872 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
873 * charset.c (charset_table_init): New static var.
874 (syms_of_charset): Use it instead of xmalloc. This removes a
875 dependency on glibc malloc internals. See Eli Zaretskii's comment in
876 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
877 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
878 Move back to alloc.c.
879 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
880 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
882 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
884 * nsterm.m (windowDidResize): Call x_set_window_size only when
885 ns_in_resize is true. Otherwise set pixelwidth/height and
886 call change_frame_size (Bug#9628).
888 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
890 Port --enable-checking=all to Fedora 14 x86-64.
891 * charset.c (syms_of_charset): Also account for glibc malloc's
892 internal overhead when calculating the initial malloc maximum.
894 Port --enable-checking=all to Fedora 14 x86.
895 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
897 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
898 (overrun_check_realloc, overrun_check_free):
899 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
900 That way, xmalloc returns a properly-aligned pointer even if
901 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
902 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
903 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
904 into account when calculating the initial malloc maximum.
905 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
906 Move here from alloc.c, so that charset.c can use it too.
907 Properly align; the old code wasn't right for common 32-bit hosts
908 when configured with --enable-checking=all.
909 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
910 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
912 2011-09-29 Eli Zaretskii <eliz@gnu.org>
914 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
917 2011-09-28 Eli Zaretskii <eliz@gnu.org>
919 * xdisp.c (compute_display_string_end): If there's no display
920 string at CHARPOS, return -1.
922 * bidi.c (bidi_fetch_char): When compute_display_string_end
923 returns a negative value, treat the character as a normal
924 character not covered by a display string. (Bug#9624)
926 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
928 * lread.c (Fread_from_string): Fix typo in docstring.
930 2011-09-27 Eli Zaretskii <eliz@gnu.org>
932 * xdisp.c (handle_invisible_prop): If invisible text ends on a
933 newline, reseat the iterator instead of bidi-iterating there one
934 character at a time. (Bug#9610)
935 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
936 TO_CHARPOS if the bidi iterator is at base embedding level.
938 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
940 * lread.c (readevalloop): Use correct code for NBSP.
941 (read1): Likewise. (Bug#9608)
943 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
945 * dbusbind.c (Fdbus_register_signal): When service is not
946 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
948 2011-09-25 Glenn Morris <rgm@gnu.org>
950 * buffer.c (truncate-lines): Doc fix.
952 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
954 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
955 (Fset_window_next_buffers): Doc fix.
957 2011-09-24 Glenn Morris <rgm@gnu.org>
959 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
961 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
963 Fix minor problems found by static checking.
964 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
965 * indent.c (Fvertical_motion): Fix == vs = typo.
967 2011-09-24 Eli Zaretskii <eliz@gnu.org>
969 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
970 Default value is now t. Doc fix.
972 * indent.c (Fvertical_motion): Compute and apply the overshoot
973 logic when moving up, not only when moving down. Fix the
974 confusing name and values of the it_overshoot_expected variable;
975 logic changes accordingly. (Bug#9254) (Bug#9549)
977 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
978 CHARPOS is covered by a display string which includes newlines.
979 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
980 is covered by a display string with embedded newlines.
982 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
984 * dbusbind.c (Fdbus_register_signal): Add match rule to
985 Vdbus_registered_objects_table. (Bug#9581)
986 (Fdbus_register_method, Vdbus_registered_objects_table):
989 2011-09-24 Jim Meyering <meyering@redhat.com>
991 do not ignore write error for any output size
992 The previous change was incomplete.
993 While it makes emacs --batch detect the vast majority of stdout
994 write failures, errors were still ignored whenever the output size is
995 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
996 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
997 && echo FAIL: ignored write error
998 FAIL: ignored write error
999 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1000 && echo FAIL: ignored write error
1001 FAIL: ignored write error
1002 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1004 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1006 * emacs.c (Fkill_emacs): In noninteractive mode exit
1007 non-successfully if a write error occurred on stdout. (Bug#9574)
1009 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1011 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1014 * dispextern.h (struct it): Update the comment documenting what
1017 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1019 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1020 a display string, extend search for cursor position to end of row.
1021 (find_row_edges): If the row ends in a newline from a display
1022 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1023 Handle the case of a display string with multiple newlines.
1024 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1025 non-empty line. Fixes confusing cursor motion with arrow keys at
1026 the beginning of a line that starts with whitespace.
1028 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1030 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1033 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1035 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1038 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1040 * xdisp.c (display_line): Record maximum and minimum buffer
1041 positions even if no glyphs were produced (e.g., by a zero-width
1042 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1043 buffer positions that will be removed from the glyph row because
1045 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1046 column is beyond frame width: don't subtract 1 "pixel" when
1047 computing width of the stretch.
1048 (reseat_at_next_visible_line_start): Undo the change made on
1049 2011-09-17 that saved paragraph information and restored it after
1050 the call to `reseat'. (Bug#9545)
1052 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1054 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1055 and turn window cursor on if cleared (Bug#9415).
1057 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1059 * search.c (boyer_moore): Take unibyte characters from pattern
1060 literally. (Bug#9458)
1062 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1064 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1066 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1068 Fix minor problem found by static checking.
1069 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1070 initialized, to pacify gcc -Wuninitialized.
1072 * fileio.c: Report proper errno when syscall falls.
1073 (Finsert_file_contents): Save and restore errno,
1074 so that report_file_error outputs the correct diagnostic.
1075 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1077 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1079 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1081 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1083 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1084 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1086 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1088 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1089 about the current paragraph and restore it after the call to reseat.
1091 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1092 (bidi_find_paragraph_start): Search back for paragraph beginning
1093 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1094 (bidi_move_to_visually_next): Only trigger paragraph-related
1095 computations when the last character is a newline or at EOB, not
1096 just any NEUTRAL_B. (Bug#9470)
1098 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1099 truncated lines if point is covered by a display string. (Bug#9524)
1101 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1103 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1104 (cons_to_x_long): New function.
1105 (lisp_data_to_selection_data): Use it. Correct the test for
1106 short-versus-long data; it was negated. Break out of vector
1107 loop, for efficiency, when a long datum is discovered.
1109 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1111 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1113 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1115 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1116 GCC PR/17406) by declaring this function with external scope.
1118 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1120 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1121 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1123 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1125 * editfns.c (Fformat): Correctly handle text properties on "%%".
1127 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1129 * xterm.c (x_draw_composite_glyph_string_foreground):
1130 * w32term.c (x_draw_composite_glyph_string_foreground):
1131 * term.c (encode_terminal_code):
1132 * composite.c (composition_update_it, get_composition_id):
1133 * xdisp.c (get_next_display_element)
1134 (fill_composite_glyph_string): Add comments about special meaning
1135 of TAB characters in a composition.
1137 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1139 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1140 This occurs when processing a multibyte format.
1141 Problem reported by Wolfgang Jenker.
1143 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1145 * xdisp.c (try_cursor_movement): Only check for exact match if
1146 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1148 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1150 Remove unused external symbols.
1151 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1152 * xdisp.c (calc_pixel_width_or_height): Now static.
1153 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1154 * indent.c (check_display_width):
1155 * w32term.c: Fix comment to match code.
1156 * xterm.c, xterm.h (x_catching_errors): Remove.
1158 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1160 * xselect.c: Use signed conversions more consistently (Bug#9498).
1161 (selection_data_to_lisp_data): Assume incoming selection data are
1162 signed integers, not unsigned. This is to be consistent with
1163 outgoing selection data, which was modified to use signed integers
1164 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1165 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1166 expects long, not unsigned long.
1168 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1170 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1171 computation of loop end. Reported by Johan Bockgård
1174 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1176 * frame.c (Fother_visible_frames_p): Function deleted.
1178 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1180 * indent.c (compute_motion): Process display vector front to back
1181 rather than the other way around. (Bug#2496)
1183 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1185 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1187 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1189 * minibuf.c (Fread_from_minibuffer): Doc fix.
1191 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1193 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1194 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1196 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1198 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1199 value for non-existent files.
1201 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1203 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1204 set its "size" to -1. This will set the modtime_size field of
1205 the corresponding buffer to -1, which is what
1206 verify-visited-file-modtime expects for files that do not exist.
1209 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1211 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1213 * lisp.h: ... from here. push_key_description is no longer
1214 defined in keyboard.c, so its declaration should not be in
1215 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1216 logically belongs with push_key_description.
1218 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1220 * buffer.h: Include <sys/types.h> instead of <time.h>.
1221 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1222 Problem reported by Herbert J. Skuhra.
1224 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1226 * xml.c (parse_region): Make the parsing work for
1227 non-comment-starting XML files again (bug#9144).
1229 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1231 * image.c (gif_load): Fix calculation of bottom and right corner.
1234 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1236 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1237 redisplay in small windows.
1239 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1241 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1243 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1245 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1246 Operate on live windows only.
1248 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1250 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1252 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1254 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1255 only under bidi iteration.
1257 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1259 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1261 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1263 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1264 Without this fix, the command to link temacs failed due to an
1265 undefined symbol __builtin_isnan. This is because
1266 /usr/include/iso/math_c99.h #defines isnan(x) to
1267 __builtin_isnan(x), but the bundled gcc, which identifies itself
1268 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1270 * floatfns.c (isnan): #undef, and then #define to a clone of
1272 (Fisnan): Always define, since it's always available now.
1273 (syms_of_floatfns): Always define isnan at the Lisp level.
1275 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1277 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1279 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1281 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1282 The previous code assumed that file offsets (off_t values) fit in
1283 EMACS_INT variables, which is not true on typical 32-bit hosts.
1284 The code messed up by falsely reporting buffer overflow in cases
1285 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1286 when "big" contains more than 2**29 bytes, even though this
1287 inserts just one byte and does not overflow the buffer.
1288 (Finsert_file_contents): Store file offsets as off_t
1289 values, not as EMACS_INT values. Check for overflow when
1290 converting between EMACS_INT and off_t. When checking for
1291 buffer overflow or for overlap, take the offsets into account.
1292 Don't use EMACS_INT for small values where int suffices.
1293 When checking for overlap, fix a typo: ZV was used where
1294 ZV_BYTE was intended.
1295 (Fwrite_region): Don't assume off_t fits into 'long'.
1296 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1298 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1300 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1302 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1304 sprintf-related integer and memory overflow issues (Bug#9412).
1306 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1307 (esprintf, exprintf, evxprintf): New functions.
1308 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1309 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1310 (modify_event_symbol): Do not assume that the length of
1311 name_alist_or_stem is safe to alloca and fits in int.
1312 (Fexecute_extended_command): Likewise for function name and binding.
1313 (Frecursion_depth): Wrap around reliably on integer overflow.
1314 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1315 since some callers pass EMACS_INT values.
1316 (Fsingle_key_description): Don't crash if symbol name contains more
1317 than MAX_ALLOCA bytes.
1318 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1319 (get_minibuffer): Arg is now EMACS_INT, not int.
1320 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1321 (esprintf, exprintf, evxprintf): New decls.
1322 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1324 * dbusbind.c (signature_cat): New function.
1325 (xd_signature, Fdbus_register_signal):
1326 Do not overrun buffer; instead, report string overflow.
1328 * dispnew.c (add_window_display_history): Don't overrun buffer.
1329 Truncate instead; this is OK since it's just a log.
1331 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1332 even if the time zone offset is outlandishly large.
1333 Don't mishandle offset == INT_MIN.
1335 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1336 when creating daemon; the previous buffer-overflow check was incorrect.
1338 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1339 which has the guts of the old verror function.
1341 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1342 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1344 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1345 (font_unparse_xlfd): Don't blindly alloca long strings.
1346 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1347 fits in int, when using sprintf. Use single snprintf to count
1348 length of string rather than counting it via multiple sprintfs;
1349 that's simpler and more reliable.
1350 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1351 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1352 sprintf, in case result does not fit in int.
1354 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1355 (fontset_from_font): Print it.
1357 * frame.c (tty_frame_count): Now printmax_t, not int.
1358 (make_terminal_frame, set_term_frame_name): Print it.
1359 (x_report_frame_params): In X, window IDs are unsigned long,
1360 not signed long, so print them as unsigned.
1361 (validate_x_resource_name): Check for implausibly long names,
1362 and don't assume name length fits in 'int'.
1363 (x_get_resource_string): Don't blindly alloca invocation name;
1364 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1367 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1368 (xg_check_special_colors, xg_set_geometry):
1369 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1371 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1372 Use esprintf, not sprintf, in case result does not fit in int.
1374 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1375 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1376 it as a large positive number.
1377 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1378 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1380 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1381 in case result does not fit in int.
1383 * print.c (float_to_string): Detect width overflow more reliably.
1384 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1385 buffer overrun. Don't assume list length fits in 'int'. Treat
1386 print length of 0 as 0, not as infinity; to be consistent with other
1387 uses of print length in this function. Don't overflow print length
1388 index. Don't assume hash table size fits in 'long', or that
1389 vectorlike size fits in 'unsigned long'.
1391 * process.c (make_process): Use printmax_t, not int, to format
1392 process-name gensyms.
1394 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1396 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1397 to avoid potential buffer overrun.
1399 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1400 if X resource line is longer than 512 bytes.
1402 * xfns.c (x_window): Make sprintf buffer a bit bigger
1403 to avoid potential buffer overrun.
1405 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1407 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1409 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1411 Integer overflow fixes for scrolling, etc.
1412 Without these, Emacs silently mishandles large integers sometimes.
1413 For example, "C-u 4294967297 M-x recenter" was treated as if
1414 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1416 * xdisp.c (try_window_id): Check Emacs fixnum range before
1417 converting to 'int'.
1419 * window.c (window_scroll_line_based, Frecenter):
1420 Check that an Emacs fixnum is in range before assigning it to 'int'.
1421 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1422 values converted from Emacs fixnums.
1423 (Frecenter): Don't wrap around a line count if it is out of 'int'
1424 range; instead, treat it as an extreme value.
1425 (Fset_window_configuration, compare_window_configurations):
1426 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1428 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1429 that can exceed INT_MAX. Check that EMACS_INT value is in range
1430 before assigning it to the (possibly-narrower) index.
1431 (match_limit): Don't assume that a fixnum can fit in 'int'.
1433 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1436 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1437 (Fvertical_motion): Don't wrap around LINES values that don't fit
1438 in 'int'. Instead, treat them as extreme values. This is good
1439 enough for windows, which can't have more than INT_MAX lines anyway.
1441 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1443 * Require libxml/parser.h to avoid compilation warning.
1445 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1447 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1448 since this reportedly can destroy thread storage.
1450 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1452 * syntax.c (find_defun_start): Update all cache variables if
1453 exiting early (Bug#9401).
1455 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1457 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1459 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1460 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1461 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1463 * term.c (tty_append_glyph): New function.
1464 (produce_stretch_glyph): Static function and its prototype deleted.
1466 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1469 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1471 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1472 when checking :margin (Bug#9390).
1473 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1474 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1475 so that the name doesn't mislead. All uses changed.
1477 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1479 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1482 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1484 * xdisp.c (move_it_to): Don't bail out early when reaching
1485 position beyond to_charpos, if we are scanning backwards.
1486 (move_it_vertically_backward): When DY == 0, make sure we get to
1487 the first character in the line after the newline.
1489 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1491 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1492 (ccl_driver): Do not generate an out-of-range pointer.
1493 (Fccl_execute_on_string): Remove unnecessary check for
1494 integer overflow, noted by Stefan Monnier in
1495 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1496 Remove a FIXME that didn't need fixing.
1497 Simplify the newly-introduced buffer reallocation code.
1499 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1501 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1503 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1505 Integer and memory overflow issues (Bug#9196).
1507 * doc.c (get_doc_string): Rework so that
1508 get_doc_string_buffer_size is the actual buffer size, rather than
1509 being 1 less than the actual buffer size; this makes xpalloc more
1512 * image.c (x_allocate_bitmap_record, cache_image):
1513 * xselect.c (Fx_register_dnd_atom):
1514 Simplify previous changes by using xpalloc.
1516 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1517 since either will do and ptrdiff_t is convenient with xpalloc.
1519 * charset.c (charset_table_size)
1520 (struct charset_sort_data.priority): Now ptrdiff_t.
1521 (charset_compare): Don't overflow if priorities differ greatly.
1522 (Fsort_charsets): Don't assume list length fits in int.
1523 Check for size-calculation overflow when allocating sort data.
1524 (syms_of_charset): Allocate an initial charset table that is
1525 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1527 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1529 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1530 The actual value is always <= INT_MAX, and leaving it unsigned made
1531 overflow checking harder.
1533 * dispextern.h (struct glyph_matrix.rows_allocated)
1534 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1535 with xpalloc. The values are still always <= INT_MAX.
1537 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1539 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1540 (SAFE_NALLOCA): New macro.
1542 * region-cache.c (struct boundary.pos, find_cache_boundary)
1543 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1544 (set_cache_region, invalidate_region_cache)
1545 (revalidate_region_cache, know_region_cache, region_cache_forward)
1546 (region_cache_backward, pp_cache):
1547 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1548 so that ptrdiff_t * can be passed to xpalloc.
1549 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1550 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1551 (pp_cache): Don't assume cache_len fits in int.
1552 * region-cache.h: Adjust extern decls to match.
1554 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1555 EMACS_INT, since either will do, for xpalloc.
1557 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1558 (xnmalloc, xnrealloc, xpalloc): New functions.
1560 * bidi.c (bidi_shelve_header_size): New constant.
1561 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1562 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1564 * bidi.c (bidi_cache_shrink):
1565 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1567 Don't update size of array until after memory allocation succeeds,
1568 because xmalloc/xrealloc may not return.
1569 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1570 now that we have proper integer overflow checking.
1571 (record_overlay_string, overlay_strings): Catch overflows when
1572 calculating size of overlay_str_buf.
1574 * callproc.c (Fcall_process): Check for size overflow when
1575 calculating size of args2.
1576 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1577 Normally we prefer signed values, but sticking with ptrdiff_t would
1578 require adding more-complicated checks.
1580 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1581 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1582 Redo buffer-overflow calculations to avoid integer overflow.
1583 Add a FIXME comment where memory seems to be over-allocated.
1585 * character.c (Fstring): Check for size-calculation overflow.
1587 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1588 unnecessary integer overflow. Check for size overflow.
1589 (encode_coding_object): Don't update size until xmalloc succeeds.
1591 * composite.c (get_composition_id): Check for overflow in glyph
1592 length calculations.
1594 Integer and memory overflow fixes for display code.
1595 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1596 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1597 (scrolling_window): Check for overflow in size calculations.
1598 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1599 Don't assume glyph table len fits in int.
1600 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1601 (row_table_size): Now ptrdiff_t, not int.
1602 (scrolling_window): Avoid overflow in size calculations.
1603 Don't update size until allocation succeeds.
1604 * fns.c (concat): Check for overflow in size calculations.
1605 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1606 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1607 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1609 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1610 (get_doc_string): Check for size calculation overflow.
1611 Don't update size until allocation succeeds.
1612 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1613 EMACS_INT, where ptrdiff_t will do.
1614 (Fsubstitute_command_keys): Check for string overflow.
1616 * editfns.c (set_time_zone_rule): Don't assume environment length
1618 (message_length): Now ptrdiff_t, not int.
1619 (Fmessage_box): Don't update size until allocation succeeds.
1620 Don't assume message length fits in int.
1621 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1623 * emacs.c (main): Do not reallocate argv, since there is a null at
1624 the end that can be overwritten, and this way there's no need to
1625 worry about size-calculation overflow.
1626 (sort_args): Check for size-calculation overflow.
1628 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1630 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1632 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1633 (x_set_scroll_bar_width, x_figure_window_size):
1634 Check for integer overflow.
1635 (x_set_alpha): Do not assume XINT fits in int.
1637 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1638 This is for the members text_lines, text_cols, total_lines, total_cols,
1639 where the system imposes an 'int' limit.
1641 * fringe.c (Fdefine_fringe_bitmap):
1642 Don't update size until alloc works.
1644 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1645 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1647 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1648 Check for size-calculation overflow.
1649 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1650 do, as we prefer signed integers.
1651 (id_to_widget.max_size, id_to_widget.used)
1652 (xg_store_widget_in_map, xg_remove_widget_from_map)
1653 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1654 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1655 Use and return ptrdiff_t, not int.
1656 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1657 * gtkutil.h: Change prototypes to match the above.
1659 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1660 are duplicate now that they've been promoted to lisp.h.
1661 (x_allocate_bitmap_record, x_alloc_image_color)
1662 (make_image_cache, cache_image, xpm_load):
1663 Don't update size until alloc is done.
1664 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1666 Check for size calculation overflow.
1667 (ct_colors_allocated_max): New constant.
1668 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1671 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1672 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1673 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1674 Use ptrdiff_t, not int, to count maps.
1675 (read_char_minibuf_menu_prompt): Check for overflow in size
1676 calculations. Don't update size until allocation succeeds.
1677 Redo calculations to avoid overflow.
1678 * keyboard.h: Change prototypes to match the above.
1680 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1682 (current_minor_maps): Check for size calculation overflow.
1683 * keymap.h: Change prototypes to match the above.
1685 * lread.c (read1, init_obarray): Don't update size until alloc done.
1687 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1688 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1690 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1691 Now ptrdiff_t, not int.
1692 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1693 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1695 * process.c (Fnetwork_interface_list): Check for overflow
1696 in size calculation.
1698 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1700 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1701 overflow. Don't bother calling xmalloc when xrealloc will do.
1703 * search.c (Freplace_match): Check for size calculation overflow.
1704 (Fset_match_data): Don't assume list lengths fit in 'int'.
1706 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1707 for command line length. Do not attempt to address one before the
1708 beginning of an array, as that's not portable.
1710 * term.c (max_frame_lines): Remove; unused.
1711 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1713 (encode_terminal_code, calculate_costs): Check for size
1714 calculation overflow.
1715 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1716 table lengths and related sizes. Don't update size until alloc
1717 done. Redo calculations to avoid overflow.
1718 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1720 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1721 subtracting pointers.
1722 (gobble_line): Check for overflow more carefully. Don't update size
1725 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1726 Don't update size until alloc done.
1727 Redo size calculations to avoid overflow.
1728 Check for size calculation overflow.
1729 (main) [DEBUG]: Fix typo in invoking tparam1.
1731 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1732 Use ptrdiff_t, not int, for sizes.
1733 (store_mode_line_noprop_char): Don't update size until alloc done.
1735 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1736 Use ptrdiff_t, not int, for sizes.
1737 (Finternal_make_lisp_face, cache_face):
1738 Check for size calculation overflow.
1739 (cache_face): Treat size calculation overflows as if they were
1740 memory exhaustion (the usual treatment), rather than aborting.
1742 * xfns.c (x_encode_text, x_set_name_internal)
1743 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1744 sizes, since they can exceed INT_MAX in size. Check for size
1745 calculation overflow.
1747 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1748 (xg_select): Check for size calculation overflow.
1749 Don't update size until alloc done.
1751 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1752 as sprintf is limited to int lengths.
1754 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1755 (X_LONG_MIN): New macros.
1756 Use them to make the following changes clearer.
1757 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1758 This change doesn't affect the value now, but it may help remind
1759 future maintainers not to raise the value too much later.
1760 (SELECTION_QUANTUM): Remove, replacing with ...
1761 (selection_quantum): ... new function, which avoids overflow.
1763 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1764 assumption that selection length fits in 'int'.
1765 (x_reply_selection_request, x_handle_selection_request)
1766 (x_get_window_property, receive_incremental_selection)
1767 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1768 (lisp_data_to_selection_data, clean_local_selection_data):
1769 Use ptrdiff_t, not int, to record length of selection.
1770 (x_reply_selection_request, x_get_window_property)
1771 (receive_incremental_selection, x_property_data_to_lisp):
1772 Redo calculations to avoid overflow.
1773 (x_reply_selection_request): When sending hint, ceiling it at
1774 X_LONG_MAX rather than relying on wraparound overflow to send
1776 (x_get_window_property, receive_incremental_selection)
1777 (lisp_data_to_selection_data, x_property_data_to_lisp):
1778 Check for size-calculation overflow.
1779 (x_get_window_property, receive_incremental_selection)
1780 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1781 Don't store size until memory allocation succeeds.
1782 (x_get_window_property): Plug memory leak on memory exhaustion.
1783 Don't double-block input; malloc is safe here. Don't assume 2**34
1784 - 4 fits in unsigned long. Add an xassert to check
1785 XGetWindowProperty overflow. Be more careful about overflow
1786 calculations, and distinguish size from memory overflow better.
1787 (receive_incremental_selection): When tracing, don't assume
1788 unsigned int is less than INT_MAX.
1789 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1790 harmful) conversions of unsigned short to int.
1791 (lisp_data_to_selection_data): Don't assume that integers
1792 in the range -65535 through -1 fit in an X unsigned short.
1793 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1794 result parameters unless successful. Rely on cons_to_unsigned
1795 to report problems with elements; the old code wasn't right anyway.
1796 (x_check_property_data): Check for int overflow; we cannot use
1797 a wider type due to X limits.
1798 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1800 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1802 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1803 (x_term_init): Check for size calculation overflow.
1804 (x_color_cells): Don't store size until memory allocation succeeds.
1805 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1806 Don't assume alloca size is less than MAX_ALLOCA.
1807 (x_term_init): Don't assume length fits in int (sprintf is limited
1810 Use ptrdiff_t for composition IDs.
1811 * character.c (lisp_string_width):
1812 * composite.c (composition_table_size, n_compositions)
1813 (get_composition_id, composition_gstring_from_id):
1814 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1815 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1816 * window.c (Frecenter):
1817 Use ptrdiff_t, not int, for composition IDs.
1818 * composite.c (get_composition_id): Check for integer overflow.
1819 * composite.h: Adjust prototypes to match the above changes.
1821 Use ptrdiff_t for hash table indexes.
1822 * category.c (hash_get_category_set):
1823 * ccl.c (ccl_driver):
1824 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1825 * coding.c (coding_system_charset_list, detect_coding_system):
1826 * coding.h (struct coding_system.id):
1827 * composite.c (get_composition_id, gstring_lookup_cache):
1828 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1829 * image.c (xpm_get_color_table_h):
1830 * lisp.h (hash_lookup, hash_put):
1831 * minibuf.c (Ftest_completion):
1832 Use ptrdiff_t for hash table indexes, not int (which is too
1833 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1834 32-bit --with-wide-int hosts).
1836 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1837 Add a FIXME comment about memory leaks.
1838 (syms_of_charset): Don't assume xmalloc returns.
1840 Don't assume that stated character widths fit in int.
1841 * character.c (Fchar_width, c_string_width, lisp_string_width):
1842 * character.h (CHAR_WIDTH):
1843 * indent.c (MULTIBYTE_BYTES_WIDTH):
1844 Use sanitize_char_width to avoid undefined and/or bad behavior
1845 with outlandish widths.
1846 * character.h (sanitize_tab_width): Rename from sanitize_width,
1847 now that we have two such functions. All uses changed.
1848 (sanitize_char_width): New inline function.
1850 Don't assume that tab-width fits in int.
1851 * character.h (sanitize_width): New inline function.
1852 (SANE_TAB_WIDTH): New macro.
1853 (ASCII_CHAR_WIDTH): Use it.
1854 * indent.c (sane_tab_width): Remove. All uses replaced by
1855 SANE_TAB_WIDTH (current_buffer).
1856 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1858 * fileio.c: Integer overflow issues with file modes.
1859 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1861 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1862 Remove unreachable code.
1863 (read_hex, load_charset_map_from_file): Check for integer overflow.
1865 * xterm.c: don't go over XClientMessageEvent limit
1866 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1867 (x_send_scroll_bar_event): Likewise. Check that the size does not
1868 exceed limits imposed by XClientMessageEvent, as well as the usual
1869 ptrdiff_t and size_t limits.
1871 * keyboard.c: Overflow, signedness and related fixes.
1872 (make_lispy_movement): Use same integer type in forward decl
1873 that is used in the definition.
1874 (read_key_sequence, keyremap_step):
1875 Change bufsize argument back to int, undoing my 2011-03-30 change.
1876 We prefer signed types, and int is wide enough here.
1877 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1878 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1879 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1880 length, not size_t. Use ptrdiff_t for index, not int.
1881 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1882 possibility of integer overflow.
1884 Overflow, signedness and related fixes for images.
1886 * dispextern.h (struct it.stack[0].u.image.image_id)
1887 (struct_it.image_id, struct image.id, struct image_cache.size)
1888 (struct image_cache.used, struct image_cache.ref_count):
1889 * gtkutil.c (update_frame_tool_bar):
1890 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1891 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1892 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1893 * nsmenu.m (update_frame_tool_bar):
1894 * xdisp.c (calc_pixel_width_or_height):
1895 * xfns.c (image_cache_refcount):
1896 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1897 on typical 64-bit hosts.
1899 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1900 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1901 Omit unnecessary casts to int.
1902 (parse_image_spec): Check that integers fall into 'int' range
1903 when the callers expect that.
1904 (image_ascent): Redo ascent calculation to avoid int overflow.
1905 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1906 (lookup_image): Remove unnecessary tests.
1907 (xbm_image_p): Locals are now of int, not EMACS_INT,
1908 since parse_image_check makes sure they fit into int.
1909 (png_load, gif_load, svg_load_image):
1910 Prefer int to unsigned where either will do.
1911 (tiff_handler): New function, combining the cores of the
1912 old tiff_error_handler and tiff_warning_handler.
1913 This function is rewritten to use vsnprintf and thereby avoid
1914 stack buffer overflows. It uses only the features of vsnprintf
1915 that are common to both POSIX and native Microsoft.
1916 (tiff_error_handler, tiff_warning_handler): Use it.
1917 (tiff_load, gif_load, imagemagick_load_image):
1918 Don't assume :index value fits in 'int'.
1919 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1920 (imagemagick_load_image): Check that crop parameters fit into
1921 the integer types that MagickCropImage accepts. Don't assume
1922 Vimagemagick_render_type has a nonnegative value. Don't assume
1923 size_t fits in 'long'.
1924 (gs_load): Use printmax_t to print the widest integers possible.
1925 Check for integer overflow when computing image height and width.
1927 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1929 * xdisp.c (redisplay_window): Don't force window start if point
1930 will be invisible in the resulting window. (Bug#9324)
1932 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1934 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1935 the display spec is of the form `(space ...)'.
1936 (handle_display_spec): Return the value returned by
1937 handle_single_display_spec, not just 1 or zero.
1938 (handle_single_display_spec): If the display spec is of the form
1939 `(space ...)', and specifies display in the text area, return 2
1941 (try_cursor_movement): Check for the need to scroll more
1942 accurately, and prefer exact match for point under bidi.
1943 Don't advance `row' beyond the last row of the window.
1945 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1946 into disp_prop; all users changed.
1948 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1949 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1950 for the text covered by the display property.
1952 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1954 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1955 Change return value to nil.
1956 (Frecord_buffer): Delete unused function.
1958 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1960 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1961 buffers, return left-to-right.
1962 (set_cursor_from_row): Consider candidate row a win if its glyph
1963 represents a newline and point is on that newline. Fixes cursor
1964 positioning on the newline at EOL of R2L text within L2R
1965 paragraph, and vice versa.
1966 (try_cursor_movement): Check continued rows, in addition to
1967 continuation rows. Fixes unwarranted scroll when point enters a
1968 continued line of R2L text within an L2R paragraph, or vice versa.
1969 (cursor_row_p): Consider the case of point being equal to
1970 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1971 from the end of a short line to the beginning of a continued line
1972 of R2L text within L2R paragraph.
1973 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1974 composed characters.
1976 * bidi.c (bidi_check_type): Use xassert.
1977 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1980 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1982 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1985 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1987 * nsfont.m (ns_otf_to_script): Fix typo.
1989 2011-08-22 Kenichi Handa <handa@m17n.org>
1991 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1992 extra slot even if the purpose is char-code-property-table.
1994 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1996 * xdisp.c (redisplay_window): When computing centering_position,
1997 account for the height of the header line. (Bug#8874)
1999 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2000 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2001 candidate is selected by the mouse, and that candidate has a
2002 composed character under the mouse.
2004 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2005 coordinates reported by pos-visible-in-window-p for a composed
2006 character in column zero.
2008 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2010 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2012 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2014 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2015 consider it a hit if to_charpos is anywhere in the range of the
2016 composed buffer positions.
2018 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2020 * image.c (gif_load): Don't assume that each subimage has the same
2021 dimensions as the base image. Handle disposal method that is
2022 "undefined" by the gif spec (Bug#9335).
2024 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2026 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2027 (Fcondition_case): Document `debug' symbol in error handler.
2029 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2031 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2032 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2033 from an Org mode buffer to a Speedbar frame.
2035 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2036 a composition, take its buffer position from IT->cmp_it.charpos.
2037 Fixes cursor positioning at the beginning of a line that begins
2038 with a composed character.
2040 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2042 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2043 character bidirectional type, use STRONG_L instead. Fixes crashes
2044 in a buffer produced by `describe-categories'.
2046 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2047 members before the level stack, so they would be saved and
2048 restored when copying iterator state. Fixes incorrect reordering
2049 around TABs covered by display properties.
2051 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2053 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2055 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2057 * eval.c (internal_condition_case, internal_condition_case_1)
2058 (internal_condition_case_2, internal_condition_case_n):
2059 Remove unnecessary aborts (Bug#9081).
2061 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2063 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2064 has no `load' handler, try opening the file locally. (Bug#9311)
2066 2011-08-16 Ken Brown <kbrown@cornell.edu>
2068 * gmalloc.c: Expand comment.
2070 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2072 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2073 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2075 2011-08-16 Ken Brown <kbrown@cornell.edu>
2077 Fix memory allocation problems in Cygwin build (Bug#9273).
2079 * unexcw.c ( __malloc_initialized): Declare external variable.
2080 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2082 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2084 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2086 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2088 [CYGWIN] (special_realloc): New function.
2089 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2090 requests to realloc storage in the static heap.
2092 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2094 * bidi.c (bidi_initialize): Remove unused local.
2096 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2099 * biditype.h: Remove file.
2100 * makefile.w32-in ($(BLD)/bidi.$(O)):
2101 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2103 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2105 * chartab.c: Improve commentary for the uniprop_table API.
2107 * bidi.c (bidi_paragraph_init): Support zero value of
2108 bidi_ignore_explicit_marks_for_paragraph_level.
2109 (bidi_initialize): Use uniprop_table instead of including
2110 biditype.h and bidimirror.h.
2112 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2113 coordinates of the iterator when restoring from ppos_it.
2116 2011-08-14 Kenichi Handa <handa@m17n.org>
2118 * process.c (create_process): Call setup_process_coding_systems
2119 after the pid of the process is set to -1 (Bug#8162).
2121 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2123 * xdisp.c (move_it_in_display_line_to): Don't invoke
2124 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2125 ppos_it. Fixes vertical cursor motion when line beginning is
2126 covered by an image. (Bug#9296)
2128 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2130 * nsterm.h (ns_run_ascript): Declare.
2131 (NSAPP_DATA2_RUNASSCRIPT): Define.
2133 * nsfns.m (as_script, as_result, as_status): New static variables.
2134 (ns_run_ascript): New function.
2135 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2136 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2137 the event loop. Get status from as_status (Bug#7276).
2139 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2140 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2141 the event loop (Bug#7276).
2143 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2145 * gnutls.c (QCgnutls_bootprop_priority)
2146 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2147 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2148 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2149 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2150 (QCgnutls_bootprop_verify_hostname_error)
2151 (QCgnutls_bootprop_callbacks_verify): Rename from
2152 Qgnutls_bootprop_..., all uses changed.
2154 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2157 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2159 * xfaces.c (Qframe_set_background_mode): Now static.
2160 * dispextern.h (Qframe_set_background_mode): Remove decl.
2162 * process.c (Fnetwork_interface_info): Declare local only if needed.
2164 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2166 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2167 (Fnetwork_interface_list): Allocate in increments of bytes instead
2168 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2169 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2171 (struct ifflag_def): notrailers is smart on OSX.
2172 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2173 Get hardware address with getifaddrs if available.
2175 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2177 * xdisp.c (iterate_out_of_display_property): xassert that
2178 IT->position is set to within IT->object's boundaries. Break from
2179 the loop as soon as EOB is reached; avoids infloops in redisplay
2180 when IT->position is set up wrongly due to some bug.
2181 Set IT->current to match the bidi iterator unconditionally.
2182 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2183 entry. Force push_it to save on the stack the current
2184 buffer/string position, to be restored by pop_it. Fix flags in
2185 the iterator structure wrt the object coming from a display
2186 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2187 properties. (Bug#9284)
2189 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2191 * fontset.c (fontset_get_font_group): Add proper type checks.
2194 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2196 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2197 and LC_VERSION_MIN_MACOSX.
2198 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2199 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2201 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2203 * xdisp.c (forward_to_next_line_start): Allow to use the
2204 no-display-properties-and-no-overlays under bidi display.
2205 Set disp_pos in the bidi iterator to avoid searches for display
2206 properties and overlays.
2208 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2210 * editfns.c (Fset_time_zone_rule): Document relationship with the
2213 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2214 the font entity extracted from the cache (Bug#8109).
2216 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2218 * composite.c (autocmp_chars): Don't reset point. That is done by
2219 restore_point_unwind (Bug#5984).
2221 2011-08-07 Juri Linkov <juri@jurta.org>
2223 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2224 to show the arg `TIME' instead of `TIMEVAL'.
2226 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2228 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2229 display property strides EOL and includes a newline, as in
2230 longlines-mode. (Bug#9254)
2231 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2232 word-wrap under bidirectional display. (Bug#9224)
2234 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2235 is non-zero, even if the data buffer is NULL. Fixes a crash in
2236 vertical-motion with longlines-mode. (Bug#9254)
2238 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2240 * bidi.c <bidi_cache_total_alloc>: Now static.
2241 (bidi_initialize): Initialize bidi_cache_total_alloc.
2243 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2246 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2247 amount allocated this far in `bidi_cache_total_alloc'.
2248 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2249 non-zero, only free the data buffer without restoring the cache
2250 contents. All callers changed.
2252 * dispextern.h (bidi_unshelve_cache): Update prototype.
2254 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2255 (move_it_in_display_line, move_it_to)
2256 (move_it_vertically_backward, move_it_by_lines): Replace the call
2257 to xfree to an equivalent call to bidi_unshelve_cache.
2258 (move_it_in_display_line_to): Fix logic of returning
2259 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2261 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2263 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2264 came from a string character with a `cursor' property. (Bug#9229)
2266 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2268 * Makefile.in (LIB_PTHREAD): New variable.
2269 (LIBES): Add LIB_PTHREAD (Bug#9216).
2271 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2272 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2274 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2276 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2278 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2280 * xterm.c (x_find_topmost_parent): New function.
2281 (x_set_frame_alpha): Find topmost parent window with
2282 x_find_topmost_parent and set the property there also (bug#9181).
2283 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2285 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2287 * callproc.c (Fcall_process): Avoid vfork clobbering
2288 the local vars buffer, coding_systems, current_dir.
2290 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2292 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2294 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2296 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2297 so that it is not optimized away.
2299 * xdisp.c (compute_display_string_pos): Remove unused local.
2301 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2303 Fix slow cursor motion and scrolling in large buffers with
2304 selective display, like Org Mode buffers. (Bug#9218)
2306 * dispextern.h (struct bidi_it): New member disp_prop_p.
2308 * xdisp.c: Remove one-slot cache of display string positions.
2309 (compute_display_string_pos): Accept an additional argument
2310 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2311 for a display string or property. If found, set DISP_PROP_P
2314 * bidi.c (bidi_fetch_char): Accept an additional argument
2315 DISP_PROP_P, and pass it to compute_display_string_pos.
2316 Only handle text covered by a display string if DISP_PROP_P is returned
2317 non-zero. All callers of bidi_fetch_char changed.
2319 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2321 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2323 2010-12-03 Don March <don@ohspite.net>
2325 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2326 last character M-[char] is translated to ESC [char] (bug#7541).
2328 2011-08-02 Kenichi Handa <handa@m17n.org>
2330 * lisp.h (uniprop_table): Extern it.
2332 * chartab.c (uniprop_table): Make it non-static.
2334 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2336 * xdisp.c (forward_to_next_line_start): Accept additional argument
2337 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2339 (reseat_at_next_visible_line_start): Use the bidi iterator state
2340 returned by forward_to_next_line_start to restore the state of
2341 it->bidi_it after backing up to previous newline. (Bug#9212)
2343 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2345 * regex.c (re_comp): Protoize.
2346 (re_exec): Fix return type.
2347 (regexec): Fix type of `ret'. (Bug#9203)
2349 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2351 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2352 This is needed if max-image-size is a floating-point number.
2354 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2356 * print.c (print_object): Print empty symbol as ##.
2358 * lread.c (read1): Read ## as empty symbol.
2360 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2362 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2363 setting frame foreground color (Bug#9175).
2364 (x_set_background_color): Likewise.
2366 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2367 contents (Bug#9176).
2368 (EmacsTooltip -init): Remove bezels and add shadows to
2371 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2372 or scroll bar (Bug#8470).
2374 * nsfont.m (nsfont_open): Remove assignment to voffset and
2375 unnecessary vars hshink, expand, hd, full_height, min_height.
2376 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2378 * nsterm.h (nsfont_info): Remove voffset field.
2380 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2382 Implement strike-through and overline on NextStep (Bug#8863).
2384 * nsfont.m (nsfont_open): Use underline position provided by font,
2385 instead of hard-coded value of 2.
2386 (nsfont_draw): Call ns_draw_text_decoration instead.
2388 * nsterm.h: Add declaration for ns_draw_text_decoration.
2390 * nsterm.m (ns_draw_text_decoration): New function for drawing
2391 underline, overline, and strike-through.
2392 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2393 ns_draw_text_decoration. Change treatment of cursor drawing to
2394 accommodate underlining, etc.
2396 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2398 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2401 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2403 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2404 Without this fix, if a signal arrives just after memory fills up,
2405 'malloc' might be invoked reentrantly.
2407 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2408 In other words, assume that every image size is allowed, on non-X
2409 hosts. This assumption is probably wrong, but it lets Emacs compile.
2411 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2413 * regex.c (re_iswctype): Convert return values to boolean.
2415 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2417 * xdisp.c (compute_display_string_pos): Don't use cached display
2418 string position if the buffer had its restriction changed.
2421 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2423 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2425 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2427 Integer signedness and overflow and related fixes. (Bug#9079)
2429 * bidi.c: Integer size and overflow fixes.
2430 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2431 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2432 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2433 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2434 (bidi_find_other_level_edge):
2435 Use ptrdiff_t instead of EMACS_INT where either will do.
2436 This works better on 32-bit hosts configured --with-wide-int.
2437 (bidi_cache_ensure_space): Check for size-calculation overflow.
2438 Use % rather than repeated addition, for better worst-case speed.
2439 Don't set bidi_cache_size until after xrealloc returns, because it
2441 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2442 (bidi_cache_ensure_space): Also check that the bidi cache size
2443 does not exceed that of the largest Lisp string or buffer. See Eli
2444 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2446 * alloc.c (__malloc_size_t): Remove.
2447 All uses replaced by size_t. See Andreas Schwab's note
2448 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2450 * image.c: Improve checking for integer overflow.
2451 (check_image_size): Assume that f is nonnull, since
2452 it is always nonnull in practice. This is one less thing to
2453 worry about when checking for integer overflow later.
2454 (x_check_image_size): New function, which checks for integer
2455 overflow issues inside X.
2456 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2457 This removes the need for a memory_full check.
2458 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2459 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2460 (xbm_read_bitmap_data): Change locals back to 'int', since
2461 their values must fit in 'int'.
2462 (xpm_load_image, png_load, tiff_load):
2463 Invoke x_create_x_image_and_pixmap earlier,
2464 to avoid much needless work if the image is too large.
2465 (tiff_load): Treat overly large images as if
2466 x_create_x_image_and_pixmap failed, not as malloc failures.
2467 (gs_load): Use x_check_image_size.
2469 * gtkutil.c: Omit integer casts.
2470 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2471 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2473 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2475 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2476 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2477 would wrongly return t on a 64-bit host.
2479 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2480 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2481 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2482 and therefore cause GCC to emit a bogus diagnostic in some cases.
2484 * image.c: Integer signedness and overflow and related fixes.
2485 This is not an exhaustive set of fixes, but it's time to
2486 record what I've got.
2487 (lookup_pixel_color, check_image_size): Remove redundant decls.
2488 (check_image_size): Don't assume that arbitrary EMACS_INT values
2489 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2490 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2491 (tiff_load, imagemagick_load_image):
2492 Check for overflow in size calculations.
2493 (x_create_x_image_and_pixmap): Remove unnecessary test for
2494 xmalloc returning NULL; that can't happen.
2495 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2496 (xpm_color_bucket): Use better integer hashing function.
2497 (xpm_cache_color): Don't possibly over-allocate memory.
2498 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2499 (gif_memory_source):
2500 Use ptrdiff_t, not int or size_t, to record sizes.
2501 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2502 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2503 either works, as we prefer signed integers.
2504 (tiff_read_from_memory, tiff_write_from_memory):
2505 Return tsize_t, not size_t, since that's what the TIFF API wants.
2506 (tiff_read_from_memory): Don't fail simply because the read would
2507 go past EOF; instead, return a short read.
2508 (tiff_load): Omit no-longer-needed casts.
2509 (Fimagemagick_types): Don't assume size fits into 'int'.
2511 Improve hashing quality when configured --with-wide-int.
2512 * fns.c (hash_string): New function, taken from sxhash_string.
2513 Do not discard information about ASCII character case; this
2514 discarding is no longer needed.
2515 (sxhash-string): Use it. Change sig to match it. Caller changed.
2516 * lisp.h: Declare it.
2517 * lread.c (hash_string): Remove, since we now use fns.c's version.
2518 The fns.c version returns a wider integer if --with-wide-int is
2519 specified, so this should help the quality of the hashing a bit.
2521 * emacs.c: Integer overflow minor fix.
2522 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2523 Define only if GNU_LINUX.
2524 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2526 * dispnew.c: Integer signedness and overflow fixes.
2527 Remove unnecessary forward decls, that were a maintenance hassle.
2528 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2530 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2531 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2532 (prepare_desired_row, line_draw_cost):
2533 Use int, not unsigned, where either works.
2534 (save_current_matrix, restore_current_matrix):
2535 Use ptrdiff_t, not size_t, where either works.
2536 (init_display): Check for overflow more accurately, and without
2537 relying on undefined behavior.
2539 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2540 Remove, replacing with the new symbols in lisp.h. All uses changed.
2541 * fileio.c (make_temp_name):
2542 * filelock.c (lock_file_1, lock_file):
2543 * xdisp.c (message_dolog):
2544 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2545 Use pMd etc. instead.
2546 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2547 replacing the pWIDE etc. symbols removed from editfns.c.
2549 * keyboard.h (num_input_events): Now uintmax_t.
2550 This is (very slightly) less likely to mess up due to wraparound.
2553 * buffer.c: Integer signedness fixes.
2554 (alloc_buffer_text, enlarge_buffer_text):
2555 Use ptrdiff_t rather than size_t when either will do, as we prefer
2558 * alloc.c: Integer signedness and overflow fixes.
2559 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2560 (__malloc_size_t): Default to size_t, not to int.
2561 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2562 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2563 Prefer ptrdiff_t to size_t when either would do, as we prefer
2565 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2566 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2567 Now const. Initialize with values that are in range even if char
2569 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2570 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2571 These functions do the right thing with sizes > 2**32.
2572 (check_depth): Now ptrdiff_t, not int.
2573 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2574 Adjust to new way of storing sizes. Check for size overflow bugs
2576 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2577 slightly wrong anyway, as it missed one instance of
2578 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2579 (refill_memory_reserve): Omit needless cast to size_t.
2580 (mark_object_loop_halt): Mark as externally visible.
2582 * xselect.c: Integer signedness and overflow fixes.
2583 (Fx_register_dnd_atom, x_handle_dnd_message):
2584 Use ptrdiff_t, not size_t, since we prefer signed.
2585 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2586 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2587 x_dnd_atoms_size and x_dnd_atoms_length.
2589 * doprnt.c: Prefer signed to unsigned when either works.
2591 * doprnt.c (doprnt):
2593 * xdisp.c (vmessage):
2594 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2595 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2596 prefer signed arithmetic to avoid comparison confusion.
2597 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2598 but is a bit tricky.
2600 Assume freestanding C89 headers, string.h, stdlib.h.
2601 * data.c, doprnt.c, floatfns.c, print.c:
2602 Include float.h unconditionally.
2603 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2604 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2605 * regex.c: Likewise for stddef.h, string.h.
2606 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2607 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2608 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2609 (STDC_HEADERS): Remove obsolete defines.
2610 * sysdep.c: Include limits.h unconditionally.
2612 Assume support for memcmp, memcpy, memmove, memset.
2613 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2614 * regex.c (memcmp, memcpy):
2615 Remove; we assume C89 now.
2617 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2618 (__malloc_safe_bcopy): Remove; no longer needed.
2620 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2621 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2622 well either way, and we prefer signed to unsigned.
2624 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2626 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2627 closes the connection while we're reading (bug#9182).
2629 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2631 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2632 are specified (Bug#9168).
2634 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2636 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2637 Found by GCC static checking and --with-wide-int on a 32-bit host.
2639 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2641 * xdisp.c (compute_display_string_pos): Fix logic of caching
2642 previous display string position. Initialize cached_prev_pos to
2643 -1. Fixes slow-down at the beginning of a buffer.
2645 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2647 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2648 for attrs[LFACE_FONTSET_INDEX].
2650 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2652 * xml.c (parse_region): Remove unused local
2653 that was recently introduced.
2655 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2657 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2658 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2660 * xdisp.c (move_it_in_display_line_to): Record the best matching
2661 position for TO_CHARPOS while scanning the line, and restore it on
2662 exit if none of the characters scanned was an exact match.
2663 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2664 when exact match is impossible due to invisible text, and the
2665 lines are truncated.
2667 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2669 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2672 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2674 Fix a significant slow-down of cursor motion with C-n, C-p,
2675 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2676 auto-repeat under bidi redisplay in fontified buffers.
2677 * xdisp.c (compute_stop_pos_backwards): New function.
2678 (next_element_from_buffer): Call compute_stop_pos_backwards to
2679 find a suitable prev_stop when we find ourselves before
2681 (reseat): Don't look for prev_stop, as that could mean a very long
2683 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2684 <cached_disp_overlay_modiff>: Cache for last found display string
2686 (compute_display_string_pos): Return the cached position if asked
2687 about the same buffer in the same area of character positions, and
2688 the buffer wasn't changed since the time the display string
2689 position was cached.
2691 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2693 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2694 is an integer, which is important for empty lines. (Bug#9149)
2696 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2698 * frame.c (Fmodify_frame_parameters): In tty case, update the
2699 default face if necessary (Bug#4238).
2701 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2703 * editfns.c (Fstring_to_char): No need to explain what a character
2704 is in the docstring (Bug#6576).
2706 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2708 * xml.c (parse_region): Make sure we always return a tree.
2710 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2712 * xml.c (parse_region): If a document contains only comments,
2715 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2717 * xml.c (make_dom): Return comments, too.
2719 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2722 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2723 and the surrounding thread.
2724 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2725 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2726 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2728 * s/openbsd.h (BROKEN_SIGIO): Define.
2729 * unexelf.c (unexec) [__OpenBSD__]:
2730 Don't update the .mdebug section of the Alpha COFF symbol table.
2732 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2734 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2737 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2739 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2740 This fixes some race conditions on the permissions of any newly
2743 * alloc.c (valid_pointer_p): Use pipe, not open.
2744 This fixes some permissions issues when debugging.
2746 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2747 If fchown fails to set both uid and gid, try to set just gid,
2748 as that is sometimes allowed. Adjust the file's mode to eliminate
2749 setuid or setgid bits that are inappropriate if fchown fails.
2751 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2753 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2754 to compare Lisp_Objects.
2755 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2756 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2757 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2759 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2761 * lread.c (read_integer): Unread even EOF character.
2762 (read1): Likewise. Properly record start position of symbol.
2764 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2765 symbol character follows.
2767 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2769 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2770 This works around a problem with the previous change to Fcopy_file.
2771 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2772 and without this change, GCC might complain about discarding
2773 fchown's return value.
2775 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2777 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2779 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2781 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2783 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2785 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2786 it's used from the C level.
2788 * process.c: Use the same condition for POLL_FOR_INPUT in both
2789 keyboard.c and process.c (bug#1858).
2791 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2793 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2794 (Fgnutls_boot): Use it.
2796 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2798 * doc.c (Fsubstitute_command_keys): Revert last change.
2800 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2802 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2803 quotes the next character, and doesn't affect other longer
2804 sequences (bug#8935).
2806 * lread.c (syms_of_lread): Clarify that is isn't only
2807 `eval-buffer' and `eval-defun' that's affected by
2808 `lexical-binding' (bug#8460).
2810 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2812 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2813 bidi redisplay when a line includes both an image and is truncated.
2815 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2817 Fix minor problems found by static checking.
2818 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2819 (elsz): Now a signed constant, not a size_t var. We prefer signed
2820 types to unsigned, to avoid integer comparison confusion. Without
2821 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2822 "cannot optimize loop, the loop counter may overflow", a symptom
2824 * indent.c (Fvertical_motion): Mark locals as initialized.
2825 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2827 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2829 * search.c (Fre_search_backward): Mention `case-fold-search' in
2830 all the re_search_* functions (bug#8138).
2832 * keyboard.c (Fopen_dribble_file): Document when the file is
2835 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2837 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2840 Support bidi reordering of display and overlay strings.
2841 * xdisp.c (compute_display_string_pos)
2842 (compute_display_string_end): Accept additional argument STRING.
2843 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2844 (reseat_to_string): Initialize bidi_it->string.s and
2845 bidi_it->string.schars.
2846 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2847 NULL (avoids a crash in bidi_paragraph_init).
2848 Initialize itb.string.lstring.
2849 (init_iterator): Call bidi_init_it only of a valid
2850 buffer position was specified. Initialize paragraph_embedding to
2852 (reseat_to_string): Initialize the bidi iterator.
2853 (display_string): If we need to ignore text properties of
2854 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2855 original value of -1 will not work with bidi.)
2856 (compute_display_string_pos): First arg is now struct
2857 `text_pos *'; all callers changed. Support display properties on
2859 (compute_display_string_end): Support display properties on Lisp
2861 (init_iterator, reseat_1, reseat_to_string): Initialize the
2862 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2863 when iterating on a string not from display properties).
2864 (compute_display_string_pos, compute_display_string_end):
2865 Fix calculation of the object to scan. Fixes an error when using
2867 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2868 base_level_stop; instead, set base_level_stop to BEGV.
2869 Fixes crashes in vertical-motion.
2870 (next_element_from_buffer): Improve commentary for when
2871 the iterator is before prev_stop.
2872 (init_iterator): Initialize bidi_p from the default value of
2873 bidi-display-reordering, not from buffer-local value. Use the
2874 buffer-local value only if initializing for buffer iteration.
2875 (handle_invisible_prop): Support invisible properties on strings
2876 that are being bidi-reordered.
2877 (set_iterator_to_next): Support bidi reordering of C strings and
2879 (next_element_from_string): Support bidi reordering of Lisp
2881 (handle_stop_backwards): Support Lisp strings as well.
2882 (display_string): Support display of R2L glyph rows.
2883 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2884 (init_iterator): Don't initialize it->bidi_p for strings
2886 (reseat_to_string): Initialize it->bidi_p for strings here.
2887 (next_element_from_string, next_element_from_c_string)
2888 (next_element_from_buffer): Add xassert's for correspondence
2889 between IT's object being iterated and it->bidi_it.string
2891 (face_before_or_after_it_pos): Support bidi iteration.
2892 (next_element_from_c_string): Handle the case of the first string
2893 character that is not the first one in the visual order.
2894 (get_visually_first_element): New function, refactored from common
2895 parts of next_element_from_buffer, next_element_from_string, and
2896 next_element_from_c_string.
2897 (tool_bar_lines_needed, redisplay_tool_bar)
2898 (display_menu_bar): Force left-to-right direction. Add a FIXME
2899 comment for making that be controlled by a user option.
2900 (push_it, pop_it): Save and restore the state of the
2901 bidi iterator. Save and restore the bidi_p flag.
2902 (pop_it): Iterate out of display property for string iteration as
2904 (iterate_out_of_display_property): Support iteration over strings.
2905 (handle_single_display_spec): Set up it->bidi_it for iteration
2906 over a display string, and call bidi_init_it.
2907 (handle_single_display_spec, next_overlay_string)
2908 (get_overlay_strings_1, push_display_prop): Set up the bidi
2909 iterator for displaying display or overlay strings.
2910 (forward_to_next_line_start): Don't use the shortcut if
2912 (back_to_previous_visible_line_start): If handle_display_prop
2913 pushed the iterator stack, restore the internal state of the bidi
2914 iterator by calling bidi_pop_it same number of times.
2915 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2916 and we are bidi-iterating, don't decrement the iterator position;
2917 instead, set the first_elt flag in the bidi iterator, to produce
2919 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2920 (push_display_prop): xassert that we are iterating a buffer.
2921 (push_it, pop_it): Save and restore paragraph_embedding member.
2922 (handle_single_display_spec, next_overlay_string)
2923 (get_overlay_strings_1, reseat_1, reseat_to_string)
2924 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2925 correctly. Don't assume unibyte strings are not bidi-reordered.
2926 (compute_display_string_pos)
2927 (compute_display_string_end): Fix handling the case of C string.
2928 (push_it, pop_it): Save and restore from_disp_prop_p.
2929 (handle_single_display_spec, push_display_prop): Set the
2930 from_disp_prop_p flag.
2931 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2932 (pop_it): Call iterate_out_of_display_property only if we are
2933 popping after iteration over a string that came from a display
2934 property. Fix a typo in popping stretch info. Add an assertion
2935 for verifying that the iterator position is in sync with the bidi
2937 (handle_single_display_spec, get_overlay_strings_1)
2938 (push_display_prop): Fix initialization of paragraph direction for
2939 string when that of the parent object is not yet determined.
2940 (reseat_1): Call bidi_init_it to resync the bidi
2941 iterator with IT's position. (Bug#7616)
2942 (find_row_edges): If ROW->start.pos gives position
2943 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2944 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2945 Reset the from_disp_prop_p flag.
2946 (SAVE_IT, RESTORE_IT): New macros.
2947 (pos_visible_p, face_before_or_after_it_pos)
2948 (back_to_previous_visible_line_start)
2949 (move_it_in_display_line_to, move_it_in_display_line)
2950 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2951 (try_scrolling, redisplay_window, display_line): Use them when
2952 saving a temporary copy of the iterator and restoring it back.
2953 (back_to_previous_visible_line_start, reseat_1)
2954 (init_iterator): Empty the bidi cache "stack".
2955 (move_it_in_display_line_to): If iterator ended up at
2956 EOL, but we never saw any buffer positions smaller than
2957 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2958 motion in bidi-reordered lines.
2959 (move_it_in_display_line_to): Record prev_method and prev_pos
2960 immediately before the call to set_iterator_to_next. Fixes cursor
2961 motion in bidi-reordered lines with stretch glyphs and strings
2962 displayed in margins. (Bug#8133) (Bug#8867)
2963 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2965 (pos_visible_p): Support positions in bidi-reordered lines.
2966 Save and restore bidi cache.
2968 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2969 (bidi_paragraph_info): Delete unused struct.
2970 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2971 (bidi_cache_start): New variable.
2972 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2974 (bidi_cache_fetch_state, bidi_cache_search)
2975 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2976 (bidi_cache_find, bidi_peek_at_next_level)
2977 (bidi_level_of_next_char, bidi_find_other_level_edge)
2978 (bidi_move_to_visually_next): Compare cache index with
2979 bidi_cache_start rather than with zero.
2980 (bidi_fetch_char): Accept new argument STRING; all callers
2981 changed. Support iteration over a string. Support strings with
2982 display properties. Support unibyte strings. Fix the type of
2983 `len' according to what STRING_CHAR_AND_LENGTH expects.
2984 (bidi_paragraph_init, bidi_resolve_explicit_1)
2985 (bidi_resolve_explicit, bidi_resolve_weak)
2986 (bidi_level_of_next_char, bidi_move_to_visually_next):
2987 Support iteration over a string.
2988 (bidi_set_sor_type, bidi_resolve_explicit_1)
2989 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2990 can now be zero (for strings); special values 0 and -1 were
2991 changed to -1 and -2, respectively.
2992 (bidi_char_at_pos): New function.
2993 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2994 Call it instead of FETCH_MULTIBYTE_CHAR.
2995 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2996 initialized to valid values.
2997 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2999 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3000 the test for valid cached positions. Fix the logic for looking up
3001 the sentinel state in the cache. GCPRO the Lisp string we are
3003 (bidi_push_it, bidi_pop_it): New functions.
3004 (bidi_initialize): Initialize the bidi cache start stack pointer.
3005 (bidi_cache_ensure_space): New function, refactored from part of
3006 bidi_cache_iterator_state. Don't assume the required size is just
3007 one BIDI_CACHE_CHUNK away.
3008 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3009 (bidi_count_bytes, bidi_char_at_pos): New functions.
3010 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3011 always valid if bidi_cache_idx is valid.
3012 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3013 is valid if it's going to be used.
3014 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3015 (bidi_cache_fetch_state, bidi_cache_search)
3016 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3017 (bidi_cache_iterator_state, bidi_cache_find)
3018 (bidi_find_other_level_edge, bidi_cache_start_stack):
3019 All variables related to cache indices are now EMACS_INT.
3021 * dispextern.h (struct bidi_string_data): New structure.
3022 (struct bidi_it): New member `string'. Make flag members be 1-bit
3023 fields, and put them last in the struct.
3024 (compute_display_string_pos, compute_display_string_end):
3026 (bidi_push_it, bidi_pop_it): Add prototypes.
3027 (struct iterator_stack_entry): New members bidi_p,
3028 paragraph_embedding, and from_disp_prop_p.
3029 (struct it): Member bidi_p is now a bit field 1 bit wide.
3030 (bidi_shelve_cache, bidi_unshelve_cache):
3033 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3034 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3035 and vector-like objects.
3037 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3038 cache around display iteration.
3040 * window.c (Fwindow_end, window_scroll_pixel_based)
3041 (displayed_window_lines, Frecenter): Save and restore the bidi
3042 cache around display iteration.
3044 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3046 * editfns.c (Fdelete_region): Clarify the use of the named
3047 parameters (bug#6788).
3049 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3051 * indent.c (Fvertical_motion): Set and restore w->pointm when
3052 saving and restoring the window's buffer (Bug#9006).
3054 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3056 * editfns.c (Fstring_to_char): Clarify just what is returned
3057 (bug#6576). Text by Eli Zaretskii.
3059 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3061 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3063 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3065 * buffer.c (mmap_find): Fix a typo.
3067 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3069 Fix execution of x selection hooks.
3070 * xselect.c (Qx_lost_selection_functions)
3071 (Qx_sent_selection_functions): New vars.
3072 (syms_of_xselect): DEFSYM them.
3073 (x_handle_selection_request): Pass Qx_sent_selection_functions
3074 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3075 (x_handle_selection_clear,x_clear_frame_selections):
3076 Pass Qx_lost_selection_functions rather than
3077 Vx_lost_selection_functions to Frun_hook_with_args.
3079 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3081 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3082 The old code sometimes used this field without initializing it.
3084 * alloc.c (gc_sweep): Don't read past end of array.
3085 In theory, the old code could also have corrupted Emacs internals,
3086 though it'd be very unlikely.
3088 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3090 * character.c (Fcharacterp): Don't advertise optional ignored
3091 argument. (Bug#4026)
3093 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3095 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3098 * window.c (Fset_window_start): Doc fix (bug#4199).
3099 (Fset_window_hscroll): Ditto.
3101 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3103 Fix minor new problems caught by GCC 4.6.1.
3104 * term.c (init_tty): Remove unused local.
3105 * xsettings.c (store_monospaced_changed): Define this function only
3106 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3109 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3111 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3113 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3115 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3116 are the mini-buffer and the echo area (bug#3320).
3118 * term.c (init_tty): Remove support for supdup, c10 and perq
3119 terminals, which are no longer supported (bug#1482).
3121 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3123 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3125 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3127 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3128 for non-popups (Bug#3642).
3130 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3132 * alloc.c (reset_malloc_hooks): Protoize.
3133 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3134 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3135 * cm.c (losecursor): Likewise.
3136 * data.c (fmod): Likewise.
3137 * dispnew.c (swap_glyphs_in_rows): Likewise.
3138 * emacs.c (memory_warning_signal): Likewise.
3139 * floatfns.c (float_error): Likewise.
3140 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3141 (otf_open, font_otf_capability, generate_otf_features)
3142 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3144 * image.c (pbm_read_file): Likewise.
3145 * indent.c (string_display_width): Likewise.
3146 * intervals.c (check_for_interval, search_for_interval)
3147 (inc_interval_count, count_intervals, root_interval)
3148 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3149 * lread.c (defalias): Likewise.
3150 * ralloc.c (r_alloc_check): Likewise.
3151 * regex.c (set_image_of_range_1, set_image_of_range)
3152 (regex_grow_registers): Likewise.
3153 * sysdep.c (strerror): Likewise.
3154 * termcap.c (valid_filename_p, tprint, main): Likewise.
3155 * tparam.c (main): Likewise.
3156 * unexhp9k800.c (run_time_remap, save_data_space)
3157 (update_file_ptrs, read_header, write_header, calculate_checksum)
3158 (copy_file, copy_rest, display_header): Likewise.
3159 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3161 * xdisp.c (check_it): Likewise.
3162 * xfaces.c (register_color, unregister_color, unregister_colors):
3164 * xfns.c (print_fontset_result): Likewise.
3165 * xrdb.c (member, fatal, main): Likewise.
3167 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3169 Fix minor problems found by static checking (Bug#9031).
3170 * chartab.c (char_table_set_range, map_sub_char_table):
3171 Remove unused locals.
3172 (uniprop_table): Now static.
3173 * composite.c (_work_char): Remove unused static var.
3175 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3177 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3179 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3181 * gtkutil.c (qttip_cb): Remove code without function.
3183 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3185 * w32.c (pthread_sigmask): New stub.
3187 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3189 Use pthread_sigmask, not sigprocmask (Bug#9010).
3190 sigprocmask is portable only for single-threaded applications, and
3191 Emacs can be multi-threaded when it uses GTK.
3192 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3194 * callproc.c (Fcall_process):
3195 * process.c (create_process):
3196 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3197 Use pthread_sigmask, not sigprocmask.
3199 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3201 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3202 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3205 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3207 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3208 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3209 (xg_hide_tooltip): Fix comment.
3211 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3212 in registerServicesMenuSendTypes.
3213 (validRequestorForSendType): Don't check ns_return_types.
3215 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3218 2011-07-08 Jason Rumney <jasonr@gnu.org>
3220 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3221 SH_SHOW for hidden windows (Bug#5482).
3223 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3224 frame struct members of non-existent frames (Bug#6284).
3226 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3228 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3229 variable firstTime not needed on OSX >= 10.6.
3230 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3231 >= 10.5. Use setKnobProportion, setDoubleValue.
3233 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3234 (MAC_OS_X_VERSION_10_5): Define if not defined.
3235 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3236 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3237 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3239 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3240 cString and lossyCString on OSX >= 10.4
3242 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3243 sizeToFit on OSX >= 10.2.
3245 * nsimage.m (allocInitFromFile): Don't use deprecated method
3246 bestRepresentationForDevice on OSX >= 10.6.
3248 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3251 * emacs.c: Declare unexec_init_emacs_zone.
3253 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3255 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3257 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3258 on svcsMenu (Bug#8842).
3260 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3262 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3264 * nsterm.m (QUTF8_STRING): Declare.
3265 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3266 (validRequestorForSendType): Return type is (id).
3267 Change indexOfObjectIdenticalTo to indexOfObject.
3268 Check if we have local selection before returning self (Bug#8842).
3269 (writeSelectionToPasteboard): Put local selection into paste board
3270 if we have a local selection (Bug#8842).
3271 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3273 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3274 (ns_get_local_selection): Declare.
3276 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3278 * keymap.c (describe_map_tree): Don't insert a double newline at
3279 the end of the buffer (bug#1169) and return whether we inserted
3282 * callint.c (Fcall_interactively): Change "reading args" to
3283 "providing args" to try to clarify what it does (bug#1010).
3285 2011-07-07 Kenichi Handa <handa@m17n.org>
3287 * composite.c (composition_compute_stop_pos): Ignore a static
3288 composition starting before CHARPOS (Bug#8915).
3290 * xdisp.c (handle_composition_prop): Likewise.
3292 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3294 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3297 2011-07-07 Kenichi Handa <handa@m17n.org>
3299 * character.h (unicode_category_t): New enum type.
3301 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3302 (Qchar_code_property_table): New variable.
3303 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3304 (UNIPROP_COMPRESSED_FORM_P): New macros.
3305 (char_table_ascii): Uncompress the compressed values.
3306 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3307 Uncompress the compressed values.
3308 (sub_char_table_ref_and_range): Likewise.
3309 (char_table_ref_and_range): Uncompress the compressed values.
3310 (sub_char_table_set): New arg is_uniprop. Callers changed.
3311 Uncompress the compressed values.
3312 (sub_char_table_set_range): Args changed. Callers changed.
3313 (char_table_set_range): Adjuted for the above change.
3314 (map_sub_char_table): Delete args default_val and parent. Add arg
3315 top. Give decoded values to a Lisp function.
3316 (map_char_table): Adjust for the above change. Give decoded
3317 values to a Lisp function. Gcpro more variables.
3318 (uniprop_table_uncompress)
3319 (uniprop_decode_value_run_length): New functions.
3320 (uniprop_decoder, uniprop_decoder_count): New variables.
3321 (uniprop_get_decoder, uniprop_encode_value_character)
3322 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3324 (uniprop_encoder, uniprop_encoder_count): New variables.
3325 (uniprop_get_encoder, uniprop_table)
3326 (Funicode_property_table_internal, Fget_unicode_property_internal)
3327 (Fput_unicode_property_internal): New functions.
3328 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3329 Sunicode_property_table_internal, Sget_unicode_property_internal,
3330 and Sput_unicode_property_internal. Defvar_lisp
3331 char-code-property-alist.
3333 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3334 Vunicode_category_table.
3336 * font.c (font_range): Adjust for the change of
3337 Vunicode_category_table.
3339 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3341 * m/iris4d.h: Remove file, move contents ...
3342 * s/irix6-5.h: ... here.
3344 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3346 Remove unportable assumption about struct layout (Bug#8884).
3347 * alloc.c (mark_buffer):
3348 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3349 (clone_per_buffer_values): Don't assume that
3350 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3351 This isn't true in general, and it's particularly not true
3352 if Emacs is configured with --with-wide-int.
3353 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3354 New macros, used in the buffer.c change.
3356 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3358 * xsettings.c: Use both GConf and GSettings if both are available.
3359 (store_config_changed_event): Add comment.
3360 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3361 (store_tool_bar_style_changed): New functions.
3362 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3363 (struct xsettings): Move font inside HAVE_XFT.
3364 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3365 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3366 Move inside HAVE_XFT.
3367 (something_changed_gsettingsCB): Rename from something_changedCB.
3368 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3370 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3371 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3372 (something_changed_gconfCB): Rename from something_changedCB.
3373 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3374 (parse_settings): Move check for font inside HAVE_XFT.
3375 (read_settings, apply_xft_settings): Add comment.
3376 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3377 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3378 call store_font_name_changed.
3379 (xft_settings_event): Add comment.
3380 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3381 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3382 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3383 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3384 (xsettings_initialize): Call init_gsettings last.
3385 (xsettings_get_system_font, xsettings_get_system_normal_font):
3388 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3390 Random fixes. E.g., (random) never returned negative values.
3391 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3392 subseconds part to the entropy, as that's a bit more random.
3393 Prefer signed to unsigned, since the signedness doesn't matter and
3394 in general we prefer signed. When given a limit, use a
3395 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3396 latter isn't right if USE_2_TAGS_FOR_INTS.
3397 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3398 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3400 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3402 * textprop.c (text_property_stickiness):
3403 Obey Vtext_property_default_nonsticky.
3404 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3405 * w32fns.c (syms_of_w32fns):
3406 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3408 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3410 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3411 This is more efficient than Ffile_directory_p and avoids a minor race.
3413 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3415 * buffer.c (Foverlay_put): Say what the return value is
3418 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3419 is a directory before asking whether to use the file name
3421 (barf_or_query_if_file_exists): Make the "File is a directory"
3422 error be more correct.
3424 * fns.c (Frequire): Remove the mention of the .gz files, since
3425 that's installation-specific, but keep the mention of
3426 `get-load-suffixes'.
3428 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3430 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3431 Report string overflow if the output is too long.
3433 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3435 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3436 (syms_of_gnutls): Remove duplicate DEFSYM for
3437 Qgnutls_bootprop_verify_hostname_error, an error for
3438 Qgnutls_bootprop_verify_error (which is no longer used).
3440 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3441 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3442 Also (re)move comments that are misplaced or no longer relevant.
3444 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3446 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3448 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3450 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3451 and background color parameters if they have been changed.
3453 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3455 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3457 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3459 * xsettings.c (SYSTEM_FONT): Define only when used.
3460 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3462 * keymap.c (access_keymap_1): Now static.
3464 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3466 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3467 leave any prefix arg for the up event (Bug#1586).
3469 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3471 * lread.c (syms_of_lread): Mention single symbols defined by
3472 `defvar' or `defconst' (bug#7154).
3474 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3475 (Frequire): Mention get-load-suffixes.
3477 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3479 * window.h (window): Remove clone_number slot.
3480 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3482 (make_parent_window, make_window, saved_window)
3483 (Fset_window_configuration, save_window_save): Don't deal with
3485 * buffer.c (Qclone_number): Remove declaration.
3486 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3488 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3490 Add multiple inheritance to keymaps.
3491 * keymap.c (Fmake_composed_keymap): New function.
3492 (Fset_keymap_parent): Simplify.
3493 (fix_submap_inheritance): Remove.
3494 (access_keymap_1): New function extracted from access_keymap to handle
3495 embedded parents and handle lists of maps.
3496 (access_keymap): Use it.
3497 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3498 (Fcopy_keymap): Handle embedded parents.
3499 (Fcommand_remapping, define_as_prefix): Simplify.
3500 (Fkey_binding): Simplify.
3501 (syms_of_keymap): Move minibuffer-local-completion-map,
3502 minibuffer-local-filename-completion-map,
3503 minibuffer-local-must-match-map, and
3504 minibuffer-local-filename-must-match-map to Elisp.
3505 (syms_of_keymap): Defsubr make-composed-keymap.
3506 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3507 (parse_menu_item): Trivial simplification.
3509 2011-07-01 Glenn Morris <rgm@gnu.org>
3511 * Makefile.in (SETTINGS_LIBS): Fix typo.
3513 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3515 * coding.c (Fencode_coding_string): Record the last coding system
3516 used, as the function doc string says (bug#8738).
3518 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3520 * xsettings.c (store_monospaced_changed): Take new font as arg and
3521 check for change against current_mono_font.
3522 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3523 (emacs_settings_constructor, emacs_settings_get_property)
3524 (emacs_settings_set_property, emacs_settings_class_init)
3525 (emacs_settings_init, gsettings_obj): Remove.
3526 (something_changedCB): New function for HAVE_GSETTINGS.
3527 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3528 with value as argument.
3529 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3530 g_settings_new (Bug#8967). Do not create gsettings_obj.
3531 Remove calls to g_settings_bind. Connect something_changedCB to
3534 * xgselect.c: Add defined (HAVE_GSETTINGS).
3535 (xgselect_initialize): Ditto.
3537 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3538 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3541 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3543 * eval.c (struct backtrace): Simplify and port the data structure.
3544 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3545 signed bit field, as this assumption is not portable and it makes
3546 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3547 "char debug_on_exit : 1" as this is not portable either; instead,
3548 use the portable "unsigned int debug_on_exit : 1". Remove unused
3549 member evalargs. Remove obsolete comments about cc bombing out.
3551 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3553 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3554 Let HAVE_GSETTINGS override HAVE_GCONF.
3555 (store_monospaced_changed): New function.
3556 (EMACS_SETTINGS): A new type derived from GObject to handle
3557 GSettings notifications.
3558 (emacs_settings_constructor, emacs_settings_get_property)
3559 (emacs_settings_set_property, emacs_settings_class_init):
3561 (gsettings_client, gsettings_obj): New variables.
3562 (GSETTINGS_SCHEMA): New define.
3563 (something_changedCB): Call store_monospaced_changed.
3564 (init_gsettings): New function.
3565 (xsettings_initialize): Call init_gsettings.
3566 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3569 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3572 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3574 * window.c (resize_root_window, grow_mini_window)
3575 (shrink_mini_window): Rename Qresize_root_window to
3576 Qwindow_resize_root_window and Qresize_root_window_vertically to
3577 Qwindow_resize_root_window_vertically.
3579 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3581 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3583 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3585 * makefile.w32-in: Redesign dependencies so they reflect more
3586 clearly which files are directly included by each source file,
3587 and not through other includes.
3589 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3591 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3592 (sort_overlays, overlay_strings): When an overlay's clone number
3593 matches the window's clone number process the overlay even if
3594 the overlay's window property doesn't match the current window.
3596 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3597 (Fwindow_hchild): Rename to Fwindow_left_child.
3598 (Fwindow_next): Rename to Fwindow_next_sibling.
3599 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3600 (resize_window_check): Rename to window_resize_check.
3601 (resize_window_apply): Rename to window_resize_apply.
3602 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3603 (Fdelete_other_windows_internal, resize_frame_windows)
3604 (Fsplit_window_internal, Fdelete_window_internal)
3605 (grow_mini_window, shrink_mini_window)
3606 (Fresize_mini_window_internal): Fix callers accordingly.
3608 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3610 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3611 (emacs_fixed_set_min_size): Remove.
3612 (emacs_fixed_new): Take frame as argument.
3614 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3615 (_EmacsFixedPrivate): Remove minwidth/height.
3616 Add struct frame *f.
3617 (emacs_fixed_init): Initialize priv->f.
3618 (get_parent_class, emacs_fixed_set_min_size): Remove.
3619 (emacs_fixed_new): Set priv->f to argument.
3620 (emacs_fixed_get_preferred_width)
3621 (emacs_fixed_get_preferred_height): Use min_width/height from
3622 frames size_hint to set minimum and natural (Bug#8919).
3623 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3624 and use min_width/height from frames size_hint to set
3625 min_width/height (Bug#8919).
3627 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3628 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3631 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3633 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3634 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3637 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3639 * process.c (wait_reading_process_output): Bypass select if
3640 waiting for a cell while ignoring keyboard input, and input is
3641 pending. Suggested by Jan Djärv (Bug#8869).
3643 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3645 Use gnulib's dup2 module instead of rolling our own.
3646 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3648 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3650 * dispnew.c (scrolling_window): Before scrolling, turn off a
3651 mouse-highlight in the window being scrolled.
3653 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3655 Move DEFSYM to lisp.h and use everywhere.
3657 * character.h (DEFSYM): Move declaration...
3658 * lisp.h (DEFSYM): ...here.
3664 * w32select.c: Don't include character.h.
3666 * alloc.c (syms_of_alloc):
3667 * buffer.c (syms_of_buffer):
3668 * bytecode.c (syms_of_bytecode):
3669 * callint.c (syms_of_callint):
3670 * casefiddle.c (syms_of_casefiddle):
3671 * casetab.c (init_casetab_once):
3672 * category.c (init_category_once, syms_of_category):
3673 * ccl.c (syms_of_ccl):
3674 * cmds.c (syms_of_cmds):
3675 * composite.c (syms_of_composite):
3676 * dbusbind.c (syms_of_dbusbind):
3677 * dired.c (syms_of_dired):
3678 * dispnew.c (syms_of_display):
3679 * doc.c (syms_of_doc):
3680 * editfns.c (syms_of_editfns):
3681 * emacs.c (syms_of_emacs):
3682 * eval.c (syms_of_eval):
3683 * fileio.c (syms_of_fileio):
3684 * fns.c (syms_of_fns):
3685 * frame.c (syms_of_frame):
3686 * fringe.c (syms_of_fringe):
3687 * insdel.c (syms_of_insdel):
3688 * keymap.c (syms_of_keymap):
3689 * lread.c (init_obarray, syms_of_lread):
3690 * macros.c (syms_of_macros):
3691 * msdos.c (syms_of_msdos):
3692 * print.c (syms_of_print):
3693 * process.c (syms_of_process):
3694 * search.c (syms_of_search):
3695 * sound.c (syms_of_sound):
3696 * syntax.c (init_syntax_once, syms_of_syntax):
3697 * terminal.c (syms_of_terminal):
3698 * textprop.c (syms_of_textprop):
3699 * undo.c (syms_of_undo):
3700 * w32.c (globals_of_w32):
3701 * window.c (syms_of_window):
3702 * xdisp.c (syms_of_xdisp):
3703 * xfaces.c (syms_of_xfaces):
3704 * xfns.c (syms_of_xfns):
3705 * xmenu.c (syms_of_xmenu):
3706 * xsettings.c (syms_of_xsettings):
3707 * xterm.c (syms_of_xterm): Use DEFSYM.
3709 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3711 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3713 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3715 Integer and buffer overflow fixes (Bug#8873).
3717 * print.c (printchar, strout): Check for string overflow.
3718 (PRINTPREPARE, printchar, strout):
3719 Don't set size unless allocation succeeds.
3721 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3722 for sizes. Check for string overflow more accurately.
3723 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3725 * macros.c: Integer and buffer overflow fixes.
3726 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3727 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3728 Use ptrdiff_t, not int, for sizes.
3729 Don't increment bufsize until after realloc succeeds.
3730 Check for size-calculation overflow.
3731 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3733 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3735 * lread.c: Integer overflow fixes.
3736 (read_integer): Radix is now EMACS_INT, not int,
3737 to improve quality of diagnostics for out-of-range radices.
3738 Calculate buffer size correctly for out-of-range radices.
3739 (read1): Check for integer overflow in radices, and in
3740 read-circle numbers.
3741 (read_escape): Avoid int overflow.
3742 (Fload, openp, read_buffer_size, read1)
3743 (substitute_object_recurse, read_vector, read_list, map_obarray):
3744 Use ptrdiff_t, not int, for sizes.
3745 (read1): Use EMACS_INT, not int, for sizes.
3746 Check for size overflow.
3748 * image.c (cache_image): Check for size arithmetic overflow.
3750 * lread.c: Integer overflow issues.
3751 (saved_doc_string_size, saved_doc_string_length)
3752 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3753 Now ptrdiff_t, not int.
3754 (read1): Don't assume doc string length fits in int. Check for
3755 out-of-range doc string lengths.
3756 (read_list): Don't assume file position fits in int.
3757 (read_escape): Check for hex character overflow.
3759 2011-06-22 Leo Liu <sdl.web@gmail.com>
3761 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3762 Move to minibuffer.el.
3764 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3766 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3767 The following patches are for when GLYPH_DEBUG && !XASSERT.
3768 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3769 * dispnew.c (flush_stdout):
3770 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3771 Mark as externally visible.
3772 * dispnew.c (check_window_matrix_pointers): Now static.
3773 * dispnew.c (window_to_frame_vpos):
3774 * xfns.c (unwind_create_frame):
3775 * xterm.c (x_check_font): Remove unused local.
3776 * scroll.c (CHECK_BOUNDS):
3777 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3778 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3779 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3780 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3781 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3783 (debug_method_add): Use va_list and vsprintf rather than relying
3784 on undefined behavior with wrong number of arguments.
3785 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3786 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3787 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3788 since we're not interested in debugging glyphs with old libraries.
3789 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3790 GCC 4.6.0's static checking.
3792 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3794 Integer overflow and signedness fixes (Bug#8873).
3795 A few related buffer overrun fixes, too.
3797 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3799 * dispextern.h (struct face.stipple):
3800 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3801 (x_bitmap_mask, x_allocate_bitmap_record)
3802 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3803 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3804 (x_create_bitmap_from_xpm_data):
3805 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3806 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3808 * xfaces.c (load_pixmap):
3809 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3810 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3811 (.bitmaps_last, struct x_output.icon_bitmap):
3812 Use ptrdiff_t, not int, for bitmap indexes.
3813 (x_allocate_bitmap_record): Check for size overflow.
3814 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3816 Use ptrdiff_t, not int, for overlay counts.
3817 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3818 * editfns.c (overlays_around, get_pos_property):
3819 * textprop.c (get_char_property_and_overlay):
3820 * xdisp.c (next_overlay_change, note_mouse_highlight):
3821 * xfaces.c (face_at_buffer_position):
3822 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3823 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3824 (Fnext_overlay_change, Fprevious_overlay_change)
3825 (mouse_face_overlay_overlaps, Foverlays_in):
3826 Use ptrdiff_t, not int, for sizes.
3827 (overlays_at, overlays_in): Check for size-calculation overflow.
3829 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3831 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3832 (x_session_initialize): Do not assume string length fits in int.
3834 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3835 This is unlikely, but can occur if DPI is outlandish.
3837 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3838 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3840 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3841 * xrdb.c (magic_file_p, search_magic_path):
3842 Omit last arg SUFFIX; it was always 0. All callers changed.
3843 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3845 * xfont.c (xfont_match): Avoid need for strlen.
3847 * xfns.c: Don't assume strlen fits in int.
3848 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3850 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3851 not unsigned long, as we prefer signed integers. All callers changed.
3852 Detect integer overflow in repeat count.
3853 (message_dolog): Don't assume print length fits in 39 bytes.
3854 (display_mode_element): Don't assume strlen fits in int.
3856 * termcap.c: Don't assume sizes fit in int and never overflow.
3857 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3858 (gobble_line): Check for size-calculation overflow.
3860 * minibuf.c (Fread_buffer):
3861 * lread.c (intern, intern_c_string):
3862 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3863 Don't assume string length fits in int.
3865 * keyboard.c (parse_tool_bar_item):
3866 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3868 * font.c: Don't assume string length fits in int.
3869 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3870 Use ptrdiff_t, not int.
3871 (font_intern_prop): Don't assume string length fits in int.
3872 Don't assume integer property fits in fixnum.
3873 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3875 * filelock.c: Fix some buffer overrun and integer overflow issues.
3876 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3877 Reformulate so as not to need the command string.
3878 Invoke gzip -cd rather than gunzip, as it's more portable.
3879 (lock_info_type, lock_file_1, lock_file):
3880 Don't assume pid_t and time_t fit in unsigned long.
3881 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3882 (current_lock_owner): Prefer signed type for sizes.
3883 Use memcpy, not strncpy, where memcpy is what is really wanted.
3884 Don't assume (via atoi) that time_t and pid_t fit in int.
3885 Check for time_t and/or pid_t out of range, e.g., via a network share.
3886 Don't alloca where an auto var works fine.
3888 * fileio.c: Fix some integer overflow issues.
3889 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3890 Don't assume string length fits in int.
3891 (directory_file_name): Don't assume string length fits in long.
3892 (make_temp_name): Don't assume pid fits in int, or that its print
3893 length is less than 20.
3895 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3897 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3899 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3901 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3902 We prefer signed integers, even for size calculations.
3904 * emacs.c: Don't assume string length fits in 'int'.
3905 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3906 (main): Don't invoke strlen when not needed.
3908 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3909 (XD_DEBUG_MESSAGE): Don't waste a byte.
3911 * callproc.c (getenv_internal_1, getenv_internal)
3913 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3915 * lread.c (invalid_syntax): Omit length argument.
3916 All uses changed. This doesn't fix a bug, but it simplifies the
3917 code away from its former Hollerith-constant appearance, and it's
3918 one less 'int' to worry about when looking at integer-overflow issues.
3919 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3921 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3922 This didn't break anything, but it didn't help either.
3923 It's confusing to put a bogus integer in a place where the actual
3924 value does not matter.
3925 (LIST_END_P): Remove unused macro and its bogus comment.
3926 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3928 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3929 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3931 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3932 We prefer signed types, and the value cannot exceed the EMACS_INT
3933 range anyway (because otherwise the length would not be representable).
3934 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3935 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3936 This avoids a GCC warning when WIDE_EMACS_INT.
3938 * indent.c (sane_tab_width): New function.
3939 (current_column, scan_for_column, Findent_to, position_indentation)
3940 (compute_motion): Use it. This is just for clarity.
3941 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3943 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3945 * lisp.h (lint_assume): New macro.
3946 * composite.c (composition_gstring_put_cache):
3947 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3949 * editfns.c, insdel.c:
3950 Omit unnecessary forward decls, to simplify future changes.
3952 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3954 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3956 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3957 Use much-faster test for byte-length change.
3958 Don't assume string byte-length fits in 'int'.
3959 Check that character arg fits in 'int'.
3960 (mapcar1): Declare byte as byte, for clarity.
3962 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3964 * fns.c (concat): Catch string overflow earlier.
3965 Do not rely on integer wraparound.
3967 * dispextern.h (struct it.overlay_strings_charpos)
3968 (struct it.selective): Now EMACS_INT, not int.
3969 * xdisp.c (forward_to_next_line_start)
3970 (back_to_previous_visible_line_start)
3971 (reseat_at_next_visible_line_start, next_element_from_buffer):
3972 Don't arbitrarily truncate the value of 'selective' to int.
3974 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3976 * composite.c: Don't truncate sizes to 'int'.
3977 (composition_gstring_p, composition_reseat_it)
3978 (composition_adjust_point): Use EMACS_INT, not int.
3979 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3980 not EMACS_UINT, for indexes.
3982 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3984 * buffer.c: Include <verify.h>.
3985 (struct sortvec.priority, struct sortstr.priority):
3986 Now EMACS_INT, not int.
3987 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3988 (struct sortstr.size, record_overlay_string)
3989 (struct sortstrlist.size, struct sortlist.used):
3990 Don't truncate size to int.
3991 (record_overlay_string): Check for size-calculation overflow.
3992 (init_buffer_once): Check at compile-time, not run-time.
3994 2011-06-22 Jim Meyering <meyering@redhat.com>
3996 Don't leak an XBM-image-sized buffer
3997 * image.c (xbm_load): Free the image buffer after using it.
3999 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4002 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4003 that Sun C diagnosed.
4004 * fns.c (secure_hash): Fix pointer signedness issue.
4005 * intervals.c (static_offset_intervals): New function.
4006 (offset_intervals): Use it.
4008 2011-06-21 Leo Liu <sdl.web@gmail.com>
4011 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4014 * fns.c (secure_hash): Rename from crypto_hash_function and change
4015 the first arg to accept symbols.
4016 (Fsecure_hash): New primitive.
4017 (syms_of_fns): New symbols.
4019 2011-06-20 Deniz Dogan <deniz@dogan.se>
4021 * process.c (Fset_process_buffer): Clarify return value in
4024 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4026 * dispnew.c (add_window_display_history): Use BVAR.
4028 * xdisp.c (debug_method_add): Use BVAR.
4029 (check_window_end, dump_glyph_matrix, dump_glyph)
4030 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4032 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4035 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4036 check till after the cache is created in init_frame_faces.
4038 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4040 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4042 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4044 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4045 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4046 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4048 Improve buffer-overflow checking (Bug#8873).
4049 * fileio.c (Finsert_file_contents):
4050 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4051 Remove the old (too-loose) buffer overflow checks.
4052 They weren't needed, since make_gap checks for buffer overflow.
4053 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4054 The old code merely checked for Emacs fixnum overflow, and relied
4055 on undefined (wraparound) behavior. The new code avoids undefined
4056 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4058 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4059 Tune. Don't use wider integers than needed. Don't use alloca.
4060 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4062 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4064 * insdel.c, lisp.h (buffer_overflow): New function.
4065 (insert_from_buffer_1, replace_range, replace_range_2):
4066 * insdel.c (make_gap_larger):
4067 * editfns.c (Finsert_char):
4068 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4070 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4072 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4074 Integer overflow and signedness fixes (Bug#8873).
4076 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4077 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4079 * fileio.c: Don't assume EMACS_INT fits in off_t.
4080 (emacs_lseek): New static function.
4081 (Finsert_file_contents, Fwrite_region): Use it.
4082 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4084 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4086 * fns.c: Don't overflow int when computing a list length.
4087 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4088 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4089 truncation on 64-bit hosts. Check for QUIT every
4090 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4091 faster and is responsive enough.
4092 (Flength): Report an error instead of overflowing an integer.
4093 (Fsafe_length): Return a float if the value is not representable
4094 as a fixnum. This shouldn't happen except in contrived situations.
4095 (Fnthcdr, Fsort): Don't assume list length fits in int.
4096 (Fcopy_sequence): Don't assume vector length fits in int.
4098 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4099 (header_size, word_size): New constants.
4100 (allocate_vectorlike): Don't check size overflow here.
4101 (allocate_vector): Check it here instead, since this is the only
4102 caller of allocate_vectorlike that could cause overflow.
4103 Check that the new vector's length is representable as a fixnum.
4105 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4106 The previous code was bogus. For example, next_almost_prime (32)
4107 returned 39, which is undesirable as it is a multiple of 3; and
4108 next_almost_prime (24) returned 25, which is a multiple of 5 so
4109 why was the code bothering to check for multiples of 7?
4111 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4113 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4115 Variadic C functions now count arguments with ptrdiff_t.
4116 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4117 Back then I didn't know that the Emacs coding style prefers signed int.
4118 Also, in the meantime I found a few more instances where arguments
4119 were being counted with int, which may truncate counts on 64-bit
4120 machines, or EMACS_INT, which may be unnecessarily wide.
4121 * lisp.h (struct Lisp_Subr.function.aMANY)
4122 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4123 Arg counts are now ptrdiff_t, not size_t.
4124 All variadic functions and their callers changed accordingly.
4125 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4126 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4127 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4128 * callint.c (Fcall_interactively): Check arg count for overflow,
4129 to avoid potential buffer overrun. Use signed char, not 'int',
4130 for 'varies' array, so that we needn't bother to check its size
4131 calculation for overflow.
4132 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4133 * eval.c (apply_lambda):
4134 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4135 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4136 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4138 * callint.c (Fcall_interactively): Don't use index var as event count.
4140 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4141 * mem-limits.h (SIZE): Remove; no longer used.
4143 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4145 Remove unnecessary casts.
4146 * xterm.c (x_term_init):
4147 * xfns.c (x_set_border_pixel):
4148 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4149 These aren't needed now that we assume ANSI C.
4151 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4152 It's more likely to cause problems (due to unsigned overflow)
4155 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4157 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4159 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4161 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4163 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4165 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4167 GLYPH_CODE_FACE returns EMACS_INT, not int.
4168 * dispextern.h (merge_faces):
4169 * xfaces.c (merge_faces):
4170 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4171 Don't assume EMACS_INT fits in int.
4173 * character.h (CHAR_VALID_P): Remove unused parameter.
4174 * fontset.c, lisp.h, xdisp.c: All uses changed.
4176 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4178 * fns.c (concat): Minor tuning based on overflow analysis.
4179 This doesn't fix any bugs. Use int to hold character, instead
4180 of constantly refetching from Emacs object. Use XFASTINT, not
4181 XINT, for value known to be a character. Don't bother comparing
4182 a single byte to 0400, as it's always less.
4184 * floatfns.c (Fexpt):
4185 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4187 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4190 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4192 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4193 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4194 incorrectly succeed when S was a string, because 4294967386 was
4195 truncated before it was used.
4197 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4198 Otherwise, an out-of-range integer could cause undefined behavior
4201 * composite.c: Use int, not EMACS_INT, for characters.
4202 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4203 EMACS_INT, for values that are known to be in character range.
4204 This doesn't fix any bugs but is the usual style inside Emacs and
4205 may generate better code on 32-bit machines.
4207 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4208 This is for reasons similar to the recent CHAR_STRING fix.
4209 * charset.c (Fencode_char): Check that character arg is actually
4210 a character. Pass an int to ENCODE_CHAR.
4211 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4212 wider than 'int', as a compile-time check to prevent future regressions
4215 * character.c (char_string): Remove unnecessary casts.
4217 Make sure a 64-bit char is never passed to CHAR_STRING.
4218 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4219 by silently ignoring the top 32 bits, allowing some values
4220 that were far too large to be valid characters.
4221 * character.h: Include <verify.h>.
4222 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4223 arguments are no wider than unsigned, as a compile-time check
4224 to prevent future regressions in this area.
4226 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4227 (Fsubst_char_in_region):
4229 * xdisp.c (decode_mode_spec_coding):
4230 Adjust to CHAR_STRING's new requirement.
4231 * editfns.c (Finsert_char, Fsubst_char_in_region):
4232 * fns.c (concat): Check that character args are actually
4233 characters. Without this test, these functions did the wrong
4234 thing with wildly out-of-range values on 64-bit hosts.
4236 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4237 These casts should not be needed on 32-bit hosts, either.
4238 * keyboard.c (read_char):
4239 * lread.c (Fload): Remove casts to unsigned.
4241 * lisp.h (UNSIGNED_CMP): New macro.
4242 This fixes comparison bugs on 64-bit hosts.
4243 (ASCII_CHAR_P): Use it.
4244 * casefiddle.c (casify_object):
4245 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4246 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4247 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4248 * dispextern.h (FACE_FROM_ID):
4249 * keyboard.c (read_char): Use UNSIGNED_CMP.
4251 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4252 not to EMACS_INT, to avoid GCC warning.
4254 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4256 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4257 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4258 isn't needed on 32-bit machines.
4260 * buffer.c (Fgenerate_new_buffer_name):
4261 Use EMACS_INT for count, not int.
4262 (advance_to_char_boundary): Return EMACS_INT, not int.
4264 * data.c (Qcompiled_function): Now static.
4266 * window.c (window_body_lines): Now static.
4268 * image.c (gif_load): Rename local to avoid shadowing.
4270 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4271 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4272 * alloc.c (make_save_value): Integer argument is now of type
4274 (mark_object): Use ptrdiff_t, not int.
4275 * lisp.h (pD): New macro.
4276 * print.c (print_object): Use it.
4278 * alloc.c: Use EMACS_INT, not int, to count objects.
4279 (total_conses, total_markers, total_symbols, total_vector_size)
4280 (total_free_conses, total_free_markers, total_free_symbols)
4281 (total_free_floats, total_floats, total_free_intervals)
4282 (total_intervals, total_strings, total_free_strings):
4283 Now EMACS_INT, not int. All uses changed.
4284 (Fgarbage_collect): Compute overall total using a double, so that
4285 integer overflow is less likely to be a problem. Check for overflow
4286 when converting back to an integer.
4287 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4288 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4289 These were 'int' variables that could overflow on 64-bit hosts;
4290 they were never used, so remove them instead of repairing them.
4291 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4292 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4293 Previously, this ceilinged at INT_MAX, but that doesn't work on
4295 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4297 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4298 (allocate_vectorlike): Check for ptrdiff_t overflow.
4299 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4300 when a (possibly-narrower) signed value would do just as well.
4301 We prefer using signed arithmetic, to avoid comparison confusion.
4303 * alloc.c: Catch some string size overflows that we were missing.
4304 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4305 for convenience in STRING_BYTES_MAX.
4306 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4307 The definition here is exact; the one in lisp.h was approximate.
4308 (allocate_string_data): Check for string overflow. This catches
4309 some instances we weren't catching before. Also, it catches
4310 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4311 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4312 and ptrdiff_t and EMACS_INT are both 64 bits.
4314 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4315 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4316 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4318 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4320 * alloc.c (Fmake_string): Check for out-of-range init.
4322 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4324 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4326 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4328 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4329 xg_get_default_scrollbar_width.
4331 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4332 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4333 (style_changed_cb): Call update_theme_scrollbar_width and call
4334 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4335 all frames (Bug#8505).
4336 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4337 Call gtk_window_set_resizable if HAVE_GTK3.
4338 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4339 and height if HAVE_GTK3 (Bug#8505).
4340 (scroll_bar_width_for_theme): New variable.
4341 (update_theme_scrollbar_width): New function.
4342 (xg_get_default_scrollbar_width): Move code to
4343 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4344 (xg_initialize): Call update_theme_scrollbar_width.
4346 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4348 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4350 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4352 * frame.c (make_frame): Call other_buffer_safely instead of
4355 * window.c (temp_output_buffer_show): Call display_buffer with
4356 second argument Vtemp_buffer_show_specifiers and reset latter
4357 immediately after the call.
4358 (Vtemp_buffer_show_specifiers): New variable.
4359 (auto_window_vscroll_p, next_screen_context_lines)
4360 (Vscroll_preserve_screen_position): Remove leading asterisks from
4363 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4365 Fix minor problems found by GCC 4.6.0 static checking.
4366 * buffer.c (Qclone_number): Remove for now, as it's unused.
4367 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4368 (record_buffer): Remove unused local.
4369 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4370 (set_frame_buffer_list): Remove; unused.
4371 * frame.h (other_visible_frames): Remove decl.
4372 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4373 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4374 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4376 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4377 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4378 Define only if HAVE_GPM.
4379 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4380 (update_hints_inhibit): Remove; never set. All uses removed.
4381 * widgetprv.h (emacsFrameClassRec): Remove decl.
4382 * window.c (delete_deletable_window): Now returns void, since it
4383 wasn't returning anything.
4384 (compare_window_configurations): Remove unused locals.
4385 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4386 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4387 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4388 the same widths as pointers. This follows up on the 2011-05-06 patch.
4389 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4390 * xterm.h: Likewise.
4391 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4393 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4395 * makefile.w32-in: Update dependencies.
4396 (LISP_H): Add lib/intprops.h.
4398 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4400 * image.c (gif_load): Add animation frame delay to the metadata.
4401 (syms_of_image): Use DEFSYM. New symbol `delay'.
4403 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4405 * window.c (delete_deletable_window): Re-add.
4406 (Fset_window_configuration): Rewrite to handle dead buffers and
4407 consequently deletable windows.
4408 (window_tree, Fwindow_tree): Remove. Supply functionality in
4410 (compare_window_configurations): Simplify code.
4412 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4414 * image.c (imagemagick_load_image): Fix type mismatch.
4415 (Fimagemagick_types): Likewise.
4417 * window.h (replace_buffer_in_windows): Declare.
4419 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4421 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4422 Qclone_number. Remove external declaration of Qdelete_window.
4423 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4425 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4426 Run Qbuffer_list_update_hook if allowed.
4427 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4428 buffer list implementation.
4429 (other_buffer_safely): New function.
4430 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4431 calls to replace_buffer_in_windows and
4432 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4434 (record_buffer): Inhibit quitting and rewrite using quittable
4435 functions. Run Qbuffer_list_update_hook if allowed.
4436 (Frecord_buffer, Funrecord_buffer): New functions.
4437 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4438 Move switch-to-buffer to window.el.
4439 (bury-buffer): Move to window.el.
4440 (Vbuffer_list_update_hook): New variable.
4442 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4445 * window.h (resize_frame_windows): Move up in code.
4446 (Fwindow_frame): Remove EXFUN.
4447 (replace_buffer_in_all_windows): Remove prototype.
4448 (replace_buffer_in_windows_safely): Add prototype.
4450 * window.c: Declare Qdelete_window static again. Move down
4451 declaration of select_count.
4452 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4453 (Fother_window): Move to window.el.
4454 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4455 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4456 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4458 (replace_buffer_in_windows): Implement by calling
4459 Qreplace_buffer_in_windows.
4460 (replace_buffer_in_all_windows): Remove with some functionality
4461 moved into replace_buffer_in_windows_safely.
4462 (replace_buffer_in_windows_safely): New function.
4463 (select_window_norecord, select_frame_norecord): Move in front
4464 of run_window_configuration_change_hook. Remove now obsolete
4466 (Fset_window_buffer): Rewrite doc-string.
4467 Call Qrecord_window_buffer.
4468 (keys_of_window): Move binding for other-window to window.el.
4470 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4472 * dispextern.h (struct image): Replace data member, whose int_val
4473 and ptr_val fields were not used by anything, with a single
4476 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4477 (gif_clear_image, gif_load, imagemagick_load_image)
4478 (gs_clear_image, gs_load): Callers changed.
4480 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4482 * buffer.h: Include <time.h>, for time_t.
4483 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4485 Fix minor problems found by static checking.
4487 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4489 Make identifiers static if they are not used in other modules.
4490 * data.c (Qcompiled_function, Qframe, Qvector):
4491 * image.c (QimageMagick, Qsvg):
4492 * minibuf.c (Qmetadata):
4493 * window.c (resize_window_check, resize_root_window): Now static.
4494 * window.h (resize_window_check, resize_root_window): Remove decls.
4496 * window.c (window_deletion_count, delete_deletable_window):
4498 (window_body_lines): Now static.
4499 (Fdelete_other_windows_internal): Mark vars as initialized.
4500 Make sure 'resize_failed' is initialized.
4501 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4502 (resize_window_apply): Remove unused local.
4503 * window.h (delete_deletable_window): Remove decl.
4505 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4506 (imagemagick_load_image): Fix pointer signedness problem by changing
4507 last arg from unsigned char * to char *. All uses changed.
4508 Also, fix a local for similar reasons.
4509 Remove unused locals. Remove locals to avoid shadowing.
4510 (fn_rsvg_handle_free): Remove; unused.
4511 (svg_load, svg_load_image): Fix pointer signedness problem.
4512 (imagemagick_load_image): Don't use garbage pointer image_wand.
4514 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4516 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4518 * image.c (gif_load): Fix omitted cast error introduced by
4521 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4523 * window.h (resize_proportionally, orig_total_lines)
4524 (orig_top_line): Remove from window structure.
4525 (set_window_height, set_window_width, change_window_heights)
4526 (Fdelete_window): Remove prototypes.
4527 (resize_frame_windows): Remove duplicate declaration.
4529 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4531 * window.h (resize_frame_windows, resize_window_check)
4532 (delete_deletable_window, resize_root_window)
4533 (resize_frame_windows): Declare prototypes.
4535 * window.c (resize_window_apply): Make definition be "static" to
4536 match the prototype.
4538 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4540 * window.c: Remove declarations of Qwindow_size_fixed,
4541 window_min_size_1, window_min_size_2, window_min_size,
4542 size_window, window_fixed_size_p, enlarge_window, delete_window.
4543 Remove static from declaration of Qdelete_window, it's
4544 temporarily needed by Fbury_buffer.
4545 (replace_window): Don't assign orig_top_line and
4547 (Fdelete_window, delete_window): Remove. Window deletion is
4548 handled by window.el.
4549 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4550 Replace Fdelete_window calls with calls to Qdelete_window.
4551 (Fdelete_other_windows): Remove. Deleting other windows is
4552 handled by window.el.
4553 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4554 handled in window.el.
4555 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4556 Window minimum sizes are handled in window.el.
4557 (shrink_windows, size_window, set_window_height)
4558 (set_window_width, change_window_heights, window_height)
4559 (window_width, CURBEG, CURSIZE, enlarge_window)
4560 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4561 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4562 handled in window.el.
4563 (make_dummy_parent): Rename to make_parent_window and give it a
4564 second argument horflag.
4565 (make_window): Don't set resize_proportionally any more.
4566 (Fsplit_window): Remove. Windows are split in window.el.
4567 (save_restore_action, save_restore_orig_size)
4568 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4569 Resize mini windows in window.el.
4570 (grow_mini_window, shrink_mini_window): Implement by calling
4571 Qresize_root_window_vertically, resize_window_check and
4572 resize_window_apply.
4573 (saved_window, Fset_window_configuration, save_window_save):
4574 Do not handle orig_top_line, orig_total_lines, and
4575 resize_proportionally.
4576 (window_min_height, window_min_width): Move to window.el.
4577 (keys_of_window): Move bindings for delete-other-windows,
4578 split-window, delete-window and enlarge-window to window.el.
4580 * buffer.c: Temporarily extern Qdelete_window.
4581 (Fbury_buffer): Temporarily call Qdelete_window instead of
4582 Fdelete_window (Fbury_buffer will move to window.el soon).
4584 * frame.c (set_menu_bar_lines_1): Remove code handling
4585 orig_top_line and orig_total_lines.
4587 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4588 set_window_height but set heights directly.
4589 (change_frame_size_1): Use resize_frame_windows.
4591 * xdisp.c (init_xdisp): Don't use set_window_height but set
4594 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4595 Use resize_frame_windows instead of change_window_heights and run
4596 run_window_configuration_change_hook.
4598 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4599 instead of change_window_heights and run
4600 run_window_configuration_change_hook.
4602 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4604 * window.c (replace_window): Rename second argument REPLACEMENT to
4605 NEW. New third argument SETFLAG. Rewrite.
4606 (delete_window, make_dummy_parent): Call replace_window with
4608 (window_list_1): Move down in code.
4609 (run_window_configuration_change_hook): Move set_buffer part
4610 before select_frame_norecord part in order to unwind correctly.
4611 Rename count1 to count.
4612 (recombine_windows, delete_deletable_window, resize_root_window)
4613 (Fdelete_other_windows_internal)
4614 (Frun_window_configuration_change_hook, make_parent_window)
4615 (resize_window_check, resize_window_apply, Fresize_window_apply)
4616 (resize_frame_windows, Fsplit_window_internal)
4617 (Fdelete_window_internal, Fresize_mini_window_internal):
4619 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4621 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4623 * window.h (window): Add some new members to window structure -
4624 normal_lines, normal_cols, new_total, new_normal, clone_number,
4625 splits, nest, prev_buffers, next_buffers.
4626 (WINDOW_TOTAL_SIZE): Move here from window.c.
4627 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4629 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4631 (make_dummy_parent): Set new members of windows structure.
4632 (make_window): Move down in code. Handle new members of window
4634 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4635 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4636 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4637 (Fset_window_prev_buffers, Fwindow_next_buffers)
4638 (Fset_window_next_buffers, Fset_window_clone_number):
4640 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4641 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4643 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4644 Argument WINDOW can be now internal window too.
4645 (Fwindow_use_time): Move up in code.
4646 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4648 (Fset_window_configuration, saved_window)
4649 (Fcurrent_window_configuration, save_window_save): Handle new
4650 members of window structure.
4651 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4652 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4653 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4654 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4655 Qget_mru_window, Qresize_root_window,
4656 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4657 Qauto_buffer_name; staticpro them.
4659 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4661 * window.c (Fwindow_total_size, Fwindow_left_column)
4662 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4663 (Fwindow_list_1): New functions.
4664 (window_box_text_cols): Replace with window_body_cols.
4665 (Fwindow_width, Fscroll_left, Fscroll_right):
4666 Use window_body_cols instead of window_box_text_cols.
4667 (delete_window, Fset_window_configuration):
4668 Call delete_all_subwindows with window as argument.
4669 (delete_all_subwindows): Take a window as argument and not a
4671 (window_loop): Remove handling of GET_LRU_WINDOW and
4673 (Fget_lru_window, Fget_largest_window): Move to window.el.
4675 * window.h: Extern window_body_cols instead of
4676 window_box_text_cols. delete_all_subwindows now takes a
4677 Lisp_Object as argument.
4679 * indent.c (compute_motion, Fcompute_motion):
4680 Use window_body_cols instead of window_box_text_cols.
4682 * frame.c (delete_frame): Call delete_all_subwindows with root
4685 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4687 * fns.c (Fputhash): Document return value.
4689 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4691 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4693 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4695 Cons<->int and similar integer overflow fixes (Bug#8794).
4697 Check for overflow when converting integer to cons and back.
4698 * charset.c (Fdefine_charset_internal, Fdecode_char):
4699 Use cons_to_unsigned to catch overflow.
4700 (Fencode_char): Use INTEGER_TO_CONS.
4701 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4702 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4703 * data.c (long_to_cons, cons_to_long): Remove.
4704 (cons_to_unsigned, cons_to_signed): New functions.
4705 These signal an error for invalid or out-of-range values.
4706 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4707 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4708 * font.c (Ffont_variation_glyphs):
4709 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4710 * lisp.h: Include <intprops.h>.
4711 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4712 (cons_to_signed, cons_to_unsigned): New decls.
4713 (long_to_cons, cons_to_long): Remove decls.
4714 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4715 (Fprimitive_undo): Use CONS_TO_INTEGER.
4716 * xfns.c (Fx_window_property): Likewise.
4717 * xselect.c: Include <limits.h>.
4718 (x_own_selection, selection_data_to_lisp_data):
4719 Use INTEGER_TO_CONS.
4720 (x_handle_selection_request, x_handle_selection_clear)
4721 (x_get_foreign_selection, Fx_disown_selection_internal)
4722 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4723 (lisp_data_to_selection_data): Use cons_to_unsigned.
4724 (x_fill_property_data): Use cons_to_signed.
4725 Report values out of range.
4727 Check for buffer and string overflow more precisely.
4728 * buffer.h (BUF_BYTES_MAX): New macro.
4729 * lisp.h (STRING_BYTES_MAX): New macro.
4730 * alloc.c (Fmake_string):
4731 * character.c (string_escape_byte8):
4732 * coding.c (coding_alloc_by_realloc):
4733 * doprnt.c (doprnt):
4734 * editfns.c (Fformat):
4736 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4737 since they may not be the same number.
4738 * editfns.c (Finsert_char):
4739 * fileio.c (Finsert_file_contents):
4740 Likewise for BUF_BYTES_MAX.
4742 * image.c: Use ptrdiff_t, not int, for sizes.
4743 (slurp_file): Switch from int to ptrdiff_t.
4745 (slurp_file): Check that file size fits in both size_t (for
4746 malloc) and ptrdiff_t (for sanity and safety).
4748 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4749 if b->modtime has its maximal value.
4751 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4753 Don't assume time_t can fit into int.
4754 * buffer.h (struct buffer.modtime): Now time_t, not int.
4755 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4756 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4758 Minor fixes for signed vs unsigned integers.
4759 * character.h (MAYBE_UNIFY_CHAR):
4760 * charset.c (maybe_unify_char):
4761 * keyboard.c (read_char, reorder_modifiers):
4762 XINT -> XFASTINT, since the integer must be nonnegative.
4763 * ftfont.c (ftfont_spec_pattern):
4764 * keymap.c (access_keymap, silly_event_symbol_error):
4765 XUINT -> XFASTINT, since the integer must be nonnegative.
4766 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4767 since it makes no difference and we prefer signed.
4768 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4769 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4772 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4774 * window.h (Fwindow_frame): Declare.
4776 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4778 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4779 (SPARE_MEMORY): Always define.
4780 (LARGE_REQUEST): Remove.
4781 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4783 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4785 * lisp.h: Move EXFUNS for Fframe_root_window,
4786 Fframe_first_window and Fset_frame_selected_window to window.h.
4788 * window.h: Move EXFUNS for Fframe_root_window,
4789 Fframe_first_window and Fset_frame_selected_window here from
4792 * frame.c (Fwindow_frame, Fframe_first_window)
4793 (Fframe_root_window, Fframe_selected_window)
4794 (Fset_frame_selected_window): Move to window.c.
4795 (Factive_minibuffer_window): Move to minibuf.c.
4796 (Fother_visible_frames_p): New function.
4798 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4800 * window.c (decode_window, decode_any_window): Move up in code.
4801 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4802 (inhibit_frame_unsplittable): Remove unused variable.
4803 (Fwindow_buffer): Move up and rewrite doc-string.
4804 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4805 (Fwindow_prev): New functions.
4806 (Fwindow_frame): Move here from frame.c. Accept any window as
4808 (Fframe_root_window, Fframe_first_window)
4809 (Fframe_selected_window): Move here from frame.c. Accept frame
4810 or arbitrary window as argument. Update doc-strings.
4811 (Fminibuffer_window): Move up in code.
4812 (Fwindow_minibuffer_p): Move up in code and simplify.
4813 (Fset_frame_selected_window): Move here from frame.c.
4815 (Fselected_window, select_window, Fselect_window): Move up in
4816 code. Minor doc-string fixes.
4818 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4820 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4821 Do not assume that spare memory exists; that assumption is valid
4822 only if SYSTEM_MALLOC.
4823 (LARGE_REQUEST): New macro, so that the issue of large requests
4824 is separated from the issue of spare memory.
4826 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4828 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4831 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4833 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4836 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4838 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4840 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4842 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4843 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4845 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4847 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4849 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4851 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4852 (x_clipboard_manager_save): Add return value.
4853 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4855 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4856 Obey Vx_select_enable_clipboard_manager. Catch errors in
4857 x_clipboard_manager_save (Bug#8779).
4858 (Vx_select_enable_clipboard_manager): New variable.
4859 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4861 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4863 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4865 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4867 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4868 in the current matrix if keep_current_p is non-zero.
4870 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4872 * bidi.c (bidi_level_of_next_char): Fix last change.
4874 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4876 Support bidi reordering of text covered by display properties.
4878 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4879 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4880 (bidi_cache_search, bidi_cache_iterator_state)
4881 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4882 (bidi_level_of_next_char, bidi_move_to_visually_next):
4883 Support character positions inside a run of characters covered by a
4885 (bidi_paragraph_init, bidi_resolve_explicit_1)
4886 (bidi_level_of_next_char): Call bidi_fetch_char and
4887 bidi_fetch_char_advance instead of FETCH_CHAR and
4889 (bidi_init_it): Initialize new members.
4890 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4892 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4893 instead of using explicit *_CHAR codes.
4894 (bidi_resolve_explicit, bidi_resolve_weak):
4895 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4896 bidirectional text is supported only in multibyte buffers.
4897 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4898 it to initialize the frame_window_p member of struct bidi_it.
4899 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4900 (bidi_resolve_explicit, bidi_resolve_weak)
4901 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4902 bidi_it->nchars is non-positive.
4903 (bidi_level_of_next_char): Don't try to lookup the cache for the
4904 next/previous character if nothing is cached there yet, or if we
4905 were just reseat()'ed to a new position.
4907 * xdisp.c (set_cursor_from_row): Set start and stop points
4908 according to the row's direction when priming the loop that looks
4909 for the glyph on which to display cursor.
4910 (single_display_spec_intangible_p): Function deleted.
4911 (display_prop_intangible_p): Reimplement to call
4912 handle_display_spec instead of single_display_spec_intangible_p.
4913 Accept 3 additional arguments needed by handle_display_spec.
4914 This fixes incorrect cursor motion across display property with complex
4915 values: lists, `(when COND...)' forms, etc.
4916 (single_display_spec_string_p): Support property values that are
4917 lists with the argument STRING its top-level element.
4918 (display_prop_string_p): Fix the condition for processing a
4919 property that is a list to be consistent with handle_display_spec.
4920 (handle_display_spec): New function, refactored from the
4921 last portion of handle_display_prop.
4922 (compute_display_string_pos): Accept additional argument
4923 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4924 value of a `display' property is a "replacing spec".
4925 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4926 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4927 the display property, but just return a value indicating whether
4928 the display property will replace the characters it covers.
4929 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4930 frame_window_p members of struct bidi_it.
4931 (compute_display_string_pos, compute_display_string_end):
4933 (push_it): Accept second argument POSITION, where pop_it should
4934 jump to continue iteration.
4935 (reseat_1): Initialize bidi_it.disp_pos.
4937 * keyboard.c (adjust_point_for_property): Adjust the call to
4938 display_prop_intangible_p to its new signature.
4940 * dispextern.h (struct bidi_it): New member frame_window_p.
4941 (bidi_init_it): Update prototypes.
4942 (display_prop_intangible_p): Update prototype.
4943 (compute_display_string_pos, compute_display_string_end):
4945 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4948 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4950 Malloc failure behavior now depends on size of allocation.
4951 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4952 * lisp.h: Change signatures accordingly.
4953 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4954 All callers changed. (Bug#8762)
4956 * gnutls.c: Use Emacs's memory allocators.
4957 Without this change, the gnutls library would invoke malloc etc.
4958 directly, which causes problems on non-SYNC_INPUT hosts, and which
4959 runs afoul of improving memory_full behavior. (Bug#8761)
4960 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4961 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4962 xfree instead of the default malloc, realloc, free.
4963 (Fgnutls_boot): No need to check for memory allocation failure,
4964 since xmalloc does that for us.
4966 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4967 * category.c (hash_get_category_set):
4968 * ccl.c (ccl_driver):
4969 * charset.c (Fdefine_charset_internal):
4970 * charset.h (struct charset.hash_index):
4971 * composite.c (get_composition_id, gstring_lookup_cache)
4972 (composition_gstring_put_cache):
4973 * composite.h (struct composition.hash_index):
4974 * dispextern.h (struct image.hash):
4975 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4976 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4977 (hashfn_equal, hashfn_user_defined, make_hash_table)
4978 (maybe_resize_hash_table, hash_lookup, hash_put)
4979 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4980 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4981 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4982 * image.c (make_image, search_image_cache, lookup_image)
4983 (xpm_put_color_table_h):
4984 * lisp.h (struct Lisp_Hash_Table):
4985 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4986 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4987 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4988 * alloc.c (allocate_vectorlike):
4989 Check for overflow in vector size calculations.
4990 * ccl.c (ccl_driver):
4991 Check for overflow when converting EMACS_INT to int.
4992 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4993 need to be updated by these changes.
4994 * fns.c (make_hash_table, maybe_resize_hash_table):
4995 Check for integer overflow with large hash tables.
4996 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4997 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4998 (SXHASH_REDUCE): New macro.
4999 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5000 Use it instead of discarding useful hash info with large hash values.
5001 (sxhash_float): New function.
5002 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5003 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5004 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5005 Rewrite to use FIXNUM_BITS, as this simplifies things.
5006 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5007 Adjust signatures to match updated version of code.
5008 (consing_since_gc): Now EMACS_INT, since a single hash table can
5009 use more than INT_MAX bytes.
5011 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5013 Make it possible to build with GCC-4.6+ -O2 -flto.
5015 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5017 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5019 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5020 Call minibuffer-inactive-mode.
5022 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5024 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5025 Update dependencies.
5027 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5029 * data.c (init_data): Remove code for UTS, this system is not
5032 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5034 Don't force ./temacs to start in terminal mode.
5036 * frame.c (make_initial_frame): Initialize faces in all cases, not
5037 only when CANNOT_DUMP is defined.
5038 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5040 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5042 * dispnew.c (add_window_display_history): Use const for the string
5043 pointer. Remove declaration, not needed.
5045 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5047 Use 'inline', not 'INLINE'.
5048 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5049 * alloc.c, fontset.c (INLINE): Remove.
5050 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5051 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5052 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5053 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5054 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5056 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5058 Make it possible to run ./temacs.
5060 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5061 syms_of_callproc does the same thing. Remove test for
5062 "initialized", do it in the caller.
5063 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5065 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5067 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5068 (read_minibuf): Use get_minibuffer.
5069 (syms_of_minibuf): Use DEFSYM.
5070 (Qmetadata): New var.
5071 * data.c (Qbuffer): Don't make it static.
5072 (syms_of_data): Use DEFSYM.
5074 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5076 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5077 (CCL_CODE_MIN): New macro.
5079 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5081 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5083 * eval.c (Qdebug): Now static.
5084 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5085 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5086 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5088 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5090 * image.c: Various fixes to ImageMagick code comments.
5091 (Fimagemagick_types): Doc fix.
5093 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5095 Minor fixes prompted by GCC 4.6.0 warnings.
5097 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5099 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5100 (x_clipboard_manager_save_all): Move extern decl to ...
5101 * xterm.h: ... here, so that it can be checked for consistency.
5103 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5105 * xselect.c (x_clipboard_manager_save_frame)
5106 (x_clipboard_manager_save_all): New functions.
5107 (Fx_clipboard_manager_save): Lisp function deleted.
5109 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5110 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5112 * xterm.h: Update prototype.
5114 2011-05-28 William Xu <william.xwl@gmail.com>
5116 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5119 2011-05-28 Jim Meyering <meyering@redhat.com>
5121 Avoid a sign-extension bug in crypto_hash_function.
5122 * fns.c (to_uchar): Define.
5123 (crypto_hash_function): Use it to convert some newly-signed
5124 variables to unsigned, to avoid sign-extension bugs. For example,
5125 without this change, (md5 "truc") would evaluate to
5126 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5127 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5128 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5130 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5132 Integer overflow fixes.
5134 * dbusbind.c: Serial number integer overflow fixes.
5135 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5136 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5137 to hold a serial number that is too large for a fixnum.
5138 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5139 Check for serial numbers out of range. Decode any serial number
5140 that was so large that it became a float. (Bug#8722)
5142 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5143 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5144 Use XFASTINT rather than XUINT when numbers are nonnegative.
5145 (xd_append_arg, Fdbus_method_return_internal):
5146 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5147 arguments, check that Lisp number is nonnegative, rather than
5148 silently wrapping negative numbers around. (Bug#8722)
5149 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5152 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5154 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5156 ccl: add integer overflow checks
5157 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5158 (IN_INT_RANGE): New macros.
5159 (ccl_driver): Use them to check for integer overflow when
5160 decoding a CCL program. Many of the new checks are whether XINT (x)
5161 fits in int; it doesn't always, on 64-bit hosts. The new version
5162 doesn't catch all possible integer overflows, but it's an
5163 improvement. (Bug#8719)
5165 * alloc.c (make_event_array): Use XINT, not XUINT.
5166 There's no need for unsigned here.
5168 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5169 This follows up to the 2011-05-06 change that substituted uintptr_t
5170 for EMACS_INT. This case wasn't caught back then.
5172 Rework Fformat to avoid integer overflow issues.
5173 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5174 now (part of C89). Include <verify.h>.
5175 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5176 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5177 (Fformat): Avoid the prepass trying to compute sizes; it was only
5178 approximate and thus did not catch overflow reliably. Instead, walk
5179 through the format just once, formatting and computing sizes as we go,
5180 checking for integer overflow at every step, and allocating a larger
5181 buffer as needed. Keep track separately whether the format is
5182 multibyte. Keep only the most-recently calculated precision, rather
5183 than them all. Record whether each argument has been converted to
5184 string. Use EMACS_INT, not int, for byte and char and arg counts.
5185 Support field widths and precisions larger than INT_MAX. Avoid
5186 sprintf's undefined behavior with conversion specifications such as %#d
5187 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5188 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5189 formatting out-of-range floating point numbers with int
5192 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5194 * data.c: Avoid integer truncation in expressions involving floats.
5195 * data.c: Include <intprops.h>.
5196 (arith_driver): When there's an integer overflow in an expression
5197 involving floating point, convert the integers to floating point
5198 so that the resulting value does not suffer from catastrophic
5199 integer truncation. For example, on a 64-bit host (* 4
5200 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5201 Do not rely on undefined behavior after integer overflow.
5203 merge count_size_as_multibyte, parse_str_to_multibyte
5204 * character.c, character.h (count_size_as_multibyte):
5205 Rename from parse_str_to_multibyte; all uses changed.
5206 Check for integer overflow.
5207 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5208 since it's now a duplicate of the other. This is more of
5209 a character than a buffer op, so better that it's in character.c.
5210 * fns.c, print.c: Adjust to above changes.
5212 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5214 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5216 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5218 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5219 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5220 (x_clipboard_manager_save): Now static.
5221 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5223 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5224 (crypto_hash_function): Now static.
5225 Fix pointer signedness problems. Avoid unnecessary initializations.
5227 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5229 * termhooks.h (Vselection_alist): Make it terminal-local.
5231 * terminal.c (create_terminal): Initialize it.
5233 * xselect.c: Support for clipboard managers.
5234 (Vselection_alist): Move to termhooks.h as terminal-local var.
5235 (LOCAL_SELECTION): New macro.
5236 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5237 (symbol_to_x_atom): Remove gratuitous arg.
5238 (x_handle_selection_request, lisp_data_to_selection_data)
5239 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5240 (x_own_selection, x_get_local_selection, x_convert_selection):
5241 New arg, specifying work frame. Use terminal-local Vselection_alist.
5242 (some_frame_on_display): Delete unused function.
5243 (Fx_own_selection_internal, Fx_get_selection_internal)
5244 (Fx_disown_selection_internal, Fx_selection_owner_p)
5245 (Fx_selection_exists_p): New optional frame arg.
5246 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5247 (x_handle_selection_clear): Don't treat other terminals with the
5248 same keyboard specially. Use the terminal-local Vselection_alist.
5249 (x_clear_frame_selections): Use Frun_hook_with_args.
5251 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5253 * xterm.h: Add support for those atoms.
5255 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5257 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5258 (converted_selections, conversion_fail_tag): New global variables.
5259 (x_selection_request_lisp_error): Free the above.
5260 (x_get_local_selection): Remove unnecessary code.
5261 (x_reply_selection_request): Args changed; handle arbitrary array
5262 of converted selections stored in converted_selections.
5263 Separate the XChangeProperty and SelectionNotify steps.
5264 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5265 (x_convert_selection): New function.
5266 (x_handle_selection_event): Simplify.
5267 (x_get_foreign_selection): Don't ignore incoming requests while
5268 waiting for an answer; this will fail when we implement
5269 SAVE_TARGETS, and seems unnecessary anyway.
5270 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5271 (Vx_sent_selection_functions): Doc fix.
5273 2011-05-26 Leo Liu <sdl.web@gmail.com>
5275 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5277 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5279 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5281 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5282 for fringe update if it has periodic bitmap.
5283 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5284 and fringe_bitmap_periodic_p.
5286 * fringe.c (get_fringe_bitmap_data): New function.
5287 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5288 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5289 row. Mark glyph row for fringe update if periodicity changed.
5291 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5292 for fringe update unless it has periodic bitmap.
5294 2011-05-25 Kenichi Handa <handa@m17n.org>
5296 * xdisp.c (get_next_display_element): Set correct it->face_id for
5297 a static composition.
5299 2011-05-24 Leo Liu <sdl.web@gmail.com>
5302 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5304 * fns.c (crypto_hash_function, Fsha1): New function.
5305 (Fmd5): Use crypto_hash_function.
5306 (syms_of_fns): Add Ssha1.
5308 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5310 * gnutls.c: Remove unused macros.
5311 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5312 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5313 Remove macros that are defined and never used.
5314 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5316 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5318 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5319 (Fx_get_selection_internal): Minor cleanup.
5320 (Fx_own_selection_internal): Rename arguments for consistency with
5323 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5325 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5327 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5329 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5331 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5333 * dispnew.c (scrolling_window): Don't exclude the case that the
5334 last enabled row in the desired matrix touches the bottom boundary.
5336 2011-05-21 Glenn Morris <rgm@gnu.org>
5338 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5339 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5340 and add some more files.
5342 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5344 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5345 report_file_error introduced by the change from 2011-05-07.
5347 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5349 * systime.h (Time): Define only if emacs is defined.
5350 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5351 where the include path doesn't have X11/X.h by default. See
5352 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5354 2011-05-20 Kenichi Handa <handa@m17n.org>
5356 * composite.c (find_automatic_composition): Fix previous change.
5358 2011-05-20 Glenn Morris <rgm@gnu.org>
5360 * lisp.mk: New file, split from Makefile.in.
5361 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5362 (shortlisp): Remove.
5363 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5365 2011-05-19 Glenn Morris <rgm@gnu.org>
5367 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5368 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5369 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5370 (lisp): Set the order to that of loadup.el.
5371 (shortlisp): Make it a copy of $lisp.
5372 (SOME_MACHINE_LISP): Remove.
5373 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5374 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5376 2011-05-18 Kenichi Handa <handa@m17n.org>
5378 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5379 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5380 (find_automatic_composition): Mostly rewrite for efficiency.
5382 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5384 * makefile.w32-in: Update dependencies.
5386 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5388 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5389 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5391 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5393 Fix some integer overflow issues, such as string length overflow.
5395 * insdel.c (count_size_as_multibyte): Check for string overflow.
5397 * character.c (lisp_string_width): Check for string overflow.
5398 Use EMACS_INT, not int, for string indexes and lengths; in
5399 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5400 the resulting string length overflows an EMACS_INT; instead,
5401 report a string overflow if no precision given. When checking for
5402 precision exhaustion, use a check that cannot possibly have
5403 integer overflow. (Bug#8675)
5404 * character.h (lisp_string_width): Adjust to new signature.
5406 * alloc.c (string_overflow): New function.
5407 (Fmake_string): Use it. This doesn't change behavior, but saves
5408 a few bytes and will simplify future changes.
5409 * character.c (string_escape_byte8): Likewise.
5410 * lisp.h (string_overflow): New decl.
5412 Fixups, following up to the user-interface timestamp change.
5413 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5414 for UI timestamps, instead of unsigned long.
5415 * msdos.c (mouse_get_pos): Likewise.
5416 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5417 * w32gui.h (Time): Define by including "systime.h" rather than by
5418 declaring it ourselves. (Bug#8664)
5420 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5421 * image.c (clear_image_cache): Likewise.
5423 * term.c (term_mouse_position): Don't assume time_t wraparound.
5425 Be more systematic about user-interface timestamps.
5426 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5427 and sometimes 'EMACS_UINT', to represent these timestamps.
5428 This change causes it to use 'Time' uniformly, as that's what X uses.
5429 This makes the code easier to follow, and makes it easier to catch
5430 integer overflow bugs such as Bug#8664.
5431 * frame.c (Fmouse_position, Fmouse_pixel_position):
5432 Use Time, not unsigned long, for user-interface timestamps.
5433 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5434 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5435 * keyboard.h (last_event_timestamp): Likewise.
5436 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5437 * menu.h (xmenu_show): Likewise.
5438 * term.c (term_mouse_position): Likewise.
5439 * termhooks.h (struct input_event.timestamp): Likewise.
5440 (struct terminal.mouse_position_hook): Likewise.
5441 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5442 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5443 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5444 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5446 * menu.h, termhooks.h: Include "systime.h", for Time.
5448 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5449 Don't assume that the difference between two unsigned long values
5450 can fit into an integer. At this point, we know button_down_time
5451 <= event->timestamp, so the difference must be nonnegative, so
5452 there's no need to cast the result if double-click-time is
5453 nonnegative, as it should be; check that it's nonnegative, just in
5454 case. This bug is triggered when events are more than 2**31 ms
5455 apart (about 25 days). (Bug#8664)
5457 * xselect.c (last_event_timestamp): Remove duplicate decl.
5458 (x_own_selection): Remove needless cast to unsigned long.
5460 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5461 that always fit in int. Use a sentinel instead of a counter, to
5462 avoid a temp and to allay GCC's concerns about possible int overflow.
5463 * frame.h (struct frame): Use int for menu_bar_items_used
5464 instead of EMACS_INT, since it always fits in int.
5466 * menu.c (grow_menu_items): Check for int overflow.
5468 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5470 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5471 Before, the code was not consistent. These values cannot exceed
5472 2**31 - 1 so there's no need to make them unsigned.
5473 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5474 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5475 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5477 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5479 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5480 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5481 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5482 presumably because the widths might not match.
5484 * window.c (size_window): Avoid needless test at loop start.
5486 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5488 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5490 2011-05-12 Drew Adams <drew.adams@oracle.com>
5492 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5494 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5496 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5497 `width' to `bar_area_x' and `bar_area_width', respectively.
5498 (x_scroll_run): Take account of fringe background extension.
5500 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5501 Rename local vars `left' and `width' to `bar_area_x' and
5502 `bar_area_width', respectively.
5503 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5504 background extension.
5506 2011-05-10 Jim Meyering <meyering@redhat.com>
5508 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5510 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5512 * image.c (Finit_image_library): Return t for built-in image types,
5513 like pbm and xbm. (Bug#8640)
5515 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5517 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5519 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5521 * w32console.c (Fset_screen_color): Doc fix.
5522 (Fget_screen_color): New function.
5523 (syms_of_ntterm): Defsubr it.
5525 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5526 unlink the temporary file if Fcall_process didn't create it in the
5528 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5529 child process will be redirected to a file specified with `:file'.
5530 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5531 cue to call_process_cleanup not to close that handle.
5533 2011-05-07 Ben Key <bkey76@gmail.com>
5535 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5536 one of two shell specific rules, either bootstrap-temacs-CMD or
5537 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5538 to the previous implementation of the bootstrap-temacs rule.
5539 The bootstrap-temacs-CMD rule is similar to the previous
5540 implementation of the bootstrap-temacs rule except that it
5541 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5544 These changes, along with some changes to nt/configure.bat,
5545 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5546 earlier fix to add support for --cflags and --ldflags options
5547 that include quotes so that it works whether make uses cmd or
5550 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5552 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5553 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5555 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5556 a string. Handle both cases.
5557 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5558 (Fdbus_register_method): Use Qinvalid_function.
5560 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5562 * makefile.w32-in: Update dependencies.
5563 (LISP_H): Add inttypes.h and stdin.h.
5564 (PROCESS_H): Add unistd.h.
5566 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5568 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5569 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5571 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5573 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5575 * term.c (vfatal): Remove stray call to va_end.
5576 It's not needed and the C Standard doesn't allow it here anyway.
5578 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5579 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5581 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5584 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5586 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5588 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5590 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5592 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5594 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5595 * charset.c (Fdefine_charset_internal): Don't initialize
5596 charset.code_space[15]. The value was garbage, on hosts with
5597 32-bit int (Bug#8600).
5599 * lread.c (read_integer): Be more consistent with string-to-number.
5600 Use string_to_number to do the actual conversion; this avoids
5601 rounding errors and fixes some other screwups. Without this fix,
5602 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5603 (digit_to_number): Move earlier, for benefit of read_integer.
5604 Return -1 if the digit is out of range for the base, -2 if it is
5605 not a digit in any supported base. (Bug#8602)
5607 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5609 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5610 to match comment at start of function. This also removes a
5611 GCC warning about overflow in a 32+64-bit port.
5613 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5615 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5616 Reported by Stefan Monnier in
5617 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5618 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5619 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5621 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5622 (EMACS_UINTPTR): Likewise, with uintptr_t.
5624 * lisp.h: Prefer 64-bit EMACS_INT if available.
5625 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5626 on 32-bit hosts that have 64-bit int, so that they can access
5628 However, temporarily disable this change unless the temporary
5629 symbol WIDE_EMACS_INT is defined.
5631 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5633 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5634 This removes an assumption that EMACS_INT and long are the same
5635 width as pointers. The assumption is true for Emacs porting targets
5636 now, but we want to make other targets possible.
5637 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5638 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5639 In the rest of the code, change types of integers that hold casted
5640 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5641 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5642 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5643 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5644 No need to cast type when ORing.
5645 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5646 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5647 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5648 assume EMACS_INT is the same width as char *.
5649 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5650 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5651 Remove no-longer-needed casts.
5652 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5653 (xg_tool_bar_help_callback, xg_make_tool_item):
5654 Use EMACS_INTPTR to hold an integer
5655 that will be cast to void *; this can avoid a GCC warning
5656 if EMACS_INT is not the same width as void *.
5657 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5658 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5659 (current_message_1, set_message_1):
5660 Use a local to convert to proper width without a cast.
5661 * xmenu.c (dialog_selection_callback): Likewise.
5663 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5664 Also, don't assume VALBITS / RAND_BITS is less than 5,
5665 and don't rely on undefined behavior when shifting a 1 left into
5667 * lisp.h (get_random): Change signature to match.
5669 * lread.c (hash_string): Use size_t, not int, for hash computation.
5670 Normally we prefer signed values; but hashing is special, because
5671 it's better to use unsigned division on hash table sizes so that
5672 the remainder is nonnegative. Also, size_t is the natural width
5673 for hashing into memory. The previous code used 'int', which doesn't
5674 retain enough info to hash well into very large tables.
5675 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5677 * dbusbind.c: Don't possibly lose pointer info when converting.
5678 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5679 Use XPNTR rather than XHASH, so that the high-order bits of
5680 the pointer aren't lost when converting through void *.
5682 * eval.c (Fautoload): Don't double-shift a pointer.
5684 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5686 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5688 * gnutls.c (DEF_GNUTLS_FN):
5689 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5691 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5693 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5696 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5698 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5699 New version that can reserve upto 2GB of heap space.
5701 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5703 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5705 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5707 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5708 `gnutls_certificate_set_x509_key_file'.
5710 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5712 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5713 Update dependencies.
5715 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5717 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5718 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5719 Remove unused parameter `fildes'.
5720 * process.c (read_process_output, send_process): Don't pass it.
5722 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5724 Fix previous change: the library cache is defined in w32.c.
5725 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5726 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5728 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5730 Implement dynamic loading of GnuTLS on Windows.
5732 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5733 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5734 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5737 * gnutls.c (Qgnutls_dll): Define.
5738 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5739 (gnutls_*): Declare function pointers.
5740 (init_gnutls_functions): New function to initialize function pointers.
5741 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5742 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5743 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5744 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5745 (emacs_gnutls_write, emacs_gnutls_read)
5746 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5747 (Fgnutls_available_p): New function.
5748 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5749 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5750 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5752 * image.c: Include w32.h.
5753 (Vimage_type_cache): Delete.
5754 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5755 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5756 (w32_delayed_load): Move to w32.c.
5758 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5760 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5761 (w32_delayed_load): Move from image.c. When loading a library, record
5762 its filename in the :loaded-from property of the library id.
5763 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5764 Initialize and staticpro them.
5765 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5767 * process.c: Include lisp.h before w32.h, not after.
5768 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5769 instead of gnutls_record_check_pending.
5771 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5773 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5775 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5776 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5779 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5781 * xterm.c (x_set_frame_alpha): Do not set property on anything
5782 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5784 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5786 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5788 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5790 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5791 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5792 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5793 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5794 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5795 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5796 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5797 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5798 (Qgnutls_bootprop_callbacks_verify): Make static.
5800 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5802 * callproc.c: Indentation fixup.
5804 * sysdep.c (wait_for_termination_1): Make static.
5805 (wait_for_termination, interruptible_wait_for_termination):
5806 Move after wait_for_termination_1.
5808 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5810 * sysdep.c (interruptible_wait_for_termination): New function
5811 which is like wait_for_termination, but allows keyboard
5814 * callproc.c (Fcall_process): Add (:file "file") as an option for
5816 (Fcall_process_region): Ditto.
5818 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5820 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5821 rather than `XVECTOR (FOO)->size'.
5823 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5824 inttypes.h, as a gnulib replacement is used if it not available in
5827 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5829 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5830 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5831 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5833 * coding.c (coding_alloc_by_realloc): Error out if destination
5834 will grow beyond MOST_POSITIVE_FIXNUM.
5835 (decode_coding_emacs_mule): Abort if there isn't enough place in
5836 charbuf for the composition carryover bytes. Reserve an extra
5837 space for up to 2 characters produced in a loop.
5838 (decode_coding_iso_2022): Abort if there isn't enough place in
5839 charbuf for the composition carryover bytes.
5841 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5843 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5844 aborting when %lld or %lll format is passed.
5845 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5846 %llo or %llx format is passed. (Bug#8545)
5848 * window.c (window_scroll_line_based): Use a marker instead of
5849 simple variables to record original value of point. (Bug#7952)
5851 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5852 produced by %s or %c overflows available buffer space. (Bug#8545)
5854 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5856 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5857 (SIZE_MAX): Move defn after all includes, as they might #define it.
5859 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5861 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5863 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5865 * keyboard.c (Qdelayed_warnings_hook): Define.
5866 (command_loop_1): Run `delayed-warnings-hook'
5867 if Vdelayed_warnings_list is non-nil.
5868 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5869 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5871 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5873 * doprnt.c (doprnt): Don't return value smaller than the buffer
5874 size if the message was truncated. (Bug#8545).
5876 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5878 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5879 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5881 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5883 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5885 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5887 * makefile.w32-in: Update dependencies.
5889 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5891 Improve `doprnt' and its usage. (Bug#8545)
5892 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5893 `format_end'. Remove support for %l as a conversion specifier.
5894 Don't use xrealloc. Improve diagnostics when the %l size modifier
5895 is used. Update the commentary.
5897 * eval.c (verror): Simplify calculation of size_t.
5899 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5902 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5904 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5907 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5909 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5910 This makes this file independent of the recent pseudovector change.
5912 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5914 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5916 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5917 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5918 Remove unused local.
5919 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5921 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5922 GCC 4.6.0 optimizes based on type-based alias analysis.
5923 For example, if b is of type struct buffer * and v of type struct
5924 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5925 != &v->size, and therefore "v->size = 1; b->size = 2; return
5926 v->size;" must therefore return 1. This assumption is incorrect
5927 for Emacs, since it type-puns struct Lisp_Vector * with many other
5928 types. To fix this problem, this patch adds a new type struct
5929 vectorlike_header that documents the constraints on layout of vectors
5930 and pseudovectors, and helps optimizing compilers not get fooled
5931 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5932 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5933 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5935 (XSETPVECTYPE): Rewrite in terms of new macro.
5936 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5937 This is a bit clearer, and further avoids the possibility of
5938 undesirable aliasing.
5939 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5940 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5941 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5942 since Lisp_Subr is a special case (no "next" field).
5943 (ASIZE): Now uses header.size rather than size.
5944 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5945 to avoid the hassle of writing XVECTOR (foo)->header.size.
5946 (struct vectorlike_header): New type.
5947 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5948 object, to help avoid aliasing.
5949 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5950 (SUBRP): Likewise, since Lisp_Subr is a special case.
5951 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5952 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5953 (struct Lisp_Hash_Table): Combine first two members into a single
5954 struct vectorlike_header member. All uses of "size" and "next" members
5955 changed to be "header.size" and "header.next".
5956 * buffer.h (struct buffer): Likewise.
5957 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5958 * frame.h (struct frame): Likewise.
5959 * process.h (struct Lisp_Process): Likewise.
5960 * termhooks.h (struct terminal): Likewise.
5961 * window.c (struct save_window_data, struct saved_window): Likewise.
5962 * window.h (struct window): Likewise.
5963 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5964 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5965 * buffer.c (init_buffer_once): Likewise.
5966 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5968 * process.c (Fformat_network_address): Use local var for size,
5971 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5973 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5974 * data.c (atof): Remove decl; no longer used or needed.
5975 (digit_to_number): Move to lread.c.
5976 (Fstring_to_number): Use new string_to_number function, to be
5977 consistent with how the Lisp reader treats infinities and NaNs.
5978 Do not assume that floating-point numbers represent EMACS_INT
5979 without losing information; this is not true on most 64-bit hosts.
5980 Avoid double-rounding errors, by insisting on integers when
5981 parsing non-base-10 numbers, as the documentation specifies.
5982 * lisp.h (string_to_number): New decl, replacing ...
5983 (isfloat_string): Remove.
5984 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5985 (read1): Do not accept +. and -. as integers; this
5986 appears to have been a coding error. Similarly, do not accept
5987 strings like +-1e0 as floating point numbers. Do not report
5988 overflow for integer overflows unless the base is not 10 which
5989 means we have no simple and reliable way to continue.
5990 Break out the floating-point parsing into a new
5991 function string_to_number, so that Fstring_to_number parses
5992 floating point numbers consistently with the Lisp reader.
5993 (digit_to_number): Move here from data.c. Make it static inline.
5994 (E_CHAR, EXP_INT): Remove, replacing with ...
5995 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5996 (string_to_number): New function, replacing isfloat_string.
5997 This function checks for valid syntax and produces the resulting
5998 Lisp float number too. Rework it so that string-to-number
5999 no longer mishandles examples like "1.0e+". Use strtoumax,
6000 so that overflow for non-base-10 numbers is reported only when
6001 there's no portable and simple way to convert to floating point.
6003 * textprop.c (set_text_properties_1): Rewrite for clarity,
6004 and to avoid GCC warning about integer overflow.
6006 * intervals.h (struct interval): Use EMACS_INT for members
6007 where EMACS_UINT might cause problems. See
6008 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6009 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6010 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6012 (offset_intervals): Tell GCC not to worry about length overflow
6013 when negating a negative length.
6015 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6016 (overrun_check_free): Likewise.
6018 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6019 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6022 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6023 (gnutls_make_error): Rename local to avoid shadowing.
6024 (gnutls_emacs_global_deinit): ifdef out; not used.
6025 (Fgnutls_boot): Use const for pointer to readonly storage.
6026 Comment out unused local. Fix pointer signedness problems.
6028 * lread.c (openp): Don't stuff size_t into an 'int'.
6029 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6030 about possible signed overflow.
6032 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6033 (GDK_KEY_g): Don't define if already defined.
6034 (xg_prepare_tooltip): Avoid pointer signedness problem.
6035 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6037 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6038 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6040 * xfns.c (Fx_window_property): Simplify a bit,
6041 to make a bit faster and to avoid GCC 4.6.0 warning.
6042 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6044 * fns.c (internal_equal): Don't assume size_t fits in int.
6046 * alloc.c (compact_small_strings): Tighten assertion a little.
6048 Replace pEd with more-general pI, and fix some printf arg casts.
6049 * lisp.h (pI): New macro, generalizing old pEd macro to other
6050 conversion specifiers. For example, use "...%"pI"d..." rather
6051 than "...%"pEd"...".
6052 (pEd): Remove. All uses replaced with similar uses of pI.
6053 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6054 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6055 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6056 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6057 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6058 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6059 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6061 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6062 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6063 * print.c (safe_debug_print, print_object): Likewise.
6064 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6066 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6067 avoiding the 0 flag, which is not portable.
6068 * process.c (Fmake_network_process): Use pI to avoid cast.
6069 * region-cache.c (pp_cache): Likewise.
6070 * xdisp.c (decode_mode_spec): Likewise.
6071 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6072 behavior on 64-bit hosts with printf arg.
6073 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6074 (x_stop_queuing_selection_requests): Likewise.
6075 (x_get_window_property): Don't truncate byte count to an 'int'
6078 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6079 here, since it parses constructs like leading '-' and spaces,
6080 which are not wanted; and it overflows with large numbers.
6081 Instead, simply match F[0-9]+, which is what is wanted anyway.
6083 * alloc.c: Remove unportable assumptions about struct layout.
6084 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6085 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6086 (allocate_vectorlike, make_pure_vector): Use the new macros,
6087 plus offsetof, to remove unportable assumptions about struct layout.
6088 These assumptions hold on all porting targets that I know of, but
6089 they are not guaranteed, they're easy to remove, and removing them
6090 makes further changes easier.
6092 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6093 This doesn't fix a bug but makes the code clearer.
6094 (string_overrun_cookie): Now const. Use initializers that
6095 don't formally overflow signed char, to avoid warnings.
6096 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6097 can cause Emacs to crash when string overrun checking is enabled.
6098 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6099 multiple of sizeof (EMACS_INT); it need not be, if
6100 alignof(EMACS_INT) < sizeof (EMACS_INT).
6101 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6103 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6105 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6107 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6109 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6110 supposed to be handshaking. (Bug#8556)
6111 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6113 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6115 * lisp.h (Qdebug): List symbol.
6116 * eval.c (Qdebug): Restore global linkage.
6117 * keyboard.c (debug-on-event): New variable.
6118 (handle_user_signal): Break into debugger when debug-on-event
6119 matches the current signal symbol.
6121 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6123 * alloc.c (check_sblock, check_string_bytes)
6124 (check_string_free_list): Convert to standard C.
6126 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6128 * w32.c (emacs_gnutls_push): Fix typo.
6130 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6132 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6133 "cast to pointer from integer of different size".
6135 Improve doprnt and its use in verror. (Bug#8545)
6136 * doprnt.c (doprnt): Document the set of format control sequences
6137 supported by the function. Use SAFE_ALLOCA instead of always
6140 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6141 is one byte too soon. Don't use xrealloc; instead xfree and
6144 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6146 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6149 * gnutls.c: Renamed global_initialized to
6150 gnutls_global_initialized. Added internals for the
6151 :verify-hostname-error, :verify-error, and :verify-flags
6152 parameters of `gnutls-boot' and documented those parameters in the
6153 docstring. Start callback support.
6154 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6155 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6156 on error. Return error code.
6157 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6158 (emacs_gnutls_read): Likewise.
6159 (Fgnutls_boot): Return handshake error code.
6160 (emacs_gnutls_handle_error): New function.
6161 (wsaerror_to_errno): Likewise.
6163 * w32.h (emacs_gnutls_pull): Add prototype.
6164 (emacs_gnutls_push): Likewise.
6166 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6167 (emacs_gnutls_push): Likewise.
6169 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6171 * process.c (wait_reading_process_output): Check if GnuTLS
6172 buffered some data internally if no FDs are set for TLS
6175 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6176 (LIBS): Link to USER_LIBS.
6177 ($(BLD)/gnutls.$(0)): New target.
6179 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6181 * xdisp.c (handle_single_display_spec): Rename the
6182 display_replaced_before_p argument into display_replaced_p, to
6183 make it consistent with the commentary. Fix typos in the
6186 * textprop.c (syms_of_textprop): Remove dead code.
6187 (copy_text_properties): Delete obsolete commentary about an
6188 interface that was deleted long ago. Fix typos in the description
6191 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6192 to changes in oldXMenu/XMenu.h from 2011-04-16.
6193 <menu_help_message, prev_menu_help_message>: Constify.
6194 (IT_menu_make_room): menu->help_text is now `const char **';
6197 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6198 to changes in oldXMenu/XMenu.h from 2011-04-16.
6199 (struct XMenu): Declare `help_text' `const char **'.
6201 * xfaces.c <Qunspecified>: Make extern again.
6203 * syntax.c: Include sys/types.h before including regex.h, as
6206 * doc.c (get_doc_string): Improve the format passed to `error'.
6208 * doprnt.c (doprnt): Improve commentary.
6210 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6212 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6215 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6216 changes in globals.h immediately force recompilation.
6217 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6218 $(CURDIR)/s/ms-w32.h.
6219 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6221 * character.c (Fchar_direction): Function deleted.
6222 (syms_of_character): Don't defsubr it.
6223 <char-direction-table>: Deleted.
6225 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6227 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6228 * doprnt.c: Include limits.h.
6229 (SIZE_MAX): New macro.
6230 (doprnt): Return a size_t value. 2nd arg is now size_t.
6231 Many local variables are now size_t instead of int or unsigned.
6232 Improve overflow protection. Support `l' modifier for integer
6233 conversions. Support %l conversion. Don't assume an EMACS_INT
6234 argument for integer conversions and for %c.
6236 * lisp.h (doprnt): Restore prototype.
6238 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6241 * Makefile.in (base_obj): Add back doprnt.o.
6243 * deps.mk (doprnt.o): Add back prerequisites.
6244 (callint.o): Depend on character.h.
6246 * eval.c (internal_lisp_condition_case): Include the handler
6247 representation in the error message.
6248 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6249 when breaking from the loop.
6251 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6253 * callint.c (Fcall_interactively): When displaying error message
6254 about invalid control letter, pass the character's codepoint, not
6255 a pointer to its multibyte form. Improve display of the character
6256 in octal and display also its hex code.
6258 * character.c (char_string): Use %x to display the (unsigned)
6259 codepoint of an invalid character, to avoid displaying a bogus
6262 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6263 `error', not SYMBOL_NAME itself.
6265 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6266 character arguments to `error'.
6268 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6269 to `error' in error message about FINAL_CHAR argument. Make sure
6270 FINAL_CHAR is a character, and use %c when it is passed as
6271 argument to `error'.
6273 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6275 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6277 * w32.c: Include <time.h>.
6278 (sys_localtime): New function.
6280 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6282 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6284 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6286 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6288 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6291 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6293 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6294 gl_state.e_property when gl_state.object is Qt.
6296 * insdel.c (make_gap_larger): Remove limitation of buffer size
6299 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6301 * xdisp.c (lookup_glyphless_char_display)
6302 (produce_glyphless_glyph): Handle cons cell entry in
6303 glyphless-char-display.
6304 (Vglyphless_char_display): Document it.
6306 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6307 glyphless-char-display.
6309 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6311 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6313 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6315 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6316 definition for no-X builds.
6318 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6320 Static checks with GCC 4.6.0 and non-default toolkits.
6322 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6324 * process.c (keyboard_bit_set): Define only if SIGIO.
6325 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6326 (send_process): Repair possible setjmp clobbering.
6328 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6330 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6332 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6334 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6335 Define only if needed.
6337 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6338 by pacifying GCC about it. Maybe it's time to retire it?
6339 * xfaces.c (USG, __TIMEVAL__): Likewise.
6341 * dispextern.h (struct redisplay_interface): Rename param
6343 * termhooks.h (struct terminal): Likewise.
6344 * xterm.c (xembed_send_message): Likewise.
6346 * insdel.c (make_gap_smaller): Define only if
6347 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6349 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6352 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6353 so that we aren't warned about unused symbols.
6355 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6357 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6359 * xfns.c (x_real_positions): Mark locals as initialized.
6361 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6363 * xterm.c: Fix problems found by static analysis with other toolkits.
6364 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6365 (x_dispatch_event): Declare static if USE_GTK, and
6366 define if USE_GTK || USE_X_TOOLKIT.
6367 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6368 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6369 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6370 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6372 * xmenu.c (menu_help_callback): Pointer type fixes.
6373 Use const pointers when pointing at readonly data. Avoid pointer
6375 (FALSE): Remove unused macro.
6376 (update_frame_menubar): Remove unused decl.
6378 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6380 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6381 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6382 (single_menu_item): Rename local to avoid shadowing.
6384 * keyboard.c (make_lispy_event): Remove unused local var.
6386 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6387 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6389 * bitmaps: Change bitmaps from unsigned char back to the X11
6390 compatible char. Avoid the old compiler warnings about
6391 out-of-range initializers by using, for example, '\xab' rather
6394 * xgselect.c (xgselect_initialize): Check vs interface
6395 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6397 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6399 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6400 to read-only memory.
6402 * fns.c (vector): Remove; this old hack is no longer needed.
6404 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6406 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6408 * xrdb.c (x_load_resources): Omit unused local.
6410 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6411 (x_window): Rename locals to avoid shadowing.
6412 (USG): Use the kludged USG macro, to pacify gcc.
6414 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6415 (x_term_init): Remove local to avoid shadowing.
6417 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6419 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6420 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6422 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6424 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6426 Fix regex.c, syntax.c and friends for buffers > 2GB.
6427 * syntax.h (struct gl_state_s): Declare character position members
6430 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6432 * textprop.c (verify_interval_modification, interval_of):
6433 Declare arguments EMACS_INT.
6435 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6438 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6440 * indent.c (Fvertical_motion): Local variable it_start is now
6443 * regex.c (re_match, re_match_2, re_match_2_internal)
6444 (bcmp_translate, regcomp, regexec, print_double_string)
6445 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6446 (re_compile_pattern, re_exec): Declare arguments and local
6447 variables `size_t' and `ssize_t' and return values `regoff_t', as
6449 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6450 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6451 <compile_stack_type>: `size' and `avail' are now `size_t'.
6453 * regex.h <regoff_t>: Use ssize_t, not int.
6454 (re_search, re_search_2, re_match, re_match_2): Arguments that
6455 specify buffer/string position and length are now ssize_t and
6456 size_t. Return type is regoff_t.
6458 2011-04-16 Ben Key <bkey76@gmail.com>
6460 * nsfont.m: Fixed bugs in ns_get_family and
6461 ns_descriptor_to_entity that were caused by using free to
6462 deallocate memory blocks that were allocated by xmalloc (via
6463 xstrdup). This caused Emacs to crash when compiled with
6464 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6465 --enable-checking=xmallocoverrun). xfree is now used to
6466 deallocate these memory blocks.
6468 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6470 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6472 emacs_write: Accept and return EMACS_INT for sizes.
6473 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6475 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6476 Accept and return EMACS_INT.
6477 (emacs_gnutls_write): Return the number of bytes written on
6479 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6480 (emacs_read, emacs_write): Remove check for negative size, as the
6481 Emacs source code has been audited now.
6482 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6483 (emacs_read, emacs_write): Use it.
6484 * process.c (send_process): Adjust to the new signatures of
6485 emacs_write and emacs_gnutls_write. Do not attempt to store
6486 a byte offset into an 'int'; it might overflow.
6487 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6489 * sound.c: Don't assume sizes fit in 'int'.
6490 (struct sound_device.period_size, alsa_period_size):
6491 Return EMACS_INT, not int.
6492 (struct sound_device.write, vox_write, alsa_write):
6493 Accept EMACS_INT, not int.
6494 (wav_play, au_play): Use EMACS_INT to store sizes and to
6495 record read return values.
6497 2011-04-15 Ben Key <bkey76@gmail.com>
6499 * keyboard.c (Qundefined): Don't declare static since it is used
6501 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6502 static since they are used in nsfont.m.
6504 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6506 * process.c (Qprocessp): Don't declare static.
6507 * lisp.h (Qprocessp): Declare again.
6509 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6511 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6513 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6515 Improve C-level modularity by making more things 'static'.
6517 Don't publish debugger-only interfaces to other modules.
6518 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6519 (verify_bytepos, count_markers): Move decls to the only modules
6521 * region-cache.h (pp_cache): Likewise.
6522 * window.h (check_all_windows): Likewise.
6523 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6525 * sysdep.c (croak): Now static, if
6526 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6527 * syssignal.h (croak): Declare only if not static.
6529 * alloc.c (refill_memory_reserve): Now static if
6530 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6531 * lisp.h (refill_memory_reserve): Declare only if not static.
6533 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6534 Define only if USE_LUCID.
6536 * xrdb.c (x_customization_string, x_rm_string): Now static.
6538 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6539 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6541 * xdisp.c (draw_row_with_mouse_face): Now static.
6542 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6544 * window.h (check_all_windows): Mark externally visible.
6546 * window.c (window_deletion_count): Now static.
6548 * undo.c: Make symbols static if they're not exported.
6549 (last_undo_buffer, last_boundary_position, pending_boundary):
6552 * textprop.c (interval_insert_behind_hooks): Now static.
6553 (interval_insert_in_front_hooks): Likewise.
6555 * term.c: Make symbols static if they're not exported.
6556 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6557 (max_frame_lines, tty_set_terminal_modes):
6558 (tty_reset_terminal_modes, tty_turn_off_highlight):
6559 (get_tty_terminal): Now static.
6560 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6561 * termhooks.h (term_mouse_moveto): Do not declare if
6563 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6564 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6566 * sysdep.c: Make symbols static if they're not exported.
6567 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6569 (sigprocmask_set, full_mask): Remove; unused.
6570 (wait_debugging): Mark as visible.
6571 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6572 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6574 * syntax.c (syntax_temp): Define only if !__GNUC__.
6576 * sound.c (current_sound_device, current_sound): Now static.
6578 * search.c (searchbufs, searchbuf_head): Now static.
6580 * scroll.c (scroll_cost): Remove; unused.
6581 * dispextern.h (scroll_cost): Remove decl.
6583 * region-cache.h (pp_cache): Mark as externally visible.
6585 * process.c: Make symbols static if they're not exported.
6586 (process_tick, update_tick, create_process, chan_process):
6587 (Vprocess_alist, proc_buffered_char, datagram_access):
6588 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6589 (deactivate_process): Mark defn as static, as well as decl.
6590 * lisp.h (create_process): Remove decl.
6591 * process.h (chan_process, Vprocess_alist): Remove decls.
6593 * print.c: Make symbols static if they're not exported.
6594 (print_depth, new_backquote_output, being_printed, print_buffer):
6595 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6596 (print_interval, print_number_index, initial_stderr_stream):
6598 * lisp.h (Fprinc): Remove decl.
6599 (debug_output_compilation_hack): Mark as externally visible.
6601 * sysdep.c (croak): Move decl from here to syssignal.h.
6602 * syssignal.h (croak): Put it here, so the API can be checked when
6603 'croak' is called from dissociate_if_controlling_tty.
6605 * minibuf.c: Make symbols static if they're not exported.
6606 (minibuf_save_list, choose_minibuf_frame): Now static.
6607 * lisp.h (choose_minibuf_frame): Remove decl.
6609 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6611 * lread.c: Make symbols static if they're not exported.
6612 (read_objects, initial_obarray, oblookup_last_bucket_number):
6614 (make_symbol): Remove; unused.
6615 * lisp.h (initial_obarray, make_symbol): Remove decls.
6617 * keyboard.c: Make symbols static if they're not exported.
6618 (single_kboard, recent_keys_index, total_keys, recent_keys):
6619 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6620 (this_single_command_key_start, echoing, last_auto_save):
6621 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6622 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6623 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6624 (Vlispy_mouse_stem, double_click_count):
6626 (force_auto_save_soon): Define only if SIGDANGER.
6627 (ignore_mouse_drag_p): Now static if
6628 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6629 (print_help): Remove; unused.
6630 (stop_character, last_timer_event): Mark as externally visible.
6631 * keyboard.h (ignore_mouse_drag_p): Declare only if
6632 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6633 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6634 * lisp.h (echoing): Remove decl.
6635 (force_auto_save_soon): Declare only if SIGDANGER.
6636 * xdisp.c (redisplay_window): Simplify code, to make it more
6637 obvious that ignore_mouse_drag_p is not accessed if !defined
6638 USE_GTK && !defined HAVE_NS.
6640 * intervals.c: Make symbols static if they're not exported.
6641 (merge_properties_sticky, merge_interval_right, delete_interval):
6643 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6645 * insdel.c: Make symbols static if they're not exported.
6646 However, leave prepare_to_modify_buffer alone. It's never
6647 called from outside this function, but that appears to be a bug.
6648 (combine_after_change_list, combine_after_change_buffer):
6649 (adjust_after_replace, signal_before_change): Now static.
6650 (adjust_after_replace_noundo): Remove; unused.
6651 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6652 (signal_before_change): Remove decls.
6654 * indent.c (val_compute_motion, val_vmotion): Now static.
6656 * image.c: Make symbols static if they're not exported.
6657 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6659 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6660 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6662 * fringe.c (standard_bitmaps): Now static.
6663 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6665 * frame.c: Make symbols static if they're not exported.
6666 (x_report_frame_params, make_terminal_frame): Now static.
6667 (get_frame_param): Now static, unless HAVE_NS.
6668 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6669 (x_get_resource_string): Remove; not used.
6670 * frame.h (make_terminal_frame, x_report_frame_params):
6671 (x_get_resource_string); Remove decls.
6672 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6673 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6675 * font.c, fontset.c: Make symbols static if they're not exported.
6676 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6677 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6678 * font.c (font_close_object): Now static.
6679 * font.h (font_close_object): Remove.
6680 * fontset.c (FONTSET_OBJLIST): Remove.
6681 (free_realized_fontset) #if-0 the body, which does nothing.
6682 (face_suitable_for_char_p): #if-0, as it's never called.
6683 * fontset.h (face_suitable_for_char_p): Remove decl.
6684 * xfaces.c (face_at_string_position):
6685 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6686 since 0 is always ASCII.
6688 * fns.c (weak_hash_tables): Now static.
6690 * fileio.c: Make symbols static if they're not exported.
6691 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6692 (Vwrite_region_annotation_buffers): Now static.
6694 * eval.c: Make symbols static if they're not exported.
6695 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6696 * lisp.h (backtrace_list): Remove decl.
6698 * emacs.c: Make symbols static if they're not exported.
6699 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6700 (fatal_error_code, fatal_error_signal_hook, standard_args):
6702 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6703 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6704 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6705 * lisp.h (fatal_error_signal_hook): Remove decl.
6706 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6708 * editfns.c: Move a (normally-unused) function to its only use.
6709 * editfns.c, lisp.h (get_operating_system_release): Remove.
6710 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6711 worth the hassle of breaking this out.
6713 * xterm.c: Make symbols static if they're not exported.
6714 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6715 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6716 (x_destroy_window, x_delete_display):
6718 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6719 (x_mouse_leave): Remove; unused.
6720 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6721 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6722 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6724 (x_mouse_leave): Declare only if WINDOWSNT.
6725 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6726 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6729 * ftxfont.c: Make symbols static if they're not exported.
6730 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6732 * font.h (ftxfont_driver): Likewise.
6734 * xfns.c: Make symbols static if they're not exported.
6735 (x_last_font_name, x_display_info_for_name):
6736 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6737 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6738 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6739 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6740 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6741 (last_show_tip_args): Now static.
6742 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6743 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6744 (x_screen_planes): Remove; unused.
6745 * dispextern.h (x_screen_planes): Remove decl.
6747 * dispnew.c: Make symbols static if they're not exported.
6748 * dispextern.h (redraw_garbaged_frames, scrolling):
6749 (increment_row_positions): Remove.
6750 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6751 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6753 (redraw_garbaged_frames): Remove; unused.
6755 * xfaces.c: Make symbols static if they're not exported.
6756 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6758 * xterm.h (defined_color): Remove decls.
6759 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6760 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6761 (menu_face_changed_default, defined_color, free_realized_face):
6762 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6763 (ascii_face_of_lisp_face): Remove; unused.
6765 * xdisp.c: Make symbols static if they're not exported.
6766 * dispextern.h (scratch_glyph_row, window_box_edges):
6767 (glyph_to_pixel_coords, set_cursor_from_row):
6768 (get_next_display_element, set_iterator_to_next):
6769 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6770 (show_mouse_face): Remove decls
6771 * frame.h (message_buf_print): Likewise.
6772 * lisp.h (pop_message, set_message, check_point_in_composition):
6774 * xterm.h (set_vertical_scroll_bar): Likewise.
6775 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6776 (message_buf_print, scratch_glyph_row, displayed_buffer):
6777 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6778 (get_next_display_element, show_mouse_face, window_box_edges):
6779 (frame_to_window_pixel_xy, check_point_in_composition):
6780 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6781 (glyph_to_pixel_coords): Remove; unused.
6783 * dired.c (file_name_completion): Now static.
6785 * dbusbind.c (xd_in_read_queued_messages): Now static.
6787 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6788 * data.c (circular_list_error): Remove.
6790 * commands.h (last_point_position, last_point_position_buffer):
6791 (last_point_position_window): Remove decls.
6792 * keyboard.c: Make these variables static.
6794 * coding.h (coding, code_convert_region, encode_coding_gap):
6796 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6797 (iso_code_class, detect_coding, code_convert_region): Now static.
6798 (encode_coding_gap): Remove; unused.
6800 * chartab.c (chartab_chars, chartab_bits): Now static.
6802 * charset.h (charset_iso_8859_1): Remove decl.
6803 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6806 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6807 * ccl.c (Vccl_program_table): Now static.
6808 (check_ccl_update): Remove; unused.
6810 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6811 * category.h: ... from here.
6812 * category.c (check_category_table, set_category_set): Now static.
6814 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6815 * lisp.h: Remove these decls.
6817 * buffer.c (buffer_count): Remove unused var.
6819 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6820 so that it's not optimized away.
6821 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6822 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6823 exported only to the debugger.
6825 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6826 * atimer.h (run_all_atimers): Remove; not exported.
6828 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6829 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6830 was inaccessible from Lisp.
6831 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6832 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6834 alloc.c: Import and export fewer symbols, and remove unused items.
6835 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6837 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6838 it's not optimized away by whole-program optimization.
6839 (message_enable_multibyte, free_misc): Remove.
6840 (catchlist, handlerlist, mark_backtrace):
6841 Declare only if BYTE_MARK_STACK.
6842 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6843 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6844 (message_enable_multibyte): Remove decl.
6845 (free_misc, interval_free_list, float_block, float_block_index):
6846 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6847 (cons_free_list, last_marked_index):
6849 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6850 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6851 (mark_backtrace): Define only if BYTE_MARK_STACK.
6852 * xdisp.c (message_enable_multibyte): Now static.
6854 Declare Lisp_Object Q* variables to be 'static' if not exported.
6855 This makes it easier for human readers (and static analyzers)
6856 to see whether these variables are used from other modules.
6857 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6858 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6859 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6860 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6861 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6862 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6863 * xmenu.c, xselect.c:
6864 Declare Q* vars static if they are not used in other modules.
6865 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6866 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6867 Remove decls of unexported vars.
6868 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6870 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6872 Make Emacs functions such as Fatom 'static' by default.
6873 This makes it easier for human readers (and static analyzers)
6874 to see whether these functions can be called from other modules.
6875 DEFUN now defines a static function. To make the function external
6876 so that it can be used in other C modules, use the new macro DEFUE.
6877 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6878 (Finit_image_library):
6879 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6880 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6881 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6882 Remove decls, since these functions are now static.
6883 (Funintern, Fget_internal_run_time): New decls, since these functions
6884 were already external.
6886 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6887 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6888 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6889 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6890 * keyboard.c, keymap.c, lread.c:
6891 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6892 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6893 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6894 Mark functions with DEFUE instead of DEFUN,
6895 if they are used in other modules.
6896 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6897 decls for now-static functions.
6898 * buffer.h (Fdelete_overlay): Remove decl.
6899 * callproc.c (Fgetenv_internal): Mark as internal.
6900 * composite.c (Fremove_list_of_text_properties): Remove decl.
6901 (Fcomposition_get_gstring): New forward static decl.
6902 * composite.h (Fcomposite_get_gstring): Remove decl.
6903 * dired.c (Ffile_attributes): New forward static decl.
6904 * doc.c (Fdocumntation_property): New forward static decl.
6905 * eval.c (Ffetch_bytecode): New forward static decl.
6906 (Funintern): Remove extern decl; now in .h file where it belongs.
6907 * fileio.c (Fmake_symbolic_link): New forward static decl.
6908 * image.c (Finit_image_library): New forward static decl.
6909 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6910 * intervals.h (Fprevious_property_change):
6911 (Fremove_list_of_text_properties): Remove decls.
6912 * keyboard.c (Fthis_command_keys): Remove decl.
6913 (Fcommand_execute): New forward static decl.
6914 * keymap.c (Flookup_key): New forward static decl.
6915 (Fcopy_keymap): Now static.
6916 * keymap.h (Flookup_key): Remove decl.
6917 * process.c (Fget_process): New forward static decl.
6918 (Fprocess_datagram_address): Mark as internal.
6919 * syntax.c (Fsyntax_table_p): New forward static decl.
6920 (skip_chars): Remove duplicate decl.
6921 * textprop.c (Fprevious_property_change): New forward static decl.
6922 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6924 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6925 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6927 * editfns.c (Fformat): Remove unreachable code.
6929 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6931 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6934 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6936 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6937 when at ZV. (Bug#8487)
6939 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6941 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6943 * keyboard.c (parse_tool_bar_item): Likewise.
6944 * sound.c (sound_cleanup, alsa_close): Likewise.
6945 * termcap.c (tgetent): Likewise.
6946 * xfns.c (x_default_font_parameter): Likewise.
6947 * xsettings.c (read_and_apply_settings): Likewise.
6949 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6950 (overrun_check_free): Protoize.
6952 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6954 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6955 since callers should never pass a negative size.
6956 Change the signature to match that of plain 'read' and 'write'; see
6957 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6958 * lisp.h: Update prototypes of emacs_write and emacs_read.
6960 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6962 * xdisp.c (redisplay_window): Don't try to determine the character
6963 position of the scroll margin if the window start point w->startp
6964 is outside the buffer's accessible region. (Bug#8468)
6966 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6968 Fix write-region and its subroutines for buffers > 2GB.
6969 * fileio.c (a_write, e_write): Modify declaration of arguments and
6970 local variables to support buffers larger than 2GB.
6971 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6973 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6974 argument, local variables, and return value.
6976 * lisp.h: Update prototypes of emacs_write and emacs_read.
6978 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6980 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6982 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6984 Fix more problems found by GCC 4.6.0's static checks.
6986 * xdisp.c (vmessage): Use a better test for character truncation.
6988 * charset.c (load_charset_map): <, not <=, for optimization,
6989 and to avoid potential problems with integer overflow.
6990 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6991 * casetab.c (set_identity, shuffle): Likewise.
6992 * editfns.c (Fformat): Likewise.
6993 * syntax.c (skip_chars): Likewise.
6995 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6996 This also lets GCC 4.6.0 generate slightly better loop code.
6998 * callint.c (Fcall_interactively): <, not <=, for optimization.
6999 (Fcall_interactively): Count the number of arguments produced,
7000 not the number of arguments given. This is simpler and lets GCC
7001 4.6.0 generate slightly better code.
7003 * ftfont.c: Distingish more carefully between FcChar8 and char.
7004 The previous code passed unsigned char * to a functions like
7005 strlen and xstrcasecmp that expect char *, which does not
7006 conform to the C standard.
7007 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7008 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7009 char * when the C standard requires it.
7011 * keyboard.c (read_char): Remove unused var.
7013 * eval.c: Port to Windows vsnprintf (Bug#8435).
7015 (SIZE_MAX): Define if the headers do not.
7016 (verror): Do not give up if vsnprintf returns a negative count.
7017 Instead, grow the buffer. This ports to Windows vsnprintf, which
7018 does not conform to C99. Problem reported by Eli Zaretskii.
7019 Also, simplify the allocation scheme, by avoiding the need for
7020 calling realloc, and removing the ALLOCATED variable.
7022 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7024 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7025 But keep the doprint source code for now, as we might revamp it
7026 and use it again (Bug#8435).
7027 * lisp.h (doprnt): Remove.
7028 * Makefile.in (base_obj): Remove doprnt.o.
7029 * deps.mk (doprnt.o): Remove.
7031 error: Print 32- and 64-bit integers portably (Bug#8435).
7032 Without this change, on typical 64-bit hosts error ("...%d...", N)
7033 was used to print both 32- and 64-bit integers N, which relied on
7035 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7037 * lisp.h (error, verror): Mark as printf-like functions.
7038 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7039 Report overflow in size calculations when allocating printf buffer.
7040 Do not truncate output string at its first null byte.
7041 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7042 Truncate the output at a character boundary, since vsnprintf does not
7044 * charset.c (check_iso_charset_parameter): Convert internal
7045 character to string before calling 'error', since %c now has the
7047 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7048 overflow when computing char to be passed to 'error'. Do not
7049 pass Lisp_Object to 'error'; pass the integer instead.
7050 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7051 formatted with plain %d.
7053 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7055 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7057 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7059 * xterm.c (x_catch_errors): Remove duplicate declaration.
7061 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7063 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7065 2011-04-10 Jim Meyering <meyering@redhat.com>
7067 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7068 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7069 return ssize_t not "int", and use size_t as the buffer length.
7070 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7071 * gnutls.h: Update declarations.
7072 * process.c (read_process_output): Use ssize_t, to match.
7073 (send_process): Likewise.
7075 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7077 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7079 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7081 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7082 Use unsigned char, to match FcChar8 type definition.
7084 * xterm.c (handle_one_xevent):
7085 * xmenu.c (create_and_show_popup_menu):
7086 * xselect.c (x_decline_selection_request)
7087 (x_reply_selection_request): Avoid type-punned deref of X events.
7089 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7091 Fix some uses of `int' instead of EMACS_INT.
7092 * search.c (string_match_1, fast_string_match)
7093 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7094 (scan_buffer, find_next_newline_no_quit)
7095 (find_before_next_newline, search_command, Freplace_match)
7096 (Fmatch_data): Make some `int' variables be EMACS_INT.
7098 * xdisp.c (display_count_lines): 3rd argument and return value now
7099 EMACS_INT. All callers changed.
7100 (pint2hrstr): Last argument is now EMACS_INT.
7102 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7103 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7104 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7105 (decode_coding_utf_16, decode_coding_emacs_mule)
7106 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7107 (decode_coding_ccl, decode_coding_charset)
7108 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7109 (decode_coding_iso_2022, decode_coding_emacs_mule)
7110 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7111 <char_offset, last_offset>: Declare EMACS_INT.
7112 (encode_coding_utf_8, encode_coding_utf_16)
7113 (encode_coding_emacs_mule, encode_invocation_designation)
7114 (encode_designation_at_bol, encode_coding_iso_2022)
7115 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7116 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7118 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7119 (encode_invocation_designation): Last argument P_NCHARS is now
7121 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7122 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7124 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7127 * ccl.c (Fccl_execute_on_string): Declare some variables
7130 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7132 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7134 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7136 * process.c (Fformat_network_address): Doc fix.
7138 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7140 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7142 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7144 * keyboard.c (read_char): Call Lisp function help-form-show,
7145 instead of using internal_with_output_to_temp_buffer.
7146 (Qhelp_form_show): New var.
7147 (syms_of_keyboard): Use DEFSYM macro.
7149 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7151 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7153 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7155 * process.c (Flist_processes): Remove to Lisp.
7156 (list_processes_1): Delete.
7158 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7160 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7162 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7164 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7166 Fix more problems found by GCC 4.6.0's static checks.
7168 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7170 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7172 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7174 * xdisp.c (vmessage): Mark as a printf-like function.
7176 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7178 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7180 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7181 printf-like functions.
7182 (tiff_load): Add casts to remove these marks before passing them
7183 to system-supplied API.
7185 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7187 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7188 This avoids several warnings with gcc -Wstrict-overflow.
7189 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7190 directly, rather than having caller test rule sign. This avoids
7191 some unnecessary tests.
7192 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7193 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7194 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7196 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7197 (xfont_open): Avoid unnecessary tests.
7199 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7201 * composite.h, composite.c (composition_gstring_put_cache):
7202 Use EMACS_INT, not int, for length.
7204 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7205 breaking out part of COMPOSITION_DECODE_RULE.
7206 (COMPOSITION_DECODE_RULE): Use it.
7207 * composite.c (get_composition_id): Remove unused local vars,
7208 by using the new macro.
7210 * textprop.c (set_text_properties_1): Change while to do-while,
7211 since the condition is always true at first.
7213 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7214 (interval_deletion_adjustment): Return unsigned value.
7217 * process.c (list_processes_1, create_pty, read_process_output):
7218 (exec_sentinel): Remove vars that were set but not used.
7219 (create_pty): Remove unnecessary "volatile"s.
7220 (Fnetwork_interface_info): Avoid possibility of int overflow.
7221 (read_process_output): Do adaptive read buffering even if carryover.
7222 (read_process_output): Simplify nbytes computation if buffered.
7224 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7226 * syntax.c (scan_words): Remove var that was set but not used.
7227 (update_syntax_table): Use unsigned instead of int.
7229 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7230 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7231 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7233 * print.c (print_error_message): Avoid int overflow.
7235 * font.c (font_list_entities): Redo for clarity,
7236 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7238 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7239 (font_score): Avoid potential overflow in diff calculation.
7241 * fns.c (substring_both): Remove var that is set but not used.
7242 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7244 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7246 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7247 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7248 can always succeed if overflow has undefined behavior.
7250 * search.c (boyer_moore, wordify): Remove vars set but not used.
7251 (wordify): Omit three unnecessary tests.
7253 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7254 All callers changed. This avoids the need for an unused var.
7256 * casefiddle.c (casify_region): Remove var that is set but not used.
7258 * dired.c (file_name_completion): Remove var that is set but not used.
7260 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7262 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7263 (Finsert_file_contents): Remove unnecessary code checking fd.
7265 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7266 Check for integer overflow on size calculations.
7268 * buffer.c (Fprevious_overlay_change): Remove var that is set
7271 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7272 Remove vars that are set but not used.
7273 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7274 (timer_check_2): Mark vars as initialized.
7276 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7278 * image.c (lookup_image): Remove var that is set but not used.
7279 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7281 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7282 that are set but not used.
7284 * xfns.c (make_invisible_cursor): Don't return garbage
7285 if XCreateBitmapFromData fails (Bug#8410).
7287 * xselect.c (x_get_local_selection, x_handle_property_notify):
7288 Remove vars that are set but not used.
7290 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7291 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7293 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7294 Remove var that is set but not used.
7295 (scroll_bar_windows_size): Now size_t, not int.
7296 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7299 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7300 (map_tty_color) [!defined MSDOS]: Likewise.
7302 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7304 * coding.c: Remove vars that are set but not used.
7305 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7306 All callers changed.
7307 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7308 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7309 (decode_coding_charset): Remove vars that are set but not used.
7311 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7312 that is set but not used.
7314 * print.c (print_object): Remove var that is set but not used.
7316 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7317 The gnulib version avoids calling malloc in the usual case,
7318 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7319 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7320 * filelock.c (current_lock_owner): Likewise.
7321 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7322 * sysdep.c: Include allocator.h, careadlinkat.h.
7323 (emacs_no_realloc_allocator): New static constant.
7324 (emacs_readlink): New function.
7325 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7326 ../lib/careadlinkat.h.
7328 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7330 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7331 first non-nil return value).
7333 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7335 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7336 if not defined (Bug#8403).
7338 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7340 * xdisp.c (display_count_lines): Remove parameter `start',
7341 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7342 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7343 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7344 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7345 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7346 and thereabouts. All callers changed.
7347 (get_per_char_metric): Remove parameter `f', unused since
7348 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7350 2011-04-02 Jim Meyering <meyering@redhat.com>
7352 do not dereference NULL upon failed strdup
7353 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7354 (ns_get_family): Likewise.
7356 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7358 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7360 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7362 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7365 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7367 Add lexical binding.
7369 * window.c (Ftemp_output_buffer_show): New fun.
7370 (Fsave_window_excursion):
7371 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7373 * lread.c (lisp_file_lexically_bound_p): New function.
7374 (Fload): Bind Qlexical_binding.
7375 (readevalloop): Remove `evalfun' arg.
7376 Bind Qinternal_interpreter_environment.
7377 (Feval_buffer): Bind Qlexical_binding.
7378 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7380 (syms_of_lread): Declare `lexical-binding'.
7382 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7384 * keyboard.c (eval_dyn): New fun.
7385 (menu_item_eval_property): Use it.
7387 * image.c (parse_image_spec): Use Ffunctionp.
7389 * fns.c (concat, mapcar1): Accept byte-code-functions.
7391 * eval.c (Fsetq): Handle lexical vars.
7392 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7393 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7394 (FletX, Flet): Obey lexical binding.
7395 (Fcommandp): Handle closures.
7396 (Feval): New `lexical' arg.
7397 (eval_sub): New function extracted from Feval. Use it almost
7398 everywhere where Feval was used. Look up vars in lexical env.
7400 (Ffunctionp): Move from subr.el.
7401 (Ffuncall): Handle closures.
7402 (apply_lambda): Remove `eval_flags'.
7403 (funcall_lambda): Handle closures and new byte-code-functions.
7404 (Fspecial_variable_p): New function.
7405 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7406 but without exporting it to Lisp.
7408 * doc.c (Fdocumentation, store_function_docstring):
7409 * data.c (Finteractive_form): Handle closures.
7411 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7414 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7416 (exec_byte_code): New function extracted from Fbyte_code to handle new
7417 calling convention for byte-code-functions. Add new byte-codes.
7419 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7421 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7423 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7425 * xdisp.c (redisplay_internal): Fix prototype.
7427 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7429 * xdisp.c (SCROLL_LIMIT): New macro.
7430 (try_scrolling): Use it when setting scroll_limit.
7431 Limit scrolling to 100 screen lines.
7432 (redisplay_window): Even when falling back on "recentering",
7433 position point in the window according to scroll-conservatively,
7434 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7436 (try_scrolling): When point is above the window, allow searching
7437 as far as scroll_max, or one screenful, to compute vertical
7438 distance from PT to the scroll margin position. This prevents
7439 try_scrolling from unnecessarily failing when
7440 scroll-conservatively is set to a value slightly larger than the
7441 window height. Clean up the case of PT below the margin at bottom
7442 of window: scroll_max can no longer be INT_MAX. When aggressive
7443 scrolling is in use, don't let point enter the opposite scroll
7444 margin as result of the scroll.
7445 (syms_of_xdisp) <scroll-conservatively>: Document the
7446 threshold of 100 lines for never-recentering scrolling.
7448 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7450 * dispextern.h (move_it_by_lines):
7451 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7452 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7453 (message_log_check_duplicate): Remove parameters `prev_bol' and
7454 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7455 (redisplay_internal): Remove parameter `preserve_echo_area',
7456 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7458 * indent.c (Fvertical_motion):
7459 * window.c (window_scroll_pixel_based, Frecenter):
7460 Don't pass `need_y_p' to `move_it_by_lines'.
7462 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7464 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7465 steal a few bits to be more compact.
7466 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7467 Remove unneeded casts.
7469 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7471 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7473 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7474 binding" message (bug#7967).
7476 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7478 Fix more problems found by GCC 4.6.0's static checks.
7480 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7481 Remove unused local var.
7483 * editfns.c (Fmessage_box): Remove unused local var.
7485 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7486 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7487 Omit unused local vars.
7488 * window.c (shrink_windows): Omit unused local var.
7489 * menu.c (digest_single_submenu): Omit unused local var.
7490 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7491 Omit unused local var.
7493 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7494 Don't assume string length fits in int.
7495 (keyremap_step, read_key_sequence): Use size_t for sizes.
7496 (read_key_sequence): Don't check last_real_key_start redundantly.
7498 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7499 instead of alloca (Bug#8344).
7501 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7502 (Fbacktrace_frame): Don't assume nframes fits in int.
7504 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7506 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7509 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7511 * cm.c (calccost): Turn while-do into do-while, for clarity.
7513 * keyboard.c (syms_of_keyboard): Use the same style as later
7514 in this function when indexing through an array. This also
7515 works around GCC bug 48267.
7517 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7519 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7521 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7522 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7524 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7525 This avoids undefined behavior on integer overflow, and is a bit
7526 more convenient anyway since it is compared to a size_t variable.
7528 Variadic C functions now count arguments with size_t, not int.
7529 This avoids an unnecessary limitation on 64-bit machines, which
7530 caused (substring ...) to crash on large vectors (Bug#8344).
7531 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7532 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7533 All variadic functions and their callers changed accordingly.
7534 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7535 * data.c (arith_driver, float_arith_driver): Likewise.
7536 * editfns.c (general_insert_function): Likewise.
7537 * eval.c (struct backtrace.nargs, interactive_p)
7538 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7539 (funcall_lambda, mark_backtrace): Likewise.
7540 * fns.c (concat): Likewise.
7541 * frame.c (x_set_frame_parameters): Likewise.
7542 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7543 0 if not found, not -1. All callers changed.
7545 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7546 (stack_copy_size): Now size_t, not int.
7547 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7549 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7551 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7552 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7553 All callers changed.
7555 * lisp.h (multibyte_char_to_unibyte):
7556 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7557 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7558 * character.h (CHAR_TO_BYTE8):
7559 * cmds.c (internal_self_insert):
7560 * editfns.c (general_insert_function):
7561 * keymap.c (push_key_description):
7562 * search.c (Freplace_match):
7563 * xdisp.c (message_dolog, set_message_1): All callers changed.
7565 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7567 * keyboard.c (safe_run_hook_funcall): New function.
7568 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7569 don't set the hook to nil, but remove the offending function instead.
7570 (Qcommand_hook_internal): Remove, unused.
7571 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7572 Vcommand_hook_internal.
7574 * eval.c (enum run_hooks_condition): Remove.
7575 (funcall_nil, funcall_not): New functions.
7576 (run_hook_with_args): Call each function through a `funcall' argument.
7577 Remove `cond' argument, now redundant.
7578 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7579 (Frun_hook_with_args_until_failure): Adjust accordingly.
7580 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7582 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7584 * dispextern.h (string_buffer_position): Remove declaration.
7586 * print.c (strout): Remove parameter `multibyte', unused since
7587 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7589 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7590 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7591 All callers changed.
7593 * w32.c (_wsa_errlist): Use braces for struct initializers.
7595 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7596 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7597 All callers changed.
7598 (string_buffer_position): Likewise. Also, make static (it's never
7599 used outside xdisp.c).
7600 (cursor_row_p): Remove parameter `w', unused since
7601 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7602 (decode_mode_spec): Remove parameter `precision', introduced during
7603 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7604 All callers changed.
7606 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7608 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7610 2011-03-27 Anders Lindgren <andlind@gmail.com>
7612 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7613 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7614 (ns_update_auto_hide_menu_bar): New functions.
7615 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7616 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7617 ns_constrain_all_frames.
7618 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7619 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7621 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7623 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7625 2011-03-27 Glenn Morris <rgm@gnu.org>
7627 * syssignal.h: Replace RETSIGTYPE with void.
7628 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7629 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7630 Replace SIGTYPE with void everywhere.
7631 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7632 * s/template.h (SIGTYPE): Remove commented out definition.
7634 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7636 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7637 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7639 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7641 * w32.c (read_unc_volume): Use parameter `henum', instead of
7642 global variable `wget_enum_handle'.
7644 * keymap.c (describe_vector): Remove parameters `indices' and
7645 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7646 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7648 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7650 * keyboard.c (timer_check): Remove parameter `do_it_now',
7651 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7652 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7653 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7655 * keyboard.c (read_char):
7656 * w32menu.c (w32_menu_display_help):
7657 * xmenu.c (show_help_event, menu_help_callback):
7658 Adjust calls to `show_help_echo'.
7660 * gtkutil.c (xg_maybe_add_timer):
7661 * keyboard.c (readable_events):
7662 * process.c (wait_reading_process_output):
7663 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7665 * insdel.c (adjust_markers_gap_motion):
7666 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7667 (gap_left, gap_right): Don't call it.
7669 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7671 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7672 incurred during fontification.
7674 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7676 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7677 (DEFVAR_PER_BUFFER): Don't pass it.
7679 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7680 (scrolling_window): Don't pass it.
7682 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7684 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7686 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7688 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7689 of variables specific to SELinux and computation of `encoded_absname'.
7691 * image.c (XPutPixel): Remove unused variable `height'.
7693 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7695 * unexw32.c (get_section_info): Remove unused variable `section'.
7697 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7698 (system_process_attributes): Remove unused variable `sess'.
7699 (sys_read): Remove unused variable `err'.
7701 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7702 (w32_wnd_proc): Remove unused variable `isdead'.
7703 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7704 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7705 (x_create_tip_frame): Remove unused variable `tem'.
7707 * w32inevt.c (w32_console_read_socket):
7708 Remove unused variable `no_events'.
7710 * w32term.c (x_draw_composite_glyph_string_foreground):
7711 Remove unused variable `width'.
7713 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7715 * w32term.c (x_set_glyph_string_clipping):
7716 Don't pass uninitialized region to CombineRgn.
7718 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7720 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7721 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7722 (Fx_close_connection): Remove unused variable `i'.
7724 * w32font.c (w32font_draw): Return number of glyphs.
7725 (w32font_open_internal): Remove unused variable `i'.
7726 (w32font_driver): Add missing initializer.
7728 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7729 (fill_in_menu): Remove unused variable `items_added'.
7731 * w32term.c (last_mouse_press_frame): Remove static global variable.
7732 (w32_clip_to_row): Remove unused variable `f'.
7733 (x_delete_terminal): Remove unused variable `i'.
7735 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7736 (NOTHING): Remove unused static global variable.
7737 (uniscribe_check_otf): Remove unused variable `table'.
7738 (uniscribe_font_driver): Add missing initializers.
7740 2011-03-23 Julien Danjou <julien@danjou.info>
7742 * term.c (Fsuspend_tty, Fresume_tty):
7743 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7744 * window.c (temp_output_buffer_show):
7745 * insdel.c (signal_before_change):
7746 * frame.c (Fhandle_switch_frame):
7747 * fileio.c (Fdo_auto_save):
7748 * emacs.c (Fkill_emacs):
7749 * editfns.c (save_excursion_restore):
7750 * cmds.c (internal_self_insert):
7751 * callint.c (Fcall_interactively):
7752 * buffer.c (Fkill_all_local_variables):
7753 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7755 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7756 unconditionally since it does the check itself.
7758 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7760 Fix more problems found by GCC 4.5.2's static checks.
7762 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7763 the first time through the loop, since we know p0 < p1 then.
7764 This also avoids a gcc -Wstrict-overflow warning.
7766 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7767 leading to a memory leak, possible in functions like
7768 load_charset_map_from_file that can allocate an unbounded number
7769 of objects (Bug#8318).
7771 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7772 that could (at least in theory) be that large.
7774 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7775 This is less likely to overflow, and avoids undefined behavior if
7776 overflow does occur. All callers changed. Use strtoul to scan
7777 for the unsigned long integer.
7778 (pint2hrstr): Simplify and tune code slightly.
7779 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7781 * scroll.c (do_scrolling): Work around GCC bug 48228.
7782 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7784 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7785 This also avoids a warning with gcc -Wstrict-overflow.
7786 (validate_x_resource_name): Simplify count usage.
7787 This also avoids a warning with gcc -Wstrict-overflow.
7789 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7792 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7794 * process.c (Fmake_network_process): Use socklen_t, not int,
7795 where POSIX says socklen_t is required in portable programs.
7796 This fixes a porting bug on hosts like 64-bit HP-UX, where
7797 socklen_t is wider than int (Bug#8277).
7798 (Fmake_network_process, server_accept_connection):
7799 (wait_reading_process_output, read_process_output):
7802 * process.c: Rename or move locals to avoid shadowing.
7803 (list_processes_1, Fmake_network_process):
7804 (read_process_output_error_handler, exec_sentinel_error_handler):
7805 Rename or move locals.
7806 (Fmake_network_process): Define label "retry_connect" only if needed.
7807 (Fnetwork_interface_info): Fix pointer signedness.
7808 (process_send_signal): Add cast to avoid pointer signedness problem.
7809 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7810 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7812 Make tparam.h and terminfo.c consistent.
7813 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7814 Include tparam.h instead, since it declares them.
7815 * cm.h (PC): Remove extern decl; tparam.h now does this.
7816 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7817 * terminfo.c: Include tparam.h, to check interfaces.
7818 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7819 (tparam): Adjust signature to match interface in tparam.h;
7820 this removes some undefined behavior. Check that outstring and len
7821 are zero, which they always are with Emacs.
7822 * tparam.h (PC, BC, UP): New extern decls.
7824 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7825 (xftfont_open): Rename locals to avoid shadowing.
7827 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7828 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7829 (OTF_TAG_SYM): Omit macro if not needed.
7830 (ftfont_list): Remove unused local.
7831 (get_adstyle_property, ftfont_pattern_entity):
7832 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7833 Rename locals to avoid shadowing.
7835 * xfont.c (xfont_list_family): Mark var as initialized.
7837 * xml.c (make_dom): Now static.
7839 * composite.c (composition_compute_stop_pos): Rename local to
7841 (composition_reseat_it): Remove unused locals.
7842 (find_automatic_composition, composition_adjust_point): Likewise.
7843 (composition_update_it): Mark var as initialized.
7844 (find_automatic_composition): Mark vars as initialized,
7845 with a FIXME (Bug#8290).
7847 character.h: Rename locals to avoid shadowing.
7848 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7849 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7850 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7851 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7854 * textprop.c (property_change_between_p): Remove; unused.
7856 * intervals.c (interval_start_pos): Now static.
7858 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7860 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7861 Rename locals to avoid shadowing.
7863 * sound.c (wav_play, au_play, Fplay_sound_internal):
7864 Fix pointer signedness.
7865 (alsa_choose_format): Remove unused local var.
7866 (wav_play): Initialize a variable to 0, to prevent undefined
7867 behavior (Bug#8278).
7869 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7871 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7873 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7874 clobbering (Bug#8298).
7875 * sysdep.c (sys_subshell): Likewise.
7876 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7878 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7879 This should get cleaned up, so that child_setup has the
7880 same signature on all platforms.
7882 * callproc.c (call_process_cleanup): Now static.
7883 (relocate_fd): Rename locals to avoid shadowing.
7885 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7887 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7888 not to be necessary, and produces flickering.
7890 2011-03-20 Glenn Morris <rgm@gnu.org>
7892 * config.in: Remove file.
7894 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7896 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7897 are now in src/globals.h.
7898 (syms_of_minibuf): Remove spurious & from previous change.
7900 2011-03-20 Leo <sdl.web@gmail.com>
7902 * minibuf.c (completing-read-function): New variable.
7903 (completing-read-default): Rename from completing-read.
7904 (completing-read): Call completing-read-function.
7906 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7908 * xfaces.c (Fx_load_color_file):
7909 Read color file from absolute filename (bug#8250).
7911 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7913 * makefile.w32-in: Update dependencies.
7915 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7917 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7919 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7921 Fix more problems found by GCC 4.5.2's static checks.
7923 * process.c (make_serial_process_unwind, send_process_trap):
7924 (sigchld_handler): Now static.
7926 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7927 That way, the code declares only the vars that it needs.
7928 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7929 * s/cygwin.h (PTY_ITERATION): Likewise.
7930 * s/darwin.h (PTY_ITERATION): Likewise.
7931 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7933 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7934 * process.c (allocate_pty): Don't declare stb unless it's needed.
7936 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7937 (CONSTANTLIM): Remove; unused.
7938 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7939 Define only if needed.
7941 * unexelf.c (unexec): Name an expression,
7942 to avoid gcc -Wbad-function-cast warning.
7943 Use a different way to cause a compilation error if anyone uses
7944 n rather than nn, a way that does not involve shadowing.
7945 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7947 * deps.mk (unexalpha.o): Remove; unused.
7949 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7950 * unexec.h: New file.
7951 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7952 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7954 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7955 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7956 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7957 Change as necessary to match prototype in unexec.h.
7959 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7961 (back_comment, skip_chars): Mark vars as initialized.
7963 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7964 Rename locals to avoid shadowing.
7966 * lread.c (read1): Rewrite so as not to use empty "else".
7967 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7969 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7971 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7972 warning when compiling print.c.
7974 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7975 instead of using an uninitialized var.
7976 (font_sort_entities): Mark var as initialized.
7978 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7980 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7981 pointers to constants.
7982 (font_parse_fcname): Remove unused vars.
7983 (font_delete_unmatched): Now static.
7984 (font_get_spec): Remove; unused.
7985 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7986 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7987 Rename or move locals to avoid shadowing.
7989 * fns.c (require_nesting_list, require_unwind): Now static.
7990 (Ffillarray): Rename locals to avoid shadowing.
7992 * floatfns.c (domain_error2): Define only if needed.
7993 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7995 * alloc.c (mark_backtrace): Move decl from here ...
7996 * lisp.h: ... to here, so that it can be checked.
7998 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7999 (Fdefvar): Rewrite so as not to use empty "else".
8000 (lisp_indirect_variable): Name an expression,
8001 to avoid gcc -Wbad-function-cast warning.
8002 (Fdefvar): Rename locals to avoid shadowing.
8004 * callint.c (quotify_arg, quotify_args): Now static.
8005 (Fcall_interactively): Rename locals to avoid shadowing.
8006 Use const pointer when appropriate.
8008 * lisp.h (get_system_name, get_operating_system_release):
8009 Move decls here, to check interfaces.
8010 * process.c (get_operating_system_release): Move decl to lisp.h.
8011 * xrdb.c (get_system_name): Likewise.
8012 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8013 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8014 some of which prompt warnings from gcc -Wbad-function-cast.
8015 (Fformat_time_string, Fencode_time, Finsert_char):
8016 (Ftranslate_region_internal, Fformat):
8017 Rename or remove local vars to avoid shadowing.
8018 (Ftranslate_region_internal): Mark var as initialized.
8020 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8023 * lisp.h (eassert): Check that the argument compiles, even if
8024 ENABLE_CHECKING is not defined.
8026 * data.c (Findirect_variable): Name an expression, to avoid
8027 gcc -Wbad-function-cast warning.
8028 (default_value, arithcompare, arith_driver, arith_error): Now static.
8029 (store_symval_forwarding): Rename local to avoid shadowing.
8030 (Fmake_variable_buffer_local, Fmake_local_variable):
8031 Mark variables as initialized.
8032 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8034 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8035 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8036 Rename locals to avoid shadowing.
8037 (mark_stack): Move local variables into the #ifdef region where
8039 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8040 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8042 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8043 (GC_STRING_CHARS): Remove; not used.
8044 (Fmemory_limit): Cast sbrk's returned value to char *.
8046 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8047 avoids undefined behavior in theory.
8049 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8051 Use functions, not macros, for up- and down-casing (Bug#8254).
8052 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8053 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8054 to use the following functions instead of these macros.
8055 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8056 EMACS_INT, since callers assume the returned value fits in int.
8057 (upcase1): Likewise, for UPCASE_TABLE.
8058 (uppercasep, lowercasep, upcase): New static inline functions.
8059 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8060 the race-condition problem in the old DOWNCASE.
8062 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8063 Rename locals to avoid shadowing.
8064 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8065 (regex_compile, re_search_2, re_match_2_internal):
8066 Remove unused local vars.
8067 (FREE_VAR): Rewrite so as not to use empty "else",
8068 which gcc can warn about.
8069 (regex_compile, re_match_2_internal): Mark locals as initialized.
8070 (RETALLOC_IF): Define only if needed.
8071 (WORDCHAR_P): Likewise. This one is never needed, but is used
8072 only in a comment talking about a compiler bug, so put inside
8073 the #if 0 of that comment.
8074 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8075 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8078 * search.c (boyer_moore): Rename locals to avoid shadowing.
8079 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8080 (PREV_CHAR_BOUNDARY): Likewise.
8082 * search.c (simple_search): Remove unused var.
8084 * dired.c (compile_pattern): Move decl from here ...
8085 * lisp.h: ... to here, so that it can be checked.
8086 (struct re_registers): New forward decl.
8088 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8090 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8092 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8093 Rename locals to avoid shadowing.
8094 (Fvertical_motion): Mark locals as initialized.
8096 * casefiddle.c (casify_object, casify_region): Now static.
8097 (casify_region): Mark local as initialized.
8099 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8101 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8102 New macros, so that the caller can use some names other than
8103 gcpro1, gcpro2, etc.
8104 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8106 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8107 argument, for consistency with GCPRO2_VAR, etc: it is now the
8108 prefix of the variable, not the variable itself. All uses
8110 * dired.c (directory_files_internal, file_name_completion):
8111 Rename locals to avoid shadowing.
8113 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8114 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8115 dired.c's scmp function, had undefined behavior.
8116 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8117 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8118 * buffer.h: ... to here, because these macros use current_buffer,
8119 and the new implementation with inline functions needs to have
8120 current_buffer in scope now, rather than later when the macros
8122 (downcase, upcase1): New static inline functions.
8123 (DOWNCASE, UPCASE1): Reimplement using these functions.
8124 This avoids undefined behavior in expressions like
8125 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8126 from race conditions in accessing the global variables
8127 case_temp1 and case_temp2.
8128 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8129 * lisp.h (case_temp1, case_temp2): Remove their decls.
8130 * character.h (ASCII_CHAR_P): Move from here ...
8131 * lisp.h: ... to here, so that the inline functions mentioned
8134 * dired.c (directory_files_internal_unwind): Now static.
8136 * fileio.c (file_name_as_directory, directory_file_name):
8137 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8139 (file_name_as_directory): Use const pointers when appropriate.
8140 (Fexpand_file_name): Likewise. In particular, newdir might
8141 point at constant storage, so make it a const pointer.
8142 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8143 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8145 (Fset_file_times, Finsert_file_contents, auto_save_error):
8146 Rename locals to avoid shadowing.
8148 * minibuf.c (choose_minibuf_frame_1): Now static.
8149 (Ftry_completion, Fall_completions): Rename or remove locals
8152 * marker.c (bytepos_to_charpos): Remove; unused.
8154 * lisp.h (verify_bytepos, count_markers): New decls,
8155 so that gcc does not warn that these functions aren't declared.
8157 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8158 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8159 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8160 (copy_text): Remove unused local var.
8162 * filelock.c (within_one_second): Now static.
8163 (lock_file_1): Rename local to avoid shadowing.
8165 * buffer.c (fix_overlays_before): Mark locals as initialized.
8166 (fix_start_end_in_overlays): Likewise. This function should be
8167 simplified by using pointers-to-pointers, but that's a different
8169 (switch_to_buffer_1): Now static.
8170 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8171 (report_overlay_modification): Rename locals to avoid shadowing.
8173 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8174 Fix pointer signedness issue.
8175 (sys_subshell): Mark local as volatile if checking for lint,
8176 to suppress a gcc -Wclobbered warning that does not seem to be right.
8177 (MAXPATHLEN): Define only if needed.
8179 * process.c (serial_open, serial_configure): Move decls from here ...
8180 * systty.h: ... to here, so that they can be checked.
8182 * fns.c (get_random, seed_random): Move extern decls from here ...
8183 * lisp.h: ... to here, so that they can be checked.
8185 * sysdep.c (reset_io): Now static.
8186 (wait_for_termination_signal): Remove; unused.
8188 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8189 (copy_keymap_item, append_key, push_text_char_description):
8191 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8192 (DENSE_TABLE_SIZE): Remove; unused.
8193 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8194 (describe_map_tree):
8195 Rename locals to avoid shadowing.
8197 * keyboard.c: Declare functions static if they are not used elsewhere.
8198 (echo_char, echo_dash, cmd_error, top_level_2):
8199 (poll_for_input, handle_async_input): Now static.
8200 (read_char, kbd_buffer_get_event, make_lispy_position):
8201 (make_lispy_event, make_lispy_movement, apply_modifiers):
8202 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8203 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8204 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8205 (read_key_sequence, read_char): Mark locals as initialized.
8206 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8208 * keyboard.h (make_ctrl_char): New decl.
8209 (mark_kboards): Move decl here ...
8210 * alloc.c (mark_kboards): ... from here.
8212 * lisp.h (force_auto_save_soon): New decl.
8214 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8215 (DEFINE_DUMMY_FUNCTION): New macro.
8216 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8218 (main): Add casts to avoid warnings
8219 if GCC considers string literals to be constants.
8221 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8223 * dbusbind.c: Pointer signedness fixes.
8224 (xd_signature, xd_append_arg, xd_initialize):
8225 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8226 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8227 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8228 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8230 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8231 if GCC considers string literals to be constants.
8232 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8234 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8236 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8237 (print_preprocess, print_object): New macro to fix last change.
8239 * print.c (print_preprocess): Don't forget font objects.
8241 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8243 * emacs.c (USAGE3): Doc fixes.
8245 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8247 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8250 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8252 * lisp.h (VWindow_system, Qfile_name_history):
8253 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8254 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8255 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8257 * w32select.c: Don't #include "keyboard.h".
8258 (run_protected): Add extern declaration for waiting_for_input.
8260 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8261 * w32console.c (detect_input_pending, read_input_pending)
8262 (encode_terminal_code):
8263 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8264 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8265 (w32_system_caret_y, Qfile_name_history):
8266 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8267 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8268 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8269 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8270 * w32proc.c (Qlocal, report_file_error):
8271 * w32term.c (Vwindow_system, updating_frame):
8272 * w32uniscribe.c (initialized, uniscribe_font_driver):
8273 Remove unneeded extern declarations.
8275 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8277 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8279 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8281 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8282 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8283 These macros can no longer be used for assignment.
8285 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8286 Assign struct members directly, instead of using BUF_BEGV etc.
8287 (record_buffer_markers, fetch_buffer_markers): New functions for
8288 recording and fetching special buffer markers.
8289 (set_buffer_internal_1, set_buffer_temp): Use them.
8291 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8293 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8295 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8296 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8298 * xdisp.c (hscroll_window_tree):
8299 (reconsider_clip_changes): Use PT instead of BUF_PT.
8301 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8303 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8304 $(EMACS_ROOT)/lib/intprops.h.
8306 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8308 Fix more problems found by GCC 4.5.2's static checks.
8310 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8311 to unsigned char * to avoid compiler diagnostic.
8312 (xg_free_frame_widgets): Make it clear that a local variable is
8313 needed only if USE_GTK_TOOLTIP.
8314 (gdk_window_get_screen): Make it clear that this macro is needed
8315 only if USE_GTK_TOOLTIP.
8316 (int_gtk_range_get_value): New function, which avoids a diagnostic
8317 from gcc -Wbad-function-cast.
8318 (xg_set_toolkit_scroll_bar_thumb): Use it.
8319 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8320 diagnostic from gcc -Wbad-function-cast.
8321 (get_utf8_string, xg_get_file_with_chooser):
8322 Rename locals to avoid shadowing.
8323 (create_dialog): Move locals to avoid shadowing.
8325 * xgselect.c (xg_select): Remove unused var.
8327 * image.c (four_corners_best): Mark locals as initialized.
8328 (gif_load): Initialize transparent_p to zero (Bug#8238).
8329 Mark another local as initialized.
8330 (my_png_error, my_error_exit): Mark with NO_RETURN.
8332 * image.c (clear_image_cache): Now static.
8333 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8334 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8335 (x_edge_detection): Remove unnecessary cast that
8336 gcc -Wbad-function-cast diagnoses.
8337 (gif_load): Fix pointer signedness.
8338 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8339 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8341 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8343 Improve quality of tests for time stamp overflow.
8344 For example, without this patch (encode-time 0 0 0 1 1
8345 1152921504606846976) returns the obviously-bogus value (-948597
8346 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8347 reports time overflow. See
8348 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8349 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8350 * editfns.c: Include limits.h and intprops.h.
8351 (TIME_T_MIN, TIME_T_MAX): New macros.
8352 (time_overflow): Move earlier, to before first use.
8353 (hi_time, lo_time): New functions, for an accurate test for
8355 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8356 (Fget_internal_run_time): Don't assume time_t fits in int.
8357 (make_time): Use list2 instead of Fcons twice.
8358 (Fdecode_time): More accurate test for out-of-range times.
8359 (check_tm_member): New function.
8360 (Fencode_time): Use it, to test for out-of-range times.
8361 (lisp_time_argument): Don't rely on undefined left-shift and
8362 right-shift behavior when checking for time stamp overflow.
8364 * editfns.c (time_overflow): New function, refactoring common code.
8365 (Fformat_time_string, Fdecode_time, Fencode_time):
8366 (Fcurrent_time_string): Use it.
8368 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8369 * dired.c (make_time): Move to ...
8370 * editfns.c (make_time): ... here.
8371 * systime.h: Note the move.
8373 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8375 * fringe.c (update_window_fringes): Remove unused variables.
8377 * unexmacosx.c (copy_data_segment): Also copy __got section.
8380 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8382 * termcap.c [MSDOS]: Include "msdos.h".
8383 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8384 Constify `char *' arguments and their references according to
8385 prototypes in tparam.h.
8387 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8389 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8390 Adapt all references accordingly.
8392 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8394 2011-03-11 Tom Tromey <tromey@redhat.com>
8396 * buffer.c (syms_of_buffer): Remove obsolete comment.
8398 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8400 * termhooks.h (encode_terminal_code): Declare prototype.
8402 * msdos.c (encode_terminal_code): Don't declare prototype.
8404 * term.c (encode_terminal_code): Now external again, used by
8405 w32console.c and msdos.c.
8407 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8408 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8410 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8412 Fix some minor problems found by GCC 4.5.2's static checks.
8414 * fringe.c (update_window_fringes): Mark locals as initialized
8416 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8418 * alloc.c (mark_fringe_data): Move decl from here ...
8419 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8420 to check its interface.
8421 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8423 * fontset.c (free_realized_fontset): Now static.
8424 (Fset_fontset_font): Rename local to avoid shadowing.
8425 (fontset_font): Mark local as initialized.
8426 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8428 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8430 * xselect.c (x_disown_buffer_selections): Remove; not used.
8431 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8432 (x_own_selection, Fx_disown_selection_internal): Rename locals
8434 (x_handle_dnd_message): Remove local to avoid shadowing.
8436 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8437 so that the caller can use some name other than gcpro1.
8438 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8439 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8440 (Fx_backspace_delete_keys_p):
8441 Use them to avoid shadowing, and rename vars to avoid shadowing.
8442 (x_decode_color, x_set_name, x_window): Now static.
8443 (Fx_create_frame): Add braces to silence GCC warning.
8444 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8445 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8446 Remove unused locals.
8447 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8448 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8449 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8452 * xterm.h (x_mouse_leave): New decl.
8454 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8455 Remove unused functions.
8456 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8457 (x_calc_absolute_position): Now static.
8458 (XTread_socket): Don't define label "out" unless it's used.
8459 Don't declare local "event" unless it's used.
8460 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8461 unless they are used.
8462 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8463 (x_fatal_error_signal): Remove; not used.
8464 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8465 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8466 (x_error_catcher, x_connection_closed, x_error_handler):
8467 (x_error_quitter, xembed_send_message, x_iconify_frame):
8468 (my_log_handler): Rename locals to avoid shadowing.
8469 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8470 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8472 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8473 Rename or move locals to avoid shadowing.
8474 (tty_defined_color, merge_face_heights): Now static.
8475 (free_realized_faces_for_fontset): Remove; not used.
8476 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8477 does not deduce is never used uninitialized.
8478 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8479 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8481 * terminal.c (store_terminal_param): Now static.
8483 * xmenu.c (menu_highlight_callback): Now static.
8484 (set_frame_menubar): Remove unused local.
8485 (xmenu_show): Rename parameter to avoid shadowing.
8486 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8487 since they might point to immutable storage.
8488 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8489 since it's unused otherwise.
8491 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8492 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8493 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8494 avoids a gcc -Wuninitialized diagnostic.
8495 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8496 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8497 does not deduce are never used uninitialized.
8499 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8501 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8502 * window.c (window_loop, size_window):
8503 (run_window_configuration_change_hook, enlarge_window): Likewise.
8505 * window.c (display_buffer): Now static.
8506 (size_window): Mark variables that gcc -Wuninitialized
8507 does not deduce are never used uninitialized.
8508 * window.h (check_all_windows): New decl, to forestall
8509 gcc -Wmissing-prototypes diagnostic.
8510 * dispextern.h (bidi_dump_cached_states): Likewise.
8512 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8514 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8516 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8517 and to avoid gcc -Wuninitialized warning.
8518 (load_charset_map): Mark variables that gcc -Wuninitialized
8519 does not deduce are never used uninitialized.
8520 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8522 * coding.c (coding_set_source, coding_set_destination):
8523 Use "else { /* comment */ }" rather than "else /* comment */;"
8524 for clarity, and to avoid gcc -Wempty-body warning.
8525 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8526 a block, when the outer 'i' will do.
8527 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8528 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8529 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8530 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8531 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8532 Rename locals to avoid shadowing.
8533 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8534 * coding.c (emacs_mule_char, encode_invocation_designation):
8535 Now static, since they're not used elsewhere.
8536 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8537 (decode_coding_object, encode_coding_object, detect_coding_system):
8538 (decode_coding_emacs_mule): Mark variables that gcc
8539 -Wuninitialized does not deduce are never used uninitialized.
8540 (detect_coding_iso_2022): Initialize a local variable that might
8541 be used uninitialized. Leave a FIXME because it's not clear that
8542 this initialization is needed. (Bug#8211)
8543 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8544 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8545 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8546 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8547 Remove unused macros.
8549 * category.c (hash_get_category_set): Remove unused local var.
8550 (copy_category_table): Now static, since it's not used elsewhere.
8551 * character.c (string_count_byte8): Likewise.
8553 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8554 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8556 * chartab.c (copy_sub_char_table): Now static, since it's not used
8558 (sub_char_table_ref_and_range, char_table_ref_and_range):
8559 Rename locals to avoid shadowing.
8560 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8562 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8563 (BIDI_BOB): Remove unused macro.
8565 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8566 deduce are never used uninitialized.
8567 * term.c (encode_terminal_code): Likewise.
8569 * term.c (encode_terminal_code): Now static. Remove unused local.
8571 * tparam.h: New file.
8572 * term.c, tparam.h: Include it.
8573 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8574 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8575 Move these decls to tparam.h, and make them agree with what
8576 is actually in tparam.c. The previous trick of using incompatible
8577 decls in different modules does not conform to the C standard.
8578 All callers of tparam changed to use tparam's actual API.
8579 * tparam.c (tparam1, tparam, tgoto):
8580 Use const pointers where appropriate.
8582 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8583 * cm.h (struct cm): Likewise.
8584 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8585 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8586 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8587 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8588 (turn_on_face, init_tty): Likewise.
8589 * termchar.h (struct tty_display_info): Likewise.
8591 * term.c (term_mouse_position): Rename local to avoid shadowing.
8593 * alloc.c (mark_ttys): Move decl from here ...
8594 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8596 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8598 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8600 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8602 * search.c (compile_pattern_1): Remove argument regp, unused since
8603 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8604 (compile_pattern): Don't pass it.
8606 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8608 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8609 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8611 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8613 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8615 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8616 gdk_window_get_screen, gdk_window_get_geometry,
8617 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8618 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8619 (xg_get_pixbuf_from_pixmap): New function.
8620 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8621 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8622 Call xg_get_pixbuf_from_pixmap instead of
8623 gdk_pixbuf_get_from_drawable.
8624 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8625 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8626 (xg_check_special_colors): Use GtkStyleContext and its functions
8628 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8629 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8630 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8631 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8632 Call gtk_widget_get_preferred_size.
8633 (xg_frame_resized): gdk_window_get_geometry only takes 5
8635 (xg_win_to_widget, xg_event_is_for_menubar):
8636 Call gdk_x11_window_lookup_for_display.
8637 (xg_set_widget_bg): New function.
8638 (delete_cb): New function.
8639 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8640 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8641 (xg_set_background_color): Call xg_set_widget_bg.
8642 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8643 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8644 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8645 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8647 (update_frame_tool_bar): Call gtk_widget_hide.
8648 (xg_initialize): Use GDK_KEY_g.
8650 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8652 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8654 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8655 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8656 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8658 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8660 * w32xfns.c (select_palette): Check success of RealizePalette against
8661 GDI_ERROR, not zero.
8663 See ChangeLog.11 for earlier changes.
8669 Copyright (C) 2011 Free Software Foundation, Inc.
8671 This file is part of GNU Emacs.
8673 GNU Emacs is free software: you can redistribute it and/or modify
8674 it under the terms of the GNU General Public License as published by
8675 the Free Software Foundation, either version 3 of the License, or
8676 (at your option) any later version.
8678 GNU Emacs is distributed in the hope that it will be useful,
8679 but WITHOUT ANY WARRANTY; without even the implied warranty of
8680 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8681 GNU General Public License for more details.
8683 You should have received a copy of the GNU General Public License
8684 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.