1 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3 * editfns.c (region_limit): Fix type mismatch.
5 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
7 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
8 undefined. Convert from xassert to eassert.
9 * nsmenu.m: Convert from xassert to eassert.
12 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
14 * editfns.c (region_limit): Clip to narrowing (bug#11770).
16 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
18 Avoid integer overflow on scroll-left and scroll-right.
19 * window.c (HSCROLL_MAX): New macro.
20 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
21 overflow when requested scroll falls outside ptrdiff_t range.
23 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
25 * window.h (struct window): Change type of 'hscroll',
26 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
27 'last_modified' and 'last_overlay_modified' to EMACS_INT.
28 Adjust users accordingly.
29 * xdisp.c (try_cursor_movement): Replace type check with eassert.
30 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
31 from EMACS_INT to ptrdiff_t.
32 (make_window): Omit redundant initialization.
34 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
36 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
38 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
40 * window.h (struct window): Change type of 'use_time' and
41 'sequence_number' from Lisp_Object to int.
42 * frame.c (make_frame): Adjust users accordingly.
43 * print.c (print_object): Likewise.
44 * window.c (select_window, Fwindow_use_time, make_parent_window)
45 (make_window): Likewise.
47 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
49 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
50 enabled with --enable-checking=[all,glyphs] configure option.
51 Fix GLYPH_DEBUG usage assuming that it may be undefined,
52 adjust comments accordingly.
53 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
54 undefined, adjust comments accordingly.
58 * w32term.c: Likewise.
64 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
66 Generalize run-time debugging checks.
67 * dispextern.h (XASSERTS): Remove.
68 * fontset.c (xassert): Remove.
69 Convert from xassert to eassert.
70 * alloc.c: Convert from xassert to eassert.
72 * dispnew.c: Likewise.
76 * gtkutil.c: Likewise.
78 * keyboard.c: Likewise.
80 * process.c: Likewise.
84 * w32console.c: Likewise.
86 * w32term.c: Likewise.
91 * xselect.c: Likewise.
94 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
96 * fns.c (maybe_resize_hash_table): Output message when growing the
99 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
101 * alloc.c (allocate_string_data): Remove dead code.
102 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
103 avoid GCC warning about unused macro.
105 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
107 * alloc.c (allocate_string): Omit intervals initialization.
108 * alloc.c (make_uninit_multibyte_string): Initialize intervals
109 as in make_pure_string and make_pure_c_string.
111 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
113 * alloc.c (allocate_string): Fix last change.
115 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
117 * alloc.c (allocate_string): Remove two redundant calls
118 to memset, add explicit initialization where appropriate.
120 2012-06-27 Glenn Morris <rgm@gnu.org>
122 * lisp.mk (lisp): Remove paths.elc.
124 2012-06-27 Chong Yidong <cyd@gnu.org>
126 * doc.c (Fsubstitute_command_keys): Fix punctuation.
128 2012-06-26 John Wiegley <johnw@newartisans.com>
130 * unexmacosx.c (copy_data_segment): Add two section names used
131 on Mac OS X Lion: __mod_init_func and __mod_term_func.
133 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
134 when building with Clang.
136 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
138 * eval.c (Fapply): Allow calling it with a single argument.
140 2012-06-26 Eli Zaretskii <eliz@gnu.org>
142 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
143 _stricmp and _strnicmp.
144 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
146 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
148 * alloc.c (allocate_window): Zero out non-Lisp part of newly
150 (allocate_process): Likewise for new process.
151 (allocate_terminal): Change to use offsetof.
152 (allocate_frame): Likewise.
153 * frame.c (make_frame): Omit redundant initialization.
154 * window.c (make_parent_window): Use memset.
155 (make_window): Omit redundant initialization.
156 * process.c (make_process): Omit redundant initialization.
157 * terminal.c (create_terminal): Likewise.
159 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
161 * term.c (delete_tty): Remove redundant call to memset.
163 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
165 * alloc.c: Remove build_string.
166 * lisp.h: Define build_string as static inline. This provides
167 a better opportunity to optimize away calls to strlen when the
168 function is called with compile-time constant argument.
169 * image.c (imagemagick_error): Convert to build_string.
170 * w32proc.c (sys_spawnve): Likewise.
171 * xterm.c (x_term_init): Likewise.
173 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
175 Use sprintf return value instead of invoking strlen on result.
176 In the old days this wasn't portable, since some sprintf
177 implementations returned char *. But they died out years ago and
178 Emacs already assumes sprintf returns int.
179 Similarly for float_to_string.
180 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
181 * ccl.c (ccl_driver):
182 * character.c (string_escape_byte8):
183 * data.c (Fnumber_to_string):
185 * print.c (print_object):
186 * xdisp.c (message_dolog):
187 * xfns.c (syms_of_xfns):
188 Use sprintf or float_to_string result to avoid need to call strlen.
189 * data.c (Fnumber_to_string):
190 Use make_unibyte_string, since the string must be ASCII.
191 * lisp.h, print.c (float_to_string): Now returns int length.
192 * term.c (produce_glyphless_glyph):
193 Use sprintf result rather than recomputing it.
195 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
196 * Makefile.in (ALL_CFLAGS):
197 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
198 * gmalloc.c, regex.c: Include <config.h> unconditionally.
200 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
202 * dispextern.h (xstrcasecmp): Define to library function
203 strcasecmp if available.
204 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
206 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
208 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
209 Avoid comma operator.
210 * menu.c (push_submenu_start, push_submenu_end)
211 (push_left_right_boundary, push_menu_pane): Likewise.
212 * msdos.c (dos_rawgetc): Likewise.
214 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
216 * xfns.c (xic_create_fontsetname): Remove redundant calls
219 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
221 * gtkutil.c (get_utf8_string): Remove redundant assignment.
222 sprintf already null-terminates its output.
224 * xfns.c (x_window): Remove redundant cast.
226 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
228 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
229 `const char *' to `char *' to avoid compiler warning.
231 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
233 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
234 instead of truncating it to 63 (admittedly a generous limit).
236 * process.c: Fix spelling and caps in comments.
238 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
240 * emacs.c (setpgrp): Remove definition, unused.
241 * sysdep.c (setpgrp): Remove definition, not used in this file.
243 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
245 * makefile.w32-in: Update dependencies.
247 2012-06-24 Eli Zaretskii <eliz@gnu.org>
249 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
250 (SYSTIME_H): Add nt/inc/sys/time.h.
252 * systime.h [WINDOWSNT]: Include sys/time.h.
254 * s/ms-w32.h (struct timespec): Definition moved from
255 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
257 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
259 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
260 * buffer.h (buffer_slot_type_mismatch):
261 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
262 * eval.c (unwind_to_catch):
263 * image.c (my_png_error, my_error_exit):
264 * keyboard.c (quit_throw_to_read_char, user_error)
265 (Fexit_recursive_edit, Fabort_recursive_edit):
266 * lisp.h (die, args_out_of_range, args_out_of_range_3)
267 (wrong_type_argument, buffer_overflow, __executable_start)
268 (memory_full, buffer_memory_full, string_overflow, Fthrow)
269 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
270 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
272 (child_setup) [!DOS_NT]:
273 * lread.c (end_of_file_error, invalid_syntax):
274 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
275 * puresize.h (pure_write_error):
276 * search.c (matcher_overflow):
277 * sound.c (sound_perror, alsa_sound_perror):
278 * sysdep.c, syssignal.h (croak):
279 * term.c (maybe_fatal, vfatal):
280 * textprop.c (text_read_only):
281 * undo.c (user_error):
282 * unexmacosx.c (unexec_error):
283 * xterm.c (x_ins_del_lines, x_delete_glyphs):
284 Use _Noreturn rather than NO_RETURN.
285 No need for separate decl merely because of _Noreturn.
286 * sound.c (sound_warning, parse_sound):
287 Remove unnecessary forward decls.
289 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
291 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
292 * lisp.h (WAIT_READING_MAX): New macro.
293 * dispnew.c (Fsleep_for, sit_for):
294 * keyboard.c (kbd_buffer_get_event):
295 * process.c (Faccept_process_output):
296 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
297 This improves on the previous patch, which introduced a bug
298 when time_t is unsigned and as wide as intmax_t.
299 See <http://bugs.gnu.org/9000#51>.
301 2012-06-23 Eli Zaretskii <eliz@gnu.org>
303 * dispnew.c (sit_for, Fsleep_for):
304 * keyboard.c (kbd_buffer_get_event):
305 * process.c (Faccept_process_output): Avoid compiler warnings when
306 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
308 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
310 * makefile.w32-in: Update dependencies.
312 * w32.c (ltime): Add return type and declare static.
313 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
315 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
317 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
318 Privately reported by Herbert J. Skuhra.
319 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
321 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
322 not make_lisp_timeval, when the argument is of type EMACS_TIME.
324 2012-06-23 Eli Zaretskii <eliz@gnu.org>
326 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
327 last argument of make_unibyte_string.
329 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
330 language ID in the event parameters.
332 * w32term.c (w32_read_socket): Put the new keyboard codepage into
333 event.code, not the obscure "character set ID".
335 2012-06-23 Chong Yidong <cyd@gnu.org>
337 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
339 2012-06-23 Eli Zaretskii <eliz@gnu.org>
341 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
342 * w32.c (fdutimens): New function.
344 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
346 * s/ms-w32.h (pselect): Redirect to sys_select.
348 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
350 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
351 in the logic of incrementing and decrementing the value of
352 use_relocatable_buffers.
354 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
356 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
357 Privately reported by Herbert J. Skuhra.
358 [__FreeBSD__]: Remove "*/" typo after "#include".
359 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
360 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
361 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
362 Don't assume EMACS_TIME and struct timeval are the same type.
364 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
366 Support higher-resolution time stamps (Bug#9000).
367 The time stamps are only nanosecond-resolution at the C level,
368 since that's the best that any real-world system supports now.
369 But they are picosecond-resolution at the Lisp level, as that's
370 easy, and leaves room for future OS improvements.
372 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
375 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
376 Don't get current time unless it's needed.
378 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
379 now provides it if it's absent.
380 (start_atimer): Port to higher-res time stamps.
381 Check for time stamp overflow. Don't get current time more
382 often than is needed.
384 * buffer.h (struct buffer): Buffer modtime now has high resolution.
385 Include systime.h, not time.h.
386 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
388 * dired.c: Include stat-time.h.
389 (Ffile-attributes): File times now have higher resolution.
391 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
392 (struct image): Timestamp now has higher resolution.
394 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
395 has at least microseconds now. All uses removed.
396 (update_frame, update_single_window, update_window, update_frame_1)
397 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
399 * editfns.c (time_overflow): Now extern.
400 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
401 (float-time, Fformat_time_string, Fcurrent_time_string)
402 (Fcurrent_time_zone): Accept and generate higher-resolution
404 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
405 (decode_time_components, lisp_seconds_argument): New functions.
406 (make_time): Now static.
407 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
408 Report an error if the time is invalid, rather than having the caller
411 * fileio.c: Include <stat-time.h>
412 (Fcopy_file): Copy higher-resolution time stamps.
413 Prefer to set the time stamp via a file descriptor if that works.
414 (Fset_file_times, Finsert_file_contents, Fwrite_region)
415 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
416 (Fvisited_file_modtime, Fset_visited_file_modtime):
417 Support higher-resolution time stamps.
419 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
421 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
423 * image.c (prepare_image_for_display, clear_image_cache)
424 (lookup_image): Port to higer-resolution time stamps.
426 * keyboard.c (start_polling, bind_polling_period):
427 Check for time stamp overflow.
428 (read_char, kbd_buffer_get_event, timer_start_idle)
429 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
430 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
431 Port to higher-resolution time stamps. Do not assume time_t is signed.
432 (decode_timer): New function. Timers are now vectors of length 9,
433 not 8, to accommodate the picosecond component.
434 (timer_check_2): Use it.
436 * nsterm.m (select_timeout, timeval_subtract): Remove.
437 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
438 as they're a bit more accurate and handle overflow better.
439 (ns_select): Change prototype to be compatible with pselect.
440 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
441 * nsterm.h (ns_select): Adjust prototype.
443 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
444 us-resolution time stamps.
445 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
447 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
449 * lisp.h (time_overflow): New decl.
450 (wait_reading_process_output): First arg is now intmax_t, not int,
451 to accommodate larger waits.
453 * process.h (struct Lisp_Process.read_output_delay):
454 Now counts nanoseconds, not microseconds.
455 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
457 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
458 (wait_reading_process_output):
459 Port to ns-resolution time stamps.
460 (Faccept_process_output, wait_reading_process_output):
461 Check for time stamp overflow. Do not assume time_t is signed.
462 (select_wrapper): Remove; we now use pselect.
463 (Fprocess_attributes): Now generates ns-resolution time stamps.
465 * sysdep.c: Include utimens.h. Don't include utime.h
466 or worry about struct utimbuf; gnulib does that for us now.
467 (gettimeofday): Remove; gnulib provides a substitute.
468 (make_timeval): New function.
469 (set_file_times): Now sets ns-resolution time stamps.
470 New arg FD; all uses changed.
471 (time_from_jiffies, ltime_from_jiffies, get_up_time)
472 (system_process_attributes):
473 Now returns ns-resolution time stamp. All uses changed.
474 Check for time stamp overflow.
476 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
477 provides a substitute now.
479 * systime.h: Include timespec.h rather than sys/time.h and time.h,
480 since it guarantees struct timespec.
481 (EMACS_TIME): Now struct timespec, so that we can support
482 ns-resolution time stamps.
483 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
484 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
485 (EMACS_USECS): Remove.
486 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
487 so multiply the arg by 1000 before storing it.
488 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
490 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
491 Port to ns-resolution time stamps.
492 (EMACS_TIME_NEG_P): Remove; replaced by....
493 (EMACS_TIME_SIGN): New macro.
494 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
495 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
496 (set_file_times, make_time, lisp_time_argument): Adjust signature.
497 (make_timeval, make_lisp_time, decode_time_components): New decls.
498 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
499 that it mishandled time_t overflow. You can't compare by subtracting!
500 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
501 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
503 * term.c: Include <sys/time.h>.
504 (timeval_to_Time): New function, for proper overflow wraparound.
505 (term_mouse_position, term_mouse_click): Use it.
507 * undo.c (record_first_change): Support higher-resolution time stamps
509 (Fprimitive_undo): Use them when restoring time stamps.
511 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
512 (w32_get_internal_run_time):
513 Port to higher-resolution Emacs time stamps.
514 (ltime): Now accepts single 64-bit integer, as that's more convenient
517 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
519 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
520 for compatibility with pselect. Support ns-resolution time stamps.
522 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
524 * xselect.c (wait_for_property_change, x_get_foreign_selection):
525 Check for time stamp overflow, and support ns-resolution time stamps.
527 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
528 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
529 (timeval_subtract): Remove; no longer needed.
530 (XTflash, XTring_bell, x_wait_for_event):
531 Port to ns-resolution time stamps. Don't assume time_t is signed.
533 2012-06-22 Chong Yidong <cyd@gnu.org>
535 * xdisp.c (x_consider_frame_title): Revert last change.
537 2012-06-22 Eli Zaretskii <eliz@gnu.org>
539 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
540 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
541 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
542 staticidx goes up to 1597 out of 1600 = 0x640.)
544 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
546 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
547 Otherwise, the umask might be mistakenly 0 while handling input signals.
549 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
551 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
553 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
555 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
556 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
557 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
558 access to `contents' member of Lisp_Vector objects with AREF and ASET
561 2012-06-19 Chong Yidong <cyd@gnu.org>
563 * frame.c (delete_frame): When selecting a frame on a different
564 text terminal, do not alter the terminal's top-frame.
566 * xdisp.c (format_mode_line_unwind_data): Record the target
567 frame's selected window and its terminal's top-frame.
568 (unwind_format_mode_line): Restore them.
569 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
571 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
572 since tty frames can be explicitly named.
573 (prepare_menu_bars): Likewise.
575 * term.c (Ftty_top_frame): New function.
577 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
579 Port byte-code-meter to modern targets.
580 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
581 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
582 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
583 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
584 (METER_1, METER_2): Simplify.
586 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
588 * data.c (Fdefalias): Return `symbol' (bug#11686).
590 2012-06-18 Martin Rudalics <rudalics@gmx.at>
592 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
593 gets killed during executing of this function (Bug#11665).
594 Try to always return Qt when the buffer has been actually killed.
595 (Vkill_buffer_query_functions): In doc-string say that functions
596 run by this hook should not change the current buffer.
598 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
600 Fix recently-introduced process.c problems found by static checking.
601 * process.c (write_queue_push, write_queue_pop, send_process):
602 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
603 (write_queue_pop): Fix pointer signedness problem.
604 (send_process): Remove unused local.
606 2012-06-17 Chong Yidong <cyd@gnu.org>
608 * xdisp.c (redisplay_internal): No need to redisplay terminal
609 frames that are not on top.
611 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
613 * process.c (make_process): Initialize write_queue.
614 (write_queue_push, write_queue_pop): New functions.
615 (send_process): Use them to maintain correct ordering of process
618 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
620 * lisp.h (eassert): Assume C89 or later.
621 This removes the need for CHECK.
622 (CHECK): Remove. Its comments about always evaluating its
623 argument were confusing, as 'eassert' typically does not evaluate
626 * coding.c (produce_chars): Use ptrdiff_t, not int.
628 * xterm.c (x_draw_underwave): Check for integer overflow.
629 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
631 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
633 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
634 referenced (Bug#11583).
636 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
638 Implement wave-style variant of underlining.
639 * dispextern.h (face_underline_type): New enum.
640 (face): Add field for underline type.
641 * nsterm.m (ns_draw_underwave): New function.
642 (ns_draw_text_decoration): Use it.
643 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
645 (x_draw_glyph_string): Use them.
646 * xfaces.c (Qline, Qwave): New Lisp objects.
647 (check_lface_attrs, merge_face_ref)
648 (Finternal_set_lisp_face_attribute, realize_x_face):
649 Handle wave-style underline face attributes.
650 * xterm.c (x_draw_underwave): New function.
651 (x_draw_glyph_string): Use it.
653 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
655 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
656 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
657 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
658 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
659 ($(BLD)/w32select.$(O)): Update dependencies.
661 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
663 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
664 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
665 * character.c (_fetch_multibyte_char_p): Remove.
666 * alloc.c: Include "character.h" before "buffer.h".
668 * buffer.c: Likewise.
669 * bytecode.c: Likewise.
670 * callint.c: Likewise.
671 * callproc.c: Likewise.
672 * casefiddle.c: Likewise.
673 * casetab.c: Likewise.
674 * category.c: Likewise.
676 * coding.c: Likewise.
677 * composite.c: Likewise.
679 * dispnew.c: Likewise.
681 * dosfns.c: Likewise.
682 * editfns.c: Likewise.
684 * fileio.c: Likewise.
685 * filelock.c: Likewise.
687 * fontset.c: Likewise.
688 * fringe.c: Likewise.
689 * indent.c: Likewise.
690 * insdel.c: Likewise.
691 * intervals.c: Likewise.
692 * keyboard.c: Likewise.
693 * keymap.c: Likewise.
695 * macros.c: Likewise.
696 * marker.c: Likewise.
697 * minibuf.c: Likewise.
699 * nsmenu.m: Likewise.
701 * process.c: Likewise.
703 * region-cache.c: Likewise.
704 * search.c: Likewise.
705 * syntax.c: Likewise.
707 * textprop.c: Likewise.
709 * unexsol.c: Likewise.
710 * w16select.c: Likewise.
711 * w32fns.c: Likewise.
712 * w32menu.c: Likewise.
713 * window.c: Likewise.
718 * xselect.c: Likewise.
720 2012-06-16 Eli Zaretskii <eliz@gnu.org>
722 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
723 If all the glyphs of the glyph row came from strings, and we have no
724 cursor positioning clues, put the cursor on the first glyph of the
726 (handle_face_prop): Use chunk-relative overlay string index when
727 indexing into it->string_overlays array. (Bug#11653)
728 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
729 the rightmost. (Bug#11720)
731 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
733 * category.h (CHAR_HAS_CATEGORY): Define as inline.
734 (CATEGORY_MEMBER): Enforce 1/0 value.
735 * category.c (_temp_category_set): Remove.
737 2012-06-16 Eli Zaretskii <eliz@gnu.org>
739 * window.c (Fdelete_other_windows_internal)
740 (Fdelete_window_internal): Don't access frame's mouse highlight
741 info of the initial frame. (Bug#11677)
743 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
745 * .gdbinit (xgetint): Fix recently-introduced paren typo.
746 Assume USE_2_TAGS_FOR_INTS.
747 (xreload): Adjust $tagmask width to match recent lisp.h change.
749 Simplify lisp.h in minor ways that should not affect code.
750 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
751 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
752 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
753 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
754 (INTTYPEBITS): New macro, for clarity.
755 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
756 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
757 Simplify now that USE_LSB_TAG is always defined.
758 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
759 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
761 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
763 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
765 2012-06-13 Glenn Morris <rgm@gnu.org>
767 * s/bsd-common.h (BSD4_3):
768 * s/usg5-4-common.h (USG5_4): No longer define; unused.
770 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
772 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
775 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
777 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
778 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
779 * alloc.c (widen_to_Lisp_Object): Remove.
780 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
781 * frame.c (delete_frame): Remove outdated comment.
782 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
784 (Fw32_unregister_hot_key): Likewise.
785 (Fw32_toggle_lock_key): Likewise.
786 * w32menu.c (add_menu_item): Likewise.
787 (w32_menu_display_help): Use XIL instead of checking
789 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
790 (init_heap): Likewise.
791 * w32term.c (w32_read_socket): Update comment.
793 2012-06-13 Glenn Morris <rgm@gnu.org>
795 * s/usg5-4-common.h, src/s/unixware.h:
796 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
798 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
800 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
802 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
803 * alloc.c (make_number) [!defined make_number]:
804 Remove, as lisp.h always defines this now.
805 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
806 (roundup_size): Verify that it is a power of 2.
807 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
808 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
809 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
810 -DUSE_LSB_TAG=0, to override the automatically-selected default.
811 USE_LSB_TAG now is always defined to be either 0 or 1.
813 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
814 code works fine either way, and efficiency is not a concern here,
815 as the union type is for debugging, not for production.
816 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
817 Use an inline function on all platforms when using the union type,
818 since this is simpler and 'static inline' can be used portably
820 (LISP_INITIALLY_ZERO): New macro.
821 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
822 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
824 2012-06-12 Glenn Morris <rgm@gnu.org>
826 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
828 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
830 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
831 Move BROKEN_SIGIO to configure.
833 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
834 Move NO_TERMIO to configure.
836 2012-06-12 Chong Yidong <cyd@gnu.org>
838 * image.c (imagemagick_load_image): Use MagickFlattenImage if
839 MagickMergeImageLayers is undefined. Use pixel pusher loop if
840 MagickExportImagePixels is undefined.
842 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
844 * image.c (imagemagick_load_image): Remove unused label.
846 2012-06-11 Glenn Morris <rgm@gnu.org>
848 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
849 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
850 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
851 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
853 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
855 * alloc.c (make_byte_code): New function.
856 (Fmake_byte_code): Use it. Don't purify here.
857 * lread.c (read1): Use it as well to avoid extra allocation.
859 2012-06-11 Chong Yidong <cyd@gnu.org>
861 * image.c (imagemagick_load_image): Implement transparency.
863 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
865 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
866 account for preceding backslashes. (Bug#11663)
868 2012-06-09 Chong Yidong <cyd@gnu.org>
870 * term.c: Support italics in capable terminals (Bug#9652).
871 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
872 (turn_on_face): Output using TS_enter_italic_mode if available.
873 Don't handle unused blinking and alt-charset cases.
874 (turn_off_face): Handle italic case; discard unused tty_blinking_p
875 and tty_alt_charset_p cases.
876 (tty_capable_p, init_tty): Support italics.
878 * termchar.h (struct tty_display_info): Add field for italics.
879 Remove unused blink field.
881 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
884 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
885 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
886 tty_alt_charset_p. Add tty_italic_p.
888 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
890 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
891 dbus_type_is_basic if available.
892 (xd_extract_signed, xd_extract_unsigned): Rename from
893 extract_signed and extract_unsigned, respectively. Adapt callers.
895 2012-06-09 Chong Yidong <cyd@gnu.org>
897 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
899 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
902 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
904 * xdisp.c (vmessage): Treat frame message as multibyte.
905 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
906 would generate the diagnostic "Making \302\247 buffer-local while
909 2012-06-08 Eli Zaretskii <eliz@gnu.org>
911 * dispnew.c (showing_window_margins_p): Undo last change, which
912 was done due to an inadvertent commit.
913 (adjust_frame_glyphs_for_frame_redisplay): Do call
914 showing_window_margins_p.
916 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
918 * eval.c (Fmake_var_non_special): New primitive.
919 (syms_of_eval): Defsubr it.
920 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
922 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
924 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
925 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
927 2012-06-08 Eli Zaretskii <eliz@gnu.org>
929 * alloc.c (allocate_vectorlike): Fix last change.
931 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
933 Block-based vector allocation of small vectors.
934 * lisp.h (struct vectorlike_header): New field `nbytes',
935 adjust comment accordingly.
936 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
937 to denote vector blocks. Adjust users (live_vector_p,
938 mark_maybe_pointer, valid_lisp_object_p) accordingly.
939 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
940 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
941 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
942 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
943 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
944 (roundup_size): New constant.
945 (struct vector_block): New data type.
946 (vector_blocks, vector_free_lists, zero_vector): New variables.
947 (all_vectors): Rename to `large_vectors'.
948 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
949 (sweep_vectors): New functions.
950 (allocate_vectorlike): Return `zero_vector' as the only vector of
951 0 items. Allocate new vector from block if vector size is less than
952 or equal to VBLOCK_BYTES_MAX.
953 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
954 (init_alloc_once): Add call to init_vectors.
956 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
958 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
960 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
962 * doprnt.c (doprnt): Truncate multibyte char correctly.
963 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
964 would mishandle a string argument "Xc" if X was a multibyte
965 character of length 2: it would truncate after X's first byte
966 rather than including all of X.
968 2012-06-06 Chong Yidong <cyd@gnu.org>
970 * buffer.c (word_wrap): Doc fix.
972 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
974 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
976 2012-06-03 Glenn Morris <rgm@gnu.org>
978 * xdisp.c (tool-bar-style): Doc fix.
980 2012-06-03 Ulrich Müller <ulm@gentoo.org>
982 * Makefile.in (PAXCTL): Define.
983 (temacs$(EXEEXT)): Disable memory randomization for the temacs
984 binary via PaX flags if the paxctl utility is available.
985 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
986 Restore PaX flags to their default. (Bug#11398)
988 2012-06-03 Chong Yidong <cyd@gnu.org>
990 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
993 2012-06-03 Chong Yidong <cyd@gnu.org>
995 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
996 (note_mode_line_or_margin_highlight): If there is no help echo,
997 use mode-line-default-help-echo. Handle the case where the mouse
998 position is past the end of the mode line string.
1000 * buffer.c (buffer_local_value_1): New function, split from
1001 Fbuffer_local_value; can return Qunbound.
1002 (Fbuffer_local_value): Use it.
1003 (Vmode_line_format): Docstring tweaks.
1005 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1007 * sysdep.c (system_process_attributes): Improve comment.
1009 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1011 * keyboard.c: Export real-this-command to Elisp.
1012 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1013 and DEFVAR it. Update all users.
1015 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1017 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1019 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1020 Convert pctcpu and pctmem to Lisp float properly.
1021 Let the compiler fold better, as 100.0/0x8000 is exact.
1023 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1025 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1028 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1030 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1032 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1034 For a 'struct window', replace some Lisp_Object fields to
1035 bitfields where appropriate, remove unused fields.
1036 * window.h (struct window): Remove unused 'last_mark_x' and
1037 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1038 change it's type from Lisp_Object to bitfield.
1039 Change type of 'force_start', 'optional_new_start',
1040 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1041 fields from Lisp_Object to bitfield. Adjust users accordingly.
1043 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1045 Pacify gcc -Wdouble-precision when using Xaw.
1046 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1047 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1048 Use 'float' consistently, rather than 'float' in most places
1049 and 'double' in a couple of places.
1051 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1053 * xdisp.c (handle_stop): Detect whether we have overlay strings
1054 loaded by testing it->current.overlay_string_index to be
1055 non-negative, instead of checking whether n_overlay_strings is
1056 positive. (Bug#11587)
1058 2012-05-31 Chong Yidong <cyd@gnu.org>
1060 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1062 * doc.c (Fsubstitute_command_keys): Doc fix.
1064 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1066 * search.c (search_buffer): Remove calls to
1067 r_alloc_inhibit_buffer_relocation, as it is now called by
1068 maybe_unify_char, which was the cause of relocation of buffer text
1071 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1073 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1074 for the duration of call to load_charset, to avoid problems with
1075 callers of maybe_unify_char that access buffer text through C
1078 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1079 decrement the inhibition flag, instead of just setting or
1082 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1084 Remove obsolete '#define static' cruft.
1085 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1086 This #undef was "temporary" in 2000; it is no longer needed
1087 now that '#define static' has gone away.
1088 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1089 (gray_bitmap_bits): Remove; no longer needed.
1090 All uses replaced with definiens.
1091 * xterm.c: Include "bitmaps/gray.xbm".
1093 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1095 Clean up __executable_start, monstartup when --enable-profiling.
1096 The following changes affect the code only when profiling.
1097 * dispnew.c (__executable_start): Rename from safe_bcopy.
1098 Define only on platforms that need it.
1099 * emacs.c: Include <sys/gmon.h> when profiling.
1100 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1101 (__executable_start): Remove decl, since lisp.h does it now.
1102 (safe_bcopy): Remove decl; no longer has that name.
1103 (main): Coalesce #if into single bit of code, for simplicity.
1104 Cast pointers to uintptr_t, since standard libraries want integers
1106 * lisp.h (__executable_start): New decl.
1108 2012-05-31 Glenn Morris <rgm@gnu.org>
1110 * image.c (Fimagemagick_types): Doc fix.
1112 2012-05-30 Jim Meyering <meyering@redhat.com>
1114 * callproc.c (Fcall_process_region): Include directory component
1115 in mkstemp error message (Bug#11586).
1117 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1119 * alloc.c, lisp.h (make_pure_vector): Now static.
1121 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1123 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1124 Move to byte-run.el.
1125 (Fautoload): Do the hash-doc more carefully.
1126 * data.c (Fdefalias): Purify definition, except for keymaps.
1127 (Qdefun): Move from eval.c.
1128 * lisp.h (Qdefun): Remove.
1129 * lread.c (read1): Tiny simplification.
1131 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1133 Do not create empty overlays with the evaporate property (Bug#9642).
1134 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1135 Bug#9642, but explicitly check that the buffer the overlay would
1136 be moved to is live and rearrange lines to make sure that errors
1137 will not put the overlay in an inconsistent state.
1138 (Fdelete_overlay): Cosmetics.
1140 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1142 * w32term.c (my_bring_window_to_top): New function.
1143 (x_raise_frame): Use handle returned by DeferWindowPos, which
1144 could be different from the original one.
1145 Call my_bring_window_to_top instead of my_set_foreground_window.
1148 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1149 by calling BringWindowToTop.
1151 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1152 (WM_EMACS_END): Increase by one.
1154 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1156 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1157 This avoids undefined behavior that might cause the eassert
1158 to not catch an out-of-range value.
1160 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1162 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1163 Update dependencies.
1165 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1167 * bidi.c (bidi_mirror_char): Fix last change.
1169 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1171 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1172 when referring to sectname field in printf format.
1174 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1176 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1177 Only r_alloc_inhibit_buffer_relocation needed to be added;
1178 the others were already declared.
1180 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1181 before checking whether it's out of range. Put the check inside
1183 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1185 2012-05-27 Ken Brown <kbrown@cornell.edu>
1187 * callproc.c (Fcall_process): Restore a line that was accidentally
1188 commented out in the 2011-02-13 change (bug#11547).
1190 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1192 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1193 defined on ralloc.c.
1195 * buffer.c [REL_ALLOC]: Remove prototypes of
1196 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1197 they are now on lisp.h.
1199 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1201 * search.c (search_buffer): Use it to inhibit relocation of buffer
1202 text while re_search_2 is doing its job, because re_search_2 is
1203 passed C pointers to buffer text. (Bug#11519)
1205 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1208 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1209 state after an additional call to move_it_in_display_line_to, keep
1210 the values of it->max_ascent and it->max_descent found for the
1212 (pos_visible_p): Revert the comparison against bottom_y to what it
1213 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1216 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1218 Fix coding-related core dumps with gcc -ftrapv.
1219 The code was computing A - B, where A and B are pointers, and B is
1220 random garbage. This can lead to core dumps on platforms that
1221 have special pointer registers, and it also leads to core dumps on
1222 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1223 A - B only when B is initialized properly.
1224 * coding.c (coding_set_source, coding_set_destination): Return void.
1225 (coding_change_source, coding_change_destinations): New functions,
1226 with the old behaviors of coding_set_source and coding_set_destination.
1227 All callers that need an offset changed to use these new functions.
1229 2012-05-26 Glenn Morris <rgm@gnu.org>
1231 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1233 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1235 Extend mouse support on W32 text-mode console.
1236 * xdisp.c (draw_row_with_mouse_face):
1237 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1239 * w32console.c: Include window.h.
1240 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1242 (initialize_w32_display): Initialize mouse-highlight data.
1244 * w32inevt.c: Include termchar.h and window.h.
1245 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1246 moves, call note_mouse_highlight. If help_echo changed, call
1247 gen_help_event to produce help-echo message in the echo area.
1248 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1251 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1253 * lread.c (read1): Simplify slightly to avoid an overflow warning
1254 with GCC 4.7.0 on x86-64.
1256 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1258 * bidi.c (bidi_mirror_char): Revert last change: an int is
1259 definitely wide enough here.
1261 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1263 Fix integer width and related bugs (Bug#9874).
1264 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1265 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1266 (string_bytes, check_sblock, allocate_string_data):
1267 (compact_small_strings, Fmake_bool_vector, make_string)
1268 (make_unibyte_string, make_multibyte_string)
1269 (make_string_from_bytes, make_specified_string)
1270 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1271 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1274 (allocate_pseudovector):
1275 Use int, not EMACS_INT, where int is wide enough.
1276 (inhibit_garbage_collection, Fgarbage_collect):
1277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1278 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1279 int might not be wide enough.
1280 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1281 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1282 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1283 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1284 (bidi_level_of_next_char, bidi_move_to_visually_next):
1285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1286 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1287 (Fkill_buffer, Fset_buffer_major_mode)
1288 (advance_to_char_boundary, Fbuffer_swap_text)
1289 (Fset_buffer_multibyte, overlays_at, overlays_in)
1290 (overlay_touches_p, struct sortvec, record_overlay_string)
1291 (overlay_strings, recenter_overlay_lists)
1292 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1293 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1294 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1295 (Foverlay_recenter, last_overlay_modification_hooks_used)
1296 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1298 (validate_region): Omit unnecessary test for b <= e,
1299 since that's guaranteed by the previous test.
1300 (adjust_overlays_for_delete): Avoid pos + length overflow.
1301 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1302 (report_overlay_modification):
1303 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1304 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1305 Omit pointer cast, which isn't needed anyway, and doesn't work
1306 after the EMACS_INT -> ptrdiff_t change.
1307 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1308 * buffer.h: Adjust decls to match defn changes elsewhere.
1309 (struct buffer_text, struct buffer):
1310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1311 Use EMACS_INT, not int, where int might not be wide enough.
1312 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1313 not int, to avoid needless 32-bit limit on 64-bit hosts.
1314 (exec_byte_code): Use tighter memory-full test, one that checks
1315 for alloca overflow. Don't compute the address of the object just
1316 before an array, as that's not portable. Use EMACS_INT, not
1317 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1318 * callint.c (Fcall_interactively):
1319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1320 * callproc.c (call_process_kill, Fcall_process):
1321 Don't assume pid_t fits into an Emacs fixnum.
1322 (call_process_cleanup, Fcall_process, child_setup):
1323 Don't assume pid_t fits into int.
1324 (call_process_cleanup, Fcall_process, delete_temp_file)
1325 (Fcall_process_region):
1326 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1327 (Fcall_process): Simplify handling of volatile integers.
1328 Use int, not EMACS_INT, where int will do.
1329 * casefiddle.c (casify_object, casify_region, operate_on_word)
1330 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1332 (casify_object): Avoid integer overflow when overallocating buffer.
1333 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1334 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1335 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1336 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1337 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1338 integers are now checked earlier. All uses replaced with XINT.
1340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1341 For CCL_MapSingle, check that content and value are in int range.
1342 (ccl_driver, Fregister_code_conversion_map):
1343 Check that Vcode_version_map_vector is a vector.
1344 (resolve_symbol_ccl_program): Check that vector header is in range.
1345 Always copy the vector, so that we can check its contents reliably
1346 now rather than having to recheck each instruction as it's being
1347 executed. Check that vector words fit in 'int'.
1348 (ccl_get_compiled_code, Fregister_ccl_program)
1349 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1350 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1351 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1352 contents are in range.
1353 (Fccl_execute_on_string): Check that status is in range.
1354 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1355 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1356 Accept and return EMACS_INT, not int, because callers can pass values
1358 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1359 (multibyte_chars_in_text, parse_str_as_multibyte)
1360 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1361 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1362 (string_escape_byte8, Fget_byte):
1363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1364 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1365 avoid mishandling large integers.
1366 * character.h: Adjust decls to match defn changes elsewhere.
1367 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1368 (Ffind_charset_region):
1369 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1370 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1371 (load_charset_map_from_vector, Fdefine_charset_internal):
1372 Don't assume fixnum fits in int.
1373 (load_charset_map_from_vector, Fmap_charset_chars):
1374 Remove now-unnecessary CHECK_NATNUMs.
1375 (Fdefine_charset_internal): Check ranges here, more carefully.
1376 Don't rely on undefined behavior with signed left shift overflow.
1377 Don't assume unsigned int fits into fixnum, or that fixnum fits
1378 into unsigned int. Don't require max_code to be a valid fixnum;
1379 that's not true for gb10830 4-byte on a 32-bit host. Allow
1380 invalid_code to be a cons, for the same reason. Require code_offset
1381 to be a character. Avoid int overflow if max_char is close
1383 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1384 this is intended anyway and avoids some undefined behavior.
1385 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1386 INDEX_TO_CODE_POINT, as that's what it expects.
1387 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1388 * charset.h (DECODE_CHAR): Return int, not unsigned;
1389 this is what was intended anyway, and it avoids undefined behavior.
1390 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1391 integer-overflow issues.
1392 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1393 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1394 where the argument is EMACS_INT, and this behavior is not intended.
1395 * chartab.c (Fmake_char_table, Fset_char_table_range)
1396 (uniprop_get_decoder, uniprop_get_encoder):
1397 Don't assume fixnum fits in int.
1398 * cmds.c (move_point): New function, that does the gist of
1399 Fforward_char and Fbackward_char, but does so while checking
1400 for integer overflow more accurately.
1401 (Fforward_char, Fbackward_char): Use it.
1402 (Fforward_line, Fend_of_line, internal_self_insert)
1403 (internal_self_insert):
1404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1405 Fix a FIXME, by checking for integer overflow when calculating
1406 target_clm and actual_clm.
1407 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1408 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1409 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1410 (coding_alloc_by_making_gap, alloc_destination)
1411 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1412 (encode_coding_utf_16, detect_coding_emacs_mule)
1413 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1414 (detect_coding_iso_2022, decode_coding_iso_2022)
1415 (encode_invocation_designation, encode_designation_at_bol)
1416 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1417 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1418 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1419 (encode_coding_ccl, encode_coding_raw_text)
1420 (detect_coding_charset, decode_coding_charset)
1421 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1422 (produce_composition, produce_charset, produce_annotation)
1423 (decode_coding, handle_composition_annotation)
1424 (handle_charset_annotation, consume_chars, decode_coding_gap)
1425 (decode_coding_object, encode_coding_object, detect_coding_system)
1426 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1427 (code_convert_region, code_convert_string)
1428 (Fdefine_coding_system_internal)
1429 (coding_set_source, coding_set_destination):
1430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1431 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1432 (Fdefine_coding_system_internal):
1433 Don't assume fixnums fit in int.
1434 (decode_coding_gap, decode_coding_object, encode_coding_object)
1435 (Fread_coding_system, Fdetect_coding_region)
1436 (Funencodable_char_position, Fcheck_coding_systems_region)
1437 (get_translation, handle_composition_annotation, consume_chars):
1438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1439 (consume_chars): Rewrite to not calculate an address outside buffer.
1440 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1441 Don't access memory outside of the args array.
1442 (Fdefine_coding_system_internal): Check for charset-id overflow.
1443 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1444 result of ENCODE_CHAR.
1445 * coding.h: Adjust decls to match defn changes elsewhere.
1446 (struct coding_system):
1447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1448 * composite.c (get_composition_id, find_composition)
1449 (run_composition_function, update_compositions)
1450 (compose_text, composition_gstring_put_cache)
1451 (composition_gstring_p, composition_gstring_width)
1452 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1453 (composition_compute_stop_pos, composition_reseat_it)
1454 (composition_update_it, struct position_record)
1455 (find_automatic_composition, composition_adjust_point)
1456 (Fcomposition_get_gstring, Ffind_composition_internal):
1457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1458 (update_compositions):
1459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1460 * composite.h: Adjust decls to match defn changes elsewhere.
1461 (struct composition):
1462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1463 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1464 Do not attempt to compute the address of the object just before a
1465 buffer; this is not portable.
1467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1468 (Faset): Use int, not EMACS_INT, where int is wide enough.
1469 (Fstring_to_number): Don't assume fixnums fit in int.
1470 (Frem): Don't assume arg is nonnegative.
1471 * dbusbind.c (xd_append_arg): Check for integers out of range.
1472 (Fdbus_call_method): Don't overflow the timeout int.
1473 (extract_signed, extract_unsigned): New functions.
1474 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1475 (xd_get_connection_references): Return ptrdiff_t, not int.
1477 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1478 (xd_read_message_1):
1479 Use int, not unsigned, where the dbus API uses int.
1480 (Fdbus_message_internal): Don't overflow mtype.
1481 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1482 * dired.c (directory_files_internal, file_name_completion, scmp)
1483 (file_name_completion_stat):
1484 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1485 (file_name_completion): Don't overflow matchcount.
1486 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1487 * dispextern.h: Adjust decls to match defn changes elsewhere.
1488 (struct text_pos, struct glyph, struct bidi_saved_info)
1489 (struct bidi_string_data, struct bidi_it, struct composition_it)
1491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1492 (struct display_pos, struct composition_it, struct it):
1493 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1494 * dispnew.c (increment_matrix_positions)
1495 (increment_row_positions, mode_line_string)
1496 (marginal_area_string):
1497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1498 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1499 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1500 (duration_to_sec_usec): New function, to check for overflow better.
1501 (Fsleep_for, sit_for): Use it.
1502 * doc.c (get_doc_string, store_function_docstring):
1503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1504 (get_doc_string, Fsnarf_documentation):
1505 Use int, not EMACS_INT, where int is wide enough.
1507 Use SAFE_ALLOCA, not alloca.
1508 Check for overflow when converting EMACS_INT to off_t.
1509 * doprnt.c (doprnt):
1510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1511 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1512 Don't assume uid_t fits into fixnum.
1513 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1514 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1515 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1516 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1517 (general_insert_function)
1518 (Finsert_char, make_buffer_string, make_buffer_string_both)
1519 (update_buffer_properties, Fbuffer_substring)
1520 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1521 (Fsubst_char_in_region, check_translation)
1522 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1523 (transpose_markers, Ftranspose_regions):
1524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1525 (clip_to_bounds): Move to lisp.h as an inline function).
1526 (Fconstrain_to_field): Don't assume integers are nonnegative.
1527 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1528 (Fsubst_char_in_region, Fsave_restriction):
1529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1530 (Femacs_pid): Don't assume pid_t fits into fixnum.
1531 (lo_time): Use int, not EMACS_INT, when int suffices.
1532 (lisp_time_argument): Check for usec out of range.
1533 (Fencode_time): Don't assume fixnum fits in int.
1534 (Fuser_login_name, Fuser_full_name): Signal an error
1535 if a uid argument is out of range, rather than relying on
1537 (Fformat_time_string): Remove now-unnecessary check.
1538 lisp_time_argument checks for out-of-range usec now.
1539 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1540 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1541 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1542 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1543 (init_cmdargs, Fdump_emacs):
1544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1545 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1546 the bottom (typically) 32 bits of the fixnum.
1547 * eval.c (specpdl_size, call_debugger):
1548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1549 (when_entered_debugger, Fbacktrace_debug):
1550 Don't assume fixnum can fit in int.
1551 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1552 the object just before a buffer; this is not portable.
1553 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1554 (grow_specpdl, unbind_to):
1555 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1556 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1557 (grow_specpdl): Simplify allocation by using xpalloc.
1558 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1559 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1560 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1562 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1565 (Fcopy_file, non_regular_nbytes, read_non_regular)
1566 (Finsert_file_contents):
1567 Use int, not EMACS_INT, where int is wide enough.
1568 (READ_BUF_SIZE): Verify that it fits in int.
1569 (Finsert_file_contents): Check that counts are in proper range,
1570 rather than assuming fixnums fit into ptrdiff_t etc.
1571 Don't assume fixnums fit into int.
1572 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1573 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1574 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1575 (string_char_to_byte, string_byte_to_char)
1576 (string_make_multibyte, string_to_multibyte)
1577 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1578 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1579 (substring_both, Fdelete, internal_equal, Ffillarray)
1580 (Fclear_string, mapcar1)
1581 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1582 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1583 (larger_vector, make_hash_table, maybe_resize_hash_table)
1584 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1585 (Fmaphash, secure_hash):
1586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1587 (concat): Check for string index and length overflow.
1588 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1591 (larger_vector): New API (vec, incr_min, size_max) replaces old
1592 one (vec, new_size, init). This catches size overflow.
1593 INIT was removed because it was always Qnil.
1594 All callers changed.
1595 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1596 the upper bound on a hash table index size.
1597 (make_hash_table, maybe_resize_hash_table): Use it.
1598 (secure_hash): Computer start_byte and end_byte only after
1599 they're known to be in ptrdiff_t range.
1600 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1601 (Ffont_get_glyphs, Ffont_at):
1602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1603 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1604 (Flist_fonts, Fopen_font):
1605 Don't assume fixnum can fit in int.
1606 (check_gstring): Don't assume index can fit in int.
1607 (font_match_p): Check that fixnum is a character, not a nonnegative
1608 fixnum, since the later code needs to stuff it into an int.
1609 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1610 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1611 conversion overflow issues.
1612 (Fopen_font): Check for integer out of range.
1613 (Ffont_get_glyphs): Don't assume index can fit in int.
1614 * font.h: Adjust decls to match defn changes elsewhere.
1615 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1617 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1618 printmax_t, where ptrdiff_t is wide enough.
1619 (Finternal_char_font):
1620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1621 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1622 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1623 (Fset_frame_position, x_set_frame_parameters)
1624 (x_set_line_spacing, x_set_border_width)
1625 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1626 Check that fixnums are in proper range for system types.
1627 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1629 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1630 Use SAFE_ALLOCA_LISP, not alloca.
1631 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1632 intptr_t is wide enough.
1633 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1634 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1635 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1636 Check for fixnum out of range.
1637 * ftfont.c (ftfont_list): Don't assume index fits in int.
1638 Check that fixnums are in proper range for system types.
1639 (ftfont_shape_by_flt):
1640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1641 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1643 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1644 Check that fixnums are in proper range for system types.
1645 * gnutls.h: Adjust decls to match defn changes elsewhere.
1646 * gtkutil.c (xg_dialog_run):
1647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1648 (update_frame_tool_bar):
1649 Check that fixnums are in proper range for system types.
1650 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1651 (lookup_image): Check that fixnums are in range for system types.
1652 * indent.c (last_known_column, last_known_column_point):
1653 (current_column_bol_cache):
1654 (skip_invisible, current_column, check_display_width):
1655 (check_display_width, scan_for_column, current_column_1)
1656 (Findent_to, Fcurrent_indentation, position_indentation)
1657 (indented_beyond_p, Fmove_to_column, compute_motion):
1658 (Fcompute_motion, Fvertical_motion):
1659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1660 (last_known_column_modified): Use EMACS_INT, not int.
1661 (check_display_width):
1663 Check that fixnums and floats are in proper range for system types.
1664 (compute_motion): Don't assume index or fixnum fits in int.
1665 (compute_motion, Fcompute_motion):
1666 Use int, not EMACS_INT, when it is wide enough.
1667 (vmotion): Omit local var start_hpos that is always 0; that way
1668 we don't need to worry about overflow in expressions involving it.
1669 * indent.h: Adjust decls to match defn changes elsewhere.
1671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1672 Use int, not EMACS_INT, where int is wide enough.
1673 Remove unused members ovstring_chars_done and tab_offset;
1675 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1676 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1677 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1678 (make_gap, copy_text, insert, insert_and_inherit)
1679 (insert_before_markers, insert_before_markers_and_inherit)
1680 (insert_1, count_combining_before, count_combining_after)
1681 (insert_1_both, insert_from_string)
1682 (insert_from_string_before_markers, insert_from_string_1)
1683 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1684 (adjust_after_replace, adjust_after_insert, replace_range)
1685 (replace_range_2, del_range, del_range_1, del_range_byte)
1686 (del_range_both, del_range_2, modify_region)
1687 (prepare_to_modify_buffer, signal_before_change)
1688 (signal_after_change, Fcombine_after_change_execute):
1689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1690 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1691 (balance_an_interval, split_interval_right, split_interval_left)
1692 (find_interval, next_interval, update_interval)
1693 (adjust_intervals_for_insertion, delete_node, delete_interval)
1694 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1695 (static_offset_intervals, offset_intervals)
1696 (merge_interval_right, merge_interval_left, make_new_interval)
1697 (graft_intervals_into_buffer, temp_set_point_both)
1698 (temp_set_point, set_point, adjust_for_invis_intang)
1699 (set_point_both, move_if_not_intangible, get_property_and_range)
1700 (get_local_map, copy_intervals, copy_intervals_to_string)
1701 (compare_string_intervals, set_intervals_multibyte_1):
1702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1703 * intervals.h: Adjust decls to match defn changes elsewhere.
1705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1706 * keyboard.c (this_command_key_count, this_single_command_key_start)
1707 (before_command_key_count, before_command_echo_length, echo_now)
1708 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1709 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1710 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1711 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1713 (last_non_minibuf_size, last_point_position, echo_truncate)
1714 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1715 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1716 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1717 (stuff_buffered_input):
1718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1719 (last_auto_save, command_loop_1, read_char):
1720 Use EMACS_INT, not int, to avoid integer overflow.
1721 (record_char): Avoid overflow in total_keys computation.
1722 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1723 * keyboard.h: Adjust decls to match defn changes elsewhere.
1724 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1725 (Fkey_description, Fdescribe_vector, Flookup_key):
1726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1727 (click_position): New function, to check that positions are in range.
1728 (Fcurrent_active_maps):
1730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1731 (Faccessible_keymaps, Fkey_description):
1732 (preferred_sequence_p):
1733 Don't assume fixnum can fit into int.
1734 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1735 Check for integer overflow in size calculations.
1736 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1737 avoid mishandling large integers.
1738 * lisp.h: Adjust decls to match defn changes elsewhere.
1739 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1740 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1741 (struct Lisp_Marker):
1742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1743 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1744 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1745 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1746 All callers changed.
1747 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1748 Assume the arg has valid form, since it always does.
1749 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1750 unsigned integer system type.
1751 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1752 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1753 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1754 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1755 (duration_to_sec_usec): New decl.
1756 * lread.c (read_from_string_index, read_from_string_index_byte)
1757 (read_from_string_limit, readchar, unreadchar, openp)
1758 (read_internal_start, read1, oblookup):
1759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1760 (Fload, readevalloop, Feval_buffer, Feval_region):
1761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1762 (openp): Check for out-of-range argument to 'access'.
1763 (read1): Use int, not EMACS_INT, where int is wide enough.
1764 Don't assume fixnum fits into int.
1765 Fix off-by-one error that can read outside a buffer.
1766 (read_filtered_event): Use duration_to_sec_usec
1767 to do proper overflow checking on durations.
1768 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1769 in size calculation.
1770 (Fexecute_kbd_macro):
1771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1772 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1773 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1774 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1775 (set_marker_both, set_marker_restricted_both, marker_position)
1776 (marker_byte_position, Fbuffer_has_markers_at):
1777 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1778 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1779 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1780 It now merely ensures that the menu is large enough, without
1781 necessarily growing it, as this avoids some integer overflow issues.
1782 All callers changed.
1783 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1785 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1786 Use SAFE_ALLOCA_LISP, not alloca.
1787 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1788 to EMACS_INT. Check that fixnums are in proper range for system types.
1789 * minibuf.c (minibuf_prompt_width, string_to_object)
1790 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1791 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1793 (get_minibuffer, read_minibuf_unwind):
1794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1795 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1796 this simplifies overflow checking. All callers changed.
1797 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1800 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1801 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1802 Check that fixnums are in proper range for system types.
1803 (Fx_create_frame, Fx_show_tip):
1804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1805 * nsfont.m (ns_findfonts, nsfont_list_family):
1806 Don't assume fixnum fits in long.
1807 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1809 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1811 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1813 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1814 (PRINTDECLARE, PRINTPREPARE):
1815 (strout, print_string):
1816 (print, print_preprocess, print_check_string_charset_prop)
1818 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1820 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1822 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1823 (printchar, strout): Use xpalloc to catch size calculation overflow.
1824 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1825 (print_error_message): Use SAFE_ALLOCA, not alloca.
1826 (print_object): Use int, not EMACS_INT, where int is wide enough.
1827 (print_depth, new_backquote_output, print_number_index):
1828 Use ptrdiff_t, not int, where int might not be wide enough.
1829 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1830 (Fset_process_window_size, Fformat_network_address)
1831 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1833 Check that fixnums are in proper range for system types.
1834 (Fsignal_process): Simplify by avoiding a goto.
1835 Check for process-ids out of pid_t range rather than relying on
1837 (process_tick, update_tick): Use EMACS_INT, not int.
1838 (Fformat_network_address, read_process_output, send_process)
1839 (Fprocess_send_region, status_notify):
1840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1841 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1842 (wait_reading_process_output, read_process_output, exec_sentinel):
1843 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1844 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1845 (Faccept_process_output): Use duration_to_sec_usec to do proper
1846 overflow checking on durations.
1847 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1848 Don't assume pid_t fits in int.
1849 * process.h (struct Lisp_Process): Members tick and update_tick
1850 are now of type EMACS_INT, not int.
1851 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1852 configured --with-wide-int.
1853 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1854 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1855 * search.c (looking_at_1, string_match_1):
1856 (fast_string_match, fast_c_string_match_ignore_case)
1857 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1858 (scan_newline, find_before_next_newline, search_command)
1859 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1860 (set_search_regs, wordify):
1863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1864 (string_match_1, search_buffer, set_search_regs):
1866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1867 (wordify): Check for overflow in size calculation.
1868 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1869 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1870 Check that fixnums are in proper range for system types.
1871 * sound.c (struct sound_device)
1872 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1874 (Fplay_sound_internal):
1875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1876 * syntax.c (struct lisp_parse_state, find_start_modiff)
1877 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1878 (Fparse_partial_sexp):
1879 Don't assume fixnums can fit in int.
1880 (struct lisp_parse_state, find_start_pos, find_start_value)
1881 (find_start_value_byte, find_start_begv)
1882 (update_syntax_table, char_quoted, dec_bytepos)
1883 (find_defun_start, prev_char_comend_first, back_comment):
1884 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1885 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1887 (Finternal_describe_syntax_value): Check that match_lisp is a
1888 character, not an integer, since the code stuffs it into int.
1889 (scan_words, scan_sexps_forward):
1890 Check that fixnums are in proper range for system types.
1892 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1893 (scan_sexps_forward):
1894 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1895 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1896 * syntax.h: Adjust decls to match defn changes elsewhere.
1897 (struct gl_state_s):
1898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1899 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1900 MOST_POSITIVE_FIXNUM.
1901 * sysdep.c (wait_for_termination_1, wait_for_termination)
1902 (interruptible_wait_for_termination, mkdir):
1903 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1904 (emacs_read, emacs_write):
1905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1906 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1907 and double all fit in int.
1908 * term.c (set_tty_color_mode):
1909 Check that fixnums are in proper range for system types.
1910 * termhooks.h (struct input_event):
1911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1912 * textprop.c (validate_interval_range, interval_of)
1913 (Fadd_text_properties, set_text_properties_1)
1914 (Fremove_text_properties, Fremove_list_of_text_properties)
1915 (Ftext_property_any, Ftext_property_not_all)
1916 (copy_text_properties, text_property_list, extend_property_ranges)
1917 (verify_interval_modification):
1918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1919 (Fnext_single_char_property_change)
1920 (Fprevious_single_char_property_change):
1921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1922 (copy_text_properties):
1923 Check for integer overflow in index calculation.
1924 * undo.c (last_boundary_position, record_point, record_insert)
1925 (record_delete, record_marker_adjustment, record_change)
1926 (record_property_change):
1927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1928 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1929 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1930 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1931 (Fx_hide_tip, Fx_file_dialog):
1932 * w32menu.c (set_frame_menubar):
1933 Use ptrdiff_t, not int, for consistency with rest of code.
1934 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1935 (select_window, Fdelete_other_windows_internal)
1936 (window_scroll_pixel_based, window_scroll_line_based)
1937 (Frecenter, Fset_window_configuration):
1938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1939 (Fset_window_hscroll, run_window_configuration_change_hook)
1940 (set_window_buffer, temp_output_buffer_show, scroll_command)
1941 (Fscroll_other_window, Frecenter):
1942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1943 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1944 Don't assume fixnum fits in int.
1945 (Fset_window_scroll_bars):
1946 Check that fixnums are in proper range for system types.
1947 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1948 (string_pos, c_string_pos, number_of_chars, init_iterator)
1949 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1950 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1951 (compute_display_string_end, handle_face_prop)
1952 (face_before_or_after_it_pos, handle_invisible_prop)
1953 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1954 (display_prop_intangible_p, string_buffer_position_lim)
1955 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1956 (get_overlay_strings_1, get_overlay_strings)
1957 (iterate_out_of_display_property, forward_to_next_line_start)
1958 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1959 (get_next_display_element, set_iterator_to_next)
1960 (get_visually_first_element, compute_stop_pos_backwards)
1961 (handle_stop_backwards, next_element_from_buffer)
1962 (move_it_in_display_line_to, move_it_in_display_line)
1963 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1964 (add_to_log, message_dolog, message_log_check_duplicate)
1965 (message2, message2_nolog, message3, message3_nolog
1966 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1967 (current_message_1, truncate_echo_area, truncate_message_1)
1968 (set_message, set_message_1, store_mode_line_noprop)
1969 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1970 (text_outside_line_unchanged_p, check_point_in_composition)
1971 (reconsider_clip_changes)
1972 (redisplay_internal, set_cursor_from_row, try_scrolling)
1973 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1974 (redisplay_window, find_last_unchanged_at_beg_row)
1975 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1976 (trailing_whitespace_p, find_row_edges, display_line)
1977 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1978 (display_mode_element, store_mode_line_string)
1979 (pint2str, pint2hrstr, decode_mode_spec)
1980 (display_count_lines, display_string, draw_glyphs)
1981 (x_produce_glyphs, x_insert_glyphs)
1982 (rows_from_pos_range, mouse_face_from_buffer_pos)
1983 (fast_find_string_pos, mouse_face_from_string_pos)
1984 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1986 (safe_call, init_from_display_pos, handle_fontified_prop)
1987 (handle_single_display_spec, load_overlay_strings)
1988 (with_echo_area_buffer, setup_echo_area_for_printing)
1989 (display_echo_area, echo_area_display)
1990 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1991 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1992 (redisplay_window, dump_glyph_row, display_mode_line)
1993 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1994 (handle_display_spec, display_prop_string_p):
1995 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1996 (handle_single_display_spec, build_desired_tool_bar_string)
1997 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1998 (get_specified_cursor_type):
1999 Check that fixnums are in proper range for system types.
2000 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2001 (Flookup_image_map):
2002 Don't assume fixnums fit in int.
2003 (compare_overlay_entries):
2004 Avoid mishandling comparisons due to subtraction overflow.
2005 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2006 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2007 (handle_tool_bar_click):
2008 Use int, not unsigned, since we prefer signed and the signedness
2009 doesn't matter here.
2010 (get_next_display_element, next_element_from_display_vector):
2011 Use int, not EMACS_INT, when int is wide enough.
2012 (start_hourglass): Use duration_to_sec_usec to do proper
2013 overflow checking on durations.
2014 * xfaces.c (Fbitmap_spec_p):
2015 Check that fixnums are in proper range for system types.
2016 (compare_fonts_by_sort_order):
2017 Avoid mishandling comparisons due to subtraction overflow.
2018 (Fx_family_fonts, realize_basic_faces):
2019 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2021 Don't assume fixnum fits in int.
2022 Use SAFE_ALLOCA_LISP, not alloca.
2023 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2024 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2025 (face_at_buffer_position, face_for_overlay_string)
2026 (face_at_string_position):
2027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2028 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2029 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2031 Check that fixnums are in proper range for system types.
2032 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2033 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2035 (Fx_change_window_property): Don't assume fixnums fit in int.
2036 * xfont.c (xfont_chars_supported):
2037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2038 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2039 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2041 * xml.c (parse_region):
2042 * xrdb.c (magic_file_p):
2043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2044 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2045 (x_get_local_selection, x_reply_selection_request)
2046 (x_handle_selection_request, wait_for_property_change):
2047 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2048 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2049 short is wide enough.
2050 (x_send_client_event): Don't assume fixnum fits in int.
2051 * xterm.c (x_x_to_emacs_modifiers):
2052 Don't assume EMACS_INT overflows nicely into int.
2053 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2055 (handle_one_xevent): NATNUMP can eval its arg twice.
2056 (x_connection_closed):
2057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2058 * xterm.h: Adjust decls to match defn changes elsewhere.
2059 (struct scroll_bar): Use struct vectorlike_header
2060 rather than rolling our own approximation.
2061 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2063 2012-05-25 Glenn Morris <rgm@gnu.org>
2065 * lisp.mk (lisp): Update for more files being compiled now.
2067 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2069 * lread.c: Remove `read_pure' which makes no difference.
2070 (read_pure): Remove var.
2071 (unreadpure): Remove function.
2072 (readevalloop): Don't call read_list with -1 flag.
2073 (read1, read_vector): Don't test read_pure any more.
2074 (read_list): Simplify.
2076 * fileio.c, character.h: Minor style tweaks.
2078 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2080 * window.h (clip_changed): Remove useless declaration.
2082 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2084 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2085 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2087 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2090 This directory predates autoconf and is no longer needed nowadays.
2091 Move its few remaining bits of functionality to where they're needed.
2092 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2093 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2094 * m/template.h: Remove.
2095 * Makefile.in (M_FILE): Remove. All uses removed.
2096 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2097 * lisp.h (USE_LSB_TAG):
2098 * mem-limits.h (EXCEEDS_LISP_PTR):
2099 Use VAL_MAX, not VALBITS, in #if.
2100 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2101 (EMACS_UINT): Define unconditionally now.
2102 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2103 (BITS_PER_EMACS_INT): New constants, replacing
2104 what used to be in config.h, but not useful in #if.
2105 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2106 define them any more.
2107 (VAL_MAX): New macro.
2109 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2110 BITS_PER_EMACS_INT, in #if.
2111 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2112 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2113 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2114 * s/ms-w32.h (DATA_START):
2115 Move here from removed file m/intel386.h.
2116 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2117 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2119 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2121 Assume C89 or later.
2122 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2123 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2125 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2126 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2127 * textprop.c, tparam.c (NULL): Remove.
2128 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2129 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2130 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2131 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2132 * xterm.c (input_signal_count): Assume volatile works.
2134 2012-05-21 Ken Brown <kbrown@cornell.edu>
2136 * xgselect.c (xg_select): Fix first argument in call to 'select'
2139 2012-05-20 Ken Brown <kbrown@cornell.edu>
2141 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2142 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2144 2012-05-19 Ken Brown <kbrown@cornell.edu>
2146 * xfns.c (x_in_use): Remove `static' qualifier.
2147 * xterm.h (x_in_use): Declare.
2148 * xgselect.c: Include xterm.h.
2149 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2150 and `display_arg' (bug#9754).
2152 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2154 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2156 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2157 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2159 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2161 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2163 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2164 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2166 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2167 reference to image_cache->refcount.
2168 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2170 2012-05-17 Juri Linkov <juri@jurta.org>
2172 * search.c (Fword_search_regexp, Fword_search_backward)
2173 (Fword_search_forward, Fword_search_backward_lax)
2174 (Fword_search_forward_lax): Move functions to isearch.el
2175 (bug#10145, bug#11381).
2177 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2179 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2181 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2183 * lread.c (init_obarray): Declare Qt and Qnil as special.
2185 2012-05-14 Glenn Morris <rgm@gnu.org>
2187 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2188 Put "libexec" before "bin", for the sake of init_callproc_1.
2190 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2192 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2194 * unexaix.c: Port to more-recent AIX compilers.
2195 (report_error, report_error_1, make_hdr, copy_sym)
2196 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2197 Make arguments const char *, not char *, to avoid violations of C
2198 standard and to fix some AIX warnings reported by Gilles Pion.
2200 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2202 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2203 already have overlays loaded.
2204 (handle_single_display_spec): Before returning without displaying
2205 fringe bitmap, synchronize the bidi iterator with the main display
2206 iterator, by calling iterate_out_of_display_property.
2207 (iterate_out_of_display_property): Detect buffer iteration by
2208 testing that it->string is a Lisp string.
2209 (get_next_display_element): When the current object is exhausted,
2210 and there's something on it->stack, call set_iterator_to_next to
2211 proceed with what's on the stack, instead of returning zero.
2212 (set_iterator_to_next): If called at the end of a Lisp string,
2213 proceed to consider_string_end without incrementing string
2214 position. Don't increment display vector index past the end of
2215 the display vector. (Bug#11417)
2216 (pos_visible_p): Don't report a position visible when move_it_to
2217 stopped at the last line of window, which happens to be scanned
2218 backwards by the bidi iteration. (Bug#11464)
2220 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2222 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2223 and right-margin display specs even if the spec is invalid or we
2224 are on a TTY, and thus unable to display on the fringes.
2225 That's because the text with the property will not be displayed anyway,
2226 so we need to signal to the caller that this is a "replacing"
2227 display spec. This fixes display when the spec is invalid or we
2230 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2232 * unexaix.c (make_hdr): Fix typo in prototype.
2233 This bug broke the build on AIX. Problem reported by Gilles Pion.
2235 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2237 * keyboard.c (kbd_buffer_get_event): Read special events also in
2238 batch mode. (Bug#11415)
2240 2012-05-12 Glenn Morris <rgm@gnu.org>
2242 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2244 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2246 * lisp.mk (lisp): Add newcomment.elc.
2248 2012-05-12 Glenn Morris <rgm@gnu.org>
2250 * Makefile.in (MKDIR_P): New, set by configure.
2251 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2253 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2255 Remove unused function hourglass_started.
2256 * dispextern.h (hourglass_started):
2257 * w32fns.c (hourglass_started):
2258 * xdisp.c (hourglass_started): Remove.
2260 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2262 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2263 Update dependencies.
2265 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2267 * xgselect.c (xg_select): Put maxfds+1 into a var.
2268 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2270 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2272 2012-05-10 Dave Abrahams <dave@boostpro.com>
2274 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2275 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2277 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2279 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2280 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2281 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2282 Initialize xd_registered_buses.
2284 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2286 Untag more efficiently if USE_LSB_TAG.
2287 This is based on a proposal by YAMAMOTO Mitsuharu in
2288 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2289 For an admittedly artificial (nth 8000 longlist) benchmark on
2290 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2291 Emacs's overall text size by 1%.
2292 * lisp.h (XUNTAG): New macro.
2293 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2294 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2295 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2296 * eval.c (Fautoload):
2297 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2298 * frame.h (XFRAME): Use XUNTAG.
2300 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2301 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2302 Remove unportable assumptions about print widths of types like
2304 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2305 intptr_t when converting between pointer and integer, to avoid GCC
2306 warnings about wrong width.
2308 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2310 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2311 stack for each reader_thread, instead of defaulting to 8MB
2312 determined by the linker. This avoids failures in creating
2313 subprocesses on Windows 7, see the discussion in this thread:
2314 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2316 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2318 Fix up display of the *Minibuf-0* buffer in the mini window.
2319 * keyboard.c (read_char): Don't clear the echo area if there's no
2321 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2322 contents of *Minibuf-0*) if there's no message displayed in its stead.
2324 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2326 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2329 2012-05-06 Chong Yidong <cyd@gnu.org>
2331 * lisp.mk (lisp): Update.
2333 2012-05-05 Jim Meyering <meyering@redhat.com>
2335 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2337 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2339 * data.c (PUT_ERROR): New macro.
2340 (syms_of_data): Use it. Add new error type `user-error'.
2341 * undo.c (user_error): New function.
2342 (Fprimitive_undo): Use it.
2343 * print.c (print_error_message): Adjust print style for `user-error'.
2344 * keyboard.c (user_error): New function.
2345 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2347 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2349 Do not limit current-time-string to years 1000..9999.
2350 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2351 (Fcurrent_time_string): Support any year that is supported by the
2352 underlying localtime representation. Don't use asctime, as it
2353 has undefined behavior for years outside the range -999..9999.
2355 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2357 Fix race conditions involving setenv, gmtime, localtime, asctime.
2358 Without this fix, interrupts could mess up code that uses these
2359 nonreentrant functions, since setting TZ invalidates existing
2360 tm_zone or tzname values, and since most of these functions return
2361 pointers to static storage.
2362 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2363 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2364 Grow the critical sections to include not just invoking
2365 localtime/gmtime, but also accessing these functions' results
2366 including their tm_zone values if any, and any related TZ setting.
2367 (format_time_string): Last arg is now struct tm *, not struct tm **,
2368 so that the struct tm is saved in the critical section.
2369 All callers changed. Simplify allocation of initial buffer, partly
2370 motivated by the fact that memory allocation needs to be outside
2371 the critical section.
2373 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2375 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2376 with RESET_INTERVAL.
2378 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2379 Remove duplicated buffer name initialization.
2381 2012-05-02 Jim Meyering <jim@meyering.net>
2383 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2385 * xfns.c (x_window): Use xstrdup (Bug#11375).
2387 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2389 * xdisp.c (pos_visible_p): If already at a newline from the
2390 display string before the 'while' loop, don't walk back the glyphs
2391 from it3.glyph_row. Solves assertion violation when the display
2392 string begins with a newline (egg.el). (Bug#11367)
2394 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2396 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2399 2012-05-01 Glenn Morris <rgm@gnu.org>
2401 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2402 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2403 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2404 All were removed before 23.1.
2406 * dispnew.c: Remove HAVE_LIBNCURSES test;
2407 it is always true on relevant platforms.
2409 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2410 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2412 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2414 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2416 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2417 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2420 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2422 Do not avoid creating empty evaporating overlays (Bug#9642).
2423 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2424 That is, do not delete an evaporating overlay if it becomes
2425 empty after its bounds are adjusted to fit within its buffer.
2426 This fix caused other problems, and I'm reverting it until we get
2427 to the bottom of them.
2429 2012-04-27 Chong Yidong <cyd@gnu.org>
2431 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2433 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2435 * xdisp.c (pos_visible_p): If the window start position is beyond
2436 ZV, start the display from buffer beginning. Prevents assertion
2437 violation in init_iterator when the minibuffer window is scrolled
2440 * window.c (window_scroll_pixel_based): Likewise.
2442 2012-04-27 Chong Yidong <cyd@gnu.org>
2444 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2446 2012-04-27 Glenn Morris <rgm@gnu.org>
2448 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2449 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2451 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2453 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2454 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2456 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2458 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2459 display element, check also the underlying string or buffer
2460 character. (Bug#11341)
2462 * w32menu.c: Include w32heap.h.
2463 (add_menu_item): If the call to AppendMenuW (via
2464 unicode_append_menu) fails, disable Unicode menus only if we are
2465 running on Windows 9X/Me.
2467 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2469 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2470 (xgetint): Add missing shift for LSB tags.
2472 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2474 * keyboard.c (read_char): Don't wipe echo area for select window
2475 events: These might get delayed via `mouse-autoselect-window'
2478 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2480 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2481 manipulation of :loaded-from data.
2483 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2485 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2486 now a cons (bug#11311).
2488 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2490 Do not create empty overlays with the evaporate property (Bug#9642).
2491 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2492 if it becomes empty after its bounds are adjusted to fit within
2493 its buffer. Without this fix, in a nonempty buffer (let ((o
2494 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2495 yields an empty overlay that has the evaporate property, which is
2496 not supposed to happen.
2498 Fix minor GTK3 problems found by static checking.
2499 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2500 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2501 (struct _EmacsFixedClass, emacs_fixed_get_type):
2502 Move decls here from emacsgtkfixed.h, since they needn't be public.
2503 (emacs_fixed_get_type): Now static.
2504 (emacs_fixed_class_init): Omit unused local.
2505 (emacs_fixed_child_type): Remove; unused.
2506 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2507 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2508 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2509 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2510 (EMACS_FIXED_GET_CLASS): Remove; unused.
2511 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2513 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2514 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2516 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2518 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2519 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2520 (__malloc_size_t, __malloc_ptrdiff_t):
2521 Remove. All uses removed, replaced by the definiens if needed,
2522 since we can assume C89 or better now.
2523 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2524 (protect_malloc_state, align, get_contiguous_space)
2525 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2526 (malloc_atfork_handler_child, malloc_enable_thread)
2527 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2528 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2529 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2530 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2531 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2532 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2533 Define using prototypes, not old style.
2534 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2535 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2536 (align): Don't assume that signed integer overflow wraps around.
2537 Omit unused local var.
2538 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2539 (_free_internal_nolock, memalign, mallochook, reallochook):
2540 Omit no-longer-needed casts.
2541 (valloc): Use getpagesize, not __getpagesize.
2542 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2543 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2545 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2547 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2549 Move functions from C to Lisp. Make non-blocking method calls
2550 the default. Implement further D-Bus standard interfaces.
2552 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2553 (QCdbus_request_name_allow_replacement)
2554 (QCdbus_request_name_replace_existing)
2555 (QCdbus_request_name_do_not_queue)
2556 (QCdbus_request_name_reply_primary_owner)
2557 (QCdbus_request_name_reply_in_queue)
2558 (QCdbus_request_name_reply_exists)
2559 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2560 (QCdbus_registered_serial, QCdbus_registered_method)
2561 (QCdbus_registered_signal): New Lisp objects.
2562 (XD_DEBUG_MESSAGE): Use sizeof.
2563 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2564 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2565 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2566 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2567 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2568 (xd_signature, xd_append_arg): Allow float for integer types.
2569 (xd_get_connection_references): New function.
2570 (xd_get_connection_address): Rename from xd_initialize.
2571 Return cached address.
2572 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2573 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2575 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2576 Return number of refcounts.
2577 (Fdbus_get_unique_name): Make stronger parameter check.
2578 (Fdbus_message_internal): New defun.
2579 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2580 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2581 (Fdbus_send_signal, Fdbus_register_service)
2582 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2583 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2584 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2585 (Vdbus_compiled_version, Vdbus_runtime_version)
2586 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2587 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2588 (Vdbus_message_type_signal): New defvars.
2589 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2592 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2594 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2595 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2596 Do not assume ptrdiff_t is the same width as 'int'.
2598 * alloc.c: Handle unusual debugging option combinations.
2599 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2600 since the two debugging options are incompatible.
2601 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2603 (mem_init, mem_insert, mem_insert_fixup):
2604 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2605 (NEED_MEM_INSERT): Remove; no longer needed.
2607 2012-04-22 Leo Liu <sdl.web@gmail.com>
2609 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2611 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2613 * sysdep.c [__FreeBSD__]: Minor cleanups.
2614 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2615 Use Emacs indenting style more consistently. Avoid some casts.
2616 Use 'double' consistently rather than mixing 'float' and 'double'.
2618 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2620 * sysdep.c (list_system_processes, system_process_attributes):
2621 Add implementation for FreeBSD (Bug#5243).
2623 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2625 * lisp.mk (lisp): Update.
2627 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2629 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2630 It is never used otherwise.
2632 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2634 * print.c (print_preprocess): Only check print_depth if print-circle
2636 (print_object): Check for cycles even when print-circle is nil and
2637 print-gensym is t, but only check print_depth if print-circle is nil.
2639 2012-04-20 Chong Yidong <cyd@gnu.org>
2641 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2642 set the status to "failed" and ensure that sentinel is run.
2644 2012-04-20 Glenn Morris <rgm@gnu.org>
2646 * process.c (Fset_process_inherit_coding_system_flag)
2647 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2648 (Fmake_network_process, Fmake_serial_process): Doc fix.
2650 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2652 * xdisp.c (string_buffer_position_lim): Limit starting position to
2654 (set_cursor_from_row): If called for a mode-line or header-line
2655 row, return zero immediately.
2656 (try_cursor_movement): If inside continuation line, don't back up
2657 farther than the first row after the header line, if any.
2658 Don't consider the header-line row as "partially visible", even if
2659 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2661 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2663 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2666 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2667 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2669 configure: new option --enable-gcc-warnings (Bug#11207)
2670 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2671 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2672 (ALL_CFLAGS): Use new macros rather than old.
2673 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2674 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2675 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2676 -Wunused-result, -Wunused-variable. This should go away once
2677 the Emacs and Gnulib regex code is merged.
2678 (xmalloc, xrealloc): Now static.
2680 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2682 * dired.c (Fsystem_groups): Remove unused local.
2684 2012-04-17 Glenn Morris <rgm@gnu.org>
2686 * dired.c (Fsystem_users): Doc fix.
2688 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2690 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2691 (syms_of_dired): Add them.
2693 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2695 Fix minor alloc.c problems found by static checking.
2696 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2697 New extern decls, to avoid calling undeclared functions.
2698 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2699 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2700 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2701 (NEED_MEM_INSERT): New macro.
2702 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2703 Remove one incorrect comment and fix another.
2705 Fix minor ralloc.c problems found by static checking.
2706 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2707 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2708 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2709 (r_alloc_sbrk): Now static.
2711 Improve ralloc.c interface checking.
2712 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2713 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2714 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2715 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2716 [REL_ALLOC]: ... to here, to check interface.
2717 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2718 Remove decls. This fixes an "It stinks!".
2720 * alloc.c (which_symbols): Fix alignment issue / type clash.
2722 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2724 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2725 (struct Lisp_Misc_Any): Likewise.
2726 (struct Lisp_Free): Likewise.
2727 * alloc.c (union aligned_Lisp_Symbol): Define.
2728 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2729 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2730 (union aligned_Lisp_Misc): Define.
2731 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2732 aligned_Lisp_Misc instead of union Lisp_Misc.
2733 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2735 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2737 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2738 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2739 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2740 * s/netbsd.h, s/sol2-6.h:
2741 Remove definition of GC_MARK_STACK, since the default now works.
2742 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2743 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2744 no longer the default.
2745 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2747 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2749 * lread.c (lisp_file_lexically_bound_p):
2750 Fix hang at ";-*-\n" (bug#11238).
2752 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2754 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2755 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2757 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2759 * nsterm.m (constrainFrameRect): Always constrain when there is only
2760 one screen (Bug#10962).
2762 2012-04-13 Ken Brown <kbrown@cornell.edu>
2764 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2766 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2768 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2770 2012-04-11 Daniel Colascione <dancol@dancol.org>
2772 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2773 against is gone. It's better to use vfork now so that when Cygwin
2774 gains a new, working vfork, we use it automatically (bug#10398).
2776 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2778 * window.c (save_window_save): Obey window-point-insertion-type.
2780 2012-04-11 Glenn Morris <rgm@gnu.org>
2782 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2784 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2786 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2788 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2790 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2791 (force_quit_count): New var.
2792 (handle_interrupt): Use it.
2794 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2796 * w32.c (w32_delayed_load): Record the full path of the library
2797 being loaded (bug#10424).
2799 2012-04-09 Glenn Morris <rgm@gnu.org>
2801 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2802 not just in the obarray, before snarfing them. (Bug#11036)
2804 * Makefile.in ($(leimdir)/leim-list.el):
2805 Pass EMACS rather than BUILT_EMACS.
2807 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2809 * process.c (make_process):
2810 * process.h: Add integer `gnutls_handshakes_tried' member to
2813 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2814 Add convenience `GNUTLS_LOG2i' macro.
2816 * gnutls.c (gnutls_log_function2i): Convenience log function.
2817 (emacs_gnutls_read): Use new log functions,
2818 `gnutls_handshakes_tried' process member, and
2819 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2820 attempts per process (connection).
2822 2012-04-09 Chong Yidong <cyd@gnu.org>
2824 * eval.c (Fuser_variable_p, user_variable_p_eh)
2825 (lisp_indirect_variable): Functions deleted.
2826 (Fdefvar): Caller changed.
2828 * callint.c (Finteractive, Fcall_interactively):
2829 * minibuf.c (Fread_variable): Callers changed.
2831 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2833 * xdisp.c (set_cursor_from_row): If the display string appears in
2834 the buffer at position that is closer to point than the position
2835 after the display string, display the cursor on the first glyph of
2836 the display string. Fixes cursor display when a 'display' text
2837 property immediately follows invisible text. (Bug#11094)
2839 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2841 composite.c: use 'double' consistently
2842 * composite.c (get_composition_id): Use 'double' consistently
2843 instead of converting 'float' to 'double' and vice versa; this is
2844 easier to understand and avoids a GCC warning.
2846 2012-04-09 Glenn Morris <rgm@gnu.org>
2848 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2849 preparation for dumping it with emacs. (Bug#4789)
2850 (leimdir): New variable.
2851 ($(leimdir)/leim-list.el): New rule.
2852 (emacs$(EXEEXT)): Depend on leim-list.el.
2854 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2855 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2856 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2858 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2860 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2863 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2865 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2866 Remove unused local variable.
2868 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2870 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2871 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2872 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2873 objects, as mark_maybe_pointer will catch them otherwise.
2874 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2875 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2877 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2879 Fix typo that broke non-Windows builds.
2880 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2882 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2884 Support building on MS-Windows with libxml2.
2886 * makefile.w32-in (OBJ2): Add xml.$(O).
2887 (GLOBAL_SOURCES): Add xml.c.
2888 ($(BLD)/xml.$(O)): New dependency list.
2890 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2891 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2892 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2893 [!WINDOWSNT]: New macros.
2894 (init_libxml2_functions, libxml2_loaded_p): New functions.
2895 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2896 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2897 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2898 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2900 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2901 Call init_libxml2_functions before calling libxml2 functions.
2902 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2904 * emacs.c: Don't include libxml/parser.h.
2905 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2906 xmlCleanupParser directly.
2908 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2910 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2912 * indent.c (Fvertical_motion): If there is a display string at
2913 point, use it.vpos to compute how many lines to backtrack after
2914 move_it_to point. (Bug#11133)
2916 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2918 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2919 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2920 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2921 macros related to unification of CJK characters. For the details,
2922 see the discussion following the message here:
2923 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2925 2012-04-04 Chong Yidong <cyd@gnu.org>
2927 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2929 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2931 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2932 instead of alloca. (Bug#11138)
2934 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2936 * w32menu.c (is_simple_dialog): Properly check lisp types.
2939 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2941 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2942 position we get to after a call to move_it_to fails the
2943 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2944 only if we wind up in a string from display property. (Bug#11063)
2946 * window.c (Fdelete_other_windows_internal): Invalidate the row
2947 and column information about mouse highlight, so that redisplay
2948 restores it after reallocating the glyph matrices. (Bug#7464)
2950 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2951 string comes from a `display' text property, use the buffer
2952 position of that property as if we actually saw that position in
2954 (move_it_by_lines): Remove the assertion that
2955 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2956 violated when there's a before-string at the beginning of a line.
2959 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2961 * xdisp.c (append_space_for_newline): If the default face was
2962 remapped, use the remapped face for the appended newline.
2963 (extend_face_to_end_of_line): Use the remapped default face for
2964 extending the face to the end of the line.
2965 (display_line): Call extend_face_to_end_of_line when the default
2966 face was remapped. (Bug#11068)
2968 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2970 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2972 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2974 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2976 2012-03-27 Glenn Morris <rgm@gnu.org>
2978 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2981 2012-03-26 Kenichi Handa <handa@m17n.org>
2983 * dispextern.h (struct glyph): Fix previous change. Change the
2984 bit length of glyphless.ch to 25 (Bug#11082).
2986 2012-03-26 Chong Yidong <cyd@gnu.org>
2988 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2989 (command_loop_1): Use it; inhibit selection update for
2990 handle-select-window too (Bug#8996).
2992 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2994 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2996 2012-03-25 Kenichi Handa <handa@m17n.org>
2998 * dispextern.h (struct glyph): Change the bit length of
2999 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3001 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3003 * s/ms-w32.h (tzname): Include time.h before redirecting to
3004 _tzname. Fixes the MSVC build. (Bug#9960)
3006 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3008 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3011 * xterm.c (XTread_socket): Only modify handling_signal if
3012 !SYNC_INPUT. (Bug#11080)
3014 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3016 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3017 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3018 when fetching a multibyte character consumes more bytes than
3019 CHAR_BYTES returns, due to unification of CJK characters in
3020 string_char. (Bug#11073)
3022 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3024 * process.c (wait_reading_process_output): Handle pty disconnect
3025 by refraining from sending oneself a SIGCHLD (bug#10933).
3027 2012-03-22 Chong Yidong <cyd@gnu.org>
3029 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3031 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3032 Mark string as coming from a prefix property.
3033 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3034 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3036 2012-03-21 Chong Yidong <cyd@gnu.org>
3038 * xfaces.c (Vface_remapping_alist): Doc fix.
3040 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3042 * w32proc.c (Fw32_set_console_codepage)
3043 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3046 2012-03-20 Chong Yidong <cyd@gnu.org>
3048 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3049 to reflect default non-nil value of redisplay-dont-pause.
3051 2012-03-19 Kenichi Handa <handa@m17n.org>
3053 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3054 it fit in a valid range (Bug#11003).
3056 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3058 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3059 that is not from display property, accept the row as a "cursor
3060 row" if one of the string's character has a non-nil `cursor'
3061 property. Fixes cursor positioning when there are newlines in
3062 overlay strings, e.g. in icomplete.el. (Bug#11035)
3064 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3066 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3068 2012-03-12 Chong Yidong <cyd@gnu.org>
3070 * eval.c (inhibit_lisp_code): Rename from
3071 inhibit_window_configuration_change_hook; move from window.c.
3073 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3074 * window.c (run_window_configuration_change_hook)
3075 (syms_of_window): Callers changed.
3077 2012-03-11 Chong Yidong <cyd@gnu.org>
3079 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3081 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3083 2012-03-10 Chong Yidong <cyd@gnu.org>
3085 * frame.c (other_visible_frames): Don't assume the selected frame
3086 is visible (Bug#10955).
3088 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3090 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3092 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3094 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3095 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3098 2012-03-03 Glenn Morris <rgm@gnu.org>
3100 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3102 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3104 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3105 position past the first glyph_row that ends at ZV. (Bug#10902)
3106 (redisplay_window, next_element_from_string): Fix typos in
3108 (redisplay_window): Pass to move_it_vertically the margin in
3109 pixels, not in screen lines.
3111 2012-03-02 Glenn Morris <rgm@gnu.org>
3113 * buffer.c (buffer-list-update-hook): Doc fix.
3115 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3117 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3118 push_it before setting up the iterator for the first overlay
3119 string, even if we have an empty string loaded.
3120 (next_overlay_string): If there's an empty string on the iterator
3121 stack, pop the stack. (Bug#10903)
3123 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3125 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3126 Suggested by Stefan Monnier in
3127 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3128 * alloc.c (widen_to_Lisp_Object): New static function.
3129 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3130 and widening them to Lisp_Objects. This would work even if
3131 USE_LSB_TAG is defined and wide integers are used, which might
3132 happen in a future version of Emacs.
3134 2012-02-25 Chong Yidong <cyd@gnu.org>
3136 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3139 * xselect.c (Fx_selection_exists_p): Doc fix.
3140 (x_clipboard_manager_save_all): Print an informative message
3141 before saving to clipboard manager.
3143 2012-02-24 Chong Yidong <cyd@gnu.org>
3145 * keyboard.c (process_special_events): Handle all X selection
3146 requests in kbd_buffer, not just the next one (Bug#8869).
3148 2012-02-23 Chong Yidong <cyd@gnu.org>
3150 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3151 call when setting menu-bar-lines and tool-bar-lines parameters.
3152 (unwind_create_frame_1): New helper function.
3154 * window.c (inhibit_window_configuration_change_hook): New var.
3155 (run_window_configuration_change_hook): Obey it.
3156 (syms_of_window): Initialize it.
3158 2012-02-22 Chong Yidong <cyd@gnu.org>
3160 * xterm.c (x_draw_image_relief): Add missing type check for
3161 Vtool_bar_button_margin (Bug#10743).
3163 2012-02-21 Chong Yidong <cyd@gnu.org>
3165 * fileio.c (Vfile_name_handler_alist): Doc fix.
3167 * buffer.c (Fget_file_buffer): Protect against invalid file
3168 handler return value.
3170 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3172 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3173 when computing $valmask.
3175 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3176 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3177 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3178 It's useless in that case, and it can cause problems on hosts
3179 that allocate halves of EMACS_INT values separately.
3180 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3181 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3182 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3183 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3184 it avoids undefined behavior on hosts where shifting right by more
3185 than the word width has undefined behavior.
3187 2012-02-19 Chong Yidong <cyd@gnu.org>
3189 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3190 (Funhandled_file_name_directory, Ffile_name_as_directory)
3191 (Fdirectory_file_name, Fexpand_file_name)
3192 (Fsubstitute_in_file_name): Protect against invalid file handler
3193 return values (Bug#10845).
3195 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3197 * .gdbinit (pitx): Fix incorrect references to fields of the
3200 2012-02-17 Chong Yidong <cyd@gnu.org>
3202 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3204 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3206 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3207 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3209 2012-02-15 Chong Yidong <cyd@gnu.org>
3211 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3212 marked as special. Also, starting docstrings with * is obsolete.
3214 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3216 * gnutls.c (emacs_gnutls_write): Fix last change.
3218 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3220 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3223 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3225 * keymap.c (Fsingle_key_description): Handle char ranges.
3227 2012-02-12 Chong Yidong <cyd@gnu.org>
3229 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3230 as that creates a dangerous corner case.
3232 * window.c (Fdelete_window_internal): Invalidate the mouse
3233 highlight (Bug#9904).
3235 2012-02-12 Glenn Morris <rgm@gnu.org>
3237 * xselect.c (Fx_own_selection_internal)
3238 (Fx_get_selection_internal, Fx_disown_selection_internal)
3239 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3240 * nsselect.m (Fx_own_selection_internal)
3241 (Fx_disown_selection_internal, Fx_selection_exists_p)
3242 (Fx_selection_owner_p, Fx_get_selection_internal):
3243 Sync docs and argument specs with the xselect.c versions.
3245 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3247 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3249 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3251 * w32select.c (Fx_selection_exists_p): Sync doc string and
3252 argument list with xselect.c. (Bug#10783)
3254 * w16select.c (Fx_selection_exists_p): Sync doc string and
3255 argument list with xselect.c. (Bug#10783)
3257 2012-02-10 Glenn Morris <rgm@gnu.org>
3259 * fns.c (Fsecure_hash): Doc fix.
3261 2012-02-09 Kenichi Handa <handa@m17n.org>
3263 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3265 2012-02-07 Chong Yidong <cyd@gnu.org>
3267 * buffer.c (Fbuffer_local_variables)
3268 (buffer_lisp_local_variables): Handle unbound vars correctly;
3269 don't let Qunbound leak into Lisp.
3271 2012-02-07 Glenn Morris <rgm@gnu.org>
3273 * image.c (Fimagemagick_types): Doc fix.
3275 * image.c (imagemagick-render-type): Change it from a lisp object
3276 to an integer. Move the doc here from the lisp manual.
3277 Treat all values not equal to 0 the same.
3279 2012-02-06 Chong Yidong <cyd@gnu.org>
3281 * doc.c (store_function_docstring): Avoid applying docstring of
3282 alias to base function (Bug#2603).
3284 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3286 * .gdbinit (pp1, pv1): Remove redundant defines.
3289 2012-02-04 Chong Yidong <cyd@gnu.org>
3291 * nsterm.m: Declare a global (Bug#10694).
3293 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3295 * w32.c (get_emacs_configuration_options):
3296 Include --enable-checking, if specified, in the return value.
3298 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3300 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3301 after rounding frame sizes. (Bug#9723)
3303 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3305 * keyboard.c (adjust_point_for_property): Don't position point
3306 before BEGV. (Bug#10696)
3308 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3310 Handle overflow when computing char display width (Bug#9496).
3311 * character.c (char_width): Return EMACS_INT, not int.
3312 (char_width, c_string_width): Check for overflow when
3313 computing the width; this is possible now that individual
3314 characters can have unbounded width. Problem introduced
3315 by merge from Emacs 23 on 2012-01-19.
3317 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3319 * dbusbind.c (Fdbus_register_method): Mention the return value
3320 :ignore in the docstring.
3322 2012-02-02 Glenn Morris <rgm@gnu.org>
3324 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3326 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3327 Unconditionally set to t. (Bug#10673)
3328 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3329 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3330 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3332 2012-02-02 Kenichi Handa <handa@m17n.org>
3334 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3335 0, do not call append_composite_glyph.
3337 2012-02-02 Kenichi Handa <handa@m17n.org>
3339 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3341 (x_produce_glyphs): If the component of a composition is a null
3342 string, set it->pixel_width to 1 to avoid zero-width glyph.
3344 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3346 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3347 first 2 arguments are identical. This makes inserting large
3348 output from a subprocess an order of magnitude faster on
3349 MS-Windows, where all sbrk'ed memory is always contiguous.
3351 2012-01-31 Glenn Morris <rgm@gnu.org>
3353 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3354 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3355 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3357 2012-01-29 Glenn Morris <rgm@gnu.org>
3359 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3361 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3363 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3365 2012-01-28 Chong Yidong <cyd@gnu.org>
3367 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3369 2012-01-26 Chong Yidong <cyd@gnu.org>
3371 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3373 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3374 repeat counts (Bug#10507).
3376 2012-01-26 Glenn Morris <rgm@gnu.org>
3378 * lread.c (syms_of_lread): Doc fix.
3380 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3382 * coding.c (encode_designation_at_bol): Change return value to
3385 2012-01-25 Chong Yidong <cyd@gnu.org>
3387 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3389 2012-01-21 Chong Yidong <cyd@gnu.org>
3391 * floatfns.c (Fcopysign): Make the second argument non-optional,
3392 since nil is not allowed anyway.
3394 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3396 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3397 (send_process): Likewise.
3399 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3401 * window.c (save_window_save, Fcurrent_window_configuration)
3402 (Vwindow_persistent_parameters): Do not use Qstate.
3403 Rewrite doc-strings.
3405 2012-01-19 Kenichi Handa <handa@m17n.org>
3407 * character.c (char_width): New function.
3408 (Fchar_width, c_string_width, lisp_string_width):
3409 Use char_width (Bug#9496).
3411 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3413 * window.c (Vwindow_persistent_parameters): New variable.
3414 (Fset_window_configuration, save_window_save): Handle persistent
3417 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3419 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3420 thrashing the stack of the thread. (Bug#9087)
3422 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3424 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3426 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3428 * xdisp.c (rows_from_pos_range): Handle the case where the
3429 highlight ends on a newline. (Bug#10464)
3430 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3431 he end column for display of highlight that ends on a newline
3434 2012-01-11 Glenn Morris <rgm@gnu.org>
3436 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3437 from load-path also when installation-directory is nil. (Bug#10208)
3439 2012-01-10 Glenn Morris <rgm@gnu.org>
3441 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3443 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3444 Update template values to be closer to their typical values these days.
3446 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3448 * xdisp.c (rows_from_pos_range): Accept additional argument
3449 DISP_STRING, and accept any glyph in a row whose object is that
3450 string as eligible for mouse highlight. Fixes mouse highlight of
3451 display strings from overlays. (Bug#10464)
3453 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3455 emacs: fix an auto-save permissions race condition (Bug#10400)
3456 * fileio.c (auto_saving_dir_umask): New static var.
3457 (Fmake_directory_internal): Use it.
3458 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3459 creating the directory. The old code temporarily assigns
3460 too-generous permissions to the directory.
3461 (do_auto_save_eh): Clear it.
3462 (Fdo_auto_save): Catch all errors, not just file errors, so
3463 that the var is always cleared.
3465 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3467 * search.c (scan_buffer): Pass character positions to
3468 know_region_cache, not byte positions. (Bug#6540)
3470 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3472 * w32.c (sys_rename): Report EXDEV when rename of a directory
3473 fails because the target is on another logical disk. (Bug#10284)
3475 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3477 * xterm.c (x_embed_request_focus): New function.
3479 * xterm.h: Add prototype.
3481 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3483 2012-01-05 Glenn Morris <rgm@gnu.org>
3485 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3487 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3489 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3490 Load gnutls_transport_set_lowat only if GnuTLS version is below
3492 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3493 GnuTLS versions below 2.11.1.
3495 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3497 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3498 to the doc string advising against its use for altering the way
3499 windows are scrolled.
3501 2011-12-28 Kenichi Handa <handa@m17n.org>
3503 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3504 coding-system ASCII compatible only when it does not produce BOM
3505 on encoding (Bug#10383).
3507 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3509 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3511 (create_and_show_popup_menu): Always use menu_position_func for
3514 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3516 * callint.c (Fcall_interactively): Don't truncate prompt string.
3518 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3520 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3521 property that ends at ZV, so that the bidi iteration could be
3522 resumed from there (after widening). (Bug#10360)
3524 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3526 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3528 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3530 * nsterm.m (x_free_frame_resources):
3531 Release f->output_data.ns->miniimage.
3532 (ns_index_color): Fix indentation. Do not retain
3533 color_table->colors[i].
3535 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3538 * nsfns.m (x_set_background_color): Assign return value from
3539 ns_index_color to face-background instead of NSColor*.
3540 (ns_implicitly_set_icon_type): Fix indentation.
3541 Change assignment in for loop to comparison.
3543 * emacs.c (ns_pool): New variable.
3544 (main): Assign ns_pool.
3545 (Fkill_emacs): Call ns_release_autorelease_pool.
3547 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3548 autorelease fdesc, release fdAttrs and tdict.
3549 (ns_get_covering_families): Release charset.
3550 (ns_findfonts): Release NSFontDescriptor created with new.
3551 (ns_uni_to_glyphs): Fix indentation.
3552 (setString): Release attrStr before assigning new value.
3554 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3556 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3558 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3559 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3561 2011-12-18 David Reitter <reitter@cmu.edu>
3563 * nsterm.m (ns_term_init): Subscribe for notifications
3564 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3565 to method trackingNotification in EmacsMenu.
3567 * nsmenu.m (trackingMenu): New variable.
3568 (trackingNotification): New method (from Aquamacs).
3569 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3570 from Aquamacs (Bug#7030).
3572 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3574 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3575 (symbol_to_nsstring): Fix indentation.
3576 (ns_symbol_to_pb): New function.
3577 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3578 (Fns_rotate_cut_buffers_internal): Remove.
3579 (Fns_store_selection_internal): Rename from
3580 Fns_store_cut_buffer_internal.
3581 (ns_get_foreign_selection, Fx_own_selection_internal)
3582 (Fx_disown_selection_internal, Fx_selection_exists_p)
3583 (Fns_get_selection_internal, Fns_store_selection_internal):
3584 Use ns_symbol_to_pb and check if return value is nil.
3585 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3586 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3587 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3588 renamed to Sns_store_selection_internal.
3589 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3590 and remove this function.
3591 (ns_handle_selection_clear): Remove, never used.
3592 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3595 2011-12-17 Ken Brown <kbrown@cornell.edu>
3597 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3598 GID is unknown (Bug#10257).
3600 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3602 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3603 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3604 which caused a build failure on GNU/Linux IA-64. This problem was
3605 introduced by my 2011-10-07 patch.
3607 2011-12-15 Juri Linkov <juri@jurta.org>
3609 * image.c (imagemagick_error): New function. (Bug#10112)
3610 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3611 Use `imagemagick_error' where ImageMagick functions return
3613 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3616 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3618 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3619 fill background (Bug#8992).
3621 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3623 * window.c (Vwindow_combination_resize)
3624 (Vwindow_combination_limit): Use t instead of non-nil in
3626 (Vrecenter_redisplay): Add first sentence of doc-string on
3628 (Frecenter): Fix doc-string typo.
3630 2011-12-11 Kenichi Handa <handa@m17n.org>
3632 * coding.c (Funencodable_char_position): Pay attention to the
3633 buffer text relocation (Bug#9389).
3635 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3637 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3638 gtk_init (Bug#10100).
3640 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3642 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3643 IT->string is nil. (Bug#10263)
3645 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3647 * nsterm.h (x_free_frame_resources): Declare.
3649 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3650 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3652 * nsterm.h (ns_get_defaults_value): Declare.
3654 * nsterm.m (ns_default): Call ns_get_defaults_value.
3656 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3658 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3661 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3663 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3664 that where the value of an _OBJC_* symbol points to is in the .bss
3665 section (Bug#10240).
3667 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3669 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3670 after the loop to call ccl_driver at least once (Bug#8619).
3672 2011-12-08 Kenichi Handa <handa@m17n.org>
3674 * ftfont.c (get_adstyle_property): Fix previous change
3677 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3679 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3680 dirs from the default value of EMACSLOADPATH (bug#10208).
3682 2011-12-07 Glenn Morris <rgm@gnu.org>
3684 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3685 installation and source directories as well. (Bug#10208)
3687 2011-12-06 Chong Yidong <cyd@gnu.org>
3689 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3691 2011-12-06 Glenn Morris <rgm@gnu.org>
3693 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3694 as an error, not just -1. (Bug#10217)
3696 2011-12-05 Chong Yidong <cyd@gnu.org>
3698 * keyboard.c (process_special_events): New function.
3699 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3701 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3703 * coding.c (encode_designation_at_bol): Don't use uninitialized
3704 local variable (Bug#9318).
3706 2011-12-05 Kenichi Handa <handa@m17n.org>
3708 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3709 return Qnil (Bug#8046, Bug#10193).
3711 2011-12-05 Kenichi Handa <handa@m17n.org>
3713 * coding.c (encode_designation_at_bol): New args charbuf_end and
3714 dst. Return the number of produced bytes. Callers changed.
3715 (coding_set_source): Return how many bytes coding->source was
3717 (coding_set_destination): Return how many bytes
3718 coding->destination was relocated.
3719 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3720 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3722 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3724 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3725 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3728 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3730 The following changes are to fix Bug#9318.
3732 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3733 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3734 (encode_coding_iso_2022, encode_coding_sjis)
3735 (encode_coding_big5, encode_coding_charset): Use the above macros.
3737 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3739 * lisp.h (process_quit_flag): Fix external declaration.
3741 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3743 Don't macro-inline non-performance-critical code.
3744 * eval.c (process_quit_flag): New function.
3745 * lisp.h (QUIT): Use it.
3747 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3749 * nsfns.m (get_geometry_from_preferences): New function.
3750 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3752 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3754 * emacs.c (Qkill_emacs): Define.
3755 (syms_of_emacs): Initialize it.
3756 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3757 Qquit_flag to `kill-emacs' instead.
3758 (quit_throw_to_read_char): Add parameter `from_signal'.
3759 All callers changed. Call Fkill_emacs if requested and safe.
3760 * lisp.h (QUIT): Call Fkill_emacs if requested.
3762 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3764 * widget.c (update_wm_hints): Return if wmshell is null.
3765 (widget_update_wm_size_hints): New function.
3767 * widget.h (widget_update_wm_size_hints): Declare.
3769 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3770 widget_update_wm_size_hints (Bug#10104).
3772 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3774 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3775 before a newline, prepare the bidi iterator for consuming the
3776 newline, and keep the current paragraph direction. (Bug#10183)
3777 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3779 2011-12-02 Juri Linkov <juri@jurta.org>
3781 * search.c (Fword_search_regexp): New Lisp function created from
3782 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3783 (Fword_search_backward, Fword_search_forward)
3784 (Fword_search_backward_lax, Fword_search_forward_lax):
3785 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3786 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3788 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3790 * fileio.c (Finsert_file_contents): Move after-change-function call
3791 to before the "handled:" label, since all "goto handled" appear in
3792 cases where the *-change-functions have already been properly called
3795 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3797 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3798 waiting for input. (Bug#10169)
3800 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3802 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3803 verifies glyph row's hash code--we have just reallocated the
3804 glyphs, so their contents can be complete garbage. (Bug#10164)
3806 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3808 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3810 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3812 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3813 attributes are tested _before_ calling verify_row_hash, to protect
3814 against GCC re-ordering of the tests. (Bug#10164)
3816 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3818 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3820 * xterm.c (handle_one_xevent): Only set async_visible and friends
3821 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3822 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3823 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3825 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3827 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3828 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3829 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3830 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3831 All uses changed to use GCPRO1 etc.
3832 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3833 Revert to old implementation (i.e., before 2011-03-11).
3835 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3837 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3838 of scroll runs so as to avoid assigning disabled bogus rows and
3839 unnecessary graphics copy operations.
3841 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3843 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3844 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3845 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3846 (malloc, free, realloc, calloc): Redirect to e_* only when
3849 * lisp.h (GCTYPEBITS): Move before first use.
3850 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3851 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3852 this macro definition.
3854 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3857 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3859 * gtkutil.c (xg_create_frame_widgets):
3860 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3861 present with Gtk+ 2.0.
3863 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3865 * fileio.c (Finsert_file_contents): Undo previous change; see
3866 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3868 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3870 Rename locals to avoid shadowing.
3871 * fileio.c (Finsert_file_contents):
3872 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3873 * process.c (wait_reading_process_output):
3874 Rename inner 'proc' to 'p' to avoid shadowing.
3875 Indent for consistency with usual Emacs style.
3877 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3879 * xdisp.c (redisplay_window): If cursor row is not fully visible
3880 after recentering, and scroll-conservatively is set to a large
3881 number, scroll window by a few more lines to make the cursor fully
3882 visible and out of scroll-margin. (Bug#10105)
3883 (start_display): Don't move to the next line if the display should
3884 start at a newline that is part of a display vector or an overlay
3887 2011-11-24 Juri Linkov <juri@jurta.org>
3889 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3890 after the `MagickPingImage' call. (Bug#10112)
3892 2011-11-23 Chong Yidong <cyd@gnu.org>
3894 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3896 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3898 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3899 making another buffer current. (Bug#10114)
3901 2011-11-23 Glenn Morris <rgm@gnu.org>
3903 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3905 2011-11-23 Chong Yidong <cyd@gnu.org>
3907 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3908 using it (Bug#5984).
3910 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3912 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3913 and header-lines, as they don't have one computed for them.
3916 * .gdbinit (prow): Make displayed values more self-explaining.
3917 Add row's hash code.
3919 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3921 * process.c (wait_reading_process_output): Fix asynchrounous
3922 GnuTLS socket handling on some versions of the GnuTLS library.
3923 (wait_reading_process_output): Add comment and URL.
3925 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3927 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3929 2011-11-21 Chong Yidong <cyd@gnu.org>
3931 * window.c (Fnext_window, Fprevious_window): Doc fix.
3933 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3935 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3937 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3939 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3941 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3943 * window.c (Fset_window_combination_limit): Rename argument
3945 (Vwindow_combination_limit): Remove "status" from doc-string.
3947 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3949 * m/ibms390.h: Remove.
3950 * m/ibms390x.h: Don't include "ibms390.h".
3952 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3954 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3955 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3957 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3959 * casetab.c (Fset_case_table):
3960 * charset.c (Fcharset_after): Fix typos.
3962 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3964 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3965 Otherwise, valgrind does not work on some platforms.
3966 Problem reported by Andreas Schwab in
3967 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3968 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3969 is set, removing the need for VIRT_ADDRESS_VARIES.
3970 (PURE_P): Use a more-efficient implementation that needs just one
3971 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3972 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3973 to 4 (xorl, subq, cmpq, setbe).
3974 * alloc.c (pure): Always extern now, since that's the
3975 VIRT_ADDR_VARIES behavior.
3976 (PURE_POINTER_P): Use a single comparison, not two, for
3977 consistency with the new puresize.h.
3978 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3979 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3980 Remove VIRT_ADDR_VARIES no longer needed.
3982 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3984 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3985 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3986 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3987 behave as if the cursor position were at the window margin.
3989 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3990 and the cursor position is out of bounds, behave as if the cursor
3991 position were at the window margin. (Bug#10075)
3993 2011-11-18 Chong Yidong <cyd@gnu.org>
3995 * window.c (Fwindow_combination_limit): Make first argument
3996 non-optional, since it is meaningless for live windows like the
3999 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4001 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4003 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4005 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4006 (graft_intervals_into_buffer): Simplify.
4008 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4010 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4011 hash values of the two rows.
4012 (copy_row_except_pointers): Preserve the used[] arrays and the
4013 hash values of the two rows. (Bug#10035)
4014 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4016 * xdisp.c (row_hash): New function, body extracted from
4017 compute_line_metrics.
4018 (compute_line_metrics): Call row_hash, instead of computing the
4021 * dispnew.c (verify_row_hash): Call row_hash for computing the
4022 hash code of a row, instead of duplicating code from xdisp.c.
4024 * dispextern.h (row_hash): Add prototype.
4026 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4028 * frame.c (delete_frame): Don't delete the terminal when the last
4029 X frame is closed if emacs is built with GTK toolkit.
4031 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4033 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4035 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4037 * window.c (Vwindow_splits): Rename to
4038 Vwindow_combination_resize. Suggested by Juri Linkov.
4039 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4042 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4044 * nsfns.m (Fns_font_name):
4045 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4047 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4049 * window.h (window): Rename slot "nest" to "combination_limit".
4050 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4051 (Fset_window_nest): Rename to Fset_window_combination_limit.
4052 (Vwindow_nest): Rename to Vwindow_combination_limit.
4053 (recombine_windows, make_parent_window, make_window)
4054 (Fsplit_window_internal, saved_window)
4055 (Fset_window_configuration, save_window_save): Rename all
4056 occurrences of window_nest to window_combination_limit.
4058 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4060 * image.c (imagemagick_load_image): Fix typo.
4062 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4064 * xdisp.c (display_line): Move the call to
4065 highlight_trailing_whitespace before the call to
4066 compute_line_metrics, since the latter needs to see the final
4067 faces of all the glyphs to compute ROW's hash value.
4068 Fixes assertion violations in row_equal_p. (Bug#10035)
4070 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4072 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4073 just return (bug#10044).
4075 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4077 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4078 with user-defined heap size. Bump the default size of the temacs
4079 heap to 27MB, to avoid memory warning when running temacs.
4080 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4082 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4083 current_matrix and desired_matrix. (Bug#9990)
4084 (verify_row_hash) [XASSERTS]: New function.
4085 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4086 that the hash value of glyph rows is correct.
4088 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4090 * window.h (window): Remove splits slot.
4091 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4092 (Fdelete_other_windows_internal, make_parent_window)
4093 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4094 (Fset_window_configuration, save_window_save): Don't deal with
4095 split status of windows.
4096 (saved_window): Remove splits slot.
4097 (Vwindow_splits): Rewrite doc-string.
4099 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4101 * xfns.c (unwind_create_frame):
4102 * nsfns.m (unwind_create_frame):
4103 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4104 Vframe_list (Bug#9999).
4106 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4108 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4110 2011-11-11 Kenichi Handa <handa@m17n.org>
4112 * callproc.c (Fcall_process): Set the member dst_multibyte of
4115 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4117 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4118 avoid a crash (bug#9496).
4120 2011-11-09 Chong Yidong <cyd@gnu.org>
4122 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4123 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4125 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4127 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4129 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4131 Avoid some portability problems by eschewing 'extern inline' functions.
4132 The trivial performance wins aren't worth the portability hassles; see
4133 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4135 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4136 (window_box_width, window_box_left, window_box_left_offset)
4137 (window_box_right, window_box_right_offset): Undo previous change,
4138 by removing the "extern"s.
4139 * intervals.c (adjust_intervals_for_insertion)
4140 (adjust_intervals_for_deletion): Undo previous change,
4141 making these static again.
4142 (offset_intervals, temp_set_point_both, temp_set_point)
4143 (copy_intervals_to_string): No longer inline.
4144 * xdisp.c (window_text_bottom_y, window_box_width)
4145 (window_box_height, window_box_left_offset)
4146 (window_box_right_offset, window_box_left, window_box_right)
4147 (window_box): No longer inline.
4149 2011-11-08 Chong Yidong <cyd@gnu.org>
4151 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4152 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4153 Signal an error if not a live window.
4154 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4155 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4157 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4159 * lisp.h (syms_of_abbrev): Remove declaration.
4160 Reported by CHENG Gao <chenggao@royau.me>.
4162 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4164 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4165 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4166 of temacs in GUI mode.
4168 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4170 * window.h: Declare delete_all_child_windows instead of
4171 delete_all_subwindows.
4172 * window.c (Fwindow_nest, Fset_window_nest)
4173 (Fset_window_new_total, Fset_window_new_normal)
4174 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4175 (delete_all_subwindows): Rename to delete_all_child_windows.
4176 (Fdelete_other_windows_internal, Fset_window_configuration):
4177 Call delete_all_child_windows instead of delete_all_subwindows.
4178 * frame.c (delete_frame): Call delete_all_child_windows instead
4179 of delete_all_subwindows.
4181 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4183 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4184 This is also needed for porting to any host where GC_MARK_STACK is
4185 not GC_MAKE_GCPROS_NOOPS.
4186 (which_symbols): Use it.
4188 2011-11-07 Kenichi Handa <handa@m17n.org>
4190 * coding.c (coding_set_destination): Check coding->src_pos only
4191 when coding->src_object is a buffer (bug#9910).
4193 * process.c (send_process): Set the member src_multibyte of coding
4194 to 0 (bug#9911) when sending a unibyte text.
4196 * callproc.c (Fcall_process): Set the member src_multibyte of
4197 process_coding to 0 (bug#9912).
4199 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4201 * xmenu.c (cleanup_widget_value_tree): New function.
4202 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4203 calling free_menubar_widget_value_tree directly (Bug#9830).
4205 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4207 Fix some portability problems with 'inline'.
4208 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4209 (window_box_width, window_box_left, window_box_left_offset)
4210 (window_box_right, window_box_right_offset): Declare extern.
4211 Otherwise, these inline functions do not conform to C99 and
4212 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4213 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4214 * intervals.c (adjust_intervals_for_insertion)
4215 (adjust_intervals_for_deletion): Now extern, because otherwise the
4216 extern inline functions 'offset_intervals' couldn't refer to it.
4217 (static_offset_intervals): Remove.
4218 (offset_intervals): Rewrite using the old contents of
4219 static_offset_intervals. The old version didn't conform to C99
4220 because an extern inline function contained a reference to an
4221 identifier with static linkage.
4223 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4225 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4228 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4230 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4231 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4232 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4233 return Qleft_to_right.
4235 2011-11-06 Chong Yidong <cyd@gnu.org>
4237 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4238 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4239 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4240 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4241 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4242 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4243 (Fwindow_vscroll): Doc fix.
4244 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4245 argument, since it makes no sense to pass a live window and for
4246 consistency with window-child.
4248 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4250 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4253 2011-11-05 Jason Rumney <jasonr@gnu.org>
4255 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4256 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4258 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4259 bitwise arithmetic preventing use of unicode-sip and non-truetype
4262 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4264 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4267 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4268 initialization code to keep similarity to xfns.c after changes
4271 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4273 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4274 (unwind_create_frame): New function (Bug#9943).
4275 (Fx_create_frame): Restructure code to be more similar to the one in
4276 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4277 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4278 Move terminal->reference_count++ just before making the frame official
4281 * nsterm.m (x_free_frame_resources): New function.
4282 (x_destroy_window): Move code to x_free_frame_resources.
4284 * xfns.c (unwind_create_frame): Fix comment.
4285 (Fx_create_frame, x_create_tip_frame):
4286 Move terminal->reference_count++ just before making the frame
4287 official. Move initialization of image_cache_refcount and
4288 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4290 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4292 Support MSVC build with newer versions of Visual Studio.
4293 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4294 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4297 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4298 which are not supported by MSVC.
4299 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4300 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4302 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4304 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4306 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4308 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4310 Support MSVC build with newer versions of Visual Studio.
4311 * w32.c: Don't include w32api.h for MSVC.
4312 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4314 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4315 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4316 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4317 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4319 (alloca) [_MSC_VER]: Define to _alloca.
4321 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4323 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4325 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4327 * xdisp.c (note_mouse_highlight): If either of
4328 previous/next-single-property-change returns nil, treat that as
4329 the beginning or the end of the buffer. (Bug#9955)
4331 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4333 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4334 label is not null (Bug#9951).
4335 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4338 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4340 * window.c (Fwindow_body_size): Mention in the doc string that the
4341 return value is in frame's canonical units. (Bug#9949)
4343 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4345 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4347 * w32fns.c (unwind_create_frame): If needed, free the glyph
4348 matrices of the partially constructed frame. (Bug#9943)
4349 * xfns.c (unwind_create_frame): Likewise.
4351 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4353 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4354 Don't stop backward scan on the continuation glyph, even though
4355 its CHARPOS is positive.
4356 (mouse_face_from_buffer_pos, note_mouse_highlight):
4357 Rename cover_string to disp_string.
4359 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4361 * window.c (temp_output_buffer_show): Don't use
4362 Vtemp_buffer_show_specifiers.
4363 (Vtemp_buffer_show_specifiers): Remove unused variable.
4365 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4367 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4368 past the beginning of the current glyph matrix.
4370 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4372 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4373 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4374 HAVE_GTK3 (Bug#9869).
4376 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4377 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4379 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4381 * xterm.c: Declare x_handle_net_wm_state to return int.
4382 (handle_one_xevent): Check if we are iconified but don't have
4383 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4384 (get_current_wm_state): Return non-zero if not hidden,
4385 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4386 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4387 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4388 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4390 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4392 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4393 so that this new function doesn't get optimized away by a
4394 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4396 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4398 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4400 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4402 Fix the `xbytecode' command.
4403 * .gdbinit (xprintbytestr): New command.
4404 (xwhichsymbols): Rename from `which'; all callers changed.
4405 (xbytecode): Print the byte-code string as well.
4407 2011-10-29 Kim Storm <storm@cua.dk>
4409 * alloc.c (which_symbols): New function.
4411 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4413 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4416 2011-10-29 Glenn Morris <rgm@gnu.org>
4418 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4419 Not clear what it was for, and it causes various bugs. (Bug#9839)
4421 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4423 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4424 possible random value that matches one of those tested as
4425 condition to clear the mouse face.
4427 2011-10-28 Chong Yidong <cyd@gnu.org>
4429 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4431 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4433 * window.c (make_window): Initialize phys_cursor_on_p.
4435 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4437 * lisp.h (struct Lisp_Symbol): Update comments.
4439 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4441 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4443 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4445 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4446 <oslsachem@gmail.com> for helping to debug this.
4448 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4449 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4450 (g_b_init_get_glyph_outline_w): New static variables.
4451 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4452 (GetGlyphOutlineW_Proc): New typedefs.
4453 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4454 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4456 (w32font_open_internal, compute_metrics):
4457 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4458 instead of calling the "wide" APIs directly.
4460 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4462 * w32.h (syms_of_w32font): Add prototype.
4464 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4466 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4467 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4468 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4469 (Fmove_to_window_line): Doc fix.
4471 2011-10-27 Chong Yidong <cyd@gnu.org>
4473 * process.c (make_process): Set gnutls_state to NULL.
4475 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4476 non-NULL, regardless of GNUTLS_INITSTAGE.
4477 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4478 an error. Set process slots as soon as we allocate them.
4480 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4482 2011-10-27 Chong Yidong <cyd@gnu.org>
4484 * gnutls.c (emacs_gnutls_deinit): New function.
4485 Deallocate credentials structures as well as calling gnutls_deinit.
4486 (Fgnutls_deinit, Fgnutls_boot): Use it.
4488 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4489 (deactivate_process): Call emacs_gnutls_deinit.
4491 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4493 * image.c (x_create_x_image_and_pixmap):
4494 * w32.c (sys_rename, w32_delayed_load):
4495 * w32font.c (fill_in_logfont):
4496 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4498 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4500 * w32fns.c (w32_default_color_map): New function,
4501 extracted from Fw32_default_color_map.
4502 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4504 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4506 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4508 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4510 * keyboard.c (test_undefined): New function (bug#9751).
4511 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4513 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4515 * sysdep.c (init_sys_modes): Fix the check for the controlling
4516 terminal (Bug#6649).
4518 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4520 * dispextern.h (struct bidi_it): New member next_en_type.
4522 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4523 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4524 current character, check also for next_en_type being WEAK_EN.
4525 (bidi_resolve_weak): Don't enter the expensive loop if the current
4526 position is before next_en_pos. Record the bidi type of the first
4527 non-ET, non-BN character we find, in addition to its position.
4528 (bidi_level_of_next_char): Invalidate next_en_type when
4529 next_en_pos is over-stepped.
4531 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4533 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4534 * editfns.c: Rewrite current-time-zone so that it invokes
4535 the equivalent of (format-time-string "%Z") to get the time zone name.
4536 This fixes a bug when the time zone name contains characters that
4537 need converting from the system time locale to Emacs internal format.
4538 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4539 that patch fixed format-time-string to do the conversion, but
4540 I forgot to fix current-time-zone.
4541 (format_time_string): New function, containing most of
4542 what Fformat_time_string used to contain.
4543 (Fformat_time_string): Rewrite in terms of format_time_string.
4544 This doesn't change this function's behavior.
4545 (current-time-zone): Rewrite to use format_time_string.
4546 This fixes the bug reported by Michael Schierl in
4547 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4548 Jason Rumney's 2007-06-07 change worked around this bug, but
4550 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4552 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4554 * xdisp.c (start_display): If the character at POS is displayed
4555 via a display vector, reset IT->current.dpvec_index to zero.
4556 (try_window_reusing_current_matrix): If a line ends in a display
4557 vector or the next line starts in a display vector, continue
4558 redrawing the window even though the character position of
4559 start_row was reached.
4562 2011-10-18 Chong Yidong <cyd@gnu.org>
4564 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4565 with nobreak-char-display too.
4567 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4569 Fix part 3 of bug#9771.
4570 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4571 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4572 non-neutral characters if the current character is a paragraph
4573 separator (a.k.a. Newline). This avoids running the same
4574 expensive loop twice, once when we consume the preceding newline
4575 and the other time when the line actually needs to be displayed.
4576 Avoid the loop when we see neutrals on the base embedding level
4577 following a character whose directionality is the same as the
4578 paragraph's. This avoids running the expensive loop when a line
4579 ends in a long sequence of neutrals, like control characters.
4580 Add assertion against STRONG_AL type. Slightly rearrange code
4581 that determines the type of a neutral given the first non-neutral
4583 (bidi_level_of_next_char): Set next_en_pos to zero when
4584 invalidating its info.
4586 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4588 * xdisp.c (push_display_prop): Determine whether to record string
4589 or buffer position by IT->string, not by IT->method. Allow
4590 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4591 (move_it_vertically_backward): Don't look for character position
4592 immediately after the newline when in a continuation line.
4595 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4597 * window.c (coordinates_in_window): Rewrite and delabelize
4598 vertical border check. (Bug#5357) (Bug#9618)
4600 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4602 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4603 errors in XSetWindowBorder (bug#9310).
4605 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4607 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4608 avoid crash when xmalloc overrun checking is enabled.
4610 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4612 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4613 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4614 cursor motion with <left> and <right> arrow keys.
4616 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4617 some callers set that themselves.
4619 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4621 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4622 display string and the previous row comes from the same string and
4623 is empty. (Bug#9739) (Bug#9738)
4625 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4627 * doc.c (get_doc_string): Encode file name (bug#9735).
4629 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4631 * bidi.c (bidi_level_of_next_char):
4632 * xdisp.c (get_visually_first_element): Remove old incorrect
4633 comments regarding the Unicode Line Separator character.
4635 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4637 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4639 * alloc.c (Fgc_status): Do not access beyond zombies array
4640 boundary if nzombies > MAX_ZOMBIES.
4641 * alloc.c (dump_zombies): Add missing format specifier.
4643 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4645 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4646 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4648 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4649 Some packages use them to denote characters with modifiers.
4651 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4653 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4654 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4655 matching a pp-number. Rename parameter var to var1.
4657 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4659 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4661 2011-10-08 Glenn Morris <rgm@gnu.org>
4663 * callint.c (Fcall_interactively): Give a more explicit error for the
4664 'c' case with a non-character input. (Bug#8479)
4666 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4668 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4670 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4671 lines that are hscrolled on the left.
4673 * dispnew.c (buffer_posn_from_coords): Account for a possible
4674 presence of header-line. (Bug#4426)
4676 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4678 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4679 Don't advertise functionality which we discourage or doesn't work.
4681 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4683 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4684 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4685 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4686 this makes Emacs dump core during garbage collection on rare
4687 occasions. sizeof is obviously inferior to offsetof here, so
4688 stick with offsetof.
4689 (GC_POINTER_ALIGNMENT): New macro.
4690 (mark_memory): Omit 3rd (offset) arg; caller changed.
4691 Don't assume EMACS_INT alignment is the same as pointer alignment.
4693 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4695 * keyboard.c (read_key_sequence_remapped): New var.
4696 (read_key_sequence): Compute remapping in the right buffer.
4697 (command_loop_1): Use read_key_sequence's remapping directly.
4699 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4701 * dired.c (file_name_completion): Don't expand file name.
4702 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4703 before checking file name handler.
4705 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4706 they've been requested explicitly (bug#9591).
4708 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4710 * keymap.c (Fsingle_key_description): Use make_specified_string
4711 instead of build_string to build string from push_key_description.
4714 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4716 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4717 This fixes a Y2038 bug on 64-bit hosts.
4718 * buffer.c (reset_buffer):
4719 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4720 (Fclear_buffer_auto_save_failure):
4721 Use 0, not -1, to represent an unset failure time, since time_t
4722 might not be signed.
4724 Remove dependency on glibc malloc internals.
4725 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4726 Move back here from lisp.h, but with their new implementations.
4727 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4728 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4729 * charset.c (charset_table_init): New static var.
4730 (syms_of_charset): Use it instead of xmalloc. This removes a
4731 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4732 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4733 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4734 Move back to alloc.c.
4735 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4736 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4738 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4740 * nsterm.m (windowDidResize): Call x_set_window_size only when
4741 ns_in_resize is true. Otherwise set pixelwidth/height and
4742 call change_frame_size (Bug#9628).
4744 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4746 Port --enable-checking=all to Fedora 14 x86-64.
4747 * charset.c (syms_of_charset): Also account for glibc malloc's
4748 internal overhead when calculating the initial malloc maximum.
4750 Port --enable-checking=all to Fedora 14 x86.
4751 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4753 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4754 (overrun_check_realloc, overrun_check_free):
4755 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4756 That way, xmalloc returns a properly-aligned pointer even if
4757 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4758 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4759 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4760 into account when calculating the initial malloc maximum.
4761 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4762 Move here from alloc.c, so that charset.c can use it too.
4763 Properly align; the old code wasn't right for common 32-bit hosts
4764 when configured with --enable-checking=all.
4765 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4766 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4768 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4770 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4773 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4775 * xdisp.c (compute_display_string_end): If there's no display
4776 string at CHARPOS, return -1.
4778 * bidi.c (bidi_fetch_char): When compute_display_string_end
4779 returns a negative value, treat the character as a normal
4780 character not covered by a display string. (Bug#9624)
4782 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4784 * lread.c (Fread_from_string): Fix typo in docstring.
4786 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4788 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4789 newline, reseat the iterator instead of bidi-iterating there one
4790 character at a time. (Bug#9610)
4791 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4792 TO_CHARPOS if the bidi iterator is at base embedding level.
4794 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4796 * lread.c (readevalloop): Use correct code for NBSP.
4797 (read1): Likewise. (Bug#9608)
4799 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4801 * dbusbind.c (Fdbus_register_signal): When service is not
4802 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4804 2011-09-25 Glenn Morris <rgm@gnu.org>
4806 * buffer.c (truncate-lines): Doc fix.
4808 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4810 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4811 (Fset_window_next_buffers): Doc fix.
4813 2011-09-24 Glenn Morris <rgm@gnu.org>
4815 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4817 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4819 Fix minor problems found by static checking.
4820 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4821 * indent.c (Fvertical_motion): Fix == vs = typo.
4823 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4825 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4826 Default value is now t. Doc fix.
4828 * indent.c (Fvertical_motion): Compute and apply the overshoot
4829 logic when moving up, not only when moving down. Fix the
4830 confusing name and values of the it_overshoot_expected variable;
4831 logic changes accordingly. (Bug#9254) (Bug#9549)
4833 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4834 CHARPOS is covered by a display string which includes newlines.
4835 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4836 is covered by a display string with embedded newlines.
4838 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4840 * dbusbind.c (Fdbus_register_signal): Add match rule to
4841 Vdbus_registered_objects_table. (Bug#9581)
4842 (Fdbus_register_method, Vdbus_registered_objects_table):
4845 2011-09-24 Jim Meyering <meyering@redhat.com>
4847 do not ignore write error for any output size
4848 The previous change was incomplete.
4849 While it makes emacs --batch detect the vast majority of stdout
4850 write failures, errors were still ignored whenever the output size is
4851 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4852 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4853 && echo FAIL: ignored write error
4854 FAIL: ignored write error
4855 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4856 && echo FAIL: ignored write error
4857 FAIL: ignored write error
4858 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4860 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4862 * emacs.c (Fkill_emacs): In noninteractive mode exit
4863 non-successfully if a write error occurred on stdout. (Bug#9574)
4865 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4867 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4870 * dispextern.h (struct it): Update the comment documenting what
4873 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4875 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4876 a display string, extend search for cursor position to end of row.
4877 (find_row_edges): If the row ends in a newline from a display
4878 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4879 Handle the case of a display string with multiple newlines.
4880 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4881 non-empty line. Fixes confusing cursor motion with arrow keys at
4882 the beginning of a line that starts with whitespace.
4884 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4886 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4889 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4891 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4894 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4896 * xdisp.c (display_line): Record maximum and minimum buffer
4897 positions even if no glyphs were produced (e.g., by a zero-width
4898 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4899 buffer positions that will be removed from the glyph row because
4901 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4902 column is beyond frame width: don't subtract 1 "pixel" when
4903 computing width of the stretch.
4904 (reseat_at_next_visible_line_start): Undo the change made on
4905 2011-09-17 that saved paragraph information and restored it after
4906 the call to `reseat'. (Bug#9545)
4908 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4910 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4911 and turn window cursor on if cleared (Bug#9415).
4913 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4915 * search.c (boyer_moore): Take unibyte characters from pattern
4916 literally. (Bug#9458)
4918 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4920 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4922 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4924 Fix minor problem found by static checking.
4925 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4926 initialized, to pacify gcc -Wuninitialized.
4928 * fileio.c: Report proper errno when syscall falls.
4929 (Finsert_file_contents): Save and restore errno,
4930 so that report_file_error outputs the correct diagnostic.
4931 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4933 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4935 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4937 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4939 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4940 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4942 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4944 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4945 about the current paragraph and restore it after the call to reseat.
4947 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4948 (bidi_find_paragraph_start): Search back for paragraph beginning
4949 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4950 (bidi_move_to_visually_next): Only trigger paragraph-related
4951 computations when the last character is a newline or at EOB, not
4952 just any NEUTRAL_B. (Bug#9470)
4954 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4955 truncated lines if point is covered by a display string. (Bug#9524)
4957 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4959 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4960 (cons_to_x_long): New function.
4961 (lisp_data_to_selection_data): Use it. Correct the test for
4962 short-versus-long data; it was negated. Break out of vector
4963 loop, for efficiency, when a long datum is discovered.
4965 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4967 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4969 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4971 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4972 GCC PR/17406) by declaring this function with external scope.
4974 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4976 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4977 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4979 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4981 * editfns.c (Fformat): Correctly handle text properties on "%%".
4983 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4985 * xterm.c (x_draw_composite_glyph_string_foreground):
4986 * w32term.c (x_draw_composite_glyph_string_foreground):
4987 * term.c (encode_terminal_code):
4988 * composite.c (composition_update_it, get_composition_id):
4989 * xdisp.c (get_next_display_element)
4990 (fill_composite_glyph_string): Add comments about special meaning
4991 of TAB characters in a composition.
4993 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4995 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4996 This occurs when processing a multibyte format.
4997 Problem reported by Wolfgang Jenker.
4999 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5001 * xdisp.c (try_cursor_movement): Only check for exact match if
5002 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5004 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5006 Remove unused external symbols.
5007 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5008 * xdisp.c (calc_pixel_width_or_height): Now static.
5009 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5010 * indent.c (check_display_width):
5011 * w32term.c: Fix comment to match code.
5012 * xterm.c, xterm.h (x_catching_errors): Remove.
5014 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5016 * xselect.c: Use signed conversions more consistently (Bug#9498).
5017 (selection_data_to_lisp_data): Assume incoming selection data are
5018 signed integers, not unsigned. This is to be consistent with
5019 outgoing selection data, which was modified to use signed integers
5020 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5021 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5022 expects long, not unsigned long.
5024 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5026 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5027 computation of loop end. Reported by Johan Bockgård
5030 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5032 * frame.c (Fother_visible_frames_p): Function deleted.
5034 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5036 * indent.c (compute_motion): Process display vector front to back
5037 rather than the other way around. (Bug#2496)
5039 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5041 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5043 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5045 * minibuf.c (Fread_from_minibuffer): Doc fix.
5047 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5049 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5050 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5052 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5054 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5055 value for non-existent files.
5057 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5059 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5060 set its "size" to -1. This will set the modtime_size field of
5061 the corresponding buffer to -1, which is what
5062 verify-visited-file-modtime expects for files that do not exist.
5065 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5067 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5069 * lisp.h: ... from here. push_key_description is no longer
5070 defined in keyboard.c, so its declaration should not be in
5071 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5072 logically belongs with push_key_description.
5074 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5076 * buffer.h: Include <sys/types.h> instead of <time.h>.
5077 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5078 Problem reported by Herbert J. Skuhra.
5080 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5082 * xml.c (parse_region): Make the parsing work for
5083 non-comment-starting XML files again (bug#9144).
5085 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5087 * image.c (gif_load): Fix calculation of bottom and right corner.
5090 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5092 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5093 redisplay in small windows.
5095 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5097 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5099 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5101 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5102 Operate on live windows only.
5104 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5106 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5108 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5110 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5111 only under bidi iteration.
5113 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5115 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5117 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5119 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5120 Without this fix, the command to link temacs failed due to an
5121 undefined symbol __builtin_isnan. This is because
5122 /usr/include/iso/math_c99.h #defines isnan(x) to
5123 __builtin_isnan(x), but the bundled gcc, which identifies itself
5124 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5126 * floatfns.c (isnan): #undef, and then #define to a clone of
5128 (Fisnan): Always define, since it's always available now.
5129 (syms_of_floatfns): Always define isnan at the Lisp level.
5131 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5133 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5135 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5137 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5138 The previous code assumed that file offsets (off_t values) fit in
5139 EMACS_INT variables, which is not true on typical 32-bit hosts.
5140 The code messed up by falsely reporting buffer overflow in cases
5141 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5142 when "big" contains more than 2**29 bytes, even though this
5143 inserts just one byte and does not overflow the buffer.
5144 (Finsert_file_contents): Store file offsets as off_t
5145 values, not as EMACS_INT values. Check for overflow when
5146 converting between EMACS_INT and off_t. When checking for
5147 buffer overflow or for overlap, take the offsets into account.
5148 Don't use EMACS_INT for small values where int suffices.
5149 When checking for overlap, fix a typo: ZV was used where
5150 ZV_BYTE was intended.
5151 (Fwrite_region): Don't assume off_t fits into 'long'.
5152 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5154 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5156 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5158 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5160 sprintf-related integer and memory overflow issues (Bug#9412).
5162 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5163 (esprintf, exprintf, evxprintf): New functions.
5164 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5165 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5166 (modify_event_symbol): Do not assume that the length of
5167 name_alist_or_stem is safe to alloca and fits in int.
5168 (Fexecute_extended_command): Likewise for function name and binding.
5169 (Frecursion_depth): Wrap around reliably on integer overflow.
5170 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5171 since some callers pass EMACS_INT values.
5172 (Fsingle_key_description): Don't crash if symbol name contains more
5173 than MAX_ALLOCA bytes.
5174 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5175 (get_minibuffer): Arg is now EMACS_INT, not int.
5176 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5177 (esprintf, exprintf, evxprintf): New decls.
5178 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5180 * dbusbind.c (signature_cat): New function.
5181 (xd_signature, Fdbus_register_signal):
5182 Do not overrun buffer; instead, report string overflow.
5184 * dispnew.c (add_window_display_history): Don't overrun buffer.
5185 Truncate instead; this is OK since it's just a log.
5187 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5188 even if the time zone offset is outlandishly large.
5189 Don't mishandle offset == INT_MIN.
5191 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5192 when creating daemon; the previous buffer-overflow check was incorrect.
5194 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5195 which has the guts of the old verror function.
5197 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5198 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5200 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5201 (font_unparse_xlfd): Don't blindly alloca long strings.
5202 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5203 fits in int, when using sprintf. Use single snprintf to count
5204 length of string rather than counting it via multiple sprintfs;
5205 that's simpler and more reliable.
5206 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5207 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5208 sprintf, in case result does not fit in int.
5210 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5211 (fontset_from_font): Print it.
5213 * frame.c (tty_frame_count): Now printmax_t, not int.
5214 (make_terminal_frame, set_term_frame_name): Print it.
5215 (x_report_frame_params): In X, window IDs are unsigned long,
5216 not signed long, so print them as unsigned.
5217 (validate_x_resource_name): Check for implausibly long names,
5218 and don't assume name length fits in 'int'.
5219 (x_get_resource_string): Don't blindly alloca invocation name;
5220 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5223 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5224 (xg_check_special_colors, xg_set_geometry):
5225 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5227 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5228 Use esprintf, not sprintf, in case result does not fit in int.
5230 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5231 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5232 it as a large positive number.
5233 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5234 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5236 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5237 in case result does not fit in int.
5239 * print.c (float_to_string): Detect width overflow more reliably.
5240 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5241 buffer overrun. Don't assume list length fits in 'int'. Treat
5242 print length of 0 as 0, not as infinity; to be consistent with other
5243 uses of print length in this function. Don't overflow print length
5244 index. Don't assume hash table size fits in 'long', or that
5245 vectorlike size fits in 'unsigned long'.
5247 * process.c (make_process): Use printmax_t, not int, to format
5248 process-name gensyms.
5250 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5252 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5253 to avoid potential buffer overrun.
5255 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5256 if X resource line is longer than 512 bytes.
5258 * xfns.c (x_window): Make sprintf buffer a bit bigger
5259 to avoid potential buffer overrun.
5261 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5263 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5265 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5267 Integer overflow fixes for scrolling, etc.
5268 Without these, Emacs silently mishandles large integers sometimes.
5269 For example, "C-u 4294967297 M-x recenter" was treated as if
5270 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5272 * xdisp.c (try_window_id): Check Emacs fixnum range before
5273 converting to 'int'.
5275 * window.c (window_scroll_line_based, Frecenter):
5276 Check that an Emacs fixnum is in range before assigning it to 'int'.
5277 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5278 values converted from Emacs fixnums.
5279 (Frecenter): Don't wrap around a line count if it is out of 'int'
5280 range; instead, treat it as an extreme value.
5281 (Fset_window_configuration, compare_window_configurations):
5282 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5284 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5285 that can exceed INT_MAX. Check that EMACS_INT value is in range
5286 before assigning it to the (possibly-narrower) index.
5287 (match_limit): Don't assume that a fixnum can fit in 'int'.
5289 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5292 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5293 (Fvertical_motion): Don't wrap around LINES values that don't fit
5294 in 'int'. Instead, treat them as extreme values. This is good
5295 enough for windows, which can't have more than INT_MAX lines anyway.
5297 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5299 * Require libxml/parser.h to avoid compilation warning.
5301 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5303 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5304 since this reportedly can destroy thread storage.
5306 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5308 * syntax.c (find_defun_start): Update all cache variables if
5309 exiting early (Bug#9401).
5311 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5313 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5315 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5316 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5317 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5319 * term.c (tty_append_glyph): New function.
5320 (produce_stretch_glyph): Static function and its prototype deleted.
5322 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5325 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5327 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5328 when checking :margin (Bug#9390).
5329 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5330 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5331 so that the name doesn't mislead. All uses changed.
5333 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5335 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5338 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5340 * xdisp.c (move_it_to): Don't bail out early when reaching
5341 position beyond to_charpos, if we are scanning backwards.
5342 (move_it_vertically_backward): When DY == 0, make sure we get to
5343 the first character in the line after the newline.
5345 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5347 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5348 (ccl_driver): Do not generate an out-of-range pointer.
5349 (Fccl_execute_on_string): Remove unnecessary check for
5350 integer overflow, noted by Stefan Monnier in
5351 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5352 Remove a FIXME that didn't need fixing.
5353 Simplify the newly-introduced buffer reallocation code.
5355 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5357 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5359 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5361 Integer and memory overflow issues (Bug#9196).
5363 * doc.c (get_doc_string): Rework so that
5364 get_doc_string_buffer_size is the actual buffer size, rather than
5365 being 1 less than the actual buffer size; this makes xpalloc more
5368 * image.c (x_allocate_bitmap_record, cache_image):
5369 * xselect.c (Fx_register_dnd_atom):
5370 Simplify previous changes by using xpalloc.
5372 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5373 since either will do and ptrdiff_t is convenient with xpalloc.
5375 * charset.c (charset_table_size)
5376 (struct charset_sort_data.priority): Now ptrdiff_t.
5377 (charset_compare): Don't overflow if priorities differ greatly.
5378 (Fsort_charsets): Don't assume list length fits in int.
5379 Check for size-calculation overflow when allocating sort data.
5380 (syms_of_charset): Allocate an initial charset table that is
5381 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5383 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5385 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5386 The actual value is always <= INT_MAX, and leaving it unsigned made
5387 overflow checking harder.
5389 * dispextern.h (struct glyph_matrix.rows_allocated)
5390 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5391 with xpalloc. The values are still always <= INT_MAX.
5393 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5395 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5396 (SAFE_NALLOCA): New macro.
5398 * region-cache.c (struct boundary.pos, find_cache_boundary)
5399 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5400 (set_cache_region, invalidate_region_cache)
5401 (revalidate_region_cache, know_region_cache, region_cache_forward)
5402 (region_cache_backward, pp_cache):
5403 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5404 so that ptrdiff_t * can be passed to xpalloc.
5405 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5406 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5407 (pp_cache): Don't assume cache_len fits in int.
5408 * region-cache.h: Adjust extern decls to match.
5410 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5411 EMACS_INT, since either will do, for xpalloc.
5413 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5414 (xnmalloc, xnrealloc, xpalloc): New functions.
5416 * bidi.c (bidi_shelve_header_size): New constant.
5417 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5418 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5420 * bidi.c (bidi_cache_shrink):
5421 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5423 Don't update size of array until after memory allocation succeeds,
5424 because xmalloc/xrealloc may not return.
5425 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5426 now that we have proper integer overflow checking.
5427 (record_overlay_string, overlay_strings): Catch overflows when
5428 calculating size of overlay_str_buf.
5430 * callproc.c (Fcall_process): Check for size overflow when
5431 calculating size of args2.
5432 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5433 Normally we prefer signed values, but sticking with ptrdiff_t would
5434 require adding more-complicated checks.
5436 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5437 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5438 Redo buffer-overflow calculations to avoid integer overflow.
5439 Add a FIXME comment where memory seems to be over-allocated.
5441 * character.c (Fstring): Check for size-calculation overflow.
5443 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5444 unnecessary integer overflow. Check for size overflow.
5445 (encode_coding_object): Don't update size until xmalloc succeeds.
5447 * composite.c (get_composition_id): Check for overflow in glyph
5448 length calculations.
5450 Integer and memory overflow fixes for display code.
5451 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5452 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5453 (scrolling_window): Check for overflow in size calculations.
5454 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5455 Don't assume glyph table len fits in int.
5456 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5457 (row_table_size): Now ptrdiff_t, not int.
5458 (scrolling_window): Avoid overflow in size calculations.
5459 Don't update size until allocation succeeds.
5460 * fns.c (concat): Check for overflow in size calculations.
5461 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5462 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5463 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5465 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5466 (get_doc_string): Check for size calculation overflow.
5467 Don't update size until allocation succeeds.
5468 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5469 EMACS_INT, where ptrdiff_t will do.
5470 (Fsubstitute_command_keys): Check for string overflow.
5472 * editfns.c (set_time_zone_rule): Don't assume environment length
5474 (message_length): Now ptrdiff_t, not int.
5475 (Fmessage_box): Don't update size until allocation succeeds.
5476 Don't assume message length fits in int.
5477 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5479 * emacs.c (main): Do not reallocate argv, since there is a null at
5480 the end that can be overwritten, and this way there's no need to
5481 worry about size-calculation overflow.
5482 (sort_args): Check for size-calculation overflow.
5484 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5486 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5488 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5489 (x_set_scroll_bar_width, x_figure_window_size):
5490 Check for integer overflow.
5491 (x_set_alpha): Do not assume XINT fits in int.
5493 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5494 This is for the members text_lines, text_cols, total_lines, total_cols,
5495 where the system imposes an 'int' limit.
5497 * fringe.c (Fdefine_fringe_bitmap):
5498 Don't update size until alloc works.
5500 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5501 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5503 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5504 Check for size-calculation overflow.
5505 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5506 do, as we prefer signed integers.
5507 (id_to_widget.max_size, id_to_widget.used)
5508 (xg_store_widget_in_map, xg_remove_widget_from_map)
5509 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5510 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5511 Use and return ptrdiff_t, not int.
5512 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5513 * gtkutil.h: Change prototypes to match the above.
5515 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5516 are duplicate now that they've been promoted to lisp.h.
5517 (x_allocate_bitmap_record, x_alloc_image_color)
5518 (make_image_cache, cache_image, xpm_load):
5519 Don't update size until alloc is done.
5520 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5522 Check for size calculation overflow.
5523 (ct_colors_allocated_max): New constant.
5524 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5527 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5528 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5529 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5530 Use ptrdiff_t, not int, to count maps.
5531 (read_char_minibuf_menu_prompt): Check for overflow in size
5532 calculations. Don't update size until allocation succeeds.
5533 Redo calculations to avoid overflow.
5534 * keyboard.h: Change prototypes to match the above.
5536 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5538 (current_minor_maps): Check for size calculation overflow.
5539 * keymap.h: Change prototypes to match the above.
5541 * lread.c (read1, init_obarray): Don't update size until alloc done.
5543 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5544 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5546 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5547 Now ptrdiff_t, not int.
5548 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5549 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5551 * process.c (Fnetwork_interface_list): Check for overflow
5552 in size calculation.
5554 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5556 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5557 overflow. Don't bother calling xmalloc when xrealloc will do.
5559 * search.c (Freplace_match): Check for size calculation overflow.
5560 (Fset_match_data): Don't assume list lengths fit in 'int'.
5562 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5563 for command line length. Do not attempt to address one before the
5564 beginning of an array, as that's not portable.
5566 * term.c (max_frame_lines): Remove; unused.
5567 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5569 (encode_terminal_code, calculate_costs): Check for size
5570 calculation overflow.
5571 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5572 table lengths and related sizes. Don't update size until alloc
5573 done. Redo calculations to avoid overflow.
5574 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5576 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5577 subtracting pointers.
5578 (gobble_line): Check for overflow more carefully. Don't update size
5581 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5582 Don't update size until alloc done.
5583 Redo size calculations to avoid overflow.
5584 Check for size calculation overflow.
5585 (main) [DEBUG]: Fix typo in invoking tparam1.
5587 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5588 Use ptrdiff_t, not int, for sizes.
5589 (store_mode_line_noprop_char): Don't update size until alloc done.
5591 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5592 Use ptrdiff_t, not int, for sizes.
5593 (Finternal_make_lisp_face, cache_face):
5594 Check for size calculation overflow.
5595 (cache_face): Treat size calculation overflows as if they were
5596 memory exhaustion (the usual treatment), rather than aborting.
5598 * xfns.c (x_encode_text, x_set_name_internal)
5599 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5600 sizes, since they can exceed INT_MAX in size. Check for size
5601 calculation overflow.
5603 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5604 (xg_select): Check for size calculation overflow.
5605 Don't update size until alloc done.
5607 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5608 as sprintf is limited to int lengths.
5610 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5611 (X_LONG_MIN): New macros.
5612 Use them to make the following changes clearer.
5613 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5614 This change doesn't affect the value now, but it may help remind
5615 future maintainers not to raise the value too much later.
5616 (SELECTION_QUANTUM): Remove, replacing with ...
5617 (selection_quantum): ... new function, which avoids overflow.
5619 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5620 assumption that selection length fits in 'int'.
5621 (x_reply_selection_request, x_handle_selection_request)
5622 (x_get_window_property, receive_incremental_selection)
5623 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5624 (lisp_data_to_selection_data, clean_local_selection_data):
5625 Use ptrdiff_t, not int, to record length of selection.
5626 (x_reply_selection_request, x_get_window_property)
5627 (receive_incremental_selection, x_property_data_to_lisp):
5628 Redo calculations to avoid overflow.
5629 (x_reply_selection_request): When sending hint, ceiling it at
5630 X_LONG_MAX rather than relying on wraparound overflow to send
5632 (x_get_window_property, receive_incremental_selection)
5633 (lisp_data_to_selection_data, x_property_data_to_lisp):
5634 Check for size-calculation overflow.
5635 (x_get_window_property, receive_incremental_selection)
5636 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5637 Don't store size until memory allocation succeeds.
5638 (x_get_window_property): Plug memory leak on memory exhaustion.
5639 Don't double-block input; malloc is safe here. Don't assume 2**34
5640 - 4 fits in unsigned long. Add an xassert to check
5641 XGetWindowProperty overflow. Be more careful about overflow
5642 calculations, and distinguish size from memory overflow better.
5643 (receive_incremental_selection): When tracing, don't assume
5644 unsigned int is less than INT_MAX.
5645 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5646 harmful) conversions of unsigned short to int.
5647 (lisp_data_to_selection_data): Don't assume that integers
5648 in the range -65535 through -1 fit in an X unsigned short.
5649 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5650 result parameters unless successful. Rely on cons_to_unsigned
5651 to report problems with elements; the old code wasn't right anyway.
5652 (x_check_property_data): Check for int overflow; we cannot use
5653 a wider type due to X limits.
5654 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5656 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5658 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5659 (x_term_init): Check for size calculation overflow.
5660 (x_color_cells): Don't store size until memory allocation succeeds.
5661 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5662 Don't assume alloca size is less than MAX_ALLOCA.
5663 (x_term_init): Don't assume length fits in int (sprintf is limited
5666 Use ptrdiff_t for composition IDs.
5667 * character.c (lisp_string_width):
5668 * composite.c (composition_table_size, n_compositions)
5669 (get_composition_id, composition_gstring_from_id):
5670 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5671 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5672 * window.c (Frecenter):
5673 Use ptrdiff_t, not int, for composition IDs.
5674 * composite.c (get_composition_id): Check for integer overflow.
5675 * composite.h: Adjust prototypes to match the above changes.
5677 Use ptrdiff_t for hash table indexes.
5678 * category.c (hash_get_category_set):
5679 * ccl.c (ccl_driver):
5680 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5681 * coding.c (coding_system_charset_list, detect_coding_system):
5682 * coding.h (struct coding_system.id):
5683 * composite.c (get_composition_id, gstring_lookup_cache):
5684 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5685 * image.c (xpm_get_color_table_h):
5686 * lisp.h (hash_lookup, hash_put):
5687 * minibuf.c (Ftest_completion):
5688 Use ptrdiff_t for hash table indexes, not int (which is too
5689 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5690 32-bit --with-wide-int hosts).
5692 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5693 Add a FIXME comment about memory leaks.
5694 (syms_of_charset): Don't assume xmalloc returns.
5696 Don't assume that stated character widths fit in int.
5697 * character.c (Fchar_width, c_string_width, lisp_string_width):
5698 * character.h (CHAR_WIDTH):
5699 * indent.c (MULTIBYTE_BYTES_WIDTH):
5700 Use sanitize_char_width to avoid undefined and/or bad behavior
5701 with outlandish widths.
5702 * character.h (sanitize_tab_width): Rename from sanitize_width,
5703 now that we have two such functions. All uses changed.
5704 (sanitize_char_width): New inline function.
5706 Don't assume that tab-width fits in int.
5707 * character.h (sanitize_width): New inline function.
5708 (SANE_TAB_WIDTH): New macro.
5709 (ASCII_CHAR_WIDTH): Use it.
5710 * indent.c (sane_tab_width): Remove. All uses replaced by
5711 SANE_TAB_WIDTH (current_buffer).
5712 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5714 * fileio.c: Integer overflow issues with file modes.
5715 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5717 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5718 Remove unreachable code.
5719 (read_hex, load_charset_map_from_file): Check for integer overflow.
5721 * xterm.c: Don't go over XClientMessageEvent limit.
5722 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5723 (x_send_scroll_bar_event): Likewise. Check that the size does not
5724 exceed limits imposed by XClientMessageEvent, as well as the usual
5725 ptrdiff_t and size_t limits.
5727 * keyboard.c: Overflow, signedness and related fixes.
5728 (make_lispy_movement): Use same integer type in forward decl
5729 that is used in the definition.
5730 (read_key_sequence, keyremap_step):
5731 Change bufsize argument back to int, undoing my 2011-03-30 change.
5732 We prefer signed types, and int is wide enough here.
5733 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5734 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5735 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5736 length, not size_t. Use ptrdiff_t for index, not int.
5737 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5738 possibility of integer overflow.
5740 Overflow, signedness and related fixes for images.
5742 * dispextern.h (struct it.stack[0].u.image.image_id)
5743 (struct_it.image_id, struct image.id, struct image_cache.size)
5744 (struct image_cache.used, struct image_cache.ref_count):
5745 * gtkutil.c (update_frame_tool_bar):
5746 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5747 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5748 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5749 * nsmenu.m (update_frame_tool_bar):
5750 * xdisp.c (calc_pixel_width_or_height):
5751 * xfns.c (image_cache_refcount):
5752 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5753 on typical 64-bit hosts.
5755 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5756 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5757 Omit unnecessary casts to int.
5758 (parse_image_spec): Check that integers fall into 'int' range
5759 when the callers expect that.
5760 (image_ascent): Redo ascent calculation to avoid int overflow.
5761 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5762 (lookup_image): Remove unnecessary tests.
5763 (xbm_image_p): Locals are now of int, not EMACS_INT,
5764 since parse_image_check makes sure they fit into int.
5765 (png_load, gif_load, svg_load_image):
5766 Prefer int to unsigned where either will do.
5767 (tiff_handler): New function, combining the cores of the
5768 old tiff_error_handler and tiff_warning_handler.
5769 This function is rewritten to use vsnprintf and thereby avoid
5770 stack buffer overflows. It uses only the features of vsnprintf
5771 that are common to both POSIX and native Microsoft.
5772 (tiff_error_handler, tiff_warning_handler): Use it.
5773 (tiff_load, gif_load, imagemagick_load_image):
5774 Don't assume :index value fits in 'int'.
5775 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5776 (imagemagick_load_image): Check that crop parameters fit into
5777 the integer types that MagickCropImage accepts. Don't assume
5778 Vimagemagick_render_type has a nonnegative value. Don't assume
5779 size_t fits in 'long'.
5780 (gs_load): Use printmax_t to print the widest integers possible.
5781 Check for integer overflow when computing image height and width.
5783 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5785 * xdisp.c (redisplay_window): Don't force window start if point
5786 will be invisible in the resulting window. (Bug#9324)
5788 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5790 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5791 the display spec is of the form `(space ...)'.
5792 (handle_display_spec): Return the value returned by
5793 handle_single_display_spec, not just 1 or zero.
5794 (handle_single_display_spec): If the display spec is of the form
5795 `(space ...)', and specifies display in the text area, return 2
5797 (try_cursor_movement): Check for the need to scroll more
5798 accurately, and prefer exact match for point under bidi.
5799 Don't advance `row' beyond the last row of the window.
5801 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5802 into disp_prop; all users changed.
5804 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5805 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5806 for the text covered by the display property.
5808 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5810 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5811 Change return value to nil.
5812 (Frecord_buffer): Delete unused function.
5814 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5816 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5817 buffers, return left-to-right.
5818 (set_cursor_from_row): Consider candidate row a win if its glyph
5819 represents a newline and point is on that newline. Fixes cursor
5820 positioning on the newline at EOL of R2L text within L2R
5821 paragraph, and vice versa.
5822 (try_cursor_movement): Check continued rows, in addition to
5823 continuation rows. Fixes unwarranted scroll when point enters a
5824 continued line of R2L text within an L2R paragraph, or vice versa.
5825 (cursor_row_p): Consider the case of point being equal to
5826 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5827 from the end of a short line to the beginning of a continued line
5828 of R2L text within L2R paragraph.
5829 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5830 composed characters.
5832 * bidi.c (bidi_check_type): Use xassert.
5833 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5836 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5838 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5841 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5843 * nsfont.m (ns_otf_to_script): Fix typo.
5845 2011-08-22 Kenichi Handa <handa@m17n.org>
5847 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5848 extra slot even if the purpose is char-code-property-table.
5850 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5852 * xdisp.c (redisplay_window): When computing centering_position,
5853 account for the height of the header line. (Bug#8874)
5855 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5856 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5857 candidate is selected by the mouse, and that candidate has a
5858 composed character under the mouse.
5860 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5861 coordinates reported by pos-visible-in-window-p for a composed
5862 character in column zero.
5864 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5866 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5868 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5870 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5871 consider it a hit if to_charpos is anywhere in the range of the
5872 composed buffer positions.
5874 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5876 * image.c (gif_load): Don't assume that each subimage has the same
5877 dimensions as the base image. Handle disposal method that is
5878 "undefined" by the gif spec (Bug#9335).
5880 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5882 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5883 (Fcondition_case): Document `debug' symbol in error handler.
5885 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5887 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5888 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5889 from an Org mode buffer to a Speedbar frame.
5891 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5892 a composition, take its buffer position from IT->cmp_it.charpos.
5893 Fixes cursor positioning at the beginning of a line that begins
5894 with a composed character.
5896 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5898 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5899 character bidirectional type, use STRONG_L instead. Fixes crashes
5900 in a buffer produced by `describe-categories'.
5902 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5903 members before the level stack, so they would be saved and
5904 restored when copying iterator state. Fixes incorrect reordering
5905 around TABs covered by display properties.
5907 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5909 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5911 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5913 * eval.c (internal_condition_case, internal_condition_case_1)
5914 (internal_condition_case_2, internal_condition_case_n):
5915 Remove unnecessary aborts (Bug#9081).
5917 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5919 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5920 has no `load' handler, try opening the file locally. (Bug#9311)
5922 2011-08-16 Ken Brown <kbrown@cornell.edu>
5924 * gmalloc.c: Expand comment.
5926 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5928 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5929 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5931 2011-08-16 Ken Brown <kbrown@cornell.edu>
5933 Fix memory allocation problems in Cygwin build (Bug#9273).
5935 * unexcw.c ( __malloc_initialized): Declare external variable.
5936 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5938 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5940 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5942 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5944 [CYGWIN] (special_realloc): New function.
5945 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5946 requests to realloc storage in the static heap.
5948 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5950 * bidi.c (bidi_initialize): Remove unused local.
5952 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5955 * biditype.h: Remove file.
5956 * makefile.w32-in ($(BLD)/bidi.$(O)):
5957 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5959 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5961 * chartab.c: Improve commentary for the uniprop_table API.
5963 * bidi.c (bidi_paragraph_init): Support zero value of
5964 bidi_ignore_explicit_marks_for_paragraph_level.
5965 (bidi_initialize): Use uniprop_table instead of including
5966 biditype.h and bidimirror.h.
5968 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5969 coordinates of the iterator when restoring from ppos_it.
5972 2011-08-14 Kenichi Handa <handa@m17n.org>
5974 * process.c (create_process): Call setup_process_coding_systems
5975 after the pid of the process is set to -1 (Bug#8162).
5977 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5979 * xdisp.c (move_it_in_display_line_to): Don't invoke
5980 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5981 ppos_it. Fixes vertical cursor motion when line beginning is
5982 covered by an image. (Bug#9296)
5984 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5986 * nsterm.h (ns_run_ascript): Declare.
5987 (NSAPP_DATA2_RUNASSCRIPT): Define.
5989 * nsfns.m (as_script, as_result, as_status): New static variables.
5990 (ns_run_ascript): New function.
5991 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5992 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5993 the event loop. Get status from as_status (Bug#7276).
5995 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5996 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5997 the event loop (Bug#7276).
5999 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6001 * gnutls.c (QCgnutls_bootprop_priority)
6002 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6003 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6004 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6005 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6006 (QCgnutls_bootprop_verify_hostname_error)
6007 (QCgnutls_bootprop_callbacks_verify): Rename from
6008 Qgnutls_bootprop_..., all uses changed.
6010 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6013 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6015 * xfaces.c (Qframe_set_background_mode): Now static.
6016 * dispextern.h (Qframe_set_background_mode): Remove decl.
6018 * process.c (Fnetwork_interface_info): Declare local only if needed.
6020 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6022 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6023 (Fnetwork_interface_list): Allocate in increments of bytes instead
6024 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6025 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6027 (struct ifflag_def): notrailers is smart on OSX.
6028 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6029 Get hardware address with getifaddrs if available.
6031 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6033 * xdisp.c (iterate_out_of_display_property): xassert that
6034 IT->position is set to within IT->object's boundaries. Break from
6035 the loop as soon as EOB is reached; avoids infloops in redisplay
6036 when IT->position is set up wrongly due to some bug.
6037 Set IT->current to match the bidi iterator unconditionally.
6038 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6039 entry. Force push_it to save on the stack the current
6040 buffer/string position, to be restored by pop_it. Fix flags in
6041 the iterator structure wrt the object coming from a display
6042 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6043 properties. (Bug#9284)
6045 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6047 * fontset.c (fontset_get_font_group): Add proper type checks.
6050 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6052 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6053 and LC_VERSION_MIN_MACOSX.
6054 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6055 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6057 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6059 * xdisp.c (forward_to_next_line_start): Allow to use the
6060 no-display-properties-and-no-overlays under bidi display.
6061 Set disp_pos in the bidi iterator to avoid searches for display
6062 properties and overlays.
6064 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6066 * editfns.c (Fset_time_zone_rule): Document relationship with the
6069 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6070 the font entity extracted from the cache (Bug#8109).
6072 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6074 * composite.c (autocmp_chars): Don't reset point. That is done by
6075 restore_point_unwind (Bug#5984).
6077 2011-08-07 Juri Linkov <juri@jurta.org>
6079 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6080 to show the arg `TIME' instead of `TIMEVAL'.
6082 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6084 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6085 display property strides EOL and includes a newline, as in
6086 longlines-mode. (Bug#9254)
6087 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6088 word-wrap under bidirectional display. (Bug#9224)
6090 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6091 is non-zero, even if the data buffer is NULL. Fixes a crash in
6092 vertical-motion with longlines-mode. (Bug#9254)
6094 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6096 * bidi.c <bidi_cache_total_alloc>: Now static.
6097 (bidi_initialize): Initialize bidi_cache_total_alloc.
6099 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6102 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6103 amount allocated this far in `bidi_cache_total_alloc'.
6104 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6105 non-zero, only free the data buffer without restoring the cache
6106 contents. All callers changed.
6108 * dispextern.h (bidi_unshelve_cache): Update prototype.
6110 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6111 (move_it_in_display_line, move_it_to)
6112 (move_it_vertically_backward, move_it_by_lines): Replace the call
6113 to xfree to an equivalent call to bidi_unshelve_cache.
6114 (move_it_in_display_line_to): Fix logic of returning
6115 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6117 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6119 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6120 came from a string character with a `cursor' property. (Bug#9229)
6122 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6124 * Makefile.in (LIB_PTHREAD): New variable.
6125 (LIBES): Add LIB_PTHREAD (Bug#9216).
6127 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6128 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6130 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6132 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6134 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6136 * xterm.c (x_find_topmost_parent): New function.
6137 (x_set_frame_alpha): Find topmost parent window with
6138 x_find_topmost_parent and set the property there also (bug#9181).
6139 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6141 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6143 * callproc.c (Fcall_process): Avoid vfork clobbering
6144 the local vars buffer, coding_systems, current_dir.
6146 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6148 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6150 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6152 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6153 so that it is not optimized away.
6155 * xdisp.c (compute_display_string_pos): Remove unused local.
6157 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6159 Fix slow cursor motion and scrolling in large buffers with
6160 selective display, like Org Mode buffers. (Bug#9218)
6162 * dispextern.h (struct bidi_it): New member disp_prop_p.
6164 * xdisp.c: Remove one-slot cache of display string positions.
6165 (compute_display_string_pos): Accept an additional argument
6166 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6167 for a display string or property. If found, set DISP_PROP_P
6170 * bidi.c (bidi_fetch_char): Accept an additional argument
6171 DISP_PROP_P, and pass it to compute_display_string_pos.
6172 Only handle text covered by a display string if DISP_PROP_P is returned
6173 non-zero. All callers of bidi_fetch_char changed.
6175 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6177 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6179 2010-12-03 Don March <don@ohspite.net>
6181 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6182 last character M-[char] is translated to ESC [char] (bug#7541).
6184 2011-08-02 Kenichi Handa <handa@m17n.org>
6186 * lisp.h (uniprop_table): Extern it.
6188 * chartab.c (uniprop_table): Make it non-static.
6190 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6192 * xdisp.c (forward_to_next_line_start): Accept additional argument
6193 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6195 (reseat_at_next_visible_line_start): Use the bidi iterator state
6196 returned by forward_to_next_line_start to restore the state of
6197 it->bidi_it after backing up to previous newline. (Bug#9212)
6199 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6201 * regex.c (re_comp): Protoize.
6202 (re_exec): Fix return type.
6203 (regexec): Fix type of `ret'. (Bug#9203)
6205 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6207 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6208 This is needed if max-image-size is a floating-point number.
6210 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6212 * print.c (print_object): Print empty symbol as ##.
6214 * lread.c (read1): Read ## as empty symbol.
6216 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6218 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6219 setting frame foreground color (Bug#9175).
6220 (x_set_background_color): Likewise.
6222 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6223 contents (Bug#9176).
6224 (EmacsTooltip -init): Remove bezels and add shadows to
6227 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6228 or scroll bar (Bug#8470).
6230 * nsfont.m (nsfont_open): Remove assignment to voffset and
6231 unnecessary vars hshink, expand, hd, full_height, min_height.
6232 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6234 * nsterm.h (nsfont_info): Remove voffset field.
6236 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6238 Implement strike-through and overline on NextStep (Bug#8863).
6240 * nsfont.m (nsfont_open): Use underline position provided by font,
6241 instead of hard-coded value of 2.
6242 (nsfont_draw): Call ns_draw_text_decoration instead.
6244 * nsterm.h: Add declaration for ns_draw_text_decoration.
6246 * nsterm.m (ns_draw_text_decoration): New function for drawing
6247 underline, overline, and strike-through.
6248 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6249 ns_draw_text_decoration. Change treatment of cursor drawing to
6250 accommodate underlining, etc.
6252 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6254 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6257 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6259 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6260 Without this fix, if a signal arrives just after memory fills up,
6261 'malloc' might be invoked reentrantly.
6263 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6264 In other words, assume that every image size is allowed, on non-X
6265 hosts. This assumption is probably wrong, but it lets Emacs compile.
6267 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6269 * regex.c (re_iswctype): Convert return values to boolean.
6271 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6273 * xdisp.c (compute_display_string_pos): Don't use cached display
6274 string position if the buffer had its restriction changed.
6277 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6279 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6281 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6283 Integer signedness and overflow and related fixes. (Bug#9079)
6285 * bidi.c: Integer size and overflow fixes.
6286 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6287 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6288 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6289 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6290 (bidi_find_other_level_edge):
6291 Use ptrdiff_t instead of EMACS_INT where either will do.
6292 This works better on 32-bit hosts configured --with-wide-int.
6293 (bidi_cache_ensure_space): Check for size-calculation overflow.
6294 Use % rather than repeated addition, for better worst-case speed.
6295 Don't set bidi_cache_size until after xrealloc returns, because it
6297 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6298 (bidi_cache_ensure_space): Also check that the bidi cache size
6299 does not exceed that of the largest Lisp string or buffer. See Eli
6300 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6302 * alloc.c (__malloc_size_t): Remove.
6303 All uses replaced by size_t. See Andreas Schwab's note
6304 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6306 * image.c: Improve checking for integer overflow.
6307 (check_image_size): Assume that f is nonnull, since
6308 it is always nonnull in practice. This is one less thing to
6309 worry about when checking for integer overflow later.
6310 (x_check_image_size): New function, which checks for integer
6311 overflow issues inside X.
6312 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6313 This removes the need for a memory_full check.
6314 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6315 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6316 (xbm_read_bitmap_data): Change locals back to 'int', since
6317 their values must fit in 'int'.
6318 (xpm_load_image, png_load, tiff_load):
6319 Invoke x_create_x_image_and_pixmap earlier,
6320 to avoid much needless work if the image is too large.
6321 (tiff_load): Treat overly large images as if
6322 x_create_x_image_and_pixmap failed, not as malloc failures.
6323 (gs_load): Use x_check_image_size.
6325 * gtkutil.c: Omit integer casts.
6326 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6327 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6329 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6331 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6332 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6333 would wrongly return t on a 64-bit host.
6335 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6336 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6337 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6338 and therefore cause GCC to emit a bogus diagnostic in some cases.
6340 * image.c: Integer signedness and overflow and related fixes.
6341 This is not an exhaustive set of fixes, but it's time to
6342 record what I've got.
6343 (lookup_pixel_color, check_image_size): Remove redundant decls.
6344 (check_image_size): Don't assume that arbitrary EMACS_INT values
6345 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6346 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6347 (tiff_load, imagemagick_load_image):
6348 Check for overflow in size calculations.
6349 (x_create_x_image_and_pixmap): Remove unnecessary test for
6350 xmalloc returning NULL; that can't happen.
6351 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6352 (xpm_color_bucket): Use better integer hashing function.
6353 (xpm_cache_color): Don't possibly over-allocate memory.
6354 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6355 (gif_memory_source):
6356 Use ptrdiff_t, not int or size_t, to record sizes.
6357 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6358 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6359 either works, as we prefer signed integers.
6360 (tiff_read_from_memory, tiff_write_from_memory):
6361 Return tsize_t, not size_t, since that's what the TIFF API wants.
6362 (tiff_read_from_memory): Don't fail simply because the read would
6363 go past EOF; instead, return a short read.
6364 (tiff_load): Omit no-longer-needed casts.
6365 (Fimagemagick_types): Don't assume size fits into 'int'.
6367 Improve hashing quality when configured --with-wide-int.
6368 * fns.c (hash_string): New function, taken from sxhash_string.
6369 Do not discard information about ASCII character case; this
6370 discarding is no longer needed.
6371 (sxhash-string): Use it. Change sig to match it. Caller changed.
6372 * lisp.h: Declare it.
6373 * lread.c (hash_string): Remove, since we now use fns.c's version.
6374 The fns.c version returns a wider integer if --with-wide-int is
6375 specified, so this should help the quality of the hashing a bit.
6377 * emacs.c: Integer overflow minor fix.
6378 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6379 Define only if GNU_LINUX.
6380 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6382 * dispnew.c: Integer signedness and overflow fixes.
6383 Remove unnecessary forward decls, that were a maintenance hassle.
6384 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6386 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6387 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6388 (prepare_desired_row, line_draw_cost):
6389 Use int, not unsigned, where either works.
6390 (save_current_matrix, restore_current_matrix):
6391 Use ptrdiff_t, not size_t, where either works.
6392 (init_display): Check for overflow more accurately, and without
6393 relying on undefined behavior.
6395 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6396 Remove, replacing with the new symbols in lisp.h. All uses changed.
6397 * fileio.c (make_temp_name):
6398 * filelock.c (lock_file_1, lock_file):
6399 * xdisp.c (message_dolog):
6400 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6401 Use pMd etc. instead.
6402 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6403 replacing the pWIDE etc. symbols removed from editfns.c.
6405 * keyboard.h (num_input_events): Now uintmax_t.
6406 This is (very slightly) less likely to mess up due to wraparound.
6409 * buffer.c: Integer signedness fixes.
6410 (alloc_buffer_text, enlarge_buffer_text):
6411 Use ptrdiff_t rather than size_t when either will do, as we prefer
6414 * alloc.c: Integer signedness and overflow fixes.
6415 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6416 (__malloc_size_t): Default to size_t, not to int.
6417 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6418 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6419 Prefer ptrdiff_t to size_t when either would do, as we prefer
6421 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6422 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6423 Now const. Initialize with values that are in range even if char
6425 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6426 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6427 These functions do the right thing with sizes > 2**32.
6428 (check_depth): Now ptrdiff_t, not int.
6429 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6430 Adjust to new way of storing sizes. Check for size overflow bugs
6432 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6433 slightly wrong anyway, as it missed one instance of
6434 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6435 (refill_memory_reserve): Omit needless cast to size_t.
6436 (mark_object_loop_halt): Mark as externally visible.
6438 * xselect.c: Integer signedness and overflow fixes.
6439 (Fx_register_dnd_atom, x_handle_dnd_message):
6440 Use ptrdiff_t, not size_t, since we prefer signed.
6441 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6442 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6443 x_dnd_atoms_size and x_dnd_atoms_length.
6445 * doprnt.c: Prefer signed to unsigned when either works.
6447 * doprnt.c (doprnt):
6449 * xdisp.c (vmessage):
6450 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6451 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6452 prefer signed arithmetic to avoid comparison confusion.
6453 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6454 but is a bit tricky.
6456 Assume freestanding C89 headers, string.h, stdlib.h.
6457 * data.c, doprnt.c, floatfns.c, print.c:
6458 Include float.h unconditionally.
6459 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6460 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6461 * regex.c: Likewise for stddef.h, string.h.
6462 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6463 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6464 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6465 (STDC_HEADERS): Remove obsolete defines.
6466 * sysdep.c: Include limits.h unconditionally.
6468 Assume support for memcmp, memcpy, memmove, memset.
6469 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6470 * regex.c (memcmp, memcpy):
6471 Remove; we assume C89 now.
6473 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6474 (__malloc_safe_bcopy): Remove; no longer needed.
6476 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6477 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6478 well either way, and we prefer signed to unsigned.
6480 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6482 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6483 closes the connection while we're reading (bug#9182).
6485 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6487 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6488 are specified (Bug#9168).
6490 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6492 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6493 Found by GCC static checking and --with-wide-int on a 32-bit host.
6495 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6497 * xdisp.c (compute_display_string_pos): Fix logic of caching
6498 previous display string position. Initialize cached_prev_pos to
6499 -1. Fixes slow-down at the beginning of a buffer.
6501 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6503 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6504 for attrs[LFACE_FONTSET_INDEX].
6506 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6508 * xml.c (parse_region): Remove unused local
6509 that was recently introduced.
6511 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6513 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6514 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6516 * xdisp.c (move_it_in_display_line_to): Record the best matching
6517 position for TO_CHARPOS while scanning the line, and restore it on
6518 exit if none of the characters scanned was an exact match.
6519 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6520 when exact match is impossible due to invisible text, and the
6521 lines are truncated.
6523 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6525 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6528 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6530 Fix a significant slow-down of cursor motion with C-n, C-p,
6531 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6532 auto-repeat under bidi redisplay in fontified buffers.
6533 * xdisp.c (compute_stop_pos_backwards): New function.
6534 (next_element_from_buffer): Call compute_stop_pos_backwards to
6535 find a suitable prev_stop when we find ourselves before
6537 (reseat): Don't look for prev_stop, as that could mean a very long
6539 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6540 <cached_disp_overlay_modiff>: Cache for last found display string
6542 (compute_display_string_pos): Return the cached position if asked
6543 about the same buffer in the same area of character positions, and
6544 the buffer wasn't changed since the time the display string
6545 position was cached.
6547 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6549 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6550 is an integer, which is important for empty lines. (Bug#9149)
6552 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6554 * frame.c (Fmodify_frame_parameters): In tty case, update the
6555 default face if necessary (Bug#4238).
6557 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6559 * editfns.c (Fstring_to_char): No need to explain what a character
6560 is in the docstring (Bug#6576).
6562 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6564 * xml.c (parse_region): Make sure we always return a tree.
6566 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6568 * xml.c (parse_region): If a document contains only comments,
6571 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6573 * xml.c (make_dom): Return comments, too.
6575 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6578 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6579 and the surrounding thread.
6580 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6581 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6582 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6584 * s/openbsd.h (BROKEN_SIGIO): Define.
6585 * unexelf.c (unexec) [__OpenBSD__]:
6586 Don't update the .mdebug section of the Alpha COFF symbol table.
6588 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6590 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6593 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6595 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6596 This fixes some race conditions on the permissions of any newly
6599 * alloc.c (valid_pointer_p): Use pipe, not open.
6600 This fixes some permissions issues when debugging.
6602 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6603 If fchown fails to set both uid and gid, try to set just gid,
6604 as that is sometimes allowed. Adjust the file's mode to eliminate
6605 setuid or setgid bits that are inappropriate if fchown fails.
6607 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6609 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6610 to compare Lisp_Objects.
6611 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6612 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6613 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6615 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6617 * lread.c (read_integer): Unread even EOF character.
6618 (read1): Likewise. Properly record start position of symbol.
6620 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6621 symbol character follows.
6623 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6625 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6626 This works around a problem with the previous change to Fcopy_file.
6627 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6628 and without this change, GCC might complain about discarding
6629 fchown's return value.
6631 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6633 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6635 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6637 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6639 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6641 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6642 it's used from the C level.
6644 * process.c: Use the same condition for POLL_FOR_INPUT in both
6645 keyboard.c and process.c (bug#1858).
6647 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6649 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6650 (Fgnutls_boot): Use it.
6652 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6654 * doc.c (Fsubstitute_command_keys): Revert last change.
6656 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6658 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6659 quotes the next character, and doesn't affect other longer
6660 sequences (bug#8935).
6662 * lread.c (syms_of_lread): Clarify that is isn't only
6663 `eval-buffer' and `eval-defun' that's affected by
6664 `lexical-binding' (bug#8460).
6666 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6668 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6669 bidi redisplay when a line includes both an image and is truncated.
6671 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6673 Fix minor problems found by static checking.
6674 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6675 (elsz): Now a signed constant, not a size_t var. We prefer signed
6676 types to unsigned, to avoid integer comparison confusion. Without
6677 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6678 "cannot optimize loop, the loop counter may overflow", a symptom
6680 * indent.c (Fvertical_motion): Mark locals as initialized.
6681 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6683 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6685 * search.c (Fre_search_backward): Mention `case-fold-search' in
6686 all the re_search_* functions (bug#8138).
6688 * keyboard.c (Fopen_dribble_file): Document when the file is
6691 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6693 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6696 Support bidi reordering of display and overlay strings.
6697 * xdisp.c (compute_display_string_pos)
6698 (compute_display_string_end): Accept additional argument STRING.
6699 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6700 (reseat_to_string): Initialize bidi_it->string.s and
6701 bidi_it->string.schars.
6702 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6703 NULL (avoids a crash in bidi_paragraph_init).
6704 Initialize itb.string.lstring.
6705 (init_iterator): Call bidi_init_it only of a valid
6706 buffer position was specified. Initialize paragraph_embedding to
6708 (reseat_to_string): Initialize the bidi iterator.
6709 (display_string): If we need to ignore text properties of
6710 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6711 original value of -1 will not work with bidi.)
6712 (compute_display_string_pos): First arg is now struct
6713 `text_pos *'; all callers changed. Support display properties on
6715 (compute_display_string_end): Support display properties on Lisp
6717 (init_iterator, reseat_1, reseat_to_string): Initialize the
6718 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6719 when iterating on a string not from display properties).
6720 (compute_display_string_pos, compute_display_string_end):
6721 Fix calculation of the object to scan. Fixes an error when using
6723 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6724 base_level_stop; instead, set base_level_stop to BEGV.
6725 Fixes crashes in vertical-motion.
6726 (next_element_from_buffer): Improve commentary for when
6727 the iterator is before prev_stop.
6728 (init_iterator): Initialize bidi_p from the default value of
6729 bidi-display-reordering, not from buffer-local value. Use the
6730 buffer-local value only if initializing for buffer iteration.
6731 (handle_invisible_prop): Support invisible properties on strings
6732 that are being bidi-reordered.
6733 (set_iterator_to_next): Support bidi reordering of C strings and
6735 (next_element_from_string): Support bidi reordering of Lisp
6737 (handle_stop_backwards): Support Lisp strings as well.
6738 (display_string): Support display of R2L glyph rows.
6739 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6740 (init_iterator): Don't initialize it->bidi_p for strings
6742 (reseat_to_string): Initialize it->bidi_p for strings here.
6743 (next_element_from_string, next_element_from_c_string)
6744 (next_element_from_buffer): Add xassert's for correspondence
6745 between IT's object being iterated and it->bidi_it.string
6747 (face_before_or_after_it_pos): Support bidi iteration.
6748 (next_element_from_c_string): Handle the case of the first string
6749 character that is not the first one in the visual order.
6750 (get_visually_first_element): New function, refactored from common
6751 parts of next_element_from_buffer, next_element_from_string, and
6752 next_element_from_c_string.
6753 (tool_bar_lines_needed, redisplay_tool_bar)
6754 (display_menu_bar): Force left-to-right direction. Add a FIXME
6755 comment for making that be controlled by a user option.
6756 (push_it, pop_it): Save and restore the state of the
6757 bidi iterator. Save and restore the bidi_p flag.
6758 (pop_it): Iterate out of display property for string iteration as
6760 (iterate_out_of_display_property): Support iteration over strings.
6761 (handle_single_display_spec): Set up it->bidi_it for iteration
6762 over a display string, and call bidi_init_it.
6763 (handle_single_display_spec, next_overlay_string)
6764 (get_overlay_strings_1, push_display_prop): Set up the bidi
6765 iterator for displaying display or overlay strings.
6766 (forward_to_next_line_start): Don't use the shortcut if
6768 (back_to_previous_visible_line_start): If handle_display_prop
6769 pushed the iterator stack, restore the internal state of the bidi
6770 iterator by calling bidi_pop_it same number of times.
6771 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6772 and we are bidi-iterating, don't decrement the iterator position;
6773 instead, set the first_elt flag in the bidi iterator, to produce
6775 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6776 (push_display_prop): xassert that we are iterating a buffer.
6777 (push_it, pop_it): Save and restore paragraph_embedding member.
6778 (handle_single_display_spec, next_overlay_string)
6779 (get_overlay_strings_1, reseat_1, reseat_to_string)
6780 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6781 correctly. Don't assume unibyte strings are not bidi-reordered.
6782 (compute_display_string_pos)
6783 (compute_display_string_end): Fix handling the case of C string.
6784 (push_it, pop_it): Save and restore from_disp_prop_p.
6785 (handle_single_display_spec, push_display_prop): Set the
6786 from_disp_prop_p flag.
6787 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6788 (pop_it): Call iterate_out_of_display_property only if we are
6789 popping after iteration over a string that came from a display
6790 property. Fix a typo in popping stretch info. Add an assertion
6791 for verifying that the iterator position is in sync with the bidi
6793 (handle_single_display_spec, get_overlay_strings_1)
6794 (push_display_prop): Fix initialization of paragraph direction for
6795 string when that of the parent object is not yet determined.
6796 (reseat_1): Call bidi_init_it to resync the bidi
6797 iterator with IT's position. (Bug#7616)
6798 (find_row_edges): If ROW->start.pos gives position
6799 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6800 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6801 Reset the from_disp_prop_p flag.
6802 (SAVE_IT, RESTORE_IT): New macros.
6803 (pos_visible_p, face_before_or_after_it_pos)
6804 (back_to_previous_visible_line_start)
6805 (move_it_in_display_line_to, move_it_in_display_line)
6806 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6807 (try_scrolling, redisplay_window, display_line): Use them when
6808 saving a temporary copy of the iterator and restoring it back.
6809 (back_to_previous_visible_line_start, reseat_1)
6810 (init_iterator): Empty the bidi cache "stack".
6811 (move_it_in_display_line_to): If iterator ended up at
6812 EOL, but we never saw any buffer positions smaller than
6813 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6814 motion in bidi-reordered lines.
6815 (move_it_in_display_line_to): Record prev_method and prev_pos
6816 immediately before the call to set_iterator_to_next. Fixes cursor
6817 motion in bidi-reordered lines with stretch glyphs and strings
6818 displayed in margins. (Bug#8133) (Bug#8867)
6819 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6821 (pos_visible_p): Support positions in bidi-reordered lines.
6822 Save and restore bidi cache.
6824 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6825 (bidi_paragraph_info): Delete unused struct.
6826 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6827 (bidi_cache_start): New variable.
6828 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6830 (bidi_cache_fetch_state, bidi_cache_search)
6831 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6832 (bidi_cache_find, bidi_peek_at_next_level)
6833 (bidi_level_of_next_char, bidi_find_other_level_edge)
6834 (bidi_move_to_visually_next): Compare cache index with
6835 bidi_cache_start rather than with zero.
6836 (bidi_fetch_char): Accept new argument STRING; all callers
6837 changed. Support iteration over a string. Support strings with
6838 display properties. Support unibyte strings. Fix the type of
6839 `len' according to what STRING_CHAR_AND_LENGTH expects.
6840 (bidi_paragraph_init, bidi_resolve_explicit_1)
6841 (bidi_resolve_explicit, bidi_resolve_weak)
6842 (bidi_level_of_next_char, bidi_move_to_visually_next):
6843 Support iteration over a string.
6844 (bidi_set_sor_type, bidi_resolve_explicit_1)
6845 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6846 can now be zero (for strings); special values 0 and -1 were
6847 changed to -1 and -2, respectively.
6848 (bidi_char_at_pos): New function.
6849 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6850 Call it instead of FETCH_MULTIBYTE_CHAR.
6851 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6852 initialized to valid values.
6853 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6855 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6856 the test for valid cached positions. Fix the logic for looking up
6857 the sentinel state in the cache. GCPRO the Lisp string we are
6859 (bidi_push_it, bidi_pop_it): New functions.
6860 (bidi_initialize): Initialize the bidi cache start stack pointer.
6861 (bidi_cache_ensure_space): New function, refactored from part of
6862 bidi_cache_iterator_state. Don't assume the required size is just
6863 one BIDI_CACHE_CHUNK away.
6864 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6865 (bidi_count_bytes, bidi_char_at_pos): New functions.
6866 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6867 always valid if bidi_cache_idx is valid.
6868 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6869 is valid if it's going to be used.
6870 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6871 (bidi_cache_fetch_state, bidi_cache_search)
6872 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6873 (bidi_cache_iterator_state, bidi_cache_find)
6874 (bidi_find_other_level_edge, bidi_cache_start_stack):
6875 All variables related to cache indices are now EMACS_INT.
6877 * dispextern.h (struct bidi_string_data): New structure.
6878 (struct bidi_it): New member `string'. Make flag members be 1-bit
6879 fields, and put them last in the struct.
6880 (compute_display_string_pos, compute_display_string_end):
6882 (bidi_push_it, bidi_pop_it): Add prototypes.
6883 (struct iterator_stack_entry): New members bidi_p,
6884 paragraph_embedding, and from_disp_prop_p.
6885 (struct it): Member bidi_p is now a bit field 1 bit wide.
6886 (bidi_shelve_cache, bidi_unshelve_cache):
6889 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6890 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6891 and vector-like objects.
6893 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6894 cache around display iteration.
6896 * window.c (Fwindow_end, window_scroll_pixel_based)
6897 (displayed_window_lines, Frecenter): Save and restore the bidi
6898 cache around display iteration.
6900 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6902 * editfns.c (Fdelete_region): Clarify the use of the named
6903 parameters (bug#6788).
6905 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6907 * indent.c (Fvertical_motion): Set and restore w->pointm when
6908 saving and restoring the window's buffer (Bug#9006).
6910 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6912 * editfns.c (Fstring_to_char): Clarify just what is returned
6913 (bug#6576). Text by Eli Zaretskii.
6915 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6917 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6919 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6921 * buffer.c (mmap_find): Fix a typo.
6923 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6925 Fix execution of x selection hooks.
6926 * xselect.c (Qx_lost_selection_functions)
6927 (Qx_sent_selection_functions): New vars.
6928 (syms_of_xselect): DEFSYM them.
6929 (x_handle_selection_request): Pass Qx_sent_selection_functions
6930 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6931 (x_handle_selection_clear,x_clear_frame_selections):
6932 Pass Qx_lost_selection_functions rather than
6933 Vx_lost_selection_functions to Frun_hook_with_args.
6935 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6937 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6938 The old code sometimes used this field without initializing it.
6940 * alloc.c (gc_sweep): Don't read past end of array.
6941 In theory, the old code could also have corrupted Emacs internals,
6942 though it'd be very unlikely.
6944 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6946 * character.c (Fcharacterp): Don't advertise optional ignored
6947 argument. (Bug#4026)
6949 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6951 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6954 * window.c (Fset_window_start): Doc fix (bug#4199).
6955 (Fset_window_hscroll): Ditto.
6957 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6959 Fix minor new problems caught by GCC 4.6.1.
6960 * term.c (init_tty): Remove unused local.
6961 * xsettings.c (store_monospaced_changed): Define this function only
6962 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6965 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6967 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6969 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6971 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6972 are the mini-buffer and the echo area (bug#3320).
6974 * term.c (init_tty): Remove support for supdup, c10 and perq
6975 terminals, which are no longer supported (bug#1482).
6977 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6979 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6981 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6983 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6984 for non-popups (Bug#3642).
6986 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6988 * alloc.c (reset_malloc_hooks): Protoize.
6989 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6990 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6991 * cm.c (losecursor): Likewise.
6992 * data.c (fmod): Likewise.
6993 * dispnew.c (swap_glyphs_in_rows): Likewise.
6994 * emacs.c (memory_warning_signal): Likewise.
6995 * floatfns.c (float_error): Likewise.
6996 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6997 (otf_open, font_otf_capability, generate_otf_features)
6998 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7000 * image.c (pbm_read_file): Likewise.
7001 * indent.c (string_display_width): Likewise.
7002 * intervals.c (check_for_interval, search_for_interval)
7003 (inc_interval_count, count_intervals, root_interval)
7004 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7005 * lread.c (defalias): Likewise.
7006 * ralloc.c (r_alloc_check): Likewise.
7007 * regex.c (set_image_of_range_1, set_image_of_range)
7008 (regex_grow_registers): Likewise.
7009 * sysdep.c (strerror): Likewise.
7010 * termcap.c (valid_filename_p, tprint, main): Likewise.
7011 * tparam.c (main): Likewise.
7012 * unexhp9k800.c (run_time_remap, save_data_space)
7013 (update_file_ptrs, read_header, write_header, calculate_checksum)
7014 (copy_file, copy_rest, display_header): Likewise.
7015 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7017 * xdisp.c (check_it): Likewise.
7018 * xfaces.c (register_color, unregister_color, unregister_colors):
7020 * xfns.c (print_fontset_result): Likewise.
7021 * xrdb.c (member, fatal, main): Likewise.
7023 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7025 Fix minor problems found by static checking (Bug#9031).
7026 * chartab.c (char_table_set_range, map_sub_char_table):
7027 Remove unused locals.
7028 (uniprop_table): Now static.
7029 * composite.c (_work_char): Remove unused static var.
7031 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7033 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7035 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7037 * gtkutil.c (qttip_cb): Remove code without function.
7039 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7041 * w32.c (pthread_sigmask): New stub.
7043 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7045 Use pthread_sigmask, not sigprocmask (Bug#9010).
7046 sigprocmask is portable only for single-threaded applications, and
7047 Emacs can be multi-threaded when it uses GTK.
7048 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7050 * callproc.c (Fcall_process):
7051 * process.c (create_process):
7052 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7053 Use pthread_sigmask, not sigprocmask.
7055 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7057 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7058 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7061 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7063 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7064 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7065 (xg_hide_tooltip): Fix comment.
7067 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7068 in registerServicesMenuSendTypes.
7069 (validRequestorForSendType): Don't check ns_return_types.
7071 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7074 2011-07-08 Jason Rumney <jasonr@gnu.org>
7076 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7077 SH_SHOW for hidden windows (Bug#5482).
7079 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7080 frame struct members of non-existent frames (Bug#6284).
7082 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7084 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7085 variable firstTime not needed on OSX >= 10.6.
7086 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7087 >= 10.5. Use setKnobProportion, setDoubleValue.
7089 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7090 (MAC_OS_X_VERSION_10_5): Define if not defined.
7091 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7092 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7093 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7095 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7096 cString and lossyCString on OSX >= 10.4
7098 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7099 sizeToFit on OSX >= 10.2.
7101 * nsimage.m (allocInitFromFile): Don't use deprecated method
7102 bestRepresentationForDevice on OSX >= 10.6.
7104 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7107 * emacs.c: Declare unexec_init_emacs_zone.
7109 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7111 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7113 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7114 on svcsMenu (Bug#8842).
7116 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7118 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7120 * nsterm.m (QUTF8_STRING): Declare.
7121 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7122 (validRequestorForSendType): Return type is (id).
7123 Change indexOfObjectIdenticalTo to indexOfObject.
7124 Check if we have local selection before returning self (Bug#8842).
7125 (writeSelectionToPasteboard): Put local selection into paste board
7126 if we have a local selection (Bug#8842).
7127 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7129 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7130 (ns_get_local_selection): Declare.
7132 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7134 * keymap.c (describe_map_tree): Don't insert a double newline at
7135 the end of the buffer (bug#1169) and return whether we inserted
7138 * callint.c (Fcall_interactively): Change "reading args" to
7139 "providing args" to try to clarify what it does (bug#1010).
7141 2011-07-07 Kenichi Handa <handa@m17n.org>
7143 * composite.c (composition_compute_stop_pos): Ignore a static
7144 composition starting before CHARPOS (Bug#8915).
7146 * xdisp.c (handle_composition_prop): Likewise.
7148 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7150 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7153 2011-07-07 Kenichi Handa <handa@m17n.org>
7155 * character.h (unicode_category_t): New enum type.
7157 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7158 (Qchar_code_property_table): New variable.
7159 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7160 (UNIPROP_COMPRESSED_FORM_P): New macros.
7161 (char_table_ascii): Uncompress the compressed values.
7162 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7163 Uncompress the compressed values.
7164 (sub_char_table_ref_and_range): Likewise.
7165 (char_table_ref_and_range): Uncompress the compressed values.
7166 (sub_char_table_set): New arg is_uniprop. Callers changed.
7167 Uncompress the compressed values.
7168 (sub_char_table_set_range): Args changed. Callers changed.
7169 (char_table_set_range): Adjuted for the above change.
7170 (map_sub_char_table): Delete args default_val and parent. Add arg
7171 top. Give decoded values to a Lisp function.
7172 (map_char_table): Adjust for the above change. Give decoded
7173 values to a Lisp function. Gcpro more variables.
7174 (uniprop_table_uncompress)
7175 (uniprop_decode_value_run_length): New functions.
7176 (uniprop_decoder, uniprop_decoder_count): New variables.
7177 (uniprop_get_decoder, uniprop_encode_value_character)
7178 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7180 (uniprop_encoder, uniprop_encoder_count): New variables.
7181 (uniprop_get_encoder, uniprop_table)
7182 (Funicode_property_table_internal, Fget_unicode_property_internal)
7183 (Fput_unicode_property_internal): New functions.
7184 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7185 Sunicode_property_table_internal, Sget_unicode_property_internal,
7186 and Sput_unicode_property_internal. Defvar_lisp
7187 char-code-property-alist.
7189 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7190 Vunicode_category_table.
7192 * font.c (font_range): Adjust for the change of
7193 Vunicode_category_table.
7195 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7197 * m/iris4d.h: Remove file, move contents ...
7198 * s/irix6-5.h: ... here.
7200 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7202 Remove unportable assumption about struct layout (Bug#8884).
7203 * alloc.c (mark_buffer):
7204 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7205 (clone_per_buffer_values): Don't assume that
7206 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7207 This isn't true in general, and it's particularly not true
7208 if Emacs is configured with --with-wide-int.
7209 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7210 New macros, used in the buffer.c change.
7212 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7214 * xsettings.c: Use both GConf and GSettings if both are available.
7215 (store_config_changed_event): Add comment.
7216 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7217 (store_tool_bar_style_changed): New functions.
7218 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7219 (struct xsettings): Move font inside HAVE_XFT.
7220 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7221 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7222 Move inside HAVE_XFT.
7223 (something_changed_gsettingsCB): Rename from something_changedCB.
7224 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7226 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7227 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7228 (something_changed_gconfCB): Rename from something_changedCB.
7229 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7230 (parse_settings): Move check for font inside HAVE_XFT.
7231 (read_settings, apply_xft_settings): Add comment.
7232 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7233 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7234 call store_font_name_changed.
7235 (xft_settings_event): Add comment.
7236 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7237 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7238 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7239 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7240 (xsettings_initialize): Call init_gsettings last.
7241 (xsettings_get_system_font, xsettings_get_system_normal_font):
7244 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7246 Random fixes. E.g., (random) never returned negative values.
7247 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7248 subseconds part to the entropy, as that's a bit more random.
7249 Prefer signed to unsigned, since the signedness doesn't matter and
7250 in general we prefer signed. When given a limit, use a
7251 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7252 latter isn't right if USE_2_TAGS_FOR_INTS.
7253 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7254 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7256 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7258 * textprop.c (text_property_stickiness):
7259 Obey Vtext_property_default_nonsticky.
7260 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7261 * w32fns.c (syms_of_w32fns):
7262 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7264 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7266 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7267 This is more efficient than Ffile_directory_p and avoids a minor race.
7269 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7271 * buffer.c (Foverlay_put): Say what the return value is
7274 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7275 is a directory before asking whether to use the file name
7277 (barf_or_query_if_file_exists): Make the "File is a directory"
7278 error be more correct.
7280 * fns.c (Frequire): Remove the mention of the .gz files, since
7281 that's installation-specific, but keep the mention of
7282 `get-load-suffixes'.
7284 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7286 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7287 Report string overflow if the output is too long.
7289 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7291 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7292 (syms_of_gnutls): Remove duplicate DEFSYM for
7293 Qgnutls_bootprop_verify_hostname_error, an error for
7294 Qgnutls_bootprop_verify_error (which is no longer used).
7296 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7297 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7298 Also (re)move comments that are misplaced or no longer relevant.
7300 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7302 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7304 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7306 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7307 and background color parameters if they have been changed.
7309 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7311 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7313 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7315 * xsettings.c (SYSTEM_FONT): Define only when used.
7316 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7318 * keymap.c (access_keymap_1): Now static.
7320 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7322 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7323 leave any prefix arg for the up event (Bug#1586).
7325 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7327 * lread.c (syms_of_lread): Mention single symbols defined by
7328 `defvar' or `defconst' (bug#7154).
7330 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7331 (Frequire): Mention get-load-suffixes.
7333 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7335 * window.h (window): Remove clone_number slot.
7336 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7338 (make_parent_window, make_window, saved_window)
7339 (Fset_window_configuration, save_window_save): Don't deal with
7341 * buffer.c (Qclone_number): Remove declaration.
7342 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7344 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7346 Add multiple inheritance to keymaps.
7347 * keymap.c (Fmake_composed_keymap): New function.
7348 (Fset_keymap_parent): Simplify.
7349 (fix_submap_inheritance): Remove.
7350 (access_keymap_1): New function extracted from access_keymap to handle
7351 embedded parents and handle lists of maps.
7352 (access_keymap): Use it.
7353 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7354 (Fcopy_keymap): Handle embedded parents.
7355 (Fcommand_remapping, define_as_prefix): Simplify.
7356 (Fkey_binding): Simplify.
7357 (syms_of_keymap): Move minibuffer-local-completion-map,
7358 minibuffer-local-filename-completion-map,
7359 minibuffer-local-must-match-map, and
7360 minibuffer-local-filename-must-match-map to Elisp.
7361 (syms_of_keymap): Defsubr make-composed-keymap.
7362 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7363 (parse_menu_item): Trivial simplification.
7365 2011-07-01 Glenn Morris <rgm@gnu.org>
7367 * Makefile.in (SETTINGS_LIBS): Fix typo.
7369 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7371 * coding.c (Fencode_coding_string): Record the last coding system
7372 used, as the function doc string says (bug#8738).
7374 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7376 * xsettings.c (store_monospaced_changed): Take new font as arg and
7377 check for change against current_mono_font.
7378 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7379 (emacs_settings_constructor, emacs_settings_get_property)
7380 (emacs_settings_set_property, emacs_settings_class_init)
7381 (emacs_settings_init, gsettings_obj): Remove.
7382 (something_changedCB): New function for HAVE_GSETTINGS.
7383 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7384 with value as argument.
7385 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7386 g_settings_new (Bug#8967). Do not create gsettings_obj.
7387 Remove calls to g_settings_bind. Connect something_changedCB to
7390 * xgselect.c: Add defined (HAVE_GSETTINGS).
7391 (xgselect_initialize): Ditto.
7393 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7394 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7397 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7399 * eval.c (struct backtrace): Simplify and port the data structure.
7400 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7401 signed bit field, as this assumption is not portable and it makes
7402 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7403 "char debug_on_exit : 1" as this is not portable either; instead,
7404 use the portable "unsigned int debug_on_exit : 1". Remove unused
7405 member evalargs. Remove obsolete comments about cc bombing out.
7407 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7409 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7410 Let HAVE_GSETTINGS override HAVE_GCONF.
7411 (store_monospaced_changed): New function.
7412 (EMACS_SETTINGS): A new type derived from GObject to handle
7413 GSettings notifications.
7414 (emacs_settings_constructor, emacs_settings_get_property)
7415 (emacs_settings_set_property, emacs_settings_class_init):
7417 (gsettings_client, gsettings_obj): New variables.
7418 (GSETTINGS_SCHEMA): New define.
7419 (something_changedCB): Call store_monospaced_changed.
7420 (init_gsettings): New function.
7421 (xsettings_initialize): Call init_gsettings.
7422 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7425 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7428 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7430 * window.c (resize_root_window, grow_mini_window)
7431 (shrink_mini_window): Rename Qresize_root_window to
7432 Qwindow_resize_root_window and Qresize_root_window_vertically to
7433 Qwindow_resize_root_window_vertically.
7435 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7437 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7439 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7441 * makefile.w32-in: Redesign dependencies so they reflect more
7442 clearly which files are directly included by each source file,
7443 and not through other includes.
7445 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7447 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7448 (sort_overlays, overlay_strings): When an overlay's clone number
7449 matches the window's clone number process the overlay even if
7450 the overlay's window property doesn't match the current window.
7452 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7453 (Fwindow_hchild): Rename to Fwindow_left_child.
7454 (Fwindow_next): Rename to Fwindow_next_sibling.
7455 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7456 (resize_window_check): Rename to window_resize_check.
7457 (resize_window_apply): Rename to window_resize_apply.
7458 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7459 (Fdelete_other_windows_internal, resize_frame_windows)
7460 (Fsplit_window_internal, Fdelete_window_internal)
7461 (grow_mini_window, shrink_mini_window)
7462 (Fresize_mini_window_internal): Fix callers accordingly.
7464 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7466 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7467 (emacs_fixed_set_min_size): Remove.
7468 (emacs_fixed_new): Take frame as argument.
7470 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7471 (_EmacsFixedPrivate): Remove minwidth/height.
7472 Add struct frame *f.
7473 (emacs_fixed_init): Initialize priv->f.
7474 (get_parent_class, emacs_fixed_set_min_size): Remove.
7475 (emacs_fixed_new): Set priv->f to argument.
7476 (emacs_fixed_get_preferred_width)
7477 (emacs_fixed_get_preferred_height): Use min_width/height from
7478 frames size_hint to set minimum and natural (Bug#8919).
7479 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7480 and use min_width/height from frames size_hint to set
7481 min_width/height (Bug#8919).
7483 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7484 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7487 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7489 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7490 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7493 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7495 * process.c (wait_reading_process_output): Bypass select if
7496 waiting for a cell while ignoring keyboard input, and input is
7497 pending. Suggested by Jan Djärv (Bug#8869).
7499 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7501 Use gnulib's dup2 module instead of rolling our own.
7502 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7504 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7506 * dispnew.c (scrolling_window): Before scrolling, turn off a
7507 mouse-highlight in the window being scrolled.
7509 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7511 Move DEFSYM to lisp.h and use everywhere.
7513 * character.h (DEFSYM): Move declaration...
7514 * lisp.h (DEFSYM): ...here.
7520 * w32select.c: Don't include character.h.
7522 * alloc.c (syms_of_alloc):
7523 * buffer.c (syms_of_buffer):
7524 * bytecode.c (syms_of_bytecode):
7525 * callint.c (syms_of_callint):
7526 * casefiddle.c (syms_of_casefiddle):
7527 * casetab.c (init_casetab_once):
7528 * category.c (init_category_once, syms_of_category):
7529 * ccl.c (syms_of_ccl):
7530 * cmds.c (syms_of_cmds):
7531 * composite.c (syms_of_composite):
7532 * dbusbind.c (syms_of_dbusbind):
7533 * dired.c (syms_of_dired):
7534 * dispnew.c (syms_of_display):
7535 * doc.c (syms_of_doc):
7536 * editfns.c (syms_of_editfns):
7537 * emacs.c (syms_of_emacs):
7538 * eval.c (syms_of_eval):
7539 * fileio.c (syms_of_fileio):
7540 * fns.c (syms_of_fns):
7541 * frame.c (syms_of_frame):
7542 * fringe.c (syms_of_fringe):
7543 * insdel.c (syms_of_insdel):
7544 * keymap.c (syms_of_keymap):
7545 * lread.c (init_obarray, syms_of_lread):
7546 * macros.c (syms_of_macros):
7547 * msdos.c (syms_of_msdos):
7548 * print.c (syms_of_print):
7549 * process.c (syms_of_process):
7550 * search.c (syms_of_search):
7551 * sound.c (syms_of_sound):
7552 * syntax.c (init_syntax_once, syms_of_syntax):
7553 * terminal.c (syms_of_terminal):
7554 * textprop.c (syms_of_textprop):
7555 * undo.c (syms_of_undo):
7556 * w32.c (globals_of_w32):
7557 * window.c (syms_of_window):
7558 * xdisp.c (syms_of_xdisp):
7559 * xfaces.c (syms_of_xfaces):
7560 * xfns.c (syms_of_xfns):
7561 * xmenu.c (syms_of_xmenu):
7562 * xsettings.c (syms_of_xsettings):
7563 * xterm.c (syms_of_xterm): Use DEFSYM.
7565 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7567 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7569 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7571 Integer and buffer overflow fixes (Bug#8873).
7573 * print.c (printchar, strout): Check for string overflow.
7574 (PRINTPREPARE, printchar, strout):
7575 Don't set size unless allocation succeeds.
7577 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7578 for sizes. Check for string overflow more accurately.
7579 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7581 * macros.c: Integer and buffer overflow fixes.
7582 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7583 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7584 Use ptrdiff_t, not int, for sizes.
7585 Don't increment bufsize until after realloc succeeds.
7586 Check for size-calculation overflow.
7587 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7589 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7591 * lread.c: Integer overflow fixes.
7592 (read_integer): Radix is now EMACS_INT, not int,
7593 to improve quality of diagnostics for out-of-range radices.
7594 Calculate buffer size correctly for out-of-range radices.
7595 (read1): Check for integer overflow in radices, and in
7596 read-circle numbers.
7597 (read_escape): Avoid int overflow.
7598 (Fload, openp, read_buffer_size, read1)
7599 (substitute_object_recurse, read_vector, read_list, map_obarray):
7600 Use ptrdiff_t, not int, for sizes.
7601 (read1): Use EMACS_INT, not int, for sizes.
7602 Check for size overflow.
7604 * image.c (cache_image): Check for size arithmetic overflow.
7606 * lread.c: Integer overflow issues.
7607 (saved_doc_string_size, saved_doc_string_length)
7608 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7609 Now ptrdiff_t, not int.
7610 (read1): Don't assume doc string length fits in int. Check for
7611 out-of-range doc string lengths.
7612 (read_list): Don't assume file position fits in int.
7613 (read_escape): Check for hex character overflow.
7615 2011-06-22 Leo Liu <sdl.web@gmail.com>
7617 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7618 Move to minibuffer.el.
7620 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7622 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7623 The following patches are for when GLYPH_DEBUG && !XASSERT.
7624 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7625 * dispnew.c (flush_stdout):
7626 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7627 Mark as externally visible.
7628 * dispnew.c (check_window_matrix_pointers): Now static.
7629 * dispnew.c (window_to_frame_vpos):
7630 * xfns.c (unwind_create_frame):
7631 * xterm.c (x_check_font): Remove unused local.
7632 * scroll.c (CHECK_BOUNDS):
7633 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7634 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7635 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7636 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7637 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7639 (debug_method_add): Use va_list and vsprintf rather than relying
7640 on undefined behavior with wrong number of arguments.
7641 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7642 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7643 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7644 since we're not interested in debugging glyphs with old libraries.
7645 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7646 GCC 4.6.0's static checking.
7648 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7650 Integer overflow and signedness fixes (Bug#8873).
7651 A few related buffer overrun fixes, too.
7653 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7655 * dispextern.h (struct face.stipple):
7656 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7657 (x_bitmap_mask, x_allocate_bitmap_record)
7658 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7659 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7660 (x_create_bitmap_from_xpm_data):
7661 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7662 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7664 * xfaces.c (load_pixmap):
7665 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7666 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7667 (.bitmaps_last, struct x_output.icon_bitmap):
7668 Use ptrdiff_t, not int, for bitmap indexes.
7669 (x_allocate_bitmap_record): Check for size overflow.
7670 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7672 Use ptrdiff_t, not int, for overlay counts.
7673 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7674 * editfns.c (overlays_around, get_pos_property):
7675 * textprop.c (get_char_property_and_overlay):
7676 * xdisp.c (next_overlay_change, note_mouse_highlight):
7677 * xfaces.c (face_at_buffer_position):
7678 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7679 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7680 (Fnext_overlay_change, Fprevious_overlay_change)
7681 (mouse_face_overlay_overlaps, Foverlays_in):
7682 Use ptrdiff_t, not int, for sizes.
7683 (overlays_at, overlays_in): Check for size-calculation overflow.
7685 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7687 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7688 (x_session_initialize): Do not assume string length fits in int.
7690 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7691 This is unlikely, but can occur if DPI is outlandish.
7693 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7694 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7696 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7697 * xrdb.c (magic_file_p, search_magic_path):
7698 Omit last arg SUFFIX; it was always 0. All callers changed.
7699 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7701 * xfont.c (xfont_match): Avoid need for strlen.
7703 * xfns.c: Don't assume strlen fits in int.
7704 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7706 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7707 not unsigned long, as we prefer signed integers. All callers changed.
7708 Detect integer overflow in repeat count.
7709 (message_dolog): Don't assume print length fits in 39 bytes.
7710 (display_mode_element): Don't assume strlen fits in int.
7712 * termcap.c: Don't assume sizes fit in int and never overflow.
7713 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7714 (gobble_line): Check for size-calculation overflow.
7716 * minibuf.c (Fread_buffer):
7717 * lread.c (intern, intern_c_string):
7718 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7719 Don't assume string length fits in int.
7721 * keyboard.c (parse_tool_bar_item):
7722 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7724 * font.c: Don't assume string length fits in int.
7725 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7726 Use ptrdiff_t, not int.
7727 (font_intern_prop): Don't assume string length fits in int.
7728 Don't assume integer property fits in fixnum.
7729 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7731 * filelock.c: Fix some buffer overrun and integer overflow issues.
7732 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7733 Reformulate so as not to need the command string.
7734 Invoke gzip -cd rather than gunzip, as it's more portable.
7735 (lock_info_type, lock_file_1, lock_file):
7736 Don't assume pid_t and time_t fit in unsigned long.
7737 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7738 (current_lock_owner): Prefer signed type for sizes.
7739 Use memcpy, not strncpy, where memcpy is what is really wanted.
7740 Don't assume (via atoi) that time_t and pid_t fit in int.
7741 Check for time_t and/or pid_t out of range, e.g., via a network share.
7742 Don't alloca where an auto var works fine.
7744 * fileio.c: Fix some integer overflow issues.
7745 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7746 Don't assume string length fits in int.
7747 (directory_file_name): Don't assume string length fits in long.
7748 (make_temp_name): Don't assume pid fits in int, or that its print
7749 length is less than 20.
7751 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7753 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7755 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7757 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7758 We prefer signed integers, even for size calculations.
7760 * emacs.c: Don't assume string length fits in 'int'.
7761 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7762 (main): Don't invoke strlen when not needed.
7764 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7765 (XD_DEBUG_MESSAGE): Don't waste a byte.
7767 * callproc.c (getenv_internal_1, getenv_internal)
7769 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7771 * lread.c (invalid_syntax): Omit length argument.
7772 All uses changed. This doesn't fix a bug, but it simplifies the
7773 code away from its former Hollerith-constant appearance, and it's
7774 one less 'int' to worry about when looking at integer-overflow issues.
7775 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7777 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7778 This didn't break anything, but it didn't help either.
7779 It's confusing to put a bogus integer in a place where the actual
7780 value does not matter.
7781 (LIST_END_P): Remove unused macro and its bogus comment.
7782 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7784 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7785 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7787 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7788 We prefer signed types, and the value cannot exceed the EMACS_INT
7789 range anyway (because otherwise the length would not be representable).
7790 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7791 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7792 This avoids a GCC warning when WIDE_EMACS_INT.
7794 * indent.c (sane_tab_width): New function.
7795 (current_column, scan_for_column, Findent_to, position_indentation)
7796 (compute_motion): Use it. This is just for clarity.
7797 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7799 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7801 * lisp.h (lint_assume): New macro.
7802 * composite.c (composition_gstring_put_cache):
7803 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7805 * editfns.c, insdel.c:
7806 Omit unnecessary forward decls, to simplify future changes.
7808 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7810 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7812 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7813 Use much-faster test for byte-length change.
7814 Don't assume string byte-length fits in 'int'.
7815 Check that character arg fits in 'int'.
7816 (mapcar1): Declare byte as byte, for clarity.
7818 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7820 * fns.c (concat): Catch string overflow earlier.
7821 Do not rely on integer wraparound.
7823 * dispextern.h (struct it.overlay_strings_charpos)
7824 (struct it.selective): Now EMACS_INT, not int.
7825 * xdisp.c (forward_to_next_line_start)
7826 (back_to_previous_visible_line_start)
7827 (reseat_at_next_visible_line_start, next_element_from_buffer):
7828 Don't arbitrarily truncate the value of 'selective' to int.
7830 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7832 * composite.c: Don't truncate sizes to 'int'.
7833 (composition_gstring_p, composition_reseat_it)
7834 (composition_adjust_point): Use EMACS_INT, not int.
7835 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7836 not EMACS_UINT, for indexes.
7838 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7840 * buffer.c: Include <verify.h>.
7841 (struct sortvec.priority, struct sortstr.priority):
7842 Now EMACS_INT, not int.
7843 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7844 (struct sortstr.size, record_overlay_string)
7845 (struct sortstrlist.size, struct sortlist.used):
7846 Don't truncate size to int.
7847 (record_overlay_string): Check for size-calculation overflow.
7848 (init_buffer_once): Check at compile-time, not run-time.
7850 2011-06-22 Jim Meyering <meyering@redhat.com>
7852 Don't leak an XBM-image-sized buffer
7853 * image.c (xbm_load): Free the image buffer after using it.
7855 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7858 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7859 that Sun C diagnosed.
7860 * fns.c (secure_hash): Fix pointer signedness issue.
7861 * intervals.c (static_offset_intervals): New function.
7862 (offset_intervals): Use it.
7864 2011-06-21 Leo Liu <sdl.web@gmail.com>
7867 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7870 * fns.c (secure_hash): Rename from crypto_hash_function and change
7871 the first arg to accept symbols.
7872 (Fsecure_hash): New primitive.
7873 (syms_of_fns): New symbols.
7875 2011-06-20 Deniz Dogan <deniz@dogan.se>
7877 * process.c (Fset_process_buffer): Clarify return value in
7880 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7882 * dispnew.c (add_window_display_history): Use BVAR.
7884 * xdisp.c (debug_method_add): Use BVAR.
7885 (check_window_end, dump_glyph_matrix, dump_glyph)
7886 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7888 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7891 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7892 check till after the cache is created in init_frame_faces.
7894 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7896 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7898 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7900 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7901 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7902 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7904 Improve buffer-overflow checking (Bug#8873).
7905 * fileio.c (Finsert_file_contents):
7906 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7907 Remove the old (too-loose) buffer overflow checks.
7908 They weren't needed, since make_gap checks for buffer overflow.
7909 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7910 The old code merely checked for Emacs fixnum overflow, and relied
7911 on undefined (wraparound) behavior. The new code avoids undefined
7912 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7914 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7915 Tune. Don't use wider integers than needed. Don't use alloca.
7916 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7918 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7920 * insdel.c, lisp.h (buffer_overflow): New function.
7921 (insert_from_buffer_1, replace_range, replace_range_2):
7922 * insdel.c (make_gap_larger):
7923 * editfns.c (Finsert_char):
7924 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7926 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7928 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7930 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7932 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7933 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7935 * fileio.c: Don't assume EMACS_INT fits in off_t.
7936 (emacs_lseek): New static function.
7937 (Finsert_file_contents, Fwrite_region): Use it.
7938 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7940 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7942 * fns.c: Don't overflow int when computing a list length.
7943 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7944 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7945 truncation on 64-bit hosts. Check for QUIT every
7946 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7947 faster and is responsive enough.
7948 (Flength): Report an error instead of overflowing an integer.
7949 (Fsafe_length): Return a float if the value is not representable
7950 as a fixnum. This shouldn't happen except in contrived situations.
7951 (Fnthcdr, Fsort): Don't assume list length fits in int.
7952 (Fcopy_sequence): Don't assume vector length fits in int.
7954 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7955 (header_size, word_size): New constants.
7956 (allocate_vectorlike): Don't check size overflow here.
7957 (allocate_vector): Check it here instead, since this is the only
7958 caller of allocate_vectorlike that could cause overflow.
7959 Check that the new vector's length is representable as a fixnum.
7961 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7962 The previous code was bogus. For example, next_almost_prime (32)
7963 returned 39, which is undesirable as it is a multiple of 3; and
7964 next_almost_prime (24) returned 25, which is a multiple of 5 so
7965 why was the code bothering to check for multiples of 7?
7967 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7969 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7971 Variadic C functions now count arguments with ptrdiff_t.
7972 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7973 Back then I didn't know that the Emacs coding style prefers signed int.
7974 Also, in the meantime I found a few more instances where arguments
7975 were being counted with int, which may truncate counts on 64-bit
7976 machines, or EMACS_INT, which may be unnecessarily wide.
7977 * lisp.h (struct Lisp_Subr.function.aMANY)
7978 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7979 Arg counts are now ptrdiff_t, not size_t.
7980 All variadic functions and their callers changed accordingly.
7981 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7982 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7983 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7984 * callint.c (Fcall_interactively): Check arg count for overflow,
7985 to avoid potential buffer overrun. Use signed char, not 'int',
7986 for 'varies' array, so that we needn't bother to check its size
7987 calculation for overflow.
7988 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7989 * eval.c (apply_lambda):
7990 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7991 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7992 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7994 * callint.c (Fcall_interactively): Don't use index var as event count.
7996 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7997 * mem-limits.h (SIZE): Remove; no longer used.
7999 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8001 Remove unnecessary casts.
8002 * xterm.c (x_term_init):
8003 * xfns.c (x_set_border_pixel):
8004 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8005 These aren't needed now that we assume ANSI C.
8007 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8008 It's more likely to cause problems (due to unsigned overflow)
8011 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8013 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8015 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8017 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8019 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8021 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8023 GLYPH_CODE_FACE returns EMACS_INT, not int.
8024 * dispextern.h (merge_faces):
8025 * xfaces.c (merge_faces):
8026 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8027 Don't assume EMACS_INT fits in int.
8029 * character.h (CHAR_VALID_P): Remove unused parameter.
8030 * fontset.c, lisp.h, xdisp.c: All uses changed.
8032 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8034 * fns.c (concat): Minor tuning based on overflow analysis.
8035 This doesn't fix any bugs. Use int to hold character, instead
8036 of constantly refetching from Emacs object. Use XFASTINT, not
8037 XINT, for value known to be a character. Don't bother comparing
8038 a single byte to 0400, as it's always less.
8040 * floatfns.c (Fexpt):
8041 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8043 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8046 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8048 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8049 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8050 incorrectly succeed when S was a string, because 4294967386 was
8051 truncated before it was used.
8053 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8054 Otherwise, an out-of-range integer could cause undefined behavior
8057 * composite.c: Use int, not EMACS_INT, for characters.
8058 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8059 EMACS_INT, for values that are known to be in character range.
8060 This doesn't fix any bugs but is the usual style inside Emacs and
8061 may generate better code on 32-bit machines.
8063 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8064 This is for reasons similar to the recent CHAR_STRING fix.
8065 * charset.c (Fencode_char): Check that character arg is actually
8066 a character. Pass an int to ENCODE_CHAR.
8067 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8068 wider than 'int', as a compile-time check to prevent future regressions
8071 * character.c (char_string): Remove unnecessary casts.
8073 Make sure a 64-bit char is never passed to CHAR_STRING.
8074 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8075 by silently ignoring the top 32 bits, allowing some values
8076 that were far too large to be valid characters.
8077 * character.h: Include <verify.h>.
8078 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8079 arguments are no wider than unsigned, as a compile-time check
8080 to prevent future regressions in this area.
8082 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8083 (Fsubst_char_in_region):
8085 * xdisp.c (decode_mode_spec_coding):
8086 Adjust to CHAR_STRING's new requirement.
8087 * editfns.c (Finsert_char, Fsubst_char_in_region):
8088 * fns.c (concat): Check that character args are actually
8089 characters. Without this test, these functions did the wrong
8090 thing with wildly out-of-range values on 64-bit hosts.
8092 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8093 These casts should not be needed on 32-bit hosts, either.
8094 * keyboard.c (read_char):
8095 * lread.c (Fload): Remove casts to unsigned.
8097 * lisp.h (UNSIGNED_CMP): New macro.
8098 This fixes comparison bugs on 64-bit hosts.
8099 (ASCII_CHAR_P): Use it.
8100 * casefiddle.c (casify_object):
8101 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8102 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8103 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8104 * dispextern.h (FACE_FROM_ID):
8105 * keyboard.c (read_char): Use UNSIGNED_CMP.
8107 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8108 not to EMACS_INT, to avoid GCC warning.
8110 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8112 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8113 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8114 isn't needed on 32-bit machines.
8116 * buffer.c (Fgenerate_new_buffer_name):
8117 Use EMACS_INT for count, not int.
8118 (advance_to_char_boundary): Return EMACS_INT, not int.
8120 * data.c (Qcompiled_function): Now static.
8122 * window.c (window_body_lines): Now static.
8124 * image.c (gif_load): Rename local to avoid shadowing.
8126 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8127 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8128 * alloc.c (make_save_value): Integer argument is now of type
8130 (mark_object): Use ptrdiff_t, not int.
8131 * lisp.h (pD): New macro.
8132 * print.c (print_object): Use it.
8134 * alloc.c: Use EMACS_INT, not int, to count objects.
8135 (total_conses, total_markers, total_symbols, total_vector_size)
8136 (total_free_conses, total_free_markers, total_free_symbols)
8137 (total_free_floats, total_floats, total_free_intervals)
8138 (total_intervals, total_strings, total_free_strings):
8139 Now EMACS_INT, not int. All uses changed.
8140 (Fgarbage_collect): Compute overall total using a double, so that
8141 integer overflow is less likely to be a problem. Check for overflow
8142 when converting back to an integer.
8143 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8144 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8145 These were 'int' variables that could overflow on 64-bit hosts;
8146 they were never used, so remove them instead of repairing them.
8147 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8148 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8149 Previously, this ceilinged at INT_MAX, but that doesn't work on
8151 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8153 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8154 (allocate_vectorlike): Check for ptrdiff_t overflow.
8155 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8156 when a (possibly-narrower) signed value would do just as well.
8157 We prefer using signed arithmetic, to avoid comparison confusion.
8159 * alloc.c: Catch some string size overflows that we were missing.
8160 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8161 for convenience in STRING_BYTES_MAX.
8162 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8163 The definition here is exact; the one in lisp.h was approximate.
8164 (allocate_string_data): Check for string overflow. This catches
8165 some instances we weren't catching before. Also, it catches
8166 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8167 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8168 and ptrdiff_t and EMACS_INT are both 64 bits.
8170 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8171 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8172 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8174 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8176 * alloc.c (Fmake_string): Check for out-of-range init.
8178 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8180 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8182 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8184 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8185 xg_get_default_scrollbar_width.
8187 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8188 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8189 (style_changed_cb): Call update_theme_scrollbar_width and call
8190 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8191 all frames (Bug#8505).
8192 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8193 Call gtk_window_set_resizable if HAVE_GTK3.
8194 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8195 and height if HAVE_GTK3 (Bug#8505).
8196 (scroll_bar_width_for_theme): New variable.
8197 (update_theme_scrollbar_width): New function.
8198 (xg_get_default_scrollbar_width): Move code to
8199 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8200 (xg_initialize): Call update_theme_scrollbar_width.
8202 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8204 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8206 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8208 * frame.c (make_frame): Call other_buffer_safely instead of
8211 * window.c (temp_output_buffer_show): Call display_buffer with
8212 second argument Vtemp_buffer_show_specifiers and reset latter
8213 immediately after the call.
8214 (Vtemp_buffer_show_specifiers): New variable.
8215 (auto_window_vscroll_p, next_screen_context_lines)
8216 (Vscroll_preserve_screen_position): Remove leading asterisks from
8219 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8221 Fix minor problems found by GCC 4.6.0 static checking.
8222 * buffer.c (Qclone_number): Remove for now, as it's unused.
8223 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8224 (record_buffer): Remove unused local.
8225 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8226 (set_frame_buffer_list): Remove; unused.
8227 * frame.h (other_visible_frames): Remove decl.
8228 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8229 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8230 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8232 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8233 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8234 Define only if HAVE_GPM.
8235 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8236 (update_hints_inhibit): Remove; never set. All uses removed.
8237 * widgetprv.h (emacsFrameClassRec): Remove decl.
8238 * window.c (delete_deletable_window): Now returns void, since it
8239 wasn't returning anything.
8240 (compare_window_configurations): Remove unused locals.
8241 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8242 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8243 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8244 the same widths as pointers. This follows up on the 2011-05-06 patch.
8245 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8246 * xterm.h: Likewise.
8247 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8249 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8251 * makefile.w32-in: Update dependencies.
8252 (LISP_H): Add lib/intprops.h.
8254 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8256 * image.c (gif_load): Add animation frame delay to the metadata.
8257 (syms_of_image): Use DEFSYM. New symbol `delay'.
8259 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8261 * window.c (delete_deletable_window): Re-add.
8262 (Fset_window_configuration): Rewrite to handle dead buffers and
8263 consequently deletable windows.
8264 (window_tree, Fwindow_tree): Remove. Supply functionality in
8266 (compare_window_configurations): Simplify code.
8268 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8270 * image.c (imagemagick_load_image): Fix type mismatch.
8271 (Fimagemagick_types): Likewise.
8273 * window.h (replace_buffer_in_windows): Declare.
8275 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8277 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8278 Qclone_number. Remove external declaration of Qdelete_window.
8279 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8281 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8282 Run Qbuffer_list_update_hook if allowed.
8283 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8284 buffer list implementation.
8285 (other_buffer_safely): New function.
8286 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8287 calls to replace_buffer_in_windows and
8288 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8290 (record_buffer): Inhibit quitting and rewrite using quittable
8291 functions. Run Qbuffer_list_update_hook if allowed.
8292 (Frecord_buffer, Funrecord_buffer): New functions.
8293 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8294 Move switch-to-buffer to window.el.
8295 (bury-buffer): Move to window.el.
8296 (Vbuffer_list_update_hook): New variable.
8298 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8301 * window.h (resize_frame_windows): Move up in code.
8302 (Fwindow_frame): Remove EXFUN.
8303 (replace_buffer_in_all_windows): Remove prototype.
8304 (replace_buffer_in_windows_safely): Add prototype.
8306 * window.c: Declare Qdelete_window static again. Move down
8307 declaration of select_count.
8308 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8309 (Fother_window): Move to window.el.
8310 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8311 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8312 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8314 (replace_buffer_in_windows): Implement by calling
8315 Qreplace_buffer_in_windows.
8316 (replace_buffer_in_all_windows): Remove with some functionality
8317 moved into replace_buffer_in_windows_safely.
8318 (replace_buffer_in_windows_safely): New function.
8319 (select_window_norecord, select_frame_norecord): Move in front
8320 of run_window_configuration_change_hook. Remove now obsolete
8322 (Fset_window_buffer): Rewrite doc-string.
8323 Call Qrecord_window_buffer.
8324 (keys_of_window): Move binding for other-window to window.el.
8326 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8328 * dispextern.h (struct image): Replace data member, whose int_val
8329 and ptr_val fields were not used by anything, with a single
8332 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8333 (gif_clear_image, gif_load, imagemagick_load_image)
8334 (gs_clear_image, gs_load): Callers changed.
8336 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8338 * buffer.h: Include <time.h>, for time_t.
8339 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8341 Fix minor problems found by static checking.
8343 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8345 Make identifiers static if they are not used in other modules.
8346 * data.c (Qcompiled_function, Qframe, Qvector):
8347 * image.c (QimageMagick, Qsvg):
8348 * minibuf.c (Qmetadata):
8349 * window.c (resize_window_check, resize_root_window): Now static.
8350 * window.h (resize_window_check, resize_root_window): Remove decls.
8352 * window.c (window_deletion_count, delete_deletable_window):
8354 (window_body_lines): Now static.
8355 (Fdelete_other_windows_internal): Mark vars as initialized.
8356 Make sure 'resize_failed' is initialized.
8357 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8358 (resize_window_apply): Remove unused local.
8359 * window.h (delete_deletable_window): Remove decl.
8361 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8362 (imagemagick_load_image): Fix pointer signedness problem by changing
8363 last arg from unsigned char * to char *. All uses changed.
8364 Also, fix a local for similar reasons.
8365 Remove unused locals. Remove locals to avoid shadowing.
8366 (fn_rsvg_handle_free): Remove; unused.
8367 (svg_load, svg_load_image): Fix pointer signedness problem.
8368 (imagemagick_load_image): Don't use garbage pointer image_wand.
8370 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8372 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8374 * image.c (gif_load): Fix omitted cast error introduced by
8377 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8379 * window.h (resize_proportionally, orig_total_lines)
8380 (orig_top_line): Remove from window structure.
8381 (set_window_height, set_window_width, change_window_heights)
8382 (Fdelete_window): Remove prototypes.
8383 (resize_frame_windows): Remove duplicate declaration.
8385 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8387 * window.h (resize_frame_windows, resize_window_check)
8388 (delete_deletable_window, resize_root_window)
8389 (resize_frame_windows): Declare prototypes.
8391 * window.c (resize_window_apply): Make definition be "static" to
8392 match the prototype.
8394 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8396 * window.c: Remove declarations of Qwindow_size_fixed,
8397 window_min_size_1, window_min_size_2, window_min_size,
8398 size_window, window_fixed_size_p, enlarge_window, delete_window.
8399 Remove static from declaration of Qdelete_window, it's
8400 temporarily needed by Fbury_buffer.
8401 (replace_window): Don't assign orig_top_line and
8403 (Fdelete_window, delete_window): Remove. Window deletion is
8404 handled by window.el.
8405 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8406 Replace Fdelete_window calls with calls to Qdelete_window.
8407 (Fdelete_other_windows): Remove. Deleting other windows is
8408 handled by window.el.
8409 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8410 handled in window.el.
8411 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8412 Window minimum sizes are handled in window.el.
8413 (shrink_windows, size_window, set_window_height)
8414 (set_window_width, change_window_heights, window_height)
8415 (window_width, CURBEG, CURSIZE, enlarge_window)
8416 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8417 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8418 handled in window.el.
8419 (make_dummy_parent): Rename to make_parent_window and give it a
8420 second argument horflag.
8421 (make_window): Don't set resize_proportionally any more.
8422 (Fsplit_window): Remove. Windows are split in window.el.
8423 (save_restore_action, save_restore_orig_size)
8424 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8425 Resize mini windows in window.el.
8426 (grow_mini_window, shrink_mini_window): Implement by calling
8427 Qresize_root_window_vertically, resize_window_check and
8428 resize_window_apply.
8429 (saved_window, Fset_window_configuration, save_window_save):
8430 Do not handle orig_top_line, orig_total_lines, and
8431 resize_proportionally.
8432 (window_min_height, window_min_width): Move to window.el.
8433 (keys_of_window): Move bindings for delete-other-windows,
8434 split-window, delete-window and enlarge-window to window.el.
8436 * buffer.c: Temporarily extern Qdelete_window.
8437 (Fbury_buffer): Temporarily call Qdelete_window instead of
8438 Fdelete_window (Fbury_buffer will move to window.el soon).
8440 * frame.c (set_menu_bar_lines_1): Remove code handling
8441 orig_top_line and orig_total_lines.
8443 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8444 set_window_height but set heights directly.
8445 (change_frame_size_1): Use resize_frame_windows.
8447 * xdisp.c (init_xdisp): Don't use set_window_height but set
8450 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8451 Use resize_frame_windows instead of change_window_heights and run
8452 run_window_configuration_change_hook.
8454 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8455 instead of change_window_heights and run
8456 run_window_configuration_change_hook.
8458 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8460 * window.c (replace_window): Rename second argument REPLACEMENT to
8461 NEW. New third argument SETFLAG. Rewrite.
8462 (delete_window, make_dummy_parent): Call replace_window with
8464 (window_list_1): Move down in code.
8465 (run_window_configuration_change_hook): Move set_buffer part
8466 before select_frame_norecord part in order to unwind correctly.
8467 Rename count1 to count.
8468 (recombine_windows, delete_deletable_window, resize_root_window)
8469 (Fdelete_other_windows_internal)
8470 (Frun_window_configuration_change_hook, make_parent_window)
8471 (resize_window_check, resize_window_apply, Fresize_window_apply)
8472 (resize_frame_windows, Fsplit_window_internal)
8473 (Fdelete_window_internal, Fresize_mini_window_internal):
8475 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8477 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8479 * window.h (window): Add some new members to window structure -
8480 normal_lines, normal_cols, new_total, new_normal, clone_number,
8481 splits, nest, prev_buffers, next_buffers.
8482 (WINDOW_TOTAL_SIZE): Move here from window.c.
8483 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8485 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8487 (make_dummy_parent): Set new members of windows structure.
8488 (make_window): Move down in code. Handle new members of window
8490 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8491 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8492 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8493 (Fset_window_prev_buffers, Fwindow_next_buffers)
8494 (Fset_window_next_buffers, Fset_window_clone_number):
8496 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8497 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8499 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8500 Argument WINDOW can be now internal window too.
8501 (Fwindow_use_time): Move up in code.
8502 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8504 (Fset_window_configuration, saved_window)
8505 (Fcurrent_window_configuration, save_window_save): Handle new
8506 members of window structure.
8507 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8508 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8509 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8510 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8511 Qget_mru_window, Qresize_root_window,
8512 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8513 Qauto_buffer_name; staticpro them.
8515 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8517 * window.c (Fwindow_total_size, Fwindow_left_column)
8518 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8519 (Fwindow_list_1): New functions.
8520 (window_box_text_cols): Replace with window_body_cols.
8521 (Fwindow_width, Fscroll_left, Fscroll_right):
8522 Use window_body_cols instead of window_box_text_cols.
8523 (delete_window, Fset_window_configuration):
8524 Call delete_all_subwindows with window as argument.
8525 (delete_all_subwindows): Take a window as argument and not a
8527 (window_loop): Remove handling of GET_LRU_WINDOW and
8529 (Fget_lru_window, Fget_largest_window): Move to window.el.
8531 * window.h: Extern window_body_cols instead of
8532 window_box_text_cols. delete_all_subwindows now takes a
8533 Lisp_Object as argument.
8535 * indent.c (compute_motion, Fcompute_motion):
8536 Use window_body_cols instead of window_box_text_cols.
8538 * frame.c (delete_frame): Call delete_all_subwindows with root
8541 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8543 * fns.c (Fputhash): Document return value.
8545 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8547 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8549 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8551 Cons<->int and similar integer overflow fixes (Bug#8794).
8553 Check for overflow when converting integer to cons and back.
8554 * charset.c (Fdefine_charset_internal, Fdecode_char):
8555 Use cons_to_unsigned to catch overflow.
8556 (Fencode_char): Use INTEGER_TO_CONS.
8557 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8558 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8559 * data.c (long_to_cons, cons_to_long): Remove.
8560 (cons_to_unsigned, cons_to_signed): New functions.
8561 These signal an error for invalid or out-of-range values.
8562 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8563 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8564 * font.c (Ffont_variation_glyphs):
8565 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8566 * lisp.h: Include <intprops.h>.
8567 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8568 (cons_to_signed, cons_to_unsigned): New decls.
8569 (long_to_cons, cons_to_long): Remove decls.
8570 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8571 (Fprimitive_undo): Use CONS_TO_INTEGER.
8572 * xfns.c (Fx_window_property): Likewise.
8573 * xselect.c: Include <limits.h>.
8574 (x_own_selection, selection_data_to_lisp_data):
8575 Use INTEGER_TO_CONS.
8576 (x_handle_selection_request, x_handle_selection_clear)
8577 (x_get_foreign_selection, Fx_disown_selection_internal)
8578 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8579 (lisp_data_to_selection_data): Use cons_to_unsigned.
8580 (x_fill_property_data): Use cons_to_signed.
8581 Report values out of range.
8583 Check for buffer and string overflow more precisely.
8584 * buffer.h (BUF_BYTES_MAX): New macro.
8585 * lisp.h (STRING_BYTES_MAX): New macro.
8586 * alloc.c (Fmake_string):
8587 * character.c (string_escape_byte8):
8588 * coding.c (coding_alloc_by_realloc):
8589 * doprnt.c (doprnt):
8590 * editfns.c (Fformat):
8592 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8593 since they may not be the same number.
8594 * editfns.c (Finsert_char):
8595 * fileio.c (Finsert_file_contents):
8596 Likewise for BUF_BYTES_MAX.
8598 * image.c: Use ptrdiff_t, not int, for sizes.
8599 (slurp_file): Switch from int to ptrdiff_t.
8601 (slurp_file): Check that file size fits in both size_t (for
8602 malloc) and ptrdiff_t (for sanity and safety).
8604 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8605 if b->modtime has its maximal value.
8607 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8609 Don't assume time_t can fit into int.
8610 * buffer.h (struct buffer.modtime): Now time_t, not int.
8611 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8612 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8614 Minor fixes for signed vs unsigned integers.
8615 * character.h (MAYBE_UNIFY_CHAR):
8616 * charset.c (maybe_unify_char):
8617 * keyboard.c (read_char, reorder_modifiers):
8618 XINT -> XFASTINT, since the integer must be nonnegative.
8619 * ftfont.c (ftfont_spec_pattern):
8620 * keymap.c (access_keymap, silly_event_symbol_error):
8621 XUINT -> XFASTINT, since the integer must be nonnegative.
8622 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8623 since it makes no difference and we prefer signed.
8624 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8625 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8628 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8630 * window.h (Fwindow_frame): Declare.
8632 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8634 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8635 (SPARE_MEMORY): Always define.
8636 (LARGE_REQUEST): Remove.
8637 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8639 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8641 * lisp.h: Move EXFUNS for Fframe_root_window,
8642 Fframe_first_window and Fset_frame_selected_window to window.h.
8644 * window.h: Move EXFUNS for Fframe_root_window,
8645 Fframe_first_window and Fset_frame_selected_window here from
8648 * frame.c (Fwindow_frame, Fframe_first_window)
8649 (Fframe_root_window, Fframe_selected_window)
8650 (Fset_frame_selected_window): Move to window.c.
8651 (Factive_minibuffer_window): Move to minibuf.c.
8652 (Fother_visible_frames_p): New function.
8654 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8656 * window.c (decode_window, decode_any_window): Move up in code.
8657 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8658 (inhibit_frame_unsplittable): Remove unused variable.
8659 (Fwindow_buffer): Move up and rewrite doc-string.
8660 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8661 (Fwindow_prev): New functions.
8662 (Fwindow_frame): Move here from frame.c. Accept any window as
8664 (Fframe_root_window, Fframe_first_window)
8665 (Fframe_selected_window): Move here from frame.c. Accept frame
8666 or arbitrary window as argument. Update doc-strings.
8667 (Fminibuffer_window): Move up in code.
8668 (Fwindow_minibuffer_p): Move up in code and simplify.
8669 (Fset_frame_selected_window): Move here from frame.c.
8671 (Fselected_window, select_window, Fselect_window): Move up in
8672 code. Minor doc-string fixes.
8674 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8676 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8677 Do not assume that spare memory exists; that assumption is valid
8678 only if SYSTEM_MALLOC.
8679 (LARGE_REQUEST): New macro, so that the issue of large requests
8680 is separated from the issue of spare memory.
8682 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8684 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8687 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8689 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8692 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8694 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8696 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8698 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8699 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8701 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8703 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8705 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8707 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8708 (x_clipboard_manager_save): Add return value.
8709 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8711 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8712 Obey Vx_select_enable_clipboard_manager. Catch errors in
8713 x_clipboard_manager_save (Bug#8779).
8714 (Vx_select_enable_clipboard_manager): New variable.
8715 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8717 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8719 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8721 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8723 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8724 in the current matrix if keep_current_p is non-zero.
8726 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8728 * bidi.c (bidi_level_of_next_char): Fix last change.
8730 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8732 Support bidi reordering of text covered by display properties.
8734 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8735 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8736 (bidi_cache_search, bidi_cache_iterator_state)
8737 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8738 (bidi_level_of_next_char, bidi_move_to_visually_next):
8739 Support character positions inside a run of characters covered by a
8741 (bidi_paragraph_init, bidi_resolve_explicit_1)
8742 (bidi_level_of_next_char): Call bidi_fetch_char and
8743 bidi_fetch_char_advance instead of FETCH_CHAR and
8745 (bidi_init_it): Initialize new members.
8746 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8748 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8749 instead of using explicit *_CHAR codes.
8750 (bidi_resolve_explicit, bidi_resolve_weak):
8751 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8752 bidirectional text is supported only in multibyte buffers.
8753 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8754 it to initialize the frame_window_p member of struct bidi_it.
8755 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8756 (bidi_resolve_explicit, bidi_resolve_weak)
8757 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8758 bidi_it->nchars is non-positive.
8759 (bidi_level_of_next_char): Don't try to lookup the cache for the
8760 next/previous character if nothing is cached there yet, or if we
8761 were just reseat()'ed to a new position.
8763 * xdisp.c (set_cursor_from_row): Set start and stop points
8764 according to the row's direction when priming the loop that looks
8765 for the glyph on which to display cursor.
8766 (single_display_spec_intangible_p): Function deleted.
8767 (display_prop_intangible_p): Reimplement to call
8768 handle_display_spec instead of single_display_spec_intangible_p.
8769 Accept 3 additional arguments needed by handle_display_spec.
8770 This fixes incorrect cursor motion across display property with complex
8771 values: lists, `(when COND...)' forms, etc.
8772 (single_display_spec_string_p): Support property values that are
8773 lists with the argument STRING its top-level element.
8774 (display_prop_string_p): Fix the condition for processing a
8775 property that is a list to be consistent with handle_display_spec.
8776 (handle_display_spec): New function, refactored from the
8777 last portion of handle_display_prop.
8778 (compute_display_string_pos): Accept additional argument
8779 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8780 value of a `display' property is a "replacing spec".
8781 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8782 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8783 the display property, but just return a value indicating whether
8784 the display property will replace the characters it covers.
8785 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8786 frame_window_p members of struct bidi_it.
8787 (compute_display_string_pos, compute_display_string_end):
8789 (push_it): Accept second argument POSITION, where pop_it should
8790 jump to continue iteration.
8791 (reseat_1): Initialize bidi_it.disp_pos.
8793 * keyboard.c (adjust_point_for_property): Adjust the call to
8794 display_prop_intangible_p to its new signature.
8796 * dispextern.h (struct bidi_it): New member frame_window_p.
8797 (bidi_init_it): Update prototypes.
8798 (display_prop_intangible_p): Update prototype.
8799 (compute_display_string_pos, compute_display_string_end):
8801 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8804 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8806 Malloc failure behavior now depends on size of allocation.
8807 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8808 * lisp.h: Change signatures accordingly.
8809 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8810 All callers changed. (Bug#8762)
8812 * gnutls.c: Use Emacs's memory allocators.
8813 Without this change, the gnutls library would invoke malloc etc.
8814 directly, which causes problems on non-SYNC_INPUT hosts, and which
8815 runs afoul of improving memory_full behavior. (Bug#8761)
8816 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8817 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8818 xfree instead of the default malloc, realloc, free.
8819 (Fgnutls_boot): No need to check for memory allocation failure,
8820 since xmalloc does that for us.
8822 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8823 * category.c (hash_get_category_set):
8824 * ccl.c (ccl_driver):
8825 * charset.c (Fdefine_charset_internal):
8826 * charset.h (struct charset.hash_index):
8827 * composite.c (get_composition_id, gstring_lookup_cache)
8828 (composition_gstring_put_cache):
8829 * composite.h (struct composition.hash_index):
8830 * dispextern.h (struct image.hash):
8831 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8832 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8833 (hashfn_equal, hashfn_user_defined, make_hash_table)
8834 (maybe_resize_hash_table, hash_lookup, hash_put)
8835 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8836 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8837 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8838 * image.c (make_image, search_image_cache, lookup_image)
8839 (xpm_put_color_table_h):
8840 * lisp.h (struct Lisp_Hash_Table):
8841 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8842 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8843 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8844 * alloc.c (allocate_vectorlike):
8845 Check for overflow in vector size calculations.
8846 * ccl.c (ccl_driver):
8847 Check for overflow when converting EMACS_INT to int.
8848 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8849 need to be updated by these changes.
8850 * fns.c (make_hash_table, maybe_resize_hash_table):
8851 Check for integer overflow with large hash tables.
8852 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8853 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8854 (SXHASH_REDUCE): New macro.
8855 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8856 Use it instead of discarding useful hash info with large hash values.
8857 (sxhash_float): New function.
8858 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8859 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8860 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8861 Rewrite to use FIXNUM_BITS, as this simplifies things.
8862 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8863 Adjust signatures to match updated version of code.
8864 (consing_since_gc): Now EMACS_INT, since a single hash table can
8865 use more than INT_MAX bytes.
8867 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8869 Make it possible to build with GCC-4.6+ -O2 -flto.
8871 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8873 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8875 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8876 Call minibuffer-inactive-mode.
8878 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8880 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8881 Update dependencies.
8883 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8885 * data.c (init_data): Remove code for UTS, this system is not
8888 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8890 Don't force ./temacs to start in terminal mode.
8892 * frame.c (make_initial_frame): Initialize faces in all cases, not
8893 only when CANNOT_DUMP is defined.
8894 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8896 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8898 * dispnew.c (add_window_display_history): Use const for the string
8899 pointer. Remove declaration, not needed.
8901 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8903 Use 'inline', not 'INLINE'.
8904 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8905 * alloc.c, fontset.c (INLINE): Remove.
8906 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8907 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8908 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8909 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8910 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8912 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8914 Make it possible to run ./temacs.
8916 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8917 syms_of_callproc does the same thing. Remove test for
8918 "initialized", do it in the caller.
8919 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8921 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8923 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8924 (read_minibuf): Use get_minibuffer.
8925 (syms_of_minibuf): Use DEFSYM.
8926 (Qmetadata): New var.
8927 * data.c (Qbuffer): Don't make it static.
8928 (syms_of_data): Use DEFSYM.
8930 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8932 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8933 (CCL_CODE_MIN): New macro.
8935 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8937 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8939 * eval.c (Qdebug): Now static.
8940 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8941 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8942 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8944 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8946 * image.c: Various fixes to ImageMagick code comments.
8947 (Fimagemagick_types): Doc fix.
8949 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8951 Minor fixes prompted by GCC 4.6.0 warnings.
8953 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8955 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8956 (x_clipboard_manager_save_all): Move extern decl to ...
8957 * xterm.h: ... here, so that it can be checked for consistency.
8959 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8961 * xselect.c (x_clipboard_manager_save_frame)
8962 (x_clipboard_manager_save_all): New functions.
8963 (Fx_clipboard_manager_save): Lisp function deleted.
8965 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8966 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8968 * xterm.h: Update prototype.
8970 2011-05-28 William Xu <william.xwl@gmail.com>
8972 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8975 2011-05-28 Jim Meyering <meyering@redhat.com>
8977 Avoid a sign-extension bug in crypto_hash_function.
8978 * fns.c (to_uchar): Define.
8979 (crypto_hash_function): Use it to convert some newly-signed
8980 variables to unsigned, to avoid sign-extension bugs. For example,
8981 without this change, (md5 "truc") would evaluate to
8982 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8983 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8984 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8986 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8988 Integer overflow fixes.
8990 * dbusbind.c: Serial number integer overflow fixes.
8991 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8992 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8993 to hold a serial number that is too large for a fixnum.
8994 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8995 Check for serial numbers out of range. Decode any serial number
8996 that was so large that it became a float. (Bug#8722)
8998 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8999 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9000 Use XFASTINT rather than XUINT when numbers are nonnegative.
9001 (xd_append_arg, Fdbus_method_return_internal):
9002 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9003 arguments, check that Lisp number is nonnegative, rather than
9004 silently wrapping negative numbers around. (Bug#8722)
9005 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9008 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9010 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9012 ccl: Add integer overflow checks.
9013 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9014 (IN_INT_RANGE): New macros.
9015 (ccl_driver): Use them to check for integer overflow when
9016 decoding a CCL program. Many of the new checks are whether XINT (x)
9017 fits in int; it doesn't always, on 64-bit hosts. The new version
9018 doesn't catch all possible integer overflows, but it's an
9019 improvement. (Bug#8719)
9021 * alloc.c (make_event_array): Use XINT, not XUINT.
9022 There's no need for unsigned here.
9024 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9025 This follows up to the 2011-05-06 change that substituted uintptr_t
9026 for EMACS_INT. This case wasn't caught back then.
9028 Rework Fformat to avoid integer overflow issues.
9029 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9030 now (part of C89). Include <verify.h>.
9031 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9032 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9033 (Fformat): Avoid the prepass trying to compute sizes; it was only
9034 approximate and thus did not catch overflow reliably. Instead, walk
9035 through the format just once, formatting and computing sizes as we go,
9036 checking for integer overflow at every step, and allocating a larger
9037 buffer as needed. Keep track separately whether the format is
9038 multibyte. Keep only the most-recently calculated precision, rather
9039 than them all. Record whether each argument has been converted to
9040 string. Use EMACS_INT, not int, for byte and char and arg counts.
9041 Support field widths and precisions larger than INT_MAX. Avoid
9042 sprintf's undefined behavior with conversion specifications such as %#d
9043 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9044 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9045 formatting out-of-range floating point numbers with int
9048 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9050 * data.c: Avoid integer truncation in expressions involving floats.
9051 * data.c: Include <intprops.h>.
9052 (arith_driver): When there's an integer overflow in an expression
9053 involving floating point, convert the integers to floating point
9054 so that the resulting value does not suffer from catastrophic
9055 integer truncation. For example, on a 64-bit host (* 4
9056 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9057 Do not rely on undefined behavior after integer overflow.
9059 merge count_size_as_multibyte, parse_str_to_multibyte
9060 * character.c, character.h (count_size_as_multibyte):
9061 Rename from parse_str_to_multibyte; all uses changed.
9062 Check for integer overflow.
9063 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9064 since it's now a duplicate of the other. This is more of
9065 a character than a buffer op, so better that it's in character.c.
9066 * fns.c, print.c: Adjust to above changes.
9068 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9070 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9072 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9074 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9075 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9076 (x_clipboard_manager_save): Now static.
9077 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9079 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9080 (crypto_hash_function): Now static.
9081 Fix pointer signedness problems. Avoid unnecessary initializations.
9083 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9085 * termhooks.h (Vselection_alist): Make it terminal-local.
9087 * terminal.c (create_terminal): Initialize it.
9089 * xselect.c: Support for clipboard managers.
9090 (Vselection_alist): Move to termhooks.h as terminal-local var.
9091 (LOCAL_SELECTION): New macro.
9092 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9093 (symbol_to_x_atom): Remove gratuitous arg.
9094 (x_handle_selection_request, lisp_data_to_selection_data)
9095 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9096 (x_own_selection, x_get_local_selection, x_convert_selection):
9097 New arg, specifying work frame. Use terminal-local Vselection_alist.
9098 (some_frame_on_display): Delete unused function.
9099 (Fx_own_selection_internal, Fx_get_selection_internal)
9100 (Fx_disown_selection_internal, Fx_selection_owner_p)
9101 (Fx_selection_exists_p): New optional frame arg.
9102 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9103 (x_handle_selection_clear): Don't treat other terminals with the
9104 same keyboard specially. Use the terminal-local Vselection_alist.
9105 (x_clear_frame_selections): Use Frun_hook_with_args.
9107 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9109 * xterm.h: Add support for those atoms.
9111 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9113 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9114 (converted_selections, conversion_fail_tag): New global variables.
9115 (x_selection_request_lisp_error): Free the above.
9116 (x_get_local_selection): Remove unnecessary code.
9117 (x_reply_selection_request): Args changed; handle arbitrary array
9118 of converted selections stored in converted_selections.
9119 Separate the XChangeProperty and SelectionNotify steps.
9120 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9121 (x_convert_selection): New function.
9122 (x_handle_selection_event): Simplify.
9123 (x_get_foreign_selection): Don't ignore incoming requests while
9124 waiting for an answer; this will fail when we implement
9125 SAVE_TARGETS, and seems unnecessary anyway.
9126 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9127 (Vx_sent_selection_functions): Doc fix.
9129 2011-05-26 Leo Liu <sdl.web@gmail.com>
9131 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9133 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9135 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9137 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9138 for fringe update if it has periodic bitmap.
9139 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9140 and fringe_bitmap_periodic_p.
9142 * fringe.c (get_fringe_bitmap_data): New function.
9143 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9144 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9145 row. Mark glyph row for fringe update if periodicity changed.
9147 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9148 for fringe update unless it has periodic bitmap.
9150 2011-05-25 Kenichi Handa <handa@m17n.org>
9152 * xdisp.c (get_next_display_element): Set correct it->face_id for
9153 a static composition.
9155 2011-05-24 Leo Liu <sdl.web@gmail.com>
9158 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9160 * fns.c (crypto_hash_function, Fsha1): New function.
9161 (Fmd5): Use crypto_hash_function.
9162 (syms_of_fns): Add Ssha1.
9164 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9166 * gnutls.c: Remove unused macros.
9167 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9168 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9169 Remove macros that are defined and never used.
9170 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9172 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9174 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9175 (Fx_get_selection_internal): Minor cleanup.
9176 (Fx_own_selection_internal): Rename arguments for consistency with
9179 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9181 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9183 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9185 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9187 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9189 * dispnew.c (scrolling_window): Don't exclude the case that the
9190 last enabled row in the desired matrix touches the bottom boundary.
9192 2011-05-21 Glenn Morris <rgm@gnu.org>
9194 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9195 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9196 and add some more files.
9198 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9200 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9201 report_file_error introduced by the change from 2011-05-07.
9203 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9205 * systime.h (Time): Define only if emacs is defined.
9206 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9207 where the include path doesn't have X11/X.h by default. See
9208 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9210 2011-05-20 Kenichi Handa <handa@m17n.org>
9212 * composite.c (find_automatic_composition): Fix previous change.
9214 2011-05-20 Glenn Morris <rgm@gnu.org>
9216 * lisp.mk: New file, split from Makefile.in.
9217 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9218 (shortlisp): Remove.
9219 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9221 2011-05-19 Glenn Morris <rgm@gnu.org>
9223 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9224 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9225 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9226 (lisp): Set the order to that of loadup.el.
9227 (shortlisp): Make it a copy of $lisp.
9228 (SOME_MACHINE_LISP): Remove.
9229 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9230 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9232 2011-05-18 Kenichi Handa <handa@m17n.org>
9234 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9235 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9236 (find_automatic_composition): Mostly rewrite for efficiency.
9238 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9240 * makefile.w32-in: Update dependencies.
9242 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9244 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9245 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9247 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9249 Fix some integer overflow issues, such as string length overflow.
9251 * insdel.c (count_size_as_multibyte): Check for string overflow.
9253 * character.c (lisp_string_width): Check for string overflow.
9254 Use EMACS_INT, not int, for string indexes and lengths; in
9255 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9256 the resulting string length overflows an EMACS_INT; instead,
9257 report a string overflow if no precision given. When checking for
9258 precision exhaustion, use a check that cannot possibly have
9259 integer overflow. (Bug#8675)
9260 * character.h (lisp_string_width): Adjust to new signature.
9262 * alloc.c (string_overflow): New function.
9263 (Fmake_string): Use it. This doesn't change behavior, but saves
9264 a few bytes and will simplify future changes.
9265 * character.c (string_escape_byte8): Likewise.
9266 * lisp.h (string_overflow): New decl.
9268 Fixups, following up to the user-interface timestamp change.
9269 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9270 for UI timestamps, instead of unsigned long.
9271 * msdos.c (mouse_get_pos): Likewise.
9272 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9273 * w32gui.h (Time): Define by including "systime.h" rather than by
9274 declaring it ourselves. (Bug#8664)
9276 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9277 * image.c (clear_image_cache): Likewise.
9279 * term.c (term_mouse_position): Don't assume time_t wraparound.
9281 Be more systematic about user-interface timestamps.
9282 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9283 and sometimes 'EMACS_UINT', to represent these timestamps.
9284 This change causes it to use 'Time' uniformly, as that's what X uses.
9285 This makes the code easier to follow, and makes it easier to catch
9286 integer overflow bugs such as Bug#8664.
9287 * frame.c (Fmouse_position, Fmouse_pixel_position):
9288 Use Time, not unsigned long, for user-interface timestamps.
9289 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9290 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9291 * keyboard.h (last_event_timestamp): Likewise.
9292 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9293 * menu.h (xmenu_show): Likewise.
9294 * term.c (term_mouse_position): Likewise.
9295 * termhooks.h (struct input_event.timestamp): Likewise.
9296 (struct terminal.mouse_position_hook): Likewise.
9297 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9298 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9299 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9300 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9302 * menu.h, termhooks.h: Include "systime.h", for Time.
9304 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9305 Don't assume that the difference between two unsigned long values
9306 can fit into an integer. At this point, we know button_down_time
9307 <= event->timestamp, so the difference must be nonnegative, so
9308 there's no need to cast the result if double-click-time is
9309 nonnegative, as it should be; check that it's nonnegative, just in
9310 case. This bug is triggered when events are more than 2**31 ms
9311 apart (about 25 days). (Bug#8664)
9313 * xselect.c (last_event_timestamp): Remove duplicate decl.
9314 (x_own_selection): Remove needless cast to unsigned long.
9316 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9317 that always fit in int. Use a sentinel instead of a counter, to
9318 avoid a temp and to allay GCC's concerns about possible int overflow.
9319 * frame.h (struct frame): Use int for menu_bar_items_used
9320 instead of EMACS_INT, since it always fits in int.
9322 * menu.c (grow_menu_items): Check for int overflow.
9324 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9326 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9327 Before, the code was not consistent. These values cannot exceed
9328 2**31 - 1 so there's no need to make them unsigned.
9329 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9330 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9331 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9333 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9335 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9336 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9337 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9338 presumably because the widths might not match.
9340 * window.c (size_window): Avoid needless test at loop start.
9342 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9344 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9346 2011-05-12 Drew Adams <drew.adams@oracle.com>
9348 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9350 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9352 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9353 `width' to `bar_area_x' and `bar_area_width', respectively.
9354 (x_scroll_run): Take account of fringe background extension.
9356 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9357 Rename local vars `left' and `width' to `bar_area_x' and
9358 `bar_area_width', respectively.
9359 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9360 background extension.
9362 2011-05-10 Jim Meyering <meyering@redhat.com>
9364 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9366 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9368 * image.c (Finit_image_library): Return t for built-in image types,
9369 like pbm and xbm. (Bug#8640)
9371 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9373 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9375 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9377 * w32console.c (Fset_screen_color): Doc fix.
9378 (Fget_screen_color): New function.
9379 (syms_of_ntterm): Defsubr it.
9381 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9382 unlink the temporary file if Fcall_process didn't create it in the
9384 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9385 child process will be redirected to a file specified with `:file'.
9386 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9387 cue to call_process_cleanup not to close that handle.
9389 2011-05-07 Ben Key <bkey76@gmail.com>
9391 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9392 one of two shell specific rules, either bootstrap-temacs-CMD or
9393 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9394 to the previous implementation of the bootstrap-temacs rule.
9395 The bootstrap-temacs-CMD rule is similar to the previous
9396 implementation of the bootstrap-temacs rule except that it
9397 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9400 These changes, along with some changes to nt/configure.bat,
9401 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9402 earlier fix to add support for --cflags and --ldflags options
9403 that include quotes so that it works whether make uses cmd or
9406 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9408 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9409 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9411 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9412 a string. Handle both cases.
9413 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9414 (Fdbus_register_method): Use Qinvalid_function.
9416 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9418 * makefile.w32-in: Update dependencies.
9419 (LISP_H): Add inttypes.h and stdin.h.
9420 (PROCESS_H): Add unistd.h.
9422 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9424 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9425 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9427 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9429 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9431 * term.c (vfatal): Remove stray call to va_end.
9432 It's not needed and the C Standard doesn't allow it here anyway.
9434 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9435 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9437 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9440 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9442 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9444 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9446 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9448 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9450 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9451 * charset.c (Fdefine_charset_internal): Don't initialize
9452 charset.code_space[15]. The value was garbage, on hosts with
9453 32-bit int (Bug#8600).
9455 * lread.c (read_integer): Be more consistent with string-to-number.
9456 Use string_to_number to do the actual conversion; this avoids
9457 rounding errors and fixes some other screwups. Without this fix,
9458 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9459 (digit_to_number): Move earlier, for benefit of read_integer.
9460 Return -1 if the digit is out of range for the base, -2 if it is
9461 not a digit in any supported base. (Bug#8602)
9463 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9465 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9466 to match comment at start of function. This also removes a
9467 GCC warning about overflow in a 32+64-bit port.
9469 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9471 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9472 Reported by Stefan Monnier in
9473 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9474 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9475 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9477 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9478 (EMACS_UINTPTR): Likewise, with uintptr_t.
9480 * lisp.h: Prefer 64-bit EMACS_INT if available.
9481 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9482 on 32-bit hosts that have 64-bit int, so that they can access
9484 However, temporarily disable this change unless the temporary
9485 symbol WIDE_EMACS_INT is defined.
9487 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9489 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9490 This removes an assumption that EMACS_INT and long are the same
9491 width as pointers. The assumption is true for Emacs porting targets
9492 now, but we want to make other targets possible.
9493 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9494 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9495 In the rest of the code, change types of integers that hold casted
9496 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9497 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9498 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9499 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9500 No need to cast type when ORing.
9501 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9502 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9503 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9504 assume EMACS_INT is the same width as char *.
9505 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9506 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9507 Remove no-longer-needed casts.
9508 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9509 (xg_tool_bar_help_callback, xg_make_tool_item):
9510 Use EMACS_INTPTR to hold an integer
9511 that will be cast to void *; this can avoid a GCC warning
9512 if EMACS_INT is not the same width as void *.
9513 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9514 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9515 (current_message_1, set_message_1):
9516 Use a local to convert to proper width without a cast.
9517 * xmenu.c (dialog_selection_callback): Likewise.
9519 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9520 Also, don't assume VALBITS / RAND_BITS is less than 5,
9521 and don't rely on undefined behavior when shifting a 1 left into
9523 * lisp.h (get_random): Change signature to match.
9525 * lread.c (hash_string): Use size_t, not int, for hash computation.
9526 Normally we prefer signed values; but hashing is special, because
9527 it's better to use unsigned division on hash table sizes so that
9528 the remainder is nonnegative. Also, size_t is the natural width
9529 for hashing into memory. The previous code used 'int', which doesn't
9530 retain enough info to hash well into very large tables.
9531 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9533 * dbusbind.c: Don't possibly lose pointer info when converting.
9534 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9535 Use XPNTR rather than XHASH, so that the high-order bits of
9536 the pointer aren't lost when converting through void *.
9538 * eval.c (Fautoload): Don't double-shift a pointer.
9540 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9542 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9544 * gnutls.c (DEF_GNUTLS_FN):
9545 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9547 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9549 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9552 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9554 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9555 New version that can reserve upto 2GB of heap space.
9557 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9559 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9561 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9563 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9564 `gnutls_certificate_set_x509_key_file'.
9566 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9568 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9569 Update dependencies.
9571 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9573 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9574 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9575 Remove unused parameter `fildes'.
9576 * process.c (read_process_output, send_process): Don't pass it.
9578 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9580 Fix previous change: the library cache is defined in w32.c.
9581 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9582 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9584 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9586 Implement dynamic loading of GnuTLS on Windows.
9588 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9589 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9590 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9593 * gnutls.c (Qgnutls_dll): Define.
9594 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9595 (gnutls_*): Declare function pointers.
9596 (init_gnutls_functions): New function to initialize function pointers.
9597 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9598 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9599 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9600 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9601 (emacs_gnutls_write, emacs_gnutls_read)
9602 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9603 (Fgnutls_available_p): New function.
9604 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9605 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9606 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9608 * image.c: Include w32.h.
9609 (Vimage_type_cache): Delete.
9610 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9611 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9612 (w32_delayed_load): Move to w32.c.
9614 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9616 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9617 (w32_delayed_load): Move from image.c. When loading a library, record
9618 its filename in the :loaded-from property of the library id.
9619 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9620 Initialize and staticpro them.
9621 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9623 * process.c: Include lisp.h before w32.h, not after.
9624 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9625 instead of gnutls_record_check_pending.
9627 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9629 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9631 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9632 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9635 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9637 * xterm.c (x_set_frame_alpha): Do not set property on anything
9638 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9640 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9642 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9644 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9646 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9647 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9648 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9649 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9650 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9651 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9652 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9653 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9654 (Qgnutls_bootprop_callbacks_verify): Make static.
9656 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9658 * callproc.c: Indentation fixup.
9660 * sysdep.c (wait_for_termination_1): Make static.
9661 (wait_for_termination, interruptible_wait_for_termination):
9662 Move after wait_for_termination_1.
9664 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9666 * sysdep.c (interruptible_wait_for_termination): New function
9667 which is like wait_for_termination, but allows keyboard
9670 * callproc.c (Fcall_process): Add (:file "file") as an option for
9672 (Fcall_process_region): Ditto.
9674 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9676 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9677 rather than `XVECTOR (FOO)->size'.
9679 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9680 inttypes.h, as a gnulib replacement is used if it not available in
9683 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9685 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9686 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9687 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9689 * coding.c (coding_alloc_by_realloc): Error out if destination
9690 will grow beyond MOST_POSITIVE_FIXNUM.
9691 (decode_coding_emacs_mule): Abort if there isn't enough place in
9692 charbuf for the composition carryover bytes. Reserve an extra
9693 space for up to 2 characters produced in a loop.
9694 (decode_coding_iso_2022): Abort if there isn't enough place in
9695 charbuf for the composition carryover bytes.
9697 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9699 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9700 aborting when %lld or %lll format is passed.
9701 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9702 %llo or %llx format is passed. (Bug#8545)
9704 * window.c (window_scroll_line_based): Use a marker instead of
9705 simple variables to record original value of point. (Bug#7952)
9707 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9708 produced by %s or %c overflows available buffer space. (Bug#8545)
9710 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9712 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9713 (SIZE_MAX): Move defn after all includes, as they might #define it.
9715 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9717 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9719 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9721 * keyboard.c (Qdelayed_warnings_hook): Define.
9722 (command_loop_1): Run `delayed-warnings-hook'
9723 if Vdelayed_warnings_list is non-nil.
9724 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9725 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9727 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9729 * doprnt.c (doprnt): Don't return value smaller than the buffer
9730 size if the message was truncated. (Bug#8545).
9732 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9734 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9735 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9737 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9739 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9741 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9743 * makefile.w32-in: Update dependencies.
9745 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9747 Improve `doprnt' and its usage. (Bug#8545)
9748 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9749 `format_end'. Remove support for %l as a conversion specifier.
9750 Don't use xrealloc. Improve diagnostics when the %l size modifier
9751 is used. Update the commentary.
9753 * eval.c (verror): Simplify calculation of size_t.
9755 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9758 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9760 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9763 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9765 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9766 This makes this file independent of the recent pseudovector change.
9768 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9770 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9772 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9773 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9774 Remove unused local.
9775 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9777 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9778 GCC 4.6.0 optimizes based on type-based alias analysis.
9779 For example, if b is of type struct buffer * and v of type struct
9780 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9781 != &v->size, and therefore "v->size = 1; b->size = 2; return
9782 v->size;" must therefore return 1. This assumption is incorrect
9783 for Emacs, since it type-puns struct Lisp_Vector * with many other
9784 types. To fix this problem, this patch adds a new type struct
9785 vectorlike_header that documents the constraints on layout of vectors
9786 and pseudovectors, and helps optimizing compilers not get fooled
9787 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9788 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9789 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9791 (XSETPVECTYPE): Rewrite in terms of new macro.
9792 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9793 This is a bit clearer, and further avoids the possibility of
9794 undesirable aliasing.
9795 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9796 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9797 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9798 since Lisp_Subr is a special case (no "next" field).
9799 (ASIZE): Now uses header.size rather than size.
9800 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9801 to avoid the hassle of writing XVECTOR (foo)->header.size.
9802 (struct vectorlike_header): New type.
9803 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9804 object, to help avoid aliasing.
9805 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9806 (SUBRP): Likewise, since Lisp_Subr is a special case.
9807 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9808 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9809 (struct Lisp_Hash_Table): Combine first two members into a single
9810 struct vectorlike_header member. All uses of "size" and "next" members
9811 changed to be "header.size" and "header.next".
9812 * buffer.h (struct buffer): Likewise.
9813 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9814 * frame.h (struct frame): Likewise.
9815 * process.h (struct Lisp_Process): Likewise.
9816 * termhooks.h (struct terminal): Likewise.
9817 * window.c (struct save_window_data, struct saved_window): Likewise.
9818 * window.h (struct window): Likewise.
9819 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9820 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9821 * buffer.c (init_buffer_once): Likewise.
9822 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9824 * process.c (Fformat_network_address): Use local var for size,
9827 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9829 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9830 * data.c (atof): Remove decl; no longer used or needed.
9831 (digit_to_number): Move to lread.c.
9832 (Fstring_to_number): Use new string_to_number function, to be
9833 consistent with how the Lisp reader treats infinities and NaNs.
9834 Do not assume that floating-point numbers represent EMACS_INT
9835 without losing information; this is not true on most 64-bit hosts.
9836 Avoid double-rounding errors, by insisting on integers when
9837 parsing non-base-10 numbers, as the documentation specifies.
9838 * lisp.h (string_to_number): New decl, replacing ...
9839 (isfloat_string): Remove.
9840 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9841 (read1): Do not accept +. and -. as integers; this
9842 appears to have been a coding error. Similarly, do not accept
9843 strings like +-1e0 as floating point numbers. Do not report
9844 overflow for integer overflows unless the base is not 10 which
9845 means we have no simple and reliable way to continue.
9846 Break out the floating-point parsing into a new
9847 function string_to_number, so that Fstring_to_number parses
9848 floating point numbers consistently with the Lisp reader.
9849 (digit_to_number): Move here from data.c. Make it static inline.
9850 (E_CHAR, EXP_INT): Remove, replacing with ...
9851 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9852 (string_to_number): New function, replacing isfloat_string.
9853 This function checks for valid syntax and produces the resulting
9854 Lisp float number too. Rework it so that string-to-number
9855 no longer mishandles examples like "1.0e+". Use strtoumax,
9856 so that overflow for non-base-10 numbers is reported only when
9857 there's no portable and simple way to convert to floating point.
9859 * textprop.c (set_text_properties_1): Rewrite for clarity,
9860 and to avoid GCC warning about integer overflow.
9862 * intervals.h (struct interval): Use EMACS_INT for members
9863 where EMACS_UINT might cause problems. See
9864 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9865 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9866 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9868 (offset_intervals): Tell GCC not to worry about length overflow
9869 when negating a negative length.
9871 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9872 (overrun_check_free): Likewise.
9874 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9875 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9878 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9879 (gnutls_make_error): Rename local to avoid shadowing.
9880 (gnutls_emacs_global_deinit): ifdef out; not used.
9881 (Fgnutls_boot): Use const for pointer to readonly storage.
9882 Comment out unused local. Fix pointer signedness problems.
9884 * lread.c (openp): Don't stuff size_t into an 'int'.
9885 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9886 about possible signed overflow.
9888 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9889 (GDK_KEY_g): Don't define if already defined.
9890 (xg_prepare_tooltip): Avoid pointer signedness problem.
9891 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9893 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9894 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9896 * xfns.c (Fx_window_property): Simplify a bit,
9897 to make a bit faster and to avoid GCC 4.6.0 warning.
9898 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9900 * fns.c (internal_equal): Don't assume size_t fits in int.
9902 * alloc.c (compact_small_strings): Tighten assertion a little.
9904 Replace pEd with more-general pI, and fix some printf arg casts.
9905 * lisp.h (pI): New macro, generalizing old pEd macro to other
9906 conversion specifiers. For example, use "...%"pI"d..." rather
9907 than "...%"pEd"...".
9908 (pEd): Remove. All uses replaced with similar uses of pI.
9909 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9910 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9911 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9912 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9913 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9914 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9915 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9917 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9918 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9919 * print.c (safe_debug_print, print_object): Likewise.
9920 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9922 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9923 avoiding the 0 flag, which is not portable.
9924 * process.c (Fmake_network_process): Use pI to avoid cast.
9925 * region-cache.c (pp_cache): Likewise.
9926 * xdisp.c (decode_mode_spec): Likewise.
9927 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9928 behavior on 64-bit hosts with printf arg.
9929 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9930 (x_stop_queuing_selection_requests): Likewise.
9931 (x_get_window_property): Don't truncate byte count to an 'int'
9934 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9935 here, since it parses constructs like leading '-' and spaces,
9936 which are not wanted; and it overflows with large numbers.
9937 Instead, simply match F[0-9]+, which is what is wanted anyway.
9939 * alloc.c: Remove unportable assumptions about struct layout.
9940 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9941 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9942 (allocate_vectorlike, make_pure_vector): Use the new macros,
9943 plus offsetof, to remove unportable assumptions about struct layout.
9944 These assumptions hold on all porting targets that I know of, but
9945 they are not guaranteed, they're easy to remove, and removing them
9946 makes further changes easier.
9948 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9949 This doesn't fix a bug but makes the code clearer.
9950 (string_overrun_cookie): Now const. Use initializers that
9951 don't formally overflow signed char, to avoid warnings.
9952 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9953 can cause Emacs to crash when string overrun checking is enabled.
9954 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9955 multiple of sizeof (EMACS_INT); it need not be, if
9956 alignof(EMACS_INT) < sizeof (EMACS_INT).
9957 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9959 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9961 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9963 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9965 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9966 supposed to be handshaking. (Bug#8556)
9967 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9969 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9971 * lisp.h (Qdebug): List symbol.
9972 * eval.c (Qdebug): Restore global linkage.
9973 * keyboard.c (debug-on-event): New variable.
9974 (handle_user_signal): Break into debugger when debug-on-event
9975 matches the current signal symbol.
9977 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9979 * alloc.c (check_sblock, check_string_bytes)
9980 (check_string_free_list): Convert to standard C.
9982 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9984 * w32.c (emacs_gnutls_push): Fix typo.
9986 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9988 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9989 "cast to pointer from integer of different size".
9991 Improve doprnt and its use in verror. (Bug#8545)
9992 * doprnt.c (doprnt): Document the set of format control sequences
9993 supported by the function. Use SAFE_ALLOCA instead of always
9996 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9997 is one byte too soon. Don't use xrealloc; instead xfree and
10000 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10002 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10005 * gnutls.c: Renamed global_initialized to
10006 gnutls_global_initialized. Added internals for the
10007 :verify-hostname-error, :verify-error, and :verify-flags
10008 parameters of `gnutls-boot' and documented those parameters in the
10009 docstring. Start callback support.
10010 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10011 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10012 on error. Return error code.
10013 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10014 (emacs_gnutls_read): Likewise.
10015 (Fgnutls_boot): Return handshake error code.
10016 (emacs_gnutls_handle_error): New function.
10017 (wsaerror_to_errno): Likewise.
10019 * w32.h (emacs_gnutls_pull): Add prototype.
10020 (emacs_gnutls_push): Likewise.
10022 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10023 (emacs_gnutls_push): Likewise.
10025 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10027 * process.c (wait_reading_process_output): Check if GnuTLS
10028 buffered some data internally if no FDs are set for TLS
10031 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10032 (LIBS): Link to USER_LIBS.
10033 ($(BLD)/gnutls.$(0)): New target.
10035 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10037 * xdisp.c (handle_single_display_spec): Rename the
10038 display_replaced_before_p argument into display_replaced_p, to
10039 make it consistent with the commentary. Fix typos in the
10042 * textprop.c (syms_of_textprop): Remove dead code.
10043 (copy_text_properties): Delete obsolete commentary about an
10044 interface that was deleted long ago. Fix typos in the description
10047 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10048 to changes in oldXMenu/XMenu.h from 2011-04-16.
10049 <menu_help_message, prev_menu_help_message>: Constify.
10050 (IT_menu_make_room): menu->help_text is now `const char **';
10053 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10054 to changes in oldXMenu/XMenu.h from 2011-04-16.
10055 (struct XMenu): Declare `help_text' `const char **'.
10057 * xfaces.c <Qunspecified>: Make extern again.
10059 * syntax.c: Include sys/types.h before including regex.h, as
10062 * doc.c (get_doc_string): Improve the format passed to `error'.
10064 * doprnt.c (doprnt): Improve commentary.
10066 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10068 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10071 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10072 changes in globals.h immediately force recompilation.
10073 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10074 $(CURDIR)/s/ms-w32.h.
10075 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10077 * character.c (Fchar_direction): Function deleted.
10078 (syms_of_character): Don't defsubr it.
10079 <char-direction-table>: Deleted.
10081 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10083 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10084 * doprnt.c: Include limits.h.
10085 (SIZE_MAX): New macro.
10086 (doprnt): Return a size_t value. 2nd arg is now size_t.
10087 Many local variables are now size_t instead of int or unsigned.
10088 Improve overflow protection. Support `l' modifier for integer
10089 conversions. Support %l conversion. Don't assume an EMACS_INT
10090 argument for integer conversions and for %c.
10092 * lisp.h (doprnt): Restore prototype.
10094 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10095 $(SRC)/character.h.
10097 * Makefile.in (base_obj): Add back doprnt.o.
10099 * deps.mk (doprnt.o): Add back prerequisites.
10100 (callint.o): Depend on character.h.
10102 * eval.c (internal_lisp_condition_case): Include the handler
10103 representation in the error message.
10104 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10105 when breaking from the loop.
10107 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10109 * callint.c (Fcall_interactively): When displaying error message
10110 about invalid control letter, pass the character's codepoint, not
10111 a pointer to its multibyte form. Improve display of the character
10112 in octal and display also its hex code.
10114 * character.c (char_string): Use %x to display the (unsigned)
10115 codepoint of an invalid character, to avoid displaying a bogus
10118 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10119 `error', not SYMBOL_NAME itself.
10121 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10122 character arguments to `error'.
10124 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10125 to `error' in error message about FINAL_CHAR argument. Make sure
10126 FINAL_CHAR is a character, and use %c when it is passed as
10127 argument to `error'.
10129 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10131 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10133 * w32.c: Include <time.h>.
10134 (sys_localtime): New function.
10136 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10138 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10140 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10142 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10144 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10145 zombies (Bug#8467).
10147 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10149 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10150 gl_state.e_property when gl_state.object is Qt.
10152 * insdel.c (make_gap_larger): Remove limitation of buffer size
10155 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10157 * xdisp.c (lookup_glyphless_char_display)
10158 (produce_glyphless_glyph): Handle cons cell entry in
10159 glyphless-char-display.
10160 (Vglyphless_char_display): Document it.
10162 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10163 glyphless-char-display.
10165 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10167 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10169 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10171 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10172 definition for no-X builds.
10174 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10176 Static checks with GCC 4.6.0 and non-default toolkits.
10178 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10180 * process.c (keyboard_bit_set): Define only if SIGIO.
10181 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10182 (send_process): Repair possible setjmp clobbering.
10184 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10186 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10188 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10190 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10191 Define only if needed.
10193 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10194 by pacifying GCC about it. Maybe it's time to retire it?
10195 * xfaces.c (USG, __TIMEVAL__): Likewise.
10197 * dispextern.h (struct redisplay_interface): Rename param
10198 to avoid shadowing.
10199 * termhooks.h (struct terminal): Likewise.
10200 * xterm.c (xembed_send_message): Likewise.
10202 * insdel.c (make_gap_smaller): Define only if
10203 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10205 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10208 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10209 so that we aren't warned about unused symbols.
10211 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10213 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10215 * xfns.c (x_real_positions): Mark locals as initialized.
10217 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10219 * xterm.c: Fix problems found by static analysis with other toolkits.
10220 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10221 (x_dispatch_event): Declare static if USE_GTK, and
10222 define if USE_GTK || USE_X_TOOLKIT.
10223 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10224 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10225 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10226 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10228 * xmenu.c (menu_help_callback): Pointer type fixes.
10229 Use const pointers when pointing at readonly data. Avoid pointer
10230 signedness clashes.
10231 (FALSE): Remove unused macro.
10232 (update_frame_menubar): Remove unused decl.
10234 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10236 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10237 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10238 (single_menu_item): Rename local to avoid shadowing.
10240 * keyboard.c (make_lispy_event): Remove unused local var.
10242 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10243 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10245 * bitmaps: Change bitmaps from unsigned char back to the X11
10246 compatible char. Avoid the old compiler warnings about
10247 out-of-range initializers by using, for example, '\xab' rather
10250 * xgselect.c (xgselect_initialize): Check vs interface
10251 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10253 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10255 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10256 to read-only memory.
10258 * fns.c (vector): Remove; this old hack is no longer needed.
10260 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10262 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10264 * xrdb.c (x_load_resources): Omit unused local.
10266 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10267 (x_window): Rename locals to avoid shadowing.
10268 (USG): Use the kludged USG macro, to pacify gcc.
10270 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10271 (x_term_init): Remove local to avoid shadowing.
10273 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10275 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10276 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10278 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10280 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10282 Fix regex.c, syntax.c and friends for buffers > 2GB.
10283 * syntax.h (struct gl_state_s): Declare character position members
10286 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10288 * textprop.c (verify_interval_modification, interval_of):
10289 Declare arguments EMACS_INT.
10291 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10294 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10296 * indent.c (Fvertical_motion): Local variable it_start is now
10299 * regex.c (re_match, re_match_2, re_match_2_internal)
10300 (bcmp_translate, regcomp, regexec, print_double_string)
10301 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10302 (re_compile_pattern, re_exec): Declare arguments and local
10303 variables `size_t' and `ssize_t' and return values `regoff_t', as
10305 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10306 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10307 <compile_stack_type>: `size' and `avail' are now `size_t'.
10309 * regex.h <regoff_t>: Use ssize_t, not int.
10310 (re_search, re_search_2, re_match, re_match_2): Arguments that
10311 specify buffer/string position and length are now ssize_t and
10312 size_t. Return type is regoff_t.
10314 2011-04-16 Ben Key <bkey76@gmail.com>
10316 * nsfont.m: Fixed bugs in ns_get_family and
10317 ns_descriptor_to_entity that were caused by using free to
10318 deallocate memory blocks that were allocated by xmalloc (via
10319 xstrdup). This caused Emacs to crash when compiled with
10320 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10321 --enable-checking=xmallocoverrun). xfree is now used to
10322 deallocate these memory blocks.
10324 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10326 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10328 emacs_write: Accept and return EMACS_INT for sizes.
10329 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10331 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10332 Accept and return EMACS_INT.
10333 (emacs_gnutls_write): Return the number of bytes written on
10335 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10336 (emacs_read, emacs_write): Remove check for negative size, as the
10337 Emacs source code has been audited now.
10338 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10339 (emacs_read, emacs_write): Use it.
10340 * process.c (send_process): Adjust to the new signatures of
10341 emacs_write and emacs_gnutls_write. Do not attempt to store
10342 a byte offset into an 'int'; it might overflow.
10343 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10345 * sound.c: Don't assume sizes fit in 'int'.
10346 (struct sound_device.period_size, alsa_period_size):
10347 Return EMACS_INT, not int.
10348 (struct sound_device.write, vox_write, alsa_write):
10349 Accept EMACS_INT, not int.
10350 (wav_play, au_play): Use EMACS_INT to store sizes and to
10351 record read return values.
10353 2011-04-15 Ben Key <bkey76@gmail.com>
10355 * keyboard.c (Qundefined): Don't declare static since it is used
10357 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10358 static since they are used in nsfont.m.
10360 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10362 * process.c (Qprocessp): Don't declare static.
10363 * lisp.h (Qprocessp): Declare again.
10365 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10367 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10369 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10371 Improve C-level modularity by making more things 'static'.
10373 Don't publish debugger-only interfaces to other modules.
10374 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10375 (verify_bytepos, count_markers): Move decls to the only modules
10377 * region-cache.h (pp_cache): Likewise.
10378 * window.h (check_all_windows): Likewise.
10379 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10381 * sysdep.c (croak): Now static, if
10382 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10383 * syssignal.h (croak): Declare only if not static.
10385 * alloc.c (refill_memory_reserve): Now static if
10386 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10387 * lisp.h (refill_memory_reserve): Declare only if not static.
10389 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10390 Define only if USE_LUCID.
10392 * xrdb.c (x_customization_string, x_rm_string): Now static.
10394 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10395 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10397 * xdisp.c (draw_row_with_mouse_face): Now static.
10398 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10400 * window.h (check_all_windows): Mark externally visible.
10402 * window.c (window_deletion_count): Now static.
10404 * undo.c: Make symbols static if they're not exported.
10405 (last_undo_buffer, last_boundary_position, pending_boundary):
10408 * textprop.c (interval_insert_behind_hooks): Now static.
10409 (interval_insert_in_front_hooks): Likewise.
10411 * term.c: Make symbols static if they're not exported.
10412 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10413 (max_frame_lines, tty_set_terminal_modes):
10414 (tty_reset_terminal_modes, tty_turn_off_highlight):
10415 (get_tty_terminal): Now static.
10416 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10417 * termhooks.h (term_mouse_moveto): Do not declare if
10418 HAVE_WINDOW_SYSTEM.
10419 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10420 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10422 * sysdep.c: Make symbols static if they're not exported.
10423 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10425 (sigprocmask_set, full_mask): Remove; unused.
10426 (wait_debugging): Mark as visible.
10427 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10428 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10430 * syntax.c (syntax_temp): Define only if !__GNUC__.
10432 * sound.c (current_sound_device, current_sound): Now static.
10434 * search.c (searchbufs, searchbuf_head): Now static.
10436 * scroll.c (scroll_cost): Remove; unused.
10437 * dispextern.h (scroll_cost): Remove decl.
10439 * region-cache.h (pp_cache): Mark as externally visible.
10441 * process.c: Make symbols static if they're not exported.
10442 (process_tick, update_tick, create_process, chan_process):
10443 (Vprocess_alist, proc_buffered_char, datagram_access):
10444 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10445 (deactivate_process): Mark defn as static, as well as decl.
10446 * lisp.h (create_process): Remove decl.
10447 * process.h (chan_process, Vprocess_alist): Remove decls.
10449 * print.c: Make symbols static if they're not exported.
10450 (print_depth, new_backquote_output, being_printed, print_buffer):
10451 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10452 (print_interval, print_number_index, initial_stderr_stream):
10454 * lisp.h (Fprinc): Remove decl.
10455 (debug_output_compilation_hack): Mark as externally visible.
10457 * sysdep.c (croak): Move decl from here to syssignal.h.
10458 * syssignal.h (croak): Put it here, so the API can be checked when
10459 'croak' is called from dissociate_if_controlling_tty.
10461 * minibuf.c: Make symbols static if they're not exported.
10462 (minibuf_save_list, choose_minibuf_frame): Now static.
10463 * lisp.h (choose_minibuf_frame): Remove decl.
10465 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10467 * lread.c: Make symbols static if they're not exported.
10468 (read_objects, initial_obarray, oblookup_last_bucket_number):
10470 (make_symbol): Remove; unused.
10471 * lisp.h (initial_obarray, make_symbol): Remove decls.
10473 * keyboard.c: Make symbols static if they're not exported.
10474 (single_kboard, recent_keys_index, total_keys, recent_keys):
10475 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10476 (this_single_command_key_start, echoing, last_auto_save):
10477 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10478 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10479 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10480 (Vlispy_mouse_stem, double_click_count):
10482 (force_auto_save_soon): Define only if SIGDANGER.
10483 (ignore_mouse_drag_p): Now static if
10484 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10485 (print_help): Remove; unused.
10486 (stop_character, last_timer_event): Mark as externally visible.
10487 * keyboard.h (ignore_mouse_drag_p): Declare only if
10488 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10489 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10490 * lisp.h (echoing): Remove decl.
10491 (force_auto_save_soon): Declare only if SIGDANGER.
10492 * xdisp.c (redisplay_window): Simplify code, to make it more
10493 obvious that ignore_mouse_drag_p is not accessed if !defined
10494 USE_GTK && !defined HAVE_NS.
10496 * intervals.c: Make symbols static if they're not exported.
10497 (merge_properties_sticky, merge_interval_right, delete_interval):
10499 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10501 * insdel.c: Make symbols static if they're not exported.
10502 However, leave prepare_to_modify_buffer alone. It's never
10503 called from outside this function, but that appears to be a bug.
10504 (combine_after_change_list, combine_after_change_buffer):
10505 (adjust_after_replace, signal_before_change): Now static.
10506 (adjust_after_replace_noundo): Remove; unused.
10507 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10508 (signal_before_change): Remove decls.
10510 * indent.c (val_compute_motion, val_vmotion): Now static.
10512 * image.c: Make symbols static if they're not exported.
10513 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10515 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10516 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10518 * fringe.c (standard_bitmaps): Now static.
10519 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10521 * frame.c: Make symbols static if they're not exported.
10522 (x_report_frame_params, make_terminal_frame): Now static.
10523 (get_frame_param): Now static, unless HAVE_NS.
10524 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10525 (x_get_resource_string): Remove; not used.
10526 * frame.h (make_terminal_frame, x_report_frame_params):
10527 (x_get_resource_string); Remove decls.
10528 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10529 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10531 * font.c, fontset.c: Make symbols static if they're not exported.
10532 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10533 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10534 * font.c (font_close_object): Now static.
10535 * font.h (font_close_object): Remove.
10536 * fontset.c (FONTSET_OBJLIST): Remove.
10537 (free_realized_fontset) #if-0 the body, which does nothing.
10538 (face_suitable_for_char_p): #if-0, as it's never called.
10539 * fontset.h (face_suitable_for_char_p): Remove decl.
10540 * xfaces.c (face_at_string_position):
10541 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10542 since 0 is always ASCII.
10544 * fns.c (weak_hash_tables): Now static.
10546 * fileio.c: Make symbols static if they're not exported.
10547 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10548 (Vwrite_region_annotation_buffers): Now static.
10550 * eval.c: Make symbols static if they're not exported.
10551 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10552 * lisp.h (backtrace_list): Remove decl.
10554 * emacs.c: Make symbols static if they're not exported.
10555 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10556 (fatal_error_code, fatal_error_signal_hook, standard_args):
10558 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10559 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10560 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10561 * lisp.h (fatal_error_signal_hook): Remove decl.
10562 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10564 * editfns.c: Move a (normally-unused) function to its only use.
10565 * editfns.c, lisp.h (get_operating_system_release): Remove.
10566 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10567 worth the hassle of breaking this out.
10569 * xterm.c: Make symbols static if they're not exported.
10570 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10571 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10572 (x_destroy_window, x_delete_display):
10574 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10575 (x_mouse_leave): Remove; unused.
10576 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10577 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10578 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10580 (x_mouse_leave): Declare only if WINDOWSNT.
10581 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10582 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10585 * ftxfont.c: Make symbols static if they're not exported.
10586 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10588 * font.h (ftxfont_driver): Likewise.
10590 * xfns.c: Make symbols static if they're not exported.
10591 (x_last_font_name, x_display_info_for_name):
10592 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10593 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10594 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10595 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10596 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10597 (last_show_tip_args): Now static.
10598 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10599 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10600 (x_screen_planes): Remove; unused.
10601 * dispextern.h (x_screen_planes): Remove decl.
10603 * dispnew.c: Make symbols static if they're not exported.
10604 * dispextern.h (redraw_garbaged_frames, scrolling):
10605 (increment_row_positions): Remove.
10606 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10607 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10609 (redraw_garbaged_frames): Remove; unused.
10611 * xfaces.c: Make symbols static if they're not exported.
10612 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10614 * xterm.h (defined_color): Remove decls.
10615 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10616 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10617 (menu_face_changed_default, defined_color, free_realized_face):
10618 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10619 (ascii_face_of_lisp_face): Remove; unused.
10621 * xdisp.c: Make symbols static if they're not exported.
10622 * dispextern.h (scratch_glyph_row, window_box_edges):
10623 (glyph_to_pixel_coords, set_cursor_from_row):
10624 (get_next_display_element, set_iterator_to_next):
10625 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10626 (show_mouse_face): Remove decls
10627 * frame.h (message_buf_print): Likewise.
10628 * lisp.h (pop_message, set_message, check_point_in_composition):
10630 * xterm.h (set_vertical_scroll_bar): Likewise.
10631 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10632 (message_buf_print, scratch_glyph_row, displayed_buffer):
10633 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10634 (get_next_display_element, show_mouse_face, window_box_edges):
10635 (frame_to_window_pixel_xy, check_point_in_composition):
10636 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10637 (glyph_to_pixel_coords): Remove; unused.
10639 * dired.c (file_name_completion): Now static.
10641 * dbusbind.c (xd_in_read_queued_messages): Now static.
10643 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10644 * data.c (circular_list_error): Remove.
10646 * commands.h (last_point_position, last_point_position_buffer):
10647 (last_point_position_window): Remove decls.
10648 * keyboard.c: Make these variables static.
10650 * coding.h (coding, code_convert_region, encode_coding_gap):
10652 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10653 (iso_code_class, detect_coding, code_convert_region): Now static.
10654 (encode_coding_gap): Remove; unused.
10656 * chartab.c (chartab_chars, chartab_bits): Now static.
10658 * charset.h (charset_iso_8859_1): Remove decl.
10659 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10662 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10663 * ccl.c (Vccl_program_table): Now static.
10664 (check_ccl_update): Remove; unused.
10666 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10667 * category.h: ... from here.
10668 * category.c (check_category_table, set_category_set): Now static.
10670 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10671 * lisp.h: Remove these decls.
10673 * buffer.c (buffer_count): Remove unused var.
10675 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10676 so that it's not optimized away.
10677 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10678 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10679 exported only to the debugger.
10681 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10682 * atimer.h (run_all_atimers): Remove; not exported.
10684 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10685 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10686 was inaccessible from Lisp.
10687 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10688 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10690 alloc.c: Import and export fewer symbols, and remove unused items.
10691 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10693 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10694 it's not optimized away by whole-program optimization.
10695 (message_enable_multibyte, free_misc): Remove.
10696 (catchlist, handlerlist, mark_backtrace):
10697 Declare only if BYTE_MARK_STACK.
10698 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10699 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10700 (message_enable_multibyte): Remove decl.
10701 (free_misc, interval_free_list, float_block, float_block_index):
10702 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10703 (cons_free_list, last_marked_index):
10705 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10706 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10707 (mark_backtrace): Define only if BYTE_MARK_STACK.
10708 * xdisp.c (message_enable_multibyte): Now static.
10710 Declare Lisp_Object Q* variables to be 'static' if not exported.
10711 This makes it easier for human readers (and static analyzers)
10712 to see whether these variables are used from other modules.
10713 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10714 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10715 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10716 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10717 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10718 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10719 * xmenu.c, xselect.c:
10720 Declare Q* vars static if they are not used in other modules.
10721 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10722 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10723 Remove decls of unexported vars.
10724 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10726 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10728 Make Emacs functions such as Fatom 'static' by default.
10729 This makes it easier for human readers (and static analyzers)
10730 to see whether these functions can be called from other modules.
10731 DEFUN now defines a static function. To make the function external
10732 so that it can be used in other C modules, use the new macro DEFUE.
10733 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10734 (Finit_image_library):
10735 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10736 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10737 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10738 Remove decls, since these functions are now static.
10739 (Funintern, Fget_internal_run_time): New decls, since these functions
10740 were already external.
10742 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10743 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10744 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10745 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10746 * keyboard.c, keymap.c, lread.c:
10747 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10748 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10749 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10750 Mark functions with DEFUE instead of DEFUN,
10751 if they are used in other modules.
10752 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10753 decls for now-static functions.
10754 * buffer.h (Fdelete_overlay): Remove decl.
10755 * callproc.c (Fgetenv_internal): Mark as internal.
10756 * composite.c (Fremove_list_of_text_properties): Remove decl.
10757 (Fcomposition_get_gstring): New forward static decl.
10758 * composite.h (Fcomposite_get_gstring): Remove decl.
10759 * dired.c (Ffile_attributes): New forward static decl.
10760 * doc.c (Fdocumntation_property): New forward static decl.
10761 * eval.c (Ffetch_bytecode): New forward static decl.
10762 (Funintern): Remove extern decl; now in .h file where it belongs.
10763 * fileio.c (Fmake_symbolic_link): New forward static decl.
10764 * image.c (Finit_image_library): New forward static decl.
10765 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10766 * intervals.h (Fprevious_property_change):
10767 (Fremove_list_of_text_properties): Remove decls.
10768 * keyboard.c (Fthis_command_keys): Remove decl.
10769 (Fcommand_execute): New forward static decl.
10770 * keymap.c (Flookup_key): New forward static decl.
10771 (Fcopy_keymap): Now static.
10772 * keymap.h (Flookup_key): Remove decl.
10773 * process.c (Fget_process): New forward static decl.
10774 (Fprocess_datagram_address): Mark as internal.
10775 * syntax.c (Fsyntax_table_p): New forward static decl.
10776 (skip_chars): Remove duplicate decl.
10777 * textprop.c (Fprevious_property_change): New forward static decl.
10778 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10780 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10781 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10783 * editfns.c (Fformat): Remove unreachable code.
10785 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10787 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10790 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10792 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10793 when at ZV. (Bug#8487)
10795 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10797 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10799 * keyboard.c (parse_tool_bar_item): Likewise.
10800 * sound.c (sound_cleanup, alsa_close): Likewise.
10801 * termcap.c (tgetent): Likewise.
10802 * xfns.c (x_default_font_parameter): Likewise.
10803 * xsettings.c (read_and_apply_settings): Likewise.
10805 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10806 (overrun_check_free): Protoize.
10808 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10810 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10811 since callers should never pass a negative size.
10812 Change the signature to match that of plain 'read' and 'write'; see
10813 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10814 * lisp.h: Update prototypes of emacs_write and emacs_read.
10816 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10818 * xdisp.c (redisplay_window): Don't try to determine the character
10819 position of the scroll margin if the window start point w->startp
10820 is outside the buffer's accessible region. (Bug#8468)
10822 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10824 Fix write-region and its subroutines for buffers > 2GB.
10825 * fileio.c (a_write, e_write): Modify declaration of arguments and
10826 local variables to support buffers larger than 2GB.
10827 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10829 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10830 argument, local variables, and return value.
10832 * lisp.h: Update prototypes of emacs_write and emacs_read.
10834 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10836 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10838 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10840 Fix more problems found by GCC 4.6.0's static checks.
10842 * xdisp.c (vmessage): Use a better test for character truncation.
10844 * charset.c (load_charset_map): <, not <=, for optimization,
10845 and to avoid potential problems with integer overflow.
10846 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10847 * casetab.c (set_identity, shuffle): Likewise.
10848 * editfns.c (Fformat): Likewise.
10849 * syntax.c (skip_chars): Likewise.
10851 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10852 This also lets GCC 4.6.0 generate slightly better loop code.
10854 * callint.c (Fcall_interactively): <, not <=, for optimization.
10855 (Fcall_interactively): Count the number of arguments produced,
10856 not the number of arguments given. This is simpler and lets GCC
10857 4.6.0 generate slightly better code.
10859 * ftfont.c: Distingish more carefully between FcChar8 and char.
10860 The previous code passed unsigned char * to a functions like
10861 strlen and xstrcasecmp that expect char *, which does not
10862 conform to the C standard.
10863 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10864 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10865 char * when the C standard requires it.
10867 * keyboard.c (read_char): Remove unused var.
10869 * eval.c: Port to Windows vsnprintf (Bug#8435).
10870 Include <limits.h>.
10871 (SIZE_MAX): Define if the headers do not.
10872 (verror): Do not give up if vsnprintf returns a negative count.
10873 Instead, grow the buffer. This ports to Windows vsnprintf, which
10874 does not conform to C99. Problem reported by Eli Zaretskii.
10875 Also, simplify the allocation scheme, by avoiding the need for
10876 calling realloc, and removing the ALLOCATED variable.
10878 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10880 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10881 But keep the doprint source code for now, as we might revamp it
10882 and use it again (Bug#8435).
10883 * lisp.h (doprnt): Remove.
10884 * Makefile.in (base_obj): Remove doprnt.o.
10885 * deps.mk (doprnt.o): Remove.
10887 error: Print 32- and 64-bit integers portably (Bug#8435).
10888 Without this change, on typical 64-bit hosts error ("...%d...", N)
10889 was used to print both 32- and 64-bit integers N, which relied on
10890 undefined behavior.
10891 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10892 * lisp.h (error, verror): Mark as printf-like functions.
10893 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10894 Report overflow in size calculations when allocating printf buffer.
10895 Do not truncate output string at its first null byte.
10896 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10897 Truncate the output at a character boundary, since vsnprintf does not
10899 * charset.c (check_iso_charset_parameter): Convert internal
10900 character to string before calling 'error', since %c now has the
10902 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10903 overflow when computing char to be passed to 'error'. Do not
10904 pass Lisp_Object to 'error'; pass the integer instead.
10905 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10906 formatted with plain %d.
10908 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10910 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10912 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10914 * xterm.c (x_catch_errors): Remove duplicate declaration.
10916 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10918 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10920 2011-04-10 Jim Meyering <meyering@redhat.com>
10922 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10923 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10924 return ssize_t not "int", and use size_t as the buffer length.
10925 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10926 * gnutls.h: Update declarations.
10927 * process.c (read_process_output): Use ssize_t, to match.
10928 (send_process): Likewise.
10930 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10932 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10934 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10936 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10937 Use unsigned char, to match FcChar8 type definition.
10939 * xterm.c (handle_one_xevent):
10940 * xmenu.c (create_and_show_popup_menu):
10941 * xselect.c (x_decline_selection_request)
10942 (x_reply_selection_request): Avoid type-punned deref of X events.
10944 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10946 Fix some uses of `int' instead of EMACS_INT.
10947 * search.c (string_match_1, fast_string_match)
10948 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10949 (scan_buffer, find_next_newline_no_quit)
10950 (find_before_next_newline, search_command, Freplace_match)
10951 (Fmatch_data): Make some `int' variables be EMACS_INT.
10953 * xdisp.c (display_count_lines): 3rd argument and return value now
10954 EMACS_INT. All callers changed.
10955 (pint2hrstr): Last argument is now EMACS_INT.
10957 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10958 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10959 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10960 (decode_coding_utf_16, decode_coding_emacs_mule)
10961 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10962 (decode_coding_ccl, decode_coding_charset)
10963 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10964 (decode_coding_iso_2022, decode_coding_emacs_mule)
10965 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10966 <char_offset, last_offset>: Declare EMACS_INT.
10967 (encode_coding_utf_8, encode_coding_utf_16)
10968 (encode_coding_emacs_mule, encode_invocation_designation)
10969 (encode_designation_at_bol, encode_coding_iso_2022)
10970 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10971 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10973 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10974 (encode_invocation_designation): Last argument P_NCHARS is now
10976 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10977 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10979 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10982 * ccl.c (Fccl_execute_on_string): Declare some variables
10985 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10987 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10989 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10991 * process.c (Fformat_network_address): Doc fix.
10993 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10995 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10997 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10999 * keyboard.c (read_char): Call Lisp function help-form-show,
11000 instead of using internal_with_output_to_temp_buffer.
11001 (Qhelp_form_show): New var.
11002 (syms_of_keyboard): Use DEFSYM macro.
11004 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11006 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11008 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11010 * process.c (Flist_processes): Remove to Lisp.
11011 (list_processes_1): Delete.
11013 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11015 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11017 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11019 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11021 Fix more problems found by GCC 4.6.0's static checks.
11023 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11025 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11027 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11029 * xdisp.c (vmessage): Mark as a printf-like function.
11031 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11033 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11035 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11036 printf-like functions.
11037 (tiff_load): Add casts to remove these marks before passing them
11038 to system-supplied API.
11040 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11042 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11043 This avoids several warnings with gcc -Wstrict-overflow.
11044 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11045 directly, rather than having caller test rule sign. This avoids
11046 some unnecessary tests.
11047 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11048 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11049 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11051 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11052 (xfont_open): Avoid unnecessary tests.
11054 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11056 * composite.h, composite.c (composition_gstring_put_cache):
11057 Use EMACS_INT, not int, for length.
11059 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11060 breaking out part of COMPOSITION_DECODE_RULE.
11061 (COMPOSITION_DECODE_RULE): Use it.
11062 * composite.c (get_composition_id): Remove unused local vars,
11063 by using the new macro.
11065 * textprop.c (set_text_properties_1): Change while to do-while,
11066 since the condition is always true at first.
11068 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11069 (interval_deletion_adjustment): Return unsigned value.
11072 * process.c (list_processes_1, create_pty, read_process_output):
11073 (exec_sentinel): Remove vars that were set but not used.
11074 (create_pty): Remove unnecessary "volatile"s.
11075 (Fnetwork_interface_info): Avoid possibility of int overflow.
11076 (read_process_output): Do adaptive read buffering even if carryover.
11077 (read_process_output): Simplify nbytes computation if buffered.
11079 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11081 * syntax.c (scan_words): Remove var that was set but not used.
11082 (update_syntax_table): Use unsigned instead of int.
11084 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11085 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11086 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11088 * print.c (print_error_message): Avoid int overflow.
11090 * font.c (font_list_entities): Redo for clarity,
11091 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11093 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11094 (font_score): Avoid potential overflow in diff calculation.
11096 * fns.c (substring_both): Remove var that is set but not used.
11097 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11099 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11101 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11102 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11103 can always succeed if overflow has undefined behavior.
11105 * search.c (boyer_moore, wordify): Remove vars set but not used.
11106 (wordify): Omit three unnecessary tests.
11108 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11109 All callers changed. This avoids the need for an unused var.
11111 * casefiddle.c (casify_region): Remove var that is set but not used.
11113 * dired.c (file_name_completion): Remove var that is set but not used.
11115 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11117 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11118 (Finsert_file_contents): Remove unnecessary code checking fd.
11120 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11121 Check for integer overflow on size calculations.
11123 * buffer.c (Fprevious_overlay_change): Remove var that is set
11126 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11127 Remove vars that are set but not used.
11128 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11129 (timer_check_2): Mark vars as initialized.
11131 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11133 * image.c (lookup_image): Remove var that is set but not used.
11134 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11136 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11137 that are set but not used.
11139 * xfns.c (make_invisible_cursor): Don't return garbage
11140 if XCreateBitmapFromData fails (Bug#8410).
11142 * xselect.c (x_get_local_selection, x_handle_property_notify):
11143 Remove vars that are set but not used.
11145 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11146 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11148 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11149 Remove var that is set but not used.
11150 (scroll_bar_windows_size): Now size_t, not int.
11151 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11152 Check for overflow.
11154 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11155 (map_tty_color) [!defined MSDOS]: Likewise.
11157 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11159 * coding.c: Remove vars that are set but not used.
11160 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11161 All callers changed.
11162 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11163 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11164 (decode_coding_charset): Remove vars that are set but not used.
11166 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11167 that is set but not used.
11169 * print.c (print_object): Remove var that is set but not used.
11171 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11172 The gnulib version avoids calling malloc in the usual case,
11173 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11174 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11175 * filelock.c (current_lock_owner): Likewise.
11176 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11177 * sysdep.c: Include allocator.h, careadlinkat.h.
11178 (emacs_no_realloc_allocator): New static constant.
11179 (emacs_readlink): New function.
11180 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11181 ../lib/careadlinkat.h.
11183 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11185 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11186 first non-nil return value).
11188 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11190 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11191 if not defined (Bug#8403).
11193 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11195 * xdisp.c (display_count_lines): Remove parameter `start',
11196 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11197 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11198 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11199 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11200 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11201 and thereabouts. All callers changed.
11202 (get_per_char_metric): Remove parameter `f', unused since
11203 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11205 2011-04-02 Jim Meyering <meyering@redhat.com>
11207 do not dereference NULL upon failed strdup
11208 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11209 (ns_get_family): Likewise.
11211 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11213 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11215 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11217 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11220 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11222 Add lexical binding.
11224 * window.c (Ftemp_output_buffer_show): New fun.
11225 (Fsave_window_excursion):
11226 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11228 * lread.c (lisp_file_lexically_bound_p): New function.
11229 (Fload): Bind Qlexical_binding.
11230 (readevalloop): Remove `evalfun' arg.
11231 Bind Qinternal_interpreter_environment.
11232 (Feval_buffer): Bind Qlexical_binding.
11233 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11235 (syms_of_lread): Declare `lexical-binding'.
11237 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11239 * keyboard.c (eval_dyn): New fun.
11240 (menu_item_eval_property): Use it.
11242 * image.c (parse_image_spec): Use Ffunctionp.
11244 * fns.c (concat, mapcar1): Accept byte-code-functions.
11246 * eval.c (Fsetq): Handle lexical vars.
11247 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11248 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11249 (FletX, Flet): Obey lexical binding.
11250 (Fcommandp): Handle closures.
11251 (Feval): New `lexical' arg.
11252 (eval_sub): New function extracted from Feval. Use it almost
11253 everywhere where Feval was used. Look up vars in lexical env.
11255 (Ffunctionp): Move from subr.el.
11256 (Ffuncall): Handle closures.
11257 (apply_lambda): Remove `eval_flags'.
11258 (funcall_lambda): Handle closures and new byte-code-functions.
11259 (Fspecial_variable_p): New function.
11260 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11261 but without exporting it to Lisp.
11263 * doc.c (Fdocumentation, store_function_docstring):
11264 * data.c (Finteractive_form): Handle closures.
11266 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11269 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11271 (exec_byte_code): New function extracted from Fbyte_code to handle new
11272 calling convention for byte-code-functions. Add new byte-codes.
11274 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11276 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11278 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11280 * xdisp.c (redisplay_internal): Fix prototype.
11282 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11284 * xdisp.c (SCROLL_LIMIT): New macro.
11285 (try_scrolling): Use it when setting scroll_limit.
11286 Limit scrolling to 100 screen lines.
11287 (redisplay_window): Even when falling back on "recentering",
11288 position point in the window according to scroll-conservatively,
11289 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11291 (try_scrolling): When point is above the window, allow searching
11292 as far as scroll_max, or one screenful, to compute vertical
11293 distance from PT to the scroll margin position. This prevents
11294 try_scrolling from unnecessarily failing when
11295 scroll-conservatively is set to a value slightly larger than the
11296 window height. Clean up the case of PT below the margin at bottom
11297 of window: scroll_max can no longer be INT_MAX. When aggressive
11298 scrolling is in use, don't let point enter the opposite scroll
11299 margin as result of the scroll.
11300 (syms_of_xdisp) <scroll-conservatively>: Document the
11301 threshold of 100 lines for never-recentering scrolling.
11303 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11305 * dispextern.h (move_it_by_lines):
11306 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11307 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11308 (message_log_check_duplicate): Remove parameters `prev_bol' and
11309 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11310 (redisplay_internal): Remove parameter `preserve_echo_area',
11311 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11313 * indent.c (Fvertical_motion):
11314 * window.c (window_scroll_pixel_based, Frecenter):
11315 Don't pass `need_y_p' to `move_it_by_lines'.
11317 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11319 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11320 steal a few bits to be more compact.
11321 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11322 Remove unneeded casts.
11324 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11326 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11328 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11329 binding" message (bug#7967).
11331 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11333 Fix more problems found by GCC 4.6.0's static checks.
11335 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11336 Remove unused local var.
11338 * editfns.c (Fmessage_box): Remove unused local var.
11340 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11341 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11342 Omit unused local vars.
11343 * window.c (shrink_windows): Omit unused local var.
11344 * menu.c (digest_single_submenu): Omit unused local var.
11345 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11346 Omit unused local var.
11348 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11349 Don't assume string length fits in int.
11350 (keyremap_step, read_key_sequence): Use size_t for sizes.
11351 (read_key_sequence): Don't check last_real_key_start redundantly.
11353 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11354 instead of alloca (Bug#8344).
11356 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11357 (Fbacktrace_frame): Don't assume nframes fits in int.
11359 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11361 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11364 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11366 * cm.c (calccost): Turn while-do into do-while, for clarity.
11368 * keyboard.c (syms_of_keyboard): Use the same style as later
11369 in this function when indexing through an array. This also
11370 works around GCC bug 48267.
11372 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11374 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11376 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11377 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11379 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11380 This avoids undefined behavior on integer overflow, and is a bit
11381 more convenient anyway since it is compared to a size_t variable.
11383 Variadic C functions now count arguments with size_t, not int.
11384 This avoids an unnecessary limitation on 64-bit machines, which
11385 caused (substring ...) to crash on large vectors (Bug#8344).
11386 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11387 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11388 All variadic functions and their callers changed accordingly.
11389 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11390 * data.c (arith_driver, float_arith_driver): Likewise.
11391 * editfns.c (general_insert_function): Likewise.
11392 * eval.c (struct backtrace.nargs, interactive_p)
11393 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11394 (funcall_lambda, mark_backtrace): Likewise.
11395 * fns.c (concat): Likewise.
11396 * frame.c (x_set_frame_parameters): Likewise.
11397 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11398 0 if not found, not -1. All callers changed.
11400 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11401 (stack_copy_size): Now size_t, not int.
11402 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11404 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11406 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11407 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11408 All callers changed.
11410 * lisp.h (multibyte_char_to_unibyte):
11411 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11412 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11413 * character.h (CHAR_TO_BYTE8):
11414 * cmds.c (internal_self_insert):
11415 * editfns.c (general_insert_function):
11416 * keymap.c (push_key_description):
11417 * search.c (Freplace_match):
11418 * xdisp.c (message_dolog, set_message_1): All callers changed.
11420 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11422 * keyboard.c (safe_run_hook_funcall): New function.
11423 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11424 don't set the hook to nil, but remove the offending function instead.
11425 (Qcommand_hook_internal): Remove, unused.
11426 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11427 Vcommand_hook_internal.
11429 * eval.c (enum run_hooks_condition): Remove.
11430 (funcall_nil, funcall_not): New functions.
11431 (run_hook_with_args): Call each function through a `funcall' argument.
11432 Remove `cond' argument, now redundant.
11433 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11434 (Frun_hook_with_args_until_failure): Adjust accordingly.
11435 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11437 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11439 * dispextern.h (string_buffer_position): Remove declaration.
11441 * print.c (strout): Remove parameter `multibyte', unused since
11442 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11444 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11445 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11446 All callers changed.
11448 * w32.c (_wsa_errlist): Use braces for struct initializers.
11450 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11451 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11452 All callers changed.
11453 (string_buffer_position): Likewise. Also, make static (it's never
11454 used outside xdisp.c).
11455 (cursor_row_p): Remove parameter `w', unused since
11456 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11457 (decode_mode_spec): Remove parameter `precision', introduced during
11458 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11459 All callers changed.
11461 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11463 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11465 2011-03-27 Anders Lindgren <andlind@gmail.com>
11467 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11468 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11469 (ns_update_auto_hide_menu_bar): New functions.
11470 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11471 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11472 ns_constrain_all_frames.
11473 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11474 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11476 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11478 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11480 2011-03-27 Glenn Morris <rgm@gnu.org>
11482 * syssignal.h: Replace RETSIGTYPE with void.
11483 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11484 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11485 Replace SIGTYPE with void everywhere.
11486 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11487 * s/template.h (SIGTYPE): Remove commented out definition.
11489 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11491 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11492 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11494 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11496 * w32.c (read_unc_volume): Use parameter `henum', instead of
11497 global variable `wget_enum_handle'.
11499 * keymap.c (describe_vector): Remove parameters `indices' and
11500 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11501 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11503 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11505 * keyboard.c (timer_check): Remove parameter `do_it_now',
11506 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11507 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11508 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11510 * keyboard.c (read_char):
11511 * w32menu.c (w32_menu_display_help):
11512 * xmenu.c (show_help_event, menu_help_callback):
11513 Adjust calls to `show_help_echo'.
11515 * gtkutil.c (xg_maybe_add_timer):
11516 * keyboard.c (readable_events):
11517 * process.c (wait_reading_process_output):
11518 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11520 * insdel.c (adjust_markers_gap_motion):
11521 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11522 (gap_left, gap_right): Don't call it.
11524 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11526 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11527 incurred during fontification.
11529 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11531 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11532 (DEFVAR_PER_BUFFER): Don't pass it.
11534 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11535 (scrolling_window): Don't pass it.
11537 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11539 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11541 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11543 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11544 of variables specific to SELinux and computation of `encoded_absname'.
11546 * image.c (XPutPixel): Remove unused variable `height'.
11548 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11550 * unexw32.c (get_section_info): Remove unused variable `section'.
11552 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11553 (system_process_attributes): Remove unused variable `sess'.
11554 (sys_read): Remove unused variable `err'.
11556 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11557 (w32_wnd_proc): Remove unused variable `isdead'.
11558 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11559 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11560 (x_create_tip_frame): Remove unused variable `tem'.
11562 * w32inevt.c (w32_console_read_socket):
11563 Remove unused variable `no_events'.
11565 * w32term.c (x_draw_composite_glyph_string_foreground):
11566 Remove unused variable `width'.
11568 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11570 * w32term.c (x_set_glyph_string_clipping):
11571 Don't pass uninitialized region to CombineRgn.
11573 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11575 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11576 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11577 (Fx_close_connection): Remove unused variable `i'.
11579 * w32font.c (w32font_draw): Return number of glyphs.
11580 (w32font_open_internal): Remove unused variable `i'.
11581 (w32font_driver): Add missing initializer.
11583 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11584 (fill_in_menu): Remove unused variable `items_added'.
11586 * w32term.c (last_mouse_press_frame): Remove static global variable.
11587 (w32_clip_to_row): Remove unused variable `f'.
11588 (x_delete_terminal): Remove unused variable `i'.
11590 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11591 (NOTHING): Remove unused static global variable.
11592 (uniscribe_check_otf): Remove unused variable `table'.
11593 (uniscribe_font_driver): Add missing initializers.
11595 2011-03-23 Julien Danjou <julien@danjou.info>
11597 * term.c (Fsuspend_tty, Fresume_tty):
11598 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11599 * window.c (temp_output_buffer_show):
11600 * insdel.c (signal_before_change):
11601 * frame.c (Fhandle_switch_frame):
11602 * fileio.c (Fdo_auto_save):
11603 * emacs.c (Fkill_emacs):
11604 * editfns.c (save_excursion_restore):
11605 * cmds.c (internal_self_insert):
11606 * callint.c (Fcall_interactively):
11607 * buffer.c (Fkill_all_local_variables):
11608 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11610 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11611 unconditionally since it does the check itself.
11613 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11615 Fix more problems found by GCC 4.5.2's static checks.
11617 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11618 the first time through the loop, since we know p0 < p1 then.
11619 This also avoids a gcc -Wstrict-overflow warning.
11621 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11622 leading to a memory leak, possible in functions like
11623 load_charset_map_from_file that can allocate an unbounded number
11624 of objects (Bug#8318).
11626 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11627 that could (at least in theory) be that large.
11629 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11630 This is less likely to overflow, and avoids undefined behavior if
11631 overflow does occur. All callers changed. Use strtoul to scan
11632 for the unsigned long integer.
11633 (pint2hrstr): Simplify and tune code slightly.
11634 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11636 * scroll.c (do_scrolling): Work around GCC bug 48228.
11637 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11639 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11640 This also avoids a warning with gcc -Wstrict-overflow.
11641 (validate_x_resource_name): Simplify count usage.
11642 This also avoids a warning with gcc -Wstrict-overflow.
11644 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11647 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11649 * process.c (Fmake_network_process): Use socklen_t, not int,
11650 where POSIX says socklen_t is required in portable programs.
11651 This fixes a porting bug on hosts like 64-bit HP-UX, where
11652 socklen_t is wider than int (Bug#8277).
11653 (Fmake_network_process, server_accept_connection):
11654 (wait_reading_process_output, read_process_output):
11657 * process.c: Rename or move locals to avoid shadowing.
11658 (list_processes_1, Fmake_network_process):
11659 (read_process_output_error_handler, exec_sentinel_error_handler):
11660 Rename or move locals.
11661 (Fmake_network_process): Define label "retry_connect" only if needed.
11662 (Fnetwork_interface_info): Fix pointer signedness.
11663 (process_send_signal): Add cast to avoid pointer signedness problem.
11664 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11665 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11667 Make tparam.h and terminfo.c consistent.
11668 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11669 Include tparam.h instead, since it declares them.
11670 * cm.h (PC): Remove extern decl; tparam.h now does this.
11671 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11672 * terminfo.c: Include tparam.h, to check interfaces.
11673 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11674 (tparam): Adjust signature to match interface in tparam.h;
11675 this removes some undefined behavior. Check that outstring and len
11676 are zero, which they always are with Emacs.
11677 * tparam.h (PC, BC, UP): New extern decls.
11679 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11680 (xftfont_open): Rename locals to avoid shadowing.
11682 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11683 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11684 (OTF_TAG_SYM): Omit macro if not needed.
11685 (ftfont_list): Remove unused local.
11686 (get_adstyle_property, ftfont_pattern_entity):
11687 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11688 Rename locals to avoid shadowing.
11690 * xfont.c (xfont_list_family): Mark var as initialized.
11692 * xml.c (make_dom): Now static.
11694 * composite.c (composition_compute_stop_pos): Rename local to
11696 (composition_reseat_it): Remove unused locals.
11697 (find_automatic_composition, composition_adjust_point): Likewise.
11698 (composition_update_it): Mark var as initialized.
11699 (find_automatic_composition): Mark vars as initialized,
11700 with a FIXME (Bug#8290).
11702 character.h: Rename locals to avoid shadowing.
11703 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11704 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11705 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11706 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11707 to avoid shadowing.
11709 * textprop.c (property_change_between_p): Remove; unused.
11711 * intervals.c (interval_start_pos): Now static.
11713 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11715 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11716 Rename locals to avoid shadowing.
11718 * sound.c (wav_play, au_play, Fplay_sound_internal):
11719 Fix pointer signedness.
11720 (alsa_choose_format): Remove unused local var.
11721 (wav_play): Initialize a variable to 0, to prevent undefined
11722 behavior (Bug#8278).
11724 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11726 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11728 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11729 clobbering (Bug#8298).
11730 * sysdep.c (sys_subshell): Likewise.
11731 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11733 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11734 This should get cleaned up, so that child_setup has the
11735 same signature on all platforms.
11737 * callproc.c (call_process_cleanup): Now static.
11738 (relocate_fd): Rename locals to avoid shadowing.
11740 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11742 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11743 not to be necessary, and produces flickering.
11745 2011-03-20 Glenn Morris <rgm@gnu.org>
11747 * config.in: Remove file.
11749 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11751 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11752 are now in src/globals.h.
11753 (syms_of_minibuf): Remove spurious & from previous change.
11755 2011-03-20 Leo Liu <sdl.web@gmail.com>
11757 * minibuf.c (completing-read-function): New variable.
11758 (completing-read-default): Rename from completing-read.
11759 (completing-read): Call completing-read-function.
11761 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11763 * xfaces.c (Fx_load_color_file):
11764 Read color file from absolute filename (bug#8250).
11766 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11768 * makefile.w32-in: Update dependencies.
11770 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11772 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11774 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11776 Fix more problems found by GCC 4.5.2's static checks.
11778 * process.c (make_serial_process_unwind, send_process_trap):
11779 (sigchld_handler): Now static.
11781 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11782 That way, the code declares only the vars that it needs.
11783 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11784 * s/cygwin.h (PTY_ITERATION): Likewise.
11785 * s/darwin.h (PTY_ITERATION): Likewise.
11786 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11788 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11789 * process.c (allocate_pty): Don't declare stb unless it's needed.
11791 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11792 (CONSTANTLIM): Remove; unused.
11793 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11794 Define only if needed.
11796 * unexelf.c (unexec): Name an expression,
11797 to avoid gcc -Wbad-function-cast warning.
11798 Use a different way to cause a compilation error if anyone uses
11799 n rather than nn, a way that does not involve shadowing.
11800 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11802 * deps.mk (unexalpha.o): Remove; unused.
11804 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11805 * unexec.h: New file.
11806 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11807 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11808 Depend on unexec.h.
11809 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11810 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11811 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11812 Change as necessary to match prototype in unexec.h.
11814 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11816 (back_comment, skip_chars): Mark vars as initialized.
11818 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11819 Rename locals to avoid shadowing.
11821 * lread.c (read1): Rewrite so as not to use empty "else".
11822 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11824 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11826 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11827 warning when compiling print.c.
11829 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11830 instead of using an uninitialized var.
11831 (font_sort_entities): Mark var as initialized.
11833 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11835 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11836 pointers to constants.
11837 (font_parse_fcname): Remove unused vars.
11838 (font_delete_unmatched): Now static.
11839 (font_get_spec): Remove; unused.
11840 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11841 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11842 Rename or move locals to avoid shadowing.
11844 * fns.c (require_nesting_list, require_unwind): Now static.
11845 (Ffillarray): Rename locals to avoid shadowing.
11847 * floatfns.c (domain_error2): Define only if needed.
11848 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11850 * alloc.c (mark_backtrace): Move decl from here ...
11851 * lisp.h: ... to here, so that it can be checked.
11853 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11854 (Fdefvar): Rewrite so as not to use empty "else".
11855 (lisp_indirect_variable): Name an expression,
11856 to avoid gcc -Wbad-function-cast warning.
11857 (Fdefvar): Rename locals to avoid shadowing.
11859 * callint.c (quotify_arg, quotify_args): Now static.
11860 (Fcall_interactively): Rename locals to avoid shadowing.
11861 Use const pointer when appropriate.
11863 * lisp.h (get_system_name, get_operating_system_release):
11864 Move decls here, to check interfaces.
11865 * process.c (get_operating_system_release): Move decl to lisp.h.
11866 * xrdb.c (get_system_name): Likewise.
11867 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11868 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11869 some of which prompt warnings from gcc -Wbad-function-cast.
11870 (Fformat_time_string, Fencode_time, Finsert_char):
11871 (Ftranslate_region_internal, Fformat):
11872 Rename or remove local vars to avoid shadowing.
11873 (Ftranslate_region_internal): Mark var as initialized.
11875 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11878 * lisp.h (eassert): Check that the argument compiles, even if
11879 ENABLE_CHECKING is not defined.
11881 * data.c (Findirect_variable): Name an expression, to avoid
11882 gcc -Wbad-function-cast warning.
11883 (default_value, arithcompare, arith_driver, arith_error): Now static.
11884 (store_symval_forwarding): Rename local to avoid shadowing.
11885 (Fmake_variable_buffer_local, Fmake_local_variable):
11886 Mark variables as initialized.
11887 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11889 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11890 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11891 Rename locals to avoid shadowing.
11892 (mark_stack): Move local variables into the #ifdef region where
11894 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11895 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11897 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11898 (GC_STRING_CHARS): Remove; not used.
11899 (Fmemory_limit): Cast sbrk's returned value to char *.
11901 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11902 avoids undefined behavior in theory.
11904 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11906 Use functions, not macros, for up- and down-casing (Bug#8254).
11907 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11908 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11909 to use the following functions instead of these macros.
11910 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11911 EMACS_INT, since callers assume the returned value fits in int.
11912 (upcase1): Likewise, for UPCASE_TABLE.
11913 (uppercasep, lowercasep, upcase): New static inline functions.
11914 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11915 the race-condition problem in the old DOWNCASE.
11917 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11918 Rename locals to avoid shadowing.
11919 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11920 (regex_compile, re_search_2, re_match_2_internal):
11921 Remove unused local vars.
11922 (FREE_VAR): Rewrite so as not to use empty "else",
11923 which gcc can warn about.
11924 (regex_compile, re_match_2_internal): Mark locals as initialized.
11925 (RETALLOC_IF): Define only if needed.
11926 (WORDCHAR_P): Likewise. This one is never needed, but is used
11927 only in a comment talking about a compiler bug, so put inside
11928 the #if 0 of that comment.
11929 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11930 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11933 * search.c (boyer_moore): Rename locals to avoid shadowing.
11934 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11935 (PREV_CHAR_BOUNDARY): Likewise.
11937 * search.c (simple_search): Remove unused var.
11939 * dired.c (compile_pattern): Move decl from here ...
11940 * lisp.h: ... to here, so that it can be checked.
11941 (struct re_registers): New forward decl.
11943 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11945 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11947 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11948 Rename locals to avoid shadowing.
11949 (Fvertical_motion): Mark locals as initialized.
11951 * casefiddle.c (casify_object, casify_region): Now static.
11952 (casify_region): Mark local as initialized.
11954 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11956 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11957 New macros, so that the caller can use some names other than
11958 gcpro1, gcpro2, etc.
11959 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11961 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11962 argument, for consistency with GCPRO2_VAR, etc: it is now the
11963 prefix of the variable, not the variable itself. All uses
11965 * dired.c (directory_files_internal, file_name_completion):
11966 Rename locals to avoid shadowing.
11968 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11969 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11970 dired.c's scmp function, had undefined behavior.
11971 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11972 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11973 * buffer.h: ... to here, because these macros use current_buffer,
11974 and the new implementation with inline functions needs to have
11975 current_buffer in scope now, rather than later when the macros
11977 (downcase, upcase1): New static inline functions.
11978 (DOWNCASE, UPCASE1): Reimplement using these functions.
11979 This avoids undefined behavior in expressions like
11980 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11981 from race conditions in accessing the global variables
11982 case_temp1 and case_temp2.
11983 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11984 * lisp.h (case_temp1, case_temp2): Remove their decls.
11985 * character.h (ASCII_CHAR_P): Move from here ...
11986 * lisp.h: ... to here, so that the inline functions mentioned
11987 above can use them.
11989 * dired.c (directory_files_internal_unwind): Now static.
11991 * fileio.c (file_name_as_directory, directory_file_name):
11992 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11994 (file_name_as_directory): Use const pointers when appropriate.
11995 (Fexpand_file_name): Likewise. In particular, newdir might
11996 point at constant storage, so make it a const pointer.
11997 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11998 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12000 (Fset_file_times, Finsert_file_contents, auto_save_error):
12001 Rename locals to avoid shadowing.
12003 * minibuf.c (choose_minibuf_frame_1): Now static.
12004 (Ftry_completion, Fall_completions): Rename or remove locals
12005 to avoid shadowing.
12007 * marker.c (bytepos_to_charpos): Remove; unused.
12009 * lisp.h (verify_bytepos, count_markers): New decls,
12010 so that gcc does not warn that these functions aren't declared.
12012 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12013 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12014 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12015 (copy_text): Remove unused local var.
12017 * filelock.c (within_one_second): Now static.
12018 (lock_file_1): Rename local to avoid shadowing.
12020 * buffer.c (fix_overlays_before): Mark locals as initialized.
12021 (fix_start_end_in_overlays): Likewise. This function should be
12022 simplified by using pointers-to-pointers, but that's a different
12024 (switch_to_buffer_1): Now static.
12025 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12026 (report_overlay_modification): Rename locals to avoid shadowing.
12028 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12029 Fix pointer signedness issue.
12030 (sys_subshell): Mark local as volatile if checking for lint,
12031 to suppress a gcc -Wclobbered warning that does not seem to be right.
12032 (MAXPATHLEN): Define only if needed.
12034 * process.c (serial_open, serial_configure): Move decls from here ...
12035 * systty.h: ... to here, so that they can be checked.
12037 * fns.c (get_random, seed_random): Move extern decls from here ...
12038 * lisp.h: ... to here, so that they can be checked.
12040 * sysdep.c (reset_io): Now static.
12041 (wait_for_termination_signal): Remove; unused.
12043 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12044 (copy_keymap_item, append_key, push_text_char_description):
12046 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12047 (DENSE_TABLE_SIZE): Remove; unused.
12048 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12049 (describe_map_tree):
12050 Rename locals to avoid shadowing.
12052 * keyboard.c: Declare functions static if they are not used elsewhere.
12053 (echo_char, echo_dash, cmd_error, top_level_2):
12054 (poll_for_input, handle_async_input): Now static.
12055 (read_char, kbd_buffer_get_event, make_lispy_position):
12056 (make_lispy_event, make_lispy_movement, apply_modifiers):
12057 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12058 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12059 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12060 (read_key_sequence, read_char): Mark locals as initialized.
12061 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12063 * keyboard.h (make_ctrl_char): New decl.
12064 (mark_kboards): Move decl here ...
12065 * alloc.c (mark_kboards): ... from here.
12067 * lisp.h (force_auto_save_soon): New decl.
12069 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12070 (DEFINE_DUMMY_FUNCTION): New macro.
12071 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12073 (main): Add casts to avoid warnings
12074 if GCC considers string literals to be constants.
12076 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12078 * dbusbind.c: Pointer signedness fixes.
12079 (xd_signature, xd_append_arg, xd_initialize):
12080 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12081 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12082 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12083 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12085 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12086 if GCC considers string literals to be constants.
12087 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12089 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12091 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12092 (print_preprocess, print_object): New macro to fix last change.
12094 * print.c (print_preprocess): Don't forget font objects.
12096 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12098 * emacs.c (USAGE3): Doc fixes.
12100 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12102 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12105 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12107 * lisp.h (VWindow_system, Qfile_name_history):
12108 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12109 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12110 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12112 * w32select.c: Don't #include "keyboard.h".
12113 (run_protected): Add extern declaration for waiting_for_input.
12115 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12116 * w32console.c (detect_input_pending, read_input_pending)
12117 (encode_terminal_code):
12118 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12119 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12120 (w32_system_caret_y, Qfile_name_history):
12121 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12122 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12123 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12124 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12125 * w32proc.c (Qlocal, report_file_error):
12126 * w32term.c (Vwindow_system, updating_frame):
12127 * w32uniscribe.c (initialized, uniscribe_font_driver):
12128 Remove unneeded extern declarations.
12130 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12132 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12134 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12136 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12137 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12138 These macros can no longer be used for assignment.
12140 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12141 Assign struct members directly, instead of using BUF_BEGV etc.
12142 (record_buffer_markers, fetch_buffer_markers): New functions for
12143 recording and fetching special buffer markers.
12144 (set_buffer_internal_1, set_buffer_temp): Use them.
12146 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12148 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12150 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12151 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12153 * xdisp.c (hscroll_window_tree):
12154 (reconsider_clip_changes): Use PT instead of BUF_PT.
12156 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12158 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12159 $(EMACS_ROOT)/lib/intprops.h.
12161 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12163 Fix more problems found by GCC 4.5.2's static checks.
12165 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12166 to unsigned char * to avoid compiler diagnostic.
12167 (xg_free_frame_widgets): Make it clear that a local variable is
12168 needed only if USE_GTK_TOOLTIP.
12169 (gdk_window_get_screen): Make it clear that this macro is needed
12170 only if USE_GTK_TOOLTIP.
12171 (int_gtk_range_get_value): New function, which avoids a diagnostic
12172 from gcc -Wbad-function-cast.
12173 (xg_set_toolkit_scroll_bar_thumb): Use it.
12174 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12175 diagnostic from gcc -Wbad-function-cast.
12176 (get_utf8_string, xg_get_file_with_chooser):
12177 Rename locals to avoid shadowing.
12178 (create_dialog): Move locals to avoid shadowing.
12180 * xgselect.c (xg_select): Remove unused var.
12182 * image.c (four_corners_best): Mark locals as initialized.
12183 (gif_load): Initialize transparent_p to zero (Bug#8238).
12184 Mark another local as initialized.
12185 (my_png_error, my_error_exit): Mark with NO_RETURN.
12187 * image.c (clear_image_cache): Now static.
12188 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12189 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12190 (x_edge_detection): Remove unnecessary cast that
12191 gcc -Wbad-function-cast diagnoses.
12192 (gif_load): Fix pointer signedness.
12193 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12194 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12196 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12198 Improve quality of tests for time stamp overflow.
12199 For example, without this patch (encode-time 0 0 0 1 1
12200 1152921504606846976) returns the obviously-bogus value (-948597
12201 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12202 reports time overflow. See
12203 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12204 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12205 * editfns.c: Include limits.h and intprops.h.
12206 (TIME_T_MIN, TIME_T_MAX): New macros.
12207 (time_overflow): Move earlier, to before first use.
12208 (hi_time, lo_time): New functions, for an accurate test for
12209 out-of-range times.
12210 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12211 (Fget_internal_run_time): Don't assume time_t fits in int.
12212 (make_time): Use list2 instead of Fcons twice.
12213 (Fdecode_time): More accurate test for out-of-range times.
12214 (check_tm_member): New function.
12215 (Fencode_time): Use it, to test for out-of-range times.
12216 (lisp_time_argument): Don't rely on undefined left-shift and
12217 right-shift behavior when checking for time stamp overflow.
12219 * editfns.c (time_overflow): New function, refactoring common code.
12220 (Fformat_time_string, Fdecode_time, Fencode_time):
12221 (Fcurrent_time_string): Use it.
12223 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12224 * dired.c (make_time): Move to ...
12225 * editfns.c (make_time): ... here.
12226 * systime.h: Note the move.
12228 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12230 * fringe.c (update_window_fringes): Remove unused variables.
12232 * unexmacosx.c (copy_data_segment): Also copy __got section.
12235 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12237 * termcap.c [MSDOS]: Include "msdos.h".
12238 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12239 Constify `char *' arguments and their references according to
12240 prototypes in tparam.h.
12242 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12244 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12245 Adapt all references accordingly.
12247 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12249 2011-03-11 Tom Tromey <tromey@redhat.com>
12251 * buffer.c (syms_of_buffer): Remove obsolete comment.
12253 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12255 * termhooks.h (encode_terminal_code): Declare prototype.
12257 * msdos.c (encode_terminal_code): Don't declare prototype.
12259 * term.c (encode_terminal_code): Now external again, used by
12260 w32console.c and msdos.c.
12262 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12263 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12265 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12267 Fix some minor problems found by GCC 4.5.2's static checks.
12269 * fringe.c (update_window_fringes): Mark locals as initialized
12271 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12273 * alloc.c (mark_fringe_data): Move decl from here ...
12274 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12275 to check its interface.
12276 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12278 * fontset.c (free_realized_fontset): Now static.
12279 (Fset_fontset_font): Rename local to avoid shadowing.
12280 (fontset_font): Mark local as initialized.
12281 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12283 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12285 * xselect.c (x_disown_buffer_selections): Remove; not used.
12286 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12287 (x_own_selection, Fx_disown_selection_internal): Rename locals
12288 to avoid shadowing.
12289 (x_handle_dnd_message): Remove local to avoid shadowing.
12291 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12292 so that the caller can use some name other than gcpro1.
12293 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12294 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12295 (Fx_backspace_delete_keys_p):
12296 Use them to avoid shadowing, and rename vars to avoid shadowing.
12297 (x_decode_color, x_set_name, x_window): Now static.
12298 (Fx_create_frame): Add braces to silence GCC warning.
12299 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12300 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12301 Remove unused locals.
12302 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12303 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12304 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12307 * xterm.h (x_mouse_leave): New decl.
12309 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12310 Remove unused functions.
12311 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12312 (x_calc_absolute_position): Now static.
12313 (XTread_socket): Don't define label "out" unless it's used.
12314 Don't declare local "event" unless it's used.
12315 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12316 unless they are used.
12317 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12318 (x_fatal_error_signal): Remove; not used.
12319 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12320 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12321 (x_error_catcher, x_connection_closed, x_error_handler):
12322 (x_error_quitter, xembed_send_message, x_iconify_frame):
12323 (my_log_handler): Rename locals to avoid shadowing.
12324 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12325 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12327 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12328 Rename or move locals to avoid shadowing.
12329 (tty_defined_color, merge_face_heights): Now static.
12330 (free_realized_faces_for_fontset): Remove; not used.
12331 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12332 does not deduce is never used uninitialized.
12333 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12334 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12336 * terminal.c (store_terminal_param): Now static.
12338 * xmenu.c (menu_highlight_callback): Now static.
12339 (set_frame_menubar): Remove unused local.
12340 (xmenu_show): Rename parameter to avoid shadowing.
12341 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12342 since they might point to immutable storage.
12343 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12344 since it's unused otherwise.
12346 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12347 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12348 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12349 avoids a gcc -Wuninitialized diagnostic.
12350 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12351 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12352 does not deduce are never used uninitialized.
12354 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12356 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12357 * window.c (window_loop, size_window):
12358 (run_window_configuration_change_hook, enlarge_window): Likewise.
12360 * window.c (display_buffer): Now static.
12361 (size_window): Mark variables that gcc -Wuninitialized
12362 does not deduce are never used uninitialized.
12363 * window.h (check_all_windows): New decl, to forestall
12364 gcc -Wmissing-prototypes diagnostic.
12365 * dispextern.h (bidi_dump_cached_states): Likewise.
12367 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12369 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12370 Include <limits.h>.
12371 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12372 and to avoid gcc -Wuninitialized warning.
12373 (load_charset_map): Mark variables that gcc -Wuninitialized
12374 does not deduce are never used uninitialized.
12375 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12377 * coding.c (coding_set_source, coding_set_destination):
12378 Use "else { /* comment */ }" rather than "else /* comment */;"
12379 for clarity, and to avoid gcc -Wempty-body warning.
12380 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12381 a block, when the outer 'i' will do.
12382 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12383 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12384 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12385 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12386 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12387 Rename locals to avoid shadowing.
12388 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12389 * coding.c (emacs_mule_char, encode_invocation_designation):
12390 Now static, since they're not used elsewhere.
12391 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12392 (decode_coding_object, encode_coding_object, detect_coding_system):
12393 (decode_coding_emacs_mule): Mark variables that gcc
12394 -Wuninitialized does not deduce are never used uninitialized.
12395 (detect_coding_iso_2022): Initialize a local variable that might
12396 be used uninitialized. Leave a FIXME because it's not clear that
12397 this initialization is needed. (Bug#8211)
12398 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12399 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12400 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12401 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12402 Remove unused macros.
12404 * category.c (hash_get_category_set): Remove unused local var.
12405 (copy_category_table): Now static, since it's not used elsewhere.
12406 * character.c (string_count_byte8): Likewise.
12408 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12409 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12411 * chartab.c (copy_sub_char_table): Now static, since it's not used
12413 (sub_char_table_ref_and_range, char_table_ref_and_range):
12414 Rename locals to avoid shadowing.
12415 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12417 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12418 (BIDI_BOB): Remove unused macro.
12420 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12421 deduce are never used uninitialized.
12422 * term.c (encode_terminal_code): Likewise.
12424 * term.c (encode_terminal_code): Now static. Remove unused local.
12426 * tparam.h: New file.
12427 * term.c, tparam.h: Include it.
12428 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12429 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12430 Move these decls to tparam.h, and make them agree with what
12431 is actually in tparam.c. The previous trick of using incompatible
12432 decls in different modules does not conform to the C standard.
12433 All callers of tparam changed to use tparam's actual API.
12434 * tparam.c (tparam1, tparam, tgoto):
12435 Use const pointers where appropriate.
12437 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12438 * cm.h (struct cm): Likewise.
12439 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12440 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12441 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12442 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12443 (turn_on_face, init_tty): Likewise.
12444 * termchar.h (struct tty_display_info): Likewise.
12446 * term.c (term_mouse_position): Rename local to avoid shadowing.
12448 * alloc.c (mark_ttys): Move decl from here ...
12449 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12451 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12453 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12455 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12457 * search.c (compile_pattern_1): Remove argument regp, unused since
12458 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12459 (compile_pattern): Don't pass it.
12461 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12463 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12464 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12466 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12468 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12470 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12471 gdk_window_get_screen, gdk_window_get_geometry,
12472 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12473 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12474 (xg_get_pixbuf_from_pixmap): New function.
12475 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12476 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12477 Call xg_get_pixbuf_from_pixmap instead of
12478 gdk_pixbuf_get_from_drawable.
12479 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12480 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12481 (xg_check_special_colors): Use GtkStyleContext and its functions
12483 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12484 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12485 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12486 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12487 Call gtk_widget_get_preferred_size.
12488 (xg_frame_resized): gdk_window_get_geometry only takes 5
12490 (xg_win_to_widget, xg_event_is_for_menubar):
12491 Call gdk_x11_window_lookup_for_display.
12492 (xg_set_widget_bg): New function.
12493 (delete_cb): New function.
12494 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12495 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12496 (xg_set_background_color): Call xg_set_widget_bg.
12497 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12498 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12499 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12500 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12502 (update_frame_tool_bar): Call gtk_widget_hide.
12503 (xg_initialize): Use GDK_KEY_g.
12505 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12507 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12509 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12510 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12511 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12513 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12515 * w32xfns.c (select_palette): Check success of RealizePalette against
12516 GDI_ERROR, not zero.
12518 See ChangeLog.11 for earlier changes.
12520 ;; Local Variables:
12524 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12526 This file is part of GNU Emacs.
12528 GNU Emacs is free software: you can redistribute it and/or modify
12529 it under the terms of the GNU General Public License as published by
12530 the Free Software Foundation, either version 3 of the License, or
12531 (at your option) any later version.
12533 GNU Emacs is distributed in the hope that it will be useful,
12534 but WITHOUT ANY WARRANTY; without even the implied warranty of
12535 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12536 GNU General Public License for more details.
12538 You should have received a copy of the GNU General Public License
12539 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.