1 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4 symbol character follows.
6 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9 This works around a problem with the previous change to Fcopy_file.
10 Recent glibc declares fchown with __attribute__((warn_unused_result)),
11 and without this change, GCC might complain about discarding
12 fchown's return value.
14 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
16 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
18 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
20 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
22 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
24 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
25 it's used from the C level.
27 * process.c: Use the same condition for POLL_FOR_INPUT in both
28 keyboard.c and process.c (bug#1858).
30 2011-07-09 Lawrence Mitchell <wence@gmx.li>
32 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
33 (Fgnutls_boot): Use it.
35 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
37 * doc.c (Fsubstitute_command_keys): Revert last change.
39 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
41 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
42 quotes the next character, and doesn't affect other longer
45 * lread.c (syms_of_lread): Clarify that is isn't only
46 `eval-buffer' and `eval-defun' that's affected by
47 `lexical-binding' (bug#8460).
49 2011-07-15 Eli Zaretskii <eliz@gnu.org>
51 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
52 bidi redisplay when a line includes both an image and is
55 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
57 Fix minor problems found by static checking.
58 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
59 (elsz): Now a signed constant, not a size_t var. We prefer signed
60 types to unsigned, to avoid integer comparison confusion. Without
61 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
62 "cannot optimize loop, the loop counter may overflow", a symptom
64 * indent.c (Fvertical_motion): Mark locals as initialized.
65 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
67 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
69 * search.c (Fre_search_backward): Mention `case-fold-search' in
70 all the re_search_* functions (bug#8138).
72 * keyboard.c (Fopen_dribble_file): Document when the file is
75 2011-07-14 Eli Zaretskii <eliz@gnu.org>
77 * bidi.c (bidi_dump_cached_states): Fix format of displaying
80 Support bidi reordering of display and overlay strings.
81 * xdisp.c (compute_display_string_pos)
82 (compute_display_string_end): Accept additional argument STRING.
83 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
84 (reseat_to_string): Initialize bidi_it->string.s and
85 bidi_it->string.schars.
86 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
87 NULL (avoids a crash in bidi_paragraph_init). Initialize
89 (init_iterator): Call bidi_init_it only of a valid
90 buffer position was specified. Initialize paragraph_embedding to
92 (reseat_to_string): Initialize the bidi iterator.
93 (display_string): If we need to ignore text properties of
94 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
95 original value of -1 will not work with bidi.)
96 (compute_display_string_pos): First arg is now struct
97 `text_pos *'; all callers changed. Support display properties on
99 (compute_display_string_end): Support display properties on Lisp
101 (init_iterator, reseat_1, reseat_to_string): Initialize the
102 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
103 when iterating on a string not from display properties).
104 (compute_display_string_pos, compute_display_string_end): Fix
105 calculation of the object to scan. Fixes an error when using
107 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
108 base_level_stop; instead, set base_level_stop to BEGV. Fixes
109 crashes in vertical-motion.
110 (next_element_from_buffer): Improve commentary for when
111 the iterator is before prev_stop.
112 (init_iterator): Initialize bidi_p from the default value of
113 bidi-display-reordering, not from buffer-local value. Use the
114 buffer-local value only if initializing for buffer iteration.
115 (handle_invisible_prop): Support invisible properties on strings
116 that are being bidi-reordered.
117 (set_iterator_to_next): Support bidi reordering of C strings and
119 (next_element_from_string): Support bidi reordering of Lisp
121 (handle_stop_backwards): Support Lisp strings as well.
122 (display_string): Support display of R2L glyph rows. Use
123 IT_STRING_CHARPOS when displaying from a Lisp string.
124 (init_iterator): Don't initialize it->bidi_p for strings
126 (reseat_to_string): Initialize it->bidi_p for strings here.
127 (next_element_from_string, next_element_from_c_string)
128 (next_element_from_buffer): Add xassert's for correspondence
129 between IT's object being iterated and it->bidi_it.string
131 (face_before_or_after_it_pos): Support bidi iteration.
132 (next_element_from_c_string): Handle the case of the first string
133 character that is not the first one in the visual order.
134 (get_visually_first_element): New function, refactored from common
135 parts of next_element_from_buffer, next_element_from_string, and
136 next_element_from_c_string.
137 (tool_bar_lines_needed, redisplay_tool_bar)
138 (display_menu_bar): Force left-to-right direction. Add a FIXME
139 comment for making that be controlled by a user option.
140 (push_it, pop_it): Save and restore the state of the
141 bidi iterator. Save and restore the bidi_p flag.
142 (pop_it): Iterate out of display property for string iteration as
144 (iterate_out_of_display_property): Support iteration over strings.
145 (handle_single_display_spec): Set up it->bidi_it for iteration
146 over a display string, and call bidi_init_it.
147 (handle_single_display_spec, next_overlay_string)
148 (get_overlay_strings_1, push_display_prop): Set up the bidi
149 iterator for displaying display or overlay strings.
150 (forward_to_next_line_start): Don't use the shortcut if
152 (back_to_previous_visible_line_start): If handle_display_prop
153 pushed the iterator stack, restore the internal state of the bidi
154 iterator by calling bidi_pop_it same number of times.
155 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
156 and we are bidi-iterating, don't decrement the iterator position;
157 instead, set the first_elt flag in the bidi iterator, to produce
159 (reseat_1): Remove redundant setting of string_from_display_prop_p.
160 (push_display_prop): xassert that we are iterating a buffer.
161 (push_it, pop_it): Save and restore paragraph_embedding member.
162 (handle_single_display_spec, next_overlay_string)
163 (get_overlay_strings_1, reseat_1, reseat_to_string)
164 (push_display_prop): Set up the `unibyte' member of bidi_it.string
165 correctly. Don't assume unibyte strings are not bidi-reordered.
166 (compute_display_string_pos)
167 (compute_display_string_end): Fix handling the case of C string.
168 (push_it, pop_it): Save and restore from_disp_prop_p.
169 (handle_single_display_spec, push_display_prop): Set the
170 from_disp_prop_p flag.
171 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
172 (pop_it): Call iterate_out_of_display_property only if we are
173 popping after iteration over a string that came from a display
174 property. Fix a typo in popping stretch info. Add an assertion
175 for verifying that the iterator position is in sync with the bidi
177 (handle_single_display_spec, get_overlay_strings_1)
178 (push_display_prop): Fix initialization of paragraph direction for
179 string when that of the parent object is not yet determined.
180 (reseat_1): Call bidi_init_it to resync the bidi
181 iterator with IT's position. (Bug#7616)
182 (find_row_edges): If ROW->start.pos gives position
183 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
184 (handle_stop, back_to_previous_visible_line_start, reseat_1):
185 Reset the from_disp_prop_p flag.
186 (SAVE_IT, RESTORE_IT): New macros.
187 (pos_visible_p, face_before_or_after_it_pos)
188 (back_to_previous_visible_line_start)
189 (move_it_in_display_line_to, move_it_in_display_line)
190 (move_it_to, move_it_vertically_backward, move_it_by_lines)
191 (try_scrolling, redisplay_window, display_line): Use them when
192 saving a temporary copy of the iterator and restoring it back.
193 (back_to_previous_visible_line_start, reseat_1)
194 (init_iterator): Empty the bidi cache "stack".
195 (move_it_in_display_line_to): If iterator ended up at
196 EOL, but we never saw any buffer positions smaller than
197 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
198 motion in bidi-reordered lines.
199 (move_it_in_display_line_to): Record prev_method and prev_pos
200 immediately before the call to set_iterator_to_next. Fixes cursor
201 motion in bidi-reordered lines with stretch glyphs and strings
202 displayed in margins. (Bug#8133) (Bug#8867)
203 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
205 (pos_visible_p): Support positions in bidi-reordered lines. Save
206 and restore bidi cache.
208 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
209 (bidi_paragraph_info): Delete unused struct.
210 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
211 (bidi_cache_start): New variable.
212 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
214 (bidi_cache_fetch_state, bidi_cache_search)
215 (bidi_cache_find_level_change, bidi_cache_iterator_state)
216 (bidi_cache_find, bidi_peek_at_next_level)
217 (bidi_level_of_next_char, bidi_find_other_level_edge)
218 (bidi_move_to_visually_next): Compare cache index with
219 bidi_cache_start rather than with zero.
220 (bidi_fetch_char): Accept new argument STRING; all callers
221 changed. Support iteration over a string. Support strings with
222 display properties. Support unibyte strings. Fix the type of
223 `len' according to what STRING_CHAR_AND_LENGTH expects.
224 (bidi_paragraph_init, bidi_resolve_explicit_1)
225 (bidi_resolve_explicit, bidi_resolve_weak)
226 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
227 iteration over a string.
228 (bidi_set_sor_type, bidi_resolve_explicit_1)
229 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
230 can now be zero (for strings); special values 0 and -1 were
231 changed to -1 and -2, respectively.
232 (bidi_char_at_pos): New function.
233 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
234 Call it instead of FETCH_MULTIBYTE_CHAR.
235 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
236 initialized to valid values.
237 (bidi_init_it): Don't initialize charpos and bytepos with invalid
239 (bidi_level_of_next_char): Allow the sentinel "position" to pass
240 the test for valid cached positions. Fix the logic for looking up
241 the sentinel state in the cache. GCPRO the Lisp string we are
243 (bidi_push_it, bidi_pop_it): New functions.
244 (bidi_initialize): Initialize the bidi cache start stack pointer.
245 (bidi_cache_ensure_space): New function, refactored from part of
246 bidi_cache_iterator_state. Don't assume the required size is just
247 one BIDI_CACHE_CHUNK away.
248 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
249 (bidi_count_bytes, bidi_char_at_pos): New functions.
250 (bidi_cache_search): Don't assume bidi_cache_last_idx is
251 always valid if bidi_cache_idx is valid.
252 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
253 is valid if it's going to be used.
254 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
255 (bidi_cache_fetch_state, bidi_cache_search)
256 (bidi_cache_find_level_change, bidi_cache_ensure_space)
257 (bidi_cache_iterator_state, bidi_cache_find)
258 (bidi_find_other_level_edge, bidi_cache_start_stack): All
259 variables related to cache indices are now EMACS_INT.
261 * dispextern.h (struct bidi_string_data): New structure.
262 (struct bidi_it): New member `string'. Make flag members be 1-bit
263 fields, and put them last in the struct.
264 (compute_display_string_pos, compute_display_string_end): Update
266 (bidi_push_it, bidi_pop_it): Add prototypes.
267 (struct iterator_stack_entry): New members bidi_p,
268 paragraph_embedding, and from_disp_prop_p.
269 (struct it): Member bidi_p is now a bit field 1 bit wide.
270 (bidi_shelve_cache, bidi_unshelve_cache): Declare
273 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
274 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
275 and vector-like objects.
277 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
278 cache around display iteration.
280 * window.c (Fwindow_end, window_scroll_pixel_based)
281 (displayed_window_lines, Frecenter): Save and restore the bidi
282 cache around display iteration.
284 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
286 * editfns.c (Fdelete_region): Clarify the use of the named
287 parameters (bug#6788).
289 2011-07-14 Martin Rudalics <rudalics@gmx.at>
291 * indent.c (Fvertical_motion): Set and restore w->pointm when
292 saving and restoring the window's buffer (Bug#9006).
294 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
296 * editfns.c (Fstring_to_char): Clarify just what is returned
297 (bug#6576). Text by Eli Zaretskii.
299 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
301 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
303 2011-07-13 Eli Zaretskii <eliz@gnu.org>
305 * buffer.c (mmap_find): Fix a typo.
307 2011-07-13 Johan Bockgård <bojohan@gnu.org>
309 Fix execution of x selection hooks.
310 * xselect.c (Qx_lost_selection_functions)
311 (Qx_sent_selection_functions): New vars.
312 (syms_of_xselect): DEFSYM them.
313 (x_handle_selection_request): Pass Qx_sent_selection_functions
314 rather than Vx_sent_selection_functions to Frun_hook_with_args.
315 (x_handle_selection_clear,x_clear_frame_selections):
316 Pass Qx_lost_selection_functions rather than
317 Vx_lost_selection_functions to Frun_hook_with_args.
319 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
321 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
322 The old code sometimes used this field without initializing it.
324 * alloc.c (gc_sweep): Don't read past end of array.
325 In theory, the old code could also have corrupted Emacs internals,
326 though it'd be very unlikely.
328 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
330 * character.c (Fcharacterp): Don't advertise optional ignored
333 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
335 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
338 * window.c (Fset_window_start): Doc fix (bug#4199).
339 (Fset_window_hscroll): Ditto.
341 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
343 Fix minor new problems caught by GCC 4.6.1.
344 * term.c (init_tty): Remove unused local.
345 * xsettings.c (store_monospaced_changed): Define this function only
346 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
349 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
351 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
353 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
355 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
356 are the mini-buffer and the echo area (bug#3320).
358 * term.c (init_tty): Remove support for supdup, c10 and perq
359 terminals, which are no longer supported (bug#1482).
361 2011-07-10 Johan Bockgård <bojohan@gnu.org>
363 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
365 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
367 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
368 for non-popups (Bug#3642).
370 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
372 * alloc.c (reset_malloc_hooks): Protoize.
373 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
374 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
375 * cm.c (losecursor): Likewise.
376 * data.c (fmod): Likewise.
377 * dispnew.c (swap_glyphs_in_rows): Likewise.
378 * emacs.c (memory_warning_signal): Likewise.
379 * floatfns.c (float_error): Likewise.
380 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
381 (otf_open, font_otf_capability, generate_otf_features)
382 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
384 * image.c (pbm_read_file): Likewise.
385 * indent.c (string_display_width): Likewise.
386 * intervals.c (check_for_interval, search_for_interval)
387 (inc_interval_count, count_intervals, root_interval)
388 (adjust_intervals_for_insertion, make_new_interval): Likewise.
389 * lread.c (defalias): Likewise.
390 * ralloc.c (r_alloc_check): Likewise.
391 * regex.c (set_image_of_range_1, set_image_of_range)
392 (regex_grow_registers): Likewise.
393 * sysdep.c (strerror): Likewise.
394 * termcap.c (valid_filename_p, tprint, main): Likewise.
395 * tparam.c (main): Likewise.
396 * unexhp9k800.c (run_time_remap, save_data_space)
397 (update_file_ptrs, read_header, write_header, calculate_checksum)
398 (copy_file, copy_rest, display_header): Likewise.
399 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
401 * xdisp.c (check_it): Likewise.
402 * xfaces.c (register_color, unregister_color, unregister_colors):
404 * xfns.c (print_fontset_result): Likewise.
405 * xrdb.c (member, fatal, main): Likewise.
407 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
409 Fix minor problems found by static checking (Bug#9031).
410 * chartab.c (char_table_set_range, map_sub_char_table):
411 Remove unused locals.
412 (uniprop_table): Now static.
413 * composite.c (_work_char): Remove unused static var.
415 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
417 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
419 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
421 * gtkutil.c (qttip_cb): Remove code without function.
423 2011-07-09 Eli Zaretskii <eliz@gnu.org>
425 * w32.c (pthread_sigmask): New stub.
427 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
429 Use pthread_sigmask, not sigprocmask (Bug#9010).
430 sigprocmask is portable only for single-threaded applications, and
431 Emacs can be multi-threaded when it uses GTK.
432 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
434 * callproc.c (Fcall_process):
435 * process.c (create_process):
436 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
437 Use pthread_sigmask, not sigprocmask.
439 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
441 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
442 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
445 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
447 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
448 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
449 (xg_hide_tooltip): Fix comment.
451 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
452 in registerServicesMenuSendTypes.
453 (validRequestorForSendType): Don't check ns_return_types.
455 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
458 2011-07-08 Jason Rumney <jasonr@gnu.org>
460 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
461 frame struct members of non-existent frames (Bug#6284).
463 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
465 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
466 variable firstTime not needed on OSX >= 10.6.
467 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
468 >= 10.5. Use setKnobProportion, setDoubleValue.
470 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
471 (MAC_OS_X_VERSION_10_5): Define if not defined.
472 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
473 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
474 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
476 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
477 cString and lossyCString on OSX >= 10.4
479 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
480 sizeToFit on OSX >= 10.2.
482 * nsimage.m (allocInitFromFile): Don't use deprecated method
483 bestRepresentationForDevice on OSX >= 10.6.
485 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
488 * emacs.c: Declare unexec_init_emacs_zone.
490 * nsgui.h: Fix compiler warning about gnulib redefining verify.
492 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
494 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
495 on svcsMenu (Bug#8842).
497 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
499 (Fns_list_services): Just return Qnil on 10.6, code not working there.
501 * nsterm.m (QUTF8_STRING): Declare.
502 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
503 (validRequestorForSendType): Return type is (id).
504 Change indexOfObjectIdenticalTo to indexOfObject.
505 Check if we have local selection before returning self (Bug#8842).
506 (writeSelectionToPasteboard): Put local selection into paste board
507 if we have a local selection (Bug#8842).
508 (syms_of_nsterm): DEFSYM QUTF8_STRING.
510 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
511 (ns_get_local_selection): Declare.
513 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
515 * keymap.c (describe_map_tree): Don't insert a double newline at
516 the end of the buffer (bug#1169) and return whether we inserted
519 * callint.c (Fcall_interactively): Change "reading args" to
520 "providing args" to try to clarify what it does (bug#1010).
522 2011-07-07 Kenichi Handa <handa@m17n.org>
524 * composite.c (composition_compute_stop_pos): Ignore a static
525 composition starting before CHARPOS (Bug#8915).
527 * xdisp.c (handle_composition_prop): Likewise.
529 2011-07-07 Eli Zaretskii <eliz@gnu.org>
531 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
534 2011-07-07 Kenichi Handa <handa@m17n.org>
536 * character.h (unicode_category_t): New enum type.
538 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
539 (Qchar_code_property_table): New variable.
540 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
541 (UNIPROP_COMPRESSED_FORM_P): New macros.
542 (char_table_ascii): Uncompress the compressed values.
543 (sub_char_table_ref): New arg is_uniprop. Callers changed.
544 Uncompress the compressed values.
545 (sub_char_table_ref_and_range): Likewise.
546 (char_table_ref_and_range): Uncompress the compressed values.
547 (sub_char_table_set): New arg is_uniprop. Callers changed.
548 Uncompress the compressed values.
549 (sub_char_table_set_range): Args changed. Callers changed.
550 (char_table_set_range): Adjuted for the above change.
551 (map_sub_char_table): Delete args default_val and parent. Add arg
552 top. Give decoded values to a Lisp function.
553 (map_char_table): Adjusted for the above change. Give decoded
554 values to a Lisp function. Gcpro more variables.
555 (uniprop_table_uncompress)
556 (uniprop_decode_value_run_length): New functions.
557 (uniprop_decoder, uniprop_decoder_count): New variables.
558 (uniprop_get_decoder, uniprop_encode_value_character)
559 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
561 (uniprop_encoder, uniprop_encoder_count): New variables.
562 (uniprop_get_encoder, uniprop_table)
563 (Funicode_property_table_internal, Fget_unicode_property_internal)
564 (Fput_unicode_property_internal): New functions.
565 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
566 Sunicode_property_table_internal, Sget_unicode_property_internal,
567 and Sput_unicode_property_internal. Defvar_lisp
568 char-code-property-alist.
570 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
571 Vunicode_category_table.
573 * font.c (font_range): Adjusted for the change of
574 Vunicode_category_table.
576 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
578 * m/iris4d.h: Remove file, move contents ...
579 * s/irix6-5.h: ... here.
581 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
583 Remove unportable assumption about struct layout (Bug#8884).
584 * alloc.c (mark_buffer):
585 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
586 (clone_per_buffer_values): Don't assume that
587 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
588 This isn't true in general, and it's particularly not true
589 if Emacs is configured with --with-wide-int.
590 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
591 New macros, used in the buffer.c change.
593 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
595 * xsettings.c: Use both GConf and GSettings if both are available.
596 (store_config_changed_event): Add comment.
597 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
598 (store_tool_bar_style_changed): New functions.
599 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
600 (struct xsettings): Move font inside HAVE_XFT.
601 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
602 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
603 Move inside HAVE_XFT.
604 (something_changed_gsettingsCB): Renamed from something_changedCB.
605 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
607 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
608 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
609 (something_changed_gconfCB): Renamed from something_changedCB.
610 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
611 (parse_settings): Move check for font inside HAVE_XFT.
612 (read_settings, apply_xft_settings): Add comment.
613 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
614 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
615 call store_font_name_changed.
616 (xft_settings_event): Add comment.
617 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
618 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
619 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
620 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
621 (xsettings_initialize): Call init_gsettings last.
622 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
625 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
627 Random fixes. E.g., (random) never returned negative values.
628 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
629 subseconds part to the entropy, as that's a bit more random.
630 Prefer signed to unsigned, since the signedness doesn't matter and
631 in general we prefer signed. When given a limit, use a
632 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
633 latter isn't right if USE_2_TAGS_FOR_INTS.
634 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
635 not 0..VALMASK. Don't discard "excess" bits that random () returns.
637 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
639 * textprop.c (text_property_stickiness):
640 Obey Vtext_property_default_nonsticky.
641 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
642 * w32fns.c (syms_of_w32fns):
643 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
645 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
647 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
648 This is more efficient than Ffile_directory_p and avoids a minor race.
650 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
652 * buffer.c (Foverlay_put): Say what the return value is
655 * fileio.c (barf_or_query_if_file_exists): Check first if the file
656 is a directory before asking whether to use the file name
658 (barf_or_query_if_file_exists): Make the "File is a directory"
659 error be more correct.
661 * fns.c (Frequire): Remove the mention of the .gz files, since
662 that's installation-specific, but keep the mention of
665 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
667 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
668 Report string overflow if the output is too long.
670 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
672 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
673 (syms_of_gnutls): Remove duplicate DEFSYM for
674 Qgnutls_bootprop_verify_hostname_error, an error for
675 Qgnutls_bootprop_verify_error (which is no longer used).
677 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
678 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
679 Also (re)move comments that are misplaced or no longer relevant.
681 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
683 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
685 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
687 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
688 and background color parameters if they have been changed.
690 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
692 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
694 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
696 * xsettings.c (SYSTEM_FONT): Define only when used.
697 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
699 * keymap.c (access_keymap_1): Now static.
701 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
703 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
704 leave any prefix arg for the up event (Bug#1586).
706 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
708 * lread.c (syms_of_lread): Mention single symbols defined by
709 `defvar' or `defconst' (bug#7154).
711 * fns.c (Frequire): Mention .el.gz files (bug#7314).
712 (Frequire): Mention get-load-suffixes.
714 2011-07-02 Martin Rudalics <rudalics@gmx.at>
716 * window.h (window): Remove clone_number slot.
717 * window.c (Fwindow_clone_number, Fset_window_clone_number):
719 (make_parent_window, make_window, saved_window)
720 (Fset_window_configuration, save_window_save): Don't deal with
722 * buffer.c (Qclone_number): Remove declaration.
723 (sort_overlays, overlay_strings): Don't deal with clone numbers.
725 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
727 Add multiple inheritance to keymaps.
728 * keymap.c (Fmake_composed_keymap): New function.
729 (Fset_keymap_parent): Simplify.
730 (fix_submap_inheritance): Remove.
731 (access_keymap_1): New function extracted from access_keymap to handle
732 embedded parents and handle lists of maps.
733 (access_keymap): Use it.
734 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
735 (Fcopy_keymap): Handle embedded parents.
736 (Fcommand_remapping, define_as_prefix): Simplify.
737 (Fkey_binding): Simplify.
738 (syms_of_keymap): Move minibuffer-local-completion-map,
739 minibuffer-local-filename-completion-map,
740 minibuffer-local-must-match-map, and
741 minibuffer-local-filename-must-match-map to Elisp.
742 (syms_of_keymap): Defsubr make-composed-keymap.
743 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
744 (parse_menu_item): Trivial simplification.
746 2011-07-01 Glenn Morris <rgm@gnu.org>
748 * Makefile.in (SETTINGS_LIBS): Fix typo.
750 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
752 * coding.c (Fencode_coding_string): Record the last coding system
753 used, as the function doc string says (bug#8738).
755 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
757 * xsettings.c (store_monospaced_changed): Take new font as arg and
758 check for change against current_mono_font.
759 (EMACS_TYPE_SETTINGS): Remove this and related defines.
760 (emacs_settings_constructor, emacs_settings_get_property)
761 (emacs_settings_set_property, emacs_settings_class_init)
762 (emacs_settings_init, gsettings_obj): Remove.
763 (something_changedCB): New function for HAVE_GSETTINGS.
764 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
765 with value as argument.
766 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
767 g_settings_new (Bug#8967). Do not create gsettings_obj.
768 Remove calls to g_settings_bind. Connect something_changedCB to
771 * xgselect.c: Add defined (HAVE_GSETTINGS).
772 (xgselect_initialize): Ditto.
774 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
775 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
778 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
780 * eval.c (struct backtrace): Simplify and port the data structure.
781 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
782 signed bit field, as this assumption is not portable and it makes
783 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
784 "char debug_on_exit : 1" as this is not portable either; instead,
785 use the portable "unsigned int debug_on_exit : 1". Remove unused
786 member evalargs. Remove obsolete comments about cc bombing out.
788 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
790 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
791 Let HAVE_GSETTINGS override HAVE_GCONF.
792 (store_monospaced_changed): New function.
793 (EMACS_SETTINGS): A new type derived from GObject to handle
794 GSettings notifications.
795 (emacs_settings_constructor, emacs_settings_get_property)
796 (emacs_settings_set_property, emacs_settings_class_init):
798 (gsettings_client, gsettings_obj): New variables.
799 (GSETTINGS_SCHEMA): New define.
800 (something_changedCB): Call store_monospaced_changed.
801 (init_gsettings): New function.
802 (xsettings_initialize): Call init_gsettings.
803 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
806 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
809 2011-06-29 Martin Rudalics <rudalics@gmx.at>
811 * window.c (resize_root_window, grow_mini_window)
812 (shrink_mini_window): Rename Qresize_root_window to
813 Qwindow_resize_root_window and Qresize_root_window_vertically to
814 Qwindow_resize_root_window_vertically.
816 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
818 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
820 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
822 * makefile.w32-in: Redesign dependencies so they reflect more
823 clearly which files are directly included by each source file,
824 and not through other includes.
826 2011-06-27 Martin Rudalics <rudalics@gmx.at>
828 * buffer.c (Qclone_number): Declare static and DEFSYM it.
829 (sort_overlays, overlay_strings): When an overlay's clone number
830 matches the window's clone number process the overlay even if
831 the overlay's window property doesn't match the current window.
833 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
834 (Fwindow_hchild): Rename to Fwindow_left_child.
835 (Fwindow_next): Rename to Fwindow_next_sibling.
836 (Fwindow_prev): Rename to Fwindow_prev_sibling.
837 (resize_window_check): Rename to window_resize_check.
838 (resize_window_apply): Rename to window_resize_apply.
839 (Fresize_window_apply): Rename to Fwindow_resize_apply.
840 (Fdelete_other_windows_internal, resize_frame_windows)
841 (Fsplit_window_internal, Fdelete_window_internal)
842 (grow_mini_window, shrink_mini_window)
843 (Fresize_mini_window_internal): Fix callers accordingly.
845 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
847 * emacsgtkfixed.h: State that this is only used with Gtk+3.
848 (emacs_fixed_set_min_size): Remove.
849 (emacs_fixed_new): Take frame as argument.
851 * emacsgtkfixed.c: State that this is only used with Gtk+3.
852 (_EmacsFixedPrivate): Remove minwidth/height.
854 (emacs_fixed_init): Initialize priv->f.
855 (get_parent_class, emacs_fixed_set_min_size): Remove.
856 (emacs_fixed_new): Set priv->f to argument.
857 (emacs_fixed_get_preferred_width)
858 (emacs_fixed_get_preferred_height): Use min_width/height from
859 frames size_hint to set minimum and natural (Bug#8919).
860 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
861 and use min_width/height from frames size_hint to set
862 min_width/height (Bug#8919).
864 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
865 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
868 2011-06-26 Eli Zaretskii <eliz@gnu.org>
870 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
871 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
874 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
876 * process.c (wait_reading_process_output): Bypass select if
877 waiting for a cell while ignoring keyboard input, and input is
878 pending. Suggested by Jan Djärv (Bug#8869).
880 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
882 Use gnulib's dup2 module instead of rolling our own.
883 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
885 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
887 * dispnew.c (scrolling_window): Before scrolling, turn off a
888 mouse-highlight in the window being scrolled.
890 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
892 Move DEFSYM to lisp.h and use everywhere.
894 * character.h (DEFSYM): Move declaration...
895 * lisp.h (DEFSYM): ...here.
901 * w32select.c: Don't include character.h.
903 * alloc.c (syms_of_alloc):
904 * buffer.c (syms_of_buffer):
905 * bytecode.c (syms_of_bytecode):
906 * callint.c (syms_of_callint):
907 * casefiddle.c (syms_of_casefiddle):
908 * casetab.c (init_casetab_once):
909 * category.c (init_category_once, syms_of_category):
910 * ccl.c (syms_of_ccl):
911 * cmds.c (syms_of_cmds):
912 * composite.c (syms_of_composite):
913 * dbusbind.c (syms_of_dbusbind):
914 * dired.c (syms_of_dired):
915 * dispnew.c (syms_of_display):
916 * doc.c (syms_of_doc):
917 * editfns.c (syms_of_editfns):
918 * emacs.c (syms_of_emacs):
919 * eval.c (syms_of_eval):
920 * fileio.c (syms_of_fileio):
921 * fns.c (syms_of_fns):
922 * frame.c (syms_of_frame):
923 * fringe.c (syms_of_fringe):
924 * insdel.c (syms_of_insdel):
925 * keymap.c (syms_of_keymap):
926 * lread.c (init_obarray, syms_of_lread):
927 * macros.c (syms_of_macros):
928 * msdos.c (syms_of_msdos):
929 * print.c (syms_of_print):
930 * process.c (syms_of_process):
931 * search.c (syms_of_search):
932 * sound.c (syms_of_sound):
933 * syntax.c (init_syntax_once, syms_of_syntax):
934 * terminal.c (syms_of_terminal):
935 * textprop.c (syms_of_textprop):
936 * undo.c (syms_of_undo):
937 * w32.c (globals_of_w32):
938 * window.c (syms_of_window):
939 * xdisp.c (syms_of_xdisp):
940 * xfaces.c (syms_of_xfaces):
941 * xfns.c (syms_of_xfns):
942 * xmenu.c (syms_of_xmenu):
943 * xsettings.c (syms_of_xsettings):
944 * xterm.c (syms_of_xterm): Use DEFSYM.
946 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
948 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
950 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
952 Integer and buffer overflow fixes (Bug#8873).
954 * print.c (printchar, strout): Check for string overflow.
955 (PRINTPREPARE, printchar, strout):
956 Don't set size unless allocation succeeds.
958 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
959 for sizes. Check for string overflow more accurately.
960 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
962 * macros.c: Integer and buffer overflow fixes.
963 * keyboard.h (struct keyboard.kbd_macro_bufsize):
964 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
965 Use ptrdiff_t, not int, for sizes.
966 Don't increment bufsize until after realloc succeeds.
967 Check for size-calculation overflow.
968 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
970 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
972 * lread.c: Integer overflow fixes.
973 (read_integer): Radix is now EMACS_INT, not int,
974 to improve quality of diagnostics for out-of-range radices.
975 Calculate buffer size correctly for out-of-range radices.
976 (read1): Check for integer overflow in radices, and in
978 (read_escape): Avoid int overflow.
979 (Fload, openp, read_buffer_size, read1)
980 (substitute_object_recurse, read_vector, read_list, map_obarray):
981 Use ptrdiff_t, not int, for sizes.
982 (read1): Use EMACS_INT, not int, for sizes.
983 Check for size overflow.
985 * image.c (cache_image): Check for size arithmetic overflow.
987 * lread.c: Integer overflow issues.
988 (saved_doc_string_size, saved_doc_string_length)
989 (prev_saved_doc_string_size, prev_saved_doc_string_length):
990 Now ptrdiff_t, not int.
991 (read1): Don't assume doc string length fits in int. Check for
992 out-of-range doc string lengths.
993 (read_list): Don't assume file position fits in int.
994 (read_escape): Check for hex character overflow.
996 2011-06-22 Leo Liu <sdl.web@gmail.com>
998 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
999 Move to minibuffer.el.
1001 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1003 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1004 The following patches are for when GLYPH_DEBUG && !XASSERT.
1005 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1006 * dispnew.c (flush_stdout):
1007 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1008 Mark as externally visible.
1009 * dispnew.c (check_window_matrix_pointers): Now static.
1010 * dispnew.c (window_to_frame_vpos):
1011 * xfns.c (unwind_create_frame):
1012 * xterm.c (x_check_font): Remove unused local.
1013 * scroll.c (CHECK_BOUNDS):
1014 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1015 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1016 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1017 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1018 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1020 (debug_method_add): Use va_list and vsprintf rather than relying
1021 on undefined behavior with wrong number of arguments.
1022 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1023 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1024 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1025 since we're not interested in debugging glyphs with old libraries.
1026 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1027 GCC 4.6.0's static checking.
1029 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1031 Integer overflow and signedness fixes (Bug#8873).
1032 A few related buffer overrun fixes, too.
1034 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1036 * dispextern.h (struct face.stipple):
1037 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1038 (x_bitmap_mask, x_allocate_bitmap_record)
1039 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1040 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1041 (x_create_bitmap_from_xpm_data):
1042 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1043 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1045 * xfaces.c (load_pixmap):
1046 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1047 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1048 (.bitmaps_last, struct x_output.icon_bitmap):
1049 Use ptrdiff_t, not int, for bitmap indexes.
1050 (x_allocate_bitmap_record): Check for size overflow.
1051 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1053 Use ptrdiff_t, not int, for overlay counts.
1054 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1055 * editfns.c (overlays_around, get_pos_property):
1056 * textprop.c (get_char_property_and_overlay):
1057 * xdisp.c (next_overlay_change, note_mouse_highlight):
1058 * xfaces.c (face_at_buffer_position):
1059 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1060 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1061 (Fnext_overlay_change, Fprevious_overlay_change)
1062 (mouse_face_overlay_overlaps, Foverlays_in):
1063 Use ptrdiff_t, not int, for sizes.
1064 (overlays_at, overlays_in): Check for size-calculation overflow.
1066 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1068 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1069 (x_session_initialize): Do not assume string length fits in int.
1071 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1072 This is unlikely, but can occur if DPI is outlandish.
1074 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1075 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1077 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1078 * xrdb.c (magic_file_p, search_magic_path):
1079 Omit last arg SUFFIX; it was always 0. All callers changed.
1080 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1082 * xfont.c (xfont_match): Avoid need for strlen.
1084 * xfns.c: Don't assume strlen fits in int.
1085 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1087 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1088 not unsigned long, as we prefer signed integers. All callers changed.
1089 Detect integer overflow in repeat count.
1090 (message_dolog): Don't assume print length fits in 39 bytes.
1091 (display_mode_element): Don't assume strlen fits in int.
1093 * termcap.c: Don't assume sizes fit in int and never overflow.
1094 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1095 (gobble_line): Check for size-calculation overflow.
1097 * minibuf.c (Fread_buffer):
1098 * lread.c (intern, intern_c_string):
1099 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1100 Don't assume string length fits in int.
1102 * keyboard.c (parse_tool_bar_item):
1103 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1105 * font.c: Don't assume string length fits in int.
1106 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1107 Use ptrdiff_t, not int.
1108 (font_intern_prop): Don't assume string length fits in int.
1109 Don't assume integer property fits in fixnum.
1110 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1112 * filelock.c: Fix some buffer overrun and integer overflow issues.
1113 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1114 Reformulate so as not to need the command string.
1115 Invoke gzip -cd rather than gunzip, as it's more portable.
1116 (lock_info_type, lock_file_1, lock_file):
1117 Don't assume pid_t and time_t fit in unsigned long.
1118 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1119 (current_lock_owner): Prefer signed type for sizes.
1120 Use memcpy, not strncpy, where memcpy is what is really wanted.
1121 Don't assume (via atoi) that time_t and pid_t fit in int.
1122 Check for time_t and/or pid_t out of range, e.g., via a network share.
1123 Don't alloca where an auto var works fine.
1125 * fileio.c: Fix some integer overflow issues.
1126 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1127 Don't assume string length fits in int.
1128 (directory_file_name): Don't assume string length fits in long.
1129 (make_temp_name): Don't assume pid fits in int, or that its print
1130 length is less than 20.
1132 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1134 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1136 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1138 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1139 We prefer signed integers, even for size calculations.
1141 * emacs.c: Don't assume string length fits in 'int'.
1142 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1143 (main): Don't invoke strlen when not needed.
1145 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1146 (XD_DEBUG_MESSAGE): Don't waste a byte.
1148 * callproc.c (getenv_internal_1, getenv_internal)
1150 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1152 * lread.c (invalid_syntax): Omit length argument.
1153 All uses changed. This doesn't fix a bug, but it simplifies the
1154 code away from its former Hollerith-constant appearance, and it's
1155 one less 'int' to worry about when looking at integer-overflow issues.
1156 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1158 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1159 This didn't break anything, but it didn't help either.
1160 It's confusing to put a bogus integer in a place where the actual
1161 value does not matter.
1162 (LIST_END_P): Remove unused macro and its bogus comment.
1163 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1165 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1166 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1168 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1169 We prefer signed types, and the value cannot exceed the EMACS_INT
1170 range anyway (because otherwise the length would not be representable).
1171 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1172 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1173 This avoids a GCC warning when WIDE_EMACS_INT.
1175 * indent.c (sane_tab_width): New function.
1176 (current_column, scan_for_column, Findent_to, position_indentation)
1177 (compute_motion): Use it. This is just for clarity.
1178 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1180 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1182 * lisp.h (lint_assume): New macro.
1183 * composite.c (composition_gstring_put_cache):
1184 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1186 * editfns.c, insdel.c:
1187 Omit unnecessary forward decls, to simplify future changes.
1189 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1191 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1193 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1194 Use much-faster test for byte-length change.
1195 Don't assume string byte-length fits in 'int'.
1196 Check that character arg fits in 'int'.
1197 (mapcar1): Declare byte as byte, for clarity.
1199 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1201 * fns.c (concat): Catch string overflow earlier.
1202 Do not rely on integer wraparound.
1204 * dispextern.h (struct it.overlay_strings_charpos)
1205 (struct it.selective): Now EMACS_INT, not int.
1206 * xdisp.c (forward_to_next_line_start)
1207 (back_to_previous_visible_line_start)
1208 (reseat_at_next_visible_line_start, next_element_from_buffer):
1209 Don't arbitrarily truncate the value of 'selective' to int.
1211 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1213 * composite.c: Don't truncate sizes to 'int'.
1214 (composition_gstring_p, composition_reseat_it)
1215 (composition_adjust_point): Use EMACS_INT, not int.
1216 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1217 not EMACS_UINT, for indexes.
1219 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1221 * buffer.c: Include <verify.h>.
1222 (struct sortvec.priority, struct sortstr.priority):
1223 Now EMACS_INT, not int.
1224 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1225 (struct sortstr.size, record_overlay_string)
1226 (struct sortstrlist.size, struct sortlist.used):
1227 Don't truncate size to int.
1228 (record_overlay_string): Check for size-calculation overflow.
1229 (init_buffer_once): Check at compile-time, not run-time.
1231 2011-06-22 Jim Meyering <meyering@redhat.com>
1233 Don't leak an XBM-image-sized buffer
1234 * image.c (xbm_load): Free the image buffer after using it.
1236 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1239 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1240 that Sun C diagnosed.
1241 * fns.c (secure_hash): Fix pointer signedness issue.
1242 * intervals.c (static_offset_intervals): New function.
1243 (offset_intervals): Use it.
1245 2011-06-21 Leo Liu <sdl.web@gmail.com>
1248 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1251 * fns.c (secure_hash): Rename from crypto_hash_function and change
1252 the first arg to accept symbols.
1253 (Fsecure_hash): New primitive.
1254 (syms_of_fns): New symbols.
1256 2011-06-20 Deniz Dogan <deniz@dogan.se>
1258 * process.c (Fset_process_buffer): Clarify return value in
1261 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1263 * dispnew.c (add_window_display_history): Use BVAR.
1265 * xdisp.c (debug_method_add): Use BVAR.
1266 (check_window_end, dump_glyph_matrix, dump_glyph)
1267 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1269 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1272 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1273 check till after the cache is created in init_frame_faces.
1275 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1277 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1279 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1281 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1282 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1283 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1285 Improve buffer-overflow checking (Bug#8873).
1286 * fileio.c (Finsert_file_contents):
1287 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1288 Remove the old (too-loose) buffer overflow checks.
1289 They weren't needed, since make_gap checks for buffer overflow.
1290 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1291 The old code merely checked for Emacs fixnum overflow, and relied
1292 on undefined (wraparound) behavior. The new code avoids undefined
1293 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1295 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1296 Tune. Don't use wider integers than needed. Don't use alloca.
1297 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1299 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1301 * insdel.c, lisp.h (buffer_overflow): New function.
1302 (insert_from_buffer_1, replace_range, replace_range_2):
1303 * insdel.c (make_gap_larger):
1304 * editfns.c (Finsert_char):
1305 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1307 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1309 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1311 Integer overflow and signedness fixes (Bug#8873).
1313 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1314 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1316 * fileio.c: Don't assume EMACS_INT fits in off_t.
1317 (emacs_lseek): New static function.
1318 (Finsert_file_contents, Fwrite_region): Use it.
1319 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1321 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1323 * fns.c: Don't overflow int when computing a list length.
1324 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1325 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1326 truncation on 64-bit hosts. Check for QUIT every
1327 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1328 faster and is responsive enough.
1329 (Flength): Report an error instead of overflowing an integer.
1330 (Fsafe_length): Return a float if the value is not representable
1331 as a fixnum. This shouldn't happen except in contrived situations.
1332 (Fnthcdr, Fsort): Don't assume list length fits in int.
1333 (Fcopy_sequence): Don't assume vector length fits in int.
1335 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1336 (header_size, word_size): New constants.
1337 (allocate_vectorlike): Don't check size overflow here.
1338 (allocate_vector): Check it here instead, since this is the only
1339 caller of allocate_vectorlike that could cause overflow.
1340 Check that the new vector's length is representable as a fixnum.
1342 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1343 The previous code was bogus. For example, next_almost_prime (32)
1344 returned 39, which is undesirable as it is a multiple of 3; and
1345 next_almost_prime (24) returned 25, which is a multiple of 5 so
1346 why was the code bothering to check for multiples of 7?
1348 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1350 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1352 Variadic C functions now count arguments with ptrdiff_t.
1353 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1354 Back then I didn't know that the Emacs coding style prefers signed int.
1355 Also, in the meantime I found a few more instances where arguments
1356 were being counted with int, which may truncate counts on 64-bit
1357 machines, or EMACS_INT, which may be unnecessarily wide.
1358 * lisp.h (struct Lisp_Subr.function.aMANY)
1359 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1360 Arg counts are now ptrdiff_t, not size_t.
1361 All variadic functions and their callers changed accordingly.
1362 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1363 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1364 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1365 * callint.c (Fcall_interactively): Check arg count for overflow,
1366 to avoid potential buffer overrun. Use signed char, not 'int',
1367 for 'varies' array, so that we needn't bother to check its size
1368 calculation for overflow.
1369 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1370 * eval.c (apply_lambda):
1371 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1372 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1373 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1375 * callint.c (Fcall_interactively): Don't use index var as event count.
1377 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1378 * mem-limits.h (SIZE): Remove; no longer used.
1380 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1382 Remove unnecessary casts.
1383 * xterm.c (x_term_init):
1384 * xfns.c (x_set_border_pixel):
1385 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1386 These aren't needed now that we assume ANSI C.
1388 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1389 It's more likely to cause problems (due to unsigned overflow)
1392 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1394 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1396 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1398 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1400 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1402 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1404 GLYPH_CODE_FACE returns EMACS_INT, not int.
1405 * dispextern.h (merge_faces):
1406 * xfaces.c (merge_faces):
1407 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1408 Don't assume EMACS_INT fits in int.
1410 * character.h (CHAR_VALID_P): Remove unused parameter.
1411 * fontset.c, lisp.h, xdisp.c: All uses changed.
1413 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1415 * fns.c (concat): Minor tuning based on overflow analysis.
1416 This doesn't fix any bugs. Use int to hold character, instead
1417 of constantly refetching from Emacs object. Use XFASTINT, not
1418 XINT, for value known to be a character. Don't bother comparing
1419 a single byte to 0400, as it's always less.
1421 * floatfns.c (Fexpt):
1422 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1424 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1427 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1429 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1430 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1431 incorrectly succeed when S was a string, because 4294967386 was
1432 truncated before it was used.
1434 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1435 Otherwise, an out-of-range integer could cause undefined behavior
1438 * composite.c: Use int, not EMACS_INT, for characters.
1439 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1440 EMACS_INT, for values that are known to be in character range.
1441 This doesn't fix any bugs but is the usual style inside Emacs and
1442 may generate better code on 32-bit machines.
1444 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1445 This is for reasons similar to the recent CHAR_STRING fix.
1446 * charset.c (Fencode_char): Check that character arg is actually
1447 a character. Pass an int to ENCODE_CHAR.
1448 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1449 wider than 'int', as a compile-time check to prevent future regressions
1452 * character.c (char_string): Remove unnecessary casts.
1454 Make sure a 64-bit char is never passed to CHAR_STRING.
1455 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1456 by silently ignoring the top 32 bits, allowing some values
1457 that were far too large to be valid characters.
1458 * character.h: Include <verify.h>.
1459 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1460 arguments are no wider than unsigned, as a compile-time check
1461 to prevent future regressions in this area.
1463 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1464 (Fsubst_char_in_region):
1466 * xdisp.c (decode_mode_spec_coding):
1467 Adjust to CHAR_STRING's new requirement.
1468 * editfns.c (Finsert_char, Fsubst_char_in_region):
1469 * fns.c (concat): Check that character args are actually
1470 characters. Without this test, these functions did the wrong
1471 thing with wildly out-of-range values on 64-bit hosts.
1473 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1474 These casts should not be needed on 32-bit hosts, either.
1475 * keyboard.c (read_char):
1476 * lread.c (Fload): Remove casts to unsigned.
1478 * lisp.h (UNSIGNED_CMP): New macro.
1479 This fixes comparison bugs on 64-bit hosts.
1480 (ASCII_CHAR_P): Use it.
1481 * casefiddle.c (casify_object):
1482 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1483 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1484 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1485 * dispextern.h (FACE_FROM_ID):
1486 * keyboard.c (read_char): Use UNSIGNED_CMP.
1488 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1489 not to EMACS_INT, to avoid GCC warning.
1491 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1493 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1494 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1495 isn't needed on 32-bit machines.
1497 * buffer.c (Fgenerate_new_buffer_name):
1498 Use EMACS_INT for count, not int.
1499 (advance_to_char_boundary): Return EMACS_INT, not int.
1501 * data.c (Qcompiled_function): Now static.
1503 * window.c (window_body_lines): Now static.
1505 * image.c (gif_load): Rename local to avoid shadowing.
1507 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1508 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1509 * alloc.c (make_save_value): Integer argument is now of type
1511 (mark_object): Use ptrdiff_t, not int.
1512 * lisp.h (pD): New macro.
1513 * print.c (print_object): Use it.
1515 * alloc.c: Use EMACS_INT, not int, to count objects.
1516 (total_conses, total_markers, total_symbols, total_vector_size)
1517 (total_free_conses, total_free_markers, total_free_symbols)
1518 (total_free_floats, total_floats, total_free_intervals)
1519 (total_intervals, total_strings, total_free_strings):
1520 Now EMACS_INT, not int. All uses changed.
1521 (Fgarbage_collect): Compute overall total using a double, so that
1522 integer overflow is less likely to be a problem. Check for overflow
1523 when converting back to an integer.
1524 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1525 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1526 These were 'int' variables that could overflow on 64-bit hosts;
1527 they were never used, so remove them instead of repairing them.
1528 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1529 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1530 Previously, this ceilinged at INT_MAX, but that doesn't work on
1532 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1534 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1535 (allocate_vectorlike): Check for ptrdiff_t overflow.
1536 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1537 when a (possibly-narrower) signed value would do just as well.
1538 We prefer using signed arithmetic, to avoid comparison confusion.
1540 * alloc.c: Catch some string size overflows that we were missing.
1541 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1542 for convenience in STRING_BYTES_MAX.
1543 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1544 The definition here is exact; the one in lisp.h was approximate.
1545 (allocate_string_data): Check for string overflow. This catches
1546 some instances we weren't catching before. Also, it catches
1547 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1548 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1549 and ptrdiff_t and EMACS_INT are both 64 bits.
1551 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1552 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1553 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1555 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1557 * alloc.c (Fmake_string): Check for out-of-range init.
1559 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1561 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1563 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1565 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1566 xg_get_default_scrollbar_width.
1568 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1569 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1570 (style_changed_cb): Call update_theme_scrollbar_width and call
1571 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1572 all frames (Bug#8505).
1573 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1574 Call gtk_window_set_resizable if HAVE_GTK3.
1575 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1576 and height if HAVE_GTK3 (Bug#8505).
1577 (scroll_bar_width_for_theme): New variable.
1578 (update_theme_scrollbar_width): New function.
1579 (xg_get_default_scrollbar_width): Move code to
1580 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1581 (xg_initialize): Call update_theme_scrollbar_width.
1583 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1585 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1587 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1589 * frame.c (make_frame): Call other_buffer_safely instead of
1592 * window.c (temp_output_buffer_show): Call display_buffer with
1593 second argument Vtemp_buffer_show_specifiers and reset latter
1594 immediately after the call.
1595 (Vtemp_buffer_show_specifiers): New variable.
1596 (auto_window_vscroll_p, next_screen_context_lines)
1597 (Vscroll_preserve_screen_position): Remove leading asterisks from
1600 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1602 Fix minor problems found by GCC 4.6.0 static checking.
1603 * buffer.c (Qclone_number): Remove for now, as it's unused.
1604 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1605 (record_buffer): Remove unused local.
1606 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1607 (set_frame_buffer_list): Remove; unused.
1608 * frame.h (other_visible_frames): Remove decl.
1609 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1610 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1611 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1613 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1614 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1615 Define only if HAVE_GPM.
1616 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1617 (update_hints_inhibit): Remove; never set. All uses removed.
1618 * widgetprv.h (emacsFrameClassRec): Remove decl.
1619 * window.c (delete_deletable_window): Now returns void, since it
1620 wasn't returning anything.
1621 (compare_window_configurations): Remove unused locals.
1622 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1623 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1624 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1625 the same widths as pointers. This follows up on the 2011-05-06 patch.
1626 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1627 * xterm.h: Likewise.
1628 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1630 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1632 * makefile.w32-in: Update dependencies.
1633 (LISP_H): Add lib/intprops.h.
1635 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1637 * image.c (gif_load): Add animation frame delay to the metadata.
1638 (syms_of_image): Use DEFSYM. New symbol `delay'.
1640 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1642 * window.c (delete_deletable_window): Re-add.
1643 (Fset_window_configuration): Rewrite to handle dead buffers and
1644 consequently deletable windows.
1645 (window_tree, Fwindow_tree): Remove. Supply functionality in
1647 (compare_window_configurations): Simplify code.
1649 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1651 * image.c (imagemagick_load_image): Fix type mismatch.
1652 (Fimagemagick_types): Likewise.
1654 * window.h (replace_buffer_in_windows): Declare.
1656 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1658 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1659 Qclone_number. Remove external declaration of Qdelete_window.
1660 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1662 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1663 Qbuffer_list_update_hook if allowed.
1664 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1665 buffer list implementation.
1666 (other_buffer_safely): New function.
1667 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1668 calls to replace_buffer_in_windows and
1669 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1671 (record_buffer): Inhibit quitting and rewrite using quittable
1672 functions. Run Qbuffer_list_update_hook if allowed.
1673 (Frecord_buffer, Funrecord_buffer): New functions.
1674 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1675 switch-to-buffer to window.el.
1676 (bury-buffer): Move to window.el.
1677 (Vbuffer_list_update_hook): New variable.
1679 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1682 * window.h (resize_frame_windows): Move up in code.
1683 (Fwindow_frame): Remove EXFUN.
1684 (replace_buffer_in_all_windows): Remove prototype.
1685 (replace_buffer_in_windows_safely): Add prototype.
1687 * window.c: Declare Qdelete_window static again. Move down
1688 declaration of select_count.
1689 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1690 (Fother_window): Move to window.el.
1691 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1692 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1693 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1695 (replace_buffer_in_windows): Implement by calling
1696 Qreplace_buffer_in_windows.
1697 (replace_buffer_in_all_windows): Remove with some functionality
1698 moved into replace_buffer_in_windows_safely.
1699 (replace_buffer_in_windows_safely): New function.
1700 (select_window_norecord, select_frame_norecord): Move in front
1701 of run_window_configuration_change_hook. Remove now obsolete
1703 (Fset_window_buffer): Rewrite doc-string. Call
1704 Qrecord_window_buffer.
1705 (keys_of_window): Move binding for other-window to window.el.
1707 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1709 * dispextern.h (struct image): Replace data member, whose int_val
1710 and ptr_val fields were not used by anything, with a single
1713 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1714 (gif_clear_image, gif_load, imagemagick_load_image)
1715 (gs_clear_image, gs_load): Callers changed.
1717 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1719 * buffer.h: Include <time.h>, for time_t.
1720 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1722 Fix minor problems found by static checking.
1724 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1726 Make identifiers static if they are not used in other modules.
1727 * data.c (Qcompiled_function, Qframe, Qvector):
1728 * image.c (QimageMagick, Qsvg):
1729 * minibuf.c (Qmetadata):
1730 * window.c (resize_window_check, resize_root_window): Now static.
1731 * window.h (resize_window_check, resize_root_window): Remove decls.
1733 * window.c (window_deletion_count, delete_deletable_window):
1735 (window_body_lines): Now static.
1736 (Fdelete_other_windows_internal): Mark vars as initialized.
1737 Make sure 'resize_failed' is initialized.
1738 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1739 (resize_window_apply): Remove unused local.
1740 * window.h (delete_deletable_window): Remove decl.
1742 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1743 (imagemagick_load_image): Fix pointer signedness problem by changing
1744 last arg from unsigned char * to char *. All uses changed.
1745 Also, fix a local for similar reasons.
1746 Remove unused locals. Remove locals to avoid shadowing.
1747 (fn_rsvg_handle_free): Remove; unused.
1748 (svg_load, svg_load_image): Fix pointer signedness problem.
1749 (imagemagick_load_image): Don't use garbage pointer image_wand.
1751 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1753 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1755 * image.c (gif_load): Fix omitted cast error introduced by
1758 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1760 * window.h (resize_proportionally, orig_total_lines)
1761 (orig_top_line): Remove from window structure.
1762 (set_window_height, set_window_width, change_window_heights)
1763 (Fdelete_window): Remove prototypes.
1764 (resize_frame_windows): Remove duplicate declaration.
1766 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1768 * window.h (resize_frame_windows, resize_window_check)
1769 (delete_deletable_window, resize_root_window)
1770 (resize_frame_windows): Declare prototypes.
1772 * window.c (resize_window_apply): Make definition be "static" to
1773 match the prototype.
1775 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1777 * window.c: Remove declarations of Qwindow_size_fixed,
1778 window_min_size_1, window_min_size_2, window_min_size,
1779 size_window, window_fixed_size_p, enlarge_window, delete_window.
1780 Remove static from declaration of Qdelete_window, it's
1781 temporarily needed by Fbury_buffer.
1782 (replace_window): Don't assign orig_top_line and
1784 (Fdelete_window, delete_window): Remove. Window deletion is
1785 handled by window.el.
1786 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1787 Fdelete_window calls with calls to Qdelete_window.
1788 (Fdelete_other_windows): Remove. Deleting other windows is
1789 handled by window.el.
1790 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1791 handled in window.el.
1792 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1793 Window minimum sizes are handled in window.el.
1794 (shrink_windows, size_window, set_window_height)
1795 (set_window_width, change_window_heights, window_height)
1796 (window_width, CURBEG, CURSIZE, enlarge_window)
1797 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1798 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1799 handled in window.el.
1800 (make_dummy_parent): Rename to make_parent_window and give it a
1801 second argument horflag.
1802 (make_window): Don't set resize_proportionally any more.
1803 (Fsplit_window): Remove. Windows are split in window.el.
1804 (save_restore_action, save_restore_orig_size)
1805 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1806 Resize mini windows in window.el.
1807 (grow_mini_window, shrink_mini_window): Implement by calling
1808 Qresize_root_window_vertically, resize_window_check and
1809 resize_window_apply.
1810 (saved_window, Fset_window_configuration, save_window_save): Do
1811 not handle orig_top_line, orig_total_lines, and
1812 resize_proportionally.
1813 (window_min_height, window_min_width): Move to window.el.
1814 (keys_of_window): Move bindings for delete-other-windows,
1815 split-window, delete-window and enlarge-window to window.el.
1817 * buffer.c: Temporarily extern Qdelete_window.
1818 (Fbury_buffer): Temporarily call Qdelete_window instead of
1819 Fdelete_window (Fbury_buffer will move to window.el soon).
1821 * frame.c (set_menu_bar_lines_1): Remove code handling
1822 orig_top_line and orig_total_lines.
1824 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1825 set_window_height but set heights directly.
1826 (change_frame_size_1): Use resize_frame_windows.
1828 * xdisp.c (init_xdisp): Don't use set_window_height but set
1831 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1832 resize_frame_windows instead of change_window_heights and run
1833 run_window_configuration_change_hook.
1835 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1836 instead of change_window_heights and run
1837 run_window_configuration_change_hook.
1839 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1841 * window.c (replace_window): Rename second argument REPLACEMENT to
1842 NEW. New third argument SETFLAG. Rewrite.
1843 (delete_window, make_dummy_parent): Call replace_window with
1845 (window_list_1): Move down in code.
1846 (run_window_configuration_change_hook): Move set_buffer part
1847 before select_frame_norecord part in order to unwind correctly.
1848 Rename count1 to count.
1849 (recombine_windows, delete_deletable_window, resize_root_window)
1850 (Fdelete_other_windows_internal)
1851 (Frun_window_configuration_change_hook, make_parent_window)
1852 (resize_window_check, resize_window_apply, Fresize_window_apply)
1853 (resize_frame_windows, Fsplit_window_internal)
1854 (Fdelete_window_internal, Fresize_mini_window_internal): New
1856 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1858 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1860 * window.h (window): Add some new members to window structure -
1861 normal_lines, normal_cols, new_total, new_normal, clone_number,
1862 splits, nest, prev_buffers, next_buffers.
1863 (WINDOW_TOTAL_SIZE): Move here from window.c.
1864 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1866 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1868 (make_dummy_parent): Set new members of windows structure.
1869 (make_window): Move down in code. Handle new members of window
1871 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1872 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1873 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1874 (Fset_window_prev_buffers, Fwindow_next_buffers)
1875 (Fset_window_next_buffers, Fset_window_clone_number): New
1877 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1878 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1880 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1881 Argument WINDOW can be now internal window too.
1882 (Fwindow_use_time): Move up in code.
1883 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1885 (Fset_window_configuration, saved_window)
1886 (Fcurrent_window_configuration, save_window_save): Handle new
1887 members of window structure.
1888 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1889 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1890 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1891 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1892 Qget_mru_window, Qresize_root_window,
1893 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1894 Qauto_buffer_name; staticpro them.
1896 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1898 * window.c (Fwindow_total_size, Fwindow_left_column)
1899 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1900 (Fwindow_list_1): New functions.
1901 (window_box_text_cols): Replace with window_body_cols.
1902 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1903 window_body_cols instead of window_box_text_cols.
1904 (delete_window, Fset_window_configuration): Call
1905 delete_all_subwindows with window as argument.
1906 (delete_all_subwindows): Take a window as argument and not a
1908 (window_loop): Remove handling of GET_LRU_WINDOW and
1910 (Fget_lru_window, Fget_largest_window): Move to window.el.
1912 * window.h: Extern window_body_cols instead of
1913 window_box_text_cols. delete_all_subwindows now takes a
1914 Lisp_Object as argument.
1916 * indent.c (compute_motion, Fcompute_motion): Use
1917 window_body_cols instead of window_box_text_cols.
1919 * frame.c (delete_frame): Call delete_all_subwindows with root
1922 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1924 * fns.c (Fputhash): Document return value.
1926 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1928 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1930 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1932 Cons<->int and similar integer overflow fixes (Bug#8794).
1934 Check for overflow when converting integer to cons and back.
1935 * charset.c (Fdefine_charset_internal, Fdecode_char):
1936 Use cons_to_unsigned to catch overflow.
1937 (Fencode_char): Use INTEGER_TO_CONS.
1938 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1939 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1940 * data.c (long_to_cons, cons_to_long): Remove.
1941 (cons_to_unsigned, cons_to_signed): New functions.
1942 These signal an error for invalid or out-of-range values.
1943 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1944 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1945 * font.c (Ffont_variation_glyphs):
1946 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1947 * lisp.h: Include <intprops.h>.
1948 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1949 (cons_to_signed, cons_to_unsigned): New decls.
1950 (long_to_cons, cons_to_long): Remove decls.
1951 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1952 (Fprimitive_undo): Use CONS_TO_INTEGER.
1953 * xfns.c (Fx_window_property): Likewise.
1954 * xselect.c: Include <limits.h>.
1955 (x_own_selection, selection_data_to_lisp_data):
1956 Use INTEGER_TO_CONS.
1957 (x_handle_selection_request, x_handle_selection_clear)
1958 (x_get_foreign_selection, Fx_disown_selection_internal)
1959 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1960 (lisp_data_to_selection_data): Use cons_to_unsigned.
1961 (x_fill_property_data): Use cons_to_signed.
1962 Report values out of range.
1964 Check for buffer and string overflow more precisely.
1965 * buffer.h (BUF_BYTES_MAX): New macro.
1966 * lisp.h (STRING_BYTES_MAX): New macro.
1967 * alloc.c (Fmake_string):
1968 * character.c (string_escape_byte8):
1969 * coding.c (coding_alloc_by_realloc):
1970 * doprnt.c (doprnt):
1971 * editfns.c (Fformat):
1973 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1974 since they may not be the same number.
1975 * editfns.c (Finsert_char):
1976 * fileio.c (Finsert_file_contents):
1977 Likewise for BUF_BYTES_MAX.
1979 * image.c: Use ptrdiff_t, not int, for sizes.
1980 (slurp_file): Switch from int to ptrdiff_t.
1982 (slurp_file): Check that file size fits in both size_t (for
1983 malloc) and ptrdiff_t (for sanity and safety).
1985 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1986 if b->modtime has its maximal value.
1988 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1990 Don't assume time_t can fit into int.
1991 * buffer.h (struct buffer.modtime): Now time_t, not int.
1992 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1993 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1995 Minor fixes for signed vs unsigned integers.
1996 * character.h (MAYBE_UNIFY_CHAR):
1997 * charset.c (maybe_unify_char):
1998 * keyboard.c (read_char, reorder_modifiers):
1999 XINT -> XFASTINT, since the integer must be nonnegative.
2000 * ftfont.c (ftfont_spec_pattern):
2001 * keymap.c (access_keymap, silly_event_symbol_error):
2002 XUINT -> XFASTINT, since the integer must be nonnegative.
2003 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2004 since it makes no difference and we prefer signed.
2005 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2006 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2009 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2011 * window.h (Fwindow_frame): Declare.
2013 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2015 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2016 (SPARE_MEMORY): Always define.
2017 (LARGE_REQUEST): Remove.
2018 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2020 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2022 * lisp.h: Move EXFUNS for Fframe_root_window,
2023 Fframe_first_window and Fset_frame_selected_window to window.h.
2025 * window.h: Move EXFUNS for Fframe_root_window,
2026 Fframe_first_window and Fset_frame_selected_window here from
2029 * frame.c (Fwindow_frame, Fframe_first_window)
2030 (Fframe_root_window, Fframe_selected_window)
2031 (Fset_frame_selected_window): Move to window.c.
2032 (Factive_minibuffer_window): Move to minibuf.c.
2033 (Fother_visible_frames_p): New function.
2035 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2037 * window.c (decode_window, decode_any_window): Move up in code.
2038 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2039 (inhibit_frame_unsplittable): Remove unused variable.
2040 (Fwindow_buffer): Move up and rewrite doc-string.
2041 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2042 (Fwindow_prev): New functions.
2043 (Fwindow_frame): Move here from frame.c. Accept any window as
2045 (Fframe_root_window, Fframe_first_window)
2046 (Fframe_selected_window): Move here from frame.c. Accept frame
2047 or arbitrary window as argument. Update doc-strings.
2048 (Fminibuffer_window): Move up in code.
2049 (Fwindow_minibuffer_p): Move up in code and simplify.
2050 (Fset_frame_selected_window): Move here from frame.c.
2052 (Fselected_window, select_window, Fselect_window): Move up in
2053 code. Minor doc-string fixes.
2055 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2057 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2058 Do not assume that spare memory exists; that assumption is valid
2059 only if SYSTEM_MALLOC.
2060 (LARGE_REQUEST): New macro, so that the issue of large requests
2061 is separated from the issue of spare memory.
2063 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2065 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2068 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2070 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2073 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2075 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2077 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2079 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2080 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2082 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2084 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2086 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2088 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2089 (x_clipboard_manager_save): Add return value.
2090 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2092 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2093 Obey Vx_select_enable_clipboard_manager. Catch errors in
2094 x_clipboard_manager_save (Bug#8779).
2095 (Vx_select_enable_clipboard_manager): New variable.
2096 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2098 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2100 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2102 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2104 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2105 in the current matrix if keep_current_p is non-zero.
2107 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2109 * bidi.c (bidi_level_of_next_char): Fix last change.
2111 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2113 Support bidi reordering of text covered by display properties.
2115 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2116 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2117 (bidi_cache_search, bidi_cache_iterator_state)
2118 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2119 (bidi_level_of_next_char, bidi_move_to_visually_next):
2120 Support character positions inside a run of characters covered by a
2122 (bidi_paragraph_init, bidi_resolve_explicit_1)
2123 (bidi_level_of_next_char): Call bidi_fetch_char and
2124 bidi_fetch_char_advance instead of FETCH_CHAR and
2126 (bidi_init_it): Initialize new members.
2127 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2129 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2130 instead of using explicit *_CHAR codes.
2131 (bidi_resolve_explicit, bidi_resolve_weak):
2132 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2133 bidirectional text is supported only in multibyte buffers.
2134 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2135 it to initialize the frame_window_p member of struct bidi_it.
2136 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2137 (bidi_resolve_explicit, bidi_resolve_weak)
2138 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2139 bidi_it->nchars is non-positive.
2140 (bidi_level_of_next_char): Don't try to lookup the cache for the
2141 next/previous character if nothing is cached there yet, or if we
2142 were just reseat()'ed to a new position.
2144 * xdisp.c (set_cursor_from_row): Set start and stop points
2145 according to the row's direction when priming the loop that looks
2146 for the glyph on which to display cursor.
2147 (single_display_spec_intangible_p): Function deleted.
2148 (display_prop_intangible_p): Reimplement to call
2149 handle_display_spec instead of single_display_spec_intangible_p.
2150 Accept 3 additional arguments needed by handle_display_spec.
2151 This fixes incorrect cursor motion across display property with complex
2152 values: lists, `(when COND...)' forms, etc.
2153 (single_display_spec_string_p): Support property values that are
2154 lists with the argument STRING its top-level element.
2155 (display_prop_string_p): Fix the condition for processing a
2156 property that is a list to be consistent with handle_display_spec.
2157 (handle_display_spec): New function, refactored from the
2158 last portion of handle_display_prop.
2159 (compute_display_string_pos): Accept additional argument
2160 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2161 value of a `display' property is a "replacing spec".
2162 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2163 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2164 the display property, but just return a value indicating whether
2165 the display property will replace the characters it covers.
2166 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2167 frame_window_p members of struct bidi_it.
2168 (compute_display_string_pos, compute_display_string_end):
2170 (push_it): Accept second argument POSITION, where pop_it should
2171 jump to continue iteration.
2172 (reseat_1): Initialize bidi_it.disp_pos.
2174 * keyboard.c (adjust_point_for_property): Adjust the call to
2175 display_prop_intangible_p to its new signature.
2177 * dispextern.h (struct bidi_it): New member frame_window_p.
2178 (bidi_init_it): Update prototypes.
2179 (display_prop_intangible_p): Update prototype.
2180 (compute_display_string_pos, compute_display_string_end):
2182 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2185 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2187 Malloc failure behavior now depends on size of allocation.
2188 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2189 * lisp.h: Change signatures accordingly.
2190 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2191 All callers changed. (Bug#8762)
2193 * gnutls.c: Use Emacs's memory allocators.
2194 Without this change, the gnutls library would invoke malloc etc.
2195 directly, which causes problems on non-SYNC_INPUT hosts, and which
2196 runs afoul of improving memory_full behavior. (Bug#8761)
2197 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2198 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2199 xfree instead of the default malloc, realloc, free.
2200 (Fgnutls_boot): No need to check for memory allocation failure,
2201 since xmalloc does that for us.
2203 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2204 * category.c (hash_get_category_set):
2205 * ccl.c (ccl_driver):
2206 * charset.c (Fdefine_charset_internal):
2207 * charset.h (struct charset.hash_index):
2208 * composite.c (get_composition_id, gstring_lookup_cache)
2209 (composition_gstring_put_cache):
2210 * composite.h (struct composition.hash_index):
2211 * dispextern.h (struct image.hash):
2212 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2213 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2214 (hashfn_equal, hashfn_user_defined, make_hash_table)
2215 (maybe_resize_hash_table, hash_lookup, hash_put)
2216 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2217 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2218 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2219 * image.c (make_image, search_image_cache, lookup_image)
2220 (xpm_put_color_table_h):
2221 * lisp.h (struct Lisp_Hash_Table):
2222 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2223 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2224 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2225 * alloc.c (allocate_vectorlike):
2226 Check for overflow in vector size calculations.
2227 * ccl.c (ccl_driver):
2228 Check for overflow when converting EMACS_INT to int.
2229 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2230 need to be updated by these changes.
2231 * fns.c (make_hash_table, maybe_resize_hash_table):
2232 Check for integer overflow with large hash tables.
2233 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2234 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2235 (SXHASH_REDUCE): New macro.
2236 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2237 Use it instead of discarding useful hash info with large hash values.
2238 (sxhash_float): New function.
2239 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2240 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2241 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2242 Rewrite to use FIXNUM_BITS, as this simplifies things.
2243 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2244 Adjust signatures to match updated version of code.
2245 (consing_since_gc): Now EMACS_INT, since a single hash table can
2246 use more than INT_MAX bytes.
2248 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2250 Make it possible to build with GCC-4.6+ -O2 -flto.
2252 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2254 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2256 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2257 Call minibuffer-inactive-mode.
2259 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2261 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2262 Update dependencies.
2264 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2266 * data.c (init_data): Remove code for UTS, this system is not
2269 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2271 Don't force ./temacs to start in terminal mode.
2273 * frame.c (make_initial_frame): Initialize faces in all cases, not
2274 only when CANNOT_DUMP is defined.
2275 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2277 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2279 * dispnew.c (add_window_display_history): Use const for the string
2280 pointer. Remove declaration, not needed.
2282 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2284 Use 'inline', not 'INLINE'.
2285 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2286 * alloc.c, fontset.c (INLINE): Remove.
2287 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2288 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2289 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2290 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2291 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2293 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2295 Make it possible to run ./temacs.
2297 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2298 syms_of_callproc does the same thing. Remove test for
2299 "initialized", do it in the caller.
2300 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2302 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2304 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2305 (read_minibuf): Use get_minibuffer.
2306 (syms_of_minibuf): Use DEFSYM.
2307 (Qmetadata): New var.
2308 * data.c (Qbuffer): Don't make it static.
2309 (syms_of_data): Use DEFSYM.
2311 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2313 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2314 (CCL_CODE_MIN): New macro.
2316 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2318 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2320 * eval.c (Qdebug): Now static.
2321 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2322 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2323 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2325 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2327 * image.c: Various fixes to ImageMagick code comments.
2328 (Fimagemagick_types): Doc fix.
2330 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2332 Minor fixes prompted by GCC 4.6.0 warnings.
2334 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2336 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2337 (x_clipboard_manager_save_all): Move extern decl to ...
2338 * xterm.h: ... here, so that it can be checked for consistency.
2340 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2342 * xselect.c (x_clipboard_manager_save_frame)
2343 (x_clipboard_manager_save_all): New functions.
2344 (Fx_clipboard_manager_save): Lisp function deleted.
2346 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2347 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2349 * xterm.h: Update prototype.
2351 2011-05-28 William Xu <william.xwl@gmail.com>
2353 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2356 2011-05-28 Jim Meyering <meyering@redhat.com>
2358 Avoid a sign-extension bug in crypto_hash_function.
2359 * fns.c (to_uchar): Define.
2360 (crypto_hash_function): Use it to convert some newly-signed
2361 variables to unsigned, to avoid sign-extension bugs. For example,
2362 without this change, (md5 "truc") would evaluate to
2363 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2364 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2365 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2367 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2369 Integer overflow fixes.
2371 * dbusbind.c: Serial number integer overflow fixes.
2372 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2373 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2374 to hold a serial number that is too large for a fixnum.
2375 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2376 Check for serial numbers out of range. Decode any serial number
2377 that was so large that it became a float. (Bug#8722)
2379 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2380 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2381 Use XFASTINT rather than XUINT when numbers are nonnegative.
2382 (xd_append_arg, Fdbus_method_return_internal):
2383 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2384 arguments, check that Lisp number is nonnegative, rather than
2385 silently wrapping negative numbers around. (Bug#8722)
2386 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2389 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2391 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2393 ccl: add integer overflow checks
2394 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2395 (IN_INT_RANGE): New macros.
2396 (ccl_driver): Use them to check for integer overflow when
2397 decoding a CCL program. Many of the new checks are whether XINT (x)
2398 fits in int; it doesn't always, on 64-bit hosts. The new version
2399 doesn't catch all possible integer overflows, but it's an
2400 improvement. (Bug#8719)
2402 * alloc.c (make_event_array): Use XINT, not XUINT.
2403 There's no need for unsigned here.
2405 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2406 This follows up to the 2011-05-06 change that substituted uintptr_t
2407 for EMACS_INT. This case wasn't caught back then.
2409 Rework Fformat to avoid integer overflow issues.
2410 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2411 now (part of C89). Include <verify.h>.
2412 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2413 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2414 (Fformat): Avoid the prepass trying to compute sizes; it was only
2415 approximate and thus did not catch overflow reliably. Instead, walk
2416 through the format just once, formatting and computing sizes as we go,
2417 checking for integer overflow at every step, and allocating a larger
2418 buffer as needed. Keep track separately whether the format is
2419 multibyte. Keep only the most-recently calculated precision, rather
2420 than them all. Record whether each argument has been converted to
2421 string. Use EMACS_INT, not int, for byte and char and arg counts.
2422 Support field widths and precisions larger than INT_MAX. Avoid
2423 sprintf's undefined behavior with conversion specifications such as %#d
2424 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2425 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2426 formatting out-of-range floating point numbers with int
2429 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2431 * data.c: Avoid integer truncation in expressions involving floats.
2432 * data.c: Include <intprops.h>.
2433 (arith_driver): When there's an integer overflow in an expression
2434 involving floating point, convert the integers to floating point
2435 so that the resulting value does not suffer from catastrophic
2436 integer truncation. For example, on a 64-bit host (* 4
2437 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2438 Do not rely on undefined behavior after integer overflow.
2440 merge count_size_as_multibyte, parse_str_to_multibyte
2441 * character.c, character.h (count_size_as_multibyte):
2442 Rename from parse_str_to_multibyte; all uses changed.
2443 Check for integer overflow.
2444 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2445 since it's now a duplicate of the other. This is more of
2446 a character than a buffer op, so better that it's in character.c.
2447 * fns.c, print.c: Adjust to above changes.
2449 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2451 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2453 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2455 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2456 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2457 (x_clipboard_manager_save): Now static.
2458 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2460 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2461 (crypto_hash_function): Now static.
2462 Fix pointer signedness problems. Avoid unnecessary initializations.
2464 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2466 * termhooks.h (Vselection_alist): Make it terminal-local.
2468 * terminal.c (create_terminal): Initialize it.
2470 * xselect.c: Support for clipboard managers.
2471 (Vselection_alist): Move to termhooks.h as terminal-local var.
2472 (LOCAL_SELECTION): New macro.
2473 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2474 (symbol_to_x_atom): Remove gratuitous arg.
2475 (x_handle_selection_request, lisp_data_to_selection_data)
2476 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2477 (x_own_selection, x_get_local_selection, x_convert_selection):
2478 New arg, specifying work frame. Use terminal-local Vselection_alist.
2479 (some_frame_on_display): Delete unused function.
2480 (Fx_own_selection_internal, Fx_get_selection_internal)
2481 (Fx_disown_selection_internal, Fx_selection_owner_p)
2482 (Fx_selection_exists_p): New optional frame arg.
2483 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2484 (x_handle_selection_clear): Don't treat other terminals with the
2485 same keyboard specially. Use the terminal-local Vselection_alist.
2486 (x_clear_frame_selections): Use Frun_hook_with_args.
2488 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2490 * xterm.h: Add support for those atoms.
2492 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2494 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2495 (converted_selections, conversion_fail_tag): New global variables.
2496 (x_selection_request_lisp_error): Free the above.
2497 (x_get_local_selection): Remove unnecessary code.
2498 (x_reply_selection_request): Args changed; handle arbitrary array
2499 of converted selections stored in converted_selections.
2500 Separate the XChangeProperty and SelectionNotify steps.
2501 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2502 (x_convert_selection): New function.
2503 (x_handle_selection_event): Simplify.
2504 (x_get_foreign_selection): Don't ignore incoming requests while
2505 waiting for an answer; this will fail when we implement
2506 SAVE_TARGETS, and seems unnecessary anyway.
2507 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2508 (Vx_sent_selection_functions): Doc fix.
2510 2011-05-26 Leo Liu <sdl.web@gmail.com>
2512 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2514 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2516 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2518 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2519 for fringe update if it has periodic bitmap.
2520 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2521 and fringe_bitmap_periodic_p.
2523 * fringe.c (get_fringe_bitmap_data): New function.
2524 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2525 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2526 row. Mark glyph row for fringe update if periodicity changed.
2528 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2529 for fringe update unless it has periodic bitmap.
2531 2011-05-25 Kenichi Handa <handa@m17n.org>
2533 * xdisp.c (get_next_display_element): Set correct it->face_id for
2534 a static composition.
2536 2011-05-24 Leo Liu <sdl.web@gmail.com>
2539 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2541 * fns.c (crypto_hash_function, Fsha1): New function.
2542 (Fmd5): Use crypto_hash_function.
2543 (syms_of_fns): Add Ssha1.
2545 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2547 * gnutls.c: Remove unused macros.
2548 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2549 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2550 Remove macros that are defined and never used.
2551 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2553 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2555 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2556 (Fx_get_selection_internal): Minor cleanup.
2557 (Fx_own_selection_internal): Rename arguments for consistency with
2560 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2562 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2564 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2566 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2568 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2570 * dispnew.c (scrolling_window): Don't exclude the case that the
2571 last enabled row in the desired matrix touches the bottom boundary.
2573 2011-05-21 Glenn Morris <rgm@gnu.org>
2575 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2576 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2577 and add some more files.
2579 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2581 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2582 report_file_error introduced by the change from 2011-05-07.
2584 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2586 * systime.h (Time): Define only if emacs is defined.
2587 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2588 where the include path doesn't have X11/X.h by default. See
2589 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2591 2011-05-20 Kenichi Handa <handa@m17n.org>
2593 * composite.c (find_automatic_composition): Fix previous change.
2595 2011-05-20 Glenn Morris <rgm@gnu.org>
2597 * lisp.mk: New file, split from Makefile.in.
2598 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2599 (shortlisp): Remove.
2600 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2602 2011-05-19 Glenn Morris <rgm@gnu.org>
2604 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2605 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2606 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2607 (lisp): Set the order to that of loadup.el.
2608 (shortlisp): Make it a copy of $lisp.
2609 (SOME_MACHINE_LISP): Remove.
2610 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2611 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2613 2011-05-18 Kenichi Handa <handa@m17n.org>
2615 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2616 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2617 (find_automatic_composition): Mostly rewrite for efficiency.
2619 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2621 * makefile.w32-in: Update dependencies.
2623 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2625 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2626 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2628 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2630 Fix some integer overflow issues, such as string length overflow.
2632 * insdel.c (count_size_as_multibyte): Check for string overflow.
2634 * character.c (lisp_string_width): Check for string overflow.
2635 Use EMACS_INT, not int, for string indexes and lengths; in
2636 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2637 the resulting string length overflows an EMACS_INT; instead,
2638 report a string overflow if no precision given. When checking for
2639 precision exhaustion, use a check that cannot possibly have
2640 integer overflow. (Bug#8675)
2641 * character.h (lisp_string_width): Adjust to new signature.
2643 * alloc.c (string_overflow): New function.
2644 (Fmake_string): Use it. This doesn't change behavior, but saves
2645 a few bytes and will simplify future changes.
2646 * character.c (string_escape_byte8): Likewise.
2647 * lisp.h (string_overflow): New decl.
2649 Fixups, following up to the user-interface timestamp change.
2650 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2651 for UI timestamps, instead of unsigned long.
2652 * msdos.c (mouse_get_pos): Likewise.
2653 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2654 * w32gui.h (Time): Define by including "systime.h" rather than by
2655 declaring it ourselves. (Bug#8664)
2657 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2658 * image.c (clear_image_cache): Likewise.
2660 * term.c (term_mouse_position): Don't assume time_t wraparound.
2662 Be more systematic about user-interface timestamps.
2663 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2664 and sometimes 'EMACS_UINT', to represent these timestamps.
2665 This change causes it to use 'Time' uniformly, as that's what X uses.
2666 This makes the code easier to follow, and makes it easier to catch
2667 integer overflow bugs such as Bug#8664.
2668 * frame.c (Fmouse_position, Fmouse_pixel_position):
2669 Use Time, not unsigned long, for user-interface timestamps.
2670 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2671 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2672 * keyboard.h (last_event_timestamp): Likewise.
2673 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2674 * menu.h (xmenu_show): Likewise.
2675 * term.c (term_mouse_position): Likewise.
2676 * termhooks.h (struct input_event.timestamp): Likewise.
2677 (struct terminal.mouse_position_hook): Likewise.
2678 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2679 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2680 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2681 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2683 * menu.h, termhooks.h: Include "systime.h", for Time.
2685 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2686 Don't assume that the difference between two unsigned long values
2687 can fit into an integer. At this point, we know button_down_time
2688 <= event->timestamp, so the difference must be nonnegative, so
2689 there's no need to cast the result if double-click-time is
2690 nonnegative, as it should be; check that it's nonnegative, just in
2691 case. This bug is triggered when events are more than 2**31 ms
2692 apart (about 25 days). (Bug#8664)
2694 * xselect.c (last_event_timestamp): Remove duplicate decl.
2695 (x_own_selection): Remove needless cast to unsigned long.
2697 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2698 that always fit in int. Use a sentinel instead of a counter, to
2699 avoid a temp and to allay GCC's concerns about possible int overflow.
2700 * frame.h (struct frame): Use int for menu_bar_items_used
2701 instead of EMACS_INT, since it always fits in int.
2703 * menu.c (grow_menu_items): Check for int overflow.
2705 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2707 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2708 Before, the code was not consistent. These values cannot exceed
2709 2**31 - 1 so there's no need to make them unsigned.
2710 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2711 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2712 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2714 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2716 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2717 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2718 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2719 presumably because the widths might not match.
2721 * window.c (size_window): Avoid needless test at loop start.
2723 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2725 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2727 2011-05-12 Drew Adams <drew.adams@oracle.com>
2729 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2731 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2733 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2734 `width' to `bar_area_x' and `bar_area_width', respectively.
2735 (x_scroll_run): Take account of fringe background extension.
2737 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2738 Rename local vars `left' and `width' to `bar_area_x' and
2739 `bar_area_width', respectively.
2740 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2741 background extension.
2743 2011-05-10 Jim Meyering <meyering@redhat.com>
2745 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2747 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2749 * image.c (Finit_image_library): Return t for built-in image types,
2750 like pbm and xbm. (Bug#8640)
2752 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2754 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2756 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2758 * w32console.c (Fset_screen_color): Doc fix.
2759 (Fget_screen_color): New function.
2760 (syms_of_ntterm): Defsubr it.
2762 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2763 unlink the temporary file if Fcall_process didn't create it in the
2765 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2766 child process will be redirected to a file specified with `:file'.
2767 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2768 cue to call_process_cleanup not to close that handle.
2770 2011-05-07 Ben Key <bkey76@gmail.com>
2772 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2773 one of two shell specific rules, either bootstrap-temacs-CMD or
2774 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2775 to the previous implementation of the bootstrap-temacs rule.
2776 The bootstrap-temacs-CMD rule is similar to the previous
2777 implementation of the bootstrap-temacs rule except that it
2778 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2781 These changes, along with some changes to nt/configure.bat,
2782 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2783 earlier fix to add support for --cflags and --ldflags options
2784 that include quotes so that it works whether make uses cmd or
2787 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2789 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2790 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2792 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2793 a string. Handle both cases.
2794 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2795 (Fdbus_register_method): Use Qinvalid_function.
2797 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2799 * makefile.w32-in: Update dependencies.
2800 (LISP_H): Add inttypes.h and stdin.h.
2801 (PROCESS_H): Add unistd.h.
2803 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2805 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2806 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2808 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2810 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2812 * term.c (vfatal): Remove stray call to va_end.
2813 It's not needed and the C Standard doesn't allow it here anyway.
2815 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2816 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2818 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2821 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2823 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2825 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2827 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2829 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2831 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2832 * charset.c (Fdefine_charset_internal): Don't initialize
2833 charset.code_space[15]. The value was garbage, on hosts with
2834 32-bit int (Bug#8600).
2836 * lread.c (read_integer): Be more consistent with string-to-number.
2837 Use string_to_number to do the actual conversion; this avoids
2838 rounding errors and fixes some other screwups. Without this fix,
2839 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2840 (digit_to_number): Move earlier, for benefit of read_integer.
2841 Return -1 if the digit is out of range for the base, -2 if it is
2842 not a digit in any supported base. (Bug#8602)
2844 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2846 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2847 to match comment at start of function. This also removes a
2848 GCC warning about overflow in a 32+64-bit port.
2850 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2852 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2853 Reported by Stefan Monnier in
2854 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2855 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2856 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2858 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2859 (EMACS_UINTPTR): Likewise, with uintptr_t.
2861 * lisp.h: Prefer 64-bit EMACS_INT if available.
2862 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2863 on 32-bit hosts that have 64-bit int, so that they can access
2865 However, temporarily disable this change unless the temporary
2866 symbol WIDE_EMACS_INT is defined.
2868 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2870 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2871 This removes an assumption that EMACS_INT and long are the same
2872 width as pointers. The assumption is true for Emacs porting targets
2873 now, but we want to make other targets possible.
2874 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2875 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2876 In the rest of the code, change types of integers that hold casted
2877 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2878 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2879 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2880 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2881 No need to cast type when ORing.
2882 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2883 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2884 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2885 assume EMACS_INT is the same width as char *.
2886 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2887 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2888 Remove no-longer-needed casts.
2889 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2890 (xg_tool_bar_help_callback, xg_make_tool_item):
2891 Use EMACS_INTPTR to hold an integer
2892 that will be cast to void *; this can avoid a GCC warning
2893 if EMACS_INT is not the same width as void *.
2894 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2895 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2896 (current_message_1, set_message_1):
2897 Use a local to convert to proper width without a cast.
2898 * xmenu.c (dialog_selection_callback): Likewise.
2900 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2901 Also, don't assume VALBITS / RAND_BITS is less than 5,
2902 and don't rely on undefined behavior when shifting a 1 left into
2904 * lisp.h (get_random): Change signature to match.
2906 * lread.c (hash_string): Use size_t, not int, for hash computation.
2907 Normally we prefer signed values; but hashing is special, because
2908 it's better to use unsigned division on hash table sizes so that
2909 the remainder is nonnegative. Also, size_t is the natural width
2910 for hashing into memory. The previous code used 'int', which doesn't
2911 retain enough info to hash well into very large tables.
2912 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2914 * dbusbind.c: Don't possibly lose pointer info when converting.
2915 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2916 Use XPNTR rather than XHASH, so that the high-order bits of
2917 the pointer aren't lost when converting through void *.
2919 * eval.c (Fautoload): Don't double-shift a pointer.
2921 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2923 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2925 * gnutls.c (DEF_GNUTLS_FN):
2926 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2928 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2930 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2933 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2935 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2936 New version that can reserve upto 2GB of heap space.
2938 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2940 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2942 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2944 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2945 `gnutls_certificate_set_x509_key_file'.
2947 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2949 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2950 Update dependencies.
2952 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2954 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2955 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2956 Remove unused parameter `fildes'.
2957 * process.c (read_process_output, send_process): Don't pass it.
2959 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2961 Fix previous change: the library cache is defined in w32.c.
2962 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2963 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2965 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2967 Implement dynamic loading of GnuTLS on Windows.
2969 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2970 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2971 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2974 * gnutls.c (Qgnutls_dll): Define.
2975 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2976 (gnutls_*): Declare function pointers.
2977 (init_gnutls_functions): New function to initialize function pointers.
2978 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2979 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2980 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2981 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2982 (emacs_gnutls_write, emacs_gnutls_read)
2983 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2984 (Fgnutls_available_p): New function.
2985 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2986 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2987 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2989 * image.c: Include w32.h.
2990 (Vimage_type_cache): Delete.
2991 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2992 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2993 (w32_delayed_load): Move to w32.c.
2995 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2997 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2998 (w32_delayed_load): Move from image.c. When loading a library, record
2999 its filename in the :loaded-from property of the library id.
3000 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3001 Initialize and staticpro them.
3002 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3004 * process.c: Include lisp.h before w32.h, not after.
3005 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3006 instead of gnutls_record_check_pending.
3008 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3010 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3012 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3013 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3016 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3018 * xterm.c (x_set_frame_alpha): Do not set property on anything
3019 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3021 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3023 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3025 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3027 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3028 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3029 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3030 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3031 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3032 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3033 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3034 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3035 (Qgnutls_bootprop_callbacks_verify): Make static.
3037 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3039 * callproc.c: Indentation fixup.
3041 * sysdep.c (wait_for_termination_1): Make static.
3042 (wait_for_termination, interruptible_wait_for_termination):
3043 Move after wait_for_termination_1.
3045 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3047 * sysdep.c (interruptible_wait_for_termination): New function
3048 which is like wait_for_termination, but allows keyboard
3051 * callproc.c (Fcall_process): Add (:file "file") as an option for
3053 (Fcall_process_region): Ditto.
3055 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3057 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3058 rather than `XVECTOR (FOO)->size'.
3060 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3061 inttypes.h, as a gnulib replacement is used if it not available in
3064 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3066 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3067 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3068 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3070 * coding.c (coding_alloc_by_realloc): Error out if destination
3071 will grow beyond MOST_POSITIVE_FIXNUM.
3072 (decode_coding_emacs_mule): Abort if there isn't enough place in
3073 charbuf for the composition carryover bytes. Reserve an extra
3074 space for up to 2 characters produced in a loop.
3075 (decode_coding_iso_2022): Abort if there isn't enough place in
3076 charbuf for the composition carryover bytes.
3078 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3080 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3081 aborting when %lld or %lll format is passed.
3082 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3083 %llo or %llx format is passed. (Bug#8545)
3085 * window.c (window_scroll_line_based): Use a marker instead of
3086 simple variables to record original value of point. (Bug#7952)
3088 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3089 produced by %s or %c overflows available buffer space. (Bug#8545)
3091 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3093 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3094 (SIZE_MAX): Move defn after all includes, as they might #define it.
3096 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3098 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3100 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3102 * keyboard.c (Qdelayed_warnings_hook): Define.
3103 (command_loop_1): Run `delayed-warnings-hook'
3104 if Vdelayed_warnings_list is non-nil.
3105 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3106 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3108 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3110 * doprnt.c (doprnt): Don't return value smaller than the buffer
3111 size if the message was truncated. (Bug#8545).
3113 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3115 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3116 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3118 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3120 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3122 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3124 * makefile.w32-in: Update dependencies.
3126 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3128 Improve `doprnt' and its usage. (Bug#8545)
3129 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3130 `format_end'. Remove support for %l as a conversion specifier.
3131 Don't use xrealloc. Improve diagnostics when the %l size modifier
3132 is used. Update the commentary.
3134 * eval.c (verror): Simplify calculation of size_t.
3136 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3139 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3141 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3144 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3146 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3147 This makes this file independent of the recent pseudovector change.
3149 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3151 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3153 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3154 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3155 Remove unused local.
3156 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3158 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3159 GCC 4.6.0 optimizes based on type-based alias analysis.
3160 For example, if b is of type struct buffer * and v of type struct
3161 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3162 != &v->size, and therefore "v->size = 1; b->size = 2; return
3163 v->size;" must therefore return 1. This assumption is incorrect
3164 for Emacs, since it type-puns struct Lisp_Vector * with many other
3165 types. To fix this problem, this patch adds a new type struct
3166 vectorlike_header that documents the constraints on layout of vectors
3167 and pseudovectors, and helps optimizing compilers not get fooled
3168 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3169 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3170 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3172 (XSETPVECTYPE): Rewrite in terms of new macro.
3173 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3174 This is a bit clearer, and further avoids the possibility of
3175 undesirable aliasing.
3176 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3177 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3178 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3179 since Lisp_Subr is a special case (no "next" field).
3180 (ASIZE): Now uses header.size rather than size.
3181 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3182 to avoid the hassle of writing XVECTOR (foo)->header.size.
3183 (struct vectorlike_header): New type.
3184 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3185 object, to help avoid aliasing.
3186 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3187 (SUBRP): Likewise, since Lisp_Subr is a special case.
3188 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3189 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3190 (struct Lisp_Hash_Table): Combine first two members into a single
3191 struct vectorlike_header member. All uses of "size" and "next" members
3192 changed to be "header.size" and "header.next".
3193 * buffer.h (struct buffer): Likewise.
3194 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3195 * frame.h (struct frame): Likewise.
3196 * process.h (struct Lisp_Process): Likewise.
3197 * termhooks.h (struct terminal): Likewise.
3198 * window.c (struct save_window_data, struct saved_window): Likewise.
3199 * window.h (struct window): Likewise.
3200 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3201 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3202 * buffer.c (init_buffer_once): Likewise.
3203 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3205 * process.c (Fformat_network_address): Use local var for size,
3208 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3210 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3211 * data.c (atof): Remove decl; no longer used or needed.
3212 (digit_to_number): Move to lread.c.
3213 (Fstring_to_number): Use new string_to_number function, to be
3214 consistent with how the Lisp reader treats infinities and NaNs.
3215 Do not assume that floating-point numbers represent EMACS_INT
3216 without losing information; this is not true on most 64-bit hosts.
3217 Avoid double-rounding errors, by insisting on integers when
3218 parsing non-base-10 numbers, as the documentation specifies.
3219 * lisp.h (string_to_number): New decl, replacing ...
3220 (isfloat_string): Remove.
3221 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3222 (read1): Do not accept +. and -. as integers; this
3223 appears to have been a coding error. Similarly, do not accept
3224 strings like +-1e0 as floating point numbers. Do not report
3225 overflow for integer overflows unless the base is not 10 which
3226 means we have no simple and reliable way to continue.
3227 Break out the floating-point parsing into a new
3228 function string_to_number, so that Fstring_to_number parses
3229 floating point numbers consistently with the Lisp reader.
3230 (digit_to_number): Move here from data.c. Make it static inline.
3231 (E_CHAR, EXP_INT): Remove, replacing with ...
3232 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3233 (string_to_number): New function, replacing isfloat_string.
3234 This function checks for valid syntax and produces the resulting
3235 Lisp float number too. Rework it so that string-to-number
3236 no longer mishandles examples like "1.0e+". Use strtoumax,
3237 so that overflow for non-base-10 numbers is reported only when
3238 there's no portable and simple way to convert to floating point.
3240 * textprop.c (set_text_properties_1): Rewrite for clarity,
3241 and to avoid GCC warning about integer overflow.
3243 * intervals.h (struct interval): Use EMACS_INT for members
3244 where EMACS_UINT might cause problems. See
3245 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3246 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3247 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3249 (offset_intervals): Tell GCC not to worry about length overflow
3250 when negating a negative length.
3252 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3253 (overrun_check_free): Likewise.
3255 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3256 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3259 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3260 (gnutls_make_error): Rename local to avoid shadowing.
3261 (gnutls_emacs_global_deinit): ifdef out; not used.
3262 (Fgnutls_boot): Use const for pointer to readonly storage.
3263 Comment out unused local. Fix pointer signedness problems.
3265 * lread.c (openp): Don't stuff size_t into an 'int'.
3266 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3267 about possible signed overflow.
3269 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3270 (GDK_KEY_g): Don't define if already defined.
3271 (xg_prepare_tooltip): Avoid pointer signedness problem.
3272 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3274 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3275 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3277 * xfns.c (Fx_window_property): Simplify a bit,
3278 to make a bit faster and to avoid GCC 4.6.0 warning.
3279 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3281 * fns.c (internal_equal): Don't assume size_t fits in int.
3283 * alloc.c (compact_small_strings): Tighten assertion a little.
3285 Replace pEd with more-general pI, and fix some printf arg casts.
3286 * lisp.h (pI): New macro, generalizing old pEd macro to other
3287 conversion specifiers. For example, use "...%"pI"d..." rather
3288 than "...%"pEd"...".
3289 (pEd): Remove. All uses replaced with similar uses of pI.
3290 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3291 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3292 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3293 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3294 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3295 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3296 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3298 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3299 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3300 * print.c (safe_debug_print, print_object): Likewise.
3301 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3303 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3304 avoiding the 0 flag, which is not portable.
3305 * process.c (Fmake_network_process): Use pI to avoid cast.
3306 * region-cache.c (pp_cache): Likewise.
3307 * xdisp.c (decode_mode_spec): Likewise.
3308 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3309 behavior on 64-bit hosts with printf arg.
3310 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3311 (x_stop_queuing_selection_requests): Likewise.
3312 (x_get_window_property): Don't truncate byte count to an 'int'
3315 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3316 here, since it parses constructs like leading '-' and spaces,
3317 which are not wanted; and it overflows with large numbers.
3318 Instead, simply match F[0-9]+, which is what is wanted anyway.
3320 * alloc.c: Remove unportable assumptions about struct layout.
3321 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3322 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3323 (allocate_vectorlike, make_pure_vector): Use the new macros,
3324 plus offsetof, to remove unportable assumptions about struct layout.
3325 These assumptions hold on all porting targets that I know of, but
3326 they are not guaranteed, they're easy to remove, and removing them
3327 makes further changes easier.
3329 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3330 This doesn't fix a bug but makes the code clearer.
3331 (string_overrun_cookie): Now const. Use initializers that
3332 don't formally overflow signed char, to avoid warnings.
3333 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3334 can cause Emacs to crash when string overrun checking is enabled.
3335 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3336 multiple of sizeof (EMACS_INT); it need not be, if
3337 alignof(EMACS_INT) < sizeof (EMACS_INT).
3338 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3340 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3342 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3344 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3346 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3347 supposed to be handshaking. (Bug#8556)
3348 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3350 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3352 * lisp.h (Qdebug): List symbol.
3353 * eval.c (Qdebug): Restore global linkage.
3354 * keyboard.c (debug-on-event): New variable.
3355 (handle_user_signal): Break into debugger when debug-on-event
3356 matches the current signal symbol.
3358 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3360 * alloc.c (check_sblock, check_string_bytes)
3361 (check_string_free_list): Convert to standard C.
3363 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3365 * w32.c (emacs_gnutls_push): Fix typo.
3367 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3369 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3370 "cast to pointer from integer of different size".
3372 Improve doprnt and its use in verror. (Bug#8545)
3373 * doprnt.c (doprnt): Document the set of format control sequences
3374 supported by the function. Use SAFE_ALLOCA instead of always
3377 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3378 is one byte too soon. Don't use xrealloc; instead xfree and
3381 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3383 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3386 * gnutls.c: Renamed global_initialized to
3387 gnutls_global_initialized. Added internals for the
3388 :verify-hostname-error, :verify-error, and :verify-flags
3389 parameters of `gnutls-boot' and documented those parameters in the
3390 docstring. Start callback support.
3391 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3392 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3393 on error. Return error code.
3394 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3395 (emacs_gnutls_read): Likewise.
3396 (Fgnutls_boot): Return handshake error code.
3397 (emacs_gnutls_handle_error): New function.
3398 (wsaerror_to_errno): Likewise.
3400 * w32.h (emacs_gnutls_pull): Add prototype.
3401 (emacs_gnutls_push): Likewise.
3403 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3404 (emacs_gnutls_push): Likewise.
3406 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3408 * process.c (wait_reading_process_output): Check if GnuTLS
3409 buffered some data internally if no FDs are set for TLS
3412 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3413 (LIBS): Link to USER_LIBS.
3414 ($(BLD)/gnutls.$(0)): New target.
3416 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3418 * xdisp.c (handle_single_display_spec): Rename the
3419 display_replaced_before_p argument into display_replaced_p, to
3420 make it consistent with the commentary. Fix typos in the
3423 * textprop.c (syms_of_textprop): Remove dead code.
3424 (copy_text_properties): Delete obsolete commentary about an
3425 interface that was deleted long ago. Fix typos in the description
3428 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3429 to changes in oldXMenu/XMenu.h from 2011-04-16.
3430 <menu_help_message, prev_menu_help_message>: Constify.
3431 (IT_menu_make_room): menu->help_text is now `const char **';
3434 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3435 to changes in oldXMenu/XMenu.h from 2011-04-16.
3436 (struct XMenu): Declare `help_text' `const char **'.
3438 * xfaces.c <Qunspecified>: Make extern again.
3440 * syntax.c: Include sys/types.h before including regex.h, as
3443 * doc.c (get_doc_string): Improve the format passed to `error'.
3445 * doprnt.c (doprnt): Improve commentary.
3447 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3449 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3452 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3453 changes in globals.h immediately force recompilation.
3454 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3455 $(CURDIR)/s/ms-w32.h.
3456 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3458 * character.c (Fchar_direction): Function deleted.
3459 (syms_of_character): Don't defsubr it.
3460 <char-direction-table>: Deleted.
3462 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3464 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3465 * doprnt.c: Include limits.h.
3466 (SIZE_MAX): New macro.
3467 (doprnt): Return a size_t value. 2nd arg is now size_t.
3468 Many local variables are now size_t instead of int or unsigned.
3469 Improve overflow protection. Support `l' modifier for integer
3470 conversions. Support %l conversion. Don't assume an EMACS_INT
3471 argument for integer conversions and for %c.
3473 * lisp.h (doprnt): Restore prototype.
3475 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3478 * Makefile.in (base_obj): Add back doprnt.o.
3480 * deps.mk (doprnt.o): Add back prerequisites.
3481 (callint.o): Depend on character.h.
3483 * eval.c (internal_lisp_condition_case): Include the handler
3484 representation in the error message.
3485 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3486 when breaking from the loop.
3488 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3490 * callint.c (Fcall_interactively): When displaying error message
3491 about invalid control letter, pass the character's codepoint, not
3492 a pointer to its multibyte form. Improve display of the character
3493 in octal and display also its hex code.
3495 * character.c (char_string): Use %x to display the (unsigned)
3496 codepoint of an invalid character, to avoid displaying a bogus
3499 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3500 `error', not SYMBOL_NAME itself.
3502 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3503 character arguments to `error'.
3505 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3506 to `error' in error message about FINAL_CHAR argument. Make sure
3507 FINAL_CHAR is a character, and use %c when it is passed as
3508 argument to `error'.
3510 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3512 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3514 * w32.c: Include <time.h>.
3515 (sys_localtime): New function.
3517 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3519 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3521 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3523 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3525 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3528 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3530 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3531 gl_state.e_property when gl_state.object is Qt.
3533 * insdel.c (make_gap_larger): Remove limitation of buffer size
3536 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3538 * xdisp.c (lookup_glyphless_char_display)
3539 (produce_glyphless_glyph): Handle cons cell entry in
3540 glyphless-char-display.
3541 (Vglyphless_char_display): Document it.
3543 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3544 glyphless-char-display.
3546 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3548 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3550 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3552 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3553 definition for no-X builds.
3555 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3557 Static checks with GCC 4.6.0 and non-default toolkits.
3559 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3561 * process.c (keyboard_bit_set): Define only if SIGIO.
3562 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3563 (send_process): Repair possible setjmp clobbering.
3565 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3567 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3569 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3571 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3572 Define only if needed.
3574 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3575 by pacifying GCC about it. Maybe it's time to retire it?
3576 * xfaces.c (USG, __TIMEVAL__): Likewise.
3578 * dispextern.h (struct redisplay_interface): Rename param
3580 * termhooks.h (struct terminal): Likewise.
3581 * xterm.c (xembed_send_message): Likewise.
3583 * insdel.c (make_gap_smaller): Define only if
3584 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3586 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3589 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3590 so that we aren't warned about unused symbols.
3592 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3594 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3596 * xfns.c (x_real_positions): Mark locals as initialized.
3598 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3600 * xterm.c: Fix problems found by static analysis with other toolkits.
3601 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3602 (x_dispatch_event): Declare static if USE_GTK, and
3603 define if USE_GTK || USE_X_TOOLKIT.
3604 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3605 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3606 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3607 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3609 * xmenu.c (menu_help_callback): Pointer type fixes.
3610 Use const pointers when pointing at readonly data. Avoid pointer
3612 (FALSE): Remove unused macro.
3613 (update_frame_menubar): Remove unused decl.
3615 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3617 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3618 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3619 (single_menu_item): Rename local to avoid shadowing.
3621 * keyboard.c (make_lispy_event): Remove unused local var.
3623 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3624 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3626 * bitmaps: Change bitmaps from unsigned char back to the X11
3627 compatible char. Avoid the old compiler warnings about
3628 out-of-range initializers by using, for example, '\xab' rather
3631 * xgselect.c (xgselect_initialize): Check vs interface
3632 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3634 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3636 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3637 to read-only memory.
3639 * fns.c (vector): Remove; this old hack is no longer needed.
3641 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3643 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3645 * xrdb.c (x_load_resources): Omit unused local.
3647 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3648 (x_window): Rename locals to avoid shadowing.
3649 (USG): Use the kludged USG macro, to pacify gcc.
3651 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3652 (x_term_init): Remove local to avoid shadowing.
3654 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3656 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3657 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3659 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3661 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3663 Fix regex.c, syntax.c and friends for buffers > 2GB.
3664 * syntax.h (struct gl_state_s): Declare character position members
3667 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3669 * textprop.c (verify_interval_modification, interval_of):
3670 Declare arguments EMACS_INT.
3672 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3675 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3677 * indent.c (Fvertical_motion): Local variable it_start is now
3680 * regex.c (re_match, re_match_2, re_match_2_internal)
3681 (bcmp_translate, regcomp, regexec, print_double_string)
3682 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3683 (re_compile_pattern, re_exec): Declare arguments and local
3684 variables `size_t' and `ssize_t' and return values `regoff_t', as
3686 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3687 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3688 <compile_stack_type>: `size' and `avail' are now `size_t'.
3690 * regex.h <regoff_t>: Use ssize_t, not int.
3691 (re_search, re_search_2, re_match, re_match_2): Arguments that
3692 specify buffer/string position and length are now ssize_t and
3693 size_t. Return type is regoff_t.
3695 2011-04-16 Ben Key <bkey76@gmail.com>
3697 * nsfont.m: Fixed bugs in ns_get_family and
3698 ns_descriptor_to_entity that were caused by using free to
3699 deallocate memory blocks that were allocated by xmalloc (via
3700 xstrdup). This caused Emacs to crash when compiled with
3701 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3702 --enable-checking=xmallocoverrun). xfree is now used to
3703 deallocate these memory blocks.
3705 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3707 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3709 emacs_write: Accept and return EMACS_INT for sizes.
3710 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3712 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3713 Accept and return EMACS_INT.
3714 (emacs_gnutls_write): Return the number of bytes written on
3716 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3717 (emacs_read, emacs_write): Remove check for negative size, as the
3718 Emacs source code has been audited now.
3719 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3720 (emacs_read, emacs_write): Use it.
3721 * process.c (send_process): Adjust to the new signatures of
3722 emacs_write and emacs_gnutls_write. Do not attempt to store
3723 a byte offset into an 'int'; it might overflow.
3724 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3726 * sound.c: Don't assume sizes fit in 'int'.
3727 (struct sound_device.period_size, alsa_period_size):
3728 Return EMACS_INT, not int.
3729 (struct sound_device.write, vox_write, alsa_write):
3730 Accept EMACS_INT, not int.
3731 (wav_play, au_play): Use EMACS_INT to store sizes and to
3732 record read return values.
3734 2011-04-15 Ben Key <bkey76@gmail.com>
3736 * keyboard.c (Qundefined): Don't declare static since it is used
3738 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3739 static since they are used in nsfont.m.
3741 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3743 * process.c (Qprocessp): Don't declare static.
3744 * lisp.h (Qprocessp): Declare again.
3746 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3748 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3750 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3752 Improve C-level modularity by making more things 'static'.
3754 Don't publish debugger-only interfaces to other modules.
3755 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3756 (verify_bytepos, count_markers): Move decls to the only modules
3758 * region-cache.h (pp_cache): Likewise.
3759 * window.h (check_all_windows): Likewise.
3760 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3762 * sysdep.c (croak): Now static, if
3763 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3764 * syssignal.h (croak): Declare only if not static.
3766 * alloc.c (refill_memory_reserve): Now static if
3767 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3768 * lisp.h (refill_memory_reserve): Declare only if not static.
3770 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3771 Define only if USE_LUCID.
3773 * xrdb.c (x_customization_string, x_rm_string): Now static.
3775 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3776 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3778 * xdisp.c (draw_row_with_mouse_face): Now static.
3779 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3781 * window.h (check_all_windows): Mark externally visible.
3783 * window.c (window_deletion_count): Now static.
3785 * undo.c: Make symbols static if they're not exported.
3786 (last_undo_buffer, last_boundary_position, pending_boundary):
3789 * textprop.c (interval_insert_behind_hooks): Now static.
3790 (interval_insert_in_front_hooks): Likewise.
3792 * term.c: Make symbols static if they're not exported.
3793 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3794 (max_frame_lines, tty_set_terminal_modes):
3795 (tty_reset_terminal_modes, tty_turn_off_highlight):
3796 (get_tty_terminal): Now static.
3797 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3798 * termhooks.h (term_mouse_moveto): Do not declare if
3800 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3801 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3803 * sysdep.c: Make symbols static if they're not exported.
3804 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3806 (sigprocmask_set, full_mask): Remove; unused.
3807 (wait_debugging): Mark as visible.
3808 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3809 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3811 * syntax.c (syntax_temp): Define only if !__GNUC__.
3813 * sound.c (current_sound_device, current_sound): Now static.
3815 * search.c (searchbufs, searchbuf_head): Now static.
3817 * scroll.c (scroll_cost): Remove; unused.
3818 * dispextern.h (scroll_cost): Remove decl.
3820 * region-cache.h (pp_cache): Mark as externally visible.
3822 * process.c: Make symbols static if they're not exported.
3823 (process_tick, update_tick, create_process, chan_process):
3824 (Vprocess_alist, proc_buffered_char, datagram_access):
3825 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3826 (deactivate_process): Mark defn as static, as well as decl.
3827 * lisp.h (create_process): Remove decl.
3828 * process.h (chan_process, Vprocess_alist): Remove decls.
3830 * print.c: Make symbols static if they're not exported.
3831 (print_depth, new_backquote_output, being_printed, print_buffer):
3832 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3833 (print_interval, print_number_index, initial_stderr_stream):
3835 * lisp.h (Fprinc): Remove decl.
3836 (debug_output_compilation_hack): Mark as externally visible.
3838 * sysdep.c (croak): Move decl from here to syssignal.h.
3839 * syssignal.h (croak): Put it here, so the API can be checked when
3840 'croak' is called from dissociate_if_controlling_tty.
3842 * minibuf.c: Make symbols static if they're not exported.
3843 (minibuf_save_list, choose_minibuf_frame): Now static.
3844 * lisp.h (choose_minibuf_frame): Remove decl.
3846 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3848 * lread.c: Make symbols static if they're not exported.
3849 (read_objects, initial_obarray, oblookup_last_bucket_number):
3851 (make_symbol): Remove; unused.
3852 * lisp.h (initial_obarray, make_symbol): Remove decls.
3854 * keyboard.c: Make symbols static if they're not exported.
3855 (single_kboard, recent_keys_index, total_keys, recent_keys):
3856 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3857 (this_single_command_key_start, echoing, last_auto_save):
3858 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3859 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3860 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3861 (Vlispy_mouse_stem, double_click_count):
3863 (force_auto_save_soon): Define only if SIGDANGER.
3864 (ignore_mouse_drag_p): Now static if
3865 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3866 (print_help): Remove; unused.
3867 (stop_character, last_timer_event): Mark as externally visible.
3868 * keyboard.h (ignore_mouse_drag_p): Declare only if
3869 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3870 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3871 * lisp.h (echoing): Remove decl.
3872 (force_auto_save_soon): Declare only if SIGDANGER.
3873 * xdisp.c (redisplay_window): Simplify code, to make it more
3874 obvious that ignore_mouse_drag_p is not accessed if !defined
3875 USE_GTK && !defined HAVE_NS.
3877 * intervals.c: Make symbols static if they're not exported.
3878 (merge_properties_sticky, merge_interval_right, delete_interval):
3880 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3882 * insdel.c: Make symbols static if they're not exported.
3883 However, leave prepare_to_modify_buffer alone. It's never
3884 called from outside this function, but that appears to be a bug.
3885 (combine_after_change_list, combine_after_change_buffer):
3886 (adjust_after_replace, signal_before_change): Now static.
3887 (adjust_after_replace_noundo): Remove; unused.
3888 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3889 (signal_before_change): Remove decls.
3891 * indent.c (val_compute_motion, val_vmotion): Now static.
3893 * image.c: Make symbols static if they're not exported.
3894 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3896 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3897 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3899 * fringe.c (standard_bitmaps): Now static.
3900 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3902 * frame.c: Make symbols static if they're not exported.
3903 (x_report_frame_params, make_terminal_frame): Now static.
3904 (get_frame_param): Now static, unless HAVE_NS.
3905 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3906 (x_get_resource_string): Remove; not used.
3907 * frame.h (make_terminal_frame, x_report_frame_params):
3908 (x_get_resource_string); Remove decls.
3909 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3910 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3912 * font.c, fontset.c: Make symbols static if they're not exported.
3913 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3914 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3915 * font.c (font_close_object): Now static.
3916 * font.h (font_close_object): Remove.
3917 * fontset.c (FONTSET_OBJLIST): Remove.
3918 (free_realized_fontset) #if-0 the body, which does nothing.
3919 (face_suitable_for_char_p): #if-0, as it's never called.
3920 * fontset.h (face_suitable_for_char_p): Remove decl.
3921 * xfaces.c (face_at_string_position):
3922 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3923 since 0 is always ASCII.
3925 * fns.c (weak_hash_tables): Now static.
3927 * fileio.c: Make symbols static if they're not exported.
3928 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3929 (Vwrite_region_annotation_buffers): Now static.
3931 * eval.c: Make symbols static if they're not exported.
3932 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3933 * lisp.h (backtrace_list): Remove decl.
3935 * emacs.c: Make symbols static if they're not exported.
3936 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3937 (fatal_error_code, fatal_error_signal_hook, standard_args):
3939 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3940 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3941 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3942 * lisp.h (fatal_error_signal_hook): Remove decl.
3943 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3945 * editfns.c: Move a (normally-unused) function to its only use.
3946 * editfns.c, lisp.h (get_operating_system_release): Remove.
3947 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3948 worth the hassle of breaking this out.
3950 * xterm.c: Make symbols static if they're not exported.
3951 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3952 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3953 (x_destroy_window, x_delete_display):
3955 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3956 (x_mouse_leave): Remove; unused.
3957 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3958 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3959 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3961 (x_mouse_leave): Declare only if WINDOWSNT.
3962 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3963 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3966 * ftxfont.c: Make symbols static if they're not exported.
3967 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3969 * font.h (ftxfont_driver): Likewise.
3971 * xfns.c: Make symbols static if they're not exported.
3972 (x_last_font_name, x_display_info_for_name):
3973 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3974 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3975 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3976 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3977 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3978 (last_show_tip_args): Now static.
3979 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3980 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3981 (x_screen_planes): Remove; unused.
3982 * dispextern.h (x_screen_planes): Remove decl.
3984 * dispnew.c: Make symbols static if they're not exported.
3985 * dispextern.h (redraw_garbaged_frames, scrolling):
3986 (increment_row_positions): Remove.
3987 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3988 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3990 (redraw_garbaged_frames): Remove; unused.
3992 * xfaces.c: Make symbols static if they're not exported.
3993 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3995 * xterm.h (defined_color): Remove decls.
3996 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3997 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3998 (menu_face_changed_default, defined_color, free_realized_face):
3999 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4000 (ascii_face_of_lisp_face): Remove; unused.
4002 * xdisp.c: Make symbols static if they're not exported.
4003 * dispextern.h (scratch_glyph_row, window_box_edges):
4004 (glyph_to_pixel_coords, set_cursor_from_row):
4005 (get_next_display_element, set_iterator_to_next):
4006 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4007 (show_mouse_face): Remove decls
4008 * frame.h (message_buf_print): Likewise.
4009 * lisp.h (pop_message, set_message, check_point_in_composition):
4011 * xterm.h (set_vertical_scroll_bar): Likewise.
4012 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4013 (message_buf_print, scratch_glyph_row, displayed_buffer):
4014 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4015 (get_next_display_element, show_mouse_face, window_box_edges):
4016 (frame_to_window_pixel_xy, check_point_in_composition):
4017 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4018 (glyph_to_pixel_coords): Remove; unused.
4020 * dired.c (file_name_completion): Now static.
4022 * dbusbind.c (xd_in_read_queued_messages): Now static.
4024 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4025 * data.c (circular_list_error): Remove.
4027 * commands.h (last_point_position, last_point_position_buffer):
4028 (last_point_position_window): Remove decls.
4029 * keyboard.c: Make these variables static.
4031 * coding.h (coding, code_convert_region, encode_coding_gap):
4033 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4034 (iso_code_class, detect_coding, code_convert_region): Now static.
4035 (encode_coding_gap): Remove; unused.
4037 * chartab.c (chartab_chars, chartab_bits): Now static.
4039 * charset.h (charset_iso_8859_1): Remove decl.
4040 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4043 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4044 * ccl.c (Vccl_program_table): Now static.
4045 (check_ccl_update): Remove; unused.
4047 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4048 * category.h: ... from here.
4049 * category.c (check_category_table, set_category_set): Now static.
4051 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4052 * lisp.h: Remove these decls.
4054 * buffer.c (buffer_count): Remove unused var.
4056 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4057 so that it's not optimized away.
4058 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4059 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4060 exported only to the debugger.
4062 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4063 * atimer.h (run_all_atimers): Remove; not exported.
4065 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4066 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4067 was inaccessible from Lisp.
4068 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4069 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4071 alloc.c: Import and export fewer symbols, and remove unused items.
4072 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4074 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4075 it's not optimized away by whole-program optimization.
4076 (message_enable_multibyte, free_misc): Remove.
4077 (catchlist, handlerlist, mark_backtrace):
4078 Declare only if BYTE_MARK_STACK.
4079 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4080 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4081 (message_enable_multibyte): Remove decl.
4082 (free_misc, interval_free_list, float_block, float_block_index):
4083 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4084 (cons_free_list, last_marked_index):
4086 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4087 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4088 (mark_backtrace): Define only if BYTE_MARK_STACK.
4089 * xdisp.c (message_enable_multibyte): Now static.
4091 Declare Lisp_Object Q* variables to be 'static' if not exported.
4092 This makes it easier for human readers (and static analyzers)
4093 to see whether these variables are used from other modules.
4094 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4095 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4096 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4097 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4098 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4099 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4100 * xmenu.c, xselect.c:
4101 Declare Q* vars static if they are not used in other modules.
4102 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4103 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4104 Remove decls of unexported vars.
4105 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4107 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4109 Make Emacs functions such as Fatom 'static' by default.
4110 This makes it easier for human readers (and static analyzers)
4111 to see whether these functions can be called from other modules.
4112 DEFUN now defines a static function. To make the function external
4113 so that it can be used in other C modules, use the new macro DEFUE.
4114 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4115 (Finit_image_library):
4116 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4117 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4118 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4119 Remove decls, since these functions are now static.
4120 (Funintern, Fget_internal_run_time): New decls, since these functions
4121 were already external.
4123 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4124 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4125 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4126 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4127 * keyboard.c, keymap.c, lread.c:
4128 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4129 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4130 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4131 Mark functions with DEFUE instead of DEFUN,
4132 if they are used in other modules.
4133 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4134 decls for now-static functions.
4135 * buffer.h (Fdelete_overlay): Remove decl.
4136 * callproc.c (Fgetenv_internal): Mark as internal.
4137 * composite.c (Fremove_list_of_text_properties): Remove decl.
4138 (Fcomposition_get_gstring): New forward static decl.
4139 * composite.h (Fcomposite_get_gstring): Remove decl.
4140 * dired.c (Ffile_attributes): New forward static decl.
4141 * doc.c (Fdocumntation_property): New forward static decl.
4142 * eval.c (Ffetch_bytecode): New forward static decl.
4143 (Funintern): Remove extern decl; now in .h file where it belongs.
4144 * fileio.c (Fmake_symbolic_link): New forward static decl.
4145 * image.c (Finit_image_library): New forward static decl.
4146 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4147 * intervals.h (Fprevious_property_change):
4148 (Fremove_list_of_text_properties): Remove decls.
4149 * keyboard.c (Fthis_command_keys): Remove decl.
4150 (Fcommand_execute): New forward static decl.
4151 * keymap.c (Flookup_key): New forward static decl.
4152 (Fcopy_keymap): Now static.
4153 * keymap.h (Flookup_key): Remove decl.
4154 * process.c (Fget_process): New forward static decl.
4155 (Fprocess_datagram_address): Mark as internal.
4156 * syntax.c (Fsyntax_table_p): New forward static decl.
4157 (skip_chars): Remove duplicate decl.
4158 * textprop.c (Fprevious_property_change): New forward static decl.
4159 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4161 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4162 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4164 * editfns.c (Fformat): Remove unreachable code.
4166 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4168 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4171 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4173 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4174 when at ZV. (Bug#8487)
4176 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4178 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4180 * keyboard.c (parse_tool_bar_item): Likewise.
4181 * sound.c (sound_cleanup, alsa_close): Likewise.
4182 * termcap.c (tgetent): Likewise.
4183 * xfns.c (x_default_font_parameter): Likewise.
4184 * xsettings.c (read_and_apply_settings): Likewise.
4186 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4187 (overrun_check_free): Protoize.
4189 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4191 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4192 since callers should never pass a negative size.
4193 Change the signature to match that of plain 'read' and 'write'; see
4194 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4195 * lisp.h: Update prototypes of emacs_write and emacs_read.
4197 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4199 * xdisp.c (redisplay_window): Don't try to determine the character
4200 position of the scroll margin if the window start point w->startp
4201 is outside the buffer's accessible region. (Bug#8468)
4203 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4205 Fix write-region and its subroutines for buffers > 2GB.
4206 * fileio.c (a_write, e_write): Modify declaration of arguments and
4207 local variables to support buffers larger than 2GB.
4208 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4210 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4211 argument, local variables, and return value.
4213 * lisp.h: Update prototypes of emacs_write and emacs_read.
4215 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4217 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4219 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4221 Fix more problems found by GCC 4.6.0's static checks.
4223 * xdisp.c (vmessage): Use a better test for character truncation.
4225 * charset.c (load_charset_map): <, not <=, for optimization,
4226 and to avoid potential problems with integer overflow.
4227 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4228 * casetab.c (set_identity, shuffle): Likewise.
4229 * editfns.c (Fformat): Likewise.
4230 * syntax.c (skip_chars): Likewise.
4232 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4233 This also lets GCC 4.6.0 generate slightly better loop code.
4235 * callint.c (Fcall_interactively): <, not <=, for optimization.
4236 (Fcall_interactively): Count the number of arguments produced,
4237 not the number of arguments given. This is simpler and lets GCC
4238 4.6.0 generate slightly better code.
4240 * ftfont.c: Distingish more carefully between FcChar8 and char.
4241 The previous code passed unsigned char * to a functions like
4242 strlen and xstrcasecmp that expect char *, which does not
4243 conform to the C standard.
4244 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4245 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4246 char * when the C standard requires it.
4248 * keyboard.c (read_char): Remove unused var.
4250 * eval.c: Port to Windows vsnprintf (Bug#8435).
4252 (SIZE_MAX): Define if the headers do not.
4253 (verror): Do not give up if vsnprintf returns a negative count.
4254 Instead, grow the buffer. This ports to Windows vsnprintf, which
4255 does not conform to C99. Problem reported by Eli Zaretskii.
4256 Also, simplify the allocation scheme, by avoiding the need for
4257 calling realloc, and removing the ALLOCATED variable.
4259 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4261 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4262 But keep the doprint source code for now, as we might revamp it
4263 and use it again (Bug#8435).
4264 * lisp.h (doprnt): Remove.
4265 * Makefile.in (base_obj): Remove doprnt.o.
4266 * deps.mk (doprnt.o): Remove.
4268 error: Print 32- and 64-bit integers portably (Bug#8435).
4269 Without this change, on typical 64-bit hosts error ("...%d...", N)
4270 was used to print both 32- and 64-bit integers N, which relied on
4272 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4274 * lisp.h (error, verror): Mark as printf-like functions.
4275 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4276 Report overflow in size calculations when allocating printf buffer.
4277 Do not truncate output string at its first null byte.
4278 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4279 Truncate the output at a character boundary, since vsnprintf does not
4281 * charset.c (check_iso_charset_parameter): Convert internal
4282 character to string before calling 'error', since %c now has the
4284 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4285 overflow when computing char to be passed to 'error'. Do not
4286 pass Lisp_Object to 'error'; pass the integer instead.
4287 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4288 formatted with plain %d.
4290 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4292 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4294 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4296 * xterm.c (x_catch_errors): Remove duplicate declaration.
4298 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4300 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4302 2011-04-10 Jim Meyering <meyering@redhat.com>
4304 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4305 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4306 return ssize_t not "int", and use size_t as the buffer length.
4307 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4308 * gnutls.h: Update declarations.
4309 * process.c (read_process_output): Use ssize_t, to match.
4310 (send_process): Likewise.
4312 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4314 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4316 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4318 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4319 Use unsigned char, to match FcChar8 type definition.
4321 * xterm.c (handle_one_xevent):
4322 * xmenu.c (create_and_show_popup_menu):
4323 * xselect.c (x_decline_selection_request)
4324 (x_reply_selection_request): Avoid type-punned deref of X events.
4326 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4328 Fix some uses of `int' instead of EMACS_INT.
4329 * search.c (string_match_1, fast_string_match)
4330 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4331 (scan_buffer, find_next_newline_no_quit)
4332 (find_before_next_newline, search_command, Freplace_match)
4333 (Fmatch_data): Make some `int' variables be EMACS_INT.
4335 * xdisp.c (display_count_lines): 3rd argument and return value now
4336 EMACS_INT. All callers changed.
4337 (pint2hrstr): Last argument is now EMACS_INT.
4339 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4340 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4341 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4342 (decode_coding_utf_16, decode_coding_emacs_mule)
4343 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4344 (decode_coding_ccl, decode_coding_charset)
4345 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4346 (decode_coding_iso_2022, decode_coding_emacs_mule)
4347 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4348 <char_offset, last_offset>: Declare EMACS_INT.
4349 (encode_coding_utf_8, encode_coding_utf_16)
4350 (encode_coding_emacs_mule, encode_invocation_designation)
4351 (encode_designation_at_bol, encode_coding_iso_2022)
4352 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4353 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4355 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4356 (encode_invocation_designation): Last argument P_NCHARS is now
4358 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4359 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4361 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4364 * ccl.c (Fccl_execute_on_string): Declare some variables
4367 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4369 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4371 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4373 * process.c (Fformat_network_address): Doc fix.
4375 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4377 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4379 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4381 * keyboard.c (read_char): Call Lisp function help-form-show,
4382 instead of using internal_with_output_to_temp_buffer.
4383 (Qhelp_form_show): New var.
4384 (syms_of_keyboard): Use DEFSYM macro.
4386 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4388 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4390 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4392 * process.c (Flist_processes): Remove to Lisp.
4393 (list_processes_1): Delete.
4395 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4397 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4399 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4401 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4403 Fix more problems found by GCC 4.6.0's static checks.
4405 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4407 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4409 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4411 * xdisp.c (vmessage): Mark as a printf-like function.
4413 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4415 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4417 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4418 printf-like functions.
4419 (tiff_load): Add casts to remove these marks before passing them
4420 to system-supplied API.
4422 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4424 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4425 This avoids several warnings with gcc -Wstrict-overflow.
4426 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4427 directly, rather than having caller test rule sign. This avoids
4428 some unnecessary tests.
4429 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4430 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4431 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4433 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4434 (xfont_open): Avoid unnecessary tests.
4436 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4438 * composite.h, composite.c (composition_gstring_put_cache):
4439 Use EMACS_INT, not int, for length.
4441 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4442 breaking out part of COMPOSITION_DECODE_RULE.
4443 (COMPOSITION_DECODE_RULE): Use it.
4444 * composite.c (get_composition_id): Remove unused local vars,
4445 by using the new macro.
4447 * textprop.c (set_text_properties_1): Change while to do-while,
4448 since the condition is always true at first.
4450 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4451 (interval_deletion_adjustment): Return unsigned value.
4454 * process.c (list_processes_1, create_pty, read_process_output):
4455 (exec_sentinel): Remove vars that were set but not used.
4456 (create_pty): Remove unnecessary "volatile"s.
4457 (Fnetwork_interface_info): Avoid possibility of int overflow.
4458 (read_process_output): Do adaptive read buffering even if carryover.
4459 (read_process_output): Simplify nbytes computation if buffered.
4461 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4463 * syntax.c (scan_words): Remove var that was set but not used.
4464 (update_syntax_table): Use unsigned instead of int.
4466 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4467 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4468 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4470 * print.c (print_error_message): Avoid int overflow.
4472 * font.c (font_list_entities): Redo for clarity,
4473 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4475 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4476 (font_score): Avoid potential overflow in diff calculation.
4478 * fns.c (substring_both): Remove var that is set but not used.
4479 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4481 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4483 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4484 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4485 can always succeed if overflow has undefined behavior.
4487 * search.c (boyer_moore, wordify): Remove vars set but not used.
4488 (wordify): Omit three unnecessary tests.
4490 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4491 All callers changed. This avoids the need for an unused var.
4493 * casefiddle.c (casify_region): Remove var that is set but not used.
4495 * dired.c (file_name_completion): Remove var that is set but not used.
4497 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4499 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4500 (Finsert_file_contents): Remove unnecessary code checking fd.
4502 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4503 Check for integer overflow on size calculations.
4505 * buffer.c (Fprevious_overlay_change): Remove var that is set
4508 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4509 Remove vars that are set but not used.
4510 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4511 (timer_check_2): Mark vars as initialized.
4513 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4515 * image.c (lookup_image): Remove var that is set but not used.
4516 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4518 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4519 that are set but not used.
4521 * xfns.c (make_invisible_cursor): Don't return garbage
4522 if XCreateBitmapFromData fails (Bug#8410).
4524 * xselect.c (x_get_local_selection, x_handle_property_notify):
4525 Remove vars that are set but not used.
4527 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4528 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4530 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4531 Remove var that is set but not used.
4532 (scroll_bar_windows_size): Now size_t, not int.
4533 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4536 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4537 (map_tty_color) [!defined MSDOS]: Likewise.
4539 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4541 * coding.c: Remove vars that are set but not used.
4542 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4543 All callers changed.
4544 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4545 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4546 (decode_coding_charset): Remove vars that are set but not used.
4548 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4549 that is set but not used.
4551 * print.c (print_object): Remove var that is set but not used.
4553 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4554 The gnulib version avoids calling malloc in the usual case,
4555 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4556 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4557 * filelock.c (current_lock_owner): Likewise.
4558 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4559 * sysdep.c: Include allocator.h, careadlinkat.h.
4560 (emacs_no_realloc_allocator): New static constant.
4561 (emacs_readlink): New function.
4562 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4563 ../lib/careadlinkat.h.
4565 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4567 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4568 first non-nil return value).
4570 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4572 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4573 if not defined (Bug#8403).
4575 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4577 * xdisp.c (display_count_lines): Remove parameter `start',
4578 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4579 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4580 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4581 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4582 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4583 and thereabouts. All callers changed.
4584 (get_per_char_metric): Remove parameter `f', unused since
4585 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4587 2011-04-02 Jim Meyering <meyering@redhat.com>
4589 do not dereference NULL upon failed strdup
4590 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4591 (ns_get_family): Likewise.
4593 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4595 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4597 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4599 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4602 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4604 Add lexical binding.
4606 * window.c (Ftemp_output_buffer_show): New fun.
4607 (Fsave_window_excursion):
4608 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4610 * lread.c (lisp_file_lexically_bound_p): New function.
4611 (Fload): Bind Qlexical_binding.
4612 (readevalloop): Remove `evalfun' arg.
4613 Bind Qinternal_interpreter_environment.
4614 (Feval_buffer): Bind Qlexical_binding.
4615 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4617 (syms_of_lread): Declare `lexical-binding'.
4619 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4621 * keyboard.c (eval_dyn): New fun.
4622 (menu_item_eval_property): Use it.
4624 * image.c (parse_image_spec): Use Ffunctionp.
4626 * fns.c (concat, mapcar1): Accept byte-code-functions.
4628 * eval.c (Fsetq): Handle lexical vars.
4629 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4630 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4631 (FletX, Flet): Obey lexical binding.
4632 (Fcommandp): Handle closures.
4633 (Feval): New `lexical' arg.
4634 (eval_sub): New function extracted from Feval. Use it almost
4635 everywhere where Feval was used. Look up vars in lexical env.
4637 (Ffunctionp): Move from subr.el.
4638 (Ffuncall): Handle closures.
4639 (apply_lambda): Remove `eval_flags'.
4640 (funcall_lambda): Handle closures and new byte-code-functions.
4641 (Fspecial_variable_p): New function.
4642 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4643 but without exporting it to Lisp.
4645 * doc.c (Fdocumentation, store_function_docstring):
4646 * data.c (Finteractive_form): Handle closures.
4648 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4651 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4653 (exec_byte_code): New function extracted from Fbyte_code to handle new
4654 calling convention for byte-code-functions. Add new byte-codes.
4656 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4658 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4660 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4662 * xdisp.c (redisplay_internal): Fix prototype.
4664 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4666 * xdisp.c (SCROLL_LIMIT): New macro.
4667 (try_scrolling): Use it when setting scroll_limit.
4668 Limit scrolling to 100 screen lines.
4669 (redisplay_window): Even when falling back on "recentering",
4670 position point in the window according to scroll-conservatively,
4671 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4673 (try_scrolling): When point is above the window, allow searching
4674 as far as scroll_max, or one screenful, to compute vertical
4675 distance from PT to the scroll margin position. This prevents
4676 try_scrolling from unnecessarily failing when
4677 scroll-conservatively is set to a value slightly larger than the
4678 window height. Clean up the case of PT below the margin at bottom
4679 of window: scroll_max can no longer be INT_MAX. When aggressive
4680 scrolling is in use, don't let point enter the opposite scroll
4681 margin as result of the scroll.
4682 (syms_of_xdisp) <scroll-conservatively>: Document the
4683 threshold of 100 lines for never-recentering scrolling.
4685 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4687 * dispextern.h (move_it_by_lines):
4688 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4689 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4690 (message_log_check_duplicate): Remove parameters `prev_bol' and
4691 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4692 (redisplay_internal): Remove parameter `preserve_echo_area',
4693 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4695 * indent.c (Fvertical_motion):
4696 * window.c (window_scroll_pixel_based, Frecenter):
4697 Don't pass `need_y_p' to `move_it_by_lines'.
4699 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4701 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4702 steal a few bits to be more compact.
4703 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4704 Remove unneeded casts.
4706 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4708 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4710 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4711 binding" message (bug#7967).
4713 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4715 Fix more problems found by GCC 4.6.0's static checks.
4717 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4718 Remove unused local var.
4720 * editfns.c (Fmessage_box): Remove unused local var.
4722 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4723 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4724 Omit unused local vars.
4725 * window.c (shrink_windows): Omit unused local var.
4726 * menu.c (digest_single_submenu): Omit unused local var.
4727 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4728 Omit unused local var.
4730 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4731 Don't assume string length fits in int.
4732 (keyremap_step, read_key_sequence): Use size_t for sizes.
4733 (read_key_sequence): Don't check last_real_key_start redundantly.
4735 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4736 instead of alloca (Bug#8344).
4738 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4739 (Fbacktrace_frame): Don't assume nframes fits in int.
4741 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4743 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4746 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4748 * cm.c (calccost): Turn while-do into do-while, for clarity.
4750 * keyboard.c (syms_of_keyboard): Use the same style as later
4751 in this function when indexing through an array. This also
4752 works around GCC bug 48267.
4754 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4756 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4758 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4759 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4761 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4762 This avoids undefined behavior on integer overflow, and is a bit
4763 more convenient anyway since it is compared to a size_t variable.
4765 Variadic C functions now count arguments with size_t, not int.
4766 This avoids an unnecessary limitation on 64-bit machines, which
4767 caused (substring ...) to crash on large vectors (Bug#8344).
4768 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4769 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4770 All variadic functions and their callers changed accordingly.
4771 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4772 * data.c (arith_driver, float_arith_driver): Likewise.
4773 * editfns.c (general_insert_function): Likewise.
4774 * eval.c (struct backtrace.nargs, interactive_p)
4775 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4776 (funcall_lambda, mark_backtrace): Likewise.
4777 * fns.c (concat): Likewise.
4778 * frame.c (x_set_frame_parameters): Likewise.
4779 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4780 0 if not found, not -1. All callers changed.
4782 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4783 (stack_copy_size): Now size_t, not int.
4784 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4786 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4788 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4789 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4790 All callers changed.
4792 * lisp.h (multibyte_char_to_unibyte):
4793 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4794 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4795 * character.h (CHAR_TO_BYTE8):
4796 * cmds.c (internal_self_insert):
4797 * editfns.c (general_insert_function):
4798 * keymap.c (push_key_description):
4799 * search.c (Freplace_match):
4800 * xdisp.c (message_dolog, set_message_1): All callers changed.
4802 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4804 * keyboard.c (safe_run_hook_funcall): New function.
4805 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4806 don't set the hook to nil, but remove the offending function instead.
4807 (Qcommand_hook_internal): Remove, unused.
4808 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4809 Vcommand_hook_internal.
4811 * eval.c (enum run_hooks_condition): Remove.
4812 (funcall_nil, funcall_not): New functions.
4813 (run_hook_with_args): Call each function through a `funcall' argument.
4814 Remove `cond' argument, now redundant.
4815 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4816 (Frun_hook_with_args_until_failure): Adjust accordingly.
4817 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4819 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4821 * dispextern.h (string_buffer_position): Remove declaration.
4823 * print.c (strout): Remove parameter `multibyte', unused since
4824 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4826 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4827 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4828 All callers changed.
4830 * w32.c (_wsa_errlist): Use braces for struct initializers.
4832 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4833 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4834 All callers changed.
4835 (string_buffer_position): Likewise. Also, make static (it's never
4836 used outside xdisp.c).
4837 (cursor_row_p): Remove parameter `w', unused since
4838 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4839 (decode_mode_spec): Remove parameter `precision', introduced during
4840 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4841 All callers changed.
4843 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4845 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4847 2011-03-27 Anders Lindgren <andlind@gmail.com>
4849 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4850 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4851 (ns_update_auto_hide_menu_bar): New functions.
4852 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4853 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4854 ns_constrain_all_frames.
4855 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4856 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4858 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4860 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4862 2011-03-27 Glenn Morris <rgm@gnu.org>
4864 * syssignal.h: Replace RETSIGTYPE with void.
4865 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4866 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4867 Replace SIGTYPE with void everywhere.
4868 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4869 * s/template.h (SIGTYPE): Remove commented out definition.
4871 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4873 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4874 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4876 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4878 * w32.c (read_unc_volume): Use parameter `henum', instead of
4879 global variable `wget_enum_handle'.
4881 * keymap.c (describe_vector): Remove parameters `indices' and
4882 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4883 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4885 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4887 * keyboard.c (timer_check): Remove parameter `do_it_now',
4888 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4889 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4890 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4892 * keyboard.c (read_char):
4893 * w32menu.c (w32_menu_display_help):
4894 * xmenu.c (show_help_event, menu_help_callback):
4895 Adjust calls to `show_help_echo'.
4897 * gtkutil.c (xg_maybe_add_timer):
4898 * keyboard.c (readable_events):
4899 * process.c (wait_reading_process_output):
4900 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4902 * insdel.c (adjust_markers_gap_motion):
4903 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4904 (gap_left, gap_right): Don't call it.
4906 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4908 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4909 incurred during fontification.
4911 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4913 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4914 (DEFVAR_PER_BUFFER): Don't pass it.
4916 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4917 (scrolling_window): Don't pass it.
4919 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4921 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4923 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4925 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4926 of variables specific to SELinux and computation of `encoded_absname'.
4928 * image.c (XPutPixel): Remove unused variable `height'.
4930 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4932 * unexw32.c (get_section_info): Remove unused variable `section'.
4934 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4935 (system_process_attributes): Remove unused variable `sess'.
4936 (sys_read): Remove unused variable `err'.
4938 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4939 (w32_wnd_proc): Remove unused variable `isdead'.
4940 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4941 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4942 (x_create_tip_frame): Remove unused variable `tem'.
4944 * w32inevt.c (w32_console_read_socket):
4945 Remove unused variable `no_events'.
4947 * w32term.c (x_draw_composite_glyph_string_foreground):
4948 Remove unused variable `width'.
4950 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4952 * w32term.c (x_set_glyph_string_clipping):
4953 Don't pass uninitialized region to CombineRgn.
4955 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4957 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4958 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4959 (Fx_close_connection): Remove unused variable `i'.
4961 * w32font.c (w32font_draw): Return number of glyphs.
4962 (w32font_open_internal): Remove unused variable `i'.
4963 (w32font_driver): Add missing initializer.
4965 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4966 (fill_in_menu): Remove unused variable `items_added'.
4968 * w32term.c (last_mouse_press_frame): Remove static global variable.
4969 (w32_clip_to_row): Remove unused variable `f'.
4970 (x_delete_terminal): Remove unused variable `i'.
4972 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4973 (NOTHING): Remove unused static global variable.
4974 (uniscribe_check_otf): Remove unused variable `table'.
4975 (uniscribe_font_driver): Add missing initializers.
4977 2011-03-23 Julien Danjou <julien@danjou.info>
4979 * term.c (Fsuspend_tty, Fresume_tty):
4980 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4981 * window.c (temp_output_buffer_show):
4982 * insdel.c (signal_before_change):
4983 * frame.c (Fhandle_switch_frame):
4984 * fileio.c (Fdo_auto_save):
4985 * emacs.c (Fkill_emacs):
4986 * editfns.c (save_excursion_restore):
4987 * cmds.c (internal_self_insert):
4988 * callint.c (Fcall_interactively):
4989 * buffer.c (Fkill_all_local_variables):
4990 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4992 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4993 unconditionnaly since it does the check itself.
4995 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4997 Fix more problems found by GCC 4.5.2's static checks.
4999 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5000 the first time through the loop, since we know p0 < p1 then.
5001 This also avoids a gcc -Wstrict-overflow warning.
5003 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5004 leading to a memory leak, possible in functions like
5005 load_charset_map_from_file that can allocate an unbounded number
5006 of objects (Bug#8318).
5008 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5009 that could (at least in theory) be that large.
5011 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5012 This is less likely to overflow, and avoids undefined behavior if
5013 overflow does occur. All callers changed. Use strtoul to scan
5014 for the unsigned long integer.
5015 (pint2hrstr): Simplify and tune code slightly.
5016 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5018 * scroll.c (do_scrolling): Work around GCC bug 48228.
5019 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5021 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5022 This also avoids a warning with gcc -Wstrict-overflow.
5023 (validate_x_resource_name): Simplify count usage.
5024 This also avoids a warning with gcc -Wstrict-overflow.
5026 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5029 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5031 * process.c (Fmake_network_process): Use socklen_t, not int,
5032 where POSIX says socklen_t is required in portable programs.
5033 This fixes a porting bug on hosts like 64-bit HP-UX, where
5034 socklen_t is wider than int (Bug#8277).
5035 (Fmake_network_process, server_accept_connection):
5036 (wait_reading_process_output, read_process_output):
5039 * process.c: Rename or move locals to avoid shadowing.
5040 (list_processes_1, Fmake_network_process):
5041 (read_process_output_error_handler, exec_sentinel_error_handler):
5042 Rename or move locals.
5043 (Fmake_network_process): Define label "retry_connect" only if needed.
5044 (Fnetwork_interface_info): Fix pointer signedness.
5045 (process_send_signal): Add cast to avoid pointer signedness problem.
5046 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5047 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5049 Make tparam.h and terminfo.c consistent.
5050 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5051 Include tparam.h instead, since it declares them.
5052 * cm.h (PC): Remove extern decl; tparam.h now does this.
5053 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5054 * terminfo.c: Include tparam.h, to check interfaces.
5055 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5056 (tparam): Adjust signature to match interface in tparam.h;
5057 this removes some undefined behavior. Check that outstring and len
5058 are zero, which they always are with Emacs.
5059 * tparam.h (PC, BC, UP): New extern decls.
5061 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5062 (xftfont_open): Rename locals to avoid shadowing.
5064 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5065 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5066 (OTF_TAG_SYM): Omit macro if not needed.
5067 (ftfont_list): Remove unused local.
5068 (get_adstyle_property, ftfont_pattern_entity):
5069 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5070 Rename locals to avoid shadowing.
5072 * xfont.c (xfont_list_family): Mark var as initialized.
5074 * xml.c (make_dom): Now static.
5076 * composite.c (composition_compute_stop_pos): Rename local to
5078 (composition_reseat_it): Remove unused locals.
5079 (find_automatic_composition, composition_adjust_point): Likewise.
5080 (composition_update_it): Mark var as initialized.
5081 (find_automatic_composition): Mark vars as initialized,
5082 with a FIXME (Bug#8290).
5084 character.h: Rename locals to avoid shadowing.
5085 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5086 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5087 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5088 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5091 * textprop.c (property_change_between_p): Remove; unused.
5093 * intervals.c (interval_start_pos): Now static.
5095 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5097 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5098 Rename locals to avoid shadowing.
5100 * sound.c (wav_play, au_play, Fplay_sound_internal):
5101 Fix pointer signedness.
5102 (alsa_choose_format): Remove unused local var.
5103 (wav_play): Initialize a variable to 0, to prevent undefined
5104 behavior (Bug#8278).
5106 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5108 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5110 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5111 clobbering (Bug#8298).
5112 * sysdep.c (sys_subshell): Likewise.
5113 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5115 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5116 This should get cleaned up, so that child_setup has the
5117 same signature on all platforms.
5119 * callproc.c (call_process_cleanup): Now static.
5120 (relocate_fd): Rename locals to avoid shadowing.
5122 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5124 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5125 not to be necessary, and produces flickering.
5127 2011-03-20 Glenn Morris <rgm@gnu.org>
5129 * config.in: Remove file.
5131 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5133 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5134 are now in src/globals.h.
5135 (syms_of_minibuf): Remove spurious & from previous change.
5137 2011-03-20 Leo <sdl.web@gmail.com>
5139 * minibuf.c (completing-read-function): New variable.
5140 (completing-read-default): Rename from completing-read.
5141 (completing-read): Call completing-read-function.
5143 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5145 * xfaces.c (Fx_load_color_file):
5146 Read color file from absolute filename (bug#8250).
5148 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5150 * makefile.w32-in: Update dependencies.
5152 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5154 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5156 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5158 Fix more problems found by GCC 4.5.2's static checks.
5160 * process.c (make_serial_process_unwind, send_process_trap):
5161 (sigchld_handler): Now static.
5163 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5164 That way, the code declares only the vars that it needs.
5165 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5166 * s/cygwin.h (PTY_ITERATION): Likewise.
5167 * s/darwin.h (PTY_ITERATION): Likewise.
5168 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5170 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5171 * process.c (allocate_pty): Don't declare stb unless it's needed.
5173 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5174 (CONSTANTLIM): Remove; unused.
5175 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5176 Define only if needed.
5178 * unexelf.c (unexec): Name an expression,
5179 to avoid gcc -Wbad-function-cast warning.
5180 Use a different way to cause a compilation error if anyone uses
5181 n rather than nn, a way that does not involve shadowing.
5182 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5184 * deps.mk (unexalpha.o): Remove; unused.
5186 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5187 * unexec.h: New file.
5188 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5189 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5191 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5192 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5193 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5194 Change as necessary to match prototype in unexec.h.
5196 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5198 (back_comment, skip_chars): Mark vars as initialized.
5200 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5201 Rename locals to avoid shadowing.
5203 * lread.c (read1): Rewrite so as not to use empty "else".
5204 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5206 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5208 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5209 warning when compiling print.c.
5211 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5212 instead of using an uninitialized var.
5213 (font_sort_entities): Mark var as initialized.
5215 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5217 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5218 pointers to constants.
5219 (font_parse_fcname): Remove unused vars.
5220 (font_delete_unmatched): Now static.
5221 (font_get_spec): Remove; unused.
5222 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5223 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5224 Rename or move locals to avoid shadowing.
5226 * fns.c (require_nesting_list, require_unwind): Now static.
5227 (Ffillarray): Rename locals to avoid shadowing.
5229 * floatfns.c (domain_error2): Define only if needed.
5230 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5232 * alloc.c (mark_backtrace): Move decl from here ...
5233 * lisp.h: ... to here, so that it can be checked.
5235 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5236 (Fdefvar): Rewrite so as not to use empty "else".
5237 (lisp_indirect_variable): Name an expression,
5238 to avoid gcc -Wbad-function-cast warning.
5239 (Fdefvar): Rename locals to avoid shadowing.
5241 * callint.c (quotify_arg, quotify_args): Now static.
5242 (Fcall_interactively): Rename locals to avoid shadowing.
5243 Use const pointer when appropriate.
5245 * lisp.h (get_system_name, get_operating_system_release):
5246 Move decls here, to check interfaces.
5247 * process.c (get_operating_system_release): Move decl to lisp.h.
5248 * xrdb.c (get_system_name): Likewise.
5249 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5250 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5251 some of which prompt warnings from gcc -Wbad-function-cast.
5252 (Fformat_time_string, Fencode_time, Finsert_char):
5253 (Ftranslate_region_internal, Fformat):
5254 Rename or remove local vars to avoid shadowing.
5255 (Ftranslate_region_internal): Mark var as initialized.
5257 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5260 * lisp.h (eassert): Check that the argument compiles, even if
5261 ENABLE_CHECKING is not defined.
5263 * data.c (Findirect_variable): Name an expression, to avoid
5264 gcc -Wbad-function-cast warning.
5265 (default_value, arithcompare, arith_driver, arith_error): Now static.
5266 (store_symval_forwarding): Rename local to avoid shadowing.
5267 (Fmake_variable_buffer_local, Fmake_local_variable):
5268 Mark variables as initialized.
5269 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5271 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5272 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5273 Rename locals to avoid shadowing.
5274 (mark_stack): Move local variables into the #ifdef region where
5276 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5277 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5279 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5280 (GC_STRING_CHARS): Remove; not used.
5281 (Fmemory_limit): Cast sbrk's returned value to char *.
5283 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5284 avoids undefined behavior in theory.
5286 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5288 Use functions, not macros, for up- and down-casing (Bug#8254).
5289 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5290 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5291 to use the following functions instead of these macros.
5292 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5293 EMACS_INT, since callers assume the returned value fits in int.
5294 (upcase1): Likewise, for UPCASE_TABLE.
5295 (uppercasep, lowercasep, upcase): New static inline functions.
5296 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5297 the race-condition problem in the old DOWNCASE.
5299 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5300 Rename locals to avoid shadowing.
5301 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5302 (regex_compile, re_search_2, re_match_2_internal):
5303 Remove unused local vars.
5304 (FREE_VAR): Rewrite so as not to use empty "else",
5305 which gcc can warn about.
5306 (regex_compile, re_match_2_internal): Mark locals as initialized.
5307 (RETALLOC_IF): Define only if needed.
5308 (WORDCHAR_P): Likewise. This one is never needed, but is used
5309 only in a comment talking about a compiler bug, so put inside
5310 the #if 0 of that comment.
5311 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5312 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5315 * search.c (boyer_moore): Rename locals to avoid shadowing.
5316 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5317 (PREV_CHAR_BOUNDARY): Likewise.
5319 * search.c (simple_search): Remove unused var.
5321 * dired.c (compile_pattern): Move decl from here ...
5322 * lisp.h: ... to here, so that it can be checked.
5323 (struct re_registers): New forward decl.
5325 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5327 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5329 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5330 Rename locals to avoid shadowing.
5331 (Fvertical_motion): Mark locals as initialized.
5333 * casefiddle.c (casify_object, casify_region): Now static.
5334 (casify_region): Mark local as initialized.
5336 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5338 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5339 New macros, so that the caller can use some names other than
5340 gcpro1, gcpro2, etc.
5341 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5343 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5344 argument, for consistency with GCPRO2_VAR, etc: it is now the
5345 prefix of the variable, not the variable itself. All uses
5347 * dired.c (directory_files_internal, file_name_completion):
5348 Rename locals to avoid shadowing.
5350 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5351 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5352 dired.c's scmp function, had undefined behavior.
5353 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5354 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5355 * buffer.h: ... to here, because these macros use current_buffer,
5356 and the new implementation with inline functions needs to have
5357 current_buffer in scope now, rather than later when the macros
5359 (downcase, upcase1): New static inline functions.
5360 (DOWNCASE, UPCASE1): Reimplement using these functions.
5361 This avoids undefined behavior in expressions like
5362 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5363 from race conditions in accessing the global variables
5364 case_temp1 and case_temp2.
5365 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5366 * lisp.h (case_temp1, case_temp2): Remove their decls.
5367 * character.h (ASCII_CHAR_P): Move from here ...
5368 * lisp.h: ... to here, so that the inline functions mentioned
5371 * dired.c (directory_files_internal_unwind): Now static.
5373 * fileio.c (file_name_as_directory, directory_file_name):
5374 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5376 (file_name_as_directory): Use const pointers when appropriate.
5377 (Fexpand_file_name): Likewise. In particular, newdir might
5378 point at constant storage, so make it a const pointer.
5379 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5380 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5382 (Fset_file_times, Finsert_file_contents, auto_save_error):
5383 Rename locals to avoid shadowing.
5385 * minibuf.c (choose_minibuf_frame_1): Now static.
5386 (Ftry_completion, Fall_completions): Rename or remove locals
5389 * marker.c (bytepos_to_charpos): Remove; unused.
5391 * lisp.h (verify_bytepos, count_markers): New decls,
5392 so that gcc does not warn that these functions aren't declared.
5394 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5395 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5396 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5397 (copy_text): Remove unused local var.
5399 * filelock.c (within_one_second): Now static.
5400 (lock_file_1): Rename local to avoid shadowing.
5402 * buffer.c (fix_overlays_before): Mark locals as initialized.
5403 (fix_start_end_in_overlays): Likewise. This function should be
5404 simplified by using pointers-to-pointers, but that's a different
5406 (switch_to_buffer_1): Now static.
5407 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5408 (report_overlay_modification): Rename locals to avoid shadowing.
5410 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5411 Fix pointer signedness issue.
5412 (sys_subshell): Mark local as volatile if checking for lint,
5413 to suppress a gcc -Wclobbered warning that does not seem to be right.
5414 (MAXPATHLEN): Define only if needed.
5416 * process.c (serial_open, serial_configure): Move decls from here ...
5417 * systty.h: ... to here, so that they can be checked.
5419 * fns.c (get_random, seed_random): Move extern decls from here ...
5420 * lisp.h: ... to here, so that they can be checked.
5422 * sysdep.c (reset_io): Now static.
5423 (wait_for_termination_signal): Remove; unused.
5425 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5426 (copy_keymap_item, append_key, push_text_char_description):
5428 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5429 (DENSE_TABLE_SIZE): Remove; unused.
5430 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5431 (describe_map_tree):
5432 Rename locals to avoid shadowing.
5434 * keyboard.c: Declare functions static if they are not used elsewhere.
5435 (echo_char, echo_dash, cmd_error, top_level_2):
5436 (poll_for_input, handle_async_input): Now static.
5437 (read_char, kbd_buffer_get_event, make_lispy_position):
5438 (make_lispy_event, make_lispy_movement, apply_modifiers):
5439 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5440 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5441 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5442 (read_key_sequence, read_char): Mark locals as initialized.
5443 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5445 * keyboard.h (make_ctrl_char): New decl.
5446 (mark_kboards): Move decl here ...
5447 * alloc.c (mark_kboards): ... from here.
5449 * lisp.h (force_auto_save_soon): New decl.
5451 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5452 (DEFINE_DUMMY_FUNCTION): New macro.
5453 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5455 (main): Add casts to avoid warnings
5456 if GCC considers string literals to be constants.
5458 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5460 * dbusbind.c: Pointer signedness fixes.
5461 (xd_signature, xd_append_arg, xd_initialize):
5462 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5463 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5464 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5465 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5467 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5468 if GCC considers string literals to be constants.
5469 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5471 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5473 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5474 (print_preprocess, print_object): New macro to fix last change.
5476 * print.c (print_preprocess): Don't forget font objects.
5478 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5480 * emacs.c (USAGE3): Doc fixes.
5482 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5484 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5487 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5489 * lisp.h (VWindow_system, Qfile_name_history):
5490 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5491 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5492 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5494 * w32select.c: Don't #include "keyboard.h".
5495 (run_protected): Add extern declaration for waiting_for_input.
5497 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5498 * w32console.c (detect_input_pending, read_input_pending)
5499 (encode_terminal_code):
5500 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5501 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5502 (w32_system_caret_y, Qfile_name_history):
5503 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5504 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5505 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5506 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5507 * w32proc.c (Qlocal, report_file_error):
5508 * w32term.c (Vwindow_system, updating_frame):
5509 * w32uniscribe.c (initialized, uniscribe_font_driver):
5510 Remove unneeded extern declarations.
5512 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5514 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5516 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5518 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5519 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5520 These macros can no longer be used for assignment.
5522 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5523 Assign struct members directly, instead of using BUF_BEGV etc.
5524 (record_buffer_markers, fetch_buffer_markers): New functions for
5525 recording and fetching special buffer markers.
5526 (set_buffer_internal_1, set_buffer_temp): Use them.
5528 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5530 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5532 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5533 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5535 * xdisp.c (hscroll_window_tree):
5536 (reconsider_clip_changes): Use PT instead of BUF_PT.
5538 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5540 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5541 $(EMACS_ROOT)/lib/intprops.h.
5543 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5545 Fix more problems found by GCC 4.5.2's static checks.
5547 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5548 to unsigned char * to avoid compiler diagnostic.
5549 (xg_free_frame_widgets): Make it clear that a local variable is
5550 needed only if USE_GTK_TOOLTIP.
5551 (gdk_window_get_screen): Make it clear that this macro is needed
5552 only if USE_GTK_TOOLTIP.
5553 (int_gtk_range_get_value): New function, which avoids a diagnostic
5554 from gcc -Wbad-function-cast.
5555 (xg_set_toolkit_scroll_bar_thumb): Use it.
5556 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5557 diagnostic from gcc -Wbad-function-cast.
5558 (get_utf8_string, xg_get_file_with_chooser):
5559 Rename locals to avoid shadowing.
5560 (create_dialog): Move locals to avoid shadowing.
5562 * xgselect.c (xg_select): Remove unused var.
5564 * image.c (four_corners_best): Mark locals as initialized.
5565 (gif_load): Initialize transparent_p to zero (Bug#8238).
5566 Mark another local as initialized.
5567 (my_png_error, my_error_exit): Mark with NO_RETURN.
5569 * image.c (clear_image_cache): Now static.
5570 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5571 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5572 (x_edge_detection): Remove unnecessary cast that
5573 gcc -Wbad-function-cast diagnoses.
5574 (gif_load): Fix pointer signedness.
5575 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5576 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5578 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5580 Improve quality of tests for time stamp overflow.
5581 For example, without this patch (encode-time 0 0 0 1 1
5582 1152921504606846976) returns the obviously-bogus value (-948597
5583 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5584 reports time overflow. See
5585 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5586 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5587 * editfns.c: Include limits.h and intprops.h.
5588 (TIME_T_MIN, TIME_T_MAX): New macros.
5589 (time_overflow): Move earlier, to before first use.
5590 (hi_time, lo_time): New functions, for an accurate test for
5592 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5593 (Fget_internal_run_time): Don't assume time_t fits in int.
5594 (make_time): Use list2 instead of Fcons twice.
5595 (Fdecode_time): More accurate test for out-of-range times.
5596 (check_tm_member): New function.
5597 (Fencode_time): Use it, to test for out-of-range times.
5598 (lisp_time_argument): Don't rely on undefined left-shift and
5599 right-shift behavior when checking for time stamp overflow.
5601 * editfns.c (time_overflow): New function, refactoring common code.
5602 (Fformat_time_string, Fdecode_time, Fencode_time):
5603 (Fcurrent_time_string): Use it.
5605 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5606 * dired.c (make_time): Move to ...
5607 * editfns.c (make_time): ... here.
5608 * systime.h: Note the move.
5610 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5612 * fringe.c (update_window_fringes): Remove unused variables.
5614 * unexmacosx.c (copy_data_segment): Also copy __got section.
5617 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5619 * termcap.c [MSDOS]: Include "msdos.h".
5620 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5621 Constify `char *' arguments and their references according to
5622 prototypes in tparam.h.
5624 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5626 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5627 Adapt all references accordingly.
5629 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5631 2011-03-11 Tom Tromey <tromey@redhat.com>
5633 * buffer.c (syms_of_buffer): Remove obsolete comment.
5635 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5637 * termhooks.h (encode_terminal_code): Declare prototype.
5639 * msdos.c (encode_terminal_code): Don't declare prototype.
5641 * term.c (encode_terminal_code): Now external again, used by
5642 w32console.c and msdos.c.
5644 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5645 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5647 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5649 Fix some minor problems found by GCC 4.5.2's static checks.
5651 * fringe.c (update_window_fringes): Mark locals as initialized
5653 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5655 * alloc.c (mark_fringe_data): Move decl from here ...
5656 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5657 to check its interface.
5658 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5660 * fontset.c (free_realized_fontset): Now static.
5661 (Fset_fontset_font): Rename local to avoid shadowing.
5662 (fontset_font): Mark local as initialized.
5663 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5665 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5667 * xselect.c (x_disown_buffer_selections): Remove; not used.
5668 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5669 (x_own_selection, Fx_disown_selection_internal): Rename locals
5671 (x_handle_dnd_message): Remove local to avoid shadowing.
5673 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5674 so that the caller can use some name other than gcpro1.
5675 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5676 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5677 (Fx_backspace_delete_keys_p):
5678 Use them to avoid shadowing, and rename vars to avoid shadowing.
5679 (x_decode_color, x_set_name, x_window): Now static.
5680 (Fx_create_frame): Add braces to silence GCC warning.
5681 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5682 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5683 Remove unused locals.
5684 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5685 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5686 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5689 * xterm.h (x_mouse_leave): New decl.
5691 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5692 Remove unused functions.
5693 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5694 (x_calc_absolute_position): Now static.
5695 (XTread_socket): Don't define label "out" unless it's used.
5696 Don't declare local "event" unless it's used.
5697 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5698 unless they are used.
5699 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5700 (x_fatal_error_signal): Remove; not used.
5701 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5702 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5703 (x_error_catcher, x_connection_closed, x_error_handler):
5704 (x_error_quitter, xembed_send_message, x_iconify_frame):
5705 (my_log_handler): Rename locals to avoid shadowing.
5706 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5707 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5709 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5710 Rename or move locals to avoid shadowing.
5711 (tty_defined_color, merge_face_heights): Now static.
5712 (free_realized_faces_for_fontset): Remove; not used.
5713 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5714 does not deduce is never used uninitialized.
5715 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5716 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5718 * terminal.c (store_terminal_param): Now static.
5720 * xmenu.c (menu_highlight_callback): Now static.
5721 (set_frame_menubar): Remove unused local.
5722 (xmenu_show): Rename parameter to avoid shadowing.
5723 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5724 since they might point to immutable storage.
5725 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5726 since it's unused otherwise.
5728 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5729 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5730 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5731 avoids a gcc -Wuninitialized diagnostic.
5732 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5733 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5734 does not deduce are never used uninitialized.
5736 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5738 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5739 * window.c (window_loop, size_window):
5740 (run_window_configuration_change_hook, enlarge_window): Likewise.
5742 * window.c (display_buffer): Now static.
5743 (size_window): Mark variables that gcc -Wuninitialized
5744 does not deduce are never used uninitialized.
5745 * window.h (check_all_windows): New decl, to forestall
5746 gcc -Wmissing-prototypes diagnostic.
5747 * dispextern.h (bidi_dump_cached_states): Likewise.
5749 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5751 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5753 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5754 and to avoid gcc -Wuninitialized warning.
5755 (load_charset_map): Mark variables that gcc -Wuninitialized
5756 does not deduce are never used uninitialized.
5757 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5759 * coding.c (coding_set_source, coding_set_destination):
5760 Use "else { /* comment */ }" rather than "else /* comment */;"
5761 for clarity, and to avoid gcc -Wempty-body warning.
5762 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5763 a block, when the outer 'i' will do.
5764 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5765 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5766 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5767 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5768 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5769 Rename locals to avoid shadowing.
5770 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5771 * coding.c (emacs_mule_char, encode_invocation_designation):
5772 Now static, since they're not used elsewhere.
5773 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5774 (decode_coding_object, encode_coding_object, detect_coding_system):
5775 (decode_coding_emacs_mule): Mark variables that gcc
5776 -Wuninitialized does not deduce are never used uninitialized.
5777 (detect_coding_iso_2022): Initialize a local variable that might
5778 be used uninitialized. Leave a FIXME because it's not clear that
5779 this initialization is needed. (Bug#8211)
5780 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5781 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5782 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5783 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5784 Remove unused macros.
5786 * category.c (hash_get_category_set): Remove unused local var.
5787 (copy_category_table): Now static, since it's not used elsewhere.
5788 * character.c (string_count_byte8): Likewise.
5790 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5791 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5793 * chartab.c (copy_sub_char_table): Now static, since it's not used
5795 (sub_char_table_ref_and_range, char_table_ref_and_range):
5796 Rename locals to avoid shadowing.
5797 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5799 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5800 (BIDI_BOB): Remove unused macro.
5802 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5803 deduce are never used uninitialized.
5804 * term.c (encode_terminal_code): Likewise.
5806 * term.c (encode_terminal_code): Now static. Remove unused local.
5808 * tparam.h: New file.
5809 * term.c, tparam.h: Include it.
5810 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5811 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5812 Move these decls to tparam.h, and make them agree with what
5813 is actually in tparam.c. The previous trick of using incompatible
5814 decls in different modules does not conform to the C standard.
5815 All callers of tparam changed to use tparam's actual API.
5816 * tparam.c (tparam1, tparam, tgoto):
5817 Use const pointers where appropriate.
5819 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5820 * cm.h (struct cm): Likewise.
5821 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5822 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5823 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5824 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5825 (turn_on_face, init_tty): Likewise.
5826 * termchar.h (struct tty_display_info): Likewise.
5828 * term.c (term_mouse_position): Rename local to avoid shadowing.
5830 * alloc.c (mark_ttys): Move decl from here ...
5831 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5833 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5835 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5837 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5839 * search.c (compile_pattern_1): Remove argument regp, unused since
5840 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5841 (compile_pattern): Don't pass it.
5843 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5845 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5846 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5848 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5850 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5852 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5853 gdk_window_get_screen, gdk_window_get_geometry,
5854 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5855 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5856 (xg_get_pixbuf_from_pixmap): New function.
5857 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5858 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5859 Call xg_get_pixbuf_from_pixmap instead of
5860 gdk_pixbuf_get_from_drawable.
5861 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5862 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5863 (xg_check_special_colors): Use GtkStyleContext and its functions
5865 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5866 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5867 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5868 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5869 Call gtk_widget_get_preferred_size.
5870 (xg_frame_resized): gdk_window_get_geometry only takes 5
5872 (xg_win_to_widget, xg_event_is_for_menubar):
5873 Call gdk_x11_window_lookup_for_display.
5874 (xg_set_widget_bg): New function.
5875 (delete_cb): New function.
5876 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5877 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5878 (xg_set_background_color): Call xg_set_widget_bg.
5879 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5880 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5881 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5882 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5884 (update_frame_tool_bar): Call gtk_widget_hide.
5885 (xg_initialize): Use GDK_KEY_g.
5887 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5889 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5891 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5892 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5893 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5895 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5897 * w32xfns.c (select_palette): Check success of RealizePalette against
5898 GDI_ERROR, not zero.
5900 See ChangeLog.11 for earlier changes.
5906 Copyright (C) 2011 Free Software Foundation, Inc.
5908 This file is part of GNU Emacs.
5910 GNU Emacs is free software: you can redistribute it and/or modify
5911 it under the terms of the GNU General Public License as published by
5912 the Free Software Foundation, either version 3 of the License, or
5913 (at your option) any later version.
5915 GNU Emacs is distributed in the hope that it will be useful,
5916 but WITHOUT ANY WARRANTY; without even the implied warranty of
5917 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5918 GNU General Public License for more details.
5920 You should have received a copy of the GNU General Public License
5921 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.