1 2012-07-12 Glenn Morris <rgm@gnu.org>
3 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
5 * process.c (init_process_emacs): Rename from init_process.
6 The old name is also the name of a Mach system call.
7 * lisp.h, emacs.c: Update for this name change.
8 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
11 2012-07-12 Eli Zaretskii <eliz@gnu.org>
13 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
14 memmove call that removes glyphs covered by the left truncation
15 glyph. Improve commentary.
16 (display_line): Fix display of continuation glyphs on GUI frames
17 when the right fringe is turned off and variable-size fonts are
18 used in the window. Move the code that appends a stretch glyph to
19 produce_special_glyphs, so that it could be used for truncation
20 and continuation glyphs alike.
21 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
22 glyph of a suitably computed width, to align the special glyphs at
23 the window margin. Code moved from display_line. (Bug#11832)
25 2012-07-12 Glenn Morris <rgm@gnu.org>
27 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
29 * s/gnu-linux.h, s/hpux10-20.h:
30 Do not unconditionally define HAVE_XRMSETDATABASE.
32 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
34 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
36 Fix typos that broke OS X build.
37 Reported by Randal L. Schwartz in
38 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
39 * nsterm.m (ns_timeout): Add missing local decl.
40 (ns_get_color): snprintf -> sprintf, to fix typo.
42 2012-07-12 Glenn Morris <rgm@gnu.org>
44 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
45 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
46 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
47 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
49 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
50 Move PTY_OPEN to configure.
52 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
53 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
54 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
56 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
58 Use empty_unibyte_string where applicable.
59 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
60 * lread.c (read1): Likewise.
61 * xsettings.c (syms_of_xsettings): Likewise.
63 2012-07-12 Glenn Morris <rgm@gnu.org>
65 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
66 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
67 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
68 * s/hpux10-20.h (RUN_TIME_REMAP):
69 * s/bsd-common.h (TABDLY): Move to configure.
71 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
73 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
75 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
76 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
78 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
80 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
81 * s/template.h: Move NARROWPROTO to configure.
83 2012-07-11 Glenn Morris <rgm@gnu.org>
85 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
86 unused since 2011-01-17 change to systty.h.
88 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
89 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
90 Move HAVE_PTYS and HAVE_SOCKETS to configure.
92 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
94 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
96 2012-07-11 Glenn Morris <rgm@gnu.org>
98 * s/darwin.h, s/gnu-linux.h, s/template.h:
99 Move INTERRUPT_INPUT to configure.
101 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
103 Minor adjustments to interning code.
104 * lisp.h (intern, intern_c_string): Redefine as static inline
105 wrappers for intern_1 and intern_c_string_1, respectively.
106 (intern_1, intern_c_string_1): Rename prototypes.
107 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
109 * font.c (font_intern_prop): Likewise. Adjust comment.
110 * w32font.c (intern_font_name): Likewise.
112 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
114 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
116 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
117 of Fcar/Fcdr if possible.
118 * font.c (check_otf_features): Likewise.
119 * fontset.c (Fnew_fontset): Likewise.
120 * gnutls.c (Fgnutls_boot): Likewise.
121 * minibuf.c (read_minibuf): Likewise.
122 * msdos.c (IT_set_frame_parameters): Likewise.
123 * xmenu.c (Fx_popup_dialog): Likewise.
124 * w32menu.c (Fx_popup_dialog): Likewise.
126 2012-07-11 Glenn Morris <rgm@gnu.org>
128 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
129 since nothing has defined it on these platforms.
131 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
132 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
134 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
135 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
136 Move CLASH_DETECTION to configure.
138 * s/gnu.h: Remove file, which is now empty.
140 * s/gnu.h, s/gnu-linux.h:
141 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
143 2012-07-11 John Wiegley <johnw@newartisans.com>
145 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
146 function attribute, so we only use it if it exists in the
149 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
151 Avoid call to strlen in fast_c_string_match_ignore_case.
152 * search.c (fast_c_string_match_ignore_case): Change to use
153 length argument. Adjust users accordingly.
154 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
156 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
159 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
160 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
163 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
166 * s/hpux10-20.h (HAVE_PERROR): Remove.
167 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
168 Remove dummy definition, as this problem was obsolete long ago.
171 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
173 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
175 Avoid calls to strlen in font processing functions.
176 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
177 (font_open_by_name): Change to use length argument. Adjust
179 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
181 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
182 Change to return ptrdiff_t.
183 (xfont_list_pattern, xfont_match): Use length returned by
184 xfont_decode_coding_xlfd.
185 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
187 2012-07-11 Glenn Morris <rgm@gnu.org>
189 * s/darwin.h, s/freebsd.h, s/netbsd.h:
190 Move DONT_REOPEN_PTY to configure.
192 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
193 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
195 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
197 Remove "#define unix" that is no longer needed (Bug#11905).
198 * s/aix4-2.h (unix): Remove; no longer needed.
200 EMACS_TIME simplification (Bug#11875).
201 This replaces macros (which typically do not work in GDB)
202 with functions, typedefs and enums, making the code easier to debug.
203 The functional style also makes code easier to read and maintain.
204 * systime.h: Include <sys/time.h> on all hosts, not just if
205 WINDOWSNT, since 'struct timeval' is needed in general.
206 (EMACS_TIME): Now a typedef, not a macro.
207 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
209 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
210 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
211 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
212 (EMACS_TIME_LE): Now functions, not macros.
213 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
214 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
215 which are not functions. All uses rewritten to use:
216 (make_emacs_time): New function.
217 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
218 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
219 not functions. All uses rewritten to use the following, respectively:
220 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
221 (add_emacs_time, sub_emacs_time): New functions.
222 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
223 * fileio.c (Fcopy_file):
224 * xterm.c (XTflash): Get the current time closer to when it's used.
225 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
227 * bytecode.c (targets): Suppress -Woverride-init warnings.
229 Simplify by avoiding confusing use of strncpy etc.
230 * doc.c (Fsnarf_documentation):
231 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
232 * frame.c (Fmake_terminal_frame):
233 * gtkutil.c (get_utf8_string):
235 * nsmenu.m (ns_update_menubar):
236 * regex.c (regerror):
237 Prefer memcpy to strncpy and strncat when either will do.
238 * fileio.c (Fsubstitute_in_file_name):
239 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
240 (menu_separator_name_p):
241 * nsmenu.m (ns_update_menubar):
242 Prefer memcmp to strncmp when either will do.
243 * nsterm.m: Include <ftoastr.h>.
245 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
246 Prefer snprintf to strncpy.
247 * nsterm.m (ns_term_init):
248 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
249 * nsterm.m (ns_term_init):
250 Avoid the need for strncpy, by using build_string or
251 make_unibyte_string directly. Use dtoastr, not snprintf.
252 * process.c (Fmake_network_process): Diagnose service names that
253 are too long, rather than silently truncating them or creating
254 non-null-terminated names.
255 (Fnetwork_interface_info): Likewise, for interface names.
256 * sysdep.c (system_process_attributes) [GNU_LINUX]:
257 Prefer sprintf to strncat.
258 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
259 Prefer vsnprintf to vsprintf + strncpy.
261 2012-07-10 Glenn Morris <rgm@gnu.org>
263 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
264 Clarify fallback case.
266 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
268 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
269 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
270 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
271 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
272 where argument type is known to be a Lisp_Cons.
274 2012-07-10 Tom Tromey <tromey@redhat.com>
276 * bytecode.c (BYTE_CODE_THREADED): New macro.
277 (BYTE_CODES): New macro. Replaces all old byte-code defines.
278 (enum byte_code_op): New type.
279 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
280 (exec_byte_code): Use them. Use token threading when applicable.
282 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
284 Optimize pure C strings initialization.
285 * lisp.h (make_pure_string): Fix prototype.
286 (build_pure_c_string): New function, defined as static inline. This
287 provides a better opportunity to optimize away calls to strlen when
288 the function is called with compile-time constant argument.
289 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
290 argument, adjust users accordingly. Use build_pure_c_string where
292 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
293 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
294 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
296 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
298 Avoid calls to strlen in miscellaneous functions.
299 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
300 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
301 * lread.c (openp): Likewise.
303 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
305 Avoid calls to strlen in path processing functions.
306 * fileio.c (file_name_as_directory): Add comment. Change to add
307 srclen argument and return the length of result. Adjust users
309 (directory_file_name): Fix comment. Change to add srclen argument,
310 swap 1st and 2nd arguments to obey the common convention. Adjust
312 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
314 2012-07-10 Glenn Morris <rgm@gnu.org>
316 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
317 Move PENDING_OUTPUT_COUNT definition to configure.
319 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
320 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
321 * s/gnu.h (DATA_START): Move definitions to configure.
323 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
324 We include usg5-4-common.h, which defines them both.
326 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
327 O_RDONLY already includes it).
329 Stop ns builds setting the EMACSLOADPATH environment variable.
330 * nsterm.m (ns_load_path): Rename from ns_init_paths.
331 Now it does not set EMACSLOADPATH, just returns the load-path string.
332 * nsterm.h: Update accordingly.
333 * lread.c [HAVE_NS]: Include nsterm.h.
334 (init_lread) [HAVE_NS]: Use ns_load_path.
335 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
337 2012-07-09 Glenn Morris <rgm@gnu.org>
339 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
340 since the included bsd-common.h does so.
342 Stop ns builds setting the EMACSPATH environment variable.
343 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
344 (ns_init_paths): Do not set EMACSPATH.
345 * nsterm.h (ns_exec_path): Add it.
346 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
349 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
351 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
353 * process.c (wait_reading_process_output): 'waitchannels' was unset
354 when read_kbd || !NILP (wait_for_cell); fix this.
356 Add GCC-style 'const' attribute to functions that can use it.
357 * character.h (char_resolve_modifier_mask):
358 * keyboard.h (make_ctrl_char):
359 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
360 (init_character_once, next_almost_prime, init_fns, init_image)
361 (flush_pending_output, init_sound):
362 * mem-limits.h (start_of_data):
363 * menu.h (finish_menu_items):
365 * emacs.c (DEFINE_DUMMY_FUNCTION):
366 Declare the dummy function with ATTRIBUTE_CONST.
367 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
368 Add decls with ATTRIBUTE_CONST.
370 Minor improvements to make_formatted_string.
371 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
372 where int is good enough, as vsprintf returns an int.
373 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
375 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
377 Use make_formatted_string to avoid double length calculation.
378 * lisp.h (make_formatted_string): New prototype.
379 * alloc.c (make_formatted_string): New function.
380 * buffer.c (Fgenerate_new_buffer_name): Use it.
381 * dbus.c (syms_of_dbusbind): Likewise.
382 * editfns.c (Fcurrent_time_zone): Likewise.
383 * filelock.c (get_boot_time): Likewise.
384 * frame.c (make_terminal_frame, set_term_frame_name)
385 (x_report_frame_params): Likewise.
386 * image.c (gs_load): Likewise.
387 * minibuf.c (get_minibuffer): Likewise.
388 * msdos.c (dos_set_window_size): Likewise.
389 * process.c (make_process): Likewise.
390 * xdisp.c (ensure_echo_area_buffers): Likewise.
391 * xsettings.c (apply_xft_settings): Likewise.
393 2012-07-09 Glenn Morris <rgm@gnu.org>
395 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
396 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
397 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
398 * nsterm.h (ns_etc_directory): Add it.
399 * callproc.c [HAVE_NS]: Include nsterm.h.
400 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
402 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
404 Move marker debugging code under MARKER_DEBUG.
405 * marker.c (MARKER_DEBUG): Move marker debugging code under
406 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
407 for bootstrap with --enable-checking (~3x slowdown reported
408 by Juanma Barranquero <lekktu@gmail.com>).
409 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
411 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
413 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
414 See <http://bugs.gnu.org/11825#29>.
416 2012-07-08 Eli Zaretskii <eliz@gnu.org>
418 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
419 has no font, use the frame's font. (Bug#11813)
420 (display_line): Add commentary about displaying truncation glyphs
422 (produce_special_glyphs): Move here from term.c.
424 * term.c (produce_special_glyphs): Move to xdisp.c.
426 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
429 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
431 * xdisp.c (display_line): Avoid warning about implicit declaration
434 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
436 * lisp.h: Remove empty conditional.
438 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
440 * lread.c (load_path_check): Now static.
442 Fix some minor --with-ns problems found by static checking.
443 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
444 (x_set_font) [!HAVE_X_WINDOWS]:
445 * image.c (xpm_load_image) [HAVE_NS]:
446 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
447 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
449 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
450 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
451 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
452 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
453 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
454 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
455 Fix pointer signedness problem.
456 * xfaces.c (FRAME_X_FONT_TABLE):
457 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
459 2012-07-07 Glenn Morris <rgm@gnu.org>
461 * lread.c (load_path_check): New function, split from init_lread.
462 (init_lread): Reorganize. Motivation:
463 If EMACSLOADPATH is set, check/warn about that rather than the
464 defaults, which we are not going to use. Hence we can remove
465 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
466 Don't warn if site-lisp directories are missing.
467 If not installed, start from a blank load-path, since
468 PATH_LOADSEARCH refers to the eventual installation directories.
470 2012-07-07 Eli Zaretskii <eliz@gnu.org>
472 Support truncation and continuation glyphs on GUI frames, when
473 fringes are disabled. (Bug#11832)
474 * xdisp.c (init_iterator): Get dimensions of truncation and
475 continuation glyphs even if on GUI frames. Adjust
476 it->last_visible_x on GUI frames when the left or right fringes,
478 (start_display, move_it_in_display_line_to): Handle the case of a
479 GUI frame without a fringe to display continuation or truncation
481 (insert_left_trunc_glyphs): Support GUI frames: make sure
482 truncation glyphs overwrite enough glyphs from the current line to
483 have sufficient space in pixels.
484 (display_line): Support truncation and continuation glyphs on GUI
485 frames. If some spare pixels are left on the line after inserting
486 the truncation glyphs, fill that space with a stretch glyph of a
487 suitably computed width.
489 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
490 produce_glyphs, to support GUI sessions.
492 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
494 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
496 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
498 Do not require float-time's arg to fit in time_t (Bug#11825).
499 This works better on hosts where time_t is unsigned, and where
500 float-time is applied to the (negative) difference between two times.
501 * editfns.c (decode_time_components): Last arg is now double *,
502 not int *, and means to store all the result as a double, without
503 worrying about whether the seconds part fits in time_t.
505 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
507 (Ffloat_time): Do not fail merely because the specified time falls
508 outside of time_t range.
510 2012-07-07 Glenn Morris <rgm@gnu.org>
512 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
513 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
514 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
516 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
518 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
521 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
523 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
525 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
526 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
527 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
528 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
529 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
530 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
532 * xfont.c (compare_font_names): Redo to omit the need for casts.
534 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
536 * xfns.c (Fx_change_window_property): Doc fix.
537 * w32fns.c (Fx_change_window_property): Doc fix.
539 * w32fns.c (Fx_window_property): Accept the same arguments as the
540 X Windows version. Doc fix.
541 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
543 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
544 Eli Zaretskii <eliz@gnu.org>
546 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
547 Windows-specific code from nt/config.nt moved here.
548 Obsolete settings removed.
550 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
552 * process.c: Avoid unnecessary calls to gettime.
553 (wait_reading_process_output): Don't get the time of day
554 when gobbling data immediately and not waiting, as there's no need
555 for it in that case. This removes a FIXME.
557 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
559 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
560 is defined (Bug#11768).
562 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
564 Fix marker debugging code.
565 * marker.c (byte_char_debug_check): Do not perform the check
566 if buffer is not multibyte.
567 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
568 Call byte_char_debug_check with correct arguments.
570 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
572 Compile marker debugging code only if ENABLE_CHECKING is defined.
573 * marker.c (byte_char_debug_check, count_markers):
574 Use only if ENABLE_CHECKING is defined.
575 (byte_debug_flag): Remove.
576 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
577 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
579 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
581 Avoid code repetition in marker-related functions.
582 * marker.c (attach_marker): New function.
583 (Fset_marker, set_marker_restricted, set_marker_both)
584 (set_marker_restricted_both): Use it.
585 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
586 Consistently rename charno to charpos.
587 (marker_position): Add eassert.
588 (marker_byte_position): Convert to eassert.
590 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
592 Simplify list operations in unchain_overlay and unchain_marker.
593 * buffer.c (unchain_overlay): Simplify. Add comment.
594 * marker.c (unchain_marker): Simplify. Fix comments.
596 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
598 Introduce fast path for the widely used marker operation.
599 * alloc.c (build_marker): New function.
600 * lisp.h (build_marker): New prototype.
601 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
602 * composite.c (autocmp_chars): Likewise.
603 * editfns.c (buildmark): Remove.
604 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
605 (save_restriction_save): Use build_marker.
606 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
607 * window.c (save_window_save): Likewise.
609 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
611 Do not use Fdelete_overlay in delete_all_overlays
612 to avoid redundant calls to unchain_overlay.
613 * buffer.c (drop_overlay): New function.
614 (delete_all_overlays, Fdelete_overlay): Use it.
615 * minibuf.c (get_minibuffer): Fix comment.
617 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
619 Port to OpenBSD 5.1 amd64.
620 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
621 This is needed for OpenBSD, and should be harmless on all BSD systems.
622 Also, include <sys/sysctl.h>, as it should be available on all
623 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
624 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
625 use p_pid member, not kp_proc.pid.
627 2012-07-06 Glenn Morris <rgm@gnu.org>
629 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
631 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
633 More xmalloc and related cleanup.
634 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
635 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
636 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
637 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
638 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
639 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
640 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
641 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
642 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
644 Omit needless casts involving void * pointers and allocation.
645 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
646 as the former is more robust if P's type is changed.
647 Prefer xzalloc to xmalloc + memset 0.
648 Simplify malloc-or-realloc to realloc.
649 Don't worry about xmalloc returning a null pointer.
650 Prefer xstrdup to xmalloc + strcpy.
651 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
653 * keyboard.c (apply_modifiers_uncached): Prefer local array to
654 alloca of a constant.
656 2012-07-05 Eli Zaretskii <eliz@gnu.org>
658 * xdisp.c (display_line): Fix horizontal pixel coordinates when
659 hscroll is larger than the line width. Fixes long and futile
660 looping inside extend_face_to_end_of_line (on a TTY) producing
661 glyphs that are not needed and thrown away.
663 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
665 * marker.c (set_marker_restricted_both): Simplify by using
668 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
670 * editfns.c (region_limit): Simplify by using clip_to_bounds.
672 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
674 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
675 not defined (Bug#11768).
676 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
677 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
678 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
679 followed by gtk_box_set_homogeneous (Bug#11768).
680 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
681 (update_theme_scrollbar_width, xg_create_scroll_bar):
682 Use gtk_scrollbar_new (Bug#11768).
683 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
684 (is_box_type): New function (Bug#11768).
685 (xg_tool_item_stale_p): Call is_box_type.
686 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
687 with default display (Bug#11768).
689 2012-07-05 Eli Zaretskii <eliz@gnu.org>
691 * xdisp.c (window_hscroll_limited): New function.
692 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
693 coordinates when window's hscroll is set to insanely large
696 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
698 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
699 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
701 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
704 * lisp.h (xzalloc): New prototype. Omit needless casts.
705 * alloc.c (xzalloc): New function. Omit needless casts.
706 * charset.c: Omit needless casts. Convert all calls to
707 xmalloc with following memset to xzalloc.
708 * dispnew.c: Likewise.
709 * fringe.c: Likewise.
713 * w32fns.c: Likewise.
714 * w32font.c: Likewise.
715 * w32term.c: Likewise.
716 * xfaces.c: Likewise.
719 * atimer.c: Omit needless casts.
720 * buffer.c: Likewise.
721 * callproc.c: Likewise.
723 * coding.c: Likewise.
724 * composite.c: Likewise.
726 * doprnt.c: Likewise.
727 * editfns.c: Likewise.
730 * filelock.c: Likewise.
732 * gtkutil.c: Likewise.
733 * keyboard.c: Likewise.
736 * minibuf.c: Likewise.
739 * process.c: Likewise.
740 * region-cache.c: Likewise.
741 * search.c: Likewise.
742 * sysdep.c: Likewise.
743 * termcap.c: Likewise.
744 * terminal.c: Likewise.
745 * tparam.c: Likewise.
746 * w16select.c: Likewise.
748 * w32reg.c: Likewise.
749 * w32select.c: Likewise.
750 * w32uniscribe.c: Likewise.
751 * widget.c: Likewise.
755 * xselect.c: Likewise.
757 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
759 * fileio.c (time_error_value): Check the right error number.
760 Problem reported by Troels Nielsen in
761 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
763 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
765 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
766 This should be fixed in a better way; see Eli Zaretskii in
767 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
768 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
770 * fileio.c (time_error_value): Rename from special_mtime.
771 The old name's problems were noted by Eli Zaretskii in
772 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
774 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
775 This variable's comment says Emacs needs at least one GDB-visible
776 symbol of type enum pvec_type, to work around GDB problems.
777 The symbol's value doesn't matter.
779 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
780 that causes compilation to fail on pre-C99 compilers.
782 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
784 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
785 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
787 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
789 * buffer.c (init_buffer_once): Fix initialization of
790 headers for buffer_defaults and buffer_local_symbols.
791 Reported by Juanma Barranquero <lekktu@gmail.com>.
793 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
795 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
796 * lisp.h (enum pvec_type): Use fewer bits.
797 (PSEUDOVECTOR_SIZE_BITS): New constant.
798 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
799 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
801 (PSEUDOVECTOR_TYPEP): New macro.
802 (TYPED_PSEUDOVECTORP): Use it.
803 * fns.c (internal_equal): Adapt code to extract pvectype.
804 * emacs.c (gdb_pvec_type): Update type.
805 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
806 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
807 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
808 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
809 (sweep_vectors): Use it. Use local var `total_bytes' instead of
810 abusing vector->header.next.nbytes.
811 (live_vector_p): Use PVEC_TYPE.
812 (mark_object): Adapt code to extract pvectype. Use switch.
814 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
816 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
817 Tighten new eassert a bit.
819 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
821 Fix compilation with --enable-gcc-warnings and -O1
823 * doprnt.c (doprnt): Change type of tem to int, initialize
824 to avoid compiler warning. Add eassert.
825 * search.c (simple_search): Initialize match_byte to avoid
826 compiler warning. Add eassert.
828 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
830 Avoid weird behavior with large horizontal scrolls.
831 Without this change, for example, large hscroll values would
832 mess up Emacs's display on Fedora 15 x86, presumably due to
833 overflows in int calculations in the display code.
834 Also, if buffers had long lines, Emacs would freeze.
835 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
836 (set_window_hscroll): New function, containing the old guts of
837 Fset_window_hscroll. Return the clipped value.
838 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
839 This avoids the need to check against PTRDIFF_MAX.
841 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
843 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
845 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
847 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
849 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
850 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
851 since GCC 4.4.6 issues a bogus warning for them.
853 Fix bugs in file timestamp newness comparisons.
854 * fileio.c (Ffile_newer_than_file_p):
855 * lread.c (Fload): Use full timestamp resolution of files,
856 not just the 1-second resolution, so that files that are only
857 slightly newer still count as newer.
858 * fileio.c (Ffile_newer_than_file_p): Don't assume file
859 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
861 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
863 * fileio.c: Improve handling of file time marker. (Bug#11852)
864 (special_mtime): New function.
865 (Finsert_file_contents, Fverify_visited_file_modtime):
866 Use it to set special mtime values consistently.
868 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
870 * fileio.c (Finsert_file_contents): Properly handle st_mtime
871 marker for non-existing file. (Bug#11852)
873 2012-07-03 Glenn Morris <rgm@gnu.org>
875 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
876 and did not make it into globals.h).
878 2012-07-03 Tom Tromey <tromey@redhat.com>
880 * window.c (Fset_window_margins, Fset_window_fringes)
881 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
882 * textprop.c (Fprevious_property_change): No longer static.
883 * syntax.c (Fsyntax_table_p): No longer static.
884 * process.c (Fget_process, Fprocess_datagram_address): No longer
886 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
887 * keyboard.c (Fcommand_execute): No longer static.
889 * insdel.c (Fcombine_after_change_execute): No longer static.
890 * image.c (Finit_image_library): No longer static.
891 * fileio.c (Fmake_symbolic_link): No longer static.
892 * eval.c (Ffetch_bytecode): No longer static.
893 * editfns.c (Fuser_full_name): No longer static.
894 * doc.c (Fdocumentation_property, Fsnarf_documentation):
896 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
898 * dired.c (Ffile_attributes): No longer static.
899 * composite.c (Fcomposition_get_gstring): No longer static.
900 * callproc.c (Fgetenv_internal): No longer static.
902 * ccl.h: Remove EXFUNs.
903 * buffer.h: Remove EXFUNs.
904 * dispextern.h: Remove EXFUNs.
905 * intervals.h: Remove EXFUNs.
906 * fontset.h: Remove EXFUN.
907 * font.h: Remove EXFUNs.
908 * dosfns.c (system_process_attributes): Remove EXFUN.
909 * keymap.h: Remove EXFUNs.
910 * lisp.h: Remove EXFUNs.
911 * w32term.h: Remove EXFUNs.
912 * window.h: Remove EXFUNs.
913 * xsettings.h: Remove EXFUN.
914 * xterm.h: Remove EXFUN.
916 2012-07-03 Glenn Morris <rgm@gnu.org>
918 * lisp.h (Frandom): Make it visible to C.
919 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
920 buffer for invisible buffers. (Bug#1229)
922 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
924 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
925 values which aren't power of 2.
926 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
927 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
930 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
932 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
934 * alloc.c (mark_object): Revert part of last patch to use `switch'.
936 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
938 * alloc.c (allocate_vector_block): Remove redundant
939 calls to mallopt if DOUG_LEA_MALLOC is defined.
940 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
941 avoid calls to mallopt if zero_vector is returned.
943 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
945 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
946 is enabled, avoid dereferencing NULL current_sblock if
949 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
951 Cleanup basic buffer management.
952 * buffer.h (struct buffer): Change layout to use generic vector
953 marking code. Fix some comments. Change type of 'clip_changed'
954 to bitfield. Remove unused #ifndef old.
955 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
956 (GET_OVERLAYS_AT): Fix indentation.
957 (for_each_per_buffer_object_at): New macro.
958 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
959 (Fbuffer_local_variables): Use it.
960 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
961 * alloc.c (allocate_buffer): Adjust to match new layout of
962 struct buffer. Fix comment.
963 (mark_overlay): New function.
964 (mark_buffer): Use it. Use mark_vectorlike to mark normal
965 Lisp area of struct buffer.
966 (mark_object): Use it. Adjust marking of misc objects
967 and related comments.
969 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
971 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
972 wrapper that is not needed because the wrapped code is a no-op (zero
973 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
974 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
976 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
978 * alloc.c (mark_buffer): Simplify. Remove prototype.
979 (mark_object): Add comment. Reorganize marking of vector-like
980 objects. Use CHECK_LIVE for all vector-like objects except buffers
981 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
982 redundant calls to mark_vectorlike for bool vectors.
984 2012-06-30 Glenn Morris <rgm@gnu.org>
986 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
988 * epaths.in (PATH_SITELOADSEARCH): New.
989 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
990 This is rather than relying on --enable-locallisppath elements
991 having "site-lisp" in their names. (Bug#10208#25, 11658)
993 2012-06-30 Eli Zaretskii <eliz@gnu.org>
995 * w32proc.c (sys_select): Accept and ignore one more argument.
997 * w32.c (emacs_gnutls_pull): Call select with one more argument.
999 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1000 (pselect) [!MS_DOS]: Redirect to sys_select.
1002 * sysdep.c: Don't include dos.h and dosfns.h.
1004 * process.c (sys_select):
1005 * msdos.c (sys_select): Accept one more argument and ignore it.
1007 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1008 adapt data types and code to that.
1011 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1012 which clashes with the gnulib function of the same name.
1014 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1016 * font.c (font_style_to_value, font_style_symbolic)
1017 (font_prop_validate_style): Add type checks for values in
1020 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1022 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1025 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1027 * xdisp.c (try_window_id): Undo last change.
1029 * w32.c (getwd): Adjust commentary about startup_dir.
1030 (init_environment): Always call sys_access, even in non-MSVC
1031 builds. Don't chdir to the directory of the Emacs executable.
1032 This undoes code from 1997 which was justified by the need to
1033 "avoid conflicts when removing and renaming directories". But its
1034 downside was that every relative file name was being interpreted
1035 relative to the directory of the Emacs executable, which can never
1036 be TRT. In particular, it broke sys_access when called with
1037 relative file names.
1038 (sys_access): Map GetLastError to errno.
1040 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1042 * window.h (struct window): Change type of 'fringes_outside_margins'
1043 to bitfield. Fix comment. Adjust users accordingly.
1044 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1046 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1049 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1051 * gnutls.c (emacs_gnutls_handshake):
1052 Add QUIT to make the loop interruptible.
1054 2012-06-29 Glenn Morris <rgm@gnu.org>
1056 * charset.c (init_charset): Make lack of etc/charsets fatal.
1058 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1060 * editfns.c (region_limit): Fix type mismatch.
1062 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1064 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1065 undefined. Convert from xassert to eassert.
1066 * nsmenu.m: Convert from xassert to eassert.
1067 * nsterm.m: Likewise.
1069 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1071 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1073 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1075 Avoid integer overflow on scroll-left and scroll-right.
1076 * window.c (HSCROLL_MAX): New macro.
1077 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1078 overflow when requested scroll falls outside ptrdiff_t range.
1080 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1082 * window.h (struct window): Change type of 'hscroll',
1083 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1084 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1085 Adjust users accordingly.
1086 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1087 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1088 from EMACS_INT to ptrdiff_t.
1089 (make_window): Omit redundant initialization.
1091 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1093 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1095 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1097 * window.h (struct window): Change type of 'use_time' and
1098 'sequence_number' from Lisp_Object to int.
1099 * frame.c (make_frame): Adjust users accordingly.
1100 * print.c (print_object): Likewise.
1101 * window.c (select_window, Fwindow_use_time, make_parent_window)
1102 (make_window): Likewise.
1104 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1106 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1107 enabled with --enable-checking=[all,glyphs] configure option.
1108 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1109 adjust comments accordingly.
1110 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1111 undefined, adjust comments accordingly.
1112 * image.c: Likewise.
1113 * scroll.c: Likewise.
1114 * w32fns.c: Likewise.
1115 * w32term.c: Likewise.
1116 * xdisp.c: Likewise.
1117 * xfaces.c: Likewise.
1119 * xterm.c: Likewise.
1121 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1123 Generalize run-time debugging checks.
1124 * dispextern.h (XASSERTS): Remove.
1125 * fontset.c (xassert): Remove.
1126 Convert from xassert to eassert.
1127 * alloc.c: Convert from xassert to eassert.
1129 * dispnew.c: Likewise.
1131 * fringe.c: Likewise.
1132 * ftfont.c: Likewise.
1133 * gtkutil.c: Likewise.
1134 * image.c: Likewise.
1135 * keyboard.c: Likewise.
1137 * process.c: Likewise.
1138 * scroll.c: Likewise.
1139 * sound.c: Likewise.
1141 * w32console.c: Likewise.
1142 * w32fns.c: Likewise.
1143 * w32term.c: Likewise.
1144 * window.c: Likewise.
1145 * xdisp.c: Likewise.
1146 * xfaces.c: Likewise.
1148 * xselect.c: Likewise.
1149 * xterm.c: Likewise.
1151 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1153 * fns.c (maybe_resize_hash_table): Output message when growing the
1156 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1158 * alloc.c (allocate_string_data): Remove dead code.
1159 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1160 avoid GCC warning about unused macro.
1162 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1164 * alloc.c (allocate_string): Omit intervals initialization.
1165 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1166 as in make_pure_string and make_pure_c_string.
1168 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1170 * alloc.c (allocate_string): Fix last change.
1172 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1174 * alloc.c (allocate_string): Remove two redundant calls
1175 to memset, add explicit initialization where appropriate.
1177 2012-06-27 Glenn Morris <rgm@gnu.org>
1179 * lisp.mk (lisp): Remove paths.elc.
1181 2012-06-27 Chong Yidong <cyd@gnu.org>
1183 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1185 2012-06-26 John Wiegley <johnw@newartisans.com>
1187 * unexmacosx.c (copy_data_segment): Add two section names used
1188 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1190 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1191 when building with Clang.
1193 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1195 * eval.c (Fapply): Allow calling it with a single argument.
1197 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1199 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1200 _stricmp and _strnicmp.
1201 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1203 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1205 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1207 (allocate_process): Likewise for new process.
1208 (allocate_terminal): Change to use offsetof.
1209 (allocate_frame): Likewise.
1210 * frame.c (make_frame): Omit redundant initialization.
1211 * window.c (make_parent_window): Use memset.
1212 (make_window): Omit redundant initialization.
1213 * process.c (make_process): Omit redundant initialization.
1214 * terminal.c (create_terminal): Likewise.
1216 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1218 * term.c (delete_tty): Remove redundant call to memset.
1220 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1222 * alloc.c: Remove build_string.
1223 * lisp.h: Define build_string as static inline. This provides
1224 a better opportunity to optimize away calls to strlen when the
1225 function is called with compile-time constant argument.
1226 * image.c (imagemagick_error): Convert to build_string.
1227 * w32proc.c (sys_spawnve): Likewise.
1228 * xterm.c (x_term_init): Likewise.
1230 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1232 Use sprintf return value instead of invoking strlen on result.
1233 In the old days this wasn't portable, since some sprintf
1234 implementations returned char *. But they died out years ago and
1235 Emacs already assumes sprintf returns int.
1236 Similarly for float_to_string.
1237 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1238 * ccl.c (ccl_driver):
1239 * character.c (string_escape_byte8):
1240 * data.c (Fnumber_to_string):
1241 * doprnt.c (doprnt):
1242 * print.c (print_object):
1243 * xdisp.c (message_dolog):
1244 * xfns.c (syms_of_xfns):
1245 Use sprintf or float_to_string result to avoid need to call strlen.
1246 * data.c (Fnumber_to_string):
1247 Use make_unibyte_string, since the string must be ASCII.
1248 * lisp.h, print.c (float_to_string): Now returns int length.
1249 * term.c (produce_glyphless_glyph):
1250 Use sprintf result rather than recomputing it.
1252 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1253 * Makefile.in (ALL_CFLAGS):
1254 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1255 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1257 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1259 * dispextern.h (xstrcasecmp): Define to library function
1260 strcasecmp if available.
1261 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1263 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1265 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1266 Avoid comma operator.
1267 * menu.c (push_submenu_start, push_submenu_end)
1268 (push_left_right_boundary, push_menu_pane): Likewise.
1269 * msdos.c (dos_rawgetc): Likewise.
1271 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1273 * xfns.c (xic_create_fontsetname): Remove redundant calls
1276 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1278 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1279 sprintf already null-terminates its output.
1281 * xfns.c (x_window): Remove redundant cast.
1283 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1285 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1286 `const char *' to `char *' to avoid compiler warning.
1288 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1290 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1291 instead of truncating it to 63 (admittedly a generous limit).
1293 * process.c: Fix spelling and caps in comments.
1295 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1297 * emacs.c (setpgrp): Remove definition, unused.
1298 * sysdep.c (setpgrp): Remove definition, not used in this file.
1300 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1302 * makefile.w32-in: Update dependencies.
1304 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1306 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1307 (SYSTIME_H): Add nt/inc/sys/time.h.
1309 * systime.h [WINDOWSNT]: Include sys/time.h.
1311 * s/ms-w32.h (struct timespec): Definition moved from
1312 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1314 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1316 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1317 * buffer.h (buffer_slot_type_mismatch):
1318 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1319 * eval.c (unwind_to_catch):
1320 * image.c (my_png_error, my_error_exit):
1321 * keyboard.c (quit_throw_to_read_char, user_error)
1322 (Fexit_recursive_edit, Fabort_recursive_edit):
1323 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1324 (wrong_type_argument, buffer_overflow, __executable_start)
1325 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1326 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1327 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1329 (child_setup) [!DOS_NT]:
1330 * lread.c (end_of_file_error, invalid_syntax):
1331 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1332 * puresize.h (pure_write_error):
1333 * search.c (matcher_overflow):
1334 * sound.c (sound_perror, alsa_sound_perror):
1335 * sysdep.c, syssignal.h (croak):
1336 * term.c (maybe_fatal, vfatal):
1337 * textprop.c (text_read_only):
1338 * undo.c (user_error):
1339 * unexmacosx.c (unexec_error):
1340 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1341 Use _Noreturn rather than NO_RETURN.
1342 No need for separate decl merely because of _Noreturn.
1343 * sound.c (sound_warning, parse_sound):
1344 Remove unnecessary forward decls.
1346 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1348 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1349 * lisp.h (WAIT_READING_MAX): New macro.
1350 * dispnew.c (Fsleep_for, sit_for):
1351 * keyboard.c (kbd_buffer_get_event):
1352 * process.c (Faccept_process_output):
1353 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1354 This improves on the previous patch, which introduced a bug
1355 when time_t is unsigned and as wide as intmax_t.
1356 See <http://bugs.gnu.org/9000#51>.
1358 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1360 * dispnew.c (sit_for, Fsleep_for):
1361 * keyboard.c (kbd_buffer_get_event):
1362 * process.c (Faccept_process_output): Avoid compiler warnings when
1363 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1365 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1367 * makefile.w32-in: Update dependencies.
1369 * w32.c (ltime): Add return type and declare static.
1370 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1372 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1374 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1375 Privately reported by Herbert J. Skuhra.
1376 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1378 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1379 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1381 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1383 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1384 last argument of make_unibyte_string.
1386 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1387 language ID in the event parameters.
1389 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1390 event.code, not the obscure "character set ID".
1392 2012-06-23 Chong Yidong <cyd@gnu.org>
1394 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1396 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1398 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1399 * w32.c (fdutimens): New function.
1401 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1403 * s/ms-w32.h (pselect): Redirect to sys_select.
1405 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1407 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1408 in the logic of incrementing and decrementing the value of
1409 use_relocatable_buffers.
1411 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1413 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1414 Privately reported by Herbert J. Skuhra.
1415 [__FreeBSD__]: Remove "*/" typo after "#include".
1416 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1417 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1418 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1419 Don't assume EMACS_TIME and struct timeval are the same type.
1421 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1423 Support higher-resolution time stamps (Bug#9000).
1424 The time stamps are only nanosecond-resolution at the C level,
1425 since that's the best that any real-world system supports now.
1426 But they are picosecond-resolution at the Lisp level, as that's
1427 easy, and leaves room for future OS improvements.
1429 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1432 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1433 Don't get current time unless it's needed.
1435 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1436 now provides it if it's absent.
1437 (start_atimer): Port to higher-res time stamps.
1438 Check for time stamp overflow. Don't get current time more
1439 often than is needed.
1441 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1442 Include systime.h, not time.h.
1443 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1445 * dired.c: Include stat-time.h.
1446 (Ffile-attributes): File times now have higher resolution.
1448 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1449 (struct image): Timestamp now has higher resolution.
1451 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1452 has at least microseconds now. All uses removed.
1453 (update_frame, update_single_window, update_window, update_frame_1)
1454 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1456 * editfns.c (time_overflow): Now extern.
1457 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1458 (float-time, Fformat_time_string, Fcurrent_time_string)
1459 (Fcurrent_time_zone): Accept and generate higher-resolution
1461 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1462 (decode_time_components, lisp_seconds_argument): New functions.
1463 (make_time): Now static.
1464 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1465 Report an error if the time is invalid, rather than having the caller
1468 * fileio.c: Include <stat-time.h>
1469 (Fcopy_file): Copy higher-resolution time stamps.
1470 Prefer to set the time stamp via a file descriptor if that works.
1471 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1472 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1473 (Fvisited_file_modtime, Fset_visited_file_modtime):
1474 Support higher-resolution time stamps.
1476 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1478 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1480 * image.c (prepare_image_for_display, clear_image_cache)
1481 (lookup_image): Port to higer-resolution time stamps.
1483 * keyboard.c (start_polling, bind_polling_period):
1484 Check for time stamp overflow.
1485 (read_char, kbd_buffer_get_event, timer_start_idle)
1486 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1487 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1488 Port to higher-resolution time stamps. Do not assume time_t is signed.
1489 (decode_timer): New function. Timers are now vectors of length 9,
1490 not 8, to accommodate the picosecond component.
1491 (timer_check_2): Use it.
1493 * nsterm.m (select_timeout, timeval_subtract): Remove.
1494 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1495 as they're a bit more accurate and handle overflow better.
1496 (ns_select): Change prototype to be compatible with pselect.
1497 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1498 * nsterm.h (ns_select): Adjust prototype.
1500 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1501 us-resolution time stamps.
1502 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1504 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1506 * lisp.h (time_overflow): New decl.
1507 (wait_reading_process_output): First arg is now intmax_t, not int,
1508 to accommodate larger waits.
1510 * process.h (struct Lisp_Process.read_output_delay):
1511 Now counts nanoseconds, not microseconds.
1512 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1514 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1515 (wait_reading_process_output):
1516 Port to ns-resolution time stamps.
1517 (Faccept_process_output, wait_reading_process_output):
1518 Check for time stamp overflow. Do not assume time_t is signed.
1519 (select_wrapper): Remove; we now use pselect.
1520 (Fprocess_attributes): Now generates ns-resolution time stamps.
1522 * sysdep.c: Include utimens.h. Don't include utime.h
1523 or worry about struct utimbuf; gnulib does that for us now.
1524 (gettimeofday): Remove; gnulib provides a substitute.
1525 (make_timeval): New function.
1526 (set_file_times): Now sets ns-resolution time stamps.
1527 New arg FD; all uses changed.
1528 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1529 (system_process_attributes):
1530 Now returns ns-resolution time stamp. All uses changed.
1531 Check for time stamp overflow.
1533 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1534 provides a substitute now.
1536 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1537 since it guarantees struct timespec.
1538 (EMACS_TIME): Now struct timespec, so that we can support
1539 ns-resolution time stamps.
1540 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1541 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1542 (EMACS_USECS): Remove.
1543 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1544 so multiply the arg by 1000 before storing it.
1545 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1547 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1548 Port to ns-resolution time stamps.
1549 (EMACS_TIME_NEG_P): Remove; replaced by....
1550 (EMACS_TIME_SIGN): New macro.
1551 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1552 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1553 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1554 (make_timeval, make_lisp_time, decode_time_components): New decls.
1555 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1556 that it mishandled time_t overflow. You can't compare by subtracting!
1557 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1558 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1560 * term.c: Include <sys/time.h>.
1561 (timeval_to_Time): New function, for proper overflow wraparound.
1562 (term_mouse_position, term_mouse_click): Use it.
1564 * undo.c (record_first_change): Support higher-resolution time stamps
1566 (Fprimitive_undo): Use them when restoring time stamps.
1568 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1569 (w32_get_internal_run_time):
1570 Port to higher-resolution Emacs time stamps.
1571 (ltime): Now accepts single 64-bit integer, as that's more convenient
1574 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1576 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1577 for compatibility with pselect. Support ns-resolution time stamps.
1579 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1581 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1582 Check for time stamp overflow, and support ns-resolution time stamps.
1584 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1585 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1586 (timeval_subtract): Remove; no longer needed.
1587 (XTflash, XTring_bell, x_wait_for_event):
1588 Port to ns-resolution time stamps. Don't assume time_t is signed.
1590 2012-06-22 Chong Yidong <cyd@gnu.org>
1592 * xdisp.c (x_consider_frame_title): Revert last change.
1594 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1596 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1597 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1598 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1599 staticidx goes up to 1597 out of 1600 = 0x640.)
1601 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1603 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1604 Otherwise, the umask might be mistakenly 0 while handling input signals.
1606 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1608 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1610 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1612 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1613 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1614 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1615 access to `contents' member of Lisp_Vector objects with AREF and ASET
1618 2012-06-19 Chong Yidong <cyd@gnu.org>
1620 * frame.c (delete_frame): When selecting a frame on a different
1621 text terminal, do not alter the terminal's top-frame.
1623 * xdisp.c (format_mode_line_unwind_data): Record the target
1624 frame's selected window and its terminal's top-frame.
1625 (unwind_format_mode_line): Restore them.
1626 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1628 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1629 since tty frames can be explicitly named.
1630 (prepare_menu_bars): Likewise.
1632 * term.c (Ftty_top_frame): New function.
1634 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1636 Port byte-code-meter to modern targets.
1637 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1638 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1639 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1640 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1641 (METER_1, METER_2): Simplify.
1643 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1645 * data.c (Fdefalias): Return `symbol' (bug#11686).
1647 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1649 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1650 gets killed during executing of this function (Bug#11665).
1651 Try to always return Qt when the buffer has been actually killed.
1652 (Vkill_buffer_query_functions): In doc-string say that functions
1653 run by this hook should not change the current buffer.
1655 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1657 Fix recently-introduced process.c problems found by static checking.
1658 * process.c (write_queue_push, write_queue_pop, send_process):
1659 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1660 (write_queue_pop): Fix pointer signedness problem.
1661 (send_process): Remove unused local.
1663 2012-06-17 Chong Yidong <cyd@gnu.org>
1665 * xdisp.c (redisplay_internal): No need to redisplay terminal
1666 frames that are not on top.
1668 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1670 * process.c (make_process): Initialize write_queue.
1671 (write_queue_push, write_queue_pop): New functions.
1672 (send_process): Use them to maintain correct ordering of process
1675 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1677 * lisp.h (eassert): Assume C89 or later.
1678 This removes the need for CHECK.
1679 (CHECK): Remove. Its comments about always evaluating its
1680 argument were confusing, as 'eassert' typically does not evaluate
1683 * coding.c (produce_chars): Use ptrdiff_t, not int.
1685 * xterm.c (x_draw_underwave): Check for integer overflow.
1686 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1688 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1690 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1691 referenced (Bug#11583).
1693 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1695 Implement wave-style variant of underlining.
1696 * dispextern.h (face_underline_type): New enum.
1697 (face): Add field for underline type.
1698 * nsterm.m (ns_draw_underwave): New function.
1699 (ns_draw_text_decoration): Use it.
1700 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1702 (x_draw_glyph_string): Use them.
1703 * xfaces.c (Qline, Qwave): New Lisp objects.
1704 (check_lface_attrs, merge_face_ref)
1705 (Finternal_set_lisp_face_attribute, realize_x_face):
1706 Handle wave-style underline face attributes.
1707 * xterm.c (x_draw_underwave): New function.
1708 (x_draw_glyph_string): Use it.
1710 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1712 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1713 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1714 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1715 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1716 ($(BLD)/w32select.$(O)): Update dependencies.
1718 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1720 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1721 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1722 * character.c (_fetch_multibyte_char_p): Remove.
1723 * alloc.c: Include "character.h" before "buffer.h".
1725 * buffer.c: Likewise.
1726 * bytecode.c: Likewise.
1727 * callint.c: Likewise.
1728 * callproc.c: Likewise.
1729 * casefiddle.c: Likewise.
1730 * casetab.c: Likewise.
1731 * category.c: Likewise.
1733 * coding.c: Likewise.
1734 * composite.c: Likewise.
1735 * dired.c: Likewise.
1736 * dispnew.c: Likewise.
1738 * dosfns.c: Likewise.
1739 * editfns.c: Likewise.
1740 * emacs.c: Likewise.
1741 * fileio.c: Likewise.
1742 * filelock.c: Likewise.
1744 * fontset.c: Likewise.
1745 * fringe.c: Likewise.
1746 * indent.c: Likewise.
1747 * insdel.c: Likewise.
1748 * intervals.c: Likewise.
1749 * keyboard.c: Likewise.
1750 * keymap.c: Likewise.
1751 * lread.c: Likewise.
1752 * macros.c: Likewise.
1753 * marker.c: Likewise.
1754 * minibuf.c: Likewise.
1755 * nsfns.m: Likewise.
1756 * nsmenu.m: Likewise.
1757 * print.c: Likewise.
1758 * process.c: Likewise.
1759 * regex.c: Likewise.
1760 * region-cache.c: Likewise.
1761 * search.c: Likewise.
1762 * syntax.c: Likewise.
1764 * textprop.c: Likewise.
1766 * unexsol.c: Likewise.
1767 * w16select.c: Likewise.
1768 * w32fns.c: Likewise.
1769 * w32menu.c: Likewise.
1770 * window.c: Likewise.
1771 * xdisp.c: Likewise.
1773 * xmenu.c: Likewise.
1775 * xselect.c: Likewise.
1777 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1779 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1780 If all the glyphs of the glyph row came from strings, and we have no
1781 cursor positioning clues, put the cursor on the first glyph of the
1783 (handle_face_prop): Use chunk-relative overlay string index when
1784 indexing into it->string_overlays array. (Bug#11653)
1785 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1786 the rightmost. (Bug#11720)
1788 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1790 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1791 (CATEGORY_MEMBER): Enforce 1/0 value.
1792 * category.c (_temp_category_set): Remove.
1794 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1796 * window.c (Fdelete_other_windows_internal)
1797 (Fdelete_window_internal): Don't access frame's mouse highlight
1798 info of the initial frame. (Bug#11677)
1800 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1802 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1803 Assume USE_2_TAGS_FOR_INTS.
1804 (xreload): Adjust $tagmask width to match recent lisp.h change.
1806 Simplify lisp.h in minor ways that should not affect code.
1807 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1808 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1809 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1810 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1811 (INTTYPEBITS): New macro, for clarity.
1812 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1813 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1814 Simplify now that USE_LSB_TAG is always defined.
1815 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1816 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1818 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1820 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1822 2012-06-13 Glenn Morris <rgm@gnu.org>
1824 * s/bsd-common.h (BSD4_3):
1825 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1827 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1829 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1832 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1834 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1835 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1836 * alloc.c (widen_to_Lisp_Object): Remove.
1837 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1838 * frame.c (delete_frame): Remove outdated comment.
1839 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1840 USE_LISP_UNION_TYPE.
1841 (Fw32_unregister_hot_key): Likewise.
1842 (Fw32_toggle_lock_key): Likewise.
1843 * w32menu.c (add_menu_item): Likewise.
1844 (w32_menu_display_help): Use XIL instead of checking
1845 USE_LISP_UNION_TYPE.
1846 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1847 (init_heap): Likewise.
1848 * w32term.c (w32_read_socket): Update comment.
1850 2012-06-13 Glenn Morris <rgm@gnu.org>
1852 * s/usg5-4-common.h, src/s/unixware.h:
1853 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1855 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1857 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1859 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1860 * alloc.c (make_number) [!defined make_number]:
1861 Remove, as lisp.h always defines this now.
1862 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1863 (roundup_size): Verify that it is a power of 2.
1864 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1865 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1866 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1867 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1868 USE_LSB_TAG now is always defined to be either 0 or 1.
1870 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1871 code works fine either way, and efficiency is not a concern here,
1872 as the union type is for debugging, not for production.
1873 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1874 Use an inline function on all platforms when using the union type,
1875 since this is simpler and 'static inline' can be used portably
1877 (LISP_INITIALLY_ZERO): New macro.
1878 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1879 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1881 2012-06-12 Glenn Morris <rgm@gnu.org>
1883 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1885 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1887 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1888 Move BROKEN_SIGIO to configure.
1890 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1891 Move NO_TERMIO to configure.
1893 2012-06-12 Chong Yidong <cyd@gnu.org>
1895 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1896 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1897 MagickExportImagePixels is undefined.
1899 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1901 * image.c (imagemagick_load_image): Remove unused label.
1903 2012-06-11 Glenn Morris <rgm@gnu.org>
1905 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1906 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1907 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1908 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1910 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1912 * alloc.c (make_byte_code): New function.
1913 (Fmake_byte_code): Use it. Don't purify here.
1914 * lread.c (read1): Use it as well to avoid extra allocation.
1916 2012-06-11 Chong Yidong <cyd@gnu.org>
1918 * image.c (imagemagick_load_image): Implement transparency.
1920 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1922 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1923 account for preceding backslashes. (Bug#11663)
1925 2012-06-09 Chong Yidong <cyd@gnu.org>
1927 * term.c: Support italics in capable terminals (Bug#9652).
1928 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1929 (turn_on_face): Output using TS_enter_italic_mode if available.
1930 Don't handle unused blinking and alt-charset cases.
1931 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1932 and tty_alt_charset_p cases.
1933 (tty_capable_p, init_tty): Support italics.
1935 * termchar.h (struct tty_display_info): Add field for italics.
1936 Remove unused blink field.
1938 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1941 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1942 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1943 tty_alt_charset_p. Add tty_italic_p.
1945 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1947 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1948 dbus_type_is_basic if available.
1949 (xd_extract_signed, xd_extract_unsigned): Rename from
1950 extract_signed and extract_unsigned, respectively. Adapt callers.
1952 2012-06-09 Chong Yidong <cyd@gnu.org>
1954 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1956 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1959 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1961 * xdisp.c (vmessage): Treat frame message as multibyte.
1962 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1963 would generate the diagnostic "Making \302\247 buffer-local while
1966 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1968 * dispnew.c (showing_window_margins_p): Undo last change, which
1969 was done due to an inadvertent commit.
1970 (adjust_frame_glyphs_for_frame_redisplay): Do call
1971 showing_window_margins_p.
1973 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1975 * eval.c (Fmake_var_non_special): New primitive.
1976 (syms_of_eval): Defsubr it.
1977 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1979 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1981 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1982 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1984 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1986 * alloc.c (allocate_vectorlike): Fix last change.
1988 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1990 Block-based vector allocation of small vectors.
1991 * lisp.h (struct vectorlike_header): New field `nbytes',
1992 adjust comment accordingly.
1993 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1994 to denote vector blocks. Adjust users (live_vector_p,
1995 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1996 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1997 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1998 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1999 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2000 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2001 (roundup_size): New constant.
2002 (struct vector_block): New data type.
2003 (vector_blocks, vector_free_lists, zero_vector): New variables.
2004 (all_vectors): Rename to `large_vectors'.
2005 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2006 (sweep_vectors): New functions.
2007 (allocate_vectorlike): Return `zero_vector' as the only vector of
2008 0 items. Allocate new vector from block if vector size is less than
2009 or equal to VBLOCK_BYTES_MAX.
2010 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2011 (init_alloc_once): Add call to init_vectors.
2013 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2015 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2017 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2019 * doprnt.c (doprnt): Truncate multibyte char correctly.
2020 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2021 would mishandle a string argument "Xc" if X was a multibyte
2022 character of length 2: it would truncate after X's first byte
2023 rather than including all of X.
2025 2012-06-06 Chong Yidong <cyd@gnu.org>
2027 * buffer.c (word_wrap): Doc fix.
2029 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2031 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2033 2012-06-03 Glenn Morris <rgm@gnu.org>
2035 * xdisp.c (tool-bar-style): Doc fix.
2037 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2039 * Makefile.in (PAXCTL): Define.
2040 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2041 binary via PaX flags if the paxctl utility is available.
2042 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2043 Restore PaX flags to their default. (Bug#11398)
2045 2012-06-03 Chong Yidong <cyd@gnu.org>
2047 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2050 2012-06-03 Chong Yidong <cyd@gnu.org>
2052 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2053 (note_mode_line_or_margin_highlight): If there is no help echo,
2054 use mode-line-default-help-echo. Handle the case where the mouse
2055 position is past the end of the mode line string.
2057 * buffer.c (buffer_local_value_1): New function, split from
2058 Fbuffer_local_value; can return Qunbound.
2059 (Fbuffer_local_value): Use it.
2060 (Vmode_line_format): Docstring tweaks.
2062 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2064 * sysdep.c (system_process_attributes): Improve comment.
2066 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2068 * keyboard.c: Export real-this-command to Elisp.
2069 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2070 and DEFVAR it. Update all users.
2072 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2074 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2076 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2077 Convert pctcpu and pctmem to Lisp float properly.
2078 Let the compiler fold better, as 100.0/0x8000 is exact.
2080 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2082 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2085 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2087 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2089 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2091 For a 'struct window', replace some Lisp_Object fields to
2092 bitfields where appropriate, remove unused fields.
2093 * window.h (struct window): Remove unused 'last_mark_x' and
2094 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2095 change it's type from Lisp_Object to bitfield.
2096 Change type of 'force_start', 'optional_new_start',
2097 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2098 fields from Lisp_Object to bitfield. Adjust users accordingly.
2100 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2102 Pacify gcc -Wdouble-precision when using Xaw.
2103 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2104 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2105 Use 'float' consistently, rather than 'float' in most places
2106 and 'double' in a couple of places.
2108 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2110 * xdisp.c (handle_stop): Detect whether we have overlay strings
2111 loaded by testing it->current.overlay_string_index to be
2112 non-negative, instead of checking whether n_overlay_strings is
2113 positive. (Bug#11587)
2115 2012-05-31 Chong Yidong <cyd@gnu.org>
2117 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2119 * doc.c (Fsubstitute_command_keys): Doc fix.
2121 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2123 * search.c (search_buffer): Remove calls to
2124 r_alloc_inhibit_buffer_relocation, as it is now called by
2125 maybe_unify_char, which was the cause of relocation of buffer text
2128 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2130 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2131 for the duration of call to load_charset, to avoid problems with
2132 callers of maybe_unify_char that access buffer text through C
2135 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2136 decrement the inhibition flag, instead of just setting or
2139 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2141 Remove obsolete '#define static' cruft.
2142 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2143 This #undef was "temporary" in 2000; it is no longer needed
2144 now that '#define static' has gone away.
2145 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2146 (gray_bitmap_bits): Remove; no longer needed.
2147 All uses replaced with definiens.
2148 * xterm.c: Include "bitmaps/gray.xbm".
2150 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2152 Clean up __executable_start, monstartup when --enable-profiling.
2153 The following changes affect the code only when profiling.
2154 * dispnew.c (__executable_start): Rename from safe_bcopy.
2155 Define only on platforms that need it.
2156 * emacs.c: Include <sys/gmon.h> when profiling.
2157 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2158 (__executable_start): Remove decl, since lisp.h does it now.
2159 (safe_bcopy): Remove decl; no longer has that name.
2160 (main): Coalesce #if into single bit of code, for simplicity.
2161 Cast pointers to uintptr_t, since standard libraries want integers
2163 * lisp.h (__executable_start): New decl.
2165 2012-05-31 Glenn Morris <rgm@gnu.org>
2167 * image.c (Fimagemagick_types): Doc fix.
2169 2012-05-30 Jim Meyering <meyering@redhat.com>
2171 * callproc.c (Fcall_process_region): Include directory component
2172 in mkstemp error message (Bug#11586).
2174 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2176 * alloc.c, lisp.h (make_pure_vector): Now static.
2178 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2180 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2181 Move to byte-run.el.
2182 (Fautoload): Do the hash-doc more carefully.
2183 * data.c (Fdefalias): Purify definition, except for keymaps.
2184 (Qdefun): Move from eval.c.
2185 * lisp.h (Qdefun): Remove.
2186 * lread.c (read1): Tiny simplification.
2188 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2190 Do not create empty overlays with the evaporate property (Bug#9642).
2191 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2192 Bug#9642, but explicitly check that the buffer the overlay would
2193 be moved to is live and rearrange lines to make sure that errors
2194 will not put the overlay in an inconsistent state.
2195 (Fdelete_overlay): Cosmetics.
2197 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2199 * w32term.c (my_bring_window_to_top): New function.
2200 (x_raise_frame): Use handle returned by DeferWindowPos, which
2201 could be different from the original one.
2202 Call my_bring_window_to_top instead of my_set_foreground_window.
2205 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2206 by calling BringWindowToTop.
2208 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2209 (WM_EMACS_END): Increase by one.
2211 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2213 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2214 This avoids undefined behavior that might cause the eassert
2215 to not catch an out-of-range value.
2217 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2219 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2220 Update dependencies.
2222 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2224 * bidi.c (bidi_mirror_char): Fix last change.
2226 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2228 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2229 when referring to sectname field in printf format.
2231 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2233 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2234 Only r_alloc_inhibit_buffer_relocation needed to be added;
2235 the others were already declared.
2237 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2238 before checking whether it's out of range. Put the check inside
2240 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2242 2012-05-27 Ken Brown <kbrown@cornell.edu>
2244 * callproc.c (Fcall_process): Restore a line that was accidentally
2245 commented out in the 2011-02-13 change (bug#11547).
2247 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2249 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2250 defined on ralloc.c.
2252 * buffer.c [REL_ALLOC]: Remove prototypes of
2253 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2254 they are now on lisp.h.
2256 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2258 * search.c (search_buffer): Use it to inhibit relocation of buffer
2259 text while re_search_2 is doing its job, because re_search_2 is
2260 passed C pointers to buffer text. (Bug#11519)
2262 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2265 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2266 state after an additional call to move_it_in_display_line_to, keep
2267 the values of it->max_ascent and it->max_descent found for the
2269 (pos_visible_p): Revert the comparison against bottom_y to what it
2270 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2273 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2275 Fix coding-related core dumps with gcc -ftrapv.
2276 The code was computing A - B, where A and B are pointers, and B is
2277 random garbage. This can lead to core dumps on platforms that
2278 have special pointer registers, and it also leads to core dumps on
2279 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2280 A - B only when B is initialized properly.
2281 * coding.c (coding_set_source, coding_set_destination): Return void.
2282 (coding_change_source, coding_change_destinations): New functions,
2283 with the old behaviors of coding_set_source and coding_set_destination.
2284 All callers that need an offset changed to use these new functions.
2286 2012-05-26 Glenn Morris <rgm@gnu.org>
2288 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2290 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2292 Extend mouse support on W32 text-mode console.
2293 * xdisp.c (draw_row_with_mouse_face):
2294 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2296 * w32console.c: Include window.h.
2297 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2299 (initialize_w32_display): Initialize mouse-highlight data.
2301 * w32inevt.c: Include termchar.h and window.h.
2302 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2303 moves, call note_mouse_highlight. If help_echo changed, call
2304 gen_help_event to produce help-echo message in the echo area.
2305 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2308 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2310 * lread.c (read1): Simplify slightly to avoid an overflow warning
2311 with GCC 4.7.0 on x86-64.
2313 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2315 * bidi.c (bidi_mirror_char): Revert last change: an int is
2316 definitely wide enough here.
2318 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2320 Fix integer width and related bugs (Bug#9874).
2321 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2322 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2323 (string_bytes, check_sblock, allocate_string_data):
2324 (compact_small_strings, Fmake_bool_vector, make_string)
2325 (make_unibyte_string, make_multibyte_string)
2326 (make_string_from_bytes, make_specified_string)
2327 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2328 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2331 (allocate_pseudovector):
2332 Use int, not EMACS_INT, where int is wide enough.
2333 (inhibit_garbage_collection, Fgarbage_collect):
2334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2335 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2336 int might not be wide enough.
2337 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2338 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2339 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2340 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2341 (bidi_level_of_next_char, bidi_move_to_visually_next):
2342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2343 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2344 (Fkill_buffer, Fset_buffer_major_mode)
2345 (advance_to_char_boundary, Fbuffer_swap_text)
2346 (Fset_buffer_multibyte, overlays_at, overlays_in)
2347 (overlay_touches_p, struct sortvec, record_overlay_string)
2348 (overlay_strings, recenter_overlay_lists)
2349 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2350 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2351 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2352 (Foverlay_recenter, last_overlay_modification_hooks_used)
2353 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2355 (validate_region): Omit unnecessary test for b <= e,
2356 since that's guaranteed by the previous test.
2357 (adjust_overlays_for_delete): Avoid pos + length overflow.
2358 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2359 (report_overlay_modification):
2360 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2361 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2362 Omit pointer cast, which isn't needed anyway, and doesn't work
2363 after the EMACS_INT -> ptrdiff_t change.
2364 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2365 * buffer.h: Adjust decls to match defn changes elsewhere.
2366 (struct buffer_text, struct buffer):
2367 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2368 Use EMACS_INT, not int, where int might not be wide enough.
2369 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2370 not int, to avoid needless 32-bit limit on 64-bit hosts.
2371 (exec_byte_code): Use tighter memory-full test, one that checks
2372 for alloca overflow. Don't compute the address of the object just
2373 before an array, as that's not portable. Use EMACS_INT, not
2374 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2375 * callint.c (Fcall_interactively):
2376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2377 * callproc.c (call_process_kill, Fcall_process):
2378 Don't assume pid_t fits into an Emacs fixnum.
2379 (call_process_cleanup, Fcall_process, child_setup):
2380 Don't assume pid_t fits into int.
2381 (call_process_cleanup, Fcall_process, delete_temp_file)
2382 (Fcall_process_region):
2383 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2384 (Fcall_process): Simplify handling of volatile integers.
2385 Use int, not EMACS_INT, where int will do.
2386 * casefiddle.c (casify_object, casify_region, operate_on_word)
2387 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2388 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2389 (casify_object): Avoid integer overflow when overallocating buffer.
2390 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2391 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2392 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2393 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2394 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2395 integers are now checked earlier. All uses replaced with XINT.
2397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2398 For CCL_MapSingle, check that content and value are in int range.
2399 (ccl_driver, Fregister_code_conversion_map):
2400 Check that Vcode_version_map_vector is a vector.
2401 (resolve_symbol_ccl_program): Check that vector header is in range.
2402 Always copy the vector, so that we can check its contents reliably
2403 now rather than having to recheck each instruction as it's being
2404 executed. Check that vector words fit in 'int'.
2405 (ccl_get_compiled_code, Fregister_ccl_program)
2406 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2407 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2408 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2409 contents are in range.
2410 (Fccl_execute_on_string): Check that status is in range.
2411 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2412 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2413 Accept and return EMACS_INT, not int, because callers can pass values
2415 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2416 (multibyte_chars_in_text, parse_str_as_multibyte)
2417 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2418 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2419 (string_escape_byte8, Fget_byte):
2420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2421 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2422 avoid mishandling large integers.
2423 * character.h: Adjust decls to match defn changes elsewhere.
2424 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2425 (Ffind_charset_region):
2426 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2427 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2428 (load_charset_map_from_vector, Fdefine_charset_internal):
2429 Don't assume fixnum fits in int.
2430 (load_charset_map_from_vector, Fmap_charset_chars):
2431 Remove now-unnecessary CHECK_NATNUMs.
2432 (Fdefine_charset_internal): Check ranges here, more carefully.
2433 Don't rely on undefined behavior with signed left shift overflow.
2434 Don't assume unsigned int fits into fixnum, or that fixnum fits
2435 into unsigned int. Don't require max_code to be a valid fixnum;
2436 that's not true for gb10830 4-byte on a 32-bit host. Allow
2437 invalid_code to be a cons, for the same reason. Require code_offset
2438 to be a character. Avoid int overflow if max_char is close
2440 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2441 this is intended anyway and avoids some undefined behavior.
2442 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2443 INDEX_TO_CODE_POINT, as that's what it expects.
2444 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2445 * charset.h (DECODE_CHAR): Return int, not unsigned;
2446 this is what was intended anyway, and it avoids undefined behavior.
2447 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2448 integer-overflow issues.
2449 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2450 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2451 where the argument is EMACS_INT, and this behavior is not intended.
2452 * chartab.c (Fmake_char_table, Fset_char_table_range)
2453 (uniprop_get_decoder, uniprop_get_encoder):
2454 Don't assume fixnum fits in int.
2455 * cmds.c (move_point): New function, that does the gist of
2456 Fforward_char and Fbackward_char, but does so while checking
2457 for integer overflow more accurately.
2458 (Fforward_char, Fbackward_char): Use it.
2459 (Fforward_line, Fend_of_line, internal_self_insert)
2460 (internal_self_insert):
2461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2462 Fix a FIXME, by checking for integer overflow when calculating
2463 target_clm and actual_clm.
2464 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2465 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2466 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2467 (coding_alloc_by_making_gap, alloc_destination)
2468 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2469 (encode_coding_utf_16, detect_coding_emacs_mule)
2470 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2471 (detect_coding_iso_2022, decode_coding_iso_2022)
2472 (encode_invocation_designation, encode_designation_at_bol)
2473 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2474 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2475 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2476 (encode_coding_ccl, encode_coding_raw_text)
2477 (detect_coding_charset, decode_coding_charset)
2478 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2479 (produce_composition, produce_charset, produce_annotation)
2480 (decode_coding, handle_composition_annotation)
2481 (handle_charset_annotation, consume_chars, decode_coding_gap)
2482 (decode_coding_object, encode_coding_object, detect_coding_system)
2483 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2484 (code_convert_region, code_convert_string)
2485 (Fdefine_coding_system_internal)
2486 (coding_set_source, coding_set_destination):
2487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2488 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2489 (Fdefine_coding_system_internal):
2490 Don't assume fixnums fit in int.
2491 (decode_coding_gap, decode_coding_object, encode_coding_object)
2492 (Fread_coding_system, Fdetect_coding_region)
2493 (Funencodable_char_position, Fcheck_coding_systems_region)
2494 (get_translation, handle_composition_annotation, consume_chars):
2495 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2496 (consume_chars): Rewrite to not calculate an address outside buffer.
2497 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2498 Don't access memory outside of the args array.
2499 (Fdefine_coding_system_internal): Check for charset-id overflow.
2500 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2501 result of ENCODE_CHAR.
2502 * coding.h: Adjust decls to match defn changes elsewhere.
2503 (struct coding_system):
2504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2505 * composite.c (get_composition_id, find_composition)
2506 (run_composition_function, update_compositions)
2507 (compose_text, composition_gstring_put_cache)
2508 (composition_gstring_p, composition_gstring_width)
2509 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2510 (composition_compute_stop_pos, composition_reseat_it)
2511 (composition_update_it, struct position_record)
2512 (find_automatic_composition, composition_adjust_point)
2513 (Fcomposition_get_gstring, Ffind_composition_internal):
2514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2515 (update_compositions):
2516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2517 * composite.h: Adjust decls to match defn changes elsewhere.
2518 (struct composition):
2519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2520 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2521 Do not attempt to compute the address of the object just before a
2522 buffer; this is not portable.
2524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2525 (Faset): Use int, not EMACS_INT, where int is wide enough.
2526 (Fstring_to_number): Don't assume fixnums fit in int.
2527 (Frem): Don't assume arg is nonnegative.
2528 * dbusbind.c (xd_append_arg): Check for integers out of range.
2529 (Fdbus_call_method): Don't overflow the timeout int.
2530 (extract_signed, extract_unsigned): New functions.
2531 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2532 (xd_get_connection_references): Return ptrdiff_t, not int.
2534 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2535 (xd_read_message_1):
2536 Use int, not unsigned, where the dbus API uses int.
2537 (Fdbus_message_internal): Don't overflow mtype.
2538 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2539 * dired.c (directory_files_internal, file_name_completion, scmp)
2540 (file_name_completion_stat):
2541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2542 (file_name_completion): Don't overflow matchcount.
2543 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2544 * dispextern.h: Adjust decls to match defn changes elsewhere.
2545 (struct text_pos, struct glyph, struct bidi_saved_info)
2546 (struct bidi_string_data, struct bidi_it, struct composition_it)
2548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2549 (struct display_pos, struct composition_it, struct it):
2550 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2551 * dispnew.c (increment_matrix_positions)
2552 (increment_row_positions, mode_line_string)
2553 (marginal_area_string):
2554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2555 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2557 (duration_to_sec_usec): New function, to check for overflow better.
2558 (Fsleep_for, sit_for): Use it.
2559 * doc.c (get_doc_string, store_function_docstring):
2560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2561 (get_doc_string, Fsnarf_documentation):
2562 Use int, not EMACS_INT, where int is wide enough.
2564 Use SAFE_ALLOCA, not alloca.
2565 Check for overflow when converting EMACS_INT to off_t.
2566 * doprnt.c (doprnt):
2567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2568 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2569 Don't assume uid_t fits into fixnum.
2570 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2571 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2572 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2573 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2574 (general_insert_function)
2575 (Finsert_char, make_buffer_string, make_buffer_string_both)
2576 (update_buffer_properties, Fbuffer_substring)
2577 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2578 (Fsubst_char_in_region, check_translation)
2579 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2580 (transpose_markers, Ftranspose_regions):
2581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2582 (clip_to_bounds): Move to lisp.h as an inline function).
2583 (Fconstrain_to_field): Don't assume integers are nonnegative.
2584 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2585 (Fsubst_char_in_region, Fsave_restriction):
2586 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2587 (Femacs_pid): Don't assume pid_t fits into fixnum.
2588 (lo_time): Use int, not EMACS_INT, when int suffices.
2589 (lisp_time_argument): Check for usec out of range.
2590 (Fencode_time): Don't assume fixnum fits in int.
2591 (Fuser_login_name, Fuser_full_name): Signal an error
2592 if a uid argument is out of range, rather than relying on
2594 (Fformat_time_string): Remove now-unnecessary check.
2595 lisp_time_argument checks for out-of-range usec now.
2596 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2597 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2598 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2599 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2600 (init_cmdargs, Fdump_emacs):
2601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2602 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2603 the bottom (typically) 32 bits of the fixnum.
2604 * eval.c (specpdl_size, call_debugger):
2605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2606 (when_entered_debugger, Fbacktrace_debug):
2607 Don't assume fixnum can fit in int.
2608 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2609 the object just before a buffer; this is not portable.
2610 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2611 (grow_specpdl, unbind_to):
2612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2613 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2614 (grow_specpdl): Simplify allocation by using xpalloc.
2615 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2616 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2617 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2619 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2622 (Fcopy_file, non_regular_nbytes, read_non_regular)
2623 (Finsert_file_contents):
2624 Use int, not EMACS_INT, where int is wide enough.
2625 (READ_BUF_SIZE): Verify that it fits in int.
2626 (Finsert_file_contents): Check that counts are in proper range,
2627 rather than assuming fixnums fit into ptrdiff_t etc.
2628 Don't assume fixnums fit into int.
2629 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2630 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2631 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2632 (string_char_to_byte, string_byte_to_char)
2633 (string_make_multibyte, string_to_multibyte)
2634 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2635 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2636 (substring_both, Fdelete, internal_equal, Ffillarray)
2637 (Fclear_string, mapcar1)
2638 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2639 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2640 (larger_vector, make_hash_table, maybe_resize_hash_table)
2641 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2642 (Fmaphash, secure_hash):
2643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2644 (concat): Check for string index and length overflow.
2645 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2648 (larger_vector): New API (vec, incr_min, size_max) replaces old
2649 one (vec, new_size, init). This catches size overflow.
2650 INIT was removed because it was always Qnil.
2651 All callers changed.
2652 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2653 the upper bound on a hash table index size.
2654 (make_hash_table, maybe_resize_hash_table): Use it.
2655 (secure_hash): Computer start_byte and end_byte only after
2656 they're known to be in ptrdiff_t range.
2657 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2658 (Ffont_get_glyphs, Ffont_at):
2659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2660 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2661 (Flist_fonts, Fopen_font):
2662 Don't assume fixnum can fit in int.
2663 (check_gstring): Don't assume index can fit in int.
2664 (font_match_p): Check that fixnum is a character, not a nonnegative
2665 fixnum, since the later code needs to stuff it into an int.
2666 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2667 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2668 conversion overflow issues.
2669 (Fopen_font): Check for integer out of range.
2670 (Ffont_get_glyphs): Don't assume index can fit in int.
2671 * font.h: Adjust decls to match defn changes elsewhere.
2672 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2674 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2675 printmax_t, where ptrdiff_t is wide enough.
2676 (Finternal_char_font):
2677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2678 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2679 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2680 (Fset_frame_position, x_set_frame_parameters)
2681 (x_set_line_spacing, x_set_border_width)
2682 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2683 Check that fixnums are in proper range for system types.
2684 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2686 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2687 Use SAFE_ALLOCA_LISP, not alloca.
2688 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2689 intptr_t is wide enough.
2690 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2691 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2692 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2693 Check for fixnum out of range.
2694 * ftfont.c (ftfont_list): Don't assume index fits in int.
2695 Check that fixnums are in proper range for system types.
2696 (ftfont_shape_by_flt):
2697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2698 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2700 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2701 Check that fixnums are in proper range for system types.
2702 * gnutls.h: Adjust decls to match defn changes elsewhere.
2703 * gtkutil.c (xg_dialog_run):
2704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2705 (update_frame_tool_bar):
2706 Check that fixnums are in proper range for system types.
2707 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2708 (lookup_image): Check that fixnums are in range for system types.
2709 * indent.c (last_known_column, last_known_column_point):
2710 (current_column_bol_cache):
2711 (skip_invisible, current_column, check_display_width):
2712 (check_display_width, scan_for_column, current_column_1)
2713 (Findent_to, Fcurrent_indentation, position_indentation)
2714 (indented_beyond_p, Fmove_to_column, compute_motion):
2715 (Fcompute_motion, Fvertical_motion):
2716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2717 (last_known_column_modified): Use EMACS_INT, not int.
2718 (check_display_width):
2720 Check that fixnums and floats are in proper range for system types.
2721 (compute_motion): Don't assume index or fixnum fits in int.
2722 (compute_motion, Fcompute_motion):
2723 Use int, not EMACS_INT, when it is wide enough.
2724 (vmotion): Omit local var start_hpos that is always 0; that way
2725 we don't need to worry about overflow in expressions involving it.
2726 * indent.h: Adjust decls to match defn changes elsewhere.
2728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2729 Use int, not EMACS_INT, where int is wide enough.
2730 Remove unused members ovstring_chars_done and tab_offset;
2732 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2733 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2734 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2735 (make_gap, copy_text, insert, insert_and_inherit)
2736 (insert_before_markers, insert_before_markers_and_inherit)
2737 (insert_1, count_combining_before, count_combining_after)
2738 (insert_1_both, insert_from_string)
2739 (insert_from_string_before_markers, insert_from_string_1)
2740 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2741 (adjust_after_replace, adjust_after_insert, replace_range)
2742 (replace_range_2, del_range, del_range_1, del_range_byte)
2743 (del_range_both, del_range_2, modify_region)
2744 (prepare_to_modify_buffer, signal_before_change)
2745 (signal_after_change, Fcombine_after_change_execute):
2746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2747 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2748 (balance_an_interval, split_interval_right, split_interval_left)
2749 (find_interval, next_interval, update_interval)
2750 (adjust_intervals_for_insertion, delete_node, delete_interval)
2751 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2752 (static_offset_intervals, offset_intervals)
2753 (merge_interval_right, merge_interval_left, make_new_interval)
2754 (graft_intervals_into_buffer, temp_set_point_both)
2755 (temp_set_point, set_point, adjust_for_invis_intang)
2756 (set_point_both, move_if_not_intangible, get_property_and_range)
2757 (get_local_map, copy_intervals, copy_intervals_to_string)
2758 (compare_string_intervals, set_intervals_multibyte_1):
2759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2760 * intervals.h: Adjust decls to match defn changes elsewhere.
2762 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2763 * keyboard.c (this_command_key_count, this_single_command_key_start)
2764 (before_command_key_count, before_command_echo_length, echo_now)
2765 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2766 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2767 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2768 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2770 (last_non_minibuf_size, last_point_position, echo_truncate)
2771 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2772 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2773 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2774 (stuff_buffered_input):
2775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2776 (last_auto_save, command_loop_1, read_char):
2777 Use EMACS_INT, not int, to avoid integer overflow.
2778 (record_char): Avoid overflow in total_keys computation.
2779 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2780 * keyboard.h: Adjust decls to match defn changes elsewhere.
2781 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2782 (Fkey_description, Fdescribe_vector, Flookup_key):
2783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2784 (click_position): New function, to check that positions are in range.
2785 (Fcurrent_active_maps):
2787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2788 (Faccessible_keymaps, Fkey_description):
2789 (preferred_sequence_p):
2790 Don't assume fixnum can fit into int.
2791 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2792 Check for integer overflow in size calculations.
2793 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2794 avoid mishandling large integers.
2795 * lisp.h: Adjust decls to match defn changes elsewhere.
2796 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2797 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2798 (struct Lisp_Marker):
2799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2800 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2801 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2802 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2803 All callers changed.
2804 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2805 Assume the arg has valid form, since it always does.
2806 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2807 unsigned integer system type.
2808 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2809 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2811 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2812 (duration_to_sec_usec): New decl.
2813 * lread.c (read_from_string_index, read_from_string_index_byte)
2814 (read_from_string_limit, readchar, unreadchar, openp)
2815 (read_internal_start, read1, oblookup):
2816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2817 (Fload, readevalloop, Feval_buffer, Feval_region):
2818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2819 (openp): Check for out-of-range argument to 'access'.
2820 (read1): Use int, not EMACS_INT, where int is wide enough.
2821 Don't assume fixnum fits into int.
2822 Fix off-by-one error that can read outside a buffer.
2823 (read_filtered_event): Use duration_to_sec_usec
2824 to do proper overflow checking on durations.
2825 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2826 in size calculation.
2827 (Fexecute_kbd_macro):
2828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2829 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2830 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2831 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2832 (set_marker_both, set_marker_restricted_both, marker_position)
2833 (marker_byte_position, Fbuffer_has_markers_at):
2834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2835 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2836 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2837 It now merely ensures that the menu is large enough, without
2838 necessarily growing it, as this avoids some integer overflow issues.
2839 All callers changed.
2840 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2842 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2843 Use SAFE_ALLOCA_LISP, not alloca.
2844 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2845 to EMACS_INT. Check that fixnums are in proper range for system types.
2846 * minibuf.c (minibuf_prompt_width, string_to_object)
2847 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2848 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2850 (get_minibuffer, read_minibuf_unwind):
2851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2852 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2853 this simplifies overflow checking. All callers changed.
2854 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2857 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2858 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2859 Check that fixnums are in proper range for system types.
2860 (Fx_create_frame, Fx_show_tip):
2861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2862 * nsfont.m (ns_findfonts, nsfont_list_family):
2863 Don't assume fixnum fits in long.
2864 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2866 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2868 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2869 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2870 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2871 (PRINTDECLARE, PRINTPREPARE):
2872 (strout, print_string):
2873 (print, print_preprocess, print_check_string_charset_prop)
2875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2877 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2879 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2880 (printchar, strout): Use xpalloc to catch size calculation overflow.
2881 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2882 (print_error_message): Use SAFE_ALLOCA, not alloca.
2883 (print_object): Use int, not EMACS_INT, where int is wide enough.
2884 (print_depth, new_backquote_output, print_number_index):
2885 Use ptrdiff_t, not int, where int might not be wide enough.
2886 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2887 (Fset_process_window_size, Fformat_network_address)
2888 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2890 Check that fixnums are in proper range for system types.
2891 (Fsignal_process): Simplify by avoiding a goto.
2892 Check for process-ids out of pid_t range rather than relying on
2894 (process_tick, update_tick): Use EMACS_INT, not int.
2895 (Fformat_network_address, read_process_output, send_process)
2896 (Fprocess_send_region, status_notify):
2897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2898 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2899 (wait_reading_process_output, read_process_output, exec_sentinel):
2900 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2901 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2902 (Faccept_process_output): Use duration_to_sec_usec to do proper
2903 overflow checking on durations.
2904 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2905 Don't assume pid_t fits in int.
2906 * process.h (struct Lisp_Process): Members tick and update_tick
2907 are now of type EMACS_INT, not int.
2908 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2909 configured --with-wide-int.
2910 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2911 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2912 * search.c (looking_at_1, string_match_1):
2913 (fast_string_match, fast_c_string_match_ignore_case)
2914 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2915 (scan_newline, find_before_next_newline, search_command)
2916 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2917 (set_search_regs, wordify):
2920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2921 (string_match_1, search_buffer, set_search_regs):
2923 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2924 (wordify): Check for overflow in size calculation.
2925 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2926 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2927 Check that fixnums are in proper range for system types.
2928 * sound.c (struct sound_device)
2929 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2931 (Fplay_sound_internal):
2932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2933 * syntax.c (struct lisp_parse_state, find_start_modiff)
2934 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2935 (Fparse_partial_sexp):
2936 Don't assume fixnums can fit in int.
2937 (struct lisp_parse_state, find_start_pos, find_start_value)
2938 (find_start_value_byte, find_start_begv)
2939 (update_syntax_table, char_quoted, dec_bytepos)
2940 (find_defun_start, prev_char_comend_first, back_comment):
2941 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2942 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2944 (Finternal_describe_syntax_value): Check that match_lisp is a
2945 character, not an integer, since the code stuffs it into int.
2946 (scan_words, scan_sexps_forward):
2947 Check that fixnums are in proper range for system types.
2949 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2950 (scan_sexps_forward):
2951 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2952 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2953 * syntax.h: Adjust decls to match defn changes elsewhere.
2954 (struct gl_state_s):
2955 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2956 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2957 MOST_POSITIVE_FIXNUM.
2958 * sysdep.c (wait_for_termination_1, wait_for_termination)
2959 (interruptible_wait_for_termination, mkdir):
2960 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2961 (emacs_read, emacs_write):
2962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2963 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2964 and double all fit in int.
2965 * term.c (set_tty_color_mode):
2966 Check that fixnums are in proper range for system types.
2967 * termhooks.h (struct input_event):
2968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2969 * textprop.c (validate_interval_range, interval_of)
2970 (Fadd_text_properties, set_text_properties_1)
2971 (Fremove_text_properties, Fremove_list_of_text_properties)
2972 (Ftext_property_any, Ftext_property_not_all)
2973 (copy_text_properties, text_property_list, extend_property_ranges)
2974 (verify_interval_modification):
2975 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2976 (Fnext_single_char_property_change)
2977 (Fprevious_single_char_property_change):
2978 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2979 (copy_text_properties):
2980 Check for integer overflow in index calculation.
2981 * undo.c (last_boundary_position, record_point, record_insert)
2982 (record_delete, record_marker_adjustment, record_change)
2983 (record_property_change):
2984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2985 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2986 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2987 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2988 (Fx_hide_tip, Fx_file_dialog):
2989 * w32menu.c (set_frame_menubar):
2990 Use ptrdiff_t, not int, for consistency with rest of code.
2991 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2992 (select_window, Fdelete_other_windows_internal)
2993 (window_scroll_pixel_based, window_scroll_line_based)
2994 (Frecenter, Fset_window_configuration):
2995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2996 (Fset_window_hscroll, run_window_configuration_change_hook)
2997 (set_window_buffer, temp_output_buffer_show, scroll_command)
2998 (Fscroll_other_window, Frecenter):
2999 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3000 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3001 Don't assume fixnum fits in int.
3002 (Fset_window_scroll_bars):
3003 Check that fixnums are in proper range for system types.
3004 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3005 (string_pos, c_string_pos, number_of_chars, init_iterator)
3006 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3007 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3008 (compute_display_string_end, handle_face_prop)
3009 (face_before_or_after_it_pos, handle_invisible_prop)
3010 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3011 (display_prop_intangible_p, string_buffer_position_lim)
3012 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3013 (get_overlay_strings_1, get_overlay_strings)
3014 (iterate_out_of_display_property, forward_to_next_line_start)
3015 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3016 (get_next_display_element, set_iterator_to_next)
3017 (get_visually_first_element, compute_stop_pos_backwards)
3018 (handle_stop_backwards, next_element_from_buffer)
3019 (move_it_in_display_line_to, move_it_in_display_line)
3020 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3021 (add_to_log, message_dolog, message_log_check_duplicate)
3022 (message2, message2_nolog, message3, message3_nolog
3023 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3024 (current_message_1, truncate_echo_area, truncate_message_1)
3025 (set_message, set_message_1, store_mode_line_noprop)
3026 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3027 (text_outside_line_unchanged_p, check_point_in_composition)
3028 (reconsider_clip_changes)
3029 (redisplay_internal, set_cursor_from_row, try_scrolling)
3030 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3031 (redisplay_window, find_last_unchanged_at_beg_row)
3032 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3033 (trailing_whitespace_p, find_row_edges, display_line)
3034 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3035 (display_mode_element, store_mode_line_string)
3036 (pint2str, pint2hrstr, decode_mode_spec)
3037 (display_count_lines, display_string, draw_glyphs)
3038 (x_produce_glyphs, x_insert_glyphs)
3039 (rows_from_pos_range, mouse_face_from_buffer_pos)
3040 (fast_find_string_pos, mouse_face_from_string_pos)
3041 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3042 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3043 (safe_call, init_from_display_pos, handle_fontified_prop)
3044 (handle_single_display_spec, load_overlay_strings)
3045 (with_echo_area_buffer, setup_echo_area_for_printing)
3046 (display_echo_area, echo_area_display)
3047 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3048 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3049 (redisplay_window, dump_glyph_row, display_mode_line)
3050 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3051 (handle_display_spec, display_prop_string_p):
3052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3053 (handle_single_display_spec, build_desired_tool_bar_string)
3054 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3055 (get_specified_cursor_type):
3056 Check that fixnums are in proper range for system types.
3057 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3058 (Flookup_image_map):
3059 Don't assume fixnums fit in int.
3060 (compare_overlay_entries):
3061 Avoid mishandling comparisons due to subtraction overflow.
3062 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3063 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3064 (handle_tool_bar_click):
3065 Use int, not unsigned, since we prefer signed and the signedness
3066 doesn't matter here.
3067 (get_next_display_element, next_element_from_display_vector):
3068 Use int, not EMACS_INT, when int is wide enough.
3069 (start_hourglass): Use duration_to_sec_usec to do proper
3070 overflow checking on durations.
3071 * xfaces.c (Fbitmap_spec_p):
3072 Check that fixnums are in proper range for system types.
3073 (compare_fonts_by_sort_order):
3074 Avoid mishandling comparisons due to subtraction overflow.
3075 (Fx_family_fonts, realize_basic_faces):
3076 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3078 Don't assume fixnum fits in int.
3079 Use SAFE_ALLOCA_LISP, not alloca.
3080 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3081 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3082 (face_at_buffer_position, face_for_overlay_string)
3083 (face_at_string_position):
3084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3085 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3086 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3088 Check that fixnums are in proper range for system types.
3089 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3090 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3092 (Fx_change_window_property): Don't assume fixnums fit in int.
3093 * xfont.c (xfont_chars_supported):
3094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3095 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3096 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3098 * xml.c (parse_region):
3099 * xrdb.c (magic_file_p):
3100 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3101 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3102 (x_get_local_selection, x_reply_selection_request)
3103 (x_handle_selection_request, wait_for_property_change):
3104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3105 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3106 short is wide enough.
3107 (x_send_client_event): Don't assume fixnum fits in int.
3108 * xterm.c (x_x_to_emacs_modifiers):
3109 Don't assume EMACS_INT overflows nicely into int.
3110 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3112 (handle_one_xevent): NATNUMP can eval its arg twice.
3113 (x_connection_closed):
3114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3115 * xterm.h: Adjust decls to match defn changes elsewhere.
3116 (struct scroll_bar): Use struct vectorlike_header
3117 rather than rolling our own approximation.
3118 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3120 2012-05-25 Glenn Morris <rgm@gnu.org>
3122 * lisp.mk (lisp): Update for more files being compiled now.
3124 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3126 * lread.c: Remove `read_pure' which makes no difference.
3127 (read_pure): Remove var.
3128 (unreadpure): Remove function.
3129 (readevalloop): Don't call read_list with -1 flag.
3130 (read1, read_vector): Don't test read_pure any more.
3131 (read_list): Simplify.
3133 * fileio.c, character.h: Minor style tweaks.
3135 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3137 * window.h (clip_changed): Remove useless declaration.
3139 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3141 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3142 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3144 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3147 This directory predates autoconf and is no longer needed nowadays.
3148 Move its few remaining bits of functionality to where they're needed.
3149 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3150 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3151 * m/template.h: Remove.
3152 * Makefile.in (M_FILE): Remove. All uses removed.
3153 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3154 * lisp.h (USE_LSB_TAG):
3155 * mem-limits.h (EXCEEDS_LISP_PTR):
3156 Use VAL_MAX, not VALBITS, in #if.
3157 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3158 (EMACS_UINT): Define unconditionally now.
3159 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3160 (BITS_PER_EMACS_INT): New constants, replacing
3161 what used to be in config.h, but not useful in #if.
3162 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3163 define them any more.
3164 (VAL_MAX): New macro.
3166 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3167 BITS_PER_EMACS_INT, in #if.
3168 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3169 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3170 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3171 * s/ms-w32.h (DATA_START):
3172 Move here from removed file m/intel386.h.
3173 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3174 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3176 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3178 Assume C89 or later.
3179 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3180 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3182 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3183 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3184 * textprop.c, tparam.c (NULL): Remove.
3185 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3186 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3187 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3188 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3189 * xterm.c (input_signal_count): Assume volatile works.
3191 2012-05-21 Ken Brown <kbrown@cornell.edu>
3193 * xgselect.c (xg_select): Fix first argument in call to 'select'
3196 2012-05-20 Ken Brown <kbrown@cornell.edu>
3198 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3199 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3201 2012-05-19 Ken Brown <kbrown@cornell.edu>
3203 * xfns.c (x_in_use): Remove `static' qualifier.
3204 * xterm.h (x_in_use): Declare.
3205 * xgselect.c: Include xterm.h.
3206 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3207 and `display_arg' (bug#9754).
3209 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3211 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3213 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3214 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3216 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3218 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3220 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3221 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3223 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3224 reference to image_cache->refcount.
3225 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3227 2012-05-17 Juri Linkov <juri@jurta.org>
3229 * search.c (Fword_search_regexp, Fword_search_backward)
3230 (Fword_search_forward, Fword_search_backward_lax)
3231 (Fword_search_forward_lax): Move functions to isearch.el
3232 (bug#10145, bug#11381).
3234 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3236 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3238 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3240 * lread.c (init_obarray): Declare Qt and Qnil as special.
3242 2012-05-14 Glenn Morris <rgm@gnu.org>
3244 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3245 Put "libexec" before "bin", for the sake of init_callproc_1.
3247 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3249 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3251 * unexaix.c: Port to more-recent AIX compilers.
3252 (report_error, report_error_1, make_hdr, copy_sym)
3253 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3254 Make arguments const char *, not char *, to avoid violations of C
3255 standard and to fix some AIX warnings reported by Gilles Pion.
3257 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3259 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3260 already have overlays loaded.
3261 (handle_single_display_spec): Before returning without displaying
3262 fringe bitmap, synchronize the bidi iterator with the main display
3263 iterator, by calling iterate_out_of_display_property.
3264 (iterate_out_of_display_property): Detect buffer iteration by
3265 testing that it->string is a Lisp string.
3266 (get_next_display_element): When the current object is exhausted,
3267 and there's something on it->stack, call set_iterator_to_next to
3268 proceed with what's on the stack, instead of returning zero.
3269 (set_iterator_to_next): If called at the end of a Lisp string,
3270 proceed to consider_string_end without incrementing string
3271 position. Don't increment display vector index past the end of
3272 the display vector. (Bug#11417)
3273 (pos_visible_p): Don't report a position visible when move_it_to
3274 stopped at the last line of window, which happens to be scanned
3275 backwards by the bidi iteration. (Bug#11464)
3277 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3279 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3280 and right-margin display specs even if the spec is invalid or we
3281 are on a TTY, and thus unable to display on the fringes.
3282 That's because the text with the property will not be displayed anyway,
3283 so we need to signal to the caller that this is a "replacing"
3284 display spec. This fixes display when the spec is invalid or we
3287 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3289 * unexaix.c (make_hdr): Fix typo in prototype.
3290 This bug broke the build on AIX. Problem reported by Gilles Pion.
3292 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3294 * keyboard.c (kbd_buffer_get_event): Read special events also in
3295 batch mode. (Bug#11415)
3297 2012-05-12 Glenn Morris <rgm@gnu.org>
3299 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3301 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3303 * lisp.mk (lisp): Add newcomment.elc.
3305 2012-05-12 Glenn Morris <rgm@gnu.org>
3307 * Makefile.in (MKDIR_P): New, set by configure.
3308 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3310 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3312 Remove unused function hourglass_started.
3313 * dispextern.h (hourglass_started):
3314 * w32fns.c (hourglass_started):
3315 * xdisp.c (hourglass_started): Remove.
3317 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3319 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3320 Update dependencies.
3322 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3324 * xgselect.c (xg_select): Put maxfds+1 into a var.
3325 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3327 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3329 2012-05-10 Dave Abrahams <dave@boostpro.com>
3331 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3332 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3334 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3336 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3337 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3338 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3339 Initialize xd_registered_buses.
3341 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3343 Untag more efficiently if USE_LSB_TAG.
3344 This is based on a proposal by YAMAMOTO Mitsuharu in
3345 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3346 For an admittedly artificial (nth 8000 longlist) benchmark on
3347 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3348 Emacs's overall text size by 1%.
3349 * lisp.h (XUNTAG): New macro.
3350 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3351 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3352 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3353 * eval.c (Fautoload):
3354 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3355 * frame.h (XFRAME): Use XUNTAG.
3357 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3358 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3359 Remove unportable assumptions about print widths of types like
3361 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3362 intptr_t when converting between pointer and integer, to avoid GCC
3363 warnings about wrong width.
3365 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3367 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3368 stack for each reader_thread, instead of defaulting to 8MB
3369 determined by the linker. This avoids failures in creating
3370 subprocesses on Windows 7, see the discussion in this thread:
3371 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3373 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3375 Fix up display of the *Minibuf-0* buffer in the mini window.
3376 * keyboard.c (read_char): Don't clear the echo area if there's no
3378 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3379 contents of *Minibuf-0*) if there's no message displayed in its stead.
3381 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3383 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3386 2012-05-06 Chong Yidong <cyd@gnu.org>
3388 * lisp.mk (lisp): Update.
3390 2012-05-05 Jim Meyering <meyering@redhat.com>
3392 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3394 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3396 * data.c (PUT_ERROR): New macro.
3397 (syms_of_data): Use it. Add new error type `user-error'.
3398 * undo.c (user_error): New function.
3399 (Fprimitive_undo): Use it.
3400 * print.c (print_error_message): Adjust print style for `user-error'.
3401 * keyboard.c (user_error): New function.
3402 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3404 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3406 Do not limit current-time-string to years 1000..9999.
3407 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3408 (Fcurrent_time_string): Support any year that is supported by the
3409 underlying localtime representation. Don't use asctime, as it
3410 has undefined behavior for years outside the range -999..9999.
3412 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3414 Fix race conditions involving setenv, gmtime, localtime, asctime.
3415 Without this fix, interrupts could mess up code that uses these
3416 nonreentrant functions, since setting TZ invalidates existing
3417 tm_zone or tzname values, and since most of these functions return
3418 pointers to static storage.
3419 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3420 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3421 Grow the critical sections to include not just invoking
3422 localtime/gmtime, but also accessing these functions' results
3423 including their tm_zone values if any, and any related TZ setting.
3424 (format_time_string): Last arg is now struct tm *, not struct tm **,
3425 so that the struct tm is saved in the critical section.
3426 All callers changed. Simplify allocation of initial buffer, partly
3427 motivated by the fact that memory allocation needs to be outside
3428 the critical section.
3430 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3432 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3433 with RESET_INTERVAL.
3435 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3436 Remove duplicated buffer name initialization.
3438 2012-05-02 Jim Meyering <jim@meyering.net>
3440 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3442 * xfns.c (x_window): Use xstrdup (Bug#11375).
3444 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3446 * xdisp.c (pos_visible_p): If already at a newline from the
3447 display string before the 'while' loop, don't walk back the glyphs
3448 from it3.glyph_row. Solves assertion violation when the display
3449 string begins with a newline (egg.el). (Bug#11367)
3451 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3453 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3456 2012-05-01 Glenn Morris <rgm@gnu.org>
3458 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3459 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3460 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3461 All were removed before 23.1.
3463 * dispnew.c: Remove HAVE_LIBNCURSES test;
3464 it is always true on relevant platforms.
3466 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3467 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3469 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3471 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3473 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3474 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3477 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3479 Do not avoid creating empty evaporating overlays (Bug#9642).
3480 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3481 That is, do not delete an evaporating overlay if it becomes
3482 empty after its bounds are adjusted to fit within its buffer.
3483 This fix caused other problems, and I'm reverting it until we get
3484 to the bottom of them.
3486 2012-04-27 Chong Yidong <cyd@gnu.org>
3488 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3490 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3492 * xdisp.c (pos_visible_p): If the window start position is beyond
3493 ZV, start the display from buffer beginning. Prevents assertion
3494 violation in init_iterator when the minibuffer window is scrolled
3497 * window.c (window_scroll_pixel_based): Likewise.
3499 2012-04-27 Chong Yidong <cyd@gnu.org>
3501 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3503 2012-04-27 Glenn Morris <rgm@gnu.org>
3505 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3506 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3508 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3510 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3511 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3513 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3515 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3516 display element, check also the underlying string or buffer
3517 character. (Bug#11341)
3519 * w32menu.c: Include w32heap.h.
3520 (add_menu_item): If the call to AppendMenuW (via
3521 unicode_append_menu) fails, disable Unicode menus only if we are
3522 running on Windows 9X/Me.
3524 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3526 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3527 (xgetint): Add missing shift for LSB tags.
3529 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3531 * keyboard.c (read_char): Don't wipe echo area for select window
3532 events: These might get delayed via `mouse-autoselect-window'
3535 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3537 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3538 manipulation of :loaded-from data.
3540 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3542 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3543 now a cons (bug#11311).
3545 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3547 Do not create empty overlays with the evaporate property (Bug#9642).
3548 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3549 if it becomes empty after its bounds are adjusted to fit within
3550 its buffer. Without this fix, in a nonempty buffer (let ((o
3551 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3552 yields an empty overlay that has the evaporate property, which is
3553 not supposed to happen.
3555 Fix minor GTK3 problems found by static checking.
3556 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3557 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3558 (struct _EmacsFixedClass, emacs_fixed_get_type):
3559 Move decls here from emacsgtkfixed.h, since they needn't be public.
3560 (emacs_fixed_get_type): Now static.
3561 (emacs_fixed_class_init): Omit unused local.
3562 (emacs_fixed_child_type): Remove; unused.
3563 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3564 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3565 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3566 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3567 (EMACS_FIXED_GET_CLASS): Remove; unused.
3568 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3570 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3571 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3573 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3575 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3576 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3577 (__malloc_size_t, __malloc_ptrdiff_t):
3578 Remove. All uses removed, replaced by the definiens if needed,
3579 since we can assume C89 or better now.
3580 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3581 (protect_malloc_state, align, get_contiguous_space)
3582 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3583 (malloc_atfork_handler_child, malloc_enable_thread)
3584 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3585 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3586 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3587 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3588 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3589 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3590 Define using prototypes, not old style.
3591 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3592 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3593 (align): Don't assume that signed integer overflow wraps around.
3594 Omit unused local var.
3595 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3596 (_free_internal_nolock, memalign, mallochook, reallochook):
3597 Omit no-longer-needed casts.
3598 (valloc): Use getpagesize, not __getpagesize.
3599 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3600 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3602 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3604 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3606 Move functions from C to Lisp. Make non-blocking method calls
3607 the default. Implement further D-Bus standard interfaces.
3609 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3610 (QCdbus_request_name_allow_replacement)
3611 (QCdbus_request_name_replace_existing)
3612 (QCdbus_request_name_do_not_queue)
3613 (QCdbus_request_name_reply_primary_owner)
3614 (QCdbus_request_name_reply_in_queue)
3615 (QCdbus_request_name_reply_exists)
3616 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3617 (QCdbus_registered_serial, QCdbus_registered_method)
3618 (QCdbus_registered_signal): New Lisp objects.
3619 (XD_DEBUG_MESSAGE): Use sizeof.
3620 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3621 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3622 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3623 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3624 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3625 (xd_signature, xd_append_arg): Allow float for integer types.
3626 (xd_get_connection_references): New function.
3627 (xd_get_connection_address): Rename from xd_initialize.
3628 Return cached address.
3629 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3630 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3632 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3633 Return number of refcounts.
3634 (Fdbus_get_unique_name): Make stronger parameter check.
3635 (Fdbus_message_internal): New defun.
3636 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3637 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3638 (Fdbus_send_signal, Fdbus_register_service)
3639 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3640 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3641 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3642 (Vdbus_compiled_version, Vdbus_runtime_version)
3643 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3644 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3645 (Vdbus_message_type_signal): New defvars.
3646 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3649 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3651 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3652 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3653 Do not assume ptrdiff_t is the same width as 'int'.
3655 * alloc.c: Handle unusual debugging option combinations.
3656 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3657 since the two debugging options are incompatible.
3658 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3660 (mem_init, mem_insert, mem_insert_fixup):
3661 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3662 (NEED_MEM_INSERT): Remove; no longer needed.
3664 2012-04-22 Leo Liu <sdl.web@gmail.com>
3666 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3668 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3670 * sysdep.c [__FreeBSD__]: Minor cleanups.
3671 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3672 Use Emacs indenting style more consistently. Avoid some casts.
3673 Use 'double' consistently rather than mixing 'float' and 'double'.
3675 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3677 * sysdep.c (list_system_processes, system_process_attributes):
3678 Add implementation for FreeBSD (Bug#5243).
3680 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3682 * lisp.mk (lisp): Update.
3684 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3686 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3687 It is never used otherwise.
3689 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3691 * print.c (print_preprocess): Only check print_depth if print-circle
3693 (print_object): Check for cycles even when print-circle is nil and
3694 print-gensym is t, but only check print_depth if print-circle is nil.
3696 2012-04-20 Chong Yidong <cyd@gnu.org>
3698 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3699 set the status to "failed" and ensure that sentinel is run.
3701 2012-04-20 Glenn Morris <rgm@gnu.org>
3703 * process.c (Fset_process_inherit_coding_system_flag)
3704 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3705 (Fmake_network_process, Fmake_serial_process): Doc fix.
3707 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3709 * xdisp.c (string_buffer_position_lim): Limit starting position to
3711 (set_cursor_from_row): If called for a mode-line or header-line
3712 row, return zero immediately.
3713 (try_cursor_movement): If inside continuation line, don't back up
3714 farther than the first row after the header line, if any.
3715 Don't consider the header-line row as "partially visible", even if
3716 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3718 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3720 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3723 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3724 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3726 configure: new option --enable-gcc-warnings (Bug#11207)
3727 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3728 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3729 (ALL_CFLAGS): Use new macros rather than old.
3730 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3731 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3732 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3733 -Wunused-result, -Wunused-variable. This should go away once
3734 the Emacs and Gnulib regex code is merged.
3735 (xmalloc, xrealloc): Now static.
3737 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3739 * dired.c (Fsystem_groups): Remove unused local.
3741 2012-04-17 Glenn Morris <rgm@gnu.org>
3743 * dired.c (Fsystem_users): Doc fix.
3745 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3747 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3748 (syms_of_dired): Add them.
3750 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3752 Fix minor alloc.c problems found by static checking.
3753 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3754 New extern decls, to avoid calling undeclared functions.
3755 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3756 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3757 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3758 (NEED_MEM_INSERT): New macro.
3759 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3760 Remove one incorrect comment and fix another.
3762 Fix minor ralloc.c problems found by static checking.
3763 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3764 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3765 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3766 (r_alloc_sbrk): Now static.
3768 Improve ralloc.c interface checking.
3769 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3770 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3771 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3772 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3773 [REL_ALLOC]: ... to here, to check interface.
3774 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3775 Remove decls. This fixes an "It stinks!".
3777 * alloc.c (which_symbols): Fix alignment issue / type clash.
3779 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3781 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3782 (struct Lisp_Misc_Any): Likewise.
3783 (struct Lisp_Free): Likewise.
3784 * alloc.c (union aligned_Lisp_Symbol): Define.
3785 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3786 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3787 (union aligned_Lisp_Misc): Define.
3788 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3789 aligned_Lisp_Misc instead of union Lisp_Misc.
3790 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3792 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3794 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3795 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3796 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3797 * s/netbsd.h, s/sol2-6.h:
3798 Remove definition of GC_MARK_STACK, since the default now works.
3799 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3800 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3801 no longer the default.
3802 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3804 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3806 * lread.c (lisp_file_lexically_bound_p):
3807 Fix hang at ";-*-\n" (bug#11238).
3809 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3811 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3812 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3814 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3816 * nsterm.m (constrainFrameRect): Always constrain when there is only
3817 one screen (Bug#10962).
3819 2012-04-13 Ken Brown <kbrown@cornell.edu>
3821 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3823 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3825 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3827 2012-04-11 Daniel Colascione <dancol@dancol.org>
3829 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3830 against is gone. It's better to use vfork now so that when Cygwin
3831 gains a new, working vfork, we use it automatically (bug#10398).
3833 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3835 * window.c (save_window_save): Obey window-point-insertion-type.
3837 2012-04-11 Glenn Morris <rgm@gnu.org>
3839 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3841 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3843 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3845 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3847 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3848 (force_quit_count): New var.
3849 (handle_interrupt): Use it.
3851 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3853 * w32.c (w32_delayed_load): Record the full path of the library
3854 being loaded (bug#10424).
3856 2012-04-09 Glenn Morris <rgm@gnu.org>
3858 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3859 not just in the obarray, before snarfing them. (Bug#11036)
3861 * Makefile.in ($(leimdir)/leim-list.el):
3862 Pass EMACS rather than BUILT_EMACS.
3864 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3866 * process.c (make_process):
3867 * process.h: Add integer `gnutls_handshakes_tried' member to
3870 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3871 Add convenience `GNUTLS_LOG2i' macro.
3873 * gnutls.c (gnutls_log_function2i): Convenience log function.
3874 (emacs_gnutls_read): Use new log functions,
3875 `gnutls_handshakes_tried' process member, and
3876 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3877 attempts per process (connection).
3879 2012-04-09 Chong Yidong <cyd@gnu.org>
3881 * eval.c (Fuser_variable_p, user_variable_p_eh)
3882 (lisp_indirect_variable): Functions deleted.
3883 (Fdefvar): Caller changed.
3885 * callint.c (Finteractive, Fcall_interactively):
3886 * minibuf.c (Fread_variable): Callers changed.
3888 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3890 * xdisp.c (set_cursor_from_row): If the display string appears in
3891 the buffer at position that is closer to point than the position
3892 after the display string, display the cursor on the first glyph of
3893 the display string. Fixes cursor display when a 'display' text
3894 property immediately follows invisible text. (Bug#11094)
3896 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3898 composite.c: use 'double' consistently
3899 * composite.c (get_composition_id): Use 'double' consistently
3900 instead of converting 'float' to 'double' and vice versa; this is
3901 easier to understand and avoids a GCC warning.
3903 2012-04-09 Glenn Morris <rgm@gnu.org>
3905 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3906 preparation for dumping it with emacs. (Bug#4789)
3907 (leimdir): New variable.
3908 ($(leimdir)/leim-list.el): New rule.
3909 (emacs$(EXEEXT)): Depend on leim-list.el.
3911 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3912 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3913 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3915 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3917 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3920 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3922 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3923 Remove unused local variable.
3925 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3927 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3928 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3929 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3930 objects, as mark_maybe_pointer will catch them otherwise.
3931 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3932 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3934 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3936 Fix typo that broke non-Windows builds.
3937 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3939 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3941 Support building on MS-Windows with libxml2.
3943 * makefile.w32-in (OBJ2): Add xml.$(O).
3944 (GLOBAL_SOURCES): Add xml.c.
3945 ($(BLD)/xml.$(O)): New dependency list.
3947 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3948 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3949 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3950 [!WINDOWSNT]: New macros.
3951 (init_libxml2_functions, libxml2_loaded_p): New functions.
3952 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3953 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3954 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3955 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3957 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3958 Call init_libxml2_functions before calling libxml2 functions.
3959 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3961 * emacs.c: Don't include libxml/parser.h.
3962 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3963 xmlCleanupParser directly.
3965 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3967 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3969 * indent.c (Fvertical_motion): If there is a display string at
3970 point, use it.vpos to compute how many lines to backtrack after
3971 move_it_to point. (Bug#11133)
3973 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3975 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3976 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3977 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3978 macros related to unification of CJK characters. For the details,
3979 see the discussion following the message here:
3980 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3982 2012-04-04 Chong Yidong <cyd@gnu.org>
3984 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3986 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3988 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3989 instead of alloca. (Bug#11138)
3991 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3993 * w32menu.c (is_simple_dialog): Properly check lisp types.
3996 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3998 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3999 position we get to after a call to move_it_to fails the
4000 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4001 only if we wind up in a string from display property. (Bug#11063)
4003 * window.c (Fdelete_other_windows_internal): Invalidate the row
4004 and column information about mouse highlight, so that redisplay
4005 restores it after reallocating the glyph matrices. (Bug#7464)
4007 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4008 string comes from a `display' text property, use the buffer
4009 position of that property as if we actually saw that position in
4011 (move_it_by_lines): Remove the assertion that
4012 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4013 violated when there's a before-string at the beginning of a line.
4016 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4018 * xdisp.c (append_space_for_newline): If the default face was
4019 remapped, use the remapped face for the appended newline.
4020 (extend_face_to_end_of_line): Use the remapped default face for
4021 extending the face to the end of the line.
4022 (display_line): Call extend_face_to_end_of_line when the default
4023 face was remapped. (Bug#11068)
4025 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4027 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4029 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4031 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4033 2012-03-27 Glenn Morris <rgm@gnu.org>
4035 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4038 2012-03-26 Kenichi Handa <handa@m17n.org>
4040 * dispextern.h (struct glyph): Fix previous change. Change the
4041 bit length of glyphless.ch to 25 (Bug#11082).
4043 2012-03-26 Chong Yidong <cyd@gnu.org>
4045 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4046 (command_loop_1): Use it; inhibit selection update for
4047 handle-select-window too (Bug#8996).
4049 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4051 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4053 2012-03-25 Kenichi Handa <handa@m17n.org>
4055 * dispextern.h (struct glyph): Change the bit length of
4056 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4058 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4060 * s/ms-w32.h (tzname): Include time.h before redirecting to
4061 _tzname. Fixes the MSVC build. (Bug#9960)
4063 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4065 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4068 * xterm.c (XTread_socket): Only modify handling_signal if
4069 !SYNC_INPUT. (Bug#11080)
4071 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4073 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4074 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4075 when fetching a multibyte character consumes more bytes than
4076 CHAR_BYTES returns, due to unification of CJK characters in
4077 string_char. (Bug#11073)
4079 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4081 * process.c (wait_reading_process_output): Handle pty disconnect
4082 by refraining from sending oneself a SIGCHLD (bug#10933).
4084 2012-03-22 Chong Yidong <cyd@gnu.org>
4086 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4088 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4089 Mark string as coming from a prefix property.
4090 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4091 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4093 2012-03-21 Chong Yidong <cyd@gnu.org>
4095 * xfaces.c (Vface_remapping_alist): Doc fix.
4097 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4099 * w32proc.c (Fw32_set_console_codepage)
4100 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4103 2012-03-20 Chong Yidong <cyd@gnu.org>
4105 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4106 to reflect default non-nil value of redisplay-dont-pause.
4108 2012-03-19 Kenichi Handa <handa@m17n.org>
4110 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4111 it fit in a valid range (Bug#11003).
4113 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4115 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4116 that is not from display property, accept the row as a "cursor
4117 row" if one of the string's character has a non-nil `cursor'
4118 property. Fixes cursor positioning when there are newlines in
4119 overlay strings, e.g. in icomplete.el. (Bug#11035)
4121 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4123 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4125 2012-03-12 Chong Yidong <cyd@gnu.org>
4127 * eval.c (inhibit_lisp_code): Rename from
4128 inhibit_window_configuration_change_hook; move from window.c.
4130 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4131 * window.c (run_window_configuration_change_hook)
4132 (syms_of_window): Callers changed.
4134 2012-03-11 Chong Yidong <cyd@gnu.org>
4136 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4138 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4140 2012-03-10 Chong Yidong <cyd@gnu.org>
4142 * frame.c (other_visible_frames): Don't assume the selected frame
4143 is visible (Bug#10955).
4145 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4147 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4149 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4151 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4152 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4155 2012-03-03 Glenn Morris <rgm@gnu.org>
4157 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4159 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4161 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4162 position past the first glyph_row that ends at ZV. (Bug#10902)
4163 (redisplay_window, next_element_from_string): Fix typos in
4165 (redisplay_window): Pass to move_it_vertically the margin in
4166 pixels, not in screen lines.
4168 2012-03-02 Glenn Morris <rgm@gnu.org>
4170 * buffer.c (buffer-list-update-hook): Doc fix.
4172 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4174 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4175 push_it before setting up the iterator for the first overlay
4176 string, even if we have an empty string loaded.
4177 (next_overlay_string): If there's an empty string on the iterator
4178 stack, pop the stack. (Bug#10903)
4180 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4182 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4183 Suggested by Stefan Monnier in
4184 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4185 * alloc.c (widen_to_Lisp_Object): New static function.
4186 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4187 and widening them to Lisp_Objects. This would work even if
4188 USE_LSB_TAG is defined and wide integers are used, which might
4189 happen in a future version of Emacs.
4191 2012-02-25 Chong Yidong <cyd@gnu.org>
4193 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4196 * xselect.c (Fx_selection_exists_p): Doc fix.
4197 (x_clipboard_manager_save_all): Print an informative message
4198 before saving to clipboard manager.
4200 2012-02-24 Chong Yidong <cyd@gnu.org>
4202 * keyboard.c (process_special_events): Handle all X selection
4203 requests in kbd_buffer, not just the next one (Bug#8869).
4205 2012-02-23 Chong Yidong <cyd@gnu.org>
4207 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4208 call when setting menu-bar-lines and tool-bar-lines parameters.
4209 (unwind_create_frame_1): New helper function.
4211 * window.c (inhibit_window_configuration_change_hook): New var.
4212 (run_window_configuration_change_hook): Obey it.
4213 (syms_of_window): Initialize it.
4215 2012-02-22 Chong Yidong <cyd@gnu.org>
4217 * xterm.c (x_draw_image_relief): Add missing type check for
4218 Vtool_bar_button_margin (Bug#10743).
4220 2012-02-21 Chong Yidong <cyd@gnu.org>
4222 * fileio.c (Vfile_name_handler_alist): Doc fix.
4224 * buffer.c (Fget_file_buffer): Protect against invalid file
4225 handler return value.
4227 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4229 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4230 when computing $valmask.
4232 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4233 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4234 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4235 It's useless in that case, and it can cause problems on hosts
4236 that allocate halves of EMACS_INT values separately.
4237 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4238 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4239 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4240 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4241 it avoids undefined behavior on hosts where shifting right by more
4242 than the word width has undefined behavior.
4244 2012-02-19 Chong Yidong <cyd@gnu.org>
4246 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4247 (Funhandled_file_name_directory, Ffile_name_as_directory)
4248 (Fdirectory_file_name, Fexpand_file_name)
4249 (Fsubstitute_in_file_name): Protect against invalid file handler
4250 return values (Bug#10845).
4252 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4254 * .gdbinit (pitx): Fix incorrect references to fields of the
4257 2012-02-17 Chong Yidong <cyd@gnu.org>
4259 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4261 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4263 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4264 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4266 2012-02-15 Chong Yidong <cyd@gnu.org>
4268 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4269 marked as special. Also, starting docstrings with * is obsolete.
4271 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4273 * gnutls.c (emacs_gnutls_write): Fix last change.
4275 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4277 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4280 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4282 * keymap.c (Fsingle_key_description): Handle char ranges.
4284 2012-02-12 Chong Yidong <cyd@gnu.org>
4286 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4287 as that creates a dangerous corner case.
4289 * window.c (Fdelete_window_internal): Invalidate the mouse
4290 highlight (Bug#9904).
4292 2012-02-12 Glenn Morris <rgm@gnu.org>
4294 * xselect.c (Fx_own_selection_internal)
4295 (Fx_get_selection_internal, Fx_disown_selection_internal)
4296 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4297 * nsselect.m (Fx_own_selection_internal)
4298 (Fx_disown_selection_internal, Fx_selection_exists_p)
4299 (Fx_selection_owner_p, Fx_get_selection_internal):
4300 Sync docs and argument specs with the xselect.c versions.
4302 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4304 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4306 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4308 * w32select.c (Fx_selection_exists_p): Sync doc string and
4309 argument list with xselect.c. (Bug#10783)
4311 * w16select.c (Fx_selection_exists_p): Sync doc string and
4312 argument list with xselect.c. (Bug#10783)
4314 2012-02-10 Glenn Morris <rgm@gnu.org>
4316 * fns.c (Fsecure_hash): Doc fix.
4318 2012-02-09 Kenichi Handa <handa@m17n.org>
4320 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4322 2012-02-07 Chong Yidong <cyd@gnu.org>
4324 * buffer.c (Fbuffer_local_variables)
4325 (buffer_lisp_local_variables): Handle unbound vars correctly;
4326 don't let Qunbound leak into Lisp.
4328 2012-02-07 Glenn Morris <rgm@gnu.org>
4330 * image.c (Fimagemagick_types): Doc fix.
4332 * image.c (imagemagick-render-type): Change it from a lisp object
4333 to an integer. Move the doc here from the lisp manual.
4334 Treat all values not equal to 0 the same.
4336 2012-02-06 Chong Yidong <cyd@gnu.org>
4338 * doc.c (store_function_docstring): Avoid applying docstring of
4339 alias to base function (Bug#2603).
4341 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4343 * .gdbinit (pp1, pv1): Remove redundant defines.
4346 2012-02-04 Chong Yidong <cyd@gnu.org>
4348 * nsterm.m: Declare a global (Bug#10694).
4350 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4352 * w32.c (get_emacs_configuration_options):
4353 Include --enable-checking, if specified, in the return value.
4355 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4357 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4358 after rounding frame sizes. (Bug#9723)
4360 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4362 * keyboard.c (adjust_point_for_property): Don't position point
4363 before BEGV. (Bug#10696)
4365 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4367 Handle overflow when computing char display width (Bug#9496).
4368 * character.c (char_width): Return EMACS_INT, not int.
4369 (char_width, c_string_width): Check for overflow when
4370 computing the width; this is possible now that individual
4371 characters can have unbounded width. Problem introduced
4372 by merge from Emacs 23 on 2012-01-19.
4374 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4376 * dbusbind.c (Fdbus_register_method): Mention the return value
4377 :ignore in the docstring.
4379 2012-02-02 Glenn Morris <rgm@gnu.org>
4381 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4383 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4384 Unconditionally set to t. (Bug#10673)
4385 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4386 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4387 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4389 2012-02-02 Kenichi Handa <handa@m17n.org>
4391 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4392 0, do not call append_composite_glyph.
4394 2012-02-02 Kenichi Handa <handa@m17n.org>
4396 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4398 (x_produce_glyphs): If the component of a composition is a null
4399 string, set it->pixel_width to 1 to avoid zero-width glyph.
4401 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4403 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4404 first 2 arguments are identical. This makes inserting large
4405 output from a subprocess an order of magnitude faster on
4406 MS-Windows, where all sbrk'ed memory is always contiguous.
4408 2012-01-31 Glenn Morris <rgm@gnu.org>
4410 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4411 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4412 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4414 2012-01-29 Glenn Morris <rgm@gnu.org>
4416 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4418 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4420 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4422 2012-01-28 Chong Yidong <cyd@gnu.org>
4424 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4426 2012-01-26 Chong Yidong <cyd@gnu.org>
4428 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4430 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4431 repeat counts (Bug#10507).
4433 2012-01-26 Glenn Morris <rgm@gnu.org>
4435 * lread.c (syms_of_lread): Doc fix.
4437 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4439 * coding.c (encode_designation_at_bol): Change return value to
4442 2012-01-25 Chong Yidong <cyd@gnu.org>
4444 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4446 2012-01-21 Chong Yidong <cyd@gnu.org>
4448 * floatfns.c (Fcopysign): Make the second argument non-optional,
4449 since nil is not allowed anyway.
4451 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4453 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4454 (send_process): Likewise.
4456 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4458 * window.c (save_window_save, Fcurrent_window_configuration)
4459 (Vwindow_persistent_parameters): Do not use Qstate.
4460 Rewrite doc-strings.
4462 2012-01-19 Kenichi Handa <handa@m17n.org>
4464 * character.c (char_width): New function.
4465 (Fchar_width, c_string_width, lisp_string_width):
4466 Use char_width (Bug#9496).
4468 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4470 * window.c (Vwindow_persistent_parameters): New variable.
4471 (Fset_window_configuration, save_window_save): Handle persistent
4474 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4476 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4477 thrashing the stack of the thread. (Bug#9087)
4479 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4481 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4483 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4485 * xdisp.c (rows_from_pos_range): Handle the case where the
4486 highlight ends on a newline. (Bug#10464)
4487 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4488 he end column for display of highlight that ends on a newline
4491 2012-01-11 Glenn Morris <rgm@gnu.org>
4493 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4494 from load-path also when installation-directory is nil. (Bug#10208)
4496 2012-01-10 Glenn Morris <rgm@gnu.org>
4498 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4500 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4501 Update template values to be closer to their typical values these days.
4503 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4505 * xdisp.c (rows_from_pos_range): Accept additional argument
4506 DISP_STRING, and accept any glyph in a row whose object is that
4507 string as eligible for mouse highlight. Fixes mouse highlight of
4508 display strings from overlays. (Bug#10464)
4510 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4512 emacs: fix an auto-save permissions race condition (Bug#10400)
4513 * fileio.c (auto_saving_dir_umask): New static var.
4514 (Fmake_directory_internal): Use it.
4515 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4516 creating the directory. The old code temporarily assigns
4517 too-generous permissions to the directory.
4518 (do_auto_save_eh): Clear it.
4519 (Fdo_auto_save): Catch all errors, not just file errors, so
4520 that the var is always cleared.
4522 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4524 * search.c (scan_buffer): Pass character positions to
4525 know_region_cache, not byte positions. (Bug#6540)
4527 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4529 * w32.c (sys_rename): Report EXDEV when rename of a directory
4530 fails because the target is on another logical disk. (Bug#10284)
4532 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4534 * xterm.c (x_embed_request_focus): New function.
4536 * xterm.h: Add prototype.
4538 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4540 2012-01-05 Glenn Morris <rgm@gnu.org>
4542 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4544 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4546 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4547 Load gnutls_transport_set_lowat only if GnuTLS version is below
4549 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4550 GnuTLS versions below 2.11.1.
4552 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4554 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4555 to the doc string advising against its use for altering the way
4556 windows are scrolled.
4558 2011-12-28 Kenichi Handa <handa@m17n.org>
4560 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4561 coding-system ASCII compatible only when it does not produce BOM
4562 on encoding (Bug#10383).
4564 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4566 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4568 (create_and_show_popup_menu): Always use menu_position_func for
4571 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4573 * callint.c (Fcall_interactively): Don't truncate prompt string.
4575 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4577 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4578 property that ends at ZV, so that the bidi iteration could be
4579 resumed from there (after widening). (Bug#10360)
4581 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4583 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4585 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4587 * nsterm.m (x_free_frame_resources):
4588 Release f->output_data.ns->miniimage.
4589 (ns_index_color): Fix indentation. Do not retain
4590 color_table->colors[i].
4592 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4595 * nsfns.m (x_set_background_color): Assign return value from
4596 ns_index_color to face-background instead of NSColor*.
4597 (ns_implicitly_set_icon_type): Fix indentation.
4598 Change assignment in for loop to comparison.
4600 * emacs.c (ns_pool): New variable.
4601 (main): Assign ns_pool.
4602 (Fkill_emacs): Call ns_release_autorelease_pool.
4604 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4605 autorelease fdesc, release fdAttrs and tdict.
4606 (ns_get_covering_families): Release charset.
4607 (ns_findfonts): Release NSFontDescriptor created with new.
4608 (ns_uni_to_glyphs): Fix indentation.
4609 (setString): Release attrStr before assigning new value.
4611 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4613 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4615 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4616 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4618 2011-12-18 David Reitter <reitter@cmu.edu>
4620 * nsterm.m (ns_term_init): Subscribe for notifications
4621 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4622 to method trackingNotification in EmacsMenu.
4624 * nsmenu.m (trackingMenu): New variable.
4625 (trackingNotification): New method (from Aquamacs).
4626 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4627 from Aquamacs (Bug#7030).
4629 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4631 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4632 (symbol_to_nsstring): Fix indentation.
4633 (ns_symbol_to_pb): New function.
4634 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4635 (Fns_rotate_cut_buffers_internal): Remove.
4636 (Fns_store_selection_internal): Rename from
4637 Fns_store_cut_buffer_internal.
4638 (ns_get_foreign_selection, Fx_own_selection_internal)
4639 (Fx_disown_selection_internal, Fx_selection_exists_p)
4640 (Fns_get_selection_internal, Fns_store_selection_internal):
4641 Use ns_symbol_to_pb and check if return value is nil.
4642 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4643 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4644 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4645 renamed to Sns_store_selection_internal.
4646 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4647 and remove this function.
4648 (ns_handle_selection_clear): Remove, never used.
4649 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4652 2011-12-17 Ken Brown <kbrown@cornell.edu>
4654 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4655 GID is unknown (Bug#10257).
4657 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4659 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4660 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4661 which caused a build failure on GNU/Linux IA-64. This problem was
4662 introduced by my 2011-10-07 patch.
4664 2011-12-15 Juri Linkov <juri@jurta.org>
4666 * image.c (imagemagick_error): New function. (Bug#10112)
4667 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4668 Use `imagemagick_error' where ImageMagick functions return
4670 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4673 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4675 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4676 fill background (Bug#8992).
4678 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4680 * window.c (Vwindow_combination_resize)
4681 (Vwindow_combination_limit): Use t instead of non-nil in
4683 (Vrecenter_redisplay): Add first sentence of doc-string on
4685 (Frecenter): Fix doc-string typo.
4687 2011-12-11 Kenichi Handa <handa@m17n.org>
4689 * coding.c (Funencodable_char_position): Pay attention to the
4690 buffer text relocation (Bug#9389).
4692 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4694 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4695 gtk_init (Bug#10100).
4697 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4699 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4700 IT->string is nil. (Bug#10263)
4702 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4704 * nsterm.h (x_free_frame_resources): Declare.
4706 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4707 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4709 * nsterm.h (ns_get_defaults_value): Declare.
4711 * nsterm.m (ns_default): Call ns_get_defaults_value.
4713 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4715 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4718 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4720 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4721 that where the value of an _OBJC_* symbol points to is in the .bss
4722 section (Bug#10240).
4724 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4726 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4727 after the loop to call ccl_driver at least once (Bug#8619).
4729 2011-12-08 Kenichi Handa <handa@m17n.org>
4731 * ftfont.c (get_adstyle_property): Fix previous change
4734 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4736 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4737 dirs from the default value of EMACSLOADPATH (bug#10208).
4739 2011-12-07 Glenn Morris <rgm@gnu.org>
4741 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4742 installation and source directories as well. (Bug#10208)
4744 2011-12-06 Chong Yidong <cyd@gnu.org>
4746 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4748 2011-12-06 Glenn Morris <rgm@gnu.org>
4750 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4751 as an error, not just -1. (Bug#10217)
4753 2011-12-05 Chong Yidong <cyd@gnu.org>
4755 * keyboard.c (process_special_events): New function.
4756 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4758 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4760 * coding.c (encode_designation_at_bol): Don't use uninitialized
4761 local variable (Bug#9318).
4763 2011-12-05 Kenichi Handa <handa@m17n.org>
4765 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4766 return Qnil (Bug#8046, Bug#10193).
4768 2011-12-05 Kenichi Handa <handa@m17n.org>
4770 * coding.c (encode_designation_at_bol): New args charbuf_end and
4771 dst. Return the number of produced bytes. Callers changed.
4772 (coding_set_source): Return how many bytes coding->source was
4774 (coding_set_destination): Return how many bytes
4775 coding->destination was relocated.
4776 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4777 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4779 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4781 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4782 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4785 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4787 The following changes are to fix Bug#9318.
4789 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4790 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4791 (encode_coding_iso_2022, encode_coding_sjis)
4792 (encode_coding_big5, encode_coding_charset): Use the above macros.
4794 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4796 * lisp.h (process_quit_flag): Fix external declaration.
4798 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4800 Don't macro-inline non-performance-critical code.
4801 * eval.c (process_quit_flag): New function.
4802 * lisp.h (QUIT): Use it.
4804 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4806 * nsfns.m (get_geometry_from_preferences): New function.
4807 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4809 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4811 * emacs.c (Qkill_emacs): Define.
4812 (syms_of_emacs): Initialize it.
4813 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4814 Qquit_flag to `kill-emacs' instead.
4815 (quit_throw_to_read_char): Add parameter `from_signal'.
4816 All callers changed. Call Fkill_emacs if requested and safe.
4817 * lisp.h (QUIT): Call Fkill_emacs if requested.
4819 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4821 * widget.c (update_wm_hints): Return if wmshell is null.
4822 (widget_update_wm_size_hints): New function.
4824 * widget.h (widget_update_wm_size_hints): Declare.
4826 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4827 widget_update_wm_size_hints (Bug#10104).
4829 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4831 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4832 before a newline, prepare the bidi iterator for consuming the
4833 newline, and keep the current paragraph direction. (Bug#10183)
4834 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4836 2011-12-02 Juri Linkov <juri@jurta.org>
4838 * search.c (Fword_search_regexp): New Lisp function created from
4839 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4840 (Fword_search_backward, Fword_search_forward)
4841 (Fword_search_backward_lax, Fword_search_forward_lax):
4842 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4843 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4845 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4847 * fileio.c (Finsert_file_contents): Move after-change-function call
4848 to before the "handled:" label, since all "goto handled" appear in
4849 cases where the *-change-functions have already been properly called
4852 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4854 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4855 waiting for input. (Bug#10169)
4857 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4859 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4860 verifies glyph row's hash code--we have just reallocated the
4861 glyphs, so their contents can be complete garbage. (Bug#10164)
4863 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4865 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4867 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4869 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4870 attributes are tested _before_ calling verify_row_hash, to protect
4871 against GCC re-ordering of the tests. (Bug#10164)
4873 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4875 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4877 * xterm.c (handle_one_xevent): Only set async_visible and friends
4878 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4879 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4880 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4882 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4884 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4885 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4886 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4887 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4888 All uses changed to use GCPRO1 etc.
4889 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4890 Revert to old implementation (i.e., before 2011-03-11).
4892 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4894 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4895 of scroll runs so as to avoid assigning disabled bogus rows and
4896 unnecessary graphics copy operations.
4898 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4900 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4901 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4902 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4903 (malloc, free, realloc, calloc): Redirect to e_* only when
4906 * lisp.h (GCTYPEBITS): Move before first use.
4907 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4908 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4909 this macro definition.
4911 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4914 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4916 * gtkutil.c (xg_create_frame_widgets):
4917 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4918 present with Gtk+ 2.0.
4920 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4922 * fileio.c (Finsert_file_contents): Undo previous change; see
4923 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4925 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4927 Rename locals to avoid shadowing.
4928 * fileio.c (Finsert_file_contents):
4929 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4930 * process.c (wait_reading_process_output):
4931 Rename inner 'proc' to 'p' to avoid shadowing.
4932 Indent for consistency with usual Emacs style.
4934 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4936 * xdisp.c (redisplay_window): If cursor row is not fully visible
4937 after recentering, and scroll-conservatively is set to a large
4938 number, scroll window by a few more lines to make the cursor fully
4939 visible and out of scroll-margin. (Bug#10105)
4940 (start_display): Don't move to the next line if the display should
4941 start at a newline that is part of a display vector or an overlay
4944 2011-11-24 Juri Linkov <juri@jurta.org>
4946 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4947 after the `MagickPingImage' call. (Bug#10112)
4949 2011-11-23 Chong Yidong <cyd@gnu.org>
4951 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4953 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4955 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4956 making another buffer current. (Bug#10114)
4958 2011-11-23 Glenn Morris <rgm@gnu.org>
4960 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4962 2011-11-23 Chong Yidong <cyd@gnu.org>
4964 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4965 using it (Bug#5984).
4967 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4969 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4970 and header-lines, as they don't have one computed for them.
4973 * .gdbinit (prow): Make displayed values more self-explaining.
4974 Add row's hash code.
4976 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4978 * process.c (wait_reading_process_output): Fix asynchrounous
4979 GnuTLS socket handling on some versions of the GnuTLS library.
4980 (wait_reading_process_output): Add comment and URL.
4982 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4984 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4986 2011-11-21 Chong Yidong <cyd@gnu.org>
4988 * window.c (Fnext_window, Fprevious_window): Doc fix.
4990 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4992 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4994 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4996 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4998 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5000 * window.c (Fset_window_combination_limit): Rename argument
5002 (Vwindow_combination_limit): Remove "status" from doc-string.
5004 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5006 * m/ibms390.h: Remove.
5007 * m/ibms390x.h: Don't include "ibms390.h".
5009 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5011 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5012 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5014 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5016 * casetab.c (Fset_case_table):
5017 * charset.c (Fcharset_after): Fix typos.
5019 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5021 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5022 Otherwise, valgrind does not work on some platforms.
5023 Problem reported by Andreas Schwab in
5024 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5025 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5026 is set, removing the need for VIRT_ADDRESS_VARIES.
5027 (PURE_P): Use a more-efficient implementation that needs just one
5028 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5029 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5030 to 4 (xorl, subq, cmpq, setbe).
5031 * alloc.c (pure): Always extern now, since that's the
5032 VIRT_ADDR_VARIES behavior.
5033 (PURE_POINTER_P): Use a single comparison, not two, for
5034 consistency with the new puresize.h.
5035 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5036 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5037 Remove VIRT_ADDR_VARIES no longer needed.
5039 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5041 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5042 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5043 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5044 behave as if the cursor position were at the window margin.
5046 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5047 and the cursor position is out of bounds, behave as if the cursor
5048 position were at the window margin. (Bug#10075)
5050 2011-11-18 Chong Yidong <cyd@gnu.org>
5052 * window.c (Fwindow_combination_limit): Make first argument
5053 non-optional, since it is meaningless for live windows like the
5056 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5058 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5060 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5062 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5063 (graft_intervals_into_buffer): Simplify.
5065 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5067 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5068 hash values of the two rows.
5069 (copy_row_except_pointers): Preserve the used[] arrays and the
5070 hash values of the two rows. (Bug#10035)
5071 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5073 * xdisp.c (row_hash): New function, body extracted from
5074 compute_line_metrics.
5075 (compute_line_metrics): Call row_hash, instead of computing the
5078 * dispnew.c (verify_row_hash): Call row_hash for computing the
5079 hash code of a row, instead of duplicating code from xdisp.c.
5081 * dispextern.h (row_hash): Add prototype.
5083 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5085 * frame.c (delete_frame): Don't delete the terminal when the last
5086 X frame is closed if emacs is built with GTK toolkit.
5088 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5090 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5092 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5094 * window.c (Vwindow_splits): Rename to
5095 Vwindow_combination_resize. Suggested by Juri Linkov.
5096 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5099 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5101 * nsfns.m (Fns_font_name):
5102 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5104 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5106 * window.h (window): Rename slot "nest" to "combination_limit".
5107 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5108 (Fset_window_nest): Rename to Fset_window_combination_limit.
5109 (Vwindow_nest): Rename to Vwindow_combination_limit.
5110 (recombine_windows, make_parent_window, make_window)
5111 (Fsplit_window_internal, saved_window)
5112 (Fset_window_configuration, save_window_save): Rename all
5113 occurrences of window_nest to window_combination_limit.
5115 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5117 * image.c (imagemagick_load_image): Fix typo.
5119 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5121 * xdisp.c (display_line): Move the call to
5122 highlight_trailing_whitespace before the call to
5123 compute_line_metrics, since the latter needs to see the final
5124 faces of all the glyphs to compute ROW's hash value.
5125 Fixes assertion violations in row_equal_p. (Bug#10035)
5127 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5129 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5130 just return (bug#10044).
5132 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5134 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5135 with user-defined heap size. Bump the default size of the temacs
5136 heap to 27MB, to avoid memory warning when running temacs.
5137 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5139 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5140 current_matrix and desired_matrix. (Bug#9990)
5141 (verify_row_hash) [XASSERTS]: New function.
5142 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5143 that the hash value of glyph rows is correct.
5145 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5147 * window.h (window): Remove splits slot.
5148 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5149 (Fdelete_other_windows_internal, make_parent_window)
5150 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5151 (Fset_window_configuration, save_window_save): Don't deal with
5152 split status of windows.
5153 (saved_window): Remove splits slot.
5154 (Vwindow_splits): Rewrite doc-string.
5156 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5158 * xfns.c (unwind_create_frame):
5159 * nsfns.m (unwind_create_frame):
5160 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5161 Vframe_list (Bug#9999).
5163 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5165 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5167 2011-11-11 Kenichi Handa <handa@m17n.org>
5169 * callproc.c (Fcall_process): Set the member dst_multibyte of
5172 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5174 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5175 avoid a crash (bug#9496).
5177 2011-11-09 Chong Yidong <cyd@gnu.org>
5179 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5180 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5182 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5184 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5186 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5188 Avoid some portability problems by eschewing 'extern inline' functions.
5189 The trivial performance wins aren't worth the portability hassles; see
5190 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5192 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5193 (window_box_width, window_box_left, window_box_left_offset)
5194 (window_box_right, window_box_right_offset): Undo previous change,
5195 by removing the "extern"s.
5196 * intervals.c (adjust_intervals_for_insertion)
5197 (adjust_intervals_for_deletion): Undo previous change,
5198 making these static again.
5199 (offset_intervals, temp_set_point_both, temp_set_point)
5200 (copy_intervals_to_string): No longer inline.
5201 * xdisp.c (window_text_bottom_y, window_box_width)
5202 (window_box_height, window_box_left_offset)
5203 (window_box_right_offset, window_box_left, window_box_right)
5204 (window_box): No longer inline.
5206 2011-11-08 Chong Yidong <cyd@gnu.org>
5208 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5209 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5210 Signal an error if not a live window.
5211 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5212 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5214 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5216 * lisp.h (syms_of_abbrev): Remove declaration.
5217 Reported by CHENG Gao <chenggao@royau.me>.
5219 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5221 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5222 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5223 of temacs in GUI mode.
5225 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5227 * window.h: Declare delete_all_child_windows instead of
5228 delete_all_subwindows.
5229 * window.c (Fwindow_nest, Fset_window_nest)
5230 (Fset_window_new_total, Fset_window_new_normal)
5231 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5232 (delete_all_subwindows): Rename to delete_all_child_windows.
5233 (Fdelete_other_windows_internal, Fset_window_configuration):
5234 Call delete_all_child_windows instead of delete_all_subwindows.
5235 * frame.c (delete_frame): Call delete_all_child_windows instead
5236 of delete_all_subwindows.
5238 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5240 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5241 This is also needed for porting to any host where GC_MARK_STACK is
5242 not GC_MAKE_GCPROS_NOOPS.
5243 (which_symbols): Use it.
5245 2011-11-07 Kenichi Handa <handa@m17n.org>
5247 * coding.c (coding_set_destination): Check coding->src_pos only
5248 when coding->src_object is a buffer (bug#9910).
5250 * process.c (send_process): Set the member src_multibyte of coding
5251 to 0 (bug#9911) when sending a unibyte text.
5253 * callproc.c (Fcall_process): Set the member src_multibyte of
5254 process_coding to 0 (bug#9912).
5256 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5258 * xmenu.c (cleanup_widget_value_tree): New function.
5259 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5260 calling free_menubar_widget_value_tree directly (Bug#9830).
5262 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5264 Fix some portability problems with 'inline'.
5265 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5266 (window_box_width, window_box_left, window_box_left_offset)
5267 (window_box_right, window_box_right_offset): Declare extern.
5268 Otherwise, these inline functions do not conform to C99 and
5269 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5270 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5271 * intervals.c (adjust_intervals_for_insertion)
5272 (adjust_intervals_for_deletion): Now extern, because otherwise the
5273 extern inline functions 'offset_intervals' couldn't refer to it.
5274 (static_offset_intervals): Remove.
5275 (offset_intervals): Rewrite using the old contents of
5276 static_offset_intervals. The old version didn't conform to C99
5277 because an extern inline function contained a reference to an
5278 identifier with static linkage.
5280 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5282 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5285 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5287 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5288 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5289 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5290 return Qleft_to_right.
5292 2011-11-06 Chong Yidong <cyd@gnu.org>
5294 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5295 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5296 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5297 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5298 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5299 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5300 (Fwindow_vscroll): Doc fix.
5301 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5302 argument, since it makes no sense to pass a live window and for
5303 consistency with window-child.
5305 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5307 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5310 2011-11-05 Jason Rumney <jasonr@gnu.org>
5312 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5313 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5315 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5316 bitwise arithmetic preventing use of unicode-sip and non-truetype
5319 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5321 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5324 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5325 initialization code to keep similarity to xfns.c after changes
5328 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5330 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5331 (unwind_create_frame): New function (Bug#9943).
5332 (Fx_create_frame): Restructure code to be more similar to the one in
5333 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5334 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5335 Move terminal->reference_count++ just before making the frame official
5338 * nsterm.m (x_free_frame_resources): New function.
5339 (x_destroy_window): Move code to x_free_frame_resources.
5341 * xfns.c (unwind_create_frame): Fix comment.
5342 (Fx_create_frame, x_create_tip_frame):
5343 Move terminal->reference_count++ just before making the frame
5344 official. Move initialization of image_cache_refcount and
5345 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5347 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5349 Support MSVC build with newer versions of Visual Studio.
5350 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5351 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5354 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5355 which are not supported by MSVC.
5356 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5357 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5359 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5361 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5363 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5365 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5367 Support MSVC build with newer versions of Visual Studio.
5368 * w32.c: Don't include w32api.h for MSVC.
5369 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5371 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5372 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5373 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5374 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5376 (alloca) [_MSC_VER]: Define to _alloca.
5378 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5380 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5382 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5384 * xdisp.c (note_mouse_highlight): If either of
5385 previous/next-single-property-change returns nil, treat that as
5386 the beginning or the end of the buffer. (Bug#9955)
5388 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5390 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5391 label is not null (Bug#9951).
5392 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5395 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5397 * window.c (Fwindow_body_size): Mention in the doc string that the
5398 return value is in frame's canonical units. (Bug#9949)
5400 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5402 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5404 * w32fns.c (unwind_create_frame): If needed, free the glyph
5405 matrices of the partially constructed frame. (Bug#9943)
5406 * xfns.c (unwind_create_frame): Likewise.
5408 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5410 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5411 Don't stop backward scan on the continuation glyph, even though
5412 its CHARPOS is positive.
5413 (mouse_face_from_buffer_pos, note_mouse_highlight):
5414 Rename cover_string to disp_string.
5416 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5418 * window.c (temp_output_buffer_show): Don't use
5419 Vtemp_buffer_show_specifiers.
5420 (Vtemp_buffer_show_specifiers): Remove unused variable.
5422 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5424 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5425 past the beginning of the current glyph matrix.
5427 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5429 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5430 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5431 HAVE_GTK3 (Bug#9869).
5433 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5434 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5436 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5438 * xterm.c: Declare x_handle_net_wm_state to return int.
5439 (handle_one_xevent): Check if we are iconified but don't have
5440 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5441 (get_current_wm_state): Return non-zero if not hidden,
5442 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5443 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5444 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5445 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5447 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5449 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5450 so that this new function doesn't get optimized away by a
5451 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5453 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5455 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5457 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5459 Fix the `xbytecode' command.
5460 * .gdbinit (xprintbytestr): New command.
5461 (xwhichsymbols): Rename from `which'; all callers changed.
5462 (xbytecode): Print the byte-code string as well.
5464 2011-10-29 Kim Storm <storm@cua.dk>
5466 * alloc.c (which_symbols): New function.
5468 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5470 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5473 2011-10-29 Glenn Morris <rgm@gnu.org>
5475 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5476 Not clear what it was for, and it causes various bugs. (Bug#9839)
5478 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5480 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5481 possible random value that matches one of those tested as
5482 condition to clear the mouse face.
5484 2011-10-28 Chong Yidong <cyd@gnu.org>
5486 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5488 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5490 * window.c (make_window): Initialize phys_cursor_on_p.
5492 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5494 * lisp.h (struct Lisp_Symbol): Update comments.
5496 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5498 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5500 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5502 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5503 <oslsachem@gmail.com> for helping to debug this.
5505 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5506 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5507 (g_b_init_get_glyph_outline_w): New static variables.
5508 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5509 (GetGlyphOutlineW_Proc): New typedefs.
5510 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5511 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5513 (w32font_open_internal, compute_metrics):
5514 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5515 instead of calling the "wide" APIs directly.
5517 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5519 * w32.h (syms_of_w32font): Add prototype.
5521 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5523 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5524 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5525 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5526 (Fmove_to_window_line): Doc fix.
5528 2011-10-27 Chong Yidong <cyd@gnu.org>
5530 * process.c (make_process): Set gnutls_state to NULL.
5532 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5533 non-NULL, regardless of GNUTLS_INITSTAGE.
5534 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5535 an error. Set process slots as soon as we allocate them.
5537 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5539 2011-10-27 Chong Yidong <cyd@gnu.org>
5541 * gnutls.c (emacs_gnutls_deinit): New function.
5542 Deallocate credentials structures as well as calling gnutls_deinit.
5543 (Fgnutls_deinit, Fgnutls_boot): Use it.
5545 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5546 (deactivate_process): Call emacs_gnutls_deinit.
5548 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5550 * image.c (x_create_x_image_and_pixmap):
5551 * w32.c (sys_rename, w32_delayed_load):
5552 * w32font.c (fill_in_logfont):
5553 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5555 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5557 * w32fns.c (w32_default_color_map): New function,
5558 extracted from Fw32_default_color_map.
5559 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5561 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5563 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5565 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5567 * keyboard.c (test_undefined): New function (bug#9751).
5568 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5570 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5572 * sysdep.c (init_sys_modes): Fix the check for the controlling
5573 terminal (Bug#6649).
5575 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5577 * dispextern.h (struct bidi_it): New member next_en_type.
5579 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5580 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5581 current character, check also for next_en_type being WEAK_EN.
5582 (bidi_resolve_weak): Don't enter the expensive loop if the current
5583 position is before next_en_pos. Record the bidi type of the first
5584 non-ET, non-BN character we find, in addition to its position.
5585 (bidi_level_of_next_char): Invalidate next_en_type when
5586 next_en_pos is over-stepped.
5588 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5590 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5591 * editfns.c: Rewrite current-time-zone so that it invokes
5592 the equivalent of (format-time-string "%Z") to get the time zone name.
5593 This fixes a bug when the time zone name contains characters that
5594 need converting from the system time locale to Emacs internal format.
5595 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5596 that patch fixed format-time-string to do the conversion, but
5597 I forgot to fix current-time-zone.
5598 (format_time_string): New function, containing most of
5599 what Fformat_time_string used to contain.
5600 (Fformat_time_string): Rewrite in terms of format_time_string.
5601 This doesn't change this function's behavior.
5602 (current-time-zone): Rewrite to use format_time_string.
5603 This fixes the bug reported by Michael Schierl in
5604 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5605 Jason Rumney's 2007-06-07 change worked around this bug, but
5607 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5609 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5611 * xdisp.c (start_display): If the character at POS is displayed
5612 via a display vector, reset IT->current.dpvec_index to zero.
5613 (try_window_reusing_current_matrix): If a line ends in a display
5614 vector or the next line starts in a display vector, continue
5615 redrawing the window even though the character position of
5616 start_row was reached.
5619 2011-10-18 Chong Yidong <cyd@gnu.org>
5621 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5622 with nobreak-char-display too.
5624 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5626 Fix part 3 of bug#9771.
5627 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5628 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5629 non-neutral characters if the current character is a paragraph
5630 separator (a.k.a. Newline). This avoids running the same
5631 expensive loop twice, once when we consume the preceding newline
5632 and the other time when the line actually needs to be displayed.
5633 Avoid the loop when we see neutrals on the base embedding level
5634 following a character whose directionality is the same as the
5635 paragraph's. This avoids running the expensive loop when a line
5636 ends in a long sequence of neutrals, like control characters.
5637 Add assertion against STRONG_AL type. Slightly rearrange code
5638 that determines the type of a neutral given the first non-neutral
5640 (bidi_level_of_next_char): Set next_en_pos to zero when
5641 invalidating its info.
5643 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5645 * xdisp.c (push_display_prop): Determine whether to record string
5646 or buffer position by IT->string, not by IT->method. Allow
5647 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5648 (move_it_vertically_backward): Don't look for character position
5649 immediately after the newline when in a continuation line.
5652 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5654 * window.c (coordinates_in_window): Rewrite and delabelize
5655 vertical border check. (Bug#5357) (Bug#9618)
5657 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5659 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5660 errors in XSetWindowBorder (bug#9310).
5662 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5664 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5665 avoid crash when xmalloc overrun checking is enabled.
5667 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5669 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5670 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5671 cursor motion with <left> and <right> arrow keys.
5673 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5674 some callers set that themselves.
5676 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5678 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5679 display string and the previous row comes from the same string and
5680 is empty. (Bug#9739) (Bug#9738)
5682 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5684 * doc.c (get_doc_string): Encode file name (bug#9735).
5686 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5688 * bidi.c (bidi_level_of_next_char):
5689 * xdisp.c (get_visually_first_element): Remove old incorrect
5690 comments regarding the Unicode Line Separator character.
5692 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5694 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5696 * alloc.c (Fgc_status): Do not access beyond zombies array
5697 boundary if nzombies > MAX_ZOMBIES.
5698 * alloc.c (dump_zombies): Add missing format specifier.
5700 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5702 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5703 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5705 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5706 Some packages use them to denote characters with modifiers.
5708 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5710 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5711 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5712 matching a pp-number. Rename parameter var to var1.
5714 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5716 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5718 2011-10-08 Glenn Morris <rgm@gnu.org>
5720 * callint.c (Fcall_interactively): Give a more explicit error for the
5721 'c' case with a non-character input. (Bug#8479)
5723 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5725 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5727 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5728 lines that are hscrolled on the left.
5730 * dispnew.c (buffer_posn_from_coords): Account for a possible
5731 presence of header-line. (Bug#4426)
5733 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5735 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5736 Don't advertise functionality which we discourage or doesn't work.
5738 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5740 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5741 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5742 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5743 this makes Emacs dump core during garbage collection on rare
5744 occasions. sizeof is obviously inferior to offsetof here, so
5745 stick with offsetof.
5746 (GC_POINTER_ALIGNMENT): New macro.
5747 (mark_memory): Omit 3rd (offset) arg; caller changed.
5748 Don't assume EMACS_INT alignment is the same as pointer alignment.
5750 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5752 * keyboard.c (read_key_sequence_remapped): New var.
5753 (read_key_sequence): Compute remapping in the right buffer.
5754 (command_loop_1): Use read_key_sequence's remapping directly.
5756 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5758 * dired.c (file_name_completion): Don't expand file name.
5759 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5760 before checking file name handler.
5762 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5763 they've been requested explicitly (bug#9591).
5765 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5767 * keymap.c (Fsingle_key_description): Use make_specified_string
5768 instead of build_string to build string from push_key_description.
5771 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5773 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5774 This fixes a Y2038 bug on 64-bit hosts.
5775 * buffer.c (reset_buffer):
5776 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5777 (Fclear_buffer_auto_save_failure):
5778 Use 0, not -1, to represent an unset failure time, since time_t
5779 might not be signed.
5781 Remove dependency on glibc malloc internals.
5782 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5783 Move back here from lisp.h, but with their new implementations.
5784 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5785 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5786 * charset.c (charset_table_init): New static var.
5787 (syms_of_charset): Use it instead of xmalloc. This removes a
5788 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5789 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5790 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5791 Move back to alloc.c.
5792 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5793 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5795 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5797 * nsterm.m (windowDidResize): Call x_set_window_size only when
5798 ns_in_resize is true. Otherwise set pixelwidth/height and
5799 call change_frame_size (Bug#9628).
5801 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5803 Port --enable-checking=all to Fedora 14 x86-64.
5804 * charset.c (syms_of_charset): Also account for glibc malloc's
5805 internal overhead when calculating the initial malloc maximum.
5807 Port --enable-checking=all to Fedora 14 x86.
5808 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5810 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5811 (overrun_check_realloc, overrun_check_free):
5812 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5813 That way, xmalloc returns a properly-aligned pointer even if
5814 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5815 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5816 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5817 into account when calculating the initial malloc maximum.
5818 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5819 Move here from alloc.c, so that charset.c can use it too.
5820 Properly align; the old code wasn't right for common 32-bit hosts
5821 when configured with --enable-checking=all.
5822 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5823 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5825 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5827 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5830 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5832 * xdisp.c (compute_display_string_end): If there's no display
5833 string at CHARPOS, return -1.
5835 * bidi.c (bidi_fetch_char): When compute_display_string_end
5836 returns a negative value, treat the character as a normal
5837 character not covered by a display string. (Bug#9624)
5839 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5841 * lread.c (Fread_from_string): Fix typo in docstring.
5843 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5845 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5846 newline, reseat the iterator instead of bidi-iterating there one
5847 character at a time. (Bug#9610)
5848 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5849 TO_CHARPOS if the bidi iterator is at base embedding level.
5851 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5853 * lread.c (readevalloop): Use correct code for NBSP.
5854 (read1): Likewise. (Bug#9608)
5856 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5858 * dbusbind.c (Fdbus_register_signal): When service is not
5859 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5861 2011-09-25 Glenn Morris <rgm@gnu.org>
5863 * buffer.c (truncate-lines): Doc fix.
5865 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5867 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5868 (Fset_window_next_buffers): Doc fix.
5870 2011-09-24 Glenn Morris <rgm@gnu.org>
5872 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5874 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5876 Fix minor problems found by static checking.
5877 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5878 * indent.c (Fvertical_motion): Fix == vs = typo.
5880 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5882 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5883 Default value is now t. Doc fix.
5885 * indent.c (Fvertical_motion): Compute and apply the overshoot
5886 logic when moving up, not only when moving down. Fix the
5887 confusing name and values of the it_overshoot_expected variable;
5888 logic changes accordingly. (Bug#9254) (Bug#9549)
5890 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5891 CHARPOS is covered by a display string which includes newlines.
5892 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5893 is covered by a display string with embedded newlines.
5895 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5897 * dbusbind.c (Fdbus_register_signal): Add match rule to
5898 Vdbus_registered_objects_table. (Bug#9581)
5899 (Fdbus_register_method, Vdbus_registered_objects_table):
5902 2011-09-24 Jim Meyering <meyering@redhat.com>
5904 do not ignore write error for any output size
5905 The previous change was incomplete.
5906 While it makes emacs --batch detect the vast majority of stdout
5907 write failures, errors were still ignored whenever the output size is
5908 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5909 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5910 && echo FAIL: ignored write error
5911 FAIL: ignored write error
5912 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5913 && echo FAIL: ignored write error
5914 FAIL: ignored write error
5915 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5917 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5919 * emacs.c (Fkill_emacs): In noninteractive mode exit
5920 non-successfully if a write error occurred on stdout. (Bug#9574)
5922 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5924 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5927 * dispextern.h (struct it): Update the comment documenting what
5930 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5932 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5933 a display string, extend search for cursor position to end of row.
5934 (find_row_edges): If the row ends in a newline from a display
5935 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5936 Handle the case of a display string with multiple newlines.
5937 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5938 non-empty line. Fixes confusing cursor motion with arrow keys at
5939 the beginning of a line that starts with whitespace.
5941 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5943 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5946 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5948 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5951 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5953 * xdisp.c (display_line): Record maximum and minimum buffer
5954 positions even if no glyphs were produced (e.g., by a zero-width
5955 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5956 buffer positions that will be removed from the glyph row because
5958 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5959 column is beyond frame width: don't subtract 1 "pixel" when
5960 computing width of the stretch.
5961 (reseat_at_next_visible_line_start): Undo the change made on
5962 2011-09-17 that saved paragraph information and restored it after
5963 the call to `reseat'. (Bug#9545)
5965 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5967 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5968 and turn window cursor on if cleared (Bug#9415).
5970 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5972 * search.c (boyer_moore): Take unibyte characters from pattern
5973 literally. (Bug#9458)
5975 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5977 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5979 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5981 Fix minor problem found by static checking.
5982 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5983 initialized, to pacify gcc -Wuninitialized.
5985 * fileio.c: Report proper errno when syscall falls.
5986 (Finsert_file_contents): Save and restore errno,
5987 so that report_file_error outputs the correct diagnostic.
5988 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5990 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5992 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5994 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5996 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5997 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5999 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6001 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6002 about the current paragraph and restore it after the call to reseat.
6004 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6005 (bidi_find_paragraph_start): Search back for paragraph beginning
6006 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6007 (bidi_move_to_visually_next): Only trigger paragraph-related
6008 computations when the last character is a newline or at EOB, not
6009 just any NEUTRAL_B. (Bug#9470)
6011 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6012 truncated lines if point is covered by a display string. (Bug#9524)
6014 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6016 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6017 (cons_to_x_long): New function.
6018 (lisp_data_to_selection_data): Use it. Correct the test for
6019 short-versus-long data; it was negated. Break out of vector
6020 loop, for efficiency, when a long datum is discovered.
6022 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6024 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6026 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6028 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6029 GCC PR/17406) by declaring this function with external scope.
6031 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6033 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6034 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6036 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6038 * editfns.c (Fformat): Correctly handle text properties on "%%".
6040 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6042 * xterm.c (x_draw_composite_glyph_string_foreground):
6043 * w32term.c (x_draw_composite_glyph_string_foreground):
6044 * term.c (encode_terminal_code):
6045 * composite.c (composition_update_it, get_composition_id):
6046 * xdisp.c (get_next_display_element)
6047 (fill_composite_glyph_string): Add comments about special meaning
6048 of TAB characters in a composition.
6050 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6052 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6053 This occurs when processing a multibyte format.
6054 Problem reported by Wolfgang Jenker.
6056 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6058 * xdisp.c (try_cursor_movement): Only check for exact match if
6059 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6061 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6063 Remove unused external symbols.
6064 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6065 * xdisp.c (calc_pixel_width_or_height): Now static.
6066 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6067 * indent.c (check_display_width):
6068 * w32term.c: Fix comment to match code.
6069 * xterm.c, xterm.h (x_catching_errors): Remove.
6071 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6073 * xselect.c: Use signed conversions more consistently (Bug#9498).
6074 (selection_data_to_lisp_data): Assume incoming selection data are
6075 signed integers, not unsigned. This is to be consistent with
6076 outgoing selection data, which was modified to use signed integers
6077 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6078 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6079 expects long, not unsigned long.
6081 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6083 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6084 computation of loop end. Reported by Johan Bockgård
6087 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6089 * frame.c (Fother_visible_frames_p): Function deleted.
6091 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6093 * indent.c (compute_motion): Process display vector front to back
6094 rather than the other way around. (Bug#2496)
6096 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6098 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6100 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6102 * minibuf.c (Fread_from_minibuffer): Doc fix.
6104 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6106 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6107 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6109 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6111 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6112 value for non-existent files.
6114 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6116 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6117 set its "size" to -1. This will set the modtime_size field of
6118 the corresponding buffer to -1, which is what
6119 verify-visited-file-modtime expects for files that do not exist.
6122 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6124 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6126 * lisp.h: ... from here. push_key_description is no longer
6127 defined in keyboard.c, so its declaration should not be in
6128 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6129 logically belongs with push_key_description.
6131 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6133 * buffer.h: Include <sys/types.h> instead of <time.h>.
6134 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6135 Problem reported by Herbert J. Skuhra.
6137 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6139 * xml.c (parse_region): Make the parsing work for
6140 non-comment-starting XML files again (bug#9144).
6142 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6144 * image.c (gif_load): Fix calculation of bottom and right corner.
6147 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6149 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6150 redisplay in small windows.
6152 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6154 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6156 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6158 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6159 Operate on live windows only.
6161 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6163 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6165 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6167 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6168 only under bidi iteration.
6170 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6172 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6174 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6176 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6177 Without this fix, the command to link temacs failed due to an
6178 undefined symbol __builtin_isnan. This is because
6179 /usr/include/iso/math_c99.h #defines isnan(x) to
6180 __builtin_isnan(x), but the bundled gcc, which identifies itself
6181 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6183 * floatfns.c (isnan): #undef, and then #define to a clone of
6185 (Fisnan): Always define, since it's always available now.
6186 (syms_of_floatfns): Always define isnan at the Lisp level.
6188 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6190 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6192 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6194 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6195 The previous code assumed that file offsets (off_t values) fit in
6196 EMACS_INT variables, which is not true on typical 32-bit hosts.
6197 The code messed up by falsely reporting buffer overflow in cases
6198 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6199 when "big" contains more than 2**29 bytes, even though this
6200 inserts just one byte and does not overflow the buffer.
6201 (Finsert_file_contents): Store file offsets as off_t
6202 values, not as EMACS_INT values. Check for overflow when
6203 converting between EMACS_INT and off_t. When checking for
6204 buffer overflow or for overlap, take the offsets into account.
6205 Don't use EMACS_INT for small values where int suffices.
6206 When checking for overlap, fix a typo: ZV was used where
6207 ZV_BYTE was intended.
6208 (Fwrite_region): Don't assume off_t fits into 'long'.
6209 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6211 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6213 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6215 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6217 sprintf-related integer and memory overflow issues (Bug#9412).
6219 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6220 (esprintf, exprintf, evxprintf): New functions.
6221 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6222 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6223 (modify_event_symbol): Do not assume that the length of
6224 name_alist_or_stem is safe to alloca and fits in int.
6225 (Fexecute_extended_command): Likewise for function name and binding.
6226 (Frecursion_depth): Wrap around reliably on integer overflow.
6227 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6228 since some callers pass EMACS_INT values.
6229 (Fsingle_key_description): Don't crash if symbol name contains more
6230 than MAX_ALLOCA bytes.
6231 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6232 (get_minibuffer): Arg is now EMACS_INT, not int.
6233 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6234 (esprintf, exprintf, evxprintf): New decls.
6235 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6237 * dbusbind.c (signature_cat): New function.
6238 (xd_signature, Fdbus_register_signal):
6239 Do not overrun buffer; instead, report string overflow.
6241 * dispnew.c (add_window_display_history): Don't overrun buffer.
6242 Truncate instead; this is OK since it's just a log.
6244 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6245 even if the time zone offset is outlandishly large.
6246 Don't mishandle offset == INT_MIN.
6248 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6249 when creating daemon; the previous buffer-overflow check was incorrect.
6251 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6252 which has the guts of the old verror function.
6254 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6255 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6257 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6258 (font_unparse_xlfd): Don't blindly alloca long strings.
6259 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6260 fits in int, when using sprintf. Use single snprintf to count
6261 length of string rather than counting it via multiple sprintfs;
6262 that's simpler and more reliable.
6263 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6264 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6265 sprintf, in case result does not fit in int.
6267 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6268 (fontset_from_font): Print it.
6270 * frame.c (tty_frame_count): Now printmax_t, not int.
6271 (make_terminal_frame, set_term_frame_name): Print it.
6272 (x_report_frame_params): In X, window IDs are unsigned long,
6273 not signed long, so print them as unsigned.
6274 (validate_x_resource_name): Check for implausibly long names,
6275 and don't assume name length fits in 'int'.
6276 (x_get_resource_string): Don't blindly alloca invocation name;
6277 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6280 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6281 (xg_check_special_colors, xg_set_geometry):
6282 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6284 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6285 Use esprintf, not sprintf, in case result does not fit in int.
6287 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6288 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6289 it as a large positive number.
6290 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6291 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6293 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6294 in case result does not fit in int.
6296 * print.c (float_to_string): Detect width overflow more reliably.
6297 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6298 buffer overrun. Don't assume list length fits in 'int'. Treat
6299 print length of 0 as 0, not as infinity; to be consistent with other
6300 uses of print length in this function. Don't overflow print length
6301 index. Don't assume hash table size fits in 'long', or that
6302 vectorlike size fits in 'unsigned long'.
6304 * process.c (make_process): Use printmax_t, not int, to format
6305 process-name gensyms.
6307 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6309 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6310 to avoid potential buffer overrun.
6312 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6313 if X resource line is longer than 512 bytes.
6315 * xfns.c (x_window): Make sprintf buffer a bit bigger
6316 to avoid potential buffer overrun.
6318 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6320 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6322 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6324 Integer overflow fixes for scrolling, etc.
6325 Without these, Emacs silently mishandles large integers sometimes.
6326 For example, "C-u 4294967297 M-x recenter" was treated as if
6327 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6329 * xdisp.c (try_window_id): Check Emacs fixnum range before
6330 converting to 'int'.
6332 * window.c (window_scroll_line_based, Frecenter):
6333 Check that an Emacs fixnum is in range before assigning it to 'int'.
6334 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6335 values converted from Emacs fixnums.
6336 (Frecenter): Don't wrap around a line count if it is out of 'int'
6337 range; instead, treat it as an extreme value.
6338 (Fset_window_configuration, compare_window_configurations):
6339 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6341 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6342 that can exceed INT_MAX. Check that EMACS_INT value is in range
6343 before assigning it to the (possibly-narrower) index.
6344 (match_limit): Don't assume that a fixnum can fit in 'int'.
6346 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6349 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6350 (Fvertical_motion): Don't wrap around LINES values that don't fit
6351 in 'int'. Instead, treat them as extreme values. This is good
6352 enough for windows, which can't have more than INT_MAX lines anyway.
6354 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6356 * Require libxml/parser.h to avoid compilation warning.
6358 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6360 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6361 since this reportedly can destroy thread storage.
6363 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6365 * syntax.c (find_defun_start): Update all cache variables if
6366 exiting early (Bug#9401).
6368 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6370 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6372 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6373 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6374 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6376 * term.c (tty_append_glyph): New function.
6377 (produce_stretch_glyph): Static function and its prototype deleted.
6379 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6382 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6384 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6385 when checking :margin (Bug#9390).
6386 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6387 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6388 so that the name doesn't mislead. All uses changed.
6390 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6392 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6395 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6397 * xdisp.c (move_it_to): Don't bail out early when reaching
6398 position beyond to_charpos, if we are scanning backwards.
6399 (move_it_vertically_backward): When DY == 0, make sure we get to
6400 the first character in the line after the newline.
6402 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6404 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6405 (ccl_driver): Do not generate an out-of-range pointer.
6406 (Fccl_execute_on_string): Remove unnecessary check for
6407 integer overflow, noted by Stefan Monnier in
6408 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6409 Remove a FIXME that didn't need fixing.
6410 Simplify the newly-introduced buffer reallocation code.
6412 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6414 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6416 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6418 Integer and memory overflow issues (Bug#9196).
6420 * doc.c (get_doc_string): Rework so that
6421 get_doc_string_buffer_size is the actual buffer size, rather than
6422 being 1 less than the actual buffer size; this makes xpalloc more
6425 * image.c (x_allocate_bitmap_record, cache_image):
6426 * xselect.c (Fx_register_dnd_atom):
6427 Simplify previous changes by using xpalloc.
6429 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6430 since either will do and ptrdiff_t is convenient with xpalloc.
6432 * charset.c (charset_table_size)
6433 (struct charset_sort_data.priority): Now ptrdiff_t.
6434 (charset_compare): Don't overflow if priorities differ greatly.
6435 (Fsort_charsets): Don't assume list length fits in int.
6436 Check for size-calculation overflow when allocating sort data.
6437 (syms_of_charset): Allocate an initial charset table that is
6438 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6440 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6442 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6443 The actual value is always <= INT_MAX, and leaving it unsigned made
6444 overflow checking harder.
6446 * dispextern.h (struct glyph_matrix.rows_allocated)
6447 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6448 with xpalloc. The values are still always <= INT_MAX.
6450 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6452 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6453 (SAFE_NALLOCA): New macro.
6455 * region-cache.c (struct boundary.pos, find_cache_boundary)
6456 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6457 (set_cache_region, invalidate_region_cache)
6458 (revalidate_region_cache, know_region_cache, region_cache_forward)
6459 (region_cache_backward, pp_cache):
6460 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6461 so that ptrdiff_t * can be passed to xpalloc.
6462 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6463 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6464 (pp_cache): Don't assume cache_len fits in int.
6465 * region-cache.h: Adjust extern decls to match.
6467 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6468 EMACS_INT, since either will do, for xpalloc.
6470 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6471 (xnmalloc, xnrealloc, xpalloc): New functions.
6473 * bidi.c (bidi_shelve_header_size): New constant.
6474 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6475 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6477 * bidi.c (bidi_cache_shrink):
6478 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6480 Don't update size of array until after memory allocation succeeds,
6481 because xmalloc/xrealloc may not return.
6482 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6483 now that we have proper integer overflow checking.
6484 (record_overlay_string, overlay_strings): Catch overflows when
6485 calculating size of overlay_str_buf.
6487 * callproc.c (Fcall_process): Check for size overflow when
6488 calculating size of args2.
6489 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6490 Normally we prefer signed values, but sticking with ptrdiff_t would
6491 require adding more-complicated checks.
6493 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6494 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6495 Redo buffer-overflow calculations to avoid integer overflow.
6496 Add a FIXME comment where memory seems to be over-allocated.
6498 * character.c (Fstring): Check for size-calculation overflow.
6500 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6501 unnecessary integer overflow. Check for size overflow.
6502 (encode_coding_object): Don't update size until xmalloc succeeds.
6504 * composite.c (get_composition_id): Check for overflow in glyph
6505 length calculations.
6507 Integer and memory overflow fixes for display code.
6508 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6509 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6510 (scrolling_window): Check for overflow in size calculations.
6511 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6512 Don't assume glyph table len fits in int.
6513 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6514 (row_table_size): Now ptrdiff_t, not int.
6515 (scrolling_window): Avoid overflow in size calculations.
6516 Don't update size until allocation succeeds.
6517 * fns.c (concat): Check for overflow in size calculations.
6518 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6519 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6520 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6522 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6523 (get_doc_string): Check for size calculation overflow.
6524 Don't update size until allocation succeeds.
6525 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6526 EMACS_INT, where ptrdiff_t will do.
6527 (Fsubstitute_command_keys): Check for string overflow.
6529 * editfns.c (set_time_zone_rule): Don't assume environment length
6531 (message_length): Now ptrdiff_t, not int.
6532 (Fmessage_box): Don't update size until allocation succeeds.
6533 Don't assume message length fits in int.
6534 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6536 * emacs.c (main): Do not reallocate argv, since there is a null at
6537 the end that can be overwritten, and this way there's no need to
6538 worry about size-calculation overflow.
6539 (sort_args): Check for size-calculation overflow.
6541 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6543 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6545 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6546 (x_set_scroll_bar_width, x_figure_window_size):
6547 Check for integer overflow.
6548 (x_set_alpha): Do not assume XINT fits in int.
6550 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6551 This is for the members text_lines, text_cols, total_lines, total_cols,
6552 where the system imposes an 'int' limit.
6554 * fringe.c (Fdefine_fringe_bitmap):
6555 Don't update size until alloc works.
6557 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6558 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6560 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6561 Check for size-calculation overflow.
6562 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6563 do, as we prefer signed integers.
6564 (id_to_widget.max_size, id_to_widget.used)
6565 (xg_store_widget_in_map, xg_remove_widget_from_map)
6566 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6567 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6568 Use and return ptrdiff_t, not int.
6569 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6570 * gtkutil.h: Change prototypes to match the above.
6572 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6573 are duplicate now that they've been promoted to lisp.h.
6574 (x_allocate_bitmap_record, x_alloc_image_color)
6575 (make_image_cache, cache_image, xpm_load):
6576 Don't update size until alloc is done.
6577 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6579 Check for size calculation overflow.
6580 (ct_colors_allocated_max): New constant.
6581 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6584 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6585 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6586 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6587 Use ptrdiff_t, not int, to count maps.
6588 (read_char_minibuf_menu_prompt): Check for overflow in size
6589 calculations. Don't update size until allocation succeeds.
6590 Redo calculations to avoid overflow.
6591 * keyboard.h: Change prototypes to match the above.
6593 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6595 (current_minor_maps): Check for size calculation overflow.
6596 * keymap.h: Change prototypes to match the above.
6598 * lread.c (read1, init_obarray): Don't update size until alloc done.
6600 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6601 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6603 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6604 Now ptrdiff_t, not int.
6605 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6606 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6608 * process.c (Fnetwork_interface_list): Check for overflow
6609 in size calculation.
6611 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6613 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6614 overflow. Don't bother calling xmalloc when xrealloc will do.
6616 * search.c (Freplace_match): Check for size calculation overflow.
6617 (Fset_match_data): Don't assume list lengths fit in 'int'.
6619 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6620 for command line length. Do not attempt to address one before the
6621 beginning of an array, as that's not portable.
6623 * term.c (max_frame_lines): Remove; unused.
6624 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6626 (encode_terminal_code, calculate_costs): Check for size
6627 calculation overflow.
6628 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6629 table lengths and related sizes. Don't update size until alloc
6630 done. Redo calculations to avoid overflow.
6631 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6633 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6634 subtracting pointers.
6635 (gobble_line): Check for overflow more carefully. Don't update size
6638 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6639 Don't update size until alloc done.
6640 Redo size calculations to avoid overflow.
6641 Check for size calculation overflow.
6642 (main) [DEBUG]: Fix typo in invoking tparam1.
6644 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6645 Use ptrdiff_t, not int, for sizes.
6646 (store_mode_line_noprop_char): Don't update size until alloc done.
6648 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6649 Use ptrdiff_t, not int, for sizes.
6650 (Finternal_make_lisp_face, cache_face):
6651 Check for size calculation overflow.
6652 (cache_face): Treat size calculation overflows as if they were
6653 memory exhaustion (the usual treatment), rather than aborting.
6655 * xfns.c (x_encode_text, x_set_name_internal)
6656 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6657 sizes, since they can exceed INT_MAX in size. Check for size
6658 calculation overflow.
6660 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6661 (xg_select): Check for size calculation overflow.
6662 Don't update size until alloc done.
6664 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6665 as sprintf is limited to int lengths.
6667 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6668 (X_LONG_MIN): New macros.
6669 Use them to make the following changes clearer.
6670 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6671 This change doesn't affect the value now, but it may help remind
6672 future maintainers not to raise the value too much later.
6673 (SELECTION_QUANTUM): Remove, replacing with ...
6674 (selection_quantum): ... new function, which avoids overflow.
6676 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6677 assumption that selection length fits in 'int'.
6678 (x_reply_selection_request, x_handle_selection_request)
6679 (x_get_window_property, receive_incremental_selection)
6680 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6681 (lisp_data_to_selection_data, clean_local_selection_data):
6682 Use ptrdiff_t, not int, to record length of selection.
6683 (x_reply_selection_request, x_get_window_property)
6684 (receive_incremental_selection, x_property_data_to_lisp):
6685 Redo calculations to avoid overflow.
6686 (x_reply_selection_request): When sending hint, ceiling it at
6687 X_LONG_MAX rather than relying on wraparound overflow to send
6689 (x_get_window_property, receive_incremental_selection)
6690 (lisp_data_to_selection_data, x_property_data_to_lisp):
6691 Check for size-calculation overflow.
6692 (x_get_window_property, receive_incremental_selection)
6693 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6694 Don't store size until memory allocation succeeds.
6695 (x_get_window_property): Plug memory leak on memory exhaustion.
6696 Don't double-block input; malloc is safe here. Don't assume 2**34
6697 - 4 fits in unsigned long. Add an xassert to check
6698 XGetWindowProperty overflow. Be more careful about overflow
6699 calculations, and distinguish size from memory overflow better.
6700 (receive_incremental_selection): When tracing, don't assume
6701 unsigned int is less than INT_MAX.
6702 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6703 harmful) conversions of unsigned short to int.
6704 (lisp_data_to_selection_data): Don't assume that integers
6705 in the range -65535 through -1 fit in an X unsigned short.
6706 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6707 result parameters unless successful. Rely on cons_to_unsigned
6708 to report problems with elements; the old code wasn't right anyway.
6709 (x_check_property_data): Check for int overflow; we cannot use
6710 a wider type due to X limits.
6711 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6713 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6715 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6716 (x_term_init): Check for size calculation overflow.
6717 (x_color_cells): Don't store size until memory allocation succeeds.
6718 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6719 Don't assume alloca size is less than MAX_ALLOCA.
6720 (x_term_init): Don't assume length fits in int (sprintf is limited
6723 Use ptrdiff_t for composition IDs.
6724 * character.c (lisp_string_width):
6725 * composite.c (composition_table_size, n_compositions)
6726 (get_composition_id, composition_gstring_from_id):
6727 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6728 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6729 * window.c (Frecenter):
6730 Use ptrdiff_t, not int, for composition IDs.
6731 * composite.c (get_composition_id): Check for integer overflow.
6732 * composite.h: Adjust prototypes to match the above changes.
6734 Use ptrdiff_t for hash table indexes.
6735 * category.c (hash_get_category_set):
6736 * ccl.c (ccl_driver):
6737 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6738 * coding.c (coding_system_charset_list, detect_coding_system):
6739 * coding.h (struct coding_system.id):
6740 * composite.c (get_composition_id, gstring_lookup_cache):
6741 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6742 * image.c (xpm_get_color_table_h):
6743 * lisp.h (hash_lookup, hash_put):
6744 * minibuf.c (Ftest_completion):
6745 Use ptrdiff_t for hash table indexes, not int (which is too
6746 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6747 32-bit --with-wide-int hosts).
6749 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6750 Add a FIXME comment about memory leaks.
6751 (syms_of_charset): Don't assume xmalloc returns.
6753 Don't assume that stated character widths fit in int.
6754 * character.c (Fchar_width, c_string_width, lisp_string_width):
6755 * character.h (CHAR_WIDTH):
6756 * indent.c (MULTIBYTE_BYTES_WIDTH):
6757 Use sanitize_char_width to avoid undefined and/or bad behavior
6758 with outlandish widths.
6759 * character.h (sanitize_tab_width): Rename from sanitize_width,
6760 now that we have two such functions. All uses changed.
6761 (sanitize_char_width): New inline function.
6763 Don't assume that tab-width fits in int.
6764 * character.h (sanitize_width): New inline function.
6765 (SANE_TAB_WIDTH): New macro.
6766 (ASCII_CHAR_WIDTH): Use it.
6767 * indent.c (sane_tab_width): Remove. All uses replaced by
6768 SANE_TAB_WIDTH (current_buffer).
6769 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6771 * fileio.c: Integer overflow issues with file modes.
6772 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6774 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6775 Remove unreachable code.
6776 (read_hex, load_charset_map_from_file): Check for integer overflow.
6778 * xterm.c: Don't go over XClientMessageEvent limit.
6779 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6780 (x_send_scroll_bar_event): Likewise. Check that the size does not
6781 exceed limits imposed by XClientMessageEvent, as well as the usual
6782 ptrdiff_t and size_t limits.
6784 * keyboard.c: Overflow, signedness and related fixes.
6785 (make_lispy_movement): Use same integer type in forward decl
6786 that is used in the definition.
6787 (read_key_sequence, keyremap_step):
6788 Change bufsize argument back to int, undoing my 2011-03-30 change.
6789 We prefer signed types, and int is wide enough here.
6790 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6791 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6792 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6793 length, not size_t. Use ptrdiff_t for index, not int.
6794 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6795 possibility of integer overflow.
6797 Overflow, signedness and related fixes for images.
6799 * dispextern.h (struct it.stack[0].u.image.image_id)
6800 (struct_it.image_id, struct image.id, struct image_cache.size)
6801 (struct image_cache.used, struct image_cache.ref_count):
6802 * gtkutil.c (update_frame_tool_bar):
6803 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6804 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6805 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6806 * nsmenu.m (update_frame_tool_bar):
6807 * xdisp.c (calc_pixel_width_or_height):
6808 * xfns.c (image_cache_refcount):
6809 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6810 on typical 64-bit hosts.
6812 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6813 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6814 Omit unnecessary casts to int.
6815 (parse_image_spec): Check that integers fall into 'int' range
6816 when the callers expect that.
6817 (image_ascent): Redo ascent calculation to avoid int overflow.
6818 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6819 (lookup_image): Remove unnecessary tests.
6820 (xbm_image_p): Locals are now of int, not EMACS_INT,
6821 since parse_image_check makes sure they fit into int.
6822 (png_load, gif_load, svg_load_image):
6823 Prefer int to unsigned where either will do.
6824 (tiff_handler): New function, combining the cores of the
6825 old tiff_error_handler and tiff_warning_handler.
6826 This function is rewritten to use vsnprintf and thereby avoid
6827 stack buffer overflows. It uses only the features of vsnprintf
6828 that are common to both POSIX and native Microsoft.
6829 (tiff_error_handler, tiff_warning_handler): Use it.
6830 (tiff_load, gif_load, imagemagick_load_image):
6831 Don't assume :index value fits in 'int'.
6832 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6833 (imagemagick_load_image): Check that crop parameters fit into
6834 the integer types that MagickCropImage accepts. Don't assume
6835 Vimagemagick_render_type has a nonnegative value. Don't assume
6836 size_t fits in 'long'.
6837 (gs_load): Use printmax_t to print the widest integers possible.
6838 Check for integer overflow when computing image height and width.
6840 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6842 * xdisp.c (redisplay_window): Don't force window start if point
6843 will be invisible in the resulting window. (Bug#9324)
6845 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6847 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6848 the display spec is of the form `(space ...)'.
6849 (handle_display_spec): Return the value returned by
6850 handle_single_display_spec, not just 1 or zero.
6851 (handle_single_display_spec): If the display spec is of the form
6852 `(space ...)', and specifies display in the text area, return 2
6854 (try_cursor_movement): Check for the need to scroll more
6855 accurately, and prefer exact match for point under bidi.
6856 Don't advance `row' beyond the last row of the window.
6858 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6859 into disp_prop; all users changed.
6861 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6862 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6863 for the text covered by the display property.
6865 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6867 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6868 Change return value to nil.
6869 (Frecord_buffer): Delete unused function.
6871 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6873 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6874 buffers, return left-to-right.
6875 (set_cursor_from_row): Consider candidate row a win if its glyph
6876 represents a newline and point is on that newline. Fixes cursor
6877 positioning on the newline at EOL of R2L text within L2R
6878 paragraph, and vice versa.
6879 (try_cursor_movement): Check continued rows, in addition to
6880 continuation rows. Fixes unwarranted scroll when point enters a
6881 continued line of R2L text within an L2R paragraph, or vice versa.
6882 (cursor_row_p): Consider the case of point being equal to
6883 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6884 from the end of a short line to the beginning of a continued line
6885 of R2L text within L2R paragraph.
6886 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6887 composed characters.
6889 * bidi.c (bidi_check_type): Use xassert.
6890 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6893 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6895 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6898 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6900 * nsfont.m (ns_otf_to_script): Fix typo.
6902 2011-08-22 Kenichi Handa <handa@m17n.org>
6904 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6905 extra slot even if the purpose is char-code-property-table.
6907 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6909 * xdisp.c (redisplay_window): When computing centering_position,
6910 account for the height of the header line. (Bug#8874)
6912 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6913 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6914 candidate is selected by the mouse, and that candidate has a
6915 composed character under the mouse.
6917 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6918 coordinates reported by pos-visible-in-window-p for a composed
6919 character in column zero.
6921 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6923 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6925 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6927 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6928 consider it a hit if to_charpos is anywhere in the range of the
6929 composed buffer positions.
6931 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6933 * image.c (gif_load): Don't assume that each subimage has the same
6934 dimensions as the base image. Handle disposal method that is
6935 "undefined" by the gif spec (Bug#9335).
6937 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6939 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6940 (Fcondition_case): Document `debug' symbol in error handler.
6942 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6944 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6945 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6946 from an Org mode buffer to a Speedbar frame.
6948 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6949 a composition, take its buffer position from IT->cmp_it.charpos.
6950 Fixes cursor positioning at the beginning of a line that begins
6951 with a composed character.
6953 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6955 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6956 character bidirectional type, use STRONG_L instead. Fixes crashes
6957 in a buffer produced by `describe-categories'.
6959 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6960 members before the level stack, so they would be saved and
6961 restored when copying iterator state. Fixes incorrect reordering
6962 around TABs covered by display properties.
6964 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6966 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6968 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6970 * eval.c (internal_condition_case, internal_condition_case_1)
6971 (internal_condition_case_2, internal_condition_case_n):
6972 Remove unnecessary aborts (Bug#9081).
6974 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6976 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6977 has no `load' handler, try opening the file locally. (Bug#9311)
6979 2011-08-16 Ken Brown <kbrown@cornell.edu>
6981 * gmalloc.c: Expand comment.
6983 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6985 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6986 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6988 2011-08-16 Ken Brown <kbrown@cornell.edu>
6990 Fix memory allocation problems in Cygwin build (Bug#9273).
6992 * unexcw.c ( __malloc_initialized): Declare external variable.
6993 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6995 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6997 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6999 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7001 [CYGWIN] (special_realloc): New function.
7002 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7003 requests to realloc storage in the static heap.
7005 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7007 * bidi.c (bidi_initialize): Remove unused local.
7009 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7012 * biditype.h: Remove file.
7013 * makefile.w32-in ($(BLD)/bidi.$(O)):
7014 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7016 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7018 * chartab.c: Improve commentary for the uniprop_table API.
7020 * bidi.c (bidi_paragraph_init): Support zero value of
7021 bidi_ignore_explicit_marks_for_paragraph_level.
7022 (bidi_initialize): Use uniprop_table instead of including
7023 biditype.h and bidimirror.h.
7025 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7026 coordinates of the iterator when restoring from ppos_it.
7029 2011-08-14 Kenichi Handa <handa@m17n.org>
7031 * process.c (create_process): Call setup_process_coding_systems
7032 after the pid of the process is set to -1 (Bug#8162).
7034 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7036 * xdisp.c (move_it_in_display_line_to): Don't invoke
7037 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7038 ppos_it. Fixes vertical cursor motion when line beginning is
7039 covered by an image. (Bug#9296)
7041 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7043 * nsterm.h (ns_run_ascript): Declare.
7044 (NSAPP_DATA2_RUNASSCRIPT): Define.
7046 * nsfns.m (as_script, as_result, as_status): New static variables.
7047 (ns_run_ascript): New function.
7048 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7049 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7050 the event loop. Get status from as_status (Bug#7276).
7052 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7053 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7054 the event loop (Bug#7276).
7056 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7058 * gnutls.c (QCgnutls_bootprop_priority)
7059 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7060 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7061 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7062 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7063 (QCgnutls_bootprop_verify_hostname_error)
7064 (QCgnutls_bootprop_callbacks_verify): Rename from
7065 Qgnutls_bootprop_..., all uses changed.
7067 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7070 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7072 * xfaces.c (Qframe_set_background_mode): Now static.
7073 * dispextern.h (Qframe_set_background_mode): Remove decl.
7075 * process.c (Fnetwork_interface_info): Declare local only if needed.
7077 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7079 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7080 (Fnetwork_interface_list): Allocate in increments of bytes instead
7081 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7082 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7084 (struct ifflag_def): notrailers is smart on OSX.
7085 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7086 Get hardware address with getifaddrs if available.
7088 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7090 * xdisp.c (iterate_out_of_display_property): xassert that
7091 IT->position is set to within IT->object's boundaries. Break from
7092 the loop as soon as EOB is reached; avoids infloops in redisplay
7093 when IT->position is set up wrongly due to some bug.
7094 Set IT->current to match the bidi iterator unconditionally.
7095 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7096 entry. Force push_it to save on the stack the current
7097 buffer/string position, to be restored by pop_it. Fix flags in
7098 the iterator structure wrt the object coming from a display
7099 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7100 properties. (Bug#9284)
7102 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7104 * fontset.c (fontset_get_font_group): Add proper type checks.
7107 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7109 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7110 and LC_VERSION_MIN_MACOSX.
7111 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7112 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7114 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7116 * xdisp.c (forward_to_next_line_start): Allow to use the
7117 no-display-properties-and-no-overlays under bidi display.
7118 Set disp_pos in the bidi iterator to avoid searches for display
7119 properties and overlays.
7121 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7123 * editfns.c (Fset_time_zone_rule): Document relationship with the
7126 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7127 the font entity extracted from the cache (Bug#8109).
7129 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7131 * composite.c (autocmp_chars): Don't reset point. That is done by
7132 restore_point_unwind (Bug#5984).
7134 2011-08-07 Juri Linkov <juri@jurta.org>
7136 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7137 to show the arg `TIME' instead of `TIMEVAL'.
7139 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7141 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7142 display property strides EOL and includes a newline, as in
7143 longlines-mode. (Bug#9254)
7144 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7145 word-wrap under bidirectional display. (Bug#9224)
7147 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7148 is non-zero, even if the data buffer is NULL. Fixes a crash in
7149 vertical-motion with longlines-mode. (Bug#9254)
7151 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7153 * bidi.c <bidi_cache_total_alloc>: Now static.
7154 (bidi_initialize): Initialize bidi_cache_total_alloc.
7156 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7159 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7160 amount allocated this far in `bidi_cache_total_alloc'.
7161 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7162 non-zero, only free the data buffer without restoring the cache
7163 contents. All callers changed.
7165 * dispextern.h (bidi_unshelve_cache): Update prototype.
7167 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7168 (move_it_in_display_line, move_it_to)
7169 (move_it_vertically_backward, move_it_by_lines): Replace the call
7170 to xfree to an equivalent call to bidi_unshelve_cache.
7171 (move_it_in_display_line_to): Fix logic of returning
7172 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7174 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7176 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7177 came from a string character with a `cursor' property. (Bug#9229)
7179 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7181 * Makefile.in (LIB_PTHREAD): New variable.
7182 (LIBES): Add LIB_PTHREAD (Bug#9216).
7184 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7185 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7187 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7189 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7191 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7193 * xterm.c (x_find_topmost_parent): New function.
7194 (x_set_frame_alpha): Find topmost parent window with
7195 x_find_topmost_parent and set the property there also (bug#9181).
7196 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7198 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7200 * callproc.c (Fcall_process): Avoid vfork clobbering
7201 the local vars buffer, coding_systems, current_dir.
7203 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7205 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7207 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7209 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7210 so that it is not optimized away.
7212 * xdisp.c (compute_display_string_pos): Remove unused local.
7214 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7216 Fix slow cursor motion and scrolling in large buffers with
7217 selective display, like Org Mode buffers. (Bug#9218)
7219 * dispextern.h (struct bidi_it): New member disp_prop_p.
7221 * xdisp.c: Remove one-slot cache of display string positions.
7222 (compute_display_string_pos): Accept an additional argument
7223 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7224 for a display string or property. If found, set DISP_PROP_P
7227 * bidi.c (bidi_fetch_char): Accept an additional argument
7228 DISP_PROP_P, and pass it to compute_display_string_pos.
7229 Only handle text covered by a display string if DISP_PROP_P is returned
7230 non-zero. All callers of bidi_fetch_char changed.
7232 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7234 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7236 2010-12-03 Don March <don@ohspite.net>
7238 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7239 last character M-[char] is translated to ESC [char] (bug#7541).
7241 2011-08-02 Kenichi Handa <handa@m17n.org>
7243 * lisp.h (uniprop_table): Extern it.
7245 * chartab.c (uniprop_table): Make it non-static.
7247 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7249 * xdisp.c (forward_to_next_line_start): Accept additional argument
7250 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7252 (reseat_at_next_visible_line_start): Use the bidi iterator state
7253 returned by forward_to_next_line_start to restore the state of
7254 it->bidi_it after backing up to previous newline. (Bug#9212)
7256 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7258 * regex.c (re_comp): Protoize.
7259 (re_exec): Fix return type.
7260 (regexec): Fix type of `ret'. (Bug#9203)
7262 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7264 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7265 This is needed if max-image-size is a floating-point number.
7267 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7269 * print.c (print_object): Print empty symbol as ##.
7271 * lread.c (read1): Read ## as empty symbol.
7273 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7275 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7276 setting frame foreground color (Bug#9175).
7277 (x_set_background_color): Likewise.
7279 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7280 contents (Bug#9176).
7281 (EmacsTooltip -init): Remove bezels and add shadows to
7284 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7285 or scroll bar (Bug#8470).
7287 * nsfont.m (nsfont_open): Remove assignment to voffset and
7288 unnecessary vars hshink, expand, hd, full_height, min_height.
7289 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7291 * nsterm.h (nsfont_info): Remove voffset field.
7293 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7295 Implement strike-through and overline on NextStep (Bug#8863).
7297 * nsfont.m (nsfont_open): Use underline position provided by font,
7298 instead of hard-coded value of 2.
7299 (nsfont_draw): Call ns_draw_text_decoration instead.
7301 * nsterm.h: Add declaration for ns_draw_text_decoration.
7303 * nsterm.m (ns_draw_text_decoration): New function for drawing
7304 underline, overline, and strike-through.
7305 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7306 ns_draw_text_decoration. Change treatment of cursor drawing to
7307 accommodate underlining, etc.
7309 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7311 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7314 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7316 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7317 Without this fix, if a signal arrives just after memory fills up,
7318 'malloc' might be invoked reentrantly.
7320 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7321 In other words, assume that every image size is allowed, on non-X
7322 hosts. This assumption is probably wrong, but it lets Emacs compile.
7324 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7326 * regex.c (re_iswctype): Convert return values to boolean.
7328 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7330 * xdisp.c (compute_display_string_pos): Don't use cached display
7331 string position if the buffer had its restriction changed.
7334 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7336 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7338 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7340 Integer signedness and overflow and related fixes. (Bug#9079)
7342 * bidi.c: Integer size and overflow fixes.
7343 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7344 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7345 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7346 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7347 (bidi_find_other_level_edge):
7348 Use ptrdiff_t instead of EMACS_INT where either will do.
7349 This works better on 32-bit hosts configured --with-wide-int.
7350 (bidi_cache_ensure_space): Check for size-calculation overflow.
7351 Use % rather than repeated addition, for better worst-case speed.
7352 Don't set bidi_cache_size until after xrealloc returns, because it
7354 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7355 (bidi_cache_ensure_space): Also check that the bidi cache size
7356 does not exceed that of the largest Lisp string or buffer. See Eli
7357 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7359 * alloc.c (__malloc_size_t): Remove.
7360 All uses replaced by size_t. See Andreas Schwab's note
7361 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7363 * image.c: Improve checking for integer overflow.
7364 (check_image_size): Assume that f is nonnull, since
7365 it is always nonnull in practice. This is one less thing to
7366 worry about when checking for integer overflow later.
7367 (x_check_image_size): New function, which checks for integer
7368 overflow issues inside X.
7369 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7370 This removes the need for a memory_full check.
7371 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7372 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7373 (xbm_read_bitmap_data): Change locals back to 'int', since
7374 their values must fit in 'int'.
7375 (xpm_load_image, png_load, tiff_load):
7376 Invoke x_create_x_image_and_pixmap earlier,
7377 to avoid much needless work if the image is too large.
7378 (tiff_load): Treat overly large images as if
7379 x_create_x_image_and_pixmap failed, not as malloc failures.
7380 (gs_load): Use x_check_image_size.
7382 * gtkutil.c: Omit integer casts.
7383 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7384 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7386 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7388 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7389 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7390 would wrongly return t on a 64-bit host.
7392 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7393 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7394 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7395 and therefore cause GCC to emit a bogus diagnostic in some cases.
7397 * image.c: Integer signedness and overflow and related fixes.
7398 This is not an exhaustive set of fixes, but it's time to
7399 record what I've got.
7400 (lookup_pixel_color, check_image_size): Remove redundant decls.
7401 (check_image_size): Don't assume that arbitrary EMACS_INT values
7402 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7403 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7404 (tiff_load, imagemagick_load_image):
7405 Check for overflow in size calculations.
7406 (x_create_x_image_and_pixmap): Remove unnecessary test for
7407 xmalloc returning NULL; that can't happen.
7408 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7409 (xpm_color_bucket): Use better integer hashing function.
7410 (xpm_cache_color): Don't possibly over-allocate memory.
7411 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7412 (gif_memory_source):
7413 Use ptrdiff_t, not int or size_t, to record sizes.
7414 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7415 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7416 either works, as we prefer signed integers.
7417 (tiff_read_from_memory, tiff_write_from_memory):
7418 Return tsize_t, not size_t, since that's what the TIFF API wants.
7419 (tiff_read_from_memory): Don't fail simply because the read would
7420 go past EOF; instead, return a short read.
7421 (tiff_load): Omit no-longer-needed casts.
7422 (Fimagemagick_types): Don't assume size fits into 'int'.
7424 Improve hashing quality when configured --with-wide-int.
7425 * fns.c (hash_string): New function, taken from sxhash_string.
7426 Do not discard information about ASCII character case; this
7427 discarding is no longer needed.
7428 (sxhash-string): Use it. Change sig to match it. Caller changed.
7429 * lisp.h: Declare it.
7430 * lread.c (hash_string): Remove, since we now use fns.c's version.
7431 The fns.c version returns a wider integer if --with-wide-int is
7432 specified, so this should help the quality of the hashing a bit.
7434 * emacs.c: Integer overflow minor fix.
7435 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7436 Define only if GNU_LINUX.
7437 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7439 * dispnew.c: Integer signedness and overflow fixes.
7440 Remove unnecessary forward decls, that were a maintenance hassle.
7441 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7443 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7444 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7445 (prepare_desired_row, line_draw_cost):
7446 Use int, not unsigned, where either works.
7447 (save_current_matrix, restore_current_matrix):
7448 Use ptrdiff_t, not size_t, where either works.
7449 (init_display): Check for overflow more accurately, and without
7450 relying on undefined behavior.
7452 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7453 Remove, replacing with the new symbols in lisp.h. All uses changed.
7454 * fileio.c (make_temp_name):
7455 * filelock.c (lock_file_1, lock_file):
7456 * xdisp.c (message_dolog):
7457 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7458 Use pMd etc. instead.
7459 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7460 replacing the pWIDE etc. symbols removed from editfns.c.
7462 * keyboard.h (num_input_events): Now uintmax_t.
7463 This is (very slightly) less likely to mess up due to wraparound.
7466 * buffer.c: Integer signedness fixes.
7467 (alloc_buffer_text, enlarge_buffer_text):
7468 Use ptrdiff_t rather than size_t when either will do, as we prefer
7471 * alloc.c: Integer signedness and overflow fixes.
7472 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7473 (__malloc_size_t): Default to size_t, not to int.
7474 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7475 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7476 Prefer ptrdiff_t to size_t when either would do, as we prefer
7478 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7479 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7480 Now const. Initialize with values that are in range even if char
7482 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7483 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7484 These functions do the right thing with sizes > 2**32.
7485 (check_depth): Now ptrdiff_t, not int.
7486 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7487 Adjust to new way of storing sizes. Check for size overflow bugs
7489 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7490 slightly wrong anyway, as it missed one instance of
7491 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7492 (refill_memory_reserve): Omit needless cast to size_t.
7493 (mark_object_loop_halt): Mark as externally visible.
7495 * xselect.c: Integer signedness and overflow fixes.
7496 (Fx_register_dnd_atom, x_handle_dnd_message):
7497 Use ptrdiff_t, not size_t, since we prefer signed.
7498 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7499 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7500 x_dnd_atoms_size and x_dnd_atoms_length.
7502 * doprnt.c: Prefer signed to unsigned when either works.
7504 * doprnt.c (doprnt):
7506 * xdisp.c (vmessage):
7507 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7508 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7509 prefer signed arithmetic to avoid comparison confusion.
7510 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7511 but is a bit tricky.
7513 Assume freestanding C89 headers, string.h, stdlib.h.
7514 * data.c, doprnt.c, floatfns.c, print.c:
7515 Include float.h unconditionally.
7516 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7517 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7518 * regex.c: Likewise for stddef.h, string.h.
7519 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7520 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7521 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7522 (STDC_HEADERS): Remove obsolete defines.
7523 * sysdep.c: Include limits.h unconditionally.
7525 Assume support for memcmp, memcpy, memmove, memset.
7526 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7527 * regex.c (memcmp, memcpy):
7528 Remove; we assume C89 now.
7530 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7531 (__malloc_safe_bcopy): Remove; no longer needed.
7533 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7534 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7535 well either way, and we prefer signed to unsigned.
7537 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7539 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7540 closes the connection while we're reading (bug#9182).
7542 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7544 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7545 are specified (Bug#9168).
7547 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7549 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7550 Found by GCC static checking and --with-wide-int on a 32-bit host.
7552 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7554 * xdisp.c (compute_display_string_pos): Fix logic of caching
7555 previous display string position. Initialize cached_prev_pos to
7556 -1. Fixes slow-down at the beginning of a buffer.
7558 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7560 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7561 for attrs[LFACE_FONTSET_INDEX].
7563 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7565 * xml.c (parse_region): Remove unused local
7566 that was recently introduced.
7568 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7570 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7571 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7573 * xdisp.c (move_it_in_display_line_to): Record the best matching
7574 position for TO_CHARPOS while scanning the line, and restore it on
7575 exit if none of the characters scanned was an exact match.
7576 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7577 when exact match is impossible due to invisible text, and the
7578 lines are truncated.
7580 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7582 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7585 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7587 Fix a significant slow-down of cursor motion with C-n, C-p,
7588 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7589 auto-repeat under bidi redisplay in fontified buffers.
7590 * xdisp.c (compute_stop_pos_backwards): New function.
7591 (next_element_from_buffer): Call compute_stop_pos_backwards to
7592 find a suitable prev_stop when we find ourselves before
7594 (reseat): Don't look for prev_stop, as that could mean a very long
7596 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7597 <cached_disp_overlay_modiff>: Cache for last found display string
7599 (compute_display_string_pos): Return the cached position if asked
7600 about the same buffer in the same area of character positions, and
7601 the buffer wasn't changed since the time the display string
7602 position was cached.
7604 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7606 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7607 is an integer, which is important for empty lines. (Bug#9149)
7609 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7611 * frame.c (Fmodify_frame_parameters): In tty case, update the
7612 default face if necessary (Bug#4238).
7614 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7616 * editfns.c (Fstring_to_char): No need to explain what a character
7617 is in the docstring (Bug#6576).
7619 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7621 * xml.c (parse_region): Make sure we always return a tree.
7623 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7625 * xml.c (parse_region): If a document contains only comments,
7628 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7630 * xml.c (make_dom): Return comments, too.
7632 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7635 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7636 and the surrounding thread.
7637 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7638 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7639 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7641 * s/openbsd.h (BROKEN_SIGIO): Define.
7642 * unexelf.c (unexec) [__OpenBSD__]:
7643 Don't update the .mdebug section of the Alpha COFF symbol table.
7645 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7647 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7650 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7652 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7653 This fixes some race conditions on the permissions of any newly
7656 * alloc.c (valid_pointer_p): Use pipe, not open.
7657 This fixes some permissions issues when debugging.
7659 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7660 If fchown fails to set both uid and gid, try to set just gid,
7661 as that is sometimes allowed. Adjust the file's mode to eliminate
7662 setuid or setgid bits that are inappropriate if fchown fails.
7664 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7666 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7667 to compare Lisp_Objects.
7668 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7669 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7670 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7672 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7674 * lread.c (read_integer): Unread even EOF character.
7675 (read1): Likewise. Properly record start position of symbol.
7677 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7678 symbol character follows.
7680 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7682 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7683 This works around a problem with the previous change to Fcopy_file.
7684 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7685 and without this change, GCC might complain about discarding
7686 fchown's return value.
7688 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7690 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7692 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7694 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7696 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7698 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7699 it's used from the C level.
7701 * process.c: Use the same condition for POLL_FOR_INPUT in both
7702 keyboard.c and process.c (bug#1858).
7704 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7706 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7707 (Fgnutls_boot): Use it.
7709 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7711 * doc.c (Fsubstitute_command_keys): Revert last change.
7713 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7715 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7716 quotes the next character, and doesn't affect other longer
7717 sequences (bug#8935).
7719 * lread.c (syms_of_lread): Clarify that is isn't only
7720 `eval-buffer' and `eval-defun' that's affected by
7721 `lexical-binding' (bug#8460).
7723 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7725 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7726 bidi redisplay when a line includes both an image and is truncated.
7728 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7730 Fix minor problems found by static checking.
7731 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7732 (elsz): Now a signed constant, not a size_t var. We prefer signed
7733 types to unsigned, to avoid integer comparison confusion. Without
7734 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7735 "cannot optimize loop, the loop counter may overflow", a symptom
7737 * indent.c (Fvertical_motion): Mark locals as initialized.
7738 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7740 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7742 * search.c (Fre_search_backward): Mention `case-fold-search' in
7743 all the re_search_* functions (bug#8138).
7745 * keyboard.c (Fopen_dribble_file): Document when the file is
7748 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7750 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7753 Support bidi reordering of display and overlay strings.
7754 * xdisp.c (compute_display_string_pos)
7755 (compute_display_string_end): Accept additional argument STRING.
7756 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7757 (reseat_to_string): Initialize bidi_it->string.s and
7758 bidi_it->string.schars.
7759 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7760 NULL (avoids a crash in bidi_paragraph_init).
7761 Initialize itb.string.lstring.
7762 (init_iterator): Call bidi_init_it only of a valid
7763 buffer position was specified. Initialize paragraph_embedding to
7765 (reseat_to_string): Initialize the bidi iterator.
7766 (display_string): If we need to ignore text properties of
7767 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7768 original value of -1 will not work with bidi.)
7769 (compute_display_string_pos): First arg is now struct
7770 `text_pos *'; all callers changed. Support display properties on
7772 (compute_display_string_end): Support display properties on Lisp
7774 (init_iterator, reseat_1, reseat_to_string): Initialize the
7775 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7776 when iterating on a string not from display properties).
7777 (compute_display_string_pos, compute_display_string_end):
7778 Fix calculation of the object to scan. Fixes an error when using
7780 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7781 base_level_stop; instead, set base_level_stop to BEGV.
7782 Fixes crashes in vertical-motion.
7783 (next_element_from_buffer): Improve commentary for when
7784 the iterator is before prev_stop.
7785 (init_iterator): Initialize bidi_p from the default value of
7786 bidi-display-reordering, not from buffer-local value. Use the
7787 buffer-local value only if initializing for buffer iteration.
7788 (handle_invisible_prop): Support invisible properties on strings
7789 that are being bidi-reordered.
7790 (set_iterator_to_next): Support bidi reordering of C strings and
7792 (next_element_from_string): Support bidi reordering of Lisp
7794 (handle_stop_backwards): Support Lisp strings as well.
7795 (display_string): Support display of R2L glyph rows.
7796 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7797 (init_iterator): Don't initialize it->bidi_p for strings
7799 (reseat_to_string): Initialize it->bidi_p for strings here.
7800 (next_element_from_string, next_element_from_c_string)
7801 (next_element_from_buffer): Add xassert's for correspondence
7802 between IT's object being iterated and it->bidi_it.string
7804 (face_before_or_after_it_pos): Support bidi iteration.
7805 (next_element_from_c_string): Handle the case of the first string
7806 character that is not the first one in the visual order.
7807 (get_visually_first_element): New function, refactored from common
7808 parts of next_element_from_buffer, next_element_from_string, and
7809 next_element_from_c_string.
7810 (tool_bar_lines_needed, redisplay_tool_bar)
7811 (display_menu_bar): Force left-to-right direction. Add a FIXME
7812 comment for making that be controlled by a user option.
7813 (push_it, pop_it): Save and restore the state of the
7814 bidi iterator. Save and restore the bidi_p flag.
7815 (pop_it): Iterate out of display property for string iteration as
7817 (iterate_out_of_display_property): Support iteration over strings.
7818 (handle_single_display_spec): Set up it->bidi_it for iteration
7819 over a display string, and call bidi_init_it.
7820 (handle_single_display_spec, next_overlay_string)
7821 (get_overlay_strings_1, push_display_prop): Set up the bidi
7822 iterator for displaying display or overlay strings.
7823 (forward_to_next_line_start): Don't use the shortcut if
7825 (back_to_previous_visible_line_start): If handle_display_prop
7826 pushed the iterator stack, restore the internal state of the bidi
7827 iterator by calling bidi_pop_it same number of times.
7828 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7829 and we are bidi-iterating, don't decrement the iterator position;
7830 instead, set the first_elt flag in the bidi iterator, to produce
7832 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7833 (push_display_prop): xassert that we are iterating a buffer.
7834 (push_it, pop_it): Save and restore paragraph_embedding member.
7835 (handle_single_display_spec, next_overlay_string)
7836 (get_overlay_strings_1, reseat_1, reseat_to_string)
7837 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7838 correctly. Don't assume unibyte strings are not bidi-reordered.
7839 (compute_display_string_pos)
7840 (compute_display_string_end): Fix handling the case of C string.
7841 (push_it, pop_it): Save and restore from_disp_prop_p.
7842 (handle_single_display_spec, push_display_prop): Set the
7843 from_disp_prop_p flag.
7844 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7845 (pop_it): Call iterate_out_of_display_property only if we are
7846 popping after iteration over a string that came from a display
7847 property. Fix a typo in popping stretch info. Add an assertion
7848 for verifying that the iterator position is in sync with the bidi
7850 (handle_single_display_spec, get_overlay_strings_1)
7851 (push_display_prop): Fix initialization of paragraph direction for
7852 string when that of the parent object is not yet determined.
7853 (reseat_1): Call bidi_init_it to resync the bidi
7854 iterator with IT's position. (Bug#7616)
7855 (find_row_edges): If ROW->start.pos gives position
7856 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7857 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7858 Reset the from_disp_prop_p flag.
7859 (SAVE_IT, RESTORE_IT): New macros.
7860 (pos_visible_p, face_before_or_after_it_pos)
7861 (back_to_previous_visible_line_start)
7862 (move_it_in_display_line_to, move_it_in_display_line)
7863 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7864 (try_scrolling, redisplay_window, display_line): Use them when
7865 saving a temporary copy of the iterator and restoring it back.
7866 (back_to_previous_visible_line_start, reseat_1)
7867 (init_iterator): Empty the bidi cache "stack".
7868 (move_it_in_display_line_to): If iterator ended up at
7869 EOL, but we never saw any buffer positions smaller than
7870 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7871 motion in bidi-reordered lines.
7872 (move_it_in_display_line_to): Record prev_method and prev_pos
7873 immediately before the call to set_iterator_to_next. Fixes cursor
7874 motion in bidi-reordered lines with stretch glyphs and strings
7875 displayed in margins. (Bug#8133) (Bug#8867)
7876 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7878 (pos_visible_p): Support positions in bidi-reordered lines.
7879 Save and restore bidi cache.
7881 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7882 (bidi_paragraph_info): Delete unused struct.
7883 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7884 (bidi_cache_start): New variable.
7885 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7887 (bidi_cache_fetch_state, bidi_cache_search)
7888 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7889 (bidi_cache_find, bidi_peek_at_next_level)
7890 (bidi_level_of_next_char, bidi_find_other_level_edge)
7891 (bidi_move_to_visually_next): Compare cache index with
7892 bidi_cache_start rather than with zero.
7893 (bidi_fetch_char): Accept new argument STRING; all callers
7894 changed. Support iteration over a string. Support strings with
7895 display properties. Support unibyte strings. Fix the type of
7896 `len' according to what STRING_CHAR_AND_LENGTH expects.
7897 (bidi_paragraph_init, bidi_resolve_explicit_1)
7898 (bidi_resolve_explicit, bidi_resolve_weak)
7899 (bidi_level_of_next_char, bidi_move_to_visually_next):
7900 Support iteration over a string.
7901 (bidi_set_sor_type, bidi_resolve_explicit_1)
7902 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7903 can now be zero (for strings); special values 0 and -1 were
7904 changed to -1 and -2, respectively.
7905 (bidi_char_at_pos): New function.
7906 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7907 Call it instead of FETCH_MULTIBYTE_CHAR.
7908 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7909 initialized to valid values.
7910 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7912 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7913 the test for valid cached positions. Fix the logic for looking up
7914 the sentinel state in the cache. GCPRO the Lisp string we are
7916 (bidi_push_it, bidi_pop_it): New functions.
7917 (bidi_initialize): Initialize the bidi cache start stack pointer.
7918 (bidi_cache_ensure_space): New function, refactored from part of
7919 bidi_cache_iterator_state. Don't assume the required size is just
7920 one BIDI_CACHE_CHUNK away.
7921 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7922 (bidi_count_bytes, bidi_char_at_pos): New functions.
7923 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7924 always valid if bidi_cache_idx is valid.
7925 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7926 is valid if it's going to be used.
7927 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7928 (bidi_cache_fetch_state, bidi_cache_search)
7929 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7930 (bidi_cache_iterator_state, bidi_cache_find)
7931 (bidi_find_other_level_edge, bidi_cache_start_stack):
7932 All variables related to cache indices are now EMACS_INT.
7934 * dispextern.h (struct bidi_string_data): New structure.
7935 (struct bidi_it): New member `string'. Make flag members be 1-bit
7936 fields, and put them last in the struct.
7937 (compute_display_string_pos, compute_display_string_end):
7939 (bidi_push_it, bidi_pop_it): Add prototypes.
7940 (struct iterator_stack_entry): New members bidi_p,
7941 paragraph_embedding, and from_disp_prop_p.
7942 (struct it): Member bidi_p is now a bit field 1 bit wide.
7943 (bidi_shelve_cache, bidi_unshelve_cache):
7946 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7947 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7948 and vector-like objects.
7950 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7951 cache around display iteration.
7953 * window.c (Fwindow_end, window_scroll_pixel_based)
7954 (displayed_window_lines, Frecenter): Save and restore the bidi
7955 cache around display iteration.
7957 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7959 * editfns.c (Fdelete_region): Clarify the use of the named
7960 parameters (bug#6788).
7962 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7964 * indent.c (Fvertical_motion): Set and restore w->pointm when
7965 saving and restoring the window's buffer (Bug#9006).
7967 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7969 * editfns.c (Fstring_to_char): Clarify just what is returned
7970 (bug#6576). Text by Eli Zaretskii.
7972 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7974 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7976 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7978 * buffer.c (mmap_find): Fix a typo.
7980 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7982 Fix execution of x selection hooks.
7983 * xselect.c (Qx_lost_selection_functions)
7984 (Qx_sent_selection_functions): New vars.
7985 (syms_of_xselect): DEFSYM them.
7986 (x_handle_selection_request): Pass Qx_sent_selection_functions
7987 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7988 (x_handle_selection_clear,x_clear_frame_selections):
7989 Pass Qx_lost_selection_functions rather than
7990 Vx_lost_selection_functions to Frun_hook_with_args.
7992 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7994 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7995 The old code sometimes used this field without initializing it.
7997 * alloc.c (gc_sweep): Don't read past end of array.
7998 In theory, the old code could also have corrupted Emacs internals,
7999 though it'd be very unlikely.
8001 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8003 * character.c (Fcharacterp): Don't advertise optional ignored
8004 argument. (Bug#4026)
8006 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8008 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8011 * window.c (Fset_window_start): Doc fix (bug#4199).
8012 (Fset_window_hscroll): Ditto.
8014 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8016 Fix minor new problems caught by GCC 4.6.1.
8017 * term.c (init_tty): Remove unused local.
8018 * xsettings.c (store_monospaced_changed): Define this function only
8019 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8022 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8024 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8026 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8028 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8029 are the mini-buffer and the echo area (bug#3320).
8031 * term.c (init_tty): Remove support for supdup, c10 and perq
8032 terminals, which are no longer supported (bug#1482).
8034 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8036 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8038 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8040 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8041 for non-popups (Bug#3642).
8043 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8045 * alloc.c (reset_malloc_hooks): Protoize.
8046 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8047 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8048 * cm.c (losecursor): Likewise.
8049 * data.c (fmod): Likewise.
8050 * dispnew.c (swap_glyphs_in_rows): Likewise.
8051 * emacs.c (memory_warning_signal): Likewise.
8052 * floatfns.c (float_error): Likewise.
8053 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8054 (otf_open, font_otf_capability, generate_otf_features)
8055 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8057 * image.c (pbm_read_file): Likewise.
8058 * indent.c (string_display_width): Likewise.
8059 * intervals.c (check_for_interval, search_for_interval)
8060 (inc_interval_count, count_intervals, root_interval)
8061 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8062 * lread.c (defalias): Likewise.
8063 * ralloc.c (r_alloc_check): Likewise.
8064 * regex.c (set_image_of_range_1, set_image_of_range)
8065 (regex_grow_registers): Likewise.
8066 * sysdep.c (strerror): Likewise.
8067 * termcap.c (valid_filename_p, tprint, main): Likewise.
8068 * tparam.c (main): Likewise.
8069 * unexhp9k800.c (run_time_remap, save_data_space)
8070 (update_file_ptrs, read_header, write_header, calculate_checksum)
8071 (copy_file, copy_rest, display_header): Likewise.
8072 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8074 * xdisp.c (check_it): Likewise.
8075 * xfaces.c (register_color, unregister_color, unregister_colors):
8077 * xfns.c (print_fontset_result): Likewise.
8078 * xrdb.c (member, fatal, main): Likewise.
8080 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8082 Fix minor problems found by static checking (Bug#9031).
8083 * chartab.c (char_table_set_range, map_sub_char_table):
8084 Remove unused locals.
8085 (uniprop_table): Now static.
8086 * composite.c (_work_char): Remove unused static var.
8088 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8090 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8092 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8094 * gtkutil.c (qttip_cb): Remove code without function.
8096 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8098 * w32.c (pthread_sigmask): New stub.
8100 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8102 Use pthread_sigmask, not sigprocmask (Bug#9010).
8103 sigprocmask is portable only for single-threaded applications, and
8104 Emacs can be multi-threaded when it uses GTK.
8105 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8107 * callproc.c (Fcall_process):
8108 * process.c (create_process):
8109 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8110 Use pthread_sigmask, not sigprocmask.
8112 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8114 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8115 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8118 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8120 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8121 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8122 (xg_hide_tooltip): Fix comment.
8124 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8125 in registerServicesMenuSendTypes.
8126 (validRequestorForSendType): Don't check ns_return_types.
8128 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8131 2011-07-08 Jason Rumney <jasonr@gnu.org>
8133 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8134 SH_SHOW for hidden windows (Bug#5482).
8136 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8137 frame struct members of non-existent frames (Bug#6284).
8139 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8141 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8142 variable firstTime not needed on OSX >= 10.6.
8143 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8144 >= 10.5. Use setKnobProportion, setDoubleValue.
8146 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8147 (MAC_OS_X_VERSION_10_5): Define if not defined.
8148 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8149 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8150 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8152 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8153 cString and lossyCString on OSX >= 10.4.
8155 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8156 sizeToFit on OSX >= 10.2.
8158 * nsimage.m (allocInitFromFile): Don't use deprecated method
8159 bestRepresentationForDevice on OSX >= 10.6.
8161 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8164 * emacs.c: Declare unexec_init_emacs_zone.
8166 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8168 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8170 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8171 on svcsMenu (Bug#8842).
8173 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8175 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8177 * nsterm.m (QUTF8_STRING): Declare.
8178 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8179 (validRequestorForSendType): Return type is (id).
8180 Change indexOfObjectIdenticalTo to indexOfObject.
8181 Check if we have local selection before returning self (Bug#8842).
8182 (writeSelectionToPasteboard): Put local selection into paste board
8183 if we have a local selection (Bug#8842).
8184 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8186 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8187 (ns_get_local_selection): Declare.
8189 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8191 * keymap.c (describe_map_tree): Don't insert a double newline at
8192 the end of the buffer (bug#1169) and return whether we inserted
8195 * callint.c (Fcall_interactively): Change "reading args" to
8196 "providing args" to try to clarify what it does (bug#1010).
8198 2011-07-07 Kenichi Handa <handa@m17n.org>
8200 * composite.c (composition_compute_stop_pos): Ignore a static
8201 composition starting before CHARPOS (Bug#8915).
8203 * xdisp.c (handle_composition_prop): Likewise.
8205 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8207 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8210 2011-07-07 Kenichi Handa <handa@m17n.org>
8212 * character.h (unicode_category_t): New enum type.
8214 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8215 (Qchar_code_property_table): New variable.
8216 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8217 (UNIPROP_COMPRESSED_FORM_P): New macros.
8218 (char_table_ascii): Uncompress the compressed values.
8219 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8220 Uncompress the compressed values.
8221 (sub_char_table_ref_and_range): Likewise.
8222 (char_table_ref_and_range): Uncompress the compressed values.
8223 (sub_char_table_set): New arg is_uniprop. Callers changed.
8224 Uncompress the compressed values.
8225 (sub_char_table_set_range): Args changed. Callers changed.
8226 (char_table_set_range): Adjuted for the above change.
8227 (map_sub_char_table): Delete args default_val and parent. Add arg
8228 top. Give decoded values to a Lisp function.
8229 (map_char_table): Adjust for the above change. Give decoded
8230 values to a Lisp function. Gcpro more variables.
8231 (uniprop_table_uncompress)
8232 (uniprop_decode_value_run_length): New functions.
8233 (uniprop_decoder, uniprop_decoder_count): New variables.
8234 (uniprop_get_decoder, uniprop_encode_value_character)
8235 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8237 (uniprop_encoder, uniprop_encoder_count): New variables.
8238 (uniprop_get_encoder, uniprop_table)
8239 (Funicode_property_table_internal, Fget_unicode_property_internal)
8240 (Fput_unicode_property_internal): New functions.
8241 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8242 Sunicode_property_table_internal, Sget_unicode_property_internal,
8243 and Sput_unicode_property_internal. Defvar_lisp
8244 char-code-property-alist.
8246 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8247 Vunicode_category_table.
8249 * font.c (font_range): Adjust for the change of
8250 Vunicode_category_table.
8252 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8254 * m/iris4d.h: Remove file, move contents ...
8255 * s/irix6-5.h: ... here.
8257 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8259 Remove unportable assumption about struct layout (Bug#8884).
8260 * alloc.c (mark_buffer):
8261 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8262 (clone_per_buffer_values): Don't assume that
8263 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8264 This isn't true in general, and it's particularly not true
8265 if Emacs is configured with --with-wide-int.
8266 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8267 New macros, used in the buffer.c change.
8269 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8271 * xsettings.c: Use both GConf and GSettings if both are available.
8272 (store_config_changed_event): Add comment.
8273 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8274 (store_tool_bar_style_changed): New functions.
8275 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8276 (struct xsettings): Move font inside HAVE_XFT.
8277 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8278 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8279 Move inside HAVE_XFT.
8280 (something_changed_gsettingsCB): Rename from something_changedCB.
8281 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8283 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8284 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8285 (something_changed_gconfCB): Rename from something_changedCB.
8286 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8287 (parse_settings): Move check for font inside HAVE_XFT.
8288 (read_settings, apply_xft_settings): Add comment.
8289 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8290 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8291 call store_font_name_changed.
8292 (xft_settings_event): Add comment.
8293 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8294 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8295 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8296 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8297 (xsettings_initialize): Call init_gsettings last.
8298 (xsettings_get_system_font, xsettings_get_system_normal_font):
8301 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8303 Random fixes. E.g., (random) never returned negative values.
8304 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8305 subseconds part to the entropy, as that's a bit more random.
8306 Prefer signed to unsigned, since the signedness doesn't matter and
8307 in general we prefer signed. When given a limit, use a
8308 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8309 latter isn't right if USE_2_TAGS_FOR_INTS.
8310 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8311 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8313 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8315 * textprop.c (text_property_stickiness):
8316 Obey Vtext_property_default_nonsticky.
8317 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8318 * w32fns.c (syms_of_w32fns):
8319 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8321 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8323 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8324 This is more efficient than Ffile_directory_p and avoids a minor race.
8326 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8328 * buffer.c (Foverlay_put): Say what the return value is
8331 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8332 is a directory before asking whether to use the file name
8334 (barf_or_query_if_file_exists): Make the "File is a directory"
8335 error be more correct.
8337 * fns.c (Frequire): Remove the mention of the .gz files, since
8338 that's installation-specific, but keep the mention of
8339 `get-load-suffixes'.
8341 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8343 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8344 Report string overflow if the output is too long.
8346 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8348 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8349 (syms_of_gnutls): Remove duplicate DEFSYM for
8350 Qgnutls_bootprop_verify_hostname_error, an error for
8351 Qgnutls_bootprop_verify_error (which is no longer used).
8353 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8354 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8355 Also (re)move comments that are misplaced or no longer relevant.
8357 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8359 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8361 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8363 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8364 and background color parameters if they have been changed.
8366 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8368 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8370 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8372 * xsettings.c (SYSTEM_FONT): Define only when used.
8373 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8375 * keymap.c (access_keymap_1): Now static.
8377 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8379 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8380 leave any prefix arg for the up event (Bug#1586).
8382 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8384 * lread.c (syms_of_lread): Mention single symbols defined by
8385 `defvar' or `defconst' (bug#7154).
8387 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8388 (Frequire): Mention get-load-suffixes.
8390 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8392 * window.h (window): Remove clone_number slot.
8393 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8395 (make_parent_window, make_window, saved_window)
8396 (Fset_window_configuration, save_window_save): Don't deal with
8398 * buffer.c (Qclone_number): Remove declaration.
8399 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8401 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8403 Add multiple inheritance to keymaps.
8404 * keymap.c (Fmake_composed_keymap): New function.
8405 (Fset_keymap_parent): Simplify.
8406 (fix_submap_inheritance): Remove.
8407 (access_keymap_1): New function extracted from access_keymap to handle
8408 embedded parents and handle lists of maps.
8409 (access_keymap): Use it.
8410 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8411 (Fcopy_keymap): Handle embedded parents.
8412 (Fcommand_remapping, define_as_prefix): Simplify.
8413 (Fkey_binding): Simplify.
8414 (syms_of_keymap): Move minibuffer-local-completion-map,
8415 minibuffer-local-filename-completion-map,
8416 minibuffer-local-must-match-map, and
8417 minibuffer-local-filename-must-match-map to Elisp.
8418 (syms_of_keymap): Defsubr make-composed-keymap.
8419 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8420 (parse_menu_item): Trivial simplification.
8422 2011-07-01 Glenn Morris <rgm@gnu.org>
8424 * Makefile.in (SETTINGS_LIBS): Fix typo.
8426 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8428 * coding.c (Fencode_coding_string): Record the last coding system
8429 used, as the function doc string says (bug#8738).
8431 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8433 * xsettings.c (store_monospaced_changed): Take new font as arg and
8434 check for change against current_mono_font.
8435 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8436 (emacs_settings_constructor, emacs_settings_get_property)
8437 (emacs_settings_set_property, emacs_settings_class_init)
8438 (emacs_settings_init, gsettings_obj): Remove.
8439 (something_changedCB): New function for HAVE_GSETTINGS.
8440 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8441 with value as argument.
8442 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8443 g_settings_new (Bug#8967). Do not create gsettings_obj.
8444 Remove calls to g_settings_bind. Connect something_changedCB to
8447 * xgselect.c: Add defined (HAVE_GSETTINGS).
8448 (xgselect_initialize): Ditto.
8450 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8451 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8454 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8456 * eval.c (struct backtrace): Simplify and port the data structure.
8457 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8458 signed bit field, as this assumption is not portable and it makes
8459 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8460 "char debug_on_exit : 1" as this is not portable either; instead,
8461 use the portable "unsigned int debug_on_exit : 1". Remove unused
8462 member evalargs. Remove obsolete comments about cc bombing out.
8464 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8466 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8467 Let HAVE_GSETTINGS override HAVE_GCONF.
8468 (store_monospaced_changed): New function.
8469 (EMACS_SETTINGS): A new type derived from GObject to handle
8470 GSettings notifications.
8471 (emacs_settings_constructor, emacs_settings_get_property)
8472 (emacs_settings_set_property, emacs_settings_class_init):
8474 (gsettings_client, gsettings_obj): New variables.
8475 (GSETTINGS_SCHEMA): New define.
8476 (something_changedCB): Call store_monospaced_changed.
8477 (init_gsettings): New function.
8478 (xsettings_initialize): Call init_gsettings.
8479 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8482 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8485 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8487 * window.c (resize_root_window, grow_mini_window)
8488 (shrink_mini_window): Rename Qresize_root_window to
8489 Qwindow_resize_root_window and Qresize_root_window_vertically to
8490 Qwindow_resize_root_window_vertically.
8492 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8494 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8496 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8498 * makefile.w32-in: Redesign dependencies so they reflect more
8499 clearly which files are directly included by each source file,
8500 and not through other includes.
8502 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8504 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8505 (sort_overlays, overlay_strings): When an overlay's clone number
8506 matches the window's clone number process the overlay even if
8507 the overlay's window property doesn't match the current window.
8509 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8510 (Fwindow_hchild): Rename to Fwindow_left_child.
8511 (Fwindow_next): Rename to Fwindow_next_sibling.
8512 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8513 (resize_window_check): Rename to window_resize_check.
8514 (resize_window_apply): Rename to window_resize_apply.
8515 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8516 (Fdelete_other_windows_internal, resize_frame_windows)
8517 (Fsplit_window_internal, Fdelete_window_internal)
8518 (grow_mini_window, shrink_mini_window)
8519 (Fresize_mini_window_internal): Fix callers accordingly.
8521 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8523 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8524 (emacs_fixed_set_min_size): Remove.
8525 (emacs_fixed_new): Take frame as argument.
8527 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8528 (_EmacsFixedPrivate): Remove minwidth/height.
8529 Add struct frame *f.
8530 (emacs_fixed_init): Initialize priv->f.
8531 (get_parent_class, emacs_fixed_set_min_size): Remove.
8532 (emacs_fixed_new): Set priv->f to argument.
8533 (emacs_fixed_get_preferred_width)
8534 (emacs_fixed_get_preferred_height): Use min_width/height from
8535 frames size_hint to set minimum and natural (Bug#8919).
8536 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8537 and use min_width/height from frames size_hint to set
8538 min_width/height (Bug#8919).
8540 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8541 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8544 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8546 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8547 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8550 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8552 * process.c (wait_reading_process_output): Bypass select if
8553 waiting for a cell while ignoring keyboard input, and input is
8554 pending. Suggested by Jan Djärv (Bug#8869).
8556 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8558 Use gnulib's dup2 module instead of rolling our own.
8559 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8561 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8563 * dispnew.c (scrolling_window): Before scrolling, turn off a
8564 mouse-highlight in the window being scrolled.
8566 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8568 Move DEFSYM to lisp.h and use everywhere.
8570 * character.h (DEFSYM): Move declaration...
8571 * lisp.h (DEFSYM): ...here.
8577 * w32select.c: Don't include character.h.
8579 * alloc.c (syms_of_alloc):
8580 * buffer.c (syms_of_buffer):
8581 * bytecode.c (syms_of_bytecode):
8582 * callint.c (syms_of_callint):
8583 * casefiddle.c (syms_of_casefiddle):
8584 * casetab.c (init_casetab_once):
8585 * category.c (init_category_once, syms_of_category):
8586 * ccl.c (syms_of_ccl):
8587 * cmds.c (syms_of_cmds):
8588 * composite.c (syms_of_composite):
8589 * dbusbind.c (syms_of_dbusbind):
8590 * dired.c (syms_of_dired):
8591 * dispnew.c (syms_of_display):
8592 * doc.c (syms_of_doc):
8593 * editfns.c (syms_of_editfns):
8594 * emacs.c (syms_of_emacs):
8595 * eval.c (syms_of_eval):
8596 * fileio.c (syms_of_fileio):
8597 * fns.c (syms_of_fns):
8598 * frame.c (syms_of_frame):
8599 * fringe.c (syms_of_fringe):
8600 * insdel.c (syms_of_insdel):
8601 * keymap.c (syms_of_keymap):
8602 * lread.c (init_obarray, syms_of_lread):
8603 * macros.c (syms_of_macros):
8604 * msdos.c (syms_of_msdos):
8605 * print.c (syms_of_print):
8606 * process.c (syms_of_process):
8607 * search.c (syms_of_search):
8608 * sound.c (syms_of_sound):
8609 * syntax.c (init_syntax_once, syms_of_syntax):
8610 * terminal.c (syms_of_terminal):
8611 * textprop.c (syms_of_textprop):
8612 * undo.c (syms_of_undo):
8613 * w32.c (globals_of_w32):
8614 * window.c (syms_of_window):
8615 * xdisp.c (syms_of_xdisp):
8616 * xfaces.c (syms_of_xfaces):
8617 * xfns.c (syms_of_xfns):
8618 * xmenu.c (syms_of_xmenu):
8619 * xsettings.c (syms_of_xsettings):
8620 * xterm.c (syms_of_xterm): Use DEFSYM.
8622 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8624 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8626 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8628 Integer and buffer overflow fixes (Bug#8873).
8630 * print.c (printchar, strout): Check for string overflow.
8631 (PRINTPREPARE, printchar, strout):
8632 Don't set size unless allocation succeeds.
8634 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8635 for sizes. Check for string overflow more accurately.
8636 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8638 * macros.c: Integer and buffer overflow fixes.
8639 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8640 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8641 Use ptrdiff_t, not int, for sizes.
8642 Don't increment bufsize until after realloc succeeds.
8643 Check for size-calculation overflow.
8644 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8646 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8648 * lread.c: Integer overflow fixes.
8649 (read_integer): Radix is now EMACS_INT, not int,
8650 to improve quality of diagnostics for out-of-range radices.
8651 Calculate buffer size correctly for out-of-range radices.
8652 (read1): Check for integer overflow in radices, and in
8653 read-circle numbers.
8654 (read_escape): Avoid int overflow.
8655 (Fload, openp, read_buffer_size, read1)
8656 (substitute_object_recurse, read_vector, read_list, map_obarray):
8657 Use ptrdiff_t, not int, for sizes.
8658 (read1): Use EMACS_INT, not int, for sizes.
8659 Check for size overflow.
8661 * image.c (cache_image): Check for size arithmetic overflow.
8663 * lread.c: Integer overflow issues.
8664 (saved_doc_string_size, saved_doc_string_length)
8665 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8666 Now ptrdiff_t, not int.
8667 (read1): Don't assume doc string length fits in int. Check for
8668 out-of-range doc string lengths.
8669 (read_list): Don't assume file position fits in int.
8670 (read_escape): Check for hex character overflow.
8672 2011-06-22 Leo Liu <sdl.web@gmail.com>
8674 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8675 Move to minibuffer.el.
8677 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8679 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8680 The following patches are for when GLYPH_DEBUG && !XASSERT.
8681 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8682 * dispnew.c (flush_stdout):
8683 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8684 Mark as externally visible.
8685 * dispnew.c (check_window_matrix_pointers): Now static.
8686 * dispnew.c (window_to_frame_vpos):
8687 * xfns.c (unwind_create_frame):
8688 * xterm.c (x_check_font): Remove unused local.
8689 * scroll.c (CHECK_BOUNDS):
8690 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8691 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8692 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8693 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8694 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8696 (debug_method_add): Use va_list and vsprintf rather than relying
8697 on undefined behavior with wrong number of arguments.
8698 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8699 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8700 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8701 since we're not interested in debugging glyphs with old libraries.
8702 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8703 GCC 4.6.0's static checking.
8705 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8707 Integer overflow and signedness fixes (Bug#8873).
8708 A few related buffer overrun fixes, too.
8710 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8712 * dispextern.h (struct face.stipple):
8713 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8714 (x_bitmap_mask, x_allocate_bitmap_record)
8715 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8716 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8717 (x_create_bitmap_from_xpm_data):
8718 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8719 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8721 * xfaces.c (load_pixmap):
8722 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8723 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8724 (.bitmaps_last, struct x_output.icon_bitmap):
8725 Use ptrdiff_t, not int, for bitmap indexes.
8726 (x_allocate_bitmap_record): Check for size overflow.
8727 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8729 Use ptrdiff_t, not int, for overlay counts.
8730 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8731 * editfns.c (overlays_around, get_pos_property):
8732 * textprop.c (get_char_property_and_overlay):
8733 * xdisp.c (next_overlay_change, note_mouse_highlight):
8734 * xfaces.c (face_at_buffer_position):
8735 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8736 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8737 (Fnext_overlay_change, Fprevious_overlay_change)
8738 (mouse_face_overlay_overlaps, Foverlays_in):
8739 Use ptrdiff_t, not int, for sizes.
8740 (overlays_at, overlays_in): Check for size-calculation overflow.
8742 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8744 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8745 (x_session_initialize): Do not assume string length fits in int.
8747 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8748 This is unlikely, but can occur if DPI is outlandish.
8750 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8751 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8753 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8754 * xrdb.c (magic_file_p, search_magic_path):
8755 Omit last arg SUFFIX; it was always 0. All callers changed.
8756 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8758 * xfont.c (xfont_match): Avoid need for strlen.
8760 * xfns.c: Don't assume strlen fits in int.
8761 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8763 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8764 not unsigned long, as we prefer signed integers. All callers changed.
8765 Detect integer overflow in repeat count.
8766 (message_dolog): Don't assume print length fits in 39 bytes.
8767 (display_mode_element): Don't assume strlen fits in int.
8769 * termcap.c: Don't assume sizes fit in int and never overflow.
8770 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8771 (gobble_line): Check for size-calculation overflow.
8773 * minibuf.c (Fread_buffer):
8774 * lread.c (intern, intern_c_string):
8775 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8776 Don't assume string length fits in int.
8778 * keyboard.c (parse_tool_bar_item):
8779 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8781 * font.c: Don't assume string length fits in int.
8782 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8783 Use ptrdiff_t, not int.
8784 (font_intern_prop): Don't assume string length fits in int.
8785 Don't assume integer property fits in fixnum.
8786 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8788 * filelock.c: Fix some buffer overrun and integer overflow issues.
8789 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8790 Reformulate so as not to need the command string.
8791 Invoke gzip -cd rather than gunzip, as it's more portable.
8792 (lock_info_type, lock_file_1, lock_file):
8793 Don't assume pid_t and time_t fit in unsigned long.
8794 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8795 (current_lock_owner): Prefer signed type for sizes.
8796 Use memcpy, not strncpy, where memcpy is what is really wanted.
8797 Don't assume (via atoi) that time_t and pid_t fit in int.
8798 Check for time_t and/or pid_t out of range, e.g., via a network share.
8799 Don't alloca where an auto var works fine.
8801 * fileio.c: Fix some integer overflow issues.
8802 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8803 Don't assume string length fits in int.
8804 (directory_file_name): Don't assume string length fits in long.
8805 (make_temp_name): Don't assume pid fits in int, or that its print
8806 length is less than 20.
8808 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8810 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8812 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8814 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8815 We prefer signed integers, even for size calculations.
8817 * emacs.c: Don't assume string length fits in 'int'.
8818 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8819 (main): Don't invoke strlen when not needed.
8821 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8822 (XD_DEBUG_MESSAGE): Don't waste a byte.
8824 * callproc.c (getenv_internal_1, getenv_internal)
8826 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8828 * lread.c (invalid_syntax): Omit length argument.
8829 All uses changed. This doesn't fix a bug, but it simplifies the
8830 code away from its former Hollerith-constant appearance, and it's
8831 one less 'int' to worry about when looking at integer-overflow issues.
8832 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8834 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8835 This didn't break anything, but it didn't help either.
8836 It's confusing to put a bogus integer in a place where the actual
8837 value does not matter.
8838 (LIST_END_P): Remove unused macro and its bogus comment.
8839 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8841 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8842 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8844 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8845 We prefer signed types, and the value cannot exceed the EMACS_INT
8846 range anyway (because otherwise the length would not be representable).
8847 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8848 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8849 This avoids a GCC warning when WIDE_EMACS_INT.
8851 * indent.c (sane_tab_width): New function.
8852 (current_column, scan_for_column, Findent_to, position_indentation)
8853 (compute_motion): Use it. This is just for clarity.
8854 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8856 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8858 * lisp.h (lint_assume): New macro.
8859 * composite.c (composition_gstring_put_cache):
8860 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8862 * editfns.c, insdel.c:
8863 Omit unnecessary forward decls, to simplify future changes.
8865 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8867 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8869 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8870 Use much-faster test for byte-length change.
8871 Don't assume string byte-length fits in 'int'.
8872 Check that character arg fits in 'int'.
8873 (mapcar1): Declare byte as byte, for clarity.
8875 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8877 * fns.c (concat): Catch string overflow earlier.
8878 Do not rely on integer wraparound.
8880 * dispextern.h (struct it.overlay_strings_charpos)
8881 (struct it.selective): Now EMACS_INT, not int.
8882 * xdisp.c (forward_to_next_line_start)
8883 (back_to_previous_visible_line_start)
8884 (reseat_at_next_visible_line_start, next_element_from_buffer):
8885 Don't arbitrarily truncate the value of 'selective' to int.
8887 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8889 * composite.c: Don't truncate sizes to 'int'.
8890 (composition_gstring_p, composition_reseat_it)
8891 (composition_adjust_point): Use EMACS_INT, not int.
8892 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8893 not EMACS_UINT, for indexes.
8895 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8897 * buffer.c: Include <verify.h>.
8898 (struct sortvec.priority, struct sortstr.priority):
8899 Now EMACS_INT, not int.
8900 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8901 (struct sortstr.size, record_overlay_string)
8902 (struct sortstrlist.size, struct sortlist.used):
8903 Don't truncate size to int.
8904 (record_overlay_string): Check for size-calculation overflow.
8905 (init_buffer_once): Check at compile-time, not run-time.
8907 2011-06-22 Jim Meyering <meyering@redhat.com>
8909 Don't leak an XBM-image-sized buffer
8910 * image.c (xbm_load): Free the image buffer after using it.
8912 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8915 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8916 that Sun C diagnosed.
8917 * fns.c (secure_hash): Fix pointer signedness issue.
8918 * intervals.c (static_offset_intervals): New function.
8919 (offset_intervals): Use it.
8921 2011-06-21 Leo Liu <sdl.web@gmail.com>
8924 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8927 * fns.c (secure_hash): Rename from crypto_hash_function and change
8928 the first arg to accept symbols.
8929 (Fsecure_hash): New primitive.
8930 (syms_of_fns): New symbols.
8932 2011-06-20 Deniz Dogan <deniz@dogan.se>
8934 * process.c (Fset_process_buffer): Clarify return value in
8937 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8939 * dispnew.c (add_window_display_history): Use BVAR.
8941 * xdisp.c (debug_method_add): Use BVAR.
8942 (check_window_end, dump_glyph_matrix, dump_glyph)
8943 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8945 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8948 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8949 check till after the cache is created in init_frame_faces.
8951 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8953 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8955 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8957 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8958 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8959 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8961 Improve buffer-overflow checking (Bug#8873).
8962 * fileio.c (Finsert_file_contents):
8963 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8964 Remove the old (too-loose) buffer overflow checks.
8965 They weren't needed, since make_gap checks for buffer overflow.
8966 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8967 The old code merely checked for Emacs fixnum overflow, and relied
8968 on undefined (wraparound) behavior. The new code avoids undefined
8969 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8971 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8972 Tune. Don't use wider integers than needed. Don't use alloca.
8973 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8975 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8977 * insdel.c, lisp.h (buffer_overflow): New function.
8978 (insert_from_buffer_1, replace_range, replace_range_2):
8979 * insdel.c (make_gap_larger):
8980 * editfns.c (Finsert_char):
8981 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8983 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8985 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8987 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8989 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8990 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8992 * fileio.c: Don't assume EMACS_INT fits in off_t.
8993 (emacs_lseek): New static function.
8994 (Finsert_file_contents, Fwrite_region): Use it.
8995 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8997 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8999 * fns.c: Don't overflow int when computing a list length.
9000 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9001 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9002 truncation on 64-bit hosts. Check for QUIT every
9003 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9004 faster and is responsive enough.
9005 (Flength): Report an error instead of overflowing an integer.
9006 (Fsafe_length): Return a float if the value is not representable
9007 as a fixnum. This shouldn't happen except in contrived situations.
9008 (Fnthcdr, Fsort): Don't assume list length fits in int.
9009 (Fcopy_sequence): Don't assume vector length fits in int.
9011 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9012 (header_size, word_size): New constants.
9013 (allocate_vectorlike): Don't check size overflow here.
9014 (allocate_vector): Check it here instead, since this is the only
9015 caller of allocate_vectorlike that could cause overflow.
9016 Check that the new vector's length is representable as a fixnum.
9018 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9019 The previous code was bogus. For example, next_almost_prime (32)
9020 returned 39, which is undesirable as it is a multiple of 3; and
9021 next_almost_prime (24) returned 25, which is a multiple of 5 so
9022 why was the code bothering to check for multiples of 7?
9024 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9026 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9028 Variadic C functions now count arguments with ptrdiff_t.
9029 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9030 Back then I didn't know that the Emacs coding style prefers signed int.
9031 Also, in the meantime I found a few more instances where arguments
9032 were being counted with int, which may truncate counts on 64-bit
9033 machines, or EMACS_INT, which may be unnecessarily wide.
9034 * lisp.h (struct Lisp_Subr.function.aMANY)
9035 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9036 Arg counts are now ptrdiff_t, not size_t.
9037 All variadic functions and their callers changed accordingly.
9038 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9039 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9040 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9041 * callint.c (Fcall_interactively): Check arg count for overflow,
9042 to avoid potential buffer overrun. Use signed char, not 'int',
9043 for 'varies' array, so that we needn't bother to check its size
9044 calculation for overflow.
9045 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9046 * eval.c (apply_lambda):
9047 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9048 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9049 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9051 * callint.c (Fcall_interactively): Don't use index var as event count.
9053 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9054 * mem-limits.h (SIZE): Remove; no longer used.
9056 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9058 Remove unnecessary casts.
9059 * xterm.c (x_term_init):
9060 * xfns.c (x_set_border_pixel):
9061 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9062 These aren't needed now that we assume ANSI C.
9064 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9065 It's more likely to cause problems (due to unsigned overflow)
9068 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9070 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9072 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9074 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9076 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9078 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9080 GLYPH_CODE_FACE returns EMACS_INT, not int.
9081 * dispextern.h (merge_faces):
9082 * xfaces.c (merge_faces):
9083 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9084 Don't assume EMACS_INT fits in int.
9086 * character.h (CHAR_VALID_P): Remove unused parameter.
9087 * fontset.c, lisp.h, xdisp.c: All uses changed.
9089 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9091 * fns.c (concat): Minor tuning based on overflow analysis.
9092 This doesn't fix any bugs. Use int to hold character, instead
9093 of constantly refetching from Emacs object. Use XFASTINT, not
9094 XINT, for value known to be a character. Don't bother comparing
9095 a single byte to 0400, as it's always less.
9097 * floatfns.c (Fexpt):
9098 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9100 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9103 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9105 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9106 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9107 incorrectly succeed when S was a string, because 4294967386 was
9108 truncated before it was used.
9110 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9111 Otherwise, an out-of-range integer could cause undefined behavior
9114 * composite.c: Use int, not EMACS_INT, for characters.
9115 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9116 EMACS_INT, for values that are known to be in character range.
9117 This doesn't fix any bugs but is the usual style inside Emacs and
9118 may generate better code on 32-bit machines.
9120 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9121 This is for reasons similar to the recent CHAR_STRING fix.
9122 * charset.c (Fencode_char): Check that character arg is actually
9123 a character. Pass an int to ENCODE_CHAR.
9124 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9125 wider than 'int', as a compile-time check to prevent future regressions
9128 * character.c (char_string): Remove unnecessary casts.
9130 Make sure a 64-bit char is never passed to CHAR_STRING.
9131 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9132 by silently ignoring the top 32 bits, allowing some values
9133 that were far too large to be valid characters.
9134 * character.h: Include <verify.h>.
9135 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9136 arguments are no wider than unsigned, as a compile-time check
9137 to prevent future regressions in this area.
9139 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9140 (Fsubst_char_in_region):
9142 * xdisp.c (decode_mode_spec_coding):
9143 Adjust to CHAR_STRING's new requirement.
9144 * editfns.c (Finsert_char, Fsubst_char_in_region):
9145 * fns.c (concat): Check that character args are actually
9146 characters. Without this test, these functions did the wrong
9147 thing with wildly out-of-range values on 64-bit hosts.
9149 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9150 These casts should not be needed on 32-bit hosts, either.
9151 * keyboard.c (read_char):
9152 * lread.c (Fload): Remove casts to unsigned.
9154 * lisp.h (UNSIGNED_CMP): New macro.
9155 This fixes comparison bugs on 64-bit hosts.
9156 (ASCII_CHAR_P): Use it.
9157 * casefiddle.c (casify_object):
9158 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9159 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9160 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9161 * dispextern.h (FACE_FROM_ID):
9162 * keyboard.c (read_char): Use UNSIGNED_CMP.
9164 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9165 not to EMACS_INT, to avoid GCC warning.
9167 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9169 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9170 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9171 isn't needed on 32-bit machines.
9173 * buffer.c (Fgenerate_new_buffer_name):
9174 Use EMACS_INT for count, not int.
9175 (advance_to_char_boundary): Return EMACS_INT, not int.
9177 * data.c (Qcompiled_function): Now static.
9179 * window.c (window_body_lines): Now static.
9181 * image.c (gif_load): Rename local to avoid shadowing.
9183 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9184 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9185 * alloc.c (make_save_value): Integer argument is now of type
9187 (mark_object): Use ptrdiff_t, not int.
9188 * lisp.h (pD): New macro.
9189 * print.c (print_object): Use it.
9191 * alloc.c: Use EMACS_INT, not int, to count objects.
9192 (total_conses, total_markers, total_symbols, total_vector_size)
9193 (total_free_conses, total_free_markers, total_free_symbols)
9194 (total_free_floats, total_floats, total_free_intervals)
9195 (total_intervals, total_strings, total_free_strings):
9196 Now EMACS_INT, not int. All uses changed.
9197 (Fgarbage_collect): Compute overall total using a double, so that
9198 integer overflow is less likely to be a problem. Check for overflow
9199 when converting back to an integer.
9200 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9201 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9202 These were 'int' variables that could overflow on 64-bit hosts;
9203 they were never used, so remove them instead of repairing them.
9204 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9205 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9206 Previously, this ceilinged at INT_MAX, but that doesn't work on
9208 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9210 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9211 (allocate_vectorlike): Check for ptrdiff_t overflow.
9212 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9213 when a (possibly-narrower) signed value would do just as well.
9214 We prefer using signed arithmetic, to avoid comparison confusion.
9216 * alloc.c: Catch some string size overflows that we were missing.
9217 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9218 for convenience in STRING_BYTES_MAX.
9219 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9220 The definition here is exact; the one in lisp.h was approximate.
9221 (allocate_string_data): Check for string overflow. This catches
9222 some instances we weren't catching before. Also, it catches
9223 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9224 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9225 and ptrdiff_t and EMACS_INT are both 64 bits.
9227 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9228 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9229 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9231 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9233 * alloc.c (Fmake_string): Check for out-of-range init.
9235 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9237 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9239 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9241 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9242 xg_get_default_scrollbar_width.
9244 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9245 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9246 (style_changed_cb): Call update_theme_scrollbar_width and call
9247 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9248 all frames (Bug#8505).
9249 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9250 Call gtk_window_set_resizable if HAVE_GTK3.
9251 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9252 and height if HAVE_GTK3 (Bug#8505).
9253 (scroll_bar_width_for_theme): New variable.
9254 (update_theme_scrollbar_width): New function.
9255 (xg_get_default_scrollbar_width): Move code to
9256 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9257 (xg_initialize): Call update_theme_scrollbar_width.
9259 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9261 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9263 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9265 * frame.c (make_frame): Call other_buffer_safely instead of
9268 * window.c (temp_output_buffer_show): Call display_buffer with
9269 second argument Vtemp_buffer_show_specifiers and reset latter
9270 immediately after the call.
9271 (Vtemp_buffer_show_specifiers): New variable.
9272 (auto_window_vscroll_p, next_screen_context_lines)
9273 (Vscroll_preserve_screen_position): Remove leading asterisks from
9276 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9278 Fix minor problems found by GCC 4.6.0 static checking.
9279 * buffer.c (Qclone_number): Remove for now, as it's unused.
9280 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9281 (record_buffer): Remove unused local.
9282 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9283 (set_frame_buffer_list): Remove; unused.
9284 * frame.h (other_visible_frames): Remove decl.
9285 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9286 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9287 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9289 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9290 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9291 Define only if HAVE_GPM.
9292 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9293 (update_hints_inhibit): Remove; never set. All uses removed.
9294 * widgetprv.h (emacsFrameClassRec): Remove decl.
9295 * window.c (delete_deletable_window): Now returns void, since it
9296 wasn't returning anything.
9297 (compare_window_configurations): Remove unused locals.
9298 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9299 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9300 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9301 the same widths as pointers. This follows up on the 2011-05-06 patch.
9302 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9303 * xterm.h: Likewise.
9304 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9306 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9308 * makefile.w32-in: Update dependencies.
9309 (LISP_H): Add lib/intprops.h.
9311 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9313 * image.c (gif_load): Add animation frame delay to the metadata.
9314 (syms_of_image): Use DEFSYM. New symbol `delay'.
9316 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9318 * window.c (delete_deletable_window): Re-add.
9319 (Fset_window_configuration): Rewrite to handle dead buffers and
9320 consequently deletable windows.
9321 (window_tree, Fwindow_tree): Remove. Supply functionality in
9323 (compare_window_configurations): Simplify code.
9325 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9327 * image.c (imagemagick_load_image): Fix type mismatch.
9328 (Fimagemagick_types): Likewise.
9330 * window.h (replace_buffer_in_windows): Declare.
9332 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9334 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9335 Qclone_number. Remove external declaration of Qdelete_window.
9336 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9338 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9339 Run Qbuffer_list_update_hook if allowed.
9340 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9341 buffer list implementation.
9342 (other_buffer_safely): New function.
9343 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9344 calls to replace_buffer_in_windows and
9345 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9347 (record_buffer): Inhibit quitting and rewrite using quittable
9348 functions. Run Qbuffer_list_update_hook if allowed.
9349 (Frecord_buffer, Funrecord_buffer): New functions.
9350 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9351 Move switch-to-buffer to window.el.
9352 (bury-buffer): Move to window.el.
9353 (Vbuffer_list_update_hook): New variable.
9355 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9358 * window.h (resize_frame_windows): Move up in code.
9359 (Fwindow_frame): Remove EXFUN.
9360 (replace_buffer_in_all_windows): Remove prototype.
9361 (replace_buffer_in_windows_safely): Add prototype.
9363 * window.c: Declare Qdelete_window static again. Move down
9364 declaration of select_count.
9365 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9366 (Fother_window): Move to window.el.
9367 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9368 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9369 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9371 (replace_buffer_in_windows): Implement by calling
9372 Qreplace_buffer_in_windows.
9373 (replace_buffer_in_all_windows): Remove with some functionality
9374 moved into replace_buffer_in_windows_safely.
9375 (replace_buffer_in_windows_safely): New function.
9376 (select_window_norecord, select_frame_norecord): Move in front
9377 of run_window_configuration_change_hook. Remove now obsolete
9379 (Fset_window_buffer): Rewrite doc-string.
9380 Call Qrecord_window_buffer.
9381 (keys_of_window): Move binding for other-window to window.el.
9383 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9385 * dispextern.h (struct image): Replace data member, whose int_val
9386 and ptr_val fields were not used by anything, with a single
9389 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9390 (gif_clear_image, gif_load, imagemagick_load_image)
9391 (gs_clear_image, gs_load): Callers changed.
9393 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9395 * buffer.h: Include <time.h>, for time_t.
9396 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9398 Fix minor problems found by static checking.
9400 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9402 Make identifiers static if they are not used in other modules.
9403 * data.c (Qcompiled_function, Qframe, Qvector):
9404 * image.c (QimageMagick, Qsvg):
9405 * minibuf.c (Qmetadata):
9406 * window.c (resize_window_check, resize_root_window): Now static.
9407 * window.h (resize_window_check, resize_root_window): Remove decls.
9409 * window.c (window_deletion_count, delete_deletable_window):
9411 (window_body_lines): Now static.
9412 (Fdelete_other_windows_internal): Mark vars as initialized.
9413 Make sure 'resize_failed' is initialized.
9414 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9415 (resize_window_apply): Remove unused local.
9416 * window.h (delete_deletable_window): Remove decl.
9418 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9419 (imagemagick_load_image): Fix pointer signedness problem by changing
9420 last arg from unsigned char * to char *. All uses changed.
9421 Also, fix a local for similar reasons.
9422 Remove unused locals. Remove locals to avoid shadowing.
9423 (fn_rsvg_handle_free): Remove; unused.
9424 (svg_load, svg_load_image): Fix pointer signedness problem.
9425 (imagemagick_load_image): Don't use garbage pointer image_wand.
9427 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9429 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9431 * image.c (gif_load): Fix omitted cast error introduced by
9434 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9436 * window.h (resize_proportionally, orig_total_lines)
9437 (orig_top_line): Remove from window structure.
9438 (set_window_height, set_window_width, change_window_heights)
9439 (Fdelete_window): Remove prototypes.
9440 (resize_frame_windows): Remove duplicate declaration.
9442 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9444 * window.h (resize_frame_windows, resize_window_check)
9445 (delete_deletable_window, resize_root_window)
9446 (resize_frame_windows): Declare prototypes.
9448 * window.c (resize_window_apply): Make definition be "static" to
9449 match the prototype.
9451 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9453 * window.c: Remove declarations of Qwindow_size_fixed,
9454 window_min_size_1, window_min_size_2, window_min_size,
9455 size_window, window_fixed_size_p, enlarge_window, delete_window.
9456 Remove static from declaration of Qdelete_window, it's
9457 temporarily needed by Fbury_buffer.
9458 (replace_window): Don't assign orig_top_line and
9460 (Fdelete_window, delete_window): Remove. Window deletion is
9461 handled by window.el.
9462 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9463 Replace Fdelete_window calls with calls to Qdelete_window.
9464 (Fdelete_other_windows): Remove. Deleting other windows is
9465 handled by window.el.
9466 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9467 handled in window.el.
9468 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9469 Window minimum sizes are handled in window.el.
9470 (shrink_windows, size_window, set_window_height)
9471 (set_window_width, change_window_heights, window_height)
9472 (window_width, CURBEG, CURSIZE, enlarge_window)
9473 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9474 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9475 handled in window.el.
9476 (make_dummy_parent): Rename to make_parent_window and give it a
9477 second argument horflag.
9478 (make_window): Don't set resize_proportionally any more.
9479 (Fsplit_window): Remove. Windows are split in window.el.
9480 (save_restore_action, save_restore_orig_size)
9481 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9482 Resize mini windows in window.el.
9483 (grow_mini_window, shrink_mini_window): Implement by calling
9484 Qresize_root_window_vertically, resize_window_check and
9485 resize_window_apply.
9486 (saved_window, Fset_window_configuration, save_window_save):
9487 Do not handle orig_top_line, orig_total_lines, and
9488 resize_proportionally.
9489 (window_min_height, window_min_width): Move to window.el.
9490 (keys_of_window): Move bindings for delete-other-windows,
9491 split-window, delete-window and enlarge-window to window.el.
9493 * buffer.c: Temporarily extern Qdelete_window.
9494 (Fbury_buffer): Temporarily call Qdelete_window instead of
9495 Fdelete_window (Fbury_buffer will move to window.el soon).
9497 * frame.c (set_menu_bar_lines_1): Remove code handling
9498 orig_top_line and orig_total_lines.
9500 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9501 set_window_height but set heights directly.
9502 (change_frame_size_1): Use resize_frame_windows.
9504 * xdisp.c (init_xdisp): Don't use set_window_height but set
9507 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9508 Use resize_frame_windows instead of change_window_heights and run
9509 run_window_configuration_change_hook.
9511 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9512 instead of change_window_heights and run
9513 run_window_configuration_change_hook.
9515 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9517 * window.c (replace_window): Rename second argument REPLACEMENT to
9518 NEW. New third argument SETFLAG. Rewrite.
9519 (delete_window, make_dummy_parent): Call replace_window with
9521 (window_list_1): Move down in code.
9522 (run_window_configuration_change_hook): Move set_buffer part
9523 before select_frame_norecord part in order to unwind correctly.
9524 Rename count1 to count.
9525 (recombine_windows, delete_deletable_window, resize_root_window)
9526 (Fdelete_other_windows_internal)
9527 (Frun_window_configuration_change_hook, make_parent_window)
9528 (resize_window_check, resize_window_apply, Fresize_window_apply)
9529 (resize_frame_windows, Fsplit_window_internal)
9530 (Fdelete_window_internal, Fresize_mini_window_internal):
9532 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9534 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9536 * window.h (window): Add some new members to window structure -
9537 normal_lines, normal_cols, new_total, new_normal, clone_number,
9538 splits, nest, prev_buffers, next_buffers.
9539 (WINDOW_TOTAL_SIZE): Move here from window.c.
9540 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9542 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9544 (make_dummy_parent): Set new members of windows structure.
9545 (make_window): Move down in code. Handle new members of window
9547 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9548 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9549 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9550 (Fset_window_prev_buffers, Fwindow_next_buffers)
9551 (Fset_window_next_buffers, Fset_window_clone_number):
9553 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9554 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9556 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9557 Argument WINDOW can be now internal window too.
9558 (Fwindow_use_time): Move up in code.
9559 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9561 (Fset_window_configuration, saved_window)
9562 (Fcurrent_window_configuration, save_window_save): Handle new
9563 members of window structure.
9564 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9565 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9566 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9567 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9568 Qget_mru_window, Qresize_root_window,
9569 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9570 Qauto_buffer_name; staticpro them.
9572 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9574 * window.c (Fwindow_total_size, Fwindow_left_column)
9575 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9576 (Fwindow_list_1): New functions.
9577 (window_box_text_cols): Replace with window_body_cols.
9578 (Fwindow_width, Fscroll_left, Fscroll_right):
9579 Use window_body_cols instead of window_box_text_cols.
9580 (delete_window, Fset_window_configuration):
9581 Call delete_all_subwindows with window as argument.
9582 (delete_all_subwindows): Take a window as argument and not a
9584 (window_loop): Remove handling of GET_LRU_WINDOW and
9586 (Fget_lru_window, Fget_largest_window): Move to window.el.
9588 * window.h: Extern window_body_cols instead of
9589 window_box_text_cols. delete_all_subwindows now takes a
9590 Lisp_Object as argument.
9592 * indent.c (compute_motion, Fcompute_motion):
9593 Use window_body_cols instead of window_box_text_cols.
9595 * frame.c (delete_frame): Call delete_all_subwindows with root
9598 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9600 * fns.c (Fputhash): Document return value.
9602 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9604 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9606 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9608 Cons<->int and similar integer overflow fixes (Bug#8794).
9610 Check for overflow when converting integer to cons and back.
9611 * charset.c (Fdefine_charset_internal, Fdecode_char):
9612 Use cons_to_unsigned to catch overflow.
9613 (Fencode_char): Use INTEGER_TO_CONS.
9614 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9615 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9616 * data.c (long_to_cons, cons_to_long): Remove.
9617 (cons_to_unsigned, cons_to_signed): New functions.
9618 These signal an error for invalid or out-of-range values.
9619 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9620 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9621 * font.c (Ffont_variation_glyphs):
9622 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9623 * lisp.h: Include <intprops.h>.
9624 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9625 (cons_to_signed, cons_to_unsigned): New decls.
9626 (long_to_cons, cons_to_long): Remove decls.
9627 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9628 (Fprimitive_undo): Use CONS_TO_INTEGER.
9629 * xfns.c (Fx_window_property): Likewise.
9630 * xselect.c: Include <limits.h>.
9631 (x_own_selection, selection_data_to_lisp_data):
9632 Use INTEGER_TO_CONS.
9633 (x_handle_selection_request, x_handle_selection_clear)
9634 (x_get_foreign_selection, Fx_disown_selection_internal)
9635 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9636 (lisp_data_to_selection_data): Use cons_to_unsigned.
9637 (x_fill_property_data): Use cons_to_signed.
9638 Report values out of range.
9640 Check for buffer and string overflow more precisely.
9641 * buffer.h (BUF_BYTES_MAX): New macro.
9642 * lisp.h (STRING_BYTES_MAX): New macro.
9643 * alloc.c (Fmake_string):
9644 * character.c (string_escape_byte8):
9645 * coding.c (coding_alloc_by_realloc):
9646 * doprnt.c (doprnt):
9647 * editfns.c (Fformat):
9649 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9650 since they may not be the same number.
9651 * editfns.c (Finsert_char):
9652 * fileio.c (Finsert_file_contents):
9653 Likewise for BUF_BYTES_MAX.
9655 * image.c: Use ptrdiff_t, not int, for sizes.
9656 (slurp_file): Switch from int to ptrdiff_t.
9658 (slurp_file): Check that file size fits in both size_t (for
9659 malloc) and ptrdiff_t (for sanity and safety).
9661 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9662 if b->modtime has its maximal value.
9664 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9666 Don't assume time_t can fit into int.
9667 * buffer.h (struct buffer.modtime): Now time_t, not int.
9668 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9669 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9671 Minor fixes for signed vs unsigned integers.
9672 * character.h (MAYBE_UNIFY_CHAR):
9673 * charset.c (maybe_unify_char):
9674 * keyboard.c (read_char, reorder_modifiers):
9675 XINT -> XFASTINT, since the integer must be nonnegative.
9676 * ftfont.c (ftfont_spec_pattern):
9677 * keymap.c (access_keymap, silly_event_symbol_error):
9678 XUINT -> XFASTINT, since the integer must be nonnegative.
9679 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9680 since it makes no difference and we prefer signed.
9681 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9682 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9685 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9687 * window.h (Fwindow_frame): Declare.
9689 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9691 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9692 (SPARE_MEMORY): Always define.
9693 (LARGE_REQUEST): Remove.
9694 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9696 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9698 * lisp.h: Move EXFUNS for Fframe_root_window,
9699 Fframe_first_window and Fset_frame_selected_window to window.h.
9701 * window.h: Move EXFUNS for Fframe_root_window,
9702 Fframe_first_window and Fset_frame_selected_window here from
9705 * frame.c (Fwindow_frame, Fframe_first_window)
9706 (Fframe_root_window, Fframe_selected_window)
9707 (Fset_frame_selected_window): Move to window.c.
9708 (Factive_minibuffer_window): Move to minibuf.c.
9709 (Fother_visible_frames_p): New function.
9711 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9713 * window.c (decode_window, decode_any_window): Move up in code.
9714 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9715 (inhibit_frame_unsplittable): Remove unused variable.
9716 (Fwindow_buffer): Move up and rewrite doc-string.
9717 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9718 (Fwindow_prev): New functions.
9719 (Fwindow_frame): Move here from frame.c. Accept any window as
9721 (Fframe_root_window, Fframe_first_window)
9722 (Fframe_selected_window): Move here from frame.c. Accept frame
9723 or arbitrary window as argument. Update doc-strings.
9724 (Fminibuffer_window): Move up in code.
9725 (Fwindow_minibuffer_p): Move up in code and simplify.
9726 (Fset_frame_selected_window): Move here from frame.c.
9728 (Fselected_window, select_window, Fselect_window): Move up in
9729 code. Minor doc-string fixes.
9731 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9733 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9734 Do not assume that spare memory exists; that assumption is valid
9735 only if SYSTEM_MALLOC.
9736 (LARGE_REQUEST): New macro, so that the issue of large requests
9737 is separated from the issue of spare memory.
9739 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9741 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9744 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9746 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9749 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9751 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9753 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9755 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9756 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9758 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9760 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9762 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9764 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9765 (x_clipboard_manager_save): Add return value.
9766 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9768 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9769 Obey Vx_select_enable_clipboard_manager. Catch errors in
9770 x_clipboard_manager_save (Bug#8779).
9771 (Vx_select_enable_clipboard_manager): New variable.
9772 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9774 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9776 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9778 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9780 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9781 in the current matrix if keep_current_p is non-zero.
9783 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9785 * bidi.c (bidi_level_of_next_char): Fix last change.
9787 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9789 Support bidi reordering of text covered by display properties.
9791 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9792 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9793 (bidi_cache_search, bidi_cache_iterator_state)
9794 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9795 (bidi_level_of_next_char, bidi_move_to_visually_next):
9796 Support character positions inside a run of characters covered by a
9798 (bidi_paragraph_init, bidi_resolve_explicit_1)
9799 (bidi_level_of_next_char): Call bidi_fetch_char and
9800 bidi_fetch_char_advance instead of FETCH_CHAR and
9802 (bidi_init_it): Initialize new members.
9803 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9805 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9806 instead of using explicit *_CHAR codes.
9807 (bidi_resolve_explicit, bidi_resolve_weak):
9808 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9809 bidirectional text is supported only in multibyte buffers.
9810 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9811 it to initialize the frame_window_p member of struct bidi_it.
9812 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9813 (bidi_resolve_explicit, bidi_resolve_weak)
9814 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9815 bidi_it->nchars is non-positive.
9816 (bidi_level_of_next_char): Don't try to lookup the cache for the
9817 next/previous character if nothing is cached there yet, or if we
9818 were just reseat()'ed to a new position.
9820 * xdisp.c (set_cursor_from_row): Set start and stop points
9821 according to the row's direction when priming the loop that looks
9822 for the glyph on which to display cursor.
9823 (single_display_spec_intangible_p): Function deleted.
9824 (display_prop_intangible_p): Reimplement to call
9825 handle_display_spec instead of single_display_spec_intangible_p.
9826 Accept 3 additional arguments needed by handle_display_spec.
9827 This fixes incorrect cursor motion across display property with complex
9828 values: lists, `(when COND...)' forms, etc.
9829 (single_display_spec_string_p): Support property values that are
9830 lists with the argument STRING its top-level element.
9831 (display_prop_string_p): Fix the condition for processing a
9832 property that is a list to be consistent with handle_display_spec.
9833 (handle_display_spec): New function, refactored from the
9834 last portion of handle_display_prop.
9835 (compute_display_string_pos): Accept additional argument
9836 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9837 value of a `display' property is a "replacing spec".
9838 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9839 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9840 the display property, but just return a value indicating whether
9841 the display property will replace the characters it covers.
9842 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9843 frame_window_p members of struct bidi_it.
9844 (compute_display_string_pos, compute_display_string_end):
9846 (push_it): Accept second argument POSITION, where pop_it should
9847 jump to continue iteration.
9848 (reseat_1): Initialize bidi_it.disp_pos.
9850 * keyboard.c (adjust_point_for_property): Adjust the call to
9851 display_prop_intangible_p to its new signature.
9853 * dispextern.h (struct bidi_it): New member frame_window_p.
9854 (bidi_init_it): Update prototypes.
9855 (display_prop_intangible_p): Update prototype.
9856 (compute_display_string_pos, compute_display_string_end):
9858 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9861 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9863 Malloc failure behavior now depends on size of allocation.
9864 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9865 * lisp.h: Change signatures accordingly.
9866 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9867 All callers changed. (Bug#8762)
9869 * gnutls.c: Use Emacs's memory allocators.
9870 Without this change, the gnutls library would invoke malloc etc.
9871 directly, which causes problems on non-SYNC_INPUT hosts, and which
9872 runs afoul of improving memory_full behavior. (Bug#8761)
9873 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9874 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9875 xfree instead of the default malloc, realloc, free.
9876 (Fgnutls_boot): No need to check for memory allocation failure,
9877 since xmalloc does that for us.
9879 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9880 * category.c (hash_get_category_set):
9881 * ccl.c (ccl_driver):
9882 * charset.c (Fdefine_charset_internal):
9883 * charset.h (struct charset.hash_index):
9884 * composite.c (get_composition_id, gstring_lookup_cache)
9885 (composition_gstring_put_cache):
9886 * composite.h (struct composition.hash_index):
9887 * dispextern.h (struct image.hash):
9888 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9889 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9890 (hashfn_equal, hashfn_user_defined, make_hash_table)
9891 (maybe_resize_hash_table, hash_lookup, hash_put)
9892 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9893 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9894 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9895 * image.c (make_image, search_image_cache, lookup_image)
9896 (xpm_put_color_table_h):
9897 * lisp.h (struct Lisp_Hash_Table):
9898 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9899 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9900 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9901 * alloc.c (allocate_vectorlike):
9902 Check for overflow in vector size calculations.
9903 * ccl.c (ccl_driver):
9904 Check for overflow when converting EMACS_INT to int.
9905 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9906 need to be updated by these changes.
9907 * fns.c (make_hash_table, maybe_resize_hash_table):
9908 Check for integer overflow with large hash tables.
9909 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9910 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9911 (SXHASH_REDUCE): New macro.
9912 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9913 Use it instead of discarding useful hash info with large hash values.
9914 (sxhash_float): New function.
9915 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9916 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9917 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9918 Rewrite to use FIXNUM_BITS, as this simplifies things.
9919 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9920 Adjust signatures to match updated version of code.
9921 (consing_since_gc): Now EMACS_INT, since a single hash table can
9922 use more than INT_MAX bytes.
9924 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9926 Make it possible to build with GCC-4.6+ -O2 -flto.
9928 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9930 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9932 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9933 Call minibuffer-inactive-mode.
9935 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9937 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9938 Update dependencies.
9940 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9942 * data.c (init_data): Remove code for UTS, this system is not
9945 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9947 Don't force ./temacs to start in terminal mode.
9949 * frame.c (make_initial_frame): Initialize faces in all cases, not
9950 only when CANNOT_DUMP is defined.
9951 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9953 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9955 * dispnew.c (add_window_display_history): Use const for the string
9956 pointer. Remove declaration, not needed.
9958 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9960 Use 'inline', not 'INLINE'.
9961 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9962 * alloc.c, fontset.c (INLINE): Remove.
9963 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9964 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9965 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9966 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9967 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9969 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9971 Make it possible to run ./temacs.
9973 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9974 syms_of_callproc does the same thing. Remove test for
9975 "initialized", do it in the caller.
9976 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9978 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9980 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9981 (read_minibuf): Use get_minibuffer.
9982 (syms_of_minibuf): Use DEFSYM.
9983 (Qmetadata): New var.
9984 * data.c (Qbuffer): Don't make it static.
9985 (syms_of_data): Use DEFSYM.
9987 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9989 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9990 (CCL_CODE_MIN): New macro.
9992 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9994 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9996 * eval.c (Qdebug): Now static.
9997 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9998 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9999 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10001 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10003 * image.c: Various fixes to ImageMagick code comments.
10004 (Fimagemagick_types): Doc fix.
10006 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10008 Minor fixes prompted by GCC 4.6.0 warnings.
10010 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10012 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10013 (x_clipboard_manager_save_all): Move extern decl to ...
10014 * xterm.h: ... here, so that it can be checked for consistency.
10016 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10018 * xselect.c (x_clipboard_manager_save_frame)
10019 (x_clipboard_manager_save_all): New functions.
10020 (Fx_clipboard_manager_save): Lisp function deleted.
10022 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10023 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10025 * xterm.h: Update prototype.
10027 2011-05-28 William Xu <william.xwl@gmail.com>
10029 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10030 exiting (Bug#8239).
10032 2011-05-28 Jim Meyering <meyering@redhat.com>
10034 Avoid a sign-extension bug in crypto_hash_function.
10035 * fns.c (to_uchar): Define.
10036 (crypto_hash_function): Use it to convert some newly-signed
10037 variables to unsigned, to avoid sign-extension bugs. For example,
10038 without this change, (md5 "truc") would evaluate to
10039 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10040 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10041 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10043 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10045 Integer overflow fixes.
10047 * dbusbind.c: Serial number integer overflow fixes.
10048 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10049 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10050 to hold a serial number that is too large for a fixnum.
10051 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10052 Check for serial numbers out of range. Decode any serial number
10053 that was so large that it became a float. (Bug#8722)
10055 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10056 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10057 Use XFASTINT rather than XUINT when numbers are nonnegative.
10058 (xd_append_arg, Fdbus_method_return_internal):
10059 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10060 arguments, check that Lisp number is nonnegative, rather than
10061 silently wrapping negative numbers around. (Bug#8722)
10062 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10065 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10067 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10069 ccl: Add integer overflow checks.
10070 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10071 (IN_INT_RANGE): New macros.
10072 (ccl_driver): Use them to check for integer overflow when
10073 decoding a CCL program. Many of the new checks are whether XINT (x)
10074 fits in int; it doesn't always, on 64-bit hosts. The new version
10075 doesn't catch all possible integer overflows, but it's an
10076 improvement. (Bug#8719)
10078 * alloc.c (make_event_array): Use XINT, not XUINT.
10079 There's no need for unsigned here.
10081 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10082 This follows up to the 2011-05-06 change that substituted uintptr_t
10083 for EMACS_INT. This case wasn't caught back then.
10085 Rework Fformat to avoid integer overflow issues.
10086 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10087 now (part of C89). Include <verify.h>.
10088 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10089 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10090 (Fformat): Avoid the prepass trying to compute sizes; it was only
10091 approximate and thus did not catch overflow reliably. Instead, walk
10092 through the format just once, formatting and computing sizes as we go,
10093 checking for integer overflow at every step, and allocating a larger
10094 buffer as needed. Keep track separately whether the format is
10095 multibyte. Keep only the most-recently calculated precision, rather
10096 than them all. Record whether each argument has been converted to
10097 string. Use EMACS_INT, not int, for byte and char and arg counts.
10098 Support field widths and precisions larger than INT_MAX. Avoid
10099 sprintf's undefined behavior with conversion specifications such as %#d
10100 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10101 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10102 formatting out-of-range floating point numbers with int
10103 formats. (Bug#8668)
10105 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10107 * data.c: Avoid integer truncation in expressions involving floats.
10108 * data.c: Include <intprops.h>.
10109 (arith_driver): When there's an integer overflow in an expression
10110 involving floating point, convert the integers to floating point
10111 so that the resulting value does not suffer from catastrophic
10112 integer truncation. For example, on a 64-bit host (* 4
10113 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10114 Do not rely on undefined behavior after integer overflow.
10116 merge count_size_as_multibyte, parse_str_to_multibyte
10117 * character.c, character.h (count_size_as_multibyte):
10118 Rename from parse_str_to_multibyte; all uses changed.
10119 Check for integer overflow.
10120 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10121 since it's now a duplicate of the other. This is more of
10122 a character than a buffer op, so better that it's in character.c.
10123 * fns.c, print.c: Adjust to above changes.
10125 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10127 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10129 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10131 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10132 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10133 (x_clipboard_manager_save): Now static.
10134 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10136 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10137 (crypto_hash_function): Now static.
10138 Fix pointer signedness problems. Avoid unnecessary initializations.
10140 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10142 * termhooks.h (Vselection_alist): Make it terminal-local.
10144 * terminal.c (create_terminal): Initialize it.
10146 * xselect.c: Support for clipboard managers.
10147 (Vselection_alist): Move to termhooks.h as terminal-local var.
10148 (LOCAL_SELECTION): New macro.
10149 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10150 (symbol_to_x_atom): Remove gratuitous arg.
10151 (x_handle_selection_request, lisp_data_to_selection_data)
10152 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10153 (x_own_selection, x_get_local_selection, x_convert_selection):
10154 New arg, specifying work frame. Use terminal-local Vselection_alist.
10155 (some_frame_on_display): Delete unused function.
10156 (Fx_own_selection_internal, Fx_get_selection_internal)
10157 (Fx_disown_selection_internal, Fx_selection_owner_p)
10158 (Fx_selection_exists_p): New optional frame arg.
10159 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10160 (x_handle_selection_clear): Don't treat other terminals with the
10161 same keyboard specially. Use the terminal-local Vselection_alist.
10162 (x_clear_frame_selections): Use Frun_hook_with_args.
10164 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10166 * xterm.h: Add support for those atoms.
10168 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10170 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10171 (converted_selections, conversion_fail_tag): New global variables.
10172 (x_selection_request_lisp_error): Free the above.
10173 (x_get_local_selection): Remove unnecessary code.
10174 (x_reply_selection_request): Args changed; handle arbitrary array
10175 of converted selections stored in converted_selections.
10176 Separate the XChangeProperty and SelectionNotify steps.
10177 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10178 (x_convert_selection): New function.
10179 (x_handle_selection_event): Simplify.
10180 (x_get_foreign_selection): Don't ignore incoming requests while
10181 waiting for an answer; this will fail when we implement
10182 SAVE_TARGETS, and seems unnecessary anyway.
10183 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10184 (Vx_sent_selection_functions): Doc fix.
10186 2011-05-26 Leo Liu <sdl.web@gmail.com>
10188 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10190 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10192 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10194 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10195 for fringe update if it has periodic bitmap.
10196 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10197 and fringe_bitmap_periodic_p.
10199 * fringe.c (get_fringe_bitmap_data): New function.
10200 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10201 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10202 row. Mark glyph row for fringe update if periodicity changed.
10204 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10205 for fringe update unless it has periodic bitmap.
10207 2011-05-25 Kenichi Handa <handa@m17n.org>
10209 * xdisp.c (get_next_display_element): Set correct it->face_id for
10210 a static composition.
10212 2011-05-24 Leo Liu <sdl.web@gmail.com>
10215 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10217 * fns.c (crypto_hash_function, Fsha1): New function.
10218 (Fmd5): Use crypto_hash_function.
10219 (syms_of_fns): Add Ssha1.
10221 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10223 * gnutls.c: Remove unused macros.
10224 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10225 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10226 Remove macros that are defined and never used.
10227 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10229 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10231 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10232 (Fx_get_selection_internal): Minor cleanup.
10233 (Fx_own_selection_internal): Rename arguments for consistency with
10236 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10238 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10240 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10242 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10244 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10246 * dispnew.c (scrolling_window): Don't exclude the case that the
10247 last enabled row in the desired matrix touches the bottom boundary.
10249 2011-05-21 Glenn Morris <rgm@gnu.org>
10251 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10252 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10253 and add some more files.
10255 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10257 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10258 report_file_error introduced by the change from 2011-05-07.
10260 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10262 * systime.h (Time): Define only if emacs is defined.
10263 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10264 where the include path doesn't have X11/X.h by default. See
10265 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10267 2011-05-20 Kenichi Handa <handa@m17n.org>
10269 * composite.c (find_automatic_composition): Fix previous change.
10271 2011-05-20 Glenn Morris <rgm@gnu.org>
10273 * lisp.mk: New file, split from Makefile.in.
10274 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10275 (shortlisp): Remove.
10276 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10278 2011-05-19 Glenn Morris <rgm@gnu.org>
10280 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10281 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10282 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10283 (lisp): Set the order to that of loadup.el.
10284 (shortlisp): Make it a copy of $lisp.
10285 (SOME_MACHINE_LISP): Remove.
10286 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10287 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10289 2011-05-18 Kenichi Handa <handa@m17n.org>
10291 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10292 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10293 (find_automatic_composition): Mostly rewrite for efficiency.
10295 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10297 * makefile.w32-in: Update dependencies.
10299 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10301 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10302 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10304 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10306 Fix some integer overflow issues, such as string length overflow.
10308 * insdel.c (count_size_as_multibyte): Check for string overflow.
10310 * character.c (lisp_string_width): Check for string overflow.
10311 Use EMACS_INT, not int, for string indexes and lengths; in
10312 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10313 the resulting string length overflows an EMACS_INT; instead,
10314 report a string overflow if no precision given. When checking for
10315 precision exhaustion, use a check that cannot possibly have
10316 integer overflow. (Bug#8675)
10317 * character.h (lisp_string_width): Adjust to new signature.
10319 * alloc.c (string_overflow): New function.
10320 (Fmake_string): Use it. This doesn't change behavior, but saves
10321 a few bytes and will simplify future changes.
10322 * character.c (string_escape_byte8): Likewise.
10323 * lisp.h (string_overflow): New decl.
10325 Fixups, following up to the user-interface timestamp change.
10326 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10327 for UI timestamps, instead of unsigned long.
10328 * msdos.c (mouse_get_pos): Likewise.
10329 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10330 * w32gui.h (Time): Define by including "systime.h" rather than by
10331 declaring it ourselves. (Bug#8664)
10333 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10334 * image.c (clear_image_cache): Likewise.
10336 * term.c (term_mouse_position): Don't assume time_t wraparound.
10338 Be more systematic about user-interface timestamps.
10339 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10340 and sometimes 'EMACS_UINT', to represent these timestamps.
10341 This change causes it to use 'Time' uniformly, as that's what X uses.
10342 This makes the code easier to follow, and makes it easier to catch
10343 integer overflow bugs such as Bug#8664.
10344 * frame.c (Fmouse_position, Fmouse_pixel_position):
10345 Use Time, not unsigned long, for user-interface timestamps.
10346 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10347 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10348 * keyboard.h (last_event_timestamp): Likewise.
10349 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10350 * menu.h (xmenu_show): Likewise.
10351 * term.c (term_mouse_position): Likewise.
10352 * termhooks.h (struct input_event.timestamp): Likewise.
10353 (struct terminal.mouse_position_hook): Likewise.
10354 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10355 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10356 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10357 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10358 what it was before.
10359 * menu.h, termhooks.h: Include "systime.h", for Time.
10361 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10362 Don't assume that the difference between two unsigned long values
10363 can fit into an integer. At this point, we know button_down_time
10364 <= event->timestamp, so the difference must be nonnegative, so
10365 there's no need to cast the result if double-click-time is
10366 nonnegative, as it should be; check that it's nonnegative, just in
10367 case. This bug is triggered when events are more than 2**31 ms
10368 apart (about 25 days). (Bug#8664)
10370 * xselect.c (last_event_timestamp): Remove duplicate decl.
10371 (x_own_selection): Remove needless cast to unsigned long.
10373 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10374 that always fit in int. Use a sentinel instead of a counter, to
10375 avoid a temp and to allay GCC's concerns about possible int overflow.
10376 * frame.h (struct frame): Use int for menu_bar_items_used
10377 instead of EMACS_INT, since it always fits in int.
10379 * menu.c (grow_menu_items): Check for int overflow.
10381 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10383 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10384 Before, the code was not consistent. These values cannot exceed
10385 2**31 - 1 so there's no need to make them unsigned.
10386 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10387 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10388 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10390 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10392 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10393 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10394 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10395 presumably because the widths might not match.
10397 * window.c (size_window): Avoid needless test at loop start.
10399 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10401 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10403 2011-05-12 Drew Adams <drew.adams@oracle.com>
10405 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10407 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10409 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10410 `width' to `bar_area_x' and `bar_area_width', respectively.
10411 (x_scroll_run): Take account of fringe background extension.
10413 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10414 Rename local vars `left' and `width' to `bar_area_x' and
10415 `bar_area_width', respectively.
10416 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10417 background extension.
10419 2011-05-10 Jim Meyering <meyering@redhat.com>
10421 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10423 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10425 * image.c (Finit_image_library): Return t for built-in image types,
10426 like pbm and xbm. (Bug#8640)
10428 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10430 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10432 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10434 * w32console.c (Fset_screen_color): Doc fix.
10435 (Fget_screen_color): New function.
10436 (syms_of_ntterm): Defsubr it.
10438 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10439 unlink the temporary file if Fcall_process didn't create it in the
10441 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10442 child process will be redirected to a file specified with `:file'.
10443 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10444 cue to call_process_cleanup not to close that handle.
10446 2011-05-07 Ben Key <bkey76@gmail.com>
10448 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10449 one of two shell specific rules, either bootstrap-temacs-CMD or
10450 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10451 to the previous implementation of the bootstrap-temacs rule.
10452 The bootstrap-temacs-CMD rule is similar to the previous
10453 implementation of the bootstrap-temacs rule except that it
10454 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10457 These changes, along with some changes to nt/configure.bat,
10458 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10459 earlier fix to add support for --cflags and --ldflags options
10460 that include quotes so that it works whether make uses cmd or
10463 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10465 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10466 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10468 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10469 a string. Handle both cases.
10470 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10471 (Fdbus_register_method): Use Qinvalid_function.
10473 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10475 * makefile.w32-in: Update dependencies.
10476 (LISP_H): Add inttypes.h and stdin.h.
10477 (PROCESS_H): Add unistd.h.
10479 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10481 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10482 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10484 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10486 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10488 * term.c (vfatal): Remove stray call to va_end.
10489 It's not needed and the C Standard doesn't allow it here anyway.
10491 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10492 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10494 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10497 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10499 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10501 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10503 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10505 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10507 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10508 * charset.c (Fdefine_charset_internal): Don't initialize
10509 charset.code_space[15]. The value was garbage, on hosts with
10510 32-bit int (Bug#8600).
10512 * lread.c (read_integer): Be more consistent with string-to-number.
10513 Use string_to_number to do the actual conversion; this avoids
10514 rounding errors and fixes some other screwups. Without this fix,
10515 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10516 (digit_to_number): Move earlier, for benefit of read_integer.
10517 Return -1 if the digit is out of range for the base, -2 if it is
10518 not a digit in any supported base. (Bug#8602)
10520 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10522 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10523 to match comment at start of function. This also removes a
10524 GCC warning about overflow in a 32+64-bit port.
10526 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10528 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10529 Reported by Stefan Monnier in
10530 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10531 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10532 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10534 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10535 (EMACS_UINTPTR): Likewise, with uintptr_t.
10537 * lisp.h: Prefer 64-bit EMACS_INT if available.
10538 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10539 on 32-bit hosts that have 64-bit int, so that they can access
10541 However, temporarily disable this change unless the temporary
10542 symbol WIDE_EMACS_INT is defined.
10544 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10546 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10547 This removes an assumption that EMACS_INT and long are the same
10548 width as pointers. The assumption is true for Emacs porting targets
10549 now, but we want to make other targets possible.
10550 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10551 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10552 In the rest of the code, change types of integers that hold casted
10553 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10554 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10555 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10556 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10557 No need to cast type when ORing.
10558 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10559 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10560 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10561 assume EMACS_INT is the same width as char *.
10562 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10563 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10564 Remove no-longer-needed casts.
10565 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10566 (xg_tool_bar_help_callback, xg_make_tool_item):
10567 Use EMACS_INTPTR to hold an integer
10568 that will be cast to void *; this can avoid a GCC warning
10569 if EMACS_INT is not the same width as void *.
10570 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10571 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10572 (current_message_1, set_message_1):
10573 Use a local to convert to proper width without a cast.
10574 * xmenu.c (dialog_selection_callback): Likewise.
10576 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10577 Also, don't assume VALBITS / RAND_BITS is less than 5,
10578 and don't rely on undefined behavior when shifting a 1 left into
10580 * lisp.h (get_random): Change signature to match.
10582 * lread.c (hash_string): Use size_t, not int, for hash computation.
10583 Normally we prefer signed values; but hashing is special, because
10584 it's better to use unsigned division on hash table sizes so that
10585 the remainder is nonnegative. Also, size_t is the natural width
10586 for hashing into memory. The previous code used 'int', which doesn't
10587 retain enough info to hash well into very large tables.
10588 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10590 * dbusbind.c: Don't possibly lose pointer info when converting.
10591 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10592 Use XPNTR rather than XHASH, so that the high-order bits of
10593 the pointer aren't lost when converting through void *.
10595 * eval.c (Fautoload): Don't double-shift a pointer.
10597 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10599 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10601 * gnutls.c (DEF_GNUTLS_FN):
10602 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10604 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10606 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10609 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10611 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10612 New version that can reserve upto 2GB of heap space.
10614 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10616 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10618 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10620 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10621 `gnutls_certificate_set_x509_key_file'.
10623 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10625 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10626 Update dependencies.
10628 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10630 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10631 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10632 Remove unused parameter `fildes'.
10633 * process.c (read_process_output, send_process): Don't pass it.
10635 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10637 Fix previous change: the library cache is defined in w32.c.
10638 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10639 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10641 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10643 Implement dynamic loading of GnuTLS on Windows.
10645 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10646 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10647 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10650 * gnutls.c (Qgnutls_dll): Define.
10651 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10652 (gnutls_*): Declare function pointers.
10653 (init_gnutls_functions): New function to initialize function pointers.
10654 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10655 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10656 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10657 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10658 (emacs_gnutls_write, emacs_gnutls_read)
10659 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10660 (Fgnutls_available_p): New function.
10661 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10662 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10663 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10665 * image.c: Include w32.h.
10666 (Vimage_type_cache): Delete.
10667 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10668 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10669 (w32_delayed_load): Move to w32.c.
10671 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10673 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10674 (w32_delayed_load): Move from image.c. When loading a library, record
10675 its filename in the :loaded-from property of the library id.
10676 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10677 Initialize and staticpro them.
10678 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10680 * process.c: Include lisp.h before w32.h, not after.
10681 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10682 instead of gnutls_record_check_pending.
10684 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10686 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10688 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10689 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10692 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10694 * xterm.c (x_set_frame_alpha): Do not set property on anything
10695 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10697 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10699 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10701 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10703 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10704 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10705 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10706 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10707 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10708 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10709 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10710 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10711 (Qgnutls_bootprop_callbacks_verify): Make static.
10713 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10715 * callproc.c: Indentation fixup.
10717 * sysdep.c (wait_for_termination_1): Make static.
10718 (wait_for_termination, interruptible_wait_for_termination):
10719 Move after wait_for_termination_1.
10721 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10723 * sysdep.c (interruptible_wait_for_termination): New function
10724 which is like wait_for_termination, but allows keyboard
10727 * callproc.c (Fcall_process): Add (:file "file") as an option for
10729 (Fcall_process_region): Ditto.
10731 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10733 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10734 rather than `XVECTOR (FOO)->size'.
10736 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10737 inttypes.h, as a gnulib replacement is used if it not available in
10740 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10742 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10743 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10744 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10746 * coding.c (coding_alloc_by_realloc): Error out if destination
10747 will grow beyond MOST_POSITIVE_FIXNUM.
10748 (decode_coding_emacs_mule): Abort if there isn't enough place in
10749 charbuf for the composition carryover bytes. Reserve an extra
10750 space for up to 2 characters produced in a loop.
10751 (decode_coding_iso_2022): Abort if there isn't enough place in
10752 charbuf for the composition carryover bytes.
10754 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10756 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10757 aborting when %lld or %lll format is passed.
10758 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10759 %llo or %llx format is passed. (Bug#8545)
10761 * window.c (window_scroll_line_based): Use a marker instead of
10762 simple variables to record original value of point. (Bug#7952)
10764 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10765 produced by %s or %c overflows available buffer space. (Bug#8545)
10767 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10769 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10770 (SIZE_MAX): Move defn after all includes, as they might #define it.
10772 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10774 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10776 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10778 * keyboard.c (Qdelayed_warnings_hook): Define.
10779 (command_loop_1): Run `delayed-warnings-hook'
10780 if Vdelayed_warnings_list is non-nil.
10781 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10782 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10784 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10786 * doprnt.c (doprnt): Don't return value smaller than the buffer
10787 size if the message was truncated. (Bug#8545).
10789 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10791 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10792 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10794 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10796 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10798 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10800 * makefile.w32-in: Update dependencies.
10802 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10804 Improve `doprnt' and its usage. (Bug#8545)
10805 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10806 `format_end'. Remove support for %l as a conversion specifier.
10807 Don't use xrealloc. Improve diagnostics when the %l size modifier
10808 is used. Update the commentary.
10810 * eval.c (verror): Simplify calculation of size_t.
10812 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10815 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10817 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10820 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10822 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10823 This makes this file independent of the recent pseudovector change.
10825 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10827 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10829 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10830 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10831 Remove unused local.
10832 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10834 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10835 GCC 4.6.0 optimizes based on type-based alias analysis.
10836 For example, if b is of type struct buffer * and v of type struct
10837 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10838 != &v->size, and therefore "v->size = 1; b->size = 2; return
10839 v->size;" must therefore return 1. This assumption is incorrect
10840 for Emacs, since it type-puns struct Lisp_Vector * with many other
10841 types. To fix this problem, this patch adds a new type struct
10842 vectorlike_header that documents the constraints on layout of vectors
10843 and pseudovectors, and helps optimizing compilers not get fooled
10844 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10845 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10846 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10848 (XSETPVECTYPE): Rewrite in terms of new macro.
10849 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10850 This is a bit clearer, and further avoids the possibility of
10851 undesirable aliasing.
10852 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10853 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10854 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10855 since Lisp_Subr is a special case (no "next" field).
10856 (ASIZE): Now uses header.size rather than size.
10857 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10858 to avoid the hassle of writing XVECTOR (foo)->header.size.
10859 (struct vectorlike_header): New type.
10860 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10861 object, to help avoid aliasing.
10862 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10863 (SUBRP): Likewise, since Lisp_Subr is a special case.
10864 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10865 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10866 (struct Lisp_Hash_Table): Combine first two members into a single
10867 struct vectorlike_header member. All uses of "size" and "next" members
10868 changed to be "header.size" and "header.next".
10869 * buffer.h (struct buffer): Likewise.
10870 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10871 * frame.h (struct frame): Likewise.
10872 * process.h (struct Lisp_Process): Likewise.
10873 * termhooks.h (struct terminal): Likewise.
10874 * window.c (struct save_window_data, struct saved_window): Likewise.
10875 * window.h (struct window): Likewise.
10876 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10877 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10878 * buffer.c (init_buffer_once): Likewise.
10879 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10881 * process.c (Fformat_network_address): Use local var for size,
10884 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10886 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10887 * data.c (atof): Remove decl; no longer used or needed.
10888 (digit_to_number): Move to lread.c.
10889 (Fstring_to_number): Use new string_to_number function, to be
10890 consistent with how the Lisp reader treats infinities and NaNs.
10891 Do not assume that floating-point numbers represent EMACS_INT
10892 without losing information; this is not true on most 64-bit hosts.
10893 Avoid double-rounding errors, by insisting on integers when
10894 parsing non-base-10 numbers, as the documentation specifies.
10895 * lisp.h (string_to_number): New decl, replacing ...
10896 (isfloat_string): Remove.
10897 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10898 (read1): Do not accept +. and -. as integers; this
10899 appears to have been a coding error. Similarly, do not accept
10900 strings like +-1e0 as floating point numbers. Do not report
10901 overflow for integer overflows unless the base is not 10 which
10902 means we have no simple and reliable way to continue.
10903 Break out the floating-point parsing into a new
10904 function string_to_number, so that Fstring_to_number parses
10905 floating point numbers consistently with the Lisp reader.
10906 (digit_to_number): Move here from data.c. Make it static inline.
10907 (E_CHAR, EXP_INT): Remove, replacing with ...
10908 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10909 (string_to_number): New function, replacing isfloat_string.
10910 This function checks for valid syntax and produces the resulting
10911 Lisp float number too. Rework it so that string-to-number
10912 no longer mishandles examples like "1.0e+". Use strtoumax,
10913 so that overflow for non-base-10 numbers is reported only when
10914 there's no portable and simple way to convert to floating point.
10916 * textprop.c (set_text_properties_1): Rewrite for clarity,
10917 and to avoid GCC warning about integer overflow.
10919 * intervals.h (struct interval): Use EMACS_INT for members
10920 where EMACS_UINT might cause problems. See
10921 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10922 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10923 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10925 (offset_intervals): Tell GCC not to worry about length overflow
10926 when negating a negative length.
10928 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10929 (overrun_check_free): Likewise.
10931 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10932 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10935 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10936 (gnutls_make_error): Rename local to avoid shadowing.
10937 (gnutls_emacs_global_deinit): ifdef out; not used.
10938 (Fgnutls_boot): Use const for pointer to readonly storage.
10939 Comment out unused local. Fix pointer signedness problems.
10941 * lread.c (openp): Don't stuff size_t into an 'int'.
10942 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10943 about possible signed overflow.
10945 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10946 (GDK_KEY_g): Don't define if already defined.
10947 (xg_prepare_tooltip): Avoid pointer signedness problem.
10948 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10950 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10951 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10953 * xfns.c (Fx_window_property): Simplify a bit,
10954 to make a bit faster and to avoid GCC 4.6.0 warning.
10955 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10957 * fns.c (internal_equal): Don't assume size_t fits in int.
10959 * alloc.c (compact_small_strings): Tighten assertion a little.
10961 Replace pEd with more-general pI, and fix some printf arg casts.
10962 * lisp.h (pI): New macro, generalizing old pEd macro to other
10963 conversion specifiers. For example, use "...%"pI"d..." rather
10964 than "...%"pEd"...".
10965 (pEd): Remove. All uses replaced with similar uses of pI.
10966 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10967 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10968 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10969 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10970 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10971 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10972 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10974 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10975 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10976 * print.c (safe_debug_print, print_object): Likewise.
10977 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10979 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10980 avoiding the 0 flag, which is not portable.
10981 * process.c (Fmake_network_process): Use pI to avoid cast.
10982 * region-cache.c (pp_cache): Likewise.
10983 * xdisp.c (decode_mode_spec): Likewise.
10984 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10985 behavior on 64-bit hosts with printf arg.
10986 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10987 (x_stop_queuing_selection_requests): Likewise.
10988 (x_get_window_property): Don't truncate byte count to an 'int'
10991 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10992 here, since it parses constructs like leading '-' and spaces,
10993 which are not wanted; and it overflows with large numbers.
10994 Instead, simply match F[0-9]+, which is what is wanted anyway.
10996 * alloc.c: Remove unportable assumptions about struct layout.
10997 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10998 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10999 (allocate_vectorlike, make_pure_vector): Use the new macros,
11000 plus offsetof, to remove unportable assumptions about struct layout.
11001 These assumptions hold on all porting targets that I know of, but
11002 they are not guaranteed, they're easy to remove, and removing them
11003 makes further changes easier.
11005 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11006 This doesn't fix a bug but makes the code clearer.
11007 (string_overrun_cookie): Now const. Use initializers that
11008 don't formally overflow signed char, to avoid warnings.
11009 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11010 can cause Emacs to crash when string overrun checking is enabled.
11011 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11012 multiple of sizeof (EMACS_INT); it need not be, if
11013 alignof(EMACS_INT) < sizeof (EMACS_INT).
11014 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11016 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11018 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11020 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11022 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11023 supposed to be handshaking. (Bug#8556)
11024 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11026 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11028 * lisp.h (Qdebug): List symbol.
11029 * eval.c (Qdebug): Restore global linkage.
11030 * keyboard.c (debug-on-event): New variable.
11031 (handle_user_signal): Break into debugger when debug-on-event
11032 matches the current signal symbol.
11034 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11036 * alloc.c (check_sblock, check_string_bytes)
11037 (check_string_free_list): Convert to standard C.
11039 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11041 * w32.c (emacs_gnutls_push): Fix typo.
11043 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11045 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11046 "cast to pointer from integer of different size".
11048 Improve doprnt and its use in verror. (Bug#8545)
11049 * doprnt.c (doprnt): Document the set of format control sequences
11050 supported by the function. Use SAFE_ALLOCA instead of always
11053 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11054 is one byte too soon. Don't use xrealloc; instead xfree and
11057 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11059 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11062 * gnutls.c: Renamed global_initialized to
11063 gnutls_global_initialized. Added internals for the
11064 :verify-hostname-error, :verify-error, and :verify-flags
11065 parameters of `gnutls-boot' and documented those parameters in the
11066 docstring. Start callback support.
11067 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11068 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11069 on error. Return error code.
11070 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11071 (emacs_gnutls_read): Likewise.
11072 (Fgnutls_boot): Return handshake error code.
11073 (emacs_gnutls_handle_error): New function.
11074 (wsaerror_to_errno): Likewise.
11076 * w32.h (emacs_gnutls_pull): Add prototype.
11077 (emacs_gnutls_push): Likewise.
11079 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11080 (emacs_gnutls_push): Likewise.
11082 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11084 * process.c (wait_reading_process_output): Check if GnuTLS
11085 buffered some data internally if no FDs are set for TLS
11088 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11089 (LIBS): Link to USER_LIBS.
11090 ($(BLD)/gnutls.$(0)): New target.
11092 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11094 * xdisp.c (handle_single_display_spec): Rename the
11095 display_replaced_before_p argument into display_replaced_p, to
11096 make it consistent with the commentary. Fix typos in the
11099 * textprop.c (syms_of_textprop): Remove dead code.
11100 (copy_text_properties): Delete obsolete commentary about an
11101 interface that was deleted long ago. Fix typos in the description
11104 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11105 to changes in oldXMenu/XMenu.h from 2011-04-16.
11106 <menu_help_message, prev_menu_help_message>: Constify.
11107 (IT_menu_make_room): menu->help_text is now `const char **';
11110 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11111 to changes in oldXMenu/XMenu.h from 2011-04-16.
11112 (struct XMenu): Declare `help_text' `const char **'.
11114 * xfaces.c <Qunspecified>: Make extern again.
11116 * syntax.c: Include sys/types.h before including regex.h, as
11119 * doc.c (get_doc_string): Improve the format passed to `error'.
11121 * doprnt.c (doprnt): Improve commentary.
11123 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11125 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11128 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11129 changes in globals.h immediately force recompilation.
11130 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11131 $(CURDIR)/s/ms-w32.h.
11132 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11134 * character.c (Fchar_direction): Function deleted.
11135 (syms_of_character): Don't defsubr it.
11136 <char-direction-table>: Deleted.
11138 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11140 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11141 * doprnt.c: Include limits.h.
11142 (SIZE_MAX): New macro.
11143 (doprnt): Return a size_t value. 2nd arg is now size_t.
11144 Many local variables are now size_t instead of int or unsigned.
11145 Improve overflow protection. Support `l' modifier for integer
11146 conversions. Support %l conversion. Don't assume an EMACS_INT
11147 argument for integer conversions and for %c.
11149 * lisp.h (doprnt): Restore prototype.
11151 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11152 $(SRC)/character.h.
11154 * Makefile.in (base_obj): Add back doprnt.o.
11156 * deps.mk (doprnt.o): Add back prerequisites.
11157 (callint.o): Depend on character.h.
11159 * eval.c (internal_lisp_condition_case): Include the handler
11160 representation in the error message.
11161 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11162 when breaking from the loop.
11164 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11166 * callint.c (Fcall_interactively): When displaying error message
11167 about invalid control letter, pass the character's codepoint, not
11168 a pointer to its multibyte form. Improve display of the character
11169 in octal and display also its hex code.
11171 * character.c (char_string): Use %x to display the (unsigned)
11172 codepoint of an invalid character, to avoid displaying a bogus
11175 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11176 `error', not SYMBOL_NAME itself.
11178 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11179 character arguments to `error'.
11181 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11182 to `error' in error message about FINAL_CHAR argument. Make sure
11183 FINAL_CHAR is a character, and use %c when it is passed as
11184 argument to `error'.
11186 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11188 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11190 * w32.c: Include <time.h>.
11191 (sys_localtime): New function.
11193 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11195 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11197 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11199 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11201 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11202 zombies (Bug#8467).
11204 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11206 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11207 gl_state.e_property when gl_state.object is Qt.
11209 * insdel.c (make_gap_larger): Remove limitation of buffer size
11212 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11214 * xdisp.c (lookup_glyphless_char_display)
11215 (produce_glyphless_glyph): Handle cons cell entry in
11216 glyphless-char-display.
11217 (Vglyphless_char_display): Document it.
11219 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11220 glyphless-char-display.
11222 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11224 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11226 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11228 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11229 definition for no-X builds.
11231 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11233 Static checks with GCC 4.6.0 and non-default toolkits.
11235 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11237 * process.c (keyboard_bit_set): Define only if SIGIO.
11238 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11239 (send_process): Repair possible setjmp clobbering.
11241 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11243 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11245 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11247 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11248 Define only if needed.
11250 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11251 by pacifying GCC about it. Maybe it's time to retire it?
11252 * xfaces.c (USG, __TIMEVAL__): Likewise.
11254 * dispextern.h (struct redisplay_interface): Rename param
11255 to avoid shadowing.
11256 * termhooks.h (struct terminal): Likewise.
11257 * xterm.c (xembed_send_message): Likewise.
11259 * insdel.c (make_gap_smaller): Define only if
11260 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11262 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11265 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11266 so that we aren't warned about unused symbols.
11268 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11270 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11272 * xfns.c (x_real_positions): Mark locals as initialized.
11274 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11276 * xterm.c: Fix problems found by static analysis with other toolkits.
11277 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11278 (x_dispatch_event): Declare static if USE_GTK, and
11279 define if USE_GTK || USE_X_TOOLKIT.
11280 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11281 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11282 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11283 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11285 * xmenu.c (menu_help_callback): Pointer type fixes.
11286 Use const pointers when pointing at readonly data. Avoid pointer
11287 signedness clashes.
11288 (FALSE): Remove unused macro.
11289 (update_frame_menubar): Remove unused decl.
11291 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11293 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11294 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11295 (single_menu_item): Rename local to avoid shadowing.
11297 * keyboard.c (make_lispy_event): Remove unused local var.
11299 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11300 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11302 * bitmaps: Change bitmaps from unsigned char back to the X11
11303 compatible char. Avoid the old compiler warnings about
11304 out-of-range initializers by using, for example, '\xab' rather
11307 * xgselect.c (xgselect_initialize): Check vs interface
11308 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11310 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11312 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11313 to read-only memory.
11315 * fns.c (vector): Remove; this old hack is no longer needed.
11317 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11319 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11321 * xrdb.c (x_load_resources): Omit unused local.
11323 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11324 (x_window): Rename locals to avoid shadowing.
11325 (USG): Use the kludged USG macro, to pacify gcc.
11327 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11328 (x_term_init): Remove local to avoid shadowing.
11330 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11332 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11333 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11335 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11337 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11339 Fix regex.c, syntax.c and friends for buffers > 2GB.
11340 * syntax.h (struct gl_state_s): Declare character position members
11343 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11345 * textprop.c (verify_interval_modification, interval_of):
11346 Declare arguments EMACS_INT.
11348 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11351 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11353 * indent.c (Fvertical_motion): Local variable it_start is now
11356 * regex.c (re_match, re_match_2, re_match_2_internal)
11357 (bcmp_translate, regcomp, regexec, print_double_string)
11358 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11359 (re_compile_pattern, re_exec): Declare arguments and local
11360 variables `size_t' and `ssize_t' and return values `regoff_t', as
11362 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11363 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11364 <compile_stack_type>: `size' and `avail' are now `size_t'.
11366 * regex.h <regoff_t>: Use ssize_t, not int.
11367 (re_search, re_search_2, re_match, re_match_2): Arguments that
11368 specify buffer/string position and length are now ssize_t and
11369 size_t. Return type is regoff_t.
11371 2011-04-16 Ben Key <bkey76@gmail.com>
11373 * nsfont.m: Fixed bugs in ns_get_family and
11374 ns_descriptor_to_entity that were caused by using free to
11375 deallocate memory blocks that were allocated by xmalloc (via
11376 xstrdup). This caused Emacs to crash when compiled with
11377 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11378 --enable-checking=xmallocoverrun). xfree is now used to
11379 deallocate these memory blocks.
11381 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11383 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11385 emacs_write: Accept and return EMACS_INT for sizes.
11386 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11388 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11389 Accept and return EMACS_INT.
11390 (emacs_gnutls_write): Return the number of bytes written on
11392 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11393 (emacs_read, emacs_write): Remove check for negative size, as the
11394 Emacs source code has been audited now.
11395 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11396 (emacs_read, emacs_write): Use it.
11397 * process.c (send_process): Adjust to the new signatures of
11398 emacs_write and emacs_gnutls_write. Do not attempt to store
11399 a byte offset into an 'int'; it might overflow.
11400 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11402 * sound.c: Don't assume sizes fit in 'int'.
11403 (struct sound_device.period_size, alsa_period_size):
11404 Return EMACS_INT, not int.
11405 (struct sound_device.write, vox_write, alsa_write):
11406 Accept EMACS_INT, not int.
11407 (wav_play, au_play): Use EMACS_INT to store sizes and to
11408 record read return values.
11410 2011-04-15 Ben Key <bkey76@gmail.com>
11412 * keyboard.c (Qundefined): Don't declare static since it is used
11414 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11415 static since they are used in nsfont.m.
11417 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11419 * process.c (Qprocessp): Don't declare static.
11420 * lisp.h (Qprocessp): Declare again.
11422 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11424 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11426 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11428 Improve C-level modularity by making more things 'static'.
11430 Don't publish debugger-only interfaces to other modules.
11431 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11432 (verify_bytepos, count_markers): Move decls to the only modules
11434 * region-cache.h (pp_cache): Likewise.
11435 * window.h (check_all_windows): Likewise.
11436 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11438 * sysdep.c (croak): Now static, if
11439 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11440 * syssignal.h (croak): Declare only if not static.
11442 * alloc.c (refill_memory_reserve): Now static if
11443 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11444 * lisp.h (refill_memory_reserve): Declare only if not static.
11446 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11447 Define only if USE_LUCID.
11449 * xrdb.c (x_customization_string, x_rm_string): Now static.
11451 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11452 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11454 * xdisp.c (draw_row_with_mouse_face): Now static.
11455 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11457 * window.h (check_all_windows): Mark externally visible.
11459 * window.c (window_deletion_count): Now static.
11461 * undo.c: Make symbols static if they're not exported.
11462 (last_undo_buffer, last_boundary_position, pending_boundary):
11465 * textprop.c (interval_insert_behind_hooks): Now static.
11466 (interval_insert_in_front_hooks): Likewise.
11468 * term.c: Make symbols static if they're not exported.
11469 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11470 (max_frame_lines, tty_set_terminal_modes):
11471 (tty_reset_terminal_modes, tty_turn_off_highlight):
11472 (get_tty_terminal): Now static.
11473 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11474 * termhooks.h (term_mouse_moveto): Do not declare if
11475 HAVE_WINDOW_SYSTEM.
11476 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11477 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11479 * sysdep.c: Make symbols static if they're not exported.
11480 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11482 (sigprocmask_set, full_mask): Remove; unused.
11483 (wait_debugging): Mark as visible.
11484 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11485 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11487 * syntax.c (syntax_temp): Define only if !__GNUC__.
11489 * sound.c (current_sound_device, current_sound): Now static.
11491 * search.c (searchbufs, searchbuf_head): Now static.
11493 * scroll.c (scroll_cost): Remove; unused.
11494 * dispextern.h (scroll_cost): Remove decl.
11496 * region-cache.h (pp_cache): Mark as externally visible.
11498 * process.c: Make symbols static if they're not exported.
11499 (process_tick, update_tick, create_process, chan_process):
11500 (Vprocess_alist, proc_buffered_char, datagram_access):
11501 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11502 (deactivate_process): Mark defn as static, as well as decl.
11503 * lisp.h (create_process): Remove decl.
11504 * process.h (chan_process, Vprocess_alist): Remove decls.
11506 * print.c: Make symbols static if they're not exported.
11507 (print_depth, new_backquote_output, being_printed, print_buffer):
11508 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11509 (print_interval, print_number_index, initial_stderr_stream):
11511 * lisp.h (Fprinc): Remove decl.
11512 (debug_output_compilation_hack): Mark as externally visible.
11514 * sysdep.c (croak): Move decl from here to syssignal.h.
11515 * syssignal.h (croak): Put it here, so the API can be checked when
11516 'croak' is called from dissociate_if_controlling_tty.
11518 * minibuf.c: Make symbols static if they're not exported.
11519 (minibuf_save_list, choose_minibuf_frame): Now static.
11520 * lisp.h (choose_minibuf_frame): Remove decl.
11522 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11524 * lread.c: Make symbols static if they're not exported.
11525 (read_objects, initial_obarray, oblookup_last_bucket_number):
11527 (make_symbol): Remove; unused.
11528 * lisp.h (initial_obarray, make_symbol): Remove decls.
11530 * keyboard.c: Make symbols static if they're not exported.
11531 (single_kboard, recent_keys_index, total_keys, recent_keys):
11532 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11533 (this_single_command_key_start, echoing, last_auto_save):
11534 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11535 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11536 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11537 (Vlispy_mouse_stem, double_click_count):
11539 (force_auto_save_soon): Define only if SIGDANGER.
11540 (ignore_mouse_drag_p): Now static if
11541 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11542 (print_help): Remove; unused.
11543 (stop_character, last_timer_event): Mark as externally visible.
11544 * keyboard.h (ignore_mouse_drag_p): Declare only if
11545 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11546 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11547 * lisp.h (echoing): Remove decl.
11548 (force_auto_save_soon): Declare only if SIGDANGER.
11549 * xdisp.c (redisplay_window): Simplify code, to make it more
11550 obvious that ignore_mouse_drag_p is not accessed if !defined
11551 USE_GTK && !defined HAVE_NS.
11553 * intervals.c: Make symbols static if they're not exported.
11554 (merge_properties_sticky, merge_interval_right, delete_interval):
11556 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11558 * insdel.c: Make symbols static if they're not exported.
11559 However, leave prepare_to_modify_buffer alone. It's never
11560 called from outside this function, but that appears to be a bug.
11561 (combine_after_change_list, combine_after_change_buffer):
11562 (adjust_after_replace, signal_before_change): Now static.
11563 (adjust_after_replace_noundo): Remove; unused.
11564 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11565 (signal_before_change): Remove decls.
11567 * indent.c (val_compute_motion, val_vmotion): Now static.
11569 * image.c: Make symbols static if they're not exported.
11570 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11572 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11573 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11575 * fringe.c (standard_bitmaps): Now static.
11576 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11578 * frame.c: Make symbols static if they're not exported.
11579 (x_report_frame_params, make_terminal_frame): Now static.
11580 (get_frame_param): Now static, unless HAVE_NS.
11581 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11582 (x_get_resource_string): Remove; not used.
11583 * frame.h (make_terminal_frame, x_report_frame_params):
11584 (x_get_resource_string); Remove decls.
11585 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11586 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11588 * font.c, fontset.c: Make symbols static if they're not exported.
11589 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11590 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11591 * font.c (font_close_object): Now static.
11592 * font.h (font_close_object): Remove.
11593 * fontset.c (FONTSET_OBJLIST): Remove.
11594 (free_realized_fontset) #if-0 the body, which does nothing.
11595 (face_suitable_for_char_p): #if-0, as it's never called.
11596 * fontset.h (face_suitable_for_char_p): Remove decl.
11597 * xfaces.c (face_at_string_position):
11598 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11599 since 0 is always ASCII.
11601 * fns.c (weak_hash_tables): Now static.
11603 * fileio.c: Make symbols static if they're not exported.
11604 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11605 (Vwrite_region_annotation_buffers): Now static.
11607 * eval.c: Make symbols static if they're not exported.
11608 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11609 * lisp.h (backtrace_list): Remove decl.
11611 * emacs.c: Make symbols static if they're not exported.
11612 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11613 (fatal_error_code, fatal_error_signal_hook, standard_args):
11615 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11616 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11617 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11618 * lisp.h (fatal_error_signal_hook): Remove decl.
11619 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11621 * editfns.c: Move a (normally-unused) function to its only use.
11622 * editfns.c, lisp.h (get_operating_system_release): Remove.
11623 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11624 worth the hassle of breaking this out.
11626 * xterm.c: Make symbols static if they're not exported.
11627 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11628 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11629 (x_destroy_window, x_delete_display):
11631 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11632 (x_mouse_leave): Remove; unused.
11633 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11634 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11635 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11637 (x_mouse_leave): Declare only if WINDOWSNT.
11638 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11639 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11642 * ftxfont.c: Make symbols static if they're not exported.
11643 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11645 * font.h (ftxfont_driver): Likewise.
11647 * xfns.c: Make symbols static if they're not exported.
11648 (x_last_font_name, x_display_info_for_name):
11649 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11650 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11651 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11652 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11653 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11654 (last_show_tip_args): Now static.
11655 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11656 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11657 (x_screen_planes): Remove; unused.
11658 * dispextern.h (x_screen_planes): Remove decl.
11660 * dispnew.c: Make symbols static if they're not exported.
11661 * dispextern.h (redraw_garbaged_frames, scrolling):
11662 (increment_row_positions): Remove.
11663 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11664 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11666 (redraw_garbaged_frames): Remove; unused.
11668 * xfaces.c: Make symbols static if they're not exported.
11669 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11671 * xterm.h (defined_color): Remove decls.
11672 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11673 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11674 (menu_face_changed_default, defined_color, free_realized_face):
11675 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11676 (ascii_face_of_lisp_face): Remove; unused.
11678 * xdisp.c: Make symbols static if they're not exported.
11679 * dispextern.h (scratch_glyph_row, window_box_edges):
11680 (glyph_to_pixel_coords, set_cursor_from_row):
11681 (get_next_display_element, set_iterator_to_next):
11682 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11683 (show_mouse_face): Remove decls
11684 * frame.h (message_buf_print): Likewise.
11685 * lisp.h (pop_message, set_message, check_point_in_composition):
11687 * xterm.h (set_vertical_scroll_bar): Likewise.
11688 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11689 (message_buf_print, scratch_glyph_row, displayed_buffer):
11690 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11691 (get_next_display_element, show_mouse_face, window_box_edges):
11692 (frame_to_window_pixel_xy, check_point_in_composition):
11693 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11694 (glyph_to_pixel_coords): Remove; unused.
11696 * dired.c (file_name_completion): Now static.
11698 * dbusbind.c (xd_in_read_queued_messages): Now static.
11700 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11701 * data.c (circular_list_error): Remove.
11703 * commands.h (last_point_position, last_point_position_buffer):
11704 (last_point_position_window): Remove decls.
11705 * keyboard.c: Make these variables static.
11707 * coding.h (coding, code_convert_region, encode_coding_gap):
11709 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11710 (iso_code_class, detect_coding, code_convert_region): Now static.
11711 (encode_coding_gap): Remove; unused.
11713 * chartab.c (chartab_chars, chartab_bits): Now static.
11715 * charset.h (charset_iso_8859_1): Remove decl.
11716 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11719 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11720 * ccl.c (Vccl_program_table): Now static.
11721 (check_ccl_update): Remove; unused.
11723 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11724 * category.h: ... from here.
11725 * category.c (check_category_table, set_category_set): Now static.
11727 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11728 * lisp.h: Remove these decls.
11730 * buffer.c (buffer_count): Remove unused var.
11732 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11733 so that it's not optimized away.
11734 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11735 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11736 exported only to the debugger.
11738 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11739 * atimer.h (run_all_atimers): Remove; not exported.
11741 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11742 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11743 was inaccessible from Lisp.
11744 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11745 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11747 alloc.c: Import and export fewer symbols, and remove unused items.
11748 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11750 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11751 it's not optimized away by whole-program optimization.
11752 (message_enable_multibyte, free_misc): Remove.
11753 (catchlist, handlerlist, mark_backtrace):
11754 Declare only if BYTE_MARK_STACK.
11755 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11756 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11757 (message_enable_multibyte): Remove decl.
11758 (free_misc, interval_free_list, float_block, float_block_index):
11759 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11760 (cons_free_list, last_marked_index):
11762 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11763 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11764 (mark_backtrace): Define only if BYTE_MARK_STACK.
11765 * xdisp.c (message_enable_multibyte): Now static.
11767 Declare Lisp_Object Q* variables to be 'static' if not exported.
11768 This makes it easier for human readers (and static analyzers)
11769 to see whether these variables are used from other modules.
11770 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11771 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11772 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11773 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11774 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11775 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11776 * xmenu.c, xselect.c:
11777 Declare Q* vars static if they are not used in other modules.
11778 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11779 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11780 Remove decls of unexported vars.
11781 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11783 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11785 Make Emacs functions such as Fatom 'static' by default.
11786 This makes it easier for human readers (and static analyzers)
11787 to see whether these functions can be called from other modules.
11788 DEFUN now defines a static function. To make the function external
11789 so that it can be used in other C modules, use the new macro DEFUE.
11790 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11791 (Finit_image_library):
11792 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11793 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11794 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11795 Remove decls, since these functions are now static.
11796 (Funintern, Fget_internal_run_time): New decls, since these functions
11797 were already external.
11799 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11800 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11801 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11802 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11803 * keyboard.c, keymap.c, lread.c:
11804 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11805 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11806 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11807 Mark functions with DEFUE instead of DEFUN,
11808 if they are used in other modules.
11809 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11810 decls for now-static functions.
11811 * buffer.h (Fdelete_overlay): Remove decl.
11812 * callproc.c (Fgetenv_internal): Mark as internal.
11813 * composite.c (Fremove_list_of_text_properties): Remove decl.
11814 (Fcomposition_get_gstring): New forward static decl.
11815 * composite.h (Fcomposite_get_gstring): Remove decl.
11816 * dired.c (Ffile_attributes): New forward static decl.
11817 * doc.c (Fdocumntation_property): New forward static decl.
11818 * eval.c (Ffetch_bytecode): New forward static decl.
11819 (Funintern): Remove extern decl; now in .h file where it belongs.
11820 * fileio.c (Fmake_symbolic_link): New forward static decl.
11821 * image.c (Finit_image_library): New forward static decl.
11822 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11823 * intervals.h (Fprevious_property_change):
11824 (Fremove_list_of_text_properties): Remove decls.
11825 * keyboard.c (Fthis_command_keys): Remove decl.
11826 (Fcommand_execute): New forward static decl.
11827 * keymap.c (Flookup_key): New forward static decl.
11828 (Fcopy_keymap): Now static.
11829 * keymap.h (Flookup_key): Remove decl.
11830 * process.c (Fget_process): New forward static decl.
11831 (Fprocess_datagram_address): Mark as internal.
11832 * syntax.c (Fsyntax_table_p): New forward static decl.
11833 (skip_chars): Remove duplicate decl.
11834 * textprop.c (Fprevious_property_change): New forward static decl.
11835 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11837 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11838 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11840 * editfns.c (Fformat): Remove unreachable code.
11842 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11844 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11847 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11849 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11850 when at ZV. (Bug#8487)
11852 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11854 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11856 * keyboard.c (parse_tool_bar_item): Likewise.
11857 * sound.c (sound_cleanup, alsa_close): Likewise.
11858 * termcap.c (tgetent): Likewise.
11859 * xfns.c (x_default_font_parameter): Likewise.
11860 * xsettings.c (read_and_apply_settings): Likewise.
11862 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11863 (overrun_check_free): Protoize.
11865 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11867 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11868 since callers should never pass a negative size.
11869 Change the signature to match that of plain 'read' and 'write'; see
11870 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11871 * lisp.h: Update prototypes of emacs_write and emacs_read.
11873 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11875 * xdisp.c (redisplay_window): Don't try to determine the character
11876 position of the scroll margin if the window start point w->startp
11877 is outside the buffer's accessible region. (Bug#8468)
11879 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11881 Fix write-region and its subroutines for buffers > 2GB.
11882 * fileio.c (a_write, e_write): Modify declaration of arguments and
11883 local variables to support buffers larger than 2GB.
11884 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11886 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11887 argument, local variables, and return value.
11889 * lisp.h: Update prototypes of emacs_write and emacs_read.
11891 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11893 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11895 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11897 Fix more problems found by GCC 4.6.0's static checks.
11899 * xdisp.c (vmessage): Use a better test for character truncation.
11901 * charset.c (load_charset_map): <, not <=, for optimization,
11902 and to avoid potential problems with integer overflow.
11903 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11904 * casetab.c (set_identity, shuffle): Likewise.
11905 * editfns.c (Fformat): Likewise.
11906 * syntax.c (skip_chars): Likewise.
11908 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11909 This also lets GCC 4.6.0 generate slightly better loop code.
11911 * callint.c (Fcall_interactively): <, not <=, for optimization.
11912 (Fcall_interactively): Count the number of arguments produced,
11913 not the number of arguments given. This is simpler and lets GCC
11914 4.6.0 generate slightly better code.
11916 * ftfont.c: Distingish more carefully between FcChar8 and char.
11917 The previous code passed unsigned char * to a functions like
11918 strlen and xstrcasecmp that expect char *, which does not
11919 conform to the C standard.
11920 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11921 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11922 char * when the C standard requires it.
11924 * keyboard.c (read_char): Remove unused var.
11926 * eval.c: Port to Windows vsnprintf (Bug#8435).
11927 Include <limits.h>.
11928 (SIZE_MAX): Define if the headers do not.
11929 (verror): Do not give up if vsnprintf returns a negative count.
11930 Instead, grow the buffer. This ports to Windows vsnprintf, which
11931 does not conform to C99. Problem reported by Eli Zaretskii.
11932 Also, simplify the allocation scheme, by avoiding the need for
11933 calling realloc, and removing the ALLOCATED variable.
11935 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11937 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11938 But keep the doprint source code for now, as we might revamp it
11939 and use it again (Bug#8435).
11940 * lisp.h (doprnt): Remove.
11941 * Makefile.in (base_obj): Remove doprnt.o.
11942 * deps.mk (doprnt.o): Remove.
11944 error: Print 32- and 64-bit integers portably (Bug#8435).
11945 Without this change, on typical 64-bit hosts error ("...%d...", N)
11946 was used to print both 32- and 64-bit integers N, which relied on
11947 undefined behavior.
11948 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11949 * lisp.h (error, verror): Mark as printf-like functions.
11950 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11951 Report overflow in size calculations when allocating printf buffer.
11952 Do not truncate output string at its first null byte.
11953 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11954 Truncate the output at a character boundary, since vsnprintf does not
11956 * charset.c (check_iso_charset_parameter): Convert internal
11957 character to string before calling 'error', since %c now has the
11959 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11960 overflow when computing char to be passed to 'error'. Do not
11961 pass Lisp_Object to 'error'; pass the integer instead.
11962 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11963 formatted with plain %d.
11965 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11967 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11969 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11971 * xterm.c (x_catch_errors): Remove duplicate declaration.
11973 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11975 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11977 2011-04-10 Jim Meyering <meyering@redhat.com>
11979 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11980 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11981 return ssize_t not "int", and use size_t as the buffer length.
11982 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11983 * gnutls.h: Update declarations.
11984 * process.c (read_process_output): Use ssize_t, to match.
11985 (send_process): Likewise.
11987 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11989 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11991 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11993 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11994 Use unsigned char, to match FcChar8 type definition.
11996 * xterm.c (handle_one_xevent):
11997 * xmenu.c (create_and_show_popup_menu):
11998 * xselect.c (x_decline_selection_request)
11999 (x_reply_selection_request): Avoid type-punned deref of X events.
12001 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12003 Fix some uses of `int' instead of EMACS_INT.
12004 * search.c (string_match_1, fast_string_match)
12005 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12006 (scan_buffer, find_next_newline_no_quit)
12007 (find_before_next_newline, search_command, Freplace_match)
12008 (Fmatch_data): Make some `int' variables be EMACS_INT.
12010 * xdisp.c (display_count_lines): 3rd argument and return value now
12011 EMACS_INT. All callers changed.
12012 (pint2hrstr): Last argument is now EMACS_INT.
12014 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12015 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12016 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12017 (decode_coding_utf_16, decode_coding_emacs_mule)
12018 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12019 (decode_coding_ccl, decode_coding_charset)
12020 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12021 (decode_coding_iso_2022, decode_coding_emacs_mule)
12022 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12023 <char_offset, last_offset>: Declare EMACS_INT.
12024 (encode_coding_utf_8, encode_coding_utf_16)
12025 (encode_coding_emacs_mule, encode_invocation_designation)
12026 (encode_designation_at_bol, encode_coding_iso_2022)
12027 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12028 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12030 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12031 (encode_invocation_designation): Last argument P_NCHARS is now
12033 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12034 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12036 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12039 * ccl.c (Fccl_execute_on_string): Declare some variables
12042 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12044 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12046 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12048 * process.c (Fformat_network_address): Doc fix.
12050 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12052 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12054 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12056 * keyboard.c (read_char): Call Lisp function help-form-show,
12057 instead of using internal_with_output_to_temp_buffer.
12058 (Qhelp_form_show): New var.
12059 (syms_of_keyboard): Use DEFSYM macro.
12061 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12063 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12065 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12067 * process.c (Flist_processes): Remove to Lisp.
12068 (list_processes_1): Delete.
12070 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12072 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12074 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12076 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12078 Fix more problems found by GCC 4.6.0's static checks.
12080 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12082 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12084 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12086 * xdisp.c (vmessage): Mark as a printf-like function.
12088 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12090 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12092 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12093 printf-like functions.
12094 (tiff_load): Add casts to remove these marks before passing them
12095 to system-supplied API.
12097 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12099 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12100 This avoids several warnings with gcc -Wstrict-overflow.
12101 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12102 directly, rather than having caller test rule sign. This avoids
12103 some unnecessary tests.
12104 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12105 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12106 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12108 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12109 (xfont_open): Avoid unnecessary tests.
12111 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12113 * composite.h, composite.c (composition_gstring_put_cache):
12114 Use EMACS_INT, not int, for length.
12116 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12117 breaking out part of COMPOSITION_DECODE_RULE.
12118 (COMPOSITION_DECODE_RULE): Use it.
12119 * composite.c (get_composition_id): Remove unused local vars,
12120 by using the new macro.
12122 * textprop.c (set_text_properties_1): Change while to do-while,
12123 since the condition is always true at first.
12125 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12126 (interval_deletion_adjustment): Return unsigned value.
12129 * process.c (list_processes_1, create_pty, read_process_output):
12130 (exec_sentinel): Remove vars that were set but not used.
12131 (create_pty): Remove unnecessary "volatile"s.
12132 (Fnetwork_interface_info): Avoid possibility of int overflow.
12133 (read_process_output): Do adaptive read buffering even if carryover.
12134 (read_process_output): Simplify nbytes computation if buffered.
12136 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12138 * syntax.c (scan_words): Remove var that was set but not used.
12139 (update_syntax_table): Use unsigned instead of int.
12141 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12142 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12143 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12145 * print.c (print_error_message): Avoid int overflow.
12147 * font.c (font_list_entities): Redo for clarity,
12148 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12150 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12151 (font_score): Avoid potential overflow in diff calculation.
12153 * fns.c (substring_both): Remove var that is set but not used.
12154 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12156 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12158 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12159 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12160 can always succeed if overflow has undefined behavior.
12162 * search.c (boyer_moore, wordify): Remove vars set but not used.
12163 (wordify): Omit three unnecessary tests.
12165 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12166 All callers changed. This avoids the need for an unused var.
12168 * casefiddle.c (casify_region): Remove var that is set but not used.
12170 * dired.c (file_name_completion): Remove var that is set but not used.
12172 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12174 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12175 (Finsert_file_contents): Remove unnecessary code checking fd.
12177 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12178 Check for integer overflow on size calculations.
12180 * buffer.c (Fprevious_overlay_change): Remove var that is set
12183 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12184 Remove vars that are set but not used.
12185 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12186 (timer_check_2): Mark vars as initialized.
12188 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12190 * image.c (lookup_image): Remove var that is set but not used.
12191 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12193 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12194 that are set but not used.
12196 * xfns.c (make_invisible_cursor): Don't return garbage
12197 if XCreateBitmapFromData fails (Bug#8410).
12199 * xselect.c (x_get_local_selection, x_handle_property_notify):
12200 Remove vars that are set but not used.
12202 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12203 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12205 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12206 Remove var that is set but not used.
12207 (scroll_bar_windows_size): Now size_t, not int.
12208 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12209 Check for overflow.
12211 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12212 (map_tty_color) [!defined MSDOS]: Likewise.
12214 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12216 * coding.c: Remove vars that are set but not used.
12217 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12218 All callers changed.
12219 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12220 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12221 (decode_coding_charset): Remove vars that are set but not used.
12223 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12224 that is set but not used.
12226 * print.c (print_object): Remove var that is set but not used.
12228 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12229 The gnulib version avoids calling malloc in the usual case,
12230 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12231 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12232 * filelock.c (current_lock_owner): Likewise.
12233 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12234 * sysdep.c: Include allocator.h, careadlinkat.h.
12235 (emacs_no_realloc_allocator): New static constant.
12236 (emacs_readlink): New function.
12237 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12238 ../lib/careadlinkat.h.
12240 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12242 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12243 first non-nil return value).
12245 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12247 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12248 if not defined (Bug#8403).
12250 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12252 * xdisp.c (display_count_lines): Remove parameter `start',
12253 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12254 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12255 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12256 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12257 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12258 and thereabouts. All callers changed.
12259 (get_per_char_metric): Remove parameter `f', unused since
12260 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12262 2011-04-02 Jim Meyering <meyering@redhat.com>
12264 do not dereference NULL upon failed strdup
12265 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12266 (ns_get_family): Likewise.
12268 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12270 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12272 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12274 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12277 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12279 Add lexical binding.
12281 * window.c (Ftemp_output_buffer_show): New fun.
12282 (Fsave_window_excursion):
12283 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12285 * lread.c (lisp_file_lexically_bound_p): New function.
12286 (Fload): Bind Qlexical_binding.
12287 (readevalloop): Remove `evalfun' arg.
12288 Bind Qinternal_interpreter_environment.
12289 (Feval_buffer): Bind Qlexical_binding.
12290 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12292 (syms_of_lread): Declare `lexical-binding'.
12294 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12296 * keyboard.c (eval_dyn): New fun.
12297 (menu_item_eval_property): Use it.
12299 * image.c (parse_image_spec): Use Ffunctionp.
12301 * fns.c (concat, mapcar1): Accept byte-code-functions.
12303 * eval.c (Fsetq): Handle lexical vars.
12304 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12305 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12306 (FletX, Flet): Obey lexical binding.
12307 (Fcommandp): Handle closures.
12308 (Feval): New `lexical' arg.
12309 (eval_sub): New function extracted from Feval. Use it almost
12310 everywhere where Feval was used. Look up vars in lexical env.
12312 (Ffunctionp): Move from subr.el.
12313 (Ffuncall): Handle closures.
12314 (apply_lambda): Remove `eval_flags'.
12315 (funcall_lambda): Handle closures and new byte-code-functions.
12316 (Fspecial_variable_p): New function.
12317 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12318 but without exporting it to Lisp.
12320 * doc.c (Fdocumentation, store_function_docstring):
12321 * data.c (Finteractive_form): Handle closures.
12323 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12326 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12328 (exec_byte_code): New function extracted from Fbyte_code to handle new
12329 calling convention for byte-code-functions. Add new byte-codes.
12331 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12333 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12335 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12337 * xdisp.c (redisplay_internal): Fix prototype.
12339 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12341 * xdisp.c (SCROLL_LIMIT): New macro.
12342 (try_scrolling): Use it when setting scroll_limit.
12343 Limit scrolling to 100 screen lines.
12344 (redisplay_window): Even when falling back on "recentering",
12345 position point in the window according to scroll-conservatively,
12346 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12348 (try_scrolling): When point is above the window, allow searching
12349 as far as scroll_max, or one screenful, to compute vertical
12350 distance from PT to the scroll margin position. This prevents
12351 try_scrolling from unnecessarily failing when
12352 scroll-conservatively is set to a value slightly larger than the
12353 window height. Clean up the case of PT below the margin at bottom
12354 of window: scroll_max can no longer be INT_MAX. When aggressive
12355 scrolling is in use, don't let point enter the opposite scroll
12356 margin as result of the scroll.
12357 (syms_of_xdisp) <scroll-conservatively>: Document the
12358 threshold of 100 lines for never-recentering scrolling.
12360 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12362 * dispextern.h (move_it_by_lines):
12363 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12364 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12365 (message_log_check_duplicate): Remove parameters `prev_bol' and
12366 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12367 (redisplay_internal): Remove parameter `preserve_echo_area',
12368 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12370 * indent.c (Fvertical_motion):
12371 * window.c (window_scroll_pixel_based, Frecenter):
12372 Don't pass `need_y_p' to `move_it_by_lines'.
12374 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12376 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12377 steal a few bits to be more compact.
12378 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12379 Remove unneeded casts.
12381 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12383 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12385 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12386 binding" message (bug#7967).
12388 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12390 Fix more problems found by GCC 4.6.0's static checks.
12392 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12393 Remove unused local var.
12395 * editfns.c (Fmessage_box): Remove unused local var.
12397 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12398 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12399 Omit unused local vars.
12400 * window.c (shrink_windows): Omit unused local var.
12401 * menu.c (digest_single_submenu): Omit unused local var.
12402 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12403 Omit unused local var.
12405 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12406 Don't assume string length fits in int.
12407 (keyremap_step, read_key_sequence): Use size_t for sizes.
12408 (read_key_sequence): Don't check last_real_key_start redundantly.
12410 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12411 instead of alloca (Bug#8344).
12413 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12414 (Fbacktrace_frame): Don't assume nframes fits in int.
12416 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12418 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12421 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12423 * cm.c (calccost): Turn while-do into do-while, for clarity.
12425 * keyboard.c (syms_of_keyboard): Use the same style as later
12426 in this function when indexing through an array. This also
12427 works around GCC bug 48267.
12429 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12431 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12433 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12434 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12436 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12437 This avoids undefined behavior on integer overflow, and is a bit
12438 more convenient anyway since it is compared to a size_t variable.
12440 Variadic C functions now count arguments with size_t, not int.
12441 This avoids an unnecessary limitation on 64-bit machines, which
12442 caused (substring ...) to crash on large vectors (Bug#8344).
12443 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12444 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12445 All variadic functions and their callers changed accordingly.
12446 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12447 * data.c (arith_driver, float_arith_driver): Likewise.
12448 * editfns.c (general_insert_function): Likewise.
12449 * eval.c (struct backtrace.nargs, interactive_p)
12450 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12451 (funcall_lambda, mark_backtrace): Likewise.
12452 * fns.c (concat): Likewise.
12453 * frame.c (x_set_frame_parameters): Likewise.
12454 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12455 0 if not found, not -1. All callers changed.
12457 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12458 (stack_copy_size): Now size_t, not int.
12459 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12461 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12463 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12464 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12465 All callers changed.
12467 * lisp.h (multibyte_char_to_unibyte):
12468 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12469 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12470 * character.h (CHAR_TO_BYTE8):
12471 * cmds.c (internal_self_insert):
12472 * editfns.c (general_insert_function):
12473 * keymap.c (push_key_description):
12474 * search.c (Freplace_match):
12475 * xdisp.c (message_dolog, set_message_1): All callers changed.
12477 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12479 * keyboard.c (safe_run_hook_funcall): New function.
12480 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12481 don't set the hook to nil, but remove the offending function instead.
12482 (Qcommand_hook_internal): Remove, unused.
12483 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12484 Vcommand_hook_internal.
12486 * eval.c (enum run_hooks_condition): Remove.
12487 (funcall_nil, funcall_not): New functions.
12488 (run_hook_with_args): Call each function through a `funcall' argument.
12489 Remove `cond' argument, now redundant.
12490 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12491 (Frun_hook_with_args_until_failure): Adjust accordingly.
12492 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12494 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12496 * dispextern.h (string_buffer_position): Remove declaration.
12498 * print.c (strout): Remove parameter `multibyte', unused since
12499 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12501 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12502 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12503 All callers changed.
12505 * w32.c (_wsa_errlist): Use braces for struct initializers.
12507 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12508 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12509 All callers changed.
12510 (string_buffer_position): Likewise. Also, make static (it's never
12511 used outside xdisp.c).
12512 (cursor_row_p): Remove parameter `w', unused since
12513 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12514 (decode_mode_spec): Remove parameter `precision', introduced during
12515 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12516 All callers changed.
12518 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12520 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12522 2011-03-27 Anders Lindgren <andlind@gmail.com>
12524 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12525 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12526 (ns_update_auto_hide_menu_bar): New functions.
12527 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12528 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12529 ns_constrain_all_frames.
12530 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12531 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12533 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12535 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12537 2011-03-27 Glenn Morris <rgm@gnu.org>
12539 * syssignal.h: Replace RETSIGTYPE with void.
12540 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12541 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12542 Replace SIGTYPE with void everywhere.
12543 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12544 * s/template.h (SIGTYPE): Remove commented out definition.
12546 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12548 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12549 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12551 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12553 * w32.c (read_unc_volume): Use parameter `henum', instead of
12554 global variable `wget_enum_handle'.
12556 * keymap.c (describe_vector): Remove parameters `indices' and
12557 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12558 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12560 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12562 * keyboard.c (timer_check): Remove parameter `do_it_now',
12563 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12564 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12565 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12567 * keyboard.c (read_char):
12568 * w32menu.c (w32_menu_display_help):
12569 * xmenu.c (show_help_event, menu_help_callback):
12570 Adjust calls to `show_help_echo'.
12572 * gtkutil.c (xg_maybe_add_timer):
12573 * keyboard.c (readable_events):
12574 * process.c (wait_reading_process_output):
12575 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12577 * insdel.c (adjust_markers_gap_motion):
12578 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12579 (gap_left, gap_right): Don't call it.
12581 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12583 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12584 incurred during fontification.
12586 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12588 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12589 (DEFVAR_PER_BUFFER): Don't pass it.
12591 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12592 (scrolling_window): Don't pass it.
12594 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12596 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12598 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12600 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12601 of variables specific to SELinux and computation of `encoded_absname'.
12603 * image.c (XPutPixel): Remove unused variable `height'.
12605 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12607 * unexw32.c (get_section_info): Remove unused variable `section'.
12609 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12610 (system_process_attributes): Remove unused variable `sess'.
12611 (sys_read): Remove unused variable `err'.
12613 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12614 (w32_wnd_proc): Remove unused variable `isdead'.
12615 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12616 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12617 (x_create_tip_frame): Remove unused variable `tem'.
12619 * w32inevt.c (w32_console_read_socket):
12620 Remove unused variable `no_events'.
12622 * w32term.c (x_draw_composite_glyph_string_foreground):
12623 Remove unused variable `width'.
12625 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12627 * w32term.c (x_set_glyph_string_clipping):
12628 Don't pass uninitialized region to CombineRgn.
12630 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12632 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12633 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12634 (Fx_close_connection): Remove unused variable `i'.
12636 * w32font.c (w32font_draw): Return number of glyphs.
12637 (w32font_open_internal): Remove unused variable `i'.
12638 (w32font_driver): Add missing initializer.
12640 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12641 (fill_in_menu): Remove unused variable `items_added'.
12643 * w32term.c (last_mouse_press_frame): Remove static global variable.
12644 (w32_clip_to_row): Remove unused variable `f'.
12645 (x_delete_terminal): Remove unused variable `i'.
12647 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12648 (NOTHING): Remove unused static global variable.
12649 (uniscribe_check_otf): Remove unused variable `table'.
12650 (uniscribe_font_driver): Add missing initializers.
12652 2011-03-23 Julien Danjou <julien@danjou.info>
12654 * term.c (Fsuspend_tty, Fresume_tty):
12655 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12656 * window.c (temp_output_buffer_show):
12657 * insdel.c (signal_before_change):
12658 * frame.c (Fhandle_switch_frame):
12659 * fileio.c (Fdo_auto_save):
12660 * emacs.c (Fkill_emacs):
12661 * editfns.c (save_excursion_restore):
12662 * cmds.c (internal_self_insert):
12663 * callint.c (Fcall_interactively):
12664 * buffer.c (Fkill_all_local_variables):
12665 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12667 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12668 unconditionally since it does the check itself.
12670 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12672 Fix more problems found by GCC 4.5.2's static checks.
12674 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12675 the first time through the loop, since we know p0 < p1 then.
12676 This also avoids a gcc -Wstrict-overflow warning.
12678 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12679 leading to a memory leak, possible in functions like
12680 load_charset_map_from_file that can allocate an unbounded number
12681 of objects (Bug#8318).
12683 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12684 that could (at least in theory) be that large.
12686 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12687 This is less likely to overflow, and avoids undefined behavior if
12688 overflow does occur. All callers changed. Use strtoul to scan
12689 for the unsigned long integer.
12690 (pint2hrstr): Simplify and tune code slightly.
12691 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12693 * scroll.c (do_scrolling): Work around GCC bug 48228.
12694 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12696 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12697 This also avoids a warning with gcc -Wstrict-overflow.
12698 (validate_x_resource_name): Simplify count usage.
12699 This also avoids a warning with gcc -Wstrict-overflow.
12701 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12704 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12706 * process.c (Fmake_network_process): Use socklen_t, not int,
12707 where POSIX says socklen_t is required in portable programs.
12708 This fixes a porting bug on hosts like 64-bit HP-UX, where
12709 socklen_t is wider than int (Bug#8277).
12710 (Fmake_network_process, server_accept_connection):
12711 (wait_reading_process_output, read_process_output):
12714 * process.c: Rename or move locals to avoid shadowing.
12715 (list_processes_1, Fmake_network_process):
12716 (read_process_output_error_handler, exec_sentinel_error_handler):
12717 Rename or move locals.
12718 (Fmake_network_process): Define label "retry_connect" only if needed.
12719 (Fnetwork_interface_info): Fix pointer signedness.
12720 (process_send_signal): Add cast to avoid pointer signedness problem.
12721 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12722 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12724 Make tparam.h and terminfo.c consistent.
12725 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12726 Include tparam.h instead, since it declares them.
12727 * cm.h (PC): Remove extern decl; tparam.h now does this.
12728 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12729 * terminfo.c: Include tparam.h, to check interfaces.
12730 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12731 (tparam): Adjust signature to match interface in tparam.h;
12732 this removes some undefined behavior. Check that outstring and len
12733 are zero, which they always are with Emacs.
12734 * tparam.h (PC, BC, UP): New extern decls.
12736 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12737 (xftfont_open): Rename locals to avoid shadowing.
12739 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12740 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12741 (OTF_TAG_SYM): Omit macro if not needed.
12742 (ftfont_list): Remove unused local.
12743 (get_adstyle_property, ftfont_pattern_entity):
12744 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12745 Rename locals to avoid shadowing.
12747 * xfont.c (xfont_list_family): Mark var as initialized.
12749 * xml.c (make_dom): Now static.
12751 * composite.c (composition_compute_stop_pos): Rename local to
12753 (composition_reseat_it): Remove unused locals.
12754 (find_automatic_composition, composition_adjust_point): Likewise.
12755 (composition_update_it): Mark var as initialized.
12756 (find_automatic_composition): Mark vars as initialized,
12757 with a FIXME (Bug#8290).
12759 character.h: Rename locals to avoid shadowing.
12760 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12761 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12762 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12763 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12764 to avoid shadowing.
12766 * textprop.c (property_change_between_p): Remove; unused.
12768 * intervals.c (interval_start_pos): Now static.
12770 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12772 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12773 Rename locals to avoid shadowing.
12775 * sound.c (wav_play, au_play, Fplay_sound_internal):
12776 Fix pointer signedness.
12777 (alsa_choose_format): Remove unused local var.
12778 (wav_play): Initialize a variable to 0, to prevent undefined
12779 behavior (Bug#8278).
12781 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12783 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12785 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12786 clobbering (Bug#8298).
12787 * sysdep.c (sys_subshell): Likewise.
12788 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12790 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12791 This should get cleaned up, so that child_setup has the
12792 same signature on all platforms.
12794 * callproc.c (call_process_cleanup): Now static.
12795 (relocate_fd): Rename locals to avoid shadowing.
12797 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12799 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12800 not to be necessary, and produces flickering.
12802 2011-03-20 Glenn Morris <rgm@gnu.org>
12804 * config.in: Remove file.
12806 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12808 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12809 are now in src/globals.h.
12810 (syms_of_minibuf): Remove spurious & from previous change.
12812 2011-03-20 Leo Liu <sdl.web@gmail.com>
12814 * minibuf.c (completing-read-function): New variable.
12815 (completing-read-default): Rename from completing-read.
12816 (completing-read): Call completing-read-function.
12818 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12820 * xfaces.c (Fx_load_color_file):
12821 Read color file from absolute filename (bug#8250).
12823 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12825 * makefile.w32-in: Update dependencies.
12827 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12829 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12831 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12833 Fix more problems found by GCC 4.5.2's static checks.
12835 * process.c (make_serial_process_unwind, send_process_trap):
12836 (sigchld_handler): Now static.
12838 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12839 That way, the code declares only the vars that it needs.
12840 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12841 * s/cygwin.h (PTY_ITERATION): Likewise.
12842 * s/darwin.h (PTY_ITERATION): Likewise.
12843 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12845 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12846 * process.c (allocate_pty): Don't declare stb unless it's needed.
12848 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12849 (CONSTANTLIM): Remove; unused.
12850 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12851 Define only if needed.
12853 * unexelf.c (unexec): Name an expression,
12854 to avoid gcc -Wbad-function-cast warning.
12855 Use a different way to cause a compilation error if anyone uses
12856 n rather than nn, a way that does not involve shadowing.
12857 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12859 * deps.mk (unexalpha.o): Remove; unused.
12861 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12862 * unexec.h: New file.
12863 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12864 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12865 Depend on unexec.h.
12866 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12867 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12868 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12869 Change as necessary to match prototype in unexec.h.
12871 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12873 (back_comment, skip_chars): Mark vars as initialized.
12875 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12876 Rename locals to avoid shadowing.
12878 * lread.c (read1): Rewrite so as not to use empty "else".
12879 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12881 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12883 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12884 warning when compiling print.c.
12886 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12887 instead of using an uninitialized var.
12888 (font_sort_entities): Mark var as initialized.
12890 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12892 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12893 pointers to constants.
12894 (font_parse_fcname): Remove unused vars.
12895 (font_delete_unmatched): Now static.
12896 (font_get_spec): Remove; unused.
12897 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12898 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12899 Rename or move locals to avoid shadowing.
12901 * fns.c (require_nesting_list, require_unwind): Now static.
12902 (Ffillarray): Rename locals to avoid shadowing.
12904 * floatfns.c (domain_error2): Define only if needed.
12905 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12907 * alloc.c (mark_backtrace): Move decl from here ...
12908 * lisp.h: ... to here, so that it can be checked.
12910 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12911 (Fdefvar): Rewrite so as not to use empty "else".
12912 (lisp_indirect_variable): Name an expression,
12913 to avoid gcc -Wbad-function-cast warning.
12914 (Fdefvar): Rename locals to avoid shadowing.
12916 * callint.c (quotify_arg, quotify_args): Now static.
12917 (Fcall_interactively): Rename locals to avoid shadowing.
12918 Use const pointer when appropriate.
12920 * lisp.h (get_system_name, get_operating_system_release):
12921 Move decls here, to check interfaces.
12922 * process.c (get_operating_system_release): Move decl to lisp.h.
12923 * xrdb.c (get_system_name): Likewise.
12924 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12925 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12926 some of which prompt warnings from gcc -Wbad-function-cast.
12927 (Fformat_time_string, Fencode_time, Finsert_char):
12928 (Ftranslate_region_internal, Fformat):
12929 Rename or remove local vars to avoid shadowing.
12930 (Ftranslate_region_internal): Mark var as initialized.
12932 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12935 * lisp.h (eassert): Check that the argument compiles, even if
12936 ENABLE_CHECKING is not defined.
12938 * data.c (Findirect_variable): Name an expression, to avoid
12939 gcc -Wbad-function-cast warning.
12940 (default_value, arithcompare, arith_driver, arith_error): Now static.
12941 (store_symval_forwarding): Rename local to avoid shadowing.
12942 (Fmake_variable_buffer_local, Fmake_local_variable):
12943 Mark variables as initialized.
12944 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12946 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12947 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12948 Rename locals to avoid shadowing.
12949 (mark_stack): Move local variables into the #ifdef region where
12951 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12952 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12954 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12955 (GC_STRING_CHARS): Remove; not used.
12956 (Fmemory_limit): Cast sbrk's returned value to char *.
12958 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12959 avoids undefined behavior in theory.
12961 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12963 Use functions, not macros, for up- and down-casing (Bug#8254).
12964 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12965 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12966 to use the following functions instead of these macros.
12967 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12968 EMACS_INT, since callers assume the returned value fits in int.
12969 (upcase1): Likewise, for UPCASE_TABLE.
12970 (uppercasep, lowercasep, upcase): New static inline functions.
12971 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12972 the race-condition problem in the old DOWNCASE.
12974 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12975 Rename locals to avoid shadowing.
12976 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12977 (regex_compile, re_search_2, re_match_2_internal):
12978 Remove unused local vars.
12979 (FREE_VAR): Rewrite so as not to use empty "else",
12980 which gcc can warn about.
12981 (regex_compile, re_match_2_internal): Mark locals as initialized.
12982 (RETALLOC_IF): Define only if needed.
12983 (WORDCHAR_P): Likewise. This one is never needed, but is used
12984 only in a comment talking about a compiler bug, so put inside
12985 the #if 0 of that comment.
12986 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12987 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12990 * search.c (boyer_moore): Rename locals to avoid shadowing.
12991 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12992 (PREV_CHAR_BOUNDARY): Likewise.
12994 * search.c (simple_search): Remove unused var.
12996 * dired.c (compile_pattern): Move decl from here ...
12997 * lisp.h: ... to here, so that it can be checked.
12998 (struct re_registers): New forward decl.
13000 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13002 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13004 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13005 Rename locals to avoid shadowing.
13006 (Fvertical_motion): Mark locals as initialized.
13008 * casefiddle.c (casify_object, casify_region): Now static.
13009 (casify_region): Mark local as initialized.
13011 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13013 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13014 New macros, so that the caller can use some names other than
13015 gcpro1, gcpro2, etc.
13016 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13018 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13019 argument, for consistency with GCPRO2_VAR, etc: it is now the
13020 prefix of the variable, not the variable itself. All uses
13022 * dired.c (directory_files_internal, file_name_completion):
13023 Rename locals to avoid shadowing.
13025 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13026 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13027 dired.c's scmp function, had undefined behavior.
13028 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13029 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13030 * buffer.h: ... to here, because these macros use current_buffer,
13031 and the new implementation with inline functions needs to have
13032 current_buffer in scope now, rather than later when the macros
13034 (downcase, upcase1): New static inline functions.
13035 (DOWNCASE, UPCASE1): Reimplement using these functions.
13036 This avoids undefined behavior in expressions like
13037 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13038 from race conditions in accessing the global variables
13039 case_temp1 and case_temp2.
13040 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13041 * lisp.h (case_temp1, case_temp2): Remove their decls.
13042 * character.h (ASCII_CHAR_P): Move from here ...
13043 * lisp.h: ... to here, so that the inline functions mentioned
13044 above can use them.
13046 * dired.c (directory_files_internal_unwind): Now static.
13048 * fileio.c (file_name_as_directory, directory_file_name):
13049 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13051 (file_name_as_directory): Use const pointers when appropriate.
13052 (Fexpand_file_name): Likewise. In particular, newdir might
13053 point at constant storage, so make it a const pointer.
13054 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13055 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13057 (Fset_file_times, Finsert_file_contents, auto_save_error):
13058 Rename locals to avoid shadowing.
13060 * minibuf.c (choose_minibuf_frame_1): Now static.
13061 (Ftry_completion, Fall_completions): Rename or remove locals
13062 to avoid shadowing.
13064 * marker.c (bytepos_to_charpos): Remove; unused.
13066 * lisp.h (verify_bytepos, count_markers): New decls,
13067 so that gcc does not warn that these functions aren't declared.
13069 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13070 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13071 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13072 (copy_text): Remove unused local var.
13074 * filelock.c (within_one_second): Now static.
13075 (lock_file_1): Rename local to avoid shadowing.
13077 * buffer.c (fix_overlays_before): Mark locals as initialized.
13078 (fix_start_end_in_overlays): Likewise. This function should be
13079 simplified by using pointers-to-pointers, but that's a different
13081 (switch_to_buffer_1): Now static.
13082 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13083 (report_overlay_modification): Rename locals to avoid shadowing.
13085 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13086 Fix pointer signedness issue.
13087 (sys_subshell): Mark local as volatile if checking for lint,
13088 to suppress a gcc -Wclobbered warning that does not seem to be right.
13089 (MAXPATHLEN): Define only if needed.
13091 * process.c (serial_open, serial_configure): Move decls from here ...
13092 * systty.h: ... to here, so that they can be checked.
13094 * fns.c (get_random, seed_random): Move extern decls from here ...
13095 * lisp.h: ... to here, so that they can be checked.
13097 * sysdep.c (reset_io): Now static.
13098 (wait_for_termination_signal): Remove; unused.
13100 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13101 (copy_keymap_item, append_key, push_text_char_description):
13103 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13104 (DENSE_TABLE_SIZE): Remove; unused.
13105 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13106 (describe_map_tree):
13107 Rename locals to avoid shadowing.
13109 * keyboard.c: Declare functions static if they are not used elsewhere.
13110 (echo_char, echo_dash, cmd_error, top_level_2):
13111 (poll_for_input, handle_async_input): Now static.
13112 (read_char, kbd_buffer_get_event, make_lispy_position):
13113 (make_lispy_event, make_lispy_movement, apply_modifiers):
13114 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13115 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13116 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13117 (read_key_sequence, read_char): Mark locals as initialized.
13118 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13120 * keyboard.h (make_ctrl_char): New decl.
13121 (mark_kboards): Move decl here ...
13122 * alloc.c (mark_kboards): ... from here.
13124 * lisp.h (force_auto_save_soon): New decl.
13126 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13127 (DEFINE_DUMMY_FUNCTION): New macro.
13128 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13130 (main): Add casts to avoid warnings
13131 if GCC considers string literals to be constants.
13133 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13135 * dbusbind.c: Pointer signedness fixes.
13136 (xd_signature, xd_append_arg, xd_initialize):
13137 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13138 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13139 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13140 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13142 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13143 if GCC considers string literals to be constants.
13144 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13146 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13148 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13149 (print_preprocess, print_object): New macro to fix last change.
13151 * print.c (print_preprocess): Don't forget font objects.
13153 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13155 * emacs.c (USAGE3): Doc fixes.
13157 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13159 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13162 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13164 * lisp.h (VWindow_system, Qfile_name_history):
13165 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13166 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13167 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13169 * w32select.c: Don't #include "keyboard.h".
13170 (run_protected): Add extern declaration for waiting_for_input.
13172 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13173 * w32console.c (detect_input_pending, read_input_pending)
13174 (encode_terminal_code):
13175 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13176 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13177 (w32_system_caret_y, Qfile_name_history):
13178 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13179 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13180 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13181 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13182 * w32proc.c (Qlocal, report_file_error):
13183 * w32term.c (Vwindow_system, updating_frame):
13184 * w32uniscribe.c (initialized, uniscribe_font_driver):
13185 Remove unneeded extern declarations.
13187 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13189 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13191 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13193 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13194 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13195 These macros can no longer be used for assignment.
13197 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13198 Assign struct members directly, instead of using BUF_BEGV etc.
13199 (record_buffer_markers, fetch_buffer_markers): New functions for
13200 recording and fetching special buffer markers.
13201 (set_buffer_internal_1, set_buffer_temp): Use them.
13203 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13205 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13207 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13208 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13210 * xdisp.c (hscroll_window_tree):
13211 (reconsider_clip_changes): Use PT instead of BUF_PT.
13213 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13215 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13216 $(EMACS_ROOT)/lib/intprops.h.
13218 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13220 Fix more problems found by GCC 4.5.2's static checks.
13222 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13223 to unsigned char * to avoid compiler diagnostic.
13224 (xg_free_frame_widgets): Make it clear that a local variable is
13225 needed only if USE_GTK_TOOLTIP.
13226 (gdk_window_get_screen): Make it clear that this macro is needed
13227 only if USE_GTK_TOOLTIP.
13228 (int_gtk_range_get_value): New function, which avoids a diagnostic
13229 from gcc -Wbad-function-cast.
13230 (xg_set_toolkit_scroll_bar_thumb): Use it.
13231 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13232 diagnostic from gcc -Wbad-function-cast.
13233 (get_utf8_string, xg_get_file_with_chooser):
13234 Rename locals to avoid shadowing.
13235 (create_dialog): Move locals to avoid shadowing.
13237 * xgselect.c (xg_select): Remove unused var.
13239 * image.c (four_corners_best): Mark locals as initialized.
13240 (gif_load): Initialize transparent_p to zero (Bug#8238).
13241 Mark another local as initialized.
13242 (my_png_error, my_error_exit): Mark with NO_RETURN.
13244 * image.c (clear_image_cache): Now static.
13245 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13246 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13247 (x_edge_detection): Remove unnecessary cast that
13248 gcc -Wbad-function-cast diagnoses.
13249 (gif_load): Fix pointer signedness.
13250 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13251 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13253 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13255 Improve quality of tests for time stamp overflow.
13256 For example, without this patch (encode-time 0 0 0 1 1
13257 1152921504606846976) returns the obviously-bogus value (-948597
13258 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13259 reports time overflow. See
13260 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13261 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13262 * editfns.c: Include limits.h and intprops.h.
13263 (TIME_T_MIN, TIME_T_MAX): New macros.
13264 (time_overflow): Move earlier, to before first use.
13265 (hi_time, lo_time): New functions, for an accurate test for
13266 out-of-range times.
13267 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13268 (Fget_internal_run_time): Don't assume time_t fits in int.
13269 (make_time): Use list2 instead of Fcons twice.
13270 (Fdecode_time): More accurate test for out-of-range times.
13271 (check_tm_member): New function.
13272 (Fencode_time): Use it, to test for out-of-range times.
13273 (lisp_time_argument): Don't rely on undefined left-shift and
13274 right-shift behavior when checking for time stamp overflow.
13276 * editfns.c (time_overflow): New function, refactoring common code.
13277 (Fformat_time_string, Fdecode_time, Fencode_time):
13278 (Fcurrent_time_string): Use it.
13280 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13281 * dired.c (make_time): Move to ...
13282 * editfns.c (make_time): ... here.
13283 * systime.h: Note the move.
13285 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13287 * fringe.c (update_window_fringes): Remove unused variables.
13289 * unexmacosx.c (copy_data_segment): Also copy __got section.
13292 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13294 * termcap.c [MSDOS]: Include "msdos.h".
13295 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13296 Constify `char *' arguments and their references according to
13297 prototypes in tparam.h.
13299 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13301 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13302 Adapt all references accordingly.
13304 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13306 2011-03-11 Tom Tromey <tromey@redhat.com>
13308 * buffer.c (syms_of_buffer): Remove obsolete comment.
13310 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13312 * termhooks.h (encode_terminal_code): Declare prototype.
13314 * msdos.c (encode_terminal_code): Don't declare prototype.
13316 * term.c (encode_terminal_code): Now external again, used by
13317 w32console.c and msdos.c.
13319 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13320 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13322 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13324 Fix some minor problems found by GCC 4.5.2's static checks.
13326 * fringe.c (update_window_fringes): Mark locals as initialized
13328 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13330 * alloc.c (mark_fringe_data): Move decl from here ...
13331 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13332 to check its interface.
13333 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13335 * fontset.c (free_realized_fontset): Now static.
13336 (Fset_fontset_font): Rename local to avoid shadowing.
13337 (fontset_font): Mark local as initialized.
13338 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13340 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13342 * xselect.c (x_disown_buffer_selections): Remove; not used.
13343 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13344 (x_own_selection, Fx_disown_selection_internal): Rename locals
13345 to avoid shadowing.
13346 (x_handle_dnd_message): Remove local to avoid shadowing.
13348 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13349 so that the caller can use some name other than gcpro1.
13350 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13351 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13352 (Fx_backspace_delete_keys_p):
13353 Use them to avoid shadowing, and rename vars to avoid shadowing.
13354 (x_decode_color, x_set_name, x_window): Now static.
13355 (Fx_create_frame): Add braces to silence GCC warning.
13356 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13357 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13358 Remove unused locals.
13359 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13360 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13361 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13364 * xterm.h (x_mouse_leave): New decl.
13366 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13367 Remove unused functions.
13368 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13369 (x_calc_absolute_position): Now static.
13370 (XTread_socket): Don't define label "out" unless it's used.
13371 Don't declare local "event" unless it's used.
13372 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13373 unless they are used.
13374 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13375 (x_fatal_error_signal): Remove; not used.
13376 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13377 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13378 (x_error_catcher, x_connection_closed, x_error_handler):
13379 (x_error_quitter, xembed_send_message, x_iconify_frame):
13380 (my_log_handler): Rename locals to avoid shadowing.
13381 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13382 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13384 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13385 Rename or move locals to avoid shadowing.
13386 (tty_defined_color, merge_face_heights): Now static.
13387 (free_realized_faces_for_fontset): Remove; not used.
13388 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13389 does not deduce is never used uninitialized.
13390 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13391 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13393 * terminal.c (store_terminal_param): Now static.
13395 * xmenu.c (menu_highlight_callback): Now static.
13396 (set_frame_menubar): Remove unused local.
13397 (xmenu_show): Rename parameter to avoid shadowing.
13398 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13399 since they might point to immutable storage.
13400 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13401 since it's unused otherwise.
13403 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13404 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13405 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13406 avoids a gcc -Wuninitialized diagnostic.
13407 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13408 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13409 does not deduce are never used uninitialized.
13411 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13413 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13414 * window.c (window_loop, size_window):
13415 (run_window_configuration_change_hook, enlarge_window): Likewise.
13417 * window.c (display_buffer): Now static.
13418 (size_window): Mark variables that gcc -Wuninitialized
13419 does not deduce are never used uninitialized.
13420 * window.h (check_all_windows): New decl, to forestall
13421 gcc -Wmissing-prototypes diagnostic.
13422 * dispextern.h (bidi_dump_cached_states): Likewise.
13424 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13426 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13427 Include <limits.h>.
13428 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13429 and to avoid gcc -Wuninitialized warning.
13430 (load_charset_map): Mark variables that gcc -Wuninitialized
13431 does not deduce are never used uninitialized.
13432 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13434 * coding.c (coding_set_source, coding_set_destination):
13435 Use "else { /* comment */ }" rather than "else /* comment */;"
13436 for clarity, and to avoid gcc -Wempty-body warning.
13437 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13438 a block, when the outer 'i' will do.
13439 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13440 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13441 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13442 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13443 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13444 Rename locals to avoid shadowing.
13445 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13446 * coding.c (emacs_mule_char, encode_invocation_designation):
13447 Now static, since they're not used elsewhere.
13448 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13449 (decode_coding_object, encode_coding_object, detect_coding_system):
13450 (decode_coding_emacs_mule): Mark variables that gcc
13451 -Wuninitialized does not deduce are never used uninitialized.
13452 (detect_coding_iso_2022): Initialize a local variable that might
13453 be used uninitialized. Leave a FIXME because it's not clear that
13454 this initialization is needed. (Bug#8211)
13455 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13456 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13457 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13458 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13459 Remove unused macros.
13461 * category.c (hash_get_category_set): Remove unused local var.
13462 (copy_category_table): Now static, since it's not used elsewhere.
13463 * character.c (string_count_byte8): Likewise.
13465 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13466 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13468 * chartab.c (copy_sub_char_table): Now static, since it's not used
13470 (sub_char_table_ref_and_range, char_table_ref_and_range):
13471 Rename locals to avoid shadowing.
13472 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13474 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13475 (BIDI_BOB): Remove unused macro.
13477 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13478 deduce are never used uninitialized.
13479 * term.c (encode_terminal_code): Likewise.
13481 * term.c (encode_terminal_code): Now static. Remove unused local.
13483 * tparam.h: New file.
13484 * term.c, tparam.h: Include it.
13485 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13486 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13487 Move these decls to tparam.h, and make them agree with what
13488 is actually in tparam.c. The previous trick of using incompatible
13489 decls in different modules does not conform to the C standard.
13490 All callers of tparam changed to use tparam's actual API.
13491 * tparam.c (tparam1, tparam, tgoto):
13492 Use const pointers where appropriate.
13494 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13495 * cm.h (struct cm): Likewise.
13496 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13497 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13498 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13499 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13500 (turn_on_face, init_tty): Likewise.
13501 * termchar.h (struct tty_display_info): Likewise.
13503 * term.c (term_mouse_position): Rename local to avoid shadowing.
13505 * alloc.c (mark_ttys): Move decl from here ...
13506 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13508 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13510 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13512 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13514 * search.c (compile_pattern_1): Remove argument regp, unused since
13515 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13516 (compile_pattern): Don't pass it.
13518 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13520 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13521 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13523 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13525 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13527 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13528 gdk_window_get_screen, gdk_window_get_geometry,
13529 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13530 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13531 (xg_get_pixbuf_from_pixmap): New function.
13532 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13533 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13534 Call xg_get_pixbuf_from_pixmap instead of
13535 gdk_pixbuf_get_from_drawable.
13536 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13537 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13538 (xg_check_special_colors): Use GtkStyleContext and its functions
13540 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13541 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13542 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13543 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13544 Call gtk_widget_get_preferred_size.
13545 (xg_frame_resized): gdk_window_get_geometry only takes 5
13547 (xg_win_to_widget, xg_event_is_for_menubar):
13548 Call gdk_x11_window_lookup_for_display.
13549 (xg_set_widget_bg): New function.
13550 (delete_cb): New function.
13551 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13552 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13553 (xg_set_background_color): Call xg_set_widget_bg.
13554 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13555 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13556 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13557 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13559 (update_frame_tool_bar): Call gtk_widget_hide.
13560 (xg_initialize): Use GDK_KEY_g.
13562 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13564 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13566 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13567 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13568 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13570 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13572 * w32xfns.c (select_palette): Check success of RealizePalette against
13573 GDI_ERROR, not zero.
13575 See ChangeLog.11 for earlier changes.
13577 ;; Local Variables:
13581 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13583 This file is part of GNU Emacs.
13585 GNU Emacs is free software: you can redistribute it and/or modify
13586 it under the terms of the GNU General Public License as published by
13587 the Free Software Foundation, either version 3 of the License, or
13588 (at your option) any later version.
13590 GNU Emacs is distributed in the hope that it will be useful,
13591 but WITHOUT ANY WARRANTY; without even the implied warranty of
13592 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13593 GNU General Public License for more details.
13595 You should have received a copy of the GNU General Public License
13596 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.