1 2012-08-01 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
5 2012-08-01 Glenn Morris <rgm@gnu.org>
7 * s/msdos.h: Remove file.
8 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
9 * Makefile.in (S_FILE): Remove.
10 (config_h): Remove S_FILE.
12 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
14 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
15 Remove; moved to nt/config.nt.
17 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
19 Use INTERNAL_FIELD for conses and overlays.
20 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
21 Remove obsolete comment.
23 (struct Lisp_Overlay): Use INTERNAL_FIELD.
24 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
26 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
28 Use INTERNAL_FIELD for symbols.
29 * lisp.h (SVAR): New macro. Adjust users.
30 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
31 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
33 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
35 Use INTERNAL_FIELD for processes.
36 * process.h (PVAR): New macro. Adjust style.
37 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
38 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
40 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
42 Use INTERNAL_FIELD for windows.
43 * window.h (WVAR): New macro.
44 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
45 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
46 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
47 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
48 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
49 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
51 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
53 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
55 2012-08-01 Glenn Morris <rgm@gnu.org>
57 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
60 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
62 * makefile.w32-in (CONFIG_H): Update dependencies.
63 (CONF_POST_H): New macro.
65 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
67 2012-07-31 Glenn Morris <rgm@gnu.org>
69 * Makefile.in (S_FILE): No longer set by configure.
71 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
73 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
75 * process.h (NULL_DEVICE):
77 * editfns.c (USER_FULL_NAME): Let configure set them.
79 * s/README, s/template.h: Remove files.
81 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
83 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
86 2012-07-31 Eli Zaretskii <eliz@gnu.org>
88 * .gdbinit (xframe): Adapt to introduction of FVAR and the
89 resulting renaming of 'struct frame' members.
91 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
93 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
94 after introduction of FVAR.
96 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
98 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
100 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
101 instead of compositeToPoint.
102 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
104 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
106 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
108 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
109 * lisp.h (INTERNAL_FIELD): New macro.
110 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
111 (BVAR): Change to use INTERNAL_FIELD.
112 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
113 (KVAR): Change to use INTERNAL_FIELD.
114 * frame.h (FVAR): New macro.
115 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
116 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
117 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
118 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
119 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
121 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
123 Miscellaneous fixes for non-default X toolkits.
124 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
125 * xterm.c (x_frame_of_widget): Remove redundant prototype.
126 Move under #ifdef USE_LUCID.
127 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
128 definition and usage to avoid warnings.
130 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
132 * nsterm.m (openFiles): Fix previous checkin.
134 2012-07-31 Paul Eggert <eggert@cs.ucla.edu>
136 * indent.c (compute_motion): Remove unused local.
138 2012-07-31 Glenn Morris <rgm@gnu.org>
140 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
142 * conf_post.h [USG5_4]:
143 Move remaining contents of s/usg5-4-common.h here.
144 * s/usg5-4-common.h: Remove file.
146 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
147 * s/irix6-5.h: Remove file.
149 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
150 * s/darwin.h: Remove file.
152 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
153 * s/hpux10-20.h: Remove file, which is now empty.
155 2012-07-30 Glenn Morris <rgm@gnu.org>
157 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
158 * Makefile.in (config_h): Add conf_post.h.
159 * makefile.w32-in (CONFIG_H): Add conf_post.h.
161 2012-07-30 Jan Djärv <jan.h.d@swipnet.se>
163 * nsterm.m (ns_do_open_file): New variable.
164 (ns_term_init): Set ns_do_open_file to YES after run returns.
165 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
166 files only if ns_do_open_file.
168 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
170 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
171 This no-op macro hasn't been needed for many years.
172 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
174 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
175 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
176 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
177 gdb_make_enums_visible.
178 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
179 (DIRECTORY_SEP): Now a constant, not a macro.
181 2012-07-30 Eli Zaretskii <eliz@gnu.org>
183 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
184 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
186 * w32term.c <w32_keyboard_codepage>: Renamed from
187 keyboard_codepage and now external. All users changed.
189 * w32term.h: Add declaration of w32_keyboard_codepage.
191 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
192 the codepage to translate keys to Unicode. If this argument is
193 -1, use the value returned by GetConsoleCP. All callers changed.
195 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
197 Update .PHONY listings in makefiles.
198 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
199 bootstrap-clean, distclean, maintainer-clean, versioclean,
202 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
203 This is a bit clearer. Fix some commentary typos.
205 2012-07-30 Glenn Morris <rgm@gnu.org>
207 * s/netbsd.h: Let configure include signal.h if needed.
208 Remove file, which is now empty.
210 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
211 Let configure set them.
212 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
213 No more need to undefine.
215 2012-07-30 Andreas Schwab <schwab@linux-m68k.org>
217 * keymap.c (Fkey_description): Don't remove 0x80 bit from
218 non-single-byte char when adding meta modifier. (Bug#12090)
220 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
222 Convert safe_call to use variable number of arguments.
223 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
224 (safe_call2): Fix comment.
225 * lisp.h (safe_call): Adjust prototype.
226 * coding.c (encode_coding_object): Change to use safe_call2.
227 * xfaces.c (merge_face_heights): Change to use safe_call1.
229 2012-07-30 Glenn Morris <rgm@gnu.org>
231 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
232 does that unconditionally. Remove file, which is now empty.
234 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
237 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
239 Export to GDB most of lisp.h's remaining object-like macros.
240 * lisp.h (min, max): Move earlier, because they're used earlier now.
241 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
242 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
243 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
244 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
245 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
246 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
247 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
248 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
249 Now constants, for GDB. They need not be macros.
250 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
251 Now constants, for GDB, as well as macros, for static initializers.
252 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
253 Move to after the definition of struct Lisp_Char_Table,
254 since the former now needs that type defined.
255 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
256 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
257 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
258 New enums, for gdb_make_enums_visible.
259 (GLYPH_MODE_LINE_FACE): Remove; unused.
260 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
261 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
262 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
263 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
264 enum maxargs, enum MAX_ALLOCA.
265 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
266 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
267 no longer needed, now that they are done in lisp.h.
269 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
271 Cleanup string bytes checking.
272 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
273 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
274 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
275 (check_sblock, compact_small_strings): Simplify.
277 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
279 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
280 These macros are confusing and no longer need to be defined, as
281 the enum values now suffice. All uses replaced with definiens.
282 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
284 2012-07-29 Juanma Barranquero <lekktu@gmail.com>
286 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
287 ($(BLD)/w32console.$(O)): Update dependencies.
289 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
291 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
292 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
294 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
296 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
298 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
299 setting sitelisp (Bug#12010).
301 2012-07-29 Eli Zaretskii <eliz@gnu.org>
303 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
305 * w32heap.c (cache_system_info):
306 * w32.c (sys_rename):
307 * w32proc.c (find_child_console, sys_kill): All users changed.
309 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
311 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
313 2012-07-29 Eli Zaretskii <eliz@gnu.org>
315 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
317 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
319 Cleanup statistics calculation in Fgarbage_collect.
320 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
321 zombies percentage calculation. Simplify elapsed time calculation.
323 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
325 Generalize marker debugging code under MARKER_DEBUG and use eassert.
326 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
327 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
328 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
329 (replace_range, replace_range_2, del_range_2): Change to eassert.
330 * marker.c (byte_char_debug_check): Adjust style.
332 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
334 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
335 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
336 long-ago-commented-out code that talks about "WIN32".
337 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
340 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
342 Use Gnulib stdalign module (Bug#9772, Bug#9960).
343 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
344 Simplify by using alignof.
345 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
346 * lisp.h: Include <stdalign.h>.
347 (GCALIGNMENT): New macro and constant.
348 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
349 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
350 (stdalign): New macro, if not already defined.
352 2012-07-28 Eli Zaretskii <eliz@gnu.org>
354 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
355 * w32inevt.c: Include w32inevt.h.
356 (w32_read_console_input): New inline function, calls either
357 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
358 w32_console_unicode_input.
359 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
360 (w32_kbd_patch_key, key_event): Use the codepage returned by
361 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
362 (key_event): use uChar.UnicodeChar only if
363 w32_console_unicode_input is non-zero.
365 * w32console.c: Include w32heap.h.
366 <w32_console_unicode_input>: New global variable.
367 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
368 family of Windows, zero otherwise.
370 * w32inevt.h: Declare w32_console_unicode_input.
372 * xdisp.c (init_iterator): Don't reference tip_frame in a build
373 --without-x. (Bug#11742)
375 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
377 Adjust GDB to reflect pvec_type changes (Bug#12036).
378 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
379 2012-07-04 changes to pseudovector representation. Problem
380 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
382 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
384 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
386 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
388 2012-07-27 Eli Zaretskii <eliz@gnu.org>
390 * alloc.c (listn): Fix the order the arguments are consed onto the
393 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
394 enumeration constants, as PURE and HEAP are too general, and clash
395 with other headers and sources, such as gmalloc.c and the
396 MS-Windows system headers. All users changed.
398 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
400 Revert last save_excursion_save and save_excursion_restore changes.
401 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
402 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
404 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
406 Fix recently-introduced typos in Windows port.
407 Reported by Martin Rudalics <rudalics@gmx.at>.
408 * w32.c (init_environment): Replace comma with semicolon.
409 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
411 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
413 Improve GDB symbol export (Bug#12036).
414 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
415 arms of an 'if', not using conditional expressions; otherwise GDB
416 complains about the types in the unevaluated arm when the argument
417 is an integer literal.
418 (xgetint): Simplify expression.
419 * alloc.c (gdb_make_enums_visible): New constant. This ports to
420 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
421 Zaretskii in <http://bugs.gnu.org/12036#13>.
422 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
423 needed now that we have gdb_make_enums_visible.
424 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
425 (enum enum_USE_LSB_TAG):
426 New enum types, packaging up enums that need to be exported to GDB.
428 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
430 Utility function to make a list from specified amount of objects.
431 * lisp.h (enum constype): New datatype.
432 (listn): New prototype.
433 * alloc.c (listn): New function.
434 (Fmemory_use_count, syms_of_alloc): Use it.
435 * buffer.c (syms_of_buffer): Likewise.
436 * callint.c (syms_of_callint): Likewise.
437 * charset.c (define_charset_internal): Likewise.
438 * coding.c (syms_of_coding): Likewise.
439 * keymap.c (syms_of_keymap): Likewise.
440 * search.c (syms_of_search): Likewise.
441 * syntax.c (syms_of_syntax): Likewise.
442 * w32.c (init_environment): Likewise.
443 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
444 * xdisp.c (syms_of_xdisp): Likewise.
445 * xfns.c (syms_of_xfns): Likewise.
447 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
449 Fast save_excursion_save and save_excursion_restore.
450 * lisp.h (struct Lisp_Excursion): New data type.
451 (PVEC_EXCURSION): New pseudovector type.
452 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
453 to deal with it. Adjust comments.
454 (init_marker, attach_marker): New prototype.
455 (unchain_marker): Adjust prototype.
456 * marker.c (attach_marker): Change to global.
457 (init_marker): New function.
458 * alloc.c (Fmake_marker, build_marker): Use it.
459 (build_marker): More easserts.
460 (mark_object): Handle struct Lisp_Excursion.
461 * editfns.c (save_excursion_save, save_excursion_restore):
462 Reimplement to use struct Lisp_Excursion. Add comments.
464 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
466 Fix export of symbols to GDB (Bug#12036).
467 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
468 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
469 emacs.c, as this is a more-suitable home. Had this been done earlier
470 the fix for 12036 would have avoided some of the problems noted in
471 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
472 would have been more obvious.
473 * emacs.c: Do not include <verify.h>; no longer needed.
474 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
475 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
476 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
477 Remove; now done in lisp.h.
478 * lisp.h (PUBLISH_TO_GDB): New macro.
479 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
480 (DATA_SEG_BITS): Use it.
481 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
482 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
483 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
484 not be usable in #if. This simplifies things.
486 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
488 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
490 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
492 Simplify export of symbols to GDB (Bug#12036).
493 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
494 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
495 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
496 Adjust to changes in lisp.h and emacs.c, by using
497 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
498 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
499 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
500 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
501 instead of gdb_valbits.
502 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
503 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
504 instead of gdb_array_mark_flag.
505 (xboolvector): Get size from $->size, not $->header.size.
506 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
507 (xreload, hook-run, hookpost-run): Remove.
508 * emacs.c: Include <verify.h>.
509 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
510 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
512 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
513 (gdb_USE_LSB_TAG): New enum constants.
514 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
515 Also define these as enum constants, so they're visible to GDB.
516 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
517 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
518 as constants, so they're visible to GDB.
519 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
520 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
521 Now enum constants, not macros, so they're visible to GDB.
522 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
523 more convenient now. All uses changed.
524 (VALMASK) [USE_LSB_TAG]: Also define in this case.
525 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
527 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
529 Explicitly free restriction data that are not needed anymore.
530 * editfns.c (save_restriction_restore): Free restriction data.
532 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
534 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
535 add argument, tune behavior, and adjust all callers.
537 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
539 Use typedef for EMACS_INT, EMACS_UINT.
540 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
541 than macros. This simplifies debugging in the usual case, since
542 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
543 and it allows expressions involving EMACS_INT casts.
544 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
546 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
548 * nsterm.m (ns_read_socket): Return early if there is a modal
551 2012-07-25 Martin Rudalics <rudalics@gmx.at>
553 * frame.c (Fredirect_frame_focus): In doc-string don't mention
554 that FOCUS-FRAME can be omitted.
556 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
558 Adjust buffer text indirection counters at the end of Fkill_buffer.
559 * buffer.c (Fkill_buffer): Adjust indirection counters when the
560 buffer is definitely dead. This should really fix an issue reported
561 by Christoph Scholtes again. (Bug#12007).
562 (init_buffer_once): Initialize indirection counters of
563 buffer_defaults and buffer_local_symbols (for sanity and safety).
565 2012-07-24 Eli Zaretskii <eliz@gnu.org>
567 * xdisp.c (init_iterator): Don't compute dimensions of truncation
568 and continuation glyphs on tooltip frames, leave them at zero.
569 Avoids continued lines in tooltips. (Bug#11832)
571 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
573 Simplify copy_overlay.
574 * buffer.c (copy_overlay): Simplify. Use build_marker.
575 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
577 2012-07-23 Eli Zaretskii <eliz@gnu.org>
579 * print.c (print_object): Don't crash when a frame's name is nil
580 or invalid. (Bug#12025)
582 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
583 it signals an error when a tooltip frame is being created.
585 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
587 Cleanup miscellaneous objects allocation and initialization.
588 * alloc.c (allocate_misc): Change to static. Add argument to
589 specify the subtype. Adjust comment and users.
590 (build_overlay): New function.
591 * buffer.c (copy_overlays, Fmake_overlay): Use it.
592 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
593 (allocate_misc): Remove prototype.
594 (build_overlay): Add prototype.
596 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
598 Swap buffer text indirection counters in Fbuffer_swap_text.
599 * buffer.c (Fbuffer_swap_text): Swap indirections too.
600 This avoids crash reported by Christoph Scholtes at
601 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
603 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
605 * nsmenu.m (Popdown_data): New struct.
606 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
608 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
609 (initWithContentRect): Make imgView and contentView non-static
610 and autorelease them. Also autorelease img and matrix (Bug#12005).
611 (dealloc): Remove (Bug#12005).
613 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
615 Adjust consing_since_gc when objects are explicitly freed.
616 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
617 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
618 (free_cons, free_misc): Subtract object size from consing_since_gc.
620 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
622 Simplify and cleanup markers positioning code.
623 * marker.c (attach_marker): More useful eassert.
624 (live_buffer, set_marker_internal): New function.
625 (Fset_marker, set_marker_restricted): Use set_marker_internal.
626 (set_marker_both, set_marker_restricted_both): Use live_buffer.
628 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
630 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
631 as it's limited by the amount of memory, not by INT_MAX.
633 2012-07-21 Eli Zaretskii <eliz@gnu.org>
635 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
636 in special-event-map. See the discussion at
637 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
640 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
641 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
642 Fabrice Popineau <fabrice.popineau@supelec.fr>.
644 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
646 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
647 (conversationIdentifier): Return value is NSInteger.
648 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
650 2012-07-21 Chong Yidong <cyd@gnu.org>
652 * window.c (decode_any_window): Signal an error if the window is
653 on a dead frame (Bug#11984).
655 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
657 Add indirection counting to speed up Fkill_buffer.
658 * buffer.h (struct buffer): New member.
659 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
660 (Fmake_indirect_buffer): Set indirection counter to -1, increment
661 base buffer indirection counter.
662 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
663 (Fkill_buffer): Adjust indirection counters as needed, don't walk
664 through buffer list if indirection counter is 0.
666 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
668 Extend the value returned by Fgarbage_collect with heap statistics.
669 * alloc.c (Qheap): New symbol.
670 (syms_of_alloc): DEFSYM it.
671 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
672 (Fmemory_free): Remove.
673 (syms_of_alloc): Don't defsubr it.
674 * buffer.c (Fcompact_buffer): Remove.
675 (syms_of_buffer): Don't defsubr it.
677 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
679 Make maybe_gc inline.
680 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
681 * lisp.h (consing_since_gc, gc_relative_threshold)
682 (memory_full_cons_threshold): Revert declaration.
683 (maybe_gc): Remove prototype, define as inline.
684 * alloc.c: Remove old commented-out code.
685 (consing_since_gc, gc_relative_threshold)
686 (memory_full_cons_threshold): Revert to global.
689 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
691 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
692 * lisp.h (build_unibyte_string): New function.
693 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
694 * sysdep.c, w32fns.c, xfns.c: Use it.
695 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
696 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
697 Adjust users accordingly.
698 * font.h (font_open_by_name): Adjust prototype.
700 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
702 Cleanup calls to Fgarbage_collect.
703 * lisp.h (maybe_gc): New prototype.
704 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
706 * alloc.c (maybe_gc): New function.
707 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
709 * bytecode.c (MAYBE_GC): Use maybe_gc.
710 * eval.c (eval_sub, Ffuncall): Likewise.
711 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
712 to avoid dependency from auto-save feature.
714 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
716 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
717 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
718 'for_each_per_buffer_object_at'.
719 All uses changed. It's better to use upper-case for macros that
720 cannot be implemented as functions, to give the reader a clue
721 that they're special.
723 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
725 * alloc.c (Fgarbage_collect): Tweak docstring.
727 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
729 Tweak the value returned from Fgarbage_collect again.
730 * alloc.c (Fgarbage_collect): New return value, as confirmed in
731 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
732 Adjust documentation.
733 (total_vector_bytes): Rename to total_vector_slots, adjust
735 (total_free_vector_bytes): Rename to total_free_vector_slots,
737 (Qstring_bytes, Qvector_slots): New symbols.
738 (syms_of_alloc): DEFSYM them.
740 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
742 Buffer compaction primitive which may be used from Lisp.
743 * buffer.c (compact_buffer, Fcompact_buffer): New function.
744 (syms_of_buffer): Register Fcompact_buffer.
745 * alloc.c (Fgarbage_collect): Use compact_buffer.
746 * buffer.h (compact_buffer): New prototype.
747 (struct buffer_text): New member.
749 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
751 New macro to iterate over all buffers, miscellaneous cleanups.
752 * lisp.h (all_buffers): Remove declaration.
753 * buffer.h (all_buffers): Add declaration, with comment.
754 (for_each_buffer): New macro.
755 * alloc.c (Fgarbage_collect, mark_object): Use it.
756 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
757 (init_buffer): Likewise.
758 * data.c (Fset_default): Likewise.
759 * coding.c (code_conversion_restore): Remove redundant check
761 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
763 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
765 Fix bug that created negative-length intervals.
766 * intervals.c (merge_interval_right, merge_interval_left):
767 Do not zero out this interval if it is absorbed by its children,
768 as this interval's total length doesn't change in that case. See
769 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
771 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
773 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
774 when invoking (make-bool-vector N t) and N is a positive
775 multiple of 8 -- the last 8 bits were mistakenly cleared.
777 Remove some struct layout assumptions in bool vectors.
778 * alloc.c (bool_header_size): New constant.
779 (header_size, word_size): Move earlier, as they're now used earlier.
780 Use 'word_size' in a few more places, where it's appropriate.
781 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
782 padding before the data member of a bool vector.
783 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
784 than doing the check by hand with an abort ().
786 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
788 * eval.c (Fdefvar): Don't check constants since we only set the var if
789 it's not yet defined anyway (bug#11904).
791 * lisp.h (last_undo_boundary): Declare new var.
792 * keyboard.c (command_loop_1): Set it.
793 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
794 were auto-added by the command loop (bug#11774).
796 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
798 * w32font.c (Qsymbol): Remove local definition.
799 (syms_of_w32font): Don't DEFSYM it.
801 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
803 Fix sweep_vectors to handle large bool vectors correctly.
804 * alloc.c (sweep_vectors): Account total_vector_bytes for
805 bool vectors larger than VBLOCK_BYTES_MAX.
807 2012-07-18 Chong Yidong <cyd@gnu.org>
809 * frame.c (x_set_frame_parameters): Revert bogus change introduced
810 in 2012-05-25 commit by Paul Eggert (Bug#11738).
812 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
814 Return more descriptive data from Fgarbage_collect.
815 Suggested by Stefan Monnier in
816 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
817 * alloc.c (bounded_number): New function.
818 (total_buffers, total_vectors): New variable.
819 (total_string_size): Rename to total_string_bytes, adjust users.
820 (total_vector_size): Rename to total_vector_bytes, adjust users.
821 (sweep_vectors): Account total_vectors and total_vector_bytes.
822 (Fgarbage_collect): New return value. Adjust documentation.
823 (gc_sweep): Account total_buffers.
824 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
825 (VECTOR_SIZE): Remove.
826 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
827 (Qinterval, Qmisc): New symbols.
828 (syms_of_data): Initialize them.
829 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
830 (Qcons, Qbuffer): New declarations.
832 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
834 * alloc.c (Fmemory_free): Account for memory-free's own storage.
835 Round up, not down. Improve doc.
837 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
839 Restore old code in allocate_string_data to avoid Faset breakage.
840 Reported by Julien Danjou <julien@danjou.info> in
841 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
842 * alloc.c (allocate_string_data): Restore old code with minor
843 adjustments, fix comment to explain this subtle issue.
845 2012-07-17 Eli Zaretskii <eliz@gnu.org>
847 Remove FILE_SYSTEM_CASE.
848 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
850 * fileio.c (FILE_SYSTEM_CASE): Don't define.
851 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
852 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
853 call-process-region passes it through expand-file-name.
855 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
857 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
859 Fix crash when creating indirect buffer (Bug#11917)
860 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
861 Don't handle unbound variables specially if non-zero.
862 (Fbuffer_local_variables): Pass zero.
863 (clone_per_buffer_values): Pass non-zero.
865 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
867 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
868 to make the loop interruptible.
870 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
872 * gnutls.c (emacs_gnutls_handshake): Only retry if
873 GNUTLS_E_INTERRUPTED.
875 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
877 Cleanup and convert miscellaneous checks to eassert.
878 * alloc.c (mark_interval): Fix comment, partially rephrase
879 old comment from intervals.h (see below).
880 * intervals.c (find_interval, adjust_intervals_for_insertion)
881 (delete_interval, adjust_intervals_for_deletion)
882 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
884 (adjust_intervals_for_insertion, make_new_interval):
885 Remove obsolete and unused code.
886 * intervals.h (struct interval): Remove obsolete comment.
887 * textprotp.c (erase_properties): Remove unused code.
888 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
889 (Fremove_list_of_text_properties): Convert to eassert.
891 2012-07-17 Chong Yidong <cyd@gnu.org>
893 * editfns.c (Finsert_char): Doc fix.
895 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
897 Fix previous change to make Fmemory_free always accurate.
898 * alloc.c (make_interval): Update total_free_intervals.
899 (make_float): Likewise for total_free_floats.
900 (free_cons, Fcons): Likewise for total_free_conses.
901 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
902 Likewise for total_free_vector_bytes.
903 (Fmake_symbol): Likewise for total_free_symbols.
904 (bytes_free): Remove.
906 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
908 Simple free memory accounting feature.
909 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
910 (sweep_vectors): Accumulate size of free vectors.
911 (Fgarbage_collect): Setup bytes_free.
912 (Fmemory_free): New function.
913 (syms_of_alloc): Register it.
915 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
917 Cleanup overlays checking.
918 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
919 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
920 eassert and OVERLAYP.
921 (sort_overlays): Change to use OVERLAYP.
923 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
925 * editfns.c (Finsert_char): Make it interactive, and make the
926 second arg optional. Copy interactive spec and docstring from
929 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
931 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
932 Unlike the other wrapped functions, fabs has an unspecified
935 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
937 * nsterm.m (keyDown): Interpret flags without left/right bits
938 as the left key (Bug#11670).
940 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
942 Remove empty and useless init functions.
943 * lisp.h (init_character_once, init_fns, init_image)
944 (init_filelock, init_sound): Remove prototype.
945 * character.c (init_character_once): Remove.
946 * filelock.c (init_filelock): Likewise.
947 * fns.c (init_fns): Likewise.
948 * image.c (init_image): Likewise.
949 * sound.c (init_sound): Likewise.
950 * emacs.c (main): Adjust accordingly.
952 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
954 * gtkutil.h: Tiny cleanups.
955 (use_old_gtk_file_dialog): Remove useless declaration.
956 (xg_uses_old_file_dialog): Add suggested const attribute.
958 2012-07-15 Eli Zaretskii <eliz@gnu.org>
960 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
961 (bidi_paragraph_init): Use it to limit search forward for a strong
962 directional character in abnormally large paragraphs full of
963 neutral or weak characters. (Bug#11943)
965 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
967 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
968 the toolbar (Bug#9451).
969 (xg_make_tool_item): Give the widget event box a transparent
972 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
974 Cleanup basic allocation variables and functions.
975 * alloc.c (ignore_warnings, init_intervals, init_float)
976 (init_cons, init_symbol, init_marker): Remove.
977 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
978 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
979 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
980 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
981 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
982 (staticidx, init_alloc_once, init_strings, free_ablock):
983 Remove redundant initialization.
984 * fns.c (init_weak_hash_tables): Remove.
985 * lisp.h (init_weak_hash_tables): Remove prototype.
987 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
989 Use zero_vector where appropriate.
990 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
992 * lisp.h (zero_vector): New declaration.
993 * font.c (null_vector): Remove.
994 (syms_of_font): Remove initialization and staticpro.
995 (font_list_entities, font_find_for_lface): Change to use zero_vector.
996 * keymap.c (Faccessible_keymaps): Likewise.
998 2012-07-15 Leo Liu <sdl.web@gmail.com>
1000 * fringe.c: Fix typo in comments.
1002 2012-07-14 Leo Liu <sdl.web@gmail.com>
1004 * fringe.c: Add a new bitmap exclamation-mark.
1006 2012-07-14 Eli Zaretskii <eliz@gnu.org>
1008 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1010 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1011 (HAVE_MENUS): Don't define, defined by editing config.in with
1013 (GMALLOC_INHIBIT_VALLOC): Don't define.
1014 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1016 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
1018 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1020 2012-07-14 Glenn Morris <rgm@gnu.org>
1022 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1023 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1024 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1026 2012-07-13 Glenn Morris <rgm@gnu.org>
1028 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1030 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1031 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1033 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1035 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1036 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1037 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1038 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1040 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1041 as boolean expression.
1042 (x_set_window_size): Remove unused variable toolbar.
1043 (ns_get_color_default, ns_mod_to_lisp): Remove.
1044 (ns_mouse_position): Remove unused variables xchar and ychar.
1045 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1046 (ns_set_vertical_scroll_bar): Remove unused variable count.
1047 (ns_delete_terminal): Remove unused variable i.
1048 (ns_term_init): Remove unused variables r, g and b.
1049 (mouseDown): Remove unused variable window.
1050 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1051 (initFrameFromEmacs): Remove unused variable vbextra.
1052 (mouseEntered): Remove unused variables p and dpyinfo.
1053 (mouseExited): Remove unused variables p and r.
1054 (ns_define_frame_cursor, ns_clear_frame_area)
1055 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1056 (menuDown): Assign [sender tag] to variable and cast the variable.
1058 * nsterm.h (menuDown): Add id as type to argument sender.
1059 (ns_display_info_for_name): Add Lisp_Object argument.
1060 (ns_term_init): Add Lisp_Object argument.
1061 (ns_map_event_to_object): Add void argument.
1062 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1063 prototype with arguments and only declare if __OBJC__.
1064 (nxatoms_of_nsselect): Add void argument.
1065 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1066 (ns_alloc_autorelease_pool): Add void argument.
1067 (ns_release_autorelease_pool): Add void* argument.
1068 (ns_get_defaults_value): Add const char* argument.
1070 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1071 (initFromContents): Use SSDATA where appropriate.
1072 (ns_update_menubar): Add braces to ambigous if-else.
1073 (initWithTitle): Put () around assignment in if statement.
1074 (ns_menu_show): Remove unused variables window and keymap.
1075 (update_frame_tool_bar): Remove unused variable selected_p.
1076 (initWithContentRect): Remove unused variable this_cmd_name.
1078 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1080 (setXBMColor): Remove unused variable len.
1081 (setPixmapData): Put () around assignment in loop statement.
1083 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1084 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1086 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1087 around assignment in loop statement.
1088 (nsfont_open): Remove unused variable i.
1089 (nsfont_open): Remove unused variable len.
1090 (nsfont_draw): Remove unused variable cs.
1092 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1093 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1094 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1095 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1096 (Fns_font_name, Fns_perform_service)
1097 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1098 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1099 (ns_set_name): Remove unused variable view.
1100 (x_set_menu_bar_lines): Remove unused variable olines.
1101 (x_set_tool_bar_lines): Remove unused variable root_window.
1102 (Fns_list_colors): Put () around assignment in while statement.
1103 (Fns_perform_service): Remove unused variable len.
1104 (Fns_display_usable_bounds): Remove unused variable top.
1105 (syms_of_nsfns): Remove unused variable i.
1107 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1110 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
1112 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1113 and free it with DestroyExceptionInfo (Bug#11558).
1115 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
1117 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1118 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1119 Set here, not in nt/config.nt.
1121 2012-07-13 Eli Zaretskii <eliz@gnu.org>
1123 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1124 cursor overflow into the last glyph on display line when the right
1125 fringe is off. (Bug#11832)
1127 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1129 * xdisp.c (produce_special_glyphs): Now static.
1130 * dispextern.h (produce_special_glyphs): Remove decl.
1132 2012-07-13 Glenn Morris <rgm@gnu.org>
1134 * s/bsd-common.h, s/cygwin.h: Remove empty files.
1135 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1137 * s/usg5-4-common.h (USG, USG5):
1138 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1139 * s/sol2-6.h (SOLARIS2):
1140 * s/irix6-5.h (IRIX6_5):
1141 * s/hpux10-20.h (USG, USG5, HPUX):
1142 * s/gnu-linux.h (USG, GNU_LINUX):
1143 * s/freebsd.h (BSD_SYSTEM):
1144 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1145 * s/cygwin.h (CYGWIN):
1146 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1147 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1149 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
1151 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
1153 2012-07-13 Glenn Morris <rgm@gnu.org>
1155 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1157 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1159 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1160 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1162 2012-07-12 Glenn Morris <rgm@gnu.org>
1164 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
1166 * process.c (init_process_emacs): Rename from init_process.
1167 The old name is also the name of a Mach system call.
1168 * lisp.h, emacs.c: Update for this name change.
1169 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1172 2012-07-12 Eli Zaretskii <eliz@gnu.org>
1174 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1175 memmove call that removes glyphs covered by the left truncation
1176 glyph. Improve commentary.
1177 (display_line): Fix display of continuation glyphs on GUI frames
1178 when the right fringe is turned off and variable-size fonts are
1179 used in the window. Move the code that appends a stretch glyph to
1180 produce_special_glyphs, so that it could be used for truncation
1181 and continuation glyphs alike.
1182 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1183 glyph of a suitably computed width, to align the special glyphs at
1184 the window margin. Code moved from display_line. (Bug#11832)
1186 2012-07-12 Glenn Morris <rgm@gnu.org>
1188 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1190 * s/gnu-linux.h, s/hpux10-20.h:
1191 Do not unconditionally define HAVE_XRMSETDATABASE.
1193 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1195 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1197 Fix typos that broke OS X build.
1198 Reported by Randal L. Schwartz in
1199 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1200 * nsterm.m (ns_timeout): Add missing local decl.
1201 (ns_get_color): snprintf -> sprintf, to fix typo.
1203 2012-07-12 Glenn Morris <rgm@gnu.org>
1205 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1206 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1207 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1208 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1210 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1211 Move PTY_OPEN to configure.
1213 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1214 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1215 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1217 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1219 Use empty_unibyte_string where applicable.
1220 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1221 * lread.c (read1): Likewise.
1222 * xsettings.c (syms_of_xsettings): Likewise.
1224 2012-07-12 Glenn Morris <rgm@gnu.org>
1226 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1227 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
1228 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1229 * s/hpux10-20.h (RUN_TIME_REMAP):
1230 * s/bsd-common.h (TABDLY): Move to configure.
1232 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1234 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1236 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1237 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
1239 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
1241 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1242 * s/template.h: Move NARROWPROTO to configure.
1244 2012-07-11 Glenn Morris <rgm@gnu.org>
1246 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1247 unused since 2011-01-17 change to systty.h.
1249 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1250 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1251 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1253 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1255 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1257 2012-07-11 Glenn Morris <rgm@gnu.org>
1259 * s/darwin.h, s/gnu-linux.h, s/template.h:
1260 Move INTERRUPT_INPUT to configure.
1262 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1264 Minor adjustments to interning code.
1265 * lisp.h (intern, intern_c_string): Redefine as static inline
1266 wrappers for intern_1 and intern_c_string_1, respectively.
1267 (intern_1, intern_c_string_1): Rename prototypes.
1268 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1270 * font.c (font_intern_prop): Likewise. Adjust comment.
1271 * w32font.c (intern_font_name): Likewise.
1273 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1275 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1277 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1278 of Fcar/Fcdr if possible.
1279 * font.c (check_otf_features): Likewise.
1280 * fontset.c (Fnew_fontset): Likewise.
1281 * gnutls.c (Fgnutls_boot): Likewise.
1282 * minibuf.c (read_minibuf): Likewise.
1283 * msdos.c (IT_set_frame_parameters): Likewise.
1284 * xmenu.c (Fx_popup_dialog): Likewise.
1285 * w32menu.c (Fx_popup_dialog): Likewise.
1287 2012-07-11 Glenn Morris <rgm@gnu.org>
1289 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1290 since nothing has defined it on these platforms.
1292 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1293 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1295 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1296 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1297 Move CLASH_DETECTION to configure.
1299 * s/gnu.h: Remove file, which is now empty.
1301 * s/gnu.h, s/gnu-linux.h:
1302 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1304 2012-07-11 John Wiegley <johnw@newartisans.com>
1306 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1307 function attribute, so we only use it if it exists in the
1310 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1312 Avoid call to strlen in fast_c_string_match_ignore_case.
1313 * search.c (fast_c_string_match_ignore_case): Change to use
1314 length argument. Adjust users accordingly.
1315 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1317 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1319 Assume mkdir, rmdir.
1320 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1321 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1324 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1327 * s/hpux10-20.h (HAVE_PERROR): Remove.
1328 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1329 Remove dummy definition, as this problem was obsolete long ago.
1332 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1334 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1336 Avoid calls to strlen in font processing functions.
1337 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1338 (font_open_by_name): Change to use length argument. Adjust
1340 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1342 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1343 Change to return ptrdiff_t.
1344 (xfont_list_pattern, xfont_match): Use length returned by
1345 xfont_decode_coding_xlfd.
1346 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1348 2012-07-11 Glenn Morris <rgm@gnu.org>
1350 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1351 Move DONT_REOPEN_PTY to configure.
1353 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1354 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1356 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1358 Remove "#define unix" that is no longer needed (Bug#11905).
1359 * s/aix4-2.h (unix): Remove; no longer needed.
1361 EMACS_TIME simplification (Bug#11875).
1362 This replaces macros (which typically do not work in GDB)
1363 with functions, typedefs and enums, making the code easier to debug.
1364 The functional style also makes code easier to read and maintain.
1365 * systime.h: Include <sys/time.h> on all hosts, not just if
1366 WINDOWSNT, since 'struct timeval' is needed in general.
1367 (EMACS_TIME): Now a typedef, not a macro.
1368 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1370 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1371 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1372 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1373 (EMACS_TIME_LE): Now functions, not macros.
1374 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1375 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1376 which are not functions. All uses rewritten to use:
1377 (make_emacs_time): New function.
1378 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1379 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1380 not functions. All uses rewritten to use the following, respectively:
1381 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1382 (add_emacs_time, sub_emacs_time): New functions.
1383 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1384 * fileio.c (Fcopy_file):
1385 * xterm.c (XTflash): Get the current time closer to when it's used.
1386 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1388 * bytecode.c (targets): Suppress -Woverride-init warnings.
1390 Simplify by avoiding confusing use of strncpy etc.
1391 * doc.c (Fsnarf_documentation):
1392 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1393 * frame.c (Fmake_terminal_frame):
1394 * gtkutil.c (get_utf8_string):
1396 * nsmenu.m (ns_update_menubar):
1397 * regex.c (regerror):
1398 Prefer memcpy to strncpy and strncat when either will do.
1399 * fileio.c (Fsubstitute_in_file_name):
1400 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1401 (menu_separator_name_p):
1402 * nsmenu.m (ns_update_menubar):
1403 Prefer memcmp to strncmp when either will do.
1404 * nsterm.m: Include <ftoastr.h>.
1406 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1407 Prefer snprintf to strncpy.
1408 * nsterm.m (ns_term_init):
1409 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1410 * nsterm.m (ns_term_init):
1411 Avoid the need for strncpy, by using build_string or
1412 make_unibyte_string directly. Use dtoastr, not snprintf.
1413 * process.c (Fmake_network_process): Diagnose service names that
1414 are too long, rather than silently truncating them or creating
1415 non-null-terminated names.
1416 (Fnetwork_interface_info): Likewise, for interface names.
1417 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1418 Prefer sprintf to strncat.
1419 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1420 Prefer vsnprintf to vsprintf + strncpy.
1422 2012-07-10 Glenn Morris <rgm@gnu.org>
1424 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1425 Clarify fallback case.
1427 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1429 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1430 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1431 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1432 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1433 where argument type is known to be a Lisp_Cons.
1435 2012-07-10 Tom Tromey <tromey@redhat.com>
1437 * bytecode.c (BYTE_CODE_THREADED): New macro.
1438 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1439 (enum byte_code_op): New type.
1440 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1441 (exec_byte_code): Use them. Use token threading when applicable.
1443 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1445 Optimize pure C strings initialization.
1446 * lisp.h (make_pure_string): Fix prototype.
1447 (build_pure_c_string): New function, defined as static inline. This
1448 provides a better opportunity to optimize away calls to strlen when
1449 the function is called with compile-time constant argument.
1450 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1451 argument, adjust users accordingly. Use build_pure_c_string where
1453 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1454 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1455 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1457 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1459 Avoid calls to strlen in miscellaneous functions.
1460 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1461 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1462 * lread.c (openp): Likewise.
1464 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1466 Avoid calls to strlen in path processing functions.
1467 * fileio.c (file_name_as_directory): Add comment. Change to add
1468 srclen argument and return the length of result. Adjust users
1470 (directory_file_name): Fix comment. Change to add srclen argument,
1471 swap 1st and 2nd arguments to obey the common convention. Adjust
1473 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1475 2012-07-10 Glenn Morris <rgm@gnu.org>
1477 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1478 Move PENDING_OUTPUT_COUNT definition to configure.
1480 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1481 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1482 * s/gnu.h (DATA_START): Move definitions to configure.
1484 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1485 We include usg5-4-common.h, which defines them both.
1487 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1488 O_RDONLY already includes it).
1490 Stop ns builds setting the EMACSLOADPATH environment variable.
1491 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1492 Now it does not set EMACSLOADPATH, just returns the load-path string.
1493 * nsterm.h: Update accordingly.
1494 * lread.c [HAVE_NS]: Include nsterm.h.
1495 (init_lread) [HAVE_NS]: Use ns_load_path.
1496 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1498 2012-07-09 Glenn Morris <rgm@gnu.org>
1500 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1501 since the included bsd-common.h does so.
1503 Stop ns builds setting the EMACSPATH environment variable.
1504 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1505 (ns_init_paths): Do not set EMACSPATH.
1506 * nsterm.h (ns_exec_path): Add it.
1507 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1510 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1512 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1514 * process.c (wait_reading_process_output): 'waitchannels' was unset
1515 when read_kbd || !NILP (wait_for_cell); fix this.
1517 Add GCC-style 'const' attribute to functions that can use it.
1518 * character.h (char_resolve_modifier_mask):
1519 * keyboard.h (make_ctrl_char):
1520 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1521 (init_character_once, next_almost_prime, init_fns, init_image)
1522 (flush_pending_output, init_sound):
1523 * mem-limits.h (start_of_data):
1524 * menu.h (finish_menu_items):
1525 Add ATTRIBUTE_CONST.
1526 * emacs.c (DEFINE_DUMMY_FUNCTION):
1527 Declare the dummy function with ATTRIBUTE_CONST.
1528 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1529 Add decls with ATTRIBUTE_CONST.
1531 Minor improvements to make_formatted_string.
1532 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1533 where int is good enough, as vsprintf returns an int.
1534 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1536 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1538 Use make_formatted_string to avoid double length calculation.
1539 * lisp.h (make_formatted_string): New prototype.
1540 * alloc.c (make_formatted_string): New function.
1541 * buffer.c (Fgenerate_new_buffer_name): Use it.
1542 * dbus.c (syms_of_dbusbind): Likewise.
1543 * editfns.c (Fcurrent_time_zone): Likewise.
1544 * filelock.c (get_boot_time): Likewise.
1545 * frame.c (make_terminal_frame, set_term_frame_name)
1546 (x_report_frame_params): Likewise.
1547 * image.c (gs_load): Likewise.
1548 * minibuf.c (get_minibuffer): Likewise.
1549 * msdos.c (dos_set_window_size): Likewise.
1550 * process.c (make_process): Likewise.
1551 * xdisp.c (ensure_echo_area_buffers): Likewise.
1552 * xsettings.c (apply_xft_settings): Likewise.
1554 2012-07-09 Glenn Morris <rgm@gnu.org>
1556 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1557 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1558 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1559 * nsterm.h (ns_etc_directory): Add it.
1560 * callproc.c [HAVE_NS]: Include nsterm.h.
1561 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1563 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1565 Move marker debugging code under MARKER_DEBUG.
1566 * marker.c (MARKER_DEBUG): Move marker debugging code under
1567 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1568 for bootstrap with --enable-checking (~3x slowdown reported
1569 by Juanma Barranquero <lekktu@gmail.com>).
1570 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1572 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1574 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1575 See <http://bugs.gnu.org/11825#29>.
1577 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1579 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1580 has no font, use the frame's font. (Bug#11813)
1581 (display_line): Add commentary about displaying truncation glyphs
1583 (produce_special_glyphs): Move here from term.c.
1585 * term.c (produce_special_glyphs): Move to xdisp.c.
1587 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1590 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1592 * xdisp.c (display_line): Avoid warning about implicit declaration
1595 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1597 * lisp.h: Remove empty conditional.
1599 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1601 * lread.c (load_path_check): Now static.
1603 Fix some minor --with-ns problems found by static checking.
1604 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1605 (x_set_font) [!HAVE_X_WINDOWS]:
1606 * image.c (xpm_load_image) [HAVE_NS]:
1607 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1608 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1609 Remove unused local.
1610 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1611 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1612 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1613 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1614 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1615 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1616 Fix pointer signedness problem.
1617 * xfaces.c (FRAME_X_FONT_TABLE):
1618 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1620 2012-07-07 Glenn Morris <rgm@gnu.org>
1622 * lread.c (load_path_check): New function, split from init_lread.
1623 (init_lread): Reorganize. Motivation:
1624 If EMACSLOADPATH is set, check/warn about that rather than the
1625 defaults, which we are not going to use. Hence we can remove
1626 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1627 Don't warn if site-lisp directories are missing.
1628 If not installed, start from a blank load-path, since
1629 PATH_LOADSEARCH refers to the eventual installation directories.
1631 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1633 Support truncation and continuation glyphs on GUI frames, when
1634 fringes are disabled. (Bug#11832)
1635 * xdisp.c (init_iterator): Get dimensions of truncation and
1636 continuation glyphs even if on GUI frames. Adjust
1637 it->last_visible_x on GUI frames when the left or right fringes,
1638 or both, are absent.
1639 (start_display, move_it_in_display_line_to): Handle the case of a
1640 GUI frame without a fringe to display continuation or truncation
1642 (insert_left_trunc_glyphs): Support GUI frames: make sure
1643 truncation glyphs overwrite enough glyphs from the current line to
1644 have sufficient space in pixels.
1645 (display_line): Support truncation and continuation glyphs on GUI
1646 frames. If some spare pixels are left on the line after inserting
1647 the truncation glyphs, fill that space with a stretch glyph of a
1648 suitably computed width.
1650 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1651 produce_glyphs, to support GUI sessions.
1653 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1655 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1657 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1659 Do not require float-time's arg to fit in time_t (Bug#11825).
1660 This works better on hosts where time_t is unsigned, and where
1661 float-time is applied to the (negative) difference between two times.
1662 * editfns.c (decode_time_components): Last arg is now double *,
1663 not int *, and means to store all the result as a double, without
1664 worrying about whether the seconds part fits in time_t.
1665 All callers changed.
1666 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1667 All callers changed.
1668 (Ffloat_time): Do not fail merely because the specified time falls
1669 outside of time_t range.
1671 2012-07-07 Glenn Morris <rgm@gnu.org>
1673 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1674 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1675 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1677 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1679 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1680 Update dependencies.
1682 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1684 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1686 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1687 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1688 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1689 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1690 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1691 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1693 * xfont.c (compare_font_names): Redo to omit the need for casts.
1695 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1697 * xfns.c (Fx_change_window_property): Doc fix.
1698 * w32fns.c (Fx_change_window_property): Doc fix.
1700 * w32fns.c (Fx_window_property): Accept the same arguments as the
1701 X Windows version. Doc fix.
1702 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1704 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1705 Eli Zaretskii <eliz@gnu.org>
1707 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1708 Windows-specific code from nt/config.nt moved here.
1709 Obsolete settings removed.
1711 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1713 * process.c: Avoid unnecessary calls to gettime.
1714 (wait_reading_process_output): Don't get the time of day
1715 when gobbling data immediately and not waiting, as there's no need
1716 for it in that case. This removes a FIXME.
1718 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1720 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1721 is defined (Bug#11768).
1723 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1725 Fix marker debugging code.
1726 * marker.c (byte_char_debug_check): Do not perform the check
1727 if buffer is not multibyte.
1728 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1729 Call byte_char_debug_check with correct arguments.
1731 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1733 Compile marker debugging code only if ENABLE_CHECKING is defined.
1734 * marker.c (byte_char_debug_check, count_markers):
1735 Use only if ENABLE_CHECKING is defined.
1736 (byte_debug_flag): Remove.
1737 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1738 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1740 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1742 Avoid code repetition in marker-related functions.
1743 * marker.c (attach_marker): New function.
1744 (Fset_marker, set_marker_restricted, set_marker_both)
1745 (set_marker_restricted_both): Use it.
1746 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1747 Consistently rename charno to charpos.
1748 (marker_position): Add eassert.
1749 (marker_byte_position): Convert to eassert.
1751 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1753 Simplify list operations in unchain_overlay and unchain_marker.
1754 * buffer.c (unchain_overlay): Simplify. Add comment.
1755 * marker.c (unchain_marker): Simplify. Fix comments.
1757 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1759 Introduce fast path for the widely used marker operation.
1760 * alloc.c (build_marker): New function.
1761 * lisp.h (build_marker): New prototype.
1762 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1763 * composite.c (autocmp_chars): Likewise.
1764 * editfns.c (buildmark): Remove.
1765 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1766 (save_restriction_save): Use build_marker.
1767 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1768 * window.c (save_window_save): Likewise.
1770 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1772 Do not use Fdelete_overlay in delete_all_overlays
1773 to avoid redundant calls to unchain_overlay.
1774 * buffer.c (drop_overlay): New function.
1775 (delete_all_overlays, Fdelete_overlay): Use it.
1776 * minibuf.c (get_minibuffer): Fix comment.
1778 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1780 Port to OpenBSD 5.1 amd64.
1781 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1782 This is needed for OpenBSD, and should be harmless on all BSD systems.
1783 Also, include <sys/sysctl.h>, as it should be available on all
1784 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1785 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1786 use p_pid member, not kp_proc.pid.
1788 2012-07-06 Glenn Morris <rgm@gnu.org>
1790 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1792 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1794 More xmalloc and related cleanup.
1795 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1796 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1797 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1798 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1799 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1800 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1801 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1802 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1803 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1805 Omit needless casts involving void * pointers and allocation.
1806 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1807 as the former is more robust if P's type is changed.
1808 Prefer xzalloc to xmalloc + memset 0.
1809 Simplify malloc-or-realloc to realloc.
1810 Don't worry about xmalloc returning a null pointer.
1811 Prefer xstrdup to xmalloc + strcpy.
1812 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1814 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1815 alloca of a constant.
1817 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1819 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1820 hscroll is larger than the line width. Fixes long and futile
1821 looping inside extend_face_to_end_of_line (on a TTY) producing
1822 glyphs that are not needed and thrown away.
1824 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1826 * marker.c (set_marker_restricted_both): Simplify by using
1829 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1831 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1833 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1835 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1836 not defined (Bug#11768).
1837 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1838 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1839 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1840 followed by gtk_box_set_homogeneous (Bug#11768).
1841 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1842 (update_theme_scrollbar_width, xg_create_scroll_bar):
1843 Use gtk_scrollbar_new (Bug#11768).
1844 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1845 (is_box_type): New function (Bug#11768).
1846 (xg_tool_item_stale_p): Call is_box_type.
1847 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1848 with default display (Bug#11768).
1850 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1852 * xdisp.c (window_hscroll_limited): New function.
1853 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1854 coordinates when window's hscroll is set to insanely large
1857 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1859 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1860 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1862 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1865 * lisp.h (xzalloc): New prototype. Omit needless casts.
1866 * alloc.c (xzalloc): New function. Omit needless casts.
1867 * charset.c: Omit needless casts. Convert all calls to
1868 xmalloc with following memset to xzalloc.
1869 * dispnew.c: Likewise.
1870 * fringe.c: Likewise.
1871 * image.c: Likewise.
1872 * sound.c: Likewise.
1874 * w32fns.c: Likewise.
1875 * w32font.c: Likewise.
1876 * w32term.c: Likewise.
1877 * xfaces.c: Likewise.
1879 * xterm.c: Likewise.
1880 * atimer.c: Omit needless casts.
1881 * buffer.c: Likewise.
1882 * callproc.c: Likewise.
1884 * coding.c: Likewise.
1885 * composite.c: Likewise.
1887 * doprnt.c: Likewise.
1888 * editfns.c: Likewise.
1889 * emacs.c: Likewise.
1891 * filelock.c: Likewise.
1893 * gtkutil.c: Likewise.
1894 * keyboard.c: Likewise.
1896 * lread.c: Likewise.
1897 * minibuf.c: Likewise.
1898 * msdos.c: Likewise.
1899 * print.c: Likewise.
1900 * process.c: Likewise.
1901 * region-cache.c: Likewise.
1902 * search.c: Likewise.
1903 * sysdep.c: Likewise.
1904 * termcap.c: Likewise.
1905 * terminal.c: Likewise.
1906 * tparam.c: Likewise.
1907 * w16select.c: Likewise.
1909 * w32reg.c: Likewise.
1910 * w32select.c: Likewise.
1911 * w32uniscribe.c: Likewise.
1912 * widget.c: Likewise.
1913 * xdisp.c: Likewise.
1914 * xmenu.c: Likewise.
1916 * xselect.c: Likewise.
1918 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1920 * fileio.c (time_error_value): Check the right error number.
1921 Problem reported by Troels Nielsen in
1922 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1924 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1926 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1927 This should be fixed in a better way; see Eli Zaretskii in
1928 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1929 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1931 * fileio.c (time_error_value): Rename from special_mtime.
1932 The old name's problems were noted by Eli Zaretskii in
1933 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1935 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1936 This variable's comment says Emacs needs at least one GDB-visible
1937 symbol of type enum pvec_type, to work around GDB problems.
1938 The symbol's value doesn't matter.
1940 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1941 that causes compilation to fail on pre-C99 compilers.
1943 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1945 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1946 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1948 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1950 * buffer.c (init_buffer_once): Fix initialization of
1951 headers for buffer_defaults and buffer_local_symbols.
1952 Reported by Juanma Barranquero <lekktu@gmail.com>.
1954 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1956 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1957 * lisp.h (enum pvec_type): Use fewer bits.
1958 (PSEUDOVECTOR_SIZE_BITS): New constant.
1959 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1960 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1961 change in pvec_type.
1962 (PSEUDOVECTOR_TYPEP): New macro.
1963 (TYPED_PSEUDOVECTORP): Use it.
1964 * fns.c (internal_equal): Adapt code to extract pvectype.
1965 * emacs.c (gdb_pvec_type): Update type.
1966 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1967 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1968 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1969 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1970 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1971 abusing vector->header.next.nbytes.
1972 (live_vector_p): Use PVEC_TYPE.
1973 (mark_object): Adapt code to extract pvectype. Use switch.
1975 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1977 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1978 Tighten new eassert a bit.
1980 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1982 Fix compilation with --enable-gcc-warnings and -O1
1984 * doprnt.c (doprnt): Change type of tem to int, initialize
1985 to avoid compiler warning. Add eassert.
1986 * search.c (simple_search): Initialize match_byte to avoid
1987 compiler warning. Add eassert.
1989 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1991 Avoid weird behavior with large horizontal scrolls.
1992 Without this change, for example, large hscroll values would
1993 mess up Emacs's display on Fedora 15 x86, presumably due to
1994 overflows in int calculations in the display code.
1995 Also, if buffers had long lines, Emacs would freeze.
1996 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1997 (set_window_hscroll): New function, containing the old guts of
1998 Fset_window_hscroll. Return the clipped value.
1999 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2000 This avoids the need to check against PTRDIFF_MAX.
2002 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2004 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2006 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2008 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2010 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2011 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2012 since GCC 4.4.6 issues a bogus warning for them.
2014 Fix bugs in file timestamp newness comparisons.
2015 * fileio.c (Ffile_newer_than_file_p):
2016 * lread.c (Fload): Use full timestamp resolution of files,
2017 not just the 1-second resolution, so that files that are only
2018 slightly newer still count as newer.
2019 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2020 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2022 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2024 * fileio.c: Improve handling of file time marker. (Bug#11852)
2025 (special_mtime): New function.
2026 (Finsert_file_contents, Fverify_visited_file_modtime):
2027 Use it to set special mtime values consistently.
2029 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2031 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2032 marker for non-existing file. (Bug#11852)
2034 2012-07-03 Glenn Morris <rgm@gnu.org>
2036 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2037 and did not make it into globals.h).
2039 2012-07-03 Tom Tromey <tromey@redhat.com>
2041 * window.c (Fset_window_margins, Fset_window_fringes)
2042 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2043 * textprop.c (Fprevious_property_change): No longer static.
2044 * syntax.c (Fsyntax_table_p): No longer static.
2045 * process.c (Fget_process, Fprocess_datagram_address): No longer
2047 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2048 * keyboard.c (Fcommand_execute): No longer static.
2050 * insdel.c (Fcombine_after_change_execute): No longer static.
2051 * image.c (Finit_image_library): No longer static.
2052 * fileio.c (Fmake_symbolic_link): No longer static.
2053 * eval.c (Ffetch_bytecode): No longer static.
2054 * editfns.c (Fuser_full_name): No longer static.
2055 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2057 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2059 * dired.c (Ffile_attributes): No longer static.
2060 * composite.c (Fcomposition_get_gstring): No longer static.
2061 * callproc.c (Fgetenv_internal): No longer static.
2063 * ccl.h: Remove EXFUNs.
2064 * buffer.h: Remove EXFUNs.
2065 * dispextern.h: Remove EXFUNs.
2066 * intervals.h: Remove EXFUNs.
2067 * fontset.h: Remove EXFUN.
2068 * font.h: Remove EXFUNs.
2069 * dosfns.c (system_process_attributes): Remove EXFUN.
2070 * keymap.h: Remove EXFUNs.
2071 * lisp.h: Remove EXFUNs.
2072 * w32term.h: Remove EXFUNs.
2073 * window.h: Remove EXFUNs.
2074 * xsettings.h: Remove EXFUN.
2075 * xterm.h: Remove EXFUN.
2077 2012-07-03 Glenn Morris <rgm@gnu.org>
2079 * lisp.h (Frandom): Make it visible to C.
2080 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2081 buffer for invisible buffers. (Bug#1229)
2083 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2085 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2086 values which aren't power of 2.
2087 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2088 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2091 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2093 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2095 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2097 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2099 * alloc.c (allocate_vector_block): Remove redundant
2100 calls to mallopt if DOUG_LEA_MALLOC is defined.
2101 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2102 avoid calls to mallopt if zero_vector is returned.
2104 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2106 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2107 is enabled, avoid dereferencing NULL current_sblock if
2110 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2112 Cleanup basic buffer management.
2113 * buffer.h (struct buffer): Change layout to use generic vector
2114 marking code. Fix some comments. Change type of 'clip_changed'
2115 to bitfield. Remove unused #ifndef old.
2116 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2117 (GET_OVERLAYS_AT): Fix indentation.
2118 (for_each_per_buffer_object_at): New macro.
2119 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2120 (Fbuffer_local_variables): Use it.
2121 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2122 * alloc.c (allocate_buffer): Adjust to match new layout of
2123 struct buffer. Fix comment.
2124 (mark_overlay): New function.
2125 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2126 Lisp area of struct buffer.
2127 (mark_object): Use it. Adjust marking of misc objects
2128 and related comments.
2130 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2132 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2133 wrapper that is not needed because the wrapped code is a no-op (zero
2134 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2135 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2137 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2139 * alloc.c (mark_buffer): Simplify. Remove prototype.
2140 (mark_object): Add comment. Reorganize marking of vector-like
2141 objects. Use CHECK_LIVE for all vector-like objects except buffers
2142 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2143 redundant calls to mark_vectorlike for bool vectors.
2145 2012-06-30 Glenn Morris <rgm@gnu.org>
2147 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2149 * epaths.in (PATH_SITELOADSEARCH): New.
2150 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2151 This is rather than relying on --enable-locallisppath elements
2152 having "site-lisp" in their names. (Bug#10208#25, 11658)
2154 2012-06-30 Eli Zaretskii <eliz@gnu.org>
2156 * w32proc.c (sys_select): Accept and ignore one more argument.
2158 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2160 * sysselect.h [DOS_NT]: Don't include sys/select.h.
2161 (pselect) [!MS_DOS]: Redirect to sys_select.
2163 * sysdep.c: Don't include dos.h and dosfns.h.
2165 * process.c (sys_select):
2166 * msdos.c (sys_select): Accept one more argument and ignore it.
2168 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2169 adapt data types and code to that.
2172 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2173 which clashes with the gnulib function of the same name.
2175 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2177 * font.c (font_style_to_value, font_style_symbolic)
2178 (font_prop_validate_style): Add type checks for values in
2181 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2183 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2186 2012-06-29 Eli Zaretskii <eliz@gnu.org>
2188 * xdisp.c (try_window_id): Undo last change.
2190 * w32.c (getwd): Adjust commentary about startup_dir.
2191 (init_environment): Always call sys_access, even in non-MSVC
2192 builds. Don't chdir to the directory of the Emacs executable.
2193 This undoes code from 1997 which was justified by the need to
2194 "avoid conflicts when removing and renaming directories". But its
2195 downside was that every relative file name was being interpreted
2196 relative to the directory of the Emacs executable, which can never
2197 be TRT. In particular, it broke sys_access when called with
2198 relative file names.
2199 (sys_access): Map GetLastError to errno.
2201 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2203 * window.h (struct window): Change type of 'fringes_outside_margins'
2204 to bitfield. Fix comment. Adjust users accordingly.
2205 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2207 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2210 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2212 * gnutls.c (emacs_gnutls_handshake):
2213 Add QUIT to make the loop interruptible.
2215 2012-06-29 Glenn Morris <rgm@gnu.org>
2217 * charset.c (init_charset): Make lack of etc/charsets fatal.
2219 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2221 * editfns.c (region_limit): Fix type mismatch.
2223 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2225 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2226 undefined. Convert from xassert to eassert.
2227 * nsmenu.m: Convert from xassert to eassert.
2228 * nsterm.m: Likewise.
2230 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2232 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2234 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2236 Avoid integer overflow on scroll-left and scroll-right.
2237 * window.c (HSCROLL_MAX): New macro.
2238 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2239 overflow when requested scroll falls outside ptrdiff_t range.
2241 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2243 * window.h (struct window): Change type of 'hscroll',
2244 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2245 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2246 Adjust users accordingly.
2247 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2248 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2249 from EMACS_INT to ptrdiff_t.
2250 (make_window): Omit redundant initialization.
2252 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
2254 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2256 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2258 * window.h (struct window): Change type of 'use_time' and
2259 'sequence_number' from Lisp_Object to int.
2260 * frame.c (make_frame): Adjust users accordingly.
2261 * print.c (print_object): Likewise.
2262 * window.c (select_window, Fwindow_use_time, make_parent_window)
2263 (make_window): Likewise.
2265 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2267 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2268 enabled with --enable-checking=[all,glyphs] configure option.
2269 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2270 adjust comments accordingly.
2271 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2272 undefined, adjust comments accordingly.
2273 * image.c: Likewise.
2274 * scroll.c: Likewise.
2275 * w32fns.c: Likewise.
2276 * w32term.c: Likewise.
2277 * xdisp.c: Likewise.
2278 * xfaces.c: Likewise.
2280 * xterm.c: Likewise.
2282 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2284 Generalize run-time debugging checks.
2285 * dispextern.h (XASSERTS): Remove.
2286 * fontset.c (xassert): Remove.
2287 Convert from xassert to eassert.
2288 * alloc.c: Convert from xassert to eassert.
2290 * dispnew.c: Likewise.
2292 * fringe.c: Likewise.
2293 * ftfont.c: Likewise.
2294 * gtkutil.c: Likewise.
2295 * image.c: Likewise.
2296 * keyboard.c: Likewise.
2298 * process.c: Likewise.
2299 * scroll.c: Likewise.
2300 * sound.c: Likewise.
2302 * w32console.c: Likewise.
2303 * w32fns.c: Likewise.
2304 * w32term.c: Likewise.
2305 * window.c: Likewise.
2306 * xdisp.c: Likewise.
2307 * xfaces.c: Likewise.
2309 * xselect.c: Likewise.
2310 * xterm.c: Likewise.
2312 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2314 * fns.c (maybe_resize_hash_table): Output message when growing the
2317 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2319 * alloc.c (allocate_string_data): Remove dead code.
2320 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2321 avoid GCC warning about unused macro.
2323 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2325 * alloc.c (allocate_string): Omit intervals initialization.
2326 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2327 as in make_pure_string and make_pure_c_string.
2329 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2331 * alloc.c (allocate_string): Fix last change.
2333 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2335 * alloc.c (allocate_string): Remove two redundant calls
2336 to memset, add explicit initialization where appropriate.
2338 2012-06-27 Glenn Morris <rgm@gnu.org>
2340 * lisp.mk (lisp): Remove paths.elc.
2342 2012-06-27 Chong Yidong <cyd@gnu.org>
2344 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2346 2012-06-26 John Wiegley <johnw@newartisans.com>
2348 * unexmacosx.c (copy_data_segment): Add two section names used
2349 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2351 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2352 when building with Clang.
2354 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2356 * eval.c (Fapply): Allow calling it with a single argument.
2358 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2360 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2361 _stricmp and _strnicmp.
2362 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2364 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2366 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2368 (allocate_process): Likewise for new process.
2369 (allocate_terminal): Change to use offsetof.
2370 (allocate_frame): Likewise.
2371 * frame.c (make_frame): Omit redundant initialization.
2372 * window.c (make_parent_window): Use memset.
2373 (make_window): Omit redundant initialization.
2374 * process.c (make_process): Omit redundant initialization.
2375 * terminal.c (create_terminal): Likewise.
2377 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2379 * term.c (delete_tty): Remove redundant call to memset.
2381 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2383 * alloc.c: Remove build_string.
2384 * lisp.h: Define build_string as static inline. This provides
2385 a better opportunity to optimize away calls to strlen when the
2386 function is called with compile-time constant argument.
2387 * image.c (imagemagick_error): Convert to build_string.
2388 * w32proc.c (sys_spawnve): Likewise.
2389 * xterm.c (x_term_init): Likewise.
2391 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2393 Use sprintf return value instead of invoking strlen on result.
2394 In the old days this wasn't portable, since some sprintf
2395 implementations returned char *. But they died out years ago and
2396 Emacs already assumes sprintf returns int.
2397 Similarly for float_to_string.
2398 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2399 * ccl.c (ccl_driver):
2400 * character.c (string_escape_byte8):
2401 * data.c (Fnumber_to_string):
2402 * doprnt.c (doprnt):
2403 * print.c (print_object):
2404 * xdisp.c (message_dolog):
2405 * xfns.c (syms_of_xfns):
2406 Use sprintf or float_to_string result to avoid need to call strlen.
2407 * data.c (Fnumber_to_string):
2408 Use make_unibyte_string, since the string must be ASCII.
2409 * lisp.h, print.c (float_to_string): Now returns int length.
2410 * term.c (produce_glyphless_glyph):
2411 Use sprintf result rather than recomputing it.
2413 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2414 * Makefile.in (ALL_CFLAGS):
2415 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2416 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2418 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2420 * dispextern.h (xstrcasecmp): Define to library function
2421 strcasecmp if available.
2422 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2424 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2426 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2427 Avoid comma operator.
2428 * menu.c (push_submenu_start, push_submenu_end)
2429 (push_left_right_boundary, push_menu_pane): Likewise.
2430 * msdos.c (dos_rawgetc): Likewise.
2432 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2434 * xfns.c (xic_create_fontsetname): Remove redundant calls
2437 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2439 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2440 sprintf already null-terminates its output.
2442 * xfns.c (x_window): Remove redundant cast.
2444 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2446 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2447 `const char *' to `char *' to avoid compiler warning.
2449 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2451 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2452 instead of truncating it to 63 (admittedly a generous limit).
2454 * process.c: Fix spelling and caps in comments.
2456 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2458 * emacs.c (setpgrp): Remove definition, unused.
2459 * sysdep.c (setpgrp): Remove definition, not used in this file.
2461 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2463 * makefile.w32-in: Update dependencies.
2465 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2467 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2468 (SYSTIME_H): Add nt/inc/sys/time.h.
2470 * systime.h [WINDOWSNT]: Include sys/time.h.
2472 * s/ms-w32.h (struct timespec): Definition moved from
2473 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2475 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2477 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2478 * buffer.h (buffer_slot_type_mismatch):
2479 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2480 * eval.c (unwind_to_catch):
2481 * image.c (my_png_error, my_error_exit):
2482 * keyboard.c (quit_throw_to_read_char, user_error)
2483 (Fexit_recursive_edit, Fabort_recursive_edit):
2484 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2485 (wrong_type_argument, buffer_overflow, __executable_start)
2486 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2487 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2488 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2490 (child_setup) [!DOS_NT]:
2491 * lread.c (end_of_file_error, invalid_syntax):
2492 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2493 * puresize.h (pure_write_error):
2494 * search.c (matcher_overflow):
2495 * sound.c (sound_perror, alsa_sound_perror):
2496 * sysdep.c, syssignal.h (croak):
2497 * term.c (maybe_fatal, vfatal):
2498 * textprop.c (text_read_only):
2499 * undo.c (user_error):
2500 * unexmacosx.c (unexec_error):
2501 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2502 Use _Noreturn rather than NO_RETURN.
2503 No need for separate decl merely because of _Noreturn.
2504 * sound.c (sound_warning, parse_sound):
2505 Remove unnecessary forward decls.
2507 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2509 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2510 * lisp.h (WAIT_READING_MAX): New macro.
2511 * dispnew.c (Fsleep_for, sit_for):
2512 * keyboard.c (kbd_buffer_get_event):
2513 * process.c (Faccept_process_output):
2514 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2515 This improves on the previous patch, which introduced a bug
2516 when time_t is unsigned and as wide as intmax_t.
2517 See <http://bugs.gnu.org/9000#51>.
2519 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2521 * dispnew.c (sit_for, Fsleep_for):
2522 * keyboard.c (kbd_buffer_get_event):
2523 * process.c (Faccept_process_output): Avoid compiler warnings when
2524 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2526 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2528 * makefile.w32-in: Update dependencies.
2530 * w32.c (ltime): Add return type and declare static.
2531 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2533 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2535 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2536 Privately reported by Herbert J. Skuhra.
2537 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2539 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2540 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2542 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2544 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2545 last argument of make_unibyte_string.
2547 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2548 language ID in the event parameters.
2550 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2551 event.code, not the obscure "character set ID".
2553 2012-06-23 Chong Yidong <cyd@gnu.org>
2555 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2557 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2559 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2560 * w32.c (fdutimens): New function.
2562 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2564 * s/ms-w32.h (pselect): Redirect to sys_select.
2566 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2568 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2569 in the logic of incrementing and decrementing the value of
2570 use_relocatable_buffers.
2572 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2574 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2575 Privately reported by Herbert J. Skuhra.
2576 [__FreeBSD__]: Remove "*/" typo after "#include".
2577 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2578 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2579 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2580 Don't assume EMACS_TIME and struct timeval are the same type.
2582 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2584 Support higher-resolution time stamps (Bug#9000).
2585 The time stamps are only nanosecond-resolution at the C level,
2586 since that's the best that any real-world system supports now.
2587 But they are picosecond-resolution at the Lisp level, as that's
2588 easy, and leaves room for future OS improvements.
2590 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2593 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2594 Don't get current time unless it's needed.
2596 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2597 now provides it if it's absent.
2598 (start_atimer): Port to higher-res time stamps.
2599 Check for time stamp overflow. Don't get current time more
2600 often than is needed.
2602 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2603 Include systime.h, not time.h.
2604 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2606 * dired.c: Include stat-time.h.
2607 (Ffile-attributes): File times now have higher resolution.
2609 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2610 (struct image): Timestamp now has higher resolution.
2612 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2613 has at least microseconds now. All uses removed.
2614 (update_frame, update_single_window, update_window, update_frame_1)
2615 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2617 * editfns.c (time_overflow): Now extern.
2618 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2619 (float-time, Fformat_time_string, Fcurrent_time_string)
2620 (Fcurrent_time_zone): Accept and generate higher-resolution
2622 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2623 (decode_time_components, lisp_seconds_argument): New functions.
2624 (make_time): Now static.
2625 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2626 Report an error if the time is invalid, rather than having the caller
2629 * fileio.c: Include <stat-time.h>
2630 (Fcopy_file): Copy higher-resolution time stamps.
2631 Prefer to set the time stamp via a file descriptor if that works.
2632 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2633 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2634 (Fvisited_file_modtime, Fset_visited_file_modtime):
2635 Support higher-resolution time stamps.
2637 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2639 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2641 * image.c (prepare_image_for_display, clear_image_cache)
2642 (lookup_image): Port to higer-resolution time stamps.
2644 * keyboard.c (start_polling, bind_polling_period):
2645 Check for time stamp overflow.
2646 (read_char, kbd_buffer_get_event, timer_start_idle)
2647 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2648 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2649 Port to higher-resolution time stamps. Do not assume time_t is signed.
2650 (decode_timer): New function. Timers are now vectors of length 9,
2651 not 8, to accommodate the picosecond component.
2652 (timer_check_2): Use it.
2654 * nsterm.m (select_timeout, timeval_subtract): Remove.
2655 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2656 as they're a bit more accurate and handle overflow better.
2657 (ns_select): Change prototype to be compatible with pselect.
2658 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2659 * nsterm.h (ns_select): Adjust prototype.
2661 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2662 us-resolution time stamps.
2663 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2665 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2667 * lisp.h (time_overflow): New decl.
2668 (wait_reading_process_output): First arg is now intmax_t, not int,
2669 to accommodate larger waits.
2671 * process.h (struct Lisp_Process.read_output_delay):
2672 Now counts nanoseconds, not microseconds.
2673 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2675 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2676 (wait_reading_process_output):
2677 Port to ns-resolution time stamps.
2678 (Faccept_process_output, wait_reading_process_output):
2679 Check for time stamp overflow. Do not assume time_t is signed.
2680 (select_wrapper): Remove; we now use pselect.
2681 (Fprocess_attributes): Now generates ns-resolution time stamps.
2683 * sysdep.c: Include utimens.h. Don't include utime.h
2684 or worry about struct utimbuf; gnulib does that for us now.
2685 (gettimeofday): Remove; gnulib provides a substitute.
2686 (make_timeval): New function.
2687 (set_file_times): Now sets ns-resolution time stamps.
2688 New arg FD; all uses changed.
2689 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2690 (system_process_attributes):
2691 Now returns ns-resolution time stamp. All uses changed.
2692 Check for time stamp overflow.
2694 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2695 provides a substitute now.
2697 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2698 since it guarantees struct timespec.
2699 (EMACS_TIME): Now struct timespec, so that we can support
2700 ns-resolution time stamps.
2701 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2702 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2703 (EMACS_USECS): Remove.
2704 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2705 so multiply the arg by 1000 before storing it.
2706 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2708 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2709 Port to ns-resolution time stamps.
2710 (EMACS_TIME_NEG_P): Remove; replaced by....
2711 (EMACS_TIME_SIGN): New macro.
2712 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2713 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2714 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2715 (make_timeval, make_lisp_time, decode_time_components): New decls.
2716 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2717 that it mishandled time_t overflow. You can't compare by subtracting!
2718 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2719 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2721 * term.c: Include <sys/time.h>.
2722 (timeval_to_Time): New function, for proper overflow wraparound.
2723 (term_mouse_position, term_mouse_click): Use it.
2725 * undo.c (record_first_change): Support higher-resolution time stamps
2727 (Fprimitive_undo): Use them when restoring time stamps.
2729 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2730 (w32_get_internal_run_time):
2731 Port to higher-resolution Emacs time stamps.
2732 (ltime): Now accepts single 64-bit integer, as that's more convenient
2735 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2737 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2738 for compatibility with pselect. Support ns-resolution time stamps.
2740 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2742 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2743 Check for time stamp overflow, and support ns-resolution time stamps.
2745 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2746 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2747 (timeval_subtract): Remove; no longer needed.
2748 (XTflash, XTring_bell, x_wait_for_event):
2749 Port to ns-resolution time stamps. Don't assume time_t is signed.
2751 2012-06-22 Chong Yidong <cyd@gnu.org>
2753 * xdisp.c (x_consider_frame_title): Revert last change.
2755 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2757 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2758 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2759 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2760 staticidx goes up to 1597 out of 1600 = 0x640.)
2762 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2764 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2765 Otherwise, the umask might be mistakenly 0 while handling input signals.
2767 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2769 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2771 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2773 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2774 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2775 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2776 access to `contents' member of Lisp_Vector objects with AREF and ASET
2779 2012-06-19 Chong Yidong <cyd@gnu.org>
2781 * frame.c (delete_frame): When selecting a frame on a different
2782 text terminal, do not alter the terminal's top-frame.
2784 * xdisp.c (format_mode_line_unwind_data): Record the target
2785 frame's selected window and its terminal's top-frame.
2786 (unwind_format_mode_line): Restore them.
2787 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2789 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2790 since tty frames can be explicitly named.
2791 (prepare_menu_bars): Likewise.
2793 * term.c (Ftty_top_frame): New function.
2795 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2797 Port byte-code-meter to modern targets.
2798 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2799 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2800 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2801 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2802 (METER_1, METER_2): Simplify.
2804 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2806 * data.c (Fdefalias): Return `symbol' (bug#11686).
2808 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2810 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2811 gets killed during executing of this function (Bug#11665).
2812 Try to always return Qt when the buffer has been actually killed.
2813 (Vkill_buffer_query_functions): In doc-string say that functions
2814 run by this hook should not change the current buffer.
2816 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2818 Fix recently-introduced process.c problems found by static checking.
2819 * process.c (write_queue_push, write_queue_pop, send_process):
2820 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2821 (write_queue_pop): Fix pointer signedness problem.
2822 (send_process): Remove unused local.
2824 2012-06-17 Chong Yidong <cyd@gnu.org>
2826 * xdisp.c (redisplay_internal): No need to redisplay terminal
2827 frames that are not on top.
2829 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2831 * process.c (make_process): Initialize write_queue.
2832 (write_queue_push, write_queue_pop): New functions.
2833 (send_process): Use them to maintain correct ordering of process
2836 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2838 * lisp.h (eassert): Assume C89 or later.
2839 This removes the need for CHECK.
2840 (CHECK): Remove. Its comments about always evaluating its
2841 argument were confusing, as 'eassert' typically does not evaluate
2844 * coding.c (produce_chars): Use ptrdiff_t, not int.
2846 * xterm.c (x_draw_underwave): Check for integer overflow.
2847 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2849 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2851 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2852 referenced (Bug#11583).
2854 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2856 Implement wave-style variant of underlining.
2857 * dispextern.h (face_underline_type): New enum.
2858 (face): Add field for underline type.
2859 * nsterm.m (ns_draw_underwave): New function.
2860 (ns_draw_text_decoration): Use it.
2861 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2863 (x_draw_glyph_string): Use them.
2864 * xfaces.c (Qline, Qwave): New Lisp objects.
2865 (check_lface_attrs, merge_face_ref)
2866 (Finternal_set_lisp_face_attribute, realize_x_face):
2867 Handle wave-style underline face attributes.
2868 * xterm.c (x_draw_underwave): New function.
2869 (x_draw_glyph_string): Use it.
2871 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2873 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2874 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2875 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2876 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2877 ($(BLD)/w32select.$(O)): Update dependencies.
2879 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2881 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2882 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2883 * character.c (_fetch_multibyte_char_p): Remove.
2884 * alloc.c: Include "character.h" before "buffer.h".
2886 * buffer.c: Likewise.
2887 * bytecode.c: Likewise.
2888 * callint.c: Likewise.
2889 * callproc.c: Likewise.
2890 * casefiddle.c: Likewise.
2891 * casetab.c: Likewise.
2892 * category.c: Likewise.
2894 * coding.c: Likewise.
2895 * composite.c: Likewise.
2896 * dired.c: Likewise.
2897 * dispnew.c: Likewise.
2899 * dosfns.c: Likewise.
2900 * editfns.c: Likewise.
2901 * emacs.c: Likewise.
2902 * fileio.c: Likewise.
2903 * filelock.c: Likewise.
2905 * fontset.c: Likewise.
2906 * fringe.c: Likewise.
2907 * indent.c: Likewise.
2908 * insdel.c: Likewise.
2909 * intervals.c: Likewise.
2910 * keyboard.c: Likewise.
2911 * keymap.c: Likewise.
2912 * lread.c: Likewise.
2913 * macros.c: Likewise.
2914 * marker.c: Likewise.
2915 * minibuf.c: Likewise.
2916 * nsfns.m: Likewise.
2917 * nsmenu.m: Likewise.
2918 * print.c: Likewise.
2919 * process.c: Likewise.
2920 * regex.c: Likewise.
2921 * region-cache.c: Likewise.
2922 * search.c: Likewise.
2923 * syntax.c: Likewise.
2925 * textprop.c: Likewise.
2927 * unexsol.c: Likewise.
2928 * w16select.c: Likewise.
2929 * w32fns.c: Likewise.
2930 * w32menu.c: Likewise.
2931 * window.c: Likewise.
2932 * xdisp.c: Likewise.
2934 * xmenu.c: Likewise.
2936 * xselect.c: Likewise.
2938 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2940 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2941 If all the glyphs of the glyph row came from strings, and we have no
2942 cursor positioning clues, put the cursor on the first glyph of the
2944 (handle_face_prop): Use chunk-relative overlay string index when
2945 indexing into it->string_overlays array. (Bug#11653)
2946 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2947 the rightmost. (Bug#11720)
2949 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2951 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2952 (CATEGORY_MEMBER): Enforce 1/0 value.
2953 * category.c (_temp_category_set): Remove.
2955 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2957 * window.c (Fdelete_other_windows_internal)
2958 (Fdelete_window_internal): Don't access frame's mouse highlight
2959 info of the initial frame. (Bug#11677)
2961 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2963 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2964 Assume USE_2_TAGS_FOR_INTS.
2965 (xreload): Adjust $tagmask width to match recent lisp.h change.
2967 Simplify lisp.h in minor ways that should not affect code.
2968 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2969 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2970 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2971 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2972 (INTTYPEBITS): New macro, for clarity.
2973 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2974 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2975 Simplify now that USE_LSB_TAG is always defined.
2976 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2977 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2979 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2981 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2983 2012-06-13 Glenn Morris <rgm@gnu.org>
2985 * s/bsd-common.h (BSD4_3):
2986 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2988 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2990 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2993 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2995 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2996 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2997 * alloc.c (widen_to_Lisp_Object): Remove.
2998 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2999 * frame.c (delete_frame): Remove outdated comment.
3000 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3001 USE_LISP_UNION_TYPE.
3002 (Fw32_unregister_hot_key): Likewise.
3003 (Fw32_toggle_lock_key): Likewise.
3004 * w32menu.c (add_menu_item): Likewise.
3005 (w32_menu_display_help): Use XIL instead of checking
3006 USE_LISP_UNION_TYPE.
3007 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3008 (init_heap): Likewise.
3009 * w32term.c (w32_read_socket): Update comment.
3011 2012-06-13 Glenn Morris <rgm@gnu.org>
3013 * s/usg5-4-common.h, src/s/unixware.h:
3014 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3016 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3018 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3020 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3021 * alloc.c (make_number) [!defined make_number]:
3022 Remove, as lisp.h always defines this now.
3023 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3024 (roundup_size): Verify that it is a power of 2.
3025 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3026 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3027 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3028 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3029 USE_LSB_TAG now is always defined to be either 0 or 1.
3031 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3032 code works fine either way, and efficiency is not a concern here,
3033 as the union type is for debugging, not for production.
3034 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3035 Use an inline function on all platforms when using the union type,
3036 since this is simpler and 'static inline' can be used portably
3038 (LISP_INITIALLY_ZERO): New macro.
3039 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3040 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3042 2012-06-12 Glenn Morris <rgm@gnu.org>
3044 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3046 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
3048 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3049 Move BROKEN_SIGIO to configure.
3051 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3052 Move NO_TERMIO to configure.
3054 2012-06-12 Chong Yidong <cyd@gnu.org>
3056 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3057 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3058 MagickExportImagePixels is undefined.
3060 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3062 * image.c (imagemagick_load_image): Remove unused label.
3064 2012-06-11 Glenn Morris <rgm@gnu.org>
3066 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3067 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3068 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3069 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3071 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3073 * alloc.c (make_byte_code): New function.
3074 (Fmake_byte_code): Use it. Don't purify here.
3075 * lread.c (read1): Use it as well to avoid extra allocation.
3077 2012-06-11 Chong Yidong <cyd@gnu.org>
3079 * image.c (imagemagick_load_image): Implement transparency.
3081 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3083 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3084 account for preceding backslashes. (Bug#11663)
3086 2012-06-09 Chong Yidong <cyd@gnu.org>
3088 * term.c: Support italics in capable terminals (Bug#9652).
3089 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3090 (turn_on_face): Output using TS_enter_italic_mode if available.
3091 Don't handle unused blinking and alt-charset cases.
3092 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3093 and tty_alt_charset_p cases.
3094 (tty_capable_p, init_tty): Support italics.
3096 * termchar.h (struct tty_display_info): Add field for italics.
3097 Remove unused blink field.
3099 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3102 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3103 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3104 tty_alt_charset_p. Add tty_italic_p.
3106 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
3108 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3109 dbus_type_is_basic if available.
3110 (xd_extract_signed, xd_extract_unsigned): Rename from
3111 extract_signed and extract_unsigned, respectively. Adapt callers.
3113 2012-06-09 Chong Yidong <cyd@gnu.org>
3115 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3117 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3120 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3122 * xdisp.c (vmessage): Treat frame message as multibyte.
3123 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3124 would generate the diagnostic "Making \302\247 buffer-local while
3127 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3129 * dispnew.c (showing_window_margins_p): Undo last change, which
3130 was done due to an inadvertent commit.
3131 (adjust_frame_glyphs_for_frame_redisplay): Do call
3132 showing_window_margins_p.
3134 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3136 * eval.c (Fmake_var_non_special): New primitive.
3137 (syms_of_eval): Defsubr it.
3138 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3140 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3142 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3143 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3145 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3147 * alloc.c (allocate_vectorlike): Fix last change.
3149 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3151 Block-based vector allocation of small vectors.
3152 * lisp.h (struct vectorlike_header): New field `nbytes',
3153 adjust comment accordingly.
3154 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3155 to denote vector blocks. Adjust users (live_vector_p,
3156 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3157 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3158 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3159 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3160 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3161 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3162 (roundup_size): New constant.
3163 (struct vector_block): New data type.
3164 (vector_blocks, vector_free_lists, zero_vector): New variables.
3165 (all_vectors): Rename to `large_vectors'.
3166 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3167 (sweep_vectors): New functions.
3168 (allocate_vectorlike): Return `zero_vector' as the only vector of
3169 0 items. Allocate new vector from block if vector size is less than
3170 or equal to VBLOCK_BYTES_MAX.
3171 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3172 (init_alloc_once): Add call to init_vectors.
3174 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3176 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3178 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3180 * doprnt.c (doprnt): Truncate multibyte char correctly.
3181 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3182 would mishandle a string argument "Xc" if X was a multibyte
3183 character of length 2: it would truncate after X's first byte
3184 rather than including all of X.
3186 2012-06-06 Chong Yidong <cyd@gnu.org>
3188 * buffer.c (word_wrap): Doc fix.
3190 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3192 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3194 2012-06-03 Glenn Morris <rgm@gnu.org>
3196 * xdisp.c (tool-bar-style): Doc fix.
3198 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3200 * Makefile.in (PAXCTL): Define.
3201 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3202 binary via PaX flags if the paxctl utility is available.
3203 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3204 Restore PaX flags to their default. (Bug#11398)
3206 2012-06-03 Chong Yidong <cyd@gnu.org>
3208 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3211 2012-06-03 Chong Yidong <cyd@gnu.org>
3213 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3214 (note_mode_line_or_margin_highlight): If there is no help echo,
3215 use mode-line-default-help-echo. Handle the case where the mouse
3216 position is past the end of the mode line string.
3218 * buffer.c (buffer_local_value_1): New function, split from
3219 Fbuffer_local_value; can return Qunbound.
3220 (Fbuffer_local_value): Use it.
3221 (Vmode_line_format): Docstring tweaks.
3223 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3225 * sysdep.c (system_process_attributes): Improve comment.
3227 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3229 * keyboard.c: Export real-this-command to Elisp.
3230 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3231 and DEFVAR it. Update all users.
3233 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3235 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3237 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3238 Convert pctcpu and pctmem to Lisp float properly.
3239 Let the compiler fold better, as 100.0/0x8000 is exact.
3241 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3243 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3246 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3248 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3250 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3252 For a 'struct window', replace some Lisp_Object fields to
3253 bitfields where appropriate, remove unused fields.
3254 * window.h (struct window): Remove unused 'last_mark_x' and
3255 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3256 change it's type from Lisp_Object to bitfield.
3257 Change type of 'force_start', 'optional_new_start',
3258 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3259 fields from Lisp_Object to bitfield. Adjust users accordingly.
3261 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3263 Pacify gcc -Wdouble-precision when using Xaw.
3264 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3265 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3266 Use 'float' consistently, rather than 'float' in most places
3267 and 'double' in a couple of places.
3269 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3271 * xdisp.c (handle_stop): Detect whether we have overlay strings
3272 loaded by testing it->current.overlay_string_index to be
3273 non-negative, instead of checking whether n_overlay_strings is
3274 positive. (Bug#11587)
3276 2012-05-31 Chong Yidong <cyd@gnu.org>
3278 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3280 * doc.c (Fsubstitute_command_keys): Doc fix.
3282 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3284 * search.c (search_buffer): Remove calls to
3285 r_alloc_inhibit_buffer_relocation, as it is now called by
3286 maybe_unify_char, which was the cause of relocation of buffer text
3289 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3291 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3292 for the duration of call to load_charset, to avoid problems with
3293 callers of maybe_unify_char that access buffer text through C
3296 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3297 decrement the inhibition flag, instead of just setting or
3300 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3302 Remove obsolete '#define static' cruft.
3303 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3304 This #undef was "temporary" in 2000; it is no longer needed
3305 now that '#define static' has gone away.
3306 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3307 (gray_bitmap_bits): Remove; no longer needed.
3308 All uses replaced with definiens.
3309 * xterm.c: Include "bitmaps/gray.xbm".
3311 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3313 Clean up __executable_start, monstartup when --enable-profiling.
3314 The following changes affect the code only when profiling.
3315 * dispnew.c (__executable_start): Rename from safe_bcopy.
3316 Define only on platforms that need it.
3317 * emacs.c: Include <sys/gmon.h> when profiling.
3318 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3319 (__executable_start): Remove decl, since lisp.h does it now.
3320 (safe_bcopy): Remove decl; no longer has that name.
3321 (main): Coalesce #if into single bit of code, for simplicity.
3322 Cast pointers to uintptr_t, since standard libraries want integers
3324 * lisp.h (__executable_start): New decl.
3326 2012-05-31 Glenn Morris <rgm@gnu.org>
3328 * image.c (Fimagemagick_types): Doc fix.
3330 2012-05-30 Jim Meyering <meyering@redhat.com>
3332 * callproc.c (Fcall_process_region): Include directory component
3333 in mkstemp error message (Bug#11586).
3335 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3337 * alloc.c, lisp.h (make_pure_vector): Now static.
3339 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3341 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3342 Move to byte-run.el.
3343 (Fautoload): Do the hash-doc more carefully.
3344 * data.c (Fdefalias): Purify definition, except for keymaps.
3345 (Qdefun): Move from eval.c.
3346 * lisp.h (Qdefun): Remove.
3347 * lread.c (read1): Tiny simplification.
3349 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3351 Do not create empty overlays with the evaporate property (Bug#9642).
3352 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3353 Bug#9642, but explicitly check that the buffer the overlay would
3354 be moved to is live and rearrange lines to make sure that errors
3355 will not put the overlay in an inconsistent state.
3356 (Fdelete_overlay): Cosmetics.
3358 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3360 * w32term.c (my_bring_window_to_top): New function.
3361 (x_raise_frame): Use handle returned by DeferWindowPos, which
3362 could be different from the original one.
3363 Call my_bring_window_to_top instead of my_set_foreground_window.
3366 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3367 by calling BringWindowToTop.
3369 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3370 (WM_EMACS_END): Increase by one.
3372 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3374 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3375 This avoids undefined behavior that might cause the eassert
3376 to not catch an out-of-range value.
3378 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3380 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3381 Update dependencies.
3383 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3385 * bidi.c (bidi_mirror_char): Fix last change.
3387 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3389 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3390 when referring to sectname field in printf format.
3392 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3394 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3395 Only r_alloc_inhibit_buffer_relocation needed to be added;
3396 the others were already declared.
3398 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3399 before checking whether it's out of range. Put the check inside
3401 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3403 2012-05-27 Ken Brown <kbrown@cornell.edu>
3405 * callproc.c (Fcall_process): Restore a line that was accidentally
3406 commented out in the 2011-02-13 change (bug#11547).
3408 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3410 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3411 defined on ralloc.c.
3413 * buffer.c [REL_ALLOC]: Remove prototypes of
3414 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3415 they are now on lisp.h.
3417 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3419 * search.c (search_buffer): Use it to inhibit relocation of buffer
3420 text while re_search_2 is doing its job, because re_search_2 is
3421 passed C pointers to buffer text. (Bug#11519)
3423 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3426 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3427 state after an additional call to move_it_in_display_line_to, keep
3428 the values of it->max_ascent and it->max_descent found for the
3430 (pos_visible_p): Revert the comparison against bottom_y to what it
3431 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3434 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3436 Fix coding-related core dumps with gcc -ftrapv.
3437 The code was computing A - B, where A and B are pointers, and B is
3438 random garbage. This can lead to core dumps on platforms that
3439 have special pointer registers, and it also leads to core dumps on
3440 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3441 A - B only when B is initialized properly.
3442 * coding.c (coding_set_source, coding_set_destination): Return void.
3443 (coding_change_source, coding_change_destinations): New functions,
3444 with the old behaviors of coding_set_source and coding_set_destination.
3445 All callers that need an offset changed to use these new functions.
3447 2012-05-26 Glenn Morris <rgm@gnu.org>
3449 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3451 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3453 Extend mouse support on W32 text-mode console.
3454 * xdisp.c (draw_row_with_mouse_face):
3455 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3457 * w32console.c: Include window.h.
3458 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3460 (initialize_w32_display): Initialize mouse-highlight data.
3462 * w32inevt.c: Include termchar.h and window.h.
3463 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3464 moves, call note_mouse_highlight. If help_echo changed, call
3465 gen_help_event to produce help-echo message in the echo area.
3466 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3469 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3471 * lread.c (read1): Simplify slightly to avoid an overflow warning
3472 with GCC 4.7.0 on x86-64.
3474 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3476 * bidi.c (bidi_mirror_char): Revert last change: an int is
3477 definitely wide enough here.
3479 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3481 Fix integer width and related bugs (Bug#9874).
3482 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3483 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3484 (string_bytes, check_sblock, allocate_string_data):
3485 (compact_small_strings, Fmake_bool_vector, make_string)
3486 (make_unibyte_string, make_multibyte_string)
3487 (make_string_from_bytes, make_specified_string)
3488 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3489 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3492 (allocate_pseudovector):
3493 Use int, not EMACS_INT, where int is wide enough.
3494 (inhibit_garbage_collection, Fgarbage_collect):
3495 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3496 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3497 int might not be wide enough.
3498 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3499 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3500 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3501 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3502 (bidi_level_of_next_char, bidi_move_to_visually_next):
3503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3504 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3505 (Fkill_buffer, Fset_buffer_major_mode)
3506 (advance_to_char_boundary, Fbuffer_swap_text)
3507 (Fset_buffer_multibyte, overlays_at, overlays_in)
3508 (overlay_touches_p, struct sortvec, record_overlay_string)
3509 (overlay_strings, recenter_overlay_lists)
3510 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3511 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3512 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3513 (Foverlay_recenter, last_overlay_modification_hooks_used)
3514 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3516 (validate_region): Omit unnecessary test for b <= e,
3517 since that's guaranteed by the previous test.
3518 (adjust_overlays_for_delete): Avoid pos + length overflow.
3519 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3520 (report_overlay_modification):
3521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3522 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3523 Omit pointer cast, which isn't needed anyway, and doesn't work
3524 after the EMACS_INT -> ptrdiff_t change.
3525 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3526 * buffer.h: Adjust decls to match defn changes elsewhere.
3527 (struct buffer_text, struct buffer):
3528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3529 Use EMACS_INT, not int, where int might not be wide enough.
3530 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3531 not int, to avoid needless 32-bit limit on 64-bit hosts.
3532 (exec_byte_code): Use tighter memory-full test, one that checks
3533 for alloca overflow. Don't compute the address of the object just
3534 before an array, as that's not portable. Use EMACS_INT, not
3535 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3536 * callint.c (Fcall_interactively):
3537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3538 * callproc.c (call_process_kill, Fcall_process):
3539 Don't assume pid_t fits into an Emacs fixnum.
3540 (call_process_cleanup, Fcall_process, child_setup):
3541 Don't assume pid_t fits into int.
3542 (call_process_cleanup, Fcall_process, delete_temp_file)
3543 (Fcall_process_region):
3544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3545 (Fcall_process): Simplify handling of volatile integers.
3546 Use int, not EMACS_INT, where int will do.
3547 * casefiddle.c (casify_object, casify_region, operate_on_word)
3548 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3550 (casify_object): Avoid integer overflow when overallocating buffer.
3551 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3552 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3553 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3554 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3555 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3556 integers are now checked earlier. All uses replaced with XINT.
3558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3559 For CCL_MapSingle, check that content and value are in int range.
3560 (ccl_driver, Fregister_code_conversion_map):
3561 Check that Vcode_version_map_vector is a vector.
3562 (resolve_symbol_ccl_program): Check that vector header is in range.
3563 Always copy the vector, so that we can check its contents reliably
3564 now rather than having to recheck each instruction as it's being
3565 executed. Check that vector words fit in 'int'.
3566 (ccl_get_compiled_code, Fregister_ccl_program)
3567 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3568 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3569 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3570 contents are in range.
3571 (Fccl_execute_on_string): Check that status is in range.
3572 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3573 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3574 Accept and return EMACS_INT, not int, because callers can pass values
3576 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3577 (multibyte_chars_in_text, parse_str_as_multibyte)
3578 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3579 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3580 (string_escape_byte8, Fget_byte):
3581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3582 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3583 avoid mishandling large integers.
3584 * character.h: Adjust decls to match defn changes elsewhere.
3585 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3586 (Ffind_charset_region):
3587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3588 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3589 (load_charset_map_from_vector, Fdefine_charset_internal):
3590 Don't assume fixnum fits in int.
3591 (load_charset_map_from_vector, Fmap_charset_chars):
3592 Remove now-unnecessary CHECK_NATNUMs.
3593 (Fdefine_charset_internal): Check ranges here, more carefully.
3594 Don't rely on undefined behavior with signed left shift overflow.
3595 Don't assume unsigned int fits into fixnum, or that fixnum fits
3596 into unsigned int. Don't require max_code to be a valid fixnum;
3597 that's not true for gb10830 4-byte on a 32-bit host. Allow
3598 invalid_code to be a cons, for the same reason. Require code_offset
3599 to be a character. Avoid int overflow if max_char is close
3601 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3602 this is intended anyway and avoids some undefined behavior.
3603 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3604 INDEX_TO_CODE_POINT, as that's what it expects.
3605 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3606 * charset.h (DECODE_CHAR): Return int, not unsigned;
3607 this is what was intended anyway, and it avoids undefined behavior.
3608 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3609 integer-overflow issues.
3610 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3611 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3612 where the argument is EMACS_INT, and this behavior is not intended.
3613 * chartab.c (Fmake_char_table, Fset_char_table_range)
3614 (uniprop_get_decoder, uniprop_get_encoder):
3615 Don't assume fixnum fits in int.
3616 * cmds.c (move_point): New function, that does the gist of
3617 Fforward_char and Fbackward_char, but does so while checking
3618 for integer overflow more accurately.
3619 (Fforward_char, Fbackward_char): Use it.
3620 (Fforward_line, Fend_of_line, internal_self_insert)
3621 (internal_self_insert):
3622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3623 Fix a FIXME, by checking for integer overflow when calculating
3624 target_clm and actual_clm.
3625 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3626 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3627 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3628 (coding_alloc_by_making_gap, alloc_destination)
3629 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3630 (encode_coding_utf_16, detect_coding_emacs_mule)
3631 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3632 (detect_coding_iso_2022, decode_coding_iso_2022)
3633 (encode_invocation_designation, encode_designation_at_bol)
3634 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3635 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3636 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3637 (encode_coding_ccl, encode_coding_raw_text)
3638 (detect_coding_charset, decode_coding_charset)
3639 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3640 (produce_composition, produce_charset, produce_annotation)
3641 (decode_coding, handle_composition_annotation)
3642 (handle_charset_annotation, consume_chars, decode_coding_gap)
3643 (decode_coding_object, encode_coding_object, detect_coding_system)
3644 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3645 (code_convert_region, code_convert_string)
3646 (Fdefine_coding_system_internal)
3647 (coding_set_source, coding_set_destination):
3648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3649 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3650 (Fdefine_coding_system_internal):
3651 Don't assume fixnums fit in int.
3652 (decode_coding_gap, decode_coding_object, encode_coding_object)
3653 (Fread_coding_system, Fdetect_coding_region)
3654 (Funencodable_char_position, Fcheck_coding_systems_region)
3655 (get_translation, handle_composition_annotation, consume_chars):
3656 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3657 (consume_chars): Rewrite to not calculate an address outside buffer.
3658 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3659 Don't access memory outside of the args array.
3660 (Fdefine_coding_system_internal): Check for charset-id overflow.
3661 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3662 result of ENCODE_CHAR.
3663 * coding.h: Adjust decls to match defn changes elsewhere.
3664 (struct coding_system):
3665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3666 * composite.c (get_composition_id, find_composition)
3667 (run_composition_function, update_compositions)
3668 (compose_text, composition_gstring_put_cache)
3669 (composition_gstring_p, composition_gstring_width)
3670 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3671 (composition_compute_stop_pos, composition_reseat_it)
3672 (composition_update_it, struct position_record)
3673 (find_automatic_composition, composition_adjust_point)
3674 (Fcomposition_get_gstring, Ffind_composition_internal):
3675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3676 (update_compositions):
3677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3678 * composite.h: Adjust decls to match defn changes elsewhere.
3679 (struct composition):
3680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3681 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3682 Do not attempt to compute the address of the object just before a
3683 buffer; this is not portable.
3685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3686 (Faset): Use int, not EMACS_INT, where int is wide enough.
3687 (Fstring_to_number): Don't assume fixnums fit in int.
3688 (Frem): Don't assume arg is nonnegative.
3689 * dbusbind.c (xd_append_arg): Check for integers out of range.
3690 (Fdbus_call_method): Don't overflow the timeout int.
3691 (extract_signed, extract_unsigned): New functions.
3692 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3693 (xd_get_connection_references): Return ptrdiff_t, not int.
3695 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3696 (xd_read_message_1):
3697 Use int, not unsigned, where the dbus API uses int.
3698 (Fdbus_message_internal): Don't overflow mtype.
3699 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3700 * dired.c (directory_files_internal, file_name_completion, scmp)
3701 (file_name_completion_stat):
3702 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3703 (file_name_completion): Don't overflow matchcount.
3704 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3705 * dispextern.h: Adjust decls to match defn changes elsewhere.
3706 (struct text_pos, struct glyph, struct bidi_saved_info)
3707 (struct bidi_string_data, struct bidi_it, struct composition_it)
3709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3710 (struct display_pos, struct composition_it, struct it):
3711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3712 * dispnew.c (increment_matrix_positions)
3713 (increment_row_positions, mode_line_string)
3714 (marginal_area_string):
3715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3716 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3718 (duration_to_sec_usec): New function, to check for overflow better.
3719 (Fsleep_for, sit_for): Use it.
3720 * doc.c (get_doc_string, store_function_docstring):
3721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3722 (get_doc_string, Fsnarf_documentation):
3723 Use int, not EMACS_INT, where int is wide enough.
3725 Use SAFE_ALLOCA, not alloca.
3726 Check for overflow when converting EMACS_INT to off_t.
3727 * doprnt.c (doprnt):
3728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3729 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3730 Don't assume uid_t fits into fixnum.
3731 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3732 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3733 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3734 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3735 (general_insert_function)
3736 (Finsert_char, make_buffer_string, make_buffer_string_both)
3737 (update_buffer_properties, Fbuffer_substring)
3738 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3739 (Fsubst_char_in_region, check_translation)
3740 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3741 (transpose_markers, Ftranspose_regions):
3742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3743 (clip_to_bounds): Move to lisp.h as an inline function).
3744 (Fconstrain_to_field): Don't assume integers are nonnegative.
3745 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3746 (Fsubst_char_in_region, Fsave_restriction):
3747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3748 (Femacs_pid): Don't assume pid_t fits into fixnum.
3749 (lo_time): Use int, not EMACS_INT, when int suffices.
3750 (lisp_time_argument): Check for usec out of range.
3751 (Fencode_time): Don't assume fixnum fits in int.
3752 (Fuser_login_name, Fuser_full_name): Signal an error
3753 if a uid argument is out of range, rather than relying on
3755 (Fformat_time_string): Remove now-unnecessary check.
3756 lisp_time_argument checks for out-of-range usec now.
3757 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3758 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3759 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3760 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3761 (init_cmdargs, Fdump_emacs):
3762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3763 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3764 the bottom (typically) 32 bits of the fixnum.
3765 * eval.c (specpdl_size, call_debugger):
3766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3767 (when_entered_debugger, Fbacktrace_debug):
3768 Don't assume fixnum can fit in int.
3769 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3770 the object just before a buffer; this is not portable.
3771 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3772 (grow_specpdl, unbind_to):
3773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3774 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3775 (grow_specpdl): Simplify allocation by using xpalloc.
3776 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3777 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3778 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3779 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3780 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3783 (Fcopy_file, non_regular_nbytes, read_non_regular)
3784 (Finsert_file_contents):
3785 Use int, not EMACS_INT, where int is wide enough.
3786 (READ_BUF_SIZE): Verify that it fits in int.
3787 (Finsert_file_contents): Check that counts are in proper range,
3788 rather than assuming fixnums fit into ptrdiff_t etc.
3789 Don't assume fixnums fit into int.
3790 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3791 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3792 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3793 (string_char_to_byte, string_byte_to_char)
3794 (string_make_multibyte, string_to_multibyte)
3795 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3796 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3797 (substring_both, Fdelete, internal_equal, Ffillarray)
3798 (Fclear_string, mapcar1)
3799 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3800 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3801 (larger_vector, make_hash_table, maybe_resize_hash_table)
3802 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3803 (Fmaphash, secure_hash):
3804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3805 (concat): Check for string index and length overflow.
3806 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3809 (larger_vector): New API (vec, incr_min, size_max) replaces old
3810 one (vec, new_size, init). This catches size overflow.
3811 INIT was removed because it was always Qnil.
3812 All callers changed.
3813 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3814 the upper bound on a hash table index size.
3815 (make_hash_table, maybe_resize_hash_table): Use it.
3816 (secure_hash): Computer start_byte and end_byte only after
3817 they're known to be in ptrdiff_t range.
3818 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3819 (Ffont_get_glyphs, Ffont_at):
3820 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3821 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3822 (Flist_fonts, Fopen_font):
3823 Don't assume fixnum can fit in int.
3824 (check_gstring): Don't assume index can fit in int.
3825 (font_match_p): Check that fixnum is a character, not a nonnegative
3826 fixnum, since the later code needs to stuff it into an int.
3827 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3828 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3829 conversion overflow issues.
3830 (Fopen_font): Check for integer out of range.
3831 (Ffont_get_glyphs): Don't assume index can fit in int.
3832 * font.h: Adjust decls to match defn changes elsewhere.
3833 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3835 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3836 printmax_t, where ptrdiff_t is wide enough.
3837 (Finternal_char_font):
3838 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3839 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3840 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3841 (Fset_frame_position, x_set_frame_parameters)
3842 (x_set_line_spacing, x_set_border_width)
3843 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3844 Check that fixnums are in proper range for system types.
3845 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3846 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3847 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3848 Use SAFE_ALLOCA_LISP, not alloca.
3849 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3850 intptr_t is wide enough.
3851 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3852 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3853 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3854 Check for fixnum out of range.
3855 * ftfont.c (ftfont_list): Don't assume index fits in int.
3856 Check that fixnums are in proper range for system types.
3857 (ftfont_shape_by_flt):
3858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3859 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3861 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3862 Check that fixnums are in proper range for system types.
3863 * gnutls.h: Adjust decls to match defn changes elsewhere.
3864 * gtkutil.c (xg_dialog_run):
3865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3866 (update_frame_tool_bar):
3867 Check that fixnums are in proper range for system types.
3868 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3869 (lookup_image): Check that fixnums are in range for system types.
3870 * indent.c (last_known_column, last_known_column_point):
3871 (current_column_bol_cache):
3872 (skip_invisible, current_column, check_display_width):
3873 (check_display_width, scan_for_column, current_column_1)
3874 (Findent_to, Fcurrent_indentation, position_indentation)
3875 (indented_beyond_p, Fmove_to_column, compute_motion):
3876 (Fcompute_motion, Fvertical_motion):
3877 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3878 (last_known_column_modified): Use EMACS_INT, not int.
3879 (check_display_width):
3881 Check that fixnums and floats are in proper range for system types.
3882 (compute_motion): Don't assume index or fixnum fits in int.
3883 (compute_motion, Fcompute_motion):
3884 Use int, not EMACS_INT, when it is wide enough.
3885 (vmotion): Omit local var start_hpos that is always 0; that way
3886 we don't need to worry about overflow in expressions involving it.
3887 * indent.h: Adjust decls to match defn changes elsewhere.
3889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3890 Use int, not EMACS_INT, where int is wide enough.
3891 Remove unused members ovstring_chars_done and tab_offset;
3893 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3894 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3895 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3896 (make_gap, copy_text, insert, insert_and_inherit)
3897 (insert_before_markers, insert_before_markers_and_inherit)
3898 (insert_1, count_combining_before, count_combining_after)
3899 (insert_1_both, insert_from_string)
3900 (insert_from_string_before_markers, insert_from_string_1)
3901 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3902 (adjust_after_replace, adjust_after_insert, replace_range)
3903 (replace_range_2, del_range, del_range_1, del_range_byte)
3904 (del_range_both, del_range_2, modify_region)
3905 (prepare_to_modify_buffer, signal_before_change)
3906 (signal_after_change, Fcombine_after_change_execute):
3907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3908 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3909 (balance_an_interval, split_interval_right, split_interval_left)
3910 (find_interval, next_interval, update_interval)
3911 (adjust_intervals_for_insertion, delete_node, delete_interval)
3912 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3913 (static_offset_intervals, offset_intervals)
3914 (merge_interval_right, merge_interval_left, make_new_interval)
3915 (graft_intervals_into_buffer, temp_set_point_both)
3916 (temp_set_point, set_point, adjust_for_invis_intang)
3917 (set_point_both, move_if_not_intangible, get_property_and_range)
3918 (get_local_map, copy_intervals, copy_intervals_to_string)
3919 (compare_string_intervals, set_intervals_multibyte_1):
3920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3921 * intervals.h: Adjust decls to match defn changes elsewhere.
3923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3924 * keyboard.c (this_command_key_count, this_single_command_key_start)
3925 (before_command_key_count, before_command_echo_length, echo_now)
3926 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3927 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3928 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3929 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3931 (last_non_minibuf_size, last_point_position, echo_truncate)
3932 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3933 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3934 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3935 (stuff_buffered_input):
3936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3937 (last_auto_save, command_loop_1, read_char):
3938 Use EMACS_INT, not int, to avoid integer overflow.
3939 (record_char): Avoid overflow in total_keys computation.
3940 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3941 * keyboard.h: Adjust decls to match defn changes elsewhere.
3942 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3943 (Fkey_description, Fdescribe_vector, Flookup_key):
3944 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3945 (click_position): New function, to check that positions are in range.
3946 (Fcurrent_active_maps):
3948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3949 (Faccessible_keymaps, Fkey_description):
3950 (preferred_sequence_p):
3951 Don't assume fixnum can fit into int.
3952 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3953 Check for integer overflow in size calculations.
3954 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3955 avoid mishandling large integers.
3956 * lisp.h: Adjust decls to match defn changes elsewhere.
3957 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3958 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3959 (struct Lisp_Marker):
3960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3961 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3962 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3963 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3964 All callers changed.
3965 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3966 Assume the arg has valid form, since it always does.
3967 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3968 unsigned integer system type.
3969 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3970 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3971 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3972 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3973 (duration_to_sec_usec): New decl.
3974 * lread.c (read_from_string_index, read_from_string_index_byte)
3975 (read_from_string_limit, readchar, unreadchar, openp)
3976 (read_internal_start, read1, oblookup):
3977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3978 (Fload, readevalloop, Feval_buffer, Feval_region):
3979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3980 (openp): Check for out-of-range argument to 'access'.
3981 (read1): Use int, not EMACS_INT, where int is wide enough.
3982 Don't assume fixnum fits into int.
3983 Fix off-by-one error that can read outside a buffer.
3984 (read_filtered_event): Use duration_to_sec_usec
3985 to do proper overflow checking on durations.
3986 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3987 in size calculation.
3988 (Fexecute_kbd_macro):
3989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3990 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3991 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3992 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3993 (set_marker_both, set_marker_restricted_both, marker_position)
3994 (marker_byte_position, Fbuffer_has_markers_at):
3995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3996 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3997 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3998 It now merely ensures that the menu is large enough, without
3999 necessarily growing it, as this avoids some integer overflow issues.
4000 All callers changed.
4001 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4003 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4004 Use SAFE_ALLOCA_LISP, not alloca.
4005 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4006 to EMACS_INT. Check that fixnums are in proper range for system types.
4007 * minibuf.c (minibuf_prompt_width, string_to_object)
4008 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4009 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4011 (get_minibuffer, read_minibuf_unwind):
4012 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4013 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4014 this simplifies overflow checking. All callers changed.
4015 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4017 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4018 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4019 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4020 Check that fixnums are in proper range for system types.
4021 (Fx_create_frame, Fx_show_tip):
4022 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4023 * nsfont.m (ns_findfonts, nsfont_list_family):
4024 Don't assume fixnum fits in long.
4025 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4027 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4029 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
4030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4031 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4032 (PRINTDECLARE, PRINTPREPARE):
4033 (strout, print_string):
4034 (print, print_preprocess, print_check_string_charset_prop)
4036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4038 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4040 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
4041 (printchar, strout): Use xpalloc to catch size calculation overflow.
4042 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
4043 (print_error_message): Use SAFE_ALLOCA, not alloca.
4044 (print_object): Use int, not EMACS_INT, where int is wide enough.
4045 (print_depth, new_backquote_output, print_number_index):
4046 Use ptrdiff_t, not int, where int might not be wide enough.
4047 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4048 (Fset_process_window_size, Fformat_network_address)
4049 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
4051 Check that fixnums are in proper range for system types.
4052 (Fsignal_process): Simplify by avoiding a goto.
4053 Check for process-ids out of pid_t range rather than relying on
4055 (process_tick, update_tick): Use EMACS_INT, not int.
4056 (Fformat_network_address, read_process_output, send_process)
4057 (Fprocess_send_region, status_notify):
4058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4059 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4060 (wait_reading_process_output, read_process_output, exec_sentinel):
4061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4062 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4063 (Faccept_process_output): Use duration_to_sec_usec to do proper
4064 overflow checking on durations.
4065 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4066 Don't assume pid_t fits in int.
4067 * process.h (struct Lisp_Process): Members tick and update_tick
4068 are now of type EMACS_INT, not int.
4069 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4070 configured --with-wide-int.
4071 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4072 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4073 * search.c (looking_at_1, string_match_1):
4074 (fast_string_match, fast_c_string_match_ignore_case)
4075 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4076 (scan_newline, find_before_next_newline, search_command)
4077 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4078 (set_search_regs, wordify):
4081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4082 (string_match_1, search_buffer, set_search_regs):
4084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4085 (wordify): Check for overflow in size calculation.
4086 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4087 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4088 Check that fixnums are in proper range for system types.
4089 * sound.c (struct sound_device)
4090 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4092 (Fplay_sound_internal):
4093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4094 * syntax.c (struct lisp_parse_state, find_start_modiff)
4095 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4096 (Fparse_partial_sexp):
4097 Don't assume fixnums can fit in int.
4098 (struct lisp_parse_state, find_start_pos, find_start_value)
4099 (find_start_value_byte, find_start_begv)
4100 (update_syntax_table, char_quoted, dec_bytepos)
4101 (find_defun_start, prev_char_comend_first, back_comment):
4102 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4103 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4105 (Finternal_describe_syntax_value): Check that match_lisp is a
4106 character, not an integer, since the code stuffs it into int.
4107 (scan_words, scan_sexps_forward):
4108 Check that fixnums are in proper range for system types.
4110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4111 (scan_sexps_forward):
4112 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4113 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4114 * syntax.h: Adjust decls to match defn changes elsewhere.
4115 (struct gl_state_s):
4116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4117 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4118 MOST_POSITIVE_FIXNUM.
4119 * sysdep.c (wait_for_termination_1, wait_for_termination)
4120 (interruptible_wait_for_termination, mkdir):
4121 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4122 (emacs_read, emacs_write):
4123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4124 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4125 and double all fit in int.
4126 * term.c (set_tty_color_mode):
4127 Check that fixnums are in proper range for system types.
4128 * termhooks.h (struct input_event):
4129 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4130 * textprop.c (validate_interval_range, interval_of)
4131 (Fadd_text_properties, set_text_properties_1)
4132 (Fremove_text_properties, Fremove_list_of_text_properties)
4133 (Ftext_property_any, Ftext_property_not_all)
4134 (copy_text_properties, text_property_list, extend_property_ranges)
4135 (verify_interval_modification):
4136 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4137 (Fnext_single_char_property_change)
4138 (Fprevious_single_char_property_change):
4139 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4140 (copy_text_properties):
4141 Check for integer overflow in index calculation.
4142 * undo.c (last_boundary_position, record_point, record_insert)
4143 (record_delete, record_marker_adjustment, record_change)
4144 (record_property_change):
4145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4146 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4148 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4149 (Fx_hide_tip, Fx_file_dialog):
4150 * w32menu.c (set_frame_menubar):
4151 Use ptrdiff_t, not int, for consistency with rest of code.
4152 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4153 (select_window, Fdelete_other_windows_internal)
4154 (window_scroll_pixel_based, window_scroll_line_based)
4155 (Frecenter, Fset_window_configuration):
4156 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4157 (Fset_window_hscroll, run_window_configuration_change_hook)
4158 (set_window_buffer, temp_output_buffer_show, scroll_command)
4159 (Fscroll_other_window, Frecenter):
4160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4161 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4162 Don't assume fixnum fits in int.
4163 (Fset_window_scroll_bars):
4164 Check that fixnums are in proper range for system types.
4165 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4166 (string_pos, c_string_pos, number_of_chars, init_iterator)
4167 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4168 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4169 (compute_display_string_end, handle_face_prop)
4170 (face_before_or_after_it_pos, handle_invisible_prop)
4171 (handle_display_prop, handle_display_spec, handle_single_display_spec)
4172 (display_prop_intangible_p, string_buffer_position_lim)
4173 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4174 (get_overlay_strings_1, get_overlay_strings)
4175 (iterate_out_of_display_property, forward_to_next_line_start)
4176 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4177 (get_next_display_element, set_iterator_to_next)
4178 (get_visually_first_element, compute_stop_pos_backwards)
4179 (handle_stop_backwards, next_element_from_buffer)
4180 (move_it_in_display_line_to, move_it_in_display_line)
4181 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4182 (add_to_log, message_dolog, message_log_check_duplicate)
4183 (message2, message2_nolog, message3, message3_nolog
4184 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4185 (current_message_1, truncate_echo_area, truncate_message_1)
4186 (set_message, set_message_1, store_mode_line_noprop)
4187 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4188 (text_outside_line_unchanged_p, check_point_in_composition)
4189 (reconsider_clip_changes)
4190 (redisplay_internal, set_cursor_from_row, try_scrolling)
4191 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4192 (redisplay_window, find_last_unchanged_at_beg_row)
4193 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4194 (trailing_whitespace_p, find_row_edges, display_line)
4195 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4196 (display_mode_element, store_mode_line_string)
4197 (pint2str, pint2hrstr, decode_mode_spec)
4198 (display_count_lines, display_string, draw_glyphs)
4199 (x_produce_glyphs, x_insert_glyphs)
4200 (rows_from_pos_range, mouse_face_from_buffer_pos)
4201 (fast_find_string_pos, mouse_face_from_string_pos)
4202 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4204 (safe_call, init_from_display_pos, handle_fontified_prop)
4205 (handle_single_display_spec, load_overlay_strings)
4206 (with_echo_area_buffer, setup_echo_area_for_printing)
4207 (display_echo_area, echo_area_display)
4208 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4209 (update_tool_bar, hscroll_window_tree, redisplay_internal)
4210 (redisplay_window, dump_glyph_row, display_mode_line)
4211 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
4212 (handle_display_spec, display_prop_string_p):
4213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4214 (handle_single_display_spec, build_desired_tool_bar_string)
4215 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4216 (get_specified_cursor_type):
4217 Check that fixnums are in proper range for system types.
4218 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4219 (Flookup_image_map):
4220 Don't assume fixnums fit in int.
4221 (compare_overlay_entries):
4222 Avoid mishandling comparisons due to subtraction overflow.
4223 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4224 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4225 (handle_tool_bar_click):
4226 Use int, not unsigned, since we prefer signed and the signedness
4227 doesn't matter here.
4228 (get_next_display_element, next_element_from_display_vector):
4229 Use int, not EMACS_INT, when int is wide enough.
4230 (start_hourglass): Use duration_to_sec_usec to do proper
4231 overflow checking on durations.
4232 * xfaces.c (Fbitmap_spec_p):
4233 Check that fixnums are in proper range for system types.
4234 (compare_fonts_by_sort_order):
4235 Avoid mishandling comparisons due to subtraction overflow.
4236 (Fx_family_fonts, realize_basic_faces):
4237 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4239 Don't assume fixnum fits in int.
4240 Use SAFE_ALLOCA_LISP, not alloca.
4241 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4242 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4243 (face_at_buffer_position, face_for_overlay_string)
4244 (face_at_string_position):
4245 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4246 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4247 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4249 Check that fixnums are in proper range for system types.
4250 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4251 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4253 (Fx_change_window_property): Don't assume fixnums fit in int.
4254 * xfont.c (xfont_chars_supported):
4255 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4256 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4257 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4258 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4259 * xml.c (parse_region):
4260 * xrdb.c (magic_file_p):
4261 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4262 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4263 (x_get_local_selection, x_reply_selection_request)
4264 (x_handle_selection_request, wait_for_property_change):
4265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4266 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4267 short is wide enough.
4268 (x_send_client_event): Don't assume fixnum fits in int.
4269 * xterm.c (x_x_to_emacs_modifiers):
4270 Don't assume EMACS_INT overflows nicely into int.
4271 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4273 (handle_one_xevent): NATNUMP can eval its arg twice.
4274 (x_connection_closed):
4275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4276 * xterm.h: Adjust decls to match defn changes elsewhere.
4277 (struct scroll_bar): Use struct vectorlike_header
4278 rather than rolling our own approximation.
4279 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4281 2012-05-25 Glenn Morris <rgm@gnu.org>
4283 * lisp.mk (lisp): Update for more files being compiled now.
4285 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4287 * lread.c: Remove `read_pure' which makes no difference.
4288 (read_pure): Remove var.
4289 (unreadpure): Remove function.
4290 (readevalloop): Don't call read_list with -1 flag.
4291 (read1, read_vector): Don't test read_pure any more.
4292 (read_list): Simplify.
4294 * fileio.c, character.h: Minor style tweaks.
4296 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4298 * window.h (clip_changed): Remove useless declaration.
4300 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4302 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4303 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4305 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4308 This directory predates autoconf and is no longer needed nowadays.
4309 Move its few remaining bits of functionality to where they're needed.
4310 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4311 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4312 * m/template.h: Remove.
4313 * Makefile.in (M_FILE): Remove. All uses removed.
4314 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4315 * lisp.h (USE_LSB_TAG):
4316 * mem-limits.h (EXCEEDS_LISP_PTR):
4317 Use VAL_MAX, not VALBITS, in #if.
4318 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4319 (EMACS_UINT): Define unconditionally now.
4320 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4321 (BITS_PER_EMACS_INT): New constants, replacing
4322 what used to be in config.h, but not useful in #if.
4323 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4324 define them any more.
4325 (VAL_MAX): New macro.
4327 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4328 BITS_PER_EMACS_INT, in #if.
4329 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4330 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4331 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4332 * s/ms-w32.h (DATA_START):
4333 Move here from removed file m/intel386.h.
4334 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4335 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4337 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4339 Assume C89 or later.
4340 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4341 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4343 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4344 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4345 * textprop.c, tparam.c (NULL): Remove.
4346 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4347 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4348 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4349 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4350 * xterm.c (input_signal_count): Assume volatile works.
4352 2012-05-21 Ken Brown <kbrown@cornell.edu>
4354 * xgselect.c (xg_select): Fix first argument in call to 'select'
4357 2012-05-20 Ken Brown <kbrown@cornell.edu>
4359 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4360 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4362 2012-05-19 Ken Brown <kbrown@cornell.edu>
4364 * xfns.c (x_in_use): Remove `static' qualifier.
4365 * xterm.h (x_in_use): Declare.
4366 * xgselect.c: Include xterm.h.
4367 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4368 and `display_arg' (bug#9754).
4370 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4372 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4374 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4375 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4377 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4379 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4381 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4382 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4384 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4385 reference to image_cache->refcount.
4386 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4388 2012-05-17 Juri Linkov <juri@jurta.org>
4390 * search.c (Fword_search_regexp, Fword_search_backward)
4391 (Fword_search_forward, Fword_search_backward_lax)
4392 (Fword_search_forward_lax): Move functions to isearch.el
4393 (bug#10145, bug#11381).
4395 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4397 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4399 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4401 * lread.c (init_obarray): Declare Qt and Qnil as special.
4403 2012-05-14 Glenn Morris <rgm@gnu.org>
4405 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4406 Put "libexec" before "bin", for the sake of init_callproc_1.
4408 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4410 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4412 * unexaix.c: Port to more-recent AIX compilers.
4413 (report_error, report_error_1, make_hdr, copy_sym)
4414 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4415 Make arguments const char *, not char *, to avoid violations of C
4416 standard and to fix some AIX warnings reported by Gilles Pion.
4418 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4420 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4421 already have overlays loaded.
4422 (handle_single_display_spec): Before returning without displaying
4423 fringe bitmap, synchronize the bidi iterator with the main display
4424 iterator, by calling iterate_out_of_display_property.
4425 (iterate_out_of_display_property): Detect buffer iteration by
4426 testing that it->string is a Lisp string.
4427 (get_next_display_element): When the current object is exhausted,
4428 and there's something on it->stack, call set_iterator_to_next to
4429 proceed with what's on the stack, instead of returning zero.
4430 (set_iterator_to_next): If called at the end of a Lisp string,
4431 proceed to consider_string_end without incrementing string
4432 position. Don't increment display vector index past the end of
4433 the display vector. (Bug#11417)
4434 (pos_visible_p): Don't report a position visible when move_it_to
4435 stopped at the last line of window, which happens to be scanned
4436 backwards by the bidi iteration. (Bug#11464)
4438 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4440 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4441 and right-margin display specs even if the spec is invalid or we
4442 are on a TTY, and thus unable to display on the fringes.
4443 That's because the text with the property will not be displayed anyway,
4444 so we need to signal to the caller that this is a "replacing"
4445 display spec. This fixes display when the spec is invalid or we
4448 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4450 * unexaix.c (make_hdr): Fix typo in prototype.
4451 This bug broke the build on AIX. Problem reported by Gilles Pion.
4453 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4455 * keyboard.c (kbd_buffer_get_event): Read special events also in
4456 batch mode. (Bug#11415)
4458 2012-05-12 Glenn Morris <rgm@gnu.org>
4460 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4462 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4464 * lisp.mk (lisp): Add newcomment.elc.
4466 2012-05-12 Glenn Morris <rgm@gnu.org>
4468 * Makefile.in (MKDIR_P): New, set by configure.
4469 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4471 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4473 Remove unused function hourglass_started.
4474 * dispextern.h (hourglass_started):
4475 * w32fns.c (hourglass_started):
4476 * xdisp.c (hourglass_started): Remove.
4478 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4480 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4481 Update dependencies.
4483 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4485 * xgselect.c (xg_select): Put maxfds+1 into a var.
4486 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4488 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4490 2012-05-10 Dave Abrahams <dave@boostpro.com>
4492 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4493 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4495 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4497 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4498 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4499 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4500 Initialize xd_registered_buses.
4502 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4504 Untag more efficiently if USE_LSB_TAG.
4505 This is based on a proposal by YAMAMOTO Mitsuharu in
4506 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4507 For an admittedly artificial (nth 8000 longlist) benchmark on
4508 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4509 Emacs's overall text size by 1%.
4510 * lisp.h (XUNTAG): New macro.
4511 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4512 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4513 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4514 * eval.c (Fautoload):
4515 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4516 * frame.h (XFRAME): Use XUNTAG.
4518 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4519 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4520 Remove unportable assumptions about print widths of types like
4522 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4523 intptr_t when converting between pointer and integer, to avoid GCC
4524 warnings about wrong width.
4526 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4528 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4529 stack for each reader_thread, instead of defaulting to 8MB
4530 determined by the linker. This avoids failures in creating
4531 subprocesses on Windows 7, see the discussion in this thread:
4532 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4534 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4536 Fix up display of the *Minibuf-0* buffer in the mini window.
4537 * keyboard.c (read_char): Don't clear the echo area if there's no
4539 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4540 contents of *Minibuf-0*) if there's no message displayed in its stead.
4542 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4544 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4547 2012-05-06 Chong Yidong <cyd@gnu.org>
4549 * lisp.mk (lisp): Update.
4551 2012-05-05 Jim Meyering <meyering@redhat.com>
4553 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4555 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4557 * data.c (PUT_ERROR): New macro.
4558 (syms_of_data): Use it. Add new error type `user-error'.
4559 * undo.c (user_error): New function.
4560 (Fprimitive_undo): Use it.
4561 * print.c (print_error_message): Adjust print style for `user-error'.
4562 * keyboard.c (user_error): New function.
4563 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4565 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4567 Do not limit current-time-string to years 1000..9999.
4568 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4569 (Fcurrent_time_string): Support any year that is supported by the
4570 underlying localtime representation. Don't use asctime, as it
4571 has undefined behavior for years outside the range -999..9999.
4573 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4575 Fix race conditions involving setenv, gmtime, localtime, asctime.
4576 Without this fix, interrupts could mess up code that uses these
4577 nonreentrant functions, since setting TZ invalidates existing
4578 tm_zone or tzname values, and since most of these functions return
4579 pointers to static storage.
4580 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4581 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4582 Grow the critical sections to include not just invoking
4583 localtime/gmtime, but also accessing these functions' results
4584 including their tm_zone values if any, and any related TZ setting.
4585 (format_time_string): Last arg is now struct tm *, not struct tm **,
4586 so that the struct tm is saved in the critical section.
4587 All callers changed. Simplify allocation of initial buffer, partly
4588 motivated by the fact that memory allocation needs to be outside
4589 the critical section.
4591 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4593 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4594 with RESET_INTERVAL.
4596 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4597 Remove duplicated buffer name initialization.
4599 2012-05-02 Jim Meyering <jim@meyering.net>
4601 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4603 * xfns.c (x_window): Use xstrdup (Bug#11375).
4605 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4607 * xdisp.c (pos_visible_p): If already at a newline from the
4608 display string before the 'while' loop, don't walk back the glyphs
4609 from it3.glyph_row. Solves assertion violation when the display
4610 string begins with a newline (egg.el). (Bug#11367)
4612 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4614 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4617 2012-05-01 Glenn Morris <rgm@gnu.org>
4619 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4620 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4621 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4622 All were removed before 23.1.
4624 * dispnew.c: Remove HAVE_LIBNCURSES test;
4625 it is always true on relevant platforms.
4627 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4628 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4630 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4632 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4634 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4635 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4638 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4640 Do not avoid creating empty evaporating overlays (Bug#9642).
4641 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4642 That is, do not delete an evaporating overlay if it becomes
4643 empty after its bounds are adjusted to fit within its buffer.
4644 This fix caused other problems, and I'm reverting it until we get
4645 to the bottom of them.
4647 2012-04-27 Chong Yidong <cyd@gnu.org>
4649 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4651 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4653 * xdisp.c (pos_visible_p): If the window start position is beyond
4654 ZV, start the display from buffer beginning. Prevents assertion
4655 violation in init_iterator when the minibuffer window is scrolled
4658 * window.c (window_scroll_pixel_based): Likewise.
4660 2012-04-27 Chong Yidong <cyd@gnu.org>
4662 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4664 2012-04-27 Glenn Morris <rgm@gnu.org>
4666 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4667 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4669 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4671 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4672 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4674 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4676 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4677 display element, check also the underlying string or buffer
4678 character. (Bug#11341)
4680 * w32menu.c: Include w32heap.h.
4681 (add_menu_item): If the call to AppendMenuW (via
4682 unicode_append_menu) fails, disable Unicode menus only if we are
4683 running on Windows 9X/Me.
4685 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4687 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4688 (xgetint): Add missing shift for LSB tags.
4690 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4692 * keyboard.c (read_char): Don't wipe echo area for select window
4693 events: These might get delayed via `mouse-autoselect-window'
4696 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4698 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4699 manipulation of :loaded-from data.
4701 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4703 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4704 now a cons (bug#11311).
4706 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4708 Do not create empty overlays with the evaporate property (Bug#9642).
4709 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4710 if it becomes empty after its bounds are adjusted to fit within
4711 its buffer. Without this fix, in a nonempty buffer (let ((o
4712 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4713 yields an empty overlay that has the evaporate property, which is
4714 not supposed to happen.
4716 Fix minor GTK3 problems found by static checking.
4717 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4718 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4719 (struct _EmacsFixedClass, emacs_fixed_get_type):
4720 Move decls here from emacsgtkfixed.h, since they needn't be public.
4721 (emacs_fixed_get_type): Now static.
4722 (emacs_fixed_class_init): Omit unused local.
4723 (emacs_fixed_child_type): Remove; unused.
4724 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4725 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4726 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4727 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4728 (EMACS_FIXED_GET_CLASS): Remove; unused.
4729 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4731 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4732 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4734 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4736 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4737 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4738 (__malloc_size_t, __malloc_ptrdiff_t):
4739 Remove. All uses removed, replaced by the definiens if needed,
4740 since we can assume C89 or better now.
4741 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4742 (protect_malloc_state, align, get_contiguous_space)
4743 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4744 (malloc_atfork_handler_child, malloc_enable_thread)
4745 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4746 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4747 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4748 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4749 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4750 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4751 Define using prototypes, not old style.
4752 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4753 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4754 (align): Don't assume that signed integer overflow wraps around.
4755 Omit unused local var.
4756 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4757 (_free_internal_nolock, memalign, mallochook, reallochook):
4758 Omit no-longer-needed casts.
4759 (valloc): Use getpagesize, not __getpagesize.
4760 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4761 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4763 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4765 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4767 Move functions from C to Lisp. Make non-blocking method calls
4768 the default. Implement further D-Bus standard interfaces.
4770 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4771 (QCdbus_request_name_allow_replacement)
4772 (QCdbus_request_name_replace_existing)
4773 (QCdbus_request_name_do_not_queue)
4774 (QCdbus_request_name_reply_primary_owner)
4775 (QCdbus_request_name_reply_in_queue)
4776 (QCdbus_request_name_reply_exists)
4777 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4778 (QCdbus_registered_serial, QCdbus_registered_method)
4779 (QCdbus_registered_signal): New Lisp objects.
4780 (XD_DEBUG_MESSAGE): Use sizeof.
4781 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4782 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4783 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4784 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4785 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4786 (xd_signature, xd_append_arg): Allow float for integer types.
4787 (xd_get_connection_references): New function.
4788 (xd_get_connection_address): Rename from xd_initialize.
4789 Return cached address.
4790 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4791 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4793 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4794 Return number of refcounts.
4795 (Fdbus_get_unique_name): Make stronger parameter check.
4796 (Fdbus_message_internal): New defun.
4797 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4798 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4799 (Fdbus_send_signal, Fdbus_register_service)
4800 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4801 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4802 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4803 (Vdbus_compiled_version, Vdbus_runtime_version)
4804 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4805 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4806 (Vdbus_message_type_signal): New defvars.
4807 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4810 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4812 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4813 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4814 Do not assume ptrdiff_t is the same width as 'int'.
4816 * alloc.c: Handle unusual debugging option combinations.
4817 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4818 since the two debugging options are incompatible.
4819 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4821 (mem_init, mem_insert, mem_insert_fixup):
4822 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4823 (NEED_MEM_INSERT): Remove; no longer needed.
4825 2012-04-22 Leo Liu <sdl.web@gmail.com>
4827 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4829 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4831 * sysdep.c [__FreeBSD__]: Minor cleanups.
4832 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4833 Use Emacs indenting style more consistently. Avoid some casts.
4834 Use 'double' consistently rather than mixing 'float' and 'double'.
4836 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4838 * sysdep.c (list_system_processes, system_process_attributes):
4839 Add implementation for FreeBSD (Bug#5243).
4841 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4843 * lisp.mk (lisp): Update.
4845 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4847 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4848 It is never used otherwise.
4850 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4852 * print.c (print_preprocess): Only check print_depth if print-circle
4854 (print_object): Check for cycles even when print-circle is nil and
4855 print-gensym is t, but only check print_depth if print-circle is nil.
4857 2012-04-20 Chong Yidong <cyd@gnu.org>
4859 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4860 set the status to "failed" and ensure that sentinel is run.
4862 2012-04-20 Glenn Morris <rgm@gnu.org>
4864 * process.c (Fset_process_inherit_coding_system_flag)
4865 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4866 (Fmake_network_process, Fmake_serial_process): Doc fix.
4868 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4870 * xdisp.c (string_buffer_position_lim): Limit starting position to
4872 (set_cursor_from_row): If called for a mode-line or header-line
4873 row, return zero immediately.
4874 (try_cursor_movement): If inside continuation line, don't back up
4875 farther than the first row after the header line, if any.
4876 Don't consider the header-line row as "partially visible", even if
4877 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4879 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4881 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4884 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4885 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4887 configure: new option --enable-gcc-warnings (Bug#11207)
4888 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4889 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4890 (ALL_CFLAGS): Use new macros rather than old.
4891 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4892 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4893 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4894 -Wunused-result, -Wunused-variable. This should go away once
4895 the Emacs and Gnulib regex code is merged.
4896 (xmalloc, xrealloc): Now static.
4898 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4900 * dired.c (Fsystem_groups): Remove unused local.
4902 2012-04-17 Glenn Morris <rgm@gnu.org>
4904 * dired.c (Fsystem_users): Doc fix.
4906 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4908 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4909 (syms_of_dired): Add them.
4911 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4913 Fix minor alloc.c problems found by static checking.
4914 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4915 New extern decls, to avoid calling undeclared functions.
4916 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4917 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4918 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4919 (NEED_MEM_INSERT): New macro.
4920 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4921 Remove one incorrect comment and fix another.
4923 Fix minor ralloc.c problems found by static checking.
4924 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4925 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4926 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4927 (r_alloc_sbrk): Now static.
4929 Improve ralloc.c interface checking.
4930 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4931 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4932 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4933 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4934 [REL_ALLOC]: ... to here, to check interface.
4935 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4936 Remove decls. This fixes an "It stinks!".
4938 * alloc.c (which_symbols): Fix alignment issue / type clash.
4940 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4942 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4943 (struct Lisp_Misc_Any): Likewise.
4944 (struct Lisp_Free): Likewise.
4945 * alloc.c (union aligned_Lisp_Symbol): Define.
4946 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4947 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4948 (union aligned_Lisp_Misc): Define.
4949 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4950 aligned_Lisp_Misc instead of union Lisp_Misc.
4951 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4953 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4955 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4956 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4957 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4958 * s/netbsd.h, s/sol2-6.h:
4959 Remove definition of GC_MARK_STACK, since the default now works.
4960 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4961 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4962 no longer the default.
4963 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4965 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4967 * lread.c (lisp_file_lexically_bound_p):
4968 Fix hang at ";-*-\n" (bug#11238).
4970 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4972 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4973 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4975 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4977 * nsterm.m (constrainFrameRect): Always constrain when there is only
4978 one screen (Bug#10962).
4980 2012-04-13 Ken Brown <kbrown@cornell.edu>
4982 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4984 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4986 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4988 2012-04-11 Daniel Colascione <dancol@dancol.org>
4990 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4991 against is gone. It's better to use vfork now so that when Cygwin
4992 gains a new, working vfork, we use it automatically (bug#10398).
4994 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4996 * window.c (save_window_save): Obey window-point-insertion-type.
4998 2012-04-11 Glenn Morris <rgm@gnu.org>
5000 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5002 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5004 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5006 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
5008 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5009 (force_quit_count): New var.
5010 (handle_interrupt): Use it.
5012 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
5014 * w32.c (w32_delayed_load): Record the full path of the library
5015 being loaded (bug#10424).
5017 2012-04-09 Glenn Morris <rgm@gnu.org>
5019 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5020 not just in the obarray, before snarfing them. (Bug#11036)
5022 * Makefile.in ($(leimdir)/leim-list.el):
5023 Pass EMACS rather than BUILT_EMACS.
5025 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5027 * process.c (make_process):
5028 * process.h: Add integer `gnutls_handshakes_tried' member to
5031 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5032 Add convenience `GNUTLS_LOG2i' macro.
5034 * gnutls.c (gnutls_log_function2i): Convenience log function.
5035 (emacs_gnutls_read): Use new log functions,
5036 `gnutls_handshakes_tried' process member, and
5037 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5038 attempts per process (connection).
5040 2012-04-09 Chong Yidong <cyd@gnu.org>
5042 * eval.c (Fuser_variable_p, user_variable_p_eh)
5043 (lisp_indirect_variable): Functions deleted.
5044 (Fdefvar): Caller changed.
5046 * callint.c (Finteractive, Fcall_interactively):
5047 * minibuf.c (Fread_variable): Callers changed.
5049 2012-04-09 Eli Zaretskii <eliz@gnu.org>
5051 * xdisp.c (set_cursor_from_row): If the display string appears in
5052 the buffer at position that is closer to point than the position
5053 after the display string, display the cursor on the first glyph of
5054 the display string. Fixes cursor display when a 'display' text
5055 property immediately follows invisible text. (Bug#11094)
5057 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5059 composite.c: use 'double' consistently
5060 * composite.c (get_composition_id): Use 'double' consistently
5061 instead of converting 'float' to 'double' and vice versa; this is
5062 easier to understand and avoids a GCC warning.
5064 2012-04-09 Glenn Morris <rgm@gnu.org>
5066 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5067 preparation for dumping it with emacs. (Bug#4789)
5068 (leimdir): New variable.
5069 ($(leimdir)/leim-list.el): New rule.
5070 (emacs$(EXEEXT)): Depend on leim-list.el.
5072 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5073 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5074 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5076 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5078 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5081 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
5083 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5084 Remove unused local variable.
5086 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5088 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5089 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5090 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5091 objects, as mark_maybe_pointer will catch them otherwise.
5092 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5093 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5095 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5097 Fix typo that broke non-Windows builds.
5098 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5100 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5102 Support building on MS-Windows with libxml2.
5104 * makefile.w32-in (OBJ2): Add xml.$(O).
5105 (GLOBAL_SOURCES): Add xml.c.
5106 ($(BLD)/xml.$(O)): New dependency list.
5108 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5109 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5110 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5111 [!WINDOWSNT]: New macros.
5112 (init_libxml2_functions, libxml2_loaded_p): New functions.
5113 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5114 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5115 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5116 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5118 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5119 Call init_libxml2_functions before calling libxml2 functions.
5120 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5122 * emacs.c: Don't include libxml/parser.h.
5123 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5124 xmlCleanupParser directly.
5126 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5128 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5130 * indent.c (Fvertical_motion): If there is a display string at
5131 point, use it.vpos to compute how many lines to backtrack after
5132 move_it_to point. (Bug#11133)
5134 2012-04-06 Eli Zaretskii <eliz@gnu.org>
5136 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5137 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5138 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5139 macros related to unification of CJK characters. For the details,
5140 see the discussion following the message here:
5141 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5143 2012-04-04 Chong Yidong <cyd@gnu.org>
5145 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5147 2012-04-01 Eli Zaretskii <eliz@gnu.org>
5149 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5150 instead of alloca. (Bug#11138)
5152 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5154 * w32menu.c (is_simple_dialog): Properly check lisp types.
5157 2012-03-31 Eli Zaretskii <eliz@gnu.org>
5159 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5160 position we get to after a call to move_it_to fails the
5161 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5162 only if we wind up in a string from display property. (Bug#11063)
5164 * window.c (Fdelete_other_windows_internal): Invalidate the row
5165 and column information about mouse highlight, so that redisplay
5166 restores it after reallocating the glyph matrices. (Bug#7464)
5168 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5169 string comes from a `display' text property, use the buffer
5170 position of that property as if we actually saw that position in
5172 (move_it_by_lines): Remove the assertion that
5173 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5174 violated when there's a before-string at the beginning of a line.
5177 2012-03-30 Eli Zaretskii <eliz@gnu.org>
5179 * xdisp.c (append_space_for_newline): If the default face was
5180 remapped, use the remapped face for the appended newline.
5181 (extend_face_to_end_of_line): Use the remapped default face for
5182 extending the face to the end of the line.
5183 (display_line): Call extend_face_to_end_of_line when the default
5184 face was remapped. (Bug#11068)
5186 2012-03-29 Eli Zaretskii <eliz@gnu.org>
5188 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5190 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5192 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5194 2012-03-27 Glenn Morris <rgm@gnu.org>
5196 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5199 2012-03-26 Kenichi Handa <handa@m17n.org>
5201 * dispextern.h (struct glyph): Fix previous change. Change the
5202 bit length of glyphless.ch to 25 (Bug#11082).
5204 2012-03-26 Chong Yidong <cyd@gnu.org>
5206 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5207 (command_loop_1): Use it; inhibit selection update for
5208 handle-select-window too (Bug#8996).
5210 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5212 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
5214 2012-03-25 Kenichi Handa <handa@m17n.org>
5216 * dispextern.h (struct glyph): Change the bit length of
5217 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5219 2012-03-24 Eli Zaretskii <eliz@gnu.org>
5221 * s/ms-w32.h (tzname): Include time.h before redirecting to
5222 _tzname. Fixes the MSVC build. (Bug#9960)
5224 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5226 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5229 * xterm.c (XTread_socket): Only modify handling_signal if
5230 !SYNC_INPUT. (Bug#11080)
5232 2012-03-23 Eli Zaretskii <eliz@gnu.org>
5234 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5235 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5236 when fetching a multibyte character consumes more bytes than
5237 CHAR_BYTES returns, due to unification of CJK characters in
5238 string_char. (Bug#11073)
5240 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5242 * process.c (wait_reading_process_output): Handle pty disconnect
5243 by refraining from sending oneself a SIGCHLD (bug#10933).
5245 2012-03-22 Chong Yidong <cyd@gnu.org>
5247 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5249 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
5250 Mark string as coming from a prefix property.
5251 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5252 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5254 2012-03-21 Chong Yidong <cyd@gnu.org>
5256 * xfaces.c (Vface_remapping_alist): Doc fix.
5258 2012-03-20 Eli Zaretskii <eliz@gnu.org>
5260 * w32proc.c (Fw32_set_console_codepage)
5261 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5264 2012-03-20 Chong Yidong <cyd@gnu.org>
5266 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5267 to reflect default non-nil value of redisplay-dont-pause.
5269 2012-03-19 Kenichi Handa <handa@m17n.org>
5271 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5272 it fit in a valid range (Bug#11003).
5274 2012-03-18 Eli Zaretskii <eliz@gnu.org>
5276 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5277 that is not from display property, accept the row as a "cursor
5278 row" if one of the string's character has a non-nil `cursor'
5279 property. Fixes cursor positioning when there are newlines in
5280 overlay strings, e.g. in icomplete.el. (Bug#11035)
5282 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5284 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5286 2012-03-12 Chong Yidong <cyd@gnu.org>
5288 * eval.c (inhibit_lisp_code): Rename from
5289 inhibit_window_configuration_change_hook; move from window.c.
5291 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5292 * window.c (run_window_configuration_change_hook)
5293 (syms_of_window): Callers changed.
5295 2012-03-11 Chong Yidong <cyd@gnu.org>
5297 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5299 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5301 2012-03-10 Chong Yidong <cyd@gnu.org>
5303 * frame.c (other_visible_frames): Don't assume the selected frame
5304 is visible (Bug#10955).
5306 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5308 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5310 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5312 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5313 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5316 2012-03-03 Glenn Morris <rgm@gnu.org>
5318 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5320 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5322 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5323 position past the first glyph_row that ends at ZV. (Bug#10902)
5324 (redisplay_window, next_element_from_string): Fix typos in
5326 (redisplay_window): Pass to move_it_vertically the margin in
5327 pixels, not in screen lines.
5329 2012-03-02 Glenn Morris <rgm@gnu.org>
5331 * buffer.c (buffer-list-update-hook): Doc fix.
5333 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5335 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5336 push_it before setting up the iterator for the first overlay
5337 string, even if we have an empty string loaded.
5338 (next_overlay_string): If there's an empty string on the iterator
5339 stack, pop the stack. (Bug#10903)
5341 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5343 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5344 Suggested by Stefan Monnier in
5345 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5346 * alloc.c (widen_to_Lisp_Object): New static function.
5347 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5348 and widening them to Lisp_Objects. This would work even if
5349 USE_LSB_TAG is defined and wide integers are used, which might
5350 happen in a future version of Emacs.
5352 2012-02-25 Chong Yidong <cyd@gnu.org>
5354 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5357 * xselect.c (Fx_selection_exists_p): Doc fix.
5358 (x_clipboard_manager_save_all): Print an informative message
5359 before saving to clipboard manager.
5361 2012-02-24 Chong Yidong <cyd@gnu.org>
5363 * keyboard.c (process_special_events): Handle all X selection
5364 requests in kbd_buffer, not just the next one (Bug#8869).
5366 2012-02-23 Chong Yidong <cyd@gnu.org>
5368 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5369 call when setting menu-bar-lines and tool-bar-lines parameters.
5370 (unwind_create_frame_1): New helper function.
5372 * window.c (inhibit_window_configuration_change_hook): New var.
5373 (run_window_configuration_change_hook): Obey it.
5374 (syms_of_window): Initialize it.
5376 2012-02-22 Chong Yidong <cyd@gnu.org>
5378 * xterm.c (x_draw_image_relief): Add missing type check for
5379 Vtool_bar_button_margin (Bug#10743).
5381 2012-02-21 Chong Yidong <cyd@gnu.org>
5383 * fileio.c (Vfile_name_handler_alist): Doc fix.
5385 * buffer.c (Fget_file_buffer): Protect against invalid file
5386 handler return value.
5388 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5390 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5391 when computing $valmask.
5393 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5394 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5395 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5396 It's useless in that case, and it can cause problems on hosts
5397 that allocate halves of EMACS_INT values separately.
5398 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5399 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5400 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5401 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5402 it avoids undefined behavior on hosts where shifting right by more
5403 than the word width has undefined behavior.
5405 2012-02-19 Chong Yidong <cyd@gnu.org>
5407 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5408 (Funhandled_file_name_directory, Ffile_name_as_directory)
5409 (Fdirectory_file_name, Fexpand_file_name)
5410 (Fsubstitute_in_file_name): Protect against invalid file handler
5411 return values (Bug#10845).
5413 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5415 * .gdbinit (pitx): Fix incorrect references to fields of the
5418 2012-02-17 Chong Yidong <cyd@gnu.org>
5420 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5422 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5424 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5425 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5427 2012-02-15 Chong Yidong <cyd@gnu.org>
5429 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5430 marked as special. Also, starting docstrings with * is obsolete.
5432 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5434 * gnutls.c (emacs_gnutls_write): Fix last change.
5436 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5438 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5441 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5443 * keymap.c (Fsingle_key_description): Handle char ranges.
5445 2012-02-12 Chong Yidong <cyd@gnu.org>
5447 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5448 as that creates a dangerous corner case.
5450 * window.c (Fdelete_window_internal): Invalidate the mouse
5451 highlight (Bug#9904).
5453 2012-02-12 Glenn Morris <rgm@gnu.org>
5455 * xselect.c (Fx_own_selection_internal)
5456 (Fx_get_selection_internal, Fx_disown_selection_internal)
5457 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5458 * nsselect.m (Fx_own_selection_internal)
5459 (Fx_disown_selection_internal, Fx_selection_exists_p)
5460 (Fx_selection_owner_p, Fx_get_selection_internal):
5461 Sync docs and argument specs with the xselect.c versions.
5463 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5465 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5467 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5469 * w32select.c (Fx_selection_exists_p): Sync doc string and
5470 argument list with xselect.c. (Bug#10783)
5472 * w16select.c (Fx_selection_exists_p): Sync doc string and
5473 argument list with xselect.c. (Bug#10783)
5475 2012-02-10 Glenn Morris <rgm@gnu.org>
5477 * fns.c (Fsecure_hash): Doc fix.
5479 2012-02-09 Kenichi Handa <handa@m17n.org>
5481 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5483 2012-02-07 Chong Yidong <cyd@gnu.org>
5485 * buffer.c (Fbuffer_local_variables)
5486 (buffer_lisp_local_variables): Handle unbound vars correctly;
5487 don't let Qunbound leak into Lisp.
5489 2012-02-07 Glenn Morris <rgm@gnu.org>
5491 * image.c (Fimagemagick_types): Doc fix.
5493 * image.c (imagemagick-render-type): Change it from a lisp object
5494 to an integer. Move the doc here from the lisp manual.
5495 Treat all values not equal to 0 the same.
5497 2012-02-06 Chong Yidong <cyd@gnu.org>
5499 * doc.c (store_function_docstring): Avoid applying docstring of
5500 alias to base function (Bug#2603).
5502 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5504 * .gdbinit (pp1, pv1): Remove redundant defines.
5507 2012-02-04 Chong Yidong <cyd@gnu.org>
5509 * nsterm.m: Declare a global (Bug#10694).
5511 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5513 * w32.c (get_emacs_configuration_options):
5514 Include --enable-checking, if specified, in the return value.
5516 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5518 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5519 after rounding frame sizes. (Bug#9723)
5521 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5523 * keyboard.c (adjust_point_for_property): Don't position point
5524 before BEGV. (Bug#10696)
5526 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5528 Handle overflow when computing char display width (Bug#9496).
5529 * character.c (char_width): Return EMACS_INT, not int.
5530 (char_width, c_string_width): Check for overflow when
5531 computing the width; this is possible now that individual
5532 characters can have unbounded width. Problem introduced
5533 by merge from Emacs 23 on 2012-01-19.
5535 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5537 * dbusbind.c (Fdbus_register_method): Mention the return value
5538 :ignore in the docstring.
5540 2012-02-02 Glenn Morris <rgm@gnu.org>
5542 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5544 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5545 Unconditionally set to t. (Bug#10673)
5546 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5547 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5548 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5550 2012-02-02 Kenichi Handa <handa@m17n.org>
5552 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5553 0, do not call append_composite_glyph.
5555 2012-02-02 Kenichi Handa <handa@m17n.org>
5557 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5559 (x_produce_glyphs): If the component of a composition is a null
5560 string, set it->pixel_width to 1 to avoid zero-width glyph.
5562 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5564 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5565 first 2 arguments are identical. This makes inserting large
5566 output from a subprocess an order of magnitude faster on
5567 MS-Windows, where all sbrk'ed memory is always contiguous.
5569 2012-01-31 Glenn Morris <rgm@gnu.org>
5571 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5572 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5573 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5575 2012-01-29 Glenn Morris <rgm@gnu.org>
5577 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5579 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5581 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5583 2012-01-28 Chong Yidong <cyd@gnu.org>
5585 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5587 2012-01-26 Chong Yidong <cyd@gnu.org>
5589 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5591 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5592 repeat counts (Bug#10507).
5594 2012-01-26 Glenn Morris <rgm@gnu.org>
5596 * lread.c (syms_of_lread): Doc fix.
5598 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5600 * coding.c (encode_designation_at_bol): Change return value to
5603 2012-01-25 Chong Yidong <cyd@gnu.org>
5605 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5607 2012-01-21 Chong Yidong <cyd@gnu.org>
5609 * floatfns.c (Fcopysign): Make the second argument non-optional,
5610 since nil is not allowed anyway.
5612 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5614 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5615 (send_process): Likewise.
5617 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5619 * window.c (save_window_save, Fcurrent_window_configuration)
5620 (Vwindow_persistent_parameters): Do not use Qstate.
5621 Rewrite doc-strings.
5623 2012-01-19 Kenichi Handa <handa@m17n.org>
5625 * character.c (char_width): New function.
5626 (Fchar_width, c_string_width, lisp_string_width):
5627 Use char_width (Bug#9496).
5629 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5631 * window.c (Vwindow_persistent_parameters): New variable.
5632 (Fset_window_configuration, save_window_save): Handle persistent
5635 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5637 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5638 thrashing the stack of the thread. (Bug#9087)
5640 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5642 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5644 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5646 * xdisp.c (rows_from_pos_range): Handle the case where the
5647 highlight ends on a newline. (Bug#10464)
5648 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5649 he end column for display of highlight that ends on a newline
5652 2012-01-11 Glenn Morris <rgm@gnu.org>
5654 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5655 from load-path also when installation-directory is nil. (Bug#10208)
5657 2012-01-10 Glenn Morris <rgm@gnu.org>
5659 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5661 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5662 Update template values to be closer to their typical values these days.
5664 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5666 * xdisp.c (rows_from_pos_range): Accept additional argument
5667 DISP_STRING, and accept any glyph in a row whose object is that
5668 string as eligible for mouse highlight. Fixes mouse highlight of
5669 display strings from overlays. (Bug#10464)
5671 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5673 emacs: fix an auto-save permissions race condition (Bug#10400)
5674 * fileio.c (auto_saving_dir_umask): New static var.
5675 (Fmake_directory_internal): Use it.
5676 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5677 creating the directory. The old code temporarily assigns
5678 too-generous permissions to the directory.
5679 (do_auto_save_eh): Clear it.
5680 (Fdo_auto_save): Catch all errors, not just file errors, so
5681 that the var is always cleared.
5683 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5685 * search.c (scan_buffer): Pass character positions to
5686 know_region_cache, not byte positions. (Bug#6540)
5688 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5690 * w32.c (sys_rename): Report EXDEV when rename of a directory
5691 fails because the target is on another logical disk. (Bug#10284)
5693 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5695 * xterm.c (x_embed_request_focus): New function.
5697 * xterm.h: Add prototype.
5699 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5701 2012-01-05 Glenn Morris <rgm@gnu.org>
5703 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5705 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5707 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5708 Load gnutls_transport_set_lowat only if GnuTLS version is below
5710 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5711 GnuTLS versions below 2.11.1.
5713 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5715 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5716 to the doc string advising against its use for altering the way
5717 windows are scrolled.
5719 2011-12-28 Kenichi Handa <handa@m17n.org>
5721 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5722 coding-system ASCII compatible only when it does not produce BOM
5723 on encoding (Bug#10383).
5725 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5727 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5729 (create_and_show_popup_menu): Always use menu_position_func for
5732 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5734 * callint.c (Fcall_interactively): Don't truncate prompt string.
5736 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5738 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5739 property that ends at ZV, so that the bidi iteration could be
5740 resumed from there (after widening). (Bug#10360)
5742 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5744 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5746 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5748 * nsterm.m (x_free_frame_resources):
5749 Release f->output_data.ns->miniimage.
5750 (ns_index_color): Fix indentation. Do not retain
5751 color_table->colors[i].
5753 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5756 * nsfns.m (x_set_background_color): Assign return value from
5757 ns_index_color to face-background instead of NSColor*.
5758 (ns_implicitly_set_icon_type): Fix indentation.
5759 Change assignment in for loop to comparison.
5761 * emacs.c (ns_pool): New variable.
5762 (main): Assign ns_pool.
5763 (Fkill_emacs): Call ns_release_autorelease_pool.
5765 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5766 autorelease fdesc, release fdAttrs and tdict.
5767 (ns_get_covering_families): Release charset.
5768 (ns_findfonts): Release NSFontDescriptor created with new.
5769 (ns_uni_to_glyphs): Fix indentation.
5770 (setString): Release attrStr before assigning new value.
5772 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5774 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5776 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5777 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5779 2011-12-18 David Reitter <reitter@cmu.edu>
5781 * nsterm.m (ns_term_init): Subscribe for notifications
5782 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5783 to method trackingNotification in EmacsMenu.
5785 * nsmenu.m (trackingMenu): New variable.
5786 (trackingNotification): New method (from Aquamacs).
5787 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5788 from Aquamacs (Bug#7030).
5790 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5792 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5793 (symbol_to_nsstring): Fix indentation.
5794 (ns_symbol_to_pb): New function.
5795 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5796 (Fns_rotate_cut_buffers_internal): Remove.
5797 (Fns_store_selection_internal): Rename from
5798 Fns_store_cut_buffer_internal.
5799 (ns_get_foreign_selection, Fx_own_selection_internal)
5800 (Fx_disown_selection_internal, Fx_selection_exists_p)
5801 (Fns_get_selection_internal, Fns_store_selection_internal):
5802 Use ns_symbol_to_pb and check if return value is nil.
5803 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5804 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5805 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5806 renamed to Sns_store_selection_internal.
5807 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5808 and remove this function.
5809 (ns_handle_selection_clear): Remove, never used.
5810 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5813 2011-12-17 Ken Brown <kbrown@cornell.edu>
5815 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5816 GID is unknown (Bug#10257).
5818 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5820 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5821 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5822 which caused a build failure on GNU/Linux IA-64. This problem was
5823 introduced by my 2011-10-07 patch.
5825 2011-12-15 Juri Linkov <juri@jurta.org>
5827 * image.c (imagemagick_error): New function. (Bug#10112)
5828 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5829 Use `imagemagick_error' where ImageMagick functions return
5831 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5834 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5836 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5837 fill background (Bug#8992).
5839 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5841 * window.c (Vwindow_combination_resize)
5842 (Vwindow_combination_limit): Use t instead of non-nil in
5844 (Vrecenter_redisplay): Add first sentence of doc-string on
5846 (Frecenter): Fix doc-string typo.
5848 2011-12-11 Kenichi Handa <handa@m17n.org>
5850 * coding.c (Funencodable_char_position): Pay attention to the
5851 buffer text relocation (Bug#9389).
5853 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5855 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5856 gtk_init (Bug#10100).
5858 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5860 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5861 IT->string is nil. (Bug#10263)
5863 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5865 * nsterm.h (x_free_frame_resources): Declare.
5867 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5868 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5870 * nsterm.h (ns_get_defaults_value): Declare.
5872 * nsterm.m (ns_default): Call ns_get_defaults_value.
5874 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5876 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5879 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5881 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5882 that where the value of an _OBJC_* symbol points to is in the .bss
5883 section (Bug#10240).
5885 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5887 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5888 after the loop to call ccl_driver at least once (Bug#8619).
5890 2011-12-08 Kenichi Handa <handa@m17n.org>
5892 * ftfont.c (get_adstyle_property): Fix previous change
5895 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5897 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5898 dirs from the default value of EMACSLOADPATH (bug#10208).
5900 2011-12-07 Glenn Morris <rgm@gnu.org>
5902 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5903 installation and source directories as well. (Bug#10208)
5905 2011-12-06 Chong Yidong <cyd@gnu.org>
5907 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5909 2011-12-06 Glenn Morris <rgm@gnu.org>
5911 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5912 as an error, not just -1. (Bug#10217)
5914 2011-12-05 Chong Yidong <cyd@gnu.org>
5916 * keyboard.c (process_special_events): New function.
5917 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5919 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5921 * coding.c (encode_designation_at_bol): Don't use uninitialized
5922 local variable (Bug#9318).
5924 2011-12-05 Kenichi Handa <handa@m17n.org>
5926 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5927 return Qnil (Bug#8046, Bug#10193).
5929 2011-12-05 Kenichi Handa <handa@m17n.org>
5931 * coding.c (encode_designation_at_bol): New args charbuf_end and
5932 dst. Return the number of produced bytes. Callers changed.
5933 (coding_set_source): Return how many bytes coding->source was
5935 (coding_set_destination): Return how many bytes
5936 coding->destination was relocated.
5937 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5938 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5940 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5942 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5943 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5946 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5948 The following changes are to fix Bug#9318.
5950 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5951 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5952 (encode_coding_iso_2022, encode_coding_sjis)
5953 (encode_coding_big5, encode_coding_charset): Use the above macros.
5955 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5957 * lisp.h (process_quit_flag): Fix external declaration.
5959 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5961 Don't macro-inline non-performance-critical code.
5962 * eval.c (process_quit_flag): New function.
5963 * lisp.h (QUIT): Use it.
5965 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5967 * nsfns.m (get_geometry_from_preferences): New function.
5968 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5970 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5972 * emacs.c (Qkill_emacs): Define.
5973 (syms_of_emacs): Initialize it.
5974 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5975 Qquit_flag to `kill-emacs' instead.
5976 (quit_throw_to_read_char): Add parameter `from_signal'.
5977 All callers changed. Call Fkill_emacs if requested and safe.
5978 * lisp.h (QUIT): Call Fkill_emacs if requested.
5980 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5982 * widget.c (update_wm_hints): Return if wmshell is null.
5983 (widget_update_wm_size_hints): New function.
5985 * widget.h (widget_update_wm_size_hints): Declare.
5987 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5988 widget_update_wm_size_hints (Bug#10104).
5990 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5992 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5993 before a newline, prepare the bidi iterator for consuming the
5994 newline, and keep the current paragraph direction. (Bug#10183)
5995 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5997 2011-12-02 Juri Linkov <juri@jurta.org>
5999 * search.c (Fword_search_regexp): New Lisp function created from
6000 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6001 (Fword_search_backward, Fword_search_forward)
6002 (Fword_search_backward_lax, Fword_search_forward_lax):
6003 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6004 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6006 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6008 * fileio.c (Finsert_file_contents): Move after-change-function call
6009 to before the "handled:" label, since all "goto handled" appear in
6010 cases where the *-change-functions have already been properly called
6013 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6015 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6016 waiting for input. (Bug#10169)
6018 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6020 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6021 verifies glyph row's hash code--we have just reallocated the
6022 glyphs, so their contents can be complete garbage. (Bug#10164)
6024 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
6026 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6028 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6030 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6031 attributes are tested _before_ calling verify_row_hash, to protect
6032 against GCC re-ordering of the tests. (Bug#10164)
6034 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6036 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6038 * xterm.c (handle_one_xevent): Only set async_visible and friends
6039 if net_wm_state_hidden_seen is non-zero (Bug#10002)
6040 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
6041 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6043 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6045 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6046 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6047 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6048 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6049 All uses changed to use GCPRO1 etc.
6050 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6051 Revert to old implementation (i.e., before 2011-03-11).
6053 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6055 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6056 of scroll runs so as to avoid assigning disabled bogus rows and
6057 unnecessary graphics copy operations.
6059 2011-11-27 Eli Zaretskii <eliz@gnu.org>
6061 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6062 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6063 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6064 (malloc, free, realloc, calloc): Redirect to e_* only when
6067 * lisp.h (GCTYPEBITS): Move before first use.
6068 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6069 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6070 this macro definition.
6072 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6075 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6077 * gtkutil.c (xg_create_frame_widgets):
6078 Call gtk_window_set_has_resize_grip (FALSE) if that function is
6079 present with Gtk+ 2.0.
6081 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6083 * fileio.c (Finsert_file_contents): Undo previous change; see
6084 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6086 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6088 Rename locals to avoid shadowing.
6089 * fileio.c (Finsert_file_contents):
6090 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6091 * process.c (wait_reading_process_output):
6092 Rename inner 'proc' to 'p' to avoid shadowing.
6093 Indent for consistency with usual Emacs style.
6095 2011-11-25 Eli Zaretskii <eliz@gnu.org>
6097 * xdisp.c (redisplay_window): If cursor row is not fully visible
6098 after recentering, and scroll-conservatively is set to a large
6099 number, scroll window by a few more lines to make the cursor fully
6100 visible and out of scroll-margin. (Bug#10105)
6101 (start_display): Don't move to the next line if the display should
6102 start at a newline that is part of a display vector or an overlay
6105 2011-11-24 Juri Linkov <juri@jurta.org>
6107 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6108 after the `MagickPingImage' call. (Bug#10112)
6110 2011-11-23 Chong Yidong <cyd@gnu.org>
6112 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6114 2011-11-23 Martin Rudalics <rudalics@gmx.at>
6116 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6117 making another buffer current. (Bug#10114)
6119 2011-11-23 Glenn Morris <rgm@gnu.org>
6121 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6123 2011-11-23 Chong Yidong <cyd@gnu.org>
6125 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6126 using it (Bug#5984).
6128 2011-11-22 Eli Zaretskii <eliz@gnu.org>
6130 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6131 and header-lines, as they don't have one computed for them.
6134 * .gdbinit (prow): Make displayed values more self-explaining.
6135 Add row's hash code.
6137 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6139 * process.c (wait_reading_process_output): Fix asynchrounous
6140 GnuTLS socket handling on some versions of the GnuTLS library.
6141 (wait_reading_process_output): Add comment and URL.
6143 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6145 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6147 2011-11-21 Chong Yidong <cyd@gnu.org>
6149 * window.c (Fnext_window, Fprevious_window): Doc fix.
6151 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6153 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6155 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6157 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6159 2011-11-20 Martin Rudalics <rudalics@gmx.at>
6161 * window.c (Fset_window_combination_limit): Rename argument
6163 (Vwindow_combination_limit): Remove "status" from doc-string.
6165 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6167 * m/ibms390.h: Remove.
6168 * m/ibms390x.h: Don't include "ibms390.h".
6170 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6172 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6173 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6175 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6177 * casetab.c (Fset_case_table):
6178 * charset.c (Fcharset_after): Fix typos.
6180 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6182 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6183 Otherwise, valgrind does not work on some platforms.
6184 Problem reported by Andreas Schwab in
6185 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6186 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6187 is set, removing the need for VIRT_ADDRESS_VARIES.
6188 (PURE_P): Use a more-efficient implementation that needs just one
6189 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6190 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6191 to 4 (xorl, subq, cmpq, setbe).
6192 * alloc.c (pure): Always extern now, since that's the
6193 VIRT_ADDR_VARIES behavior.
6194 (PURE_POINTER_P): Use a single comparison, not two, for
6195 consistency with the new puresize.h.
6196 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6197 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6198 Remove VIRT_ADDR_VARIES no longer needed.
6200 2011-11-19 Eli Zaretskii <eliz@gnu.org>
6202 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6203 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6204 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6205 behave as if the cursor position were at the window margin.
6207 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6208 and the cursor position is out of bounds, behave as if the cursor
6209 position were at the window margin. (Bug#10075)
6211 2011-11-18 Chong Yidong <cyd@gnu.org>
6213 * window.c (Fwindow_combination_limit): Make first argument
6214 non-optional, since it is meaningless for live windows like the
6217 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6219 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6221 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6223 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6224 (graft_intervals_into_buffer): Simplify.
6226 2011-11-18 Eli Zaretskii <eliz@gnu.org>
6228 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6229 hash values of the two rows.
6230 (copy_row_except_pointers): Preserve the used[] arrays and the
6231 hash values of the two rows. (Bug#10035)
6232 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
6234 * xdisp.c (row_hash): New function, body extracted from
6235 compute_line_metrics.
6236 (compute_line_metrics): Call row_hash, instead of computing the
6239 * dispnew.c (verify_row_hash): Call row_hash for computing the
6240 hash code of a row, instead of duplicating code from xdisp.c.
6242 * dispextern.h (row_hash): Add prototype.
6244 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6246 * frame.c (delete_frame): Don't delete the terminal when the last
6247 X frame is closed if emacs is built with GTK toolkit.
6249 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
6251 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6253 2011-11-17 Martin Rudalics <rudalics@gmx.at>
6255 * window.c (Vwindow_splits): Rename to
6256 Vwindow_combination_resize. Suggested by Juri Linkov.
6257 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6260 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
6262 * nsfns.m (Fns_font_name):
6263 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
6265 2011-11-16 Martin Rudalics <rudalics@gmx.at>
6267 * window.h (window): Rename slot "nest" to "combination_limit".
6268 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6269 (Fset_window_nest): Rename to Fset_window_combination_limit.
6270 (Vwindow_nest): Rename to Vwindow_combination_limit.
6271 (recombine_windows, make_parent_window, make_window)
6272 (Fsplit_window_internal, saved_window)
6273 (Fset_window_configuration, save_window_save): Rename all
6274 occurrences of window_nest to window_combination_limit.
6276 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
6278 * image.c (imagemagick_load_image): Fix typo.
6280 2011-11-14 Eli Zaretskii <eliz@gnu.org>
6282 * xdisp.c (display_line): Move the call to
6283 highlight_trailing_whitespace before the call to
6284 compute_line_metrics, since the latter needs to see the final
6285 faces of all the glyphs to compute ROW's hash value.
6286 Fixes assertion violations in row_equal_p. (Bug#10035)
6288 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6290 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6291 just return (bug#10044).
6293 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6295 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6296 with user-defined heap size. Bump the default size of the temacs
6297 heap to 27MB, to avoid memory warning when running temacs.
6298 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6300 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6301 current_matrix and desired_matrix. (Bug#9990)
6302 (verify_row_hash) [XASSERTS]: New function.
6303 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6304 that the hash value of glyph rows is correct.
6306 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6308 * window.h (window): Remove splits slot.
6309 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6310 (Fdelete_other_windows_internal, make_parent_window)
6311 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6312 (Fset_window_configuration, save_window_save): Don't deal with
6313 split status of windows.
6314 (saved_window): Remove splits slot.
6315 (Vwindow_splits): Rewrite doc-string.
6317 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6319 * xfns.c (unwind_create_frame):
6320 * nsfns.m (unwind_create_frame):
6321 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6322 Vframe_list (Bug#9999).
6324 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6326 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6328 2011-11-11 Kenichi Handa <handa@m17n.org>
6330 * callproc.c (Fcall_process): Set the member dst_multibyte of
6333 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6335 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6336 avoid a crash (bug#9496).
6338 2011-11-09 Chong Yidong <cyd@gnu.org>
6340 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6341 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6343 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6345 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6347 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6349 Avoid some portability problems by eschewing 'extern inline' functions.
6350 The trivial performance wins aren't worth the portability hassles; see
6351 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6353 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6354 (window_box_width, window_box_left, window_box_left_offset)
6355 (window_box_right, window_box_right_offset): Undo previous change,
6356 by removing the "extern"s.
6357 * intervals.c (adjust_intervals_for_insertion)
6358 (adjust_intervals_for_deletion): Undo previous change,
6359 making these static again.
6360 (offset_intervals, temp_set_point_both, temp_set_point)
6361 (copy_intervals_to_string): No longer inline.
6362 * xdisp.c (window_text_bottom_y, window_box_width)
6363 (window_box_height, window_box_left_offset)
6364 (window_box_right_offset, window_box_left, window_box_right)
6365 (window_box): No longer inline.
6367 2011-11-08 Chong Yidong <cyd@gnu.org>
6369 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6370 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6371 Signal an error if not a live window.
6372 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6373 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6375 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6377 * lisp.h (syms_of_abbrev): Remove declaration.
6378 Reported by CHENG Gao <chenggao@royau.me>.
6380 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6382 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6383 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6384 of temacs in GUI mode.
6386 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6388 * window.h: Declare delete_all_child_windows instead of
6389 delete_all_subwindows.
6390 * window.c (Fwindow_nest, Fset_window_nest)
6391 (Fset_window_new_total, Fset_window_new_normal)
6392 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6393 (delete_all_subwindows): Rename to delete_all_child_windows.
6394 (Fdelete_other_windows_internal, Fset_window_configuration):
6395 Call delete_all_child_windows instead of delete_all_subwindows.
6396 * frame.c (delete_frame): Call delete_all_child_windows instead
6397 of delete_all_subwindows.
6399 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6401 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6402 This is also needed for porting to any host where GC_MARK_STACK is
6403 not GC_MAKE_GCPROS_NOOPS.
6404 (which_symbols): Use it.
6406 2011-11-07 Kenichi Handa <handa@m17n.org>
6408 * coding.c (coding_set_destination): Check coding->src_pos only
6409 when coding->src_object is a buffer (bug#9910).
6411 * process.c (send_process): Set the member src_multibyte of coding
6412 to 0 (bug#9911) when sending a unibyte text.
6414 * callproc.c (Fcall_process): Set the member src_multibyte of
6415 process_coding to 0 (bug#9912).
6417 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6419 * xmenu.c (cleanup_widget_value_tree): New function.
6420 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6421 calling free_menubar_widget_value_tree directly (Bug#9830).
6423 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6425 Fix some portability problems with 'inline'.
6426 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6427 (window_box_width, window_box_left, window_box_left_offset)
6428 (window_box_right, window_box_right_offset): Declare extern.
6429 Otherwise, these inline functions do not conform to C99 and
6430 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6431 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6432 * intervals.c (adjust_intervals_for_insertion)
6433 (adjust_intervals_for_deletion): Now extern, because otherwise the
6434 extern inline functions 'offset_intervals' couldn't refer to it.
6435 (static_offset_intervals): Remove.
6436 (offset_intervals): Rewrite using the old contents of
6437 static_offset_intervals. The old version didn't conform to C99
6438 because an extern inline function contained a reference to an
6439 identifier with static linkage.
6441 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6443 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6446 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6448 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6449 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6450 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6451 return Qleft_to_right.
6453 2011-11-06 Chong Yidong <cyd@gnu.org>
6455 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6456 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6457 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6458 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6459 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6460 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6461 (Fwindow_vscroll): Doc fix.
6462 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6463 argument, since it makes no sense to pass a live window and for
6464 consistency with window-child.
6466 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6468 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6471 2011-11-05 Jason Rumney <jasonr@gnu.org>
6473 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6474 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6476 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6477 bitwise arithmetic preventing use of unicode-sip and non-truetype
6480 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6482 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6485 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6486 initialization code to keep similarity to xfns.c after changes
6489 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6491 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6492 (unwind_create_frame): New function (Bug#9943).
6493 (Fx_create_frame): Restructure code to be more similar to the one in
6494 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6495 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6496 Move terminal->reference_count++ just before making the frame official
6499 * nsterm.m (x_free_frame_resources): New function.
6500 (x_destroy_window): Move code to x_free_frame_resources.
6502 * xfns.c (unwind_create_frame): Fix comment.
6503 (Fx_create_frame, x_create_tip_frame):
6504 Move terminal->reference_count++ just before making the frame
6505 official. Move initialization of image_cache_refcount and
6506 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6508 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6510 Support MSVC build with newer versions of Visual Studio.
6511 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6512 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6515 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6516 which are not supported by MSVC.
6517 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6518 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6520 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6522 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6524 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6526 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6528 Support MSVC build with newer versions of Visual Studio.
6529 * w32.c: Don't include w32api.h for MSVC.
6530 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6532 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6533 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6534 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6535 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6537 (alloca) [_MSC_VER]: Define to _alloca.
6539 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6541 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6543 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6545 * xdisp.c (note_mouse_highlight): If either of
6546 previous/next-single-property-change returns nil, treat that as
6547 the beginning or the end of the buffer. (Bug#9955)
6549 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6551 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6552 label is not null (Bug#9951).
6553 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6556 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6558 * window.c (Fwindow_body_size): Mention in the doc string that the
6559 return value is in frame's canonical units. (Bug#9949)
6561 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6563 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6565 * w32fns.c (unwind_create_frame): If needed, free the glyph
6566 matrices of the partially constructed frame. (Bug#9943)
6567 * xfns.c (unwind_create_frame): Likewise.
6569 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6571 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6572 Don't stop backward scan on the continuation glyph, even though
6573 its CHARPOS is positive.
6574 (mouse_face_from_buffer_pos, note_mouse_highlight):
6575 Rename cover_string to disp_string.
6577 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6579 * window.c (temp_output_buffer_show): Don't use
6580 Vtemp_buffer_show_specifiers.
6581 (Vtemp_buffer_show_specifiers): Remove unused variable.
6583 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6585 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6586 past the beginning of the current glyph matrix.
6588 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6590 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6591 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6592 HAVE_GTK3 (Bug#9869).
6594 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6595 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6597 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6599 * xterm.c: Declare x_handle_net_wm_state to return int.
6600 (handle_one_xevent): Check if we are iconified but don't have
6601 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6602 (get_current_wm_state): Return non-zero if not hidden,
6603 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6604 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6605 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6606 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6608 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6610 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6611 so that this new function doesn't get optimized away by a
6612 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6614 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6616 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6618 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6620 Fix the `xbytecode' command.
6621 * .gdbinit (xprintbytestr): New command.
6622 (xwhichsymbols): Rename from `which'; all callers changed.
6623 (xbytecode): Print the byte-code string as well.
6625 2011-10-29 Kim Storm <storm@cua.dk>
6627 * alloc.c (which_symbols): New function.
6629 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6631 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6634 2011-10-29 Glenn Morris <rgm@gnu.org>
6636 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6637 Not clear what it was for, and it causes various bugs. (Bug#9839)
6639 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6641 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6642 possible random value that matches one of those tested as
6643 condition to clear the mouse face.
6645 2011-10-28 Chong Yidong <cyd@gnu.org>
6647 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6649 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6651 * window.c (make_window): Initialize phys_cursor_on_p.
6653 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6655 * lisp.h (struct Lisp_Symbol): Update comments.
6657 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6659 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6661 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6663 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6664 <oslsachem@gmail.com> for helping to debug this.
6666 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6667 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6668 (g_b_init_get_glyph_outline_w): New static variables.
6669 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6670 (GetGlyphOutlineW_Proc): New typedefs.
6671 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6672 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6674 (w32font_open_internal, compute_metrics):
6675 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6676 instead of calling the "wide" APIs directly.
6678 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6680 * w32.h (syms_of_w32font): Add prototype.
6682 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6684 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6685 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6686 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6687 (Fmove_to_window_line): Doc fix.
6689 2011-10-27 Chong Yidong <cyd@gnu.org>
6691 * process.c (make_process): Set gnutls_state to NULL.
6693 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6694 non-NULL, regardless of GNUTLS_INITSTAGE.
6695 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6696 an error. Set process slots as soon as we allocate them.
6698 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6700 2011-10-27 Chong Yidong <cyd@gnu.org>
6702 * gnutls.c (emacs_gnutls_deinit): New function.
6703 Deallocate credentials structures as well as calling gnutls_deinit.
6704 (Fgnutls_deinit, Fgnutls_boot): Use it.
6706 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6707 (deactivate_process): Call emacs_gnutls_deinit.
6709 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6711 * image.c (x_create_x_image_and_pixmap):
6712 * w32.c (sys_rename, w32_delayed_load):
6713 * w32font.c (fill_in_logfont):
6714 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6716 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6718 * w32fns.c (w32_default_color_map): New function,
6719 extracted from Fw32_default_color_map.
6720 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6722 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6724 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6726 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6728 * keyboard.c (test_undefined): New function (bug#9751).
6729 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6731 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6733 * sysdep.c (init_sys_modes): Fix the check for the controlling
6734 terminal (Bug#6649).
6736 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6738 * dispextern.h (struct bidi_it): New member next_en_type.
6740 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6741 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6742 current character, check also for next_en_type being WEAK_EN.
6743 (bidi_resolve_weak): Don't enter the expensive loop if the current
6744 position is before next_en_pos. Record the bidi type of the first
6745 non-ET, non-BN character we find, in addition to its position.
6746 (bidi_level_of_next_char): Invalidate next_en_type when
6747 next_en_pos is over-stepped.
6749 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6751 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6752 * editfns.c: Rewrite current-time-zone so that it invokes
6753 the equivalent of (format-time-string "%Z") to get the time zone name.
6754 This fixes a bug when the time zone name contains characters that
6755 need converting from the system time locale to Emacs internal format.
6756 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6757 that patch fixed format-time-string to do the conversion, but
6758 I forgot to fix current-time-zone.
6759 (format_time_string): New function, containing most of
6760 what Fformat_time_string used to contain.
6761 (Fformat_time_string): Rewrite in terms of format_time_string.
6762 This doesn't change this function's behavior.
6763 (current-time-zone): Rewrite to use format_time_string.
6764 This fixes the bug reported by Michael Schierl in
6765 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6766 Jason Rumney's 2007-06-07 change worked around this bug, but
6768 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6770 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6772 * xdisp.c (start_display): If the character at POS is displayed
6773 via a display vector, reset IT->current.dpvec_index to zero.
6774 (try_window_reusing_current_matrix): If a line ends in a display
6775 vector or the next line starts in a display vector, continue
6776 redrawing the window even though the character position of
6777 start_row was reached.
6780 2011-10-18 Chong Yidong <cyd@gnu.org>
6782 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6783 with nobreak-char-display too.
6785 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6787 Fix part 3 of bug#9771.
6788 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6789 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6790 non-neutral characters if the current character is a paragraph
6791 separator (a.k.a. Newline). This avoids running the same
6792 expensive loop twice, once when we consume the preceding newline
6793 and the other time when the line actually needs to be displayed.
6794 Avoid the loop when we see neutrals on the base embedding level
6795 following a character whose directionality is the same as the
6796 paragraph's. This avoids running the expensive loop when a line
6797 ends in a long sequence of neutrals, like control characters.
6798 Add assertion against STRONG_AL type. Slightly rearrange code
6799 that determines the type of a neutral given the first non-neutral
6801 (bidi_level_of_next_char): Set next_en_pos to zero when
6802 invalidating its info.
6804 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6806 * xdisp.c (push_display_prop): Determine whether to record string
6807 or buffer position by IT->string, not by IT->method. Allow
6808 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6809 (move_it_vertically_backward): Don't look for character position
6810 immediately after the newline when in a continuation line.
6813 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6815 * window.c (coordinates_in_window): Rewrite and delabelize
6816 vertical border check. (Bug#5357) (Bug#9618)
6818 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6820 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6821 errors in XSetWindowBorder (bug#9310).
6823 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6825 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6826 avoid crash when xmalloc overrun checking is enabled.
6828 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6830 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6831 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6832 cursor motion with <left> and <right> arrow keys.
6834 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6835 some callers set that themselves.
6837 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6839 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6840 display string and the previous row comes from the same string and
6841 is empty. (Bug#9739) (Bug#9738)
6843 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6845 * doc.c (get_doc_string): Encode file name (bug#9735).
6847 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6849 * bidi.c (bidi_level_of_next_char):
6850 * xdisp.c (get_visually_first_element): Remove old incorrect
6851 comments regarding the Unicode Line Separator character.
6853 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6855 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6857 * alloc.c (Fgc_status): Do not access beyond zombies array
6858 boundary if nzombies > MAX_ZOMBIES.
6859 * alloc.c (dump_zombies): Add missing format specifier.
6861 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6863 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6864 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6866 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6867 Some packages use them to denote characters with modifiers.
6869 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6871 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6872 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6873 matching a pp-number. Rename parameter var to var1.
6875 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6877 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6879 2011-10-08 Glenn Morris <rgm@gnu.org>
6881 * callint.c (Fcall_interactively): Give a more explicit error for the
6882 'c' case with a non-character input. (Bug#8479)
6884 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6886 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6888 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6889 lines that are hscrolled on the left.
6891 * dispnew.c (buffer_posn_from_coords): Account for a possible
6892 presence of header-line. (Bug#4426)
6894 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6896 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6897 Don't advertise functionality which we discourage or doesn't work.
6899 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6901 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6902 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6903 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6904 this makes Emacs dump core during garbage collection on rare
6905 occasions. sizeof is obviously inferior to offsetof here, so
6906 stick with offsetof.
6907 (GC_POINTER_ALIGNMENT): New macro.
6908 (mark_memory): Omit 3rd (offset) arg; caller changed.
6909 Don't assume EMACS_INT alignment is the same as pointer alignment.
6911 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6913 * keyboard.c (read_key_sequence_remapped): New var.
6914 (read_key_sequence): Compute remapping in the right buffer.
6915 (command_loop_1): Use read_key_sequence's remapping directly.
6917 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6919 * dired.c (file_name_completion): Don't expand file name.
6920 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6921 before checking file name handler.
6923 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6924 they've been requested explicitly (bug#9591).
6926 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6928 * keymap.c (Fsingle_key_description): Use make_specified_string
6929 instead of build_string to build string from push_key_description.
6932 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6934 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6935 This fixes a Y2038 bug on 64-bit hosts.
6936 * buffer.c (reset_buffer):
6937 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6938 (Fclear_buffer_auto_save_failure):
6939 Use 0, not -1, to represent an unset failure time, since time_t
6940 might not be signed.
6942 Remove dependency on glibc malloc internals.
6943 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6944 Move back here from lisp.h, but with their new implementations.
6945 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6946 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6947 * charset.c (charset_table_init): New static var.
6948 (syms_of_charset): Use it instead of xmalloc. This removes a
6949 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6950 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6951 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6952 Move back to alloc.c.
6953 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6954 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6956 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6958 * nsterm.m (windowDidResize): Call x_set_window_size only when
6959 ns_in_resize is true. Otherwise set pixelwidth/height and
6960 call change_frame_size (Bug#9628).
6962 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6964 Port --enable-checking=all to Fedora 14 x86-64.
6965 * charset.c (syms_of_charset): Also account for glibc malloc's
6966 internal overhead when calculating the initial malloc maximum.
6968 Port --enable-checking=all to Fedora 14 x86.
6969 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6971 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6972 (overrun_check_realloc, overrun_check_free):
6973 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6974 That way, xmalloc returns a properly-aligned pointer even if
6975 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6976 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6977 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6978 into account when calculating the initial malloc maximum.
6979 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6980 Move here from alloc.c, so that charset.c can use it too.
6981 Properly align; the old code wasn't right for common 32-bit hosts
6982 when configured with --enable-checking=all.
6983 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6984 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6986 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6988 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6991 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6993 * xdisp.c (compute_display_string_end): If there's no display
6994 string at CHARPOS, return -1.
6996 * bidi.c (bidi_fetch_char): When compute_display_string_end
6997 returns a negative value, treat the character as a normal
6998 character not covered by a display string. (Bug#9624)
7000 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
7002 * lread.c (Fread_from_string): Fix typo in docstring.
7004 2011-09-27 Eli Zaretskii <eliz@gnu.org>
7006 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7007 newline, reseat the iterator instead of bidi-iterating there one
7008 character at a time. (Bug#9610)
7009 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7010 TO_CHARPOS if the bidi iterator is at base embedding level.
7012 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7014 * lread.c (readevalloop): Use correct code for NBSP.
7015 (read1): Likewise. (Bug#9608)
7017 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
7019 * dbusbind.c (Fdbus_register_signal): When service is not
7020 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7022 2011-09-25 Glenn Morris <rgm@gnu.org>
7024 * buffer.c (truncate-lines): Doc fix.
7026 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
7028 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7029 (Fset_window_next_buffers): Doc fix.
7031 2011-09-24 Glenn Morris <rgm@gnu.org>
7033 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7035 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7037 Fix minor problems found by static checking.
7038 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
7039 * indent.c (Fvertical_motion): Fix == vs = typo.
7041 2011-09-24 Eli Zaretskii <eliz@gnu.org>
7043 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7044 Default value is now t. Doc fix.
7046 * indent.c (Fvertical_motion): Compute and apply the overshoot
7047 logic when moving up, not only when moving down. Fix the
7048 confusing name and values of the it_overshoot_expected variable;
7049 logic changes accordingly. (Bug#9254) (Bug#9549)
7051 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7052 CHARPOS is covered by a display string which includes newlines.
7053 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7054 is covered by a display string with embedded newlines.
7056 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
7058 * dbusbind.c (Fdbus_register_signal): Add match rule to
7059 Vdbus_registered_objects_table. (Bug#9581)
7060 (Fdbus_register_method, Vdbus_registered_objects_table):
7063 2011-09-24 Jim Meyering <meyering@redhat.com>
7065 do not ignore write error for any output size
7066 The previous change was incomplete.
7067 While it makes emacs --batch detect the vast majority of stdout
7068 write failures, errors were still ignored whenever the output size is
7069 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7070 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7071 && echo FAIL: ignored write error
7072 FAIL: ignored write error
7073 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7074 && echo FAIL: ignored write error
7075 FAIL: ignored write error
7076 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7078 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7080 * emacs.c (Fkill_emacs): In noninteractive mode exit
7081 non-successfully if a write error occurred on stdout. (Bug#9574)
7083 2011-09-21 Eli Zaretskii <eliz@gnu.org>
7085 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7088 * dispextern.h (struct it): Update the comment documenting what
7091 2011-09-20 Eli Zaretskii <eliz@gnu.org>
7093 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7094 a display string, extend search for cursor position to end of row.
7095 (find_row_edges): If the row ends in a newline from a display
7096 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7097 Handle the case of a display string with multiple newlines.
7098 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7099 non-empty line. Fixes confusing cursor motion with arrow keys at
7100 the beginning of a line that starts with whitespace.
7102 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7104 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7107 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
7109 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7112 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7114 * xdisp.c (display_line): Record maximum and minimum buffer
7115 positions even if no glyphs were produced (e.g., by a zero-width
7116 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7117 buffer positions that will be removed from the glyph row because
7119 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7120 column is beyond frame width: don't subtract 1 "pixel" when
7121 computing width of the stretch.
7122 (reseat_at_next_visible_line_start): Undo the change made on
7123 2011-09-17 that saved paragraph information and restored it after
7124 the call to `reseat'. (Bug#9545)
7126 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7128 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7129 and turn window cursor on if cleared (Bug#9415).
7131 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
7133 * search.c (boyer_moore): Take unibyte characters from pattern
7134 literally. (Bug#9458)
7136 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7138 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7140 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7142 Fix minor problem found by static checking.
7143 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7144 initialized, to pacify gcc -Wuninitialized.
7146 * fileio.c: Report proper errno when syscall falls.
7147 (Finsert_file_contents): Save and restore errno,
7148 so that report_file_error outputs the correct diagnostic.
7149 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7151 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7153 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7155 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7157 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7158 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7160 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7162 * xdisp.c (reseat_at_next_visible_line_start): Keep information
7163 about the current paragraph and restore it after the call to reseat.
7165 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7166 (bidi_find_paragraph_start): Search back for paragraph beginning
7167 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7168 (bidi_move_to_visually_next): Only trigger paragraph-related
7169 computations when the last character is a newline or at EOB, not
7170 just any NEUTRAL_B. (Bug#9470)
7172 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7173 truncated lines if point is covered by a display string. (Bug#9524)
7175 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7177 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7178 (cons_to_x_long): New function.
7179 (lisp_data_to_selection_data): Use it. Correct the test for
7180 short-versus-long data; it was negated. Break out of vector
7181 loop, for efficiency, when a long datum is discovered.
7183 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7185 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7187 2011-09-16 Eli Zaretskii <eliz@gnu.org>
7189 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7190 GCC PR/17406) by declaring this function with external scope.
7192 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7194 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7195 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7197 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7199 * editfns.c (Fformat): Correctly handle text properties on "%%".
7201 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7203 * xterm.c (x_draw_composite_glyph_string_foreground):
7204 * w32term.c (x_draw_composite_glyph_string_foreground):
7205 * term.c (encode_terminal_code):
7206 * composite.c (composition_update_it, get_composition_id):
7207 * xdisp.c (get_next_display_element)
7208 (fill_composite_glyph_string): Add comments about special meaning
7209 of TAB characters in a composition.
7211 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7213 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
7214 This occurs when processing a multibyte format.
7215 Problem reported by Wolfgang Jenker.
7217 2011-09-15 Johan Bockgård <bojohan@gnu.org>
7219 * xdisp.c (try_cursor_movement): Only check for exact match if
7220 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7222 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7224 Remove unused external symbols.
7225 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7226 * xdisp.c (calc_pixel_width_or_height): Now static.
7227 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7228 * indent.c (check_display_width):
7229 * w32term.c: Fix comment to match code.
7230 * xterm.c, xterm.h (x_catching_errors): Remove.
7232 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7234 * xselect.c: Use signed conversions more consistently (Bug#9498).
7235 (selection_data_to_lisp_data): Assume incoming selection data are
7236 signed integers, not unsigned. This is to be consistent with
7237 outgoing selection data, which was modified to use signed integers
7238 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7239 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7240 expects long, not unsigned long.
7242 2011-09-14 Eli Zaretskii <eliz@gnu.org>
7244 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7245 computation of loop end. Reported by Johan Bockgård
7248 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
7250 * frame.c (Fother_visible_frames_p): Function deleted.
7252 2011-09-12 Eli Zaretskii <eliz@gnu.org>
7254 * indent.c (compute_motion): Process display vector front to back
7255 rather than the other way around. (Bug#2496)
7257 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7259 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7261 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
7263 * minibuf.c (Fread_from_minibuffer): Doc fix.
7265 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7267 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7268 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7270 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7272 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7273 value for non-existent files.
7275 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7277 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7278 set its "size" to -1. This will set the modtime_size field of
7279 the corresponding buffer to -1, which is what
7280 verify-visited-file-modtime expects for files that do not exist.
7283 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7285 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7287 * lisp.h: ... from here. push_key_description is no longer
7288 defined in keyboard.c, so its declaration should not be in
7289 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7290 logically belongs with push_key_description.
7292 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7294 * buffer.h: Include <sys/types.h> instead of <time.h>.
7295 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7296 Problem reported by Herbert J. Skuhra.
7298 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7300 * xml.c (parse_region): Make the parsing work for
7301 non-comment-starting XML files again (bug#9144).
7303 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7305 * image.c (gif_load): Fix calculation of bottom and right corner.
7308 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7310 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7311 redisplay in small windows.
7313 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7315 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7317 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7319 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7320 Operate on live windows only.
7322 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7324 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7326 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7328 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7329 only under bidi iteration.
7331 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7333 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7335 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7337 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7338 Without this fix, the command to link temacs failed due to an
7339 undefined symbol __builtin_isnan. This is because
7340 /usr/include/iso/math_c99.h #defines isnan(x) to
7341 __builtin_isnan(x), but the bundled gcc, which identifies itself
7342 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7344 * floatfns.c (isnan): #undef, and then #define to a clone of
7346 (Fisnan): Always define, since it's always available now.
7347 (syms_of_floatfns): Always define isnan at the Lisp level.
7349 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7351 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7353 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7355 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7356 The previous code assumed that file offsets (off_t values) fit in
7357 EMACS_INT variables, which is not true on typical 32-bit hosts.
7358 The code messed up by falsely reporting buffer overflow in cases
7359 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7360 when "big" contains more than 2**29 bytes, even though this
7361 inserts just one byte and does not overflow the buffer.
7362 (Finsert_file_contents): Store file offsets as off_t
7363 values, not as EMACS_INT values. Check for overflow when
7364 converting between EMACS_INT and off_t. When checking for
7365 buffer overflow or for overlap, take the offsets into account.
7366 Don't use EMACS_INT for small values where int suffices.
7367 When checking for overlap, fix a typo: ZV was used where
7368 ZV_BYTE was intended.
7369 (Fwrite_region): Don't assume off_t fits into 'long'.
7370 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7372 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7374 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7376 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7378 sprintf-related integer and memory overflow issues (Bug#9412).
7380 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7381 (esprintf, exprintf, evxprintf): New functions.
7382 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7383 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7384 (modify_event_symbol): Do not assume that the length of
7385 name_alist_or_stem is safe to alloca and fits in int.
7386 (Fexecute_extended_command): Likewise for function name and binding.
7387 (Frecursion_depth): Wrap around reliably on integer overflow.
7388 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7389 since some callers pass EMACS_INT values.
7390 (Fsingle_key_description): Don't crash if symbol name contains more
7391 than MAX_ALLOCA bytes.
7392 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7393 (get_minibuffer): Arg is now EMACS_INT, not int.
7394 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7395 (esprintf, exprintf, evxprintf): New decls.
7396 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7398 * dbusbind.c (signature_cat): New function.
7399 (xd_signature, Fdbus_register_signal):
7400 Do not overrun buffer; instead, report string overflow.
7402 * dispnew.c (add_window_display_history): Don't overrun buffer.
7403 Truncate instead; this is OK since it's just a log.
7405 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7406 even if the time zone offset is outlandishly large.
7407 Don't mishandle offset == INT_MIN.
7409 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7410 when creating daemon; the previous buffer-overflow check was incorrect.
7412 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7413 which has the guts of the old verror function.
7415 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7416 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7418 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7419 (font_unparse_xlfd): Don't blindly alloca long strings.
7420 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7421 fits in int, when using sprintf. Use single snprintf to count
7422 length of string rather than counting it via multiple sprintfs;
7423 that's simpler and more reliable.
7424 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7425 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7426 sprintf, in case result does not fit in int.
7428 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7429 (fontset_from_font): Print it.
7431 * frame.c (tty_frame_count): Now printmax_t, not int.
7432 (make_terminal_frame, set_term_frame_name): Print it.
7433 (x_report_frame_params): In X, window IDs are unsigned long,
7434 not signed long, so print them as unsigned.
7435 (validate_x_resource_name): Check for implausibly long names,
7436 and don't assume name length fits in 'int'.
7437 (x_get_resource_string): Don't blindly alloca invocation name;
7438 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7441 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7442 (xg_check_special_colors, xg_set_geometry):
7443 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7445 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7446 Use esprintf, not sprintf, in case result does not fit in int.
7448 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7449 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7450 it as a large positive number.
7451 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7452 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7454 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7455 in case result does not fit in int.
7457 * print.c (float_to_string): Detect width overflow more reliably.
7458 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7459 buffer overrun. Don't assume list length fits in 'int'. Treat
7460 print length of 0 as 0, not as infinity; to be consistent with other
7461 uses of print length in this function. Don't overflow print length
7462 index. Don't assume hash table size fits in 'long', or that
7463 vectorlike size fits in 'unsigned long'.
7465 * process.c (make_process): Use printmax_t, not int, to format
7466 process-name gensyms.
7468 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7470 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7471 to avoid potential buffer overrun.
7473 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7474 if X resource line is longer than 512 bytes.
7476 * xfns.c (x_window): Make sprintf buffer a bit bigger
7477 to avoid potential buffer overrun.
7479 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7481 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7483 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7485 Integer overflow fixes for scrolling, etc.
7486 Without these, Emacs silently mishandles large integers sometimes.
7487 For example, "C-u 4294967297 M-x recenter" was treated as if
7488 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7490 * xdisp.c (try_window_id): Check Emacs fixnum range before
7491 converting to 'int'.
7493 * window.c (window_scroll_line_based, Frecenter):
7494 Check that an Emacs fixnum is in range before assigning it to 'int'.
7495 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7496 values converted from Emacs fixnums.
7497 (Frecenter): Don't wrap around a line count if it is out of 'int'
7498 range; instead, treat it as an extreme value.
7499 (Fset_window_configuration, compare_window_configurations):
7500 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7502 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7503 that can exceed INT_MAX. Check that EMACS_INT value is in range
7504 before assigning it to the (possibly-narrower) index.
7505 (match_limit): Don't assume that a fixnum can fit in 'int'.
7507 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7510 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7511 (Fvertical_motion): Don't wrap around LINES values that don't fit
7512 in 'int'. Instead, treat them as extreme values. This is good
7513 enough for windows, which can't have more than INT_MAX lines anyway.
7515 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7517 * Require libxml/parser.h to avoid compilation warning.
7519 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7521 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7522 since this reportedly can destroy thread storage.
7524 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7526 * syntax.c (find_defun_start): Update all cache variables if
7527 exiting early (Bug#9401).
7529 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7531 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7533 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7534 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7535 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7537 * term.c (tty_append_glyph): New function.
7538 (produce_stretch_glyph): Static function and its prototype deleted.
7540 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7543 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7545 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7546 when checking :margin (Bug#9390).
7547 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7548 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7549 so that the name doesn't mislead. All uses changed.
7551 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7553 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7556 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7558 * xdisp.c (move_it_to): Don't bail out early when reaching
7559 position beyond to_charpos, if we are scanning backwards.
7560 (move_it_vertically_backward): When DY == 0, make sure we get to
7561 the first character in the line after the newline.
7563 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7565 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7566 (ccl_driver): Do not generate an out-of-range pointer.
7567 (Fccl_execute_on_string): Remove unnecessary check for
7568 integer overflow, noted by Stefan Monnier in
7569 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7570 Remove a FIXME that didn't need fixing.
7571 Simplify the newly-introduced buffer reallocation code.
7573 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7575 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7577 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7579 Integer and memory overflow issues (Bug#9196).
7581 * doc.c (get_doc_string): Rework so that
7582 get_doc_string_buffer_size is the actual buffer size, rather than
7583 being 1 less than the actual buffer size; this makes xpalloc more
7586 * image.c (x_allocate_bitmap_record, cache_image):
7587 * xselect.c (Fx_register_dnd_atom):
7588 Simplify previous changes by using xpalloc.
7590 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7591 since either will do and ptrdiff_t is convenient with xpalloc.
7593 * charset.c (charset_table_size)
7594 (struct charset_sort_data.priority): Now ptrdiff_t.
7595 (charset_compare): Don't overflow if priorities differ greatly.
7596 (Fsort_charsets): Don't assume list length fits in int.
7597 Check for size-calculation overflow when allocating sort data.
7598 (syms_of_charset): Allocate an initial charset table that is
7599 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7601 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7603 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7604 The actual value is always <= INT_MAX, and leaving it unsigned made
7605 overflow checking harder.
7607 * dispextern.h (struct glyph_matrix.rows_allocated)
7608 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7609 with xpalloc. The values are still always <= INT_MAX.
7611 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7613 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7614 (SAFE_NALLOCA): New macro.
7616 * region-cache.c (struct boundary.pos, find_cache_boundary)
7617 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7618 (set_cache_region, invalidate_region_cache)
7619 (revalidate_region_cache, know_region_cache, region_cache_forward)
7620 (region_cache_backward, pp_cache):
7621 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7622 so that ptrdiff_t * can be passed to xpalloc.
7623 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7624 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7625 (pp_cache): Don't assume cache_len fits in int.
7626 * region-cache.h: Adjust extern decls to match.
7628 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7629 EMACS_INT, since either will do, for xpalloc.
7631 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7632 (xnmalloc, xnrealloc, xpalloc): New functions.
7634 * bidi.c (bidi_shelve_header_size): New constant.
7635 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7636 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7638 * bidi.c (bidi_cache_shrink):
7639 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7641 Don't update size of array until after memory allocation succeeds,
7642 because xmalloc/xrealloc may not return.
7643 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7644 now that we have proper integer overflow checking.
7645 (record_overlay_string, overlay_strings): Catch overflows when
7646 calculating size of overlay_str_buf.
7648 * callproc.c (Fcall_process): Check for size overflow when
7649 calculating size of args2.
7650 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7651 Normally we prefer signed values, but sticking with ptrdiff_t would
7652 require adding more-complicated checks.
7654 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7655 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7656 Redo buffer-overflow calculations to avoid integer overflow.
7657 Add a FIXME comment where memory seems to be over-allocated.
7659 * character.c (Fstring): Check for size-calculation overflow.
7661 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7662 unnecessary integer overflow. Check for size overflow.
7663 (encode_coding_object): Don't update size until xmalloc succeeds.
7665 * composite.c (get_composition_id): Check for overflow in glyph
7666 length calculations.
7668 Integer and memory overflow fixes for display code.
7669 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7670 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7671 (scrolling_window): Check for overflow in size calculations.
7672 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7673 Don't assume glyph table len fits in int.
7674 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7675 (row_table_size): Now ptrdiff_t, not int.
7676 (scrolling_window): Avoid overflow in size calculations.
7677 Don't update size until allocation succeeds.
7678 * fns.c (concat): Check for overflow in size calculations.
7679 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7680 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7681 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7683 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7684 (get_doc_string): Check for size calculation overflow.
7685 Don't update size until allocation succeeds.
7686 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7687 EMACS_INT, where ptrdiff_t will do.
7688 (Fsubstitute_command_keys): Check for string overflow.
7690 * editfns.c (set_time_zone_rule): Don't assume environment length
7692 (message_length): Now ptrdiff_t, not int.
7693 (Fmessage_box): Don't update size until allocation succeeds.
7694 Don't assume message length fits in int.
7695 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7697 * emacs.c (main): Do not reallocate argv, since there is a null at
7698 the end that can be overwritten, and this way there's no need to
7699 worry about size-calculation overflow.
7700 (sort_args): Check for size-calculation overflow.
7702 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7704 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7706 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7707 (x_set_scroll_bar_width, x_figure_window_size):
7708 Check for integer overflow.
7709 (x_set_alpha): Do not assume XINT fits in int.
7711 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7712 This is for the members text_lines, text_cols, total_lines, total_cols,
7713 where the system imposes an 'int' limit.
7715 * fringe.c (Fdefine_fringe_bitmap):
7716 Don't update size until alloc works.
7718 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7719 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7721 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7722 Check for size-calculation overflow.
7723 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7724 do, as we prefer signed integers.
7725 (id_to_widget.max_size, id_to_widget.used)
7726 (xg_store_widget_in_map, xg_remove_widget_from_map)
7727 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7728 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7729 Use and return ptrdiff_t, not int.
7730 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7731 * gtkutil.h: Change prototypes to match the above.
7733 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7734 are duplicate now that they've been promoted to lisp.h.
7735 (x_allocate_bitmap_record, x_alloc_image_color)
7736 (make_image_cache, cache_image, xpm_load):
7737 Don't update size until alloc is done.
7738 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7740 Check for size calculation overflow.
7741 (ct_colors_allocated_max): New constant.
7742 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7745 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7746 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7747 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7748 Use ptrdiff_t, not int, to count maps.
7749 (read_char_minibuf_menu_prompt): Check for overflow in size
7750 calculations. Don't update size until allocation succeeds.
7751 Redo calculations to avoid overflow.
7752 * keyboard.h: Change prototypes to match the above.
7754 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7756 (current_minor_maps): Check for size calculation overflow.
7757 * keymap.h: Change prototypes to match the above.
7759 * lread.c (read1, init_obarray): Don't update size until alloc done.
7761 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7762 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7764 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7765 Now ptrdiff_t, not int.
7766 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7767 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7769 * process.c (Fnetwork_interface_list): Check for overflow
7770 in size calculation.
7772 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7774 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7775 overflow. Don't bother calling xmalloc when xrealloc will do.
7777 * search.c (Freplace_match): Check for size calculation overflow.
7778 (Fset_match_data): Don't assume list lengths fit in 'int'.
7780 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7781 for command line length. Do not attempt to address one before the
7782 beginning of an array, as that's not portable.
7784 * term.c (max_frame_lines): Remove; unused.
7785 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7787 (encode_terminal_code, calculate_costs): Check for size
7788 calculation overflow.
7789 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7790 table lengths and related sizes. Don't update size until alloc
7791 done. Redo calculations to avoid overflow.
7792 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7794 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7795 subtracting pointers.
7796 (gobble_line): Check for overflow more carefully. Don't update size
7799 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7800 Don't update size until alloc done.
7801 Redo size calculations to avoid overflow.
7802 Check for size calculation overflow.
7803 (main) [DEBUG]: Fix typo in invoking tparam1.
7805 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7806 Use ptrdiff_t, not int, for sizes.
7807 (store_mode_line_noprop_char): Don't update size until alloc done.
7809 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7810 Use ptrdiff_t, not int, for sizes.
7811 (Finternal_make_lisp_face, cache_face):
7812 Check for size calculation overflow.
7813 (cache_face): Treat size calculation overflows as if they were
7814 memory exhaustion (the usual treatment), rather than aborting.
7816 * xfns.c (x_encode_text, x_set_name_internal)
7817 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7818 sizes, since they can exceed INT_MAX in size. Check for size
7819 calculation overflow.
7821 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7822 (xg_select): Check for size calculation overflow.
7823 Don't update size until alloc done.
7825 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7826 as sprintf is limited to int lengths.
7828 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7829 (X_LONG_MIN): New macros.
7830 Use them to make the following changes clearer.
7831 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7832 This change doesn't affect the value now, but it may help remind
7833 future maintainers not to raise the value too much later.
7834 (SELECTION_QUANTUM): Remove, replacing with ...
7835 (selection_quantum): ... new function, which avoids overflow.
7837 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7838 assumption that selection length fits in 'int'.
7839 (x_reply_selection_request, x_handle_selection_request)
7840 (x_get_window_property, receive_incremental_selection)
7841 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7842 (lisp_data_to_selection_data, clean_local_selection_data):
7843 Use ptrdiff_t, not int, to record length of selection.
7844 (x_reply_selection_request, x_get_window_property)
7845 (receive_incremental_selection, x_property_data_to_lisp):
7846 Redo calculations to avoid overflow.
7847 (x_reply_selection_request): When sending hint, ceiling it at
7848 X_LONG_MAX rather than relying on wraparound overflow to send
7850 (x_get_window_property, receive_incremental_selection)
7851 (lisp_data_to_selection_data, x_property_data_to_lisp):
7852 Check for size-calculation overflow.
7853 (x_get_window_property, receive_incremental_selection)
7854 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7855 Don't store size until memory allocation succeeds.
7856 (x_get_window_property): Plug memory leak on memory exhaustion.
7857 Don't double-block input; malloc is safe here. Don't assume 2**34
7858 - 4 fits in unsigned long. Add an xassert to check
7859 XGetWindowProperty overflow. Be more careful about overflow
7860 calculations, and distinguish size from memory overflow better.
7861 (receive_incremental_selection): When tracing, don't assume
7862 unsigned int is less than INT_MAX.
7863 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7864 harmful) conversions of unsigned short to int.
7865 (lisp_data_to_selection_data): Don't assume that integers
7866 in the range -65535 through -1 fit in an X unsigned short.
7867 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7868 result parameters unless successful. Rely on cons_to_unsigned
7869 to report problems with elements; the old code wasn't right anyway.
7870 (x_check_property_data): Check for int overflow; we cannot use
7871 a wider type due to X limits.
7872 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7874 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7876 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7877 (x_term_init): Check for size calculation overflow.
7878 (x_color_cells): Don't store size until memory allocation succeeds.
7879 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7880 Don't assume alloca size is less than MAX_ALLOCA.
7881 (x_term_init): Don't assume length fits in int (sprintf is limited
7884 Use ptrdiff_t for composition IDs.
7885 * character.c (lisp_string_width):
7886 * composite.c (composition_table_size, n_compositions)
7887 (get_composition_id, composition_gstring_from_id):
7888 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7889 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7890 * window.c (Frecenter):
7891 Use ptrdiff_t, not int, for composition IDs.
7892 * composite.c (get_composition_id): Check for integer overflow.
7893 * composite.h: Adjust prototypes to match the above changes.
7895 Use ptrdiff_t for hash table indexes.
7896 * category.c (hash_get_category_set):
7897 * ccl.c (ccl_driver):
7898 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7899 * coding.c (coding_system_charset_list, detect_coding_system):
7900 * coding.h (struct coding_system.id):
7901 * composite.c (get_composition_id, gstring_lookup_cache):
7902 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7903 * image.c (xpm_get_color_table_h):
7904 * lisp.h (hash_lookup, hash_put):
7905 * minibuf.c (Ftest_completion):
7906 Use ptrdiff_t for hash table indexes, not int (which is too
7907 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7908 32-bit --with-wide-int hosts).
7910 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7911 Add a FIXME comment about memory leaks.
7912 (syms_of_charset): Don't assume xmalloc returns.
7914 Don't assume that stated character widths fit in int.
7915 * character.c (Fchar_width, c_string_width, lisp_string_width):
7916 * character.h (CHAR_WIDTH):
7917 * indent.c (MULTIBYTE_BYTES_WIDTH):
7918 Use sanitize_char_width to avoid undefined and/or bad behavior
7919 with outlandish widths.
7920 * character.h (sanitize_tab_width): Rename from sanitize_width,
7921 now that we have two such functions. All uses changed.
7922 (sanitize_char_width): New inline function.
7924 Don't assume that tab-width fits in int.
7925 * character.h (sanitize_width): New inline function.
7926 (SANE_TAB_WIDTH): New macro.
7927 (ASCII_CHAR_WIDTH): Use it.
7928 * indent.c (sane_tab_width): Remove. All uses replaced by
7929 SANE_TAB_WIDTH (current_buffer).
7930 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7932 * fileio.c: Integer overflow issues with file modes.
7933 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7935 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7936 Remove unreachable code.
7937 (read_hex, load_charset_map_from_file): Check for integer overflow.
7939 * xterm.c: Don't go over XClientMessageEvent limit.
7940 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7941 (x_send_scroll_bar_event): Likewise. Check that the size does not
7942 exceed limits imposed by XClientMessageEvent, as well as the usual
7943 ptrdiff_t and size_t limits.
7945 * keyboard.c: Overflow, signedness and related fixes.
7946 (make_lispy_movement): Use same integer type in forward decl
7947 that is used in the definition.
7948 (read_key_sequence, keyremap_step):
7949 Change bufsize argument back to int, undoing my 2011-03-30 change.
7950 We prefer signed types, and int is wide enough here.
7951 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7952 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7953 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7954 length, not size_t. Use ptrdiff_t for index, not int.
7955 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7956 possibility of integer overflow.
7958 Overflow, signedness and related fixes for images.
7960 * dispextern.h (struct it.stack[0].u.image.image_id)
7961 (struct_it.image_id, struct image.id, struct image_cache.size)
7962 (struct image_cache.used, struct image_cache.ref_count):
7963 * gtkutil.c (update_frame_tool_bar):
7964 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7965 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7966 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7967 * nsmenu.m (update_frame_tool_bar):
7968 * xdisp.c (calc_pixel_width_or_height):
7969 * xfns.c (image_cache_refcount):
7970 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7971 on typical 64-bit hosts.
7973 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7974 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7975 Omit unnecessary casts to int.
7976 (parse_image_spec): Check that integers fall into 'int' range
7977 when the callers expect that.
7978 (image_ascent): Redo ascent calculation to avoid int overflow.
7979 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7980 (lookup_image): Remove unnecessary tests.
7981 (xbm_image_p): Locals are now of int, not EMACS_INT,
7982 since parse_image_check makes sure they fit into int.
7983 (png_load, gif_load, svg_load_image):
7984 Prefer int to unsigned where either will do.
7985 (tiff_handler): New function, combining the cores of the
7986 old tiff_error_handler and tiff_warning_handler.
7987 This function is rewritten to use vsnprintf and thereby avoid
7988 stack buffer overflows. It uses only the features of vsnprintf
7989 that are common to both POSIX and native Microsoft.
7990 (tiff_error_handler, tiff_warning_handler): Use it.
7991 (tiff_load, gif_load, imagemagick_load_image):
7992 Don't assume :index value fits in 'int'.
7993 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7994 (imagemagick_load_image): Check that crop parameters fit into
7995 the integer types that MagickCropImage accepts. Don't assume
7996 Vimagemagick_render_type has a nonnegative value. Don't assume
7997 size_t fits in 'long'.
7998 (gs_load): Use printmax_t to print the widest integers possible.
7999 Check for integer overflow when computing image height and width.
8001 2011-08-26 Eli Zaretskii <eliz@gnu.org>
8003 * xdisp.c (redisplay_window): Don't force window start if point
8004 will be invisible in the resulting window. (Bug#9324)
8006 2011-08-25 Eli Zaretskii <eliz@gnu.org>
8008 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8009 the display spec is of the form `(space ...)'.
8010 (handle_display_spec): Return the value returned by
8011 handle_single_display_spec, not just 1 or zero.
8012 (handle_single_display_spec): If the display spec is of the form
8013 `(space ...)', and specifies display in the text area, return 2
8015 (try_cursor_movement): Check for the need to scroll more
8016 accurately, and prefer exact match for point under bidi.
8017 Don't advance `row' beyond the last row of the window.
8019 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8020 into disp_prop; all users changed.
8022 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8023 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8024 for the text covered by the display property.
8026 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
8028 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8029 Change return value to nil.
8030 (Frecord_buffer): Delete unused function.
8032 2011-08-24 Eli Zaretskii <eliz@gnu.org>
8034 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8035 buffers, return left-to-right.
8036 (set_cursor_from_row): Consider candidate row a win if its glyph
8037 represents a newline and point is on that newline. Fixes cursor
8038 positioning on the newline at EOL of R2L text within L2R
8039 paragraph, and vice versa.
8040 (try_cursor_movement): Check continued rows, in addition to
8041 continuation rows. Fixes unwarranted scroll when point enters a
8042 continued line of R2L text within an L2R paragraph, or vice versa.
8043 (cursor_row_p): Consider the case of point being equal to
8044 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8045 from the end of a short line to the beginning of a continued line
8046 of R2L text within L2R paragraph.
8047 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8048 composed characters.
8050 * bidi.c (bidi_check_type): Use xassert.
8051 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8054 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8056 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8059 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
8061 * nsfont.m (ns_otf_to_script): Fix typo.
8063 2011-08-22 Kenichi Handa <handa@m17n.org>
8065 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8066 extra slot even if the purpose is char-code-property-table.
8068 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8070 * xdisp.c (redisplay_window): When computing centering_position,
8071 account for the height of the header line. (Bug#8874)
8073 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8074 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8075 candidate is selected by the mouse, and that candidate has a
8076 composed character under the mouse.
8078 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8079 coordinates reported by pos-visible-in-window-p for a composed
8080 character in column zero.
8082 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8084 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8086 2011-08-22 Eli Zaretskii <eliz@gnu.org>
8088 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8089 consider it a hit if to_charpos is anywhere in the range of the
8090 composed buffer positions.
8092 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
8094 * image.c (gif_load): Don't assume that each subimage has the same
8095 dimensions as the base image. Handle disposal method that is
8096 "undefined" by the gif spec (Bug#9335).
8098 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
8100 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
8101 (Fcondition_case): Document `debug' symbol in error handler.
8103 2011-08-19 Eli Zaretskii <eliz@gnu.org>
8105 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8106 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8107 from an Org mode buffer to a Speedbar frame.
8109 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8110 a composition, take its buffer position from IT->cmp_it.charpos.
8111 Fixes cursor positioning at the beginning of a line that begins
8112 with a composed character.
8114 2011-08-18 Eli Zaretskii <eliz@gnu.org>
8116 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8117 character bidirectional type, use STRONG_L instead. Fixes crashes
8118 in a buffer produced by `describe-categories'.
8120 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8121 members before the level stack, so they would be saved and
8122 restored when copying iterator state. Fixes incorrect reordering
8123 around TABs covered by display properties.
8125 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8127 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
8129 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
8131 * eval.c (internal_condition_case, internal_condition_case_1)
8132 (internal_condition_case_2, internal_condition_case_n):
8133 Remove unnecessary aborts (Bug#9081).
8135 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8137 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8138 has no `load' handler, try opening the file locally. (Bug#9311)
8140 2011-08-16 Ken Brown <kbrown@cornell.edu>
8142 * gmalloc.c: Expand comment.
8144 2011-08-16 Eli Zaretskii <eliz@gnu.org>
8146 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8147 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8149 2011-08-16 Ken Brown <kbrown@cornell.edu>
8151 Fix memory allocation problems in Cygwin build (Bug#9273).
8153 * unexcw.c ( __malloc_initialized): Declare external variable.
8154 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8156 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8158 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8160 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8162 [CYGWIN] (special_realloc): New function.
8163 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8164 requests to realloc storage in the static heap.
8166 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8168 * bidi.c (bidi_initialize): Remove unused local.
8170 2011-08-15 Eli Zaretskii <eliz@gnu.org>
8173 * biditype.h: Remove file.
8174 * makefile.w32-in ($(BLD)/bidi.$(O)):
8175 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
8177 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8179 * chartab.c: Improve commentary for the uniprop_table API.
8181 * bidi.c (bidi_paragraph_init): Support zero value of
8182 bidi_ignore_explicit_marks_for_paragraph_level.
8183 (bidi_initialize): Use uniprop_table instead of including
8184 biditype.h and bidimirror.h.
8186 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8187 coordinates of the iterator when restoring from ppos_it.
8190 2011-08-14 Kenichi Handa <handa@m17n.org>
8192 * process.c (create_process): Call setup_process_coding_systems
8193 after the pid of the process is set to -1 (Bug#8162).
8195 2011-08-14 Eli Zaretskii <eliz@gnu.org>
8197 * xdisp.c (move_it_in_display_line_to): Don't invoke
8198 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8199 ppos_it. Fixes vertical cursor motion when line beginning is
8200 covered by an image. (Bug#9296)
8202 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8204 * nsterm.h (ns_run_ascript): Declare.
8205 (NSAPP_DATA2_RUNASSCRIPT): Define.
8207 * nsfns.m (as_script, as_result, as_status): New static variables.
8208 (ns_run_ascript): New function.
8209 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
8210 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8211 the event loop. Get status from as_status (Bug#7276).
8213 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8214 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8215 the event loop (Bug#7276).
8217 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8219 * gnutls.c (QCgnutls_bootprop_priority)
8220 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8221 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8222 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8223 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8224 (QCgnutls_bootprop_verify_hostname_error)
8225 (QCgnutls_bootprop_callbacks_verify): Rename from
8226 Qgnutls_bootprop_..., all uses changed.
8228 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8231 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8233 * xfaces.c (Qframe_set_background_mode): Now static.
8234 * dispextern.h (Qframe_set_background_mode): Remove decl.
8236 * process.c (Fnetwork_interface_info): Declare local only if needed.
8238 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8240 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8241 (Fnetwork_interface_list): Allocate in increments of bytes instead
8242 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8243 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8245 (struct ifflag_def): notrailers is smart on OSX.
8246 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8247 Get hardware address with getifaddrs if available.
8249 2011-08-12 Eli Zaretskii <eliz@gnu.org>
8251 * xdisp.c (iterate_out_of_display_property): xassert that
8252 IT->position is set to within IT->object's boundaries. Break from
8253 the loop as soon as EOB is reached; avoids infloops in redisplay
8254 when IT->position is set up wrongly due to some bug.
8255 Set IT->current to match the bidi iterator unconditionally.
8256 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8257 entry. Force push_it to save on the stack the current
8258 buffer/string position, to be restored by pop_it. Fix flags in
8259 the iterator structure wrt the object coming from a display
8260 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8261 properties. (Bug#9284)
8263 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
8265 * fontset.c (fontset_get_font_group): Add proper type checks.
8268 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8270 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8271 and LC_VERSION_MIN_MACOSX.
8272 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8273 (dump_it) [LC_FUNCTION_STARTS]: Use it.
8275 2011-08-08 Eli Zaretskii <eliz@gnu.org>
8277 * xdisp.c (forward_to_next_line_start): Allow to use the
8278 no-display-properties-and-no-overlays under bidi display.
8279 Set disp_pos in the bidi iterator to avoid searches for display
8280 properties and overlays.
8282 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8284 * editfns.c (Fset_time_zone_rule): Document relationship with the
8287 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8288 the font entity extracted from the cache (Bug#8109).
8290 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8292 * composite.c (autocmp_chars): Don't reset point. That is done by
8293 restore_point_unwind (Bug#5984).
8295 2011-08-07 Juri Linkov <juri@jurta.org>
8297 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8298 to show the arg `TIME' instead of `TIMEVAL'.
8300 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8302 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8303 display property strides EOL and includes a newline, as in
8304 longlines-mode. (Bug#9254)
8305 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8306 word-wrap under bidirectional display. (Bug#9224)
8308 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8309 is non-zero, even if the data buffer is NULL. Fixes a crash in
8310 vertical-motion with longlines-mode. (Bug#9254)
8312 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8314 * bidi.c <bidi_cache_total_alloc>: Now static.
8315 (bidi_initialize): Initialize bidi_cache_total_alloc.
8317 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8320 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8321 amount allocated this far in `bidi_cache_total_alloc'.
8322 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8323 non-zero, only free the data buffer without restoring the cache
8324 contents. All callers changed.
8326 * dispextern.h (bidi_unshelve_cache): Update prototype.
8328 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8329 (move_it_in_display_line, move_it_to)
8330 (move_it_vertically_backward, move_it_by_lines): Replace the call
8331 to xfree to an equivalent call to bidi_unshelve_cache.
8332 (move_it_in_display_line_to): Fix logic of returning
8333 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8335 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8337 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8338 came from a string character with a `cursor' property. (Bug#9229)
8340 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8342 * Makefile.in (LIB_PTHREAD): New variable.
8343 (LIBES): Add LIB_PTHREAD (Bug#9216).
8345 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8346 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8348 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8350 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8352 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8354 * xterm.c (x_find_topmost_parent): New function.
8355 (x_set_frame_alpha): Find topmost parent window with
8356 x_find_topmost_parent and set the property there also (bug#9181).
8357 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8359 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8361 * callproc.c (Fcall_process): Avoid vfork clobbering
8362 the local vars buffer, coding_systems, current_dir.
8364 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8366 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8368 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8370 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8371 so that it is not optimized away.
8373 * xdisp.c (compute_display_string_pos): Remove unused local.
8375 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8377 Fix slow cursor motion and scrolling in large buffers with
8378 selective display, like Org Mode buffers. (Bug#9218)
8380 * dispextern.h (struct bidi_it): New member disp_prop_p.
8382 * xdisp.c: Remove one-slot cache of display string positions.
8383 (compute_display_string_pos): Accept an additional argument
8384 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8385 for a display string or property. If found, set DISP_PROP_P
8388 * bidi.c (bidi_fetch_char): Accept an additional argument
8389 DISP_PROP_P, and pass it to compute_display_string_pos.
8390 Only handle text covered by a display string if DISP_PROP_P is returned
8391 non-zero. All callers of bidi_fetch_char changed.
8393 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8395 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8397 2010-12-03 Don March <don@ohspite.net>
8399 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8400 last character M-[char] is translated to ESC [char] (bug#7541).
8402 2011-08-02 Kenichi Handa <handa@m17n.org>
8404 * lisp.h (uniprop_table): Extern it.
8406 * chartab.c (uniprop_table): Make it non-static.
8408 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8410 * xdisp.c (forward_to_next_line_start): Accept additional argument
8411 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8413 (reseat_at_next_visible_line_start): Use the bidi iterator state
8414 returned by forward_to_next_line_start to restore the state of
8415 it->bidi_it after backing up to previous newline. (Bug#9212)
8417 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8419 * regex.c (re_comp): Protoize.
8420 (re_exec): Fix return type.
8421 (regexec): Fix type of `ret'. (Bug#9203)
8423 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8425 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8426 This is needed if max-image-size is a floating-point number.
8428 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8430 * print.c (print_object): Print empty symbol as ##.
8432 * lread.c (read1): Read ## as empty symbol.
8434 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8436 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8437 setting frame foreground color (Bug#9175).
8438 (x_set_background_color): Likewise.
8440 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8441 contents (Bug#9176).
8442 (EmacsTooltip -init): Remove bezels and add shadows to
8445 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8446 or scroll bar (Bug#8470).
8448 * nsfont.m (nsfont_open): Remove assignment to voffset and
8449 unnecessary vars hshink, expand, hd, full_height, min_height.
8450 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8452 * nsterm.h (nsfont_info): Remove voffset field.
8454 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8456 Implement strike-through and overline on NextStep (Bug#8863).
8458 * nsfont.m (nsfont_open): Use underline position provided by font,
8459 instead of hard-coded value of 2.
8460 (nsfont_draw): Call ns_draw_text_decoration instead.
8462 * nsterm.h: Add declaration for ns_draw_text_decoration.
8464 * nsterm.m (ns_draw_text_decoration): New function for drawing
8465 underline, overline, and strike-through.
8466 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8467 ns_draw_text_decoration. Change treatment of cursor drawing to
8468 accommodate underlining, etc.
8470 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8472 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8475 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8477 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8478 Without this fix, if a signal arrives just after memory fills up,
8479 'malloc' might be invoked reentrantly.
8481 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8482 In other words, assume that every image size is allowed, on non-X
8483 hosts. This assumption is probably wrong, but it lets Emacs compile.
8485 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8487 * regex.c (re_iswctype): Convert return values to boolean.
8489 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8491 * xdisp.c (compute_display_string_pos): Don't use cached display
8492 string position if the buffer had its restriction changed.
8495 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8497 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8499 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8501 Integer signedness and overflow and related fixes. (Bug#9079)
8503 * bidi.c: Integer size and overflow fixes.
8504 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8505 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8506 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8507 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8508 (bidi_find_other_level_edge):
8509 Use ptrdiff_t instead of EMACS_INT where either will do.
8510 This works better on 32-bit hosts configured --with-wide-int.
8511 (bidi_cache_ensure_space): Check for size-calculation overflow.
8512 Use % rather than repeated addition, for better worst-case speed.
8513 Don't set bidi_cache_size until after xrealloc returns, because it
8515 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8516 (bidi_cache_ensure_space): Also check that the bidi cache size
8517 does not exceed that of the largest Lisp string or buffer. See Eli
8518 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8520 * alloc.c (__malloc_size_t): Remove.
8521 All uses replaced by size_t. See Andreas Schwab's note
8522 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8524 * image.c: Improve checking for integer overflow.
8525 (check_image_size): Assume that f is nonnull, since
8526 it is always nonnull in practice. This is one less thing to
8527 worry about when checking for integer overflow later.
8528 (x_check_image_size): New function, which checks for integer
8529 overflow issues inside X.
8530 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8531 This removes the need for a memory_full check.
8532 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8533 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8534 (xbm_read_bitmap_data): Change locals back to 'int', since
8535 their values must fit in 'int'.
8536 (xpm_load_image, png_load, tiff_load):
8537 Invoke x_create_x_image_and_pixmap earlier,
8538 to avoid much needless work if the image is too large.
8539 (tiff_load): Treat overly large images as if
8540 x_create_x_image_and_pixmap failed, not as malloc failures.
8541 (gs_load): Use x_check_image_size.
8543 * gtkutil.c: Omit integer casts.
8544 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8545 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8547 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8549 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8550 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8551 would wrongly return t on a 64-bit host.
8553 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8554 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8555 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8556 and therefore cause GCC to emit a bogus diagnostic in some cases.
8558 * image.c: Integer signedness and overflow and related fixes.
8559 This is not an exhaustive set of fixes, but it's time to
8560 record what I've got.
8561 (lookup_pixel_color, check_image_size): Remove redundant decls.
8562 (check_image_size): Don't assume that arbitrary EMACS_INT values
8563 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8564 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8565 (tiff_load, imagemagick_load_image):
8566 Check for overflow in size calculations.
8567 (x_create_x_image_and_pixmap): Remove unnecessary test for
8568 xmalloc returning NULL; that can't happen.
8569 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8570 (xpm_color_bucket): Use better integer hashing function.
8571 (xpm_cache_color): Don't possibly over-allocate memory.
8572 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8573 (gif_memory_source):
8574 Use ptrdiff_t, not int or size_t, to record sizes.
8575 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8576 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8577 either works, as we prefer signed integers.
8578 (tiff_read_from_memory, tiff_write_from_memory):
8579 Return tsize_t, not size_t, since that's what the TIFF API wants.
8580 (tiff_read_from_memory): Don't fail simply because the read would
8581 go past EOF; instead, return a short read.
8582 (tiff_load): Omit no-longer-needed casts.
8583 (Fimagemagick_types): Don't assume size fits into 'int'.
8585 Improve hashing quality when configured --with-wide-int.
8586 * fns.c (hash_string): New function, taken from sxhash_string.
8587 Do not discard information about ASCII character case; this
8588 discarding is no longer needed.
8589 (sxhash-string): Use it. Change sig to match it. Caller changed.
8590 * lisp.h: Declare it.
8591 * lread.c (hash_string): Remove, since we now use fns.c's version.
8592 The fns.c version returns a wider integer if --with-wide-int is
8593 specified, so this should help the quality of the hashing a bit.
8595 * emacs.c: Integer overflow minor fix.
8596 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8597 Define only if GNU_LINUX.
8598 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8600 * dispnew.c: Integer signedness and overflow fixes.
8601 Remove unnecessary forward decls, that were a maintenance hassle.
8602 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8604 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8605 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8606 (prepare_desired_row, line_draw_cost):
8607 Use int, not unsigned, where either works.
8608 (save_current_matrix, restore_current_matrix):
8609 Use ptrdiff_t, not size_t, where either works.
8610 (init_display): Check for overflow more accurately, and without
8611 relying on undefined behavior.
8613 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8614 Remove, replacing with the new symbols in lisp.h. All uses changed.
8615 * fileio.c (make_temp_name):
8616 * filelock.c (lock_file_1, lock_file):
8617 * xdisp.c (message_dolog):
8618 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8619 Use pMd etc. instead.
8620 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8621 replacing the pWIDE etc. symbols removed from editfns.c.
8623 * keyboard.h (num_input_events): Now uintmax_t.
8624 This is (very slightly) less likely to mess up due to wraparound.
8627 * buffer.c: Integer signedness fixes.
8628 (alloc_buffer_text, enlarge_buffer_text):
8629 Use ptrdiff_t rather than size_t when either will do, as we prefer
8632 * alloc.c: Integer signedness and overflow fixes.
8633 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8634 (__malloc_size_t): Default to size_t, not to int.
8635 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8636 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8637 Prefer ptrdiff_t to size_t when either would do, as we prefer
8639 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8640 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8641 Now const. Initialize with values that are in range even if char
8643 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8644 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8645 These functions do the right thing with sizes > 2**32.
8646 (check_depth): Now ptrdiff_t, not int.
8647 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8648 Adjust to new way of storing sizes. Check for size overflow bugs
8650 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8651 slightly wrong anyway, as it missed one instance of
8652 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8653 (refill_memory_reserve): Omit needless cast to size_t.
8654 (mark_object_loop_halt): Mark as externally visible.
8656 * xselect.c: Integer signedness and overflow fixes.
8657 (Fx_register_dnd_atom, x_handle_dnd_message):
8658 Use ptrdiff_t, not size_t, since we prefer signed.
8659 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8660 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8661 x_dnd_atoms_size and x_dnd_atoms_length.
8663 * doprnt.c: Prefer signed to unsigned when either works.
8665 * doprnt.c (doprnt):
8667 * xdisp.c (vmessage):
8668 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8669 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8670 prefer signed arithmetic to avoid comparison confusion.
8671 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8672 but is a bit tricky.
8674 Assume freestanding C89 headers, string.h, stdlib.h.
8675 * data.c, doprnt.c, floatfns.c, print.c:
8676 Include float.h unconditionally.
8677 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8678 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8679 * regex.c: Likewise for stddef.h, string.h.
8680 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8681 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8682 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8683 (STDC_HEADERS): Remove obsolete defines.
8684 * sysdep.c: Include limits.h unconditionally.
8686 Assume support for memcmp, memcpy, memmove, memset.
8687 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8688 * regex.c (memcmp, memcpy):
8689 Remove; we assume C89 now.
8691 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8692 (__malloc_safe_bcopy): Remove; no longer needed.
8694 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8695 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8696 well either way, and we prefer signed to unsigned.
8698 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8700 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8701 closes the connection while we're reading (bug#9182).
8703 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8705 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8706 are specified (Bug#9168).
8708 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8710 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8711 Found by GCC static checking and --with-wide-int on a 32-bit host.
8713 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8715 * xdisp.c (compute_display_string_pos): Fix logic of caching
8716 previous display string position. Initialize cached_prev_pos to
8717 -1. Fixes slow-down at the beginning of a buffer.
8719 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8721 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8722 for attrs[LFACE_FONTSET_INDEX].
8724 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8726 * xml.c (parse_region): Remove unused local
8727 that was recently introduced.
8729 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8731 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8732 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8734 * xdisp.c (move_it_in_display_line_to): Record the best matching
8735 position for TO_CHARPOS while scanning the line, and restore it on
8736 exit if none of the characters scanned was an exact match.
8737 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8738 when exact match is impossible due to invisible text, and the
8739 lines are truncated.
8741 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8743 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8746 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8748 Fix a significant slow-down of cursor motion with C-n, C-p,
8749 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8750 auto-repeat under bidi redisplay in fontified buffers.
8751 * xdisp.c (compute_stop_pos_backwards): New function.
8752 (next_element_from_buffer): Call compute_stop_pos_backwards to
8753 find a suitable prev_stop when we find ourselves before
8755 (reseat): Don't look for prev_stop, as that could mean a very long
8757 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8758 <cached_disp_overlay_modiff>: Cache for last found display string
8760 (compute_display_string_pos): Return the cached position if asked
8761 about the same buffer in the same area of character positions, and
8762 the buffer wasn't changed since the time the display string
8763 position was cached.
8765 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8767 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8768 is an integer, which is important for empty lines. (Bug#9149)
8770 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8772 * frame.c (Fmodify_frame_parameters): In tty case, update the
8773 default face if necessary (Bug#4238).
8775 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8777 * editfns.c (Fstring_to_char): No need to explain what a character
8778 is in the docstring (Bug#6576).
8780 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8782 * xml.c (parse_region): Make sure we always return a tree.
8784 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8786 * xml.c (parse_region): If a document contains only comments,
8789 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8791 * xml.c (make_dom): Return comments, too.
8793 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8796 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8797 and the surrounding thread.
8798 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8799 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8800 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8802 * s/openbsd.h (BROKEN_SIGIO): Define.
8803 * unexelf.c (unexec) [__OpenBSD__]:
8804 Don't update the .mdebug section of the Alpha COFF symbol table.
8806 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8808 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8811 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8813 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8814 This fixes some race conditions on the permissions of any newly
8817 * alloc.c (valid_pointer_p): Use pipe, not open.
8818 This fixes some permissions issues when debugging.
8820 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8821 If fchown fails to set both uid and gid, try to set just gid,
8822 as that is sometimes allowed. Adjust the file's mode to eliminate
8823 setuid or setgid bits that are inappropriate if fchown fails.
8825 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8827 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8828 to compare Lisp_Objects.
8829 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8830 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8831 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8833 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8835 * lread.c (read_integer): Unread even EOF character.
8836 (read1): Likewise. Properly record start position of symbol.
8838 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8839 symbol character follows.
8841 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8843 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8844 This works around a problem with the previous change to Fcopy_file.
8845 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8846 and without this change, GCC might complain about discarding
8847 fchown's return value.
8849 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8851 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8853 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8855 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8857 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8859 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8860 it's used from the C level.
8862 * process.c: Use the same condition for POLL_FOR_INPUT in both
8863 keyboard.c and process.c (bug#1858).
8865 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8867 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8868 (Fgnutls_boot): Use it.
8870 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8872 * doc.c (Fsubstitute_command_keys): Revert last change.
8874 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8876 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8877 quotes the next character, and doesn't affect other longer
8878 sequences (bug#8935).
8880 * lread.c (syms_of_lread): Clarify that is isn't only
8881 `eval-buffer' and `eval-defun' that's affected by
8882 `lexical-binding' (bug#8460).
8884 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8886 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8887 bidi redisplay when a line includes both an image and is truncated.
8889 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8891 Fix minor problems found by static checking.
8892 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8893 (elsz): Now a signed constant, not a size_t var. We prefer signed
8894 types to unsigned, to avoid integer comparison confusion. Without
8895 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8896 "cannot optimize loop, the loop counter may overflow", a symptom
8898 * indent.c (Fvertical_motion): Mark locals as initialized.
8899 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8901 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8903 * search.c (Fre_search_backward): Mention `case-fold-search' in
8904 all the re_search_* functions (bug#8138).
8906 * keyboard.c (Fopen_dribble_file): Document when the file is
8909 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8911 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8914 Support bidi reordering of display and overlay strings.
8915 * xdisp.c (compute_display_string_pos)
8916 (compute_display_string_end): Accept additional argument STRING.
8917 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8918 (reseat_to_string): Initialize bidi_it->string.s and
8919 bidi_it->string.schars.
8920 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8921 NULL (avoids a crash in bidi_paragraph_init).
8922 Initialize itb.string.lstring.
8923 (init_iterator): Call bidi_init_it only of a valid
8924 buffer position was specified. Initialize paragraph_embedding to
8926 (reseat_to_string): Initialize the bidi iterator.
8927 (display_string): If we need to ignore text properties of
8928 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8929 original value of -1 will not work with bidi.)
8930 (compute_display_string_pos): First arg is now struct
8931 `text_pos *'; all callers changed. Support display properties on
8933 (compute_display_string_end): Support display properties on Lisp
8935 (init_iterator, reseat_1, reseat_to_string): Initialize the
8936 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8937 when iterating on a string not from display properties).
8938 (compute_display_string_pos, compute_display_string_end):
8939 Fix calculation of the object to scan. Fixes an error when using
8941 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8942 base_level_stop; instead, set base_level_stop to BEGV.
8943 Fixes crashes in vertical-motion.
8944 (next_element_from_buffer): Improve commentary for when
8945 the iterator is before prev_stop.
8946 (init_iterator): Initialize bidi_p from the default value of
8947 bidi-display-reordering, not from buffer-local value. Use the
8948 buffer-local value only if initializing for buffer iteration.
8949 (handle_invisible_prop): Support invisible properties on strings
8950 that are being bidi-reordered.
8951 (set_iterator_to_next): Support bidi reordering of C strings and
8953 (next_element_from_string): Support bidi reordering of Lisp
8955 (handle_stop_backwards): Support Lisp strings as well.
8956 (display_string): Support display of R2L glyph rows.
8957 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8958 (init_iterator): Don't initialize it->bidi_p for strings
8960 (reseat_to_string): Initialize it->bidi_p for strings here.
8961 (next_element_from_string, next_element_from_c_string)
8962 (next_element_from_buffer): Add xassert's for correspondence
8963 between IT's object being iterated and it->bidi_it.string
8965 (face_before_or_after_it_pos): Support bidi iteration.
8966 (next_element_from_c_string): Handle the case of the first string
8967 character that is not the first one in the visual order.
8968 (get_visually_first_element): New function, refactored from common
8969 parts of next_element_from_buffer, next_element_from_string, and
8970 next_element_from_c_string.
8971 (tool_bar_lines_needed, redisplay_tool_bar)
8972 (display_menu_bar): Force left-to-right direction. Add a FIXME
8973 comment for making that be controlled by a user option.
8974 (push_it, pop_it): Save and restore the state of the
8975 bidi iterator. Save and restore the bidi_p flag.
8976 (pop_it): Iterate out of display property for string iteration as
8978 (iterate_out_of_display_property): Support iteration over strings.
8979 (handle_single_display_spec): Set up it->bidi_it for iteration
8980 over a display string, and call bidi_init_it.
8981 (handle_single_display_spec, next_overlay_string)
8982 (get_overlay_strings_1, push_display_prop): Set up the bidi
8983 iterator for displaying display or overlay strings.
8984 (forward_to_next_line_start): Don't use the shortcut if
8986 (back_to_previous_visible_line_start): If handle_display_prop
8987 pushed the iterator stack, restore the internal state of the bidi
8988 iterator by calling bidi_pop_it same number of times.
8989 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8990 and we are bidi-iterating, don't decrement the iterator position;
8991 instead, set the first_elt flag in the bidi iterator, to produce
8993 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8994 (push_display_prop): xassert that we are iterating a buffer.
8995 (push_it, pop_it): Save and restore paragraph_embedding member.
8996 (handle_single_display_spec, next_overlay_string)
8997 (get_overlay_strings_1, reseat_1, reseat_to_string)
8998 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8999 correctly. Don't assume unibyte strings are not bidi-reordered.
9000 (compute_display_string_pos)
9001 (compute_display_string_end): Fix handling the case of C string.
9002 (push_it, pop_it): Save and restore from_disp_prop_p.
9003 (handle_single_display_spec, push_display_prop): Set the
9004 from_disp_prop_p flag.
9005 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9006 (pop_it): Call iterate_out_of_display_property only if we are
9007 popping after iteration over a string that came from a display
9008 property. Fix a typo in popping stretch info. Add an assertion
9009 for verifying that the iterator position is in sync with the bidi
9011 (handle_single_display_spec, get_overlay_strings_1)
9012 (push_display_prop): Fix initialization of paragraph direction for
9013 string when that of the parent object is not yet determined.
9014 (reseat_1): Call bidi_init_it to resync the bidi
9015 iterator with IT's position. (Bug#7616)
9016 (find_row_edges): If ROW->start.pos gives position
9017 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9018 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9019 Reset the from_disp_prop_p flag.
9020 (SAVE_IT, RESTORE_IT): New macros.
9021 (pos_visible_p, face_before_or_after_it_pos)
9022 (back_to_previous_visible_line_start)
9023 (move_it_in_display_line_to, move_it_in_display_line)
9024 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9025 (try_scrolling, redisplay_window, display_line): Use them when
9026 saving a temporary copy of the iterator and restoring it back.
9027 (back_to_previous_visible_line_start, reseat_1)
9028 (init_iterator): Empty the bidi cache "stack".
9029 (move_it_in_display_line_to): If iterator ended up at
9030 EOL, but we never saw any buffer positions smaller than
9031 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9032 motion in bidi-reordered lines.
9033 (move_it_in_display_line_to): Record prev_method and prev_pos
9034 immediately before the call to set_iterator_to_next. Fixes cursor
9035 motion in bidi-reordered lines with stretch glyphs and strings
9036 displayed in margins. (Bug#8133) (Bug#8867)
9037 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9039 (pos_visible_p): Support positions in bidi-reordered lines.
9040 Save and restore bidi cache.
9042 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9043 (bidi_paragraph_info): Delete unused struct.
9044 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9045 (bidi_cache_start): New variable.
9046 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9048 (bidi_cache_fetch_state, bidi_cache_search)
9049 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9050 (bidi_cache_find, bidi_peek_at_next_level)
9051 (bidi_level_of_next_char, bidi_find_other_level_edge)
9052 (bidi_move_to_visually_next): Compare cache index with
9053 bidi_cache_start rather than with zero.
9054 (bidi_fetch_char): Accept new argument STRING; all callers
9055 changed. Support iteration over a string. Support strings with
9056 display properties. Support unibyte strings. Fix the type of
9057 `len' according to what STRING_CHAR_AND_LENGTH expects.
9058 (bidi_paragraph_init, bidi_resolve_explicit_1)
9059 (bidi_resolve_explicit, bidi_resolve_weak)
9060 (bidi_level_of_next_char, bidi_move_to_visually_next):
9061 Support iteration over a string.
9062 (bidi_set_sor_type, bidi_resolve_explicit_1)
9063 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9064 can now be zero (for strings); special values 0 and -1 were
9065 changed to -1 and -2, respectively.
9066 (bidi_char_at_pos): New function.
9067 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9068 Call it instead of FETCH_MULTIBYTE_CHAR.
9069 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9070 initialized to valid values.
9071 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9073 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9074 the test for valid cached positions. Fix the logic for looking up
9075 the sentinel state in the cache. GCPRO the Lisp string we are
9077 (bidi_push_it, bidi_pop_it): New functions.
9078 (bidi_initialize): Initialize the bidi cache start stack pointer.
9079 (bidi_cache_ensure_space): New function, refactored from part of
9080 bidi_cache_iterator_state. Don't assume the required size is just
9081 one BIDI_CACHE_CHUNK away.
9082 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9083 (bidi_count_bytes, bidi_char_at_pos): New functions.
9084 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9085 always valid if bidi_cache_idx is valid.
9086 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9087 is valid if it's going to be used.
9088 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9089 (bidi_cache_fetch_state, bidi_cache_search)
9090 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9091 (bidi_cache_iterator_state, bidi_cache_find)
9092 (bidi_find_other_level_edge, bidi_cache_start_stack):
9093 All variables related to cache indices are now EMACS_INT.
9095 * dispextern.h (struct bidi_string_data): New structure.
9096 (struct bidi_it): New member `string'. Make flag members be 1-bit
9097 fields, and put them last in the struct.
9098 (compute_display_string_pos, compute_display_string_end):
9100 (bidi_push_it, bidi_pop_it): Add prototypes.
9101 (struct iterator_stack_entry): New members bidi_p,
9102 paragraph_embedding, and from_disp_prop_p.
9103 (struct it): Member bidi_p is now a bit field 1 bit wide.
9104 (bidi_shelve_cache, bidi_unshelve_cache):
9107 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9108 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9109 and vector-like objects.
9111 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9112 cache around display iteration.
9114 * window.c (Fwindow_end, window_scroll_pixel_based)
9115 (displayed_window_lines, Frecenter): Save and restore the bidi
9116 cache around display iteration.
9118 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9120 * editfns.c (Fdelete_region): Clarify the use of the named
9121 parameters (bug#6788).
9123 2011-07-14 Martin Rudalics <rudalics@gmx.at>
9125 * indent.c (Fvertical_motion): Set and restore w->pointm when
9126 saving and restoring the window's buffer (Bug#9006).
9128 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9130 * editfns.c (Fstring_to_char): Clarify just what is returned
9131 (bug#6576). Text by Eli Zaretskii.
9133 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
9135 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9137 2011-07-13 Eli Zaretskii <eliz@gnu.org>
9139 * buffer.c (mmap_find): Fix a typo.
9141 2011-07-13 Johan Bockgård <bojohan@gnu.org>
9143 Fix execution of x selection hooks.
9144 * xselect.c (Qx_lost_selection_functions)
9145 (Qx_sent_selection_functions): New vars.
9146 (syms_of_xselect): DEFSYM them.
9147 (x_handle_selection_request): Pass Qx_sent_selection_functions
9148 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9149 (x_handle_selection_clear,x_clear_frame_selections):
9150 Pass Qx_lost_selection_functions rather than
9151 Vx_lost_selection_functions to Frun_hook_with_args.
9153 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9155 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
9156 The old code sometimes used this field without initializing it.
9158 * alloc.c (gc_sweep): Don't read past end of array.
9159 In theory, the old code could also have corrupted Emacs internals,
9160 though it'd be very unlikely.
9162 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9164 * character.c (Fcharacterp): Don't advertise optional ignored
9165 argument. (Bug#4026)
9167 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9169 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9172 * window.c (Fset_window_start): Doc fix (bug#4199).
9173 (Fset_window_hscroll): Ditto.
9175 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9177 Fix minor new problems caught by GCC 4.6.1.
9178 * term.c (init_tty): Remove unused local.
9179 * xsettings.c (store_monospaced_changed): Define this function only
9180 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
9183 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
9185 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9187 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9189 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9190 are the mini-buffer and the echo area (bug#3320).
9192 * term.c (init_tty): Remove support for supdup, c10 and perq
9193 terminals, which are no longer supported (bug#1482).
9195 2011-07-10 Johan Bockgård <bojohan@gnu.org>
9197 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9199 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9201 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9202 for non-popups (Bug#3642).
9204 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9206 * alloc.c (reset_malloc_hooks): Protoize.
9207 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
9208 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9209 * cm.c (losecursor): Likewise.
9210 * data.c (fmod): Likewise.
9211 * dispnew.c (swap_glyphs_in_rows): Likewise.
9212 * emacs.c (memory_warning_signal): Likewise.
9213 * floatfns.c (float_error): Likewise.
9214 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9215 (otf_open, font_otf_capability, generate_otf_features)
9216 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9218 * image.c (pbm_read_file): Likewise.
9219 * indent.c (string_display_width): Likewise.
9220 * intervals.c (check_for_interval, search_for_interval)
9221 (inc_interval_count, count_intervals, root_interval)
9222 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9223 * lread.c (defalias): Likewise.
9224 * ralloc.c (r_alloc_check): Likewise.
9225 * regex.c (set_image_of_range_1, set_image_of_range)
9226 (regex_grow_registers): Likewise.
9227 * sysdep.c (strerror): Likewise.
9228 * termcap.c (valid_filename_p, tprint, main): Likewise.
9229 * tparam.c (main): Likewise.
9230 * unexhp9k800.c (run_time_remap, save_data_space)
9231 (update_file_ptrs, read_header, write_header, calculate_checksum)
9232 (copy_file, copy_rest, display_header): Likewise.
9233 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9235 * xdisp.c (check_it): Likewise.
9236 * xfaces.c (register_color, unregister_color, unregister_colors):
9238 * xfns.c (print_fontset_result): Likewise.
9239 * xrdb.c (member, fatal, main): Likewise.
9241 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9243 Fix minor problems found by static checking (Bug#9031).
9244 * chartab.c (char_table_set_range, map_sub_char_table):
9245 Remove unused locals.
9246 (uniprop_table): Now static.
9247 * composite.c (_work_char): Remove unused static var.
9249 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
9251 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9253 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9255 * gtkutil.c (qttip_cb): Remove code without function.
9257 2011-07-09 Eli Zaretskii <eliz@gnu.org>
9259 * w32.c (pthread_sigmask): New stub.
9261 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
9263 Use pthread_sigmask, not sigprocmask (Bug#9010).
9264 sigprocmask is portable only for single-threaded applications, and
9265 Emacs can be multi-threaded when it uses GTK.
9266 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9268 * callproc.c (Fcall_process):
9269 * process.c (create_process):
9270 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9271 Use pthread_sigmask, not sigprocmask.
9273 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9275 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9276 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9279 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9281 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9282 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9283 (xg_hide_tooltip): Fix comment.
9285 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9286 in registerServicesMenuSendTypes.
9287 (validRequestorForSendType): Don't check ns_return_types.
9289 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9292 2011-07-08 Jason Rumney <jasonr@gnu.org>
9294 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9295 SH_SHOW for hidden windows (Bug#5482).
9297 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9298 frame struct members of non-existent frames (Bug#6284).
9300 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9302 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9303 variable firstTime not needed on OSX >= 10.6.
9304 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9305 >= 10.5. Use setKnobProportion, setDoubleValue.
9307 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9308 (MAC_OS_X_VERSION_10_5): Define if not defined.
9309 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9310 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9311 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9313 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9314 cString and lossyCString on OSX >= 10.4.
9316 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9317 sizeToFit on OSX >= 10.2.
9319 * nsimage.m (allocInitFromFile): Don't use deprecated method
9320 bestRepresentationForDevice on OSX >= 10.6.
9322 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9325 * emacs.c: Declare unexec_init_emacs_zone.
9327 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9329 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9331 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9332 on svcsMenu (Bug#8842).
9334 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9336 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9338 * nsterm.m (QUTF8_STRING): Declare.
9339 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9340 (validRequestorForSendType): Return type is (id).
9341 Change indexOfObjectIdenticalTo to indexOfObject.
9342 Check if we have local selection before returning self (Bug#8842).
9343 (writeSelectionToPasteboard): Put local selection into paste board
9344 if we have a local selection (Bug#8842).
9345 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9347 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9348 (ns_get_local_selection): Declare.
9350 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9352 * keymap.c (describe_map_tree): Don't insert a double newline at
9353 the end of the buffer (bug#1169) and return whether we inserted
9356 * callint.c (Fcall_interactively): Change "reading args" to
9357 "providing args" to try to clarify what it does (bug#1010).
9359 2011-07-07 Kenichi Handa <handa@m17n.org>
9361 * composite.c (composition_compute_stop_pos): Ignore a static
9362 composition starting before CHARPOS (Bug#8915).
9364 * xdisp.c (handle_composition_prop): Likewise.
9366 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9368 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9371 2011-07-07 Kenichi Handa <handa@m17n.org>
9373 * character.h (unicode_category_t): New enum type.
9375 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9376 (Qchar_code_property_table): New variable.
9377 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9378 (UNIPROP_COMPRESSED_FORM_P): New macros.
9379 (char_table_ascii): Uncompress the compressed values.
9380 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9381 Uncompress the compressed values.
9382 (sub_char_table_ref_and_range): Likewise.
9383 (char_table_ref_and_range): Uncompress the compressed values.
9384 (sub_char_table_set): New arg is_uniprop. Callers changed.
9385 Uncompress the compressed values.
9386 (sub_char_table_set_range): Args changed. Callers changed.
9387 (char_table_set_range): Adjuted for the above change.
9388 (map_sub_char_table): Delete args default_val and parent. Add arg
9389 top. Give decoded values to a Lisp function.
9390 (map_char_table): Adjust for the above change. Give decoded
9391 values to a Lisp function. Gcpro more variables.
9392 (uniprop_table_uncompress)
9393 (uniprop_decode_value_run_length): New functions.
9394 (uniprop_decoder, uniprop_decoder_count): New variables.
9395 (uniprop_get_decoder, uniprop_encode_value_character)
9396 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9398 (uniprop_encoder, uniprop_encoder_count): New variables.
9399 (uniprop_get_encoder, uniprop_table)
9400 (Funicode_property_table_internal, Fget_unicode_property_internal)
9401 (Fput_unicode_property_internal): New functions.
9402 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9403 Sunicode_property_table_internal, Sget_unicode_property_internal,
9404 and Sput_unicode_property_internal. Defvar_lisp
9405 char-code-property-alist.
9407 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9408 Vunicode_category_table.
9410 * font.c (font_range): Adjust for the change of
9411 Vunicode_category_table.
9413 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9415 * m/iris4d.h: Remove file, move contents ...
9416 * s/irix6-5.h: ... here.
9418 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9420 Remove unportable assumption about struct layout (Bug#8884).
9421 * alloc.c (mark_buffer):
9422 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9423 (clone_per_buffer_values): Don't assume that
9424 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9425 This isn't true in general, and it's particularly not true
9426 if Emacs is configured with --with-wide-int.
9427 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9428 New macros, used in the buffer.c change.
9430 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9432 * xsettings.c: Use both GConf and GSettings if both are available.
9433 (store_config_changed_event): Add comment.
9434 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9435 (store_tool_bar_style_changed): New functions.
9436 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9437 (struct xsettings): Move font inside HAVE_XFT.
9438 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9439 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9440 Move inside HAVE_XFT.
9441 (something_changed_gsettingsCB): Rename from something_changedCB.
9442 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9444 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9445 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9446 (something_changed_gconfCB): Rename from something_changedCB.
9447 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9448 (parse_settings): Move check for font inside HAVE_XFT.
9449 (read_settings, apply_xft_settings): Add comment.
9450 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9451 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9452 call store_font_name_changed.
9453 (xft_settings_event): Add comment.
9454 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9455 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9456 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9457 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9458 (xsettings_initialize): Call init_gsettings last.
9459 (xsettings_get_system_font, xsettings_get_system_normal_font):
9462 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9464 Random fixes. E.g., (random) never returned negative values.
9465 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9466 subseconds part to the entropy, as that's a bit more random.
9467 Prefer signed to unsigned, since the signedness doesn't matter and
9468 in general we prefer signed. When given a limit, use a
9469 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9470 latter isn't right if USE_2_TAGS_FOR_INTS.
9471 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9472 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9474 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9476 * textprop.c (text_property_stickiness):
9477 Obey Vtext_property_default_nonsticky.
9478 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9479 * w32fns.c (syms_of_w32fns):
9480 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9482 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9484 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9485 This is more efficient than Ffile_directory_p and avoids a minor race.
9487 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9489 * buffer.c (Foverlay_put): Say what the return value is
9492 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9493 is a directory before asking whether to use the file name
9495 (barf_or_query_if_file_exists): Make the "File is a directory"
9496 error be more correct.
9498 * fns.c (Frequire): Remove the mention of the .gz files, since
9499 that's installation-specific, but keep the mention of
9500 `get-load-suffixes'.
9502 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9504 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9505 Report string overflow if the output is too long.
9507 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9509 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9510 (syms_of_gnutls): Remove duplicate DEFSYM for
9511 Qgnutls_bootprop_verify_hostname_error, an error for
9512 Qgnutls_bootprop_verify_error (which is no longer used).
9514 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9515 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9516 Also (re)move comments that are misplaced or no longer relevant.
9518 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9520 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9522 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9524 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9525 and background color parameters if they have been changed.
9527 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9529 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9531 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9533 * xsettings.c (SYSTEM_FONT): Define only when used.
9534 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9536 * keymap.c (access_keymap_1): Now static.
9538 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9540 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9541 leave any prefix arg for the up event (Bug#1586).
9543 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9545 * lread.c (syms_of_lread): Mention single symbols defined by
9546 `defvar' or `defconst' (bug#7154).
9548 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9549 (Frequire): Mention get-load-suffixes.
9551 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9553 * window.h (window): Remove clone_number slot.
9554 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9556 (make_parent_window, make_window, saved_window)
9557 (Fset_window_configuration, save_window_save): Don't deal with
9559 * buffer.c (Qclone_number): Remove declaration.
9560 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9562 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9564 Add multiple inheritance to keymaps.
9565 * keymap.c (Fmake_composed_keymap): New function.
9566 (Fset_keymap_parent): Simplify.
9567 (fix_submap_inheritance): Remove.
9568 (access_keymap_1): New function extracted from access_keymap to handle
9569 embedded parents and handle lists of maps.
9570 (access_keymap): Use it.
9571 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9572 (Fcopy_keymap): Handle embedded parents.
9573 (Fcommand_remapping, define_as_prefix): Simplify.
9574 (Fkey_binding): Simplify.
9575 (syms_of_keymap): Move minibuffer-local-completion-map,
9576 minibuffer-local-filename-completion-map,
9577 minibuffer-local-must-match-map, and
9578 minibuffer-local-filename-must-match-map to Elisp.
9579 (syms_of_keymap): Defsubr make-composed-keymap.
9580 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9581 (parse_menu_item): Trivial simplification.
9583 2011-07-01 Glenn Morris <rgm@gnu.org>
9585 * Makefile.in (SETTINGS_LIBS): Fix typo.
9587 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9589 * coding.c (Fencode_coding_string): Record the last coding system
9590 used, as the function doc string says (bug#8738).
9592 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9594 * xsettings.c (store_monospaced_changed): Take new font as arg and
9595 check for change against current_mono_font.
9596 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9597 (emacs_settings_constructor, emacs_settings_get_property)
9598 (emacs_settings_set_property, emacs_settings_class_init)
9599 (emacs_settings_init, gsettings_obj): Remove.
9600 (something_changedCB): New function for HAVE_GSETTINGS.
9601 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9602 with value as argument.
9603 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9604 g_settings_new (Bug#8967). Do not create gsettings_obj.
9605 Remove calls to g_settings_bind. Connect something_changedCB to
9608 * xgselect.c: Add defined (HAVE_GSETTINGS).
9609 (xgselect_initialize): Ditto.
9611 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9612 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9615 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9617 * eval.c (struct backtrace): Simplify and port the data structure.
9618 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9619 signed bit field, as this assumption is not portable and it makes
9620 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9621 "char debug_on_exit : 1" as this is not portable either; instead,
9622 use the portable "unsigned int debug_on_exit : 1". Remove unused
9623 member evalargs. Remove obsolete comments about cc bombing out.
9625 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9627 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9628 Let HAVE_GSETTINGS override HAVE_GCONF.
9629 (store_monospaced_changed): New function.
9630 (EMACS_SETTINGS): A new type derived from GObject to handle
9631 GSettings notifications.
9632 (emacs_settings_constructor, emacs_settings_get_property)
9633 (emacs_settings_set_property, emacs_settings_class_init):
9635 (gsettings_client, gsettings_obj): New variables.
9636 (GSETTINGS_SCHEMA): New define.
9637 (something_changedCB): Call store_monospaced_changed.
9638 (init_gsettings): New function.
9639 (xsettings_initialize): Call init_gsettings.
9640 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9643 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9646 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9648 * window.c (resize_root_window, grow_mini_window)
9649 (shrink_mini_window): Rename Qresize_root_window to
9650 Qwindow_resize_root_window and Qresize_root_window_vertically to
9651 Qwindow_resize_root_window_vertically.
9653 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9655 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9657 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9659 * makefile.w32-in: Redesign dependencies so they reflect more
9660 clearly which files are directly included by each source file,
9661 and not through other includes.
9663 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9665 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9666 (sort_overlays, overlay_strings): When an overlay's clone number
9667 matches the window's clone number process the overlay even if
9668 the overlay's window property doesn't match the current window.
9670 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9671 (Fwindow_hchild): Rename to Fwindow_left_child.
9672 (Fwindow_next): Rename to Fwindow_next_sibling.
9673 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9674 (resize_window_check): Rename to window_resize_check.
9675 (resize_window_apply): Rename to window_resize_apply.
9676 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9677 (Fdelete_other_windows_internal, resize_frame_windows)
9678 (Fsplit_window_internal, Fdelete_window_internal)
9679 (grow_mini_window, shrink_mini_window)
9680 (Fresize_mini_window_internal): Fix callers accordingly.
9682 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9684 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9685 (emacs_fixed_set_min_size): Remove.
9686 (emacs_fixed_new): Take frame as argument.
9688 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9689 (_EmacsFixedPrivate): Remove minwidth/height.
9690 Add struct frame *f.
9691 (emacs_fixed_init): Initialize priv->f.
9692 (get_parent_class, emacs_fixed_set_min_size): Remove.
9693 (emacs_fixed_new): Set priv->f to argument.
9694 (emacs_fixed_get_preferred_width)
9695 (emacs_fixed_get_preferred_height): Use min_width/height from
9696 frames size_hint to set minimum and natural (Bug#8919).
9697 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9698 and use min_width/height from frames size_hint to set
9699 min_width/height (Bug#8919).
9701 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9702 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9705 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9707 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9708 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9711 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9713 * process.c (wait_reading_process_output): Bypass select if
9714 waiting for a cell while ignoring keyboard input, and input is
9715 pending. Suggested by Jan Djärv (Bug#8869).
9717 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9719 Use gnulib's dup2 module instead of rolling our own.
9720 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9722 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9724 * dispnew.c (scrolling_window): Before scrolling, turn off a
9725 mouse-highlight in the window being scrolled.
9727 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9729 Move DEFSYM to lisp.h and use everywhere.
9731 * character.h (DEFSYM): Move declaration...
9732 * lisp.h (DEFSYM): ...here.
9738 * w32select.c: Don't include character.h.
9740 * alloc.c (syms_of_alloc):
9741 * buffer.c (syms_of_buffer):
9742 * bytecode.c (syms_of_bytecode):
9743 * callint.c (syms_of_callint):
9744 * casefiddle.c (syms_of_casefiddle):
9745 * casetab.c (init_casetab_once):
9746 * category.c (init_category_once, syms_of_category):
9747 * ccl.c (syms_of_ccl):
9748 * cmds.c (syms_of_cmds):
9749 * composite.c (syms_of_composite):
9750 * dbusbind.c (syms_of_dbusbind):
9751 * dired.c (syms_of_dired):
9752 * dispnew.c (syms_of_display):
9753 * doc.c (syms_of_doc):
9754 * editfns.c (syms_of_editfns):
9755 * emacs.c (syms_of_emacs):
9756 * eval.c (syms_of_eval):
9757 * fileio.c (syms_of_fileio):
9758 * fns.c (syms_of_fns):
9759 * frame.c (syms_of_frame):
9760 * fringe.c (syms_of_fringe):
9761 * insdel.c (syms_of_insdel):
9762 * keymap.c (syms_of_keymap):
9763 * lread.c (init_obarray, syms_of_lread):
9764 * macros.c (syms_of_macros):
9765 * msdos.c (syms_of_msdos):
9766 * print.c (syms_of_print):
9767 * process.c (syms_of_process):
9768 * search.c (syms_of_search):
9769 * sound.c (syms_of_sound):
9770 * syntax.c (init_syntax_once, syms_of_syntax):
9771 * terminal.c (syms_of_terminal):
9772 * textprop.c (syms_of_textprop):
9773 * undo.c (syms_of_undo):
9774 * w32.c (globals_of_w32):
9775 * window.c (syms_of_window):
9776 * xdisp.c (syms_of_xdisp):
9777 * xfaces.c (syms_of_xfaces):
9778 * xfns.c (syms_of_xfns):
9779 * xmenu.c (syms_of_xmenu):
9780 * xsettings.c (syms_of_xsettings):
9781 * xterm.c (syms_of_xterm): Use DEFSYM.
9783 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9785 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9787 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9789 Integer and buffer overflow fixes (Bug#8873).
9791 * print.c (printchar, strout): Check for string overflow.
9792 (PRINTPREPARE, printchar, strout):
9793 Don't set size unless allocation succeeds.
9795 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9796 for sizes. Check for string overflow more accurately.
9797 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9799 * macros.c: Integer and buffer overflow fixes.
9800 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9801 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9802 Use ptrdiff_t, not int, for sizes.
9803 Don't increment bufsize until after realloc succeeds.
9804 Check for size-calculation overflow.
9805 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9807 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9809 * lread.c: Integer overflow fixes.
9810 (read_integer): Radix is now EMACS_INT, not int,
9811 to improve quality of diagnostics for out-of-range radices.
9812 Calculate buffer size correctly for out-of-range radices.
9813 (read1): Check for integer overflow in radices, and in
9814 read-circle numbers.
9815 (read_escape): Avoid int overflow.
9816 (Fload, openp, read_buffer_size, read1)
9817 (substitute_object_recurse, read_vector, read_list, map_obarray):
9818 Use ptrdiff_t, not int, for sizes.
9819 (read1): Use EMACS_INT, not int, for sizes.
9820 Check for size overflow.
9822 * image.c (cache_image): Check for size arithmetic overflow.
9824 * lread.c: Integer overflow issues.
9825 (saved_doc_string_size, saved_doc_string_length)
9826 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9827 Now ptrdiff_t, not int.
9828 (read1): Don't assume doc string length fits in int. Check for
9829 out-of-range doc string lengths.
9830 (read_list): Don't assume file position fits in int.
9831 (read_escape): Check for hex character overflow.
9833 2011-06-22 Leo Liu <sdl.web@gmail.com>
9835 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9836 Move to minibuffer.el.
9838 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9840 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9841 The following patches are for when GLYPH_DEBUG && !XASSERT.
9842 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9843 * dispnew.c (flush_stdout):
9844 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9845 Mark as externally visible.
9846 * dispnew.c (check_window_matrix_pointers): Now static.
9847 * dispnew.c (window_to_frame_vpos):
9848 * xfns.c (unwind_create_frame):
9849 * xterm.c (x_check_font): Remove unused local.
9850 * scroll.c (CHECK_BOUNDS):
9851 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9852 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9853 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9854 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9855 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9857 (debug_method_add): Use va_list and vsprintf rather than relying
9858 on undefined behavior with wrong number of arguments.
9859 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9860 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9861 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9862 since we're not interested in debugging glyphs with old libraries.
9863 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9864 GCC 4.6.0's static checking.
9866 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9868 Integer overflow and signedness fixes (Bug#8873).
9869 A few related buffer overrun fixes, too.
9871 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9873 * dispextern.h (struct face.stipple):
9874 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9875 (x_bitmap_mask, x_allocate_bitmap_record)
9876 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9877 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9878 (x_create_bitmap_from_xpm_data):
9879 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9880 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9882 * xfaces.c (load_pixmap):
9883 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9884 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9885 (.bitmaps_last, struct x_output.icon_bitmap):
9886 Use ptrdiff_t, not int, for bitmap indexes.
9887 (x_allocate_bitmap_record): Check for size overflow.
9888 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9890 Use ptrdiff_t, not int, for overlay counts.
9891 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9892 * editfns.c (overlays_around, get_pos_property):
9893 * textprop.c (get_char_property_and_overlay):
9894 * xdisp.c (next_overlay_change, note_mouse_highlight):
9895 * xfaces.c (face_at_buffer_position):
9896 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9897 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9898 (Fnext_overlay_change, Fprevious_overlay_change)
9899 (mouse_face_overlay_overlaps, Foverlays_in):
9900 Use ptrdiff_t, not int, for sizes.
9901 (overlays_at, overlays_in): Check for size-calculation overflow.
9903 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9905 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9906 (x_session_initialize): Do not assume string length fits in int.
9908 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9909 This is unlikely, but can occur if DPI is outlandish.
9911 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9912 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9914 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9915 * xrdb.c (magic_file_p, search_magic_path):
9916 Omit last arg SUFFIX; it was always 0. All callers changed.
9917 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9919 * xfont.c (xfont_match): Avoid need for strlen.
9921 * xfns.c: Don't assume strlen fits in int.
9922 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9924 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9925 not unsigned long, as we prefer signed integers. All callers changed.
9926 Detect integer overflow in repeat count.
9927 (message_dolog): Don't assume print length fits in 39 bytes.
9928 (display_mode_element): Don't assume strlen fits in int.
9930 * termcap.c: Don't assume sizes fit in int and never overflow.
9931 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9932 (gobble_line): Check for size-calculation overflow.
9934 * minibuf.c (Fread_buffer):
9935 * lread.c (intern, intern_c_string):
9936 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9937 Don't assume string length fits in int.
9939 * keyboard.c (parse_tool_bar_item):
9940 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9942 * font.c: Don't assume string length fits in int.
9943 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9944 Use ptrdiff_t, not int.
9945 (font_intern_prop): Don't assume string length fits in int.
9946 Don't assume integer property fits in fixnum.
9947 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9949 * filelock.c: Fix some buffer overrun and integer overflow issues.
9950 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9951 Reformulate so as not to need the command string.
9952 Invoke gzip -cd rather than gunzip, as it's more portable.
9953 (lock_info_type, lock_file_1, lock_file):
9954 Don't assume pid_t and time_t fit in unsigned long.
9955 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9956 (current_lock_owner): Prefer signed type for sizes.
9957 Use memcpy, not strncpy, where memcpy is what is really wanted.
9958 Don't assume (via atoi) that time_t and pid_t fit in int.
9959 Check for time_t and/or pid_t out of range, e.g., via a network share.
9960 Don't alloca where an auto var works fine.
9962 * fileio.c: Fix some integer overflow issues.
9963 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9964 Don't assume string length fits in int.
9965 (directory_file_name): Don't assume string length fits in long.
9966 (make_temp_name): Don't assume pid fits in int, or that its print
9967 length is less than 20.
9969 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9971 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9973 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9975 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9976 We prefer signed integers, even for size calculations.
9978 * emacs.c: Don't assume string length fits in 'int'.
9979 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9980 (main): Don't invoke strlen when not needed.
9982 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9983 (XD_DEBUG_MESSAGE): Don't waste a byte.
9985 * callproc.c (getenv_internal_1, getenv_internal)
9987 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9989 * lread.c (invalid_syntax): Omit length argument.
9990 All uses changed. This doesn't fix a bug, but it simplifies the
9991 code away from its former Hollerith-constant appearance, and it's
9992 one less 'int' to worry about when looking at integer-overflow issues.
9993 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9995 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9996 This didn't break anything, but it didn't help either.
9997 It's confusing to put a bogus integer in a place where the actual
9998 value does not matter.
9999 (LIST_END_P): Remove unused macro and its bogus comment.
10000 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
10002 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10003 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10005 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10006 We prefer signed types, and the value cannot exceed the EMACS_INT
10007 range anyway (because otherwise the length would not be representable).
10008 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10009 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10010 This avoids a GCC warning when WIDE_EMACS_INT.
10012 * indent.c (sane_tab_width): New function.
10013 (current_column, scan_for_column, Findent_to, position_indentation)
10014 (compute_motion): Use it. This is just for clarity.
10015 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
10017 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
10019 * lisp.h (lint_assume): New macro.
10020 * composite.c (composition_gstring_put_cache):
10021 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10023 * editfns.c, insdel.c:
10024 Omit unnecessary forward decls, to simplify future changes.
10026 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10028 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10030 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
10031 Use much-faster test for byte-length change.
10032 Don't assume string byte-length fits in 'int'.
10033 Check that character arg fits in 'int'.
10034 (mapcar1): Declare byte as byte, for clarity.
10036 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10038 * fns.c (concat): Catch string overflow earlier.
10039 Do not rely on integer wraparound.
10041 * dispextern.h (struct it.overlay_strings_charpos)
10042 (struct it.selective): Now EMACS_INT, not int.
10043 * xdisp.c (forward_to_next_line_start)
10044 (back_to_previous_visible_line_start)
10045 (reseat_at_next_visible_line_start, next_element_from_buffer):
10046 Don't arbitrarily truncate the value of 'selective' to int.
10048 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10050 * composite.c: Don't truncate sizes to 'int'.
10051 (composition_gstring_p, composition_reseat_it)
10052 (composition_adjust_point): Use EMACS_INT, not int.
10053 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10054 not EMACS_UINT, for indexes.
10056 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10058 * buffer.c: Include <verify.h>.
10059 (struct sortvec.priority, struct sortstr.priority):
10060 Now EMACS_INT, not int.
10061 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
10062 (struct sortstr.size, record_overlay_string)
10063 (struct sortstrlist.size, struct sortlist.used):
10064 Don't truncate size to int.
10065 (record_overlay_string): Check for size-calculation overflow.
10066 (init_buffer_once): Check at compile-time, not run-time.
10068 2011-06-22 Jim Meyering <meyering@redhat.com>
10070 Don't leak an XBM-image-sized buffer
10071 * image.c (xbm_load): Free the image buffer after using it.
10073 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10076 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10077 that Sun C diagnosed.
10078 * fns.c (secure_hash): Fix pointer signedness issue.
10079 * intervals.c (static_offset_intervals): New function.
10080 (offset_intervals): Use it.
10082 2011-06-21 Leo Liu <sdl.web@gmail.com>
10085 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10088 * fns.c (secure_hash): Rename from crypto_hash_function and change
10089 the first arg to accept symbols.
10090 (Fsecure_hash): New primitive.
10091 (syms_of_fns): New symbols.
10093 2011-06-20 Deniz Dogan <deniz@dogan.se>
10095 * process.c (Fset_process_buffer): Clarify return value in
10098 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
10100 * dispnew.c (add_window_display_history): Use BVAR.
10102 * xdisp.c (debug_method_add): Use BVAR.
10103 (check_window_end, dump_glyph_matrix, dump_glyph)
10104 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10106 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10109 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10110 check till after the cache is created in init_frame_faces.
10112 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10114 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10116 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10118 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10119 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10120 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10122 Improve buffer-overflow checking (Bug#8873).
10123 * fileio.c (Finsert_file_contents):
10124 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10125 Remove the old (too-loose) buffer overflow checks.
10126 They weren't needed, since make_gap checks for buffer overflow.
10127 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10128 The old code merely checked for Emacs fixnum overflow, and relied
10129 on undefined (wraparound) behavior. The new code avoids undefined
10130 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10132 * editfns.c (Finsert_char): Don't dump core with very negative counts.
10133 Tune. Don't use wider integers than needed. Don't use alloca.
10134 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
10136 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10138 * insdel.c, lisp.h (buffer_overflow): New function.
10139 (insert_from_buffer_1, replace_range, replace_range_2):
10140 * insdel.c (make_gap_larger):
10141 * editfns.c (Finsert_char):
10142 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10144 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10146 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10148 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
10150 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10151 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10153 * fileio.c: Don't assume EMACS_INT fits in off_t.
10154 (emacs_lseek): New static function.
10155 (Finsert_file_contents, Fwrite_region): Use it.
10156 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10158 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10160 * fns.c: Don't overflow int when computing a list length.
10161 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10162 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10163 truncation on 64-bit hosts. Check for QUIT every
10164 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10165 faster and is responsive enough.
10166 (Flength): Report an error instead of overflowing an integer.
10167 (Fsafe_length): Return a float if the value is not representable
10168 as a fixnum. This shouldn't happen except in contrived situations.
10169 (Fnthcdr, Fsort): Don't assume list length fits in int.
10170 (Fcopy_sequence): Don't assume vector length fits in int.
10172 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10173 (header_size, word_size): New constants.
10174 (allocate_vectorlike): Don't check size overflow here.
10175 (allocate_vector): Check it here instead, since this is the only
10176 caller of allocate_vectorlike that could cause overflow.
10177 Check that the new vector's length is representable as a fixnum.
10179 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10180 The previous code was bogus. For example, next_almost_prime (32)
10181 returned 39, which is undesirable as it is a multiple of 3; and
10182 next_almost_prime (24) returned 25, which is a multiple of 5 so
10183 why was the code bothering to check for multiples of 7?
10185 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10187 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10189 Variadic C functions now count arguments with ptrdiff_t.
10190 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10191 Back then I didn't know that the Emacs coding style prefers signed int.
10192 Also, in the meantime I found a few more instances where arguments
10193 were being counted with int, which may truncate counts on 64-bit
10194 machines, or EMACS_INT, which may be unnecessarily wide.
10195 * lisp.h (struct Lisp_Subr.function.aMANY)
10196 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10197 Arg counts are now ptrdiff_t, not size_t.
10198 All variadic functions and their callers changed accordingly.
10199 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10200 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10201 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10202 * callint.c (Fcall_interactively): Check arg count for overflow,
10203 to avoid potential buffer overrun. Use signed char, not 'int',
10204 for 'varies' array, so that we needn't bother to check its size
10205 calculation for overflow.
10206 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10207 * eval.c (apply_lambda):
10208 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10209 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10210 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10212 * callint.c (Fcall_interactively): Don't use index var as event count.
10214 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10215 * mem-limits.h (SIZE): Remove; no longer used.
10217 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
10219 Remove unnecessary casts.
10220 * xterm.c (x_term_init):
10221 * xfns.c (x_set_border_pixel):
10222 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10223 These aren't needed now that we assume ANSI C.
10225 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10226 It's more likely to cause problems (due to unsigned overflow)
10229 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10231 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10233 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10235 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10237 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10239 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10241 GLYPH_CODE_FACE returns EMACS_INT, not int.
10242 * dispextern.h (merge_faces):
10243 * xfaces.c (merge_faces):
10244 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10245 Don't assume EMACS_INT fits in int.
10247 * character.h (CHAR_VALID_P): Remove unused parameter.
10248 * fontset.c, lisp.h, xdisp.c: All uses changed.
10250 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10252 * fns.c (concat): Minor tuning based on overflow analysis.
10253 This doesn't fix any bugs. Use int to hold character, instead
10254 of constantly refetching from Emacs object. Use XFASTINT, not
10255 XINT, for value known to be a character. Don't bother comparing
10256 a single byte to 0400, as it's always less.
10258 * floatfns.c (Fexpt):
10259 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10261 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10264 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10266 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10267 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10268 incorrectly succeed when S was a string, because 4294967386 was
10269 truncated before it was used.
10271 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10272 Otherwise, an out-of-range integer could cause undefined behavior
10275 * composite.c: Use int, not EMACS_INT, for characters.
10276 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10277 EMACS_INT, for values that are known to be in character range.
10278 This doesn't fix any bugs but is the usual style inside Emacs and
10279 may generate better code on 32-bit machines.
10281 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10282 This is for reasons similar to the recent CHAR_STRING fix.
10283 * charset.c (Fencode_char): Check that character arg is actually
10284 a character. Pass an int to ENCODE_CHAR.
10285 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10286 wider than 'int', as a compile-time check to prevent future regressions
10289 * character.c (char_string): Remove unnecessary casts.
10291 Make sure a 64-bit char is never passed to CHAR_STRING.
10292 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10293 by silently ignoring the top 32 bits, allowing some values
10294 that were far too large to be valid characters.
10295 * character.h: Include <verify.h>.
10296 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10297 arguments are no wider than unsigned, as a compile-time check
10298 to prevent future regressions in this area.
10300 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10301 (Fsubst_char_in_region):
10303 * xdisp.c (decode_mode_spec_coding):
10304 Adjust to CHAR_STRING's new requirement.
10305 * editfns.c (Finsert_char, Fsubst_char_in_region):
10306 * fns.c (concat): Check that character args are actually
10307 characters. Without this test, these functions did the wrong
10308 thing with wildly out-of-range values on 64-bit hosts.
10310 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10311 These casts should not be needed on 32-bit hosts, either.
10312 * keyboard.c (read_char):
10313 * lread.c (Fload): Remove casts to unsigned.
10315 * lisp.h (UNSIGNED_CMP): New macro.
10316 This fixes comparison bugs on 64-bit hosts.
10317 (ASCII_CHAR_P): Use it.
10318 * casefiddle.c (casify_object):
10319 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10320 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10321 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10322 * dispextern.h (FACE_FROM_ID):
10323 * keyboard.c (read_char): Use UNSIGNED_CMP.
10325 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10326 not to EMACS_INT, to avoid GCC warning.
10328 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10330 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10331 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10332 isn't needed on 32-bit machines.
10334 * buffer.c (Fgenerate_new_buffer_name):
10335 Use EMACS_INT for count, not int.
10336 (advance_to_char_boundary): Return EMACS_INT, not int.
10338 * data.c (Qcompiled_function): Now static.
10340 * window.c (window_body_lines): Now static.
10342 * image.c (gif_load): Rename local to avoid shadowing.
10344 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10345 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10346 * alloc.c (make_save_value): Integer argument is now of type
10347 ptrdiff_t, not int.
10348 (mark_object): Use ptrdiff_t, not int.
10349 * lisp.h (pD): New macro.
10350 * print.c (print_object): Use it.
10352 * alloc.c: Use EMACS_INT, not int, to count objects.
10353 (total_conses, total_markers, total_symbols, total_vector_size)
10354 (total_free_conses, total_free_markers, total_free_symbols)
10355 (total_free_floats, total_floats, total_free_intervals)
10356 (total_intervals, total_strings, total_free_strings):
10357 Now EMACS_INT, not int. All uses changed.
10358 (Fgarbage_collect): Compute overall total using a double, so that
10359 integer overflow is less likely to be a problem. Check for overflow
10360 when converting back to an integer.
10361 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10362 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10363 These were 'int' variables that could overflow on 64-bit hosts;
10364 they were never used, so remove them instead of repairing them.
10365 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10366 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10367 Previously, this ceilinged at INT_MAX, but that doesn't work on
10369 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10371 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10372 (allocate_vectorlike): Check for ptrdiff_t overflow.
10373 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10374 when a (possibly-narrower) signed value would do just as well.
10375 We prefer using signed arithmetic, to avoid comparison confusion.
10377 * alloc.c: Catch some string size overflows that we were missing.
10378 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10379 for convenience in STRING_BYTES_MAX.
10380 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10381 The definition here is exact; the one in lisp.h was approximate.
10382 (allocate_string_data): Check for string overflow. This catches
10383 some instances we weren't catching before. Also, it catches
10384 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10385 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10386 and ptrdiff_t and EMACS_INT are both 64 bits.
10388 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10389 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10390 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10392 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10394 * alloc.c (Fmake_string): Check for out-of-range init.
10396 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10398 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10400 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10402 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10403 xg_get_default_scrollbar_width.
10405 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10406 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10407 (style_changed_cb): Call update_theme_scrollbar_width and call
10408 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10409 all frames (Bug#8505).
10410 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10411 Call gtk_window_set_resizable if HAVE_GTK3.
10412 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10413 and height if HAVE_GTK3 (Bug#8505).
10414 (scroll_bar_width_for_theme): New variable.
10415 (update_theme_scrollbar_width): New function.
10416 (xg_get_default_scrollbar_width): Move code to
10417 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10418 (xg_initialize): Call update_theme_scrollbar_width.
10420 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10422 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10424 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10426 * frame.c (make_frame): Call other_buffer_safely instead of
10429 * window.c (temp_output_buffer_show): Call display_buffer with
10430 second argument Vtemp_buffer_show_specifiers and reset latter
10431 immediately after the call.
10432 (Vtemp_buffer_show_specifiers): New variable.
10433 (auto_window_vscroll_p, next_screen_context_lines)
10434 (Vscroll_preserve_screen_position): Remove leading asterisks from
10437 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10439 Fix minor problems found by GCC 4.6.0 static checking.
10440 * buffer.c (Qclone_number): Remove for now, as it's unused.
10441 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10442 (record_buffer): Remove unused local.
10443 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10444 (set_frame_buffer_list): Remove; unused.
10445 * frame.h (other_visible_frames): Remove decl.
10446 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10447 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10448 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10450 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10451 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10452 Define only if HAVE_GPM.
10453 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10454 (update_hints_inhibit): Remove; never set. All uses removed.
10455 * widgetprv.h (emacsFrameClassRec): Remove decl.
10456 * window.c (delete_deletable_window): Now returns void, since it
10457 wasn't returning anything.
10458 (compare_window_configurations): Remove unused locals.
10459 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10460 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10461 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10462 the same widths as pointers. This follows up on the 2011-05-06 patch.
10463 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10464 * xterm.h: Likewise.
10465 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10467 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10469 * makefile.w32-in: Update dependencies.
10470 (LISP_H): Add lib/intprops.h.
10472 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10474 * image.c (gif_load): Add animation frame delay to the metadata.
10475 (syms_of_image): Use DEFSYM. New symbol `delay'.
10477 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10479 * window.c (delete_deletable_window): Re-add.
10480 (Fset_window_configuration): Rewrite to handle dead buffers and
10481 consequently deletable windows.
10482 (window_tree, Fwindow_tree): Remove. Supply functionality in
10484 (compare_window_configurations): Simplify code.
10486 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10488 * image.c (imagemagick_load_image): Fix type mismatch.
10489 (Fimagemagick_types): Likewise.
10491 * window.h (replace_buffer_in_windows): Declare.
10493 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10495 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10496 Qclone_number. Remove external declaration of Qdelete_window.
10497 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10499 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10500 Run Qbuffer_list_update_hook if allowed.
10501 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10502 buffer list implementation.
10503 (other_buffer_safely): New function.
10504 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10505 calls to replace_buffer_in_windows and
10506 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10508 (record_buffer): Inhibit quitting and rewrite using quittable
10509 functions. Run Qbuffer_list_update_hook if allowed.
10510 (Frecord_buffer, Funrecord_buffer): New functions.
10511 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10512 Move switch-to-buffer to window.el.
10513 (bury-buffer): Move to window.el.
10514 (Vbuffer_list_update_hook): New variable.
10516 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10519 * window.h (resize_frame_windows): Move up in code.
10520 (Fwindow_frame): Remove EXFUN.
10521 (replace_buffer_in_all_windows): Remove prototype.
10522 (replace_buffer_in_windows_safely): Add prototype.
10524 * window.c: Declare Qdelete_window static again. Move down
10525 declaration of select_count.
10526 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10527 (Fother_window): Move to window.el.
10528 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10529 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10530 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10532 (replace_buffer_in_windows): Implement by calling
10533 Qreplace_buffer_in_windows.
10534 (replace_buffer_in_all_windows): Remove with some functionality
10535 moved into replace_buffer_in_windows_safely.
10536 (replace_buffer_in_windows_safely): New function.
10537 (select_window_norecord, select_frame_norecord): Move in front
10538 of run_window_configuration_change_hook. Remove now obsolete
10540 (Fset_window_buffer): Rewrite doc-string.
10541 Call Qrecord_window_buffer.
10542 (keys_of_window): Move binding for other-window to window.el.
10544 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10546 * dispextern.h (struct image): Replace data member, whose int_val
10547 and ptr_val fields were not used by anything, with a single
10550 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10551 (gif_clear_image, gif_load, imagemagick_load_image)
10552 (gs_clear_image, gs_load): Callers changed.
10554 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10556 * buffer.h: Include <time.h>, for time_t.
10557 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10559 Fix minor problems found by static checking.
10561 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10563 Make identifiers static if they are not used in other modules.
10564 * data.c (Qcompiled_function, Qframe, Qvector):
10565 * image.c (QimageMagick, Qsvg):
10566 * minibuf.c (Qmetadata):
10567 * window.c (resize_window_check, resize_root_window): Now static.
10568 * window.h (resize_window_check, resize_root_window): Remove decls.
10570 * window.c (window_deletion_count, delete_deletable_window):
10572 (window_body_lines): Now static.
10573 (Fdelete_other_windows_internal): Mark vars as initialized.
10574 Make sure 'resize_failed' is initialized.
10575 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10576 (resize_window_apply): Remove unused local.
10577 * window.h (delete_deletable_window): Remove decl.
10579 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10580 (imagemagick_load_image): Fix pointer signedness problem by changing
10581 last arg from unsigned char * to char *. All uses changed.
10582 Also, fix a local for similar reasons.
10583 Remove unused locals. Remove locals to avoid shadowing.
10584 (fn_rsvg_handle_free): Remove; unused.
10585 (svg_load, svg_load_image): Fix pointer signedness problem.
10586 (imagemagick_load_image): Don't use garbage pointer image_wand.
10588 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10590 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10592 * image.c (gif_load): Fix omitted cast error introduced by
10595 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10597 * window.h (resize_proportionally, orig_total_lines)
10598 (orig_top_line): Remove from window structure.
10599 (set_window_height, set_window_width, change_window_heights)
10600 (Fdelete_window): Remove prototypes.
10601 (resize_frame_windows): Remove duplicate declaration.
10603 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10605 * window.h (resize_frame_windows, resize_window_check)
10606 (delete_deletable_window, resize_root_window)
10607 (resize_frame_windows): Declare prototypes.
10609 * window.c (resize_window_apply): Make definition be "static" to
10610 match the prototype.
10612 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10614 * window.c: Remove declarations of Qwindow_size_fixed,
10615 window_min_size_1, window_min_size_2, window_min_size,
10616 size_window, window_fixed_size_p, enlarge_window, delete_window.
10617 Remove static from declaration of Qdelete_window, it's
10618 temporarily needed by Fbury_buffer.
10619 (replace_window): Don't assign orig_top_line and
10621 (Fdelete_window, delete_window): Remove. Window deletion is
10622 handled by window.el.
10623 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10624 Replace Fdelete_window calls with calls to Qdelete_window.
10625 (Fdelete_other_windows): Remove. Deleting other windows is
10626 handled by window.el.
10627 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10628 handled in window.el.
10629 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10630 Window minimum sizes are handled in window.el.
10631 (shrink_windows, size_window, set_window_height)
10632 (set_window_width, change_window_heights, window_height)
10633 (window_width, CURBEG, CURSIZE, enlarge_window)
10634 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10635 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10636 handled in window.el.
10637 (make_dummy_parent): Rename to make_parent_window and give it a
10638 second argument horflag.
10639 (make_window): Don't set resize_proportionally any more.
10640 (Fsplit_window): Remove. Windows are split in window.el.
10641 (save_restore_action, save_restore_orig_size)
10642 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10643 Resize mini windows in window.el.
10644 (grow_mini_window, shrink_mini_window): Implement by calling
10645 Qresize_root_window_vertically, resize_window_check and
10646 resize_window_apply.
10647 (saved_window, Fset_window_configuration, save_window_save):
10648 Do not handle orig_top_line, orig_total_lines, and
10649 resize_proportionally.
10650 (window_min_height, window_min_width): Move to window.el.
10651 (keys_of_window): Move bindings for delete-other-windows,
10652 split-window, delete-window and enlarge-window to window.el.
10654 * buffer.c: Temporarily extern Qdelete_window.
10655 (Fbury_buffer): Temporarily call Qdelete_window instead of
10656 Fdelete_window (Fbury_buffer will move to window.el soon).
10658 * frame.c (set_menu_bar_lines_1): Remove code handling
10659 orig_top_line and orig_total_lines.
10661 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10662 set_window_height but set heights directly.
10663 (change_frame_size_1): Use resize_frame_windows.
10665 * xdisp.c (init_xdisp): Don't use set_window_height but set
10668 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10669 Use resize_frame_windows instead of change_window_heights and run
10670 run_window_configuration_change_hook.
10672 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10673 instead of change_window_heights and run
10674 run_window_configuration_change_hook.
10676 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10678 * window.c (replace_window): Rename second argument REPLACEMENT to
10679 NEW. New third argument SETFLAG. Rewrite.
10680 (delete_window, make_dummy_parent): Call replace_window with
10682 (window_list_1): Move down in code.
10683 (run_window_configuration_change_hook): Move set_buffer part
10684 before select_frame_norecord part in order to unwind correctly.
10685 Rename count1 to count.
10686 (recombine_windows, delete_deletable_window, resize_root_window)
10687 (Fdelete_other_windows_internal)
10688 (Frun_window_configuration_change_hook, make_parent_window)
10689 (resize_window_check, resize_window_apply, Fresize_window_apply)
10690 (resize_frame_windows, Fsplit_window_internal)
10691 (Fdelete_window_internal, Fresize_mini_window_internal):
10693 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10695 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10697 * window.h (window): Add some new members to window structure -
10698 normal_lines, normal_cols, new_total, new_normal, clone_number,
10699 splits, nest, prev_buffers, next_buffers.
10700 (WINDOW_TOTAL_SIZE): Move here from window.c.
10701 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10703 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10705 (make_dummy_parent): Set new members of windows structure.
10706 (make_window): Move down in code. Handle new members of window
10708 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10709 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10710 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10711 (Fset_window_prev_buffers, Fwindow_next_buffers)
10712 (Fset_window_next_buffers, Fset_window_clone_number):
10714 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10715 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10717 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10718 Argument WINDOW can be now internal window too.
10719 (Fwindow_use_time): Move up in code.
10720 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10721 Rewrite doc-string.
10722 (Fset_window_configuration, saved_window)
10723 (Fcurrent_window_configuration, save_window_save): Handle new
10724 members of window structure.
10725 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10726 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10727 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10728 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10729 Qget_mru_window, Qresize_root_window,
10730 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10731 Qauto_buffer_name; staticpro them.
10733 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10735 * window.c (Fwindow_total_size, Fwindow_left_column)
10736 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10737 (Fwindow_list_1): New functions.
10738 (window_box_text_cols): Replace with window_body_cols.
10739 (Fwindow_width, Fscroll_left, Fscroll_right):
10740 Use window_body_cols instead of window_box_text_cols.
10741 (delete_window, Fset_window_configuration):
10742 Call delete_all_subwindows with window as argument.
10743 (delete_all_subwindows): Take a window as argument and not a
10744 structure. Rewrite.
10745 (window_loop): Remove handling of GET_LRU_WINDOW and
10746 GET_LARGEST_WINDOW.
10747 (Fget_lru_window, Fget_largest_window): Move to window.el.
10749 * window.h: Extern window_body_cols instead of
10750 window_box_text_cols. delete_all_subwindows now takes a
10751 Lisp_Object as argument.
10753 * indent.c (compute_motion, Fcompute_motion):
10754 Use window_body_cols instead of window_box_text_cols.
10756 * frame.c (delete_frame): Call delete_all_subwindows with root
10757 window as argument.
10759 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10761 * fns.c (Fputhash): Document return value.
10763 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10765 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10767 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10769 Cons<->int and similar integer overflow fixes (Bug#8794).
10771 Check for overflow when converting integer to cons and back.
10772 * charset.c (Fdefine_charset_internal, Fdecode_char):
10773 Use cons_to_unsigned to catch overflow.
10774 (Fencode_char): Use INTEGER_TO_CONS.
10775 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10776 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10777 * data.c (long_to_cons, cons_to_long): Remove.
10778 (cons_to_unsigned, cons_to_signed): New functions.
10779 These signal an error for invalid or out-of-range values.
10780 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10781 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10782 * font.c (Ffont_variation_glyphs):
10783 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10784 * lisp.h: Include <intprops.h>.
10785 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10786 (cons_to_signed, cons_to_unsigned): New decls.
10787 (long_to_cons, cons_to_long): Remove decls.
10788 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10789 (Fprimitive_undo): Use CONS_TO_INTEGER.
10790 * xfns.c (Fx_window_property): Likewise.
10791 * xselect.c: Include <limits.h>.
10792 (x_own_selection, selection_data_to_lisp_data):
10793 Use INTEGER_TO_CONS.
10794 (x_handle_selection_request, x_handle_selection_clear)
10795 (x_get_foreign_selection, Fx_disown_selection_internal)
10796 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10797 (lisp_data_to_selection_data): Use cons_to_unsigned.
10798 (x_fill_property_data): Use cons_to_signed.
10799 Report values out of range.
10801 Check for buffer and string overflow more precisely.
10802 * buffer.h (BUF_BYTES_MAX): New macro.
10803 * lisp.h (STRING_BYTES_MAX): New macro.
10804 * alloc.c (Fmake_string):
10805 * character.c (string_escape_byte8):
10806 * coding.c (coding_alloc_by_realloc):
10807 * doprnt.c (doprnt):
10808 * editfns.c (Fformat):
10810 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10811 since they may not be the same number.
10812 * editfns.c (Finsert_char):
10813 * fileio.c (Finsert_file_contents):
10814 Likewise for BUF_BYTES_MAX.
10816 * image.c: Use ptrdiff_t, not int, for sizes.
10817 (slurp_file): Switch from int to ptrdiff_t.
10819 (slurp_file): Check that file size fits in both size_t (for
10820 malloc) and ptrdiff_t (for sanity and safety).
10822 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10823 if b->modtime has its maximal value.
10825 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10827 Don't assume time_t can fit into int.
10828 * buffer.h (struct buffer.modtime): Now time_t, not int.
10829 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10830 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10832 Minor fixes for signed vs unsigned integers.
10833 * character.h (MAYBE_UNIFY_CHAR):
10834 * charset.c (maybe_unify_char):
10835 * keyboard.c (read_char, reorder_modifiers):
10836 XINT -> XFASTINT, since the integer must be nonnegative.
10837 * ftfont.c (ftfont_spec_pattern):
10838 * keymap.c (access_keymap, silly_event_symbol_error):
10839 XUINT -> XFASTINT, since the integer must be nonnegative.
10840 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10841 since it makes no difference and we prefer signed.
10842 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10843 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10846 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10848 * window.h (Fwindow_frame): Declare.
10850 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10852 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10853 (SPARE_MEMORY): Always define.
10854 (LARGE_REQUEST): Remove.
10855 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10857 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10859 * lisp.h: Move EXFUNS for Fframe_root_window,
10860 Fframe_first_window and Fset_frame_selected_window to window.h.
10862 * window.h: Move EXFUNS for Fframe_root_window,
10863 Fframe_first_window and Fset_frame_selected_window here from
10866 * frame.c (Fwindow_frame, Fframe_first_window)
10867 (Fframe_root_window, Fframe_selected_window)
10868 (Fset_frame_selected_window): Move to window.c.
10869 (Factive_minibuffer_window): Move to minibuf.c.
10870 (Fother_visible_frames_p): New function.
10872 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10874 * window.c (decode_window, decode_any_window): Move up in code.
10875 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10876 (inhibit_frame_unsplittable): Remove unused variable.
10877 (Fwindow_buffer): Move up and rewrite doc-string.
10878 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10879 (Fwindow_prev): New functions.
10880 (Fwindow_frame): Move here from frame.c. Accept any window as
10882 (Fframe_root_window, Fframe_first_window)
10883 (Fframe_selected_window): Move here from frame.c. Accept frame
10884 or arbitrary window as argument. Update doc-strings.
10885 (Fminibuffer_window): Move up in code.
10886 (Fwindow_minibuffer_p): Move up in code and simplify.
10887 (Fset_frame_selected_window): Move here from frame.c.
10889 (Fselected_window, select_window, Fselect_window): Move up in
10890 code. Minor doc-string fixes.
10892 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10894 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10895 Do not assume that spare memory exists; that assumption is valid
10896 only if SYSTEM_MALLOC.
10897 (LARGE_REQUEST): New macro, so that the issue of large requests
10898 is separated from the issue of spare memory.
10900 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10902 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10905 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10907 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10910 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10912 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10914 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10916 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10917 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10919 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10921 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10923 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10925 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10926 (x_clipboard_manager_save): Add return value.
10927 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10928 New error handlers.
10929 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10930 Obey Vx_select_enable_clipboard_manager. Catch errors in
10931 x_clipboard_manager_save (Bug#8779).
10932 (Vx_select_enable_clipboard_manager): New variable.
10933 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10935 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10937 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10939 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10941 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10942 in the current matrix if keep_current_p is non-zero.
10944 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10946 * bidi.c (bidi_level_of_next_char): Fix last change.
10948 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10950 Support bidi reordering of text covered by display properties.
10952 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10953 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10954 (bidi_cache_search, bidi_cache_iterator_state)
10955 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10956 (bidi_level_of_next_char, bidi_move_to_visually_next):
10957 Support character positions inside a run of characters covered by a
10959 (bidi_paragraph_init, bidi_resolve_explicit_1)
10960 (bidi_level_of_next_char): Call bidi_fetch_char and
10961 bidi_fetch_char_advance instead of FETCH_CHAR and
10962 FETCH_CHAR_ADVANCE.
10963 (bidi_init_it): Initialize new members.
10964 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10966 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10967 instead of using explicit *_CHAR codes.
10968 (bidi_resolve_explicit, bidi_resolve_weak):
10969 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10970 bidirectional text is supported only in multibyte buffers.
10971 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10972 it to initialize the frame_window_p member of struct bidi_it.
10973 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10974 (bidi_resolve_explicit, bidi_resolve_weak)
10975 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10976 bidi_it->nchars is non-positive.
10977 (bidi_level_of_next_char): Don't try to lookup the cache for the
10978 next/previous character if nothing is cached there yet, or if we
10979 were just reseat()'ed to a new position.
10981 * xdisp.c (set_cursor_from_row): Set start and stop points
10982 according to the row's direction when priming the loop that looks
10983 for the glyph on which to display cursor.
10984 (single_display_spec_intangible_p): Function deleted.
10985 (display_prop_intangible_p): Reimplement to call
10986 handle_display_spec instead of single_display_spec_intangible_p.
10987 Accept 3 additional arguments needed by handle_display_spec.
10988 This fixes incorrect cursor motion across display property with complex
10989 values: lists, `(when COND...)' forms, etc.
10990 (single_display_spec_string_p): Support property values that are
10991 lists with the argument STRING its top-level element.
10992 (display_prop_string_p): Fix the condition for processing a
10993 property that is a list to be consistent with handle_display_spec.
10994 (handle_display_spec): New function, refactored from the
10995 last portion of handle_display_prop.
10996 (compute_display_string_pos): Accept additional argument
10997 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10998 value of a `display' property is a "replacing spec".
10999 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11000 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11001 the display property, but just return a value indicating whether
11002 the display property will replace the characters it covers.
11003 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11004 frame_window_p members of struct bidi_it.
11005 (compute_display_string_pos, compute_display_string_end):
11007 (push_it): Accept second argument POSITION, where pop_it should
11008 jump to continue iteration.
11009 (reseat_1): Initialize bidi_it.disp_pos.
11011 * keyboard.c (adjust_point_for_property): Adjust the call to
11012 display_prop_intangible_p to its new signature.
11014 * dispextern.h (struct bidi_it): New member frame_window_p.
11015 (bidi_init_it): Update prototypes.
11016 (display_prop_intangible_p): Update prototype.
11017 (compute_display_string_pos, compute_display_string_end):
11018 Declare prototypes.
11019 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11022 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
11024 Malloc failure behavior now depends on size of allocation.
11025 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11026 * lisp.h: Change signatures accordingly.
11027 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11028 All callers changed. (Bug#8762)
11030 * gnutls.c: Use Emacs's memory allocators.
11031 Without this change, the gnutls library would invoke malloc etc.
11032 directly, which causes problems on non-SYNC_INPUT hosts, and which
11033 runs afoul of improving memory_full behavior. (Bug#8761)
11034 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11035 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11036 xfree instead of the default malloc, realloc, free.
11037 (Fgnutls_boot): No need to check for memory allocation failure,
11038 since xmalloc does that for us.
11040 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
11041 * category.c (hash_get_category_set):
11042 * ccl.c (ccl_driver):
11043 * charset.c (Fdefine_charset_internal):
11044 * charset.h (struct charset.hash_index):
11045 * composite.c (get_composition_id, gstring_lookup_cache)
11046 (composition_gstring_put_cache):
11047 * composite.h (struct composition.hash_index):
11048 * dispextern.h (struct image.hash):
11049 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11050 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11051 (hashfn_equal, hashfn_user_defined, make_hash_table)
11052 (maybe_resize_hash_table, hash_lookup, hash_put)
11053 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11054 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11055 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11056 * image.c (make_image, search_image_cache, lookup_image)
11057 (xpm_put_color_table_h):
11058 * lisp.h (struct Lisp_Hash_Table):
11059 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
11060 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
11061 for hashes and hash indexes, instead of 'unsigned' and 'int'.
11062 * alloc.c (allocate_vectorlike):
11063 Check for overflow in vector size calculations.
11064 * ccl.c (ccl_driver):
11065 Check for overflow when converting EMACS_INT to int.
11066 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11067 need to be updated by these changes.
11068 * fns.c (make_hash_table, maybe_resize_hash_table):
11069 Check for integer overflow with large hash tables.
11070 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11071 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11072 (SXHASH_REDUCE): New macro.
11073 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11074 Use it instead of discarding useful hash info with large hash values.
11075 (sxhash_float): New function.
11076 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11077 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
11078 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11079 Rewrite to use FIXNUM_BITS, as this simplifies things.
11080 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11081 Adjust signatures to match updated version of code.
11082 (consing_since_gc): Now EMACS_INT, since a single hash table can
11083 use more than INT_MAX bytes.
11085 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11087 Make it possible to build with GCC-4.6+ -O2 -flto.
11089 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11091 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11093 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11094 Call minibuffer-inactive-mode.
11096 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
11098 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11099 Update dependencies.
11101 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11103 * data.c (init_data): Remove code for UTS, this system is not
11106 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11108 Don't force ./temacs to start in terminal mode.
11110 * frame.c (make_initial_frame): Initialize faces in all cases, not
11111 only when CANNOT_DUMP is defined.
11112 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11114 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11116 * dispnew.c (add_window_display_history): Use const for the string
11117 pointer. Remove declaration, not needed.
11119 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11121 Use 'inline', not 'INLINE'.
11122 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
11123 * alloc.c, fontset.c (INLINE): Remove.
11124 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11125 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11126 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11127 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11128 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11130 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11132 Make it possible to run ./temacs.
11134 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11135 syms_of_callproc does the same thing. Remove test for
11136 "initialized", do it in the caller.
11137 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11139 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11141 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11142 (read_minibuf): Use get_minibuffer.
11143 (syms_of_minibuf): Use DEFSYM.
11144 (Qmetadata): New var.
11145 * data.c (Qbuffer): Don't make it static.
11146 (syms_of_data): Use DEFSYM.
11148 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11150 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11151 (CCL_CODE_MIN): New macro.
11153 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11155 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11157 * eval.c (Qdebug): Now static.
11158 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11159 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11160 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11162 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11164 * image.c: Various fixes to ImageMagick code comments.
11165 (Fimagemagick_types): Doc fix.
11167 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11169 Minor fixes prompted by GCC 4.6.0 warnings.
11171 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11173 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11174 (x_clipboard_manager_save_all): Move extern decl to ...
11175 * xterm.h: ... here, so that it can be checked for consistency.
11177 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11179 * xselect.c (x_clipboard_manager_save_frame)
11180 (x_clipboard_manager_save_all): New functions.
11181 (Fx_clipboard_manager_save): Lisp function deleted.
11183 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11184 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11186 * xterm.h: Update prototype.
11188 2011-05-28 William Xu <william.xwl@gmail.com>
11190 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11191 exiting (Bug#8239).
11193 2011-05-28 Jim Meyering <meyering@redhat.com>
11195 Avoid a sign-extension bug in crypto_hash_function.
11196 * fns.c (to_uchar): Define.
11197 (crypto_hash_function): Use it to convert some newly-signed
11198 variables to unsigned, to avoid sign-extension bugs. For example,
11199 without this change, (md5 "truc") would evaluate to
11200 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11201 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
11202 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
11204 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11206 Integer overflow fixes.
11208 * dbusbind.c: Serial number integer overflow fixes.
11209 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
11210 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11211 to hold a serial number that is too large for a fixnum.
11212 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11213 Check for serial numbers out of range. Decode any serial number
11214 that was so large that it became a float. (Bug#8722)
11216 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11217 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11218 Use XFASTINT rather than XUINT when numbers are nonnegative.
11219 (xd_append_arg, Fdbus_method_return_internal):
11220 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11221 arguments, check that Lisp number is nonnegative, rather than
11222 silently wrapping negative numbers around. (Bug#8722)
11223 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
11226 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11228 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11230 ccl: Add integer overflow checks.
11231 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11232 (IN_INT_RANGE): New macros.
11233 (ccl_driver): Use them to check for integer overflow when
11234 decoding a CCL program. Many of the new checks are whether XINT (x)
11235 fits in int; it doesn't always, on 64-bit hosts. The new version
11236 doesn't catch all possible integer overflows, but it's an
11237 improvement. (Bug#8719)
11239 * alloc.c (make_event_array): Use XINT, not XUINT.
11240 There's no need for unsigned here.
11242 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11243 This follows up to the 2011-05-06 change that substituted uintptr_t
11244 for EMACS_INT. This case wasn't caught back then.
11246 Rework Fformat to avoid integer overflow issues.
11247 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11248 now (part of C89). Include <verify.h>.
11249 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11250 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11251 (Fformat): Avoid the prepass trying to compute sizes; it was only
11252 approximate and thus did not catch overflow reliably. Instead, walk
11253 through the format just once, formatting and computing sizes as we go,
11254 checking for integer overflow at every step, and allocating a larger
11255 buffer as needed. Keep track separately whether the format is
11256 multibyte. Keep only the most-recently calculated precision, rather
11257 than them all. Record whether each argument has been converted to
11258 string. Use EMACS_INT, not int, for byte and char and arg counts.
11259 Support field widths and precisions larger than INT_MAX. Avoid
11260 sprintf's undefined behavior with conversion specifications such as %#d
11261 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11262 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11263 formatting out-of-range floating point numbers with int
11264 formats. (Bug#8668)
11266 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11268 * data.c: Avoid integer truncation in expressions involving floats.
11269 * data.c: Include <intprops.h>.
11270 (arith_driver): When there's an integer overflow in an expression
11271 involving floating point, convert the integers to floating point
11272 so that the resulting value does not suffer from catastrophic
11273 integer truncation. For example, on a 64-bit host (* 4
11274 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11275 Do not rely on undefined behavior after integer overflow.
11277 merge count_size_as_multibyte, parse_str_to_multibyte
11278 * character.c, character.h (count_size_as_multibyte):
11279 Rename from parse_str_to_multibyte; all uses changed.
11280 Check for integer overflow.
11281 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11282 since it's now a duplicate of the other. This is more of
11283 a character than a buffer op, so better that it's in character.c.
11284 * fns.c, print.c: Adjust to above changes.
11286 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11288 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11290 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11292 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11293 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11294 (x_clipboard_manager_save): Now static.
11295 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11297 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11298 (crypto_hash_function): Now static.
11299 Fix pointer signedness problems. Avoid unnecessary initializations.
11301 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11303 * termhooks.h (Vselection_alist): Make it terminal-local.
11305 * terminal.c (create_terminal): Initialize it.
11307 * xselect.c: Support for clipboard managers.
11308 (Vselection_alist): Move to termhooks.h as terminal-local var.
11309 (LOCAL_SELECTION): New macro.
11310 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11311 (symbol_to_x_atom): Remove gratuitous arg.
11312 (x_handle_selection_request, lisp_data_to_selection_data)
11313 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11314 (x_own_selection, x_get_local_selection, x_convert_selection):
11315 New arg, specifying work frame. Use terminal-local Vselection_alist.
11316 (some_frame_on_display): Delete unused function.
11317 (Fx_own_selection_internal, Fx_get_selection_internal)
11318 (Fx_disown_selection_internal, Fx_selection_owner_p)
11319 (Fx_selection_exists_p): New optional frame arg.
11320 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11321 (x_handle_selection_clear): Don't treat other terminals with the
11322 same keyboard specially. Use the terminal-local Vselection_alist.
11323 (x_clear_frame_selections): Use Frun_hook_with_args.
11325 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11327 * xterm.h: Add support for those atoms.
11329 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11331 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11332 (converted_selections, conversion_fail_tag): New global variables.
11333 (x_selection_request_lisp_error): Free the above.
11334 (x_get_local_selection): Remove unnecessary code.
11335 (x_reply_selection_request): Args changed; handle arbitrary array
11336 of converted selections stored in converted_selections.
11337 Separate the XChangeProperty and SelectionNotify steps.
11338 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11339 (x_convert_selection): New function.
11340 (x_handle_selection_event): Simplify.
11341 (x_get_foreign_selection): Don't ignore incoming requests while
11342 waiting for an answer; this will fail when we implement
11343 SAVE_TARGETS, and seems unnecessary anyway.
11344 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11345 (Vx_sent_selection_functions): Doc fix.
11347 2011-05-26 Leo Liu <sdl.web@gmail.com>
11349 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11351 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11353 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11355 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11356 for fringe update if it has periodic bitmap.
11357 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11358 and fringe_bitmap_periodic_p.
11360 * fringe.c (get_fringe_bitmap_data): New function.
11361 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11362 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11363 row. Mark glyph row for fringe update if periodicity changed.
11365 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11366 for fringe update unless it has periodic bitmap.
11368 2011-05-25 Kenichi Handa <handa@m17n.org>
11370 * xdisp.c (get_next_display_element): Set correct it->face_id for
11371 a static composition.
11373 2011-05-24 Leo Liu <sdl.web@gmail.com>
11376 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11378 * fns.c (crypto_hash_function, Fsha1): New function.
11379 (Fmd5): Use crypto_hash_function.
11380 (syms_of_fns): Add Ssha1.
11382 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11384 * gnutls.c: Remove unused macros.
11385 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11386 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11387 Remove macros that are defined and never used.
11388 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11390 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11392 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11393 (Fx_get_selection_internal): Minor cleanup.
11394 (Fx_own_selection_internal): Rename arguments for consistency with
11397 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11399 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11401 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11403 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11405 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11407 * dispnew.c (scrolling_window): Don't exclude the case that the
11408 last enabled row in the desired matrix touches the bottom boundary.
11410 2011-05-21 Glenn Morris <rgm@gnu.org>
11412 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11413 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11414 and add some more files.
11416 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11418 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11419 report_file_error introduced by the change from 2011-05-07.
11421 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11423 * systime.h (Time): Define only if emacs is defined.
11424 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11425 where the include path doesn't have X11/X.h by default. See
11426 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11428 2011-05-20 Kenichi Handa <handa@m17n.org>
11430 * composite.c (find_automatic_composition): Fix previous change.
11432 2011-05-20 Glenn Morris <rgm@gnu.org>
11434 * lisp.mk: New file, split from Makefile.in.
11435 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11436 (shortlisp): Remove.
11437 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11439 2011-05-19 Glenn Morris <rgm@gnu.org>
11441 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11442 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11443 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11444 (lisp): Set the order to that of loadup.el.
11445 (shortlisp): Make it a copy of $lisp.
11446 (SOME_MACHINE_LISP): Remove.
11447 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11448 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11450 2011-05-18 Kenichi Handa <handa@m17n.org>
11452 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11453 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11454 (find_automatic_composition): Mostly rewrite for efficiency.
11456 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11458 * makefile.w32-in: Update dependencies.
11460 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11462 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11463 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11465 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11467 Fix some integer overflow issues, such as string length overflow.
11469 * insdel.c (count_size_as_multibyte): Check for string overflow.
11471 * character.c (lisp_string_width): Check for string overflow.
11472 Use EMACS_INT, not int, for string indexes and lengths; in
11473 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11474 the resulting string length overflows an EMACS_INT; instead,
11475 report a string overflow if no precision given. When checking for
11476 precision exhaustion, use a check that cannot possibly have
11477 integer overflow. (Bug#8675)
11478 * character.h (lisp_string_width): Adjust to new signature.
11480 * alloc.c (string_overflow): New function.
11481 (Fmake_string): Use it. This doesn't change behavior, but saves
11482 a few bytes and will simplify future changes.
11483 * character.c (string_escape_byte8): Likewise.
11484 * lisp.h (string_overflow): New decl.
11486 Fixups, following up to the user-interface timestamp change.
11487 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11488 for UI timestamps, instead of unsigned long.
11489 * msdos.c (mouse_get_pos): Likewise.
11490 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11491 * w32gui.h (Time): Define by including "systime.h" rather than by
11492 declaring it ourselves. (Bug#8664)
11494 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11495 * image.c (clear_image_cache): Likewise.
11497 * term.c (term_mouse_position): Don't assume time_t wraparound.
11499 Be more systematic about user-interface timestamps.
11500 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11501 and sometimes 'EMACS_UINT', to represent these timestamps.
11502 This change causes it to use 'Time' uniformly, as that's what X uses.
11503 This makes the code easier to follow, and makes it easier to catch
11504 integer overflow bugs such as Bug#8664.
11505 * frame.c (Fmouse_position, Fmouse_pixel_position):
11506 Use Time, not unsigned long, for user-interface timestamps.
11507 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11508 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11509 * keyboard.h (last_event_timestamp): Likewise.
11510 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11511 * menu.h (xmenu_show): Likewise.
11512 * term.c (term_mouse_position): Likewise.
11513 * termhooks.h (struct input_event.timestamp): Likewise.
11514 (struct terminal.mouse_position_hook): Likewise.
11515 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11516 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11517 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11518 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11519 what it was before.
11520 * menu.h, termhooks.h: Include "systime.h", for Time.
11522 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11523 Don't assume that the difference between two unsigned long values
11524 can fit into an integer. At this point, we know button_down_time
11525 <= event->timestamp, so the difference must be nonnegative, so
11526 there's no need to cast the result if double-click-time is
11527 nonnegative, as it should be; check that it's nonnegative, just in
11528 case. This bug is triggered when events are more than 2**31 ms
11529 apart (about 25 days). (Bug#8664)
11531 * xselect.c (last_event_timestamp): Remove duplicate decl.
11532 (x_own_selection): Remove needless cast to unsigned long.
11534 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11535 that always fit in int. Use a sentinel instead of a counter, to
11536 avoid a temp and to allay GCC's concerns about possible int overflow.
11537 * frame.h (struct frame): Use int for menu_bar_items_used
11538 instead of EMACS_INT, since it always fits in int.
11540 * menu.c (grow_menu_items): Check for int overflow.
11542 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11544 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11545 Before, the code was not consistent. These values cannot exceed
11546 2**31 - 1 so there's no need to make them unsigned.
11547 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11548 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11549 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11551 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11553 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11554 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11555 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11556 presumably because the widths might not match.
11558 * window.c (size_window): Avoid needless test at loop start.
11560 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11562 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11564 2011-05-12 Drew Adams <drew.adams@oracle.com>
11566 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11568 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11570 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11571 `width' to `bar_area_x' and `bar_area_width', respectively.
11572 (x_scroll_run): Take account of fringe background extension.
11574 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11575 Rename local vars `left' and `width' to `bar_area_x' and
11576 `bar_area_width', respectively.
11577 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11578 background extension.
11580 2011-05-10 Jim Meyering <meyering@redhat.com>
11582 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11584 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11586 * image.c (Finit_image_library): Return t for built-in image types,
11587 like pbm and xbm. (Bug#8640)
11589 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11591 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11593 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11595 * w32console.c (Fset_screen_color): Doc fix.
11596 (Fget_screen_color): New function.
11597 (syms_of_ntterm): Defsubr it.
11599 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11600 unlink the temporary file if Fcall_process didn't create it in the
11602 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11603 child process will be redirected to a file specified with `:file'.
11604 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11605 cue to call_process_cleanup not to close that handle.
11607 2011-05-07 Ben Key <bkey76@gmail.com>
11609 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11610 one of two shell specific rules, either bootstrap-temacs-CMD or
11611 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11612 to the previous implementation of the bootstrap-temacs rule.
11613 The bootstrap-temacs-CMD rule is similar to the previous
11614 implementation of the bootstrap-temacs rule except that it
11615 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11618 These changes, along with some changes to nt/configure.bat,
11619 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11620 earlier fix to add support for --cflags and --ldflags options
11621 that include quotes so that it works whether make uses cmd or
11624 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11626 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11627 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11629 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11630 a string. Handle both cases.
11631 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11632 (Fdbus_register_method): Use Qinvalid_function.
11634 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11636 * makefile.w32-in: Update dependencies.
11637 (LISP_H): Add inttypes.h and stdin.h.
11638 (PROCESS_H): Add unistd.h.
11640 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11642 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11643 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11645 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11647 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11649 * term.c (vfatal): Remove stray call to va_end.
11650 It's not needed and the C Standard doesn't allow it here anyway.
11652 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11653 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11655 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11658 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11660 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11662 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11664 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11666 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11668 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11669 * charset.c (Fdefine_charset_internal): Don't initialize
11670 charset.code_space[15]. The value was garbage, on hosts with
11671 32-bit int (Bug#8600).
11673 * lread.c (read_integer): Be more consistent with string-to-number.
11674 Use string_to_number to do the actual conversion; this avoids
11675 rounding errors and fixes some other screwups. Without this fix,
11676 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11677 (digit_to_number): Move earlier, for benefit of read_integer.
11678 Return -1 if the digit is out of range for the base, -2 if it is
11679 not a digit in any supported base. (Bug#8602)
11681 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11683 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11684 to match comment at start of function. This also removes a
11685 GCC warning about overflow in a 32+64-bit port.
11687 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11689 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11690 Reported by Stefan Monnier in
11691 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11692 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11693 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11695 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11696 (EMACS_UINTPTR): Likewise, with uintptr_t.
11698 * lisp.h: Prefer 64-bit EMACS_INT if available.
11699 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11700 on 32-bit hosts that have 64-bit int, so that they can access
11702 However, temporarily disable this change unless the temporary
11703 symbol WIDE_EMACS_INT is defined.
11705 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11707 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11708 This removes an assumption that EMACS_INT and long are the same
11709 width as pointers. The assumption is true for Emacs porting targets
11710 now, but we want to make other targets possible.
11711 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11712 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11713 In the rest of the code, change types of integers that hold casted
11714 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11715 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11716 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11717 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11718 No need to cast type when ORing.
11719 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11720 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11721 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11722 assume EMACS_INT is the same width as char *.
11723 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11724 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11725 Remove no-longer-needed casts.
11726 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11727 (xg_tool_bar_help_callback, xg_make_tool_item):
11728 Use EMACS_INTPTR to hold an integer
11729 that will be cast to void *; this can avoid a GCC warning
11730 if EMACS_INT is not the same width as void *.
11731 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11732 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11733 (current_message_1, set_message_1):
11734 Use a local to convert to proper width without a cast.
11735 * xmenu.c (dialog_selection_callback): Likewise.
11737 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11738 Also, don't assume VALBITS / RAND_BITS is less than 5,
11739 and don't rely on undefined behavior when shifting a 1 left into
11741 * lisp.h (get_random): Change signature to match.
11743 * lread.c (hash_string): Use size_t, not int, for hash computation.
11744 Normally we prefer signed values; but hashing is special, because
11745 it's better to use unsigned division on hash table sizes so that
11746 the remainder is nonnegative. Also, size_t is the natural width
11747 for hashing into memory. The previous code used 'int', which doesn't
11748 retain enough info to hash well into very large tables.
11749 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11751 * dbusbind.c: Don't possibly lose pointer info when converting.
11752 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11753 Use XPNTR rather than XHASH, so that the high-order bits of
11754 the pointer aren't lost when converting through void *.
11756 * eval.c (Fautoload): Don't double-shift a pointer.
11758 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11760 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11762 * gnutls.c (DEF_GNUTLS_FN):
11763 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11765 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11767 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11770 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11772 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11773 New version that can reserve upto 2GB of heap space.
11775 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11777 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11779 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11781 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11782 `gnutls_certificate_set_x509_key_file'.
11784 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11786 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11787 Update dependencies.
11789 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11791 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11792 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11793 Remove unused parameter `fildes'.
11794 * process.c (read_process_output, send_process): Don't pass it.
11796 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11798 Fix previous change: the library cache is defined in w32.c.
11799 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11800 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11802 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11804 Implement dynamic loading of GnuTLS on Windows.
11806 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11807 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11808 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11811 * gnutls.c (Qgnutls_dll): Define.
11812 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11813 (gnutls_*): Declare function pointers.
11814 (init_gnutls_functions): New function to initialize function pointers.
11815 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11816 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11817 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11818 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11819 (emacs_gnutls_write, emacs_gnutls_read)
11820 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11821 (Fgnutls_available_p): New function.
11822 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11823 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11824 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11826 * image.c: Include w32.h.
11827 (Vimage_type_cache): Delete.
11828 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11829 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11830 (w32_delayed_load): Move to w32.c.
11832 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11834 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11835 (w32_delayed_load): Move from image.c. When loading a library, record
11836 its filename in the :loaded-from property of the library id.
11837 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11838 Initialize and staticpro them.
11839 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11841 * process.c: Include lisp.h before w32.h, not after.
11842 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11843 instead of gnutls_record_check_pending.
11845 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11847 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11849 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11850 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11853 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11855 * xterm.c (x_set_frame_alpha): Do not set property on anything
11856 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11858 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11860 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11862 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11864 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11865 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11866 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11867 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11868 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11869 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11870 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11871 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11872 (Qgnutls_bootprop_callbacks_verify): Make static.
11874 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11876 * callproc.c: Indentation fixup.
11878 * sysdep.c (wait_for_termination_1): Make static.
11879 (wait_for_termination, interruptible_wait_for_termination):
11880 Move after wait_for_termination_1.
11882 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11884 * sysdep.c (interruptible_wait_for_termination): New function
11885 which is like wait_for_termination, but allows keyboard
11888 * callproc.c (Fcall_process): Add (:file "file") as an option for
11890 (Fcall_process_region): Ditto.
11892 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11894 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11895 rather than `XVECTOR (FOO)->size'.
11897 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11898 inttypes.h, as a gnulib replacement is used if it not available in
11901 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11903 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11904 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11905 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11907 * coding.c (coding_alloc_by_realloc): Error out if destination
11908 will grow beyond MOST_POSITIVE_FIXNUM.
11909 (decode_coding_emacs_mule): Abort if there isn't enough place in
11910 charbuf for the composition carryover bytes. Reserve an extra
11911 space for up to 2 characters produced in a loop.
11912 (decode_coding_iso_2022): Abort if there isn't enough place in
11913 charbuf for the composition carryover bytes.
11915 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11917 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11918 aborting when %lld or %lll format is passed.
11919 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11920 %llo or %llx format is passed. (Bug#8545)
11922 * window.c (window_scroll_line_based): Use a marker instead of
11923 simple variables to record original value of point. (Bug#7952)
11925 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11926 produced by %s or %c overflows available buffer space. (Bug#8545)
11928 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11930 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11931 (SIZE_MAX): Move defn after all includes, as they might #define it.
11933 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11935 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11937 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11939 * keyboard.c (Qdelayed_warnings_hook): Define.
11940 (command_loop_1): Run `delayed-warnings-hook'
11941 if Vdelayed_warnings_list is non-nil.
11942 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11943 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11945 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11947 * doprnt.c (doprnt): Don't return value smaller than the buffer
11948 size if the message was truncated. (Bug#8545).
11950 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11952 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11953 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11955 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11957 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11959 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11961 * makefile.w32-in: Update dependencies.
11963 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11965 Improve `doprnt' and its usage. (Bug#8545)
11966 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11967 `format_end'. Remove support for %l as a conversion specifier.
11968 Don't use xrealloc. Improve diagnostics when the %l size modifier
11969 is used. Update the commentary.
11971 * eval.c (verror): Simplify calculation of size_t.
11973 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11976 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11978 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11981 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11983 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11984 This makes this file independent of the recent pseudovector change.
11986 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11988 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11990 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11991 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11992 Remove unused local.
11993 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11995 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11996 GCC 4.6.0 optimizes based on type-based alias analysis.
11997 For example, if b is of type struct buffer * and v of type struct
11998 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11999 != &v->size, and therefore "v->size = 1; b->size = 2; return
12000 v->size;" must therefore return 1. This assumption is incorrect
12001 for Emacs, since it type-puns struct Lisp_Vector * with many other
12002 types. To fix this problem, this patch adds a new type struct
12003 vectorlike_header that documents the constraints on layout of vectors
12004 and pseudovectors, and helps optimizing compilers not get fooled
12005 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12006 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
12007 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12009 (XSETPVECTYPE): Rewrite in terms of new macro.
12010 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12011 This is a bit clearer, and further avoids the possibility of
12012 undesirable aliasing.
12013 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
12014 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
12015 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12016 since Lisp_Subr is a special case (no "next" field).
12017 (ASIZE): Now uses header.size rather than size.
12018 All previous uses of XVECTOR (foo)->size replaced to use this macro,
12019 to avoid the hassle of writing XVECTOR (foo)->header.size.
12020 (struct vectorlike_header): New type.
12021 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12022 object, to help avoid aliasing.
12023 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12024 (SUBRP): Likewise, since Lisp_Subr is a special case.
12025 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12026 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12027 (struct Lisp_Hash_Table): Combine first two members into a single
12028 struct vectorlike_header member. All uses of "size" and "next" members
12029 changed to be "header.size" and "header.next".
12030 * buffer.h (struct buffer): Likewise.
12031 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12032 * frame.h (struct frame): Likewise.
12033 * process.h (struct Lisp_Process): Likewise.
12034 * termhooks.h (struct terminal): Likewise.
12035 * window.c (struct save_window_data, struct saved_window): Likewise.
12036 * window.h (struct window): Likewise.
12037 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12038 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12039 * buffer.c (init_buffer_once): Likewise.
12040 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12042 * process.c (Fformat_network_address): Use local var for size,
12045 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12047 Make the Lisp reader and string-to-float more consistent (Bug#8525)
12048 * data.c (atof): Remove decl; no longer used or needed.
12049 (digit_to_number): Move to lread.c.
12050 (Fstring_to_number): Use new string_to_number function, to be
12051 consistent with how the Lisp reader treats infinities and NaNs.
12052 Do not assume that floating-point numbers represent EMACS_INT
12053 without losing information; this is not true on most 64-bit hosts.
12054 Avoid double-rounding errors, by insisting on integers when
12055 parsing non-base-10 numbers, as the documentation specifies.
12056 * lisp.h (string_to_number): New decl, replacing ...
12057 (isfloat_string): Remove.
12058 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
12059 (read1): Do not accept +. and -. as integers; this
12060 appears to have been a coding error. Similarly, do not accept
12061 strings like +-1e0 as floating point numbers. Do not report
12062 overflow for integer overflows unless the base is not 10 which
12063 means we have no simple and reliable way to continue.
12064 Break out the floating-point parsing into a new
12065 function string_to_number, so that Fstring_to_number parses
12066 floating point numbers consistently with the Lisp reader.
12067 (digit_to_number): Move here from data.c. Make it static inline.
12068 (E_CHAR, EXP_INT): Remove, replacing with ...
12069 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12070 (string_to_number): New function, replacing isfloat_string.
12071 This function checks for valid syntax and produces the resulting
12072 Lisp float number too. Rework it so that string-to-number
12073 no longer mishandles examples like "1.0e+". Use strtoumax,
12074 so that overflow for non-base-10 numbers is reported only when
12075 there's no portable and simple way to convert to floating point.
12077 * textprop.c (set_text_properties_1): Rewrite for clarity,
12078 and to avoid GCC warning about integer overflow.
12080 * intervals.h (struct interval): Use EMACS_INT for members
12081 where EMACS_UINT might cause problems. See
12082 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12083 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12084 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12086 (offset_intervals): Tell GCC not to worry about length overflow
12087 when negating a negative length.
12089 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12090 (overrun_check_free): Likewise.
12092 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12093 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12096 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12097 (gnutls_make_error): Rename local to avoid shadowing.
12098 (gnutls_emacs_global_deinit): ifdef out; not used.
12099 (Fgnutls_boot): Use const for pointer to readonly storage.
12100 Comment out unused local. Fix pointer signedness problems.
12102 * lread.c (openp): Don't stuff size_t into an 'int'.
12103 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12104 about possible signed overflow.
12106 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12107 (GDK_KEY_g): Don't define if already defined.
12108 (xg_prepare_tooltip): Avoid pointer signedness problem.
12109 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12111 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12112 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12114 * xfns.c (Fx_window_property): Simplify a bit,
12115 to make a bit faster and to avoid GCC 4.6.0 warning.
12116 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12118 * fns.c (internal_equal): Don't assume size_t fits in int.
12120 * alloc.c (compact_small_strings): Tighten assertion a little.
12122 Replace pEd with more-general pI, and fix some printf arg casts.
12123 * lisp.h (pI): New macro, generalizing old pEd macro to other
12124 conversion specifiers. For example, use "...%"pI"d..." rather
12125 than "...%"pEd"...".
12126 (pEd): Remove. All uses replaced with similar uses of pI.
12127 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
12128 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12129 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12130 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12131 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12132 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12133 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12135 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12136 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12137 * print.c (safe_debug_print, print_object): Likewise.
12138 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12140 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12141 avoiding the 0 flag, which is not portable.
12142 * process.c (Fmake_network_process): Use pI to avoid cast.
12143 * region-cache.c (pp_cache): Likewise.
12144 * xdisp.c (decode_mode_spec): Likewise.
12145 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12146 behavior on 64-bit hosts with printf arg.
12147 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
12148 (x_stop_queuing_selection_requests): Likewise.
12149 (x_get_window_property): Don't truncate byte count to an 'int'
12152 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12153 here, since it parses constructs like leading '-' and spaces,
12154 which are not wanted; and it overflows with large numbers.
12155 Instead, simply match F[0-9]+, which is what is wanted anyway.
12157 * alloc.c: Remove unportable assumptions about struct layout.
12158 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12159 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12160 (allocate_vectorlike, make_pure_vector): Use the new macros,
12161 plus offsetof, to remove unportable assumptions about struct layout.
12162 These assumptions hold on all porting targets that I know of, but
12163 they are not guaranteed, they're easy to remove, and removing them
12164 makes further changes easier.
12166 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12167 This doesn't fix a bug but makes the code clearer.
12168 (string_overrun_cookie): Now const. Use initializers that
12169 don't formally overflow signed char, to avoid warnings.
12170 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12171 can cause Emacs to crash when string overrun checking is enabled.
12172 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12173 multiple of sizeof (EMACS_INT); it need not be, if
12174 alignof(EMACS_INT) < sizeof (EMACS_INT).
12175 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
12177 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
12179 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12181 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12183 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
12184 supposed to be handshaking. (Bug#8556)
12185 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12187 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12189 * lisp.h (Qdebug): List symbol.
12190 * eval.c (Qdebug): Restore global linkage.
12191 * keyboard.c (debug-on-event): New variable.
12192 (handle_user_signal): Break into debugger when debug-on-event
12193 matches the current signal symbol.
12195 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12197 * alloc.c (check_sblock, check_string_bytes)
12198 (check_string_free_list): Convert to standard C.
12200 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12202 * w32.c (emacs_gnutls_push): Fix typo.
12204 2011-04-25 Eli Zaretskii <eliz@gnu.org>
12206 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12207 "cast to pointer from integer of different size".
12209 Improve doprnt and its use in verror. (Bug#8545)
12210 * doprnt.c (doprnt): Document the set of format control sequences
12211 supported by the function. Use SAFE_ALLOCA instead of always
12214 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12215 is one byte too soon. Don't use xrealloc; instead xfree and
12218 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12220 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12223 * gnutls.c: Renamed global_initialized to
12224 gnutls_global_initialized. Added internals for the
12225 :verify-hostname-error, :verify-error, and :verify-flags
12226 parameters of `gnutls-boot' and documented those parameters in the
12227 docstring. Start callback support.
12228 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12229 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12230 on error. Return error code.
12231 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12232 (emacs_gnutls_read): Likewise.
12233 (Fgnutls_boot): Return handshake error code.
12234 (emacs_gnutls_handle_error): New function.
12235 (wsaerror_to_errno): Likewise.
12237 * w32.h (emacs_gnutls_pull): Add prototype.
12238 (emacs_gnutls_push): Likewise.
12240 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12241 (emacs_gnutls_push): Likewise.
12243 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12245 * process.c (wait_reading_process_output): Check if GnuTLS
12246 buffered some data internally if no FDs are set for TLS
12249 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12250 (LIBS): Link to USER_LIBS.
12251 ($(BLD)/gnutls.$(0)): New target.
12253 2011-04-24 Eli Zaretskii <eliz@gnu.org>
12255 * xdisp.c (handle_single_display_spec): Rename the
12256 display_replaced_before_p argument into display_replaced_p, to
12257 make it consistent with the commentary. Fix typos in the
12260 * textprop.c (syms_of_textprop): Remove dead code.
12261 (copy_text_properties): Delete obsolete commentary about an
12262 interface that was deleted long ago. Fix typos in the description
12265 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12266 to changes in oldXMenu/XMenu.h from 2011-04-16.
12267 <menu_help_message, prev_menu_help_message>: Constify.
12268 (IT_menu_make_room): menu->help_text is now `const char **';
12271 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12272 to changes in oldXMenu/XMenu.h from 2011-04-16.
12273 (struct XMenu): Declare `help_text' `const char **'.
12275 * xfaces.c <Qunspecified>: Make extern again.
12277 * syntax.c: Include sys/types.h before including regex.h, as
12280 * doc.c (get_doc_string): Improve the format passed to `error'.
12282 * doprnt.c (doprnt): Improve commentary.
12284 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12286 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12289 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12290 changes in globals.h immediately force recompilation.
12291 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12292 $(CURDIR)/s/ms-w32.h.
12293 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12295 * character.c (Fchar_direction): Function deleted.
12296 (syms_of_character): Don't defsubr it.
12297 <char-direction-table>: Deleted.
12299 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12301 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12302 * doprnt.c: Include limits.h.
12303 (SIZE_MAX): New macro.
12304 (doprnt): Return a size_t value. 2nd arg is now size_t.
12305 Many local variables are now size_t instead of int or unsigned.
12306 Improve overflow protection. Support `l' modifier for integer
12307 conversions. Support %l conversion. Don't assume an EMACS_INT
12308 argument for integer conversions and for %c.
12310 * lisp.h (doprnt): Restore prototype.
12312 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12313 $(SRC)/character.h.
12315 * Makefile.in (base_obj): Add back doprnt.o.
12317 * deps.mk (doprnt.o): Add back prerequisites.
12318 (callint.o): Depend on character.h.
12320 * eval.c (internal_lisp_condition_case): Include the handler
12321 representation in the error message.
12322 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12323 when breaking from the loop.
12325 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12327 * callint.c (Fcall_interactively): When displaying error message
12328 about invalid control letter, pass the character's codepoint, not
12329 a pointer to its multibyte form. Improve display of the character
12330 in octal and display also its hex code.
12332 * character.c (char_string): Use %x to display the (unsigned)
12333 codepoint of an invalid character, to avoid displaying a bogus
12336 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12337 `error', not SYMBOL_NAME itself.
12339 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12340 character arguments to `error'.
12342 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12343 to `error' in error message about FINAL_CHAR argument. Make sure
12344 FINAL_CHAR is a character, and use %c when it is passed as
12345 argument to `error'.
12347 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12349 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12351 * w32.c: Include <time.h>.
12352 (sys_localtime): New function.
12354 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12356 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12358 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12360 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12362 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12363 zombies (Bug#8467).
12365 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12367 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12368 gl_state.e_property when gl_state.object is Qt.
12370 * insdel.c (make_gap_larger): Remove limitation of buffer size
12373 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12375 * xdisp.c (lookup_glyphless_char_display)
12376 (produce_glyphless_glyph): Handle cons cell entry in
12377 glyphless-char-display.
12378 (Vglyphless_char_display): Document it.
12380 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12381 glyphless-char-display.
12383 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12385 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12387 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12389 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12390 definition for no-X builds.
12392 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12394 Static checks with GCC 4.6.0 and non-default toolkits.
12396 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12398 * process.c (keyboard_bit_set): Define only if SIGIO.
12399 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12400 (send_process): Repair possible setjmp clobbering.
12402 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12404 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12406 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12408 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12409 Define only if needed.
12411 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12412 by pacifying GCC about it. Maybe it's time to retire it?
12413 * xfaces.c (USG, __TIMEVAL__): Likewise.
12415 * dispextern.h (struct redisplay_interface): Rename param
12416 to avoid shadowing.
12417 * termhooks.h (struct terminal): Likewise.
12418 * xterm.c (xembed_send_message): Likewise.
12420 * insdel.c (make_gap_smaller): Define only if
12421 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12423 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12426 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12427 so that we aren't warned about unused symbols.
12429 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12431 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12433 * xfns.c (x_real_positions): Mark locals as initialized.
12435 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12437 * xterm.c: Fix problems found by static analysis with other toolkits.
12438 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12439 (x_dispatch_event): Declare static if USE_GTK, and
12440 define if USE_GTK || USE_X_TOOLKIT.
12441 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12442 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12443 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12444 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12446 * xmenu.c (menu_help_callback): Pointer type fixes.
12447 Use const pointers when pointing at readonly data. Avoid pointer
12448 signedness clashes.
12449 (FALSE): Remove unused macro.
12450 (update_frame_menubar): Remove unused decl.
12452 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12454 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12455 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12456 (single_menu_item): Rename local to avoid shadowing.
12458 * keyboard.c (make_lispy_event): Remove unused local var.
12460 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12461 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12463 * bitmaps: Change bitmaps from unsigned char back to the X11
12464 compatible char. Avoid the old compiler warnings about
12465 out-of-range initializers by using, for example, '\xab' rather
12468 * xgselect.c (xgselect_initialize): Check vs interface
12469 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12471 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12473 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12474 to read-only memory.
12476 * fns.c (vector): Remove; this old hack is no longer needed.
12478 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12480 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12482 * xrdb.c (x_load_resources): Omit unused local.
12484 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12485 (x_window): Rename locals to avoid shadowing.
12486 (USG): Use the kludged USG macro, to pacify gcc.
12488 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12489 (x_term_init): Remove local to avoid shadowing.
12491 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12493 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12494 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12496 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12498 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12500 Fix regex.c, syntax.c and friends for buffers > 2GB.
12501 * syntax.h (struct gl_state_s): Declare character position members
12504 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12506 * textprop.c (verify_interval_modification, interval_of):
12507 Declare arguments EMACS_INT.
12509 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12512 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12514 * indent.c (Fvertical_motion): Local variable it_start is now
12517 * regex.c (re_match, re_match_2, re_match_2_internal)
12518 (bcmp_translate, regcomp, regexec, print_double_string)
12519 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12520 (re_compile_pattern, re_exec): Declare arguments and local
12521 variables `size_t' and `ssize_t' and return values `regoff_t', as
12523 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12524 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12525 <compile_stack_type>: `size' and `avail' are now `size_t'.
12527 * regex.h <regoff_t>: Use ssize_t, not int.
12528 (re_search, re_search_2, re_match, re_match_2): Arguments that
12529 specify buffer/string position and length are now ssize_t and
12530 size_t. Return type is regoff_t.
12532 2011-04-16 Ben Key <bkey76@gmail.com>
12534 * nsfont.m: Fixed bugs in ns_get_family and
12535 ns_descriptor_to_entity that were caused by using free to
12536 deallocate memory blocks that were allocated by xmalloc (via
12537 xstrdup). This caused Emacs to crash when compiled with
12538 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12539 --enable-checking=xmallocoverrun). xfree is now used to
12540 deallocate these memory blocks.
12542 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12544 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12546 emacs_write: Accept and return EMACS_INT for sizes.
12547 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12549 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12550 Accept and return EMACS_INT.
12551 (emacs_gnutls_write): Return the number of bytes written on
12553 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12554 (emacs_read, emacs_write): Remove check for negative size, as the
12555 Emacs source code has been audited now.
12556 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12557 (emacs_read, emacs_write): Use it.
12558 * process.c (send_process): Adjust to the new signatures of
12559 emacs_write and emacs_gnutls_write. Do not attempt to store
12560 a byte offset into an 'int'; it might overflow.
12561 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12563 * sound.c: Don't assume sizes fit in 'int'.
12564 (struct sound_device.period_size, alsa_period_size):
12565 Return EMACS_INT, not int.
12566 (struct sound_device.write, vox_write, alsa_write):
12567 Accept EMACS_INT, not int.
12568 (wav_play, au_play): Use EMACS_INT to store sizes and to
12569 record read return values.
12571 2011-04-15 Ben Key <bkey76@gmail.com>
12573 * keyboard.c (Qundefined): Don't declare static since it is used
12575 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12576 static since they are used in nsfont.m.
12578 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12580 * process.c (Qprocessp): Don't declare static.
12581 * lisp.h (Qprocessp): Declare again.
12583 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12585 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12587 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12589 Improve C-level modularity by making more things 'static'.
12591 Don't publish debugger-only interfaces to other modules.
12592 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12593 (verify_bytepos, count_markers): Move decls to the only modules
12595 * region-cache.h (pp_cache): Likewise.
12596 * window.h (check_all_windows): Likewise.
12597 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12599 * sysdep.c (croak): Now static, if
12600 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12601 * syssignal.h (croak): Declare only if not static.
12603 * alloc.c (refill_memory_reserve): Now static if
12604 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12605 * lisp.h (refill_memory_reserve): Declare only if not static.
12607 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12608 Define only if USE_LUCID.
12610 * xrdb.c (x_customization_string, x_rm_string): Now static.
12612 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12613 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12615 * xdisp.c (draw_row_with_mouse_face): Now static.
12616 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12618 * window.h (check_all_windows): Mark externally visible.
12620 * window.c (window_deletion_count): Now static.
12622 * undo.c: Make symbols static if they're not exported.
12623 (last_undo_buffer, last_boundary_position, pending_boundary):
12626 * textprop.c (interval_insert_behind_hooks): Now static.
12627 (interval_insert_in_front_hooks): Likewise.
12629 * term.c: Make symbols static if they're not exported.
12630 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12631 (max_frame_lines, tty_set_terminal_modes):
12632 (tty_reset_terminal_modes, tty_turn_off_highlight):
12633 (get_tty_terminal): Now static.
12634 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12635 * termhooks.h (term_mouse_moveto): Do not declare if
12636 HAVE_WINDOW_SYSTEM.
12637 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12638 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12640 * sysdep.c: Make symbols static if they're not exported.
12641 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12643 (sigprocmask_set, full_mask): Remove; unused.
12644 (wait_debugging): Mark as visible.
12645 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12646 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12648 * syntax.c (syntax_temp): Define only if !__GNUC__.
12650 * sound.c (current_sound_device, current_sound): Now static.
12652 * search.c (searchbufs, searchbuf_head): Now static.
12654 * scroll.c (scroll_cost): Remove; unused.
12655 * dispextern.h (scroll_cost): Remove decl.
12657 * region-cache.h (pp_cache): Mark as externally visible.
12659 * process.c: Make symbols static if they're not exported.
12660 (process_tick, update_tick, create_process, chan_process):
12661 (Vprocess_alist, proc_buffered_char, datagram_access):
12662 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12663 (deactivate_process): Mark defn as static, as well as decl.
12664 * lisp.h (create_process): Remove decl.
12665 * process.h (chan_process, Vprocess_alist): Remove decls.
12667 * print.c: Make symbols static if they're not exported.
12668 (print_depth, new_backquote_output, being_printed, print_buffer):
12669 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12670 (print_interval, print_number_index, initial_stderr_stream):
12672 * lisp.h (Fprinc): Remove decl.
12673 (debug_output_compilation_hack): Mark as externally visible.
12675 * sysdep.c (croak): Move decl from here to syssignal.h.
12676 * syssignal.h (croak): Put it here, so the API can be checked when
12677 'croak' is called from dissociate_if_controlling_tty.
12679 * minibuf.c: Make symbols static if they're not exported.
12680 (minibuf_save_list, choose_minibuf_frame): Now static.
12681 * lisp.h (choose_minibuf_frame): Remove decl.
12683 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12685 * lread.c: Make symbols static if they're not exported.
12686 (read_objects, initial_obarray, oblookup_last_bucket_number):
12688 (make_symbol): Remove; unused.
12689 * lisp.h (initial_obarray, make_symbol): Remove decls.
12691 * keyboard.c: Make symbols static if they're not exported.
12692 (single_kboard, recent_keys_index, total_keys, recent_keys):
12693 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12694 (this_single_command_key_start, echoing, last_auto_save):
12695 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12696 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12697 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12698 (Vlispy_mouse_stem, double_click_count):
12700 (force_auto_save_soon): Define only if SIGDANGER.
12701 (ignore_mouse_drag_p): Now static if
12702 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12703 (print_help): Remove; unused.
12704 (stop_character, last_timer_event): Mark as externally visible.
12705 * keyboard.h (ignore_mouse_drag_p): Declare only if
12706 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12707 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12708 * lisp.h (echoing): Remove decl.
12709 (force_auto_save_soon): Declare only if SIGDANGER.
12710 * xdisp.c (redisplay_window): Simplify code, to make it more
12711 obvious that ignore_mouse_drag_p is not accessed if !defined
12712 USE_GTK && !defined HAVE_NS.
12714 * intervals.c: Make symbols static if they're not exported.
12715 (merge_properties_sticky, merge_interval_right, delete_interval):
12717 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12719 * insdel.c: Make symbols static if they're not exported.
12720 However, leave prepare_to_modify_buffer alone. It's never
12721 called from outside this function, but that appears to be a bug.
12722 (combine_after_change_list, combine_after_change_buffer):
12723 (adjust_after_replace, signal_before_change): Now static.
12724 (adjust_after_replace_noundo): Remove; unused.
12725 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12726 (signal_before_change): Remove decls.
12728 * indent.c (val_compute_motion, val_vmotion): Now static.
12730 * image.c: Make symbols static if they're not exported.
12731 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12733 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12734 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12736 * fringe.c (standard_bitmaps): Now static.
12737 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12739 * frame.c: Make symbols static if they're not exported.
12740 (x_report_frame_params, make_terminal_frame): Now static.
12741 (get_frame_param): Now static, unless HAVE_NS.
12742 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12743 (x_get_resource_string): Remove; not used.
12744 * frame.h (make_terminal_frame, x_report_frame_params):
12745 (x_get_resource_string); Remove decls.
12746 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12747 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12749 * font.c, fontset.c: Make symbols static if they're not exported.
12750 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12751 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12752 * font.c (font_close_object): Now static.
12753 * font.h (font_close_object): Remove.
12754 * fontset.c (FONTSET_OBJLIST): Remove.
12755 (free_realized_fontset) #if-0 the body, which does nothing.
12756 (face_suitable_for_char_p): #if-0, as it's never called.
12757 * fontset.h (face_suitable_for_char_p): Remove decl.
12758 * xfaces.c (face_at_string_position):
12759 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12760 since 0 is always ASCII.
12762 * fns.c (weak_hash_tables): Now static.
12764 * fileio.c: Make symbols static if they're not exported.
12765 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12766 (Vwrite_region_annotation_buffers): Now static.
12768 * eval.c: Make symbols static if they're not exported.
12769 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12770 * lisp.h (backtrace_list): Remove decl.
12772 * emacs.c: Make symbols static if they're not exported.
12773 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12774 (fatal_error_code, fatal_error_signal_hook, standard_args):
12776 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12777 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12778 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12779 * lisp.h (fatal_error_signal_hook): Remove decl.
12780 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12782 * editfns.c: Move a (normally-unused) function to its only use.
12783 * editfns.c, lisp.h (get_operating_system_release): Remove.
12784 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12785 worth the hassle of breaking this out.
12787 * xterm.c: Make symbols static if they're not exported.
12788 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12789 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12790 (x_destroy_window, x_delete_display):
12792 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12793 (x_mouse_leave): Remove; unused.
12794 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12795 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12796 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12798 (x_mouse_leave): Declare only if WINDOWSNT.
12799 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12800 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12803 * ftxfont.c: Make symbols static if they're not exported.
12804 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12806 * font.h (ftxfont_driver): Likewise.
12808 * xfns.c: Make symbols static if they're not exported.
12809 (x_last_font_name, x_display_info_for_name):
12810 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12811 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12812 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12813 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12814 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12815 (last_show_tip_args): Now static.
12816 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12817 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12818 (x_screen_planes): Remove; unused.
12819 * dispextern.h (x_screen_planes): Remove decl.
12821 * dispnew.c: Make symbols static if they're not exported.
12822 * dispextern.h (redraw_garbaged_frames, scrolling):
12823 (increment_row_positions): Remove.
12824 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12825 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12827 (redraw_garbaged_frames): Remove; unused.
12829 * xfaces.c: Make symbols static if they're not exported.
12830 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12832 * xterm.h (defined_color): Remove decls.
12833 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12834 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12835 (menu_face_changed_default, defined_color, free_realized_face):
12836 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12837 (ascii_face_of_lisp_face): Remove; unused.
12839 * xdisp.c: Make symbols static if they're not exported.
12840 * dispextern.h (scratch_glyph_row, window_box_edges):
12841 (glyph_to_pixel_coords, set_cursor_from_row):
12842 (get_next_display_element, set_iterator_to_next):
12843 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12844 (show_mouse_face): Remove decls
12845 * frame.h (message_buf_print): Likewise.
12846 * lisp.h (pop_message, set_message, check_point_in_composition):
12848 * xterm.h (set_vertical_scroll_bar): Likewise.
12849 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12850 (message_buf_print, scratch_glyph_row, displayed_buffer):
12851 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12852 (get_next_display_element, show_mouse_face, window_box_edges):
12853 (frame_to_window_pixel_xy, check_point_in_composition):
12854 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12855 (glyph_to_pixel_coords): Remove; unused.
12857 * dired.c (file_name_completion): Now static.
12859 * dbusbind.c (xd_in_read_queued_messages): Now static.
12861 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12862 * data.c (circular_list_error): Remove.
12864 * commands.h (last_point_position, last_point_position_buffer):
12865 (last_point_position_window): Remove decls.
12866 * keyboard.c: Make these variables static.
12868 * coding.h (coding, code_convert_region, encode_coding_gap):
12870 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12871 (iso_code_class, detect_coding, code_convert_region): Now static.
12872 (encode_coding_gap): Remove; unused.
12874 * chartab.c (chartab_chars, chartab_bits): Now static.
12876 * charset.h (charset_iso_8859_1): Remove decl.
12877 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12880 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12881 * ccl.c (Vccl_program_table): Now static.
12882 (check_ccl_update): Remove; unused.
12884 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12885 * category.h: ... from here.
12886 * category.c (check_category_table, set_category_set): Now static.
12888 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12889 * lisp.h: Remove these decls.
12891 * buffer.c (buffer_count): Remove unused var.
12893 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12894 so that it's not optimized away.
12895 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12896 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12897 exported only to the debugger.
12899 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12900 * atimer.h (run_all_atimers): Remove; not exported.
12902 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12903 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12904 was inaccessible from Lisp.
12905 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12906 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12908 alloc.c: Import and export fewer symbols, and remove unused items.
12909 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12911 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12912 it's not optimized away by whole-program optimization.
12913 (message_enable_multibyte, free_misc): Remove.
12914 (catchlist, handlerlist, mark_backtrace):
12915 Declare only if BYTE_MARK_STACK.
12916 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12917 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12918 (message_enable_multibyte): Remove decl.
12919 (free_misc, interval_free_list, float_block, float_block_index):
12920 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12921 (cons_free_list, last_marked_index):
12923 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12924 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12925 (mark_backtrace): Define only if BYTE_MARK_STACK.
12926 * xdisp.c (message_enable_multibyte): Now static.
12928 Declare Lisp_Object Q* variables to be 'static' if not exported.
12929 This makes it easier for human readers (and static analyzers)
12930 to see whether these variables are used from other modules.
12931 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12932 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12933 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12934 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12935 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12936 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12937 * xmenu.c, xselect.c:
12938 Declare Q* vars static if they are not used in other modules.
12939 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12940 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12941 Remove decls of unexported vars.
12942 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12944 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12946 Make Emacs functions such as Fatom 'static' by default.
12947 This makes it easier for human readers (and static analyzers)
12948 to see whether these functions can be called from other modules.
12949 DEFUN now defines a static function. To make the function external
12950 so that it can be used in other C modules, use the new macro DEFUE.
12951 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12952 (Finit_image_library):
12953 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12954 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12955 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12956 Remove decls, since these functions are now static.
12957 (Funintern, Fget_internal_run_time): New decls, since these functions
12958 were already external.
12960 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12961 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12962 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12963 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12964 * keyboard.c, keymap.c, lread.c:
12965 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12966 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12967 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12968 Mark functions with DEFUE instead of DEFUN,
12969 if they are used in other modules.
12970 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12971 decls for now-static functions.
12972 * buffer.h (Fdelete_overlay): Remove decl.
12973 * callproc.c (Fgetenv_internal): Mark as internal.
12974 * composite.c (Fremove_list_of_text_properties): Remove decl.
12975 (Fcomposition_get_gstring): New forward static decl.
12976 * composite.h (Fcomposite_get_gstring): Remove decl.
12977 * dired.c (Ffile_attributes): New forward static decl.
12978 * doc.c (Fdocumntation_property): New forward static decl.
12979 * eval.c (Ffetch_bytecode): New forward static decl.
12980 (Funintern): Remove extern decl; now in .h file where it belongs.
12981 * fileio.c (Fmake_symbolic_link): New forward static decl.
12982 * image.c (Finit_image_library): New forward static decl.
12983 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12984 * intervals.h (Fprevious_property_change):
12985 (Fremove_list_of_text_properties): Remove decls.
12986 * keyboard.c (Fthis_command_keys): Remove decl.
12987 (Fcommand_execute): New forward static decl.
12988 * keymap.c (Flookup_key): New forward static decl.
12989 (Fcopy_keymap): Now static.
12990 * keymap.h (Flookup_key): Remove decl.
12991 * process.c (Fget_process): New forward static decl.
12992 (Fprocess_datagram_address): Mark as internal.
12993 * syntax.c (Fsyntax_table_p): New forward static decl.
12994 (skip_chars): Remove duplicate decl.
12995 * textprop.c (Fprevious_property_change): New forward static decl.
12996 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12998 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12999 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13001 * editfns.c (Fformat): Remove unreachable code.
13003 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13005 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13008 2011-04-13 Eli Zaretskii <eliz@gnu.org>
13010 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13011 when at ZV. (Bug#8487)
13013 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13015 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13017 * keyboard.c (parse_tool_bar_item): Likewise.
13018 * sound.c (sound_cleanup, alsa_close): Likewise.
13019 * termcap.c (tgetent): Likewise.
13020 * xfns.c (x_default_font_parameter): Likewise.
13021 * xsettings.c (read_and_apply_settings): Likewise.
13023 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13024 (overrun_check_free): Protoize.
13026 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13028 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13029 since callers should never pass a negative size.
13030 Change the signature to match that of plain 'read' and 'write'; see
13031 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13032 * lisp.h: Update prototypes of emacs_write and emacs_read.
13034 2011-04-11 Eli Zaretskii <eliz@gnu.org>
13036 * xdisp.c (redisplay_window): Don't try to determine the character
13037 position of the scroll margin if the window start point w->startp
13038 is outside the buffer's accessible region. (Bug#8468)
13040 2011-04-10 Eli Zaretskii <eliz@gnu.org>
13042 Fix write-region and its subroutines for buffers > 2GB.
13043 * fileio.c (a_write, e_write): Modify declaration of arguments and
13044 local variables to support buffers larger than 2GB.
13045 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13047 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13048 argument, local variables, and return value.
13050 * lisp.h: Update prototypes of emacs_write and emacs_read.
13052 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13054 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
13056 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13058 Fix more problems found by GCC 4.6.0's static checks.
13060 * xdisp.c (vmessage): Use a better test for character truncation.
13062 * charset.c (load_charset_map): <, not <=, for optimization,
13063 and to avoid potential problems with integer overflow.
13064 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
13065 * casetab.c (set_identity, shuffle): Likewise.
13066 * editfns.c (Fformat): Likewise.
13067 * syntax.c (skip_chars): Likewise.
13069 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13070 This also lets GCC 4.6.0 generate slightly better loop code.
13072 * callint.c (Fcall_interactively): <, not <=, for optimization.
13073 (Fcall_interactively): Count the number of arguments produced,
13074 not the number of arguments given. This is simpler and lets GCC
13075 4.6.0 generate slightly better code.
13077 * ftfont.c: Distingish more carefully between FcChar8 and char.
13078 The previous code passed unsigned char * to a functions like
13079 strlen and xstrcasecmp that expect char *, which does not
13080 conform to the C standard.
13081 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13082 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13083 char * when the C standard requires it.
13085 * keyboard.c (read_char): Remove unused var.
13087 * eval.c: Port to Windows vsnprintf (Bug#8435).
13088 Include <limits.h>.
13089 (SIZE_MAX): Define if the headers do not.
13090 (verror): Do not give up if vsnprintf returns a negative count.
13091 Instead, grow the buffer. This ports to Windows vsnprintf, which
13092 does not conform to C99. Problem reported by Eli Zaretskii.
13093 Also, simplify the allocation scheme, by avoiding the need for
13094 calling realloc, and removing the ALLOCATED variable.
13096 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13098 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13099 But keep the doprint source code for now, as we might revamp it
13100 and use it again (Bug#8435).
13101 * lisp.h (doprnt): Remove.
13102 * Makefile.in (base_obj): Remove doprnt.o.
13103 * deps.mk (doprnt.o): Remove.
13105 error: Print 32- and 64-bit integers portably (Bug#8435).
13106 Without this change, on typical 64-bit hosts error ("...%d...", N)
13107 was used to print both 32- and 64-bit integers N, which relied on
13108 undefined behavior.
13109 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
13110 * lisp.h (error, verror): Mark as printf-like functions.
13111 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13112 Report overflow in size calculations when allocating printf buffer.
13113 Do not truncate output string at its first null byte.
13114 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13115 Truncate the output at a character boundary, since vsnprintf does not
13117 * charset.c (check_iso_charset_parameter): Convert internal
13118 character to string before calling 'error', since %c now has the
13120 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13121 overflow when computing char to be passed to 'error'. Do not
13122 pass Lisp_Object to 'error'; pass the integer instead.
13123 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13124 formatted with plain %d.
13126 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13128 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13130 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13132 * xterm.c (x_catch_errors): Remove duplicate declaration.
13134 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13136 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13138 2011-04-10 Jim Meyering <meyering@redhat.com>
13140 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13141 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13142 return ssize_t not "int", and use size_t as the buffer length.
13143 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13144 * gnutls.h: Update declarations.
13145 * process.c (read_process_output): Use ssize_t, to match.
13146 (send_process): Likewise.
13148 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13150 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13152 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13154 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13155 Use unsigned char, to match FcChar8 type definition.
13157 * xterm.c (handle_one_xevent):
13158 * xmenu.c (create_and_show_popup_menu):
13159 * xselect.c (x_decline_selection_request)
13160 (x_reply_selection_request): Avoid type-punned deref of X events.
13162 2011-04-09 Eli Zaretskii <eliz@gnu.org>
13164 Fix some uses of `int' instead of EMACS_INT.
13165 * search.c (string_match_1, fast_string_match)
13166 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13167 (scan_buffer, find_next_newline_no_quit)
13168 (find_before_next_newline, search_command, Freplace_match)
13169 (Fmatch_data): Make some `int' variables be EMACS_INT.
13171 * xdisp.c (display_count_lines): 3rd argument and return value now
13172 EMACS_INT. All callers changed.
13173 (pint2hrstr): Last argument is now EMACS_INT.
13175 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13176 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13177 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13178 (decode_coding_utf_16, decode_coding_emacs_mule)
13179 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13180 (decode_coding_ccl, decode_coding_charset)
13181 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13182 (decode_coding_iso_2022, decode_coding_emacs_mule)
13183 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13184 <char_offset, last_offset>: Declare EMACS_INT.
13185 (encode_coding_utf_8, encode_coding_utf_16)
13186 (encode_coding_emacs_mule, encode_invocation_designation)
13187 (encode_designation_at_bol, encode_coding_iso_2022)
13188 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13189 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13191 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13192 (encode_invocation_designation): Last argument P_NCHARS is now
13194 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13195 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13197 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13200 * ccl.c (Fccl_execute_on_string): Declare some variables
13203 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
13205 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13207 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13209 * process.c (Fformat_network_address): Doc fix.
13211 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13213 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
13215 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
13217 * keyboard.c (read_char): Call Lisp function help-form-show,
13218 instead of using internal_with_output_to_temp_buffer.
13219 (Qhelp_form_show): New var.
13220 (syms_of_keyboard): Use DEFSYM macro.
13222 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13224 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13226 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
13228 * process.c (Flist_processes): Remove to Lisp.
13229 (list_processes_1): Delete.
13231 2011-04-06 Eli Zaretskii <eliz@gnu.org>
13233 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13235 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13237 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13239 Fix more problems found by GCC 4.6.0's static checks.
13241 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13243 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13245 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
13247 * xdisp.c (vmessage): Mark as a printf-like function.
13249 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13251 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13253 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13254 printf-like functions.
13255 (tiff_load): Add casts to remove these marks before passing them
13256 to system-supplied API.
13258 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13260 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13261 This avoids several warnings with gcc -Wstrict-overflow.
13262 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13263 directly, rather than having caller test rule sign. This avoids
13264 some unnecessary tests.
13265 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13266 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13267 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
13269 * xfont.c (xfont_text_extents): Remove var that was set but not used.
13270 (xfont_open): Avoid unnecessary tests.
13272 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13274 * composite.h, composite.c (composition_gstring_put_cache):
13275 Use EMACS_INT, not int, for length.
13277 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13278 breaking out part of COMPOSITION_DECODE_RULE.
13279 (COMPOSITION_DECODE_RULE): Use it.
13280 * composite.c (get_composition_id): Remove unused local vars,
13281 by using the new macro.
13283 * textprop.c (set_text_properties_1): Change while to do-while,
13284 since the condition is always true at first.
13286 * intervals.c (graft_intervals_into_buffer): Mark var as used.
13287 (interval_deletion_adjustment): Return unsigned value.
13290 * process.c (list_processes_1, create_pty, read_process_output):
13291 (exec_sentinel): Remove vars that were set but not used.
13292 (create_pty): Remove unnecessary "volatile"s.
13293 (Fnetwork_interface_info): Avoid possibility of int overflow.
13294 (read_process_output): Do adaptive read buffering even if carryover.
13295 (read_process_output): Simplify nbytes computation if buffered.
13297 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13299 * syntax.c (scan_words): Remove var that was set but not used.
13300 (update_syntax_table): Use unsigned instead of int.
13302 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13303 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13304 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13306 * print.c (print_error_message): Avoid int overflow.
13308 * font.c (font_list_entities): Redo for clarity,
13309 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13311 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13312 (font_score): Avoid potential overflow in diff calculation.
13314 * fns.c (substring_both): Remove var that is set but not used.
13315 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13317 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13319 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13320 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13321 can always succeed if overflow has undefined behavior.
13323 * search.c (boyer_moore, wordify): Remove vars set but not used.
13324 (wordify): Omit three unnecessary tests.
13326 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13327 All callers changed. This avoids the need for an unused var.
13329 * casefiddle.c (casify_region): Remove var that is set but not used.
13331 * dired.c (file_name_completion): Remove var that is set but not used.
13333 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13335 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13336 (Finsert_file_contents): Remove unnecessary code checking fd.
13338 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13339 Check for integer overflow on size calculations.
13341 * buffer.c (Fprevious_overlay_change): Remove var that is set
13344 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13345 Remove vars that are set but not used.
13346 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13347 (timer_check_2): Mark vars as initialized.
13349 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13351 * image.c (lookup_image): Remove var that is set but not used.
13352 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13354 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13355 that are set but not used.
13357 * xfns.c (make_invisible_cursor): Don't return garbage
13358 if XCreateBitmapFromData fails (Bug#8410).
13360 * xselect.c (x_get_local_selection, x_handle_property_notify):
13361 Remove vars that are set but not used.
13363 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13364 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13366 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13367 Remove var that is set but not used.
13368 (scroll_bar_windows_size): Now size_t, not int.
13369 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13370 Check for overflow.
13372 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13373 (map_tty_color) [!defined MSDOS]: Likewise.
13375 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13377 * coding.c: Remove vars that are set but not used.
13378 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13379 All callers changed.
13380 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13381 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13382 (decode_coding_charset): Remove vars that are set but not used.
13384 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13385 that is set but not used.
13387 * print.c (print_object): Remove var that is set but not used.
13389 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13390 The gnulib version avoids calling malloc in the usual case,
13391 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13392 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13393 * filelock.c (current_lock_owner): Likewise.
13394 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13395 * sysdep.c: Include allocator.h, careadlinkat.h.
13396 (emacs_no_realloc_allocator): New static constant.
13397 (emacs_readlink): New function.
13398 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13399 ../lib/careadlinkat.h.
13401 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13403 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13404 first non-nil return value).
13406 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13408 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13409 if not defined (Bug#8403).
13411 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13413 * xdisp.c (display_count_lines): Remove parameter `start',
13414 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13415 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13416 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13417 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13418 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13419 and thereabouts. All callers changed.
13420 (get_per_char_metric): Remove parameter `f', unused since
13421 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13423 2011-04-02 Jim Meyering <meyering@redhat.com>
13425 do not dereference NULL upon failed strdup
13426 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13427 (ns_get_family): Likewise.
13429 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13431 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13433 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13435 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13438 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13440 Add lexical binding.
13442 * window.c (Ftemp_output_buffer_show): New fun.
13443 (Fsave_window_excursion):
13444 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13446 * lread.c (lisp_file_lexically_bound_p): New function.
13447 (Fload): Bind Qlexical_binding.
13448 (readevalloop): Remove `evalfun' arg.
13449 Bind Qinternal_interpreter_environment.
13450 (Feval_buffer): Bind Qlexical_binding.
13451 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13453 (syms_of_lread): Declare `lexical-binding'.
13455 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13457 * keyboard.c (eval_dyn): New fun.
13458 (menu_item_eval_property): Use it.
13460 * image.c (parse_image_spec): Use Ffunctionp.
13462 * fns.c (concat, mapcar1): Accept byte-code-functions.
13464 * eval.c (Fsetq): Handle lexical vars.
13465 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13466 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13467 (FletX, Flet): Obey lexical binding.
13468 (Fcommandp): Handle closures.
13469 (Feval): New `lexical' arg.
13470 (eval_sub): New function extracted from Feval. Use it almost
13471 everywhere where Feval was used. Look up vars in lexical env.
13473 (Ffunctionp): Move from subr.el.
13474 (Ffuncall): Handle closures.
13475 (apply_lambda): Remove `eval_flags'.
13476 (funcall_lambda): Handle closures and new byte-code-functions.
13477 (Fspecial_variable_p): New function.
13478 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13479 but without exporting it to Lisp.
13481 * doc.c (Fdocumentation, store_function_docstring):
13482 * data.c (Finteractive_form): Handle closures.
13484 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13487 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13489 (exec_byte_code): New function extracted from Fbyte_code to handle new
13490 calling convention for byte-code-functions. Add new byte-codes.
13492 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13494 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13496 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13498 * xdisp.c (redisplay_internal): Fix prototype.
13500 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13502 * xdisp.c (SCROLL_LIMIT): New macro.
13503 (try_scrolling): Use it when setting scroll_limit.
13504 Limit scrolling to 100 screen lines.
13505 (redisplay_window): Even when falling back on "recentering",
13506 position point in the window according to scroll-conservatively,
13507 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13509 (try_scrolling): When point is above the window, allow searching
13510 as far as scroll_max, or one screenful, to compute vertical
13511 distance from PT to the scroll margin position. This prevents
13512 try_scrolling from unnecessarily failing when
13513 scroll-conservatively is set to a value slightly larger than the
13514 window height. Clean up the case of PT below the margin at bottom
13515 of window: scroll_max can no longer be INT_MAX. When aggressive
13516 scrolling is in use, don't let point enter the opposite scroll
13517 margin as result of the scroll.
13518 (syms_of_xdisp) <scroll-conservatively>: Document the
13519 threshold of 100 lines for never-recentering scrolling.
13521 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13523 * dispextern.h (move_it_by_lines):
13524 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13525 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13526 (message_log_check_duplicate): Remove parameters `prev_bol' and
13527 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13528 (redisplay_internal): Remove parameter `preserve_echo_area',
13529 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13531 * indent.c (Fvertical_motion):
13532 * window.c (window_scroll_pixel_based, Frecenter):
13533 Don't pass `need_y_p' to `move_it_by_lines'.
13535 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13537 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13538 steal a few bits to be more compact.
13539 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13540 Remove unneeded casts.
13542 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13544 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13546 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13547 binding" message (bug#7967).
13549 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13551 Fix more problems found by GCC 4.6.0's static checks.
13553 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13554 Remove unused local var.
13556 * editfns.c (Fmessage_box): Remove unused local var.
13558 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13559 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13560 Omit unused local vars.
13561 * window.c (shrink_windows): Omit unused local var.
13562 * menu.c (digest_single_submenu): Omit unused local var.
13563 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13564 Omit unused local var.
13566 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13567 Don't assume string length fits in int.
13568 (keyremap_step, read_key_sequence): Use size_t for sizes.
13569 (read_key_sequence): Don't check last_real_key_start redundantly.
13571 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13572 instead of alloca (Bug#8344).
13574 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13575 (Fbacktrace_frame): Don't assume nframes fits in int.
13577 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13579 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13582 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13584 * cm.c (calccost): Turn while-do into do-while, for clarity.
13586 * keyboard.c (syms_of_keyboard): Use the same style as later
13587 in this function when indexing through an array. This also
13588 works around GCC bug 48267.
13590 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13592 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13594 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13595 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13597 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13598 This avoids undefined behavior on integer overflow, and is a bit
13599 more convenient anyway since it is compared to a size_t variable.
13601 Variadic C functions now count arguments with size_t, not int.
13602 This avoids an unnecessary limitation on 64-bit machines, which
13603 caused (substring ...) to crash on large vectors (Bug#8344).
13604 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13605 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13606 All variadic functions and their callers changed accordingly.
13607 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13608 * data.c (arith_driver, float_arith_driver): Likewise.
13609 * editfns.c (general_insert_function): Likewise.
13610 * eval.c (struct backtrace.nargs, interactive_p)
13611 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13612 (funcall_lambda, mark_backtrace): Likewise.
13613 * fns.c (concat): Likewise.
13614 * frame.c (x_set_frame_parameters): Likewise.
13615 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13616 0 if not found, not -1. All callers changed.
13618 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13619 (stack_copy_size): Now size_t, not int.
13620 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13622 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13624 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13625 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13626 All callers changed.
13628 * lisp.h (multibyte_char_to_unibyte):
13629 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13630 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13631 * character.h (CHAR_TO_BYTE8):
13632 * cmds.c (internal_self_insert):
13633 * editfns.c (general_insert_function):
13634 * keymap.c (push_key_description):
13635 * search.c (Freplace_match):
13636 * xdisp.c (message_dolog, set_message_1): All callers changed.
13638 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13640 * keyboard.c (safe_run_hook_funcall): New function.
13641 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13642 don't set the hook to nil, but remove the offending function instead.
13643 (Qcommand_hook_internal): Remove, unused.
13644 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13645 Vcommand_hook_internal.
13647 * eval.c (enum run_hooks_condition): Remove.
13648 (funcall_nil, funcall_not): New functions.
13649 (run_hook_with_args): Call each function through a `funcall' argument.
13650 Remove `cond' argument, now redundant.
13651 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13652 (Frun_hook_with_args_until_failure): Adjust accordingly.
13653 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13655 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13657 * dispextern.h (string_buffer_position): Remove declaration.
13659 * print.c (strout): Remove parameter `multibyte', unused since
13660 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13662 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13663 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13664 All callers changed.
13666 * w32.c (_wsa_errlist): Use braces for struct initializers.
13668 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13669 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13670 All callers changed.
13671 (string_buffer_position): Likewise. Also, make static (it's never
13672 used outside xdisp.c).
13673 (cursor_row_p): Remove parameter `w', unused since
13674 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13675 (decode_mode_spec): Remove parameter `precision', introduced during
13676 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13677 All callers changed.
13679 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13681 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13683 2011-03-27 Anders Lindgren <andlind@gmail.com>
13685 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13686 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13687 (ns_update_auto_hide_menu_bar): New functions.
13688 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13689 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13690 ns_constrain_all_frames.
13691 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13692 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13694 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13696 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13698 2011-03-27 Glenn Morris <rgm@gnu.org>
13700 * syssignal.h: Replace RETSIGTYPE with void.
13701 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13702 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13703 Replace SIGTYPE with void everywhere.
13704 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13705 * s/template.h (SIGTYPE): Remove commented out definition.
13707 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13709 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13710 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13712 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13714 * w32.c (read_unc_volume): Use parameter `henum', instead of
13715 global variable `wget_enum_handle'.
13717 * keymap.c (describe_vector): Remove parameters `indices' and
13718 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13719 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13721 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13723 * keyboard.c (timer_check): Remove parameter `do_it_now',
13724 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13725 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13726 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13728 * keyboard.c (read_char):
13729 * w32menu.c (w32_menu_display_help):
13730 * xmenu.c (show_help_event, menu_help_callback):
13731 Adjust calls to `show_help_echo'.
13733 * gtkutil.c (xg_maybe_add_timer):
13734 * keyboard.c (readable_events):
13735 * process.c (wait_reading_process_output):
13736 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13738 * insdel.c (adjust_markers_gap_motion):
13739 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13740 (gap_left, gap_right): Don't call it.
13742 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13744 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13745 incurred during fontification.
13747 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13749 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13750 (DEFVAR_PER_BUFFER): Don't pass it.
13752 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13753 (scrolling_window): Don't pass it.
13755 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13757 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13759 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13761 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13762 of variables specific to SELinux and computation of `encoded_absname'.
13764 * image.c (XPutPixel): Remove unused variable `height'.
13766 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13768 * unexw32.c (get_section_info): Remove unused variable `section'.
13770 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13771 (system_process_attributes): Remove unused variable `sess'.
13772 (sys_read): Remove unused variable `err'.
13774 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13775 (w32_wnd_proc): Remove unused variable `isdead'.
13776 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13777 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13778 (x_create_tip_frame): Remove unused variable `tem'.
13780 * w32inevt.c (w32_console_read_socket):
13781 Remove unused variable `no_events'.
13783 * w32term.c (x_draw_composite_glyph_string_foreground):
13784 Remove unused variable `width'.
13786 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13788 * w32term.c (x_set_glyph_string_clipping):
13789 Don't pass uninitialized region to CombineRgn.
13791 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13793 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13794 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13795 (Fx_close_connection): Remove unused variable `i'.
13797 * w32font.c (w32font_draw): Return number of glyphs.
13798 (w32font_open_internal): Remove unused variable `i'.
13799 (w32font_driver): Add missing initializer.
13801 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13802 (fill_in_menu): Remove unused variable `items_added'.
13804 * w32term.c (last_mouse_press_frame): Remove static global variable.
13805 (w32_clip_to_row): Remove unused variable `f'.
13806 (x_delete_terminal): Remove unused variable `i'.
13808 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13809 (NOTHING): Remove unused static global variable.
13810 (uniscribe_check_otf): Remove unused variable `table'.
13811 (uniscribe_font_driver): Add missing initializers.
13813 2011-03-23 Julien Danjou <julien@danjou.info>
13815 * term.c (Fsuspend_tty, Fresume_tty):
13816 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13817 * window.c (temp_output_buffer_show):
13818 * insdel.c (signal_before_change):
13819 * frame.c (Fhandle_switch_frame):
13820 * fileio.c (Fdo_auto_save):
13821 * emacs.c (Fkill_emacs):
13822 * editfns.c (save_excursion_restore):
13823 * cmds.c (internal_self_insert):
13824 * callint.c (Fcall_interactively):
13825 * buffer.c (Fkill_all_local_variables):
13826 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13828 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13829 unconditionally since it does the check itself.
13831 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13833 Fix more problems found by GCC 4.5.2's static checks.
13835 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13836 the first time through the loop, since we know p0 < p1 then.
13837 This also avoids a gcc -Wstrict-overflow warning.
13839 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13840 leading to a memory leak, possible in functions like
13841 load_charset_map_from_file that can allocate an unbounded number
13842 of objects (Bug#8318).
13844 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13845 that could (at least in theory) be that large.
13847 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13848 This is less likely to overflow, and avoids undefined behavior if
13849 overflow does occur. All callers changed. Use strtoul to scan
13850 for the unsigned long integer.
13851 (pint2hrstr): Simplify and tune code slightly.
13852 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13854 * scroll.c (do_scrolling): Work around GCC bug 48228.
13855 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13857 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13858 This also avoids a warning with gcc -Wstrict-overflow.
13859 (validate_x_resource_name): Simplify count usage.
13860 This also avoids a warning with gcc -Wstrict-overflow.
13862 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13865 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13867 * process.c (Fmake_network_process): Use socklen_t, not int,
13868 where POSIX says socklen_t is required in portable programs.
13869 This fixes a porting bug on hosts like 64-bit HP-UX, where
13870 socklen_t is wider than int (Bug#8277).
13871 (Fmake_network_process, server_accept_connection):
13872 (wait_reading_process_output, read_process_output):
13875 * process.c: Rename or move locals to avoid shadowing.
13876 (list_processes_1, Fmake_network_process):
13877 (read_process_output_error_handler, exec_sentinel_error_handler):
13878 Rename or move locals.
13879 (Fmake_network_process): Define label "retry_connect" only if needed.
13880 (Fnetwork_interface_info): Fix pointer signedness.
13881 (process_send_signal): Add cast to avoid pointer signedness problem.
13882 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13883 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13885 Make tparam.h and terminfo.c consistent.
13886 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13887 Include tparam.h instead, since it declares them.
13888 * cm.h (PC): Remove extern decl; tparam.h now does this.
13889 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13890 * terminfo.c: Include tparam.h, to check interfaces.
13891 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13892 (tparam): Adjust signature to match interface in tparam.h;
13893 this removes some undefined behavior. Check that outstring and len
13894 are zero, which they always are with Emacs.
13895 * tparam.h (PC, BC, UP): New extern decls.
13897 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13898 (xftfont_open): Rename locals to avoid shadowing.
13900 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13901 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13902 (OTF_TAG_SYM): Omit macro if not needed.
13903 (ftfont_list): Remove unused local.
13904 (get_adstyle_property, ftfont_pattern_entity):
13905 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13906 Rename locals to avoid shadowing.
13908 * xfont.c (xfont_list_family): Mark var as initialized.
13910 * xml.c (make_dom): Now static.
13912 * composite.c (composition_compute_stop_pos): Rename local to
13914 (composition_reseat_it): Remove unused locals.
13915 (find_automatic_composition, composition_adjust_point): Likewise.
13916 (composition_update_it): Mark var as initialized.
13917 (find_automatic_composition): Mark vars as initialized,
13918 with a FIXME (Bug#8290).
13920 character.h: Rename locals to avoid shadowing.
13921 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13922 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13923 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13924 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13925 to avoid shadowing.
13927 * textprop.c (property_change_between_p): Remove; unused.
13929 * intervals.c (interval_start_pos): Now static.
13931 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13933 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13934 Rename locals to avoid shadowing.
13936 * sound.c (wav_play, au_play, Fplay_sound_internal):
13937 Fix pointer signedness.
13938 (alsa_choose_format): Remove unused local var.
13939 (wav_play): Initialize a variable to 0, to prevent undefined
13940 behavior (Bug#8278).
13942 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13944 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13946 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13947 clobbering (Bug#8298).
13948 * sysdep.c (sys_subshell): Likewise.
13949 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13951 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13952 This should get cleaned up, so that child_setup has the
13953 same signature on all platforms.
13955 * callproc.c (call_process_cleanup): Now static.
13956 (relocate_fd): Rename locals to avoid shadowing.
13958 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13960 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13961 not to be necessary, and produces flickering.
13963 2011-03-20 Glenn Morris <rgm@gnu.org>
13965 * config.in: Remove file.
13967 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13969 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13970 are now in src/globals.h.
13971 (syms_of_minibuf): Remove spurious & from previous change.
13973 2011-03-20 Leo Liu <sdl.web@gmail.com>
13975 * minibuf.c (completing-read-function): New variable.
13976 (completing-read-default): Rename from completing-read.
13977 (completing-read): Call completing-read-function.
13979 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13981 * xfaces.c (Fx_load_color_file):
13982 Read color file from absolute filename (bug#8250).
13984 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13986 * makefile.w32-in: Update dependencies.
13988 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13990 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13992 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13994 Fix more problems found by GCC 4.5.2's static checks.
13996 * process.c (make_serial_process_unwind, send_process_trap):
13997 (sigchld_handler): Now static.
13999 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14000 That way, the code declares only the vars that it needs.
14001 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14002 * s/cygwin.h (PTY_ITERATION): Likewise.
14003 * s/darwin.h (PTY_ITERATION): Likewise.
14004 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14006 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14007 * process.c (allocate_pty): Don't declare stb unless it's needed.
14009 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
14010 (CONSTANTLIM): Remove; unused.
14011 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14012 Define only if needed.
14014 * unexelf.c (unexec): Name an expression,
14015 to avoid gcc -Wbad-function-cast warning.
14016 Use a different way to cause a compilation error if anyone uses
14017 n rather than nn, a way that does not involve shadowing.
14018 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
14020 * deps.mk (unexalpha.o): Remove; unused.
14022 New file unexec.h, the (simple) interface for unexec (Bug#8267).
14023 * unexec.h: New file.
14024 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14025 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14026 Depend on unexec.h.
14027 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14028 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14029 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
14030 Change as necessary to match prototype in unexec.h.
14032 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14034 (back_comment, skip_chars): Mark vars as initialized.
14036 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14037 Rename locals to avoid shadowing.
14039 * lread.c (read1): Rewrite so as not to use empty "else".
14040 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
14042 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14044 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14045 warning when compiling print.c.
14047 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14048 instead of using an uninitialized var.
14049 (font_sort_entities): Mark var as initialized.
14051 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14053 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14054 pointers to constants.
14055 (font_parse_fcname): Remove unused vars.
14056 (font_delete_unmatched): Now static.
14057 (font_get_spec): Remove; unused.
14058 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14059 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14060 Rename or move locals to avoid shadowing.
14062 * fns.c (require_nesting_list, require_unwind): Now static.
14063 (Ffillarray): Rename locals to avoid shadowing.
14065 * floatfns.c (domain_error2): Define only if needed.
14066 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
14068 * alloc.c (mark_backtrace): Move decl from here ...
14069 * lisp.h: ... to here, so that it can be checked.
14071 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
14072 (Fdefvar): Rewrite so as not to use empty "else".
14073 (lisp_indirect_variable): Name an expression,
14074 to avoid gcc -Wbad-function-cast warning.
14075 (Fdefvar): Rename locals to avoid shadowing.
14077 * callint.c (quotify_arg, quotify_args): Now static.
14078 (Fcall_interactively): Rename locals to avoid shadowing.
14079 Use const pointer when appropriate.
14081 * lisp.h (get_system_name, get_operating_system_release):
14082 Move decls here, to check interfaces.
14083 * process.c (get_operating_system_release): Move decl to lisp.h.
14084 * xrdb.c (get_system_name): Likewise.
14085 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14086 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14087 some of which prompt warnings from gcc -Wbad-function-cast.
14088 (Fformat_time_string, Fencode_time, Finsert_char):
14089 (Ftranslate_region_internal, Fformat):
14090 Rename or remove local vars to avoid shadowing.
14091 (Ftranslate_region_internal): Mark var as initialized.
14093 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14096 * lisp.h (eassert): Check that the argument compiles, even if
14097 ENABLE_CHECKING is not defined.
14099 * data.c (Findirect_variable): Name an expression, to avoid
14100 gcc -Wbad-function-cast warning.
14101 (default_value, arithcompare, arith_driver, arith_error): Now static.
14102 (store_symval_forwarding): Rename local to avoid shadowing.
14103 (Fmake_variable_buffer_local, Fmake_local_variable):
14104 Mark variables as initialized.
14105 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
14107 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
14108 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14109 Rename locals to avoid shadowing.
14110 (mark_stack): Move local variables into the #ifdef region where
14112 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14113 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14115 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14116 (GC_STRING_CHARS): Remove; not used.
14117 (Fmemory_limit): Cast sbrk's returned value to char *.
14119 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14120 avoids undefined behavior in theory.
14122 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14124 Use functions, not macros, for up- and down-casing (Bug#8254).
14125 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14126 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14127 to use the following functions instead of these macros.
14128 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14129 EMACS_INT, since callers assume the returned value fits in int.
14130 (upcase1): Likewise, for UPCASE_TABLE.
14131 (uppercasep, lowercasep, upcase): New static inline functions.
14132 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
14133 the race-condition problem in the old DOWNCASE.
14135 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14136 Rename locals to avoid shadowing.
14137 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
14138 (regex_compile, re_search_2, re_match_2_internal):
14139 Remove unused local vars.
14140 (FREE_VAR): Rewrite so as not to use empty "else",
14141 which gcc can warn about.
14142 (regex_compile, re_match_2_internal): Mark locals as initialized.
14143 (RETALLOC_IF): Define only if needed.
14144 (WORDCHAR_P): Likewise. This one is never needed, but is used
14145 only in a comment talking about a compiler bug, so put inside
14146 the #if 0 of that comment.
14147 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14148 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14151 * search.c (boyer_moore): Rename locals to avoid shadowing.
14152 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14153 (PREV_CHAR_BOUNDARY): Likewise.
14155 * search.c (simple_search): Remove unused var.
14157 * dired.c (compile_pattern): Move decl from here ...
14158 * lisp.h: ... to here, so that it can be checked.
14159 (struct re_registers): New forward decl.
14161 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14163 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14165 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14166 Rename locals to avoid shadowing.
14167 (Fvertical_motion): Mark locals as initialized.
14169 * casefiddle.c (casify_object, casify_region): Now static.
14170 (casify_region): Mark local as initialized.
14172 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14174 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14175 New macros, so that the caller can use some names other than
14176 gcpro1, gcpro2, etc.
14177 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14179 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14180 argument, for consistency with GCPRO2_VAR, etc: it is now the
14181 prefix of the variable, not the variable itself. All uses
14183 * dired.c (directory_files_internal, file_name_completion):
14184 Rename locals to avoid shadowing.
14186 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14187 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14188 dired.c's scmp function, had undefined behavior.
14189 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14190 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14191 * buffer.h: ... to here, because these macros use current_buffer,
14192 and the new implementation with inline functions needs to have
14193 current_buffer in scope now, rather than later when the macros
14195 (downcase, upcase1): New static inline functions.
14196 (DOWNCASE, UPCASE1): Reimplement using these functions.
14197 This avoids undefined behavior in expressions like
14198 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14199 from race conditions in accessing the global variables
14200 case_temp1 and case_temp2.
14201 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14202 * lisp.h (case_temp1, case_temp2): Remove their decls.
14203 * character.h (ASCII_CHAR_P): Move from here ...
14204 * lisp.h: ... to here, so that the inline functions mentioned
14205 above can use them.
14207 * dired.c (directory_files_internal_unwind): Now static.
14209 * fileio.c (file_name_as_directory, directory_file_name):
14210 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14212 (file_name_as_directory): Use const pointers when appropriate.
14213 (Fexpand_file_name): Likewise. In particular, newdir might
14214 point at constant storage, so make it a const pointer.
14215 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
14216 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14218 (Fset_file_times, Finsert_file_contents, auto_save_error):
14219 Rename locals to avoid shadowing.
14221 * minibuf.c (choose_minibuf_frame_1): Now static.
14222 (Ftry_completion, Fall_completions): Rename or remove locals
14223 to avoid shadowing.
14225 * marker.c (bytepos_to_charpos): Remove; unused.
14227 * lisp.h (verify_bytepos, count_markers): New decls,
14228 so that gcc does not warn that these functions aren't declared.
14230 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14231 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
14232 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
14233 (copy_text): Remove unused local var.
14235 * filelock.c (within_one_second): Now static.
14236 (lock_file_1): Rename local to avoid shadowing.
14238 * buffer.c (fix_overlays_before): Mark locals as initialized.
14239 (fix_start_end_in_overlays): Likewise. This function should be
14240 simplified by using pointers-to-pointers, but that's a different
14242 (switch_to_buffer_1): Now static.
14243 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14244 (report_overlay_modification): Rename locals to avoid shadowing.
14246 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
14247 Fix pointer signedness issue.
14248 (sys_subshell): Mark local as volatile if checking for lint,
14249 to suppress a gcc -Wclobbered warning that does not seem to be right.
14250 (MAXPATHLEN): Define only if needed.
14252 * process.c (serial_open, serial_configure): Move decls from here ...
14253 * systty.h: ... to here, so that they can be checked.
14255 * fns.c (get_random, seed_random): Move extern decls from here ...
14256 * lisp.h: ... to here, so that they can be checked.
14258 * sysdep.c (reset_io): Now static.
14259 (wait_for_termination_signal): Remove; unused.
14261 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14262 (copy_keymap_item, append_key, push_text_char_description):
14264 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
14265 (DENSE_TABLE_SIZE): Remove; unused.
14266 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14267 (describe_map_tree):
14268 Rename locals to avoid shadowing.
14270 * keyboard.c: Declare functions static if they are not used elsewhere.
14271 (echo_char, echo_dash, cmd_error, top_level_2):
14272 (poll_for_input, handle_async_input): Now static.
14273 (read_char, kbd_buffer_get_event, make_lispy_position):
14274 (make_lispy_event, make_lispy_movement, apply_modifiers):
14275 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14276 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14277 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
14278 (read_key_sequence, read_char): Mark locals as initialized.
14279 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
14281 * keyboard.h (make_ctrl_char): New decl.
14282 (mark_kboards): Move decl here ...
14283 * alloc.c (mark_kboards): ... from here.
14285 * lisp.h (force_auto_save_soon): New decl.
14287 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14288 (DEFINE_DUMMY_FUNCTION): New macro.
14289 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14291 (main): Add casts to avoid warnings
14292 if GCC considers string literals to be constants.
14294 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14296 * dbusbind.c: Pointer signedness fixes.
14297 (xd_signature, xd_append_arg, xd_initialize):
14298 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14299 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14300 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14301 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14303 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14304 if GCC considers string literals to be constants.
14305 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14307 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14309 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14310 (print_preprocess, print_object): New macro to fix last change.
14312 * print.c (print_preprocess): Don't forget font objects.
14314 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14316 * emacs.c (USAGE3): Doc fixes.
14318 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14320 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14323 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14325 * lisp.h (VWindow_system, Qfile_name_history):
14326 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14327 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14328 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14330 * w32select.c: Don't #include "keyboard.h".
14331 (run_protected): Add extern declaration for waiting_for_input.
14333 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14334 * w32console.c (detect_input_pending, read_input_pending)
14335 (encode_terminal_code):
14336 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14337 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14338 (w32_system_caret_y, Qfile_name_history):
14339 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14340 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14341 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14342 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14343 * w32proc.c (Qlocal, report_file_error):
14344 * w32term.c (Vwindow_system, updating_frame):
14345 * w32uniscribe.c (initialized, uniscribe_font_driver):
14346 Remove unneeded extern declarations.
14348 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14350 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14352 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14354 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14355 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14356 These macros can no longer be used for assignment.
14358 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14359 Assign struct members directly, instead of using BUF_BEGV etc.
14360 (record_buffer_markers, fetch_buffer_markers): New functions for
14361 recording and fetching special buffer markers.
14362 (set_buffer_internal_1, set_buffer_temp): Use them.
14364 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14366 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14368 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14369 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14371 * xdisp.c (hscroll_window_tree):
14372 (reconsider_clip_changes): Use PT instead of BUF_PT.
14374 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14376 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14377 $(EMACS_ROOT)/lib/intprops.h.
14379 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14381 Fix more problems found by GCC 4.5.2's static checks.
14383 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14384 to unsigned char * to avoid compiler diagnostic.
14385 (xg_free_frame_widgets): Make it clear that a local variable is
14386 needed only if USE_GTK_TOOLTIP.
14387 (gdk_window_get_screen): Make it clear that this macro is needed
14388 only if USE_GTK_TOOLTIP.
14389 (int_gtk_range_get_value): New function, which avoids a diagnostic
14390 from gcc -Wbad-function-cast.
14391 (xg_set_toolkit_scroll_bar_thumb): Use it.
14392 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14393 diagnostic from gcc -Wbad-function-cast.
14394 (get_utf8_string, xg_get_file_with_chooser):
14395 Rename locals to avoid shadowing.
14396 (create_dialog): Move locals to avoid shadowing.
14398 * xgselect.c (xg_select): Remove unused var.
14400 * image.c (four_corners_best): Mark locals as initialized.
14401 (gif_load): Initialize transparent_p to zero (Bug#8238).
14402 Mark another local as initialized.
14403 (my_png_error, my_error_exit): Mark with NO_RETURN.
14405 * image.c (clear_image_cache): Now static.
14406 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14407 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14408 (x_edge_detection): Remove unnecessary cast that
14409 gcc -Wbad-function-cast diagnoses.
14410 (gif_load): Fix pointer signedness.
14411 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14412 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14414 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14416 Improve quality of tests for time stamp overflow.
14417 For example, without this patch (encode-time 0 0 0 1 1
14418 1152921504606846976) returns the obviously-bogus value (-948597
14419 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14420 reports time overflow. See
14421 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14422 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14423 * editfns.c: Include limits.h and intprops.h.
14424 (TIME_T_MIN, TIME_T_MAX): New macros.
14425 (time_overflow): Move earlier, to before first use.
14426 (hi_time, lo_time): New functions, for an accurate test for
14427 out-of-range times.
14428 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14429 (Fget_internal_run_time): Don't assume time_t fits in int.
14430 (make_time): Use list2 instead of Fcons twice.
14431 (Fdecode_time): More accurate test for out-of-range times.
14432 (check_tm_member): New function.
14433 (Fencode_time): Use it, to test for out-of-range times.
14434 (lisp_time_argument): Don't rely on undefined left-shift and
14435 right-shift behavior when checking for time stamp overflow.
14437 * editfns.c (time_overflow): New function, refactoring common code.
14438 (Fformat_time_string, Fdecode_time, Fencode_time):
14439 (Fcurrent_time_string): Use it.
14441 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14442 * dired.c (make_time): Move to ...
14443 * editfns.c (make_time): ... here.
14444 * systime.h: Note the move.
14446 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14448 * fringe.c (update_window_fringes): Remove unused variables.
14450 * unexmacosx.c (copy_data_segment): Also copy __got section.
14453 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14455 * termcap.c [MSDOS]: Include "msdos.h".
14456 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14457 Constify `char *' arguments and their references according to
14458 prototypes in tparam.h.
14460 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14462 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14463 Adapt all references accordingly.
14465 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14467 2011-03-11 Tom Tromey <tromey@redhat.com>
14469 * buffer.c (syms_of_buffer): Remove obsolete comment.
14471 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14473 * termhooks.h (encode_terminal_code): Declare prototype.
14475 * msdos.c (encode_terminal_code): Don't declare prototype.
14477 * term.c (encode_terminal_code): Now external again, used by
14478 w32console.c and msdos.c.
14480 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14481 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14483 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14485 Fix some minor problems found by GCC 4.5.2's static checks.
14487 * fringe.c (update_window_fringes): Mark locals as initialized
14489 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14491 * alloc.c (mark_fringe_data): Move decl from here ...
14492 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14493 to check its interface.
14494 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14496 * fontset.c (free_realized_fontset): Now static.
14497 (Fset_fontset_font): Rename local to avoid shadowing.
14498 (fontset_font): Mark local as initialized.
14499 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14501 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14503 * xselect.c (x_disown_buffer_selections): Remove; not used.
14504 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14505 (x_own_selection, Fx_disown_selection_internal): Rename locals
14506 to avoid shadowing.
14507 (x_handle_dnd_message): Remove local to avoid shadowing.
14509 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14510 so that the caller can use some name other than gcpro1.
14511 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14512 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14513 (Fx_backspace_delete_keys_p):
14514 Use them to avoid shadowing, and rename vars to avoid shadowing.
14515 (x_decode_color, x_set_name, x_window): Now static.
14516 (Fx_create_frame): Add braces to silence GCC warning.
14517 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14518 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14519 Remove unused locals.
14520 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14521 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14522 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14525 * xterm.h (x_mouse_leave): New decl.
14527 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14528 Remove unused functions.
14529 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14530 (x_calc_absolute_position): Now static.
14531 (XTread_socket): Don't define label "out" unless it's used.
14532 Don't declare local "event" unless it's used.
14533 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14534 unless they are used.
14535 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14536 (x_fatal_error_signal): Remove; not used.
14537 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14538 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14539 (x_error_catcher, x_connection_closed, x_error_handler):
14540 (x_error_quitter, xembed_send_message, x_iconify_frame):
14541 (my_log_handler): Rename locals to avoid shadowing.
14542 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14543 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14545 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14546 Rename or move locals to avoid shadowing.
14547 (tty_defined_color, merge_face_heights): Now static.
14548 (free_realized_faces_for_fontset): Remove; not used.
14549 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14550 does not deduce is never used uninitialized.
14551 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14552 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14554 * terminal.c (store_terminal_param): Now static.
14556 * xmenu.c (menu_highlight_callback): Now static.
14557 (set_frame_menubar): Remove unused local.
14558 (xmenu_show): Rename parameter to avoid shadowing.
14559 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14560 since they might point to immutable storage.
14561 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14562 since it's unused otherwise.
14564 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14565 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14566 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14567 avoids a gcc -Wuninitialized diagnostic.
14568 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14569 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14570 does not deduce are never used uninitialized.
14572 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14574 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14575 * window.c (window_loop, size_window):
14576 (run_window_configuration_change_hook, enlarge_window): Likewise.
14578 * window.c (display_buffer): Now static.
14579 (size_window): Mark variables that gcc -Wuninitialized
14580 does not deduce are never used uninitialized.
14581 * window.h (check_all_windows): New decl, to forestall
14582 gcc -Wmissing-prototypes diagnostic.
14583 * dispextern.h (bidi_dump_cached_states): Likewise.
14585 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14587 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14588 Include <limits.h>.
14589 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14590 and to avoid gcc -Wuninitialized warning.
14591 (load_charset_map): Mark variables that gcc -Wuninitialized
14592 does not deduce are never used uninitialized.
14593 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14595 * coding.c (coding_set_source, coding_set_destination):
14596 Use "else { /* comment */ }" rather than "else /* comment */;"
14597 for clarity, and to avoid gcc -Wempty-body warning.
14598 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14599 a block, when the outer 'i' will do.
14600 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14601 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14602 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14603 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14604 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14605 Rename locals to avoid shadowing.
14606 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14607 * coding.c (emacs_mule_char, encode_invocation_designation):
14608 Now static, since they're not used elsewhere.
14609 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14610 (decode_coding_object, encode_coding_object, detect_coding_system):
14611 (decode_coding_emacs_mule): Mark variables that gcc
14612 -Wuninitialized does not deduce are never used uninitialized.
14613 (detect_coding_iso_2022): Initialize a local variable that might
14614 be used uninitialized. Leave a FIXME because it's not clear that
14615 this initialization is needed. (Bug#8211)
14616 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14617 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14618 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14619 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14620 Remove unused macros.
14622 * category.c (hash_get_category_set): Remove unused local var.
14623 (copy_category_table): Now static, since it's not used elsewhere.
14624 * character.c (string_count_byte8): Likewise.
14626 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14627 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14629 * chartab.c (copy_sub_char_table): Now static, since it's not used
14631 (sub_char_table_ref_and_range, char_table_ref_and_range):
14632 Rename locals to avoid shadowing.
14633 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14635 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14636 (BIDI_BOB): Remove unused macro.
14638 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14639 deduce are never used uninitialized.
14640 * term.c (encode_terminal_code): Likewise.
14642 * term.c (encode_terminal_code): Now static. Remove unused local.
14644 * tparam.h: New file.
14645 * term.c, tparam.h: Include it.
14646 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14647 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14648 Move these decls to tparam.h, and make them agree with what
14649 is actually in tparam.c. The previous trick of using incompatible
14650 decls in different modules does not conform to the C standard.
14651 All callers of tparam changed to use tparam's actual API.
14652 * tparam.c (tparam1, tparam, tgoto):
14653 Use const pointers where appropriate.
14655 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14656 * cm.h (struct cm): Likewise.
14657 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14658 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14659 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14660 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14661 (turn_on_face, init_tty): Likewise.
14662 * termchar.h (struct tty_display_info): Likewise.
14664 * term.c (term_mouse_position): Rename local to avoid shadowing.
14666 * alloc.c (mark_ttys): Move decl from here ...
14667 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14669 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14671 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14673 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14675 * search.c (compile_pattern_1): Remove argument regp, unused since
14676 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14677 (compile_pattern): Don't pass it.
14679 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14681 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14682 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14684 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14686 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14688 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14689 gdk_window_get_screen, gdk_window_get_geometry,
14690 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14691 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14692 (xg_get_pixbuf_from_pixmap): New function.
14693 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14694 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14695 Call xg_get_pixbuf_from_pixmap instead of
14696 gdk_pixbuf_get_from_drawable.
14697 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14698 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14699 (xg_check_special_colors): Use GtkStyleContext and its functions
14701 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14702 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14703 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14704 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14705 Call gtk_widget_get_preferred_size.
14706 (xg_frame_resized): gdk_window_get_geometry only takes 5
14708 (xg_win_to_widget, xg_event_is_for_menubar):
14709 Call gdk_x11_window_lookup_for_display.
14710 (xg_set_widget_bg): New function.
14711 (delete_cb): New function.
14712 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14713 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14714 (xg_set_background_color): Call xg_set_widget_bg.
14715 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14716 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14717 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14718 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14720 (update_frame_tool_bar): Call gtk_widget_hide.
14721 (xg_initialize): Use GDK_KEY_g.
14723 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14725 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14727 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14728 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14729 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14731 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14733 * w32xfns.c (select_palette): Check success of RealizePalette against
14734 GDI_ERROR, not zero.
14736 See ChangeLog.11 for earlier changes.
14738 ;; Local Variables:
14742 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14744 This file is part of GNU Emacs.
14746 GNU Emacs is free software: you can redistribute it and/or modify
14747 it under the terms of the GNU General Public License as published by
14748 the Free Software Foundation, either version 3 of the License, or
14749 (at your option) any later version.
14751 GNU Emacs is distributed in the hope that it will be useful,
14752 but WITHOUT ANY WARRANTY; without even the implied warranty of
14753 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14754 GNU General Public License for more details.
14756 You should have received a copy of the GNU General Public License
14757 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
HCoop / bpt / emacs.git / blob