1 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3 * window.c (temp_output_buffer_show): Don't use
4 Vtemp_buffer_show_specifiers.
5 (Vtemp_buffer_show_specifiers): Remove unused variable.
7 2011-10-30 Eli Zaretskii <eliz@gnu.org>
9 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
10 past the beginning of the current glyph matrix.
12 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
14 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
15 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
18 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
19 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
21 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
23 * xterm.c: Declare x_handle_net_wm_state to return int.
24 (handle_one_xevent): Check if we are iconified but don't have
25 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
26 (get_current_wm_state): Return non-zero if not hidden,
27 check for _NET_WM_STATE_HIDDEN (Bug#9893).
28 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
29 (x_handle_net_wm_state): Return what get_current_wm_state returns.
30 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
32 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
34 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
35 so that this new function doesn't get optimized away by a
36 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
38 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
40 * frame.h (MOUSE_HL_INFO): Remove excess parens.
42 2011-10-29 Eli Zaretskii <eliz@gnu.org>
44 Fix the `xbytecode' command.
45 * .gdbinit (xprintbytestr): New command.
46 (xwhichsymbols): Renamed from `which'; all callers changed.
47 (xbytecode): Print the byte-code string as well.
49 2011-10-29 Kim Storm <storm@cua.dk>
51 * alloc.c (which_symbols): New function.
53 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
55 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
58 2011-10-29 Glenn Morris <rgm@gnu.org>
60 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
61 Not clear what it was for, and it causes various bugs. (Bug#9839)
63 2011-10-28 Eli Zaretskii <eliz@gnu.org>
65 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
66 possible random value that matches one of those tested as
67 condition to clear the mouse face.
69 2011-10-28 Chong Yidong <cyd@gnu.org>
71 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
73 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
75 * window.c (make_window): Initialize phys_cursor_on_p.
77 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
79 * lisp.h (struct Lisp_Symbol): Update comments.
81 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
83 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
85 2011-10-28 Eli Zaretskii <eliz@gnu.org>
87 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
88 <oslsachem@gmail.com> for helping to debug this.
90 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
91 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
92 (g_b_init_get_glyph_outline_w): New static variables.
93 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
94 (GetGlyphOutlineW_Proc): New typedefs.
95 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
96 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
98 (w32font_open_internal, compute_metrics):
99 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
100 instead of calling the "wide" APIs directly.
102 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
104 * w32.h (syms_of_w32font): Add prototype.
106 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
108 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
109 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
110 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
111 (Fmove_to_window_line): Doc fix.
113 2011-10-27 Chong Yidong <cyd@gnu.org>
115 * process.c (make_process): Set gnutls_state to NULL.
117 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
118 non-NULL, regardless of GNUTLS_INITSTAGE.
119 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
120 an error. Set process slots as soon as we allocate them.
122 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
124 2011-10-27 Chong Yidong <cyd@gnu.org>
126 * gnutls.c (emacs_gnutls_deinit): New function.
127 Deallocate credentials structures as well as calling gnutls_deinit.
128 (Fgnutls_deinit, Fgnutls_boot): Use it.
130 * process.c (make_process): Initialize GnuTLS credentials to NULL.
131 (deactivate_process): Call emacs_gnutls_deinit.
133 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
135 * image.c (x_create_x_image_and_pixmap):
136 * w32.c (sys_rename, w32_delayed_load):
137 * w32font.c (fill_in_logfont):
138 * w32reg.c (x_get_string_resource): Silence compiler warnings.
140 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
142 * w32fns.c (w32_default_color_map): New function,
143 extracted from Fw32_default_color_map.
144 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
146 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
148 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
150 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
152 * keyboard.c (test_undefined): New function (bug#9751).
153 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
155 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
157 * sysdep.c (init_sys_modes): Fix the check for the controlling
160 2011-10-20 Eli Zaretskii <eliz@gnu.org>
162 * dispextern.h (struct bidi_it): New member next_en_type.
164 * bidi.c (bidi_line_init): Initialize the next_en_type member.
165 (bidi_resolve_explicit_1): When next_en_pos is valid for the
166 current character, check also for next_en_type being WEAK_EN.
167 (bidi_resolve_weak): Don't enter the expensive loop if the current
168 position is before next_en_pos. Record the bidi type of the first
169 non-ET, non-BN character we find, in addition to its position.
170 (bidi_level_of_next_char): Invalidate next_en_type when
171 next_en_pos is over-stepped.
173 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
175 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
176 * editfns.c: Rewrite current-time-zone so that it invokes
177 the equivalent of (format-time-string "%Z") to get the time zone name.
178 This fixes a bug when the time zone name contains characters that
179 need converting from the system time locale to Emacs internal format.
180 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
181 that patch fixed format-time-string to do the conversion, but
182 I forgot to fix current-time-zone.
183 (format_time_string): New function, containing most of
184 what Fformat_time_string used to contain.
185 (Fformat_time_string): Rewrite in terms of format_time_string.
186 This doesn't change this function's behavior.
187 (current-time-zone): Rewrite to use format_time_string.
188 This fixes the bug reported by Michael Schierl in
189 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
190 Jason Rumney's 2007-06-07 change worked around this bug, but
192 * systime.h (tzname, timezone): Remove no-longer-used declarations.
194 2011-10-19 Eli Zaretskii <eliz@gnu.org>
196 * xdisp.c (start_display): If the character at POS is displayed
197 via a display vector, reset IT->current.dpvec_index to zero.
198 (try_window_reusing_current_matrix): If a line ends in a display
199 vector or the next line starts in a display vector, continue
200 redrawing the window even though the character position of
201 start_row was reached.
204 2011-10-18 Chong Yidong <cyd@gnu.org>
206 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
207 with nobreak-char-display too.
209 2011-10-18 Eli Zaretskii <eliz@gnu.org>
211 Fix part 3 of bug#9771.
212 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
213 (bidi_resolve_neutral): Don't enter the expensive loop looking for
214 non-neutral characters if the current character is a paragraph
215 separator (a.k.a. Newline). This avoids running the same
216 expensive loop twice, once when we consume the preceding newline
217 and the other time when the line actually needs to be displayed.
218 Avoid the loop when we see neutrals on the base embedding level
219 following a character whose directionality is the same as the
220 paragraph's. This avoids running the expensive loop when a line
221 ends in a long sequence of neutrals, like control characters.
222 Add assertion against STRONG_AL type. Slightly rearrange code
223 that determines the type of a neutral given the first non-neutral
225 (bidi_level_of_next_char): Set next_en_pos to zero when
226 invalidating its info.
228 2011-10-17 Eli Zaretskii <eliz@gnu.org>
230 * xdisp.c (push_display_prop): Determine whether to record string
231 or buffer position by IT->string, not by IT->method. Allow
232 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
233 (move_it_vertically_backward): Don't look for character position
234 immediately after the newline when in a continuation line.
237 2011-10-15 Martin Rudalics <rudalics@gmx.at>
239 * window.c (coordinates_in_window): Rewrite and delabelize
240 vertical border check. (Bug#5357) (Bug#9618)
242 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
244 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
245 errors in XSetWindowBorder (bug#9310).
247 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
249 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
250 avoid crash when xmalloc overrun checking is enabled.
252 2011-10-13 Eli Zaretskii <eliz@gnu.org>
254 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
255 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
256 cursor motion with <left> and <right> arrow keys.
258 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
259 some callers set that themselves.
261 2011-10-12 Eli Zaretskii <eliz@gnu.org>
263 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
264 display string and the previous row comes from the same string and
265 is empty. (Bug#9739) (Bug#9738)
267 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
269 * doc.c (get_doc_string): Encode file name (bug#9735).
271 2011-10-12 Eli Zaretskii <eliz@gnu.org>
273 * bidi.c (bidi_level_of_next_char):
274 * xdisp.c (get_visually_first_element): Remove old incorrect
275 comments regarding the Unicode Line Separator character.
277 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
279 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
281 * alloc.c (Fgc_status): Do not access beyond zombies array
282 boundary if nzombies > MAX_ZOMBIES.
283 * alloc.c (dump_zombies): Add missing format specifier.
285 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
287 * xdisp.c (set_cursor_from_row): Simplify conditionals,
288 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
290 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
291 Some packages use them to denote characters with modifiers.
293 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
295 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
296 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
297 matching a pp-number. Rename parameter var to var1.
299 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
301 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
303 2011-10-08 Glenn Morris <rgm@gnu.org>
305 * callint.c (Fcall_interactively): Give a more explicit error for the
306 'c' case with a non-character input. (Bug#8479)
308 2011-10-08 Eli Zaretskii <eliz@gnu.org>
310 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
312 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
313 lines that are hscrolled on the left.
315 * dispnew.c (buffer_posn_from_coords): Account for a possible
316 presence of header-line. (Bug#4426)
318 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
320 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
321 Don't advertise functionality which we discourage or doesn't work.
323 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
325 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
326 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
327 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
328 this makes Emacs dump core during garbage collection on rare
329 occasions. sizeof is obviously inferior to offsetof here, so
331 (GC_POINTER_ALIGNMENT): New macro.
332 (mark_memory): Omit 3rd (offset) arg; caller changed.
333 Don't assume EMACS_INT alignment is the same as pointer alignment.
335 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
337 * keyboard.c (read_key_sequence_remapped): New var.
338 (read_key_sequence): Compute remapping in the right buffer.
339 (command_loop_1): Use read_key_sequence's remapping directly.
341 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
343 * dired.c (file_name_completion): Don't expand file name.
344 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
345 before checking file name handler.
347 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
348 they've been requested explicitly (bug#9591).
350 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
352 * keymap.c (Fsingle_key_description): Use make_specified_string
353 instead of build_string to build string from push_key_description.
356 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
358 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
359 This fixes a Y2038 bug on 64-bit hosts.
360 * buffer.c (reset_buffer):
361 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
362 (Fclear_buffer_auto_save_failure):
363 Use 0, not -1, to represent an unset failure time, since time_t
366 Remove dependency on glibc malloc internals.
367 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
368 Move back here from lisp.h, but with their new implementations.
369 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
370 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
371 * charset.c (charset_table_init): New static var.
372 (syms_of_charset): Use it instead of xmalloc. This removes a
373 dependency on glibc malloc internals. See Eli Zaretskii's comment in
374 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
375 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
376 Move back to alloc.c.
377 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
378 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
380 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
382 * nsterm.m (windowDidResize): Call x_set_window_size only when
383 ns_in_resize is true. Otherwise set pixelwidth/height and
384 call change_frame_size (Bug#9628).
386 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
388 Port --enable-checking=all to Fedora 14 x86-64.
389 * charset.c (syms_of_charset): Also account for glibc malloc's
390 internal overhead when calculating the initial malloc maximum.
392 Port --enable-checking=all to Fedora 14 x86.
393 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
395 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
396 (overrun_check_realloc, overrun_check_free):
397 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
398 That way, xmalloc returns a properly-aligned pointer even if
399 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
400 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
401 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
402 into account when calculating the initial malloc maximum.
403 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
404 Move here from alloc.c, so that charset.c can use it too.
405 Properly align; the old code wasn't right for common 32-bit hosts
406 when configured with --enable-checking=all.
407 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
408 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
410 2011-09-29 Eli Zaretskii <eliz@gnu.org>
412 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
415 2011-09-28 Eli Zaretskii <eliz@gnu.org>
417 * xdisp.c (compute_display_string_end): If there's no display
418 string at CHARPOS, return -1.
420 * bidi.c (bidi_fetch_char): When compute_display_string_end
421 returns a negative value, treat the character as a normal
422 character not covered by a display string. (Bug#9624)
424 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
426 * lread.c (Fread_from_string): Fix typo in docstring.
428 2011-09-27 Eli Zaretskii <eliz@gnu.org>
430 * xdisp.c (handle_invisible_prop): If invisible text ends on a
431 newline, reseat the iterator instead of bidi-iterating there one
432 character at a time. (Bug#9610)
433 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
434 TO_CHARPOS if the bidi iterator is at base embedding level.
436 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
438 * lread.c (readevalloop): Use correct code for NBSP.
439 (read1): Likewise. (Bug#9608)
441 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
443 * dbusbind.c (Fdbus_register_signal): When service is not
444 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
446 2011-09-25 Glenn Morris <rgm@gnu.org>
448 * buffer.c (truncate-lines): Doc fix.
450 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
452 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
453 (Fset_window_next_buffers): Doc fix.
455 2011-09-24 Glenn Morris <rgm@gnu.org>
457 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
459 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
461 Fix minor problems found by static checking.
462 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
463 * indent.c (Fvertical_motion): Fix == vs = typo.
465 2011-09-24 Eli Zaretskii <eliz@gnu.org>
467 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
468 Default value is now t. Doc fix.
470 * indent.c (Fvertical_motion): Compute and apply the overshoot
471 logic when moving up, not only when moving down. Fix the
472 confusing name and values of the it_overshoot_expected variable;
473 logic changes accordingly. (Bug#9254) (Bug#9549)
475 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
476 CHARPOS is covered by a display string which includes newlines.
477 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
478 is covered by a display string with embedded newlines.
480 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
482 * dbusbind.c (Fdbus_register_signal): Add match rule to
483 Vdbus_registered_objects_table. (Bug#9581)
484 (Fdbus_register_method, Vdbus_registered_objects_table):
487 2011-09-24 Jim Meyering <meyering@redhat.com>
489 do not ignore write error for any output size
490 The previous change was incomplete.
491 While it makes emacs --batch detect the vast majority of stdout
492 write failures, errors were still ignored whenever the output size is
493 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
494 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
495 && echo FAIL: ignored write error
496 FAIL: ignored write error
497 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
498 && echo FAIL: ignored write error
499 FAIL: ignored write error
500 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
502 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
504 * emacs.c (Fkill_emacs): In noninteractive mode exit
505 non-successfully if a write error occurred on stdout. (Bug#9574)
507 2011-09-21 Eli Zaretskii <eliz@gnu.org>
509 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
512 * dispextern.h (struct it): Update the comment documenting what
515 2011-09-20 Eli Zaretskii <eliz@gnu.org>
517 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
518 a display string, extend search for cursor position to end of row.
519 (find_row_edges): If the row ends in a newline from a display
520 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
521 Handle the case of a display string with multiple newlines.
522 (Fcurrent_bidi_paragraph_direction): Fix search for previous
523 non-empty line. Fixes confusing cursor motion with arrow keys at
524 the beginning of a line that starts with whitespace.
526 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
528 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
531 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
533 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
536 2011-09-18 Eli Zaretskii <eliz@gnu.org>
538 * xdisp.c (display_line): Record maximum and minimum buffer
539 positions even if no glyphs were produced (e.g., by a zero-width
540 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
541 buffer positions that will be removed from the glyph row because
543 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
544 column is beyond frame width: don't subtract 1 "pixel" when
545 computing width of the stretch.
546 (reseat_at_next_visible_line_start): Undo the change made on
547 2011-09-17 that saved paragraph information and restored it after
548 the call to `reseat'. (Bug#9545)
550 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
552 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
553 and turn window cursor on if cleared (Bug#9415).
555 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
557 * search.c (boyer_moore): Take unibyte characters from pattern
558 literally. (Bug#9458)
560 2011-09-18 Eli Zaretskii <eliz@gnu.org>
562 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
564 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
566 Fix minor problem found by static checking.
567 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
568 initialized, to pacify gcc -Wuninitialized.
570 * fileio.c: Report proper errno when syscall falls.
571 (Finsert_file_contents): Save and restore errno,
572 so that report_file_error outputs the correct diagnostic.
573 (Fwrite_region) [CLASH_DETECTION]: Likewise.
575 2011-09-18 Eli Zaretskii <eliz@gnu.org>
577 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
579 2011-09-17 Eli Zaretskii <eliz@gnu.org>
581 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
582 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
584 2011-09-17 Eli Zaretskii <eliz@gnu.org>
586 * xdisp.c (reseat_at_next_visible_line_start): Keep information
587 about the current paragraph and restore it after the call to reseat.
589 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
590 (bidi_find_paragraph_start): Search back for paragraph beginning
591 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
592 (bidi_move_to_visually_next): Only trigger paragraph-related
593 computations when the last character is a newline or at EOB, not
594 just any NEUTRAL_B. (Bug#9470)
596 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
597 truncated lines if point is covered by a display string. (Bug#9524)
599 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
601 * xselect.c: Relax test for outgoing X longs (Bug#9498).
602 (cons_to_x_long): New function.
603 (lisp_data_to_selection_data): Use it. Correct the test for
604 short-versus-long data; it was negated. Break out of vector
605 loop, for efficiency, when a long datum is discovered.
607 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
609 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
611 2011-09-16 Eli Zaretskii <eliz@gnu.org>
613 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
614 GCC PR/17406) by declaring this function with external scope.
616 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
618 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
619 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
621 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
623 * editfns.c (Fformat): Correctly handle text properties on "%%".
625 2011-09-15 Eli Zaretskii <eliz@gnu.org>
627 * xterm.c (x_draw_composite_glyph_string_foreground):
628 * w32term.c (x_draw_composite_glyph_string_foreground):
629 * term.c (encode_terminal_code):
630 * composite.c (composition_update_it, get_composition_id):
631 * xdisp.c (get_next_display_element)
632 (fill_composite_glyph_string): Add comments about special meaning
633 of TAB characters in a composition.
635 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
637 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
638 This occurs when processing a multibyte format.
639 Problem reported by Wolfgang Jenker.
641 2011-09-15 Johan Bockgård <bojohan@gnu.org>
643 * xdisp.c (try_cursor_movement): Only check for exact match if
644 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
646 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
648 Remove unused external symbols.
649 * dispextern.h (calc_pixel_width_or_height): Remove decl.
650 * xdisp.c (calc_pixel_width_or_height): Now static.
651 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
652 * indent.c (check_display_width):
653 * w32term.c: Fix comment to match code.
654 * xterm.c, xterm.h (x_catching_errors): Remove.
656 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
658 * xselect.c: Use signed conversions more consistently (Bug#9498).
659 (selection_data_to_lisp_data): Assume incoming selection data are
660 signed integers, not unsigned. This is to be consistent with
661 outgoing selection data, which was modified to use signed integers
662 in as part of the fix to Bug#9196 in response to Jan D.'s comment
663 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
664 expects long, not unsigned long.
666 2011-09-14 Eli Zaretskii <eliz@gnu.org>
668 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
669 computation of loop end. Reported by Johan Bockgård
672 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
674 * frame.c (Fother_visible_frames_p): Function deleted.
676 2011-09-12 Eli Zaretskii <eliz@gnu.org>
678 * indent.c (compute_motion): Process display vector front to back
679 rather than the other way around. (Bug#2496)
681 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
683 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
685 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
687 * minibuf.c (Fread_from_minibuffer): Doc fix.
689 2011-09-11 Eli Zaretskii <eliz@gnu.org>
691 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
692 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
694 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
696 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
697 value for non-existent files.
699 2011-09-11 Eli Zaretskii <eliz@gnu.org>
701 * fileio.c (Finsert_file_contents): If the file cannot be opened,
702 set its "size" to -1. This will set the modtime_size field of
703 the corresponding buffer to -1, which is what
704 verify-visited-file-modtime expects for files that do not exist.
707 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
709 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
711 * lisp.h: ... from here. push_key_description is no longer
712 defined in keyboard.c, so its declaration should not be in
713 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
714 logically belongs with push_key_description.
716 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
718 * buffer.h: Include <sys/types.h> instead of <time.h>.
719 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
720 Problem reported by Herbert J. Skuhra.
722 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
724 * xml.c (parse_region): Make the parsing work for
725 non-comment-starting XML files again (bug#9144).
727 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
729 * image.c (gif_load): Fix calculation of bottom and right corner.
732 2011-09-10 Eli Zaretskii <eliz@gnu.org>
734 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
735 redisplay in small windows.
737 2011-09-09 Eli Zaretskii <eliz@gnu.org>
739 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
741 2011-09-08 Martin Rudalics <rudalics@gmx.at>
743 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
744 Operate on live windows only.
746 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
748 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
750 2011-09-07 Eli Zaretskii <eliz@gnu.org>
752 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
753 only under bidi iteration.
755 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
757 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
759 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
761 isnan: Fix porting problem to Solaris 10 with bundled gcc.
762 Without this fix, the command to link temacs failed due to an
763 undefined symbol __builtin_isnan. This is because
764 /usr/include/iso/math_c99.h #defines isnan(x) to
765 __builtin_isnan(x), but the bundled gcc, which identifies itself
766 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
768 * floatfns.c (isnan): #undef, and then #define to a clone of
770 (Fisnan): Always define, since it's always available now.
771 (syms_of_floatfns): Always define isnan at the Lisp level.
773 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
775 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
777 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
779 * fileio.c: Fix bugs with large file offsets (Bug#9428).
780 The previous code assumed that file offsets (off_t values) fit in
781 EMACS_INT variables, which is not true on typical 32-bit hosts.
782 The code messed up by falsely reporting buffer overflow in cases
783 such as (insert-file-contents "big" nil 1 2) into an empty buffer
784 when "big" contains more than 2**29 bytes, even though this
785 inserts just one byte and does not overflow the buffer.
786 (Finsert_file_contents): Store file offsets as off_t
787 values, not as EMACS_INT values. Check for overflow when
788 converting between EMACS_INT and off_t. When checking for
789 buffer overflow or for overlap, take the offsets into account.
790 Don't use EMACS_INT for small values where int suffices.
791 When checking for overlap, fix a typo: ZV was used where
792 ZV_BYTE was intended.
793 (Fwrite_region): Don't assume off_t fits into 'long'.
794 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
796 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
798 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
800 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
802 sprintf-related integer and memory overflow issues (Bug#9412).
804 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
805 (esprintf, exprintf, evxprintf): New functions.
806 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
807 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
808 (modify_event_symbol): Do not assume that the length of
809 name_alist_or_stem is safe to alloca and fits in int.
810 (Fexecute_extended_command): Likewise for function name and binding.
811 (Frecursion_depth): Wrap around reliably on integer overflow.
812 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
813 since some callers pass EMACS_INT values.
814 (Fsingle_key_description): Don't crash if symbol name contains more
815 than MAX_ALLOCA bytes.
816 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
817 (get_minibuffer): Arg is now EMACS_INT, not int.
818 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
819 (esprintf, exprintf, evxprintf): New decls.
820 * window.h (command_loop_level, minibuf_level): Reflect API changes.
822 * dbusbind.c (signature_cat): New function.
823 (xd_signature, Fdbus_register_signal):
824 Do not overrun buffer; instead, report string overflow.
826 * dispnew.c (add_window_display_history): Don't overrun buffer.
827 Truncate instead; this is OK since it's just a log.
829 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
830 even if the time zone offset is outlandishly large.
831 Don't mishandle offset == INT_MIN.
833 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
834 when creating daemon; the previous buffer-overflow check was incorrect.
836 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
837 which has the guts of the old verror function.
839 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
840 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
842 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
843 (font_unparse_xlfd): Don't blindly alloca long strings.
844 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
845 fits in int, when using sprintf. Use single snprintf to count
846 length of string rather than counting it via multiple sprintfs;
847 that's simpler and more reliable.
848 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
849 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
850 sprintf, in case result does not fit in int.
852 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
853 (fontset_from_font): Print it.
855 * frame.c (tty_frame_count): Now printmax_t, not int.
856 (make_terminal_frame, set_term_frame_name): Print it.
857 (x_report_frame_params): In X, window IDs are unsigned long,
858 not signed long, so print them as unsigned.
859 (validate_x_resource_name): Check for implausibly long names,
860 and don't assume name length fits in 'int'.
861 (x_get_resource_string): Don't blindly alloca invocation name;
862 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
865 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
866 (xg_check_special_colors, xg_set_geometry):
867 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
869 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
870 Use esprintf, not sprintf, in case result does not fit in int.
872 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
873 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
874 it as a large positive number.
875 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
876 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
878 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
879 in case result does not fit in int.
881 * print.c (float_to_string): Detect width overflow more reliably.
882 (print_object): Make sprintf buffer a bit bigger, to avoid potential
883 buffer overrun. Don't assume list length fits in 'int'. Treat
884 print length of 0 as 0, not as infinity; to be consistent with other
885 uses of print length in this function. Don't overflow print length
886 index. Don't assume hash table size fits in 'long', or that
887 vectorlike size fits in 'unsigned long'.
889 * process.c (make_process): Use printmax_t, not int, to format
890 process-name gensyms.
892 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
894 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
895 to avoid potential buffer overrun.
897 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
898 if X resource line is longer than 512 bytes.
900 * xfns.c (x_window): Make sprintf buffer a bit bigger
901 to avoid potential buffer overrun.
903 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
905 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
907 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
909 Integer overflow fixes for scrolling, etc.
910 Without these, Emacs silently mishandles large integers sometimes.
911 For example, "C-u 4294967297 M-x recenter" was treated as if
912 it were "C-u 1 M-x recenter" on a typical 64-bit host.
914 * xdisp.c (try_window_id): Check Emacs fixnum range before
917 * window.c (window_scroll_line_based, Frecenter):
918 Check that an Emacs fixnum is in range before assigning it to 'int'.
919 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
920 values converted from Emacs fixnums.
921 (Frecenter): Don't wrap around a line count if it is out of 'int'
922 range; instead, treat it as an extreme value.
923 (Fset_window_configuration, compare_window_configurations):
924 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
926 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
927 that can exceed INT_MAX. Check that EMACS_INT value is in range
928 before assigning it to the (possibly-narrower) index.
929 (match_limit): Don't assume that a fixnum can fit in 'int'.
931 * print.c (print_object): Use ptrdiff_t, not int, for index that can
934 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
935 (Fvertical_motion): Don't wrap around LINES values that don't fit
936 in 'int'. Instead, treat them as extreme values. This is good
937 enough for windows, which can't have more than INT_MAX lines anyway.
939 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
941 * Require libxml/parser.h to avoid compilation warning.
943 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
945 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
946 since this reportedly can destroy thread storage.
948 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
950 * syntax.c (find_defun_start): Update all cache variables if
951 exiting early (Bug#9401).
953 2011-08-30 Eli Zaretskii <eliz@gnu.org>
955 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
957 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
958 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
959 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
961 * term.c (tty_append_glyph): New function.
962 (produce_stretch_glyph): Static function and its prototype deleted.
964 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
967 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
969 * image.c (parse_image_spec): Check for nonnegative, not for positive,
970 when checking :margin (Bug#9390).
971 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
972 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
973 so that the name doesn't mislead. All uses changed.
975 2011-08-28 Johan Bockgård <bojohan@gnu.org>
977 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
980 2011-08-27 Eli Zaretskii <eliz@gnu.org>
982 * xdisp.c (move_it_to): Don't bail out early when reaching
983 position beyond to_charpos, if we are scanning backwards.
984 (move_it_vertically_backward): When DY == 0, make sure we get to
985 the first character in the line after the newline.
987 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
989 * ccl.c: Improve and simplify overflow checking (Bug#9196).
990 (ccl_driver): Do not generate an out-of-range pointer.
991 (Fccl_execute_on_string): Remove unnecessary check for
992 integer overflow, noted by Stefan Monnier in
993 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
994 Remove a FIXME that didn't need fixing.
995 Simplify the newly-introduced buffer reallocation code.
997 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
999 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1001 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1003 Integer and memory overflow issues (Bug#9196).
1005 * doc.c (get_doc_string): Rework so that
1006 get_doc_string_buffer_size is the actual buffer size, rather than
1007 being 1 less than the actual buffer size; this makes xpalloc more
1010 * image.c (x_allocate_bitmap_record, cache_image):
1011 * xselect.c (Fx_register_dnd_atom):
1012 Simplify previous changes by using xpalloc.
1014 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1015 since either will do and ptrdiff_t is convenient with xpalloc.
1017 * charset.c (charset_table_size)
1018 (struct charset_sort_data.priority): Now ptrdiff_t.
1019 (charset_compare): Don't overflow if priorities differ greatly.
1020 (Fsort_charsets): Don't assume list length fits in int.
1021 Check for size-calculation overflow when allocating sort data.
1022 (syms_of_charset): Allocate an initial charset table that is
1023 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1025 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1027 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1028 The actual value is always <= INT_MAX, and leaving it unsigned made
1029 overflow checking harder.
1031 * dispextern.h (struct glyph_matrix.rows_allocated)
1032 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1033 with xpalloc. The values are still always <= INT_MAX.
1035 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1037 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1038 (SAFE_NALLOCA): New macro.
1040 * region-cache.c (struct boundary.pos, find_cache_boundary)
1041 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1042 (set_cache_region, invalidate_region_cache)
1043 (revalidate_region_cache, know_region_cache, region_cache_forward)
1044 (region_cache_backward, pp_cache):
1045 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1046 so that ptrdiff_t * can be passed to xpalloc.
1047 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1048 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1049 (pp_cache): Don't assume cache_len fits in int.
1050 * region-cache.h: Adjust extern decls to match.
1052 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1053 EMACS_INT, since either will do, for xpalloc.
1055 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1056 (xnmalloc, xnrealloc, xpalloc): New functions.
1058 * bidi.c (bidi_shelve_header_size): New constant.
1059 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1060 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1062 * bidi.c (bidi_cache_shrink):
1063 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1065 Don't update size of array until after memory allocation succeeds,
1066 because xmalloc/xrealloc may not return.
1067 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1068 now that we have proper integer overflow checking.
1069 (record_overlay_string, overlay_strings): Catch overflows when
1070 calculating size of overlay_str_buf.
1072 * callproc.c (Fcall_process): Check for size overflow when
1073 calculating size of args2.
1074 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1075 Normally we prefer signed values, but sticking with ptrdiff_t would
1076 require adding more-complicated checks.
1078 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1079 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1080 Redo buffer-overflow calculations to avoid integer overflow.
1081 Add a FIXME comment where memory seems to be over-allocated.
1083 * character.c (Fstring): Check for size-calculation overflow.
1085 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1086 unnecessary integer overflow. Check for size overflow.
1087 (encode_coding_object): Don't update size until xmalloc succeeds.
1089 * composite.c (get_composition_id): Check for overflow in glyph
1090 length calculations.
1092 Integer and memory overflow fixes for display code.
1093 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1094 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1095 (scrolling_window): Check for overflow in size calculations.
1096 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1097 Don't assume glyph table len fits in int.
1098 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1099 (row_table_size): Now ptrdiff_t, not int.
1100 (scrolling_window): Avoid overflow in size calculations.
1101 Don't update size until allocation succeeds.
1102 * fns.c (concat): Check for overflow in size calculations.
1103 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1104 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1105 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1107 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1108 (get_doc_string): Check for size calculation overflow.
1109 Don't update size until allocation succeeds.
1110 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1111 EMACS_INT, where ptrdiff_t will do.
1112 (Fsubstitute_command_keys): Check for string overflow.
1114 * editfns.c (set_time_zone_rule): Don't assume environment length
1116 (message_length): Now ptrdiff_t, not int.
1117 (Fmessage_box): Don't update size until allocation succeeds.
1118 Don't assume message length fits in int.
1119 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1121 * emacs.c (main): Do not reallocate argv, since there is a null at
1122 the end that can be overwritten, and this way there's no need to
1123 worry about size-calculation overflow.
1124 (sort_args): Check for size-calculation overflow.
1126 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1128 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1130 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1131 (x_set_scroll_bar_width, x_figure_window_size):
1132 Check for integer overflow.
1133 (x_set_alpha): Do not assume XINT fits in int.
1135 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1136 This is for the members text_lines, text_cols, total_lines, total_cols,
1137 where the system imposes an 'int' limit.
1139 * fringe.c (Fdefine_fringe_bitmap):
1140 Don't update size until alloc works.
1142 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1143 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1145 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1146 Check for size-calculation overflow.
1147 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1148 do, as we prefer signed integers.
1149 (id_to_widget.max_size, id_to_widget.used)
1150 (xg_store_widget_in_map, xg_remove_widget_from_map)
1151 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1152 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1153 Use and return ptrdiff_t, not int.
1154 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1155 * gtkutil.h: Change prototypes to match the above.
1157 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1158 are duplicate now that they've been promoted to lisp.h.
1159 (x_allocate_bitmap_record, x_alloc_image_color)
1160 (make_image_cache, cache_image, xpm_load):
1161 Don't update size until alloc is done.
1162 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1164 Check for size calculation overflow.
1165 (ct_colors_allocated_max): New constant.
1166 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1169 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1170 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1171 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1172 Use ptrdiff_t, not int, to count maps.
1173 (read_char_minibuf_menu_prompt): Check for overflow in size
1174 calculations. Don't update size until allocation succeeds.
1175 Redo calculations to avoid overflow.
1176 * keyboard.h: Change prototypes to match the above.
1178 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1180 (current_minor_maps): Check for size calculation overflow.
1181 * keymap.h: Change prototypes to match the above.
1183 * lread.c (read1, init_obarray): Don't update size until alloc done.
1185 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1186 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1188 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1189 Now ptrdiff_t, not int.
1190 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1191 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1193 * process.c (Fnetwork_interface_list): Check for overflow
1194 in size calculation.
1196 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1198 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1199 overflow. Don't bother calling xmalloc when xrealloc will do.
1201 * search.c (Freplace_match): Check for size calculation overflow.
1202 (Fset_match_data): Don't assume list lengths fit in 'int'.
1204 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1205 for command line length. Do not attempt to address one before the
1206 beginning of an array, as that's not portable.
1208 * term.c (max_frame_lines): Remove; unused.
1209 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1211 (encode_terminal_code, calculate_costs): Check for size
1212 calculation overflow.
1213 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1214 table lengths and related sizes. Don't update size until alloc
1215 done. Redo calculations to avoid overflow.
1216 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1218 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1219 subtracting pointers.
1220 (gobble_line): Check for overflow more carefully. Don't update size
1223 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1224 Don't update size until alloc done.
1225 Redo size calculations to avoid overflow.
1226 Check for size calculation overflow.
1227 (main) [DEBUG]: Fix typo in invoking tparam1.
1229 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1230 Use ptrdiff_t, not int, for sizes.
1231 (store_mode_line_noprop_char): Don't update size until alloc done.
1233 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1234 Use ptrdiff_t, not int, for sizes.
1235 (Finternal_make_lisp_face, cache_face):
1236 Check for size calculation overflow.
1237 (cache_face): Treat size calculation overflows as if they were
1238 memory exhaustion (the usual treatment), rather than aborting.
1240 * xfns.c (x_encode_text, x_set_name_internal)
1241 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1242 sizes, since they can exceed INT_MAX in size. Check for size
1243 calculation overflow.
1245 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1246 (xg_select): Check for size calculation overflow.
1247 Don't update size until alloc done.
1249 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1250 as sprintf is limited to int lengths.
1252 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1253 (X_LONG_MIN): New macros.
1254 Use them to make the following changes clearer.
1255 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1256 This change doesn't affect the value now, but it may help remind
1257 future maintainers not to raise the value too much later.
1258 (SELECTION_QUANTUM): Remove, replacing with ...
1259 (selection_quantum): ... new function, which avoids overflow.
1261 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1262 assumption that selection length fits in 'int'.
1263 (x_reply_selection_request, x_handle_selection_request)
1264 (x_get_window_property, receive_incremental_selection)
1265 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1266 (lisp_data_to_selection_data, clean_local_selection_data):
1267 Use ptrdiff_t, not int, to record length of selection.
1268 (x_reply_selection_request, x_get_window_property)
1269 (receive_incremental_selection, x_property_data_to_lisp):
1270 Redo calculations to avoid overflow.
1271 (x_reply_selection_request): When sending hint, ceiling it at
1272 X_LONG_MAX rather than relying on wraparound overflow to send
1274 (x_get_window_property, receive_incremental_selection)
1275 (lisp_data_to_selection_data, x_property_data_to_lisp):
1276 Check for size-calculation overflow.
1277 (x_get_window_property, receive_incremental_selection)
1278 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1279 Don't store size until memory allocation succeeds.
1280 (x_get_window_property): Plug memory leak on memory exhaustion.
1281 Don't double-block input; malloc is safe here. Don't assume 2**34
1282 - 4 fits in unsigned long. Add an xassert to check
1283 XGetWindowProperty overflow. Be more careful about overflow
1284 calculations, and distinguish size from memory overflow better.
1285 (receive_incremental_selection): When tracing, don't assume
1286 unsigned int is less than INT_MAX.
1287 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1288 harmful) conversions of unsigned short to int.
1289 (lisp_data_to_selection_data): Don't assume that integers
1290 in the range -65535 through -1 fit in an X unsigned short.
1291 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1292 result parameters unless successful. Rely on cons_to_unsigned
1293 to report problems with elements; the old code wasn't right anyway.
1294 (x_check_property_data): Check for int overflow; we cannot use
1295 a wider type due to X limits.
1296 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1298 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1300 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1301 (x_term_init): Check for size calculation overflow.
1302 (x_color_cells): Don't store size until memory allocation succeeds.
1303 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1304 Don't assume alloca size is less than MAX_ALLOCA.
1305 (x_term_init): Don't assume length fits in int (sprintf is limited
1308 Use ptrdiff_t for composition IDs.
1309 * character.c (lisp_string_width):
1310 * composite.c (composition_table_size, n_compositions)
1311 (get_composition_id, composition_gstring_from_id):
1312 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1313 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1314 * window.c (Frecenter):
1315 Use ptrdiff_t, not int, for composition IDs.
1316 * composite.c (get_composition_id): Check for integer overflow.
1317 * composite.h: Adjust prototypes to match the above changes.
1319 Use ptrdiff_t for hash table indexes.
1320 * category.c (hash_get_category_set):
1321 * ccl.c (ccl_driver):
1322 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1323 * coding.c (coding_system_charset_list, detect_coding_system):
1324 * coding.h (struct coding_system.id):
1325 * composite.c (get_composition_id, gstring_lookup_cache):
1326 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1327 * image.c (xpm_get_color_table_h):
1328 * lisp.h (hash_lookup, hash_put):
1329 * minibuf.c (Ftest_completion):
1330 Use ptrdiff_t for hash table indexes, not int (which is too
1331 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1332 32-bit --with-wide-int hosts).
1334 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1335 Add a FIXME comment about memory leaks.
1336 (syms_of_charset): Don't assume xmalloc returns.
1338 Don't assume that stated character widths fit in int.
1339 * character.c (Fchar_width, c_string_width, lisp_string_width):
1340 * character.h (CHAR_WIDTH):
1341 * indent.c (MULTIBYTE_BYTES_WIDTH):
1342 Use sanitize_char_width to avoid undefined and/or bad behavior
1343 with outlandish widths.
1344 * character.h (sanitize_tab_width): Rename from sanitize_width,
1345 now that we have two such functions. All uses changed.
1346 (sanitize_char_width): New inline function.
1348 Don't assume that tab-width fits in int.
1349 * character.h (sanitize_width): New inline function.
1350 (SANE_TAB_WIDTH): New macro.
1351 (ASCII_CHAR_WIDTH): Use it.
1352 * indent.c (sane_tab_width): Remove. All uses replaced by
1353 SANE_TAB_WIDTH (current_buffer).
1354 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1356 * fileio.c: Integer overflow issues with file modes.
1357 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1359 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1360 Remove unreachable code.
1361 (read_hex, load_charset_map_from_file): Check for integer overflow.
1363 * xterm.c: don't go over XClientMessageEvent limit
1364 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1365 (x_send_scroll_bar_event): Likewise. Check that the size does not
1366 exceed limits imposed by XClientMessageEvent, as well as the usual
1367 ptrdiff_t and size_t limits.
1369 * keyboard.c: Overflow, signedness and related fixes.
1370 (make_lispy_movement): Use same integer type in forward decl
1371 that is used in the definition.
1372 (read_key_sequence, keyremap_step):
1373 Change bufsize argument back to int, undoing my 2011-03-30 change.
1374 We prefer signed types, and int is wide enough here.
1375 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1376 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1377 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1378 length, not size_t. Use ptrdiff_t for index, not int.
1379 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1380 possibility of integer overflow.
1382 Overflow, signedness and related fixes for images.
1384 * dispextern.h (struct it.stack[0].u.image.image_id)
1385 (struct_it.image_id, struct image.id, struct image_cache.size)
1386 (struct image_cache.used, struct image_cache.ref_count):
1387 * gtkutil.c (update_frame_tool_bar):
1388 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1389 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1390 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1391 * nsmenu.m (update_frame_tool_bar):
1392 * xdisp.c (calc_pixel_width_or_height):
1393 * xfns.c (image_cache_refcount):
1394 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1395 on typical 64-bit hosts.
1397 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1398 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1399 Omit unnecessary casts to int.
1400 (parse_image_spec): Check that integers fall into 'int' range
1401 when the callers expect that.
1402 (image_ascent): Redo ascent calculation to avoid int overflow.
1403 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1404 (lookup_image): Remove unnecessary tests.
1405 (xbm_image_p): Locals are now of int, not EMACS_INT,
1406 since parse_image_check makes sure they fit into int.
1407 (png_load, gif_load, svg_load_image):
1408 Prefer int to unsigned where either will do.
1409 (tiff_handler): New function, combining the cores of the
1410 old tiff_error_handler and tiff_warning_handler.
1411 This function is rewritten to use vsnprintf and thereby avoid
1412 stack buffer overflows. It uses only the features of vsnprintf
1413 that are common to both POSIX and native Microsoft.
1414 (tiff_error_handler, tiff_warning_handler): Use it.
1415 (tiff_load, gif_load, imagemagick_load_image):
1416 Don't assume :index value fits in 'int'.
1417 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1418 (imagemagick_load_image): Check that crop parameters fit into
1419 the integer types that MagickCropImage accepts. Don't assume
1420 Vimagemagick_render_type has a nonnegative value. Don't assume
1421 size_t fits in 'long'.
1422 (gs_load): Use printmax_t to print the widest integers possible.
1423 Check for integer overflow when computing image height and width.
1425 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1427 * xdisp.c (redisplay_window): Don't force window start if point
1428 will be invisible in the resulting window. (Bug#9324)
1430 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1432 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1433 the display spec is of the form `(space ...)'.
1434 (handle_display_spec): Return the value returned by
1435 handle_single_display_spec, not just 1 or zero.
1436 (handle_single_display_spec): If the display spec is of the form
1437 `(space ...)', and specifies display in the text area, return 2
1439 (try_cursor_movement): Check for the need to scroll more
1440 accurately, and prefer exact match for point under bidi.
1441 Don't advance `row' beyond the last row of the window.
1443 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1444 into disp_prop; all users changed.
1446 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1447 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1448 for the text covered by the display property.
1450 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1452 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1453 Change return value to nil.
1454 (Frecord_buffer): Delete unused function.
1456 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1458 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1459 buffers, return left-to-right.
1460 (set_cursor_from_row): Consider candidate row a win if its glyph
1461 represents a newline and point is on that newline. Fixes cursor
1462 positioning on the newline at EOL of R2L text within L2R
1463 paragraph, and vice versa.
1464 (try_cursor_movement): Check continued rows, in addition to
1465 continuation rows. Fixes unwarranted scroll when point enters a
1466 continued line of R2L text within an L2R paragraph, or vice versa.
1467 (cursor_row_p): Consider the case of point being equal to
1468 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1469 from the end of a short line to the beginning of a continued line
1470 of R2L text within L2R paragraph.
1471 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1472 composed characters.
1474 * bidi.c (bidi_check_type): Use xassert.
1475 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1478 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1480 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1483 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1485 * nsfont.m (ns_otf_to_script): Fix typo.
1487 2011-08-22 Kenichi Handa <handa@m17n.org>
1489 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1490 extra slot even if the purpose is char-code-property-table.
1492 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1494 * xdisp.c (redisplay_window): When computing centering_position,
1495 account for the height of the header line. (Bug#8874)
1497 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1498 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1499 candidate is selected by the mouse, and that candidate has a
1500 composed character under the mouse.
1502 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1503 coordinates reported by pos-visible-in-window-p for a composed
1504 character in column zero.
1506 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1508 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1510 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1512 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1513 consider it a hit if to_charpos is anywhere in the range of the
1514 composed buffer positions.
1516 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1518 * image.c (gif_load): Don't assume that each subimage has the same
1519 dimensions as the base image. Handle disposal method that is
1520 "undefined" by the gif spec (Bug#9335).
1522 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1524 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1525 (Fcondition_case): Document `debug' symbol in error handler.
1527 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1529 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1530 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1531 from an Org mode buffer to a Speedbar frame.
1533 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1534 a composition, take its buffer position from IT->cmp_it.charpos.
1535 Fixes cursor positioning at the beginning of a line that begins
1536 with a composed character.
1538 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1540 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1541 character bidirectional type, use STRONG_L instead. Fixes crashes
1542 in a buffer produced by `describe-categories'.
1544 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1545 members before the level stack, so they would be saved and
1546 restored when copying iterator state. Fixes incorrect reordering
1547 around TABs covered by display properties.
1549 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1551 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1553 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1555 * eval.c (internal_condition_case, internal_condition_case_1)
1556 (internal_condition_case_2, internal_condition_case_n):
1557 Remove unnecessary aborts (Bug#9081).
1559 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1561 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1562 has no `load' handler, try opening the file locally. (Bug#9311)
1564 2011-08-16 Ken Brown <kbrown@cornell.edu>
1566 * gmalloc.c: Expand comment.
1568 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1570 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1571 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1573 2011-08-16 Ken Brown <kbrown@cornell.edu>
1575 Fix memory allocation problems in Cygwin build (Bug#9273).
1577 * unexcw.c ( __malloc_initialized): Declare external variable.
1578 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1580 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1582 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1584 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1586 [CYGWIN] (special_realloc): New function.
1587 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1588 requests to realloc storage in the static heap.
1590 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1592 * bidi.c (bidi_initialize): Remove unused local.
1594 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1597 * biditype.h: Remove file.
1598 * makefile.w32-in ($(BLD)/bidi.$(O)):
1599 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1601 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1603 * chartab.c: Improve commentary for the uniprop_table API.
1605 * bidi.c (bidi_paragraph_init): Support zero value of
1606 bidi_ignore_explicit_marks_for_paragraph_level.
1607 (bidi_initialize): Use uniprop_table instead of including
1608 biditype.h and bidimirror.h.
1610 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1611 coordinates of the iterator when restoring from ppos_it.
1614 2011-08-14 Kenichi Handa <handa@m17n.org>
1616 * process.c (create_process): Call setup_process_coding_systems
1617 after the pid of the process is set to -1 (Bug#8162).
1619 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1621 * xdisp.c (move_it_in_display_line_to): Don't invoke
1622 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1623 ppos_it. Fixes vertical cursor motion when line beginning is
1624 covered by an image. (Bug#9296)
1626 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1628 * nsterm.h (ns_run_ascript): Declare.
1629 (NSAPP_DATA2_RUNASSCRIPT): Define.
1631 * nsfns.m (as_script, as_result, as_status): New static variables.
1632 (ns_run_ascript): New function.
1633 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1634 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1635 the event loop. Get status from as_status (Bug#7276).
1637 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1638 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1639 the event loop (Bug#7276).
1641 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1643 * gnutls.c (QCgnutls_bootprop_priority)
1644 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1645 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1646 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1647 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1648 (QCgnutls_bootprop_verify_hostname_error)
1649 (QCgnutls_bootprop_callbacks_verify): Rename from
1650 Qgnutls_bootprop_..., all uses changed.
1652 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1655 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1657 * xfaces.c (Qframe_set_background_mode): Now static.
1658 * dispextern.h (Qframe_set_background_mode): Remove decl.
1660 * process.c (Fnetwork_interface_info): Declare local only if needed.
1662 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1664 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1665 (Fnetwork_interface_list): Allocate in increments of bytes instead
1666 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1667 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1669 (struct ifflag_def): notrailers is smart on OSX.
1670 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1671 Get hardware address with getifaddrs if available.
1673 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1675 * xdisp.c (iterate_out_of_display_property): xassert that
1676 IT->position is set to within IT->object's boundaries. Break from
1677 the loop as soon as EOB is reached; avoids infloops in redisplay
1678 when IT->position is set up wrongly due to some bug.
1679 Set IT->current to match the bidi iterator unconditionally.
1680 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1681 entry. Force push_it to save on the stack the current
1682 buffer/string position, to be restored by pop_it. Fix flags in
1683 the iterator structure wrt the object coming from a display
1684 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1685 properties. (Bug#9284)
1687 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1689 * fontset.c (fontset_get_font_group): Add proper type checks.
1692 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1694 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1695 and LC_VERSION_MIN_MACOSX.
1696 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1697 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1699 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1701 * xdisp.c (forward_to_next_line_start): Allow to use the
1702 no-display-properties-and-no-overlays under bidi display.
1703 Set disp_pos in the bidi iterator to avoid searches for display
1704 properties and overlays.
1706 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1708 * editfns.c (Fset_time_zone_rule): Document relationship with the
1711 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1712 the font entity extracted from the cache (Bug#8109).
1714 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1716 * composite.c (autocmp_chars): Don't reset point. That is done by
1717 restore_point_unwind (Bug#5984).
1719 2011-08-07 Juri Linkov <juri@jurta.org>
1721 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1722 to show the arg `TIME' instead of `TIMEVAL'.
1724 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1726 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1727 display property strides EOL and includes a newline, as in
1728 longlines-mode. (Bug#9254)
1729 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1730 word-wrap under bidirectional display. (Bug#9224)
1732 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1733 is non-zero, even if the data buffer is NULL. Fixes a crash in
1734 vertical-motion with longlines-mode. (Bug#9254)
1736 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1738 * bidi.c <bidi_cache_total_alloc>: Now static.
1739 (bidi_initialize): Initialize bidi_cache_total_alloc.
1741 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1744 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1745 amount allocated this far in `bidi_cache_total_alloc'.
1746 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1747 non-zero, only free the data buffer without restoring the cache
1748 contents. All callers changed.
1750 * dispextern.h (bidi_unshelve_cache): Update prototype.
1752 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1753 (move_it_in_display_line, move_it_to)
1754 (move_it_vertically_backward, move_it_by_lines): Replace the call
1755 to xfree to an equivalent call to bidi_unshelve_cache.
1756 (move_it_in_display_line_to): Fix logic of returning
1757 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1759 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1761 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1762 came from a string character with a `cursor' property. (Bug#9229)
1764 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1766 * Makefile.in (LIB_PTHREAD): New variable.
1767 (LIBES): Add LIB_PTHREAD (Bug#9216).
1769 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1770 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1772 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1774 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1776 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1778 * xterm.c (x_find_topmost_parent): New function.
1779 (x_set_frame_alpha): Find topmost parent window with
1780 x_find_topmost_parent and set the property there also (bug#9181).
1781 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1783 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1785 * callproc.c (Fcall_process): Avoid vfork clobbering
1786 the local vars buffer, coding_systems, current_dir.
1788 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1790 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1792 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1794 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1795 so that it is not optimized away.
1797 * xdisp.c (compute_display_string_pos): Remove unused local.
1799 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1801 Fix slow cursor motion and scrolling in large buffers with
1802 selective display, like Org Mode buffers. (Bug#9218)
1804 * dispextern.h (struct bidi_it): New member disp_prop_p.
1806 * xdisp.c: Remove one-slot cache of display string positions.
1807 (compute_display_string_pos): Accept an additional argument
1808 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1809 for a display string or property. If found, set DISP_PROP_P
1812 * bidi.c (bidi_fetch_char): Accept an additional argument
1813 DISP_PROP_P, and pass it to compute_display_string_pos.
1814 Only handle text covered by a display string if DISP_PROP_P is returned
1815 non-zero. All callers of bidi_fetch_char changed.
1817 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1819 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1821 2010-12-03 Don March <don@ohspite.net>
1823 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1824 last character M-[char] is translated to ESC [char] (bug#7541).
1826 2011-08-02 Kenichi Handa <handa@m17n.org>
1828 * lisp.h (uniprop_table): Extern it.
1830 * chartab.c (uniprop_table): Make it non-static.
1832 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1834 * xdisp.c (forward_to_next_line_start): Accept additional argument
1835 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1837 (reseat_at_next_visible_line_start): Use the bidi iterator state
1838 returned by forward_to_next_line_start to restore the state of
1839 it->bidi_it after backing up to previous newline. (Bug#9212)
1841 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1843 * regex.c (re_comp): Protoize.
1844 (re_exec): Fix return type.
1845 (regexec): Fix type of `ret'. (Bug#9203)
1847 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1849 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1850 This is needed if max-image-size is a floating-point number.
1852 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1854 * print.c (print_object): Print empty symbol as ##.
1856 * lread.c (read1): Read ## as empty symbol.
1858 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1860 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1861 setting frame foreground color (Bug#9175).
1862 (x_set_background_color): Likewise.
1864 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1865 contents (Bug#9176).
1866 (EmacsTooltip -init): Remove bezels and add shadows to
1869 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1870 or scroll bar (Bug#8470).
1872 * nsfont.m (nsfont_open): Remove assignment to voffset and
1873 unnecessary vars hshink, expand, hd, full_height, min_height.
1874 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1876 * nsterm.h (nsfont_info): Remove voffset field.
1878 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1880 Implement strike-through and overline on NextStep (Bug#8863).
1882 * nsfont.m (nsfont_open): Use underline position provided by font,
1883 instead of hard-coded value of 2.
1884 (nsfont_draw): Call ns_draw_text_decoration instead.
1886 * nsterm.h: Add declaration for ns_draw_text_decoration.
1888 * nsterm.m (ns_draw_text_decoration): New function for drawing
1889 underline, overline, and strike-through.
1890 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1891 ns_draw_text_decoration. Change treatment of cursor drawing to
1892 accommodate underlining, etc.
1894 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1896 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1899 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1901 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1902 Without this fix, if a signal arrives just after memory fills up,
1903 'malloc' might be invoked reentrantly.
1905 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1906 In other words, assume that every image size is allowed, on non-X
1907 hosts. This assumption is probably wrong, but it lets Emacs compile.
1909 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1911 * regex.c (re_iswctype): Convert return values to boolean.
1913 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1915 * xdisp.c (compute_display_string_pos): Don't use cached display
1916 string position if the buffer had its restriction changed.
1919 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1921 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1923 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1925 Integer signedness and overflow and related fixes. (Bug#9079)
1927 * bidi.c: Integer size and overflow fixes.
1928 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1929 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1930 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1931 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1932 (bidi_find_other_level_edge):
1933 Use ptrdiff_t instead of EMACS_INT where either will do.
1934 This works better on 32-bit hosts configured --with-wide-int.
1935 (bidi_cache_ensure_space): Check for size-calculation overflow.
1936 Use % rather than repeated addition, for better worst-case speed.
1937 Don't set bidi_cache_size until after xrealloc returns, because it
1939 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1940 (bidi_cache_ensure_space): Also check that the bidi cache size
1941 does not exceed that of the largest Lisp string or buffer. See Eli
1942 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1944 * alloc.c (__malloc_size_t): Remove.
1945 All uses replaced by size_t. See Andreas Schwab's note
1946 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1948 * image.c: Improve checking for integer overflow.
1949 (check_image_size): Assume that f is nonnull, since
1950 it is always nonnull in practice. This is one less thing to
1951 worry about when checking for integer overflow later.
1952 (x_check_image_size): New function, which checks for integer
1953 overflow issues inside X.
1954 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1955 This removes the need for a memory_full check.
1956 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1957 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1958 (xbm_read_bitmap_data): Change locals back to 'int', since
1959 their values must fit in 'int'.
1960 (xpm_load_image, png_load, tiff_load):
1961 Invoke x_create_x_image_and_pixmap earlier,
1962 to avoid much needless work if the image is too large.
1963 (tiff_load): Treat overly large images as if
1964 x_create_x_image_and_pixmap failed, not as malloc failures.
1965 (gs_load): Use x_check_image_size.
1967 * gtkutil.c: Omit integer casts.
1968 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1969 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1971 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1973 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1974 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1975 would wrongly return t on a 64-bit host.
1977 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1978 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1979 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1980 and therefore cause GCC to emit a bogus diagnostic in some cases.
1982 * image.c: Integer signedness and overflow and related fixes.
1983 This is not an exhaustive set of fixes, but it's time to
1984 record what I've got.
1985 (lookup_pixel_color, check_image_size): Remove redundant decls.
1986 (check_image_size): Don't assume that arbitrary EMACS_INT values
1987 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1988 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1989 (tiff_load, imagemagick_load_image):
1990 Check for overflow in size calculations.
1991 (x_create_x_image_and_pixmap): Remove unnecessary test for
1992 xmalloc returning NULL; that can't happen.
1993 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1994 (xpm_color_bucket): Use better integer hashing function.
1995 (xpm_cache_color): Don't possibly over-allocate memory.
1996 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1997 (gif_memory_source):
1998 Use ptrdiff_t, not int or size_t, to record sizes.
1999 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2000 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2001 either works, as we prefer signed integers.
2002 (tiff_read_from_memory, tiff_write_from_memory):
2003 Return tsize_t, not size_t, since that's what the TIFF API wants.
2004 (tiff_read_from_memory): Don't fail simply because the read would
2005 go past EOF; instead, return a short read.
2006 (tiff_load): Omit no-longer-needed casts.
2007 (Fimagemagick_types): Don't assume size fits into 'int'.
2009 Improve hashing quality when configured --with-wide-int.
2010 * fns.c (hash_string): New function, taken from sxhash_string.
2011 Do not discard information about ASCII character case; this
2012 discarding is no longer needed.
2013 (sxhash-string): Use it. Change sig to match it. Caller changed.
2014 * lisp.h: Declare it.
2015 * lread.c (hash_string): Remove, since we now use fns.c's version.
2016 The fns.c version returns a wider integer if --with-wide-int is
2017 specified, so this should help the quality of the hashing a bit.
2019 * emacs.c: Integer overflow minor fix.
2020 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2021 Define only if GNU_LINUX.
2022 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2024 * dispnew.c: Integer signedness and overflow fixes.
2025 Remove unnecessary forward decls, that were a maintenance hassle.
2026 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2028 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2029 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2030 (prepare_desired_row, line_draw_cost):
2031 Use int, not unsigned, where either works.
2032 (save_current_matrix, restore_current_matrix):
2033 Use ptrdiff_t, not size_t, where either works.
2034 (init_display): Check for overflow more accurately, and without
2035 relying on undefined behavior.
2037 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2038 Remove, replacing with the new symbols in lisp.h. All uses changed.
2039 * fileio.c (make_temp_name):
2040 * filelock.c (lock_file_1, lock_file):
2041 * xdisp.c (message_dolog):
2042 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2043 Use pMd etc. instead.
2044 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2045 replacing the pWIDE etc. symbols removed from editfns.c.
2047 * keyboard.h (num_input_events): Now uintmax_t.
2048 This is (very slightly) less likely to mess up due to wraparound.
2051 * buffer.c: Integer signedness fixes.
2052 (alloc_buffer_text, enlarge_buffer_text):
2053 Use ptrdiff_t rather than size_t when either will do, as we prefer
2056 * alloc.c: Integer signedness and overflow fixes.
2057 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2058 (__malloc_size_t): Default to size_t, not to int.
2059 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2060 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2061 Prefer ptrdiff_t to size_t when either would do, as we prefer
2063 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2064 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2065 Now const. Initialize with values that are in range even if char
2067 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2068 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2069 These functions do the right thing with sizes > 2**32.
2070 (check_depth): Now ptrdiff_t, not int.
2071 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2072 Adjust to new way of storing sizes. Check for size overflow bugs
2074 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2075 slightly wrong anyway, as it missed one instance of
2076 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2077 (refill_memory_reserve): Omit needless cast to size_t.
2078 (mark_object_loop_halt): Mark as externally visible.
2080 * xselect.c: Integer signedness and overflow fixes.
2081 (Fx_register_dnd_atom, x_handle_dnd_message):
2082 Use ptrdiff_t, not size_t, since we prefer signed.
2083 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2084 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2085 x_dnd_atoms_size and x_dnd_atoms_length.
2087 * doprnt.c: Prefer signed to unsigned when either works.
2089 * doprnt.c (doprnt):
2091 * xdisp.c (vmessage):
2092 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2093 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2094 prefer signed arithmetic to avoid comparison confusion.
2095 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2096 but is a bit tricky.
2098 Assume freestanding C89 headers, string.h, stdlib.h.
2099 * data.c, doprnt.c, floatfns.c, print.c:
2100 Include float.h unconditionally.
2101 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2102 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2103 * regex.c: Likewise for stddef.h, string.h.
2104 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2105 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2106 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2107 (STDC_HEADERS): Remove obsolete defines.
2108 * sysdep.c: Include limits.h unconditionally.
2110 Assume support for memcmp, memcpy, memmove, memset.
2111 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2112 * regex.c (memcmp, memcpy):
2113 Remove; we assume C89 now.
2115 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2116 (__malloc_safe_bcopy): Remove; no longer needed.
2118 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2119 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2120 well either way, and we prefer signed to unsigned.
2122 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2124 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2125 closes the connection while we're reading (bug#9182).
2127 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2129 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2130 are specified (Bug#9168).
2132 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2134 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2135 Found by GCC static checking and --with-wide-int on a 32-bit host.
2137 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2139 * xdisp.c (compute_display_string_pos): Fix logic of caching
2140 previous display string position. Initialize cached_prev_pos to
2141 -1. Fixes slow-down at the beginning of a buffer.
2143 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2145 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2146 for attrs[LFACE_FONTSET_INDEX].
2148 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2150 * xml.c (parse_region): Remove unused local
2151 that was recently introduced.
2153 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2155 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2156 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2158 * xdisp.c (move_it_in_display_line_to): Record the best matching
2159 position for TO_CHARPOS while scanning the line, and restore it on
2160 exit if none of the characters scanned was an exact match.
2161 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2162 when exact match is impossible due to invisible text, and the
2163 lines are truncated.
2165 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2167 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2170 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2172 Fix a significant slow-down of cursor motion with C-n, C-p,
2173 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2174 auto-repeat under bidi redisplay in fontified buffers.
2175 * xdisp.c (compute_stop_pos_backwards): New function.
2176 (next_element_from_buffer): Call compute_stop_pos_backwards to
2177 find a suitable prev_stop when we find ourselves before
2179 (reseat): Don't look for prev_stop, as that could mean a very long
2181 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2182 <cached_disp_overlay_modiff>: Cache for last found display string
2184 (compute_display_string_pos): Return the cached position if asked
2185 about the same buffer in the same area of character positions, and
2186 the buffer wasn't changed since the time the display string
2187 position was cached.
2189 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2191 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2192 is an integer, which is important for empty lines. (Bug#9149)
2194 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2196 * frame.c (Fmodify_frame_parameters): In tty case, update the
2197 default face if necessary (Bug#4238).
2199 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2201 * editfns.c (Fstring_to_char): No need to explain what a character
2202 is in the docstring (Bug#6576).
2204 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2206 * xml.c (parse_region): Make sure we always return a tree.
2208 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2210 * xml.c (parse_region): If a document contains only comments,
2213 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2215 * xml.c (make_dom): Return comments, too.
2217 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2220 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2221 and the surrounding thread.
2222 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2223 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2224 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2226 * s/openbsd.h (BROKEN_SIGIO): Define.
2227 * unexelf.c (unexec) [__OpenBSD__]:
2228 Don't update the .mdebug section of the Alpha COFF symbol table.
2230 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2232 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2235 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2237 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2238 This fixes some race conditions on the permissions of any newly
2241 * alloc.c (valid_pointer_p): Use pipe, not open.
2242 This fixes some permissions issues when debugging.
2244 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2245 If fchown fails to set both uid and gid, try to set just gid,
2246 as that is sometimes allowed. Adjust the file's mode to eliminate
2247 setuid or setgid bits that are inappropriate if fchown fails.
2249 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2251 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2252 to compare Lisp_Objects.
2253 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2254 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2255 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2257 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2259 * lread.c (read_integer): Unread even EOF character.
2260 (read1): Likewise. Properly record start position of symbol.
2262 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2263 symbol character follows.
2265 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2267 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2268 This works around a problem with the previous change to Fcopy_file.
2269 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2270 and without this change, GCC might complain about discarding
2271 fchown's return value.
2273 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2275 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2277 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2279 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2281 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2283 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2284 it's used from the C level.
2286 * process.c: Use the same condition for POLL_FOR_INPUT in both
2287 keyboard.c and process.c (bug#1858).
2289 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2291 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2292 (Fgnutls_boot): Use it.
2294 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2296 * doc.c (Fsubstitute_command_keys): Revert last change.
2298 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2300 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2301 quotes the next character, and doesn't affect other longer
2302 sequences (bug#8935).
2304 * lread.c (syms_of_lread): Clarify that is isn't only
2305 `eval-buffer' and `eval-defun' that's affected by
2306 `lexical-binding' (bug#8460).
2308 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2310 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2311 bidi redisplay when a line includes both an image and is truncated.
2313 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2315 Fix minor problems found by static checking.
2316 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2317 (elsz): Now a signed constant, not a size_t var. We prefer signed
2318 types to unsigned, to avoid integer comparison confusion. Without
2319 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2320 "cannot optimize loop, the loop counter may overflow", a symptom
2322 * indent.c (Fvertical_motion): Mark locals as initialized.
2323 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2325 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2327 * search.c (Fre_search_backward): Mention `case-fold-search' in
2328 all the re_search_* functions (bug#8138).
2330 * keyboard.c (Fopen_dribble_file): Document when the file is
2333 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2335 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2338 Support bidi reordering of display and overlay strings.
2339 * xdisp.c (compute_display_string_pos)
2340 (compute_display_string_end): Accept additional argument STRING.
2341 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2342 (reseat_to_string): Initialize bidi_it->string.s and
2343 bidi_it->string.schars.
2344 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2345 NULL (avoids a crash in bidi_paragraph_init).
2346 Initialize itb.string.lstring.
2347 (init_iterator): Call bidi_init_it only of a valid
2348 buffer position was specified. Initialize paragraph_embedding to
2350 (reseat_to_string): Initialize the bidi iterator.
2351 (display_string): If we need to ignore text properties of
2352 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2353 original value of -1 will not work with bidi.)
2354 (compute_display_string_pos): First arg is now struct
2355 `text_pos *'; all callers changed. Support display properties on
2357 (compute_display_string_end): Support display properties on Lisp
2359 (init_iterator, reseat_1, reseat_to_string): Initialize the
2360 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2361 when iterating on a string not from display properties).
2362 (compute_display_string_pos, compute_display_string_end):
2363 Fix calculation of the object to scan. Fixes an error when using
2365 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2366 base_level_stop; instead, set base_level_stop to BEGV.
2367 Fixes crashes in vertical-motion.
2368 (next_element_from_buffer): Improve commentary for when
2369 the iterator is before prev_stop.
2370 (init_iterator): Initialize bidi_p from the default value of
2371 bidi-display-reordering, not from buffer-local value. Use the
2372 buffer-local value only if initializing for buffer iteration.
2373 (handle_invisible_prop): Support invisible properties on strings
2374 that are being bidi-reordered.
2375 (set_iterator_to_next): Support bidi reordering of C strings and
2377 (next_element_from_string): Support bidi reordering of Lisp
2379 (handle_stop_backwards): Support Lisp strings as well.
2380 (display_string): Support display of R2L glyph rows.
2381 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2382 (init_iterator): Don't initialize it->bidi_p for strings
2384 (reseat_to_string): Initialize it->bidi_p for strings here.
2385 (next_element_from_string, next_element_from_c_string)
2386 (next_element_from_buffer): Add xassert's for correspondence
2387 between IT's object being iterated and it->bidi_it.string
2389 (face_before_or_after_it_pos): Support bidi iteration.
2390 (next_element_from_c_string): Handle the case of the first string
2391 character that is not the first one in the visual order.
2392 (get_visually_first_element): New function, refactored from common
2393 parts of next_element_from_buffer, next_element_from_string, and
2394 next_element_from_c_string.
2395 (tool_bar_lines_needed, redisplay_tool_bar)
2396 (display_menu_bar): Force left-to-right direction. Add a FIXME
2397 comment for making that be controlled by a user option.
2398 (push_it, pop_it): Save and restore the state of the
2399 bidi iterator. Save and restore the bidi_p flag.
2400 (pop_it): Iterate out of display property for string iteration as
2402 (iterate_out_of_display_property): Support iteration over strings.
2403 (handle_single_display_spec): Set up it->bidi_it for iteration
2404 over a display string, and call bidi_init_it.
2405 (handle_single_display_spec, next_overlay_string)
2406 (get_overlay_strings_1, push_display_prop): Set up the bidi
2407 iterator for displaying display or overlay strings.
2408 (forward_to_next_line_start): Don't use the shortcut if
2410 (back_to_previous_visible_line_start): If handle_display_prop
2411 pushed the iterator stack, restore the internal state of the bidi
2412 iterator by calling bidi_pop_it same number of times.
2413 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2414 and we are bidi-iterating, don't decrement the iterator position;
2415 instead, set the first_elt flag in the bidi iterator, to produce
2417 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2418 (push_display_prop): xassert that we are iterating a buffer.
2419 (push_it, pop_it): Save and restore paragraph_embedding member.
2420 (handle_single_display_spec, next_overlay_string)
2421 (get_overlay_strings_1, reseat_1, reseat_to_string)
2422 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2423 correctly. Don't assume unibyte strings are not bidi-reordered.
2424 (compute_display_string_pos)
2425 (compute_display_string_end): Fix handling the case of C string.
2426 (push_it, pop_it): Save and restore from_disp_prop_p.
2427 (handle_single_display_spec, push_display_prop): Set the
2428 from_disp_prop_p flag.
2429 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2430 (pop_it): Call iterate_out_of_display_property only if we are
2431 popping after iteration over a string that came from a display
2432 property. Fix a typo in popping stretch info. Add an assertion
2433 for verifying that the iterator position is in sync with the bidi
2435 (handle_single_display_spec, get_overlay_strings_1)
2436 (push_display_prop): Fix initialization of paragraph direction for
2437 string when that of the parent object is not yet determined.
2438 (reseat_1): Call bidi_init_it to resync the bidi
2439 iterator with IT's position. (Bug#7616)
2440 (find_row_edges): If ROW->start.pos gives position
2441 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2442 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2443 Reset the from_disp_prop_p flag.
2444 (SAVE_IT, RESTORE_IT): New macros.
2445 (pos_visible_p, face_before_or_after_it_pos)
2446 (back_to_previous_visible_line_start)
2447 (move_it_in_display_line_to, move_it_in_display_line)
2448 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2449 (try_scrolling, redisplay_window, display_line): Use them when
2450 saving a temporary copy of the iterator and restoring it back.
2451 (back_to_previous_visible_line_start, reseat_1)
2452 (init_iterator): Empty the bidi cache "stack".
2453 (move_it_in_display_line_to): If iterator ended up at
2454 EOL, but we never saw any buffer positions smaller than
2455 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2456 motion in bidi-reordered lines.
2457 (move_it_in_display_line_to): Record prev_method and prev_pos
2458 immediately before the call to set_iterator_to_next. Fixes cursor
2459 motion in bidi-reordered lines with stretch glyphs and strings
2460 displayed in margins. (Bug#8133) (Bug#8867)
2461 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2463 (pos_visible_p): Support positions in bidi-reordered lines.
2464 Save and restore bidi cache.
2466 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2467 (bidi_paragraph_info): Delete unused struct.
2468 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2469 (bidi_cache_start): New variable.
2470 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2472 (bidi_cache_fetch_state, bidi_cache_search)
2473 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2474 (bidi_cache_find, bidi_peek_at_next_level)
2475 (bidi_level_of_next_char, bidi_find_other_level_edge)
2476 (bidi_move_to_visually_next): Compare cache index with
2477 bidi_cache_start rather than with zero.
2478 (bidi_fetch_char): Accept new argument STRING; all callers
2479 changed. Support iteration over a string. Support strings with
2480 display properties. Support unibyte strings. Fix the type of
2481 `len' according to what STRING_CHAR_AND_LENGTH expects.
2482 (bidi_paragraph_init, bidi_resolve_explicit_1)
2483 (bidi_resolve_explicit, bidi_resolve_weak)
2484 (bidi_level_of_next_char, bidi_move_to_visually_next):
2485 Support iteration over a string.
2486 (bidi_set_sor_type, bidi_resolve_explicit_1)
2487 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2488 can now be zero (for strings); special values 0 and -1 were
2489 changed to -1 and -2, respectively.
2490 (bidi_char_at_pos): New function.
2491 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2492 Call it instead of FETCH_MULTIBYTE_CHAR.
2493 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2494 initialized to valid values.
2495 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2497 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2498 the test for valid cached positions. Fix the logic for looking up
2499 the sentinel state in the cache. GCPRO the Lisp string we are
2501 (bidi_push_it, bidi_pop_it): New functions.
2502 (bidi_initialize): Initialize the bidi cache start stack pointer.
2503 (bidi_cache_ensure_space): New function, refactored from part of
2504 bidi_cache_iterator_state. Don't assume the required size is just
2505 one BIDI_CACHE_CHUNK away.
2506 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2507 (bidi_count_bytes, bidi_char_at_pos): New functions.
2508 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2509 always valid if bidi_cache_idx is valid.
2510 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2511 is valid if it's going to be used.
2512 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2513 (bidi_cache_fetch_state, bidi_cache_search)
2514 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2515 (bidi_cache_iterator_state, bidi_cache_find)
2516 (bidi_find_other_level_edge, bidi_cache_start_stack):
2517 All variables related to cache indices are now EMACS_INT.
2519 * dispextern.h (struct bidi_string_data): New structure.
2520 (struct bidi_it): New member `string'. Make flag members be 1-bit
2521 fields, and put them last in the struct.
2522 (compute_display_string_pos, compute_display_string_end):
2524 (bidi_push_it, bidi_pop_it): Add prototypes.
2525 (struct iterator_stack_entry): New members bidi_p,
2526 paragraph_embedding, and from_disp_prop_p.
2527 (struct it): Member bidi_p is now a bit field 1 bit wide.
2528 (bidi_shelve_cache, bidi_unshelve_cache):
2531 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2532 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2533 and vector-like objects.
2535 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2536 cache around display iteration.
2538 * window.c (Fwindow_end, window_scroll_pixel_based)
2539 (displayed_window_lines, Frecenter): Save and restore the bidi
2540 cache around display iteration.
2542 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2544 * editfns.c (Fdelete_region): Clarify the use of the named
2545 parameters (bug#6788).
2547 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2549 * indent.c (Fvertical_motion): Set and restore w->pointm when
2550 saving and restoring the window's buffer (Bug#9006).
2552 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2554 * editfns.c (Fstring_to_char): Clarify just what is returned
2555 (bug#6576). Text by Eli Zaretskii.
2557 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2559 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2561 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2563 * buffer.c (mmap_find): Fix a typo.
2565 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2567 Fix execution of x selection hooks.
2568 * xselect.c (Qx_lost_selection_functions)
2569 (Qx_sent_selection_functions): New vars.
2570 (syms_of_xselect): DEFSYM them.
2571 (x_handle_selection_request): Pass Qx_sent_selection_functions
2572 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2573 (x_handle_selection_clear,x_clear_frame_selections):
2574 Pass Qx_lost_selection_functions rather than
2575 Vx_lost_selection_functions to Frun_hook_with_args.
2577 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2579 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2580 The old code sometimes used this field without initializing it.
2582 * alloc.c (gc_sweep): Don't read past end of array.
2583 In theory, the old code could also have corrupted Emacs internals,
2584 though it'd be very unlikely.
2586 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2588 * character.c (Fcharacterp): Don't advertise optional ignored
2589 argument. (Bug#4026)
2591 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2593 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2596 * window.c (Fset_window_start): Doc fix (bug#4199).
2597 (Fset_window_hscroll): Ditto.
2599 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2601 Fix minor new problems caught by GCC 4.6.1.
2602 * term.c (init_tty): Remove unused local.
2603 * xsettings.c (store_monospaced_changed): Define this function only
2604 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2607 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2609 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2611 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2613 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2614 are the mini-buffer and the echo area (bug#3320).
2616 * term.c (init_tty): Remove support for supdup, c10 and perq
2617 terminals, which are no longer supported (bug#1482).
2619 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2621 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2623 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2625 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2626 for non-popups (Bug#3642).
2628 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2630 * alloc.c (reset_malloc_hooks): Protoize.
2631 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2632 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2633 * cm.c (losecursor): Likewise.
2634 * data.c (fmod): Likewise.
2635 * dispnew.c (swap_glyphs_in_rows): Likewise.
2636 * emacs.c (memory_warning_signal): Likewise.
2637 * floatfns.c (float_error): Likewise.
2638 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2639 (otf_open, font_otf_capability, generate_otf_features)
2640 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2642 * image.c (pbm_read_file): Likewise.
2643 * indent.c (string_display_width): Likewise.
2644 * intervals.c (check_for_interval, search_for_interval)
2645 (inc_interval_count, count_intervals, root_interval)
2646 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2647 * lread.c (defalias): Likewise.
2648 * ralloc.c (r_alloc_check): Likewise.
2649 * regex.c (set_image_of_range_1, set_image_of_range)
2650 (regex_grow_registers): Likewise.
2651 * sysdep.c (strerror): Likewise.
2652 * termcap.c (valid_filename_p, tprint, main): Likewise.
2653 * tparam.c (main): Likewise.
2654 * unexhp9k800.c (run_time_remap, save_data_space)
2655 (update_file_ptrs, read_header, write_header, calculate_checksum)
2656 (copy_file, copy_rest, display_header): Likewise.
2657 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2659 * xdisp.c (check_it): Likewise.
2660 * xfaces.c (register_color, unregister_color, unregister_colors):
2662 * xfns.c (print_fontset_result): Likewise.
2663 * xrdb.c (member, fatal, main): Likewise.
2665 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2667 Fix minor problems found by static checking (Bug#9031).
2668 * chartab.c (char_table_set_range, map_sub_char_table):
2669 Remove unused locals.
2670 (uniprop_table): Now static.
2671 * composite.c (_work_char): Remove unused static var.
2673 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2675 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2677 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2679 * gtkutil.c (qttip_cb): Remove code without function.
2681 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2683 * w32.c (pthread_sigmask): New stub.
2685 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2687 Use pthread_sigmask, not sigprocmask (Bug#9010).
2688 sigprocmask is portable only for single-threaded applications, and
2689 Emacs can be multi-threaded when it uses GTK.
2690 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2692 * callproc.c (Fcall_process):
2693 * process.c (create_process):
2694 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2695 Use pthread_sigmask, not sigprocmask.
2697 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2699 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2700 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2703 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2705 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2706 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2707 (xg_hide_tooltip): Fix comment.
2709 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2710 in registerServicesMenuSendTypes.
2711 (validRequestorForSendType): Don't check ns_return_types.
2713 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2716 2011-07-08 Jason Rumney <jasonr@gnu.org>
2718 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2719 frame struct members of non-existent frames (Bug#6284).
2721 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2723 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2724 variable firstTime not needed on OSX >= 10.6.
2725 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2726 >= 10.5. Use setKnobProportion, setDoubleValue.
2728 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2729 (MAC_OS_X_VERSION_10_5): Define if not defined.
2730 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2731 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2732 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2734 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2735 cString and lossyCString on OSX >= 10.4
2737 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2738 sizeToFit on OSX >= 10.2.
2740 * nsimage.m (allocInitFromFile): Don't use deprecated method
2741 bestRepresentationForDevice on OSX >= 10.6.
2743 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2746 * emacs.c: Declare unexec_init_emacs_zone.
2748 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2750 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2752 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2753 on svcsMenu (Bug#8842).
2755 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2757 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2759 * nsterm.m (QUTF8_STRING): Declare.
2760 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2761 (validRequestorForSendType): Return type is (id).
2762 Change indexOfObjectIdenticalTo to indexOfObject.
2763 Check if we have local selection before returning self (Bug#8842).
2764 (writeSelectionToPasteboard): Put local selection into paste board
2765 if we have a local selection (Bug#8842).
2766 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2768 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2769 (ns_get_local_selection): Declare.
2771 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2773 * keymap.c (describe_map_tree): Don't insert a double newline at
2774 the end of the buffer (bug#1169) and return whether we inserted
2777 * callint.c (Fcall_interactively): Change "reading args" to
2778 "providing args" to try to clarify what it does (bug#1010).
2780 2011-07-07 Kenichi Handa <handa@m17n.org>
2782 * composite.c (composition_compute_stop_pos): Ignore a static
2783 composition starting before CHARPOS (Bug#8915).
2785 * xdisp.c (handle_composition_prop): Likewise.
2787 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2789 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2792 2011-07-07 Kenichi Handa <handa@m17n.org>
2794 * character.h (unicode_category_t): New enum type.
2796 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2797 (Qchar_code_property_table): New variable.
2798 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2799 (UNIPROP_COMPRESSED_FORM_P): New macros.
2800 (char_table_ascii): Uncompress the compressed values.
2801 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2802 Uncompress the compressed values.
2803 (sub_char_table_ref_and_range): Likewise.
2804 (char_table_ref_and_range): Uncompress the compressed values.
2805 (sub_char_table_set): New arg is_uniprop. Callers changed.
2806 Uncompress the compressed values.
2807 (sub_char_table_set_range): Args changed. Callers changed.
2808 (char_table_set_range): Adjuted for the above change.
2809 (map_sub_char_table): Delete args default_val and parent. Add arg
2810 top. Give decoded values to a Lisp function.
2811 (map_char_table): Adjust for the above change. Give decoded
2812 values to a Lisp function. Gcpro more variables.
2813 (uniprop_table_uncompress)
2814 (uniprop_decode_value_run_length): New functions.
2815 (uniprop_decoder, uniprop_decoder_count): New variables.
2816 (uniprop_get_decoder, uniprop_encode_value_character)
2817 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2819 (uniprop_encoder, uniprop_encoder_count): New variables.
2820 (uniprop_get_encoder, uniprop_table)
2821 (Funicode_property_table_internal, Fget_unicode_property_internal)
2822 (Fput_unicode_property_internal): New functions.
2823 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2824 Sunicode_property_table_internal, Sget_unicode_property_internal,
2825 and Sput_unicode_property_internal. Defvar_lisp
2826 char-code-property-alist.
2828 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2829 Vunicode_category_table.
2831 * font.c (font_range): Adjust for the change of
2832 Vunicode_category_table.
2834 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2836 * m/iris4d.h: Remove file, move contents ...
2837 * s/irix6-5.h: ... here.
2839 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2841 Remove unportable assumption about struct layout (Bug#8884).
2842 * alloc.c (mark_buffer):
2843 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2844 (clone_per_buffer_values): Don't assume that
2845 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2846 This isn't true in general, and it's particularly not true
2847 if Emacs is configured with --with-wide-int.
2848 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2849 New macros, used in the buffer.c change.
2851 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2853 * xsettings.c: Use both GConf and GSettings if both are available.
2854 (store_config_changed_event): Add comment.
2855 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2856 (store_tool_bar_style_changed): New functions.
2857 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2858 (struct xsettings): Move font inside HAVE_XFT.
2859 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2860 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2861 Move inside HAVE_XFT.
2862 (something_changed_gsettingsCB): Rename from something_changedCB.
2863 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2865 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2866 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2867 (something_changed_gconfCB): Rename from something_changedCB.
2868 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2869 (parse_settings): Move check for font inside HAVE_XFT.
2870 (read_settings, apply_xft_settings): Add comment.
2871 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2872 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2873 call store_font_name_changed.
2874 (xft_settings_event): Add comment.
2875 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2876 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2877 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2878 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2879 (xsettings_initialize): Call init_gsettings last.
2880 (xsettings_get_system_font, xsettings_get_system_normal_font):
2883 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2885 Random fixes. E.g., (random) never returned negative values.
2886 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2887 subseconds part to the entropy, as that's a bit more random.
2888 Prefer signed to unsigned, since the signedness doesn't matter and
2889 in general we prefer signed. When given a limit, use a
2890 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2891 latter isn't right if USE_2_TAGS_FOR_INTS.
2892 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2893 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2895 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2897 * textprop.c (text_property_stickiness):
2898 Obey Vtext_property_default_nonsticky.
2899 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2900 * w32fns.c (syms_of_w32fns):
2901 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2903 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2905 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2906 This is more efficient than Ffile_directory_p and avoids a minor race.
2908 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2910 * buffer.c (Foverlay_put): Say what the return value is
2913 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2914 is a directory before asking whether to use the file name
2916 (barf_or_query_if_file_exists): Make the "File is a directory"
2917 error be more correct.
2919 * fns.c (Frequire): Remove the mention of the .gz files, since
2920 that's installation-specific, but keep the mention of
2921 `get-load-suffixes'.
2923 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2925 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2926 Report string overflow if the output is too long.
2928 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2930 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2931 (syms_of_gnutls): Remove duplicate DEFSYM for
2932 Qgnutls_bootprop_verify_hostname_error, an error for
2933 Qgnutls_bootprop_verify_error (which is no longer used).
2935 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2936 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2937 Also (re)move comments that are misplaced or no longer relevant.
2939 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2941 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2943 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2945 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2946 and background color parameters if they have been changed.
2948 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2950 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2952 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2954 * xsettings.c (SYSTEM_FONT): Define only when used.
2955 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2957 * keymap.c (access_keymap_1): Now static.
2959 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2961 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2962 leave any prefix arg for the up event (Bug#1586).
2964 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2966 * lread.c (syms_of_lread): Mention single symbols defined by
2967 `defvar' or `defconst' (bug#7154).
2969 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2970 (Frequire): Mention get-load-suffixes.
2972 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2974 * window.h (window): Remove clone_number slot.
2975 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2977 (make_parent_window, make_window, saved_window)
2978 (Fset_window_configuration, save_window_save): Don't deal with
2980 * buffer.c (Qclone_number): Remove declaration.
2981 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2983 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2985 Add multiple inheritance to keymaps.
2986 * keymap.c (Fmake_composed_keymap): New function.
2987 (Fset_keymap_parent): Simplify.
2988 (fix_submap_inheritance): Remove.
2989 (access_keymap_1): New function extracted from access_keymap to handle
2990 embedded parents and handle lists of maps.
2991 (access_keymap): Use it.
2992 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2993 (Fcopy_keymap): Handle embedded parents.
2994 (Fcommand_remapping, define_as_prefix): Simplify.
2995 (Fkey_binding): Simplify.
2996 (syms_of_keymap): Move minibuffer-local-completion-map,
2997 minibuffer-local-filename-completion-map,
2998 minibuffer-local-must-match-map, and
2999 minibuffer-local-filename-must-match-map to Elisp.
3000 (syms_of_keymap): Defsubr make-composed-keymap.
3001 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3002 (parse_menu_item): Trivial simplification.
3004 2011-07-01 Glenn Morris <rgm@gnu.org>
3006 * Makefile.in (SETTINGS_LIBS): Fix typo.
3008 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3010 * coding.c (Fencode_coding_string): Record the last coding system
3011 used, as the function doc string says (bug#8738).
3013 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3015 * xsettings.c (store_monospaced_changed): Take new font as arg and
3016 check for change against current_mono_font.
3017 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3018 (emacs_settings_constructor, emacs_settings_get_property)
3019 (emacs_settings_set_property, emacs_settings_class_init)
3020 (emacs_settings_init, gsettings_obj): Remove.
3021 (something_changedCB): New function for HAVE_GSETTINGS.
3022 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3023 with value as argument.
3024 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3025 g_settings_new (Bug#8967). Do not create gsettings_obj.
3026 Remove calls to g_settings_bind. Connect something_changedCB to
3029 * xgselect.c: Add defined (HAVE_GSETTINGS).
3030 (xgselect_initialize): Ditto.
3032 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3033 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3036 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3038 * eval.c (struct backtrace): Simplify and port the data structure.
3039 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3040 signed bit field, as this assumption is not portable and it makes
3041 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3042 "char debug_on_exit : 1" as this is not portable either; instead,
3043 use the portable "unsigned int debug_on_exit : 1". Remove unused
3044 member evalargs. Remove obsolete comments about cc bombing out.
3046 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3048 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3049 Let HAVE_GSETTINGS override HAVE_GCONF.
3050 (store_monospaced_changed): New function.
3051 (EMACS_SETTINGS): A new type derived from GObject to handle
3052 GSettings notifications.
3053 (emacs_settings_constructor, emacs_settings_get_property)
3054 (emacs_settings_set_property, emacs_settings_class_init):
3056 (gsettings_client, gsettings_obj): New variables.
3057 (GSETTINGS_SCHEMA): New define.
3058 (something_changedCB): Call store_monospaced_changed.
3059 (init_gsettings): New function.
3060 (xsettings_initialize): Call init_gsettings.
3061 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3064 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3067 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3069 * window.c (resize_root_window, grow_mini_window)
3070 (shrink_mini_window): Rename Qresize_root_window to
3071 Qwindow_resize_root_window and Qresize_root_window_vertically to
3072 Qwindow_resize_root_window_vertically.
3074 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3076 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3078 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3080 * makefile.w32-in: Redesign dependencies so they reflect more
3081 clearly which files are directly included by each source file,
3082 and not through other includes.
3084 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3086 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3087 (sort_overlays, overlay_strings): When an overlay's clone number
3088 matches the window's clone number process the overlay even if
3089 the overlay's window property doesn't match the current window.
3091 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3092 (Fwindow_hchild): Rename to Fwindow_left_child.
3093 (Fwindow_next): Rename to Fwindow_next_sibling.
3094 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3095 (resize_window_check): Rename to window_resize_check.
3096 (resize_window_apply): Rename to window_resize_apply.
3097 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3098 (Fdelete_other_windows_internal, resize_frame_windows)
3099 (Fsplit_window_internal, Fdelete_window_internal)
3100 (grow_mini_window, shrink_mini_window)
3101 (Fresize_mini_window_internal): Fix callers accordingly.
3103 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3105 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3106 (emacs_fixed_set_min_size): Remove.
3107 (emacs_fixed_new): Take frame as argument.
3109 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3110 (_EmacsFixedPrivate): Remove minwidth/height.
3111 Add struct frame *f.
3112 (emacs_fixed_init): Initialize priv->f.
3113 (get_parent_class, emacs_fixed_set_min_size): Remove.
3114 (emacs_fixed_new): Set priv->f to argument.
3115 (emacs_fixed_get_preferred_width)
3116 (emacs_fixed_get_preferred_height): Use min_width/height from
3117 frames size_hint to set minimum and natural (Bug#8919).
3118 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3119 and use min_width/height from frames size_hint to set
3120 min_width/height (Bug#8919).
3122 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3123 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3126 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3128 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3129 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3132 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3134 * process.c (wait_reading_process_output): Bypass select if
3135 waiting for a cell while ignoring keyboard input, and input is
3136 pending. Suggested by Jan Djärv (Bug#8869).
3138 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3140 Use gnulib's dup2 module instead of rolling our own.
3141 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3143 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3145 * dispnew.c (scrolling_window): Before scrolling, turn off a
3146 mouse-highlight in the window being scrolled.
3148 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3150 Move DEFSYM to lisp.h and use everywhere.
3152 * character.h (DEFSYM): Move declaration...
3153 * lisp.h (DEFSYM): ...here.
3159 * w32select.c: Don't include character.h.
3161 * alloc.c (syms_of_alloc):
3162 * buffer.c (syms_of_buffer):
3163 * bytecode.c (syms_of_bytecode):
3164 * callint.c (syms_of_callint):
3165 * casefiddle.c (syms_of_casefiddle):
3166 * casetab.c (init_casetab_once):
3167 * category.c (init_category_once, syms_of_category):
3168 * ccl.c (syms_of_ccl):
3169 * cmds.c (syms_of_cmds):
3170 * composite.c (syms_of_composite):
3171 * dbusbind.c (syms_of_dbusbind):
3172 * dired.c (syms_of_dired):
3173 * dispnew.c (syms_of_display):
3174 * doc.c (syms_of_doc):
3175 * editfns.c (syms_of_editfns):
3176 * emacs.c (syms_of_emacs):
3177 * eval.c (syms_of_eval):
3178 * fileio.c (syms_of_fileio):
3179 * fns.c (syms_of_fns):
3180 * frame.c (syms_of_frame):
3181 * fringe.c (syms_of_fringe):
3182 * insdel.c (syms_of_insdel):
3183 * keymap.c (syms_of_keymap):
3184 * lread.c (init_obarray, syms_of_lread):
3185 * macros.c (syms_of_macros):
3186 * msdos.c (syms_of_msdos):
3187 * print.c (syms_of_print):
3188 * process.c (syms_of_process):
3189 * search.c (syms_of_search):
3190 * sound.c (syms_of_sound):
3191 * syntax.c (init_syntax_once, syms_of_syntax):
3192 * terminal.c (syms_of_terminal):
3193 * textprop.c (syms_of_textprop):
3194 * undo.c (syms_of_undo):
3195 * w32.c (globals_of_w32):
3196 * window.c (syms_of_window):
3197 * xdisp.c (syms_of_xdisp):
3198 * xfaces.c (syms_of_xfaces):
3199 * xfns.c (syms_of_xfns):
3200 * xmenu.c (syms_of_xmenu):
3201 * xsettings.c (syms_of_xsettings):
3202 * xterm.c (syms_of_xterm): Use DEFSYM.
3204 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3206 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3208 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3210 Integer and buffer overflow fixes (Bug#8873).
3212 * print.c (printchar, strout): Check for string overflow.
3213 (PRINTPREPARE, printchar, strout):
3214 Don't set size unless allocation succeeds.
3216 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3217 for sizes. Check for string overflow more accurately.
3218 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3220 * macros.c: Integer and buffer overflow fixes.
3221 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3222 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3223 Use ptrdiff_t, not int, for sizes.
3224 Don't increment bufsize until after realloc succeeds.
3225 Check for size-calculation overflow.
3226 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3228 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3230 * lread.c: Integer overflow fixes.
3231 (read_integer): Radix is now EMACS_INT, not int,
3232 to improve quality of diagnostics for out-of-range radices.
3233 Calculate buffer size correctly for out-of-range radices.
3234 (read1): Check for integer overflow in radices, and in
3235 read-circle numbers.
3236 (read_escape): Avoid int overflow.
3237 (Fload, openp, read_buffer_size, read1)
3238 (substitute_object_recurse, read_vector, read_list, map_obarray):
3239 Use ptrdiff_t, not int, for sizes.
3240 (read1): Use EMACS_INT, not int, for sizes.
3241 Check for size overflow.
3243 * image.c (cache_image): Check for size arithmetic overflow.
3245 * lread.c: Integer overflow issues.
3246 (saved_doc_string_size, saved_doc_string_length)
3247 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3248 Now ptrdiff_t, not int.
3249 (read1): Don't assume doc string length fits in int. Check for
3250 out-of-range doc string lengths.
3251 (read_list): Don't assume file position fits in int.
3252 (read_escape): Check for hex character overflow.
3254 2011-06-22 Leo Liu <sdl.web@gmail.com>
3256 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3257 Move to minibuffer.el.
3259 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3261 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3262 The following patches are for when GLYPH_DEBUG && !XASSERT.
3263 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3264 * dispnew.c (flush_stdout):
3265 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3266 Mark as externally visible.
3267 * dispnew.c (check_window_matrix_pointers): Now static.
3268 * dispnew.c (window_to_frame_vpos):
3269 * xfns.c (unwind_create_frame):
3270 * xterm.c (x_check_font): Remove unused local.
3271 * scroll.c (CHECK_BOUNDS):
3272 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3273 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3274 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3275 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3276 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3278 (debug_method_add): Use va_list and vsprintf rather than relying
3279 on undefined behavior with wrong number of arguments.
3280 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3281 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3282 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3283 since we're not interested in debugging glyphs with old libraries.
3284 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3285 GCC 4.6.0's static checking.
3287 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3289 Integer overflow and signedness fixes (Bug#8873).
3290 A few related buffer overrun fixes, too.
3292 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3294 * dispextern.h (struct face.stipple):
3295 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3296 (x_bitmap_mask, x_allocate_bitmap_record)
3297 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3298 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3299 (x_create_bitmap_from_xpm_data):
3300 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3301 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3303 * xfaces.c (load_pixmap):
3304 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3305 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3306 (.bitmaps_last, struct x_output.icon_bitmap):
3307 Use ptrdiff_t, not int, for bitmap indexes.
3308 (x_allocate_bitmap_record): Check for size overflow.
3309 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3311 Use ptrdiff_t, not int, for overlay counts.
3312 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3313 * editfns.c (overlays_around, get_pos_property):
3314 * textprop.c (get_char_property_and_overlay):
3315 * xdisp.c (next_overlay_change, note_mouse_highlight):
3316 * xfaces.c (face_at_buffer_position):
3317 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3318 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3319 (Fnext_overlay_change, Fprevious_overlay_change)
3320 (mouse_face_overlay_overlaps, Foverlays_in):
3321 Use ptrdiff_t, not int, for sizes.
3322 (overlays_at, overlays_in): Check for size-calculation overflow.
3324 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3326 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3327 (x_session_initialize): Do not assume string length fits in int.
3329 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3330 This is unlikely, but can occur if DPI is outlandish.
3332 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3333 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3335 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3336 * xrdb.c (magic_file_p, search_magic_path):
3337 Omit last arg SUFFIX; it was always 0. All callers changed.
3338 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3340 * xfont.c (xfont_match): Avoid need for strlen.
3342 * xfns.c: Don't assume strlen fits in int.
3343 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3345 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3346 not unsigned long, as we prefer signed integers. All callers changed.
3347 Detect integer overflow in repeat count.
3348 (message_dolog): Don't assume print length fits in 39 bytes.
3349 (display_mode_element): Don't assume strlen fits in int.
3351 * termcap.c: Don't assume sizes fit in int and never overflow.
3352 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3353 (gobble_line): Check for size-calculation overflow.
3355 * minibuf.c (Fread_buffer):
3356 * lread.c (intern, intern_c_string):
3357 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3358 Don't assume string length fits in int.
3360 * keyboard.c (parse_tool_bar_item):
3361 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3363 * font.c: Don't assume string length fits in int.
3364 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3365 Use ptrdiff_t, not int.
3366 (font_intern_prop): Don't assume string length fits in int.
3367 Don't assume integer property fits in fixnum.
3368 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3370 * filelock.c: Fix some buffer overrun and integer overflow issues.
3371 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3372 Reformulate so as not to need the command string.
3373 Invoke gzip -cd rather than gunzip, as it's more portable.
3374 (lock_info_type, lock_file_1, lock_file):
3375 Don't assume pid_t and time_t fit in unsigned long.
3376 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3377 (current_lock_owner): Prefer signed type for sizes.
3378 Use memcpy, not strncpy, where memcpy is what is really wanted.
3379 Don't assume (via atoi) that time_t and pid_t fit in int.
3380 Check for time_t and/or pid_t out of range, e.g., via a network share.
3381 Don't alloca where an auto var works fine.
3383 * fileio.c: Fix some integer overflow issues.
3384 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3385 Don't assume string length fits in int.
3386 (directory_file_name): Don't assume string length fits in long.
3387 (make_temp_name): Don't assume pid fits in int, or that its print
3388 length is less than 20.
3390 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3392 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3394 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3396 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3397 We prefer signed integers, even for size calculations.
3399 * emacs.c: Don't assume string length fits in 'int'.
3400 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3401 (main): Don't invoke strlen when not needed.
3403 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3404 (XD_DEBUG_MESSAGE): Don't waste a byte.
3406 * callproc.c (getenv_internal_1, getenv_internal)
3408 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3410 * lread.c (invalid_syntax): Omit length argument.
3411 All uses changed. This doesn't fix a bug, but it simplifies the
3412 code away from its former Hollerith-constant appearance, and it's
3413 one less 'int' to worry about when looking at integer-overflow issues.
3414 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3416 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3417 This didn't break anything, but it didn't help either.
3418 It's confusing to put a bogus integer in a place where the actual
3419 value does not matter.
3420 (LIST_END_P): Remove unused macro and its bogus comment.
3421 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3423 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3424 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3426 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3427 We prefer signed types, and the value cannot exceed the EMACS_INT
3428 range anyway (because otherwise the length would not be representable).
3429 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3430 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3431 This avoids a GCC warning when WIDE_EMACS_INT.
3433 * indent.c (sane_tab_width): New function.
3434 (current_column, scan_for_column, Findent_to, position_indentation)
3435 (compute_motion): Use it. This is just for clarity.
3436 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3438 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3440 * lisp.h (lint_assume): New macro.
3441 * composite.c (composition_gstring_put_cache):
3442 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3444 * editfns.c, insdel.c:
3445 Omit unnecessary forward decls, to simplify future changes.
3447 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3449 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3451 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3452 Use much-faster test for byte-length change.
3453 Don't assume string byte-length fits in 'int'.
3454 Check that character arg fits in 'int'.
3455 (mapcar1): Declare byte as byte, for clarity.
3457 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3459 * fns.c (concat): Catch string overflow earlier.
3460 Do not rely on integer wraparound.
3462 * dispextern.h (struct it.overlay_strings_charpos)
3463 (struct it.selective): Now EMACS_INT, not int.
3464 * xdisp.c (forward_to_next_line_start)
3465 (back_to_previous_visible_line_start)
3466 (reseat_at_next_visible_line_start, next_element_from_buffer):
3467 Don't arbitrarily truncate the value of 'selective' to int.
3469 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3471 * composite.c: Don't truncate sizes to 'int'.
3472 (composition_gstring_p, composition_reseat_it)
3473 (composition_adjust_point): Use EMACS_INT, not int.
3474 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3475 not EMACS_UINT, for indexes.
3477 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3479 * buffer.c: Include <verify.h>.
3480 (struct sortvec.priority, struct sortstr.priority):
3481 Now EMACS_INT, not int.
3482 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3483 (struct sortstr.size, record_overlay_string)
3484 (struct sortstrlist.size, struct sortlist.used):
3485 Don't truncate size to int.
3486 (record_overlay_string): Check for size-calculation overflow.
3487 (init_buffer_once): Check at compile-time, not run-time.
3489 2011-06-22 Jim Meyering <meyering@redhat.com>
3491 Don't leak an XBM-image-sized buffer
3492 * image.c (xbm_load): Free the image buffer after using it.
3494 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3497 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3498 that Sun C diagnosed.
3499 * fns.c (secure_hash): Fix pointer signedness issue.
3500 * intervals.c (static_offset_intervals): New function.
3501 (offset_intervals): Use it.
3503 2011-06-21 Leo Liu <sdl.web@gmail.com>
3506 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3509 * fns.c (secure_hash): Rename from crypto_hash_function and change
3510 the first arg to accept symbols.
3511 (Fsecure_hash): New primitive.
3512 (syms_of_fns): New symbols.
3514 2011-06-20 Deniz Dogan <deniz@dogan.se>
3516 * process.c (Fset_process_buffer): Clarify return value in
3519 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3521 * dispnew.c (add_window_display_history): Use BVAR.
3523 * xdisp.c (debug_method_add): Use BVAR.
3524 (check_window_end, dump_glyph_matrix, dump_glyph)
3525 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3527 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3530 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3531 check till after the cache is created in init_frame_faces.
3533 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3535 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3537 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3539 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3540 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3541 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3543 Improve buffer-overflow checking (Bug#8873).
3544 * fileio.c (Finsert_file_contents):
3545 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3546 Remove the old (too-loose) buffer overflow checks.
3547 They weren't needed, since make_gap checks for buffer overflow.
3548 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3549 The old code merely checked for Emacs fixnum overflow, and relied
3550 on undefined (wraparound) behavior. The new code avoids undefined
3551 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3553 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3554 Tune. Don't use wider integers than needed. Don't use alloca.
3555 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3557 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3559 * insdel.c, lisp.h (buffer_overflow): New function.
3560 (insert_from_buffer_1, replace_range, replace_range_2):
3561 * insdel.c (make_gap_larger):
3562 * editfns.c (Finsert_char):
3563 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3565 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3567 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3569 Integer overflow and signedness fixes (Bug#8873).
3571 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3572 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3574 * fileio.c: Don't assume EMACS_INT fits in off_t.
3575 (emacs_lseek): New static function.
3576 (Finsert_file_contents, Fwrite_region): Use it.
3577 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3579 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3581 * fns.c: Don't overflow int when computing a list length.
3582 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3583 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3584 truncation on 64-bit hosts. Check for QUIT every
3585 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3586 faster and is responsive enough.
3587 (Flength): Report an error instead of overflowing an integer.
3588 (Fsafe_length): Return a float if the value is not representable
3589 as a fixnum. This shouldn't happen except in contrived situations.
3590 (Fnthcdr, Fsort): Don't assume list length fits in int.
3591 (Fcopy_sequence): Don't assume vector length fits in int.
3593 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3594 (header_size, word_size): New constants.
3595 (allocate_vectorlike): Don't check size overflow here.
3596 (allocate_vector): Check it here instead, since this is the only
3597 caller of allocate_vectorlike that could cause overflow.
3598 Check that the new vector's length is representable as a fixnum.
3600 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3601 The previous code was bogus. For example, next_almost_prime (32)
3602 returned 39, which is undesirable as it is a multiple of 3; and
3603 next_almost_prime (24) returned 25, which is a multiple of 5 so
3604 why was the code bothering to check for multiples of 7?
3606 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3608 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3610 Variadic C functions now count arguments with ptrdiff_t.
3611 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3612 Back then I didn't know that the Emacs coding style prefers signed int.
3613 Also, in the meantime I found a few more instances where arguments
3614 were being counted with int, which may truncate counts on 64-bit
3615 machines, or EMACS_INT, which may be unnecessarily wide.
3616 * lisp.h (struct Lisp_Subr.function.aMANY)
3617 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3618 Arg counts are now ptrdiff_t, not size_t.
3619 All variadic functions and their callers changed accordingly.
3620 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3621 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3622 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3623 * callint.c (Fcall_interactively): Check arg count for overflow,
3624 to avoid potential buffer overrun. Use signed char, not 'int',
3625 for 'varies' array, so that we needn't bother to check its size
3626 calculation for overflow.
3627 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3628 * eval.c (apply_lambda):
3629 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3630 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3631 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3633 * callint.c (Fcall_interactively): Don't use index var as event count.
3635 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3636 * mem-limits.h (SIZE): Remove; no longer used.
3638 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3640 Remove unnecessary casts.
3641 * xterm.c (x_term_init):
3642 * xfns.c (x_set_border_pixel):
3643 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3644 These aren't needed now that we assume ANSI C.
3646 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3647 It's more likely to cause problems (due to unsigned overflow)
3650 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3652 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3654 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3656 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3658 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3660 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3662 GLYPH_CODE_FACE returns EMACS_INT, not int.
3663 * dispextern.h (merge_faces):
3664 * xfaces.c (merge_faces):
3665 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3666 Don't assume EMACS_INT fits in int.
3668 * character.h (CHAR_VALID_P): Remove unused parameter.
3669 * fontset.c, lisp.h, xdisp.c: All uses changed.
3671 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3673 * fns.c (concat): Minor tuning based on overflow analysis.
3674 This doesn't fix any bugs. Use int to hold character, instead
3675 of constantly refetching from Emacs object. Use XFASTINT, not
3676 XINT, for value known to be a character. Don't bother comparing
3677 a single byte to 0400, as it's always less.
3679 * floatfns.c (Fexpt):
3680 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3682 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3685 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3687 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3688 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3689 incorrectly succeed when S was a string, because 4294967386 was
3690 truncated before it was used.
3692 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3693 Otherwise, an out-of-range integer could cause undefined behavior
3696 * composite.c: Use int, not EMACS_INT, for characters.
3697 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3698 EMACS_INT, for values that are known to be in character range.
3699 This doesn't fix any bugs but is the usual style inside Emacs and
3700 may generate better code on 32-bit machines.
3702 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3703 This is for reasons similar to the recent CHAR_STRING fix.
3704 * charset.c (Fencode_char): Check that character arg is actually
3705 a character. Pass an int to ENCODE_CHAR.
3706 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3707 wider than 'int', as a compile-time check to prevent future regressions
3710 * character.c (char_string): Remove unnecessary casts.
3712 Make sure a 64-bit char is never passed to CHAR_STRING.
3713 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3714 by silently ignoring the top 32 bits, allowing some values
3715 that were far too large to be valid characters.
3716 * character.h: Include <verify.h>.
3717 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3718 arguments are no wider than unsigned, as a compile-time check
3719 to prevent future regressions in this area.
3721 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3722 (Fsubst_char_in_region):
3724 * xdisp.c (decode_mode_spec_coding):
3725 Adjust to CHAR_STRING's new requirement.
3726 * editfns.c (Finsert_char, Fsubst_char_in_region):
3727 * fns.c (concat): Check that character args are actually
3728 characters. Without this test, these functions did the wrong
3729 thing with wildly out-of-range values on 64-bit hosts.
3731 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3732 These casts should not be needed on 32-bit hosts, either.
3733 * keyboard.c (read_char):
3734 * lread.c (Fload): Remove casts to unsigned.
3736 * lisp.h (UNSIGNED_CMP): New macro.
3737 This fixes comparison bugs on 64-bit hosts.
3738 (ASCII_CHAR_P): Use it.
3739 * casefiddle.c (casify_object):
3740 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3741 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3742 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3743 * dispextern.h (FACE_FROM_ID):
3744 * keyboard.c (read_char): Use UNSIGNED_CMP.
3746 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3747 not to EMACS_INT, to avoid GCC warning.
3749 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3751 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3752 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3753 isn't needed on 32-bit machines.
3755 * buffer.c (Fgenerate_new_buffer_name):
3756 Use EMACS_INT for count, not int.
3757 (advance_to_char_boundary): Return EMACS_INT, not int.
3759 * data.c (Qcompiled_function): Now static.
3761 * window.c (window_body_lines): Now static.
3763 * image.c (gif_load): Rename local to avoid shadowing.
3765 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3766 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3767 * alloc.c (make_save_value): Integer argument is now of type
3769 (mark_object): Use ptrdiff_t, not int.
3770 * lisp.h (pD): New macro.
3771 * print.c (print_object): Use it.
3773 * alloc.c: Use EMACS_INT, not int, to count objects.
3774 (total_conses, total_markers, total_symbols, total_vector_size)
3775 (total_free_conses, total_free_markers, total_free_symbols)
3776 (total_free_floats, total_floats, total_free_intervals)
3777 (total_intervals, total_strings, total_free_strings):
3778 Now EMACS_INT, not int. All uses changed.
3779 (Fgarbage_collect): Compute overall total using a double, so that
3780 integer overflow is less likely to be a problem. Check for overflow
3781 when converting back to an integer.
3782 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3783 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3784 These were 'int' variables that could overflow on 64-bit hosts;
3785 they were never used, so remove them instead of repairing them.
3786 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3787 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3788 Previously, this ceilinged at INT_MAX, but that doesn't work on
3790 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3792 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3793 (allocate_vectorlike): Check for ptrdiff_t overflow.
3794 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3795 when a (possibly-narrower) signed value would do just as well.
3796 We prefer using signed arithmetic, to avoid comparison confusion.
3798 * alloc.c: Catch some string size overflows that we were missing.
3799 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3800 for convenience in STRING_BYTES_MAX.
3801 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3802 The definition here is exact; the one in lisp.h was approximate.
3803 (allocate_string_data): Check for string overflow. This catches
3804 some instances we weren't catching before. Also, it catches
3805 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3806 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3807 and ptrdiff_t and EMACS_INT are both 64 bits.
3809 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3810 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3811 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3813 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3815 * alloc.c (Fmake_string): Check for out-of-range init.
3817 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3819 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3821 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3823 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3824 xg_get_default_scrollbar_width.
3826 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3827 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3828 (style_changed_cb): Call update_theme_scrollbar_width and call
3829 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3830 all frames (Bug#8505).
3831 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3832 Call gtk_window_set_resizable if HAVE_GTK3.
3833 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3834 and height if HAVE_GTK3 (Bug#8505).
3835 (scroll_bar_width_for_theme): New variable.
3836 (update_theme_scrollbar_width): New function.
3837 (xg_get_default_scrollbar_width): Move code to
3838 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3839 (xg_initialize): Call update_theme_scrollbar_width.
3841 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3843 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3845 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3847 * frame.c (make_frame): Call other_buffer_safely instead of
3850 * window.c (temp_output_buffer_show): Call display_buffer with
3851 second argument Vtemp_buffer_show_specifiers and reset latter
3852 immediately after the call.
3853 (Vtemp_buffer_show_specifiers): New variable.
3854 (auto_window_vscroll_p, next_screen_context_lines)
3855 (Vscroll_preserve_screen_position): Remove leading asterisks from
3858 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3860 Fix minor problems found by GCC 4.6.0 static checking.
3861 * buffer.c (Qclone_number): Remove for now, as it's unused.
3862 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3863 (record_buffer): Remove unused local.
3864 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3865 (set_frame_buffer_list): Remove; unused.
3866 * frame.h (other_visible_frames): Remove decl.
3867 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3868 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3869 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3871 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3872 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3873 Define only if HAVE_GPM.
3874 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3875 (update_hints_inhibit): Remove; never set. All uses removed.
3876 * widgetprv.h (emacsFrameClassRec): Remove decl.
3877 * window.c (delete_deletable_window): Now returns void, since it
3878 wasn't returning anything.
3879 (compare_window_configurations): Remove unused locals.
3880 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3881 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3882 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3883 the same widths as pointers. This follows up on the 2011-05-06 patch.
3884 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3885 * xterm.h: Likewise.
3886 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3888 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3890 * makefile.w32-in: Update dependencies.
3891 (LISP_H): Add lib/intprops.h.
3893 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3895 * image.c (gif_load): Add animation frame delay to the metadata.
3896 (syms_of_image): Use DEFSYM. New symbol `delay'.
3898 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3900 * window.c (delete_deletable_window): Re-add.
3901 (Fset_window_configuration): Rewrite to handle dead buffers and
3902 consequently deletable windows.
3903 (window_tree, Fwindow_tree): Remove. Supply functionality in
3905 (compare_window_configurations): Simplify code.
3907 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3909 * image.c (imagemagick_load_image): Fix type mismatch.
3910 (Fimagemagick_types): Likewise.
3912 * window.h (replace_buffer_in_windows): Declare.
3914 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3916 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3917 Qclone_number. Remove external declaration of Qdelete_window.
3918 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3920 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3921 Run Qbuffer_list_update_hook if allowed.
3922 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3923 buffer list implementation.
3924 (other_buffer_safely): New function.
3925 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3926 calls to replace_buffer_in_windows and
3927 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3929 (record_buffer): Inhibit quitting and rewrite using quittable
3930 functions. Run Qbuffer_list_update_hook if allowed.
3931 (Frecord_buffer, Funrecord_buffer): New functions.
3932 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3933 Move switch-to-buffer to window.el.
3934 (bury-buffer): Move to window.el.
3935 (Vbuffer_list_update_hook): New variable.
3937 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3940 * window.h (resize_frame_windows): Move up in code.
3941 (Fwindow_frame): Remove EXFUN.
3942 (replace_buffer_in_all_windows): Remove prototype.
3943 (replace_buffer_in_windows_safely): Add prototype.
3945 * window.c: Declare Qdelete_window static again. Move down
3946 declaration of select_count.
3947 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3948 (Fother_window): Move to window.el.
3949 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3950 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3951 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3953 (replace_buffer_in_windows): Implement by calling
3954 Qreplace_buffer_in_windows.
3955 (replace_buffer_in_all_windows): Remove with some functionality
3956 moved into replace_buffer_in_windows_safely.
3957 (replace_buffer_in_windows_safely): New function.
3958 (select_window_norecord, select_frame_norecord): Move in front
3959 of run_window_configuration_change_hook. Remove now obsolete
3961 (Fset_window_buffer): Rewrite doc-string.
3962 Call Qrecord_window_buffer.
3963 (keys_of_window): Move binding for other-window to window.el.
3965 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3967 * dispextern.h (struct image): Replace data member, whose int_val
3968 and ptr_val fields were not used by anything, with a single
3971 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3972 (gif_clear_image, gif_load, imagemagick_load_image)
3973 (gs_clear_image, gs_load): Callers changed.
3975 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3977 * buffer.h: Include <time.h>, for time_t.
3978 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3980 Fix minor problems found by static checking.
3982 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3984 Make identifiers static if they are not used in other modules.
3985 * data.c (Qcompiled_function, Qframe, Qvector):
3986 * image.c (QimageMagick, Qsvg):
3987 * minibuf.c (Qmetadata):
3988 * window.c (resize_window_check, resize_root_window): Now static.
3989 * window.h (resize_window_check, resize_root_window): Remove decls.
3991 * window.c (window_deletion_count, delete_deletable_window):
3993 (window_body_lines): Now static.
3994 (Fdelete_other_windows_internal): Mark vars as initialized.
3995 Make sure 'resize_failed' is initialized.
3996 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3997 (resize_window_apply): Remove unused local.
3998 * window.h (delete_deletable_window): Remove decl.
4000 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4001 (imagemagick_load_image): Fix pointer signedness problem by changing
4002 last arg from unsigned char * to char *. All uses changed.
4003 Also, fix a local for similar reasons.
4004 Remove unused locals. Remove locals to avoid shadowing.
4005 (fn_rsvg_handle_free): Remove; unused.
4006 (svg_load, svg_load_image): Fix pointer signedness problem.
4007 (imagemagick_load_image): Don't use garbage pointer image_wand.
4009 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4011 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4013 * image.c (gif_load): Fix omitted cast error introduced by
4016 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4018 * window.h (resize_proportionally, orig_total_lines)
4019 (orig_top_line): Remove from window structure.
4020 (set_window_height, set_window_width, change_window_heights)
4021 (Fdelete_window): Remove prototypes.
4022 (resize_frame_windows): Remove duplicate declaration.
4024 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4026 * window.h (resize_frame_windows, resize_window_check)
4027 (delete_deletable_window, resize_root_window)
4028 (resize_frame_windows): Declare prototypes.
4030 * window.c (resize_window_apply): Make definition be "static" to
4031 match the prototype.
4033 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4035 * window.c: Remove declarations of Qwindow_size_fixed,
4036 window_min_size_1, window_min_size_2, window_min_size,
4037 size_window, window_fixed_size_p, enlarge_window, delete_window.
4038 Remove static from declaration of Qdelete_window, it's
4039 temporarily needed by Fbury_buffer.
4040 (replace_window): Don't assign orig_top_line and
4042 (Fdelete_window, delete_window): Remove. Window deletion is
4043 handled by window.el.
4044 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4045 Replace Fdelete_window calls with calls to Qdelete_window.
4046 (Fdelete_other_windows): Remove. Deleting other windows is
4047 handled by window.el.
4048 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4049 handled in window.el.
4050 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4051 Window minimum sizes are handled in window.el.
4052 (shrink_windows, size_window, set_window_height)
4053 (set_window_width, change_window_heights, window_height)
4054 (window_width, CURBEG, CURSIZE, enlarge_window)
4055 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4056 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4057 handled in window.el.
4058 (make_dummy_parent): Rename to make_parent_window and give it a
4059 second argument horflag.
4060 (make_window): Don't set resize_proportionally any more.
4061 (Fsplit_window): Remove. Windows are split in window.el.
4062 (save_restore_action, save_restore_orig_size)
4063 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4064 Resize mini windows in window.el.
4065 (grow_mini_window, shrink_mini_window): Implement by calling
4066 Qresize_root_window_vertically, resize_window_check and
4067 resize_window_apply.
4068 (saved_window, Fset_window_configuration, save_window_save):
4069 Do not handle orig_top_line, orig_total_lines, and
4070 resize_proportionally.
4071 (window_min_height, window_min_width): Move to window.el.
4072 (keys_of_window): Move bindings for delete-other-windows,
4073 split-window, delete-window and enlarge-window to window.el.
4075 * buffer.c: Temporarily extern Qdelete_window.
4076 (Fbury_buffer): Temporarily call Qdelete_window instead of
4077 Fdelete_window (Fbury_buffer will move to window.el soon).
4079 * frame.c (set_menu_bar_lines_1): Remove code handling
4080 orig_top_line and orig_total_lines.
4082 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4083 set_window_height but set heights directly.
4084 (change_frame_size_1): Use resize_frame_windows.
4086 * xdisp.c (init_xdisp): Don't use set_window_height but set
4089 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4090 Use resize_frame_windows instead of change_window_heights and run
4091 run_window_configuration_change_hook.
4093 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4094 instead of change_window_heights and run
4095 run_window_configuration_change_hook.
4097 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4099 * window.c (replace_window): Rename second argument REPLACEMENT to
4100 NEW. New third argument SETFLAG. Rewrite.
4101 (delete_window, make_dummy_parent): Call replace_window with
4103 (window_list_1): Move down in code.
4104 (run_window_configuration_change_hook): Move set_buffer part
4105 before select_frame_norecord part in order to unwind correctly.
4106 Rename count1 to count.
4107 (recombine_windows, delete_deletable_window, resize_root_window)
4108 (Fdelete_other_windows_internal)
4109 (Frun_window_configuration_change_hook, make_parent_window)
4110 (resize_window_check, resize_window_apply, Fresize_window_apply)
4111 (resize_frame_windows, Fsplit_window_internal)
4112 (Fdelete_window_internal, Fresize_mini_window_internal):
4114 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4116 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4118 * window.h (window): Add some new members to window structure -
4119 normal_lines, normal_cols, new_total, new_normal, clone_number,
4120 splits, nest, prev_buffers, next_buffers.
4121 (WINDOW_TOTAL_SIZE): Move here from window.c.
4122 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4124 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4126 (make_dummy_parent): Set new members of windows structure.
4127 (make_window): Move down in code. Handle new members of window
4129 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4130 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4131 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4132 (Fset_window_prev_buffers, Fwindow_next_buffers)
4133 (Fset_window_next_buffers, Fset_window_clone_number):
4135 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4136 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4138 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4139 Argument WINDOW can be now internal window too.
4140 (Fwindow_use_time): Move up in code.
4141 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4143 (Fset_window_configuration, saved_window)
4144 (Fcurrent_window_configuration, save_window_save): Handle new
4145 members of window structure.
4146 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4147 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4148 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4149 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4150 Qget_mru_window, Qresize_root_window,
4151 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4152 Qauto_buffer_name; staticpro them.
4154 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4156 * window.c (Fwindow_total_size, Fwindow_left_column)
4157 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4158 (Fwindow_list_1): New functions.
4159 (window_box_text_cols): Replace with window_body_cols.
4160 (Fwindow_width, Fscroll_left, Fscroll_right):
4161 Use window_body_cols instead of window_box_text_cols.
4162 (delete_window, Fset_window_configuration):
4163 Call delete_all_subwindows with window as argument.
4164 (delete_all_subwindows): Take a window as argument and not a
4166 (window_loop): Remove handling of GET_LRU_WINDOW and
4168 (Fget_lru_window, Fget_largest_window): Move to window.el.
4170 * window.h: Extern window_body_cols instead of
4171 window_box_text_cols. delete_all_subwindows now takes a
4172 Lisp_Object as argument.
4174 * indent.c (compute_motion, Fcompute_motion):
4175 Use window_body_cols instead of window_box_text_cols.
4177 * frame.c (delete_frame): Call delete_all_subwindows with root
4180 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4182 * fns.c (Fputhash): Document return value.
4184 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4186 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4188 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4190 Cons<->int and similar integer overflow fixes (Bug#8794).
4192 Check for overflow when converting integer to cons and back.
4193 * charset.c (Fdefine_charset_internal, Fdecode_char):
4194 Use cons_to_unsigned to catch overflow.
4195 (Fencode_char): Use INTEGER_TO_CONS.
4196 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4197 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4198 * data.c (long_to_cons, cons_to_long): Remove.
4199 (cons_to_unsigned, cons_to_signed): New functions.
4200 These signal an error for invalid or out-of-range values.
4201 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4202 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4203 * font.c (Ffont_variation_glyphs):
4204 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4205 * lisp.h: Include <intprops.h>.
4206 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4207 (cons_to_signed, cons_to_unsigned): New decls.
4208 (long_to_cons, cons_to_long): Remove decls.
4209 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4210 (Fprimitive_undo): Use CONS_TO_INTEGER.
4211 * xfns.c (Fx_window_property): Likewise.
4212 * xselect.c: Include <limits.h>.
4213 (x_own_selection, selection_data_to_lisp_data):
4214 Use INTEGER_TO_CONS.
4215 (x_handle_selection_request, x_handle_selection_clear)
4216 (x_get_foreign_selection, Fx_disown_selection_internal)
4217 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4218 (lisp_data_to_selection_data): Use cons_to_unsigned.
4219 (x_fill_property_data): Use cons_to_signed.
4220 Report values out of range.
4222 Check for buffer and string overflow more precisely.
4223 * buffer.h (BUF_BYTES_MAX): New macro.
4224 * lisp.h (STRING_BYTES_MAX): New macro.
4225 * alloc.c (Fmake_string):
4226 * character.c (string_escape_byte8):
4227 * coding.c (coding_alloc_by_realloc):
4228 * doprnt.c (doprnt):
4229 * editfns.c (Fformat):
4231 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4232 since they may not be the same number.
4233 * editfns.c (Finsert_char):
4234 * fileio.c (Finsert_file_contents):
4235 Likewise for BUF_BYTES_MAX.
4237 * image.c: Use ptrdiff_t, not int, for sizes.
4238 (slurp_file): Switch from int to ptrdiff_t.
4240 (slurp_file): Check that file size fits in both size_t (for
4241 malloc) and ptrdiff_t (for sanity and safety).
4243 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4244 if b->modtime has its maximal value.
4246 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4248 Don't assume time_t can fit into int.
4249 * buffer.h (struct buffer.modtime): Now time_t, not int.
4250 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4251 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4253 Minor fixes for signed vs unsigned integers.
4254 * character.h (MAYBE_UNIFY_CHAR):
4255 * charset.c (maybe_unify_char):
4256 * keyboard.c (read_char, reorder_modifiers):
4257 XINT -> XFASTINT, since the integer must be nonnegative.
4258 * ftfont.c (ftfont_spec_pattern):
4259 * keymap.c (access_keymap, silly_event_symbol_error):
4260 XUINT -> XFASTINT, since the integer must be nonnegative.
4261 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4262 since it makes no difference and we prefer signed.
4263 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4264 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4267 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4269 * window.h (Fwindow_frame): Declare.
4271 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4273 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4274 (SPARE_MEMORY): Always define.
4275 (LARGE_REQUEST): Remove.
4276 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4278 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4280 * lisp.h: Move EXFUNS for Fframe_root_window,
4281 Fframe_first_window and Fset_frame_selected_window to window.h.
4283 * window.h: Move EXFUNS for Fframe_root_window,
4284 Fframe_first_window and Fset_frame_selected_window here from
4287 * frame.c (Fwindow_frame, Fframe_first_window)
4288 (Fframe_root_window, Fframe_selected_window)
4289 (Fset_frame_selected_window): Move to window.c.
4290 (Factive_minibuffer_window): Move to minibuf.c.
4291 (Fother_visible_frames_p): New function.
4293 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4295 * window.c (decode_window, decode_any_window): Move up in code.
4296 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4297 (inhibit_frame_unsplittable): Remove unused variable.
4298 (Fwindow_buffer): Move up and rewrite doc-string.
4299 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4300 (Fwindow_prev): New functions.
4301 (Fwindow_frame): Move here from frame.c. Accept any window as
4303 (Fframe_root_window, Fframe_first_window)
4304 (Fframe_selected_window): Move here from frame.c. Accept frame
4305 or arbitrary window as argument. Update doc-strings.
4306 (Fminibuffer_window): Move up in code.
4307 (Fwindow_minibuffer_p): Move up in code and simplify.
4308 (Fset_frame_selected_window): Move here from frame.c.
4310 (Fselected_window, select_window, Fselect_window): Move up in
4311 code. Minor doc-string fixes.
4313 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4315 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4316 Do not assume that spare memory exists; that assumption is valid
4317 only if SYSTEM_MALLOC.
4318 (LARGE_REQUEST): New macro, so that the issue of large requests
4319 is separated from the issue of spare memory.
4321 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4323 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4326 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4328 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4331 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4333 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4335 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4337 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4338 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4340 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4342 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4344 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4346 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4347 (x_clipboard_manager_save): Add return value.
4348 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4350 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4351 Obey Vx_select_enable_clipboard_manager. Catch errors in
4352 x_clipboard_manager_save (Bug#8779).
4353 (Vx_select_enable_clipboard_manager): New variable.
4354 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4356 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4358 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4360 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4362 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4363 in the current matrix if keep_current_p is non-zero.
4365 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4367 * bidi.c (bidi_level_of_next_char): Fix last change.
4369 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4371 Support bidi reordering of text covered by display properties.
4373 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4374 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4375 (bidi_cache_search, bidi_cache_iterator_state)
4376 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4377 (bidi_level_of_next_char, bidi_move_to_visually_next):
4378 Support character positions inside a run of characters covered by a
4380 (bidi_paragraph_init, bidi_resolve_explicit_1)
4381 (bidi_level_of_next_char): Call bidi_fetch_char and
4382 bidi_fetch_char_advance instead of FETCH_CHAR and
4384 (bidi_init_it): Initialize new members.
4385 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4387 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4388 instead of using explicit *_CHAR codes.
4389 (bidi_resolve_explicit, bidi_resolve_weak):
4390 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4391 bidirectional text is supported only in multibyte buffers.
4392 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4393 it to initialize the frame_window_p member of struct bidi_it.
4394 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4395 (bidi_resolve_explicit, bidi_resolve_weak)
4396 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4397 bidi_it->nchars is non-positive.
4398 (bidi_level_of_next_char): Don't try to lookup the cache for the
4399 next/previous character if nothing is cached there yet, or if we
4400 were just reseat()'ed to a new position.
4402 * xdisp.c (set_cursor_from_row): Set start and stop points
4403 according to the row's direction when priming the loop that looks
4404 for the glyph on which to display cursor.
4405 (single_display_spec_intangible_p): Function deleted.
4406 (display_prop_intangible_p): Reimplement to call
4407 handle_display_spec instead of single_display_spec_intangible_p.
4408 Accept 3 additional arguments needed by handle_display_spec.
4409 This fixes incorrect cursor motion across display property with complex
4410 values: lists, `(when COND...)' forms, etc.
4411 (single_display_spec_string_p): Support property values that are
4412 lists with the argument STRING its top-level element.
4413 (display_prop_string_p): Fix the condition for processing a
4414 property that is a list to be consistent with handle_display_spec.
4415 (handle_display_spec): New function, refactored from the
4416 last portion of handle_display_prop.
4417 (compute_display_string_pos): Accept additional argument
4418 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4419 value of a `display' property is a "replacing spec".
4420 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4421 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4422 the display property, but just return a value indicating whether
4423 the display property will replace the characters it covers.
4424 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4425 frame_window_p members of struct bidi_it.
4426 (compute_display_string_pos, compute_display_string_end):
4428 (push_it): Accept second argument POSITION, where pop_it should
4429 jump to continue iteration.
4430 (reseat_1): Initialize bidi_it.disp_pos.
4432 * keyboard.c (adjust_point_for_property): Adjust the call to
4433 display_prop_intangible_p to its new signature.
4435 * dispextern.h (struct bidi_it): New member frame_window_p.
4436 (bidi_init_it): Update prototypes.
4437 (display_prop_intangible_p): Update prototype.
4438 (compute_display_string_pos, compute_display_string_end):
4440 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4443 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4445 Malloc failure behavior now depends on size of allocation.
4446 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4447 * lisp.h: Change signatures accordingly.
4448 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4449 All callers changed. (Bug#8762)
4451 * gnutls.c: Use Emacs's memory allocators.
4452 Without this change, the gnutls library would invoke malloc etc.
4453 directly, which causes problems on non-SYNC_INPUT hosts, and which
4454 runs afoul of improving memory_full behavior. (Bug#8761)
4455 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4456 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4457 xfree instead of the default malloc, realloc, free.
4458 (Fgnutls_boot): No need to check for memory allocation failure,
4459 since xmalloc does that for us.
4461 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4462 * category.c (hash_get_category_set):
4463 * ccl.c (ccl_driver):
4464 * charset.c (Fdefine_charset_internal):
4465 * charset.h (struct charset.hash_index):
4466 * composite.c (get_composition_id, gstring_lookup_cache)
4467 (composition_gstring_put_cache):
4468 * composite.h (struct composition.hash_index):
4469 * dispextern.h (struct image.hash):
4470 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4471 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4472 (hashfn_equal, hashfn_user_defined, make_hash_table)
4473 (maybe_resize_hash_table, hash_lookup, hash_put)
4474 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4475 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4476 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4477 * image.c (make_image, search_image_cache, lookup_image)
4478 (xpm_put_color_table_h):
4479 * lisp.h (struct Lisp_Hash_Table):
4480 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4481 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4482 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4483 * alloc.c (allocate_vectorlike):
4484 Check for overflow in vector size calculations.
4485 * ccl.c (ccl_driver):
4486 Check for overflow when converting EMACS_INT to int.
4487 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4488 need to be updated by these changes.
4489 * fns.c (make_hash_table, maybe_resize_hash_table):
4490 Check for integer overflow with large hash tables.
4491 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4492 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4493 (SXHASH_REDUCE): New macro.
4494 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4495 Use it instead of discarding useful hash info with large hash values.
4496 (sxhash_float): New function.
4497 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4498 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4499 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4500 Rewrite to use FIXNUM_BITS, as this simplifies things.
4501 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4502 Adjust signatures to match updated version of code.
4503 (consing_since_gc): Now EMACS_INT, since a single hash table can
4504 use more than INT_MAX bytes.
4506 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4508 Make it possible to build with GCC-4.6+ -O2 -flto.
4510 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4512 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4514 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4515 Call minibuffer-inactive-mode.
4517 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4519 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4520 Update dependencies.
4522 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4524 * data.c (init_data): Remove code for UTS, this system is not
4527 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4529 Don't force ./temacs to start in terminal mode.
4531 * frame.c (make_initial_frame): Initialize faces in all cases, not
4532 only when CANNOT_DUMP is defined.
4533 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4535 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4537 * dispnew.c (add_window_display_history): Use const for the string
4538 pointer. Remove declaration, not needed.
4540 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4542 Use 'inline', not 'INLINE'.
4543 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4544 * alloc.c, fontset.c (INLINE): Remove.
4545 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4546 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4547 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4548 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4549 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4551 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4553 Make it possible to run ./temacs.
4555 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4556 syms_of_callproc does the same thing. Remove test for
4557 "initialized", do it in the caller.
4558 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4560 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4562 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4563 (read_minibuf): Use get_minibuffer.
4564 (syms_of_minibuf): Use DEFSYM.
4565 (Qmetadata): New var.
4566 * data.c (Qbuffer): Don't make it static.
4567 (syms_of_data): Use DEFSYM.
4569 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4571 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4572 (CCL_CODE_MIN): New macro.
4574 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4576 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4578 * eval.c (Qdebug): Now static.
4579 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4580 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4581 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4583 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4585 * image.c: Various fixes to ImageMagick code comments.
4586 (Fimagemagick_types): Doc fix.
4588 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4590 Minor fixes prompted by GCC 4.6.0 warnings.
4592 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4594 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4595 (x_clipboard_manager_save_all): Move extern decl to ...
4596 * xterm.h: ... here, so that it can be checked for consistency.
4598 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4600 * xselect.c (x_clipboard_manager_save_frame)
4601 (x_clipboard_manager_save_all): New functions.
4602 (Fx_clipboard_manager_save): Lisp function deleted.
4604 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4605 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4607 * xterm.h: Update prototype.
4609 2011-05-28 William Xu <william.xwl@gmail.com>
4611 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4614 2011-05-28 Jim Meyering <meyering@redhat.com>
4616 Avoid a sign-extension bug in crypto_hash_function.
4617 * fns.c (to_uchar): Define.
4618 (crypto_hash_function): Use it to convert some newly-signed
4619 variables to unsigned, to avoid sign-extension bugs. For example,
4620 without this change, (md5 "truc") would evaluate to
4621 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4622 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4623 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4625 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4627 Integer overflow fixes.
4629 * dbusbind.c: Serial number integer overflow fixes.
4630 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4631 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4632 to hold a serial number that is too large for a fixnum.
4633 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4634 Check for serial numbers out of range. Decode any serial number
4635 that was so large that it became a float. (Bug#8722)
4637 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4638 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4639 Use XFASTINT rather than XUINT when numbers are nonnegative.
4640 (xd_append_arg, Fdbus_method_return_internal):
4641 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4642 arguments, check that Lisp number is nonnegative, rather than
4643 silently wrapping negative numbers around. (Bug#8722)
4644 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4647 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4649 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4651 ccl: add integer overflow checks
4652 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4653 (IN_INT_RANGE): New macros.
4654 (ccl_driver): Use them to check for integer overflow when
4655 decoding a CCL program. Many of the new checks are whether XINT (x)
4656 fits in int; it doesn't always, on 64-bit hosts. The new version
4657 doesn't catch all possible integer overflows, but it's an
4658 improvement. (Bug#8719)
4660 * alloc.c (make_event_array): Use XINT, not XUINT.
4661 There's no need for unsigned here.
4663 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4664 This follows up to the 2011-05-06 change that substituted uintptr_t
4665 for EMACS_INT. This case wasn't caught back then.
4667 Rework Fformat to avoid integer overflow issues.
4668 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4669 now (part of C89). Include <verify.h>.
4670 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4671 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4672 (Fformat): Avoid the prepass trying to compute sizes; it was only
4673 approximate and thus did not catch overflow reliably. Instead, walk
4674 through the format just once, formatting and computing sizes as we go,
4675 checking for integer overflow at every step, and allocating a larger
4676 buffer as needed. Keep track separately whether the format is
4677 multibyte. Keep only the most-recently calculated precision, rather
4678 than them all. Record whether each argument has been converted to
4679 string. Use EMACS_INT, not int, for byte and char and arg counts.
4680 Support field widths and precisions larger than INT_MAX. Avoid
4681 sprintf's undefined behavior with conversion specifications such as %#d
4682 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4683 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4684 formatting out-of-range floating point numbers with int
4687 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4689 * data.c: Avoid integer truncation in expressions involving floats.
4690 * data.c: Include <intprops.h>.
4691 (arith_driver): When there's an integer overflow in an expression
4692 involving floating point, convert the integers to floating point
4693 so that the resulting value does not suffer from catastrophic
4694 integer truncation. For example, on a 64-bit host (* 4
4695 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4696 Do not rely on undefined behavior after integer overflow.
4698 merge count_size_as_multibyte, parse_str_to_multibyte
4699 * character.c, character.h (count_size_as_multibyte):
4700 Rename from parse_str_to_multibyte; all uses changed.
4701 Check for integer overflow.
4702 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4703 since it's now a duplicate of the other. This is more of
4704 a character than a buffer op, so better that it's in character.c.
4705 * fns.c, print.c: Adjust to above changes.
4707 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4709 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4711 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4713 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4714 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4715 (x_clipboard_manager_save): Now static.
4716 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4718 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4719 (crypto_hash_function): Now static.
4720 Fix pointer signedness problems. Avoid unnecessary initializations.
4722 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4724 * termhooks.h (Vselection_alist): Make it terminal-local.
4726 * terminal.c (create_terminal): Initialize it.
4728 * xselect.c: Support for clipboard managers.
4729 (Vselection_alist): Move to termhooks.h as terminal-local var.
4730 (LOCAL_SELECTION): New macro.
4731 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4732 (symbol_to_x_atom): Remove gratuitous arg.
4733 (x_handle_selection_request, lisp_data_to_selection_data)
4734 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4735 (x_own_selection, x_get_local_selection, x_convert_selection):
4736 New arg, specifying work frame. Use terminal-local Vselection_alist.
4737 (some_frame_on_display): Delete unused function.
4738 (Fx_own_selection_internal, Fx_get_selection_internal)
4739 (Fx_disown_selection_internal, Fx_selection_owner_p)
4740 (Fx_selection_exists_p): New optional frame arg.
4741 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4742 (x_handle_selection_clear): Don't treat other terminals with the
4743 same keyboard specially. Use the terminal-local Vselection_alist.
4744 (x_clear_frame_selections): Use Frun_hook_with_args.
4746 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4748 * xterm.h: Add support for those atoms.
4750 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4752 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4753 (converted_selections, conversion_fail_tag): New global variables.
4754 (x_selection_request_lisp_error): Free the above.
4755 (x_get_local_selection): Remove unnecessary code.
4756 (x_reply_selection_request): Args changed; handle arbitrary array
4757 of converted selections stored in converted_selections.
4758 Separate the XChangeProperty and SelectionNotify steps.
4759 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4760 (x_convert_selection): New function.
4761 (x_handle_selection_event): Simplify.
4762 (x_get_foreign_selection): Don't ignore incoming requests while
4763 waiting for an answer; this will fail when we implement
4764 SAVE_TARGETS, and seems unnecessary anyway.
4765 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4766 (Vx_sent_selection_functions): Doc fix.
4768 2011-05-26 Leo Liu <sdl.web@gmail.com>
4770 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4772 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4774 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4776 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4777 for fringe update if it has periodic bitmap.
4778 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4779 and fringe_bitmap_periodic_p.
4781 * fringe.c (get_fringe_bitmap_data): New function.
4782 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4783 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4784 row. Mark glyph row for fringe update if periodicity changed.
4786 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4787 for fringe update unless it has periodic bitmap.
4789 2011-05-25 Kenichi Handa <handa@m17n.org>
4791 * xdisp.c (get_next_display_element): Set correct it->face_id for
4792 a static composition.
4794 2011-05-24 Leo Liu <sdl.web@gmail.com>
4797 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4799 * fns.c (crypto_hash_function, Fsha1): New function.
4800 (Fmd5): Use crypto_hash_function.
4801 (syms_of_fns): Add Ssha1.
4803 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4805 * gnutls.c: Remove unused macros.
4806 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4807 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4808 Remove macros that are defined and never used.
4809 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4811 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4813 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4814 (Fx_get_selection_internal): Minor cleanup.
4815 (Fx_own_selection_internal): Rename arguments for consistency with
4818 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4820 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4822 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4824 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4826 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4828 * dispnew.c (scrolling_window): Don't exclude the case that the
4829 last enabled row in the desired matrix touches the bottom boundary.
4831 2011-05-21 Glenn Morris <rgm@gnu.org>
4833 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4834 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4835 and add some more files.
4837 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4839 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4840 report_file_error introduced by the change from 2011-05-07.
4842 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4844 * systime.h (Time): Define only if emacs is defined.
4845 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4846 where the include path doesn't have X11/X.h by default. See
4847 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4849 2011-05-20 Kenichi Handa <handa@m17n.org>
4851 * composite.c (find_automatic_composition): Fix previous change.
4853 2011-05-20 Glenn Morris <rgm@gnu.org>
4855 * lisp.mk: New file, split from Makefile.in.
4856 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4857 (shortlisp): Remove.
4858 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4860 2011-05-19 Glenn Morris <rgm@gnu.org>
4862 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4863 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4864 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4865 (lisp): Set the order to that of loadup.el.
4866 (shortlisp): Make it a copy of $lisp.
4867 (SOME_MACHINE_LISP): Remove.
4868 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4869 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4871 2011-05-18 Kenichi Handa <handa@m17n.org>
4873 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4874 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4875 (find_automatic_composition): Mostly rewrite for efficiency.
4877 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4879 * makefile.w32-in: Update dependencies.
4881 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4883 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4884 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4886 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4888 Fix some integer overflow issues, such as string length overflow.
4890 * insdel.c (count_size_as_multibyte): Check for string overflow.
4892 * character.c (lisp_string_width): Check for string overflow.
4893 Use EMACS_INT, not int, for string indexes and lengths; in
4894 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4895 the resulting string length overflows an EMACS_INT; instead,
4896 report a string overflow if no precision given. When checking for
4897 precision exhaustion, use a check that cannot possibly have
4898 integer overflow. (Bug#8675)
4899 * character.h (lisp_string_width): Adjust to new signature.
4901 * alloc.c (string_overflow): New function.
4902 (Fmake_string): Use it. This doesn't change behavior, but saves
4903 a few bytes and will simplify future changes.
4904 * character.c (string_escape_byte8): Likewise.
4905 * lisp.h (string_overflow): New decl.
4907 Fixups, following up to the user-interface timestamp change.
4908 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4909 for UI timestamps, instead of unsigned long.
4910 * msdos.c (mouse_get_pos): Likewise.
4911 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4912 * w32gui.h (Time): Define by including "systime.h" rather than by
4913 declaring it ourselves. (Bug#8664)
4915 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4916 * image.c (clear_image_cache): Likewise.
4918 * term.c (term_mouse_position): Don't assume time_t wraparound.
4920 Be more systematic about user-interface timestamps.
4921 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4922 and sometimes 'EMACS_UINT', to represent these timestamps.
4923 This change causes it to use 'Time' uniformly, as that's what X uses.
4924 This makes the code easier to follow, and makes it easier to catch
4925 integer overflow bugs such as Bug#8664.
4926 * frame.c (Fmouse_position, Fmouse_pixel_position):
4927 Use Time, not unsigned long, for user-interface timestamps.
4928 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4929 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4930 * keyboard.h (last_event_timestamp): Likewise.
4931 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4932 * menu.h (xmenu_show): Likewise.
4933 * term.c (term_mouse_position): Likewise.
4934 * termhooks.h (struct input_event.timestamp): Likewise.
4935 (struct terminal.mouse_position_hook): Likewise.
4936 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4937 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4938 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4939 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4941 * menu.h, termhooks.h: Include "systime.h", for Time.
4943 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4944 Don't assume that the difference between two unsigned long values
4945 can fit into an integer. At this point, we know button_down_time
4946 <= event->timestamp, so the difference must be nonnegative, so
4947 there's no need to cast the result if double-click-time is
4948 nonnegative, as it should be; check that it's nonnegative, just in
4949 case. This bug is triggered when events are more than 2**31 ms
4950 apart (about 25 days). (Bug#8664)
4952 * xselect.c (last_event_timestamp): Remove duplicate decl.
4953 (x_own_selection): Remove needless cast to unsigned long.
4955 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4956 that always fit in int. Use a sentinel instead of a counter, to
4957 avoid a temp and to allay GCC's concerns about possible int overflow.
4958 * frame.h (struct frame): Use int for menu_bar_items_used
4959 instead of EMACS_INT, since it always fits in int.
4961 * menu.c (grow_menu_items): Check for int overflow.
4963 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4965 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4966 Before, the code was not consistent. These values cannot exceed
4967 2**31 - 1 so there's no need to make them unsigned.
4968 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4969 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4970 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4972 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4974 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4975 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4976 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4977 presumably because the widths might not match.
4979 * window.c (size_window): Avoid needless test at loop start.
4981 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4983 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4985 2011-05-12 Drew Adams <drew.adams@oracle.com>
4987 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4989 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4991 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4992 `width' to `bar_area_x' and `bar_area_width', respectively.
4993 (x_scroll_run): Take account of fringe background extension.
4995 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4996 Rename local vars `left' and `width' to `bar_area_x' and
4997 `bar_area_width', respectively.
4998 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4999 background extension.
5001 2011-05-10 Jim Meyering <meyering@redhat.com>
5003 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5005 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5007 * image.c (Finit_image_library): Return t for built-in image types,
5008 like pbm and xbm. (Bug#8640)
5010 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5012 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5014 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5016 * w32console.c (Fset_screen_color): Doc fix.
5017 (Fget_screen_color): New function.
5018 (syms_of_ntterm): Defsubr it.
5020 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5021 unlink the temporary file if Fcall_process didn't create it in the
5023 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5024 child process will be redirected to a file specified with `:file'.
5025 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5026 cue to call_process_cleanup not to close that handle.
5028 2011-05-07 Ben Key <bkey76@gmail.com>
5030 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5031 one of two shell specific rules, either bootstrap-temacs-CMD or
5032 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5033 to the previous implementation of the bootstrap-temacs rule.
5034 The bootstrap-temacs-CMD rule is similar to the previous
5035 implementation of the bootstrap-temacs rule except that it
5036 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5039 These changes, along with some changes to nt/configure.bat,
5040 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5041 earlier fix to add support for --cflags and --ldflags options
5042 that include quotes so that it works whether make uses cmd or
5045 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5047 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5048 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5050 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5051 a string. Handle both cases.
5052 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5053 (Fdbus_register_method): Use Qinvalid_function.
5055 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5057 * makefile.w32-in: Update dependencies.
5058 (LISP_H): Add inttypes.h and stdin.h.
5059 (PROCESS_H): Add unistd.h.
5061 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5063 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5064 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5066 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5068 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5070 * term.c (vfatal): Remove stray call to va_end.
5071 It's not needed and the C Standard doesn't allow it here anyway.
5073 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5074 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5076 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5079 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5081 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5083 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5085 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5087 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5089 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5090 * charset.c (Fdefine_charset_internal): Don't initialize
5091 charset.code_space[15]. The value was garbage, on hosts with
5092 32-bit int (Bug#8600).
5094 * lread.c (read_integer): Be more consistent with string-to-number.
5095 Use string_to_number to do the actual conversion; this avoids
5096 rounding errors and fixes some other screwups. Without this fix,
5097 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5098 (digit_to_number): Move earlier, for benefit of read_integer.
5099 Return -1 if the digit is out of range for the base, -2 if it is
5100 not a digit in any supported base. (Bug#8602)
5102 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5104 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5105 to match comment at start of function. This also removes a
5106 GCC warning about overflow in a 32+64-bit port.
5108 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5110 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5111 Reported by Stefan Monnier in
5112 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5113 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5114 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5116 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5117 (EMACS_UINTPTR): Likewise, with uintptr_t.
5119 * lisp.h: Prefer 64-bit EMACS_INT if available.
5120 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5121 on 32-bit hosts that have 64-bit int, so that they can access
5123 However, temporarily disable this change unless the temporary
5124 symbol WIDE_EMACS_INT is defined.
5126 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5128 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5129 This removes an assumption that EMACS_INT and long are the same
5130 width as pointers. The assumption is true for Emacs porting targets
5131 now, but we want to make other targets possible.
5132 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5133 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5134 In the rest of the code, change types of integers that hold casted
5135 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5136 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5137 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5138 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5139 No need to cast type when ORing.
5140 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5141 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5142 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5143 assume EMACS_INT is the same width as char *.
5144 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5145 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5146 Remove no-longer-needed casts.
5147 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5148 (xg_tool_bar_help_callback, xg_make_tool_item):
5149 Use EMACS_INTPTR to hold an integer
5150 that will be cast to void *; this can avoid a GCC warning
5151 if EMACS_INT is not the same width as void *.
5152 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5153 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5154 (current_message_1, set_message_1):
5155 Use a local to convert to proper width without a cast.
5156 * xmenu.c (dialog_selection_callback): Likewise.
5158 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5159 Also, don't assume VALBITS / RAND_BITS is less than 5,
5160 and don't rely on undefined behavior when shifting a 1 left into
5162 * lisp.h (get_random): Change signature to match.
5164 * lread.c (hash_string): Use size_t, not int, for hash computation.
5165 Normally we prefer signed values; but hashing is special, because
5166 it's better to use unsigned division on hash table sizes so that
5167 the remainder is nonnegative. Also, size_t is the natural width
5168 for hashing into memory. The previous code used 'int', which doesn't
5169 retain enough info to hash well into very large tables.
5170 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5172 * dbusbind.c: Don't possibly lose pointer info when converting.
5173 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5174 Use XPNTR rather than XHASH, so that the high-order bits of
5175 the pointer aren't lost when converting through void *.
5177 * eval.c (Fautoload): Don't double-shift a pointer.
5179 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5181 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5183 * gnutls.c (DEF_GNUTLS_FN):
5184 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5186 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5188 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5191 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5193 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5194 New version that can reserve upto 2GB of heap space.
5196 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5198 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5200 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5202 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5203 `gnutls_certificate_set_x509_key_file'.
5205 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5207 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5208 Update dependencies.
5210 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5212 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5213 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5214 Remove unused parameter `fildes'.
5215 * process.c (read_process_output, send_process): Don't pass it.
5217 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5219 Fix previous change: the library cache is defined in w32.c.
5220 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5221 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5223 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5225 Implement dynamic loading of GnuTLS on Windows.
5227 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5228 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5229 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5232 * gnutls.c (Qgnutls_dll): Define.
5233 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5234 (gnutls_*): Declare function pointers.
5235 (init_gnutls_functions): New function to initialize function pointers.
5236 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5237 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5238 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5239 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5240 (emacs_gnutls_write, emacs_gnutls_read)
5241 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5242 (Fgnutls_available_p): New function.
5243 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5244 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5245 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5247 * image.c: Include w32.h.
5248 (Vimage_type_cache): Delete.
5249 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5250 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5251 (w32_delayed_load): Move to w32.c.
5253 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5255 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5256 (w32_delayed_load): Move from image.c. When loading a library, record
5257 its filename in the :loaded-from property of the library id.
5258 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5259 Initialize and staticpro them.
5260 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5262 * process.c: Include lisp.h before w32.h, not after.
5263 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5264 instead of gnutls_record_check_pending.
5266 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5268 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5270 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5271 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5274 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5276 * xterm.c (x_set_frame_alpha): Do not set property on anything
5277 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5279 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5281 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5283 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5285 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5286 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5287 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5288 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5289 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5290 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5291 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5292 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5293 (Qgnutls_bootprop_callbacks_verify): Make static.
5295 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5297 * callproc.c: Indentation fixup.
5299 * sysdep.c (wait_for_termination_1): Make static.
5300 (wait_for_termination, interruptible_wait_for_termination):
5301 Move after wait_for_termination_1.
5303 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5305 * sysdep.c (interruptible_wait_for_termination): New function
5306 which is like wait_for_termination, but allows keyboard
5309 * callproc.c (Fcall_process): Add (:file "file") as an option for
5311 (Fcall_process_region): Ditto.
5313 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5315 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5316 rather than `XVECTOR (FOO)->size'.
5318 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5319 inttypes.h, as a gnulib replacement is used if it not available in
5322 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5324 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5325 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5326 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5328 * coding.c (coding_alloc_by_realloc): Error out if destination
5329 will grow beyond MOST_POSITIVE_FIXNUM.
5330 (decode_coding_emacs_mule): Abort if there isn't enough place in
5331 charbuf for the composition carryover bytes. Reserve an extra
5332 space for up to 2 characters produced in a loop.
5333 (decode_coding_iso_2022): Abort if there isn't enough place in
5334 charbuf for the composition carryover bytes.
5336 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5338 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5339 aborting when %lld or %lll format is passed.
5340 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5341 %llo or %llx format is passed. (Bug#8545)
5343 * window.c (window_scroll_line_based): Use a marker instead of
5344 simple variables to record original value of point. (Bug#7952)
5346 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5347 produced by %s or %c overflows available buffer space. (Bug#8545)
5349 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5351 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5352 (SIZE_MAX): Move defn after all includes, as they might #define it.
5354 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5356 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5358 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5360 * keyboard.c (Qdelayed_warnings_hook): Define.
5361 (command_loop_1): Run `delayed-warnings-hook'
5362 if Vdelayed_warnings_list is non-nil.
5363 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5364 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5366 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5368 * doprnt.c (doprnt): Don't return value smaller than the buffer
5369 size if the message was truncated. (Bug#8545).
5371 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5373 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5374 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5376 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5378 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5380 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5382 * makefile.w32-in: Update dependencies.
5384 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5386 Improve `doprnt' and its usage. (Bug#8545)
5387 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5388 `format_end'. Remove support for %l as a conversion specifier.
5389 Don't use xrealloc. Improve diagnostics when the %l size modifier
5390 is used. Update the commentary.
5392 * eval.c (verror): Simplify calculation of size_t.
5394 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5397 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5399 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5402 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5404 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5405 This makes this file independent of the recent pseudovector change.
5407 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5409 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5411 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5412 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5413 Remove unused local.
5414 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5416 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5417 GCC 4.6.0 optimizes based on type-based alias analysis.
5418 For example, if b is of type struct buffer * and v of type struct
5419 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5420 != &v->size, and therefore "v->size = 1; b->size = 2; return
5421 v->size;" must therefore return 1. This assumption is incorrect
5422 for Emacs, since it type-puns struct Lisp_Vector * with many other
5423 types. To fix this problem, this patch adds a new type struct
5424 vectorlike_header that documents the constraints on layout of vectors
5425 and pseudovectors, and helps optimizing compilers not get fooled
5426 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5427 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5428 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5430 (XSETPVECTYPE): Rewrite in terms of new macro.
5431 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5432 This is a bit clearer, and further avoids the possibility of
5433 undesirable aliasing.
5434 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5435 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5436 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5437 since Lisp_Subr is a special case (no "next" field).
5438 (ASIZE): Now uses header.size rather than size.
5439 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5440 to avoid the hassle of writing XVECTOR (foo)->header.size.
5441 (struct vectorlike_header): New type.
5442 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5443 object, to help avoid aliasing.
5444 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5445 (SUBRP): Likewise, since Lisp_Subr is a special case.
5446 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5447 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5448 (struct Lisp_Hash_Table): Combine first two members into a single
5449 struct vectorlike_header member. All uses of "size" and "next" members
5450 changed to be "header.size" and "header.next".
5451 * buffer.h (struct buffer): Likewise.
5452 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5453 * frame.h (struct frame): Likewise.
5454 * process.h (struct Lisp_Process): Likewise.
5455 * termhooks.h (struct terminal): Likewise.
5456 * window.c (struct save_window_data, struct saved_window): Likewise.
5457 * window.h (struct window): Likewise.
5458 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5459 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5460 * buffer.c (init_buffer_once): Likewise.
5461 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5463 * process.c (Fformat_network_address): Use local var for size,
5466 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5468 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5469 * data.c (atof): Remove decl; no longer used or needed.
5470 (digit_to_number): Move to lread.c.
5471 (Fstring_to_number): Use new string_to_number function, to be
5472 consistent with how the Lisp reader treats infinities and NaNs.
5473 Do not assume that floating-point numbers represent EMACS_INT
5474 without losing information; this is not true on most 64-bit hosts.
5475 Avoid double-rounding errors, by insisting on integers when
5476 parsing non-base-10 numbers, as the documentation specifies.
5477 * lisp.h (string_to_number): New decl, replacing ...
5478 (isfloat_string): Remove.
5479 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5480 (read1): Do not accept +. and -. as integers; this
5481 appears to have been a coding error. Similarly, do not accept
5482 strings like +-1e0 as floating point numbers. Do not report
5483 overflow for integer overflows unless the base is not 10 which
5484 means we have no simple and reliable way to continue.
5485 Break out the floating-point parsing into a new
5486 function string_to_number, so that Fstring_to_number parses
5487 floating point numbers consistently with the Lisp reader.
5488 (digit_to_number): Move here from data.c. Make it static inline.
5489 (E_CHAR, EXP_INT): Remove, replacing with ...
5490 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5491 (string_to_number): New function, replacing isfloat_string.
5492 This function checks for valid syntax and produces the resulting
5493 Lisp float number too. Rework it so that string-to-number
5494 no longer mishandles examples like "1.0e+". Use strtoumax,
5495 so that overflow for non-base-10 numbers is reported only when
5496 there's no portable and simple way to convert to floating point.
5498 * textprop.c (set_text_properties_1): Rewrite for clarity,
5499 and to avoid GCC warning about integer overflow.
5501 * intervals.h (struct interval): Use EMACS_INT for members
5502 where EMACS_UINT might cause problems. See
5503 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5504 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5505 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5507 (offset_intervals): Tell GCC not to worry about length overflow
5508 when negating a negative length.
5510 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5511 (overrun_check_free): Likewise.
5513 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5514 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5517 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5518 (gnutls_make_error): Rename local to avoid shadowing.
5519 (gnutls_emacs_global_deinit): ifdef out; not used.
5520 (Fgnutls_boot): Use const for pointer to readonly storage.
5521 Comment out unused local. Fix pointer signedness problems.
5523 * lread.c (openp): Don't stuff size_t into an 'int'.
5524 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5525 about possible signed overflow.
5527 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5528 (GDK_KEY_g): Don't define if already defined.
5529 (xg_prepare_tooltip): Avoid pointer signedness problem.
5530 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5532 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5533 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5535 * xfns.c (Fx_window_property): Simplify a bit,
5536 to make a bit faster and to avoid GCC 4.6.0 warning.
5537 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5539 * fns.c (internal_equal): Don't assume size_t fits in int.
5541 * alloc.c (compact_small_strings): Tighten assertion a little.
5543 Replace pEd with more-general pI, and fix some printf arg casts.
5544 * lisp.h (pI): New macro, generalizing old pEd macro to other
5545 conversion specifiers. For example, use "...%"pI"d..." rather
5546 than "...%"pEd"...".
5547 (pEd): Remove. All uses replaced with similar uses of pI.
5548 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5549 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5550 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5551 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5552 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5553 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5554 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5556 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5557 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5558 * print.c (safe_debug_print, print_object): Likewise.
5559 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5561 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5562 avoiding the 0 flag, which is not portable.
5563 * process.c (Fmake_network_process): Use pI to avoid cast.
5564 * region-cache.c (pp_cache): Likewise.
5565 * xdisp.c (decode_mode_spec): Likewise.
5566 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5567 behavior on 64-bit hosts with printf arg.
5568 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5569 (x_stop_queuing_selection_requests): Likewise.
5570 (x_get_window_property): Don't truncate byte count to an 'int'
5573 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5574 here, since it parses constructs like leading '-' and spaces,
5575 which are not wanted; and it overflows with large numbers.
5576 Instead, simply match F[0-9]+, which is what is wanted anyway.
5578 * alloc.c: Remove unportable assumptions about struct layout.
5579 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5580 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5581 (allocate_vectorlike, make_pure_vector): Use the new macros,
5582 plus offsetof, to remove unportable assumptions about struct layout.
5583 These assumptions hold on all porting targets that I know of, but
5584 they are not guaranteed, they're easy to remove, and removing them
5585 makes further changes easier.
5587 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5588 This doesn't fix a bug but makes the code clearer.
5589 (string_overrun_cookie): Now const. Use initializers that
5590 don't formally overflow signed char, to avoid warnings.
5591 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5592 can cause Emacs to crash when string overrun checking is enabled.
5593 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5594 multiple of sizeof (EMACS_INT); it need not be, if
5595 alignof(EMACS_INT) < sizeof (EMACS_INT).
5596 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5598 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5600 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5602 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5604 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5605 supposed to be handshaking. (Bug#8556)
5606 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5608 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5610 * lisp.h (Qdebug): List symbol.
5611 * eval.c (Qdebug): Restore global linkage.
5612 * keyboard.c (debug-on-event): New variable.
5613 (handle_user_signal): Break into debugger when debug-on-event
5614 matches the current signal symbol.
5616 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5618 * alloc.c (check_sblock, check_string_bytes)
5619 (check_string_free_list): Convert to standard C.
5621 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5623 * w32.c (emacs_gnutls_push): Fix typo.
5625 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5627 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5628 "cast to pointer from integer of different size".
5630 Improve doprnt and its use in verror. (Bug#8545)
5631 * doprnt.c (doprnt): Document the set of format control sequences
5632 supported by the function. Use SAFE_ALLOCA instead of always
5635 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5636 is one byte too soon. Don't use xrealloc; instead xfree and
5639 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5641 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5644 * gnutls.c: Renamed global_initialized to
5645 gnutls_global_initialized. Added internals for the
5646 :verify-hostname-error, :verify-error, and :verify-flags
5647 parameters of `gnutls-boot' and documented those parameters in the
5648 docstring. Start callback support.
5649 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5650 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5651 on error. Return error code.
5652 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5653 (emacs_gnutls_read): Likewise.
5654 (Fgnutls_boot): Return handshake error code.
5655 (emacs_gnutls_handle_error): New function.
5656 (wsaerror_to_errno): Likewise.
5658 * w32.h (emacs_gnutls_pull): Add prototype.
5659 (emacs_gnutls_push): Likewise.
5661 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5662 (emacs_gnutls_push): Likewise.
5664 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5666 * process.c (wait_reading_process_output): Check if GnuTLS
5667 buffered some data internally if no FDs are set for TLS
5670 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5671 (LIBS): Link to USER_LIBS.
5672 ($(BLD)/gnutls.$(0)): New target.
5674 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5676 * xdisp.c (handle_single_display_spec): Rename the
5677 display_replaced_before_p argument into display_replaced_p, to
5678 make it consistent with the commentary. Fix typos in the
5681 * textprop.c (syms_of_textprop): Remove dead code.
5682 (copy_text_properties): Delete obsolete commentary about an
5683 interface that was deleted long ago. Fix typos in the description
5686 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5687 to changes in oldXMenu/XMenu.h from 2011-04-16.
5688 <menu_help_message, prev_menu_help_message>: Constify.
5689 (IT_menu_make_room): menu->help_text is now `const char **';
5692 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5693 to changes in oldXMenu/XMenu.h from 2011-04-16.
5694 (struct XMenu): Declare `help_text' `const char **'.
5696 * xfaces.c <Qunspecified>: Make extern again.
5698 * syntax.c: Include sys/types.h before including regex.h, as
5701 * doc.c (get_doc_string): Improve the format passed to `error'.
5703 * doprnt.c (doprnt): Improve commentary.
5705 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5707 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5710 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5711 changes in globals.h immediately force recompilation.
5712 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5713 $(CURDIR)/s/ms-w32.h.
5714 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5716 * character.c (Fchar_direction): Function deleted.
5717 (syms_of_character): Don't defsubr it.
5718 <char-direction-table>: Deleted.
5720 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5722 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5723 * doprnt.c: Include limits.h.
5724 (SIZE_MAX): New macro.
5725 (doprnt): Return a size_t value. 2nd arg is now size_t.
5726 Many local variables are now size_t instead of int or unsigned.
5727 Improve overflow protection. Support `l' modifier for integer
5728 conversions. Support %l conversion. Don't assume an EMACS_INT
5729 argument for integer conversions and for %c.
5731 * lisp.h (doprnt): Restore prototype.
5733 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5736 * Makefile.in (base_obj): Add back doprnt.o.
5738 * deps.mk (doprnt.o): Add back prerequisites.
5739 (callint.o): Depend on character.h.
5741 * eval.c (internal_lisp_condition_case): Include the handler
5742 representation in the error message.
5743 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5744 when breaking from the loop.
5746 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5748 * callint.c (Fcall_interactively): When displaying error message
5749 about invalid control letter, pass the character's codepoint, not
5750 a pointer to its multibyte form. Improve display of the character
5751 in octal and display also its hex code.
5753 * character.c (char_string): Use %x to display the (unsigned)
5754 codepoint of an invalid character, to avoid displaying a bogus
5757 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5758 `error', not SYMBOL_NAME itself.
5760 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5761 character arguments to `error'.
5763 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5764 to `error' in error message about FINAL_CHAR argument. Make sure
5765 FINAL_CHAR is a character, and use %c when it is passed as
5766 argument to `error'.
5768 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5770 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5772 * w32.c: Include <time.h>.
5773 (sys_localtime): New function.
5775 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5777 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5779 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5781 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5783 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5786 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5788 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5789 gl_state.e_property when gl_state.object is Qt.
5791 * insdel.c (make_gap_larger): Remove limitation of buffer size
5794 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5796 * xdisp.c (lookup_glyphless_char_display)
5797 (produce_glyphless_glyph): Handle cons cell entry in
5798 glyphless-char-display.
5799 (Vglyphless_char_display): Document it.
5801 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5802 glyphless-char-display.
5804 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5806 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5808 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5810 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5811 definition for no-X builds.
5813 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5815 Static checks with GCC 4.6.0 and non-default toolkits.
5817 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5819 * process.c (keyboard_bit_set): Define only if SIGIO.
5820 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5821 (send_process): Repair possible setjmp clobbering.
5823 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5825 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5827 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5829 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5830 Define only if needed.
5832 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5833 by pacifying GCC about it. Maybe it's time to retire it?
5834 * xfaces.c (USG, __TIMEVAL__): Likewise.
5836 * dispextern.h (struct redisplay_interface): Rename param
5838 * termhooks.h (struct terminal): Likewise.
5839 * xterm.c (xembed_send_message): Likewise.
5841 * insdel.c (make_gap_smaller): Define only if
5842 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5844 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5847 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5848 so that we aren't warned about unused symbols.
5850 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5852 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5854 * xfns.c (x_real_positions): Mark locals as initialized.
5856 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5858 * xterm.c: Fix problems found by static analysis with other toolkits.
5859 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5860 (x_dispatch_event): Declare static if USE_GTK, and
5861 define if USE_GTK || USE_X_TOOLKIT.
5862 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5863 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5864 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5865 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5867 * xmenu.c (menu_help_callback): Pointer type fixes.
5868 Use const pointers when pointing at readonly data. Avoid pointer
5870 (FALSE): Remove unused macro.
5871 (update_frame_menubar): Remove unused decl.
5873 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5875 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5876 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5877 (single_menu_item): Rename local to avoid shadowing.
5879 * keyboard.c (make_lispy_event): Remove unused local var.
5881 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5882 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5884 * bitmaps: Change bitmaps from unsigned char back to the X11
5885 compatible char. Avoid the old compiler warnings about
5886 out-of-range initializers by using, for example, '\xab' rather
5889 * xgselect.c (xgselect_initialize): Check vs interface
5890 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5892 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5894 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5895 to read-only memory.
5897 * fns.c (vector): Remove; this old hack is no longer needed.
5899 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5901 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5903 * xrdb.c (x_load_resources): Omit unused local.
5905 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5906 (x_window): Rename locals to avoid shadowing.
5907 (USG): Use the kludged USG macro, to pacify gcc.
5909 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5910 (x_term_init): Remove local to avoid shadowing.
5912 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5914 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5915 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5917 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5919 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5921 Fix regex.c, syntax.c and friends for buffers > 2GB.
5922 * syntax.h (struct gl_state_s): Declare character position members
5925 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5927 * textprop.c (verify_interval_modification, interval_of):
5928 Declare arguments EMACS_INT.
5930 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5933 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5935 * indent.c (Fvertical_motion): Local variable it_start is now
5938 * regex.c (re_match, re_match_2, re_match_2_internal)
5939 (bcmp_translate, regcomp, regexec, print_double_string)
5940 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5941 (re_compile_pattern, re_exec): Declare arguments and local
5942 variables `size_t' and `ssize_t' and return values `regoff_t', as
5944 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5945 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5946 <compile_stack_type>: `size' and `avail' are now `size_t'.
5948 * regex.h <regoff_t>: Use ssize_t, not int.
5949 (re_search, re_search_2, re_match, re_match_2): Arguments that
5950 specify buffer/string position and length are now ssize_t and
5951 size_t. Return type is regoff_t.
5953 2011-04-16 Ben Key <bkey76@gmail.com>
5955 * nsfont.m: Fixed bugs in ns_get_family and
5956 ns_descriptor_to_entity that were caused by using free to
5957 deallocate memory blocks that were allocated by xmalloc (via
5958 xstrdup). This caused Emacs to crash when compiled with
5959 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5960 --enable-checking=xmallocoverrun). xfree is now used to
5961 deallocate these memory blocks.
5963 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5965 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5967 emacs_write: Accept and return EMACS_INT for sizes.
5968 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5970 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5971 Accept and return EMACS_INT.
5972 (emacs_gnutls_write): Return the number of bytes written on
5974 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5975 (emacs_read, emacs_write): Remove check for negative size, as the
5976 Emacs source code has been audited now.
5977 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5978 (emacs_read, emacs_write): Use it.
5979 * process.c (send_process): Adjust to the new signatures of
5980 emacs_write and emacs_gnutls_write. Do not attempt to store
5981 a byte offset into an 'int'; it might overflow.
5982 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5984 * sound.c: Don't assume sizes fit in 'int'.
5985 (struct sound_device.period_size, alsa_period_size):
5986 Return EMACS_INT, not int.
5987 (struct sound_device.write, vox_write, alsa_write):
5988 Accept EMACS_INT, not int.
5989 (wav_play, au_play): Use EMACS_INT to store sizes and to
5990 record read return values.
5992 2011-04-15 Ben Key <bkey76@gmail.com>
5994 * keyboard.c (Qundefined): Don't declare static since it is used
5996 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5997 static since they are used in nsfont.m.
5999 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6001 * process.c (Qprocessp): Don't declare static.
6002 * lisp.h (Qprocessp): Declare again.
6004 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6006 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6008 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6010 Improve C-level modularity by making more things 'static'.
6012 Don't publish debugger-only interfaces to other modules.
6013 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6014 (verify_bytepos, count_markers): Move decls to the only modules
6016 * region-cache.h (pp_cache): Likewise.
6017 * window.h (check_all_windows): Likewise.
6018 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6020 * sysdep.c (croak): Now static, if
6021 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6022 * syssignal.h (croak): Declare only if not static.
6024 * alloc.c (refill_memory_reserve): Now static if
6025 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6026 * lisp.h (refill_memory_reserve): Declare only if not static.
6028 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6029 Define only if USE_LUCID.
6031 * xrdb.c (x_customization_string, x_rm_string): Now static.
6033 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6034 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6036 * xdisp.c (draw_row_with_mouse_face): Now static.
6037 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6039 * window.h (check_all_windows): Mark externally visible.
6041 * window.c (window_deletion_count): Now static.
6043 * undo.c: Make symbols static if they're not exported.
6044 (last_undo_buffer, last_boundary_position, pending_boundary):
6047 * textprop.c (interval_insert_behind_hooks): Now static.
6048 (interval_insert_in_front_hooks): Likewise.
6050 * term.c: Make symbols static if they're not exported.
6051 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6052 (max_frame_lines, tty_set_terminal_modes):
6053 (tty_reset_terminal_modes, tty_turn_off_highlight):
6054 (get_tty_terminal): Now static.
6055 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6056 * termhooks.h (term_mouse_moveto): Do not declare if
6058 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6059 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6061 * sysdep.c: Make symbols static if they're not exported.
6062 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6064 (sigprocmask_set, full_mask): Remove; unused.
6065 (wait_debugging): Mark as visible.
6066 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6067 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6069 * syntax.c (syntax_temp): Define only if !__GNUC__.
6071 * sound.c (current_sound_device, current_sound): Now static.
6073 * search.c (searchbufs, searchbuf_head): Now static.
6075 * scroll.c (scroll_cost): Remove; unused.
6076 * dispextern.h (scroll_cost): Remove decl.
6078 * region-cache.h (pp_cache): Mark as externally visible.
6080 * process.c: Make symbols static if they're not exported.
6081 (process_tick, update_tick, create_process, chan_process):
6082 (Vprocess_alist, proc_buffered_char, datagram_access):
6083 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6084 (deactivate_process): Mark defn as static, as well as decl.
6085 * lisp.h (create_process): Remove decl.
6086 * process.h (chan_process, Vprocess_alist): Remove decls.
6088 * print.c: Make symbols static if they're not exported.
6089 (print_depth, new_backquote_output, being_printed, print_buffer):
6090 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6091 (print_interval, print_number_index, initial_stderr_stream):
6093 * lisp.h (Fprinc): Remove decl.
6094 (debug_output_compilation_hack): Mark as externally visible.
6096 * sysdep.c (croak): Move decl from here to syssignal.h.
6097 * syssignal.h (croak): Put it here, so the API can be checked when
6098 'croak' is called from dissociate_if_controlling_tty.
6100 * minibuf.c: Make symbols static if they're not exported.
6101 (minibuf_save_list, choose_minibuf_frame): Now static.
6102 * lisp.h (choose_minibuf_frame): Remove decl.
6104 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6106 * lread.c: Make symbols static if they're not exported.
6107 (read_objects, initial_obarray, oblookup_last_bucket_number):
6109 (make_symbol): Remove; unused.
6110 * lisp.h (initial_obarray, make_symbol): Remove decls.
6112 * keyboard.c: Make symbols static if they're not exported.
6113 (single_kboard, recent_keys_index, total_keys, recent_keys):
6114 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6115 (this_single_command_key_start, echoing, last_auto_save):
6116 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6117 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6118 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6119 (Vlispy_mouse_stem, double_click_count):
6121 (force_auto_save_soon): Define only if SIGDANGER.
6122 (ignore_mouse_drag_p): Now static if
6123 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6124 (print_help): Remove; unused.
6125 (stop_character, last_timer_event): Mark as externally visible.
6126 * keyboard.h (ignore_mouse_drag_p): Declare only if
6127 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6128 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6129 * lisp.h (echoing): Remove decl.
6130 (force_auto_save_soon): Declare only if SIGDANGER.
6131 * xdisp.c (redisplay_window): Simplify code, to make it more
6132 obvious that ignore_mouse_drag_p is not accessed if !defined
6133 USE_GTK && !defined HAVE_NS.
6135 * intervals.c: Make symbols static if they're not exported.
6136 (merge_properties_sticky, merge_interval_right, delete_interval):
6138 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6140 * insdel.c: Make symbols static if they're not exported.
6141 However, leave prepare_to_modify_buffer alone. It's never
6142 called from outside this function, but that appears to be a bug.
6143 (combine_after_change_list, combine_after_change_buffer):
6144 (adjust_after_replace, signal_before_change): Now static.
6145 (adjust_after_replace_noundo): Remove; unused.
6146 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6147 (signal_before_change): Remove decls.
6149 * indent.c (val_compute_motion, val_vmotion): Now static.
6151 * image.c: Make symbols static if they're not exported.
6152 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6154 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6155 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6157 * fringe.c (standard_bitmaps): Now static.
6158 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6160 * frame.c: Make symbols static if they're not exported.
6161 (x_report_frame_params, make_terminal_frame): Now static.
6162 (get_frame_param): Now static, unless HAVE_NS.
6163 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6164 (x_get_resource_string): Remove; not used.
6165 * frame.h (make_terminal_frame, x_report_frame_params):
6166 (x_get_resource_string); Remove decls.
6167 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6168 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6170 * font.c, fontset.c: Make symbols static if they're not exported.
6171 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6172 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6173 * font.c (font_close_object): Now static.
6174 * font.h (font_close_object): Remove.
6175 * fontset.c (FONTSET_OBJLIST): Remove.
6176 (free_realized_fontset) #if-0 the body, which does nothing.
6177 (face_suitable_for_char_p): #if-0, as it's never called.
6178 * fontset.h (face_suitable_for_char_p): Remove decl.
6179 * xfaces.c (face_at_string_position):
6180 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6181 since 0 is always ASCII.
6183 * fns.c (weak_hash_tables): Now static.
6185 * fileio.c: Make symbols static if they're not exported.
6186 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6187 (Vwrite_region_annotation_buffers): Now static.
6189 * eval.c: Make symbols static if they're not exported.
6190 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6191 * lisp.h (backtrace_list): Remove decl.
6193 * emacs.c: Make symbols static if they're not exported.
6194 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6195 (fatal_error_code, fatal_error_signal_hook, standard_args):
6197 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6198 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6199 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6200 * lisp.h (fatal_error_signal_hook): Remove decl.
6201 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6203 * editfns.c: Move a (normally-unused) function to its only use.
6204 * editfns.c, lisp.h (get_operating_system_release): Remove.
6205 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6206 worth the hassle of breaking this out.
6208 * xterm.c: Make symbols static if they're not exported.
6209 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6210 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6211 (x_destroy_window, x_delete_display):
6213 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6214 (x_mouse_leave): Remove; unused.
6215 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6216 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6217 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6219 (x_mouse_leave): Declare only if WINDOWSNT.
6220 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6221 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6224 * ftxfont.c: Make symbols static if they're not exported.
6225 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6227 * font.h (ftxfont_driver): Likewise.
6229 * xfns.c: Make symbols static if they're not exported.
6230 (x_last_font_name, x_display_info_for_name):
6231 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6232 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6233 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6234 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6235 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6236 (last_show_tip_args): Now static.
6237 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6238 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6239 (x_screen_planes): Remove; unused.
6240 * dispextern.h (x_screen_planes): Remove decl.
6242 * dispnew.c: Make symbols static if they're not exported.
6243 * dispextern.h (redraw_garbaged_frames, scrolling):
6244 (increment_row_positions): Remove.
6245 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6246 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6248 (redraw_garbaged_frames): Remove; unused.
6250 * xfaces.c: Make symbols static if they're not exported.
6251 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6253 * xterm.h (defined_color): Remove decls.
6254 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6255 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6256 (menu_face_changed_default, defined_color, free_realized_face):
6257 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6258 (ascii_face_of_lisp_face): Remove; unused.
6260 * xdisp.c: Make symbols static if they're not exported.
6261 * dispextern.h (scratch_glyph_row, window_box_edges):
6262 (glyph_to_pixel_coords, set_cursor_from_row):
6263 (get_next_display_element, set_iterator_to_next):
6264 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6265 (show_mouse_face): Remove decls
6266 * frame.h (message_buf_print): Likewise.
6267 * lisp.h (pop_message, set_message, check_point_in_composition):
6269 * xterm.h (set_vertical_scroll_bar): Likewise.
6270 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6271 (message_buf_print, scratch_glyph_row, displayed_buffer):
6272 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6273 (get_next_display_element, show_mouse_face, window_box_edges):
6274 (frame_to_window_pixel_xy, check_point_in_composition):
6275 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6276 (glyph_to_pixel_coords): Remove; unused.
6278 * dired.c (file_name_completion): Now static.
6280 * dbusbind.c (xd_in_read_queued_messages): Now static.
6282 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6283 * data.c (circular_list_error): Remove.
6285 * commands.h (last_point_position, last_point_position_buffer):
6286 (last_point_position_window): Remove decls.
6287 * keyboard.c: Make these variables static.
6289 * coding.h (coding, code_convert_region, encode_coding_gap):
6291 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6292 (iso_code_class, detect_coding, code_convert_region): Now static.
6293 (encode_coding_gap): Remove; unused.
6295 * chartab.c (chartab_chars, chartab_bits): Now static.
6297 * charset.h (charset_iso_8859_1): Remove decl.
6298 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6301 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6302 * ccl.c (Vccl_program_table): Now static.
6303 (check_ccl_update): Remove; unused.
6305 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6306 * category.h: ... from here.
6307 * category.c (check_category_table, set_category_set): Now static.
6309 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6310 * lisp.h: Remove these decls.
6312 * buffer.c (buffer_count): Remove unused var.
6314 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6315 so that it's not optimized away.
6316 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6317 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6318 exported only to the debugger.
6320 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6321 * atimer.h (run_all_atimers): Remove; not exported.
6323 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6324 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6325 was inaccessible from Lisp.
6326 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6327 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6329 alloc.c: Import and export fewer symbols, and remove unused items.
6330 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6332 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6333 it's not optimized away by whole-program optimization.
6334 (message_enable_multibyte, free_misc): Remove.
6335 (catchlist, handlerlist, mark_backtrace):
6336 Declare only if BYTE_MARK_STACK.
6337 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6338 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6339 (message_enable_multibyte): Remove decl.
6340 (free_misc, interval_free_list, float_block, float_block_index):
6341 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6342 (cons_free_list, last_marked_index):
6344 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6345 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6346 (mark_backtrace): Define only if BYTE_MARK_STACK.
6347 * xdisp.c (message_enable_multibyte): Now static.
6349 Declare Lisp_Object Q* variables to be 'static' if not exported.
6350 This makes it easier for human readers (and static analyzers)
6351 to see whether these variables are used from other modules.
6352 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6353 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6354 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6355 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6356 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6357 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6358 * xmenu.c, xselect.c:
6359 Declare Q* vars static if they are not used in other modules.
6360 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6361 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6362 Remove decls of unexported vars.
6363 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6365 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6367 Make Emacs functions such as Fatom 'static' by default.
6368 This makes it easier for human readers (and static analyzers)
6369 to see whether these functions can be called from other modules.
6370 DEFUN now defines a static function. To make the function external
6371 so that it can be used in other C modules, use the new macro DEFUE.
6372 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6373 (Finit_image_library):
6374 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6375 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6376 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6377 Remove decls, since these functions are now static.
6378 (Funintern, Fget_internal_run_time): New decls, since these functions
6379 were already external.
6381 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6382 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6383 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6384 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6385 * keyboard.c, keymap.c, lread.c:
6386 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6387 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6388 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6389 Mark functions with DEFUE instead of DEFUN,
6390 if they are used in other modules.
6391 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6392 decls for now-static functions.
6393 * buffer.h (Fdelete_overlay): Remove decl.
6394 * callproc.c (Fgetenv_internal): Mark as internal.
6395 * composite.c (Fremove_list_of_text_properties): Remove decl.
6396 (Fcomposition_get_gstring): New forward static decl.
6397 * composite.h (Fcomposite_get_gstring): Remove decl.
6398 * dired.c (Ffile_attributes): New forward static decl.
6399 * doc.c (Fdocumntation_property): New forward static decl.
6400 * eval.c (Ffetch_bytecode): New forward static decl.
6401 (Funintern): Remove extern decl; now in .h file where it belongs.
6402 * fileio.c (Fmake_symbolic_link): New forward static decl.
6403 * image.c (Finit_image_library): New forward static decl.
6404 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6405 * intervals.h (Fprevious_property_change):
6406 (Fremove_list_of_text_properties): Remove decls.
6407 * keyboard.c (Fthis_command_keys): Remove decl.
6408 (Fcommand_execute): New forward static decl.
6409 * keymap.c (Flookup_key): New forward static decl.
6410 (Fcopy_keymap): Now static.
6411 * keymap.h (Flookup_key): Remove decl.
6412 * process.c (Fget_process): New forward static decl.
6413 (Fprocess_datagram_address): Mark as internal.
6414 * syntax.c (Fsyntax_table_p): New forward static decl.
6415 (skip_chars): Remove duplicate decl.
6416 * textprop.c (Fprevious_property_change): New forward static decl.
6417 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6419 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6420 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6422 * editfns.c (Fformat): Remove unreachable code.
6424 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6426 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6429 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6431 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6432 when at ZV. (Bug#8487)
6434 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6436 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6438 * keyboard.c (parse_tool_bar_item): Likewise.
6439 * sound.c (sound_cleanup, alsa_close): Likewise.
6440 * termcap.c (tgetent): Likewise.
6441 * xfns.c (x_default_font_parameter): Likewise.
6442 * xsettings.c (read_and_apply_settings): Likewise.
6444 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6445 (overrun_check_free): Protoize.
6447 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6449 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6450 since callers should never pass a negative size.
6451 Change the signature to match that of plain 'read' and 'write'; see
6452 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6453 * lisp.h: Update prototypes of emacs_write and emacs_read.
6455 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6457 * xdisp.c (redisplay_window): Don't try to determine the character
6458 position of the scroll margin if the window start point w->startp
6459 is outside the buffer's accessible region. (Bug#8468)
6461 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6463 Fix write-region and its subroutines for buffers > 2GB.
6464 * fileio.c (a_write, e_write): Modify declaration of arguments and
6465 local variables to support buffers larger than 2GB.
6466 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6468 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6469 argument, local variables, and return value.
6471 * lisp.h: Update prototypes of emacs_write and emacs_read.
6473 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6475 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6477 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6479 Fix more problems found by GCC 4.6.0's static checks.
6481 * xdisp.c (vmessage): Use a better test for character truncation.
6483 * charset.c (load_charset_map): <, not <=, for optimization,
6484 and to avoid potential problems with integer overflow.
6485 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6486 * casetab.c (set_identity, shuffle): Likewise.
6487 * editfns.c (Fformat): Likewise.
6488 * syntax.c (skip_chars): Likewise.
6490 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6491 This also lets GCC 4.6.0 generate slightly better loop code.
6493 * callint.c (Fcall_interactively): <, not <=, for optimization.
6494 (Fcall_interactively): Count the number of arguments produced,
6495 not the number of arguments given. This is simpler and lets GCC
6496 4.6.0 generate slightly better code.
6498 * ftfont.c: Distingish more carefully between FcChar8 and char.
6499 The previous code passed unsigned char * to a functions like
6500 strlen and xstrcasecmp that expect char *, which does not
6501 conform to the C standard.
6502 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6503 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6504 char * when the C standard requires it.
6506 * keyboard.c (read_char): Remove unused var.
6508 * eval.c: Port to Windows vsnprintf (Bug#8435).
6510 (SIZE_MAX): Define if the headers do not.
6511 (verror): Do not give up if vsnprintf returns a negative count.
6512 Instead, grow the buffer. This ports to Windows vsnprintf, which
6513 does not conform to C99. Problem reported by Eli Zaretskii.
6514 Also, simplify the allocation scheme, by avoiding the need for
6515 calling realloc, and removing the ALLOCATED variable.
6517 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6519 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6520 But keep the doprint source code for now, as we might revamp it
6521 and use it again (Bug#8435).
6522 * lisp.h (doprnt): Remove.
6523 * Makefile.in (base_obj): Remove doprnt.o.
6524 * deps.mk (doprnt.o): Remove.
6526 error: Print 32- and 64-bit integers portably (Bug#8435).
6527 Without this change, on typical 64-bit hosts error ("...%d...", N)
6528 was used to print both 32- and 64-bit integers N, which relied on
6530 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6532 * lisp.h (error, verror): Mark as printf-like functions.
6533 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6534 Report overflow in size calculations when allocating printf buffer.
6535 Do not truncate output string at its first null byte.
6536 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6537 Truncate the output at a character boundary, since vsnprintf does not
6539 * charset.c (check_iso_charset_parameter): Convert internal
6540 character to string before calling 'error', since %c now has the
6542 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6543 overflow when computing char to be passed to 'error'. Do not
6544 pass Lisp_Object to 'error'; pass the integer instead.
6545 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6546 formatted with plain %d.
6548 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6550 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6552 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6554 * xterm.c (x_catch_errors): Remove duplicate declaration.
6556 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6558 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6560 2011-04-10 Jim Meyering <meyering@redhat.com>
6562 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6563 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6564 return ssize_t not "int", and use size_t as the buffer length.
6565 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6566 * gnutls.h: Update declarations.
6567 * process.c (read_process_output): Use ssize_t, to match.
6568 (send_process): Likewise.
6570 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6572 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6574 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6576 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6577 Use unsigned char, to match FcChar8 type definition.
6579 * xterm.c (handle_one_xevent):
6580 * xmenu.c (create_and_show_popup_menu):
6581 * xselect.c (x_decline_selection_request)
6582 (x_reply_selection_request): Avoid type-punned deref of X events.
6584 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6586 Fix some uses of `int' instead of EMACS_INT.
6587 * search.c (string_match_1, fast_string_match)
6588 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6589 (scan_buffer, find_next_newline_no_quit)
6590 (find_before_next_newline, search_command, Freplace_match)
6591 (Fmatch_data): Make some `int' variables be EMACS_INT.
6593 * xdisp.c (display_count_lines): 3rd argument and return value now
6594 EMACS_INT. All callers changed.
6595 (pint2hrstr): Last argument is now EMACS_INT.
6597 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6598 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6599 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6600 (decode_coding_utf_16, decode_coding_emacs_mule)
6601 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6602 (decode_coding_ccl, decode_coding_charset)
6603 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6604 (decode_coding_iso_2022, decode_coding_emacs_mule)
6605 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6606 <char_offset, last_offset>: Declare EMACS_INT.
6607 (encode_coding_utf_8, encode_coding_utf_16)
6608 (encode_coding_emacs_mule, encode_invocation_designation)
6609 (encode_designation_at_bol, encode_coding_iso_2022)
6610 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6611 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6613 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6614 (encode_invocation_designation): Last argument P_NCHARS is now
6616 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6617 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6619 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6622 * ccl.c (Fccl_execute_on_string): Declare some variables
6625 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6627 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6629 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6631 * process.c (Fformat_network_address): Doc fix.
6633 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6635 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6637 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6639 * keyboard.c (read_char): Call Lisp function help-form-show,
6640 instead of using internal_with_output_to_temp_buffer.
6641 (Qhelp_form_show): New var.
6642 (syms_of_keyboard): Use DEFSYM macro.
6644 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6646 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6648 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6650 * process.c (Flist_processes): Remove to Lisp.
6651 (list_processes_1): Delete.
6653 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6655 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6657 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6659 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6661 Fix more problems found by GCC 4.6.0's static checks.
6663 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6665 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6667 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6669 * xdisp.c (vmessage): Mark as a printf-like function.
6671 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6673 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6675 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6676 printf-like functions.
6677 (tiff_load): Add casts to remove these marks before passing them
6678 to system-supplied API.
6680 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6682 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6683 This avoids several warnings with gcc -Wstrict-overflow.
6684 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6685 directly, rather than having caller test rule sign. This avoids
6686 some unnecessary tests.
6687 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6688 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6689 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6691 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6692 (xfont_open): Avoid unnecessary tests.
6694 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6696 * composite.h, composite.c (composition_gstring_put_cache):
6697 Use EMACS_INT, not int, for length.
6699 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6700 breaking out part of COMPOSITION_DECODE_RULE.
6701 (COMPOSITION_DECODE_RULE): Use it.
6702 * composite.c (get_composition_id): Remove unused local vars,
6703 by using the new macro.
6705 * textprop.c (set_text_properties_1): Change while to do-while,
6706 since the condition is always true at first.
6708 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6709 (interval_deletion_adjustment): Return unsigned value.
6712 * process.c (list_processes_1, create_pty, read_process_output):
6713 (exec_sentinel): Remove vars that were set but not used.
6714 (create_pty): Remove unnecessary "volatile"s.
6715 (Fnetwork_interface_info): Avoid possibility of int overflow.
6716 (read_process_output): Do adaptive read buffering even if carryover.
6717 (read_process_output): Simplify nbytes computation if buffered.
6719 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6721 * syntax.c (scan_words): Remove var that was set but not used.
6722 (update_syntax_table): Use unsigned instead of int.
6724 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6725 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6726 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6728 * print.c (print_error_message): Avoid int overflow.
6730 * font.c (font_list_entities): Redo for clarity,
6731 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6733 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6734 (font_score): Avoid potential overflow in diff calculation.
6736 * fns.c (substring_both): Remove var that is set but not used.
6737 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6739 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6741 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6742 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6743 can always succeed if overflow has undefined behavior.
6745 * search.c (boyer_moore, wordify): Remove vars set but not used.
6746 (wordify): Omit three unnecessary tests.
6748 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6749 All callers changed. This avoids the need for an unused var.
6751 * casefiddle.c (casify_region): Remove var that is set but not used.
6753 * dired.c (file_name_completion): Remove var that is set but not used.
6755 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6757 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6758 (Finsert_file_contents): Remove unnecessary code checking fd.
6760 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6761 Check for integer overflow on size calculations.
6763 * buffer.c (Fprevious_overlay_change): Remove var that is set
6766 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6767 Remove vars that are set but not used.
6768 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6769 (timer_check_2): Mark vars as initialized.
6771 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6773 * image.c (lookup_image): Remove var that is set but not used.
6774 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6776 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6777 that are set but not used.
6779 * xfns.c (make_invisible_cursor): Don't return garbage
6780 if XCreateBitmapFromData fails (Bug#8410).
6782 * xselect.c (x_get_local_selection, x_handle_property_notify):
6783 Remove vars that are set but not used.
6785 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6786 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6788 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6789 Remove var that is set but not used.
6790 (scroll_bar_windows_size): Now size_t, not int.
6791 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6794 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6795 (map_tty_color) [!defined MSDOS]: Likewise.
6797 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6799 * coding.c: Remove vars that are set but not used.
6800 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6801 All callers changed.
6802 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6803 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6804 (decode_coding_charset): Remove vars that are set but not used.
6806 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6807 that is set but not used.
6809 * print.c (print_object): Remove var that is set but not used.
6811 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6812 The gnulib version avoids calling malloc in the usual case,
6813 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6814 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6815 * filelock.c (current_lock_owner): Likewise.
6816 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6817 * sysdep.c: Include allocator.h, careadlinkat.h.
6818 (emacs_no_realloc_allocator): New static constant.
6819 (emacs_readlink): New function.
6820 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6821 ../lib/careadlinkat.h.
6823 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6825 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6826 first non-nil return value).
6828 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6830 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6831 if not defined (Bug#8403).
6833 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6835 * xdisp.c (display_count_lines): Remove parameter `start',
6836 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6837 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6838 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6839 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6840 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6841 and thereabouts. All callers changed.
6842 (get_per_char_metric): Remove parameter `f', unused since
6843 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6845 2011-04-02 Jim Meyering <meyering@redhat.com>
6847 do not dereference NULL upon failed strdup
6848 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6849 (ns_get_family): Likewise.
6851 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6853 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6855 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6857 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6860 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6862 Add lexical binding.
6864 * window.c (Ftemp_output_buffer_show): New fun.
6865 (Fsave_window_excursion):
6866 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6868 * lread.c (lisp_file_lexically_bound_p): New function.
6869 (Fload): Bind Qlexical_binding.
6870 (readevalloop): Remove `evalfun' arg.
6871 Bind Qinternal_interpreter_environment.
6872 (Feval_buffer): Bind Qlexical_binding.
6873 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6875 (syms_of_lread): Declare `lexical-binding'.
6877 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6879 * keyboard.c (eval_dyn): New fun.
6880 (menu_item_eval_property): Use it.
6882 * image.c (parse_image_spec): Use Ffunctionp.
6884 * fns.c (concat, mapcar1): Accept byte-code-functions.
6886 * eval.c (Fsetq): Handle lexical vars.
6887 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6888 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6889 (FletX, Flet): Obey lexical binding.
6890 (Fcommandp): Handle closures.
6891 (Feval): New `lexical' arg.
6892 (eval_sub): New function extracted from Feval. Use it almost
6893 everywhere where Feval was used. Look up vars in lexical env.
6895 (Ffunctionp): Move from subr.el.
6896 (Ffuncall): Handle closures.
6897 (apply_lambda): Remove `eval_flags'.
6898 (funcall_lambda): Handle closures and new byte-code-functions.
6899 (Fspecial_variable_p): New function.
6900 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6901 but without exporting it to Lisp.
6903 * doc.c (Fdocumentation, store_function_docstring):
6904 * data.c (Finteractive_form): Handle closures.
6906 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6909 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6911 (exec_byte_code): New function extracted from Fbyte_code to handle new
6912 calling convention for byte-code-functions. Add new byte-codes.
6914 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6916 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6918 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6920 * xdisp.c (redisplay_internal): Fix prototype.
6922 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6924 * xdisp.c (SCROLL_LIMIT): New macro.
6925 (try_scrolling): Use it when setting scroll_limit.
6926 Limit scrolling to 100 screen lines.
6927 (redisplay_window): Even when falling back on "recentering",
6928 position point in the window according to scroll-conservatively,
6929 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6931 (try_scrolling): When point is above the window, allow searching
6932 as far as scroll_max, or one screenful, to compute vertical
6933 distance from PT to the scroll margin position. This prevents
6934 try_scrolling from unnecessarily failing when
6935 scroll-conservatively is set to a value slightly larger than the
6936 window height. Clean up the case of PT below the margin at bottom
6937 of window: scroll_max can no longer be INT_MAX. When aggressive
6938 scrolling is in use, don't let point enter the opposite scroll
6939 margin as result of the scroll.
6940 (syms_of_xdisp) <scroll-conservatively>: Document the
6941 threshold of 100 lines for never-recentering scrolling.
6943 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6945 * dispextern.h (move_it_by_lines):
6946 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6947 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6948 (message_log_check_duplicate): Remove parameters `prev_bol' and
6949 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6950 (redisplay_internal): Remove parameter `preserve_echo_area',
6951 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6953 * indent.c (Fvertical_motion):
6954 * window.c (window_scroll_pixel_based, Frecenter):
6955 Don't pass `need_y_p' to `move_it_by_lines'.
6957 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6959 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6960 steal a few bits to be more compact.
6961 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6962 Remove unneeded casts.
6964 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6966 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6968 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6969 binding" message (bug#7967).
6971 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6973 Fix more problems found by GCC 4.6.0's static checks.
6975 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6976 Remove unused local var.
6978 * editfns.c (Fmessage_box): Remove unused local var.
6980 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6981 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6982 Omit unused local vars.
6983 * window.c (shrink_windows): Omit unused local var.
6984 * menu.c (digest_single_submenu): Omit unused local var.
6985 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6986 Omit unused local var.
6988 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6989 Don't assume string length fits in int.
6990 (keyremap_step, read_key_sequence): Use size_t for sizes.
6991 (read_key_sequence): Don't check last_real_key_start redundantly.
6993 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6994 instead of alloca (Bug#8344).
6996 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6997 (Fbacktrace_frame): Don't assume nframes fits in int.
6999 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7001 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7004 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7006 * cm.c (calccost): Turn while-do into do-while, for clarity.
7008 * keyboard.c (syms_of_keyboard): Use the same style as later
7009 in this function when indexing through an array. This also
7010 works around GCC bug 48267.
7012 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7014 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7016 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7017 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7019 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7020 This avoids undefined behavior on integer overflow, and is a bit
7021 more convenient anyway since it is compared to a size_t variable.
7023 Variadic C functions now count arguments with size_t, not int.
7024 This avoids an unnecessary limitation on 64-bit machines, which
7025 caused (substring ...) to crash on large vectors (Bug#8344).
7026 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7027 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7028 All variadic functions and their callers changed accordingly.
7029 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7030 * data.c (arith_driver, float_arith_driver): Likewise.
7031 * editfns.c (general_insert_function): Likewise.
7032 * eval.c (struct backtrace.nargs, interactive_p)
7033 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7034 (funcall_lambda, mark_backtrace): Likewise.
7035 * fns.c (concat): Likewise.
7036 * frame.c (x_set_frame_parameters): Likewise.
7037 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7038 0 if not found, not -1. All callers changed.
7040 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7041 (stack_copy_size): Now size_t, not int.
7042 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7044 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7046 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7047 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7048 All callers changed.
7050 * lisp.h (multibyte_char_to_unibyte):
7051 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7052 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7053 * character.h (CHAR_TO_BYTE8):
7054 * cmds.c (internal_self_insert):
7055 * editfns.c (general_insert_function):
7056 * keymap.c (push_key_description):
7057 * search.c (Freplace_match):
7058 * xdisp.c (message_dolog, set_message_1): All callers changed.
7060 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7062 * keyboard.c (safe_run_hook_funcall): New function.
7063 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7064 don't set the hook to nil, but remove the offending function instead.
7065 (Qcommand_hook_internal): Remove, unused.
7066 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7067 Vcommand_hook_internal.
7069 * eval.c (enum run_hooks_condition): Remove.
7070 (funcall_nil, funcall_not): New functions.
7071 (run_hook_with_args): Call each function through a `funcall' argument.
7072 Remove `cond' argument, now redundant.
7073 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7074 (Frun_hook_with_args_until_failure): Adjust accordingly.
7075 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7077 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7079 * dispextern.h (string_buffer_position): Remove declaration.
7081 * print.c (strout): Remove parameter `multibyte', unused since
7082 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7084 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7085 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7086 All callers changed.
7088 * w32.c (_wsa_errlist): Use braces for struct initializers.
7090 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7091 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7092 All callers changed.
7093 (string_buffer_position): Likewise. Also, make static (it's never
7094 used outside xdisp.c).
7095 (cursor_row_p): Remove parameter `w', unused since
7096 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7097 (decode_mode_spec): Remove parameter `precision', introduced during
7098 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7099 All callers changed.
7101 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7103 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7105 2011-03-27 Anders Lindgren <andlind@gmail.com>
7107 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7108 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7109 (ns_update_auto_hide_menu_bar): New functions.
7110 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7111 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7112 ns_constrain_all_frames.
7113 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7114 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7116 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7118 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7120 2011-03-27 Glenn Morris <rgm@gnu.org>
7122 * syssignal.h: Replace RETSIGTYPE with void.
7123 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7124 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7125 Replace SIGTYPE with void everywhere.
7126 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7127 * s/template.h (SIGTYPE): Remove commented out definition.
7129 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7131 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7132 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7134 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7136 * w32.c (read_unc_volume): Use parameter `henum', instead of
7137 global variable `wget_enum_handle'.
7139 * keymap.c (describe_vector): Remove parameters `indices' and
7140 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7141 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7143 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7145 * keyboard.c (timer_check): Remove parameter `do_it_now',
7146 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7147 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7148 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7150 * keyboard.c (read_char):
7151 * w32menu.c (w32_menu_display_help):
7152 * xmenu.c (show_help_event, menu_help_callback):
7153 Adjust calls to `show_help_echo'.
7155 * gtkutil.c (xg_maybe_add_timer):
7156 * keyboard.c (readable_events):
7157 * process.c (wait_reading_process_output):
7158 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7160 * insdel.c (adjust_markers_gap_motion):
7161 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7162 (gap_left, gap_right): Don't call it.
7164 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7166 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7167 incurred during fontification.
7169 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7171 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7172 (DEFVAR_PER_BUFFER): Don't pass it.
7174 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7175 (scrolling_window): Don't pass it.
7177 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7179 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7181 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7183 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7184 of variables specific to SELinux and computation of `encoded_absname'.
7186 * image.c (XPutPixel): Remove unused variable `height'.
7188 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7190 * unexw32.c (get_section_info): Remove unused variable `section'.
7192 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7193 (system_process_attributes): Remove unused variable `sess'.
7194 (sys_read): Remove unused variable `err'.
7196 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7197 (w32_wnd_proc): Remove unused variable `isdead'.
7198 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7199 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7200 (x_create_tip_frame): Remove unused variable `tem'.
7202 * w32inevt.c (w32_console_read_socket):
7203 Remove unused variable `no_events'.
7205 * w32term.c (x_draw_composite_glyph_string_foreground):
7206 Remove unused variable `width'.
7208 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7210 * w32term.c (x_set_glyph_string_clipping):
7211 Don't pass uninitialized region to CombineRgn.
7213 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7215 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7216 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7217 (Fx_close_connection): Remove unused variable `i'.
7219 * w32font.c (w32font_draw): Return number of glyphs.
7220 (w32font_open_internal): Remove unused variable `i'.
7221 (w32font_driver): Add missing initializer.
7223 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7224 (fill_in_menu): Remove unused variable `items_added'.
7226 * w32term.c (last_mouse_press_frame): Remove static global variable.
7227 (w32_clip_to_row): Remove unused variable `f'.
7228 (x_delete_terminal): Remove unused variable `i'.
7230 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7231 (NOTHING): Remove unused static global variable.
7232 (uniscribe_check_otf): Remove unused variable `table'.
7233 (uniscribe_font_driver): Add missing initializers.
7235 2011-03-23 Julien Danjou <julien@danjou.info>
7237 * term.c (Fsuspend_tty, Fresume_tty):
7238 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7239 * window.c (temp_output_buffer_show):
7240 * insdel.c (signal_before_change):
7241 * frame.c (Fhandle_switch_frame):
7242 * fileio.c (Fdo_auto_save):
7243 * emacs.c (Fkill_emacs):
7244 * editfns.c (save_excursion_restore):
7245 * cmds.c (internal_self_insert):
7246 * callint.c (Fcall_interactively):
7247 * buffer.c (Fkill_all_local_variables):
7248 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7250 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7251 unconditionnaly since it does the check itself.
7253 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7255 Fix more problems found by GCC 4.5.2's static checks.
7257 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7258 the first time through the loop, since we know p0 < p1 then.
7259 This also avoids a gcc -Wstrict-overflow warning.
7261 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7262 leading to a memory leak, possible in functions like
7263 load_charset_map_from_file that can allocate an unbounded number
7264 of objects (Bug#8318).
7266 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7267 that could (at least in theory) be that large.
7269 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7270 This is less likely to overflow, and avoids undefined behavior if
7271 overflow does occur. All callers changed. Use strtoul to scan
7272 for the unsigned long integer.
7273 (pint2hrstr): Simplify and tune code slightly.
7274 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7276 * scroll.c (do_scrolling): Work around GCC bug 48228.
7277 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7279 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7280 This also avoids a warning with gcc -Wstrict-overflow.
7281 (validate_x_resource_name): Simplify count usage.
7282 This also avoids a warning with gcc -Wstrict-overflow.
7284 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7287 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7289 * process.c (Fmake_network_process): Use socklen_t, not int,
7290 where POSIX says socklen_t is required in portable programs.
7291 This fixes a porting bug on hosts like 64-bit HP-UX, where
7292 socklen_t is wider than int (Bug#8277).
7293 (Fmake_network_process, server_accept_connection):
7294 (wait_reading_process_output, read_process_output):
7297 * process.c: Rename or move locals to avoid shadowing.
7298 (list_processes_1, Fmake_network_process):
7299 (read_process_output_error_handler, exec_sentinel_error_handler):
7300 Rename or move locals.
7301 (Fmake_network_process): Define label "retry_connect" only if needed.
7302 (Fnetwork_interface_info): Fix pointer signedness.
7303 (process_send_signal): Add cast to avoid pointer signedness problem.
7304 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7305 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7307 Make tparam.h and terminfo.c consistent.
7308 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7309 Include tparam.h instead, since it declares them.
7310 * cm.h (PC): Remove extern decl; tparam.h now does this.
7311 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7312 * terminfo.c: Include tparam.h, to check interfaces.
7313 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7314 (tparam): Adjust signature to match interface in tparam.h;
7315 this removes some undefined behavior. Check that outstring and len
7316 are zero, which they always are with Emacs.
7317 * tparam.h (PC, BC, UP): New extern decls.
7319 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7320 (xftfont_open): Rename locals to avoid shadowing.
7322 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7323 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7324 (OTF_TAG_SYM): Omit macro if not needed.
7325 (ftfont_list): Remove unused local.
7326 (get_adstyle_property, ftfont_pattern_entity):
7327 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7328 Rename locals to avoid shadowing.
7330 * xfont.c (xfont_list_family): Mark var as initialized.
7332 * xml.c (make_dom): Now static.
7334 * composite.c (composition_compute_stop_pos): Rename local to
7336 (composition_reseat_it): Remove unused locals.
7337 (find_automatic_composition, composition_adjust_point): Likewise.
7338 (composition_update_it): Mark var as initialized.
7339 (find_automatic_composition): Mark vars as initialized,
7340 with a FIXME (Bug#8290).
7342 character.h: Rename locals to avoid shadowing.
7343 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7344 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7345 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7346 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7349 * textprop.c (property_change_between_p): Remove; unused.
7351 * intervals.c (interval_start_pos): Now static.
7353 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7355 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7356 Rename locals to avoid shadowing.
7358 * sound.c (wav_play, au_play, Fplay_sound_internal):
7359 Fix pointer signedness.
7360 (alsa_choose_format): Remove unused local var.
7361 (wav_play): Initialize a variable to 0, to prevent undefined
7362 behavior (Bug#8278).
7364 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7366 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7368 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7369 clobbering (Bug#8298).
7370 * sysdep.c (sys_subshell): Likewise.
7371 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7373 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7374 This should get cleaned up, so that child_setup has the
7375 same signature on all platforms.
7377 * callproc.c (call_process_cleanup): Now static.
7378 (relocate_fd): Rename locals to avoid shadowing.
7380 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7382 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7383 not to be necessary, and produces flickering.
7385 2011-03-20 Glenn Morris <rgm@gnu.org>
7387 * config.in: Remove file.
7389 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7391 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7392 are now in src/globals.h.
7393 (syms_of_minibuf): Remove spurious & from previous change.
7395 2011-03-20 Leo <sdl.web@gmail.com>
7397 * minibuf.c (completing-read-function): New variable.
7398 (completing-read-default): Rename from completing-read.
7399 (completing-read): Call completing-read-function.
7401 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7403 * xfaces.c (Fx_load_color_file):
7404 Read color file from absolute filename (bug#8250).
7406 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7408 * makefile.w32-in: Update dependencies.
7410 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7412 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7414 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7416 Fix more problems found by GCC 4.5.2's static checks.
7418 * process.c (make_serial_process_unwind, send_process_trap):
7419 (sigchld_handler): Now static.
7421 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7422 That way, the code declares only the vars that it needs.
7423 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7424 * s/cygwin.h (PTY_ITERATION): Likewise.
7425 * s/darwin.h (PTY_ITERATION): Likewise.
7426 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7428 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7429 * process.c (allocate_pty): Don't declare stb unless it's needed.
7431 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7432 (CONSTANTLIM): Remove; unused.
7433 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7434 Define only if needed.
7436 * unexelf.c (unexec): Name an expression,
7437 to avoid gcc -Wbad-function-cast warning.
7438 Use a different way to cause a compilation error if anyone uses
7439 n rather than nn, a way that does not involve shadowing.
7440 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7442 * deps.mk (unexalpha.o): Remove; unused.
7444 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7445 * unexec.h: New file.
7446 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7447 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7449 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7450 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7451 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7452 Change as necessary to match prototype in unexec.h.
7454 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7456 (back_comment, skip_chars): Mark vars as initialized.
7458 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7459 Rename locals to avoid shadowing.
7461 * lread.c (read1): Rewrite so as not to use empty "else".
7462 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7464 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7466 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7467 warning when compiling print.c.
7469 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7470 instead of using an uninitialized var.
7471 (font_sort_entities): Mark var as initialized.
7473 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7475 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7476 pointers to constants.
7477 (font_parse_fcname): Remove unused vars.
7478 (font_delete_unmatched): Now static.
7479 (font_get_spec): Remove; unused.
7480 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7481 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7482 Rename or move locals to avoid shadowing.
7484 * fns.c (require_nesting_list, require_unwind): Now static.
7485 (Ffillarray): Rename locals to avoid shadowing.
7487 * floatfns.c (domain_error2): Define only if needed.
7488 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7490 * alloc.c (mark_backtrace): Move decl from here ...
7491 * lisp.h: ... to here, so that it can be checked.
7493 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7494 (Fdefvar): Rewrite so as not to use empty "else".
7495 (lisp_indirect_variable): Name an expression,
7496 to avoid gcc -Wbad-function-cast warning.
7497 (Fdefvar): Rename locals to avoid shadowing.
7499 * callint.c (quotify_arg, quotify_args): Now static.
7500 (Fcall_interactively): Rename locals to avoid shadowing.
7501 Use const pointer when appropriate.
7503 * lisp.h (get_system_name, get_operating_system_release):
7504 Move decls here, to check interfaces.
7505 * process.c (get_operating_system_release): Move decl to lisp.h.
7506 * xrdb.c (get_system_name): Likewise.
7507 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7508 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7509 some of which prompt warnings from gcc -Wbad-function-cast.
7510 (Fformat_time_string, Fencode_time, Finsert_char):
7511 (Ftranslate_region_internal, Fformat):
7512 Rename or remove local vars to avoid shadowing.
7513 (Ftranslate_region_internal): Mark var as initialized.
7515 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7518 * lisp.h (eassert): Check that the argument compiles, even if
7519 ENABLE_CHECKING is not defined.
7521 * data.c (Findirect_variable): Name an expression, to avoid
7522 gcc -Wbad-function-cast warning.
7523 (default_value, arithcompare, arith_driver, arith_error): Now static.
7524 (store_symval_forwarding): Rename local to avoid shadowing.
7525 (Fmake_variable_buffer_local, Fmake_local_variable):
7526 Mark variables as initialized.
7527 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7529 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7530 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7531 Rename locals to avoid shadowing.
7532 (mark_stack): Move local variables into the #ifdef region where
7534 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7535 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7537 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7538 (GC_STRING_CHARS): Remove; not used.
7539 (Fmemory_limit): Cast sbrk's returned value to char *.
7541 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7542 avoids undefined behavior in theory.
7544 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7546 Use functions, not macros, for up- and down-casing (Bug#8254).
7547 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7548 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7549 to use the following functions instead of these macros.
7550 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7551 EMACS_INT, since callers assume the returned value fits in int.
7552 (upcase1): Likewise, for UPCASE_TABLE.
7553 (uppercasep, lowercasep, upcase): New static inline functions.
7554 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7555 the race-condition problem in the old DOWNCASE.
7557 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7558 Rename locals to avoid shadowing.
7559 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7560 (regex_compile, re_search_2, re_match_2_internal):
7561 Remove unused local vars.
7562 (FREE_VAR): Rewrite so as not to use empty "else",
7563 which gcc can warn about.
7564 (regex_compile, re_match_2_internal): Mark locals as initialized.
7565 (RETALLOC_IF): Define only if needed.
7566 (WORDCHAR_P): Likewise. This one is never needed, but is used
7567 only in a comment talking about a compiler bug, so put inside
7568 the #if 0 of that comment.
7569 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7570 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7573 * search.c (boyer_moore): Rename locals to avoid shadowing.
7574 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7575 (PREV_CHAR_BOUNDARY): Likewise.
7577 * search.c (simple_search): Remove unused var.
7579 * dired.c (compile_pattern): Move decl from here ...
7580 * lisp.h: ... to here, so that it can be checked.
7581 (struct re_registers): New forward decl.
7583 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7585 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7587 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7588 Rename locals to avoid shadowing.
7589 (Fvertical_motion): Mark locals as initialized.
7591 * casefiddle.c (casify_object, casify_region): Now static.
7592 (casify_region): Mark local as initialized.
7594 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7596 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7597 New macros, so that the caller can use some names other than
7598 gcpro1, gcpro2, etc.
7599 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7601 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7602 argument, for consistency with GCPRO2_VAR, etc: it is now the
7603 prefix of the variable, not the variable itself. All uses
7605 * dired.c (directory_files_internal, file_name_completion):
7606 Rename locals to avoid shadowing.
7608 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7609 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7610 dired.c's scmp function, had undefined behavior.
7611 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7612 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7613 * buffer.h: ... to here, because these macros use current_buffer,
7614 and the new implementation with inline functions needs to have
7615 current_buffer in scope now, rather than later when the macros
7617 (downcase, upcase1): New static inline functions.
7618 (DOWNCASE, UPCASE1): Reimplement using these functions.
7619 This avoids undefined behavior in expressions like
7620 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7621 from race conditions in accessing the global variables
7622 case_temp1 and case_temp2.
7623 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7624 * lisp.h (case_temp1, case_temp2): Remove their decls.
7625 * character.h (ASCII_CHAR_P): Move from here ...
7626 * lisp.h: ... to here, so that the inline functions mentioned
7629 * dired.c (directory_files_internal_unwind): Now static.
7631 * fileio.c (file_name_as_directory, directory_file_name):
7632 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7634 (file_name_as_directory): Use const pointers when appropriate.
7635 (Fexpand_file_name): Likewise. In particular, newdir might
7636 point at constant storage, so make it a const pointer.
7637 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7638 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7640 (Fset_file_times, Finsert_file_contents, auto_save_error):
7641 Rename locals to avoid shadowing.
7643 * minibuf.c (choose_minibuf_frame_1): Now static.
7644 (Ftry_completion, Fall_completions): Rename or remove locals
7647 * marker.c (bytepos_to_charpos): Remove; unused.
7649 * lisp.h (verify_bytepos, count_markers): New decls,
7650 so that gcc does not warn that these functions aren't declared.
7652 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7653 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7654 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7655 (copy_text): Remove unused local var.
7657 * filelock.c (within_one_second): Now static.
7658 (lock_file_1): Rename local to avoid shadowing.
7660 * buffer.c (fix_overlays_before): Mark locals as initialized.
7661 (fix_start_end_in_overlays): Likewise. This function should be
7662 simplified by using pointers-to-pointers, but that's a different
7664 (switch_to_buffer_1): Now static.
7665 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7666 (report_overlay_modification): Rename locals to avoid shadowing.
7668 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7669 Fix pointer signedness issue.
7670 (sys_subshell): Mark local as volatile if checking for lint,
7671 to suppress a gcc -Wclobbered warning that does not seem to be right.
7672 (MAXPATHLEN): Define only if needed.
7674 * process.c (serial_open, serial_configure): Move decls from here ...
7675 * systty.h: ... to here, so that they can be checked.
7677 * fns.c (get_random, seed_random): Move extern decls from here ...
7678 * lisp.h: ... to here, so that they can be checked.
7680 * sysdep.c (reset_io): Now static.
7681 (wait_for_termination_signal): Remove; unused.
7683 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7684 (copy_keymap_item, append_key, push_text_char_description):
7686 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7687 (DENSE_TABLE_SIZE): Remove; unused.
7688 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7689 (describe_map_tree):
7690 Rename locals to avoid shadowing.
7692 * keyboard.c: Declare functions static if they are not used elsewhere.
7693 (echo_char, echo_dash, cmd_error, top_level_2):
7694 (poll_for_input, handle_async_input): Now static.
7695 (read_char, kbd_buffer_get_event, make_lispy_position):
7696 (make_lispy_event, make_lispy_movement, apply_modifiers):
7697 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7698 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7699 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7700 (read_key_sequence, read_char): Mark locals as initialized.
7701 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7703 * keyboard.h (make_ctrl_char): New decl.
7704 (mark_kboards): Move decl here ...
7705 * alloc.c (mark_kboards): ... from here.
7707 * lisp.h (force_auto_save_soon): New decl.
7709 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7710 (DEFINE_DUMMY_FUNCTION): New macro.
7711 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7713 (main): Add casts to avoid warnings
7714 if GCC considers string literals to be constants.
7716 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7718 * dbusbind.c: Pointer signedness fixes.
7719 (xd_signature, xd_append_arg, xd_initialize):
7720 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7721 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7722 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7723 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7725 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7726 if GCC considers string literals to be constants.
7727 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7729 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7731 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7732 (print_preprocess, print_object): New macro to fix last change.
7734 * print.c (print_preprocess): Don't forget font objects.
7736 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7738 * emacs.c (USAGE3): Doc fixes.
7740 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7742 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7745 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7747 * lisp.h (VWindow_system, Qfile_name_history):
7748 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7749 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7750 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7752 * w32select.c: Don't #include "keyboard.h".
7753 (run_protected): Add extern declaration for waiting_for_input.
7755 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7756 * w32console.c (detect_input_pending, read_input_pending)
7757 (encode_terminal_code):
7758 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7759 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7760 (w32_system_caret_y, Qfile_name_history):
7761 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7762 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7763 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7764 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7765 * w32proc.c (Qlocal, report_file_error):
7766 * w32term.c (Vwindow_system, updating_frame):
7767 * w32uniscribe.c (initialized, uniscribe_font_driver):
7768 Remove unneeded extern declarations.
7770 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7772 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7774 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7776 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7777 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7778 These macros can no longer be used for assignment.
7780 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7781 Assign struct members directly, instead of using BUF_BEGV etc.
7782 (record_buffer_markers, fetch_buffer_markers): New functions for
7783 recording and fetching special buffer markers.
7784 (set_buffer_internal_1, set_buffer_temp): Use them.
7786 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7788 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7790 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7791 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7793 * xdisp.c (hscroll_window_tree):
7794 (reconsider_clip_changes): Use PT instead of BUF_PT.
7796 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7798 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7799 $(EMACS_ROOT)/lib/intprops.h.
7801 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7803 Fix more problems found by GCC 4.5.2's static checks.
7805 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7806 to unsigned char * to avoid compiler diagnostic.
7807 (xg_free_frame_widgets): Make it clear that a local variable is
7808 needed only if USE_GTK_TOOLTIP.
7809 (gdk_window_get_screen): Make it clear that this macro is needed
7810 only if USE_GTK_TOOLTIP.
7811 (int_gtk_range_get_value): New function, which avoids a diagnostic
7812 from gcc -Wbad-function-cast.
7813 (xg_set_toolkit_scroll_bar_thumb): Use it.
7814 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7815 diagnostic from gcc -Wbad-function-cast.
7816 (get_utf8_string, xg_get_file_with_chooser):
7817 Rename locals to avoid shadowing.
7818 (create_dialog): Move locals to avoid shadowing.
7820 * xgselect.c (xg_select): Remove unused var.
7822 * image.c (four_corners_best): Mark locals as initialized.
7823 (gif_load): Initialize transparent_p to zero (Bug#8238).
7824 Mark another local as initialized.
7825 (my_png_error, my_error_exit): Mark with NO_RETURN.
7827 * image.c (clear_image_cache): Now static.
7828 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7829 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7830 (x_edge_detection): Remove unnecessary cast that
7831 gcc -Wbad-function-cast diagnoses.
7832 (gif_load): Fix pointer signedness.
7833 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7834 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7836 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7838 Improve quality of tests for time stamp overflow.
7839 For example, without this patch (encode-time 0 0 0 1 1
7840 1152921504606846976) returns the obviously-bogus value (-948597
7841 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7842 reports time overflow. See
7843 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7844 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7845 * editfns.c: Include limits.h and intprops.h.
7846 (TIME_T_MIN, TIME_T_MAX): New macros.
7847 (time_overflow): Move earlier, to before first use.
7848 (hi_time, lo_time): New functions, for an accurate test for
7850 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7851 (Fget_internal_run_time): Don't assume time_t fits in int.
7852 (make_time): Use list2 instead of Fcons twice.
7853 (Fdecode_time): More accurate test for out-of-range times.
7854 (check_tm_member): New function.
7855 (Fencode_time): Use it, to test for out-of-range times.
7856 (lisp_time_argument): Don't rely on undefined left-shift and
7857 right-shift behavior when checking for time stamp overflow.
7859 * editfns.c (time_overflow): New function, refactoring common code.
7860 (Fformat_time_string, Fdecode_time, Fencode_time):
7861 (Fcurrent_time_string): Use it.
7863 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7864 * dired.c (make_time): Move to ...
7865 * editfns.c (make_time): ... here.
7866 * systime.h: Note the move.
7868 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7870 * fringe.c (update_window_fringes): Remove unused variables.
7872 * unexmacosx.c (copy_data_segment): Also copy __got section.
7875 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7877 * termcap.c [MSDOS]: Include "msdos.h".
7878 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7879 Constify `char *' arguments and their references according to
7880 prototypes in tparam.h.
7882 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7884 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7885 Adapt all references accordingly.
7887 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7889 2011-03-11 Tom Tromey <tromey@redhat.com>
7891 * buffer.c (syms_of_buffer): Remove obsolete comment.
7893 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7895 * termhooks.h (encode_terminal_code): Declare prototype.
7897 * msdos.c (encode_terminal_code): Don't declare prototype.
7899 * term.c (encode_terminal_code): Now external again, used by
7900 w32console.c and msdos.c.
7902 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7903 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7905 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7907 Fix some minor problems found by GCC 4.5.2's static checks.
7909 * fringe.c (update_window_fringes): Mark locals as initialized
7911 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7913 * alloc.c (mark_fringe_data): Move decl from here ...
7914 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7915 to check its interface.
7916 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7918 * fontset.c (free_realized_fontset): Now static.
7919 (Fset_fontset_font): Rename local to avoid shadowing.
7920 (fontset_font): Mark local as initialized.
7921 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7923 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7925 * xselect.c (x_disown_buffer_selections): Remove; not used.
7926 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7927 (x_own_selection, Fx_disown_selection_internal): Rename locals
7929 (x_handle_dnd_message): Remove local to avoid shadowing.
7931 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7932 so that the caller can use some name other than gcpro1.
7933 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7934 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7935 (Fx_backspace_delete_keys_p):
7936 Use them to avoid shadowing, and rename vars to avoid shadowing.
7937 (x_decode_color, x_set_name, x_window): Now static.
7938 (Fx_create_frame): Add braces to silence GCC warning.
7939 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7940 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7941 Remove unused locals.
7942 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7943 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7944 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7947 * xterm.h (x_mouse_leave): New decl.
7949 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7950 Remove unused functions.
7951 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7952 (x_calc_absolute_position): Now static.
7953 (XTread_socket): Don't define label "out" unless it's used.
7954 Don't declare local "event" unless it's used.
7955 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7956 unless they are used.
7957 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7958 (x_fatal_error_signal): Remove; not used.
7959 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7960 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7961 (x_error_catcher, x_connection_closed, x_error_handler):
7962 (x_error_quitter, xembed_send_message, x_iconify_frame):
7963 (my_log_handler): Rename locals to avoid shadowing.
7964 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7965 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7967 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7968 Rename or move locals to avoid shadowing.
7969 (tty_defined_color, merge_face_heights): Now static.
7970 (free_realized_faces_for_fontset): Remove; not used.
7971 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7972 does not deduce is never used uninitialized.
7973 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7974 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7976 * terminal.c (store_terminal_param): Now static.
7978 * xmenu.c (menu_highlight_callback): Now static.
7979 (set_frame_menubar): Remove unused local.
7980 (xmenu_show): Rename parameter to avoid shadowing.
7981 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7982 since they might point to immutable storage.
7983 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7984 since it's unused otherwise.
7986 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7987 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7988 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7989 avoids a gcc -Wuninitialized diagnostic.
7990 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7991 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7992 does not deduce are never used uninitialized.
7994 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7996 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7997 * window.c (window_loop, size_window):
7998 (run_window_configuration_change_hook, enlarge_window): Likewise.
8000 * window.c (display_buffer): Now static.
8001 (size_window): Mark variables that gcc -Wuninitialized
8002 does not deduce are never used uninitialized.
8003 * window.h (check_all_windows): New decl, to forestall
8004 gcc -Wmissing-prototypes diagnostic.
8005 * dispextern.h (bidi_dump_cached_states): Likewise.
8007 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8009 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8011 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8012 and to avoid gcc -Wuninitialized warning.
8013 (load_charset_map): Mark variables that gcc -Wuninitialized
8014 does not deduce are never used uninitialized.
8015 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8017 * coding.c (coding_set_source, coding_set_destination):
8018 Use "else { /* comment */ }" rather than "else /* comment */;"
8019 for clarity, and to avoid gcc -Wempty-body warning.
8020 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8021 a block, when the outer 'i' will do.
8022 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8023 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8024 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8025 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8026 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8027 Rename locals to avoid shadowing.
8028 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8029 * coding.c (emacs_mule_char, encode_invocation_designation):
8030 Now static, since they're not used elsewhere.
8031 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8032 (decode_coding_object, encode_coding_object, detect_coding_system):
8033 (decode_coding_emacs_mule): Mark variables that gcc
8034 -Wuninitialized does not deduce are never used uninitialized.
8035 (detect_coding_iso_2022): Initialize a local variable that might
8036 be used uninitialized. Leave a FIXME because it's not clear that
8037 this initialization is needed. (Bug#8211)
8038 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8039 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8040 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8041 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8042 Remove unused macros.
8044 * category.c (hash_get_category_set): Remove unused local var.
8045 (copy_category_table): Now static, since it's not used elsewhere.
8046 * character.c (string_count_byte8): Likewise.
8048 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8049 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8051 * chartab.c (copy_sub_char_table): Now static, since it's not used
8053 (sub_char_table_ref_and_range, char_table_ref_and_range):
8054 Rename locals to avoid shadowing.
8055 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8057 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8058 (BIDI_BOB): Remove unused macro.
8060 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8061 deduce are never used uninitialized.
8062 * term.c (encode_terminal_code): Likewise.
8064 * term.c (encode_terminal_code): Now static. Remove unused local.
8066 * tparam.h: New file.
8067 * term.c, tparam.h: Include it.
8068 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8069 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8070 Move these decls to tparam.h, and make them agree with what
8071 is actually in tparam.c. The previous trick of using incompatible
8072 decls in different modules does not conform to the C standard.
8073 All callers of tparam changed to use tparam's actual API.
8074 * tparam.c (tparam1, tparam, tgoto):
8075 Use const pointers where appropriate.
8077 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8078 * cm.h (struct cm): Likewise.
8079 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8080 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8081 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8082 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8083 (turn_on_face, init_tty): Likewise.
8084 * termchar.h (struct tty_display_info): Likewise.
8086 * term.c (term_mouse_position): Rename local to avoid shadowing.
8088 * alloc.c (mark_ttys): Move decl from here ...
8089 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8091 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8093 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8095 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8097 * search.c (compile_pattern_1): Remove argument regp, unused since
8098 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8099 (compile_pattern): Don't pass it.
8101 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8103 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8104 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8106 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8108 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8110 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8111 gdk_window_get_screen, gdk_window_get_geometry,
8112 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8113 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8114 (xg_get_pixbuf_from_pixmap): New function.
8115 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8116 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8117 Call xg_get_pixbuf_from_pixmap instead of
8118 gdk_pixbuf_get_from_drawable.
8119 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8120 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8121 (xg_check_special_colors): Use GtkStyleContext and its functions
8123 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8124 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8125 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8126 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8127 Call gtk_widget_get_preferred_size.
8128 (xg_frame_resized): gdk_window_get_geometry only takes 5
8130 (xg_win_to_widget, xg_event_is_for_menubar):
8131 Call gdk_x11_window_lookup_for_display.
8132 (xg_set_widget_bg): New function.
8133 (delete_cb): New function.
8134 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8135 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8136 (xg_set_background_color): Call xg_set_widget_bg.
8137 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8138 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8139 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8140 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8142 (update_frame_tool_bar): Call gtk_widget_hide.
8143 (xg_initialize): Use GDK_KEY_g.
8145 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8147 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8149 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8150 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8151 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8153 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8155 * w32xfns.c (select_palette): Check success of RealizePalette against
8156 GDI_ERROR, not zero.
8158 See ChangeLog.11 for earlier changes.
8164 Copyright (C) 2011 Free Software Foundation, Inc.
8166 This file is part of GNU Emacs.
8168 GNU Emacs is free software: you can redistribute it and/or modify
8169 it under the terms of the GNU General Public License as published by
8170 the Free Software Foundation, either version 3 of the License, or
8171 (at your option) any later version.
8173 GNU Emacs is distributed in the hope that it will be useful,
8174 but WITHOUT ANY WARRANTY; without even the implied warranty of
8175 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8176 GNU General Public License for more details.
8178 You should have received a copy of the GNU General Public License
8179 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.