1 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
4 This how ASET and AREF are supposed to work, and makes
5 it easier to think about future improvements. See
6 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
7 * charset.h (set_charset_attr): New function.
8 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
9 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
10 (aref_addr): New function. All uses of &AREF(...) changed.
11 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
12 (set_hash_index): New functions. All lvalue-style uses of
13 HASH_KEY etc. changed.
14 * keyboard.c (set_prop): New function. All lvalue-style uses
17 2012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
19 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
20 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
21 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
22 * nsfns.m (ns_set_name_as_filename): Likewise.
23 * nsmenu.m (ns_update_menubar): Likewise.
24 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
26 2012-08-01 Eli Zaretskii <eliz@gnu.org>
28 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
29 Adapt to latest changes in field names of the corresponding Lisp
32 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
34 2012-08-01 Glenn Morris <rgm@gnu.org>
36 * s/msdos.h: Remove file.
37 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
38 * Makefile.in (S_FILE): Remove.
39 (config_h): Remove S_FILE.
41 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
43 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
44 Remove; moved to nt/config.nt.
46 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
48 Use INTERNAL_FIELD for conses and overlays.
49 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
50 Remove obsolete comment.
52 (struct Lisp_Overlay): Use INTERNAL_FIELD.
53 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
55 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
57 Use INTERNAL_FIELD for symbols.
58 * lisp.h (SVAR): New macro. Adjust users.
59 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
60 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
62 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
64 Use INTERNAL_FIELD for processes.
65 * process.h (PVAR): New macro. Adjust style.
66 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
67 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
69 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
71 Use INTERNAL_FIELD for windows.
72 * window.h (WVAR): New macro.
73 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
74 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
75 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
76 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
77 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
78 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
80 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
82 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
84 2012-08-01 Glenn Morris <rgm@gnu.org>
86 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
89 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
91 * makefile.w32-in (CONFIG_H): Update dependencies.
92 (CONF_POST_H): New macro.
94 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
96 2012-07-31 Glenn Morris <rgm@gnu.org>
98 * Makefile.in (S_FILE): No longer set by configure.
100 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
102 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
104 * process.h (NULL_DEVICE):
106 * editfns.c (USER_FULL_NAME): Let configure set them.
108 * s/README, s/template.h: Remove files.
110 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
112 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
113 Move to configure.ac.
115 2012-07-31 Eli Zaretskii <eliz@gnu.org>
117 * .gdbinit (xframe): Adapt to introduction of FVAR and the
118 resulting renaming of 'struct frame' members.
120 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
122 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
123 after introduction of FVAR.
125 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
127 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
129 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
130 instead of compositeToPoint.
131 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
133 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
135 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
137 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
138 * lisp.h (INTERNAL_FIELD): New macro.
139 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
140 (BVAR): Change to use INTERNAL_FIELD.
141 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
142 (KVAR): Change to use INTERNAL_FIELD.
143 * frame.h (FVAR): New macro.
144 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
145 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
146 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
147 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
148 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
150 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
152 Miscellaneous fixes for non-default X toolkits.
153 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
154 * xterm.c (x_frame_of_widget): Remove redundant prototype.
155 Move under #ifdef USE_LUCID.
156 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
157 definition and usage to avoid warnings.
159 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
161 * nsterm.m (openFiles): Fix previous checkin.
163 2012-07-31 Paul Eggert <eggert@cs.ucla.edu>
165 * indent.c (compute_motion): Remove unused local.
167 2012-07-31 Glenn Morris <rgm@gnu.org>
169 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
171 * conf_post.h [USG5_4]:
172 Move remaining contents of s/usg5-4-common.h here.
173 * s/usg5-4-common.h: Remove file.
175 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
176 * s/irix6-5.h: Remove file.
178 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
179 * s/darwin.h: Remove file.
181 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
182 * s/hpux10-20.h: Remove file, which is now empty.
184 2012-07-30 Glenn Morris <rgm@gnu.org>
186 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
187 * Makefile.in (config_h): Add conf_post.h.
188 * makefile.w32-in (CONFIG_H): Add conf_post.h.
190 2012-07-30 Jan Djärv <jan.h.d@swipnet.se>
192 * nsterm.m (ns_do_open_file): New variable.
193 (ns_term_init): Set ns_do_open_file to YES after run returns.
194 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
195 files only if ns_do_open_file.
197 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
199 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
200 This no-op macro hasn't been needed for many years.
201 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
203 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
204 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
205 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
206 gdb_make_enums_visible.
207 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
208 (DIRECTORY_SEP): Now a constant, not a macro.
210 2012-07-30 Eli Zaretskii <eliz@gnu.org>
212 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
213 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
215 * w32term.c <w32_keyboard_codepage>: Renamed from
216 keyboard_codepage and now external. All users changed.
218 * w32term.h: Add declaration of w32_keyboard_codepage.
220 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
221 the codepage to translate keys to Unicode. If this argument is
222 -1, use the value returned by GetConsoleCP. All callers changed.
224 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
226 Update .PHONY listings in makefiles.
227 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
228 bootstrap-clean, distclean, maintainer-clean, versioclean,
231 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
232 This is a bit clearer. Fix some commentary typos.
234 2012-07-30 Glenn Morris <rgm@gnu.org>
236 * s/netbsd.h: Let configure include signal.h if needed.
237 Remove file, which is now empty.
239 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
240 Let configure set them.
241 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
242 No more need to undefine.
244 2012-07-30 Andreas Schwab <schwab@linux-m68k.org>
246 * keymap.c (Fkey_description): Don't remove 0x80 bit from
247 non-single-byte char when adding meta modifier. (Bug#12090)
249 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
251 Convert safe_call to use variable number of arguments.
252 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
253 (safe_call2): Fix comment.
254 * lisp.h (safe_call): Adjust prototype.
255 * coding.c (encode_coding_object): Change to use safe_call2.
256 * xfaces.c (merge_face_heights): Change to use safe_call1.
258 2012-07-30 Glenn Morris <rgm@gnu.org>
260 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
261 does that unconditionally. Remove file, which is now empty.
263 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
266 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
268 Export to GDB most of lisp.h's remaining object-like macros.
269 * lisp.h (min, max): Move earlier, because they're used earlier now.
270 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
271 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
272 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
273 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
274 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
275 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
276 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
277 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
278 Now constants, for GDB. They need not be macros.
279 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
280 Now constants, for GDB, as well as macros, for static initializers.
281 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
282 Move to after the definition of struct Lisp_Char_Table,
283 since the former now needs that type defined.
284 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
285 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
286 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
287 New enums, for gdb_make_enums_visible.
288 (GLYPH_MODE_LINE_FACE): Remove; unused.
289 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
290 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
291 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
292 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
293 enum maxargs, enum MAX_ALLOCA.
294 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
295 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
296 no longer needed, now that they are done in lisp.h.
298 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
300 Cleanup string bytes checking.
301 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
302 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
303 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
304 (check_sblock, compact_small_strings): Simplify.
306 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
308 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
309 These macros are confusing and no longer need to be defined, as
310 the enum values now suffice. All uses replaced with definiens.
311 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
313 2012-07-29 Juanma Barranquero <lekktu@gmail.com>
315 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
316 ($(BLD)/w32console.$(O)): Update dependencies.
318 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
320 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
321 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
323 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
325 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
327 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
328 setting sitelisp (Bug#12010).
330 2012-07-29 Eli Zaretskii <eliz@gnu.org>
332 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
334 * w32heap.c (cache_system_info):
335 * w32.c (sys_rename):
336 * w32proc.c (find_child_console, sys_kill): All users changed.
338 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
340 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
342 2012-07-29 Eli Zaretskii <eliz@gnu.org>
344 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
346 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
348 Cleanup statistics calculation in Fgarbage_collect.
349 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
350 zombies percentage calculation. Simplify elapsed time calculation.
352 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
354 Generalize marker debugging code under MARKER_DEBUG and use eassert.
355 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
356 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
357 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
358 (replace_range, replace_range_2, del_range_2): Change to eassert.
359 * marker.c (byte_char_debug_check): Adjust style.
361 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
363 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
364 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
365 long-ago-commented-out code that talks about "WIN32".
366 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
369 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
371 Use Gnulib stdalign module (Bug#9772, Bug#9960).
372 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
373 Simplify by using alignof.
374 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
375 * lisp.h: Include <stdalign.h>.
376 (GCALIGNMENT): New macro and constant.
377 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
378 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
379 (stdalign): New macro, if not already defined.
381 2012-07-28 Eli Zaretskii <eliz@gnu.org>
383 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
384 * w32inevt.c: Include w32inevt.h.
385 (w32_read_console_input): New inline function, calls either
386 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
387 w32_console_unicode_input.
388 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
389 (w32_kbd_patch_key, key_event): Use the codepage returned by
390 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
391 (key_event): use uChar.UnicodeChar only if
392 w32_console_unicode_input is non-zero.
394 * w32console.c: Include w32heap.h.
395 <w32_console_unicode_input>: New global variable.
396 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
397 family of Windows, zero otherwise.
399 * w32inevt.h: Declare w32_console_unicode_input.
401 * xdisp.c (init_iterator): Don't reference tip_frame in a build
402 --without-x. (Bug#11742)
404 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
406 Adjust GDB to reflect pvec_type changes (Bug#12036).
407 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
408 2012-07-04 changes to pseudovector representation. Problem
409 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
411 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
413 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
415 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
417 2012-07-27 Eli Zaretskii <eliz@gnu.org>
419 * alloc.c (listn): Fix the order the arguments are consed onto the
422 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
423 enumeration constants, as PURE and HEAP are too general, and clash
424 with other headers and sources, such as gmalloc.c and the
425 MS-Windows system headers. All users changed.
427 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
429 Revert last save_excursion_save and save_excursion_restore changes.
430 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
431 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
433 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
435 Fix recently-introduced typos in Windows port.
436 Reported by Martin Rudalics <rudalics@gmx.at>.
437 * w32.c (init_environment): Replace comma with semicolon.
438 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
440 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
442 Improve GDB symbol export (Bug#12036).
443 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
444 arms of an 'if', not using conditional expressions; otherwise GDB
445 complains about the types in the unevaluated arm when the argument
446 is an integer literal.
447 (xgetint): Simplify expression.
448 * alloc.c (gdb_make_enums_visible): New constant. This ports to
449 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
450 Zaretskii in <http://bugs.gnu.org/12036#13>.
451 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
452 needed now that we have gdb_make_enums_visible.
453 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
454 (enum enum_USE_LSB_TAG):
455 New enum types, packaging up enums that need to be exported to GDB.
457 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
459 Utility function to make a list from specified amount of objects.
460 * lisp.h (enum constype): New datatype.
461 (listn): New prototype.
462 * alloc.c (listn): New function.
463 (Fmemory_use_count, syms_of_alloc): Use it.
464 * buffer.c (syms_of_buffer): Likewise.
465 * callint.c (syms_of_callint): Likewise.
466 * charset.c (define_charset_internal): Likewise.
467 * coding.c (syms_of_coding): Likewise.
468 * keymap.c (syms_of_keymap): Likewise.
469 * search.c (syms_of_search): Likewise.
470 * syntax.c (syms_of_syntax): Likewise.
471 * w32.c (init_environment): Likewise.
472 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
473 * xdisp.c (syms_of_xdisp): Likewise.
474 * xfns.c (syms_of_xfns): Likewise.
476 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
478 Fast save_excursion_save and save_excursion_restore.
479 * lisp.h (struct Lisp_Excursion): New data type.
480 (PVEC_EXCURSION): New pseudovector type.
481 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
482 to deal with it. Adjust comments.
483 (init_marker, attach_marker): New prototype.
484 (unchain_marker): Adjust prototype.
485 * marker.c (attach_marker): Change to global.
486 (init_marker): New function.
487 * alloc.c (Fmake_marker, build_marker): Use it.
488 (build_marker): More easserts.
489 (mark_object): Handle struct Lisp_Excursion.
490 * editfns.c (save_excursion_save, save_excursion_restore):
491 Reimplement to use struct Lisp_Excursion. Add comments.
493 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
495 Fix export of symbols to GDB (Bug#12036).
496 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
497 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
498 emacs.c, as this is a more-suitable home. Had this been done earlier
499 the fix for 12036 would have avoided some of the problems noted in
500 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
501 would have been more obvious.
502 * emacs.c: Do not include <verify.h>; no longer needed.
503 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
504 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
505 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
506 Remove; now done in lisp.h.
507 * lisp.h (PUBLISH_TO_GDB): New macro.
508 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
509 (DATA_SEG_BITS): Use it.
510 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
511 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
512 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
513 not be usable in #if. This simplifies things.
515 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
517 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
519 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
521 Simplify export of symbols to GDB (Bug#12036).
522 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
523 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
524 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
525 Adjust to changes in lisp.h and emacs.c, by using
526 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
527 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
528 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
529 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
530 instead of gdb_valbits.
531 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
532 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
533 instead of gdb_array_mark_flag.
534 (xboolvector): Get size from $->size, not $->header.size.
535 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
536 (xreload, hook-run, hookpost-run): Remove.
537 * emacs.c: Include <verify.h>.
538 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
539 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
541 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
542 (gdb_USE_LSB_TAG): New enum constants.
543 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
544 Also define these as enum constants, so they're visible to GDB.
545 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
546 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
547 as constants, so they're visible to GDB.
548 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
549 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
550 Now enum constants, not macros, so they're visible to GDB.
551 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
552 more convenient now. All uses changed.
553 (VALMASK) [USE_LSB_TAG]: Also define in this case.
554 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
556 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
558 Explicitly free restriction data that are not needed anymore.
559 * editfns.c (save_restriction_restore): Free restriction data.
561 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
563 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
564 add argument, tune behavior, and adjust all callers.
566 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
568 Use typedef for EMACS_INT, EMACS_UINT.
569 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
570 than macros. This simplifies debugging in the usual case, since
571 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
572 and it allows expressions involving EMACS_INT casts.
573 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
575 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
577 * nsterm.m (ns_read_socket): Return early if there is a modal
580 2012-07-25 Martin Rudalics <rudalics@gmx.at>
582 * frame.c (Fredirect_frame_focus): In doc-string don't mention
583 that FOCUS-FRAME can be omitted.
585 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
587 Adjust buffer text indirection counters at the end of Fkill_buffer.
588 * buffer.c (Fkill_buffer): Adjust indirection counters when the
589 buffer is definitely dead. This should really fix an issue reported
590 by Christoph Scholtes again. (Bug#12007).
591 (init_buffer_once): Initialize indirection counters of
592 buffer_defaults and buffer_local_symbols (for sanity and safety).
594 2012-07-24 Eli Zaretskii <eliz@gnu.org>
596 * xdisp.c (init_iterator): Don't compute dimensions of truncation
597 and continuation glyphs on tooltip frames, leave them at zero.
598 Avoids continued lines in tooltips. (Bug#11832)
600 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
602 Simplify copy_overlay.
603 * buffer.c (copy_overlay): Simplify. Use build_marker.
604 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
606 2012-07-23 Eli Zaretskii <eliz@gnu.org>
608 * print.c (print_object): Don't crash when a frame's name is nil
609 or invalid. (Bug#12025)
611 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
612 it signals an error when a tooltip frame is being created.
614 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
616 Cleanup miscellaneous objects allocation and initialization.
617 * alloc.c (allocate_misc): Change to static. Add argument to
618 specify the subtype. Adjust comment and users.
619 (build_overlay): New function.
620 * buffer.c (copy_overlays, Fmake_overlay): Use it.
621 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
622 (allocate_misc): Remove prototype.
623 (build_overlay): Add prototype.
625 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
627 Swap buffer text indirection counters in Fbuffer_swap_text.
628 * buffer.c (Fbuffer_swap_text): Swap indirections too.
629 This avoids crash reported by Christoph Scholtes at
630 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
632 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
634 * nsmenu.m (Popdown_data): New struct.
635 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
637 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
638 (initWithContentRect): Make imgView and contentView non-static
639 and autorelease them. Also autorelease img and matrix (Bug#12005).
640 (dealloc): Remove (Bug#12005).
642 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
644 Adjust consing_since_gc when objects are explicitly freed.
645 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
646 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
647 (free_cons, free_misc): Subtract object size from consing_since_gc.
649 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
651 Simplify and cleanup markers positioning code.
652 * marker.c (attach_marker): More useful eassert.
653 (live_buffer, set_marker_internal): New function.
654 (Fset_marker, set_marker_restricted): Use set_marker_internal.
655 (set_marker_both, set_marker_restricted_both): Use live_buffer.
657 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
659 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
660 as it's limited by the amount of memory, not by INT_MAX.
662 2012-07-21 Eli Zaretskii <eliz@gnu.org>
664 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
665 in special-event-map. See the discussion at
666 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
669 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
670 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
671 Fabrice Popineau <fabrice.popineau@supelec.fr>.
673 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
675 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
676 (conversationIdentifier): Return value is NSInteger.
677 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
679 2012-07-21 Chong Yidong <cyd@gnu.org>
681 * window.c (decode_any_window): Signal an error if the window is
682 on a dead frame (Bug#11984).
684 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
686 Add indirection counting to speed up Fkill_buffer.
687 * buffer.h (struct buffer): New member.
688 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
689 (Fmake_indirect_buffer): Set indirection counter to -1, increment
690 base buffer indirection counter.
691 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
692 (Fkill_buffer): Adjust indirection counters as needed, don't walk
693 through buffer list if indirection counter is 0.
695 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
697 Extend the value returned by Fgarbage_collect with heap statistics.
698 * alloc.c (Qheap): New symbol.
699 (syms_of_alloc): DEFSYM it.
700 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
701 (Fmemory_free): Remove.
702 (syms_of_alloc): Don't defsubr it.
703 * buffer.c (Fcompact_buffer): Remove.
704 (syms_of_buffer): Don't defsubr it.
706 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
708 Make maybe_gc inline.
709 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
710 * lisp.h (consing_since_gc, gc_relative_threshold)
711 (memory_full_cons_threshold): Revert declaration.
712 (maybe_gc): Remove prototype, define as inline.
713 * alloc.c: Remove old commented-out code.
714 (consing_since_gc, gc_relative_threshold)
715 (memory_full_cons_threshold): Revert to global.
718 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
720 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
721 * lisp.h (build_unibyte_string): New function.
722 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
723 * sysdep.c, w32fns.c, xfns.c: Use it.
724 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
725 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
726 Adjust users accordingly.
727 * font.h (font_open_by_name): Adjust prototype.
729 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
731 Cleanup calls to Fgarbage_collect.
732 * lisp.h (maybe_gc): New prototype.
733 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
735 * alloc.c (maybe_gc): New function.
736 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
738 * bytecode.c (MAYBE_GC): Use maybe_gc.
739 * eval.c (eval_sub, Ffuncall): Likewise.
740 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
741 to avoid dependency from auto-save feature.
743 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
745 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
746 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
747 'for_each_per_buffer_object_at'.
748 All uses changed. It's better to use upper-case for macros that
749 cannot be implemented as functions, to give the reader a clue
750 that they're special.
752 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
754 * alloc.c (Fgarbage_collect): Tweak docstring.
756 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
758 Tweak the value returned from Fgarbage_collect again.
759 * alloc.c (Fgarbage_collect): New return value, as confirmed in
760 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
761 Adjust documentation.
762 (total_vector_bytes): Rename to total_vector_slots, adjust
764 (total_free_vector_bytes): Rename to total_free_vector_slots,
766 (Qstring_bytes, Qvector_slots): New symbols.
767 (syms_of_alloc): DEFSYM them.
769 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
771 Buffer compaction primitive which may be used from Lisp.
772 * buffer.c (compact_buffer, Fcompact_buffer): New function.
773 (syms_of_buffer): Register Fcompact_buffer.
774 * alloc.c (Fgarbage_collect): Use compact_buffer.
775 * buffer.h (compact_buffer): New prototype.
776 (struct buffer_text): New member.
778 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
780 New macro to iterate over all buffers, miscellaneous cleanups.
781 * lisp.h (all_buffers): Remove declaration.
782 * buffer.h (all_buffers): Add declaration, with comment.
783 (for_each_buffer): New macro.
784 * alloc.c (Fgarbage_collect, mark_object): Use it.
785 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
786 (init_buffer): Likewise.
787 * data.c (Fset_default): Likewise.
788 * coding.c (code_conversion_restore): Remove redundant check
790 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
792 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
794 Fix bug that created negative-length intervals.
795 * intervals.c (merge_interval_right, merge_interval_left):
796 Do not zero out this interval if it is absorbed by its children,
797 as this interval's total length doesn't change in that case. See
798 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
800 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
802 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
803 when invoking (make-bool-vector N t) and N is a positive
804 multiple of 8 -- the last 8 bits were mistakenly cleared.
806 Remove some struct layout assumptions in bool vectors.
807 * alloc.c (bool_header_size): New constant.
808 (header_size, word_size): Move earlier, as they're now used earlier.
809 Use 'word_size' in a few more places, where it's appropriate.
810 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
811 padding before the data member of a bool vector.
812 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
813 than doing the check by hand with an abort ().
815 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
817 * eval.c (Fdefvar): Don't check constants since we only set the var if
818 it's not yet defined anyway (bug#11904).
820 * lisp.h (last_undo_boundary): Declare new var.
821 * keyboard.c (command_loop_1): Set it.
822 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
823 were auto-added by the command loop (bug#11774).
825 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
827 * w32font.c (Qsymbol): Remove local definition.
828 (syms_of_w32font): Don't DEFSYM it.
830 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
832 Fix sweep_vectors to handle large bool vectors correctly.
833 * alloc.c (sweep_vectors): Account total_vector_bytes for
834 bool vectors larger than VBLOCK_BYTES_MAX.
836 2012-07-18 Chong Yidong <cyd@gnu.org>
838 * frame.c (x_set_frame_parameters): Revert bogus change introduced
839 in 2012-05-25 commit by Paul Eggert (Bug#11738).
841 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
843 Return more descriptive data from Fgarbage_collect.
844 Suggested by Stefan Monnier in
845 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
846 * alloc.c (bounded_number): New function.
847 (total_buffers, total_vectors): New variable.
848 (total_string_size): Rename to total_string_bytes, adjust users.
849 (total_vector_size): Rename to total_vector_bytes, adjust users.
850 (sweep_vectors): Account total_vectors and total_vector_bytes.
851 (Fgarbage_collect): New return value. Adjust documentation.
852 (gc_sweep): Account total_buffers.
853 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
854 (VECTOR_SIZE): Remove.
855 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
856 (Qinterval, Qmisc): New symbols.
857 (syms_of_data): Initialize them.
858 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
859 (Qcons, Qbuffer): New declarations.
861 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
863 * alloc.c (Fmemory_free): Account for memory-free's own storage.
864 Round up, not down. Improve doc.
866 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
868 Restore old code in allocate_string_data to avoid Faset breakage.
869 Reported by Julien Danjou <julien@danjou.info> in
870 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
871 * alloc.c (allocate_string_data): Restore old code with minor
872 adjustments, fix comment to explain this subtle issue.
874 2012-07-17 Eli Zaretskii <eliz@gnu.org>
876 Remove FILE_SYSTEM_CASE.
877 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
879 * fileio.c (FILE_SYSTEM_CASE): Don't define.
880 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
881 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
882 call-process-region passes it through expand-file-name.
884 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
886 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
888 Fix crash when creating indirect buffer (Bug#11917)
889 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
890 Don't handle unbound variables specially if non-zero.
891 (Fbuffer_local_variables): Pass zero.
892 (clone_per_buffer_values): Pass non-zero.
894 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
896 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
897 to make the loop interruptible.
899 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
901 * gnutls.c (emacs_gnutls_handshake): Only retry if
902 GNUTLS_E_INTERRUPTED.
904 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
906 Cleanup and convert miscellaneous checks to eassert.
907 * alloc.c (mark_interval): Fix comment, partially rephrase
908 old comment from intervals.h (see below).
909 * intervals.c (find_interval, adjust_intervals_for_insertion)
910 (delete_interval, adjust_intervals_for_deletion)
911 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
913 (adjust_intervals_for_insertion, make_new_interval):
914 Remove obsolete and unused code.
915 * intervals.h (struct interval): Remove obsolete comment.
916 * textprotp.c (erase_properties): Remove unused code.
917 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
918 (Fremove_list_of_text_properties): Convert to eassert.
920 2012-07-17 Chong Yidong <cyd@gnu.org>
922 * editfns.c (Finsert_char): Doc fix.
924 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
926 Fix previous change to make Fmemory_free always accurate.
927 * alloc.c (make_interval): Update total_free_intervals.
928 (make_float): Likewise for total_free_floats.
929 (free_cons, Fcons): Likewise for total_free_conses.
930 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
931 Likewise for total_free_vector_bytes.
932 (Fmake_symbol): Likewise for total_free_symbols.
933 (bytes_free): Remove.
935 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
937 Simple free memory accounting feature.
938 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
939 (sweep_vectors): Accumulate size of free vectors.
940 (Fgarbage_collect): Setup bytes_free.
941 (Fmemory_free): New function.
942 (syms_of_alloc): Register it.
944 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
946 Cleanup overlays checking.
947 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
948 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
949 eassert and OVERLAYP.
950 (sort_overlays): Change to use OVERLAYP.
952 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
954 * editfns.c (Finsert_char): Make it interactive, and make the
955 second arg optional. Copy interactive spec and docstring from
958 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
960 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
961 Unlike the other wrapped functions, fabs has an unspecified
964 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
966 * nsterm.m (keyDown): Interpret flags without left/right bits
967 as the left key (Bug#11670).
969 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
971 Remove empty and useless init functions.
972 * lisp.h (init_character_once, init_fns, init_image)
973 (init_filelock, init_sound): Remove prototype.
974 * character.c (init_character_once): Remove.
975 * filelock.c (init_filelock): Likewise.
976 * fns.c (init_fns): Likewise.
977 * image.c (init_image): Likewise.
978 * sound.c (init_sound): Likewise.
979 * emacs.c (main): Adjust accordingly.
981 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
983 * gtkutil.h: Tiny cleanups.
984 (use_old_gtk_file_dialog): Remove useless declaration.
985 (xg_uses_old_file_dialog): Add suggested const attribute.
987 2012-07-15 Eli Zaretskii <eliz@gnu.org>
989 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
990 (bidi_paragraph_init): Use it to limit search forward for a strong
991 directional character in abnormally large paragraphs full of
992 neutral or weak characters. (Bug#11943)
994 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
996 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
997 the toolbar (Bug#9451).
998 (xg_make_tool_item): Give the widget event box a transparent
1001 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1003 Cleanup basic allocation variables and functions.
1004 * alloc.c (ignore_warnings, init_intervals, init_float)
1005 (init_cons, init_symbol, init_marker): Remove.
1006 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1007 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1008 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1009 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1010 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1011 (staticidx, init_alloc_once, init_strings, free_ablock):
1012 Remove redundant initialization.
1013 * fns.c (init_weak_hash_tables): Remove.
1014 * lisp.h (init_weak_hash_tables): Remove prototype.
1016 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1018 Use zero_vector where appropriate.
1019 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1021 * lisp.h (zero_vector): New declaration.
1022 * font.c (null_vector): Remove.
1023 (syms_of_font): Remove initialization and staticpro.
1024 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1025 * keymap.c (Faccessible_keymaps): Likewise.
1027 2012-07-15 Leo Liu <sdl.web@gmail.com>
1029 * fringe.c: Fix typo in comments.
1031 2012-07-14 Leo Liu <sdl.web@gmail.com>
1033 * fringe.c: Add a new bitmap exclamation-mark.
1035 2012-07-14 Eli Zaretskii <eliz@gnu.org>
1037 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1039 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1040 (HAVE_MENUS): Don't define, defined by editing config.in with
1042 (GMALLOC_INHIBIT_VALLOC): Don't define.
1043 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1045 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
1047 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1049 2012-07-14 Glenn Morris <rgm@gnu.org>
1051 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1052 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1053 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1055 2012-07-13 Glenn Morris <rgm@gnu.org>
1057 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1059 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1060 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1062 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1064 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1065 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1066 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1067 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1069 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1070 as boolean expression.
1071 (x_set_window_size): Remove unused variable toolbar.
1072 (ns_get_color_default, ns_mod_to_lisp): Remove.
1073 (ns_mouse_position): Remove unused variables xchar and ychar.
1074 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1075 (ns_set_vertical_scroll_bar): Remove unused variable count.
1076 (ns_delete_terminal): Remove unused variable i.
1077 (ns_term_init): Remove unused variables r, g and b.
1078 (mouseDown): Remove unused variable window.
1079 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1080 (initFrameFromEmacs): Remove unused variable vbextra.
1081 (mouseEntered): Remove unused variables p and dpyinfo.
1082 (mouseExited): Remove unused variables p and r.
1083 (ns_define_frame_cursor, ns_clear_frame_area)
1084 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1085 (menuDown): Assign [sender tag] to variable and cast the variable.
1087 * nsterm.h (menuDown): Add id as type to argument sender.
1088 (ns_display_info_for_name): Add Lisp_Object argument.
1089 (ns_term_init): Add Lisp_Object argument.
1090 (ns_map_event_to_object): Add void argument.
1091 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1092 prototype with arguments and only declare if __OBJC__.
1093 (nxatoms_of_nsselect): Add void argument.
1094 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1095 (ns_alloc_autorelease_pool): Add void argument.
1096 (ns_release_autorelease_pool): Add void* argument.
1097 (ns_get_defaults_value): Add const char* argument.
1099 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1100 (initFromContents): Use SSDATA where appropriate.
1101 (ns_update_menubar): Add braces to ambigous if-else.
1102 (initWithTitle): Put () around assignment in if statement.
1103 (ns_menu_show): Remove unused variables window and keymap.
1104 (update_frame_tool_bar): Remove unused variable selected_p.
1105 (initWithContentRect): Remove unused variable this_cmd_name.
1107 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1109 (setXBMColor): Remove unused variable len.
1110 (setPixmapData): Put () around assignment in loop statement.
1112 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1113 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1115 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1116 around assignment in loop statement.
1117 (nsfont_open): Remove unused variable i.
1118 (nsfont_open): Remove unused variable len.
1119 (nsfont_draw): Remove unused variable cs.
1121 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1122 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1123 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1124 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1125 (Fns_font_name, Fns_perform_service)
1126 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1127 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1128 (ns_set_name): Remove unused variable view.
1129 (x_set_menu_bar_lines): Remove unused variable olines.
1130 (x_set_tool_bar_lines): Remove unused variable root_window.
1131 (Fns_list_colors): Put () around assignment in while statement.
1132 (Fns_perform_service): Remove unused variable len.
1133 (Fns_display_usable_bounds): Remove unused variable top.
1134 (syms_of_nsfns): Remove unused variable i.
1136 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1139 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
1141 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1142 and free it with DestroyExceptionInfo (Bug#11558).
1144 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
1146 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1147 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1148 Set here, not in nt/config.nt.
1150 2012-07-13 Eli Zaretskii <eliz@gnu.org>
1152 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1153 cursor overflow into the last glyph on display line when the right
1154 fringe is off. (Bug#11832)
1156 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1158 * xdisp.c (produce_special_glyphs): Now static.
1159 * dispextern.h (produce_special_glyphs): Remove decl.
1161 2012-07-13 Glenn Morris <rgm@gnu.org>
1163 * s/bsd-common.h, s/cygwin.h: Remove empty files.
1164 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1166 * s/usg5-4-common.h (USG, USG5):
1167 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1168 * s/sol2-6.h (SOLARIS2):
1169 * s/irix6-5.h (IRIX6_5):
1170 * s/hpux10-20.h (USG, USG5, HPUX):
1171 * s/gnu-linux.h (USG, GNU_LINUX):
1172 * s/freebsd.h (BSD_SYSTEM):
1173 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1174 * s/cygwin.h (CYGWIN):
1175 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1176 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1178 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
1180 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
1182 2012-07-13 Glenn Morris <rgm@gnu.org>
1184 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1186 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1188 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1189 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1191 2012-07-12 Glenn Morris <rgm@gnu.org>
1193 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
1195 * process.c (init_process_emacs): Rename from init_process.
1196 The old name is also the name of a Mach system call.
1197 * lisp.h, emacs.c: Update for this name change.
1198 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1201 2012-07-12 Eli Zaretskii <eliz@gnu.org>
1203 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1204 memmove call that removes glyphs covered by the left truncation
1205 glyph. Improve commentary.
1206 (display_line): Fix display of continuation glyphs on GUI frames
1207 when the right fringe is turned off and variable-size fonts are
1208 used in the window. Move the code that appends a stretch glyph to
1209 produce_special_glyphs, so that it could be used for truncation
1210 and continuation glyphs alike.
1211 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1212 glyph of a suitably computed width, to align the special glyphs at
1213 the window margin. Code moved from display_line. (Bug#11832)
1215 2012-07-12 Glenn Morris <rgm@gnu.org>
1217 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1219 * s/gnu-linux.h, s/hpux10-20.h:
1220 Do not unconditionally define HAVE_XRMSETDATABASE.
1222 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1224 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1226 Fix typos that broke OS X build.
1227 Reported by Randal L. Schwartz in
1228 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1229 * nsterm.m (ns_timeout): Add missing local decl.
1230 (ns_get_color): snprintf -> sprintf, to fix typo.
1232 2012-07-12 Glenn Morris <rgm@gnu.org>
1234 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1235 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1236 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1237 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1239 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1240 Move PTY_OPEN to configure.
1242 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1243 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1244 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1246 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1248 Use empty_unibyte_string where applicable.
1249 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1250 * lread.c (read1): Likewise.
1251 * xsettings.c (syms_of_xsettings): Likewise.
1253 2012-07-12 Glenn Morris <rgm@gnu.org>
1255 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1256 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
1257 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1258 * s/hpux10-20.h (RUN_TIME_REMAP):
1259 * s/bsd-common.h (TABDLY): Move to configure.
1261 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1263 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1265 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1266 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
1268 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
1270 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1271 * s/template.h: Move NARROWPROTO to configure.
1273 2012-07-11 Glenn Morris <rgm@gnu.org>
1275 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1276 unused since 2011-01-17 change to systty.h.
1278 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1279 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1280 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1282 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1284 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1286 2012-07-11 Glenn Morris <rgm@gnu.org>
1288 * s/darwin.h, s/gnu-linux.h, s/template.h:
1289 Move INTERRUPT_INPUT to configure.
1291 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1293 Minor adjustments to interning code.
1294 * lisp.h (intern, intern_c_string): Redefine as static inline
1295 wrappers for intern_1 and intern_c_string_1, respectively.
1296 (intern_1, intern_c_string_1): Rename prototypes.
1297 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1299 * font.c (font_intern_prop): Likewise. Adjust comment.
1300 * w32font.c (intern_font_name): Likewise.
1302 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1304 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1306 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1307 of Fcar/Fcdr if possible.
1308 * font.c (check_otf_features): Likewise.
1309 * fontset.c (Fnew_fontset): Likewise.
1310 * gnutls.c (Fgnutls_boot): Likewise.
1311 * minibuf.c (read_minibuf): Likewise.
1312 * msdos.c (IT_set_frame_parameters): Likewise.
1313 * xmenu.c (Fx_popup_dialog): Likewise.
1314 * w32menu.c (Fx_popup_dialog): Likewise.
1316 2012-07-11 Glenn Morris <rgm@gnu.org>
1318 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1319 since nothing has defined it on these platforms.
1321 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1322 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1324 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1325 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1326 Move CLASH_DETECTION to configure.
1328 * s/gnu.h: Remove file, which is now empty.
1330 * s/gnu.h, s/gnu-linux.h:
1331 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1333 2012-07-11 John Wiegley <johnw@newartisans.com>
1335 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1336 function attribute, so we only use it if it exists in the
1339 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1341 Avoid call to strlen in fast_c_string_match_ignore_case.
1342 * search.c (fast_c_string_match_ignore_case): Change to use
1343 length argument. Adjust users accordingly.
1344 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1346 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1348 Assume mkdir, rmdir.
1349 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1350 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1353 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1356 * s/hpux10-20.h (HAVE_PERROR): Remove.
1357 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1358 Remove dummy definition, as this problem was obsolete long ago.
1361 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1363 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1365 Avoid calls to strlen in font processing functions.
1366 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1367 (font_open_by_name): Change to use length argument. Adjust
1369 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1371 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1372 Change to return ptrdiff_t.
1373 (xfont_list_pattern, xfont_match): Use length returned by
1374 xfont_decode_coding_xlfd.
1375 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1377 2012-07-11 Glenn Morris <rgm@gnu.org>
1379 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1380 Move DONT_REOPEN_PTY to configure.
1382 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1383 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1385 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1387 Remove "#define unix" that is no longer needed (Bug#11905).
1388 * s/aix4-2.h (unix): Remove; no longer needed.
1390 EMACS_TIME simplification (Bug#11875).
1391 This replaces macros (which typically do not work in GDB)
1392 with functions, typedefs and enums, making the code easier to debug.
1393 The functional style also makes code easier to read and maintain.
1394 * systime.h: Include <sys/time.h> on all hosts, not just if
1395 WINDOWSNT, since 'struct timeval' is needed in general.
1396 (EMACS_TIME): Now a typedef, not a macro.
1397 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1399 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1400 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1401 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1402 (EMACS_TIME_LE): Now functions, not macros.
1403 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1404 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1405 which are not functions. All uses rewritten to use:
1406 (make_emacs_time): New function.
1407 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1408 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1409 not functions. All uses rewritten to use the following, respectively:
1410 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1411 (add_emacs_time, sub_emacs_time): New functions.
1412 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1413 * fileio.c (Fcopy_file):
1414 * xterm.c (XTflash): Get the current time closer to when it's used.
1415 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1417 * bytecode.c (targets): Suppress -Woverride-init warnings.
1419 Simplify by avoiding confusing use of strncpy etc.
1420 * doc.c (Fsnarf_documentation):
1421 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1422 * frame.c (Fmake_terminal_frame):
1423 * gtkutil.c (get_utf8_string):
1425 * nsmenu.m (ns_update_menubar):
1426 * regex.c (regerror):
1427 Prefer memcpy to strncpy and strncat when either will do.
1428 * fileio.c (Fsubstitute_in_file_name):
1429 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1430 (menu_separator_name_p):
1431 * nsmenu.m (ns_update_menubar):
1432 Prefer memcmp to strncmp when either will do.
1433 * nsterm.m: Include <ftoastr.h>.
1435 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1436 Prefer snprintf to strncpy.
1437 * nsterm.m (ns_term_init):
1438 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1439 * nsterm.m (ns_term_init):
1440 Avoid the need for strncpy, by using build_string or
1441 make_unibyte_string directly. Use dtoastr, not snprintf.
1442 * process.c (Fmake_network_process): Diagnose service names that
1443 are too long, rather than silently truncating them or creating
1444 non-null-terminated names.
1445 (Fnetwork_interface_info): Likewise, for interface names.
1446 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1447 Prefer sprintf to strncat.
1448 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1449 Prefer vsnprintf to vsprintf + strncpy.
1451 2012-07-10 Glenn Morris <rgm@gnu.org>
1453 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1454 Clarify fallback case.
1456 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1458 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1459 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1460 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1461 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1462 where argument type is known to be a Lisp_Cons.
1464 2012-07-10 Tom Tromey <tromey@redhat.com>
1466 * bytecode.c (BYTE_CODE_THREADED): New macro.
1467 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1468 (enum byte_code_op): New type.
1469 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1470 (exec_byte_code): Use them. Use token threading when applicable.
1472 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1474 Optimize pure C strings initialization.
1475 * lisp.h (make_pure_string): Fix prototype.
1476 (build_pure_c_string): New function, defined as static inline. This
1477 provides a better opportunity to optimize away calls to strlen when
1478 the function is called with compile-time constant argument.
1479 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1480 argument, adjust users accordingly. Use build_pure_c_string where
1482 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1483 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1484 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1486 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1488 Avoid calls to strlen in miscellaneous functions.
1489 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1490 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1491 * lread.c (openp): Likewise.
1493 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1495 Avoid calls to strlen in path processing functions.
1496 * fileio.c (file_name_as_directory): Add comment. Change to add
1497 srclen argument and return the length of result. Adjust users
1499 (directory_file_name): Fix comment. Change to add srclen argument,
1500 swap 1st and 2nd arguments to obey the common convention. Adjust
1502 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1504 2012-07-10 Glenn Morris <rgm@gnu.org>
1506 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1507 Move PENDING_OUTPUT_COUNT definition to configure.
1509 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1510 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1511 * s/gnu.h (DATA_START): Move definitions to configure.
1513 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1514 We include usg5-4-common.h, which defines them both.
1516 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1517 O_RDONLY already includes it).
1519 Stop ns builds setting the EMACSLOADPATH environment variable.
1520 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1521 Now it does not set EMACSLOADPATH, just returns the load-path string.
1522 * nsterm.h: Update accordingly.
1523 * lread.c [HAVE_NS]: Include nsterm.h.
1524 (init_lread) [HAVE_NS]: Use ns_load_path.
1525 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1527 2012-07-09 Glenn Morris <rgm@gnu.org>
1529 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1530 since the included bsd-common.h does so.
1532 Stop ns builds setting the EMACSPATH environment variable.
1533 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1534 (ns_init_paths): Do not set EMACSPATH.
1535 * nsterm.h (ns_exec_path): Add it.
1536 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1539 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1541 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1543 * process.c (wait_reading_process_output): 'waitchannels' was unset
1544 when read_kbd || !NILP (wait_for_cell); fix this.
1546 Add GCC-style 'const' attribute to functions that can use it.
1547 * character.h (char_resolve_modifier_mask):
1548 * keyboard.h (make_ctrl_char):
1549 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1550 (init_character_once, next_almost_prime, init_fns, init_image)
1551 (flush_pending_output, init_sound):
1552 * mem-limits.h (start_of_data):
1553 * menu.h (finish_menu_items):
1554 Add ATTRIBUTE_CONST.
1555 * emacs.c (DEFINE_DUMMY_FUNCTION):
1556 Declare the dummy function with ATTRIBUTE_CONST.
1557 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1558 Add decls with ATTRIBUTE_CONST.
1560 Minor improvements to make_formatted_string.
1561 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1562 where int is good enough, as vsprintf returns an int.
1563 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1565 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1567 Use make_formatted_string to avoid double length calculation.
1568 * lisp.h (make_formatted_string): New prototype.
1569 * alloc.c (make_formatted_string): New function.
1570 * buffer.c (Fgenerate_new_buffer_name): Use it.
1571 * dbus.c (syms_of_dbusbind): Likewise.
1572 * editfns.c (Fcurrent_time_zone): Likewise.
1573 * filelock.c (get_boot_time): Likewise.
1574 * frame.c (make_terminal_frame, set_term_frame_name)
1575 (x_report_frame_params): Likewise.
1576 * image.c (gs_load): Likewise.
1577 * minibuf.c (get_minibuffer): Likewise.
1578 * msdos.c (dos_set_window_size): Likewise.
1579 * process.c (make_process): Likewise.
1580 * xdisp.c (ensure_echo_area_buffers): Likewise.
1581 * xsettings.c (apply_xft_settings): Likewise.
1583 2012-07-09 Glenn Morris <rgm@gnu.org>
1585 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1586 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1587 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1588 * nsterm.h (ns_etc_directory): Add it.
1589 * callproc.c [HAVE_NS]: Include nsterm.h.
1590 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1592 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1594 Move marker debugging code under MARKER_DEBUG.
1595 * marker.c (MARKER_DEBUG): Move marker debugging code under
1596 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1597 for bootstrap with --enable-checking (~3x slowdown reported
1598 by Juanma Barranquero <lekktu@gmail.com>).
1599 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1601 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1603 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1604 See <http://bugs.gnu.org/11825#29>.
1606 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1608 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1609 has no font, use the frame's font. (Bug#11813)
1610 (display_line): Add commentary about displaying truncation glyphs
1612 (produce_special_glyphs): Move here from term.c.
1614 * term.c (produce_special_glyphs): Move to xdisp.c.
1616 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1619 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1621 * xdisp.c (display_line): Avoid warning about implicit declaration
1624 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1626 * lisp.h: Remove empty conditional.
1628 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1630 * lread.c (load_path_check): Now static.
1632 Fix some minor --with-ns problems found by static checking.
1633 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1634 (x_set_font) [!HAVE_X_WINDOWS]:
1635 * image.c (xpm_load_image) [HAVE_NS]:
1636 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1637 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1638 Remove unused local.
1639 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1640 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1641 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1642 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1643 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1644 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1645 Fix pointer signedness problem.
1646 * xfaces.c (FRAME_X_FONT_TABLE):
1647 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1649 2012-07-07 Glenn Morris <rgm@gnu.org>
1651 * lread.c (load_path_check): New function, split from init_lread.
1652 (init_lread): Reorganize. Motivation:
1653 If EMACSLOADPATH is set, check/warn about that rather than the
1654 defaults, which we are not going to use. Hence we can remove
1655 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1656 Don't warn if site-lisp directories are missing.
1657 If not installed, start from a blank load-path, since
1658 PATH_LOADSEARCH refers to the eventual installation directories.
1660 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1662 Support truncation and continuation glyphs on GUI frames, when
1663 fringes are disabled. (Bug#11832)
1664 * xdisp.c (init_iterator): Get dimensions of truncation and
1665 continuation glyphs even if on GUI frames. Adjust
1666 it->last_visible_x on GUI frames when the left or right fringes,
1667 or both, are absent.
1668 (start_display, move_it_in_display_line_to): Handle the case of a
1669 GUI frame without a fringe to display continuation or truncation
1671 (insert_left_trunc_glyphs): Support GUI frames: make sure
1672 truncation glyphs overwrite enough glyphs from the current line to
1673 have sufficient space in pixels.
1674 (display_line): Support truncation and continuation glyphs on GUI
1675 frames. If some spare pixels are left on the line after inserting
1676 the truncation glyphs, fill that space with a stretch glyph of a
1677 suitably computed width.
1679 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1680 produce_glyphs, to support GUI sessions.
1682 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1684 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1686 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1688 Do not require float-time's arg to fit in time_t (Bug#11825).
1689 This works better on hosts where time_t is unsigned, and where
1690 float-time is applied to the (negative) difference between two times.
1691 * editfns.c (decode_time_components): Last arg is now double *,
1692 not int *, and means to store all the result as a double, without
1693 worrying about whether the seconds part fits in time_t.
1694 All callers changed.
1695 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1696 All callers changed.
1697 (Ffloat_time): Do not fail merely because the specified time falls
1698 outside of time_t range.
1700 2012-07-07 Glenn Morris <rgm@gnu.org>
1702 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1703 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1704 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1706 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1708 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1709 Update dependencies.
1711 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1713 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1715 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1716 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1717 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1718 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1719 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1720 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1722 * xfont.c (compare_font_names): Redo to omit the need for casts.
1724 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1726 * xfns.c (Fx_change_window_property): Doc fix.
1727 * w32fns.c (Fx_change_window_property): Doc fix.
1729 * w32fns.c (Fx_window_property): Accept the same arguments as the
1730 X Windows version. Doc fix.
1731 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1733 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1734 Eli Zaretskii <eliz@gnu.org>
1736 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1737 Windows-specific code from nt/config.nt moved here.
1738 Obsolete settings removed.
1740 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1742 * process.c: Avoid unnecessary calls to gettime.
1743 (wait_reading_process_output): Don't get the time of day
1744 when gobbling data immediately and not waiting, as there's no need
1745 for it in that case. This removes a FIXME.
1747 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1749 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1750 is defined (Bug#11768).
1752 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1754 Fix marker debugging code.
1755 * marker.c (byte_char_debug_check): Do not perform the check
1756 if buffer is not multibyte.
1757 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1758 Call byte_char_debug_check with correct arguments.
1760 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1762 Compile marker debugging code only if ENABLE_CHECKING is defined.
1763 * marker.c (byte_char_debug_check, count_markers):
1764 Use only if ENABLE_CHECKING is defined.
1765 (byte_debug_flag): Remove.
1766 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1767 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1769 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1771 Avoid code repetition in marker-related functions.
1772 * marker.c (attach_marker): New function.
1773 (Fset_marker, set_marker_restricted, set_marker_both)
1774 (set_marker_restricted_both): Use it.
1775 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1776 Consistently rename charno to charpos.
1777 (marker_position): Add eassert.
1778 (marker_byte_position): Convert to eassert.
1780 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1782 Simplify list operations in unchain_overlay and unchain_marker.
1783 * buffer.c (unchain_overlay): Simplify. Add comment.
1784 * marker.c (unchain_marker): Simplify. Fix comments.
1786 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1788 Introduce fast path for the widely used marker operation.
1789 * alloc.c (build_marker): New function.
1790 * lisp.h (build_marker): New prototype.
1791 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1792 * composite.c (autocmp_chars): Likewise.
1793 * editfns.c (buildmark): Remove.
1794 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1795 (save_restriction_save): Use build_marker.
1796 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1797 * window.c (save_window_save): Likewise.
1799 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1801 Do not use Fdelete_overlay in delete_all_overlays
1802 to avoid redundant calls to unchain_overlay.
1803 * buffer.c (drop_overlay): New function.
1804 (delete_all_overlays, Fdelete_overlay): Use it.
1805 * minibuf.c (get_minibuffer): Fix comment.
1807 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1809 Port to OpenBSD 5.1 amd64.
1810 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1811 This is needed for OpenBSD, and should be harmless on all BSD systems.
1812 Also, include <sys/sysctl.h>, as it should be available on all
1813 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1814 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1815 use p_pid member, not kp_proc.pid.
1817 2012-07-06 Glenn Morris <rgm@gnu.org>
1819 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1821 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1823 More xmalloc and related cleanup.
1824 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1825 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1826 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1827 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1828 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1829 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1830 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1831 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1832 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1834 Omit needless casts involving void * pointers and allocation.
1835 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1836 as the former is more robust if P's type is changed.
1837 Prefer xzalloc to xmalloc + memset 0.
1838 Simplify malloc-or-realloc to realloc.
1839 Don't worry about xmalloc returning a null pointer.
1840 Prefer xstrdup to xmalloc + strcpy.
1841 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1843 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1844 alloca of a constant.
1846 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1848 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1849 hscroll is larger than the line width. Fixes long and futile
1850 looping inside extend_face_to_end_of_line (on a TTY) producing
1851 glyphs that are not needed and thrown away.
1853 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1855 * marker.c (set_marker_restricted_both): Simplify by using
1858 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1860 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1862 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1864 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1865 not defined (Bug#11768).
1866 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1867 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1868 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1869 followed by gtk_box_set_homogeneous (Bug#11768).
1870 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1871 (update_theme_scrollbar_width, xg_create_scroll_bar):
1872 Use gtk_scrollbar_new (Bug#11768).
1873 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1874 (is_box_type): New function (Bug#11768).
1875 (xg_tool_item_stale_p): Call is_box_type.
1876 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1877 with default display (Bug#11768).
1879 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1881 * xdisp.c (window_hscroll_limited): New function.
1882 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1883 coordinates when window's hscroll is set to insanely large
1886 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1888 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1889 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1891 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1894 * lisp.h (xzalloc): New prototype. Omit needless casts.
1895 * alloc.c (xzalloc): New function. Omit needless casts.
1896 * charset.c: Omit needless casts. Convert all calls to
1897 xmalloc with following memset to xzalloc.
1898 * dispnew.c: Likewise.
1899 * fringe.c: Likewise.
1900 * image.c: Likewise.
1901 * sound.c: Likewise.
1903 * w32fns.c: Likewise.
1904 * w32font.c: Likewise.
1905 * w32term.c: Likewise.
1906 * xfaces.c: Likewise.
1908 * xterm.c: Likewise.
1909 * atimer.c: Omit needless casts.
1910 * buffer.c: Likewise.
1911 * callproc.c: Likewise.
1913 * coding.c: Likewise.
1914 * composite.c: Likewise.
1916 * doprnt.c: Likewise.
1917 * editfns.c: Likewise.
1918 * emacs.c: Likewise.
1920 * filelock.c: Likewise.
1922 * gtkutil.c: Likewise.
1923 * keyboard.c: Likewise.
1925 * lread.c: Likewise.
1926 * minibuf.c: Likewise.
1927 * msdos.c: Likewise.
1928 * print.c: Likewise.
1929 * process.c: Likewise.
1930 * region-cache.c: Likewise.
1931 * search.c: Likewise.
1932 * sysdep.c: Likewise.
1933 * termcap.c: Likewise.
1934 * terminal.c: Likewise.
1935 * tparam.c: Likewise.
1936 * w16select.c: Likewise.
1938 * w32reg.c: Likewise.
1939 * w32select.c: Likewise.
1940 * w32uniscribe.c: Likewise.
1941 * widget.c: Likewise.
1942 * xdisp.c: Likewise.
1943 * xmenu.c: Likewise.
1945 * xselect.c: Likewise.
1947 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1949 * fileio.c (time_error_value): Check the right error number.
1950 Problem reported by Troels Nielsen in
1951 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1953 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1955 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1956 This should be fixed in a better way; see Eli Zaretskii in
1957 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1958 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1960 * fileio.c (time_error_value): Rename from special_mtime.
1961 The old name's problems were noted by Eli Zaretskii in
1962 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1964 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1965 This variable's comment says Emacs needs at least one GDB-visible
1966 symbol of type enum pvec_type, to work around GDB problems.
1967 The symbol's value doesn't matter.
1969 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1970 that causes compilation to fail on pre-C99 compilers.
1972 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1974 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1975 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1977 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1979 * buffer.c (init_buffer_once): Fix initialization of
1980 headers for buffer_defaults and buffer_local_symbols.
1981 Reported by Juanma Barranquero <lekktu@gmail.com>.
1983 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1985 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1986 * lisp.h (enum pvec_type): Use fewer bits.
1987 (PSEUDOVECTOR_SIZE_BITS): New constant.
1988 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1989 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1990 change in pvec_type.
1991 (PSEUDOVECTOR_TYPEP): New macro.
1992 (TYPED_PSEUDOVECTORP): Use it.
1993 * fns.c (internal_equal): Adapt code to extract pvectype.
1994 * emacs.c (gdb_pvec_type): Update type.
1995 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1996 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1997 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1998 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1999 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2000 abusing vector->header.next.nbytes.
2001 (live_vector_p): Use PVEC_TYPE.
2002 (mark_object): Adapt code to extract pvectype. Use switch.
2004 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2006 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2007 Tighten new eassert a bit.
2009 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2011 Fix compilation with --enable-gcc-warnings and -O1
2013 * doprnt.c (doprnt): Change type of tem to int, initialize
2014 to avoid compiler warning. Add eassert.
2015 * search.c (simple_search): Initialize match_byte to avoid
2016 compiler warning. Add eassert.
2018 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2020 Avoid weird behavior with large horizontal scrolls.
2021 Without this change, for example, large hscroll values would
2022 mess up Emacs's display on Fedora 15 x86, presumably due to
2023 overflows in int calculations in the display code.
2024 Also, if buffers had long lines, Emacs would freeze.
2025 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2026 (set_window_hscroll): New function, containing the old guts of
2027 Fset_window_hscroll. Return the clipped value.
2028 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2029 This avoids the need to check against PTRDIFF_MAX.
2031 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2033 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2035 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2037 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2039 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2040 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2041 since GCC 4.4.6 issues a bogus warning for them.
2043 Fix bugs in file timestamp newness comparisons.
2044 * fileio.c (Ffile_newer_than_file_p):
2045 * lread.c (Fload): Use full timestamp resolution of files,
2046 not just the 1-second resolution, so that files that are only
2047 slightly newer still count as newer.
2048 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2049 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2051 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2053 * fileio.c: Improve handling of file time marker. (Bug#11852)
2054 (special_mtime): New function.
2055 (Finsert_file_contents, Fverify_visited_file_modtime):
2056 Use it to set special mtime values consistently.
2058 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2060 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2061 marker for non-existing file. (Bug#11852)
2063 2012-07-03 Glenn Morris <rgm@gnu.org>
2065 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2066 and did not make it into globals.h).
2068 2012-07-03 Tom Tromey <tromey@redhat.com>
2070 * window.c (Fset_window_margins, Fset_window_fringes)
2071 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2072 * textprop.c (Fprevious_property_change): No longer static.
2073 * syntax.c (Fsyntax_table_p): No longer static.
2074 * process.c (Fget_process, Fprocess_datagram_address): No longer
2076 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2077 * keyboard.c (Fcommand_execute): No longer static.
2079 * insdel.c (Fcombine_after_change_execute): No longer static.
2080 * image.c (Finit_image_library): No longer static.
2081 * fileio.c (Fmake_symbolic_link): No longer static.
2082 * eval.c (Ffetch_bytecode): No longer static.
2083 * editfns.c (Fuser_full_name): No longer static.
2084 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2086 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2088 * dired.c (Ffile_attributes): No longer static.
2089 * composite.c (Fcomposition_get_gstring): No longer static.
2090 * callproc.c (Fgetenv_internal): No longer static.
2092 * ccl.h: Remove EXFUNs.
2093 * buffer.h: Remove EXFUNs.
2094 * dispextern.h: Remove EXFUNs.
2095 * intervals.h: Remove EXFUNs.
2096 * fontset.h: Remove EXFUN.
2097 * font.h: Remove EXFUNs.
2098 * dosfns.c (system_process_attributes): Remove EXFUN.
2099 * keymap.h: Remove EXFUNs.
2100 * lisp.h: Remove EXFUNs.
2101 * w32term.h: Remove EXFUNs.
2102 * window.h: Remove EXFUNs.
2103 * xsettings.h: Remove EXFUN.
2104 * xterm.h: Remove EXFUN.
2106 2012-07-03 Glenn Morris <rgm@gnu.org>
2108 * lisp.h (Frandom): Make it visible to C.
2109 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2110 buffer for invisible buffers. (Bug#1229)
2112 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2114 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2115 values which aren't power of 2.
2116 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2117 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2120 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2122 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2124 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2126 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2128 * alloc.c (allocate_vector_block): Remove redundant
2129 calls to mallopt if DOUG_LEA_MALLOC is defined.
2130 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2131 avoid calls to mallopt if zero_vector is returned.
2133 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2135 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2136 is enabled, avoid dereferencing NULL current_sblock if
2139 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2141 Cleanup basic buffer management.
2142 * buffer.h (struct buffer): Change layout to use generic vector
2143 marking code. Fix some comments. Change type of 'clip_changed'
2144 to bitfield. Remove unused #ifndef old.
2145 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2146 (GET_OVERLAYS_AT): Fix indentation.
2147 (for_each_per_buffer_object_at): New macro.
2148 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2149 (Fbuffer_local_variables): Use it.
2150 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2151 * alloc.c (allocate_buffer): Adjust to match new layout of
2152 struct buffer. Fix comment.
2153 (mark_overlay): New function.
2154 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2155 Lisp area of struct buffer.
2156 (mark_object): Use it. Adjust marking of misc objects
2157 and related comments.
2159 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2161 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2162 wrapper that is not needed because the wrapped code is a no-op (zero
2163 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2164 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2166 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2168 * alloc.c (mark_buffer): Simplify. Remove prototype.
2169 (mark_object): Add comment. Reorganize marking of vector-like
2170 objects. Use CHECK_LIVE for all vector-like objects except buffers
2171 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2172 redundant calls to mark_vectorlike for bool vectors.
2174 2012-06-30 Glenn Morris <rgm@gnu.org>
2176 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2178 * epaths.in (PATH_SITELOADSEARCH): New.
2179 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2180 This is rather than relying on --enable-locallisppath elements
2181 having "site-lisp" in their names. (Bug#10208#25, 11658)
2183 2012-06-30 Eli Zaretskii <eliz@gnu.org>
2185 * w32proc.c (sys_select): Accept and ignore one more argument.
2187 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2189 * sysselect.h [DOS_NT]: Don't include sys/select.h.
2190 (pselect) [!MS_DOS]: Redirect to sys_select.
2192 * sysdep.c: Don't include dos.h and dosfns.h.
2194 * process.c (sys_select):
2195 * msdos.c (sys_select): Accept one more argument and ignore it.
2197 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2198 adapt data types and code to that.
2201 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2202 which clashes with the gnulib function of the same name.
2204 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2206 * font.c (font_style_to_value, font_style_symbolic)
2207 (font_prop_validate_style): Add type checks for values in
2210 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2212 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2215 2012-06-29 Eli Zaretskii <eliz@gnu.org>
2217 * xdisp.c (try_window_id): Undo last change.
2219 * w32.c (getwd): Adjust commentary about startup_dir.
2220 (init_environment): Always call sys_access, even in non-MSVC
2221 builds. Don't chdir to the directory of the Emacs executable.
2222 This undoes code from 1997 which was justified by the need to
2223 "avoid conflicts when removing and renaming directories". But its
2224 downside was that every relative file name was being interpreted
2225 relative to the directory of the Emacs executable, which can never
2226 be TRT. In particular, it broke sys_access when called with
2227 relative file names.
2228 (sys_access): Map GetLastError to errno.
2230 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2232 * window.h (struct window): Change type of 'fringes_outside_margins'
2233 to bitfield. Fix comment. Adjust users accordingly.
2234 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2236 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2239 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2241 * gnutls.c (emacs_gnutls_handshake):
2242 Add QUIT to make the loop interruptible.
2244 2012-06-29 Glenn Morris <rgm@gnu.org>
2246 * charset.c (init_charset): Make lack of etc/charsets fatal.
2248 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2250 * editfns.c (region_limit): Fix type mismatch.
2252 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2254 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2255 undefined. Convert from xassert to eassert.
2256 * nsmenu.m: Convert from xassert to eassert.
2257 * nsterm.m: Likewise.
2259 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2261 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2263 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2265 Avoid integer overflow on scroll-left and scroll-right.
2266 * window.c (HSCROLL_MAX): New macro.
2267 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2268 overflow when requested scroll falls outside ptrdiff_t range.
2270 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2272 * window.h (struct window): Change type of 'hscroll',
2273 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2274 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2275 Adjust users accordingly.
2276 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2277 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2278 from EMACS_INT to ptrdiff_t.
2279 (make_window): Omit redundant initialization.
2281 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
2283 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2285 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2287 * window.h (struct window): Change type of 'use_time' and
2288 'sequence_number' from Lisp_Object to int.
2289 * frame.c (make_frame): Adjust users accordingly.
2290 * print.c (print_object): Likewise.
2291 * window.c (select_window, Fwindow_use_time, make_parent_window)
2292 (make_window): Likewise.
2294 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2296 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2297 enabled with --enable-checking=[all,glyphs] configure option.
2298 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2299 adjust comments accordingly.
2300 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2301 undefined, adjust comments accordingly.
2302 * image.c: Likewise.
2303 * scroll.c: Likewise.
2304 * w32fns.c: Likewise.
2305 * w32term.c: Likewise.
2306 * xdisp.c: Likewise.
2307 * xfaces.c: Likewise.
2309 * xterm.c: Likewise.
2311 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2313 Generalize run-time debugging checks.
2314 * dispextern.h (XASSERTS): Remove.
2315 * fontset.c (xassert): Remove.
2316 Convert from xassert to eassert.
2317 * alloc.c: Convert from xassert to eassert.
2319 * dispnew.c: Likewise.
2321 * fringe.c: Likewise.
2322 * ftfont.c: Likewise.
2323 * gtkutil.c: Likewise.
2324 * image.c: Likewise.
2325 * keyboard.c: Likewise.
2327 * process.c: Likewise.
2328 * scroll.c: Likewise.
2329 * sound.c: Likewise.
2331 * w32console.c: Likewise.
2332 * w32fns.c: Likewise.
2333 * w32term.c: Likewise.
2334 * window.c: Likewise.
2335 * xdisp.c: Likewise.
2336 * xfaces.c: Likewise.
2338 * xselect.c: Likewise.
2339 * xterm.c: Likewise.
2341 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2343 * fns.c (maybe_resize_hash_table): Output message when growing the
2346 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2348 * alloc.c (allocate_string_data): Remove dead code.
2349 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2350 avoid GCC warning about unused macro.
2352 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2354 * alloc.c (allocate_string): Omit intervals initialization.
2355 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2356 as in make_pure_string and make_pure_c_string.
2358 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2360 * alloc.c (allocate_string): Fix last change.
2362 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2364 * alloc.c (allocate_string): Remove two redundant calls
2365 to memset, add explicit initialization where appropriate.
2367 2012-06-27 Glenn Morris <rgm@gnu.org>
2369 * lisp.mk (lisp): Remove paths.elc.
2371 2012-06-27 Chong Yidong <cyd@gnu.org>
2373 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2375 2012-06-26 John Wiegley <johnw@newartisans.com>
2377 * unexmacosx.c (copy_data_segment): Add two section names used
2378 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2380 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2381 when building with Clang.
2383 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2385 * eval.c (Fapply): Allow calling it with a single argument.
2387 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2389 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2390 _stricmp and _strnicmp.
2391 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2393 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2395 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2397 (allocate_process): Likewise for new process.
2398 (allocate_terminal): Change to use offsetof.
2399 (allocate_frame): Likewise.
2400 * frame.c (make_frame): Omit redundant initialization.
2401 * window.c (make_parent_window): Use memset.
2402 (make_window): Omit redundant initialization.
2403 * process.c (make_process): Omit redundant initialization.
2404 * terminal.c (create_terminal): Likewise.
2406 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2408 * term.c (delete_tty): Remove redundant call to memset.
2410 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2412 * alloc.c: Remove build_string.
2413 * lisp.h: Define build_string as static inline. This provides
2414 a better opportunity to optimize away calls to strlen when the
2415 function is called with compile-time constant argument.
2416 * image.c (imagemagick_error): Convert to build_string.
2417 * w32proc.c (sys_spawnve): Likewise.
2418 * xterm.c (x_term_init): Likewise.
2420 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2422 Use sprintf return value instead of invoking strlen on result.
2423 In the old days this wasn't portable, since some sprintf
2424 implementations returned char *. But they died out years ago and
2425 Emacs already assumes sprintf returns int.
2426 Similarly for float_to_string.
2427 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2428 * ccl.c (ccl_driver):
2429 * character.c (string_escape_byte8):
2430 * data.c (Fnumber_to_string):
2431 * doprnt.c (doprnt):
2432 * print.c (print_object):
2433 * xdisp.c (message_dolog):
2434 * xfns.c (syms_of_xfns):
2435 Use sprintf or float_to_string result to avoid need to call strlen.
2436 * data.c (Fnumber_to_string):
2437 Use make_unibyte_string, since the string must be ASCII.
2438 * lisp.h, print.c (float_to_string): Now returns int length.
2439 * term.c (produce_glyphless_glyph):
2440 Use sprintf result rather than recomputing it.
2442 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2443 * Makefile.in (ALL_CFLAGS):
2444 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2445 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2447 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2449 * dispextern.h (xstrcasecmp): Define to library function
2450 strcasecmp if available.
2451 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2453 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2455 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2456 Avoid comma operator.
2457 * menu.c (push_submenu_start, push_submenu_end)
2458 (push_left_right_boundary, push_menu_pane): Likewise.
2459 * msdos.c (dos_rawgetc): Likewise.
2461 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2463 * xfns.c (xic_create_fontsetname): Remove redundant calls
2466 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2468 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2469 sprintf already null-terminates its output.
2471 * xfns.c (x_window): Remove redundant cast.
2473 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2475 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2476 `const char *' to `char *' to avoid compiler warning.
2478 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2480 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2481 instead of truncating it to 63 (admittedly a generous limit).
2483 * process.c: Fix spelling and caps in comments.
2485 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2487 * emacs.c (setpgrp): Remove definition, unused.
2488 * sysdep.c (setpgrp): Remove definition, not used in this file.
2490 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2492 * makefile.w32-in: Update dependencies.
2494 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2496 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2497 (SYSTIME_H): Add nt/inc/sys/time.h.
2499 * systime.h [WINDOWSNT]: Include sys/time.h.
2501 * s/ms-w32.h (struct timespec): Definition moved from
2502 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2504 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2506 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2507 * buffer.h (buffer_slot_type_mismatch):
2508 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2509 * eval.c (unwind_to_catch):
2510 * image.c (my_png_error, my_error_exit):
2511 * keyboard.c (quit_throw_to_read_char, user_error)
2512 (Fexit_recursive_edit, Fabort_recursive_edit):
2513 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2514 (wrong_type_argument, buffer_overflow, __executable_start)
2515 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2516 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2517 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2519 (child_setup) [!DOS_NT]:
2520 * lread.c (end_of_file_error, invalid_syntax):
2521 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2522 * puresize.h (pure_write_error):
2523 * search.c (matcher_overflow):
2524 * sound.c (sound_perror, alsa_sound_perror):
2525 * sysdep.c, syssignal.h (croak):
2526 * term.c (maybe_fatal, vfatal):
2527 * textprop.c (text_read_only):
2528 * undo.c (user_error):
2529 * unexmacosx.c (unexec_error):
2530 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2531 Use _Noreturn rather than NO_RETURN.
2532 No need for separate decl merely because of _Noreturn.
2533 * sound.c (sound_warning, parse_sound):
2534 Remove unnecessary forward decls.
2536 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2538 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2539 * lisp.h (WAIT_READING_MAX): New macro.
2540 * dispnew.c (Fsleep_for, sit_for):
2541 * keyboard.c (kbd_buffer_get_event):
2542 * process.c (Faccept_process_output):
2543 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2544 This improves on the previous patch, which introduced a bug
2545 when time_t is unsigned and as wide as intmax_t.
2546 See <http://bugs.gnu.org/9000#51>.
2548 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2550 * dispnew.c (sit_for, Fsleep_for):
2551 * keyboard.c (kbd_buffer_get_event):
2552 * process.c (Faccept_process_output): Avoid compiler warnings when
2553 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2555 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2557 * makefile.w32-in: Update dependencies.
2559 * w32.c (ltime): Add return type and declare static.
2560 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2562 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2564 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2565 Privately reported by Herbert J. Skuhra.
2566 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2568 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2569 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2571 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2573 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2574 last argument of make_unibyte_string.
2576 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2577 language ID in the event parameters.
2579 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2580 event.code, not the obscure "character set ID".
2582 2012-06-23 Chong Yidong <cyd@gnu.org>
2584 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2586 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2588 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2589 * w32.c (fdutimens): New function.
2591 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2593 * s/ms-w32.h (pselect): Redirect to sys_select.
2595 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2597 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2598 in the logic of incrementing and decrementing the value of
2599 use_relocatable_buffers.
2601 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2603 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2604 Privately reported by Herbert J. Skuhra.
2605 [__FreeBSD__]: Remove "*/" typo after "#include".
2606 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2607 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2608 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2609 Don't assume EMACS_TIME and struct timeval are the same type.
2611 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2613 Support higher-resolution time stamps (Bug#9000).
2614 The time stamps are only nanosecond-resolution at the C level,
2615 since that's the best that any real-world system supports now.
2616 But they are picosecond-resolution at the Lisp level, as that's
2617 easy, and leaves room for future OS improvements.
2619 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2622 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2623 Don't get current time unless it's needed.
2625 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2626 now provides it if it's absent.
2627 (start_atimer): Port to higher-res time stamps.
2628 Check for time stamp overflow. Don't get current time more
2629 often than is needed.
2631 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2632 Include systime.h, not time.h.
2633 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2635 * dired.c: Include stat-time.h.
2636 (Ffile-attributes): File times now have higher resolution.
2638 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2639 (struct image): Timestamp now has higher resolution.
2641 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2642 has at least microseconds now. All uses removed.
2643 (update_frame, update_single_window, update_window, update_frame_1)
2644 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2646 * editfns.c (time_overflow): Now extern.
2647 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2648 (float-time, Fformat_time_string, Fcurrent_time_string)
2649 (Fcurrent_time_zone): Accept and generate higher-resolution
2651 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2652 (decode_time_components, lisp_seconds_argument): New functions.
2653 (make_time): Now static.
2654 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2655 Report an error if the time is invalid, rather than having the caller
2658 * fileio.c: Include <stat-time.h>
2659 (Fcopy_file): Copy higher-resolution time stamps.
2660 Prefer to set the time stamp via a file descriptor if that works.
2661 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2662 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2663 (Fvisited_file_modtime, Fset_visited_file_modtime):
2664 Support higher-resolution time stamps.
2666 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2668 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2670 * image.c (prepare_image_for_display, clear_image_cache)
2671 (lookup_image): Port to higer-resolution time stamps.
2673 * keyboard.c (start_polling, bind_polling_period):
2674 Check for time stamp overflow.
2675 (read_char, kbd_buffer_get_event, timer_start_idle)
2676 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2677 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2678 Port to higher-resolution time stamps. Do not assume time_t is signed.
2679 (decode_timer): New function. Timers are now vectors of length 9,
2680 not 8, to accommodate the picosecond component.
2681 (timer_check_2): Use it.
2683 * nsterm.m (select_timeout, timeval_subtract): Remove.
2684 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2685 as they're a bit more accurate and handle overflow better.
2686 (ns_select): Change prototype to be compatible with pselect.
2687 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2688 * nsterm.h (ns_select): Adjust prototype.
2690 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2691 us-resolution time stamps.
2692 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2694 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2696 * lisp.h (time_overflow): New decl.
2697 (wait_reading_process_output): First arg is now intmax_t, not int,
2698 to accommodate larger waits.
2700 * process.h (struct Lisp_Process.read_output_delay):
2701 Now counts nanoseconds, not microseconds.
2702 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2704 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2705 (wait_reading_process_output):
2706 Port to ns-resolution time stamps.
2707 (Faccept_process_output, wait_reading_process_output):
2708 Check for time stamp overflow. Do not assume time_t is signed.
2709 (select_wrapper): Remove; we now use pselect.
2710 (Fprocess_attributes): Now generates ns-resolution time stamps.
2712 * sysdep.c: Include utimens.h. Don't include utime.h
2713 or worry about struct utimbuf; gnulib does that for us now.
2714 (gettimeofday): Remove; gnulib provides a substitute.
2715 (make_timeval): New function.
2716 (set_file_times): Now sets ns-resolution time stamps.
2717 New arg FD; all uses changed.
2718 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2719 (system_process_attributes):
2720 Now returns ns-resolution time stamp. All uses changed.
2721 Check for time stamp overflow.
2723 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2724 provides a substitute now.
2726 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2727 since it guarantees struct timespec.
2728 (EMACS_TIME): Now struct timespec, so that we can support
2729 ns-resolution time stamps.
2730 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2731 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2732 (EMACS_USECS): Remove.
2733 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2734 so multiply the arg by 1000 before storing it.
2735 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2737 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2738 Port to ns-resolution time stamps.
2739 (EMACS_TIME_NEG_P): Remove; replaced by....
2740 (EMACS_TIME_SIGN): New macro.
2741 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2742 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2743 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2744 (make_timeval, make_lisp_time, decode_time_components): New decls.
2745 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2746 that it mishandled time_t overflow. You can't compare by subtracting!
2747 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2748 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2750 * term.c: Include <sys/time.h>.
2751 (timeval_to_Time): New function, for proper overflow wraparound.
2752 (term_mouse_position, term_mouse_click): Use it.
2754 * undo.c (record_first_change): Support higher-resolution time stamps
2756 (Fprimitive_undo): Use them when restoring time stamps.
2758 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2759 (w32_get_internal_run_time):
2760 Port to higher-resolution Emacs time stamps.
2761 (ltime): Now accepts single 64-bit integer, as that's more convenient
2764 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2766 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2767 for compatibility with pselect. Support ns-resolution time stamps.
2769 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2771 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2772 Check for time stamp overflow, and support ns-resolution time stamps.
2774 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2775 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2776 (timeval_subtract): Remove; no longer needed.
2777 (XTflash, XTring_bell, x_wait_for_event):
2778 Port to ns-resolution time stamps. Don't assume time_t is signed.
2780 2012-06-22 Chong Yidong <cyd@gnu.org>
2782 * xdisp.c (x_consider_frame_title): Revert last change.
2784 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2786 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2787 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2788 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2789 staticidx goes up to 1597 out of 1600 = 0x640.)
2791 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2793 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2794 Otherwise, the umask might be mistakenly 0 while handling input signals.
2796 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2798 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2800 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2802 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2803 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2804 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2805 access to `contents' member of Lisp_Vector objects with AREF and ASET
2808 2012-06-19 Chong Yidong <cyd@gnu.org>
2810 * frame.c (delete_frame): When selecting a frame on a different
2811 text terminal, do not alter the terminal's top-frame.
2813 * xdisp.c (format_mode_line_unwind_data): Record the target
2814 frame's selected window and its terminal's top-frame.
2815 (unwind_format_mode_line): Restore them.
2816 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2818 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2819 since tty frames can be explicitly named.
2820 (prepare_menu_bars): Likewise.
2822 * term.c (Ftty_top_frame): New function.
2824 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2826 Port byte-code-meter to modern targets.
2827 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2828 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2829 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2830 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2831 (METER_1, METER_2): Simplify.
2833 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2835 * data.c (Fdefalias): Return `symbol' (bug#11686).
2837 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2839 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2840 gets killed during executing of this function (Bug#11665).
2841 Try to always return Qt when the buffer has been actually killed.
2842 (Vkill_buffer_query_functions): In doc-string say that functions
2843 run by this hook should not change the current buffer.
2845 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2847 Fix recently-introduced process.c problems found by static checking.
2848 * process.c (write_queue_push, write_queue_pop, send_process):
2849 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2850 (write_queue_pop): Fix pointer signedness problem.
2851 (send_process): Remove unused local.
2853 2012-06-17 Chong Yidong <cyd@gnu.org>
2855 * xdisp.c (redisplay_internal): No need to redisplay terminal
2856 frames that are not on top.
2858 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2860 * process.c (make_process): Initialize write_queue.
2861 (write_queue_push, write_queue_pop): New functions.
2862 (send_process): Use them to maintain correct ordering of process
2865 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2867 * lisp.h (eassert): Assume C89 or later.
2868 This removes the need for CHECK.
2869 (CHECK): Remove. Its comments about always evaluating its
2870 argument were confusing, as 'eassert' typically does not evaluate
2873 * coding.c (produce_chars): Use ptrdiff_t, not int.
2875 * xterm.c (x_draw_underwave): Check for integer overflow.
2876 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2878 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2880 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2881 referenced (Bug#11583).
2883 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2885 Implement wave-style variant of underlining.
2886 * dispextern.h (face_underline_type): New enum.
2887 (face): Add field for underline type.
2888 * nsterm.m (ns_draw_underwave): New function.
2889 (ns_draw_text_decoration): Use it.
2890 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2892 (x_draw_glyph_string): Use them.
2893 * xfaces.c (Qline, Qwave): New Lisp objects.
2894 (check_lface_attrs, merge_face_ref)
2895 (Finternal_set_lisp_face_attribute, realize_x_face):
2896 Handle wave-style underline face attributes.
2897 * xterm.c (x_draw_underwave): New function.
2898 (x_draw_glyph_string): Use it.
2900 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2902 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2903 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2904 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2905 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2906 ($(BLD)/w32select.$(O)): Update dependencies.
2908 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2910 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2911 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2912 * character.c (_fetch_multibyte_char_p): Remove.
2913 * alloc.c: Include "character.h" before "buffer.h".
2915 * buffer.c: Likewise.
2916 * bytecode.c: Likewise.
2917 * callint.c: Likewise.
2918 * callproc.c: Likewise.
2919 * casefiddle.c: Likewise.
2920 * casetab.c: Likewise.
2921 * category.c: Likewise.
2923 * coding.c: Likewise.
2924 * composite.c: Likewise.
2925 * dired.c: Likewise.
2926 * dispnew.c: Likewise.
2928 * dosfns.c: Likewise.
2929 * editfns.c: Likewise.
2930 * emacs.c: Likewise.
2931 * fileio.c: Likewise.
2932 * filelock.c: Likewise.
2934 * fontset.c: Likewise.
2935 * fringe.c: Likewise.
2936 * indent.c: Likewise.
2937 * insdel.c: Likewise.
2938 * intervals.c: Likewise.
2939 * keyboard.c: Likewise.
2940 * keymap.c: Likewise.
2941 * lread.c: Likewise.
2942 * macros.c: Likewise.
2943 * marker.c: Likewise.
2944 * minibuf.c: Likewise.
2945 * nsfns.m: Likewise.
2946 * nsmenu.m: Likewise.
2947 * print.c: Likewise.
2948 * process.c: Likewise.
2949 * regex.c: Likewise.
2950 * region-cache.c: Likewise.
2951 * search.c: Likewise.
2952 * syntax.c: Likewise.
2954 * textprop.c: Likewise.
2956 * unexsol.c: Likewise.
2957 * w16select.c: Likewise.
2958 * w32fns.c: Likewise.
2959 * w32menu.c: Likewise.
2960 * window.c: Likewise.
2961 * xdisp.c: Likewise.
2963 * xmenu.c: Likewise.
2965 * xselect.c: Likewise.
2967 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2969 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2970 If all the glyphs of the glyph row came from strings, and we have no
2971 cursor positioning clues, put the cursor on the first glyph of the
2973 (handle_face_prop): Use chunk-relative overlay string index when
2974 indexing into it->string_overlays array. (Bug#11653)
2975 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2976 the rightmost. (Bug#11720)
2978 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2980 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2981 (CATEGORY_MEMBER): Enforce 1/0 value.
2982 * category.c (_temp_category_set): Remove.
2984 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2986 * window.c (Fdelete_other_windows_internal)
2987 (Fdelete_window_internal): Don't access frame's mouse highlight
2988 info of the initial frame. (Bug#11677)
2990 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2992 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2993 Assume USE_2_TAGS_FOR_INTS.
2994 (xreload): Adjust $tagmask width to match recent lisp.h change.
2996 Simplify lisp.h in minor ways that should not affect code.
2997 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2998 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2999 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3000 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3001 (INTTYPEBITS): New macro, for clarity.
3002 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
3003 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3004 Simplify now that USE_LSB_TAG is always defined.
3005 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3006 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3008 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
3010 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3012 2012-06-13 Glenn Morris <rgm@gnu.org>
3014 * s/bsd-common.h (BSD4_3):
3015 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3017 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3019 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3022 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3024 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
3025 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
3026 * alloc.c (widen_to_Lisp_Object): Remove.
3027 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3028 * frame.c (delete_frame): Remove outdated comment.
3029 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3030 USE_LISP_UNION_TYPE.
3031 (Fw32_unregister_hot_key): Likewise.
3032 (Fw32_toggle_lock_key): Likewise.
3033 * w32menu.c (add_menu_item): Likewise.
3034 (w32_menu_display_help): Use XIL instead of checking
3035 USE_LISP_UNION_TYPE.
3036 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3037 (init_heap): Likewise.
3038 * w32term.c (w32_read_socket): Update comment.
3040 2012-06-13 Glenn Morris <rgm@gnu.org>
3042 * s/usg5-4-common.h, src/s/unixware.h:
3043 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3045 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3047 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3049 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3050 * alloc.c (make_number) [!defined make_number]:
3051 Remove, as lisp.h always defines this now.
3052 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3053 (roundup_size): Verify that it is a power of 2.
3054 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3055 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3056 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3057 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3058 USE_LSB_TAG now is always defined to be either 0 or 1.
3060 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3061 code works fine either way, and efficiency is not a concern here,
3062 as the union type is for debugging, not for production.
3063 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3064 Use an inline function on all platforms when using the union type,
3065 since this is simpler and 'static inline' can be used portably
3067 (LISP_INITIALLY_ZERO): New macro.
3068 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3069 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3071 2012-06-12 Glenn Morris <rgm@gnu.org>
3073 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3075 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
3077 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3078 Move BROKEN_SIGIO to configure.
3080 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3081 Move NO_TERMIO to configure.
3083 2012-06-12 Chong Yidong <cyd@gnu.org>
3085 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3086 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3087 MagickExportImagePixels is undefined.
3089 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3091 * image.c (imagemagick_load_image): Remove unused label.
3093 2012-06-11 Glenn Morris <rgm@gnu.org>
3095 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3096 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3097 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3098 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3100 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3102 * alloc.c (make_byte_code): New function.
3103 (Fmake_byte_code): Use it. Don't purify here.
3104 * lread.c (read1): Use it as well to avoid extra allocation.
3106 2012-06-11 Chong Yidong <cyd@gnu.org>
3108 * image.c (imagemagick_load_image): Implement transparency.
3110 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3112 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3113 account for preceding backslashes. (Bug#11663)
3115 2012-06-09 Chong Yidong <cyd@gnu.org>
3117 * term.c: Support italics in capable terminals (Bug#9652).
3118 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3119 (turn_on_face): Output using TS_enter_italic_mode if available.
3120 Don't handle unused blinking and alt-charset cases.
3121 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3122 and tty_alt_charset_p cases.
3123 (tty_capable_p, init_tty): Support italics.
3125 * termchar.h (struct tty_display_info): Add field for italics.
3126 Remove unused blink field.
3128 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3131 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3132 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3133 tty_alt_charset_p. Add tty_italic_p.
3135 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
3137 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3138 dbus_type_is_basic if available.
3139 (xd_extract_signed, xd_extract_unsigned): Rename from
3140 extract_signed and extract_unsigned, respectively. Adapt callers.
3142 2012-06-09 Chong Yidong <cyd@gnu.org>
3144 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3146 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3149 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3151 * xdisp.c (vmessage): Treat frame message as multibyte.
3152 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3153 would generate the diagnostic "Making \302\247 buffer-local while
3156 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3158 * dispnew.c (showing_window_margins_p): Undo last change, which
3159 was done due to an inadvertent commit.
3160 (adjust_frame_glyphs_for_frame_redisplay): Do call
3161 showing_window_margins_p.
3163 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3165 * eval.c (Fmake_var_non_special): New primitive.
3166 (syms_of_eval): Defsubr it.
3167 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3169 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3171 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3172 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3174 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3176 * alloc.c (allocate_vectorlike): Fix last change.
3178 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3180 Block-based vector allocation of small vectors.
3181 * lisp.h (struct vectorlike_header): New field `nbytes',
3182 adjust comment accordingly.
3183 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3184 to denote vector blocks. Adjust users (live_vector_p,
3185 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3186 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3187 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3188 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3189 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3190 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3191 (roundup_size): New constant.
3192 (struct vector_block): New data type.
3193 (vector_blocks, vector_free_lists, zero_vector): New variables.
3194 (all_vectors): Rename to `large_vectors'.
3195 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3196 (sweep_vectors): New functions.
3197 (allocate_vectorlike): Return `zero_vector' as the only vector of
3198 0 items. Allocate new vector from block if vector size is less than
3199 or equal to VBLOCK_BYTES_MAX.
3200 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3201 (init_alloc_once): Add call to init_vectors.
3203 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3205 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3207 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3209 * doprnt.c (doprnt): Truncate multibyte char correctly.
3210 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3211 would mishandle a string argument "Xc" if X was a multibyte
3212 character of length 2: it would truncate after X's first byte
3213 rather than including all of X.
3215 2012-06-06 Chong Yidong <cyd@gnu.org>
3217 * buffer.c (word_wrap): Doc fix.
3219 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3221 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3223 2012-06-03 Glenn Morris <rgm@gnu.org>
3225 * xdisp.c (tool-bar-style): Doc fix.
3227 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3229 * Makefile.in (PAXCTL): Define.
3230 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3231 binary via PaX flags if the paxctl utility is available.
3232 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3233 Restore PaX flags to their default. (Bug#11398)
3235 2012-06-03 Chong Yidong <cyd@gnu.org>
3237 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3240 2012-06-03 Chong Yidong <cyd@gnu.org>
3242 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3243 (note_mode_line_or_margin_highlight): If there is no help echo,
3244 use mode-line-default-help-echo. Handle the case where the mouse
3245 position is past the end of the mode line string.
3247 * buffer.c (buffer_local_value_1): New function, split from
3248 Fbuffer_local_value; can return Qunbound.
3249 (Fbuffer_local_value): Use it.
3250 (Vmode_line_format): Docstring tweaks.
3252 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3254 * sysdep.c (system_process_attributes): Improve comment.
3256 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3258 * keyboard.c: Export real-this-command to Elisp.
3259 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3260 and DEFVAR it. Update all users.
3262 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3264 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3266 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3267 Convert pctcpu and pctmem to Lisp float properly.
3268 Let the compiler fold better, as 100.0/0x8000 is exact.
3270 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3272 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3275 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3277 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3279 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3281 For a 'struct window', replace some Lisp_Object fields to
3282 bitfields where appropriate, remove unused fields.
3283 * window.h (struct window): Remove unused 'last_mark_x' and
3284 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3285 change it's type from Lisp_Object to bitfield.
3286 Change type of 'force_start', 'optional_new_start',
3287 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3288 fields from Lisp_Object to bitfield. Adjust users accordingly.
3290 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3292 Pacify gcc -Wdouble-precision when using Xaw.
3293 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3294 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3295 Use 'float' consistently, rather than 'float' in most places
3296 and 'double' in a couple of places.
3298 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3300 * xdisp.c (handle_stop): Detect whether we have overlay strings
3301 loaded by testing it->current.overlay_string_index to be
3302 non-negative, instead of checking whether n_overlay_strings is
3303 positive. (Bug#11587)
3305 2012-05-31 Chong Yidong <cyd@gnu.org>
3307 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3309 * doc.c (Fsubstitute_command_keys): Doc fix.
3311 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3313 * search.c (search_buffer): Remove calls to
3314 r_alloc_inhibit_buffer_relocation, as it is now called by
3315 maybe_unify_char, which was the cause of relocation of buffer text
3318 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3320 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3321 for the duration of call to load_charset, to avoid problems with
3322 callers of maybe_unify_char that access buffer text through C
3325 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3326 decrement the inhibition flag, instead of just setting or
3329 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3331 Remove obsolete '#define static' cruft.
3332 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3333 This #undef was "temporary" in 2000; it is no longer needed
3334 now that '#define static' has gone away.
3335 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3336 (gray_bitmap_bits): Remove; no longer needed.
3337 All uses replaced with definiens.
3338 * xterm.c: Include "bitmaps/gray.xbm".
3340 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3342 Clean up __executable_start, monstartup when --enable-profiling.
3343 The following changes affect the code only when profiling.
3344 * dispnew.c (__executable_start): Rename from safe_bcopy.
3345 Define only on platforms that need it.
3346 * emacs.c: Include <sys/gmon.h> when profiling.
3347 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3348 (__executable_start): Remove decl, since lisp.h does it now.
3349 (safe_bcopy): Remove decl; no longer has that name.
3350 (main): Coalesce #if into single bit of code, for simplicity.
3351 Cast pointers to uintptr_t, since standard libraries want integers
3353 * lisp.h (__executable_start): New decl.
3355 2012-05-31 Glenn Morris <rgm@gnu.org>
3357 * image.c (Fimagemagick_types): Doc fix.
3359 2012-05-30 Jim Meyering <meyering@redhat.com>
3361 * callproc.c (Fcall_process_region): Include directory component
3362 in mkstemp error message (Bug#11586).
3364 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3366 * alloc.c, lisp.h (make_pure_vector): Now static.
3368 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3370 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3371 Move to byte-run.el.
3372 (Fautoload): Do the hash-doc more carefully.
3373 * data.c (Fdefalias): Purify definition, except for keymaps.
3374 (Qdefun): Move from eval.c.
3375 * lisp.h (Qdefun): Remove.
3376 * lread.c (read1): Tiny simplification.
3378 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3380 Do not create empty overlays with the evaporate property (Bug#9642).
3381 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3382 Bug#9642, but explicitly check that the buffer the overlay would
3383 be moved to is live and rearrange lines to make sure that errors
3384 will not put the overlay in an inconsistent state.
3385 (Fdelete_overlay): Cosmetics.
3387 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3389 * w32term.c (my_bring_window_to_top): New function.
3390 (x_raise_frame): Use handle returned by DeferWindowPos, which
3391 could be different from the original one.
3392 Call my_bring_window_to_top instead of my_set_foreground_window.
3395 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3396 by calling BringWindowToTop.
3398 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3399 (WM_EMACS_END): Increase by one.
3401 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3403 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3404 This avoids undefined behavior that might cause the eassert
3405 to not catch an out-of-range value.
3407 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3409 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3410 Update dependencies.
3412 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3414 * bidi.c (bidi_mirror_char): Fix last change.
3416 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3418 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3419 when referring to sectname field in printf format.
3421 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3423 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3424 Only r_alloc_inhibit_buffer_relocation needed to be added;
3425 the others were already declared.
3427 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3428 before checking whether it's out of range. Put the check inside
3430 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3432 2012-05-27 Ken Brown <kbrown@cornell.edu>
3434 * callproc.c (Fcall_process): Restore a line that was accidentally
3435 commented out in the 2011-02-13 change (bug#11547).
3437 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3439 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3440 defined on ralloc.c.
3442 * buffer.c [REL_ALLOC]: Remove prototypes of
3443 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3444 they are now on lisp.h.
3446 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3448 * search.c (search_buffer): Use it to inhibit relocation of buffer
3449 text while re_search_2 is doing its job, because re_search_2 is
3450 passed C pointers to buffer text. (Bug#11519)
3452 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3455 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3456 state after an additional call to move_it_in_display_line_to, keep
3457 the values of it->max_ascent and it->max_descent found for the
3459 (pos_visible_p): Revert the comparison against bottom_y to what it
3460 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3463 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3465 Fix coding-related core dumps with gcc -ftrapv.
3466 The code was computing A - B, where A and B are pointers, and B is
3467 random garbage. This can lead to core dumps on platforms that
3468 have special pointer registers, and it also leads to core dumps on
3469 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3470 A - B only when B is initialized properly.
3471 * coding.c (coding_set_source, coding_set_destination): Return void.
3472 (coding_change_source, coding_change_destinations): New functions,
3473 with the old behaviors of coding_set_source and coding_set_destination.
3474 All callers that need an offset changed to use these new functions.
3476 2012-05-26 Glenn Morris <rgm@gnu.org>
3478 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3480 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3482 Extend mouse support on W32 text-mode console.
3483 * xdisp.c (draw_row_with_mouse_face):
3484 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3486 * w32console.c: Include window.h.
3487 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3489 (initialize_w32_display): Initialize mouse-highlight data.
3491 * w32inevt.c: Include termchar.h and window.h.
3492 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3493 moves, call note_mouse_highlight. If help_echo changed, call
3494 gen_help_event to produce help-echo message in the echo area.
3495 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3498 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3500 * lread.c (read1): Simplify slightly to avoid an overflow warning
3501 with GCC 4.7.0 on x86-64.
3503 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3505 * bidi.c (bidi_mirror_char): Revert last change: an int is
3506 definitely wide enough here.
3508 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3510 Fix integer width and related bugs (Bug#9874).
3511 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3512 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3513 (string_bytes, check_sblock, allocate_string_data):
3514 (compact_small_strings, Fmake_bool_vector, make_string)
3515 (make_unibyte_string, make_multibyte_string)
3516 (make_string_from_bytes, make_specified_string)
3517 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3518 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3521 (allocate_pseudovector):
3522 Use int, not EMACS_INT, where int is wide enough.
3523 (inhibit_garbage_collection, Fgarbage_collect):
3524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3525 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3526 int might not be wide enough.
3527 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3528 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3529 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3530 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3531 (bidi_level_of_next_char, bidi_move_to_visually_next):
3532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3533 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3534 (Fkill_buffer, Fset_buffer_major_mode)
3535 (advance_to_char_boundary, Fbuffer_swap_text)
3536 (Fset_buffer_multibyte, overlays_at, overlays_in)
3537 (overlay_touches_p, struct sortvec, record_overlay_string)
3538 (overlay_strings, recenter_overlay_lists)
3539 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3540 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3541 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3542 (Foverlay_recenter, last_overlay_modification_hooks_used)
3543 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3545 (validate_region): Omit unnecessary test for b <= e,
3546 since that's guaranteed by the previous test.
3547 (adjust_overlays_for_delete): Avoid pos + length overflow.
3548 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3549 (report_overlay_modification):
3550 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3551 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3552 Omit pointer cast, which isn't needed anyway, and doesn't work
3553 after the EMACS_INT -> ptrdiff_t change.
3554 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3555 * buffer.h: Adjust decls to match defn changes elsewhere.
3556 (struct buffer_text, struct buffer):
3557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3558 Use EMACS_INT, not int, where int might not be wide enough.
3559 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3560 not int, to avoid needless 32-bit limit on 64-bit hosts.
3561 (exec_byte_code): Use tighter memory-full test, one that checks
3562 for alloca overflow. Don't compute the address of the object just
3563 before an array, as that's not portable. Use EMACS_INT, not
3564 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3565 * callint.c (Fcall_interactively):
3566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3567 * callproc.c (call_process_kill, Fcall_process):
3568 Don't assume pid_t fits into an Emacs fixnum.
3569 (call_process_cleanup, Fcall_process, child_setup):
3570 Don't assume pid_t fits into int.
3571 (call_process_cleanup, Fcall_process, delete_temp_file)
3572 (Fcall_process_region):
3573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3574 (Fcall_process): Simplify handling of volatile integers.
3575 Use int, not EMACS_INT, where int will do.
3576 * casefiddle.c (casify_object, casify_region, operate_on_word)
3577 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3579 (casify_object): Avoid integer overflow when overallocating buffer.
3580 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3581 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3582 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3583 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3584 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3585 integers are now checked earlier. All uses replaced with XINT.
3587 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3588 For CCL_MapSingle, check that content and value are in int range.
3589 (ccl_driver, Fregister_code_conversion_map):
3590 Check that Vcode_version_map_vector is a vector.
3591 (resolve_symbol_ccl_program): Check that vector header is in range.
3592 Always copy the vector, so that we can check its contents reliably
3593 now rather than having to recheck each instruction as it's being
3594 executed. Check that vector words fit in 'int'.
3595 (ccl_get_compiled_code, Fregister_ccl_program)
3596 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3597 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3598 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3599 contents are in range.
3600 (Fccl_execute_on_string): Check that status is in range.
3601 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3602 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3603 Accept and return EMACS_INT, not int, because callers can pass values
3605 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3606 (multibyte_chars_in_text, parse_str_as_multibyte)
3607 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3608 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3609 (string_escape_byte8, Fget_byte):
3610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3611 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3612 avoid mishandling large integers.
3613 * character.h: Adjust decls to match defn changes elsewhere.
3614 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3615 (Ffind_charset_region):
3616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3617 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3618 (load_charset_map_from_vector, Fdefine_charset_internal):
3619 Don't assume fixnum fits in int.
3620 (load_charset_map_from_vector, Fmap_charset_chars):
3621 Remove now-unnecessary CHECK_NATNUMs.
3622 (Fdefine_charset_internal): Check ranges here, more carefully.
3623 Don't rely on undefined behavior with signed left shift overflow.
3624 Don't assume unsigned int fits into fixnum, or that fixnum fits
3625 into unsigned int. Don't require max_code to be a valid fixnum;
3626 that's not true for gb10830 4-byte on a 32-bit host. Allow
3627 invalid_code to be a cons, for the same reason. Require code_offset
3628 to be a character. Avoid int overflow if max_char is close
3630 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3631 this is intended anyway and avoids some undefined behavior.
3632 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3633 INDEX_TO_CODE_POINT, as that's what it expects.
3634 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3635 * charset.h (DECODE_CHAR): Return int, not unsigned;
3636 this is what was intended anyway, and it avoids undefined behavior.
3637 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3638 integer-overflow issues.
3639 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3640 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3641 where the argument is EMACS_INT, and this behavior is not intended.
3642 * chartab.c (Fmake_char_table, Fset_char_table_range)
3643 (uniprop_get_decoder, uniprop_get_encoder):
3644 Don't assume fixnum fits in int.
3645 * cmds.c (move_point): New function, that does the gist of
3646 Fforward_char and Fbackward_char, but does so while checking
3647 for integer overflow more accurately.
3648 (Fforward_char, Fbackward_char): Use it.
3649 (Fforward_line, Fend_of_line, internal_self_insert)
3650 (internal_self_insert):
3651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3652 Fix a FIXME, by checking for integer overflow when calculating
3653 target_clm and actual_clm.
3654 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3655 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3656 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3657 (coding_alloc_by_making_gap, alloc_destination)
3658 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3659 (encode_coding_utf_16, detect_coding_emacs_mule)
3660 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3661 (detect_coding_iso_2022, decode_coding_iso_2022)
3662 (encode_invocation_designation, encode_designation_at_bol)
3663 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3664 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3665 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3666 (encode_coding_ccl, encode_coding_raw_text)
3667 (detect_coding_charset, decode_coding_charset)
3668 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3669 (produce_composition, produce_charset, produce_annotation)
3670 (decode_coding, handle_composition_annotation)
3671 (handle_charset_annotation, consume_chars, decode_coding_gap)
3672 (decode_coding_object, encode_coding_object, detect_coding_system)
3673 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3674 (code_convert_region, code_convert_string)
3675 (Fdefine_coding_system_internal)
3676 (coding_set_source, coding_set_destination):
3677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3678 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3679 (Fdefine_coding_system_internal):
3680 Don't assume fixnums fit in int.
3681 (decode_coding_gap, decode_coding_object, encode_coding_object)
3682 (Fread_coding_system, Fdetect_coding_region)
3683 (Funencodable_char_position, Fcheck_coding_systems_region)
3684 (get_translation, handle_composition_annotation, consume_chars):
3685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3686 (consume_chars): Rewrite to not calculate an address outside buffer.
3687 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3688 Don't access memory outside of the args array.
3689 (Fdefine_coding_system_internal): Check for charset-id overflow.
3690 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3691 result of ENCODE_CHAR.
3692 * coding.h: Adjust decls to match defn changes elsewhere.
3693 (struct coding_system):
3694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3695 * composite.c (get_composition_id, find_composition)
3696 (run_composition_function, update_compositions)
3697 (compose_text, composition_gstring_put_cache)
3698 (composition_gstring_p, composition_gstring_width)
3699 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3700 (composition_compute_stop_pos, composition_reseat_it)
3701 (composition_update_it, struct position_record)
3702 (find_automatic_composition, composition_adjust_point)
3703 (Fcomposition_get_gstring, Ffind_composition_internal):
3704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3705 (update_compositions):
3706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3707 * composite.h: Adjust decls to match defn changes elsewhere.
3708 (struct composition):
3709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3710 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3711 Do not attempt to compute the address of the object just before a
3712 buffer; this is not portable.
3714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3715 (Faset): Use int, not EMACS_INT, where int is wide enough.
3716 (Fstring_to_number): Don't assume fixnums fit in int.
3717 (Frem): Don't assume arg is nonnegative.
3718 * dbusbind.c (xd_append_arg): Check for integers out of range.
3719 (Fdbus_call_method): Don't overflow the timeout int.
3720 (extract_signed, extract_unsigned): New functions.
3721 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3722 (xd_get_connection_references): Return ptrdiff_t, not int.
3724 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3725 (xd_read_message_1):
3726 Use int, not unsigned, where the dbus API uses int.
3727 (Fdbus_message_internal): Don't overflow mtype.
3728 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3729 * dired.c (directory_files_internal, file_name_completion, scmp)
3730 (file_name_completion_stat):
3731 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3732 (file_name_completion): Don't overflow matchcount.
3733 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3734 * dispextern.h: Adjust decls to match defn changes elsewhere.
3735 (struct text_pos, struct glyph, struct bidi_saved_info)
3736 (struct bidi_string_data, struct bidi_it, struct composition_it)
3738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3739 (struct display_pos, struct composition_it, struct it):
3740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3741 * dispnew.c (increment_matrix_positions)
3742 (increment_row_positions, mode_line_string)
3743 (marginal_area_string):
3744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3745 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3747 (duration_to_sec_usec): New function, to check for overflow better.
3748 (Fsleep_for, sit_for): Use it.
3749 * doc.c (get_doc_string, store_function_docstring):
3750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3751 (get_doc_string, Fsnarf_documentation):
3752 Use int, not EMACS_INT, where int is wide enough.
3754 Use SAFE_ALLOCA, not alloca.
3755 Check for overflow when converting EMACS_INT to off_t.
3756 * doprnt.c (doprnt):
3757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3758 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3759 Don't assume uid_t fits into fixnum.
3760 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3761 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3762 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3763 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3764 (general_insert_function)
3765 (Finsert_char, make_buffer_string, make_buffer_string_both)
3766 (update_buffer_properties, Fbuffer_substring)
3767 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3768 (Fsubst_char_in_region, check_translation)
3769 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3770 (transpose_markers, Ftranspose_regions):
3771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3772 (clip_to_bounds): Move to lisp.h as an inline function).
3773 (Fconstrain_to_field): Don't assume integers are nonnegative.
3774 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3775 (Fsubst_char_in_region, Fsave_restriction):
3776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3777 (Femacs_pid): Don't assume pid_t fits into fixnum.
3778 (lo_time): Use int, not EMACS_INT, when int suffices.
3779 (lisp_time_argument): Check for usec out of range.
3780 (Fencode_time): Don't assume fixnum fits in int.
3781 (Fuser_login_name, Fuser_full_name): Signal an error
3782 if a uid argument is out of range, rather than relying on
3784 (Fformat_time_string): Remove now-unnecessary check.
3785 lisp_time_argument checks for out-of-range usec now.
3786 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3787 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3788 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3789 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3790 (init_cmdargs, Fdump_emacs):
3791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3792 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3793 the bottom (typically) 32 bits of the fixnum.
3794 * eval.c (specpdl_size, call_debugger):
3795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3796 (when_entered_debugger, Fbacktrace_debug):
3797 Don't assume fixnum can fit in int.
3798 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3799 the object just before a buffer; this is not portable.
3800 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3801 (grow_specpdl, unbind_to):
3802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3803 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3804 (grow_specpdl): Simplify allocation by using xpalloc.
3805 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3806 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3807 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3809 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3812 (Fcopy_file, non_regular_nbytes, read_non_regular)
3813 (Finsert_file_contents):
3814 Use int, not EMACS_INT, where int is wide enough.
3815 (READ_BUF_SIZE): Verify that it fits in int.
3816 (Finsert_file_contents): Check that counts are in proper range,
3817 rather than assuming fixnums fit into ptrdiff_t etc.
3818 Don't assume fixnums fit into int.
3819 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3820 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3821 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3822 (string_char_to_byte, string_byte_to_char)
3823 (string_make_multibyte, string_to_multibyte)
3824 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3825 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3826 (substring_both, Fdelete, internal_equal, Ffillarray)
3827 (Fclear_string, mapcar1)
3828 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3829 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3830 (larger_vector, make_hash_table, maybe_resize_hash_table)
3831 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3832 (Fmaphash, secure_hash):
3833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3834 (concat): Check for string index and length overflow.
3835 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3838 (larger_vector): New API (vec, incr_min, size_max) replaces old
3839 one (vec, new_size, init). This catches size overflow.
3840 INIT was removed because it was always Qnil.
3841 All callers changed.
3842 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3843 the upper bound on a hash table index size.
3844 (make_hash_table, maybe_resize_hash_table): Use it.
3845 (secure_hash): Computer start_byte and end_byte only after
3846 they're known to be in ptrdiff_t range.
3847 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3848 (Ffont_get_glyphs, Ffont_at):
3849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3850 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3851 (Flist_fonts, Fopen_font):
3852 Don't assume fixnum can fit in int.
3853 (check_gstring): Don't assume index can fit in int.
3854 (font_match_p): Check that fixnum is a character, not a nonnegative
3855 fixnum, since the later code needs to stuff it into an int.
3856 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3857 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3858 conversion overflow issues.
3859 (Fopen_font): Check for integer out of range.
3860 (Ffont_get_glyphs): Don't assume index can fit in int.
3861 * font.h: Adjust decls to match defn changes elsewhere.
3862 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3864 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3865 printmax_t, where ptrdiff_t is wide enough.
3866 (Finternal_char_font):
3867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3868 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3869 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3870 (Fset_frame_position, x_set_frame_parameters)
3871 (x_set_line_spacing, x_set_border_width)
3872 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3873 Check that fixnums are in proper range for system types.
3874 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3876 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3877 Use SAFE_ALLOCA_LISP, not alloca.
3878 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3879 intptr_t is wide enough.
3880 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3881 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3882 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3883 Check for fixnum out of range.
3884 * ftfont.c (ftfont_list): Don't assume index fits in int.
3885 Check that fixnums are in proper range for system types.
3886 (ftfont_shape_by_flt):
3887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3888 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3890 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3891 Check that fixnums are in proper range for system types.
3892 * gnutls.h: Adjust decls to match defn changes elsewhere.
3893 * gtkutil.c (xg_dialog_run):
3894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3895 (update_frame_tool_bar):
3896 Check that fixnums are in proper range for system types.
3897 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3898 (lookup_image): Check that fixnums are in range for system types.
3899 * indent.c (last_known_column, last_known_column_point):
3900 (current_column_bol_cache):
3901 (skip_invisible, current_column, check_display_width):
3902 (check_display_width, scan_for_column, current_column_1)
3903 (Findent_to, Fcurrent_indentation, position_indentation)
3904 (indented_beyond_p, Fmove_to_column, compute_motion):
3905 (Fcompute_motion, Fvertical_motion):
3906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3907 (last_known_column_modified): Use EMACS_INT, not int.
3908 (check_display_width):
3910 Check that fixnums and floats are in proper range for system types.
3911 (compute_motion): Don't assume index or fixnum fits in int.
3912 (compute_motion, Fcompute_motion):
3913 Use int, not EMACS_INT, when it is wide enough.
3914 (vmotion): Omit local var start_hpos that is always 0; that way
3915 we don't need to worry about overflow in expressions involving it.
3916 * indent.h: Adjust decls to match defn changes elsewhere.
3918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3919 Use int, not EMACS_INT, where int is wide enough.
3920 Remove unused members ovstring_chars_done and tab_offset;
3922 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3923 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3924 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3925 (make_gap, copy_text, insert, insert_and_inherit)
3926 (insert_before_markers, insert_before_markers_and_inherit)
3927 (insert_1, count_combining_before, count_combining_after)
3928 (insert_1_both, insert_from_string)
3929 (insert_from_string_before_markers, insert_from_string_1)
3930 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3931 (adjust_after_replace, adjust_after_insert, replace_range)
3932 (replace_range_2, del_range, del_range_1, del_range_byte)
3933 (del_range_both, del_range_2, modify_region)
3934 (prepare_to_modify_buffer, signal_before_change)
3935 (signal_after_change, Fcombine_after_change_execute):
3936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3937 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3938 (balance_an_interval, split_interval_right, split_interval_left)
3939 (find_interval, next_interval, update_interval)
3940 (adjust_intervals_for_insertion, delete_node, delete_interval)
3941 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3942 (static_offset_intervals, offset_intervals)
3943 (merge_interval_right, merge_interval_left, make_new_interval)
3944 (graft_intervals_into_buffer, temp_set_point_both)
3945 (temp_set_point, set_point, adjust_for_invis_intang)
3946 (set_point_both, move_if_not_intangible, get_property_and_range)
3947 (get_local_map, copy_intervals, copy_intervals_to_string)
3948 (compare_string_intervals, set_intervals_multibyte_1):
3949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3950 * intervals.h: Adjust decls to match defn changes elsewhere.
3952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3953 * keyboard.c (this_command_key_count, this_single_command_key_start)
3954 (before_command_key_count, before_command_echo_length, echo_now)
3955 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3956 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3957 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3958 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3960 (last_non_minibuf_size, last_point_position, echo_truncate)
3961 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3962 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3963 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3964 (stuff_buffered_input):
3965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3966 (last_auto_save, command_loop_1, read_char):
3967 Use EMACS_INT, not int, to avoid integer overflow.
3968 (record_char): Avoid overflow in total_keys computation.
3969 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3970 * keyboard.h: Adjust decls to match defn changes elsewhere.
3971 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3972 (Fkey_description, Fdescribe_vector, Flookup_key):
3973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3974 (click_position): New function, to check that positions are in range.
3975 (Fcurrent_active_maps):
3977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3978 (Faccessible_keymaps, Fkey_description):
3979 (preferred_sequence_p):
3980 Don't assume fixnum can fit into int.
3981 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3982 Check for integer overflow in size calculations.
3983 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3984 avoid mishandling large integers.
3985 * lisp.h: Adjust decls to match defn changes elsewhere.
3986 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3987 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3988 (struct Lisp_Marker):
3989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3990 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3991 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3992 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3993 All callers changed.
3994 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3995 Assume the arg has valid form, since it always does.
3996 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3997 unsigned integer system type.
3998 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3999 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4001 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4002 (duration_to_sec_usec): New decl.
4003 * lread.c (read_from_string_index, read_from_string_index_byte)
4004 (read_from_string_limit, readchar, unreadchar, openp)
4005 (read_internal_start, read1, oblookup):
4006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4007 (Fload, readevalloop, Feval_buffer, Feval_region):
4008 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4009 (openp): Check for out-of-range argument to 'access'.
4010 (read1): Use int, not EMACS_INT, where int is wide enough.
4011 Don't assume fixnum fits into int.
4012 Fix off-by-one error that can read outside a buffer.
4013 (read_filtered_event): Use duration_to_sec_usec
4014 to do proper overflow checking on durations.
4015 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4016 in size calculation.
4017 (Fexecute_kbd_macro):
4018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4019 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4020 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4021 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4022 (set_marker_both, set_marker_restricted_both, marker_position)
4023 (marker_byte_position, Fbuffer_has_markers_at):
4024 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4025 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
4026 * menu.c (ensure_menu_items): Rename from grow_menu_items.
4027 It now merely ensures that the menu is large enough, without
4028 necessarily growing it, as this avoids some integer overflow issues.
4029 All callers changed.
4030 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4031 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4032 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4033 Use SAFE_ALLOCA_LISP, not alloca.
4034 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4035 to EMACS_INT. Check that fixnums are in proper range for system types.
4036 * minibuf.c (minibuf_prompt_width, string_to_object)
4037 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4038 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4040 (get_minibuffer, read_minibuf_unwind):
4041 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4042 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4043 this simplifies overflow checking. All callers changed.
4044 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4046 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4047 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4048 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4049 Check that fixnums are in proper range for system types.
4050 (Fx_create_frame, Fx_show_tip):
4051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4052 * nsfont.m (ns_findfonts, nsfont_list_family):
4053 Don't assume fixnum fits in long.
4054 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4056 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4058 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
4059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4060 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4061 (PRINTDECLARE, PRINTPREPARE):
4062 (strout, print_string):
4063 (print, print_preprocess, print_check_string_charset_prop)
4065 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4067 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4068 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4069 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
4070 (printchar, strout): Use xpalloc to catch size calculation overflow.
4071 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
4072 (print_error_message): Use SAFE_ALLOCA, not alloca.
4073 (print_object): Use int, not EMACS_INT, where int is wide enough.
4074 (print_depth, new_backquote_output, print_number_index):
4075 Use ptrdiff_t, not int, where int might not be wide enough.
4076 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4077 (Fset_process_window_size, Fformat_network_address)
4078 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
4080 Check that fixnums are in proper range for system types.
4081 (Fsignal_process): Simplify by avoiding a goto.
4082 Check for process-ids out of pid_t range rather than relying on
4084 (process_tick, update_tick): Use EMACS_INT, not int.
4085 (Fformat_network_address, read_process_output, send_process)
4086 (Fprocess_send_region, status_notify):
4087 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4088 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4089 (wait_reading_process_output, read_process_output, exec_sentinel):
4090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4091 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4092 (Faccept_process_output): Use duration_to_sec_usec to do proper
4093 overflow checking on durations.
4094 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4095 Don't assume pid_t fits in int.
4096 * process.h (struct Lisp_Process): Members tick and update_tick
4097 are now of type EMACS_INT, not int.
4098 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4099 configured --with-wide-int.
4100 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4101 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4102 * search.c (looking_at_1, string_match_1):
4103 (fast_string_match, fast_c_string_match_ignore_case)
4104 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4105 (scan_newline, find_before_next_newline, search_command)
4106 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4107 (set_search_regs, wordify):
4110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4111 (string_match_1, search_buffer, set_search_regs):
4113 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4114 (wordify): Check for overflow in size calculation.
4115 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4116 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4117 Check that fixnums are in proper range for system types.
4118 * sound.c (struct sound_device)
4119 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4121 (Fplay_sound_internal):
4122 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4123 * syntax.c (struct lisp_parse_state, find_start_modiff)
4124 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4125 (Fparse_partial_sexp):
4126 Don't assume fixnums can fit in int.
4127 (struct lisp_parse_state, find_start_pos, find_start_value)
4128 (find_start_value_byte, find_start_begv)
4129 (update_syntax_table, char_quoted, dec_bytepos)
4130 (find_defun_start, prev_char_comend_first, back_comment):
4131 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4132 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4134 (Finternal_describe_syntax_value): Check that match_lisp is a
4135 character, not an integer, since the code stuffs it into int.
4136 (scan_words, scan_sexps_forward):
4137 Check that fixnums are in proper range for system types.
4139 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4140 (scan_sexps_forward):
4141 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4142 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4143 * syntax.h: Adjust decls to match defn changes elsewhere.
4144 (struct gl_state_s):
4145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4146 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4147 MOST_POSITIVE_FIXNUM.
4148 * sysdep.c (wait_for_termination_1, wait_for_termination)
4149 (interruptible_wait_for_termination, mkdir):
4150 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4151 (emacs_read, emacs_write):
4152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4153 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4154 and double all fit in int.
4155 * term.c (set_tty_color_mode):
4156 Check that fixnums are in proper range for system types.
4157 * termhooks.h (struct input_event):
4158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4159 * textprop.c (validate_interval_range, interval_of)
4160 (Fadd_text_properties, set_text_properties_1)
4161 (Fremove_text_properties, Fremove_list_of_text_properties)
4162 (Ftext_property_any, Ftext_property_not_all)
4163 (copy_text_properties, text_property_list, extend_property_ranges)
4164 (verify_interval_modification):
4165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4166 (Fnext_single_char_property_change)
4167 (Fprevious_single_char_property_change):
4168 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4169 (copy_text_properties):
4170 Check for integer overflow in index calculation.
4171 * undo.c (last_boundary_position, record_point, record_insert)
4172 (record_delete, record_marker_adjustment, record_change)
4173 (record_property_change):
4174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4175 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4177 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4178 (Fx_hide_tip, Fx_file_dialog):
4179 * w32menu.c (set_frame_menubar):
4180 Use ptrdiff_t, not int, for consistency with rest of code.
4181 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4182 (select_window, Fdelete_other_windows_internal)
4183 (window_scroll_pixel_based, window_scroll_line_based)
4184 (Frecenter, Fset_window_configuration):
4185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4186 (Fset_window_hscroll, run_window_configuration_change_hook)
4187 (set_window_buffer, temp_output_buffer_show, scroll_command)
4188 (Fscroll_other_window, Frecenter):
4189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4190 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4191 Don't assume fixnum fits in int.
4192 (Fset_window_scroll_bars):
4193 Check that fixnums are in proper range for system types.
4194 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4195 (string_pos, c_string_pos, number_of_chars, init_iterator)
4196 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4197 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4198 (compute_display_string_end, handle_face_prop)
4199 (face_before_or_after_it_pos, handle_invisible_prop)
4200 (handle_display_prop, handle_display_spec, handle_single_display_spec)
4201 (display_prop_intangible_p, string_buffer_position_lim)
4202 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4203 (get_overlay_strings_1, get_overlay_strings)
4204 (iterate_out_of_display_property, forward_to_next_line_start)
4205 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4206 (get_next_display_element, set_iterator_to_next)
4207 (get_visually_first_element, compute_stop_pos_backwards)
4208 (handle_stop_backwards, next_element_from_buffer)
4209 (move_it_in_display_line_to, move_it_in_display_line)
4210 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4211 (add_to_log, message_dolog, message_log_check_duplicate)
4212 (message2, message2_nolog, message3, message3_nolog
4213 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4214 (current_message_1, truncate_echo_area, truncate_message_1)
4215 (set_message, set_message_1, store_mode_line_noprop)
4216 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4217 (text_outside_line_unchanged_p, check_point_in_composition)
4218 (reconsider_clip_changes)
4219 (redisplay_internal, set_cursor_from_row, try_scrolling)
4220 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4221 (redisplay_window, find_last_unchanged_at_beg_row)
4222 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4223 (trailing_whitespace_p, find_row_edges, display_line)
4224 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4225 (display_mode_element, store_mode_line_string)
4226 (pint2str, pint2hrstr, decode_mode_spec)
4227 (display_count_lines, display_string, draw_glyphs)
4228 (x_produce_glyphs, x_insert_glyphs)
4229 (rows_from_pos_range, mouse_face_from_buffer_pos)
4230 (fast_find_string_pos, mouse_face_from_string_pos)
4231 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4233 (safe_call, init_from_display_pos, handle_fontified_prop)
4234 (handle_single_display_spec, load_overlay_strings)
4235 (with_echo_area_buffer, setup_echo_area_for_printing)
4236 (display_echo_area, echo_area_display)
4237 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4238 (update_tool_bar, hscroll_window_tree, redisplay_internal)
4239 (redisplay_window, dump_glyph_row, display_mode_line)
4240 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
4241 (handle_display_spec, display_prop_string_p):
4242 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4243 (handle_single_display_spec, build_desired_tool_bar_string)
4244 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4245 (get_specified_cursor_type):
4246 Check that fixnums are in proper range for system types.
4247 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4248 (Flookup_image_map):
4249 Don't assume fixnums fit in int.
4250 (compare_overlay_entries):
4251 Avoid mishandling comparisons due to subtraction overflow.
4252 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4253 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4254 (handle_tool_bar_click):
4255 Use int, not unsigned, since we prefer signed and the signedness
4256 doesn't matter here.
4257 (get_next_display_element, next_element_from_display_vector):
4258 Use int, not EMACS_INT, when int is wide enough.
4259 (start_hourglass): Use duration_to_sec_usec to do proper
4260 overflow checking on durations.
4261 * xfaces.c (Fbitmap_spec_p):
4262 Check that fixnums are in proper range for system types.
4263 (compare_fonts_by_sort_order):
4264 Avoid mishandling comparisons due to subtraction overflow.
4265 (Fx_family_fonts, realize_basic_faces):
4266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4268 Don't assume fixnum fits in int.
4269 Use SAFE_ALLOCA_LISP, not alloca.
4270 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4271 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4272 (face_at_buffer_position, face_for_overlay_string)
4273 (face_at_string_position):
4274 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4275 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4276 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4278 Check that fixnums are in proper range for system types.
4279 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4280 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4281 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4282 (Fx_change_window_property): Don't assume fixnums fit in int.
4283 * xfont.c (xfont_chars_supported):
4284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4285 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4286 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4287 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4288 * xml.c (parse_region):
4289 * xrdb.c (magic_file_p):
4290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4291 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4292 (x_get_local_selection, x_reply_selection_request)
4293 (x_handle_selection_request, wait_for_property_change):
4294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4295 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4296 short is wide enough.
4297 (x_send_client_event): Don't assume fixnum fits in int.
4298 * xterm.c (x_x_to_emacs_modifiers):
4299 Don't assume EMACS_INT overflows nicely into int.
4300 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4302 (handle_one_xevent): NATNUMP can eval its arg twice.
4303 (x_connection_closed):
4304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4305 * xterm.h: Adjust decls to match defn changes elsewhere.
4306 (struct scroll_bar): Use struct vectorlike_header
4307 rather than rolling our own approximation.
4308 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4310 2012-05-25 Glenn Morris <rgm@gnu.org>
4312 * lisp.mk (lisp): Update for more files being compiled now.
4314 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4316 * lread.c: Remove `read_pure' which makes no difference.
4317 (read_pure): Remove var.
4318 (unreadpure): Remove function.
4319 (readevalloop): Don't call read_list with -1 flag.
4320 (read1, read_vector): Don't test read_pure any more.
4321 (read_list): Simplify.
4323 * fileio.c, character.h: Minor style tweaks.
4325 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4327 * window.h (clip_changed): Remove useless declaration.
4329 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4331 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4332 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4334 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4337 This directory predates autoconf and is no longer needed nowadays.
4338 Move its few remaining bits of functionality to where they're needed.
4339 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4340 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4341 * m/template.h: Remove.
4342 * Makefile.in (M_FILE): Remove. All uses removed.
4343 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4344 * lisp.h (USE_LSB_TAG):
4345 * mem-limits.h (EXCEEDS_LISP_PTR):
4346 Use VAL_MAX, not VALBITS, in #if.
4347 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4348 (EMACS_UINT): Define unconditionally now.
4349 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4350 (BITS_PER_EMACS_INT): New constants, replacing
4351 what used to be in config.h, but not useful in #if.
4352 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4353 define them any more.
4354 (VAL_MAX): New macro.
4356 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4357 BITS_PER_EMACS_INT, in #if.
4358 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4359 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4360 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4361 * s/ms-w32.h (DATA_START):
4362 Move here from removed file m/intel386.h.
4363 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4364 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4366 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4368 Assume C89 or later.
4369 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4370 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4372 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4373 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4374 * textprop.c, tparam.c (NULL): Remove.
4375 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4376 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4377 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4378 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4379 * xterm.c (input_signal_count): Assume volatile works.
4381 2012-05-21 Ken Brown <kbrown@cornell.edu>
4383 * xgselect.c (xg_select): Fix first argument in call to 'select'
4386 2012-05-20 Ken Brown <kbrown@cornell.edu>
4388 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4389 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4391 2012-05-19 Ken Brown <kbrown@cornell.edu>
4393 * xfns.c (x_in_use): Remove `static' qualifier.
4394 * xterm.h (x_in_use): Declare.
4395 * xgselect.c: Include xterm.h.
4396 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4397 and `display_arg' (bug#9754).
4399 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4401 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4403 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4404 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4406 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4408 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4410 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4411 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4413 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4414 reference to image_cache->refcount.
4415 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4417 2012-05-17 Juri Linkov <juri@jurta.org>
4419 * search.c (Fword_search_regexp, Fword_search_backward)
4420 (Fword_search_forward, Fword_search_backward_lax)
4421 (Fword_search_forward_lax): Move functions to isearch.el
4422 (bug#10145, bug#11381).
4424 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4426 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4428 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4430 * lread.c (init_obarray): Declare Qt and Qnil as special.
4432 2012-05-14 Glenn Morris <rgm@gnu.org>
4434 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4435 Put "libexec" before "bin", for the sake of init_callproc_1.
4437 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4439 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4441 * unexaix.c: Port to more-recent AIX compilers.
4442 (report_error, report_error_1, make_hdr, copy_sym)
4443 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4444 Make arguments const char *, not char *, to avoid violations of C
4445 standard and to fix some AIX warnings reported by Gilles Pion.
4447 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4449 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4450 already have overlays loaded.
4451 (handle_single_display_spec): Before returning without displaying
4452 fringe bitmap, synchronize the bidi iterator with the main display
4453 iterator, by calling iterate_out_of_display_property.
4454 (iterate_out_of_display_property): Detect buffer iteration by
4455 testing that it->string is a Lisp string.
4456 (get_next_display_element): When the current object is exhausted,
4457 and there's something on it->stack, call set_iterator_to_next to
4458 proceed with what's on the stack, instead of returning zero.
4459 (set_iterator_to_next): If called at the end of a Lisp string,
4460 proceed to consider_string_end without incrementing string
4461 position. Don't increment display vector index past the end of
4462 the display vector. (Bug#11417)
4463 (pos_visible_p): Don't report a position visible when move_it_to
4464 stopped at the last line of window, which happens to be scanned
4465 backwards by the bidi iteration. (Bug#11464)
4467 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4469 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4470 and right-margin display specs even if the spec is invalid or we
4471 are on a TTY, and thus unable to display on the fringes.
4472 That's because the text with the property will not be displayed anyway,
4473 so we need to signal to the caller that this is a "replacing"
4474 display spec. This fixes display when the spec is invalid or we
4477 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4479 * unexaix.c (make_hdr): Fix typo in prototype.
4480 This bug broke the build on AIX. Problem reported by Gilles Pion.
4482 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4484 * keyboard.c (kbd_buffer_get_event): Read special events also in
4485 batch mode. (Bug#11415)
4487 2012-05-12 Glenn Morris <rgm@gnu.org>
4489 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4491 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4493 * lisp.mk (lisp): Add newcomment.elc.
4495 2012-05-12 Glenn Morris <rgm@gnu.org>
4497 * Makefile.in (MKDIR_P): New, set by configure.
4498 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4500 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4502 Remove unused function hourglass_started.
4503 * dispextern.h (hourglass_started):
4504 * w32fns.c (hourglass_started):
4505 * xdisp.c (hourglass_started): Remove.
4507 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4509 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4510 Update dependencies.
4512 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4514 * xgselect.c (xg_select): Put maxfds+1 into a var.
4515 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4517 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4519 2012-05-10 Dave Abrahams <dave@boostpro.com>
4521 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4522 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4524 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4526 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4527 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4528 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4529 Initialize xd_registered_buses.
4531 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4533 Untag more efficiently if USE_LSB_TAG.
4534 This is based on a proposal by YAMAMOTO Mitsuharu in
4535 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4536 For an admittedly artificial (nth 8000 longlist) benchmark on
4537 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4538 Emacs's overall text size by 1%.
4539 * lisp.h (XUNTAG): New macro.
4540 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4541 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4542 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4543 * eval.c (Fautoload):
4544 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4545 * frame.h (XFRAME): Use XUNTAG.
4547 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4548 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4549 Remove unportable assumptions about print widths of types like
4551 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4552 intptr_t when converting between pointer and integer, to avoid GCC
4553 warnings about wrong width.
4555 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4557 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4558 stack for each reader_thread, instead of defaulting to 8MB
4559 determined by the linker. This avoids failures in creating
4560 subprocesses on Windows 7, see the discussion in this thread:
4561 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4563 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4565 Fix up display of the *Minibuf-0* buffer in the mini window.
4566 * keyboard.c (read_char): Don't clear the echo area if there's no
4568 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4569 contents of *Minibuf-0*) if there's no message displayed in its stead.
4571 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4573 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4576 2012-05-06 Chong Yidong <cyd@gnu.org>
4578 * lisp.mk (lisp): Update.
4580 2012-05-05 Jim Meyering <meyering@redhat.com>
4582 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4584 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4586 * data.c (PUT_ERROR): New macro.
4587 (syms_of_data): Use it. Add new error type `user-error'.
4588 * undo.c (user_error): New function.
4589 (Fprimitive_undo): Use it.
4590 * print.c (print_error_message): Adjust print style for `user-error'.
4591 * keyboard.c (user_error): New function.
4592 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4594 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4596 Do not limit current-time-string to years 1000..9999.
4597 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4598 (Fcurrent_time_string): Support any year that is supported by the
4599 underlying localtime representation. Don't use asctime, as it
4600 has undefined behavior for years outside the range -999..9999.
4602 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4604 Fix race conditions involving setenv, gmtime, localtime, asctime.
4605 Without this fix, interrupts could mess up code that uses these
4606 nonreentrant functions, since setting TZ invalidates existing
4607 tm_zone or tzname values, and since most of these functions return
4608 pointers to static storage.
4609 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4610 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4611 Grow the critical sections to include not just invoking
4612 localtime/gmtime, but also accessing these functions' results
4613 including their tm_zone values if any, and any related TZ setting.
4614 (format_time_string): Last arg is now struct tm *, not struct tm **,
4615 so that the struct tm is saved in the critical section.
4616 All callers changed. Simplify allocation of initial buffer, partly
4617 motivated by the fact that memory allocation needs to be outside
4618 the critical section.
4620 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4622 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4623 with RESET_INTERVAL.
4625 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4626 Remove duplicated buffer name initialization.
4628 2012-05-02 Jim Meyering <jim@meyering.net>
4630 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4632 * xfns.c (x_window): Use xstrdup (Bug#11375).
4634 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4636 * xdisp.c (pos_visible_p): If already at a newline from the
4637 display string before the 'while' loop, don't walk back the glyphs
4638 from it3.glyph_row. Solves assertion violation when the display
4639 string begins with a newline (egg.el). (Bug#11367)
4641 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4643 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4646 2012-05-01 Glenn Morris <rgm@gnu.org>
4648 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4649 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4650 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4651 All were removed before 23.1.
4653 * dispnew.c: Remove HAVE_LIBNCURSES test;
4654 it is always true on relevant platforms.
4656 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4657 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4659 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4661 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4663 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4664 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4667 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4669 Do not avoid creating empty evaporating overlays (Bug#9642).
4670 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4671 That is, do not delete an evaporating overlay if it becomes
4672 empty after its bounds are adjusted to fit within its buffer.
4673 This fix caused other problems, and I'm reverting it until we get
4674 to the bottom of them.
4676 2012-04-27 Chong Yidong <cyd@gnu.org>
4678 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4680 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4682 * xdisp.c (pos_visible_p): If the window start position is beyond
4683 ZV, start the display from buffer beginning. Prevents assertion
4684 violation in init_iterator when the minibuffer window is scrolled
4687 * window.c (window_scroll_pixel_based): Likewise.
4689 2012-04-27 Chong Yidong <cyd@gnu.org>
4691 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4693 2012-04-27 Glenn Morris <rgm@gnu.org>
4695 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4696 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4698 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4700 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4701 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4703 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4705 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4706 display element, check also the underlying string or buffer
4707 character. (Bug#11341)
4709 * w32menu.c: Include w32heap.h.
4710 (add_menu_item): If the call to AppendMenuW (via
4711 unicode_append_menu) fails, disable Unicode menus only if we are
4712 running on Windows 9X/Me.
4714 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4716 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4717 (xgetint): Add missing shift for LSB tags.
4719 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4721 * keyboard.c (read_char): Don't wipe echo area for select window
4722 events: These might get delayed via `mouse-autoselect-window'
4725 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4727 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4728 manipulation of :loaded-from data.
4730 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4732 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4733 now a cons (bug#11311).
4735 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4737 Do not create empty overlays with the evaporate property (Bug#9642).
4738 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4739 if it becomes empty after its bounds are adjusted to fit within
4740 its buffer. Without this fix, in a nonempty buffer (let ((o
4741 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4742 yields an empty overlay that has the evaporate property, which is
4743 not supposed to happen.
4745 Fix minor GTK3 problems found by static checking.
4746 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4747 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4748 (struct _EmacsFixedClass, emacs_fixed_get_type):
4749 Move decls here from emacsgtkfixed.h, since they needn't be public.
4750 (emacs_fixed_get_type): Now static.
4751 (emacs_fixed_class_init): Omit unused local.
4752 (emacs_fixed_child_type): Remove; unused.
4753 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4754 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4755 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4756 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4757 (EMACS_FIXED_GET_CLASS): Remove; unused.
4758 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4760 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4761 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4763 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4765 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4766 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4767 (__malloc_size_t, __malloc_ptrdiff_t):
4768 Remove. All uses removed, replaced by the definiens if needed,
4769 since we can assume C89 or better now.
4770 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4771 (protect_malloc_state, align, get_contiguous_space)
4772 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4773 (malloc_atfork_handler_child, malloc_enable_thread)
4774 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4775 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4776 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4777 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4778 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4779 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4780 Define using prototypes, not old style.
4781 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4782 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4783 (align): Don't assume that signed integer overflow wraps around.
4784 Omit unused local var.
4785 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4786 (_free_internal_nolock, memalign, mallochook, reallochook):
4787 Omit no-longer-needed casts.
4788 (valloc): Use getpagesize, not __getpagesize.
4789 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4790 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4792 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4794 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4796 Move functions from C to Lisp. Make non-blocking method calls
4797 the default. Implement further D-Bus standard interfaces.
4799 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4800 (QCdbus_request_name_allow_replacement)
4801 (QCdbus_request_name_replace_existing)
4802 (QCdbus_request_name_do_not_queue)
4803 (QCdbus_request_name_reply_primary_owner)
4804 (QCdbus_request_name_reply_in_queue)
4805 (QCdbus_request_name_reply_exists)
4806 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4807 (QCdbus_registered_serial, QCdbus_registered_method)
4808 (QCdbus_registered_signal): New Lisp objects.
4809 (XD_DEBUG_MESSAGE): Use sizeof.
4810 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4811 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4812 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4813 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4814 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4815 (xd_signature, xd_append_arg): Allow float for integer types.
4816 (xd_get_connection_references): New function.
4817 (xd_get_connection_address): Rename from xd_initialize.
4818 Return cached address.
4819 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4820 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4822 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4823 Return number of refcounts.
4824 (Fdbus_get_unique_name): Make stronger parameter check.
4825 (Fdbus_message_internal): New defun.
4826 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4827 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4828 (Fdbus_send_signal, Fdbus_register_service)
4829 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4830 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4831 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4832 (Vdbus_compiled_version, Vdbus_runtime_version)
4833 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4834 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4835 (Vdbus_message_type_signal): New defvars.
4836 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4839 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4841 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4842 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4843 Do not assume ptrdiff_t is the same width as 'int'.
4845 * alloc.c: Handle unusual debugging option combinations.
4846 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4847 since the two debugging options are incompatible.
4848 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4850 (mem_init, mem_insert, mem_insert_fixup):
4851 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4852 (NEED_MEM_INSERT): Remove; no longer needed.
4854 2012-04-22 Leo Liu <sdl.web@gmail.com>
4856 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4858 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4860 * sysdep.c [__FreeBSD__]: Minor cleanups.
4861 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4862 Use Emacs indenting style more consistently. Avoid some casts.
4863 Use 'double' consistently rather than mixing 'float' and 'double'.
4865 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4867 * sysdep.c (list_system_processes, system_process_attributes):
4868 Add implementation for FreeBSD (Bug#5243).
4870 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4872 * lisp.mk (lisp): Update.
4874 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4876 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4877 It is never used otherwise.
4879 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4881 * print.c (print_preprocess): Only check print_depth if print-circle
4883 (print_object): Check for cycles even when print-circle is nil and
4884 print-gensym is t, but only check print_depth if print-circle is nil.
4886 2012-04-20 Chong Yidong <cyd@gnu.org>
4888 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4889 set the status to "failed" and ensure that sentinel is run.
4891 2012-04-20 Glenn Morris <rgm@gnu.org>
4893 * process.c (Fset_process_inherit_coding_system_flag)
4894 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4895 (Fmake_network_process, Fmake_serial_process): Doc fix.
4897 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4899 * xdisp.c (string_buffer_position_lim): Limit starting position to
4901 (set_cursor_from_row): If called for a mode-line or header-line
4902 row, return zero immediately.
4903 (try_cursor_movement): If inside continuation line, don't back up
4904 farther than the first row after the header line, if any.
4905 Don't consider the header-line row as "partially visible", even if
4906 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4908 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4910 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4913 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4914 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4916 configure: new option --enable-gcc-warnings (Bug#11207)
4917 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4918 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4919 (ALL_CFLAGS): Use new macros rather than old.
4920 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4921 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4922 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4923 -Wunused-result, -Wunused-variable. This should go away once
4924 the Emacs and Gnulib regex code is merged.
4925 (xmalloc, xrealloc): Now static.
4927 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4929 * dired.c (Fsystem_groups): Remove unused local.
4931 2012-04-17 Glenn Morris <rgm@gnu.org>
4933 * dired.c (Fsystem_users): Doc fix.
4935 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4937 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4938 (syms_of_dired): Add them.
4940 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4942 Fix minor alloc.c problems found by static checking.
4943 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4944 New extern decls, to avoid calling undeclared functions.
4945 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4946 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4947 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4948 (NEED_MEM_INSERT): New macro.
4949 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4950 Remove one incorrect comment and fix another.
4952 Fix minor ralloc.c problems found by static checking.
4953 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4954 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4955 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4956 (r_alloc_sbrk): Now static.
4958 Improve ralloc.c interface checking.
4959 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4960 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4961 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4962 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4963 [REL_ALLOC]: ... to here, to check interface.
4964 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4965 Remove decls. This fixes an "It stinks!".
4967 * alloc.c (which_symbols): Fix alignment issue / type clash.
4969 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4971 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4972 (struct Lisp_Misc_Any): Likewise.
4973 (struct Lisp_Free): Likewise.
4974 * alloc.c (union aligned_Lisp_Symbol): Define.
4975 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4976 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4977 (union aligned_Lisp_Misc): Define.
4978 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4979 aligned_Lisp_Misc instead of union Lisp_Misc.
4980 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4982 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4984 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4985 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4986 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4987 * s/netbsd.h, s/sol2-6.h:
4988 Remove definition of GC_MARK_STACK, since the default now works.
4989 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4990 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4991 no longer the default.
4992 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4994 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4996 * lread.c (lisp_file_lexically_bound_p):
4997 Fix hang at ";-*-\n" (bug#11238).
4999 2012-04-14 Eli Zaretskii <eliz@gnu.org>
5001 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5002 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5004 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5006 * nsterm.m (constrainFrameRect): Always constrain when there is only
5007 one screen (Bug#10962).
5009 2012-04-13 Ken Brown <kbrown@cornell.edu>
5011 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5013 2012-04-13 Reuben Thomas <rrt@sc3d.org>
5015 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5017 2012-04-11 Daniel Colascione <dancol@dancol.org>
5019 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5020 against is gone. It's better to use vfork now so that when Cygwin
5021 gains a new, working vfork, we use it automatically (bug#10398).
5023 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5025 * window.c (save_window_save): Obey window-point-insertion-type.
5027 2012-04-11 Glenn Morris <rgm@gnu.org>
5029 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5031 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5033 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5035 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
5037 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5038 (force_quit_count): New var.
5039 (handle_interrupt): Use it.
5041 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
5043 * w32.c (w32_delayed_load): Record the full path of the library
5044 being loaded (bug#10424).
5046 2012-04-09 Glenn Morris <rgm@gnu.org>
5048 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5049 not just in the obarray, before snarfing them. (Bug#11036)
5051 * Makefile.in ($(leimdir)/leim-list.el):
5052 Pass EMACS rather than BUILT_EMACS.
5054 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5056 * process.c (make_process):
5057 * process.h: Add integer `gnutls_handshakes_tried' member to
5060 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5061 Add convenience `GNUTLS_LOG2i' macro.
5063 * gnutls.c (gnutls_log_function2i): Convenience log function.
5064 (emacs_gnutls_read): Use new log functions,
5065 `gnutls_handshakes_tried' process member, and
5066 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5067 attempts per process (connection).
5069 2012-04-09 Chong Yidong <cyd@gnu.org>
5071 * eval.c (Fuser_variable_p, user_variable_p_eh)
5072 (lisp_indirect_variable): Functions deleted.
5073 (Fdefvar): Caller changed.
5075 * callint.c (Finteractive, Fcall_interactively):
5076 * minibuf.c (Fread_variable): Callers changed.
5078 2012-04-09 Eli Zaretskii <eliz@gnu.org>
5080 * xdisp.c (set_cursor_from_row): If the display string appears in
5081 the buffer at position that is closer to point than the position
5082 after the display string, display the cursor on the first glyph of
5083 the display string. Fixes cursor display when a 'display' text
5084 property immediately follows invisible text. (Bug#11094)
5086 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5088 composite.c: use 'double' consistently
5089 * composite.c (get_composition_id): Use 'double' consistently
5090 instead of converting 'float' to 'double' and vice versa; this is
5091 easier to understand and avoids a GCC warning.
5093 2012-04-09 Glenn Morris <rgm@gnu.org>
5095 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5096 preparation for dumping it with emacs. (Bug#4789)
5097 (leimdir): New variable.
5098 ($(leimdir)/leim-list.el): New rule.
5099 (emacs$(EXEEXT)): Depend on leim-list.el.
5101 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5102 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5103 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5105 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5107 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5110 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
5112 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5113 Remove unused local variable.
5115 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5117 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5118 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5119 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5120 objects, as mark_maybe_pointer will catch them otherwise.
5121 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5122 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5124 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5126 Fix typo that broke non-Windows builds.
5127 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5129 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5131 Support building on MS-Windows with libxml2.
5133 * makefile.w32-in (OBJ2): Add xml.$(O).
5134 (GLOBAL_SOURCES): Add xml.c.
5135 ($(BLD)/xml.$(O)): New dependency list.
5137 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5138 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5139 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5140 [!WINDOWSNT]: New macros.
5141 (init_libxml2_functions, libxml2_loaded_p): New functions.
5142 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5143 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5144 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5145 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5147 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5148 Call init_libxml2_functions before calling libxml2 functions.
5149 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5151 * emacs.c: Don't include libxml/parser.h.
5152 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5153 xmlCleanupParser directly.
5155 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5157 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5159 * indent.c (Fvertical_motion): If there is a display string at
5160 point, use it.vpos to compute how many lines to backtrack after
5161 move_it_to point. (Bug#11133)
5163 2012-04-06 Eli Zaretskii <eliz@gnu.org>
5165 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5166 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5167 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5168 macros related to unification of CJK characters. For the details,
5169 see the discussion following the message here:
5170 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5172 2012-04-04 Chong Yidong <cyd@gnu.org>
5174 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5176 2012-04-01 Eli Zaretskii <eliz@gnu.org>
5178 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5179 instead of alloca. (Bug#11138)
5181 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5183 * w32menu.c (is_simple_dialog): Properly check lisp types.
5186 2012-03-31 Eli Zaretskii <eliz@gnu.org>
5188 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5189 position we get to after a call to move_it_to fails the
5190 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5191 only if we wind up in a string from display property. (Bug#11063)
5193 * window.c (Fdelete_other_windows_internal): Invalidate the row
5194 and column information about mouse highlight, so that redisplay
5195 restores it after reallocating the glyph matrices. (Bug#7464)
5197 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5198 string comes from a `display' text property, use the buffer
5199 position of that property as if we actually saw that position in
5201 (move_it_by_lines): Remove the assertion that
5202 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5203 violated when there's a before-string at the beginning of a line.
5206 2012-03-30 Eli Zaretskii <eliz@gnu.org>
5208 * xdisp.c (append_space_for_newline): If the default face was
5209 remapped, use the remapped face for the appended newline.
5210 (extend_face_to_end_of_line): Use the remapped default face for
5211 extending the face to the end of the line.
5212 (display_line): Call extend_face_to_end_of_line when the default
5213 face was remapped. (Bug#11068)
5215 2012-03-29 Eli Zaretskii <eliz@gnu.org>
5217 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5219 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5221 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5223 2012-03-27 Glenn Morris <rgm@gnu.org>
5225 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5228 2012-03-26 Kenichi Handa <handa@m17n.org>
5230 * dispextern.h (struct glyph): Fix previous change. Change the
5231 bit length of glyphless.ch to 25 (Bug#11082).
5233 2012-03-26 Chong Yidong <cyd@gnu.org>
5235 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5236 (command_loop_1): Use it; inhibit selection update for
5237 handle-select-window too (Bug#8996).
5239 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5241 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
5243 2012-03-25 Kenichi Handa <handa@m17n.org>
5245 * dispextern.h (struct glyph): Change the bit length of
5246 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5248 2012-03-24 Eli Zaretskii <eliz@gnu.org>
5250 * s/ms-w32.h (tzname): Include time.h before redirecting to
5251 _tzname. Fixes the MSVC build. (Bug#9960)
5253 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5255 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5258 * xterm.c (XTread_socket): Only modify handling_signal if
5259 !SYNC_INPUT. (Bug#11080)
5261 2012-03-23 Eli Zaretskii <eliz@gnu.org>
5263 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5264 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5265 when fetching a multibyte character consumes more bytes than
5266 CHAR_BYTES returns, due to unification of CJK characters in
5267 string_char. (Bug#11073)
5269 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5271 * process.c (wait_reading_process_output): Handle pty disconnect
5272 by refraining from sending oneself a SIGCHLD (bug#10933).
5274 2012-03-22 Chong Yidong <cyd@gnu.org>
5276 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5278 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
5279 Mark string as coming from a prefix property.
5280 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5281 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5283 2012-03-21 Chong Yidong <cyd@gnu.org>
5285 * xfaces.c (Vface_remapping_alist): Doc fix.
5287 2012-03-20 Eli Zaretskii <eliz@gnu.org>
5289 * w32proc.c (Fw32_set_console_codepage)
5290 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5293 2012-03-20 Chong Yidong <cyd@gnu.org>
5295 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5296 to reflect default non-nil value of redisplay-dont-pause.
5298 2012-03-19 Kenichi Handa <handa@m17n.org>
5300 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5301 it fit in a valid range (Bug#11003).
5303 2012-03-18 Eli Zaretskii <eliz@gnu.org>
5305 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5306 that is not from display property, accept the row as a "cursor
5307 row" if one of the string's character has a non-nil `cursor'
5308 property. Fixes cursor positioning when there are newlines in
5309 overlay strings, e.g. in icomplete.el. (Bug#11035)
5311 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5313 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5315 2012-03-12 Chong Yidong <cyd@gnu.org>
5317 * eval.c (inhibit_lisp_code): Rename from
5318 inhibit_window_configuration_change_hook; move from window.c.
5320 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5321 * window.c (run_window_configuration_change_hook)
5322 (syms_of_window): Callers changed.
5324 2012-03-11 Chong Yidong <cyd@gnu.org>
5326 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5328 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5330 2012-03-10 Chong Yidong <cyd@gnu.org>
5332 * frame.c (other_visible_frames): Don't assume the selected frame
5333 is visible (Bug#10955).
5335 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5337 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5339 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5341 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5342 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5345 2012-03-03 Glenn Morris <rgm@gnu.org>
5347 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5349 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5351 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5352 position past the first glyph_row that ends at ZV. (Bug#10902)
5353 (redisplay_window, next_element_from_string): Fix typos in
5355 (redisplay_window): Pass to move_it_vertically the margin in
5356 pixels, not in screen lines.
5358 2012-03-02 Glenn Morris <rgm@gnu.org>
5360 * buffer.c (buffer-list-update-hook): Doc fix.
5362 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5364 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5365 push_it before setting up the iterator for the first overlay
5366 string, even if we have an empty string loaded.
5367 (next_overlay_string): If there's an empty string on the iterator
5368 stack, pop the stack. (Bug#10903)
5370 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5372 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5373 Suggested by Stefan Monnier in
5374 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5375 * alloc.c (widen_to_Lisp_Object): New static function.
5376 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5377 and widening them to Lisp_Objects. This would work even if
5378 USE_LSB_TAG is defined and wide integers are used, which might
5379 happen in a future version of Emacs.
5381 2012-02-25 Chong Yidong <cyd@gnu.org>
5383 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5386 * xselect.c (Fx_selection_exists_p): Doc fix.
5387 (x_clipboard_manager_save_all): Print an informative message
5388 before saving to clipboard manager.
5390 2012-02-24 Chong Yidong <cyd@gnu.org>
5392 * keyboard.c (process_special_events): Handle all X selection
5393 requests in kbd_buffer, not just the next one (Bug#8869).
5395 2012-02-23 Chong Yidong <cyd@gnu.org>
5397 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5398 call when setting menu-bar-lines and tool-bar-lines parameters.
5399 (unwind_create_frame_1): New helper function.
5401 * window.c (inhibit_window_configuration_change_hook): New var.
5402 (run_window_configuration_change_hook): Obey it.
5403 (syms_of_window): Initialize it.
5405 2012-02-22 Chong Yidong <cyd@gnu.org>
5407 * xterm.c (x_draw_image_relief): Add missing type check for
5408 Vtool_bar_button_margin (Bug#10743).
5410 2012-02-21 Chong Yidong <cyd@gnu.org>
5412 * fileio.c (Vfile_name_handler_alist): Doc fix.
5414 * buffer.c (Fget_file_buffer): Protect against invalid file
5415 handler return value.
5417 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5419 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5420 when computing $valmask.
5422 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5423 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5424 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5425 It's useless in that case, and it can cause problems on hosts
5426 that allocate halves of EMACS_INT values separately.
5427 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5428 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5429 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5430 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5431 it avoids undefined behavior on hosts where shifting right by more
5432 than the word width has undefined behavior.
5434 2012-02-19 Chong Yidong <cyd@gnu.org>
5436 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5437 (Funhandled_file_name_directory, Ffile_name_as_directory)
5438 (Fdirectory_file_name, Fexpand_file_name)
5439 (Fsubstitute_in_file_name): Protect against invalid file handler
5440 return values (Bug#10845).
5442 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5444 * .gdbinit (pitx): Fix incorrect references to fields of the
5447 2012-02-17 Chong Yidong <cyd@gnu.org>
5449 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5451 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5453 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5454 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5456 2012-02-15 Chong Yidong <cyd@gnu.org>
5458 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5459 marked as special. Also, starting docstrings with * is obsolete.
5461 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5463 * gnutls.c (emacs_gnutls_write): Fix last change.
5465 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5467 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5470 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5472 * keymap.c (Fsingle_key_description): Handle char ranges.
5474 2012-02-12 Chong Yidong <cyd@gnu.org>
5476 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5477 as that creates a dangerous corner case.
5479 * window.c (Fdelete_window_internal): Invalidate the mouse
5480 highlight (Bug#9904).
5482 2012-02-12 Glenn Morris <rgm@gnu.org>
5484 * xselect.c (Fx_own_selection_internal)
5485 (Fx_get_selection_internal, Fx_disown_selection_internal)
5486 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5487 * nsselect.m (Fx_own_selection_internal)
5488 (Fx_disown_selection_internal, Fx_selection_exists_p)
5489 (Fx_selection_owner_p, Fx_get_selection_internal):
5490 Sync docs and argument specs with the xselect.c versions.
5492 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5494 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5496 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5498 * w32select.c (Fx_selection_exists_p): Sync doc string and
5499 argument list with xselect.c. (Bug#10783)
5501 * w16select.c (Fx_selection_exists_p): Sync doc string and
5502 argument list with xselect.c. (Bug#10783)
5504 2012-02-10 Glenn Morris <rgm@gnu.org>
5506 * fns.c (Fsecure_hash): Doc fix.
5508 2012-02-09 Kenichi Handa <handa@m17n.org>
5510 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5512 2012-02-07 Chong Yidong <cyd@gnu.org>
5514 * buffer.c (Fbuffer_local_variables)
5515 (buffer_lisp_local_variables): Handle unbound vars correctly;
5516 don't let Qunbound leak into Lisp.
5518 2012-02-07 Glenn Morris <rgm@gnu.org>
5520 * image.c (Fimagemagick_types): Doc fix.
5522 * image.c (imagemagick-render-type): Change it from a lisp object
5523 to an integer. Move the doc here from the lisp manual.
5524 Treat all values not equal to 0 the same.
5526 2012-02-06 Chong Yidong <cyd@gnu.org>
5528 * doc.c (store_function_docstring): Avoid applying docstring of
5529 alias to base function (Bug#2603).
5531 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5533 * .gdbinit (pp1, pv1): Remove redundant defines.
5536 2012-02-04 Chong Yidong <cyd@gnu.org>
5538 * nsterm.m: Declare a global (Bug#10694).
5540 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5542 * w32.c (get_emacs_configuration_options):
5543 Include --enable-checking, if specified, in the return value.
5545 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5547 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5548 after rounding frame sizes. (Bug#9723)
5550 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5552 * keyboard.c (adjust_point_for_property): Don't position point
5553 before BEGV. (Bug#10696)
5555 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5557 Handle overflow when computing char display width (Bug#9496).
5558 * character.c (char_width): Return EMACS_INT, not int.
5559 (char_width, c_string_width): Check for overflow when
5560 computing the width; this is possible now that individual
5561 characters can have unbounded width. Problem introduced
5562 by merge from Emacs 23 on 2012-01-19.
5564 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5566 * dbusbind.c (Fdbus_register_method): Mention the return value
5567 :ignore in the docstring.
5569 2012-02-02 Glenn Morris <rgm@gnu.org>
5571 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5573 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5574 Unconditionally set to t. (Bug#10673)
5575 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5576 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5577 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5579 2012-02-02 Kenichi Handa <handa@m17n.org>
5581 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5582 0, do not call append_composite_glyph.
5584 2012-02-02 Kenichi Handa <handa@m17n.org>
5586 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5588 (x_produce_glyphs): If the component of a composition is a null
5589 string, set it->pixel_width to 1 to avoid zero-width glyph.
5591 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5593 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5594 first 2 arguments are identical. This makes inserting large
5595 output from a subprocess an order of magnitude faster on
5596 MS-Windows, where all sbrk'ed memory is always contiguous.
5598 2012-01-31 Glenn Morris <rgm@gnu.org>
5600 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5601 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5602 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5604 2012-01-29 Glenn Morris <rgm@gnu.org>
5606 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5608 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5610 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5612 2012-01-28 Chong Yidong <cyd@gnu.org>
5614 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5616 2012-01-26 Chong Yidong <cyd@gnu.org>
5618 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5620 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5621 repeat counts (Bug#10507).
5623 2012-01-26 Glenn Morris <rgm@gnu.org>
5625 * lread.c (syms_of_lread): Doc fix.
5627 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5629 * coding.c (encode_designation_at_bol): Change return value to
5632 2012-01-25 Chong Yidong <cyd@gnu.org>
5634 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5636 2012-01-21 Chong Yidong <cyd@gnu.org>
5638 * floatfns.c (Fcopysign): Make the second argument non-optional,
5639 since nil is not allowed anyway.
5641 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5643 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5644 (send_process): Likewise.
5646 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5648 * window.c (save_window_save, Fcurrent_window_configuration)
5649 (Vwindow_persistent_parameters): Do not use Qstate.
5650 Rewrite doc-strings.
5652 2012-01-19 Kenichi Handa <handa@m17n.org>
5654 * character.c (char_width): New function.
5655 (Fchar_width, c_string_width, lisp_string_width):
5656 Use char_width (Bug#9496).
5658 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5660 * window.c (Vwindow_persistent_parameters): New variable.
5661 (Fset_window_configuration, save_window_save): Handle persistent
5664 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5666 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5667 thrashing the stack of the thread. (Bug#9087)
5669 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5671 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5673 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5675 * xdisp.c (rows_from_pos_range): Handle the case where the
5676 highlight ends on a newline. (Bug#10464)
5677 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5678 he end column for display of highlight that ends on a newline
5681 2012-01-11 Glenn Morris <rgm@gnu.org>
5683 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5684 from load-path also when installation-directory is nil. (Bug#10208)
5686 2012-01-10 Glenn Morris <rgm@gnu.org>
5688 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5690 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5691 Update template values to be closer to their typical values these days.
5693 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5695 * xdisp.c (rows_from_pos_range): Accept additional argument
5696 DISP_STRING, and accept any glyph in a row whose object is that
5697 string as eligible for mouse highlight. Fixes mouse highlight of
5698 display strings from overlays. (Bug#10464)
5700 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5702 emacs: fix an auto-save permissions race condition (Bug#10400)
5703 * fileio.c (auto_saving_dir_umask): New static var.
5704 (Fmake_directory_internal): Use it.
5705 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5706 creating the directory. The old code temporarily assigns
5707 too-generous permissions to the directory.
5708 (do_auto_save_eh): Clear it.
5709 (Fdo_auto_save): Catch all errors, not just file errors, so
5710 that the var is always cleared.
5712 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5714 * search.c (scan_buffer): Pass character positions to
5715 know_region_cache, not byte positions. (Bug#6540)
5717 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5719 * w32.c (sys_rename): Report EXDEV when rename of a directory
5720 fails because the target is on another logical disk. (Bug#10284)
5722 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5724 * xterm.c (x_embed_request_focus): New function.
5726 * xterm.h: Add prototype.
5728 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5730 2012-01-05 Glenn Morris <rgm@gnu.org>
5732 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5734 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5736 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5737 Load gnutls_transport_set_lowat only if GnuTLS version is below
5739 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5740 GnuTLS versions below 2.11.1.
5742 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5744 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5745 to the doc string advising against its use for altering the way
5746 windows are scrolled.
5748 2011-12-28 Kenichi Handa <handa@m17n.org>
5750 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5751 coding-system ASCII compatible only when it does not produce BOM
5752 on encoding (Bug#10383).
5754 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5756 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5758 (create_and_show_popup_menu): Always use menu_position_func for
5761 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5763 * callint.c (Fcall_interactively): Don't truncate prompt string.
5765 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5767 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5768 property that ends at ZV, so that the bidi iteration could be
5769 resumed from there (after widening). (Bug#10360)
5771 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5773 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5775 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5777 * nsterm.m (x_free_frame_resources):
5778 Release f->output_data.ns->miniimage.
5779 (ns_index_color): Fix indentation. Do not retain
5780 color_table->colors[i].
5782 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5785 * nsfns.m (x_set_background_color): Assign return value from
5786 ns_index_color to face-background instead of NSColor*.
5787 (ns_implicitly_set_icon_type): Fix indentation.
5788 Change assignment in for loop to comparison.
5790 * emacs.c (ns_pool): New variable.
5791 (main): Assign ns_pool.
5792 (Fkill_emacs): Call ns_release_autorelease_pool.
5794 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5795 autorelease fdesc, release fdAttrs and tdict.
5796 (ns_get_covering_families): Release charset.
5797 (ns_findfonts): Release NSFontDescriptor created with new.
5798 (ns_uni_to_glyphs): Fix indentation.
5799 (setString): Release attrStr before assigning new value.
5801 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5803 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5805 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5806 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5808 2011-12-18 David Reitter <reitter@cmu.edu>
5810 * nsterm.m (ns_term_init): Subscribe for notifications
5811 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5812 to method trackingNotification in EmacsMenu.
5814 * nsmenu.m (trackingMenu): New variable.
5815 (trackingNotification): New method (from Aquamacs).
5816 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5817 from Aquamacs (Bug#7030).
5819 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5821 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5822 (symbol_to_nsstring): Fix indentation.
5823 (ns_symbol_to_pb): New function.
5824 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5825 (Fns_rotate_cut_buffers_internal): Remove.
5826 (Fns_store_selection_internal): Rename from
5827 Fns_store_cut_buffer_internal.
5828 (ns_get_foreign_selection, Fx_own_selection_internal)
5829 (Fx_disown_selection_internal, Fx_selection_exists_p)
5830 (Fns_get_selection_internal, Fns_store_selection_internal):
5831 Use ns_symbol_to_pb and check if return value is nil.
5832 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5833 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5834 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5835 renamed to Sns_store_selection_internal.
5836 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5837 and remove this function.
5838 (ns_handle_selection_clear): Remove, never used.
5839 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5842 2011-12-17 Ken Brown <kbrown@cornell.edu>
5844 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5845 GID is unknown (Bug#10257).
5847 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5849 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5850 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5851 which caused a build failure on GNU/Linux IA-64. This problem was
5852 introduced by my 2011-10-07 patch.
5854 2011-12-15 Juri Linkov <juri@jurta.org>
5856 * image.c (imagemagick_error): New function. (Bug#10112)
5857 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5858 Use `imagemagick_error' where ImageMagick functions return
5860 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5863 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5865 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5866 fill background (Bug#8992).
5868 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5870 * window.c (Vwindow_combination_resize)
5871 (Vwindow_combination_limit): Use t instead of non-nil in
5873 (Vrecenter_redisplay): Add first sentence of doc-string on
5875 (Frecenter): Fix doc-string typo.
5877 2011-12-11 Kenichi Handa <handa@m17n.org>
5879 * coding.c (Funencodable_char_position): Pay attention to the
5880 buffer text relocation (Bug#9389).
5882 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5884 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5885 gtk_init (Bug#10100).
5887 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5889 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5890 IT->string is nil. (Bug#10263)
5892 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5894 * nsterm.h (x_free_frame_resources): Declare.
5896 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5897 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5899 * nsterm.h (ns_get_defaults_value): Declare.
5901 * nsterm.m (ns_default): Call ns_get_defaults_value.
5903 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5905 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5908 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5910 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5911 that where the value of an _OBJC_* symbol points to is in the .bss
5912 section (Bug#10240).
5914 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5916 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5917 after the loop to call ccl_driver at least once (Bug#8619).
5919 2011-12-08 Kenichi Handa <handa@m17n.org>
5921 * ftfont.c (get_adstyle_property): Fix previous change
5924 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5926 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5927 dirs from the default value of EMACSLOADPATH (bug#10208).
5929 2011-12-07 Glenn Morris <rgm@gnu.org>
5931 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5932 installation and source directories as well. (Bug#10208)
5934 2011-12-06 Chong Yidong <cyd@gnu.org>
5936 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5938 2011-12-06 Glenn Morris <rgm@gnu.org>
5940 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5941 as an error, not just -1. (Bug#10217)
5943 2011-12-05 Chong Yidong <cyd@gnu.org>
5945 * keyboard.c (process_special_events): New function.
5946 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5948 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5950 * coding.c (encode_designation_at_bol): Don't use uninitialized
5951 local variable (Bug#9318).
5953 2011-12-05 Kenichi Handa <handa@m17n.org>
5955 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5956 return Qnil (Bug#8046, Bug#10193).
5958 2011-12-05 Kenichi Handa <handa@m17n.org>
5960 * coding.c (encode_designation_at_bol): New args charbuf_end and
5961 dst. Return the number of produced bytes. Callers changed.
5962 (coding_set_source): Return how many bytes coding->source was
5964 (coding_set_destination): Return how many bytes
5965 coding->destination was relocated.
5966 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5967 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5969 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5971 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5972 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5975 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5977 The following changes are to fix Bug#9318.
5979 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5980 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5981 (encode_coding_iso_2022, encode_coding_sjis)
5982 (encode_coding_big5, encode_coding_charset): Use the above macros.
5984 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5986 * lisp.h (process_quit_flag): Fix external declaration.
5988 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5990 Don't macro-inline non-performance-critical code.
5991 * eval.c (process_quit_flag): New function.
5992 * lisp.h (QUIT): Use it.
5994 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5996 * nsfns.m (get_geometry_from_preferences): New function.
5997 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5999 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6001 * emacs.c (Qkill_emacs): Define.
6002 (syms_of_emacs): Initialize it.
6003 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6004 Qquit_flag to `kill-emacs' instead.
6005 (quit_throw_to_read_char): Add parameter `from_signal'.
6006 All callers changed. Call Fkill_emacs if requested and safe.
6007 * lisp.h (QUIT): Call Fkill_emacs if requested.
6009 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6011 * widget.c (update_wm_hints): Return if wmshell is null.
6012 (widget_update_wm_size_hints): New function.
6014 * widget.h (widget_update_wm_size_hints): Declare.
6016 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6017 widget_update_wm_size_hints (Bug#10104).
6019 2011-12-03 Eli Zaretskii <eliz@gnu.org>
6021 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6022 before a newline, prepare the bidi iterator for consuming the
6023 newline, and keep the current paragraph direction. (Bug#10183)
6024 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
6026 2011-12-02 Juri Linkov <juri@jurta.org>
6028 * search.c (Fword_search_regexp): New Lisp function created from
6029 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6030 (Fword_search_backward, Fword_search_forward)
6031 (Fword_search_backward_lax, Fword_search_forward_lax):
6032 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6033 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6035 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6037 * fileio.c (Finsert_file_contents): Move after-change-function call
6038 to before the "handled:" label, since all "goto handled" appear in
6039 cases where the *-change-functions have already been properly called
6042 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6044 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6045 waiting for input. (Bug#10169)
6047 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6049 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6050 verifies glyph row's hash code--we have just reallocated the
6051 glyphs, so their contents can be complete garbage. (Bug#10164)
6053 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
6055 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6057 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6059 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6060 attributes are tested _before_ calling verify_row_hash, to protect
6061 against GCC re-ordering of the tests. (Bug#10164)
6063 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6065 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6067 * xterm.c (handle_one_xevent): Only set async_visible and friends
6068 if net_wm_state_hidden_seen is non-zero (Bug#10002)
6069 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
6070 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6072 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6074 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6075 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6076 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6077 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6078 All uses changed to use GCPRO1 etc.
6079 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6080 Revert to old implementation (i.e., before 2011-03-11).
6082 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6084 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6085 of scroll runs so as to avoid assigning disabled bogus rows and
6086 unnecessary graphics copy operations.
6088 2011-11-27 Eli Zaretskii <eliz@gnu.org>
6090 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6091 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6092 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6093 (malloc, free, realloc, calloc): Redirect to e_* only when
6096 * lisp.h (GCTYPEBITS): Move before first use.
6097 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6098 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6099 this macro definition.
6101 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6104 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6106 * gtkutil.c (xg_create_frame_widgets):
6107 Call gtk_window_set_has_resize_grip (FALSE) if that function is
6108 present with Gtk+ 2.0.
6110 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6112 * fileio.c (Finsert_file_contents): Undo previous change; see
6113 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6115 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6117 Rename locals to avoid shadowing.
6118 * fileio.c (Finsert_file_contents):
6119 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6120 * process.c (wait_reading_process_output):
6121 Rename inner 'proc' to 'p' to avoid shadowing.
6122 Indent for consistency with usual Emacs style.
6124 2011-11-25 Eli Zaretskii <eliz@gnu.org>
6126 * xdisp.c (redisplay_window): If cursor row is not fully visible
6127 after recentering, and scroll-conservatively is set to a large
6128 number, scroll window by a few more lines to make the cursor fully
6129 visible and out of scroll-margin. (Bug#10105)
6130 (start_display): Don't move to the next line if the display should
6131 start at a newline that is part of a display vector or an overlay
6134 2011-11-24 Juri Linkov <juri@jurta.org>
6136 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6137 after the `MagickPingImage' call. (Bug#10112)
6139 2011-11-23 Chong Yidong <cyd@gnu.org>
6141 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6143 2011-11-23 Martin Rudalics <rudalics@gmx.at>
6145 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6146 making another buffer current. (Bug#10114)
6148 2011-11-23 Glenn Morris <rgm@gnu.org>
6150 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6152 2011-11-23 Chong Yidong <cyd@gnu.org>
6154 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6155 using it (Bug#5984).
6157 2011-11-22 Eli Zaretskii <eliz@gnu.org>
6159 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6160 and header-lines, as they don't have one computed for them.
6163 * .gdbinit (prow): Make displayed values more self-explaining.
6164 Add row's hash code.
6166 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6168 * process.c (wait_reading_process_output): Fix asynchrounous
6169 GnuTLS socket handling on some versions of the GnuTLS library.
6170 (wait_reading_process_output): Add comment and URL.
6172 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6174 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6176 2011-11-21 Chong Yidong <cyd@gnu.org>
6178 * window.c (Fnext_window, Fprevious_window): Doc fix.
6180 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6182 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6184 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6186 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6188 2011-11-20 Martin Rudalics <rudalics@gmx.at>
6190 * window.c (Fset_window_combination_limit): Rename argument
6192 (Vwindow_combination_limit): Remove "status" from doc-string.
6194 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6196 * m/ibms390.h: Remove.
6197 * m/ibms390x.h: Don't include "ibms390.h".
6199 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6201 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6202 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6204 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6206 * casetab.c (Fset_case_table):
6207 * charset.c (Fcharset_after): Fix typos.
6209 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6211 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6212 Otherwise, valgrind does not work on some platforms.
6213 Problem reported by Andreas Schwab in
6214 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6215 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6216 is set, removing the need for VIRT_ADDRESS_VARIES.
6217 (PURE_P): Use a more-efficient implementation that needs just one
6218 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6219 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6220 to 4 (xorl, subq, cmpq, setbe).
6221 * alloc.c (pure): Always extern now, since that's the
6222 VIRT_ADDR_VARIES behavior.
6223 (PURE_POINTER_P): Use a single comparison, not two, for
6224 consistency with the new puresize.h.
6225 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6226 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6227 Remove VIRT_ADDR_VARIES no longer needed.
6229 2011-11-19 Eli Zaretskii <eliz@gnu.org>
6231 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6232 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6233 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6234 behave as if the cursor position were at the window margin.
6236 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6237 and the cursor position is out of bounds, behave as if the cursor
6238 position were at the window margin. (Bug#10075)
6240 2011-11-18 Chong Yidong <cyd@gnu.org>
6242 * window.c (Fwindow_combination_limit): Make first argument
6243 non-optional, since it is meaningless for live windows like the
6246 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6248 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6250 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6252 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6253 (graft_intervals_into_buffer): Simplify.
6255 2011-11-18 Eli Zaretskii <eliz@gnu.org>
6257 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6258 hash values of the two rows.
6259 (copy_row_except_pointers): Preserve the used[] arrays and the
6260 hash values of the two rows. (Bug#10035)
6261 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
6263 * xdisp.c (row_hash): New function, body extracted from
6264 compute_line_metrics.
6265 (compute_line_metrics): Call row_hash, instead of computing the
6268 * dispnew.c (verify_row_hash): Call row_hash for computing the
6269 hash code of a row, instead of duplicating code from xdisp.c.
6271 * dispextern.h (row_hash): Add prototype.
6273 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6275 * frame.c (delete_frame): Don't delete the terminal when the last
6276 X frame is closed if emacs is built with GTK toolkit.
6278 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
6280 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6282 2011-11-17 Martin Rudalics <rudalics@gmx.at>
6284 * window.c (Vwindow_splits): Rename to
6285 Vwindow_combination_resize. Suggested by Juri Linkov.
6286 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6289 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
6291 * nsfns.m (Fns_font_name):
6292 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
6294 2011-11-16 Martin Rudalics <rudalics@gmx.at>
6296 * window.h (window): Rename slot "nest" to "combination_limit".
6297 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6298 (Fset_window_nest): Rename to Fset_window_combination_limit.
6299 (Vwindow_nest): Rename to Vwindow_combination_limit.
6300 (recombine_windows, make_parent_window, make_window)
6301 (Fsplit_window_internal, saved_window)
6302 (Fset_window_configuration, save_window_save): Rename all
6303 occurrences of window_nest to window_combination_limit.
6305 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
6307 * image.c (imagemagick_load_image): Fix typo.
6309 2011-11-14 Eli Zaretskii <eliz@gnu.org>
6311 * xdisp.c (display_line): Move the call to
6312 highlight_trailing_whitespace before the call to
6313 compute_line_metrics, since the latter needs to see the final
6314 faces of all the glyphs to compute ROW's hash value.
6315 Fixes assertion violations in row_equal_p. (Bug#10035)
6317 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6319 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6320 just return (bug#10044).
6322 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6324 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6325 with user-defined heap size. Bump the default size of the temacs
6326 heap to 27MB, to avoid memory warning when running temacs.
6327 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6329 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6330 current_matrix and desired_matrix. (Bug#9990)
6331 (verify_row_hash) [XASSERTS]: New function.
6332 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6333 that the hash value of glyph rows is correct.
6335 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6337 * window.h (window): Remove splits slot.
6338 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6339 (Fdelete_other_windows_internal, make_parent_window)
6340 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6341 (Fset_window_configuration, save_window_save): Don't deal with
6342 split status of windows.
6343 (saved_window): Remove splits slot.
6344 (Vwindow_splits): Rewrite doc-string.
6346 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6348 * xfns.c (unwind_create_frame):
6349 * nsfns.m (unwind_create_frame):
6350 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6351 Vframe_list (Bug#9999).
6353 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6355 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6357 2011-11-11 Kenichi Handa <handa@m17n.org>
6359 * callproc.c (Fcall_process): Set the member dst_multibyte of
6362 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6364 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6365 avoid a crash (bug#9496).
6367 2011-11-09 Chong Yidong <cyd@gnu.org>
6369 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6370 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6372 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6374 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6376 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6378 Avoid some portability problems by eschewing 'extern inline' functions.
6379 The trivial performance wins aren't worth the portability hassles; see
6380 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6382 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6383 (window_box_width, window_box_left, window_box_left_offset)
6384 (window_box_right, window_box_right_offset): Undo previous change,
6385 by removing the "extern"s.
6386 * intervals.c (adjust_intervals_for_insertion)
6387 (adjust_intervals_for_deletion): Undo previous change,
6388 making these static again.
6389 (offset_intervals, temp_set_point_both, temp_set_point)
6390 (copy_intervals_to_string): No longer inline.
6391 * xdisp.c (window_text_bottom_y, window_box_width)
6392 (window_box_height, window_box_left_offset)
6393 (window_box_right_offset, window_box_left, window_box_right)
6394 (window_box): No longer inline.
6396 2011-11-08 Chong Yidong <cyd@gnu.org>
6398 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6399 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6400 Signal an error if not a live window.
6401 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6402 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6404 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6406 * lisp.h (syms_of_abbrev): Remove declaration.
6407 Reported by CHENG Gao <chenggao@royau.me>.
6409 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6411 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6412 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6413 of temacs in GUI mode.
6415 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6417 * window.h: Declare delete_all_child_windows instead of
6418 delete_all_subwindows.
6419 * window.c (Fwindow_nest, Fset_window_nest)
6420 (Fset_window_new_total, Fset_window_new_normal)
6421 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6422 (delete_all_subwindows): Rename to delete_all_child_windows.
6423 (Fdelete_other_windows_internal, Fset_window_configuration):
6424 Call delete_all_child_windows instead of delete_all_subwindows.
6425 * frame.c (delete_frame): Call delete_all_child_windows instead
6426 of delete_all_subwindows.
6428 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6430 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6431 This is also needed for porting to any host where GC_MARK_STACK is
6432 not GC_MAKE_GCPROS_NOOPS.
6433 (which_symbols): Use it.
6435 2011-11-07 Kenichi Handa <handa@m17n.org>
6437 * coding.c (coding_set_destination): Check coding->src_pos only
6438 when coding->src_object is a buffer (bug#9910).
6440 * process.c (send_process): Set the member src_multibyte of coding
6441 to 0 (bug#9911) when sending a unibyte text.
6443 * callproc.c (Fcall_process): Set the member src_multibyte of
6444 process_coding to 0 (bug#9912).
6446 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6448 * xmenu.c (cleanup_widget_value_tree): New function.
6449 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6450 calling free_menubar_widget_value_tree directly (Bug#9830).
6452 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6454 Fix some portability problems with 'inline'.
6455 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6456 (window_box_width, window_box_left, window_box_left_offset)
6457 (window_box_right, window_box_right_offset): Declare extern.
6458 Otherwise, these inline functions do not conform to C99 and
6459 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6460 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6461 * intervals.c (adjust_intervals_for_insertion)
6462 (adjust_intervals_for_deletion): Now extern, because otherwise the
6463 extern inline functions 'offset_intervals' couldn't refer to it.
6464 (static_offset_intervals): Remove.
6465 (offset_intervals): Rewrite using the old contents of
6466 static_offset_intervals. The old version didn't conform to C99
6467 because an extern inline function contained a reference to an
6468 identifier with static linkage.
6470 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6472 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6475 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6477 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6478 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6479 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6480 return Qleft_to_right.
6482 2011-11-06 Chong Yidong <cyd@gnu.org>
6484 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6485 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6486 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6487 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6488 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6489 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6490 (Fwindow_vscroll): Doc fix.
6491 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6492 argument, since it makes no sense to pass a live window and for
6493 consistency with window-child.
6495 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6497 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6500 2011-11-05 Jason Rumney <jasonr@gnu.org>
6502 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6503 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6505 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6506 bitwise arithmetic preventing use of unicode-sip and non-truetype
6509 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6511 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6514 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6515 initialization code to keep similarity to xfns.c after changes
6518 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6520 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6521 (unwind_create_frame): New function (Bug#9943).
6522 (Fx_create_frame): Restructure code to be more similar to the one in
6523 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6524 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6525 Move terminal->reference_count++ just before making the frame official
6528 * nsterm.m (x_free_frame_resources): New function.
6529 (x_destroy_window): Move code to x_free_frame_resources.
6531 * xfns.c (unwind_create_frame): Fix comment.
6532 (Fx_create_frame, x_create_tip_frame):
6533 Move terminal->reference_count++ just before making the frame
6534 official. Move initialization of image_cache_refcount and
6535 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6537 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6539 Support MSVC build with newer versions of Visual Studio.
6540 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6541 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6544 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6545 which are not supported by MSVC.
6546 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6547 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6549 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6551 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6553 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6555 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6557 Support MSVC build with newer versions of Visual Studio.
6558 * w32.c: Don't include w32api.h for MSVC.
6559 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6561 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6562 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6563 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6564 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6566 (alloca) [_MSC_VER]: Define to _alloca.
6568 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6570 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6572 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6574 * xdisp.c (note_mouse_highlight): If either of
6575 previous/next-single-property-change returns nil, treat that as
6576 the beginning or the end of the buffer. (Bug#9955)
6578 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6580 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6581 label is not null (Bug#9951).
6582 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6585 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6587 * window.c (Fwindow_body_size): Mention in the doc string that the
6588 return value is in frame's canonical units. (Bug#9949)
6590 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6592 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6594 * w32fns.c (unwind_create_frame): If needed, free the glyph
6595 matrices of the partially constructed frame. (Bug#9943)
6596 * xfns.c (unwind_create_frame): Likewise.
6598 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6600 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6601 Don't stop backward scan on the continuation glyph, even though
6602 its CHARPOS is positive.
6603 (mouse_face_from_buffer_pos, note_mouse_highlight):
6604 Rename cover_string to disp_string.
6606 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6608 * window.c (temp_output_buffer_show): Don't use
6609 Vtemp_buffer_show_specifiers.
6610 (Vtemp_buffer_show_specifiers): Remove unused variable.
6612 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6614 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6615 past the beginning of the current glyph matrix.
6617 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6619 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6620 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6621 HAVE_GTK3 (Bug#9869).
6623 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6624 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6626 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6628 * xterm.c: Declare x_handle_net_wm_state to return int.
6629 (handle_one_xevent): Check if we are iconified but don't have
6630 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6631 (get_current_wm_state): Return non-zero if not hidden,
6632 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6633 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6634 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6635 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6637 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6639 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6640 so that this new function doesn't get optimized away by a
6641 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6643 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6645 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6647 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6649 Fix the `xbytecode' command.
6650 * .gdbinit (xprintbytestr): New command.
6651 (xwhichsymbols): Rename from `which'; all callers changed.
6652 (xbytecode): Print the byte-code string as well.
6654 2011-10-29 Kim Storm <storm@cua.dk>
6656 * alloc.c (which_symbols): New function.
6658 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6660 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6663 2011-10-29 Glenn Morris <rgm@gnu.org>
6665 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6666 Not clear what it was for, and it causes various bugs. (Bug#9839)
6668 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6670 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6671 possible random value that matches one of those tested as
6672 condition to clear the mouse face.
6674 2011-10-28 Chong Yidong <cyd@gnu.org>
6676 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6678 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6680 * window.c (make_window): Initialize phys_cursor_on_p.
6682 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6684 * lisp.h (struct Lisp_Symbol): Update comments.
6686 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6688 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6690 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6692 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6693 <oslsachem@gmail.com> for helping to debug this.
6695 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6696 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6697 (g_b_init_get_glyph_outline_w): New static variables.
6698 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6699 (GetGlyphOutlineW_Proc): New typedefs.
6700 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6701 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6703 (w32font_open_internal, compute_metrics):
6704 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6705 instead of calling the "wide" APIs directly.
6707 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6709 * w32.h (syms_of_w32font): Add prototype.
6711 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6713 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6714 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6715 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6716 (Fmove_to_window_line): Doc fix.
6718 2011-10-27 Chong Yidong <cyd@gnu.org>
6720 * process.c (make_process): Set gnutls_state to NULL.
6722 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6723 non-NULL, regardless of GNUTLS_INITSTAGE.
6724 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6725 an error. Set process slots as soon as we allocate them.
6727 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6729 2011-10-27 Chong Yidong <cyd@gnu.org>
6731 * gnutls.c (emacs_gnutls_deinit): New function.
6732 Deallocate credentials structures as well as calling gnutls_deinit.
6733 (Fgnutls_deinit, Fgnutls_boot): Use it.
6735 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6736 (deactivate_process): Call emacs_gnutls_deinit.
6738 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6740 * image.c (x_create_x_image_and_pixmap):
6741 * w32.c (sys_rename, w32_delayed_load):
6742 * w32font.c (fill_in_logfont):
6743 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6745 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6747 * w32fns.c (w32_default_color_map): New function,
6748 extracted from Fw32_default_color_map.
6749 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6751 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6753 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6755 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6757 * keyboard.c (test_undefined): New function (bug#9751).
6758 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6760 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6762 * sysdep.c (init_sys_modes): Fix the check for the controlling
6763 terminal (Bug#6649).
6765 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6767 * dispextern.h (struct bidi_it): New member next_en_type.
6769 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6770 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6771 current character, check also for next_en_type being WEAK_EN.
6772 (bidi_resolve_weak): Don't enter the expensive loop if the current
6773 position is before next_en_pos. Record the bidi type of the first
6774 non-ET, non-BN character we find, in addition to its position.
6775 (bidi_level_of_next_char): Invalidate next_en_type when
6776 next_en_pos is over-stepped.
6778 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6780 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6781 * editfns.c: Rewrite current-time-zone so that it invokes
6782 the equivalent of (format-time-string "%Z") to get the time zone name.
6783 This fixes a bug when the time zone name contains characters that
6784 need converting from the system time locale to Emacs internal format.
6785 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6786 that patch fixed format-time-string to do the conversion, but
6787 I forgot to fix current-time-zone.
6788 (format_time_string): New function, containing most of
6789 what Fformat_time_string used to contain.
6790 (Fformat_time_string): Rewrite in terms of format_time_string.
6791 This doesn't change this function's behavior.
6792 (current-time-zone): Rewrite to use format_time_string.
6793 This fixes the bug reported by Michael Schierl in
6794 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6795 Jason Rumney's 2007-06-07 change worked around this bug, but
6797 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6799 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6801 * xdisp.c (start_display): If the character at POS is displayed
6802 via a display vector, reset IT->current.dpvec_index to zero.
6803 (try_window_reusing_current_matrix): If a line ends in a display
6804 vector or the next line starts in a display vector, continue
6805 redrawing the window even though the character position of
6806 start_row was reached.
6809 2011-10-18 Chong Yidong <cyd@gnu.org>
6811 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6812 with nobreak-char-display too.
6814 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6816 Fix part 3 of bug#9771.
6817 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6818 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6819 non-neutral characters if the current character is a paragraph
6820 separator (a.k.a. Newline). This avoids running the same
6821 expensive loop twice, once when we consume the preceding newline
6822 and the other time when the line actually needs to be displayed.
6823 Avoid the loop when we see neutrals on the base embedding level
6824 following a character whose directionality is the same as the
6825 paragraph's. This avoids running the expensive loop when a line
6826 ends in a long sequence of neutrals, like control characters.
6827 Add assertion against STRONG_AL type. Slightly rearrange code
6828 that determines the type of a neutral given the first non-neutral
6830 (bidi_level_of_next_char): Set next_en_pos to zero when
6831 invalidating its info.
6833 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6835 * xdisp.c (push_display_prop): Determine whether to record string
6836 or buffer position by IT->string, not by IT->method. Allow
6837 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6838 (move_it_vertically_backward): Don't look for character position
6839 immediately after the newline when in a continuation line.
6842 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6844 * window.c (coordinates_in_window): Rewrite and delabelize
6845 vertical border check. (Bug#5357) (Bug#9618)
6847 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6849 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6850 errors in XSetWindowBorder (bug#9310).
6852 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6854 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6855 avoid crash when xmalloc overrun checking is enabled.
6857 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6859 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6860 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6861 cursor motion with <left> and <right> arrow keys.
6863 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6864 some callers set that themselves.
6866 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6868 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6869 display string and the previous row comes from the same string and
6870 is empty. (Bug#9739) (Bug#9738)
6872 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6874 * doc.c (get_doc_string): Encode file name (bug#9735).
6876 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6878 * bidi.c (bidi_level_of_next_char):
6879 * xdisp.c (get_visually_first_element): Remove old incorrect
6880 comments regarding the Unicode Line Separator character.
6882 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6884 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6886 * alloc.c (Fgc_status): Do not access beyond zombies array
6887 boundary if nzombies > MAX_ZOMBIES.
6888 * alloc.c (dump_zombies): Add missing format specifier.
6890 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6892 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6893 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6895 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6896 Some packages use them to denote characters with modifiers.
6898 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6900 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6901 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6902 matching a pp-number. Rename parameter var to var1.
6904 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6906 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6908 2011-10-08 Glenn Morris <rgm@gnu.org>
6910 * callint.c (Fcall_interactively): Give a more explicit error for the
6911 'c' case with a non-character input. (Bug#8479)
6913 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6915 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6917 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6918 lines that are hscrolled on the left.
6920 * dispnew.c (buffer_posn_from_coords): Account for a possible
6921 presence of header-line. (Bug#4426)
6923 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6925 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6926 Don't advertise functionality which we discourage or doesn't work.
6928 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6930 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6931 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6932 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6933 this makes Emacs dump core during garbage collection on rare
6934 occasions. sizeof is obviously inferior to offsetof here, so
6935 stick with offsetof.
6936 (GC_POINTER_ALIGNMENT): New macro.
6937 (mark_memory): Omit 3rd (offset) arg; caller changed.
6938 Don't assume EMACS_INT alignment is the same as pointer alignment.
6940 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6942 * keyboard.c (read_key_sequence_remapped): New var.
6943 (read_key_sequence): Compute remapping in the right buffer.
6944 (command_loop_1): Use read_key_sequence's remapping directly.
6946 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6948 * dired.c (file_name_completion): Don't expand file name.
6949 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6950 before checking file name handler.
6952 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6953 they've been requested explicitly (bug#9591).
6955 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6957 * keymap.c (Fsingle_key_description): Use make_specified_string
6958 instead of build_string to build string from push_key_description.
6961 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6963 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6964 This fixes a Y2038 bug on 64-bit hosts.
6965 * buffer.c (reset_buffer):
6966 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6967 (Fclear_buffer_auto_save_failure):
6968 Use 0, not -1, to represent an unset failure time, since time_t
6969 might not be signed.
6971 Remove dependency on glibc malloc internals.
6972 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6973 Move back here from lisp.h, but with their new implementations.
6974 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6975 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6976 * charset.c (charset_table_init): New static var.
6977 (syms_of_charset): Use it instead of xmalloc. This removes a
6978 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6979 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6980 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6981 Move back to alloc.c.
6982 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6983 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6985 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6987 * nsterm.m (windowDidResize): Call x_set_window_size only when
6988 ns_in_resize is true. Otherwise set pixelwidth/height and
6989 call change_frame_size (Bug#9628).
6991 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6993 Port --enable-checking=all to Fedora 14 x86-64.
6994 * charset.c (syms_of_charset): Also account for glibc malloc's
6995 internal overhead when calculating the initial malloc maximum.
6997 Port --enable-checking=all to Fedora 14 x86.
6998 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7000 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7001 (overrun_check_realloc, overrun_check_free):
7002 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7003 That way, xmalloc returns a properly-aligned pointer even if
7004 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7005 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7006 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7007 into account when calculating the initial malloc maximum.
7008 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7009 Move here from alloc.c, so that charset.c can use it too.
7010 Properly align; the old code wasn't right for common 32-bit hosts
7011 when configured with --enable-checking=all.
7012 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7013 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7015 2011-09-29 Eli Zaretskii <eliz@gnu.org>
7017 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
7020 2011-09-28 Eli Zaretskii <eliz@gnu.org>
7022 * xdisp.c (compute_display_string_end): If there's no display
7023 string at CHARPOS, return -1.
7025 * bidi.c (bidi_fetch_char): When compute_display_string_end
7026 returns a negative value, treat the character as a normal
7027 character not covered by a display string. (Bug#9624)
7029 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
7031 * lread.c (Fread_from_string): Fix typo in docstring.
7033 2011-09-27 Eli Zaretskii <eliz@gnu.org>
7035 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7036 newline, reseat the iterator instead of bidi-iterating there one
7037 character at a time. (Bug#9610)
7038 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7039 TO_CHARPOS if the bidi iterator is at base embedding level.
7041 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7043 * lread.c (readevalloop): Use correct code for NBSP.
7044 (read1): Likewise. (Bug#9608)
7046 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
7048 * dbusbind.c (Fdbus_register_signal): When service is not
7049 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7051 2011-09-25 Glenn Morris <rgm@gnu.org>
7053 * buffer.c (truncate-lines): Doc fix.
7055 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
7057 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7058 (Fset_window_next_buffers): Doc fix.
7060 2011-09-24 Glenn Morris <rgm@gnu.org>
7062 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7064 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7066 Fix minor problems found by static checking.
7067 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
7068 * indent.c (Fvertical_motion): Fix == vs = typo.
7070 2011-09-24 Eli Zaretskii <eliz@gnu.org>
7072 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7073 Default value is now t. Doc fix.
7075 * indent.c (Fvertical_motion): Compute and apply the overshoot
7076 logic when moving up, not only when moving down. Fix the
7077 confusing name and values of the it_overshoot_expected variable;
7078 logic changes accordingly. (Bug#9254) (Bug#9549)
7080 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7081 CHARPOS is covered by a display string which includes newlines.
7082 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7083 is covered by a display string with embedded newlines.
7085 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
7087 * dbusbind.c (Fdbus_register_signal): Add match rule to
7088 Vdbus_registered_objects_table. (Bug#9581)
7089 (Fdbus_register_method, Vdbus_registered_objects_table):
7092 2011-09-24 Jim Meyering <meyering@redhat.com>
7094 do not ignore write error for any output size
7095 The previous change was incomplete.
7096 While it makes emacs --batch detect the vast majority of stdout
7097 write failures, errors were still ignored whenever the output size is
7098 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7099 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7100 && echo FAIL: ignored write error
7101 FAIL: ignored write error
7102 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7103 && echo FAIL: ignored write error
7104 FAIL: ignored write error
7105 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7107 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7109 * emacs.c (Fkill_emacs): In noninteractive mode exit
7110 non-successfully if a write error occurred on stdout. (Bug#9574)
7112 2011-09-21 Eli Zaretskii <eliz@gnu.org>
7114 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7117 * dispextern.h (struct it): Update the comment documenting what
7120 2011-09-20 Eli Zaretskii <eliz@gnu.org>
7122 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7123 a display string, extend search for cursor position to end of row.
7124 (find_row_edges): If the row ends in a newline from a display
7125 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7126 Handle the case of a display string with multiple newlines.
7127 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7128 non-empty line. Fixes confusing cursor motion with arrow keys at
7129 the beginning of a line that starts with whitespace.
7131 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7133 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7136 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
7138 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7141 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7143 * xdisp.c (display_line): Record maximum and minimum buffer
7144 positions even if no glyphs were produced (e.g., by a zero-width
7145 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7146 buffer positions that will be removed from the glyph row because
7148 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7149 column is beyond frame width: don't subtract 1 "pixel" when
7150 computing width of the stretch.
7151 (reseat_at_next_visible_line_start): Undo the change made on
7152 2011-09-17 that saved paragraph information and restored it after
7153 the call to `reseat'. (Bug#9545)
7155 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7157 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7158 and turn window cursor on if cleared (Bug#9415).
7160 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
7162 * search.c (boyer_moore): Take unibyte characters from pattern
7163 literally. (Bug#9458)
7165 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7167 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7169 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7171 Fix minor problem found by static checking.
7172 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7173 initialized, to pacify gcc -Wuninitialized.
7175 * fileio.c: Report proper errno when syscall falls.
7176 (Finsert_file_contents): Save and restore errno,
7177 so that report_file_error outputs the correct diagnostic.
7178 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7180 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7182 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7184 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7186 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7187 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7189 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7191 * xdisp.c (reseat_at_next_visible_line_start): Keep information
7192 about the current paragraph and restore it after the call to reseat.
7194 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7195 (bidi_find_paragraph_start): Search back for paragraph beginning
7196 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7197 (bidi_move_to_visually_next): Only trigger paragraph-related
7198 computations when the last character is a newline or at EOB, not
7199 just any NEUTRAL_B. (Bug#9470)
7201 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7202 truncated lines if point is covered by a display string. (Bug#9524)
7204 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7206 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7207 (cons_to_x_long): New function.
7208 (lisp_data_to_selection_data): Use it. Correct the test for
7209 short-versus-long data; it was negated. Break out of vector
7210 loop, for efficiency, when a long datum is discovered.
7212 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7214 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7216 2011-09-16 Eli Zaretskii <eliz@gnu.org>
7218 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7219 GCC PR/17406) by declaring this function with external scope.
7221 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7223 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7224 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7226 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7228 * editfns.c (Fformat): Correctly handle text properties on "%%".
7230 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7232 * xterm.c (x_draw_composite_glyph_string_foreground):
7233 * w32term.c (x_draw_composite_glyph_string_foreground):
7234 * term.c (encode_terminal_code):
7235 * composite.c (composition_update_it, get_composition_id):
7236 * xdisp.c (get_next_display_element)
7237 (fill_composite_glyph_string): Add comments about special meaning
7238 of TAB characters in a composition.
7240 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7242 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
7243 This occurs when processing a multibyte format.
7244 Problem reported by Wolfgang Jenker.
7246 2011-09-15 Johan Bockgård <bojohan@gnu.org>
7248 * xdisp.c (try_cursor_movement): Only check for exact match if
7249 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7251 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7253 Remove unused external symbols.
7254 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7255 * xdisp.c (calc_pixel_width_or_height): Now static.
7256 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7257 * indent.c (check_display_width):
7258 * w32term.c: Fix comment to match code.
7259 * xterm.c, xterm.h (x_catching_errors): Remove.
7261 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7263 * xselect.c: Use signed conversions more consistently (Bug#9498).
7264 (selection_data_to_lisp_data): Assume incoming selection data are
7265 signed integers, not unsigned. This is to be consistent with
7266 outgoing selection data, which was modified to use signed integers
7267 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7268 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7269 expects long, not unsigned long.
7271 2011-09-14 Eli Zaretskii <eliz@gnu.org>
7273 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7274 computation of loop end. Reported by Johan Bockgård
7277 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
7279 * frame.c (Fother_visible_frames_p): Function deleted.
7281 2011-09-12 Eli Zaretskii <eliz@gnu.org>
7283 * indent.c (compute_motion): Process display vector front to back
7284 rather than the other way around. (Bug#2496)
7286 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7288 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7290 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
7292 * minibuf.c (Fread_from_minibuffer): Doc fix.
7294 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7296 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7297 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7299 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7301 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7302 value for non-existent files.
7304 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7306 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7307 set its "size" to -1. This will set the modtime_size field of
7308 the corresponding buffer to -1, which is what
7309 verify-visited-file-modtime expects for files that do not exist.
7312 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7314 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7316 * lisp.h: ... from here. push_key_description is no longer
7317 defined in keyboard.c, so its declaration should not be in
7318 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7319 logically belongs with push_key_description.
7321 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7323 * buffer.h: Include <sys/types.h> instead of <time.h>.
7324 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7325 Problem reported by Herbert J. Skuhra.
7327 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7329 * xml.c (parse_region): Make the parsing work for
7330 non-comment-starting XML files again (bug#9144).
7332 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7334 * image.c (gif_load): Fix calculation of bottom and right corner.
7337 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7339 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7340 redisplay in small windows.
7342 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7344 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7346 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7348 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7349 Operate on live windows only.
7351 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7353 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7355 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7357 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7358 only under bidi iteration.
7360 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7362 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7364 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7366 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7367 Without this fix, the command to link temacs failed due to an
7368 undefined symbol __builtin_isnan. This is because
7369 /usr/include/iso/math_c99.h #defines isnan(x) to
7370 __builtin_isnan(x), but the bundled gcc, which identifies itself
7371 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7373 * floatfns.c (isnan): #undef, and then #define to a clone of
7375 (Fisnan): Always define, since it's always available now.
7376 (syms_of_floatfns): Always define isnan at the Lisp level.
7378 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7380 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7382 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7384 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7385 The previous code assumed that file offsets (off_t values) fit in
7386 EMACS_INT variables, which is not true on typical 32-bit hosts.
7387 The code messed up by falsely reporting buffer overflow in cases
7388 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7389 when "big" contains more than 2**29 bytes, even though this
7390 inserts just one byte and does not overflow the buffer.
7391 (Finsert_file_contents): Store file offsets as off_t
7392 values, not as EMACS_INT values. Check for overflow when
7393 converting between EMACS_INT and off_t. When checking for
7394 buffer overflow or for overlap, take the offsets into account.
7395 Don't use EMACS_INT for small values where int suffices.
7396 When checking for overlap, fix a typo: ZV was used where
7397 ZV_BYTE was intended.
7398 (Fwrite_region): Don't assume off_t fits into 'long'.
7399 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7401 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7403 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7405 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7407 sprintf-related integer and memory overflow issues (Bug#9412).
7409 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7410 (esprintf, exprintf, evxprintf): New functions.
7411 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7412 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7413 (modify_event_symbol): Do not assume that the length of
7414 name_alist_or_stem is safe to alloca and fits in int.
7415 (Fexecute_extended_command): Likewise for function name and binding.
7416 (Frecursion_depth): Wrap around reliably on integer overflow.
7417 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7418 since some callers pass EMACS_INT values.
7419 (Fsingle_key_description): Don't crash if symbol name contains more
7420 than MAX_ALLOCA bytes.
7421 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7422 (get_minibuffer): Arg is now EMACS_INT, not int.
7423 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7424 (esprintf, exprintf, evxprintf): New decls.
7425 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7427 * dbusbind.c (signature_cat): New function.
7428 (xd_signature, Fdbus_register_signal):
7429 Do not overrun buffer; instead, report string overflow.
7431 * dispnew.c (add_window_display_history): Don't overrun buffer.
7432 Truncate instead; this is OK since it's just a log.
7434 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7435 even if the time zone offset is outlandishly large.
7436 Don't mishandle offset == INT_MIN.
7438 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7439 when creating daemon; the previous buffer-overflow check was incorrect.
7441 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7442 which has the guts of the old verror function.
7444 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7445 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7447 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7448 (font_unparse_xlfd): Don't blindly alloca long strings.
7449 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7450 fits in int, when using sprintf. Use single snprintf to count
7451 length of string rather than counting it via multiple sprintfs;
7452 that's simpler and more reliable.
7453 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7454 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7455 sprintf, in case result does not fit in int.
7457 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7458 (fontset_from_font): Print it.
7460 * frame.c (tty_frame_count): Now printmax_t, not int.
7461 (make_terminal_frame, set_term_frame_name): Print it.
7462 (x_report_frame_params): In X, window IDs are unsigned long,
7463 not signed long, so print them as unsigned.
7464 (validate_x_resource_name): Check for implausibly long names,
7465 and don't assume name length fits in 'int'.
7466 (x_get_resource_string): Don't blindly alloca invocation name;
7467 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7470 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7471 (xg_check_special_colors, xg_set_geometry):
7472 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7474 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7475 Use esprintf, not sprintf, in case result does not fit in int.
7477 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7478 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7479 it as a large positive number.
7480 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7481 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7483 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7484 in case result does not fit in int.
7486 * print.c (float_to_string): Detect width overflow more reliably.
7487 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7488 buffer overrun. Don't assume list length fits in 'int'. Treat
7489 print length of 0 as 0, not as infinity; to be consistent with other
7490 uses of print length in this function. Don't overflow print length
7491 index. Don't assume hash table size fits in 'long', or that
7492 vectorlike size fits in 'unsigned long'.
7494 * process.c (make_process): Use printmax_t, not int, to format
7495 process-name gensyms.
7497 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7499 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7500 to avoid potential buffer overrun.
7502 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7503 if X resource line is longer than 512 bytes.
7505 * xfns.c (x_window): Make sprintf buffer a bit bigger
7506 to avoid potential buffer overrun.
7508 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7510 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7512 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7514 Integer overflow fixes for scrolling, etc.
7515 Without these, Emacs silently mishandles large integers sometimes.
7516 For example, "C-u 4294967297 M-x recenter" was treated as if
7517 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7519 * xdisp.c (try_window_id): Check Emacs fixnum range before
7520 converting to 'int'.
7522 * window.c (window_scroll_line_based, Frecenter):
7523 Check that an Emacs fixnum is in range before assigning it to 'int'.
7524 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7525 values converted from Emacs fixnums.
7526 (Frecenter): Don't wrap around a line count if it is out of 'int'
7527 range; instead, treat it as an extreme value.
7528 (Fset_window_configuration, compare_window_configurations):
7529 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7531 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7532 that can exceed INT_MAX. Check that EMACS_INT value is in range
7533 before assigning it to the (possibly-narrower) index.
7534 (match_limit): Don't assume that a fixnum can fit in 'int'.
7536 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7539 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7540 (Fvertical_motion): Don't wrap around LINES values that don't fit
7541 in 'int'. Instead, treat them as extreme values. This is good
7542 enough for windows, which can't have more than INT_MAX lines anyway.
7544 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7546 * Require libxml/parser.h to avoid compilation warning.
7548 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7550 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7551 since this reportedly can destroy thread storage.
7553 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7555 * syntax.c (find_defun_start): Update all cache variables if
7556 exiting early (Bug#9401).
7558 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7560 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7562 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7563 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7564 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7566 * term.c (tty_append_glyph): New function.
7567 (produce_stretch_glyph): Static function and its prototype deleted.
7569 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7572 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7574 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7575 when checking :margin (Bug#9390).
7576 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7577 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7578 so that the name doesn't mislead. All uses changed.
7580 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7582 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7585 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7587 * xdisp.c (move_it_to): Don't bail out early when reaching
7588 position beyond to_charpos, if we are scanning backwards.
7589 (move_it_vertically_backward): When DY == 0, make sure we get to
7590 the first character in the line after the newline.
7592 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7594 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7595 (ccl_driver): Do not generate an out-of-range pointer.
7596 (Fccl_execute_on_string): Remove unnecessary check for
7597 integer overflow, noted by Stefan Monnier in
7598 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7599 Remove a FIXME that didn't need fixing.
7600 Simplify the newly-introduced buffer reallocation code.
7602 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7604 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7606 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7608 Integer and memory overflow issues (Bug#9196).
7610 * doc.c (get_doc_string): Rework so that
7611 get_doc_string_buffer_size is the actual buffer size, rather than
7612 being 1 less than the actual buffer size; this makes xpalloc more
7615 * image.c (x_allocate_bitmap_record, cache_image):
7616 * xselect.c (Fx_register_dnd_atom):
7617 Simplify previous changes by using xpalloc.
7619 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7620 since either will do and ptrdiff_t is convenient with xpalloc.
7622 * charset.c (charset_table_size)
7623 (struct charset_sort_data.priority): Now ptrdiff_t.
7624 (charset_compare): Don't overflow if priorities differ greatly.
7625 (Fsort_charsets): Don't assume list length fits in int.
7626 Check for size-calculation overflow when allocating sort data.
7627 (syms_of_charset): Allocate an initial charset table that is
7628 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7630 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7632 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7633 The actual value is always <= INT_MAX, and leaving it unsigned made
7634 overflow checking harder.
7636 * dispextern.h (struct glyph_matrix.rows_allocated)
7637 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7638 with xpalloc. The values are still always <= INT_MAX.
7640 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7642 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7643 (SAFE_NALLOCA): New macro.
7645 * region-cache.c (struct boundary.pos, find_cache_boundary)
7646 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7647 (set_cache_region, invalidate_region_cache)
7648 (revalidate_region_cache, know_region_cache, region_cache_forward)
7649 (region_cache_backward, pp_cache):
7650 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7651 so that ptrdiff_t * can be passed to xpalloc.
7652 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7653 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7654 (pp_cache): Don't assume cache_len fits in int.
7655 * region-cache.h: Adjust extern decls to match.
7657 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7658 EMACS_INT, since either will do, for xpalloc.
7660 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7661 (xnmalloc, xnrealloc, xpalloc): New functions.
7663 * bidi.c (bidi_shelve_header_size): New constant.
7664 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7665 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7667 * bidi.c (bidi_cache_shrink):
7668 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7670 Don't update size of array until after memory allocation succeeds,
7671 because xmalloc/xrealloc may not return.
7672 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7673 now that we have proper integer overflow checking.
7674 (record_overlay_string, overlay_strings): Catch overflows when
7675 calculating size of overlay_str_buf.
7677 * callproc.c (Fcall_process): Check for size overflow when
7678 calculating size of args2.
7679 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7680 Normally we prefer signed values, but sticking with ptrdiff_t would
7681 require adding more-complicated checks.
7683 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7684 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7685 Redo buffer-overflow calculations to avoid integer overflow.
7686 Add a FIXME comment where memory seems to be over-allocated.
7688 * character.c (Fstring): Check for size-calculation overflow.
7690 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7691 unnecessary integer overflow. Check for size overflow.
7692 (encode_coding_object): Don't update size until xmalloc succeeds.
7694 * composite.c (get_composition_id): Check for overflow in glyph
7695 length calculations.
7697 Integer and memory overflow fixes for display code.
7698 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7699 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7700 (scrolling_window): Check for overflow in size calculations.
7701 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7702 Don't assume glyph table len fits in int.
7703 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7704 (row_table_size): Now ptrdiff_t, not int.
7705 (scrolling_window): Avoid overflow in size calculations.
7706 Don't update size until allocation succeeds.
7707 * fns.c (concat): Check for overflow in size calculations.
7708 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7709 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7710 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7712 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7713 (get_doc_string): Check for size calculation overflow.
7714 Don't update size until allocation succeeds.
7715 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7716 EMACS_INT, where ptrdiff_t will do.
7717 (Fsubstitute_command_keys): Check for string overflow.
7719 * editfns.c (set_time_zone_rule): Don't assume environment length
7721 (message_length): Now ptrdiff_t, not int.
7722 (Fmessage_box): Don't update size until allocation succeeds.
7723 Don't assume message length fits in int.
7724 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7726 * emacs.c (main): Do not reallocate argv, since there is a null at
7727 the end that can be overwritten, and this way there's no need to
7728 worry about size-calculation overflow.
7729 (sort_args): Check for size-calculation overflow.
7731 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7733 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7735 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7736 (x_set_scroll_bar_width, x_figure_window_size):
7737 Check for integer overflow.
7738 (x_set_alpha): Do not assume XINT fits in int.
7740 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7741 This is for the members text_lines, text_cols, total_lines, total_cols,
7742 where the system imposes an 'int' limit.
7744 * fringe.c (Fdefine_fringe_bitmap):
7745 Don't update size until alloc works.
7747 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7748 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7750 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7751 Check for size-calculation overflow.
7752 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7753 do, as we prefer signed integers.
7754 (id_to_widget.max_size, id_to_widget.used)
7755 (xg_store_widget_in_map, xg_remove_widget_from_map)
7756 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7757 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7758 Use and return ptrdiff_t, not int.
7759 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7760 * gtkutil.h: Change prototypes to match the above.
7762 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7763 are duplicate now that they've been promoted to lisp.h.
7764 (x_allocate_bitmap_record, x_alloc_image_color)
7765 (make_image_cache, cache_image, xpm_load):
7766 Don't update size until alloc is done.
7767 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7769 Check for size calculation overflow.
7770 (ct_colors_allocated_max): New constant.
7771 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7774 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7775 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7776 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7777 Use ptrdiff_t, not int, to count maps.
7778 (read_char_minibuf_menu_prompt): Check for overflow in size
7779 calculations. Don't update size until allocation succeeds.
7780 Redo calculations to avoid overflow.
7781 * keyboard.h: Change prototypes to match the above.
7783 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7785 (current_minor_maps): Check for size calculation overflow.
7786 * keymap.h: Change prototypes to match the above.
7788 * lread.c (read1, init_obarray): Don't update size until alloc done.
7790 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7791 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7793 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7794 Now ptrdiff_t, not int.
7795 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7796 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7798 * process.c (Fnetwork_interface_list): Check for overflow
7799 in size calculation.
7801 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7803 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7804 overflow. Don't bother calling xmalloc when xrealloc will do.
7806 * search.c (Freplace_match): Check for size calculation overflow.
7807 (Fset_match_data): Don't assume list lengths fit in 'int'.
7809 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7810 for command line length. Do not attempt to address one before the
7811 beginning of an array, as that's not portable.
7813 * term.c (max_frame_lines): Remove; unused.
7814 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7816 (encode_terminal_code, calculate_costs): Check for size
7817 calculation overflow.
7818 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7819 table lengths and related sizes. Don't update size until alloc
7820 done. Redo calculations to avoid overflow.
7821 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7823 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7824 subtracting pointers.
7825 (gobble_line): Check for overflow more carefully. Don't update size
7828 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7829 Don't update size until alloc done.
7830 Redo size calculations to avoid overflow.
7831 Check for size calculation overflow.
7832 (main) [DEBUG]: Fix typo in invoking tparam1.
7834 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7835 Use ptrdiff_t, not int, for sizes.
7836 (store_mode_line_noprop_char): Don't update size until alloc done.
7838 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7839 Use ptrdiff_t, not int, for sizes.
7840 (Finternal_make_lisp_face, cache_face):
7841 Check for size calculation overflow.
7842 (cache_face): Treat size calculation overflows as if they were
7843 memory exhaustion (the usual treatment), rather than aborting.
7845 * xfns.c (x_encode_text, x_set_name_internal)
7846 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7847 sizes, since they can exceed INT_MAX in size. Check for size
7848 calculation overflow.
7850 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7851 (xg_select): Check for size calculation overflow.
7852 Don't update size until alloc done.
7854 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7855 as sprintf is limited to int lengths.
7857 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7858 (X_LONG_MIN): New macros.
7859 Use them to make the following changes clearer.
7860 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7861 This change doesn't affect the value now, but it may help remind
7862 future maintainers not to raise the value too much later.
7863 (SELECTION_QUANTUM): Remove, replacing with ...
7864 (selection_quantum): ... new function, which avoids overflow.
7866 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7867 assumption that selection length fits in 'int'.
7868 (x_reply_selection_request, x_handle_selection_request)
7869 (x_get_window_property, receive_incremental_selection)
7870 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7871 (lisp_data_to_selection_data, clean_local_selection_data):
7872 Use ptrdiff_t, not int, to record length of selection.
7873 (x_reply_selection_request, x_get_window_property)
7874 (receive_incremental_selection, x_property_data_to_lisp):
7875 Redo calculations to avoid overflow.
7876 (x_reply_selection_request): When sending hint, ceiling it at
7877 X_LONG_MAX rather than relying on wraparound overflow to send
7879 (x_get_window_property, receive_incremental_selection)
7880 (lisp_data_to_selection_data, x_property_data_to_lisp):
7881 Check for size-calculation overflow.
7882 (x_get_window_property, receive_incremental_selection)
7883 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7884 Don't store size until memory allocation succeeds.
7885 (x_get_window_property): Plug memory leak on memory exhaustion.
7886 Don't double-block input; malloc is safe here. Don't assume 2**34
7887 - 4 fits in unsigned long. Add an xassert to check
7888 XGetWindowProperty overflow. Be more careful about overflow
7889 calculations, and distinguish size from memory overflow better.
7890 (receive_incremental_selection): When tracing, don't assume
7891 unsigned int is less than INT_MAX.
7892 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7893 harmful) conversions of unsigned short to int.
7894 (lisp_data_to_selection_data): Don't assume that integers
7895 in the range -65535 through -1 fit in an X unsigned short.
7896 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7897 result parameters unless successful. Rely on cons_to_unsigned
7898 to report problems with elements; the old code wasn't right anyway.
7899 (x_check_property_data): Check for int overflow; we cannot use
7900 a wider type due to X limits.
7901 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7903 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7905 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7906 (x_term_init): Check for size calculation overflow.
7907 (x_color_cells): Don't store size until memory allocation succeeds.
7908 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7909 Don't assume alloca size is less than MAX_ALLOCA.
7910 (x_term_init): Don't assume length fits in int (sprintf is limited
7913 Use ptrdiff_t for composition IDs.
7914 * character.c (lisp_string_width):
7915 * composite.c (composition_table_size, n_compositions)
7916 (get_composition_id, composition_gstring_from_id):
7917 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7918 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7919 * window.c (Frecenter):
7920 Use ptrdiff_t, not int, for composition IDs.
7921 * composite.c (get_composition_id): Check for integer overflow.
7922 * composite.h: Adjust prototypes to match the above changes.
7924 Use ptrdiff_t for hash table indexes.
7925 * category.c (hash_get_category_set):
7926 * ccl.c (ccl_driver):
7927 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7928 * coding.c (coding_system_charset_list, detect_coding_system):
7929 * coding.h (struct coding_system.id):
7930 * composite.c (get_composition_id, gstring_lookup_cache):
7931 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7932 * image.c (xpm_get_color_table_h):
7933 * lisp.h (hash_lookup, hash_put):
7934 * minibuf.c (Ftest_completion):
7935 Use ptrdiff_t for hash table indexes, not int (which is too
7936 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7937 32-bit --with-wide-int hosts).
7939 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7940 Add a FIXME comment about memory leaks.
7941 (syms_of_charset): Don't assume xmalloc returns.
7943 Don't assume that stated character widths fit in int.
7944 * character.c (Fchar_width, c_string_width, lisp_string_width):
7945 * character.h (CHAR_WIDTH):
7946 * indent.c (MULTIBYTE_BYTES_WIDTH):
7947 Use sanitize_char_width to avoid undefined and/or bad behavior
7948 with outlandish widths.
7949 * character.h (sanitize_tab_width): Rename from sanitize_width,
7950 now that we have two such functions. All uses changed.
7951 (sanitize_char_width): New inline function.
7953 Don't assume that tab-width fits in int.
7954 * character.h (sanitize_width): New inline function.
7955 (SANE_TAB_WIDTH): New macro.
7956 (ASCII_CHAR_WIDTH): Use it.
7957 * indent.c (sane_tab_width): Remove. All uses replaced by
7958 SANE_TAB_WIDTH (current_buffer).
7959 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7961 * fileio.c: Integer overflow issues with file modes.
7962 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7964 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7965 Remove unreachable code.
7966 (read_hex, load_charset_map_from_file): Check for integer overflow.
7968 * xterm.c: Don't go over XClientMessageEvent limit.
7969 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7970 (x_send_scroll_bar_event): Likewise. Check that the size does not
7971 exceed limits imposed by XClientMessageEvent, as well as the usual
7972 ptrdiff_t and size_t limits.
7974 * keyboard.c: Overflow, signedness and related fixes.
7975 (make_lispy_movement): Use same integer type in forward decl
7976 that is used in the definition.
7977 (read_key_sequence, keyremap_step):
7978 Change bufsize argument back to int, undoing my 2011-03-30 change.
7979 We prefer signed types, and int is wide enough here.
7980 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7981 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7982 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7983 length, not size_t. Use ptrdiff_t for index, not int.
7984 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7985 possibility of integer overflow.
7987 Overflow, signedness and related fixes for images.
7989 * dispextern.h (struct it.stack[0].u.image.image_id)
7990 (struct_it.image_id, struct image.id, struct image_cache.size)
7991 (struct image_cache.used, struct image_cache.ref_count):
7992 * gtkutil.c (update_frame_tool_bar):
7993 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7994 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7995 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7996 * nsmenu.m (update_frame_tool_bar):
7997 * xdisp.c (calc_pixel_width_or_height):
7998 * xfns.c (image_cache_refcount):
7999 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8000 on typical 64-bit hosts.
8002 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8003 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8004 Omit unnecessary casts to int.
8005 (parse_image_spec): Check that integers fall into 'int' range
8006 when the callers expect that.
8007 (image_ascent): Redo ascent calculation to avoid int overflow.
8008 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8009 (lookup_image): Remove unnecessary tests.
8010 (xbm_image_p): Locals are now of int, not EMACS_INT,
8011 since parse_image_check makes sure they fit into int.
8012 (png_load, gif_load, svg_load_image):
8013 Prefer int to unsigned where either will do.
8014 (tiff_handler): New function, combining the cores of the
8015 old tiff_error_handler and tiff_warning_handler.
8016 This function is rewritten to use vsnprintf and thereby avoid
8017 stack buffer overflows. It uses only the features of vsnprintf
8018 that are common to both POSIX and native Microsoft.
8019 (tiff_error_handler, tiff_warning_handler): Use it.
8020 (tiff_load, gif_load, imagemagick_load_image):
8021 Don't assume :index value fits in 'int'.
8022 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8023 (imagemagick_load_image): Check that crop parameters fit into
8024 the integer types that MagickCropImage accepts. Don't assume
8025 Vimagemagick_render_type has a nonnegative value. Don't assume
8026 size_t fits in 'long'.
8027 (gs_load): Use printmax_t to print the widest integers possible.
8028 Check for integer overflow when computing image height and width.
8030 2011-08-26 Eli Zaretskii <eliz@gnu.org>
8032 * xdisp.c (redisplay_window): Don't force window start if point
8033 will be invisible in the resulting window. (Bug#9324)
8035 2011-08-25 Eli Zaretskii <eliz@gnu.org>
8037 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8038 the display spec is of the form `(space ...)'.
8039 (handle_display_spec): Return the value returned by
8040 handle_single_display_spec, not just 1 or zero.
8041 (handle_single_display_spec): If the display spec is of the form
8042 `(space ...)', and specifies display in the text area, return 2
8044 (try_cursor_movement): Check for the need to scroll more
8045 accurately, and prefer exact match for point under bidi.
8046 Don't advance `row' beyond the last row of the window.
8048 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8049 into disp_prop; all users changed.
8051 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8052 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8053 for the text covered by the display property.
8055 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
8057 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8058 Change return value to nil.
8059 (Frecord_buffer): Delete unused function.
8061 2011-08-24 Eli Zaretskii <eliz@gnu.org>
8063 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8064 buffers, return left-to-right.
8065 (set_cursor_from_row): Consider candidate row a win if its glyph
8066 represents a newline and point is on that newline. Fixes cursor
8067 positioning on the newline at EOL of R2L text within L2R
8068 paragraph, and vice versa.
8069 (try_cursor_movement): Check continued rows, in addition to
8070 continuation rows. Fixes unwarranted scroll when point enters a
8071 continued line of R2L text within an L2R paragraph, or vice versa.
8072 (cursor_row_p): Consider the case of point being equal to
8073 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8074 from the end of a short line to the beginning of a continued line
8075 of R2L text within L2R paragraph.
8076 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8077 composed characters.
8079 * bidi.c (bidi_check_type): Use xassert.
8080 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8083 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8085 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8088 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
8090 * nsfont.m (ns_otf_to_script): Fix typo.
8092 2011-08-22 Kenichi Handa <handa@m17n.org>
8094 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8095 extra slot even if the purpose is char-code-property-table.
8097 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8099 * xdisp.c (redisplay_window): When computing centering_position,
8100 account for the height of the header line. (Bug#8874)
8102 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8103 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8104 candidate is selected by the mouse, and that candidate has a
8105 composed character under the mouse.
8107 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8108 coordinates reported by pos-visible-in-window-p for a composed
8109 character in column zero.
8111 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8113 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8115 2011-08-22 Eli Zaretskii <eliz@gnu.org>
8117 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8118 consider it a hit if to_charpos is anywhere in the range of the
8119 composed buffer positions.
8121 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
8123 * image.c (gif_load): Don't assume that each subimage has the same
8124 dimensions as the base image. Handle disposal method that is
8125 "undefined" by the gif spec (Bug#9335).
8127 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
8129 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
8130 (Fcondition_case): Document `debug' symbol in error handler.
8132 2011-08-19 Eli Zaretskii <eliz@gnu.org>
8134 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8135 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8136 from an Org mode buffer to a Speedbar frame.
8138 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8139 a composition, take its buffer position from IT->cmp_it.charpos.
8140 Fixes cursor positioning at the beginning of a line that begins
8141 with a composed character.
8143 2011-08-18 Eli Zaretskii <eliz@gnu.org>
8145 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8146 character bidirectional type, use STRONG_L instead. Fixes crashes
8147 in a buffer produced by `describe-categories'.
8149 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8150 members before the level stack, so they would be saved and
8151 restored when copying iterator state. Fixes incorrect reordering
8152 around TABs covered by display properties.
8154 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8156 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
8158 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
8160 * eval.c (internal_condition_case, internal_condition_case_1)
8161 (internal_condition_case_2, internal_condition_case_n):
8162 Remove unnecessary aborts (Bug#9081).
8164 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8166 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8167 has no `load' handler, try opening the file locally. (Bug#9311)
8169 2011-08-16 Ken Brown <kbrown@cornell.edu>
8171 * gmalloc.c: Expand comment.
8173 2011-08-16 Eli Zaretskii <eliz@gnu.org>
8175 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8176 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8178 2011-08-16 Ken Brown <kbrown@cornell.edu>
8180 Fix memory allocation problems in Cygwin build (Bug#9273).
8182 * unexcw.c ( __malloc_initialized): Declare external variable.
8183 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8185 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8187 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8189 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8191 [CYGWIN] (special_realloc): New function.
8192 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8193 requests to realloc storage in the static heap.
8195 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8197 * bidi.c (bidi_initialize): Remove unused local.
8199 2011-08-15 Eli Zaretskii <eliz@gnu.org>
8202 * biditype.h: Remove file.
8203 * makefile.w32-in ($(BLD)/bidi.$(O)):
8204 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
8206 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8208 * chartab.c: Improve commentary for the uniprop_table API.
8210 * bidi.c (bidi_paragraph_init): Support zero value of
8211 bidi_ignore_explicit_marks_for_paragraph_level.
8212 (bidi_initialize): Use uniprop_table instead of including
8213 biditype.h and bidimirror.h.
8215 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8216 coordinates of the iterator when restoring from ppos_it.
8219 2011-08-14 Kenichi Handa <handa@m17n.org>
8221 * process.c (create_process): Call setup_process_coding_systems
8222 after the pid of the process is set to -1 (Bug#8162).
8224 2011-08-14 Eli Zaretskii <eliz@gnu.org>
8226 * xdisp.c (move_it_in_display_line_to): Don't invoke
8227 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8228 ppos_it. Fixes vertical cursor motion when line beginning is
8229 covered by an image. (Bug#9296)
8231 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8233 * nsterm.h (ns_run_ascript): Declare.
8234 (NSAPP_DATA2_RUNASSCRIPT): Define.
8236 * nsfns.m (as_script, as_result, as_status): New static variables.
8237 (ns_run_ascript): New function.
8238 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
8239 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8240 the event loop. Get status from as_status (Bug#7276).
8242 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8243 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8244 the event loop (Bug#7276).
8246 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8248 * gnutls.c (QCgnutls_bootprop_priority)
8249 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8250 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8251 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8252 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8253 (QCgnutls_bootprop_verify_hostname_error)
8254 (QCgnutls_bootprop_callbacks_verify): Rename from
8255 Qgnutls_bootprop_..., all uses changed.
8257 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8260 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8262 * xfaces.c (Qframe_set_background_mode): Now static.
8263 * dispextern.h (Qframe_set_background_mode): Remove decl.
8265 * process.c (Fnetwork_interface_info): Declare local only if needed.
8267 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8269 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8270 (Fnetwork_interface_list): Allocate in increments of bytes instead
8271 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8272 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8274 (struct ifflag_def): notrailers is smart on OSX.
8275 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8276 Get hardware address with getifaddrs if available.
8278 2011-08-12 Eli Zaretskii <eliz@gnu.org>
8280 * xdisp.c (iterate_out_of_display_property): xassert that
8281 IT->position is set to within IT->object's boundaries. Break from
8282 the loop as soon as EOB is reached; avoids infloops in redisplay
8283 when IT->position is set up wrongly due to some bug.
8284 Set IT->current to match the bidi iterator unconditionally.
8285 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8286 entry. Force push_it to save on the stack the current
8287 buffer/string position, to be restored by pop_it. Fix flags in
8288 the iterator structure wrt the object coming from a display
8289 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8290 properties. (Bug#9284)
8292 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
8294 * fontset.c (fontset_get_font_group): Add proper type checks.
8297 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8299 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8300 and LC_VERSION_MIN_MACOSX.
8301 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8302 (dump_it) [LC_FUNCTION_STARTS]: Use it.
8304 2011-08-08 Eli Zaretskii <eliz@gnu.org>
8306 * xdisp.c (forward_to_next_line_start): Allow to use the
8307 no-display-properties-and-no-overlays under bidi display.
8308 Set disp_pos in the bidi iterator to avoid searches for display
8309 properties and overlays.
8311 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8313 * editfns.c (Fset_time_zone_rule): Document relationship with the
8316 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8317 the font entity extracted from the cache (Bug#8109).
8319 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8321 * composite.c (autocmp_chars): Don't reset point. That is done by
8322 restore_point_unwind (Bug#5984).
8324 2011-08-07 Juri Linkov <juri@jurta.org>
8326 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8327 to show the arg `TIME' instead of `TIMEVAL'.
8329 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8331 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8332 display property strides EOL and includes a newline, as in
8333 longlines-mode. (Bug#9254)
8334 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8335 word-wrap under bidirectional display. (Bug#9224)
8337 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8338 is non-zero, even if the data buffer is NULL. Fixes a crash in
8339 vertical-motion with longlines-mode. (Bug#9254)
8341 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8343 * bidi.c <bidi_cache_total_alloc>: Now static.
8344 (bidi_initialize): Initialize bidi_cache_total_alloc.
8346 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8349 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8350 amount allocated this far in `bidi_cache_total_alloc'.
8351 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8352 non-zero, only free the data buffer without restoring the cache
8353 contents. All callers changed.
8355 * dispextern.h (bidi_unshelve_cache): Update prototype.
8357 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8358 (move_it_in_display_line, move_it_to)
8359 (move_it_vertically_backward, move_it_by_lines): Replace the call
8360 to xfree to an equivalent call to bidi_unshelve_cache.
8361 (move_it_in_display_line_to): Fix logic of returning
8362 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8364 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8366 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8367 came from a string character with a `cursor' property. (Bug#9229)
8369 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8371 * Makefile.in (LIB_PTHREAD): New variable.
8372 (LIBES): Add LIB_PTHREAD (Bug#9216).
8374 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8375 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8377 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8379 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8381 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8383 * xterm.c (x_find_topmost_parent): New function.
8384 (x_set_frame_alpha): Find topmost parent window with
8385 x_find_topmost_parent and set the property there also (bug#9181).
8386 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8388 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8390 * callproc.c (Fcall_process): Avoid vfork clobbering
8391 the local vars buffer, coding_systems, current_dir.
8393 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8395 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8397 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8399 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8400 so that it is not optimized away.
8402 * xdisp.c (compute_display_string_pos): Remove unused local.
8404 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8406 Fix slow cursor motion and scrolling in large buffers with
8407 selective display, like Org Mode buffers. (Bug#9218)
8409 * dispextern.h (struct bidi_it): New member disp_prop_p.
8411 * xdisp.c: Remove one-slot cache of display string positions.
8412 (compute_display_string_pos): Accept an additional argument
8413 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8414 for a display string or property. If found, set DISP_PROP_P
8417 * bidi.c (bidi_fetch_char): Accept an additional argument
8418 DISP_PROP_P, and pass it to compute_display_string_pos.
8419 Only handle text covered by a display string if DISP_PROP_P is returned
8420 non-zero. All callers of bidi_fetch_char changed.
8422 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8424 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8426 2010-12-03 Don March <don@ohspite.net>
8428 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8429 last character M-[char] is translated to ESC [char] (bug#7541).
8431 2011-08-02 Kenichi Handa <handa@m17n.org>
8433 * lisp.h (uniprop_table): Extern it.
8435 * chartab.c (uniprop_table): Make it non-static.
8437 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8439 * xdisp.c (forward_to_next_line_start): Accept additional argument
8440 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8442 (reseat_at_next_visible_line_start): Use the bidi iterator state
8443 returned by forward_to_next_line_start to restore the state of
8444 it->bidi_it after backing up to previous newline. (Bug#9212)
8446 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8448 * regex.c (re_comp): Protoize.
8449 (re_exec): Fix return type.
8450 (regexec): Fix type of `ret'. (Bug#9203)
8452 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8454 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8455 This is needed if max-image-size is a floating-point number.
8457 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8459 * print.c (print_object): Print empty symbol as ##.
8461 * lread.c (read1): Read ## as empty symbol.
8463 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8465 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8466 setting frame foreground color (Bug#9175).
8467 (x_set_background_color): Likewise.
8469 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8470 contents (Bug#9176).
8471 (EmacsTooltip -init): Remove bezels and add shadows to
8474 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8475 or scroll bar (Bug#8470).
8477 * nsfont.m (nsfont_open): Remove assignment to voffset and
8478 unnecessary vars hshink, expand, hd, full_height, min_height.
8479 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8481 * nsterm.h (nsfont_info): Remove voffset field.
8483 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8485 Implement strike-through and overline on NextStep (Bug#8863).
8487 * nsfont.m (nsfont_open): Use underline position provided by font,
8488 instead of hard-coded value of 2.
8489 (nsfont_draw): Call ns_draw_text_decoration instead.
8491 * nsterm.h: Add declaration for ns_draw_text_decoration.
8493 * nsterm.m (ns_draw_text_decoration): New function for drawing
8494 underline, overline, and strike-through.
8495 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8496 ns_draw_text_decoration. Change treatment of cursor drawing to
8497 accommodate underlining, etc.
8499 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8501 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8504 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8506 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8507 Without this fix, if a signal arrives just after memory fills up,
8508 'malloc' might be invoked reentrantly.
8510 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8511 In other words, assume that every image size is allowed, on non-X
8512 hosts. This assumption is probably wrong, but it lets Emacs compile.
8514 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8516 * regex.c (re_iswctype): Convert return values to boolean.
8518 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8520 * xdisp.c (compute_display_string_pos): Don't use cached display
8521 string position if the buffer had its restriction changed.
8524 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8526 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8528 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8530 Integer signedness and overflow and related fixes. (Bug#9079)
8532 * bidi.c: Integer size and overflow fixes.
8533 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8534 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8535 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8536 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8537 (bidi_find_other_level_edge):
8538 Use ptrdiff_t instead of EMACS_INT where either will do.
8539 This works better on 32-bit hosts configured --with-wide-int.
8540 (bidi_cache_ensure_space): Check for size-calculation overflow.
8541 Use % rather than repeated addition, for better worst-case speed.
8542 Don't set bidi_cache_size until after xrealloc returns, because it
8544 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8545 (bidi_cache_ensure_space): Also check that the bidi cache size
8546 does not exceed that of the largest Lisp string or buffer. See Eli
8547 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8549 * alloc.c (__malloc_size_t): Remove.
8550 All uses replaced by size_t. See Andreas Schwab's note
8551 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8553 * image.c: Improve checking for integer overflow.
8554 (check_image_size): Assume that f is nonnull, since
8555 it is always nonnull in practice. This is one less thing to
8556 worry about when checking for integer overflow later.
8557 (x_check_image_size): New function, which checks for integer
8558 overflow issues inside X.
8559 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8560 This removes the need for a memory_full check.
8561 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8562 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8563 (xbm_read_bitmap_data): Change locals back to 'int', since
8564 their values must fit in 'int'.
8565 (xpm_load_image, png_load, tiff_load):
8566 Invoke x_create_x_image_and_pixmap earlier,
8567 to avoid much needless work if the image is too large.
8568 (tiff_load): Treat overly large images as if
8569 x_create_x_image_and_pixmap failed, not as malloc failures.
8570 (gs_load): Use x_check_image_size.
8572 * gtkutil.c: Omit integer casts.
8573 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8574 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8576 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8578 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8579 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8580 would wrongly return t on a 64-bit host.
8582 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8583 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8584 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8585 and therefore cause GCC to emit a bogus diagnostic in some cases.
8587 * image.c: Integer signedness and overflow and related fixes.
8588 This is not an exhaustive set of fixes, but it's time to
8589 record what I've got.
8590 (lookup_pixel_color, check_image_size): Remove redundant decls.
8591 (check_image_size): Don't assume that arbitrary EMACS_INT values
8592 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8593 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8594 (tiff_load, imagemagick_load_image):
8595 Check for overflow in size calculations.
8596 (x_create_x_image_and_pixmap): Remove unnecessary test for
8597 xmalloc returning NULL; that can't happen.
8598 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8599 (xpm_color_bucket): Use better integer hashing function.
8600 (xpm_cache_color): Don't possibly over-allocate memory.
8601 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8602 (gif_memory_source):
8603 Use ptrdiff_t, not int or size_t, to record sizes.
8604 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8605 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8606 either works, as we prefer signed integers.
8607 (tiff_read_from_memory, tiff_write_from_memory):
8608 Return tsize_t, not size_t, since that's what the TIFF API wants.
8609 (tiff_read_from_memory): Don't fail simply because the read would
8610 go past EOF; instead, return a short read.
8611 (tiff_load): Omit no-longer-needed casts.
8612 (Fimagemagick_types): Don't assume size fits into 'int'.
8614 Improve hashing quality when configured --with-wide-int.
8615 * fns.c (hash_string): New function, taken from sxhash_string.
8616 Do not discard information about ASCII character case; this
8617 discarding is no longer needed.
8618 (sxhash-string): Use it. Change sig to match it. Caller changed.
8619 * lisp.h: Declare it.
8620 * lread.c (hash_string): Remove, since we now use fns.c's version.
8621 The fns.c version returns a wider integer if --with-wide-int is
8622 specified, so this should help the quality of the hashing a bit.
8624 * emacs.c: Integer overflow minor fix.
8625 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8626 Define only if GNU_LINUX.
8627 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8629 * dispnew.c: Integer signedness and overflow fixes.
8630 Remove unnecessary forward decls, that were a maintenance hassle.
8631 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8633 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8634 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8635 (prepare_desired_row, line_draw_cost):
8636 Use int, not unsigned, where either works.
8637 (save_current_matrix, restore_current_matrix):
8638 Use ptrdiff_t, not size_t, where either works.
8639 (init_display): Check for overflow more accurately, and without
8640 relying on undefined behavior.
8642 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8643 Remove, replacing with the new symbols in lisp.h. All uses changed.
8644 * fileio.c (make_temp_name):
8645 * filelock.c (lock_file_1, lock_file):
8646 * xdisp.c (message_dolog):
8647 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8648 Use pMd etc. instead.
8649 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8650 replacing the pWIDE etc. symbols removed from editfns.c.
8652 * keyboard.h (num_input_events): Now uintmax_t.
8653 This is (very slightly) less likely to mess up due to wraparound.
8656 * buffer.c: Integer signedness fixes.
8657 (alloc_buffer_text, enlarge_buffer_text):
8658 Use ptrdiff_t rather than size_t when either will do, as we prefer
8661 * alloc.c: Integer signedness and overflow fixes.
8662 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8663 (__malloc_size_t): Default to size_t, not to int.
8664 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8665 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8666 Prefer ptrdiff_t to size_t when either would do, as we prefer
8668 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8669 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8670 Now const. Initialize with values that are in range even if char
8672 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8673 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8674 These functions do the right thing with sizes > 2**32.
8675 (check_depth): Now ptrdiff_t, not int.
8676 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8677 Adjust to new way of storing sizes. Check for size overflow bugs
8679 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8680 slightly wrong anyway, as it missed one instance of
8681 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8682 (refill_memory_reserve): Omit needless cast to size_t.
8683 (mark_object_loop_halt): Mark as externally visible.
8685 * xselect.c: Integer signedness and overflow fixes.
8686 (Fx_register_dnd_atom, x_handle_dnd_message):
8687 Use ptrdiff_t, not size_t, since we prefer signed.
8688 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8689 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8690 x_dnd_atoms_size and x_dnd_atoms_length.
8692 * doprnt.c: Prefer signed to unsigned when either works.
8694 * doprnt.c (doprnt):
8696 * xdisp.c (vmessage):
8697 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8698 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8699 prefer signed arithmetic to avoid comparison confusion.
8700 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8701 but is a bit tricky.
8703 Assume freestanding C89 headers, string.h, stdlib.h.
8704 * data.c, doprnt.c, floatfns.c, print.c:
8705 Include float.h unconditionally.
8706 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8707 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8708 * regex.c: Likewise for stddef.h, string.h.
8709 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8710 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8711 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8712 (STDC_HEADERS): Remove obsolete defines.
8713 * sysdep.c: Include limits.h unconditionally.
8715 Assume support for memcmp, memcpy, memmove, memset.
8716 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8717 * regex.c (memcmp, memcpy):
8718 Remove; we assume C89 now.
8720 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8721 (__malloc_safe_bcopy): Remove; no longer needed.
8723 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8724 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8725 well either way, and we prefer signed to unsigned.
8727 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8729 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8730 closes the connection while we're reading (bug#9182).
8732 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8734 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8735 are specified (Bug#9168).
8737 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8739 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8740 Found by GCC static checking and --with-wide-int on a 32-bit host.
8742 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8744 * xdisp.c (compute_display_string_pos): Fix logic of caching
8745 previous display string position. Initialize cached_prev_pos to
8746 -1. Fixes slow-down at the beginning of a buffer.
8748 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8750 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8751 for attrs[LFACE_FONTSET_INDEX].
8753 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8755 * xml.c (parse_region): Remove unused local
8756 that was recently introduced.
8758 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8760 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8761 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8763 * xdisp.c (move_it_in_display_line_to): Record the best matching
8764 position for TO_CHARPOS while scanning the line, and restore it on
8765 exit if none of the characters scanned was an exact match.
8766 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8767 when exact match is impossible due to invisible text, and the
8768 lines are truncated.
8770 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8772 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8775 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8777 Fix a significant slow-down of cursor motion with C-n, C-p,
8778 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8779 auto-repeat under bidi redisplay in fontified buffers.
8780 * xdisp.c (compute_stop_pos_backwards): New function.
8781 (next_element_from_buffer): Call compute_stop_pos_backwards to
8782 find a suitable prev_stop when we find ourselves before
8784 (reseat): Don't look for prev_stop, as that could mean a very long
8786 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8787 <cached_disp_overlay_modiff>: Cache for last found display string
8789 (compute_display_string_pos): Return the cached position if asked
8790 about the same buffer in the same area of character positions, and
8791 the buffer wasn't changed since the time the display string
8792 position was cached.
8794 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8796 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8797 is an integer, which is important for empty lines. (Bug#9149)
8799 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8801 * frame.c (Fmodify_frame_parameters): In tty case, update the
8802 default face if necessary (Bug#4238).
8804 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8806 * editfns.c (Fstring_to_char): No need to explain what a character
8807 is in the docstring (Bug#6576).
8809 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8811 * xml.c (parse_region): Make sure we always return a tree.
8813 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8815 * xml.c (parse_region): If a document contains only comments,
8818 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8820 * xml.c (make_dom): Return comments, too.
8822 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8825 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8826 and the surrounding thread.
8827 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8828 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8829 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8831 * s/openbsd.h (BROKEN_SIGIO): Define.
8832 * unexelf.c (unexec) [__OpenBSD__]:
8833 Don't update the .mdebug section of the Alpha COFF symbol table.
8835 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8837 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8840 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8842 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8843 This fixes some race conditions on the permissions of any newly
8846 * alloc.c (valid_pointer_p): Use pipe, not open.
8847 This fixes some permissions issues when debugging.
8849 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8850 If fchown fails to set both uid and gid, try to set just gid,
8851 as that is sometimes allowed. Adjust the file's mode to eliminate
8852 setuid or setgid bits that are inappropriate if fchown fails.
8854 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8856 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8857 to compare Lisp_Objects.
8858 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8859 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8860 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8862 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8864 * lread.c (read_integer): Unread even EOF character.
8865 (read1): Likewise. Properly record start position of symbol.
8867 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8868 symbol character follows.
8870 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8872 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8873 This works around a problem with the previous change to Fcopy_file.
8874 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8875 and without this change, GCC might complain about discarding
8876 fchown's return value.
8878 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8880 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8882 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8884 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8886 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8888 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8889 it's used from the C level.
8891 * process.c: Use the same condition for POLL_FOR_INPUT in both
8892 keyboard.c and process.c (bug#1858).
8894 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8896 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8897 (Fgnutls_boot): Use it.
8899 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8901 * doc.c (Fsubstitute_command_keys): Revert last change.
8903 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8905 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8906 quotes the next character, and doesn't affect other longer
8907 sequences (bug#8935).
8909 * lread.c (syms_of_lread): Clarify that is isn't only
8910 `eval-buffer' and `eval-defun' that's affected by
8911 `lexical-binding' (bug#8460).
8913 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8915 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8916 bidi redisplay when a line includes both an image and is truncated.
8918 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8920 Fix minor problems found by static checking.
8921 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8922 (elsz): Now a signed constant, not a size_t var. We prefer signed
8923 types to unsigned, to avoid integer comparison confusion. Without
8924 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8925 "cannot optimize loop, the loop counter may overflow", a symptom
8927 * indent.c (Fvertical_motion): Mark locals as initialized.
8928 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8930 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8932 * search.c (Fre_search_backward): Mention `case-fold-search' in
8933 all the re_search_* functions (bug#8138).
8935 * keyboard.c (Fopen_dribble_file): Document when the file is
8938 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8940 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8943 Support bidi reordering of display and overlay strings.
8944 * xdisp.c (compute_display_string_pos)
8945 (compute_display_string_end): Accept additional argument STRING.
8946 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8947 (reseat_to_string): Initialize bidi_it->string.s and
8948 bidi_it->string.schars.
8949 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8950 NULL (avoids a crash in bidi_paragraph_init).
8951 Initialize itb.string.lstring.
8952 (init_iterator): Call bidi_init_it only of a valid
8953 buffer position was specified. Initialize paragraph_embedding to
8955 (reseat_to_string): Initialize the bidi iterator.
8956 (display_string): If we need to ignore text properties of
8957 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8958 original value of -1 will not work with bidi.)
8959 (compute_display_string_pos): First arg is now struct
8960 `text_pos *'; all callers changed. Support display properties on
8962 (compute_display_string_end): Support display properties on Lisp
8964 (init_iterator, reseat_1, reseat_to_string): Initialize the
8965 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8966 when iterating on a string not from display properties).
8967 (compute_display_string_pos, compute_display_string_end):
8968 Fix calculation of the object to scan. Fixes an error when using
8970 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8971 base_level_stop; instead, set base_level_stop to BEGV.
8972 Fixes crashes in vertical-motion.
8973 (next_element_from_buffer): Improve commentary for when
8974 the iterator is before prev_stop.
8975 (init_iterator): Initialize bidi_p from the default value of
8976 bidi-display-reordering, not from buffer-local value. Use the
8977 buffer-local value only if initializing for buffer iteration.
8978 (handle_invisible_prop): Support invisible properties on strings
8979 that are being bidi-reordered.
8980 (set_iterator_to_next): Support bidi reordering of C strings and
8982 (next_element_from_string): Support bidi reordering of Lisp
8984 (handle_stop_backwards): Support Lisp strings as well.
8985 (display_string): Support display of R2L glyph rows.
8986 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8987 (init_iterator): Don't initialize it->bidi_p for strings
8989 (reseat_to_string): Initialize it->bidi_p for strings here.
8990 (next_element_from_string, next_element_from_c_string)
8991 (next_element_from_buffer): Add xassert's for correspondence
8992 between IT's object being iterated and it->bidi_it.string
8994 (face_before_or_after_it_pos): Support bidi iteration.
8995 (next_element_from_c_string): Handle the case of the first string
8996 character that is not the first one in the visual order.
8997 (get_visually_first_element): New function, refactored from common
8998 parts of next_element_from_buffer, next_element_from_string, and
8999 next_element_from_c_string.
9000 (tool_bar_lines_needed, redisplay_tool_bar)
9001 (display_menu_bar): Force left-to-right direction. Add a FIXME
9002 comment for making that be controlled by a user option.
9003 (push_it, pop_it): Save and restore the state of the
9004 bidi iterator. Save and restore the bidi_p flag.
9005 (pop_it): Iterate out of display property for string iteration as
9007 (iterate_out_of_display_property): Support iteration over strings.
9008 (handle_single_display_spec): Set up it->bidi_it for iteration
9009 over a display string, and call bidi_init_it.
9010 (handle_single_display_spec, next_overlay_string)
9011 (get_overlay_strings_1, push_display_prop): Set up the bidi
9012 iterator for displaying display or overlay strings.
9013 (forward_to_next_line_start): Don't use the shortcut if
9015 (back_to_previous_visible_line_start): If handle_display_prop
9016 pushed the iterator stack, restore the internal state of the bidi
9017 iterator by calling bidi_pop_it same number of times.
9018 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9019 and we are bidi-iterating, don't decrement the iterator position;
9020 instead, set the first_elt flag in the bidi iterator, to produce
9022 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9023 (push_display_prop): xassert that we are iterating a buffer.
9024 (push_it, pop_it): Save and restore paragraph_embedding member.
9025 (handle_single_display_spec, next_overlay_string)
9026 (get_overlay_strings_1, reseat_1, reseat_to_string)
9027 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9028 correctly. Don't assume unibyte strings are not bidi-reordered.
9029 (compute_display_string_pos)
9030 (compute_display_string_end): Fix handling the case of C string.
9031 (push_it, pop_it): Save and restore from_disp_prop_p.
9032 (handle_single_display_spec, push_display_prop): Set the
9033 from_disp_prop_p flag.
9034 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9035 (pop_it): Call iterate_out_of_display_property only if we are
9036 popping after iteration over a string that came from a display
9037 property. Fix a typo in popping stretch info. Add an assertion
9038 for verifying that the iterator position is in sync with the bidi
9040 (handle_single_display_spec, get_overlay_strings_1)
9041 (push_display_prop): Fix initialization of paragraph direction for
9042 string when that of the parent object is not yet determined.
9043 (reseat_1): Call bidi_init_it to resync the bidi
9044 iterator with IT's position. (Bug#7616)
9045 (find_row_edges): If ROW->start.pos gives position
9046 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9047 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9048 Reset the from_disp_prop_p flag.
9049 (SAVE_IT, RESTORE_IT): New macros.
9050 (pos_visible_p, face_before_or_after_it_pos)
9051 (back_to_previous_visible_line_start)
9052 (move_it_in_display_line_to, move_it_in_display_line)
9053 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9054 (try_scrolling, redisplay_window, display_line): Use them when
9055 saving a temporary copy of the iterator and restoring it back.
9056 (back_to_previous_visible_line_start, reseat_1)
9057 (init_iterator): Empty the bidi cache "stack".
9058 (move_it_in_display_line_to): If iterator ended up at
9059 EOL, but we never saw any buffer positions smaller than
9060 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9061 motion in bidi-reordered lines.
9062 (move_it_in_display_line_to): Record prev_method and prev_pos
9063 immediately before the call to set_iterator_to_next. Fixes cursor
9064 motion in bidi-reordered lines with stretch glyphs and strings
9065 displayed in margins. (Bug#8133) (Bug#8867)
9066 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9068 (pos_visible_p): Support positions in bidi-reordered lines.
9069 Save and restore bidi cache.
9071 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9072 (bidi_paragraph_info): Delete unused struct.
9073 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9074 (bidi_cache_start): New variable.
9075 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9077 (bidi_cache_fetch_state, bidi_cache_search)
9078 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9079 (bidi_cache_find, bidi_peek_at_next_level)
9080 (bidi_level_of_next_char, bidi_find_other_level_edge)
9081 (bidi_move_to_visually_next): Compare cache index with
9082 bidi_cache_start rather than with zero.
9083 (bidi_fetch_char): Accept new argument STRING; all callers
9084 changed. Support iteration over a string. Support strings with
9085 display properties. Support unibyte strings. Fix the type of
9086 `len' according to what STRING_CHAR_AND_LENGTH expects.
9087 (bidi_paragraph_init, bidi_resolve_explicit_1)
9088 (bidi_resolve_explicit, bidi_resolve_weak)
9089 (bidi_level_of_next_char, bidi_move_to_visually_next):
9090 Support iteration over a string.
9091 (bidi_set_sor_type, bidi_resolve_explicit_1)
9092 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9093 can now be zero (for strings); special values 0 and -1 were
9094 changed to -1 and -2, respectively.
9095 (bidi_char_at_pos): New function.
9096 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9097 Call it instead of FETCH_MULTIBYTE_CHAR.
9098 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9099 initialized to valid values.
9100 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9102 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9103 the test for valid cached positions. Fix the logic for looking up
9104 the sentinel state in the cache. GCPRO the Lisp string we are
9106 (bidi_push_it, bidi_pop_it): New functions.
9107 (bidi_initialize): Initialize the bidi cache start stack pointer.
9108 (bidi_cache_ensure_space): New function, refactored from part of
9109 bidi_cache_iterator_state. Don't assume the required size is just
9110 one BIDI_CACHE_CHUNK away.
9111 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9112 (bidi_count_bytes, bidi_char_at_pos): New functions.
9113 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9114 always valid if bidi_cache_idx is valid.
9115 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9116 is valid if it's going to be used.
9117 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9118 (bidi_cache_fetch_state, bidi_cache_search)
9119 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9120 (bidi_cache_iterator_state, bidi_cache_find)
9121 (bidi_find_other_level_edge, bidi_cache_start_stack):
9122 All variables related to cache indices are now EMACS_INT.
9124 * dispextern.h (struct bidi_string_data): New structure.
9125 (struct bidi_it): New member `string'. Make flag members be 1-bit
9126 fields, and put them last in the struct.
9127 (compute_display_string_pos, compute_display_string_end):
9129 (bidi_push_it, bidi_pop_it): Add prototypes.
9130 (struct iterator_stack_entry): New members bidi_p,
9131 paragraph_embedding, and from_disp_prop_p.
9132 (struct it): Member bidi_p is now a bit field 1 bit wide.
9133 (bidi_shelve_cache, bidi_unshelve_cache):
9136 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9137 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9138 and vector-like objects.
9140 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9141 cache around display iteration.
9143 * window.c (Fwindow_end, window_scroll_pixel_based)
9144 (displayed_window_lines, Frecenter): Save and restore the bidi
9145 cache around display iteration.
9147 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9149 * editfns.c (Fdelete_region): Clarify the use of the named
9150 parameters (bug#6788).
9152 2011-07-14 Martin Rudalics <rudalics@gmx.at>
9154 * indent.c (Fvertical_motion): Set and restore w->pointm when
9155 saving and restoring the window's buffer (Bug#9006).
9157 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9159 * editfns.c (Fstring_to_char): Clarify just what is returned
9160 (bug#6576). Text by Eli Zaretskii.
9162 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
9164 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9166 2011-07-13 Eli Zaretskii <eliz@gnu.org>
9168 * buffer.c (mmap_find): Fix a typo.
9170 2011-07-13 Johan Bockgård <bojohan@gnu.org>
9172 Fix execution of x selection hooks.
9173 * xselect.c (Qx_lost_selection_functions)
9174 (Qx_sent_selection_functions): New vars.
9175 (syms_of_xselect): DEFSYM them.
9176 (x_handle_selection_request): Pass Qx_sent_selection_functions
9177 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9178 (x_handle_selection_clear,x_clear_frame_selections):
9179 Pass Qx_lost_selection_functions rather than
9180 Vx_lost_selection_functions to Frun_hook_with_args.
9182 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9184 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
9185 The old code sometimes used this field without initializing it.
9187 * alloc.c (gc_sweep): Don't read past end of array.
9188 In theory, the old code could also have corrupted Emacs internals,
9189 though it'd be very unlikely.
9191 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9193 * character.c (Fcharacterp): Don't advertise optional ignored
9194 argument. (Bug#4026)
9196 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9198 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9201 * window.c (Fset_window_start): Doc fix (bug#4199).
9202 (Fset_window_hscroll): Ditto.
9204 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9206 Fix minor new problems caught by GCC 4.6.1.
9207 * term.c (init_tty): Remove unused local.
9208 * xsettings.c (store_monospaced_changed): Define this function only
9209 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
9212 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
9214 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9216 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9218 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9219 are the mini-buffer and the echo area (bug#3320).
9221 * term.c (init_tty): Remove support for supdup, c10 and perq
9222 terminals, which are no longer supported (bug#1482).
9224 2011-07-10 Johan Bockgård <bojohan@gnu.org>
9226 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9228 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9230 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9231 for non-popups (Bug#3642).
9233 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9235 * alloc.c (reset_malloc_hooks): Protoize.
9236 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
9237 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9238 * cm.c (losecursor): Likewise.
9239 * data.c (fmod): Likewise.
9240 * dispnew.c (swap_glyphs_in_rows): Likewise.
9241 * emacs.c (memory_warning_signal): Likewise.
9242 * floatfns.c (float_error): Likewise.
9243 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9244 (otf_open, font_otf_capability, generate_otf_features)
9245 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9247 * image.c (pbm_read_file): Likewise.
9248 * indent.c (string_display_width): Likewise.
9249 * intervals.c (check_for_interval, search_for_interval)
9250 (inc_interval_count, count_intervals, root_interval)
9251 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9252 * lread.c (defalias): Likewise.
9253 * ralloc.c (r_alloc_check): Likewise.
9254 * regex.c (set_image_of_range_1, set_image_of_range)
9255 (regex_grow_registers): Likewise.
9256 * sysdep.c (strerror): Likewise.
9257 * termcap.c (valid_filename_p, tprint, main): Likewise.
9258 * tparam.c (main): Likewise.
9259 * unexhp9k800.c (run_time_remap, save_data_space)
9260 (update_file_ptrs, read_header, write_header, calculate_checksum)
9261 (copy_file, copy_rest, display_header): Likewise.
9262 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9264 * xdisp.c (check_it): Likewise.
9265 * xfaces.c (register_color, unregister_color, unregister_colors):
9267 * xfns.c (print_fontset_result): Likewise.
9268 * xrdb.c (member, fatal, main): Likewise.
9270 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9272 Fix minor problems found by static checking (Bug#9031).
9273 * chartab.c (char_table_set_range, map_sub_char_table):
9274 Remove unused locals.
9275 (uniprop_table): Now static.
9276 * composite.c (_work_char): Remove unused static var.
9278 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
9280 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9282 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9284 * gtkutil.c (qttip_cb): Remove code without function.
9286 2011-07-09 Eli Zaretskii <eliz@gnu.org>
9288 * w32.c (pthread_sigmask): New stub.
9290 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
9292 Use pthread_sigmask, not sigprocmask (Bug#9010).
9293 sigprocmask is portable only for single-threaded applications, and
9294 Emacs can be multi-threaded when it uses GTK.
9295 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9297 * callproc.c (Fcall_process):
9298 * process.c (create_process):
9299 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9300 Use pthread_sigmask, not sigprocmask.
9302 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9304 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9305 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9308 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9310 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9311 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9312 (xg_hide_tooltip): Fix comment.
9314 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9315 in registerServicesMenuSendTypes.
9316 (validRequestorForSendType): Don't check ns_return_types.
9318 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9321 2011-07-08 Jason Rumney <jasonr@gnu.org>
9323 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9324 SH_SHOW for hidden windows (Bug#5482).
9326 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9327 frame struct members of non-existent frames (Bug#6284).
9329 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9331 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9332 variable firstTime not needed on OSX >= 10.6.
9333 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9334 >= 10.5. Use setKnobProportion, setDoubleValue.
9336 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9337 (MAC_OS_X_VERSION_10_5): Define if not defined.
9338 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9339 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9340 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9342 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9343 cString and lossyCString on OSX >= 10.4.
9345 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9346 sizeToFit on OSX >= 10.2.
9348 * nsimage.m (allocInitFromFile): Don't use deprecated method
9349 bestRepresentationForDevice on OSX >= 10.6.
9351 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9354 * emacs.c: Declare unexec_init_emacs_zone.
9356 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9358 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9360 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9361 on svcsMenu (Bug#8842).
9363 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9365 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9367 * nsterm.m (QUTF8_STRING): Declare.
9368 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9369 (validRequestorForSendType): Return type is (id).
9370 Change indexOfObjectIdenticalTo to indexOfObject.
9371 Check if we have local selection before returning self (Bug#8842).
9372 (writeSelectionToPasteboard): Put local selection into paste board
9373 if we have a local selection (Bug#8842).
9374 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9376 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9377 (ns_get_local_selection): Declare.
9379 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9381 * keymap.c (describe_map_tree): Don't insert a double newline at
9382 the end of the buffer (bug#1169) and return whether we inserted
9385 * callint.c (Fcall_interactively): Change "reading args" to
9386 "providing args" to try to clarify what it does (bug#1010).
9388 2011-07-07 Kenichi Handa <handa@m17n.org>
9390 * composite.c (composition_compute_stop_pos): Ignore a static
9391 composition starting before CHARPOS (Bug#8915).
9393 * xdisp.c (handle_composition_prop): Likewise.
9395 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9397 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9400 2011-07-07 Kenichi Handa <handa@m17n.org>
9402 * character.h (unicode_category_t): New enum type.
9404 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9405 (Qchar_code_property_table): New variable.
9406 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9407 (UNIPROP_COMPRESSED_FORM_P): New macros.
9408 (char_table_ascii): Uncompress the compressed values.
9409 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9410 Uncompress the compressed values.
9411 (sub_char_table_ref_and_range): Likewise.
9412 (char_table_ref_and_range): Uncompress the compressed values.
9413 (sub_char_table_set): New arg is_uniprop. Callers changed.
9414 Uncompress the compressed values.
9415 (sub_char_table_set_range): Args changed. Callers changed.
9416 (char_table_set_range): Adjuted for the above change.
9417 (map_sub_char_table): Delete args default_val and parent. Add arg
9418 top. Give decoded values to a Lisp function.
9419 (map_char_table): Adjust for the above change. Give decoded
9420 values to a Lisp function. Gcpro more variables.
9421 (uniprop_table_uncompress)
9422 (uniprop_decode_value_run_length): New functions.
9423 (uniprop_decoder, uniprop_decoder_count): New variables.
9424 (uniprop_get_decoder, uniprop_encode_value_character)
9425 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9427 (uniprop_encoder, uniprop_encoder_count): New variables.
9428 (uniprop_get_encoder, uniprop_table)
9429 (Funicode_property_table_internal, Fget_unicode_property_internal)
9430 (Fput_unicode_property_internal): New functions.
9431 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9432 Sunicode_property_table_internal, Sget_unicode_property_internal,
9433 and Sput_unicode_property_internal. Defvar_lisp
9434 char-code-property-alist.
9436 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9437 Vunicode_category_table.
9439 * font.c (font_range): Adjust for the change of
9440 Vunicode_category_table.
9442 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9444 * m/iris4d.h: Remove file, move contents ...
9445 * s/irix6-5.h: ... here.
9447 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9449 Remove unportable assumption about struct layout (Bug#8884).
9450 * alloc.c (mark_buffer):
9451 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9452 (clone_per_buffer_values): Don't assume that
9453 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9454 This isn't true in general, and it's particularly not true
9455 if Emacs is configured with --with-wide-int.
9456 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9457 New macros, used in the buffer.c change.
9459 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9461 * xsettings.c: Use both GConf and GSettings if both are available.
9462 (store_config_changed_event): Add comment.
9463 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9464 (store_tool_bar_style_changed): New functions.
9465 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9466 (struct xsettings): Move font inside HAVE_XFT.
9467 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9468 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9469 Move inside HAVE_XFT.
9470 (something_changed_gsettingsCB): Rename from something_changedCB.
9471 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9473 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9474 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9475 (something_changed_gconfCB): Rename from something_changedCB.
9476 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9477 (parse_settings): Move check for font inside HAVE_XFT.
9478 (read_settings, apply_xft_settings): Add comment.
9479 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9480 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9481 call store_font_name_changed.
9482 (xft_settings_event): Add comment.
9483 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9484 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9485 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9486 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9487 (xsettings_initialize): Call init_gsettings last.
9488 (xsettings_get_system_font, xsettings_get_system_normal_font):
9491 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9493 Random fixes. E.g., (random) never returned negative values.
9494 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9495 subseconds part to the entropy, as that's a bit more random.
9496 Prefer signed to unsigned, since the signedness doesn't matter and
9497 in general we prefer signed. When given a limit, use a
9498 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9499 latter isn't right if USE_2_TAGS_FOR_INTS.
9500 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9501 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9503 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9505 * textprop.c (text_property_stickiness):
9506 Obey Vtext_property_default_nonsticky.
9507 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9508 * w32fns.c (syms_of_w32fns):
9509 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9511 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9513 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9514 This is more efficient than Ffile_directory_p and avoids a minor race.
9516 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9518 * buffer.c (Foverlay_put): Say what the return value is
9521 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9522 is a directory before asking whether to use the file name
9524 (barf_or_query_if_file_exists): Make the "File is a directory"
9525 error be more correct.
9527 * fns.c (Frequire): Remove the mention of the .gz files, since
9528 that's installation-specific, but keep the mention of
9529 `get-load-suffixes'.
9531 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9533 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9534 Report string overflow if the output is too long.
9536 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9538 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9539 (syms_of_gnutls): Remove duplicate DEFSYM for
9540 Qgnutls_bootprop_verify_hostname_error, an error for
9541 Qgnutls_bootprop_verify_error (which is no longer used).
9543 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9544 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9545 Also (re)move comments that are misplaced or no longer relevant.
9547 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9549 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9551 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9553 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9554 and background color parameters if they have been changed.
9556 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9558 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9560 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9562 * xsettings.c (SYSTEM_FONT): Define only when used.
9563 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9565 * keymap.c (access_keymap_1): Now static.
9567 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9569 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9570 leave any prefix arg for the up event (Bug#1586).
9572 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9574 * lread.c (syms_of_lread): Mention single symbols defined by
9575 `defvar' or `defconst' (bug#7154).
9577 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9578 (Frequire): Mention get-load-suffixes.
9580 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9582 * window.h (window): Remove clone_number slot.
9583 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9585 (make_parent_window, make_window, saved_window)
9586 (Fset_window_configuration, save_window_save): Don't deal with
9588 * buffer.c (Qclone_number): Remove declaration.
9589 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9591 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9593 Add multiple inheritance to keymaps.
9594 * keymap.c (Fmake_composed_keymap): New function.
9595 (Fset_keymap_parent): Simplify.
9596 (fix_submap_inheritance): Remove.
9597 (access_keymap_1): New function extracted from access_keymap to handle
9598 embedded parents and handle lists of maps.
9599 (access_keymap): Use it.
9600 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9601 (Fcopy_keymap): Handle embedded parents.
9602 (Fcommand_remapping, define_as_prefix): Simplify.
9603 (Fkey_binding): Simplify.
9604 (syms_of_keymap): Move minibuffer-local-completion-map,
9605 minibuffer-local-filename-completion-map,
9606 minibuffer-local-must-match-map, and
9607 minibuffer-local-filename-must-match-map to Elisp.
9608 (syms_of_keymap): Defsubr make-composed-keymap.
9609 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9610 (parse_menu_item): Trivial simplification.
9612 2011-07-01 Glenn Morris <rgm@gnu.org>
9614 * Makefile.in (SETTINGS_LIBS): Fix typo.
9616 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9618 * coding.c (Fencode_coding_string): Record the last coding system
9619 used, as the function doc string says (bug#8738).
9621 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9623 * xsettings.c (store_monospaced_changed): Take new font as arg and
9624 check for change against current_mono_font.
9625 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9626 (emacs_settings_constructor, emacs_settings_get_property)
9627 (emacs_settings_set_property, emacs_settings_class_init)
9628 (emacs_settings_init, gsettings_obj): Remove.
9629 (something_changedCB): New function for HAVE_GSETTINGS.
9630 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9631 with value as argument.
9632 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9633 g_settings_new (Bug#8967). Do not create gsettings_obj.
9634 Remove calls to g_settings_bind. Connect something_changedCB to
9637 * xgselect.c: Add defined (HAVE_GSETTINGS).
9638 (xgselect_initialize): Ditto.
9640 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9641 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9644 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9646 * eval.c (struct backtrace): Simplify and port the data structure.
9647 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9648 signed bit field, as this assumption is not portable and it makes
9649 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9650 "char debug_on_exit : 1" as this is not portable either; instead,
9651 use the portable "unsigned int debug_on_exit : 1". Remove unused
9652 member evalargs. Remove obsolete comments about cc bombing out.
9654 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9656 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9657 Let HAVE_GSETTINGS override HAVE_GCONF.
9658 (store_monospaced_changed): New function.
9659 (EMACS_SETTINGS): A new type derived from GObject to handle
9660 GSettings notifications.
9661 (emacs_settings_constructor, emacs_settings_get_property)
9662 (emacs_settings_set_property, emacs_settings_class_init):
9664 (gsettings_client, gsettings_obj): New variables.
9665 (GSETTINGS_SCHEMA): New define.
9666 (something_changedCB): Call store_monospaced_changed.
9667 (init_gsettings): New function.
9668 (xsettings_initialize): Call init_gsettings.
9669 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9672 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9675 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9677 * window.c (resize_root_window, grow_mini_window)
9678 (shrink_mini_window): Rename Qresize_root_window to
9679 Qwindow_resize_root_window and Qresize_root_window_vertically to
9680 Qwindow_resize_root_window_vertically.
9682 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9684 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9686 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9688 * makefile.w32-in: Redesign dependencies so they reflect more
9689 clearly which files are directly included by each source file,
9690 and not through other includes.
9692 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9694 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9695 (sort_overlays, overlay_strings): When an overlay's clone number
9696 matches the window's clone number process the overlay even if
9697 the overlay's window property doesn't match the current window.
9699 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9700 (Fwindow_hchild): Rename to Fwindow_left_child.
9701 (Fwindow_next): Rename to Fwindow_next_sibling.
9702 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9703 (resize_window_check): Rename to window_resize_check.
9704 (resize_window_apply): Rename to window_resize_apply.
9705 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9706 (Fdelete_other_windows_internal, resize_frame_windows)
9707 (Fsplit_window_internal, Fdelete_window_internal)
9708 (grow_mini_window, shrink_mini_window)
9709 (Fresize_mini_window_internal): Fix callers accordingly.
9711 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9713 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9714 (emacs_fixed_set_min_size): Remove.
9715 (emacs_fixed_new): Take frame as argument.
9717 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9718 (_EmacsFixedPrivate): Remove minwidth/height.
9719 Add struct frame *f.
9720 (emacs_fixed_init): Initialize priv->f.
9721 (get_parent_class, emacs_fixed_set_min_size): Remove.
9722 (emacs_fixed_new): Set priv->f to argument.
9723 (emacs_fixed_get_preferred_width)
9724 (emacs_fixed_get_preferred_height): Use min_width/height from
9725 frames size_hint to set minimum and natural (Bug#8919).
9726 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9727 and use min_width/height from frames size_hint to set
9728 min_width/height (Bug#8919).
9730 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9731 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9734 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9736 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9737 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9740 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9742 * process.c (wait_reading_process_output): Bypass select if
9743 waiting for a cell while ignoring keyboard input, and input is
9744 pending. Suggested by Jan Djärv (Bug#8869).
9746 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9748 Use gnulib's dup2 module instead of rolling our own.
9749 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9751 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9753 * dispnew.c (scrolling_window): Before scrolling, turn off a
9754 mouse-highlight in the window being scrolled.
9756 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9758 Move DEFSYM to lisp.h and use everywhere.
9760 * character.h (DEFSYM): Move declaration...
9761 * lisp.h (DEFSYM): ...here.
9767 * w32select.c: Don't include character.h.
9769 * alloc.c (syms_of_alloc):
9770 * buffer.c (syms_of_buffer):
9771 * bytecode.c (syms_of_bytecode):
9772 * callint.c (syms_of_callint):
9773 * casefiddle.c (syms_of_casefiddle):
9774 * casetab.c (init_casetab_once):
9775 * category.c (init_category_once, syms_of_category):
9776 * ccl.c (syms_of_ccl):
9777 * cmds.c (syms_of_cmds):
9778 * composite.c (syms_of_composite):
9779 * dbusbind.c (syms_of_dbusbind):
9780 * dired.c (syms_of_dired):
9781 * dispnew.c (syms_of_display):
9782 * doc.c (syms_of_doc):
9783 * editfns.c (syms_of_editfns):
9784 * emacs.c (syms_of_emacs):
9785 * eval.c (syms_of_eval):
9786 * fileio.c (syms_of_fileio):
9787 * fns.c (syms_of_fns):
9788 * frame.c (syms_of_frame):
9789 * fringe.c (syms_of_fringe):
9790 * insdel.c (syms_of_insdel):
9791 * keymap.c (syms_of_keymap):
9792 * lread.c (init_obarray, syms_of_lread):
9793 * macros.c (syms_of_macros):
9794 * msdos.c (syms_of_msdos):
9795 * print.c (syms_of_print):
9796 * process.c (syms_of_process):
9797 * search.c (syms_of_search):
9798 * sound.c (syms_of_sound):
9799 * syntax.c (init_syntax_once, syms_of_syntax):
9800 * terminal.c (syms_of_terminal):
9801 * textprop.c (syms_of_textprop):
9802 * undo.c (syms_of_undo):
9803 * w32.c (globals_of_w32):
9804 * window.c (syms_of_window):
9805 * xdisp.c (syms_of_xdisp):
9806 * xfaces.c (syms_of_xfaces):
9807 * xfns.c (syms_of_xfns):
9808 * xmenu.c (syms_of_xmenu):
9809 * xsettings.c (syms_of_xsettings):
9810 * xterm.c (syms_of_xterm): Use DEFSYM.
9812 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9814 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9816 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9818 Integer and buffer overflow fixes (Bug#8873).
9820 * print.c (printchar, strout): Check for string overflow.
9821 (PRINTPREPARE, printchar, strout):
9822 Don't set size unless allocation succeeds.
9824 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9825 for sizes. Check for string overflow more accurately.
9826 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9828 * macros.c: Integer and buffer overflow fixes.
9829 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9830 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9831 Use ptrdiff_t, not int, for sizes.
9832 Don't increment bufsize until after realloc succeeds.
9833 Check for size-calculation overflow.
9834 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9836 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9838 * lread.c: Integer overflow fixes.
9839 (read_integer): Radix is now EMACS_INT, not int,
9840 to improve quality of diagnostics for out-of-range radices.
9841 Calculate buffer size correctly for out-of-range radices.
9842 (read1): Check for integer overflow in radices, and in
9843 read-circle numbers.
9844 (read_escape): Avoid int overflow.
9845 (Fload, openp, read_buffer_size, read1)
9846 (substitute_object_recurse, read_vector, read_list, map_obarray):
9847 Use ptrdiff_t, not int, for sizes.
9848 (read1): Use EMACS_INT, not int, for sizes.
9849 Check for size overflow.
9851 * image.c (cache_image): Check for size arithmetic overflow.
9853 * lread.c: Integer overflow issues.
9854 (saved_doc_string_size, saved_doc_string_length)
9855 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9856 Now ptrdiff_t, not int.
9857 (read1): Don't assume doc string length fits in int. Check for
9858 out-of-range doc string lengths.
9859 (read_list): Don't assume file position fits in int.
9860 (read_escape): Check for hex character overflow.
9862 2011-06-22 Leo Liu <sdl.web@gmail.com>
9864 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9865 Move to minibuffer.el.
9867 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9869 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9870 The following patches are for when GLYPH_DEBUG && !XASSERT.
9871 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9872 * dispnew.c (flush_stdout):
9873 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9874 Mark as externally visible.
9875 * dispnew.c (check_window_matrix_pointers): Now static.
9876 * dispnew.c (window_to_frame_vpos):
9877 * xfns.c (unwind_create_frame):
9878 * xterm.c (x_check_font): Remove unused local.
9879 * scroll.c (CHECK_BOUNDS):
9880 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9881 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9882 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9883 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9884 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9886 (debug_method_add): Use va_list and vsprintf rather than relying
9887 on undefined behavior with wrong number of arguments.
9888 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9889 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9890 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9891 since we're not interested in debugging glyphs with old libraries.
9892 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9893 GCC 4.6.0's static checking.
9895 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9897 Integer overflow and signedness fixes (Bug#8873).
9898 A few related buffer overrun fixes, too.
9900 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9902 * dispextern.h (struct face.stipple):
9903 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9904 (x_bitmap_mask, x_allocate_bitmap_record)
9905 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9906 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9907 (x_create_bitmap_from_xpm_data):
9908 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9909 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9911 * xfaces.c (load_pixmap):
9912 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9913 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9914 (.bitmaps_last, struct x_output.icon_bitmap):
9915 Use ptrdiff_t, not int, for bitmap indexes.
9916 (x_allocate_bitmap_record): Check for size overflow.
9917 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9919 Use ptrdiff_t, not int, for overlay counts.
9920 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9921 * editfns.c (overlays_around, get_pos_property):
9922 * textprop.c (get_char_property_and_overlay):
9923 * xdisp.c (next_overlay_change, note_mouse_highlight):
9924 * xfaces.c (face_at_buffer_position):
9925 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9926 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9927 (Fnext_overlay_change, Fprevious_overlay_change)
9928 (mouse_face_overlay_overlaps, Foverlays_in):
9929 Use ptrdiff_t, not int, for sizes.
9930 (overlays_at, overlays_in): Check for size-calculation overflow.
9932 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9934 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9935 (x_session_initialize): Do not assume string length fits in int.
9937 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9938 This is unlikely, but can occur if DPI is outlandish.
9940 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9941 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9943 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9944 * xrdb.c (magic_file_p, search_magic_path):
9945 Omit last arg SUFFIX; it was always 0. All callers changed.
9946 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9948 * xfont.c (xfont_match): Avoid need for strlen.
9950 * xfns.c: Don't assume strlen fits in int.
9951 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9953 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9954 not unsigned long, as we prefer signed integers. All callers changed.
9955 Detect integer overflow in repeat count.
9956 (message_dolog): Don't assume print length fits in 39 bytes.
9957 (display_mode_element): Don't assume strlen fits in int.
9959 * termcap.c: Don't assume sizes fit in int and never overflow.
9960 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9961 (gobble_line): Check for size-calculation overflow.
9963 * minibuf.c (Fread_buffer):
9964 * lread.c (intern, intern_c_string):
9965 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9966 Don't assume string length fits in int.
9968 * keyboard.c (parse_tool_bar_item):
9969 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9971 * font.c: Don't assume string length fits in int.
9972 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9973 Use ptrdiff_t, not int.
9974 (font_intern_prop): Don't assume string length fits in int.
9975 Don't assume integer property fits in fixnum.
9976 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9978 * filelock.c: Fix some buffer overrun and integer overflow issues.
9979 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9980 Reformulate so as not to need the command string.
9981 Invoke gzip -cd rather than gunzip, as it's more portable.
9982 (lock_info_type, lock_file_1, lock_file):
9983 Don't assume pid_t and time_t fit in unsigned long.
9984 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9985 (current_lock_owner): Prefer signed type for sizes.
9986 Use memcpy, not strncpy, where memcpy is what is really wanted.
9987 Don't assume (via atoi) that time_t and pid_t fit in int.
9988 Check for time_t and/or pid_t out of range, e.g., via a network share.
9989 Don't alloca where an auto var works fine.
9991 * fileio.c: Fix some integer overflow issues.
9992 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9993 Don't assume string length fits in int.
9994 (directory_file_name): Don't assume string length fits in long.
9995 (make_temp_name): Don't assume pid fits in int, or that its print
9996 length is less than 20.
9998 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10000 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10002 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10004 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10005 We prefer signed integers, even for size calculations.
10007 * emacs.c: Don't assume string length fits in 'int'.
10008 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10009 (main): Don't invoke strlen when not needed.
10011 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10012 (XD_DEBUG_MESSAGE): Don't waste a byte.
10014 * callproc.c (getenv_internal_1, getenv_internal)
10015 (Fgetenv_internal):
10016 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10018 * lread.c (invalid_syntax): Omit length argument.
10019 All uses changed. This doesn't fix a bug, but it simplifies the
10020 code away from its former Hollerith-constant appearance, and it's
10021 one less 'int' to worry about when looking at integer-overflow issues.
10022 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
10024 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10025 This didn't break anything, but it didn't help either.
10026 It's confusing to put a bogus integer in a place where the actual
10027 value does not matter.
10028 (LIST_END_P): Remove unused macro and its bogus comment.
10029 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
10031 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10032 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10034 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10035 We prefer signed types, and the value cannot exceed the EMACS_INT
10036 range anyway (because otherwise the length would not be representable).
10037 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10038 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10039 This avoids a GCC warning when WIDE_EMACS_INT.
10041 * indent.c (sane_tab_width): New function.
10042 (current_column, scan_for_column, Findent_to, position_indentation)
10043 (compute_motion): Use it. This is just for clarity.
10044 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
10046 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
10048 * lisp.h (lint_assume): New macro.
10049 * composite.c (composition_gstring_put_cache):
10050 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10052 * editfns.c, insdel.c:
10053 Omit unnecessary forward decls, to simplify future changes.
10055 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10057 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10059 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
10060 Use much-faster test for byte-length change.
10061 Don't assume string byte-length fits in 'int'.
10062 Check that character arg fits in 'int'.
10063 (mapcar1): Declare byte as byte, for clarity.
10065 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10067 * fns.c (concat): Catch string overflow earlier.
10068 Do not rely on integer wraparound.
10070 * dispextern.h (struct it.overlay_strings_charpos)
10071 (struct it.selective): Now EMACS_INT, not int.
10072 * xdisp.c (forward_to_next_line_start)
10073 (back_to_previous_visible_line_start)
10074 (reseat_at_next_visible_line_start, next_element_from_buffer):
10075 Don't arbitrarily truncate the value of 'selective' to int.
10077 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10079 * composite.c: Don't truncate sizes to 'int'.
10080 (composition_gstring_p, composition_reseat_it)
10081 (composition_adjust_point): Use EMACS_INT, not int.
10082 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10083 not EMACS_UINT, for indexes.
10085 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10087 * buffer.c: Include <verify.h>.
10088 (struct sortvec.priority, struct sortstr.priority):
10089 Now EMACS_INT, not int.
10090 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
10091 (struct sortstr.size, record_overlay_string)
10092 (struct sortstrlist.size, struct sortlist.used):
10093 Don't truncate size to int.
10094 (record_overlay_string): Check for size-calculation overflow.
10095 (init_buffer_once): Check at compile-time, not run-time.
10097 2011-06-22 Jim Meyering <meyering@redhat.com>
10099 Don't leak an XBM-image-sized buffer
10100 * image.c (xbm_load): Free the image buffer after using it.
10102 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10105 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10106 that Sun C diagnosed.
10107 * fns.c (secure_hash): Fix pointer signedness issue.
10108 * intervals.c (static_offset_intervals): New function.
10109 (offset_intervals): Use it.
10111 2011-06-21 Leo Liu <sdl.web@gmail.com>
10114 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10117 * fns.c (secure_hash): Rename from crypto_hash_function and change
10118 the first arg to accept symbols.
10119 (Fsecure_hash): New primitive.
10120 (syms_of_fns): New symbols.
10122 2011-06-20 Deniz Dogan <deniz@dogan.se>
10124 * process.c (Fset_process_buffer): Clarify return value in
10127 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
10129 * dispnew.c (add_window_display_history): Use BVAR.
10131 * xdisp.c (debug_method_add): Use BVAR.
10132 (check_window_end, dump_glyph_matrix, dump_glyph)
10133 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10135 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10138 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10139 check till after the cache is created in init_frame_faces.
10141 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10143 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10145 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10147 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10148 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10149 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10151 Improve buffer-overflow checking (Bug#8873).
10152 * fileio.c (Finsert_file_contents):
10153 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10154 Remove the old (too-loose) buffer overflow checks.
10155 They weren't needed, since make_gap checks for buffer overflow.
10156 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10157 The old code merely checked for Emacs fixnum overflow, and relied
10158 on undefined (wraparound) behavior. The new code avoids undefined
10159 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10161 * editfns.c (Finsert_char): Don't dump core with very negative counts.
10162 Tune. Don't use wider integers than needed. Don't use alloca.
10163 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
10165 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10167 * insdel.c, lisp.h (buffer_overflow): New function.
10168 (insert_from_buffer_1, replace_range, replace_range_2):
10169 * insdel.c (make_gap_larger):
10170 * editfns.c (Finsert_char):
10171 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10173 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10175 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10177 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
10179 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10180 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10182 * fileio.c: Don't assume EMACS_INT fits in off_t.
10183 (emacs_lseek): New static function.
10184 (Finsert_file_contents, Fwrite_region): Use it.
10185 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10187 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10189 * fns.c: Don't overflow int when computing a list length.
10190 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10191 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10192 truncation on 64-bit hosts. Check for QUIT every
10193 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10194 faster and is responsive enough.
10195 (Flength): Report an error instead of overflowing an integer.
10196 (Fsafe_length): Return a float if the value is not representable
10197 as a fixnum. This shouldn't happen except in contrived situations.
10198 (Fnthcdr, Fsort): Don't assume list length fits in int.
10199 (Fcopy_sequence): Don't assume vector length fits in int.
10201 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10202 (header_size, word_size): New constants.
10203 (allocate_vectorlike): Don't check size overflow here.
10204 (allocate_vector): Check it here instead, since this is the only
10205 caller of allocate_vectorlike that could cause overflow.
10206 Check that the new vector's length is representable as a fixnum.
10208 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10209 The previous code was bogus. For example, next_almost_prime (32)
10210 returned 39, which is undesirable as it is a multiple of 3; and
10211 next_almost_prime (24) returned 25, which is a multiple of 5 so
10212 why was the code bothering to check for multiples of 7?
10214 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10216 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10218 Variadic C functions now count arguments with ptrdiff_t.
10219 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10220 Back then I didn't know that the Emacs coding style prefers signed int.
10221 Also, in the meantime I found a few more instances where arguments
10222 were being counted with int, which may truncate counts on 64-bit
10223 machines, or EMACS_INT, which may be unnecessarily wide.
10224 * lisp.h (struct Lisp_Subr.function.aMANY)
10225 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10226 Arg counts are now ptrdiff_t, not size_t.
10227 All variadic functions and their callers changed accordingly.
10228 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10229 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10230 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10231 * callint.c (Fcall_interactively): Check arg count for overflow,
10232 to avoid potential buffer overrun. Use signed char, not 'int',
10233 for 'varies' array, so that we needn't bother to check its size
10234 calculation for overflow.
10235 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10236 * eval.c (apply_lambda):
10237 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10238 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10239 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10241 * callint.c (Fcall_interactively): Don't use index var as event count.
10243 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10244 * mem-limits.h (SIZE): Remove; no longer used.
10246 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
10248 Remove unnecessary casts.
10249 * xterm.c (x_term_init):
10250 * xfns.c (x_set_border_pixel):
10251 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10252 These aren't needed now that we assume ANSI C.
10254 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10255 It's more likely to cause problems (due to unsigned overflow)
10258 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10260 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10262 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10264 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10266 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10268 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10270 GLYPH_CODE_FACE returns EMACS_INT, not int.
10271 * dispextern.h (merge_faces):
10272 * xfaces.c (merge_faces):
10273 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10274 Don't assume EMACS_INT fits in int.
10276 * character.h (CHAR_VALID_P): Remove unused parameter.
10277 * fontset.c, lisp.h, xdisp.c: All uses changed.
10279 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10281 * fns.c (concat): Minor tuning based on overflow analysis.
10282 This doesn't fix any bugs. Use int to hold character, instead
10283 of constantly refetching from Emacs object. Use XFASTINT, not
10284 XINT, for value known to be a character. Don't bother comparing
10285 a single byte to 0400, as it's always less.
10287 * floatfns.c (Fexpt):
10288 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10290 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10293 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10295 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10296 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10297 incorrectly succeed when S was a string, because 4294967386 was
10298 truncated before it was used.
10300 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10301 Otherwise, an out-of-range integer could cause undefined behavior
10304 * composite.c: Use int, not EMACS_INT, for characters.
10305 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10306 EMACS_INT, for values that are known to be in character range.
10307 This doesn't fix any bugs but is the usual style inside Emacs and
10308 may generate better code on 32-bit machines.
10310 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10311 This is for reasons similar to the recent CHAR_STRING fix.
10312 * charset.c (Fencode_char): Check that character arg is actually
10313 a character. Pass an int to ENCODE_CHAR.
10314 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10315 wider than 'int', as a compile-time check to prevent future regressions
10318 * character.c (char_string): Remove unnecessary casts.
10320 Make sure a 64-bit char is never passed to CHAR_STRING.
10321 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10322 by silently ignoring the top 32 bits, allowing some values
10323 that were far too large to be valid characters.
10324 * character.h: Include <verify.h>.
10325 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10326 arguments are no wider than unsigned, as a compile-time check
10327 to prevent future regressions in this area.
10329 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10330 (Fsubst_char_in_region):
10332 * xdisp.c (decode_mode_spec_coding):
10333 Adjust to CHAR_STRING's new requirement.
10334 * editfns.c (Finsert_char, Fsubst_char_in_region):
10335 * fns.c (concat): Check that character args are actually
10336 characters. Without this test, these functions did the wrong
10337 thing with wildly out-of-range values on 64-bit hosts.
10339 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10340 These casts should not be needed on 32-bit hosts, either.
10341 * keyboard.c (read_char):
10342 * lread.c (Fload): Remove casts to unsigned.
10344 * lisp.h (UNSIGNED_CMP): New macro.
10345 This fixes comparison bugs on 64-bit hosts.
10346 (ASCII_CHAR_P): Use it.
10347 * casefiddle.c (casify_object):
10348 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10349 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10350 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10351 * dispextern.h (FACE_FROM_ID):
10352 * keyboard.c (read_char): Use UNSIGNED_CMP.
10354 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10355 not to EMACS_INT, to avoid GCC warning.
10357 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10359 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10360 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10361 isn't needed on 32-bit machines.
10363 * buffer.c (Fgenerate_new_buffer_name):
10364 Use EMACS_INT for count, not int.
10365 (advance_to_char_boundary): Return EMACS_INT, not int.
10367 * data.c (Qcompiled_function): Now static.
10369 * window.c (window_body_lines): Now static.
10371 * image.c (gif_load): Rename local to avoid shadowing.
10373 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10374 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10375 * alloc.c (make_save_value): Integer argument is now of type
10376 ptrdiff_t, not int.
10377 (mark_object): Use ptrdiff_t, not int.
10378 * lisp.h (pD): New macro.
10379 * print.c (print_object): Use it.
10381 * alloc.c: Use EMACS_INT, not int, to count objects.
10382 (total_conses, total_markers, total_symbols, total_vector_size)
10383 (total_free_conses, total_free_markers, total_free_symbols)
10384 (total_free_floats, total_floats, total_free_intervals)
10385 (total_intervals, total_strings, total_free_strings):
10386 Now EMACS_INT, not int. All uses changed.
10387 (Fgarbage_collect): Compute overall total using a double, so that
10388 integer overflow is less likely to be a problem. Check for overflow
10389 when converting back to an integer.
10390 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10391 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10392 These were 'int' variables that could overflow on 64-bit hosts;
10393 they were never used, so remove them instead of repairing them.
10394 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10395 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10396 Previously, this ceilinged at INT_MAX, but that doesn't work on
10398 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10400 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10401 (allocate_vectorlike): Check for ptrdiff_t overflow.
10402 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10403 when a (possibly-narrower) signed value would do just as well.
10404 We prefer using signed arithmetic, to avoid comparison confusion.
10406 * alloc.c: Catch some string size overflows that we were missing.
10407 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10408 for convenience in STRING_BYTES_MAX.
10409 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10410 The definition here is exact; the one in lisp.h was approximate.
10411 (allocate_string_data): Check for string overflow. This catches
10412 some instances we weren't catching before. Also, it catches
10413 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10414 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10415 and ptrdiff_t and EMACS_INT are both 64 bits.
10417 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10418 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10419 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10421 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10423 * alloc.c (Fmake_string): Check for out-of-range init.
10425 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10427 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10429 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10431 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10432 xg_get_default_scrollbar_width.
10434 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10435 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10436 (style_changed_cb): Call update_theme_scrollbar_width and call
10437 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10438 all frames (Bug#8505).
10439 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10440 Call gtk_window_set_resizable if HAVE_GTK3.
10441 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10442 and height if HAVE_GTK3 (Bug#8505).
10443 (scroll_bar_width_for_theme): New variable.
10444 (update_theme_scrollbar_width): New function.
10445 (xg_get_default_scrollbar_width): Move code to
10446 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10447 (xg_initialize): Call update_theme_scrollbar_width.
10449 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10451 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10453 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10455 * frame.c (make_frame): Call other_buffer_safely instead of
10458 * window.c (temp_output_buffer_show): Call display_buffer with
10459 second argument Vtemp_buffer_show_specifiers and reset latter
10460 immediately after the call.
10461 (Vtemp_buffer_show_specifiers): New variable.
10462 (auto_window_vscroll_p, next_screen_context_lines)
10463 (Vscroll_preserve_screen_position): Remove leading asterisks from
10466 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10468 Fix minor problems found by GCC 4.6.0 static checking.
10469 * buffer.c (Qclone_number): Remove for now, as it's unused.
10470 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10471 (record_buffer): Remove unused local.
10472 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10473 (set_frame_buffer_list): Remove; unused.
10474 * frame.h (other_visible_frames): Remove decl.
10475 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10476 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10477 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10479 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10480 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10481 Define only if HAVE_GPM.
10482 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10483 (update_hints_inhibit): Remove; never set. All uses removed.
10484 * widgetprv.h (emacsFrameClassRec): Remove decl.
10485 * window.c (delete_deletable_window): Now returns void, since it
10486 wasn't returning anything.
10487 (compare_window_configurations): Remove unused locals.
10488 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10489 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10490 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10491 the same widths as pointers. This follows up on the 2011-05-06 patch.
10492 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10493 * xterm.h: Likewise.
10494 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10496 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10498 * makefile.w32-in: Update dependencies.
10499 (LISP_H): Add lib/intprops.h.
10501 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10503 * image.c (gif_load): Add animation frame delay to the metadata.
10504 (syms_of_image): Use DEFSYM. New symbol `delay'.
10506 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10508 * window.c (delete_deletable_window): Re-add.
10509 (Fset_window_configuration): Rewrite to handle dead buffers and
10510 consequently deletable windows.
10511 (window_tree, Fwindow_tree): Remove. Supply functionality in
10513 (compare_window_configurations): Simplify code.
10515 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10517 * image.c (imagemagick_load_image): Fix type mismatch.
10518 (Fimagemagick_types): Likewise.
10520 * window.h (replace_buffer_in_windows): Declare.
10522 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10524 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10525 Qclone_number. Remove external declaration of Qdelete_window.
10526 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10528 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10529 Run Qbuffer_list_update_hook if allowed.
10530 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10531 buffer list implementation.
10532 (other_buffer_safely): New function.
10533 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10534 calls to replace_buffer_in_windows and
10535 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10537 (record_buffer): Inhibit quitting and rewrite using quittable
10538 functions. Run Qbuffer_list_update_hook if allowed.
10539 (Frecord_buffer, Funrecord_buffer): New functions.
10540 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10541 Move switch-to-buffer to window.el.
10542 (bury-buffer): Move to window.el.
10543 (Vbuffer_list_update_hook): New variable.
10545 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10548 * window.h (resize_frame_windows): Move up in code.
10549 (Fwindow_frame): Remove EXFUN.
10550 (replace_buffer_in_all_windows): Remove prototype.
10551 (replace_buffer_in_windows_safely): Add prototype.
10553 * window.c: Declare Qdelete_window static again. Move down
10554 declaration of select_count.
10555 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10556 (Fother_window): Move to window.el.
10557 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10558 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10559 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10561 (replace_buffer_in_windows): Implement by calling
10562 Qreplace_buffer_in_windows.
10563 (replace_buffer_in_all_windows): Remove with some functionality
10564 moved into replace_buffer_in_windows_safely.
10565 (replace_buffer_in_windows_safely): New function.
10566 (select_window_norecord, select_frame_norecord): Move in front
10567 of run_window_configuration_change_hook. Remove now obsolete
10569 (Fset_window_buffer): Rewrite doc-string.
10570 Call Qrecord_window_buffer.
10571 (keys_of_window): Move binding for other-window to window.el.
10573 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10575 * dispextern.h (struct image): Replace data member, whose int_val
10576 and ptr_val fields were not used by anything, with a single
10579 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10580 (gif_clear_image, gif_load, imagemagick_load_image)
10581 (gs_clear_image, gs_load): Callers changed.
10583 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10585 * buffer.h: Include <time.h>, for time_t.
10586 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10588 Fix minor problems found by static checking.
10590 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10592 Make identifiers static if they are not used in other modules.
10593 * data.c (Qcompiled_function, Qframe, Qvector):
10594 * image.c (QimageMagick, Qsvg):
10595 * minibuf.c (Qmetadata):
10596 * window.c (resize_window_check, resize_root_window): Now static.
10597 * window.h (resize_window_check, resize_root_window): Remove decls.
10599 * window.c (window_deletion_count, delete_deletable_window):
10601 (window_body_lines): Now static.
10602 (Fdelete_other_windows_internal): Mark vars as initialized.
10603 Make sure 'resize_failed' is initialized.
10604 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10605 (resize_window_apply): Remove unused local.
10606 * window.h (delete_deletable_window): Remove decl.
10608 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10609 (imagemagick_load_image): Fix pointer signedness problem by changing
10610 last arg from unsigned char * to char *. All uses changed.
10611 Also, fix a local for similar reasons.
10612 Remove unused locals. Remove locals to avoid shadowing.
10613 (fn_rsvg_handle_free): Remove; unused.
10614 (svg_load, svg_load_image): Fix pointer signedness problem.
10615 (imagemagick_load_image): Don't use garbage pointer image_wand.
10617 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10619 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10621 * image.c (gif_load): Fix omitted cast error introduced by
10624 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10626 * window.h (resize_proportionally, orig_total_lines)
10627 (orig_top_line): Remove from window structure.
10628 (set_window_height, set_window_width, change_window_heights)
10629 (Fdelete_window): Remove prototypes.
10630 (resize_frame_windows): Remove duplicate declaration.
10632 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10634 * window.h (resize_frame_windows, resize_window_check)
10635 (delete_deletable_window, resize_root_window)
10636 (resize_frame_windows): Declare prototypes.
10638 * window.c (resize_window_apply): Make definition be "static" to
10639 match the prototype.
10641 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10643 * window.c: Remove declarations of Qwindow_size_fixed,
10644 window_min_size_1, window_min_size_2, window_min_size,
10645 size_window, window_fixed_size_p, enlarge_window, delete_window.
10646 Remove static from declaration of Qdelete_window, it's
10647 temporarily needed by Fbury_buffer.
10648 (replace_window): Don't assign orig_top_line and
10650 (Fdelete_window, delete_window): Remove. Window deletion is
10651 handled by window.el.
10652 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10653 Replace Fdelete_window calls with calls to Qdelete_window.
10654 (Fdelete_other_windows): Remove. Deleting other windows is
10655 handled by window.el.
10656 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10657 handled in window.el.
10658 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10659 Window minimum sizes are handled in window.el.
10660 (shrink_windows, size_window, set_window_height)
10661 (set_window_width, change_window_heights, window_height)
10662 (window_width, CURBEG, CURSIZE, enlarge_window)
10663 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10664 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10665 handled in window.el.
10666 (make_dummy_parent): Rename to make_parent_window and give it a
10667 second argument horflag.
10668 (make_window): Don't set resize_proportionally any more.
10669 (Fsplit_window): Remove. Windows are split in window.el.
10670 (save_restore_action, save_restore_orig_size)
10671 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10672 Resize mini windows in window.el.
10673 (grow_mini_window, shrink_mini_window): Implement by calling
10674 Qresize_root_window_vertically, resize_window_check and
10675 resize_window_apply.
10676 (saved_window, Fset_window_configuration, save_window_save):
10677 Do not handle orig_top_line, orig_total_lines, and
10678 resize_proportionally.
10679 (window_min_height, window_min_width): Move to window.el.
10680 (keys_of_window): Move bindings for delete-other-windows,
10681 split-window, delete-window and enlarge-window to window.el.
10683 * buffer.c: Temporarily extern Qdelete_window.
10684 (Fbury_buffer): Temporarily call Qdelete_window instead of
10685 Fdelete_window (Fbury_buffer will move to window.el soon).
10687 * frame.c (set_menu_bar_lines_1): Remove code handling
10688 orig_top_line and orig_total_lines.
10690 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10691 set_window_height but set heights directly.
10692 (change_frame_size_1): Use resize_frame_windows.
10694 * xdisp.c (init_xdisp): Don't use set_window_height but set
10697 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10698 Use resize_frame_windows instead of change_window_heights and run
10699 run_window_configuration_change_hook.
10701 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10702 instead of change_window_heights and run
10703 run_window_configuration_change_hook.
10705 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10707 * window.c (replace_window): Rename second argument REPLACEMENT to
10708 NEW. New third argument SETFLAG. Rewrite.
10709 (delete_window, make_dummy_parent): Call replace_window with
10711 (window_list_1): Move down in code.
10712 (run_window_configuration_change_hook): Move set_buffer part
10713 before select_frame_norecord part in order to unwind correctly.
10714 Rename count1 to count.
10715 (recombine_windows, delete_deletable_window, resize_root_window)
10716 (Fdelete_other_windows_internal)
10717 (Frun_window_configuration_change_hook, make_parent_window)
10718 (resize_window_check, resize_window_apply, Fresize_window_apply)
10719 (resize_frame_windows, Fsplit_window_internal)
10720 (Fdelete_window_internal, Fresize_mini_window_internal):
10722 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10724 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10726 * window.h (window): Add some new members to window structure -
10727 normal_lines, normal_cols, new_total, new_normal, clone_number,
10728 splits, nest, prev_buffers, next_buffers.
10729 (WINDOW_TOTAL_SIZE): Move here from window.c.
10730 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10732 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10734 (make_dummy_parent): Set new members of windows structure.
10735 (make_window): Move down in code. Handle new members of window
10737 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10738 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10739 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10740 (Fset_window_prev_buffers, Fwindow_next_buffers)
10741 (Fset_window_next_buffers, Fset_window_clone_number):
10743 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10744 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10746 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10747 Argument WINDOW can be now internal window too.
10748 (Fwindow_use_time): Move up in code.
10749 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10750 Rewrite doc-string.
10751 (Fset_window_configuration, saved_window)
10752 (Fcurrent_window_configuration, save_window_save): Handle new
10753 members of window structure.
10754 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10755 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10756 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10757 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10758 Qget_mru_window, Qresize_root_window,
10759 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10760 Qauto_buffer_name; staticpro them.
10762 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10764 * window.c (Fwindow_total_size, Fwindow_left_column)
10765 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10766 (Fwindow_list_1): New functions.
10767 (window_box_text_cols): Replace with window_body_cols.
10768 (Fwindow_width, Fscroll_left, Fscroll_right):
10769 Use window_body_cols instead of window_box_text_cols.
10770 (delete_window, Fset_window_configuration):
10771 Call delete_all_subwindows with window as argument.
10772 (delete_all_subwindows): Take a window as argument and not a
10773 structure. Rewrite.
10774 (window_loop): Remove handling of GET_LRU_WINDOW and
10775 GET_LARGEST_WINDOW.
10776 (Fget_lru_window, Fget_largest_window): Move to window.el.
10778 * window.h: Extern window_body_cols instead of
10779 window_box_text_cols. delete_all_subwindows now takes a
10780 Lisp_Object as argument.
10782 * indent.c (compute_motion, Fcompute_motion):
10783 Use window_body_cols instead of window_box_text_cols.
10785 * frame.c (delete_frame): Call delete_all_subwindows with root
10786 window as argument.
10788 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10790 * fns.c (Fputhash): Document return value.
10792 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10794 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10796 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10798 Cons<->int and similar integer overflow fixes (Bug#8794).
10800 Check for overflow when converting integer to cons and back.
10801 * charset.c (Fdefine_charset_internal, Fdecode_char):
10802 Use cons_to_unsigned to catch overflow.
10803 (Fencode_char): Use INTEGER_TO_CONS.
10804 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10805 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10806 * data.c (long_to_cons, cons_to_long): Remove.
10807 (cons_to_unsigned, cons_to_signed): New functions.
10808 These signal an error for invalid or out-of-range values.
10809 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10810 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10811 * font.c (Ffont_variation_glyphs):
10812 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10813 * lisp.h: Include <intprops.h>.
10814 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10815 (cons_to_signed, cons_to_unsigned): New decls.
10816 (long_to_cons, cons_to_long): Remove decls.
10817 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10818 (Fprimitive_undo): Use CONS_TO_INTEGER.
10819 * xfns.c (Fx_window_property): Likewise.
10820 * xselect.c: Include <limits.h>.
10821 (x_own_selection, selection_data_to_lisp_data):
10822 Use INTEGER_TO_CONS.
10823 (x_handle_selection_request, x_handle_selection_clear)
10824 (x_get_foreign_selection, Fx_disown_selection_internal)
10825 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10826 (lisp_data_to_selection_data): Use cons_to_unsigned.
10827 (x_fill_property_data): Use cons_to_signed.
10828 Report values out of range.
10830 Check for buffer and string overflow more precisely.
10831 * buffer.h (BUF_BYTES_MAX): New macro.
10832 * lisp.h (STRING_BYTES_MAX): New macro.
10833 * alloc.c (Fmake_string):
10834 * character.c (string_escape_byte8):
10835 * coding.c (coding_alloc_by_realloc):
10836 * doprnt.c (doprnt):
10837 * editfns.c (Fformat):
10839 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10840 since they may not be the same number.
10841 * editfns.c (Finsert_char):
10842 * fileio.c (Finsert_file_contents):
10843 Likewise for BUF_BYTES_MAX.
10845 * image.c: Use ptrdiff_t, not int, for sizes.
10846 (slurp_file): Switch from int to ptrdiff_t.
10848 (slurp_file): Check that file size fits in both size_t (for
10849 malloc) and ptrdiff_t (for sanity and safety).
10851 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10852 if b->modtime has its maximal value.
10854 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10856 Don't assume time_t can fit into int.
10857 * buffer.h (struct buffer.modtime): Now time_t, not int.
10858 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10859 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10861 Minor fixes for signed vs unsigned integers.
10862 * character.h (MAYBE_UNIFY_CHAR):
10863 * charset.c (maybe_unify_char):
10864 * keyboard.c (read_char, reorder_modifiers):
10865 XINT -> XFASTINT, since the integer must be nonnegative.
10866 * ftfont.c (ftfont_spec_pattern):
10867 * keymap.c (access_keymap, silly_event_symbol_error):
10868 XUINT -> XFASTINT, since the integer must be nonnegative.
10869 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10870 since it makes no difference and we prefer signed.
10871 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10872 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10875 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10877 * window.h (Fwindow_frame): Declare.
10879 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10881 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10882 (SPARE_MEMORY): Always define.
10883 (LARGE_REQUEST): Remove.
10884 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10886 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10888 * lisp.h: Move EXFUNS for Fframe_root_window,
10889 Fframe_first_window and Fset_frame_selected_window to window.h.
10891 * window.h: Move EXFUNS for Fframe_root_window,
10892 Fframe_first_window and Fset_frame_selected_window here from
10895 * frame.c (Fwindow_frame, Fframe_first_window)
10896 (Fframe_root_window, Fframe_selected_window)
10897 (Fset_frame_selected_window): Move to window.c.
10898 (Factive_minibuffer_window): Move to minibuf.c.
10899 (Fother_visible_frames_p): New function.
10901 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10903 * window.c (decode_window, decode_any_window): Move up in code.
10904 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10905 (inhibit_frame_unsplittable): Remove unused variable.
10906 (Fwindow_buffer): Move up and rewrite doc-string.
10907 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10908 (Fwindow_prev): New functions.
10909 (Fwindow_frame): Move here from frame.c. Accept any window as
10911 (Fframe_root_window, Fframe_first_window)
10912 (Fframe_selected_window): Move here from frame.c. Accept frame
10913 or arbitrary window as argument. Update doc-strings.
10914 (Fminibuffer_window): Move up in code.
10915 (Fwindow_minibuffer_p): Move up in code and simplify.
10916 (Fset_frame_selected_window): Move here from frame.c.
10918 (Fselected_window, select_window, Fselect_window): Move up in
10919 code. Minor doc-string fixes.
10921 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10923 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10924 Do not assume that spare memory exists; that assumption is valid
10925 only if SYSTEM_MALLOC.
10926 (LARGE_REQUEST): New macro, so that the issue of large requests
10927 is separated from the issue of spare memory.
10929 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10931 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10934 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10936 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10939 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10941 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10943 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10945 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10946 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10948 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10950 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10952 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10954 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10955 (x_clipboard_manager_save): Add return value.
10956 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10957 New error handlers.
10958 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10959 Obey Vx_select_enable_clipboard_manager. Catch errors in
10960 x_clipboard_manager_save (Bug#8779).
10961 (Vx_select_enable_clipboard_manager): New variable.
10962 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10964 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10966 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10968 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10970 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10971 in the current matrix if keep_current_p is non-zero.
10973 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10975 * bidi.c (bidi_level_of_next_char): Fix last change.
10977 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10979 Support bidi reordering of text covered by display properties.
10981 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10982 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10983 (bidi_cache_search, bidi_cache_iterator_state)
10984 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10985 (bidi_level_of_next_char, bidi_move_to_visually_next):
10986 Support character positions inside a run of characters covered by a
10988 (bidi_paragraph_init, bidi_resolve_explicit_1)
10989 (bidi_level_of_next_char): Call bidi_fetch_char and
10990 bidi_fetch_char_advance instead of FETCH_CHAR and
10991 FETCH_CHAR_ADVANCE.
10992 (bidi_init_it): Initialize new members.
10993 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10995 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10996 instead of using explicit *_CHAR codes.
10997 (bidi_resolve_explicit, bidi_resolve_weak):
10998 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10999 bidirectional text is supported only in multibyte buffers.
11000 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11001 it to initialize the frame_window_p member of struct bidi_it.
11002 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11003 (bidi_resolve_explicit, bidi_resolve_weak)
11004 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11005 bidi_it->nchars is non-positive.
11006 (bidi_level_of_next_char): Don't try to lookup the cache for the
11007 next/previous character if nothing is cached there yet, or if we
11008 were just reseat()'ed to a new position.
11010 * xdisp.c (set_cursor_from_row): Set start and stop points
11011 according to the row's direction when priming the loop that looks
11012 for the glyph on which to display cursor.
11013 (single_display_spec_intangible_p): Function deleted.
11014 (display_prop_intangible_p): Reimplement to call
11015 handle_display_spec instead of single_display_spec_intangible_p.
11016 Accept 3 additional arguments needed by handle_display_spec.
11017 This fixes incorrect cursor motion across display property with complex
11018 values: lists, `(when COND...)' forms, etc.
11019 (single_display_spec_string_p): Support property values that are
11020 lists with the argument STRING its top-level element.
11021 (display_prop_string_p): Fix the condition for processing a
11022 property that is a list to be consistent with handle_display_spec.
11023 (handle_display_spec): New function, refactored from the
11024 last portion of handle_display_prop.
11025 (compute_display_string_pos): Accept additional argument
11026 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11027 value of a `display' property is a "replacing spec".
11028 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11029 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11030 the display property, but just return a value indicating whether
11031 the display property will replace the characters it covers.
11032 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11033 frame_window_p members of struct bidi_it.
11034 (compute_display_string_pos, compute_display_string_end):
11036 (push_it): Accept second argument POSITION, where pop_it should
11037 jump to continue iteration.
11038 (reseat_1): Initialize bidi_it.disp_pos.
11040 * keyboard.c (adjust_point_for_property): Adjust the call to
11041 display_prop_intangible_p to its new signature.
11043 * dispextern.h (struct bidi_it): New member frame_window_p.
11044 (bidi_init_it): Update prototypes.
11045 (display_prop_intangible_p): Update prototype.
11046 (compute_display_string_pos, compute_display_string_end):
11047 Declare prototypes.
11048 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11051 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
11053 Malloc failure behavior now depends on size of allocation.
11054 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11055 * lisp.h: Change signatures accordingly.
11056 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11057 All callers changed. (Bug#8762)
11059 * gnutls.c: Use Emacs's memory allocators.
11060 Without this change, the gnutls library would invoke malloc etc.
11061 directly, which causes problems on non-SYNC_INPUT hosts, and which
11062 runs afoul of improving memory_full behavior. (Bug#8761)
11063 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11064 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11065 xfree instead of the default malloc, realloc, free.
11066 (Fgnutls_boot): No need to check for memory allocation failure,
11067 since xmalloc does that for us.
11069 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
11070 * category.c (hash_get_category_set):
11071 * ccl.c (ccl_driver):
11072 * charset.c (Fdefine_charset_internal):
11073 * charset.h (struct charset.hash_index):
11074 * composite.c (get_composition_id, gstring_lookup_cache)
11075 (composition_gstring_put_cache):
11076 * composite.h (struct composition.hash_index):
11077 * dispextern.h (struct image.hash):
11078 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11079 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11080 (hashfn_equal, hashfn_user_defined, make_hash_table)
11081 (maybe_resize_hash_table, hash_lookup, hash_put)
11082 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11083 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11084 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11085 * image.c (make_image, search_image_cache, lookup_image)
11086 (xpm_put_color_table_h):
11087 * lisp.h (struct Lisp_Hash_Table):
11088 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
11089 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
11090 for hashes and hash indexes, instead of 'unsigned' and 'int'.
11091 * alloc.c (allocate_vectorlike):
11092 Check for overflow in vector size calculations.
11093 * ccl.c (ccl_driver):
11094 Check for overflow when converting EMACS_INT to int.
11095 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11096 need to be updated by these changes.
11097 * fns.c (make_hash_table, maybe_resize_hash_table):
11098 Check for integer overflow with large hash tables.
11099 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11100 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11101 (SXHASH_REDUCE): New macro.
11102 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11103 Use it instead of discarding useful hash info with large hash values.
11104 (sxhash_float): New function.
11105 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11106 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
11107 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11108 Rewrite to use FIXNUM_BITS, as this simplifies things.
11109 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11110 Adjust signatures to match updated version of code.
11111 (consing_since_gc): Now EMACS_INT, since a single hash table can
11112 use more than INT_MAX bytes.
11114 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11116 Make it possible to build with GCC-4.6+ -O2 -flto.
11118 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11120 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11122 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11123 Call minibuffer-inactive-mode.
11125 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
11127 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11128 Update dependencies.
11130 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11132 * data.c (init_data): Remove code for UTS, this system is not
11135 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11137 Don't force ./temacs to start in terminal mode.
11139 * frame.c (make_initial_frame): Initialize faces in all cases, not
11140 only when CANNOT_DUMP is defined.
11141 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11143 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11145 * dispnew.c (add_window_display_history): Use const for the string
11146 pointer. Remove declaration, not needed.
11148 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11150 Use 'inline', not 'INLINE'.
11151 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
11152 * alloc.c, fontset.c (INLINE): Remove.
11153 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11154 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11155 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11156 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11157 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11159 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11161 Make it possible to run ./temacs.
11163 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11164 syms_of_callproc does the same thing. Remove test for
11165 "initialized", do it in the caller.
11166 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11168 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11170 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11171 (read_minibuf): Use get_minibuffer.
11172 (syms_of_minibuf): Use DEFSYM.
11173 (Qmetadata): New var.
11174 * data.c (Qbuffer): Don't make it static.
11175 (syms_of_data): Use DEFSYM.
11177 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11179 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11180 (CCL_CODE_MIN): New macro.
11182 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11184 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11186 * eval.c (Qdebug): Now static.
11187 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11188 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11189 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11191 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11193 * image.c: Various fixes to ImageMagick code comments.
11194 (Fimagemagick_types): Doc fix.
11196 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11198 Minor fixes prompted by GCC 4.6.0 warnings.
11200 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11202 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11203 (x_clipboard_manager_save_all): Move extern decl to ...
11204 * xterm.h: ... here, so that it can be checked for consistency.
11206 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11208 * xselect.c (x_clipboard_manager_save_frame)
11209 (x_clipboard_manager_save_all): New functions.
11210 (Fx_clipboard_manager_save): Lisp function deleted.
11212 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11213 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11215 * xterm.h: Update prototype.
11217 2011-05-28 William Xu <william.xwl@gmail.com>
11219 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11220 exiting (Bug#8239).
11222 2011-05-28 Jim Meyering <meyering@redhat.com>
11224 Avoid a sign-extension bug in crypto_hash_function.
11225 * fns.c (to_uchar): Define.
11226 (crypto_hash_function): Use it to convert some newly-signed
11227 variables to unsigned, to avoid sign-extension bugs. For example,
11228 without this change, (md5 "truc") would evaluate to
11229 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11230 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
11231 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
11233 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11235 Integer overflow fixes.
11237 * dbusbind.c: Serial number integer overflow fixes.
11238 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
11239 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11240 to hold a serial number that is too large for a fixnum.
11241 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11242 Check for serial numbers out of range. Decode any serial number
11243 that was so large that it became a float. (Bug#8722)
11245 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11246 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11247 Use XFASTINT rather than XUINT when numbers are nonnegative.
11248 (xd_append_arg, Fdbus_method_return_internal):
11249 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11250 arguments, check that Lisp number is nonnegative, rather than
11251 silently wrapping negative numbers around. (Bug#8722)
11252 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
11255 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11257 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11259 ccl: Add integer overflow checks.
11260 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11261 (IN_INT_RANGE): New macros.
11262 (ccl_driver): Use them to check for integer overflow when
11263 decoding a CCL program. Many of the new checks are whether XINT (x)
11264 fits in int; it doesn't always, on 64-bit hosts. The new version
11265 doesn't catch all possible integer overflows, but it's an
11266 improvement. (Bug#8719)
11268 * alloc.c (make_event_array): Use XINT, not XUINT.
11269 There's no need for unsigned here.
11271 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11272 This follows up to the 2011-05-06 change that substituted uintptr_t
11273 for EMACS_INT. This case wasn't caught back then.
11275 Rework Fformat to avoid integer overflow issues.
11276 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11277 now (part of C89). Include <verify.h>.
11278 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11279 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11280 (Fformat): Avoid the prepass trying to compute sizes; it was only
11281 approximate and thus did not catch overflow reliably. Instead, walk
11282 through the format just once, formatting and computing sizes as we go,
11283 checking for integer overflow at every step, and allocating a larger
11284 buffer as needed. Keep track separately whether the format is
11285 multibyte. Keep only the most-recently calculated precision, rather
11286 than them all. Record whether each argument has been converted to
11287 string. Use EMACS_INT, not int, for byte and char and arg counts.
11288 Support field widths and precisions larger than INT_MAX. Avoid
11289 sprintf's undefined behavior with conversion specifications such as %#d
11290 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11291 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11292 formatting out-of-range floating point numbers with int
11293 formats. (Bug#8668)
11295 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11297 * data.c: Avoid integer truncation in expressions involving floats.
11298 * data.c: Include <intprops.h>.
11299 (arith_driver): When there's an integer overflow in an expression
11300 involving floating point, convert the integers to floating point
11301 so that the resulting value does not suffer from catastrophic
11302 integer truncation. For example, on a 64-bit host (* 4
11303 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11304 Do not rely on undefined behavior after integer overflow.
11306 merge count_size_as_multibyte, parse_str_to_multibyte
11307 * character.c, character.h (count_size_as_multibyte):
11308 Rename from parse_str_to_multibyte; all uses changed.
11309 Check for integer overflow.
11310 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11311 since it's now a duplicate of the other. This is more of
11312 a character than a buffer op, so better that it's in character.c.
11313 * fns.c, print.c: Adjust to above changes.
11315 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11317 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11319 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11321 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11322 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11323 (x_clipboard_manager_save): Now static.
11324 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11326 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11327 (crypto_hash_function): Now static.
11328 Fix pointer signedness problems. Avoid unnecessary initializations.
11330 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11332 * termhooks.h (Vselection_alist): Make it terminal-local.
11334 * terminal.c (create_terminal): Initialize it.
11336 * xselect.c: Support for clipboard managers.
11337 (Vselection_alist): Move to termhooks.h as terminal-local var.
11338 (LOCAL_SELECTION): New macro.
11339 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11340 (symbol_to_x_atom): Remove gratuitous arg.
11341 (x_handle_selection_request, lisp_data_to_selection_data)
11342 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11343 (x_own_selection, x_get_local_selection, x_convert_selection):
11344 New arg, specifying work frame. Use terminal-local Vselection_alist.
11345 (some_frame_on_display): Delete unused function.
11346 (Fx_own_selection_internal, Fx_get_selection_internal)
11347 (Fx_disown_selection_internal, Fx_selection_owner_p)
11348 (Fx_selection_exists_p): New optional frame arg.
11349 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11350 (x_handle_selection_clear): Don't treat other terminals with the
11351 same keyboard specially. Use the terminal-local Vselection_alist.
11352 (x_clear_frame_selections): Use Frun_hook_with_args.
11354 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11356 * xterm.h: Add support for those atoms.
11358 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11360 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11361 (converted_selections, conversion_fail_tag): New global variables.
11362 (x_selection_request_lisp_error): Free the above.
11363 (x_get_local_selection): Remove unnecessary code.
11364 (x_reply_selection_request): Args changed; handle arbitrary array
11365 of converted selections stored in converted_selections.
11366 Separate the XChangeProperty and SelectionNotify steps.
11367 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11368 (x_convert_selection): New function.
11369 (x_handle_selection_event): Simplify.
11370 (x_get_foreign_selection): Don't ignore incoming requests while
11371 waiting for an answer; this will fail when we implement
11372 SAVE_TARGETS, and seems unnecessary anyway.
11373 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11374 (Vx_sent_selection_functions): Doc fix.
11376 2011-05-26 Leo Liu <sdl.web@gmail.com>
11378 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11380 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11382 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11384 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11385 for fringe update if it has periodic bitmap.
11386 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11387 and fringe_bitmap_periodic_p.
11389 * fringe.c (get_fringe_bitmap_data): New function.
11390 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11391 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11392 row. Mark glyph row for fringe update if periodicity changed.
11394 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11395 for fringe update unless it has periodic bitmap.
11397 2011-05-25 Kenichi Handa <handa@m17n.org>
11399 * xdisp.c (get_next_display_element): Set correct it->face_id for
11400 a static composition.
11402 2011-05-24 Leo Liu <sdl.web@gmail.com>
11405 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11407 * fns.c (crypto_hash_function, Fsha1): New function.
11408 (Fmd5): Use crypto_hash_function.
11409 (syms_of_fns): Add Ssha1.
11411 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11413 * gnutls.c: Remove unused macros.
11414 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11415 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11416 Remove macros that are defined and never used.
11417 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11419 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11421 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11422 (Fx_get_selection_internal): Minor cleanup.
11423 (Fx_own_selection_internal): Rename arguments for consistency with
11426 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11428 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11430 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11432 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11434 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11436 * dispnew.c (scrolling_window): Don't exclude the case that the
11437 last enabled row in the desired matrix touches the bottom boundary.
11439 2011-05-21 Glenn Morris <rgm@gnu.org>
11441 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11442 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11443 and add some more files.
11445 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11447 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11448 report_file_error introduced by the change from 2011-05-07.
11450 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11452 * systime.h (Time): Define only if emacs is defined.
11453 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11454 where the include path doesn't have X11/X.h by default. See
11455 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11457 2011-05-20 Kenichi Handa <handa@m17n.org>
11459 * composite.c (find_automatic_composition): Fix previous change.
11461 2011-05-20 Glenn Morris <rgm@gnu.org>
11463 * lisp.mk: New file, split from Makefile.in.
11464 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11465 (shortlisp): Remove.
11466 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11468 2011-05-19 Glenn Morris <rgm@gnu.org>
11470 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11471 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11472 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11473 (lisp): Set the order to that of loadup.el.
11474 (shortlisp): Make it a copy of $lisp.
11475 (SOME_MACHINE_LISP): Remove.
11476 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11477 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11479 2011-05-18 Kenichi Handa <handa@m17n.org>
11481 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11482 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11483 (find_automatic_composition): Mostly rewrite for efficiency.
11485 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11487 * makefile.w32-in: Update dependencies.
11489 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11491 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11492 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11494 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11496 Fix some integer overflow issues, such as string length overflow.
11498 * insdel.c (count_size_as_multibyte): Check for string overflow.
11500 * character.c (lisp_string_width): Check for string overflow.
11501 Use EMACS_INT, not int, for string indexes and lengths; in
11502 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11503 the resulting string length overflows an EMACS_INT; instead,
11504 report a string overflow if no precision given. When checking for
11505 precision exhaustion, use a check that cannot possibly have
11506 integer overflow. (Bug#8675)
11507 * character.h (lisp_string_width): Adjust to new signature.
11509 * alloc.c (string_overflow): New function.
11510 (Fmake_string): Use it. This doesn't change behavior, but saves
11511 a few bytes and will simplify future changes.
11512 * character.c (string_escape_byte8): Likewise.
11513 * lisp.h (string_overflow): New decl.
11515 Fixups, following up to the user-interface timestamp change.
11516 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11517 for UI timestamps, instead of unsigned long.
11518 * msdos.c (mouse_get_pos): Likewise.
11519 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11520 * w32gui.h (Time): Define by including "systime.h" rather than by
11521 declaring it ourselves. (Bug#8664)
11523 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11524 * image.c (clear_image_cache): Likewise.
11526 * term.c (term_mouse_position): Don't assume time_t wraparound.
11528 Be more systematic about user-interface timestamps.
11529 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11530 and sometimes 'EMACS_UINT', to represent these timestamps.
11531 This change causes it to use 'Time' uniformly, as that's what X uses.
11532 This makes the code easier to follow, and makes it easier to catch
11533 integer overflow bugs such as Bug#8664.
11534 * frame.c (Fmouse_position, Fmouse_pixel_position):
11535 Use Time, not unsigned long, for user-interface timestamps.
11536 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11537 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11538 * keyboard.h (last_event_timestamp): Likewise.
11539 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11540 * menu.h (xmenu_show): Likewise.
11541 * term.c (term_mouse_position): Likewise.
11542 * termhooks.h (struct input_event.timestamp): Likewise.
11543 (struct terminal.mouse_position_hook): Likewise.
11544 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11545 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11546 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11547 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11548 what it was before.
11549 * menu.h, termhooks.h: Include "systime.h", for Time.
11551 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11552 Don't assume that the difference between two unsigned long values
11553 can fit into an integer. At this point, we know button_down_time
11554 <= event->timestamp, so the difference must be nonnegative, so
11555 there's no need to cast the result if double-click-time is
11556 nonnegative, as it should be; check that it's nonnegative, just in
11557 case. This bug is triggered when events are more than 2**31 ms
11558 apart (about 25 days). (Bug#8664)
11560 * xselect.c (last_event_timestamp): Remove duplicate decl.
11561 (x_own_selection): Remove needless cast to unsigned long.
11563 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11564 that always fit in int. Use a sentinel instead of a counter, to
11565 avoid a temp and to allay GCC's concerns about possible int overflow.
11566 * frame.h (struct frame): Use int for menu_bar_items_used
11567 instead of EMACS_INT, since it always fits in int.
11569 * menu.c (grow_menu_items): Check for int overflow.
11571 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11573 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11574 Before, the code was not consistent. These values cannot exceed
11575 2**31 - 1 so there's no need to make them unsigned.
11576 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11577 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11578 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11580 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11582 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11583 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11584 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11585 presumably because the widths might not match.
11587 * window.c (size_window): Avoid needless test at loop start.
11589 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11591 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11593 2011-05-12 Drew Adams <drew.adams@oracle.com>
11595 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11597 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11599 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11600 `width' to `bar_area_x' and `bar_area_width', respectively.
11601 (x_scroll_run): Take account of fringe background extension.
11603 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11604 Rename local vars `left' and `width' to `bar_area_x' and
11605 `bar_area_width', respectively.
11606 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11607 background extension.
11609 2011-05-10 Jim Meyering <meyering@redhat.com>
11611 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11613 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11615 * image.c (Finit_image_library): Return t for built-in image types,
11616 like pbm and xbm. (Bug#8640)
11618 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11620 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11622 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11624 * w32console.c (Fset_screen_color): Doc fix.
11625 (Fget_screen_color): New function.
11626 (syms_of_ntterm): Defsubr it.
11628 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11629 unlink the temporary file if Fcall_process didn't create it in the
11631 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11632 child process will be redirected to a file specified with `:file'.
11633 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11634 cue to call_process_cleanup not to close that handle.
11636 2011-05-07 Ben Key <bkey76@gmail.com>
11638 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11639 one of two shell specific rules, either bootstrap-temacs-CMD or
11640 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11641 to the previous implementation of the bootstrap-temacs rule.
11642 The bootstrap-temacs-CMD rule is similar to the previous
11643 implementation of the bootstrap-temacs rule except that it
11644 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11647 These changes, along with some changes to nt/configure.bat,
11648 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11649 earlier fix to add support for --cflags and --ldflags options
11650 that include quotes so that it works whether make uses cmd or
11653 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11655 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11656 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11658 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11659 a string. Handle both cases.
11660 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11661 (Fdbus_register_method): Use Qinvalid_function.
11663 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11665 * makefile.w32-in: Update dependencies.
11666 (LISP_H): Add inttypes.h and stdin.h.
11667 (PROCESS_H): Add unistd.h.
11669 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11671 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11672 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11674 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11676 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11678 * term.c (vfatal): Remove stray call to va_end.
11679 It's not needed and the C Standard doesn't allow it here anyway.
11681 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11682 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11684 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11687 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11689 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11691 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11693 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11695 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11697 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11698 * charset.c (Fdefine_charset_internal): Don't initialize
11699 charset.code_space[15]. The value was garbage, on hosts with
11700 32-bit int (Bug#8600).
11702 * lread.c (read_integer): Be more consistent with string-to-number.
11703 Use string_to_number to do the actual conversion; this avoids
11704 rounding errors and fixes some other screwups. Without this fix,
11705 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11706 (digit_to_number): Move earlier, for benefit of read_integer.
11707 Return -1 if the digit is out of range for the base, -2 if it is
11708 not a digit in any supported base. (Bug#8602)
11710 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11712 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11713 to match comment at start of function. This also removes a
11714 GCC warning about overflow in a 32+64-bit port.
11716 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11718 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11719 Reported by Stefan Monnier in
11720 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11721 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11722 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11724 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11725 (EMACS_UINTPTR): Likewise, with uintptr_t.
11727 * lisp.h: Prefer 64-bit EMACS_INT if available.
11728 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11729 on 32-bit hosts that have 64-bit int, so that they can access
11731 However, temporarily disable this change unless the temporary
11732 symbol WIDE_EMACS_INT is defined.
11734 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11736 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11737 This removes an assumption that EMACS_INT and long are the same
11738 width as pointers. The assumption is true for Emacs porting targets
11739 now, but we want to make other targets possible.
11740 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11741 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11742 In the rest of the code, change types of integers that hold casted
11743 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11744 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11745 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11746 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11747 No need to cast type when ORing.
11748 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11749 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11750 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11751 assume EMACS_INT is the same width as char *.
11752 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11753 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11754 Remove no-longer-needed casts.
11755 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11756 (xg_tool_bar_help_callback, xg_make_tool_item):
11757 Use EMACS_INTPTR to hold an integer
11758 that will be cast to void *; this can avoid a GCC warning
11759 if EMACS_INT is not the same width as void *.
11760 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11761 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11762 (current_message_1, set_message_1):
11763 Use a local to convert to proper width without a cast.
11764 * xmenu.c (dialog_selection_callback): Likewise.
11766 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11767 Also, don't assume VALBITS / RAND_BITS is less than 5,
11768 and don't rely on undefined behavior when shifting a 1 left into
11770 * lisp.h (get_random): Change signature to match.
11772 * lread.c (hash_string): Use size_t, not int, for hash computation.
11773 Normally we prefer signed values; but hashing is special, because
11774 it's better to use unsigned division on hash table sizes so that
11775 the remainder is nonnegative. Also, size_t is the natural width
11776 for hashing into memory. The previous code used 'int', which doesn't
11777 retain enough info to hash well into very large tables.
11778 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11780 * dbusbind.c: Don't possibly lose pointer info when converting.
11781 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11782 Use XPNTR rather than XHASH, so that the high-order bits of
11783 the pointer aren't lost when converting through void *.
11785 * eval.c (Fautoload): Don't double-shift a pointer.
11787 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11789 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11791 * gnutls.c (DEF_GNUTLS_FN):
11792 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11794 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11796 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11799 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11801 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11802 New version that can reserve upto 2GB of heap space.
11804 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11806 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11808 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11810 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11811 `gnutls_certificate_set_x509_key_file'.
11813 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11815 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11816 Update dependencies.
11818 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11820 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11821 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11822 Remove unused parameter `fildes'.
11823 * process.c (read_process_output, send_process): Don't pass it.
11825 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11827 Fix previous change: the library cache is defined in w32.c.
11828 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11829 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11831 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11833 Implement dynamic loading of GnuTLS on Windows.
11835 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11836 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11837 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11840 * gnutls.c (Qgnutls_dll): Define.
11841 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11842 (gnutls_*): Declare function pointers.
11843 (init_gnutls_functions): New function to initialize function pointers.
11844 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11845 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11846 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11847 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11848 (emacs_gnutls_write, emacs_gnutls_read)
11849 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11850 (Fgnutls_available_p): New function.
11851 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11852 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11853 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11855 * image.c: Include w32.h.
11856 (Vimage_type_cache): Delete.
11857 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11858 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11859 (w32_delayed_load): Move to w32.c.
11861 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11863 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11864 (w32_delayed_load): Move from image.c. When loading a library, record
11865 its filename in the :loaded-from property of the library id.
11866 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11867 Initialize and staticpro them.
11868 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11870 * process.c: Include lisp.h before w32.h, not after.
11871 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11872 instead of gnutls_record_check_pending.
11874 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11876 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11878 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11879 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11882 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11884 * xterm.c (x_set_frame_alpha): Do not set property on anything
11885 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11887 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11889 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11891 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11893 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11894 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11895 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11896 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11897 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11898 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11899 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11900 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11901 (Qgnutls_bootprop_callbacks_verify): Make static.
11903 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11905 * callproc.c: Indentation fixup.
11907 * sysdep.c (wait_for_termination_1): Make static.
11908 (wait_for_termination, interruptible_wait_for_termination):
11909 Move after wait_for_termination_1.
11911 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11913 * sysdep.c (interruptible_wait_for_termination): New function
11914 which is like wait_for_termination, but allows keyboard
11917 * callproc.c (Fcall_process): Add (:file "file") as an option for
11919 (Fcall_process_region): Ditto.
11921 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11923 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11924 rather than `XVECTOR (FOO)->size'.
11926 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11927 inttypes.h, as a gnulib replacement is used if it not available in
11930 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11932 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11933 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11934 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11936 * coding.c (coding_alloc_by_realloc): Error out if destination
11937 will grow beyond MOST_POSITIVE_FIXNUM.
11938 (decode_coding_emacs_mule): Abort if there isn't enough place in
11939 charbuf for the composition carryover bytes. Reserve an extra
11940 space for up to 2 characters produced in a loop.
11941 (decode_coding_iso_2022): Abort if there isn't enough place in
11942 charbuf for the composition carryover bytes.
11944 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11946 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11947 aborting when %lld or %lll format is passed.
11948 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11949 %llo or %llx format is passed. (Bug#8545)
11951 * window.c (window_scroll_line_based): Use a marker instead of
11952 simple variables to record original value of point. (Bug#7952)
11954 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11955 produced by %s or %c overflows available buffer space. (Bug#8545)
11957 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11959 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11960 (SIZE_MAX): Move defn after all includes, as they might #define it.
11962 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11964 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11966 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11968 * keyboard.c (Qdelayed_warnings_hook): Define.
11969 (command_loop_1): Run `delayed-warnings-hook'
11970 if Vdelayed_warnings_list is non-nil.
11971 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11972 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11974 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11976 * doprnt.c (doprnt): Don't return value smaller than the buffer
11977 size if the message was truncated. (Bug#8545).
11979 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11981 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11982 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11984 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11986 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11988 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11990 * makefile.w32-in: Update dependencies.
11992 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11994 Improve `doprnt' and its usage. (Bug#8545)
11995 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11996 `format_end'. Remove support for %l as a conversion specifier.
11997 Don't use xrealloc. Improve diagnostics when the %l size modifier
11998 is used. Update the commentary.
12000 * eval.c (verror): Simplify calculation of size_t.
12002 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12005 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12007 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12010 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12012 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12013 This makes this file independent of the recent pseudovector change.
12015 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
12017 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12019 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
12020 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
12021 Remove unused local.
12022 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
12024 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
12025 GCC 4.6.0 optimizes based on type-based alias analysis.
12026 For example, if b is of type struct buffer * and v of type struct
12027 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12028 != &v->size, and therefore "v->size = 1; b->size = 2; return
12029 v->size;" must therefore return 1. This assumption is incorrect
12030 for Emacs, since it type-puns struct Lisp_Vector * with many other
12031 types. To fix this problem, this patch adds a new type struct
12032 vectorlike_header that documents the constraints on layout of vectors
12033 and pseudovectors, and helps optimizing compilers not get fooled
12034 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12035 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
12036 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12038 (XSETPVECTYPE): Rewrite in terms of new macro.
12039 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12040 This is a bit clearer, and further avoids the possibility of
12041 undesirable aliasing.
12042 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
12043 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
12044 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12045 since Lisp_Subr is a special case (no "next" field).
12046 (ASIZE): Now uses header.size rather than size.
12047 All previous uses of XVECTOR (foo)->size replaced to use this macro,
12048 to avoid the hassle of writing XVECTOR (foo)->header.size.
12049 (struct vectorlike_header): New type.
12050 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12051 object, to help avoid aliasing.
12052 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12053 (SUBRP): Likewise, since Lisp_Subr is a special case.
12054 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12055 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12056 (struct Lisp_Hash_Table): Combine first two members into a single
12057 struct vectorlike_header member. All uses of "size" and "next" members
12058 changed to be "header.size" and "header.next".
12059 * buffer.h (struct buffer): Likewise.
12060 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12061 * frame.h (struct frame): Likewise.
12062 * process.h (struct Lisp_Process): Likewise.
12063 * termhooks.h (struct terminal): Likewise.
12064 * window.c (struct save_window_data, struct saved_window): Likewise.
12065 * window.h (struct window): Likewise.
12066 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12067 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12068 * buffer.c (init_buffer_once): Likewise.
12069 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12071 * process.c (Fformat_network_address): Use local var for size,
12074 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12076 Make the Lisp reader and string-to-float more consistent (Bug#8525)
12077 * data.c (atof): Remove decl; no longer used or needed.
12078 (digit_to_number): Move to lread.c.
12079 (Fstring_to_number): Use new string_to_number function, to be
12080 consistent with how the Lisp reader treats infinities and NaNs.
12081 Do not assume that floating-point numbers represent EMACS_INT
12082 without losing information; this is not true on most 64-bit hosts.
12083 Avoid double-rounding errors, by insisting on integers when
12084 parsing non-base-10 numbers, as the documentation specifies.
12085 * lisp.h (string_to_number): New decl, replacing ...
12086 (isfloat_string): Remove.
12087 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
12088 (read1): Do not accept +. and -. as integers; this
12089 appears to have been a coding error. Similarly, do not accept
12090 strings like +-1e0 as floating point numbers. Do not report
12091 overflow for integer overflows unless the base is not 10 which
12092 means we have no simple and reliable way to continue.
12093 Break out the floating-point parsing into a new
12094 function string_to_number, so that Fstring_to_number parses
12095 floating point numbers consistently with the Lisp reader.
12096 (digit_to_number): Move here from data.c. Make it static inline.
12097 (E_CHAR, EXP_INT): Remove, replacing with ...
12098 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12099 (string_to_number): New function, replacing isfloat_string.
12100 This function checks for valid syntax and produces the resulting
12101 Lisp float number too. Rework it so that string-to-number
12102 no longer mishandles examples like "1.0e+". Use strtoumax,
12103 so that overflow for non-base-10 numbers is reported only when
12104 there's no portable and simple way to convert to floating point.
12106 * textprop.c (set_text_properties_1): Rewrite for clarity,
12107 and to avoid GCC warning about integer overflow.
12109 * intervals.h (struct interval): Use EMACS_INT for members
12110 where EMACS_UINT might cause problems. See
12111 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12112 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12113 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12115 (offset_intervals): Tell GCC not to worry about length overflow
12116 when negating a negative length.
12118 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12119 (overrun_check_free): Likewise.
12121 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12122 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12125 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12126 (gnutls_make_error): Rename local to avoid shadowing.
12127 (gnutls_emacs_global_deinit): ifdef out; not used.
12128 (Fgnutls_boot): Use const for pointer to readonly storage.
12129 Comment out unused local. Fix pointer signedness problems.
12131 * lread.c (openp): Don't stuff size_t into an 'int'.
12132 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12133 about possible signed overflow.
12135 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12136 (GDK_KEY_g): Don't define if already defined.
12137 (xg_prepare_tooltip): Avoid pointer signedness problem.
12138 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12140 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12141 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12143 * xfns.c (Fx_window_property): Simplify a bit,
12144 to make a bit faster and to avoid GCC 4.6.0 warning.
12145 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12147 * fns.c (internal_equal): Don't assume size_t fits in int.
12149 * alloc.c (compact_small_strings): Tighten assertion a little.
12151 Replace pEd with more-general pI, and fix some printf arg casts.
12152 * lisp.h (pI): New macro, generalizing old pEd macro to other
12153 conversion specifiers. For example, use "...%"pI"d..." rather
12154 than "...%"pEd"...".
12155 (pEd): Remove. All uses replaced with similar uses of pI.
12156 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
12157 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12158 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12159 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12160 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12161 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12162 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12164 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12165 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12166 * print.c (safe_debug_print, print_object): Likewise.
12167 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12169 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12170 avoiding the 0 flag, which is not portable.
12171 * process.c (Fmake_network_process): Use pI to avoid cast.
12172 * region-cache.c (pp_cache): Likewise.
12173 * xdisp.c (decode_mode_spec): Likewise.
12174 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12175 behavior on 64-bit hosts with printf arg.
12176 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
12177 (x_stop_queuing_selection_requests): Likewise.
12178 (x_get_window_property): Don't truncate byte count to an 'int'
12181 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12182 here, since it parses constructs like leading '-' and spaces,
12183 which are not wanted; and it overflows with large numbers.
12184 Instead, simply match F[0-9]+, which is what is wanted anyway.
12186 * alloc.c: Remove unportable assumptions about struct layout.
12187 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12188 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12189 (allocate_vectorlike, make_pure_vector): Use the new macros,
12190 plus offsetof, to remove unportable assumptions about struct layout.
12191 These assumptions hold on all porting targets that I know of, but
12192 they are not guaranteed, they're easy to remove, and removing them
12193 makes further changes easier.
12195 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12196 This doesn't fix a bug but makes the code clearer.
12197 (string_overrun_cookie): Now const. Use initializers that
12198 don't formally overflow signed char, to avoid warnings.
12199 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12200 can cause Emacs to crash when string overrun checking is enabled.
12201 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12202 multiple of sizeof (EMACS_INT); it need not be, if
12203 alignof(EMACS_INT) < sizeof (EMACS_INT).
12204 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
12206 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
12208 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12210 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12212 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
12213 supposed to be handshaking. (Bug#8556)
12214 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12216 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12218 * lisp.h (Qdebug): List symbol.
12219 * eval.c (Qdebug): Restore global linkage.
12220 * keyboard.c (debug-on-event): New variable.
12221 (handle_user_signal): Break into debugger when debug-on-event
12222 matches the current signal symbol.
12224 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12226 * alloc.c (check_sblock, check_string_bytes)
12227 (check_string_free_list): Convert to standard C.
12229 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12231 * w32.c (emacs_gnutls_push): Fix typo.
12233 2011-04-25 Eli Zaretskii <eliz@gnu.org>
12235 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12236 "cast to pointer from integer of different size".
12238 Improve doprnt and its use in verror. (Bug#8545)
12239 * doprnt.c (doprnt): Document the set of format control sequences
12240 supported by the function. Use SAFE_ALLOCA instead of always
12243 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12244 is one byte too soon. Don't use xrealloc; instead xfree and
12247 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12249 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12252 * gnutls.c: Renamed global_initialized to
12253 gnutls_global_initialized. Added internals for the
12254 :verify-hostname-error, :verify-error, and :verify-flags
12255 parameters of `gnutls-boot' and documented those parameters in the
12256 docstring. Start callback support.
12257 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12258 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12259 on error. Return error code.
12260 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12261 (emacs_gnutls_read): Likewise.
12262 (Fgnutls_boot): Return handshake error code.
12263 (emacs_gnutls_handle_error): New function.
12264 (wsaerror_to_errno): Likewise.
12266 * w32.h (emacs_gnutls_pull): Add prototype.
12267 (emacs_gnutls_push): Likewise.
12269 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12270 (emacs_gnutls_push): Likewise.
12272 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12274 * process.c (wait_reading_process_output): Check if GnuTLS
12275 buffered some data internally if no FDs are set for TLS
12278 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12279 (LIBS): Link to USER_LIBS.
12280 ($(BLD)/gnutls.$(0)): New target.
12282 2011-04-24 Eli Zaretskii <eliz@gnu.org>
12284 * xdisp.c (handle_single_display_spec): Rename the
12285 display_replaced_before_p argument into display_replaced_p, to
12286 make it consistent with the commentary. Fix typos in the
12289 * textprop.c (syms_of_textprop): Remove dead code.
12290 (copy_text_properties): Delete obsolete commentary about an
12291 interface that was deleted long ago. Fix typos in the description
12294 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12295 to changes in oldXMenu/XMenu.h from 2011-04-16.
12296 <menu_help_message, prev_menu_help_message>: Constify.
12297 (IT_menu_make_room): menu->help_text is now `const char **';
12300 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12301 to changes in oldXMenu/XMenu.h from 2011-04-16.
12302 (struct XMenu): Declare `help_text' `const char **'.
12304 * xfaces.c <Qunspecified>: Make extern again.
12306 * syntax.c: Include sys/types.h before including regex.h, as
12309 * doc.c (get_doc_string): Improve the format passed to `error'.
12311 * doprnt.c (doprnt): Improve commentary.
12313 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12315 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12318 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12319 changes in globals.h immediately force recompilation.
12320 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12321 $(CURDIR)/s/ms-w32.h.
12322 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12324 * character.c (Fchar_direction): Function deleted.
12325 (syms_of_character): Don't defsubr it.
12326 <char-direction-table>: Deleted.
12328 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12330 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12331 * doprnt.c: Include limits.h.
12332 (SIZE_MAX): New macro.
12333 (doprnt): Return a size_t value. 2nd arg is now size_t.
12334 Many local variables are now size_t instead of int or unsigned.
12335 Improve overflow protection. Support `l' modifier for integer
12336 conversions. Support %l conversion. Don't assume an EMACS_INT
12337 argument for integer conversions and for %c.
12339 * lisp.h (doprnt): Restore prototype.
12341 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12342 $(SRC)/character.h.
12344 * Makefile.in (base_obj): Add back doprnt.o.
12346 * deps.mk (doprnt.o): Add back prerequisites.
12347 (callint.o): Depend on character.h.
12349 * eval.c (internal_lisp_condition_case): Include the handler
12350 representation in the error message.
12351 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12352 when breaking from the loop.
12354 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12356 * callint.c (Fcall_interactively): When displaying error message
12357 about invalid control letter, pass the character's codepoint, not
12358 a pointer to its multibyte form. Improve display of the character
12359 in octal and display also its hex code.
12361 * character.c (char_string): Use %x to display the (unsigned)
12362 codepoint of an invalid character, to avoid displaying a bogus
12365 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12366 `error', not SYMBOL_NAME itself.
12368 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12369 character arguments to `error'.
12371 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12372 to `error' in error message about FINAL_CHAR argument. Make sure
12373 FINAL_CHAR is a character, and use %c when it is passed as
12374 argument to `error'.
12376 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12378 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12380 * w32.c: Include <time.h>.
12381 (sys_localtime): New function.
12383 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12385 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12387 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12389 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12391 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12392 zombies (Bug#8467).
12394 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12396 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12397 gl_state.e_property when gl_state.object is Qt.
12399 * insdel.c (make_gap_larger): Remove limitation of buffer size
12402 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12404 * xdisp.c (lookup_glyphless_char_display)
12405 (produce_glyphless_glyph): Handle cons cell entry in
12406 glyphless-char-display.
12407 (Vglyphless_char_display): Document it.
12409 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12410 glyphless-char-display.
12412 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12414 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12416 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12418 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12419 definition for no-X builds.
12421 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12423 Static checks with GCC 4.6.0 and non-default toolkits.
12425 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12427 * process.c (keyboard_bit_set): Define only if SIGIO.
12428 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12429 (send_process): Repair possible setjmp clobbering.
12431 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12433 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12435 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12437 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12438 Define only if needed.
12440 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12441 by pacifying GCC about it. Maybe it's time to retire it?
12442 * xfaces.c (USG, __TIMEVAL__): Likewise.
12444 * dispextern.h (struct redisplay_interface): Rename param
12445 to avoid shadowing.
12446 * termhooks.h (struct terminal): Likewise.
12447 * xterm.c (xembed_send_message): Likewise.
12449 * insdel.c (make_gap_smaller): Define only if
12450 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12452 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12455 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12456 so that we aren't warned about unused symbols.
12458 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12460 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12462 * xfns.c (x_real_positions): Mark locals as initialized.
12464 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12466 * xterm.c: Fix problems found by static analysis with other toolkits.
12467 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12468 (x_dispatch_event): Declare static if USE_GTK, and
12469 define if USE_GTK || USE_X_TOOLKIT.
12470 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12471 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12472 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12473 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12475 * xmenu.c (menu_help_callback): Pointer type fixes.
12476 Use const pointers when pointing at readonly data. Avoid pointer
12477 signedness clashes.
12478 (FALSE): Remove unused macro.
12479 (update_frame_menubar): Remove unused decl.
12481 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12483 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12484 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12485 (single_menu_item): Rename local to avoid shadowing.
12487 * keyboard.c (make_lispy_event): Remove unused local var.
12489 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12490 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12492 * bitmaps: Change bitmaps from unsigned char back to the X11
12493 compatible char. Avoid the old compiler warnings about
12494 out-of-range initializers by using, for example, '\xab' rather
12497 * xgselect.c (xgselect_initialize): Check vs interface
12498 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12500 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12502 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12503 to read-only memory.
12505 * fns.c (vector): Remove; this old hack is no longer needed.
12507 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12509 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12511 * xrdb.c (x_load_resources): Omit unused local.
12513 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12514 (x_window): Rename locals to avoid shadowing.
12515 (USG): Use the kludged USG macro, to pacify gcc.
12517 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12518 (x_term_init): Remove local to avoid shadowing.
12520 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12522 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12523 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12525 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12527 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12529 Fix regex.c, syntax.c and friends for buffers > 2GB.
12530 * syntax.h (struct gl_state_s): Declare character position members
12533 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12535 * textprop.c (verify_interval_modification, interval_of):
12536 Declare arguments EMACS_INT.
12538 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12541 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12543 * indent.c (Fvertical_motion): Local variable it_start is now
12546 * regex.c (re_match, re_match_2, re_match_2_internal)
12547 (bcmp_translate, regcomp, regexec, print_double_string)
12548 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12549 (re_compile_pattern, re_exec): Declare arguments and local
12550 variables `size_t' and `ssize_t' and return values `regoff_t', as
12552 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12553 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12554 <compile_stack_type>: `size' and `avail' are now `size_t'.
12556 * regex.h <regoff_t>: Use ssize_t, not int.
12557 (re_search, re_search_2, re_match, re_match_2): Arguments that
12558 specify buffer/string position and length are now ssize_t and
12559 size_t. Return type is regoff_t.
12561 2011-04-16 Ben Key <bkey76@gmail.com>
12563 * nsfont.m: Fixed bugs in ns_get_family and
12564 ns_descriptor_to_entity that were caused by using free to
12565 deallocate memory blocks that were allocated by xmalloc (via
12566 xstrdup). This caused Emacs to crash when compiled with
12567 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12568 --enable-checking=xmallocoverrun). xfree is now used to
12569 deallocate these memory blocks.
12571 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12573 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12575 emacs_write: Accept and return EMACS_INT for sizes.
12576 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12578 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12579 Accept and return EMACS_INT.
12580 (emacs_gnutls_write): Return the number of bytes written on
12582 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12583 (emacs_read, emacs_write): Remove check for negative size, as the
12584 Emacs source code has been audited now.
12585 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12586 (emacs_read, emacs_write): Use it.
12587 * process.c (send_process): Adjust to the new signatures of
12588 emacs_write and emacs_gnutls_write. Do not attempt to store
12589 a byte offset into an 'int'; it might overflow.
12590 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12592 * sound.c: Don't assume sizes fit in 'int'.
12593 (struct sound_device.period_size, alsa_period_size):
12594 Return EMACS_INT, not int.
12595 (struct sound_device.write, vox_write, alsa_write):
12596 Accept EMACS_INT, not int.
12597 (wav_play, au_play): Use EMACS_INT to store sizes and to
12598 record read return values.
12600 2011-04-15 Ben Key <bkey76@gmail.com>
12602 * keyboard.c (Qundefined): Don't declare static since it is used
12604 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12605 static since they are used in nsfont.m.
12607 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12609 * process.c (Qprocessp): Don't declare static.
12610 * lisp.h (Qprocessp): Declare again.
12612 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12614 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12616 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12618 Improve C-level modularity by making more things 'static'.
12620 Don't publish debugger-only interfaces to other modules.
12621 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12622 (verify_bytepos, count_markers): Move decls to the only modules
12624 * region-cache.h (pp_cache): Likewise.
12625 * window.h (check_all_windows): Likewise.
12626 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12628 * sysdep.c (croak): Now static, if
12629 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12630 * syssignal.h (croak): Declare only if not static.
12632 * alloc.c (refill_memory_reserve): Now static if
12633 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12634 * lisp.h (refill_memory_reserve): Declare only if not static.
12636 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12637 Define only if USE_LUCID.
12639 * xrdb.c (x_customization_string, x_rm_string): Now static.
12641 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12642 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12644 * xdisp.c (draw_row_with_mouse_face): Now static.
12645 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12647 * window.h (check_all_windows): Mark externally visible.
12649 * window.c (window_deletion_count): Now static.
12651 * undo.c: Make symbols static if they're not exported.
12652 (last_undo_buffer, last_boundary_position, pending_boundary):
12655 * textprop.c (interval_insert_behind_hooks): Now static.
12656 (interval_insert_in_front_hooks): Likewise.
12658 * term.c: Make symbols static if they're not exported.
12659 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12660 (max_frame_lines, tty_set_terminal_modes):
12661 (tty_reset_terminal_modes, tty_turn_off_highlight):
12662 (get_tty_terminal): Now static.
12663 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12664 * termhooks.h (term_mouse_moveto): Do not declare if
12665 HAVE_WINDOW_SYSTEM.
12666 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12667 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12669 * sysdep.c: Make symbols static if they're not exported.
12670 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12672 (sigprocmask_set, full_mask): Remove; unused.
12673 (wait_debugging): Mark as visible.
12674 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12675 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12677 * syntax.c (syntax_temp): Define only if !__GNUC__.
12679 * sound.c (current_sound_device, current_sound): Now static.
12681 * search.c (searchbufs, searchbuf_head): Now static.
12683 * scroll.c (scroll_cost): Remove; unused.
12684 * dispextern.h (scroll_cost): Remove decl.
12686 * region-cache.h (pp_cache): Mark as externally visible.
12688 * process.c: Make symbols static if they're not exported.
12689 (process_tick, update_tick, create_process, chan_process):
12690 (Vprocess_alist, proc_buffered_char, datagram_access):
12691 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12692 (deactivate_process): Mark defn as static, as well as decl.
12693 * lisp.h (create_process): Remove decl.
12694 * process.h (chan_process, Vprocess_alist): Remove decls.
12696 * print.c: Make symbols static if they're not exported.
12697 (print_depth, new_backquote_output, being_printed, print_buffer):
12698 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12699 (print_interval, print_number_index, initial_stderr_stream):
12701 * lisp.h (Fprinc): Remove decl.
12702 (debug_output_compilation_hack): Mark as externally visible.
12704 * sysdep.c (croak): Move decl from here to syssignal.h.
12705 * syssignal.h (croak): Put it here, so the API can be checked when
12706 'croak' is called from dissociate_if_controlling_tty.
12708 * minibuf.c: Make symbols static if they're not exported.
12709 (minibuf_save_list, choose_minibuf_frame): Now static.
12710 * lisp.h (choose_minibuf_frame): Remove decl.
12712 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12714 * lread.c: Make symbols static if they're not exported.
12715 (read_objects, initial_obarray, oblookup_last_bucket_number):
12717 (make_symbol): Remove; unused.
12718 * lisp.h (initial_obarray, make_symbol): Remove decls.
12720 * keyboard.c: Make symbols static if they're not exported.
12721 (single_kboard, recent_keys_index, total_keys, recent_keys):
12722 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12723 (this_single_command_key_start, echoing, last_auto_save):
12724 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12725 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12726 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12727 (Vlispy_mouse_stem, double_click_count):
12729 (force_auto_save_soon): Define only if SIGDANGER.
12730 (ignore_mouse_drag_p): Now static if
12731 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12732 (print_help): Remove; unused.
12733 (stop_character, last_timer_event): Mark as externally visible.
12734 * keyboard.h (ignore_mouse_drag_p): Declare only if
12735 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12736 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12737 * lisp.h (echoing): Remove decl.
12738 (force_auto_save_soon): Declare only if SIGDANGER.
12739 * xdisp.c (redisplay_window): Simplify code, to make it more
12740 obvious that ignore_mouse_drag_p is not accessed if !defined
12741 USE_GTK && !defined HAVE_NS.
12743 * intervals.c: Make symbols static if they're not exported.
12744 (merge_properties_sticky, merge_interval_right, delete_interval):
12746 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12748 * insdel.c: Make symbols static if they're not exported.
12749 However, leave prepare_to_modify_buffer alone. It's never
12750 called from outside this function, but that appears to be a bug.
12751 (combine_after_change_list, combine_after_change_buffer):
12752 (adjust_after_replace, signal_before_change): Now static.
12753 (adjust_after_replace_noundo): Remove; unused.
12754 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12755 (signal_before_change): Remove decls.
12757 * indent.c (val_compute_motion, val_vmotion): Now static.
12759 * image.c: Make symbols static if they're not exported.
12760 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12762 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12763 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12765 * fringe.c (standard_bitmaps): Now static.
12766 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12768 * frame.c: Make symbols static if they're not exported.
12769 (x_report_frame_params, make_terminal_frame): Now static.
12770 (get_frame_param): Now static, unless HAVE_NS.
12771 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12772 (x_get_resource_string): Remove; not used.
12773 * frame.h (make_terminal_frame, x_report_frame_params):
12774 (x_get_resource_string); Remove decls.
12775 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12776 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12778 * font.c, fontset.c: Make symbols static if they're not exported.
12779 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12780 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12781 * font.c (font_close_object): Now static.
12782 * font.h (font_close_object): Remove.
12783 * fontset.c (FONTSET_OBJLIST): Remove.
12784 (free_realized_fontset) #if-0 the body, which does nothing.
12785 (face_suitable_for_char_p): #if-0, as it's never called.
12786 * fontset.h (face_suitable_for_char_p): Remove decl.
12787 * xfaces.c (face_at_string_position):
12788 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12789 since 0 is always ASCII.
12791 * fns.c (weak_hash_tables): Now static.
12793 * fileio.c: Make symbols static if they're not exported.
12794 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12795 (Vwrite_region_annotation_buffers): Now static.
12797 * eval.c: Make symbols static if they're not exported.
12798 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12799 * lisp.h (backtrace_list): Remove decl.
12801 * emacs.c: Make symbols static if they're not exported.
12802 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12803 (fatal_error_code, fatal_error_signal_hook, standard_args):
12805 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12806 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12807 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12808 * lisp.h (fatal_error_signal_hook): Remove decl.
12809 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12811 * editfns.c: Move a (normally-unused) function to its only use.
12812 * editfns.c, lisp.h (get_operating_system_release): Remove.
12813 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12814 worth the hassle of breaking this out.
12816 * xterm.c: Make symbols static if they're not exported.
12817 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12818 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12819 (x_destroy_window, x_delete_display):
12821 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12822 (x_mouse_leave): Remove; unused.
12823 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12824 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12825 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12827 (x_mouse_leave): Declare only if WINDOWSNT.
12828 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12829 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12832 * ftxfont.c: Make symbols static if they're not exported.
12833 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12835 * font.h (ftxfont_driver): Likewise.
12837 * xfns.c: Make symbols static if they're not exported.
12838 (x_last_font_name, x_display_info_for_name):
12839 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12840 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12841 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12842 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12843 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12844 (last_show_tip_args): Now static.
12845 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12846 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12847 (x_screen_planes): Remove; unused.
12848 * dispextern.h (x_screen_planes): Remove decl.
12850 * dispnew.c: Make symbols static if they're not exported.
12851 * dispextern.h (redraw_garbaged_frames, scrolling):
12852 (increment_row_positions): Remove.
12853 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12854 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12856 (redraw_garbaged_frames): Remove; unused.
12858 * xfaces.c: Make symbols static if they're not exported.
12859 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12861 * xterm.h (defined_color): Remove decls.
12862 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12863 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12864 (menu_face_changed_default, defined_color, free_realized_face):
12865 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12866 (ascii_face_of_lisp_face): Remove; unused.
12868 * xdisp.c: Make symbols static if they're not exported.
12869 * dispextern.h (scratch_glyph_row, window_box_edges):
12870 (glyph_to_pixel_coords, set_cursor_from_row):
12871 (get_next_display_element, set_iterator_to_next):
12872 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12873 (show_mouse_face): Remove decls
12874 * frame.h (message_buf_print): Likewise.
12875 * lisp.h (pop_message, set_message, check_point_in_composition):
12877 * xterm.h (set_vertical_scroll_bar): Likewise.
12878 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12879 (message_buf_print, scratch_glyph_row, displayed_buffer):
12880 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12881 (get_next_display_element, show_mouse_face, window_box_edges):
12882 (frame_to_window_pixel_xy, check_point_in_composition):
12883 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12884 (glyph_to_pixel_coords): Remove; unused.
12886 * dired.c (file_name_completion): Now static.
12888 * dbusbind.c (xd_in_read_queued_messages): Now static.
12890 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12891 * data.c (circular_list_error): Remove.
12893 * commands.h (last_point_position, last_point_position_buffer):
12894 (last_point_position_window): Remove decls.
12895 * keyboard.c: Make these variables static.
12897 * coding.h (coding, code_convert_region, encode_coding_gap):
12899 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12900 (iso_code_class, detect_coding, code_convert_region): Now static.
12901 (encode_coding_gap): Remove; unused.
12903 * chartab.c (chartab_chars, chartab_bits): Now static.
12905 * charset.h (charset_iso_8859_1): Remove decl.
12906 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12909 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12910 * ccl.c (Vccl_program_table): Now static.
12911 (check_ccl_update): Remove; unused.
12913 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12914 * category.h: ... from here.
12915 * category.c (check_category_table, set_category_set): Now static.
12917 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12918 * lisp.h: Remove these decls.
12920 * buffer.c (buffer_count): Remove unused var.
12922 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12923 so that it's not optimized away.
12924 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12925 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12926 exported only to the debugger.
12928 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12929 * atimer.h (run_all_atimers): Remove; not exported.
12931 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12932 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12933 was inaccessible from Lisp.
12934 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12935 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12937 alloc.c: Import and export fewer symbols, and remove unused items.
12938 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12940 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12941 it's not optimized away by whole-program optimization.
12942 (message_enable_multibyte, free_misc): Remove.
12943 (catchlist, handlerlist, mark_backtrace):
12944 Declare only if BYTE_MARK_STACK.
12945 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12946 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12947 (message_enable_multibyte): Remove decl.
12948 (free_misc, interval_free_list, float_block, float_block_index):
12949 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12950 (cons_free_list, last_marked_index):
12952 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12953 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12954 (mark_backtrace): Define only if BYTE_MARK_STACK.
12955 * xdisp.c (message_enable_multibyte): Now static.
12957 Declare Lisp_Object Q* variables to be 'static' if not exported.
12958 This makes it easier for human readers (and static analyzers)
12959 to see whether these variables are used from other modules.
12960 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12961 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12962 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12963 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12964 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12965 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12966 * xmenu.c, xselect.c:
12967 Declare Q* vars static if they are not used in other modules.
12968 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12969 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12970 Remove decls of unexported vars.
12971 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12973 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12975 Make Emacs functions such as Fatom 'static' by default.
12976 This makes it easier for human readers (and static analyzers)
12977 to see whether these functions can be called from other modules.
12978 DEFUN now defines a static function. To make the function external
12979 so that it can be used in other C modules, use the new macro DEFUE.
12980 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12981 (Finit_image_library):
12982 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12983 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12984 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12985 Remove decls, since these functions are now static.
12986 (Funintern, Fget_internal_run_time): New decls, since these functions
12987 were already external.
12989 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12990 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12991 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12992 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12993 * keyboard.c, keymap.c, lread.c:
12994 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12995 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12996 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12997 Mark functions with DEFUE instead of DEFUN,
12998 if they are used in other modules.
12999 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13000 decls for now-static functions.
13001 * buffer.h (Fdelete_overlay): Remove decl.
13002 * callproc.c (Fgetenv_internal): Mark as internal.
13003 * composite.c (Fremove_list_of_text_properties): Remove decl.
13004 (Fcomposition_get_gstring): New forward static decl.
13005 * composite.h (Fcomposite_get_gstring): Remove decl.
13006 * dired.c (Ffile_attributes): New forward static decl.
13007 * doc.c (Fdocumntation_property): New forward static decl.
13008 * eval.c (Ffetch_bytecode): New forward static decl.
13009 (Funintern): Remove extern decl; now in .h file where it belongs.
13010 * fileio.c (Fmake_symbolic_link): New forward static decl.
13011 * image.c (Finit_image_library): New forward static decl.
13012 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13013 * intervals.h (Fprevious_property_change):
13014 (Fremove_list_of_text_properties): Remove decls.
13015 * keyboard.c (Fthis_command_keys): Remove decl.
13016 (Fcommand_execute): New forward static decl.
13017 * keymap.c (Flookup_key): New forward static decl.
13018 (Fcopy_keymap): Now static.
13019 * keymap.h (Flookup_key): Remove decl.
13020 * process.c (Fget_process): New forward static decl.
13021 (Fprocess_datagram_address): Mark as internal.
13022 * syntax.c (Fsyntax_table_p): New forward static decl.
13023 (skip_chars): Remove duplicate decl.
13024 * textprop.c (Fprevious_property_change): New forward static decl.
13025 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13027 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13028 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13030 * editfns.c (Fformat): Remove unreachable code.
13032 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13034 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13037 2011-04-13 Eli Zaretskii <eliz@gnu.org>
13039 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13040 when at ZV. (Bug#8487)
13042 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13044 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13046 * keyboard.c (parse_tool_bar_item): Likewise.
13047 * sound.c (sound_cleanup, alsa_close): Likewise.
13048 * termcap.c (tgetent): Likewise.
13049 * xfns.c (x_default_font_parameter): Likewise.
13050 * xsettings.c (read_and_apply_settings): Likewise.
13052 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13053 (overrun_check_free): Protoize.
13055 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13057 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13058 since callers should never pass a negative size.
13059 Change the signature to match that of plain 'read' and 'write'; see
13060 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13061 * lisp.h: Update prototypes of emacs_write and emacs_read.
13063 2011-04-11 Eli Zaretskii <eliz@gnu.org>
13065 * xdisp.c (redisplay_window): Don't try to determine the character
13066 position of the scroll margin if the window start point w->startp
13067 is outside the buffer's accessible region. (Bug#8468)
13069 2011-04-10 Eli Zaretskii <eliz@gnu.org>
13071 Fix write-region and its subroutines for buffers > 2GB.
13072 * fileio.c (a_write, e_write): Modify declaration of arguments and
13073 local variables to support buffers larger than 2GB.
13074 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13076 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13077 argument, local variables, and return value.
13079 * lisp.h: Update prototypes of emacs_write and emacs_read.
13081 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13083 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
13085 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13087 Fix more problems found by GCC 4.6.0's static checks.
13089 * xdisp.c (vmessage): Use a better test for character truncation.
13091 * charset.c (load_charset_map): <, not <=, for optimization,
13092 and to avoid potential problems with integer overflow.
13093 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
13094 * casetab.c (set_identity, shuffle): Likewise.
13095 * editfns.c (Fformat): Likewise.
13096 * syntax.c (skip_chars): Likewise.
13098 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13099 This also lets GCC 4.6.0 generate slightly better loop code.
13101 * callint.c (Fcall_interactively): <, not <=, for optimization.
13102 (Fcall_interactively): Count the number of arguments produced,
13103 not the number of arguments given. This is simpler and lets GCC
13104 4.6.0 generate slightly better code.
13106 * ftfont.c: Distingish more carefully between FcChar8 and char.
13107 The previous code passed unsigned char * to a functions like
13108 strlen and xstrcasecmp that expect char *, which does not
13109 conform to the C standard.
13110 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13111 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13112 char * when the C standard requires it.
13114 * keyboard.c (read_char): Remove unused var.
13116 * eval.c: Port to Windows vsnprintf (Bug#8435).
13117 Include <limits.h>.
13118 (SIZE_MAX): Define if the headers do not.
13119 (verror): Do not give up if vsnprintf returns a negative count.
13120 Instead, grow the buffer. This ports to Windows vsnprintf, which
13121 does not conform to C99. Problem reported by Eli Zaretskii.
13122 Also, simplify the allocation scheme, by avoiding the need for
13123 calling realloc, and removing the ALLOCATED variable.
13125 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13127 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13128 But keep the doprint source code for now, as we might revamp it
13129 and use it again (Bug#8435).
13130 * lisp.h (doprnt): Remove.
13131 * Makefile.in (base_obj): Remove doprnt.o.
13132 * deps.mk (doprnt.o): Remove.
13134 error: Print 32- and 64-bit integers portably (Bug#8435).
13135 Without this change, on typical 64-bit hosts error ("...%d...", N)
13136 was used to print both 32- and 64-bit integers N, which relied on
13137 undefined behavior.
13138 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
13139 * lisp.h (error, verror): Mark as printf-like functions.
13140 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13141 Report overflow in size calculations when allocating printf buffer.
13142 Do not truncate output string at its first null byte.
13143 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13144 Truncate the output at a character boundary, since vsnprintf does not
13146 * charset.c (check_iso_charset_parameter): Convert internal
13147 character to string before calling 'error', since %c now has the
13149 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13150 overflow when computing char to be passed to 'error'. Do not
13151 pass Lisp_Object to 'error'; pass the integer instead.
13152 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13153 formatted with plain %d.
13155 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13157 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13159 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13161 * xterm.c (x_catch_errors): Remove duplicate declaration.
13163 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13165 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13167 2011-04-10 Jim Meyering <meyering@redhat.com>
13169 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13170 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13171 return ssize_t not "int", and use size_t as the buffer length.
13172 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13173 * gnutls.h: Update declarations.
13174 * process.c (read_process_output): Use ssize_t, to match.
13175 (send_process): Likewise.
13177 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13179 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13181 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13183 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13184 Use unsigned char, to match FcChar8 type definition.
13186 * xterm.c (handle_one_xevent):
13187 * xmenu.c (create_and_show_popup_menu):
13188 * xselect.c (x_decline_selection_request)
13189 (x_reply_selection_request): Avoid type-punned deref of X events.
13191 2011-04-09 Eli Zaretskii <eliz@gnu.org>
13193 Fix some uses of `int' instead of EMACS_INT.
13194 * search.c (string_match_1, fast_string_match)
13195 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13196 (scan_buffer, find_next_newline_no_quit)
13197 (find_before_next_newline, search_command, Freplace_match)
13198 (Fmatch_data): Make some `int' variables be EMACS_INT.
13200 * xdisp.c (display_count_lines): 3rd argument and return value now
13201 EMACS_INT. All callers changed.
13202 (pint2hrstr): Last argument is now EMACS_INT.
13204 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13205 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13206 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13207 (decode_coding_utf_16, decode_coding_emacs_mule)
13208 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13209 (decode_coding_ccl, decode_coding_charset)
13210 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13211 (decode_coding_iso_2022, decode_coding_emacs_mule)
13212 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13213 <char_offset, last_offset>: Declare EMACS_INT.
13214 (encode_coding_utf_8, encode_coding_utf_16)
13215 (encode_coding_emacs_mule, encode_invocation_designation)
13216 (encode_designation_at_bol, encode_coding_iso_2022)
13217 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13218 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13220 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13221 (encode_invocation_designation): Last argument P_NCHARS is now
13223 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13224 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13226 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13229 * ccl.c (Fccl_execute_on_string): Declare some variables
13232 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
13234 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13236 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13238 * process.c (Fformat_network_address): Doc fix.
13240 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13242 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
13244 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
13246 * keyboard.c (read_char): Call Lisp function help-form-show,
13247 instead of using internal_with_output_to_temp_buffer.
13248 (Qhelp_form_show): New var.
13249 (syms_of_keyboard): Use DEFSYM macro.
13251 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13253 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13255 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
13257 * process.c (Flist_processes): Remove to Lisp.
13258 (list_processes_1): Delete.
13260 2011-04-06 Eli Zaretskii <eliz@gnu.org>
13262 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13264 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13266 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13268 Fix more problems found by GCC 4.6.0's static checks.
13270 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13272 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13274 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
13276 * xdisp.c (vmessage): Mark as a printf-like function.
13278 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13280 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13282 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13283 printf-like functions.
13284 (tiff_load): Add casts to remove these marks before passing them
13285 to system-supplied API.
13287 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13289 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13290 This avoids several warnings with gcc -Wstrict-overflow.
13291 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13292 directly, rather than having caller test rule sign. This avoids
13293 some unnecessary tests.
13294 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13295 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13296 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
13298 * xfont.c (xfont_text_extents): Remove var that was set but not used.
13299 (xfont_open): Avoid unnecessary tests.
13301 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13303 * composite.h, composite.c (composition_gstring_put_cache):
13304 Use EMACS_INT, not int, for length.
13306 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13307 breaking out part of COMPOSITION_DECODE_RULE.
13308 (COMPOSITION_DECODE_RULE): Use it.
13309 * composite.c (get_composition_id): Remove unused local vars,
13310 by using the new macro.
13312 * textprop.c (set_text_properties_1): Change while to do-while,
13313 since the condition is always true at first.
13315 * intervals.c (graft_intervals_into_buffer): Mark var as used.
13316 (interval_deletion_adjustment): Return unsigned value.
13319 * process.c (list_processes_1, create_pty, read_process_output):
13320 (exec_sentinel): Remove vars that were set but not used.
13321 (create_pty): Remove unnecessary "volatile"s.
13322 (Fnetwork_interface_info): Avoid possibility of int overflow.
13323 (read_process_output): Do adaptive read buffering even if carryover.
13324 (read_process_output): Simplify nbytes computation if buffered.
13326 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13328 * syntax.c (scan_words): Remove var that was set but not used.
13329 (update_syntax_table): Use unsigned instead of int.
13331 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13332 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13333 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13335 * print.c (print_error_message): Avoid int overflow.
13337 * font.c (font_list_entities): Redo for clarity,
13338 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13340 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13341 (font_score): Avoid potential overflow in diff calculation.
13343 * fns.c (substring_both): Remove var that is set but not used.
13344 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13346 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13348 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13349 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13350 can always succeed if overflow has undefined behavior.
13352 * search.c (boyer_moore, wordify): Remove vars set but not used.
13353 (wordify): Omit three unnecessary tests.
13355 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13356 All callers changed. This avoids the need for an unused var.
13358 * casefiddle.c (casify_region): Remove var that is set but not used.
13360 * dired.c (file_name_completion): Remove var that is set but not used.
13362 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13364 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13365 (Finsert_file_contents): Remove unnecessary code checking fd.
13367 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13368 Check for integer overflow on size calculations.
13370 * buffer.c (Fprevious_overlay_change): Remove var that is set
13373 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13374 Remove vars that are set but not used.
13375 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13376 (timer_check_2): Mark vars as initialized.
13378 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13380 * image.c (lookup_image): Remove var that is set but not used.
13381 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13383 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13384 that are set but not used.
13386 * xfns.c (make_invisible_cursor): Don't return garbage
13387 if XCreateBitmapFromData fails (Bug#8410).
13389 * xselect.c (x_get_local_selection, x_handle_property_notify):
13390 Remove vars that are set but not used.
13392 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13393 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13395 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13396 Remove var that is set but not used.
13397 (scroll_bar_windows_size): Now size_t, not int.
13398 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13399 Check for overflow.
13401 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13402 (map_tty_color) [!defined MSDOS]: Likewise.
13404 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13406 * coding.c: Remove vars that are set but not used.
13407 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13408 All callers changed.
13409 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13410 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13411 (decode_coding_charset): Remove vars that are set but not used.
13413 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13414 that is set but not used.
13416 * print.c (print_object): Remove var that is set but not used.
13418 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13419 The gnulib version avoids calling malloc in the usual case,
13420 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13421 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13422 * filelock.c (current_lock_owner): Likewise.
13423 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13424 * sysdep.c: Include allocator.h, careadlinkat.h.
13425 (emacs_no_realloc_allocator): New static constant.
13426 (emacs_readlink): New function.
13427 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13428 ../lib/careadlinkat.h.
13430 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13432 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13433 first non-nil return value).
13435 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13437 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13438 if not defined (Bug#8403).
13440 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13442 * xdisp.c (display_count_lines): Remove parameter `start',
13443 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13444 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13445 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13446 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13447 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13448 and thereabouts. All callers changed.
13449 (get_per_char_metric): Remove parameter `f', unused since
13450 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13452 2011-04-02 Jim Meyering <meyering@redhat.com>
13454 do not dereference NULL upon failed strdup
13455 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13456 (ns_get_family): Likewise.
13458 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13460 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13462 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13464 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13467 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13469 Add lexical binding.
13471 * window.c (Ftemp_output_buffer_show): New fun.
13472 (Fsave_window_excursion):
13473 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13475 * lread.c (lisp_file_lexically_bound_p): New function.
13476 (Fload): Bind Qlexical_binding.
13477 (readevalloop): Remove `evalfun' arg.
13478 Bind Qinternal_interpreter_environment.
13479 (Feval_buffer): Bind Qlexical_binding.
13480 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13482 (syms_of_lread): Declare `lexical-binding'.
13484 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13486 * keyboard.c (eval_dyn): New fun.
13487 (menu_item_eval_property): Use it.
13489 * image.c (parse_image_spec): Use Ffunctionp.
13491 * fns.c (concat, mapcar1): Accept byte-code-functions.
13493 * eval.c (Fsetq): Handle lexical vars.
13494 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13495 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13496 (FletX, Flet): Obey lexical binding.
13497 (Fcommandp): Handle closures.
13498 (Feval): New `lexical' arg.
13499 (eval_sub): New function extracted from Feval. Use it almost
13500 everywhere where Feval was used. Look up vars in lexical env.
13502 (Ffunctionp): Move from subr.el.
13503 (Ffuncall): Handle closures.
13504 (apply_lambda): Remove `eval_flags'.
13505 (funcall_lambda): Handle closures and new byte-code-functions.
13506 (Fspecial_variable_p): New function.
13507 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13508 but without exporting it to Lisp.
13510 * doc.c (Fdocumentation, store_function_docstring):
13511 * data.c (Finteractive_form): Handle closures.
13513 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13516 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13518 (exec_byte_code): New function extracted from Fbyte_code to handle new
13519 calling convention for byte-code-functions. Add new byte-codes.
13521 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13523 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13525 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13527 * xdisp.c (redisplay_internal): Fix prototype.
13529 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13531 * xdisp.c (SCROLL_LIMIT): New macro.
13532 (try_scrolling): Use it when setting scroll_limit.
13533 Limit scrolling to 100 screen lines.
13534 (redisplay_window): Even when falling back on "recentering",
13535 position point in the window according to scroll-conservatively,
13536 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13538 (try_scrolling): When point is above the window, allow searching
13539 as far as scroll_max, or one screenful, to compute vertical
13540 distance from PT to the scroll margin position. This prevents
13541 try_scrolling from unnecessarily failing when
13542 scroll-conservatively is set to a value slightly larger than the
13543 window height. Clean up the case of PT below the margin at bottom
13544 of window: scroll_max can no longer be INT_MAX. When aggressive
13545 scrolling is in use, don't let point enter the opposite scroll
13546 margin as result of the scroll.
13547 (syms_of_xdisp) <scroll-conservatively>: Document the
13548 threshold of 100 lines for never-recentering scrolling.
13550 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13552 * dispextern.h (move_it_by_lines):
13553 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13554 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13555 (message_log_check_duplicate): Remove parameters `prev_bol' and
13556 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13557 (redisplay_internal): Remove parameter `preserve_echo_area',
13558 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13560 * indent.c (Fvertical_motion):
13561 * window.c (window_scroll_pixel_based, Frecenter):
13562 Don't pass `need_y_p' to `move_it_by_lines'.
13564 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13566 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13567 steal a few bits to be more compact.
13568 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13569 Remove unneeded casts.
13571 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13573 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13575 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13576 binding" message (bug#7967).
13578 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13580 Fix more problems found by GCC 4.6.0's static checks.
13582 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13583 Remove unused local var.
13585 * editfns.c (Fmessage_box): Remove unused local var.
13587 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13588 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13589 Omit unused local vars.
13590 * window.c (shrink_windows): Omit unused local var.
13591 * menu.c (digest_single_submenu): Omit unused local var.
13592 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13593 Omit unused local var.
13595 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13596 Don't assume string length fits in int.
13597 (keyremap_step, read_key_sequence): Use size_t for sizes.
13598 (read_key_sequence): Don't check last_real_key_start redundantly.
13600 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13601 instead of alloca (Bug#8344).
13603 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13604 (Fbacktrace_frame): Don't assume nframes fits in int.
13606 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13608 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13611 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13613 * cm.c (calccost): Turn while-do into do-while, for clarity.
13615 * keyboard.c (syms_of_keyboard): Use the same style as later
13616 in this function when indexing through an array. This also
13617 works around GCC bug 48267.
13619 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13621 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13623 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13624 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13626 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13627 This avoids undefined behavior on integer overflow, and is a bit
13628 more convenient anyway since it is compared to a size_t variable.
13630 Variadic C functions now count arguments with size_t, not int.
13631 This avoids an unnecessary limitation on 64-bit machines, which
13632 caused (substring ...) to crash on large vectors (Bug#8344).
13633 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13634 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13635 All variadic functions and their callers changed accordingly.
13636 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13637 * data.c (arith_driver, float_arith_driver): Likewise.
13638 * editfns.c (general_insert_function): Likewise.
13639 * eval.c (struct backtrace.nargs, interactive_p)
13640 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13641 (funcall_lambda, mark_backtrace): Likewise.
13642 * fns.c (concat): Likewise.
13643 * frame.c (x_set_frame_parameters): Likewise.
13644 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13645 0 if not found, not -1. All callers changed.
13647 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13648 (stack_copy_size): Now size_t, not int.
13649 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13651 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13653 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13654 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13655 All callers changed.
13657 * lisp.h (multibyte_char_to_unibyte):
13658 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13659 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13660 * character.h (CHAR_TO_BYTE8):
13661 * cmds.c (internal_self_insert):
13662 * editfns.c (general_insert_function):
13663 * keymap.c (push_key_description):
13664 * search.c (Freplace_match):
13665 * xdisp.c (message_dolog, set_message_1): All callers changed.
13667 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13669 * keyboard.c (safe_run_hook_funcall): New function.
13670 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13671 don't set the hook to nil, but remove the offending function instead.
13672 (Qcommand_hook_internal): Remove, unused.
13673 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13674 Vcommand_hook_internal.
13676 * eval.c (enum run_hooks_condition): Remove.
13677 (funcall_nil, funcall_not): New functions.
13678 (run_hook_with_args): Call each function through a `funcall' argument.
13679 Remove `cond' argument, now redundant.
13680 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13681 (Frun_hook_with_args_until_failure): Adjust accordingly.
13682 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13684 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13686 * dispextern.h (string_buffer_position): Remove declaration.
13688 * print.c (strout): Remove parameter `multibyte', unused since
13689 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13691 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13692 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13693 All callers changed.
13695 * w32.c (_wsa_errlist): Use braces for struct initializers.
13697 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13698 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13699 All callers changed.
13700 (string_buffer_position): Likewise. Also, make static (it's never
13701 used outside xdisp.c).
13702 (cursor_row_p): Remove parameter `w', unused since
13703 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13704 (decode_mode_spec): Remove parameter `precision', introduced during
13705 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13706 All callers changed.
13708 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13710 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13712 2011-03-27 Anders Lindgren <andlind@gmail.com>
13714 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13715 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13716 (ns_update_auto_hide_menu_bar): New functions.
13717 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13718 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13719 ns_constrain_all_frames.
13720 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13721 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13723 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13725 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13727 2011-03-27 Glenn Morris <rgm@gnu.org>
13729 * syssignal.h: Replace RETSIGTYPE with void.
13730 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13731 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13732 Replace SIGTYPE with void everywhere.
13733 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13734 * s/template.h (SIGTYPE): Remove commented out definition.
13736 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13738 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13739 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13741 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13743 * w32.c (read_unc_volume): Use parameter `henum', instead of
13744 global variable `wget_enum_handle'.
13746 * keymap.c (describe_vector): Remove parameters `indices' and
13747 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13748 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13750 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13752 * keyboard.c (timer_check): Remove parameter `do_it_now',
13753 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13754 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13755 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13757 * keyboard.c (read_char):
13758 * w32menu.c (w32_menu_display_help):
13759 * xmenu.c (show_help_event, menu_help_callback):
13760 Adjust calls to `show_help_echo'.
13762 * gtkutil.c (xg_maybe_add_timer):
13763 * keyboard.c (readable_events):
13764 * process.c (wait_reading_process_output):
13765 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13767 * insdel.c (adjust_markers_gap_motion):
13768 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13769 (gap_left, gap_right): Don't call it.
13771 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13773 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13774 incurred during fontification.
13776 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13778 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13779 (DEFVAR_PER_BUFFER): Don't pass it.
13781 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13782 (scrolling_window): Don't pass it.
13784 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13786 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13788 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13790 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13791 of variables specific to SELinux and computation of `encoded_absname'.
13793 * image.c (XPutPixel): Remove unused variable `height'.
13795 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13797 * unexw32.c (get_section_info): Remove unused variable `section'.
13799 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13800 (system_process_attributes): Remove unused variable `sess'.
13801 (sys_read): Remove unused variable `err'.
13803 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13804 (w32_wnd_proc): Remove unused variable `isdead'.
13805 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13806 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13807 (x_create_tip_frame): Remove unused variable `tem'.
13809 * w32inevt.c (w32_console_read_socket):
13810 Remove unused variable `no_events'.
13812 * w32term.c (x_draw_composite_glyph_string_foreground):
13813 Remove unused variable `width'.
13815 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13817 * w32term.c (x_set_glyph_string_clipping):
13818 Don't pass uninitialized region to CombineRgn.
13820 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13822 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13823 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13824 (Fx_close_connection): Remove unused variable `i'.
13826 * w32font.c (w32font_draw): Return number of glyphs.
13827 (w32font_open_internal): Remove unused variable `i'.
13828 (w32font_driver): Add missing initializer.
13830 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13831 (fill_in_menu): Remove unused variable `items_added'.
13833 * w32term.c (last_mouse_press_frame): Remove static global variable.
13834 (w32_clip_to_row): Remove unused variable `f'.
13835 (x_delete_terminal): Remove unused variable `i'.
13837 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13838 (NOTHING): Remove unused static global variable.
13839 (uniscribe_check_otf): Remove unused variable `table'.
13840 (uniscribe_font_driver): Add missing initializers.
13842 2011-03-23 Julien Danjou <julien@danjou.info>
13844 * term.c (Fsuspend_tty, Fresume_tty):
13845 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13846 * window.c (temp_output_buffer_show):
13847 * insdel.c (signal_before_change):
13848 * frame.c (Fhandle_switch_frame):
13849 * fileio.c (Fdo_auto_save):
13850 * emacs.c (Fkill_emacs):
13851 * editfns.c (save_excursion_restore):
13852 * cmds.c (internal_self_insert):
13853 * callint.c (Fcall_interactively):
13854 * buffer.c (Fkill_all_local_variables):
13855 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13857 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13858 unconditionally since it does the check itself.
13860 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13862 Fix more problems found by GCC 4.5.2's static checks.
13864 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13865 the first time through the loop, since we know p0 < p1 then.
13866 This also avoids a gcc -Wstrict-overflow warning.
13868 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13869 leading to a memory leak, possible in functions like
13870 load_charset_map_from_file that can allocate an unbounded number
13871 of objects (Bug#8318).
13873 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13874 that could (at least in theory) be that large.
13876 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13877 This is less likely to overflow, and avoids undefined behavior if
13878 overflow does occur. All callers changed. Use strtoul to scan
13879 for the unsigned long integer.
13880 (pint2hrstr): Simplify and tune code slightly.
13881 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13883 * scroll.c (do_scrolling): Work around GCC bug 48228.
13884 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13886 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13887 This also avoids a warning with gcc -Wstrict-overflow.
13888 (validate_x_resource_name): Simplify count usage.
13889 This also avoids a warning with gcc -Wstrict-overflow.
13891 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13894 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13896 * process.c (Fmake_network_process): Use socklen_t, not int,
13897 where POSIX says socklen_t is required in portable programs.
13898 This fixes a porting bug on hosts like 64-bit HP-UX, where
13899 socklen_t is wider than int (Bug#8277).
13900 (Fmake_network_process, server_accept_connection):
13901 (wait_reading_process_output, read_process_output):
13904 * process.c: Rename or move locals to avoid shadowing.
13905 (list_processes_1, Fmake_network_process):
13906 (read_process_output_error_handler, exec_sentinel_error_handler):
13907 Rename or move locals.
13908 (Fmake_network_process): Define label "retry_connect" only if needed.
13909 (Fnetwork_interface_info): Fix pointer signedness.
13910 (process_send_signal): Add cast to avoid pointer signedness problem.
13911 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13912 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13914 Make tparam.h and terminfo.c consistent.
13915 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13916 Include tparam.h instead, since it declares them.
13917 * cm.h (PC): Remove extern decl; tparam.h now does this.
13918 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13919 * terminfo.c: Include tparam.h, to check interfaces.
13920 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13921 (tparam): Adjust signature to match interface in tparam.h;
13922 this removes some undefined behavior. Check that outstring and len
13923 are zero, which they always are with Emacs.
13924 * tparam.h (PC, BC, UP): New extern decls.
13926 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13927 (xftfont_open): Rename locals to avoid shadowing.
13929 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13930 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13931 (OTF_TAG_SYM): Omit macro if not needed.
13932 (ftfont_list): Remove unused local.
13933 (get_adstyle_property, ftfont_pattern_entity):
13934 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13935 Rename locals to avoid shadowing.
13937 * xfont.c (xfont_list_family): Mark var as initialized.
13939 * xml.c (make_dom): Now static.
13941 * composite.c (composition_compute_stop_pos): Rename local to
13943 (composition_reseat_it): Remove unused locals.
13944 (find_automatic_composition, composition_adjust_point): Likewise.
13945 (composition_update_it): Mark var as initialized.
13946 (find_automatic_composition): Mark vars as initialized,
13947 with a FIXME (Bug#8290).
13949 character.h: Rename locals to avoid shadowing.
13950 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13951 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13952 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13953 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13954 to avoid shadowing.
13956 * textprop.c (property_change_between_p): Remove; unused.
13958 * intervals.c (interval_start_pos): Now static.
13960 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13962 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13963 Rename locals to avoid shadowing.
13965 * sound.c (wav_play, au_play, Fplay_sound_internal):
13966 Fix pointer signedness.
13967 (alsa_choose_format): Remove unused local var.
13968 (wav_play): Initialize a variable to 0, to prevent undefined
13969 behavior (Bug#8278).
13971 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13973 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13975 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13976 clobbering (Bug#8298).
13977 * sysdep.c (sys_subshell): Likewise.
13978 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13980 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13981 This should get cleaned up, so that child_setup has the
13982 same signature on all platforms.
13984 * callproc.c (call_process_cleanup): Now static.
13985 (relocate_fd): Rename locals to avoid shadowing.
13987 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13989 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13990 not to be necessary, and produces flickering.
13992 2011-03-20 Glenn Morris <rgm@gnu.org>
13994 * config.in: Remove file.
13996 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13998 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13999 are now in src/globals.h.
14000 (syms_of_minibuf): Remove spurious & from previous change.
14002 2011-03-20 Leo Liu <sdl.web@gmail.com>
14004 * minibuf.c (completing-read-function): New variable.
14005 (completing-read-default): Rename from completing-read.
14006 (completing-read): Call completing-read-function.
14008 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14010 * xfaces.c (Fx_load_color_file):
14011 Read color file from absolute filename (bug#8250).
14013 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14015 * makefile.w32-in: Update dependencies.
14017 2011-03-17 Eli Zaretskii <eliz@gnu.org>
14019 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14021 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14023 Fix more problems found by GCC 4.5.2's static checks.
14025 * process.c (make_serial_process_unwind, send_process_trap):
14026 (sigchld_handler): Now static.
14028 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14029 That way, the code declares only the vars that it needs.
14030 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14031 * s/cygwin.h (PTY_ITERATION): Likewise.
14032 * s/darwin.h (PTY_ITERATION): Likewise.
14033 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14035 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14036 * process.c (allocate_pty): Don't declare stb unless it's needed.
14038 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
14039 (CONSTANTLIM): Remove; unused.
14040 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14041 Define only if needed.
14043 * unexelf.c (unexec): Name an expression,
14044 to avoid gcc -Wbad-function-cast warning.
14045 Use a different way to cause a compilation error if anyone uses
14046 n rather than nn, a way that does not involve shadowing.
14047 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
14049 * deps.mk (unexalpha.o): Remove; unused.
14051 New file unexec.h, the (simple) interface for unexec (Bug#8267).
14052 * unexec.h: New file.
14053 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14054 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14055 Depend on unexec.h.
14056 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14057 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14058 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
14059 Change as necessary to match prototype in unexec.h.
14061 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14063 (back_comment, skip_chars): Mark vars as initialized.
14065 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14066 Rename locals to avoid shadowing.
14068 * lread.c (read1): Rewrite so as not to use empty "else".
14069 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
14071 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14073 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14074 warning when compiling print.c.
14076 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14077 instead of using an uninitialized var.
14078 (font_sort_entities): Mark var as initialized.
14080 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14082 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14083 pointers to constants.
14084 (font_parse_fcname): Remove unused vars.
14085 (font_delete_unmatched): Now static.
14086 (font_get_spec): Remove; unused.
14087 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14088 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14089 Rename or move locals to avoid shadowing.
14091 * fns.c (require_nesting_list, require_unwind): Now static.
14092 (Ffillarray): Rename locals to avoid shadowing.
14094 * floatfns.c (domain_error2): Define only if needed.
14095 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
14097 * alloc.c (mark_backtrace): Move decl from here ...
14098 * lisp.h: ... to here, so that it can be checked.
14100 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
14101 (Fdefvar): Rewrite so as not to use empty "else".
14102 (lisp_indirect_variable): Name an expression,
14103 to avoid gcc -Wbad-function-cast warning.
14104 (Fdefvar): Rename locals to avoid shadowing.
14106 * callint.c (quotify_arg, quotify_args): Now static.
14107 (Fcall_interactively): Rename locals to avoid shadowing.
14108 Use const pointer when appropriate.
14110 * lisp.h (get_system_name, get_operating_system_release):
14111 Move decls here, to check interfaces.
14112 * process.c (get_operating_system_release): Move decl to lisp.h.
14113 * xrdb.c (get_system_name): Likewise.
14114 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14115 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14116 some of which prompt warnings from gcc -Wbad-function-cast.
14117 (Fformat_time_string, Fencode_time, Finsert_char):
14118 (Ftranslate_region_internal, Fformat):
14119 Rename or remove local vars to avoid shadowing.
14120 (Ftranslate_region_internal): Mark var as initialized.
14122 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14125 * lisp.h (eassert): Check that the argument compiles, even if
14126 ENABLE_CHECKING is not defined.
14128 * data.c (Findirect_variable): Name an expression, to avoid
14129 gcc -Wbad-function-cast warning.
14130 (default_value, arithcompare, arith_driver, arith_error): Now static.
14131 (store_symval_forwarding): Rename local to avoid shadowing.
14132 (Fmake_variable_buffer_local, Fmake_local_variable):
14133 Mark variables as initialized.
14134 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
14136 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
14137 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14138 Rename locals to avoid shadowing.
14139 (mark_stack): Move local variables into the #ifdef region where
14141 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14142 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14144 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14145 (GC_STRING_CHARS): Remove; not used.
14146 (Fmemory_limit): Cast sbrk's returned value to char *.
14148 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14149 avoids undefined behavior in theory.
14151 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14153 Use functions, not macros, for up- and down-casing (Bug#8254).
14154 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14155 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14156 to use the following functions instead of these macros.
14157 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14158 EMACS_INT, since callers assume the returned value fits in int.
14159 (upcase1): Likewise, for UPCASE_TABLE.
14160 (uppercasep, lowercasep, upcase): New static inline functions.
14161 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
14162 the race-condition problem in the old DOWNCASE.
14164 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14165 Rename locals to avoid shadowing.
14166 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
14167 (regex_compile, re_search_2, re_match_2_internal):
14168 Remove unused local vars.
14169 (FREE_VAR): Rewrite so as not to use empty "else",
14170 which gcc can warn about.
14171 (regex_compile, re_match_2_internal): Mark locals as initialized.
14172 (RETALLOC_IF): Define only if needed.
14173 (WORDCHAR_P): Likewise. This one is never needed, but is used
14174 only in a comment talking about a compiler bug, so put inside
14175 the #if 0 of that comment.
14176 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14177 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14180 * search.c (boyer_moore): Rename locals to avoid shadowing.
14181 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14182 (PREV_CHAR_BOUNDARY): Likewise.
14184 * search.c (simple_search): Remove unused var.
14186 * dired.c (compile_pattern): Move decl from here ...
14187 * lisp.h: ... to here, so that it can be checked.
14188 (struct re_registers): New forward decl.
14190 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14192 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14194 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14195 Rename locals to avoid shadowing.
14196 (Fvertical_motion): Mark locals as initialized.
14198 * casefiddle.c (casify_object, casify_region): Now static.
14199 (casify_region): Mark local as initialized.
14201 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14203 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14204 New macros, so that the caller can use some names other than
14205 gcpro1, gcpro2, etc.
14206 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14208 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14209 argument, for consistency with GCPRO2_VAR, etc: it is now the
14210 prefix of the variable, not the variable itself. All uses
14212 * dired.c (directory_files_internal, file_name_completion):
14213 Rename locals to avoid shadowing.
14215 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14216 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14217 dired.c's scmp function, had undefined behavior.
14218 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14219 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14220 * buffer.h: ... to here, because these macros use current_buffer,
14221 and the new implementation with inline functions needs to have
14222 current_buffer in scope now, rather than later when the macros
14224 (downcase, upcase1): New static inline functions.
14225 (DOWNCASE, UPCASE1): Reimplement using these functions.
14226 This avoids undefined behavior in expressions like
14227 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14228 from race conditions in accessing the global variables
14229 case_temp1 and case_temp2.
14230 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14231 * lisp.h (case_temp1, case_temp2): Remove their decls.
14232 * character.h (ASCII_CHAR_P): Move from here ...
14233 * lisp.h: ... to here, so that the inline functions mentioned
14234 above can use them.
14236 * dired.c (directory_files_internal_unwind): Now static.
14238 * fileio.c (file_name_as_directory, directory_file_name):
14239 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14241 (file_name_as_directory): Use const pointers when appropriate.
14242 (Fexpand_file_name): Likewise. In particular, newdir might
14243 point at constant storage, so make it a const pointer.
14244 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
14245 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14247 (Fset_file_times, Finsert_file_contents, auto_save_error):
14248 Rename locals to avoid shadowing.
14250 * minibuf.c (choose_minibuf_frame_1): Now static.
14251 (Ftry_completion, Fall_completions): Rename or remove locals
14252 to avoid shadowing.
14254 * marker.c (bytepos_to_charpos): Remove; unused.
14256 * lisp.h (verify_bytepos, count_markers): New decls,
14257 so that gcc does not warn that these functions aren't declared.
14259 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14260 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
14261 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
14262 (copy_text): Remove unused local var.
14264 * filelock.c (within_one_second): Now static.
14265 (lock_file_1): Rename local to avoid shadowing.
14267 * buffer.c (fix_overlays_before): Mark locals as initialized.
14268 (fix_start_end_in_overlays): Likewise. This function should be
14269 simplified by using pointers-to-pointers, but that's a different
14271 (switch_to_buffer_1): Now static.
14272 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14273 (report_overlay_modification): Rename locals to avoid shadowing.
14275 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
14276 Fix pointer signedness issue.
14277 (sys_subshell): Mark local as volatile if checking for lint,
14278 to suppress a gcc -Wclobbered warning that does not seem to be right.
14279 (MAXPATHLEN): Define only if needed.
14281 * process.c (serial_open, serial_configure): Move decls from here ...
14282 * systty.h: ... to here, so that they can be checked.
14284 * fns.c (get_random, seed_random): Move extern decls from here ...
14285 * lisp.h: ... to here, so that they can be checked.
14287 * sysdep.c (reset_io): Now static.
14288 (wait_for_termination_signal): Remove; unused.
14290 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14291 (copy_keymap_item, append_key, push_text_char_description):
14293 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
14294 (DENSE_TABLE_SIZE): Remove; unused.
14295 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14296 (describe_map_tree):
14297 Rename locals to avoid shadowing.
14299 * keyboard.c: Declare functions static if they are not used elsewhere.
14300 (echo_char, echo_dash, cmd_error, top_level_2):
14301 (poll_for_input, handle_async_input): Now static.
14302 (read_char, kbd_buffer_get_event, make_lispy_position):
14303 (make_lispy_event, make_lispy_movement, apply_modifiers):
14304 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14305 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14306 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
14307 (read_key_sequence, read_char): Mark locals as initialized.
14308 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
14310 * keyboard.h (make_ctrl_char): New decl.
14311 (mark_kboards): Move decl here ...
14312 * alloc.c (mark_kboards): ... from here.
14314 * lisp.h (force_auto_save_soon): New decl.
14316 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14317 (DEFINE_DUMMY_FUNCTION): New macro.
14318 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14320 (main): Add casts to avoid warnings
14321 if GCC considers string literals to be constants.
14323 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14325 * dbusbind.c: Pointer signedness fixes.
14326 (xd_signature, xd_append_arg, xd_initialize):
14327 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14328 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14329 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14330 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14332 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14333 if GCC considers string literals to be constants.
14334 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14336 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14338 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14339 (print_preprocess, print_object): New macro to fix last change.
14341 * print.c (print_preprocess): Don't forget font objects.
14343 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14345 * emacs.c (USAGE3): Doc fixes.
14347 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14349 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14352 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14354 * lisp.h (VWindow_system, Qfile_name_history):
14355 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14356 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14357 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14359 * w32select.c: Don't #include "keyboard.h".
14360 (run_protected): Add extern declaration for waiting_for_input.
14362 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14363 * w32console.c (detect_input_pending, read_input_pending)
14364 (encode_terminal_code):
14365 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14366 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14367 (w32_system_caret_y, Qfile_name_history):
14368 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14369 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14370 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14371 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14372 * w32proc.c (Qlocal, report_file_error):
14373 * w32term.c (Vwindow_system, updating_frame):
14374 * w32uniscribe.c (initialized, uniscribe_font_driver):
14375 Remove unneeded extern declarations.
14377 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14379 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14381 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14383 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14384 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14385 These macros can no longer be used for assignment.
14387 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14388 Assign struct members directly, instead of using BUF_BEGV etc.
14389 (record_buffer_markers, fetch_buffer_markers): New functions for
14390 recording and fetching special buffer markers.
14391 (set_buffer_internal_1, set_buffer_temp): Use them.
14393 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14395 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14397 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14398 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14400 * xdisp.c (hscroll_window_tree):
14401 (reconsider_clip_changes): Use PT instead of BUF_PT.
14403 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14405 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14406 $(EMACS_ROOT)/lib/intprops.h.
14408 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14410 Fix more problems found by GCC 4.5.2's static checks.
14412 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14413 to unsigned char * to avoid compiler diagnostic.
14414 (xg_free_frame_widgets): Make it clear that a local variable is
14415 needed only if USE_GTK_TOOLTIP.
14416 (gdk_window_get_screen): Make it clear that this macro is needed
14417 only if USE_GTK_TOOLTIP.
14418 (int_gtk_range_get_value): New function, which avoids a diagnostic
14419 from gcc -Wbad-function-cast.
14420 (xg_set_toolkit_scroll_bar_thumb): Use it.
14421 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14422 diagnostic from gcc -Wbad-function-cast.
14423 (get_utf8_string, xg_get_file_with_chooser):
14424 Rename locals to avoid shadowing.
14425 (create_dialog): Move locals to avoid shadowing.
14427 * xgselect.c (xg_select): Remove unused var.
14429 * image.c (four_corners_best): Mark locals as initialized.
14430 (gif_load): Initialize transparent_p to zero (Bug#8238).
14431 Mark another local as initialized.
14432 (my_png_error, my_error_exit): Mark with NO_RETURN.
14434 * image.c (clear_image_cache): Now static.
14435 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14436 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14437 (x_edge_detection): Remove unnecessary cast that
14438 gcc -Wbad-function-cast diagnoses.
14439 (gif_load): Fix pointer signedness.
14440 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14441 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14443 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14445 Improve quality of tests for time stamp overflow.
14446 For example, without this patch (encode-time 0 0 0 1 1
14447 1152921504606846976) returns the obviously-bogus value (-948597
14448 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14449 reports time overflow. See
14450 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14451 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14452 * editfns.c: Include limits.h and intprops.h.
14453 (TIME_T_MIN, TIME_T_MAX): New macros.
14454 (time_overflow): Move earlier, to before first use.
14455 (hi_time, lo_time): New functions, for an accurate test for
14456 out-of-range times.
14457 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14458 (Fget_internal_run_time): Don't assume time_t fits in int.
14459 (make_time): Use list2 instead of Fcons twice.
14460 (Fdecode_time): More accurate test for out-of-range times.
14461 (check_tm_member): New function.
14462 (Fencode_time): Use it, to test for out-of-range times.
14463 (lisp_time_argument): Don't rely on undefined left-shift and
14464 right-shift behavior when checking for time stamp overflow.
14466 * editfns.c (time_overflow): New function, refactoring common code.
14467 (Fformat_time_string, Fdecode_time, Fencode_time):
14468 (Fcurrent_time_string): Use it.
14470 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14471 * dired.c (make_time): Move to ...
14472 * editfns.c (make_time): ... here.
14473 * systime.h: Note the move.
14475 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14477 * fringe.c (update_window_fringes): Remove unused variables.
14479 * unexmacosx.c (copy_data_segment): Also copy __got section.
14482 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14484 * termcap.c [MSDOS]: Include "msdos.h".
14485 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14486 Constify `char *' arguments and their references according to
14487 prototypes in tparam.h.
14489 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14491 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14492 Adapt all references accordingly.
14494 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14496 2011-03-11 Tom Tromey <tromey@redhat.com>
14498 * buffer.c (syms_of_buffer): Remove obsolete comment.
14500 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14502 * termhooks.h (encode_terminal_code): Declare prototype.
14504 * msdos.c (encode_terminal_code): Don't declare prototype.
14506 * term.c (encode_terminal_code): Now external again, used by
14507 w32console.c and msdos.c.
14509 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14510 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14512 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14514 Fix some minor problems found by GCC 4.5.2's static checks.
14516 * fringe.c (update_window_fringes): Mark locals as initialized
14518 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14520 * alloc.c (mark_fringe_data): Move decl from here ...
14521 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14522 to check its interface.
14523 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14525 * fontset.c (free_realized_fontset): Now static.
14526 (Fset_fontset_font): Rename local to avoid shadowing.
14527 (fontset_font): Mark local as initialized.
14528 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14530 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14532 * xselect.c (x_disown_buffer_selections): Remove; not used.
14533 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14534 (x_own_selection, Fx_disown_selection_internal): Rename locals
14535 to avoid shadowing.
14536 (x_handle_dnd_message): Remove local to avoid shadowing.
14538 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14539 so that the caller can use some name other than gcpro1.
14540 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14541 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14542 (Fx_backspace_delete_keys_p):
14543 Use them to avoid shadowing, and rename vars to avoid shadowing.
14544 (x_decode_color, x_set_name, x_window): Now static.
14545 (Fx_create_frame): Add braces to silence GCC warning.
14546 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14547 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14548 Remove unused locals.
14549 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14550 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14551 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14554 * xterm.h (x_mouse_leave): New decl.
14556 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14557 Remove unused functions.
14558 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14559 (x_calc_absolute_position): Now static.
14560 (XTread_socket): Don't define label "out" unless it's used.
14561 Don't declare local "event" unless it's used.
14562 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14563 unless they are used.
14564 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14565 (x_fatal_error_signal): Remove; not used.
14566 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14567 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14568 (x_error_catcher, x_connection_closed, x_error_handler):
14569 (x_error_quitter, xembed_send_message, x_iconify_frame):
14570 (my_log_handler): Rename locals to avoid shadowing.
14571 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14572 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14574 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14575 Rename or move locals to avoid shadowing.
14576 (tty_defined_color, merge_face_heights): Now static.
14577 (free_realized_faces_for_fontset): Remove; not used.
14578 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14579 does not deduce is never used uninitialized.
14580 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14581 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14583 * terminal.c (store_terminal_param): Now static.
14585 * xmenu.c (menu_highlight_callback): Now static.
14586 (set_frame_menubar): Remove unused local.
14587 (xmenu_show): Rename parameter to avoid shadowing.
14588 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14589 since they might point to immutable storage.
14590 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14591 since it's unused otherwise.
14593 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14594 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14595 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14596 avoids a gcc -Wuninitialized diagnostic.
14597 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14598 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14599 does not deduce are never used uninitialized.
14601 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14603 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14604 * window.c (window_loop, size_window):
14605 (run_window_configuration_change_hook, enlarge_window): Likewise.
14607 * window.c (display_buffer): Now static.
14608 (size_window): Mark variables that gcc -Wuninitialized
14609 does not deduce are never used uninitialized.
14610 * window.h (check_all_windows): New decl, to forestall
14611 gcc -Wmissing-prototypes diagnostic.
14612 * dispextern.h (bidi_dump_cached_states): Likewise.
14614 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14616 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14617 Include <limits.h>.
14618 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14619 and to avoid gcc -Wuninitialized warning.
14620 (load_charset_map): Mark variables that gcc -Wuninitialized
14621 does not deduce are never used uninitialized.
14622 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14624 * coding.c (coding_set_source, coding_set_destination):
14625 Use "else { /* comment */ }" rather than "else /* comment */;"
14626 for clarity, and to avoid gcc -Wempty-body warning.
14627 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14628 a block, when the outer 'i' will do.
14629 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14630 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14631 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14632 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14633 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14634 Rename locals to avoid shadowing.
14635 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14636 * coding.c (emacs_mule_char, encode_invocation_designation):
14637 Now static, since they're not used elsewhere.
14638 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14639 (decode_coding_object, encode_coding_object, detect_coding_system):
14640 (decode_coding_emacs_mule): Mark variables that gcc
14641 -Wuninitialized does not deduce are never used uninitialized.
14642 (detect_coding_iso_2022): Initialize a local variable that might
14643 be used uninitialized. Leave a FIXME because it's not clear that
14644 this initialization is needed. (Bug#8211)
14645 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14646 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14647 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14648 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14649 Remove unused macros.
14651 * category.c (hash_get_category_set): Remove unused local var.
14652 (copy_category_table): Now static, since it's not used elsewhere.
14653 * character.c (string_count_byte8): Likewise.
14655 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14656 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14658 * chartab.c (copy_sub_char_table): Now static, since it's not used
14660 (sub_char_table_ref_and_range, char_table_ref_and_range):
14661 Rename locals to avoid shadowing.
14662 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14664 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14665 (BIDI_BOB): Remove unused macro.
14667 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14668 deduce are never used uninitialized.
14669 * term.c (encode_terminal_code): Likewise.
14671 * term.c (encode_terminal_code): Now static. Remove unused local.
14673 * tparam.h: New file.
14674 * term.c, tparam.h: Include it.
14675 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14676 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14677 Move these decls to tparam.h, and make them agree with what
14678 is actually in tparam.c. The previous trick of using incompatible
14679 decls in different modules does not conform to the C standard.
14680 All callers of tparam changed to use tparam's actual API.
14681 * tparam.c (tparam1, tparam, tgoto):
14682 Use const pointers where appropriate.
14684 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14685 * cm.h (struct cm): Likewise.
14686 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14687 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14688 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14689 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14690 (turn_on_face, init_tty): Likewise.
14691 * termchar.h (struct tty_display_info): Likewise.
14693 * term.c (term_mouse_position): Rename local to avoid shadowing.
14695 * alloc.c (mark_ttys): Move decl from here ...
14696 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14698 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14700 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14702 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14704 * search.c (compile_pattern_1): Remove argument regp, unused since
14705 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14706 (compile_pattern): Don't pass it.
14708 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14710 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14711 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14713 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14715 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14717 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14718 gdk_window_get_screen, gdk_window_get_geometry,
14719 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14720 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14721 (xg_get_pixbuf_from_pixmap): New function.
14722 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14723 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14724 Call xg_get_pixbuf_from_pixmap instead of
14725 gdk_pixbuf_get_from_drawable.
14726 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14727 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14728 (xg_check_special_colors): Use GtkStyleContext and its functions
14730 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14731 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14732 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14733 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14734 Call gtk_widget_get_preferred_size.
14735 (xg_frame_resized): gdk_window_get_geometry only takes 5
14737 (xg_win_to_widget, xg_event_is_for_menubar):
14738 Call gdk_x11_window_lookup_for_display.
14739 (xg_set_widget_bg): New function.
14740 (delete_cb): New function.
14741 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14742 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14743 (xg_set_background_color): Call xg_set_widget_bg.
14744 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14745 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14746 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14747 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14749 (update_frame_tool_bar): Call gtk_widget_hide.
14750 (xg_initialize): Use GDK_KEY_g.
14752 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14754 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14756 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14757 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14758 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14760 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14762 * w32xfns.c (select_palette): Check success of RealizePalette against
14763 GDI_ERROR, not zero.
14765 See ChangeLog.11 for earlier changes.
14767 ;; Local Variables:
14771 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14773 This file is part of GNU Emacs.
14775 GNU Emacs is free software: you can redistribute it and/or modify
14776 it under the terms of the GNU General Public License as published by
14777 the Free Software Foundation, either version 3 of the License, or
14778 (at your option) any later version.
14780 GNU Emacs is distributed in the hope that it will be useful,
14781 but WITHOUT ANY WARRANTY; without even the implied warranty of
14782 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14783 GNU General Public License for more details.
14785 You should have received a copy of the GNU General Public License
14786 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
HCoop / bpt / emacs.git / blob