1 2012-03-19 Kenichi Handa <handa@m17n.org>
3 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4 it fit in a valid range (Bug#11003).
6 2012-03-12 Chong Yidong <cyd@gnu.org>
8 * eval.c (inhibit_lisp_code): Rename from
9 inhibit_window_configuration_change_hook; move from window.c.
11 * xfns.c (unwind_create_frame_1, Fx_create_frame):
12 * window.c (run_window_configuration_change_hook)
13 (syms_of_window): Callers changed.
15 2012-03-11 Chong Yidong <cyd@gnu.org>
17 * keymap.c (Fkey_description): Doc fix (Bug#9700).
19 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
21 2012-03-10 Chong Yidong <cyd@gnu.org>
23 * frame.c (other_visible_frames): Don't assume the selected frame
24 is visible (Bug#10955).
26 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
28 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
30 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
32 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
33 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
36 2012-03-03 Glenn Morris <rgm@gnu.org>
38 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
40 2012-03-02 Eli Zaretskii <eliz@gnu.org>
42 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
43 position past the first glyph_row that ends at ZV. (Bug#10902)
44 (redisplay_window, next_element_from_string): Fix typos in
46 (redisplay_window): Pass to move_it_vertically the margin in
47 pixels, not in screen lines.
49 2012-03-02 Glenn Morris <rgm@gnu.org>
51 * buffer.c (buffer-list-update-hook): Doc fix.
53 2012-02-29 Eli Zaretskii <eliz@gnu.org>
55 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
56 push_it before setting up the iterator for the first overlay
57 string, even if we have an empty string loaded.
58 (next_overlay_string): If there's an empty string on the iterator
59 stack, pop the stack. (Bug#10903)
61 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
63 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
64 Suggested by Stefan Monnier in
65 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
66 * alloc.c (widen_to_Lisp_Object): New static function.
67 (mark_memory): Also mark Lisp_Objects by fetching pointer words
68 and widening them to Lisp_Objects. This would work even if
69 USE_LSB_TAG is defined and wide integers are used, which might
70 happen in a future version of Emacs.
72 2012-02-25 Chong Yidong <cyd@gnu.org>
74 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
77 * xselect.c (Fx_selection_exists_p): Doc fix.
78 (x_clipboard_manager_save_all): Print an informative message
79 before saving to clipboard manager.
81 2012-02-24 Chong Yidong <cyd@gnu.org>
83 * keyboard.c (process_special_events): Handle all X selection
84 requests in kbd_buffer, not just the next one (Bug#8869).
86 2012-02-23 Chong Yidong <cyd@gnu.org>
88 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
89 call when setting menu-bar-lines and tool-bar-lines parameters.
90 (unwind_create_frame_1): New helper function.
92 * window.c (inhibit_window_configuration_change_hook): New var.
93 (run_window_configuration_change_hook): Obey it.
94 (syms_of_window): Initialize it.
96 2012-02-22 Chong Yidong <cyd@gnu.org>
98 * xterm.c (x_draw_image_relief): Add missing type check for
99 Vtool_bar_button_margin (Bug#10743).
101 2012-02-21 Chong Yidong <cyd@gnu.org>
103 * fileio.c (Vfile_name_handler_alist): Doc fix.
105 * buffer.c (Fget_file_buffer): Protect against invalid file
106 handler return value.
108 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
110 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
111 when computing $valmask.
113 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
114 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
115 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
116 It's useless in that case, and it can cause problems on hosts
117 that allocate halves of EMACS_INT values separately.
118 Reported by Dan Horák. Diagnosed by Andreas Schwab in
119 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
120 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
121 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
122 it avoids undefined behavior on hosts where shifting right by more
123 than the word width has undefined behavior.
125 2012-02-19 Chong Yidong <cyd@gnu.org>
127 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
128 (Funhandled_file_name_directory, Ffile_name_as_directory)
129 (Fdirectory_file_name, Fexpand_file_name)
130 (Fsubstitute_in_file_name): Protect against invalid file handler
131 return values (Bug#10845).
133 2012-02-18 Eli Zaretskii <eliz@gnu.org>
135 * .gdbinit (pitx): Fix incorrect references to fields of the
138 2012-02-17 Chong Yidong <cyd@gnu.org>
140 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
142 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
144 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
145 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
147 2012-02-15 Chong Yidong <cyd@gnu.org>
149 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
150 marked as special. Also, starting docstrings with * is obsolete.
152 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
154 * gnutls.c (emacs_gnutls_write): Fix last change.
156 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
158 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
161 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
163 * keymap.c (Fsingle_key_description): Handle char ranges.
165 2012-02-12 Chong Yidong <cyd@gnu.org>
167 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
168 as that creates a dangerous corner case.
170 * window.c (Fdelete_window_internal): Invalidate the mouse
171 highlight (Bug#9904).
173 2012-02-12 Glenn Morris <rgm@gnu.org>
175 * xselect.c (Fx_own_selection_internal)
176 (Fx_get_selection_internal, Fx_disown_selection_internal)
177 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
178 * nsselect.m (Fx_own_selection_internal)
179 (Fx_disown_selection_internal, Fx_selection_exists_p)
180 (Fx_selection_owner_p, Fx_get_selection_internal):
181 Sync docs and argument specs with the xselect.c versions.
183 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
185 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
187 2012-02-11 Eli Zaretskii <eliz@gnu.org>
189 * w32select.c (Fx_selection_exists_p): Sync doc string and
190 argument list with xselect.c. (Bug#10783)
192 * w16select.c (Fx_selection_exists_p): Sync doc string and
193 argument list with xselect.c. (Bug#10783)
195 2012-02-10 Glenn Morris <rgm@gnu.org>
197 * fns.c (Fsecure_hash): Doc fix.
199 2012-02-09 Kenichi Handa <handa@m17n.org>
201 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
203 2012-02-07 Chong Yidong <cyd@gnu.org>
205 * buffer.c (Fbuffer_local_variables)
206 (buffer_lisp_local_variables): Handle unbound vars correctly;
207 don't let Qunbound leak into Lisp.
209 2012-02-07 Glenn Morris <rgm@gnu.org>
211 * image.c (Fimagemagick_types): Doc fix.
213 * image.c (imagemagick-render-type): Change it from a lisp object
214 to an integer. Move the doc here from the lisp manual.
215 Treat all values not equal to 0 the same.
217 2012-02-06 Chong Yidong <cyd@gnu.org>
219 * doc.c (store_function_docstring): Avoid applying docstring of
220 alias to base function (Bug#2603).
222 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
224 * .gdbinit (pp1, pv1): Remove redundant defines.
227 2012-02-04 Chong Yidong <cyd@gnu.org>
229 * nsterm.m: Declare a global (Bug#10694).
231 2012-02-04 Eli Zaretskii <eliz@gnu.org>
233 * w32.c (get_emacs_configuration_options):
234 Include --enable-checking, if specified, in the return value.
236 2012-02-04 Martin Rudalics <rudalics@gmx.at>
238 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
239 after rounding frame sizes. (Bug#9723)
241 2012-02-04 Eli Zaretskii <eliz@gnu.org>
243 * keyboard.c (adjust_point_for_property): Don't position point
244 before BEGV. (Bug#10696)
246 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
248 Handle overflow when computing char display width (Bug#9496).
249 * character.c (char_width): Return EMACS_INT, not int.
250 (char_width, c_string_width): Check for overflow when
251 computing the width; this is possible now that individual
252 characters can have unbounded width. Problem introduced
253 by merge from Emacs 23 on 2012-01-19.
255 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
257 * dbusbind.c (Fdbus_register_method): Mention the return value
258 :ignore in the docstring.
260 2012-02-02 Glenn Morris <rgm@gnu.org>
262 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
264 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
265 Unconditionally set to t. (Bug#10673)
266 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
267 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
268 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
270 2012-02-02 Kenichi Handa <handa@m17n.org>
272 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
273 0, do not call append_composite_glyph.
275 2012-02-02 Kenichi Handa <handa@m17n.org>
277 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
279 (x_produce_glyphs): If the component of a composition is a null
280 string, set it->pixel_width to 1 to avoid zero-width glyph.
282 2012-02-01 Eli Zaretskii <eliz@gnu.org>
284 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
285 first 2 arguments are identical. This makes inserting large
286 output from a subprocess an order of magnitude faster on
287 MS-Windows, where all sbrk'ed memory is always contiguous.
289 2012-01-31 Glenn Morris <rgm@gnu.org>
291 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
292 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
293 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
295 2012-01-29 Glenn Morris <rgm@gnu.org>
297 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
299 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
301 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
303 2012-01-28 Chong Yidong <cyd@gnu.org>
305 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
307 2012-01-26 Chong Yidong <cyd@gnu.org>
309 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
311 * search.c (Fsearch_forward, Fsearch_backward): Document negative
312 repeat counts (Bug#10507).
314 2012-01-26 Glenn Morris <rgm@gnu.org>
316 * lread.c (syms_of_lread): Doc fix.
318 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
320 * coding.c (encode_designation_at_bol): Change return value to
323 2012-01-25 Chong Yidong <cyd@gnu.org>
325 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
327 2012-01-21 Chong Yidong <cyd@gnu.org>
329 * floatfns.c (Fcopysign): Make the second argument non-optional,
330 since nil is not allowed anyway.
332 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
334 * process.c (read_process_output): Use p instead of XPROCESS (proc).
335 (send_process): Likewise.
337 2012-01-19 Martin Rudalics <rudalics@gmx.at>
339 * window.c (save_window_save, Fcurrent_window_configuration)
340 (Vwindow_persistent_parameters): Do not use Qstate.
343 2012-01-19 Kenichi Handa <handa@m17n.org>
345 * character.c (char_width): New function.
346 (Fchar_width, c_string_width, lisp_string_width):
347 Use char_width (Bug#9496).
349 2012-01-16 Martin Rudalics <rudalics@gmx.at>
351 * window.c (Vwindow_persistent_parameters): New variable.
352 (Fset_window_configuration, save_window_save): Handle persistent
355 2012-01-14 Eli Zaretskii <eliz@gnu.org>
357 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
358 thrashing the stack of the thread. (Bug#9087)
360 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
362 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
364 2012-01-11 Eli Zaretskii <eliz@gnu.org>
366 * xdisp.c (rows_from_pos_range): Handle the case where the
367 highlight ends on a newline. (Bug#10464)
368 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
369 he end column for display of highlight that ends on a newline
372 2012-01-11 Glenn Morris <rgm@gnu.org>
374 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
375 from load-path also when installation-directory is nil. (Bug#10208)
377 2012-01-10 Glenn Morris <rgm@gnu.org>
379 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
381 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
382 Update template values to be closer to their typical values these days.
384 2012-01-09 Eli Zaretskii <eliz@gnu.org>
386 * xdisp.c (rows_from_pos_range): Accept additional argument
387 DISP_STRING, and accept any glyph in a row whose object is that
388 string as eligible for mouse highlight. Fixes mouse highlight of
389 display strings from overlays. (Bug#10464)
391 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
393 emacs: fix an auto-save permissions race condition (Bug#10400)
394 * fileio.c (auto_saving_dir_umask): New static var.
395 (Fmake_directory_internal): Use it.
396 (do_auto_save_make_dir): Set it, instead of invoking chmod after
397 creating the directory. The old code temporarily assigns
398 too-generous permissions to the directory.
399 (do_auto_save_eh): Clear it.
400 (Fdo_auto_save): Catch all errors, not just file errors, so
401 that the var is always cleared.
403 2012-01-07 Eli Zaretskii <eliz@gnu.org>
405 * search.c (scan_buffer): Pass character positions to
406 know_region_cache, not byte positions. (Bug#6540)
408 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
410 * w32.c (sys_rename): Report EXDEV when rename of a directory
411 fails because the target is on another logical disk. (Bug#10284)
413 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
415 * xterm.c (x_embed_request_focus): New function.
417 * xterm.h: Add prototype.
419 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
421 2012-01-05 Glenn Morris <rgm@gnu.org>
423 * emacs.c (emacs_copyright): Update short copyright year to 2012.
425 2012-01-01 Eli Zaretskii <eliz@gnu.org>
427 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
428 Load gnutls_transport_set_lowat only if GnuTLS version is below
430 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
431 GnuTLS versions below 2.11.1.
433 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
435 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
436 to the doc string advising against its use for altering the way
437 windows are scrolled.
439 2011-12-28 Kenichi Handa <handa@m17n.org>
441 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
442 coding-system ASCII compatible only when it does not produce BOM
443 on encoding (Bug#10383).
445 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
447 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
449 (create_and_show_popup_menu): Always use menu_position_func for
452 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
454 * callint.c (Fcall_interactively): Don't truncate prompt string.
456 2011-12-23 Eli Zaretskii <eliz@gnu.org>
458 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
459 property that ends at ZV, so that the bidi iteration could be
460 resumed from there (after widening). (Bug#10360)
462 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
464 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
466 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
468 * nsterm.m (x_free_frame_resources):
469 Release f->output_data.ns->miniimage.
470 (ns_index_color): Fix indentation. Do not retain
471 color_table->colors[i].
473 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
476 * nsfns.m (x_set_background_color): Assign return value from
477 ns_index_color to face-background instead of NSColor*.
478 (ns_implicitly_set_icon_type): Fix indentation.
479 Change assignment in for loop to comparison.
481 * emacs.c (ns_pool): New variable.
482 (main): Assign ns_pool.
483 (Fkill_emacs): Call ns_release_autorelease_pool.
485 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
486 autorelease fdesc, release fdAttrs and tdict.
487 (ns_get_covering_families): Release charset.
488 (ns_findfonts): Release NSFontDescriptor created with new.
489 (ns_uni_to_glyphs): Fix indentation.
490 (setString): Release attrStr before assigning new value.
492 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
494 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
496 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
497 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
499 2011-12-18 David Reitter <reitter@cmu.edu>
501 * nsterm.m (ns_term_init): Subscribe for notifications
502 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
503 to method trackingNotification in EmacsMenu.
505 * nsmenu.m (trackingMenu): New variable.
506 (trackingNotification): New method (from Aquamacs).
507 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
508 from Aquamacs (Bug#7030).
510 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
512 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
513 (symbol_to_nsstring): Fix indentation.
514 (ns_symbol_to_pb): New function.
515 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
516 (Fns_rotate_cut_buffers_internal): Remove.
517 (Fns_store_selection_internal): Rename from
518 Fns_store_cut_buffer_internal.
519 (ns_get_foreign_selection, Fx_own_selection_internal)
520 (Fx_disown_selection_internal, Fx_selection_exists_p)
521 (Fns_get_selection_internal, Fns_store_selection_internal):
522 Use ns_symbol_to_pb and check if return value is nil.
523 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
524 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
525 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
526 renamed to Sns_store_selection_internal.
527 (ns_handle_selection_request): Move code to Fx_own_selection_internal
528 and remove this function.
529 (ns_handle_selection_clear): Remove, never used.
530 (Fx_own_selection_internal): Move code from ns_handle_selection_request
533 2011-12-17 Ken Brown <kbrown@cornell.edu>
535 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
536 GID is unknown (Bug#10257).
538 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
540 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
541 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
542 which caused a build failure on GNU/Linux IA-64. This problem was
543 introduced by my 2011-10-07 patch.
545 2011-12-15 Juri Linkov <juri@jurta.org>
547 * image.c (imagemagick_error): New function. (Bug#10112)
548 (imagemagick_load_image): Comment out `MagickSetResolution' call.
549 Use `imagemagick_error' where ImageMagick functions return
551 (Fimagemagick_types): Add `Fnreverse' to return the list in the
554 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
556 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
557 fill background (Bug#8992).
559 2011-12-13 Martin Rudalics <rudalics@gmx.at>
561 * window.c (Vwindow_combination_resize)
562 (Vwindow_combination_limit): Use t instead of non-nil in
564 (Vrecenter_redisplay): Add first sentence of doc-string on
566 (Frecenter): Fix doc-string typo.
568 2011-12-11 Kenichi Handa <handa@m17n.org>
570 * coding.c (Funencodable_char_position): Pay attention to the
571 buffer text relocation (Bug#9389).
573 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
575 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
576 gtk_init (Bug#10100).
578 2011-12-10 Eli Zaretskii <eliz@gnu.org>
580 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
581 IT->string is nil. (Bug#10263)
583 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
585 * nsterm.h (x_free_frame_resources): Declare.
587 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
588 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
590 * nsterm.h (ns_get_defaults_value): Declare.
592 * nsterm.m (ns_default): Call ns_get_defaults_value.
594 2011-12-09 Eli Zaretskii <eliz@gnu.org>
596 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
599 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
601 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
602 that where the value of an _OBJC_* symbol points to is in the .bss
605 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
607 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
608 after the loop to call ccl_driver at least once (Bug#8619).
610 2011-12-08 Kenichi Handa <handa@m17n.org>
612 * ftfont.c (get_adstyle_property): Fix previous change
615 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
617 * w32.c (init_environment): If no_site_lisp, remove site-lisp
618 dirs from the default value of EMACSLOADPATH (bug#10208).
620 2011-12-07 Glenn Morris <rgm@gnu.org>
622 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
623 installation and source directories as well. (Bug#10208)
625 2011-12-06 Chong Yidong <cyd@gnu.org>
627 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
629 2011-12-06 Glenn Morris <rgm@gnu.org>
631 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
632 as an error, not just -1. (Bug#10217)
634 2011-12-05 Chong Yidong <cyd@gnu.org>
636 * keyboard.c (process_special_events): New function.
637 (swallow_events, Finput_pending_p): Use it (Bug#10195).
639 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
641 * coding.c (encode_designation_at_bol): Don't use uninitialized
642 local variable (Bug#9318).
644 2011-12-05 Kenichi Handa <handa@m17n.org>
646 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
647 return Qnil (Bug#8046, Bug#10193).
649 2011-12-05 Kenichi Handa <handa@m17n.org>
651 * coding.c (encode_designation_at_bol): New args charbuf_end and
652 dst. Return the number of produced bytes. Callers changed.
653 (coding_set_source): Return how many bytes coding->source was
655 (coding_set_destination): Return how many bytes
656 coding->destination was relocated.
657 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
658 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
660 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
662 * coding.c (CODING_CHAR_CHARSET_P): New macro.
663 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
666 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
668 The following changes are to fix Bug#9318.
670 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
671 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
672 (encode_coding_iso_2022, encode_coding_sjis)
673 (encode_coding_big5, encode_coding_charset): Use the above macros.
675 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
677 * lisp.h (process_quit_flag): Fix external declaration.
679 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
681 Don't macro-inline non-performance-critical code.
682 * eval.c (process_quit_flag): New function.
683 * lisp.h (QUIT): Use it.
685 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
687 * nsfns.m (get_geometry_from_preferences): New function.
688 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
690 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
692 * emacs.c (Qkill_emacs): Define.
693 (syms_of_emacs): Initialize it.
694 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
695 Qquit_flag to `kill-emacs' instead.
696 (quit_throw_to_read_char): Add parameter `from_signal'.
697 All callers changed. Call Fkill_emacs if requested and safe.
698 * lisp.h (QUIT): Call Fkill_emacs if requested.
700 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
702 * widget.c (update_wm_hints): Return if wmshell is null.
703 (widget_update_wm_size_hints): New function.
705 * widget.h (widget_update_wm_size_hints): Declare.
707 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
708 widget_update_wm_size_hints (Bug#10104).
710 2011-12-03 Eli Zaretskii <eliz@gnu.org>
712 * xdisp.c (handle_invisible_prop): If the invisible text ends just
713 before a newline, prepare the bidi iterator for consuming the
714 newline, and keep the current paragraph direction. (Bug#10183)
715 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
717 2011-12-02 Juri Linkov <juri@jurta.org>
719 * search.c (Fword_search_regexp): New Lisp function created from
720 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
721 (Fword_search_backward, Fword_search_forward)
722 (Fword_search_backward_lax, Fword_search_forward_lax):
723 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
724 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
726 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
728 * fileio.c (Finsert_file_contents): Move after-change-function call
729 to before the "handled:" label, since all "goto handled" appear in
730 cases where the *-change-functions have already been properly called
733 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
735 * keyboard.c (interrupt_signal): Don't call kill-emacs when
736 waiting for input. (Bug#10169)
738 2011-11-30 Eli Zaretskii <eliz@gnu.org>
740 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
741 verifies glyph row's hash code--we have just reallocated the
742 glyphs, so their contents can be complete garbage. (Bug#10164)
744 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
746 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
748 2011-11-30 Eli Zaretskii <eliz@gnu.org>
750 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
751 attributes are tested _before_ calling verify_row_hash, to protect
752 against GCC re-ordering of the tests. (Bug#10164)
754 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
756 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
758 * xterm.c (handle_one_xevent): Only set async_visible and friends
759 if net_wm_state_hidden_seen is non-zero (Bug#10002)
760 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
761 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
763 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
765 Remove GCPRO-related macros that exist only to avoid shadowing locals.
766 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
767 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
768 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
769 All uses changed to use GCPRO1 etc.
770 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
771 Revert to old implementation (i.e., before 2011-03-11).
773 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
775 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
776 of scroll runs so as to avoid assigning disabled bogus rows and
777 unnecessary graphics copy operations.
779 2011-11-27 Eli Zaretskii <eliz@gnu.org>
781 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
782 (snprintf) [_MSC_VER]: Redirect to _snprintf.
783 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
784 (malloc, free, realloc, calloc): Redirect to e_* only when
787 * lisp.h (GCTYPEBITS): Move before first use.
788 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
789 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
790 this macro definition.
792 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
795 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
797 * gtkutil.c (xg_create_frame_widgets):
798 Call gtk_window_set_has_resize_grip (FALSE) if that function is
799 present with Gtk+ 2.0.
801 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
803 * fileio.c (Finsert_file_contents): Undo previous change; see
804 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
806 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
808 Rename locals to avoid shadowing.
809 * fileio.c (Finsert_file_contents):
810 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
811 * process.c (wait_reading_process_output):
812 Rename inner 'proc' to 'p' to avoid shadowing.
813 Indent for consistency with usual Emacs style.
815 2011-11-25 Eli Zaretskii <eliz@gnu.org>
817 * xdisp.c (redisplay_window): If cursor row is not fully visible
818 after recentering, and scroll-conservatively is set to a large
819 number, scroll window by a few more lines to make the cursor fully
820 visible and out of scroll-margin. (Bug#10105)
821 (start_display): Don't move to the next line if the display should
822 start at a newline that is part of a display vector or an overlay
825 2011-11-24 Juri Linkov <juri@jurta.org>
827 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
828 after the `MagickPingImage' call. (Bug#10112)
830 2011-11-23 Chong Yidong <cyd@gnu.org>
832 * window.c (Fcoordinates_in_window_p): Accept only live windows.
834 2011-11-23 Martin Rudalics <rudalics@gmx.at>
836 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
837 making another buffer current. (Bug#10114)
839 2011-11-23 Glenn Morris <rgm@gnu.org>
841 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
843 2011-11-23 Chong Yidong <cyd@gnu.org>
845 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
848 2011-11-22 Eli Zaretskii <eliz@gnu.org>
850 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
851 and header-lines, as they don't have one computed for them.
854 * .gdbinit (prow): Make displayed values more self-explaining.
857 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
859 * process.c (wait_reading_process_output): Fix asynchrounous
860 GnuTLS socket handling on some versions of the GnuTLS library.
861 (wait_reading_process_output): Add comment and URL.
863 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
865 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
867 2011-11-21 Chong Yidong <cyd@gnu.org>
869 * window.c (Fnext_window, Fprevious_window): Doc fix.
871 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
873 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
875 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
877 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
879 2011-11-20 Martin Rudalics <rudalics@gmx.at>
881 * window.c (Fset_window_combination_limit): Rename argument
883 (Vwindow_combination_limit): Remove "status" from doc-string.
885 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
887 * m/ibms390.h: Remove.
888 * m/ibms390x.h: Don't include "ibms390.h".
890 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
892 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
893 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
895 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
897 * casetab.c (Fset_case_table):
898 * charset.c (Fcharset_after): Fix typos.
900 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
902 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
903 Otherwise, valgrind does not work on some platforms.
904 Problem reported by Andreas Schwab in
905 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
906 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
907 is set, removing the need for VIRT_ADDRESS_VARIES.
908 (PURE_P): Use a more-efficient implementation that needs just one
909 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
910 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
911 to 4 (xorl, subq, cmpq, setbe).
912 * alloc.c (pure): Always extern now, since that's the
913 VIRT_ADDR_VARIES behavior.
914 (PURE_POINTER_P): Use a single comparison, not two, for
915 consistency with the new puresize.h.
916 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
917 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
918 Remove VIRT_ADDR_VARIES no longer needed.
920 2011-11-19 Eli Zaretskii <eliz@gnu.org>
922 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
923 (erase_phys_cursor, update_window_cursor, show_mouse_face)
924 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
925 behave as if the cursor position were at the window margin.
927 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
928 and the cursor position is out of bounds, behave as if the cursor
929 position were at the window margin. (Bug#10075)
931 2011-11-18 Chong Yidong <cyd@gnu.org>
933 * window.c (Fwindow_combination_limit): Make first argument
934 non-optional, since it is meaningless for live windows like the
937 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
939 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
941 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
943 * intervals.c: Fix grafting over the whole buffer (bug#10071).
944 (graft_intervals_into_buffer): Simplify.
946 2011-11-18 Eli Zaretskii <eliz@gnu.org>
948 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
949 hash values of the two rows.
950 (copy_row_except_pointers): Preserve the used[] arrays and the
951 hash values of the two rows. (Bug#10035)
952 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
954 * xdisp.c (row_hash): New function, body extracted from
955 compute_line_metrics.
956 (compute_line_metrics): Call row_hash, instead of computing the
959 * dispnew.c (verify_row_hash): Call row_hash for computing the
960 hash code of a row, instead of duplicating code from xdisp.c.
962 * dispextern.h (row_hash): Add prototype.
964 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
966 * frame.c (delete_frame): Don't delete the terminal when the last
967 X frame is closed if emacs is built with GTK toolkit.
969 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
971 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
973 2011-11-17 Martin Rudalics <rudalics@gmx.at>
975 * window.c (Vwindow_splits): Rename to
976 Vwindow_combination_resize. Suggested by Juri Linkov.
977 (Fsplit_window_internal): Use Vwindow_combination_resize instead
980 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
982 * nsfns.m (Fns_font_name):
983 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
985 2011-11-16 Martin Rudalics <rudalics@gmx.at>
987 * window.h (window): Rename slot "nest" to "combination_limit".
988 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
989 (Fset_window_nest): Rename to Fset_window_combination_limit.
990 (Vwindow_nest): Rename to Vwindow_combination_limit.
991 (recombine_windows, make_parent_window, make_window)
992 (Fsplit_window_internal, saved_window)
993 (Fset_window_configuration, save_window_save): Rename all
994 occurrences of window_nest to window_combination_limit.
996 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
998 * image.c (imagemagick_load_image): Fix typo.
1000 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1002 * xdisp.c (display_line): Move the call to
1003 highlight_trailing_whitespace before the call to
1004 compute_line_metrics, since the latter needs to see the final
1005 faces of all the glyphs to compute ROW's hash value.
1006 Fixes assertion violations in row_equal_p. (Bug#10035)
1008 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1010 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1011 just return (bug#10044).
1013 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1015 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1016 with user-defined heap size. Bump the default size of the temacs
1017 heap to 27MB, to avoid memory warning when running temacs.
1018 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1020 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1021 current_matrix and desired_matrix. (Bug#9990)
1022 (verify_row_hash) [XASSERTS]: New function.
1023 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1024 that the hash value of glyph rows is correct.
1026 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1028 * window.h (window): Remove splits slot.
1029 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1030 (Fdelete_other_windows_internal, make_parent_window)
1031 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1032 (Fset_window_configuration, save_window_save): Don't deal with
1033 split status of windows.
1034 (saved_window): Remove splits slot.
1035 (Vwindow_splits): Rewrite doc-string.
1037 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1039 * xfns.c (unwind_create_frame):
1040 * nsfns.m (unwind_create_frame):
1041 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1042 Vframe_list (Bug#9999).
1044 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1046 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1048 2011-11-11 Kenichi Handa <handa@m17n.org>
1050 * callproc.c (Fcall_process): Set the member dst_multibyte of
1053 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1055 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1056 avoid a crash (bug#9496).
1058 2011-11-09 Chong Yidong <cyd@gnu.org>
1060 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1061 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1063 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1065 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1067 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1069 Avoid some portability problems by eschewing 'extern inline' functions.
1070 The trivial performance wins aren't worth the portability hassles; see
1071 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1073 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1074 (window_box_width, window_box_left, window_box_left_offset)
1075 (window_box_right, window_box_right_offset): Undo previous change,
1076 by removing the "extern"s.
1077 * intervals.c (adjust_intervals_for_insertion)
1078 (adjust_intervals_for_deletion): Undo previous change,
1079 making these static again.
1080 (offset_intervals, temp_set_point_both, temp_set_point)
1081 (copy_intervals_to_string): No longer inline.
1082 * xdisp.c (window_text_bottom_y, window_box_width)
1083 (window_box_height, window_box_left_offset)
1084 (window_box_right_offset, window_box_left, window_box_right)
1085 (window_box): No longer inline.
1087 2011-11-08 Chong Yidong <cyd@gnu.org>
1089 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1090 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1091 Signal an error if not a live window.
1092 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1093 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1095 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1097 * lisp.h (syms_of_abbrev): Remove declaration.
1098 Reported by CHENG Gao <chenggao@royau.me>.
1100 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1102 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1103 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1104 of temacs in GUI mode.
1106 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1108 * window.h: Declare delete_all_child_windows instead of
1109 delete_all_subwindows.
1110 * window.c (Fwindow_nest, Fset_window_nest)
1111 (Fset_window_new_total, Fset_window_new_normal)
1112 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1113 (delete_all_subwindows): Rename to delete_all_child_windows.
1114 (Fdelete_other_windows_internal, Fset_window_configuration):
1115 Call delete_all_child_windows instead of delete_all_subwindows.
1116 * frame.c (delete_frame): Call delete_all_child_windows instead
1117 of delete_all_subwindows.
1119 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1121 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1122 This is also needed for porting to any host where GC_MARK_STACK is
1123 not GC_MAKE_GCPROS_NOOPS.
1124 (which_symbols): Use it.
1126 2011-11-07 Kenichi Handa <handa@m17n.org>
1128 * coding.c (coding_set_destination): Check coding->src_pos only
1129 when coding->src_object is a buffer (bug#9910).
1131 * process.c (send_process): Set the member src_multibyte of coding
1132 to 0 (bug#9911) when sending a unibyte text.
1134 * callproc.c (Fcall_process): Set the member src_multibyte of
1135 process_coding to 0 (bug#9912).
1137 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1139 * xmenu.c (cleanup_widget_value_tree): New function.
1140 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1141 calling free_menubar_widget_value_tree directly (Bug#9830).
1143 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1145 Fix some portability problems with 'inline'.
1146 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1147 (window_box_width, window_box_left, window_box_left_offset)
1148 (window_box_right, window_box_right_offset): Declare extern.
1149 Otherwise, these inline functions do not conform to C99 and
1150 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1151 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1152 * intervals.c (adjust_intervals_for_insertion)
1153 (adjust_intervals_for_deletion): Now extern, because otherwise the
1154 extern inline functions 'offset_intervals' couldn't refer to it.
1155 (static_offset_intervals): Remove.
1156 (offset_intervals): Rewrite using the old contents of
1157 static_offset_intervals. The old version didn't conform to C99
1158 because an extern inline function contained a reference to an
1159 identifier with static linkage.
1161 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1163 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1166 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1168 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1169 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1170 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1171 return Qleft_to_right.
1173 2011-11-06 Chong Yidong <cyd@gnu.org>
1175 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1176 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1177 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1178 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1179 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1180 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1181 (Fwindow_vscroll): Doc fix.
1182 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1183 argument, since it makes no sense to pass a live window and for
1184 consistency with window-child.
1186 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1188 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1191 2011-11-05 Jason Rumney <jasonr@gnu.org>
1193 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1194 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1196 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1197 bitwise arithmetic preventing use of unicode-sip and non-truetype
1200 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1202 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1205 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1206 initialization code to keep similarity to xfns.c after changes
1209 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1211 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1212 (unwind_create_frame): New function (Bug#9943).
1213 (Fx_create_frame): Restructure code to be more similar to the one in
1214 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1215 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1216 Move terminal->reference_count++ just before making the frame official
1219 * nsterm.m (x_free_frame_resources): New function.
1220 (x_destroy_window): Move code to x_free_frame_resources.
1222 * xfns.c (unwind_create_frame): Fix comment.
1223 (Fx_create_frame, x_create_tip_frame):
1224 Move terminal->reference_count++ just before making the frame
1225 official. Move initialization of image_cache_refcount and
1226 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1228 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1230 Support MSVC build with newer versions of Visual Studio.
1231 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1232 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1235 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1236 which are not supported by MSVC.
1237 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1238 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1240 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1242 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1244 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1246 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1248 Support MSVC build with newer versions of Visual Studio.
1249 * w32.c: Don't include w32api.h for MSVC.
1250 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1252 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1253 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1254 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1255 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1257 (alloca) [_MSC_VER]: Define to _alloca.
1259 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1261 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1263 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1265 * xdisp.c (note_mouse_highlight): If either of
1266 previous/next-single-property-change returns nil, treat that as
1267 the beginning or the end of the buffer. (Bug#9955)
1269 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1271 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1272 label is not null (Bug#9951).
1273 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1276 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1278 * window.c (Fwindow_body_size): Mention in the doc string that the
1279 return value is in frame's canonical units. (Bug#9949)
1281 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1283 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1285 * w32fns.c (unwind_create_frame): If needed, free the glyph
1286 matrices of the partially constructed frame. (Bug#9943)
1287 * xfns.c (unwind_create_frame): Likewise.
1289 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1291 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1292 Don't stop backward scan on the continuation glyph, even though
1293 its CHARPOS is positive.
1294 (mouse_face_from_buffer_pos, note_mouse_highlight):
1295 Rename cover_string to disp_string.
1297 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1299 * window.c (temp_output_buffer_show): Don't use
1300 Vtemp_buffer_show_specifiers.
1301 (Vtemp_buffer_show_specifiers): Remove unused variable.
1303 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1305 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1306 past the beginning of the current glyph matrix.
1308 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1310 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1311 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1312 HAVE_GTK3 (Bug#9869).
1314 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1315 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1317 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1319 * xterm.c: Declare x_handle_net_wm_state to return int.
1320 (handle_one_xevent): Check if we are iconified but don't have
1321 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1322 (get_current_wm_state): Return non-zero if not hidden,
1323 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1324 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1325 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1326 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1328 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1330 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1331 so that this new function doesn't get optimized away by a
1332 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1334 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1336 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1338 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1340 Fix the `xbytecode' command.
1341 * .gdbinit (xprintbytestr): New command.
1342 (xwhichsymbols): Rename from `which'; all callers changed.
1343 (xbytecode): Print the byte-code string as well.
1345 2011-10-29 Kim Storm <storm@cua.dk>
1347 * alloc.c (which_symbols): New function.
1349 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1351 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1354 2011-10-29 Glenn Morris <rgm@gnu.org>
1356 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1357 Not clear what it was for, and it causes various bugs. (Bug#9839)
1359 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1361 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1362 possible random value that matches one of those tested as
1363 condition to clear the mouse face.
1365 2011-10-28 Chong Yidong <cyd@gnu.org>
1367 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1369 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1371 * window.c (make_window): Initialize phys_cursor_on_p.
1373 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1375 * lisp.h (struct Lisp_Symbol): Update comments.
1377 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1379 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1381 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1383 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1384 <oslsachem@gmail.com> for helping to debug this.
1386 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1387 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1388 (g_b_init_get_glyph_outline_w): New static variables.
1389 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1390 (GetGlyphOutlineW_Proc): New typedefs.
1391 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1392 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1394 (w32font_open_internal, compute_metrics):
1395 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1396 instead of calling the "wide" APIs directly.
1398 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1400 * w32.h (syms_of_w32font): Add prototype.
1402 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1404 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1405 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1406 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1407 (Fmove_to_window_line): Doc fix.
1409 2011-10-27 Chong Yidong <cyd@gnu.org>
1411 * process.c (make_process): Set gnutls_state to NULL.
1413 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1414 non-NULL, regardless of GNUTLS_INITSTAGE.
1415 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1416 an error. Set process slots as soon as we allocate them.
1418 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1420 2011-10-27 Chong Yidong <cyd@gnu.org>
1422 * gnutls.c (emacs_gnutls_deinit): New function.
1423 Deallocate credentials structures as well as calling gnutls_deinit.
1424 (Fgnutls_deinit, Fgnutls_boot): Use it.
1426 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1427 (deactivate_process): Call emacs_gnutls_deinit.
1429 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1431 * image.c (x_create_x_image_and_pixmap):
1432 * w32.c (sys_rename, w32_delayed_load):
1433 * w32font.c (fill_in_logfont):
1434 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1436 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1438 * w32fns.c (w32_default_color_map): New function,
1439 extracted from Fw32_default_color_map.
1440 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1442 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1444 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1446 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1448 * keyboard.c (test_undefined): New function (bug#9751).
1449 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1451 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1453 * sysdep.c (init_sys_modes): Fix the check for the controlling
1454 terminal (Bug#6649).
1456 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1458 * dispextern.h (struct bidi_it): New member next_en_type.
1460 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1461 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1462 current character, check also for next_en_type being WEAK_EN.
1463 (bidi_resolve_weak): Don't enter the expensive loop if the current
1464 position is before next_en_pos. Record the bidi type of the first
1465 non-ET, non-BN character we find, in addition to its position.
1466 (bidi_level_of_next_char): Invalidate next_en_type when
1467 next_en_pos is over-stepped.
1469 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1471 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1472 * editfns.c: Rewrite current-time-zone so that it invokes
1473 the equivalent of (format-time-string "%Z") to get the time zone name.
1474 This fixes a bug when the time zone name contains characters that
1475 need converting from the system time locale to Emacs internal format.
1476 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1477 that patch fixed format-time-string to do the conversion, but
1478 I forgot to fix current-time-zone.
1479 (format_time_string): New function, containing most of
1480 what Fformat_time_string used to contain.
1481 (Fformat_time_string): Rewrite in terms of format_time_string.
1482 This doesn't change this function's behavior.
1483 (current-time-zone): Rewrite to use format_time_string.
1484 This fixes the bug reported by Michael Schierl in
1485 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1486 Jason Rumney's 2007-06-07 change worked around this bug, but
1488 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1490 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1492 * xdisp.c (start_display): If the character at POS is displayed
1493 via a display vector, reset IT->current.dpvec_index to zero.
1494 (try_window_reusing_current_matrix): If a line ends in a display
1495 vector or the next line starts in a display vector, continue
1496 redrawing the window even though the character position of
1497 start_row was reached.
1500 2011-10-18 Chong Yidong <cyd@gnu.org>
1502 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1503 with nobreak-char-display too.
1505 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1507 Fix part 3 of bug#9771.
1508 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1509 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1510 non-neutral characters if the current character is a paragraph
1511 separator (a.k.a. Newline). This avoids running the same
1512 expensive loop twice, once when we consume the preceding newline
1513 and the other time when the line actually needs to be displayed.
1514 Avoid the loop when we see neutrals on the base embedding level
1515 following a character whose directionality is the same as the
1516 paragraph's. This avoids running the expensive loop when a line
1517 ends in a long sequence of neutrals, like control characters.
1518 Add assertion against STRONG_AL type. Slightly rearrange code
1519 that determines the type of a neutral given the first non-neutral
1521 (bidi_level_of_next_char): Set next_en_pos to zero when
1522 invalidating its info.
1524 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1526 * xdisp.c (push_display_prop): Determine whether to record string
1527 or buffer position by IT->string, not by IT->method. Allow
1528 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1529 (move_it_vertically_backward): Don't look for character position
1530 immediately after the newline when in a continuation line.
1533 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1535 * window.c (coordinates_in_window): Rewrite and delabelize
1536 vertical border check. (Bug#5357) (Bug#9618)
1538 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1540 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1541 errors in XSetWindowBorder (bug#9310).
1543 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1545 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1546 avoid crash when xmalloc overrun checking is enabled.
1548 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1550 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1551 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1552 cursor motion with <left> and <right> arrow keys.
1554 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1555 some callers set that themselves.
1557 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1559 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1560 display string and the previous row comes from the same string and
1561 is empty. (Bug#9739) (Bug#9738)
1563 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1565 * doc.c (get_doc_string): Encode file name (bug#9735).
1567 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1569 * bidi.c (bidi_level_of_next_char):
1570 * xdisp.c (get_visually_first_element): Remove old incorrect
1571 comments regarding the Unicode Line Separator character.
1573 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1575 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1577 * alloc.c (Fgc_status): Do not access beyond zombies array
1578 boundary if nzombies > MAX_ZOMBIES.
1579 * alloc.c (dump_zombies): Add missing format specifier.
1581 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1583 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1584 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1586 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1587 Some packages use them to denote characters with modifiers.
1589 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1591 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1592 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1593 matching a pp-number. Rename parameter var to var1.
1595 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1597 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1599 2011-10-08 Glenn Morris <rgm@gnu.org>
1601 * callint.c (Fcall_interactively): Give a more explicit error for the
1602 'c' case with a non-character input. (Bug#8479)
1604 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1606 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1608 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1609 lines that are hscrolled on the left.
1611 * dispnew.c (buffer_posn_from_coords): Account for a possible
1612 presence of header-line. (Bug#4426)
1614 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1616 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1617 Don't advertise functionality which we discourage or doesn't work.
1619 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1621 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1622 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1623 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1624 this makes Emacs dump core during garbage collection on rare
1625 occasions. sizeof is obviously inferior to offsetof here, so
1626 stick with offsetof.
1627 (GC_POINTER_ALIGNMENT): New macro.
1628 (mark_memory): Omit 3rd (offset) arg; caller changed.
1629 Don't assume EMACS_INT alignment is the same as pointer alignment.
1631 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1633 * keyboard.c (read_key_sequence_remapped): New var.
1634 (read_key_sequence): Compute remapping in the right buffer.
1635 (command_loop_1): Use read_key_sequence's remapping directly.
1637 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1639 * dired.c (file_name_completion): Don't expand file name.
1640 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1641 before checking file name handler.
1643 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1644 they've been requested explicitly (bug#9591).
1646 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1648 * keymap.c (Fsingle_key_description): Use make_specified_string
1649 instead of build_string to build string from push_key_description.
1652 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1654 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1655 This fixes a Y2038 bug on 64-bit hosts.
1656 * buffer.c (reset_buffer):
1657 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1658 (Fclear_buffer_auto_save_failure):
1659 Use 0, not -1, to represent an unset failure time, since time_t
1660 might not be signed.
1662 Remove dependency on glibc malloc internals.
1663 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1664 Move back here from lisp.h, but with their new implementations.
1665 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1666 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1667 * charset.c (charset_table_init): New static var.
1668 (syms_of_charset): Use it instead of xmalloc. This removes a
1669 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1670 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1671 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1672 Move back to alloc.c.
1673 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1674 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1676 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1678 * nsterm.m (windowDidResize): Call x_set_window_size only when
1679 ns_in_resize is true. Otherwise set pixelwidth/height and
1680 call change_frame_size (Bug#9628).
1682 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1684 Port --enable-checking=all to Fedora 14 x86-64.
1685 * charset.c (syms_of_charset): Also account for glibc malloc's
1686 internal overhead when calculating the initial malloc maximum.
1688 Port --enable-checking=all to Fedora 14 x86.
1689 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1691 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1692 (overrun_check_realloc, overrun_check_free):
1693 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1694 That way, xmalloc returns a properly-aligned pointer even if
1695 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1696 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1697 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1698 into account when calculating the initial malloc maximum.
1699 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1700 Move here from alloc.c, so that charset.c can use it too.
1701 Properly align; the old code wasn't right for common 32-bit hosts
1702 when configured with --enable-checking=all.
1703 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1704 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1706 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1708 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1711 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1713 * xdisp.c (compute_display_string_end): If there's no display
1714 string at CHARPOS, return -1.
1716 * bidi.c (bidi_fetch_char): When compute_display_string_end
1717 returns a negative value, treat the character as a normal
1718 character not covered by a display string. (Bug#9624)
1720 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1722 * lread.c (Fread_from_string): Fix typo in docstring.
1724 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1726 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1727 newline, reseat the iterator instead of bidi-iterating there one
1728 character at a time. (Bug#9610)
1729 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1730 TO_CHARPOS if the bidi iterator is at base embedding level.
1732 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1734 * lread.c (readevalloop): Use correct code for NBSP.
1735 (read1): Likewise. (Bug#9608)
1737 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1739 * dbusbind.c (Fdbus_register_signal): When service is not
1740 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1742 2011-09-25 Glenn Morris <rgm@gnu.org>
1744 * buffer.c (truncate-lines): Doc fix.
1746 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1748 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1749 (Fset_window_next_buffers): Doc fix.
1751 2011-09-24 Glenn Morris <rgm@gnu.org>
1753 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1755 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1757 Fix minor problems found by static checking.
1758 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1759 * indent.c (Fvertical_motion): Fix == vs = typo.
1761 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1763 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1764 Default value is now t. Doc fix.
1766 * indent.c (Fvertical_motion): Compute and apply the overshoot
1767 logic when moving up, not only when moving down. Fix the
1768 confusing name and values of the it_overshoot_expected variable;
1769 logic changes accordingly. (Bug#9254) (Bug#9549)
1771 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1772 CHARPOS is covered by a display string which includes newlines.
1773 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1774 is covered by a display string with embedded newlines.
1776 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1778 * dbusbind.c (Fdbus_register_signal): Add match rule to
1779 Vdbus_registered_objects_table. (Bug#9581)
1780 (Fdbus_register_method, Vdbus_registered_objects_table):
1783 2011-09-24 Jim Meyering <meyering@redhat.com>
1785 do not ignore write error for any output size
1786 The previous change was incomplete.
1787 While it makes emacs --batch detect the vast majority of stdout
1788 write failures, errors were still ignored whenever the output size is
1789 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1790 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1791 && echo FAIL: ignored write error
1792 FAIL: ignored write error
1793 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1794 && echo FAIL: ignored write error
1795 FAIL: ignored write error
1796 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1798 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1800 * emacs.c (Fkill_emacs): In noninteractive mode exit
1801 non-successfully if a write error occurred on stdout. (Bug#9574)
1803 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1805 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1808 * dispextern.h (struct it): Update the comment documenting what
1811 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1813 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1814 a display string, extend search for cursor position to end of row.
1815 (find_row_edges): If the row ends in a newline from a display
1816 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1817 Handle the case of a display string with multiple newlines.
1818 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1819 non-empty line. Fixes confusing cursor motion with arrow keys at
1820 the beginning of a line that starts with whitespace.
1822 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1824 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1827 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1829 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1832 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1834 * xdisp.c (display_line): Record maximum and minimum buffer
1835 positions even if no glyphs were produced (e.g., by a zero-width
1836 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1837 buffer positions that will be removed from the glyph row because
1839 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1840 column is beyond frame width: don't subtract 1 "pixel" when
1841 computing width of the stretch.
1842 (reseat_at_next_visible_line_start): Undo the change made on
1843 2011-09-17 that saved paragraph information and restored it after
1844 the call to `reseat'. (Bug#9545)
1846 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1848 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1849 and turn window cursor on if cleared (Bug#9415).
1851 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1853 * search.c (boyer_moore): Take unibyte characters from pattern
1854 literally. (Bug#9458)
1856 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1858 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1860 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1862 Fix minor problem found by static checking.
1863 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1864 initialized, to pacify gcc -Wuninitialized.
1866 * fileio.c: Report proper errno when syscall falls.
1867 (Finsert_file_contents): Save and restore errno,
1868 so that report_file_error outputs the correct diagnostic.
1869 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1871 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1873 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1875 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1877 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1878 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1880 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1882 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1883 about the current paragraph and restore it after the call to reseat.
1885 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1886 (bidi_find_paragraph_start): Search back for paragraph beginning
1887 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1888 (bidi_move_to_visually_next): Only trigger paragraph-related
1889 computations when the last character is a newline or at EOB, not
1890 just any NEUTRAL_B. (Bug#9470)
1892 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1893 truncated lines if point is covered by a display string. (Bug#9524)
1895 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1897 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1898 (cons_to_x_long): New function.
1899 (lisp_data_to_selection_data): Use it. Correct the test for
1900 short-versus-long data; it was negated. Break out of vector
1901 loop, for efficiency, when a long datum is discovered.
1903 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1905 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1907 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1909 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1910 GCC PR/17406) by declaring this function with external scope.
1912 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1914 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1915 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1917 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1919 * editfns.c (Fformat): Correctly handle text properties on "%%".
1921 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1923 * xterm.c (x_draw_composite_glyph_string_foreground):
1924 * w32term.c (x_draw_composite_glyph_string_foreground):
1925 * term.c (encode_terminal_code):
1926 * composite.c (composition_update_it, get_composition_id):
1927 * xdisp.c (get_next_display_element)
1928 (fill_composite_glyph_string): Add comments about special meaning
1929 of TAB characters in a composition.
1931 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1933 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1934 This occurs when processing a multibyte format.
1935 Problem reported by Wolfgang Jenker.
1937 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1939 * xdisp.c (try_cursor_movement): Only check for exact match if
1940 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1942 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1944 Remove unused external symbols.
1945 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1946 * xdisp.c (calc_pixel_width_or_height): Now static.
1947 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1948 * indent.c (check_display_width):
1949 * w32term.c: Fix comment to match code.
1950 * xterm.c, xterm.h (x_catching_errors): Remove.
1952 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1954 * xselect.c: Use signed conversions more consistently (Bug#9498).
1955 (selection_data_to_lisp_data): Assume incoming selection data are
1956 signed integers, not unsigned. This is to be consistent with
1957 outgoing selection data, which was modified to use signed integers
1958 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1959 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1960 expects long, not unsigned long.
1962 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1964 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1965 computation of loop end. Reported by Johan Bockgård
1968 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1970 * frame.c (Fother_visible_frames_p): Function deleted.
1972 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1974 * indent.c (compute_motion): Process display vector front to back
1975 rather than the other way around. (Bug#2496)
1977 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1979 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1981 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1983 * minibuf.c (Fread_from_minibuffer): Doc fix.
1985 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1987 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1988 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1990 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1992 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1993 value for non-existent files.
1995 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1997 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1998 set its "size" to -1. This will set the modtime_size field of
1999 the corresponding buffer to -1, which is what
2000 verify-visited-file-modtime expects for files that do not exist.
2003 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2005 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2007 * lisp.h: ... from here. push_key_description is no longer
2008 defined in keyboard.c, so its declaration should not be in
2009 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2010 logically belongs with push_key_description.
2012 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2014 * buffer.h: Include <sys/types.h> instead of <time.h>.
2015 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2016 Problem reported by Herbert J. Skuhra.
2018 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2020 * xml.c (parse_region): Make the parsing work for
2021 non-comment-starting XML files again (bug#9144).
2023 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2025 * image.c (gif_load): Fix calculation of bottom and right corner.
2028 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2030 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2031 redisplay in small windows.
2033 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2035 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2037 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2039 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2040 Operate on live windows only.
2042 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2044 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2046 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2048 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2049 only under bidi iteration.
2051 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2053 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2055 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2057 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2058 Without this fix, the command to link temacs failed due to an
2059 undefined symbol __builtin_isnan. This is because
2060 /usr/include/iso/math_c99.h #defines isnan(x) to
2061 __builtin_isnan(x), but the bundled gcc, which identifies itself
2062 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2064 * floatfns.c (isnan): #undef, and then #define to a clone of
2066 (Fisnan): Always define, since it's always available now.
2067 (syms_of_floatfns): Always define isnan at the Lisp level.
2069 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2071 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2073 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2075 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2076 The previous code assumed that file offsets (off_t values) fit in
2077 EMACS_INT variables, which is not true on typical 32-bit hosts.
2078 The code messed up by falsely reporting buffer overflow in cases
2079 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2080 when "big" contains more than 2**29 bytes, even though this
2081 inserts just one byte and does not overflow the buffer.
2082 (Finsert_file_contents): Store file offsets as off_t
2083 values, not as EMACS_INT values. Check for overflow when
2084 converting between EMACS_INT and off_t. When checking for
2085 buffer overflow or for overlap, take the offsets into account.
2086 Don't use EMACS_INT for small values where int suffices.
2087 When checking for overlap, fix a typo: ZV was used where
2088 ZV_BYTE was intended.
2089 (Fwrite_region): Don't assume off_t fits into 'long'.
2090 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2092 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2094 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2096 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2098 sprintf-related integer and memory overflow issues (Bug#9412).
2100 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2101 (esprintf, exprintf, evxprintf): New functions.
2102 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2103 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2104 (modify_event_symbol): Do not assume that the length of
2105 name_alist_or_stem is safe to alloca and fits in int.
2106 (Fexecute_extended_command): Likewise for function name and binding.
2107 (Frecursion_depth): Wrap around reliably on integer overflow.
2108 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2109 since some callers pass EMACS_INT values.
2110 (Fsingle_key_description): Don't crash if symbol name contains more
2111 than MAX_ALLOCA bytes.
2112 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2113 (get_minibuffer): Arg is now EMACS_INT, not int.
2114 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2115 (esprintf, exprintf, evxprintf): New decls.
2116 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2118 * dbusbind.c (signature_cat): New function.
2119 (xd_signature, Fdbus_register_signal):
2120 Do not overrun buffer; instead, report string overflow.
2122 * dispnew.c (add_window_display_history): Don't overrun buffer.
2123 Truncate instead; this is OK since it's just a log.
2125 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2126 even if the time zone offset is outlandishly large.
2127 Don't mishandle offset == INT_MIN.
2129 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2130 when creating daemon; the previous buffer-overflow check was incorrect.
2132 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2133 which has the guts of the old verror function.
2135 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2136 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2138 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2139 (font_unparse_xlfd): Don't blindly alloca long strings.
2140 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2141 fits in int, when using sprintf. Use single snprintf to count
2142 length of string rather than counting it via multiple sprintfs;
2143 that's simpler and more reliable.
2144 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2145 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2146 sprintf, in case result does not fit in int.
2148 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2149 (fontset_from_font): Print it.
2151 * frame.c (tty_frame_count): Now printmax_t, not int.
2152 (make_terminal_frame, set_term_frame_name): Print it.
2153 (x_report_frame_params): In X, window IDs are unsigned long,
2154 not signed long, so print them as unsigned.
2155 (validate_x_resource_name): Check for implausibly long names,
2156 and don't assume name length fits in 'int'.
2157 (x_get_resource_string): Don't blindly alloca invocation name;
2158 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2161 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2162 (xg_check_special_colors, xg_set_geometry):
2163 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2165 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2166 Use esprintf, not sprintf, in case result does not fit in int.
2168 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2169 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2170 it as a large positive number.
2171 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2172 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2174 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2175 in case result does not fit in int.
2177 * print.c (float_to_string): Detect width overflow more reliably.
2178 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2179 buffer overrun. Don't assume list length fits in 'int'. Treat
2180 print length of 0 as 0, not as infinity; to be consistent with other
2181 uses of print length in this function. Don't overflow print length
2182 index. Don't assume hash table size fits in 'long', or that
2183 vectorlike size fits in 'unsigned long'.
2185 * process.c (make_process): Use printmax_t, not int, to format
2186 process-name gensyms.
2188 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2190 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2191 to avoid potential buffer overrun.
2193 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2194 if X resource line is longer than 512 bytes.
2196 * xfns.c (x_window): Make sprintf buffer a bit bigger
2197 to avoid potential buffer overrun.
2199 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2201 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2203 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2205 Integer overflow fixes for scrolling, etc.
2206 Without these, Emacs silently mishandles large integers sometimes.
2207 For example, "C-u 4294967297 M-x recenter" was treated as if
2208 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2210 * xdisp.c (try_window_id): Check Emacs fixnum range before
2211 converting to 'int'.
2213 * window.c (window_scroll_line_based, Frecenter):
2214 Check that an Emacs fixnum is in range before assigning it to 'int'.
2215 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2216 values converted from Emacs fixnums.
2217 (Frecenter): Don't wrap around a line count if it is out of 'int'
2218 range; instead, treat it as an extreme value.
2219 (Fset_window_configuration, compare_window_configurations):
2220 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2222 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2223 that can exceed INT_MAX. Check that EMACS_INT value is in range
2224 before assigning it to the (possibly-narrower) index.
2225 (match_limit): Don't assume that a fixnum can fit in 'int'.
2227 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2230 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2231 (Fvertical_motion): Don't wrap around LINES values that don't fit
2232 in 'int'. Instead, treat them as extreme values. This is good
2233 enough for windows, which can't have more than INT_MAX lines anyway.
2235 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2237 * Require libxml/parser.h to avoid compilation warning.
2239 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2241 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2242 since this reportedly can destroy thread storage.
2244 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2246 * syntax.c (find_defun_start): Update all cache variables if
2247 exiting early (Bug#9401).
2249 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2251 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2253 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2254 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2255 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2257 * term.c (tty_append_glyph): New function.
2258 (produce_stretch_glyph): Static function and its prototype deleted.
2260 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2263 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2265 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2266 when checking :margin (Bug#9390).
2267 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2268 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2269 so that the name doesn't mislead. All uses changed.
2271 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2273 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2276 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2278 * xdisp.c (move_it_to): Don't bail out early when reaching
2279 position beyond to_charpos, if we are scanning backwards.
2280 (move_it_vertically_backward): When DY == 0, make sure we get to
2281 the first character in the line after the newline.
2283 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2285 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2286 (ccl_driver): Do not generate an out-of-range pointer.
2287 (Fccl_execute_on_string): Remove unnecessary check for
2288 integer overflow, noted by Stefan Monnier in
2289 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2290 Remove a FIXME that didn't need fixing.
2291 Simplify the newly-introduced buffer reallocation code.
2293 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2295 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2297 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2299 Integer and memory overflow issues (Bug#9196).
2301 * doc.c (get_doc_string): Rework so that
2302 get_doc_string_buffer_size is the actual buffer size, rather than
2303 being 1 less than the actual buffer size; this makes xpalloc more
2306 * image.c (x_allocate_bitmap_record, cache_image):
2307 * xselect.c (Fx_register_dnd_atom):
2308 Simplify previous changes by using xpalloc.
2310 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2311 since either will do and ptrdiff_t is convenient with xpalloc.
2313 * charset.c (charset_table_size)
2314 (struct charset_sort_data.priority): Now ptrdiff_t.
2315 (charset_compare): Don't overflow if priorities differ greatly.
2316 (Fsort_charsets): Don't assume list length fits in int.
2317 Check for size-calculation overflow when allocating sort data.
2318 (syms_of_charset): Allocate an initial charset table that is
2319 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2321 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2323 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2324 The actual value is always <= INT_MAX, and leaving it unsigned made
2325 overflow checking harder.
2327 * dispextern.h (struct glyph_matrix.rows_allocated)
2328 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2329 with xpalloc. The values are still always <= INT_MAX.
2331 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2333 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2334 (SAFE_NALLOCA): New macro.
2336 * region-cache.c (struct boundary.pos, find_cache_boundary)
2337 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2338 (set_cache_region, invalidate_region_cache)
2339 (revalidate_region_cache, know_region_cache, region_cache_forward)
2340 (region_cache_backward, pp_cache):
2341 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2342 so that ptrdiff_t * can be passed to xpalloc.
2343 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2344 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2345 (pp_cache): Don't assume cache_len fits in int.
2346 * region-cache.h: Adjust extern decls to match.
2348 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2349 EMACS_INT, since either will do, for xpalloc.
2351 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2352 (xnmalloc, xnrealloc, xpalloc): New functions.
2354 * bidi.c (bidi_shelve_header_size): New constant.
2355 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2356 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2358 * bidi.c (bidi_cache_shrink):
2359 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2361 Don't update size of array until after memory allocation succeeds,
2362 because xmalloc/xrealloc may not return.
2363 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2364 now that we have proper integer overflow checking.
2365 (record_overlay_string, overlay_strings): Catch overflows when
2366 calculating size of overlay_str_buf.
2368 * callproc.c (Fcall_process): Check for size overflow when
2369 calculating size of args2.
2370 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2371 Normally we prefer signed values, but sticking with ptrdiff_t would
2372 require adding more-complicated checks.
2374 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2375 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2376 Redo buffer-overflow calculations to avoid integer overflow.
2377 Add a FIXME comment where memory seems to be over-allocated.
2379 * character.c (Fstring): Check for size-calculation overflow.
2381 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2382 unnecessary integer overflow. Check for size overflow.
2383 (encode_coding_object): Don't update size until xmalloc succeeds.
2385 * composite.c (get_composition_id): Check for overflow in glyph
2386 length calculations.
2388 Integer and memory overflow fixes for display code.
2389 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2390 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2391 (scrolling_window): Check for overflow in size calculations.
2392 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2393 Don't assume glyph table len fits in int.
2394 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2395 (row_table_size): Now ptrdiff_t, not int.
2396 (scrolling_window): Avoid overflow in size calculations.
2397 Don't update size until allocation succeeds.
2398 * fns.c (concat): Check for overflow in size calculations.
2399 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2400 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2401 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2403 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2404 (get_doc_string): Check for size calculation overflow.
2405 Don't update size until allocation succeeds.
2406 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2407 EMACS_INT, where ptrdiff_t will do.
2408 (Fsubstitute_command_keys): Check for string overflow.
2410 * editfns.c (set_time_zone_rule): Don't assume environment length
2412 (message_length): Now ptrdiff_t, not int.
2413 (Fmessage_box): Don't update size until allocation succeeds.
2414 Don't assume message length fits in int.
2415 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2417 * emacs.c (main): Do not reallocate argv, since there is a null at
2418 the end that can be overwritten, and this way there's no need to
2419 worry about size-calculation overflow.
2420 (sort_args): Check for size-calculation overflow.
2422 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2424 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2426 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2427 (x_set_scroll_bar_width, x_figure_window_size):
2428 Check for integer overflow.
2429 (x_set_alpha): Do not assume XINT fits in int.
2431 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2432 This is for the members text_lines, text_cols, total_lines, total_cols,
2433 where the system imposes an 'int' limit.
2435 * fringe.c (Fdefine_fringe_bitmap):
2436 Don't update size until alloc works.
2438 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2439 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2441 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2442 Check for size-calculation overflow.
2443 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2444 do, as we prefer signed integers.
2445 (id_to_widget.max_size, id_to_widget.used)
2446 (xg_store_widget_in_map, xg_remove_widget_from_map)
2447 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2448 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2449 Use and return ptrdiff_t, not int.
2450 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2451 * gtkutil.h: Change prototypes to match the above.
2453 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2454 are duplicate now that they've been promoted to lisp.h.
2455 (x_allocate_bitmap_record, x_alloc_image_color)
2456 (make_image_cache, cache_image, xpm_load):
2457 Don't update size until alloc is done.
2458 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2460 Check for size calculation overflow.
2461 (ct_colors_allocated_max): New constant.
2462 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2465 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2466 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2467 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2468 Use ptrdiff_t, not int, to count maps.
2469 (read_char_minibuf_menu_prompt): Check for overflow in size
2470 calculations. Don't update size until allocation succeeds.
2471 Redo calculations to avoid overflow.
2472 * keyboard.h: Change prototypes to match the above.
2474 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2476 (current_minor_maps): Check for size calculation overflow.
2477 * keymap.h: Change prototypes to match the above.
2479 * lread.c (read1, init_obarray): Don't update size until alloc done.
2481 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2482 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2484 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2485 Now ptrdiff_t, not int.
2486 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2487 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2489 * process.c (Fnetwork_interface_list): Check for overflow
2490 in size calculation.
2492 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2494 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2495 overflow. Don't bother calling xmalloc when xrealloc will do.
2497 * search.c (Freplace_match): Check for size calculation overflow.
2498 (Fset_match_data): Don't assume list lengths fit in 'int'.
2500 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2501 for command line length. Do not attempt to address one before the
2502 beginning of an array, as that's not portable.
2504 * term.c (max_frame_lines): Remove; unused.
2505 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2507 (encode_terminal_code, calculate_costs): Check for size
2508 calculation overflow.
2509 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2510 table lengths and related sizes. Don't update size until alloc
2511 done. Redo calculations to avoid overflow.
2512 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2514 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2515 subtracting pointers.
2516 (gobble_line): Check for overflow more carefully. Don't update size
2519 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2520 Don't update size until alloc done.
2521 Redo size calculations to avoid overflow.
2522 Check for size calculation overflow.
2523 (main) [DEBUG]: Fix typo in invoking tparam1.
2525 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2526 Use ptrdiff_t, not int, for sizes.
2527 (store_mode_line_noprop_char): Don't update size until alloc done.
2529 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2530 Use ptrdiff_t, not int, for sizes.
2531 (Finternal_make_lisp_face, cache_face):
2532 Check for size calculation overflow.
2533 (cache_face): Treat size calculation overflows as if they were
2534 memory exhaustion (the usual treatment), rather than aborting.
2536 * xfns.c (x_encode_text, x_set_name_internal)
2537 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2538 sizes, since they can exceed INT_MAX in size. Check for size
2539 calculation overflow.
2541 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2542 (xg_select): Check for size calculation overflow.
2543 Don't update size until alloc done.
2545 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2546 as sprintf is limited to int lengths.
2548 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2549 (X_LONG_MIN): New macros.
2550 Use them to make the following changes clearer.
2551 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2552 This change doesn't affect the value now, but it may help remind
2553 future maintainers not to raise the value too much later.
2554 (SELECTION_QUANTUM): Remove, replacing with ...
2555 (selection_quantum): ... new function, which avoids overflow.
2557 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2558 assumption that selection length fits in 'int'.
2559 (x_reply_selection_request, x_handle_selection_request)
2560 (x_get_window_property, receive_incremental_selection)
2561 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2562 (lisp_data_to_selection_data, clean_local_selection_data):
2563 Use ptrdiff_t, not int, to record length of selection.
2564 (x_reply_selection_request, x_get_window_property)
2565 (receive_incremental_selection, x_property_data_to_lisp):
2566 Redo calculations to avoid overflow.
2567 (x_reply_selection_request): When sending hint, ceiling it at
2568 X_LONG_MAX rather than relying on wraparound overflow to send
2570 (x_get_window_property, receive_incremental_selection)
2571 (lisp_data_to_selection_data, x_property_data_to_lisp):
2572 Check for size-calculation overflow.
2573 (x_get_window_property, receive_incremental_selection)
2574 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2575 Don't store size until memory allocation succeeds.
2576 (x_get_window_property): Plug memory leak on memory exhaustion.
2577 Don't double-block input; malloc is safe here. Don't assume 2**34
2578 - 4 fits in unsigned long. Add an xassert to check
2579 XGetWindowProperty overflow. Be more careful about overflow
2580 calculations, and distinguish size from memory overflow better.
2581 (receive_incremental_selection): When tracing, don't assume
2582 unsigned int is less than INT_MAX.
2583 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2584 harmful) conversions of unsigned short to int.
2585 (lisp_data_to_selection_data): Don't assume that integers
2586 in the range -65535 through -1 fit in an X unsigned short.
2587 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2588 result parameters unless successful. Rely on cons_to_unsigned
2589 to report problems with elements; the old code wasn't right anyway.
2590 (x_check_property_data): Check for int overflow; we cannot use
2591 a wider type due to X limits.
2592 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2594 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2596 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2597 (x_term_init): Check for size calculation overflow.
2598 (x_color_cells): Don't store size until memory allocation succeeds.
2599 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2600 Don't assume alloca size is less than MAX_ALLOCA.
2601 (x_term_init): Don't assume length fits in int (sprintf is limited
2604 Use ptrdiff_t for composition IDs.
2605 * character.c (lisp_string_width):
2606 * composite.c (composition_table_size, n_compositions)
2607 (get_composition_id, composition_gstring_from_id):
2608 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2609 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2610 * window.c (Frecenter):
2611 Use ptrdiff_t, not int, for composition IDs.
2612 * composite.c (get_composition_id): Check for integer overflow.
2613 * composite.h: Adjust prototypes to match the above changes.
2615 Use ptrdiff_t for hash table indexes.
2616 * category.c (hash_get_category_set):
2617 * ccl.c (ccl_driver):
2618 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2619 * coding.c (coding_system_charset_list, detect_coding_system):
2620 * coding.h (struct coding_system.id):
2621 * composite.c (get_composition_id, gstring_lookup_cache):
2622 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2623 * image.c (xpm_get_color_table_h):
2624 * lisp.h (hash_lookup, hash_put):
2625 * minibuf.c (Ftest_completion):
2626 Use ptrdiff_t for hash table indexes, not int (which is too
2627 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2628 32-bit --with-wide-int hosts).
2630 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2631 Add a FIXME comment about memory leaks.
2632 (syms_of_charset): Don't assume xmalloc returns.
2634 Don't assume that stated character widths fit in int.
2635 * character.c (Fchar_width, c_string_width, lisp_string_width):
2636 * character.h (CHAR_WIDTH):
2637 * indent.c (MULTIBYTE_BYTES_WIDTH):
2638 Use sanitize_char_width to avoid undefined and/or bad behavior
2639 with outlandish widths.
2640 * character.h (sanitize_tab_width): Rename from sanitize_width,
2641 now that we have two such functions. All uses changed.
2642 (sanitize_char_width): New inline function.
2644 Don't assume that tab-width fits in int.
2645 * character.h (sanitize_width): New inline function.
2646 (SANE_TAB_WIDTH): New macro.
2647 (ASCII_CHAR_WIDTH): Use it.
2648 * indent.c (sane_tab_width): Remove. All uses replaced by
2649 SANE_TAB_WIDTH (current_buffer).
2650 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2652 * fileio.c: Integer overflow issues with file modes.
2653 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2655 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2656 Remove unreachable code.
2657 (read_hex, load_charset_map_from_file): Check for integer overflow.
2659 * xterm.c: Don't go over XClientMessageEvent limit.
2660 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2661 (x_send_scroll_bar_event): Likewise. Check that the size does not
2662 exceed limits imposed by XClientMessageEvent, as well as the usual
2663 ptrdiff_t and size_t limits.
2665 * keyboard.c: Overflow, signedness and related fixes.
2666 (make_lispy_movement): Use same integer type in forward decl
2667 that is used in the definition.
2668 (read_key_sequence, keyremap_step):
2669 Change bufsize argument back to int, undoing my 2011-03-30 change.
2670 We prefer signed types, and int is wide enough here.
2671 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2672 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2673 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2674 length, not size_t. Use ptrdiff_t for index, not int.
2675 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2676 possibility of integer overflow.
2678 Overflow, signedness and related fixes for images.
2680 * dispextern.h (struct it.stack[0].u.image.image_id)
2681 (struct_it.image_id, struct image.id, struct image_cache.size)
2682 (struct image_cache.used, struct image_cache.ref_count):
2683 * gtkutil.c (update_frame_tool_bar):
2684 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2685 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2686 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2687 * nsmenu.m (update_frame_tool_bar):
2688 * xdisp.c (calc_pixel_width_or_height):
2689 * xfns.c (image_cache_refcount):
2690 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2691 on typical 64-bit hosts.
2693 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2694 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2695 Omit unnecessary casts to int.
2696 (parse_image_spec): Check that integers fall into 'int' range
2697 when the callers expect that.
2698 (image_ascent): Redo ascent calculation to avoid int overflow.
2699 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2700 (lookup_image): Remove unnecessary tests.
2701 (xbm_image_p): Locals are now of int, not EMACS_INT,
2702 since parse_image_check makes sure they fit into int.
2703 (png_load, gif_load, svg_load_image):
2704 Prefer int to unsigned where either will do.
2705 (tiff_handler): New function, combining the cores of the
2706 old tiff_error_handler and tiff_warning_handler.
2707 This function is rewritten to use vsnprintf and thereby avoid
2708 stack buffer overflows. It uses only the features of vsnprintf
2709 that are common to both POSIX and native Microsoft.
2710 (tiff_error_handler, tiff_warning_handler): Use it.
2711 (tiff_load, gif_load, imagemagick_load_image):
2712 Don't assume :index value fits in 'int'.
2713 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2714 (imagemagick_load_image): Check that crop parameters fit into
2715 the integer types that MagickCropImage accepts. Don't assume
2716 Vimagemagick_render_type has a nonnegative value. Don't assume
2717 size_t fits in 'long'.
2718 (gs_load): Use printmax_t to print the widest integers possible.
2719 Check for integer overflow when computing image height and width.
2721 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2723 * xdisp.c (redisplay_window): Don't force window start if point
2724 will be invisible in the resulting window. (Bug#9324)
2726 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2728 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2729 the display spec is of the form `(space ...)'.
2730 (handle_display_spec): Return the value returned by
2731 handle_single_display_spec, not just 1 or zero.
2732 (handle_single_display_spec): If the display spec is of the form
2733 `(space ...)', and specifies display in the text area, return 2
2735 (try_cursor_movement): Check for the need to scroll more
2736 accurately, and prefer exact match for point under bidi.
2737 Don't advance `row' beyond the last row of the window.
2739 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2740 into disp_prop; all users changed.
2742 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2743 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2744 for the text covered by the display property.
2746 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2748 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2749 Change return value to nil.
2750 (Frecord_buffer): Delete unused function.
2752 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2754 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2755 buffers, return left-to-right.
2756 (set_cursor_from_row): Consider candidate row a win if its glyph
2757 represents a newline and point is on that newline. Fixes cursor
2758 positioning on the newline at EOL of R2L text within L2R
2759 paragraph, and vice versa.
2760 (try_cursor_movement): Check continued rows, in addition to
2761 continuation rows. Fixes unwarranted scroll when point enters a
2762 continued line of R2L text within an L2R paragraph, or vice versa.
2763 (cursor_row_p): Consider the case of point being equal to
2764 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2765 from the end of a short line to the beginning of a continued line
2766 of R2L text within L2R paragraph.
2767 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2768 composed characters.
2770 * bidi.c (bidi_check_type): Use xassert.
2771 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2774 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2776 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2779 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2781 * nsfont.m (ns_otf_to_script): Fix typo.
2783 2011-08-22 Kenichi Handa <handa@m17n.org>
2785 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2786 extra slot even if the purpose is char-code-property-table.
2788 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2790 * xdisp.c (redisplay_window): When computing centering_position,
2791 account for the height of the header line. (Bug#8874)
2793 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2794 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2795 candidate is selected by the mouse, and that candidate has a
2796 composed character under the mouse.
2798 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2799 coordinates reported by pos-visible-in-window-p for a composed
2800 character in column zero.
2802 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2804 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2806 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2808 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2809 consider it a hit if to_charpos is anywhere in the range of the
2810 composed buffer positions.
2812 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2814 * image.c (gif_load): Don't assume that each subimage has the same
2815 dimensions as the base image. Handle disposal method that is
2816 "undefined" by the gif spec (Bug#9335).
2818 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2820 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2821 (Fcondition_case): Document `debug' symbol in error handler.
2823 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2825 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2826 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2827 from an Org mode buffer to a Speedbar frame.
2829 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2830 a composition, take its buffer position from IT->cmp_it.charpos.
2831 Fixes cursor positioning at the beginning of a line that begins
2832 with a composed character.
2834 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2836 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2837 character bidirectional type, use STRONG_L instead. Fixes crashes
2838 in a buffer produced by `describe-categories'.
2840 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2841 members before the level stack, so they would be saved and
2842 restored when copying iterator state. Fixes incorrect reordering
2843 around TABs covered by display properties.
2845 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2847 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2849 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2851 * eval.c (internal_condition_case, internal_condition_case_1)
2852 (internal_condition_case_2, internal_condition_case_n):
2853 Remove unnecessary aborts (Bug#9081).
2855 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2857 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2858 has no `load' handler, try opening the file locally. (Bug#9311)
2860 2011-08-16 Ken Brown <kbrown@cornell.edu>
2862 * gmalloc.c: Expand comment.
2864 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2866 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2867 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2869 2011-08-16 Ken Brown <kbrown@cornell.edu>
2871 Fix memory allocation problems in Cygwin build (Bug#9273).
2873 * unexcw.c ( __malloc_initialized): Declare external variable.
2874 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2876 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2878 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2880 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2882 [CYGWIN] (special_realloc): New function.
2883 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2884 requests to realloc storage in the static heap.
2886 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2888 * bidi.c (bidi_initialize): Remove unused local.
2890 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2893 * biditype.h: Remove file.
2894 * makefile.w32-in ($(BLD)/bidi.$(O)):
2895 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2897 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2899 * chartab.c: Improve commentary for the uniprop_table API.
2901 * bidi.c (bidi_paragraph_init): Support zero value of
2902 bidi_ignore_explicit_marks_for_paragraph_level.
2903 (bidi_initialize): Use uniprop_table instead of including
2904 biditype.h and bidimirror.h.
2906 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2907 coordinates of the iterator when restoring from ppos_it.
2910 2011-08-14 Kenichi Handa <handa@m17n.org>
2912 * process.c (create_process): Call setup_process_coding_systems
2913 after the pid of the process is set to -1 (Bug#8162).
2915 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2917 * xdisp.c (move_it_in_display_line_to): Don't invoke
2918 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2919 ppos_it. Fixes vertical cursor motion when line beginning is
2920 covered by an image. (Bug#9296)
2922 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2924 * nsterm.h (ns_run_ascript): Declare.
2925 (NSAPP_DATA2_RUNASSCRIPT): Define.
2927 * nsfns.m (as_script, as_result, as_status): New static variables.
2928 (ns_run_ascript): New function.
2929 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2930 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2931 the event loop. Get status from as_status (Bug#7276).
2933 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2934 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2935 the event loop (Bug#7276).
2937 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2939 * gnutls.c (QCgnutls_bootprop_priority)
2940 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2941 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2942 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2943 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2944 (QCgnutls_bootprop_verify_hostname_error)
2945 (QCgnutls_bootprop_callbacks_verify): Rename from
2946 Qgnutls_bootprop_..., all uses changed.
2948 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2951 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2953 * xfaces.c (Qframe_set_background_mode): Now static.
2954 * dispextern.h (Qframe_set_background_mode): Remove decl.
2956 * process.c (Fnetwork_interface_info): Declare local only if needed.
2958 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2960 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2961 (Fnetwork_interface_list): Allocate in increments of bytes instead
2962 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2963 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2965 (struct ifflag_def): notrailers is smart on OSX.
2966 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2967 Get hardware address with getifaddrs if available.
2969 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2971 * xdisp.c (iterate_out_of_display_property): xassert that
2972 IT->position is set to within IT->object's boundaries. Break from
2973 the loop as soon as EOB is reached; avoids infloops in redisplay
2974 when IT->position is set up wrongly due to some bug.
2975 Set IT->current to match the bidi iterator unconditionally.
2976 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2977 entry. Force push_it to save on the stack the current
2978 buffer/string position, to be restored by pop_it. Fix flags in
2979 the iterator structure wrt the object coming from a display
2980 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2981 properties. (Bug#9284)
2983 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2985 * fontset.c (fontset_get_font_group): Add proper type checks.
2988 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2990 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2991 and LC_VERSION_MIN_MACOSX.
2992 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2993 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2995 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2997 * xdisp.c (forward_to_next_line_start): Allow to use the
2998 no-display-properties-and-no-overlays under bidi display.
2999 Set disp_pos in the bidi iterator to avoid searches for display
3000 properties and overlays.
3002 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3004 * editfns.c (Fset_time_zone_rule): Document relationship with the
3007 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3008 the font entity extracted from the cache (Bug#8109).
3010 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3012 * composite.c (autocmp_chars): Don't reset point. That is done by
3013 restore_point_unwind (Bug#5984).
3015 2011-08-07 Juri Linkov <juri@jurta.org>
3017 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3018 to show the arg `TIME' instead of `TIMEVAL'.
3020 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3022 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3023 display property strides EOL and includes a newline, as in
3024 longlines-mode. (Bug#9254)
3025 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3026 word-wrap under bidirectional display. (Bug#9224)
3028 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3029 is non-zero, even if the data buffer is NULL. Fixes a crash in
3030 vertical-motion with longlines-mode. (Bug#9254)
3032 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3034 * bidi.c <bidi_cache_total_alloc>: Now static.
3035 (bidi_initialize): Initialize bidi_cache_total_alloc.
3037 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3040 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3041 amount allocated this far in `bidi_cache_total_alloc'.
3042 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3043 non-zero, only free the data buffer without restoring the cache
3044 contents. All callers changed.
3046 * dispextern.h (bidi_unshelve_cache): Update prototype.
3048 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3049 (move_it_in_display_line, move_it_to)
3050 (move_it_vertically_backward, move_it_by_lines): Replace the call
3051 to xfree to an equivalent call to bidi_unshelve_cache.
3052 (move_it_in_display_line_to): Fix logic of returning
3053 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3055 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3057 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3058 came from a string character with a `cursor' property. (Bug#9229)
3060 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3062 * Makefile.in (LIB_PTHREAD): New variable.
3063 (LIBES): Add LIB_PTHREAD (Bug#9216).
3065 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3066 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3068 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3070 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3072 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3074 * xterm.c (x_find_topmost_parent): New function.
3075 (x_set_frame_alpha): Find topmost parent window with
3076 x_find_topmost_parent and set the property there also (bug#9181).
3077 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3079 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3081 * callproc.c (Fcall_process): Avoid vfork clobbering
3082 the local vars buffer, coding_systems, current_dir.
3084 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3086 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3088 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3090 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3091 so that it is not optimized away.
3093 * xdisp.c (compute_display_string_pos): Remove unused local.
3095 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3097 Fix slow cursor motion and scrolling in large buffers with
3098 selective display, like Org Mode buffers. (Bug#9218)
3100 * dispextern.h (struct bidi_it): New member disp_prop_p.
3102 * xdisp.c: Remove one-slot cache of display string positions.
3103 (compute_display_string_pos): Accept an additional argument
3104 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3105 for a display string or property. If found, set DISP_PROP_P
3108 * bidi.c (bidi_fetch_char): Accept an additional argument
3109 DISP_PROP_P, and pass it to compute_display_string_pos.
3110 Only handle text covered by a display string if DISP_PROP_P is returned
3111 non-zero. All callers of bidi_fetch_char changed.
3113 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3115 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3117 2010-12-03 Don March <don@ohspite.net>
3119 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3120 last character M-[char] is translated to ESC [char] (bug#7541).
3122 2011-08-02 Kenichi Handa <handa@m17n.org>
3124 * lisp.h (uniprop_table): Extern it.
3126 * chartab.c (uniprop_table): Make it non-static.
3128 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3130 * xdisp.c (forward_to_next_line_start): Accept additional argument
3131 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3133 (reseat_at_next_visible_line_start): Use the bidi iterator state
3134 returned by forward_to_next_line_start to restore the state of
3135 it->bidi_it after backing up to previous newline. (Bug#9212)
3137 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3139 * regex.c (re_comp): Protoize.
3140 (re_exec): Fix return type.
3141 (regexec): Fix type of `ret'. (Bug#9203)
3143 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3145 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3146 This is needed if max-image-size is a floating-point number.
3148 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3150 * print.c (print_object): Print empty symbol as ##.
3152 * lread.c (read1): Read ## as empty symbol.
3154 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3156 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3157 setting frame foreground color (Bug#9175).
3158 (x_set_background_color): Likewise.
3160 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3161 contents (Bug#9176).
3162 (EmacsTooltip -init): Remove bezels and add shadows to
3165 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3166 or scroll bar (Bug#8470).
3168 * nsfont.m (nsfont_open): Remove assignment to voffset and
3169 unnecessary vars hshink, expand, hd, full_height, min_height.
3170 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3172 * nsterm.h (nsfont_info): Remove voffset field.
3174 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3176 Implement strike-through and overline on NextStep (Bug#8863).
3178 * nsfont.m (nsfont_open): Use underline position provided by font,
3179 instead of hard-coded value of 2.
3180 (nsfont_draw): Call ns_draw_text_decoration instead.
3182 * nsterm.h: Add declaration for ns_draw_text_decoration.
3184 * nsterm.m (ns_draw_text_decoration): New function for drawing
3185 underline, overline, and strike-through.
3186 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3187 ns_draw_text_decoration. Change treatment of cursor drawing to
3188 accommodate underlining, etc.
3190 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3192 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3195 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3197 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3198 Without this fix, if a signal arrives just after memory fills up,
3199 'malloc' might be invoked reentrantly.
3201 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3202 In other words, assume that every image size is allowed, on non-X
3203 hosts. This assumption is probably wrong, but it lets Emacs compile.
3205 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3207 * regex.c (re_iswctype): Convert return values to boolean.
3209 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3211 * xdisp.c (compute_display_string_pos): Don't use cached display
3212 string position if the buffer had its restriction changed.
3215 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3217 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3219 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3221 Integer signedness and overflow and related fixes. (Bug#9079)
3223 * bidi.c: Integer size and overflow fixes.
3224 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3225 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3226 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3227 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3228 (bidi_find_other_level_edge):
3229 Use ptrdiff_t instead of EMACS_INT where either will do.
3230 This works better on 32-bit hosts configured --with-wide-int.
3231 (bidi_cache_ensure_space): Check for size-calculation overflow.
3232 Use % rather than repeated addition, for better worst-case speed.
3233 Don't set bidi_cache_size until after xrealloc returns, because it
3235 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3236 (bidi_cache_ensure_space): Also check that the bidi cache size
3237 does not exceed that of the largest Lisp string or buffer. See Eli
3238 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3240 * alloc.c (__malloc_size_t): Remove.
3241 All uses replaced by size_t. See Andreas Schwab's note
3242 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3244 * image.c: Improve checking for integer overflow.
3245 (check_image_size): Assume that f is nonnull, since
3246 it is always nonnull in practice. This is one less thing to
3247 worry about when checking for integer overflow later.
3248 (x_check_image_size): New function, which checks for integer
3249 overflow issues inside X.
3250 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3251 This removes the need for a memory_full check.
3252 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3253 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3254 (xbm_read_bitmap_data): Change locals back to 'int', since
3255 their values must fit in 'int'.
3256 (xpm_load_image, png_load, tiff_load):
3257 Invoke x_create_x_image_and_pixmap earlier,
3258 to avoid much needless work if the image is too large.
3259 (tiff_load): Treat overly large images as if
3260 x_create_x_image_and_pixmap failed, not as malloc failures.
3261 (gs_load): Use x_check_image_size.
3263 * gtkutil.c: Omit integer casts.
3264 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3265 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3267 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3269 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3270 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3271 would wrongly return t on a 64-bit host.
3273 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3274 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3275 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3276 and therefore cause GCC to emit a bogus diagnostic in some cases.
3278 * image.c: Integer signedness and overflow and related fixes.
3279 This is not an exhaustive set of fixes, but it's time to
3280 record what I've got.
3281 (lookup_pixel_color, check_image_size): Remove redundant decls.
3282 (check_image_size): Don't assume that arbitrary EMACS_INT values
3283 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3284 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3285 (tiff_load, imagemagick_load_image):
3286 Check for overflow in size calculations.
3287 (x_create_x_image_and_pixmap): Remove unnecessary test for
3288 xmalloc returning NULL; that can't happen.
3289 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3290 (xpm_color_bucket): Use better integer hashing function.
3291 (xpm_cache_color): Don't possibly over-allocate memory.
3292 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3293 (gif_memory_source):
3294 Use ptrdiff_t, not int or size_t, to record sizes.
3295 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3296 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3297 either works, as we prefer signed integers.
3298 (tiff_read_from_memory, tiff_write_from_memory):
3299 Return tsize_t, not size_t, since that's what the TIFF API wants.
3300 (tiff_read_from_memory): Don't fail simply because the read would
3301 go past EOF; instead, return a short read.
3302 (tiff_load): Omit no-longer-needed casts.
3303 (Fimagemagick_types): Don't assume size fits into 'int'.
3305 Improve hashing quality when configured --with-wide-int.
3306 * fns.c (hash_string): New function, taken from sxhash_string.
3307 Do not discard information about ASCII character case; this
3308 discarding is no longer needed.
3309 (sxhash-string): Use it. Change sig to match it. Caller changed.
3310 * lisp.h: Declare it.
3311 * lread.c (hash_string): Remove, since we now use fns.c's version.
3312 The fns.c version returns a wider integer if --with-wide-int is
3313 specified, so this should help the quality of the hashing a bit.
3315 * emacs.c: Integer overflow minor fix.
3316 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3317 Define only if GNU_LINUX.
3318 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3320 * dispnew.c: Integer signedness and overflow fixes.
3321 Remove unnecessary forward decls, that were a maintenance hassle.
3322 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3324 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3325 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3326 (prepare_desired_row, line_draw_cost):
3327 Use int, not unsigned, where either works.
3328 (save_current_matrix, restore_current_matrix):
3329 Use ptrdiff_t, not size_t, where either works.
3330 (init_display): Check for overflow more accurately, and without
3331 relying on undefined behavior.
3333 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3334 Remove, replacing with the new symbols in lisp.h. All uses changed.
3335 * fileio.c (make_temp_name):
3336 * filelock.c (lock_file_1, lock_file):
3337 * xdisp.c (message_dolog):
3338 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3339 Use pMd etc. instead.
3340 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3341 replacing the pWIDE etc. symbols removed from editfns.c.
3343 * keyboard.h (num_input_events): Now uintmax_t.
3344 This is (very slightly) less likely to mess up due to wraparound.
3347 * buffer.c: Integer signedness fixes.
3348 (alloc_buffer_text, enlarge_buffer_text):
3349 Use ptrdiff_t rather than size_t when either will do, as we prefer
3352 * alloc.c: Integer signedness and overflow fixes.
3353 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3354 (__malloc_size_t): Default to size_t, not to int.
3355 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3356 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3357 Prefer ptrdiff_t to size_t when either would do, as we prefer
3359 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3360 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3361 Now const. Initialize with values that are in range even if char
3363 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3364 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3365 These functions do the right thing with sizes > 2**32.
3366 (check_depth): Now ptrdiff_t, not int.
3367 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3368 Adjust to new way of storing sizes. Check for size overflow bugs
3370 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3371 slightly wrong anyway, as it missed one instance of
3372 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3373 (refill_memory_reserve): Omit needless cast to size_t.
3374 (mark_object_loop_halt): Mark as externally visible.
3376 * xselect.c: Integer signedness and overflow fixes.
3377 (Fx_register_dnd_atom, x_handle_dnd_message):
3378 Use ptrdiff_t, not size_t, since we prefer signed.
3379 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3380 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3381 x_dnd_atoms_size and x_dnd_atoms_length.
3383 * doprnt.c: Prefer signed to unsigned when either works.
3385 * doprnt.c (doprnt):
3387 * xdisp.c (vmessage):
3388 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3389 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3390 prefer signed arithmetic to avoid comparison confusion.
3391 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3392 but is a bit tricky.
3394 Assume freestanding C89 headers, string.h, stdlib.h.
3395 * data.c, doprnt.c, floatfns.c, print.c:
3396 Include float.h unconditionally.
3397 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3398 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3399 * regex.c: Likewise for stddef.h, string.h.
3400 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3401 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3402 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3403 (STDC_HEADERS): Remove obsolete defines.
3404 * sysdep.c: Include limits.h unconditionally.
3406 Assume support for memcmp, memcpy, memmove, memset.
3407 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3408 * regex.c (memcmp, memcpy):
3409 Remove; we assume C89 now.
3411 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3412 (__malloc_safe_bcopy): Remove; no longer needed.
3414 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3415 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3416 well either way, and we prefer signed to unsigned.
3418 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3420 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3421 closes the connection while we're reading (bug#9182).
3423 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3425 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3426 are specified (Bug#9168).
3428 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3430 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3431 Found by GCC static checking and --with-wide-int on a 32-bit host.
3433 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3435 * xdisp.c (compute_display_string_pos): Fix logic of caching
3436 previous display string position. Initialize cached_prev_pos to
3437 -1. Fixes slow-down at the beginning of a buffer.
3439 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3441 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3442 for attrs[LFACE_FONTSET_INDEX].
3444 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3446 * xml.c (parse_region): Remove unused local
3447 that was recently introduced.
3449 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3451 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3452 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3454 * xdisp.c (move_it_in_display_line_to): Record the best matching
3455 position for TO_CHARPOS while scanning the line, and restore it on
3456 exit if none of the characters scanned was an exact match.
3457 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3458 when exact match is impossible due to invisible text, and the
3459 lines are truncated.
3461 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3463 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3466 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3468 Fix a significant slow-down of cursor motion with C-n, C-p,
3469 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3470 auto-repeat under bidi redisplay in fontified buffers.
3471 * xdisp.c (compute_stop_pos_backwards): New function.
3472 (next_element_from_buffer): Call compute_stop_pos_backwards to
3473 find a suitable prev_stop when we find ourselves before
3475 (reseat): Don't look for prev_stop, as that could mean a very long
3477 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3478 <cached_disp_overlay_modiff>: Cache for last found display string
3480 (compute_display_string_pos): Return the cached position if asked
3481 about the same buffer in the same area of character positions, and
3482 the buffer wasn't changed since the time the display string
3483 position was cached.
3485 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3487 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3488 is an integer, which is important for empty lines. (Bug#9149)
3490 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3492 * frame.c (Fmodify_frame_parameters): In tty case, update the
3493 default face if necessary (Bug#4238).
3495 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3497 * editfns.c (Fstring_to_char): No need to explain what a character
3498 is in the docstring (Bug#6576).
3500 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3502 * xml.c (parse_region): Make sure we always return a tree.
3504 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3506 * xml.c (parse_region): If a document contains only comments,
3509 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3511 * xml.c (make_dom): Return comments, too.
3513 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3516 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3517 and the surrounding thread.
3518 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3519 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3520 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3522 * s/openbsd.h (BROKEN_SIGIO): Define.
3523 * unexelf.c (unexec) [__OpenBSD__]:
3524 Don't update the .mdebug section of the Alpha COFF symbol table.
3526 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3528 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3531 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3533 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3534 This fixes some race conditions on the permissions of any newly
3537 * alloc.c (valid_pointer_p): Use pipe, not open.
3538 This fixes some permissions issues when debugging.
3540 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3541 If fchown fails to set both uid and gid, try to set just gid,
3542 as that is sometimes allowed. Adjust the file's mode to eliminate
3543 setuid or setgid bits that are inappropriate if fchown fails.
3545 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3547 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3548 to compare Lisp_Objects.
3549 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3550 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3551 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3553 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3555 * lread.c (read_integer): Unread even EOF character.
3556 (read1): Likewise. Properly record start position of symbol.
3558 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3559 symbol character follows.
3561 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3563 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3564 This works around a problem with the previous change to Fcopy_file.
3565 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3566 and without this change, GCC might complain about discarding
3567 fchown's return value.
3569 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3571 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3573 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3575 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3577 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3579 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3580 it's used from the C level.
3582 * process.c: Use the same condition for POLL_FOR_INPUT in both
3583 keyboard.c and process.c (bug#1858).
3585 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3587 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3588 (Fgnutls_boot): Use it.
3590 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3592 * doc.c (Fsubstitute_command_keys): Revert last change.
3594 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3596 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3597 quotes the next character, and doesn't affect other longer
3598 sequences (bug#8935).
3600 * lread.c (syms_of_lread): Clarify that is isn't only
3601 `eval-buffer' and `eval-defun' that's affected by
3602 `lexical-binding' (bug#8460).
3604 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3606 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3607 bidi redisplay when a line includes both an image and is truncated.
3609 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3611 Fix minor problems found by static checking.
3612 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3613 (elsz): Now a signed constant, not a size_t var. We prefer signed
3614 types to unsigned, to avoid integer comparison confusion. Without
3615 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3616 "cannot optimize loop, the loop counter may overflow", a symptom
3618 * indent.c (Fvertical_motion): Mark locals as initialized.
3619 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3621 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3623 * search.c (Fre_search_backward): Mention `case-fold-search' in
3624 all the re_search_* functions (bug#8138).
3626 * keyboard.c (Fopen_dribble_file): Document when the file is
3629 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3631 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3634 Support bidi reordering of display and overlay strings.
3635 * xdisp.c (compute_display_string_pos)
3636 (compute_display_string_end): Accept additional argument STRING.
3637 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3638 (reseat_to_string): Initialize bidi_it->string.s and
3639 bidi_it->string.schars.
3640 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3641 NULL (avoids a crash in bidi_paragraph_init).
3642 Initialize itb.string.lstring.
3643 (init_iterator): Call bidi_init_it only of a valid
3644 buffer position was specified. Initialize paragraph_embedding to
3646 (reseat_to_string): Initialize the bidi iterator.
3647 (display_string): If we need to ignore text properties of
3648 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3649 original value of -1 will not work with bidi.)
3650 (compute_display_string_pos): First arg is now struct
3651 `text_pos *'; all callers changed. Support display properties on
3653 (compute_display_string_end): Support display properties on Lisp
3655 (init_iterator, reseat_1, reseat_to_string): Initialize the
3656 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3657 when iterating on a string not from display properties).
3658 (compute_display_string_pos, compute_display_string_end):
3659 Fix calculation of the object to scan. Fixes an error when using
3661 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3662 base_level_stop; instead, set base_level_stop to BEGV.
3663 Fixes crashes in vertical-motion.
3664 (next_element_from_buffer): Improve commentary for when
3665 the iterator is before prev_stop.
3666 (init_iterator): Initialize bidi_p from the default value of
3667 bidi-display-reordering, not from buffer-local value. Use the
3668 buffer-local value only if initializing for buffer iteration.
3669 (handle_invisible_prop): Support invisible properties on strings
3670 that are being bidi-reordered.
3671 (set_iterator_to_next): Support bidi reordering of C strings and
3673 (next_element_from_string): Support bidi reordering of Lisp
3675 (handle_stop_backwards): Support Lisp strings as well.
3676 (display_string): Support display of R2L glyph rows.
3677 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3678 (init_iterator): Don't initialize it->bidi_p for strings
3680 (reseat_to_string): Initialize it->bidi_p for strings here.
3681 (next_element_from_string, next_element_from_c_string)
3682 (next_element_from_buffer): Add xassert's for correspondence
3683 between IT's object being iterated and it->bidi_it.string
3685 (face_before_or_after_it_pos): Support bidi iteration.
3686 (next_element_from_c_string): Handle the case of the first string
3687 character that is not the first one in the visual order.
3688 (get_visually_first_element): New function, refactored from common
3689 parts of next_element_from_buffer, next_element_from_string, and
3690 next_element_from_c_string.
3691 (tool_bar_lines_needed, redisplay_tool_bar)
3692 (display_menu_bar): Force left-to-right direction. Add a FIXME
3693 comment for making that be controlled by a user option.
3694 (push_it, pop_it): Save and restore the state of the
3695 bidi iterator. Save and restore the bidi_p flag.
3696 (pop_it): Iterate out of display property for string iteration as
3698 (iterate_out_of_display_property): Support iteration over strings.
3699 (handle_single_display_spec): Set up it->bidi_it for iteration
3700 over a display string, and call bidi_init_it.
3701 (handle_single_display_spec, next_overlay_string)
3702 (get_overlay_strings_1, push_display_prop): Set up the bidi
3703 iterator for displaying display or overlay strings.
3704 (forward_to_next_line_start): Don't use the shortcut if
3706 (back_to_previous_visible_line_start): If handle_display_prop
3707 pushed the iterator stack, restore the internal state of the bidi
3708 iterator by calling bidi_pop_it same number of times.
3709 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3710 and we are bidi-iterating, don't decrement the iterator position;
3711 instead, set the first_elt flag in the bidi iterator, to produce
3713 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3714 (push_display_prop): xassert that we are iterating a buffer.
3715 (push_it, pop_it): Save and restore paragraph_embedding member.
3716 (handle_single_display_spec, next_overlay_string)
3717 (get_overlay_strings_1, reseat_1, reseat_to_string)
3718 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3719 correctly. Don't assume unibyte strings are not bidi-reordered.
3720 (compute_display_string_pos)
3721 (compute_display_string_end): Fix handling the case of C string.
3722 (push_it, pop_it): Save and restore from_disp_prop_p.
3723 (handle_single_display_spec, push_display_prop): Set the
3724 from_disp_prop_p flag.
3725 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3726 (pop_it): Call iterate_out_of_display_property only if we are
3727 popping after iteration over a string that came from a display
3728 property. Fix a typo in popping stretch info. Add an assertion
3729 for verifying that the iterator position is in sync with the bidi
3731 (handle_single_display_spec, get_overlay_strings_1)
3732 (push_display_prop): Fix initialization of paragraph direction for
3733 string when that of the parent object is not yet determined.
3734 (reseat_1): Call bidi_init_it to resync the bidi
3735 iterator with IT's position. (Bug#7616)
3736 (find_row_edges): If ROW->start.pos gives position
3737 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3738 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3739 Reset the from_disp_prop_p flag.
3740 (SAVE_IT, RESTORE_IT): New macros.
3741 (pos_visible_p, face_before_or_after_it_pos)
3742 (back_to_previous_visible_line_start)
3743 (move_it_in_display_line_to, move_it_in_display_line)
3744 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3745 (try_scrolling, redisplay_window, display_line): Use them when
3746 saving a temporary copy of the iterator and restoring it back.
3747 (back_to_previous_visible_line_start, reseat_1)
3748 (init_iterator): Empty the bidi cache "stack".
3749 (move_it_in_display_line_to): If iterator ended up at
3750 EOL, but we never saw any buffer positions smaller than
3751 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3752 motion in bidi-reordered lines.
3753 (move_it_in_display_line_to): Record prev_method and prev_pos
3754 immediately before the call to set_iterator_to_next. Fixes cursor
3755 motion in bidi-reordered lines with stretch glyphs and strings
3756 displayed in margins. (Bug#8133) (Bug#8867)
3757 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3759 (pos_visible_p): Support positions in bidi-reordered lines.
3760 Save and restore bidi cache.
3762 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3763 (bidi_paragraph_info): Delete unused struct.
3764 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3765 (bidi_cache_start): New variable.
3766 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3768 (bidi_cache_fetch_state, bidi_cache_search)
3769 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3770 (bidi_cache_find, bidi_peek_at_next_level)
3771 (bidi_level_of_next_char, bidi_find_other_level_edge)
3772 (bidi_move_to_visually_next): Compare cache index with
3773 bidi_cache_start rather than with zero.
3774 (bidi_fetch_char): Accept new argument STRING; all callers
3775 changed. Support iteration over a string. Support strings with
3776 display properties. Support unibyte strings. Fix the type of
3777 `len' according to what STRING_CHAR_AND_LENGTH expects.
3778 (bidi_paragraph_init, bidi_resolve_explicit_1)
3779 (bidi_resolve_explicit, bidi_resolve_weak)
3780 (bidi_level_of_next_char, bidi_move_to_visually_next):
3781 Support iteration over a string.
3782 (bidi_set_sor_type, bidi_resolve_explicit_1)
3783 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3784 can now be zero (for strings); special values 0 and -1 were
3785 changed to -1 and -2, respectively.
3786 (bidi_char_at_pos): New function.
3787 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3788 Call it instead of FETCH_MULTIBYTE_CHAR.
3789 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3790 initialized to valid values.
3791 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3793 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3794 the test for valid cached positions. Fix the logic for looking up
3795 the sentinel state in the cache. GCPRO the Lisp string we are
3797 (bidi_push_it, bidi_pop_it): New functions.
3798 (bidi_initialize): Initialize the bidi cache start stack pointer.
3799 (bidi_cache_ensure_space): New function, refactored from part of
3800 bidi_cache_iterator_state. Don't assume the required size is just
3801 one BIDI_CACHE_CHUNK away.
3802 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3803 (bidi_count_bytes, bidi_char_at_pos): New functions.
3804 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3805 always valid if bidi_cache_idx is valid.
3806 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3807 is valid if it's going to be used.
3808 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3809 (bidi_cache_fetch_state, bidi_cache_search)
3810 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3811 (bidi_cache_iterator_state, bidi_cache_find)
3812 (bidi_find_other_level_edge, bidi_cache_start_stack):
3813 All variables related to cache indices are now EMACS_INT.
3815 * dispextern.h (struct bidi_string_data): New structure.
3816 (struct bidi_it): New member `string'. Make flag members be 1-bit
3817 fields, and put them last in the struct.
3818 (compute_display_string_pos, compute_display_string_end):
3820 (bidi_push_it, bidi_pop_it): Add prototypes.
3821 (struct iterator_stack_entry): New members bidi_p,
3822 paragraph_embedding, and from_disp_prop_p.
3823 (struct it): Member bidi_p is now a bit field 1 bit wide.
3824 (bidi_shelve_cache, bidi_unshelve_cache):
3827 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3828 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3829 and vector-like objects.
3831 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3832 cache around display iteration.
3834 * window.c (Fwindow_end, window_scroll_pixel_based)
3835 (displayed_window_lines, Frecenter): Save and restore the bidi
3836 cache around display iteration.
3838 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3840 * editfns.c (Fdelete_region): Clarify the use of the named
3841 parameters (bug#6788).
3843 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3845 * indent.c (Fvertical_motion): Set and restore w->pointm when
3846 saving and restoring the window's buffer (Bug#9006).
3848 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3850 * editfns.c (Fstring_to_char): Clarify just what is returned
3851 (bug#6576). Text by Eli Zaretskii.
3853 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3855 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3857 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3859 * buffer.c (mmap_find): Fix a typo.
3861 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3863 Fix execution of x selection hooks.
3864 * xselect.c (Qx_lost_selection_functions)
3865 (Qx_sent_selection_functions): New vars.
3866 (syms_of_xselect): DEFSYM them.
3867 (x_handle_selection_request): Pass Qx_sent_selection_functions
3868 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3869 (x_handle_selection_clear,x_clear_frame_selections):
3870 Pass Qx_lost_selection_functions rather than
3871 Vx_lost_selection_functions to Frun_hook_with_args.
3873 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3875 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3876 The old code sometimes used this field without initializing it.
3878 * alloc.c (gc_sweep): Don't read past end of array.
3879 In theory, the old code could also have corrupted Emacs internals,
3880 though it'd be very unlikely.
3882 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3884 * character.c (Fcharacterp): Don't advertise optional ignored
3885 argument. (Bug#4026)
3887 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3889 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3892 * window.c (Fset_window_start): Doc fix (bug#4199).
3893 (Fset_window_hscroll): Ditto.
3895 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3897 Fix minor new problems caught by GCC 4.6.1.
3898 * term.c (init_tty): Remove unused local.
3899 * xsettings.c (store_monospaced_changed): Define this function only
3900 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3903 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3905 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3907 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3909 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3910 are the mini-buffer and the echo area (bug#3320).
3912 * term.c (init_tty): Remove support for supdup, c10 and perq
3913 terminals, which are no longer supported (bug#1482).
3915 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3917 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3919 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3921 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3922 for non-popups (Bug#3642).
3924 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3926 * alloc.c (reset_malloc_hooks): Protoize.
3927 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3928 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3929 * cm.c (losecursor): Likewise.
3930 * data.c (fmod): Likewise.
3931 * dispnew.c (swap_glyphs_in_rows): Likewise.
3932 * emacs.c (memory_warning_signal): Likewise.
3933 * floatfns.c (float_error): Likewise.
3934 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3935 (otf_open, font_otf_capability, generate_otf_features)
3936 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3938 * image.c (pbm_read_file): Likewise.
3939 * indent.c (string_display_width): Likewise.
3940 * intervals.c (check_for_interval, search_for_interval)
3941 (inc_interval_count, count_intervals, root_interval)
3942 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3943 * lread.c (defalias): Likewise.
3944 * ralloc.c (r_alloc_check): Likewise.
3945 * regex.c (set_image_of_range_1, set_image_of_range)
3946 (regex_grow_registers): Likewise.
3947 * sysdep.c (strerror): Likewise.
3948 * termcap.c (valid_filename_p, tprint, main): Likewise.
3949 * tparam.c (main): Likewise.
3950 * unexhp9k800.c (run_time_remap, save_data_space)
3951 (update_file_ptrs, read_header, write_header, calculate_checksum)
3952 (copy_file, copy_rest, display_header): Likewise.
3953 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3955 * xdisp.c (check_it): Likewise.
3956 * xfaces.c (register_color, unregister_color, unregister_colors):
3958 * xfns.c (print_fontset_result): Likewise.
3959 * xrdb.c (member, fatal, main): Likewise.
3961 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3963 Fix minor problems found by static checking (Bug#9031).
3964 * chartab.c (char_table_set_range, map_sub_char_table):
3965 Remove unused locals.
3966 (uniprop_table): Now static.
3967 * composite.c (_work_char): Remove unused static var.
3969 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3971 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3973 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3975 * gtkutil.c (qttip_cb): Remove code without function.
3977 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3979 * w32.c (pthread_sigmask): New stub.
3981 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3983 Use pthread_sigmask, not sigprocmask (Bug#9010).
3984 sigprocmask is portable only for single-threaded applications, and
3985 Emacs can be multi-threaded when it uses GTK.
3986 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3988 * callproc.c (Fcall_process):
3989 * process.c (create_process):
3990 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3991 Use pthread_sigmask, not sigprocmask.
3993 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3995 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3996 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3999 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4001 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4002 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4003 (xg_hide_tooltip): Fix comment.
4005 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4006 in registerServicesMenuSendTypes.
4007 (validRequestorForSendType): Don't check ns_return_types.
4009 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4012 2011-07-08 Jason Rumney <jasonr@gnu.org>
4014 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4015 SH_SHOW for hidden windows (Bug#5482).
4017 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4018 frame struct members of non-existent frames (Bug#6284).
4020 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4022 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4023 variable firstTime not needed on OSX >= 10.6.
4024 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4025 >= 10.5. Use setKnobProportion, setDoubleValue.
4027 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4028 (MAC_OS_X_VERSION_10_5): Define if not defined.
4029 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4030 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4031 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4033 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4034 cString and lossyCString on OSX >= 10.4
4036 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4037 sizeToFit on OSX >= 10.2.
4039 * nsimage.m (allocInitFromFile): Don't use deprecated method
4040 bestRepresentationForDevice on OSX >= 10.6.
4042 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4045 * emacs.c: Declare unexec_init_emacs_zone.
4047 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4049 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4051 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4052 on svcsMenu (Bug#8842).
4054 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4056 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4058 * nsterm.m (QUTF8_STRING): Declare.
4059 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4060 (validRequestorForSendType): Return type is (id).
4061 Change indexOfObjectIdenticalTo to indexOfObject.
4062 Check if we have local selection before returning self (Bug#8842).
4063 (writeSelectionToPasteboard): Put local selection into paste board
4064 if we have a local selection (Bug#8842).
4065 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4067 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4068 (ns_get_local_selection): Declare.
4070 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4072 * keymap.c (describe_map_tree): Don't insert a double newline at
4073 the end of the buffer (bug#1169) and return whether we inserted
4076 * callint.c (Fcall_interactively): Change "reading args" to
4077 "providing args" to try to clarify what it does (bug#1010).
4079 2011-07-07 Kenichi Handa <handa@m17n.org>
4081 * composite.c (composition_compute_stop_pos): Ignore a static
4082 composition starting before CHARPOS (Bug#8915).
4084 * xdisp.c (handle_composition_prop): Likewise.
4086 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4088 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4091 2011-07-07 Kenichi Handa <handa@m17n.org>
4093 * character.h (unicode_category_t): New enum type.
4095 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4096 (Qchar_code_property_table): New variable.
4097 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4098 (UNIPROP_COMPRESSED_FORM_P): New macros.
4099 (char_table_ascii): Uncompress the compressed values.
4100 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4101 Uncompress the compressed values.
4102 (sub_char_table_ref_and_range): Likewise.
4103 (char_table_ref_and_range): Uncompress the compressed values.
4104 (sub_char_table_set): New arg is_uniprop. Callers changed.
4105 Uncompress the compressed values.
4106 (sub_char_table_set_range): Args changed. Callers changed.
4107 (char_table_set_range): Adjuted for the above change.
4108 (map_sub_char_table): Delete args default_val and parent. Add arg
4109 top. Give decoded values to a Lisp function.
4110 (map_char_table): Adjust for the above change. Give decoded
4111 values to a Lisp function. Gcpro more variables.
4112 (uniprop_table_uncompress)
4113 (uniprop_decode_value_run_length): New functions.
4114 (uniprop_decoder, uniprop_decoder_count): New variables.
4115 (uniprop_get_decoder, uniprop_encode_value_character)
4116 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4118 (uniprop_encoder, uniprop_encoder_count): New variables.
4119 (uniprop_get_encoder, uniprop_table)
4120 (Funicode_property_table_internal, Fget_unicode_property_internal)
4121 (Fput_unicode_property_internal): New functions.
4122 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4123 Sunicode_property_table_internal, Sget_unicode_property_internal,
4124 and Sput_unicode_property_internal. Defvar_lisp
4125 char-code-property-alist.
4127 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4128 Vunicode_category_table.
4130 * font.c (font_range): Adjust for the change of
4131 Vunicode_category_table.
4133 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4135 * m/iris4d.h: Remove file, move contents ...
4136 * s/irix6-5.h: ... here.
4138 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4140 Remove unportable assumption about struct layout (Bug#8884).
4141 * alloc.c (mark_buffer):
4142 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4143 (clone_per_buffer_values): Don't assume that
4144 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4145 This isn't true in general, and it's particularly not true
4146 if Emacs is configured with --with-wide-int.
4147 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4148 New macros, used in the buffer.c change.
4150 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4152 * xsettings.c: Use both GConf and GSettings if both are available.
4153 (store_config_changed_event): Add comment.
4154 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4155 (store_tool_bar_style_changed): New functions.
4156 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4157 (struct xsettings): Move font inside HAVE_XFT.
4158 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4159 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4160 Move inside HAVE_XFT.
4161 (something_changed_gsettingsCB): Rename from something_changedCB.
4162 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4164 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4165 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4166 (something_changed_gconfCB): Rename from something_changedCB.
4167 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4168 (parse_settings): Move check for font inside HAVE_XFT.
4169 (read_settings, apply_xft_settings): Add comment.
4170 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4171 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4172 call store_font_name_changed.
4173 (xft_settings_event): Add comment.
4174 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4175 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4176 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4177 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4178 (xsettings_initialize): Call init_gsettings last.
4179 (xsettings_get_system_font, xsettings_get_system_normal_font):
4182 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4184 Random fixes. E.g., (random) never returned negative values.
4185 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4186 subseconds part to the entropy, as that's a bit more random.
4187 Prefer signed to unsigned, since the signedness doesn't matter and
4188 in general we prefer signed. When given a limit, use a
4189 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4190 latter isn't right if USE_2_TAGS_FOR_INTS.
4191 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4192 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4194 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4196 * textprop.c (text_property_stickiness):
4197 Obey Vtext_property_default_nonsticky.
4198 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4199 * w32fns.c (syms_of_w32fns):
4200 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4202 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4204 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4205 This is more efficient than Ffile_directory_p and avoids a minor race.
4207 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4209 * buffer.c (Foverlay_put): Say what the return value is
4212 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4213 is a directory before asking whether to use the file name
4215 (barf_or_query_if_file_exists): Make the "File is a directory"
4216 error be more correct.
4218 * fns.c (Frequire): Remove the mention of the .gz files, since
4219 that's installation-specific, but keep the mention of
4220 `get-load-suffixes'.
4222 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4224 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4225 Report string overflow if the output is too long.
4227 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4229 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4230 (syms_of_gnutls): Remove duplicate DEFSYM for
4231 Qgnutls_bootprop_verify_hostname_error, an error for
4232 Qgnutls_bootprop_verify_error (which is no longer used).
4234 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4235 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4236 Also (re)move comments that are misplaced or no longer relevant.
4238 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4240 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4242 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4244 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4245 and background color parameters if they have been changed.
4247 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4249 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4251 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4253 * xsettings.c (SYSTEM_FONT): Define only when used.
4254 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4256 * keymap.c (access_keymap_1): Now static.
4258 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4260 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4261 leave any prefix arg for the up event (Bug#1586).
4263 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4265 * lread.c (syms_of_lread): Mention single symbols defined by
4266 `defvar' or `defconst' (bug#7154).
4268 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4269 (Frequire): Mention get-load-suffixes.
4271 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4273 * window.h (window): Remove clone_number slot.
4274 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4276 (make_parent_window, make_window, saved_window)
4277 (Fset_window_configuration, save_window_save): Don't deal with
4279 * buffer.c (Qclone_number): Remove declaration.
4280 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4282 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4284 Add multiple inheritance to keymaps.
4285 * keymap.c (Fmake_composed_keymap): New function.
4286 (Fset_keymap_parent): Simplify.
4287 (fix_submap_inheritance): Remove.
4288 (access_keymap_1): New function extracted from access_keymap to handle
4289 embedded parents and handle lists of maps.
4290 (access_keymap): Use it.
4291 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4292 (Fcopy_keymap): Handle embedded parents.
4293 (Fcommand_remapping, define_as_prefix): Simplify.
4294 (Fkey_binding): Simplify.
4295 (syms_of_keymap): Move minibuffer-local-completion-map,
4296 minibuffer-local-filename-completion-map,
4297 minibuffer-local-must-match-map, and
4298 minibuffer-local-filename-must-match-map to Elisp.
4299 (syms_of_keymap): Defsubr make-composed-keymap.
4300 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4301 (parse_menu_item): Trivial simplification.
4303 2011-07-01 Glenn Morris <rgm@gnu.org>
4305 * Makefile.in (SETTINGS_LIBS): Fix typo.
4307 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4309 * coding.c (Fencode_coding_string): Record the last coding system
4310 used, as the function doc string says (bug#8738).
4312 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4314 * xsettings.c (store_monospaced_changed): Take new font as arg and
4315 check for change against current_mono_font.
4316 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4317 (emacs_settings_constructor, emacs_settings_get_property)
4318 (emacs_settings_set_property, emacs_settings_class_init)
4319 (emacs_settings_init, gsettings_obj): Remove.
4320 (something_changedCB): New function for HAVE_GSETTINGS.
4321 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4322 with value as argument.
4323 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4324 g_settings_new (Bug#8967). Do not create gsettings_obj.
4325 Remove calls to g_settings_bind. Connect something_changedCB to
4328 * xgselect.c: Add defined (HAVE_GSETTINGS).
4329 (xgselect_initialize): Ditto.
4331 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4332 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4335 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4337 * eval.c (struct backtrace): Simplify and port the data structure.
4338 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4339 signed bit field, as this assumption is not portable and it makes
4340 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4341 "char debug_on_exit : 1" as this is not portable either; instead,
4342 use the portable "unsigned int debug_on_exit : 1". Remove unused
4343 member evalargs. Remove obsolete comments about cc bombing out.
4345 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4347 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4348 Let HAVE_GSETTINGS override HAVE_GCONF.
4349 (store_monospaced_changed): New function.
4350 (EMACS_SETTINGS): A new type derived from GObject to handle
4351 GSettings notifications.
4352 (emacs_settings_constructor, emacs_settings_get_property)
4353 (emacs_settings_set_property, emacs_settings_class_init):
4355 (gsettings_client, gsettings_obj): New variables.
4356 (GSETTINGS_SCHEMA): New define.
4357 (something_changedCB): Call store_monospaced_changed.
4358 (init_gsettings): New function.
4359 (xsettings_initialize): Call init_gsettings.
4360 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4363 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4366 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4368 * window.c (resize_root_window, grow_mini_window)
4369 (shrink_mini_window): Rename Qresize_root_window to
4370 Qwindow_resize_root_window and Qresize_root_window_vertically to
4371 Qwindow_resize_root_window_vertically.
4373 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4375 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4377 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4379 * makefile.w32-in: Redesign dependencies so they reflect more
4380 clearly which files are directly included by each source file,
4381 and not through other includes.
4383 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4385 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4386 (sort_overlays, overlay_strings): When an overlay's clone number
4387 matches the window's clone number process the overlay even if
4388 the overlay's window property doesn't match the current window.
4390 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4391 (Fwindow_hchild): Rename to Fwindow_left_child.
4392 (Fwindow_next): Rename to Fwindow_next_sibling.
4393 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4394 (resize_window_check): Rename to window_resize_check.
4395 (resize_window_apply): Rename to window_resize_apply.
4396 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4397 (Fdelete_other_windows_internal, resize_frame_windows)
4398 (Fsplit_window_internal, Fdelete_window_internal)
4399 (grow_mini_window, shrink_mini_window)
4400 (Fresize_mini_window_internal): Fix callers accordingly.
4402 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4404 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4405 (emacs_fixed_set_min_size): Remove.
4406 (emacs_fixed_new): Take frame as argument.
4408 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4409 (_EmacsFixedPrivate): Remove minwidth/height.
4410 Add struct frame *f.
4411 (emacs_fixed_init): Initialize priv->f.
4412 (get_parent_class, emacs_fixed_set_min_size): Remove.
4413 (emacs_fixed_new): Set priv->f to argument.
4414 (emacs_fixed_get_preferred_width)
4415 (emacs_fixed_get_preferred_height): Use min_width/height from
4416 frames size_hint to set minimum and natural (Bug#8919).
4417 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4418 and use min_width/height from frames size_hint to set
4419 min_width/height (Bug#8919).
4421 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4422 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4425 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4427 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4428 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4431 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4433 * process.c (wait_reading_process_output): Bypass select if
4434 waiting for a cell while ignoring keyboard input, and input is
4435 pending. Suggested by Jan Djärv (Bug#8869).
4437 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4439 Use gnulib's dup2 module instead of rolling our own.
4440 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4442 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4444 * dispnew.c (scrolling_window): Before scrolling, turn off a
4445 mouse-highlight in the window being scrolled.
4447 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4449 Move DEFSYM to lisp.h and use everywhere.
4451 * character.h (DEFSYM): Move declaration...
4452 * lisp.h (DEFSYM): ...here.
4458 * w32select.c: Don't include character.h.
4460 * alloc.c (syms_of_alloc):
4461 * buffer.c (syms_of_buffer):
4462 * bytecode.c (syms_of_bytecode):
4463 * callint.c (syms_of_callint):
4464 * casefiddle.c (syms_of_casefiddle):
4465 * casetab.c (init_casetab_once):
4466 * category.c (init_category_once, syms_of_category):
4467 * ccl.c (syms_of_ccl):
4468 * cmds.c (syms_of_cmds):
4469 * composite.c (syms_of_composite):
4470 * dbusbind.c (syms_of_dbusbind):
4471 * dired.c (syms_of_dired):
4472 * dispnew.c (syms_of_display):
4473 * doc.c (syms_of_doc):
4474 * editfns.c (syms_of_editfns):
4475 * emacs.c (syms_of_emacs):
4476 * eval.c (syms_of_eval):
4477 * fileio.c (syms_of_fileio):
4478 * fns.c (syms_of_fns):
4479 * frame.c (syms_of_frame):
4480 * fringe.c (syms_of_fringe):
4481 * insdel.c (syms_of_insdel):
4482 * keymap.c (syms_of_keymap):
4483 * lread.c (init_obarray, syms_of_lread):
4484 * macros.c (syms_of_macros):
4485 * msdos.c (syms_of_msdos):
4486 * print.c (syms_of_print):
4487 * process.c (syms_of_process):
4488 * search.c (syms_of_search):
4489 * sound.c (syms_of_sound):
4490 * syntax.c (init_syntax_once, syms_of_syntax):
4491 * terminal.c (syms_of_terminal):
4492 * textprop.c (syms_of_textprop):
4493 * undo.c (syms_of_undo):
4494 * w32.c (globals_of_w32):
4495 * window.c (syms_of_window):
4496 * xdisp.c (syms_of_xdisp):
4497 * xfaces.c (syms_of_xfaces):
4498 * xfns.c (syms_of_xfns):
4499 * xmenu.c (syms_of_xmenu):
4500 * xsettings.c (syms_of_xsettings):
4501 * xterm.c (syms_of_xterm): Use DEFSYM.
4503 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4505 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4507 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4509 Integer and buffer overflow fixes (Bug#8873).
4511 * print.c (printchar, strout): Check for string overflow.
4512 (PRINTPREPARE, printchar, strout):
4513 Don't set size unless allocation succeeds.
4515 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4516 for sizes. Check for string overflow more accurately.
4517 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4519 * macros.c: Integer and buffer overflow fixes.
4520 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4521 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4522 Use ptrdiff_t, not int, for sizes.
4523 Don't increment bufsize until after realloc succeeds.
4524 Check for size-calculation overflow.
4525 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4527 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4529 * lread.c: Integer overflow fixes.
4530 (read_integer): Radix is now EMACS_INT, not int,
4531 to improve quality of diagnostics for out-of-range radices.
4532 Calculate buffer size correctly for out-of-range radices.
4533 (read1): Check for integer overflow in radices, and in
4534 read-circle numbers.
4535 (read_escape): Avoid int overflow.
4536 (Fload, openp, read_buffer_size, read1)
4537 (substitute_object_recurse, read_vector, read_list, map_obarray):
4538 Use ptrdiff_t, not int, for sizes.
4539 (read1): Use EMACS_INT, not int, for sizes.
4540 Check for size overflow.
4542 * image.c (cache_image): Check for size arithmetic overflow.
4544 * lread.c: Integer overflow issues.
4545 (saved_doc_string_size, saved_doc_string_length)
4546 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4547 Now ptrdiff_t, not int.
4548 (read1): Don't assume doc string length fits in int. Check for
4549 out-of-range doc string lengths.
4550 (read_list): Don't assume file position fits in int.
4551 (read_escape): Check for hex character overflow.
4553 2011-06-22 Leo Liu <sdl.web@gmail.com>
4555 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4556 Move to minibuffer.el.
4558 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4560 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4561 The following patches are for when GLYPH_DEBUG && !XASSERT.
4562 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4563 * dispnew.c (flush_stdout):
4564 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4565 Mark as externally visible.
4566 * dispnew.c (check_window_matrix_pointers): Now static.
4567 * dispnew.c (window_to_frame_vpos):
4568 * xfns.c (unwind_create_frame):
4569 * xterm.c (x_check_font): Remove unused local.
4570 * scroll.c (CHECK_BOUNDS):
4571 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4572 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4573 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4574 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4575 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4577 (debug_method_add): Use va_list and vsprintf rather than relying
4578 on undefined behavior with wrong number of arguments.
4579 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4580 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4581 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4582 since we're not interested in debugging glyphs with old libraries.
4583 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4584 GCC 4.6.0's static checking.
4586 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4588 Integer overflow and signedness fixes (Bug#8873).
4589 A few related buffer overrun fixes, too.
4591 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4593 * dispextern.h (struct face.stipple):
4594 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4595 (x_bitmap_mask, x_allocate_bitmap_record)
4596 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4597 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4598 (x_create_bitmap_from_xpm_data):
4599 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4600 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4602 * xfaces.c (load_pixmap):
4603 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4604 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4605 (.bitmaps_last, struct x_output.icon_bitmap):
4606 Use ptrdiff_t, not int, for bitmap indexes.
4607 (x_allocate_bitmap_record): Check for size overflow.
4608 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4610 Use ptrdiff_t, not int, for overlay counts.
4611 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4612 * editfns.c (overlays_around, get_pos_property):
4613 * textprop.c (get_char_property_and_overlay):
4614 * xdisp.c (next_overlay_change, note_mouse_highlight):
4615 * xfaces.c (face_at_buffer_position):
4616 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4617 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4618 (Fnext_overlay_change, Fprevious_overlay_change)
4619 (mouse_face_overlay_overlaps, Foverlays_in):
4620 Use ptrdiff_t, not int, for sizes.
4621 (overlays_at, overlays_in): Check for size-calculation overflow.
4623 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4625 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4626 (x_session_initialize): Do not assume string length fits in int.
4628 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4629 This is unlikely, but can occur if DPI is outlandish.
4631 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4632 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4634 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4635 * xrdb.c (magic_file_p, search_magic_path):
4636 Omit last arg SUFFIX; it was always 0. All callers changed.
4637 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4639 * xfont.c (xfont_match): Avoid need for strlen.
4641 * xfns.c: Don't assume strlen fits in int.
4642 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4644 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4645 not unsigned long, as we prefer signed integers. All callers changed.
4646 Detect integer overflow in repeat count.
4647 (message_dolog): Don't assume print length fits in 39 bytes.
4648 (display_mode_element): Don't assume strlen fits in int.
4650 * termcap.c: Don't assume sizes fit in int and never overflow.
4651 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4652 (gobble_line): Check for size-calculation overflow.
4654 * minibuf.c (Fread_buffer):
4655 * lread.c (intern, intern_c_string):
4656 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4657 Don't assume string length fits in int.
4659 * keyboard.c (parse_tool_bar_item):
4660 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4662 * font.c: Don't assume string length fits in int.
4663 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4664 Use ptrdiff_t, not int.
4665 (font_intern_prop): Don't assume string length fits in int.
4666 Don't assume integer property fits in fixnum.
4667 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4669 * filelock.c: Fix some buffer overrun and integer overflow issues.
4670 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4671 Reformulate so as not to need the command string.
4672 Invoke gzip -cd rather than gunzip, as it's more portable.
4673 (lock_info_type, lock_file_1, lock_file):
4674 Don't assume pid_t and time_t fit in unsigned long.
4675 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4676 (current_lock_owner): Prefer signed type for sizes.
4677 Use memcpy, not strncpy, where memcpy is what is really wanted.
4678 Don't assume (via atoi) that time_t and pid_t fit in int.
4679 Check for time_t and/or pid_t out of range, e.g., via a network share.
4680 Don't alloca where an auto var works fine.
4682 * fileio.c: Fix some integer overflow issues.
4683 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4684 Don't assume string length fits in int.
4685 (directory_file_name): Don't assume string length fits in long.
4686 (make_temp_name): Don't assume pid fits in int, or that its print
4687 length is less than 20.
4689 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4691 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4693 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4695 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4696 We prefer signed integers, even for size calculations.
4698 * emacs.c: Don't assume string length fits in 'int'.
4699 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4700 (main): Don't invoke strlen when not needed.
4702 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4703 (XD_DEBUG_MESSAGE): Don't waste a byte.
4705 * callproc.c (getenv_internal_1, getenv_internal)
4707 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4709 * lread.c (invalid_syntax): Omit length argument.
4710 All uses changed. This doesn't fix a bug, but it simplifies the
4711 code away from its former Hollerith-constant appearance, and it's
4712 one less 'int' to worry about when looking at integer-overflow issues.
4713 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4715 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4716 This didn't break anything, but it didn't help either.
4717 It's confusing to put a bogus integer in a place where the actual
4718 value does not matter.
4719 (LIST_END_P): Remove unused macro and its bogus comment.
4720 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4722 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4723 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4725 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4726 We prefer signed types, and the value cannot exceed the EMACS_INT
4727 range anyway (because otherwise the length would not be representable).
4728 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4729 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4730 This avoids a GCC warning when WIDE_EMACS_INT.
4732 * indent.c (sane_tab_width): New function.
4733 (current_column, scan_for_column, Findent_to, position_indentation)
4734 (compute_motion): Use it. This is just for clarity.
4735 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4737 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4739 * lisp.h (lint_assume): New macro.
4740 * composite.c (composition_gstring_put_cache):
4741 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4743 * editfns.c, insdel.c:
4744 Omit unnecessary forward decls, to simplify future changes.
4746 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4748 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4750 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4751 Use much-faster test for byte-length change.
4752 Don't assume string byte-length fits in 'int'.
4753 Check that character arg fits in 'int'.
4754 (mapcar1): Declare byte as byte, for clarity.
4756 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4758 * fns.c (concat): Catch string overflow earlier.
4759 Do not rely on integer wraparound.
4761 * dispextern.h (struct it.overlay_strings_charpos)
4762 (struct it.selective): Now EMACS_INT, not int.
4763 * xdisp.c (forward_to_next_line_start)
4764 (back_to_previous_visible_line_start)
4765 (reseat_at_next_visible_line_start, next_element_from_buffer):
4766 Don't arbitrarily truncate the value of 'selective' to int.
4768 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4770 * composite.c: Don't truncate sizes to 'int'.
4771 (composition_gstring_p, composition_reseat_it)
4772 (composition_adjust_point): Use EMACS_INT, not int.
4773 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4774 not EMACS_UINT, for indexes.
4776 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4778 * buffer.c: Include <verify.h>.
4779 (struct sortvec.priority, struct sortstr.priority):
4780 Now EMACS_INT, not int.
4781 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4782 (struct sortstr.size, record_overlay_string)
4783 (struct sortstrlist.size, struct sortlist.used):
4784 Don't truncate size to int.
4785 (record_overlay_string): Check for size-calculation overflow.
4786 (init_buffer_once): Check at compile-time, not run-time.
4788 2011-06-22 Jim Meyering <meyering@redhat.com>
4790 Don't leak an XBM-image-sized buffer
4791 * image.c (xbm_load): Free the image buffer after using it.
4793 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4796 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4797 that Sun C diagnosed.
4798 * fns.c (secure_hash): Fix pointer signedness issue.
4799 * intervals.c (static_offset_intervals): New function.
4800 (offset_intervals): Use it.
4802 2011-06-21 Leo Liu <sdl.web@gmail.com>
4805 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4808 * fns.c (secure_hash): Rename from crypto_hash_function and change
4809 the first arg to accept symbols.
4810 (Fsecure_hash): New primitive.
4811 (syms_of_fns): New symbols.
4813 2011-06-20 Deniz Dogan <deniz@dogan.se>
4815 * process.c (Fset_process_buffer): Clarify return value in
4818 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4820 * dispnew.c (add_window_display_history): Use BVAR.
4822 * xdisp.c (debug_method_add): Use BVAR.
4823 (check_window_end, dump_glyph_matrix, dump_glyph)
4824 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4826 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4829 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4830 check till after the cache is created in init_frame_faces.
4832 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4834 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4836 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4838 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4839 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4840 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4842 Improve buffer-overflow checking (Bug#8873).
4843 * fileio.c (Finsert_file_contents):
4844 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4845 Remove the old (too-loose) buffer overflow checks.
4846 They weren't needed, since make_gap checks for buffer overflow.
4847 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4848 The old code merely checked for Emacs fixnum overflow, and relied
4849 on undefined (wraparound) behavior. The new code avoids undefined
4850 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4852 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4853 Tune. Don't use wider integers than needed. Don't use alloca.
4854 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4856 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4858 * insdel.c, lisp.h (buffer_overflow): New function.
4859 (insert_from_buffer_1, replace_range, replace_range_2):
4860 * insdel.c (make_gap_larger):
4861 * editfns.c (Finsert_char):
4862 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4864 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4866 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4868 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4870 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4871 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4873 * fileio.c: Don't assume EMACS_INT fits in off_t.
4874 (emacs_lseek): New static function.
4875 (Finsert_file_contents, Fwrite_region): Use it.
4876 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4878 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4880 * fns.c: Don't overflow int when computing a list length.
4881 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4882 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4883 truncation on 64-bit hosts. Check for QUIT every
4884 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4885 faster and is responsive enough.
4886 (Flength): Report an error instead of overflowing an integer.
4887 (Fsafe_length): Return a float if the value is not representable
4888 as a fixnum. This shouldn't happen except in contrived situations.
4889 (Fnthcdr, Fsort): Don't assume list length fits in int.
4890 (Fcopy_sequence): Don't assume vector length fits in int.
4892 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4893 (header_size, word_size): New constants.
4894 (allocate_vectorlike): Don't check size overflow here.
4895 (allocate_vector): Check it here instead, since this is the only
4896 caller of allocate_vectorlike that could cause overflow.
4897 Check that the new vector's length is representable as a fixnum.
4899 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4900 The previous code was bogus. For example, next_almost_prime (32)
4901 returned 39, which is undesirable as it is a multiple of 3; and
4902 next_almost_prime (24) returned 25, which is a multiple of 5 so
4903 why was the code bothering to check for multiples of 7?
4905 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4907 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4909 Variadic C functions now count arguments with ptrdiff_t.
4910 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4911 Back then I didn't know that the Emacs coding style prefers signed int.
4912 Also, in the meantime I found a few more instances where arguments
4913 were being counted with int, which may truncate counts on 64-bit
4914 machines, or EMACS_INT, which may be unnecessarily wide.
4915 * lisp.h (struct Lisp_Subr.function.aMANY)
4916 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4917 Arg counts are now ptrdiff_t, not size_t.
4918 All variadic functions and their callers changed accordingly.
4919 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4920 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4921 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4922 * callint.c (Fcall_interactively): Check arg count for overflow,
4923 to avoid potential buffer overrun. Use signed char, not 'int',
4924 for 'varies' array, so that we needn't bother to check its size
4925 calculation for overflow.
4926 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4927 * eval.c (apply_lambda):
4928 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4929 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4930 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4932 * callint.c (Fcall_interactively): Don't use index var as event count.
4934 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4935 * mem-limits.h (SIZE): Remove; no longer used.
4937 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4939 Remove unnecessary casts.
4940 * xterm.c (x_term_init):
4941 * xfns.c (x_set_border_pixel):
4942 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4943 These aren't needed now that we assume ANSI C.
4945 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4946 It's more likely to cause problems (due to unsigned overflow)
4949 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4951 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4953 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4955 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4957 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4959 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4961 GLYPH_CODE_FACE returns EMACS_INT, not int.
4962 * dispextern.h (merge_faces):
4963 * xfaces.c (merge_faces):
4964 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4965 Don't assume EMACS_INT fits in int.
4967 * character.h (CHAR_VALID_P): Remove unused parameter.
4968 * fontset.c, lisp.h, xdisp.c: All uses changed.
4970 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4972 * fns.c (concat): Minor tuning based on overflow analysis.
4973 This doesn't fix any bugs. Use int to hold character, instead
4974 of constantly refetching from Emacs object. Use XFASTINT, not
4975 XINT, for value known to be a character. Don't bother comparing
4976 a single byte to 0400, as it's always less.
4978 * floatfns.c (Fexpt):
4979 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4981 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4984 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4986 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4987 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4988 incorrectly succeed when S was a string, because 4294967386 was
4989 truncated before it was used.
4991 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4992 Otherwise, an out-of-range integer could cause undefined behavior
4995 * composite.c: Use int, not EMACS_INT, for characters.
4996 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4997 EMACS_INT, for values that are known to be in character range.
4998 This doesn't fix any bugs but is the usual style inside Emacs and
4999 may generate better code on 32-bit machines.
5001 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5002 This is for reasons similar to the recent CHAR_STRING fix.
5003 * charset.c (Fencode_char): Check that character arg is actually
5004 a character. Pass an int to ENCODE_CHAR.
5005 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5006 wider than 'int', as a compile-time check to prevent future regressions
5009 * character.c (char_string): Remove unnecessary casts.
5011 Make sure a 64-bit char is never passed to CHAR_STRING.
5012 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5013 by silently ignoring the top 32 bits, allowing some values
5014 that were far too large to be valid characters.
5015 * character.h: Include <verify.h>.
5016 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5017 arguments are no wider than unsigned, as a compile-time check
5018 to prevent future regressions in this area.
5020 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5021 (Fsubst_char_in_region):
5023 * xdisp.c (decode_mode_spec_coding):
5024 Adjust to CHAR_STRING's new requirement.
5025 * editfns.c (Finsert_char, Fsubst_char_in_region):
5026 * fns.c (concat): Check that character args are actually
5027 characters. Without this test, these functions did the wrong
5028 thing with wildly out-of-range values on 64-bit hosts.
5030 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5031 These casts should not be needed on 32-bit hosts, either.
5032 * keyboard.c (read_char):
5033 * lread.c (Fload): Remove casts to unsigned.
5035 * lisp.h (UNSIGNED_CMP): New macro.
5036 This fixes comparison bugs on 64-bit hosts.
5037 (ASCII_CHAR_P): Use it.
5038 * casefiddle.c (casify_object):
5039 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5040 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5041 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5042 * dispextern.h (FACE_FROM_ID):
5043 * keyboard.c (read_char): Use UNSIGNED_CMP.
5045 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5046 not to EMACS_INT, to avoid GCC warning.
5048 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5050 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5051 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5052 isn't needed on 32-bit machines.
5054 * buffer.c (Fgenerate_new_buffer_name):
5055 Use EMACS_INT for count, not int.
5056 (advance_to_char_boundary): Return EMACS_INT, not int.
5058 * data.c (Qcompiled_function): Now static.
5060 * window.c (window_body_lines): Now static.
5062 * image.c (gif_load): Rename local to avoid shadowing.
5064 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5065 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5066 * alloc.c (make_save_value): Integer argument is now of type
5068 (mark_object): Use ptrdiff_t, not int.
5069 * lisp.h (pD): New macro.
5070 * print.c (print_object): Use it.
5072 * alloc.c: Use EMACS_INT, not int, to count objects.
5073 (total_conses, total_markers, total_symbols, total_vector_size)
5074 (total_free_conses, total_free_markers, total_free_symbols)
5075 (total_free_floats, total_floats, total_free_intervals)
5076 (total_intervals, total_strings, total_free_strings):
5077 Now EMACS_INT, not int. All uses changed.
5078 (Fgarbage_collect): Compute overall total using a double, so that
5079 integer overflow is less likely to be a problem. Check for overflow
5080 when converting back to an integer.
5081 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5082 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5083 These were 'int' variables that could overflow on 64-bit hosts;
5084 they were never used, so remove them instead of repairing them.
5085 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5086 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5087 Previously, this ceilinged at INT_MAX, but that doesn't work on
5089 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5091 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5092 (allocate_vectorlike): Check for ptrdiff_t overflow.
5093 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5094 when a (possibly-narrower) signed value would do just as well.
5095 We prefer using signed arithmetic, to avoid comparison confusion.
5097 * alloc.c: Catch some string size overflows that we were missing.
5098 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5099 for convenience in STRING_BYTES_MAX.
5100 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5101 The definition here is exact; the one in lisp.h was approximate.
5102 (allocate_string_data): Check for string overflow. This catches
5103 some instances we weren't catching before. Also, it catches
5104 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5105 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5106 and ptrdiff_t and EMACS_INT are both 64 bits.
5108 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5109 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5110 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5112 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5114 * alloc.c (Fmake_string): Check for out-of-range init.
5116 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5118 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5120 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5122 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5123 xg_get_default_scrollbar_width.
5125 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5126 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5127 (style_changed_cb): Call update_theme_scrollbar_width and call
5128 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5129 all frames (Bug#8505).
5130 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5131 Call gtk_window_set_resizable if HAVE_GTK3.
5132 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5133 and height if HAVE_GTK3 (Bug#8505).
5134 (scroll_bar_width_for_theme): New variable.
5135 (update_theme_scrollbar_width): New function.
5136 (xg_get_default_scrollbar_width): Move code to
5137 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5138 (xg_initialize): Call update_theme_scrollbar_width.
5140 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5142 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5144 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5146 * frame.c (make_frame): Call other_buffer_safely instead of
5149 * window.c (temp_output_buffer_show): Call display_buffer with
5150 second argument Vtemp_buffer_show_specifiers and reset latter
5151 immediately after the call.
5152 (Vtemp_buffer_show_specifiers): New variable.
5153 (auto_window_vscroll_p, next_screen_context_lines)
5154 (Vscroll_preserve_screen_position): Remove leading asterisks from
5157 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5159 Fix minor problems found by GCC 4.6.0 static checking.
5160 * buffer.c (Qclone_number): Remove for now, as it's unused.
5161 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5162 (record_buffer): Remove unused local.
5163 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5164 (set_frame_buffer_list): Remove; unused.
5165 * frame.h (other_visible_frames): Remove decl.
5166 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5167 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5168 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5170 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5171 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5172 Define only if HAVE_GPM.
5173 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5174 (update_hints_inhibit): Remove; never set. All uses removed.
5175 * widgetprv.h (emacsFrameClassRec): Remove decl.
5176 * window.c (delete_deletable_window): Now returns void, since it
5177 wasn't returning anything.
5178 (compare_window_configurations): Remove unused locals.
5179 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5180 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5181 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5182 the same widths as pointers. This follows up on the 2011-05-06 patch.
5183 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5184 * xterm.h: Likewise.
5185 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5187 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5189 * makefile.w32-in: Update dependencies.
5190 (LISP_H): Add lib/intprops.h.
5192 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5194 * image.c (gif_load): Add animation frame delay to the metadata.
5195 (syms_of_image): Use DEFSYM. New symbol `delay'.
5197 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5199 * window.c (delete_deletable_window): Re-add.
5200 (Fset_window_configuration): Rewrite to handle dead buffers and
5201 consequently deletable windows.
5202 (window_tree, Fwindow_tree): Remove. Supply functionality in
5204 (compare_window_configurations): Simplify code.
5206 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5208 * image.c (imagemagick_load_image): Fix type mismatch.
5209 (Fimagemagick_types): Likewise.
5211 * window.h (replace_buffer_in_windows): Declare.
5213 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5215 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5216 Qclone_number. Remove external declaration of Qdelete_window.
5217 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5219 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5220 Run Qbuffer_list_update_hook if allowed.
5221 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5222 buffer list implementation.
5223 (other_buffer_safely): New function.
5224 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5225 calls to replace_buffer_in_windows and
5226 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5228 (record_buffer): Inhibit quitting and rewrite using quittable
5229 functions. Run Qbuffer_list_update_hook if allowed.
5230 (Frecord_buffer, Funrecord_buffer): New functions.
5231 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5232 Move switch-to-buffer to window.el.
5233 (bury-buffer): Move to window.el.
5234 (Vbuffer_list_update_hook): New variable.
5236 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5239 * window.h (resize_frame_windows): Move up in code.
5240 (Fwindow_frame): Remove EXFUN.
5241 (replace_buffer_in_all_windows): Remove prototype.
5242 (replace_buffer_in_windows_safely): Add prototype.
5244 * window.c: Declare Qdelete_window static again. Move down
5245 declaration of select_count.
5246 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5247 (Fother_window): Move to window.el.
5248 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5249 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5250 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5252 (replace_buffer_in_windows): Implement by calling
5253 Qreplace_buffer_in_windows.
5254 (replace_buffer_in_all_windows): Remove with some functionality
5255 moved into replace_buffer_in_windows_safely.
5256 (replace_buffer_in_windows_safely): New function.
5257 (select_window_norecord, select_frame_norecord): Move in front
5258 of run_window_configuration_change_hook. Remove now obsolete
5260 (Fset_window_buffer): Rewrite doc-string.
5261 Call Qrecord_window_buffer.
5262 (keys_of_window): Move binding for other-window to window.el.
5264 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5266 * dispextern.h (struct image): Replace data member, whose int_val
5267 and ptr_val fields were not used by anything, with a single
5270 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5271 (gif_clear_image, gif_load, imagemagick_load_image)
5272 (gs_clear_image, gs_load): Callers changed.
5274 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5276 * buffer.h: Include <time.h>, for time_t.
5277 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5279 Fix minor problems found by static checking.
5281 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5283 Make identifiers static if they are not used in other modules.
5284 * data.c (Qcompiled_function, Qframe, Qvector):
5285 * image.c (QimageMagick, Qsvg):
5286 * minibuf.c (Qmetadata):
5287 * window.c (resize_window_check, resize_root_window): Now static.
5288 * window.h (resize_window_check, resize_root_window): Remove decls.
5290 * window.c (window_deletion_count, delete_deletable_window):
5292 (window_body_lines): Now static.
5293 (Fdelete_other_windows_internal): Mark vars as initialized.
5294 Make sure 'resize_failed' is initialized.
5295 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5296 (resize_window_apply): Remove unused local.
5297 * window.h (delete_deletable_window): Remove decl.
5299 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5300 (imagemagick_load_image): Fix pointer signedness problem by changing
5301 last arg from unsigned char * to char *. All uses changed.
5302 Also, fix a local for similar reasons.
5303 Remove unused locals. Remove locals to avoid shadowing.
5304 (fn_rsvg_handle_free): Remove; unused.
5305 (svg_load, svg_load_image): Fix pointer signedness problem.
5306 (imagemagick_load_image): Don't use garbage pointer image_wand.
5308 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5310 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5312 * image.c (gif_load): Fix omitted cast error introduced by
5315 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5317 * window.h (resize_proportionally, orig_total_lines)
5318 (orig_top_line): Remove from window structure.
5319 (set_window_height, set_window_width, change_window_heights)
5320 (Fdelete_window): Remove prototypes.
5321 (resize_frame_windows): Remove duplicate declaration.
5323 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5325 * window.h (resize_frame_windows, resize_window_check)
5326 (delete_deletable_window, resize_root_window)
5327 (resize_frame_windows): Declare prototypes.
5329 * window.c (resize_window_apply): Make definition be "static" to
5330 match the prototype.
5332 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5334 * window.c: Remove declarations of Qwindow_size_fixed,
5335 window_min_size_1, window_min_size_2, window_min_size,
5336 size_window, window_fixed_size_p, enlarge_window, delete_window.
5337 Remove static from declaration of Qdelete_window, it's
5338 temporarily needed by Fbury_buffer.
5339 (replace_window): Don't assign orig_top_line and
5341 (Fdelete_window, delete_window): Remove. Window deletion is
5342 handled by window.el.
5343 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5344 Replace Fdelete_window calls with calls to Qdelete_window.
5345 (Fdelete_other_windows): Remove. Deleting other windows is
5346 handled by window.el.
5347 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5348 handled in window.el.
5349 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5350 Window minimum sizes are handled in window.el.
5351 (shrink_windows, size_window, set_window_height)
5352 (set_window_width, change_window_heights, window_height)
5353 (window_width, CURBEG, CURSIZE, enlarge_window)
5354 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5355 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5356 handled in window.el.
5357 (make_dummy_parent): Rename to make_parent_window and give it a
5358 second argument horflag.
5359 (make_window): Don't set resize_proportionally any more.
5360 (Fsplit_window): Remove. Windows are split in window.el.
5361 (save_restore_action, save_restore_orig_size)
5362 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5363 Resize mini windows in window.el.
5364 (grow_mini_window, shrink_mini_window): Implement by calling
5365 Qresize_root_window_vertically, resize_window_check and
5366 resize_window_apply.
5367 (saved_window, Fset_window_configuration, save_window_save):
5368 Do not handle orig_top_line, orig_total_lines, and
5369 resize_proportionally.
5370 (window_min_height, window_min_width): Move to window.el.
5371 (keys_of_window): Move bindings for delete-other-windows,
5372 split-window, delete-window and enlarge-window to window.el.
5374 * buffer.c: Temporarily extern Qdelete_window.
5375 (Fbury_buffer): Temporarily call Qdelete_window instead of
5376 Fdelete_window (Fbury_buffer will move to window.el soon).
5378 * frame.c (set_menu_bar_lines_1): Remove code handling
5379 orig_top_line and orig_total_lines.
5381 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5382 set_window_height but set heights directly.
5383 (change_frame_size_1): Use resize_frame_windows.
5385 * xdisp.c (init_xdisp): Don't use set_window_height but set
5388 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5389 Use resize_frame_windows instead of change_window_heights and run
5390 run_window_configuration_change_hook.
5392 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5393 instead of change_window_heights and run
5394 run_window_configuration_change_hook.
5396 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5398 * window.c (replace_window): Rename second argument REPLACEMENT to
5399 NEW. New third argument SETFLAG. Rewrite.
5400 (delete_window, make_dummy_parent): Call replace_window with
5402 (window_list_1): Move down in code.
5403 (run_window_configuration_change_hook): Move set_buffer part
5404 before select_frame_norecord part in order to unwind correctly.
5405 Rename count1 to count.
5406 (recombine_windows, delete_deletable_window, resize_root_window)
5407 (Fdelete_other_windows_internal)
5408 (Frun_window_configuration_change_hook, make_parent_window)
5409 (resize_window_check, resize_window_apply, Fresize_window_apply)
5410 (resize_frame_windows, Fsplit_window_internal)
5411 (Fdelete_window_internal, Fresize_mini_window_internal):
5413 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5415 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5417 * window.h (window): Add some new members to window structure -
5418 normal_lines, normal_cols, new_total, new_normal, clone_number,
5419 splits, nest, prev_buffers, next_buffers.
5420 (WINDOW_TOTAL_SIZE): Move here from window.c.
5421 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5423 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5425 (make_dummy_parent): Set new members of windows structure.
5426 (make_window): Move down in code. Handle new members of window
5428 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5429 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5430 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5431 (Fset_window_prev_buffers, Fwindow_next_buffers)
5432 (Fset_window_next_buffers, Fset_window_clone_number):
5434 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5435 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5437 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5438 Argument WINDOW can be now internal window too.
5439 (Fwindow_use_time): Move up in code.
5440 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5442 (Fset_window_configuration, saved_window)
5443 (Fcurrent_window_configuration, save_window_save): Handle new
5444 members of window structure.
5445 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5446 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5447 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5448 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5449 Qget_mru_window, Qresize_root_window,
5450 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5451 Qauto_buffer_name; staticpro them.
5453 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5455 * window.c (Fwindow_total_size, Fwindow_left_column)
5456 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5457 (Fwindow_list_1): New functions.
5458 (window_box_text_cols): Replace with window_body_cols.
5459 (Fwindow_width, Fscroll_left, Fscroll_right):
5460 Use window_body_cols instead of window_box_text_cols.
5461 (delete_window, Fset_window_configuration):
5462 Call delete_all_subwindows with window as argument.
5463 (delete_all_subwindows): Take a window as argument and not a
5465 (window_loop): Remove handling of GET_LRU_WINDOW and
5467 (Fget_lru_window, Fget_largest_window): Move to window.el.
5469 * window.h: Extern window_body_cols instead of
5470 window_box_text_cols. delete_all_subwindows now takes a
5471 Lisp_Object as argument.
5473 * indent.c (compute_motion, Fcompute_motion):
5474 Use window_body_cols instead of window_box_text_cols.
5476 * frame.c (delete_frame): Call delete_all_subwindows with root
5479 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5481 * fns.c (Fputhash): Document return value.
5483 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5485 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5487 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5489 Cons<->int and similar integer overflow fixes (Bug#8794).
5491 Check for overflow when converting integer to cons and back.
5492 * charset.c (Fdefine_charset_internal, Fdecode_char):
5493 Use cons_to_unsigned to catch overflow.
5494 (Fencode_char): Use INTEGER_TO_CONS.
5495 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5496 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5497 * data.c (long_to_cons, cons_to_long): Remove.
5498 (cons_to_unsigned, cons_to_signed): New functions.
5499 These signal an error for invalid or out-of-range values.
5500 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5501 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5502 * font.c (Ffont_variation_glyphs):
5503 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5504 * lisp.h: Include <intprops.h>.
5505 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5506 (cons_to_signed, cons_to_unsigned): New decls.
5507 (long_to_cons, cons_to_long): Remove decls.
5508 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5509 (Fprimitive_undo): Use CONS_TO_INTEGER.
5510 * xfns.c (Fx_window_property): Likewise.
5511 * xselect.c: Include <limits.h>.
5512 (x_own_selection, selection_data_to_lisp_data):
5513 Use INTEGER_TO_CONS.
5514 (x_handle_selection_request, x_handle_selection_clear)
5515 (x_get_foreign_selection, Fx_disown_selection_internal)
5516 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5517 (lisp_data_to_selection_data): Use cons_to_unsigned.
5518 (x_fill_property_data): Use cons_to_signed.
5519 Report values out of range.
5521 Check for buffer and string overflow more precisely.
5522 * buffer.h (BUF_BYTES_MAX): New macro.
5523 * lisp.h (STRING_BYTES_MAX): New macro.
5524 * alloc.c (Fmake_string):
5525 * character.c (string_escape_byte8):
5526 * coding.c (coding_alloc_by_realloc):
5527 * doprnt.c (doprnt):
5528 * editfns.c (Fformat):
5530 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5531 since they may not be the same number.
5532 * editfns.c (Finsert_char):
5533 * fileio.c (Finsert_file_contents):
5534 Likewise for BUF_BYTES_MAX.
5536 * image.c: Use ptrdiff_t, not int, for sizes.
5537 (slurp_file): Switch from int to ptrdiff_t.
5539 (slurp_file): Check that file size fits in both size_t (for
5540 malloc) and ptrdiff_t (for sanity and safety).
5542 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5543 if b->modtime has its maximal value.
5545 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5547 Don't assume time_t can fit into int.
5548 * buffer.h (struct buffer.modtime): Now time_t, not int.
5549 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5550 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5552 Minor fixes for signed vs unsigned integers.
5553 * character.h (MAYBE_UNIFY_CHAR):
5554 * charset.c (maybe_unify_char):
5555 * keyboard.c (read_char, reorder_modifiers):
5556 XINT -> XFASTINT, since the integer must be nonnegative.
5557 * ftfont.c (ftfont_spec_pattern):
5558 * keymap.c (access_keymap, silly_event_symbol_error):
5559 XUINT -> XFASTINT, since the integer must be nonnegative.
5560 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5561 since it makes no difference and we prefer signed.
5562 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5563 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5566 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5568 * window.h (Fwindow_frame): Declare.
5570 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5572 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5573 (SPARE_MEMORY): Always define.
5574 (LARGE_REQUEST): Remove.
5575 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5577 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5579 * lisp.h: Move EXFUNS for Fframe_root_window,
5580 Fframe_first_window and Fset_frame_selected_window to window.h.
5582 * window.h: Move EXFUNS for Fframe_root_window,
5583 Fframe_first_window and Fset_frame_selected_window here from
5586 * frame.c (Fwindow_frame, Fframe_first_window)
5587 (Fframe_root_window, Fframe_selected_window)
5588 (Fset_frame_selected_window): Move to window.c.
5589 (Factive_minibuffer_window): Move to minibuf.c.
5590 (Fother_visible_frames_p): New function.
5592 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5594 * window.c (decode_window, decode_any_window): Move up in code.
5595 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5596 (inhibit_frame_unsplittable): Remove unused variable.
5597 (Fwindow_buffer): Move up and rewrite doc-string.
5598 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5599 (Fwindow_prev): New functions.
5600 (Fwindow_frame): Move here from frame.c. Accept any window as
5602 (Fframe_root_window, Fframe_first_window)
5603 (Fframe_selected_window): Move here from frame.c. Accept frame
5604 or arbitrary window as argument. Update doc-strings.
5605 (Fminibuffer_window): Move up in code.
5606 (Fwindow_minibuffer_p): Move up in code and simplify.
5607 (Fset_frame_selected_window): Move here from frame.c.
5609 (Fselected_window, select_window, Fselect_window): Move up in
5610 code. Minor doc-string fixes.
5612 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5614 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5615 Do not assume that spare memory exists; that assumption is valid
5616 only if SYSTEM_MALLOC.
5617 (LARGE_REQUEST): New macro, so that the issue of large requests
5618 is separated from the issue of spare memory.
5620 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5622 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5625 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5627 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5630 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5632 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5634 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5636 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5637 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5639 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5641 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5643 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5645 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5646 (x_clipboard_manager_save): Add return value.
5647 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5649 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5650 Obey Vx_select_enable_clipboard_manager. Catch errors in
5651 x_clipboard_manager_save (Bug#8779).
5652 (Vx_select_enable_clipboard_manager): New variable.
5653 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5655 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5657 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5659 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5661 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5662 in the current matrix if keep_current_p is non-zero.
5664 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5666 * bidi.c (bidi_level_of_next_char): Fix last change.
5668 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5670 Support bidi reordering of text covered by display properties.
5672 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5673 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5674 (bidi_cache_search, bidi_cache_iterator_state)
5675 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5676 (bidi_level_of_next_char, bidi_move_to_visually_next):
5677 Support character positions inside a run of characters covered by a
5679 (bidi_paragraph_init, bidi_resolve_explicit_1)
5680 (bidi_level_of_next_char): Call bidi_fetch_char and
5681 bidi_fetch_char_advance instead of FETCH_CHAR and
5683 (bidi_init_it): Initialize new members.
5684 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5686 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5687 instead of using explicit *_CHAR codes.
5688 (bidi_resolve_explicit, bidi_resolve_weak):
5689 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5690 bidirectional text is supported only in multibyte buffers.
5691 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5692 it to initialize the frame_window_p member of struct bidi_it.
5693 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5694 (bidi_resolve_explicit, bidi_resolve_weak)
5695 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5696 bidi_it->nchars is non-positive.
5697 (bidi_level_of_next_char): Don't try to lookup the cache for the
5698 next/previous character if nothing is cached there yet, or if we
5699 were just reseat()'ed to a new position.
5701 * xdisp.c (set_cursor_from_row): Set start and stop points
5702 according to the row's direction when priming the loop that looks
5703 for the glyph on which to display cursor.
5704 (single_display_spec_intangible_p): Function deleted.
5705 (display_prop_intangible_p): Reimplement to call
5706 handle_display_spec instead of single_display_spec_intangible_p.
5707 Accept 3 additional arguments needed by handle_display_spec.
5708 This fixes incorrect cursor motion across display property with complex
5709 values: lists, `(when COND...)' forms, etc.
5710 (single_display_spec_string_p): Support property values that are
5711 lists with the argument STRING its top-level element.
5712 (display_prop_string_p): Fix the condition for processing a
5713 property that is a list to be consistent with handle_display_spec.
5714 (handle_display_spec): New function, refactored from the
5715 last portion of handle_display_prop.
5716 (compute_display_string_pos): Accept additional argument
5717 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5718 value of a `display' property is a "replacing spec".
5719 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5720 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5721 the display property, but just return a value indicating whether
5722 the display property will replace the characters it covers.
5723 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5724 frame_window_p members of struct bidi_it.
5725 (compute_display_string_pos, compute_display_string_end):
5727 (push_it): Accept second argument POSITION, where pop_it should
5728 jump to continue iteration.
5729 (reseat_1): Initialize bidi_it.disp_pos.
5731 * keyboard.c (adjust_point_for_property): Adjust the call to
5732 display_prop_intangible_p to its new signature.
5734 * dispextern.h (struct bidi_it): New member frame_window_p.
5735 (bidi_init_it): Update prototypes.
5736 (display_prop_intangible_p): Update prototype.
5737 (compute_display_string_pos, compute_display_string_end):
5739 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5742 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5744 Malloc failure behavior now depends on size of allocation.
5745 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5746 * lisp.h: Change signatures accordingly.
5747 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5748 All callers changed. (Bug#8762)
5750 * gnutls.c: Use Emacs's memory allocators.
5751 Without this change, the gnutls library would invoke malloc etc.
5752 directly, which causes problems on non-SYNC_INPUT hosts, and which
5753 runs afoul of improving memory_full behavior. (Bug#8761)
5754 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5755 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5756 xfree instead of the default malloc, realloc, free.
5757 (Fgnutls_boot): No need to check for memory allocation failure,
5758 since xmalloc does that for us.
5760 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5761 * category.c (hash_get_category_set):
5762 * ccl.c (ccl_driver):
5763 * charset.c (Fdefine_charset_internal):
5764 * charset.h (struct charset.hash_index):
5765 * composite.c (get_composition_id, gstring_lookup_cache)
5766 (composition_gstring_put_cache):
5767 * composite.h (struct composition.hash_index):
5768 * dispextern.h (struct image.hash):
5769 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5770 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5771 (hashfn_equal, hashfn_user_defined, make_hash_table)
5772 (maybe_resize_hash_table, hash_lookup, hash_put)
5773 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5774 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5775 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5776 * image.c (make_image, search_image_cache, lookup_image)
5777 (xpm_put_color_table_h):
5778 * lisp.h (struct Lisp_Hash_Table):
5779 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5780 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5781 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5782 * alloc.c (allocate_vectorlike):
5783 Check for overflow in vector size calculations.
5784 * ccl.c (ccl_driver):
5785 Check for overflow when converting EMACS_INT to int.
5786 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5787 need to be updated by these changes.
5788 * fns.c (make_hash_table, maybe_resize_hash_table):
5789 Check for integer overflow with large hash tables.
5790 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5791 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5792 (SXHASH_REDUCE): New macro.
5793 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5794 Use it instead of discarding useful hash info with large hash values.
5795 (sxhash_float): New function.
5796 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5797 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5798 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5799 Rewrite to use FIXNUM_BITS, as this simplifies things.
5800 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5801 Adjust signatures to match updated version of code.
5802 (consing_since_gc): Now EMACS_INT, since a single hash table can
5803 use more than INT_MAX bytes.
5805 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5807 Make it possible to build with GCC-4.6+ -O2 -flto.
5809 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5811 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5813 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5814 Call minibuffer-inactive-mode.
5816 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5818 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5819 Update dependencies.
5821 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5823 * data.c (init_data): Remove code for UTS, this system is not
5826 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5828 Don't force ./temacs to start in terminal mode.
5830 * frame.c (make_initial_frame): Initialize faces in all cases, not
5831 only when CANNOT_DUMP is defined.
5832 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5834 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5836 * dispnew.c (add_window_display_history): Use const for the string
5837 pointer. Remove declaration, not needed.
5839 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5841 Use 'inline', not 'INLINE'.
5842 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5843 * alloc.c, fontset.c (INLINE): Remove.
5844 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5845 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5846 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5847 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5848 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5850 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5852 Make it possible to run ./temacs.
5854 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5855 syms_of_callproc does the same thing. Remove test for
5856 "initialized", do it in the caller.
5857 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5859 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5861 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5862 (read_minibuf): Use get_minibuffer.
5863 (syms_of_minibuf): Use DEFSYM.
5864 (Qmetadata): New var.
5865 * data.c (Qbuffer): Don't make it static.
5866 (syms_of_data): Use DEFSYM.
5868 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5870 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5871 (CCL_CODE_MIN): New macro.
5873 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5875 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5877 * eval.c (Qdebug): Now static.
5878 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5879 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5880 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5882 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5884 * image.c: Various fixes to ImageMagick code comments.
5885 (Fimagemagick_types): Doc fix.
5887 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5889 Minor fixes prompted by GCC 4.6.0 warnings.
5891 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5893 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5894 (x_clipboard_manager_save_all): Move extern decl to ...
5895 * xterm.h: ... here, so that it can be checked for consistency.
5897 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5899 * xselect.c (x_clipboard_manager_save_frame)
5900 (x_clipboard_manager_save_all): New functions.
5901 (Fx_clipboard_manager_save): Lisp function deleted.
5903 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5904 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5906 * xterm.h: Update prototype.
5908 2011-05-28 William Xu <william.xwl@gmail.com>
5910 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5913 2011-05-28 Jim Meyering <meyering@redhat.com>
5915 Avoid a sign-extension bug in crypto_hash_function.
5916 * fns.c (to_uchar): Define.
5917 (crypto_hash_function): Use it to convert some newly-signed
5918 variables to unsigned, to avoid sign-extension bugs. For example,
5919 without this change, (md5 "truc") would evaluate to
5920 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5921 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5922 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5924 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5926 Integer overflow fixes.
5928 * dbusbind.c: Serial number integer overflow fixes.
5929 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5930 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5931 to hold a serial number that is too large for a fixnum.
5932 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5933 Check for serial numbers out of range. Decode any serial number
5934 that was so large that it became a float. (Bug#8722)
5936 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5937 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5938 Use XFASTINT rather than XUINT when numbers are nonnegative.
5939 (xd_append_arg, Fdbus_method_return_internal):
5940 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5941 arguments, check that Lisp number is nonnegative, rather than
5942 silently wrapping negative numbers around. (Bug#8722)
5943 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5946 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5948 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5950 ccl: Add integer overflow checks.
5951 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5952 (IN_INT_RANGE): New macros.
5953 (ccl_driver): Use them to check for integer overflow when
5954 decoding a CCL program. Many of the new checks are whether XINT (x)
5955 fits in int; it doesn't always, on 64-bit hosts. The new version
5956 doesn't catch all possible integer overflows, but it's an
5957 improvement. (Bug#8719)
5959 * alloc.c (make_event_array): Use XINT, not XUINT.
5960 There's no need for unsigned here.
5962 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5963 This follows up to the 2011-05-06 change that substituted uintptr_t
5964 for EMACS_INT. This case wasn't caught back then.
5966 Rework Fformat to avoid integer overflow issues.
5967 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5968 now (part of C89). Include <verify.h>.
5969 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5970 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5971 (Fformat): Avoid the prepass trying to compute sizes; it was only
5972 approximate and thus did not catch overflow reliably. Instead, walk
5973 through the format just once, formatting and computing sizes as we go,
5974 checking for integer overflow at every step, and allocating a larger
5975 buffer as needed. Keep track separately whether the format is
5976 multibyte. Keep only the most-recently calculated precision, rather
5977 than them all. Record whether each argument has been converted to
5978 string. Use EMACS_INT, not int, for byte and char and arg counts.
5979 Support field widths and precisions larger than INT_MAX. Avoid
5980 sprintf's undefined behavior with conversion specifications such as %#d
5981 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5982 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5983 formatting out-of-range floating point numbers with int
5986 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5988 * data.c: Avoid integer truncation in expressions involving floats.
5989 * data.c: Include <intprops.h>.
5990 (arith_driver): When there's an integer overflow in an expression
5991 involving floating point, convert the integers to floating point
5992 so that the resulting value does not suffer from catastrophic
5993 integer truncation. For example, on a 64-bit host (* 4
5994 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5995 Do not rely on undefined behavior after integer overflow.
5997 merge count_size_as_multibyte, parse_str_to_multibyte
5998 * character.c, character.h (count_size_as_multibyte):
5999 Rename from parse_str_to_multibyte; all uses changed.
6000 Check for integer overflow.
6001 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6002 since it's now a duplicate of the other. This is more of
6003 a character than a buffer op, so better that it's in character.c.
6004 * fns.c, print.c: Adjust to above changes.
6006 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6008 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6010 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6012 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6013 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6014 (x_clipboard_manager_save): Now static.
6015 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6017 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6018 (crypto_hash_function): Now static.
6019 Fix pointer signedness problems. Avoid unnecessary initializations.
6021 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6023 * termhooks.h (Vselection_alist): Make it terminal-local.
6025 * terminal.c (create_terminal): Initialize it.
6027 * xselect.c: Support for clipboard managers.
6028 (Vselection_alist): Move to termhooks.h as terminal-local var.
6029 (LOCAL_SELECTION): New macro.
6030 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6031 (symbol_to_x_atom): Remove gratuitous arg.
6032 (x_handle_selection_request, lisp_data_to_selection_data)
6033 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6034 (x_own_selection, x_get_local_selection, x_convert_selection):
6035 New arg, specifying work frame. Use terminal-local Vselection_alist.
6036 (some_frame_on_display): Delete unused function.
6037 (Fx_own_selection_internal, Fx_get_selection_internal)
6038 (Fx_disown_selection_internal, Fx_selection_owner_p)
6039 (Fx_selection_exists_p): New optional frame arg.
6040 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6041 (x_handle_selection_clear): Don't treat other terminals with the
6042 same keyboard specially. Use the terminal-local Vselection_alist.
6043 (x_clear_frame_selections): Use Frun_hook_with_args.
6045 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6047 * xterm.h: Add support for those atoms.
6049 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6051 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6052 (converted_selections, conversion_fail_tag): New global variables.
6053 (x_selection_request_lisp_error): Free the above.
6054 (x_get_local_selection): Remove unnecessary code.
6055 (x_reply_selection_request): Args changed; handle arbitrary array
6056 of converted selections stored in converted_selections.
6057 Separate the XChangeProperty and SelectionNotify steps.
6058 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6059 (x_convert_selection): New function.
6060 (x_handle_selection_event): Simplify.
6061 (x_get_foreign_selection): Don't ignore incoming requests while
6062 waiting for an answer; this will fail when we implement
6063 SAVE_TARGETS, and seems unnecessary anyway.
6064 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6065 (Vx_sent_selection_functions): Doc fix.
6067 2011-05-26 Leo Liu <sdl.web@gmail.com>
6069 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6071 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6073 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6075 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6076 for fringe update if it has periodic bitmap.
6077 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6078 and fringe_bitmap_periodic_p.
6080 * fringe.c (get_fringe_bitmap_data): New function.
6081 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6082 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6083 row. Mark glyph row for fringe update if periodicity changed.
6085 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6086 for fringe update unless it has periodic bitmap.
6088 2011-05-25 Kenichi Handa <handa@m17n.org>
6090 * xdisp.c (get_next_display_element): Set correct it->face_id for
6091 a static composition.
6093 2011-05-24 Leo Liu <sdl.web@gmail.com>
6096 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6098 * fns.c (crypto_hash_function, Fsha1): New function.
6099 (Fmd5): Use crypto_hash_function.
6100 (syms_of_fns): Add Ssha1.
6102 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6104 * gnutls.c: Remove unused macros.
6105 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6106 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6107 Remove macros that are defined and never used.
6108 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6110 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6112 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6113 (Fx_get_selection_internal): Minor cleanup.
6114 (Fx_own_selection_internal): Rename arguments for consistency with
6117 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6119 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6121 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6123 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6125 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6127 * dispnew.c (scrolling_window): Don't exclude the case that the
6128 last enabled row in the desired matrix touches the bottom boundary.
6130 2011-05-21 Glenn Morris <rgm@gnu.org>
6132 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6133 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6134 and add some more files.
6136 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6138 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6139 report_file_error introduced by the change from 2011-05-07.
6141 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6143 * systime.h (Time): Define only if emacs is defined.
6144 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6145 where the include path doesn't have X11/X.h by default. See
6146 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6148 2011-05-20 Kenichi Handa <handa@m17n.org>
6150 * composite.c (find_automatic_composition): Fix previous change.
6152 2011-05-20 Glenn Morris <rgm@gnu.org>
6154 * lisp.mk: New file, split from Makefile.in.
6155 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6156 (shortlisp): Remove.
6157 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6159 2011-05-19 Glenn Morris <rgm@gnu.org>
6161 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6162 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6163 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6164 (lisp): Set the order to that of loadup.el.
6165 (shortlisp): Make it a copy of $lisp.
6166 (SOME_MACHINE_LISP): Remove.
6167 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6168 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6170 2011-05-18 Kenichi Handa <handa@m17n.org>
6172 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6173 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6174 (find_automatic_composition): Mostly rewrite for efficiency.
6176 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6178 * makefile.w32-in: Update dependencies.
6180 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6182 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6183 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6185 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6187 Fix some integer overflow issues, such as string length overflow.
6189 * insdel.c (count_size_as_multibyte): Check for string overflow.
6191 * character.c (lisp_string_width): Check for string overflow.
6192 Use EMACS_INT, not int, for string indexes and lengths; in
6193 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6194 the resulting string length overflows an EMACS_INT; instead,
6195 report a string overflow if no precision given. When checking for
6196 precision exhaustion, use a check that cannot possibly have
6197 integer overflow. (Bug#8675)
6198 * character.h (lisp_string_width): Adjust to new signature.
6200 * alloc.c (string_overflow): New function.
6201 (Fmake_string): Use it. This doesn't change behavior, but saves
6202 a few bytes and will simplify future changes.
6203 * character.c (string_escape_byte8): Likewise.
6204 * lisp.h (string_overflow): New decl.
6206 Fixups, following up to the user-interface timestamp change.
6207 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6208 for UI timestamps, instead of unsigned long.
6209 * msdos.c (mouse_get_pos): Likewise.
6210 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6211 * w32gui.h (Time): Define by including "systime.h" rather than by
6212 declaring it ourselves. (Bug#8664)
6214 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6215 * image.c (clear_image_cache): Likewise.
6217 * term.c (term_mouse_position): Don't assume time_t wraparound.
6219 Be more systematic about user-interface timestamps.
6220 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6221 and sometimes 'EMACS_UINT', to represent these timestamps.
6222 This change causes it to use 'Time' uniformly, as that's what X uses.
6223 This makes the code easier to follow, and makes it easier to catch
6224 integer overflow bugs such as Bug#8664.
6225 * frame.c (Fmouse_position, Fmouse_pixel_position):
6226 Use Time, not unsigned long, for user-interface timestamps.
6227 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6228 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6229 * keyboard.h (last_event_timestamp): Likewise.
6230 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6231 * menu.h (xmenu_show): Likewise.
6232 * term.c (term_mouse_position): Likewise.
6233 * termhooks.h (struct input_event.timestamp): Likewise.
6234 (struct terminal.mouse_position_hook): Likewise.
6235 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6236 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6237 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6238 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6240 * menu.h, termhooks.h: Include "systime.h", for Time.
6242 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6243 Don't assume that the difference between two unsigned long values
6244 can fit into an integer. At this point, we know button_down_time
6245 <= event->timestamp, so the difference must be nonnegative, so
6246 there's no need to cast the result if double-click-time is
6247 nonnegative, as it should be; check that it's nonnegative, just in
6248 case. This bug is triggered when events are more than 2**31 ms
6249 apart (about 25 days). (Bug#8664)
6251 * xselect.c (last_event_timestamp): Remove duplicate decl.
6252 (x_own_selection): Remove needless cast to unsigned long.
6254 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6255 that always fit in int. Use a sentinel instead of a counter, to
6256 avoid a temp and to allay GCC's concerns about possible int overflow.
6257 * frame.h (struct frame): Use int for menu_bar_items_used
6258 instead of EMACS_INT, since it always fits in int.
6260 * menu.c (grow_menu_items): Check for int overflow.
6262 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6264 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6265 Before, the code was not consistent. These values cannot exceed
6266 2**31 - 1 so there's no need to make them unsigned.
6267 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6268 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6269 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6271 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6273 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6274 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6275 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6276 presumably because the widths might not match.
6278 * window.c (size_window): Avoid needless test at loop start.
6280 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6282 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6284 2011-05-12 Drew Adams <drew.adams@oracle.com>
6286 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6288 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6290 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6291 `width' to `bar_area_x' and `bar_area_width', respectively.
6292 (x_scroll_run): Take account of fringe background extension.
6294 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6295 Rename local vars `left' and `width' to `bar_area_x' and
6296 `bar_area_width', respectively.
6297 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6298 background extension.
6300 2011-05-10 Jim Meyering <meyering@redhat.com>
6302 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6304 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6306 * image.c (Finit_image_library): Return t for built-in image types,
6307 like pbm and xbm. (Bug#8640)
6309 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6311 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6313 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6315 * w32console.c (Fset_screen_color): Doc fix.
6316 (Fget_screen_color): New function.
6317 (syms_of_ntterm): Defsubr it.
6319 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6320 unlink the temporary file if Fcall_process didn't create it in the
6322 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6323 child process will be redirected to a file specified with `:file'.
6324 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6325 cue to call_process_cleanup not to close that handle.
6327 2011-05-07 Ben Key <bkey76@gmail.com>
6329 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6330 one of two shell specific rules, either bootstrap-temacs-CMD or
6331 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6332 to the previous implementation of the bootstrap-temacs rule.
6333 The bootstrap-temacs-CMD rule is similar to the previous
6334 implementation of the bootstrap-temacs rule except that it
6335 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6338 These changes, along with some changes to nt/configure.bat,
6339 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6340 earlier fix to add support for --cflags and --ldflags options
6341 that include quotes so that it works whether make uses cmd or
6344 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6346 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6347 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6349 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6350 a string. Handle both cases.
6351 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6352 (Fdbus_register_method): Use Qinvalid_function.
6354 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6356 * makefile.w32-in: Update dependencies.
6357 (LISP_H): Add inttypes.h and stdin.h.
6358 (PROCESS_H): Add unistd.h.
6360 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6362 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6363 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6365 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6367 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6369 * term.c (vfatal): Remove stray call to va_end.
6370 It's not needed and the C Standard doesn't allow it here anyway.
6372 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6373 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6375 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6378 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6380 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6382 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6384 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6386 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6388 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6389 * charset.c (Fdefine_charset_internal): Don't initialize
6390 charset.code_space[15]. The value was garbage, on hosts with
6391 32-bit int (Bug#8600).
6393 * lread.c (read_integer): Be more consistent with string-to-number.
6394 Use string_to_number to do the actual conversion; this avoids
6395 rounding errors and fixes some other screwups. Without this fix,
6396 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6397 (digit_to_number): Move earlier, for benefit of read_integer.
6398 Return -1 if the digit is out of range for the base, -2 if it is
6399 not a digit in any supported base. (Bug#8602)
6401 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6403 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6404 to match comment at start of function. This also removes a
6405 GCC warning about overflow in a 32+64-bit port.
6407 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6409 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6410 Reported by Stefan Monnier in
6411 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6412 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6413 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6415 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6416 (EMACS_UINTPTR): Likewise, with uintptr_t.
6418 * lisp.h: Prefer 64-bit EMACS_INT if available.
6419 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6420 on 32-bit hosts that have 64-bit int, so that they can access
6422 However, temporarily disable this change unless the temporary
6423 symbol WIDE_EMACS_INT is defined.
6425 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6427 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6428 This removes an assumption that EMACS_INT and long are the same
6429 width as pointers. The assumption is true for Emacs porting targets
6430 now, but we want to make other targets possible.
6431 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6432 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6433 In the rest of the code, change types of integers that hold casted
6434 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6435 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6436 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6437 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6438 No need to cast type when ORing.
6439 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6440 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6441 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6442 assume EMACS_INT is the same width as char *.
6443 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6444 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6445 Remove no-longer-needed casts.
6446 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6447 (xg_tool_bar_help_callback, xg_make_tool_item):
6448 Use EMACS_INTPTR to hold an integer
6449 that will be cast to void *; this can avoid a GCC warning
6450 if EMACS_INT is not the same width as void *.
6451 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6452 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6453 (current_message_1, set_message_1):
6454 Use a local to convert to proper width without a cast.
6455 * xmenu.c (dialog_selection_callback): Likewise.
6457 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6458 Also, don't assume VALBITS / RAND_BITS is less than 5,
6459 and don't rely on undefined behavior when shifting a 1 left into
6461 * lisp.h (get_random): Change signature to match.
6463 * lread.c (hash_string): Use size_t, not int, for hash computation.
6464 Normally we prefer signed values; but hashing is special, because
6465 it's better to use unsigned division on hash table sizes so that
6466 the remainder is nonnegative. Also, size_t is the natural width
6467 for hashing into memory. The previous code used 'int', which doesn't
6468 retain enough info to hash well into very large tables.
6469 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6471 * dbusbind.c: Don't possibly lose pointer info when converting.
6472 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6473 Use XPNTR rather than XHASH, so that the high-order bits of
6474 the pointer aren't lost when converting through void *.
6476 * eval.c (Fautoload): Don't double-shift a pointer.
6478 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6480 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6482 * gnutls.c (DEF_GNUTLS_FN):
6483 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6485 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6487 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6490 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6492 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6493 New version that can reserve upto 2GB of heap space.
6495 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6497 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6499 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6501 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6502 `gnutls_certificate_set_x509_key_file'.
6504 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6506 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6507 Update dependencies.
6509 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6511 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6512 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6513 Remove unused parameter `fildes'.
6514 * process.c (read_process_output, send_process): Don't pass it.
6516 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6518 Fix previous change: the library cache is defined in w32.c.
6519 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6520 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6522 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6524 Implement dynamic loading of GnuTLS on Windows.
6526 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6527 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6528 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6531 * gnutls.c (Qgnutls_dll): Define.
6532 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6533 (gnutls_*): Declare function pointers.
6534 (init_gnutls_functions): New function to initialize function pointers.
6535 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6536 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6537 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6538 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6539 (emacs_gnutls_write, emacs_gnutls_read)
6540 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6541 (Fgnutls_available_p): New function.
6542 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6543 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6544 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6546 * image.c: Include w32.h.
6547 (Vimage_type_cache): Delete.
6548 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6549 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6550 (w32_delayed_load): Move to w32.c.
6552 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6554 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6555 (w32_delayed_load): Move from image.c. When loading a library, record
6556 its filename in the :loaded-from property of the library id.
6557 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6558 Initialize and staticpro them.
6559 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6561 * process.c: Include lisp.h before w32.h, not after.
6562 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6563 instead of gnutls_record_check_pending.
6565 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6567 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6569 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6570 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6573 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6575 * xterm.c (x_set_frame_alpha): Do not set property on anything
6576 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6578 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6580 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6582 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6584 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6585 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6586 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6587 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6588 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6589 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6590 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6591 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6592 (Qgnutls_bootprop_callbacks_verify): Make static.
6594 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6596 * callproc.c: Indentation fixup.
6598 * sysdep.c (wait_for_termination_1): Make static.
6599 (wait_for_termination, interruptible_wait_for_termination):
6600 Move after wait_for_termination_1.
6602 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6604 * sysdep.c (interruptible_wait_for_termination): New function
6605 which is like wait_for_termination, but allows keyboard
6608 * callproc.c (Fcall_process): Add (:file "file") as an option for
6610 (Fcall_process_region): Ditto.
6612 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6614 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6615 rather than `XVECTOR (FOO)->size'.
6617 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6618 inttypes.h, as a gnulib replacement is used if it not available in
6621 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6623 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6624 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6625 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6627 * coding.c (coding_alloc_by_realloc): Error out if destination
6628 will grow beyond MOST_POSITIVE_FIXNUM.
6629 (decode_coding_emacs_mule): Abort if there isn't enough place in
6630 charbuf for the composition carryover bytes. Reserve an extra
6631 space for up to 2 characters produced in a loop.
6632 (decode_coding_iso_2022): Abort if there isn't enough place in
6633 charbuf for the composition carryover bytes.
6635 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6637 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6638 aborting when %lld or %lll format is passed.
6639 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6640 %llo or %llx format is passed. (Bug#8545)
6642 * window.c (window_scroll_line_based): Use a marker instead of
6643 simple variables to record original value of point. (Bug#7952)
6645 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6646 produced by %s or %c overflows available buffer space. (Bug#8545)
6648 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6650 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6651 (SIZE_MAX): Move defn after all includes, as they might #define it.
6653 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6655 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6657 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6659 * keyboard.c (Qdelayed_warnings_hook): Define.
6660 (command_loop_1): Run `delayed-warnings-hook'
6661 if Vdelayed_warnings_list is non-nil.
6662 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6663 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6665 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6667 * doprnt.c (doprnt): Don't return value smaller than the buffer
6668 size if the message was truncated. (Bug#8545).
6670 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6672 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6673 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6675 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6677 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6679 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6681 * makefile.w32-in: Update dependencies.
6683 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6685 Improve `doprnt' and its usage. (Bug#8545)
6686 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6687 `format_end'. Remove support for %l as a conversion specifier.
6688 Don't use xrealloc. Improve diagnostics when the %l size modifier
6689 is used. Update the commentary.
6691 * eval.c (verror): Simplify calculation of size_t.
6693 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6696 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6698 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6701 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6703 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6704 This makes this file independent of the recent pseudovector change.
6706 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6708 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6710 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6711 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6712 Remove unused local.
6713 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6715 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6716 GCC 4.6.0 optimizes based on type-based alias analysis.
6717 For example, if b is of type struct buffer * and v of type struct
6718 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6719 != &v->size, and therefore "v->size = 1; b->size = 2; return
6720 v->size;" must therefore return 1. This assumption is incorrect
6721 for Emacs, since it type-puns struct Lisp_Vector * with many other
6722 types. To fix this problem, this patch adds a new type struct
6723 vectorlike_header that documents the constraints on layout of vectors
6724 and pseudovectors, and helps optimizing compilers not get fooled
6725 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6726 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6727 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6729 (XSETPVECTYPE): Rewrite in terms of new macro.
6730 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6731 This is a bit clearer, and further avoids the possibility of
6732 undesirable aliasing.
6733 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6734 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6735 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6736 since Lisp_Subr is a special case (no "next" field).
6737 (ASIZE): Now uses header.size rather than size.
6738 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6739 to avoid the hassle of writing XVECTOR (foo)->header.size.
6740 (struct vectorlike_header): New type.
6741 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6742 object, to help avoid aliasing.
6743 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6744 (SUBRP): Likewise, since Lisp_Subr is a special case.
6745 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6746 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6747 (struct Lisp_Hash_Table): Combine first two members into a single
6748 struct vectorlike_header member. All uses of "size" and "next" members
6749 changed to be "header.size" and "header.next".
6750 * buffer.h (struct buffer): Likewise.
6751 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6752 * frame.h (struct frame): Likewise.
6753 * process.h (struct Lisp_Process): Likewise.
6754 * termhooks.h (struct terminal): Likewise.
6755 * window.c (struct save_window_data, struct saved_window): Likewise.
6756 * window.h (struct window): Likewise.
6757 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6758 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6759 * buffer.c (init_buffer_once): Likewise.
6760 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6762 * process.c (Fformat_network_address): Use local var for size,
6765 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6767 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6768 * data.c (atof): Remove decl; no longer used or needed.
6769 (digit_to_number): Move to lread.c.
6770 (Fstring_to_number): Use new string_to_number function, to be
6771 consistent with how the Lisp reader treats infinities and NaNs.
6772 Do not assume that floating-point numbers represent EMACS_INT
6773 without losing information; this is not true on most 64-bit hosts.
6774 Avoid double-rounding errors, by insisting on integers when
6775 parsing non-base-10 numbers, as the documentation specifies.
6776 * lisp.h (string_to_number): New decl, replacing ...
6777 (isfloat_string): Remove.
6778 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6779 (read1): Do not accept +. and -. as integers; this
6780 appears to have been a coding error. Similarly, do not accept
6781 strings like +-1e0 as floating point numbers. Do not report
6782 overflow for integer overflows unless the base is not 10 which
6783 means we have no simple and reliable way to continue.
6784 Break out the floating-point parsing into a new
6785 function string_to_number, so that Fstring_to_number parses
6786 floating point numbers consistently with the Lisp reader.
6787 (digit_to_number): Move here from data.c. Make it static inline.
6788 (E_CHAR, EXP_INT): Remove, replacing with ...
6789 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6790 (string_to_number): New function, replacing isfloat_string.
6791 This function checks for valid syntax and produces the resulting
6792 Lisp float number too. Rework it so that string-to-number
6793 no longer mishandles examples like "1.0e+". Use strtoumax,
6794 so that overflow for non-base-10 numbers is reported only when
6795 there's no portable and simple way to convert to floating point.
6797 * textprop.c (set_text_properties_1): Rewrite for clarity,
6798 and to avoid GCC warning about integer overflow.
6800 * intervals.h (struct interval): Use EMACS_INT for members
6801 where EMACS_UINT might cause problems. See
6802 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6803 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6804 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6806 (offset_intervals): Tell GCC not to worry about length overflow
6807 when negating a negative length.
6809 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6810 (overrun_check_free): Likewise.
6812 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6813 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6816 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6817 (gnutls_make_error): Rename local to avoid shadowing.
6818 (gnutls_emacs_global_deinit): ifdef out; not used.
6819 (Fgnutls_boot): Use const for pointer to readonly storage.
6820 Comment out unused local. Fix pointer signedness problems.
6822 * lread.c (openp): Don't stuff size_t into an 'int'.
6823 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6824 about possible signed overflow.
6826 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6827 (GDK_KEY_g): Don't define if already defined.
6828 (xg_prepare_tooltip): Avoid pointer signedness problem.
6829 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6831 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6832 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6834 * xfns.c (Fx_window_property): Simplify a bit,
6835 to make a bit faster and to avoid GCC 4.6.0 warning.
6836 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6838 * fns.c (internal_equal): Don't assume size_t fits in int.
6840 * alloc.c (compact_small_strings): Tighten assertion a little.
6842 Replace pEd with more-general pI, and fix some printf arg casts.
6843 * lisp.h (pI): New macro, generalizing old pEd macro to other
6844 conversion specifiers. For example, use "...%"pI"d..." rather
6845 than "...%"pEd"...".
6846 (pEd): Remove. All uses replaced with similar uses of pI.
6847 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6848 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6849 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6850 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6851 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6852 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6853 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6855 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6856 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6857 * print.c (safe_debug_print, print_object): Likewise.
6858 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6860 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6861 avoiding the 0 flag, which is not portable.
6862 * process.c (Fmake_network_process): Use pI to avoid cast.
6863 * region-cache.c (pp_cache): Likewise.
6864 * xdisp.c (decode_mode_spec): Likewise.
6865 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6866 behavior on 64-bit hosts with printf arg.
6867 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6868 (x_stop_queuing_selection_requests): Likewise.
6869 (x_get_window_property): Don't truncate byte count to an 'int'
6872 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6873 here, since it parses constructs like leading '-' and spaces,
6874 which are not wanted; and it overflows with large numbers.
6875 Instead, simply match F[0-9]+, which is what is wanted anyway.
6877 * alloc.c: Remove unportable assumptions about struct layout.
6878 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6879 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6880 (allocate_vectorlike, make_pure_vector): Use the new macros,
6881 plus offsetof, to remove unportable assumptions about struct layout.
6882 These assumptions hold on all porting targets that I know of, but
6883 they are not guaranteed, they're easy to remove, and removing them
6884 makes further changes easier.
6886 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6887 This doesn't fix a bug but makes the code clearer.
6888 (string_overrun_cookie): Now const. Use initializers that
6889 don't formally overflow signed char, to avoid warnings.
6890 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6891 can cause Emacs to crash when string overrun checking is enabled.
6892 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6893 multiple of sizeof (EMACS_INT); it need not be, if
6894 alignof(EMACS_INT) < sizeof (EMACS_INT).
6895 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6897 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6899 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6901 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6903 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6904 supposed to be handshaking. (Bug#8556)
6905 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6907 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6909 * lisp.h (Qdebug): List symbol.
6910 * eval.c (Qdebug): Restore global linkage.
6911 * keyboard.c (debug-on-event): New variable.
6912 (handle_user_signal): Break into debugger when debug-on-event
6913 matches the current signal symbol.
6915 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6917 * alloc.c (check_sblock, check_string_bytes)
6918 (check_string_free_list): Convert to standard C.
6920 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6922 * w32.c (emacs_gnutls_push): Fix typo.
6924 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6926 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6927 "cast to pointer from integer of different size".
6929 Improve doprnt and its use in verror. (Bug#8545)
6930 * doprnt.c (doprnt): Document the set of format control sequences
6931 supported by the function. Use SAFE_ALLOCA instead of always
6934 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6935 is one byte too soon. Don't use xrealloc; instead xfree and
6938 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6940 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6943 * gnutls.c: Renamed global_initialized to
6944 gnutls_global_initialized. Added internals for the
6945 :verify-hostname-error, :verify-error, and :verify-flags
6946 parameters of `gnutls-boot' and documented those parameters in the
6947 docstring. Start callback support.
6948 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6949 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6950 on error. Return error code.
6951 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6952 (emacs_gnutls_read): Likewise.
6953 (Fgnutls_boot): Return handshake error code.
6954 (emacs_gnutls_handle_error): New function.
6955 (wsaerror_to_errno): Likewise.
6957 * w32.h (emacs_gnutls_pull): Add prototype.
6958 (emacs_gnutls_push): Likewise.
6960 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6961 (emacs_gnutls_push): Likewise.
6963 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6965 * process.c (wait_reading_process_output): Check if GnuTLS
6966 buffered some data internally if no FDs are set for TLS
6969 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6970 (LIBS): Link to USER_LIBS.
6971 ($(BLD)/gnutls.$(0)): New target.
6973 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6975 * xdisp.c (handle_single_display_spec): Rename the
6976 display_replaced_before_p argument into display_replaced_p, to
6977 make it consistent with the commentary. Fix typos in the
6980 * textprop.c (syms_of_textprop): Remove dead code.
6981 (copy_text_properties): Delete obsolete commentary about an
6982 interface that was deleted long ago. Fix typos in the description
6985 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6986 to changes in oldXMenu/XMenu.h from 2011-04-16.
6987 <menu_help_message, prev_menu_help_message>: Constify.
6988 (IT_menu_make_room): menu->help_text is now `const char **';
6991 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6992 to changes in oldXMenu/XMenu.h from 2011-04-16.
6993 (struct XMenu): Declare `help_text' `const char **'.
6995 * xfaces.c <Qunspecified>: Make extern again.
6997 * syntax.c: Include sys/types.h before including regex.h, as
7000 * doc.c (get_doc_string): Improve the format passed to `error'.
7002 * doprnt.c (doprnt): Improve commentary.
7004 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7006 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7009 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7010 changes in globals.h immediately force recompilation.
7011 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7012 $(CURDIR)/s/ms-w32.h.
7013 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7015 * character.c (Fchar_direction): Function deleted.
7016 (syms_of_character): Don't defsubr it.
7017 <char-direction-table>: Deleted.
7019 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7021 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7022 * doprnt.c: Include limits.h.
7023 (SIZE_MAX): New macro.
7024 (doprnt): Return a size_t value. 2nd arg is now size_t.
7025 Many local variables are now size_t instead of int or unsigned.
7026 Improve overflow protection. Support `l' modifier for integer
7027 conversions. Support %l conversion. Don't assume an EMACS_INT
7028 argument for integer conversions and for %c.
7030 * lisp.h (doprnt): Restore prototype.
7032 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7035 * Makefile.in (base_obj): Add back doprnt.o.
7037 * deps.mk (doprnt.o): Add back prerequisites.
7038 (callint.o): Depend on character.h.
7040 * eval.c (internal_lisp_condition_case): Include the handler
7041 representation in the error message.
7042 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7043 when breaking from the loop.
7045 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7047 * callint.c (Fcall_interactively): When displaying error message
7048 about invalid control letter, pass the character's codepoint, not
7049 a pointer to its multibyte form. Improve display of the character
7050 in octal and display also its hex code.
7052 * character.c (char_string): Use %x to display the (unsigned)
7053 codepoint of an invalid character, to avoid displaying a bogus
7056 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7057 `error', not SYMBOL_NAME itself.
7059 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7060 character arguments to `error'.
7062 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7063 to `error' in error message about FINAL_CHAR argument. Make sure
7064 FINAL_CHAR is a character, and use %c when it is passed as
7065 argument to `error'.
7067 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7069 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7071 * w32.c: Include <time.h>.
7072 (sys_localtime): New function.
7074 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7076 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7078 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7080 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7082 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7085 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7087 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7088 gl_state.e_property when gl_state.object is Qt.
7090 * insdel.c (make_gap_larger): Remove limitation of buffer size
7093 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7095 * xdisp.c (lookup_glyphless_char_display)
7096 (produce_glyphless_glyph): Handle cons cell entry in
7097 glyphless-char-display.
7098 (Vglyphless_char_display): Document it.
7100 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7101 glyphless-char-display.
7103 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7105 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7107 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7109 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7110 definition for no-X builds.
7112 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7114 Static checks with GCC 4.6.0 and non-default toolkits.
7116 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7118 * process.c (keyboard_bit_set): Define only if SIGIO.
7119 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7120 (send_process): Repair possible setjmp clobbering.
7122 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7124 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7126 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7128 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7129 Define only if needed.
7131 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7132 by pacifying GCC about it. Maybe it's time to retire it?
7133 * xfaces.c (USG, __TIMEVAL__): Likewise.
7135 * dispextern.h (struct redisplay_interface): Rename param
7137 * termhooks.h (struct terminal): Likewise.
7138 * xterm.c (xembed_send_message): Likewise.
7140 * insdel.c (make_gap_smaller): Define only if
7141 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7143 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7146 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7147 so that we aren't warned about unused symbols.
7149 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7151 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7153 * xfns.c (x_real_positions): Mark locals as initialized.
7155 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7157 * xterm.c: Fix problems found by static analysis with other toolkits.
7158 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7159 (x_dispatch_event): Declare static if USE_GTK, and
7160 define if USE_GTK || USE_X_TOOLKIT.
7161 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7162 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7163 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7164 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7166 * xmenu.c (menu_help_callback): Pointer type fixes.
7167 Use const pointers when pointing at readonly data. Avoid pointer
7169 (FALSE): Remove unused macro.
7170 (update_frame_menubar): Remove unused decl.
7172 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7174 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7175 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7176 (single_menu_item): Rename local to avoid shadowing.
7178 * keyboard.c (make_lispy_event): Remove unused local var.
7180 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7181 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7183 * bitmaps: Change bitmaps from unsigned char back to the X11
7184 compatible char. Avoid the old compiler warnings about
7185 out-of-range initializers by using, for example, '\xab' rather
7188 * xgselect.c (xgselect_initialize): Check vs interface
7189 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7191 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7193 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7194 to read-only memory.
7196 * fns.c (vector): Remove; this old hack is no longer needed.
7198 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7200 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7202 * xrdb.c (x_load_resources): Omit unused local.
7204 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7205 (x_window): Rename locals to avoid shadowing.
7206 (USG): Use the kludged USG macro, to pacify gcc.
7208 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7209 (x_term_init): Remove local to avoid shadowing.
7211 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7213 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7214 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7216 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7218 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7220 Fix regex.c, syntax.c and friends for buffers > 2GB.
7221 * syntax.h (struct gl_state_s): Declare character position members
7224 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7226 * textprop.c (verify_interval_modification, interval_of):
7227 Declare arguments EMACS_INT.
7229 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7232 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7234 * indent.c (Fvertical_motion): Local variable it_start is now
7237 * regex.c (re_match, re_match_2, re_match_2_internal)
7238 (bcmp_translate, regcomp, regexec, print_double_string)
7239 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7240 (re_compile_pattern, re_exec): Declare arguments and local
7241 variables `size_t' and `ssize_t' and return values `regoff_t', as
7243 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7244 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7245 <compile_stack_type>: `size' and `avail' are now `size_t'.
7247 * regex.h <regoff_t>: Use ssize_t, not int.
7248 (re_search, re_search_2, re_match, re_match_2): Arguments that
7249 specify buffer/string position and length are now ssize_t and
7250 size_t. Return type is regoff_t.
7252 2011-04-16 Ben Key <bkey76@gmail.com>
7254 * nsfont.m: Fixed bugs in ns_get_family and
7255 ns_descriptor_to_entity that were caused by using free to
7256 deallocate memory blocks that were allocated by xmalloc (via
7257 xstrdup). This caused Emacs to crash when compiled with
7258 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7259 --enable-checking=xmallocoverrun). xfree is now used to
7260 deallocate these memory blocks.
7262 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7264 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7266 emacs_write: Accept and return EMACS_INT for sizes.
7267 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7269 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7270 Accept and return EMACS_INT.
7271 (emacs_gnutls_write): Return the number of bytes written on
7273 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7274 (emacs_read, emacs_write): Remove check for negative size, as the
7275 Emacs source code has been audited now.
7276 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7277 (emacs_read, emacs_write): Use it.
7278 * process.c (send_process): Adjust to the new signatures of
7279 emacs_write and emacs_gnutls_write. Do not attempt to store
7280 a byte offset into an 'int'; it might overflow.
7281 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7283 * sound.c: Don't assume sizes fit in 'int'.
7284 (struct sound_device.period_size, alsa_period_size):
7285 Return EMACS_INT, not int.
7286 (struct sound_device.write, vox_write, alsa_write):
7287 Accept EMACS_INT, not int.
7288 (wav_play, au_play): Use EMACS_INT to store sizes and to
7289 record read return values.
7291 2011-04-15 Ben Key <bkey76@gmail.com>
7293 * keyboard.c (Qundefined): Don't declare static since it is used
7295 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7296 static since they are used in nsfont.m.
7298 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7300 * process.c (Qprocessp): Don't declare static.
7301 * lisp.h (Qprocessp): Declare again.
7303 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7305 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7307 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7309 Improve C-level modularity by making more things 'static'.
7311 Don't publish debugger-only interfaces to other modules.
7312 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7313 (verify_bytepos, count_markers): Move decls to the only modules
7315 * region-cache.h (pp_cache): Likewise.
7316 * window.h (check_all_windows): Likewise.
7317 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7319 * sysdep.c (croak): Now static, if
7320 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7321 * syssignal.h (croak): Declare only if not static.
7323 * alloc.c (refill_memory_reserve): Now static if
7324 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7325 * lisp.h (refill_memory_reserve): Declare only if not static.
7327 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7328 Define only if USE_LUCID.
7330 * xrdb.c (x_customization_string, x_rm_string): Now static.
7332 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7333 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7335 * xdisp.c (draw_row_with_mouse_face): Now static.
7336 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7338 * window.h (check_all_windows): Mark externally visible.
7340 * window.c (window_deletion_count): Now static.
7342 * undo.c: Make symbols static if they're not exported.
7343 (last_undo_buffer, last_boundary_position, pending_boundary):
7346 * textprop.c (interval_insert_behind_hooks): Now static.
7347 (interval_insert_in_front_hooks): Likewise.
7349 * term.c: Make symbols static if they're not exported.
7350 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7351 (max_frame_lines, tty_set_terminal_modes):
7352 (tty_reset_terminal_modes, tty_turn_off_highlight):
7353 (get_tty_terminal): Now static.
7354 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7355 * termhooks.h (term_mouse_moveto): Do not declare if
7357 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7358 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7360 * sysdep.c: Make symbols static if they're not exported.
7361 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7363 (sigprocmask_set, full_mask): Remove; unused.
7364 (wait_debugging): Mark as visible.
7365 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7366 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7368 * syntax.c (syntax_temp): Define only if !__GNUC__.
7370 * sound.c (current_sound_device, current_sound): Now static.
7372 * search.c (searchbufs, searchbuf_head): Now static.
7374 * scroll.c (scroll_cost): Remove; unused.
7375 * dispextern.h (scroll_cost): Remove decl.
7377 * region-cache.h (pp_cache): Mark as externally visible.
7379 * process.c: Make symbols static if they're not exported.
7380 (process_tick, update_tick, create_process, chan_process):
7381 (Vprocess_alist, proc_buffered_char, datagram_access):
7382 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7383 (deactivate_process): Mark defn as static, as well as decl.
7384 * lisp.h (create_process): Remove decl.
7385 * process.h (chan_process, Vprocess_alist): Remove decls.
7387 * print.c: Make symbols static if they're not exported.
7388 (print_depth, new_backquote_output, being_printed, print_buffer):
7389 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7390 (print_interval, print_number_index, initial_stderr_stream):
7392 * lisp.h (Fprinc): Remove decl.
7393 (debug_output_compilation_hack): Mark as externally visible.
7395 * sysdep.c (croak): Move decl from here to syssignal.h.
7396 * syssignal.h (croak): Put it here, so the API can be checked when
7397 'croak' is called from dissociate_if_controlling_tty.
7399 * minibuf.c: Make symbols static if they're not exported.
7400 (minibuf_save_list, choose_minibuf_frame): Now static.
7401 * lisp.h (choose_minibuf_frame): Remove decl.
7403 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7405 * lread.c: Make symbols static if they're not exported.
7406 (read_objects, initial_obarray, oblookup_last_bucket_number):
7408 (make_symbol): Remove; unused.
7409 * lisp.h (initial_obarray, make_symbol): Remove decls.
7411 * keyboard.c: Make symbols static if they're not exported.
7412 (single_kboard, recent_keys_index, total_keys, recent_keys):
7413 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7414 (this_single_command_key_start, echoing, last_auto_save):
7415 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7416 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7417 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7418 (Vlispy_mouse_stem, double_click_count):
7420 (force_auto_save_soon): Define only if SIGDANGER.
7421 (ignore_mouse_drag_p): Now static if
7422 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7423 (print_help): Remove; unused.
7424 (stop_character, last_timer_event): Mark as externally visible.
7425 * keyboard.h (ignore_mouse_drag_p): Declare only if
7426 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7427 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7428 * lisp.h (echoing): Remove decl.
7429 (force_auto_save_soon): Declare only if SIGDANGER.
7430 * xdisp.c (redisplay_window): Simplify code, to make it more
7431 obvious that ignore_mouse_drag_p is not accessed if !defined
7432 USE_GTK && !defined HAVE_NS.
7434 * intervals.c: Make symbols static if they're not exported.
7435 (merge_properties_sticky, merge_interval_right, delete_interval):
7437 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7439 * insdel.c: Make symbols static if they're not exported.
7440 However, leave prepare_to_modify_buffer alone. It's never
7441 called from outside this function, but that appears to be a bug.
7442 (combine_after_change_list, combine_after_change_buffer):
7443 (adjust_after_replace, signal_before_change): Now static.
7444 (adjust_after_replace_noundo): Remove; unused.
7445 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7446 (signal_before_change): Remove decls.
7448 * indent.c (val_compute_motion, val_vmotion): Now static.
7450 * image.c: Make symbols static if they're not exported.
7451 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7453 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7454 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7456 * fringe.c (standard_bitmaps): Now static.
7457 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7459 * frame.c: Make symbols static if they're not exported.
7460 (x_report_frame_params, make_terminal_frame): Now static.
7461 (get_frame_param): Now static, unless HAVE_NS.
7462 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7463 (x_get_resource_string): Remove; not used.
7464 * frame.h (make_terminal_frame, x_report_frame_params):
7465 (x_get_resource_string); Remove decls.
7466 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7467 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7469 * font.c, fontset.c: Make symbols static if they're not exported.
7470 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7471 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7472 * font.c (font_close_object): Now static.
7473 * font.h (font_close_object): Remove.
7474 * fontset.c (FONTSET_OBJLIST): Remove.
7475 (free_realized_fontset) #if-0 the body, which does nothing.
7476 (face_suitable_for_char_p): #if-0, as it's never called.
7477 * fontset.h (face_suitable_for_char_p): Remove decl.
7478 * xfaces.c (face_at_string_position):
7479 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7480 since 0 is always ASCII.
7482 * fns.c (weak_hash_tables): Now static.
7484 * fileio.c: Make symbols static if they're not exported.
7485 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7486 (Vwrite_region_annotation_buffers): Now static.
7488 * eval.c: Make symbols static if they're not exported.
7489 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7490 * lisp.h (backtrace_list): Remove decl.
7492 * emacs.c: Make symbols static if they're not exported.
7493 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7494 (fatal_error_code, fatal_error_signal_hook, standard_args):
7496 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7497 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7498 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7499 * lisp.h (fatal_error_signal_hook): Remove decl.
7500 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7502 * editfns.c: Move a (normally-unused) function to its only use.
7503 * editfns.c, lisp.h (get_operating_system_release): Remove.
7504 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7505 worth the hassle of breaking this out.
7507 * xterm.c: Make symbols static if they're not exported.
7508 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7509 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7510 (x_destroy_window, x_delete_display):
7512 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7513 (x_mouse_leave): Remove; unused.
7514 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7515 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7516 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7518 (x_mouse_leave): Declare only if WINDOWSNT.
7519 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7520 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7523 * ftxfont.c: Make symbols static if they're not exported.
7524 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7526 * font.h (ftxfont_driver): Likewise.
7528 * xfns.c: Make symbols static if they're not exported.
7529 (x_last_font_name, x_display_info_for_name):
7530 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7531 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7532 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7533 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7534 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7535 (last_show_tip_args): Now static.
7536 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7537 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7538 (x_screen_planes): Remove; unused.
7539 * dispextern.h (x_screen_planes): Remove decl.
7541 * dispnew.c: Make symbols static if they're not exported.
7542 * dispextern.h (redraw_garbaged_frames, scrolling):
7543 (increment_row_positions): Remove.
7544 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7545 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7547 (redraw_garbaged_frames): Remove; unused.
7549 * xfaces.c: Make symbols static if they're not exported.
7550 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7552 * xterm.h (defined_color): Remove decls.
7553 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7554 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7555 (menu_face_changed_default, defined_color, free_realized_face):
7556 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7557 (ascii_face_of_lisp_face): Remove; unused.
7559 * xdisp.c: Make symbols static if they're not exported.
7560 * dispextern.h (scratch_glyph_row, window_box_edges):
7561 (glyph_to_pixel_coords, set_cursor_from_row):
7562 (get_next_display_element, set_iterator_to_next):
7563 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7564 (show_mouse_face): Remove decls
7565 * frame.h (message_buf_print): Likewise.
7566 * lisp.h (pop_message, set_message, check_point_in_composition):
7568 * xterm.h (set_vertical_scroll_bar): Likewise.
7569 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7570 (message_buf_print, scratch_glyph_row, displayed_buffer):
7571 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7572 (get_next_display_element, show_mouse_face, window_box_edges):
7573 (frame_to_window_pixel_xy, check_point_in_composition):
7574 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7575 (glyph_to_pixel_coords): Remove; unused.
7577 * dired.c (file_name_completion): Now static.
7579 * dbusbind.c (xd_in_read_queued_messages): Now static.
7581 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7582 * data.c (circular_list_error): Remove.
7584 * commands.h (last_point_position, last_point_position_buffer):
7585 (last_point_position_window): Remove decls.
7586 * keyboard.c: Make these variables static.
7588 * coding.h (coding, code_convert_region, encode_coding_gap):
7590 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7591 (iso_code_class, detect_coding, code_convert_region): Now static.
7592 (encode_coding_gap): Remove; unused.
7594 * chartab.c (chartab_chars, chartab_bits): Now static.
7596 * charset.h (charset_iso_8859_1): Remove decl.
7597 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7600 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7601 * ccl.c (Vccl_program_table): Now static.
7602 (check_ccl_update): Remove; unused.
7604 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7605 * category.h: ... from here.
7606 * category.c (check_category_table, set_category_set): Now static.
7608 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7609 * lisp.h: Remove these decls.
7611 * buffer.c (buffer_count): Remove unused var.
7613 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7614 so that it's not optimized away.
7615 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7616 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7617 exported only to the debugger.
7619 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7620 * atimer.h (run_all_atimers): Remove; not exported.
7622 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7623 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7624 was inaccessible from Lisp.
7625 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7626 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7628 alloc.c: Import and export fewer symbols, and remove unused items.
7629 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7631 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7632 it's not optimized away by whole-program optimization.
7633 (message_enable_multibyte, free_misc): Remove.
7634 (catchlist, handlerlist, mark_backtrace):
7635 Declare only if BYTE_MARK_STACK.
7636 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7637 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7638 (message_enable_multibyte): Remove decl.
7639 (free_misc, interval_free_list, float_block, float_block_index):
7640 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7641 (cons_free_list, last_marked_index):
7643 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7644 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7645 (mark_backtrace): Define only if BYTE_MARK_STACK.
7646 * xdisp.c (message_enable_multibyte): Now static.
7648 Declare Lisp_Object Q* variables to be 'static' if not exported.
7649 This makes it easier for human readers (and static analyzers)
7650 to see whether these variables are used from other modules.
7651 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7652 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7653 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7654 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7655 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7656 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7657 * xmenu.c, xselect.c:
7658 Declare Q* vars static if they are not used in other modules.
7659 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7660 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7661 Remove decls of unexported vars.
7662 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7664 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7666 Make Emacs functions such as Fatom 'static' by default.
7667 This makes it easier for human readers (and static analyzers)
7668 to see whether these functions can be called from other modules.
7669 DEFUN now defines a static function. To make the function external
7670 so that it can be used in other C modules, use the new macro DEFUE.
7671 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7672 (Finit_image_library):
7673 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7674 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7675 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7676 Remove decls, since these functions are now static.
7677 (Funintern, Fget_internal_run_time): New decls, since these functions
7678 were already external.
7680 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7681 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7682 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7683 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7684 * keyboard.c, keymap.c, lread.c:
7685 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7686 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7687 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7688 Mark functions with DEFUE instead of DEFUN,
7689 if they are used in other modules.
7690 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7691 decls for now-static functions.
7692 * buffer.h (Fdelete_overlay): Remove decl.
7693 * callproc.c (Fgetenv_internal): Mark as internal.
7694 * composite.c (Fremove_list_of_text_properties): Remove decl.
7695 (Fcomposition_get_gstring): New forward static decl.
7696 * composite.h (Fcomposite_get_gstring): Remove decl.
7697 * dired.c (Ffile_attributes): New forward static decl.
7698 * doc.c (Fdocumntation_property): New forward static decl.
7699 * eval.c (Ffetch_bytecode): New forward static decl.
7700 (Funintern): Remove extern decl; now in .h file where it belongs.
7701 * fileio.c (Fmake_symbolic_link): New forward static decl.
7702 * image.c (Finit_image_library): New forward static decl.
7703 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7704 * intervals.h (Fprevious_property_change):
7705 (Fremove_list_of_text_properties): Remove decls.
7706 * keyboard.c (Fthis_command_keys): Remove decl.
7707 (Fcommand_execute): New forward static decl.
7708 * keymap.c (Flookup_key): New forward static decl.
7709 (Fcopy_keymap): Now static.
7710 * keymap.h (Flookup_key): Remove decl.
7711 * process.c (Fget_process): New forward static decl.
7712 (Fprocess_datagram_address): Mark as internal.
7713 * syntax.c (Fsyntax_table_p): New forward static decl.
7714 (skip_chars): Remove duplicate decl.
7715 * textprop.c (Fprevious_property_change): New forward static decl.
7716 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7718 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7719 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7721 * editfns.c (Fformat): Remove unreachable code.
7723 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7725 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7728 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7730 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7731 when at ZV. (Bug#8487)
7733 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7735 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7737 * keyboard.c (parse_tool_bar_item): Likewise.
7738 * sound.c (sound_cleanup, alsa_close): Likewise.
7739 * termcap.c (tgetent): Likewise.
7740 * xfns.c (x_default_font_parameter): Likewise.
7741 * xsettings.c (read_and_apply_settings): Likewise.
7743 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7744 (overrun_check_free): Protoize.
7746 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7748 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7749 since callers should never pass a negative size.
7750 Change the signature to match that of plain 'read' and 'write'; see
7751 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7752 * lisp.h: Update prototypes of emacs_write and emacs_read.
7754 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7756 * xdisp.c (redisplay_window): Don't try to determine the character
7757 position of the scroll margin if the window start point w->startp
7758 is outside the buffer's accessible region. (Bug#8468)
7760 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7762 Fix write-region and its subroutines for buffers > 2GB.
7763 * fileio.c (a_write, e_write): Modify declaration of arguments and
7764 local variables to support buffers larger than 2GB.
7765 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7767 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7768 argument, local variables, and return value.
7770 * lisp.h: Update prototypes of emacs_write and emacs_read.
7772 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7774 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7776 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7778 Fix more problems found by GCC 4.6.0's static checks.
7780 * xdisp.c (vmessage): Use a better test for character truncation.
7782 * charset.c (load_charset_map): <, not <=, for optimization,
7783 and to avoid potential problems with integer overflow.
7784 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7785 * casetab.c (set_identity, shuffle): Likewise.
7786 * editfns.c (Fformat): Likewise.
7787 * syntax.c (skip_chars): Likewise.
7789 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7790 This also lets GCC 4.6.0 generate slightly better loop code.
7792 * callint.c (Fcall_interactively): <, not <=, for optimization.
7793 (Fcall_interactively): Count the number of arguments produced,
7794 not the number of arguments given. This is simpler and lets GCC
7795 4.6.0 generate slightly better code.
7797 * ftfont.c: Distingish more carefully between FcChar8 and char.
7798 The previous code passed unsigned char * to a functions like
7799 strlen and xstrcasecmp that expect char *, which does not
7800 conform to the C standard.
7801 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7802 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7803 char * when the C standard requires it.
7805 * keyboard.c (read_char): Remove unused var.
7807 * eval.c: Port to Windows vsnprintf (Bug#8435).
7809 (SIZE_MAX): Define if the headers do not.
7810 (verror): Do not give up if vsnprintf returns a negative count.
7811 Instead, grow the buffer. This ports to Windows vsnprintf, which
7812 does not conform to C99. Problem reported by Eli Zaretskii.
7813 Also, simplify the allocation scheme, by avoiding the need for
7814 calling realloc, and removing the ALLOCATED variable.
7816 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7818 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7819 But keep the doprint source code for now, as we might revamp it
7820 and use it again (Bug#8435).
7821 * lisp.h (doprnt): Remove.
7822 * Makefile.in (base_obj): Remove doprnt.o.
7823 * deps.mk (doprnt.o): Remove.
7825 error: Print 32- and 64-bit integers portably (Bug#8435).
7826 Without this change, on typical 64-bit hosts error ("...%d...", N)
7827 was used to print both 32- and 64-bit integers N, which relied on
7829 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7830 * lisp.h (error, verror): Mark as printf-like functions.
7831 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7832 Report overflow in size calculations when allocating printf buffer.
7833 Do not truncate output string at its first null byte.
7834 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7835 Truncate the output at a character boundary, since vsnprintf does not
7837 * charset.c (check_iso_charset_parameter): Convert internal
7838 character to string before calling 'error', since %c now has the
7840 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7841 overflow when computing char to be passed to 'error'. Do not
7842 pass Lisp_Object to 'error'; pass the integer instead.
7843 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7844 formatted with plain %d.
7846 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7848 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7850 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7852 * xterm.c (x_catch_errors): Remove duplicate declaration.
7854 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7856 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7858 2011-04-10 Jim Meyering <meyering@redhat.com>
7860 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7861 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7862 return ssize_t not "int", and use size_t as the buffer length.
7863 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7864 * gnutls.h: Update declarations.
7865 * process.c (read_process_output): Use ssize_t, to match.
7866 (send_process): Likewise.
7868 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7870 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7872 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7874 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7875 Use unsigned char, to match FcChar8 type definition.
7877 * xterm.c (handle_one_xevent):
7878 * xmenu.c (create_and_show_popup_menu):
7879 * xselect.c (x_decline_selection_request)
7880 (x_reply_selection_request): Avoid type-punned deref of X events.
7882 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7884 Fix some uses of `int' instead of EMACS_INT.
7885 * search.c (string_match_1, fast_string_match)
7886 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7887 (scan_buffer, find_next_newline_no_quit)
7888 (find_before_next_newline, search_command, Freplace_match)
7889 (Fmatch_data): Make some `int' variables be EMACS_INT.
7891 * xdisp.c (display_count_lines): 3rd argument and return value now
7892 EMACS_INT. All callers changed.
7893 (pint2hrstr): Last argument is now EMACS_INT.
7895 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7896 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7897 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7898 (decode_coding_utf_16, decode_coding_emacs_mule)
7899 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7900 (decode_coding_ccl, decode_coding_charset)
7901 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7902 (decode_coding_iso_2022, decode_coding_emacs_mule)
7903 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7904 <char_offset, last_offset>: Declare EMACS_INT.
7905 (encode_coding_utf_8, encode_coding_utf_16)
7906 (encode_coding_emacs_mule, encode_invocation_designation)
7907 (encode_designation_at_bol, encode_coding_iso_2022)
7908 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7909 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7911 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7912 (encode_invocation_designation): Last argument P_NCHARS is now
7914 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7915 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7917 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7920 * ccl.c (Fccl_execute_on_string): Declare some variables
7923 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7925 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7927 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7929 * process.c (Fformat_network_address): Doc fix.
7931 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7933 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7935 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7937 * keyboard.c (read_char): Call Lisp function help-form-show,
7938 instead of using internal_with_output_to_temp_buffer.
7939 (Qhelp_form_show): New var.
7940 (syms_of_keyboard): Use DEFSYM macro.
7942 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7944 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7946 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7948 * process.c (Flist_processes): Remove to Lisp.
7949 (list_processes_1): Delete.
7951 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7953 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7955 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7957 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7959 Fix more problems found by GCC 4.6.0's static checks.
7961 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7963 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7965 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7967 * xdisp.c (vmessage): Mark as a printf-like function.
7969 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7971 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7973 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7974 printf-like functions.
7975 (tiff_load): Add casts to remove these marks before passing them
7976 to system-supplied API.
7978 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7980 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7981 This avoids several warnings with gcc -Wstrict-overflow.
7982 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7983 directly, rather than having caller test rule sign. This avoids
7984 some unnecessary tests.
7985 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7986 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7987 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7989 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7990 (xfont_open): Avoid unnecessary tests.
7992 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7994 * composite.h, composite.c (composition_gstring_put_cache):
7995 Use EMACS_INT, not int, for length.
7997 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7998 breaking out part of COMPOSITION_DECODE_RULE.
7999 (COMPOSITION_DECODE_RULE): Use it.
8000 * composite.c (get_composition_id): Remove unused local vars,
8001 by using the new macro.
8003 * textprop.c (set_text_properties_1): Change while to do-while,
8004 since the condition is always true at first.
8006 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8007 (interval_deletion_adjustment): Return unsigned value.
8010 * process.c (list_processes_1, create_pty, read_process_output):
8011 (exec_sentinel): Remove vars that were set but not used.
8012 (create_pty): Remove unnecessary "volatile"s.
8013 (Fnetwork_interface_info): Avoid possibility of int overflow.
8014 (read_process_output): Do adaptive read buffering even if carryover.
8015 (read_process_output): Simplify nbytes computation if buffered.
8017 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8019 * syntax.c (scan_words): Remove var that was set but not used.
8020 (update_syntax_table): Use unsigned instead of int.
8022 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8023 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8024 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8026 * print.c (print_error_message): Avoid int overflow.
8028 * font.c (font_list_entities): Redo for clarity,
8029 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8031 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8032 (font_score): Avoid potential overflow in diff calculation.
8034 * fns.c (substring_both): Remove var that is set but not used.
8035 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8037 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8039 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8040 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8041 can always succeed if overflow has undefined behavior.
8043 * search.c (boyer_moore, wordify): Remove vars set but not used.
8044 (wordify): Omit three unnecessary tests.
8046 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8047 All callers changed. This avoids the need for an unused var.
8049 * casefiddle.c (casify_region): Remove var that is set but not used.
8051 * dired.c (file_name_completion): Remove var that is set but not used.
8053 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8055 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8056 (Finsert_file_contents): Remove unnecessary code checking fd.
8058 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8059 Check for integer overflow on size calculations.
8061 * buffer.c (Fprevious_overlay_change): Remove var that is set
8064 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8065 Remove vars that are set but not used.
8066 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8067 (timer_check_2): Mark vars as initialized.
8069 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8071 * image.c (lookup_image): Remove var that is set but not used.
8072 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8074 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8075 that are set but not used.
8077 * xfns.c (make_invisible_cursor): Don't return garbage
8078 if XCreateBitmapFromData fails (Bug#8410).
8080 * xselect.c (x_get_local_selection, x_handle_property_notify):
8081 Remove vars that are set but not used.
8083 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8084 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8086 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8087 Remove var that is set but not used.
8088 (scroll_bar_windows_size): Now size_t, not int.
8089 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8092 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8093 (map_tty_color) [!defined MSDOS]: Likewise.
8095 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8097 * coding.c: Remove vars that are set but not used.
8098 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8099 All callers changed.
8100 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8101 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8102 (decode_coding_charset): Remove vars that are set but not used.
8104 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8105 that is set but not used.
8107 * print.c (print_object): Remove var that is set but not used.
8109 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8110 The gnulib version avoids calling malloc in the usual case,
8111 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8112 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8113 * filelock.c (current_lock_owner): Likewise.
8114 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8115 * sysdep.c: Include allocator.h, careadlinkat.h.
8116 (emacs_no_realloc_allocator): New static constant.
8117 (emacs_readlink): New function.
8118 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8119 ../lib/careadlinkat.h.
8121 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8123 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8124 first non-nil return value).
8126 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8128 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8129 if not defined (Bug#8403).
8131 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8133 * xdisp.c (display_count_lines): Remove parameter `start',
8134 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8135 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8136 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8137 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8138 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8139 and thereabouts. All callers changed.
8140 (get_per_char_metric): Remove parameter `f', unused since
8141 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8143 2011-04-02 Jim Meyering <meyering@redhat.com>
8145 do not dereference NULL upon failed strdup
8146 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8147 (ns_get_family): Likewise.
8149 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8151 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8153 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8155 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8158 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8160 Add lexical binding.
8162 * window.c (Ftemp_output_buffer_show): New fun.
8163 (Fsave_window_excursion):
8164 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8166 * lread.c (lisp_file_lexically_bound_p): New function.
8167 (Fload): Bind Qlexical_binding.
8168 (readevalloop): Remove `evalfun' arg.
8169 Bind Qinternal_interpreter_environment.
8170 (Feval_buffer): Bind Qlexical_binding.
8171 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8173 (syms_of_lread): Declare `lexical-binding'.
8175 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8177 * keyboard.c (eval_dyn): New fun.
8178 (menu_item_eval_property): Use it.
8180 * image.c (parse_image_spec): Use Ffunctionp.
8182 * fns.c (concat, mapcar1): Accept byte-code-functions.
8184 * eval.c (Fsetq): Handle lexical vars.
8185 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8186 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8187 (FletX, Flet): Obey lexical binding.
8188 (Fcommandp): Handle closures.
8189 (Feval): New `lexical' arg.
8190 (eval_sub): New function extracted from Feval. Use it almost
8191 everywhere where Feval was used. Look up vars in lexical env.
8193 (Ffunctionp): Move from subr.el.
8194 (Ffuncall): Handle closures.
8195 (apply_lambda): Remove `eval_flags'.
8196 (funcall_lambda): Handle closures and new byte-code-functions.
8197 (Fspecial_variable_p): New function.
8198 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8199 but without exporting it to Lisp.
8201 * doc.c (Fdocumentation, store_function_docstring):
8202 * data.c (Finteractive_form): Handle closures.
8204 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8207 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8209 (exec_byte_code): New function extracted from Fbyte_code to handle new
8210 calling convention for byte-code-functions. Add new byte-codes.
8212 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8214 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8216 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8218 * xdisp.c (redisplay_internal): Fix prototype.
8220 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8222 * xdisp.c (SCROLL_LIMIT): New macro.
8223 (try_scrolling): Use it when setting scroll_limit.
8224 Limit scrolling to 100 screen lines.
8225 (redisplay_window): Even when falling back on "recentering",
8226 position point in the window according to scroll-conservatively,
8227 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8229 (try_scrolling): When point is above the window, allow searching
8230 as far as scroll_max, or one screenful, to compute vertical
8231 distance from PT to the scroll margin position. This prevents
8232 try_scrolling from unnecessarily failing when
8233 scroll-conservatively is set to a value slightly larger than the
8234 window height. Clean up the case of PT below the margin at bottom
8235 of window: scroll_max can no longer be INT_MAX. When aggressive
8236 scrolling is in use, don't let point enter the opposite scroll
8237 margin as result of the scroll.
8238 (syms_of_xdisp) <scroll-conservatively>: Document the
8239 threshold of 100 lines for never-recentering scrolling.
8241 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8243 * dispextern.h (move_it_by_lines):
8244 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8245 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8246 (message_log_check_duplicate): Remove parameters `prev_bol' and
8247 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8248 (redisplay_internal): Remove parameter `preserve_echo_area',
8249 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8251 * indent.c (Fvertical_motion):
8252 * window.c (window_scroll_pixel_based, Frecenter):
8253 Don't pass `need_y_p' to `move_it_by_lines'.
8255 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8257 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8258 steal a few bits to be more compact.
8259 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8260 Remove unneeded casts.
8262 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8264 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8266 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8267 binding" message (bug#7967).
8269 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8271 Fix more problems found by GCC 4.6.0's static checks.
8273 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8274 Remove unused local var.
8276 * editfns.c (Fmessage_box): Remove unused local var.
8278 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8279 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8280 Omit unused local vars.
8281 * window.c (shrink_windows): Omit unused local var.
8282 * menu.c (digest_single_submenu): Omit unused local var.
8283 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8284 Omit unused local var.
8286 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8287 Don't assume string length fits in int.
8288 (keyremap_step, read_key_sequence): Use size_t for sizes.
8289 (read_key_sequence): Don't check last_real_key_start redundantly.
8291 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8292 instead of alloca (Bug#8344).
8294 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8295 (Fbacktrace_frame): Don't assume nframes fits in int.
8297 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8299 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8302 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8304 * cm.c (calccost): Turn while-do into do-while, for clarity.
8306 * keyboard.c (syms_of_keyboard): Use the same style as later
8307 in this function when indexing through an array. This also
8308 works around GCC bug 48267.
8310 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8312 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8314 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8315 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8317 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8318 This avoids undefined behavior on integer overflow, and is a bit
8319 more convenient anyway since it is compared to a size_t variable.
8321 Variadic C functions now count arguments with size_t, not int.
8322 This avoids an unnecessary limitation on 64-bit machines, which
8323 caused (substring ...) to crash on large vectors (Bug#8344).
8324 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8325 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8326 All variadic functions and their callers changed accordingly.
8327 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8328 * data.c (arith_driver, float_arith_driver): Likewise.
8329 * editfns.c (general_insert_function): Likewise.
8330 * eval.c (struct backtrace.nargs, interactive_p)
8331 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8332 (funcall_lambda, mark_backtrace): Likewise.
8333 * fns.c (concat): Likewise.
8334 * frame.c (x_set_frame_parameters): Likewise.
8335 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8336 0 if not found, not -1. All callers changed.
8338 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8339 (stack_copy_size): Now size_t, not int.
8340 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8342 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8344 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8345 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8346 All callers changed.
8348 * lisp.h (multibyte_char_to_unibyte):
8349 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8350 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8351 * character.h (CHAR_TO_BYTE8):
8352 * cmds.c (internal_self_insert):
8353 * editfns.c (general_insert_function):
8354 * keymap.c (push_key_description):
8355 * search.c (Freplace_match):
8356 * xdisp.c (message_dolog, set_message_1): All callers changed.
8358 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8360 * keyboard.c (safe_run_hook_funcall): New function.
8361 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8362 don't set the hook to nil, but remove the offending function instead.
8363 (Qcommand_hook_internal): Remove, unused.
8364 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8365 Vcommand_hook_internal.
8367 * eval.c (enum run_hooks_condition): Remove.
8368 (funcall_nil, funcall_not): New functions.
8369 (run_hook_with_args): Call each function through a `funcall' argument.
8370 Remove `cond' argument, now redundant.
8371 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8372 (Frun_hook_with_args_until_failure): Adjust accordingly.
8373 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8375 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8377 * dispextern.h (string_buffer_position): Remove declaration.
8379 * print.c (strout): Remove parameter `multibyte', unused since
8380 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8382 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8383 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8384 All callers changed.
8386 * w32.c (_wsa_errlist): Use braces for struct initializers.
8388 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8389 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8390 All callers changed.
8391 (string_buffer_position): Likewise. Also, make static (it's never
8392 used outside xdisp.c).
8393 (cursor_row_p): Remove parameter `w', unused since
8394 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8395 (decode_mode_spec): Remove parameter `precision', introduced during
8396 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8397 All callers changed.
8399 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8401 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8403 2011-03-27 Anders Lindgren <andlind@gmail.com>
8405 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8406 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8407 (ns_update_auto_hide_menu_bar): New functions.
8408 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8409 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8410 ns_constrain_all_frames.
8411 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8412 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8414 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8416 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8418 2011-03-27 Glenn Morris <rgm@gnu.org>
8420 * syssignal.h: Replace RETSIGTYPE with void.
8421 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8422 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8423 Replace SIGTYPE with void everywhere.
8424 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8425 * s/template.h (SIGTYPE): Remove commented out definition.
8427 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8429 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8430 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8432 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8434 * w32.c (read_unc_volume): Use parameter `henum', instead of
8435 global variable `wget_enum_handle'.
8437 * keymap.c (describe_vector): Remove parameters `indices' and
8438 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8439 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8441 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8443 * keyboard.c (timer_check): Remove parameter `do_it_now',
8444 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8445 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8446 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8448 * keyboard.c (read_char):
8449 * w32menu.c (w32_menu_display_help):
8450 * xmenu.c (show_help_event, menu_help_callback):
8451 Adjust calls to `show_help_echo'.
8453 * gtkutil.c (xg_maybe_add_timer):
8454 * keyboard.c (readable_events):
8455 * process.c (wait_reading_process_output):
8456 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8458 * insdel.c (adjust_markers_gap_motion):
8459 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8460 (gap_left, gap_right): Don't call it.
8462 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8464 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8465 incurred during fontification.
8467 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8469 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8470 (DEFVAR_PER_BUFFER): Don't pass it.
8472 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8473 (scrolling_window): Don't pass it.
8475 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8477 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8479 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8481 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8482 of variables specific to SELinux and computation of `encoded_absname'.
8484 * image.c (XPutPixel): Remove unused variable `height'.
8486 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8488 * unexw32.c (get_section_info): Remove unused variable `section'.
8490 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8491 (system_process_attributes): Remove unused variable `sess'.
8492 (sys_read): Remove unused variable `err'.
8494 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8495 (w32_wnd_proc): Remove unused variable `isdead'.
8496 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8497 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8498 (x_create_tip_frame): Remove unused variable `tem'.
8500 * w32inevt.c (w32_console_read_socket):
8501 Remove unused variable `no_events'.
8503 * w32term.c (x_draw_composite_glyph_string_foreground):
8504 Remove unused variable `width'.
8506 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8508 * w32term.c (x_set_glyph_string_clipping):
8509 Don't pass uninitialized region to CombineRgn.
8511 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8513 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8514 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8515 (Fx_close_connection): Remove unused variable `i'.
8517 * w32font.c (w32font_draw): Return number of glyphs.
8518 (w32font_open_internal): Remove unused variable `i'.
8519 (w32font_driver): Add missing initializer.
8521 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8522 (fill_in_menu): Remove unused variable `items_added'.
8524 * w32term.c (last_mouse_press_frame): Remove static global variable.
8525 (w32_clip_to_row): Remove unused variable `f'.
8526 (x_delete_terminal): Remove unused variable `i'.
8528 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8529 (NOTHING): Remove unused static global variable.
8530 (uniscribe_check_otf): Remove unused variable `table'.
8531 (uniscribe_font_driver): Add missing initializers.
8533 2011-03-23 Julien Danjou <julien@danjou.info>
8535 * term.c (Fsuspend_tty, Fresume_tty):
8536 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8537 * window.c (temp_output_buffer_show):
8538 * insdel.c (signal_before_change):
8539 * frame.c (Fhandle_switch_frame):
8540 * fileio.c (Fdo_auto_save):
8541 * emacs.c (Fkill_emacs):
8542 * editfns.c (save_excursion_restore):
8543 * cmds.c (internal_self_insert):
8544 * callint.c (Fcall_interactively):
8545 * buffer.c (Fkill_all_local_variables):
8546 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8548 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8549 unconditionally since it does the check itself.
8551 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8553 Fix more problems found by GCC 4.5.2's static checks.
8555 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8556 the first time through the loop, since we know p0 < p1 then.
8557 This also avoids a gcc -Wstrict-overflow warning.
8559 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8560 leading to a memory leak, possible in functions like
8561 load_charset_map_from_file that can allocate an unbounded number
8562 of objects (Bug#8318).
8564 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8565 that could (at least in theory) be that large.
8567 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8568 This is less likely to overflow, and avoids undefined behavior if
8569 overflow does occur. All callers changed. Use strtoul to scan
8570 for the unsigned long integer.
8571 (pint2hrstr): Simplify and tune code slightly.
8572 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8574 * scroll.c (do_scrolling): Work around GCC bug 48228.
8575 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8577 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8578 This also avoids a warning with gcc -Wstrict-overflow.
8579 (validate_x_resource_name): Simplify count usage.
8580 This also avoids a warning with gcc -Wstrict-overflow.
8582 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8585 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8587 * process.c (Fmake_network_process): Use socklen_t, not int,
8588 where POSIX says socklen_t is required in portable programs.
8589 This fixes a porting bug on hosts like 64-bit HP-UX, where
8590 socklen_t is wider than int (Bug#8277).
8591 (Fmake_network_process, server_accept_connection):
8592 (wait_reading_process_output, read_process_output):
8595 * process.c: Rename or move locals to avoid shadowing.
8596 (list_processes_1, Fmake_network_process):
8597 (read_process_output_error_handler, exec_sentinel_error_handler):
8598 Rename or move locals.
8599 (Fmake_network_process): Define label "retry_connect" only if needed.
8600 (Fnetwork_interface_info): Fix pointer signedness.
8601 (process_send_signal): Add cast to avoid pointer signedness problem.
8602 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8603 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8605 Make tparam.h and terminfo.c consistent.
8606 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8607 Include tparam.h instead, since it declares them.
8608 * cm.h (PC): Remove extern decl; tparam.h now does this.
8609 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8610 * terminfo.c: Include tparam.h, to check interfaces.
8611 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8612 (tparam): Adjust signature to match interface in tparam.h;
8613 this removes some undefined behavior. Check that outstring and len
8614 are zero, which they always are with Emacs.
8615 * tparam.h (PC, BC, UP): New extern decls.
8617 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8618 (xftfont_open): Rename locals to avoid shadowing.
8620 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8621 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8622 (OTF_TAG_SYM): Omit macro if not needed.
8623 (ftfont_list): Remove unused local.
8624 (get_adstyle_property, ftfont_pattern_entity):
8625 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8626 Rename locals to avoid shadowing.
8628 * xfont.c (xfont_list_family): Mark var as initialized.
8630 * xml.c (make_dom): Now static.
8632 * composite.c (composition_compute_stop_pos): Rename local to
8634 (composition_reseat_it): Remove unused locals.
8635 (find_automatic_composition, composition_adjust_point): Likewise.
8636 (composition_update_it): Mark var as initialized.
8637 (find_automatic_composition): Mark vars as initialized,
8638 with a FIXME (Bug#8290).
8640 character.h: Rename locals to avoid shadowing.
8641 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8642 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8643 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8644 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8647 * textprop.c (property_change_between_p): Remove; unused.
8649 * intervals.c (interval_start_pos): Now static.
8651 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8653 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8654 Rename locals to avoid shadowing.
8656 * sound.c (wav_play, au_play, Fplay_sound_internal):
8657 Fix pointer signedness.
8658 (alsa_choose_format): Remove unused local var.
8659 (wav_play): Initialize a variable to 0, to prevent undefined
8660 behavior (Bug#8278).
8662 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8664 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8666 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8667 clobbering (Bug#8298).
8668 * sysdep.c (sys_subshell): Likewise.
8669 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8671 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8672 This should get cleaned up, so that child_setup has the
8673 same signature on all platforms.
8675 * callproc.c (call_process_cleanup): Now static.
8676 (relocate_fd): Rename locals to avoid shadowing.
8678 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8680 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8681 not to be necessary, and produces flickering.
8683 2011-03-20 Glenn Morris <rgm@gnu.org>
8685 * config.in: Remove file.
8687 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8689 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8690 are now in src/globals.h.
8691 (syms_of_minibuf): Remove spurious & from previous change.
8693 2011-03-20 Leo Liu <sdl.web@gmail.com>
8695 * minibuf.c (completing-read-function): New variable.
8696 (completing-read-default): Rename from completing-read.
8697 (completing-read): Call completing-read-function.
8699 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8701 * xfaces.c (Fx_load_color_file):
8702 Read color file from absolute filename (bug#8250).
8704 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8706 * makefile.w32-in: Update dependencies.
8708 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8710 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8712 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8714 Fix more problems found by GCC 4.5.2's static checks.
8716 * process.c (make_serial_process_unwind, send_process_trap):
8717 (sigchld_handler): Now static.
8719 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8720 That way, the code declares only the vars that it needs.
8721 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8722 * s/cygwin.h (PTY_ITERATION): Likewise.
8723 * s/darwin.h (PTY_ITERATION): Likewise.
8724 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8726 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8727 * process.c (allocate_pty): Don't declare stb unless it's needed.
8729 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8730 (CONSTANTLIM): Remove; unused.
8731 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8732 Define only if needed.
8734 * unexelf.c (unexec): Name an expression,
8735 to avoid gcc -Wbad-function-cast warning.
8736 Use a different way to cause a compilation error if anyone uses
8737 n rather than nn, a way that does not involve shadowing.
8738 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8740 * deps.mk (unexalpha.o): Remove; unused.
8742 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8743 * unexec.h: New file.
8744 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8745 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8747 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8748 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8749 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8750 Change as necessary to match prototype in unexec.h.
8752 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8754 (back_comment, skip_chars): Mark vars as initialized.
8756 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8757 Rename locals to avoid shadowing.
8759 * lread.c (read1): Rewrite so as not to use empty "else".
8760 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8762 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8764 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8765 warning when compiling print.c.
8767 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8768 instead of using an uninitialized var.
8769 (font_sort_entities): Mark var as initialized.
8771 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8773 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8774 pointers to constants.
8775 (font_parse_fcname): Remove unused vars.
8776 (font_delete_unmatched): Now static.
8777 (font_get_spec): Remove; unused.
8778 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8779 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8780 Rename or move locals to avoid shadowing.
8782 * fns.c (require_nesting_list, require_unwind): Now static.
8783 (Ffillarray): Rename locals to avoid shadowing.
8785 * floatfns.c (domain_error2): Define only if needed.
8786 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8788 * alloc.c (mark_backtrace): Move decl from here ...
8789 * lisp.h: ... to here, so that it can be checked.
8791 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8792 (Fdefvar): Rewrite so as not to use empty "else".
8793 (lisp_indirect_variable): Name an expression,
8794 to avoid gcc -Wbad-function-cast warning.
8795 (Fdefvar): Rename locals to avoid shadowing.
8797 * callint.c (quotify_arg, quotify_args): Now static.
8798 (Fcall_interactively): Rename locals to avoid shadowing.
8799 Use const pointer when appropriate.
8801 * lisp.h (get_system_name, get_operating_system_release):
8802 Move decls here, to check interfaces.
8803 * process.c (get_operating_system_release): Move decl to lisp.h.
8804 * xrdb.c (get_system_name): Likewise.
8805 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8806 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8807 some of which prompt warnings from gcc -Wbad-function-cast.
8808 (Fformat_time_string, Fencode_time, Finsert_char):
8809 (Ftranslate_region_internal, Fformat):
8810 Rename or remove local vars to avoid shadowing.
8811 (Ftranslate_region_internal): Mark var as initialized.
8813 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8816 * lisp.h (eassert): Check that the argument compiles, even if
8817 ENABLE_CHECKING is not defined.
8819 * data.c (Findirect_variable): Name an expression, to avoid
8820 gcc -Wbad-function-cast warning.
8821 (default_value, arithcompare, arith_driver, arith_error): Now static.
8822 (store_symval_forwarding): Rename local to avoid shadowing.
8823 (Fmake_variable_buffer_local, Fmake_local_variable):
8824 Mark variables as initialized.
8825 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8827 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8828 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8829 Rename locals to avoid shadowing.
8830 (mark_stack): Move local variables into the #ifdef region where
8832 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8833 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8835 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8836 (GC_STRING_CHARS): Remove; not used.
8837 (Fmemory_limit): Cast sbrk's returned value to char *.
8839 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8840 avoids undefined behavior in theory.
8842 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8844 Use functions, not macros, for up- and down-casing (Bug#8254).
8845 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8846 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8847 to use the following functions instead of these macros.
8848 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8849 EMACS_INT, since callers assume the returned value fits in int.
8850 (upcase1): Likewise, for UPCASE_TABLE.
8851 (uppercasep, lowercasep, upcase): New static inline functions.
8852 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8853 the race-condition problem in the old DOWNCASE.
8855 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8856 Rename locals to avoid shadowing.
8857 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8858 (regex_compile, re_search_2, re_match_2_internal):
8859 Remove unused local vars.
8860 (FREE_VAR): Rewrite so as not to use empty "else",
8861 which gcc can warn about.
8862 (regex_compile, re_match_2_internal): Mark locals as initialized.
8863 (RETALLOC_IF): Define only if needed.
8864 (WORDCHAR_P): Likewise. This one is never needed, but is used
8865 only in a comment talking about a compiler bug, so put inside
8866 the #if 0 of that comment.
8867 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8868 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8871 * search.c (boyer_moore): Rename locals to avoid shadowing.
8872 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8873 (PREV_CHAR_BOUNDARY): Likewise.
8875 * search.c (simple_search): Remove unused var.
8877 * dired.c (compile_pattern): Move decl from here ...
8878 * lisp.h: ... to here, so that it can be checked.
8879 (struct re_registers): New forward decl.
8881 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8883 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8885 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8886 Rename locals to avoid shadowing.
8887 (Fvertical_motion): Mark locals as initialized.
8889 * casefiddle.c (casify_object, casify_region): Now static.
8890 (casify_region): Mark local as initialized.
8892 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8894 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8895 New macros, so that the caller can use some names other than
8896 gcpro1, gcpro2, etc.
8897 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8899 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8900 argument, for consistency with GCPRO2_VAR, etc: it is now the
8901 prefix of the variable, not the variable itself. All uses
8903 * dired.c (directory_files_internal, file_name_completion):
8904 Rename locals to avoid shadowing.
8906 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8907 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8908 dired.c's scmp function, had undefined behavior.
8909 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8910 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8911 * buffer.h: ... to here, because these macros use current_buffer,
8912 and the new implementation with inline functions needs to have
8913 current_buffer in scope now, rather than later when the macros
8915 (downcase, upcase1): New static inline functions.
8916 (DOWNCASE, UPCASE1): Reimplement using these functions.
8917 This avoids undefined behavior in expressions like
8918 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8919 from race conditions in accessing the global variables
8920 case_temp1 and case_temp2.
8921 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8922 * lisp.h (case_temp1, case_temp2): Remove their decls.
8923 * character.h (ASCII_CHAR_P): Move from here ...
8924 * lisp.h: ... to here, so that the inline functions mentioned
8927 * dired.c (directory_files_internal_unwind): Now static.
8929 * fileio.c (file_name_as_directory, directory_file_name):
8930 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8932 (file_name_as_directory): Use const pointers when appropriate.
8933 (Fexpand_file_name): Likewise. In particular, newdir might
8934 point at constant storage, so make it a const pointer.
8935 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8936 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8938 (Fset_file_times, Finsert_file_contents, auto_save_error):
8939 Rename locals to avoid shadowing.
8941 * minibuf.c (choose_minibuf_frame_1): Now static.
8942 (Ftry_completion, Fall_completions): Rename or remove locals
8945 * marker.c (bytepos_to_charpos): Remove; unused.
8947 * lisp.h (verify_bytepos, count_markers): New decls,
8948 so that gcc does not warn that these functions aren't declared.
8950 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8951 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8952 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8953 (copy_text): Remove unused local var.
8955 * filelock.c (within_one_second): Now static.
8956 (lock_file_1): Rename local to avoid shadowing.
8958 * buffer.c (fix_overlays_before): Mark locals as initialized.
8959 (fix_start_end_in_overlays): Likewise. This function should be
8960 simplified by using pointers-to-pointers, but that's a different
8962 (switch_to_buffer_1): Now static.
8963 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8964 (report_overlay_modification): Rename locals to avoid shadowing.
8966 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8967 Fix pointer signedness issue.
8968 (sys_subshell): Mark local as volatile if checking for lint,
8969 to suppress a gcc -Wclobbered warning that does not seem to be right.
8970 (MAXPATHLEN): Define only if needed.
8972 * process.c (serial_open, serial_configure): Move decls from here ...
8973 * systty.h: ... to here, so that they can be checked.
8975 * fns.c (get_random, seed_random): Move extern decls from here ...
8976 * lisp.h: ... to here, so that they can be checked.
8978 * sysdep.c (reset_io): Now static.
8979 (wait_for_termination_signal): Remove; unused.
8981 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8982 (copy_keymap_item, append_key, push_text_char_description):
8984 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8985 (DENSE_TABLE_SIZE): Remove; unused.
8986 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8987 (describe_map_tree):
8988 Rename locals to avoid shadowing.
8990 * keyboard.c: Declare functions static if they are not used elsewhere.
8991 (echo_char, echo_dash, cmd_error, top_level_2):
8992 (poll_for_input, handle_async_input): Now static.
8993 (read_char, kbd_buffer_get_event, make_lispy_position):
8994 (make_lispy_event, make_lispy_movement, apply_modifiers):
8995 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8996 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8997 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8998 (read_key_sequence, read_char): Mark locals as initialized.
8999 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9001 * keyboard.h (make_ctrl_char): New decl.
9002 (mark_kboards): Move decl here ...
9003 * alloc.c (mark_kboards): ... from here.
9005 * lisp.h (force_auto_save_soon): New decl.
9007 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9008 (DEFINE_DUMMY_FUNCTION): New macro.
9009 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9011 (main): Add casts to avoid warnings
9012 if GCC considers string literals to be constants.
9014 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9016 * dbusbind.c: Pointer signedness fixes.
9017 (xd_signature, xd_append_arg, xd_initialize):
9018 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9019 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9020 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9021 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9023 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9024 if GCC considers string literals to be constants.
9025 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9027 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9029 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9030 (print_preprocess, print_object): New macro to fix last change.
9032 * print.c (print_preprocess): Don't forget font objects.
9034 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9036 * emacs.c (USAGE3): Doc fixes.
9038 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9040 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9043 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9045 * lisp.h (VWindow_system, Qfile_name_history):
9046 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9047 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9048 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9050 * w32select.c: Don't #include "keyboard.h".
9051 (run_protected): Add extern declaration for waiting_for_input.
9053 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9054 * w32console.c (detect_input_pending, read_input_pending)
9055 (encode_terminal_code):
9056 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9057 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9058 (w32_system_caret_y, Qfile_name_history):
9059 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9060 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9061 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9062 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9063 * w32proc.c (Qlocal, report_file_error):
9064 * w32term.c (Vwindow_system, updating_frame):
9065 * w32uniscribe.c (initialized, uniscribe_font_driver):
9066 Remove unneeded extern declarations.
9068 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9070 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9072 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9074 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9075 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9076 These macros can no longer be used for assignment.
9078 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9079 Assign struct members directly, instead of using BUF_BEGV etc.
9080 (record_buffer_markers, fetch_buffer_markers): New functions for
9081 recording and fetching special buffer markers.
9082 (set_buffer_internal_1, set_buffer_temp): Use them.
9084 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9086 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9088 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9089 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9091 * xdisp.c (hscroll_window_tree):
9092 (reconsider_clip_changes): Use PT instead of BUF_PT.
9094 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9096 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9097 $(EMACS_ROOT)/lib/intprops.h.
9099 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9101 Fix more problems found by GCC 4.5.2's static checks.
9103 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9104 to unsigned char * to avoid compiler diagnostic.
9105 (xg_free_frame_widgets): Make it clear that a local variable is
9106 needed only if USE_GTK_TOOLTIP.
9107 (gdk_window_get_screen): Make it clear that this macro is needed
9108 only if USE_GTK_TOOLTIP.
9109 (int_gtk_range_get_value): New function, which avoids a diagnostic
9110 from gcc -Wbad-function-cast.
9111 (xg_set_toolkit_scroll_bar_thumb): Use it.
9112 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9113 diagnostic from gcc -Wbad-function-cast.
9114 (get_utf8_string, xg_get_file_with_chooser):
9115 Rename locals to avoid shadowing.
9116 (create_dialog): Move locals to avoid shadowing.
9118 * xgselect.c (xg_select): Remove unused var.
9120 * image.c (four_corners_best): Mark locals as initialized.
9121 (gif_load): Initialize transparent_p to zero (Bug#8238).
9122 Mark another local as initialized.
9123 (my_png_error, my_error_exit): Mark with NO_RETURN.
9125 * image.c (clear_image_cache): Now static.
9126 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9127 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9128 (x_edge_detection): Remove unnecessary cast that
9129 gcc -Wbad-function-cast diagnoses.
9130 (gif_load): Fix pointer signedness.
9131 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9132 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9134 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9136 Improve quality of tests for time stamp overflow.
9137 For example, without this patch (encode-time 0 0 0 1 1
9138 1152921504606846976) returns the obviously-bogus value (-948597
9139 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9140 reports time overflow. See
9141 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9142 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9143 * editfns.c: Include limits.h and intprops.h.
9144 (TIME_T_MIN, TIME_T_MAX): New macros.
9145 (time_overflow): Move earlier, to before first use.
9146 (hi_time, lo_time): New functions, for an accurate test for
9148 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9149 (Fget_internal_run_time): Don't assume time_t fits in int.
9150 (make_time): Use list2 instead of Fcons twice.
9151 (Fdecode_time): More accurate test for out-of-range times.
9152 (check_tm_member): New function.
9153 (Fencode_time): Use it, to test for out-of-range times.
9154 (lisp_time_argument): Don't rely on undefined left-shift and
9155 right-shift behavior when checking for time stamp overflow.
9157 * editfns.c (time_overflow): New function, refactoring common code.
9158 (Fformat_time_string, Fdecode_time, Fencode_time):
9159 (Fcurrent_time_string): Use it.
9161 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9162 * dired.c (make_time): Move to ...
9163 * editfns.c (make_time): ... here.
9164 * systime.h: Note the move.
9166 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9168 * fringe.c (update_window_fringes): Remove unused variables.
9170 * unexmacosx.c (copy_data_segment): Also copy __got section.
9173 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9175 * termcap.c [MSDOS]: Include "msdos.h".
9176 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9177 Constify `char *' arguments and their references according to
9178 prototypes in tparam.h.
9180 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9182 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9183 Adapt all references accordingly.
9185 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9187 2011-03-11 Tom Tromey <tromey@redhat.com>
9189 * buffer.c (syms_of_buffer): Remove obsolete comment.
9191 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9193 * termhooks.h (encode_terminal_code): Declare prototype.
9195 * msdos.c (encode_terminal_code): Don't declare prototype.
9197 * term.c (encode_terminal_code): Now external again, used by
9198 w32console.c and msdos.c.
9200 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9201 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9203 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9205 Fix some minor problems found by GCC 4.5.2's static checks.
9207 * fringe.c (update_window_fringes): Mark locals as initialized
9209 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9211 * alloc.c (mark_fringe_data): Move decl from here ...
9212 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9213 to check its interface.
9214 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9216 * fontset.c (free_realized_fontset): Now static.
9217 (Fset_fontset_font): Rename local to avoid shadowing.
9218 (fontset_font): Mark local as initialized.
9219 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9221 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9223 * xselect.c (x_disown_buffer_selections): Remove; not used.
9224 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9225 (x_own_selection, Fx_disown_selection_internal): Rename locals
9227 (x_handle_dnd_message): Remove local to avoid shadowing.
9229 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9230 so that the caller can use some name other than gcpro1.
9231 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9232 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9233 (Fx_backspace_delete_keys_p):
9234 Use them to avoid shadowing, and rename vars to avoid shadowing.
9235 (x_decode_color, x_set_name, x_window): Now static.
9236 (Fx_create_frame): Add braces to silence GCC warning.
9237 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9238 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9239 Remove unused locals.
9240 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9241 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9242 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9245 * xterm.h (x_mouse_leave): New decl.
9247 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9248 Remove unused functions.
9249 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9250 (x_calc_absolute_position): Now static.
9251 (XTread_socket): Don't define label "out" unless it's used.
9252 Don't declare local "event" unless it's used.
9253 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9254 unless they are used.
9255 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9256 (x_fatal_error_signal): Remove; not used.
9257 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9258 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9259 (x_error_catcher, x_connection_closed, x_error_handler):
9260 (x_error_quitter, xembed_send_message, x_iconify_frame):
9261 (my_log_handler): Rename locals to avoid shadowing.
9262 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9263 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9265 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9266 Rename or move locals to avoid shadowing.
9267 (tty_defined_color, merge_face_heights): Now static.
9268 (free_realized_faces_for_fontset): Remove; not used.
9269 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9270 does not deduce is never used uninitialized.
9271 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9272 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9274 * terminal.c (store_terminal_param): Now static.
9276 * xmenu.c (menu_highlight_callback): Now static.
9277 (set_frame_menubar): Remove unused local.
9278 (xmenu_show): Rename parameter to avoid shadowing.
9279 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9280 since they might point to immutable storage.
9281 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9282 since it's unused otherwise.
9284 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9285 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9286 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9287 avoids a gcc -Wuninitialized diagnostic.
9288 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9289 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9290 does not deduce are never used uninitialized.
9292 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9294 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9295 * window.c (window_loop, size_window):
9296 (run_window_configuration_change_hook, enlarge_window): Likewise.
9298 * window.c (display_buffer): Now static.
9299 (size_window): Mark variables that gcc -Wuninitialized
9300 does not deduce are never used uninitialized.
9301 * window.h (check_all_windows): New decl, to forestall
9302 gcc -Wmissing-prototypes diagnostic.
9303 * dispextern.h (bidi_dump_cached_states): Likewise.
9305 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9307 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9309 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9310 and to avoid gcc -Wuninitialized warning.
9311 (load_charset_map): Mark variables that gcc -Wuninitialized
9312 does not deduce are never used uninitialized.
9313 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9315 * coding.c (coding_set_source, coding_set_destination):
9316 Use "else { /* comment */ }" rather than "else /* comment */;"
9317 for clarity, and to avoid gcc -Wempty-body warning.
9318 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9319 a block, when the outer 'i' will do.
9320 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9321 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9322 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9323 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9324 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9325 Rename locals to avoid shadowing.
9326 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9327 * coding.c (emacs_mule_char, encode_invocation_designation):
9328 Now static, since they're not used elsewhere.
9329 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9330 (decode_coding_object, encode_coding_object, detect_coding_system):
9331 (decode_coding_emacs_mule): Mark variables that gcc
9332 -Wuninitialized does not deduce are never used uninitialized.
9333 (detect_coding_iso_2022): Initialize a local variable that might
9334 be used uninitialized. Leave a FIXME because it's not clear that
9335 this initialization is needed. (Bug#8211)
9336 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9337 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9338 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9339 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9340 Remove unused macros.
9342 * category.c (hash_get_category_set): Remove unused local var.
9343 (copy_category_table): Now static, since it's not used elsewhere.
9344 * character.c (string_count_byte8): Likewise.
9346 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9347 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9349 * chartab.c (copy_sub_char_table): Now static, since it's not used
9351 (sub_char_table_ref_and_range, char_table_ref_and_range):
9352 Rename locals to avoid shadowing.
9353 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9355 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9356 (BIDI_BOB): Remove unused macro.
9358 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9359 deduce are never used uninitialized.
9360 * term.c (encode_terminal_code): Likewise.
9362 * term.c (encode_terminal_code): Now static. Remove unused local.
9364 * tparam.h: New file.
9365 * term.c, tparam.h: Include it.
9366 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9367 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9368 Move these decls to tparam.h, and make them agree with what
9369 is actually in tparam.c. The previous trick of using incompatible
9370 decls in different modules does not conform to the C standard.
9371 All callers of tparam changed to use tparam's actual API.
9372 * tparam.c (tparam1, tparam, tgoto):
9373 Use const pointers where appropriate.
9375 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9376 * cm.h (struct cm): Likewise.
9377 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9378 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9379 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9380 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9381 (turn_on_face, init_tty): Likewise.
9382 * termchar.h (struct tty_display_info): Likewise.
9384 * term.c (term_mouse_position): Rename local to avoid shadowing.
9386 * alloc.c (mark_ttys): Move decl from here ...
9387 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9389 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9391 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9393 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9395 * search.c (compile_pattern_1): Remove argument regp, unused since
9396 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9397 (compile_pattern): Don't pass it.
9399 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9401 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9402 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9404 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9406 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9408 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9409 gdk_window_get_screen, gdk_window_get_geometry,
9410 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9411 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9412 (xg_get_pixbuf_from_pixmap): New function.
9413 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9414 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9415 Call xg_get_pixbuf_from_pixmap instead of
9416 gdk_pixbuf_get_from_drawable.
9417 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9418 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9419 (xg_check_special_colors): Use GtkStyleContext and its functions
9421 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9422 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9423 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9424 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9425 Call gtk_widget_get_preferred_size.
9426 (xg_frame_resized): gdk_window_get_geometry only takes 5
9428 (xg_win_to_widget, xg_event_is_for_menubar):
9429 Call gdk_x11_window_lookup_for_display.
9430 (xg_set_widget_bg): New function.
9431 (delete_cb): New function.
9432 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9433 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9434 (xg_set_background_color): Call xg_set_widget_bg.
9435 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9436 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9437 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9438 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9440 (update_frame_tool_bar): Call gtk_widget_hide.
9441 (xg_initialize): Use GDK_KEY_g.
9443 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9445 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9447 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9448 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9449 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9451 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9453 * w32xfns.c (select_palette): Check success of RealizePalette against
9454 GDI_ERROR, not zero.
9456 See ChangeLog.11 for earlier changes.
9462 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9464 This file is part of GNU Emacs.
9466 GNU Emacs is free software: you can redistribute it and/or modify
9467 it under the terms of the GNU General Public License as published by
9468 the Free Software Foundation, either version 3 of the License, or
9469 (at your option) any later version.
9471 GNU Emacs is distributed in the hope that it will be useful,
9472 but WITHOUT ANY WARRANTY; without even the implied warranty of
9473 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9474 GNU General Public License for more details.
9476 You should have received a copy of the GNU General Public License
9477 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.