Native scroll-bars are not implemented for Nextstep (bug#10673)
[bpt/emacs.git] / src / ChangeLog
1 2012-02-02 Glenn Morris <rgm@gnu.org>
2
3 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4 Unconditionally set to t. (Bug#10673)
5 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
7 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
8
9 2012-02-02 Kenichi Handa <handa@m17n.org>
10
11 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
12 NULL (Bug#6988).
13 (x_produce_glyphs): If the component of a composition is a null
14 string, set it->pixel_width to 1 to avoid zero-width glyph.
15
16 2012-02-01 Eli Zaretskii <eliz@gnu.org>
17
18 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
19 first 2 arguments are identical. This makes inserting large
20 output from a subprocess an order of magnitude faster on
21 MS-Windows, where all sbrk'ed memory is always contiguous.
22
23 2012-01-31 Glenn Morris <rgm@gnu.org>
24
25 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
26 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
27 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
28
29 2012-01-29 Glenn Morris <rgm@gnu.org>
30
31 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
32
33 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
34
35 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
36
37 2012-01-28 Chong Yidong <cyd@gnu.org>
38
39 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
40
41 2012-01-26 Chong Yidong <cyd@gnu.org>
42
43 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
44
45 * search.c (Fsearch_forward, Fsearch_backward): Document negative
46 repeat counts (Bug#10507).
47
48 2012-01-26 Glenn Morris <rgm@gnu.org>
49
50 * lread.c (syms_of_lread): Doc fix.
51
52 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
53
54 * coding.c (encode_designation_at_bol): Change return value to
55 EMACS_INT.
56
57 2012-01-25 Chong Yidong <cyd@gnu.org>
58
59 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
60
61 2012-01-21 Chong Yidong <cyd@gnu.org>
62
63 * floatfns.c (Fcopysign): Make the second argument non-optional,
64 since nil is not allowed anyway.
65
66 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
67
68 * process.c (read_process_output): Use p instead of XPROCESS (proc).
69 (send_process): Likewise.
70
71 2012-01-19 Martin Rudalics <rudalics@gmx.at>
72
73 * window.c (save_window_save, Fcurrent_window_configuration)
74 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
75 doc-strings.
76
77 2012-01-19 Kenichi Handa <handa@m17n.org>
78
79 * character.c (char_width): New function.
80 (Fchar_width, c_string_width, lisp_string_width):
81 Use char_width (Bug#9496).
82
83 2012-01-16 Martin Rudalics <rudalics@gmx.at>
84
85 * window.c (Vwindow_persistent_parameters): New variable.
86 (Fset_window_configuration, save_window_save): Handle persistent
87 window parameters.
88
89 2012-01-14 Eli Zaretskii <eliz@gnu.org>
90
91 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
92 thrashing the stack of the thread. (Bug#9087)
93
94 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
95
96 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
97
98 2012-01-11 Eli Zaretskii <eliz@gnu.org>
99
100 * xdisp.c (rows_from_pos_range): Handle the case where the
101 highlight ends on a newline. (Bug#10464)
102 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
103 he end column for display of highlight that ends on a newline
104 before a R2L line.
105
106 2012-01-11 Glenn Morris <rgm@gnu.org>
107
108 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
109 from load-path also when installation-directory is nil. (Bug#10208)
110
111 2012-01-10 Glenn Morris <rgm@gnu.org>
112
113 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
114
115 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
116 Update template values to be closer to their typical values these days.
117
118 2012-01-09 Eli Zaretskii <eliz@gnu.org>
119
120 * xdisp.c (rows_from_pos_range): Accept additional argument
121 DISP_STRING, and accept any glyph in a row whose object is that
122 string as eligible for mouse highlight. Fixes mouse highlight of
123 display strings from overlays. (Bug#10464)
124
125 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
126
127 emacs: fix an auto-save permissions race condition (Bug#10400)
128 * fileio.c (auto_saving_dir_umask): New static var.
129 (Fmake_directory_internal): Use it.
130 (do_auto_save_make_dir): Set it, instead of invoking chmod after
131 creating the directory. The old code temporarily assigns
132 too-generous permissions to the directory.
133 (do_auto_save_eh): Clear it.
134 (Fdo_auto_save): Catch all errors, not just file errors, so
135 that the var is always cleared.
136
137 2012-01-07 Eli Zaretskii <eliz@gnu.org>
138
139 * search.c (scan_buffer): Pass character positions to
140 know_region_cache, not byte positions. (Bug#6540)
141
142 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
143
144 * w32.c (sys_rename): Report EXDEV when rename of a directory
145 fails because the target is on another logical disk. (Bug#10284)
146
147 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
148
149 * xterm.c (x_embed_request_focus): New function.
150
151 * xterm.h: Add prototype.
152
153 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
154
155 2012-01-05 Glenn Morris <rgm@gnu.org>
156
157 * emacs.c (emacs_copyright): Update short copyright year to 2012.
158
159 2012-01-01 Eli Zaretskii <eliz@gnu.org>
160
161 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
162 Load gnutls_transport_set_lowat only if GnuTLS version is below
163 2.11.1.
164 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
165 GnuTLS versions below 2.11.1.
166
167 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
168
169 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
170 to the doc string advising against its use for altering the way
171 windows are scrolled.
172
173 2011-12-28 Kenichi Handa <handa@m17n.org>
174
175 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
176 coding-system ASCII compatible only when it does not produce BOM
177 on encoding (Bug#10383).
178
179 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
180
181 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
182 can scroll.
183 (create_and_show_popup_menu): Always use menu_position_func for
184 Gtk3 (Bug#10361).
185
186 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
187
188 * callint.c (Fcall_interactively): Don't truncate prompt string.
189
190 2011-12-23 Eli Zaretskii <eliz@gnu.org>
191
192 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
193 property that ends at ZV, so that the bidi iteration could be
194 resumed from there (after widening). (Bug#10360)
195
196 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
197
198 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
199
200 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
201
202 * nsterm.m (x_free_frame_resources):
203 Release f->output_data.ns->miniimage.
204 (ns_index_color): Fix indentation. Do not retain
205 color_table->colors[i].
206
207 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
208 before returning.
209
210 * nsfns.m (x_set_background_color): Assign return value from
211 ns_index_color to face-background instead of NSColor*.
212 (ns_implicitly_set_icon_type): Fix indentation.
213 Change assignment in for loop to comparison.
214
215 * emacs.c (ns_pool): New variable.
216 (main): Assign ns_pool.
217 (Fkill_emacs): Call ns_release_autorelease_pool.
218
219 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
220 autorelease fdesc, release fdAttrs and tdict.
221 (ns_get_covering_families): Release charset.
222 (ns_findfonts): Release NSFontDescriptor created with new.
223 (ns_uni_to_glyphs): Fix indentation.
224 (setString): Release attrStr before assigning new value.
225
226 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
227
228 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
229 and NS_IMPL_COCOA.
230 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
231 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
232
233 2011-12-18 David Reitter <reitter@cmu.edu>
234
235 * nsterm.m (ns_term_init): Subscribe for notifications
236 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
237 to method trackingNotification in EmacsMenu.
238
239 * nsmenu.m (trackingMenu): New variable.
240 (trackingNotification): New method (from Aquamacs).
241 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
242 from Aquamacs (Bug#7030).
243
244 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
245
246 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
247 (symbol_to_nsstring): Fix indentation.
248 (ns_symbol_to_pb): New function.
249 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
250 (Fns_rotate_cut_buffers_internal): Removed.
251 (Fns_store_selection_internal): Renamed from
252 Fns_store_cut_buffer_internal.
253 (ns_get_foreign_selection, Fx_own_selection_internal)
254 (Fx_disown_selection_internal, Fx_selection_exists_p)
255 (Fns_get_selection_internal, Fns_store_selection_internal):
256 Use ns_symbol_to_pb and check if return value is nil.
257 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
258 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
259 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
260 renamed to Sns_store_selection_internal.
261 (ns_handle_selection_request): Move code to Fx_own_selection_internal
262 and remove this function.
263 (ns_handle_selection_clear): Remove, never used.
264 (Fx_own_selection_internal): Move code from ns_handle_selection_request
265 here.
266
267 2011-12-17 Ken Brown <kbrown@cornell.edu>
268
269 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
270 GID is unknown (Bug#10257).
271
272 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
273
274 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
275 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
276 which caused a build failure on GNU/Linux IA-64. This problem was
277 introduced by my 2011-10-07 patch.
278
279 2011-12-15 Juri Linkov <juri@jurta.org>
280
281 * image.c (imagemagick_error): New function. (Bug#10112)
282 (imagemagick_load_image): Comment out `MagickSetResolution' call.
283 Use `imagemagick_error' where ImageMagick functions return
284 `MagickFalse'.
285 (Fimagemagick_types): Add `Fnreverse' to return the list in the
286 proper order.
287
288 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
289
290 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
291 fill background (Bug#8992).
292
293 2011-12-13 Martin Rudalics <rudalics@gmx.at>
294
295 * window.c (Vwindow_combination_resize)
296 (Vwindow_combination_limit): Use t instead of non-nil in
297 doc-strings.
298 (Vrecenter_redisplay): Add first sentence of doc-string on
299 separate line.
300 (Frecenter): Fix doc-string typo.
301
302 2011-12-11 Kenichi Handa <handa@m17n.org>
303
304 * coding.c (Funencodable_char_position): Pay attention to the
305 buffer text relocation (Bug#9389).
306
307 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
308
309 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
310 gtk_init (Bug#10100).
311
312 2011-12-10 Eli Zaretskii <eliz@gnu.org>
313
314 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
315 IT->string is nil. (Bug#10263)
316
317 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
318
319 * nsterm.h (x_free_frame_resources): Declare.
320
321 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
322 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
323
324 * nsterm.h (ns_get_defaults_value): Declare.
325
326 * nsterm.m (ns_default): Call ns_get_defaults_value.
327
328 2011-12-09 Eli Zaretskii <eliz@gnu.org>
329
330 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
331 (Bug#10170)
332
333 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
334
335 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
336 that where the value of an _OBJC_* symbol points to is in the .bss
337 section (Bug#10240).
338
339 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
340
341 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
342 after the loop to call ccl_driver at least once (Bug#8619).
343
344 2011-12-08 Kenichi Handa <handa@m17n.org>
345
346 * ftfont.c (get_adstyle_property): Fix previous change
347 (Bug#10233).
348
349 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
350
351 * w32.c (init_environment): If no_site_lisp, remove site-lisp
352 dirs from the default value of EMACSLOADPATH (bug#10208).
353
354 2011-12-07 Glenn Morris <rgm@gnu.org>
355
356 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
357 installation and source directories as well. (Bug#10208)
358
359 2011-12-06 Chong Yidong <cyd@gnu.org>
360
361 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
362
363 2011-12-06 Glenn Morris <rgm@gnu.org>
364
365 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
366 as an error, not just -1. (Bug#10217)
367
368 2011-12-05 Chong Yidong <cyd@gnu.org>
369
370 * keyboard.c (process_special_events): New function.
371 (swallow_events, Finput_pending_p): Use it (Bug#10195).
372
373 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
374
375 * coding.c (encode_designation_at_bol): Don't use uninitialized
376 local variable (Bug#9318).
377
378 2011-12-05 Kenichi Handa <handa@m17n.org>
379
380 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
381 return Qnil (Bug#8046, Bug#10193).
382
383 2011-12-05 Kenichi Handa <handa@m17n.org>
384
385 * coding.c (encode_designation_at_bol): New args charbuf_end and
386 dst. Return the number of produced bytes. Callers changed.
387 (coding_set_source): Return how many bytes coding->source was
388 relocated.
389 (coding_set_destination): Return how many bytes
390 coding->destination was relocated.
391 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
392 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
393
394 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
395
396 * coding.c (CODING_CHAR_CHARSET_P): New macro.
397 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
398 macro (Bug#9318).
399
400 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
401
402 The following changes are to fix Bug#9318.
403
404 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
405 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
406 (encode_coding_iso_2022, encode_coding_sjis)
407 (encode_coding_big5, encode_coding_charset): Use the above macros.
408
409 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
410
411 * lisp.h (process_quit_flag): Fix external declaration.
412
413 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
414
415 Don't macro-inline non-performance-critical code.
416 * eval.c (process_quit_flag): New function.
417 * lisp.h (QUIT): Use it.
418
419 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
420
421 * nsfns.m (get_geometry_from_preferences): New function.
422 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
423
424 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
425
426 * emacs.c (Qkill_emacs): Define.
427 (syms_of_emacs): Initialize it.
428 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
429 Qquit_flag to `kill-emacs' instead.
430 (quit_throw_to_read_char): Add parameter `from_signal'.
431 All callers changed. Call Fkill_emacs if requested and safe.
432 * lisp.h (QUIT): Call Fkill_emacs if requested.
433
434 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
435
436 * widget.c (update_wm_hints): Return if wmshell is null.
437 (widget_update_wm_size_hints): New function.
438
439 * widget.h (widget_update_wm_size_hints): Declare.
440
441 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
442 widget_update_wm_size_hints (Bug#10104).
443
444 2011-12-03 Eli Zaretskii <eliz@gnu.org>
445
446 * xdisp.c (handle_invisible_prop): If the invisible text ends just
447 before a newline, prepare the bidi iterator for consuming the
448 newline, and keep the current paragraph direction. (Bug#10183)
449 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
450
451 2011-12-02 Juri Linkov <juri@jurta.org>
452
453 * search.c (Fword_search_regexp): New Lisp function created from
454 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
455 (Fword_search_backward, Fword_search_forward)
456 (Fword_search_backward_lax, Fword_search_forward_lax):
457 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
458 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
459
460 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
461
462 * fileio.c (Finsert_file_contents): Move after-change-function call
463 to before the "handled:" label, since all "goto handled" appear in
464 cases where the *-change-functions have already been properly called
465 (bug#10117).
466
467 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
468
469 * keyboard.c (interrupt_signal): Don't call kill-emacs when
470 waiting for input. (Bug#10169)
471
472 2011-11-30 Eli Zaretskii <eliz@gnu.org>
473
474 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
475 verifies glyph row's hash code--we have just reallocated the
476 glyphs, so their contents can be complete garbage. (Bug#10164)
477
478 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
479
480 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
481
482 2011-11-30 Eli Zaretskii <eliz@gnu.org>
483
484 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
485 attributes are tested _before_ calling verify_row_hash, to protect
486 against GCC re-ordering of the tests. (Bug#10164)
487
488 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
489
490 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
491
492 * xterm.c (handle_one_xevent): Only set async_visible and friends
493 if net_wm_state_hidden_seen is non-zero (Bug#10002)
494 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
495 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
496
497 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
498
499 Remove GCPRO-related macros that exist only to avoid shadowing locals.
500 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
501 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
502 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
503 All uses changed to use GCPRO1 etc.
504 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
505 Revert to old implementation (i.e., before 2011-03-11).
506
507 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
508
509 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
510 of scroll runs so as to avoid assigning disabled bogus rows and
511 unnecessary graphics copy operations.
512
513 2011-11-27 Eli Zaretskii <eliz@gnu.org>
514
515 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
516 (snprintf) [_MSC_VER]: Redirect to _snprintf.
517 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
518 (malloc, free, realloc, calloc): Redirect to e_* only when
519 compiling Emacs.
520
521 * lisp.h (GCTYPEBITS): Move before first use.
522 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
523 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
524 this macro definition.
525
526 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
527 _MSC_VER.
528
529 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
530
531 * gtkutil.c (xg_create_frame_widgets):
532 Call gtk_window_set_has_resize_grip (FALSE) if that function is
533 present with Gtk+ 2.0.
534
535 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
536
537 * fileio.c (Finsert_file_contents): Undo previous change; see
538 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
539
540 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
541
542 Rename locals to avoid shadowing.
543 * fileio.c (Finsert_file_contents):
544 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
545 * process.c (wait_reading_process_output):
546 Rename inner 'proc' to 'p' to avoid shadowing.
547 Indent for consistency with usual Emacs style.
548
549 2011-11-25 Eli Zaretskii <eliz@gnu.org>
550
551 * xdisp.c (redisplay_window): If cursor row is not fully visible
552 after recentering, and scroll-conservatively is set to a large
553 number, scroll window by a few more lines to make the cursor fully
554 visible and out of scroll-margin. (Bug#10105)
555 (start_display): Don't move to the next line if the display should
556 start at a newline that is part of a display vector or an overlay
557 string. (Bug#10119)
558
559 2011-11-24 Juri Linkov <juri@jurta.org>
560
561 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
562 after the `MagickPingImage' call. (Bug#10112)
563
564 2011-11-23 Chong Yidong <cyd@gnu.org>
565
566 * window.c (Fcoordinates_in_window_p): Accept only live windows.
567
568 2011-11-23 Martin Rudalics <rudalics@gmx.at>
569
570 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
571 making another buffer current. (Bug#10114)
572
573 2011-11-23 Glenn Morris <rgm@gnu.org>
574
575 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
576
577 2011-11-23 Chong Yidong <cyd@gnu.org>
578
579 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
580 using it (Bug#5984).
581
582 2011-11-22 Eli Zaretskii <eliz@gnu.org>
583
584 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
585 and header-lines, as they don't have one computed for them.
586 (Bug#10098)
587
588 * .gdbinit (prow): Make displayed values more self-explaining.
589 Add row's hash code.
590
591 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
592
593 * process.c (wait_reading_process_output): Fix asynchrounous
594 GnuTLS socket handling on some versions of the GnuTLS library.
595 (wait_reading_process_output): Add comment and URL.
596
597 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
598
599 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
600
601 2011-11-21 Chong Yidong <cyd@gnu.org>
602
603 * window.c (Fnext_window, Fprevious_window): Doc fix.
604
605 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
606
607 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
608
609 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
610
611 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
612
613 2011-11-20 Martin Rudalics <rudalics@gmx.at>
614
615 * window.c (Fset_window_combination_limit): Rename argument
616 STATUS to LIMIT.
617 (Vwindow_combination_limit): Remove "status" from doc-string.
618
619 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
620
621 * m/ibms390.h: Remove.
622 * m/ibms390x.h: Don't include "ibms390.h".
623
624 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
625
626 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
627 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
628
629 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
630
631 * casetab.c (Fset_case_table):
632 * charset.c (Fcharset_after): Fix typos.
633
634 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
635
636 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
637 Otherwise, valgrind does not work on some platforms.
638 Problem reported by Andreas Schwab in
639 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
640 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
641 is set, removing the need for VIRT_ADDRESS_VARIES.
642 (PURE_P): Use a more-efficient implementation that needs just one
643 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
644 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
645 to 4 (xorl, subq, cmpq, setbe).
646 * alloc.c (pure): Always extern now, since that's the
647 VIRT_ADDR_VARIES behavior.
648 (PURE_POINTER_P): Use a single comparison, not two, for
649 consistency with the new puresize.h.
650 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
651 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
652 Remove VIRT_ADDR_VARIES no longer needed.
653
654 2011-11-19 Eli Zaretskii <eliz@gnu.org>
655
656 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
657 (erase_phys_cursor, update_window_cursor, show_mouse_face)
658 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
659 behave as if the cursor position were at the window margin.
660
661 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
662 and the cursor position is out of bounds, behave as if the cursor
663 position were at the window margin. (Bug#10075)
664
665 2011-11-18 Chong Yidong <cyd@gnu.org>
666
667 * window.c (Fwindow_combination_limit): Make first argument
668 non-optional, since it is meaningless for live windows like the
669 selected window.
670
671 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
672
673 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
674
675 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
676
677 * intervals.c: Fix grafting over the whole buffer (bug#10071).
678 (graft_intervals_into_buffer): Simplify.
679
680 2011-11-18 Eli Zaretskii <eliz@gnu.org>
681
682 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
683 hash values of the two rows.
684 (copy_row_except_pointers): Preserve the used[] arrays and the
685 hash values of the two rows. (Bug#10035)
686 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
687
688 * xdisp.c (row_hash): New function, body extracted from
689 compute_line_metrics.
690 (compute_line_metrics): Call row_hash, instead of computing the
691 hash code inline.
692
693 * dispnew.c (verify_row_hash): Call row_hash for computing the
694 hash code of a row, instead of duplicating code from xdisp.c.
695
696 * dispextern.h (row_hash): Add prototype.
697
698 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
699
700 * frame.c (delete_frame): Don't delete the terminal when the last
701 X frame is closed if emacs is built with GTK toolkit.
702
703 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
704
705 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
706
707 2011-11-17 Martin Rudalics <rudalics@gmx.at>
708
709 * window.c (Vwindow_splits): Rename to
710 Vwindow_combination_resize. Suggested by Juri Linkov.
711 (Fsplit_window_internal): Use Vwindow_combination_resize instead
712 of Vwindow_splits.
713
714 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
715
716 * nsfns.m (Fns_font_name):
717 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
718
719 2011-11-16 Martin Rudalics <rudalics@gmx.at>
720
721 * window.h (window): Rename slot "nest" to "combination_limit".
722 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
723 (Fset_window_nest): Rename to Fset_window_combination_limit.
724 (Vwindow_nest): Rename to Vwindow_combination_limit.
725 (recombine_windows, make_parent_window, make_window)
726 (Fsplit_window_internal, saved_window)
727 (Fset_window_configuration, save_window_save): Rename all
728 occurrences of window_nest to window_combination_limit.
729
730 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
731
732 * image.c (imagemagick_load_image): Fix typo.
733
734 2011-11-14 Eli Zaretskii <eliz@gnu.org>
735
736 * xdisp.c (display_line): Move the call to
737 highlight_trailing_whitespace before the call to
738 compute_line_metrics, since the latter needs to see the final
739 faces of all the glyphs to compute ROW's hash value.
740 Fixes assertion violations in row_equal_p. (Bug#10035)
741
742 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
743
744 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
745 just return (bug#10044).
746
747 2011-11-12 Eli Zaretskii <eliz@gnu.org>
748
749 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
750 with user-defined heap size. Bump the default size of the temacs
751 heap to 27MB, to avoid memory warning when running temacs.
752 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
753
754 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
755 current_matrix and desired_matrix. (Bug#9990)
756 (verify_row_hash) [XASSERTS]: New function.
757 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
758 that the hash value of glyph rows is correct.
759
760 2011-11-12 Martin Rudalics <rudalics@gmx.at>
761
762 * window.h (window): Remove splits slot.
763 * window.c (Fwindow_splits, Fset_window_splits): Remove.
764 (Fdelete_other_windows_internal, make_parent_window)
765 (make_window, Fsplit_window_internal, Fdelete_window_internal)
766 (Fset_window_configuration, save_window_save): Don't deal with
767 split status of windows.
768 (saved_window): Remove splits slot.
769 (Vwindow_splits): Rewrite doc-string.
770
771 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
772
773 * xfns.c (unwind_create_frame):
774 * nsfns.m (unwind_create_frame):
775 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
776 Vframe_list (Bug#9999).
777
778 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
779
780 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
781
782 2011-11-11 Kenichi Handa <handa@m17n.org>
783
784 * callproc.c (Fcall_process): Set the member dst_multibyte of
785 process_coding.
786
787 2011-11-11 Johan Bockgård <bojohan@gnu.org>
788
789 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
790 avoid a crash (bug#9496).
791
792 2011-11-09 Chong Yidong <cyd@gnu.org>
793
794 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
795 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
796
797 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
798
799 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
800
801 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
802
803 Avoid some portability problems by eschewing 'extern inline' functions.
804 The trivial performance wins aren't worth the portability hassles; see
805 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
806 et seq.
807 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
808 (window_box_width, window_box_left, window_box_left_offset)
809 (window_box_right, window_box_right_offset): Undo previous change,
810 by removing the "extern"s.
811 * intervals.c (adjust_intervals_for_insertion)
812 (adjust_intervals_for_deletion): Undo previous change,
813 making these static again.
814 (offset_intervals, temp_set_point_both, temp_set_point)
815 (copy_intervals_to_string): No longer inline.
816 * xdisp.c (window_text_bottom_y, window_box_width)
817 (window_box_height, window_box_left_offset)
818 (window_box_right_offset, window_box_left, window_box_right)
819 (window_box): No longer inline.
820
821 2011-11-08 Chong Yidong <cyd@gnu.org>
822
823 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
824 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
825 Signal an error if not a live window.
826 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
827 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
828
829 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
830
831 * lisp.h (syms_of_abbrev): Remove declaration.
832 Reported by CHENG Gao <chenggao@royau.me>.
833
834 2011-11-07 Eli Zaretskii <eliz@gnu.org>
835
836 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
837 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
838 of temacs in GUI mode.
839
840 2011-11-07 Martin Rudalics <rudalics@gmx.at>
841
842 * window.h: Declare delete_all_child_windows instead of
843 delete_all_subwindows.
844 * window.c (Fwindow_nest, Fset_window_nest)
845 (Fset_window_new_total, Fset_window_new_normal)
846 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
847 (delete_all_subwindows): Rename to delete_all_child_windows.
848 (Fdelete_other_windows_internal, Fset_window_configuration):
849 Call delete_all_child_windows instead of delete_all_subwindows.
850 * frame.c (delete_frame): Call delete_all_child_windows instead
851 of delete_all_subwindows.
852
853 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
854
855 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
856 This is also needed for porting to any host where GC_MARK_STACK is
857 not GC_MAKE_GCPROS_NOOPS.
858 (which_symbols): Use it.
859
860 2011-11-07 Kenichi Handa <handa@m17n.org>
861
862 * coding.c (coding_set_destination): Check coding->src_pos only
863 when coding->src_object is a buffer (bug#9910).
864
865 * process.c (send_process): Set the member src_multibyte of coding
866 to 0 (bug#9911) when sending a unibyte text.
867
868 * callproc.c (Fcall_process): Set the member src_multibyte of
869 process_coding to 0 (bug#9912).
870
871 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
872
873 * xmenu.c (cleanup_widget_value_tree): New function.
874 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
875 calling free_menubar_widget_value_tree directly (Bug#9830).
876
877 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
878
879 Fix some portability problems with 'inline'.
880 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
881 (window_box_width, window_box_left, window_box_left_offset)
882 (window_box_right, window_box_right_offset): Declare extern.
883 Otherwise, these inline functions do not conform to C99 and
884 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
885 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
886 * intervals.c (adjust_intervals_for_insertion)
887 (adjust_intervals_for_deletion): Now extern, because otherwise the
888 extern inline functions 'offset_intervals' couldn't refer to it.
889 (static_offset_intervals): Remove.
890 (offset_intervals): Rewrite using the old contents of
891 static_offset_intervals. The old version didn't conform to C99
892 because an extern inline function contained a reference to an
893 identifier with static linkage.
894
895 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
896
897 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
898 GC.
899
900 2011-11-06 Eli Zaretskii <eliz@gnu.org>
901
902 * xdisp.c (init_iterator, reseat_to_string): Don't set the
903 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
904 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
905 return Qleft_to_right.
906
907 2011-11-06 Chong Yidong <cyd@gnu.org>
908
909 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
910 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
911 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
912 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
913 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
914 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
915 (Fwindow_vscroll): Doc fix.
916 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
917 argument, since it makes no sense to pass a live window and for
918 consistency with window-child.
919
920 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
921
922 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
923 support MSVC.
924
925 2011-11-05 Jason Rumney <jasonr@gnu.org>
926
927 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
928 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
929 fonts (Bug#6029).
930 (add_font_entity_to_list): Fix logic errors in mixed boolean and
931 bitwise arithmetic preventing use of unicode-sip and non-truetype
932 opentype fonts.
933
934 2011-11-05 Eli Zaretskii <eliz@gnu.org>
935
936 * s/ms-w32.h (fstat, stat, utime): Move redirections to
937 "emacs"-only part.
938
939 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
940 initialization code to keep similarity to xfns.c after changes
941 from 2011-11-05.
942
943 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
944
945 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
946 (unwind_create_frame): New function (Bug#9943).
947 (Fx_create_frame): Restructure code to be more similar to the one in
948 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
949 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
950 Move terminal->reference_count++ just before making the frame official
951 (Bug#9943).
952
953 * nsterm.m (x_free_frame_resources): New function.
954 (x_destroy_window): Move code to x_free_frame_resources.
955
956 * xfns.c (unwind_create_frame): Fix comment.
957 (Fx_create_frame, x_create_tip_frame):
958 Move terminal->reference_count++ just before making the frame
959 official. Move initialization of image_cache_refcount and
960 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
961
962 2011-11-05 Eli Zaretskii <eliz@gnu.org>
963
964 Support MSVC build with newer versions of Visual Studio.
965 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
966 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
967 nt/gmake.defs.
968
969 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
970 which are not supported by MSVC.
971 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
972 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
973 bitfields.
974 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
975 types in bitfields.
976 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
977
978 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
979
980 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
981
982 Support MSVC build with newer versions of Visual Studio.
983 * w32.c: Don't include w32api.h for MSVC.
984 (init_environment) [_MSC_VER]: Call sys_access, not _access.
985
986 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
987 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
988 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
989 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
990 e_* cousins.
991 (alloca) [_MSC_VER]: Define to _alloca.
992
993 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
994
995 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
996
997 2011-11-04 Eli Zaretskii <eliz@gnu.org>
998
999 * xdisp.c (note_mouse_highlight): If either of
1000 previous/next-single-property-change returns nil, treat that as
1001 the beginning or the end of the buffer. (Bug#9955)
1002
1003 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1004
1005 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1006 label is not null (Bug#9951).
1007 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1008 may be NULL.
1009
1010 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1011
1012 * window.c (Fwindow_body_size): Mention in the doc string that the
1013 return value is in frame's canonical units. (Bug#9949)
1014
1015 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1016
1017 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1018
1019 * w32fns.c (unwind_create_frame): If needed, free the glyph
1020 matrices of the partially constructed frame. (Bug#9943)
1021 * xfns.c (unwind_create_frame): Likewise.
1022
1023 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1024
1025 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1026 Don't stop backward scan on the continuation glyph, even though
1027 its CHARPOS is positive.
1028 (mouse_face_from_buffer_pos, note_mouse_highlight):
1029 Rename cover_string to disp_string.
1030
1031 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1032
1033 * window.c (temp_output_buffer_show): Don't use
1034 Vtemp_buffer_show_specifiers.
1035 (Vtemp_buffer_show_specifiers): Remove unused variable.
1036
1037 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1038
1039 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1040 past the beginning of the current glyph matrix.
1041
1042 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1043
1044 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1045 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1046 HAVE_GTK3 (Bug#9869).
1047
1048 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1049 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1050
1051 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1052
1053 * xterm.c: Declare x_handle_net_wm_state to return int.
1054 (handle_one_xevent): Check if we are iconified but don't have
1055 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1056 (get_current_wm_state): Return non-zero if not hidden,
1057 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1058 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1059 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1060 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1061
1062 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1065 so that this new function doesn't get optimized away by a
1066 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1067
1068 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1069
1070 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1071
1072 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1073
1074 Fix the `xbytecode' command.
1075 * .gdbinit (xprintbytestr): New command.
1076 (xwhichsymbols): Rename from `which'; all callers changed.
1077 (xbytecode): Print the byte-code string as well.
1078
1079 2011-10-29 Kim Storm <storm@cua.dk>
1080
1081 * alloc.c (which_symbols): New function.
1082
1083 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1084
1085 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1086 line. (Bug#9903)
1087
1088 2011-10-29 Glenn Morris <rgm@gnu.org>
1089
1090 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1091 Not clear what it was for, and it causes various bugs. (Bug#9839)
1092
1093 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1094
1095 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1096 possible random value that matches one of those tested as
1097 condition to clear the mouse face.
1098
1099 2011-10-28 Chong Yidong <cyd@gnu.org>
1100
1101 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1102
1103 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1104
1105 * window.c (make_window): Initialize phys_cursor_on_p.
1106
1107 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1108
1109 * lisp.h (struct Lisp_Symbol): Update comments.
1110
1111 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1112
1113 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1114
1115 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1116
1117 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1118 <oslsachem@gmail.com> for helping to debug this.
1119
1120 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1121 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1122 (g_b_init_get_glyph_outline_w): New static variables.
1123 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1124 (GetGlyphOutlineW_Proc): New typedefs.
1125 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1126 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1127 New functions.
1128 (w32font_open_internal, compute_metrics):
1129 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1130 instead of calling the "wide" APIs directly.
1131
1132 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1133
1134 * w32.h (syms_of_w32font): Add prototype.
1135
1136 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1137
1138 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1139 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1140 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1141 (Fmove_to_window_line): Doc fix.
1142
1143 2011-10-27 Chong Yidong <cyd@gnu.org>
1144
1145 * process.c (make_process): Set gnutls_state to NULL.
1146
1147 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1148 non-NULL, regardless of GNUTLS_INITSTAGE.
1149 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1150 an error. Set process slots as soon as we allocate them.
1151
1152 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1153
1154 2011-10-27 Chong Yidong <cyd@gnu.org>
1155
1156 * gnutls.c (emacs_gnutls_deinit): New function.
1157 Deallocate credentials structures as well as calling gnutls_deinit.
1158 (Fgnutls_deinit, Fgnutls_boot): Use it.
1159
1160 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1161 (deactivate_process): Call emacs_gnutls_deinit.
1162
1163 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1164
1165 * image.c (x_create_x_image_and_pixmap):
1166 * w32.c (sys_rename, w32_delayed_load):
1167 * w32font.c (fill_in_logfont):
1168 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1169
1170 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1171
1172 * w32fns.c (w32_default_color_map): New function,
1173 extracted from Fw32_default_color_map.
1174 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1175
1176 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1179
1180 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1181
1182 * keyboard.c (test_undefined): New function (bug#9751).
1183 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1184
1185 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1186
1187 * sysdep.c (init_sys_modes): Fix the check for the controlling
1188 terminal (Bug#6649).
1189
1190 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1191
1192 * dispextern.h (struct bidi_it): New member next_en_type.
1193
1194 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1195 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1196 current character, check also for next_en_type being WEAK_EN.
1197 (bidi_resolve_weak): Don't enter the expensive loop if the current
1198 position is before next_en_pos. Record the bidi type of the first
1199 non-ET, non-BN character we find, in addition to its position.
1200 (bidi_level_of_next_char): Invalidate next_en_type when
1201 next_en_pos is over-stepped.
1202
1203 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1204
1205 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1206 * editfns.c: Rewrite current-time-zone so that it invokes
1207 the equivalent of (format-time-string "%Z") to get the time zone name.
1208 This fixes a bug when the time zone name contains characters that
1209 need converting from the system time locale to Emacs internal format.
1210 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1211 that patch fixed format-time-string to do the conversion, but
1212 I forgot to fix current-time-zone.
1213 (format_time_string): New function, containing most of
1214 what Fformat_time_string used to contain.
1215 (Fformat_time_string): Rewrite in terms of format_time_string.
1216 This doesn't change this function's behavior.
1217 (current-time-zone): Rewrite to use format_time_string.
1218 This fixes the bug reported by Michael Schierl in
1219 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1220 Jason Rumney's 2007-06-07 change worked around this bug, but
1221 didn't fix it.
1222 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1223
1224 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1225
1226 * xdisp.c (start_display): If the character at POS is displayed
1227 via a display vector, reset IT->current.dpvec_index to zero.
1228 (try_window_reusing_current_matrix): If a line ends in a display
1229 vector or the next line starts in a display vector, continue
1230 redrawing the window even though the character position of
1231 start_row was reached.
1232 (Bug#9771, part 2)
1233
1234 2011-10-18 Chong Yidong <cyd@gnu.org>
1235
1236 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1237 with nobreak-char-display too.
1238
1239 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1240
1241 Fix part 3 of bug#9771.
1242 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1243 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1244 non-neutral characters if the current character is a paragraph
1245 separator (a.k.a. Newline). This avoids running the same
1246 expensive loop twice, once when we consume the preceding newline
1247 and the other time when the line actually needs to be displayed.
1248 Avoid the loop when we see neutrals on the base embedding level
1249 following a character whose directionality is the same as the
1250 paragraph's. This avoids running the expensive loop when a line
1251 ends in a long sequence of neutrals, like control characters.
1252 Add assertion against STRONG_AL type. Slightly rearrange code
1253 that determines the type of a neutral given the first non-neutral
1254 that follows it.
1255 (bidi_level_of_next_char): Set next_en_pos to zero when
1256 invalidating its info.
1257
1258 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1259
1260 * xdisp.c (push_display_prop): Determine whether to record string
1261 or buffer position by IT->string, not by IT->method. Allow
1262 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1263 (move_it_vertically_backward): Don't look for character position
1264 immediately after the newline when in a continuation line.
1265 (Bug#9771, part 1)
1266
1267 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1268
1269 * window.c (coordinates_in_window): Rewrite and delabelize
1270 vertical border check. (Bug#5357) (Bug#9618)
1271
1272 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1273
1274 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1275 errors in XSetWindowBorder (bug#9310).
1276
1277 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1278
1279 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1280 avoid crash when xmalloc overrun checking is enabled.
1281
1282 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1283
1284 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1285 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1286 cursor motion with <left> and <right> arrow keys.
1287
1288 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1289 some callers set that themselves.
1290
1291 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1292
1293 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1294 display string and the previous row comes from the same string and
1295 is empty. (Bug#9739) (Bug#9738)
1296
1297 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1298
1299 * doc.c (get_doc_string): Encode file name (bug#9735).
1300
1301 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1302
1303 * bidi.c (bidi_level_of_next_char):
1304 * xdisp.c (get_visually_first_element): Remove old incorrect
1305 comments regarding the Unicode Line Separator character.
1306
1307 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1308
1309 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1310
1311 * alloc.c (Fgc_status): Do not access beyond zombies array
1312 boundary if nzombies > MAX_ZOMBIES.
1313 * alloc.c (dump_zombies): Add missing format specifier.
1314
1315 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1316
1317 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1318 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1319
1320 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1321 Some packages use them to denote characters with modifiers.
1322
1323 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1324
1325 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1326 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1327 matching a pp-number. Rename parameter var to var1.
1328
1329 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1330
1331 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1332
1333 2011-10-08 Glenn Morris <rgm@gnu.org>
1334
1335 * callint.c (Fcall_interactively): Give a more explicit error for the
1336 'c' case with a non-character input. (Bug#8479)
1337
1338 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1339
1340 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1341 lines.
1342 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1343 lines that are hscrolled on the left.
1344
1345 * dispnew.c (buffer_posn_from_coords): Account for a possible
1346 presence of header-line. (Bug#4426)
1347
1348 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1349
1350 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1351 Don't advertise functionality which we discourage or doesn't work.
1352
1353 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1354
1355 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1356 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1357 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1358 this makes Emacs dump core during garbage collection on rare
1359 occasions. sizeof is obviously inferior to offsetof here, so
1360 stick with offsetof.
1361 (GC_POINTER_ALIGNMENT): New macro.
1362 (mark_memory): Omit 3rd (offset) arg; caller changed.
1363 Don't assume EMACS_INT alignment is the same as pointer alignment.
1364
1365 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1366
1367 * keyboard.c (read_key_sequence_remapped): New var.
1368 (read_key_sequence): Compute remapping in the right buffer.
1369 (command_loop_1): Use read_key_sequence's remapping directly.
1370
1371 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1372
1373 * dired.c (file_name_completion): Don't expand file name.
1374 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1375 before checking file name handler.
1376
1377 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1378 they've been requested explicitly (bug#9591).
1379
1380 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1381
1382 * keymap.c (Fsingle_key_description): Use make_specified_string
1383 instead of build_string to build string from push_key_description.
1384 (Bug#5193)
1385
1386 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1389 This fixes a Y2038 bug on 64-bit hosts.
1390 * buffer.c (reset_buffer):
1391 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1392 (Fclear_buffer_auto_save_failure):
1393 Use 0, not -1, to represent an unset failure time, since time_t
1394 might not be signed.
1395
1396 Remove dependency on glibc malloc internals.
1397 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1398 Move back here from lisp.h, but with their new implementations.
1399 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1400 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1401 * charset.c (charset_table_init): New static var.
1402 (syms_of_charset): Use it instead of xmalloc. This removes a
1403 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1404 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1405 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1406 Move back to alloc.c.
1407 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1408 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1409
1410 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1411
1412 * nsterm.m (windowDidResize): Call x_set_window_size only when
1413 ns_in_resize is true. Otherwise set pixelwidth/height and
1414 call change_frame_size (Bug#9628).
1415
1416 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1417
1418 Port --enable-checking=all to Fedora 14 x86-64.
1419 * charset.c (syms_of_charset): Also account for glibc malloc's
1420 internal overhead when calculating the initial malloc maximum.
1421
1422 Port --enable-checking=all to Fedora 14 x86.
1423 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1424 Move to lisp.h.
1425 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1426 (overrun_check_realloc, overrun_check_free):
1427 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1428 That way, xmalloc returns a properly-aligned pointer even if
1429 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1430 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1431 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1432 into account when calculating the initial malloc maximum.
1433 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1434 Move here from alloc.c, so that charset.c can use it too.
1435 Properly align; the old code wasn't right for common 32-bit hosts
1436 when configured with --enable-checking=all.
1437 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1438 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1439
1440 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1441
1442 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1443 use EDOM.
1444
1445 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1446
1447 * xdisp.c (compute_display_string_end): If there's no display
1448 string at CHARPOS, return -1.
1449
1450 * bidi.c (bidi_fetch_char): When compute_display_string_end
1451 returns a negative value, treat the character as a normal
1452 character not covered by a display string. (Bug#9624)
1453
1454 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1455
1456 * lread.c (Fread_from_string): Fix typo in docstring.
1457
1458 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1459
1460 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1461 newline, reseat the iterator instead of bidi-iterating there one
1462 character at a time. (Bug#9610)
1463 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1464 TO_CHARPOS if the bidi iterator is at base embedding level.
1465
1466 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1467
1468 * lread.c (readevalloop): Use correct code for NBSP.
1469 (read1): Likewise. (Bug#9608)
1470
1471 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1472
1473 * dbusbind.c (Fdbus_register_signal): When service is not
1474 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1475
1476 2011-09-25 Glenn Morris <rgm@gnu.org>
1477
1478 * buffer.c (truncate-lines): Doc fix.
1479
1480 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1481
1482 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1483 (Fset_window_next_buffers): Doc fix.
1484
1485 2011-09-24 Glenn Morris <rgm@gnu.org>
1486
1487 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1488
1489 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1490
1491 Fix minor problems found by static checking.
1492 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1493 * indent.c (Fvertical_motion): Fix == vs = typo.
1494
1495 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1496
1497 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1498 Default value is now t. Doc fix.
1499
1500 * indent.c (Fvertical_motion): Compute and apply the overshoot
1501 logic when moving up, not only when moving down. Fix the
1502 confusing name and values of the it_overshoot_expected variable;
1503 logic changes accordingly. (Bug#9254) (Bug#9549)
1504
1505 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1506 CHARPOS is covered by a display string which includes newlines.
1507 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1508 is covered by a display string with embedded newlines.
1509
1510 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1511
1512 * dbusbind.c (Fdbus_register_signal): Add match rule to
1513 Vdbus_registered_objects_table. (Bug#9581)
1514 (Fdbus_register_method, Vdbus_registered_objects_table):
1515 Fix docstring.
1516
1517 2011-09-24 Jim Meyering <meyering@redhat.com>
1518
1519 do not ignore write error for any output size
1520 The previous change was incomplete.
1521 While it makes emacs --batch detect the vast majority of stdout
1522 write failures, errors were still ignored whenever the output size is
1523 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1524 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1525 && echo FAIL: ignored write error
1526 FAIL: ignored write error
1527 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1528 && echo FAIL: ignored write error
1529 FAIL: ignored write error
1530 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1531
1532 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1533
1534 * emacs.c (Fkill_emacs): In noninteractive mode exit
1535 non-successfully if a write error occurred on stdout. (Bug#9574)
1536
1537 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1538
1539 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1540 the xassert test.
1541
1542 * dispextern.h (struct it): Update the comment documenting what
1543 can it->OBJECT be.
1544
1545 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1546
1547 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1548 a display string, extend search for cursor position to end of row.
1549 (find_row_edges): If the row ends in a newline from a display
1550 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1551 Handle the case of a display string with multiple newlines.
1552 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1553 non-empty line. Fixes confusing cursor motion with arrow keys at
1554 the beginning of a line that starts with whitespace.
1555
1556 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1557
1558 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1559 (bug#9493).
1560
1561 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1562
1563 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1564 boolean (Bug#9154).
1565
1566 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1567
1568 * xdisp.c (display_line): Record maximum and minimum buffer
1569 positions even if no glyphs were produced (e.g., by a zero-width
1570 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1571 buffer positions that will be removed from the glyph row because
1572 they don't fit.
1573 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1574 column is beyond frame width: don't subtract 1 "pixel" when
1575 computing width of the stretch.
1576 (reseat_at_next_visible_line_start): Undo the change made on
1577 2011-09-17 that saved paragraph information and restored it after
1578 the call to `reseat'. (Bug#9545)
1579
1580 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1581
1582 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1583 and turn window cursor on if cleared (Bug#9415).
1584
1585 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1586
1587 * search.c (boyer_moore): Take unibyte characters from pattern
1588 literally. (Bug#9458)
1589
1590 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1591
1592 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1593
1594 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1595
1596 Fix minor problem found by static checking.
1597 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1598 initialized, to pacify gcc -Wuninitialized.
1599
1600 * fileio.c: Report proper errno when syscall falls.
1601 (Finsert_file_contents): Save and restore errno,
1602 so that report_file_error outputs the correct diagnostic.
1603 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1604
1605 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1606
1607 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1608
1609 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1610
1611 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1612 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1613
1614 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1615
1616 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1617 about the current paragraph and restore it after the call to reseat.
1618
1619 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1620 (bidi_find_paragraph_start): Search back for paragraph beginning
1621 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1622 (bidi_move_to_visually_next): Only trigger paragraph-related
1623 computations when the last character is a newline or at EOB, not
1624 just any NEUTRAL_B. (Bug#9470)
1625
1626 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1627 truncated lines if point is covered by a display string. (Bug#9524)
1628
1629 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1630
1631 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1632 (cons_to_x_long): New function.
1633 (lisp_data_to_selection_data): Use it. Correct the test for
1634 short-versus-long data; it was negated. Break out of vector
1635 loop, for efficiency, when a long datum is discovered.
1636
1637 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1638
1639 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1640
1641 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1642
1643 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1644 GCC PR/17406) by declaring this function with external scope.
1645
1646 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1647
1648 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1649 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1650
1651 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1652
1653 * editfns.c (Fformat): Correctly handle text properties on "%%".
1654
1655 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1656
1657 * xterm.c (x_draw_composite_glyph_string_foreground):
1658 * w32term.c (x_draw_composite_glyph_string_foreground):
1659 * term.c (encode_terminal_code):
1660 * composite.c (composition_update_it, get_composition_id):
1661 * xdisp.c (get_next_display_element)
1662 (fill_composite_glyph_string): Add comments about special meaning
1663 of TAB characters in a composition.
1664
1665 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1666
1667 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1668 This occurs when processing a multibyte format.
1669 Problem reported by Wolfgang Jenker.
1670
1671 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1672
1673 * xdisp.c (try_cursor_movement): Only check for exact match if
1674 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1675
1676 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1677
1678 Remove unused external symbols.
1679 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1680 * xdisp.c (calc_pixel_width_or_height): Now static.
1681 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1682 * indent.c (check_display_width):
1683 * w32term.c: Fix comment to match code.
1684 * xterm.c, xterm.h (x_catching_errors): Remove.
1685
1686 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 * xselect.c: Use signed conversions more consistently (Bug#9498).
1689 (selection_data_to_lisp_data): Assume incoming selection data are
1690 signed integers, not unsigned. This is to be consistent with
1691 outgoing selection data, which was modified to use signed integers
1692 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1693 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1694 expects long, not unsigned long.
1695
1696 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1697
1698 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1699 computation of loop end. Reported by Johan Bockgård
1700 <bojohan@gnu.org>.
1701
1702 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1703
1704 * frame.c (Fother_visible_frames_p): Function deleted.
1705
1706 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1707
1708 * indent.c (compute_motion): Process display vector front to back
1709 rather than the other way around. (Bug#2496)
1710
1711 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1712
1713 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1714
1715 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1716
1717 * minibuf.c (Fread_from_minibuffer): Doc fix.
1718
1719 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1720
1721 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1722 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1723
1724 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1725
1726 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1727 value for non-existent files.
1728
1729 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1730
1731 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1732 set its "size" to -1. This will set the modtime_size field of
1733 the corresponding buffer to -1, which is what
1734 verify-visited-file-modtime expects for files that do not exist.
1735 (Bug#9139)
1736
1737 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1738
1739 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1740 here ...
1741 * lisp.h: ... from here. push_key_description is no longer
1742 defined in keyboard.c, so its declaration should not be in
1743 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1744 logically belongs with push_key_description.
1745
1746 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1747
1748 * buffer.h: Include <sys/types.h> instead of <time.h>.
1749 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1750 Problem reported by Herbert J. Skuhra.
1751
1752 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1753
1754 * xml.c (parse_region): Make the parsing work for
1755 non-comment-starting XML files again (bug#9144).
1756
1757 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1758
1759 * image.c (gif_load): Fix calculation of bottom and right corner.
1760 (Bug#9468)
1761
1762 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1763
1764 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1765 redisplay in small windows.
1766
1767 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1768
1769 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1770
1771 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1772
1773 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1774 Operate on live windows only.
1775
1776 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1777
1778 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1779
1780 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1781
1782 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1783 only under bidi iteration.
1784
1785 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1786
1787 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1788
1789 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1790
1791 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1792 Without this fix, the command to link temacs failed due to an
1793 undefined symbol __builtin_isnan. This is because
1794 /usr/include/iso/math_c99.h #defines isnan(x) to
1795 __builtin_isnan(x), but the bundled gcc, which identifies itself
1796 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1797 a __builtin_isnan.
1798 * floatfns.c (isnan): #undef, and then #define to a clone of
1799 what's in data.c.
1800 (Fisnan): Always define, since it's always available now.
1801 (syms_of_floatfns): Always define isnan at the Lisp level.
1802
1803 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1804
1805 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1806
1807 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1808
1809 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1810 The previous code assumed that file offsets (off_t values) fit in
1811 EMACS_INT variables, which is not true on typical 32-bit hosts.
1812 The code messed up by falsely reporting buffer overflow in cases
1813 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1814 when "big" contains more than 2**29 bytes, even though this
1815 inserts just one byte and does not overflow the buffer.
1816 (Finsert_file_contents): Store file offsets as off_t
1817 values, not as EMACS_INT values. Check for overflow when
1818 converting between EMACS_INT and off_t. When checking for
1819 buffer overflow or for overlap, take the offsets into account.
1820 Don't use EMACS_INT for small values where int suffices.
1821 When checking for overlap, fix a typo: ZV was used where
1822 ZV_BYTE was intended.
1823 (Fwrite_region): Don't assume off_t fits into 'long'.
1824 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1825
1826 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1827
1828 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1829
1830 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1831
1832 sprintf-related integer and memory overflow issues (Bug#9412).
1833
1834 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1835 (esprintf, exprintf, evxprintf): New functions.
1836 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1837 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1838 (modify_event_symbol): Do not assume that the length of
1839 name_alist_or_stem is safe to alloca and fits in int.
1840 (Fexecute_extended_command): Likewise for function name and binding.
1841 (Frecursion_depth): Wrap around reliably on integer overflow.
1842 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1843 since some callers pass EMACS_INT values.
1844 (Fsingle_key_description): Don't crash if symbol name contains more
1845 than MAX_ALLOCA bytes.
1846 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1847 (get_minibuffer): Arg is now EMACS_INT, not int.
1848 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1849 (esprintf, exprintf, evxprintf): New decls.
1850 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1851
1852 * dbusbind.c (signature_cat): New function.
1853 (xd_signature, Fdbus_register_signal):
1854 Do not overrun buffer; instead, report string overflow.
1855
1856 * dispnew.c (add_window_display_history): Don't overrun buffer.
1857 Truncate instead; this is OK since it's just a log.
1858
1859 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1860 even if the time zone offset is outlandishly large.
1861 Don't mishandle offset == INT_MIN.
1862
1863 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1864 when creating daemon; the previous buffer-overflow check was incorrect.
1865
1866 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1867 which has the guts of the old verror function.
1868
1869 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1870 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1871
1872 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1873 (font_unparse_xlfd): Don't blindly alloca long strings.
1874 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1875 fits in int, when using sprintf. Use single snprintf to count
1876 length of string rather than counting it via multiple sprintfs;
1877 that's simpler and more reliable.
1878 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1879 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1880 sprintf, in case result does not fit in int.
1881
1882 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1883 (fontset_from_font): Print it.
1884
1885 * frame.c (tty_frame_count): Now printmax_t, not int.
1886 (make_terminal_frame, set_term_frame_name): Print it.
1887 (x_report_frame_params): In X, window IDs are unsigned long,
1888 not signed long, so print them as unsigned.
1889 (validate_x_resource_name): Check for implausibly long names,
1890 and don't assume name length fits in 'int'.
1891 (x_get_resource_string): Don't blindly alloca invocation name;
1892 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1893 not fit in int.
1894
1895 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1896 (xg_check_special_colors, xg_set_geometry):
1897 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1898
1899 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1900 Use esprintf, not sprintf, in case result does not fit in int.
1901
1902 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1903 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1904 it as a large positive number.
1905 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1906 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1907
1908 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1909 in case result does not fit in int.
1910
1911 * print.c (float_to_string): Detect width overflow more reliably.
1912 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1913 buffer overrun. Don't assume list length fits in 'int'. Treat
1914 print length of 0 as 0, not as infinity; to be consistent with other
1915 uses of print length in this function. Don't overflow print length
1916 index. Don't assume hash table size fits in 'long', or that
1917 vectorlike size fits in 'unsigned long'.
1918
1919 * process.c (make_process): Use printmax_t, not int, to format
1920 process-name gensyms.
1921
1922 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1923
1924 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1925 to avoid potential buffer overrun.
1926
1927 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1928 if X resource line is longer than 512 bytes.
1929
1930 * xfns.c (x_window): Make sprintf buffer a bit bigger
1931 to avoid potential buffer overrun.
1932
1933 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1934
1935 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1936
1937 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1938
1939 Integer overflow fixes for scrolling, etc.
1940 Without these, Emacs silently mishandles large integers sometimes.
1941 For example, "C-u 4294967297 M-x recenter" was treated as if
1942 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1943
1944 * xdisp.c (try_window_id): Check Emacs fixnum range before
1945 converting to 'int'.
1946
1947 * window.c (window_scroll_line_based, Frecenter):
1948 Check that an Emacs fixnum is in range before assigning it to 'int'.
1949 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1950 values converted from Emacs fixnums.
1951 (Frecenter): Don't wrap around a line count if it is out of 'int'
1952 range; instead, treat it as an extreme value.
1953 (Fset_window_configuration, compare_window_configurations):
1954 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1955
1956 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1957 that can exceed INT_MAX. Check that EMACS_INT value is in range
1958 before assigning it to the (possibly-narrower) index.
1959 (match_limit): Don't assume that a fixnum can fit in 'int'.
1960
1961 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1962 exceed INT_MAX.
1963
1964 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1965 (Fvertical_motion): Don't wrap around LINES values that don't fit
1966 in 'int'. Instead, treat them as extreme values. This is good
1967 enough for windows, which can't have more than INT_MAX lines anyway.
1968
1969 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1970
1971 * Require libxml/parser.h to avoid compilation warning.
1972
1973 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1974
1975 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1976 since this reportedly can destroy thread storage.
1977
1978 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1979
1980 * syntax.c (find_defun_start): Update all cache variables if
1981 exiting early (Bug#9401).
1982
1983 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1984
1985 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1986
1987 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1988 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1989 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1990
1991 * term.c (tty_append_glyph): New function.
1992 (produce_stretch_glyph): Static function and its prototype deleted.
1993
1994 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1995 Add prototypes.
1996
1997 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1998
1999 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2000 when checking :margin (Bug#9390).
2001 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2002 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2003 so that the name doesn't mislead. All uses changed.
2004
2005 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2006
2007 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2008 set_tty_hooks.
2009
2010 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2011
2012 * xdisp.c (move_it_to): Don't bail out early when reaching
2013 position beyond to_charpos, if we are scanning backwards.
2014 (move_it_vertically_backward): When DY == 0, make sure we get to
2015 the first character in the line after the newline.
2016
2017 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2018
2019 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2020 (ccl_driver): Do not generate an out-of-range pointer.
2021 (Fccl_execute_on_string): Remove unnecessary check for
2022 integer overflow, noted by Stefan Monnier in
2023 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2024 Remove a FIXME that didn't need fixing.
2025 Simplify the newly-introduced buffer reallocation code.
2026
2027 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2028
2029 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2030
2031 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2032
2033 Integer and memory overflow issues (Bug#9196).
2034
2035 * doc.c (get_doc_string): Rework so that
2036 get_doc_string_buffer_size is the actual buffer size, rather than
2037 being 1 less than the actual buffer size; this makes xpalloc more
2038 convenient.
2039
2040 * image.c (x_allocate_bitmap_record, cache_image):
2041 * xselect.c (Fx_register_dnd_atom):
2042 Simplify previous changes by using xpalloc.
2043
2044 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2045 since either will do and ptrdiff_t is convenient with xpalloc.
2046
2047 * charset.c (charset_table_size)
2048 (struct charset_sort_data.priority): Now ptrdiff_t.
2049 (charset_compare): Don't overflow if priorities differ greatly.
2050 (Fsort_charsets): Don't assume list length fits in int.
2051 Check for size-calculation overflow when allocating sort data.
2052 (syms_of_charset): Allocate an initial charset table that is
2053 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2054
2055 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2056
2057 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2058 The actual value is always <= INT_MAX, and leaving it unsigned made
2059 overflow checking harder.
2060
2061 * dispextern.h (struct glyph_matrix.rows_allocated)
2062 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2063 with xpalloc. The values are still always <= INT_MAX.
2064
2065 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2066
2067 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2068 (SAFE_NALLOCA): New macro.
2069
2070 * region-cache.c (struct boundary.pos, find_cache_boundary)
2071 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2072 (set_cache_region, invalidate_region_cache)
2073 (revalidate_region_cache, know_region_cache, region_cache_forward)
2074 (region_cache_backward, pp_cache):
2075 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2076 so that ptrdiff_t * can be passed to xpalloc.
2077 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2078 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2079 (pp_cache): Don't assume cache_len fits in int.
2080 * region-cache.h: Adjust extern decls to match.
2081
2082 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2083 EMACS_INT, since either will do, for xpalloc.
2084
2085 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2086 (xnmalloc, xnrealloc, xpalloc): New functions.
2087
2088 * bidi.c (bidi_shelve_header_size): New constant.
2089 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2090 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2091
2092 * bidi.c (bidi_cache_shrink):
2093 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2094 (overlay_strings):
2095 Don't update size of array until after memory allocation succeeds,
2096 because xmalloc/xrealloc may not return.
2097 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2098 now that we have proper integer overflow checking.
2099 (record_overlay_string, overlay_strings): Catch overflows when
2100 calculating size of overlay_str_buf.
2101
2102 * callproc.c (Fcall_process): Check for size overflow when
2103 calculating size of args2.
2104 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2105 Normally we prefer signed values, but sticking with ptrdiff_t would
2106 require adding more-complicated checks.
2107
2108 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2109 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2110 Redo buffer-overflow calculations to avoid integer overflow.
2111 Add a FIXME comment where memory seems to be over-allocated.
2112
2113 * character.c (Fstring): Check for size-calculation overflow.
2114
2115 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2116 unnecessary integer overflow. Check for size overflow.
2117 (encode_coding_object): Don't update size until xmalloc succeeds.
2118
2119 * composite.c (get_composition_id): Check for overflow in glyph
2120 length calculations.
2121
2122 Integer and memory overflow fixes for display code.
2123 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2124 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2125 (scrolling_window): Check for overflow in size calculations.
2126 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2127 Don't assume glyph table len fits in int.
2128 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2129 (row_table_size): Now ptrdiff_t, not int.
2130 (scrolling_window): Avoid overflow in size calculations.
2131 Don't update size until allocation succeeds.
2132 * fns.c (concat): Check for overflow in size calculations.
2133 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2134 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2135 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2136
2137 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2138 (get_doc_string): Check for size calculation overflow.
2139 Don't update size until allocation succeeds.
2140 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2141 EMACS_INT, where ptrdiff_t will do.
2142 (Fsubstitute_command_keys): Check for string overflow.
2143
2144 * editfns.c (set_time_zone_rule): Don't assume environment length
2145 fits in int.
2146 (message_length): Now ptrdiff_t, not int.
2147 (Fmessage_box): Don't update size until allocation succeeds.
2148 Don't assume message length fits in int.
2149 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2150
2151 * emacs.c (main): Do not reallocate argv, since there is a null at
2152 the end that can be overwritten, and this way there's no need to
2153 worry about size-calculation overflow.
2154 (sort_args): Check for size-calculation overflow.
2155
2156 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2157 alloc succeeds.
2158 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2159
2160 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2161 (x_set_scroll_bar_width, x_figure_window_size):
2162 Check for integer overflow.
2163 (x_set_alpha): Do not assume XINT fits in int.
2164
2165 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2166 This is for the members text_lines, text_cols, total_lines, total_cols,
2167 where the system imposes an 'int' limit.
2168
2169 * fringe.c (Fdefine_fringe_bitmap):
2170 Don't update size until alloc works.
2171
2172 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2173 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2174
2175 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2176 Check for size-calculation overflow.
2177 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2178 do, as we prefer signed integers.
2179 (id_to_widget.max_size, id_to_widget.used)
2180 (xg_store_widget_in_map, xg_remove_widget_from_map)
2181 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2182 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2183 Use and return ptrdiff_t, not int.
2184 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2185 * gtkutil.h: Change prototypes to match the above.
2186
2187 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2188 are duplicate now that they've been promoted to lisp.h.
2189 (x_allocate_bitmap_record, x_alloc_image_color)
2190 (make_image_cache, cache_image, xpm_load):
2191 Don't update size until alloc is done.
2192 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2193 (x_detect_edges):
2194 Check for size calculation overflow.
2195 (ct_colors_allocated_max): New constant.
2196 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2197 overflow.
2198
2199 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2200 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2201 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2202 Use ptrdiff_t, not int, to count maps.
2203 (read_char_minibuf_menu_prompt): Check for overflow in size
2204 calculations. Don't update size until allocation succeeds.
2205 Redo calculations to avoid overflow.
2206 * keyboard.h: Change prototypes to match the above.
2207
2208 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2209 to count maps.
2210 (current_minor_maps): Check for size calculation overflow.
2211 * keymap.h: Change prototypes to match the above.
2212
2213 * lread.c (read1, init_obarray): Don't update size until alloc done.
2214
2215 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2216 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2217
2218 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2219 Now ptrdiff_t, not int.
2220 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2221 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2222
2223 * process.c (Fnetwork_interface_list): Check for overflow
2224 in size calculation.
2225
2226 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2227
2228 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2229 overflow. Don't bother calling xmalloc when xrealloc will do.
2230
2231 * search.c (Freplace_match): Check for size calculation overflow.
2232 (Fset_match_data): Don't assume list lengths fit in 'int'.
2233
2234 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2235 for command line length. Do not attempt to address one before the
2236 beginning of an array, as that's not portable.
2237
2238 * term.c (max_frame_lines): Remove; unused.
2239 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2240 not int.
2241 (encode_terminal_code, calculate_costs): Check for size
2242 calculation overflow.
2243 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2244 table lengths and related sizes. Don't update size until alloc
2245 done. Redo calculations to avoid overflow.
2246 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2247
2248 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2249 subtracting pointers.
2250 (gobble_line): Check for overflow more carefully. Don't update size
2251 until alloc done.
2252
2253 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2254 Don't update size until alloc done.
2255 Redo size calculations to avoid overflow.
2256 Check for size calculation overflow.
2257 (main) [DEBUG]: Fix typo in invoking tparam1.
2258
2259 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2260 Use ptrdiff_t, not int, for sizes.
2261 (store_mode_line_noprop_char): Don't update size until alloc done.
2262
2263 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2264 Use ptrdiff_t, not int, for sizes.
2265 (Finternal_make_lisp_face, cache_face):
2266 Check for size calculation overflow.
2267 (cache_face): Treat size calculation overflows as if they were
2268 memory exhaustion (the usual treatment), rather than aborting.
2269
2270 * xfns.c (x_encode_text, x_set_name_internal)
2271 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2272 sizes, since they can exceed INT_MAX in size. Check for size
2273 calculation overflow.
2274
2275 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2276 (xg_select): Check for size calculation overflow.
2277 Don't update size until alloc done.
2278
2279 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2280 as sprintf is limited to int lengths.
2281
2282 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2283 (X_LONG_MIN): New macros.
2284 Use them to make the following changes clearer.
2285 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2286 This change doesn't affect the value now, but it may help remind
2287 future maintainers not to raise the value too much later.
2288 (SELECTION_QUANTUM): Remove, replacing with ...
2289 (selection_quantum): ... new function, which avoids overflow.
2290 All uses changed.
2291 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2292 assumption that selection length fits in 'int'.
2293 (x_reply_selection_request, x_handle_selection_request)
2294 (x_get_window_property, receive_incremental_selection)
2295 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2296 (lisp_data_to_selection_data, clean_local_selection_data):
2297 Use ptrdiff_t, not int, to record length of selection.
2298 (x_reply_selection_request, x_get_window_property)
2299 (receive_incremental_selection, x_property_data_to_lisp):
2300 Redo calculations to avoid overflow.
2301 (x_reply_selection_request): When sending hint, ceiling it at
2302 X_LONG_MAX rather than relying on wraparound overflow to send
2303 something.
2304 (x_get_window_property, receive_incremental_selection)
2305 (lisp_data_to_selection_data, x_property_data_to_lisp):
2306 Check for size-calculation overflow.
2307 (x_get_window_property, receive_incremental_selection)
2308 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2309 Don't store size until memory allocation succeeds.
2310 (x_get_window_property): Plug memory leak on memory exhaustion.
2311 Don't double-block input; malloc is safe here. Don't assume 2**34
2312 - 4 fits in unsigned long. Add an xassert to check
2313 XGetWindowProperty overflow. Be more careful about overflow
2314 calculations, and distinguish size from memory overflow better.
2315 (receive_incremental_selection): When tracing, don't assume
2316 unsigned int is less than INT_MAX.
2317 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2318 harmful) conversions of unsigned short to int.
2319 (lisp_data_to_selection_data): Don't assume that integers
2320 in the range -65535 through -1 fit in an X unsigned short.
2321 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2322 result parameters unless successful. Rely on cons_to_unsigned
2323 to report problems with elements; the old code wasn't right anyway.
2324 (x_check_property_data): Check for int overflow; we cannot use
2325 a wider type due to X limits.
2326 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2327
2328 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2329
2330 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2331 (x_term_init): Check for size calculation overflow.
2332 (x_color_cells): Don't store size until memory allocation succeeds.
2333 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2334 Don't assume alloca size is less than MAX_ALLOCA.
2335 (x_term_init): Don't assume length fits in int (sprintf is limited
2336 to int size).
2337
2338 Use ptrdiff_t for composition IDs.
2339 * character.c (lisp_string_width):
2340 * composite.c (composition_table_size, n_compositions)
2341 (get_composition_id, composition_gstring_from_id):
2342 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2343 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2344 * window.c (Frecenter):
2345 Use ptrdiff_t, not int, for composition IDs.
2346 * composite.c (get_composition_id): Check for integer overflow.
2347 * composite.h: Adjust prototypes to match the above changes.
2348
2349 Use ptrdiff_t for hash table indexes.
2350 * category.c (hash_get_category_set):
2351 * ccl.c (ccl_driver):
2352 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2353 * coding.c (coding_system_charset_list, detect_coding_system):
2354 * coding.h (struct coding_system.id):
2355 * composite.c (get_composition_id, gstring_lookup_cache):
2356 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2357 * image.c (xpm_get_color_table_h):
2358 * lisp.h (hash_lookup, hash_put):
2359 * minibuf.c (Ftest_completion):
2360 Use ptrdiff_t for hash table indexes, not int (which is too
2361 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2362 32-bit --with-wide-int hosts).
2363
2364 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2365 Add a FIXME comment about memory leaks.
2366 (syms_of_charset): Don't assume xmalloc returns.
2367
2368 Don't assume that stated character widths fit in int.
2369 * character.c (Fchar_width, c_string_width, lisp_string_width):
2370 * character.h (CHAR_WIDTH):
2371 * indent.c (MULTIBYTE_BYTES_WIDTH):
2372 Use sanitize_char_width to avoid undefined and/or bad behavior
2373 with outlandish widths.
2374 * character.h (sanitize_tab_width): Rename from sanitize_width,
2375 now that we have two such functions. All uses changed.
2376 (sanitize_char_width): New inline function.
2377
2378 Don't assume that tab-width fits in int.
2379 * character.h (sanitize_width): New inline function.
2380 (SANE_TAB_WIDTH): New macro.
2381 (ASCII_CHAR_WIDTH): Use it.
2382 * indent.c (sane_tab_width): Remove. All uses replaced by
2383 SANE_TAB_WIDTH (current_buffer).
2384 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2385
2386 * fileio.c: Integer overflow issues with file modes.
2387 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2388
2389 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2390 Remove unreachable code.
2391 (read_hex, load_charset_map_from_file): Check for integer overflow.
2392
2393 * xterm.c: Don't go over XClientMessageEvent limit.
2394 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2395 (x_send_scroll_bar_event): Likewise. Check that the size does not
2396 exceed limits imposed by XClientMessageEvent, as well as the usual
2397 ptrdiff_t and size_t limits.
2398
2399 * keyboard.c: Overflow, signedness and related fixes.
2400 (make_lispy_movement): Use same integer type in forward decl
2401 that is used in the definition.
2402 (read_key_sequence, keyremap_step):
2403 Change bufsize argument back to int, undoing my 2011-03-30 change.
2404 We prefer signed types, and int is wide enough here.
2405 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2406 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2407 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2408 length, not size_t. Use ptrdiff_t for index, not int.
2409 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2410 possibility of integer overflow.
2411
2412 Overflow, signedness and related fixes for images.
2413
2414 * dispextern.h (struct it.stack[0].u.image.image_id)
2415 (struct_it.image_id, struct image.id, struct image_cache.size)
2416 (struct image_cache.used, struct image_cache.ref_count):
2417 * gtkutil.c (update_frame_tool_bar):
2418 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2419 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2420 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2421 * nsmenu.m (update_frame_tool_bar):
2422 * xdisp.c (calc_pixel_width_or_height):
2423 * xfns.c (image_cache_refcount):
2424 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2425 on typical 64-bit hosts.
2426
2427 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2428 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2429 Omit unnecessary casts to int.
2430 (parse_image_spec): Check that integers fall into 'int' range
2431 when the callers expect that.
2432 (image_ascent): Redo ascent calculation to avoid int overflow.
2433 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2434 (lookup_image): Remove unnecessary tests.
2435 (xbm_image_p): Locals are now of int, not EMACS_INT,
2436 since parse_image_check makes sure they fit into int.
2437 (png_load, gif_load, svg_load_image):
2438 Prefer int to unsigned where either will do.
2439 (tiff_handler): New function, combining the cores of the
2440 old tiff_error_handler and tiff_warning_handler.
2441 This function is rewritten to use vsnprintf and thereby avoid
2442 stack buffer overflows. It uses only the features of vsnprintf
2443 that are common to both POSIX and native Microsoft.
2444 (tiff_error_handler, tiff_warning_handler): Use it.
2445 (tiff_load, gif_load, imagemagick_load_image):
2446 Don't assume :index value fits in 'int'.
2447 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2448 (imagemagick_load_image): Check that crop parameters fit into
2449 the integer types that MagickCropImage accepts. Don't assume
2450 Vimagemagick_render_type has a nonnegative value. Don't assume
2451 size_t fits in 'long'.
2452 (gs_load): Use printmax_t to print the widest integers possible.
2453 Check for integer overflow when computing image height and width.
2454
2455 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2456
2457 * xdisp.c (redisplay_window): Don't force window start if point
2458 will be invisible in the resulting window. (Bug#9324)
2459
2460 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2461
2462 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2463 the display spec is of the form `(space ...)'.
2464 (handle_display_spec): Return the value returned by
2465 handle_single_display_spec, not just 1 or zero.
2466 (handle_single_display_spec): If the display spec is of the form
2467 `(space ...)', and specifies display in the text area, return 2
2468 rather than 1.
2469 (try_cursor_movement): Check for the need to scroll more
2470 accurately, and prefer exact match for point under bidi.
2471 Don't advance `row' beyond the last row of the window.
2472
2473 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2474 into disp_prop; all users changed.
2475
2476 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2477 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2478 for the text covered by the display property.
2479
2480 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2481
2482 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2483 Change return value to nil.
2484 (Frecord_buffer): Delete unused function.
2485
2486 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2487
2488 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2489 buffers, return left-to-right.
2490 (set_cursor_from_row): Consider candidate row a win if its glyph
2491 represents a newline and point is on that newline. Fixes cursor
2492 positioning on the newline at EOL of R2L text within L2R
2493 paragraph, and vice versa.
2494 (try_cursor_movement): Check continued rows, in addition to
2495 continuation rows. Fixes unwarranted scroll when point enters a
2496 continued line of R2L text within an L2R paragraph, or vice versa.
2497 (cursor_row_p): Consider the case of point being equal to
2498 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2499 from the end of a short line to the beginning of a continued line
2500 of R2L text within L2R paragraph.
2501 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2502 composed characters.
2503
2504 * bidi.c (bidi_check_type): Use xassert.
2505 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2506 members.
2507
2508 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2509
2510 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2511 a character.
2512
2513 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2514
2515 * nsfont.m (ns_otf_to_script): Fix typo.
2516
2517 2011-08-22 Kenichi Handa <handa@m17n.org>
2518
2519 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2520 extra slot even if the purpose is char-code-property-table.
2521
2522 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2523
2524 * xdisp.c (redisplay_window): When computing centering_position,
2525 account for the height of the header line. (Bug#8874)
2526
2527 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2528 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2529 candidate is selected by the mouse, and that candidate has a
2530 composed character under the mouse.
2531
2532 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2533 coordinates reported by pos-visible-in-window-p for a composed
2534 character in column zero.
2535
2536 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2537
2538 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2539
2540 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2541
2542 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2543 consider it a hit if to_charpos is anywhere in the range of the
2544 composed buffer positions.
2545
2546 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2547
2548 * image.c (gif_load): Don't assume that each subimage has the same
2549 dimensions as the base image. Handle disposal method that is
2550 "undefined" by the gif spec (Bug#9335).
2551
2552 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2553
2554 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2555 (Fcondition_case): Document `debug' symbol in error handler.
2556
2557 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2558
2559 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2560 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2561 from an Org mode buffer to a Speedbar frame.
2562
2563 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2564 a composition, take its buffer position from IT->cmp_it.charpos.
2565 Fixes cursor positioning at the beginning of a line that begins
2566 with a composed character.
2567
2568 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2569
2570 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2571 character bidirectional type, use STRONG_L instead. Fixes crashes
2572 in a buffer produced by `describe-categories'.
2573
2574 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2575 members before the level stack, so they would be saved and
2576 restored when copying iterator state. Fixes incorrect reordering
2577 around TABs covered by display properties.
2578
2579 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2580
2581 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2582
2583 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2584
2585 * eval.c (internal_condition_case, internal_condition_case_1)
2586 (internal_condition_case_2, internal_condition_case_n):
2587 Remove unnecessary aborts (Bug#9081).
2588
2589 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2590
2591 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2592 has no `load' handler, try opening the file locally. (Bug#9311)
2593
2594 2011-08-16 Ken Brown <kbrown@cornell.edu>
2595
2596 * gmalloc.c: Expand comment.
2597
2598 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2599
2600 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2601 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2602
2603 2011-08-16 Ken Brown <kbrown@cornell.edu>
2604
2605 Fix memory allocation problems in Cygwin build (Bug#9273).
2606
2607 * unexcw.c ( __malloc_initialized): Declare external variable.
2608 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2609
2610 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2611 New variables.
2612 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2613 dumped emacs.
2614 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2615 in the static heap.
2616 [CYGWIN] (special_realloc): New function.
2617 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2618 requests to realloc storage in the static heap.
2619
2620 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2621
2622 * bidi.c (bidi_initialize): Remove unused local.
2623
2624 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2625
2626 * bidimirror.h:
2627 * biditype.h: Remove file.
2628 * makefile.w32-in ($(BLD)/bidi.$(O)):
2629 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2630
2631 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2632
2633 * chartab.c: Improve commentary for the uniprop_table API.
2634
2635 * bidi.c (bidi_paragraph_init): Support zero value of
2636 bidi_ignore_explicit_marks_for_paragraph_level.
2637 (bidi_initialize): Use uniprop_table instead of including
2638 biditype.h and bidimirror.h.
2639
2640 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2641 coordinates of the iterator when restoring from ppos_it.
2642 (Bug#9296)
2643
2644 2011-08-14 Kenichi Handa <handa@m17n.org>
2645
2646 * process.c (create_process): Call setup_process_coding_systems
2647 after the pid of the process is set to -1 (Bug#8162).
2648
2649 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2650
2651 * xdisp.c (move_it_in_display_line_to): Don't invoke
2652 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2653 ppos_it. Fixes vertical cursor motion when line beginning is
2654 covered by an image. (Bug#9296)
2655
2656 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2657
2658 * nsterm.h (ns_run_ascript): Declare.
2659 (NSAPP_DATA2_RUNASSCRIPT): Define.
2660
2661 * nsfns.m (as_script, as_result, as_status): New static variables.
2662 (ns_run_ascript): New function.
2663 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2664 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2665 the event loop. Get status from as_status (Bug#7276).
2666
2667 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2668 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2669 the event loop (Bug#7276).
2670
2671 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2672
2673 * gnutls.c (QCgnutls_bootprop_priority)
2674 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2675 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2676 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2677 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2678 (QCgnutls_bootprop_verify_hostname_error)
2679 (QCgnutls_bootprop_callbacks_verify): Rename from
2680 Qgnutls_bootprop_..., all uses changed.
2681
2682 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2683 uses changed.
2684
2685 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2686
2687 * xfaces.c (Qframe_set_background_mode): Now static.
2688 * dispextern.h (Qframe_set_background_mode): Remove decl.
2689
2690 * process.c (Fnetwork_interface_info): Declare local only if needed.
2691
2692 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2693
2694 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2695 (Fnetwork_interface_list): Allocate in increments of bytes instead
2696 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2697 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2698 sockaddr.
2699 (struct ifflag_def): notrailers is smart on OSX.
2700 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2701 Get hardware address with getifaddrs if available.
2702
2703 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2704
2705 * xdisp.c (iterate_out_of_display_property): xassert that
2706 IT->position is set to within IT->object's boundaries. Break from
2707 the loop as soon as EOB is reached; avoids infloops in redisplay
2708 when IT->position is set up wrongly due to some bug.
2709 Set IT->current to match the bidi iterator unconditionally.
2710 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2711 entry. Force push_it to save on the stack the current
2712 buffer/string position, to be restored by pop_it. Fix flags in
2713 the iterator structure wrt the object coming from a display
2714 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2715 properties. (Bug#9284)
2716
2717 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2718
2719 * fontset.c (fontset_get_font_group): Add proper type checks.
2720 (Bug#9172)
2721
2722 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2723
2724 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2725 and LC_VERSION_MIN_MACOSX.
2726 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2727 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2728
2729 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2730
2731 * xdisp.c (forward_to_next_line_start): Allow to use the
2732 no-display-properties-and-no-overlays under bidi display.
2733 Set disp_pos in the bidi iterator to avoid searches for display
2734 properties and overlays.
2735
2736 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2737
2738 * editfns.c (Fset_time_zone_rule): Document relationship with the
2739 setenv function.
2740
2741 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2742 the font entity extracted from the cache (Bug#8109).
2743
2744 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2745
2746 * composite.c (autocmp_chars): Don't reset point. That is done by
2747 restore_point_unwind (Bug#5984).
2748
2749 2011-08-07 Juri Linkov <juri@jurta.org>
2750
2751 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2752 to show the arg `TIME' instead of `TIMEVAL'.
2753
2754 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2755
2756 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2757 display property strides EOL and includes a newline, as in
2758 longlines-mode. (Bug#9254)
2759 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2760 word-wrap under bidirectional display. (Bug#9224)
2761
2762 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2763 is non-zero, even if the data buffer is NULL. Fixes a crash in
2764 vertical-motion with longlines-mode. (Bug#9254)
2765
2766 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2767
2768 * bidi.c <bidi_cache_total_alloc>: Now static.
2769 (bidi_initialize): Initialize bidi_cache_total_alloc.
2770
2771 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2772 cache. (Bug#9221)
2773
2774 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2775 amount allocated this far in `bidi_cache_total_alloc'.
2776 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2777 non-zero, only free the data buffer without restoring the cache
2778 contents. All callers changed.
2779
2780 * dispextern.h (bidi_unshelve_cache): Update prototype.
2781
2782 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2783 (move_it_in_display_line, move_it_to)
2784 (move_it_vertically_backward, move_it_by_lines): Replace the call
2785 to xfree to an equivalent call to bidi_unshelve_cache.
2786 (move_it_in_display_line_to): Fix logic of returning
2787 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2788
2789 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2790
2791 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2792 came from a string character with a `cursor' property. (Bug#9229)
2793
2794 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2795
2796 * Makefile.in (LIB_PTHREAD): New variable.
2797 (LIBES): Add LIB_PTHREAD (Bug#9216).
2798
2799 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2800 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2801
2802 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2803
2804 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2805
2806 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2807
2808 * xterm.c (x_find_topmost_parent): New function.
2809 (x_set_frame_alpha): Find topmost parent window with
2810 x_find_topmost_parent and set the property there also (bug#9181).
2811 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2812
2813 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2814
2815 * callproc.c (Fcall_process): Avoid vfork clobbering
2816 the local vars buffer, coding_systems, current_dir.
2817
2818 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2819
2820 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2821
2822 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2823
2824 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2825 so that it is not optimized away.
2826
2827 * xdisp.c (compute_display_string_pos): Remove unused local.
2828
2829 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2830
2831 Fix slow cursor motion and scrolling in large buffers with
2832 selective display, like Org Mode buffers. (Bug#9218)
2833
2834 * dispextern.h (struct bidi_it): New member disp_prop_p.
2835
2836 * xdisp.c: Remove one-slot cache of display string positions.
2837 (compute_display_string_pos): Accept an additional argument
2838 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2839 for a display string or property. If found, set DISP_PROP_P
2840 non-zero.
2841
2842 * bidi.c (bidi_fetch_char): Accept an additional argument
2843 DISP_PROP_P, and pass it to compute_display_string_pos.
2844 Only handle text covered by a display string if DISP_PROP_P is returned
2845 non-zero. All callers of bidi_fetch_char changed.
2846
2847 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2848
2849 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2850
2851 2010-12-03 Don March <don@ohspite.net>
2852
2853 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2854 last character M-[char] is translated to ESC [char] (bug#7541).
2855
2856 2011-08-02 Kenichi Handa <handa@m17n.org>
2857
2858 * lisp.h (uniprop_table): Extern it.
2859
2860 * chartab.c (uniprop_table): Make it non-static.
2861
2862 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2863
2864 * xdisp.c (forward_to_next_line_start): Accept additional argument
2865 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2866 on the newline.
2867 (reseat_at_next_visible_line_start): Use the bidi iterator state
2868 returned by forward_to_next_line_start to restore the state of
2869 it->bidi_it after backing up to previous newline. (Bug#9212)
2870
2871 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2872
2873 * regex.c (re_comp): Protoize.
2874 (re_exec): Fix return type.
2875 (regexec): Fix type of `ret'. (Bug#9203)
2876
2877 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2878
2879 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2880 This is needed if max-image-size is a floating-point number.
2881
2882 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2883
2884 * print.c (print_object): Print empty symbol as ##.
2885
2886 * lread.c (read1): Read ## as empty symbol.
2887
2888 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2889
2890 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2891 setting frame foreground color (Bug#9175).
2892 (x_set_background_color): Likewise.
2893
2894 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2895 contents (Bug#9176).
2896 (EmacsTooltip -init): Remove bezels and add shadows to
2897 tooltip windows.
2898
2899 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2900 or scroll bar (Bug#8470).
2901
2902 * nsfont.m (nsfont_open): Remove assignment to voffset and
2903 unnecessary vars hshink, expand, hd, full_height, min_height.
2904 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2905
2906 * nsterm.h (nsfont_info): Remove voffset field.
2907
2908 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2909
2910 Implement strike-through and overline on NextStep (Bug#8863).
2911
2912 * nsfont.m (nsfont_open): Use underline position provided by font,
2913 instead of hard-coded value of 2.
2914 (nsfont_draw): Call ns_draw_text_decoration instead.
2915
2916 * nsterm.h: Add declaration for ns_draw_text_decoration.
2917
2918 * nsterm.m (ns_draw_text_decoration): New function for drawing
2919 underline, overline, and strike-through.
2920 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2921 ns_draw_text_decoration. Change treatment of cursor drawing to
2922 accommodate underlining, etc.
2923
2924 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2925
2926 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2927 default.
2928
2929 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2930
2931 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2932 Without this fix, if a signal arrives just after memory fills up,
2933 'malloc' might be invoked reentrantly.
2934
2935 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2936 In other words, assume that every image size is allowed, on non-X
2937 hosts. This assumption is probably wrong, but it lets Emacs compile.
2938
2939 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2940
2941 * regex.c (re_iswctype): Convert return values to boolean.
2942
2943 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2944
2945 * xdisp.c (compute_display_string_pos): Don't use cached display
2946 string position if the buffer had its restriction changed.
2947 (Bug#9184)
2948
2949 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2950
2951 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2952
2953 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2954
2955 Integer signedness and overflow and related fixes. (Bug#9079)
2956
2957 * bidi.c: Integer size and overflow fixes.
2958 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2959 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2960 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2961 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2962 (bidi_find_other_level_edge):
2963 Use ptrdiff_t instead of EMACS_INT where either will do.
2964 This works better on 32-bit hosts configured --with-wide-int.
2965 (bidi_cache_ensure_space): Check for size-calculation overflow.
2966 Use % rather than repeated addition, for better worst-case speed.
2967 Don't set bidi_cache_size until after xrealloc returns, because it
2968 might not return.
2969 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2970 (bidi_cache_ensure_space): Also check that the bidi cache size
2971 does not exceed that of the largest Lisp string or buffer. See Eli
2972 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2973
2974 * alloc.c (__malloc_size_t): Remove.
2975 All uses replaced by size_t. See Andreas Schwab's note
2976 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2977
2978 * image.c: Improve checking for integer overflow.
2979 (check_image_size): Assume that f is nonnull, since
2980 it is always nonnull in practice. This is one less thing to
2981 worry about when checking for integer overflow later.
2982 (x_check_image_size): New function, which checks for integer
2983 overflow issues inside X.
2984 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2985 This removes the need for a memory_full check.
2986 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2987 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2988 (xbm_read_bitmap_data): Change locals back to 'int', since
2989 their values must fit in 'int'.
2990 (xpm_load_image, png_load, tiff_load):
2991 Invoke x_create_x_image_and_pixmap earlier,
2992 to avoid much needless work if the image is too large.
2993 (tiff_load): Treat overly large images as if
2994 x_create_x_image_and_pixmap failed, not as malloc failures.
2995 (gs_load): Use x_check_image_size.
2996
2997 * gtkutil.c: Omit integer casts.
2998 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2999 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3000
3001 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3002
3003 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3004 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3005 would wrongly return t on a 64-bit host.
3006
3007 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3008 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3009 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3010 and therefore cause GCC to emit a bogus diagnostic in some cases.
3011
3012 * image.c: Integer signedness and overflow and related fixes.
3013 This is not an exhaustive set of fixes, but it's time to
3014 record what I've got.
3015 (lookup_pixel_color, check_image_size): Remove redundant decls.
3016 (check_image_size): Don't assume that arbitrary EMACS_INT values
3017 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3018 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3019 (tiff_load, imagemagick_load_image):
3020 Check for overflow in size calculations.
3021 (x_create_x_image_and_pixmap): Remove unnecessary test for
3022 xmalloc returning NULL; that can't happen.
3023 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3024 (xpm_color_bucket): Use better integer hashing function.
3025 (xpm_cache_color): Don't possibly over-allocate memory.
3026 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3027 (gif_memory_source):
3028 Use ptrdiff_t, not int or size_t, to record sizes.
3029 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3030 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3031 either works, as we prefer signed integers.
3032 (tiff_read_from_memory, tiff_write_from_memory):
3033 Return tsize_t, not size_t, since that's what the TIFF API wants.
3034 (tiff_read_from_memory): Don't fail simply because the read would
3035 go past EOF; instead, return a short read.
3036 (tiff_load): Omit no-longer-needed casts.
3037 (Fimagemagick_types): Don't assume size fits into 'int'.
3038
3039 Improve hashing quality when configured --with-wide-int.
3040 * fns.c (hash_string): New function, taken from sxhash_string.
3041 Do not discard information about ASCII character case; this
3042 discarding is no longer needed.
3043 (sxhash-string): Use it. Change sig to match it. Caller changed.
3044 * lisp.h: Declare it.
3045 * lread.c (hash_string): Remove, since we now use fns.c's version.
3046 The fns.c version returns a wider integer if --with-wide-int is
3047 specified, so this should help the quality of the hashing a bit.
3048
3049 * emacs.c: Integer overflow minor fix.
3050 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3051 Define only if GNU_LINUX.
3052 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3053
3054 * dispnew.c: Integer signedness and overflow fixes.
3055 Remove unnecessary forward decls, that were a maintenance hassle.
3056 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3057 All uses changed.
3058 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3059 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3060 (prepare_desired_row, line_draw_cost):
3061 Use int, not unsigned, where either works.
3062 (save_current_matrix, restore_current_matrix):
3063 Use ptrdiff_t, not size_t, where either works.
3064 (init_display): Check for overflow more accurately, and without
3065 relying on undefined behavior.
3066
3067 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3068 Remove, replacing with the new symbols in lisp.h. All uses changed.
3069 * fileio.c (make_temp_name):
3070 * filelock.c (lock_file_1, lock_file):
3071 * xdisp.c (message_dolog):
3072 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3073 Use pMd etc. instead.
3074 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3075 replacing the pWIDE etc. symbols removed from editfns.c.
3076
3077 * keyboard.h (num_input_events): Now uintmax_t.
3078 This is (very slightly) less likely to mess up due to wraparound.
3079 All uses changed.
3080
3081 * buffer.c: Integer signedness fixes.
3082 (alloc_buffer_text, enlarge_buffer_text):
3083 Use ptrdiff_t rather than size_t when either will do, as we prefer
3084 signed integers.
3085
3086 * alloc.c: Integer signedness and overflow fixes.
3087 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3088 (__malloc_size_t): Default to size_t, not to int.
3089 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3090 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3091 Prefer ptrdiff_t to size_t when either would do, as we prefer
3092 signed integers.
3093 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3094 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3095 Now const. Initialize with values that are in range even if char
3096 is signed.
3097 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3098 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3099 These functions do the right thing with sizes > 2**32.
3100 (check_depth): Now ptrdiff_t, not int.
3101 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3102 Adjust to new way of storing sizes. Check for size overflow bugs
3103 in rest of code.
3104 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3105 slightly wrong anyway, as it missed one instance of
3106 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3107 (refill_memory_reserve): Omit needless cast to size_t.
3108 (mark_object_loop_halt): Mark as externally visible.
3109
3110 * xselect.c: Integer signedness and overflow fixes.
3111 (Fx_register_dnd_atom, x_handle_dnd_message):
3112 Use ptrdiff_t, not size_t, since we prefer signed.
3113 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3114 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3115 x_dnd_atoms_size and x_dnd_atoms_length.
3116
3117 * doprnt.c: Prefer signed to unsigned when either works.
3118 * eval.c (verror):
3119 * doprnt.c (doprnt):
3120 * lisp.h (doprnt):
3121 * xdisp.c (vmessage):
3122 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3123 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3124 prefer signed arithmetic to avoid comparison confusion.
3125 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3126 but is a bit tricky.
3127
3128 Assume freestanding C89 headers, string.h, stdlib.h.
3129 * data.c, doprnt.c, floatfns.c, print.c:
3130 Include float.h unconditionally.
3131 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3132 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3133 * regex.c: Likewise for stddef.h, string.h.
3134 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3135 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3136 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3137 (STDC_HEADERS): Remove obsolete defines.
3138 * sysdep.c: Include limits.h unconditionally.
3139
3140 Assume support for memcmp, memcpy, memmove, memset.
3141 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3142 * regex.c (memcmp, memcpy):
3143 Remove; we assume C89 now.
3144
3145 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3146 (__malloc_safe_bcopy): Remove; no longer needed.
3147
3148 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3149 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3150 well either way, and we prefer signed to unsigned.
3151
3152 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3153
3154 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3155 closes the connection while we're reading (bug#9182).
3156
3157 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3158
3159 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3160 are specified (Bug#9168).
3161
3162 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3163
3164 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3165 Found by GCC static checking and --with-wide-int on a 32-bit host.
3166
3167 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3168
3169 * xdisp.c (compute_display_string_pos): Fix logic of caching
3170 previous display string position. Initialize cached_prev_pos to
3171 -1. Fixes slow-down at the beginning of a buffer.
3172
3173 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3174
3175 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3176 for attrs[LFACE_FONTSET_INDEX].
3177
3178 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3179
3180 * xml.c (parse_region): Remove unused local
3181 that was recently introduced.
3182
3183 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3184
3185 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3186 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3187
3188 * xdisp.c (move_it_in_display_line_to): Record the best matching
3189 position for TO_CHARPOS while scanning the line, and restore it on
3190 exit if none of the characters scanned was an exact match.
3191 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3192 when exact match is impossible due to invisible text, and the
3193 lines are truncated.
3194
3195 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3196
3197 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3198 for OSX >= 10.7.
3199
3200 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3201
3202 Fix a significant slow-down of cursor motion with C-n, C-p,
3203 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3204 auto-repeat under bidi redisplay in fontified buffers.
3205 * xdisp.c (compute_stop_pos_backwards): New function.
3206 (next_element_from_buffer): Call compute_stop_pos_backwards to
3207 find a suitable prev_stop when we find ourselves before
3208 base_level_stop.
3209 (reseat): Don't look for prev_stop, as that could mean a very long
3210 run.
3211 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3212 <cached_disp_overlay_modiff>: Cache for last found display string
3213 position.
3214 (compute_display_string_pos): Return the cached position if asked
3215 about the same buffer in the same area of character positions, and
3216 the buffer wasn't changed since the time the display string
3217 position was cached.
3218
3219 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3220
3221 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3222 is an integer, which is important for empty lines. (Bug#9149)
3223
3224 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3225
3226 * frame.c (Fmodify_frame_parameters): In tty case, update the
3227 default face if necessary (Bug#4238).
3228
3229 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3230
3231 * editfns.c (Fstring_to_char): No need to explain what a character
3232 is in the docstring (Bug#6576).
3233
3234 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3235
3236 * xml.c (parse_region): Make sure we always return a tree.
3237
3238 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3239
3240 * xml.c (parse_region): If a document contains only comments,
3241 return that, too.
3242
3243 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3244
3245 * xml.c (make_dom): Return comments, too.
3246
3247 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3248
3249 Port to OpenBSD.
3250 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3251 and the surrounding thread.
3252 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3253 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3254 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3255 timer goes off.
3256 * s/openbsd.h (BROKEN_SIGIO): Define.
3257 * unexelf.c (unexec) [__OpenBSD__]:
3258 Don't update the .mdebug section of the Alpha COFF symbol table.
3259
3260 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3261
3262 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3263 (bug#8460).
3264
3265 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3266
3267 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3268 This fixes some race conditions on the permissions of any newly
3269 created file.
3270
3271 * alloc.c (valid_pointer_p): Use pipe, not open.
3272 This fixes some permissions issues when debugging.
3273
3274 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3275 If fchown fails to set both uid and gid, try to set just gid,
3276 as that is sometimes allowed. Adjust the file's mode to eliminate
3277 setuid or setgid bits that are inappropriate if fchown fails.
3278
3279 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3280
3281 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3282 to compare Lisp_Objects.
3283 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3284 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3285 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3286
3287 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3288
3289 * lread.c (read_integer): Unread even EOF character.
3290 (read1): Likewise. Properly record start position of symbol.
3291
3292 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3293 symbol character follows.
3294
3295 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3296
3297 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3298 This works around a problem with the previous change to Fcopy_file.
3299 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3300 and without this change, GCC might complain about discarding
3301 fchown's return value.
3302
3303 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3304
3305 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3306
3307 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3308
3309 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3310
3311 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3312
3313 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3314 it's used from the C level.
3315
3316 * process.c: Use the same condition for POLL_FOR_INPUT in both
3317 keyboard.c and process.c (bug#1858).
3318
3319 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3320
3321 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3322 (Fgnutls_boot): Use it.
3323
3324 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3325
3326 * doc.c (Fsubstitute_command_keys): Revert last change.
3327
3328 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3329
3330 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3331 quotes the next character, and doesn't affect other longer
3332 sequences (bug#8935).
3333
3334 * lread.c (syms_of_lread): Clarify that is isn't only
3335 `eval-buffer' and `eval-defun' that's affected by
3336 `lexical-binding' (bug#8460).
3337
3338 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3339
3340 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3341 bidi redisplay when a line includes both an image and is truncated.
3342
3343 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 Fix minor problems found by static checking.
3346 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3347 (elsz): Now a signed constant, not a size_t var. We prefer signed
3348 types to unsigned, to avoid integer comparison confusion. Without
3349 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3350 "cannot optimize loop, the loop counter may overflow", a symptom
3351 of the confusion.
3352 * indent.c (Fvertical_motion): Mark locals as initialized.
3353 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3354
3355 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3356
3357 * search.c (Fre_search_backward): Mention `case-fold-search' in
3358 all the re_search_* functions (bug#8138).
3359
3360 * keyboard.c (Fopen_dribble_file): Document when the file is
3361 closed (bug#8056).
3362
3363 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3364
3365 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3366 bidi_cache_idx.
3367
3368 Support bidi reordering of display and overlay strings.
3369 * xdisp.c (compute_display_string_pos)
3370 (compute_display_string_end): Accept additional argument STRING.
3371 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3372 (reseat_to_string): Initialize bidi_it->string.s and
3373 bidi_it->string.schars.
3374 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3375 NULL (avoids a crash in bidi_paragraph_init).
3376 Initialize itb.string.lstring.
3377 (init_iterator): Call bidi_init_it only of a valid
3378 buffer position was specified. Initialize paragraph_embedding to
3379 L2R.
3380 (reseat_to_string): Initialize the bidi iterator.
3381 (display_string): If we need to ignore text properties of
3382 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3383 original value of -1 will not work with bidi.)
3384 (compute_display_string_pos): First arg is now struct
3385 `text_pos *'; all callers changed. Support display properties on
3386 Lisp strings.
3387 (compute_display_string_end): Support display properties on Lisp
3388 strings.
3389 (init_iterator, reseat_1, reseat_to_string): Initialize the
3390 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3391 when iterating on a string not from display properties).
3392 (compute_display_string_pos, compute_display_string_end):
3393 Fix calculation of the object to scan. Fixes an error when using
3394 arrow keys.
3395 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3396 base_level_stop; instead, set base_level_stop to BEGV.
3397 Fixes crashes in vertical-motion.
3398 (next_element_from_buffer): Improve commentary for when
3399 the iterator is before prev_stop.
3400 (init_iterator): Initialize bidi_p from the default value of
3401 bidi-display-reordering, not from buffer-local value. Use the
3402 buffer-local value only if initializing for buffer iteration.
3403 (handle_invisible_prop): Support invisible properties on strings
3404 that are being bidi-reordered.
3405 (set_iterator_to_next): Support bidi reordering of C strings and
3406 Lisp strings.
3407 (next_element_from_string): Support bidi reordering of Lisp
3408 strings.
3409 (handle_stop_backwards): Support Lisp strings as well.
3410 (display_string): Support display of R2L glyph rows.
3411 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3412 (init_iterator): Don't initialize it->bidi_p for strings
3413 here.
3414 (reseat_to_string): Initialize it->bidi_p for strings here.
3415 (next_element_from_string, next_element_from_c_string)
3416 (next_element_from_buffer): Add xassert's for correspondence
3417 between IT's object being iterated and it->bidi_it.string
3418 structure.
3419 (face_before_or_after_it_pos): Support bidi iteration.
3420 (next_element_from_c_string): Handle the case of the first string
3421 character that is not the first one in the visual order.
3422 (get_visually_first_element): New function, refactored from common
3423 parts of next_element_from_buffer, next_element_from_string, and
3424 next_element_from_c_string.
3425 (tool_bar_lines_needed, redisplay_tool_bar)
3426 (display_menu_bar): Force left-to-right direction. Add a FIXME
3427 comment for making that be controlled by a user option.
3428 (push_it, pop_it): Save and restore the state of the
3429 bidi iterator. Save and restore the bidi_p flag.
3430 (pop_it): Iterate out of display property for string iteration as
3431 well.
3432 (iterate_out_of_display_property): Support iteration over strings.
3433 (handle_single_display_spec): Set up it->bidi_it for iteration
3434 over a display string, and call bidi_init_it.
3435 (handle_single_display_spec, next_overlay_string)
3436 (get_overlay_strings_1, push_display_prop): Set up the bidi
3437 iterator for displaying display or overlay strings.
3438 (forward_to_next_line_start): Don't use the shortcut if
3439 bidi-iterating.
3440 (back_to_previous_visible_line_start): If handle_display_prop
3441 pushed the iterator stack, restore the internal state of the bidi
3442 iterator by calling bidi_pop_it same number of times.
3443 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3444 and we are bidi-iterating, don't decrement the iterator position;
3445 instead, set the first_elt flag in the bidi iterator, to produce
3446 the same effect.
3447 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3448 (push_display_prop): xassert that we are iterating a buffer.
3449 (push_it, pop_it): Save and restore paragraph_embedding member.
3450 (handle_single_display_spec, next_overlay_string)
3451 (get_overlay_strings_1, reseat_1, reseat_to_string)
3452 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3453 correctly. Don't assume unibyte strings are not bidi-reordered.
3454 (compute_display_string_pos)
3455 (compute_display_string_end): Fix handling the case of C string.
3456 (push_it, pop_it): Save and restore from_disp_prop_p.
3457 (handle_single_display_spec, push_display_prop): Set the
3458 from_disp_prop_p flag.
3459 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3460 (pop_it): Call iterate_out_of_display_property only if we are
3461 popping after iteration over a string that came from a display
3462 property. Fix a typo in popping stretch info. Add an assertion
3463 for verifying that the iterator position is in sync with the bidi
3464 iterator.
3465 (handle_single_display_spec, get_overlay_strings_1)
3466 (push_display_prop): Fix initialization of paragraph direction for
3467 string when that of the parent object is not yet determined.
3468 (reseat_1): Call bidi_init_it to resync the bidi
3469 iterator with IT's position. (Bug#7616)
3470 (find_row_edges): If ROW->start.pos gives position
3471 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3472 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3473 Reset the from_disp_prop_p flag.
3474 (SAVE_IT, RESTORE_IT): New macros.
3475 (pos_visible_p, face_before_or_after_it_pos)
3476 (back_to_previous_visible_line_start)
3477 (move_it_in_display_line_to, move_it_in_display_line)
3478 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3479 (try_scrolling, redisplay_window, display_line): Use them when
3480 saving a temporary copy of the iterator and restoring it back.
3481 (back_to_previous_visible_line_start, reseat_1)
3482 (init_iterator): Empty the bidi cache "stack".
3483 (move_it_in_display_line_to): If iterator ended up at
3484 EOL, but we never saw any buffer positions smaller than
3485 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3486 motion in bidi-reordered lines.
3487 (move_it_in_display_line_to): Record prev_method and prev_pos
3488 immediately before the call to set_iterator_to_next. Fixes cursor
3489 motion in bidi-reordered lines with stretch glyphs and strings
3490 displayed in margins. (Bug#8133) (Bug#8867)
3491 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3492 TO_CHARPOS.
3493 (pos_visible_p): Support positions in bidi-reordered lines.
3494 Save and restore bidi cache.
3495
3496 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3497 (bidi_paragraph_info): Delete unused struct.
3498 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3499 (bidi_cache_start): New variable.
3500 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3501 to zero.
3502 (bidi_cache_fetch_state, bidi_cache_search)
3503 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3504 (bidi_cache_find, bidi_peek_at_next_level)
3505 (bidi_level_of_next_char, bidi_find_other_level_edge)
3506 (bidi_move_to_visually_next): Compare cache index with
3507 bidi_cache_start rather than with zero.
3508 (bidi_fetch_char): Accept new argument STRING; all callers
3509 changed. Support iteration over a string. Support strings with
3510 display properties. Support unibyte strings. Fix the type of
3511 `len' according to what STRING_CHAR_AND_LENGTH expects.
3512 (bidi_paragraph_init, bidi_resolve_explicit_1)
3513 (bidi_resolve_explicit, bidi_resolve_weak)
3514 (bidi_level_of_next_char, bidi_move_to_visually_next):
3515 Support iteration over a string.
3516 (bidi_set_sor_type, bidi_resolve_explicit_1)
3517 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3518 can now be zero (for strings); special values 0 and -1 were
3519 changed to -1 and -2, respectively.
3520 (bidi_char_at_pos): New function.
3521 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3522 Call it instead of FETCH_MULTIBYTE_CHAR.
3523 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3524 initialized to valid values.
3525 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3526 values.
3527 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3528 the test for valid cached positions. Fix the logic for looking up
3529 the sentinel state in the cache. GCPRO the Lisp string we are
3530 iterating.
3531 (bidi_push_it, bidi_pop_it): New functions.
3532 (bidi_initialize): Initialize the bidi cache start stack pointer.
3533 (bidi_cache_ensure_space): New function, refactored from part of
3534 bidi_cache_iterator_state. Don't assume the required size is just
3535 one BIDI_CACHE_CHUNK away.
3536 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3537 (bidi_count_bytes, bidi_char_at_pos): New functions.
3538 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3539 always valid if bidi_cache_idx is valid.
3540 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3541 is valid if it's going to be used.
3542 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3543 (bidi_cache_fetch_state, bidi_cache_search)
3544 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3545 (bidi_cache_iterator_state, bidi_cache_find)
3546 (bidi_find_other_level_edge, bidi_cache_start_stack):
3547 All variables related to cache indices are now EMACS_INT.
3548
3549 * dispextern.h (struct bidi_string_data): New structure.
3550 (struct bidi_it): New member `string'. Make flag members be 1-bit
3551 fields, and put them last in the struct.
3552 (compute_display_string_pos, compute_display_string_end):
3553 Update prototypes.
3554 (bidi_push_it, bidi_pop_it): Add prototypes.
3555 (struct iterator_stack_entry): New members bidi_p,
3556 paragraph_embedding, and from_disp_prop_p.
3557 (struct it): Member bidi_p is now a bit field 1 bit wide.
3558 (bidi_shelve_cache, bidi_unshelve_cache):
3559 Declare prototypes.
3560
3561 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3562 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3563 and vector-like objects.
3564
3565 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3566 cache around display iteration.
3567
3568 * window.c (Fwindow_end, window_scroll_pixel_based)
3569 (displayed_window_lines, Frecenter): Save and restore the bidi
3570 cache around display iteration.
3571
3572 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3573
3574 * editfns.c (Fdelete_region): Clarify the use of the named
3575 parameters (bug#6788).
3576
3577 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3578
3579 * indent.c (Fvertical_motion): Set and restore w->pointm when
3580 saving and restoring the window's buffer (Bug#9006).
3581
3582 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3583
3584 * editfns.c (Fstring_to_char): Clarify just what is returned
3585 (bug#6576). Text by Eli Zaretskii.
3586
3587 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3588
3589 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3590
3591 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3592
3593 * buffer.c (mmap_find): Fix a typo.
3594
3595 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3596
3597 Fix execution of x selection hooks.
3598 * xselect.c (Qx_lost_selection_functions)
3599 (Qx_sent_selection_functions): New vars.
3600 (syms_of_xselect): DEFSYM them.
3601 (x_handle_selection_request): Pass Qx_sent_selection_functions
3602 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3603 (x_handle_selection_clear,x_clear_frame_selections):
3604 Pass Qx_lost_selection_functions rather than
3605 Vx_lost_selection_functions to Frun_hook_with_args.
3606
3607 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3608
3609 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3610 The old code sometimes used this field without initializing it.
3611
3612 * alloc.c (gc_sweep): Don't read past end of array.
3613 In theory, the old code could also have corrupted Emacs internals,
3614 though it'd be very unlikely.
3615
3616 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3617
3618 * character.c (Fcharacterp): Don't advertise optional ignored
3619 argument. (Bug#4026)
3620
3621 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3622
3623 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3624 key" (bug#4257).
3625
3626 * window.c (Fset_window_start): Doc fix (bug#4199).
3627 (Fset_window_hscroll): Ditto.
3628
3629 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3630
3631 Fix minor new problems caught by GCC 4.6.1.
3632 * term.c (init_tty): Remove unused local.
3633 * xsettings.c (store_monospaced_changed): Define this function only
3634 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3635 not used otherwise.
3636
3637 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3638
3639 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3640
3641 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3642
3643 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3644 are the mini-buffer and the echo area (bug#3320).
3645
3646 * term.c (init_tty): Remove support for supdup, c10 and perq
3647 terminals, which are no longer supported (bug#1482).
3648
3649 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3650
3651 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3652
3653 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3654
3655 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3656 for non-popups (Bug#3642).
3657
3658 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3659
3660 * alloc.c (reset_malloc_hooks): Protoize.
3661 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3662 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3663 * cm.c (losecursor): Likewise.
3664 * data.c (fmod): Likewise.
3665 * dispnew.c (swap_glyphs_in_rows): Likewise.
3666 * emacs.c (memory_warning_signal): Likewise.
3667 * floatfns.c (float_error): Likewise.
3668 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3669 (otf_open, font_otf_capability, generate_otf_features)
3670 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3671 Likewise.
3672 * image.c (pbm_read_file): Likewise.
3673 * indent.c (string_display_width): Likewise.
3674 * intervals.c (check_for_interval, search_for_interval)
3675 (inc_interval_count, count_intervals, root_interval)
3676 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3677 * lread.c (defalias): Likewise.
3678 * ralloc.c (r_alloc_check): Likewise.
3679 * regex.c (set_image_of_range_1, set_image_of_range)
3680 (regex_grow_registers): Likewise.
3681 * sysdep.c (strerror): Likewise.
3682 * termcap.c (valid_filename_p, tprint, main): Likewise.
3683 * tparam.c (main): Likewise.
3684 * unexhp9k800.c (run_time_remap, save_data_space)
3685 (update_file_ptrs, read_header, write_header, calculate_checksum)
3686 (copy_file, copy_rest, display_header): Likewise.
3687 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3688 Likewise.
3689 * xdisp.c (check_it): Likewise.
3690 * xfaces.c (register_color, unregister_color, unregister_colors):
3691 Likewise.
3692 * xfns.c (print_fontset_result): Likewise.
3693 * xrdb.c (member, fatal, main): Likewise.
3694
3695 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3696
3697 Fix minor problems found by static checking (Bug#9031).
3698 * chartab.c (char_table_set_range, map_sub_char_table):
3699 Remove unused locals.
3700 (uniprop_table): Now static.
3701 * composite.c (_work_char): Remove unused static var.
3702
3703 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3704
3705 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3706
3707 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3708
3709 * gtkutil.c (qttip_cb): Remove code without function.
3710
3711 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3712
3713 * w32.c (pthread_sigmask): New stub.
3714
3715 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3716
3717 Use pthread_sigmask, not sigprocmask (Bug#9010).
3718 sigprocmask is portable only for single-threaded applications, and
3719 Emacs can be multi-threaded when it uses GTK.
3720 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3721 (LIBES): Use it.
3722 * callproc.c (Fcall_process):
3723 * process.c (create_process):
3724 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3725 Use pthread_sigmask, not sigprocmask.
3726
3727 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3728
3729 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3730 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3731 wrong (Bug#8591).
3732
3733 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3734
3735 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3736 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3737 (xg_hide_tooltip): Fix comment.
3738
3739 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3740 in registerServicesMenuSendTypes.
3741 (validRequestorForSendType): Don't check ns_return_types.
3742
3743 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3744 ns_return_type.
3745
3746 2011-07-08 Jason Rumney <jasonr@gnu.org>
3747
3748 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3749 SH_SHOW for hidden windows (Bug#5482).
3750
3751 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3752 frame struct members of non-existent frames (Bug#6284).
3753
3754 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3755
3756 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3757 variable firstTime not needed on OSX >= 10.6.
3758 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3759 >= 10.5. Use setKnobProportion, setDoubleValue.
3760
3761 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3762 (MAC_OS_X_VERSION_10_5): Define if not defined.
3763 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3764 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3765 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3766
3767 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3768 cString and lossyCString on OSX >= 10.4
3769
3770 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3771 sizeToFit on OSX >= 10.2.
3772
3773 * nsimage.m (allocInitFromFile): Don't use deprecated method
3774 bestRepresentationForDevice on OSX >= 10.6.
3775
3776 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3777 to avoid warning.
3778
3779 * emacs.c: Declare unexec_init_emacs_zone.
3780
3781 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3782
3783 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3784
3785 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3786 on svcsMenu (Bug#8842).
3787
3788 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3789 ns_return_types.
3790 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3791
3792 * nsterm.m (QUTF8_STRING): Declare.
3793 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3794 (validRequestorForSendType): Return type is (id).
3795 Change indexOfObjectIdenticalTo to indexOfObject.
3796 Check if we have local selection before returning self (Bug#8842).
3797 (writeSelectionToPasteboard): Put local selection into paste board
3798 if we have a local selection (Bug#8842).
3799 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3800
3801 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3802 (ns_get_local_selection): Declare.
3803
3804 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3805
3806 * keymap.c (describe_map_tree): Don't insert a double newline at
3807 the end of the buffer (bug#1169) and return whether we inserted
3808 something.
3809
3810 * callint.c (Fcall_interactively): Change "reading args" to
3811 "providing args" to try to clarify what it does (bug#1010).
3812
3813 2011-07-07 Kenichi Handa <handa@m17n.org>
3814
3815 * composite.c (composition_compute_stop_pos): Ignore a static
3816 composition starting before CHARPOS (Bug#8915).
3817
3818 * xdisp.c (handle_composition_prop): Likewise.
3819
3820 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3821
3822 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3823 (Bug#9015)
3824
3825 2011-07-07 Kenichi Handa <handa@m17n.org>
3826
3827 * character.h (unicode_category_t): New enum type.
3828
3829 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3830 (Qchar_code_property_table): New variable.
3831 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3832 (UNIPROP_COMPRESSED_FORM_P): New macros.
3833 (char_table_ascii): Uncompress the compressed values.
3834 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3835 Uncompress the compressed values.
3836 (sub_char_table_ref_and_range): Likewise.
3837 (char_table_ref_and_range): Uncompress the compressed values.
3838 (sub_char_table_set): New arg is_uniprop. Callers changed.
3839 Uncompress the compressed values.
3840 (sub_char_table_set_range): Args changed. Callers changed.
3841 (char_table_set_range): Adjuted for the above change.
3842 (map_sub_char_table): Delete args default_val and parent. Add arg
3843 top. Give decoded values to a Lisp function.
3844 (map_char_table): Adjust for the above change. Give decoded
3845 values to a Lisp function. Gcpro more variables.
3846 (uniprop_table_uncompress)
3847 (uniprop_decode_value_run_length): New functions.
3848 (uniprop_decoder, uniprop_decoder_count): New variables.
3849 (uniprop_get_decoder, uniprop_encode_value_character)
3850 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3851 New functions.
3852 (uniprop_encoder, uniprop_encoder_count): New variables.
3853 (uniprop_get_encoder, uniprop_table)
3854 (Funicode_property_table_internal, Fget_unicode_property_internal)
3855 (Fput_unicode_property_internal): New functions.
3856 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3857 Sunicode_property_table_internal, Sget_unicode_property_internal,
3858 and Sput_unicode_property_internal. Defvar_lisp
3859 char-code-property-alist.
3860
3861 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3862 Vunicode_category_table.
3863
3864 * font.c (font_range): Adjust for the change of
3865 Vunicode_category_table.
3866
3867 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3868
3869 * m/iris4d.h: Remove file, move contents ...
3870 * s/irix6-5.h: ... here.
3871
3872 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3873
3874 Remove unportable assumption about struct layout (Bug#8884).
3875 * alloc.c (mark_buffer):
3876 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3877 (clone_per_buffer_values): Don't assume that
3878 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3879 This isn't true in general, and it's particularly not true
3880 if Emacs is configured with --with-wide-int.
3881 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3882 New macros, used in the buffer.c change.
3883
3884 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3885
3886 * xsettings.c: Use both GConf and GSettings if both are available.
3887 (store_config_changed_event): Add comment.
3888 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3889 (store_tool_bar_style_changed): New functions.
3890 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3891 (struct xsettings): Move font inside HAVE_XFT.
3892 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3893 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3894 Move inside HAVE_XFT.
3895 (something_changed_gsettingsCB): Rename from something_changedCB.
3896 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3897 also.
3898 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3899 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3900 (something_changed_gconfCB): Rename from something_changedCB.
3901 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3902 (parse_settings): Move check for font inside HAVE_XFT.
3903 (read_settings, apply_xft_settings): Add comment.
3904 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3905 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3906 call store_font_name_changed.
3907 (xft_settings_event): Add comment.
3908 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3909 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3910 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3911 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3912 (xsettings_initialize): Call init_gsettings last.
3913 (xsettings_get_system_font, xsettings_get_system_normal_font):
3914 Add comment.
3915
3916 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3917
3918 Random fixes. E.g., (random) never returned negative values.
3919 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3920 subseconds part to the entropy, as that's a bit more random.
3921 Prefer signed to unsigned, since the signedness doesn't matter and
3922 in general we prefer signed. When given a limit, use a
3923 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3924 latter isn't right if USE_2_TAGS_FOR_INTS.
3925 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3926 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3927
3928 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3929
3930 * textprop.c (text_property_stickiness):
3931 Obey Vtext_property_default_nonsticky.
3932 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3933 * w32fns.c (syms_of_w32fns):
3934 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3935
3936 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3937
3938 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3939 This is more efficient than Ffile_directory_p and avoids a minor race.
3940
3941 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3942
3943 * buffer.c (Foverlay_put): Say what the return value is
3944 (bug#7835).
3945
3946 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3947 is a directory before asking whether to use the file name
3948 (bug#7564).
3949 (barf_or_query_if_file_exists): Make the "File is a directory"
3950 error be more correct.
3951
3952 * fns.c (Frequire): Remove the mention of the .gz files, since
3953 that's installation-specific, but keep the mention of
3954 `get-load-suffixes'.
3955
3956 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3959 Report string overflow if the output is too long.
3960
3961 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3962
3963 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3964 (syms_of_gnutls): Remove duplicate DEFSYM for
3965 Qgnutls_bootprop_verify_hostname_error, an error for
3966 Qgnutls_bootprop_verify_error (which is no longer used).
3967
3968 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3969 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3970 Also (re)move comments that are misplaced or no longer relevant.
3971
3972 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3973
3974 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3975
3976 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3977
3978 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3979 and background color parameters if they have been changed.
3980
3981 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3982
3983 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3984
3985 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3986
3987 * xsettings.c (SYSTEM_FONT): Define only when used.
3988 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3989
3990 * keymap.c (access_keymap_1): Now static.
3991
3992 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3993
3994 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3995 leave any prefix arg for the up event (Bug#1586).
3996
3997 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3998
3999 * lread.c (syms_of_lread): Mention single symbols defined by
4000 `defvar' or `defconst' (bug#7154).
4001
4002 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4003 (Frequire): Mention get-load-suffixes.
4004
4005 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4006
4007 * window.h (window): Remove clone_number slot.
4008 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4009 Remove.
4010 (make_parent_window, make_window, saved_window)
4011 (Fset_window_configuration, save_window_save): Don't deal with
4012 clone numbers.
4013 * buffer.c (Qclone_number): Remove declaration.
4014 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4015
4016 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4017
4018 Add multiple inheritance to keymaps.
4019 * keymap.c (Fmake_composed_keymap): New function.
4020 (Fset_keymap_parent): Simplify.
4021 (fix_submap_inheritance): Remove.
4022 (access_keymap_1): New function extracted from access_keymap to handle
4023 embedded parents and handle lists of maps.
4024 (access_keymap): Use it.
4025 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4026 (Fcopy_keymap): Handle embedded parents.
4027 (Fcommand_remapping, define_as_prefix): Simplify.
4028 (Fkey_binding): Simplify.
4029 (syms_of_keymap): Move minibuffer-local-completion-map,
4030 minibuffer-local-filename-completion-map,
4031 minibuffer-local-must-match-map, and
4032 minibuffer-local-filename-must-match-map to Elisp.
4033 (syms_of_keymap): Defsubr make-composed-keymap.
4034 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4035 (parse_menu_item): Trivial simplification.
4036
4037 2011-07-01 Glenn Morris <rgm@gnu.org>
4038
4039 * Makefile.in (SETTINGS_LIBS): Fix typo.
4040
4041 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4042
4043 * coding.c (Fencode_coding_string): Record the last coding system
4044 used, as the function doc string says (bug#8738).
4045
4046 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4047
4048 * xsettings.c (store_monospaced_changed): Take new font as arg and
4049 check for change against current_mono_font.
4050 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4051 (emacs_settings_constructor, emacs_settings_get_property)
4052 (emacs_settings_set_property, emacs_settings_class_init)
4053 (emacs_settings_init, gsettings_obj): Remove.
4054 (something_changedCB): New function for HAVE_GSETTINGS.
4055 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4056 with value as argument.
4057 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4058 g_settings_new (Bug#8967). Do not create gsettings_obj.
4059 Remove calls to g_settings_bind. Connect something_changedCB to
4060 "changed".
4061
4062 * xgselect.c: Add defined (HAVE_GSETTINGS).
4063 (xgselect_initialize): Ditto.
4064
4065 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4066 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4067 xg_select.
4068
4069 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4070
4071 * eval.c (struct backtrace): Simplify and port the data structure.
4072 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4073 signed bit field, as this assumption is not portable and it makes
4074 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4075 "char debug_on_exit : 1" as this is not portable either; instead,
4076 use the portable "unsigned int debug_on_exit : 1". Remove unused
4077 member evalargs. Remove obsolete comments about cc bombing out.
4078
4079 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4080
4081 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4082 Let HAVE_GSETTINGS override HAVE_GCONF.
4083 (store_monospaced_changed): New function.
4084 (EMACS_SETTINGS): A new type derived from GObject to handle
4085 GSettings notifications.
4086 (emacs_settings_constructor, emacs_settings_get_property)
4087 (emacs_settings_set_property, emacs_settings_class_init):
4088 New functions.
4089 (gsettings_client, gsettings_obj): New variables.
4090 (GSETTINGS_SCHEMA): New define.
4091 (something_changedCB): Call store_monospaced_changed.
4092 (init_gsettings): New function.
4093 (xsettings_initialize): Call init_gsettings.
4094 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4095 to NULL.
4096
4097 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4098 GCONF_CFLAGS/LIBS.
4099
4100 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4101
4102 * window.c (resize_root_window, grow_mini_window)
4103 (shrink_mini_window): Rename Qresize_root_window to
4104 Qwindow_resize_root_window and Qresize_root_window_vertically to
4105 Qwindow_resize_root_window_vertically.
4106
4107 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4108
4109 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4110
4111 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4112
4113 * makefile.w32-in: Redesign dependencies so they reflect more
4114 clearly which files are directly included by each source file,
4115 and not through other includes.
4116
4117 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4118
4119 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4120 (sort_overlays, overlay_strings): When an overlay's clone number
4121 matches the window's clone number process the overlay even if
4122 the overlay's window property doesn't match the current window.
4123
4124 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4125 (Fwindow_hchild): Rename to Fwindow_left_child.
4126 (Fwindow_next): Rename to Fwindow_next_sibling.
4127 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4128 (resize_window_check): Rename to window_resize_check.
4129 (resize_window_apply): Rename to window_resize_apply.
4130 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4131 (Fdelete_other_windows_internal, resize_frame_windows)
4132 (Fsplit_window_internal, Fdelete_window_internal)
4133 (grow_mini_window, shrink_mini_window)
4134 (Fresize_mini_window_internal): Fix callers accordingly.
4135
4136 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4137
4138 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4139 (emacs_fixed_set_min_size): Remove.
4140 (emacs_fixed_new): Take frame as argument.
4141
4142 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4143 (_EmacsFixedPrivate): Remove minwidth/height.
4144 Add struct frame *f.
4145 (emacs_fixed_init): Initialize priv->f.
4146 (get_parent_class, emacs_fixed_set_min_size): Remove.
4147 (emacs_fixed_new): Set priv->f to argument.
4148 (emacs_fixed_get_preferred_width)
4149 (emacs_fixed_get_preferred_height): Use min_width/height from
4150 frames size_hint to set minimum and natural (Bug#8919).
4151 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4152 and use min_width/height from frames size_hint to set
4153 min_width/height (Bug#8919).
4154
4155 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4156 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4157 Fix indentation.
4158
4159 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4160
4161 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4162 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4163 called at ZV.
4164
4165 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4166
4167 * process.c (wait_reading_process_output): Bypass select if
4168 waiting for a cell while ignoring keyboard input, and input is
4169 pending. Suggested by Jan Djärv (Bug#8869).
4170
4171 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4172
4173 Use gnulib's dup2 module instead of rolling our own.
4174 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4175
4176 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4177
4178 * dispnew.c (scrolling_window): Before scrolling, turn off a
4179 mouse-highlight in the window being scrolled.
4180
4181 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4182
4183 Move DEFSYM to lisp.h and use everywhere.
4184
4185 * character.h (DEFSYM): Move declaration...
4186 * lisp.h (DEFSYM): ...here.
4187
4188 * gnutls.c:
4189 * minibuf.c:
4190 * w32menu.c:
4191 * w32proc.c:
4192 * w32select.c: Don't include character.h.
4193
4194 * alloc.c (syms_of_alloc):
4195 * buffer.c (syms_of_buffer):
4196 * bytecode.c (syms_of_bytecode):
4197 * callint.c (syms_of_callint):
4198 * casefiddle.c (syms_of_casefiddle):
4199 * casetab.c (init_casetab_once):
4200 * category.c (init_category_once, syms_of_category):
4201 * ccl.c (syms_of_ccl):
4202 * cmds.c (syms_of_cmds):
4203 * composite.c (syms_of_composite):
4204 * dbusbind.c (syms_of_dbusbind):
4205 * dired.c (syms_of_dired):
4206 * dispnew.c (syms_of_display):
4207 * doc.c (syms_of_doc):
4208 * editfns.c (syms_of_editfns):
4209 * emacs.c (syms_of_emacs):
4210 * eval.c (syms_of_eval):
4211 * fileio.c (syms_of_fileio):
4212 * fns.c (syms_of_fns):
4213 * frame.c (syms_of_frame):
4214 * fringe.c (syms_of_fringe):
4215 * insdel.c (syms_of_insdel):
4216 * keymap.c (syms_of_keymap):
4217 * lread.c (init_obarray, syms_of_lread):
4218 * macros.c (syms_of_macros):
4219 * msdos.c (syms_of_msdos):
4220 * print.c (syms_of_print):
4221 * process.c (syms_of_process):
4222 * search.c (syms_of_search):
4223 * sound.c (syms_of_sound):
4224 * syntax.c (init_syntax_once, syms_of_syntax):
4225 * terminal.c (syms_of_terminal):
4226 * textprop.c (syms_of_textprop):
4227 * undo.c (syms_of_undo):
4228 * w32.c (globals_of_w32):
4229 * window.c (syms_of_window):
4230 * xdisp.c (syms_of_xdisp):
4231 * xfaces.c (syms_of_xfaces):
4232 * xfns.c (syms_of_xfns):
4233 * xmenu.c (syms_of_xmenu):
4234 * xsettings.c (syms_of_xsettings):
4235 * xterm.c (syms_of_xterm): Use DEFSYM.
4236
4237 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4238
4239 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4240
4241 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4242
4243 Integer and buffer overflow fixes (Bug#8873).
4244
4245 * print.c (printchar, strout): Check for string overflow.
4246 (PRINTPREPARE, printchar, strout):
4247 Don't set size unless allocation succeeds.
4248
4249 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4250 for sizes. Check for string overflow more accurately.
4251 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4252
4253 * macros.c: Integer and buffer overflow fixes.
4254 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4255 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4256 Use ptrdiff_t, not int, for sizes.
4257 Don't increment bufsize until after realloc succeeds.
4258 Check for size-calculation overflow.
4259 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4260
4261 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4262
4263 * lread.c: Integer overflow fixes.
4264 (read_integer): Radix is now EMACS_INT, not int,
4265 to improve quality of diagnostics for out-of-range radices.
4266 Calculate buffer size correctly for out-of-range radices.
4267 (read1): Check for integer overflow in radices, and in
4268 read-circle numbers.
4269 (read_escape): Avoid int overflow.
4270 (Fload, openp, read_buffer_size, read1)
4271 (substitute_object_recurse, read_vector, read_list, map_obarray):
4272 Use ptrdiff_t, not int, for sizes.
4273 (read1): Use EMACS_INT, not int, for sizes.
4274 Check for size overflow.
4275
4276 * image.c (cache_image): Check for size arithmetic overflow.
4277
4278 * lread.c: Integer overflow issues.
4279 (saved_doc_string_size, saved_doc_string_length)
4280 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4281 Now ptrdiff_t, not int.
4282 (read1): Don't assume doc string length fits in int. Check for
4283 out-of-range doc string lengths.
4284 (read_list): Don't assume file position fits in int.
4285 (read_escape): Check for hex character overflow.
4286
4287 2011-06-22 Leo Liu <sdl.web@gmail.com>
4288
4289 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4290 Move to minibuffer.el.
4291
4292 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4293
4294 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4295 The following patches are for when GLYPH_DEBUG && !XASSERT.
4296 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4297 * dispnew.c (flush_stdout):
4298 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4299 Mark as externally visible.
4300 * dispnew.c (check_window_matrix_pointers): Now static.
4301 * dispnew.c (window_to_frame_vpos):
4302 * xfns.c (unwind_create_frame):
4303 * xterm.c (x_check_font): Remove unused local.
4304 * scroll.c (CHECK_BOUNDS):
4305 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4306 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4307 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4308 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4309 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4310 Now static.
4311 (debug_method_add): Use va_list and vsprintf rather than relying
4312 on undefined behavior with wrong number of arguments.
4313 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4314 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4315 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4316 since we're not interested in debugging glyphs with old libraries.
4317 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4318 GCC 4.6.0's static checking.
4319
4320 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4321
4322 Integer overflow and signedness fixes (Bug#8873).
4323 A few related buffer overrun fixes, too.
4324
4325 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4326
4327 * dispextern.h (struct face.stipple):
4328 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4329 (x_bitmap_mask, x_allocate_bitmap_record)
4330 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4331 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4332 (x_create_bitmap_from_xpm_data):
4333 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4334 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4335 (.bitmaps_last):
4336 * xfaces.c (load_pixmap):
4337 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4338 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4339 (.bitmaps_last, struct x_output.icon_bitmap):
4340 Use ptrdiff_t, not int, for bitmap indexes.
4341 (x_allocate_bitmap_record): Check for size overflow.
4342 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4343
4344 Use ptrdiff_t, not int, for overlay counts.
4345 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4346 * editfns.c (overlays_around, get_pos_property):
4347 * textprop.c (get_char_property_and_overlay):
4348 * xdisp.c (next_overlay_change, note_mouse_highlight):
4349 * xfaces.c (face_at_buffer_position):
4350 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4351 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4352 (Fnext_overlay_change, Fprevious_overlay_change)
4353 (mouse_face_overlay_overlaps, Foverlays_in):
4354 Use ptrdiff_t, not int, for sizes.
4355 (overlays_at, overlays_in): Check for size-calculation overflow.
4356
4357 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4358
4359 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4360 (x_session_initialize): Do not assume string length fits in int.
4361
4362 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4363 This is unlikely, but can occur if DPI is outlandish.
4364
4365 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4366 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4367
4368 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4369 * xrdb.c (magic_file_p, search_magic_path):
4370 Omit last arg SUFFIX; it was always 0. All callers changed.
4371 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4372
4373 * xfont.c (xfont_match): Avoid need for strlen.
4374
4375 * xfns.c: Don't assume strlen fits in int.
4376 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4377
4378 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4379 not unsigned long, as we prefer signed integers. All callers changed.
4380 Detect integer overflow in repeat count.
4381 (message_dolog): Don't assume print length fits in 39 bytes.
4382 (display_mode_element): Don't assume strlen fits in int.
4383
4384 * termcap.c: Don't assume sizes fit in int and never overflow.
4385 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4386 (gobble_line): Check for size-calculation overflow.
4387
4388 * minibuf.c (Fread_buffer):
4389 * lread.c (intern, intern_c_string):
4390 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4391 Don't assume string length fits in int.
4392
4393 * keyboard.c (parse_tool_bar_item):
4394 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4395
4396 * font.c: Don't assume string length fits in int.
4397 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4398 Use ptrdiff_t, not int.
4399 (font_intern_prop): Don't assume string length fits in int.
4400 Don't assume integer property fits in fixnum.
4401 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4402
4403 * filelock.c: Fix some buffer overrun and integer overflow issues.
4404 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4405 Reformulate so as not to need the command string.
4406 Invoke gzip -cd rather than gunzip, as it's more portable.
4407 (lock_info_type, lock_file_1, lock_file):
4408 Don't assume pid_t and time_t fit in unsigned long.
4409 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4410 (current_lock_owner): Prefer signed type for sizes.
4411 Use memcpy, not strncpy, where memcpy is what is really wanted.
4412 Don't assume (via atoi) that time_t and pid_t fit in int.
4413 Check for time_t and/or pid_t out of range, e.g., via a network share.
4414 Don't alloca where an auto var works fine.
4415
4416 * fileio.c: Fix some integer overflow issues.
4417 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4418 Don't assume string length fits in int.
4419 (directory_file_name): Don't assume string length fits in long.
4420 (make_temp_name): Don't assume pid fits in int, or that its print
4421 length is less than 20.
4422
4423 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4424
4425 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4426
4427 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4428
4429 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4430 We prefer signed integers, even for size calculations.
4431
4432 * emacs.c: Don't assume string length fits in 'int'.
4433 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4434 (main): Don't invoke strlen when not needed.
4435
4436 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4437 (XD_DEBUG_MESSAGE): Don't waste a byte.
4438
4439 * callproc.c (getenv_internal_1, getenv_internal)
4440 (Fgetenv_internal):
4441 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4442
4443 * lread.c (invalid_syntax): Omit length argument.
4444 All uses changed. This doesn't fix a bug, but it simplifies the
4445 code away from its former Hollerith-constant appearance, and it's
4446 one less 'int' to worry about when looking at integer-overflow issues.
4447 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4448
4449 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4450 This didn't break anything, but it didn't help either.
4451 It's confusing to put a bogus integer in a place where the actual
4452 value does not matter.
4453 (LIST_END_P): Remove unused macro and its bogus comment.
4454 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4455
4456 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4457 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4458 implementation.
4459 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4460 We prefer signed types, and the value cannot exceed the EMACS_INT
4461 range anyway (because otherwise the length would not be representable).
4462 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4463 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4464 This avoids a GCC warning when WIDE_EMACS_INT.
4465
4466 * indent.c (sane_tab_width): New function.
4467 (current_column, scan_for_column, Findent_to, position_indentation)
4468 (compute_motion): Use it. This is just for clarity.
4469 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4470
4471 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4472
4473 * lisp.h (lint_assume): New macro.
4474 * composite.c (composition_gstring_put_cache):
4475 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4476
4477 * editfns.c, insdel.c:
4478 Omit unnecessary forward decls, to simplify future changes.
4479
4480 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4481
4482 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4483
4484 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4485 Use much-faster test for byte-length change.
4486 Don't assume string byte-length fits in 'int'.
4487 Check that character arg fits in 'int'.
4488 (mapcar1): Declare byte as byte, for clarity.
4489
4490 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4491
4492 * fns.c (concat): Catch string overflow earlier.
4493 Do not rely on integer wraparound.
4494
4495 * dispextern.h (struct it.overlay_strings_charpos)
4496 (struct it.selective): Now EMACS_INT, not int.
4497 * xdisp.c (forward_to_next_line_start)
4498 (back_to_previous_visible_line_start)
4499 (reseat_at_next_visible_line_start, next_element_from_buffer):
4500 Don't arbitrarily truncate the value of 'selective' to int.
4501
4502 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4503
4504 * composite.c: Don't truncate sizes to 'int'.
4505 (composition_gstring_p, composition_reseat_it)
4506 (composition_adjust_point): Use EMACS_INT, not int.
4507 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4508 not EMACS_UINT, for indexes.
4509
4510 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4511
4512 * buffer.c: Include <verify.h>.
4513 (struct sortvec.priority, struct sortstr.priority):
4514 Now EMACS_INT, not int.
4515 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4516 (struct sortstr.size, record_overlay_string)
4517 (struct sortstrlist.size, struct sortlist.used):
4518 Don't truncate size to int.
4519 (record_overlay_string): Check for size-calculation overflow.
4520 (init_buffer_once): Check at compile-time, not run-time.
4521
4522 2011-06-22 Jim Meyering <meyering@redhat.com>
4523
4524 Don't leak an XBM-image-sized buffer
4525 * image.c (xbm_load): Free the image buffer after using it.
4526
4527 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4528
4529 Port to Sun C.
4530 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4531 that Sun C diagnosed.
4532 * fns.c (secure_hash): Fix pointer signedness issue.
4533 * intervals.c (static_offset_intervals): New function.
4534 (offset_intervals): Use it.
4535
4536 2011-06-21 Leo Liu <sdl.web@gmail.com>
4537
4538 * deps.mk (fns.o):
4539 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4540 sha512.h.
4541
4542 * fns.c (secure_hash): Rename from crypto_hash_function and change
4543 the first arg to accept symbols.
4544 (Fsecure_hash): New primitive.
4545 (syms_of_fns): New symbols.
4546
4547 2011-06-20 Deniz Dogan <deniz@dogan.se>
4548
4549 * process.c (Fset_process_buffer): Clarify return value in
4550 docstring.
4551
4552 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4553
4554 * dispnew.c (add_window_display_history): Use BVAR.
4555
4556 * xdisp.c (debug_method_add): Use BVAR.
4557 (check_window_end, dump_glyph_matrix, dump_glyph)
4558 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4559
4560 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4561 Likewise.
4562
4563 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4564 check till after the cache is created in init_frame_faces.
4565
4566 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4567
4568 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4569
4570 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4571
4572 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4573 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4574 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4575
4576 Improve buffer-overflow checking (Bug#8873).
4577 * fileio.c (Finsert_file_contents):
4578 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4579 Remove the old (too-loose) buffer overflow checks.
4580 They weren't needed, since make_gap checks for buffer overflow.
4581 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4582 The old code merely checked for Emacs fixnum overflow, and relied
4583 on undefined (wraparound) behavior. The new code avoids undefined
4584 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4585
4586 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4587 Tune. Don't use wider integers than needed. Don't use alloca.
4588 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4589
4590 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4591
4592 * insdel.c, lisp.h (buffer_overflow): New function.
4593 (insert_from_buffer_1, replace_range, replace_range_2):
4594 * insdel.c (make_gap_larger):
4595 * editfns.c (Finsert_char):
4596 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4597
4598 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4599
4600 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4601
4602 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4603
4604 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4605 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4606
4607 * fileio.c: Don't assume EMACS_INT fits in off_t.
4608 (emacs_lseek): New static function.
4609 (Finsert_file_contents, Fwrite_region): Use it.
4610 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4611
4612 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4613
4614 * fns.c: Don't overflow int when computing a list length.
4615 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4616 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4617 truncation on 64-bit hosts. Check for QUIT every
4618 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4619 faster and is responsive enough.
4620 (Flength): Report an error instead of overflowing an integer.
4621 (Fsafe_length): Return a float if the value is not representable
4622 as a fixnum. This shouldn't happen except in contrived situations.
4623 (Fnthcdr, Fsort): Don't assume list length fits in int.
4624 (Fcopy_sequence): Don't assume vector length fits in int.
4625
4626 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4627 (header_size, word_size): New constants.
4628 (allocate_vectorlike): Don't check size overflow here.
4629 (allocate_vector): Check it here instead, since this is the only
4630 caller of allocate_vectorlike that could cause overflow.
4631 Check that the new vector's length is representable as a fixnum.
4632
4633 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4634 The previous code was bogus. For example, next_almost_prime (32)
4635 returned 39, which is undesirable as it is a multiple of 3; and
4636 next_almost_prime (24) returned 25, which is a multiple of 5 so
4637 why was the code bothering to check for multiples of 7?
4638
4639 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4640
4641 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4642
4643 Variadic C functions now count arguments with ptrdiff_t.
4644 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4645 Back then I didn't know that the Emacs coding style prefers signed int.
4646 Also, in the meantime I found a few more instances where arguments
4647 were being counted with int, which may truncate counts on 64-bit
4648 machines, or EMACS_INT, which may be unnecessarily wide.
4649 * lisp.h (struct Lisp_Subr.function.aMANY)
4650 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4651 Arg counts are now ptrdiff_t, not size_t.
4652 All variadic functions and their callers changed accordingly.
4653 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4654 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4655 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4656 * callint.c (Fcall_interactively): Check arg count for overflow,
4657 to avoid potential buffer overrun. Use signed char, not 'int',
4658 for 'varies' array, so that we needn't bother to check its size
4659 calculation for overflow.
4660 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4661 * eval.c (apply_lambda):
4662 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4663 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4664 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4665
4666 * callint.c (Fcall_interactively): Don't use index var as event count.
4667
4668 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4669 * mem-limits.h (SIZE): Remove; no longer used.
4670
4671 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4672
4673 Remove unnecessary casts.
4674 * xterm.c (x_term_init):
4675 * xfns.c (x_set_border_pixel):
4676 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4677 These aren't needed now that we assume ANSI C.
4678
4679 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4680 It's more likely to cause problems (due to unsigned overflow)
4681 than to cure them.
4682
4683 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4684
4685 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4686
4687 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4688
4689 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4690
4691 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4692
4693 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4694
4695 GLYPH_CODE_FACE returns EMACS_INT, not int.
4696 * dispextern.h (merge_faces):
4697 * xfaces.c (merge_faces):
4698 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4699 Don't assume EMACS_INT fits in int.
4700
4701 * character.h (CHAR_VALID_P): Remove unused parameter.
4702 * fontset.c, lisp.h, xdisp.c: All uses changed.
4703
4704 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4705
4706 * fns.c (concat): Minor tuning based on overflow analysis.
4707 This doesn't fix any bugs. Use int to hold character, instead
4708 of constantly refetching from Emacs object. Use XFASTINT, not
4709 XINT, for value known to be a character. Don't bother comparing
4710 a single byte to 0400, as it's always less.
4711
4712 * floatfns.c (Fexpt):
4713 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4714
4715 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4716 for characters.
4717
4718 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4719
4720 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4721 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4722 incorrectly succeed when S was a string, because 4294967386 was
4723 truncated before it was used.
4724
4725 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4726 Otherwise, an out-of-range integer could cause undefined behavior
4727 on a 64-bit host.
4728
4729 * composite.c: Use int, not EMACS_INT, for characters.
4730 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4731 EMACS_INT, for values that are known to be in character range.
4732 This doesn't fix any bugs but is the usual style inside Emacs and
4733 may generate better code on 32-bit machines.
4734
4735 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4736 This is for reasons similar to the recent CHAR_STRING fix.
4737 * charset.c (Fencode_char): Check that character arg is actually
4738 a character. Pass an int to ENCODE_CHAR.
4739 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4740 wider than 'int', as a compile-time check to prevent future regressions
4741 in this area.
4742
4743 * character.c (char_string): Remove unnecessary casts.
4744
4745 Make sure a 64-bit char is never passed to CHAR_STRING.
4746 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4747 by silently ignoring the top 32 bits, allowing some values
4748 that were far too large to be valid characters.
4749 * character.h: Include <verify.h>.
4750 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4751 arguments are no wider than unsigned, as a compile-time check
4752 to prevent future regressions in this area.
4753 * data.c (Faset):
4754 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4755 (Fsubst_char_in_region):
4756 * fns.c (concat):
4757 * xdisp.c (decode_mode_spec_coding):
4758 Adjust to CHAR_STRING's new requirement.
4759 * editfns.c (Finsert_char, Fsubst_char_in_region):
4760 * fns.c (concat): Check that character args are actually
4761 characters. Without this test, these functions did the wrong
4762 thing with wildly out-of-range values on 64-bit hosts.
4763
4764 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4765 These casts should not be needed on 32-bit hosts, either.
4766 * keyboard.c (read_char):
4767 * lread.c (Fload): Remove casts to unsigned.
4768
4769 * lisp.h (UNSIGNED_CMP): New macro.
4770 This fixes comparison bugs on 64-bit hosts.
4771 (ASCII_CHAR_P): Use it.
4772 * casefiddle.c (casify_object):
4773 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4774 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4775 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4776 * dispextern.h (FACE_FROM_ID):
4777 * keyboard.c (read_char): Use UNSIGNED_CMP.
4778
4779 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4780 not to EMACS_INT, to avoid GCC warning.
4781
4782 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4783
4784 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4785 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4786 isn't needed on 32-bit machines.
4787
4788 * buffer.c (Fgenerate_new_buffer_name):
4789 Use EMACS_INT for count, not int.
4790 (advance_to_char_boundary): Return EMACS_INT, not int.
4791
4792 * data.c (Qcompiled_function): Now static.
4793
4794 * window.c (window_body_lines): Now static.
4795
4796 * image.c (gif_load): Rename local to avoid shadowing.
4797
4798 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4799 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4800 * alloc.c (make_save_value): Integer argument is now of type
4801 ptrdiff_t, not int.
4802 (mark_object): Use ptrdiff_t, not int.
4803 * lisp.h (pD): New macro.
4804 * print.c (print_object): Use it.
4805
4806 * alloc.c: Use EMACS_INT, not int, to count objects.
4807 (total_conses, total_markers, total_symbols, total_vector_size)
4808 (total_free_conses, total_free_markers, total_free_symbols)
4809 (total_free_floats, total_floats, total_free_intervals)
4810 (total_intervals, total_strings, total_free_strings):
4811 Now EMACS_INT, not int. All uses changed.
4812 (Fgarbage_collect): Compute overall total using a double, so that
4813 integer overflow is less likely to be a problem. Check for overflow
4814 when converting back to an integer.
4815 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4816 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4817 These were 'int' variables that could overflow on 64-bit hosts;
4818 they were never used, so remove them instead of repairing them.
4819 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4820 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4821 Previously, this ceilinged at INT_MAX, but that doesn't work on
4822 64-bit machines.
4823 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4824
4825 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4826 (allocate_vectorlike): Check for ptrdiff_t overflow.
4827 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4828 when a (possibly-narrower) signed value would do just as well.
4829 We prefer using signed arithmetic, to avoid comparison confusion.
4830
4831 * alloc.c: Catch some string size overflows that we were missing.
4832 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4833 for convenience in STRING_BYTES_MAX.
4834 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4835 The definition here is exact; the one in lisp.h was approximate.
4836 (allocate_string_data): Check for string overflow. This catches
4837 some instances we weren't catching before. Also, it catches
4838 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4839 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4840 and ptrdiff_t and EMACS_INT are both 64 bits.
4841
4842 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4843 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4844 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4845
4846 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4847
4848 * alloc.c (Fmake_string): Check for out-of-range init.
4849
4850 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4851
4852 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4853
4854 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4855
4856 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4857 xg_get_default_scrollbar_width.
4858
4859 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4860 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4861 (style_changed_cb): Call update_theme_scrollbar_width and call
4862 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4863 all frames (Bug#8505).
4864 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4865 Call gtk_window_set_resizable if HAVE_GTK3.
4866 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4867 and height if HAVE_GTK3 (Bug#8505).
4868 (scroll_bar_width_for_theme): New variable.
4869 (update_theme_scrollbar_width): New function.
4870 (xg_get_default_scrollbar_width): Move code to
4871 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4872 (xg_initialize): Call update_theme_scrollbar_width.
4873
4874 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4875
4876 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4877
4878 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4879
4880 * frame.c (make_frame): Call other_buffer_safely instead of
4881 other_buffer.
4882
4883 * window.c (temp_output_buffer_show): Call display_buffer with
4884 second argument Vtemp_buffer_show_specifiers and reset latter
4885 immediately after the call.
4886 (Vtemp_buffer_show_specifiers): New variable.
4887 (auto_window_vscroll_p, next_screen_context_lines)
4888 (Vscroll_preserve_screen_position): Remove leading asterisks from
4889 doc-strings.
4890
4891 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4892
4893 Fix minor problems found by GCC 4.6.0 static checking.
4894 * buffer.c (Qclone_number): Remove for now, as it's unused.
4895 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4896 (record_buffer): Remove unused local.
4897 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4898 (set_frame_buffer_list): Remove; unused.
4899 * frame.h (other_visible_frames): Remove decl.
4900 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4901 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4902 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4903 if HAVE_GPM.
4904 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4905 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4906 Define only if HAVE_GPM.
4907 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4908 (update_hints_inhibit): Remove; never set. All uses removed.
4909 * widgetprv.h (emacsFrameClassRec): Remove decl.
4910 * window.c (delete_deletable_window): Now returns void, since it
4911 wasn't returning anything.
4912 (compare_window_configurations): Remove unused locals.
4913 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4914 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4915 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4916 the same widths as pointers. This follows up on the 2011-05-06 patch.
4917 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4918 * xterm.h: Likewise.
4919 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4920
4921 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4922
4923 * makefile.w32-in: Update dependencies.
4924 (LISP_H): Add lib/intprops.h.
4925
4926 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4927
4928 * image.c (gif_load): Add animation frame delay to the metadata.
4929 (syms_of_image): Use DEFSYM. New symbol `delay'.
4930
4931 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4932
4933 * window.c (delete_deletable_window): Re-add.
4934 (Fset_window_configuration): Rewrite to handle dead buffers and
4935 consequently deletable windows.
4936 (window_tree, Fwindow_tree): Remove. Supply functionality in
4937 window.el.
4938 (compare_window_configurations): Simplify code.
4939
4940 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4941
4942 * image.c (imagemagick_load_image): Fix type mismatch.
4943 (Fimagemagick_types): Likewise.
4944
4945 * window.h (replace_buffer_in_windows): Declare.
4946
4947 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4948
4949 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4950 Qclone_number. Remove external declaration of Qdelete_window.
4951 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4952 code.
4953 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4954 Run Qbuffer_list_update_hook if allowed.
4955 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4956 buffer list implementation.
4957 (other_buffer_safely): New function.
4958 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4959 calls to replace_buffer_in_windows and
4960 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4961 if allowed.
4962 (record_buffer): Inhibit quitting and rewrite using quittable
4963 functions. Run Qbuffer_list_update_hook if allowed.
4964 (Frecord_buffer, Funrecord_buffer): New functions.
4965 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4966 Move switch-to-buffer to window.el.
4967 (bury-buffer): Move to window.el.
4968 (Vbuffer_list_update_hook): New variable.
4969
4970 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4971 section.
4972
4973 * window.h (resize_frame_windows): Move up in code.
4974 (Fwindow_frame): Remove EXFUN.
4975 (replace_buffer_in_all_windows): Remove prototype.
4976 (replace_buffer_in_windows_safely): Add prototype.
4977
4978 * window.c: Declare Qdelete_window static again. Move down
4979 declaration of select_count.
4980 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4981 (Fother_window): Move to window.el.
4982 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4983 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4984 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4985 window.el.
4986 (replace_buffer_in_windows): Implement by calling
4987 Qreplace_buffer_in_windows.
4988 (replace_buffer_in_all_windows): Remove with some functionality
4989 moved into replace_buffer_in_windows_safely.
4990 (replace_buffer_in_windows_safely): New function.
4991 (select_window_norecord, select_frame_norecord): Move in front
4992 of run_window_configuration_change_hook. Remove now obsolete
4993 declarations.
4994 (Fset_window_buffer): Rewrite doc-string.
4995 Call Qrecord_window_buffer.
4996 (keys_of_window): Move binding for other-window to window.el.
4997
4998 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4999
5000 * dispextern.h (struct image): Replace data member, whose int_val
5001 and ptr_val fields were not used by anything, with a single
5002 lisp_val object.
5003
5004 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5005 (gif_clear_image, gif_load, imagemagick_load_image)
5006 (gs_clear_image, gs_load): Callers changed.
5007
5008 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5009
5010 * buffer.h: Include <time.h>, for time_t.
5011 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5012
5013 Fix minor problems found by static checking.
5014
5015 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5016
5017 Make identifiers static if they are not used in other modules.
5018 * data.c (Qcompiled_function, Qframe, Qvector):
5019 * image.c (QimageMagick, Qsvg):
5020 * minibuf.c (Qmetadata):
5021 * window.c (resize_window_check, resize_root_window): Now static.
5022 * window.h (resize_window_check, resize_root_window): Remove decls.
5023
5024 * window.c (window_deletion_count, delete_deletable_window):
5025 Remove; unused.
5026 (window_body_lines): Now static.
5027 (Fdelete_other_windows_internal): Mark vars as initialized.
5028 Make sure 'resize_failed' is initialized.
5029 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5030 (resize_window_apply): Remove unused local.
5031 * window.h (delete_deletable_window): Remove decl.
5032
5033 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5034 (imagemagick_load_image): Fix pointer signedness problem by changing
5035 last arg from unsigned char * to char *. All uses changed.
5036 Also, fix a local for similar reasons.
5037 Remove unused locals. Remove locals to avoid shadowing.
5038 (fn_rsvg_handle_free): Remove; unused.
5039 (svg_load, svg_load_image): Fix pointer signedness problem.
5040 (imagemagick_load_image): Don't use garbage pointer image_wand.
5041
5042 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5043
5044 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5045
5046 * image.c (gif_load): Fix omitted cast error introduced by
5047 2011-06-06 change.
5048
5049 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5050
5051 * window.h (resize_proportionally, orig_total_lines)
5052 (orig_top_line): Remove from window structure.
5053 (set_window_height, set_window_width, change_window_heights)
5054 (Fdelete_window): Remove prototypes.
5055 (resize_frame_windows): Remove duplicate declaration.
5056
5057 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5058
5059 * window.h (resize_frame_windows, resize_window_check)
5060 (delete_deletable_window, resize_root_window)
5061 (resize_frame_windows): Declare prototypes.
5062
5063 * window.c (resize_window_apply): Make definition be "static" to
5064 match the prototype.
5065
5066 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5067
5068 * window.c: Remove declarations of Qwindow_size_fixed,
5069 window_min_size_1, window_min_size_2, window_min_size,
5070 size_window, window_fixed_size_p, enlarge_window, delete_window.
5071 Remove static from declaration of Qdelete_window, it's
5072 temporarily needed by Fbury_buffer.
5073 (replace_window): Don't assign orig_top_line and
5074 orig_total_lines.
5075 (Fdelete_window, delete_window): Remove. Window deletion is
5076 handled by window.el.
5077 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5078 Replace Fdelete_window calls with calls to Qdelete_window.
5079 (Fdelete_other_windows): Remove. Deleting other windows is
5080 handled by window.el.
5081 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5082 handled in window.el.
5083 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5084 Window minimum sizes are handled in window.el.
5085 (shrink_windows, size_window, set_window_height)
5086 (set_window_width, change_window_heights, window_height)
5087 (window_width, CURBEG, CURSIZE, enlarge_window)
5088 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5089 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5090 handled in window.el.
5091 (make_dummy_parent): Rename to make_parent_window and give it a
5092 second argument horflag.
5093 (make_window): Don't set resize_proportionally any more.
5094 (Fsplit_window): Remove. Windows are split in window.el.
5095 (save_restore_action, save_restore_orig_size)
5096 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5097 Resize mini windows in window.el.
5098 (grow_mini_window, shrink_mini_window): Implement by calling
5099 Qresize_root_window_vertically, resize_window_check and
5100 resize_window_apply.
5101 (saved_window, Fset_window_configuration, save_window_save):
5102 Do not handle orig_top_line, orig_total_lines, and
5103 resize_proportionally.
5104 (window_min_height, window_min_width): Move to window.el.
5105 (keys_of_window): Move bindings for delete-other-windows,
5106 split-window, delete-window and enlarge-window to window.el.
5107
5108 * buffer.c: Temporarily extern Qdelete_window.
5109 (Fbury_buffer): Temporarily call Qdelete_window instead of
5110 Fdelete_window (Fbury_buffer will move to window.el soon).
5111
5112 * frame.c (set_menu_bar_lines_1): Remove code handling
5113 orig_top_line and orig_total_lines.
5114
5115 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5116 set_window_height but set heights directly.
5117 (change_frame_size_1): Use resize_frame_windows.
5118
5119 * xdisp.c (init_xdisp): Don't use set_window_height but set
5120 heights directly.
5121
5122 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5123 Use resize_frame_windows instead of change_window_heights and run
5124 run_window_configuration_change_hook.
5125
5126 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5127 instead of change_window_heights and run
5128 run_window_configuration_change_hook.
5129
5130 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5131
5132 * window.c (replace_window): Rename second argument REPLACEMENT to
5133 NEW. New third argument SETFLAG. Rewrite.
5134 (delete_window, make_dummy_parent): Call replace_window with
5135 third argument 1.
5136 (window_list_1): Move down in code.
5137 (run_window_configuration_change_hook): Move set_buffer part
5138 before select_frame_norecord part in order to unwind correctly.
5139 Rename count1 to count.
5140 (recombine_windows, delete_deletable_window, resize_root_window)
5141 (Fdelete_other_windows_internal)
5142 (Frun_window_configuration_change_hook, make_parent_window)
5143 (resize_window_check, resize_window_apply, Fresize_window_apply)
5144 (resize_frame_windows, Fsplit_window_internal)
5145 (Fdelete_window_internal, Fresize_mini_window_internal):
5146 New functions.
5147 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5148
5149 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5150
5151 * window.h (window): Add some new members to window structure -
5152 normal_lines, normal_cols, new_total, new_normal, clone_number,
5153 splits, nest, prev_buffers, next_buffers.
5154 (WINDOW_TOTAL_SIZE): Move here from window.c.
5155 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5156
5157 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5158 Remove.
5159 (make_dummy_parent): Set new members of windows structure.
5160 (make_window): Move down in code. Handle new members of window
5161 structure.
5162 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5163 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5164 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5165 (Fset_window_prev_buffers, Fwindow_next_buffers)
5166 (Fset_window_next_buffers, Fset_window_clone_number):
5167 New functions.
5168 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5169 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5170 Doc-string fixes.
5171 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5172 Argument WINDOW can be now internal window too.
5173 (Fwindow_use_time): Move up in code.
5174 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5175 Rewrite doc-string.
5176 (Fset_window_configuration, saved_window)
5177 (Fcurrent_window_configuration, save_window_save): Handle new
5178 members of window structure.
5179 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5180 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5181 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5182 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5183 Qget_mru_window, Qresize_root_window,
5184 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5185 Qauto_buffer_name; staticpro them.
5186
5187 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5188
5189 * window.c (Fwindow_total_size, Fwindow_left_column)
5190 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5191 (Fwindow_list_1): New functions.
5192 (window_box_text_cols): Replace with window_body_cols.
5193 (Fwindow_width, Fscroll_left, Fscroll_right):
5194 Use window_body_cols instead of window_box_text_cols.
5195 (delete_window, Fset_window_configuration):
5196 Call delete_all_subwindows with window as argument.
5197 (delete_all_subwindows): Take a window as argument and not a
5198 structure. Rewrite.
5199 (window_loop): Remove handling of GET_LRU_WINDOW and
5200 GET_LARGEST_WINDOW.
5201 (Fget_lru_window, Fget_largest_window): Move to window.el.
5202
5203 * window.h: Extern window_body_cols instead of
5204 window_box_text_cols. delete_all_subwindows now takes a
5205 Lisp_Object as argument.
5206
5207 * indent.c (compute_motion, Fcompute_motion):
5208 Use window_body_cols instead of window_box_text_cols.
5209
5210 * frame.c (delete_frame): Call delete_all_subwindows with root
5211 window as argument.
5212
5213 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5214
5215 * fns.c (Fputhash): Document return value.
5216
5217 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5218
5219 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5220
5221 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5222
5223 Cons<->int and similar integer overflow fixes (Bug#8794).
5224
5225 Check for overflow when converting integer to cons and back.
5226 * charset.c (Fdefine_charset_internal, Fdecode_char):
5227 Use cons_to_unsigned to catch overflow.
5228 (Fencode_char): Use INTEGER_TO_CONS.
5229 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5230 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5231 * data.c (long_to_cons, cons_to_long): Remove.
5232 (cons_to_unsigned, cons_to_signed): New functions.
5233 These signal an error for invalid or out-of-range values.
5234 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5235 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5236 * font.c (Ffont_variation_glyphs):
5237 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5238 * lisp.h: Include <intprops.h>.
5239 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5240 (cons_to_signed, cons_to_unsigned): New decls.
5241 (long_to_cons, cons_to_long): Remove decls.
5242 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5243 (Fprimitive_undo): Use CONS_TO_INTEGER.
5244 * xfns.c (Fx_window_property): Likewise.
5245 * xselect.c: Include <limits.h>.
5246 (x_own_selection, selection_data_to_lisp_data):
5247 Use INTEGER_TO_CONS.
5248 (x_handle_selection_request, x_handle_selection_clear)
5249 (x_get_foreign_selection, Fx_disown_selection_internal)
5250 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5251 (lisp_data_to_selection_data): Use cons_to_unsigned.
5252 (x_fill_property_data): Use cons_to_signed.
5253 Report values out of range.
5254
5255 Check for buffer and string overflow more precisely.
5256 * buffer.h (BUF_BYTES_MAX): New macro.
5257 * lisp.h (STRING_BYTES_MAX): New macro.
5258 * alloc.c (Fmake_string):
5259 * character.c (string_escape_byte8):
5260 * coding.c (coding_alloc_by_realloc):
5261 * doprnt.c (doprnt):
5262 * editfns.c (Fformat):
5263 * eval.c (verror):
5264 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5265 since they may not be the same number.
5266 * editfns.c (Finsert_char):
5267 * fileio.c (Finsert_file_contents):
5268 Likewise for BUF_BYTES_MAX.
5269
5270 * image.c: Use ptrdiff_t, not int, for sizes.
5271 (slurp_file): Switch from int to ptrdiff_t.
5272 All uses changed.
5273 (slurp_file): Check that file size fits in both size_t (for
5274 malloc) and ptrdiff_t (for sanity and safety).
5275
5276 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5277 if b->modtime has its maximal value.
5278
5279 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5280
5281 Don't assume time_t can fit into int.
5282 * buffer.h (struct buffer.modtime): Now time_t, not int.
5283 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5284 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5285
5286 Minor fixes for signed vs unsigned integers.
5287 * character.h (MAYBE_UNIFY_CHAR):
5288 * charset.c (maybe_unify_char):
5289 * keyboard.c (read_char, reorder_modifiers):
5290 XINT -> XFASTINT, since the integer must be nonnegative.
5291 * ftfont.c (ftfont_spec_pattern):
5292 * keymap.c (access_keymap, silly_event_symbol_error):
5293 XUINT -> XFASTINT, since the integer must be nonnegative.
5294 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5295 since it makes no difference and we prefer signed.
5296 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5297 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5298 nonnegative.
5299
5300 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5301
5302 * window.h (Fwindow_frame): Declare.
5303
5304 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5305
5306 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5307 (SPARE_MEMORY): Always define.
5308 (LARGE_REQUEST): Remove.
5309 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5310
5311 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5312
5313 * lisp.h: Move EXFUNS for Fframe_root_window,
5314 Fframe_first_window and Fset_frame_selected_window to window.h.
5315
5316 * window.h: Move EXFUNS for Fframe_root_window,
5317 Fframe_first_window and Fset_frame_selected_window here from
5318 lisp.h.
5319
5320 * frame.c (Fwindow_frame, Fframe_first_window)
5321 (Fframe_root_window, Fframe_selected_window)
5322 (Fset_frame_selected_window): Move to window.c.
5323 (Factive_minibuffer_window): Move to minibuf.c.
5324 (Fother_visible_frames_p): New function.
5325
5326 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5327
5328 * window.c (decode_window, decode_any_window): Move up in code.
5329 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5330 (inhibit_frame_unsplittable): Remove unused variable.
5331 (Fwindow_buffer): Move up and rewrite doc-string.
5332 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5333 (Fwindow_prev): New functions.
5334 (Fwindow_frame): Move here from frame.c. Accept any window as
5335 argument.
5336 (Fframe_root_window, Fframe_first_window)
5337 (Fframe_selected_window): Move here from frame.c. Accept frame
5338 or arbitrary window as argument. Update doc-strings.
5339 (Fminibuffer_window): Move up in code.
5340 (Fwindow_minibuffer_p): Move up in code and simplify.
5341 (Fset_frame_selected_window): Move here from frame.c.
5342 Marginal rewrite.
5343 (Fselected_window, select_window, Fselect_window): Move up in
5344 code. Minor doc-string fixes.
5345
5346 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5347
5348 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5349 Do not assume that spare memory exists; that assumption is valid
5350 only if SYSTEM_MALLOC.
5351 (LARGE_REQUEST): New macro, so that the issue of large requests
5352 is separated from the issue of spare memory.
5353
5354 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5355
5356 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5357 format. (Bug#8806)
5358
5359 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5360
5361 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5362 before statements.
5363
5364 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5365
5366 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5367
5368 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5369
5370 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5371 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5372
5373 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5374
5375 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5376
5377 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5378
5379 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5380 (x_clipboard_manager_save): Add return value.
5381 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5382 New error handlers.
5383 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5384 Obey Vx_select_enable_clipboard_manager. Catch errors in
5385 x_clipboard_manager_save (Bug#8779).
5386 (Vx_select_enable_clipboard_manager): New variable.
5387 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5388
5389 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5390
5391 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5392
5393 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5394
5395 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5396 in the current matrix if keep_current_p is non-zero.
5397
5398 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5399
5400 * bidi.c (bidi_level_of_next_char): Fix last change.
5401
5402 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5403
5404 Support bidi reordering of text covered by display properties.
5405
5406 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5407 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5408 (bidi_cache_search, bidi_cache_iterator_state)
5409 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5410 (bidi_level_of_next_char, bidi_move_to_visually_next):
5411 Support character positions inside a run of characters covered by a
5412 display string.
5413 (bidi_paragraph_init, bidi_resolve_explicit_1)
5414 (bidi_level_of_next_char): Call bidi_fetch_char and
5415 bidi_fetch_char_advance instead of FETCH_CHAR and
5416 FETCH_CHAR_ADVANCE.
5417 (bidi_init_it): Initialize new members.
5418 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5419 definitions.
5420 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5421 instead of using explicit *_CHAR codes.
5422 (bidi_resolve_explicit, bidi_resolve_weak):
5423 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5424 bidirectional text is supported only in multibyte buffers.
5425 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5426 it to initialize the frame_window_p member of struct bidi_it.
5427 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5428 (bidi_resolve_explicit, bidi_resolve_weak)
5429 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5430 bidi_it->nchars is non-positive.
5431 (bidi_level_of_next_char): Don't try to lookup the cache for the
5432 next/previous character if nothing is cached there yet, or if we
5433 were just reseat()'ed to a new position.
5434
5435 * xdisp.c (set_cursor_from_row): Set start and stop points
5436 according to the row's direction when priming the loop that looks
5437 for the glyph on which to display cursor.
5438 (single_display_spec_intangible_p): Function deleted.
5439 (display_prop_intangible_p): Reimplement to call
5440 handle_display_spec instead of single_display_spec_intangible_p.
5441 Accept 3 additional arguments needed by handle_display_spec.
5442 This fixes incorrect cursor motion across display property with complex
5443 values: lists, `(when COND...)' forms, etc.
5444 (single_display_spec_string_p): Support property values that are
5445 lists with the argument STRING its top-level element.
5446 (display_prop_string_p): Fix the condition for processing a
5447 property that is a list to be consistent with handle_display_spec.
5448 (handle_display_spec): New function, refactored from the
5449 last portion of handle_display_prop.
5450 (compute_display_string_pos): Accept additional argument
5451 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5452 value of a `display' property is a "replacing spec".
5453 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5454 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5455 the display property, but just return a value indicating whether
5456 the display property will replace the characters it covers.
5457 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5458 frame_window_p members of struct bidi_it.
5459 (compute_display_string_pos, compute_display_string_end):
5460 New functions.
5461 (push_it): Accept second argument POSITION, where pop_it should
5462 jump to continue iteration.
5463 (reseat_1): Initialize bidi_it.disp_pos.
5464
5465 * keyboard.c (adjust_point_for_property): Adjust the call to
5466 display_prop_intangible_p to its new signature.
5467
5468 * dispextern.h (struct bidi_it): New member frame_window_p.
5469 (bidi_init_it): Update prototypes.
5470 (display_prop_intangible_p): Update prototype.
5471 (compute_display_string_pos, compute_display_string_end):
5472 Declare prototypes.
5473 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5474 EMACS_INT.
5475
5476 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5477
5478 Malloc failure behavior now depends on size of allocation.
5479 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5480 * lisp.h: Change signatures accordingly.
5481 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5482 All callers changed. (Bug#8762)
5483
5484 * gnutls.c: Use Emacs's memory allocators.
5485 Without this change, the gnutls library would invoke malloc etc.
5486 directly, which causes problems on non-SYNC_INPUT hosts, and which
5487 runs afoul of improving memory_full behavior. (Bug#8761)
5488 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5489 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5490 xfree instead of the default malloc, realloc, free.
5491 (Fgnutls_boot): No need to check for memory allocation failure,
5492 since xmalloc does that for us.
5493
5494 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5495 * category.c (hash_get_category_set):
5496 * ccl.c (ccl_driver):
5497 * charset.c (Fdefine_charset_internal):
5498 * charset.h (struct charset.hash_index):
5499 * composite.c (get_composition_id, gstring_lookup_cache)
5500 (composition_gstring_put_cache):
5501 * composite.h (struct composition.hash_index):
5502 * dispextern.h (struct image.hash):
5503 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5504 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5505 (hashfn_equal, hashfn_user_defined, make_hash_table)
5506 (maybe_resize_hash_table, hash_lookup, hash_put)
5507 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5508 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5509 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5510 * image.c (make_image, search_image_cache, lookup_image)
5511 (xpm_put_color_table_h):
5512 * lisp.h (struct Lisp_Hash_Table):
5513 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5514 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5515 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5516 * alloc.c (allocate_vectorlike):
5517 Check for overflow in vector size calculations.
5518 * ccl.c (ccl_driver):
5519 Check for overflow when converting EMACS_INT to int.
5520 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5521 need to be updated by these changes.
5522 * fns.c (make_hash_table, maybe_resize_hash_table):
5523 Check for integer overflow with large hash tables.
5524 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5525 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5526 (SXHASH_REDUCE): New macro.
5527 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5528 Use it instead of discarding useful hash info with large hash values.
5529 (sxhash_float): New function.
5530 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5531 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5532 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5533 Rewrite to use FIXNUM_BITS, as this simplifies things.
5534 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5535 Adjust signatures to match updated version of code.
5536 (consing_since_gc): Now EMACS_INT, since a single hash table can
5537 use more than INT_MAX bytes.
5538
5539 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5540
5541 Make it possible to build with GCC-4.6+ -O2 -flto.
5542
5543 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5544
5545 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5546
5547 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5548 Call minibuffer-inactive-mode.
5549
5550 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5551
5552 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5553 Update dependencies.
5554
5555 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5556
5557 * data.c (init_data): Remove code for UTS, this system is not
5558 supported anymore.
5559
5560 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5561
5562 Don't force ./temacs to start in terminal mode.
5563
5564 * frame.c (make_initial_frame): Initialize faces in all cases, not
5565 only when CANNOT_DUMP is defined.
5566 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5567
5568 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5569
5570 * dispnew.c (add_window_display_history): Use const for the string
5571 pointer. Remove declaration, not needed.
5572
5573 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5574
5575 Use 'inline', not 'INLINE'.
5576 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5577 * alloc.c, fontset.c (INLINE): Remove.
5578 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5579 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5580 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5581 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5582 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5583
5584 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5585
5586 Make it possible to run ./temacs.
5587
5588 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5589 syms_of_callproc does the same thing. Remove test for
5590 "initialized", do it in the caller.
5591 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5592
5593 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5594
5595 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5596 (read_minibuf): Use get_minibuffer.
5597 (syms_of_minibuf): Use DEFSYM.
5598 (Qmetadata): New var.
5599 * data.c (Qbuffer): Don't make it static.
5600 (syms_of_data): Use DEFSYM.
5601
5602 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5603
5604 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5605 (CCL_CODE_MIN): New macro.
5606
5607 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5608
5609 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5610
5611 * eval.c (Qdebug): Now static.
5612 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5613 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5614 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5615
5616 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5617
5618 * image.c: Various fixes to ImageMagick code comments.
5619 (Fimagemagick_types): Doc fix.
5620
5621 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5622
5623 Minor fixes prompted by GCC 4.6.0 warnings.
5624
5625 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5626
5627 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5628 (x_clipboard_manager_save_all): Move extern decl to ...
5629 * xterm.h: ... here, so that it can be checked for consistency.
5630
5631 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5632
5633 * xselect.c (x_clipboard_manager_save_frame)
5634 (x_clipboard_manager_save_all): New functions.
5635 (Fx_clipboard_manager_save): Lisp function deleted.
5636
5637 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5638 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5639
5640 * xterm.h: Update prototype.
5641
5642 2011-05-28 William Xu <william.xwl@gmail.com>
5643
5644 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5645 exiting (Bug#8239).
5646
5647 2011-05-28 Jim Meyering <meyering@redhat.com>
5648
5649 Avoid a sign-extension bug in crypto_hash_function.
5650 * fns.c (to_uchar): Define.
5651 (crypto_hash_function): Use it to convert some newly-signed
5652 variables to unsigned, to avoid sign-extension bugs. For example,
5653 without this change, (md5 "truc") would evaluate to
5654 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5655 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5656 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5657
5658 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5659
5660 Integer overflow fixes.
5661
5662 * dbusbind.c: Serial number integer overflow fixes.
5663 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5664 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5665 to hold a serial number that is too large for a fixnum.
5666 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5667 Check for serial numbers out of range. Decode any serial number
5668 that was so large that it became a float. (Bug#8722)
5669
5670 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5671 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5672 Use XFASTINT rather than XUINT when numbers are nonnegative.
5673 (xd_append_arg, Fdbus_method_return_internal):
5674 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5675 arguments, check that Lisp number is nonnegative, rather than
5676 silently wrapping negative numbers around. (Bug#8722)
5677 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5678 (Bug#8722)
5679
5680 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5681
5682 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5683
5684 ccl: Add integer overflow checks.
5685 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5686 (IN_INT_RANGE): New macros.
5687 (ccl_driver): Use them to check for integer overflow when
5688 decoding a CCL program. Many of the new checks are whether XINT (x)
5689 fits in int; it doesn't always, on 64-bit hosts. The new version
5690 doesn't catch all possible integer overflows, but it's an
5691 improvement. (Bug#8719)
5692
5693 * alloc.c (make_event_array): Use XINT, not XUINT.
5694 There's no need for unsigned here.
5695
5696 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5697 This follows up to the 2011-05-06 change that substituted uintptr_t
5698 for EMACS_INT. This case wasn't caught back then.
5699
5700 Rework Fformat to avoid integer overflow issues.
5701 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5702 now (part of C89). Include <verify.h>.
5703 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5704 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5705 (Fformat): Avoid the prepass trying to compute sizes; it was only
5706 approximate and thus did not catch overflow reliably. Instead, walk
5707 through the format just once, formatting and computing sizes as we go,
5708 checking for integer overflow at every step, and allocating a larger
5709 buffer as needed. Keep track separately whether the format is
5710 multibyte. Keep only the most-recently calculated precision, rather
5711 than them all. Record whether each argument has been converted to
5712 string. Use EMACS_INT, not int, for byte and char and arg counts.
5713 Support field widths and precisions larger than INT_MAX. Avoid
5714 sprintf's undefined behavior with conversion specifications such as %#d
5715 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5716 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5717 formatting out-of-range floating point numbers with int
5718 formats. (Bug#8668)
5719
5720 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5721
5722 * data.c: Avoid integer truncation in expressions involving floats.
5723 * data.c: Include <intprops.h>.
5724 (arith_driver): When there's an integer overflow in an expression
5725 involving floating point, convert the integers to floating point
5726 so that the resulting value does not suffer from catastrophic
5727 integer truncation. For example, on a 64-bit host (* 4
5728 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5729 Do not rely on undefined behavior after integer overflow.
5730
5731 merge count_size_as_multibyte, parse_str_to_multibyte
5732 * character.c, character.h (count_size_as_multibyte):
5733 Rename from parse_str_to_multibyte; all uses changed.
5734 Check for integer overflow.
5735 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5736 since it's now a duplicate of the other. This is more of
5737 a character than a buffer op, so better that it's in character.c.
5738 * fns.c, print.c: Adjust to above changes.
5739
5740 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5741
5742 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5743
5744 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5745
5746 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5747 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5748 (x_clipboard_manager_save): Now static.
5749 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5750
5751 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5752 (crypto_hash_function): Now static.
5753 Fix pointer signedness problems. Avoid unnecessary initializations.
5754
5755 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5756
5757 * termhooks.h (Vselection_alist): Make it terminal-local.
5758
5759 * terminal.c (create_terminal): Initialize it.
5760
5761 * xselect.c: Support for clipboard managers.
5762 (Vselection_alist): Move to termhooks.h as terminal-local var.
5763 (LOCAL_SELECTION): New macro.
5764 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5765 (symbol_to_x_atom): Remove gratuitous arg.
5766 (x_handle_selection_request, lisp_data_to_selection_data)
5767 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5768 (x_own_selection, x_get_local_selection, x_convert_selection):
5769 New arg, specifying work frame. Use terminal-local Vselection_alist.
5770 (some_frame_on_display): Delete unused function.
5771 (Fx_own_selection_internal, Fx_get_selection_internal)
5772 (Fx_disown_selection_internal, Fx_selection_owner_p)
5773 (Fx_selection_exists_p): New optional frame arg.
5774 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5775 (x_handle_selection_clear): Don't treat other terminals with the
5776 same keyboard specially. Use the terminal-local Vselection_alist.
5777 (x_clear_frame_selections): Use Frun_hook_with_args.
5778
5779 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5780
5781 * xterm.h: Add support for those atoms.
5782
5783 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5784
5785 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5786 (converted_selections, conversion_fail_tag): New global variables.
5787 (x_selection_request_lisp_error): Free the above.
5788 (x_get_local_selection): Remove unnecessary code.
5789 (x_reply_selection_request): Args changed; handle arbitrary array
5790 of converted selections stored in converted_selections.
5791 Separate the XChangeProperty and SelectionNotify steps.
5792 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5793 (x_convert_selection): New function.
5794 (x_handle_selection_event): Simplify.
5795 (x_get_foreign_selection): Don't ignore incoming requests while
5796 waiting for an answer; this will fail when we implement
5797 SAVE_TARGETS, and seems unnecessary anyway.
5798 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5799 (Vx_sent_selection_functions): Doc fix.
5800
5801 2011-05-26 Leo Liu <sdl.web@gmail.com>
5802
5803 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5804
5805 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5806
5807 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5808
5809 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5810 for fringe update if it has periodic bitmap.
5811 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5812 and fringe_bitmap_periodic_p.
5813
5814 * fringe.c (get_fringe_bitmap_data): New function.
5815 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5816 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5817 row. Mark glyph row for fringe update if periodicity changed.
5818
5819 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5820 for fringe update unless it has periodic bitmap.
5821
5822 2011-05-25 Kenichi Handa <handa@m17n.org>
5823
5824 * xdisp.c (get_next_display_element): Set correct it->face_id for
5825 a static composition.
5826
5827 2011-05-24 Leo Liu <sdl.web@gmail.com>
5828
5829 * deps.mk (fns.o):
5830 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5831
5832 * fns.c (crypto_hash_function, Fsha1): New function.
5833 (Fmd5): Use crypto_hash_function.
5834 (syms_of_fns): Add Ssha1.
5835
5836 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5837
5838 * gnutls.c: Remove unused macros.
5839 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5840 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5841 Remove macros that are defined and never used.
5842 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5843
5844 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5845
5846 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5847 (Fx_get_selection_internal): Minor cleanup.
5848 (Fx_own_selection_internal): Rename arguments for consistency with
5849 select.el.
5850
5851 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5852
5853 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5854
5855 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5856
5857 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5858
5859 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5860
5861 * dispnew.c (scrolling_window): Don't exclude the case that the
5862 last enabled row in the desired matrix touches the bottom boundary.
5863
5864 2011-05-21 Glenn Morris <rgm@gnu.org>
5865
5866 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5867 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5868 and add some more files.
5869
5870 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5871
5872 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5873 report_file_error introduced by the change from 2011-05-07.
5874
5875 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5876
5877 * systime.h (Time): Define only if emacs is defined.
5878 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5879 where the include path doesn't have X11/X.h by default. See
5880 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5881
5882 2011-05-20 Kenichi Handa <handa@m17n.org>
5883
5884 * composite.c (find_automatic_composition): Fix previous change.
5885
5886 2011-05-20 Glenn Morris <rgm@gnu.org>
5887
5888 * lisp.mk: New file, split from Makefile.in.
5889 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5890 (shortlisp): Remove.
5891 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5892
5893 2011-05-19 Glenn Morris <rgm@gnu.org>
5894
5895 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5896 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5897 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5898 (lisp): Set the order to that of loadup.el.
5899 (shortlisp): Make it a copy of $lisp.
5900 (SOME_MACHINE_LISP): Remove.
5901 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5902 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5903
5904 2011-05-18 Kenichi Handa <handa@m17n.org>
5905
5906 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5907 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5908 (find_automatic_composition): Mostly rewrite for efficiency.
5909
5910 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5911
5912 * makefile.w32-in: Update dependencies.
5913
5914 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5915
5916 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5917 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5918
5919 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5920
5921 Fix some integer overflow issues, such as string length overflow.
5922
5923 * insdel.c (count_size_as_multibyte): Check for string overflow.
5924
5925 * character.c (lisp_string_width): Check for string overflow.
5926 Use EMACS_INT, not int, for string indexes and lengths; in
5927 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5928 the resulting string length overflows an EMACS_INT; instead,
5929 report a string overflow if no precision given. When checking for
5930 precision exhaustion, use a check that cannot possibly have
5931 integer overflow. (Bug#8675)
5932 * character.h (lisp_string_width): Adjust to new signature.
5933
5934 * alloc.c (string_overflow): New function.
5935 (Fmake_string): Use it. This doesn't change behavior, but saves
5936 a few bytes and will simplify future changes.
5937 * character.c (string_escape_byte8): Likewise.
5938 * lisp.h (string_overflow): New decl.
5939
5940 Fixups, following up to the user-interface timestamp change.
5941 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5942 for UI timestamps, instead of unsigned long.
5943 * msdos.c (mouse_get_pos): Likewise.
5944 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5945 * w32gui.h (Time): Define by including "systime.h" rather than by
5946 declaring it ourselves. (Bug#8664)
5947
5948 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5949 * image.c (clear_image_cache): Likewise.
5950
5951 * term.c (term_mouse_position): Don't assume time_t wraparound.
5952
5953 Be more systematic about user-interface timestamps.
5954 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5955 and sometimes 'EMACS_UINT', to represent these timestamps.
5956 This change causes it to use 'Time' uniformly, as that's what X uses.
5957 This makes the code easier to follow, and makes it easier to catch
5958 integer overflow bugs such as Bug#8664.
5959 * frame.c (Fmouse_position, Fmouse_pixel_position):
5960 Use Time, not unsigned long, for user-interface timestamps.
5961 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5962 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5963 * keyboard.h (last_event_timestamp): Likewise.
5964 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5965 * menu.h (xmenu_show): Likewise.
5966 * term.c (term_mouse_position): Likewise.
5967 * termhooks.h (struct input_event.timestamp): Likewise.
5968 (struct terminal.mouse_position_hook): Likewise.
5969 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5970 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5971 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5972 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5973 what it was before.
5974 * menu.h, termhooks.h: Include "systime.h", for Time.
5975
5976 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5977 Don't assume that the difference between two unsigned long values
5978 can fit into an integer. At this point, we know button_down_time
5979 <= event->timestamp, so the difference must be nonnegative, so
5980 there's no need to cast the result if double-click-time is
5981 nonnegative, as it should be; check that it's nonnegative, just in
5982 case. This bug is triggered when events are more than 2**31 ms
5983 apart (about 25 days). (Bug#8664)
5984
5985 * xselect.c (last_event_timestamp): Remove duplicate decl.
5986 (x_own_selection): Remove needless cast to unsigned long.
5987
5988 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5989 that always fit in int. Use a sentinel instead of a counter, to
5990 avoid a temp and to allay GCC's concerns about possible int overflow.
5991 * frame.h (struct frame): Use int for menu_bar_items_used
5992 instead of EMACS_INT, since it always fits in int.
5993
5994 * menu.c (grow_menu_items): Check for int overflow.
5995
5996 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5997
5998 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5999 Before, the code was not consistent. These values cannot exceed
6000 2**31 - 1 so there's no need to make them unsigned.
6001 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6002 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6003 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6004 as modifiers.
6005 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6006
6007 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6008 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6009 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6010 presumably because the widths might not match.
6011
6012 * window.c (size_window): Avoid needless test at loop start.
6013
6014 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6015
6016 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6017
6018 2011-05-12 Drew Adams <drew.adams@oracle.com>
6019
6020 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6021
6022 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6023
6024 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6025 `width' to `bar_area_x' and `bar_area_width', respectively.
6026 (x_scroll_run): Take account of fringe background extension.
6027
6028 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6029 Rename local vars `left' and `width' to `bar_area_x' and
6030 `bar_area_width', respectively.
6031 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6032 background extension.
6033
6034 2011-05-10 Jim Meyering <meyering@redhat.com>
6035
6036 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6037
6038 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6039
6040 * image.c (Finit_image_library): Return t for built-in image types,
6041 like pbm and xbm. (Bug#8640)
6042
6043 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6044
6045 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6046
6047 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6048
6049 * w32console.c (Fset_screen_color): Doc fix.
6050 (Fget_screen_color): New function.
6051 (syms_of_ntterm): Defsubr it.
6052
6053 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6054 unlink the temporary file if Fcall_process didn't create it in the
6055 first place.
6056 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6057 child process will be redirected to a file specified with `:file'.
6058 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6059 cue to call_process_cleanup not to close that handle.
6060
6061 2011-05-07 Ben Key <bkey76@gmail.com>
6062
6063 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6064 one of two shell specific rules, either bootstrap-temacs-CMD or
6065 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6066 to the previous implementation of the bootstrap-temacs rule.
6067 The bootstrap-temacs-CMD rule is similar to the previous
6068 implementation of the bootstrap-temacs rule except that it
6069 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6070 variable.
6071
6072 These changes, along with some changes to nt/configure.bat,
6073 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6074 earlier fix to add support for --cflags and --ldflags options
6075 that include quotes so that it works whether make uses cmd or
6076 sh as the shell.
6077
6078 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6079
6080 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6081 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6082 is a constant.
6083 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6084 a string. Handle both cases.
6085 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6086 (Fdbus_register_method): Use Qinvalid_function.
6087
6088 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6089
6090 * makefile.w32-in: Update dependencies.
6091 (LISP_H): Add inttypes.h and stdin.h.
6092 (PROCESS_H): Add unistd.h.
6093
6094 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6095
6096 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6097 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6098
6099 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6100
6101 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6102
6103 * term.c (vfatal): Remove stray call to va_end.
6104 It's not needed and the C Standard doesn't allow it here anyway.
6105
6106 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6107 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6108
6109 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6110 bytes.
6111
6112 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6113
6114 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6115
6116 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6117
6118 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6119
6120 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6121
6122 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6123 * charset.c (Fdefine_charset_internal): Don't initialize
6124 charset.code_space[15]. The value was garbage, on hosts with
6125 32-bit int (Bug#8600).
6126
6127 * lread.c (read_integer): Be more consistent with string-to-number.
6128 Use string_to_number to do the actual conversion; this avoids
6129 rounding errors and fixes some other screwups. Without this fix,
6130 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6131 (digit_to_number): Move earlier, for benefit of read_integer.
6132 Return -1 if the digit is out of range for the base, -2 if it is
6133 not a digit in any supported base. (Bug#8602)
6134
6135 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6136
6137 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6138 to match comment at start of function. This also removes a
6139 GCC warning about overflow in a 32+64-bit port.
6140
6141 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6142
6143 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6144 Reported by Stefan Monnier in
6145 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6146 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6147 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6148
6149 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6150 (EMACS_UINTPTR): Likewise, with uintptr_t.
6151
6152 * lisp.h: Prefer 64-bit EMACS_INT if available.
6153 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6154 on 32-bit hosts that have 64-bit int, so that they can access
6155 large files.
6156 However, temporarily disable this change unless the temporary
6157 symbol WIDE_EMACS_INT is defined.
6158
6159 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6160
6161 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6162 This removes an assumption that EMACS_INT and long are the same
6163 width as pointers. The assumption is true for Emacs porting targets
6164 now, but we want to make other targets possible.
6165 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6166 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6167 In the rest of the code, change types of integers that hold casted
6168 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6169 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6170 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6171 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6172 No need to cast type when ORing.
6173 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6174 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6175 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6176 assume EMACS_INT is the same width as char *.
6177 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6178 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6179 Remove no-longer-needed casts.
6180 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6181 (xg_tool_bar_help_callback, xg_make_tool_item):
6182 Use EMACS_INTPTR to hold an integer
6183 that will be cast to void *; this can avoid a GCC warning
6184 if EMACS_INT is not the same width as void *.
6185 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6186 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6187 (current_message_1, set_message_1):
6188 Use a local to convert to proper width without a cast.
6189 * xmenu.c (dialog_selection_callback): Likewise.
6190
6191 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6192 Also, don't assume VALBITS / RAND_BITS is less than 5,
6193 and don't rely on undefined behavior when shifting a 1 left into
6194 the sign bit.
6195 * lisp.h (get_random): Change signature to match.
6196
6197 * lread.c (hash_string): Use size_t, not int, for hash computation.
6198 Normally we prefer signed values; but hashing is special, because
6199 it's better to use unsigned division on hash table sizes so that
6200 the remainder is nonnegative. Also, size_t is the natural width
6201 for hashing into memory. The previous code used 'int', which doesn't
6202 retain enough info to hash well into very large tables.
6203 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6204
6205 * dbusbind.c: Don't possibly lose pointer info when converting.
6206 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6207 Use XPNTR rather than XHASH, so that the high-order bits of
6208 the pointer aren't lost when converting through void *.
6209
6210 * eval.c (Fautoload): Don't double-shift a pointer.
6211
6212 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6213
6214 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6215
6216 * gnutls.c (DEF_GNUTLS_FN):
6217 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6218
6219 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6220
6221 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6222 marker. (Bug#8610)
6223
6224 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6225
6226 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6227 New version that can reserve upto 2GB of heap space.
6228
6229 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6230
6231 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6232
6233 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6234
6235 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6236 `gnutls_certificate_set_x509_key_file'.
6237
6238 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6239
6240 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6241 Update dependencies.
6242
6243 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6244
6245 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6246 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6247 Remove unused parameter `fildes'.
6248 * process.c (read_process_output, send_process): Don't pass it.
6249
6250 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6251
6252 Fix previous change: the library cache is defined in w32.c.
6253 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6254 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6255
6256 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6257
6258 Implement dynamic loading of GnuTLS on Windows.
6259
6260 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6261 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6262 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6263 Declare.
6264
6265 * gnutls.c (Qgnutls_dll): Define.
6266 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6267 (gnutls_*): Declare function pointers.
6268 (init_gnutls_functions): New function to initialize function pointers.
6269 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6270 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6271 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6272 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6273 (emacs_gnutls_write, emacs_gnutls_read)
6274 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6275 (Fgnutls_available_p): New function.
6276 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6277 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6278 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6279
6280 * image.c: Include w32.h.
6281 (Vimage_type_cache): Delete.
6282 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6283 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6284 (w32_delayed_load): Move to w32.c.
6285
6286 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6287
6288 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6289 (w32_delayed_load): Move from image.c. When loading a library, record
6290 its filename in the :loaded-from property of the library id.
6291 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6292 Initialize and staticpro them.
6293 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6294
6295 * process.c: Include lisp.h before w32.h, not after.
6296 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6297 instead of gnutls_record_check_pending.
6298
6299 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6300
6301 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6302
6303 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6304 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6305 as passed in.
6306
6307 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6308
6309 * xterm.c (x_set_frame_alpha): Do not set property on anything
6310 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6311
6312 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6313
6314 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6315
6316 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6317
6318 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6319 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6320 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6321 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6322 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6323 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6324 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6325 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6326 (Qgnutls_bootprop_callbacks_verify): Make static.
6327
6328 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6329
6330 * callproc.c: Indentation fixup.
6331
6332 * sysdep.c (wait_for_termination_1): Make static.
6333 (wait_for_termination, interruptible_wait_for_termination):
6334 Move after wait_for_termination_1.
6335
6336 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6337
6338 * sysdep.c (interruptible_wait_for_termination): New function
6339 which is like wait_for_termination, but allows keyboard
6340 interruptions.
6341
6342 * callproc.c (Fcall_process): Add (:file "file") as an option for
6343 the STDOUT buffer.
6344 (Fcall_process_region): Ditto.
6345
6346 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6347
6348 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6349 rather than `XVECTOR (FOO)->size'.
6350
6351 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6352 inttypes.h, as a gnulib replacement is used if it not available in
6353 system headers.
6354
6355 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6356
6357 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6358 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6359 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6360
6361 * coding.c (coding_alloc_by_realloc): Error out if destination
6362 will grow beyond MOST_POSITIVE_FIXNUM.
6363 (decode_coding_emacs_mule): Abort if there isn't enough place in
6364 charbuf for the composition carryover bytes. Reserve an extra
6365 space for up to 2 characters produced in a loop.
6366 (decode_coding_iso_2022): Abort if there isn't enough place in
6367 charbuf for the composition carryover bytes.
6368
6369 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6370
6371 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6372 aborting when %lld or %lll format is passed.
6373 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6374 %llo or %llx format is passed. (Bug#8545)
6375
6376 * window.c (window_scroll_line_based): Use a marker instead of
6377 simple variables to record original value of point. (Bug#7952)
6378
6379 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6380 produced by %s or %c overflows available buffer space. (Bug#8545)
6381
6382 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6383
6384 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6385 (SIZE_MAX): Move defn after all includes, as they might #define it.
6386
6387 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6388
6389 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6390
6391 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6392
6393 * keyboard.c (Qdelayed_warnings_hook): Define.
6394 (command_loop_1): Run `delayed-warnings-hook'
6395 if Vdelayed_warnings_list is non-nil.
6396 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6397 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6398
6399 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6400
6401 * doprnt.c (doprnt): Don't return value smaller than the buffer
6402 size if the message was truncated. (Bug#8545).
6403
6404 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6405
6406 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6407 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6408
6409 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6410
6411 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6412
6413 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6414
6415 * makefile.w32-in: Update dependencies.
6416
6417 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6418
6419 Improve `doprnt' and its usage. (Bug#8545)
6420 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6421 `format_end'. Remove support for %l as a conversion specifier.
6422 Don't use xrealloc. Improve diagnostics when the %l size modifier
6423 is used. Update the commentary.
6424
6425 * eval.c (verror): Simplify calculation of size_t.
6426
6427 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6428 messages.
6429
6430 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6431
6432 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6433 change.
6434
6435 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6436
6437 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6438 This makes this file independent of the recent pseudovector change.
6439
6440 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6441
6442 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6443
6444 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6445 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6446 Remove unused local.
6447 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6448
6449 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6450 GCC 4.6.0 optimizes based on type-based alias analysis.
6451 For example, if b is of type struct buffer * and v of type struct
6452 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6453 != &v->size, and therefore "v->size = 1; b->size = 2; return
6454 v->size;" must therefore return 1. This assumption is incorrect
6455 for Emacs, since it type-puns struct Lisp_Vector * with many other
6456 types. To fix this problem, this patch adds a new type struct
6457 vectorlike_header that documents the constraints on layout of vectors
6458 and pseudovectors, and helps optimizing compilers not get fooled
6459 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6460 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6461 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6462 the size member.
6463 (XSETPVECTYPE): Rewrite in terms of new macro.
6464 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6465 This is a bit clearer, and further avoids the possibility of
6466 undesirable aliasing.
6467 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6468 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6469 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6470 since Lisp_Subr is a special case (no "next" field).
6471 (ASIZE): Now uses header.size rather than size.
6472 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6473 to avoid the hassle of writing XVECTOR (foo)->header.size.
6474 (struct vectorlike_header): New type.
6475 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6476 object, to help avoid aliasing.
6477 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6478 (SUBRP): Likewise, since Lisp_Subr is a special case.
6479 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6480 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6481 (struct Lisp_Hash_Table): Combine first two members into a single
6482 struct vectorlike_header member. All uses of "size" and "next" members
6483 changed to be "header.size" and "header.next".
6484 * buffer.h (struct buffer): Likewise.
6485 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6486 * frame.h (struct frame): Likewise.
6487 * process.h (struct Lisp_Process): Likewise.
6488 * termhooks.h (struct terminal): Likewise.
6489 * window.c (struct save_window_data, struct saved_window): Likewise.
6490 * window.h (struct window): Likewise.
6491 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6492 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6493 * buffer.c (init_buffer_once): Likewise.
6494 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6495 special case.
6496 * process.c (Fformat_network_address): Use local var for size,
6497 for brevity.
6498
6499 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6500
6501 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6502 * data.c (atof): Remove decl; no longer used or needed.
6503 (digit_to_number): Move to lread.c.
6504 (Fstring_to_number): Use new string_to_number function, to be
6505 consistent with how the Lisp reader treats infinities and NaNs.
6506 Do not assume that floating-point numbers represent EMACS_INT
6507 without losing information; this is not true on most 64-bit hosts.
6508 Avoid double-rounding errors, by insisting on integers when
6509 parsing non-base-10 numbers, as the documentation specifies.
6510 * lisp.h (string_to_number): New decl, replacing ...
6511 (isfloat_string): Remove.
6512 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6513 (read1): Do not accept +. and -. as integers; this
6514 appears to have been a coding error. Similarly, do not accept
6515 strings like +-1e0 as floating point numbers. Do not report
6516 overflow for integer overflows unless the base is not 10 which
6517 means we have no simple and reliable way to continue.
6518 Break out the floating-point parsing into a new
6519 function string_to_number, so that Fstring_to_number parses
6520 floating point numbers consistently with the Lisp reader.
6521 (digit_to_number): Move here from data.c. Make it static inline.
6522 (E_CHAR, EXP_INT): Remove, replacing with ...
6523 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6524 (string_to_number): New function, replacing isfloat_string.
6525 This function checks for valid syntax and produces the resulting
6526 Lisp float number too. Rework it so that string-to-number
6527 no longer mishandles examples like "1.0e+". Use strtoumax,
6528 so that overflow for non-base-10 numbers is reported only when
6529 there's no portable and simple way to convert to floating point.
6530
6531 * textprop.c (set_text_properties_1): Rewrite for clarity,
6532 and to avoid GCC warning about integer overflow.
6533
6534 * intervals.h (struct interval): Use EMACS_INT for members
6535 where EMACS_UINT might cause problems. See
6536 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6537 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6538 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6539 All uses changed.
6540 (offset_intervals): Tell GCC not to worry about length overflow
6541 when negating a negative length.
6542
6543 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6544 (overrun_check_free): Likewise.
6545
6546 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6547 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6548 word size.
6549
6550 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6551 (gnutls_make_error): Rename local to avoid shadowing.
6552 (gnutls_emacs_global_deinit): ifdef out; not used.
6553 (Fgnutls_boot): Use const for pointer to readonly storage.
6554 Comment out unused local. Fix pointer signedness problems.
6555
6556 * lread.c (openp): Don't stuff size_t into an 'int'.
6557 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6558 about possible signed overflow.
6559
6560 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6561 (GDK_KEY_g): Don't define if already defined.
6562 (xg_prepare_tooltip): Avoid pointer signedness problem.
6563 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6564
6565 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6566 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6567
6568 * xfns.c (Fx_window_property): Simplify a bit,
6569 to make a bit faster and to avoid GCC 4.6.0 warning.
6570 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6571
6572 * fns.c (internal_equal): Don't assume size_t fits in int.
6573
6574 * alloc.c (compact_small_strings): Tighten assertion a little.
6575
6576 Replace pEd with more-general pI, and fix some printf arg casts.
6577 * lisp.h (pI): New macro, generalizing old pEd macro to other
6578 conversion specifiers. For example, use "...%"pI"d..." rather
6579 than "...%"pEd"...".
6580 (pEd): Remove. All uses replaced with similar uses of pI.
6581 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6582 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6583 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6584 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6585 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6586 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6587 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6588 64-bit hosts.
6589 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6590 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6591 * print.c (safe_debug_print, print_object): Likewise.
6592 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6593 to int.
6594 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6595 avoiding the 0 flag, which is not portable.
6596 * process.c (Fmake_network_process): Use pI to avoid cast.
6597 * region-cache.c (pp_cache): Likewise.
6598 * xdisp.c (decode_mode_spec): Likewise.
6599 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6600 behavior on 64-bit hosts with printf arg.
6601 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6602 (x_stop_queuing_selection_requests): Likewise.
6603 (x_get_window_property): Don't truncate byte count to an 'int'
6604 when tracing.
6605
6606 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6607 here, since it parses constructs like leading '-' and spaces,
6608 which are not wanted; and it overflows with large numbers.
6609 Instead, simply match F[0-9]+, which is what is wanted anyway.
6610
6611 * alloc.c: Remove unportable assumptions about struct layout.
6612 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6613 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6614 (allocate_vectorlike, make_pure_vector): Use the new macros,
6615 plus offsetof, to remove unportable assumptions about struct layout.
6616 These assumptions hold on all porting targets that I know of, but
6617 they are not guaranteed, they're easy to remove, and removing them
6618 makes further changes easier.
6619
6620 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6621 This doesn't fix a bug but makes the code clearer.
6622 (string_overrun_cookie): Now const. Use initializers that
6623 don't formally overflow signed char, to avoid warnings.
6624 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6625 can cause Emacs to crash when string overrun checking is enabled.
6626 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6627 multiple of sizeof (EMACS_INT); it need not be, if
6628 alignof(EMACS_INT) < sizeof (EMACS_INT).
6629 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6630
6631 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6632
6633 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6634
6635 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6636
6637 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6638 supposed to be handshaking. (Bug#8556)
6639 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6640
6641 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6642
6643 * lisp.h (Qdebug): List symbol.
6644 * eval.c (Qdebug): Restore global linkage.
6645 * keyboard.c (debug-on-event): New variable.
6646 (handle_user_signal): Break into debugger when debug-on-event
6647 matches the current signal symbol.
6648
6649 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6650
6651 * alloc.c (check_sblock, check_string_bytes)
6652 (check_string_free_list): Convert to standard C.
6653
6654 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6655
6656 * w32.c (emacs_gnutls_push): Fix typo.
6657
6658 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6659
6660 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6661 "cast to pointer from integer of different size".
6662
6663 Improve doprnt and its use in verror. (Bug#8545)
6664 * doprnt.c (doprnt): Document the set of format control sequences
6665 supported by the function. Use SAFE_ALLOCA instead of always
6666 using `alloca'.
6667
6668 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6669 is one byte too soon. Don't use xrealloc; instead xfree and
6670 xmalloc anew.
6671
6672 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6673
6674 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6675 callbacks stage.
6676
6677 * gnutls.c: Renamed global_initialized to
6678 gnutls_global_initialized. Added internals for the
6679 :verify-hostname-error, :verify-error, and :verify-flags
6680 parameters of `gnutls-boot' and documented those parameters in the
6681 docstring. Start callback support.
6682 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6683 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6684 on error. Return error code.
6685 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6686 (emacs_gnutls_read): Likewise.
6687 (Fgnutls_boot): Return handshake error code.
6688 (emacs_gnutls_handle_error): New function.
6689 (wsaerror_to_errno): Likewise.
6690
6691 * w32.h (emacs_gnutls_pull): Add prototype.
6692 (emacs_gnutls_push): Likewise.
6693
6694 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6695 (emacs_gnutls_push): Likewise.
6696
6697 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6698
6699 * process.c (wait_reading_process_output): Check if GnuTLS
6700 buffered some data internally if no FDs are set for TLS
6701 connections.
6702
6703 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6704 (LIBS): Link to USER_LIBS.
6705 ($(BLD)/gnutls.$(0)): New target.
6706
6707 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6708
6709 * xdisp.c (handle_single_display_spec): Rename the
6710 display_replaced_before_p argument into display_replaced_p, to
6711 make it consistent with the commentary. Fix typos in the
6712 commentary.
6713
6714 * textprop.c (syms_of_textprop): Remove dead code.
6715 (copy_text_properties): Delete obsolete commentary about an
6716 interface that was deleted long ago. Fix typos in the description
6717 of arguments.
6718
6719 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6720 to changes in oldXMenu/XMenu.h from 2011-04-16.
6721 <menu_help_message, prev_menu_help_message>: Constify.
6722 (IT_menu_make_room): menu->help_text is now `const char **';
6723 adjust.
6724
6725 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6726 to changes in oldXMenu/XMenu.h from 2011-04-16.
6727 (struct XMenu): Declare `help_text' `const char **'.
6728
6729 * xfaces.c <Qunspecified>: Make extern again.
6730
6731 * syntax.c: Include sys/types.h before including regex.h, as
6732 required by Posix.
6733
6734 * doc.c (get_doc_string): Improve the format passed to `error'.
6735
6736 * doprnt.c (doprnt): Improve commentary.
6737
6738 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6739
6740 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6741 them with etags.
6742
6743 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6744 changes in globals.h immediately force recompilation.
6745 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6746 $(CURDIR)/s/ms-w32.h.
6747 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6748
6749 * character.c (Fchar_direction): Function deleted.
6750 (syms_of_character): Don't defsubr it.
6751 <char-direction-table>: Deleted.
6752
6753 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6754
6755 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6756 * doprnt.c: Include limits.h.
6757 (SIZE_MAX): New macro.
6758 (doprnt): Return a size_t value. 2nd arg is now size_t.
6759 Many local variables are now size_t instead of int or unsigned.
6760 Improve overflow protection. Support `l' modifier for integer
6761 conversions. Support %l conversion. Don't assume an EMACS_INT
6762 argument for integer conversions and for %c.
6763
6764 * lisp.h (doprnt): Restore prototype.
6765
6766 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6767 $(SRC)/character.h.
6768
6769 * Makefile.in (base_obj): Add back doprnt.o.
6770
6771 * deps.mk (doprnt.o): Add back prerequisites.
6772 (callint.o): Depend on character.h.
6773
6774 * eval.c (internal_lisp_condition_case): Include the handler
6775 representation in the error message.
6776 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6777 when breaking from the loop.
6778
6779 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6780
6781 * callint.c (Fcall_interactively): When displaying error message
6782 about invalid control letter, pass the character's codepoint, not
6783 a pointer to its multibyte form. Improve display of the character
6784 in octal and display also its hex code.
6785
6786 * character.c (char_string): Use %x to display the (unsigned)
6787 codepoint of an invalid character, to avoid displaying a bogus
6788 negative value.
6789
6790 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6791 `error', not SYMBOL_NAME itself.
6792
6793 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6794 character arguments to `error'.
6795
6796 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6797 to `error' in error message about FINAL_CHAR argument. Make sure
6798 FINAL_CHAR is a character, and use %c when it is passed as
6799 argument to `error'.
6800
6801 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6802
6803 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6804
6805 * w32.c: Include <time.h>.
6806 (sys_localtime): New function.
6807
6808 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6809
6810 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6811
6812 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6813
6814 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6815
6816 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6817 zombies (Bug#8467).
6818
6819 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6820
6821 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6822 gl_state.e_property when gl_state.object is Qt.
6823
6824 * insdel.c (make_gap_larger): Remove limitation of buffer size
6825 to <= INT_MAX.
6826
6827 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6828
6829 * xdisp.c (lookup_glyphless_char_display)
6830 (produce_glyphless_glyph): Handle cons cell entry in
6831 glyphless-char-display.
6832 (Vglyphless_char_display): Document it.
6833
6834 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6835 glyphless-char-display.
6836
6837 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6838
6839 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6840
6841 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6842
6843 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6844 definition for no-X builds.
6845
6846 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6847
6848 Static checks with GCC 4.6.0 and non-default toolkits.
6849
6850 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6851
6852 * process.c (keyboard_bit_set): Define only if SIGIO.
6853 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6854 (send_process): Repair possible setjmp clobbering.
6855
6856 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6857
6858 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6859
6860 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6861
6862 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6863 Define only if needed.
6864
6865 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6866 by pacifying GCC about it. Maybe it's time to retire it?
6867 * xfaces.c (USG, __TIMEVAL__): Likewise.
6868
6869 * dispextern.h (struct redisplay_interface): Rename param
6870 to avoid shadowing.
6871 * termhooks.h (struct terminal): Likewise.
6872 * xterm.c (xembed_send_message): Likewise.
6873
6874 * insdel.c (make_gap_smaller): Define only if
6875 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6876
6877 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6878 it.
6879
6880 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6881 so that we aren't warned about unused symbols.
6882
6883 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6884
6885 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6886
6887 * xfns.c (x_real_positions): Mark locals as initialized.
6888
6889 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6890
6891 * xterm.c: Fix problems found by static analysis with other toolkits.
6892 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6893 (x_dispatch_event): Declare static if USE_GTK, and
6894 define if USE_GTK || USE_X_TOOLKIT.
6895 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6896 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6897 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6898 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6899
6900 * xmenu.c (menu_help_callback): Pointer type fixes.
6901 Use const pointers when pointing at readonly data. Avoid pointer
6902 signedness clashes.
6903 (FALSE): Remove unused macro.
6904 (update_frame_menubar): Remove unused decl.
6905
6906 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6907
6908 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6909 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6910 (single_menu_item): Rename local to avoid shadowing.
6911
6912 * keyboard.c (make_lispy_event): Remove unused local var.
6913
6914 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6915 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6916
6917 * bitmaps: Change bitmaps from unsigned char back to the X11
6918 compatible char. Avoid the old compiler warnings about
6919 out-of-range initializers by using, for example, '\xab' rather
6920 than 0xab.
6921
6922 * xgselect.c (xgselect_initialize): Check vs interface
6923 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6924
6925 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6926
6927 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6928 to read-only memory.
6929
6930 * fns.c (vector): Remove; this old hack is no longer needed.
6931
6932 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6933 Remove unused var.
6934 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6935
6936 * xrdb.c (x_load_resources): Omit unused local.
6937
6938 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6939 (x_window): Rename locals to avoid shadowing.
6940 (USG): Use the kludged USG macro, to pacify gcc.
6941
6942 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6943 (x_term_init): Remove local to avoid shadowing.
6944
6945 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6946
6947 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6948 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6949
6950 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6951
6952 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6953
6954 Fix regex.c, syntax.c and friends for buffers > 2GB.
6955 * syntax.h (struct gl_state_s): Declare character position members
6956 EMACS_INT.
6957
6958 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6959
6960 * textprop.c (verify_interval_modification, interval_of):
6961 Declare arguments EMACS_INT.
6962
6963 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6964 EMACS_INT.
6965
6966 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6967
6968 * indent.c (Fvertical_motion): Local variable it_start is now
6969 EMACS_INT.
6970
6971 * regex.c (re_match, re_match_2, re_match_2_internal)
6972 (bcmp_translate, regcomp, regexec, print_double_string)
6973 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6974 (re_compile_pattern, re_exec): Declare arguments and local
6975 variables `size_t' and `ssize_t' and return values `regoff_t', as
6976 appropriate.
6977 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6978 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6979 <compile_stack_type>: `size' and `avail' are now `size_t'.
6980
6981 * regex.h <regoff_t>: Use ssize_t, not int.
6982 (re_search, re_search_2, re_match, re_match_2): Arguments that
6983 specify buffer/string position and length are now ssize_t and
6984 size_t. Return type is regoff_t.
6985
6986 2011-04-16 Ben Key <bkey76@gmail.com>
6987
6988 * nsfont.m: Fixed bugs in ns_get_family and
6989 ns_descriptor_to_entity that were caused by using free to
6990 deallocate memory blocks that were allocated by xmalloc (via
6991 xstrdup). This caused Emacs to crash when compiled with
6992 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6993 --enable-checking=xmallocoverrun). xfree is now used to
6994 deallocate these memory blocks.
6995
6996 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6997
6998 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6999
7000 emacs_write: Accept and return EMACS_INT for sizes.
7001 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7002 et seq.
7003 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7004 Accept and return EMACS_INT.
7005 (emacs_gnutls_write): Return the number of bytes written on
7006 partial writes.
7007 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7008 (emacs_read, emacs_write): Remove check for negative size, as the
7009 Emacs source code has been audited now.
7010 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7011 (emacs_read, emacs_write): Use it.
7012 * process.c (send_process): Adjust to the new signatures of
7013 emacs_write and emacs_gnutls_write. Do not attempt to store
7014 a byte offset into an 'int'; it might overflow.
7015 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7016
7017 * sound.c: Don't assume sizes fit in 'int'.
7018 (struct sound_device.period_size, alsa_period_size):
7019 Return EMACS_INT, not int.
7020 (struct sound_device.write, vox_write, alsa_write):
7021 Accept EMACS_INT, not int.
7022 (wav_play, au_play): Use EMACS_INT to store sizes and to
7023 record read return values.
7024
7025 2011-04-15 Ben Key <bkey76@gmail.com>
7026
7027 * keyboard.c (Qundefined): Don't declare static since it is used
7028 in nsfns.m.
7029 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7030 static since they are used in nsfont.m.
7031
7032 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7033
7034 * process.c (Qprocessp): Don't declare static.
7035 * lisp.h (Qprocessp): Declare again.
7036
7037 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7038
7039 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7040
7041 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7042
7043 Improve C-level modularity by making more things 'static'.
7044
7045 Don't publish debugger-only interfaces to other modules.
7046 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7047 (verify_bytepos, count_markers): Move decls to the only modules
7048 that need them.
7049 * region-cache.h (pp_cache): Likewise.
7050 * window.h (check_all_windows): Likewise.
7051 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7052
7053 * sysdep.c (croak): Now static, if
7054 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7055 * syssignal.h (croak): Declare only if not static.
7056
7057 * alloc.c (refill_memory_reserve): Now static if
7058 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7059 * lisp.h (refill_memory_reserve): Declare only if not static.
7060
7061 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7062 Define only if USE_LUCID.
7063
7064 * xrdb.c (x_customization_string, x_rm_string): Now static.
7065
7066 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7067 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7068
7069 * xdisp.c (draw_row_with_mouse_face): Now static.
7070 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7071
7072 * window.h (check_all_windows): Mark externally visible.
7073
7074 * window.c (window_deletion_count): Now static.
7075
7076 * undo.c: Make symbols static if they're not exported.
7077 (last_undo_buffer, last_boundary_position, pending_boundary):
7078 Now static.
7079
7080 * textprop.c (interval_insert_behind_hooks): Now static.
7081 (interval_insert_in_front_hooks): Likewise.
7082
7083 * term.c: Make symbols static if they're not exported.
7084 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7085 (max_frame_lines, tty_set_terminal_modes):
7086 (tty_reset_terminal_modes, tty_turn_off_highlight):
7087 (get_tty_terminal): Now static.
7088 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7089 * termhooks.h (term_mouse_moveto): Do not declare if
7090 HAVE_WINDOW_SYSTEM.
7091 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7092 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7093
7094 * sysdep.c: Make symbols static if they're not exported.
7095 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7096 Now static.
7097 (sigprocmask_set, full_mask): Remove; unused.
7098 (wait_debugging): Mark as visible.
7099 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7100 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7101
7102 * syntax.c (syntax_temp): Define only if !__GNUC__.
7103
7104 * sound.c (current_sound_device, current_sound): Now static.
7105
7106 * search.c (searchbufs, searchbuf_head): Now static.
7107
7108 * scroll.c (scroll_cost): Remove; unused.
7109 * dispextern.h (scroll_cost): Remove decl.
7110
7111 * region-cache.h (pp_cache): Mark as externally visible.
7112
7113 * process.c: Make symbols static if they're not exported.
7114 (process_tick, update_tick, create_process, chan_process):
7115 (Vprocess_alist, proc_buffered_char, datagram_access):
7116 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7117 (deactivate_process): Mark defn as static, as well as decl.
7118 * lisp.h (create_process): Remove decl.
7119 * process.h (chan_process, Vprocess_alist): Remove decls.
7120
7121 * print.c: Make symbols static if they're not exported.
7122 (print_depth, new_backquote_output, being_printed, print_buffer):
7123 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7124 (print_interval, print_number_index, initial_stderr_stream):
7125 Now static.
7126 * lisp.h (Fprinc): Remove decl.
7127 (debug_output_compilation_hack): Mark as externally visible.
7128
7129 * sysdep.c (croak): Move decl from here to syssignal.h.
7130 * syssignal.h (croak): Put it here, so the API can be checked when
7131 'croak' is called from dissociate_if_controlling_tty.
7132
7133 * minibuf.c: Make symbols static if they're not exported.
7134 (minibuf_save_list, choose_minibuf_frame): Now static.
7135 * lisp.h (choose_minibuf_frame): Remove decl.
7136
7137 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7138
7139 * lread.c: Make symbols static if they're not exported.
7140 (read_objects, initial_obarray, oblookup_last_bucket_number):
7141 Now static.
7142 (make_symbol): Remove; unused.
7143 * lisp.h (initial_obarray, make_symbol): Remove decls.
7144
7145 * keyboard.c: Make symbols static if they're not exported.
7146 (single_kboard, recent_keys_index, total_keys, recent_keys):
7147 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7148 (this_single_command_key_start, echoing, last_auto_save):
7149 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7150 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7151 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7152 (Vlispy_mouse_stem, double_click_count):
7153 Now static.
7154 (force_auto_save_soon): Define only if SIGDANGER.
7155 (ignore_mouse_drag_p): Now static if
7156 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7157 (print_help): Remove; unused.
7158 (stop_character, last_timer_event): Mark as externally visible.
7159 * keyboard.h (ignore_mouse_drag_p): Declare only if
7160 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7161 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7162 * lisp.h (echoing): Remove decl.
7163 (force_auto_save_soon): Declare only if SIGDANGER.
7164 * xdisp.c (redisplay_window): Simplify code, to make it more
7165 obvious that ignore_mouse_drag_p is not accessed if !defined
7166 USE_GTK && !defined HAVE_NS.
7167
7168 * intervals.c: Make symbols static if they're not exported.
7169 (merge_properties_sticky, merge_interval_right, delete_interval):
7170 Now static.
7171 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7172
7173 * insdel.c: Make symbols static if they're not exported.
7174 However, leave prepare_to_modify_buffer alone. It's never
7175 called from outside this function, but that appears to be a bug.
7176 (combine_after_change_list, combine_after_change_buffer):
7177 (adjust_after_replace, signal_before_change): Now static.
7178 (adjust_after_replace_noundo): Remove; unused.
7179 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7180 (signal_before_change): Remove decls.
7181
7182 * indent.c (val_compute_motion, val_vmotion): Now static.
7183
7184 * image.c: Make symbols static if they're not exported.
7185 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7186 if USE_GTK.
7187 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7188 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7189
7190 * fringe.c (standard_bitmaps): Now static.
7191 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7192
7193 * frame.c: Make symbols static if they're not exported.
7194 (x_report_frame_params, make_terminal_frame): Now static.
7195 (get_frame_param): Now static, unless HAVE_NS.
7196 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7197 (x_get_resource_string): Remove; not used.
7198 * frame.h (make_terminal_frame, x_report_frame_params):
7199 (x_get_resource_string); Remove decls.
7200 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7201 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7202
7203 * font.c, fontset.c: Make symbols static if they're not exported.
7204 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7205 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7206 * font.c (font_close_object): Now static.
7207 * font.h (font_close_object): Remove.
7208 * fontset.c (FONTSET_OBJLIST): Remove.
7209 (free_realized_fontset) #if-0 the body, which does nothing.
7210 (face_suitable_for_char_p): #if-0, as it's never called.
7211 * fontset.h (face_suitable_for_char_p): Remove decl.
7212 * xfaces.c (face_at_string_position):
7213 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7214 since 0 is always ASCII.
7215
7216 * fns.c (weak_hash_tables): Now static.
7217
7218 * fileio.c: Make symbols static if they're not exported.
7219 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7220 (Vwrite_region_annotation_buffers): Now static.
7221
7222 * eval.c: Make symbols static if they're not exported.
7223 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7224 * lisp.h (backtrace_list): Remove decl.
7225
7226 * emacs.c: Make symbols static if they're not exported.
7227 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7228 (fatal_error_code, fatal_error_signal_hook, standard_args):
7229 Now static.
7230 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7231 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7232 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7233 * lisp.h (fatal_error_signal_hook): Remove decl.
7234 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7235
7236 * editfns.c: Move a (normally-unused) function to its only use.
7237 * editfns.c, lisp.h (get_operating_system_release): Remove.
7238 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7239 worth the hassle of breaking this out.
7240
7241 * xterm.c: Make symbols static if they're not exported.
7242 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7243 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7244 (x_destroy_window, x_delete_display):
7245 Now static.
7246 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7247 (x_mouse_leave): Remove; unused.
7248 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7249 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7250 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7251 Remove decls.
7252 (x_mouse_leave): Declare only if WINDOWSNT.
7253 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7254 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7255 USE_X_TOOLKIT.
7256
7257 * ftxfont.c: Make symbols static if they're not exported.
7258 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7259 HAVE_FREETYPE.
7260 * font.h (ftxfont_driver): Likewise.
7261
7262 * xfns.c: Make symbols static if they're not exported.
7263 (x_last_font_name, x_display_info_for_name):
7264 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7265 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7266 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7267 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7268 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7269 (last_show_tip_args): Now static.
7270 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7271 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7272 (x_screen_planes): Remove; unused.
7273 * dispextern.h (x_screen_planes): Remove decl.
7274
7275 * dispnew.c: Make symbols static if they're not exported.
7276 * dispextern.h (redraw_garbaged_frames, scrolling):
7277 (increment_row_positions): Remove.
7278 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7279 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7280 Now static.
7281 (redraw_garbaged_frames): Remove; unused.
7282
7283 * xfaces.c: Make symbols static if they're not exported.
7284 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7285 Remove decls.
7286 * xterm.h (defined_color): Remove decls.
7287 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7288 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7289 (menu_face_changed_default, defined_color, free_realized_face):
7290 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7291 (ascii_face_of_lisp_face): Remove; unused.
7292
7293 * xdisp.c: Make symbols static if they're not exported.
7294 * dispextern.h (scratch_glyph_row, window_box_edges):
7295 (glyph_to_pixel_coords, set_cursor_from_row):
7296 (get_next_display_element, set_iterator_to_next):
7297 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7298 (show_mouse_face): Remove decls
7299 * frame.h (message_buf_print): Likewise.
7300 * lisp.h (pop_message, set_message, check_point_in_composition):
7301 Likewise.
7302 * xterm.h (set_vertical_scroll_bar): Likewise.
7303 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7304 (message_buf_print, scratch_glyph_row, displayed_buffer):
7305 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7306 (get_next_display_element, show_mouse_face, window_box_edges):
7307 (frame_to_window_pixel_xy, check_point_in_composition):
7308 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7309 (glyph_to_pixel_coords): Remove; unused.
7310
7311 * dired.c (file_name_completion): Now static.
7312
7313 * dbusbind.c (xd_in_read_queued_messages): Now static.
7314
7315 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7316 * data.c (circular_list_error): Remove.
7317
7318 * commands.h (last_point_position, last_point_position_buffer):
7319 (last_point_position_window): Remove decls.
7320 * keyboard.c: Make these variables static.
7321
7322 * coding.h (coding, code_convert_region, encode_coding_gap):
7323 Remove decls.
7324 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7325 (iso_code_class, detect_coding, code_convert_region): Now static.
7326 (encode_coding_gap): Remove; unused.
7327
7328 * chartab.c (chartab_chars, chartab_bits): Now static.
7329
7330 * charset.h (charset_iso_8859_1): Remove decl.
7331 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7332 Now static.
7333
7334 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7335 * ccl.c (Vccl_program_table): Now static.
7336 (check_ccl_update): Remove; unused.
7337
7338 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7339 * category.h: ... from here.
7340 * category.c (check_category_table, set_category_set): Now static.
7341
7342 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7343 * lisp.h: Remove these decls.
7344
7345 * buffer.c (buffer_count): Remove unused var.
7346
7347 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7348 so that it's not optimized away.
7349 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7350 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7351 exported only to the debugger.
7352
7353 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7354 * atimer.h (run_all_atimers): Remove; not exported.
7355
7356 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7357 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7358 was inaccessible from Lisp.
7359 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7360 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7361
7362 alloc.c: Import and export fewer symbols, and remove unused items.
7363 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7364 is defined.
7365 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7366 it's not optimized away by whole-program optimization.
7367 (message_enable_multibyte, free_misc): Remove.
7368 (catchlist, handlerlist, mark_backtrace):
7369 Declare only if BYTE_MARK_STACK.
7370 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7371 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7372 (message_enable_multibyte): Remove decl.
7373 (free_misc, interval_free_list, float_block, float_block_index):
7374 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7375 (cons_free_list, last_marked_index):
7376 Now static.
7377 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7378 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7379 (mark_backtrace): Define only if BYTE_MARK_STACK.
7380 * xdisp.c (message_enable_multibyte): Now static.
7381
7382 Declare Lisp_Object Q* variables to be 'static' if not exported.
7383 This makes it easier for human readers (and static analyzers)
7384 to see whether these variables are used from other modules.
7385 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7386 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7387 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7388 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7389 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7390 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7391 * xmenu.c, xselect.c:
7392 Declare Q* vars static if they are not used in other modules.
7393 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7394 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7395 Remove decls of unexported vars.
7396 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7397
7398 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7399
7400 Make Emacs functions such as Fatom 'static' by default.
7401 This makes it easier for human readers (and static analyzers)
7402 to see whether these functions can be called from other modules.
7403 DEFUN now defines a static function. To make the function external
7404 so that it can be used in other C modules, use the new macro DEFUE.
7405 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7406 (Finit_image_library):
7407 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7408 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7409 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7410 Remove decls, since these functions are now static.
7411 (Funintern, Fget_internal_run_time): New decls, since these functions
7412 were already external.
7413
7414 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7415 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7416 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7417 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7418 * keyboard.c, keymap.c, lread.c:
7419 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7420 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7421 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7422 Mark functions with DEFUE instead of DEFUN,
7423 if they are used in other modules.
7424 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7425 decls for now-static functions.
7426 * buffer.h (Fdelete_overlay): Remove decl.
7427 * callproc.c (Fgetenv_internal): Mark as internal.
7428 * composite.c (Fremove_list_of_text_properties): Remove decl.
7429 (Fcomposition_get_gstring): New forward static decl.
7430 * composite.h (Fcomposite_get_gstring): Remove decl.
7431 * dired.c (Ffile_attributes): New forward static decl.
7432 * doc.c (Fdocumntation_property): New forward static decl.
7433 * eval.c (Ffetch_bytecode): New forward static decl.
7434 (Funintern): Remove extern decl; now in .h file where it belongs.
7435 * fileio.c (Fmake_symbolic_link): New forward static decl.
7436 * image.c (Finit_image_library): New forward static decl.
7437 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7438 * intervals.h (Fprevious_property_change):
7439 (Fremove_list_of_text_properties): Remove decls.
7440 * keyboard.c (Fthis_command_keys): Remove decl.
7441 (Fcommand_execute): New forward static decl.
7442 * keymap.c (Flookup_key): New forward static decl.
7443 (Fcopy_keymap): Now static.
7444 * keymap.h (Flookup_key): Remove decl.
7445 * process.c (Fget_process): New forward static decl.
7446 (Fprocess_datagram_address): Mark as internal.
7447 * syntax.c (Fsyntax_table_p): New forward static decl.
7448 (skip_chars): Remove duplicate decl.
7449 * textprop.c (Fprevious_property_change): New forward static decl.
7450 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7451 Now internal.
7452 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7453 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7454
7455 * editfns.c (Fformat): Remove unreachable code.
7456
7457 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7458
7459 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7460 change. (Bug#8496)
7461
7462 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7463
7464 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7465 when at ZV. (Bug#8487)
7466
7467 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7468
7469 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7470 (Bug#8437)
7471 * keyboard.c (parse_tool_bar_item): Likewise.
7472 * sound.c (sound_cleanup, alsa_close): Likewise.
7473 * termcap.c (tgetent): Likewise.
7474 * xfns.c (x_default_font_parameter): Likewise.
7475 * xsettings.c (read_and_apply_settings): Likewise.
7476
7477 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7478 (overrun_check_free): Protoize.
7479
7480 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7481
7482 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7483 since callers should never pass a negative size.
7484 Change the signature to match that of plain 'read' and 'write'; see
7485 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7486 * lisp.h: Update prototypes of emacs_write and emacs_read.
7487
7488 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7489
7490 * xdisp.c (redisplay_window): Don't try to determine the character
7491 position of the scroll margin if the window start point w->startp
7492 is outside the buffer's accessible region. (Bug#8468)
7493
7494 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7495
7496 Fix write-region and its subroutines for buffers > 2GB.
7497 * fileio.c (a_write, e_write): Modify declaration of arguments and
7498 local variables to support buffers larger than 2GB.
7499 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7500
7501 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7502 argument, local variables, and return value.
7503
7504 * lisp.h: Update prototypes of emacs_write and emacs_read.
7505
7506 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7507
7508 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7509
7510 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7511
7512 Fix more problems found by GCC 4.6.0's static checks.
7513
7514 * xdisp.c (vmessage): Use a better test for character truncation.
7515
7516 * charset.c (load_charset_map): <, not <=, for optimization,
7517 and to avoid potential problems with integer overflow.
7518 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7519 * casetab.c (set_identity, shuffle): Likewise.
7520 * editfns.c (Fformat): Likewise.
7521 * syntax.c (skip_chars): Likewise.
7522
7523 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7524 This also lets GCC 4.6.0 generate slightly better loop code.
7525
7526 * callint.c (Fcall_interactively): <, not <=, for optimization.
7527 (Fcall_interactively): Count the number of arguments produced,
7528 not the number of arguments given. This is simpler and lets GCC
7529 4.6.0 generate slightly better code.
7530
7531 * ftfont.c: Distingish more carefully between FcChar8 and char.
7532 The previous code passed unsigned char * to a functions like
7533 strlen and xstrcasecmp that expect char *, which does not
7534 conform to the C standard.
7535 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7536 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7537 char * when the C standard requires it.
7538
7539 * keyboard.c (read_char): Remove unused var.
7540
7541 * eval.c: Port to Windows vsnprintf (Bug#8435).
7542 Include <limits.h>.
7543 (SIZE_MAX): Define if the headers do not.
7544 (verror): Do not give up if vsnprintf returns a negative count.
7545 Instead, grow the buffer. This ports to Windows vsnprintf, which
7546 does not conform to C99. Problem reported by Eli Zaretskii.
7547 Also, simplify the allocation scheme, by avoiding the need for
7548 calling realloc, and removing the ALLOCATED variable.
7549
7550 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7551
7552 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7553 But keep the doprint source code for now, as we might revamp it
7554 and use it again (Bug#8435).
7555 * lisp.h (doprnt): Remove.
7556 * Makefile.in (base_obj): Remove doprnt.o.
7557 * deps.mk (doprnt.o): Remove.
7558
7559 error: Print 32- and 64-bit integers portably (Bug#8435).
7560 Without this change, on typical 64-bit hosts error ("...%d...", N)
7561 was used to print both 32- and 64-bit integers N, which relied on
7562 undefined behavior.
7563 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7564 New macro.
7565 * lisp.h (error, verror): Mark as printf-like functions.
7566 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7567 Report overflow in size calculations when allocating printf buffer.
7568 Do not truncate output string at its first null byte.
7569 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7570 Truncate the output at a character boundary, since vsnprintf does not
7571 do that.
7572 * charset.c (check_iso_charset_parameter): Convert internal
7573 character to string before calling 'error', since %c now has the
7574 printf meaning.
7575 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7576 overflow when computing char to be passed to 'error'. Do not
7577 pass Lisp_Object to 'error'; pass the integer instead.
7578 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7579 formatted with plain %d.
7580
7581 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7582
7583 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7584
7585 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7586
7587 * xterm.c (x_catch_errors): Remove duplicate declaration.
7588
7589 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7590
7591 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7592
7593 2011-04-10 Jim Meyering <meyering@redhat.com>
7594
7595 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7596 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7597 return ssize_t not "int", and use size_t as the buffer length.
7598 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7599 * gnutls.h: Update declarations.
7600 * process.c (read_process_output): Use ssize_t, to match.
7601 (send_process): Likewise.
7602
7603 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7604
7605 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7606
7607 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7608
7609 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7610 Use unsigned char, to match FcChar8 type definition.
7611
7612 * xterm.c (handle_one_xevent):
7613 * xmenu.c (create_and_show_popup_menu):
7614 * xselect.c (x_decline_selection_request)
7615 (x_reply_selection_request): Avoid type-punned deref of X events.
7616
7617 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7618
7619 Fix some uses of `int' instead of EMACS_INT.
7620 * search.c (string_match_1, fast_string_match)
7621 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7622 (scan_buffer, find_next_newline_no_quit)
7623 (find_before_next_newline, search_command, Freplace_match)
7624 (Fmatch_data): Make some `int' variables be EMACS_INT.
7625
7626 * xdisp.c (display_count_lines): 3rd argument and return value now
7627 EMACS_INT. All callers changed.
7628 (pint2hrstr): Last argument is now EMACS_INT.
7629
7630 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7631 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7632 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7633 (decode_coding_utf_16, decode_coding_emacs_mule)
7634 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7635 (decode_coding_ccl, decode_coding_charset)
7636 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7637 (decode_coding_iso_2022, decode_coding_emacs_mule)
7638 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7639 <char_offset, last_offset>: Declare EMACS_INT.
7640 (encode_coding_utf_8, encode_coding_utf_16)
7641 (encode_coding_emacs_mule, encode_invocation_designation)
7642 (encode_designation_at_bol, encode_coding_iso_2022)
7643 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7644 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7645 Declare EMACS_INT.
7646 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7647 (encode_invocation_designation): Last argument P_NCHARS is now
7648 EMACS_INT.
7649 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7650 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7651
7652 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7653 All users changed.
7654
7655 * ccl.c (Fccl_execute_on_string): Declare some variables
7656 EMACS_INT.
7657
7658 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7659
7660 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7661
7662 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7663
7664 * process.c (Fformat_network_address): Doc fix.
7665
7666 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7667
7668 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7669
7670 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7671
7672 * keyboard.c (read_char): Call Lisp function help-form-show,
7673 instead of using internal_with_output_to_temp_buffer.
7674 (Qhelp_form_show): New var.
7675 (syms_of_keyboard): Use DEFSYM macro.
7676
7677 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7678
7679 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7680
7681 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7682
7683 * process.c (Flist_processes): Remove to Lisp.
7684 (list_processes_1): Delete.
7685
7686 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7687
7688 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7689
7690 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7691
7692 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7693
7694 Fix more problems found by GCC 4.6.0's static checks.
7695
7696 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7697
7698 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7699
7700 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7701
7702 * xdisp.c (vmessage): Mark as a printf-like function.
7703
7704 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7705
7706 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7707
7708 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7709 printf-like functions.
7710 (tiff_load): Add casts to remove these marks before passing them
7711 to system-supplied API.
7712
7713 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7714
7715 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7716 This avoids several warnings with gcc -Wstrict-overflow.
7717 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7718 directly, rather than having caller test rule sign. This avoids
7719 some unnecessary tests.
7720 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7721 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7722 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7723
7724 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7725 (xfont_open): Avoid unnecessary tests.
7726
7727 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7728
7729 * composite.h, composite.c (composition_gstring_put_cache):
7730 Use EMACS_INT, not int, for length.
7731
7732 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7733 breaking out part of COMPOSITION_DECODE_RULE.
7734 (COMPOSITION_DECODE_RULE): Use it.
7735 * composite.c (get_composition_id): Remove unused local vars,
7736 by using the new macro.
7737
7738 * textprop.c (set_text_properties_1): Change while to do-while,
7739 since the condition is always true at first.
7740
7741 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7742 (interval_deletion_adjustment): Return unsigned value.
7743 All uses changed.
7744
7745 * process.c (list_processes_1, create_pty, read_process_output):
7746 (exec_sentinel): Remove vars that were set but not used.
7747 (create_pty): Remove unnecessary "volatile"s.
7748 (Fnetwork_interface_info): Avoid possibility of int overflow.
7749 (read_process_output): Do adaptive read buffering even if carryover.
7750 (read_process_output): Simplify nbytes computation if buffered.
7751
7752 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7753
7754 * syntax.c (scan_words): Remove var that was set but not used.
7755 (update_syntax_table): Use unsigned instead of int.
7756
7757 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7758 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7759 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7760
7761 * print.c (print_error_message): Avoid int overflow.
7762
7763 * font.c (font_list_entities): Redo for clarity,
7764 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7765
7766 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7767 (font_score): Avoid potential overflow in diff calculation.
7768
7769 * fns.c (substring_both): Remove var that is set but not used.
7770 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7771
7772 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7773
7774 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7775 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7776 can always succeed if overflow has undefined behavior.
7777
7778 * search.c (boyer_moore, wordify): Remove vars set but not used.
7779 (wordify): Omit three unnecessary tests.
7780
7781 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7782 All callers changed. This avoids the need for an unused var.
7783
7784 * casefiddle.c (casify_region): Remove var that is set but not used.
7785
7786 * dired.c (file_name_completion): Remove var that is set but not used.
7787
7788 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7789
7790 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7791 (Finsert_file_contents): Remove unnecessary code checking fd.
7792
7793 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7794 Check for integer overflow on size calculations.
7795
7796 * buffer.c (Fprevious_overlay_change): Remove var that is set
7797 but not used.
7798
7799 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7800 Remove vars that are set but not used.
7801 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7802 (timer_check_2): Mark vars as initialized.
7803
7804 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7805
7806 * image.c (lookup_image): Remove var that is set but not used.
7807 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7808
7809 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7810 that are set but not used.
7811
7812 * xfns.c (make_invisible_cursor): Don't return garbage
7813 if XCreateBitmapFromData fails (Bug#8410).
7814
7815 * xselect.c (x_get_local_selection, x_handle_property_notify):
7816 Remove vars that are set but not used.
7817
7818 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7819 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7820
7821 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7822 Remove var that is set but not used.
7823 (scroll_bar_windows_size): Now size_t, not int.
7824 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7825 Check for overflow.
7826
7827 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7828 (map_tty_color) [!defined MSDOS]: Likewise.
7829
7830 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7831
7832 * coding.c: Remove vars that are set but not used.
7833 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7834 All callers changed.
7835 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7836 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7837 (decode_coding_charset): Remove vars that are set but not used.
7838
7839 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7840 that is set but not used.
7841
7842 * print.c (print_object): Remove var that is set but not used.
7843
7844 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7845 The gnulib version avoids calling malloc in the usual case,
7846 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7847 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7848 * filelock.c (current_lock_owner): Likewise.
7849 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7850 * sysdep.c: Include allocator.h, careadlinkat.h.
7851 (emacs_no_realloc_allocator): New static constant.
7852 (emacs_readlink): New function.
7853 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7854 ../lib/careadlinkat.h.
7855
7856 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7857
7858 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7859 first non-nil return value).
7860
7861 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7862
7863 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7864 if not defined (Bug#8403).
7865
7866 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7867
7868 * xdisp.c (display_count_lines): Remove parameter `start',
7869 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7870 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7871 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7872 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7873 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7874 and thereabouts. All callers changed.
7875 (get_per_char_metric): Remove parameter `f', unused since
7876 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7877
7878 2011-04-02 Jim Meyering <meyering@redhat.com>
7879
7880 do not dereference NULL upon failed strdup
7881 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7882 (ns_get_family): Likewise.
7883
7884 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7885
7886 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7887
7888 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7889
7890 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7891 later (Bug#8403).
7892
7893 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7894
7895 Add lexical binding.
7896
7897 * window.c (Ftemp_output_buffer_show): New fun.
7898 (Fsave_window_excursion):
7899 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7900
7901 * lread.c (lisp_file_lexically_bound_p): New function.
7902 (Fload): Bind Qlexical_binding.
7903 (readevalloop): Remove `evalfun' arg.
7904 Bind Qinternal_interpreter_environment.
7905 (Feval_buffer): Bind Qlexical_binding.
7906 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7907 Mark as dynamic.
7908 (syms_of_lread): Declare `lexical-binding'.
7909
7910 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7911
7912 * keyboard.c (eval_dyn): New fun.
7913 (menu_item_eval_property): Use it.
7914
7915 * image.c (parse_image_spec): Use Ffunctionp.
7916
7917 * fns.c (concat, mapcar1): Accept byte-code-functions.
7918
7919 * eval.c (Fsetq): Handle lexical vars.
7920 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7921 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7922 (FletX, Flet): Obey lexical binding.
7923 (Fcommandp): Handle closures.
7924 (Feval): New `lexical' arg.
7925 (eval_sub): New function extracted from Feval. Use it almost
7926 everywhere where Feval was used. Look up vars in lexical env.
7927 Handle closures.
7928 (Ffunctionp): Move from subr.el.
7929 (Ffuncall): Handle closures.
7930 (apply_lambda): Remove `eval_flags'.
7931 (funcall_lambda): Handle closures and new byte-code-functions.
7932 (Fspecial_variable_p): New function.
7933 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7934 but without exporting it to Lisp.
7935
7936 * doc.c (Fdocumentation, store_function_docstring):
7937 * data.c (Finteractive_form): Handle closures.
7938
7939 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7940 interactive spec.
7941
7942 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7943 New byte-codes.
7944 (exec_byte_code): New function extracted from Fbyte_code to handle new
7945 calling convention for byte-code-functions. Add new byte-codes.
7946
7947 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7948
7949 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7950
7951 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7952
7953 * xdisp.c (redisplay_internal): Fix prototype.
7954
7955 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7956
7957 * xdisp.c (SCROLL_LIMIT): New macro.
7958 (try_scrolling): Use it when setting scroll_limit.
7959 Limit scrolling to 100 screen lines.
7960 (redisplay_window): Even when falling back on "recentering",
7961 position point in the window according to scroll-conservatively,
7962 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7963
7964 (try_scrolling): When point is above the window, allow searching
7965 as far as scroll_max, or one screenful, to compute vertical
7966 distance from PT to the scroll margin position. This prevents
7967 try_scrolling from unnecessarily failing when
7968 scroll-conservatively is set to a value slightly larger than the
7969 window height. Clean up the case of PT below the margin at bottom
7970 of window: scroll_max can no longer be INT_MAX. When aggressive
7971 scrolling is in use, don't let point enter the opposite scroll
7972 margin as result of the scroll.
7973 (syms_of_xdisp) <scroll-conservatively>: Document the
7974 threshold of 100 lines for never-recentering scrolling.
7975
7976 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7977
7978 * dispextern.h (move_it_by_lines):
7979 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7980 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7981 (message_log_check_duplicate): Remove parameters `prev_bol' and
7982 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7983 (redisplay_internal): Remove parameter `preserve_echo_area',
7984 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7985
7986 * indent.c (Fvertical_motion):
7987 * window.c (window_scroll_pixel_based, Frecenter):
7988 Don't pass `need_y_p' to `move_it_by_lines'.
7989
7990 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7991
7992 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7993 steal a few bits to be more compact.
7994 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7995 Remove unneeded casts.
7996
7997 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7998
7999 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8000
8001 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8002 binding" message (bug#7967).
8003
8004 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8005
8006 Fix more problems found by GCC 4.6.0's static checks.
8007
8008 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8009 Remove unused local var.
8010
8011 * editfns.c (Fmessage_box): Remove unused local var.
8012
8013 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8014 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8015 Omit unused local vars.
8016 * window.c (shrink_windows): Omit unused local var.
8017 * menu.c (digest_single_submenu): Omit unused local var.
8018 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8019 Omit unused local var.
8020
8021 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8022 Don't assume string length fits in int.
8023 (keyremap_step, read_key_sequence): Use size_t for sizes.
8024 (read_key_sequence): Don't check last_real_key_start redundantly.
8025
8026 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8027 instead of alloca (Bug#8344).
8028
8029 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8030 (Fbacktrace_frame): Don't assume nframes fits in int.
8031
8032 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8033
8034 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8035 concerns.
8036
8037 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8038
8039 * cm.c (calccost): Turn while-do into do-while, for clarity.
8040
8041 * keyboard.c (syms_of_keyboard): Use the same style as later
8042 in this function when indexing through an array. This also
8043 works around GCC bug 48267.
8044
8045 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8046
8047 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8048
8049 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8050 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8051
8052 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8053 This avoids undefined behavior on integer overflow, and is a bit
8054 more convenient anyway since it is compared to a size_t variable.
8055
8056 Variadic C functions now count arguments with size_t, not int.
8057 This avoids an unnecessary limitation on 64-bit machines, which
8058 caused (substring ...) to crash on large vectors (Bug#8344).
8059 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8060 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8061 All variadic functions and their callers changed accordingly.
8062 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8063 * data.c (arith_driver, float_arith_driver): Likewise.
8064 * editfns.c (general_insert_function): Likewise.
8065 * eval.c (struct backtrace.nargs, interactive_p)
8066 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8067 (funcall_lambda, mark_backtrace): Likewise.
8068 * fns.c (concat): Likewise.
8069 * frame.c (x_set_frame_parameters): Likewise.
8070 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8071 0 if not found, not -1. All callers changed.
8072
8073 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8074 (stack_copy_size): Now size_t, not int.
8075 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8076
8077 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8078
8079 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8080 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8081 All callers changed.
8082
8083 * lisp.h (multibyte_char_to_unibyte):
8084 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8085 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8086 * character.h (CHAR_TO_BYTE8):
8087 * cmds.c (internal_self_insert):
8088 * editfns.c (general_insert_function):
8089 * keymap.c (push_key_description):
8090 * search.c (Freplace_match):
8091 * xdisp.c (message_dolog, set_message_1): All callers changed.
8092
8093 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8094
8095 * keyboard.c (safe_run_hook_funcall): New function.
8096 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8097 don't set the hook to nil, but remove the offending function instead.
8098 (Qcommand_hook_internal): Remove, unused.
8099 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8100 Vcommand_hook_internal.
8101
8102 * eval.c (enum run_hooks_condition): Remove.
8103 (funcall_nil, funcall_not): New functions.
8104 (run_hook_with_args): Call each function through a `funcall' argument.
8105 Remove `cond' argument, now redundant.
8106 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8107 (Frun_hook_with_args_until_failure): Adjust accordingly.
8108 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8109
8110 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8111
8112 * dispextern.h (string_buffer_position): Remove declaration.
8113
8114 * print.c (strout): Remove parameter `multibyte', unused since
8115 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8116
8117 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8118 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8119 All callers changed.
8120
8121 * w32.c (_wsa_errlist): Use braces for struct initializers.
8122
8123 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8124 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8125 All callers changed.
8126 (string_buffer_position): Likewise. Also, make static (it's never
8127 used outside xdisp.c).
8128 (cursor_row_p): Remove parameter `w', unused since
8129 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8130 (decode_mode_spec): Remove parameter `precision', introduced during
8131 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8132 All callers changed.
8133
8134 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8135
8136 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8137
8138 2011-03-27 Anders Lindgren <andlind@gmail.com>
8139
8140 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8141 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8142 (ns_update_auto_hide_menu_bar): New functions.
8143 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8144 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8145 ns_constrain_all_frames.
8146 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8147 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8148
8149 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8150
8151 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8152
8153 2011-03-27 Glenn Morris <rgm@gnu.org>
8154
8155 * syssignal.h: Replace RETSIGTYPE with void.
8156 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8157 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8158 Replace SIGTYPE with void everywhere.
8159 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8160 * s/template.h (SIGTYPE): Remove commented out definition.
8161
8162 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8163
8164 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8165 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8166
8167 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8168
8169 * w32.c (read_unc_volume): Use parameter `henum', instead of
8170 global variable `wget_enum_handle'.
8171
8172 * keymap.c (describe_vector): Remove parameters `indices' and
8173 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8174 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8175
8176 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8177
8178 * keyboard.c (timer_check): Remove parameter `do_it_now',
8179 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8180 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8181 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8182
8183 * keyboard.c (read_char):
8184 * w32menu.c (w32_menu_display_help):
8185 * xmenu.c (show_help_event, menu_help_callback):
8186 Adjust calls to `show_help_echo'.
8187
8188 * gtkutil.c (xg_maybe_add_timer):
8189 * keyboard.c (readable_events):
8190 * process.c (wait_reading_process_output):
8191 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8192
8193 * insdel.c (adjust_markers_gap_motion):
8194 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8195 (gap_left, gap_right): Don't call it.
8196
8197 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8198
8199 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8200 incurred during fontification.
8201
8202 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8203
8204 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8205 (DEFVAR_PER_BUFFER): Don't pass it.
8206
8207 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8208 (scrolling_window): Don't pass it.
8209
8210 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8211
8212 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8213
8214 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8215 and `suffix'.
8216 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8217 of variables specific to SELinux and computation of `encoded_absname'.
8218
8219 * image.c (XPutPixel): Remove unused variable `height'.
8220
8221 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8222
8223 * unexw32.c (get_section_info): Remove unused variable `section'.
8224
8225 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8226 (system_process_attributes): Remove unused variable `sess'.
8227 (sys_read): Remove unused variable `err'.
8228
8229 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8230 (w32_wnd_proc): Remove unused variable `isdead'.
8231 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8232 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8233 (x_create_tip_frame): Remove unused variable `tem'.
8234
8235 * w32inevt.c (w32_console_read_socket):
8236 Remove unused variable `no_events'.
8237
8238 * w32term.c (x_draw_composite_glyph_string_foreground):
8239 Remove unused variable `width'.
8240
8241 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8242
8243 * w32term.c (x_set_glyph_string_clipping):
8244 Don't pass uninitialized region to CombineRgn.
8245
8246 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8247
8248 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8249 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8250 (Fx_close_connection): Remove unused variable `i'.
8251
8252 * w32font.c (w32font_draw): Return number of glyphs.
8253 (w32font_open_internal): Remove unused variable `i'.
8254 (w32font_driver): Add missing initializer.
8255
8256 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8257 (fill_in_menu): Remove unused variable `items_added'.
8258
8259 * w32term.c (last_mouse_press_frame): Remove static global variable.
8260 (w32_clip_to_row): Remove unused variable `f'.
8261 (x_delete_terminal): Remove unused variable `i'.
8262
8263 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8264 (NOTHING): Remove unused static global variable.
8265 (uniscribe_check_otf): Remove unused variable `table'.
8266 (uniscribe_font_driver): Add missing initializers.
8267
8268 2011-03-23 Julien Danjou <julien@danjou.info>
8269
8270 * term.c (Fsuspend_tty, Fresume_tty):
8271 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8272 * window.c (temp_output_buffer_show):
8273 * insdel.c (signal_before_change):
8274 * frame.c (Fhandle_switch_frame):
8275 * fileio.c (Fdo_auto_save):
8276 * emacs.c (Fkill_emacs):
8277 * editfns.c (save_excursion_restore):
8278 * cmds.c (internal_self_insert):
8279 * callint.c (Fcall_interactively):
8280 * buffer.c (Fkill_all_local_variables):
8281 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8282 Use Frun_hooks.
8283 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8284 unconditionally since it does the check itself.
8285
8286 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8287
8288 Fix more problems found by GCC 4.5.2's static checks.
8289
8290 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8291 the first time through the loop, since we know p0 < p1 then.
8292 This also avoids a gcc -Wstrict-overflow warning.
8293
8294 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8295 leading to a memory leak, possible in functions like
8296 load_charset_map_from_file that can allocate an unbounded number
8297 of objects (Bug#8318).
8298
8299 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8300 that could (at least in theory) be that large.
8301
8302 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8303 This is less likely to overflow, and avoids undefined behavior if
8304 overflow does occur. All callers changed. Use strtoul to scan
8305 for the unsigned long integer.
8306 (pint2hrstr): Simplify and tune code slightly.
8307 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8308
8309 * scroll.c (do_scrolling): Work around GCC bug 48228.
8310 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8311
8312 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8313 This also avoids a warning with gcc -Wstrict-overflow.
8314 (validate_x_resource_name): Simplify count usage.
8315 This also avoids a warning with gcc -Wstrict-overflow.
8316
8317 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8318 fail (Bug#8306).
8319
8320 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8321
8322 * process.c (Fmake_network_process): Use socklen_t, not int,
8323 where POSIX says socklen_t is required in portable programs.
8324 This fixes a porting bug on hosts like 64-bit HP-UX, where
8325 socklen_t is wider than int (Bug#8277).
8326 (Fmake_network_process, server_accept_connection):
8327 (wait_reading_process_output, read_process_output):
8328 Likewise.
8329
8330 * process.c: Rename or move locals to avoid shadowing.
8331 (list_processes_1, Fmake_network_process):
8332 (read_process_output_error_handler, exec_sentinel_error_handler):
8333 Rename or move locals.
8334 (Fmake_network_process): Define label "retry_connect" only if needed.
8335 (Fnetwork_interface_info): Fix pointer signedness.
8336 (process_send_signal): Add cast to avoid pointer signedness problem.
8337 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8338 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8339
8340 Make tparam.h and terminfo.c consistent.
8341 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8342 Include tparam.h instead, since it declares them.
8343 * cm.h (PC): Remove extern decl; tparam.h now does this.
8344 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8345 * terminfo.c: Include tparam.h, to check interfaces.
8346 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8347 (tparam): Adjust signature to match interface in tparam.h;
8348 this removes some undefined behavior. Check that outstring and len
8349 are zero, which they always are with Emacs.
8350 * tparam.h (PC, BC, UP): New extern decls.
8351
8352 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8353 (xftfont_open): Rename locals to avoid shadowing.
8354
8355 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8356 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8357 (OTF_TAG_SYM): Omit macro if not needed.
8358 (ftfont_list): Remove unused local.
8359 (get_adstyle_property, ftfont_pattern_entity):
8360 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8361 Rename locals to avoid shadowing.
8362
8363 * xfont.c (xfont_list_family): Mark var as initialized.
8364
8365 * xml.c (make_dom): Now static.
8366
8367 * composite.c (composition_compute_stop_pos): Rename local to
8368 avoid shadowing.
8369 (composition_reseat_it): Remove unused locals.
8370 (find_automatic_composition, composition_adjust_point): Likewise.
8371 (composition_update_it): Mark var as initialized.
8372 (find_automatic_composition): Mark vars as initialized,
8373 with a FIXME (Bug#8290).
8374
8375 character.h: Rename locals to avoid shadowing.
8376 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8377 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8378 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8379 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8380 to avoid shadowing.
8381
8382 * textprop.c (property_change_between_p): Remove; unused.
8383
8384 * intervals.c (interval_start_pos): Now static.
8385
8386 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8387
8388 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8389 Rename locals to avoid shadowing.
8390
8391 * sound.c (wav_play, au_play, Fplay_sound_internal):
8392 Fix pointer signedness.
8393 (alsa_choose_format): Remove unused local var.
8394 (wav_play): Initialize a variable to 0, to prevent undefined
8395 behavior (Bug#8278).
8396
8397 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8398
8399 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8400
8401 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8402 clobbering (Bug#8298).
8403 * sysdep.c (sys_subshell): Likewise.
8404 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8405
8406 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8407 This should get cleaned up, so that child_setup has the
8408 same signature on all platforms.
8409
8410 * callproc.c (call_process_cleanup): Now static.
8411 (relocate_fd): Rename locals to avoid shadowing.
8412
8413 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8414
8415 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8416 not to be necessary, and produces flickering.
8417
8418 2011-03-20 Glenn Morris <rgm@gnu.org>
8419
8420 * config.in: Remove file.
8421
8422 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8423
8424 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8425 are now in src/globals.h.
8426 (syms_of_minibuf): Remove spurious & from previous change.
8427
8428 2011-03-20 Leo Liu <sdl.web@gmail.com>
8429
8430 * minibuf.c (completing-read-function): New variable.
8431 (completing-read-default): Rename from completing-read.
8432 (completing-read): Call completing-read-function.
8433
8434 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8435
8436 * xfaces.c (Fx_load_color_file):
8437 Read color file from absolute filename (bug#8250).
8438
8439 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8440
8441 * makefile.w32-in: Update dependencies.
8442
8443 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8444
8445 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8446
8447 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8448
8449 Fix more problems found by GCC 4.5.2's static checks.
8450
8451 * process.c (make_serial_process_unwind, send_process_trap):
8452 (sigchld_handler): Now static.
8453
8454 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8455 That way, the code declares only the vars that it needs.
8456 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8457 * s/cygwin.h (PTY_ITERATION): Likewise.
8458 * s/darwin.h (PTY_ITERATION): Likewise.
8459 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8460
8461 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8462 * process.c (allocate_pty): Don't declare stb unless it's needed.
8463
8464 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8465 (CONSTANTLIM): Remove; unused.
8466 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8467 Define only if needed.
8468
8469 * unexelf.c (unexec): Name an expression,
8470 to avoid gcc -Wbad-function-cast warning.
8471 Use a different way to cause a compilation error if anyone uses
8472 n rather than nn, a way that does not involve shadowing.
8473 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8474
8475 * deps.mk (unexalpha.o): Remove; unused.
8476
8477 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8478 * unexec.h: New file.
8479 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8480 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8481 Depend on unexec.h.
8482 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8483 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8484 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8485 Change as necessary to match prototype in unexec.h.
8486
8487 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8488 shadowing.
8489 (back_comment, skip_chars): Mark vars as initialized.
8490
8491 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8492 Rename locals to avoid shadowing.
8493
8494 * lread.c (read1): Rewrite so as not to use empty "else".
8495 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8496
8497 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8498
8499 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8500 warning when compiling print.c.
8501
8502 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8503 instead of using an uninitialized var.
8504 (font_sort_entities): Mark var as initialized.
8505
8506 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8507
8508 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8509 pointers to constants.
8510 (font_parse_fcname): Remove unused vars.
8511 (font_delete_unmatched): Now static.
8512 (font_get_spec): Remove; unused.
8513 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8514 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8515 Rename or move locals to avoid shadowing.
8516
8517 * fns.c (require_nesting_list, require_unwind): Now static.
8518 (Ffillarray): Rename locals to avoid shadowing.
8519
8520 * floatfns.c (domain_error2): Define only if needed.
8521 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8522
8523 * alloc.c (mark_backtrace): Move decl from here ...
8524 * lisp.h: ... to here, so that it can be checked.
8525
8526 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8527 (Fdefvar): Rewrite so as not to use empty "else".
8528 (lisp_indirect_variable): Name an expression,
8529 to avoid gcc -Wbad-function-cast warning.
8530 (Fdefvar): Rename locals to avoid shadowing.
8531
8532 * callint.c (quotify_arg, quotify_args): Now static.
8533 (Fcall_interactively): Rename locals to avoid shadowing.
8534 Use const pointer when appropriate.
8535
8536 * lisp.h (get_system_name, get_operating_system_release):
8537 Move decls here, to check interfaces.
8538 * process.c (get_operating_system_release): Move decl to lisp.h.
8539 * xrdb.c (get_system_name): Likewise.
8540 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8541 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8542 some of which prompt warnings from gcc -Wbad-function-cast.
8543 (Fformat_time_string, Fencode_time, Finsert_char):
8544 (Ftranslate_region_internal, Fformat):
8545 Rename or remove local vars to avoid shadowing.
8546 (Ftranslate_region_internal): Mark var as initialized.
8547
8548 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8549 avoid shadowing.
8550
8551 * lisp.h (eassert): Check that the argument compiles, even if
8552 ENABLE_CHECKING is not defined.
8553
8554 * data.c (Findirect_variable): Name an expression, to avoid
8555 gcc -Wbad-function-cast warning.
8556 (default_value, arithcompare, arith_driver, arith_error): Now static.
8557 (store_symval_forwarding): Rename local to avoid shadowing.
8558 (Fmake_variable_buffer_local, Fmake_local_variable):
8559 Mark variables as initialized.
8560 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8561
8562 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8563 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8564 Rename locals to avoid shadowing.
8565 (mark_stack): Move local variables into the #ifdef region where
8566 they're used.
8567 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8568 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8569 needed otherwise.
8570 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8571 (GC_STRING_CHARS): Remove; not used.
8572 (Fmemory_limit): Cast sbrk's returned value to char *.
8573
8574 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8575 avoids undefined behavior in theory.
8576
8577 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8578
8579 Use functions, not macros, for up- and down-casing (Bug#8254).
8580 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8581 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8582 to use the following functions instead of these macros.
8583 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8584 EMACS_INT, since callers assume the returned value fits in int.
8585 (upcase1): Likewise, for UPCASE_TABLE.
8586 (uppercasep, lowercasep, upcase): New static inline functions.
8587 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8588 the race-condition problem in the old DOWNCASE.
8589
8590 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8591 Rename locals to avoid shadowing.
8592 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8593 (regex_compile, re_search_2, re_match_2_internal):
8594 Remove unused local vars.
8595 (FREE_VAR): Rewrite so as not to use empty "else",
8596 which gcc can warn about.
8597 (regex_compile, re_match_2_internal): Mark locals as initialized.
8598 (RETALLOC_IF): Define only if needed.
8599 (WORDCHAR_P): Likewise. This one is never needed, but is used
8600 only in a comment talking about a compiler bug, so put inside
8601 the #if 0 of that comment.
8602 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8603 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8604 Remove; unused.
8605
8606 * search.c (boyer_moore): Rename locals to avoid shadowing.
8607 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8608 (PREV_CHAR_BOUNDARY): Likewise.
8609
8610 * search.c (simple_search): Remove unused var.
8611
8612 * dired.c (compile_pattern): Move decl from here ...
8613 * lisp.h: ... to here, so that it can be checked.
8614 (struct re_registers): New forward decl.
8615
8616 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8617
8618 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8619 All uses changed.
8620 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8621 Rename locals to avoid shadowing.
8622 (Fvertical_motion): Mark locals as initialized.
8623
8624 * casefiddle.c (casify_object, casify_region): Now static.
8625 (casify_region): Mark local as initialized.
8626
8627 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8628
8629 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8630 New macros, so that the caller can use some names other than
8631 gcpro1, gcpro2, etc.
8632 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8633 of the new macros.
8634 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8635 argument, for consistency with GCPRO2_VAR, etc: it is now the
8636 prefix of the variable, not the variable itself. All uses
8637 changed.
8638 * dired.c (directory_files_internal, file_name_completion):
8639 Rename locals to avoid shadowing.
8640
8641 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8642 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8643 dired.c's scmp function, had undefined behavior.
8644 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8645 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8646 * buffer.h: ... to here, because these macros use current_buffer,
8647 and the new implementation with inline functions needs to have
8648 current_buffer in scope now, rather than later when the macros
8649 are used.
8650 (downcase, upcase1): New static inline functions.
8651 (DOWNCASE, UPCASE1): Reimplement using these functions.
8652 This avoids undefined behavior in expressions like
8653 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8654 from race conditions in accessing the global variables
8655 case_temp1 and case_temp2.
8656 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8657 * lisp.h (case_temp1, case_temp2): Remove their decls.
8658 * character.h (ASCII_CHAR_P): Move from here ...
8659 * lisp.h: ... to here, so that the inline functions mentioned
8660 above can use them.
8661
8662 * dired.c (directory_files_internal_unwind): Now static.
8663
8664 * fileio.c (file_name_as_directory, directory_file_name):
8665 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8666 Now static.
8667 (file_name_as_directory): Use const pointers when appropriate.
8668 (Fexpand_file_name): Likewise. In particular, newdir might
8669 point at constant storage, so make it a const pointer.
8670 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8671 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8672 signedness issues.
8673 (Fset_file_times, Finsert_file_contents, auto_save_error):
8674 Rename locals to avoid shadowing.
8675
8676 * minibuf.c (choose_minibuf_frame_1): Now static.
8677 (Ftry_completion, Fall_completions): Rename or remove locals
8678 to avoid shadowing.
8679
8680 * marker.c (bytepos_to_charpos): Remove; unused.
8681
8682 * lisp.h (verify_bytepos, count_markers): New decls,
8683 so that gcc does not warn that these functions aren't declared.
8684
8685 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8686 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8687 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8688 (copy_text): Remove unused local var.
8689
8690 * filelock.c (within_one_second): Now static.
8691 (lock_file_1): Rename local to avoid shadowing.
8692
8693 * buffer.c (fix_overlays_before): Mark locals as initialized.
8694 (fix_start_end_in_overlays): Likewise. This function should be
8695 simplified by using pointers-to-pointers, but that's a different
8696 matter.
8697 (switch_to_buffer_1): Now static.
8698 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8699 (report_overlay_modification): Rename locals to avoid shadowing.
8700
8701 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8702 Fix pointer signedness issue.
8703 (sys_subshell): Mark local as volatile if checking for lint,
8704 to suppress a gcc -Wclobbered warning that does not seem to be right.
8705 (MAXPATHLEN): Define only if needed.
8706
8707 * process.c (serial_open, serial_configure): Move decls from here ...
8708 * systty.h: ... to here, so that they can be checked.
8709
8710 * fns.c (get_random, seed_random): Move extern decls from here ...
8711 * lisp.h: ... to here, so that they can be checked.
8712
8713 * sysdep.c (reset_io): Now static.
8714 (wait_for_termination_signal): Remove; unused.
8715
8716 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8717 (copy_keymap_item, append_key, push_text_char_description):
8718 Now static.
8719 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8720 (DENSE_TABLE_SIZE): Remove; unused.
8721 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8722 (describe_map_tree):
8723 Rename locals to avoid shadowing.
8724
8725 * keyboard.c: Declare functions static if they are not used elsewhere.
8726 (echo_char, echo_dash, cmd_error, top_level_2):
8727 (poll_for_input, handle_async_input): Now static.
8728 (read_char, kbd_buffer_get_event, make_lispy_position):
8729 (make_lispy_event, make_lispy_movement, apply_modifiers):
8730 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8731 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8732 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8733 (read_key_sequence, read_char): Mark locals as initialized.
8734 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8735
8736 * keyboard.h (make_ctrl_char): New decl.
8737 (mark_kboards): Move decl here ...
8738 * alloc.c (mark_kboards): ... from here.
8739
8740 * lisp.h (force_auto_save_soon): New decl.
8741
8742 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8743 (DEFINE_DUMMY_FUNCTION): New macro.
8744 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8745 Use it.
8746 (main): Add casts to avoid warnings
8747 if GCC considers string literals to be constants.
8748
8749 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8750
8751 * dbusbind.c: Pointer signedness fixes.
8752 (xd_signature, xd_append_arg, xd_initialize):
8753 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8754 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8755 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8756 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8757
8758 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8759 if GCC considers string literals to be constants.
8760 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8761
8762 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8763
8764 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8765 (print_preprocess, print_object): New macro to fix last change.
8766
8767 * print.c (print_preprocess): Don't forget font objects.
8768
8769 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8770
8771 * emacs.c (USAGE3): Doc fixes.
8772
8773 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8774
8775 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8776 structure.
8777
8778 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8779
8780 * lisp.h (VWindow_system, Qfile_name_history):
8781 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8782 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8783 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8784
8785 * w32select.c: Don't #include "keyboard.h".
8786 (run_protected): Add extern declaration for waiting_for_input.
8787
8788 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8789 * w32console.c (detect_input_pending, read_input_pending)
8790 (encode_terminal_code):
8791 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8792 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8793 (w32_system_caret_y, Qfile_name_history):
8794 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8795 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8796 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8797 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8798 * w32proc.c (Qlocal, report_file_error):
8799 * w32term.c (Vwindow_system, updating_frame):
8800 * w32uniscribe.c (initialized, uniscribe_font_driver):
8801 Remove unneeded extern declarations.
8802
8803 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8804
8805 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8806
8807 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8808
8809 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8810 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8811 These macros can no longer be used for assignment.
8812
8813 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8814 Assign struct members directly, instead of using BUF_BEGV etc.
8815 (record_buffer_markers, fetch_buffer_markers): New functions for
8816 recording and fetching special buffer markers.
8817 (set_buffer_internal_1, set_buffer_temp): Use them.
8818
8819 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8820
8821 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8822
8823 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8824 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8825
8826 * xdisp.c (hscroll_window_tree):
8827 (reconsider_clip_changes): Use PT instead of BUF_PT.
8828
8829 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8830
8831 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8832 $(EMACS_ROOT)/lib/intprops.h.
8833
8834 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8835
8836 Fix more problems found by GCC 4.5.2's static checks.
8837
8838 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8839 to unsigned char * to avoid compiler diagnostic.
8840 (xg_free_frame_widgets): Make it clear that a local variable is
8841 needed only if USE_GTK_TOOLTIP.
8842 (gdk_window_get_screen): Make it clear that this macro is needed
8843 only if USE_GTK_TOOLTIP.
8844 (int_gtk_range_get_value): New function, which avoids a diagnostic
8845 from gcc -Wbad-function-cast.
8846 (xg_set_toolkit_scroll_bar_thumb): Use it.
8847 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8848 diagnostic from gcc -Wbad-function-cast.
8849 (get_utf8_string, xg_get_file_with_chooser):
8850 Rename locals to avoid shadowing.
8851 (create_dialog): Move locals to avoid shadowing.
8852
8853 * xgselect.c (xg_select): Remove unused var.
8854
8855 * image.c (four_corners_best): Mark locals as initialized.
8856 (gif_load): Initialize transparent_p to zero (Bug#8238).
8857 Mark another local as initialized.
8858 (my_png_error, my_error_exit): Mark with NO_RETURN.
8859
8860 * image.c (clear_image_cache): Now static.
8861 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8862 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8863 (x_edge_detection): Remove unnecessary cast that
8864 gcc -Wbad-function-cast diagnoses.
8865 (gif_load): Fix pointer signedness.
8866 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8867 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8868
8869 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8870
8871 Improve quality of tests for time stamp overflow.
8872 For example, without this patch (encode-time 0 0 0 1 1
8873 1152921504606846976) returns the obviously-bogus value (-948597
8874 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8875 reports time overflow. See
8876 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8877 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8878 * editfns.c: Include limits.h and intprops.h.
8879 (TIME_T_MIN, TIME_T_MAX): New macros.
8880 (time_overflow): Move earlier, to before first use.
8881 (hi_time, lo_time): New functions, for an accurate test for
8882 out-of-range times.
8883 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8884 (Fget_internal_run_time): Don't assume time_t fits in int.
8885 (make_time): Use list2 instead of Fcons twice.
8886 (Fdecode_time): More accurate test for out-of-range times.
8887 (check_tm_member): New function.
8888 (Fencode_time): Use it, to test for out-of-range times.
8889 (lisp_time_argument): Don't rely on undefined left-shift and
8890 right-shift behavior when checking for time stamp overflow.
8891
8892 * editfns.c (time_overflow): New function, refactoring common code.
8893 (Fformat_time_string, Fdecode_time, Fencode_time):
8894 (Fcurrent_time_string): Use it.
8895
8896 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8897 * dired.c (make_time): Move to ...
8898 * editfns.c (make_time): ... here.
8899 * systime.h: Note the move.
8900
8901 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8902
8903 * fringe.c (update_window_fringes): Remove unused variables.
8904
8905 * unexmacosx.c (copy_data_segment): Also copy __got section.
8906 (Bug#8223)
8907
8908 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8909
8910 * termcap.c [MSDOS]: Include "msdos.h".
8911 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8912 Constify `char *' arguments and their references according to
8913 prototypes in tparam.h.
8914
8915 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8916
8917 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8918 Adapt all references accordingly.
8919
8920 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8921
8922 2011-03-11 Tom Tromey <tromey@redhat.com>
8923
8924 * buffer.c (syms_of_buffer): Remove obsolete comment.
8925
8926 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8927
8928 * termhooks.h (encode_terminal_code): Declare prototype.
8929
8930 * msdos.c (encode_terminal_code): Don't declare prototype.
8931
8932 * term.c (encode_terminal_code): Now external again, used by
8933 w32console.c and msdos.c.
8934
8935 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8936 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8937
8938 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8939
8940 Fix some minor problems found by GCC 4.5.2's static checks.
8941
8942 * fringe.c (update_window_fringes): Mark locals as initialized
8943 (Bug#8227).
8944 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8945
8946 * alloc.c (mark_fringe_data): Move decl from here ...
8947 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8948 to check its interface.
8949 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8950
8951 * fontset.c (free_realized_fontset): Now static.
8952 (Fset_fontset_font): Rename local to avoid shadowing.
8953 (fontset_font): Mark local as initialized.
8954 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8955
8956 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8957
8958 * xselect.c (x_disown_buffer_selections): Remove; not used.
8959 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8960 (x_own_selection, Fx_disown_selection_internal): Rename locals
8961 to avoid shadowing.
8962 (x_handle_dnd_message): Remove local to avoid shadowing.
8963
8964 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8965 so that the caller can use some name other than gcpro1.
8966 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8967 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8968 (Fx_backspace_delete_keys_p):
8969 Use them to avoid shadowing, and rename vars to avoid shadowing.
8970 (x_decode_color, x_set_name, x_window): Now static.
8971 (Fx_create_frame): Add braces to silence GCC warning.
8972 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8973 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8974 Remove unused locals.
8975 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8976 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8977 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8978 macros.
8979
8980 * xterm.h (x_mouse_leave): New decl.
8981
8982 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8983 Remove unused functions.
8984 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8985 (x_calc_absolute_position): Now static.
8986 (XTread_socket): Don't define label "out" unless it's used.
8987 Don't declare local "event" unless it's used.
8988 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8989 unless they are used.
8990 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8991 (x_fatal_error_signal): Remove; not used.
8992 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8993 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8994 (x_error_catcher, x_connection_closed, x_error_handler):
8995 (x_error_quitter, xembed_send_message, x_iconify_frame):
8996 (my_log_handler): Rename locals to avoid shadowing.
8997 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8998 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8999
9000 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9001 Rename or move locals to avoid shadowing.
9002 (tty_defined_color, merge_face_heights): Now static.
9003 (free_realized_faces_for_fontset): Remove; not used.
9004 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9005 does not deduce is never used uninitialized.
9006 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9007 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9008
9009 * terminal.c (store_terminal_param): Now static.
9010
9011 * xmenu.c (menu_highlight_callback): Now static.
9012 (set_frame_menubar): Remove unused local.
9013 (xmenu_show): Rename parameter to avoid shadowing.
9014 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9015 since they might point to immutable storage.
9016 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9017 since it's unused otherwise.
9018
9019 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9020 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9021 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9022 avoids a gcc -Wuninitialized diagnostic.
9023 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9024 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9025 does not deduce are never used uninitialized.
9026
9027 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9028
9029 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9030 * window.c (window_loop, size_window):
9031 (run_window_configuration_change_hook, enlarge_window): Likewise.
9032
9033 * window.c (display_buffer): Now static.
9034 (size_window): Mark variables that gcc -Wuninitialized
9035 does not deduce are never used uninitialized.
9036 * window.h (check_all_windows): New decl, to forestall
9037 gcc -Wmissing-prototypes diagnostic.
9038 * dispextern.h (bidi_dump_cached_states): Likewise.
9039
9040 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9041 shadowing.
9042 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9043 Include <limits.h>.
9044 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9045 and to avoid gcc -Wuninitialized warning.
9046 (load_charset_map): Mark variables that gcc -Wuninitialized
9047 does not deduce are never used uninitialized.
9048 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9049
9050 * coding.c (coding_set_source, coding_set_destination):
9051 Use "else { /* comment */ }" rather than "else /* comment */;"
9052 for clarity, and to avoid gcc -Wempty-body warning.
9053 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9054 a block, when the outer 'i' will do.
9055 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9056 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9057 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9058 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9059 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9060 Rename locals to avoid shadowing.
9061 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9062 * coding.c (emacs_mule_char, encode_invocation_designation):
9063 Now static, since they're not used elsewhere.
9064 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9065 (decode_coding_object, encode_coding_object, detect_coding_system):
9066 (decode_coding_emacs_mule): Mark variables that gcc
9067 -Wuninitialized does not deduce are never used uninitialized.
9068 (detect_coding_iso_2022): Initialize a local variable that might
9069 be used uninitialized. Leave a FIXME because it's not clear that
9070 this initialization is needed. (Bug#8211)
9071 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9072 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9073 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9074 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9075 Remove unused macros.
9076
9077 * category.c (hash_get_category_set): Remove unused local var.
9078 (copy_category_table): Now static, since it's not used elsewhere.
9079 * character.c (string_count_byte8): Likewise.
9080
9081 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9082 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9083
9084 * chartab.c (copy_sub_char_table): Now static, since it's not used
9085 elsewhere.
9086 (sub_char_table_ref_and_range, char_table_ref_and_range):
9087 Rename locals to avoid shadowing.
9088 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9089
9090 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9091 (BIDI_BOB): Remove unused macro.
9092
9093 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9094 deduce are never used uninitialized.
9095 * term.c (encode_terminal_code): Likewise.
9096
9097 * term.c (encode_terminal_code): Now static. Remove unused local.
9098
9099 * tparam.h: New file.
9100 * term.c, tparam.h: Include it.
9101 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9102 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9103 Move these decls to tparam.h, and make them agree with what
9104 is actually in tparam.c. The previous trick of using incompatible
9105 decls in different modules does not conform to the C standard.
9106 All callers of tparam changed to use tparam's actual API.
9107 * tparam.c (tparam1, tparam, tgoto):
9108 Use const pointers where appropriate.
9109
9110 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9111 * cm.h (struct cm): Likewise.
9112 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9113 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9114 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9115 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9116 (turn_on_face, init_tty): Likewise.
9117 * termchar.h (struct tty_display_info): Likewise.
9118
9119 * term.c (term_mouse_position): Rename local to avoid shadowing.
9120
9121 * alloc.c (mark_ttys): Move decl from here ...
9122 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9123
9124 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9125
9126 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9127
9128 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9129
9130 * search.c (compile_pattern_1): Remove argument regp, unused since
9131 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9132 (compile_pattern): Don't pass it.
9133
9134 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9135
9136 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9137 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9138 for ! HAVE_GTK3.
9139 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9140
9141 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9142
9143 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9144 gdk_window_get_screen, gdk_window_get_geometry,
9145 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9146 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9147 (xg_get_pixbuf_from_pixmap): New function.
9148 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9149 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9150 Call xg_get_pixbuf_from_pixmap instead of
9151 gdk_pixbuf_get_from_drawable.
9152 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9153 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9154 (xg_check_special_colors): Use GtkStyleContext and its functions
9155 for HAVE_GTK3.
9156 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9157 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9158 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9159 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9160 Call gtk_widget_get_preferred_size.
9161 (xg_frame_resized): gdk_window_get_geometry only takes 5
9162 parameters.
9163 (xg_win_to_widget, xg_event_is_for_menubar):
9164 Call gdk_x11_window_lookup_for_display.
9165 (xg_set_widget_bg): New function.
9166 (delete_cb): New function.
9167 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9168 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9169 (xg_set_background_color): Call xg_set_widget_bg.
9170 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9171 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9172 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9173 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9174 if ! HAVE_GTK3.
9175 (update_frame_tool_bar): Call gtk_widget_hide.
9176 (xg_initialize): Use GDK_KEY_g.
9177
9178 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9179 if ! HAVE_GTK3
9180 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9181
9182 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9183 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9184 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9185
9186 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9187
9188 * w32xfns.c (select_palette): Check success of RealizePalette against
9189 GDI_ERROR, not zero.
9190
9191 See ChangeLog.11 for earlier changes.
9192
9193 ;; Local Variables:
9194 ;; coding: utf-8
9195 ;; End:
9196
9197 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9198
9199 This file is part of GNU Emacs.
9200
9201 GNU Emacs is free software: you can redistribute it and/or modify
9202 it under the terms of the GNU General Public License as published by
9203 the Free Software Foundation, either version 3 of the License, or
9204 (at your option) any later version.
9205
9206 GNU Emacs is distributed in the hope that it will be useful,
9207 but WITHOUT ANY WARRANTY; without even the implied warranty of
9208 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9209 GNU General Public License for more details.
9210
9211 You should have received a copy of the GNU General Public License
9212 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.