1 2012-05-19 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4 state after an additional call to move_it_in_display_line_to, keep
5 the values of it->max_ascent and it->max_descent found for the
7 (pos_visible_p): Revert the comparison against bottom_y to what it
8 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
11 2012-05-15 Eli Zaretskii <eliz@gnu.org>
13 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
15 2012-05-13 Eli Zaretskii <eliz@gnu.org>
17 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
18 already have overlays loaded.
19 (handle_single_display_spec): Before returning without displaying
20 fringe bitmap, synchronize the bidi iterator with the main display
21 iterator, by calling iterate_out_of_display_property.
22 (iterate_out_of_display_property): Detect buffer iteration by
23 testing that it->string is a Lisp string.
24 (get_next_display_element): When the current object is exhausted,
25 and there's something on it->stack, call set_iterator_to_next to
26 proceed with what's on the stack, instead of returning zero.
27 (set_iterator_to_next): If called at the end of a Lisp string,
28 proceed to consider_string_end without incrementing string
29 position. Don't increment display vector index past the end of
30 the display vector. (Bug#11417)
31 (pos_visible_p): Don't report a position visible when move_it_to
32 stopped at the last line of window, which happens to be scanned
33 backwards by the bidi iteration. (Bug#11464)
35 2012-05-11 Eli Zaretskii <eliz@gnu.org>
37 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
38 and right-margin display specs even if the spec is invalid or we
39 are on a TTY, and thus unable to display on the fringes. That's
40 because the text with the property will not be displayed anyway,
41 so we need to signal to the caller that this is a "replacing"
42 display spec. This fixes display when the spec is invalid or we
45 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
47 * unexaix.c (make_hdr): Fix typo in prototype.
48 This bug broke the build on AIX. Problem reported by Gilles Pion.
50 2012-05-05 Eli Zaretskii <eliz@gnu.org>
52 * w32proc.c (new_child): Force Windows to reserve only 64KB of
53 stack for each reader_thread, instead of defaulting to 8MB
54 determined by the linker. This avoids failures in creating
55 subprocesses on Windows 7, see the discussion in this thread:
56 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
58 2012-05-02 Jim Meyering <meyering@redhat.com>
60 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
62 2012-04-29 Eli Zaretskii <eliz@gnu.org>
64 * xdisp.c (pos_visible_p): If already at a newline from the
65 display string before the 'while' loop, don't walk back the glyphs
66 from it3.glyph_row. Solves assertion violation when the display
67 string begins with a newline (egg.el). (Bug#11367)
69 2012-04-24 Chong Yidong <cyd@gnu.org>
71 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
73 2012-04-23 Eli Zaretskii <eliz@gnu.org>
75 * xdisp.c (pos_visible_p): If the window start position is beyond
76 ZV, start the display from buffer beginning. Prevents assertion
77 violation in init_iterator when the minibuffer window is scrolled
80 * window.c (window_scroll_pixel_based): Likewise.
82 2012-04-23 Chong Yidong <cyd@gnu.org>
84 * keymap.c (where_is_internal): Doc fix (Bug#10872).
86 2012-04-20 Glenn Morris <rgm@gnu.org>
88 * fileio.c (Fcopy_file, Fset_file_selinux_context):
89 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
91 2012-04-20 Eli Zaretskii <eliz@gnu.org>
93 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
94 overrun array limits of glyph row's used[] array. (Bug#11288)
96 2012-04-20 Chong Yidong <cyd@gnu.org>
98 * process.c (wait_reading_process_output): If EIO occurs on a pty,
99 set the status to "failed" and ensure that sentinel is run.
101 2012-04-18 Glenn Morris <rgm@gnu.org>
103 * process.c (Fset_process_inherit_coding_system_flag)
104 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
105 (Fmake_network_process, Fmake_serial_process): Doc fix.
107 2012-04-17 Eli Zaretskii <eliz@gnu.org>
109 * xdisp.c (string_buffer_position_lim): Limit starting position to
111 (set_cursor_from_row): If called for a mode-line or header-line
112 row, return zero immediately.
113 (try_cursor_movement): If inside continuation line, don't back up
114 farther than the first row after the header line, if any. Don't
115 consider the header-line row as "partially visible", even if
116 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
118 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
120 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
122 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
124 * process.c (make_process):
125 * process.h: Add integer `gnutls_handshakes_tried' member to
128 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
129 Add convenience `GNUTLS_LOG2i' macro.
131 * gnutls.c (gnutls_log_function2i): Convenience log function.
132 (emacs_gnutls_read): Use new log functions,
133 `gnutls_handshakes_tried' process member, and
134 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
135 attempts per process (connection).
137 2012-04-09 Eli Zaretskii <eliz@gnu.org>
139 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
140 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
142 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
144 * nsterm.m (constrainFrameRect): Always constrain when there is only
145 one screen (Bug#10962).
147 2012-04-06 Eli Zaretskii <eliz@gnu.org>
149 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
150 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
151 about subtle differences between FETCH_CHAR* and STRING_CHAR*
152 macros related to unification of CJK characters. For the details,
153 see the discussion following the message here:
154 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
156 2012-04-04 Chong Yidong <cyd@gnu.org>
158 * keyboard.c (Vdelayed_warnings_list): Doc fix.
160 2012-04-01 Eli Zaretskii <eliz@gnu.org>
162 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
163 instead of alloca. (Bug#11138)
165 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
167 * w32menu.c (is_simple_dialog): Properly check lisp types.
170 2012-03-31 Eli Zaretskii <eliz@gnu.org>
172 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
173 position we get to after a call to move_it_to fails the
174 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
175 only if we wind up in a string from display property. (Bug#11063)
177 * window.c (Fdelete_other_windows_internal): Invalidate the row
178 and column information about mouse highlight, so that redisplay
179 restores it after reallocating the glyph matrices. (Bug#7464)
181 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
182 string comes from a `display' text property, use the buffer
183 position of that property as if we actually saw that position in
185 (move_it_by_lines): Remove the assertion that
186 "it->current_x == 0 && it->hpos == 0" which can be legitimately
187 violated when there's a before-string at the beginning of a line.
190 2012-03-30 Eli Zaretskii <eliz@gnu.org>
192 * xdisp.c (append_space_for_newline): If the default face was
193 remapped, use the remapped face for the appended newline.
194 (extend_face_to_end_of_line): Use the remapped default face for
195 extending the face to the end of the line.
196 (display_line): Call extend_face_to_end_of_line when the default
197 face was remapped. (Bug#11068)
199 2012-03-29 Eli Zaretskii <eliz@gnu.org>
201 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
203 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
205 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
207 2012-03-27 Glenn Morris <rgm@gnu.org>
209 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
212 2012-03-26 Kenichi Handa <handa@m17n.org>
214 * dispextern.h (struct glyph): Fix previous change. Change the
215 bit length of glyphless.ch to 25 (Bug#11082).
217 2012-03-26 Chong Yidong <cyd@gnu.org>
219 * keyboard.c (Vselection_inhibit_update_commands): New variable.
220 (command_loop_1): Use it; inhibit selection update for
221 handle-select-window too (Bug#8996).
223 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
225 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
227 2012-03-25 Kenichi Handa <handa@m17n.org>
229 * dispextern.h (struct glyph): Change the bit length of
230 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
232 2012-03-24 Eli Zaretskii <eliz@gnu.org>
234 * s/ms-w32.h (tzname): Include time.h before redirecting to
235 _tzname. Fixes the MSVC build. (Bug#9960)
237 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
239 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
242 * xterm.c (XTread_socket): Only modify handling_signal if
243 !SYNC_INPUT. (Bug#11080)
245 2012-03-23 Eli Zaretskii <eliz@gnu.org>
247 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
248 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
249 when fetching a multibyte character consumes more bytes than
250 CHAR_BYTES returns, due to unification of CJK characters in
251 string_char. (Bug#11073)
253 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
255 * process.c (wait_reading_process_output): Handle pty disconnect
256 by refraining from sending oneself a SIGCHLD (bug#10933).
258 2012-03-22 Chong Yidong <cyd@gnu.org>
260 * dispextern.h (struct it): New member string_from_prefix_prop_p.
262 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
263 Mark string as coming from a prefix property.
264 (handle_face_prop): Use default face for prefix strings (Bug#4281).
265 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
267 2012-03-21 Chong Yidong <cyd@gnu.org>
269 * xfaces.c (Vface_remapping_alist): Doc fix.
271 2012-03-20 Eli Zaretskii <eliz@gnu.org>
273 * w32proc.c (Fw32_set_console_codepage)
274 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
277 2012-03-20 Chong Yidong <cyd@gnu.org>
279 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
280 to reflect default non-nil value of redisplay-dont-pause.
282 2012-03-19 Kenichi Handa <handa@m17n.org>
284 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
285 it fit in a valid range (Bug#11003).
287 2012-03-18 Eli Zaretskii <eliz@gnu.org>
289 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
290 that is not from display property, accept the row as a "cursor
291 row" if one of the string's character has a non-nil `cursor'
292 property. Fixes cursor positioning when there are newlines in
293 overlay strings, e.g. in icomplete.el. (Bug#11035)
295 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
297 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
299 2012-03-12 Chong Yidong <cyd@gnu.org>
301 * eval.c (inhibit_lisp_code): Rename from
302 inhibit_window_configuration_change_hook; move from window.c.
304 * xfns.c (unwind_create_frame_1, Fx_create_frame):
305 * window.c (run_window_configuration_change_hook)
306 (syms_of_window): Callers changed.
308 2012-03-11 Chong Yidong <cyd@gnu.org>
310 * keymap.c (Fkey_description): Doc fix (Bug#9700).
312 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
314 2012-03-10 Chong Yidong <cyd@gnu.org>
316 * frame.c (other_visible_frames): Don't assume the selected frame
317 is visible (Bug#10955).
319 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
321 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
323 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
325 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
326 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
329 2012-03-03 Glenn Morris <rgm@gnu.org>
331 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
333 2012-03-02 Eli Zaretskii <eliz@gnu.org>
335 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
336 position past the first glyph_row that ends at ZV. (Bug#10902)
337 (redisplay_window, next_element_from_string): Fix typos in
339 (redisplay_window): Pass to move_it_vertically the margin in
340 pixels, not in screen lines.
342 2012-03-02 Glenn Morris <rgm@gnu.org>
344 * buffer.c (buffer-list-update-hook): Doc fix.
346 2012-02-29 Eli Zaretskii <eliz@gnu.org>
348 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
349 push_it before setting up the iterator for the first overlay
350 string, even if we have an empty string loaded.
351 (next_overlay_string): If there's an empty string on the iterator
352 stack, pop the stack. (Bug#10903)
354 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
356 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
357 Suggested by Stefan Monnier in
358 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
359 * alloc.c (widen_to_Lisp_Object): New static function.
360 (mark_memory): Also mark Lisp_Objects by fetching pointer words
361 and widening them to Lisp_Objects. This would work even if
362 USE_LSB_TAG is defined and wide integers are used, which might
363 happen in a future version of Emacs.
365 2012-02-25 Chong Yidong <cyd@gnu.org>
367 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
370 * xselect.c (Fx_selection_exists_p): Doc fix.
371 (x_clipboard_manager_save_all): Print an informative message
372 before saving to clipboard manager.
374 2012-02-24 Chong Yidong <cyd@gnu.org>
376 * keyboard.c (process_special_events): Handle all X selection
377 requests in kbd_buffer, not just the next one (Bug#8869).
379 2012-02-23 Chong Yidong <cyd@gnu.org>
381 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
382 call when setting menu-bar-lines and tool-bar-lines parameters.
383 (unwind_create_frame_1): New helper function.
385 * window.c (inhibit_window_configuration_change_hook): New var.
386 (run_window_configuration_change_hook): Obey it.
387 (syms_of_window): Initialize it.
389 2012-02-22 Chong Yidong <cyd@gnu.org>
391 * xterm.c (x_draw_image_relief): Add missing type check for
392 Vtool_bar_button_margin (Bug#10743).
394 2012-02-21 Chong Yidong <cyd@gnu.org>
396 * fileio.c (Vfile_name_handler_alist): Doc fix.
398 * buffer.c (Fget_file_buffer): Protect against invalid file
399 handler return value.
401 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
403 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
404 when computing $valmask.
406 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
407 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
408 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
409 It's useless in that case, and it can cause problems on hosts
410 that allocate halves of EMACS_INT values separately.
411 Reported by Dan Horák. Diagnosed by Andreas Schwab in
412 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
413 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
414 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
415 it avoids undefined behavior on hosts where shifting right by more
416 than the word width has undefined behavior.
418 2012-02-19 Chong Yidong <cyd@gnu.org>
420 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
421 (Funhandled_file_name_directory, Ffile_name_as_directory)
422 (Fdirectory_file_name, Fexpand_file_name)
423 (Fsubstitute_in_file_name): Protect against invalid file handler
424 return values (Bug#10845).
426 2012-02-18 Eli Zaretskii <eliz@gnu.org>
428 * .gdbinit (pitx): Fix incorrect references to fields of the
431 2012-02-17 Chong Yidong <cyd@gnu.org>
433 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
435 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
437 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
438 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
440 2012-02-15 Chong Yidong <cyd@gnu.org>
442 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
443 marked as special. Also, starting docstrings with * is obsolete.
445 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
447 * gnutls.c (emacs_gnutls_write): Fix last change.
449 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
451 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
454 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
456 * keymap.c (Fsingle_key_description): Handle char ranges.
458 2012-02-12 Chong Yidong <cyd@gnu.org>
460 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
461 as that creates a dangerous corner case.
463 * window.c (Fdelete_window_internal): Invalidate the mouse
464 highlight (Bug#9904).
466 2012-02-12 Glenn Morris <rgm@gnu.org>
468 * xselect.c (Fx_own_selection_internal)
469 (Fx_get_selection_internal, Fx_disown_selection_internal)
470 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
471 * nsselect.m (Fx_own_selection_internal)
472 (Fx_disown_selection_internal, Fx_selection_exists_p)
473 (Fx_selection_owner_p, Fx_get_selection_internal):
474 Sync docs and argument specs with the xselect.c versions.
476 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
478 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
480 2012-02-11 Eli Zaretskii <eliz@gnu.org>
482 * w32select.c (Fx_selection_exists_p): Sync doc string and
483 argument list with xselect.c. (Bug#10783)
485 * w16select.c (Fx_selection_exists_p): Sync doc string and
486 argument list with xselect.c. (Bug#10783)
488 2012-02-10 Glenn Morris <rgm@gnu.org>
490 * fns.c (Fsecure_hash): Doc fix.
492 2012-02-09 Kenichi Handa <handa@m17n.org>
494 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
496 2012-02-07 Chong Yidong <cyd@gnu.org>
498 * buffer.c (Fbuffer_local_variables)
499 (buffer_lisp_local_variables): Handle unbound vars correctly;
500 don't let Qunbound leak into Lisp.
502 2012-02-07 Glenn Morris <rgm@gnu.org>
504 * image.c (Fimagemagick_types): Doc fix.
506 * image.c (imagemagick-render-type): Change it from a lisp object
507 to an integer. Move the doc here from the lisp manual.
508 Treat all values not equal to 0 the same.
510 2012-02-06 Chong Yidong <cyd@gnu.org>
512 * doc.c (store_function_docstring): Avoid applying docstring of
513 alias to base function (Bug#2603).
515 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
517 * .gdbinit (pp1, pv1): Remove redundant defines.
520 2012-02-04 Chong Yidong <cyd@gnu.org>
522 * nsterm.m: Declare a global (Bug#10694).
524 2012-02-04 Eli Zaretskii <eliz@gnu.org>
526 * w32.c (get_emacs_configuration_options):
527 Include --enable-checking, if specified, in the return value.
529 2012-02-04 Martin Rudalics <rudalics@gmx.at>
531 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
532 after rounding frame sizes. (Bug#9723)
534 2012-02-04 Eli Zaretskii <eliz@gnu.org>
536 * keyboard.c (adjust_point_for_property): Don't position point
537 before BEGV. (Bug#10696)
539 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
541 Handle overflow when computing char display width (Bug#9496).
542 * character.c (char_width): Return EMACS_INT, not int.
543 (char_width, c_string_width): Check for overflow when
544 computing the width; this is possible now that individual
545 characters can have unbounded width. Problem introduced
546 by merge from Emacs 23 on 2012-01-19.
548 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
550 * dbusbind.c (Fdbus_register_method): Mention the return value
551 :ignore in the docstring.
553 2012-02-02 Glenn Morris <rgm@gnu.org>
555 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
557 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
558 Unconditionally set to t. (Bug#10673)
559 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
560 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
561 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
563 2012-02-02 Kenichi Handa <handa@m17n.org>
565 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
566 0, do not call append_composite_glyph.
568 2012-02-02 Kenichi Handa <handa@m17n.org>
570 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
572 (x_produce_glyphs): If the component of a composition is a null
573 string, set it->pixel_width to 1 to avoid zero-width glyph.
575 2012-02-01 Eli Zaretskii <eliz@gnu.org>
577 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
578 first 2 arguments are identical. This makes inserting large
579 output from a subprocess an order of magnitude faster on
580 MS-Windows, where all sbrk'ed memory is always contiguous.
582 2012-01-31 Glenn Morris <rgm@gnu.org>
584 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
585 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
586 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
588 2012-01-29 Glenn Morris <rgm@gnu.org>
590 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
592 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
594 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
596 2012-01-28 Chong Yidong <cyd@gnu.org>
598 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
600 2012-01-26 Chong Yidong <cyd@gnu.org>
602 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
604 * search.c (Fsearch_forward, Fsearch_backward): Document negative
605 repeat counts (Bug#10507).
607 2012-01-26 Glenn Morris <rgm@gnu.org>
609 * lread.c (syms_of_lread): Doc fix.
611 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
613 * coding.c (encode_designation_at_bol): Change return value to
616 2012-01-25 Chong Yidong <cyd@gnu.org>
618 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
620 2012-01-21 Chong Yidong <cyd@gnu.org>
622 * floatfns.c (Fcopysign): Make the second argument non-optional,
623 since nil is not allowed anyway.
625 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
627 * process.c (read_process_output): Use p instead of XPROCESS (proc).
628 (send_process): Likewise.
630 2012-01-19 Martin Rudalics <rudalics@gmx.at>
632 * window.c (save_window_save, Fcurrent_window_configuration)
633 (Vwindow_persistent_parameters): Do not use Qstate.
636 2012-01-19 Kenichi Handa <handa@m17n.org>
638 * character.c (char_width): New function.
639 (Fchar_width, c_string_width, lisp_string_width):
640 Use char_width (Bug#9496).
642 2012-01-16 Martin Rudalics <rudalics@gmx.at>
644 * window.c (Vwindow_persistent_parameters): New variable.
645 (Fset_window_configuration, save_window_save): Handle persistent
648 2012-01-14 Eli Zaretskii <eliz@gnu.org>
650 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
651 thrashing the stack of the thread. (Bug#9087)
653 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
655 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
657 2012-01-11 Eli Zaretskii <eliz@gnu.org>
659 * xdisp.c (rows_from_pos_range): Handle the case where the
660 highlight ends on a newline. (Bug#10464)
661 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
662 he end column for display of highlight that ends on a newline
665 2012-01-11 Glenn Morris <rgm@gnu.org>
667 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
668 from load-path also when installation-directory is nil. (Bug#10208)
670 2012-01-10 Glenn Morris <rgm@gnu.org>
672 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
674 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
675 Update template values to be closer to their typical values these days.
677 2012-01-09 Eli Zaretskii <eliz@gnu.org>
679 * xdisp.c (rows_from_pos_range): Accept additional argument
680 DISP_STRING, and accept any glyph in a row whose object is that
681 string as eligible for mouse highlight. Fixes mouse highlight of
682 display strings from overlays. (Bug#10464)
684 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
686 emacs: fix an auto-save permissions race condition (Bug#10400)
687 * fileio.c (auto_saving_dir_umask): New static var.
688 (Fmake_directory_internal): Use it.
689 (do_auto_save_make_dir): Set it, instead of invoking chmod after
690 creating the directory. The old code temporarily assigns
691 too-generous permissions to the directory.
692 (do_auto_save_eh): Clear it.
693 (Fdo_auto_save): Catch all errors, not just file errors, so
694 that the var is always cleared.
696 2012-01-07 Eli Zaretskii <eliz@gnu.org>
698 * search.c (scan_buffer): Pass character positions to
699 know_region_cache, not byte positions. (Bug#6540)
701 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
703 * w32.c (sys_rename): Report EXDEV when rename of a directory
704 fails because the target is on another logical disk. (Bug#10284)
706 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
708 * xterm.c (x_embed_request_focus): New function.
710 * xterm.h: Add prototype.
712 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
714 2012-01-05 Glenn Morris <rgm@gnu.org>
716 * emacs.c (emacs_copyright): Update short copyright year to 2012.
718 2012-01-01 Eli Zaretskii <eliz@gnu.org>
720 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
721 Load gnutls_transport_set_lowat only if GnuTLS version is below
723 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
724 GnuTLS versions below 2.11.1.
726 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
728 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
729 to the doc string advising against its use for altering the way
730 windows are scrolled.
732 2011-12-28 Kenichi Handa <handa@m17n.org>
734 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
735 coding-system ASCII compatible only when it does not produce BOM
736 on encoding (Bug#10383).
738 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
740 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
742 (create_and_show_popup_menu): Always use menu_position_func for
745 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
747 * callint.c (Fcall_interactively): Don't truncate prompt string.
749 2011-12-23 Eli Zaretskii <eliz@gnu.org>
751 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
752 property that ends at ZV, so that the bidi iteration could be
753 resumed from there (after widening). (Bug#10360)
755 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
757 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
759 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
761 * nsterm.m (x_free_frame_resources):
762 Release f->output_data.ns->miniimage.
763 (ns_index_color): Fix indentation. Do not retain
764 color_table->colors[i].
766 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
769 * nsfns.m (x_set_background_color): Assign return value from
770 ns_index_color to face-background instead of NSColor*.
771 (ns_implicitly_set_icon_type): Fix indentation.
772 Change assignment in for loop to comparison.
774 * emacs.c (ns_pool): New variable.
775 (main): Assign ns_pool.
776 (Fkill_emacs): Call ns_release_autorelease_pool.
778 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
779 autorelease fdesc, release fdAttrs and tdict.
780 (ns_get_covering_families): Release charset.
781 (ns_findfonts): Release NSFontDescriptor created with new.
782 (ns_uni_to_glyphs): Fix indentation.
783 (setString): Release attrStr before assigning new value.
785 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
787 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
789 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
790 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
792 2011-12-18 David Reitter <reitter@cmu.edu>
794 * nsterm.m (ns_term_init): Subscribe for notifications
795 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
796 to method trackingNotification in EmacsMenu.
798 * nsmenu.m (trackingMenu): New variable.
799 (trackingNotification): New method (from Aquamacs).
800 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
801 from Aquamacs (Bug#7030).
803 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
805 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
806 (symbol_to_nsstring): Fix indentation.
807 (ns_symbol_to_pb): New function.
808 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
809 (Fns_rotate_cut_buffers_internal): Remove.
810 (Fns_store_selection_internal): Rename from
811 Fns_store_cut_buffer_internal.
812 (ns_get_foreign_selection, Fx_own_selection_internal)
813 (Fx_disown_selection_internal, Fx_selection_exists_p)
814 (Fns_get_selection_internal, Fns_store_selection_internal):
815 Use ns_symbol_to_pb and check if return value is nil.
816 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
817 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
818 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
819 renamed to Sns_store_selection_internal.
820 (ns_handle_selection_request): Move code to Fx_own_selection_internal
821 and remove this function.
822 (ns_handle_selection_clear): Remove, never used.
823 (Fx_own_selection_internal): Move code from ns_handle_selection_request
826 2011-12-17 Ken Brown <kbrown@cornell.edu>
828 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
829 GID is unknown (Bug#10257).
831 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
833 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
834 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
835 which caused a build failure on GNU/Linux IA-64. This problem was
836 introduced by my 2011-10-07 patch.
838 2011-12-15 Juri Linkov <juri@jurta.org>
840 * image.c (imagemagick_error): New function. (Bug#10112)
841 (imagemagick_load_image): Comment out `MagickSetResolution' call.
842 Use `imagemagick_error' where ImageMagick functions return
844 (Fimagemagick_types): Add `Fnreverse' to return the list in the
847 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
849 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
850 fill background (Bug#8992).
852 2011-12-13 Martin Rudalics <rudalics@gmx.at>
854 * window.c (Vwindow_combination_resize)
855 (Vwindow_combination_limit): Use t instead of non-nil in
857 (Vrecenter_redisplay): Add first sentence of doc-string on
859 (Frecenter): Fix doc-string typo.
861 2011-12-11 Kenichi Handa <handa@m17n.org>
863 * coding.c (Funencodable_char_position): Pay attention to the
864 buffer text relocation (Bug#9389).
866 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
868 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
869 gtk_init (Bug#10100).
871 2011-12-10 Eli Zaretskii <eliz@gnu.org>
873 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
874 IT->string is nil. (Bug#10263)
876 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
878 * nsterm.h (x_free_frame_resources): Declare.
880 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
881 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
883 * nsterm.h (ns_get_defaults_value): Declare.
885 * nsterm.m (ns_default): Call ns_get_defaults_value.
887 2011-12-09 Eli Zaretskii <eliz@gnu.org>
889 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
892 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
894 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
895 that where the value of an _OBJC_* symbol points to is in the .bss
898 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
900 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
901 after the loop to call ccl_driver at least once (Bug#8619).
903 2011-12-08 Kenichi Handa <handa@m17n.org>
905 * ftfont.c (get_adstyle_property): Fix previous change
908 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
910 * w32.c (init_environment): If no_site_lisp, remove site-lisp
911 dirs from the default value of EMACSLOADPATH (bug#10208).
913 2011-12-07 Glenn Morris <rgm@gnu.org>
915 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
916 installation and source directories as well. (Bug#10208)
918 2011-12-06 Chong Yidong <cyd@gnu.org>
920 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
922 2011-12-06 Glenn Morris <rgm@gnu.org>
924 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
925 as an error, not just -1. (Bug#10217)
927 2011-12-05 Chong Yidong <cyd@gnu.org>
929 * keyboard.c (process_special_events): New function.
930 (swallow_events, Finput_pending_p): Use it (Bug#10195).
932 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
934 * coding.c (encode_designation_at_bol): Don't use uninitialized
935 local variable (Bug#9318).
937 2011-12-05 Kenichi Handa <handa@m17n.org>
939 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
940 return Qnil (Bug#8046, Bug#10193).
942 2011-12-05 Kenichi Handa <handa@m17n.org>
944 * coding.c (encode_designation_at_bol): New args charbuf_end and
945 dst. Return the number of produced bytes. Callers changed.
946 (coding_set_source): Return how many bytes coding->source was
948 (coding_set_destination): Return how many bytes
949 coding->destination was relocated.
950 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
951 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
953 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
955 * coding.c (CODING_CHAR_CHARSET_P): New macro.
956 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
959 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
961 The following changes are to fix Bug#9318.
963 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
964 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
965 (encode_coding_iso_2022, encode_coding_sjis)
966 (encode_coding_big5, encode_coding_charset): Use the above macros.
968 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
970 * lisp.h (process_quit_flag): Fix external declaration.
972 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
974 Don't macro-inline non-performance-critical code.
975 * eval.c (process_quit_flag): New function.
976 * lisp.h (QUIT): Use it.
978 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
980 * nsfns.m (get_geometry_from_preferences): New function.
981 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
983 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
985 * emacs.c (Qkill_emacs): Define.
986 (syms_of_emacs): Initialize it.
987 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
988 Qquit_flag to `kill-emacs' instead.
989 (quit_throw_to_read_char): Add parameter `from_signal'.
990 All callers changed. Call Fkill_emacs if requested and safe.
991 * lisp.h (QUIT): Call Fkill_emacs if requested.
993 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
995 * widget.c (update_wm_hints): Return if wmshell is null.
996 (widget_update_wm_size_hints): New function.
998 * widget.h (widget_update_wm_size_hints): Declare.
1000 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1001 widget_update_wm_size_hints (Bug#10104).
1003 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1005 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1006 before a newline, prepare the bidi iterator for consuming the
1007 newline, and keep the current paragraph direction. (Bug#10183)
1008 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1010 2011-12-02 Juri Linkov <juri@jurta.org>
1012 * search.c (Fword_search_regexp): New Lisp function created from
1013 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1014 (Fword_search_backward, Fword_search_forward)
1015 (Fword_search_backward_lax, Fword_search_forward_lax):
1016 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1017 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1019 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1021 * fileio.c (Finsert_file_contents): Move after-change-function call
1022 to before the "handled:" label, since all "goto handled" appear in
1023 cases where the *-change-functions have already been properly called
1026 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1028 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1029 waiting for input. (Bug#10169)
1031 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1033 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1034 verifies glyph row's hash code--we have just reallocated the
1035 glyphs, so their contents can be complete garbage. (Bug#10164)
1037 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1039 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1041 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1043 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1044 attributes are tested _before_ calling verify_row_hash, to protect
1045 against GCC re-ordering of the tests. (Bug#10164)
1047 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1049 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1051 * xterm.c (handle_one_xevent): Only set async_visible and friends
1052 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1053 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1054 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1056 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1058 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1059 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1060 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1061 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1062 All uses changed to use GCPRO1 etc.
1063 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1064 Revert to old implementation (i.e., before 2011-03-11).
1066 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1068 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1069 of scroll runs so as to avoid assigning disabled bogus rows and
1070 unnecessary graphics copy operations.
1072 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1074 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1075 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1076 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1077 (malloc, free, realloc, calloc): Redirect to e_* only when
1080 * lisp.h (GCTYPEBITS): Move before first use.
1081 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1082 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1083 this macro definition.
1085 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1088 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1090 * gtkutil.c (xg_create_frame_widgets):
1091 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1092 present with Gtk+ 2.0.
1094 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1096 * fileio.c (Finsert_file_contents): Undo previous change; see
1097 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1099 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1101 Rename locals to avoid shadowing.
1102 * fileio.c (Finsert_file_contents):
1103 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1104 * process.c (wait_reading_process_output):
1105 Rename inner 'proc' to 'p' to avoid shadowing.
1106 Indent for consistency with usual Emacs style.
1108 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1110 * xdisp.c (redisplay_window): If cursor row is not fully visible
1111 after recentering, and scroll-conservatively is set to a large
1112 number, scroll window by a few more lines to make the cursor fully
1113 visible and out of scroll-margin. (Bug#10105)
1114 (start_display): Don't move to the next line if the display should
1115 start at a newline that is part of a display vector or an overlay
1118 2011-11-24 Juri Linkov <juri@jurta.org>
1120 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1121 after the `MagickPingImage' call. (Bug#10112)
1123 2011-11-23 Chong Yidong <cyd@gnu.org>
1125 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1127 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1129 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1130 making another buffer current. (Bug#10114)
1132 2011-11-23 Glenn Morris <rgm@gnu.org>
1134 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1136 2011-11-23 Chong Yidong <cyd@gnu.org>
1138 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1139 using it (Bug#5984).
1141 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1143 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1144 and header-lines, as they don't have one computed for them.
1147 * .gdbinit (prow): Make displayed values more self-explaining.
1148 Add row's hash code.
1150 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1152 * process.c (wait_reading_process_output): Fix asynchrounous
1153 GnuTLS socket handling on some versions of the GnuTLS library.
1154 (wait_reading_process_output): Add comment and URL.
1156 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1158 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1160 2011-11-21 Chong Yidong <cyd@gnu.org>
1162 * window.c (Fnext_window, Fprevious_window): Doc fix.
1164 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1166 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1168 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1170 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1172 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1174 * window.c (Fset_window_combination_limit): Rename argument
1176 (Vwindow_combination_limit): Remove "status" from doc-string.
1178 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1180 * m/ibms390.h: Remove.
1181 * m/ibms390x.h: Don't include "ibms390.h".
1183 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1185 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1186 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1188 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1190 * casetab.c (Fset_case_table):
1191 * charset.c (Fcharset_after): Fix typos.
1193 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1195 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1196 Otherwise, valgrind does not work on some platforms.
1197 Problem reported by Andreas Schwab in
1198 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1199 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1200 is set, removing the need for VIRT_ADDRESS_VARIES.
1201 (PURE_P): Use a more-efficient implementation that needs just one
1202 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1203 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1204 to 4 (xorl, subq, cmpq, setbe).
1205 * alloc.c (pure): Always extern now, since that's the
1206 VIRT_ADDR_VARIES behavior.
1207 (PURE_POINTER_P): Use a single comparison, not two, for
1208 consistency with the new puresize.h.
1209 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1210 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1211 Remove VIRT_ADDR_VARIES no longer needed.
1213 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1215 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1216 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1217 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1218 behave as if the cursor position were at the window margin.
1220 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1221 and the cursor position is out of bounds, behave as if the cursor
1222 position were at the window margin. (Bug#10075)
1224 2011-11-18 Chong Yidong <cyd@gnu.org>
1226 * window.c (Fwindow_combination_limit): Make first argument
1227 non-optional, since it is meaningless for live windows like the
1230 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1232 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1234 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1236 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1237 (graft_intervals_into_buffer): Simplify.
1239 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1241 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1242 hash values of the two rows.
1243 (copy_row_except_pointers): Preserve the used[] arrays and the
1244 hash values of the two rows. (Bug#10035)
1245 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1247 * xdisp.c (row_hash): New function, body extracted from
1248 compute_line_metrics.
1249 (compute_line_metrics): Call row_hash, instead of computing the
1252 * dispnew.c (verify_row_hash): Call row_hash for computing the
1253 hash code of a row, instead of duplicating code from xdisp.c.
1255 * dispextern.h (row_hash): Add prototype.
1257 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1259 * frame.c (delete_frame): Don't delete the terminal when the last
1260 X frame is closed if emacs is built with GTK toolkit.
1262 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1264 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1266 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1268 * window.c (Vwindow_splits): Rename to
1269 Vwindow_combination_resize. Suggested by Juri Linkov.
1270 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1273 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1275 * nsfns.m (Fns_font_name):
1276 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1278 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1280 * window.h (window): Rename slot "nest" to "combination_limit".
1281 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1282 (Fset_window_nest): Rename to Fset_window_combination_limit.
1283 (Vwindow_nest): Rename to Vwindow_combination_limit.
1284 (recombine_windows, make_parent_window, make_window)
1285 (Fsplit_window_internal, saved_window)
1286 (Fset_window_configuration, save_window_save): Rename all
1287 occurrences of window_nest to window_combination_limit.
1289 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1291 * image.c (imagemagick_load_image): Fix typo.
1293 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1295 * xdisp.c (display_line): Move the call to
1296 highlight_trailing_whitespace before the call to
1297 compute_line_metrics, since the latter needs to see the final
1298 faces of all the glyphs to compute ROW's hash value.
1299 Fixes assertion violations in row_equal_p. (Bug#10035)
1301 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1303 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1304 just return (bug#10044).
1306 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1308 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1309 with user-defined heap size. Bump the default size of the temacs
1310 heap to 27MB, to avoid memory warning when running temacs.
1311 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1313 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1314 current_matrix and desired_matrix. (Bug#9990)
1315 (verify_row_hash) [XASSERTS]: New function.
1316 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1317 that the hash value of glyph rows is correct.
1319 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1321 * window.h (window): Remove splits slot.
1322 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1323 (Fdelete_other_windows_internal, make_parent_window)
1324 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1325 (Fset_window_configuration, save_window_save): Don't deal with
1326 split status of windows.
1327 (saved_window): Remove splits slot.
1328 (Vwindow_splits): Rewrite doc-string.
1330 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1332 * xfns.c (unwind_create_frame):
1333 * nsfns.m (unwind_create_frame):
1334 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1335 Vframe_list (Bug#9999).
1337 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1339 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1341 2011-11-11 Kenichi Handa <handa@m17n.org>
1343 * callproc.c (Fcall_process): Set the member dst_multibyte of
1346 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1348 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1349 avoid a crash (bug#9496).
1351 2011-11-09 Chong Yidong <cyd@gnu.org>
1353 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1354 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1356 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1358 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1360 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1362 Avoid some portability problems by eschewing 'extern inline' functions.
1363 The trivial performance wins aren't worth the portability hassles; see
1364 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1366 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1367 (window_box_width, window_box_left, window_box_left_offset)
1368 (window_box_right, window_box_right_offset): Undo previous change,
1369 by removing the "extern"s.
1370 * intervals.c (adjust_intervals_for_insertion)
1371 (adjust_intervals_for_deletion): Undo previous change,
1372 making these static again.
1373 (offset_intervals, temp_set_point_both, temp_set_point)
1374 (copy_intervals_to_string): No longer inline.
1375 * xdisp.c (window_text_bottom_y, window_box_width)
1376 (window_box_height, window_box_left_offset)
1377 (window_box_right_offset, window_box_left, window_box_right)
1378 (window_box): No longer inline.
1380 2011-11-08 Chong Yidong <cyd@gnu.org>
1382 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1383 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1384 Signal an error if not a live window.
1385 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1386 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1388 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1390 * lisp.h (syms_of_abbrev): Remove declaration.
1391 Reported by CHENG Gao <chenggao@royau.me>.
1393 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1395 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1396 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1397 of temacs in GUI mode.
1399 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1401 * window.h: Declare delete_all_child_windows instead of
1402 delete_all_subwindows.
1403 * window.c (Fwindow_nest, Fset_window_nest)
1404 (Fset_window_new_total, Fset_window_new_normal)
1405 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1406 (delete_all_subwindows): Rename to delete_all_child_windows.
1407 (Fdelete_other_windows_internal, Fset_window_configuration):
1408 Call delete_all_child_windows instead of delete_all_subwindows.
1409 * frame.c (delete_frame): Call delete_all_child_windows instead
1410 of delete_all_subwindows.
1412 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1414 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1415 This is also needed for porting to any host where GC_MARK_STACK is
1416 not GC_MAKE_GCPROS_NOOPS.
1417 (which_symbols): Use it.
1419 2011-11-07 Kenichi Handa <handa@m17n.org>
1421 * coding.c (coding_set_destination): Check coding->src_pos only
1422 when coding->src_object is a buffer (bug#9910).
1424 * process.c (send_process): Set the member src_multibyte of coding
1425 to 0 (bug#9911) when sending a unibyte text.
1427 * callproc.c (Fcall_process): Set the member src_multibyte of
1428 process_coding to 0 (bug#9912).
1430 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1432 * xmenu.c (cleanup_widget_value_tree): New function.
1433 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1434 calling free_menubar_widget_value_tree directly (Bug#9830).
1436 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1438 Fix some portability problems with 'inline'.
1439 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1440 (window_box_width, window_box_left, window_box_left_offset)
1441 (window_box_right, window_box_right_offset): Declare extern.
1442 Otherwise, these inline functions do not conform to C99 and
1443 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1444 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1445 * intervals.c (adjust_intervals_for_insertion)
1446 (adjust_intervals_for_deletion): Now extern, because otherwise the
1447 extern inline functions 'offset_intervals' couldn't refer to it.
1448 (static_offset_intervals): Remove.
1449 (offset_intervals): Rewrite using the old contents of
1450 static_offset_intervals. The old version didn't conform to C99
1451 because an extern inline function contained a reference to an
1452 identifier with static linkage.
1454 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1456 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1459 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1461 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1462 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1463 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1464 return Qleft_to_right.
1466 2011-11-06 Chong Yidong <cyd@gnu.org>
1468 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1469 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1470 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1471 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1472 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1473 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1474 (Fwindow_vscroll): Doc fix.
1475 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1476 argument, since it makes no sense to pass a live window and for
1477 consistency with window-child.
1479 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1481 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1484 2011-11-05 Jason Rumney <jasonr@gnu.org>
1486 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1487 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1489 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1490 bitwise arithmetic preventing use of unicode-sip and non-truetype
1493 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1495 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1498 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1499 initialization code to keep similarity to xfns.c after changes
1502 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1504 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1505 (unwind_create_frame): New function (Bug#9943).
1506 (Fx_create_frame): Restructure code to be more similar to the one in
1507 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1508 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1509 Move terminal->reference_count++ just before making the frame official
1512 * nsterm.m (x_free_frame_resources): New function.
1513 (x_destroy_window): Move code to x_free_frame_resources.
1515 * xfns.c (unwind_create_frame): Fix comment.
1516 (Fx_create_frame, x_create_tip_frame):
1517 Move terminal->reference_count++ just before making the frame
1518 official. Move initialization of image_cache_refcount and
1519 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1521 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1523 Support MSVC build with newer versions of Visual Studio.
1524 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1525 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1528 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1529 which are not supported by MSVC.
1530 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1531 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1533 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1535 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1537 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1539 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1541 Support MSVC build with newer versions of Visual Studio.
1542 * w32.c: Don't include w32api.h for MSVC.
1543 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1545 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1546 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1547 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1548 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1550 (alloca) [_MSC_VER]: Define to _alloca.
1552 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1554 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1556 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1558 * xdisp.c (note_mouse_highlight): If either of
1559 previous/next-single-property-change returns nil, treat that as
1560 the beginning or the end of the buffer. (Bug#9955)
1562 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1564 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1565 label is not null (Bug#9951).
1566 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1569 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1571 * window.c (Fwindow_body_size): Mention in the doc string that the
1572 return value is in frame's canonical units. (Bug#9949)
1574 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1576 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1578 * w32fns.c (unwind_create_frame): If needed, free the glyph
1579 matrices of the partially constructed frame. (Bug#9943)
1580 * xfns.c (unwind_create_frame): Likewise.
1582 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1584 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1585 Don't stop backward scan on the continuation glyph, even though
1586 its CHARPOS is positive.
1587 (mouse_face_from_buffer_pos, note_mouse_highlight):
1588 Rename cover_string to disp_string.
1590 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1592 * window.c (temp_output_buffer_show): Don't use
1593 Vtemp_buffer_show_specifiers.
1594 (Vtemp_buffer_show_specifiers): Remove unused variable.
1596 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1598 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1599 past the beginning of the current glyph matrix.
1601 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1603 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1604 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1605 HAVE_GTK3 (Bug#9869).
1607 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1608 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1610 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1612 * xterm.c: Declare x_handle_net_wm_state to return int.
1613 (handle_one_xevent): Check if we are iconified but don't have
1614 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1615 (get_current_wm_state): Return non-zero if not hidden,
1616 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1617 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1618 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1619 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1621 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1623 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1624 so that this new function doesn't get optimized away by a
1625 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1627 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1629 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1631 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1633 Fix the `xbytecode' command.
1634 * .gdbinit (xprintbytestr): New command.
1635 (xwhichsymbols): Rename from `which'; all callers changed.
1636 (xbytecode): Print the byte-code string as well.
1638 2011-10-29 Kim Storm <storm@cua.dk>
1640 * alloc.c (which_symbols): New function.
1642 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1644 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1647 2011-10-29 Glenn Morris <rgm@gnu.org>
1649 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1650 Not clear what it was for, and it causes various bugs. (Bug#9839)
1652 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1654 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1655 possible random value that matches one of those tested as
1656 condition to clear the mouse face.
1658 2011-10-28 Chong Yidong <cyd@gnu.org>
1660 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1662 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1664 * window.c (make_window): Initialize phys_cursor_on_p.
1666 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1668 * lisp.h (struct Lisp_Symbol): Update comments.
1670 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1672 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1674 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1676 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1677 <oslsachem@gmail.com> for helping to debug this.
1679 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1680 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1681 (g_b_init_get_glyph_outline_w): New static variables.
1682 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1683 (GetGlyphOutlineW_Proc): New typedefs.
1684 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1685 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1687 (w32font_open_internal, compute_metrics):
1688 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1689 instead of calling the "wide" APIs directly.
1691 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1693 * w32.h (syms_of_w32font): Add prototype.
1695 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1697 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1698 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1699 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1700 (Fmove_to_window_line): Doc fix.
1702 2011-10-27 Chong Yidong <cyd@gnu.org>
1704 * process.c (make_process): Set gnutls_state to NULL.
1706 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1707 non-NULL, regardless of GNUTLS_INITSTAGE.
1708 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1709 an error. Set process slots as soon as we allocate them.
1711 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1713 2011-10-27 Chong Yidong <cyd@gnu.org>
1715 * gnutls.c (emacs_gnutls_deinit): New function.
1716 Deallocate credentials structures as well as calling gnutls_deinit.
1717 (Fgnutls_deinit, Fgnutls_boot): Use it.
1719 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1720 (deactivate_process): Call emacs_gnutls_deinit.
1722 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1724 * image.c (x_create_x_image_and_pixmap):
1725 * w32.c (sys_rename, w32_delayed_load):
1726 * w32font.c (fill_in_logfont):
1727 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1729 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1731 * w32fns.c (w32_default_color_map): New function,
1732 extracted from Fw32_default_color_map.
1733 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1735 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1737 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1739 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1741 * keyboard.c (test_undefined): New function (bug#9751).
1742 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1744 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1746 * sysdep.c (init_sys_modes): Fix the check for the controlling
1747 terminal (Bug#6649).
1749 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1751 * dispextern.h (struct bidi_it): New member next_en_type.
1753 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1754 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1755 current character, check also for next_en_type being WEAK_EN.
1756 (bidi_resolve_weak): Don't enter the expensive loop if the current
1757 position is before next_en_pos. Record the bidi type of the first
1758 non-ET, non-BN character we find, in addition to its position.
1759 (bidi_level_of_next_char): Invalidate next_en_type when
1760 next_en_pos is over-stepped.
1762 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1764 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1765 * editfns.c: Rewrite current-time-zone so that it invokes
1766 the equivalent of (format-time-string "%Z") to get the time zone name.
1767 This fixes a bug when the time zone name contains characters that
1768 need converting from the system time locale to Emacs internal format.
1769 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1770 that patch fixed format-time-string to do the conversion, but
1771 I forgot to fix current-time-zone.
1772 (format_time_string): New function, containing most of
1773 what Fformat_time_string used to contain.
1774 (Fformat_time_string): Rewrite in terms of format_time_string.
1775 This doesn't change this function's behavior.
1776 (current-time-zone): Rewrite to use format_time_string.
1777 This fixes the bug reported by Michael Schierl in
1778 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1779 Jason Rumney's 2007-06-07 change worked around this bug, but
1781 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1783 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1785 * xdisp.c (start_display): If the character at POS is displayed
1786 via a display vector, reset IT->current.dpvec_index to zero.
1787 (try_window_reusing_current_matrix): If a line ends in a display
1788 vector or the next line starts in a display vector, continue
1789 redrawing the window even though the character position of
1790 start_row was reached.
1793 2011-10-18 Chong Yidong <cyd@gnu.org>
1795 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1796 with nobreak-char-display too.
1798 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1800 Fix part 3 of bug#9771.
1801 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1802 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1803 non-neutral characters if the current character is a paragraph
1804 separator (a.k.a. Newline). This avoids running the same
1805 expensive loop twice, once when we consume the preceding newline
1806 and the other time when the line actually needs to be displayed.
1807 Avoid the loop when we see neutrals on the base embedding level
1808 following a character whose directionality is the same as the
1809 paragraph's. This avoids running the expensive loop when a line
1810 ends in a long sequence of neutrals, like control characters.
1811 Add assertion against STRONG_AL type. Slightly rearrange code
1812 that determines the type of a neutral given the first non-neutral
1814 (bidi_level_of_next_char): Set next_en_pos to zero when
1815 invalidating its info.
1817 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1819 * xdisp.c (push_display_prop): Determine whether to record string
1820 or buffer position by IT->string, not by IT->method. Allow
1821 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1822 (move_it_vertically_backward): Don't look for character position
1823 immediately after the newline when in a continuation line.
1826 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1828 * window.c (coordinates_in_window): Rewrite and delabelize
1829 vertical border check. (Bug#5357) (Bug#9618)
1831 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1833 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1834 errors in XSetWindowBorder (bug#9310).
1836 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1838 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1839 avoid crash when xmalloc overrun checking is enabled.
1841 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1843 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1844 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1845 cursor motion with <left> and <right> arrow keys.
1847 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1848 some callers set that themselves.
1850 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1852 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1853 display string and the previous row comes from the same string and
1854 is empty. (Bug#9739) (Bug#9738)
1856 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1858 * doc.c (get_doc_string): Encode file name (bug#9735).
1860 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1862 * bidi.c (bidi_level_of_next_char):
1863 * xdisp.c (get_visually_first_element): Remove old incorrect
1864 comments regarding the Unicode Line Separator character.
1866 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1868 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1870 * alloc.c (Fgc_status): Do not access beyond zombies array
1871 boundary if nzombies > MAX_ZOMBIES.
1872 * alloc.c (dump_zombies): Add missing format specifier.
1874 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1876 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1877 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1879 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1880 Some packages use them to denote characters with modifiers.
1882 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1884 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1885 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1886 matching a pp-number. Rename parameter var to var1.
1888 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1890 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1892 2011-10-08 Glenn Morris <rgm@gnu.org>
1894 * callint.c (Fcall_interactively): Give a more explicit error for the
1895 'c' case with a non-character input. (Bug#8479)
1897 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1899 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1901 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1902 lines that are hscrolled on the left.
1904 * dispnew.c (buffer_posn_from_coords): Account for a possible
1905 presence of header-line. (Bug#4426)
1907 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1909 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1910 Don't advertise functionality which we discourage or doesn't work.
1912 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1914 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1915 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1916 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1917 this makes Emacs dump core during garbage collection on rare
1918 occasions. sizeof is obviously inferior to offsetof here, so
1919 stick with offsetof.
1920 (GC_POINTER_ALIGNMENT): New macro.
1921 (mark_memory): Omit 3rd (offset) arg; caller changed.
1922 Don't assume EMACS_INT alignment is the same as pointer alignment.
1924 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1926 * keyboard.c (read_key_sequence_remapped): New var.
1927 (read_key_sequence): Compute remapping in the right buffer.
1928 (command_loop_1): Use read_key_sequence's remapping directly.
1930 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1932 * dired.c (file_name_completion): Don't expand file name.
1933 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1934 before checking file name handler.
1936 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1937 they've been requested explicitly (bug#9591).
1939 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1941 * keymap.c (Fsingle_key_description): Use make_specified_string
1942 instead of build_string to build string from push_key_description.
1945 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1947 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1948 This fixes a Y2038 bug on 64-bit hosts.
1949 * buffer.c (reset_buffer):
1950 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1951 (Fclear_buffer_auto_save_failure):
1952 Use 0, not -1, to represent an unset failure time, since time_t
1953 might not be signed.
1955 Remove dependency on glibc malloc internals.
1956 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1957 Move back here from lisp.h, but with their new implementations.
1958 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1959 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1960 * charset.c (charset_table_init): New static var.
1961 (syms_of_charset): Use it instead of xmalloc. This removes a
1962 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1963 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1964 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1965 Move back to alloc.c.
1966 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1967 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1969 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1971 * nsterm.m (windowDidResize): Call x_set_window_size only when
1972 ns_in_resize is true. Otherwise set pixelwidth/height and
1973 call change_frame_size (Bug#9628).
1975 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1977 Port --enable-checking=all to Fedora 14 x86-64.
1978 * charset.c (syms_of_charset): Also account for glibc malloc's
1979 internal overhead when calculating the initial malloc maximum.
1981 Port --enable-checking=all to Fedora 14 x86.
1982 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1984 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1985 (overrun_check_realloc, overrun_check_free):
1986 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1987 That way, xmalloc returns a properly-aligned pointer even if
1988 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1989 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1990 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1991 into account when calculating the initial malloc maximum.
1992 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1993 Move here from alloc.c, so that charset.c can use it too.
1994 Properly align; the old code wasn't right for common 32-bit hosts
1995 when configured with --enable-checking=all.
1996 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1997 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1999 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2001 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2004 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2006 * xdisp.c (compute_display_string_end): If there's no display
2007 string at CHARPOS, return -1.
2009 * bidi.c (bidi_fetch_char): When compute_display_string_end
2010 returns a negative value, treat the character as a normal
2011 character not covered by a display string. (Bug#9624)
2013 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2015 * lread.c (Fread_from_string): Fix typo in docstring.
2017 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2019 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2020 newline, reseat the iterator instead of bidi-iterating there one
2021 character at a time. (Bug#9610)
2022 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2023 TO_CHARPOS if the bidi iterator is at base embedding level.
2025 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2027 * lread.c (readevalloop): Use correct code for NBSP.
2028 (read1): Likewise. (Bug#9608)
2030 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2032 * dbusbind.c (Fdbus_register_signal): When service is not
2033 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2035 2011-09-25 Glenn Morris <rgm@gnu.org>
2037 * buffer.c (truncate-lines): Doc fix.
2039 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2041 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2042 (Fset_window_next_buffers): Doc fix.
2044 2011-09-24 Glenn Morris <rgm@gnu.org>
2046 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2048 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2050 Fix minor problems found by static checking.
2051 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2052 * indent.c (Fvertical_motion): Fix == vs = typo.
2054 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2056 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2057 Default value is now t. Doc fix.
2059 * indent.c (Fvertical_motion): Compute and apply the overshoot
2060 logic when moving up, not only when moving down. Fix the
2061 confusing name and values of the it_overshoot_expected variable;
2062 logic changes accordingly. (Bug#9254) (Bug#9549)
2064 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2065 CHARPOS is covered by a display string which includes newlines.
2066 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2067 is covered by a display string with embedded newlines.
2069 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2071 * dbusbind.c (Fdbus_register_signal): Add match rule to
2072 Vdbus_registered_objects_table. (Bug#9581)
2073 (Fdbus_register_method, Vdbus_registered_objects_table):
2076 2011-09-24 Jim Meyering <meyering@redhat.com>
2078 do not ignore write error for any output size
2079 The previous change was incomplete.
2080 While it makes emacs --batch detect the vast majority of stdout
2081 write failures, errors were still ignored whenever the output size is
2082 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2083 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2084 && echo FAIL: ignored write error
2085 FAIL: ignored write error
2086 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2087 && echo FAIL: ignored write error
2088 FAIL: ignored write error
2089 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2091 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2093 * emacs.c (Fkill_emacs): In noninteractive mode exit
2094 non-successfully if a write error occurred on stdout. (Bug#9574)
2096 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2098 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2101 * dispextern.h (struct it): Update the comment documenting what
2104 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2106 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2107 a display string, extend search for cursor position to end of row.
2108 (find_row_edges): If the row ends in a newline from a display
2109 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2110 Handle the case of a display string with multiple newlines.
2111 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2112 non-empty line. Fixes confusing cursor motion with arrow keys at
2113 the beginning of a line that starts with whitespace.
2115 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2117 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2120 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2122 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2125 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2127 * xdisp.c (display_line): Record maximum and minimum buffer
2128 positions even if no glyphs were produced (e.g., by a zero-width
2129 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2130 buffer positions that will be removed from the glyph row because
2132 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2133 column is beyond frame width: don't subtract 1 "pixel" when
2134 computing width of the stretch.
2135 (reseat_at_next_visible_line_start): Undo the change made on
2136 2011-09-17 that saved paragraph information and restored it after
2137 the call to `reseat'. (Bug#9545)
2139 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2141 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2142 and turn window cursor on if cleared (Bug#9415).
2144 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2146 * search.c (boyer_moore): Take unibyte characters from pattern
2147 literally. (Bug#9458)
2149 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2151 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2153 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2155 Fix minor problem found by static checking.
2156 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2157 initialized, to pacify gcc -Wuninitialized.
2159 * fileio.c: Report proper errno when syscall falls.
2160 (Finsert_file_contents): Save and restore errno,
2161 so that report_file_error outputs the correct diagnostic.
2162 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2164 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2166 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2168 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2170 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2171 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2173 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2175 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2176 about the current paragraph and restore it after the call to reseat.
2178 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2179 (bidi_find_paragraph_start): Search back for paragraph beginning
2180 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2181 (bidi_move_to_visually_next): Only trigger paragraph-related
2182 computations when the last character is a newline or at EOB, not
2183 just any NEUTRAL_B. (Bug#9470)
2185 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2186 truncated lines if point is covered by a display string. (Bug#9524)
2188 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2190 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2191 (cons_to_x_long): New function.
2192 (lisp_data_to_selection_data): Use it. Correct the test for
2193 short-versus-long data; it was negated. Break out of vector
2194 loop, for efficiency, when a long datum is discovered.
2196 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2198 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2200 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2202 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2203 GCC PR/17406) by declaring this function with external scope.
2205 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2207 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2208 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2210 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2212 * editfns.c (Fformat): Correctly handle text properties on "%%".
2214 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2216 * xterm.c (x_draw_composite_glyph_string_foreground):
2217 * w32term.c (x_draw_composite_glyph_string_foreground):
2218 * term.c (encode_terminal_code):
2219 * composite.c (composition_update_it, get_composition_id):
2220 * xdisp.c (get_next_display_element)
2221 (fill_composite_glyph_string): Add comments about special meaning
2222 of TAB characters in a composition.
2224 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2226 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2227 This occurs when processing a multibyte format.
2228 Problem reported by Wolfgang Jenker.
2230 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2232 * xdisp.c (try_cursor_movement): Only check for exact match if
2233 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2235 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2237 Remove unused external symbols.
2238 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2239 * xdisp.c (calc_pixel_width_or_height): Now static.
2240 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2241 * indent.c (check_display_width):
2242 * w32term.c: Fix comment to match code.
2243 * xterm.c, xterm.h (x_catching_errors): Remove.
2245 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2247 * xselect.c: Use signed conversions more consistently (Bug#9498).
2248 (selection_data_to_lisp_data): Assume incoming selection data are
2249 signed integers, not unsigned. This is to be consistent with
2250 outgoing selection data, which was modified to use signed integers
2251 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2252 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2253 expects long, not unsigned long.
2255 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2257 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2258 computation of loop end. Reported by Johan Bockgård
2261 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2263 * frame.c (Fother_visible_frames_p): Function deleted.
2265 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2267 * indent.c (compute_motion): Process display vector front to back
2268 rather than the other way around. (Bug#2496)
2270 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2272 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2274 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2276 * minibuf.c (Fread_from_minibuffer): Doc fix.
2278 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2280 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2281 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2283 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2285 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2286 value for non-existent files.
2288 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2290 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2291 set its "size" to -1. This will set the modtime_size field of
2292 the corresponding buffer to -1, which is what
2293 verify-visited-file-modtime expects for files that do not exist.
2296 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2298 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2300 * lisp.h: ... from here. push_key_description is no longer
2301 defined in keyboard.c, so its declaration should not be in
2302 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2303 logically belongs with push_key_description.
2305 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2307 * buffer.h: Include <sys/types.h> instead of <time.h>.
2308 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2309 Problem reported by Herbert J. Skuhra.
2311 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2313 * xml.c (parse_region): Make the parsing work for
2314 non-comment-starting XML files again (bug#9144).
2316 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2318 * image.c (gif_load): Fix calculation of bottom and right corner.
2321 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2323 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2324 redisplay in small windows.
2326 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2328 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2330 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2332 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2333 Operate on live windows only.
2335 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2337 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2339 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2341 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2342 only under bidi iteration.
2344 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2346 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2348 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2350 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2351 Without this fix, the command to link temacs failed due to an
2352 undefined symbol __builtin_isnan. This is because
2353 /usr/include/iso/math_c99.h #defines isnan(x) to
2354 __builtin_isnan(x), but the bundled gcc, which identifies itself
2355 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2357 * floatfns.c (isnan): #undef, and then #define to a clone of
2359 (Fisnan): Always define, since it's always available now.
2360 (syms_of_floatfns): Always define isnan at the Lisp level.
2362 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2364 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2366 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2368 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2369 The previous code assumed that file offsets (off_t values) fit in
2370 EMACS_INT variables, which is not true on typical 32-bit hosts.
2371 The code messed up by falsely reporting buffer overflow in cases
2372 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2373 when "big" contains more than 2**29 bytes, even though this
2374 inserts just one byte and does not overflow the buffer.
2375 (Finsert_file_contents): Store file offsets as off_t
2376 values, not as EMACS_INT values. Check for overflow when
2377 converting between EMACS_INT and off_t. When checking for
2378 buffer overflow or for overlap, take the offsets into account.
2379 Don't use EMACS_INT for small values where int suffices.
2380 When checking for overlap, fix a typo: ZV was used where
2381 ZV_BYTE was intended.
2382 (Fwrite_region): Don't assume off_t fits into 'long'.
2383 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2385 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2387 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2389 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2391 sprintf-related integer and memory overflow issues (Bug#9412).
2393 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2394 (esprintf, exprintf, evxprintf): New functions.
2395 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2396 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2397 (modify_event_symbol): Do not assume that the length of
2398 name_alist_or_stem is safe to alloca and fits in int.
2399 (Fexecute_extended_command): Likewise for function name and binding.
2400 (Frecursion_depth): Wrap around reliably on integer overflow.
2401 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2402 since some callers pass EMACS_INT values.
2403 (Fsingle_key_description): Don't crash if symbol name contains more
2404 than MAX_ALLOCA bytes.
2405 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2406 (get_minibuffer): Arg is now EMACS_INT, not int.
2407 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2408 (esprintf, exprintf, evxprintf): New decls.
2409 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2411 * dbusbind.c (signature_cat): New function.
2412 (xd_signature, Fdbus_register_signal):
2413 Do not overrun buffer; instead, report string overflow.
2415 * dispnew.c (add_window_display_history): Don't overrun buffer.
2416 Truncate instead; this is OK since it's just a log.
2418 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2419 even if the time zone offset is outlandishly large.
2420 Don't mishandle offset == INT_MIN.
2422 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2423 when creating daemon; the previous buffer-overflow check was incorrect.
2425 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2426 which has the guts of the old verror function.
2428 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2429 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2431 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2432 (font_unparse_xlfd): Don't blindly alloca long strings.
2433 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2434 fits in int, when using sprintf. Use single snprintf to count
2435 length of string rather than counting it via multiple sprintfs;
2436 that's simpler and more reliable.
2437 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2438 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2439 sprintf, in case result does not fit in int.
2441 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2442 (fontset_from_font): Print it.
2444 * frame.c (tty_frame_count): Now printmax_t, not int.
2445 (make_terminal_frame, set_term_frame_name): Print it.
2446 (x_report_frame_params): In X, window IDs are unsigned long,
2447 not signed long, so print them as unsigned.
2448 (validate_x_resource_name): Check for implausibly long names,
2449 and don't assume name length fits in 'int'.
2450 (x_get_resource_string): Don't blindly alloca invocation name;
2451 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2454 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2455 (xg_check_special_colors, xg_set_geometry):
2456 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2458 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2459 Use esprintf, not sprintf, in case result does not fit in int.
2461 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2462 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2463 it as a large positive number.
2464 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2465 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2467 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2468 in case result does not fit in int.
2470 * print.c (float_to_string): Detect width overflow more reliably.
2471 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2472 buffer overrun. Don't assume list length fits in 'int'. Treat
2473 print length of 0 as 0, not as infinity; to be consistent with other
2474 uses of print length in this function. Don't overflow print length
2475 index. Don't assume hash table size fits in 'long', or that
2476 vectorlike size fits in 'unsigned long'.
2478 * process.c (make_process): Use printmax_t, not int, to format
2479 process-name gensyms.
2481 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2483 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2484 to avoid potential buffer overrun.
2486 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2487 if X resource line is longer than 512 bytes.
2489 * xfns.c (x_window): Make sprintf buffer a bit bigger
2490 to avoid potential buffer overrun.
2492 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2494 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2496 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2498 Integer overflow fixes for scrolling, etc.
2499 Without these, Emacs silently mishandles large integers sometimes.
2500 For example, "C-u 4294967297 M-x recenter" was treated as if
2501 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2503 * xdisp.c (try_window_id): Check Emacs fixnum range before
2504 converting to 'int'.
2506 * window.c (window_scroll_line_based, Frecenter):
2507 Check that an Emacs fixnum is in range before assigning it to 'int'.
2508 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2509 values converted from Emacs fixnums.
2510 (Frecenter): Don't wrap around a line count if it is out of 'int'
2511 range; instead, treat it as an extreme value.
2512 (Fset_window_configuration, compare_window_configurations):
2513 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2515 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2516 that can exceed INT_MAX. Check that EMACS_INT value is in range
2517 before assigning it to the (possibly-narrower) index.
2518 (match_limit): Don't assume that a fixnum can fit in 'int'.
2520 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2523 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2524 (Fvertical_motion): Don't wrap around LINES values that don't fit
2525 in 'int'. Instead, treat them as extreme values. This is good
2526 enough for windows, which can't have more than INT_MAX lines anyway.
2528 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2530 * Require libxml/parser.h to avoid compilation warning.
2532 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2534 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2535 since this reportedly can destroy thread storage.
2537 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2539 * syntax.c (find_defun_start): Update all cache variables if
2540 exiting early (Bug#9401).
2542 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2544 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2546 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2547 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2548 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2550 * term.c (tty_append_glyph): New function.
2551 (produce_stretch_glyph): Static function and its prototype deleted.
2553 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2556 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2558 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2559 when checking :margin (Bug#9390).
2560 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2561 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2562 so that the name doesn't mislead. All uses changed.
2564 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2566 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2569 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2571 * xdisp.c (move_it_to): Don't bail out early when reaching
2572 position beyond to_charpos, if we are scanning backwards.
2573 (move_it_vertically_backward): When DY == 0, make sure we get to
2574 the first character in the line after the newline.
2576 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2578 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2579 (ccl_driver): Do not generate an out-of-range pointer.
2580 (Fccl_execute_on_string): Remove unnecessary check for
2581 integer overflow, noted by Stefan Monnier in
2582 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2583 Remove a FIXME that didn't need fixing.
2584 Simplify the newly-introduced buffer reallocation code.
2586 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2588 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2590 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2592 Integer and memory overflow issues (Bug#9196).
2594 * doc.c (get_doc_string): Rework so that
2595 get_doc_string_buffer_size is the actual buffer size, rather than
2596 being 1 less than the actual buffer size; this makes xpalloc more
2599 * image.c (x_allocate_bitmap_record, cache_image):
2600 * xselect.c (Fx_register_dnd_atom):
2601 Simplify previous changes by using xpalloc.
2603 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2604 since either will do and ptrdiff_t is convenient with xpalloc.
2606 * charset.c (charset_table_size)
2607 (struct charset_sort_data.priority): Now ptrdiff_t.
2608 (charset_compare): Don't overflow if priorities differ greatly.
2609 (Fsort_charsets): Don't assume list length fits in int.
2610 Check for size-calculation overflow when allocating sort data.
2611 (syms_of_charset): Allocate an initial charset table that is
2612 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2614 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2616 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2617 The actual value is always <= INT_MAX, and leaving it unsigned made
2618 overflow checking harder.
2620 * dispextern.h (struct glyph_matrix.rows_allocated)
2621 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2622 with xpalloc. The values are still always <= INT_MAX.
2624 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2626 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2627 (SAFE_NALLOCA): New macro.
2629 * region-cache.c (struct boundary.pos, find_cache_boundary)
2630 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2631 (set_cache_region, invalidate_region_cache)
2632 (revalidate_region_cache, know_region_cache, region_cache_forward)
2633 (region_cache_backward, pp_cache):
2634 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2635 so that ptrdiff_t * can be passed to xpalloc.
2636 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2637 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2638 (pp_cache): Don't assume cache_len fits in int.
2639 * region-cache.h: Adjust extern decls to match.
2641 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2642 EMACS_INT, since either will do, for xpalloc.
2644 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2645 (xnmalloc, xnrealloc, xpalloc): New functions.
2647 * bidi.c (bidi_shelve_header_size): New constant.
2648 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2649 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2651 * bidi.c (bidi_cache_shrink):
2652 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2654 Don't update size of array until after memory allocation succeeds,
2655 because xmalloc/xrealloc may not return.
2656 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2657 now that we have proper integer overflow checking.
2658 (record_overlay_string, overlay_strings): Catch overflows when
2659 calculating size of overlay_str_buf.
2661 * callproc.c (Fcall_process): Check for size overflow when
2662 calculating size of args2.
2663 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2664 Normally we prefer signed values, but sticking with ptrdiff_t would
2665 require adding more-complicated checks.
2667 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2668 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2669 Redo buffer-overflow calculations to avoid integer overflow.
2670 Add a FIXME comment where memory seems to be over-allocated.
2672 * character.c (Fstring): Check for size-calculation overflow.
2674 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2675 unnecessary integer overflow. Check for size overflow.
2676 (encode_coding_object): Don't update size until xmalloc succeeds.
2678 * composite.c (get_composition_id): Check for overflow in glyph
2679 length calculations.
2681 Integer and memory overflow fixes for display code.
2682 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2683 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2684 (scrolling_window): Check for overflow in size calculations.
2685 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2686 Don't assume glyph table len fits in int.
2687 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2688 (row_table_size): Now ptrdiff_t, not int.
2689 (scrolling_window): Avoid overflow in size calculations.
2690 Don't update size until allocation succeeds.
2691 * fns.c (concat): Check for overflow in size calculations.
2692 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2693 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2694 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2696 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2697 (get_doc_string): Check for size calculation overflow.
2698 Don't update size until allocation succeeds.
2699 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2700 EMACS_INT, where ptrdiff_t will do.
2701 (Fsubstitute_command_keys): Check for string overflow.
2703 * editfns.c (set_time_zone_rule): Don't assume environment length
2705 (message_length): Now ptrdiff_t, not int.
2706 (Fmessage_box): Don't update size until allocation succeeds.
2707 Don't assume message length fits in int.
2708 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2710 * emacs.c (main): Do not reallocate argv, since there is a null at
2711 the end that can be overwritten, and this way there's no need to
2712 worry about size-calculation overflow.
2713 (sort_args): Check for size-calculation overflow.
2715 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2717 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2719 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2720 (x_set_scroll_bar_width, x_figure_window_size):
2721 Check for integer overflow.
2722 (x_set_alpha): Do not assume XINT fits in int.
2724 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2725 This is for the members text_lines, text_cols, total_lines, total_cols,
2726 where the system imposes an 'int' limit.
2728 * fringe.c (Fdefine_fringe_bitmap):
2729 Don't update size until alloc works.
2731 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2732 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2734 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2735 Check for size-calculation overflow.
2736 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2737 do, as we prefer signed integers.
2738 (id_to_widget.max_size, id_to_widget.used)
2739 (xg_store_widget_in_map, xg_remove_widget_from_map)
2740 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2741 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2742 Use and return ptrdiff_t, not int.
2743 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2744 * gtkutil.h: Change prototypes to match the above.
2746 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2747 are duplicate now that they've been promoted to lisp.h.
2748 (x_allocate_bitmap_record, x_alloc_image_color)
2749 (make_image_cache, cache_image, xpm_load):
2750 Don't update size until alloc is done.
2751 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2753 Check for size calculation overflow.
2754 (ct_colors_allocated_max): New constant.
2755 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2758 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2759 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2760 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2761 Use ptrdiff_t, not int, to count maps.
2762 (read_char_minibuf_menu_prompt): Check for overflow in size
2763 calculations. Don't update size until allocation succeeds.
2764 Redo calculations to avoid overflow.
2765 * keyboard.h: Change prototypes to match the above.
2767 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2769 (current_minor_maps): Check for size calculation overflow.
2770 * keymap.h: Change prototypes to match the above.
2772 * lread.c (read1, init_obarray): Don't update size until alloc done.
2774 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2775 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2777 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2778 Now ptrdiff_t, not int.
2779 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2780 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2782 * process.c (Fnetwork_interface_list): Check for overflow
2783 in size calculation.
2785 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2787 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2788 overflow. Don't bother calling xmalloc when xrealloc will do.
2790 * search.c (Freplace_match): Check for size calculation overflow.
2791 (Fset_match_data): Don't assume list lengths fit in 'int'.
2793 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2794 for command line length. Do not attempt to address one before the
2795 beginning of an array, as that's not portable.
2797 * term.c (max_frame_lines): Remove; unused.
2798 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2800 (encode_terminal_code, calculate_costs): Check for size
2801 calculation overflow.
2802 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2803 table lengths and related sizes. Don't update size until alloc
2804 done. Redo calculations to avoid overflow.
2805 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2807 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2808 subtracting pointers.
2809 (gobble_line): Check for overflow more carefully. Don't update size
2812 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2813 Don't update size until alloc done.
2814 Redo size calculations to avoid overflow.
2815 Check for size calculation overflow.
2816 (main) [DEBUG]: Fix typo in invoking tparam1.
2818 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2819 Use ptrdiff_t, not int, for sizes.
2820 (store_mode_line_noprop_char): Don't update size until alloc done.
2822 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2823 Use ptrdiff_t, not int, for sizes.
2824 (Finternal_make_lisp_face, cache_face):
2825 Check for size calculation overflow.
2826 (cache_face): Treat size calculation overflows as if they were
2827 memory exhaustion (the usual treatment), rather than aborting.
2829 * xfns.c (x_encode_text, x_set_name_internal)
2830 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2831 sizes, since they can exceed INT_MAX in size. Check for size
2832 calculation overflow.
2834 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2835 (xg_select): Check for size calculation overflow.
2836 Don't update size until alloc done.
2838 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2839 as sprintf is limited to int lengths.
2841 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2842 (X_LONG_MIN): New macros.
2843 Use them to make the following changes clearer.
2844 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2845 This change doesn't affect the value now, but it may help remind
2846 future maintainers not to raise the value too much later.
2847 (SELECTION_QUANTUM): Remove, replacing with ...
2848 (selection_quantum): ... new function, which avoids overflow.
2850 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2851 assumption that selection length fits in 'int'.
2852 (x_reply_selection_request, x_handle_selection_request)
2853 (x_get_window_property, receive_incremental_selection)
2854 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2855 (lisp_data_to_selection_data, clean_local_selection_data):
2856 Use ptrdiff_t, not int, to record length of selection.
2857 (x_reply_selection_request, x_get_window_property)
2858 (receive_incremental_selection, x_property_data_to_lisp):
2859 Redo calculations to avoid overflow.
2860 (x_reply_selection_request): When sending hint, ceiling it at
2861 X_LONG_MAX rather than relying on wraparound overflow to send
2863 (x_get_window_property, receive_incremental_selection)
2864 (lisp_data_to_selection_data, x_property_data_to_lisp):
2865 Check for size-calculation overflow.
2866 (x_get_window_property, receive_incremental_selection)
2867 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2868 Don't store size until memory allocation succeeds.
2869 (x_get_window_property): Plug memory leak on memory exhaustion.
2870 Don't double-block input; malloc is safe here. Don't assume 2**34
2871 - 4 fits in unsigned long. Add an xassert to check
2872 XGetWindowProperty overflow. Be more careful about overflow
2873 calculations, and distinguish size from memory overflow better.
2874 (receive_incremental_selection): When tracing, don't assume
2875 unsigned int is less than INT_MAX.
2876 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2877 harmful) conversions of unsigned short to int.
2878 (lisp_data_to_selection_data): Don't assume that integers
2879 in the range -65535 through -1 fit in an X unsigned short.
2880 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2881 result parameters unless successful. Rely on cons_to_unsigned
2882 to report problems with elements; the old code wasn't right anyway.
2883 (x_check_property_data): Check for int overflow; we cannot use
2884 a wider type due to X limits.
2885 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2887 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2889 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2890 (x_term_init): Check for size calculation overflow.
2891 (x_color_cells): Don't store size until memory allocation succeeds.
2892 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2893 Don't assume alloca size is less than MAX_ALLOCA.
2894 (x_term_init): Don't assume length fits in int (sprintf is limited
2897 Use ptrdiff_t for composition IDs.
2898 * character.c (lisp_string_width):
2899 * composite.c (composition_table_size, n_compositions)
2900 (get_composition_id, composition_gstring_from_id):
2901 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2902 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2903 * window.c (Frecenter):
2904 Use ptrdiff_t, not int, for composition IDs.
2905 * composite.c (get_composition_id): Check for integer overflow.
2906 * composite.h: Adjust prototypes to match the above changes.
2908 Use ptrdiff_t for hash table indexes.
2909 * category.c (hash_get_category_set):
2910 * ccl.c (ccl_driver):
2911 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2912 * coding.c (coding_system_charset_list, detect_coding_system):
2913 * coding.h (struct coding_system.id):
2914 * composite.c (get_composition_id, gstring_lookup_cache):
2915 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2916 * image.c (xpm_get_color_table_h):
2917 * lisp.h (hash_lookup, hash_put):
2918 * minibuf.c (Ftest_completion):
2919 Use ptrdiff_t for hash table indexes, not int (which is too
2920 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2921 32-bit --with-wide-int hosts).
2923 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2924 Add a FIXME comment about memory leaks.
2925 (syms_of_charset): Don't assume xmalloc returns.
2927 Don't assume that stated character widths fit in int.
2928 * character.c (Fchar_width, c_string_width, lisp_string_width):
2929 * character.h (CHAR_WIDTH):
2930 * indent.c (MULTIBYTE_BYTES_WIDTH):
2931 Use sanitize_char_width to avoid undefined and/or bad behavior
2932 with outlandish widths.
2933 * character.h (sanitize_tab_width): Rename from sanitize_width,
2934 now that we have two such functions. All uses changed.
2935 (sanitize_char_width): New inline function.
2937 Don't assume that tab-width fits in int.
2938 * character.h (sanitize_width): New inline function.
2939 (SANE_TAB_WIDTH): New macro.
2940 (ASCII_CHAR_WIDTH): Use it.
2941 * indent.c (sane_tab_width): Remove. All uses replaced by
2942 SANE_TAB_WIDTH (current_buffer).
2943 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2945 * fileio.c: Integer overflow issues with file modes.
2946 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2948 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2949 Remove unreachable code.
2950 (read_hex, load_charset_map_from_file): Check for integer overflow.
2952 * xterm.c: Don't go over XClientMessageEvent limit.
2953 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2954 (x_send_scroll_bar_event): Likewise. Check that the size does not
2955 exceed limits imposed by XClientMessageEvent, as well as the usual
2956 ptrdiff_t and size_t limits.
2958 * keyboard.c: Overflow, signedness and related fixes.
2959 (make_lispy_movement): Use same integer type in forward decl
2960 that is used in the definition.
2961 (read_key_sequence, keyremap_step):
2962 Change bufsize argument back to int, undoing my 2011-03-30 change.
2963 We prefer signed types, and int is wide enough here.
2964 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2965 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2966 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2967 length, not size_t. Use ptrdiff_t for index, not int.
2968 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2969 possibility of integer overflow.
2971 Overflow, signedness and related fixes for images.
2973 * dispextern.h (struct it.stack[0].u.image.image_id)
2974 (struct_it.image_id, struct image.id, struct image_cache.size)
2975 (struct image_cache.used, struct image_cache.ref_count):
2976 * gtkutil.c (update_frame_tool_bar):
2977 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2978 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2979 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2980 * nsmenu.m (update_frame_tool_bar):
2981 * xdisp.c (calc_pixel_width_or_height):
2982 * xfns.c (image_cache_refcount):
2983 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2984 on typical 64-bit hosts.
2986 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2987 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2988 Omit unnecessary casts to int.
2989 (parse_image_spec): Check that integers fall into 'int' range
2990 when the callers expect that.
2991 (image_ascent): Redo ascent calculation to avoid int overflow.
2992 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2993 (lookup_image): Remove unnecessary tests.
2994 (xbm_image_p): Locals are now of int, not EMACS_INT,
2995 since parse_image_check makes sure they fit into int.
2996 (png_load, gif_load, svg_load_image):
2997 Prefer int to unsigned where either will do.
2998 (tiff_handler): New function, combining the cores of the
2999 old tiff_error_handler and tiff_warning_handler.
3000 This function is rewritten to use vsnprintf and thereby avoid
3001 stack buffer overflows. It uses only the features of vsnprintf
3002 that are common to both POSIX and native Microsoft.
3003 (tiff_error_handler, tiff_warning_handler): Use it.
3004 (tiff_load, gif_load, imagemagick_load_image):
3005 Don't assume :index value fits in 'int'.
3006 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3007 (imagemagick_load_image): Check that crop parameters fit into
3008 the integer types that MagickCropImage accepts. Don't assume
3009 Vimagemagick_render_type has a nonnegative value. Don't assume
3010 size_t fits in 'long'.
3011 (gs_load): Use printmax_t to print the widest integers possible.
3012 Check for integer overflow when computing image height and width.
3014 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3016 * xdisp.c (redisplay_window): Don't force window start if point
3017 will be invisible in the resulting window. (Bug#9324)
3019 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3021 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3022 the display spec is of the form `(space ...)'.
3023 (handle_display_spec): Return the value returned by
3024 handle_single_display_spec, not just 1 or zero.
3025 (handle_single_display_spec): If the display spec is of the form
3026 `(space ...)', and specifies display in the text area, return 2
3028 (try_cursor_movement): Check for the need to scroll more
3029 accurately, and prefer exact match for point under bidi.
3030 Don't advance `row' beyond the last row of the window.
3032 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3033 into disp_prop; all users changed.
3035 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3036 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3037 for the text covered by the display property.
3039 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3041 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3042 Change return value to nil.
3043 (Frecord_buffer): Delete unused function.
3045 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3047 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3048 buffers, return left-to-right.
3049 (set_cursor_from_row): Consider candidate row a win if its glyph
3050 represents a newline and point is on that newline. Fixes cursor
3051 positioning on the newline at EOL of R2L text within L2R
3052 paragraph, and vice versa.
3053 (try_cursor_movement): Check continued rows, in addition to
3054 continuation rows. Fixes unwarranted scroll when point enters a
3055 continued line of R2L text within an L2R paragraph, or vice versa.
3056 (cursor_row_p): Consider the case of point being equal to
3057 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3058 from the end of a short line to the beginning of a continued line
3059 of R2L text within L2R paragraph.
3060 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3061 composed characters.
3063 * bidi.c (bidi_check_type): Use xassert.
3064 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3067 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3069 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3072 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3074 * nsfont.m (ns_otf_to_script): Fix typo.
3076 2011-08-22 Kenichi Handa <handa@m17n.org>
3078 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3079 extra slot even if the purpose is char-code-property-table.
3081 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3083 * xdisp.c (redisplay_window): When computing centering_position,
3084 account for the height of the header line. (Bug#8874)
3086 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3087 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3088 candidate is selected by the mouse, and that candidate has a
3089 composed character under the mouse.
3091 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3092 coordinates reported by pos-visible-in-window-p for a composed
3093 character in column zero.
3095 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3097 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3099 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3101 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3102 consider it a hit if to_charpos is anywhere in the range of the
3103 composed buffer positions.
3105 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3107 * image.c (gif_load): Don't assume that each subimage has the same
3108 dimensions as the base image. Handle disposal method that is
3109 "undefined" by the gif spec (Bug#9335).
3111 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3113 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3114 (Fcondition_case): Document `debug' symbol in error handler.
3116 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3118 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3119 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3120 from an Org mode buffer to a Speedbar frame.
3122 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3123 a composition, take its buffer position from IT->cmp_it.charpos.
3124 Fixes cursor positioning at the beginning of a line that begins
3125 with a composed character.
3127 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3129 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3130 character bidirectional type, use STRONG_L instead. Fixes crashes
3131 in a buffer produced by `describe-categories'.
3133 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3134 members before the level stack, so they would be saved and
3135 restored when copying iterator state. Fixes incorrect reordering
3136 around TABs covered by display properties.
3138 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3140 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3142 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3144 * eval.c (internal_condition_case, internal_condition_case_1)
3145 (internal_condition_case_2, internal_condition_case_n):
3146 Remove unnecessary aborts (Bug#9081).
3148 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3150 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3151 has no `load' handler, try opening the file locally. (Bug#9311)
3153 2011-08-16 Ken Brown <kbrown@cornell.edu>
3155 * gmalloc.c: Expand comment.
3157 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3159 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3160 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3162 2011-08-16 Ken Brown <kbrown@cornell.edu>
3164 Fix memory allocation problems in Cygwin build (Bug#9273).
3166 * unexcw.c ( __malloc_initialized): Declare external variable.
3167 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3169 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3171 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3173 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3175 [CYGWIN] (special_realloc): New function.
3176 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3177 requests to realloc storage in the static heap.
3179 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3181 * bidi.c (bidi_initialize): Remove unused local.
3183 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3186 * biditype.h: Remove file.
3187 * makefile.w32-in ($(BLD)/bidi.$(O)):
3188 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3190 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3192 * chartab.c: Improve commentary for the uniprop_table API.
3194 * bidi.c (bidi_paragraph_init): Support zero value of
3195 bidi_ignore_explicit_marks_for_paragraph_level.
3196 (bidi_initialize): Use uniprop_table instead of including
3197 biditype.h and bidimirror.h.
3199 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3200 coordinates of the iterator when restoring from ppos_it.
3203 2011-08-14 Kenichi Handa <handa@m17n.org>
3205 * process.c (create_process): Call setup_process_coding_systems
3206 after the pid of the process is set to -1 (Bug#8162).
3208 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3210 * xdisp.c (move_it_in_display_line_to): Don't invoke
3211 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3212 ppos_it. Fixes vertical cursor motion when line beginning is
3213 covered by an image. (Bug#9296)
3215 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3217 * nsterm.h (ns_run_ascript): Declare.
3218 (NSAPP_DATA2_RUNASSCRIPT): Define.
3220 * nsfns.m (as_script, as_result, as_status): New static variables.
3221 (ns_run_ascript): New function.
3222 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3223 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3224 the event loop. Get status from as_status (Bug#7276).
3226 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3227 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3228 the event loop (Bug#7276).
3230 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3232 * gnutls.c (QCgnutls_bootprop_priority)
3233 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3234 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3235 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3236 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3237 (QCgnutls_bootprop_verify_hostname_error)
3238 (QCgnutls_bootprop_callbacks_verify): Rename from
3239 Qgnutls_bootprop_..., all uses changed.
3241 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3244 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3246 * xfaces.c (Qframe_set_background_mode): Now static.
3247 * dispextern.h (Qframe_set_background_mode): Remove decl.
3249 * process.c (Fnetwork_interface_info): Declare local only if needed.
3251 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3253 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3254 (Fnetwork_interface_list): Allocate in increments of bytes instead
3255 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3256 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3258 (struct ifflag_def): notrailers is smart on OSX.
3259 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3260 Get hardware address with getifaddrs if available.
3262 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3264 * xdisp.c (iterate_out_of_display_property): xassert that
3265 IT->position is set to within IT->object's boundaries. Break from
3266 the loop as soon as EOB is reached; avoids infloops in redisplay
3267 when IT->position is set up wrongly due to some bug.
3268 Set IT->current to match the bidi iterator unconditionally.
3269 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3270 entry. Force push_it to save on the stack the current
3271 buffer/string position, to be restored by pop_it. Fix flags in
3272 the iterator structure wrt the object coming from a display
3273 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3274 properties. (Bug#9284)
3276 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3278 * fontset.c (fontset_get_font_group): Add proper type checks.
3281 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3283 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3284 and LC_VERSION_MIN_MACOSX.
3285 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3286 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3288 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3290 * xdisp.c (forward_to_next_line_start): Allow to use the
3291 no-display-properties-and-no-overlays under bidi display.
3292 Set disp_pos in the bidi iterator to avoid searches for display
3293 properties and overlays.
3295 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3297 * editfns.c (Fset_time_zone_rule): Document relationship with the
3300 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3301 the font entity extracted from the cache (Bug#8109).
3303 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3305 * composite.c (autocmp_chars): Don't reset point. That is done by
3306 restore_point_unwind (Bug#5984).
3308 2011-08-07 Juri Linkov <juri@jurta.org>
3310 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3311 to show the arg `TIME' instead of `TIMEVAL'.
3313 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3315 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3316 display property strides EOL and includes a newline, as in
3317 longlines-mode. (Bug#9254)
3318 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3319 word-wrap under bidirectional display. (Bug#9224)
3321 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3322 is non-zero, even if the data buffer is NULL. Fixes a crash in
3323 vertical-motion with longlines-mode. (Bug#9254)
3325 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3327 * bidi.c <bidi_cache_total_alloc>: Now static.
3328 (bidi_initialize): Initialize bidi_cache_total_alloc.
3330 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3333 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3334 amount allocated this far in `bidi_cache_total_alloc'.
3335 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3336 non-zero, only free the data buffer without restoring the cache
3337 contents. All callers changed.
3339 * dispextern.h (bidi_unshelve_cache): Update prototype.
3341 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3342 (move_it_in_display_line, move_it_to)
3343 (move_it_vertically_backward, move_it_by_lines): Replace the call
3344 to xfree to an equivalent call to bidi_unshelve_cache.
3345 (move_it_in_display_line_to): Fix logic of returning
3346 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3348 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3350 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3351 came from a string character with a `cursor' property. (Bug#9229)
3353 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3355 * Makefile.in (LIB_PTHREAD): New variable.
3356 (LIBES): Add LIB_PTHREAD (Bug#9216).
3358 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3359 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3361 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3363 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3365 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3367 * xterm.c (x_find_topmost_parent): New function.
3368 (x_set_frame_alpha): Find topmost parent window with
3369 x_find_topmost_parent and set the property there also (bug#9181).
3370 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3372 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3374 * callproc.c (Fcall_process): Avoid vfork clobbering
3375 the local vars buffer, coding_systems, current_dir.
3377 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3379 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3381 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3383 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3384 so that it is not optimized away.
3386 * xdisp.c (compute_display_string_pos): Remove unused local.
3388 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3390 Fix slow cursor motion and scrolling in large buffers with
3391 selective display, like Org Mode buffers. (Bug#9218)
3393 * dispextern.h (struct bidi_it): New member disp_prop_p.
3395 * xdisp.c: Remove one-slot cache of display string positions.
3396 (compute_display_string_pos): Accept an additional argument
3397 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3398 for a display string or property. If found, set DISP_PROP_P
3401 * bidi.c (bidi_fetch_char): Accept an additional argument
3402 DISP_PROP_P, and pass it to compute_display_string_pos.
3403 Only handle text covered by a display string if DISP_PROP_P is returned
3404 non-zero. All callers of bidi_fetch_char changed.
3406 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3408 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3410 2010-12-03 Don March <don@ohspite.net>
3412 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3413 last character M-[char] is translated to ESC [char] (bug#7541).
3415 2011-08-02 Kenichi Handa <handa@m17n.org>
3417 * lisp.h (uniprop_table): Extern it.
3419 * chartab.c (uniprop_table): Make it non-static.
3421 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3423 * xdisp.c (forward_to_next_line_start): Accept additional argument
3424 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3426 (reseat_at_next_visible_line_start): Use the bidi iterator state
3427 returned by forward_to_next_line_start to restore the state of
3428 it->bidi_it after backing up to previous newline. (Bug#9212)
3430 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3432 * regex.c (re_comp): Protoize.
3433 (re_exec): Fix return type.
3434 (regexec): Fix type of `ret'. (Bug#9203)
3436 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3438 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3439 This is needed if max-image-size is a floating-point number.
3441 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3443 * print.c (print_object): Print empty symbol as ##.
3445 * lread.c (read1): Read ## as empty symbol.
3447 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3449 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3450 setting frame foreground color (Bug#9175).
3451 (x_set_background_color): Likewise.
3453 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3454 contents (Bug#9176).
3455 (EmacsTooltip -init): Remove bezels and add shadows to
3458 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3459 or scroll bar (Bug#8470).
3461 * nsfont.m (nsfont_open): Remove assignment to voffset and
3462 unnecessary vars hshink, expand, hd, full_height, min_height.
3463 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3465 * nsterm.h (nsfont_info): Remove voffset field.
3467 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3469 Implement strike-through and overline on NextStep (Bug#8863).
3471 * nsfont.m (nsfont_open): Use underline position provided by font,
3472 instead of hard-coded value of 2.
3473 (nsfont_draw): Call ns_draw_text_decoration instead.
3475 * nsterm.h: Add declaration for ns_draw_text_decoration.
3477 * nsterm.m (ns_draw_text_decoration): New function for drawing
3478 underline, overline, and strike-through.
3479 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3480 ns_draw_text_decoration. Change treatment of cursor drawing to
3481 accommodate underlining, etc.
3483 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3485 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3488 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3490 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3491 Without this fix, if a signal arrives just after memory fills up,
3492 'malloc' might be invoked reentrantly.
3494 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3495 In other words, assume that every image size is allowed, on non-X
3496 hosts. This assumption is probably wrong, but it lets Emacs compile.
3498 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3500 * regex.c (re_iswctype): Convert return values to boolean.
3502 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3504 * xdisp.c (compute_display_string_pos): Don't use cached display
3505 string position if the buffer had its restriction changed.
3508 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3510 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3512 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3514 Integer signedness and overflow and related fixes. (Bug#9079)
3516 * bidi.c: Integer size and overflow fixes.
3517 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3518 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3519 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3520 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3521 (bidi_find_other_level_edge):
3522 Use ptrdiff_t instead of EMACS_INT where either will do.
3523 This works better on 32-bit hosts configured --with-wide-int.
3524 (bidi_cache_ensure_space): Check for size-calculation overflow.
3525 Use % rather than repeated addition, for better worst-case speed.
3526 Don't set bidi_cache_size until after xrealloc returns, because it
3528 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3529 (bidi_cache_ensure_space): Also check that the bidi cache size
3530 does not exceed that of the largest Lisp string or buffer. See Eli
3531 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3533 * alloc.c (__malloc_size_t): Remove.
3534 All uses replaced by size_t. See Andreas Schwab's note
3535 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3537 * image.c: Improve checking for integer overflow.
3538 (check_image_size): Assume that f is nonnull, since
3539 it is always nonnull in practice. This is one less thing to
3540 worry about when checking for integer overflow later.
3541 (x_check_image_size): New function, which checks for integer
3542 overflow issues inside X.
3543 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3544 This removes the need for a memory_full check.
3545 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3546 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3547 (xbm_read_bitmap_data): Change locals back to 'int', since
3548 their values must fit in 'int'.
3549 (xpm_load_image, png_load, tiff_load):
3550 Invoke x_create_x_image_and_pixmap earlier,
3551 to avoid much needless work if the image is too large.
3552 (tiff_load): Treat overly large images as if
3553 x_create_x_image_and_pixmap failed, not as malloc failures.
3554 (gs_load): Use x_check_image_size.
3556 * gtkutil.c: Omit integer casts.
3557 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3558 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3560 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3562 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3563 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3564 would wrongly return t on a 64-bit host.
3566 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3567 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3568 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3569 and therefore cause GCC to emit a bogus diagnostic in some cases.
3571 * image.c: Integer signedness and overflow and related fixes.
3572 This is not an exhaustive set of fixes, but it's time to
3573 record what I've got.
3574 (lookup_pixel_color, check_image_size): Remove redundant decls.
3575 (check_image_size): Don't assume that arbitrary EMACS_INT values
3576 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3577 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3578 (tiff_load, imagemagick_load_image):
3579 Check for overflow in size calculations.
3580 (x_create_x_image_and_pixmap): Remove unnecessary test for
3581 xmalloc returning NULL; that can't happen.
3582 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3583 (xpm_color_bucket): Use better integer hashing function.
3584 (xpm_cache_color): Don't possibly over-allocate memory.
3585 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3586 (gif_memory_source):
3587 Use ptrdiff_t, not int or size_t, to record sizes.
3588 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3589 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3590 either works, as we prefer signed integers.
3591 (tiff_read_from_memory, tiff_write_from_memory):
3592 Return tsize_t, not size_t, since that's what the TIFF API wants.
3593 (tiff_read_from_memory): Don't fail simply because the read would
3594 go past EOF; instead, return a short read.
3595 (tiff_load): Omit no-longer-needed casts.
3596 (Fimagemagick_types): Don't assume size fits into 'int'.
3598 Improve hashing quality when configured --with-wide-int.
3599 * fns.c (hash_string): New function, taken from sxhash_string.
3600 Do not discard information about ASCII character case; this
3601 discarding is no longer needed.
3602 (sxhash-string): Use it. Change sig to match it. Caller changed.
3603 * lisp.h: Declare it.
3604 * lread.c (hash_string): Remove, since we now use fns.c's version.
3605 The fns.c version returns a wider integer if --with-wide-int is
3606 specified, so this should help the quality of the hashing a bit.
3608 * emacs.c: Integer overflow minor fix.
3609 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3610 Define only if GNU_LINUX.
3611 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3613 * dispnew.c: Integer signedness and overflow fixes.
3614 Remove unnecessary forward decls, that were a maintenance hassle.
3615 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3617 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3618 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3619 (prepare_desired_row, line_draw_cost):
3620 Use int, not unsigned, where either works.
3621 (save_current_matrix, restore_current_matrix):
3622 Use ptrdiff_t, not size_t, where either works.
3623 (init_display): Check for overflow more accurately, and without
3624 relying on undefined behavior.
3626 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3627 Remove, replacing with the new symbols in lisp.h. All uses changed.
3628 * fileio.c (make_temp_name):
3629 * filelock.c (lock_file_1, lock_file):
3630 * xdisp.c (message_dolog):
3631 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3632 Use pMd etc. instead.
3633 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3634 replacing the pWIDE etc. symbols removed from editfns.c.
3636 * keyboard.h (num_input_events): Now uintmax_t.
3637 This is (very slightly) less likely to mess up due to wraparound.
3640 * buffer.c: Integer signedness fixes.
3641 (alloc_buffer_text, enlarge_buffer_text):
3642 Use ptrdiff_t rather than size_t when either will do, as we prefer
3645 * alloc.c: Integer signedness and overflow fixes.
3646 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3647 (__malloc_size_t): Default to size_t, not to int.
3648 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3649 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3650 Prefer ptrdiff_t to size_t when either would do, as we prefer
3652 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3653 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3654 Now const. Initialize with values that are in range even if char
3656 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3657 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3658 These functions do the right thing with sizes > 2**32.
3659 (check_depth): Now ptrdiff_t, not int.
3660 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3661 Adjust to new way of storing sizes. Check for size overflow bugs
3663 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3664 slightly wrong anyway, as it missed one instance of
3665 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3666 (refill_memory_reserve): Omit needless cast to size_t.
3667 (mark_object_loop_halt): Mark as externally visible.
3669 * xselect.c: Integer signedness and overflow fixes.
3670 (Fx_register_dnd_atom, x_handle_dnd_message):
3671 Use ptrdiff_t, not size_t, since we prefer signed.
3672 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3673 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3674 x_dnd_atoms_size and x_dnd_atoms_length.
3676 * doprnt.c: Prefer signed to unsigned when either works.
3678 * doprnt.c (doprnt):
3680 * xdisp.c (vmessage):
3681 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3682 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3683 prefer signed arithmetic to avoid comparison confusion.
3684 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3685 but is a bit tricky.
3687 Assume freestanding C89 headers, string.h, stdlib.h.
3688 * data.c, doprnt.c, floatfns.c, print.c:
3689 Include float.h unconditionally.
3690 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3691 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3692 * regex.c: Likewise for stddef.h, string.h.
3693 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3694 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3695 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3696 (STDC_HEADERS): Remove obsolete defines.
3697 * sysdep.c: Include limits.h unconditionally.
3699 Assume support for memcmp, memcpy, memmove, memset.
3700 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3701 * regex.c (memcmp, memcpy):
3702 Remove; we assume C89 now.
3704 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3705 (__malloc_safe_bcopy): Remove; no longer needed.
3707 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3708 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3709 well either way, and we prefer signed to unsigned.
3711 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3713 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3714 closes the connection while we're reading (bug#9182).
3716 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3718 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3719 are specified (Bug#9168).
3721 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3723 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3724 Found by GCC static checking and --with-wide-int on a 32-bit host.
3726 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3728 * xdisp.c (compute_display_string_pos): Fix logic of caching
3729 previous display string position. Initialize cached_prev_pos to
3730 -1. Fixes slow-down at the beginning of a buffer.
3732 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3734 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3735 for attrs[LFACE_FONTSET_INDEX].
3737 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3739 * xml.c (parse_region): Remove unused local
3740 that was recently introduced.
3742 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3744 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3745 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3747 * xdisp.c (move_it_in_display_line_to): Record the best matching
3748 position for TO_CHARPOS while scanning the line, and restore it on
3749 exit if none of the characters scanned was an exact match.
3750 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3751 when exact match is impossible due to invisible text, and the
3752 lines are truncated.
3754 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3756 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3759 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3761 Fix a significant slow-down of cursor motion with C-n, C-p,
3762 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3763 auto-repeat under bidi redisplay in fontified buffers.
3764 * xdisp.c (compute_stop_pos_backwards): New function.
3765 (next_element_from_buffer): Call compute_stop_pos_backwards to
3766 find a suitable prev_stop when we find ourselves before
3768 (reseat): Don't look for prev_stop, as that could mean a very long
3770 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3771 <cached_disp_overlay_modiff>: Cache for last found display string
3773 (compute_display_string_pos): Return the cached position if asked
3774 about the same buffer in the same area of character positions, and
3775 the buffer wasn't changed since the time the display string
3776 position was cached.
3778 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3780 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3781 is an integer, which is important for empty lines. (Bug#9149)
3783 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3785 * frame.c (Fmodify_frame_parameters): In tty case, update the
3786 default face if necessary (Bug#4238).
3788 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3790 * editfns.c (Fstring_to_char): No need to explain what a character
3791 is in the docstring (Bug#6576).
3793 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3795 * xml.c (parse_region): Make sure we always return a tree.
3797 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3799 * xml.c (parse_region): If a document contains only comments,
3802 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3804 * xml.c (make_dom): Return comments, too.
3806 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3809 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3810 and the surrounding thread.
3811 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3812 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3813 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3815 * s/openbsd.h (BROKEN_SIGIO): Define.
3816 * unexelf.c (unexec) [__OpenBSD__]:
3817 Don't update the .mdebug section of the Alpha COFF symbol table.
3819 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3821 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3824 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3826 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3827 This fixes some race conditions on the permissions of any newly
3830 * alloc.c (valid_pointer_p): Use pipe, not open.
3831 This fixes some permissions issues when debugging.
3833 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3834 If fchown fails to set both uid and gid, try to set just gid,
3835 as that is sometimes allowed. Adjust the file's mode to eliminate
3836 setuid or setgid bits that are inappropriate if fchown fails.
3838 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3840 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3841 to compare Lisp_Objects.
3842 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3843 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3844 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3846 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3848 * lread.c (read_integer): Unread even EOF character.
3849 (read1): Likewise. Properly record start position of symbol.
3851 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3852 symbol character follows.
3854 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3856 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3857 This works around a problem with the previous change to Fcopy_file.
3858 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3859 and without this change, GCC might complain about discarding
3860 fchown's return value.
3862 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3864 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3866 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3868 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3870 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3872 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3873 it's used from the C level.
3875 * process.c: Use the same condition for POLL_FOR_INPUT in both
3876 keyboard.c and process.c (bug#1858).
3878 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3880 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3881 (Fgnutls_boot): Use it.
3883 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3885 * doc.c (Fsubstitute_command_keys): Revert last change.
3887 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3889 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3890 quotes the next character, and doesn't affect other longer
3891 sequences (bug#8935).
3893 * lread.c (syms_of_lread): Clarify that is isn't only
3894 `eval-buffer' and `eval-defun' that's affected by
3895 `lexical-binding' (bug#8460).
3897 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3899 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3900 bidi redisplay when a line includes both an image and is truncated.
3902 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3904 Fix minor problems found by static checking.
3905 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3906 (elsz): Now a signed constant, not a size_t var. We prefer signed
3907 types to unsigned, to avoid integer comparison confusion. Without
3908 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3909 "cannot optimize loop, the loop counter may overflow", a symptom
3911 * indent.c (Fvertical_motion): Mark locals as initialized.
3912 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3914 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3916 * search.c (Fre_search_backward): Mention `case-fold-search' in
3917 all the re_search_* functions (bug#8138).
3919 * keyboard.c (Fopen_dribble_file): Document when the file is
3922 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3924 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3927 Support bidi reordering of display and overlay strings.
3928 * xdisp.c (compute_display_string_pos)
3929 (compute_display_string_end): Accept additional argument STRING.
3930 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3931 (reseat_to_string): Initialize bidi_it->string.s and
3932 bidi_it->string.schars.
3933 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3934 NULL (avoids a crash in bidi_paragraph_init).
3935 Initialize itb.string.lstring.
3936 (init_iterator): Call bidi_init_it only of a valid
3937 buffer position was specified. Initialize paragraph_embedding to
3939 (reseat_to_string): Initialize the bidi iterator.
3940 (display_string): If we need to ignore text properties of
3941 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3942 original value of -1 will not work with bidi.)
3943 (compute_display_string_pos): First arg is now struct
3944 `text_pos *'; all callers changed. Support display properties on
3946 (compute_display_string_end): Support display properties on Lisp
3948 (init_iterator, reseat_1, reseat_to_string): Initialize the
3949 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3950 when iterating on a string not from display properties).
3951 (compute_display_string_pos, compute_display_string_end):
3952 Fix calculation of the object to scan. Fixes an error when using
3954 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3955 base_level_stop; instead, set base_level_stop to BEGV.
3956 Fixes crashes in vertical-motion.
3957 (next_element_from_buffer): Improve commentary for when
3958 the iterator is before prev_stop.
3959 (init_iterator): Initialize bidi_p from the default value of
3960 bidi-display-reordering, not from buffer-local value. Use the
3961 buffer-local value only if initializing for buffer iteration.
3962 (handle_invisible_prop): Support invisible properties on strings
3963 that are being bidi-reordered.
3964 (set_iterator_to_next): Support bidi reordering of C strings and
3966 (next_element_from_string): Support bidi reordering of Lisp
3968 (handle_stop_backwards): Support Lisp strings as well.
3969 (display_string): Support display of R2L glyph rows.
3970 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3971 (init_iterator): Don't initialize it->bidi_p for strings
3973 (reseat_to_string): Initialize it->bidi_p for strings here.
3974 (next_element_from_string, next_element_from_c_string)
3975 (next_element_from_buffer): Add xassert's for correspondence
3976 between IT's object being iterated and it->bidi_it.string
3978 (face_before_or_after_it_pos): Support bidi iteration.
3979 (next_element_from_c_string): Handle the case of the first string
3980 character that is not the first one in the visual order.
3981 (get_visually_first_element): New function, refactored from common
3982 parts of next_element_from_buffer, next_element_from_string, and
3983 next_element_from_c_string.
3984 (tool_bar_lines_needed, redisplay_tool_bar)
3985 (display_menu_bar): Force left-to-right direction. Add a FIXME
3986 comment for making that be controlled by a user option.
3987 (push_it, pop_it): Save and restore the state of the
3988 bidi iterator. Save and restore the bidi_p flag.
3989 (pop_it): Iterate out of display property for string iteration as
3991 (iterate_out_of_display_property): Support iteration over strings.
3992 (handle_single_display_spec): Set up it->bidi_it for iteration
3993 over a display string, and call bidi_init_it.
3994 (handle_single_display_spec, next_overlay_string)
3995 (get_overlay_strings_1, push_display_prop): Set up the bidi
3996 iterator for displaying display or overlay strings.
3997 (forward_to_next_line_start): Don't use the shortcut if
3999 (back_to_previous_visible_line_start): If handle_display_prop
4000 pushed the iterator stack, restore the internal state of the bidi
4001 iterator by calling bidi_pop_it same number of times.
4002 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4003 and we are bidi-iterating, don't decrement the iterator position;
4004 instead, set the first_elt flag in the bidi iterator, to produce
4006 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4007 (push_display_prop): xassert that we are iterating a buffer.
4008 (push_it, pop_it): Save and restore paragraph_embedding member.
4009 (handle_single_display_spec, next_overlay_string)
4010 (get_overlay_strings_1, reseat_1, reseat_to_string)
4011 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4012 correctly. Don't assume unibyte strings are not bidi-reordered.
4013 (compute_display_string_pos)
4014 (compute_display_string_end): Fix handling the case of C string.
4015 (push_it, pop_it): Save and restore from_disp_prop_p.
4016 (handle_single_display_spec, push_display_prop): Set the
4017 from_disp_prop_p flag.
4018 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4019 (pop_it): Call iterate_out_of_display_property only if we are
4020 popping after iteration over a string that came from a display
4021 property. Fix a typo in popping stretch info. Add an assertion
4022 for verifying that the iterator position is in sync with the bidi
4024 (handle_single_display_spec, get_overlay_strings_1)
4025 (push_display_prop): Fix initialization of paragraph direction for
4026 string when that of the parent object is not yet determined.
4027 (reseat_1): Call bidi_init_it to resync the bidi
4028 iterator with IT's position. (Bug#7616)
4029 (find_row_edges): If ROW->start.pos gives position
4030 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4031 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4032 Reset the from_disp_prop_p flag.
4033 (SAVE_IT, RESTORE_IT): New macros.
4034 (pos_visible_p, face_before_or_after_it_pos)
4035 (back_to_previous_visible_line_start)
4036 (move_it_in_display_line_to, move_it_in_display_line)
4037 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4038 (try_scrolling, redisplay_window, display_line): Use them when
4039 saving a temporary copy of the iterator and restoring it back.
4040 (back_to_previous_visible_line_start, reseat_1)
4041 (init_iterator): Empty the bidi cache "stack".
4042 (move_it_in_display_line_to): If iterator ended up at
4043 EOL, but we never saw any buffer positions smaller than
4044 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4045 motion in bidi-reordered lines.
4046 (move_it_in_display_line_to): Record prev_method and prev_pos
4047 immediately before the call to set_iterator_to_next. Fixes cursor
4048 motion in bidi-reordered lines with stretch glyphs and strings
4049 displayed in margins. (Bug#8133) (Bug#8867)
4050 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4052 (pos_visible_p): Support positions in bidi-reordered lines.
4053 Save and restore bidi cache.
4055 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4056 (bidi_paragraph_info): Delete unused struct.
4057 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4058 (bidi_cache_start): New variable.
4059 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4061 (bidi_cache_fetch_state, bidi_cache_search)
4062 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4063 (bidi_cache_find, bidi_peek_at_next_level)
4064 (bidi_level_of_next_char, bidi_find_other_level_edge)
4065 (bidi_move_to_visually_next): Compare cache index with
4066 bidi_cache_start rather than with zero.
4067 (bidi_fetch_char): Accept new argument STRING; all callers
4068 changed. Support iteration over a string. Support strings with
4069 display properties. Support unibyte strings. Fix the type of
4070 `len' according to what STRING_CHAR_AND_LENGTH expects.
4071 (bidi_paragraph_init, bidi_resolve_explicit_1)
4072 (bidi_resolve_explicit, bidi_resolve_weak)
4073 (bidi_level_of_next_char, bidi_move_to_visually_next):
4074 Support iteration over a string.
4075 (bidi_set_sor_type, bidi_resolve_explicit_1)
4076 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4077 can now be zero (for strings); special values 0 and -1 were
4078 changed to -1 and -2, respectively.
4079 (bidi_char_at_pos): New function.
4080 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4081 Call it instead of FETCH_MULTIBYTE_CHAR.
4082 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4083 initialized to valid values.
4084 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4086 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4087 the test for valid cached positions. Fix the logic for looking up
4088 the sentinel state in the cache. GCPRO the Lisp string we are
4090 (bidi_push_it, bidi_pop_it): New functions.
4091 (bidi_initialize): Initialize the bidi cache start stack pointer.
4092 (bidi_cache_ensure_space): New function, refactored from part of
4093 bidi_cache_iterator_state. Don't assume the required size is just
4094 one BIDI_CACHE_CHUNK away.
4095 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4096 (bidi_count_bytes, bidi_char_at_pos): New functions.
4097 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4098 always valid if bidi_cache_idx is valid.
4099 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4100 is valid if it's going to be used.
4101 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4102 (bidi_cache_fetch_state, bidi_cache_search)
4103 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4104 (bidi_cache_iterator_state, bidi_cache_find)
4105 (bidi_find_other_level_edge, bidi_cache_start_stack):
4106 All variables related to cache indices are now EMACS_INT.
4108 * dispextern.h (struct bidi_string_data): New structure.
4109 (struct bidi_it): New member `string'. Make flag members be 1-bit
4110 fields, and put them last in the struct.
4111 (compute_display_string_pos, compute_display_string_end):
4113 (bidi_push_it, bidi_pop_it): Add prototypes.
4114 (struct iterator_stack_entry): New members bidi_p,
4115 paragraph_embedding, and from_disp_prop_p.
4116 (struct it): Member bidi_p is now a bit field 1 bit wide.
4117 (bidi_shelve_cache, bidi_unshelve_cache):
4120 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4121 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4122 and vector-like objects.
4124 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4125 cache around display iteration.
4127 * window.c (Fwindow_end, window_scroll_pixel_based)
4128 (displayed_window_lines, Frecenter): Save and restore the bidi
4129 cache around display iteration.
4131 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4133 * editfns.c (Fdelete_region): Clarify the use of the named
4134 parameters (bug#6788).
4136 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4138 * indent.c (Fvertical_motion): Set and restore w->pointm when
4139 saving and restoring the window's buffer (Bug#9006).
4141 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4143 * editfns.c (Fstring_to_char): Clarify just what is returned
4144 (bug#6576). Text by Eli Zaretskii.
4146 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4148 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4150 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4152 * buffer.c (mmap_find): Fix a typo.
4154 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4156 Fix execution of x selection hooks.
4157 * xselect.c (Qx_lost_selection_functions)
4158 (Qx_sent_selection_functions): New vars.
4159 (syms_of_xselect): DEFSYM them.
4160 (x_handle_selection_request): Pass Qx_sent_selection_functions
4161 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4162 (x_handle_selection_clear,x_clear_frame_selections):
4163 Pass Qx_lost_selection_functions rather than
4164 Vx_lost_selection_functions to Frun_hook_with_args.
4166 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4168 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4169 The old code sometimes used this field without initializing it.
4171 * alloc.c (gc_sweep): Don't read past end of array.
4172 In theory, the old code could also have corrupted Emacs internals,
4173 though it'd be very unlikely.
4175 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4177 * character.c (Fcharacterp): Don't advertise optional ignored
4178 argument. (Bug#4026)
4180 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4182 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4185 * window.c (Fset_window_start): Doc fix (bug#4199).
4186 (Fset_window_hscroll): Ditto.
4188 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4190 Fix minor new problems caught by GCC 4.6.1.
4191 * term.c (init_tty): Remove unused local.
4192 * xsettings.c (store_monospaced_changed): Define this function only
4193 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4196 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4198 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4200 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4202 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4203 are the mini-buffer and the echo area (bug#3320).
4205 * term.c (init_tty): Remove support for supdup, c10 and perq
4206 terminals, which are no longer supported (bug#1482).
4208 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4210 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4212 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4214 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4215 for non-popups (Bug#3642).
4217 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4219 * alloc.c (reset_malloc_hooks): Protoize.
4220 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4221 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4222 * cm.c (losecursor): Likewise.
4223 * data.c (fmod): Likewise.
4224 * dispnew.c (swap_glyphs_in_rows): Likewise.
4225 * emacs.c (memory_warning_signal): Likewise.
4226 * floatfns.c (float_error): Likewise.
4227 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4228 (otf_open, font_otf_capability, generate_otf_features)
4229 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4231 * image.c (pbm_read_file): Likewise.
4232 * indent.c (string_display_width): Likewise.
4233 * intervals.c (check_for_interval, search_for_interval)
4234 (inc_interval_count, count_intervals, root_interval)
4235 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4236 * lread.c (defalias): Likewise.
4237 * ralloc.c (r_alloc_check): Likewise.
4238 * regex.c (set_image_of_range_1, set_image_of_range)
4239 (regex_grow_registers): Likewise.
4240 * sysdep.c (strerror): Likewise.
4241 * termcap.c (valid_filename_p, tprint, main): Likewise.
4242 * tparam.c (main): Likewise.
4243 * unexhp9k800.c (run_time_remap, save_data_space)
4244 (update_file_ptrs, read_header, write_header, calculate_checksum)
4245 (copy_file, copy_rest, display_header): Likewise.
4246 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4248 * xdisp.c (check_it): Likewise.
4249 * xfaces.c (register_color, unregister_color, unregister_colors):
4251 * xfns.c (print_fontset_result): Likewise.
4252 * xrdb.c (member, fatal, main): Likewise.
4254 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4256 Fix minor problems found by static checking (Bug#9031).
4257 * chartab.c (char_table_set_range, map_sub_char_table):
4258 Remove unused locals.
4259 (uniprop_table): Now static.
4260 * composite.c (_work_char): Remove unused static var.
4262 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4264 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4266 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4268 * gtkutil.c (qttip_cb): Remove code without function.
4270 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4272 * w32.c (pthread_sigmask): New stub.
4274 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4276 Use pthread_sigmask, not sigprocmask (Bug#9010).
4277 sigprocmask is portable only for single-threaded applications, and
4278 Emacs can be multi-threaded when it uses GTK.
4279 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4281 * callproc.c (Fcall_process):
4282 * process.c (create_process):
4283 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4284 Use pthread_sigmask, not sigprocmask.
4286 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4288 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4289 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4292 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4294 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4295 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4296 (xg_hide_tooltip): Fix comment.
4298 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4299 in registerServicesMenuSendTypes.
4300 (validRequestorForSendType): Don't check ns_return_types.
4302 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4305 2011-07-08 Jason Rumney <jasonr@gnu.org>
4307 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4308 SH_SHOW for hidden windows (Bug#5482).
4310 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4311 frame struct members of non-existent frames (Bug#6284).
4313 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4315 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4316 variable firstTime not needed on OSX >= 10.6.
4317 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4318 >= 10.5. Use setKnobProportion, setDoubleValue.
4320 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4321 (MAC_OS_X_VERSION_10_5): Define if not defined.
4322 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4323 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4324 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4326 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4327 cString and lossyCString on OSX >= 10.4
4329 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4330 sizeToFit on OSX >= 10.2.
4332 * nsimage.m (allocInitFromFile): Don't use deprecated method
4333 bestRepresentationForDevice on OSX >= 10.6.
4335 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4338 * emacs.c: Declare unexec_init_emacs_zone.
4340 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4342 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4344 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4345 on svcsMenu (Bug#8842).
4347 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4349 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4351 * nsterm.m (QUTF8_STRING): Declare.
4352 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4353 (validRequestorForSendType): Return type is (id).
4354 Change indexOfObjectIdenticalTo to indexOfObject.
4355 Check if we have local selection before returning self (Bug#8842).
4356 (writeSelectionToPasteboard): Put local selection into paste board
4357 if we have a local selection (Bug#8842).
4358 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4360 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4361 (ns_get_local_selection): Declare.
4363 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4365 * keymap.c (describe_map_tree): Don't insert a double newline at
4366 the end of the buffer (bug#1169) and return whether we inserted
4369 * callint.c (Fcall_interactively): Change "reading args" to
4370 "providing args" to try to clarify what it does (bug#1010).
4372 2011-07-07 Kenichi Handa <handa@m17n.org>
4374 * composite.c (composition_compute_stop_pos): Ignore a static
4375 composition starting before CHARPOS (Bug#8915).
4377 * xdisp.c (handle_composition_prop): Likewise.
4379 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4381 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4384 2011-07-07 Kenichi Handa <handa@m17n.org>
4386 * character.h (unicode_category_t): New enum type.
4388 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4389 (Qchar_code_property_table): New variable.
4390 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4391 (UNIPROP_COMPRESSED_FORM_P): New macros.
4392 (char_table_ascii): Uncompress the compressed values.
4393 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4394 Uncompress the compressed values.
4395 (sub_char_table_ref_and_range): Likewise.
4396 (char_table_ref_and_range): Uncompress the compressed values.
4397 (sub_char_table_set): New arg is_uniprop. Callers changed.
4398 Uncompress the compressed values.
4399 (sub_char_table_set_range): Args changed. Callers changed.
4400 (char_table_set_range): Adjuted for the above change.
4401 (map_sub_char_table): Delete args default_val and parent. Add arg
4402 top. Give decoded values to a Lisp function.
4403 (map_char_table): Adjust for the above change. Give decoded
4404 values to a Lisp function. Gcpro more variables.
4405 (uniprop_table_uncompress)
4406 (uniprop_decode_value_run_length): New functions.
4407 (uniprop_decoder, uniprop_decoder_count): New variables.
4408 (uniprop_get_decoder, uniprop_encode_value_character)
4409 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4411 (uniprop_encoder, uniprop_encoder_count): New variables.
4412 (uniprop_get_encoder, uniprop_table)
4413 (Funicode_property_table_internal, Fget_unicode_property_internal)
4414 (Fput_unicode_property_internal): New functions.
4415 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4416 Sunicode_property_table_internal, Sget_unicode_property_internal,
4417 and Sput_unicode_property_internal. Defvar_lisp
4418 char-code-property-alist.
4420 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4421 Vunicode_category_table.
4423 * font.c (font_range): Adjust for the change of
4424 Vunicode_category_table.
4426 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4428 * m/iris4d.h: Remove file, move contents ...
4429 * s/irix6-5.h: ... here.
4431 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4433 Remove unportable assumption about struct layout (Bug#8884).
4434 * alloc.c (mark_buffer):
4435 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4436 (clone_per_buffer_values): Don't assume that
4437 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4438 This isn't true in general, and it's particularly not true
4439 if Emacs is configured with --with-wide-int.
4440 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4441 New macros, used in the buffer.c change.
4443 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4445 * xsettings.c: Use both GConf and GSettings if both are available.
4446 (store_config_changed_event): Add comment.
4447 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4448 (store_tool_bar_style_changed): New functions.
4449 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4450 (struct xsettings): Move font inside HAVE_XFT.
4451 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4452 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4453 Move inside HAVE_XFT.
4454 (something_changed_gsettingsCB): Rename from something_changedCB.
4455 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4457 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4458 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4459 (something_changed_gconfCB): Rename from something_changedCB.
4460 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4461 (parse_settings): Move check for font inside HAVE_XFT.
4462 (read_settings, apply_xft_settings): Add comment.
4463 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4464 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4465 call store_font_name_changed.
4466 (xft_settings_event): Add comment.
4467 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4468 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4469 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4470 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4471 (xsettings_initialize): Call init_gsettings last.
4472 (xsettings_get_system_font, xsettings_get_system_normal_font):
4475 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4477 Random fixes. E.g., (random) never returned negative values.
4478 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4479 subseconds part to the entropy, as that's a bit more random.
4480 Prefer signed to unsigned, since the signedness doesn't matter and
4481 in general we prefer signed. When given a limit, use a
4482 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4483 latter isn't right if USE_2_TAGS_FOR_INTS.
4484 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4485 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4487 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4489 * textprop.c (text_property_stickiness):
4490 Obey Vtext_property_default_nonsticky.
4491 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4492 * w32fns.c (syms_of_w32fns):
4493 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4495 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4497 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4498 This is more efficient than Ffile_directory_p and avoids a minor race.
4500 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4502 * buffer.c (Foverlay_put): Say what the return value is
4505 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4506 is a directory before asking whether to use the file name
4508 (barf_or_query_if_file_exists): Make the "File is a directory"
4509 error be more correct.
4511 * fns.c (Frequire): Remove the mention of the .gz files, since
4512 that's installation-specific, but keep the mention of
4513 `get-load-suffixes'.
4515 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4517 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4518 Report string overflow if the output is too long.
4520 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4522 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4523 (syms_of_gnutls): Remove duplicate DEFSYM for
4524 Qgnutls_bootprop_verify_hostname_error, an error for
4525 Qgnutls_bootprop_verify_error (which is no longer used).
4527 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4528 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4529 Also (re)move comments that are misplaced or no longer relevant.
4531 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4533 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4535 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4537 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4538 and background color parameters if they have been changed.
4540 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4542 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4544 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4546 * xsettings.c (SYSTEM_FONT): Define only when used.
4547 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4549 * keymap.c (access_keymap_1): Now static.
4551 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4553 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4554 leave any prefix arg for the up event (Bug#1586).
4556 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4558 * lread.c (syms_of_lread): Mention single symbols defined by
4559 `defvar' or `defconst' (bug#7154).
4561 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4562 (Frequire): Mention get-load-suffixes.
4564 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4566 * window.h (window): Remove clone_number slot.
4567 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4569 (make_parent_window, make_window, saved_window)
4570 (Fset_window_configuration, save_window_save): Don't deal with
4572 * buffer.c (Qclone_number): Remove declaration.
4573 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4575 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4577 Add multiple inheritance to keymaps.
4578 * keymap.c (Fmake_composed_keymap): New function.
4579 (Fset_keymap_parent): Simplify.
4580 (fix_submap_inheritance): Remove.
4581 (access_keymap_1): New function extracted from access_keymap to handle
4582 embedded parents and handle lists of maps.
4583 (access_keymap): Use it.
4584 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4585 (Fcopy_keymap): Handle embedded parents.
4586 (Fcommand_remapping, define_as_prefix): Simplify.
4587 (Fkey_binding): Simplify.
4588 (syms_of_keymap): Move minibuffer-local-completion-map,
4589 minibuffer-local-filename-completion-map,
4590 minibuffer-local-must-match-map, and
4591 minibuffer-local-filename-must-match-map to Elisp.
4592 (syms_of_keymap): Defsubr make-composed-keymap.
4593 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4594 (parse_menu_item): Trivial simplification.
4596 2011-07-01 Glenn Morris <rgm@gnu.org>
4598 * Makefile.in (SETTINGS_LIBS): Fix typo.
4600 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4602 * coding.c (Fencode_coding_string): Record the last coding system
4603 used, as the function doc string says (bug#8738).
4605 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4607 * xsettings.c (store_monospaced_changed): Take new font as arg and
4608 check for change against current_mono_font.
4609 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4610 (emacs_settings_constructor, emacs_settings_get_property)
4611 (emacs_settings_set_property, emacs_settings_class_init)
4612 (emacs_settings_init, gsettings_obj): Remove.
4613 (something_changedCB): New function for HAVE_GSETTINGS.
4614 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4615 with value as argument.
4616 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4617 g_settings_new (Bug#8967). Do not create gsettings_obj.
4618 Remove calls to g_settings_bind. Connect something_changedCB to
4621 * xgselect.c: Add defined (HAVE_GSETTINGS).
4622 (xgselect_initialize): Ditto.
4624 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4625 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4628 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4630 * eval.c (struct backtrace): Simplify and port the data structure.
4631 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4632 signed bit field, as this assumption is not portable and it makes
4633 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4634 "char debug_on_exit : 1" as this is not portable either; instead,
4635 use the portable "unsigned int debug_on_exit : 1". Remove unused
4636 member evalargs. Remove obsolete comments about cc bombing out.
4638 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4640 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4641 Let HAVE_GSETTINGS override HAVE_GCONF.
4642 (store_monospaced_changed): New function.
4643 (EMACS_SETTINGS): A new type derived from GObject to handle
4644 GSettings notifications.
4645 (emacs_settings_constructor, emacs_settings_get_property)
4646 (emacs_settings_set_property, emacs_settings_class_init):
4648 (gsettings_client, gsettings_obj): New variables.
4649 (GSETTINGS_SCHEMA): New define.
4650 (something_changedCB): Call store_monospaced_changed.
4651 (init_gsettings): New function.
4652 (xsettings_initialize): Call init_gsettings.
4653 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4656 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4659 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4661 * window.c (resize_root_window, grow_mini_window)
4662 (shrink_mini_window): Rename Qresize_root_window to
4663 Qwindow_resize_root_window and Qresize_root_window_vertically to
4664 Qwindow_resize_root_window_vertically.
4666 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4668 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4670 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4672 * makefile.w32-in: Redesign dependencies so they reflect more
4673 clearly which files are directly included by each source file,
4674 and not through other includes.
4676 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4678 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4679 (sort_overlays, overlay_strings): When an overlay's clone number
4680 matches the window's clone number process the overlay even if
4681 the overlay's window property doesn't match the current window.
4683 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4684 (Fwindow_hchild): Rename to Fwindow_left_child.
4685 (Fwindow_next): Rename to Fwindow_next_sibling.
4686 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4687 (resize_window_check): Rename to window_resize_check.
4688 (resize_window_apply): Rename to window_resize_apply.
4689 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4690 (Fdelete_other_windows_internal, resize_frame_windows)
4691 (Fsplit_window_internal, Fdelete_window_internal)
4692 (grow_mini_window, shrink_mini_window)
4693 (Fresize_mini_window_internal): Fix callers accordingly.
4695 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4697 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4698 (emacs_fixed_set_min_size): Remove.
4699 (emacs_fixed_new): Take frame as argument.
4701 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4702 (_EmacsFixedPrivate): Remove minwidth/height.
4703 Add struct frame *f.
4704 (emacs_fixed_init): Initialize priv->f.
4705 (get_parent_class, emacs_fixed_set_min_size): Remove.
4706 (emacs_fixed_new): Set priv->f to argument.
4707 (emacs_fixed_get_preferred_width)
4708 (emacs_fixed_get_preferred_height): Use min_width/height from
4709 frames size_hint to set minimum and natural (Bug#8919).
4710 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4711 and use min_width/height from frames size_hint to set
4712 min_width/height (Bug#8919).
4714 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4715 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4718 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4720 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4721 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4724 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4726 * process.c (wait_reading_process_output): Bypass select if
4727 waiting for a cell while ignoring keyboard input, and input is
4728 pending. Suggested by Jan Djärv (Bug#8869).
4730 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4732 Use gnulib's dup2 module instead of rolling our own.
4733 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4735 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4737 * dispnew.c (scrolling_window): Before scrolling, turn off a
4738 mouse-highlight in the window being scrolled.
4740 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4742 Move DEFSYM to lisp.h and use everywhere.
4744 * character.h (DEFSYM): Move declaration...
4745 * lisp.h (DEFSYM): ...here.
4751 * w32select.c: Don't include character.h.
4753 * alloc.c (syms_of_alloc):
4754 * buffer.c (syms_of_buffer):
4755 * bytecode.c (syms_of_bytecode):
4756 * callint.c (syms_of_callint):
4757 * casefiddle.c (syms_of_casefiddle):
4758 * casetab.c (init_casetab_once):
4759 * category.c (init_category_once, syms_of_category):
4760 * ccl.c (syms_of_ccl):
4761 * cmds.c (syms_of_cmds):
4762 * composite.c (syms_of_composite):
4763 * dbusbind.c (syms_of_dbusbind):
4764 * dired.c (syms_of_dired):
4765 * dispnew.c (syms_of_display):
4766 * doc.c (syms_of_doc):
4767 * editfns.c (syms_of_editfns):
4768 * emacs.c (syms_of_emacs):
4769 * eval.c (syms_of_eval):
4770 * fileio.c (syms_of_fileio):
4771 * fns.c (syms_of_fns):
4772 * frame.c (syms_of_frame):
4773 * fringe.c (syms_of_fringe):
4774 * insdel.c (syms_of_insdel):
4775 * keymap.c (syms_of_keymap):
4776 * lread.c (init_obarray, syms_of_lread):
4777 * macros.c (syms_of_macros):
4778 * msdos.c (syms_of_msdos):
4779 * print.c (syms_of_print):
4780 * process.c (syms_of_process):
4781 * search.c (syms_of_search):
4782 * sound.c (syms_of_sound):
4783 * syntax.c (init_syntax_once, syms_of_syntax):
4784 * terminal.c (syms_of_terminal):
4785 * textprop.c (syms_of_textprop):
4786 * undo.c (syms_of_undo):
4787 * w32.c (globals_of_w32):
4788 * window.c (syms_of_window):
4789 * xdisp.c (syms_of_xdisp):
4790 * xfaces.c (syms_of_xfaces):
4791 * xfns.c (syms_of_xfns):
4792 * xmenu.c (syms_of_xmenu):
4793 * xsettings.c (syms_of_xsettings):
4794 * xterm.c (syms_of_xterm): Use DEFSYM.
4796 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4798 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4800 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4802 Integer and buffer overflow fixes (Bug#8873).
4804 * print.c (printchar, strout): Check for string overflow.
4805 (PRINTPREPARE, printchar, strout):
4806 Don't set size unless allocation succeeds.
4808 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4809 for sizes. Check for string overflow more accurately.
4810 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4812 * macros.c: Integer and buffer overflow fixes.
4813 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4814 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4815 Use ptrdiff_t, not int, for sizes.
4816 Don't increment bufsize until after realloc succeeds.
4817 Check for size-calculation overflow.
4818 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4820 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4822 * lread.c: Integer overflow fixes.
4823 (read_integer): Radix is now EMACS_INT, not int,
4824 to improve quality of diagnostics for out-of-range radices.
4825 Calculate buffer size correctly for out-of-range radices.
4826 (read1): Check for integer overflow in radices, and in
4827 read-circle numbers.
4828 (read_escape): Avoid int overflow.
4829 (Fload, openp, read_buffer_size, read1)
4830 (substitute_object_recurse, read_vector, read_list, map_obarray):
4831 Use ptrdiff_t, not int, for sizes.
4832 (read1): Use EMACS_INT, not int, for sizes.
4833 Check for size overflow.
4835 * image.c (cache_image): Check for size arithmetic overflow.
4837 * lread.c: Integer overflow issues.
4838 (saved_doc_string_size, saved_doc_string_length)
4839 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4840 Now ptrdiff_t, not int.
4841 (read1): Don't assume doc string length fits in int. Check for
4842 out-of-range doc string lengths.
4843 (read_list): Don't assume file position fits in int.
4844 (read_escape): Check for hex character overflow.
4846 2011-06-22 Leo Liu <sdl.web@gmail.com>
4848 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4849 Move to minibuffer.el.
4851 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4853 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4854 The following patches are for when GLYPH_DEBUG && !XASSERT.
4855 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4856 * dispnew.c (flush_stdout):
4857 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4858 Mark as externally visible.
4859 * dispnew.c (check_window_matrix_pointers): Now static.
4860 * dispnew.c (window_to_frame_vpos):
4861 * xfns.c (unwind_create_frame):
4862 * xterm.c (x_check_font): Remove unused local.
4863 * scroll.c (CHECK_BOUNDS):
4864 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4865 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4866 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4867 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4868 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4870 (debug_method_add): Use va_list and vsprintf rather than relying
4871 on undefined behavior with wrong number of arguments.
4872 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4873 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4874 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4875 since we're not interested in debugging glyphs with old libraries.
4876 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4877 GCC 4.6.0's static checking.
4879 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4881 Integer overflow and signedness fixes (Bug#8873).
4882 A few related buffer overrun fixes, too.
4884 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4886 * dispextern.h (struct face.stipple):
4887 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4888 (x_bitmap_mask, x_allocate_bitmap_record)
4889 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4890 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4891 (x_create_bitmap_from_xpm_data):
4892 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4893 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4895 * xfaces.c (load_pixmap):
4896 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4897 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4898 (.bitmaps_last, struct x_output.icon_bitmap):
4899 Use ptrdiff_t, not int, for bitmap indexes.
4900 (x_allocate_bitmap_record): Check for size overflow.
4901 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4903 Use ptrdiff_t, not int, for overlay counts.
4904 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4905 * editfns.c (overlays_around, get_pos_property):
4906 * textprop.c (get_char_property_and_overlay):
4907 * xdisp.c (next_overlay_change, note_mouse_highlight):
4908 * xfaces.c (face_at_buffer_position):
4909 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4910 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4911 (Fnext_overlay_change, Fprevious_overlay_change)
4912 (mouse_face_overlay_overlaps, Foverlays_in):
4913 Use ptrdiff_t, not int, for sizes.
4914 (overlays_at, overlays_in): Check for size-calculation overflow.
4916 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4918 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4919 (x_session_initialize): Do not assume string length fits in int.
4921 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4922 This is unlikely, but can occur if DPI is outlandish.
4924 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4925 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4927 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4928 * xrdb.c (magic_file_p, search_magic_path):
4929 Omit last arg SUFFIX; it was always 0. All callers changed.
4930 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4932 * xfont.c (xfont_match): Avoid need for strlen.
4934 * xfns.c: Don't assume strlen fits in int.
4935 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4937 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4938 not unsigned long, as we prefer signed integers. All callers changed.
4939 Detect integer overflow in repeat count.
4940 (message_dolog): Don't assume print length fits in 39 bytes.
4941 (display_mode_element): Don't assume strlen fits in int.
4943 * termcap.c: Don't assume sizes fit in int and never overflow.
4944 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4945 (gobble_line): Check for size-calculation overflow.
4947 * minibuf.c (Fread_buffer):
4948 * lread.c (intern, intern_c_string):
4949 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4950 Don't assume string length fits in int.
4952 * keyboard.c (parse_tool_bar_item):
4953 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4955 * font.c: Don't assume string length fits in int.
4956 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4957 Use ptrdiff_t, not int.
4958 (font_intern_prop): Don't assume string length fits in int.
4959 Don't assume integer property fits in fixnum.
4960 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4962 * filelock.c: Fix some buffer overrun and integer overflow issues.
4963 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4964 Reformulate so as not to need the command string.
4965 Invoke gzip -cd rather than gunzip, as it's more portable.
4966 (lock_info_type, lock_file_1, lock_file):
4967 Don't assume pid_t and time_t fit in unsigned long.
4968 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4969 (current_lock_owner): Prefer signed type for sizes.
4970 Use memcpy, not strncpy, where memcpy is what is really wanted.
4971 Don't assume (via atoi) that time_t and pid_t fit in int.
4972 Check for time_t and/or pid_t out of range, e.g., via a network share.
4973 Don't alloca where an auto var works fine.
4975 * fileio.c: Fix some integer overflow issues.
4976 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4977 Don't assume string length fits in int.
4978 (directory_file_name): Don't assume string length fits in long.
4979 (make_temp_name): Don't assume pid fits in int, or that its print
4980 length is less than 20.
4982 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4984 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4986 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4988 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4989 We prefer signed integers, even for size calculations.
4991 * emacs.c: Don't assume string length fits in 'int'.
4992 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4993 (main): Don't invoke strlen when not needed.
4995 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4996 (XD_DEBUG_MESSAGE): Don't waste a byte.
4998 * callproc.c (getenv_internal_1, getenv_internal)
5000 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5002 * lread.c (invalid_syntax): Omit length argument.
5003 All uses changed. This doesn't fix a bug, but it simplifies the
5004 code away from its former Hollerith-constant appearance, and it's
5005 one less 'int' to worry about when looking at integer-overflow issues.
5006 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5008 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5009 This didn't break anything, but it didn't help either.
5010 It's confusing to put a bogus integer in a place where the actual
5011 value does not matter.
5012 (LIST_END_P): Remove unused macro and its bogus comment.
5013 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5015 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5016 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5018 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5019 We prefer signed types, and the value cannot exceed the EMACS_INT
5020 range anyway (because otherwise the length would not be representable).
5021 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5022 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5023 This avoids a GCC warning when WIDE_EMACS_INT.
5025 * indent.c (sane_tab_width): New function.
5026 (current_column, scan_for_column, Findent_to, position_indentation)
5027 (compute_motion): Use it. This is just for clarity.
5028 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5030 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5032 * lisp.h (lint_assume): New macro.
5033 * composite.c (composition_gstring_put_cache):
5034 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5036 * editfns.c, insdel.c:
5037 Omit unnecessary forward decls, to simplify future changes.
5039 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5041 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5043 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5044 Use much-faster test for byte-length change.
5045 Don't assume string byte-length fits in 'int'.
5046 Check that character arg fits in 'int'.
5047 (mapcar1): Declare byte as byte, for clarity.
5049 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5051 * fns.c (concat): Catch string overflow earlier.
5052 Do not rely on integer wraparound.
5054 * dispextern.h (struct it.overlay_strings_charpos)
5055 (struct it.selective): Now EMACS_INT, not int.
5056 * xdisp.c (forward_to_next_line_start)
5057 (back_to_previous_visible_line_start)
5058 (reseat_at_next_visible_line_start, next_element_from_buffer):
5059 Don't arbitrarily truncate the value of 'selective' to int.
5061 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5063 * composite.c: Don't truncate sizes to 'int'.
5064 (composition_gstring_p, composition_reseat_it)
5065 (composition_adjust_point): Use EMACS_INT, not int.
5066 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5067 not EMACS_UINT, for indexes.
5069 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5071 * buffer.c: Include <verify.h>.
5072 (struct sortvec.priority, struct sortstr.priority):
5073 Now EMACS_INT, not int.
5074 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5075 (struct sortstr.size, record_overlay_string)
5076 (struct sortstrlist.size, struct sortlist.used):
5077 Don't truncate size to int.
5078 (record_overlay_string): Check for size-calculation overflow.
5079 (init_buffer_once): Check at compile-time, not run-time.
5081 2011-06-22 Jim Meyering <meyering@redhat.com>
5083 Don't leak an XBM-image-sized buffer
5084 * image.c (xbm_load): Free the image buffer after using it.
5086 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5089 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5090 that Sun C diagnosed.
5091 * fns.c (secure_hash): Fix pointer signedness issue.
5092 * intervals.c (static_offset_intervals): New function.
5093 (offset_intervals): Use it.
5095 2011-06-21 Leo Liu <sdl.web@gmail.com>
5098 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5101 * fns.c (secure_hash): Rename from crypto_hash_function and change
5102 the first arg to accept symbols.
5103 (Fsecure_hash): New primitive.
5104 (syms_of_fns): New symbols.
5106 2011-06-20 Deniz Dogan <deniz@dogan.se>
5108 * process.c (Fset_process_buffer): Clarify return value in
5111 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5113 * dispnew.c (add_window_display_history): Use BVAR.
5115 * xdisp.c (debug_method_add): Use BVAR.
5116 (check_window_end, dump_glyph_matrix, dump_glyph)
5117 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5119 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5122 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5123 check till after the cache is created in init_frame_faces.
5125 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5127 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5129 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5131 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5132 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5133 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5135 Improve buffer-overflow checking (Bug#8873).
5136 * fileio.c (Finsert_file_contents):
5137 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5138 Remove the old (too-loose) buffer overflow checks.
5139 They weren't needed, since make_gap checks for buffer overflow.
5140 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5141 The old code merely checked for Emacs fixnum overflow, and relied
5142 on undefined (wraparound) behavior. The new code avoids undefined
5143 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5145 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5146 Tune. Don't use wider integers than needed. Don't use alloca.
5147 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5149 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5151 * insdel.c, lisp.h (buffer_overflow): New function.
5152 (insert_from_buffer_1, replace_range, replace_range_2):
5153 * insdel.c (make_gap_larger):
5154 * editfns.c (Finsert_char):
5155 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5157 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5159 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5161 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5163 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5164 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5166 * fileio.c: Don't assume EMACS_INT fits in off_t.
5167 (emacs_lseek): New static function.
5168 (Finsert_file_contents, Fwrite_region): Use it.
5169 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5171 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5173 * fns.c: Don't overflow int when computing a list length.
5174 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5175 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5176 truncation on 64-bit hosts. Check for QUIT every
5177 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5178 faster and is responsive enough.
5179 (Flength): Report an error instead of overflowing an integer.
5180 (Fsafe_length): Return a float if the value is not representable
5181 as a fixnum. This shouldn't happen except in contrived situations.
5182 (Fnthcdr, Fsort): Don't assume list length fits in int.
5183 (Fcopy_sequence): Don't assume vector length fits in int.
5185 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5186 (header_size, word_size): New constants.
5187 (allocate_vectorlike): Don't check size overflow here.
5188 (allocate_vector): Check it here instead, since this is the only
5189 caller of allocate_vectorlike that could cause overflow.
5190 Check that the new vector's length is representable as a fixnum.
5192 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5193 The previous code was bogus. For example, next_almost_prime (32)
5194 returned 39, which is undesirable as it is a multiple of 3; and
5195 next_almost_prime (24) returned 25, which is a multiple of 5 so
5196 why was the code bothering to check for multiples of 7?
5198 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5200 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5202 Variadic C functions now count arguments with ptrdiff_t.
5203 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5204 Back then I didn't know that the Emacs coding style prefers signed int.
5205 Also, in the meantime I found a few more instances where arguments
5206 were being counted with int, which may truncate counts on 64-bit
5207 machines, or EMACS_INT, which may be unnecessarily wide.
5208 * lisp.h (struct Lisp_Subr.function.aMANY)
5209 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5210 Arg counts are now ptrdiff_t, not size_t.
5211 All variadic functions and their callers changed accordingly.
5212 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5213 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5214 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5215 * callint.c (Fcall_interactively): Check arg count for overflow,
5216 to avoid potential buffer overrun. Use signed char, not 'int',
5217 for 'varies' array, so that we needn't bother to check its size
5218 calculation for overflow.
5219 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5220 * eval.c (apply_lambda):
5221 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5222 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5223 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5225 * callint.c (Fcall_interactively): Don't use index var as event count.
5227 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5228 * mem-limits.h (SIZE): Remove; no longer used.
5230 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5232 Remove unnecessary casts.
5233 * xterm.c (x_term_init):
5234 * xfns.c (x_set_border_pixel):
5235 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5236 These aren't needed now that we assume ANSI C.
5238 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5239 It's more likely to cause problems (due to unsigned overflow)
5242 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5244 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5246 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5248 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5250 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5252 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5254 GLYPH_CODE_FACE returns EMACS_INT, not int.
5255 * dispextern.h (merge_faces):
5256 * xfaces.c (merge_faces):
5257 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5258 Don't assume EMACS_INT fits in int.
5260 * character.h (CHAR_VALID_P): Remove unused parameter.
5261 * fontset.c, lisp.h, xdisp.c: All uses changed.
5263 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5265 * fns.c (concat): Minor tuning based on overflow analysis.
5266 This doesn't fix any bugs. Use int to hold character, instead
5267 of constantly refetching from Emacs object. Use XFASTINT, not
5268 XINT, for value known to be a character. Don't bother comparing
5269 a single byte to 0400, as it's always less.
5271 * floatfns.c (Fexpt):
5272 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5274 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5277 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5279 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5280 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5281 incorrectly succeed when S was a string, because 4294967386 was
5282 truncated before it was used.
5284 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5285 Otherwise, an out-of-range integer could cause undefined behavior
5288 * composite.c: Use int, not EMACS_INT, for characters.
5289 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5290 EMACS_INT, for values that are known to be in character range.
5291 This doesn't fix any bugs but is the usual style inside Emacs and
5292 may generate better code on 32-bit machines.
5294 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5295 This is for reasons similar to the recent CHAR_STRING fix.
5296 * charset.c (Fencode_char): Check that character arg is actually
5297 a character. Pass an int to ENCODE_CHAR.
5298 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5299 wider than 'int', as a compile-time check to prevent future regressions
5302 * character.c (char_string): Remove unnecessary casts.
5304 Make sure a 64-bit char is never passed to CHAR_STRING.
5305 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5306 by silently ignoring the top 32 bits, allowing some values
5307 that were far too large to be valid characters.
5308 * character.h: Include <verify.h>.
5309 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5310 arguments are no wider than unsigned, as a compile-time check
5311 to prevent future regressions in this area.
5313 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5314 (Fsubst_char_in_region):
5316 * xdisp.c (decode_mode_spec_coding):
5317 Adjust to CHAR_STRING's new requirement.
5318 * editfns.c (Finsert_char, Fsubst_char_in_region):
5319 * fns.c (concat): Check that character args are actually
5320 characters. Without this test, these functions did the wrong
5321 thing with wildly out-of-range values on 64-bit hosts.
5323 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5324 These casts should not be needed on 32-bit hosts, either.
5325 * keyboard.c (read_char):
5326 * lread.c (Fload): Remove casts to unsigned.
5328 * lisp.h (UNSIGNED_CMP): New macro.
5329 This fixes comparison bugs on 64-bit hosts.
5330 (ASCII_CHAR_P): Use it.
5331 * casefiddle.c (casify_object):
5332 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5333 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5334 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5335 * dispextern.h (FACE_FROM_ID):
5336 * keyboard.c (read_char): Use UNSIGNED_CMP.
5338 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5339 not to EMACS_INT, to avoid GCC warning.
5341 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5343 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5344 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5345 isn't needed on 32-bit machines.
5347 * buffer.c (Fgenerate_new_buffer_name):
5348 Use EMACS_INT for count, not int.
5349 (advance_to_char_boundary): Return EMACS_INT, not int.
5351 * data.c (Qcompiled_function): Now static.
5353 * window.c (window_body_lines): Now static.
5355 * image.c (gif_load): Rename local to avoid shadowing.
5357 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5358 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5359 * alloc.c (make_save_value): Integer argument is now of type
5361 (mark_object): Use ptrdiff_t, not int.
5362 * lisp.h (pD): New macro.
5363 * print.c (print_object): Use it.
5365 * alloc.c: Use EMACS_INT, not int, to count objects.
5366 (total_conses, total_markers, total_symbols, total_vector_size)
5367 (total_free_conses, total_free_markers, total_free_symbols)
5368 (total_free_floats, total_floats, total_free_intervals)
5369 (total_intervals, total_strings, total_free_strings):
5370 Now EMACS_INT, not int. All uses changed.
5371 (Fgarbage_collect): Compute overall total using a double, so that
5372 integer overflow is less likely to be a problem. Check for overflow
5373 when converting back to an integer.
5374 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5375 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5376 These were 'int' variables that could overflow on 64-bit hosts;
5377 they were never used, so remove them instead of repairing them.
5378 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5379 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5380 Previously, this ceilinged at INT_MAX, but that doesn't work on
5382 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5384 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5385 (allocate_vectorlike): Check for ptrdiff_t overflow.
5386 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5387 when a (possibly-narrower) signed value would do just as well.
5388 We prefer using signed arithmetic, to avoid comparison confusion.
5390 * alloc.c: Catch some string size overflows that we were missing.
5391 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5392 for convenience in STRING_BYTES_MAX.
5393 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5394 The definition here is exact; the one in lisp.h was approximate.
5395 (allocate_string_data): Check for string overflow. This catches
5396 some instances we weren't catching before. Also, it catches
5397 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5398 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5399 and ptrdiff_t and EMACS_INT are both 64 bits.
5401 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5402 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5403 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5405 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5407 * alloc.c (Fmake_string): Check for out-of-range init.
5409 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5411 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5413 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5415 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5416 xg_get_default_scrollbar_width.
5418 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5419 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5420 (style_changed_cb): Call update_theme_scrollbar_width and call
5421 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5422 all frames (Bug#8505).
5423 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5424 Call gtk_window_set_resizable if HAVE_GTK3.
5425 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5426 and height if HAVE_GTK3 (Bug#8505).
5427 (scroll_bar_width_for_theme): New variable.
5428 (update_theme_scrollbar_width): New function.
5429 (xg_get_default_scrollbar_width): Move code to
5430 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5431 (xg_initialize): Call update_theme_scrollbar_width.
5433 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5435 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5437 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5439 * frame.c (make_frame): Call other_buffer_safely instead of
5442 * window.c (temp_output_buffer_show): Call display_buffer with
5443 second argument Vtemp_buffer_show_specifiers and reset latter
5444 immediately after the call.
5445 (Vtemp_buffer_show_specifiers): New variable.
5446 (auto_window_vscroll_p, next_screen_context_lines)
5447 (Vscroll_preserve_screen_position): Remove leading asterisks from
5450 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5452 Fix minor problems found by GCC 4.6.0 static checking.
5453 * buffer.c (Qclone_number): Remove for now, as it's unused.
5454 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5455 (record_buffer): Remove unused local.
5456 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5457 (set_frame_buffer_list): Remove; unused.
5458 * frame.h (other_visible_frames): Remove decl.
5459 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5460 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5461 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5463 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5464 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5465 Define only if HAVE_GPM.
5466 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5467 (update_hints_inhibit): Remove; never set. All uses removed.
5468 * widgetprv.h (emacsFrameClassRec): Remove decl.
5469 * window.c (delete_deletable_window): Now returns void, since it
5470 wasn't returning anything.
5471 (compare_window_configurations): Remove unused locals.
5472 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5473 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5474 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5475 the same widths as pointers. This follows up on the 2011-05-06 patch.
5476 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5477 * xterm.h: Likewise.
5478 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5480 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5482 * makefile.w32-in: Update dependencies.
5483 (LISP_H): Add lib/intprops.h.
5485 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5487 * image.c (gif_load): Add animation frame delay to the metadata.
5488 (syms_of_image): Use DEFSYM. New symbol `delay'.
5490 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5492 * window.c (delete_deletable_window): Re-add.
5493 (Fset_window_configuration): Rewrite to handle dead buffers and
5494 consequently deletable windows.
5495 (window_tree, Fwindow_tree): Remove. Supply functionality in
5497 (compare_window_configurations): Simplify code.
5499 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5501 * image.c (imagemagick_load_image): Fix type mismatch.
5502 (Fimagemagick_types): Likewise.
5504 * window.h (replace_buffer_in_windows): Declare.
5506 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5508 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5509 Qclone_number. Remove external declaration of Qdelete_window.
5510 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5512 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5513 Run Qbuffer_list_update_hook if allowed.
5514 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5515 buffer list implementation.
5516 (other_buffer_safely): New function.
5517 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5518 calls to replace_buffer_in_windows and
5519 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5521 (record_buffer): Inhibit quitting and rewrite using quittable
5522 functions. Run Qbuffer_list_update_hook if allowed.
5523 (Frecord_buffer, Funrecord_buffer): New functions.
5524 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5525 Move switch-to-buffer to window.el.
5526 (bury-buffer): Move to window.el.
5527 (Vbuffer_list_update_hook): New variable.
5529 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5532 * window.h (resize_frame_windows): Move up in code.
5533 (Fwindow_frame): Remove EXFUN.
5534 (replace_buffer_in_all_windows): Remove prototype.
5535 (replace_buffer_in_windows_safely): Add prototype.
5537 * window.c: Declare Qdelete_window static again. Move down
5538 declaration of select_count.
5539 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5540 (Fother_window): Move to window.el.
5541 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5542 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5543 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5545 (replace_buffer_in_windows): Implement by calling
5546 Qreplace_buffer_in_windows.
5547 (replace_buffer_in_all_windows): Remove with some functionality
5548 moved into replace_buffer_in_windows_safely.
5549 (replace_buffer_in_windows_safely): New function.
5550 (select_window_norecord, select_frame_norecord): Move in front
5551 of run_window_configuration_change_hook. Remove now obsolete
5553 (Fset_window_buffer): Rewrite doc-string.
5554 Call Qrecord_window_buffer.
5555 (keys_of_window): Move binding for other-window to window.el.
5557 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5559 * dispextern.h (struct image): Replace data member, whose int_val
5560 and ptr_val fields were not used by anything, with a single
5563 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5564 (gif_clear_image, gif_load, imagemagick_load_image)
5565 (gs_clear_image, gs_load): Callers changed.
5567 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5569 * buffer.h: Include <time.h>, for time_t.
5570 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5572 Fix minor problems found by static checking.
5574 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5576 Make identifiers static if they are not used in other modules.
5577 * data.c (Qcompiled_function, Qframe, Qvector):
5578 * image.c (QimageMagick, Qsvg):
5579 * minibuf.c (Qmetadata):
5580 * window.c (resize_window_check, resize_root_window): Now static.
5581 * window.h (resize_window_check, resize_root_window): Remove decls.
5583 * window.c (window_deletion_count, delete_deletable_window):
5585 (window_body_lines): Now static.
5586 (Fdelete_other_windows_internal): Mark vars as initialized.
5587 Make sure 'resize_failed' is initialized.
5588 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5589 (resize_window_apply): Remove unused local.
5590 * window.h (delete_deletable_window): Remove decl.
5592 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5593 (imagemagick_load_image): Fix pointer signedness problem by changing
5594 last arg from unsigned char * to char *. All uses changed.
5595 Also, fix a local for similar reasons.
5596 Remove unused locals. Remove locals to avoid shadowing.
5597 (fn_rsvg_handle_free): Remove; unused.
5598 (svg_load, svg_load_image): Fix pointer signedness problem.
5599 (imagemagick_load_image): Don't use garbage pointer image_wand.
5601 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5603 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5605 * image.c (gif_load): Fix omitted cast error introduced by
5608 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5610 * window.h (resize_proportionally, orig_total_lines)
5611 (orig_top_line): Remove from window structure.
5612 (set_window_height, set_window_width, change_window_heights)
5613 (Fdelete_window): Remove prototypes.
5614 (resize_frame_windows): Remove duplicate declaration.
5616 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5618 * window.h (resize_frame_windows, resize_window_check)
5619 (delete_deletable_window, resize_root_window)
5620 (resize_frame_windows): Declare prototypes.
5622 * window.c (resize_window_apply): Make definition be "static" to
5623 match the prototype.
5625 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5627 * window.c: Remove declarations of Qwindow_size_fixed,
5628 window_min_size_1, window_min_size_2, window_min_size,
5629 size_window, window_fixed_size_p, enlarge_window, delete_window.
5630 Remove static from declaration of Qdelete_window, it's
5631 temporarily needed by Fbury_buffer.
5632 (replace_window): Don't assign orig_top_line and
5634 (Fdelete_window, delete_window): Remove. Window deletion is
5635 handled by window.el.
5636 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5637 Replace Fdelete_window calls with calls to Qdelete_window.
5638 (Fdelete_other_windows): Remove. Deleting other windows is
5639 handled by window.el.
5640 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5641 handled in window.el.
5642 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5643 Window minimum sizes are handled in window.el.
5644 (shrink_windows, size_window, set_window_height)
5645 (set_window_width, change_window_heights, window_height)
5646 (window_width, CURBEG, CURSIZE, enlarge_window)
5647 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5648 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5649 handled in window.el.
5650 (make_dummy_parent): Rename to make_parent_window and give it a
5651 second argument horflag.
5652 (make_window): Don't set resize_proportionally any more.
5653 (Fsplit_window): Remove. Windows are split in window.el.
5654 (save_restore_action, save_restore_orig_size)
5655 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5656 Resize mini windows in window.el.
5657 (grow_mini_window, shrink_mini_window): Implement by calling
5658 Qresize_root_window_vertically, resize_window_check and
5659 resize_window_apply.
5660 (saved_window, Fset_window_configuration, save_window_save):
5661 Do not handle orig_top_line, orig_total_lines, and
5662 resize_proportionally.
5663 (window_min_height, window_min_width): Move to window.el.
5664 (keys_of_window): Move bindings for delete-other-windows,
5665 split-window, delete-window and enlarge-window to window.el.
5667 * buffer.c: Temporarily extern Qdelete_window.
5668 (Fbury_buffer): Temporarily call Qdelete_window instead of
5669 Fdelete_window (Fbury_buffer will move to window.el soon).
5671 * frame.c (set_menu_bar_lines_1): Remove code handling
5672 orig_top_line and orig_total_lines.
5674 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5675 set_window_height but set heights directly.
5676 (change_frame_size_1): Use resize_frame_windows.
5678 * xdisp.c (init_xdisp): Don't use set_window_height but set
5681 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5682 Use resize_frame_windows instead of change_window_heights and run
5683 run_window_configuration_change_hook.
5685 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5686 instead of change_window_heights and run
5687 run_window_configuration_change_hook.
5689 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5691 * window.c (replace_window): Rename second argument REPLACEMENT to
5692 NEW. New third argument SETFLAG. Rewrite.
5693 (delete_window, make_dummy_parent): Call replace_window with
5695 (window_list_1): Move down in code.
5696 (run_window_configuration_change_hook): Move set_buffer part
5697 before select_frame_norecord part in order to unwind correctly.
5698 Rename count1 to count.
5699 (recombine_windows, delete_deletable_window, resize_root_window)
5700 (Fdelete_other_windows_internal)
5701 (Frun_window_configuration_change_hook, make_parent_window)
5702 (resize_window_check, resize_window_apply, Fresize_window_apply)
5703 (resize_frame_windows, Fsplit_window_internal)
5704 (Fdelete_window_internal, Fresize_mini_window_internal):
5706 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5708 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5710 * window.h (window): Add some new members to window structure -
5711 normal_lines, normal_cols, new_total, new_normal, clone_number,
5712 splits, nest, prev_buffers, next_buffers.
5713 (WINDOW_TOTAL_SIZE): Move here from window.c.
5714 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5716 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5718 (make_dummy_parent): Set new members of windows structure.
5719 (make_window): Move down in code. Handle new members of window
5721 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5722 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5723 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5724 (Fset_window_prev_buffers, Fwindow_next_buffers)
5725 (Fset_window_next_buffers, Fset_window_clone_number):
5727 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5728 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5730 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5731 Argument WINDOW can be now internal window too.
5732 (Fwindow_use_time): Move up in code.
5733 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5735 (Fset_window_configuration, saved_window)
5736 (Fcurrent_window_configuration, save_window_save): Handle new
5737 members of window structure.
5738 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5739 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5740 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5741 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5742 Qget_mru_window, Qresize_root_window,
5743 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5744 Qauto_buffer_name; staticpro them.
5746 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5748 * window.c (Fwindow_total_size, Fwindow_left_column)
5749 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5750 (Fwindow_list_1): New functions.
5751 (window_box_text_cols): Replace with window_body_cols.
5752 (Fwindow_width, Fscroll_left, Fscroll_right):
5753 Use window_body_cols instead of window_box_text_cols.
5754 (delete_window, Fset_window_configuration):
5755 Call delete_all_subwindows with window as argument.
5756 (delete_all_subwindows): Take a window as argument and not a
5758 (window_loop): Remove handling of GET_LRU_WINDOW and
5760 (Fget_lru_window, Fget_largest_window): Move to window.el.
5762 * window.h: Extern window_body_cols instead of
5763 window_box_text_cols. delete_all_subwindows now takes a
5764 Lisp_Object as argument.
5766 * indent.c (compute_motion, Fcompute_motion):
5767 Use window_body_cols instead of window_box_text_cols.
5769 * frame.c (delete_frame): Call delete_all_subwindows with root
5772 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5774 * fns.c (Fputhash): Document return value.
5776 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5778 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5780 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5782 Cons<->int and similar integer overflow fixes (Bug#8794).
5784 Check for overflow when converting integer to cons and back.
5785 * charset.c (Fdefine_charset_internal, Fdecode_char):
5786 Use cons_to_unsigned to catch overflow.
5787 (Fencode_char): Use INTEGER_TO_CONS.
5788 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5789 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5790 * data.c (long_to_cons, cons_to_long): Remove.
5791 (cons_to_unsigned, cons_to_signed): New functions.
5792 These signal an error for invalid or out-of-range values.
5793 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5794 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5795 * font.c (Ffont_variation_glyphs):
5796 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5797 * lisp.h: Include <intprops.h>.
5798 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5799 (cons_to_signed, cons_to_unsigned): New decls.
5800 (long_to_cons, cons_to_long): Remove decls.
5801 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5802 (Fprimitive_undo): Use CONS_TO_INTEGER.
5803 * xfns.c (Fx_window_property): Likewise.
5804 * xselect.c: Include <limits.h>.
5805 (x_own_selection, selection_data_to_lisp_data):
5806 Use INTEGER_TO_CONS.
5807 (x_handle_selection_request, x_handle_selection_clear)
5808 (x_get_foreign_selection, Fx_disown_selection_internal)
5809 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5810 (lisp_data_to_selection_data): Use cons_to_unsigned.
5811 (x_fill_property_data): Use cons_to_signed.
5812 Report values out of range.
5814 Check for buffer and string overflow more precisely.
5815 * buffer.h (BUF_BYTES_MAX): New macro.
5816 * lisp.h (STRING_BYTES_MAX): New macro.
5817 * alloc.c (Fmake_string):
5818 * character.c (string_escape_byte8):
5819 * coding.c (coding_alloc_by_realloc):
5820 * doprnt.c (doprnt):
5821 * editfns.c (Fformat):
5823 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5824 since they may not be the same number.
5825 * editfns.c (Finsert_char):
5826 * fileio.c (Finsert_file_contents):
5827 Likewise for BUF_BYTES_MAX.
5829 * image.c: Use ptrdiff_t, not int, for sizes.
5830 (slurp_file): Switch from int to ptrdiff_t.
5832 (slurp_file): Check that file size fits in both size_t (for
5833 malloc) and ptrdiff_t (for sanity and safety).
5835 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5836 if b->modtime has its maximal value.
5838 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5840 Don't assume time_t can fit into int.
5841 * buffer.h (struct buffer.modtime): Now time_t, not int.
5842 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5843 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5845 Minor fixes for signed vs unsigned integers.
5846 * character.h (MAYBE_UNIFY_CHAR):
5847 * charset.c (maybe_unify_char):
5848 * keyboard.c (read_char, reorder_modifiers):
5849 XINT -> XFASTINT, since the integer must be nonnegative.
5850 * ftfont.c (ftfont_spec_pattern):
5851 * keymap.c (access_keymap, silly_event_symbol_error):
5852 XUINT -> XFASTINT, since the integer must be nonnegative.
5853 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5854 since it makes no difference and we prefer signed.
5855 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5856 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5859 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5861 * window.h (Fwindow_frame): Declare.
5863 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5865 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5866 (SPARE_MEMORY): Always define.
5867 (LARGE_REQUEST): Remove.
5868 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5870 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5872 * lisp.h: Move EXFUNS for Fframe_root_window,
5873 Fframe_first_window and Fset_frame_selected_window to window.h.
5875 * window.h: Move EXFUNS for Fframe_root_window,
5876 Fframe_first_window and Fset_frame_selected_window here from
5879 * frame.c (Fwindow_frame, Fframe_first_window)
5880 (Fframe_root_window, Fframe_selected_window)
5881 (Fset_frame_selected_window): Move to window.c.
5882 (Factive_minibuffer_window): Move to minibuf.c.
5883 (Fother_visible_frames_p): New function.
5885 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5887 * window.c (decode_window, decode_any_window): Move up in code.
5888 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5889 (inhibit_frame_unsplittable): Remove unused variable.
5890 (Fwindow_buffer): Move up and rewrite doc-string.
5891 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5892 (Fwindow_prev): New functions.
5893 (Fwindow_frame): Move here from frame.c. Accept any window as
5895 (Fframe_root_window, Fframe_first_window)
5896 (Fframe_selected_window): Move here from frame.c. Accept frame
5897 or arbitrary window as argument. Update doc-strings.
5898 (Fminibuffer_window): Move up in code.
5899 (Fwindow_minibuffer_p): Move up in code and simplify.
5900 (Fset_frame_selected_window): Move here from frame.c.
5902 (Fselected_window, select_window, Fselect_window): Move up in
5903 code. Minor doc-string fixes.
5905 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5907 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5908 Do not assume that spare memory exists; that assumption is valid
5909 only if SYSTEM_MALLOC.
5910 (LARGE_REQUEST): New macro, so that the issue of large requests
5911 is separated from the issue of spare memory.
5913 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5915 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5918 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5920 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5923 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5925 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5927 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5929 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5930 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5932 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5934 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5936 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5938 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5939 (x_clipboard_manager_save): Add return value.
5940 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5942 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5943 Obey Vx_select_enable_clipboard_manager. Catch errors in
5944 x_clipboard_manager_save (Bug#8779).
5945 (Vx_select_enable_clipboard_manager): New variable.
5946 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5948 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5950 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5952 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5954 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5955 in the current matrix if keep_current_p is non-zero.
5957 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5959 * bidi.c (bidi_level_of_next_char): Fix last change.
5961 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5963 Support bidi reordering of text covered by display properties.
5965 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5966 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5967 (bidi_cache_search, bidi_cache_iterator_state)
5968 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5969 (bidi_level_of_next_char, bidi_move_to_visually_next):
5970 Support character positions inside a run of characters covered by a
5972 (bidi_paragraph_init, bidi_resolve_explicit_1)
5973 (bidi_level_of_next_char): Call bidi_fetch_char and
5974 bidi_fetch_char_advance instead of FETCH_CHAR and
5976 (bidi_init_it): Initialize new members.
5977 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5979 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5980 instead of using explicit *_CHAR codes.
5981 (bidi_resolve_explicit, bidi_resolve_weak):
5982 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5983 bidirectional text is supported only in multibyte buffers.
5984 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5985 it to initialize the frame_window_p member of struct bidi_it.
5986 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5987 (bidi_resolve_explicit, bidi_resolve_weak)
5988 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5989 bidi_it->nchars is non-positive.
5990 (bidi_level_of_next_char): Don't try to lookup the cache for the
5991 next/previous character if nothing is cached there yet, or if we
5992 were just reseat()'ed to a new position.
5994 * xdisp.c (set_cursor_from_row): Set start and stop points
5995 according to the row's direction when priming the loop that looks
5996 for the glyph on which to display cursor.
5997 (single_display_spec_intangible_p): Function deleted.
5998 (display_prop_intangible_p): Reimplement to call
5999 handle_display_spec instead of single_display_spec_intangible_p.
6000 Accept 3 additional arguments needed by handle_display_spec.
6001 This fixes incorrect cursor motion across display property with complex
6002 values: lists, `(when COND...)' forms, etc.
6003 (single_display_spec_string_p): Support property values that are
6004 lists with the argument STRING its top-level element.
6005 (display_prop_string_p): Fix the condition for processing a
6006 property that is a list to be consistent with handle_display_spec.
6007 (handle_display_spec): New function, refactored from the
6008 last portion of handle_display_prop.
6009 (compute_display_string_pos): Accept additional argument
6010 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6011 value of a `display' property is a "replacing spec".
6012 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6013 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6014 the display property, but just return a value indicating whether
6015 the display property will replace the characters it covers.
6016 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6017 frame_window_p members of struct bidi_it.
6018 (compute_display_string_pos, compute_display_string_end):
6020 (push_it): Accept second argument POSITION, where pop_it should
6021 jump to continue iteration.
6022 (reseat_1): Initialize bidi_it.disp_pos.
6024 * keyboard.c (adjust_point_for_property): Adjust the call to
6025 display_prop_intangible_p to its new signature.
6027 * dispextern.h (struct bidi_it): New member frame_window_p.
6028 (bidi_init_it): Update prototypes.
6029 (display_prop_intangible_p): Update prototype.
6030 (compute_display_string_pos, compute_display_string_end):
6032 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6035 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6037 Malloc failure behavior now depends on size of allocation.
6038 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6039 * lisp.h: Change signatures accordingly.
6040 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6041 All callers changed. (Bug#8762)
6043 * gnutls.c: Use Emacs's memory allocators.
6044 Without this change, the gnutls library would invoke malloc etc.
6045 directly, which causes problems on non-SYNC_INPUT hosts, and which
6046 runs afoul of improving memory_full behavior. (Bug#8761)
6047 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6048 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6049 xfree instead of the default malloc, realloc, free.
6050 (Fgnutls_boot): No need to check for memory allocation failure,
6051 since xmalloc does that for us.
6053 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6054 * category.c (hash_get_category_set):
6055 * ccl.c (ccl_driver):
6056 * charset.c (Fdefine_charset_internal):
6057 * charset.h (struct charset.hash_index):
6058 * composite.c (get_composition_id, gstring_lookup_cache)
6059 (composition_gstring_put_cache):
6060 * composite.h (struct composition.hash_index):
6061 * dispextern.h (struct image.hash):
6062 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6063 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6064 (hashfn_equal, hashfn_user_defined, make_hash_table)
6065 (maybe_resize_hash_table, hash_lookup, hash_put)
6066 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6067 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6068 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6069 * image.c (make_image, search_image_cache, lookup_image)
6070 (xpm_put_color_table_h):
6071 * lisp.h (struct Lisp_Hash_Table):
6072 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6073 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6074 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6075 * alloc.c (allocate_vectorlike):
6076 Check for overflow in vector size calculations.
6077 * ccl.c (ccl_driver):
6078 Check for overflow when converting EMACS_INT to int.
6079 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6080 need to be updated by these changes.
6081 * fns.c (make_hash_table, maybe_resize_hash_table):
6082 Check for integer overflow with large hash tables.
6083 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6084 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6085 (SXHASH_REDUCE): New macro.
6086 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6087 Use it instead of discarding useful hash info with large hash values.
6088 (sxhash_float): New function.
6089 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6090 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6091 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6092 Rewrite to use FIXNUM_BITS, as this simplifies things.
6093 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6094 Adjust signatures to match updated version of code.
6095 (consing_since_gc): Now EMACS_INT, since a single hash table can
6096 use more than INT_MAX bytes.
6098 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6100 Make it possible to build with GCC-4.6+ -O2 -flto.
6102 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6104 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6106 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6107 Call minibuffer-inactive-mode.
6109 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6111 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6112 Update dependencies.
6114 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6116 * data.c (init_data): Remove code for UTS, this system is not
6119 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6121 Don't force ./temacs to start in terminal mode.
6123 * frame.c (make_initial_frame): Initialize faces in all cases, not
6124 only when CANNOT_DUMP is defined.
6125 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6127 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6129 * dispnew.c (add_window_display_history): Use const for the string
6130 pointer. Remove declaration, not needed.
6132 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6134 Use 'inline', not 'INLINE'.
6135 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6136 * alloc.c, fontset.c (INLINE): Remove.
6137 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6138 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6139 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6140 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6141 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6143 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6145 Make it possible to run ./temacs.
6147 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6148 syms_of_callproc does the same thing. Remove test for
6149 "initialized", do it in the caller.
6150 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6152 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6154 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6155 (read_minibuf): Use get_minibuffer.
6156 (syms_of_minibuf): Use DEFSYM.
6157 (Qmetadata): New var.
6158 * data.c (Qbuffer): Don't make it static.
6159 (syms_of_data): Use DEFSYM.
6161 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6163 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6164 (CCL_CODE_MIN): New macro.
6166 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6168 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6170 * eval.c (Qdebug): Now static.
6171 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6172 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6173 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6175 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6177 * image.c: Various fixes to ImageMagick code comments.
6178 (Fimagemagick_types): Doc fix.
6180 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6182 Minor fixes prompted by GCC 4.6.0 warnings.
6184 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6186 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6187 (x_clipboard_manager_save_all): Move extern decl to ...
6188 * xterm.h: ... here, so that it can be checked for consistency.
6190 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6192 * xselect.c (x_clipboard_manager_save_frame)
6193 (x_clipboard_manager_save_all): New functions.
6194 (Fx_clipboard_manager_save): Lisp function deleted.
6196 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6197 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6199 * xterm.h: Update prototype.
6201 2011-05-28 William Xu <william.xwl@gmail.com>
6203 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6206 2011-05-28 Jim Meyering <meyering@redhat.com>
6208 Avoid a sign-extension bug in crypto_hash_function.
6209 * fns.c (to_uchar): Define.
6210 (crypto_hash_function): Use it to convert some newly-signed
6211 variables to unsigned, to avoid sign-extension bugs. For example,
6212 without this change, (md5 "truc") would evaluate to
6213 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6214 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6215 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6217 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6219 Integer overflow fixes.
6221 * dbusbind.c: Serial number integer overflow fixes.
6222 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6223 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6224 to hold a serial number that is too large for a fixnum.
6225 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6226 Check for serial numbers out of range. Decode any serial number
6227 that was so large that it became a float. (Bug#8722)
6229 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6230 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6231 Use XFASTINT rather than XUINT when numbers are nonnegative.
6232 (xd_append_arg, Fdbus_method_return_internal):
6233 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6234 arguments, check that Lisp number is nonnegative, rather than
6235 silently wrapping negative numbers around. (Bug#8722)
6236 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6239 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6241 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6243 ccl: Add integer overflow checks.
6244 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6245 (IN_INT_RANGE): New macros.
6246 (ccl_driver): Use them to check for integer overflow when
6247 decoding a CCL program. Many of the new checks are whether XINT (x)
6248 fits in int; it doesn't always, on 64-bit hosts. The new version
6249 doesn't catch all possible integer overflows, but it's an
6250 improvement. (Bug#8719)
6252 * alloc.c (make_event_array): Use XINT, not XUINT.
6253 There's no need for unsigned here.
6255 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6256 This follows up to the 2011-05-06 change that substituted uintptr_t
6257 for EMACS_INT. This case wasn't caught back then.
6259 Rework Fformat to avoid integer overflow issues.
6260 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6261 now (part of C89). Include <verify.h>.
6262 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6263 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6264 (Fformat): Avoid the prepass trying to compute sizes; it was only
6265 approximate and thus did not catch overflow reliably. Instead, walk
6266 through the format just once, formatting and computing sizes as we go,
6267 checking for integer overflow at every step, and allocating a larger
6268 buffer as needed. Keep track separately whether the format is
6269 multibyte. Keep only the most-recently calculated precision, rather
6270 than them all. Record whether each argument has been converted to
6271 string. Use EMACS_INT, not int, for byte and char and arg counts.
6272 Support field widths and precisions larger than INT_MAX. Avoid
6273 sprintf's undefined behavior with conversion specifications such as %#d
6274 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6275 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6276 formatting out-of-range floating point numbers with int
6279 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6281 * data.c: Avoid integer truncation in expressions involving floats.
6282 * data.c: Include <intprops.h>.
6283 (arith_driver): When there's an integer overflow in an expression
6284 involving floating point, convert the integers to floating point
6285 so that the resulting value does not suffer from catastrophic
6286 integer truncation. For example, on a 64-bit host (* 4
6287 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6288 Do not rely on undefined behavior after integer overflow.
6290 merge count_size_as_multibyte, parse_str_to_multibyte
6291 * character.c, character.h (count_size_as_multibyte):
6292 Rename from parse_str_to_multibyte; all uses changed.
6293 Check for integer overflow.
6294 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6295 since it's now a duplicate of the other. This is more of
6296 a character than a buffer op, so better that it's in character.c.
6297 * fns.c, print.c: Adjust to above changes.
6299 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6301 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6303 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6305 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6306 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6307 (x_clipboard_manager_save): Now static.
6308 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6310 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6311 (crypto_hash_function): Now static.
6312 Fix pointer signedness problems. Avoid unnecessary initializations.
6314 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6316 * termhooks.h (Vselection_alist): Make it terminal-local.
6318 * terminal.c (create_terminal): Initialize it.
6320 * xselect.c: Support for clipboard managers.
6321 (Vselection_alist): Move to termhooks.h as terminal-local var.
6322 (LOCAL_SELECTION): New macro.
6323 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6324 (symbol_to_x_atom): Remove gratuitous arg.
6325 (x_handle_selection_request, lisp_data_to_selection_data)
6326 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6327 (x_own_selection, x_get_local_selection, x_convert_selection):
6328 New arg, specifying work frame. Use terminal-local Vselection_alist.
6329 (some_frame_on_display): Delete unused function.
6330 (Fx_own_selection_internal, Fx_get_selection_internal)
6331 (Fx_disown_selection_internal, Fx_selection_owner_p)
6332 (Fx_selection_exists_p): New optional frame arg.
6333 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6334 (x_handle_selection_clear): Don't treat other terminals with the
6335 same keyboard specially. Use the terminal-local Vselection_alist.
6336 (x_clear_frame_selections): Use Frun_hook_with_args.
6338 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6340 * xterm.h: Add support for those atoms.
6342 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6344 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6345 (converted_selections, conversion_fail_tag): New global variables.
6346 (x_selection_request_lisp_error): Free the above.
6347 (x_get_local_selection): Remove unnecessary code.
6348 (x_reply_selection_request): Args changed; handle arbitrary array
6349 of converted selections stored in converted_selections.
6350 Separate the XChangeProperty and SelectionNotify steps.
6351 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6352 (x_convert_selection): New function.
6353 (x_handle_selection_event): Simplify.
6354 (x_get_foreign_selection): Don't ignore incoming requests while
6355 waiting for an answer; this will fail when we implement
6356 SAVE_TARGETS, and seems unnecessary anyway.
6357 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6358 (Vx_sent_selection_functions): Doc fix.
6360 2011-05-26 Leo Liu <sdl.web@gmail.com>
6362 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6364 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6366 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6368 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6369 for fringe update if it has periodic bitmap.
6370 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6371 and fringe_bitmap_periodic_p.
6373 * fringe.c (get_fringe_bitmap_data): New function.
6374 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6375 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6376 row. Mark glyph row for fringe update if periodicity changed.
6378 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6379 for fringe update unless it has periodic bitmap.
6381 2011-05-25 Kenichi Handa <handa@m17n.org>
6383 * xdisp.c (get_next_display_element): Set correct it->face_id for
6384 a static composition.
6386 2011-05-24 Leo Liu <sdl.web@gmail.com>
6389 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6391 * fns.c (crypto_hash_function, Fsha1): New function.
6392 (Fmd5): Use crypto_hash_function.
6393 (syms_of_fns): Add Ssha1.
6395 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6397 * gnutls.c: Remove unused macros.
6398 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6399 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6400 Remove macros that are defined and never used.
6401 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6403 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6405 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6406 (Fx_get_selection_internal): Minor cleanup.
6407 (Fx_own_selection_internal): Rename arguments for consistency with
6410 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6412 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6414 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6416 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6418 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6420 * dispnew.c (scrolling_window): Don't exclude the case that the
6421 last enabled row in the desired matrix touches the bottom boundary.
6423 2011-05-21 Glenn Morris <rgm@gnu.org>
6425 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6426 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6427 and add some more files.
6429 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6431 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6432 report_file_error introduced by the change from 2011-05-07.
6434 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6436 * systime.h (Time): Define only if emacs is defined.
6437 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6438 where the include path doesn't have X11/X.h by default. See
6439 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6441 2011-05-20 Kenichi Handa <handa@m17n.org>
6443 * composite.c (find_automatic_composition): Fix previous change.
6445 2011-05-20 Glenn Morris <rgm@gnu.org>
6447 * lisp.mk: New file, split from Makefile.in.
6448 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6449 (shortlisp): Remove.
6450 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6452 2011-05-19 Glenn Morris <rgm@gnu.org>
6454 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6455 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6456 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6457 (lisp): Set the order to that of loadup.el.
6458 (shortlisp): Make it a copy of $lisp.
6459 (SOME_MACHINE_LISP): Remove.
6460 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6461 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6463 2011-05-18 Kenichi Handa <handa@m17n.org>
6465 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6466 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6467 (find_automatic_composition): Mostly rewrite for efficiency.
6469 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6471 * makefile.w32-in: Update dependencies.
6473 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6475 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6476 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6478 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6480 Fix some integer overflow issues, such as string length overflow.
6482 * insdel.c (count_size_as_multibyte): Check for string overflow.
6484 * character.c (lisp_string_width): Check for string overflow.
6485 Use EMACS_INT, not int, for string indexes and lengths; in
6486 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6487 the resulting string length overflows an EMACS_INT; instead,
6488 report a string overflow if no precision given. When checking for
6489 precision exhaustion, use a check that cannot possibly have
6490 integer overflow. (Bug#8675)
6491 * character.h (lisp_string_width): Adjust to new signature.
6493 * alloc.c (string_overflow): New function.
6494 (Fmake_string): Use it. This doesn't change behavior, but saves
6495 a few bytes and will simplify future changes.
6496 * character.c (string_escape_byte8): Likewise.
6497 * lisp.h (string_overflow): New decl.
6499 Fixups, following up to the user-interface timestamp change.
6500 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6501 for UI timestamps, instead of unsigned long.
6502 * msdos.c (mouse_get_pos): Likewise.
6503 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6504 * w32gui.h (Time): Define by including "systime.h" rather than by
6505 declaring it ourselves. (Bug#8664)
6507 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6508 * image.c (clear_image_cache): Likewise.
6510 * term.c (term_mouse_position): Don't assume time_t wraparound.
6512 Be more systematic about user-interface timestamps.
6513 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6514 and sometimes 'EMACS_UINT', to represent these timestamps.
6515 This change causes it to use 'Time' uniformly, as that's what X uses.
6516 This makes the code easier to follow, and makes it easier to catch
6517 integer overflow bugs such as Bug#8664.
6518 * frame.c (Fmouse_position, Fmouse_pixel_position):
6519 Use Time, not unsigned long, for user-interface timestamps.
6520 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6521 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6522 * keyboard.h (last_event_timestamp): Likewise.
6523 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6524 * menu.h (xmenu_show): Likewise.
6525 * term.c (term_mouse_position): Likewise.
6526 * termhooks.h (struct input_event.timestamp): Likewise.
6527 (struct terminal.mouse_position_hook): Likewise.
6528 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6529 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6530 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6531 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6533 * menu.h, termhooks.h: Include "systime.h", for Time.
6535 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6536 Don't assume that the difference between two unsigned long values
6537 can fit into an integer. At this point, we know button_down_time
6538 <= event->timestamp, so the difference must be nonnegative, so
6539 there's no need to cast the result if double-click-time is
6540 nonnegative, as it should be; check that it's nonnegative, just in
6541 case. This bug is triggered when events are more than 2**31 ms
6542 apart (about 25 days). (Bug#8664)
6544 * xselect.c (last_event_timestamp): Remove duplicate decl.
6545 (x_own_selection): Remove needless cast to unsigned long.
6547 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6548 that always fit in int. Use a sentinel instead of a counter, to
6549 avoid a temp and to allay GCC's concerns about possible int overflow.
6550 * frame.h (struct frame): Use int for menu_bar_items_used
6551 instead of EMACS_INT, since it always fits in int.
6553 * menu.c (grow_menu_items): Check for int overflow.
6555 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6557 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6558 Before, the code was not consistent. These values cannot exceed
6559 2**31 - 1 so there's no need to make them unsigned.
6560 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6561 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6562 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6564 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6566 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6567 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6568 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6569 presumably because the widths might not match.
6571 * window.c (size_window): Avoid needless test at loop start.
6573 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6575 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6577 2011-05-12 Drew Adams <drew.adams@oracle.com>
6579 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6581 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6583 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6584 `width' to `bar_area_x' and `bar_area_width', respectively.
6585 (x_scroll_run): Take account of fringe background extension.
6587 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6588 Rename local vars `left' and `width' to `bar_area_x' and
6589 `bar_area_width', respectively.
6590 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6591 background extension.
6593 2011-05-10 Jim Meyering <meyering@redhat.com>
6595 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6597 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6599 * image.c (Finit_image_library): Return t for built-in image types,
6600 like pbm and xbm. (Bug#8640)
6602 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6604 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6606 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6608 * w32console.c (Fset_screen_color): Doc fix.
6609 (Fget_screen_color): New function.
6610 (syms_of_ntterm): Defsubr it.
6612 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6613 unlink the temporary file if Fcall_process didn't create it in the
6615 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6616 child process will be redirected to a file specified with `:file'.
6617 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6618 cue to call_process_cleanup not to close that handle.
6620 2011-05-07 Ben Key <bkey76@gmail.com>
6622 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6623 one of two shell specific rules, either bootstrap-temacs-CMD or
6624 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6625 to the previous implementation of the bootstrap-temacs rule.
6626 The bootstrap-temacs-CMD rule is similar to the previous
6627 implementation of the bootstrap-temacs rule except that it
6628 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6631 These changes, along with some changes to nt/configure.bat,
6632 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6633 earlier fix to add support for --cflags and --ldflags options
6634 that include quotes so that it works whether make uses cmd or
6637 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6639 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6640 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6642 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6643 a string. Handle both cases.
6644 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6645 (Fdbus_register_method): Use Qinvalid_function.
6647 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6649 * makefile.w32-in: Update dependencies.
6650 (LISP_H): Add inttypes.h and stdin.h.
6651 (PROCESS_H): Add unistd.h.
6653 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6655 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6656 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6658 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6660 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6662 * term.c (vfatal): Remove stray call to va_end.
6663 It's not needed and the C Standard doesn't allow it here anyway.
6665 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6666 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6668 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6671 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6673 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6675 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6677 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6679 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6681 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6682 * charset.c (Fdefine_charset_internal): Don't initialize
6683 charset.code_space[15]. The value was garbage, on hosts with
6684 32-bit int (Bug#8600).
6686 * lread.c (read_integer): Be more consistent with string-to-number.
6687 Use string_to_number to do the actual conversion; this avoids
6688 rounding errors and fixes some other screwups. Without this fix,
6689 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6690 (digit_to_number): Move earlier, for benefit of read_integer.
6691 Return -1 if the digit is out of range for the base, -2 if it is
6692 not a digit in any supported base. (Bug#8602)
6694 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6696 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6697 to match comment at start of function. This also removes a
6698 GCC warning about overflow in a 32+64-bit port.
6700 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6702 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6703 Reported by Stefan Monnier in
6704 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6705 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6706 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6708 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6709 (EMACS_UINTPTR): Likewise, with uintptr_t.
6711 * lisp.h: Prefer 64-bit EMACS_INT if available.
6712 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6713 on 32-bit hosts that have 64-bit int, so that they can access
6715 However, temporarily disable this change unless the temporary
6716 symbol WIDE_EMACS_INT is defined.
6718 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6720 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6721 This removes an assumption that EMACS_INT and long are the same
6722 width as pointers. The assumption is true for Emacs porting targets
6723 now, but we want to make other targets possible.
6724 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6725 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6726 In the rest of the code, change types of integers that hold casted
6727 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6728 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6729 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6730 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6731 No need to cast type when ORing.
6732 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6733 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6734 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6735 assume EMACS_INT is the same width as char *.
6736 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6737 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6738 Remove no-longer-needed casts.
6739 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6740 (xg_tool_bar_help_callback, xg_make_tool_item):
6741 Use EMACS_INTPTR to hold an integer
6742 that will be cast to void *; this can avoid a GCC warning
6743 if EMACS_INT is not the same width as void *.
6744 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6745 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6746 (current_message_1, set_message_1):
6747 Use a local to convert to proper width without a cast.
6748 * xmenu.c (dialog_selection_callback): Likewise.
6750 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6751 Also, don't assume VALBITS / RAND_BITS is less than 5,
6752 and don't rely on undefined behavior when shifting a 1 left into
6754 * lisp.h (get_random): Change signature to match.
6756 * lread.c (hash_string): Use size_t, not int, for hash computation.
6757 Normally we prefer signed values; but hashing is special, because
6758 it's better to use unsigned division on hash table sizes so that
6759 the remainder is nonnegative. Also, size_t is the natural width
6760 for hashing into memory. The previous code used 'int', which doesn't
6761 retain enough info to hash well into very large tables.
6762 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6764 * dbusbind.c: Don't possibly lose pointer info when converting.
6765 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6766 Use XPNTR rather than XHASH, so that the high-order bits of
6767 the pointer aren't lost when converting through void *.
6769 * eval.c (Fautoload): Don't double-shift a pointer.
6771 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6773 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6775 * gnutls.c (DEF_GNUTLS_FN):
6776 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6778 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6780 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6783 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6785 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6786 New version that can reserve upto 2GB of heap space.
6788 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6790 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6792 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6794 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6795 `gnutls_certificate_set_x509_key_file'.
6797 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6799 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6800 Update dependencies.
6802 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6804 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6805 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6806 Remove unused parameter `fildes'.
6807 * process.c (read_process_output, send_process): Don't pass it.
6809 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6811 Fix previous change: the library cache is defined in w32.c.
6812 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6813 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6815 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6817 Implement dynamic loading of GnuTLS on Windows.
6819 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6820 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6821 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6824 * gnutls.c (Qgnutls_dll): Define.
6825 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6826 (gnutls_*): Declare function pointers.
6827 (init_gnutls_functions): New function to initialize function pointers.
6828 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6829 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6830 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6831 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6832 (emacs_gnutls_write, emacs_gnutls_read)
6833 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6834 (Fgnutls_available_p): New function.
6835 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6836 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6837 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6839 * image.c: Include w32.h.
6840 (Vimage_type_cache): Delete.
6841 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6842 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6843 (w32_delayed_load): Move to w32.c.
6845 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6847 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6848 (w32_delayed_load): Move from image.c. When loading a library, record
6849 its filename in the :loaded-from property of the library id.
6850 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6851 Initialize and staticpro them.
6852 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6854 * process.c: Include lisp.h before w32.h, not after.
6855 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6856 instead of gnutls_record_check_pending.
6858 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6860 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6862 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6863 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6866 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6868 * xterm.c (x_set_frame_alpha): Do not set property on anything
6869 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6871 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6873 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6875 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6877 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6878 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6879 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6880 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6881 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6882 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6883 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6884 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6885 (Qgnutls_bootprop_callbacks_verify): Make static.
6887 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6889 * callproc.c: Indentation fixup.
6891 * sysdep.c (wait_for_termination_1): Make static.
6892 (wait_for_termination, interruptible_wait_for_termination):
6893 Move after wait_for_termination_1.
6895 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6897 * sysdep.c (interruptible_wait_for_termination): New function
6898 which is like wait_for_termination, but allows keyboard
6901 * callproc.c (Fcall_process): Add (:file "file") as an option for
6903 (Fcall_process_region): Ditto.
6905 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6907 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6908 rather than `XVECTOR (FOO)->size'.
6910 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6911 inttypes.h, as a gnulib replacement is used if it not available in
6914 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6916 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6917 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6918 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6920 * coding.c (coding_alloc_by_realloc): Error out if destination
6921 will grow beyond MOST_POSITIVE_FIXNUM.
6922 (decode_coding_emacs_mule): Abort if there isn't enough place in
6923 charbuf for the composition carryover bytes. Reserve an extra
6924 space for up to 2 characters produced in a loop.
6925 (decode_coding_iso_2022): Abort if there isn't enough place in
6926 charbuf for the composition carryover bytes.
6928 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6930 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6931 aborting when %lld or %lll format is passed.
6932 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6933 %llo or %llx format is passed. (Bug#8545)
6935 * window.c (window_scroll_line_based): Use a marker instead of
6936 simple variables to record original value of point. (Bug#7952)
6938 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6939 produced by %s or %c overflows available buffer space. (Bug#8545)
6941 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6943 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6944 (SIZE_MAX): Move defn after all includes, as they might #define it.
6946 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6948 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6950 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6952 * keyboard.c (Qdelayed_warnings_hook): Define.
6953 (command_loop_1): Run `delayed-warnings-hook'
6954 if Vdelayed_warnings_list is non-nil.
6955 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6956 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6958 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6960 * doprnt.c (doprnt): Don't return value smaller than the buffer
6961 size if the message was truncated. (Bug#8545).
6963 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6965 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6966 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6968 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6970 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6972 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6974 * makefile.w32-in: Update dependencies.
6976 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6978 Improve `doprnt' and its usage. (Bug#8545)
6979 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6980 `format_end'. Remove support for %l as a conversion specifier.
6981 Don't use xrealloc. Improve diagnostics when the %l size modifier
6982 is used. Update the commentary.
6984 * eval.c (verror): Simplify calculation of size_t.
6986 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6989 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6991 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6994 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6996 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6997 This makes this file independent of the recent pseudovector change.
6999 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7001 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7003 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7004 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7005 Remove unused local.
7006 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7008 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7009 GCC 4.6.0 optimizes based on type-based alias analysis.
7010 For example, if b is of type struct buffer * and v of type struct
7011 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7012 != &v->size, and therefore "v->size = 1; b->size = 2; return
7013 v->size;" must therefore return 1. This assumption is incorrect
7014 for Emacs, since it type-puns struct Lisp_Vector * with many other
7015 types. To fix this problem, this patch adds a new type struct
7016 vectorlike_header that documents the constraints on layout of vectors
7017 and pseudovectors, and helps optimizing compilers not get fooled
7018 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7019 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7020 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7022 (XSETPVECTYPE): Rewrite in terms of new macro.
7023 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7024 This is a bit clearer, and further avoids the possibility of
7025 undesirable aliasing.
7026 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7027 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7028 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7029 since Lisp_Subr is a special case (no "next" field).
7030 (ASIZE): Now uses header.size rather than size.
7031 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7032 to avoid the hassle of writing XVECTOR (foo)->header.size.
7033 (struct vectorlike_header): New type.
7034 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7035 object, to help avoid aliasing.
7036 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7037 (SUBRP): Likewise, since Lisp_Subr is a special case.
7038 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7039 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7040 (struct Lisp_Hash_Table): Combine first two members into a single
7041 struct vectorlike_header member. All uses of "size" and "next" members
7042 changed to be "header.size" and "header.next".
7043 * buffer.h (struct buffer): Likewise.
7044 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7045 * frame.h (struct frame): Likewise.
7046 * process.h (struct Lisp_Process): Likewise.
7047 * termhooks.h (struct terminal): Likewise.
7048 * window.c (struct save_window_data, struct saved_window): Likewise.
7049 * window.h (struct window): Likewise.
7050 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7051 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7052 * buffer.c (init_buffer_once): Likewise.
7053 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7055 * process.c (Fformat_network_address): Use local var for size,
7058 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7060 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7061 * data.c (atof): Remove decl; no longer used or needed.
7062 (digit_to_number): Move to lread.c.
7063 (Fstring_to_number): Use new string_to_number function, to be
7064 consistent with how the Lisp reader treats infinities and NaNs.
7065 Do not assume that floating-point numbers represent EMACS_INT
7066 without losing information; this is not true on most 64-bit hosts.
7067 Avoid double-rounding errors, by insisting on integers when
7068 parsing non-base-10 numbers, as the documentation specifies.
7069 * lisp.h (string_to_number): New decl, replacing ...
7070 (isfloat_string): Remove.
7071 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7072 (read1): Do not accept +. and -. as integers; this
7073 appears to have been a coding error. Similarly, do not accept
7074 strings like +-1e0 as floating point numbers. Do not report
7075 overflow for integer overflows unless the base is not 10 which
7076 means we have no simple and reliable way to continue.
7077 Break out the floating-point parsing into a new
7078 function string_to_number, so that Fstring_to_number parses
7079 floating point numbers consistently with the Lisp reader.
7080 (digit_to_number): Move here from data.c. Make it static inline.
7081 (E_CHAR, EXP_INT): Remove, replacing with ...
7082 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7083 (string_to_number): New function, replacing isfloat_string.
7084 This function checks for valid syntax and produces the resulting
7085 Lisp float number too. Rework it so that string-to-number
7086 no longer mishandles examples like "1.0e+". Use strtoumax,
7087 so that overflow for non-base-10 numbers is reported only when
7088 there's no portable and simple way to convert to floating point.
7090 * textprop.c (set_text_properties_1): Rewrite for clarity,
7091 and to avoid GCC warning about integer overflow.
7093 * intervals.h (struct interval): Use EMACS_INT for members
7094 where EMACS_UINT might cause problems. See
7095 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7096 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7097 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7099 (offset_intervals): Tell GCC not to worry about length overflow
7100 when negating a negative length.
7102 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7103 (overrun_check_free): Likewise.
7105 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7106 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7109 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7110 (gnutls_make_error): Rename local to avoid shadowing.
7111 (gnutls_emacs_global_deinit): ifdef out; not used.
7112 (Fgnutls_boot): Use const for pointer to readonly storage.
7113 Comment out unused local. Fix pointer signedness problems.
7115 * lread.c (openp): Don't stuff size_t into an 'int'.
7116 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7117 about possible signed overflow.
7119 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7120 (GDK_KEY_g): Don't define if already defined.
7121 (xg_prepare_tooltip): Avoid pointer signedness problem.
7122 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7124 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7125 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7127 * xfns.c (Fx_window_property): Simplify a bit,
7128 to make a bit faster and to avoid GCC 4.6.0 warning.
7129 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7131 * fns.c (internal_equal): Don't assume size_t fits in int.
7133 * alloc.c (compact_small_strings): Tighten assertion a little.
7135 Replace pEd with more-general pI, and fix some printf arg casts.
7136 * lisp.h (pI): New macro, generalizing old pEd macro to other
7137 conversion specifiers. For example, use "...%"pI"d..." rather
7138 than "...%"pEd"...".
7139 (pEd): Remove. All uses replaced with similar uses of pI.
7140 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7141 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7142 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7143 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7144 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7145 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7146 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7148 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7149 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7150 * print.c (safe_debug_print, print_object): Likewise.
7151 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7153 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7154 avoiding the 0 flag, which is not portable.
7155 * process.c (Fmake_network_process): Use pI to avoid cast.
7156 * region-cache.c (pp_cache): Likewise.
7157 * xdisp.c (decode_mode_spec): Likewise.
7158 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7159 behavior on 64-bit hosts with printf arg.
7160 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7161 (x_stop_queuing_selection_requests): Likewise.
7162 (x_get_window_property): Don't truncate byte count to an 'int'
7165 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7166 here, since it parses constructs like leading '-' and spaces,
7167 which are not wanted; and it overflows with large numbers.
7168 Instead, simply match F[0-9]+, which is what is wanted anyway.
7170 * alloc.c: Remove unportable assumptions about struct layout.
7171 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7172 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7173 (allocate_vectorlike, make_pure_vector): Use the new macros,
7174 plus offsetof, to remove unportable assumptions about struct layout.
7175 These assumptions hold on all porting targets that I know of, but
7176 they are not guaranteed, they're easy to remove, and removing them
7177 makes further changes easier.
7179 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7180 This doesn't fix a bug but makes the code clearer.
7181 (string_overrun_cookie): Now const. Use initializers that
7182 don't formally overflow signed char, to avoid warnings.
7183 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7184 can cause Emacs to crash when string overrun checking is enabled.
7185 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7186 multiple of sizeof (EMACS_INT); it need not be, if
7187 alignof(EMACS_INT) < sizeof (EMACS_INT).
7188 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7190 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7192 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7194 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7196 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7197 supposed to be handshaking. (Bug#8556)
7198 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7200 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7202 * lisp.h (Qdebug): List symbol.
7203 * eval.c (Qdebug): Restore global linkage.
7204 * keyboard.c (debug-on-event): New variable.
7205 (handle_user_signal): Break into debugger when debug-on-event
7206 matches the current signal symbol.
7208 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7210 * alloc.c (check_sblock, check_string_bytes)
7211 (check_string_free_list): Convert to standard C.
7213 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7215 * w32.c (emacs_gnutls_push): Fix typo.
7217 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7219 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7220 "cast to pointer from integer of different size".
7222 Improve doprnt and its use in verror. (Bug#8545)
7223 * doprnt.c (doprnt): Document the set of format control sequences
7224 supported by the function. Use SAFE_ALLOCA instead of always
7227 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7228 is one byte too soon. Don't use xrealloc; instead xfree and
7231 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7233 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7236 * gnutls.c: Renamed global_initialized to
7237 gnutls_global_initialized. Added internals for the
7238 :verify-hostname-error, :verify-error, and :verify-flags
7239 parameters of `gnutls-boot' and documented those parameters in the
7240 docstring. Start callback support.
7241 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7242 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7243 on error. Return error code.
7244 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7245 (emacs_gnutls_read): Likewise.
7246 (Fgnutls_boot): Return handshake error code.
7247 (emacs_gnutls_handle_error): New function.
7248 (wsaerror_to_errno): Likewise.
7250 * w32.h (emacs_gnutls_pull): Add prototype.
7251 (emacs_gnutls_push): Likewise.
7253 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7254 (emacs_gnutls_push): Likewise.
7256 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7258 * process.c (wait_reading_process_output): Check if GnuTLS
7259 buffered some data internally if no FDs are set for TLS
7262 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7263 (LIBS): Link to USER_LIBS.
7264 ($(BLD)/gnutls.$(0)): New target.
7266 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7268 * xdisp.c (handle_single_display_spec): Rename the
7269 display_replaced_before_p argument into display_replaced_p, to
7270 make it consistent with the commentary. Fix typos in the
7273 * textprop.c (syms_of_textprop): Remove dead code.
7274 (copy_text_properties): Delete obsolete commentary about an
7275 interface that was deleted long ago. Fix typos in the description
7278 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7279 to changes in oldXMenu/XMenu.h from 2011-04-16.
7280 <menu_help_message, prev_menu_help_message>: Constify.
7281 (IT_menu_make_room): menu->help_text is now `const char **';
7284 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7285 to changes in oldXMenu/XMenu.h from 2011-04-16.
7286 (struct XMenu): Declare `help_text' `const char **'.
7288 * xfaces.c <Qunspecified>: Make extern again.
7290 * syntax.c: Include sys/types.h before including regex.h, as
7293 * doc.c (get_doc_string): Improve the format passed to `error'.
7295 * doprnt.c (doprnt): Improve commentary.
7297 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7299 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7302 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7303 changes in globals.h immediately force recompilation.
7304 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7305 $(CURDIR)/s/ms-w32.h.
7306 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7308 * character.c (Fchar_direction): Function deleted.
7309 (syms_of_character): Don't defsubr it.
7310 <char-direction-table>: Deleted.
7312 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7314 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7315 * doprnt.c: Include limits.h.
7316 (SIZE_MAX): New macro.
7317 (doprnt): Return a size_t value. 2nd arg is now size_t.
7318 Many local variables are now size_t instead of int or unsigned.
7319 Improve overflow protection. Support `l' modifier for integer
7320 conversions. Support %l conversion. Don't assume an EMACS_INT
7321 argument for integer conversions and for %c.
7323 * lisp.h (doprnt): Restore prototype.
7325 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7328 * Makefile.in (base_obj): Add back doprnt.o.
7330 * deps.mk (doprnt.o): Add back prerequisites.
7331 (callint.o): Depend on character.h.
7333 * eval.c (internal_lisp_condition_case): Include the handler
7334 representation in the error message.
7335 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7336 when breaking from the loop.
7338 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7340 * callint.c (Fcall_interactively): When displaying error message
7341 about invalid control letter, pass the character's codepoint, not
7342 a pointer to its multibyte form. Improve display of the character
7343 in octal and display also its hex code.
7345 * character.c (char_string): Use %x to display the (unsigned)
7346 codepoint of an invalid character, to avoid displaying a bogus
7349 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7350 `error', not SYMBOL_NAME itself.
7352 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7353 character arguments to `error'.
7355 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7356 to `error' in error message about FINAL_CHAR argument. Make sure
7357 FINAL_CHAR is a character, and use %c when it is passed as
7358 argument to `error'.
7360 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7362 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7364 * w32.c: Include <time.h>.
7365 (sys_localtime): New function.
7367 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7369 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7371 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7373 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7375 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7378 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7380 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7381 gl_state.e_property when gl_state.object is Qt.
7383 * insdel.c (make_gap_larger): Remove limitation of buffer size
7386 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7388 * xdisp.c (lookup_glyphless_char_display)
7389 (produce_glyphless_glyph): Handle cons cell entry in
7390 glyphless-char-display.
7391 (Vglyphless_char_display): Document it.
7393 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7394 glyphless-char-display.
7396 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7398 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7400 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7402 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7403 definition for no-X builds.
7405 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7407 Static checks with GCC 4.6.0 and non-default toolkits.
7409 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7411 * process.c (keyboard_bit_set): Define only if SIGIO.
7412 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7413 (send_process): Repair possible setjmp clobbering.
7415 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7417 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7419 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7421 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7422 Define only if needed.
7424 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7425 by pacifying GCC about it. Maybe it's time to retire it?
7426 * xfaces.c (USG, __TIMEVAL__): Likewise.
7428 * dispextern.h (struct redisplay_interface): Rename param
7430 * termhooks.h (struct terminal): Likewise.
7431 * xterm.c (xembed_send_message): Likewise.
7433 * insdel.c (make_gap_smaller): Define only if
7434 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7436 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7439 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7440 so that we aren't warned about unused symbols.
7442 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7444 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7446 * xfns.c (x_real_positions): Mark locals as initialized.
7448 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7450 * xterm.c: Fix problems found by static analysis with other toolkits.
7451 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7452 (x_dispatch_event): Declare static if USE_GTK, and
7453 define if USE_GTK || USE_X_TOOLKIT.
7454 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7455 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7456 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7457 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7459 * xmenu.c (menu_help_callback): Pointer type fixes.
7460 Use const pointers when pointing at readonly data. Avoid pointer
7462 (FALSE): Remove unused macro.
7463 (update_frame_menubar): Remove unused decl.
7465 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7467 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7468 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7469 (single_menu_item): Rename local to avoid shadowing.
7471 * keyboard.c (make_lispy_event): Remove unused local var.
7473 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7474 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7476 * bitmaps: Change bitmaps from unsigned char back to the X11
7477 compatible char. Avoid the old compiler warnings about
7478 out-of-range initializers by using, for example, '\xab' rather
7481 * xgselect.c (xgselect_initialize): Check vs interface
7482 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7484 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7486 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7487 to read-only memory.
7489 * fns.c (vector): Remove; this old hack is no longer needed.
7491 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7493 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7495 * xrdb.c (x_load_resources): Omit unused local.
7497 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7498 (x_window): Rename locals to avoid shadowing.
7499 (USG): Use the kludged USG macro, to pacify gcc.
7501 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7502 (x_term_init): Remove local to avoid shadowing.
7504 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7506 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7507 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7509 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7511 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7513 Fix regex.c, syntax.c and friends for buffers > 2GB.
7514 * syntax.h (struct gl_state_s): Declare character position members
7517 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7519 * textprop.c (verify_interval_modification, interval_of):
7520 Declare arguments EMACS_INT.
7522 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7525 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7527 * indent.c (Fvertical_motion): Local variable it_start is now
7530 * regex.c (re_match, re_match_2, re_match_2_internal)
7531 (bcmp_translate, regcomp, regexec, print_double_string)
7532 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7533 (re_compile_pattern, re_exec): Declare arguments and local
7534 variables `size_t' and `ssize_t' and return values `regoff_t', as
7536 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7537 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7538 <compile_stack_type>: `size' and `avail' are now `size_t'.
7540 * regex.h <regoff_t>: Use ssize_t, not int.
7541 (re_search, re_search_2, re_match, re_match_2): Arguments that
7542 specify buffer/string position and length are now ssize_t and
7543 size_t. Return type is regoff_t.
7545 2011-04-16 Ben Key <bkey76@gmail.com>
7547 * nsfont.m: Fixed bugs in ns_get_family and
7548 ns_descriptor_to_entity that were caused by using free to
7549 deallocate memory blocks that were allocated by xmalloc (via
7550 xstrdup). This caused Emacs to crash when compiled with
7551 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7552 --enable-checking=xmallocoverrun). xfree is now used to
7553 deallocate these memory blocks.
7555 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7557 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7559 emacs_write: Accept and return EMACS_INT for sizes.
7560 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7562 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7563 Accept and return EMACS_INT.
7564 (emacs_gnutls_write): Return the number of bytes written on
7566 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7567 (emacs_read, emacs_write): Remove check for negative size, as the
7568 Emacs source code has been audited now.
7569 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7570 (emacs_read, emacs_write): Use it.
7571 * process.c (send_process): Adjust to the new signatures of
7572 emacs_write and emacs_gnutls_write. Do not attempt to store
7573 a byte offset into an 'int'; it might overflow.
7574 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7576 * sound.c: Don't assume sizes fit in 'int'.
7577 (struct sound_device.period_size, alsa_period_size):
7578 Return EMACS_INT, not int.
7579 (struct sound_device.write, vox_write, alsa_write):
7580 Accept EMACS_INT, not int.
7581 (wav_play, au_play): Use EMACS_INT to store sizes and to
7582 record read return values.
7584 2011-04-15 Ben Key <bkey76@gmail.com>
7586 * keyboard.c (Qundefined): Don't declare static since it is used
7588 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7589 static since they are used in nsfont.m.
7591 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7593 * process.c (Qprocessp): Don't declare static.
7594 * lisp.h (Qprocessp): Declare again.
7596 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7598 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7600 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7602 Improve C-level modularity by making more things 'static'.
7604 Don't publish debugger-only interfaces to other modules.
7605 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7606 (verify_bytepos, count_markers): Move decls to the only modules
7608 * region-cache.h (pp_cache): Likewise.
7609 * window.h (check_all_windows): Likewise.
7610 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7612 * sysdep.c (croak): Now static, if
7613 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7614 * syssignal.h (croak): Declare only if not static.
7616 * alloc.c (refill_memory_reserve): Now static if
7617 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7618 * lisp.h (refill_memory_reserve): Declare only if not static.
7620 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7621 Define only if USE_LUCID.
7623 * xrdb.c (x_customization_string, x_rm_string): Now static.
7625 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7626 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7628 * xdisp.c (draw_row_with_mouse_face): Now static.
7629 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7631 * window.h (check_all_windows): Mark externally visible.
7633 * window.c (window_deletion_count): Now static.
7635 * undo.c: Make symbols static if they're not exported.
7636 (last_undo_buffer, last_boundary_position, pending_boundary):
7639 * textprop.c (interval_insert_behind_hooks): Now static.
7640 (interval_insert_in_front_hooks): Likewise.
7642 * term.c: Make symbols static if they're not exported.
7643 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7644 (max_frame_lines, tty_set_terminal_modes):
7645 (tty_reset_terminal_modes, tty_turn_off_highlight):
7646 (get_tty_terminal): Now static.
7647 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7648 * termhooks.h (term_mouse_moveto): Do not declare if
7650 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7651 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7653 * sysdep.c: Make symbols static if they're not exported.
7654 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7656 (sigprocmask_set, full_mask): Remove; unused.
7657 (wait_debugging): Mark as visible.
7658 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7659 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7661 * syntax.c (syntax_temp): Define only if !__GNUC__.
7663 * sound.c (current_sound_device, current_sound): Now static.
7665 * search.c (searchbufs, searchbuf_head): Now static.
7667 * scroll.c (scroll_cost): Remove; unused.
7668 * dispextern.h (scroll_cost): Remove decl.
7670 * region-cache.h (pp_cache): Mark as externally visible.
7672 * process.c: Make symbols static if they're not exported.
7673 (process_tick, update_tick, create_process, chan_process):
7674 (Vprocess_alist, proc_buffered_char, datagram_access):
7675 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7676 (deactivate_process): Mark defn as static, as well as decl.
7677 * lisp.h (create_process): Remove decl.
7678 * process.h (chan_process, Vprocess_alist): Remove decls.
7680 * print.c: Make symbols static if they're not exported.
7681 (print_depth, new_backquote_output, being_printed, print_buffer):
7682 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7683 (print_interval, print_number_index, initial_stderr_stream):
7685 * lisp.h (Fprinc): Remove decl.
7686 (debug_output_compilation_hack): Mark as externally visible.
7688 * sysdep.c (croak): Move decl from here to syssignal.h.
7689 * syssignal.h (croak): Put it here, so the API can be checked when
7690 'croak' is called from dissociate_if_controlling_tty.
7692 * minibuf.c: Make symbols static if they're not exported.
7693 (minibuf_save_list, choose_minibuf_frame): Now static.
7694 * lisp.h (choose_minibuf_frame): Remove decl.
7696 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7698 * lread.c: Make symbols static if they're not exported.
7699 (read_objects, initial_obarray, oblookup_last_bucket_number):
7701 (make_symbol): Remove; unused.
7702 * lisp.h (initial_obarray, make_symbol): Remove decls.
7704 * keyboard.c: Make symbols static if they're not exported.
7705 (single_kboard, recent_keys_index, total_keys, recent_keys):
7706 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7707 (this_single_command_key_start, echoing, last_auto_save):
7708 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7709 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7710 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7711 (Vlispy_mouse_stem, double_click_count):
7713 (force_auto_save_soon): Define only if SIGDANGER.
7714 (ignore_mouse_drag_p): Now static if
7715 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7716 (print_help): Remove; unused.
7717 (stop_character, last_timer_event): Mark as externally visible.
7718 * keyboard.h (ignore_mouse_drag_p): Declare only if
7719 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7720 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7721 * lisp.h (echoing): Remove decl.
7722 (force_auto_save_soon): Declare only if SIGDANGER.
7723 * xdisp.c (redisplay_window): Simplify code, to make it more
7724 obvious that ignore_mouse_drag_p is not accessed if !defined
7725 USE_GTK && !defined HAVE_NS.
7727 * intervals.c: Make symbols static if they're not exported.
7728 (merge_properties_sticky, merge_interval_right, delete_interval):
7730 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7732 * insdel.c: Make symbols static if they're not exported.
7733 However, leave prepare_to_modify_buffer alone. It's never
7734 called from outside this function, but that appears to be a bug.
7735 (combine_after_change_list, combine_after_change_buffer):
7736 (adjust_after_replace, signal_before_change): Now static.
7737 (adjust_after_replace_noundo): Remove; unused.
7738 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7739 (signal_before_change): Remove decls.
7741 * indent.c (val_compute_motion, val_vmotion): Now static.
7743 * image.c: Make symbols static if they're not exported.
7744 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7746 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7747 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7749 * fringe.c (standard_bitmaps): Now static.
7750 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7752 * frame.c: Make symbols static if they're not exported.
7753 (x_report_frame_params, make_terminal_frame): Now static.
7754 (get_frame_param): Now static, unless HAVE_NS.
7755 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7756 (x_get_resource_string): Remove; not used.
7757 * frame.h (make_terminal_frame, x_report_frame_params):
7758 (x_get_resource_string); Remove decls.
7759 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7760 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7762 * font.c, fontset.c: Make symbols static if they're not exported.
7763 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7764 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7765 * font.c (font_close_object): Now static.
7766 * font.h (font_close_object): Remove.
7767 * fontset.c (FONTSET_OBJLIST): Remove.
7768 (free_realized_fontset) #if-0 the body, which does nothing.
7769 (face_suitable_for_char_p): #if-0, as it's never called.
7770 * fontset.h (face_suitable_for_char_p): Remove decl.
7771 * xfaces.c (face_at_string_position):
7772 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7773 since 0 is always ASCII.
7775 * fns.c (weak_hash_tables): Now static.
7777 * fileio.c: Make symbols static if they're not exported.
7778 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7779 (Vwrite_region_annotation_buffers): Now static.
7781 * eval.c: Make symbols static if they're not exported.
7782 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7783 * lisp.h (backtrace_list): Remove decl.
7785 * emacs.c: Make symbols static if they're not exported.
7786 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7787 (fatal_error_code, fatal_error_signal_hook, standard_args):
7789 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7790 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7791 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7792 * lisp.h (fatal_error_signal_hook): Remove decl.
7793 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7795 * editfns.c: Move a (normally-unused) function to its only use.
7796 * editfns.c, lisp.h (get_operating_system_release): Remove.
7797 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7798 worth the hassle of breaking this out.
7800 * xterm.c: Make symbols static if they're not exported.
7801 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7802 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7803 (x_destroy_window, x_delete_display):
7805 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7806 (x_mouse_leave): Remove; unused.
7807 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7808 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7809 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7811 (x_mouse_leave): Declare only if WINDOWSNT.
7812 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7813 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7816 * ftxfont.c: Make symbols static if they're not exported.
7817 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7819 * font.h (ftxfont_driver): Likewise.
7821 * xfns.c: Make symbols static if they're not exported.
7822 (x_last_font_name, x_display_info_for_name):
7823 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7824 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7825 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7826 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7827 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7828 (last_show_tip_args): Now static.
7829 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7830 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7831 (x_screen_planes): Remove; unused.
7832 * dispextern.h (x_screen_planes): Remove decl.
7834 * dispnew.c: Make symbols static if they're not exported.
7835 * dispextern.h (redraw_garbaged_frames, scrolling):
7836 (increment_row_positions): Remove.
7837 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7838 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7840 (redraw_garbaged_frames): Remove; unused.
7842 * xfaces.c: Make symbols static if they're not exported.
7843 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7845 * xterm.h (defined_color): Remove decls.
7846 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7847 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7848 (menu_face_changed_default, defined_color, free_realized_face):
7849 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7850 (ascii_face_of_lisp_face): Remove; unused.
7852 * xdisp.c: Make symbols static if they're not exported.
7853 * dispextern.h (scratch_glyph_row, window_box_edges):
7854 (glyph_to_pixel_coords, set_cursor_from_row):
7855 (get_next_display_element, set_iterator_to_next):
7856 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7857 (show_mouse_face): Remove decls
7858 * frame.h (message_buf_print): Likewise.
7859 * lisp.h (pop_message, set_message, check_point_in_composition):
7861 * xterm.h (set_vertical_scroll_bar): Likewise.
7862 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7863 (message_buf_print, scratch_glyph_row, displayed_buffer):
7864 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7865 (get_next_display_element, show_mouse_face, window_box_edges):
7866 (frame_to_window_pixel_xy, check_point_in_composition):
7867 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7868 (glyph_to_pixel_coords): Remove; unused.
7870 * dired.c (file_name_completion): Now static.
7872 * dbusbind.c (xd_in_read_queued_messages): Now static.
7874 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7875 * data.c (circular_list_error): Remove.
7877 * commands.h (last_point_position, last_point_position_buffer):
7878 (last_point_position_window): Remove decls.
7879 * keyboard.c: Make these variables static.
7881 * coding.h (coding, code_convert_region, encode_coding_gap):
7883 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7884 (iso_code_class, detect_coding, code_convert_region): Now static.
7885 (encode_coding_gap): Remove; unused.
7887 * chartab.c (chartab_chars, chartab_bits): Now static.
7889 * charset.h (charset_iso_8859_1): Remove decl.
7890 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7893 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7894 * ccl.c (Vccl_program_table): Now static.
7895 (check_ccl_update): Remove; unused.
7897 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7898 * category.h: ... from here.
7899 * category.c (check_category_table, set_category_set): Now static.
7901 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7902 * lisp.h: Remove these decls.
7904 * buffer.c (buffer_count): Remove unused var.
7906 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7907 so that it's not optimized away.
7908 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7909 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7910 exported only to the debugger.
7912 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7913 * atimer.h (run_all_atimers): Remove; not exported.
7915 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7916 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7917 was inaccessible from Lisp.
7918 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7919 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7921 alloc.c: Import and export fewer symbols, and remove unused items.
7922 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7924 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7925 it's not optimized away by whole-program optimization.
7926 (message_enable_multibyte, free_misc): Remove.
7927 (catchlist, handlerlist, mark_backtrace):
7928 Declare only if BYTE_MARK_STACK.
7929 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7930 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7931 (message_enable_multibyte): Remove decl.
7932 (free_misc, interval_free_list, float_block, float_block_index):
7933 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7934 (cons_free_list, last_marked_index):
7936 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7937 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7938 (mark_backtrace): Define only if BYTE_MARK_STACK.
7939 * xdisp.c (message_enable_multibyte): Now static.
7941 Declare Lisp_Object Q* variables to be 'static' if not exported.
7942 This makes it easier for human readers (and static analyzers)
7943 to see whether these variables are used from other modules.
7944 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7945 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7946 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7947 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7948 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7949 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7950 * xmenu.c, xselect.c:
7951 Declare Q* vars static if they are not used in other modules.
7952 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7953 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7954 Remove decls of unexported vars.
7955 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7957 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7959 Make Emacs functions such as Fatom 'static' by default.
7960 This makes it easier for human readers (and static analyzers)
7961 to see whether these functions can be called from other modules.
7962 DEFUN now defines a static function. To make the function external
7963 so that it can be used in other C modules, use the new macro DEFUE.
7964 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7965 (Finit_image_library):
7966 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7967 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7968 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7969 Remove decls, since these functions are now static.
7970 (Funintern, Fget_internal_run_time): New decls, since these functions
7971 were already external.
7973 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7974 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7975 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7976 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7977 * keyboard.c, keymap.c, lread.c:
7978 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7979 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7980 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7981 Mark functions with DEFUE instead of DEFUN,
7982 if they are used in other modules.
7983 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7984 decls for now-static functions.
7985 * buffer.h (Fdelete_overlay): Remove decl.
7986 * callproc.c (Fgetenv_internal): Mark as internal.
7987 * composite.c (Fremove_list_of_text_properties): Remove decl.
7988 (Fcomposition_get_gstring): New forward static decl.
7989 * composite.h (Fcomposite_get_gstring): Remove decl.
7990 * dired.c (Ffile_attributes): New forward static decl.
7991 * doc.c (Fdocumntation_property): New forward static decl.
7992 * eval.c (Ffetch_bytecode): New forward static decl.
7993 (Funintern): Remove extern decl; now in .h file where it belongs.
7994 * fileio.c (Fmake_symbolic_link): New forward static decl.
7995 * image.c (Finit_image_library): New forward static decl.
7996 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7997 * intervals.h (Fprevious_property_change):
7998 (Fremove_list_of_text_properties): Remove decls.
7999 * keyboard.c (Fthis_command_keys): Remove decl.
8000 (Fcommand_execute): New forward static decl.
8001 * keymap.c (Flookup_key): New forward static decl.
8002 (Fcopy_keymap): Now static.
8003 * keymap.h (Flookup_key): Remove decl.
8004 * process.c (Fget_process): New forward static decl.
8005 (Fprocess_datagram_address): Mark as internal.
8006 * syntax.c (Fsyntax_table_p): New forward static decl.
8007 (skip_chars): Remove duplicate decl.
8008 * textprop.c (Fprevious_property_change): New forward static decl.
8009 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8011 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8012 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8014 * editfns.c (Fformat): Remove unreachable code.
8016 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8018 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8021 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8023 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8024 when at ZV. (Bug#8487)
8026 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8028 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8030 * keyboard.c (parse_tool_bar_item): Likewise.
8031 * sound.c (sound_cleanup, alsa_close): Likewise.
8032 * termcap.c (tgetent): Likewise.
8033 * xfns.c (x_default_font_parameter): Likewise.
8034 * xsettings.c (read_and_apply_settings): Likewise.
8036 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8037 (overrun_check_free): Protoize.
8039 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8041 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8042 since callers should never pass a negative size.
8043 Change the signature to match that of plain 'read' and 'write'; see
8044 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8045 * lisp.h: Update prototypes of emacs_write and emacs_read.
8047 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8049 * xdisp.c (redisplay_window): Don't try to determine the character
8050 position of the scroll margin if the window start point w->startp
8051 is outside the buffer's accessible region. (Bug#8468)
8053 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8055 Fix write-region and its subroutines for buffers > 2GB.
8056 * fileio.c (a_write, e_write): Modify declaration of arguments and
8057 local variables to support buffers larger than 2GB.
8058 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8060 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8061 argument, local variables, and return value.
8063 * lisp.h: Update prototypes of emacs_write and emacs_read.
8065 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8067 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8069 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8071 Fix more problems found by GCC 4.6.0's static checks.
8073 * xdisp.c (vmessage): Use a better test for character truncation.
8075 * charset.c (load_charset_map): <, not <=, for optimization,
8076 and to avoid potential problems with integer overflow.
8077 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8078 * casetab.c (set_identity, shuffle): Likewise.
8079 * editfns.c (Fformat): Likewise.
8080 * syntax.c (skip_chars): Likewise.
8082 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8083 This also lets GCC 4.6.0 generate slightly better loop code.
8085 * callint.c (Fcall_interactively): <, not <=, for optimization.
8086 (Fcall_interactively): Count the number of arguments produced,
8087 not the number of arguments given. This is simpler and lets GCC
8088 4.6.0 generate slightly better code.
8090 * ftfont.c: Distingish more carefully between FcChar8 and char.
8091 The previous code passed unsigned char * to a functions like
8092 strlen and xstrcasecmp that expect char *, which does not
8093 conform to the C standard.
8094 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8095 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8096 char * when the C standard requires it.
8098 * keyboard.c (read_char): Remove unused var.
8100 * eval.c: Port to Windows vsnprintf (Bug#8435).
8102 (SIZE_MAX): Define if the headers do not.
8103 (verror): Do not give up if vsnprintf returns a negative count.
8104 Instead, grow the buffer. This ports to Windows vsnprintf, which
8105 does not conform to C99. Problem reported by Eli Zaretskii.
8106 Also, simplify the allocation scheme, by avoiding the need for
8107 calling realloc, and removing the ALLOCATED variable.
8109 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8111 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8112 But keep the doprint source code for now, as we might revamp it
8113 and use it again (Bug#8435).
8114 * lisp.h (doprnt): Remove.
8115 * Makefile.in (base_obj): Remove doprnt.o.
8116 * deps.mk (doprnt.o): Remove.
8118 error: Print 32- and 64-bit integers portably (Bug#8435).
8119 Without this change, on typical 64-bit hosts error ("...%d...", N)
8120 was used to print both 32- and 64-bit integers N, which relied on
8122 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8123 * lisp.h (error, verror): Mark as printf-like functions.
8124 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8125 Report overflow in size calculations when allocating printf buffer.
8126 Do not truncate output string at its first null byte.
8127 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8128 Truncate the output at a character boundary, since vsnprintf does not
8130 * charset.c (check_iso_charset_parameter): Convert internal
8131 character to string before calling 'error', since %c now has the
8133 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8134 overflow when computing char to be passed to 'error'. Do not
8135 pass Lisp_Object to 'error'; pass the integer instead.
8136 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8137 formatted with plain %d.
8139 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8141 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8143 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8145 * xterm.c (x_catch_errors): Remove duplicate declaration.
8147 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8149 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8151 2011-04-10 Jim Meyering <meyering@redhat.com>
8153 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8154 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8155 return ssize_t not "int", and use size_t as the buffer length.
8156 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8157 * gnutls.h: Update declarations.
8158 * process.c (read_process_output): Use ssize_t, to match.
8159 (send_process): Likewise.
8161 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8163 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8165 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8167 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8168 Use unsigned char, to match FcChar8 type definition.
8170 * xterm.c (handle_one_xevent):
8171 * xmenu.c (create_and_show_popup_menu):
8172 * xselect.c (x_decline_selection_request)
8173 (x_reply_selection_request): Avoid type-punned deref of X events.
8175 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8177 Fix some uses of `int' instead of EMACS_INT.
8178 * search.c (string_match_1, fast_string_match)
8179 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8180 (scan_buffer, find_next_newline_no_quit)
8181 (find_before_next_newline, search_command, Freplace_match)
8182 (Fmatch_data): Make some `int' variables be EMACS_INT.
8184 * xdisp.c (display_count_lines): 3rd argument and return value now
8185 EMACS_INT. All callers changed.
8186 (pint2hrstr): Last argument is now EMACS_INT.
8188 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8189 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8190 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8191 (decode_coding_utf_16, decode_coding_emacs_mule)
8192 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8193 (decode_coding_ccl, decode_coding_charset)
8194 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8195 (decode_coding_iso_2022, decode_coding_emacs_mule)
8196 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8197 <char_offset, last_offset>: Declare EMACS_INT.
8198 (encode_coding_utf_8, encode_coding_utf_16)
8199 (encode_coding_emacs_mule, encode_invocation_designation)
8200 (encode_designation_at_bol, encode_coding_iso_2022)
8201 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8202 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8204 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8205 (encode_invocation_designation): Last argument P_NCHARS is now
8207 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8208 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8210 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8213 * ccl.c (Fccl_execute_on_string): Declare some variables
8216 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8218 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8220 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8222 * process.c (Fformat_network_address): Doc fix.
8224 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8226 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8228 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8230 * keyboard.c (read_char): Call Lisp function help-form-show,
8231 instead of using internal_with_output_to_temp_buffer.
8232 (Qhelp_form_show): New var.
8233 (syms_of_keyboard): Use DEFSYM macro.
8235 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8237 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8239 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8241 * process.c (Flist_processes): Remove to Lisp.
8242 (list_processes_1): Delete.
8244 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8246 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8248 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8250 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8252 Fix more problems found by GCC 4.6.0's static checks.
8254 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8256 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8258 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8260 * xdisp.c (vmessage): Mark as a printf-like function.
8262 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8264 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8266 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8267 printf-like functions.
8268 (tiff_load): Add casts to remove these marks before passing them
8269 to system-supplied API.
8271 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8273 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8274 This avoids several warnings with gcc -Wstrict-overflow.
8275 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8276 directly, rather than having caller test rule sign. This avoids
8277 some unnecessary tests.
8278 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8279 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8280 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8282 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8283 (xfont_open): Avoid unnecessary tests.
8285 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8287 * composite.h, composite.c (composition_gstring_put_cache):
8288 Use EMACS_INT, not int, for length.
8290 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8291 breaking out part of COMPOSITION_DECODE_RULE.
8292 (COMPOSITION_DECODE_RULE): Use it.
8293 * composite.c (get_composition_id): Remove unused local vars,
8294 by using the new macro.
8296 * textprop.c (set_text_properties_1): Change while to do-while,
8297 since the condition is always true at first.
8299 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8300 (interval_deletion_adjustment): Return unsigned value.
8303 * process.c (list_processes_1, create_pty, read_process_output):
8304 (exec_sentinel): Remove vars that were set but not used.
8305 (create_pty): Remove unnecessary "volatile"s.
8306 (Fnetwork_interface_info): Avoid possibility of int overflow.
8307 (read_process_output): Do adaptive read buffering even if carryover.
8308 (read_process_output): Simplify nbytes computation if buffered.
8310 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8312 * syntax.c (scan_words): Remove var that was set but not used.
8313 (update_syntax_table): Use unsigned instead of int.
8315 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8316 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8317 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8319 * print.c (print_error_message): Avoid int overflow.
8321 * font.c (font_list_entities): Redo for clarity,
8322 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8324 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8325 (font_score): Avoid potential overflow in diff calculation.
8327 * fns.c (substring_both): Remove var that is set but not used.
8328 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8330 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8332 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8333 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8334 can always succeed if overflow has undefined behavior.
8336 * search.c (boyer_moore, wordify): Remove vars set but not used.
8337 (wordify): Omit three unnecessary tests.
8339 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8340 All callers changed. This avoids the need for an unused var.
8342 * casefiddle.c (casify_region): Remove var that is set but not used.
8344 * dired.c (file_name_completion): Remove var that is set but not used.
8346 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8348 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8349 (Finsert_file_contents): Remove unnecessary code checking fd.
8351 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8352 Check for integer overflow on size calculations.
8354 * buffer.c (Fprevious_overlay_change): Remove var that is set
8357 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8358 Remove vars that are set but not used.
8359 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8360 (timer_check_2): Mark vars as initialized.
8362 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8364 * image.c (lookup_image): Remove var that is set but not used.
8365 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8367 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8368 that are set but not used.
8370 * xfns.c (make_invisible_cursor): Don't return garbage
8371 if XCreateBitmapFromData fails (Bug#8410).
8373 * xselect.c (x_get_local_selection, x_handle_property_notify):
8374 Remove vars that are set but not used.
8376 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8377 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8379 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8380 Remove var that is set but not used.
8381 (scroll_bar_windows_size): Now size_t, not int.
8382 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8385 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8386 (map_tty_color) [!defined MSDOS]: Likewise.
8388 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8390 * coding.c: Remove vars that are set but not used.
8391 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8392 All callers changed.
8393 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8394 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8395 (decode_coding_charset): Remove vars that are set but not used.
8397 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8398 that is set but not used.
8400 * print.c (print_object): Remove var that is set but not used.
8402 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8403 The gnulib version avoids calling malloc in the usual case,
8404 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8405 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8406 * filelock.c (current_lock_owner): Likewise.
8407 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8408 * sysdep.c: Include allocator.h, careadlinkat.h.
8409 (emacs_no_realloc_allocator): New static constant.
8410 (emacs_readlink): New function.
8411 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8412 ../lib/careadlinkat.h.
8414 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8416 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8417 first non-nil return value).
8419 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8421 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8422 if not defined (Bug#8403).
8424 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8426 * xdisp.c (display_count_lines): Remove parameter `start',
8427 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8428 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8429 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8430 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8431 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8432 and thereabouts. All callers changed.
8433 (get_per_char_metric): Remove parameter `f', unused since
8434 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8436 2011-04-02 Jim Meyering <meyering@redhat.com>
8438 do not dereference NULL upon failed strdup
8439 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8440 (ns_get_family): Likewise.
8442 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8444 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8446 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8448 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8451 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8453 Add lexical binding.
8455 * window.c (Ftemp_output_buffer_show): New fun.
8456 (Fsave_window_excursion):
8457 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8459 * lread.c (lisp_file_lexically_bound_p): New function.
8460 (Fload): Bind Qlexical_binding.
8461 (readevalloop): Remove `evalfun' arg.
8462 Bind Qinternal_interpreter_environment.
8463 (Feval_buffer): Bind Qlexical_binding.
8464 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8466 (syms_of_lread): Declare `lexical-binding'.
8468 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8470 * keyboard.c (eval_dyn): New fun.
8471 (menu_item_eval_property): Use it.
8473 * image.c (parse_image_spec): Use Ffunctionp.
8475 * fns.c (concat, mapcar1): Accept byte-code-functions.
8477 * eval.c (Fsetq): Handle lexical vars.
8478 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8479 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8480 (FletX, Flet): Obey lexical binding.
8481 (Fcommandp): Handle closures.
8482 (Feval): New `lexical' arg.
8483 (eval_sub): New function extracted from Feval. Use it almost
8484 everywhere where Feval was used. Look up vars in lexical env.
8486 (Ffunctionp): Move from subr.el.
8487 (Ffuncall): Handle closures.
8488 (apply_lambda): Remove `eval_flags'.
8489 (funcall_lambda): Handle closures and new byte-code-functions.
8490 (Fspecial_variable_p): New function.
8491 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8492 but without exporting it to Lisp.
8494 * doc.c (Fdocumentation, store_function_docstring):
8495 * data.c (Finteractive_form): Handle closures.
8497 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8500 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8502 (exec_byte_code): New function extracted from Fbyte_code to handle new
8503 calling convention for byte-code-functions. Add new byte-codes.
8505 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8507 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8509 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8511 * xdisp.c (redisplay_internal): Fix prototype.
8513 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8515 * xdisp.c (SCROLL_LIMIT): New macro.
8516 (try_scrolling): Use it when setting scroll_limit.
8517 Limit scrolling to 100 screen lines.
8518 (redisplay_window): Even when falling back on "recentering",
8519 position point in the window according to scroll-conservatively,
8520 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8522 (try_scrolling): When point is above the window, allow searching
8523 as far as scroll_max, or one screenful, to compute vertical
8524 distance from PT to the scroll margin position. This prevents
8525 try_scrolling from unnecessarily failing when
8526 scroll-conservatively is set to a value slightly larger than the
8527 window height. Clean up the case of PT below the margin at bottom
8528 of window: scroll_max can no longer be INT_MAX. When aggressive
8529 scrolling is in use, don't let point enter the opposite scroll
8530 margin as result of the scroll.
8531 (syms_of_xdisp) <scroll-conservatively>: Document the
8532 threshold of 100 lines for never-recentering scrolling.
8534 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8536 * dispextern.h (move_it_by_lines):
8537 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8538 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8539 (message_log_check_duplicate): Remove parameters `prev_bol' and
8540 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8541 (redisplay_internal): Remove parameter `preserve_echo_area',
8542 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8544 * indent.c (Fvertical_motion):
8545 * window.c (window_scroll_pixel_based, Frecenter):
8546 Don't pass `need_y_p' to `move_it_by_lines'.
8548 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8550 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8551 steal a few bits to be more compact.
8552 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8553 Remove unneeded casts.
8555 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8557 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8559 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8560 binding" message (bug#7967).
8562 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8564 Fix more problems found by GCC 4.6.0's static checks.
8566 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8567 Remove unused local var.
8569 * editfns.c (Fmessage_box): Remove unused local var.
8571 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8572 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8573 Omit unused local vars.
8574 * window.c (shrink_windows): Omit unused local var.
8575 * menu.c (digest_single_submenu): Omit unused local var.
8576 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8577 Omit unused local var.
8579 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8580 Don't assume string length fits in int.
8581 (keyremap_step, read_key_sequence): Use size_t for sizes.
8582 (read_key_sequence): Don't check last_real_key_start redundantly.
8584 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8585 instead of alloca (Bug#8344).
8587 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8588 (Fbacktrace_frame): Don't assume nframes fits in int.
8590 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8592 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8595 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8597 * cm.c (calccost): Turn while-do into do-while, for clarity.
8599 * keyboard.c (syms_of_keyboard): Use the same style as later
8600 in this function when indexing through an array. This also
8601 works around GCC bug 48267.
8603 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8605 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8607 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8608 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8610 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8611 This avoids undefined behavior on integer overflow, and is a bit
8612 more convenient anyway since it is compared to a size_t variable.
8614 Variadic C functions now count arguments with size_t, not int.
8615 This avoids an unnecessary limitation on 64-bit machines, which
8616 caused (substring ...) to crash on large vectors (Bug#8344).
8617 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8618 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8619 All variadic functions and their callers changed accordingly.
8620 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8621 * data.c (arith_driver, float_arith_driver): Likewise.
8622 * editfns.c (general_insert_function): Likewise.
8623 * eval.c (struct backtrace.nargs, interactive_p)
8624 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8625 (funcall_lambda, mark_backtrace): Likewise.
8626 * fns.c (concat): Likewise.
8627 * frame.c (x_set_frame_parameters): Likewise.
8628 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8629 0 if not found, not -1. All callers changed.
8631 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8632 (stack_copy_size): Now size_t, not int.
8633 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8635 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8637 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8638 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8639 All callers changed.
8641 * lisp.h (multibyte_char_to_unibyte):
8642 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8643 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8644 * character.h (CHAR_TO_BYTE8):
8645 * cmds.c (internal_self_insert):
8646 * editfns.c (general_insert_function):
8647 * keymap.c (push_key_description):
8648 * search.c (Freplace_match):
8649 * xdisp.c (message_dolog, set_message_1): All callers changed.
8651 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8653 * keyboard.c (safe_run_hook_funcall): New function.
8654 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8655 don't set the hook to nil, but remove the offending function instead.
8656 (Qcommand_hook_internal): Remove, unused.
8657 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8658 Vcommand_hook_internal.
8660 * eval.c (enum run_hooks_condition): Remove.
8661 (funcall_nil, funcall_not): New functions.
8662 (run_hook_with_args): Call each function through a `funcall' argument.
8663 Remove `cond' argument, now redundant.
8664 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8665 (Frun_hook_with_args_until_failure): Adjust accordingly.
8666 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8668 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8670 * dispextern.h (string_buffer_position): Remove declaration.
8672 * print.c (strout): Remove parameter `multibyte', unused since
8673 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8675 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8676 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8677 All callers changed.
8679 * w32.c (_wsa_errlist): Use braces for struct initializers.
8681 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8682 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8683 All callers changed.
8684 (string_buffer_position): Likewise. Also, make static (it's never
8685 used outside xdisp.c).
8686 (cursor_row_p): Remove parameter `w', unused since
8687 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8688 (decode_mode_spec): Remove parameter `precision', introduced during
8689 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8690 All callers changed.
8692 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8694 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8696 2011-03-27 Anders Lindgren <andlind@gmail.com>
8698 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8699 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8700 (ns_update_auto_hide_menu_bar): New functions.
8701 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8702 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8703 ns_constrain_all_frames.
8704 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8705 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8707 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8709 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8711 2011-03-27 Glenn Morris <rgm@gnu.org>
8713 * syssignal.h: Replace RETSIGTYPE with void.
8714 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8715 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8716 Replace SIGTYPE with void everywhere.
8717 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8718 * s/template.h (SIGTYPE): Remove commented out definition.
8720 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8722 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8723 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8725 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8727 * w32.c (read_unc_volume): Use parameter `henum', instead of
8728 global variable `wget_enum_handle'.
8730 * keymap.c (describe_vector): Remove parameters `indices' and
8731 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8732 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8734 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8736 * keyboard.c (timer_check): Remove parameter `do_it_now',
8737 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8738 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8739 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8741 * keyboard.c (read_char):
8742 * w32menu.c (w32_menu_display_help):
8743 * xmenu.c (show_help_event, menu_help_callback):
8744 Adjust calls to `show_help_echo'.
8746 * gtkutil.c (xg_maybe_add_timer):
8747 * keyboard.c (readable_events):
8748 * process.c (wait_reading_process_output):
8749 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8751 * insdel.c (adjust_markers_gap_motion):
8752 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8753 (gap_left, gap_right): Don't call it.
8755 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8757 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8758 incurred during fontification.
8760 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8762 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8763 (DEFVAR_PER_BUFFER): Don't pass it.
8765 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8766 (scrolling_window): Don't pass it.
8768 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8770 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8772 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8774 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8775 of variables specific to SELinux and computation of `encoded_absname'.
8777 * image.c (XPutPixel): Remove unused variable `height'.
8779 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8781 * unexw32.c (get_section_info): Remove unused variable `section'.
8783 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8784 (system_process_attributes): Remove unused variable `sess'.
8785 (sys_read): Remove unused variable `err'.
8787 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8788 (w32_wnd_proc): Remove unused variable `isdead'.
8789 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8790 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8791 (x_create_tip_frame): Remove unused variable `tem'.
8793 * w32inevt.c (w32_console_read_socket):
8794 Remove unused variable `no_events'.
8796 * w32term.c (x_draw_composite_glyph_string_foreground):
8797 Remove unused variable `width'.
8799 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8801 * w32term.c (x_set_glyph_string_clipping):
8802 Don't pass uninitialized region to CombineRgn.
8804 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8806 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8807 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8808 (Fx_close_connection): Remove unused variable `i'.
8810 * w32font.c (w32font_draw): Return number of glyphs.
8811 (w32font_open_internal): Remove unused variable `i'.
8812 (w32font_driver): Add missing initializer.
8814 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8815 (fill_in_menu): Remove unused variable `items_added'.
8817 * w32term.c (last_mouse_press_frame): Remove static global variable.
8818 (w32_clip_to_row): Remove unused variable `f'.
8819 (x_delete_terminal): Remove unused variable `i'.
8821 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8822 (NOTHING): Remove unused static global variable.
8823 (uniscribe_check_otf): Remove unused variable `table'.
8824 (uniscribe_font_driver): Add missing initializers.
8826 2011-03-23 Julien Danjou <julien@danjou.info>
8828 * term.c (Fsuspend_tty, Fresume_tty):
8829 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8830 * window.c (temp_output_buffer_show):
8831 * insdel.c (signal_before_change):
8832 * frame.c (Fhandle_switch_frame):
8833 * fileio.c (Fdo_auto_save):
8834 * emacs.c (Fkill_emacs):
8835 * editfns.c (save_excursion_restore):
8836 * cmds.c (internal_self_insert):
8837 * callint.c (Fcall_interactively):
8838 * buffer.c (Fkill_all_local_variables):
8839 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8841 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8842 unconditionally since it does the check itself.
8844 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8846 Fix more problems found by GCC 4.5.2's static checks.
8848 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8849 the first time through the loop, since we know p0 < p1 then.
8850 This also avoids a gcc -Wstrict-overflow warning.
8852 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8853 leading to a memory leak, possible in functions like
8854 load_charset_map_from_file that can allocate an unbounded number
8855 of objects (Bug#8318).
8857 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8858 that could (at least in theory) be that large.
8860 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8861 This is less likely to overflow, and avoids undefined behavior if
8862 overflow does occur. All callers changed. Use strtoul to scan
8863 for the unsigned long integer.
8864 (pint2hrstr): Simplify and tune code slightly.
8865 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8867 * scroll.c (do_scrolling): Work around GCC bug 48228.
8868 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8870 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8871 This also avoids a warning with gcc -Wstrict-overflow.
8872 (validate_x_resource_name): Simplify count usage.
8873 This also avoids a warning with gcc -Wstrict-overflow.
8875 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8878 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8880 * process.c (Fmake_network_process): Use socklen_t, not int,
8881 where POSIX says socklen_t is required in portable programs.
8882 This fixes a porting bug on hosts like 64-bit HP-UX, where
8883 socklen_t is wider than int (Bug#8277).
8884 (Fmake_network_process, server_accept_connection):
8885 (wait_reading_process_output, read_process_output):
8888 * process.c: Rename or move locals to avoid shadowing.
8889 (list_processes_1, Fmake_network_process):
8890 (read_process_output_error_handler, exec_sentinel_error_handler):
8891 Rename or move locals.
8892 (Fmake_network_process): Define label "retry_connect" only if needed.
8893 (Fnetwork_interface_info): Fix pointer signedness.
8894 (process_send_signal): Add cast to avoid pointer signedness problem.
8895 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8896 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8898 Make tparam.h and terminfo.c consistent.
8899 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8900 Include tparam.h instead, since it declares them.
8901 * cm.h (PC): Remove extern decl; tparam.h now does this.
8902 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8903 * terminfo.c: Include tparam.h, to check interfaces.
8904 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8905 (tparam): Adjust signature to match interface in tparam.h;
8906 this removes some undefined behavior. Check that outstring and len
8907 are zero, which they always are with Emacs.
8908 * tparam.h (PC, BC, UP): New extern decls.
8910 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8911 (xftfont_open): Rename locals to avoid shadowing.
8913 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8914 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8915 (OTF_TAG_SYM): Omit macro if not needed.
8916 (ftfont_list): Remove unused local.
8917 (get_adstyle_property, ftfont_pattern_entity):
8918 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8919 Rename locals to avoid shadowing.
8921 * xfont.c (xfont_list_family): Mark var as initialized.
8923 * xml.c (make_dom): Now static.
8925 * composite.c (composition_compute_stop_pos): Rename local to
8927 (composition_reseat_it): Remove unused locals.
8928 (find_automatic_composition, composition_adjust_point): Likewise.
8929 (composition_update_it): Mark var as initialized.
8930 (find_automatic_composition): Mark vars as initialized,
8931 with a FIXME (Bug#8290).
8933 character.h: Rename locals to avoid shadowing.
8934 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8935 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8936 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8937 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8940 * textprop.c (property_change_between_p): Remove; unused.
8942 * intervals.c (interval_start_pos): Now static.
8944 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8946 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8947 Rename locals to avoid shadowing.
8949 * sound.c (wav_play, au_play, Fplay_sound_internal):
8950 Fix pointer signedness.
8951 (alsa_choose_format): Remove unused local var.
8952 (wav_play): Initialize a variable to 0, to prevent undefined
8953 behavior (Bug#8278).
8955 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8957 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8959 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8960 clobbering (Bug#8298).
8961 * sysdep.c (sys_subshell): Likewise.
8962 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8964 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8965 This should get cleaned up, so that child_setup has the
8966 same signature on all platforms.
8968 * callproc.c (call_process_cleanup): Now static.
8969 (relocate_fd): Rename locals to avoid shadowing.
8971 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8973 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8974 not to be necessary, and produces flickering.
8976 2011-03-20 Glenn Morris <rgm@gnu.org>
8978 * config.in: Remove file.
8980 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8982 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8983 are now in src/globals.h.
8984 (syms_of_minibuf): Remove spurious & from previous change.
8986 2011-03-20 Leo Liu <sdl.web@gmail.com>
8988 * minibuf.c (completing-read-function): New variable.
8989 (completing-read-default): Rename from completing-read.
8990 (completing-read): Call completing-read-function.
8992 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8994 * xfaces.c (Fx_load_color_file):
8995 Read color file from absolute filename (bug#8250).
8997 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8999 * makefile.w32-in: Update dependencies.
9001 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9003 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9005 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9007 Fix more problems found by GCC 4.5.2's static checks.
9009 * process.c (make_serial_process_unwind, send_process_trap):
9010 (sigchld_handler): Now static.
9012 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9013 That way, the code declares only the vars that it needs.
9014 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9015 * s/cygwin.h (PTY_ITERATION): Likewise.
9016 * s/darwin.h (PTY_ITERATION): Likewise.
9017 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9019 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9020 * process.c (allocate_pty): Don't declare stb unless it's needed.
9022 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9023 (CONSTANTLIM): Remove; unused.
9024 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9025 Define only if needed.
9027 * unexelf.c (unexec): Name an expression,
9028 to avoid gcc -Wbad-function-cast warning.
9029 Use a different way to cause a compilation error if anyone uses
9030 n rather than nn, a way that does not involve shadowing.
9031 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9033 * deps.mk (unexalpha.o): Remove; unused.
9035 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9036 * unexec.h: New file.
9037 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9038 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9040 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9041 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9042 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9043 Change as necessary to match prototype in unexec.h.
9045 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9047 (back_comment, skip_chars): Mark vars as initialized.
9049 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9050 Rename locals to avoid shadowing.
9052 * lread.c (read1): Rewrite so as not to use empty "else".
9053 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9055 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9057 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9058 warning when compiling print.c.
9060 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9061 instead of using an uninitialized var.
9062 (font_sort_entities): Mark var as initialized.
9064 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9066 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9067 pointers to constants.
9068 (font_parse_fcname): Remove unused vars.
9069 (font_delete_unmatched): Now static.
9070 (font_get_spec): Remove; unused.
9071 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9072 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9073 Rename or move locals to avoid shadowing.
9075 * fns.c (require_nesting_list, require_unwind): Now static.
9076 (Ffillarray): Rename locals to avoid shadowing.
9078 * floatfns.c (domain_error2): Define only if needed.
9079 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9081 * alloc.c (mark_backtrace): Move decl from here ...
9082 * lisp.h: ... to here, so that it can be checked.
9084 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9085 (Fdefvar): Rewrite so as not to use empty "else".
9086 (lisp_indirect_variable): Name an expression,
9087 to avoid gcc -Wbad-function-cast warning.
9088 (Fdefvar): Rename locals to avoid shadowing.
9090 * callint.c (quotify_arg, quotify_args): Now static.
9091 (Fcall_interactively): Rename locals to avoid shadowing.
9092 Use const pointer when appropriate.
9094 * lisp.h (get_system_name, get_operating_system_release):
9095 Move decls here, to check interfaces.
9096 * process.c (get_operating_system_release): Move decl to lisp.h.
9097 * xrdb.c (get_system_name): Likewise.
9098 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9099 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9100 some of which prompt warnings from gcc -Wbad-function-cast.
9101 (Fformat_time_string, Fencode_time, Finsert_char):
9102 (Ftranslate_region_internal, Fformat):
9103 Rename or remove local vars to avoid shadowing.
9104 (Ftranslate_region_internal): Mark var as initialized.
9106 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9109 * lisp.h (eassert): Check that the argument compiles, even if
9110 ENABLE_CHECKING is not defined.
9112 * data.c (Findirect_variable): Name an expression, to avoid
9113 gcc -Wbad-function-cast warning.
9114 (default_value, arithcompare, arith_driver, arith_error): Now static.
9115 (store_symval_forwarding): Rename local to avoid shadowing.
9116 (Fmake_variable_buffer_local, Fmake_local_variable):
9117 Mark variables as initialized.
9118 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9120 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9121 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9122 Rename locals to avoid shadowing.
9123 (mark_stack): Move local variables into the #ifdef region where
9125 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9126 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9128 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9129 (GC_STRING_CHARS): Remove; not used.
9130 (Fmemory_limit): Cast sbrk's returned value to char *.
9132 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9133 avoids undefined behavior in theory.
9135 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9137 Use functions, not macros, for up- and down-casing (Bug#8254).
9138 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9139 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9140 to use the following functions instead of these macros.
9141 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9142 EMACS_INT, since callers assume the returned value fits in int.
9143 (upcase1): Likewise, for UPCASE_TABLE.
9144 (uppercasep, lowercasep, upcase): New static inline functions.
9145 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9146 the race-condition problem in the old DOWNCASE.
9148 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9149 Rename locals to avoid shadowing.
9150 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9151 (regex_compile, re_search_2, re_match_2_internal):
9152 Remove unused local vars.
9153 (FREE_VAR): Rewrite so as not to use empty "else",
9154 which gcc can warn about.
9155 (regex_compile, re_match_2_internal): Mark locals as initialized.
9156 (RETALLOC_IF): Define only if needed.
9157 (WORDCHAR_P): Likewise. This one is never needed, but is used
9158 only in a comment talking about a compiler bug, so put inside
9159 the #if 0 of that comment.
9160 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9161 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9164 * search.c (boyer_moore): Rename locals to avoid shadowing.
9165 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9166 (PREV_CHAR_BOUNDARY): Likewise.
9168 * search.c (simple_search): Remove unused var.
9170 * dired.c (compile_pattern): Move decl from here ...
9171 * lisp.h: ... to here, so that it can be checked.
9172 (struct re_registers): New forward decl.
9174 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9176 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9178 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9179 Rename locals to avoid shadowing.
9180 (Fvertical_motion): Mark locals as initialized.
9182 * casefiddle.c (casify_object, casify_region): Now static.
9183 (casify_region): Mark local as initialized.
9185 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9187 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9188 New macros, so that the caller can use some names other than
9189 gcpro1, gcpro2, etc.
9190 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9192 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9193 argument, for consistency with GCPRO2_VAR, etc: it is now the
9194 prefix of the variable, not the variable itself. All uses
9196 * dired.c (directory_files_internal, file_name_completion):
9197 Rename locals to avoid shadowing.
9199 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9200 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9201 dired.c's scmp function, had undefined behavior.
9202 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9203 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9204 * buffer.h: ... to here, because these macros use current_buffer,
9205 and the new implementation with inline functions needs to have
9206 current_buffer in scope now, rather than later when the macros
9208 (downcase, upcase1): New static inline functions.
9209 (DOWNCASE, UPCASE1): Reimplement using these functions.
9210 This avoids undefined behavior in expressions like
9211 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9212 from race conditions in accessing the global variables
9213 case_temp1 and case_temp2.
9214 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9215 * lisp.h (case_temp1, case_temp2): Remove their decls.
9216 * character.h (ASCII_CHAR_P): Move from here ...
9217 * lisp.h: ... to here, so that the inline functions mentioned
9220 * dired.c (directory_files_internal_unwind): Now static.
9222 * fileio.c (file_name_as_directory, directory_file_name):
9223 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9225 (file_name_as_directory): Use const pointers when appropriate.
9226 (Fexpand_file_name): Likewise. In particular, newdir might
9227 point at constant storage, so make it a const pointer.
9228 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9229 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9231 (Fset_file_times, Finsert_file_contents, auto_save_error):
9232 Rename locals to avoid shadowing.
9234 * minibuf.c (choose_minibuf_frame_1): Now static.
9235 (Ftry_completion, Fall_completions): Rename or remove locals
9238 * marker.c (bytepos_to_charpos): Remove; unused.
9240 * lisp.h (verify_bytepos, count_markers): New decls,
9241 so that gcc does not warn that these functions aren't declared.
9243 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9244 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9245 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9246 (copy_text): Remove unused local var.
9248 * filelock.c (within_one_second): Now static.
9249 (lock_file_1): Rename local to avoid shadowing.
9251 * buffer.c (fix_overlays_before): Mark locals as initialized.
9252 (fix_start_end_in_overlays): Likewise. This function should be
9253 simplified by using pointers-to-pointers, but that's a different
9255 (switch_to_buffer_1): Now static.
9256 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9257 (report_overlay_modification): Rename locals to avoid shadowing.
9259 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9260 Fix pointer signedness issue.
9261 (sys_subshell): Mark local as volatile if checking for lint,
9262 to suppress a gcc -Wclobbered warning that does not seem to be right.
9263 (MAXPATHLEN): Define only if needed.
9265 * process.c (serial_open, serial_configure): Move decls from here ...
9266 * systty.h: ... to here, so that they can be checked.
9268 * fns.c (get_random, seed_random): Move extern decls from here ...
9269 * lisp.h: ... to here, so that they can be checked.
9271 * sysdep.c (reset_io): Now static.
9272 (wait_for_termination_signal): Remove; unused.
9274 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9275 (copy_keymap_item, append_key, push_text_char_description):
9277 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9278 (DENSE_TABLE_SIZE): Remove; unused.
9279 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9280 (describe_map_tree):
9281 Rename locals to avoid shadowing.
9283 * keyboard.c: Declare functions static if they are not used elsewhere.
9284 (echo_char, echo_dash, cmd_error, top_level_2):
9285 (poll_for_input, handle_async_input): Now static.
9286 (read_char, kbd_buffer_get_event, make_lispy_position):
9287 (make_lispy_event, make_lispy_movement, apply_modifiers):
9288 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9289 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9290 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9291 (read_key_sequence, read_char): Mark locals as initialized.
9292 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9294 * keyboard.h (make_ctrl_char): New decl.
9295 (mark_kboards): Move decl here ...
9296 * alloc.c (mark_kboards): ... from here.
9298 * lisp.h (force_auto_save_soon): New decl.
9300 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9301 (DEFINE_DUMMY_FUNCTION): New macro.
9302 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9304 (main): Add casts to avoid warnings
9305 if GCC considers string literals to be constants.
9307 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9309 * dbusbind.c: Pointer signedness fixes.
9310 (xd_signature, xd_append_arg, xd_initialize):
9311 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9312 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9313 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9314 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9316 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9317 if GCC considers string literals to be constants.
9318 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9320 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9322 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9323 (print_preprocess, print_object): New macro to fix last change.
9325 * print.c (print_preprocess): Don't forget font objects.
9327 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9329 * emacs.c (USAGE3): Doc fixes.
9331 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9333 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9336 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9338 * lisp.h (VWindow_system, Qfile_name_history):
9339 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9340 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9341 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9343 * w32select.c: Don't #include "keyboard.h".
9344 (run_protected): Add extern declaration for waiting_for_input.
9346 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9347 * w32console.c (detect_input_pending, read_input_pending)
9348 (encode_terminal_code):
9349 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9350 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9351 (w32_system_caret_y, Qfile_name_history):
9352 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9353 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9354 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9355 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9356 * w32proc.c (Qlocal, report_file_error):
9357 * w32term.c (Vwindow_system, updating_frame):
9358 * w32uniscribe.c (initialized, uniscribe_font_driver):
9359 Remove unneeded extern declarations.
9361 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9363 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9365 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9367 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9368 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9369 These macros can no longer be used for assignment.
9371 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9372 Assign struct members directly, instead of using BUF_BEGV etc.
9373 (record_buffer_markers, fetch_buffer_markers): New functions for
9374 recording and fetching special buffer markers.
9375 (set_buffer_internal_1, set_buffer_temp): Use them.
9377 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9379 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9381 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9382 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9384 * xdisp.c (hscroll_window_tree):
9385 (reconsider_clip_changes): Use PT instead of BUF_PT.
9387 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9389 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9390 $(EMACS_ROOT)/lib/intprops.h.
9392 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9394 Fix more problems found by GCC 4.5.2's static checks.
9396 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9397 to unsigned char * to avoid compiler diagnostic.
9398 (xg_free_frame_widgets): Make it clear that a local variable is
9399 needed only if USE_GTK_TOOLTIP.
9400 (gdk_window_get_screen): Make it clear that this macro is needed
9401 only if USE_GTK_TOOLTIP.
9402 (int_gtk_range_get_value): New function, which avoids a diagnostic
9403 from gcc -Wbad-function-cast.
9404 (xg_set_toolkit_scroll_bar_thumb): Use it.
9405 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9406 diagnostic from gcc -Wbad-function-cast.
9407 (get_utf8_string, xg_get_file_with_chooser):
9408 Rename locals to avoid shadowing.
9409 (create_dialog): Move locals to avoid shadowing.
9411 * xgselect.c (xg_select): Remove unused var.
9413 * image.c (four_corners_best): Mark locals as initialized.
9414 (gif_load): Initialize transparent_p to zero (Bug#8238).
9415 Mark another local as initialized.
9416 (my_png_error, my_error_exit): Mark with NO_RETURN.
9418 * image.c (clear_image_cache): Now static.
9419 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9420 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9421 (x_edge_detection): Remove unnecessary cast that
9422 gcc -Wbad-function-cast diagnoses.
9423 (gif_load): Fix pointer signedness.
9424 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9425 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9427 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9429 Improve quality of tests for time stamp overflow.
9430 For example, without this patch (encode-time 0 0 0 1 1
9431 1152921504606846976) returns the obviously-bogus value (-948597
9432 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9433 reports time overflow. See
9434 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9435 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9436 * editfns.c: Include limits.h and intprops.h.
9437 (TIME_T_MIN, TIME_T_MAX): New macros.
9438 (time_overflow): Move earlier, to before first use.
9439 (hi_time, lo_time): New functions, for an accurate test for
9441 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9442 (Fget_internal_run_time): Don't assume time_t fits in int.
9443 (make_time): Use list2 instead of Fcons twice.
9444 (Fdecode_time): More accurate test for out-of-range times.
9445 (check_tm_member): New function.
9446 (Fencode_time): Use it, to test for out-of-range times.
9447 (lisp_time_argument): Don't rely on undefined left-shift and
9448 right-shift behavior when checking for time stamp overflow.
9450 * editfns.c (time_overflow): New function, refactoring common code.
9451 (Fformat_time_string, Fdecode_time, Fencode_time):
9452 (Fcurrent_time_string): Use it.
9454 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9455 * dired.c (make_time): Move to ...
9456 * editfns.c (make_time): ... here.
9457 * systime.h: Note the move.
9459 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9461 * fringe.c (update_window_fringes): Remove unused variables.
9463 * unexmacosx.c (copy_data_segment): Also copy __got section.
9466 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9468 * termcap.c [MSDOS]: Include "msdos.h".
9469 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9470 Constify `char *' arguments and their references according to
9471 prototypes in tparam.h.
9473 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9475 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9476 Adapt all references accordingly.
9478 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9480 2011-03-11 Tom Tromey <tromey@redhat.com>
9482 * buffer.c (syms_of_buffer): Remove obsolete comment.
9484 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9486 * termhooks.h (encode_terminal_code): Declare prototype.
9488 * msdos.c (encode_terminal_code): Don't declare prototype.
9490 * term.c (encode_terminal_code): Now external again, used by
9491 w32console.c and msdos.c.
9493 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9494 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9496 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9498 Fix some minor problems found by GCC 4.5.2's static checks.
9500 * fringe.c (update_window_fringes): Mark locals as initialized
9502 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9504 * alloc.c (mark_fringe_data): Move decl from here ...
9505 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9506 to check its interface.
9507 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9509 * fontset.c (free_realized_fontset): Now static.
9510 (Fset_fontset_font): Rename local to avoid shadowing.
9511 (fontset_font): Mark local as initialized.
9512 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9514 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9516 * xselect.c (x_disown_buffer_selections): Remove; not used.
9517 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9518 (x_own_selection, Fx_disown_selection_internal): Rename locals
9520 (x_handle_dnd_message): Remove local to avoid shadowing.
9522 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9523 so that the caller can use some name other than gcpro1.
9524 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9525 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9526 (Fx_backspace_delete_keys_p):
9527 Use them to avoid shadowing, and rename vars to avoid shadowing.
9528 (x_decode_color, x_set_name, x_window): Now static.
9529 (Fx_create_frame): Add braces to silence GCC warning.
9530 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9531 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9532 Remove unused locals.
9533 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9534 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9535 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9538 * xterm.h (x_mouse_leave): New decl.
9540 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9541 Remove unused functions.
9542 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9543 (x_calc_absolute_position): Now static.
9544 (XTread_socket): Don't define label "out" unless it's used.
9545 Don't declare local "event" unless it's used.
9546 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9547 unless they are used.
9548 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9549 (x_fatal_error_signal): Remove; not used.
9550 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9551 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9552 (x_error_catcher, x_connection_closed, x_error_handler):
9553 (x_error_quitter, xembed_send_message, x_iconify_frame):
9554 (my_log_handler): Rename locals to avoid shadowing.
9555 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9556 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9558 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9559 Rename or move locals to avoid shadowing.
9560 (tty_defined_color, merge_face_heights): Now static.
9561 (free_realized_faces_for_fontset): Remove; not used.
9562 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9563 does not deduce is never used uninitialized.
9564 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9565 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9567 * terminal.c (store_terminal_param): Now static.
9569 * xmenu.c (menu_highlight_callback): Now static.
9570 (set_frame_menubar): Remove unused local.
9571 (xmenu_show): Rename parameter to avoid shadowing.
9572 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9573 since they might point to immutable storage.
9574 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9575 since it's unused otherwise.
9577 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9578 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9579 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9580 avoids a gcc -Wuninitialized diagnostic.
9581 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9582 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9583 does not deduce are never used uninitialized.
9585 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9587 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9588 * window.c (window_loop, size_window):
9589 (run_window_configuration_change_hook, enlarge_window): Likewise.
9591 * window.c (display_buffer): Now static.
9592 (size_window): Mark variables that gcc -Wuninitialized
9593 does not deduce are never used uninitialized.
9594 * window.h (check_all_windows): New decl, to forestall
9595 gcc -Wmissing-prototypes diagnostic.
9596 * dispextern.h (bidi_dump_cached_states): Likewise.
9598 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9600 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9602 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9603 and to avoid gcc -Wuninitialized warning.
9604 (load_charset_map): Mark variables that gcc -Wuninitialized
9605 does not deduce are never used uninitialized.
9606 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9608 * coding.c (coding_set_source, coding_set_destination):
9609 Use "else { /* comment */ }" rather than "else /* comment */;"
9610 for clarity, and to avoid gcc -Wempty-body warning.
9611 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9612 a block, when the outer 'i' will do.
9613 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9614 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9615 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9616 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9617 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9618 Rename locals to avoid shadowing.
9619 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9620 * coding.c (emacs_mule_char, encode_invocation_designation):
9621 Now static, since they're not used elsewhere.
9622 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9623 (decode_coding_object, encode_coding_object, detect_coding_system):
9624 (decode_coding_emacs_mule): Mark variables that gcc
9625 -Wuninitialized does not deduce are never used uninitialized.
9626 (detect_coding_iso_2022): Initialize a local variable that might
9627 be used uninitialized. Leave a FIXME because it's not clear that
9628 this initialization is needed. (Bug#8211)
9629 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9630 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9631 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9632 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9633 Remove unused macros.
9635 * category.c (hash_get_category_set): Remove unused local var.
9636 (copy_category_table): Now static, since it's not used elsewhere.
9637 * character.c (string_count_byte8): Likewise.
9639 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9640 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9642 * chartab.c (copy_sub_char_table): Now static, since it's not used
9644 (sub_char_table_ref_and_range, char_table_ref_and_range):
9645 Rename locals to avoid shadowing.
9646 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9648 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9649 (BIDI_BOB): Remove unused macro.
9651 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9652 deduce are never used uninitialized.
9653 * term.c (encode_terminal_code): Likewise.
9655 * term.c (encode_terminal_code): Now static. Remove unused local.
9657 * tparam.h: New file.
9658 * term.c, tparam.h: Include it.
9659 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9660 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9661 Move these decls to tparam.h, and make them agree with what
9662 is actually in tparam.c. The previous trick of using incompatible
9663 decls in different modules does not conform to the C standard.
9664 All callers of tparam changed to use tparam's actual API.
9665 * tparam.c (tparam1, tparam, tgoto):
9666 Use const pointers where appropriate.
9668 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9669 * cm.h (struct cm): Likewise.
9670 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9671 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9672 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9673 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9674 (turn_on_face, init_tty): Likewise.
9675 * termchar.h (struct tty_display_info): Likewise.
9677 * term.c (term_mouse_position): Rename local to avoid shadowing.
9679 * alloc.c (mark_ttys): Move decl from here ...
9680 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9682 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9684 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9686 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9688 * search.c (compile_pattern_1): Remove argument regp, unused since
9689 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9690 (compile_pattern): Don't pass it.
9692 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9694 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9695 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9697 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9699 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9701 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9702 gdk_window_get_screen, gdk_window_get_geometry,
9703 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9704 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9705 (xg_get_pixbuf_from_pixmap): New function.
9706 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9707 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9708 Call xg_get_pixbuf_from_pixmap instead of
9709 gdk_pixbuf_get_from_drawable.
9710 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9711 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9712 (xg_check_special_colors): Use GtkStyleContext and its functions
9714 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9715 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9716 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9717 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9718 Call gtk_widget_get_preferred_size.
9719 (xg_frame_resized): gdk_window_get_geometry only takes 5
9721 (xg_win_to_widget, xg_event_is_for_menubar):
9722 Call gdk_x11_window_lookup_for_display.
9723 (xg_set_widget_bg): New function.
9724 (delete_cb): New function.
9725 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9726 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9727 (xg_set_background_color): Call xg_set_widget_bg.
9728 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9729 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9730 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9731 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9733 (update_frame_tool_bar): Call gtk_widget_hide.
9734 (xg_initialize): Use GDK_KEY_g.
9736 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9738 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9740 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9741 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9742 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9744 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9746 * w32xfns.c (select_palette): Check success of RealizePalette against
9747 GDI_ERROR, not zero.
9749 See ChangeLog.11 for earlier changes.
9755 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9757 This file is part of GNU Emacs.
9759 GNU Emacs is free software: you can redistribute it and/or modify
9760 it under the terms of the GNU General Public License as published by
9761 the Free Software Foundation, either version 3 of the License, or
9762 (at your option) any later version.
9764 GNU Emacs is distributed in the hope that it will be useful,
9765 but WITHOUT ANY WARRANTY; without even the implied warranty of
9766 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9767 GNU General Public License for more details.
9769 You should have received a copy of the GNU General Public License
9770 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.