* fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive case.
[bpt/emacs.git] / src / ChangeLog
1 2012-06-09 Chong Yidong <cyd@gnu.org>
2
3 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
4 case (Bug#9752).
5
6 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
7
8 * xdisp.c (vmessage): Treat frame message as multibyte.
9 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
10 would generate the diagnostic "Making \302\247 buffer-local while
11 let-bound!".
12
13 2012-06-08 Eli Zaretskii <eliz@gnu.org>
14
15 * dispnew.c (showing_window_margins_p): Undo last change, which
16 was done due to an inadvertent commit.
17 (adjust_frame_glyphs_for_frame_redisplay): Do call
18 showing_window_margins_p.
19
20 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
21
22 * eval.c (Fmake_var_non_special): New primitive.
23 (syms_of_eval): Defsubr it.
24 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
25
26 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
27
28 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
29 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
30
31 2012-06-08 Eli Zaretskii <eliz@gnu.org>
32
33 * alloc.c (allocate_vectorlike): Fix last change.
34
35 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
36
37 Block-based vector allocation of small vectors.
38 * lisp.h (struct vectorlike_header): New field `nbytes',
39 adjust comment accordingly.
40 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
41 to denote vector blocks. Adjust users (live_vector_p,
42 mark_maybe_pointer, valid_lisp_object_p) accordingly.
43 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
44 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
45 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
46 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
47 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
48 (roundup_size): New constant.
49 (struct vector_block): New data type.
50 (vector_blocks, vector_free_lists, zero_vector): New variables.
51 (all_vectors): Rename to `large_vectors'.
52 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
53 (sweep_vectors): New functions.
54 (allocate_vectorlike): Return `zero_vector' as the only vector of
55 0 items. Allocate new vector from block if vector size is less than
56 or equal to VBLOCK_BYTES_MAX.
57 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
58 (init_alloc_once): Add call to init_vectors.
59
60 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
61
62 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
63
64 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
65
66 * doprnt.c (doprnt): Truncate multibyte char correctly.
67 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
68 would mishandle a string argument "Xc" if X was a multibyte
69 character of length 2: it would truncate after X's first byte
70 rather than including all of X.
71
72 2012-06-06 Chong Yidong <cyd@gnu.org>
73
74 * buffer.c (word_wrap): Doc fix.
75
76 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
77
78 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
79
80 2012-06-03 Glenn Morris <rgm@gnu.org>
81
82 * xdisp.c (tool-bar-style): Doc fix.
83
84 2012-06-03 Ulrich Müller <ulm@gentoo.org>
85
86 * Makefile.in (PAXCTL): Define.
87 (temacs$(EXEEXT)): Disable memory randomization for the temacs
88 binary via PaX flags if the paxctl utility is available.
89 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
90 Restore PaX flags to their default. (Bug#11398)
91
92 2012-06-03 Chong Yidong <cyd@gnu.org>
93
94 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
95 buffer (Bug#11226).
96
97 2012-06-03 Chong Yidong <cyd@gnu.org>
98
99 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
100 (note_mode_line_or_margin_highlight): If there is no help echo,
101 use mode-line-default-help-echo. Handle the case where the mouse
102 position is past the end of the mode line string.
103
104 * buffer.c (buffer_local_value_1): New function, split from
105 Fbuffer_local_value; can return Qunbound.
106 (Fbuffer_local_value): Use it.
107 (Vmode_line_format): Docstring tweaks.
108
109 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
110
111 * sysdep.c (system_process_attributes): Improve comment.
112
113 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
114
115 * keyboard.c: Export real-this-command to Elisp.
116 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
117 and DEFVAR it. Update all users.
118
119 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
120
121 * minibuf.c (Fassoc_string): Remove duplicate declaration.
122
123 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
124 Convert pctcpu and pctmem to Lisp float properly.
125 Let the compiler fold better, as 100.0/0x8000 is exact.
126
127 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
128
129 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
130 cons_block.
131
132 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
133
134 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
135
136 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
137
138 For a 'struct window', replace some Lisp_Object fields to
139 bitfields where appropriate, remove unused fields.
140 * window.h (struct window): Remove unused 'last_mark_x' and
141 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
142 change it's type from Lisp_Object to bitfield.
143 Change type of 'force_start', 'optional_new_start',
144 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
145 fields from Lisp_Object to bitfield. Adjust users accordingly.
146
147 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
148
149 Pacify gcc -Wdouble-precision when using Xaw.
150 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
151 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
152 Use 'float' consistently, rather than 'float' in most places
153 and 'double' in a couple of places.
154
155 2012-05-31 Eli Zaretskii <eliz@gnu.org>
156
157 * xdisp.c (handle_stop): Detect whether we have overlay strings
158 loaded by testing it->current.overlay_string_index to be
159 non-negative, instead of checking whether n_overlay_strings is
160 positive. (Bug#11587)
161
162 2012-05-31 Chong Yidong <cyd@gnu.org>
163
164 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
165
166 * doc.c (Fsubstitute_command_keys): Doc fix.
167
168 2012-05-31 Eli Zaretskii <eliz@gnu.org>
169
170 * search.c (search_buffer): Remove calls to
171 r_alloc_inhibit_buffer_relocation, as it is now called by
172 maybe_unify_char, which was the cause of relocation of buffer text
173 in bug#11519.
174
175 2012-05-31 Eli Zaretskii <eliz@gnu.org>
176
177 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
178 for the duration of call to load_charset, to avoid problems with
179 callers of maybe_unify_char that access buffer text through C
180 pointers.
181
182 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
183 decrement the inhibition flag, instead of just setting or
184 resetting it.
185
186 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
187
188 Remove obsolete '#define static' cruft.
189 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
190 This #undef was "temporary" in 2000; it is no longer needed
191 now that '#define static' has gone away.
192 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
193 (gray_bitmap_bits): Remove; no longer needed.
194 All uses replaced with definiens.
195 * xterm.c: Include "bitmaps/gray.xbm".
196
197 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
198
199 Clean up __executable_start, monstartup when --enable-profiling.
200 The following changes affect the code only when profiling.
201 * dispnew.c (__executable_start): Rename from safe_bcopy.
202 Define only on platforms that need it.
203 * emacs.c: Include <sys/gmon.h> when profiling.
204 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
205 (__executable_start): Remove decl, since lisp.h does it now.
206 (safe_bcopy): Remove decl; no longer has that name.
207 (main): Coalesce #if into single bit of code, for simplicity.
208 Cast pointers to uintptr_t, since standard libraries want integers
209 and not pointers.
210 * lisp.h (__executable_start): New decl.
211
212 2012-05-31 Glenn Morris <rgm@gnu.org>
213
214 * image.c (Fimagemagick_types): Doc fix.
215
216 2012-05-30 Jim Meyering <meyering@redhat.com>
217
218 * callproc.c (Fcall_process_region): Include directory component
219 in mkstemp error message (Bug#11586).
220
221 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
222
223 * alloc.c, lisp.h (make_pure_vector): Now static.
224
225 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
226
227 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
228 Move to byte-run.el.
229 (Fautoload): Do the hash-doc more carefully.
230 * data.c (Fdefalias): Purify definition, except for keymaps.
231 (Qdefun): Move from eval.c.
232 * lisp.h (Qdefun): Remove.
233 * lread.c (read1): Tiny simplification.
234
235 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
236
237 Do not create empty overlays with the evaporate property (Bug#9642).
238 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
239 Bug#9642, but explicitly check that the buffer the overlay would
240 be moved to is live and rearrange lines to make sure that errors
241 will not put the overlay in an inconsistent state.
242 (Fdelete_overlay): Cosmetics.
243
244 2012-05-28 Eli Zaretskii <eliz@gnu.org>
245
246 * w32term.c (my_bring_window_to_top): New function.
247 (x_raise_frame): Use handle returned by DeferWindowPos, which
248 could be different from the original one.
249 Call my_bring_window_to_top instead of my_set_foreground_window.
250 (Bug#11513)
251
252 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
253 by calling BringWindowToTop.
254
255 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
256 (WM_EMACS_END): Increase by one.
257
258 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
259
260 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
261 This avoids undefined behavior that might cause the eassert
262 to not catch an out-of-range value.
263
264 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
265
266 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
267 Update dependencies.
268
269 2012-05-27 Eli Zaretskii <eliz@gnu.org>
270
271 * bidi.c (bidi_mirror_char): Fix last change.
272
273 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
274
275 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
276 when referring to sectname field in printf format.
277
278 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
279
280 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
281 Only r_alloc_inhibit_buffer_relocation needed to be added;
282 the others were already declared.
283
284 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
285 before checking whether it's out of range. Put the check inside
286 eassert. See
287 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
288
289 2012-05-27 Ken Brown <kbrown@cornell.edu>
290
291 * callproc.c (Fcall_process): Restore a line that was accidentally
292 commented out in the 2011-02-13 change (bug#11547).
293
294 2012-05-27 Eli Zaretskii <eliz@gnu.org>
295
296 * lisp.h [REL_ALLOC]: Add prototypes for external functions
297 defined on ralloc.c.
298
299 * buffer.c [REL_ALLOC]: Remove prototypes of
300 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
301 they are now on lisp.h.
302
303 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
304
305 * search.c (search_buffer): Use it to inhibit relocation of buffer
306 text while re_search_2 is doing its job, because re_search_2 is
307 passed C pointers to buffer text. (Bug#11519)
308
309 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
310 Update value to 24.
311
312 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
313 state after an additional call to move_it_in_display_line_to, keep
314 the values of it->max_ascent and it->max_descent found for the
315 entire line.
316 (pos_visible_p): Revert the comparison against bottom_y to what it
317 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
318 (Bug#11464)
319
320 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
321
322 Fix coding-related core dumps with gcc -ftrapv.
323 The code was computing A - B, where A and B are pointers, and B is
324 random garbage. This can lead to core dumps on platforms that
325 have special pointer registers, and it also leads to core dumps on
326 x86-64 when compiled with gcc -ftrapv. The fix is to compute
327 A - B only when B is initialized properly.
328 * coding.c (coding_set_source, coding_set_destination): Return void.
329 (coding_change_source, coding_change_destinations): New functions,
330 with the old behaviors of coding_set_source and coding_set_destination.
331 All callers that need an offset changed to use these new functions.
332
333 2012-05-26 Glenn Morris <rgm@gnu.org>
334
335 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
336
337 2012-05-26 Eli Zaretskii <eliz@gnu.org>
338
339 Extend mouse support on W32 text-mode console.
340 * xdisp.c (draw_row_with_mouse_face):
341 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
342
343 * w32console.c: Include window.h.
344 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
345 New functions.
346 (initialize_w32_display): Initialize mouse-highlight data.
347
348 * w32inevt.c: Include termchar.h and window.h.
349 (do_mouse_event): Support mouse-autoselect-window. When the mouse
350 moves, call note_mouse_highlight. If help_echo changed, call
351 gen_help_event to produce help-echo message in the echo area.
352 Call clear_mouse_face if mouse_face_hidden is set in the mouse
353 highlight info.
354
355 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
356
357 * lread.c (read1): Simplify slightly to avoid an overflow warning
358 with GCC 4.7.0 on x86-64.
359
360 2012-05-26 Eli Zaretskii <eliz@gnu.org>
361
362 * bidi.c (bidi_mirror_char): Revert last change: an int is
363 definitely wide enough here.
364
365 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
366
367 Fix integer width and related bugs (Bug#9874).
368 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
369 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
370 (string_bytes, check_sblock, allocate_string_data):
371 (compact_small_strings, Fmake_bool_vector, make_string)
372 (make_unibyte_string, make_multibyte_string)
373 (make_string_from_bytes, make_specified_string)
374 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
375 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
376 (mark_vectorlike):
377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
378 (allocate_pseudovector):
379 Use int, not EMACS_INT, where int is wide enough.
380 (inhibit_garbage_collection, Fgarbage_collect):
381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
382 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
383 int might not be wide enough.
384 (bidi_cache_search, bidi_cache_find, bidi_init_it)
385 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
386 (bidi_at_paragraph_end, bidi_find_paragraph_start)
387 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
388 (bidi_level_of_next_char, bidi_move_to_visually_next):
389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
390 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
391 (Fkill_buffer, Fset_buffer_major_mode)
392 (advance_to_char_boundary, Fbuffer_swap_text)
393 (Fset_buffer_multibyte, overlays_at, overlays_in)
394 (overlay_touches_p, struct sortvec, record_overlay_string)
395 (overlay_strings, recenter_overlay_lists)
396 (adjust_overlays_for_insert, adjust_overlays_for_delete)
397 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
398 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
399 (Foverlay_recenter, last_overlay_modification_hooks_used)
400 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
402 (validate_region): Omit unnecessary test for b <= e,
403 since that's guaranteed by the previous test.
404 (adjust_overlays_for_delete): Avoid pos + length overflow.
405 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
406 (report_overlay_modification):
407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
408 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
409 Omit pointer cast, which isn't needed anyway, and doesn't work
410 after the EMACS_INT -> ptrdiff_t change.
411 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
412 * buffer.h: Adjust decls to match defn changes elsewhere.
413 (struct buffer_text, struct buffer):
414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
415 Use EMACS_INT, not int, where int might not be wide enough.
416 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
417 not int, to avoid needless 32-bit limit on 64-bit hosts.
418 (exec_byte_code): Use tighter memory-full test, one that checks
419 for alloca overflow. Don't compute the address of the object just
420 before an array, as that's not portable. Use EMACS_INT, not
421 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
422 * callint.c (Fcall_interactively):
423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
424 * callproc.c (call_process_kill, Fcall_process):
425 Don't assume pid_t fits into an Emacs fixnum.
426 (call_process_cleanup, Fcall_process, child_setup):
427 Don't assume pid_t fits into int.
428 (call_process_cleanup, Fcall_process, delete_temp_file)
429 (Fcall_process_region):
430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
431 (Fcall_process): Simplify handling of volatile integers.
432 Use int, not EMACS_INT, where int will do.
433 * casefiddle.c (casify_object, casify_region, operate_on_word)
434 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
436 (casify_object): Avoid integer overflow when overallocating buffer.
437 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
438 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
439 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
440 * category.h (CATEGORYP): Don't assume arg is nonnegative.
441 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
442 integers are now checked earlier. All uses replaced with XINT.
443 (ccl_driver):
444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
445 For CCL_MapSingle, check that content and value are in int range.
446 (ccl_driver, Fregister_code_conversion_map):
447 Check that Vcode_version_map_vector is a vector.
448 (resolve_symbol_ccl_program): Check that vector header is in range.
449 Always copy the vector, so that we can check its contents reliably
450 now rather than having to recheck each instruction as it's being
451 executed. Check that vector words fit in 'int'.
452 (ccl_get_compiled_code, Fregister_ccl_program)
453 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
454 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
455 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
456 contents are in range.
457 (Fccl_execute_on_string): Check that status is in range.
458 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
459 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
460 Accept and return EMACS_INT, not int, because callers can pass values
461 out of 'int' range.
462 (c_string_width, strwidth, lisp_string_width, chars_in_text)
463 (multibyte_chars_in_text, parse_str_as_multibyte)
464 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
465 (str_as_unibyte, str_to_unibyte, string_count_byte8)
466 (string_escape_byte8, Fget_byte):
467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
468 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
469 avoid mishandling large integers.
470 * character.h: Adjust decls to match defn changes elsewhere.
471 * charset.c (load_charset_map_from_file, find_charsets_in_text)
472 (Ffind_charset_region):
473 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
474 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
475 (load_charset_map_from_vector, Fdefine_charset_internal):
476 Don't assume fixnum fits in int.
477 (load_charset_map_from_vector, Fmap_charset_chars):
478 Remove now-unnecessary CHECK_NATNUMs.
479 (Fdefine_charset_internal): Check ranges here, more carefully.
480 Don't rely on undefined behavior with signed left shift overflow.
481 Don't assume unsigned int fits into fixnum, or that fixnum fits
482 into unsigned int. Don't require max_code to be a valid fixnum;
483 that's not true for gb10830 4-byte on a 32-bit host. Allow
484 invalid_code to be a cons, for the same reason. Require code_offset
485 to be a character. Avoid int overflow if max_char is close
486 to INT_MAX.
487 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
488 this is intended anyway and avoids some undefined behavior.
489 (load_charset_map): Pass unsigned, not int, as 2nd arg of
490 INDEX_TO_CODE_POINT, as that's what it expects.
491 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
492 * charset.h (DECODE_CHAR): Return int, not unsigned;
493 this is what was intended anyway, and it avoids undefined behavior.
494 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
495 integer-overflow issues.
496 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
497 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
498 where the argument is EMACS_INT, and this behavior is not intended.
499 * chartab.c (Fmake_char_table, Fset_char_table_range)
500 (uniprop_get_decoder, uniprop_get_encoder):
501 Don't assume fixnum fits in int.
502 * cmds.c (move_point): New function, that does the gist of
503 Fforward_char and Fbackward_char, but does so while checking
504 for integer overflow more accurately.
505 (Fforward_char, Fbackward_char): Use it.
506 (Fforward_line, Fend_of_line, internal_self_insert)
507 (internal_self_insert):
508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
509 Fix a FIXME, by checking for integer overflow when calculating
510 target_clm and actual_clm.
511 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
512 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
513 (ASSURE_DESTINATION, coding_alloc_by_realloc)
514 (coding_alloc_by_making_gap, alloc_destination)
515 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
516 (encode_coding_utf_16, detect_coding_emacs_mule)
517 (decode_coding_emacs_mule, encode_coding_emacs_mule)
518 (detect_coding_iso_2022, decode_coding_iso_2022)
519 (encode_invocation_designation, encode_designation_at_bol)
520 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
521 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
522 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
523 (encode_coding_ccl, encode_coding_raw_text)
524 (detect_coding_charset, decode_coding_charset)
525 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
526 (produce_composition, produce_charset, produce_annotation)
527 (decode_coding, handle_composition_annotation)
528 (handle_charset_annotation, consume_chars, decode_coding_gap)
529 (decode_coding_object, encode_coding_object, detect_coding_system)
530 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
531 (code_convert_region, code_convert_string)
532 (Fdefine_coding_system_internal)
533 (coding_set_source, coding_set_destination):
534 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
535 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
536 (Fdefine_coding_system_internal):
537 Don't assume fixnums fit in int.
538 (decode_coding_gap, decode_coding_object, encode_coding_object)
539 (Fread_coding_system, Fdetect_coding_region)
540 (Funencodable_char_position, Fcheck_coding_systems_region)
541 (get_translation, handle_composition_annotation, consume_chars):
542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
543 (consume_chars): Rewrite to not calculate an address outside buffer.
544 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
545 Don't access memory outside of the args array.
546 (Fdefine_coding_system_internal): Check for charset-id overflow.
547 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
548 result of ENCODE_CHAR.
549 * coding.h: Adjust decls to match defn changes elsewhere.
550 (struct coding_system):
551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
552 * composite.c (get_composition_id, find_composition)
553 (run_composition_function, update_compositions)
554 (compose_text, composition_gstring_put_cache)
555 (composition_gstring_p, composition_gstring_width)
556 (fill_gstring_header, fill_gstring_body, autocmp_chars)
557 (composition_compute_stop_pos, composition_reseat_it)
558 (composition_update_it, struct position_record)
559 (find_automatic_composition, composition_adjust_point)
560 (Fcomposition_get_gstring, Ffind_composition_internal):
561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
562 (update_compositions):
563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
564 * composite.h: Adjust decls to match defn changes elsewhere.
565 (struct composition):
566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
567 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
568 Do not attempt to compute the address of the object just before a
569 buffer; this is not portable.
570 (Faref, Faset):
571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
572 (Faset): Use int, not EMACS_INT, where int is wide enough.
573 (Fstring_to_number): Don't assume fixnums fit in int.
574 (Frem): Don't assume arg is nonnegative.
575 * dbusbind.c (xd_append_arg): Check for integers out of range.
576 (Fdbus_call_method): Don't overflow the timeout int.
577 (extract_signed, extract_unsigned): New functions.
578 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
579 (xd_get_connection_references): Return ptrdiff_t, not int.
580 All uses changed.
581 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
582 (xd_read_message_1):
583 Use int, not unsigned, where the dbus API uses int.
584 (Fdbus_message_internal): Don't overflow mtype.
585 (syms_of_dbusbind): Allocate right-sized buffer for integers.
586 * dired.c (directory_files_internal, file_name_completion, scmp)
587 (file_name_completion_stat):
588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
589 (file_name_completion): Don't overflow matchcount.
590 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
591 * dispextern.h: Adjust decls to match defn changes elsewhere.
592 (struct text_pos, struct glyph, struct bidi_saved_info)
593 (struct bidi_string_data, struct bidi_it, struct composition_it)
594 (struct it):
595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
596 (struct display_pos, struct composition_it, struct it):
597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
598 * dispnew.c (increment_matrix_positions)
599 (increment_row_positions, mode_line_string)
600 (marginal_area_string):
601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
602 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
604 (duration_to_sec_usec): New function, to check for overflow better.
605 (Fsleep_for, sit_for): Use it.
606 * doc.c (get_doc_string, store_function_docstring):
607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
608 (get_doc_string, Fsnarf_documentation):
609 Use int, not EMACS_INT, where int is wide enough.
610 (get_doc_string):
611 Use SAFE_ALLOCA, not alloca.
612 Check for overflow when converting EMACS_INT to off_t.
613 * doprnt.c (doprnt):
614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
615 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
616 Don't assume uid_t fits into fixnum.
617 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
618 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
619 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
620 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
621 (general_insert_function)
622 (Finsert_char, make_buffer_string, make_buffer_string_both)
623 (update_buffer_properties, Fbuffer_substring)
624 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
625 (Fsubst_char_in_region, check_translation)
626 (Ftranslate_region_internal, save_restriction_restore, Fformat)
627 (transpose_markers, Ftranspose_regions):
628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
629 (clip_to_bounds): Move to lisp.h as an inline function).
630 (Fconstrain_to_field): Don't assume integers are nonnegative.
631 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
632 (Fsubst_char_in_region, Fsave_restriction):
633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
634 (Femacs_pid): Don't assume pid_t fits into fixnum.
635 (lo_time): Use int, not EMACS_INT, when int suffices.
636 (lisp_time_argument): Check for usec out of range.
637 (Fencode_time): Don't assume fixnum fits in int.
638 (Fuser_login_name, Fuser_full_name): Signal an error
639 if a uid argument is out of range, rather than relying on
640 undefined behavior.
641 (Fformat_time_string): Remove now-unnecessary check.
642 lisp_time_argument checks for out-of-range usec now.
643 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
644 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
645 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
646 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
647 (init_cmdargs, Fdump_emacs):
648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
649 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
650 the bottom (typically) 32 bits of the fixnum.
651 * eval.c (specpdl_size, call_debugger):
652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
653 (when_entered_debugger, Fbacktrace_debug):
654 Don't assume fixnum can fit in int.
655 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
656 the object just before a buffer; this is not portable.
657 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
658 (grow_specpdl, unbind_to):
659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
660 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
661 (grow_specpdl): Simplify allocation by using xpalloc.
662 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
663 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
664 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
665 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
666 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
667 (a_write, e_write):
668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
669 (Fcopy_file, non_regular_nbytes, read_non_regular)
670 (Finsert_file_contents):
671 Use int, not EMACS_INT, where int is wide enough.
672 (READ_BUF_SIZE): Verify that it fits in int.
673 (Finsert_file_contents): Check that counts are in proper range,
674 rather than assuming fixnums fit into ptrdiff_t etc.
675 Don't assume fixnums fit into int.
676 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
677 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
678 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
679 (string_char_to_byte, string_byte_to_char)
680 (string_make_multibyte, string_to_multibyte)
681 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
682 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
683 (substring_both, Fdelete, internal_equal, Ffillarray)
684 (Fclear_string, mapcar1)
685 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
686 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
687 (larger_vector, make_hash_table, maybe_resize_hash_table)
688 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
689 (Fmaphash, secure_hash):
690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
691 (concat): Check for string index and length overflow.
692 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
693 (Frequire):
694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
695 (larger_vector): New API (vec, incr_min, size_max) replaces old
696 one (vec, new_size, init). This catches size overflow.
697 INIT was removed because it was always Qnil.
698 All callers changed.
699 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
700 the upper bound on a hash table index size.
701 (make_hash_table, maybe_resize_hash_table): Use it.
702 (secure_hash): Computer start_byte and end_byte only after
703 they're known to be in ptrdiff_t range.
704 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
705 (Ffont_get_glyphs, Ffont_at):
706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
707 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
708 (Flist_fonts, Fopen_font):
709 Don't assume fixnum can fit in int.
710 (check_gstring): Don't assume index can fit in int.
711 (font_match_p): Check that fixnum is a character, not a nonnegative
712 fixnum, since the later code needs to stuff it into an int.
713 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
714 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
715 conversion overflow issues.
716 (Fopen_font): Check for integer out of range.
717 (Ffont_get_glyphs): Don't assume index can fit in int.
718 * font.h: Adjust decls to match defn changes elsewhere.
719 * fontset.c (reorder_font_vector): Redo score calculation to avoid
720 integer overflow.
721 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
722 printmax_t, where ptrdiff_t is wide enough.
723 (Finternal_char_font):
724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
725 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
726 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
727 (Fset_frame_position, x_set_frame_parameters)
728 (x_set_line_spacing, x_set_border_width)
729 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
730 Check that fixnums are in proper range for system types.
731 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
733 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
734 Use SAFE_ALLOCA_LISP, not alloca.
735 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
736 intptr_t is wide enough.
737 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
738 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
739 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
740 Check for fixnum out of range.
741 * ftfont.c (ftfont_list): Don't assume index fits in int.
742 Check that fixnums are in proper range for system types.
743 (ftfont_shape_by_flt):
744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
745 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
747 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
748 Check that fixnums are in proper range for system types.
749 * gnutls.h: Adjust decls to match defn changes elsewhere.
750 * gtkutil.c (xg_dialog_run):
751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
752 (update_frame_tool_bar):
753 Check that fixnums are in proper range for system types.
754 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
755 (lookup_image): Check that fixnums are in range for system types.
756 * indent.c (last_known_column, last_known_column_point):
757 (current_column_bol_cache):
758 (skip_invisible, current_column, check_display_width):
759 (check_display_width, scan_for_column, current_column_1)
760 (Findent_to, Fcurrent_indentation, position_indentation)
761 (indented_beyond_p, Fmove_to_column, compute_motion):
762 (Fcompute_motion, Fvertical_motion):
763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
764 (last_known_column_modified): Use EMACS_INT, not int.
765 (check_display_width):
766 (Fcompute_motion):
767 Check that fixnums and floats are in proper range for system types.
768 (compute_motion): Don't assume index or fixnum fits in int.
769 (compute_motion, Fcompute_motion):
770 Use int, not EMACS_INT, when it is wide enough.
771 (vmotion): Omit local var start_hpos that is always 0; that way
772 we don't need to worry about overflow in expressions involving it.
773 * indent.h: Adjust decls to match defn changes elsewhere.
774 (struct position):
775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
776 Use int, not EMACS_INT, where int is wide enough.
777 Remove unused members ovstring_chars_done and tab_offset;
778 all uses removed.
779 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
780 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
781 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
782 (make_gap, copy_text, insert, insert_and_inherit)
783 (insert_before_markers, insert_before_markers_and_inherit)
784 (insert_1, count_combining_before, count_combining_after)
785 (insert_1_both, insert_from_string)
786 (insert_from_string_before_markers, insert_from_string_1)
787 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
788 (adjust_after_replace, adjust_after_insert, replace_range)
789 (replace_range_2, del_range, del_range_1, del_range_byte)
790 (del_range_both, del_range_2, modify_region)
791 (prepare_to_modify_buffer, signal_before_change)
792 (signal_after_change, Fcombine_after_change_execute):
793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
794 * intervals.c (traverse_intervals, rotate_right, rotate_left)
795 (balance_an_interval, split_interval_right, split_interval_left)
796 (find_interval, next_interval, update_interval)
797 (adjust_intervals_for_insertion, delete_node, delete_interval)
798 (interval_deletion_adjustment, adjust_intervals_for_deletion)
799 (static_offset_intervals, offset_intervals)
800 (merge_interval_right, merge_interval_left, make_new_interval)
801 (graft_intervals_into_buffer, temp_set_point_both)
802 (temp_set_point, set_point, adjust_for_invis_intang)
803 (set_point_both, move_if_not_intangible, get_property_and_range)
804 (get_local_map, copy_intervals, copy_intervals_to_string)
805 (compare_string_intervals, set_intervals_multibyte_1):
806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
807 * intervals.h: Adjust decls to match defn changes elsewhere.
808 (struct interval):
809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
810 * keyboard.c (this_command_key_count, this_single_command_key_start)
811 (before_command_key_count, before_command_echo_length, echo_now)
812 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
813 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
814 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
815 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
816 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
817 (last_non_minibuf_size, last_point_position, echo_truncate)
818 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
819 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
820 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
821 (stuff_buffered_input):
822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
823 (last_auto_save, command_loop_1, read_char):
824 Use EMACS_INT, not int, to avoid integer overflow.
825 (record_char): Avoid overflow in total_keys computation.
826 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
827 * keyboard.h: Adjust decls to match defn changes elsewhere.
828 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
829 (Fkey_description, Fdescribe_vector, Flookup_key):
830 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
831 (click_position): New function, to check that positions are in range.
832 (Fcurrent_active_maps):
833 (describe_command):
834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
835 (Faccessible_keymaps, Fkey_description):
836 (preferred_sequence_p):
837 Don't assume fixnum can fit into int.
838 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
839 Check for integer overflow in size calculations.
840 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
841 avoid mishandling large integers.
842 * lisp.h: Adjust decls to match defn changes elsewhere.
843 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
844 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
845 (struct Lisp_Marker):
846 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
847 (clip_to_bounds): Now an inline function, moved here from editfns.c.
848 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
849 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
850 All callers changed.
851 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
852 Assume the arg has valid form, since it always does.
853 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
854 unsigned integer system type.
855 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
856 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
857 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
858 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
859 (duration_to_sec_usec): New decl.
860 * lread.c (read_from_string_index, read_from_string_index_byte)
861 (read_from_string_limit, readchar, unreadchar, openp)
862 (read_internal_start, read1, oblookup):
863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
864 (Fload, readevalloop, Feval_buffer, Feval_region):
865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
866 (openp): Check for out-of-range argument to 'access'.
867 (read1): Use int, not EMACS_INT, where int is wide enough.
868 Don't assume fixnum fits into int.
869 Fix off-by-one error that can read outside a buffer.
870 (read_filtered_event): Use duration_to_sec_usec
871 to do proper overflow checking on durations.
872 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
873 in size calculation.
874 (Fexecute_kbd_macro):
875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
876 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
877 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
878 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
879 (set_marker_both, set_marker_restricted_both, marker_position)
880 (marker_byte_position, Fbuffer_has_markers_at):
881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
882 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
883 * menu.c (ensure_menu_items): Rename from grow_menu_items.
884 It now merely ensures that the menu is large enough, without
885 necessarily growing it, as this avoids some integer overflow issues.
886 All callers changed.
887 (keymap_panes, parse_single_submenu, Fx_popup_menu):
888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
889 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
890 Use SAFE_ALLOCA_LISP, not alloca.
891 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
892 to EMACS_INT. Check that fixnums are in proper range for system types.
893 * minibuf.c (minibuf_prompt_width, string_to_object)
894 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
895 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
896 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
897 (get_minibuffer, read_minibuf_unwind):
898 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
899 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
900 this simplifies overflow checking. All callers changed.
901 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
902 (Ftest_completion):
903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
904 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
905 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
906 Check that fixnums are in proper range for system types.
907 (Fx_create_frame, Fx_show_tip):
908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
909 * nsfont.m (ns_findfonts, nsfont_list_family):
910 Don't assume fixnum fits in long.
911 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
913 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
914 wide enough.
915 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
916 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
917 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
918 (PRINTDECLARE, PRINTPREPARE):
919 (strout, print_string):
920 (print, print_preprocess, print_check_string_charset_prop)
921 (print_object):
922 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
923 (PRINTDECLARE):
924 (temp_output_buffer_setup, Fprin1_to_string, print_object):
925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
926 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
927 (printchar, strout): Use xpalloc to catch size calculation overflow.
928 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
929 (print_error_message): Use SAFE_ALLOCA, not alloca.
930 (print_object): Use int, not EMACS_INT, where int is wide enough.
931 (print_depth, new_backquote_output, print_number_index):
932 Use ptrdiff_t, not int, where int might not be wide enough.
933 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
934 (Fset_process_window_size, Fformat_network_address)
935 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
936 (sigchld_handler):
937 Check that fixnums are in proper range for system types.
938 (Fsignal_process): Simplify by avoiding a goto.
939 Check for process-ids out of pid_t range rather than relying on
940 undefined behavior.
941 (process_tick, update_tick): Use EMACS_INT, not int.
942 (Fformat_network_address, read_process_output, send_process)
943 (Fprocess_send_region, status_notify):
944 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
945 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
946 (wait_reading_process_output, read_process_output, exec_sentinel):
947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
948 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
949 (Faccept_process_output): Use duration_to_sec_usec to do proper
950 overflow checking on durations.
951 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
952 Don't assume pid_t fits in int.
953 * process.h (struct Lisp_Process): Members tick and update_tick
954 are now of type EMACS_INT, not int.
955 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
956 configured --with-wide-int.
957 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
958 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
959 * search.c (looking_at_1, string_match_1):
960 (fast_string_match, fast_c_string_match_ignore_case)
961 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
962 (scan_newline, find_before_next_newline, search_command)
963 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
964 (set_search_regs, wordify):
965 (Freplace_match):
966 (Fmatch_data):
967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
968 (string_match_1, search_buffer, set_search_regs):
969 (Fmatch_data):
970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
971 (wordify): Check for overflow in size calculation.
972 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
973 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
974 Check that fixnums are in proper range for system types.
975 * sound.c (struct sound_device)
976 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
978 (Fplay_sound_internal):
979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
980 * syntax.c (struct lisp_parse_state, find_start_modiff)
981 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
982 (Fparse_partial_sexp):
983 Don't assume fixnums can fit in int.
984 (struct lisp_parse_state, find_start_pos, find_start_value)
985 (find_start_value_byte, find_start_begv)
986 (update_syntax_table, char_quoted, dec_bytepos)
987 (find_defun_start, prev_char_comend_first, back_comment):
988 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
989 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
991 (Finternal_describe_syntax_value): Check that match_lisp is a
992 character, not an integer, since the code stuffs it into int.
993 (scan_words, scan_sexps_forward):
994 Check that fixnums are in proper range for system types.
995 (Fforward_word):
996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
997 (scan_sexps_forward):
998 Use CHARACTERP, not INTEGERP, since the value must fit into int.
999 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1000 * syntax.h: Adjust decls to match defn changes elsewhere.
1001 (struct gl_state_s):
1002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1003 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1004 MOST_POSITIVE_FIXNUM.
1005 * sysdep.c (wait_for_termination_1, wait_for_termination)
1006 (interruptible_wait_for_termination, mkdir):
1007 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1008 (emacs_read, emacs_write):
1009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1010 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1011 and double all fit in int.
1012 * term.c (set_tty_color_mode):
1013 Check that fixnums are in proper range for system types.
1014 * termhooks.h (struct input_event):
1015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1016 * textprop.c (validate_interval_range, interval_of)
1017 (Fadd_text_properties, set_text_properties_1)
1018 (Fremove_text_properties, Fremove_list_of_text_properties)
1019 (Ftext_property_any, Ftext_property_not_all)
1020 (copy_text_properties, text_property_list, extend_property_ranges)
1021 (verify_interval_modification):
1022 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1023 (Fnext_single_char_property_change)
1024 (Fprevious_single_char_property_change):
1025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1026 (copy_text_properties):
1027 Check for integer overflow in index calculation.
1028 * undo.c (last_boundary_position, record_point, record_insert)
1029 (record_delete, record_marker_adjustment, record_change)
1030 (record_property_change):
1031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1032 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1033 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1034 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1035 (Fx_hide_tip, Fx_file_dialog):
1036 * w32menu.c (set_frame_menubar):
1037 Use ptrdiff_t, not int, for consistency with rest of code.
1038 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1039 (select_window, Fdelete_other_windows_internal)
1040 (window_scroll_pixel_based, window_scroll_line_based)
1041 (Frecenter, Fset_window_configuration):
1042 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1043 (Fset_window_hscroll, run_window_configuration_change_hook)
1044 (set_window_buffer, temp_output_buffer_show, scroll_command)
1045 (Fscroll_other_window, Frecenter):
1046 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1047 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1048 Don't assume fixnum fits in int.
1049 (Fset_window_scroll_bars):
1050 Check that fixnums are in proper range for system types.
1051 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1052 (string_pos, c_string_pos, number_of_chars, init_iterator)
1053 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1054 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1055 (compute_display_string_end, handle_face_prop)
1056 (face_before_or_after_it_pos, handle_invisible_prop)
1057 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1058 (display_prop_intangible_p, string_buffer_position_lim)
1059 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1060 (get_overlay_strings_1, get_overlay_strings)
1061 (iterate_out_of_display_property, forward_to_next_line_start)
1062 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1063 (get_next_display_element, set_iterator_to_next)
1064 (get_visually_first_element, compute_stop_pos_backwards)
1065 (handle_stop_backwards, next_element_from_buffer)
1066 (move_it_in_display_line_to, move_it_in_display_line)
1067 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1068 (add_to_log, message_dolog, message_log_check_duplicate)
1069 (message2, message2_nolog, message3, message3_nolog
1070 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1071 (current_message_1, truncate_echo_area, truncate_message_1)
1072 (set_message, set_message_1, store_mode_line_noprop)
1073 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1074 (text_outside_line_unchanged_p, check_point_in_composition)
1075 (reconsider_clip_changes)
1076 (redisplay_internal, set_cursor_from_row, try_scrolling)
1077 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1078 (redisplay_window, find_last_unchanged_at_beg_row)
1079 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1080 (trailing_whitespace_p, find_row_edges, display_line)
1081 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1082 (display_mode_element, store_mode_line_string)
1083 (pint2str, pint2hrstr, decode_mode_spec)
1084 (display_count_lines, display_string, draw_glyphs)
1085 (x_produce_glyphs, x_insert_glyphs)
1086 (rows_from_pos_range, mouse_face_from_buffer_pos)
1087 (fast_find_string_pos, mouse_face_from_string_pos)
1088 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1089 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1090 (safe_call, init_from_display_pos, handle_fontified_prop)
1091 (handle_single_display_spec, load_overlay_strings)
1092 (with_echo_area_buffer, setup_echo_area_for_printing)
1093 (display_echo_area, echo_area_display)
1094 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1095 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1096 (redisplay_window, dump_glyph_row, display_mode_line)
1097 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1098 (handle_display_spec, display_prop_string_p):
1099 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1100 (handle_single_display_spec, build_desired_tool_bar_string)
1101 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1102 (get_specified_cursor_type):
1103 Check that fixnums are in proper range for system types.
1104 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1105 (Flookup_image_map):
1106 Don't assume fixnums fit in int.
1107 (compare_overlay_entries):
1108 Avoid mishandling comparisons due to subtraction overflow.
1109 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1110 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1111 (handle_tool_bar_click):
1112 Use int, not unsigned, since we prefer signed and the signedness
1113 doesn't matter here.
1114 (get_next_display_element, next_element_from_display_vector):
1115 Use int, not EMACS_INT, when int is wide enough.
1116 (start_hourglass): Use duration_to_sec_usec to do proper
1117 overflow checking on durations.
1118 * xfaces.c (Fbitmap_spec_p):
1119 Check that fixnums are in proper range for system types.
1120 (compare_fonts_by_sort_order):
1121 Avoid mishandling comparisons due to subtraction overflow.
1122 (Fx_family_fonts, realize_basic_faces):
1123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1124 (Fx_family_fonts):
1125 Don't assume fixnum fits in int.
1126 Use SAFE_ALLOCA_LISP, not alloca.
1127 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1128 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1129 (face_at_buffer_position, face_for_overlay_string)
1130 (face_at_string_position):
1131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1132 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1133 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1134 (Fx_show_tip):
1135 Check that fixnums are in proper range for system types.
1136 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1137 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1138 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1139 (Fx_change_window_property): Don't assume fixnums fit in int.
1140 * xfont.c (xfont_chars_supported):
1141 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1142 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1143 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1144 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1145 * xml.c (parse_region):
1146 * xrdb.c (magic_file_p):
1147 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1148 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1149 (x_get_local_selection, x_reply_selection_request)
1150 (x_handle_selection_request, wait_for_property_change):
1151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1152 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1153 short is wide enough.
1154 (x_send_client_event): Don't assume fixnum fits in int.
1155 * xterm.c (x_x_to_emacs_modifiers):
1156 Don't assume EMACS_INT overflows nicely into int.
1157 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1158 may come from Lisp.
1159 (handle_one_xevent): NATNUMP can eval its arg twice.
1160 (x_connection_closed):
1161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1162 * xterm.h: Adjust decls to match defn changes elsewhere.
1163 (struct scroll_bar): Use struct vectorlike_header
1164 rather than rolling our own approximation.
1165 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1166
1167 2012-05-25 Glenn Morris <rgm@gnu.org>
1168
1169 * lisp.mk (lisp): Update for more files being compiled now.
1170
1171 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1172
1173 * lread.c: Remove `read_pure' which makes no difference.
1174 (read_pure): Remove var.
1175 (unreadpure): Remove function.
1176 (readevalloop): Don't call read_list with -1 flag.
1177 (read1, read_vector): Don't test read_pure any more.
1178 (read_list): Simplify.
1179
1180 * fileio.c, character.h: Minor style tweaks.
1181
1182 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1183
1184 * window.h (clip_changed): Remove useless declaration.
1185
1186 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1187
1188 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1189 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1190
1191 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1192
1193 Remove src/m/*.
1194 This directory predates autoconf and is no longer needed nowadays.
1195 Move its few remaining bits of functionality to where they're needed.
1196 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1197 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1198 * m/template.h: Remove.
1199 * Makefile.in (M_FILE): Remove. All uses removed.
1200 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1201 * lisp.h (USE_LSB_TAG):
1202 * mem-limits.h (EXCEEDS_LISP_PTR):
1203 Use VAL_MAX, not VALBITS, in #if.
1204 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1205 (EMACS_UINT): Define unconditionally now.
1206 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1207 (BITS_PER_EMACS_INT): New constants, replacing
1208 what used to be in config.h, but not useful in #if.
1209 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1210 define them any more.
1211 (VAL_MAX): New macro.
1212 (VALMASK): Use it.
1213 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1214 BITS_PER_EMACS_INT, in #if.
1215 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1216 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1217 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1218 * s/ms-w32.h (DATA_START):
1219 Move here from removed file m/intel386.h.
1220 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1221 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1222
1223 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1224
1225 Assume C89 or later.
1226 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1227 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1228 (xrealloc):
1229 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1230 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1231 * textprop.c, tparam.c (NULL): Remove.
1232 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1233 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1234 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1235 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1236 * xterm.c (input_signal_count): Assume volatile works.
1237
1238 2012-05-21 Ken Brown <kbrown@cornell.edu>
1239
1240 * xgselect.c (xg_select): Fix first argument in call to 'select'
1241 (bug#11508).
1242
1243 2012-05-20 Ken Brown <kbrown@cornell.edu>
1244
1245 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1246 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1247
1248 2012-05-19 Ken Brown <kbrown@cornell.edu>
1249
1250 * xfns.c (x_in_use): Remove `static' qualifier.
1251 * xterm.h (x_in_use): Declare.
1252 * xgselect.c: Include xterm.h.
1253 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1254 and `display_arg' (bug#9754).
1255
1256 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1257
1258 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1259
1260 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1261 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1262
1263 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1264
1265 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1266
1267 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1268 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1269
1270 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1271 reference to image_cache->refcount.
1272 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1273
1274 2012-05-17 Juri Linkov <juri@jurta.org>
1275
1276 * search.c (Fword_search_regexp, Fword_search_backward)
1277 (Fword_search_forward, Fword_search_backward_lax)
1278 (Fword_search_forward_lax): Move functions to isearch.el
1279 (bug#10145, bug#11381).
1280
1281 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1282
1283 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1284
1285 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1286
1287 * lread.c (init_obarray): Declare Qt and Qnil as special.
1288
1289 2012-05-14 Glenn Morris <rgm@gnu.org>
1290
1291 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1292 Put "libexec" before "bin", for the sake of init_callproc_1.
1293
1294 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1295
1296 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1297
1298 * unexaix.c: Port to more-recent AIX compilers.
1299 (report_error, report_error_1, make_hdr, copy_sym)
1300 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1301 Make arguments const char *, not char *, to avoid violations of C
1302 standard and to fix some AIX warnings reported by Gilles Pion.
1303
1304 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1305
1306 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1307 already have overlays loaded.
1308 (handle_single_display_spec): Before returning without displaying
1309 fringe bitmap, synchronize the bidi iterator with the main display
1310 iterator, by calling iterate_out_of_display_property.
1311 (iterate_out_of_display_property): Detect buffer iteration by
1312 testing that it->string is a Lisp string.
1313 (get_next_display_element): When the current object is exhausted,
1314 and there's something on it->stack, call set_iterator_to_next to
1315 proceed with what's on the stack, instead of returning zero.
1316 (set_iterator_to_next): If called at the end of a Lisp string,
1317 proceed to consider_string_end without incrementing string
1318 position. Don't increment display vector index past the end of
1319 the display vector. (Bug#11417)
1320 (pos_visible_p): Don't report a position visible when move_it_to
1321 stopped at the last line of window, which happens to be scanned
1322 backwards by the bidi iteration. (Bug#11464)
1323
1324 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1325
1326 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1327 and right-margin display specs even if the spec is invalid or we
1328 are on a TTY, and thus unable to display on the fringes.
1329 That's because the text with the property will not be displayed anyway,
1330 so we need to signal to the caller that this is a "replacing"
1331 display spec. This fixes display when the spec is invalid or we
1332 are on a TTY.
1333
1334 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1335
1336 * unexaix.c (make_hdr): Fix typo in prototype.
1337 This bug broke the build on AIX. Problem reported by Gilles Pion.
1338
1339 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1340
1341 * keyboard.c (kbd_buffer_get_event): Read special events also in
1342 batch mode. (Bug#11415)
1343
1344 2012-05-12 Glenn Morris <rgm@gnu.org>
1345
1346 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1347
1348 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1349
1350 * lisp.mk (lisp): Add newcomment.elc.
1351
1352 2012-05-12 Glenn Morris <rgm@gnu.org>
1353
1354 * Makefile.in (MKDIR_P): New, set by configure.
1355 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1356
1357 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1358
1359 Remove unused function hourglass_started.
1360 * dispextern.h (hourglass_started):
1361 * w32fns.c (hourglass_started):
1362 * xdisp.c (hourglass_started): Remove.
1363
1364 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1365
1366 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1367 Update dependencies.
1368
1369 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1370
1371 * xgselect.c (xg_select): Put maxfds+1 into a var.
1372 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1373
1374 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1375
1376 2012-05-10 Dave Abrahams <dave@boostpro.com>
1377
1378 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1379 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1380
1381 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1382
1383 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1384 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1385 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1386 Initialize xd_registered_buses.
1387
1388 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1389
1390 Untag more efficiently if USE_LSB_TAG.
1391 This is based on a proposal by YAMAMOTO Mitsuharu in
1392 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1393 For an admittedly artificial (nth 8000 longlist) benchmark on
1394 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1395 Emacs's overall text size by 1%.
1396 * lisp.h (XUNTAG): New macro.
1397 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1398 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1399 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1400 * eval.c (Fautoload):
1401 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1402 * frame.h (XFRAME): Use XUNTAG.
1403
1404 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1405 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1406 Remove unportable assumptions about print widths of types like
1407 dbus_uint32_t.
1408 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1409 intptr_t when converting between pointer and integer, to avoid GCC
1410 warnings about wrong width.
1411
1412 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1413
1414 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1415 stack for each reader_thread, instead of defaulting to 8MB
1416 determined by the linker. This avoids failures in creating
1417 subprocesses on Windows 7, see the discussion in this thread:
1418 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1419
1420 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1421
1422 Fix up display of the *Minibuf-0* buffer in the mini window.
1423 * keyboard.c (read_char): Don't clear the echo area if there's no
1424 message to clear.
1425 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1426 contents of *Minibuf-0*) if there's no message displayed in its stead.
1427
1428 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1429
1430 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1431 batch mode.
1432
1433 2012-05-06 Chong Yidong <cyd@gnu.org>
1434
1435 * lisp.mk (lisp): Update.
1436
1437 2012-05-05 Jim Meyering <meyering@redhat.com>
1438
1439 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1440
1441 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1442
1443 * data.c (PUT_ERROR): New macro.
1444 (syms_of_data): Use it. Add new error type `user-error'.
1445 * undo.c (user_error): New function.
1446 (Fprimitive_undo): Use it.
1447 * print.c (print_error_message): Adjust print style for `user-error'.
1448 * keyboard.c (user_error): New function.
1449 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1450
1451 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1452
1453 Do not limit current-time-string to years 1000..9999.
1454 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1455 (Fcurrent_time_string): Support any year that is supported by the
1456 underlying localtime representation. Don't use asctime, as it
1457 has undefined behavior for years outside the range -999..9999.
1458
1459 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1460
1461 Fix race conditions involving setenv, gmtime, localtime, asctime.
1462 Without this fix, interrupts could mess up code that uses these
1463 nonreentrant functions, since setting TZ invalidates existing
1464 tm_zone or tzname values, and since most of these functions return
1465 pointers to static storage.
1466 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1467 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1468 Grow the critical sections to include not just invoking
1469 localtime/gmtime, but also accessing these functions' results
1470 including their tm_zone values if any, and any related TZ setting.
1471 (format_time_string): Last arg is now struct tm *, not struct tm **,
1472 so that the struct tm is saved in the critical section.
1473 All callers changed. Simplify allocation of initial buffer, partly
1474 motivated by the fact that memory allocation needs to be outside
1475 the critical section.
1476
1477 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1478
1479 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1480 with RESET_INTERVAL.
1481
1482 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1483 Remove duplicated buffer name initialization.
1484
1485 2012-05-02 Jim Meyering <jim@meyering.net>
1486
1487 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1488
1489 * xfns.c (x_window): Use xstrdup (Bug#11375).
1490
1491 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1492
1493 * xdisp.c (pos_visible_p): If already at a newline from the
1494 display string before the 'while' loop, don't walk back the glyphs
1495 from it3.glyph_row. Solves assertion violation when the display
1496 string begins with a newline (egg.el). (Bug#11367)
1497
1498 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1499
1500 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1501 Move to simple.el.
1502
1503 2012-05-01 Glenn Morris <rgm@gnu.org>
1504
1505 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1506 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1507 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1508 All were removed before 23.1.
1509
1510 * dispnew.c: Remove HAVE_LIBNCURSES test;
1511 it is always true on relevant platforms.
1512
1513 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1514 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1515
1516 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1517
1518 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1519
1520 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1521 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1522 Remove.
1523
1524 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1525
1526 Do not avoid creating empty evaporating overlays (Bug#9642).
1527 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1528 That is, do not delete an evaporating overlay if it becomes
1529 empty after its bounds are adjusted to fit within its buffer.
1530 This fix caused other problems, and I'm reverting it until we get
1531 to the bottom of them.
1532
1533 2012-04-27 Chong Yidong <cyd@gnu.org>
1534
1535 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1536
1537 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1538
1539 * xdisp.c (pos_visible_p): If the window start position is beyond
1540 ZV, start the display from buffer beginning. Prevents assertion
1541 violation in init_iterator when the minibuffer window is scrolled
1542 via the scroll bar.
1543
1544 * window.c (window_scroll_pixel_based): Likewise.
1545
1546 2012-04-27 Chong Yidong <cyd@gnu.org>
1547
1548 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1549
1550 2012-04-27 Glenn Morris <rgm@gnu.org>
1551
1552 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1553 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1554
1555 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1556
1557 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1558 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1559
1560 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1561
1562 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1563 display element, check also the underlying string or buffer
1564 character. (Bug#11341)
1565
1566 * w32menu.c: Include w32heap.h.
1567 (add_menu_item): If the call to AppendMenuW (via
1568 unicode_append_menu) fails, disable Unicode menus only if we are
1569 running on Windows 9X/Me.
1570
1571 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1572
1573 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1574 (xgetint): Add missing shift for LSB tags.
1575
1576 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1577
1578 * keyboard.c (read_char): Don't wipe echo area for select window
1579 events: These might get delayed via `mouse-autoselect-window'
1580 (Bug#11304).
1581
1582 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1583
1584 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1585 manipulation of :loaded-from data.
1586
1587 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1588
1589 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1590 now a cons (bug#11311).
1591
1592 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1593
1594 Do not create empty overlays with the evaporate property (Bug#9642).
1595 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1596 if it becomes empty after its bounds are adjusted to fit within
1597 its buffer. Without this fix, in a nonempty buffer (let ((o
1598 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1599 yields an empty overlay that has the evaporate property, which is
1600 not supposed to happen.
1601
1602 Fix minor GTK3 problems found by static checking.
1603 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1604 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1605 (struct _EmacsFixedClass, emacs_fixed_get_type):
1606 Move decls here from emacsgtkfixed.h, since they needn't be public.
1607 (emacs_fixed_get_type): Now static.
1608 (emacs_fixed_class_init): Omit unused local.
1609 (emacs_fixed_child_type): Remove; unused.
1610 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1611 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1612 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1613 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1614 (EMACS_FIXED_GET_CLASS): Remove; unused.
1615 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1616
1617 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1618 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1619
1620 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1621
1622 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1623 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1624 (__malloc_size_t, __malloc_ptrdiff_t):
1625 Remove. All uses removed, replaced by the definiens if needed,
1626 since we can assume C89 or better now.
1627 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1628 (protect_malloc_state, align, get_contiguous_space)
1629 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1630 (malloc_atfork_handler_child, malloc_enable_thread)
1631 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1632 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1633 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1634 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1635 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1636 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1637 Define using prototypes, not old style.
1638 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1639 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1640 (align): Don't assume that signed integer overflow wraps around.
1641 Omit unused local var.
1642 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1643 (_free_internal_nolock, memalign, mallochook, reallochook):
1644 Omit no-longer-needed casts.
1645 (valloc): Use getpagesize, not __getpagesize.
1646 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1647 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1648
1649 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1650
1651 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1652
1653 Move functions from C to Lisp. Make non-blocking method calls
1654 the default. Implement further D-Bus standard interfaces.
1655
1656 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1657 (QCdbus_request_name_allow_replacement)
1658 (QCdbus_request_name_replace_existing)
1659 (QCdbus_request_name_do_not_queue)
1660 (QCdbus_request_name_reply_primary_owner)
1661 (QCdbus_request_name_reply_in_queue)
1662 (QCdbus_request_name_reply_exists)
1663 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1664 (QCdbus_registered_serial, QCdbus_registered_method)
1665 (QCdbus_registered_signal): New Lisp objects.
1666 (XD_DEBUG_MESSAGE): Use sizeof.
1667 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1668 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1669 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1670 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1671 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1672 (xd_signature, xd_append_arg): Allow float for integer types.
1673 (xd_get_connection_references): New function.
1674 (xd_get_connection_address): Rename from xd_initialize.
1675 Return cached address.
1676 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1677 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1678 level.
1679 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1680 Return number of refcounts.
1681 (Fdbus_get_unique_name): Make stronger parameter check.
1682 (Fdbus_message_internal): New defun.
1683 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1684 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1685 (Fdbus_send_signal, Fdbus_register_service)
1686 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1687 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1688 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1689 (Vdbus_compiled_version, Vdbus_runtime_version)
1690 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1691 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1692 (Vdbus_message_type_signal): New defvars.
1693 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1694 Adapt docstring.
1695
1696 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1697
1698 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1699 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1700 Do not assume ptrdiff_t is the same width as 'int'.
1701
1702 * alloc.c: Handle unusual debugging option combinations.
1703 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1704 since the two debugging options are incompatible.
1705 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1706 is defined.
1707 (mem_init, mem_insert, mem_insert_fixup):
1708 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1709 (NEED_MEM_INSERT): Remove; no longer needed.
1710
1711 2012-04-22 Leo Liu <sdl.web@gmail.com>
1712
1713 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1714
1715 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1716
1717 * sysdep.c [__FreeBSD__]: Minor cleanups.
1718 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1719 Use Emacs indenting style more consistently. Avoid some casts.
1720 Use 'double' consistently rather than mixing 'float' and 'double'.
1721
1722 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1723
1724 * sysdep.c (list_system_processes, system_process_attributes):
1725 Add implementation for FreeBSD (Bug#5243).
1726
1727 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1728
1729 * lisp.mk (lisp): Update.
1730
1731 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1732
1733 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1734 It is never used otherwise.
1735
1736 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1737
1738 * print.c (print_preprocess): Only check print_depth if print-circle
1739 is nil.
1740 (print_object): Check for cycles even when print-circle is nil and
1741 print-gensym is t, but only check print_depth if print-circle is nil.
1742
1743 2012-04-20 Chong Yidong <cyd@gnu.org>
1744
1745 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1746 set the status to "failed" and ensure that sentinel is run.
1747
1748 2012-04-20 Glenn Morris <rgm@gnu.org>
1749
1750 * process.c (Fset_process_inherit_coding_system_flag)
1751 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1752 (Fmake_network_process, Fmake_serial_process): Doc fix.
1753
1754 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1755
1756 * xdisp.c (string_buffer_position_lim): Limit starting position to
1757 BEGV.
1758 (set_cursor_from_row): If called for a mode-line or header-line
1759 row, return zero immediately.
1760 (try_cursor_movement): If inside continuation line, don't back up
1761 farther than the first row after the header line, if any.
1762 Don't consider the header-line row as "partially visible", even if
1763 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1764
1765 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1766
1767 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1768 (bug#11238).
1769
1770 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1771 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 configure: new option --enable-gcc-warnings (Bug#11207)
1774 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1775 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1776 (ALL_CFLAGS): Use new macros rather than old.
1777 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1778 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1779 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1780 -Wunused-result, -Wunused-variable. This should go away once
1781 the Emacs and Gnulib regex code is merged.
1782 (xmalloc, xrealloc): Now static.
1783
1784 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1785
1786 * dired.c (Fsystem_groups): Remove unused local.
1787
1788 2012-04-17 Glenn Morris <rgm@gnu.org>
1789
1790 * dired.c (Fsystem_users): Doc fix.
1791
1792 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1793
1794 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1795 (syms_of_dired): Add them.
1796
1797 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1798
1799 Fix minor alloc.c problems found by static checking.
1800 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1801 New extern decls, to avoid calling undeclared functions.
1802 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1803 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1804 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1805 (NEED_MEM_INSERT): New macro.
1806 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1807 Remove one incorrect comment and fix another.
1808
1809 Fix minor ralloc.c problems found by static checking.
1810 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1811 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1812 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1813 (r_alloc_sbrk): Now static.
1814
1815 Improve ralloc.c interface checking.
1816 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1817 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1818 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1819 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1820 [REL_ALLOC]: ... to here, to check interface.
1821 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1822 Remove decls. This fixes an "It stinks!".
1823
1824 * alloc.c (which_symbols): Fix alignment issue / type clash.
1825
1826 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1827
1828 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1829 (struct Lisp_Misc_Any): Likewise.
1830 (struct Lisp_Free): Likewise.
1831 * alloc.c (union aligned_Lisp_Symbol): Define.
1832 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1833 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1834 (union aligned_Lisp_Misc): Define.
1835 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1836 aligned_Lisp_Misc instead of union Lisp_Misc.
1837 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1838
1839 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1842 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1843 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1844 * s/netbsd.h, s/sol2-6.h:
1845 Remove definition of GC_MARK_STACK, since the default now works.
1846 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1847 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1848 no longer the default.
1849 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1850
1851 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1852
1853 * lread.c (lisp_file_lexically_bound_p):
1854 Fix hang at ";-*-\n" (bug#11238).
1855
1856 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1857
1858 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1859 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1860
1861 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1862
1863 * nsterm.m (constrainFrameRect): Always constrain when there is only
1864 one screen (Bug#10962).
1865
1866 2012-04-13 Ken Brown <kbrown@cornell.edu>
1867
1868 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1869
1870 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1871
1872 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1873
1874 2012-04-11 Daniel Colascione <dancol@dancol.org>
1875
1876 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1877 against is gone. It's better to use vfork now so that when Cygwin
1878 gains a new, working vfork, we use it automatically (bug#10398).
1879
1880 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1881
1882 * window.c (save_window_save): Obey window-point-insertion-type.
1883
1884 2012-04-11 Glenn Morris <rgm@gnu.org>
1885
1886 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1887
1888 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1889
1890 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1891
1892 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1893
1894 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1895 (force_quit_count): New var.
1896 (handle_interrupt): Use it.
1897
1898 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1899
1900 * w32.c (w32_delayed_load): Record the full path of the library
1901 being loaded (bug#10424).
1902
1903 2012-04-09 Glenn Morris <rgm@gnu.org>
1904
1905 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1906 not just in the obarray, before snarfing them. (Bug#11036)
1907
1908 * Makefile.in ($(leimdir)/leim-list.el):
1909 Pass EMACS rather than BUILT_EMACS.
1910
1911 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1912
1913 * process.c (make_process):
1914 * process.h: Add integer `gnutls_handshakes_tried' member to
1915 process struct.
1916
1917 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1918 Add convenience `GNUTLS_LOG2i' macro.
1919
1920 * gnutls.c (gnutls_log_function2i): Convenience log function.
1921 (emacs_gnutls_read): Use new log functions,
1922 `gnutls_handshakes_tried' process member, and
1923 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1924 attempts per process (connection).
1925
1926 2012-04-09 Chong Yidong <cyd@gnu.org>
1927
1928 * eval.c (Fuser_variable_p, user_variable_p_eh)
1929 (lisp_indirect_variable): Functions deleted.
1930 (Fdefvar): Caller changed.
1931
1932 * callint.c (Finteractive, Fcall_interactively):
1933 * minibuf.c (Fread_variable): Callers changed.
1934
1935 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1936
1937 * xdisp.c (set_cursor_from_row): If the display string appears in
1938 the buffer at position that is closer to point than the position
1939 after the display string, display the cursor on the first glyph of
1940 the display string. Fixes cursor display when a 'display' text
1941 property immediately follows invisible text. (Bug#11094)
1942
1943 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1944
1945 composite.c: use 'double' consistently
1946 * composite.c (get_composition_id): Use 'double' consistently
1947 instead of converting 'float' to 'double' and vice versa; this is
1948 easier to understand and avoids a GCC warning.
1949
1950 2012-04-09 Glenn Morris <rgm@gnu.org>
1951
1952 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1953 preparation for dumping it with emacs. (Bug#4789)
1954 (leimdir): New variable.
1955 ($(leimdir)/leim-list.el): New rule.
1956 (emacs$(EXEEXT)): Depend on leim-list.el.
1957
1958 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1959 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1960 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1961
1962 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1963
1964 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1965 proper alignment.
1966
1967 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1968
1969 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1970 Remove unused local variable.
1971
1972 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1975 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1976 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1977 objects, as mark_maybe_pointer will catch them otherwise.
1978 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1979 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1980
1981 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1982
1983 Fix typo that broke non-Windows builds.
1984 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1985
1986 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1987
1988 Support building on MS-Windows with libxml2.
1989
1990 * makefile.w32-in (OBJ2): Add xml.$(O).
1991 (GLOBAL_SOURCES): Add xml.c.
1992 ($(BLD)/xml.$(O)): New dependency list.
1993
1994 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1995 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1996 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1997 [!WINDOWSNT]: New macros.
1998 (init_libxml2_functions, libxml2_loaded_p): New functions.
1999 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2000 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2001 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2002 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2003 linked in).
2004 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2005 Call init_libxml2_functions before calling libxml2 functions.
2006 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2007
2008 * emacs.c: Don't include libxml/parser.h.
2009 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2010 xmlCleanupParser directly.
2011
2012 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2013
2014 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2015
2016 * indent.c (Fvertical_motion): If there is a display string at
2017 point, use it.vpos to compute how many lines to backtrack after
2018 move_it_to point. (Bug#11133)
2019
2020 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2021
2022 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2023 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2024 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2025 macros related to unification of CJK characters. For the details,
2026 see the discussion following the message here:
2027 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2028
2029 2012-04-04 Chong Yidong <cyd@gnu.org>
2030
2031 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2032
2033 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2034
2035 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2036 instead of alloca. (Bug#11138)
2037
2038 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2039
2040 * w32menu.c (is_simple_dialog): Properly check lisp types.
2041 (Bug#11141)
2042
2043 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2044
2045 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2046 position we get to after a call to move_it_to fails the
2047 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2048 only if we wind up in a string from display property. (Bug#11063)
2049
2050 * window.c (Fdelete_other_windows_internal): Invalidate the row
2051 and column information about mouse highlight, so that redisplay
2052 restores it after reallocating the glyph matrices. (Bug#7464)
2053
2054 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2055 string comes from a `display' text property, use the buffer
2056 position of that property as if we actually saw that position in
2057 the row's glyphs.
2058 (move_it_by_lines): Remove the assertion that
2059 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2060 violated when there's a before-string at the beginning of a line.
2061 (Bug#11063)
2062
2063 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2064
2065 * xdisp.c (append_space_for_newline): If the default face was
2066 remapped, use the remapped face for the appended newline.
2067 (extend_face_to_end_of_line): Use the remapped default face for
2068 extending the face to the end of the line.
2069 (display_line): Call extend_face_to_end_of_line when the default
2070 face was remapped. (Bug#11068)
2071
2072 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2073
2074 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2075
2076 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2077
2078 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2079
2080 2012-03-27 Glenn Morris <rgm@gnu.org>
2081
2082 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2083 Doc fixes.
2084
2085 2012-03-26 Kenichi Handa <handa@m17n.org>
2086
2087 * dispextern.h (struct glyph): Fix previous change. Change the
2088 bit length of glyphless.ch to 25 (Bug#11082).
2089
2090 2012-03-26 Chong Yidong <cyd@gnu.org>
2091
2092 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2093 (command_loop_1): Use it; inhibit selection update for
2094 handle-select-window too (Bug#8996).
2095
2096 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2097
2098 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2099
2100 2012-03-25 Kenichi Handa <handa@m17n.org>
2101
2102 * dispextern.h (struct glyph): Change the bit length of
2103 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2104
2105 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2106
2107 * s/ms-w32.h (tzname): Include time.h before redirecting to
2108 _tzname. Fixes the MSVC build. (Bug#9960)
2109
2110 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2111
2112 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2113 characters.
2114
2115 * xterm.c (XTread_socket): Only modify handling_signal if
2116 !SYNC_INPUT. (Bug#11080)
2117
2118 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2119
2120 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2121 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2122 when fetching a multibyte character consumes more bytes than
2123 CHAR_BYTES returns, due to unification of CJK characters in
2124 string_char. (Bug#11073)
2125
2126 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2127
2128 * process.c (wait_reading_process_output): Handle pty disconnect
2129 by refraining from sending oneself a SIGCHLD (bug#10933).
2130
2131 2012-03-22 Chong Yidong <cyd@gnu.org>
2132
2133 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2134
2135 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2136 Mark string as coming from a prefix property.
2137 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2138 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2139
2140 2012-03-21 Chong Yidong <cyd@gnu.org>
2141
2142 * xfaces.c (Vface_remapping_alist): Doc fix.
2143
2144 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2145
2146 * w32proc.c (Fw32_set_console_codepage)
2147 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2148 Doc fixes.
2149
2150 2012-03-20 Chong Yidong <cyd@gnu.org>
2151
2152 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2153 to reflect default non-nil value of redisplay-dont-pause.
2154
2155 2012-03-19 Kenichi Handa <handa@m17n.org>
2156
2157 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2158 it fit in a valid range (Bug#11003).
2159
2160 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2161
2162 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2163 that is not from display property, accept the row as a "cursor
2164 row" if one of the string's character has a non-nil `cursor'
2165 property. Fixes cursor positioning when there are newlines in
2166 overlay strings, e.g. in icomplete.el. (Bug#11035)
2167
2168 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2169
2170 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2171
2172 2012-03-12 Chong Yidong <cyd@gnu.org>
2173
2174 * eval.c (inhibit_lisp_code): Rename from
2175 inhibit_window_configuration_change_hook; move from window.c.
2176
2177 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2178 * window.c (run_window_configuration_change_hook)
2179 (syms_of_window): Callers changed.
2180
2181 2012-03-11 Chong Yidong <cyd@gnu.org>
2182
2183 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2184
2185 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2186
2187 2012-03-10 Chong Yidong <cyd@gnu.org>
2188
2189 * frame.c (other_visible_frames): Don't assume the selected frame
2190 is visible (Bug#10955).
2191
2192 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2193
2194 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2195
2196 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2197
2198 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2199 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2200 zero (Bug#10954).
2201
2202 2012-03-03 Glenn Morris <rgm@gnu.org>
2203
2204 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2205
2206 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2207
2208 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2209 position past the first glyph_row that ends at ZV. (Bug#10902)
2210 (redisplay_window, next_element_from_string): Fix typos in
2211 comments.
2212 (redisplay_window): Pass to move_it_vertically the margin in
2213 pixels, not in screen lines.
2214
2215 2012-03-02 Glenn Morris <rgm@gnu.org>
2216
2217 * buffer.c (buffer-list-update-hook): Doc fix.
2218
2219 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2220
2221 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2222 push_it before setting up the iterator for the first overlay
2223 string, even if we have an empty string loaded.
2224 (next_overlay_string): If there's an empty string on the iterator
2225 stack, pop the stack. (Bug#10903)
2226
2227 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2228
2229 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2230 Suggested by Stefan Monnier in
2231 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2232 * alloc.c (widen_to_Lisp_Object): New static function.
2233 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2234 and widening them to Lisp_Objects. This would work even if
2235 USE_LSB_TAG is defined and wide integers are used, which might
2236 happen in a future version of Emacs.
2237
2238 2012-02-25 Chong Yidong <cyd@gnu.org>
2239
2240 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2241 Doc fix.
2242
2243 * xselect.c (Fx_selection_exists_p): Doc fix.
2244 (x_clipboard_manager_save_all): Print an informative message
2245 before saving to clipboard manager.
2246
2247 2012-02-24 Chong Yidong <cyd@gnu.org>
2248
2249 * keyboard.c (process_special_events): Handle all X selection
2250 requests in kbd_buffer, not just the next one (Bug#8869).
2251
2252 2012-02-23 Chong Yidong <cyd@gnu.org>
2253
2254 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2255 call when setting menu-bar-lines and tool-bar-lines parameters.
2256 (unwind_create_frame_1): New helper function.
2257
2258 * window.c (inhibit_window_configuration_change_hook): New var.
2259 (run_window_configuration_change_hook): Obey it.
2260 (syms_of_window): Initialize it.
2261
2262 2012-02-22 Chong Yidong <cyd@gnu.org>
2263
2264 * xterm.c (x_draw_image_relief): Add missing type check for
2265 Vtool_bar_button_margin (Bug#10743).
2266
2267 2012-02-21 Chong Yidong <cyd@gnu.org>
2268
2269 * fileio.c (Vfile_name_handler_alist): Doc fix.
2270
2271 * buffer.c (Fget_file_buffer): Protect against invalid file
2272 handler return value.
2273
2274 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2275
2276 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2277 when computing $valmask.
2278
2279 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2280 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2281 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2282 It's useless in that case, and it can cause problems on hosts
2283 that allocate halves of EMACS_INT values separately.
2284 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2285 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2286 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2287 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2288 it avoids undefined behavior on hosts where shifting right by more
2289 than the word width has undefined behavior.
2290
2291 2012-02-19 Chong Yidong <cyd@gnu.org>
2292
2293 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2294 (Funhandled_file_name_directory, Ffile_name_as_directory)
2295 (Fdirectory_file_name, Fexpand_file_name)
2296 (Fsubstitute_in_file_name): Protect against invalid file handler
2297 return values (Bug#10845).
2298
2299 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2300
2301 * .gdbinit (pitx): Fix incorrect references to fields of the
2302 iterator stack.
2303
2304 2012-02-17 Chong Yidong <cyd@gnu.org>
2305
2306 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2307
2308 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2309
2310 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2311 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2312
2313 2012-02-15 Chong Yidong <cyd@gnu.org>
2314
2315 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2316 marked as special. Also, starting docstrings with * is obsolete.
2317
2318 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2319
2320 * gnutls.c (emacs_gnutls_write): Fix last change.
2321
2322 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2323
2324 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2325 send_process.
2326
2327 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2328
2329 * keymap.c (Fsingle_key_description): Handle char ranges.
2330
2331 2012-02-12 Chong Yidong <cyd@gnu.org>
2332
2333 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2334 as that creates a dangerous corner case.
2335
2336 * window.c (Fdelete_window_internal): Invalidate the mouse
2337 highlight (Bug#9904).
2338
2339 2012-02-12 Glenn Morris <rgm@gnu.org>
2340
2341 * xselect.c (Fx_own_selection_internal)
2342 (Fx_get_selection_internal, Fx_disown_selection_internal)
2343 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2344 * nsselect.m (Fx_own_selection_internal)
2345 (Fx_disown_selection_internal, Fx_selection_exists_p)
2346 (Fx_selection_owner_p, Fx_get_selection_internal):
2347 Sync docs and argument specs with the xselect.c versions.
2348
2349 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2350
2351 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2352
2353 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2354
2355 * w32select.c (Fx_selection_exists_p): Sync doc string and
2356 argument list with xselect.c. (Bug#10783)
2357
2358 * w16select.c (Fx_selection_exists_p): Sync doc string and
2359 argument list with xselect.c. (Bug#10783)
2360
2361 2012-02-10 Glenn Morris <rgm@gnu.org>
2362
2363 * fns.c (Fsecure_hash): Doc fix.
2364
2365 2012-02-09 Kenichi Handa <handa@m17n.org>
2366
2367 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2368
2369 2012-02-07 Chong Yidong <cyd@gnu.org>
2370
2371 * buffer.c (Fbuffer_local_variables)
2372 (buffer_lisp_local_variables): Handle unbound vars correctly;
2373 don't let Qunbound leak into Lisp.
2374
2375 2012-02-07 Glenn Morris <rgm@gnu.org>
2376
2377 * image.c (Fimagemagick_types): Doc fix.
2378
2379 * image.c (imagemagick-render-type): Change it from a lisp object
2380 to an integer. Move the doc here from the lisp manual.
2381 Treat all values not equal to 0 the same.
2382
2383 2012-02-06 Chong Yidong <cyd@gnu.org>
2384
2385 * doc.c (store_function_docstring): Avoid applying docstring of
2386 alias to base function (Bug#2603).
2387
2388 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2389
2390 * .gdbinit (pp1, pv1): Remove redundant defines.
2391 (pr): Use pp.
2392
2393 2012-02-04 Chong Yidong <cyd@gnu.org>
2394
2395 * nsterm.m: Declare a global (Bug#10694).
2396
2397 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2398
2399 * w32.c (get_emacs_configuration_options):
2400 Include --enable-checking, if specified, in the return value.
2401
2402 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2403
2404 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2405 after rounding frame sizes. (Bug#9723)
2406
2407 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2408
2409 * keyboard.c (adjust_point_for_property): Don't position point
2410 before BEGV. (Bug#10696)
2411
2412 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2413
2414 Handle overflow when computing char display width (Bug#9496).
2415 * character.c (char_width): Return EMACS_INT, not int.
2416 (char_width, c_string_width): Check for overflow when
2417 computing the width; this is possible now that individual
2418 characters can have unbounded width. Problem introduced
2419 by merge from Emacs 23 on 2012-01-19.
2420
2421 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2422
2423 * dbusbind.c (Fdbus_register_method): Mention the return value
2424 :ignore in the docstring.
2425
2426 2012-02-02 Glenn Morris <rgm@gnu.org>
2427
2428 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2429
2430 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2431 Unconditionally set to t. (Bug#10673)
2432 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2433 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2434 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2435
2436 2012-02-02 Kenichi Handa <handa@m17n.org>
2437
2438 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2439 0, do not call append_composite_glyph.
2440
2441 2012-02-02 Kenichi Handa <handa@m17n.org>
2442
2443 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2444 NULL (Bug#6988).
2445 (x_produce_glyphs): If the component of a composition is a null
2446 string, set it->pixel_width to 1 to avoid zero-width glyph.
2447
2448 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2449
2450 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2451 first 2 arguments are identical. This makes inserting large
2452 output from a subprocess an order of magnitude faster on
2453 MS-Windows, where all sbrk'ed memory is always contiguous.
2454
2455 2012-01-31 Glenn Morris <rgm@gnu.org>
2456
2457 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2458 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2459 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2460
2461 2012-01-29 Glenn Morris <rgm@gnu.org>
2462
2463 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2464
2465 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2466
2467 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2468
2469 2012-01-28 Chong Yidong <cyd@gnu.org>
2470
2471 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2472
2473 2012-01-26 Chong Yidong <cyd@gnu.org>
2474
2475 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2476
2477 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2478 repeat counts (Bug#10507).
2479
2480 2012-01-26 Glenn Morris <rgm@gnu.org>
2481
2482 * lread.c (syms_of_lread): Doc fix.
2483
2484 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2485
2486 * coding.c (encode_designation_at_bol): Change return value to
2487 EMACS_INT.
2488
2489 2012-01-25 Chong Yidong <cyd@gnu.org>
2490
2491 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2492
2493 2012-01-21 Chong Yidong <cyd@gnu.org>
2494
2495 * floatfns.c (Fcopysign): Make the second argument non-optional,
2496 since nil is not allowed anyway.
2497
2498 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2499
2500 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2501 (send_process): Likewise.
2502
2503 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2504
2505 * window.c (save_window_save, Fcurrent_window_configuration)
2506 (Vwindow_persistent_parameters): Do not use Qstate.
2507 Rewrite doc-strings.
2508
2509 2012-01-19 Kenichi Handa <handa@m17n.org>
2510
2511 * character.c (char_width): New function.
2512 (Fchar_width, c_string_width, lisp_string_width):
2513 Use char_width (Bug#9496).
2514
2515 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2516
2517 * window.c (Vwindow_persistent_parameters): New variable.
2518 (Fset_window_configuration, save_window_save): Handle persistent
2519 window parameters.
2520
2521 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2522
2523 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2524 thrashing the stack of the thread. (Bug#9087)
2525
2526 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2527
2528 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2529
2530 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2531
2532 * xdisp.c (rows_from_pos_range): Handle the case where the
2533 highlight ends on a newline. (Bug#10464)
2534 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2535 he end column for display of highlight that ends on a newline
2536 before a R2L line.
2537
2538 2012-01-11 Glenn Morris <rgm@gnu.org>
2539
2540 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2541 from load-path also when installation-directory is nil. (Bug#10208)
2542
2543 2012-01-10 Glenn Morris <rgm@gnu.org>
2544
2545 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2546
2547 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2548 Update template values to be closer to their typical values these days.
2549
2550 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2551
2552 * xdisp.c (rows_from_pos_range): Accept additional argument
2553 DISP_STRING, and accept any glyph in a row whose object is that
2554 string as eligible for mouse highlight. Fixes mouse highlight of
2555 display strings from overlays. (Bug#10464)
2556
2557 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2558
2559 emacs: fix an auto-save permissions race condition (Bug#10400)
2560 * fileio.c (auto_saving_dir_umask): New static var.
2561 (Fmake_directory_internal): Use it.
2562 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2563 creating the directory. The old code temporarily assigns
2564 too-generous permissions to the directory.
2565 (do_auto_save_eh): Clear it.
2566 (Fdo_auto_save): Catch all errors, not just file errors, so
2567 that the var is always cleared.
2568
2569 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2570
2571 * search.c (scan_buffer): Pass character positions to
2572 know_region_cache, not byte positions. (Bug#6540)
2573
2574 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2575
2576 * w32.c (sys_rename): Report EXDEV when rename of a directory
2577 fails because the target is on another logical disk. (Bug#10284)
2578
2579 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2580
2581 * xterm.c (x_embed_request_focus): New function.
2582
2583 * xterm.h: Add prototype.
2584
2585 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2586
2587 2012-01-05 Glenn Morris <rgm@gnu.org>
2588
2589 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2590
2591 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2592
2593 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2594 Load gnutls_transport_set_lowat only if GnuTLS version is below
2595 2.11.1.
2596 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2597 GnuTLS versions below 2.11.1.
2598
2599 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2600
2601 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2602 to the doc string advising against its use for altering the way
2603 windows are scrolled.
2604
2605 2011-12-28 Kenichi Handa <handa@m17n.org>
2606
2607 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2608 coding-system ASCII compatible only when it does not produce BOM
2609 on encoding (Bug#10383).
2610
2611 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2612
2613 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2614 can scroll.
2615 (create_and_show_popup_menu): Always use menu_position_func for
2616 Gtk3 (Bug#10361).
2617
2618 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2619
2620 * callint.c (Fcall_interactively): Don't truncate prompt string.
2621
2622 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2623
2624 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2625 property that ends at ZV, so that the bidi iteration could be
2626 resumed from there (after widening). (Bug#10360)
2627
2628 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2629
2630 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2631
2632 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2633
2634 * nsterm.m (x_free_frame_resources):
2635 Release f->output_data.ns->miniimage.
2636 (ns_index_color): Fix indentation. Do not retain
2637 color_table->colors[i].
2638
2639 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2640 before returning.
2641
2642 * nsfns.m (x_set_background_color): Assign return value from
2643 ns_index_color to face-background instead of NSColor*.
2644 (ns_implicitly_set_icon_type): Fix indentation.
2645 Change assignment in for loop to comparison.
2646
2647 * emacs.c (ns_pool): New variable.
2648 (main): Assign ns_pool.
2649 (Fkill_emacs): Call ns_release_autorelease_pool.
2650
2651 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2652 autorelease fdesc, release fdAttrs and tdict.
2653 (ns_get_covering_families): Release charset.
2654 (ns_findfonts): Release NSFontDescriptor created with new.
2655 (ns_uni_to_glyphs): Fix indentation.
2656 (setString): Release attrStr before assigning new value.
2657
2658 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2659
2660 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2661 and NS_IMPL_COCOA.
2662 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2663 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2664
2665 2011-12-18 David Reitter <reitter@cmu.edu>
2666
2667 * nsterm.m (ns_term_init): Subscribe for notifications
2668 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2669 to method trackingNotification in EmacsMenu.
2670
2671 * nsmenu.m (trackingMenu): New variable.
2672 (trackingNotification): New method (from Aquamacs).
2673 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2674 from Aquamacs (Bug#7030).
2675
2676 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2677
2678 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2679 (symbol_to_nsstring): Fix indentation.
2680 (ns_symbol_to_pb): New function.
2681 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2682 (Fns_rotate_cut_buffers_internal): Remove.
2683 (Fns_store_selection_internal): Rename from
2684 Fns_store_cut_buffer_internal.
2685 (ns_get_foreign_selection, Fx_own_selection_internal)
2686 (Fx_disown_selection_internal, Fx_selection_exists_p)
2687 (Fns_get_selection_internal, Fns_store_selection_internal):
2688 Use ns_symbol_to_pb and check if return value is nil.
2689 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2690 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2691 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2692 renamed to Sns_store_selection_internal.
2693 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2694 and remove this function.
2695 (ns_handle_selection_clear): Remove, never used.
2696 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2697 here.
2698
2699 2011-12-17 Ken Brown <kbrown@cornell.edu>
2700
2701 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2702 GID is unknown (Bug#10257).
2703
2704 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2705
2706 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2707 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2708 which caused a build failure on GNU/Linux IA-64. This problem was
2709 introduced by my 2011-10-07 patch.
2710
2711 2011-12-15 Juri Linkov <juri@jurta.org>
2712
2713 * image.c (imagemagick_error): New function. (Bug#10112)
2714 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2715 Use `imagemagick_error' where ImageMagick functions return
2716 `MagickFalse'.
2717 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2718 proper order.
2719
2720 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2721
2722 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2723 fill background (Bug#8992).
2724
2725 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2726
2727 * window.c (Vwindow_combination_resize)
2728 (Vwindow_combination_limit): Use t instead of non-nil in
2729 doc-strings.
2730 (Vrecenter_redisplay): Add first sentence of doc-string on
2731 separate line.
2732 (Frecenter): Fix doc-string typo.
2733
2734 2011-12-11 Kenichi Handa <handa@m17n.org>
2735
2736 * coding.c (Funencodable_char_position): Pay attention to the
2737 buffer text relocation (Bug#9389).
2738
2739 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2740
2741 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2742 gtk_init (Bug#10100).
2743
2744 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2745
2746 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2747 IT->string is nil. (Bug#10263)
2748
2749 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2750
2751 * nsterm.h (x_free_frame_resources): Declare.
2752
2753 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2754 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2755
2756 * nsterm.h (ns_get_defaults_value): Declare.
2757
2758 * nsterm.m (ns_default): Call ns_get_defaults_value.
2759
2760 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2761
2762 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2763 (Bug#10170)
2764
2765 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2766
2767 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2768 that where the value of an _OBJC_* symbol points to is in the .bss
2769 section (Bug#10240).
2770
2771 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2772
2773 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2774 after the loop to call ccl_driver at least once (Bug#8619).
2775
2776 2011-12-08 Kenichi Handa <handa@m17n.org>
2777
2778 * ftfont.c (get_adstyle_property): Fix previous change
2779 (Bug#10233).
2780
2781 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2782
2783 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2784 dirs from the default value of EMACSLOADPATH (bug#10208).
2785
2786 2011-12-07 Glenn Morris <rgm@gnu.org>
2787
2788 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2789 installation and source directories as well. (Bug#10208)
2790
2791 2011-12-06 Chong Yidong <cyd@gnu.org>
2792
2793 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2794
2795 2011-12-06 Glenn Morris <rgm@gnu.org>
2796
2797 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2798 as an error, not just -1. (Bug#10217)
2799
2800 2011-12-05 Chong Yidong <cyd@gnu.org>
2801
2802 * keyboard.c (process_special_events): New function.
2803 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2804
2805 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2806
2807 * coding.c (encode_designation_at_bol): Don't use uninitialized
2808 local variable (Bug#9318).
2809
2810 2011-12-05 Kenichi Handa <handa@m17n.org>
2811
2812 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2813 return Qnil (Bug#8046, Bug#10193).
2814
2815 2011-12-05 Kenichi Handa <handa@m17n.org>
2816
2817 * coding.c (encode_designation_at_bol): New args charbuf_end and
2818 dst. Return the number of produced bytes. Callers changed.
2819 (coding_set_source): Return how many bytes coding->source was
2820 relocated.
2821 (coding_set_destination): Return how many bytes
2822 coding->destination was relocated.
2823 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2824 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2825
2826 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2827
2828 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2829 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2830 macro (Bug#9318).
2831
2832 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2833
2834 The following changes are to fix Bug#9318.
2835
2836 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2837 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2838 (encode_coding_iso_2022, encode_coding_sjis)
2839 (encode_coding_big5, encode_coding_charset): Use the above macros.
2840
2841 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2842
2843 * lisp.h (process_quit_flag): Fix external declaration.
2844
2845 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2846
2847 Don't macro-inline non-performance-critical code.
2848 * eval.c (process_quit_flag): New function.
2849 * lisp.h (QUIT): Use it.
2850
2851 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2852
2853 * nsfns.m (get_geometry_from_preferences): New function.
2854 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2855
2856 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2857
2858 * emacs.c (Qkill_emacs): Define.
2859 (syms_of_emacs): Initialize it.
2860 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2861 Qquit_flag to `kill-emacs' instead.
2862 (quit_throw_to_read_char): Add parameter `from_signal'.
2863 All callers changed. Call Fkill_emacs if requested and safe.
2864 * lisp.h (QUIT): Call Fkill_emacs if requested.
2865
2866 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2867
2868 * widget.c (update_wm_hints): Return if wmshell is null.
2869 (widget_update_wm_size_hints): New function.
2870
2871 * widget.h (widget_update_wm_size_hints): Declare.
2872
2873 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2874 widget_update_wm_size_hints (Bug#10104).
2875
2876 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2877
2878 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2879 before a newline, prepare the bidi iterator for consuming the
2880 newline, and keep the current paragraph direction. (Bug#10183)
2881 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2882
2883 2011-12-02 Juri Linkov <juri@jurta.org>
2884
2885 * search.c (Fword_search_regexp): New Lisp function created from
2886 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2887 (Fword_search_backward, Fword_search_forward)
2888 (Fword_search_backward_lax, Fword_search_forward_lax):
2889 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2890 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2891
2892 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2893
2894 * fileio.c (Finsert_file_contents): Move after-change-function call
2895 to before the "handled:" label, since all "goto handled" appear in
2896 cases where the *-change-functions have already been properly called
2897 (bug#10117).
2898
2899 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2900
2901 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2902 waiting for input. (Bug#10169)
2903
2904 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2905
2906 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2907 verifies glyph row's hash code--we have just reallocated the
2908 glyphs, so their contents can be complete garbage. (Bug#10164)
2909
2910 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2911
2912 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2913
2914 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2915
2916 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2917 attributes are tested _before_ calling verify_row_hash, to protect
2918 against GCC re-ordering of the tests. (Bug#10164)
2919
2920 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2921
2922 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2923
2924 * xterm.c (handle_one_xevent): Only set async_visible and friends
2925 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2926 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2927 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2928
2929 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2930
2931 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2932 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2933 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2934 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2935 All uses changed to use GCPRO1 etc.
2936 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2937 Revert to old implementation (i.e., before 2011-03-11).
2938
2939 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2940
2941 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2942 of scroll runs so as to avoid assigning disabled bogus rows and
2943 unnecessary graphics copy operations.
2944
2945 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2946
2947 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2948 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2949 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2950 (malloc, free, realloc, calloc): Redirect to e_* only when
2951 compiling Emacs.
2952
2953 * lisp.h (GCTYPEBITS): Move before first use.
2954 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2955 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2956 this macro definition.
2957
2958 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2959 _MSC_VER.
2960
2961 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2962
2963 * gtkutil.c (xg_create_frame_widgets):
2964 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2965 present with Gtk+ 2.0.
2966
2967 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2968
2969 * fileio.c (Finsert_file_contents): Undo previous change; see
2970 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2971
2972 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2973
2974 Rename locals to avoid shadowing.
2975 * fileio.c (Finsert_file_contents):
2976 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2977 * process.c (wait_reading_process_output):
2978 Rename inner 'proc' to 'p' to avoid shadowing.
2979 Indent for consistency with usual Emacs style.
2980
2981 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2982
2983 * xdisp.c (redisplay_window): If cursor row is not fully visible
2984 after recentering, and scroll-conservatively is set to a large
2985 number, scroll window by a few more lines to make the cursor fully
2986 visible and out of scroll-margin. (Bug#10105)
2987 (start_display): Don't move to the next line if the display should
2988 start at a newline that is part of a display vector or an overlay
2989 string. (Bug#10119)
2990
2991 2011-11-24 Juri Linkov <juri@jurta.org>
2992
2993 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2994 after the `MagickPingImage' call. (Bug#10112)
2995
2996 2011-11-23 Chong Yidong <cyd@gnu.org>
2997
2998 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2999
3000 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3001
3002 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3003 making another buffer current. (Bug#10114)
3004
3005 2011-11-23 Glenn Morris <rgm@gnu.org>
3006
3007 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3008
3009 2011-11-23 Chong Yidong <cyd@gnu.org>
3010
3011 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3012 using it (Bug#5984).
3013
3014 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3015
3016 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3017 and header-lines, as they don't have one computed for them.
3018 (Bug#10098)
3019
3020 * .gdbinit (prow): Make displayed values more self-explaining.
3021 Add row's hash code.
3022
3023 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3024
3025 * process.c (wait_reading_process_output): Fix asynchrounous
3026 GnuTLS socket handling on some versions of the GnuTLS library.
3027 (wait_reading_process_output): Add comment and URL.
3028
3029 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3030
3031 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3032
3033 2011-11-21 Chong Yidong <cyd@gnu.org>
3034
3035 * window.c (Fnext_window, Fprevious_window): Doc fix.
3036
3037 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3038
3039 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3040
3041 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3042
3043 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3044
3045 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3046
3047 * window.c (Fset_window_combination_limit): Rename argument
3048 STATUS to LIMIT.
3049 (Vwindow_combination_limit): Remove "status" from doc-string.
3050
3051 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3052
3053 * m/ibms390.h: Remove.
3054 * m/ibms390x.h: Don't include "ibms390.h".
3055
3056 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3057
3058 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3059 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3060
3061 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3062
3063 * casetab.c (Fset_case_table):
3064 * charset.c (Fcharset_after): Fix typos.
3065
3066 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3067
3068 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3069 Otherwise, valgrind does not work on some platforms.
3070 Problem reported by Andreas Schwab in
3071 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3072 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3073 is set, removing the need for VIRT_ADDRESS_VARIES.
3074 (PURE_P): Use a more-efficient implementation that needs just one
3075 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3076 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3077 to 4 (xorl, subq, cmpq, setbe).
3078 * alloc.c (pure): Always extern now, since that's the
3079 VIRT_ADDR_VARIES behavior.
3080 (PURE_POINTER_P): Use a single comparison, not two, for
3081 consistency with the new puresize.h.
3082 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3083 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3084 Remove VIRT_ADDR_VARIES no longer needed.
3085
3086 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3087
3088 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3089 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3090 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3091 behave as if the cursor position were at the window margin.
3092
3093 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3094 and the cursor position is out of bounds, behave as if the cursor
3095 position were at the window margin. (Bug#10075)
3096
3097 2011-11-18 Chong Yidong <cyd@gnu.org>
3098
3099 * window.c (Fwindow_combination_limit): Make first argument
3100 non-optional, since it is meaningless for live windows like the
3101 selected window.
3102
3103 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3104
3105 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3106
3107 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3108
3109 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3110 (graft_intervals_into_buffer): Simplify.
3111
3112 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3113
3114 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3115 hash values of the two rows.
3116 (copy_row_except_pointers): Preserve the used[] arrays and the
3117 hash values of the two rows. (Bug#10035)
3118 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3119
3120 * xdisp.c (row_hash): New function, body extracted from
3121 compute_line_metrics.
3122 (compute_line_metrics): Call row_hash, instead of computing the
3123 hash code inline.
3124
3125 * dispnew.c (verify_row_hash): Call row_hash for computing the
3126 hash code of a row, instead of duplicating code from xdisp.c.
3127
3128 * dispextern.h (row_hash): Add prototype.
3129
3130 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3131
3132 * frame.c (delete_frame): Don't delete the terminal when the last
3133 X frame is closed if emacs is built with GTK toolkit.
3134
3135 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3136
3137 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3138
3139 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3140
3141 * window.c (Vwindow_splits): Rename to
3142 Vwindow_combination_resize. Suggested by Juri Linkov.
3143 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3144 of Vwindow_splits.
3145
3146 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3147
3148 * nsfns.m (Fns_font_name):
3149 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3150
3151 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3152
3153 * window.h (window): Rename slot "nest" to "combination_limit".
3154 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3155 (Fset_window_nest): Rename to Fset_window_combination_limit.
3156 (Vwindow_nest): Rename to Vwindow_combination_limit.
3157 (recombine_windows, make_parent_window, make_window)
3158 (Fsplit_window_internal, saved_window)
3159 (Fset_window_configuration, save_window_save): Rename all
3160 occurrences of window_nest to window_combination_limit.
3161
3162 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3163
3164 * image.c (imagemagick_load_image): Fix typo.
3165
3166 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3167
3168 * xdisp.c (display_line): Move the call to
3169 highlight_trailing_whitespace before the call to
3170 compute_line_metrics, since the latter needs to see the final
3171 faces of all the glyphs to compute ROW's hash value.
3172 Fixes assertion violations in row_equal_p. (Bug#10035)
3173
3174 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3175
3176 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3177 just return (bug#10044).
3178
3179 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3180
3181 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3182 with user-defined heap size. Bump the default size of the temacs
3183 heap to 27MB, to avoid memory warning when running temacs.
3184 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3185
3186 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3187 current_matrix and desired_matrix. (Bug#9990)
3188 (verify_row_hash) [XASSERTS]: New function.
3189 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3190 that the hash value of glyph rows is correct.
3191
3192 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3193
3194 * window.h (window): Remove splits slot.
3195 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3196 (Fdelete_other_windows_internal, make_parent_window)
3197 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3198 (Fset_window_configuration, save_window_save): Don't deal with
3199 split status of windows.
3200 (saved_window): Remove splits slot.
3201 (Vwindow_splits): Rewrite doc-string.
3202
3203 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3204
3205 * xfns.c (unwind_create_frame):
3206 * nsfns.m (unwind_create_frame):
3207 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3208 Vframe_list (Bug#9999).
3209
3210 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3211
3212 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3213
3214 2011-11-11 Kenichi Handa <handa@m17n.org>
3215
3216 * callproc.c (Fcall_process): Set the member dst_multibyte of
3217 process_coding.
3218
3219 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3220
3221 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3222 avoid a crash (bug#9496).
3223
3224 2011-11-09 Chong Yidong <cyd@gnu.org>
3225
3226 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3227 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3228
3229 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3230
3231 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3232
3233 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3234
3235 Avoid some portability problems by eschewing 'extern inline' functions.
3236 The trivial performance wins aren't worth the portability hassles; see
3237 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3238 et seq.
3239 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3240 (window_box_width, window_box_left, window_box_left_offset)
3241 (window_box_right, window_box_right_offset): Undo previous change,
3242 by removing the "extern"s.
3243 * intervals.c (adjust_intervals_for_insertion)
3244 (adjust_intervals_for_deletion): Undo previous change,
3245 making these static again.
3246 (offset_intervals, temp_set_point_both, temp_set_point)
3247 (copy_intervals_to_string): No longer inline.
3248 * xdisp.c (window_text_bottom_y, window_box_width)
3249 (window_box_height, window_box_left_offset)
3250 (window_box_right_offset, window_box_left, window_box_right)
3251 (window_box): No longer inline.
3252
3253 2011-11-08 Chong Yidong <cyd@gnu.org>
3254
3255 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3256 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3257 Signal an error if not a live window.
3258 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3259 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3260
3261 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3262
3263 * lisp.h (syms_of_abbrev): Remove declaration.
3264 Reported by CHENG Gao <chenggao@royau.me>.
3265
3266 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3267
3268 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3269 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3270 of temacs in GUI mode.
3271
3272 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3273
3274 * window.h: Declare delete_all_child_windows instead of
3275 delete_all_subwindows.
3276 * window.c (Fwindow_nest, Fset_window_nest)
3277 (Fset_window_new_total, Fset_window_new_normal)
3278 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3279 (delete_all_subwindows): Rename to delete_all_child_windows.
3280 (Fdelete_other_windows_internal, Fset_window_configuration):
3281 Call delete_all_child_windows instead of delete_all_subwindows.
3282 * frame.c (delete_frame): Call delete_all_child_windows instead
3283 of delete_all_subwindows.
3284
3285 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3286
3287 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3288 This is also needed for porting to any host where GC_MARK_STACK is
3289 not GC_MAKE_GCPROS_NOOPS.
3290 (which_symbols): Use it.
3291
3292 2011-11-07 Kenichi Handa <handa@m17n.org>
3293
3294 * coding.c (coding_set_destination): Check coding->src_pos only
3295 when coding->src_object is a buffer (bug#9910).
3296
3297 * process.c (send_process): Set the member src_multibyte of coding
3298 to 0 (bug#9911) when sending a unibyte text.
3299
3300 * callproc.c (Fcall_process): Set the member src_multibyte of
3301 process_coding to 0 (bug#9912).
3302
3303 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3304
3305 * xmenu.c (cleanup_widget_value_tree): New function.
3306 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3307 calling free_menubar_widget_value_tree directly (Bug#9830).
3308
3309 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3310
3311 Fix some portability problems with 'inline'.
3312 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3313 (window_box_width, window_box_left, window_box_left_offset)
3314 (window_box_right, window_box_right_offset): Declare extern.
3315 Otherwise, these inline functions do not conform to C99 and
3316 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3317 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3318 * intervals.c (adjust_intervals_for_insertion)
3319 (adjust_intervals_for_deletion): Now extern, because otherwise the
3320 extern inline functions 'offset_intervals' couldn't refer to it.
3321 (static_offset_intervals): Remove.
3322 (offset_intervals): Rewrite using the old contents of
3323 static_offset_intervals. The old version didn't conform to C99
3324 because an extern inline function contained a reference to an
3325 identifier with static linkage.
3326
3327 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3328
3329 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3330 GC.
3331
3332 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3333
3334 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3335 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3336 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3337 return Qleft_to_right.
3338
3339 2011-11-06 Chong Yidong <cyd@gnu.org>
3340
3341 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3342 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3343 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3344 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3345 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3346 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3347 (Fwindow_vscroll): Doc fix.
3348 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3349 argument, since it makes no sense to pass a live window and for
3350 consistency with window-child.
3351
3352 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3353
3354 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3355 support MSVC.
3356
3357 2011-11-05 Jason Rumney <jasonr@gnu.org>
3358
3359 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3360 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3361 fonts (Bug#6029).
3362 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3363 bitwise arithmetic preventing use of unicode-sip and non-truetype
3364 opentype fonts.
3365
3366 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3367
3368 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3369 "emacs"-only part.
3370
3371 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3372 initialization code to keep similarity to xfns.c after changes
3373 from 2011-11-05.
3374
3375 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3376
3377 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3378 (unwind_create_frame): New function (Bug#9943).
3379 (Fx_create_frame): Restructure code to be more similar to the one in
3380 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3381 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3382 Move terminal->reference_count++ just before making the frame official
3383 (Bug#9943).
3384
3385 * nsterm.m (x_free_frame_resources): New function.
3386 (x_destroy_window): Move code to x_free_frame_resources.
3387
3388 * xfns.c (unwind_create_frame): Fix comment.
3389 (Fx_create_frame, x_create_tip_frame):
3390 Move terminal->reference_count++ just before making the frame
3391 official. Move initialization of image_cache_refcount and
3392 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3393
3394 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3395
3396 Support MSVC build with newer versions of Visual Studio.
3397 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3398 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3399 nt/gmake.defs.
3400
3401 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3402 which are not supported by MSVC.
3403 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3404 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3405 bitfields.
3406 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3407 types in bitfields.
3408 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3409
3410 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3411
3412 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3413
3414 Support MSVC build with newer versions of Visual Studio.
3415 * w32.c: Don't include w32api.h for MSVC.
3416 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3417
3418 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3419 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3420 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3421 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3422 e_* cousins.
3423 (alloca) [_MSC_VER]: Define to _alloca.
3424
3425 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3426
3427 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3428
3429 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3430
3431 * xdisp.c (note_mouse_highlight): If either of
3432 previous/next-single-property-change returns nil, treat that as
3433 the beginning or the end of the buffer. (Bug#9955)
3434
3435 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3436
3437 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3438 label is not null (Bug#9951).
3439 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3440 may be NULL.
3441
3442 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3443
3444 * window.c (Fwindow_body_size): Mention in the doc string that the
3445 return value is in frame's canonical units. (Bug#9949)
3446
3447 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3448
3449 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3450
3451 * w32fns.c (unwind_create_frame): If needed, free the glyph
3452 matrices of the partially constructed frame. (Bug#9943)
3453 * xfns.c (unwind_create_frame): Likewise.
3454
3455 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3456
3457 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3458 Don't stop backward scan on the continuation glyph, even though
3459 its CHARPOS is positive.
3460 (mouse_face_from_buffer_pos, note_mouse_highlight):
3461 Rename cover_string to disp_string.
3462
3463 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3464
3465 * window.c (temp_output_buffer_show): Don't use
3466 Vtemp_buffer_show_specifiers.
3467 (Vtemp_buffer_show_specifiers): Remove unused variable.
3468
3469 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3470
3471 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3472 past the beginning of the current glyph matrix.
3473
3474 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3475
3476 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3477 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3478 HAVE_GTK3 (Bug#9869).
3479
3480 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3481 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3482
3483 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3484
3485 * xterm.c: Declare x_handle_net_wm_state to return int.
3486 (handle_one_xevent): Check if we are iconified but don't have
3487 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3488 (get_current_wm_state): Return non-zero if not hidden,
3489 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3490 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3491 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3492 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3493
3494 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3495
3496 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3497 so that this new function doesn't get optimized away by a
3498 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3499
3500 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3501
3502 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3503
3504 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3505
3506 Fix the `xbytecode' command.
3507 * .gdbinit (xprintbytestr): New command.
3508 (xwhichsymbols): Rename from `which'; all callers changed.
3509 (xbytecode): Print the byte-code string as well.
3510
3511 2011-10-29 Kim Storm <storm@cua.dk>
3512
3513 * alloc.c (which_symbols): New function.
3514
3515 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3516
3517 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3518 line. (Bug#9903)
3519
3520 2011-10-29 Glenn Morris <rgm@gnu.org>
3521
3522 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3523 Not clear what it was for, and it causes various bugs. (Bug#9839)
3524
3525 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3526
3527 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3528 possible random value that matches one of those tested as
3529 condition to clear the mouse face.
3530
3531 2011-10-28 Chong Yidong <cyd@gnu.org>
3532
3533 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3534
3535 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3536
3537 * window.c (make_window): Initialize phys_cursor_on_p.
3538
3539 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3540
3541 * lisp.h (struct Lisp_Symbol): Update comments.
3542
3543 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3544
3545 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3546
3547 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3548
3549 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3550 <oslsachem@gmail.com> for helping to debug this.
3551
3552 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3553 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3554 (g_b_init_get_glyph_outline_w): New static variables.
3555 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3556 (GetGlyphOutlineW_Proc): New typedefs.
3557 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3558 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3559 New functions.
3560 (w32font_open_internal, compute_metrics):
3561 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3562 instead of calling the "wide" APIs directly.
3563
3564 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3565
3566 * w32.h (syms_of_w32font): Add prototype.
3567
3568 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3569
3570 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3571 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3572 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3573 (Fmove_to_window_line): Doc fix.
3574
3575 2011-10-27 Chong Yidong <cyd@gnu.org>
3576
3577 * process.c (make_process): Set gnutls_state to NULL.
3578
3579 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3580 non-NULL, regardless of GNUTLS_INITSTAGE.
3581 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3582 an error. Set process slots as soon as we allocate them.
3583
3584 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3585
3586 2011-10-27 Chong Yidong <cyd@gnu.org>
3587
3588 * gnutls.c (emacs_gnutls_deinit): New function.
3589 Deallocate credentials structures as well as calling gnutls_deinit.
3590 (Fgnutls_deinit, Fgnutls_boot): Use it.
3591
3592 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3593 (deactivate_process): Call emacs_gnutls_deinit.
3594
3595 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3596
3597 * image.c (x_create_x_image_and_pixmap):
3598 * w32.c (sys_rename, w32_delayed_load):
3599 * w32font.c (fill_in_logfont):
3600 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3601
3602 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3603
3604 * w32fns.c (w32_default_color_map): New function,
3605 extracted from Fw32_default_color_map.
3606 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3607
3608 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3609
3610 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3611
3612 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3613
3614 * keyboard.c (test_undefined): New function (bug#9751).
3615 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3616
3617 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3618
3619 * sysdep.c (init_sys_modes): Fix the check for the controlling
3620 terminal (Bug#6649).
3621
3622 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3623
3624 * dispextern.h (struct bidi_it): New member next_en_type.
3625
3626 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3627 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3628 current character, check also for next_en_type being WEAK_EN.
3629 (bidi_resolve_weak): Don't enter the expensive loop if the current
3630 position is before next_en_pos. Record the bidi type of the first
3631 non-ET, non-BN character we find, in addition to its position.
3632 (bidi_level_of_next_char): Invalidate next_en_type when
3633 next_en_pos is over-stepped.
3634
3635 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3636
3637 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3638 * editfns.c: Rewrite current-time-zone so that it invokes
3639 the equivalent of (format-time-string "%Z") to get the time zone name.
3640 This fixes a bug when the time zone name contains characters that
3641 need converting from the system time locale to Emacs internal format.
3642 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3643 that patch fixed format-time-string to do the conversion, but
3644 I forgot to fix current-time-zone.
3645 (format_time_string): New function, containing most of
3646 what Fformat_time_string used to contain.
3647 (Fformat_time_string): Rewrite in terms of format_time_string.
3648 This doesn't change this function's behavior.
3649 (current-time-zone): Rewrite to use format_time_string.
3650 This fixes the bug reported by Michael Schierl in
3651 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3652 Jason Rumney's 2007-06-07 change worked around this bug, but
3653 didn't fix it.
3654 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3655
3656 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3657
3658 * xdisp.c (start_display): If the character at POS is displayed
3659 via a display vector, reset IT->current.dpvec_index to zero.
3660 (try_window_reusing_current_matrix): If a line ends in a display
3661 vector or the next line starts in a display vector, continue
3662 redrawing the window even though the character position of
3663 start_row was reached.
3664 (Bug#9771, part 2)
3665
3666 2011-10-18 Chong Yidong <cyd@gnu.org>
3667
3668 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3669 with nobreak-char-display too.
3670
3671 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3672
3673 Fix part 3 of bug#9771.
3674 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3675 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3676 non-neutral characters if the current character is a paragraph
3677 separator (a.k.a. Newline). This avoids running the same
3678 expensive loop twice, once when we consume the preceding newline
3679 and the other time when the line actually needs to be displayed.
3680 Avoid the loop when we see neutrals on the base embedding level
3681 following a character whose directionality is the same as the
3682 paragraph's. This avoids running the expensive loop when a line
3683 ends in a long sequence of neutrals, like control characters.
3684 Add assertion against STRONG_AL type. Slightly rearrange code
3685 that determines the type of a neutral given the first non-neutral
3686 that follows it.
3687 (bidi_level_of_next_char): Set next_en_pos to zero when
3688 invalidating its info.
3689
3690 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3691
3692 * xdisp.c (push_display_prop): Determine whether to record string
3693 or buffer position by IT->string, not by IT->method. Allow
3694 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3695 (move_it_vertically_backward): Don't look for character position
3696 immediately after the newline when in a continuation line.
3697 (Bug#9771, part 1)
3698
3699 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3700
3701 * window.c (coordinates_in_window): Rewrite and delabelize
3702 vertical border check. (Bug#5357) (Bug#9618)
3703
3704 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3705
3706 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3707 errors in XSetWindowBorder (bug#9310).
3708
3709 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3710
3711 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3712 avoid crash when xmalloc overrun checking is enabled.
3713
3714 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3715
3716 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3717 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3718 cursor motion with <left> and <right> arrow keys.
3719
3720 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3721 some callers set that themselves.
3722
3723 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3724
3725 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3726 display string and the previous row comes from the same string and
3727 is empty. (Bug#9739) (Bug#9738)
3728
3729 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3730
3731 * doc.c (get_doc_string): Encode file name (bug#9735).
3732
3733 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3734
3735 * bidi.c (bidi_level_of_next_char):
3736 * xdisp.c (get_visually_first_element): Remove old incorrect
3737 comments regarding the Unicode Line Separator character.
3738
3739 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3740
3741 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3742
3743 * alloc.c (Fgc_status): Do not access beyond zombies array
3744 boundary if nzombies > MAX_ZOMBIES.
3745 * alloc.c (dump_zombies): Add missing format specifier.
3746
3747 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3748
3749 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3750 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3751
3752 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3753 Some packages use them to denote characters with modifiers.
3754
3755 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3756
3757 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3758 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3759 matching a pp-number. Rename parameter var to var1.
3760
3761 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3762
3763 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3764
3765 2011-10-08 Glenn Morris <rgm@gnu.org>
3766
3767 * callint.c (Fcall_interactively): Give a more explicit error for the
3768 'c' case with a non-character input. (Bug#8479)
3769
3770 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3771
3772 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3773 lines.
3774 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3775 lines that are hscrolled on the left.
3776
3777 * dispnew.c (buffer_posn_from_coords): Account for a possible
3778 presence of header-line. (Bug#4426)
3779
3780 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3781
3782 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3783 Don't advertise functionality which we discourage or doesn't work.
3784
3785 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3786
3787 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3788 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3789 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3790 this makes Emacs dump core during garbage collection on rare
3791 occasions. sizeof is obviously inferior to offsetof here, so
3792 stick with offsetof.
3793 (GC_POINTER_ALIGNMENT): New macro.
3794 (mark_memory): Omit 3rd (offset) arg; caller changed.
3795 Don't assume EMACS_INT alignment is the same as pointer alignment.
3796
3797 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3798
3799 * keyboard.c (read_key_sequence_remapped): New var.
3800 (read_key_sequence): Compute remapping in the right buffer.
3801 (command_loop_1): Use read_key_sequence's remapping directly.
3802
3803 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3804
3805 * dired.c (file_name_completion): Don't expand file name.
3806 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3807 before checking file name handler.
3808
3809 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3810 they've been requested explicitly (bug#9591).
3811
3812 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3813
3814 * keymap.c (Fsingle_key_description): Use make_specified_string
3815 instead of build_string to build string from push_key_description.
3816 (Bug#5193)
3817
3818 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3819
3820 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3821 This fixes a Y2038 bug on 64-bit hosts.
3822 * buffer.c (reset_buffer):
3823 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3824 (Fclear_buffer_auto_save_failure):
3825 Use 0, not -1, to represent an unset failure time, since time_t
3826 might not be signed.
3827
3828 Remove dependency on glibc malloc internals.
3829 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3830 Move back here from lisp.h, but with their new implementations.
3831 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3832 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3833 * charset.c (charset_table_init): New static var.
3834 (syms_of_charset): Use it instead of xmalloc. This removes a
3835 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3836 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3837 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3838 Move back to alloc.c.
3839 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3840 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3841
3842 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3843
3844 * nsterm.m (windowDidResize): Call x_set_window_size only when
3845 ns_in_resize is true. Otherwise set pixelwidth/height and
3846 call change_frame_size (Bug#9628).
3847
3848 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3849
3850 Port --enable-checking=all to Fedora 14 x86-64.
3851 * charset.c (syms_of_charset): Also account for glibc malloc's
3852 internal overhead when calculating the initial malloc maximum.
3853
3854 Port --enable-checking=all to Fedora 14 x86.
3855 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3856 Move to lisp.h.
3857 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3858 (overrun_check_realloc, overrun_check_free):
3859 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3860 That way, xmalloc returns a properly-aligned pointer even if
3861 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3862 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3863 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3864 into account when calculating the initial malloc maximum.
3865 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3866 Move here from alloc.c, so that charset.c can use it too.
3867 Properly align; the old code wasn't right for common 32-bit hosts
3868 when configured with --enable-checking=all.
3869 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3870 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3871
3872 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3873
3874 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3875 use EDOM.
3876
3877 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3878
3879 * xdisp.c (compute_display_string_end): If there's no display
3880 string at CHARPOS, return -1.
3881
3882 * bidi.c (bidi_fetch_char): When compute_display_string_end
3883 returns a negative value, treat the character as a normal
3884 character not covered by a display string. (Bug#9624)
3885
3886 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3887
3888 * lread.c (Fread_from_string): Fix typo in docstring.
3889
3890 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3891
3892 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3893 newline, reseat the iterator instead of bidi-iterating there one
3894 character at a time. (Bug#9610)
3895 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3896 TO_CHARPOS if the bidi iterator is at base embedding level.
3897
3898 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3899
3900 * lread.c (readevalloop): Use correct code for NBSP.
3901 (read1): Likewise. (Bug#9608)
3902
3903 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3904
3905 * dbusbind.c (Fdbus_register_signal): When service is not
3906 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3907
3908 2011-09-25 Glenn Morris <rgm@gnu.org>
3909
3910 * buffer.c (truncate-lines): Doc fix.
3911
3912 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3913
3914 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3915 (Fset_window_next_buffers): Doc fix.
3916
3917 2011-09-24 Glenn Morris <rgm@gnu.org>
3918
3919 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3920
3921 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3922
3923 Fix minor problems found by static checking.
3924 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3925 * indent.c (Fvertical_motion): Fix == vs = typo.
3926
3927 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3928
3929 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3930 Default value is now t. Doc fix.
3931
3932 * indent.c (Fvertical_motion): Compute and apply the overshoot
3933 logic when moving up, not only when moving down. Fix the
3934 confusing name and values of the it_overshoot_expected variable;
3935 logic changes accordingly. (Bug#9254) (Bug#9549)
3936
3937 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3938 CHARPOS is covered by a display string which includes newlines.
3939 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3940 is covered by a display string with embedded newlines.
3941
3942 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3943
3944 * dbusbind.c (Fdbus_register_signal): Add match rule to
3945 Vdbus_registered_objects_table. (Bug#9581)
3946 (Fdbus_register_method, Vdbus_registered_objects_table):
3947 Fix docstring.
3948
3949 2011-09-24 Jim Meyering <meyering@redhat.com>
3950
3951 do not ignore write error for any output size
3952 The previous change was incomplete.
3953 While it makes emacs --batch detect the vast majority of stdout
3954 write failures, errors were still ignored whenever the output size is
3955 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3956 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3957 && echo FAIL: ignored write error
3958 FAIL: ignored write error
3959 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3960 && echo FAIL: ignored write error
3961 FAIL: ignored write error
3962 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3963
3964 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3965
3966 * emacs.c (Fkill_emacs): In noninteractive mode exit
3967 non-successfully if a write error occurred on stdout. (Bug#9574)
3968
3969 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3970
3971 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3972 the xassert test.
3973
3974 * dispextern.h (struct it): Update the comment documenting what
3975 can it->OBJECT be.
3976
3977 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3978
3979 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3980 a display string, extend search for cursor position to end of row.
3981 (find_row_edges): If the row ends in a newline from a display
3982 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3983 Handle the case of a display string with multiple newlines.
3984 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3985 non-empty line. Fixes confusing cursor motion with arrow keys at
3986 the beginning of a line that starts with whitespace.
3987
3988 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3989
3990 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3991 (bug#9493).
3992
3993 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3994
3995 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3996 boolean (Bug#9154).
3997
3998 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3999
4000 * xdisp.c (display_line): Record maximum and minimum buffer
4001 positions even if no glyphs were produced (e.g., by a zero-width
4002 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4003 buffer positions that will be removed from the glyph row because
4004 they don't fit.
4005 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4006 column is beyond frame width: don't subtract 1 "pixel" when
4007 computing width of the stretch.
4008 (reseat_at_next_visible_line_start): Undo the change made on
4009 2011-09-17 that saved paragraph information and restored it after
4010 the call to `reseat'. (Bug#9545)
4011
4012 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4013
4014 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4015 and turn window cursor on if cleared (Bug#9415).
4016
4017 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4018
4019 * search.c (boyer_moore): Take unibyte characters from pattern
4020 literally. (Bug#9458)
4021
4022 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4023
4024 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4025
4026 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4027
4028 Fix minor problem found by static checking.
4029 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4030 initialized, to pacify gcc -Wuninitialized.
4031
4032 * fileio.c: Report proper errno when syscall falls.
4033 (Finsert_file_contents): Save and restore errno,
4034 so that report_file_error outputs the correct diagnostic.
4035 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4036
4037 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4038
4039 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4040
4041 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4042
4043 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4044 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4045
4046 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4047
4048 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4049 about the current paragraph and restore it after the call to reseat.
4050
4051 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4052 (bidi_find_paragraph_start): Search back for paragraph beginning
4053 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4054 (bidi_move_to_visually_next): Only trigger paragraph-related
4055 computations when the last character is a newline or at EOB, not
4056 just any NEUTRAL_B. (Bug#9470)
4057
4058 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4059 truncated lines if point is covered by a display string. (Bug#9524)
4060
4061 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4062
4063 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4064 (cons_to_x_long): New function.
4065 (lisp_data_to_selection_data): Use it. Correct the test for
4066 short-versus-long data; it was negated. Break out of vector
4067 loop, for efficiency, when a long datum is discovered.
4068
4069 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4070
4071 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4072
4073 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4074
4075 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4076 GCC PR/17406) by declaring this function with external scope.
4077
4078 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4079
4080 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4081 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4082
4083 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4084
4085 * editfns.c (Fformat): Correctly handle text properties on "%%".
4086
4087 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4088
4089 * xterm.c (x_draw_composite_glyph_string_foreground):
4090 * w32term.c (x_draw_composite_glyph_string_foreground):
4091 * term.c (encode_terminal_code):
4092 * composite.c (composition_update_it, get_composition_id):
4093 * xdisp.c (get_next_display_element)
4094 (fill_composite_glyph_string): Add comments about special meaning
4095 of TAB characters in a composition.
4096
4097 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4098
4099 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4100 This occurs when processing a multibyte format.
4101 Problem reported by Wolfgang Jenker.
4102
4103 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4104
4105 * xdisp.c (try_cursor_movement): Only check for exact match if
4106 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4107
4108 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4109
4110 Remove unused external symbols.
4111 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4112 * xdisp.c (calc_pixel_width_or_height): Now static.
4113 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4114 * indent.c (check_display_width):
4115 * w32term.c: Fix comment to match code.
4116 * xterm.c, xterm.h (x_catching_errors): Remove.
4117
4118 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4119
4120 * xselect.c: Use signed conversions more consistently (Bug#9498).
4121 (selection_data_to_lisp_data): Assume incoming selection data are
4122 signed integers, not unsigned. This is to be consistent with
4123 outgoing selection data, which was modified to use signed integers
4124 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4125 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4126 expects long, not unsigned long.
4127
4128 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4129
4130 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4131 computation of loop end. Reported by Johan Bockgård
4132 <bojohan@gnu.org>.
4133
4134 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4135
4136 * frame.c (Fother_visible_frames_p): Function deleted.
4137
4138 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4139
4140 * indent.c (compute_motion): Process display vector front to back
4141 rather than the other way around. (Bug#2496)
4142
4143 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4144
4145 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4146
4147 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4148
4149 * minibuf.c (Fread_from_minibuffer): Doc fix.
4150
4151 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4152
4153 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4154 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4155
4156 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4157
4158 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4159 value for non-existent files.
4160
4161 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4162
4163 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4164 set its "size" to -1. This will set the modtime_size field of
4165 the corresponding buffer to -1, which is what
4166 verify-visited-file-modtime expects for files that do not exist.
4167 (Bug#9139)
4168
4169 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4170
4171 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4172 here ...
4173 * lisp.h: ... from here. push_key_description is no longer
4174 defined in keyboard.c, so its declaration should not be in
4175 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4176 logically belongs with push_key_description.
4177
4178 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4179
4180 * buffer.h: Include <sys/types.h> instead of <time.h>.
4181 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4182 Problem reported by Herbert J. Skuhra.
4183
4184 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4185
4186 * xml.c (parse_region): Make the parsing work for
4187 non-comment-starting XML files again (bug#9144).
4188
4189 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4190
4191 * image.c (gif_load): Fix calculation of bottom and right corner.
4192 (Bug#9468)
4193
4194 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4195
4196 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4197 redisplay in small windows.
4198
4199 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4200
4201 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4202
4203 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4204
4205 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4206 Operate on live windows only.
4207
4208 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4209
4210 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4211
4212 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4213
4214 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4215 only under bidi iteration.
4216
4217 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4218
4219 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4220
4221 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4222
4223 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4224 Without this fix, the command to link temacs failed due to an
4225 undefined symbol __builtin_isnan. This is because
4226 /usr/include/iso/math_c99.h #defines isnan(x) to
4227 __builtin_isnan(x), but the bundled gcc, which identifies itself
4228 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4229 a __builtin_isnan.
4230 * floatfns.c (isnan): #undef, and then #define to a clone of
4231 what's in data.c.
4232 (Fisnan): Always define, since it's always available now.
4233 (syms_of_floatfns): Always define isnan at the Lisp level.
4234
4235 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4236
4237 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4238
4239 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4240
4241 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4242 The previous code assumed that file offsets (off_t values) fit in
4243 EMACS_INT variables, which is not true on typical 32-bit hosts.
4244 The code messed up by falsely reporting buffer overflow in cases
4245 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4246 when "big" contains more than 2**29 bytes, even though this
4247 inserts just one byte and does not overflow the buffer.
4248 (Finsert_file_contents): Store file offsets as off_t
4249 values, not as EMACS_INT values. Check for overflow when
4250 converting between EMACS_INT and off_t. When checking for
4251 buffer overflow or for overlap, take the offsets into account.
4252 Don't use EMACS_INT for small values where int suffices.
4253 When checking for overlap, fix a typo: ZV was used where
4254 ZV_BYTE was intended.
4255 (Fwrite_region): Don't assume off_t fits into 'long'.
4256 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4257
4258 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4259
4260 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4261
4262 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4263
4264 sprintf-related integer and memory overflow issues (Bug#9412).
4265
4266 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4267 (esprintf, exprintf, evxprintf): New functions.
4268 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4269 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4270 (modify_event_symbol): Do not assume that the length of
4271 name_alist_or_stem is safe to alloca and fits in int.
4272 (Fexecute_extended_command): Likewise for function name and binding.
4273 (Frecursion_depth): Wrap around reliably on integer overflow.
4274 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4275 since some callers pass EMACS_INT values.
4276 (Fsingle_key_description): Don't crash if symbol name contains more
4277 than MAX_ALLOCA bytes.
4278 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4279 (get_minibuffer): Arg is now EMACS_INT, not int.
4280 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4281 (esprintf, exprintf, evxprintf): New decls.
4282 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4283
4284 * dbusbind.c (signature_cat): New function.
4285 (xd_signature, Fdbus_register_signal):
4286 Do not overrun buffer; instead, report string overflow.
4287
4288 * dispnew.c (add_window_display_history): Don't overrun buffer.
4289 Truncate instead; this is OK since it's just a log.
4290
4291 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4292 even if the time zone offset is outlandishly large.
4293 Don't mishandle offset == INT_MIN.
4294
4295 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4296 when creating daemon; the previous buffer-overflow check was incorrect.
4297
4298 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4299 which has the guts of the old verror function.
4300
4301 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4302 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4303
4304 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4305 (font_unparse_xlfd): Don't blindly alloca long strings.
4306 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4307 fits in int, when using sprintf. Use single snprintf to count
4308 length of string rather than counting it via multiple sprintfs;
4309 that's simpler and more reliable.
4310 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4311 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4312 sprintf, in case result does not fit in int.
4313
4314 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4315 (fontset_from_font): Print it.
4316
4317 * frame.c (tty_frame_count): Now printmax_t, not int.
4318 (make_terminal_frame, set_term_frame_name): Print it.
4319 (x_report_frame_params): In X, window IDs are unsigned long,
4320 not signed long, so print them as unsigned.
4321 (validate_x_resource_name): Check for implausibly long names,
4322 and don't assume name length fits in 'int'.
4323 (x_get_resource_string): Don't blindly alloca invocation name;
4324 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4325 not fit in int.
4326
4327 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4328 (xg_check_special_colors, xg_set_geometry):
4329 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4330
4331 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4332 Use esprintf, not sprintf, in case result does not fit in int.
4333
4334 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4335 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4336 it as a large positive number.
4337 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4338 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4339
4340 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4341 in case result does not fit in int.
4342
4343 * print.c (float_to_string): Detect width overflow more reliably.
4344 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4345 buffer overrun. Don't assume list length fits in 'int'. Treat
4346 print length of 0 as 0, not as infinity; to be consistent with other
4347 uses of print length in this function. Don't overflow print length
4348 index. Don't assume hash table size fits in 'long', or that
4349 vectorlike size fits in 'unsigned long'.
4350
4351 * process.c (make_process): Use printmax_t, not int, to format
4352 process-name gensyms.
4353
4354 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4355
4356 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4357 to avoid potential buffer overrun.
4358
4359 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4360 if X resource line is longer than 512 bytes.
4361
4362 * xfns.c (x_window): Make sprintf buffer a bit bigger
4363 to avoid potential buffer overrun.
4364
4365 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4366
4367 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4368
4369 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4370
4371 Integer overflow fixes for scrolling, etc.
4372 Without these, Emacs silently mishandles large integers sometimes.
4373 For example, "C-u 4294967297 M-x recenter" was treated as if
4374 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4375
4376 * xdisp.c (try_window_id): Check Emacs fixnum range before
4377 converting to 'int'.
4378
4379 * window.c (window_scroll_line_based, Frecenter):
4380 Check that an Emacs fixnum is in range before assigning it to 'int'.
4381 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4382 values converted from Emacs fixnums.
4383 (Frecenter): Don't wrap around a line count if it is out of 'int'
4384 range; instead, treat it as an extreme value.
4385 (Fset_window_configuration, compare_window_configurations):
4386 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4387
4388 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4389 that can exceed INT_MAX. Check that EMACS_INT value is in range
4390 before assigning it to the (possibly-narrower) index.
4391 (match_limit): Don't assume that a fixnum can fit in 'int'.
4392
4393 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4394 exceed INT_MAX.
4395
4396 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4397 (Fvertical_motion): Don't wrap around LINES values that don't fit
4398 in 'int'. Instead, treat them as extreme values. This is good
4399 enough for windows, which can't have more than INT_MAX lines anyway.
4400
4401 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4402
4403 * Require libxml/parser.h to avoid compilation warning.
4404
4405 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4406
4407 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4408 since this reportedly can destroy thread storage.
4409
4410 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4411
4412 * syntax.c (find_defun_start): Update all cache variables if
4413 exiting early (Bug#9401).
4414
4415 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4416
4417 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4418
4419 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4420 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4421 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4422
4423 * term.c (tty_append_glyph): New function.
4424 (produce_stretch_glyph): Static function and its prototype deleted.
4425
4426 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4427 Add prototypes.
4428
4429 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4430
4431 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4432 when checking :margin (Bug#9390).
4433 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4434 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4435 so that the name doesn't mislead. All uses changed.
4436
4437 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4438
4439 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4440 set_tty_hooks.
4441
4442 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4443
4444 * xdisp.c (move_it_to): Don't bail out early when reaching
4445 position beyond to_charpos, if we are scanning backwards.
4446 (move_it_vertically_backward): When DY == 0, make sure we get to
4447 the first character in the line after the newline.
4448
4449 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4450
4451 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4452 (ccl_driver): Do not generate an out-of-range pointer.
4453 (Fccl_execute_on_string): Remove unnecessary check for
4454 integer overflow, noted by Stefan Monnier in
4455 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4456 Remove a FIXME that didn't need fixing.
4457 Simplify the newly-introduced buffer reallocation code.
4458
4459 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4460
4461 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4462
4463 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4464
4465 Integer and memory overflow issues (Bug#9196).
4466
4467 * doc.c (get_doc_string): Rework so that
4468 get_doc_string_buffer_size is the actual buffer size, rather than
4469 being 1 less than the actual buffer size; this makes xpalloc more
4470 convenient.
4471
4472 * image.c (x_allocate_bitmap_record, cache_image):
4473 * xselect.c (Fx_register_dnd_atom):
4474 Simplify previous changes by using xpalloc.
4475
4476 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4477 since either will do and ptrdiff_t is convenient with xpalloc.
4478
4479 * charset.c (charset_table_size)
4480 (struct charset_sort_data.priority): Now ptrdiff_t.
4481 (charset_compare): Don't overflow if priorities differ greatly.
4482 (Fsort_charsets): Don't assume list length fits in int.
4483 Check for size-calculation overflow when allocating sort data.
4484 (syms_of_charset): Allocate an initial charset table that is
4485 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4486
4487 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4488
4489 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4490 The actual value is always <= INT_MAX, and leaving it unsigned made
4491 overflow checking harder.
4492
4493 * dispextern.h (struct glyph_matrix.rows_allocated)
4494 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4495 with xpalloc. The values are still always <= INT_MAX.
4496
4497 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4498
4499 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4500 (SAFE_NALLOCA): New macro.
4501
4502 * region-cache.c (struct boundary.pos, find_cache_boundary)
4503 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4504 (set_cache_region, invalidate_region_cache)
4505 (revalidate_region_cache, know_region_cache, region_cache_forward)
4506 (region_cache_backward, pp_cache):
4507 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4508 so that ptrdiff_t * can be passed to xpalloc.
4509 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4510 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4511 (pp_cache): Don't assume cache_len fits in int.
4512 * region-cache.h: Adjust extern decls to match.
4513
4514 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4515 EMACS_INT, since either will do, for xpalloc.
4516
4517 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4518 (xnmalloc, xnrealloc, xpalloc): New functions.
4519
4520 * bidi.c (bidi_shelve_header_size): New constant.
4521 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4522 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4523
4524 * bidi.c (bidi_cache_shrink):
4525 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4526 (overlay_strings):
4527 Don't update size of array until after memory allocation succeeds,
4528 because xmalloc/xrealloc may not return.
4529 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4530 now that we have proper integer overflow checking.
4531 (record_overlay_string, overlay_strings): Catch overflows when
4532 calculating size of overlay_str_buf.
4533
4534 * callproc.c (Fcall_process): Check for size overflow when
4535 calculating size of args2.
4536 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4537 Normally we prefer signed values, but sticking with ptrdiff_t would
4538 require adding more-complicated checks.
4539
4540 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4541 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4542 Redo buffer-overflow calculations to avoid integer overflow.
4543 Add a FIXME comment where memory seems to be over-allocated.
4544
4545 * character.c (Fstring): Check for size-calculation overflow.
4546
4547 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4548 unnecessary integer overflow. Check for size overflow.
4549 (encode_coding_object): Don't update size until xmalloc succeeds.
4550
4551 * composite.c (get_composition_id): Check for overflow in glyph
4552 length calculations.
4553
4554 Integer and memory overflow fixes for display code.
4555 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4556 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4557 (scrolling_window): Check for overflow in size calculations.
4558 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4559 Don't assume glyph table len fits in int.
4560 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4561 (row_table_size): Now ptrdiff_t, not int.
4562 (scrolling_window): Avoid overflow in size calculations.
4563 Don't update size until allocation succeeds.
4564 * fns.c (concat): Check for overflow in size calculations.
4565 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4566 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4567 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4568
4569 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4570 (get_doc_string): Check for size calculation overflow.
4571 Don't update size until allocation succeeds.
4572 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4573 EMACS_INT, where ptrdiff_t will do.
4574 (Fsubstitute_command_keys): Check for string overflow.
4575
4576 * editfns.c (set_time_zone_rule): Don't assume environment length
4577 fits in int.
4578 (message_length): Now ptrdiff_t, not int.
4579 (Fmessage_box): Don't update size until allocation succeeds.
4580 Don't assume message length fits in int.
4581 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4582
4583 * emacs.c (main): Do not reallocate argv, since there is a null at
4584 the end that can be overwritten, and this way there's no need to
4585 worry about size-calculation overflow.
4586 (sort_args): Check for size-calculation overflow.
4587
4588 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4589 alloc succeeds.
4590 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4591
4592 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4593 (x_set_scroll_bar_width, x_figure_window_size):
4594 Check for integer overflow.
4595 (x_set_alpha): Do not assume XINT fits in int.
4596
4597 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4598 This is for the members text_lines, text_cols, total_lines, total_cols,
4599 where the system imposes an 'int' limit.
4600
4601 * fringe.c (Fdefine_fringe_bitmap):
4602 Don't update size until alloc works.
4603
4604 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4605 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4606
4607 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4608 Check for size-calculation overflow.
4609 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4610 do, as we prefer signed integers.
4611 (id_to_widget.max_size, id_to_widget.used)
4612 (xg_store_widget_in_map, xg_remove_widget_from_map)
4613 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4614 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4615 Use and return ptrdiff_t, not int.
4616 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4617 * gtkutil.h: Change prototypes to match the above.
4618
4619 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4620 are duplicate now that they've been promoted to lisp.h.
4621 (x_allocate_bitmap_record, x_alloc_image_color)
4622 (make_image_cache, cache_image, xpm_load):
4623 Don't update size until alloc is done.
4624 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4625 (x_detect_edges):
4626 Check for size calculation overflow.
4627 (ct_colors_allocated_max): New constant.
4628 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4629 overflow.
4630
4631 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4632 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4633 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4634 Use ptrdiff_t, not int, to count maps.
4635 (read_char_minibuf_menu_prompt): Check for overflow in size
4636 calculations. Don't update size until allocation succeeds.
4637 Redo calculations to avoid overflow.
4638 * keyboard.h: Change prototypes to match the above.
4639
4640 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4641 to count maps.
4642 (current_minor_maps): Check for size calculation overflow.
4643 * keymap.h: Change prototypes to match the above.
4644
4645 * lread.c (read1, init_obarray): Don't update size until alloc done.
4646
4647 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4648 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4649
4650 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4651 Now ptrdiff_t, not int.
4652 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4653 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4654
4655 * process.c (Fnetwork_interface_list): Check for overflow
4656 in size calculation.
4657
4658 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4659
4660 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4661 overflow. Don't bother calling xmalloc when xrealloc will do.
4662
4663 * search.c (Freplace_match): Check for size calculation overflow.
4664 (Fset_match_data): Don't assume list lengths fit in 'int'.
4665
4666 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4667 for command line length. Do not attempt to address one before the
4668 beginning of an array, as that's not portable.
4669
4670 * term.c (max_frame_lines): Remove; unused.
4671 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4672 not int.
4673 (encode_terminal_code, calculate_costs): Check for size
4674 calculation overflow.
4675 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4676 table lengths and related sizes. Don't update size until alloc
4677 done. Redo calculations to avoid overflow.
4678 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4679
4680 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4681 subtracting pointers.
4682 (gobble_line): Check for overflow more carefully. Don't update size
4683 until alloc done.
4684
4685 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4686 Don't update size until alloc done.
4687 Redo size calculations to avoid overflow.
4688 Check for size calculation overflow.
4689 (main) [DEBUG]: Fix typo in invoking tparam1.
4690
4691 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4692 Use ptrdiff_t, not int, for sizes.
4693 (store_mode_line_noprop_char): Don't update size until alloc done.
4694
4695 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4696 Use ptrdiff_t, not int, for sizes.
4697 (Finternal_make_lisp_face, cache_face):
4698 Check for size calculation overflow.
4699 (cache_face): Treat size calculation overflows as if they were
4700 memory exhaustion (the usual treatment), rather than aborting.
4701
4702 * xfns.c (x_encode_text, x_set_name_internal)
4703 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4704 sizes, since they can exceed INT_MAX in size. Check for size
4705 calculation overflow.
4706
4707 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4708 (xg_select): Check for size calculation overflow.
4709 Don't update size until alloc done.
4710
4711 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4712 as sprintf is limited to int lengths.
4713
4714 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4715 (X_LONG_MIN): New macros.
4716 Use them to make the following changes clearer.
4717 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4718 This change doesn't affect the value now, but it may help remind
4719 future maintainers not to raise the value too much later.
4720 (SELECTION_QUANTUM): Remove, replacing with ...
4721 (selection_quantum): ... new function, which avoids overflow.
4722 All uses changed.
4723 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4724 assumption that selection length fits in 'int'.
4725 (x_reply_selection_request, x_handle_selection_request)
4726 (x_get_window_property, receive_incremental_selection)
4727 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4728 (lisp_data_to_selection_data, clean_local_selection_data):
4729 Use ptrdiff_t, not int, to record length of selection.
4730 (x_reply_selection_request, x_get_window_property)
4731 (receive_incremental_selection, x_property_data_to_lisp):
4732 Redo calculations to avoid overflow.
4733 (x_reply_selection_request): When sending hint, ceiling it at
4734 X_LONG_MAX rather than relying on wraparound overflow to send
4735 something.
4736 (x_get_window_property, receive_incremental_selection)
4737 (lisp_data_to_selection_data, x_property_data_to_lisp):
4738 Check for size-calculation overflow.
4739 (x_get_window_property, receive_incremental_selection)
4740 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4741 Don't store size until memory allocation succeeds.
4742 (x_get_window_property): Plug memory leak on memory exhaustion.
4743 Don't double-block input; malloc is safe here. Don't assume 2**34
4744 - 4 fits in unsigned long. Add an xassert to check
4745 XGetWindowProperty overflow. Be more careful about overflow
4746 calculations, and distinguish size from memory overflow better.
4747 (receive_incremental_selection): When tracing, don't assume
4748 unsigned int is less than INT_MAX.
4749 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4750 harmful) conversions of unsigned short to int.
4751 (lisp_data_to_selection_data): Don't assume that integers
4752 in the range -65535 through -1 fit in an X unsigned short.
4753 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4754 result parameters unless successful. Rely on cons_to_unsigned
4755 to report problems with elements; the old code wasn't right anyway.
4756 (x_check_property_data): Check for int overflow; we cannot use
4757 a wider type due to X limits.
4758 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4759
4760 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4761
4762 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4763 (x_term_init): Check for size calculation overflow.
4764 (x_color_cells): Don't store size until memory allocation succeeds.
4765 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4766 Don't assume alloca size is less than MAX_ALLOCA.
4767 (x_term_init): Don't assume length fits in int (sprintf is limited
4768 to int size).
4769
4770 Use ptrdiff_t for composition IDs.
4771 * character.c (lisp_string_width):
4772 * composite.c (composition_table_size, n_compositions)
4773 (get_composition_id, composition_gstring_from_id):
4774 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4775 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4776 * window.c (Frecenter):
4777 Use ptrdiff_t, not int, for composition IDs.
4778 * composite.c (get_composition_id): Check for integer overflow.
4779 * composite.h: Adjust prototypes to match the above changes.
4780
4781 Use ptrdiff_t for hash table indexes.
4782 * category.c (hash_get_category_set):
4783 * ccl.c (ccl_driver):
4784 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4785 * coding.c (coding_system_charset_list, detect_coding_system):
4786 * coding.h (struct coding_system.id):
4787 * composite.c (get_composition_id, gstring_lookup_cache):
4788 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4789 * image.c (xpm_get_color_table_h):
4790 * lisp.h (hash_lookup, hash_put):
4791 * minibuf.c (Ftest_completion):
4792 Use ptrdiff_t for hash table indexes, not int (which is too
4793 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4794 32-bit --with-wide-int hosts).
4795
4796 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4797 Add a FIXME comment about memory leaks.
4798 (syms_of_charset): Don't assume xmalloc returns.
4799
4800 Don't assume that stated character widths fit in int.
4801 * character.c (Fchar_width, c_string_width, lisp_string_width):
4802 * character.h (CHAR_WIDTH):
4803 * indent.c (MULTIBYTE_BYTES_WIDTH):
4804 Use sanitize_char_width to avoid undefined and/or bad behavior
4805 with outlandish widths.
4806 * character.h (sanitize_tab_width): Rename from sanitize_width,
4807 now that we have two such functions. All uses changed.
4808 (sanitize_char_width): New inline function.
4809
4810 Don't assume that tab-width fits in int.
4811 * character.h (sanitize_width): New inline function.
4812 (SANE_TAB_WIDTH): New macro.
4813 (ASCII_CHAR_WIDTH): Use it.
4814 * indent.c (sane_tab_width): Remove. All uses replaced by
4815 SANE_TAB_WIDTH (current_buffer).
4816 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4817
4818 * fileio.c: Integer overflow issues with file modes.
4819 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4820
4821 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4822 Remove unreachable code.
4823 (read_hex, load_charset_map_from_file): Check for integer overflow.
4824
4825 * xterm.c: Don't go over XClientMessageEvent limit.
4826 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4827 (x_send_scroll_bar_event): Likewise. Check that the size does not
4828 exceed limits imposed by XClientMessageEvent, as well as the usual
4829 ptrdiff_t and size_t limits.
4830
4831 * keyboard.c: Overflow, signedness and related fixes.
4832 (make_lispy_movement): Use same integer type in forward decl
4833 that is used in the definition.
4834 (read_key_sequence, keyremap_step):
4835 Change bufsize argument back to int, undoing my 2011-03-30 change.
4836 We prefer signed types, and int is wide enough here.
4837 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4838 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4839 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4840 length, not size_t. Use ptrdiff_t for index, not int.
4841 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4842 possibility of integer overflow.
4843
4844 Overflow, signedness and related fixes for images.
4845
4846 * dispextern.h (struct it.stack[0].u.image.image_id)
4847 (struct_it.image_id, struct image.id, struct image_cache.size)
4848 (struct image_cache.used, struct image_cache.ref_count):
4849 * gtkutil.c (update_frame_tool_bar):
4850 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4851 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4852 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4853 * nsmenu.m (update_frame_tool_bar):
4854 * xdisp.c (calc_pixel_width_or_height):
4855 * xfns.c (image_cache_refcount):
4856 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4857 on typical 64-bit hosts.
4858
4859 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4860 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4861 Omit unnecessary casts to int.
4862 (parse_image_spec): Check that integers fall into 'int' range
4863 when the callers expect that.
4864 (image_ascent): Redo ascent calculation to avoid int overflow.
4865 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4866 (lookup_image): Remove unnecessary tests.
4867 (xbm_image_p): Locals are now of int, not EMACS_INT,
4868 since parse_image_check makes sure they fit into int.
4869 (png_load, gif_load, svg_load_image):
4870 Prefer int to unsigned where either will do.
4871 (tiff_handler): New function, combining the cores of the
4872 old tiff_error_handler and tiff_warning_handler.
4873 This function is rewritten to use vsnprintf and thereby avoid
4874 stack buffer overflows. It uses only the features of vsnprintf
4875 that are common to both POSIX and native Microsoft.
4876 (tiff_error_handler, tiff_warning_handler): Use it.
4877 (tiff_load, gif_load, imagemagick_load_image):
4878 Don't assume :index value fits in 'int'.
4879 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4880 (imagemagick_load_image): Check that crop parameters fit into
4881 the integer types that MagickCropImage accepts. Don't assume
4882 Vimagemagick_render_type has a nonnegative value. Don't assume
4883 size_t fits in 'long'.
4884 (gs_load): Use printmax_t to print the widest integers possible.
4885 Check for integer overflow when computing image height and width.
4886
4887 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4888
4889 * xdisp.c (redisplay_window): Don't force window start if point
4890 will be invisible in the resulting window. (Bug#9324)
4891
4892 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4893
4894 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4895 the display spec is of the form `(space ...)'.
4896 (handle_display_spec): Return the value returned by
4897 handle_single_display_spec, not just 1 or zero.
4898 (handle_single_display_spec): If the display spec is of the form
4899 `(space ...)', and specifies display in the text area, return 2
4900 rather than 1.
4901 (try_cursor_movement): Check for the need to scroll more
4902 accurately, and prefer exact match for point under bidi.
4903 Don't advance `row' beyond the last row of the window.
4904
4905 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4906 into disp_prop; all users changed.
4907
4908 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4909 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4910 for the text covered by the display property.
4911
4912 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4913
4914 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4915 Change return value to nil.
4916 (Frecord_buffer): Delete unused function.
4917
4918 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4919
4920 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4921 buffers, return left-to-right.
4922 (set_cursor_from_row): Consider candidate row a win if its glyph
4923 represents a newline and point is on that newline. Fixes cursor
4924 positioning on the newline at EOL of R2L text within L2R
4925 paragraph, and vice versa.
4926 (try_cursor_movement): Check continued rows, in addition to
4927 continuation rows. Fixes unwarranted scroll when point enters a
4928 continued line of R2L text within an L2R paragraph, or vice versa.
4929 (cursor_row_p): Consider the case of point being equal to
4930 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4931 from the end of a short line to the beginning of a continued line
4932 of R2L text within L2R paragraph.
4933 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4934 composed characters.
4935
4936 * bidi.c (bidi_check_type): Use xassert.
4937 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4938 members.
4939
4940 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4941
4942 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4943 a character.
4944
4945 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4946
4947 * nsfont.m (ns_otf_to_script): Fix typo.
4948
4949 2011-08-22 Kenichi Handa <handa@m17n.org>
4950
4951 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4952 extra slot even if the purpose is char-code-property-table.
4953
4954 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4955
4956 * xdisp.c (redisplay_window): When computing centering_position,
4957 account for the height of the header line. (Bug#8874)
4958
4959 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4960 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4961 candidate is selected by the mouse, and that candidate has a
4962 composed character under the mouse.
4963
4964 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4965 coordinates reported by pos-visible-in-window-p for a composed
4966 character in column zero.
4967
4968 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4969
4970 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4971
4972 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4973
4974 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4975 consider it a hit if to_charpos is anywhere in the range of the
4976 composed buffer positions.
4977
4978 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4979
4980 * image.c (gif_load): Don't assume that each subimage has the same
4981 dimensions as the base image. Handle disposal method that is
4982 "undefined" by the gif spec (Bug#9335).
4983
4984 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4985
4986 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4987 (Fcondition_case): Document `debug' symbol in error handler.
4988
4989 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4990
4991 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4992 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4993 from an Org mode buffer to a Speedbar frame.
4994
4995 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4996 a composition, take its buffer position from IT->cmp_it.charpos.
4997 Fixes cursor positioning at the beginning of a line that begins
4998 with a composed character.
4999
5000 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5001
5002 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5003 character bidirectional type, use STRONG_L instead. Fixes crashes
5004 in a buffer produced by `describe-categories'.
5005
5006 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5007 members before the level stack, so they would be saved and
5008 restored when copying iterator state. Fixes incorrect reordering
5009 around TABs covered by display properties.
5010
5011 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5012
5013 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5014
5015 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5016
5017 * eval.c (internal_condition_case, internal_condition_case_1)
5018 (internal_condition_case_2, internal_condition_case_n):
5019 Remove unnecessary aborts (Bug#9081).
5020
5021 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5022
5023 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5024 has no `load' handler, try opening the file locally. (Bug#9311)
5025
5026 2011-08-16 Ken Brown <kbrown@cornell.edu>
5027
5028 * gmalloc.c: Expand comment.
5029
5030 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5031
5032 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5033 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5034
5035 2011-08-16 Ken Brown <kbrown@cornell.edu>
5036
5037 Fix memory allocation problems in Cygwin build (Bug#9273).
5038
5039 * unexcw.c ( __malloc_initialized): Declare external variable.
5040 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5041
5042 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5043 New variables.
5044 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5045 dumped emacs.
5046 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5047 in the static heap.
5048 [CYGWIN] (special_realloc): New function.
5049 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5050 requests to realloc storage in the static heap.
5051
5052 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5053
5054 * bidi.c (bidi_initialize): Remove unused local.
5055
5056 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5057
5058 * bidimirror.h:
5059 * biditype.h: Remove file.
5060 * makefile.w32-in ($(BLD)/bidi.$(O)):
5061 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5062
5063 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5064
5065 * chartab.c: Improve commentary for the uniprop_table API.
5066
5067 * bidi.c (bidi_paragraph_init): Support zero value of
5068 bidi_ignore_explicit_marks_for_paragraph_level.
5069 (bidi_initialize): Use uniprop_table instead of including
5070 biditype.h and bidimirror.h.
5071
5072 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5073 coordinates of the iterator when restoring from ppos_it.
5074 (Bug#9296)
5075
5076 2011-08-14 Kenichi Handa <handa@m17n.org>
5077
5078 * process.c (create_process): Call setup_process_coding_systems
5079 after the pid of the process is set to -1 (Bug#8162).
5080
5081 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5082
5083 * xdisp.c (move_it_in_display_line_to): Don't invoke
5084 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5085 ppos_it. Fixes vertical cursor motion when line beginning is
5086 covered by an image. (Bug#9296)
5087
5088 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5089
5090 * nsterm.h (ns_run_ascript): Declare.
5091 (NSAPP_DATA2_RUNASSCRIPT): Define.
5092
5093 * nsfns.m (as_script, as_result, as_status): New static variables.
5094 (ns_run_ascript): New function.
5095 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5096 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5097 the event loop. Get status from as_status (Bug#7276).
5098
5099 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5100 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5101 the event loop (Bug#7276).
5102
5103 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5104
5105 * gnutls.c (QCgnutls_bootprop_priority)
5106 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5107 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5108 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5109 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5110 (QCgnutls_bootprop_verify_hostname_error)
5111 (QCgnutls_bootprop_callbacks_verify): Rename from
5112 Qgnutls_bootprop_..., all uses changed.
5113
5114 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5115 uses changed.
5116
5117 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5118
5119 * xfaces.c (Qframe_set_background_mode): Now static.
5120 * dispextern.h (Qframe_set_background_mode): Remove decl.
5121
5122 * process.c (Fnetwork_interface_info): Declare local only if needed.
5123
5124 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5125
5126 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5127 (Fnetwork_interface_list): Allocate in increments of bytes instead
5128 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5129 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5130 sockaddr.
5131 (struct ifflag_def): notrailers is smart on OSX.
5132 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5133 Get hardware address with getifaddrs if available.
5134
5135 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5136
5137 * xdisp.c (iterate_out_of_display_property): xassert that
5138 IT->position is set to within IT->object's boundaries. Break from
5139 the loop as soon as EOB is reached; avoids infloops in redisplay
5140 when IT->position is set up wrongly due to some bug.
5141 Set IT->current to match the bidi iterator unconditionally.
5142 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5143 entry. Force push_it to save on the stack the current
5144 buffer/string position, to be restored by pop_it. Fix flags in
5145 the iterator structure wrt the object coming from a display
5146 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5147 properties. (Bug#9284)
5148
5149 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5150
5151 * fontset.c (fontset_get_font_group): Add proper type checks.
5152 (Bug#9172)
5153
5154 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5155
5156 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5157 and LC_VERSION_MIN_MACOSX.
5158 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5159 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5160
5161 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5162
5163 * xdisp.c (forward_to_next_line_start): Allow to use the
5164 no-display-properties-and-no-overlays under bidi display.
5165 Set disp_pos in the bidi iterator to avoid searches for display
5166 properties and overlays.
5167
5168 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5169
5170 * editfns.c (Fset_time_zone_rule): Document relationship with the
5171 setenv function.
5172
5173 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5174 the font entity extracted from the cache (Bug#8109).
5175
5176 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5177
5178 * composite.c (autocmp_chars): Don't reset point. That is done by
5179 restore_point_unwind (Bug#5984).
5180
5181 2011-08-07 Juri Linkov <juri@jurta.org>
5182
5183 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5184 to show the arg `TIME' instead of `TIMEVAL'.
5185
5186 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5187
5188 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5189 display property strides EOL and includes a newline, as in
5190 longlines-mode. (Bug#9254)
5191 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5192 word-wrap under bidirectional display. (Bug#9224)
5193
5194 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5195 is non-zero, even if the data buffer is NULL. Fixes a crash in
5196 vertical-motion with longlines-mode. (Bug#9254)
5197
5198 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5199
5200 * bidi.c <bidi_cache_total_alloc>: Now static.
5201 (bidi_initialize): Initialize bidi_cache_total_alloc.
5202
5203 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5204 cache. (Bug#9221)
5205
5206 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5207 amount allocated this far in `bidi_cache_total_alloc'.
5208 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5209 non-zero, only free the data buffer without restoring the cache
5210 contents. All callers changed.
5211
5212 * dispextern.h (bidi_unshelve_cache): Update prototype.
5213
5214 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5215 (move_it_in_display_line, move_it_to)
5216 (move_it_vertically_backward, move_it_by_lines): Replace the call
5217 to xfree to an equivalent call to bidi_unshelve_cache.
5218 (move_it_in_display_line_to): Fix logic of returning
5219 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5220
5221 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5222
5223 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5224 came from a string character with a `cursor' property. (Bug#9229)
5225
5226 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5227
5228 * Makefile.in (LIB_PTHREAD): New variable.
5229 (LIBES): Add LIB_PTHREAD (Bug#9216).
5230
5231 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5232 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5233
5234 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5235
5236 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5237
5238 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5239
5240 * xterm.c (x_find_topmost_parent): New function.
5241 (x_set_frame_alpha): Find topmost parent window with
5242 x_find_topmost_parent and set the property there also (bug#9181).
5243 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5244
5245 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5246
5247 * callproc.c (Fcall_process): Avoid vfork clobbering
5248 the local vars buffer, coding_systems, current_dir.
5249
5250 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5251
5252 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5253
5254 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5255
5256 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5257 so that it is not optimized away.
5258
5259 * xdisp.c (compute_display_string_pos): Remove unused local.
5260
5261 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5262
5263 Fix slow cursor motion and scrolling in large buffers with
5264 selective display, like Org Mode buffers. (Bug#9218)
5265
5266 * dispextern.h (struct bidi_it): New member disp_prop_p.
5267
5268 * xdisp.c: Remove one-slot cache of display string positions.
5269 (compute_display_string_pos): Accept an additional argument
5270 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5271 for a display string or property. If found, set DISP_PROP_P
5272 non-zero.
5273
5274 * bidi.c (bidi_fetch_char): Accept an additional argument
5275 DISP_PROP_P, and pass it to compute_display_string_pos.
5276 Only handle text covered by a display string if DISP_PROP_P is returned
5277 non-zero. All callers of bidi_fetch_char changed.
5278
5279 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5280
5281 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5282
5283 2010-12-03 Don March <don@ohspite.net>
5284
5285 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5286 last character M-[char] is translated to ESC [char] (bug#7541).
5287
5288 2011-08-02 Kenichi Handa <handa@m17n.org>
5289
5290 * lisp.h (uniprop_table): Extern it.
5291
5292 * chartab.c (uniprop_table): Make it non-static.
5293
5294 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5295
5296 * xdisp.c (forward_to_next_line_start): Accept additional argument
5297 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5298 on the newline.
5299 (reseat_at_next_visible_line_start): Use the bidi iterator state
5300 returned by forward_to_next_line_start to restore the state of
5301 it->bidi_it after backing up to previous newline. (Bug#9212)
5302
5303 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5304
5305 * regex.c (re_comp): Protoize.
5306 (re_exec): Fix return type.
5307 (regexec): Fix type of `ret'. (Bug#9203)
5308
5309 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5310
5311 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5312 This is needed if max-image-size is a floating-point number.
5313
5314 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5315
5316 * print.c (print_object): Print empty symbol as ##.
5317
5318 * lread.c (read1): Read ## as empty symbol.
5319
5320 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5321
5322 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5323 setting frame foreground color (Bug#9175).
5324 (x_set_background_color): Likewise.
5325
5326 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5327 contents (Bug#9176).
5328 (EmacsTooltip -init): Remove bezels and add shadows to
5329 tooltip windows.
5330
5331 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5332 or scroll bar (Bug#8470).
5333
5334 * nsfont.m (nsfont_open): Remove assignment to voffset and
5335 unnecessary vars hshink, expand, hd, full_height, min_height.
5336 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5337
5338 * nsterm.h (nsfont_info): Remove voffset field.
5339
5340 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5341
5342 Implement strike-through and overline on NextStep (Bug#8863).
5343
5344 * nsfont.m (nsfont_open): Use underline position provided by font,
5345 instead of hard-coded value of 2.
5346 (nsfont_draw): Call ns_draw_text_decoration instead.
5347
5348 * nsterm.h: Add declaration for ns_draw_text_decoration.
5349
5350 * nsterm.m (ns_draw_text_decoration): New function for drawing
5351 underline, overline, and strike-through.
5352 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5353 ns_draw_text_decoration. Change treatment of cursor drawing to
5354 accommodate underlining, etc.
5355
5356 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5357
5358 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5359 default.
5360
5361 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5362
5363 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5364 Without this fix, if a signal arrives just after memory fills up,
5365 'malloc' might be invoked reentrantly.
5366
5367 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5368 In other words, assume that every image size is allowed, on non-X
5369 hosts. This assumption is probably wrong, but it lets Emacs compile.
5370
5371 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5372
5373 * regex.c (re_iswctype): Convert return values to boolean.
5374
5375 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5376
5377 * xdisp.c (compute_display_string_pos): Don't use cached display
5378 string position if the buffer had its restriction changed.
5379 (Bug#9184)
5380
5381 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5382
5383 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5384
5385 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5386
5387 Integer signedness and overflow and related fixes. (Bug#9079)
5388
5389 * bidi.c: Integer size and overflow fixes.
5390 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5391 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5392 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5393 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5394 (bidi_find_other_level_edge):
5395 Use ptrdiff_t instead of EMACS_INT where either will do.
5396 This works better on 32-bit hosts configured --with-wide-int.
5397 (bidi_cache_ensure_space): Check for size-calculation overflow.
5398 Use % rather than repeated addition, for better worst-case speed.
5399 Don't set bidi_cache_size until after xrealloc returns, because it
5400 might not return.
5401 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5402 (bidi_cache_ensure_space): Also check that the bidi cache size
5403 does not exceed that of the largest Lisp string or buffer. See Eli
5404 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5405
5406 * alloc.c (__malloc_size_t): Remove.
5407 All uses replaced by size_t. See Andreas Schwab's note
5408 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5409
5410 * image.c: Improve checking for integer overflow.
5411 (check_image_size): Assume that f is nonnull, since
5412 it is always nonnull in practice. This is one less thing to
5413 worry about when checking for integer overflow later.
5414 (x_check_image_size): New function, which checks for integer
5415 overflow issues inside X.
5416 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5417 This removes the need for a memory_full check.
5418 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5419 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5420 (xbm_read_bitmap_data): Change locals back to 'int', since
5421 their values must fit in 'int'.
5422 (xpm_load_image, png_load, tiff_load):
5423 Invoke x_create_x_image_and_pixmap earlier,
5424 to avoid much needless work if the image is too large.
5425 (tiff_load): Treat overly large images as if
5426 x_create_x_image_and_pixmap failed, not as malloc failures.
5427 (gs_load): Use x_check_image_size.
5428
5429 * gtkutil.c: Omit integer casts.
5430 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5431 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5432
5433 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5434
5435 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5436 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5437 would wrongly return t on a 64-bit host.
5438
5439 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5440 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5441 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5442 and therefore cause GCC to emit a bogus diagnostic in some cases.
5443
5444 * image.c: Integer signedness and overflow and related fixes.
5445 This is not an exhaustive set of fixes, but it's time to
5446 record what I've got.
5447 (lookup_pixel_color, check_image_size): Remove redundant decls.
5448 (check_image_size): Don't assume that arbitrary EMACS_INT values
5449 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5450 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5451 (tiff_load, imagemagick_load_image):
5452 Check for overflow in size calculations.
5453 (x_create_x_image_and_pixmap): Remove unnecessary test for
5454 xmalloc returning NULL; that can't happen.
5455 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5456 (xpm_color_bucket): Use better integer hashing function.
5457 (xpm_cache_color): Don't possibly over-allocate memory.
5458 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5459 (gif_memory_source):
5460 Use ptrdiff_t, not int or size_t, to record sizes.
5461 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5462 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5463 either works, as we prefer signed integers.
5464 (tiff_read_from_memory, tiff_write_from_memory):
5465 Return tsize_t, not size_t, since that's what the TIFF API wants.
5466 (tiff_read_from_memory): Don't fail simply because the read would
5467 go past EOF; instead, return a short read.
5468 (tiff_load): Omit no-longer-needed casts.
5469 (Fimagemagick_types): Don't assume size fits into 'int'.
5470
5471 Improve hashing quality when configured --with-wide-int.
5472 * fns.c (hash_string): New function, taken from sxhash_string.
5473 Do not discard information about ASCII character case; this
5474 discarding is no longer needed.
5475 (sxhash-string): Use it. Change sig to match it. Caller changed.
5476 * lisp.h: Declare it.
5477 * lread.c (hash_string): Remove, since we now use fns.c's version.
5478 The fns.c version returns a wider integer if --with-wide-int is
5479 specified, so this should help the quality of the hashing a bit.
5480
5481 * emacs.c: Integer overflow minor fix.
5482 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5483 Define only if GNU_LINUX.
5484 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5485
5486 * dispnew.c: Integer signedness and overflow fixes.
5487 Remove unnecessary forward decls, that were a maintenance hassle.
5488 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5489 All uses changed.
5490 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5491 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5492 (prepare_desired_row, line_draw_cost):
5493 Use int, not unsigned, where either works.
5494 (save_current_matrix, restore_current_matrix):
5495 Use ptrdiff_t, not size_t, where either works.
5496 (init_display): Check for overflow more accurately, and without
5497 relying on undefined behavior.
5498
5499 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5500 Remove, replacing with the new symbols in lisp.h. All uses changed.
5501 * fileio.c (make_temp_name):
5502 * filelock.c (lock_file_1, lock_file):
5503 * xdisp.c (message_dolog):
5504 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5505 Use pMd etc. instead.
5506 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5507 replacing the pWIDE etc. symbols removed from editfns.c.
5508
5509 * keyboard.h (num_input_events): Now uintmax_t.
5510 This is (very slightly) less likely to mess up due to wraparound.
5511 All uses changed.
5512
5513 * buffer.c: Integer signedness fixes.
5514 (alloc_buffer_text, enlarge_buffer_text):
5515 Use ptrdiff_t rather than size_t when either will do, as we prefer
5516 signed integers.
5517
5518 * alloc.c: Integer signedness and overflow fixes.
5519 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5520 (__malloc_size_t): Default to size_t, not to int.
5521 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5522 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5523 Prefer ptrdiff_t to size_t when either would do, as we prefer
5524 signed integers.
5525 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5526 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5527 Now const. Initialize with values that are in range even if char
5528 is signed.
5529 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5530 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5531 These functions do the right thing with sizes > 2**32.
5532 (check_depth): Now ptrdiff_t, not int.
5533 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5534 Adjust to new way of storing sizes. Check for size overflow bugs
5535 in rest of code.
5536 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5537 slightly wrong anyway, as it missed one instance of
5538 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5539 (refill_memory_reserve): Omit needless cast to size_t.
5540 (mark_object_loop_halt): Mark as externally visible.
5541
5542 * xselect.c: Integer signedness and overflow fixes.
5543 (Fx_register_dnd_atom, x_handle_dnd_message):
5544 Use ptrdiff_t, not size_t, since we prefer signed.
5545 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5546 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5547 x_dnd_atoms_size and x_dnd_atoms_length.
5548
5549 * doprnt.c: Prefer signed to unsigned when either works.
5550 * eval.c (verror):
5551 * doprnt.c (doprnt):
5552 * lisp.h (doprnt):
5553 * xdisp.c (vmessage):
5554 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5555 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5556 prefer signed arithmetic to avoid comparison confusion.
5557 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5558 but is a bit tricky.
5559
5560 Assume freestanding C89 headers, string.h, stdlib.h.
5561 * data.c, doprnt.c, floatfns.c, print.c:
5562 Include float.h unconditionally.
5563 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5564 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5565 * regex.c: Likewise for stddef.h, string.h.
5566 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5567 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5568 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5569 (STDC_HEADERS): Remove obsolete defines.
5570 * sysdep.c: Include limits.h unconditionally.
5571
5572 Assume support for memcmp, memcpy, memmove, memset.
5573 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5574 * regex.c (memcmp, memcpy):
5575 Remove; we assume C89 now.
5576
5577 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5578 (__malloc_safe_bcopy): Remove; no longer needed.
5579
5580 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5581 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5582 well either way, and we prefer signed to unsigned.
5583
5584 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5585
5586 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5587 closes the connection while we're reading (bug#9182).
5588
5589 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5590
5591 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5592 are specified (Bug#9168).
5593
5594 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5595
5596 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5597 Found by GCC static checking and --with-wide-int on a 32-bit host.
5598
5599 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5600
5601 * xdisp.c (compute_display_string_pos): Fix logic of caching
5602 previous display string position. Initialize cached_prev_pos to
5603 -1. Fixes slow-down at the beginning of a buffer.
5604
5605 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5606
5607 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5608 for attrs[LFACE_FONTSET_INDEX].
5609
5610 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5611
5612 * xml.c (parse_region): Remove unused local
5613 that was recently introduced.
5614
5615 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5616
5617 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5618 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5619
5620 * xdisp.c (move_it_in_display_line_to): Record the best matching
5621 position for TO_CHARPOS while scanning the line, and restore it on
5622 exit if none of the characters scanned was an exact match.
5623 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5624 when exact match is impossible due to invisible text, and the
5625 lines are truncated.
5626
5627 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5628
5629 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5630 for OSX >= 10.7.
5631
5632 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5633
5634 Fix a significant slow-down of cursor motion with C-n, C-p,
5635 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5636 auto-repeat under bidi redisplay in fontified buffers.
5637 * xdisp.c (compute_stop_pos_backwards): New function.
5638 (next_element_from_buffer): Call compute_stop_pos_backwards to
5639 find a suitable prev_stop when we find ourselves before
5640 base_level_stop.
5641 (reseat): Don't look for prev_stop, as that could mean a very long
5642 run.
5643 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5644 <cached_disp_overlay_modiff>: Cache for last found display string
5645 position.
5646 (compute_display_string_pos): Return the cached position if asked
5647 about the same buffer in the same area of character positions, and
5648 the buffer wasn't changed since the time the display string
5649 position was cached.
5650
5651 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5652
5653 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5654 is an integer, which is important for empty lines. (Bug#9149)
5655
5656 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5657
5658 * frame.c (Fmodify_frame_parameters): In tty case, update the
5659 default face if necessary (Bug#4238).
5660
5661 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5662
5663 * editfns.c (Fstring_to_char): No need to explain what a character
5664 is in the docstring (Bug#6576).
5665
5666 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5667
5668 * xml.c (parse_region): Make sure we always return a tree.
5669
5670 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5671
5672 * xml.c (parse_region): If a document contains only comments,
5673 return that, too.
5674
5675 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5676
5677 * xml.c (make_dom): Return comments, too.
5678
5679 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5680
5681 Port to OpenBSD.
5682 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5683 and the surrounding thread.
5684 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5685 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5686 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5687 timer goes off.
5688 * s/openbsd.h (BROKEN_SIGIO): Define.
5689 * unexelf.c (unexec) [__OpenBSD__]:
5690 Don't update the .mdebug section of the Alpha COFF symbol table.
5691
5692 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5693
5694 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5695 (bug#8460).
5696
5697 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5698
5699 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5700 This fixes some race conditions on the permissions of any newly
5701 created file.
5702
5703 * alloc.c (valid_pointer_p): Use pipe, not open.
5704 This fixes some permissions issues when debugging.
5705
5706 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5707 If fchown fails to set both uid and gid, try to set just gid,
5708 as that is sometimes allowed. Adjust the file's mode to eliminate
5709 setuid or setgid bits that are inappropriate if fchown fails.
5710
5711 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5712
5713 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5714 to compare Lisp_Objects.
5715 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5716 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5717 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5718
5719 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5720
5721 * lread.c (read_integer): Unread even EOF character.
5722 (read1): Likewise. Properly record start position of symbol.
5723
5724 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5725 symbol character follows.
5726
5727 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5728
5729 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5730 This works around a problem with the previous change to Fcopy_file.
5731 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5732 and without this change, GCC might complain about discarding
5733 fchown's return value.
5734
5735 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5736
5737 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5738
5739 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5740
5741 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5742
5743 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5744
5745 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5746 it's used from the C level.
5747
5748 * process.c: Use the same condition for POLL_FOR_INPUT in both
5749 keyboard.c and process.c (bug#1858).
5750
5751 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5752
5753 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5754 (Fgnutls_boot): Use it.
5755
5756 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5757
5758 * doc.c (Fsubstitute_command_keys): Revert last change.
5759
5760 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5761
5762 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5763 quotes the next character, and doesn't affect other longer
5764 sequences (bug#8935).
5765
5766 * lread.c (syms_of_lread): Clarify that is isn't only
5767 `eval-buffer' and `eval-defun' that's affected by
5768 `lexical-binding' (bug#8460).
5769
5770 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5771
5772 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5773 bidi redisplay when a line includes both an image and is truncated.
5774
5775 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5776
5777 Fix minor problems found by static checking.
5778 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5779 (elsz): Now a signed constant, not a size_t var. We prefer signed
5780 types to unsigned, to avoid integer comparison confusion. Without
5781 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5782 "cannot optimize loop, the loop counter may overflow", a symptom
5783 of the confusion.
5784 * indent.c (Fvertical_motion): Mark locals as initialized.
5785 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5786
5787 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5788
5789 * search.c (Fre_search_backward): Mention `case-fold-search' in
5790 all the re_search_* functions (bug#8138).
5791
5792 * keyboard.c (Fopen_dribble_file): Document when the file is
5793 closed (bug#8056).
5794
5795 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5796
5797 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5798 bidi_cache_idx.
5799
5800 Support bidi reordering of display and overlay strings.
5801 * xdisp.c (compute_display_string_pos)
5802 (compute_display_string_end): Accept additional argument STRING.
5803 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5804 (reseat_to_string): Initialize bidi_it->string.s and
5805 bidi_it->string.schars.
5806 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5807 NULL (avoids a crash in bidi_paragraph_init).
5808 Initialize itb.string.lstring.
5809 (init_iterator): Call bidi_init_it only of a valid
5810 buffer position was specified. Initialize paragraph_embedding to
5811 L2R.
5812 (reseat_to_string): Initialize the bidi iterator.
5813 (display_string): If we need to ignore text properties of
5814 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5815 original value of -1 will not work with bidi.)
5816 (compute_display_string_pos): First arg is now struct
5817 `text_pos *'; all callers changed. Support display properties on
5818 Lisp strings.
5819 (compute_display_string_end): Support display properties on Lisp
5820 strings.
5821 (init_iterator, reseat_1, reseat_to_string): Initialize the
5822 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5823 when iterating on a string not from display properties).
5824 (compute_display_string_pos, compute_display_string_end):
5825 Fix calculation of the object to scan. Fixes an error when using
5826 arrow keys.
5827 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5828 base_level_stop; instead, set base_level_stop to BEGV.
5829 Fixes crashes in vertical-motion.
5830 (next_element_from_buffer): Improve commentary for when
5831 the iterator is before prev_stop.
5832 (init_iterator): Initialize bidi_p from the default value of
5833 bidi-display-reordering, not from buffer-local value. Use the
5834 buffer-local value only if initializing for buffer iteration.
5835 (handle_invisible_prop): Support invisible properties on strings
5836 that are being bidi-reordered.
5837 (set_iterator_to_next): Support bidi reordering of C strings and
5838 Lisp strings.
5839 (next_element_from_string): Support bidi reordering of Lisp
5840 strings.
5841 (handle_stop_backwards): Support Lisp strings as well.
5842 (display_string): Support display of R2L glyph rows.
5843 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5844 (init_iterator): Don't initialize it->bidi_p for strings
5845 here.
5846 (reseat_to_string): Initialize it->bidi_p for strings here.
5847 (next_element_from_string, next_element_from_c_string)
5848 (next_element_from_buffer): Add xassert's for correspondence
5849 between IT's object being iterated and it->bidi_it.string
5850 structure.
5851 (face_before_or_after_it_pos): Support bidi iteration.
5852 (next_element_from_c_string): Handle the case of the first string
5853 character that is not the first one in the visual order.
5854 (get_visually_first_element): New function, refactored from common
5855 parts of next_element_from_buffer, next_element_from_string, and
5856 next_element_from_c_string.
5857 (tool_bar_lines_needed, redisplay_tool_bar)
5858 (display_menu_bar): Force left-to-right direction. Add a FIXME
5859 comment for making that be controlled by a user option.
5860 (push_it, pop_it): Save and restore the state of the
5861 bidi iterator. Save and restore the bidi_p flag.
5862 (pop_it): Iterate out of display property for string iteration as
5863 well.
5864 (iterate_out_of_display_property): Support iteration over strings.
5865 (handle_single_display_spec): Set up it->bidi_it for iteration
5866 over a display string, and call bidi_init_it.
5867 (handle_single_display_spec, next_overlay_string)
5868 (get_overlay_strings_1, push_display_prop): Set up the bidi
5869 iterator for displaying display or overlay strings.
5870 (forward_to_next_line_start): Don't use the shortcut if
5871 bidi-iterating.
5872 (back_to_previous_visible_line_start): If handle_display_prop
5873 pushed the iterator stack, restore the internal state of the bidi
5874 iterator by calling bidi_pop_it same number of times.
5875 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5876 and we are bidi-iterating, don't decrement the iterator position;
5877 instead, set the first_elt flag in the bidi iterator, to produce
5878 the same effect.
5879 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5880 (push_display_prop): xassert that we are iterating a buffer.
5881 (push_it, pop_it): Save and restore paragraph_embedding member.
5882 (handle_single_display_spec, next_overlay_string)
5883 (get_overlay_strings_1, reseat_1, reseat_to_string)
5884 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5885 correctly. Don't assume unibyte strings are not bidi-reordered.
5886 (compute_display_string_pos)
5887 (compute_display_string_end): Fix handling the case of C string.
5888 (push_it, pop_it): Save and restore from_disp_prop_p.
5889 (handle_single_display_spec, push_display_prop): Set the
5890 from_disp_prop_p flag.
5891 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5892 (pop_it): Call iterate_out_of_display_property only if we are
5893 popping after iteration over a string that came from a display
5894 property. Fix a typo in popping stretch info. Add an assertion
5895 for verifying that the iterator position is in sync with the bidi
5896 iterator.
5897 (handle_single_display_spec, get_overlay_strings_1)
5898 (push_display_prop): Fix initialization of paragraph direction for
5899 string when that of the parent object is not yet determined.
5900 (reseat_1): Call bidi_init_it to resync the bidi
5901 iterator with IT's position. (Bug#7616)
5902 (find_row_edges): If ROW->start.pos gives position
5903 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5904 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5905 Reset the from_disp_prop_p flag.
5906 (SAVE_IT, RESTORE_IT): New macros.
5907 (pos_visible_p, face_before_or_after_it_pos)
5908 (back_to_previous_visible_line_start)
5909 (move_it_in_display_line_to, move_it_in_display_line)
5910 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5911 (try_scrolling, redisplay_window, display_line): Use them when
5912 saving a temporary copy of the iterator and restoring it back.
5913 (back_to_previous_visible_line_start, reseat_1)
5914 (init_iterator): Empty the bidi cache "stack".
5915 (move_it_in_display_line_to): If iterator ended up at
5916 EOL, but we never saw any buffer positions smaller than
5917 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5918 motion in bidi-reordered lines.
5919 (move_it_in_display_line_to): Record prev_method and prev_pos
5920 immediately before the call to set_iterator_to_next. Fixes cursor
5921 motion in bidi-reordered lines with stretch glyphs and strings
5922 displayed in margins. (Bug#8133) (Bug#8867)
5923 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5924 TO_CHARPOS.
5925 (pos_visible_p): Support positions in bidi-reordered lines.
5926 Save and restore bidi cache.
5927
5928 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5929 (bidi_paragraph_info): Delete unused struct.
5930 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5931 (bidi_cache_start): New variable.
5932 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5933 to zero.
5934 (bidi_cache_fetch_state, bidi_cache_search)
5935 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5936 (bidi_cache_find, bidi_peek_at_next_level)
5937 (bidi_level_of_next_char, bidi_find_other_level_edge)
5938 (bidi_move_to_visually_next): Compare cache index with
5939 bidi_cache_start rather than with zero.
5940 (bidi_fetch_char): Accept new argument STRING; all callers
5941 changed. Support iteration over a string. Support strings with
5942 display properties. Support unibyte strings. Fix the type of
5943 `len' according to what STRING_CHAR_AND_LENGTH expects.
5944 (bidi_paragraph_init, bidi_resolve_explicit_1)
5945 (bidi_resolve_explicit, bidi_resolve_weak)
5946 (bidi_level_of_next_char, bidi_move_to_visually_next):
5947 Support iteration over a string.
5948 (bidi_set_sor_type, bidi_resolve_explicit_1)
5949 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5950 can now be zero (for strings); special values 0 and -1 were
5951 changed to -1 and -2, respectively.
5952 (bidi_char_at_pos): New function.
5953 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5954 Call it instead of FETCH_MULTIBYTE_CHAR.
5955 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5956 initialized to valid values.
5957 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5958 values.
5959 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5960 the test for valid cached positions. Fix the logic for looking up
5961 the sentinel state in the cache. GCPRO the Lisp string we are
5962 iterating.
5963 (bidi_push_it, bidi_pop_it): New functions.
5964 (bidi_initialize): Initialize the bidi cache start stack pointer.
5965 (bidi_cache_ensure_space): New function, refactored from part of
5966 bidi_cache_iterator_state. Don't assume the required size is just
5967 one BIDI_CACHE_CHUNK away.
5968 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5969 (bidi_count_bytes, bidi_char_at_pos): New functions.
5970 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5971 always valid if bidi_cache_idx is valid.
5972 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5973 is valid if it's going to be used.
5974 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5975 (bidi_cache_fetch_state, bidi_cache_search)
5976 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5977 (bidi_cache_iterator_state, bidi_cache_find)
5978 (bidi_find_other_level_edge, bidi_cache_start_stack):
5979 All variables related to cache indices are now EMACS_INT.
5980
5981 * dispextern.h (struct bidi_string_data): New structure.
5982 (struct bidi_it): New member `string'. Make flag members be 1-bit
5983 fields, and put them last in the struct.
5984 (compute_display_string_pos, compute_display_string_end):
5985 Update prototypes.
5986 (bidi_push_it, bidi_pop_it): Add prototypes.
5987 (struct iterator_stack_entry): New members bidi_p,
5988 paragraph_embedding, and from_disp_prop_p.
5989 (struct it): Member bidi_p is now a bit field 1 bit wide.
5990 (bidi_shelve_cache, bidi_unshelve_cache):
5991 Declare prototypes.
5992
5993 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5994 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5995 and vector-like objects.
5996
5997 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5998 cache around display iteration.
5999
6000 * window.c (Fwindow_end, window_scroll_pixel_based)
6001 (displayed_window_lines, Frecenter): Save and restore the bidi
6002 cache around display iteration.
6003
6004 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6005
6006 * editfns.c (Fdelete_region): Clarify the use of the named
6007 parameters (bug#6788).
6008
6009 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6010
6011 * indent.c (Fvertical_motion): Set and restore w->pointm when
6012 saving and restoring the window's buffer (Bug#9006).
6013
6014 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6015
6016 * editfns.c (Fstring_to_char): Clarify just what is returned
6017 (bug#6576). Text by Eli Zaretskii.
6018
6019 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6020
6021 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6022
6023 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6024
6025 * buffer.c (mmap_find): Fix a typo.
6026
6027 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6028
6029 Fix execution of x selection hooks.
6030 * xselect.c (Qx_lost_selection_functions)
6031 (Qx_sent_selection_functions): New vars.
6032 (syms_of_xselect): DEFSYM them.
6033 (x_handle_selection_request): Pass Qx_sent_selection_functions
6034 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6035 (x_handle_selection_clear,x_clear_frame_selections):
6036 Pass Qx_lost_selection_functions rather than
6037 Vx_lost_selection_functions to Frun_hook_with_args.
6038
6039 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6040
6041 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6042 The old code sometimes used this field without initializing it.
6043
6044 * alloc.c (gc_sweep): Don't read past end of array.
6045 In theory, the old code could also have corrupted Emacs internals,
6046 though it'd be very unlikely.
6047
6048 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6049
6050 * character.c (Fcharacterp): Don't advertise optional ignored
6051 argument. (Bug#4026)
6052
6053 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6054
6055 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6056 key" (bug#4257).
6057
6058 * window.c (Fset_window_start): Doc fix (bug#4199).
6059 (Fset_window_hscroll): Ditto.
6060
6061 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6062
6063 Fix minor new problems caught by GCC 4.6.1.
6064 * term.c (init_tty): Remove unused local.
6065 * xsettings.c (store_monospaced_changed): Define this function only
6066 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6067 not used otherwise.
6068
6069 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6070
6071 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6072
6073 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6074
6075 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6076 are the mini-buffer and the echo area (bug#3320).
6077
6078 * term.c (init_tty): Remove support for supdup, c10 and perq
6079 terminals, which are no longer supported (bug#1482).
6080
6081 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6082
6083 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6084
6085 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6086
6087 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6088 for non-popups (Bug#3642).
6089
6090 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6091
6092 * alloc.c (reset_malloc_hooks): Protoize.
6093 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6094 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6095 * cm.c (losecursor): Likewise.
6096 * data.c (fmod): Likewise.
6097 * dispnew.c (swap_glyphs_in_rows): Likewise.
6098 * emacs.c (memory_warning_signal): Likewise.
6099 * floatfns.c (float_error): Likewise.
6100 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6101 (otf_open, font_otf_capability, generate_otf_features)
6102 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6103 Likewise.
6104 * image.c (pbm_read_file): Likewise.
6105 * indent.c (string_display_width): Likewise.
6106 * intervals.c (check_for_interval, search_for_interval)
6107 (inc_interval_count, count_intervals, root_interval)
6108 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6109 * lread.c (defalias): Likewise.
6110 * ralloc.c (r_alloc_check): Likewise.
6111 * regex.c (set_image_of_range_1, set_image_of_range)
6112 (regex_grow_registers): Likewise.
6113 * sysdep.c (strerror): Likewise.
6114 * termcap.c (valid_filename_p, tprint, main): Likewise.
6115 * tparam.c (main): Likewise.
6116 * unexhp9k800.c (run_time_remap, save_data_space)
6117 (update_file_ptrs, read_header, write_header, calculate_checksum)
6118 (copy_file, copy_rest, display_header): Likewise.
6119 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6120 Likewise.
6121 * xdisp.c (check_it): Likewise.
6122 * xfaces.c (register_color, unregister_color, unregister_colors):
6123 Likewise.
6124 * xfns.c (print_fontset_result): Likewise.
6125 * xrdb.c (member, fatal, main): Likewise.
6126
6127 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6128
6129 Fix minor problems found by static checking (Bug#9031).
6130 * chartab.c (char_table_set_range, map_sub_char_table):
6131 Remove unused locals.
6132 (uniprop_table): Now static.
6133 * composite.c (_work_char): Remove unused static var.
6134
6135 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6136
6137 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6138
6139 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6140
6141 * gtkutil.c (qttip_cb): Remove code without function.
6142
6143 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6144
6145 * w32.c (pthread_sigmask): New stub.
6146
6147 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6148
6149 Use pthread_sigmask, not sigprocmask (Bug#9010).
6150 sigprocmask is portable only for single-threaded applications, and
6151 Emacs can be multi-threaded when it uses GTK.
6152 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6153 (LIBES): Use it.
6154 * callproc.c (Fcall_process):
6155 * process.c (create_process):
6156 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6157 Use pthread_sigmask, not sigprocmask.
6158
6159 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6160
6161 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6162 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6163 wrong (Bug#8591).
6164
6165 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6166
6167 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6168 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6169 (xg_hide_tooltip): Fix comment.
6170
6171 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6172 in registerServicesMenuSendTypes.
6173 (validRequestorForSendType): Don't check ns_return_types.
6174
6175 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6176 ns_return_type.
6177
6178 2011-07-08 Jason Rumney <jasonr@gnu.org>
6179
6180 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6181 SH_SHOW for hidden windows (Bug#5482).
6182
6183 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6184 frame struct members of non-existent frames (Bug#6284).
6185
6186 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6187
6188 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6189 variable firstTime not needed on OSX >= 10.6.
6190 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6191 >= 10.5. Use setKnobProportion, setDoubleValue.
6192
6193 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6194 (MAC_OS_X_VERSION_10_5): Define if not defined.
6195 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6196 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6197 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6198
6199 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6200 cString and lossyCString on OSX >= 10.4
6201
6202 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6203 sizeToFit on OSX >= 10.2.
6204
6205 * nsimage.m (allocInitFromFile): Don't use deprecated method
6206 bestRepresentationForDevice on OSX >= 10.6.
6207
6208 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6209 to avoid warning.
6210
6211 * emacs.c: Declare unexec_init_emacs_zone.
6212
6213 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6214
6215 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6216
6217 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6218 on svcsMenu (Bug#8842).
6219
6220 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6221 ns_return_types.
6222 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6223
6224 * nsterm.m (QUTF8_STRING): Declare.
6225 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6226 (validRequestorForSendType): Return type is (id).
6227 Change indexOfObjectIdenticalTo to indexOfObject.
6228 Check if we have local selection before returning self (Bug#8842).
6229 (writeSelectionToPasteboard): Put local selection into paste board
6230 if we have a local selection (Bug#8842).
6231 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6232
6233 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6234 (ns_get_local_selection): Declare.
6235
6236 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6237
6238 * keymap.c (describe_map_tree): Don't insert a double newline at
6239 the end of the buffer (bug#1169) and return whether we inserted
6240 something.
6241
6242 * callint.c (Fcall_interactively): Change "reading args" to
6243 "providing args" to try to clarify what it does (bug#1010).
6244
6245 2011-07-07 Kenichi Handa <handa@m17n.org>
6246
6247 * composite.c (composition_compute_stop_pos): Ignore a static
6248 composition starting before CHARPOS (Bug#8915).
6249
6250 * xdisp.c (handle_composition_prop): Likewise.
6251
6252 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6253
6254 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6255 (Bug#9015)
6256
6257 2011-07-07 Kenichi Handa <handa@m17n.org>
6258
6259 * character.h (unicode_category_t): New enum type.
6260
6261 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6262 (Qchar_code_property_table): New variable.
6263 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6264 (UNIPROP_COMPRESSED_FORM_P): New macros.
6265 (char_table_ascii): Uncompress the compressed values.
6266 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6267 Uncompress the compressed values.
6268 (sub_char_table_ref_and_range): Likewise.
6269 (char_table_ref_and_range): Uncompress the compressed values.
6270 (sub_char_table_set): New arg is_uniprop. Callers changed.
6271 Uncompress the compressed values.
6272 (sub_char_table_set_range): Args changed. Callers changed.
6273 (char_table_set_range): Adjuted for the above change.
6274 (map_sub_char_table): Delete args default_val and parent. Add arg
6275 top. Give decoded values to a Lisp function.
6276 (map_char_table): Adjust for the above change. Give decoded
6277 values to a Lisp function. Gcpro more variables.
6278 (uniprop_table_uncompress)
6279 (uniprop_decode_value_run_length): New functions.
6280 (uniprop_decoder, uniprop_decoder_count): New variables.
6281 (uniprop_get_decoder, uniprop_encode_value_character)
6282 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6283 New functions.
6284 (uniprop_encoder, uniprop_encoder_count): New variables.
6285 (uniprop_get_encoder, uniprop_table)
6286 (Funicode_property_table_internal, Fget_unicode_property_internal)
6287 (Fput_unicode_property_internal): New functions.
6288 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6289 Sunicode_property_table_internal, Sget_unicode_property_internal,
6290 and Sput_unicode_property_internal. Defvar_lisp
6291 char-code-property-alist.
6292
6293 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6294 Vunicode_category_table.
6295
6296 * font.c (font_range): Adjust for the change of
6297 Vunicode_category_table.
6298
6299 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6300
6301 * m/iris4d.h: Remove file, move contents ...
6302 * s/irix6-5.h: ... here.
6303
6304 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6305
6306 Remove unportable assumption about struct layout (Bug#8884).
6307 * alloc.c (mark_buffer):
6308 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6309 (clone_per_buffer_values): Don't assume that
6310 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6311 This isn't true in general, and it's particularly not true
6312 if Emacs is configured with --with-wide-int.
6313 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6314 New macros, used in the buffer.c change.
6315
6316 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6317
6318 * xsettings.c: Use both GConf and GSettings if both are available.
6319 (store_config_changed_event): Add comment.
6320 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6321 (store_tool_bar_style_changed): New functions.
6322 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6323 (struct xsettings): Move font inside HAVE_XFT.
6324 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6325 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6326 Move inside HAVE_XFT.
6327 (something_changed_gsettingsCB): Rename from something_changedCB.
6328 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6329 also.
6330 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6331 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6332 (something_changed_gconfCB): Rename from something_changedCB.
6333 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6334 (parse_settings): Move check for font inside HAVE_XFT.
6335 (read_settings, apply_xft_settings): Add comment.
6336 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6337 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6338 call store_font_name_changed.
6339 (xft_settings_event): Add comment.
6340 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6341 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6342 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6343 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6344 (xsettings_initialize): Call init_gsettings last.
6345 (xsettings_get_system_font, xsettings_get_system_normal_font):
6346 Add comment.
6347
6348 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6349
6350 Random fixes. E.g., (random) never returned negative values.
6351 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6352 subseconds part to the entropy, as that's a bit more random.
6353 Prefer signed to unsigned, since the signedness doesn't matter and
6354 in general we prefer signed. When given a limit, use a
6355 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6356 latter isn't right if USE_2_TAGS_FOR_INTS.
6357 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6358 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6359
6360 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6361
6362 * textprop.c (text_property_stickiness):
6363 Obey Vtext_property_default_nonsticky.
6364 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6365 * w32fns.c (syms_of_w32fns):
6366 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6367
6368 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6369
6370 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6371 This is more efficient than Ffile_directory_p and avoids a minor race.
6372
6373 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6374
6375 * buffer.c (Foverlay_put): Say what the return value is
6376 (bug#7835).
6377
6378 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6379 is a directory before asking whether to use the file name
6380 (bug#7564).
6381 (barf_or_query_if_file_exists): Make the "File is a directory"
6382 error be more correct.
6383
6384 * fns.c (Frequire): Remove the mention of the .gz files, since
6385 that's installation-specific, but keep the mention of
6386 `get-load-suffixes'.
6387
6388 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6389
6390 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6391 Report string overflow if the output is too long.
6392
6393 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6394
6395 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6396 (syms_of_gnutls): Remove duplicate DEFSYM for
6397 Qgnutls_bootprop_verify_hostname_error, an error for
6398 Qgnutls_bootprop_verify_error (which is no longer used).
6399
6400 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6401 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6402 Also (re)move comments that are misplaced or no longer relevant.
6403
6404 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6405
6406 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6407
6408 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6409
6410 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6411 and background color parameters if they have been changed.
6412
6413 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6414
6415 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6416
6417 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6418
6419 * xsettings.c (SYSTEM_FONT): Define only when used.
6420 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6421
6422 * keymap.c (access_keymap_1): Now static.
6423
6424 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6425
6426 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6427 leave any prefix arg for the up event (Bug#1586).
6428
6429 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6430
6431 * lread.c (syms_of_lread): Mention single symbols defined by
6432 `defvar' or `defconst' (bug#7154).
6433
6434 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6435 (Frequire): Mention get-load-suffixes.
6436
6437 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6438
6439 * window.h (window): Remove clone_number slot.
6440 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6441 Remove.
6442 (make_parent_window, make_window, saved_window)
6443 (Fset_window_configuration, save_window_save): Don't deal with
6444 clone numbers.
6445 * buffer.c (Qclone_number): Remove declaration.
6446 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6447
6448 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6449
6450 Add multiple inheritance to keymaps.
6451 * keymap.c (Fmake_composed_keymap): New function.
6452 (Fset_keymap_parent): Simplify.
6453 (fix_submap_inheritance): Remove.
6454 (access_keymap_1): New function extracted from access_keymap to handle
6455 embedded parents and handle lists of maps.
6456 (access_keymap): Use it.
6457 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6458 (Fcopy_keymap): Handle embedded parents.
6459 (Fcommand_remapping, define_as_prefix): Simplify.
6460 (Fkey_binding): Simplify.
6461 (syms_of_keymap): Move minibuffer-local-completion-map,
6462 minibuffer-local-filename-completion-map,
6463 minibuffer-local-must-match-map, and
6464 minibuffer-local-filename-must-match-map to Elisp.
6465 (syms_of_keymap): Defsubr make-composed-keymap.
6466 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6467 (parse_menu_item): Trivial simplification.
6468
6469 2011-07-01 Glenn Morris <rgm@gnu.org>
6470
6471 * Makefile.in (SETTINGS_LIBS): Fix typo.
6472
6473 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6474
6475 * coding.c (Fencode_coding_string): Record the last coding system
6476 used, as the function doc string says (bug#8738).
6477
6478 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6479
6480 * xsettings.c (store_monospaced_changed): Take new font as arg and
6481 check for change against current_mono_font.
6482 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6483 (emacs_settings_constructor, emacs_settings_get_property)
6484 (emacs_settings_set_property, emacs_settings_class_init)
6485 (emacs_settings_init, gsettings_obj): Remove.
6486 (something_changedCB): New function for HAVE_GSETTINGS.
6487 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6488 with value as argument.
6489 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6490 g_settings_new (Bug#8967). Do not create gsettings_obj.
6491 Remove calls to g_settings_bind. Connect something_changedCB to
6492 "changed".
6493
6494 * xgselect.c: Add defined (HAVE_GSETTINGS).
6495 (xgselect_initialize): Ditto.
6496
6497 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6498 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6499 xg_select.
6500
6501 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6502
6503 * eval.c (struct backtrace): Simplify and port the data structure.
6504 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6505 signed bit field, as this assumption is not portable and it makes
6506 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6507 "char debug_on_exit : 1" as this is not portable either; instead,
6508 use the portable "unsigned int debug_on_exit : 1". Remove unused
6509 member evalargs. Remove obsolete comments about cc bombing out.
6510
6511 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6512
6513 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6514 Let HAVE_GSETTINGS override HAVE_GCONF.
6515 (store_monospaced_changed): New function.
6516 (EMACS_SETTINGS): A new type derived from GObject to handle
6517 GSettings notifications.
6518 (emacs_settings_constructor, emacs_settings_get_property)
6519 (emacs_settings_set_property, emacs_settings_class_init):
6520 New functions.
6521 (gsettings_client, gsettings_obj): New variables.
6522 (GSETTINGS_SCHEMA): New define.
6523 (something_changedCB): Call store_monospaced_changed.
6524 (init_gsettings): New function.
6525 (xsettings_initialize): Call init_gsettings.
6526 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6527 to NULL.
6528
6529 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6530 GCONF_CFLAGS/LIBS.
6531
6532 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6533
6534 * window.c (resize_root_window, grow_mini_window)
6535 (shrink_mini_window): Rename Qresize_root_window to
6536 Qwindow_resize_root_window and Qresize_root_window_vertically to
6537 Qwindow_resize_root_window_vertically.
6538
6539 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6540
6541 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6542
6543 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6544
6545 * makefile.w32-in: Redesign dependencies so they reflect more
6546 clearly which files are directly included by each source file,
6547 and not through other includes.
6548
6549 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6550
6551 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6552 (sort_overlays, overlay_strings): When an overlay's clone number
6553 matches the window's clone number process the overlay even if
6554 the overlay's window property doesn't match the current window.
6555
6556 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6557 (Fwindow_hchild): Rename to Fwindow_left_child.
6558 (Fwindow_next): Rename to Fwindow_next_sibling.
6559 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6560 (resize_window_check): Rename to window_resize_check.
6561 (resize_window_apply): Rename to window_resize_apply.
6562 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6563 (Fdelete_other_windows_internal, resize_frame_windows)
6564 (Fsplit_window_internal, Fdelete_window_internal)
6565 (grow_mini_window, shrink_mini_window)
6566 (Fresize_mini_window_internal): Fix callers accordingly.
6567
6568 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6569
6570 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6571 (emacs_fixed_set_min_size): Remove.
6572 (emacs_fixed_new): Take frame as argument.
6573
6574 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6575 (_EmacsFixedPrivate): Remove minwidth/height.
6576 Add struct frame *f.
6577 (emacs_fixed_init): Initialize priv->f.
6578 (get_parent_class, emacs_fixed_set_min_size): Remove.
6579 (emacs_fixed_new): Set priv->f to argument.
6580 (emacs_fixed_get_preferred_width)
6581 (emacs_fixed_get_preferred_height): Use min_width/height from
6582 frames size_hint to set minimum and natural (Bug#8919).
6583 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6584 and use min_width/height from frames size_hint to set
6585 min_width/height (Bug#8919).
6586
6587 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6588 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6589 Fix indentation.
6590
6591 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6592
6593 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6594 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6595 called at ZV.
6596
6597 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6598
6599 * process.c (wait_reading_process_output): Bypass select if
6600 waiting for a cell while ignoring keyboard input, and input is
6601 pending. Suggested by Jan Djärv (Bug#8869).
6602
6603 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6604
6605 Use gnulib's dup2 module instead of rolling our own.
6606 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6607
6608 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6609
6610 * dispnew.c (scrolling_window): Before scrolling, turn off a
6611 mouse-highlight in the window being scrolled.
6612
6613 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6614
6615 Move DEFSYM to lisp.h and use everywhere.
6616
6617 * character.h (DEFSYM): Move declaration...
6618 * lisp.h (DEFSYM): ...here.
6619
6620 * gnutls.c:
6621 * minibuf.c:
6622 * w32menu.c:
6623 * w32proc.c:
6624 * w32select.c: Don't include character.h.
6625
6626 * alloc.c (syms_of_alloc):
6627 * buffer.c (syms_of_buffer):
6628 * bytecode.c (syms_of_bytecode):
6629 * callint.c (syms_of_callint):
6630 * casefiddle.c (syms_of_casefiddle):
6631 * casetab.c (init_casetab_once):
6632 * category.c (init_category_once, syms_of_category):
6633 * ccl.c (syms_of_ccl):
6634 * cmds.c (syms_of_cmds):
6635 * composite.c (syms_of_composite):
6636 * dbusbind.c (syms_of_dbusbind):
6637 * dired.c (syms_of_dired):
6638 * dispnew.c (syms_of_display):
6639 * doc.c (syms_of_doc):
6640 * editfns.c (syms_of_editfns):
6641 * emacs.c (syms_of_emacs):
6642 * eval.c (syms_of_eval):
6643 * fileio.c (syms_of_fileio):
6644 * fns.c (syms_of_fns):
6645 * frame.c (syms_of_frame):
6646 * fringe.c (syms_of_fringe):
6647 * insdel.c (syms_of_insdel):
6648 * keymap.c (syms_of_keymap):
6649 * lread.c (init_obarray, syms_of_lread):
6650 * macros.c (syms_of_macros):
6651 * msdos.c (syms_of_msdos):
6652 * print.c (syms_of_print):
6653 * process.c (syms_of_process):
6654 * search.c (syms_of_search):
6655 * sound.c (syms_of_sound):
6656 * syntax.c (init_syntax_once, syms_of_syntax):
6657 * terminal.c (syms_of_terminal):
6658 * textprop.c (syms_of_textprop):
6659 * undo.c (syms_of_undo):
6660 * w32.c (globals_of_w32):
6661 * window.c (syms_of_window):
6662 * xdisp.c (syms_of_xdisp):
6663 * xfaces.c (syms_of_xfaces):
6664 * xfns.c (syms_of_xfns):
6665 * xmenu.c (syms_of_xmenu):
6666 * xsettings.c (syms_of_xsettings):
6667 * xterm.c (syms_of_xterm): Use DEFSYM.
6668
6669 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6670
6671 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6672
6673 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6674
6675 Integer and buffer overflow fixes (Bug#8873).
6676
6677 * print.c (printchar, strout): Check for string overflow.
6678 (PRINTPREPARE, printchar, strout):
6679 Don't set size unless allocation succeeds.
6680
6681 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6682 for sizes. Check for string overflow more accurately.
6683 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6684
6685 * macros.c: Integer and buffer overflow fixes.
6686 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6687 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6688 Use ptrdiff_t, not int, for sizes.
6689 Don't increment bufsize until after realloc succeeds.
6690 Check for size-calculation overflow.
6691 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6692
6693 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6694
6695 * lread.c: Integer overflow fixes.
6696 (read_integer): Radix is now EMACS_INT, not int,
6697 to improve quality of diagnostics for out-of-range radices.
6698 Calculate buffer size correctly for out-of-range radices.
6699 (read1): Check for integer overflow in radices, and in
6700 read-circle numbers.
6701 (read_escape): Avoid int overflow.
6702 (Fload, openp, read_buffer_size, read1)
6703 (substitute_object_recurse, read_vector, read_list, map_obarray):
6704 Use ptrdiff_t, not int, for sizes.
6705 (read1): Use EMACS_INT, not int, for sizes.
6706 Check for size overflow.
6707
6708 * image.c (cache_image): Check for size arithmetic overflow.
6709
6710 * lread.c: Integer overflow issues.
6711 (saved_doc_string_size, saved_doc_string_length)
6712 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6713 Now ptrdiff_t, not int.
6714 (read1): Don't assume doc string length fits in int. Check for
6715 out-of-range doc string lengths.
6716 (read_list): Don't assume file position fits in int.
6717 (read_escape): Check for hex character overflow.
6718
6719 2011-06-22 Leo Liu <sdl.web@gmail.com>
6720
6721 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6722 Move to minibuffer.el.
6723
6724 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6725
6726 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6727 The following patches are for when GLYPH_DEBUG && !XASSERT.
6728 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6729 * dispnew.c (flush_stdout):
6730 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6731 Mark as externally visible.
6732 * dispnew.c (check_window_matrix_pointers): Now static.
6733 * dispnew.c (window_to_frame_vpos):
6734 * xfns.c (unwind_create_frame):
6735 * xterm.c (x_check_font): Remove unused local.
6736 * scroll.c (CHECK_BOUNDS):
6737 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6738 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6739 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6740 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6741 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6742 Now static.
6743 (debug_method_add): Use va_list and vsprintf rather than relying
6744 on undefined behavior with wrong number of arguments.
6745 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6746 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6747 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6748 since we're not interested in debugging glyphs with old libraries.
6749 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6750 GCC 4.6.0's static checking.
6751
6752 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6753
6754 Integer overflow and signedness fixes (Bug#8873).
6755 A few related buffer overrun fixes, too.
6756
6757 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6758
6759 * dispextern.h (struct face.stipple):
6760 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6761 (x_bitmap_mask, x_allocate_bitmap_record)
6762 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6763 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6764 (x_create_bitmap_from_xpm_data):
6765 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6766 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6767 (.bitmaps_last):
6768 * xfaces.c (load_pixmap):
6769 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6770 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6771 (.bitmaps_last, struct x_output.icon_bitmap):
6772 Use ptrdiff_t, not int, for bitmap indexes.
6773 (x_allocate_bitmap_record): Check for size overflow.
6774 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6775
6776 Use ptrdiff_t, not int, for overlay counts.
6777 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6778 * editfns.c (overlays_around, get_pos_property):
6779 * textprop.c (get_char_property_and_overlay):
6780 * xdisp.c (next_overlay_change, note_mouse_highlight):
6781 * xfaces.c (face_at_buffer_position):
6782 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6783 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6784 (Fnext_overlay_change, Fprevious_overlay_change)
6785 (mouse_face_overlay_overlaps, Foverlays_in):
6786 Use ptrdiff_t, not int, for sizes.
6787 (overlays_at, overlays_in): Check for size-calculation overflow.
6788
6789 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6790
6791 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6792 (x_session_initialize): Do not assume string length fits in int.
6793
6794 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6795 This is unlikely, but can occur if DPI is outlandish.
6796
6797 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6798 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6799
6800 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6801 * xrdb.c (magic_file_p, search_magic_path):
6802 Omit last arg SUFFIX; it was always 0. All callers changed.
6803 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6804
6805 * xfont.c (xfont_match): Avoid need for strlen.
6806
6807 * xfns.c: Don't assume strlen fits in int.
6808 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6809
6810 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6811 not unsigned long, as we prefer signed integers. All callers changed.
6812 Detect integer overflow in repeat count.
6813 (message_dolog): Don't assume print length fits in 39 bytes.
6814 (display_mode_element): Don't assume strlen fits in int.
6815
6816 * termcap.c: Don't assume sizes fit in int and never overflow.
6817 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6818 (gobble_line): Check for size-calculation overflow.
6819
6820 * minibuf.c (Fread_buffer):
6821 * lread.c (intern, intern_c_string):
6822 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6823 Don't assume string length fits in int.
6824
6825 * keyboard.c (parse_tool_bar_item):
6826 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6827
6828 * font.c: Don't assume string length fits in int.
6829 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6830 Use ptrdiff_t, not int.
6831 (font_intern_prop): Don't assume string length fits in int.
6832 Don't assume integer property fits in fixnum.
6833 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6834
6835 * filelock.c: Fix some buffer overrun and integer overflow issues.
6836 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6837 Reformulate so as not to need the command string.
6838 Invoke gzip -cd rather than gunzip, as it's more portable.
6839 (lock_info_type, lock_file_1, lock_file):
6840 Don't assume pid_t and time_t fit in unsigned long.
6841 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6842 (current_lock_owner): Prefer signed type for sizes.
6843 Use memcpy, not strncpy, where memcpy is what is really wanted.
6844 Don't assume (via atoi) that time_t and pid_t fit in int.
6845 Check for time_t and/or pid_t out of range, e.g., via a network share.
6846 Don't alloca where an auto var works fine.
6847
6848 * fileio.c: Fix some integer overflow issues.
6849 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6850 Don't assume string length fits in int.
6851 (directory_file_name): Don't assume string length fits in long.
6852 (make_temp_name): Don't assume pid fits in int, or that its print
6853 length is less than 20.
6854
6855 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6856
6857 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6858
6859 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6860
6861 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6862 We prefer signed integers, even for size calculations.
6863
6864 * emacs.c: Don't assume string length fits in 'int'.
6865 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6866 (main): Don't invoke strlen when not needed.
6867
6868 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6869 (XD_DEBUG_MESSAGE): Don't waste a byte.
6870
6871 * callproc.c (getenv_internal_1, getenv_internal)
6872 (Fgetenv_internal):
6873 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6874
6875 * lread.c (invalid_syntax): Omit length argument.
6876 All uses changed. This doesn't fix a bug, but it simplifies the
6877 code away from its former Hollerith-constant appearance, and it's
6878 one less 'int' to worry about when looking at integer-overflow issues.
6879 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6880
6881 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6882 This didn't break anything, but it didn't help either.
6883 It's confusing to put a bogus integer in a place where the actual
6884 value does not matter.
6885 (LIST_END_P): Remove unused macro and its bogus comment.
6886 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6887
6888 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6889 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6890 implementation.
6891 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6892 We prefer signed types, and the value cannot exceed the EMACS_INT
6893 range anyway (because otherwise the length would not be representable).
6894 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6895 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6896 This avoids a GCC warning when WIDE_EMACS_INT.
6897
6898 * indent.c (sane_tab_width): New function.
6899 (current_column, scan_for_column, Findent_to, position_indentation)
6900 (compute_motion): Use it. This is just for clarity.
6901 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6902
6903 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6904
6905 * lisp.h (lint_assume): New macro.
6906 * composite.c (composition_gstring_put_cache):
6907 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6908
6909 * editfns.c, insdel.c:
6910 Omit unnecessary forward decls, to simplify future changes.
6911
6912 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6913
6914 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6915
6916 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6917 Use much-faster test for byte-length change.
6918 Don't assume string byte-length fits in 'int'.
6919 Check that character arg fits in 'int'.
6920 (mapcar1): Declare byte as byte, for clarity.
6921
6922 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6923
6924 * fns.c (concat): Catch string overflow earlier.
6925 Do not rely on integer wraparound.
6926
6927 * dispextern.h (struct it.overlay_strings_charpos)
6928 (struct it.selective): Now EMACS_INT, not int.
6929 * xdisp.c (forward_to_next_line_start)
6930 (back_to_previous_visible_line_start)
6931 (reseat_at_next_visible_line_start, next_element_from_buffer):
6932 Don't arbitrarily truncate the value of 'selective' to int.
6933
6934 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6935
6936 * composite.c: Don't truncate sizes to 'int'.
6937 (composition_gstring_p, composition_reseat_it)
6938 (composition_adjust_point): Use EMACS_INT, not int.
6939 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6940 not EMACS_UINT, for indexes.
6941
6942 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6943
6944 * buffer.c: Include <verify.h>.
6945 (struct sortvec.priority, struct sortstr.priority):
6946 Now EMACS_INT, not int.
6947 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6948 (struct sortstr.size, record_overlay_string)
6949 (struct sortstrlist.size, struct sortlist.used):
6950 Don't truncate size to int.
6951 (record_overlay_string): Check for size-calculation overflow.
6952 (init_buffer_once): Check at compile-time, not run-time.
6953
6954 2011-06-22 Jim Meyering <meyering@redhat.com>
6955
6956 Don't leak an XBM-image-sized buffer
6957 * image.c (xbm_load): Free the image buffer after using it.
6958
6959 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6960
6961 Port to Sun C.
6962 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6963 that Sun C diagnosed.
6964 * fns.c (secure_hash): Fix pointer signedness issue.
6965 * intervals.c (static_offset_intervals): New function.
6966 (offset_intervals): Use it.
6967
6968 2011-06-21 Leo Liu <sdl.web@gmail.com>
6969
6970 * deps.mk (fns.o):
6971 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6972 sha512.h.
6973
6974 * fns.c (secure_hash): Rename from crypto_hash_function and change
6975 the first arg to accept symbols.
6976 (Fsecure_hash): New primitive.
6977 (syms_of_fns): New symbols.
6978
6979 2011-06-20 Deniz Dogan <deniz@dogan.se>
6980
6981 * process.c (Fset_process_buffer): Clarify return value in
6982 docstring.
6983
6984 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6985
6986 * dispnew.c (add_window_display_history): Use BVAR.
6987
6988 * xdisp.c (debug_method_add): Use BVAR.
6989 (check_window_end, dump_glyph_matrix, dump_glyph)
6990 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6991
6992 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6993 Likewise.
6994
6995 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6996 check till after the cache is created in init_frame_faces.
6997
6998 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6999
7000 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7001
7002 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7003
7004 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7005 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7006 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7007
7008 Improve buffer-overflow checking (Bug#8873).
7009 * fileio.c (Finsert_file_contents):
7010 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7011 Remove the old (too-loose) buffer overflow checks.
7012 They weren't needed, since make_gap checks for buffer overflow.
7013 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7014 The old code merely checked for Emacs fixnum overflow, and relied
7015 on undefined (wraparound) behavior. The new code avoids undefined
7016 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7017
7018 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7019 Tune. Don't use wider integers than needed. Don't use alloca.
7020 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7021
7022 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7023
7024 * insdel.c, lisp.h (buffer_overflow): New function.
7025 (insert_from_buffer_1, replace_range, replace_range_2):
7026 * insdel.c (make_gap_larger):
7027 * editfns.c (Finsert_char):
7028 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7029
7030 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7031
7032 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7033
7034 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7035
7036 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7037 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7038
7039 * fileio.c: Don't assume EMACS_INT fits in off_t.
7040 (emacs_lseek): New static function.
7041 (Finsert_file_contents, Fwrite_region): Use it.
7042 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7043
7044 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7045
7046 * fns.c: Don't overflow int when computing a list length.
7047 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7048 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7049 truncation on 64-bit hosts. Check for QUIT every
7050 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7051 faster and is responsive enough.
7052 (Flength): Report an error instead of overflowing an integer.
7053 (Fsafe_length): Return a float if the value is not representable
7054 as a fixnum. This shouldn't happen except in contrived situations.
7055 (Fnthcdr, Fsort): Don't assume list length fits in int.
7056 (Fcopy_sequence): Don't assume vector length fits in int.
7057
7058 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7059 (header_size, word_size): New constants.
7060 (allocate_vectorlike): Don't check size overflow here.
7061 (allocate_vector): Check it here instead, since this is the only
7062 caller of allocate_vectorlike that could cause overflow.
7063 Check that the new vector's length is representable as a fixnum.
7064
7065 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7066 The previous code was bogus. For example, next_almost_prime (32)
7067 returned 39, which is undesirable as it is a multiple of 3; and
7068 next_almost_prime (24) returned 25, which is a multiple of 5 so
7069 why was the code bothering to check for multiples of 7?
7070
7071 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7072
7073 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7074
7075 Variadic C functions now count arguments with ptrdiff_t.
7076 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7077 Back then I didn't know that the Emacs coding style prefers signed int.
7078 Also, in the meantime I found a few more instances where arguments
7079 were being counted with int, which may truncate counts on 64-bit
7080 machines, or EMACS_INT, which may be unnecessarily wide.
7081 * lisp.h (struct Lisp_Subr.function.aMANY)
7082 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7083 Arg counts are now ptrdiff_t, not size_t.
7084 All variadic functions and their callers changed accordingly.
7085 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7086 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7087 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7088 * callint.c (Fcall_interactively): Check arg count for overflow,
7089 to avoid potential buffer overrun. Use signed char, not 'int',
7090 for 'varies' array, so that we needn't bother to check its size
7091 calculation for overflow.
7092 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7093 * eval.c (apply_lambda):
7094 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7095 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7096 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7097
7098 * callint.c (Fcall_interactively): Don't use index var as event count.
7099
7100 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7101 * mem-limits.h (SIZE): Remove; no longer used.
7102
7103 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7104
7105 Remove unnecessary casts.
7106 * xterm.c (x_term_init):
7107 * xfns.c (x_set_border_pixel):
7108 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7109 These aren't needed now that we assume ANSI C.
7110
7111 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7112 It's more likely to cause problems (due to unsigned overflow)
7113 than to cure them.
7114
7115 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7116
7117 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7118
7119 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7120
7121 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7122
7123 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7124
7125 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7126
7127 GLYPH_CODE_FACE returns EMACS_INT, not int.
7128 * dispextern.h (merge_faces):
7129 * xfaces.c (merge_faces):
7130 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7131 Don't assume EMACS_INT fits in int.
7132
7133 * character.h (CHAR_VALID_P): Remove unused parameter.
7134 * fontset.c, lisp.h, xdisp.c: All uses changed.
7135
7136 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7137
7138 * fns.c (concat): Minor tuning based on overflow analysis.
7139 This doesn't fix any bugs. Use int to hold character, instead
7140 of constantly refetching from Emacs object. Use XFASTINT, not
7141 XINT, for value known to be a character. Don't bother comparing
7142 a single byte to 0400, as it's always less.
7143
7144 * floatfns.c (Fexpt):
7145 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7146
7147 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7148 for characters.
7149
7150 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7151
7152 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7153 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7154 incorrectly succeed when S was a string, because 4294967386 was
7155 truncated before it was used.
7156
7157 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7158 Otherwise, an out-of-range integer could cause undefined behavior
7159 on a 64-bit host.
7160
7161 * composite.c: Use int, not EMACS_INT, for characters.
7162 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7163 EMACS_INT, for values that are known to be in character range.
7164 This doesn't fix any bugs but is the usual style inside Emacs and
7165 may generate better code on 32-bit machines.
7166
7167 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7168 This is for reasons similar to the recent CHAR_STRING fix.
7169 * charset.c (Fencode_char): Check that character arg is actually
7170 a character. Pass an int to ENCODE_CHAR.
7171 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7172 wider than 'int', as a compile-time check to prevent future regressions
7173 in this area.
7174
7175 * character.c (char_string): Remove unnecessary casts.
7176
7177 Make sure a 64-bit char is never passed to CHAR_STRING.
7178 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7179 by silently ignoring the top 32 bits, allowing some values
7180 that were far too large to be valid characters.
7181 * character.h: Include <verify.h>.
7182 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7183 arguments are no wider than unsigned, as a compile-time check
7184 to prevent future regressions in this area.
7185 * data.c (Faset):
7186 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7187 (Fsubst_char_in_region):
7188 * fns.c (concat):
7189 * xdisp.c (decode_mode_spec_coding):
7190 Adjust to CHAR_STRING's new requirement.
7191 * editfns.c (Finsert_char, Fsubst_char_in_region):
7192 * fns.c (concat): Check that character args are actually
7193 characters. Without this test, these functions did the wrong
7194 thing with wildly out-of-range values on 64-bit hosts.
7195
7196 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7197 These casts should not be needed on 32-bit hosts, either.
7198 * keyboard.c (read_char):
7199 * lread.c (Fload): Remove casts to unsigned.
7200
7201 * lisp.h (UNSIGNED_CMP): New macro.
7202 This fixes comparison bugs on 64-bit hosts.
7203 (ASCII_CHAR_P): Use it.
7204 * casefiddle.c (casify_object):
7205 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7206 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7207 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7208 * dispextern.h (FACE_FROM_ID):
7209 * keyboard.c (read_char): Use UNSIGNED_CMP.
7210
7211 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7212 not to EMACS_INT, to avoid GCC warning.
7213
7214 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7215
7216 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7217 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7218 isn't needed on 32-bit machines.
7219
7220 * buffer.c (Fgenerate_new_buffer_name):
7221 Use EMACS_INT for count, not int.
7222 (advance_to_char_boundary): Return EMACS_INT, not int.
7223
7224 * data.c (Qcompiled_function): Now static.
7225
7226 * window.c (window_body_lines): Now static.
7227
7228 * image.c (gif_load): Rename local to avoid shadowing.
7229
7230 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7231 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7232 * alloc.c (make_save_value): Integer argument is now of type
7233 ptrdiff_t, not int.
7234 (mark_object): Use ptrdiff_t, not int.
7235 * lisp.h (pD): New macro.
7236 * print.c (print_object): Use it.
7237
7238 * alloc.c: Use EMACS_INT, not int, to count objects.
7239 (total_conses, total_markers, total_symbols, total_vector_size)
7240 (total_free_conses, total_free_markers, total_free_symbols)
7241 (total_free_floats, total_floats, total_free_intervals)
7242 (total_intervals, total_strings, total_free_strings):
7243 Now EMACS_INT, not int. All uses changed.
7244 (Fgarbage_collect): Compute overall total using a double, so that
7245 integer overflow is less likely to be a problem. Check for overflow
7246 when converting back to an integer.
7247 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7248 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7249 These were 'int' variables that could overflow on 64-bit hosts;
7250 they were never used, so remove them instead of repairing them.
7251 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7252 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7253 Previously, this ceilinged at INT_MAX, but that doesn't work on
7254 64-bit machines.
7255 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7256
7257 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7258 (allocate_vectorlike): Check for ptrdiff_t overflow.
7259 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7260 when a (possibly-narrower) signed value would do just as well.
7261 We prefer using signed arithmetic, to avoid comparison confusion.
7262
7263 * alloc.c: Catch some string size overflows that we were missing.
7264 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7265 for convenience in STRING_BYTES_MAX.
7266 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7267 The definition here is exact; the one in lisp.h was approximate.
7268 (allocate_string_data): Check for string overflow. This catches
7269 some instances we weren't catching before. Also, it catches
7270 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7271 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7272 and ptrdiff_t and EMACS_INT are both 64 bits.
7273
7274 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7275 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7276 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7277
7278 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7279
7280 * alloc.c (Fmake_string): Check for out-of-range init.
7281
7282 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7283
7284 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7285
7286 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7287
7288 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7289 xg_get_default_scrollbar_width.
7290
7291 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7292 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7293 (style_changed_cb): Call update_theme_scrollbar_width and call
7294 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7295 all frames (Bug#8505).
7296 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7297 Call gtk_window_set_resizable if HAVE_GTK3.
7298 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7299 and height if HAVE_GTK3 (Bug#8505).
7300 (scroll_bar_width_for_theme): New variable.
7301 (update_theme_scrollbar_width): New function.
7302 (xg_get_default_scrollbar_width): Move code to
7303 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7304 (xg_initialize): Call update_theme_scrollbar_width.
7305
7306 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7307
7308 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7309
7310 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7311
7312 * frame.c (make_frame): Call other_buffer_safely instead of
7313 other_buffer.
7314
7315 * window.c (temp_output_buffer_show): Call display_buffer with
7316 second argument Vtemp_buffer_show_specifiers and reset latter
7317 immediately after the call.
7318 (Vtemp_buffer_show_specifiers): New variable.
7319 (auto_window_vscroll_p, next_screen_context_lines)
7320 (Vscroll_preserve_screen_position): Remove leading asterisks from
7321 doc-strings.
7322
7323 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7324
7325 Fix minor problems found by GCC 4.6.0 static checking.
7326 * buffer.c (Qclone_number): Remove for now, as it's unused.
7327 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7328 (record_buffer): Remove unused local.
7329 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7330 (set_frame_buffer_list): Remove; unused.
7331 * frame.h (other_visible_frames): Remove decl.
7332 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7333 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7334 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7335 if HAVE_GPM.
7336 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7337 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7338 Define only if HAVE_GPM.
7339 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7340 (update_hints_inhibit): Remove; never set. All uses removed.
7341 * widgetprv.h (emacsFrameClassRec): Remove decl.
7342 * window.c (delete_deletable_window): Now returns void, since it
7343 wasn't returning anything.
7344 (compare_window_configurations): Remove unused locals.
7345 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7346 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7347 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7348 the same widths as pointers. This follows up on the 2011-05-06 patch.
7349 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7350 * xterm.h: Likewise.
7351 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7352
7353 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7354
7355 * makefile.w32-in: Update dependencies.
7356 (LISP_H): Add lib/intprops.h.
7357
7358 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7359
7360 * image.c (gif_load): Add animation frame delay to the metadata.
7361 (syms_of_image): Use DEFSYM. New symbol `delay'.
7362
7363 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7364
7365 * window.c (delete_deletable_window): Re-add.
7366 (Fset_window_configuration): Rewrite to handle dead buffers and
7367 consequently deletable windows.
7368 (window_tree, Fwindow_tree): Remove. Supply functionality in
7369 window.el.
7370 (compare_window_configurations): Simplify code.
7371
7372 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7373
7374 * image.c (imagemagick_load_image): Fix type mismatch.
7375 (Fimagemagick_types): Likewise.
7376
7377 * window.h (replace_buffer_in_windows): Declare.
7378
7379 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7380
7381 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7382 Qclone_number. Remove external declaration of Qdelete_window.
7383 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7384 code.
7385 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7386 Run Qbuffer_list_update_hook if allowed.
7387 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7388 buffer list implementation.
7389 (other_buffer_safely): New function.
7390 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7391 calls to replace_buffer_in_windows and
7392 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7393 if allowed.
7394 (record_buffer): Inhibit quitting and rewrite using quittable
7395 functions. Run Qbuffer_list_update_hook if allowed.
7396 (Frecord_buffer, Funrecord_buffer): New functions.
7397 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7398 Move switch-to-buffer to window.el.
7399 (bury-buffer): Move to window.el.
7400 (Vbuffer_list_update_hook): New variable.
7401
7402 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7403 section.
7404
7405 * window.h (resize_frame_windows): Move up in code.
7406 (Fwindow_frame): Remove EXFUN.
7407 (replace_buffer_in_all_windows): Remove prototype.
7408 (replace_buffer_in_windows_safely): Add prototype.
7409
7410 * window.c: Declare Qdelete_window static again. Move down
7411 declaration of select_count.
7412 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7413 (Fother_window): Move to window.el.
7414 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7415 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7416 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7417 window.el.
7418 (replace_buffer_in_windows): Implement by calling
7419 Qreplace_buffer_in_windows.
7420 (replace_buffer_in_all_windows): Remove with some functionality
7421 moved into replace_buffer_in_windows_safely.
7422 (replace_buffer_in_windows_safely): New function.
7423 (select_window_norecord, select_frame_norecord): Move in front
7424 of run_window_configuration_change_hook. Remove now obsolete
7425 declarations.
7426 (Fset_window_buffer): Rewrite doc-string.
7427 Call Qrecord_window_buffer.
7428 (keys_of_window): Move binding for other-window to window.el.
7429
7430 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7431
7432 * dispextern.h (struct image): Replace data member, whose int_val
7433 and ptr_val fields were not used by anything, with a single
7434 lisp_val object.
7435
7436 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7437 (gif_clear_image, gif_load, imagemagick_load_image)
7438 (gs_clear_image, gs_load): Callers changed.
7439
7440 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7441
7442 * buffer.h: Include <time.h>, for time_t.
7443 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7444
7445 Fix minor problems found by static checking.
7446
7447 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7448
7449 Make identifiers static if they are not used in other modules.
7450 * data.c (Qcompiled_function, Qframe, Qvector):
7451 * image.c (QimageMagick, Qsvg):
7452 * minibuf.c (Qmetadata):
7453 * window.c (resize_window_check, resize_root_window): Now static.
7454 * window.h (resize_window_check, resize_root_window): Remove decls.
7455
7456 * window.c (window_deletion_count, delete_deletable_window):
7457 Remove; unused.
7458 (window_body_lines): Now static.
7459 (Fdelete_other_windows_internal): Mark vars as initialized.
7460 Make sure 'resize_failed' is initialized.
7461 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7462 (resize_window_apply): Remove unused local.
7463 * window.h (delete_deletable_window): Remove decl.
7464
7465 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7466 (imagemagick_load_image): Fix pointer signedness problem by changing
7467 last arg from unsigned char * to char *. All uses changed.
7468 Also, fix a local for similar reasons.
7469 Remove unused locals. Remove locals to avoid shadowing.
7470 (fn_rsvg_handle_free): Remove; unused.
7471 (svg_load, svg_load_image): Fix pointer signedness problem.
7472 (imagemagick_load_image): Don't use garbage pointer image_wand.
7473
7474 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7475
7476 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7477
7478 * image.c (gif_load): Fix omitted cast error introduced by
7479 2011-06-06 change.
7480
7481 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7482
7483 * window.h (resize_proportionally, orig_total_lines)
7484 (orig_top_line): Remove from window structure.
7485 (set_window_height, set_window_width, change_window_heights)
7486 (Fdelete_window): Remove prototypes.
7487 (resize_frame_windows): Remove duplicate declaration.
7488
7489 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7490
7491 * window.h (resize_frame_windows, resize_window_check)
7492 (delete_deletable_window, resize_root_window)
7493 (resize_frame_windows): Declare prototypes.
7494
7495 * window.c (resize_window_apply): Make definition be "static" to
7496 match the prototype.
7497
7498 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7499
7500 * window.c: Remove declarations of Qwindow_size_fixed,
7501 window_min_size_1, window_min_size_2, window_min_size,
7502 size_window, window_fixed_size_p, enlarge_window, delete_window.
7503 Remove static from declaration of Qdelete_window, it's
7504 temporarily needed by Fbury_buffer.
7505 (replace_window): Don't assign orig_top_line and
7506 orig_total_lines.
7507 (Fdelete_window, delete_window): Remove. Window deletion is
7508 handled by window.el.
7509 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7510 Replace Fdelete_window calls with calls to Qdelete_window.
7511 (Fdelete_other_windows): Remove. Deleting other windows is
7512 handled by window.el.
7513 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7514 handled in window.el.
7515 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7516 Window minimum sizes are handled in window.el.
7517 (shrink_windows, size_window, set_window_height)
7518 (set_window_width, change_window_heights, window_height)
7519 (window_width, CURBEG, CURSIZE, enlarge_window)
7520 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7521 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7522 handled in window.el.
7523 (make_dummy_parent): Rename to make_parent_window and give it a
7524 second argument horflag.
7525 (make_window): Don't set resize_proportionally any more.
7526 (Fsplit_window): Remove. Windows are split in window.el.
7527 (save_restore_action, save_restore_orig_size)
7528 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7529 Resize mini windows in window.el.
7530 (grow_mini_window, shrink_mini_window): Implement by calling
7531 Qresize_root_window_vertically, resize_window_check and
7532 resize_window_apply.
7533 (saved_window, Fset_window_configuration, save_window_save):
7534 Do not handle orig_top_line, orig_total_lines, and
7535 resize_proportionally.
7536 (window_min_height, window_min_width): Move to window.el.
7537 (keys_of_window): Move bindings for delete-other-windows,
7538 split-window, delete-window and enlarge-window to window.el.
7539
7540 * buffer.c: Temporarily extern Qdelete_window.
7541 (Fbury_buffer): Temporarily call Qdelete_window instead of
7542 Fdelete_window (Fbury_buffer will move to window.el soon).
7543
7544 * frame.c (set_menu_bar_lines_1): Remove code handling
7545 orig_top_line and orig_total_lines.
7546
7547 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7548 set_window_height but set heights directly.
7549 (change_frame_size_1): Use resize_frame_windows.
7550
7551 * xdisp.c (init_xdisp): Don't use set_window_height but set
7552 heights directly.
7553
7554 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7555 Use resize_frame_windows instead of change_window_heights and run
7556 run_window_configuration_change_hook.
7557
7558 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7559 instead of change_window_heights and run
7560 run_window_configuration_change_hook.
7561
7562 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7563
7564 * window.c (replace_window): Rename second argument REPLACEMENT to
7565 NEW. New third argument SETFLAG. Rewrite.
7566 (delete_window, make_dummy_parent): Call replace_window with
7567 third argument 1.
7568 (window_list_1): Move down in code.
7569 (run_window_configuration_change_hook): Move set_buffer part
7570 before select_frame_norecord part in order to unwind correctly.
7571 Rename count1 to count.
7572 (recombine_windows, delete_deletable_window, resize_root_window)
7573 (Fdelete_other_windows_internal)
7574 (Frun_window_configuration_change_hook, make_parent_window)
7575 (resize_window_check, resize_window_apply, Fresize_window_apply)
7576 (resize_frame_windows, Fsplit_window_internal)
7577 (Fdelete_window_internal, Fresize_mini_window_internal):
7578 New functions.
7579 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7580
7581 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7582
7583 * window.h (window): Add some new members to window structure -
7584 normal_lines, normal_cols, new_total, new_normal, clone_number,
7585 splits, nest, prev_buffers, next_buffers.
7586 (WINDOW_TOTAL_SIZE): Move here from window.c.
7587 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7588
7589 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7590 Remove.
7591 (make_dummy_parent): Set new members of windows structure.
7592 (make_window): Move down in code. Handle new members of window
7593 structure.
7594 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7595 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7596 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7597 (Fset_window_prev_buffers, Fwindow_next_buffers)
7598 (Fset_window_next_buffers, Fset_window_clone_number):
7599 New functions.
7600 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7601 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7602 Doc-string fixes.
7603 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7604 Argument WINDOW can be now internal window too.
7605 (Fwindow_use_time): Move up in code.
7606 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7607 Rewrite doc-string.
7608 (Fset_window_configuration, saved_window)
7609 (Fcurrent_window_configuration, save_window_save): Handle new
7610 members of window structure.
7611 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7612 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7613 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7614 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7615 Qget_mru_window, Qresize_root_window,
7616 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7617 Qauto_buffer_name; staticpro them.
7618
7619 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7620
7621 * window.c (Fwindow_total_size, Fwindow_left_column)
7622 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7623 (Fwindow_list_1): New functions.
7624 (window_box_text_cols): Replace with window_body_cols.
7625 (Fwindow_width, Fscroll_left, Fscroll_right):
7626 Use window_body_cols instead of window_box_text_cols.
7627 (delete_window, Fset_window_configuration):
7628 Call delete_all_subwindows with window as argument.
7629 (delete_all_subwindows): Take a window as argument and not a
7630 structure. Rewrite.
7631 (window_loop): Remove handling of GET_LRU_WINDOW and
7632 GET_LARGEST_WINDOW.
7633 (Fget_lru_window, Fget_largest_window): Move to window.el.
7634
7635 * window.h: Extern window_body_cols instead of
7636 window_box_text_cols. delete_all_subwindows now takes a
7637 Lisp_Object as argument.
7638
7639 * indent.c (compute_motion, Fcompute_motion):
7640 Use window_body_cols instead of window_box_text_cols.
7641
7642 * frame.c (delete_frame): Call delete_all_subwindows with root
7643 window as argument.
7644
7645 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7646
7647 * fns.c (Fputhash): Document return value.
7648
7649 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7650
7651 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7652
7653 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7654
7655 Cons<->int and similar integer overflow fixes (Bug#8794).
7656
7657 Check for overflow when converting integer to cons and back.
7658 * charset.c (Fdefine_charset_internal, Fdecode_char):
7659 Use cons_to_unsigned to catch overflow.
7660 (Fencode_char): Use INTEGER_TO_CONS.
7661 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7662 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7663 * data.c (long_to_cons, cons_to_long): Remove.
7664 (cons_to_unsigned, cons_to_signed): New functions.
7665 These signal an error for invalid or out-of-range values.
7666 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7667 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7668 * font.c (Ffont_variation_glyphs):
7669 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7670 * lisp.h: Include <intprops.h>.
7671 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7672 (cons_to_signed, cons_to_unsigned): New decls.
7673 (long_to_cons, cons_to_long): Remove decls.
7674 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7675 (Fprimitive_undo): Use CONS_TO_INTEGER.
7676 * xfns.c (Fx_window_property): Likewise.
7677 * xselect.c: Include <limits.h>.
7678 (x_own_selection, selection_data_to_lisp_data):
7679 Use INTEGER_TO_CONS.
7680 (x_handle_selection_request, x_handle_selection_clear)
7681 (x_get_foreign_selection, Fx_disown_selection_internal)
7682 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7683 (lisp_data_to_selection_data): Use cons_to_unsigned.
7684 (x_fill_property_data): Use cons_to_signed.
7685 Report values out of range.
7686
7687 Check for buffer and string overflow more precisely.
7688 * buffer.h (BUF_BYTES_MAX): New macro.
7689 * lisp.h (STRING_BYTES_MAX): New macro.
7690 * alloc.c (Fmake_string):
7691 * character.c (string_escape_byte8):
7692 * coding.c (coding_alloc_by_realloc):
7693 * doprnt.c (doprnt):
7694 * editfns.c (Fformat):
7695 * eval.c (verror):
7696 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7697 since they may not be the same number.
7698 * editfns.c (Finsert_char):
7699 * fileio.c (Finsert_file_contents):
7700 Likewise for BUF_BYTES_MAX.
7701
7702 * image.c: Use ptrdiff_t, not int, for sizes.
7703 (slurp_file): Switch from int to ptrdiff_t.
7704 All uses changed.
7705 (slurp_file): Check that file size fits in both size_t (for
7706 malloc) and ptrdiff_t (for sanity and safety).
7707
7708 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7709 if b->modtime has its maximal value.
7710
7711 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7712
7713 Don't assume time_t can fit into int.
7714 * buffer.h (struct buffer.modtime): Now time_t, not int.
7715 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7716 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7717
7718 Minor fixes for signed vs unsigned integers.
7719 * character.h (MAYBE_UNIFY_CHAR):
7720 * charset.c (maybe_unify_char):
7721 * keyboard.c (read_char, reorder_modifiers):
7722 XINT -> XFASTINT, since the integer must be nonnegative.
7723 * ftfont.c (ftfont_spec_pattern):
7724 * keymap.c (access_keymap, silly_event_symbol_error):
7725 XUINT -> XFASTINT, since the integer must be nonnegative.
7726 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7727 since it makes no difference and we prefer signed.
7728 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7729 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7730 nonnegative.
7731
7732 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7733
7734 * window.h (Fwindow_frame): Declare.
7735
7736 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7737
7738 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7739 (SPARE_MEMORY): Always define.
7740 (LARGE_REQUEST): Remove.
7741 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7742
7743 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7744
7745 * lisp.h: Move EXFUNS for Fframe_root_window,
7746 Fframe_first_window and Fset_frame_selected_window to window.h.
7747
7748 * window.h: Move EXFUNS for Fframe_root_window,
7749 Fframe_first_window and Fset_frame_selected_window here from
7750 lisp.h.
7751
7752 * frame.c (Fwindow_frame, Fframe_first_window)
7753 (Fframe_root_window, Fframe_selected_window)
7754 (Fset_frame_selected_window): Move to window.c.
7755 (Factive_minibuffer_window): Move to minibuf.c.
7756 (Fother_visible_frames_p): New function.
7757
7758 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7759
7760 * window.c (decode_window, decode_any_window): Move up in code.
7761 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7762 (inhibit_frame_unsplittable): Remove unused variable.
7763 (Fwindow_buffer): Move up and rewrite doc-string.
7764 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7765 (Fwindow_prev): New functions.
7766 (Fwindow_frame): Move here from frame.c. Accept any window as
7767 argument.
7768 (Fframe_root_window, Fframe_first_window)
7769 (Fframe_selected_window): Move here from frame.c. Accept frame
7770 or arbitrary window as argument. Update doc-strings.
7771 (Fminibuffer_window): Move up in code.
7772 (Fwindow_minibuffer_p): Move up in code and simplify.
7773 (Fset_frame_selected_window): Move here from frame.c.
7774 Marginal rewrite.
7775 (Fselected_window, select_window, Fselect_window): Move up in
7776 code. Minor doc-string fixes.
7777
7778 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7779
7780 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7781 Do not assume that spare memory exists; that assumption is valid
7782 only if SYSTEM_MALLOC.
7783 (LARGE_REQUEST): New macro, so that the issue of large requests
7784 is separated from the issue of spare memory.
7785
7786 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7787
7788 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7789 format. (Bug#8806)
7790
7791 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7792
7793 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7794 before statements.
7795
7796 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7797
7798 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7799
7800 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7801
7802 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7803 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7804
7805 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7806
7807 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7808
7809 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7810
7811 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7812 (x_clipboard_manager_save): Add return value.
7813 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7814 New error handlers.
7815 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7816 Obey Vx_select_enable_clipboard_manager. Catch errors in
7817 x_clipboard_manager_save (Bug#8779).
7818 (Vx_select_enable_clipboard_manager): New variable.
7819 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7820
7821 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7822
7823 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7824
7825 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7826
7827 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7828 in the current matrix if keep_current_p is non-zero.
7829
7830 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7831
7832 * bidi.c (bidi_level_of_next_char): Fix last change.
7833
7834 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7835
7836 Support bidi reordering of text covered by display properties.
7837
7838 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7839 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7840 (bidi_cache_search, bidi_cache_iterator_state)
7841 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7842 (bidi_level_of_next_char, bidi_move_to_visually_next):
7843 Support character positions inside a run of characters covered by a
7844 display string.
7845 (bidi_paragraph_init, bidi_resolve_explicit_1)
7846 (bidi_level_of_next_char): Call bidi_fetch_char and
7847 bidi_fetch_char_advance instead of FETCH_CHAR and
7848 FETCH_CHAR_ADVANCE.
7849 (bidi_init_it): Initialize new members.
7850 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7851 definitions.
7852 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7853 instead of using explicit *_CHAR codes.
7854 (bidi_resolve_explicit, bidi_resolve_weak):
7855 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7856 bidirectional text is supported only in multibyte buffers.
7857 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7858 it to initialize the frame_window_p member of struct bidi_it.
7859 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7860 (bidi_resolve_explicit, bidi_resolve_weak)
7861 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7862 bidi_it->nchars is non-positive.
7863 (bidi_level_of_next_char): Don't try to lookup the cache for the
7864 next/previous character if nothing is cached there yet, or if we
7865 were just reseat()'ed to a new position.
7866
7867 * xdisp.c (set_cursor_from_row): Set start and stop points
7868 according to the row's direction when priming the loop that looks
7869 for the glyph on which to display cursor.
7870 (single_display_spec_intangible_p): Function deleted.
7871 (display_prop_intangible_p): Reimplement to call
7872 handle_display_spec instead of single_display_spec_intangible_p.
7873 Accept 3 additional arguments needed by handle_display_spec.
7874 This fixes incorrect cursor motion across display property with complex
7875 values: lists, `(when COND...)' forms, etc.
7876 (single_display_spec_string_p): Support property values that are
7877 lists with the argument STRING its top-level element.
7878 (display_prop_string_p): Fix the condition for processing a
7879 property that is a list to be consistent with handle_display_spec.
7880 (handle_display_spec): New function, refactored from the
7881 last portion of handle_display_prop.
7882 (compute_display_string_pos): Accept additional argument
7883 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7884 value of a `display' property is a "replacing spec".
7885 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7886 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7887 the display property, but just return a value indicating whether
7888 the display property will replace the characters it covers.
7889 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7890 frame_window_p members of struct bidi_it.
7891 (compute_display_string_pos, compute_display_string_end):
7892 New functions.
7893 (push_it): Accept second argument POSITION, where pop_it should
7894 jump to continue iteration.
7895 (reseat_1): Initialize bidi_it.disp_pos.
7896
7897 * keyboard.c (adjust_point_for_property): Adjust the call to
7898 display_prop_intangible_p to its new signature.
7899
7900 * dispextern.h (struct bidi_it): New member frame_window_p.
7901 (bidi_init_it): Update prototypes.
7902 (display_prop_intangible_p): Update prototype.
7903 (compute_display_string_pos, compute_display_string_end):
7904 Declare prototypes.
7905 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7906 EMACS_INT.
7907
7908 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7909
7910 Malloc failure behavior now depends on size of allocation.
7911 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7912 * lisp.h: Change signatures accordingly.
7913 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7914 All callers changed. (Bug#8762)
7915
7916 * gnutls.c: Use Emacs's memory allocators.
7917 Without this change, the gnutls library would invoke malloc etc.
7918 directly, which causes problems on non-SYNC_INPUT hosts, and which
7919 runs afoul of improving memory_full behavior. (Bug#8761)
7920 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7921 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7922 xfree instead of the default malloc, realloc, free.
7923 (Fgnutls_boot): No need to check for memory allocation failure,
7924 since xmalloc does that for us.
7925
7926 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7927 * category.c (hash_get_category_set):
7928 * ccl.c (ccl_driver):
7929 * charset.c (Fdefine_charset_internal):
7930 * charset.h (struct charset.hash_index):
7931 * composite.c (get_composition_id, gstring_lookup_cache)
7932 (composition_gstring_put_cache):
7933 * composite.h (struct composition.hash_index):
7934 * dispextern.h (struct image.hash):
7935 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7936 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7937 (hashfn_equal, hashfn_user_defined, make_hash_table)
7938 (maybe_resize_hash_table, hash_lookup, hash_put)
7939 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7940 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7941 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7942 * image.c (make_image, search_image_cache, lookup_image)
7943 (xpm_put_color_table_h):
7944 * lisp.h (struct Lisp_Hash_Table):
7945 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7946 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7947 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7948 * alloc.c (allocate_vectorlike):
7949 Check for overflow in vector size calculations.
7950 * ccl.c (ccl_driver):
7951 Check for overflow when converting EMACS_INT to int.
7952 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7953 need to be updated by these changes.
7954 * fns.c (make_hash_table, maybe_resize_hash_table):
7955 Check for integer overflow with large hash tables.
7956 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7957 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7958 (SXHASH_REDUCE): New macro.
7959 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7960 Use it instead of discarding useful hash info with large hash values.
7961 (sxhash_float): New function.
7962 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7963 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7964 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7965 Rewrite to use FIXNUM_BITS, as this simplifies things.
7966 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7967 Adjust signatures to match updated version of code.
7968 (consing_since_gc): Now EMACS_INT, since a single hash table can
7969 use more than INT_MAX bytes.
7970
7971 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7972
7973 Make it possible to build with GCC-4.6+ -O2 -flto.
7974
7975 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7976
7977 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7978
7979 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7980 Call minibuffer-inactive-mode.
7981
7982 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7983
7984 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7985 Update dependencies.
7986
7987 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7988
7989 * data.c (init_data): Remove code for UTS, this system is not
7990 supported anymore.
7991
7992 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7993
7994 Don't force ./temacs to start in terminal mode.
7995
7996 * frame.c (make_initial_frame): Initialize faces in all cases, not
7997 only when CANNOT_DUMP is defined.
7998 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7999
8000 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8001
8002 * dispnew.c (add_window_display_history): Use const for the string
8003 pointer. Remove declaration, not needed.
8004
8005 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8006
8007 Use 'inline', not 'INLINE'.
8008 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8009 * alloc.c, fontset.c (INLINE): Remove.
8010 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8011 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8012 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8013 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8014 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8015
8016 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8017
8018 Make it possible to run ./temacs.
8019
8020 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8021 syms_of_callproc does the same thing. Remove test for
8022 "initialized", do it in the caller.
8023 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8024
8025 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8026
8027 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8028 (read_minibuf): Use get_minibuffer.
8029 (syms_of_minibuf): Use DEFSYM.
8030 (Qmetadata): New var.
8031 * data.c (Qbuffer): Don't make it static.
8032 (syms_of_data): Use DEFSYM.
8033
8034 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8035
8036 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8037 (CCL_CODE_MIN): New macro.
8038
8039 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8040
8041 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8042
8043 * eval.c (Qdebug): Now static.
8044 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8045 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8046 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8047
8048 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8049
8050 * image.c: Various fixes to ImageMagick code comments.
8051 (Fimagemagick_types): Doc fix.
8052
8053 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8054
8055 Minor fixes prompted by GCC 4.6.0 warnings.
8056
8057 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8058
8059 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8060 (x_clipboard_manager_save_all): Move extern decl to ...
8061 * xterm.h: ... here, so that it can be checked for consistency.
8062
8063 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8064
8065 * xselect.c (x_clipboard_manager_save_frame)
8066 (x_clipboard_manager_save_all): New functions.
8067 (Fx_clipboard_manager_save): Lisp function deleted.
8068
8069 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8070 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8071
8072 * xterm.h: Update prototype.
8073
8074 2011-05-28 William Xu <william.xwl@gmail.com>
8075
8076 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8077 exiting (Bug#8239).
8078
8079 2011-05-28 Jim Meyering <meyering@redhat.com>
8080
8081 Avoid a sign-extension bug in crypto_hash_function.
8082 * fns.c (to_uchar): Define.
8083 (crypto_hash_function): Use it to convert some newly-signed
8084 variables to unsigned, to avoid sign-extension bugs. For example,
8085 without this change, (md5 "truc") would evaluate to
8086 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8087 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8088 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8089
8090 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8091
8092 Integer overflow fixes.
8093
8094 * dbusbind.c: Serial number integer overflow fixes.
8095 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8096 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8097 to hold a serial number that is too large for a fixnum.
8098 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8099 Check for serial numbers out of range. Decode any serial number
8100 that was so large that it became a float. (Bug#8722)
8101
8102 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8103 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8104 Use XFASTINT rather than XUINT when numbers are nonnegative.
8105 (xd_append_arg, Fdbus_method_return_internal):
8106 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8107 arguments, check that Lisp number is nonnegative, rather than
8108 silently wrapping negative numbers around. (Bug#8722)
8109 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8110 (Bug#8722)
8111
8112 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8113
8114 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8115
8116 ccl: Add integer overflow checks.
8117 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8118 (IN_INT_RANGE): New macros.
8119 (ccl_driver): Use them to check for integer overflow when
8120 decoding a CCL program. Many of the new checks are whether XINT (x)
8121 fits in int; it doesn't always, on 64-bit hosts. The new version
8122 doesn't catch all possible integer overflows, but it's an
8123 improvement. (Bug#8719)
8124
8125 * alloc.c (make_event_array): Use XINT, not XUINT.
8126 There's no need for unsigned here.
8127
8128 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8129 This follows up to the 2011-05-06 change that substituted uintptr_t
8130 for EMACS_INT. This case wasn't caught back then.
8131
8132 Rework Fformat to avoid integer overflow issues.
8133 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8134 now (part of C89). Include <verify.h>.
8135 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8136 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8137 (Fformat): Avoid the prepass trying to compute sizes; it was only
8138 approximate and thus did not catch overflow reliably. Instead, walk
8139 through the format just once, formatting and computing sizes as we go,
8140 checking for integer overflow at every step, and allocating a larger
8141 buffer as needed. Keep track separately whether the format is
8142 multibyte. Keep only the most-recently calculated precision, rather
8143 than them all. Record whether each argument has been converted to
8144 string. Use EMACS_INT, not int, for byte and char and arg counts.
8145 Support field widths and precisions larger than INT_MAX. Avoid
8146 sprintf's undefined behavior with conversion specifications such as %#d
8147 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8148 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8149 formatting out-of-range floating point numbers with int
8150 formats. (Bug#8668)
8151
8152 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8153
8154 * data.c: Avoid integer truncation in expressions involving floats.
8155 * data.c: Include <intprops.h>.
8156 (arith_driver): When there's an integer overflow in an expression
8157 involving floating point, convert the integers to floating point
8158 so that the resulting value does not suffer from catastrophic
8159 integer truncation. For example, on a 64-bit host (* 4
8160 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8161 Do not rely on undefined behavior after integer overflow.
8162
8163 merge count_size_as_multibyte, parse_str_to_multibyte
8164 * character.c, character.h (count_size_as_multibyte):
8165 Rename from parse_str_to_multibyte; all uses changed.
8166 Check for integer overflow.
8167 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8168 since it's now a duplicate of the other. This is more of
8169 a character than a buffer op, so better that it's in character.c.
8170 * fns.c, print.c: Adjust to above changes.
8171
8172 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8173
8174 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8175
8176 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8177
8178 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8179 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8180 (x_clipboard_manager_save): Now static.
8181 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8182
8183 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8184 (crypto_hash_function): Now static.
8185 Fix pointer signedness problems. Avoid unnecessary initializations.
8186
8187 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8188
8189 * termhooks.h (Vselection_alist): Make it terminal-local.
8190
8191 * terminal.c (create_terminal): Initialize it.
8192
8193 * xselect.c: Support for clipboard managers.
8194 (Vselection_alist): Move to termhooks.h as terminal-local var.
8195 (LOCAL_SELECTION): New macro.
8196 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8197 (symbol_to_x_atom): Remove gratuitous arg.
8198 (x_handle_selection_request, lisp_data_to_selection_data)
8199 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8200 (x_own_selection, x_get_local_selection, x_convert_selection):
8201 New arg, specifying work frame. Use terminal-local Vselection_alist.
8202 (some_frame_on_display): Delete unused function.
8203 (Fx_own_selection_internal, Fx_get_selection_internal)
8204 (Fx_disown_selection_internal, Fx_selection_owner_p)
8205 (Fx_selection_exists_p): New optional frame arg.
8206 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8207 (x_handle_selection_clear): Don't treat other terminals with the
8208 same keyboard specially. Use the terminal-local Vselection_alist.
8209 (x_clear_frame_selections): Use Frun_hook_with_args.
8210
8211 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8212
8213 * xterm.h: Add support for those atoms.
8214
8215 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8216
8217 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8218 (converted_selections, conversion_fail_tag): New global variables.
8219 (x_selection_request_lisp_error): Free the above.
8220 (x_get_local_selection): Remove unnecessary code.
8221 (x_reply_selection_request): Args changed; handle arbitrary array
8222 of converted selections stored in converted_selections.
8223 Separate the XChangeProperty and SelectionNotify steps.
8224 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8225 (x_convert_selection): New function.
8226 (x_handle_selection_event): Simplify.
8227 (x_get_foreign_selection): Don't ignore incoming requests while
8228 waiting for an answer; this will fail when we implement
8229 SAVE_TARGETS, and seems unnecessary anyway.
8230 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8231 (Vx_sent_selection_functions): Doc fix.
8232
8233 2011-05-26 Leo Liu <sdl.web@gmail.com>
8234
8235 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8236
8237 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8238
8239 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8240
8241 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8242 for fringe update if it has periodic bitmap.
8243 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8244 and fringe_bitmap_periodic_p.
8245
8246 * fringe.c (get_fringe_bitmap_data): New function.
8247 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8248 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8249 row. Mark glyph row for fringe update if periodicity changed.
8250
8251 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8252 for fringe update unless it has periodic bitmap.
8253
8254 2011-05-25 Kenichi Handa <handa@m17n.org>
8255
8256 * xdisp.c (get_next_display_element): Set correct it->face_id for
8257 a static composition.
8258
8259 2011-05-24 Leo Liu <sdl.web@gmail.com>
8260
8261 * deps.mk (fns.o):
8262 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8263
8264 * fns.c (crypto_hash_function, Fsha1): New function.
8265 (Fmd5): Use crypto_hash_function.
8266 (syms_of_fns): Add Ssha1.
8267
8268 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8269
8270 * gnutls.c: Remove unused macros.
8271 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8272 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8273 Remove macros that are defined and never used.
8274 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8275
8276 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8277
8278 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8279 (Fx_get_selection_internal): Minor cleanup.
8280 (Fx_own_selection_internal): Rename arguments for consistency with
8281 select.el.
8282
8283 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8284
8285 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8286
8287 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8288
8289 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8290
8291 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8292
8293 * dispnew.c (scrolling_window): Don't exclude the case that the
8294 last enabled row in the desired matrix touches the bottom boundary.
8295
8296 2011-05-21 Glenn Morris <rgm@gnu.org>
8297
8298 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8299 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8300 and add some more files.
8301
8302 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8303
8304 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8305 report_file_error introduced by the change from 2011-05-07.
8306
8307 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8308
8309 * systime.h (Time): Define only if emacs is defined.
8310 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8311 where the include path doesn't have X11/X.h by default. See
8312 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8313
8314 2011-05-20 Kenichi Handa <handa@m17n.org>
8315
8316 * composite.c (find_automatic_composition): Fix previous change.
8317
8318 2011-05-20 Glenn Morris <rgm@gnu.org>
8319
8320 * lisp.mk: New file, split from Makefile.in.
8321 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8322 (shortlisp): Remove.
8323 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8324
8325 2011-05-19 Glenn Morris <rgm@gnu.org>
8326
8327 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8328 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8329 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8330 (lisp): Set the order to that of loadup.el.
8331 (shortlisp): Make it a copy of $lisp.
8332 (SOME_MACHINE_LISP): Remove.
8333 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8334 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8335
8336 2011-05-18 Kenichi Handa <handa@m17n.org>
8337
8338 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8339 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8340 (find_automatic_composition): Mostly rewrite for efficiency.
8341
8342 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8343
8344 * makefile.w32-in: Update dependencies.
8345
8346 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8347
8348 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8349 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8350
8351 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8352
8353 Fix some integer overflow issues, such as string length overflow.
8354
8355 * insdel.c (count_size_as_multibyte): Check for string overflow.
8356
8357 * character.c (lisp_string_width): Check for string overflow.
8358 Use EMACS_INT, not int, for string indexes and lengths; in
8359 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8360 the resulting string length overflows an EMACS_INT; instead,
8361 report a string overflow if no precision given. When checking for
8362 precision exhaustion, use a check that cannot possibly have
8363 integer overflow. (Bug#8675)
8364 * character.h (lisp_string_width): Adjust to new signature.
8365
8366 * alloc.c (string_overflow): New function.
8367 (Fmake_string): Use it. This doesn't change behavior, but saves
8368 a few bytes and will simplify future changes.
8369 * character.c (string_escape_byte8): Likewise.
8370 * lisp.h (string_overflow): New decl.
8371
8372 Fixups, following up to the user-interface timestamp change.
8373 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8374 for UI timestamps, instead of unsigned long.
8375 * msdos.c (mouse_get_pos): Likewise.
8376 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8377 * w32gui.h (Time): Define by including "systime.h" rather than by
8378 declaring it ourselves. (Bug#8664)
8379
8380 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8381 * image.c (clear_image_cache): Likewise.
8382
8383 * term.c (term_mouse_position): Don't assume time_t wraparound.
8384
8385 Be more systematic about user-interface timestamps.
8386 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8387 and sometimes 'EMACS_UINT', to represent these timestamps.
8388 This change causes it to use 'Time' uniformly, as that's what X uses.
8389 This makes the code easier to follow, and makes it easier to catch
8390 integer overflow bugs such as Bug#8664.
8391 * frame.c (Fmouse_position, Fmouse_pixel_position):
8392 Use Time, not unsigned long, for user-interface timestamps.
8393 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8394 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8395 * keyboard.h (last_event_timestamp): Likewise.
8396 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8397 * menu.h (xmenu_show): Likewise.
8398 * term.c (term_mouse_position): Likewise.
8399 * termhooks.h (struct input_event.timestamp): Likewise.
8400 (struct terminal.mouse_position_hook): Likewise.
8401 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8402 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8403 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8404 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8405 what it was before.
8406 * menu.h, termhooks.h: Include "systime.h", for Time.
8407
8408 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8409 Don't assume that the difference between two unsigned long values
8410 can fit into an integer. At this point, we know button_down_time
8411 <= event->timestamp, so the difference must be nonnegative, so
8412 there's no need to cast the result if double-click-time is
8413 nonnegative, as it should be; check that it's nonnegative, just in
8414 case. This bug is triggered when events are more than 2**31 ms
8415 apart (about 25 days). (Bug#8664)
8416
8417 * xselect.c (last_event_timestamp): Remove duplicate decl.
8418 (x_own_selection): Remove needless cast to unsigned long.
8419
8420 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8421 that always fit in int. Use a sentinel instead of a counter, to
8422 avoid a temp and to allay GCC's concerns about possible int overflow.
8423 * frame.h (struct frame): Use int for menu_bar_items_used
8424 instead of EMACS_INT, since it always fits in int.
8425
8426 * menu.c (grow_menu_items): Check for int overflow.
8427
8428 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8429
8430 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8431 Before, the code was not consistent. These values cannot exceed
8432 2**31 - 1 so there's no need to make them unsigned.
8433 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8434 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8435 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8436 as modifiers.
8437 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8438
8439 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8440 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8441 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8442 presumably because the widths might not match.
8443
8444 * window.c (size_window): Avoid needless test at loop start.
8445
8446 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8447
8448 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8449
8450 2011-05-12 Drew Adams <drew.adams@oracle.com>
8451
8452 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8453
8454 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8455
8456 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8457 `width' to `bar_area_x' and `bar_area_width', respectively.
8458 (x_scroll_run): Take account of fringe background extension.
8459
8460 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8461 Rename local vars `left' and `width' to `bar_area_x' and
8462 `bar_area_width', respectively.
8463 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8464 background extension.
8465
8466 2011-05-10 Jim Meyering <meyering@redhat.com>
8467
8468 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8469
8470 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8471
8472 * image.c (Finit_image_library): Return t for built-in image types,
8473 like pbm and xbm. (Bug#8640)
8474
8475 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8476
8477 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8478
8479 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8480
8481 * w32console.c (Fset_screen_color): Doc fix.
8482 (Fget_screen_color): New function.
8483 (syms_of_ntterm): Defsubr it.
8484
8485 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8486 unlink the temporary file if Fcall_process didn't create it in the
8487 first place.
8488 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8489 child process will be redirected to a file specified with `:file'.
8490 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8491 cue to call_process_cleanup not to close that handle.
8492
8493 2011-05-07 Ben Key <bkey76@gmail.com>
8494
8495 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8496 one of two shell specific rules, either bootstrap-temacs-CMD or
8497 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8498 to the previous implementation of the bootstrap-temacs rule.
8499 The bootstrap-temacs-CMD rule is similar to the previous
8500 implementation of the bootstrap-temacs rule except that it
8501 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8502 variable.
8503
8504 These changes, along with some changes to nt/configure.bat,
8505 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8506 earlier fix to add support for --cflags and --ldflags options
8507 that include quotes so that it works whether make uses cmd or
8508 sh as the shell.
8509
8510 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8511
8512 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8513 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8514 is a constant.
8515 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8516 a string. Handle both cases.
8517 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8518 (Fdbus_register_method): Use Qinvalid_function.
8519
8520 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8521
8522 * makefile.w32-in: Update dependencies.
8523 (LISP_H): Add inttypes.h and stdin.h.
8524 (PROCESS_H): Add unistd.h.
8525
8526 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8527
8528 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8529 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8530
8531 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8532
8533 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8534
8535 * term.c (vfatal): Remove stray call to va_end.
8536 It's not needed and the C Standard doesn't allow it here anyway.
8537
8538 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8539 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8540
8541 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8542 bytes.
8543
8544 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8545
8546 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8547
8548 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8549
8550 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8551
8552 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8553
8554 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8555 * charset.c (Fdefine_charset_internal): Don't initialize
8556 charset.code_space[15]. The value was garbage, on hosts with
8557 32-bit int (Bug#8600).
8558
8559 * lread.c (read_integer): Be more consistent with string-to-number.
8560 Use string_to_number to do the actual conversion; this avoids
8561 rounding errors and fixes some other screwups. Without this fix,
8562 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8563 (digit_to_number): Move earlier, for benefit of read_integer.
8564 Return -1 if the digit is out of range for the base, -2 if it is
8565 not a digit in any supported base. (Bug#8602)
8566
8567 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8568
8569 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8570 to match comment at start of function. This also removes a
8571 GCC warning about overflow in a 32+64-bit port.
8572
8573 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8574
8575 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8576 Reported by Stefan Monnier in
8577 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8578 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8579 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8580
8581 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8582 (EMACS_UINTPTR): Likewise, with uintptr_t.
8583
8584 * lisp.h: Prefer 64-bit EMACS_INT if available.
8585 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8586 on 32-bit hosts that have 64-bit int, so that they can access
8587 large files.
8588 However, temporarily disable this change unless the temporary
8589 symbol WIDE_EMACS_INT is defined.
8590
8591 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8592
8593 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8594 This removes an assumption that EMACS_INT and long are the same
8595 width as pointers. The assumption is true for Emacs porting targets
8596 now, but we want to make other targets possible.
8597 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8598 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8599 In the rest of the code, change types of integers that hold casted
8600 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8601 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8602 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8603 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8604 No need to cast type when ORing.
8605 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8606 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8607 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8608 assume EMACS_INT is the same width as char *.
8609 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8610 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8611 Remove no-longer-needed casts.
8612 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8613 (xg_tool_bar_help_callback, xg_make_tool_item):
8614 Use EMACS_INTPTR to hold an integer
8615 that will be cast to void *; this can avoid a GCC warning
8616 if EMACS_INT is not the same width as void *.
8617 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8618 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8619 (current_message_1, set_message_1):
8620 Use a local to convert to proper width without a cast.
8621 * xmenu.c (dialog_selection_callback): Likewise.
8622
8623 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8624 Also, don't assume VALBITS / RAND_BITS is less than 5,
8625 and don't rely on undefined behavior when shifting a 1 left into
8626 the sign bit.
8627 * lisp.h (get_random): Change signature to match.
8628
8629 * lread.c (hash_string): Use size_t, not int, for hash computation.
8630 Normally we prefer signed values; but hashing is special, because
8631 it's better to use unsigned division on hash table sizes so that
8632 the remainder is nonnegative. Also, size_t is the natural width
8633 for hashing into memory. The previous code used 'int', which doesn't
8634 retain enough info to hash well into very large tables.
8635 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8636
8637 * dbusbind.c: Don't possibly lose pointer info when converting.
8638 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8639 Use XPNTR rather than XHASH, so that the high-order bits of
8640 the pointer aren't lost when converting through void *.
8641
8642 * eval.c (Fautoload): Don't double-shift a pointer.
8643
8644 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8645
8646 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8647
8648 * gnutls.c (DEF_GNUTLS_FN):
8649 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8650
8651 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8652
8653 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8654 marker. (Bug#8610)
8655
8656 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8657
8658 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8659 New version that can reserve upto 2GB of heap space.
8660
8661 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8662
8663 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8664
8665 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8666
8667 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8668 `gnutls_certificate_set_x509_key_file'.
8669
8670 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8671
8672 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8673 Update dependencies.
8674
8675 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8676
8677 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8678 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8679 Remove unused parameter `fildes'.
8680 * process.c (read_process_output, send_process): Don't pass it.
8681
8682 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8683
8684 Fix previous change: the library cache is defined in w32.c.
8685 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8686 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8687
8688 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8689
8690 Implement dynamic loading of GnuTLS on Windows.
8691
8692 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8693 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8694 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8695 Declare.
8696
8697 * gnutls.c (Qgnutls_dll): Define.
8698 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8699 (gnutls_*): Declare function pointers.
8700 (init_gnutls_functions): New function to initialize function pointers.
8701 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8702 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8703 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8704 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8705 (emacs_gnutls_write, emacs_gnutls_read)
8706 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8707 (Fgnutls_available_p): New function.
8708 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8709 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8710 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8711
8712 * image.c: Include w32.h.
8713 (Vimage_type_cache): Delete.
8714 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8715 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8716 (w32_delayed_load): Move to w32.c.
8717
8718 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8719
8720 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8721 (w32_delayed_load): Move from image.c. When loading a library, record
8722 its filename in the :loaded-from property of the library id.
8723 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8724 Initialize and staticpro them.
8725 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8726
8727 * process.c: Include lisp.h before w32.h, not after.
8728 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8729 instead of gnutls_record_check_pending.
8730
8731 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8732
8733 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8734
8735 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8736 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8737 as passed in.
8738
8739 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8740
8741 * xterm.c (x_set_frame_alpha): Do not set property on anything
8742 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8743
8744 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8745
8746 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8747
8748 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8749
8750 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8751 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8752 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8753 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8754 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8755 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8756 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8757 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8758 (Qgnutls_bootprop_callbacks_verify): Make static.
8759
8760 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8761
8762 * callproc.c: Indentation fixup.
8763
8764 * sysdep.c (wait_for_termination_1): Make static.
8765 (wait_for_termination, interruptible_wait_for_termination):
8766 Move after wait_for_termination_1.
8767
8768 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8769
8770 * sysdep.c (interruptible_wait_for_termination): New function
8771 which is like wait_for_termination, but allows keyboard
8772 interruptions.
8773
8774 * callproc.c (Fcall_process): Add (:file "file") as an option for
8775 the STDOUT buffer.
8776 (Fcall_process_region): Ditto.
8777
8778 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8779
8780 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8781 rather than `XVECTOR (FOO)->size'.
8782
8783 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8784 inttypes.h, as a gnulib replacement is used if it not available in
8785 system headers.
8786
8787 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8788
8789 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8790 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8791 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8792
8793 * coding.c (coding_alloc_by_realloc): Error out if destination
8794 will grow beyond MOST_POSITIVE_FIXNUM.
8795 (decode_coding_emacs_mule): Abort if there isn't enough place in
8796 charbuf for the composition carryover bytes. Reserve an extra
8797 space for up to 2 characters produced in a loop.
8798 (decode_coding_iso_2022): Abort if there isn't enough place in
8799 charbuf for the composition carryover bytes.
8800
8801 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8802
8803 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8804 aborting when %lld or %lll format is passed.
8805 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8806 %llo or %llx format is passed. (Bug#8545)
8807
8808 * window.c (window_scroll_line_based): Use a marker instead of
8809 simple variables to record original value of point. (Bug#7952)
8810
8811 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8812 produced by %s or %c overflows available buffer space. (Bug#8545)
8813
8814 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8815
8816 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8817 (SIZE_MAX): Move defn after all includes, as they might #define it.
8818
8819 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8820
8821 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8822
8823 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8824
8825 * keyboard.c (Qdelayed_warnings_hook): Define.
8826 (command_loop_1): Run `delayed-warnings-hook'
8827 if Vdelayed_warnings_list is non-nil.
8828 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8829 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8830
8831 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8832
8833 * doprnt.c (doprnt): Don't return value smaller than the buffer
8834 size if the message was truncated. (Bug#8545).
8835
8836 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8837
8838 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8839 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8840
8841 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8842
8843 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8844
8845 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8846
8847 * makefile.w32-in: Update dependencies.
8848
8849 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8850
8851 Improve `doprnt' and its usage. (Bug#8545)
8852 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8853 `format_end'. Remove support for %l as a conversion specifier.
8854 Don't use xrealloc. Improve diagnostics when the %l size modifier
8855 is used. Update the commentary.
8856
8857 * eval.c (verror): Simplify calculation of size_t.
8858
8859 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8860 messages.
8861
8862 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8863
8864 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8865 change.
8866
8867 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8868
8869 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8870 This makes this file independent of the recent pseudovector change.
8871
8872 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8873
8874 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8875
8876 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8877 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8878 Remove unused local.
8879 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8880
8881 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8882 GCC 4.6.0 optimizes based on type-based alias analysis.
8883 For example, if b is of type struct buffer * and v of type struct
8884 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8885 != &v->size, and therefore "v->size = 1; b->size = 2; return
8886 v->size;" must therefore return 1. This assumption is incorrect
8887 for Emacs, since it type-puns struct Lisp_Vector * with many other
8888 types. To fix this problem, this patch adds a new type struct
8889 vectorlike_header that documents the constraints on layout of vectors
8890 and pseudovectors, and helps optimizing compilers not get fooled
8891 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8892 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8893 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8894 the size member.
8895 (XSETPVECTYPE): Rewrite in terms of new macro.
8896 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8897 This is a bit clearer, and further avoids the possibility of
8898 undesirable aliasing.
8899 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8900 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8901 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8902 since Lisp_Subr is a special case (no "next" field).
8903 (ASIZE): Now uses header.size rather than size.
8904 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8905 to avoid the hassle of writing XVECTOR (foo)->header.size.
8906 (struct vectorlike_header): New type.
8907 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8908 object, to help avoid aliasing.
8909 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8910 (SUBRP): Likewise, since Lisp_Subr is a special case.
8911 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8912 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8913 (struct Lisp_Hash_Table): Combine first two members into a single
8914 struct vectorlike_header member. All uses of "size" and "next" members
8915 changed to be "header.size" and "header.next".
8916 * buffer.h (struct buffer): Likewise.
8917 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8918 * frame.h (struct frame): Likewise.
8919 * process.h (struct Lisp_Process): Likewise.
8920 * termhooks.h (struct terminal): Likewise.
8921 * window.c (struct save_window_data, struct saved_window): Likewise.
8922 * window.h (struct window): Likewise.
8923 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8924 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8925 * buffer.c (init_buffer_once): Likewise.
8926 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8927 special case.
8928 * process.c (Fformat_network_address): Use local var for size,
8929 for brevity.
8930
8931 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8932
8933 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8934 * data.c (atof): Remove decl; no longer used or needed.
8935 (digit_to_number): Move to lread.c.
8936 (Fstring_to_number): Use new string_to_number function, to be
8937 consistent with how the Lisp reader treats infinities and NaNs.
8938 Do not assume that floating-point numbers represent EMACS_INT
8939 without losing information; this is not true on most 64-bit hosts.
8940 Avoid double-rounding errors, by insisting on integers when
8941 parsing non-base-10 numbers, as the documentation specifies.
8942 * lisp.h (string_to_number): New decl, replacing ...
8943 (isfloat_string): Remove.
8944 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8945 (read1): Do not accept +. and -. as integers; this
8946 appears to have been a coding error. Similarly, do not accept
8947 strings like +-1e0 as floating point numbers. Do not report
8948 overflow for integer overflows unless the base is not 10 which
8949 means we have no simple and reliable way to continue.
8950 Break out the floating-point parsing into a new
8951 function string_to_number, so that Fstring_to_number parses
8952 floating point numbers consistently with the Lisp reader.
8953 (digit_to_number): Move here from data.c. Make it static inline.
8954 (E_CHAR, EXP_INT): Remove, replacing with ...
8955 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8956 (string_to_number): New function, replacing isfloat_string.
8957 This function checks for valid syntax and produces the resulting
8958 Lisp float number too. Rework it so that string-to-number
8959 no longer mishandles examples like "1.0e+". Use strtoumax,
8960 so that overflow for non-base-10 numbers is reported only when
8961 there's no portable and simple way to convert to floating point.
8962
8963 * textprop.c (set_text_properties_1): Rewrite for clarity,
8964 and to avoid GCC warning about integer overflow.
8965
8966 * intervals.h (struct interval): Use EMACS_INT for members
8967 where EMACS_UINT might cause problems. See
8968 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8969 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8970 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8971 All uses changed.
8972 (offset_intervals): Tell GCC not to worry about length overflow
8973 when negating a negative length.
8974
8975 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8976 (overrun_check_free): Likewise.
8977
8978 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8979 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8980 word size.
8981
8982 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8983 (gnutls_make_error): Rename local to avoid shadowing.
8984 (gnutls_emacs_global_deinit): ifdef out; not used.
8985 (Fgnutls_boot): Use const for pointer to readonly storage.
8986 Comment out unused local. Fix pointer signedness problems.
8987
8988 * lread.c (openp): Don't stuff size_t into an 'int'.
8989 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8990 about possible signed overflow.
8991
8992 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8993 (GDK_KEY_g): Don't define if already defined.
8994 (xg_prepare_tooltip): Avoid pointer signedness problem.
8995 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8996
8997 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8998 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8999
9000 * xfns.c (Fx_window_property): Simplify a bit,
9001 to make a bit faster and to avoid GCC 4.6.0 warning.
9002 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9003
9004 * fns.c (internal_equal): Don't assume size_t fits in int.
9005
9006 * alloc.c (compact_small_strings): Tighten assertion a little.
9007
9008 Replace pEd with more-general pI, and fix some printf arg casts.
9009 * lisp.h (pI): New macro, generalizing old pEd macro to other
9010 conversion specifiers. For example, use "...%"pI"d..." rather
9011 than "...%"pEd"...".
9012 (pEd): Remove. All uses replaced with similar uses of pI.
9013 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9014 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9015 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9016 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9017 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9018 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9019 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9020 64-bit hosts.
9021 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9022 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9023 * print.c (safe_debug_print, print_object): Likewise.
9024 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9025 to int.
9026 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9027 avoiding the 0 flag, which is not portable.
9028 * process.c (Fmake_network_process): Use pI to avoid cast.
9029 * region-cache.c (pp_cache): Likewise.
9030 * xdisp.c (decode_mode_spec): Likewise.
9031 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9032 behavior on 64-bit hosts with printf arg.
9033 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9034 (x_stop_queuing_selection_requests): Likewise.
9035 (x_get_window_property): Don't truncate byte count to an 'int'
9036 when tracing.
9037
9038 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9039 here, since it parses constructs like leading '-' and spaces,
9040 which are not wanted; and it overflows with large numbers.
9041 Instead, simply match F[0-9]+, which is what is wanted anyway.
9042
9043 * alloc.c: Remove unportable assumptions about struct layout.
9044 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9045 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9046 (allocate_vectorlike, make_pure_vector): Use the new macros,
9047 plus offsetof, to remove unportable assumptions about struct layout.
9048 These assumptions hold on all porting targets that I know of, but
9049 they are not guaranteed, they're easy to remove, and removing them
9050 makes further changes easier.
9051
9052 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9053 This doesn't fix a bug but makes the code clearer.
9054 (string_overrun_cookie): Now const. Use initializers that
9055 don't formally overflow signed char, to avoid warnings.
9056 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9057 can cause Emacs to crash when string overrun checking is enabled.
9058 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9059 multiple of sizeof (EMACS_INT); it need not be, if
9060 alignof(EMACS_INT) < sizeof (EMACS_INT).
9061 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9062
9063 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9064
9065 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9066
9067 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9068
9069 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9070 supposed to be handshaking. (Bug#8556)
9071 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9072
9073 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9074
9075 * lisp.h (Qdebug): List symbol.
9076 * eval.c (Qdebug): Restore global linkage.
9077 * keyboard.c (debug-on-event): New variable.
9078 (handle_user_signal): Break into debugger when debug-on-event
9079 matches the current signal symbol.
9080
9081 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9082
9083 * alloc.c (check_sblock, check_string_bytes)
9084 (check_string_free_list): Convert to standard C.
9085
9086 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9087
9088 * w32.c (emacs_gnutls_push): Fix typo.
9089
9090 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9091
9092 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9093 "cast to pointer from integer of different size".
9094
9095 Improve doprnt and its use in verror. (Bug#8545)
9096 * doprnt.c (doprnt): Document the set of format control sequences
9097 supported by the function. Use SAFE_ALLOCA instead of always
9098 using `alloca'.
9099
9100 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9101 is one byte too soon. Don't use xrealloc; instead xfree and
9102 xmalloc anew.
9103
9104 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9105
9106 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9107 callbacks stage.
9108
9109 * gnutls.c: Renamed global_initialized to
9110 gnutls_global_initialized. Added internals for the
9111 :verify-hostname-error, :verify-error, and :verify-flags
9112 parameters of `gnutls-boot' and documented those parameters in the
9113 docstring. Start callback support.
9114 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9115 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9116 on error. Return error code.
9117 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9118 (emacs_gnutls_read): Likewise.
9119 (Fgnutls_boot): Return handshake error code.
9120 (emacs_gnutls_handle_error): New function.
9121 (wsaerror_to_errno): Likewise.
9122
9123 * w32.h (emacs_gnutls_pull): Add prototype.
9124 (emacs_gnutls_push): Likewise.
9125
9126 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9127 (emacs_gnutls_push): Likewise.
9128
9129 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9130
9131 * process.c (wait_reading_process_output): Check if GnuTLS
9132 buffered some data internally if no FDs are set for TLS
9133 connections.
9134
9135 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9136 (LIBS): Link to USER_LIBS.
9137 ($(BLD)/gnutls.$(0)): New target.
9138
9139 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9140
9141 * xdisp.c (handle_single_display_spec): Rename the
9142 display_replaced_before_p argument into display_replaced_p, to
9143 make it consistent with the commentary. Fix typos in the
9144 commentary.
9145
9146 * textprop.c (syms_of_textprop): Remove dead code.
9147 (copy_text_properties): Delete obsolete commentary about an
9148 interface that was deleted long ago. Fix typos in the description
9149 of arguments.
9150
9151 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9152 to changes in oldXMenu/XMenu.h from 2011-04-16.
9153 <menu_help_message, prev_menu_help_message>: Constify.
9154 (IT_menu_make_room): menu->help_text is now `const char **';
9155 adjust.
9156
9157 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9158 to changes in oldXMenu/XMenu.h from 2011-04-16.
9159 (struct XMenu): Declare `help_text' `const char **'.
9160
9161 * xfaces.c <Qunspecified>: Make extern again.
9162
9163 * syntax.c: Include sys/types.h before including regex.h, as
9164 required by POSIX.
9165
9166 * doc.c (get_doc_string): Improve the format passed to `error'.
9167
9168 * doprnt.c (doprnt): Improve commentary.
9169
9170 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9171
9172 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9173 them with etags.
9174
9175 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9176 changes in globals.h immediately force recompilation.
9177 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9178 $(CURDIR)/s/ms-w32.h.
9179 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9180
9181 * character.c (Fchar_direction): Function deleted.
9182 (syms_of_character): Don't defsubr it.
9183 <char-direction-table>: Deleted.
9184
9185 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9186
9187 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9188 * doprnt.c: Include limits.h.
9189 (SIZE_MAX): New macro.
9190 (doprnt): Return a size_t value. 2nd arg is now size_t.
9191 Many local variables are now size_t instead of int or unsigned.
9192 Improve overflow protection. Support `l' modifier for integer
9193 conversions. Support %l conversion. Don't assume an EMACS_INT
9194 argument for integer conversions and for %c.
9195
9196 * lisp.h (doprnt): Restore prototype.
9197
9198 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9199 $(SRC)/character.h.
9200
9201 * Makefile.in (base_obj): Add back doprnt.o.
9202
9203 * deps.mk (doprnt.o): Add back prerequisites.
9204 (callint.o): Depend on character.h.
9205
9206 * eval.c (internal_lisp_condition_case): Include the handler
9207 representation in the error message.
9208 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9209 when breaking from the loop.
9210
9211 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9212
9213 * callint.c (Fcall_interactively): When displaying error message
9214 about invalid control letter, pass the character's codepoint, not
9215 a pointer to its multibyte form. Improve display of the character
9216 in octal and display also its hex code.
9217
9218 * character.c (char_string): Use %x to display the (unsigned)
9219 codepoint of an invalid character, to avoid displaying a bogus
9220 negative value.
9221
9222 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9223 `error', not SYMBOL_NAME itself.
9224
9225 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9226 character arguments to `error'.
9227
9228 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9229 to `error' in error message about FINAL_CHAR argument. Make sure
9230 FINAL_CHAR is a character, and use %c when it is passed as
9231 argument to `error'.
9232
9233 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9234
9235 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9236
9237 * w32.c: Include <time.h>.
9238 (sys_localtime): New function.
9239
9240 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9241
9242 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9243
9244 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9245
9246 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9247
9248 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9249 zombies (Bug#8467).
9250
9251 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9252
9253 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9254 gl_state.e_property when gl_state.object is Qt.
9255
9256 * insdel.c (make_gap_larger): Remove limitation of buffer size
9257 to <= INT_MAX.
9258
9259 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9260
9261 * xdisp.c (lookup_glyphless_char_display)
9262 (produce_glyphless_glyph): Handle cons cell entry in
9263 glyphless-char-display.
9264 (Vglyphless_char_display): Document it.
9265
9266 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9267 glyphless-char-display.
9268
9269 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9270
9271 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9272
9273 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9274
9275 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9276 definition for no-X builds.
9277
9278 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9279
9280 Static checks with GCC 4.6.0 and non-default toolkits.
9281
9282 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9283
9284 * process.c (keyboard_bit_set): Define only if SIGIO.
9285 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9286 (send_process): Repair possible setjmp clobbering.
9287
9288 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9289
9290 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9291
9292 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9293
9294 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9295 Define only if needed.
9296
9297 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9298 by pacifying GCC about it. Maybe it's time to retire it?
9299 * xfaces.c (USG, __TIMEVAL__): Likewise.
9300
9301 * dispextern.h (struct redisplay_interface): Rename param
9302 to avoid shadowing.
9303 * termhooks.h (struct terminal): Likewise.
9304 * xterm.c (xembed_send_message): Likewise.
9305
9306 * insdel.c (make_gap_smaller): Define only if
9307 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9308
9309 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9310 it.
9311
9312 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9313 so that we aren't warned about unused symbols.
9314
9315 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9316
9317 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9318
9319 * xfns.c (x_real_positions): Mark locals as initialized.
9320
9321 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9322
9323 * xterm.c: Fix problems found by static analysis with other toolkits.
9324 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9325 (x_dispatch_event): Declare static if USE_GTK, and
9326 define if USE_GTK || USE_X_TOOLKIT.
9327 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9328 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9329 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9330 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9331
9332 * xmenu.c (menu_help_callback): Pointer type fixes.
9333 Use const pointers when pointing at readonly data. Avoid pointer
9334 signedness clashes.
9335 (FALSE): Remove unused macro.
9336 (update_frame_menubar): Remove unused decl.
9337
9338 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9339
9340 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9341 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9342 (single_menu_item): Rename local to avoid shadowing.
9343
9344 * keyboard.c (make_lispy_event): Remove unused local var.
9345
9346 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9347 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9348
9349 * bitmaps: Change bitmaps from unsigned char back to the X11
9350 compatible char. Avoid the old compiler warnings about
9351 out-of-range initializers by using, for example, '\xab' rather
9352 than 0xab.
9353
9354 * xgselect.c (xgselect_initialize): Check vs interface
9355 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9356
9357 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9358
9359 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9360 to read-only memory.
9361
9362 * fns.c (vector): Remove; this old hack is no longer needed.
9363
9364 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9365 Remove unused var.
9366 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9367
9368 * xrdb.c (x_load_resources): Omit unused local.
9369
9370 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9371 (x_window): Rename locals to avoid shadowing.
9372 (USG): Use the kludged USG macro, to pacify gcc.
9373
9374 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9375 (x_term_init): Remove local to avoid shadowing.
9376
9377 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9378
9379 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9380 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9381
9382 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9383
9384 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9385
9386 Fix regex.c, syntax.c and friends for buffers > 2GB.
9387 * syntax.h (struct gl_state_s): Declare character position members
9388 EMACS_INT.
9389
9390 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9391
9392 * textprop.c (verify_interval_modification, interval_of):
9393 Declare arguments EMACS_INT.
9394
9395 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9396 EMACS_INT.
9397
9398 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9399
9400 * indent.c (Fvertical_motion): Local variable it_start is now
9401 EMACS_INT.
9402
9403 * regex.c (re_match, re_match_2, re_match_2_internal)
9404 (bcmp_translate, regcomp, regexec, print_double_string)
9405 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9406 (re_compile_pattern, re_exec): Declare arguments and local
9407 variables `size_t' and `ssize_t' and return values `regoff_t', as
9408 appropriate.
9409 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9410 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9411 <compile_stack_type>: `size' and `avail' are now `size_t'.
9412
9413 * regex.h <regoff_t>: Use ssize_t, not int.
9414 (re_search, re_search_2, re_match, re_match_2): Arguments that
9415 specify buffer/string position and length are now ssize_t and
9416 size_t. Return type is regoff_t.
9417
9418 2011-04-16 Ben Key <bkey76@gmail.com>
9419
9420 * nsfont.m: Fixed bugs in ns_get_family and
9421 ns_descriptor_to_entity that were caused by using free to
9422 deallocate memory blocks that were allocated by xmalloc (via
9423 xstrdup). This caused Emacs to crash when compiled with
9424 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9425 --enable-checking=xmallocoverrun). xfree is now used to
9426 deallocate these memory blocks.
9427
9428 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9429
9430 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9431
9432 emacs_write: Accept and return EMACS_INT for sizes.
9433 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9434 et seq.
9435 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9436 Accept and return EMACS_INT.
9437 (emacs_gnutls_write): Return the number of bytes written on
9438 partial writes.
9439 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9440 (emacs_read, emacs_write): Remove check for negative size, as the
9441 Emacs source code has been audited now.
9442 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9443 (emacs_read, emacs_write): Use it.
9444 * process.c (send_process): Adjust to the new signatures of
9445 emacs_write and emacs_gnutls_write. Do not attempt to store
9446 a byte offset into an 'int'; it might overflow.
9447 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9448
9449 * sound.c: Don't assume sizes fit in 'int'.
9450 (struct sound_device.period_size, alsa_period_size):
9451 Return EMACS_INT, not int.
9452 (struct sound_device.write, vox_write, alsa_write):
9453 Accept EMACS_INT, not int.
9454 (wav_play, au_play): Use EMACS_INT to store sizes and to
9455 record read return values.
9456
9457 2011-04-15 Ben Key <bkey76@gmail.com>
9458
9459 * keyboard.c (Qundefined): Don't declare static since it is used
9460 in nsfns.m.
9461 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9462 static since they are used in nsfont.m.
9463
9464 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9465
9466 * process.c (Qprocessp): Don't declare static.
9467 * lisp.h (Qprocessp): Declare again.
9468
9469 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9470
9471 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9472
9473 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9474
9475 Improve C-level modularity by making more things 'static'.
9476
9477 Don't publish debugger-only interfaces to other modules.
9478 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9479 (verify_bytepos, count_markers): Move decls to the only modules
9480 that need them.
9481 * region-cache.h (pp_cache): Likewise.
9482 * window.h (check_all_windows): Likewise.
9483 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9484
9485 * sysdep.c (croak): Now static, if
9486 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9487 * syssignal.h (croak): Declare only if not static.
9488
9489 * alloc.c (refill_memory_reserve): Now static if
9490 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9491 * lisp.h (refill_memory_reserve): Declare only if not static.
9492
9493 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9494 Define only if USE_LUCID.
9495
9496 * xrdb.c (x_customization_string, x_rm_string): Now static.
9497
9498 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9499 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9500
9501 * xdisp.c (draw_row_with_mouse_face): Now static.
9502 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9503
9504 * window.h (check_all_windows): Mark externally visible.
9505
9506 * window.c (window_deletion_count): Now static.
9507
9508 * undo.c: Make symbols static if they're not exported.
9509 (last_undo_buffer, last_boundary_position, pending_boundary):
9510 Now static.
9511
9512 * textprop.c (interval_insert_behind_hooks): Now static.
9513 (interval_insert_in_front_hooks): Likewise.
9514
9515 * term.c: Make symbols static if they're not exported.
9516 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9517 (max_frame_lines, tty_set_terminal_modes):
9518 (tty_reset_terminal_modes, tty_turn_off_highlight):
9519 (get_tty_terminal): Now static.
9520 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9521 * termhooks.h (term_mouse_moveto): Do not declare if
9522 HAVE_WINDOW_SYSTEM.
9523 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9524 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9525
9526 * sysdep.c: Make symbols static if they're not exported.
9527 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9528 Now static.
9529 (sigprocmask_set, full_mask): Remove; unused.
9530 (wait_debugging): Mark as visible.
9531 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9532 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9533
9534 * syntax.c (syntax_temp): Define only if !__GNUC__.
9535
9536 * sound.c (current_sound_device, current_sound): Now static.
9537
9538 * search.c (searchbufs, searchbuf_head): Now static.
9539
9540 * scroll.c (scroll_cost): Remove; unused.
9541 * dispextern.h (scroll_cost): Remove decl.
9542
9543 * region-cache.h (pp_cache): Mark as externally visible.
9544
9545 * process.c: Make symbols static if they're not exported.
9546 (process_tick, update_tick, create_process, chan_process):
9547 (Vprocess_alist, proc_buffered_char, datagram_access):
9548 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9549 (deactivate_process): Mark defn as static, as well as decl.
9550 * lisp.h (create_process): Remove decl.
9551 * process.h (chan_process, Vprocess_alist): Remove decls.
9552
9553 * print.c: Make symbols static if they're not exported.
9554 (print_depth, new_backquote_output, being_printed, print_buffer):
9555 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9556 (print_interval, print_number_index, initial_stderr_stream):
9557 Now static.
9558 * lisp.h (Fprinc): Remove decl.
9559 (debug_output_compilation_hack): Mark as externally visible.
9560
9561 * sysdep.c (croak): Move decl from here to syssignal.h.
9562 * syssignal.h (croak): Put it here, so the API can be checked when
9563 'croak' is called from dissociate_if_controlling_tty.
9564
9565 * minibuf.c: Make symbols static if they're not exported.
9566 (minibuf_save_list, choose_minibuf_frame): Now static.
9567 * lisp.h (choose_minibuf_frame): Remove decl.
9568
9569 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9570
9571 * lread.c: Make symbols static if they're not exported.
9572 (read_objects, initial_obarray, oblookup_last_bucket_number):
9573 Now static.
9574 (make_symbol): Remove; unused.
9575 * lisp.h (initial_obarray, make_symbol): Remove decls.
9576
9577 * keyboard.c: Make symbols static if they're not exported.
9578 (single_kboard, recent_keys_index, total_keys, recent_keys):
9579 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9580 (this_single_command_key_start, echoing, last_auto_save):
9581 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9582 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9583 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9584 (Vlispy_mouse_stem, double_click_count):
9585 Now static.
9586 (force_auto_save_soon): Define only if SIGDANGER.
9587 (ignore_mouse_drag_p): Now static if
9588 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9589 (print_help): Remove; unused.
9590 (stop_character, last_timer_event): Mark as externally visible.
9591 * keyboard.h (ignore_mouse_drag_p): Declare only if
9592 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9593 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9594 * lisp.h (echoing): Remove decl.
9595 (force_auto_save_soon): Declare only if SIGDANGER.
9596 * xdisp.c (redisplay_window): Simplify code, to make it more
9597 obvious that ignore_mouse_drag_p is not accessed if !defined
9598 USE_GTK && !defined HAVE_NS.
9599
9600 * intervals.c: Make symbols static if they're not exported.
9601 (merge_properties_sticky, merge_interval_right, delete_interval):
9602 Now static.
9603 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9604
9605 * insdel.c: Make symbols static if they're not exported.
9606 However, leave prepare_to_modify_buffer alone. It's never
9607 called from outside this function, but that appears to be a bug.
9608 (combine_after_change_list, combine_after_change_buffer):
9609 (adjust_after_replace, signal_before_change): Now static.
9610 (adjust_after_replace_noundo): Remove; unused.
9611 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9612 (signal_before_change): Remove decls.
9613
9614 * indent.c (val_compute_motion, val_vmotion): Now static.
9615
9616 * image.c: Make symbols static if they're not exported.
9617 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9618 if USE_GTK.
9619 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9620 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9621
9622 * fringe.c (standard_bitmaps): Now static.
9623 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9624
9625 * frame.c: Make symbols static if they're not exported.
9626 (x_report_frame_params, make_terminal_frame): Now static.
9627 (get_frame_param): Now static, unless HAVE_NS.
9628 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9629 (x_get_resource_string): Remove; not used.
9630 * frame.h (make_terminal_frame, x_report_frame_params):
9631 (x_get_resource_string); Remove decls.
9632 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9633 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9634
9635 * font.c, fontset.c: Make symbols static if they're not exported.
9636 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9637 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9638 * font.c (font_close_object): Now static.
9639 * font.h (font_close_object): Remove.
9640 * fontset.c (FONTSET_OBJLIST): Remove.
9641 (free_realized_fontset) #if-0 the body, which does nothing.
9642 (face_suitable_for_char_p): #if-0, as it's never called.
9643 * fontset.h (face_suitable_for_char_p): Remove decl.
9644 * xfaces.c (face_at_string_position):
9645 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9646 since 0 is always ASCII.
9647
9648 * fns.c (weak_hash_tables): Now static.
9649
9650 * fileio.c: Make symbols static if they're not exported.
9651 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9652 (Vwrite_region_annotation_buffers): Now static.
9653
9654 * eval.c: Make symbols static if they're not exported.
9655 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9656 * lisp.h (backtrace_list): Remove decl.
9657
9658 * emacs.c: Make symbols static if they're not exported.
9659 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9660 (fatal_error_code, fatal_error_signal_hook, standard_args):
9661 Now static.
9662 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9663 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9664 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9665 * lisp.h (fatal_error_signal_hook): Remove decl.
9666 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9667
9668 * editfns.c: Move a (normally-unused) function to its only use.
9669 * editfns.c, lisp.h (get_operating_system_release): Remove.
9670 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9671 worth the hassle of breaking this out.
9672
9673 * xterm.c: Make symbols static if they're not exported.
9674 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9675 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9676 (x_destroy_window, x_delete_display):
9677 Now static.
9678 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9679 (x_mouse_leave): Remove; unused.
9680 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9681 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9682 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9683 Remove decls.
9684 (x_mouse_leave): Declare only if WINDOWSNT.
9685 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9686 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9687 USE_X_TOOLKIT.
9688
9689 * ftxfont.c: Make symbols static if they're not exported.
9690 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9691 HAVE_FREETYPE.
9692 * font.h (ftxfont_driver): Likewise.
9693
9694 * xfns.c: Make symbols static if they're not exported.
9695 (x_last_font_name, x_display_info_for_name):
9696 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9697 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9698 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9699 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9700 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9701 (last_show_tip_args): Now static.
9702 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9703 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9704 (x_screen_planes): Remove; unused.
9705 * dispextern.h (x_screen_planes): Remove decl.
9706
9707 * dispnew.c: Make symbols static if they're not exported.
9708 * dispextern.h (redraw_garbaged_frames, scrolling):
9709 (increment_row_positions): Remove.
9710 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9711 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9712 Now static.
9713 (redraw_garbaged_frames): Remove; unused.
9714
9715 * xfaces.c: Make symbols static if they're not exported.
9716 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9717 Remove decls.
9718 * xterm.h (defined_color): Remove decls.
9719 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9720 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9721 (menu_face_changed_default, defined_color, free_realized_face):
9722 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9723 (ascii_face_of_lisp_face): Remove; unused.
9724
9725 * xdisp.c: Make symbols static if they're not exported.
9726 * dispextern.h (scratch_glyph_row, window_box_edges):
9727 (glyph_to_pixel_coords, set_cursor_from_row):
9728 (get_next_display_element, set_iterator_to_next):
9729 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9730 (show_mouse_face): Remove decls
9731 * frame.h (message_buf_print): Likewise.
9732 * lisp.h (pop_message, set_message, check_point_in_composition):
9733 Likewise.
9734 * xterm.h (set_vertical_scroll_bar): Likewise.
9735 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9736 (message_buf_print, scratch_glyph_row, displayed_buffer):
9737 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9738 (get_next_display_element, show_mouse_face, window_box_edges):
9739 (frame_to_window_pixel_xy, check_point_in_composition):
9740 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9741 (glyph_to_pixel_coords): Remove; unused.
9742
9743 * dired.c (file_name_completion): Now static.
9744
9745 * dbusbind.c (xd_in_read_queued_messages): Now static.
9746
9747 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9748 * data.c (circular_list_error): Remove.
9749
9750 * commands.h (last_point_position, last_point_position_buffer):
9751 (last_point_position_window): Remove decls.
9752 * keyboard.c: Make these variables static.
9753
9754 * coding.h (coding, code_convert_region, encode_coding_gap):
9755 Remove decls.
9756 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9757 (iso_code_class, detect_coding, code_convert_region): Now static.
9758 (encode_coding_gap): Remove; unused.
9759
9760 * chartab.c (chartab_chars, chartab_bits): Now static.
9761
9762 * charset.h (charset_iso_8859_1): Remove decl.
9763 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9764 Now static.
9765
9766 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9767 * ccl.c (Vccl_program_table): Now static.
9768 (check_ccl_update): Remove; unused.
9769
9770 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9771 * category.h: ... from here.
9772 * category.c (check_category_table, set_category_set): Now static.
9773
9774 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9775 * lisp.h: Remove these decls.
9776
9777 * buffer.c (buffer_count): Remove unused var.
9778
9779 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9780 so that it's not optimized away.
9781 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9782 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9783 exported only to the debugger.
9784
9785 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9786 * atimer.h (run_all_atimers): Remove; not exported.
9787
9788 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9789 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9790 was inaccessible from Lisp.
9791 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9792 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9793
9794 alloc.c: Import and export fewer symbols, and remove unused items.
9795 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9796 is defined.
9797 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9798 it's not optimized away by whole-program optimization.
9799 (message_enable_multibyte, free_misc): Remove.
9800 (catchlist, handlerlist, mark_backtrace):
9801 Declare only if BYTE_MARK_STACK.
9802 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9803 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9804 (message_enable_multibyte): Remove decl.
9805 (free_misc, interval_free_list, float_block, float_block_index):
9806 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9807 (cons_free_list, last_marked_index):
9808 Now static.
9809 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9810 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9811 (mark_backtrace): Define only if BYTE_MARK_STACK.
9812 * xdisp.c (message_enable_multibyte): Now static.
9813
9814 Declare Lisp_Object Q* variables to be 'static' if not exported.
9815 This makes it easier for human readers (and static analyzers)
9816 to see whether these variables are used from other modules.
9817 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9818 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9819 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9820 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9821 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9822 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9823 * xmenu.c, xselect.c:
9824 Declare Q* vars static if they are not used in other modules.
9825 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9826 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9827 Remove decls of unexported vars.
9828 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9829
9830 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9831
9832 Make Emacs functions such as Fatom 'static' by default.
9833 This makes it easier for human readers (and static analyzers)
9834 to see whether these functions can be called from other modules.
9835 DEFUN now defines a static function. To make the function external
9836 so that it can be used in other C modules, use the new macro DEFUE.
9837 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9838 (Finit_image_library):
9839 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9840 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9841 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9842 Remove decls, since these functions are now static.
9843 (Funintern, Fget_internal_run_time): New decls, since these functions
9844 were already external.
9845
9846 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9847 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9848 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9849 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9850 * keyboard.c, keymap.c, lread.c:
9851 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9852 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9853 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9854 Mark functions with DEFUE instead of DEFUN,
9855 if they are used in other modules.
9856 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9857 decls for now-static functions.
9858 * buffer.h (Fdelete_overlay): Remove decl.
9859 * callproc.c (Fgetenv_internal): Mark as internal.
9860 * composite.c (Fremove_list_of_text_properties): Remove decl.
9861 (Fcomposition_get_gstring): New forward static decl.
9862 * composite.h (Fcomposite_get_gstring): Remove decl.
9863 * dired.c (Ffile_attributes): New forward static decl.
9864 * doc.c (Fdocumntation_property): New forward static decl.
9865 * eval.c (Ffetch_bytecode): New forward static decl.
9866 (Funintern): Remove extern decl; now in .h file where it belongs.
9867 * fileio.c (Fmake_symbolic_link): New forward static decl.
9868 * image.c (Finit_image_library): New forward static decl.
9869 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9870 * intervals.h (Fprevious_property_change):
9871 (Fremove_list_of_text_properties): Remove decls.
9872 * keyboard.c (Fthis_command_keys): Remove decl.
9873 (Fcommand_execute): New forward static decl.
9874 * keymap.c (Flookup_key): New forward static decl.
9875 (Fcopy_keymap): Now static.
9876 * keymap.h (Flookup_key): Remove decl.
9877 * process.c (Fget_process): New forward static decl.
9878 (Fprocess_datagram_address): Mark as internal.
9879 * syntax.c (Fsyntax_table_p): New forward static decl.
9880 (skip_chars): Remove duplicate decl.
9881 * textprop.c (Fprevious_property_change): New forward static decl.
9882 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9883 Now internal.
9884 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9885 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9886
9887 * editfns.c (Fformat): Remove unreachable code.
9888
9889 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9890
9891 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9892 change. (Bug#8496)
9893
9894 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9895
9896 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9897 when at ZV. (Bug#8487)
9898
9899 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9900
9901 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9902 (Bug#8437)
9903 * keyboard.c (parse_tool_bar_item): Likewise.
9904 * sound.c (sound_cleanup, alsa_close): Likewise.
9905 * termcap.c (tgetent): Likewise.
9906 * xfns.c (x_default_font_parameter): Likewise.
9907 * xsettings.c (read_and_apply_settings): Likewise.
9908
9909 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9910 (overrun_check_free): Protoize.
9911
9912 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9913
9914 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9915 since callers should never pass a negative size.
9916 Change the signature to match that of plain 'read' and 'write'; see
9917 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9918 * lisp.h: Update prototypes of emacs_write and emacs_read.
9919
9920 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9921
9922 * xdisp.c (redisplay_window): Don't try to determine the character
9923 position of the scroll margin if the window start point w->startp
9924 is outside the buffer's accessible region. (Bug#8468)
9925
9926 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9927
9928 Fix write-region and its subroutines for buffers > 2GB.
9929 * fileio.c (a_write, e_write): Modify declaration of arguments and
9930 local variables to support buffers larger than 2GB.
9931 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9932
9933 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9934 argument, local variables, and return value.
9935
9936 * lisp.h: Update prototypes of emacs_write and emacs_read.
9937
9938 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9939
9940 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9941
9942 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9943
9944 Fix more problems found by GCC 4.6.0's static checks.
9945
9946 * xdisp.c (vmessage): Use a better test for character truncation.
9947
9948 * charset.c (load_charset_map): <, not <=, for optimization,
9949 and to avoid potential problems with integer overflow.
9950 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9951 * casetab.c (set_identity, shuffle): Likewise.
9952 * editfns.c (Fformat): Likewise.
9953 * syntax.c (skip_chars): Likewise.
9954
9955 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9956 This also lets GCC 4.6.0 generate slightly better loop code.
9957
9958 * callint.c (Fcall_interactively): <, not <=, for optimization.
9959 (Fcall_interactively): Count the number of arguments produced,
9960 not the number of arguments given. This is simpler and lets GCC
9961 4.6.0 generate slightly better code.
9962
9963 * ftfont.c: Distingish more carefully between FcChar8 and char.
9964 The previous code passed unsigned char * to a functions like
9965 strlen and xstrcasecmp that expect char *, which does not
9966 conform to the C standard.
9967 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9968 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9969 char * when the C standard requires it.
9970
9971 * keyboard.c (read_char): Remove unused var.
9972
9973 * eval.c: Port to Windows vsnprintf (Bug#8435).
9974 Include <limits.h>.
9975 (SIZE_MAX): Define if the headers do not.
9976 (verror): Do not give up if vsnprintf returns a negative count.
9977 Instead, grow the buffer. This ports to Windows vsnprintf, which
9978 does not conform to C99. Problem reported by Eli Zaretskii.
9979 Also, simplify the allocation scheme, by avoiding the need for
9980 calling realloc, and removing the ALLOCATED variable.
9981
9982 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9983
9984 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9985 But keep the doprint source code for now, as we might revamp it
9986 and use it again (Bug#8435).
9987 * lisp.h (doprnt): Remove.
9988 * Makefile.in (base_obj): Remove doprnt.o.
9989 * deps.mk (doprnt.o): Remove.
9990
9991 error: Print 32- and 64-bit integers portably (Bug#8435).
9992 Without this change, on typical 64-bit hosts error ("...%d...", N)
9993 was used to print both 32- and 64-bit integers N, which relied on
9994 undefined behavior.
9995 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9996 * lisp.h (error, verror): Mark as printf-like functions.
9997 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9998 Report overflow in size calculations when allocating printf buffer.
9999 Do not truncate output string at its first null byte.
10000 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10001 Truncate the output at a character boundary, since vsnprintf does not
10002 do that.
10003 * charset.c (check_iso_charset_parameter): Convert internal
10004 character to string before calling 'error', since %c now has the
10005 printf meaning.
10006 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10007 overflow when computing char to be passed to 'error'. Do not
10008 pass Lisp_Object to 'error'; pass the integer instead.
10009 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10010 formatted with plain %d.
10011
10012 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10013
10014 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10015
10016 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10017
10018 * xterm.c (x_catch_errors): Remove duplicate declaration.
10019
10020 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10021
10022 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10023
10024 2011-04-10 Jim Meyering <meyering@redhat.com>
10025
10026 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10027 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10028 return ssize_t not "int", and use size_t as the buffer length.
10029 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10030 * gnutls.h: Update declarations.
10031 * process.c (read_process_output): Use ssize_t, to match.
10032 (send_process): Likewise.
10033
10034 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10035
10036 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10037
10038 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10039
10040 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10041 Use unsigned char, to match FcChar8 type definition.
10042
10043 * xterm.c (handle_one_xevent):
10044 * xmenu.c (create_and_show_popup_menu):
10045 * xselect.c (x_decline_selection_request)
10046 (x_reply_selection_request): Avoid type-punned deref of X events.
10047
10048 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10049
10050 Fix some uses of `int' instead of EMACS_INT.
10051 * search.c (string_match_1, fast_string_match)
10052 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10053 (scan_buffer, find_next_newline_no_quit)
10054 (find_before_next_newline, search_command, Freplace_match)
10055 (Fmatch_data): Make some `int' variables be EMACS_INT.
10056
10057 * xdisp.c (display_count_lines): 3rd argument and return value now
10058 EMACS_INT. All callers changed.
10059 (pint2hrstr): Last argument is now EMACS_INT.
10060
10061 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10062 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10063 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10064 (decode_coding_utf_16, decode_coding_emacs_mule)
10065 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10066 (decode_coding_ccl, decode_coding_charset)
10067 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10068 (decode_coding_iso_2022, decode_coding_emacs_mule)
10069 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10070 <char_offset, last_offset>: Declare EMACS_INT.
10071 (encode_coding_utf_8, encode_coding_utf_16)
10072 (encode_coding_emacs_mule, encode_invocation_designation)
10073 (encode_designation_at_bol, encode_coding_iso_2022)
10074 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10075 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10076 Declare EMACS_INT.
10077 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10078 (encode_invocation_designation): Last argument P_NCHARS is now
10079 EMACS_INT.
10080 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10081 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10082
10083 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10084 All users changed.
10085
10086 * ccl.c (Fccl_execute_on_string): Declare some variables
10087 EMACS_INT.
10088
10089 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10090
10091 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10092
10093 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10094
10095 * process.c (Fformat_network_address): Doc fix.
10096
10097 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10098
10099 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10100
10101 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10102
10103 * keyboard.c (read_char): Call Lisp function help-form-show,
10104 instead of using internal_with_output_to_temp_buffer.
10105 (Qhelp_form_show): New var.
10106 (syms_of_keyboard): Use DEFSYM macro.
10107
10108 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10109
10110 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10111
10112 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10113
10114 * process.c (Flist_processes): Remove to Lisp.
10115 (list_processes_1): Delete.
10116
10117 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10118
10119 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10120
10121 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10122
10123 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10124
10125 Fix more problems found by GCC 4.6.0's static checks.
10126
10127 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10128
10129 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10130
10131 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10132
10133 * xdisp.c (vmessage): Mark as a printf-like function.
10134
10135 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10136
10137 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10138
10139 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10140 printf-like functions.
10141 (tiff_load): Add casts to remove these marks before passing them
10142 to system-supplied API.
10143
10144 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10145
10146 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10147 This avoids several warnings with gcc -Wstrict-overflow.
10148 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10149 directly, rather than having caller test rule sign. This avoids
10150 some unnecessary tests.
10151 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10152 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10153 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10154
10155 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10156 (xfont_open): Avoid unnecessary tests.
10157
10158 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10159
10160 * composite.h, composite.c (composition_gstring_put_cache):
10161 Use EMACS_INT, not int, for length.
10162
10163 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10164 breaking out part of COMPOSITION_DECODE_RULE.
10165 (COMPOSITION_DECODE_RULE): Use it.
10166 * composite.c (get_composition_id): Remove unused local vars,
10167 by using the new macro.
10168
10169 * textprop.c (set_text_properties_1): Change while to do-while,
10170 since the condition is always true at first.
10171
10172 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10173 (interval_deletion_adjustment): Return unsigned value.
10174 All uses changed.
10175
10176 * process.c (list_processes_1, create_pty, read_process_output):
10177 (exec_sentinel): Remove vars that were set but not used.
10178 (create_pty): Remove unnecessary "volatile"s.
10179 (Fnetwork_interface_info): Avoid possibility of int overflow.
10180 (read_process_output): Do adaptive read buffering even if carryover.
10181 (read_process_output): Simplify nbytes computation if buffered.
10182
10183 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10184
10185 * syntax.c (scan_words): Remove var that was set but not used.
10186 (update_syntax_table): Use unsigned instead of int.
10187
10188 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10189 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10190 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10191
10192 * print.c (print_error_message): Avoid int overflow.
10193
10194 * font.c (font_list_entities): Redo for clarity,
10195 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10196
10197 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10198 (font_score): Avoid potential overflow in diff calculation.
10199
10200 * fns.c (substring_both): Remove var that is set but not used.
10201 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10202
10203 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10204
10205 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10206 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10207 can always succeed if overflow has undefined behavior.
10208
10209 * search.c (boyer_moore, wordify): Remove vars set but not used.
10210 (wordify): Omit three unnecessary tests.
10211
10212 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10213 All callers changed. This avoids the need for an unused var.
10214
10215 * casefiddle.c (casify_region): Remove var that is set but not used.
10216
10217 * dired.c (file_name_completion): Remove var that is set but not used.
10218
10219 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10220
10221 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10222 (Finsert_file_contents): Remove unnecessary code checking fd.
10223
10224 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10225 Check for integer overflow on size calculations.
10226
10227 * buffer.c (Fprevious_overlay_change): Remove var that is set
10228 but not used.
10229
10230 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10231 Remove vars that are set but not used.
10232 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10233 (timer_check_2): Mark vars as initialized.
10234
10235 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10236
10237 * image.c (lookup_image): Remove var that is set but not used.
10238 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10239
10240 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10241 that are set but not used.
10242
10243 * xfns.c (make_invisible_cursor): Don't return garbage
10244 if XCreateBitmapFromData fails (Bug#8410).
10245
10246 * xselect.c (x_get_local_selection, x_handle_property_notify):
10247 Remove vars that are set but not used.
10248
10249 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10250 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10251
10252 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10253 Remove var that is set but not used.
10254 (scroll_bar_windows_size): Now size_t, not int.
10255 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10256 Check for overflow.
10257
10258 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10259 (map_tty_color) [!defined MSDOS]: Likewise.
10260
10261 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10262
10263 * coding.c: Remove vars that are set but not used.
10264 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10265 All callers changed.
10266 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10267 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10268 (decode_coding_charset): Remove vars that are set but not used.
10269
10270 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10271 that is set but not used.
10272
10273 * print.c (print_object): Remove var that is set but not used.
10274
10275 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10276 The gnulib version avoids calling malloc in the usual case,
10277 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10278 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10279 * filelock.c (current_lock_owner): Likewise.
10280 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10281 * sysdep.c: Include allocator.h, careadlinkat.h.
10282 (emacs_no_realloc_allocator): New static constant.
10283 (emacs_readlink): New function.
10284 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10285 ../lib/careadlinkat.h.
10286
10287 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10288
10289 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10290 first non-nil return value).
10291
10292 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10293
10294 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10295 if not defined (Bug#8403).
10296
10297 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10298
10299 * xdisp.c (display_count_lines): Remove parameter `start',
10300 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10301 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10302 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10303 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10304 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10305 and thereabouts. All callers changed.
10306 (get_per_char_metric): Remove parameter `f', unused since
10307 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10308
10309 2011-04-02 Jim Meyering <meyering@redhat.com>
10310
10311 do not dereference NULL upon failed strdup
10312 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10313 (ns_get_family): Likewise.
10314
10315 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10316
10317 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10318
10319 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10320
10321 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10322 later (Bug#8403).
10323
10324 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10325
10326 Add lexical binding.
10327
10328 * window.c (Ftemp_output_buffer_show): New fun.
10329 (Fsave_window_excursion):
10330 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10331
10332 * lread.c (lisp_file_lexically_bound_p): New function.
10333 (Fload): Bind Qlexical_binding.
10334 (readevalloop): Remove `evalfun' arg.
10335 Bind Qinternal_interpreter_environment.
10336 (Feval_buffer): Bind Qlexical_binding.
10337 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10338 Mark as dynamic.
10339 (syms_of_lread): Declare `lexical-binding'.
10340
10341 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10342
10343 * keyboard.c (eval_dyn): New fun.
10344 (menu_item_eval_property): Use it.
10345
10346 * image.c (parse_image_spec): Use Ffunctionp.
10347
10348 * fns.c (concat, mapcar1): Accept byte-code-functions.
10349
10350 * eval.c (Fsetq): Handle lexical vars.
10351 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10352 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10353 (FletX, Flet): Obey lexical binding.
10354 (Fcommandp): Handle closures.
10355 (Feval): New `lexical' arg.
10356 (eval_sub): New function extracted from Feval. Use it almost
10357 everywhere where Feval was used. Look up vars in lexical env.
10358 Handle closures.
10359 (Ffunctionp): Move from subr.el.
10360 (Ffuncall): Handle closures.
10361 (apply_lambda): Remove `eval_flags'.
10362 (funcall_lambda): Handle closures and new byte-code-functions.
10363 (Fspecial_variable_p): New function.
10364 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10365 but without exporting it to Lisp.
10366
10367 * doc.c (Fdocumentation, store_function_docstring):
10368 * data.c (Finteractive_form): Handle closures.
10369
10370 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10371 interactive spec.
10372
10373 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10374 New byte-codes.
10375 (exec_byte_code): New function extracted from Fbyte_code to handle new
10376 calling convention for byte-code-functions. Add new byte-codes.
10377
10378 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10379
10380 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10381
10382 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10383
10384 * xdisp.c (redisplay_internal): Fix prototype.
10385
10386 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10387
10388 * xdisp.c (SCROLL_LIMIT): New macro.
10389 (try_scrolling): Use it when setting scroll_limit.
10390 Limit scrolling to 100 screen lines.
10391 (redisplay_window): Even when falling back on "recentering",
10392 position point in the window according to scroll-conservatively,
10393 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10394
10395 (try_scrolling): When point is above the window, allow searching
10396 as far as scroll_max, or one screenful, to compute vertical
10397 distance from PT to the scroll margin position. This prevents
10398 try_scrolling from unnecessarily failing when
10399 scroll-conservatively is set to a value slightly larger than the
10400 window height. Clean up the case of PT below the margin at bottom
10401 of window: scroll_max can no longer be INT_MAX. When aggressive
10402 scrolling is in use, don't let point enter the opposite scroll
10403 margin as result of the scroll.
10404 (syms_of_xdisp) <scroll-conservatively>: Document the
10405 threshold of 100 lines for never-recentering scrolling.
10406
10407 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10408
10409 * dispextern.h (move_it_by_lines):
10410 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10411 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10412 (message_log_check_duplicate): Remove parameters `prev_bol' and
10413 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10414 (redisplay_internal): Remove parameter `preserve_echo_area',
10415 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10416
10417 * indent.c (Fvertical_motion):
10418 * window.c (window_scroll_pixel_based, Frecenter):
10419 Don't pass `need_y_p' to `move_it_by_lines'.
10420
10421 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10422
10423 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10424 steal a few bits to be more compact.
10425 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10426 Remove unneeded casts.
10427
10428 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10429
10430 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10431
10432 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10433 binding" message (bug#7967).
10434
10435 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10436
10437 Fix more problems found by GCC 4.6.0's static checks.
10438
10439 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10440 Remove unused local var.
10441
10442 * editfns.c (Fmessage_box): Remove unused local var.
10443
10444 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10445 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10446 Omit unused local vars.
10447 * window.c (shrink_windows): Omit unused local var.
10448 * menu.c (digest_single_submenu): Omit unused local var.
10449 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10450 Omit unused local var.
10451
10452 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10453 Don't assume string length fits in int.
10454 (keyremap_step, read_key_sequence): Use size_t for sizes.
10455 (read_key_sequence): Don't check last_real_key_start redundantly.
10456
10457 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10458 instead of alloca (Bug#8344).
10459
10460 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10461 (Fbacktrace_frame): Don't assume nframes fits in int.
10462
10463 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10464
10465 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10466 concerns.
10467
10468 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10469
10470 * cm.c (calccost): Turn while-do into do-while, for clarity.
10471
10472 * keyboard.c (syms_of_keyboard): Use the same style as later
10473 in this function when indexing through an array. This also
10474 works around GCC bug 48267.
10475
10476 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10477
10478 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10479
10480 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10481 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10482
10483 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10484 This avoids undefined behavior on integer overflow, and is a bit
10485 more convenient anyway since it is compared to a size_t variable.
10486
10487 Variadic C functions now count arguments with size_t, not int.
10488 This avoids an unnecessary limitation on 64-bit machines, which
10489 caused (substring ...) to crash on large vectors (Bug#8344).
10490 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10491 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10492 All variadic functions and their callers changed accordingly.
10493 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10494 * data.c (arith_driver, float_arith_driver): Likewise.
10495 * editfns.c (general_insert_function): Likewise.
10496 * eval.c (struct backtrace.nargs, interactive_p)
10497 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10498 (funcall_lambda, mark_backtrace): Likewise.
10499 * fns.c (concat): Likewise.
10500 * frame.c (x_set_frame_parameters): Likewise.
10501 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10502 0 if not found, not -1. All callers changed.
10503
10504 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10505 (stack_copy_size): Now size_t, not int.
10506 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10507
10508 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10509
10510 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10511 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10512 All callers changed.
10513
10514 * lisp.h (multibyte_char_to_unibyte):
10515 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10516 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10517 * character.h (CHAR_TO_BYTE8):
10518 * cmds.c (internal_self_insert):
10519 * editfns.c (general_insert_function):
10520 * keymap.c (push_key_description):
10521 * search.c (Freplace_match):
10522 * xdisp.c (message_dolog, set_message_1): All callers changed.
10523
10524 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10525
10526 * keyboard.c (safe_run_hook_funcall): New function.
10527 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10528 don't set the hook to nil, but remove the offending function instead.
10529 (Qcommand_hook_internal): Remove, unused.
10530 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10531 Vcommand_hook_internal.
10532
10533 * eval.c (enum run_hooks_condition): Remove.
10534 (funcall_nil, funcall_not): New functions.
10535 (run_hook_with_args): Call each function through a `funcall' argument.
10536 Remove `cond' argument, now redundant.
10537 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10538 (Frun_hook_with_args_until_failure): Adjust accordingly.
10539 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10540
10541 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10542
10543 * dispextern.h (string_buffer_position): Remove declaration.
10544
10545 * print.c (strout): Remove parameter `multibyte', unused since
10546 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10547
10548 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10549 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10550 All callers changed.
10551
10552 * w32.c (_wsa_errlist): Use braces for struct initializers.
10553
10554 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10555 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10556 All callers changed.
10557 (string_buffer_position): Likewise. Also, make static (it's never
10558 used outside xdisp.c).
10559 (cursor_row_p): Remove parameter `w', unused since
10560 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10561 (decode_mode_spec): Remove parameter `precision', introduced during
10562 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10563 All callers changed.
10564
10565 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10566
10567 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10568
10569 2011-03-27 Anders Lindgren <andlind@gmail.com>
10570
10571 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10572 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10573 (ns_update_auto_hide_menu_bar): New functions.
10574 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10575 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10576 ns_constrain_all_frames.
10577 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10578 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10579
10580 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10581
10582 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10583
10584 2011-03-27 Glenn Morris <rgm@gnu.org>
10585
10586 * syssignal.h: Replace RETSIGTYPE with void.
10587 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10588 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10589 Replace SIGTYPE with void everywhere.
10590 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10591 * s/template.h (SIGTYPE): Remove commented out definition.
10592
10593 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10594
10595 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10596 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10597
10598 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10599
10600 * w32.c (read_unc_volume): Use parameter `henum', instead of
10601 global variable `wget_enum_handle'.
10602
10603 * keymap.c (describe_vector): Remove parameters `indices' and
10604 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10605 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10606
10607 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10608
10609 * keyboard.c (timer_check): Remove parameter `do_it_now',
10610 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10611 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10612 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10613
10614 * keyboard.c (read_char):
10615 * w32menu.c (w32_menu_display_help):
10616 * xmenu.c (show_help_event, menu_help_callback):
10617 Adjust calls to `show_help_echo'.
10618
10619 * gtkutil.c (xg_maybe_add_timer):
10620 * keyboard.c (readable_events):
10621 * process.c (wait_reading_process_output):
10622 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10623
10624 * insdel.c (adjust_markers_gap_motion):
10625 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10626 (gap_left, gap_right): Don't call it.
10627
10628 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10629
10630 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10631 incurred during fontification.
10632
10633 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10634
10635 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10636 (DEFVAR_PER_BUFFER): Don't pass it.
10637
10638 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10639 (scrolling_window): Don't pass it.
10640
10641 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10642
10643 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10644
10645 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10646 and `suffix'.
10647 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10648 of variables specific to SELinux and computation of `encoded_absname'.
10649
10650 * image.c (XPutPixel): Remove unused variable `height'.
10651
10652 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10653
10654 * unexw32.c (get_section_info): Remove unused variable `section'.
10655
10656 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10657 (system_process_attributes): Remove unused variable `sess'.
10658 (sys_read): Remove unused variable `err'.
10659
10660 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10661 (w32_wnd_proc): Remove unused variable `isdead'.
10662 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10663 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10664 (x_create_tip_frame): Remove unused variable `tem'.
10665
10666 * w32inevt.c (w32_console_read_socket):
10667 Remove unused variable `no_events'.
10668
10669 * w32term.c (x_draw_composite_glyph_string_foreground):
10670 Remove unused variable `width'.
10671
10672 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10673
10674 * w32term.c (x_set_glyph_string_clipping):
10675 Don't pass uninitialized region to CombineRgn.
10676
10677 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10678
10679 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10680 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10681 (Fx_close_connection): Remove unused variable `i'.
10682
10683 * w32font.c (w32font_draw): Return number of glyphs.
10684 (w32font_open_internal): Remove unused variable `i'.
10685 (w32font_driver): Add missing initializer.
10686
10687 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10688 (fill_in_menu): Remove unused variable `items_added'.
10689
10690 * w32term.c (last_mouse_press_frame): Remove static global variable.
10691 (w32_clip_to_row): Remove unused variable `f'.
10692 (x_delete_terminal): Remove unused variable `i'.
10693
10694 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10695 (NOTHING): Remove unused static global variable.
10696 (uniscribe_check_otf): Remove unused variable `table'.
10697 (uniscribe_font_driver): Add missing initializers.
10698
10699 2011-03-23 Julien Danjou <julien@danjou.info>
10700
10701 * term.c (Fsuspend_tty, Fresume_tty):
10702 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10703 * window.c (temp_output_buffer_show):
10704 * insdel.c (signal_before_change):
10705 * frame.c (Fhandle_switch_frame):
10706 * fileio.c (Fdo_auto_save):
10707 * emacs.c (Fkill_emacs):
10708 * editfns.c (save_excursion_restore):
10709 * cmds.c (internal_self_insert):
10710 * callint.c (Fcall_interactively):
10711 * buffer.c (Fkill_all_local_variables):
10712 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10713 Use Frun_hooks.
10714 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10715 unconditionally since it does the check itself.
10716
10717 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10718
10719 Fix more problems found by GCC 4.5.2's static checks.
10720
10721 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10722 the first time through the loop, since we know p0 < p1 then.
10723 This also avoids a gcc -Wstrict-overflow warning.
10724
10725 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10726 leading to a memory leak, possible in functions like
10727 load_charset_map_from_file that can allocate an unbounded number
10728 of objects (Bug#8318).
10729
10730 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10731 that could (at least in theory) be that large.
10732
10733 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10734 This is less likely to overflow, and avoids undefined behavior if
10735 overflow does occur. All callers changed. Use strtoul to scan
10736 for the unsigned long integer.
10737 (pint2hrstr): Simplify and tune code slightly.
10738 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10739
10740 * scroll.c (do_scrolling): Work around GCC bug 48228.
10741 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10742
10743 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10744 This also avoids a warning with gcc -Wstrict-overflow.
10745 (validate_x_resource_name): Simplify count usage.
10746 This also avoids a warning with gcc -Wstrict-overflow.
10747
10748 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10749 fail (Bug#8306).
10750
10751 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10752
10753 * process.c (Fmake_network_process): Use socklen_t, not int,
10754 where POSIX says socklen_t is required in portable programs.
10755 This fixes a porting bug on hosts like 64-bit HP-UX, where
10756 socklen_t is wider than int (Bug#8277).
10757 (Fmake_network_process, server_accept_connection):
10758 (wait_reading_process_output, read_process_output):
10759 Likewise.
10760
10761 * process.c: Rename or move locals to avoid shadowing.
10762 (list_processes_1, Fmake_network_process):
10763 (read_process_output_error_handler, exec_sentinel_error_handler):
10764 Rename or move locals.
10765 (Fmake_network_process): Define label "retry_connect" only if needed.
10766 (Fnetwork_interface_info): Fix pointer signedness.
10767 (process_send_signal): Add cast to avoid pointer signedness problem.
10768 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10769 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10770
10771 Make tparam.h and terminfo.c consistent.
10772 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10773 Include tparam.h instead, since it declares them.
10774 * cm.h (PC): Remove extern decl; tparam.h now does this.
10775 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10776 * terminfo.c: Include tparam.h, to check interfaces.
10777 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10778 (tparam): Adjust signature to match interface in tparam.h;
10779 this removes some undefined behavior. Check that outstring and len
10780 are zero, which they always are with Emacs.
10781 * tparam.h (PC, BC, UP): New extern decls.
10782
10783 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10784 (xftfont_open): Rename locals to avoid shadowing.
10785
10786 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10787 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10788 (OTF_TAG_SYM): Omit macro if not needed.
10789 (ftfont_list): Remove unused local.
10790 (get_adstyle_property, ftfont_pattern_entity):
10791 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10792 Rename locals to avoid shadowing.
10793
10794 * xfont.c (xfont_list_family): Mark var as initialized.
10795
10796 * xml.c (make_dom): Now static.
10797
10798 * composite.c (composition_compute_stop_pos): Rename local to
10799 avoid shadowing.
10800 (composition_reseat_it): Remove unused locals.
10801 (find_automatic_composition, composition_adjust_point): Likewise.
10802 (composition_update_it): Mark var as initialized.
10803 (find_automatic_composition): Mark vars as initialized,
10804 with a FIXME (Bug#8290).
10805
10806 character.h: Rename locals to avoid shadowing.
10807 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10808 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10809 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10810 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10811 to avoid shadowing.
10812
10813 * textprop.c (property_change_between_p): Remove; unused.
10814
10815 * intervals.c (interval_start_pos): Now static.
10816
10817 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10818
10819 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10820 Rename locals to avoid shadowing.
10821
10822 * sound.c (wav_play, au_play, Fplay_sound_internal):
10823 Fix pointer signedness.
10824 (alsa_choose_format): Remove unused local var.
10825 (wav_play): Initialize a variable to 0, to prevent undefined
10826 behavior (Bug#8278).
10827
10828 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10829
10830 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10831
10832 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10833 clobbering (Bug#8298).
10834 * sysdep.c (sys_subshell): Likewise.
10835 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10836
10837 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10838 This should get cleaned up, so that child_setup has the
10839 same signature on all platforms.
10840
10841 * callproc.c (call_process_cleanup): Now static.
10842 (relocate_fd): Rename locals to avoid shadowing.
10843
10844 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10845
10846 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10847 not to be necessary, and produces flickering.
10848
10849 2011-03-20 Glenn Morris <rgm@gnu.org>
10850
10851 * config.in: Remove file.
10852
10853 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10854
10855 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10856 are now in src/globals.h.
10857 (syms_of_minibuf): Remove spurious & from previous change.
10858
10859 2011-03-20 Leo Liu <sdl.web@gmail.com>
10860
10861 * minibuf.c (completing-read-function): New variable.
10862 (completing-read-default): Rename from completing-read.
10863 (completing-read): Call completing-read-function.
10864
10865 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10866
10867 * xfaces.c (Fx_load_color_file):
10868 Read color file from absolute filename (bug#8250).
10869
10870 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10871
10872 * makefile.w32-in: Update dependencies.
10873
10874 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10875
10876 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10877
10878 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10879
10880 Fix more problems found by GCC 4.5.2's static checks.
10881
10882 * process.c (make_serial_process_unwind, send_process_trap):
10883 (sigchld_handler): Now static.
10884
10885 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10886 That way, the code declares only the vars that it needs.
10887 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10888 * s/cygwin.h (PTY_ITERATION): Likewise.
10889 * s/darwin.h (PTY_ITERATION): Likewise.
10890 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10891
10892 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10893 * process.c (allocate_pty): Don't declare stb unless it's needed.
10894
10895 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10896 (CONSTANTLIM): Remove; unused.
10897 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10898 Define only if needed.
10899
10900 * unexelf.c (unexec): Name an expression,
10901 to avoid gcc -Wbad-function-cast warning.
10902 Use a different way to cause a compilation error if anyone uses
10903 n rather than nn, a way that does not involve shadowing.
10904 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10905
10906 * deps.mk (unexalpha.o): Remove; unused.
10907
10908 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10909 * unexec.h: New file.
10910 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10911 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10912 Depend on unexec.h.
10913 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10914 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10915 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10916 Change as necessary to match prototype in unexec.h.
10917
10918 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10919 shadowing.
10920 (back_comment, skip_chars): Mark vars as initialized.
10921
10922 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10923 Rename locals to avoid shadowing.
10924
10925 * lread.c (read1): Rewrite so as not to use empty "else".
10926 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10927
10928 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10929
10930 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10931 warning when compiling print.c.
10932
10933 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10934 instead of using an uninitialized var.
10935 (font_sort_entities): Mark var as initialized.
10936
10937 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10938
10939 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10940 pointers to constants.
10941 (font_parse_fcname): Remove unused vars.
10942 (font_delete_unmatched): Now static.
10943 (font_get_spec): Remove; unused.
10944 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10945 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10946 Rename or move locals to avoid shadowing.
10947
10948 * fns.c (require_nesting_list, require_unwind): Now static.
10949 (Ffillarray): Rename locals to avoid shadowing.
10950
10951 * floatfns.c (domain_error2): Define only if needed.
10952 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10953
10954 * alloc.c (mark_backtrace): Move decl from here ...
10955 * lisp.h: ... to here, so that it can be checked.
10956
10957 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10958 (Fdefvar): Rewrite so as not to use empty "else".
10959 (lisp_indirect_variable): Name an expression,
10960 to avoid gcc -Wbad-function-cast warning.
10961 (Fdefvar): Rename locals to avoid shadowing.
10962
10963 * callint.c (quotify_arg, quotify_args): Now static.
10964 (Fcall_interactively): Rename locals to avoid shadowing.
10965 Use const pointer when appropriate.
10966
10967 * lisp.h (get_system_name, get_operating_system_release):
10968 Move decls here, to check interfaces.
10969 * process.c (get_operating_system_release): Move decl to lisp.h.
10970 * xrdb.c (get_system_name): Likewise.
10971 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10972 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10973 some of which prompt warnings from gcc -Wbad-function-cast.
10974 (Fformat_time_string, Fencode_time, Finsert_char):
10975 (Ftranslate_region_internal, Fformat):
10976 Rename or remove local vars to avoid shadowing.
10977 (Ftranslate_region_internal): Mark var as initialized.
10978
10979 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10980 avoid shadowing.
10981
10982 * lisp.h (eassert): Check that the argument compiles, even if
10983 ENABLE_CHECKING is not defined.
10984
10985 * data.c (Findirect_variable): Name an expression, to avoid
10986 gcc -Wbad-function-cast warning.
10987 (default_value, arithcompare, arith_driver, arith_error): Now static.
10988 (store_symval_forwarding): Rename local to avoid shadowing.
10989 (Fmake_variable_buffer_local, Fmake_local_variable):
10990 Mark variables as initialized.
10991 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10992
10993 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10994 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10995 Rename locals to avoid shadowing.
10996 (mark_stack): Move local variables into the #ifdef region where
10997 they're used.
10998 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10999 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11000 needed otherwise.
11001 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11002 (GC_STRING_CHARS): Remove; not used.
11003 (Fmemory_limit): Cast sbrk's returned value to char *.
11004
11005 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11006 avoids undefined behavior in theory.
11007
11008 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11009
11010 Use functions, not macros, for up- and down-casing (Bug#8254).
11011 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11012 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11013 to use the following functions instead of these macros.
11014 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11015 EMACS_INT, since callers assume the returned value fits in int.
11016 (upcase1): Likewise, for UPCASE_TABLE.
11017 (uppercasep, lowercasep, upcase): New static inline functions.
11018 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11019 the race-condition problem in the old DOWNCASE.
11020
11021 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11022 Rename locals to avoid shadowing.
11023 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11024 (regex_compile, re_search_2, re_match_2_internal):
11025 Remove unused local vars.
11026 (FREE_VAR): Rewrite so as not to use empty "else",
11027 which gcc can warn about.
11028 (regex_compile, re_match_2_internal): Mark locals as initialized.
11029 (RETALLOC_IF): Define only if needed.
11030 (WORDCHAR_P): Likewise. This one is never needed, but is used
11031 only in a comment talking about a compiler bug, so put inside
11032 the #if 0 of that comment.
11033 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11034 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11035 Remove; unused.
11036
11037 * search.c (boyer_moore): Rename locals to avoid shadowing.
11038 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11039 (PREV_CHAR_BOUNDARY): Likewise.
11040
11041 * search.c (simple_search): Remove unused var.
11042
11043 * dired.c (compile_pattern): Move decl from here ...
11044 * lisp.h: ... to here, so that it can be checked.
11045 (struct re_registers): New forward decl.
11046
11047 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11048
11049 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11050 All uses changed.
11051 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11052 Rename locals to avoid shadowing.
11053 (Fvertical_motion): Mark locals as initialized.
11054
11055 * casefiddle.c (casify_object, casify_region): Now static.
11056 (casify_region): Mark local as initialized.
11057
11058 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11059
11060 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11061 New macros, so that the caller can use some names other than
11062 gcpro1, gcpro2, etc.
11063 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11064 of the new macros.
11065 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11066 argument, for consistency with GCPRO2_VAR, etc: it is now the
11067 prefix of the variable, not the variable itself. All uses
11068 changed.
11069 * dired.c (directory_files_internal, file_name_completion):
11070 Rename locals to avoid shadowing.
11071
11072 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11073 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11074 dired.c's scmp function, had undefined behavior.
11075 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11076 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11077 * buffer.h: ... to here, because these macros use current_buffer,
11078 and the new implementation with inline functions needs to have
11079 current_buffer in scope now, rather than later when the macros
11080 are used.
11081 (downcase, upcase1): New static inline functions.
11082 (DOWNCASE, UPCASE1): Reimplement using these functions.
11083 This avoids undefined behavior in expressions like
11084 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11085 from race conditions in accessing the global variables
11086 case_temp1 and case_temp2.
11087 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11088 * lisp.h (case_temp1, case_temp2): Remove their decls.
11089 * character.h (ASCII_CHAR_P): Move from here ...
11090 * lisp.h: ... to here, so that the inline functions mentioned
11091 above can use them.
11092
11093 * dired.c (directory_files_internal_unwind): Now static.
11094
11095 * fileio.c (file_name_as_directory, directory_file_name):
11096 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11097 Now static.
11098 (file_name_as_directory): Use const pointers when appropriate.
11099 (Fexpand_file_name): Likewise. In particular, newdir might
11100 point at constant storage, so make it a const pointer.
11101 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11102 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11103 signedness issues.
11104 (Fset_file_times, Finsert_file_contents, auto_save_error):
11105 Rename locals to avoid shadowing.
11106
11107 * minibuf.c (choose_minibuf_frame_1): Now static.
11108 (Ftry_completion, Fall_completions): Rename or remove locals
11109 to avoid shadowing.
11110
11111 * marker.c (bytepos_to_charpos): Remove; unused.
11112
11113 * lisp.h (verify_bytepos, count_markers): New decls,
11114 so that gcc does not warn that these functions aren't declared.
11115
11116 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11117 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11118 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11119 (copy_text): Remove unused local var.
11120
11121 * filelock.c (within_one_second): Now static.
11122 (lock_file_1): Rename local to avoid shadowing.
11123
11124 * buffer.c (fix_overlays_before): Mark locals as initialized.
11125 (fix_start_end_in_overlays): Likewise. This function should be
11126 simplified by using pointers-to-pointers, but that's a different
11127 matter.
11128 (switch_to_buffer_1): Now static.
11129 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11130 (report_overlay_modification): Rename locals to avoid shadowing.
11131
11132 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11133 Fix pointer signedness issue.
11134 (sys_subshell): Mark local as volatile if checking for lint,
11135 to suppress a gcc -Wclobbered warning that does not seem to be right.
11136 (MAXPATHLEN): Define only if needed.
11137
11138 * process.c (serial_open, serial_configure): Move decls from here ...
11139 * systty.h: ... to here, so that they can be checked.
11140
11141 * fns.c (get_random, seed_random): Move extern decls from here ...
11142 * lisp.h: ... to here, so that they can be checked.
11143
11144 * sysdep.c (reset_io): Now static.
11145 (wait_for_termination_signal): Remove; unused.
11146
11147 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11148 (copy_keymap_item, append_key, push_text_char_description):
11149 Now static.
11150 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11151 (DENSE_TABLE_SIZE): Remove; unused.
11152 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11153 (describe_map_tree):
11154 Rename locals to avoid shadowing.
11155
11156 * keyboard.c: Declare functions static if they are not used elsewhere.
11157 (echo_char, echo_dash, cmd_error, top_level_2):
11158 (poll_for_input, handle_async_input): Now static.
11159 (read_char, kbd_buffer_get_event, make_lispy_position):
11160 (make_lispy_event, make_lispy_movement, apply_modifiers):
11161 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11162 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11163 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11164 (read_key_sequence, read_char): Mark locals as initialized.
11165 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11166
11167 * keyboard.h (make_ctrl_char): New decl.
11168 (mark_kboards): Move decl here ...
11169 * alloc.c (mark_kboards): ... from here.
11170
11171 * lisp.h (force_auto_save_soon): New decl.
11172
11173 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11174 (DEFINE_DUMMY_FUNCTION): New macro.
11175 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11176 Use it.
11177 (main): Add casts to avoid warnings
11178 if GCC considers string literals to be constants.
11179
11180 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11181
11182 * dbusbind.c: Pointer signedness fixes.
11183 (xd_signature, xd_append_arg, xd_initialize):
11184 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11185 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11186 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11187 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11188
11189 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11190 if GCC considers string literals to be constants.
11191 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11192
11193 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11194
11195 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11196 (print_preprocess, print_object): New macro to fix last change.
11197
11198 * print.c (print_preprocess): Don't forget font objects.
11199
11200 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11201
11202 * emacs.c (USAGE3): Doc fixes.
11203
11204 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11205
11206 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11207 structure.
11208
11209 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11210
11211 * lisp.h (VWindow_system, Qfile_name_history):
11212 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11213 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11214 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11215
11216 * w32select.c: Don't #include "keyboard.h".
11217 (run_protected): Add extern declaration for waiting_for_input.
11218
11219 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11220 * w32console.c (detect_input_pending, read_input_pending)
11221 (encode_terminal_code):
11222 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11223 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11224 (w32_system_caret_y, Qfile_name_history):
11225 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11226 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11227 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11228 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11229 * w32proc.c (Qlocal, report_file_error):
11230 * w32term.c (Vwindow_system, updating_frame):
11231 * w32uniscribe.c (initialized, uniscribe_font_driver):
11232 Remove unneeded extern declarations.
11233
11234 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11235
11236 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11237
11238 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11239
11240 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11241 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11242 These macros can no longer be used for assignment.
11243
11244 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11245 Assign struct members directly, instead of using BUF_BEGV etc.
11246 (record_buffer_markers, fetch_buffer_markers): New functions for
11247 recording and fetching special buffer markers.
11248 (set_buffer_internal_1, set_buffer_temp): Use them.
11249
11250 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11251
11252 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11253
11254 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11255 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11256
11257 * xdisp.c (hscroll_window_tree):
11258 (reconsider_clip_changes): Use PT instead of BUF_PT.
11259
11260 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11261
11262 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11263 $(EMACS_ROOT)/lib/intprops.h.
11264
11265 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11266
11267 Fix more problems found by GCC 4.5.2's static checks.
11268
11269 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11270 to unsigned char * to avoid compiler diagnostic.
11271 (xg_free_frame_widgets): Make it clear that a local variable is
11272 needed only if USE_GTK_TOOLTIP.
11273 (gdk_window_get_screen): Make it clear that this macro is needed
11274 only if USE_GTK_TOOLTIP.
11275 (int_gtk_range_get_value): New function, which avoids a diagnostic
11276 from gcc -Wbad-function-cast.
11277 (xg_set_toolkit_scroll_bar_thumb): Use it.
11278 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11279 diagnostic from gcc -Wbad-function-cast.
11280 (get_utf8_string, xg_get_file_with_chooser):
11281 Rename locals to avoid shadowing.
11282 (create_dialog): Move locals to avoid shadowing.
11283
11284 * xgselect.c (xg_select): Remove unused var.
11285
11286 * image.c (four_corners_best): Mark locals as initialized.
11287 (gif_load): Initialize transparent_p to zero (Bug#8238).
11288 Mark another local as initialized.
11289 (my_png_error, my_error_exit): Mark with NO_RETURN.
11290
11291 * image.c (clear_image_cache): Now static.
11292 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11293 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11294 (x_edge_detection): Remove unnecessary cast that
11295 gcc -Wbad-function-cast diagnoses.
11296 (gif_load): Fix pointer signedness.
11297 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11298 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11299
11300 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11301
11302 Improve quality of tests for time stamp overflow.
11303 For example, without this patch (encode-time 0 0 0 1 1
11304 1152921504606846976) returns the obviously-bogus value (-948597
11305 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11306 reports time overflow. See
11307 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11308 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11309 * editfns.c: Include limits.h and intprops.h.
11310 (TIME_T_MIN, TIME_T_MAX): New macros.
11311 (time_overflow): Move earlier, to before first use.
11312 (hi_time, lo_time): New functions, for an accurate test for
11313 out-of-range times.
11314 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11315 (Fget_internal_run_time): Don't assume time_t fits in int.
11316 (make_time): Use list2 instead of Fcons twice.
11317 (Fdecode_time): More accurate test for out-of-range times.
11318 (check_tm_member): New function.
11319 (Fencode_time): Use it, to test for out-of-range times.
11320 (lisp_time_argument): Don't rely on undefined left-shift and
11321 right-shift behavior when checking for time stamp overflow.
11322
11323 * editfns.c (time_overflow): New function, refactoring common code.
11324 (Fformat_time_string, Fdecode_time, Fencode_time):
11325 (Fcurrent_time_string): Use it.
11326
11327 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11328 * dired.c (make_time): Move to ...
11329 * editfns.c (make_time): ... here.
11330 * systime.h: Note the move.
11331
11332 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11333
11334 * fringe.c (update_window_fringes): Remove unused variables.
11335
11336 * unexmacosx.c (copy_data_segment): Also copy __got section.
11337 (Bug#8223)
11338
11339 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11340
11341 * termcap.c [MSDOS]: Include "msdos.h".
11342 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11343 Constify `char *' arguments and their references according to
11344 prototypes in tparam.h.
11345
11346 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11347
11348 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11349 Adapt all references accordingly.
11350
11351 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11352
11353 2011-03-11 Tom Tromey <tromey@redhat.com>
11354
11355 * buffer.c (syms_of_buffer): Remove obsolete comment.
11356
11357 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11358
11359 * termhooks.h (encode_terminal_code): Declare prototype.
11360
11361 * msdos.c (encode_terminal_code): Don't declare prototype.
11362
11363 * term.c (encode_terminal_code): Now external again, used by
11364 w32console.c and msdos.c.
11365
11366 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11367 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11368
11369 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11370
11371 Fix some minor problems found by GCC 4.5.2's static checks.
11372
11373 * fringe.c (update_window_fringes): Mark locals as initialized
11374 (Bug#8227).
11375 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11376
11377 * alloc.c (mark_fringe_data): Move decl from here ...
11378 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11379 to check its interface.
11380 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11381
11382 * fontset.c (free_realized_fontset): Now static.
11383 (Fset_fontset_font): Rename local to avoid shadowing.
11384 (fontset_font): Mark local as initialized.
11385 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11386
11387 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11388
11389 * xselect.c (x_disown_buffer_selections): Remove; not used.
11390 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11391 (x_own_selection, Fx_disown_selection_internal): Rename locals
11392 to avoid shadowing.
11393 (x_handle_dnd_message): Remove local to avoid shadowing.
11394
11395 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11396 so that the caller can use some name other than gcpro1.
11397 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11398 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11399 (Fx_backspace_delete_keys_p):
11400 Use them to avoid shadowing, and rename vars to avoid shadowing.
11401 (x_decode_color, x_set_name, x_window): Now static.
11402 (Fx_create_frame): Add braces to silence GCC warning.
11403 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11404 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11405 Remove unused locals.
11406 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11407 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11408 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11409 macros.
11410
11411 * xterm.h (x_mouse_leave): New decl.
11412
11413 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11414 Remove unused functions.
11415 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11416 (x_calc_absolute_position): Now static.
11417 (XTread_socket): Don't define label "out" unless it's used.
11418 Don't declare local "event" unless it's used.
11419 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11420 unless they are used.
11421 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11422 (x_fatal_error_signal): Remove; not used.
11423 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11424 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11425 (x_error_catcher, x_connection_closed, x_error_handler):
11426 (x_error_quitter, xembed_send_message, x_iconify_frame):
11427 (my_log_handler): Rename locals to avoid shadowing.
11428 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11429 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11430
11431 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11432 Rename or move locals to avoid shadowing.
11433 (tty_defined_color, merge_face_heights): Now static.
11434 (free_realized_faces_for_fontset): Remove; not used.
11435 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11436 does not deduce is never used uninitialized.
11437 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11438 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11439
11440 * terminal.c (store_terminal_param): Now static.
11441
11442 * xmenu.c (menu_highlight_callback): Now static.
11443 (set_frame_menubar): Remove unused local.
11444 (xmenu_show): Rename parameter to avoid shadowing.
11445 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11446 since they might point to immutable storage.
11447 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11448 since it's unused otherwise.
11449
11450 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11451 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11452 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11453 avoids a gcc -Wuninitialized diagnostic.
11454 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11455 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11456 does not deduce are never used uninitialized.
11457
11458 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11459
11460 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11461 * window.c (window_loop, size_window):
11462 (run_window_configuration_change_hook, enlarge_window): Likewise.
11463
11464 * window.c (display_buffer): Now static.
11465 (size_window): Mark variables that gcc -Wuninitialized
11466 does not deduce are never used uninitialized.
11467 * window.h (check_all_windows): New decl, to forestall
11468 gcc -Wmissing-prototypes diagnostic.
11469 * dispextern.h (bidi_dump_cached_states): Likewise.
11470
11471 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11472 shadowing.
11473 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11474 Include <limits.h>.
11475 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11476 and to avoid gcc -Wuninitialized warning.
11477 (load_charset_map): Mark variables that gcc -Wuninitialized
11478 does not deduce are never used uninitialized.
11479 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11480
11481 * coding.c (coding_set_source, coding_set_destination):
11482 Use "else { /* comment */ }" rather than "else /* comment */;"
11483 for clarity, and to avoid gcc -Wempty-body warning.
11484 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11485 a block, when the outer 'i' will do.
11486 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11487 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11488 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11489 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11490 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11491 Rename locals to avoid shadowing.
11492 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11493 * coding.c (emacs_mule_char, encode_invocation_designation):
11494 Now static, since they're not used elsewhere.
11495 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11496 (decode_coding_object, encode_coding_object, detect_coding_system):
11497 (decode_coding_emacs_mule): Mark variables that gcc
11498 -Wuninitialized does not deduce are never used uninitialized.
11499 (detect_coding_iso_2022): Initialize a local variable that might
11500 be used uninitialized. Leave a FIXME because it's not clear that
11501 this initialization is needed. (Bug#8211)
11502 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11503 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11504 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11505 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11506 Remove unused macros.
11507
11508 * category.c (hash_get_category_set): Remove unused local var.
11509 (copy_category_table): Now static, since it's not used elsewhere.
11510 * character.c (string_count_byte8): Likewise.
11511
11512 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11513 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11514
11515 * chartab.c (copy_sub_char_table): Now static, since it's not used
11516 elsewhere.
11517 (sub_char_table_ref_and_range, char_table_ref_and_range):
11518 Rename locals to avoid shadowing.
11519 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11520
11521 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11522 (BIDI_BOB): Remove unused macro.
11523
11524 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11525 deduce are never used uninitialized.
11526 * term.c (encode_terminal_code): Likewise.
11527
11528 * term.c (encode_terminal_code): Now static. Remove unused local.
11529
11530 * tparam.h: New file.
11531 * term.c, tparam.h: Include it.
11532 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11533 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11534 Move these decls to tparam.h, and make them agree with what
11535 is actually in tparam.c. The previous trick of using incompatible
11536 decls in different modules does not conform to the C standard.
11537 All callers of tparam changed to use tparam's actual API.
11538 * tparam.c (tparam1, tparam, tgoto):
11539 Use const pointers where appropriate.
11540
11541 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11542 * cm.h (struct cm): Likewise.
11543 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11544 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11545 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11546 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11547 (turn_on_face, init_tty): Likewise.
11548 * termchar.h (struct tty_display_info): Likewise.
11549
11550 * term.c (term_mouse_position): Rename local to avoid shadowing.
11551
11552 * alloc.c (mark_ttys): Move decl from here ...
11553 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11554
11555 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11556
11557 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11558
11559 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11560
11561 * search.c (compile_pattern_1): Remove argument regp, unused since
11562 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11563 (compile_pattern): Don't pass it.
11564
11565 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11566
11567 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11568 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11569 for ! HAVE_GTK3.
11570 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11571
11572 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11573
11574 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11575 gdk_window_get_screen, gdk_window_get_geometry,
11576 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11577 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11578 (xg_get_pixbuf_from_pixmap): New function.
11579 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11580 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11581 Call xg_get_pixbuf_from_pixmap instead of
11582 gdk_pixbuf_get_from_drawable.
11583 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11584 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11585 (xg_check_special_colors): Use GtkStyleContext and its functions
11586 for HAVE_GTK3.
11587 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11588 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11589 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11590 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11591 Call gtk_widget_get_preferred_size.
11592 (xg_frame_resized): gdk_window_get_geometry only takes 5
11593 parameters.
11594 (xg_win_to_widget, xg_event_is_for_menubar):
11595 Call gdk_x11_window_lookup_for_display.
11596 (xg_set_widget_bg): New function.
11597 (delete_cb): New function.
11598 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11599 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11600 (xg_set_background_color): Call xg_set_widget_bg.
11601 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11602 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11603 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11604 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11605 if ! HAVE_GTK3.
11606 (update_frame_tool_bar): Call gtk_widget_hide.
11607 (xg_initialize): Use GDK_KEY_g.
11608
11609 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11610 if ! HAVE_GTK3
11611 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11612
11613 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11614 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11615 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11616
11617 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11618
11619 * w32xfns.c (select_palette): Check success of RealizePalette against
11620 GDI_ERROR, not zero.
11621
11622 See ChangeLog.11 for earlier changes.
11623
11624 ;; Local Variables:
11625 ;; coding: utf-8
11626 ;; End:
11627
11628 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11629
11630 This file is part of GNU Emacs.
11631
11632 GNU Emacs is free software: you can redistribute it and/or modify
11633 it under the terms of the GNU General Public License as published by
11634 the Free Software Foundation, either version 3 of the License, or
11635 (at your option) any later version.
11636
11637 GNU Emacs is distributed in the hope that it will be useful,
11638 but WITHOUT ANY WARRANTY; without even the implied warranty of
11639 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11640 GNU General Public License for more details.
11641
11642 You should have received a copy of the GNU General Public License
11643 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.