1 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3 * term.c (delete_tty): Remove redundant call to memset.
5 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
7 * alloc.c: Remove build_string.
8 * lisp.h: Define build_string as static inline. This provides
9 a better opportunity to optimize away calls to strlen when the
10 function is called with compile-time constant argument.
11 * image.c (imagemagick_error): Convert to build_string.
12 * w32proc.c (sys_spawnve): Likewise.
13 * xterm.c (x_term_init): Likewise.
15 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
17 Use sprintf return value instead of invoking strlen on result.
18 In the old days this wasn't portable, since some sprintf
19 implementations returned char *. But they died out years ago and
20 Emacs already assumes sprintf returns int.
21 Similarly for float_to_string.
22 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
24 * character.c (string_escape_byte8):
25 * data.c (Fnumber_to_string):
27 * print.c (print_object):
28 * xdisp.c (message_dolog):
29 * xfns.c (syms_of_xfns):
30 Use sprintf or float_to_string result to avoid need to call strlen.
31 * data.c (Fnumber_to_string):
32 Use make_unibyte_string, since the string must be ASCII.
33 * lisp.h, print.c (float_to_string): Now returns int length.
34 * term.c (produce_glyphless_glyph):
35 Use sprintf result rather than recomputing it.
37 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
38 * Makefile.in (ALL_CFLAGS):
39 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
40 * gmalloc.c, regex.c: Include <config.h> unconditionally.
42 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
44 * dispextern.h (xstrcasecmp): Define to library function
45 strcasecmp if available.
46 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
48 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
50 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
52 * menu.c (push_submenu_start, push_submenu_end)
53 (push_left_right_boundary, push_menu_pane): Likewise.
54 * msdos.c (dos_rawgetc): Likewise.
56 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
58 * xfns.c (xic_create_fontsetname): Remove redundant calls
61 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
63 * gtkutil.c (get_utf8_string): Remove redundant assignment.
64 sprintf already null-terminates its output.
66 * xfns.c (x_window): Remove redundant cast.
68 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
70 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
71 `const char *' to `char *' to avoid compiler warning.
73 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
75 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
76 instead of truncating it to 63 (admittedly a generous limit).
78 * process.c: Fix spelling and caps in comments.
80 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
82 * emacs.c (setpgrp): Remove definition, unused.
83 * sysdep.c (setpgrp): Remove definition, not used in this file.
85 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
87 * makefile.w32-in: Update dependencies.
89 2012-06-24 Eli Zaretskii <eliz@gnu.org>
91 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
92 (SYSTIME_H): Add nt/inc/sys/time.h.
94 * systime.h [WINDOWSNT]: Include sys/time.h.
96 * s/ms-w32.h (struct timespec): Definition moved from
97 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
99 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
101 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
102 * buffer.h (buffer_slot_type_mismatch):
103 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
104 * eval.c (unwind_to_catch):
105 * image.c (my_png_error, my_error_exit):
106 * keyboard.c (quit_throw_to_read_char, user_error)
107 (Fexit_recursive_edit, Fabort_recursive_edit):
108 * lisp.h (die, args_out_of_range, args_out_of_range_3)
109 (wrong_type_argument, buffer_overflow, __executable_start)
110 (memory_full, buffer_memory_full, string_overflow, Fthrow)
111 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
112 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
114 (child_setup) [!DOS_NT]:
115 * lread.c (end_of_file_error, invalid_syntax):
116 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
117 * puresize.h (pure_write_error):
118 * search.c (matcher_overflow):
119 * sound.c (sound_perror, alsa_sound_perror):
120 * sysdep.c, syssignal.h (croak):
121 * term.c (maybe_fatal, vfatal):
122 * textprop.c (text_read_only):
123 * undo.c (user_error):
124 * unexmacosx.c (unexec_error):
125 * xterm.c (x_ins_del_lines, x_delete_glyphs):
126 Use _Noreturn rather than NO_RETURN.
127 No need for separate decl merely because of _Noreturn.
128 * sound.c (sound_warning, parse_sound):
129 Remove unnecessary forward decls.
131 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
133 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
134 * lisp.h (WAIT_READING_MAX): New macro.
135 * dispnew.c (Fsleep_for, sit_for):
136 * keyboard.c (kbd_buffer_get_event):
137 * process.c (Faccept_process_output):
138 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
139 This improves on the previous patch, which introduced a bug
140 when time_t is unsigned and as wide as intmax_t.
141 See <http://bugs.gnu.org/9000#51>.
143 2012-06-23 Eli Zaretskii <eliz@gnu.org>
145 * dispnew.c (sit_for, Fsleep_for):
146 * keyboard.c (kbd_buffer_get_event):
147 * process.c (Faccept_process_output): Avoid compiler warnings when
148 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
150 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
152 * makefile.w32-in: Update dependencies.
154 * w32.c (ltime): Add return type and declare static.
155 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
157 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
159 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
160 Privately reported by Herbert J. Skuhra.
161 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
163 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
164 not make_lisp_timeval, when the argument is of type EMACS_TIME.
166 2012-06-23 Eli Zaretskii <eliz@gnu.org>
168 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
169 last argument of make_unibyte_string.
171 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
172 language ID in the event parameters.
174 * w32term.c (w32_read_socket): Put the new keyboard codepage into
175 event.code, not the obscure "character set ID".
177 2012-06-23 Chong Yidong <cyd@gnu.org>
179 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
181 2012-06-23 Eli Zaretskii <eliz@gnu.org>
183 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
184 * w32.c (fdutimens): New function.
186 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
188 * s/ms-w32.h (pselect): Redirect to sys_select.
190 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
192 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
193 in the logic of incrementing and decrementing the value of
194 use_relocatable_buffers.
196 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
198 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
199 Privately reported by Herbert J. Skuhra.
200 [__FreeBSD__]: Remove "*/" typo after "#include".
201 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
202 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
203 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
204 Don't assume EMACS_TIME and struct timeval are the same type.
206 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
208 Support higher-resolution time stamps (Bug#9000).
209 The time stamps are only nanosecond-resolution at the C level,
210 since that's the best that any real-world system supports now.
211 But they are picosecond-resolution at the Lisp level, as that's
212 easy, and leaves room for future OS improvements.
214 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
217 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
218 Don't get current time unless it's needed.
220 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
221 now provides it if it's absent.
222 (start_atimer): Port to higher-res time stamps.
223 Check for time stamp overflow. Don't get current time more
224 often than is needed.
226 * buffer.h (struct buffer): Buffer modtime now has high resolution.
227 Include systime.h, not time.h.
228 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
230 * dired.c: Include stat-time.h.
231 (Ffile-attributes): File times now have higher resolution.
233 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
234 (struct image): Timestamp now has higher resolution.
236 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
237 has at least microseconds now. All uses removed.
238 (update_frame, update_single_window, update_window, update_frame_1)
239 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
241 * editfns.c (time_overflow): Now extern.
242 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
243 (float-time, Fformat_time_string, Fcurrent_time_string)
244 (Fcurrent_time_zone): Accept and generate higher-resolution
246 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
247 (decode_time_components, lisp_seconds_argument): New functions.
248 (make_time): Now static.
249 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
250 Report an error if the time is invalid, rather than having the caller
253 * fileio.c: Include <stat-time.h>
254 (Fcopy_file): Copy higher-resolution time stamps.
255 Prefer to set the time stamp via a file descriptor if that works.
256 (Fset_file_times, Finsert_file_contents, Fwrite_region)
257 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
258 (Fvisited_file_modtime, Fset_visited_file_modtime):
259 Support higher-resolution time stamps.
261 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
263 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
265 * image.c (prepare_image_for_display, clear_image_cache)
266 (lookup_image): Port to higer-resolution time stamps.
268 * keyboard.c (start_polling, bind_polling_period):
269 Check for time stamp overflow.
270 (read_char, kbd_buffer_get_event, timer_start_idle)
271 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
272 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
273 Port to higher-resolution time stamps. Do not assume time_t is signed.
274 (decode_timer): New function. Timers are now vectors of length 9,
275 not 8, to accommodate the picosecond component.
276 (timer_check_2): Use it.
278 * nsterm.m (select_timeout, timeval_subtract): Remove.
279 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
280 as they're a bit more accurate and handle overflow better.
281 (ns_select): Change prototype to be compatible with pselect.
282 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
283 * nsterm.h (ns_select): Adjust prototype.
285 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
286 us-resolution time stamps.
287 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
289 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
291 * lisp.h (time_overflow): New decl.
292 (wait_reading_process_output): First arg is now intmax_t, not int,
293 to accommodate larger waits.
295 * process.h (struct Lisp_Process.read_output_delay):
296 Now counts nanoseconds, not microseconds.
297 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
299 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
300 (wait_reading_process_output):
301 Port to ns-resolution time stamps.
302 (Faccept_process_output, wait_reading_process_output):
303 Check for time stamp overflow. Do not assume time_t is signed.
304 (select_wrapper): Remove; we now use pselect.
305 (Fprocess_attributes): Now generates ns-resolution time stamps.
307 * sysdep.c: Include utimens.h. Don't include utime.h
308 or worry about struct utimbuf; gnulib does that for us now.
309 (gettimeofday): Remove; gnulib provides a substitute.
310 (make_timeval): New function.
311 (set_file_times): Now sets ns-resolution time stamps.
312 New arg FD; all uses changed.
313 (time_from_jiffies, ltime_from_jiffies, get_up_time)
314 (system_process_attributes):
315 Now returns ns-resolution time stamp. All uses changed.
316 Check for time stamp overflow.
318 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
319 provides a substitute now.
321 * systime.h: Include timespec.h rather than sys/time.h and time.h,
322 since it guarantees struct timespec.
323 (EMACS_TIME): Now struct timespec, so that we can support
324 ns-resolution time stamps.
325 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
326 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
327 (EMACS_USECS): Remove.
328 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
329 so multiply the arg by 1000 before storing it.
330 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
332 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
333 Port to ns-resolution time stamps.
334 (EMACS_TIME_NEG_P): Remove; replaced by....
335 (EMACS_TIME_SIGN): New macro.
336 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
337 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
338 (set_file_times, make_time, lisp_time_argument): Adjust signature.
339 (make_timeval, make_lisp_time, decode_time_components): New decls.
340 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
341 that it mishandled time_t overflow. You can't compare by subtracting!
342 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
343 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
345 * term.c: Include <sys/time.h>.
346 (timeval_to_Time): New function, for proper overflow wraparound.
347 (term_mouse_position, term_mouse_click): Use it.
349 * undo.c (record_first_change): Support higher-resolution time stamps
351 (Fprimitive_undo): Use them when restoring time stamps.
353 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
354 (w32_get_internal_run_time):
355 Port to higher-resolution Emacs time stamps.
356 (ltime): Now accepts single 64-bit integer, as that's more convenient
359 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
361 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
362 for compatibility with pselect. Support ns-resolution time stamps.
364 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
366 * xselect.c (wait_for_property_change, x_get_foreign_selection):
367 Check for time stamp overflow, and support ns-resolution time stamps.
369 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
370 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
371 (timeval_subtract): Remove; no longer needed.
372 (XTflash, XTring_bell, x_wait_for_event):
373 Port to ns-resolution time stamps. Don't assume time_t is signed.
375 2012-06-22 Chong Yidong <cyd@gnu.org>
377 * xdisp.c (x_consider_frame_title): Revert last change.
379 2012-06-22 Eli Zaretskii <eliz@gnu.org>
381 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
382 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
383 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
384 staticidx goes up to 1597 out of 1600 = 0x640.)
386 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
388 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
389 Otherwise, the umask might be mistakenly 0 while handling input signals.
391 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
393 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
395 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
397 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
398 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
399 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
400 access to `contents' member of Lisp_Vector objects with AREF and ASET
403 2012-06-19 Chong Yidong <cyd@gnu.org>
405 * frame.c (delete_frame): When selecting a frame on a different
406 text terminal, do not alter the terminal's top-frame.
408 * xdisp.c (format_mode_line_unwind_data): Record the target
409 frame's selected window and its terminal's top-frame.
410 (unwind_format_mode_line): Restore them.
411 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
413 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
414 since tty frames can be explicitly named.
415 (prepare_menu_bars): Likewise.
417 * term.c (Ftty_top_frame): New function.
419 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
421 Port byte-code-meter to modern targets.
422 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
423 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
424 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
425 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
426 (METER_1, METER_2): Simplify.
428 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
430 * data.c (Fdefalias): Return `symbol' (bug#11686).
432 2012-06-18 Martin Rudalics <rudalics@gmx.at>
434 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
435 gets killed during executing of this function (Bug#11665).
436 Try to always return Qt when the buffer has been actually killed.
437 (Vkill_buffer_query_functions): In doc-string say that functions
438 run by this hook should not change the current buffer.
440 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
442 Fix recently-introduced process.c problems found by static checking.
443 * process.c (write_queue_push, write_queue_pop, send_process):
444 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
445 (write_queue_pop): Fix pointer signedness problem.
446 (send_process): Remove unused local.
448 2012-06-17 Chong Yidong <cyd@gnu.org>
450 * xdisp.c (redisplay_internal): No need to redisplay terminal
451 frames that are not on top.
453 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
455 * process.c (make_process): Initialize write_queue.
456 (write_queue_push, write_queue_pop): New functions.
457 (send_process): Use them to maintain correct ordering of process
460 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
462 * lisp.h (eassert): Assume C89 or later.
463 This removes the need for CHECK.
464 (CHECK): Remove. Its comments about always evaluating its
465 argument were confusing, as 'eassert' typically does not evaluate
468 * coding.c (produce_chars): Use ptrdiff_t, not int.
470 * xterm.c (x_draw_underwave): Check for integer overflow.
471 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
473 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
475 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
476 referenced (Bug#11583).
478 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
480 Implement wave-style variant of underlining.
481 * dispextern.h (face_underline_type): New enum.
482 (face): Add field for underline type.
483 * nsterm.m (ns_draw_underwave): New function.
484 (ns_draw_text_decoration): Use it.
485 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
487 (x_draw_glyph_string): Use them.
488 * xfaces.c (Qline, Qwave): New Lisp objects.
489 (check_lface_attrs, merge_face_ref)
490 (Finternal_set_lisp_face_attribute, realize_x_face):
491 Handle wave-style underline face attributes.
492 * xterm.c (x_draw_underwave): New function.
493 (x_draw_glyph_string): Use it.
495 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
497 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
498 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
499 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
500 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
501 ($(BLD)/w32select.$(O)): Update dependencies.
503 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
505 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
506 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
507 * character.c (_fetch_multibyte_char_p): Remove.
508 * alloc.c: Include "character.h" before "buffer.h".
510 * buffer.c: Likewise.
511 * bytecode.c: Likewise.
512 * callint.c: Likewise.
513 * callproc.c: Likewise.
514 * casefiddle.c: Likewise.
515 * casetab.c: Likewise.
516 * category.c: Likewise.
518 * coding.c: Likewise.
519 * composite.c: Likewise.
521 * dispnew.c: Likewise.
523 * dosfns.c: Likewise.
524 * editfns.c: Likewise.
526 * fileio.c: Likewise.
527 * filelock.c: Likewise.
529 * fontset.c: Likewise.
530 * fringe.c: Likewise.
531 * indent.c: Likewise.
532 * insdel.c: Likewise.
533 * intervals.c: Likewise.
534 * keyboard.c: Likewise.
535 * keymap.c: Likewise.
537 * macros.c: Likewise.
538 * marker.c: Likewise.
539 * minibuf.c: Likewise.
541 * nsmenu.m: Likewise.
543 * process.c: Likewise.
545 * region-cache.c: Likewise.
546 * search.c: Likewise.
547 * syntax.c: Likewise.
549 * textprop.c: Likewise.
551 * unexsol.c: Likewise.
552 * w16select.c: Likewise.
553 * w32fns.c: Likewise.
554 * w32menu.c: Likewise.
555 * window.c: Likewise.
560 * xselect.c: Likewise.
562 2012-06-16 Eli Zaretskii <eliz@gnu.org>
564 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
565 If all the glyphs of the glyph row came from strings, and we have no
566 cursor positioning clues, put the cursor on the first glyph of the
568 (handle_face_prop): Use chunk-relative overlay string index when
569 indexing into it->string_overlays array. (Bug#11653)
570 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
571 the rightmost. (Bug#11720)
573 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
575 * category.h (CHAR_HAS_CATEGORY): Define as inline.
576 (CATEGORY_MEMBER): Enforce 1/0 value.
577 * category.c (_temp_category_set): Remove.
579 2012-06-16 Eli Zaretskii <eliz@gnu.org>
581 * window.c (Fdelete_other_windows_internal)
582 (Fdelete_window_internal): Don't access frame's mouse highlight
583 info of the initial frame. (Bug#11677)
585 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
587 * .gdbinit (xgetint): Fix recently-introduced paren typo.
588 Assume USE_2_TAGS_FOR_INTS.
589 (xreload): Adjust $tagmask width to match recent lisp.h change.
591 Simplify lisp.h in minor ways that should not affect code.
592 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
593 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
594 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
595 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
596 (INTTYPEBITS): New macro, for clarity.
597 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
598 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
599 Simplify now that USE_LSB_TAG is always defined.
600 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
601 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
603 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
605 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
607 2012-06-13 Glenn Morris <rgm@gnu.org>
609 * s/bsd-common.h (BSD4_3):
610 * s/usg5-4-common.h (USG5_4): No longer define; unused.
612 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
614 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
617 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
619 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
620 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
621 * alloc.c (widen_to_Lisp_Object): Remove.
622 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
623 * frame.c (delete_frame): Remove outdated comment.
624 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
626 (Fw32_unregister_hot_key): Likewise.
627 (Fw32_toggle_lock_key): Likewise.
628 * w32menu.c (add_menu_item): Likewise.
629 (w32_menu_display_help): Use XIL instead of checking
631 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
632 (init_heap): Likewise.
633 * w32term.c (w32_read_socket): Update comment.
635 2012-06-13 Glenn Morris <rgm@gnu.org>
637 * s/usg5-4-common.h, src/s/unixware.h:
638 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
640 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
642 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
644 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
645 * alloc.c (make_number) [!defined make_number]:
646 Remove, as lisp.h always defines this now.
647 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
648 (roundup_size): Verify that it is a power of 2.
649 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
650 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
651 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
652 -DUSE_LSB_TAG=0, to override the automatically-selected default.
653 USE_LSB_TAG now is always defined to be either 0 or 1.
655 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
656 code works fine either way, and efficiency is not a concern here,
657 as the union type is for debugging, not for production.
658 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
659 Use an inline function on all platforms when using the union type,
660 since this is simpler and 'static inline' can be used portably
662 (LISP_INITIALLY_ZERO): New macro.
663 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
664 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
666 2012-06-12 Glenn Morris <rgm@gnu.org>
668 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
670 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
672 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
673 Move BROKEN_SIGIO to configure.
675 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
676 Move NO_TERMIO to configure.
678 2012-06-12 Chong Yidong <cyd@gnu.org>
680 * image.c (imagemagick_load_image): Use MagickFlattenImage if
681 MagickMergeImageLayers is undefined. Use pixel pusher loop if
682 MagickExportImagePixels is undefined.
684 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
686 * image.c (imagemagick_load_image): Remove unused label.
688 2012-06-11 Glenn Morris <rgm@gnu.org>
690 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
691 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
692 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
693 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
695 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
697 * alloc.c (make_byte_code): New function.
698 (Fmake_byte_code): Use it. Don't purify here.
699 * lread.c (read1): Use it as well to avoid extra allocation.
701 2012-06-11 Chong Yidong <cyd@gnu.org>
703 * image.c (imagemagick_load_image): Implement transparency.
705 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
707 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
708 account for preceding backslashes. (Bug#11663)
710 2012-06-09 Chong Yidong <cyd@gnu.org>
712 * term.c: Support italics in capable terminals (Bug#9652).
713 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
714 (turn_on_face): Output using TS_enter_italic_mode if available.
715 Don't handle unused blinking and alt-charset cases.
716 (turn_off_face): Handle italic case; discard unused tty_blinking_p
717 and tty_alt_charset_p cases.
718 (tty_capable_p, init_tty): Support italics.
720 * termchar.h (struct tty_display_info): Add field for italics.
721 Remove unused blink field.
723 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
726 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
727 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
728 tty_alt_charset_p. Add tty_italic_p.
730 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
732 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
733 dbus_type_is_basic if available.
734 (xd_extract_signed, xd_extract_unsigned): Rename from
735 extract_signed and extract_unsigned, respectively. Adapt callers.
737 2012-06-09 Chong Yidong <cyd@gnu.org>
739 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
741 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
744 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
746 * xdisp.c (vmessage): Treat frame message as multibyte.
747 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
748 would generate the diagnostic "Making \302\247 buffer-local while
751 2012-06-08 Eli Zaretskii <eliz@gnu.org>
753 * dispnew.c (showing_window_margins_p): Undo last change, which
754 was done due to an inadvertent commit.
755 (adjust_frame_glyphs_for_frame_redisplay): Do call
756 showing_window_margins_p.
758 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
760 * eval.c (Fmake_var_non_special): New primitive.
761 (syms_of_eval): Defsubr it.
762 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
764 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
766 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
767 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
769 2012-06-08 Eli Zaretskii <eliz@gnu.org>
771 * alloc.c (allocate_vectorlike): Fix last change.
773 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
775 Block-based vector allocation of small vectors.
776 * lisp.h (struct vectorlike_header): New field `nbytes',
777 adjust comment accordingly.
778 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
779 to denote vector blocks. Adjust users (live_vector_p,
780 mark_maybe_pointer, valid_lisp_object_p) accordingly.
781 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
782 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
783 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
784 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
785 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
786 (roundup_size): New constant.
787 (struct vector_block): New data type.
788 (vector_blocks, vector_free_lists, zero_vector): New variables.
789 (all_vectors): Rename to `large_vectors'.
790 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
791 (sweep_vectors): New functions.
792 (allocate_vectorlike): Return `zero_vector' as the only vector of
793 0 items. Allocate new vector from block if vector size is less than
794 or equal to VBLOCK_BYTES_MAX.
795 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
796 (init_alloc_once): Add call to init_vectors.
798 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
800 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
802 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
804 * doprnt.c (doprnt): Truncate multibyte char correctly.
805 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
806 would mishandle a string argument "Xc" if X was a multibyte
807 character of length 2: it would truncate after X's first byte
808 rather than including all of X.
810 2012-06-06 Chong Yidong <cyd@gnu.org>
812 * buffer.c (word_wrap): Doc fix.
814 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
816 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
818 2012-06-03 Glenn Morris <rgm@gnu.org>
820 * xdisp.c (tool-bar-style): Doc fix.
822 2012-06-03 Ulrich Müller <ulm@gentoo.org>
824 * Makefile.in (PAXCTL): Define.
825 (temacs$(EXEEXT)): Disable memory randomization for the temacs
826 binary via PaX flags if the paxctl utility is available.
827 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
828 Restore PaX flags to their default. (Bug#11398)
830 2012-06-03 Chong Yidong <cyd@gnu.org>
832 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
835 2012-06-03 Chong Yidong <cyd@gnu.org>
837 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
838 (note_mode_line_or_margin_highlight): If there is no help echo,
839 use mode-line-default-help-echo. Handle the case where the mouse
840 position is past the end of the mode line string.
842 * buffer.c (buffer_local_value_1): New function, split from
843 Fbuffer_local_value; can return Qunbound.
844 (Fbuffer_local_value): Use it.
845 (Vmode_line_format): Docstring tweaks.
847 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
849 * sysdep.c (system_process_attributes): Improve comment.
851 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
853 * keyboard.c: Export real-this-command to Elisp.
854 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
855 and DEFVAR it. Update all users.
857 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
859 * minibuf.c (Fassoc_string): Remove duplicate declaration.
861 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
862 Convert pctcpu and pctmem to Lisp float properly.
863 Let the compiler fold better, as 100.0/0x8000 is exact.
865 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
867 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
870 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
872 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
874 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
876 For a 'struct window', replace some Lisp_Object fields to
877 bitfields where appropriate, remove unused fields.
878 * window.h (struct window): Remove unused 'last_mark_x' and
879 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
880 change it's type from Lisp_Object to bitfield.
881 Change type of 'force_start', 'optional_new_start',
882 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
883 fields from Lisp_Object to bitfield. Adjust users accordingly.
885 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
887 Pacify gcc -Wdouble-precision when using Xaw.
888 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
889 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
890 Use 'float' consistently, rather than 'float' in most places
891 and 'double' in a couple of places.
893 2012-05-31 Eli Zaretskii <eliz@gnu.org>
895 * xdisp.c (handle_stop): Detect whether we have overlay strings
896 loaded by testing it->current.overlay_string_index to be
897 non-negative, instead of checking whether n_overlay_strings is
898 positive. (Bug#11587)
900 2012-05-31 Chong Yidong <cyd@gnu.org>
902 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
904 * doc.c (Fsubstitute_command_keys): Doc fix.
906 2012-05-31 Eli Zaretskii <eliz@gnu.org>
908 * search.c (search_buffer): Remove calls to
909 r_alloc_inhibit_buffer_relocation, as it is now called by
910 maybe_unify_char, which was the cause of relocation of buffer text
913 2012-05-31 Eli Zaretskii <eliz@gnu.org>
915 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
916 for the duration of call to load_charset, to avoid problems with
917 callers of maybe_unify_char that access buffer text through C
920 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
921 decrement the inhibition flag, instead of just setting or
924 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
926 Remove obsolete '#define static' cruft.
927 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
928 This #undef was "temporary" in 2000; it is no longer needed
929 now that '#define static' has gone away.
930 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
931 (gray_bitmap_bits): Remove; no longer needed.
932 All uses replaced with definiens.
933 * xterm.c: Include "bitmaps/gray.xbm".
935 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
937 Clean up __executable_start, monstartup when --enable-profiling.
938 The following changes affect the code only when profiling.
939 * dispnew.c (__executable_start): Rename from safe_bcopy.
940 Define only on platforms that need it.
941 * emacs.c: Include <sys/gmon.h> when profiling.
942 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
943 (__executable_start): Remove decl, since lisp.h does it now.
944 (safe_bcopy): Remove decl; no longer has that name.
945 (main): Coalesce #if into single bit of code, for simplicity.
946 Cast pointers to uintptr_t, since standard libraries want integers
948 * lisp.h (__executable_start): New decl.
950 2012-05-31 Glenn Morris <rgm@gnu.org>
952 * image.c (Fimagemagick_types): Doc fix.
954 2012-05-30 Jim Meyering <meyering@redhat.com>
956 * callproc.c (Fcall_process_region): Include directory component
957 in mkstemp error message (Bug#11586).
959 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
961 * alloc.c, lisp.h (make_pure_vector): Now static.
963 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
965 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
967 (Fautoload): Do the hash-doc more carefully.
968 * data.c (Fdefalias): Purify definition, except for keymaps.
969 (Qdefun): Move from eval.c.
970 * lisp.h (Qdefun): Remove.
971 * lread.c (read1): Tiny simplification.
973 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
975 Do not create empty overlays with the evaporate property (Bug#9642).
976 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
977 Bug#9642, but explicitly check that the buffer the overlay would
978 be moved to is live and rearrange lines to make sure that errors
979 will not put the overlay in an inconsistent state.
980 (Fdelete_overlay): Cosmetics.
982 2012-05-28 Eli Zaretskii <eliz@gnu.org>
984 * w32term.c (my_bring_window_to_top): New function.
985 (x_raise_frame): Use handle returned by DeferWindowPos, which
986 could be different from the original one.
987 Call my_bring_window_to_top instead of my_set_foreground_window.
990 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
991 by calling BringWindowToTop.
993 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
994 (WM_EMACS_END): Increase by one.
996 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
998 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
999 This avoids undefined behavior that might cause the eassert
1000 to not catch an out-of-range value.
1002 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1004 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1005 Update dependencies.
1007 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1009 * bidi.c (bidi_mirror_char): Fix last change.
1011 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1013 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1014 when referring to sectname field in printf format.
1016 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1018 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1019 Only r_alloc_inhibit_buffer_relocation needed to be added;
1020 the others were already declared.
1022 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1023 before checking whether it's out of range. Put the check inside
1025 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1027 2012-05-27 Ken Brown <kbrown@cornell.edu>
1029 * callproc.c (Fcall_process): Restore a line that was accidentally
1030 commented out in the 2011-02-13 change (bug#11547).
1032 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1034 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1035 defined on ralloc.c.
1037 * buffer.c [REL_ALLOC]: Remove prototypes of
1038 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1039 they are now on lisp.h.
1041 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1043 * search.c (search_buffer): Use it to inhibit relocation of buffer
1044 text while re_search_2 is doing its job, because re_search_2 is
1045 passed C pointers to buffer text. (Bug#11519)
1047 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1050 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1051 state after an additional call to move_it_in_display_line_to, keep
1052 the values of it->max_ascent and it->max_descent found for the
1054 (pos_visible_p): Revert the comparison against bottom_y to what it
1055 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1058 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1060 Fix coding-related core dumps with gcc -ftrapv.
1061 The code was computing A - B, where A and B are pointers, and B is
1062 random garbage. This can lead to core dumps on platforms that
1063 have special pointer registers, and it also leads to core dumps on
1064 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1065 A - B only when B is initialized properly.
1066 * coding.c (coding_set_source, coding_set_destination): Return void.
1067 (coding_change_source, coding_change_destinations): New functions,
1068 with the old behaviors of coding_set_source and coding_set_destination.
1069 All callers that need an offset changed to use these new functions.
1071 2012-05-26 Glenn Morris <rgm@gnu.org>
1073 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1075 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1077 Extend mouse support on W32 text-mode console.
1078 * xdisp.c (draw_row_with_mouse_face):
1079 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1081 * w32console.c: Include window.h.
1082 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1084 (initialize_w32_display): Initialize mouse-highlight data.
1086 * w32inevt.c: Include termchar.h and window.h.
1087 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1088 moves, call note_mouse_highlight. If help_echo changed, call
1089 gen_help_event to produce help-echo message in the echo area.
1090 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1093 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1095 * lread.c (read1): Simplify slightly to avoid an overflow warning
1096 with GCC 4.7.0 on x86-64.
1098 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1100 * bidi.c (bidi_mirror_char): Revert last change: an int is
1101 definitely wide enough here.
1103 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1105 Fix integer width and related bugs (Bug#9874).
1106 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1107 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1108 (string_bytes, check_sblock, allocate_string_data):
1109 (compact_small_strings, Fmake_bool_vector, make_string)
1110 (make_unibyte_string, make_multibyte_string)
1111 (make_string_from_bytes, make_specified_string)
1112 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1113 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1116 (allocate_pseudovector):
1117 Use int, not EMACS_INT, where int is wide enough.
1118 (inhibit_garbage_collection, Fgarbage_collect):
1119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1120 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1121 int might not be wide enough.
1122 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1123 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1124 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1125 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1126 (bidi_level_of_next_char, bidi_move_to_visually_next):
1127 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1128 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1129 (Fkill_buffer, Fset_buffer_major_mode)
1130 (advance_to_char_boundary, Fbuffer_swap_text)
1131 (Fset_buffer_multibyte, overlays_at, overlays_in)
1132 (overlay_touches_p, struct sortvec, record_overlay_string)
1133 (overlay_strings, recenter_overlay_lists)
1134 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1135 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1136 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1137 (Foverlay_recenter, last_overlay_modification_hooks_used)
1138 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1140 (validate_region): Omit unnecessary test for b <= e,
1141 since that's guaranteed by the previous test.
1142 (adjust_overlays_for_delete): Avoid pos + length overflow.
1143 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1144 (report_overlay_modification):
1145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1146 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1147 Omit pointer cast, which isn't needed anyway, and doesn't work
1148 after the EMACS_INT -> ptrdiff_t change.
1149 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1150 * buffer.h: Adjust decls to match defn changes elsewhere.
1151 (struct buffer_text, struct buffer):
1152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1153 Use EMACS_INT, not int, where int might not be wide enough.
1154 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1155 not int, to avoid needless 32-bit limit on 64-bit hosts.
1156 (exec_byte_code): Use tighter memory-full test, one that checks
1157 for alloca overflow. Don't compute the address of the object just
1158 before an array, as that's not portable. Use EMACS_INT, not
1159 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1160 * callint.c (Fcall_interactively):
1161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1162 * callproc.c (call_process_kill, Fcall_process):
1163 Don't assume pid_t fits into an Emacs fixnum.
1164 (call_process_cleanup, Fcall_process, child_setup):
1165 Don't assume pid_t fits into int.
1166 (call_process_cleanup, Fcall_process, delete_temp_file)
1167 (Fcall_process_region):
1168 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1169 (Fcall_process): Simplify handling of volatile integers.
1170 Use int, not EMACS_INT, where int will do.
1171 * casefiddle.c (casify_object, casify_region, operate_on_word)
1172 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1174 (casify_object): Avoid integer overflow when overallocating buffer.
1175 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1176 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1177 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1178 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1179 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1180 integers are now checked earlier. All uses replaced with XINT.
1182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1183 For CCL_MapSingle, check that content and value are in int range.
1184 (ccl_driver, Fregister_code_conversion_map):
1185 Check that Vcode_version_map_vector is a vector.
1186 (resolve_symbol_ccl_program): Check that vector header is in range.
1187 Always copy the vector, so that we can check its contents reliably
1188 now rather than having to recheck each instruction as it's being
1189 executed. Check that vector words fit in 'int'.
1190 (ccl_get_compiled_code, Fregister_ccl_program)
1191 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1192 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1193 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1194 contents are in range.
1195 (Fccl_execute_on_string): Check that status is in range.
1196 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1197 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1198 Accept and return EMACS_INT, not int, because callers can pass values
1200 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1201 (multibyte_chars_in_text, parse_str_as_multibyte)
1202 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1203 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1204 (string_escape_byte8, Fget_byte):
1205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1206 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1207 avoid mishandling large integers.
1208 * character.h: Adjust decls to match defn changes elsewhere.
1209 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1210 (Ffind_charset_region):
1211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1212 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1213 (load_charset_map_from_vector, Fdefine_charset_internal):
1214 Don't assume fixnum fits in int.
1215 (load_charset_map_from_vector, Fmap_charset_chars):
1216 Remove now-unnecessary CHECK_NATNUMs.
1217 (Fdefine_charset_internal): Check ranges here, more carefully.
1218 Don't rely on undefined behavior with signed left shift overflow.
1219 Don't assume unsigned int fits into fixnum, or that fixnum fits
1220 into unsigned int. Don't require max_code to be a valid fixnum;
1221 that's not true for gb10830 4-byte on a 32-bit host. Allow
1222 invalid_code to be a cons, for the same reason. Require code_offset
1223 to be a character. Avoid int overflow if max_char is close
1225 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1226 this is intended anyway and avoids some undefined behavior.
1227 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1228 INDEX_TO_CODE_POINT, as that's what it expects.
1229 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1230 * charset.h (DECODE_CHAR): Return int, not unsigned;
1231 this is what was intended anyway, and it avoids undefined behavior.
1232 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1233 integer-overflow issues.
1234 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1235 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1236 where the argument is EMACS_INT, and this behavior is not intended.
1237 * chartab.c (Fmake_char_table, Fset_char_table_range)
1238 (uniprop_get_decoder, uniprop_get_encoder):
1239 Don't assume fixnum fits in int.
1240 * cmds.c (move_point): New function, that does the gist of
1241 Fforward_char and Fbackward_char, but does so while checking
1242 for integer overflow more accurately.
1243 (Fforward_char, Fbackward_char): Use it.
1244 (Fforward_line, Fend_of_line, internal_self_insert)
1245 (internal_self_insert):
1246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1247 Fix a FIXME, by checking for integer overflow when calculating
1248 target_clm and actual_clm.
1249 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1250 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1251 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1252 (coding_alloc_by_making_gap, alloc_destination)
1253 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1254 (encode_coding_utf_16, detect_coding_emacs_mule)
1255 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1256 (detect_coding_iso_2022, decode_coding_iso_2022)
1257 (encode_invocation_designation, encode_designation_at_bol)
1258 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1259 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1260 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1261 (encode_coding_ccl, encode_coding_raw_text)
1262 (detect_coding_charset, decode_coding_charset)
1263 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1264 (produce_composition, produce_charset, produce_annotation)
1265 (decode_coding, handle_composition_annotation)
1266 (handle_charset_annotation, consume_chars, decode_coding_gap)
1267 (decode_coding_object, encode_coding_object, detect_coding_system)
1268 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1269 (code_convert_region, code_convert_string)
1270 (Fdefine_coding_system_internal)
1271 (coding_set_source, coding_set_destination):
1272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1273 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1274 (Fdefine_coding_system_internal):
1275 Don't assume fixnums fit in int.
1276 (decode_coding_gap, decode_coding_object, encode_coding_object)
1277 (Fread_coding_system, Fdetect_coding_region)
1278 (Funencodable_char_position, Fcheck_coding_systems_region)
1279 (get_translation, handle_composition_annotation, consume_chars):
1280 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1281 (consume_chars): Rewrite to not calculate an address outside buffer.
1282 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1283 Don't access memory outside of the args array.
1284 (Fdefine_coding_system_internal): Check for charset-id overflow.
1285 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1286 result of ENCODE_CHAR.
1287 * coding.h: Adjust decls to match defn changes elsewhere.
1288 (struct coding_system):
1289 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1290 * composite.c (get_composition_id, find_composition)
1291 (run_composition_function, update_compositions)
1292 (compose_text, composition_gstring_put_cache)
1293 (composition_gstring_p, composition_gstring_width)
1294 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1295 (composition_compute_stop_pos, composition_reseat_it)
1296 (composition_update_it, struct position_record)
1297 (find_automatic_composition, composition_adjust_point)
1298 (Fcomposition_get_gstring, Ffind_composition_internal):
1299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1300 (update_compositions):
1301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1302 * composite.h: Adjust decls to match defn changes elsewhere.
1303 (struct composition):
1304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1305 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1306 Do not attempt to compute the address of the object just before a
1307 buffer; this is not portable.
1309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1310 (Faset): Use int, not EMACS_INT, where int is wide enough.
1311 (Fstring_to_number): Don't assume fixnums fit in int.
1312 (Frem): Don't assume arg is nonnegative.
1313 * dbusbind.c (xd_append_arg): Check for integers out of range.
1314 (Fdbus_call_method): Don't overflow the timeout int.
1315 (extract_signed, extract_unsigned): New functions.
1316 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1317 (xd_get_connection_references): Return ptrdiff_t, not int.
1319 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1320 (xd_read_message_1):
1321 Use int, not unsigned, where the dbus API uses int.
1322 (Fdbus_message_internal): Don't overflow mtype.
1323 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1324 * dired.c (directory_files_internal, file_name_completion, scmp)
1325 (file_name_completion_stat):
1326 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1327 (file_name_completion): Don't overflow matchcount.
1328 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1329 * dispextern.h: Adjust decls to match defn changes elsewhere.
1330 (struct text_pos, struct glyph, struct bidi_saved_info)
1331 (struct bidi_string_data, struct bidi_it, struct composition_it)
1333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1334 (struct display_pos, struct composition_it, struct it):
1335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1336 * dispnew.c (increment_matrix_positions)
1337 (increment_row_positions, mode_line_string)
1338 (marginal_area_string):
1339 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1340 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1341 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1342 (duration_to_sec_usec): New function, to check for overflow better.
1343 (Fsleep_for, sit_for): Use it.
1344 * doc.c (get_doc_string, store_function_docstring):
1345 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1346 (get_doc_string, Fsnarf_documentation):
1347 Use int, not EMACS_INT, where int is wide enough.
1349 Use SAFE_ALLOCA, not alloca.
1350 Check for overflow when converting EMACS_INT to off_t.
1351 * doprnt.c (doprnt):
1352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1353 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1354 Don't assume uid_t fits into fixnum.
1355 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1356 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1357 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1358 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1359 (general_insert_function)
1360 (Finsert_char, make_buffer_string, make_buffer_string_both)
1361 (update_buffer_properties, Fbuffer_substring)
1362 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1363 (Fsubst_char_in_region, check_translation)
1364 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1365 (transpose_markers, Ftranspose_regions):
1366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1367 (clip_to_bounds): Move to lisp.h as an inline function).
1368 (Fconstrain_to_field): Don't assume integers are nonnegative.
1369 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1370 (Fsubst_char_in_region, Fsave_restriction):
1371 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1372 (Femacs_pid): Don't assume pid_t fits into fixnum.
1373 (lo_time): Use int, not EMACS_INT, when int suffices.
1374 (lisp_time_argument): Check for usec out of range.
1375 (Fencode_time): Don't assume fixnum fits in int.
1376 (Fuser_login_name, Fuser_full_name): Signal an error
1377 if a uid argument is out of range, rather than relying on
1379 (Fformat_time_string): Remove now-unnecessary check.
1380 lisp_time_argument checks for out-of-range usec now.
1381 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1382 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1383 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1384 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1385 (init_cmdargs, Fdump_emacs):
1386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1387 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1388 the bottom (typically) 32 bits of the fixnum.
1389 * eval.c (specpdl_size, call_debugger):
1390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1391 (when_entered_debugger, Fbacktrace_debug):
1392 Don't assume fixnum can fit in int.
1393 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1394 the object just before a buffer; this is not portable.
1395 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1396 (grow_specpdl, unbind_to):
1397 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1398 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1399 (grow_specpdl): Simplify allocation by using xpalloc.
1400 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1401 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1402 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1403 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1404 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1407 (Fcopy_file, non_regular_nbytes, read_non_regular)
1408 (Finsert_file_contents):
1409 Use int, not EMACS_INT, where int is wide enough.
1410 (READ_BUF_SIZE): Verify that it fits in int.
1411 (Finsert_file_contents): Check that counts are in proper range,
1412 rather than assuming fixnums fit into ptrdiff_t etc.
1413 Don't assume fixnums fit into int.
1414 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1415 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1416 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1417 (string_char_to_byte, string_byte_to_char)
1418 (string_make_multibyte, string_to_multibyte)
1419 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1420 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1421 (substring_both, Fdelete, internal_equal, Ffillarray)
1422 (Fclear_string, mapcar1)
1423 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1424 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1425 (larger_vector, make_hash_table, maybe_resize_hash_table)
1426 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1427 (Fmaphash, secure_hash):
1428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1429 (concat): Check for string index and length overflow.
1430 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1433 (larger_vector): New API (vec, incr_min, size_max) replaces old
1434 one (vec, new_size, init). This catches size overflow.
1435 INIT was removed because it was always Qnil.
1436 All callers changed.
1437 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1438 the upper bound on a hash table index size.
1439 (make_hash_table, maybe_resize_hash_table): Use it.
1440 (secure_hash): Computer start_byte and end_byte only after
1441 they're known to be in ptrdiff_t range.
1442 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1443 (Ffont_get_glyphs, Ffont_at):
1444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1445 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1446 (Flist_fonts, Fopen_font):
1447 Don't assume fixnum can fit in int.
1448 (check_gstring): Don't assume index can fit in int.
1449 (font_match_p): Check that fixnum is a character, not a nonnegative
1450 fixnum, since the later code needs to stuff it into an int.
1451 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1452 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1453 conversion overflow issues.
1454 (Fopen_font): Check for integer out of range.
1455 (Ffont_get_glyphs): Don't assume index can fit in int.
1456 * font.h: Adjust decls to match defn changes elsewhere.
1457 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1459 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1460 printmax_t, where ptrdiff_t is wide enough.
1461 (Finternal_char_font):
1462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1463 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1464 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1465 (Fset_frame_position, x_set_frame_parameters)
1466 (x_set_line_spacing, x_set_border_width)
1467 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1468 Check that fixnums are in proper range for system types.
1469 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1471 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1472 Use SAFE_ALLOCA_LISP, not alloca.
1473 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1474 intptr_t is wide enough.
1475 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1476 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1477 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1478 Check for fixnum out of range.
1479 * ftfont.c (ftfont_list): Don't assume index fits in int.
1480 Check that fixnums are in proper range for system types.
1481 (ftfont_shape_by_flt):
1482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1483 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1485 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1486 Check that fixnums are in proper range for system types.
1487 * gnutls.h: Adjust decls to match defn changes elsewhere.
1488 * gtkutil.c (xg_dialog_run):
1489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1490 (update_frame_tool_bar):
1491 Check that fixnums are in proper range for system types.
1492 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1493 (lookup_image): Check that fixnums are in range for system types.
1494 * indent.c (last_known_column, last_known_column_point):
1495 (current_column_bol_cache):
1496 (skip_invisible, current_column, check_display_width):
1497 (check_display_width, scan_for_column, current_column_1)
1498 (Findent_to, Fcurrent_indentation, position_indentation)
1499 (indented_beyond_p, Fmove_to_column, compute_motion):
1500 (Fcompute_motion, Fvertical_motion):
1501 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1502 (last_known_column_modified): Use EMACS_INT, not int.
1503 (check_display_width):
1505 Check that fixnums and floats are in proper range for system types.
1506 (compute_motion): Don't assume index or fixnum fits in int.
1507 (compute_motion, Fcompute_motion):
1508 Use int, not EMACS_INT, when it is wide enough.
1509 (vmotion): Omit local var start_hpos that is always 0; that way
1510 we don't need to worry about overflow in expressions involving it.
1511 * indent.h: Adjust decls to match defn changes elsewhere.
1513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1514 Use int, not EMACS_INT, where int is wide enough.
1515 Remove unused members ovstring_chars_done and tab_offset;
1517 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1518 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1519 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1520 (make_gap, copy_text, insert, insert_and_inherit)
1521 (insert_before_markers, insert_before_markers_and_inherit)
1522 (insert_1, count_combining_before, count_combining_after)
1523 (insert_1_both, insert_from_string)
1524 (insert_from_string_before_markers, insert_from_string_1)
1525 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1526 (adjust_after_replace, adjust_after_insert, replace_range)
1527 (replace_range_2, del_range, del_range_1, del_range_byte)
1528 (del_range_both, del_range_2, modify_region)
1529 (prepare_to_modify_buffer, signal_before_change)
1530 (signal_after_change, Fcombine_after_change_execute):
1531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1532 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1533 (balance_an_interval, split_interval_right, split_interval_left)
1534 (find_interval, next_interval, update_interval)
1535 (adjust_intervals_for_insertion, delete_node, delete_interval)
1536 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1537 (static_offset_intervals, offset_intervals)
1538 (merge_interval_right, merge_interval_left, make_new_interval)
1539 (graft_intervals_into_buffer, temp_set_point_both)
1540 (temp_set_point, set_point, adjust_for_invis_intang)
1541 (set_point_both, move_if_not_intangible, get_property_and_range)
1542 (get_local_map, copy_intervals, copy_intervals_to_string)
1543 (compare_string_intervals, set_intervals_multibyte_1):
1544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1545 * intervals.h: Adjust decls to match defn changes elsewhere.
1547 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1548 * keyboard.c (this_command_key_count, this_single_command_key_start)
1549 (before_command_key_count, before_command_echo_length, echo_now)
1550 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1551 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1552 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1553 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1555 (last_non_minibuf_size, last_point_position, echo_truncate)
1556 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1557 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1558 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1559 (stuff_buffered_input):
1560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1561 (last_auto_save, command_loop_1, read_char):
1562 Use EMACS_INT, not int, to avoid integer overflow.
1563 (record_char): Avoid overflow in total_keys computation.
1564 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1565 * keyboard.h: Adjust decls to match defn changes elsewhere.
1566 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1567 (Fkey_description, Fdescribe_vector, Flookup_key):
1568 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1569 (click_position): New function, to check that positions are in range.
1570 (Fcurrent_active_maps):
1572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1573 (Faccessible_keymaps, Fkey_description):
1574 (preferred_sequence_p):
1575 Don't assume fixnum can fit into int.
1576 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1577 Check for integer overflow in size calculations.
1578 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1579 avoid mishandling large integers.
1580 * lisp.h: Adjust decls to match defn changes elsewhere.
1581 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1582 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1583 (struct Lisp_Marker):
1584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1585 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1586 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1587 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1588 All callers changed.
1589 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1590 Assume the arg has valid form, since it always does.
1591 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1592 unsigned integer system type.
1593 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1594 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1596 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1597 (duration_to_sec_usec): New decl.
1598 * lread.c (read_from_string_index, read_from_string_index_byte)
1599 (read_from_string_limit, readchar, unreadchar, openp)
1600 (read_internal_start, read1, oblookup):
1601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1602 (Fload, readevalloop, Feval_buffer, Feval_region):
1603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1604 (openp): Check for out-of-range argument to 'access'.
1605 (read1): Use int, not EMACS_INT, where int is wide enough.
1606 Don't assume fixnum fits into int.
1607 Fix off-by-one error that can read outside a buffer.
1608 (read_filtered_event): Use duration_to_sec_usec
1609 to do proper overflow checking on durations.
1610 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1611 in size calculation.
1612 (Fexecute_kbd_macro):
1613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1614 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1615 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1616 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1617 (set_marker_both, set_marker_restricted_both, marker_position)
1618 (marker_byte_position, Fbuffer_has_markers_at):
1619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1620 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1621 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1622 It now merely ensures that the menu is large enough, without
1623 necessarily growing it, as this avoids some integer overflow issues.
1624 All callers changed.
1625 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1627 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1628 Use SAFE_ALLOCA_LISP, not alloca.
1629 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1630 to EMACS_INT. Check that fixnums are in proper range for system types.
1631 * minibuf.c (minibuf_prompt_width, string_to_object)
1632 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1633 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1635 (get_minibuffer, read_minibuf_unwind):
1636 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1637 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1638 this simplifies overflow checking. All callers changed.
1639 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1641 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1642 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1643 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1644 Check that fixnums are in proper range for system types.
1645 (Fx_create_frame, Fx_show_tip):
1646 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1647 * nsfont.m (ns_findfonts, nsfont_list_family):
1648 Don't assume fixnum fits in long.
1649 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1651 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1653 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1655 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1656 (PRINTDECLARE, PRINTPREPARE):
1657 (strout, print_string):
1658 (print, print_preprocess, print_check_string_charset_prop)
1660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1662 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1663 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1664 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1665 (printchar, strout): Use xpalloc to catch size calculation overflow.
1666 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1667 (print_error_message): Use SAFE_ALLOCA, not alloca.
1668 (print_object): Use int, not EMACS_INT, where int is wide enough.
1669 (print_depth, new_backquote_output, print_number_index):
1670 Use ptrdiff_t, not int, where int might not be wide enough.
1671 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1672 (Fset_process_window_size, Fformat_network_address)
1673 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1675 Check that fixnums are in proper range for system types.
1676 (Fsignal_process): Simplify by avoiding a goto.
1677 Check for process-ids out of pid_t range rather than relying on
1679 (process_tick, update_tick): Use EMACS_INT, not int.
1680 (Fformat_network_address, read_process_output, send_process)
1681 (Fprocess_send_region, status_notify):
1682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1683 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1684 (wait_reading_process_output, read_process_output, exec_sentinel):
1685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1686 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1687 (Faccept_process_output): Use duration_to_sec_usec to do proper
1688 overflow checking on durations.
1689 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1690 Don't assume pid_t fits in int.
1691 * process.h (struct Lisp_Process): Members tick and update_tick
1692 are now of type EMACS_INT, not int.
1693 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1694 configured --with-wide-int.
1695 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1696 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1697 * search.c (looking_at_1, string_match_1):
1698 (fast_string_match, fast_c_string_match_ignore_case)
1699 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1700 (scan_newline, find_before_next_newline, search_command)
1701 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1702 (set_search_regs, wordify):
1705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1706 (string_match_1, search_buffer, set_search_regs):
1708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1709 (wordify): Check for overflow in size calculation.
1710 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1711 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1712 Check that fixnums are in proper range for system types.
1713 * sound.c (struct sound_device)
1714 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1716 (Fplay_sound_internal):
1717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1718 * syntax.c (struct lisp_parse_state, find_start_modiff)
1719 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1720 (Fparse_partial_sexp):
1721 Don't assume fixnums can fit in int.
1722 (struct lisp_parse_state, find_start_pos, find_start_value)
1723 (find_start_value_byte, find_start_begv)
1724 (update_syntax_table, char_quoted, dec_bytepos)
1725 (find_defun_start, prev_char_comend_first, back_comment):
1726 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1727 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1729 (Finternal_describe_syntax_value): Check that match_lisp is a
1730 character, not an integer, since the code stuffs it into int.
1731 (scan_words, scan_sexps_forward):
1732 Check that fixnums are in proper range for system types.
1734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1735 (scan_sexps_forward):
1736 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1737 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1738 * syntax.h: Adjust decls to match defn changes elsewhere.
1739 (struct gl_state_s):
1740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1741 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1742 MOST_POSITIVE_FIXNUM.
1743 * sysdep.c (wait_for_termination_1, wait_for_termination)
1744 (interruptible_wait_for_termination, mkdir):
1745 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1746 (emacs_read, emacs_write):
1747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1748 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1749 and double all fit in int.
1750 * term.c (set_tty_color_mode):
1751 Check that fixnums are in proper range for system types.
1752 * termhooks.h (struct input_event):
1753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1754 * textprop.c (validate_interval_range, interval_of)
1755 (Fadd_text_properties, set_text_properties_1)
1756 (Fremove_text_properties, Fremove_list_of_text_properties)
1757 (Ftext_property_any, Ftext_property_not_all)
1758 (copy_text_properties, text_property_list, extend_property_ranges)
1759 (verify_interval_modification):
1760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1761 (Fnext_single_char_property_change)
1762 (Fprevious_single_char_property_change):
1763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1764 (copy_text_properties):
1765 Check for integer overflow in index calculation.
1766 * undo.c (last_boundary_position, record_point, record_insert)
1767 (record_delete, record_marker_adjustment, record_change)
1768 (record_property_change):
1769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1770 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1772 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1773 (Fx_hide_tip, Fx_file_dialog):
1774 * w32menu.c (set_frame_menubar):
1775 Use ptrdiff_t, not int, for consistency with rest of code.
1776 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1777 (select_window, Fdelete_other_windows_internal)
1778 (window_scroll_pixel_based, window_scroll_line_based)
1779 (Frecenter, Fset_window_configuration):
1780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1781 (Fset_window_hscroll, run_window_configuration_change_hook)
1782 (set_window_buffer, temp_output_buffer_show, scroll_command)
1783 (Fscroll_other_window, Frecenter):
1784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1785 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1786 Don't assume fixnum fits in int.
1787 (Fset_window_scroll_bars):
1788 Check that fixnums are in proper range for system types.
1789 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1790 (string_pos, c_string_pos, number_of_chars, init_iterator)
1791 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1792 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1793 (compute_display_string_end, handle_face_prop)
1794 (face_before_or_after_it_pos, handle_invisible_prop)
1795 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1796 (display_prop_intangible_p, string_buffer_position_lim)
1797 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1798 (get_overlay_strings_1, get_overlay_strings)
1799 (iterate_out_of_display_property, forward_to_next_line_start)
1800 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1801 (get_next_display_element, set_iterator_to_next)
1802 (get_visually_first_element, compute_stop_pos_backwards)
1803 (handle_stop_backwards, next_element_from_buffer)
1804 (move_it_in_display_line_to, move_it_in_display_line)
1805 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1806 (add_to_log, message_dolog, message_log_check_duplicate)
1807 (message2, message2_nolog, message3, message3_nolog
1808 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1809 (current_message_1, truncate_echo_area, truncate_message_1)
1810 (set_message, set_message_1, store_mode_line_noprop)
1811 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1812 (text_outside_line_unchanged_p, check_point_in_composition)
1813 (reconsider_clip_changes)
1814 (redisplay_internal, set_cursor_from_row, try_scrolling)
1815 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1816 (redisplay_window, find_last_unchanged_at_beg_row)
1817 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1818 (trailing_whitespace_p, find_row_edges, display_line)
1819 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1820 (display_mode_element, store_mode_line_string)
1821 (pint2str, pint2hrstr, decode_mode_spec)
1822 (display_count_lines, display_string, draw_glyphs)
1823 (x_produce_glyphs, x_insert_glyphs)
1824 (rows_from_pos_range, mouse_face_from_buffer_pos)
1825 (fast_find_string_pos, mouse_face_from_string_pos)
1826 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1828 (safe_call, init_from_display_pos, handle_fontified_prop)
1829 (handle_single_display_spec, load_overlay_strings)
1830 (with_echo_area_buffer, setup_echo_area_for_printing)
1831 (display_echo_area, echo_area_display)
1832 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1833 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1834 (redisplay_window, dump_glyph_row, display_mode_line)
1835 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1836 (handle_display_spec, display_prop_string_p):
1837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1838 (handle_single_display_spec, build_desired_tool_bar_string)
1839 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1840 (get_specified_cursor_type):
1841 Check that fixnums are in proper range for system types.
1842 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1843 (Flookup_image_map):
1844 Don't assume fixnums fit in int.
1845 (compare_overlay_entries):
1846 Avoid mishandling comparisons due to subtraction overflow.
1847 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1848 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1849 (handle_tool_bar_click):
1850 Use int, not unsigned, since we prefer signed and the signedness
1851 doesn't matter here.
1852 (get_next_display_element, next_element_from_display_vector):
1853 Use int, not EMACS_INT, when int is wide enough.
1854 (start_hourglass): Use duration_to_sec_usec to do proper
1855 overflow checking on durations.
1856 * xfaces.c (Fbitmap_spec_p):
1857 Check that fixnums are in proper range for system types.
1858 (compare_fonts_by_sort_order):
1859 Avoid mishandling comparisons due to subtraction overflow.
1860 (Fx_family_fonts, realize_basic_faces):
1861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1863 Don't assume fixnum fits in int.
1864 Use SAFE_ALLOCA_LISP, not alloca.
1865 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1866 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1867 (face_at_buffer_position, face_for_overlay_string)
1868 (face_at_string_position):
1869 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1870 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1871 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1873 Check that fixnums are in proper range for system types.
1874 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1875 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1877 (Fx_change_window_property): Don't assume fixnums fit in int.
1878 * xfont.c (xfont_chars_supported):
1879 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1880 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1881 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1883 * xml.c (parse_region):
1884 * xrdb.c (magic_file_p):
1885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1886 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1887 (x_get_local_selection, x_reply_selection_request)
1888 (x_handle_selection_request, wait_for_property_change):
1889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1890 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1891 short is wide enough.
1892 (x_send_client_event): Don't assume fixnum fits in int.
1893 * xterm.c (x_x_to_emacs_modifiers):
1894 Don't assume EMACS_INT overflows nicely into int.
1895 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1897 (handle_one_xevent): NATNUMP can eval its arg twice.
1898 (x_connection_closed):
1899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1900 * xterm.h: Adjust decls to match defn changes elsewhere.
1901 (struct scroll_bar): Use struct vectorlike_header
1902 rather than rolling our own approximation.
1903 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1905 2012-05-25 Glenn Morris <rgm@gnu.org>
1907 * lisp.mk (lisp): Update for more files being compiled now.
1909 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1911 * lread.c: Remove `read_pure' which makes no difference.
1912 (read_pure): Remove var.
1913 (unreadpure): Remove function.
1914 (readevalloop): Don't call read_list with -1 flag.
1915 (read1, read_vector): Don't test read_pure any more.
1916 (read_list): Simplify.
1918 * fileio.c, character.h: Minor style tweaks.
1920 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1922 * window.h (clip_changed): Remove useless declaration.
1924 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1926 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1927 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1929 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1932 This directory predates autoconf and is no longer needed nowadays.
1933 Move its few remaining bits of functionality to where they're needed.
1934 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1935 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1936 * m/template.h: Remove.
1937 * Makefile.in (M_FILE): Remove. All uses removed.
1938 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1939 * lisp.h (USE_LSB_TAG):
1940 * mem-limits.h (EXCEEDS_LISP_PTR):
1941 Use VAL_MAX, not VALBITS, in #if.
1942 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1943 (EMACS_UINT): Define unconditionally now.
1944 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1945 (BITS_PER_EMACS_INT): New constants, replacing
1946 what used to be in config.h, but not useful in #if.
1947 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1948 define them any more.
1949 (VAL_MAX): New macro.
1951 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1952 BITS_PER_EMACS_INT, in #if.
1953 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1954 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1955 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1956 * s/ms-w32.h (DATA_START):
1957 Move here from removed file m/intel386.h.
1958 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1959 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1961 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1963 Assume C89 or later.
1964 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1965 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1967 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1968 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1969 * textprop.c, tparam.c (NULL): Remove.
1970 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1971 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1972 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1973 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1974 * xterm.c (input_signal_count): Assume volatile works.
1976 2012-05-21 Ken Brown <kbrown@cornell.edu>
1978 * xgselect.c (xg_select): Fix first argument in call to 'select'
1981 2012-05-20 Ken Brown <kbrown@cornell.edu>
1983 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1984 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1986 2012-05-19 Ken Brown <kbrown@cornell.edu>
1988 * xfns.c (x_in_use): Remove `static' qualifier.
1989 * xterm.h (x_in_use): Declare.
1990 * xgselect.c: Include xterm.h.
1991 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1992 and `display_arg' (bug#9754).
1994 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1996 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1998 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1999 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2001 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2003 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2005 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2006 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2008 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2009 reference to image_cache->refcount.
2010 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2012 2012-05-17 Juri Linkov <juri@jurta.org>
2014 * search.c (Fword_search_regexp, Fword_search_backward)
2015 (Fword_search_forward, Fword_search_backward_lax)
2016 (Fword_search_forward_lax): Move functions to isearch.el
2017 (bug#10145, bug#11381).
2019 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2021 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2023 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2025 * lread.c (init_obarray): Declare Qt and Qnil as special.
2027 2012-05-14 Glenn Morris <rgm@gnu.org>
2029 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2030 Put "libexec" before "bin", for the sake of init_callproc_1.
2032 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2034 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2036 * unexaix.c: Port to more-recent AIX compilers.
2037 (report_error, report_error_1, make_hdr, copy_sym)
2038 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2039 Make arguments const char *, not char *, to avoid violations of C
2040 standard and to fix some AIX warnings reported by Gilles Pion.
2042 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2044 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2045 already have overlays loaded.
2046 (handle_single_display_spec): Before returning without displaying
2047 fringe bitmap, synchronize the bidi iterator with the main display
2048 iterator, by calling iterate_out_of_display_property.
2049 (iterate_out_of_display_property): Detect buffer iteration by
2050 testing that it->string is a Lisp string.
2051 (get_next_display_element): When the current object is exhausted,
2052 and there's something on it->stack, call set_iterator_to_next to
2053 proceed with what's on the stack, instead of returning zero.
2054 (set_iterator_to_next): If called at the end of a Lisp string,
2055 proceed to consider_string_end without incrementing string
2056 position. Don't increment display vector index past the end of
2057 the display vector. (Bug#11417)
2058 (pos_visible_p): Don't report a position visible when move_it_to
2059 stopped at the last line of window, which happens to be scanned
2060 backwards by the bidi iteration. (Bug#11464)
2062 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2064 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2065 and right-margin display specs even if the spec is invalid or we
2066 are on a TTY, and thus unable to display on the fringes.
2067 That's because the text with the property will not be displayed anyway,
2068 so we need to signal to the caller that this is a "replacing"
2069 display spec. This fixes display when the spec is invalid or we
2072 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2074 * unexaix.c (make_hdr): Fix typo in prototype.
2075 This bug broke the build on AIX. Problem reported by Gilles Pion.
2077 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2079 * keyboard.c (kbd_buffer_get_event): Read special events also in
2080 batch mode. (Bug#11415)
2082 2012-05-12 Glenn Morris <rgm@gnu.org>
2084 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2086 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2088 * lisp.mk (lisp): Add newcomment.elc.
2090 2012-05-12 Glenn Morris <rgm@gnu.org>
2092 * Makefile.in (MKDIR_P): New, set by configure.
2093 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2095 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2097 Remove unused function hourglass_started.
2098 * dispextern.h (hourglass_started):
2099 * w32fns.c (hourglass_started):
2100 * xdisp.c (hourglass_started): Remove.
2102 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2104 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2105 Update dependencies.
2107 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2109 * xgselect.c (xg_select): Put maxfds+1 into a var.
2110 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2112 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2114 2012-05-10 Dave Abrahams <dave@boostpro.com>
2116 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2117 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2119 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2121 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2122 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2123 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2124 Initialize xd_registered_buses.
2126 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2128 Untag more efficiently if USE_LSB_TAG.
2129 This is based on a proposal by YAMAMOTO Mitsuharu in
2130 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2131 For an admittedly artificial (nth 8000 longlist) benchmark on
2132 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2133 Emacs's overall text size by 1%.
2134 * lisp.h (XUNTAG): New macro.
2135 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2136 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2137 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2138 * eval.c (Fautoload):
2139 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2140 * frame.h (XFRAME): Use XUNTAG.
2142 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2143 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2144 Remove unportable assumptions about print widths of types like
2146 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2147 intptr_t when converting between pointer and integer, to avoid GCC
2148 warnings about wrong width.
2150 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2152 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2153 stack for each reader_thread, instead of defaulting to 8MB
2154 determined by the linker. This avoids failures in creating
2155 subprocesses on Windows 7, see the discussion in this thread:
2156 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2158 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2160 Fix up display of the *Minibuf-0* buffer in the mini window.
2161 * keyboard.c (read_char): Don't clear the echo area if there's no
2163 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2164 contents of *Minibuf-0*) if there's no message displayed in its stead.
2166 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2168 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2171 2012-05-06 Chong Yidong <cyd@gnu.org>
2173 * lisp.mk (lisp): Update.
2175 2012-05-05 Jim Meyering <meyering@redhat.com>
2177 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2179 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2181 * data.c (PUT_ERROR): New macro.
2182 (syms_of_data): Use it. Add new error type `user-error'.
2183 * undo.c (user_error): New function.
2184 (Fprimitive_undo): Use it.
2185 * print.c (print_error_message): Adjust print style for `user-error'.
2186 * keyboard.c (user_error): New function.
2187 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2189 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2191 Do not limit current-time-string to years 1000..9999.
2192 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2193 (Fcurrent_time_string): Support any year that is supported by the
2194 underlying localtime representation. Don't use asctime, as it
2195 has undefined behavior for years outside the range -999..9999.
2197 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2199 Fix race conditions involving setenv, gmtime, localtime, asctime.
2200 Without this fix, interrupts could mess up code that uses these
2201 nonreentrant functions, since setting TZ invalidates existing
2202 tm_zone or tzname values, and since most of these functions return
2203 pointers to static storage.
2204 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2205 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2206 Grow the critical sections to include not just invoking
2207 localtime/gmtime, but also accessing these functions' results
2208 including their tm_zone values if any, and any related TZ setting.
2209 (format_time_string): Last arg is now struct tm *, not struct tm **,
2210 so that the struct tm is saved in the critical section.
2211 All callers changed. Simplify allocation of initial buffer, partly
2212 motivated by the fact that memory allocation needs to be outside
2213 the critical section.
2215 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2217 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2218 with RESET_INTERVAL.
2220 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2221 Remove duplicated buffer name initialization.
2223 2012-05-02 Jim Meyering <jim@meyering.net>
2225 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2227 * xfns.c (x_window): Use xstrdup (Bug#11375).
2229 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2231 * xdisp.c (pos_visible_p): If already at a newline from the
2232 display string before the 'while' loop, don't walk back the glyphs
2233 from it3.glyph_row. Solves assertion violation when the display
2234 string begins with a newline (egg.el). (Bug#11367)
2236 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2238 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2241 2012-05-01 Glenn Morris <rgm@gnu.org>
2243 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2244 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2245 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2246 All were removed before 23.1.
2248 * dispnew.c: Remove HAVE_LIBNCURSES test;
2249 it is always true on relevant platforms.
2251 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2252 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2254 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2256 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2258 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2259 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2262 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2264 Do not avoid creating empty evaporating overlays (Bug#9642).
2265 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2266 That is, do not delete an evaporating overlay if it becomes
2267 empty after its bounds are adjusted to fit within its buffer.
2268 This fix caused other problems, and I'm reverting it until we get
2269 to the bottom of them.
2271 2012-04-27 Chong Yidong <cyd@gnu.org>
2273 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2275 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2277 * xdisp.c (pos_visible_p): If the window start position is beyond
2278 ZV, start the display from buffer beginning. Prevents assertion
2279 violation in init_iterator when the minibuffer window is scrolled
2282 * window.c (window_scroll_pixel_based): Likewise.
2284 2012-04-27 Chong Yidong <cyd@gnu.org>
2286 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2288 2012-04-27 Glenn Morris <rgm@gnu.org>
2290 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2291 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2293 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2295 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2296 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2298 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2300 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2301 display element, check also the underlying string or buffer
2302 character. (Bug#11341)
2304 * w32menu.c: Include w32heap.h.
2305 (add_menu_item): If the call to AppendMenuW (via
2306 unicode_append_menu) fails, disable Unicode menus only if we are
2307 running on Windows 9X/Me.
2309 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2311 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2312 (xgetint): Add missing shift for LSB tags.
2314 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2316 * keyboard.c (read_char): Don't wipe echo area for select window
2317 events: These might get delayed via `mouse-autoselect-window'
2320 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2322 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2323 manipulation of :loaded-from data.
2325 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2327 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2328 now a cons (bug#11311).
2330 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2332 Do not create empty overlays with the evaporate property (Bug#9642).
2333 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2334 if it becomes empty after its bounds are adjusted to fit within
2335 its buffer. Without this fix, in a nonempty buffer (let ((o
2336 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2337 yields an empty overlay that has the evaporate property, which is
2338 not supposed to happen.
2340 Fix minor GTK3 problems found by static checking.
2341 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2342 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2343 (struct _EmacsFixedClass, emacs_fixed_get_type):
2344 Move decls here from emacsgtkfixed.h, since they needn't be public.
2345 (emacs_fixed_get_type): Now static.
2346 (emacs_fixed_class_init): Omit unused local.
2347 (emacs_fixed_child_type): Remove; unused.
2348 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2349 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2350 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2351 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2352 (EMACS_FIXED_GET_CLASS): Remove; unused.
2353 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2355 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2356 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2358 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2360 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2361 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2362 (__malloc_size_t, __malloc_ptrdiff_t):
2363 Remove. All uses removed, replaced by the definiens if needed,
2364 since we can assume C89 or better now.
2365 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2366 (protect_malloc_state, align, get_contiguous_space)
2367 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2368 (malloc_atfork_handler_child, malloc_enable_thread)
2369 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2370 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2371 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2372 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2373 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2374 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2375 Define using prototypes, not old style.
2376 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2377 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2378 (align): Don't assume that signed integer overflow wraps around.
2379 Omit unused local var.
2380 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2381 (_free_internal_nolock, memalign, mallochook, reallochook):
2382 Omit no-longer-needed casts.
2383 (valloc): Use getpagesize, not __getpagesize.
2384 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2385 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2387 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2389 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2391 Move functions from C to Lisp. Make non-blocking method calls
2392 the default. Implement further D-Bus standard interfaces.
2394 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2395 (QCdbus_request_name_allow_replacement)
2396 (QCdbus_request_name_replace_existing)
2397 (QCdbus_request_name_do_not_queue)
2398 (QCdbus_request_name_reply_primary_owner)
2399 (QCdbus_request_name_reply_in_queue)
2400 (QCdbus_request_name_reply_exists)
2401 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2402 (QCdbus_registered_serial, QCdbus_registered_method)
2403 (QCdbus_registered_signal): New Lisp objects.
2404 (XD_DEBUG_MESSAGE): Use sizeof.
2405 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2406 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2407 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2408 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2409 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2410 (xd_signature, xd_append_arg): Allow float for integer types.
2411 (xd_get_connection_references): New function.
2412 (xd_get_connection_address): Rename from xd_initialize.
2413 Return cached address.
2414 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2415 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2417 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2418 Return number of refcounts.
2419 (Fdbus_get_unique_name): Make stronger parameter check.
2420 (Fdbus_message_internal): New defun.
2421 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2422 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2423 (Fdbus_send_signal, Fdbus_register_service)
2424 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2425 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2426 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2427 (Vdbus_compiled_version, Vdbus_runtime_version)
2428 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2429 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2430 (Vdbus_message_type_signal): New defvars.
2431 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2434 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2436 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2437 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2438 Do not assume ptrdiff_t is the same width as 'int'.
2440 * alloc.c: Handle unusual debugging option combinations.
2441 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2442 since the two debugging options are incompatible.
2443 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2445 (mem_init, mem_insert, mem_insert_fixup):
2446 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2447 (NEED_MEM_INSERT): Remove; no longer needed.
2449 2012-04-22 Leo Liu <sdl.web@gmail.com>
2451 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2453 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2455 * sysdep.c [__FreeBSD__]: Minor cleanups.
2456 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2457 Use Emacs indenting style more consistently. Avoid some casts.
2458 Use 'double' consistently rather than mixing 'float' and 'double'.
2460 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2462 * sysdep.c (list_system_processes, system_process_attributes):
2463 Add implementation for FreeBSD (Bug#5243).
2465 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2467 * lisp.mk (lisp): Update.
2469 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2471 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2472 It is never used otherwise.
2474 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2476 * print.c (print_preprocess): Only check print_depth if print-circle
2478 (print_object): Check for cycles even when print-circle is nil and
2479 print-gensym is t, but only check print_depth if print-circle is nil.
2481 2012-04-20 Chong Yidong <cyd@gnu.org>
2483 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2484 set the status to "failed" and ensure that sentinel is run.
2486 2012-04-20 Glenn Morris <rgm@gnu.org>
2488 * process.c (Fset_process_inherit_coding_system_flag)
2489 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2490 (Fmake_network_process, Fmake_serial_process): Doc fix.
2492 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2494 * xdisp.c (string_buffer_position_lim): Limit starting position to
2496 (set_cursor_from_row): If called for a mode-line or header-line
2497 row, return zero immediately.
2498 (try_cursor_movement): If inside continuation line, don't back up
2499 farther than the first row after the header line, if any.
2500 Don't consider the header-line row as "partially visible", even if
2501 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2503 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2505 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2508 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2509 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2511 configure: new option --enable-gcc-warnings (Bug#11207)
2512 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2513 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2514 (ALL_CFLAGS): Use new macros rather than old.
2515 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2516 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2517 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2518 -Wunused-result, -Wunused-variable. This should go away once
2519 the Emacs and Gnulib regex code is merged.
2520 (xmalloc, xrealloc): Now static.
2522 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2524 * dired.c (Fsystem_groups): Remove unused local.
2526 2012-04-17 Glenn Morris <rgm@gnu.org>
2528 * dired.c (Fsystem_users): Doc fix.
2530 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2532 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2533 (syms_of_dired): Add them.
2535 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2537 Fix minor alloc.c problems found by static checking.
2538 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2539 New extern decls, to avoid calling undeclared functions.
2540 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2541 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2542 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2543 (NEED_MEM_INSERT): New macro.
2544 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2545 Remove one incorrect comment and fix another.
2547 Fix minor ralloc.c problems found by static checking.
2548 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2549 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2550 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2551 (r_alloc_sbrk): Now static.
2553 Improve ralloc.c interface checking.
2554 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2555 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2556 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2557 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2558 [REL_ALLOC]: ... to here, to check interface.
2559 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2560 Remove decls. This fixes an "It stinks!".
2562 * alloc.c (which_symbols): Fix alignment issue / type clash.
2564 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2566 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2567 (struct Lisp_Misc_Any): Likewise.
2568 (struct Lisp_Free): Likewise.
2569 * alloc.c (union aligned_Lisp_Symbol): Define.
2570 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2571 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2572 (union aligned_Lisp_Misc): Define.
2573 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2574 aligned_Lisp_Misc instead of union Lisp_Misc.
2575 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2577 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2579 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2580 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2581 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2582 * s/netbsd.h, s/sol2-6.h:
2583 Remove definition of GC_MARK_STACK, since the default now works.
2584 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2585 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2586 no longer the default.
2587 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2589 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2591 * lread.c (lisp_file_lexically_bound_p):
2592 Fix hang at ";-*-\n" (bug#11238).
2594 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2596 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2597 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2599 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2601 * nsterm.m (constrainFrameRect): Always constrain when there is only
2602 one screen (Bug#10962).
2604 2012-04-13 Ken Brown <kbrown@cornell.edu>
2606 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2608 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2610 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2612 2012-04-11 Daniel Colascione <dancol@dancol.org>
2614 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2615 against is gone. It's better to use vfork now so that when Cygwin
2616 gains a new, working vfork, we use it automatically (bug#10398).
2618 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2620 * window.c (save_window_save): Obey window-point-insertion-type.
2622 2012-04-11 Glenn Morris <rgm@gnu.org>
2624 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2626 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2628 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2630 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2632 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2633 (force_quit_count): New var.
2634 (handle_interrupt): Use it.
2636 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2638 * w32.c (w32_delayed_load): Record the full path of the library
2639 being loaded (bug#10424).
2641 2012-04-09 Glenn Morris <rgm@gnu.org>
2643 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2644 not just in the obarray, before snarfing them. (Bug#11036)
2646 * Makefile.in ($(leimdir)/leim-list.el):
2647 Pass EMACS rather than BUILT_EMACS.
2649 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2651 * process.c (make_process):
2652 * process.h: Add integer `gnutls_handshakes_tried' member to
2655 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2656 Add convenience `GNUTLS_LOG2i' macro.
2658 * gnutls.c (gnutls_log_function2i): Convenience log function.
2659 (emacs_gnutls_read): Use new log functions,
2660 `gnutls_handshakes_tried' process member, and
2661 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2662 attempts per process (connection).
2664 2012-04-09 Chong Yidong <cyd@gnu.org>
2666 * eval.c (Fuser_variable_p, user_variable_p_eh)
2667 (lisp_indirect_variable): Functions deleted.
2668 (Fdefvar): Caller changed.
2670 * callint.c (Finteractive, Fcall_interactively):
2671 * minibuf.c (Fread_variable): Callers changed.
2673 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2675 * xdisp.c (set_cursor_from_row): If the display string appears in
2676 the buffer at position that is closer to point than the position
2677 after the display string, display the cursor on the first glyph of
2678 the display string. Fixes cursor display when a 'display' text
2679 property immediately follows invisible text. (Bug#11094)
2681 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2683 composite.c: use 'double' consistently
2684 * composite.c (get_composition_id): Use 'double' consistently
2685 instead of converting 'float' to 'double' and vice versa; this is
2686 easier to understand and avoids a GCC warning.
2688 2012-04-09 Glenn Morris <rgm@gnu.org>
2690 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2691 preparation for dumping it with emacs. (Bug#4789)
2692 (leimdir): New variable.
2693 ($(leimdir)/leim-list.el): New rule.
2694 (emacs$(EXEEXT)): Depend on leim-list.el.
2696 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2697 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2698 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2700 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2702 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2705 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2707 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2708 Remove unused local variable.
2710 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2712 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2713 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2714 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2715 objects, as mark_maybe_pointer will catch them otherwise.
2716 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2717 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2719 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2721 Fix typo that broke non-Windows builds.
2722 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2724 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2726 Support building on MS-Windows with libxml2.
2728 * makefile.w32-in (OBJ2): Add xml.$(O).
2729 (GLOBAL_SOURCES): Add xml.c.
2730 ($(BLD)/xml.$(O)): New dependency list.
2732 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2733 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2734 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2735 [!WINDOWSNT]: New macros.
2736 (init_libxml2_functions, libxml2_loaded_p): New functions.
2737 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2738 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2739 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2740 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2742 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2743 Call init_libxml2_functions before calling libxml2 functions.
2744 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2746 * emacs.c: Don't include libxml/parser.h.
2747 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2748 xmlCleanupParser directly.
2750 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2752 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2754 * indent.c (Fvertical_motion): If there is a display string at
2755 point, use it.vpos to compute how many lines to backtrack after
2756 move_it_to point. (Bug#11133)
2758 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2760 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2761 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2762 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2763 macros related to unification of CJK characters. For the details,
2764 see the discussion following the message here:
2765 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2767 2012-04-04 Chong Yidong <cyd@gnu.org>
2769 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2771 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2773 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2774 instead of alloca. (Bug#11138)
2776 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2778 * w32menu.c (is_simple_dialog): Properly check lisp types.
2781 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2783 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2784 position we get to after a call to move_it_to fails the
2785 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2786 only if we wind up in a string from display property. (Bug#11063)
2788 * window.c (Fdelete_other_windows_internal): Invalidate the row
2789 and column information about mouse highlight, so that redisplay
2790 restores it after reallocating the glyph matrices. (Bug#7464)
2792 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2793 string comes from a `display' text property, use the buffer
2794 position of that property as if we actually saw that position in
2796 (move_it_by_lines): Remove the assertion that
2797 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2798 violated when there's a before-string at the beginning of a line.
2801 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2803 * xdisp.c (append_space_for_newline): If the default face was
2804 remapped, use the remapped face for the appended newline.
2805 (extend_face_to_end_of_line): Use the remapped default face for
2806 extending the face to the end of the line.
2807 (display_line): Call extend_face_to_end_of_line when the default
2808 face was remapped. (Bug#11068)
2810 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2812 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2814 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2816 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2818 2012-03-27 Glenn Morris <rgm@gnu.org>
2820 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2823 2012-03-26 Kenichi Handa <handa@m17n.org>
2825 * dispextern.h (struct glyph): Fix previous change. Change the
2826 bit length of glyphless.ch to 25 (Bug#11082).
2828 2012-03-26 Chong Yidong <cyd@gnu.org>
2830 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2831 (command_loop_1): Use it; inhibit selection update for
2832 handle-select-window too (Bug#8996).
2834 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2836 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2838 2012-03-25 Kenichi Handa <handa@m17n.org>
2840 * dispextern.h (struct glyph): Change the bit length of
2841 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2843 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2845 * s/ms-w32.h (tzname): Include time.h before redirecting to
2846 _tzname. Fixes the MSVC build. (Bug#9960)
2848 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2850 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2853 * xterm.c (XTread_socket): Only modify handling_signal if
2854 !SYNC_INPUT. (Bug#11080)
2856 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2858 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2859 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2860 when fetching a multibyte character consumes more bytes than
2861 CHAR_BYTES returns, due to unification of CJK characters in
2862 string_char. (Bug#11073)
2864 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2866 * process.c (wait_reading_process_output): Handle pty disconnect
2867 by refraining from sending oneself a SIGCHLD (bug#10933).
2869 2012-03-22 Chong Yidong <cyd@gnu.org>
2871 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2873 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2874 Mark string as coming from a prefix property.
2875 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2876 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2878 2012-03-21 Chong Yidong <cyd@gnu.org>
2880 * xfaces.c (Vface_remapping_alist): Doc fix.
2882 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2884 * w32proc.c (Fw32_set_console_codepage)
2885 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2888 2012-03-20 Chong Yidong <cyd@gnu.org>
2890 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2891 to reflect default non-nil value of redisplay-dont-pause.
2893 2012-03-19 Kenichi Handa <handa@m17n.org>
2895 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2896 it fit in a valid range (Bug#11003).
2898 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2900 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2901 that is not from display property, accept the row as a "cursor
2902 row" if one of the string's character has a non-nil `cursor'
2903 property. Fixes cursor positioning when there are newlines in
2904 overlay strings, e.g. in icomplete.el. (Bug#11035)
2906 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2908 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2910 2012-03-12 Chong Yidong <cyd@gnu.org>
2912 * eval.c (inhibit_lisp_code): Rename from
2913 inhibit_window_configuration_change_hook; move from window.c.
2915 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2916 * window.c (run_window_configuration_change_hook)
2917 (syms_of_window): Callers changed.
2919 2012-03-11 Chong Yidong <cyd@gnu.org>
2921 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2923 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2925 2012-03-10 Chong Yidong <cyd@gnu.org>
2927 * frame.c (other_visible_frames): Don't assume the selected frame
2928 is visible (Bug#10955).
2930 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2932 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2934 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2936 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2937 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2940 2012-03-03 Glenn Morris <rgm@gnu.org>
2942 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2944 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2946 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2947 position past the first glyph_row that ends at ZV. (Bug#10902)
2948 (redisplay_window, next_element_from_string): Fix typos in
2950 (redisplay_window): Pass to move_it_vertically the margin in
2951 pixels, not in screen lines.
2953 2012-03-02 Glenn Morris <rgm@gnu.org>
2955 * buffer.c (buffer-list-update-hook): Doc fix.
2957 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2959 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2960 push_it before setting up the iterator for the first overlay
2961 string, even if we have an empty string loaded.
2962 (next_overlay_string): If there's an empty string on the iterator
2963 stack, pop the stack. (Bug#10903)
2965 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2967 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2968 Suggested by Stefan Monnier in
2969 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2970 * alloc.c (widen_to_Lisp_Object): New static function.
2971 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2972 and widening them to Lisp_Objects. This would work even if
2973 USE_LSB_TAG is defined and wide integers are used, which might
2974 happen in a future version of Emacs.
2976 2012-02-25 Chong Yidong <cyd@gnu.org>
2978 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2981 * xselect.c (Fx_selection_exists_p): Doc fix.
2982 (x_clipboard_manager_save_all): Print an informative message
2983 before saving to clipboard manager.
2985 2012-02-24 Chong Yidong <cyd@gnu.org>
2987 * keyboard.c (process_special_events): Handle all X selection
2988 requests in kbd_buffer, not just the next one (Bug#8869).
2990 2012-02-23 Chong Yidong <cyd@gnu.org>
2992 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2993 call when setting menu-bar-lines and tool-bar-lines parameters.
2994 (unwind_create_frame_1): New helper function.
2996 * window.c (inhibit_window_configuration_change_hook): New var.
2997 (run_window_configuration_change_hook): Obey it.
2998 (syms_of_window): Initialize it.
3000 2012-02-22 Chong Yidong <cyd@gnu.org>
3002 * xterm.c (x_draw_image_relief): Add missing type check for
3003 Vtool_bar_button_margin (Bug#10743).
3005 2012-02-21 Chong Yidong <cyd@gnu.org>
3007 * fileio.c (Vfile_name_handler_alist): Doc fix.
3009 * buffer.c (Fget_file_buffer): Protect against invalid file
3010 handler return value.
3012 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3014 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3015 when computing $valmask.
3017 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3018 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3019 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3020 It's useless in that case, and it can cause problems on hosts
3021 that allocate halves of EMACS_INT values separately.
3022 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3023 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3024 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3025 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3026 it avoids undefined behavior on hosts where shifting right by more
3027 than the word width has undefined behavior.
3029 2012-02-19 Chong Yidong <cyd@gnu.org>
3031 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3032 (Funhandled_file_name_directory, Ffile_name_as_directory)
3033 (Fdirectory_file_name, Fexpand_file_name)
3034 (Fsubstitute_in_file_name): Protect against invalid file handler
3035 return values (Bug#10845).
3037 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3039 * .gdbinit (pitx): Fix incorrect references to fields of the
3042 2012-02-17 Chong Yidong <cyd@gnu.org>
3044 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3046 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3048 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3049 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3051 2012-02-15 Chong Yidong <cyd@gnu.org>
3053 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3054 marked as special. Also, starting docstrings with * is obsolete.
3056 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3058 * gnutls.c (emacs_gnutls_write): Fix last change.
3060 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3062 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3065 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3067 * keymap.c (Fsingle_key_description): Handle char ranges.
3069 2012-02-12 Chong Yidong <cyd@gnu.org>
3071 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3072 as that creates a dangerous corner case.
3074 * window.c (Fdelete_window_internal): Invalidate the mouse
3075 highlight (Bug#9904).
3077 2012-02-12 Glenn Morris <rgm@gnu.org>
3079 * xselect.c (Fx_own_selection_internal)
3080 (Fx_get_selection_internal, Fx_disown_selection_internal)
3081 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3082 * nsselect.m (Fx_own_selection_internal)
3083 (Fx_disown_selection_internal, Fx_selection_exists_p)
3084 (Fx_selection_owner_p, Fx_get_selection_internal):
3085 Sync docs and argument specs with the xselect.c versions.
3087 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3089 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3091 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3093 * w32select.c (Fx_selection_exists_p): Sync doc string and
3094 argument list with xselect.c. (Bug#10783)
3096 * w16select.c (Fx_selection_exists_p): Sync doc string and
3097 argument list with xselect.c. (Bug#10783)
3099 2012-02-10 Glenn Morris <rgm@gnu.org>
3101 * fns.c (Fsecure_hash): Doc fix.
3103 2012-02-09 Kenichi Handa <handa@m17n.org>
3105 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3107 2012-02-07 Chong Yidong <cyd@gnu.org>
3109 * buffer.c (Fbuffer_local_variables)
3110 (buffer_lisp_local_variables): Handle unbound vars correctly;
3111 don't let Qunbound leak into Lisp.
3113 2012-02-07 Glenn Morris <rgm@gnu.org>
3115 * image.c (Fimagemagick_types): Doc fix.
3117 * image.c (imagemagick-render-type): Change it from a lisp object
3118 to an integer. Move the doc here from the lisp manual.
3119 Treat all values not equal to 0 the same.
3121 2012-02-06 Chong Yidong <cyd@gnu.org>
3123 * doc.c (store_function_docstring): Avoid applying docstring of
3124 alias to base function (Bug#2603).
3126 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3128 * .gdbinit (pp1, pv1): Remove redundant defines.
3131 2012-02-04 Chong Yidong <cyd@gnu.org>
3133 * nsterm.m: Declare a global (Bug#10694).
3135 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3137 * w32.c (get_emacs_configuration_options):
3138 Include --enable-checking, if specified, in the return value.
3140 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3142 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3143 after rounding frame sizes. (Bug#9723)
3145 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3147 * keyboard.c (adjust_point_for_property): Don't position point
3148 before BEGV. (Bug#10696)
3150 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3152 Handle overflow when computing char display width (Bug#9496).
3153 * character.c (char_width): Return EMACS_INT, not int.
3154 (char_width, c_string_width): Check for overflow when
3155 computing the width; this is possible now that individual
3156 characters can have unbounded width. Problem introduced
3157 by merge from Emacs 23 on 2012-01-19.
3159 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3161 * dbusbind.c (Fdbus_register_method): Mention the return value
3162 :ignore in the docstring.
3164 2012-02-02 Glenn Morris <rgm@gnu.org>
3166 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3168 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3169 Unconditionally set to t. (Bug#10673)
3170 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3171 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3172 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3174 2012-02-02 Kenichi Handa <handa@m17n.org>
3176 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3177 0, do not call append_composite_glyph.
3179 2012-02-02 Kenichi Handa <handa@m17n.org>
3181 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3183 (x_produce_glyphs): If the component of a composition is a null
3184 string, set it->pixel_width to 1 to avoid zero-width glyph.
3186 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3188 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3189 first 2 arguments are identical. This makes inserting large
3190 output from a subprocess an order of magnitude faster on
3191 MS-Windows, where all sbrk'ed memory is always contiguous.
3193 2012-01-31 Glenn Morris <rgm@gnu.org>
3195 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3196 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3197 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3199 2012-01-29 Glenn Morris <rgm@gnu.org>
3201 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3203 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3205 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3207 2012-01-28 Chong Yidong <cyd@gnu.org>
3209 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3211 2012-01-26 Chong Yidong <cyd@gnu.org>
3213 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3215 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3216 repeat counts (Bug#10507).
3218 2012-01-26 Glenn Morris <rgm@gnu.org>
3220 * lread.c (syms_of_lread): Doc fix.
3222 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3224 * coding.c (encode_designation_at_bol): Change return value to
3227 2012-01-25 Chong Yidong <cyd@gnu.org>
3229 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3231 2012-01-21 Chong Yidong <cyd@gnu.org>
3233 * floatfns.c (Fcopysign): Make the second argument non-optional,
3234 since nil is not allowed anyway.
3236 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3238 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3239 (send_process): Likewise.
3241 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3243 * window.c (save_window_save, Fcurrent_window_configuration)
3244 (Vwindow_persistent_parameters): Do not use Qstate.
3245 Rewrite doc-strings.
3247 2012-01-19 Kenichi Handa <handa@m17n.org>
3249 * character.c (char_width): New function.
3250 (Fchar_width, c_string_width, lisp_string_width):
3251 Use char_width (Bug#9496).
3253 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3255 * window.c (Vwindow_persistent_parameters): New variable.
3256 (Fset_window_configuration, save_window_save): Handle persistent
3259 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3261 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3262 thrashing the stack of the thread. (Bug#9087)
3264 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3266 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3268 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3270 * xdisp.c (rows_from_pos_range): Handle the case where the
3271 highlight ends on a newline. (Bug#10464)
3272 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3273 he end column for display of highlight that ends on a newline
3276 2012-01-11 Glenn Morris <rgm@gnu.org>
3278 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3279 from load-path also when installation-directory is nil. (Bug#10208)
3281 2012-01-10 Glenn Morris <rgm@gnu.org>
3283 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3285 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3286 Update template values to be closer to their typical values these days.
3288 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3290 * xdisp.c (rows_from_pos_range): Accept additional argument
3291 DISP_STRING, and accept any glyph in a row whose object is that
3292 string as eligible for mouse highlight. Fixes mouse highlight of
3293 display strings from overlays. (Bug#10464)
3295 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3297 emacs: fix an auto-save permissions race condition (Bug#10400)
3298 * fileio.c (auto_saving_dir_umask): New static var.
3299 (Fmake_directory_internal): Use it.
3300 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3301 creating the directory. The old code temporarily assigns
3302 too-generous permissions to the directory.
3303 (do_auto_save_eh): Clear it.
3304 (Fdo_auto_save): Catch all errors, not just file errors, so
3305 that the var is always cleared.
3307 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3309 * search.c (scan_buffer): Pass character positions to
3310 know_region_cache, not byte positions. (Bug#6540)
3312 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3314 * w32.c (sys_rename): Report EXDEV when rename of a directory
3315 fails because the target is on another logical disk. (Bug#10284)
3317 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3319 * xterm.c (x_embed_request_focus): New function.
3321 * xterm.h: Add prototype.
3323 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3325 2012-01-05 Glenn Morris <rgm@gnu.org>
3327 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3329 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3331 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3332 Load gnutls_transport_set_lowat only if GnuTLS version is below
3334 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3335 GnuTLS versions below 2.11.1.
3337 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3339 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3340 to the doc string advising against its use for altering the way
3341 windows are scrolled.
3343 2011-12-28 Kenichi Handa <handa@m17n.org>
3345 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3346 coding-system ASCII compatible only when it does not produce BOM
3347 on encoding (Bug#10383).
3349 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3351 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3353 (create_and_show_popup_menu): Always use menu_position_func for
3356 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3358 * callint.c (Fcall_interactively): Don't truncate prompt string.
3360 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3362 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3363 property that ends at ZV, so that the bidi iteration could be
3364 resumed from there (after widening). (Bug#10360)
3366 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3368 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3370 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3372 * nsterm.m (x_free_frame_resources):
3373 Release f->output_data.ns->miniimage.
3374 (ns_index_color): Fix indentation. Do not retain
3375 color_table->colors[i].
3377 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3380 * nsfns.m (x_set_background_color): Assign return value from
3381 ns_index_color to face-background instead of NSColor*.
3382 (ns_implicitly_set_icon_type): Fix indentation.
3383 Change assignment in for loop to comparison.
3385 * emacs.c (ns_pool): New variable.
3386 (main): Assign ns_pool.
3387 (Fkill_emacs): Call ns_release_autorelease_pool.
3389 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3390 autorelease fdesc, release fdAttrs and tdict.
3391 (ns_get_covering_families): Release charset.
3392 (ns_findfonts): Release NSFontDescriptor created with new.
3393 (ns_uni_to_glyphs): Fix indentation.
3394 (setString): Release attrStr before assigning new value.
3396 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3398 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3400 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3401 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3403 2011-12-18 David Reitter <reitter@cmu.edu>
3405 * nsterm.m (ns_term_init): Subscribe for notifications
3406 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3407 to method trackingNotification in EmacsMenu.
3409 * nsmenu.m (trackingMenu): New variable.
3410 (trackingNotification): New method (from Aquamacs).
3411 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3412 from Aquamacs (Bug#7030).
3414 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3416 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3417 (symbol_to_nsstring): Fix indentation.
3418 (ns_symbol_to_pb): New function.
3419 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3420 (Fns_rotate_cut_buffers_internal): Remove.
3421 (Fns_store_selection_internal): Rename from
3422 Fns_store_cut_buffer_internal.
3423 (ns_get_foreign_selection, Fx_own_selection_internal)
3424 (Fx_disown_selection_internal, Fx_selection_exists_p)
3425 (Fns_get_selection_internal, Fns_store_selection_internal):
3426 Use ns_symbol_to_pb and check if return value is nil.
3427 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3428 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3429 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3430 renamed to Sns_store_selection_internal.
3431 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3432 and remove this function.
3433 (ns_handle_selection_clear): Remove, never used.
3434 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3437 2011-12-17 Ken Brown <kbrown@cornell.edu>
3439 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3440 GID is unknown (Bug#10257).
3442 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3444 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3445 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3446 which caused a build failure on GNU/Linux IA-64. This problem was
3447 introduced by my 2011-10-07 patch.
3449 2011-12-15 Juri Linkov <juri@jurta.org>
3451 * image.c (imagemagick_error): New function. (Bug#10112)
3452 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3453 Use `imagemagick_error' where ImageMagick functions return
3455 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3458 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3460 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3461 fill background (Bug#8992).
3463 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3465 * window.c (Vwindow_combination_resize)
3466 (Vwindow_combination_limit): Use t instead of non-nil in
3468 (Vrecenter_redisplay): Add first sentence of doc-string on
3470 (Frecenter): Fix doc-string typo.
3472 2011-12-11 Kenichi Handa <handa@m17n.org>
3474 * coding.c (Funencodable_char_position): Pay attention to the
3475 buffer text relocation (Bug#9389).
3477 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3479 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3480 gtk_init (Bug#10100).
3482 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3484 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3485 IT->string is nil. (Bug#10263)
3487 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3489 * nsterm.h (x_free_frame_resources): Declare.
3491 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3492 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3494 * nsterm.h (ns_get_defaults_value): Declare.
3496 * nsterm.m (ns_default): Call ns_get_defaults_value.
3498 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3500 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3503 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3505 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3506 that where the value of an _OBJC_* symbol points to is in the .bss
3507 section (Bug#10240).
3509 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3511 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3512 after the loop to call ccl_driver at least once (Bug#8619).
3514 2011-12-08 Kenichi Handa <handa@m17n.org>
3516 * ftfont.c (get_adstyle_property): Fix previous change
3519 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3521 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3522 dirs from the default value of EMACSLOADPATH (bug#10208).
3524 2011-12-07 Glenn Morris <rgm@gnu.org>
3526 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3527 installation and source directories as well. (Bug#10208)
3529 2011-12-06 Chong Yidong <cyd@gnu.org>
3531 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3533 2011-12-06 Glenn Morris <rgm@gnu.org>
3535 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3536 as an error, not just -1. (Bug#10217)
3538 2011-12-05 Chong Yidong <cyd@gnu.org>
3540 * keyboard.c (process_special_events): New function.
3541 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3543 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3545 * coding.c (encode_designation_at_bol): Don't use uninitialized
3546 local variable (Bug#9318).
3548 2011-12-05 Kenichi Handa <handa@m17n.org>
3550 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3551 return Qnil (Bug#8046, Bug#10193).
3553 2011-12-05 Kenichi Handa <handa@m17n.org>
3555 * coding.c (encode_designation_at_bol): New args charbuf_end and
3556 dst. Return the number of produced bytes. Callers changed.
3557 (coding_set_source): Return how many bytes coding->source was
3559 (coding_set_destination): Return how many bytes
3560 coding->destination was relocated.
3561 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3562 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3564 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3566 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3567 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3570 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3572 The following changes are to fix Bug#9318.
3574 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3575 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3576 (encode_coding_iso_2022, encode_coding_sjis)
3577 (encode_coding_big5, encode_coding_charset): Use the above macros.
3579 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3581 * lisp.h (process_quit_flag): Fix external declaration.
3583 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3585 Don't macro-inline non-performance-critical code.
3586 * eval.c (process_quit_flag): New function.
3587 * lisp.h (QUIT): Use it.
3589 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3591 * nsfns.m (get_geometry_from_preferences): New function.
3592 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3594 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3596 * emacs.c (Qkill_emacs): Define.
3597 (syms_of_emacs): Initialize it.
3598 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3599 Qquit_flag to `kill-emacs' instead.
3600 (quit_throw_to_read_char): Add parameter `from_signal'.
3601 All callers changed. Call Fkill_emacs if requested and safe.
3602 * lisp.h (QUIT): Call Fkill_emacs if requested.
3604 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3606 * widget.c (update_wm_hints): Return if wmshell is null.
3607 (widget_update_wm_size_hints): New function.
3609 * widget.h (widget_update_wm_size_hints): Declare.
3611 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3612 widget_update_wm_size_hints (Bug#10104).
3614 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3616 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3617 before a newline, prepare the bidi iterator for consuming the
3618 newline, and keep the current paragraph direction. (Bug#10183)
3619 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3621 2011-12-02 Juri Linkov <juri@jurta.org>
3623 * search.c (Fword_search_regexp): New Lisp function created from
3624 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3625 (Fword_search_backward, Fword_search_forward)
3626 (Fword_search_backward_lax, Fword_search_forward_lax):
3627 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3628 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3630 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3632 * fileio.c (Finsert_file_contents): Move after-change-function call
3633 to before the "handled:" label, since all "goto handled" appear in
3634 cases where the *-change-functions have already been properly called
3637 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3639 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3640 waiting for input. (Bug#10169)
3642 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3644 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3645 verifies glyph row's hash code--we have just reallocated the
3646 glyphs, so their contents can be complete garbage. (Bug#10164)
3648 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3650 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3652 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3654 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3655 attributes are tested _before_ calling verify_row_hash, to protect
3656 against GCC re-ordering of the tests. (Bug#10164)
3658 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3660 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3662 * xterm.c (handle_one_xevent): Only set async_visible and friends
3663 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3664 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3665 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3667 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3669 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3670 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3671 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3672 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3673 All uses changed to use GCPRO1 etc.
3674 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3675 Revert to old implementation (i.e., before 2011-03-11).
3677 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3679 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3680 of scroll runs so as to avoid assigning disabled bogus rows and
3681 unnecessary graphics copy operations.
3683 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3685 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3686 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3687 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3688 (malloc, free, realloc, calloc): Redirect to e_* only when
3691 * lisp.h (GCTYPEBITS): Move before first use.
3692 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3693 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3694 this macro definition.
3696 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3699 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3701 * gtkutil.c (xg_create_frame_widgets):
3702 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3703 present with Gtk+ 2.0.
3705 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3707 * fileio.c (Finsert_file_contents): Undo previous change; see
3708 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3710 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3712 Rename locals to avoid shadowing.
3713 * fileio.c (Finsert_file_contents):
3714 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3715 * process.c (wait_reading_process_output):
3716 Rename inner 'proc' to 'p' to avoid shadowing.
3717 Indent for consistency with usual Emacs style.
3719 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3721 * xdisp.c (redisplay_window): If cursor row is not fully visible
3722 after recentering, and scroll-conservatively is set to a large
3723 number, scroll window by a few more lines to make the cursor fully
3724 visible and out of scroll-margin. (Bug#10105)
3725 (start_display): Don't move to the next line if the display should
3726 start at a newline that is part of a display vector or an overlay
3729 2011-11-24 Juri Linkov <juri@jurta.org>
3731 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3732 after the `MagickPingImage' call. (Bug#10112)
3734 2011-11-23 Chong Yidong <cyd@gnu.org>
3736 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3738 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3740 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3741 making another buffer current. (Bug#10114)
3743 2011-11-23 Glenn Morris <rgm@gnu.org>
3745 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3747 2011-11-23 Chong Yidong <cyd@gnu.org>
3749 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3750 using it (Bug#5984).
3752 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3754 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3755 and header-lines, as they don't have one computed for them.
3758 * .gdbinit (prow): Make displayed values more self-explaining.
3759 Add row's hash code.
3761 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3763 * process.c (wait_reading_process_output): Fix asynchrounous
3764 GnuTLS socket handling on some versions of the GnuTLS library.
3765 (wait_reading_process_output): Add comment and URL.
3767 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3769 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3771 2011-11-21 Chong Yidong <cyd@gnu.org>
3773 * window.c (Fnext_window, Fprevious_window): Doc fix.
3775 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3777 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3779 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3781 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3783 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3785 * window.c (Fset_window_combination_limit): Rename argument
3787 (Vwindow_combination_limit): Remove "status" from doc-string.
3789 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3791 * m/ibms390.h: Remove.
3792 * m/ibms390x.h: Don't include "ibms390.h".
3794 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3796 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3797 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3799 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3801 * casetab.c (Fset_case_table):
3802 * charset.c (Fcharset_after): Fix typos.
3804 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3806 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3807 Otherwise, valgrind does not work on some platforms.
3808 Problem reported by Andreas Schwab in
3809 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3810 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3811 is set, removing the need for VIRT_ADDRESS_VARIES.
3812 (PURE_P): Use a more-efficient implementation that needs just one
3813 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3814 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3815 to 4 (xorl, subq, cmpq, setbe).
3816 * alloc.c (pure): Always extern now, since that's the
3817 VIRT_ADDR_VARIES behavior.
3818 (PURE_POINTER_P): Use a single comparison, not two, for
3819 consistency with the new puresize.h.
3820 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3821 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3822 Remove VIRT_ADDR_VARIES no longer needed.
3824 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3826 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3827 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3828 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3829 behave as if the cursor position were at the window margin.
3831 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3832 and the cursor position is out of bounds, behave as if the cursor
3833 position were at the window margin. (Bug#10075)
3835 2011-11-18 Chong Yidong <cyd@gnu.org>
3837 * window.c (Fwindow_combination_limit): Make first argument
3838 non-optional, since it is meaningless for live windows like the
3841 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3843 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3845 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3847 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3848 (graft_intervals_into_buffer): Simplify.
3850 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3852 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3853 hash values of the two rows.
3854 (copy_row_except_pointers): Preserve the used[] arrays and the
3855 hash values of the two rows. (Bug#10035)
3856 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3858 * xdisp.c (row_hash): New function, body extracted from
3859 compute_line_metrics.
3860 (compute_line_metrics): Call row_hash, instead of computing the
3863 * dispnew.c (verify_row_hash): Call row_hash for computing the
3864 hash code of a row, instead of duplicating code from xdisp.c.
3866 * dispextern.h (row_hash): Add prototype.
3868 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3870 * frame.c (delete_frame): Don't delete the terminal when the last
3871 X frame is closed if emacs is built with GTK toolkit.
3873 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3875 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3877 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3879 * window.c (Vwindow_splits): Rename to
3880 Vwindow_combination_resize. Suggested by Juri Linkov.
3881 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3884 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3886 * nsfns.m (Fns_font_name):
3887 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3889 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3891 * window.h (window): Rename slot "nest" to "combination_limit".
3892 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3893 (Fset_window_nest): Rename to Fset_window_combination_limit.
3894 (Vwindow_nest): Rename to Vwindow_combination_limit.
3895 (recombine_windows, make_parent_window, make_window)
3896 (Fsplit_window_internal, saved_window)
3897 (Fset_window_configuration, save_window_save): Rename all
3898 occurrences of window_nest to window_combination_limit.
3900 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3902 * image.c (imagemagick_load_image): Fix typo.
3904 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3906 * xdisp.c (display_line): Move the call to
3907 highlight_trailing_whitespace before the call to
3908 compute_line_metrics, since the latter needs to see the final
3909 faces of all the glyphs to compute ROW's hash value.
3910 Fixes assertion violations in row_equal_p. (Bug#10035)
3912 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3914 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3915 just return (bug#10044).
3917 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3919 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3920 with user-defined heap size. Bump the default size of the temacs
3921 heap to 27MB, to avoid memory warning when running temacs.
3922 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3924 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3925 current_matrix and desired_matrix. (Bug#9990)
3926 (verify_row_hash) [XASSERTS]: New function.
3927 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3928 that the hash value of glyph rows is correct.
3930 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3932 * window.h (window): Remove splits slot.
3933 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3934 (Fdelete_other_windows_internal, make_parent_window)
3935 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3936 (Fset_window_configuration, save_window_save): Don't deal with
3937 split status of windows.
3938 (saved_window): Remove splits slot.
3939 (Vwindow_splits): Rewrite doc-string.
3941 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3943 * xfns.c (unwind_create_frame):
3944 * nsfns.m (unwind_create_frame):
3945 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3946 Vframe_list (Bug#9999).
3948 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3950 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3952 2011-11-11 Kenichi Handa <handa@m17n.org>
3954 * callproc.c (Fcall_process): Set the member dst_multibyte of
3957 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3959 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3960 avoid a crash (bug#9496).
3962 2011-11-09 Chong Yidong <cyd@gnu.org>
3964 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3965 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3967 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3969 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3971 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3973 Avoid some portability problems by eschewing 'extern inline' functions.
3974 The trivial performance wins aren't worth the portability hassles; see
3975 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3977 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3978 (window_box_width, window_box_left, window_box_left_offset)
3979 (window_box_right, window_box_right_offset): Undo previous change,
3980 by removing the "extern"s.
3981 * intervals.c (adjust_intervals_for_insertion)
3982 (adjust_intervals_for_deletion): Undo previous change,
3983 making these static again.
3984 (offset_intervals, temp_set_point_both, temp_set_point)
3985 (copy_intervals_to_string): No longer inline.
3986 * xdisp.c (window_text_bottom_y, window_box_width)
3987 (window_box_height, window_box_left_offset)
3988 (window_box_right_offset, window_box_left, window_box_right)
3989 (window_box): No longer inline.
3991 2011-11-08 Chong Yidong <cyd@gnu.org>
3993 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3994 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3995 Signal an error if not a live window.
3996 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3997 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3999 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4001 * lisp.h (syms_of_abbrev): Remove declaration.
4002 Reported by CHENG Gao <chenggao@royau.me>.
4004 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4006 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4007 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4008 of temacs in GUI mode.
4010 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4012 * window.h: Declare delete_all_child_windows instead of
4013 delete_all_subwindows.
4014 * window.c (Fwindow_nest, Fset_window_nest)
4015 (Fset_window_new_total, Fset_window_new_normal)
4016 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4017 (delete_all_subwindows): Rename to delete_all_child_windows.
4018 (Fdelete_other_windows_internal, Fset_window_configuration):
4019 Call delete_all_child_windows instead of delete_all_subwindows.
4020 * frame.c (delete_frame): Call delete_all_child_windows instead
4021 of delete_all_subwindows.
4023 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4025 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4026 This is also needed for porting to any host where GC_MARK_STACK is
4027 not GC_MAKE_GCPROS_NOOPS.
4028 (which_symbols): Use it.
4030 2011-11-07 Kenichi Handa <handa@m17n.org>
4032 * coding.c (coding_set_destination): Check coding->src_pos only
4033 when coding->src_object is a buffer (bug#9910).
4035 * process.c (send_process): Set the member src_multibyte of coding
4036 to 0 (bug#9911) when sending a unibyte text.
4038 * callproc.c (Fcall_process): Set the member src_multibyte of
4039 process_coding to 0 (bug#9912).
4041 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4043 * xmenu.c (cleanup_widget_value_tree): New function.
4044 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4045 calling free_menubar_widget_value_tree directly (Bug#9830).
4047 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4049 Fix some portability problems with 'inline'.
4050 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4051 (window_box_width, window_box_left, window_box_left_offset)
4052 (window_box_right, window_box_right_offset): Declare extern.
4053 Otherwise, these inline functions do not conform to C99 and
4054 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4055 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4056 * intervals.c (adjust_intervals_for_insertion)
4057 (adjust_intervals_for_deletion): Now extern, because otherwise the
4058 extern inline functions 'offset_intervals' couldn't refer to it.
4059 (static_offset_intervals): Remove.
4060 (offset_intervals): Rewrite using the old contents of
4061 static_offset_intervals. The old version didn't conform to C99
4062 because an extern inline function contained a reference to an
4063 identifier with static linkage.
4065 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4067 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4070 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4072 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4073 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4074 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4075 return Qleft_to_right.
4077 2011-11-06 Chong Yidong <cyd@gnu.org>
4079 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4080 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4081 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4082 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4083 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4084 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4085 (Fwindow_vscroll): Doc fix.
4086 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4087 argument, since it makes no sense to pass a live window and for
4088 consistency with window-child.
4090 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4092 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4095 2011-11-05 Jason Rumney <jasonr@gnu.org>
4097 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4098 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4100 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4101 bitwise arithmetic preventing use of unicode-sip and non-truetype
4104 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4106 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4109 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4110 initialization code to keep similarity to xfns.c after changes
4113 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4115 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4116 (unwind_create_frame): New function (Bug#9943).
4117 (Fx_create_frame): Restructure code to be more similar to the one in
4118 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4119 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4120 Move terminal->reference_count++ just before making the frame official
4123 * nsterm.m (x_free_frame_resources): New function.
4124 (x_destroy_window): Move code to x_free_frame_resources.
4126 * xfns.c (unwind_create_frame): Fix comment.
4127 (Fx_create_frame, x_create_tip_frame):
4128 Move terminal->reference_count++ just before making the frame
4129 official. Move initialization of image_cache_refcount and
4130 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4132 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4134 Support MSVC build with newer versions of Visual Studio.
4135 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4136 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4139 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4140 which are not supported by MSVC.
4141 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4142 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4144 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4146 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4148 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4150 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4152 Support MSVC build with newer versions of Visual Studio.
4153 * w32.c: Don't include w32api.h for MSVC.
4154 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4156 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4157 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4158 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4159 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4161 (alloca) [_MSC_VER]: Define to _alloca.
4163 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4165 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4167 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4169 * xdisp.c (note_mouse_highlight): If either of
4170 previous/next-single-property-change returns nil, treat that as
4171 the beginning or the end of the buffer. (Bug#9955)
4173 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4175 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4176 label is not null (Bug#9951).
4177 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4180 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4182 * window.c (Fwindow_body_size): Mention in the doc string that the
4183 return value is in frame's canonical units. (Bug#9949)
4185 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4187 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4189 * w32fns.c (unwind_create_frame): If needed, free the glyph
4190 matrices of the partially constructed frame. (Bug#9943)
4191 * xfns.c (unwind_create_frame): Likewise.
4193 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4195 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4196 Don't stop backward scan on the continuation glyph, even though
4197 its CHARPOS is positive.
4198 (mouse_face_from_buffer_pos, note_mouse_highlight):
4199 Rename cover_string to disp_string.
4201 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4203 * window.c (temp_output_buffer_show): Don't use
4204 Vtemp_buffer_show_specifiers.
4205 (Vtemp_buffer_show_specifiers): Remove unused variable.
4207 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4209 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4210 past the beginning of the current glyph matrix.
4212 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4214 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4215 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4216 HAVE_GTK3 (Bug#9869).
4218 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4219 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4221 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4223 * xterm.c: Declare x_handle_net_wm_state to return int.
4224 (handle_one_xevent): Check if we are iconified but don't have
4225 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4226 (get_current_wm_state): Return non-zero if not hidden,
4227 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4228 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4229 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4230 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4232 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4234 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4235 so that this new function doesn't get optimized away by a
4236 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4238 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4240 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4242 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4244 Fix the `xbytecode' command.
4245 * .gdbinit (xprintbytestr): New command.
4246 (xwhichsymbols): Rename from `which'; all callers changed.
4247 (xbytecode): Print the byte-code string as well.
4249 2011-10-29 Kim Storm <storm@cua.dk>
4251 * alloc.c (which_symbols): New function.
4253 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4255 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4258 2011-10-29 Glenn Morris <rgm@gnu.org>
4260 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4261 Not clear what it was for, and it causes various bugs. (Bug#9839)
4263 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4265 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4266 possible random value that matches one of those tested as
4267 condition to clear the mouse face.
4269 2011-10-28 Chong Yidong <cyd@gnu.org>
4271 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4273 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4275 * window.c (make_window): Initialize phys_cursor_on_p.
4277 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4279 * lisp.h (struct Lisp_Symbol): Update comments.
4281 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4283 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4285 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4287 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4288 <oslsachem@gmail.com> for helping to debug this.
4290 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4291 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4292 (g_b_init_get_glyph_outline_w): New static variables.
4293 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4294 (GetGlyphOutlineW_Proc): New typedefs.
4295 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4296 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4298 (w32font_open_internal, compute_metrics):
4299 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4300 instead of calling the "wide" APIs directly.
4302 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4304 * w32.h (syms_of_w32font): Add prototype.
4306 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4308 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4309 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4310 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4311 (Fmove_to_window_line): Doc fix.
4313 2011-10-27 Chong Yidong <cyd@gnu.org>
4315 * process.c (make_process): Set gnutls_state to NULL.
4317 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4318 non-NULL, regardless of GNUTLS_INITSTAGE.
4319 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4320 an error. Set process slots as soon as we allocate them.
4322 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4324 2011-10-27 Chong Yidong <cyd@gnu.org>
4326 * gnutls.c (emacs_gnutls_deinit): New function.
4327 Deallocate credentials structures as well as calling gnutls_deinit.
4328 (Fgnutls_deinit, Fgnutls_boot): Use it.
4330 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4331 (deactivate_process): Call emacs_gnutls_deinit.
4333 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4335 * image.c (x_create_x_image_and_pixmap):
4336 * w32.c (sys_rename, w32_delayed_load):
4337 * w32font.c (fill_in_logfont):
4338 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4340 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4342 * w32fns.c (w32_default_color_map): New function,
4343 extracted from Fw32_default_color_map.
4344 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4346 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4348 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4350 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4352 * keyboard.c (test_undefined): New function (bug#9751).
4353 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4355 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4357 * sysdep.c (init_sys_modes): Fix the check for the controlling
4358 terminal (Bug#6649).
4360 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4362 * dispextern.h (struct bidi_it): New member next_en_type.
4364 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4365 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4366 current character, check also for next_en_type being WEAK_EN.
4367 (bidi_resolve_weak): Don't enter the expensive loop if the current
4368 position is before next_en_pos. Record the bidi type of the first
4369 non-ET, non-BN character we find, in addition to its position.
4370 (bidi_level_of_next_char): Invalidate next_en_type when
4371 next_en_pos is over-stepped.
4373 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4375 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4376 * editfns.c: Rewrite current-time-zone so that it invokes
4377 the equivalent of (format-time-string "%Z") to get the time zone name.
4378 This fixes a bug when the time zone name contains characters that
4379 need converting from the system time locale to Emacs internal format.
4380 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4381 that patch fixed format-time-string to do the conversion, but
4382 I forgot to fix current-time-zone.
4383 (format_time_string): New function, containing most of
4384 what Fformat_time_string used to contain.
4385 (Fformat_time_string): Rewrite in terms of format_time_string.
4386 This doesn't change this function's behavior.
4387 (current-time-zone): Rewrite to use format_time_string.
4388 This fixes the bug reported by Michael Schierl in
4389 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4390 Jason Rumney's 2007-06-07 change worked around this bug, but
4392 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4394 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4396 * xdisp.c (start_display): If the character at POS is displayed
4397 via a display vector, reset IT->current.dpvec_index to zero.
4398 (try_window_reusing_current_matrix): If a line ends in a display
4399 vector or the next line starts in a display vector, continue
4400 redrawing the window even though the character position of
4401 start_row was reached.
4404 2011-10-18 Chong Yidong <cyd@gnu.org>
4406 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4407 with nobreak-char-display too.
4409 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4411 Fix part 3 of bug#9771.
4412 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4413 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4414 non-neutral characters if the current character is a paragraph
4415 separator (a.k.a. Newline). This avoids running the same
4416 expensive loop twice, once when we consume the preceding newline
4417 and the other time when the line actually needs to be displayed.
4418 Avoid the loop when we see neutrals on the base embedding level
4419 following a character whose directionality is the same as the
4420 paragraph's. This avoids running the expensive loop when a line
4421 ends in a long sequence of neutrals, like control characters.
4422 Add assertion against STRONG_AL type. Slightly rearrange code
4423 that determines the type of a neutral given the first non-neutral
4425 (bidi_level_of_next_char): Set next_en_pos to zero when
4426 invalidating its info.
4428 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4430 * xdisp.c (push_display_prop): Determine whether to record string
4431 or buffer position by IT->string, not by IT->method. Allow
4432 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4433 (move_it_vertically_backward): Don't look for character position
4434 immediately after the newline when in a continuation line.
4437 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4439 * window.c (coordinates_in_window): Rewrite and delabelize
4440 vertical border check. (Bug#5357) (Bug#9618)
4442 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4444 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4445 errors in XSetWindowBorder (bug#9310).
4447 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4449 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4450 avoid crash when xmalloc overrun checking is enabled.
4452 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4454 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4455 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4456 cursor motion with <left> and <right> arrow keys.
4458 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4459 some callers set that themselves.
4461 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4463 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4464 display string and the previous row comes from the same string and
4465 is empty. (Bug#9739) (Bug#9738)
4467 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4469 * doc.c (get_doc_string): Encode file name (bug#9735).
4471 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4473 * bidi.c (bidi_level_of_next_char):
4474 * xdisp.c (get_visually_first_element): Remove old incorrect
4475 comments regarding the Unicode Line Separator character.
4477 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4479 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4481 * alloc.c (Fgc_status): Do not access beyond zombies array
4482 boundary if nzombies > MAX_ZOMBIES.
4483 * alloc.c (dump_zombies): Add missing format specifier.
4485 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4487 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4488 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4490 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4491 Some packages use them to denote characters with modifiers.
4493 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4495 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4496 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4497 matching a pp-number. Rename parameter var to var1.
4499 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4501 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4503 2011-10-08 Glenn Morris <rgm@gnu.org>
4505 * callint.c (Fcall_interactively): Give a more explicit error for the
4506 'c' case with a non-character input. (Bug#8479)
4508 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4510 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4512 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4513 lines that are hscrolled on the left.
4515 * dispnew.c (buffer_posn_from_coords): Account for a possible
4516 presence of header-line. (Bug#4426)
4518 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4520 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4521 Don't advertise functionality which we discourage or doesn't work.
4523 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4525 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4526 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4527 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4528 this makes Emacs dump core during garbage collection on rare
4529 occasions. sizeof is obviously inferior to offsetof here, so
4530 stick with offsetof.
4531 (GC_POINTER_ALIGNMENT): New macro.
4532 (mark_memory): Omit 3rd (offset) arg; caller changed.
4533 Don't assume EMACS_INT alignment is the same as pointer alignment.
4535 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4537 * keyboard.c (read_key_sequence_remapped): New var.
4538 (read_key_sequence): Compute remapping in the right buffer.
4539 (command_loop_1): Use read_key_sequence's remapping directly.
4541 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4543 * dired.c (file_name_completion): Don't expand file name.
4544 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4545 before checking file name handler.
4547 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4548 they've been requested explicitly (bug#9591).
4550 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4552 * keymap.c (Fsingle_key_description): Use make_specified_string
4553 instead of build_string to build string from push_key_description.
4556 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4558 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4559 This fixes a Y2038 bug on 64-bit hosts.
4560 * buffer.c (reset_buffer):
4561 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4562 (Fclear_buffer_auto_save_failure):
4563 Use 0, not -1, to represent an unset failure time, since time_t
4564 might not be signed.
4566 Remove dependency on glibc malloc internals.
4567 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4568 Move back here from lisp.h, but with their new implementations.
4569 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4570 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4571 * charset.c (charset_table_init): New static var.
4572 (syms_of_charset): Use it instead of xmalloc. This removes a
4573 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4574 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4575 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4576 Move back to alloc.c.
4577 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4578 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4580 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4582 * nsterm.m (windowDidResize): Call x_set_window_size only when
4583 ns_in_resize is true. Otherwise set pixelwidth/height and
4584 call change_frame_size (Bug#9628).
4586 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4588 Port --enable-checking=all to Fedora 14 x86-64.
4589 * charset.c (syms_of_charset): Also account for glibc malloc's
4590 internal overhead when calculating the initial malloc maximum.
4592 Port --enable-checking=all to Fedora 14 x86.
4593 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4595 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4596 (overrun_check_realloc, overrun_check_free):
4597 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4598 That way, xmalloc returns a properly-aligned pointer even if
4599 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4600 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4601 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4602 into account when calculating the initial malloc maximum.
4603 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4604 Move here from alloc.c, so that charset.c can use it too.
4605 Properly align; the old code wasn't right for common 32-bit hosts
4606 when configured with --enable-checking=all.
4607 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4608 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4610 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4612 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4615 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4617 * xdisp.c (compute_display_string_end): If there's no display
4618 string at CHARPOS, return -1.
4620 * bidi.c (bidi_fetch_char): When compute_display_string_end
4621 returns a negative value, treat the character as a normal
4622 character not covered by a display string. (Bug#9624)
4624 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4626 * lread.c (Fread_from_string): Fix typo in docstring.
4628 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4630 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4631 newline, reseat the iterator instead of bidi-iterating there one
4632 character at a time. (Bug#9610)
4633 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4634 TO_CHARPOS if the bidi iterator is at base embedding level.
4636 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4638 * lread.c (readevalloop): Use correct code for NBSP.
4639 (read1): Likewise. (Bug#9608)
4641 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4643 * dbusbind.c (Fdbus_register_signal): When service is not
4644 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4646 2011-09-25 Glenn Morris <rgm@gnu.org>
4648 * buffer.c (truncate-lines): Doc fix.
4650 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4652 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4653 (Fset_window_next_buffers): Doc fix.
4655 2011-09-24 Glenn Morris <rgm@gnu.org>
4657 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4659 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4661 Fix minor problems found by static checking.
4662 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4663 * indent.c (Fvertical_motion): Fix == vs = typo.
4665 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4667 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4668 Default value is now t. Doc fix.
4670 * indent.c (Fvertical_motion): Compute and apply the overshoot
4671 logic when moving up, not only when moving down. Fix the
4672 confusing name and values of the it_overshoot_expected variable;
4673 logic changes accordingly. (Bug#9254) (Bug#9549)
4675 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4676 CHARPOS is covered by a display string which includes newlines.
4677 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4678 is covered by a display string with embedded newlines.
4680 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4682 * dbusbind.c (Fdbus_register_signal): Add match rule to
4683 Vdbus_registered_objects_table. (Bug#9581)
4684 (Fdbus_register_method, Vdbus_registered_objects_table):
4687 2011-09-24 Jim Meyering <meyering@redhat.com>
4689 do not ignore write error for any output size
4690 The previous change was incomplete.
4691 While it makes emacs --batch detect the vast majority of stdout
4692 write failures, errors were still ignored whenever the output size is
4693 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4694 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4695 && echo FAIL: ignored write error
4696 FAIL: ignored write error
4697 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4698 && echo FAIL: ignored write error
4699 FAIL: ignored write error
4700 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4702 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4704 * emacs.c (Fkill_emacs): In noninteractive mode exit
4705 non-successfully if a write error occurred on stdout. (Bug#9574)
4707 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4709 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4712 * dispextern.h (struct it): Update the comment documenting what
4715 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4717 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4718 a display string, extend search for cursor position to end of row.
4719 (find_row_edges): If the row ends in a newline from a display
4720 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4721 Handle the case of a display string with multiple newlines.
4722 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4723 non-empty line. Fixes confusing cursor motion with arrow keys at
4724 the beginning of a line that starts with whitespace.
4726 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4728 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4731 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4733 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4736 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4738 * xdisp.c (display_line): Record maximum and minimum buffer
4739 positions even if no glyphs were produced (e.g., by a zero-width
4740 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4741 buffer positions that will be removed from the glyph row because
4743 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4744 column is beyond frame width: don't subtract 1 "pixel" when
4745 computing width of the stretch.
4746 (reseat_at_next_visible_line_start): Undo the change made on
4747 2011-09-17 that saved paragraph information and restored it after
4748 the call to `reseat'. (Bug#9545)
4750 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4752 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4753 and turn window cursor on if cleared (Bug#9415).
4755 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4757 * search.c (boyer_moore): Take unibyte characters from pattern
4758 literally. (Bug#9458)
4760 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4762 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4764 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4766 Fix minor problem found by static checking.
4767 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4768 initialized, to pacify gcc -Wuninitialized.
4770 * fileio.c: Report proper errno when syscall falls.
4771 (Finsert_file_contents): Save and restore errno,
4772 so that report_file_error outputs the correct diagnostic.
4773 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4775 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4777 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4779 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4781 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4782 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4784 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4786 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4787 about the current paragraph and restore it after the call to reseat.
4789 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4790 (bidi_find_paragraph_start): Search back for paragraph beginning
4791 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4792 (bidi_move_to_visually_next): Only trigger paragraph-related
4793 computations when the last character is a newline or at EOB, not
4794 just any NEUTRAL_B. (Bug#9470)
4796 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4797 truncated lines if point is covered by a display string. (Bug#9524)
4799 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4801 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4802 (cons_to_x_long): New function.
4803 (lisp_data_to_selection_data): Use it. Correct the test for
4804 short-versus-long data; it was negated. Break out of vector
4805 loop, for efficiency, when a long datum is discovered.
4807 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4809 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4811 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4813 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4814 GCC PR/17406) by declaring this function with external scope.
4816 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4818 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4819 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4821 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4823 * editfns.c (Fformat): Correctly handle text properties on "%%".
4825 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4827 * xterm.c (x_draw_composite_glyph_string_foreground):
4828 * w32term.c (x_draw_composite_glyph_string_foreground):
4829 * term.c (encode_terminal_code):
4830 * composite.c (composition_update_it, get_composition_id):
4831 * xdisp.c (get_next_display_element)
4832 (fill_composite_glyph_string): Add comments about special meaning
4833 of TAB characters in a composition.
4835 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4837 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4838 This occurs when processing a multibyte format.
4839 Problem reported by Wolfgang Jenker.
4841 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4843 * xdisp.c (try_cursor_movement): Only check for exact match if
4844 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4846 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4848 Remove unused external symbols.
4849 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4850 * xdisp.c (calc_pixel_width_or_height): Now static.
4851 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4852 * indent.c (check_display_width):
4853 * w32term.c: Fix comment to match code.
4854 * xterm.c, xterm.h (x_catching_errors): Remove.
4856 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4858 * xselect.c: Use signed conversions more consistently (Bug#9498).
4859 (selection_data_to_lisp_data): Assume incoming selection data are
4860 signed integers, not unsigned. This is to be consistent with
4861 outgoing selection data, which was modified to use signed integers
4862 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4863 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4864 expects long, not unsigned long.
4866 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4868 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4869 computation of loop end. Reported by Johan Bockgård
4872 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4874 * frame.c (Fother_visible_frames_p): Function deleted.
4876 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4878 * indent.c (compute_motion): Process display vector front to back
4879 rather than the other way around. (Bug#2496)
4881 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4883 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4885 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4887 * minibuf.c (Fread_from_minibuffer): Doc fix.
4889 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4891 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4892 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4894 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4896 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4897 value for non-existent files.
4899 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4901 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4902 set its "size" to -1. This will set the modtime_size field of
4903 the corresponding buffer to -1, which is what
4904 verify-visited-file-modtime expects for files that do not exist.
4907 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4909 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4911 * lisp.h: ... from here. push_key_description is no longer
4912 defined in keyboard.c, so its declaration should not be in
4913 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4914 logically belongs with push_key_description.
4916 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4918 * buffer.h: Include <sys/types.h> instead of <time.h>.
4919 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4920 Problem reported by Herbert J. Skuhra.
4922 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4924 * xml.c (parse_region): Make the parsing work for
4925 non-comment-starting XML files again (bug#9144).
4927 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4929 * image.c (gif_load): Fix calculation of bottom and right corner.
4932 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4934 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4935 redisplay in small windows.
4937 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4939 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4941 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4943 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4944 Operate on live windows only.
4946 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4948 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4950 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4952 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4953 only under bidi iteration.
4955 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4957 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4959 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4961 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4962 Without this fix, the command to link temacs failed due to an
4963 undefined symbol __builtin_isnan. This is because
4964 /usr/include/iso/math_c99.h #defines isnan(x) to
4965 __builtin_isnan(x), but the bundled gcc, which identifies itself
4966 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4968 * floatfns.c (isnan): #undef, and then #define to a clone of
4970 (Fisnan): Always define, since it's always available now.
4971 (syms_of_floatfns): Always define isnan at the Lisp level.
4973 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4975 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4977 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4979 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4980 The previous code assumed that file offsets (off_t values) fit in
4981 EMACS_INT variables, which is not true on typical 32-bit hosts.
4982 The code messed up by falsely reporting buffer overflow in cases
4983 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4984 when "big" contains more than 2**29 bytes, even though this
4985 inserts just one byte and does not overflow the buffer.
4986 (Finsert_file_contents): Store file offsets as off_t
4987 values, not as EMACS_INT values. Check for overflow when
4988 converting between EMACS_INT and off_t. When checking for
4989 buffer overflow or for overlap, take the offsets into account.
4990 Don't use EMACS_INT for small values where int suffices.
4991 When checking for overlap, fix a typo: ZV was used where
4992 ZV_BYTE was intended.
4993 (Fwrite_region): Don't assume off_t fits into 'long'.
4994 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4996 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4998 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5000 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5002 sprintf-related integer and memory overflow issues (Bug#9412).
5004 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5005 (esprintf, exprintf, evxprintf): New functions.
5006 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5007 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5008 (modify_event_symbol): Do not assume that the length of
5009 name_alist_or_stem is safe to alloca and fits in int.
5010 (Fexecute_extended_command): Likewise for function name and binding.
5011 (Frecursion_depth): Wrap around reliably on integer overflow.
5012 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5013 since some callers pass EMACS_INT values.
5014 (Fsingle_key_description): Don't crash if symbol name contains more
5015 than MAX_ALLOCA bytes.
5016 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5017 (get_minibuffer): Arg is now EMACS_INT, not int.
5018 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5019 (esprintf, exprintf, evxprintf): New decls.
5020 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5022 * dbusbind.c (signature_cat): New function.
5023 (xd_signature, Fdbus_register_signal):
5024 Do not overrun buffer; instead, report string overflow.
5026 * dispnew.c (add_window_display_history): Don't overrun buffer.
5027 Truncate instead; this is OK since it's just a log.
5029 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5030 even if the time zone offset is outlandishly large.
5031 Don't mishandle offset == INT_MIN.
5033 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5034 when creating daemon; the previous buffer-overflow check was incorrect.
5036 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5037 which has the guts of the old verror function.
5039 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5040 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5042 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5043 (font_unparse_xlfd): Don't blindly alloca long strings.
5044 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5045 fits in int, when using sprintf. Use single snprintf to count
5046 length of string rather than counting it via multiple sprintfs;
5047 that's simpler and more reliable.
5048 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5049 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5050 sprintf, in case result does not fit in int.
5052 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5053 (fontset_from_font): Print it.
5055 * frame.c (tty_frame_count): Now printmax_t, not int.
5056 (make_terminal_frame, set_term_frame_name): Print it.
5057 (x_report_frame_params): In X, window IDs are unsigned long,
5058 not signed long, so print them as unsigned.
5059 (validate_x_resource_name): Check for implausibly long names,
5060 and don't assume name length fits in 'int'.
5061 (x_get_resource_string): Don't blindly alloca invocation name;
5062 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5065 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5066 (xg_check_special_colors, xg_set_geometry):
5067 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5069 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5070 Use esprintf, not sprintf, in case result does not fit in int.
5072 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5073 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5074 it as a large positive number.
5075 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5076 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5078 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5079 in case result does not fit in int.
5081 * print.c (float_to_string): Detect width overflow more reliably.
5082 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5083 buffer overrun. Don't assume list length fits in 'int'. Treat
5084 print length of 0 as 0, not as infinity; to be consistent with other
5085 uses of print length in this function. Don't overflow print length
5086 index. Don't assume hash table size fits in 'long', or that
5087 vectorlike size fits in 'unsigned long'.
5089 * process.c (make_process): Use printmax_t, not int, to format
5090 process-name gensyms.
5092 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5094 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5095 to avoid potential buffer overrun.
5097 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5098 if X resource line is longer than 512 bytes.
5100 * xfns.c (x_window): Make sprintf buffer a bit bigger
5101 to avoid potential buffer overrun.
5103 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5105 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5107 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5109 Integer overflow fixes for scrolling, etc.
5110 Without these, Emacs silently mishandles large integers sometimes.
5111 For example, "C-u 4294967297 M-x recenter" was treated as if
5112 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5114 * xdisp.c (try_window_id): Check Emacs fixnum range before
5115 converting to 'int'.
5117 * window.c (window_scroll_line_based, Frecenter):
5118 Check that an Emacs fixnum is in range before assigning it to 'int'.
5119 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5120 values converted from Emacs fixnums.
5121 (Frecenter): Don't wrap around a line count if it is out of 'int'
5122 range; instead, treat it as an extreme value.
5123 (Fset_window_configuration, compare_window_configurations):
5124 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5126 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5127 that can exceed INT_MAX. Check that EMACS_INT value is in range
5128 before assigning it to the (possibly-narrower) index.
5129 (match_limit): Don't assume that a fixnum can fit in 'int'.
5131 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5134 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5135 (Fvertical_motion): Don't wrap around LINES values that don't fit
5136 in 'int'. Instead, treat them as extreme values. This is good
5137 enough for windows, which can't have more than INT_MAX lines anyway.
5139 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5141 * Require libxml/parser.h to avoid compilation warning.
5143 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5145 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5146 since this reportedly can destroy thread storage.
5148 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5150 * syntax.c (find_defun_start): Update all cache variables if
5151 exiting early (Bug#9401).
5153 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5155 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5157 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5158 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5159 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5161 * term.c (tty_append_glyph): New function.
5162 (produce_stretch_glyph): Static function and its prototype deleted.
5164 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5167 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5169 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5170 when checking :margin (Bug#9390).
5171 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5172 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5173 so that the name doesn't mislead. All uses changed.
5175 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5177 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5180 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5182 * xdisp.c (move_it_to): Don't bail out early when reaching
5183 position beyond to_charpos, if we are scanning backwards.
5184 (move_it_vertically_backward): When DY == 0, make sure we get to
5185 the first character in the line after the newline.
5187 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5189 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5190 (ccl_driver): Do not generate an out-of-range pointer.
5191 (Fccl_execute_on_string): Remove unnecessary check for
5192 integer overflow, noted by Stefan Monnier in
5193 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5194 Remove a FIXME that didn't need fixing.
5195 Simplify the newly-introduced buffer reallocation code.
5197 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5199 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5201 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5203 Integer and memory overflow issues (Bug#9196).
5205 * doc.c (get_doc_string): Rework so that
5206 get_doc_string_buffer_size is the actual buffer size, rather than
5207 being 1 less than the actual buffer size; this makes xpalloc more
5210 * image.c (x_allocate_bitmap_record, cache_image):
5211 * xselect.c (Fx_register_dnd_atom):
5212 Simplify previous changes by using xpalloc.
5214 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5215 since either will do and ptrdiff_t is convenient with xpalloc.
5217 * charset.c (charset_table_size)
5218 (struct charset_sort_data.priority): Now ptrdiff_t.
5219 (charset_compare): Don't overflow if priorities differ greatly.
5220 (Fsort_charsets): Don't assume list length fits in int.
5221 Check for size-calculation overflow when allocating sort data.
5222 (syms_of_charset): Allocate an initial charset table that is
5223 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5225 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5227 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5228 The actual value is always <= INT_MAX, and leaving it unsigned made
5229 overflow checking harder.
5231 * dispextern.h (struct glyph_matrix.rows_allocated)
5232 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5233 with xpalloc. The values are still always <= INT_MAX.
5235 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5237 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5238 (SAFE_NALLOCA): New macro.
5240 * region-cache.c (struct boundary.pos, find_cache_boundary)
5241 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5242 (set_cache_region, invalidate_region_cache)
5243 (revalidate_region_cache, know_region_cache, region_cache_forward)
5244 (region_cache_backward, pp_cache):
5245 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5246 so that ptrdiff_t * can be passed to xpalloc.
5247 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5248 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5249 (pp_cache): Don't assume cache_len fits in int.
5250 * region-cache.h: Adjust extern decls to match.
5252 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5253 EMACS_INT, since either will do, for xpalloc.
5255 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5256 (xnmalloc, xnrealloc, xpalloc): New functions.
5258 * bidi.c (bidi_shelve_header_size): New constant.
5259 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5260 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5262 * bidi.c (bidi_cache_shrink):
5263 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5265 Don't update size of array until after memory allocation succeeds,
5266 because xmalloc/xrealloc may not return.
5267 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5268 now that we have proper integer overflow checking.
5269 (record_overlay_string, overlay_strings): Catch overflows when
5270 calculating size of overlay_str_buf.
5272 * callproc.c (Fcall_process): Check for size overflow when
5273 calculating size of args2.
5274 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5275 Normally we prefer signed values, but sticking with ptrdiff_t would
5276 require adding more-complicated checks.
5278 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5279 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5280 Redo buffer-overflow calculations to avoid integer overflow.
5281 Add a FIXME comment where memory seems to be over-allocated.
5283 * character.c (Fstring): Check for size-calculation overflow.
5285 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5286 unnecessary integer overflow. Check for size overflow.
5287 (encode_coding_object): Don't update size until xmalloc succeeds.
5289 * composite.c (get_composition_id): Check for overflow in glyph
5290 length calculations.
5292 Integer and memory overflow fixes for display code.
5293 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5294 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5295 (scrolling_window): Check for overflow in size calculations.
5296 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5297 Don't assume glyph table len fits in int.
5298 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5299 (row_table_size): Now ptrdiff_t, not int.
5300 (scrolling_window): Avoid overflow in size calculations.
5301 Don't update size until allocation succeeds.
5302 * fns.c (concat): Check for overflow in size calculations.
5303 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5304 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5305 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5307 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5308 (get_doc_string): Check for size calculation overflow.
5309 Don't update size until allocation succeeds.
5310 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5311 EMACS_INT, where ptrdiff_t will do.
5312 (Fsubstitute_command_keys): Check for string overflow.
5314 * editfns.c (set_time_zone_rule): Don't assume environment length
5316 (message_length): Now ptrdiff_t, not int.
5317 (Fmessage_box): Don't update size until allocation succeeds.
5318 Don't assume message length fits in int.
5319 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5321 * emacs.c (main): Do not reallocate argv, since there is a null at
5322 the end that can be overwritten, and this way there's no need to
5323 worry about size-calculation overflow.
5324 (sort_args): Check for size-calculation overflow.
5326 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5328 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5330 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5331 (x_set_scroll_bar_width, x_figure_window_size):
5332 Check for integer overflow.
5333 (x_set_alpha): Do not assume XINT fits in int.
5335 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5336 This is for the members text_lines, text_cols, total_lines, total_cols,
5337 where the system imposes an 'int' limit.
5339 * fringe.c (Fdefine_fringe_bitmap):
5340 Don't update size until alloc works.
5342 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5343 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5345 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5346 Check for size-calculation overflow.
5347 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5348 do, as we prefer signed integers.
5349 (id_to_widget.max_size, id_to_widget.used)
5350 (xg_store_widget_in_map, xg_remove_widget_from_map)
5351 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5352 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5353 Use and return ptrdiff_t, not int.
5354 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5355 * gtkutil.h: Change prototypes to match the above.
5357 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5358 are duplicate now that they've been promoted to lisp.h.
5359 (x_allocate_bitmap_record, x_alloc_image_color)
5360 (make_image_cache, cache_image, xpm_load):
5361 Don't update size until alloc is done.
5362 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5364 Check for size calculation overflow.
5365 (ct_colors_allocated_max): New constant.
5366 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5369 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5370 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5371 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5372 Use ptrdiff_t, not int, to count maps.
5373 (read_char_minibuf_menu_prompt): Check for overflow in size
5374 calculations. Don't update size until allocation succeeds.
5375 Redo calculations to avoid overflow.
5376 * keyboard.h: Change prototypes to match the above.
5378 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5380 (current_minor_maps): Check for size calculation overflow.
5381 * keymap.h: Change prototypes to match the above.
5383 * lread.c (read1, init_obarray): Don't update size until alloc done.
5385 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5386 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5388 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5389 Now ptrdiff_t, not int.
5390 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5391 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5393 * process.c (Fnetwork_interface_list): Check for overflow
5394 in size calculation.
5396 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5398 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5399 overflow. Don't bother calling xmalloc when xrealloc will do.
5401 * search.c (Freplace_match): Check for size calculation overflow.
5402 (Fset_match_data): Don't assume list lengths fit in 'int'.
5404 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5405 for command line length. Do not attempt to address one before the
5406 beginning of an array, as that's not portable.
5408 * term.c (max_frame_lines): Remove; unused.
5409 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5411 (encode_terminal_code, calculate_costs): Check for size
5412 calculation overflow.
5413 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5414 table lengths and related sizes. Don't update size until alloc
5415 done. Redo calculations to avoid overflow.
5416 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5418 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5419 subtracting pointers.
5420 (gobble_line): Check for overflow more carefully. Don't update size
5423 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5424 Don't update size until alloc done.
5425 Redo size calculations to avoid overflow.
5426 Check for size calculation overflow.
5427 (main) [DEBUG]: Fix typo in invoking tparam1.
5429 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5430 Use ptrdiff_t, not int, for sizes.
5431 (store_mode_line_noprop_char): Don't update size until alloc done.
5433 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5434 Use ptrdiff_t, not int, for sizes.
5435 (Finternal_make_lisp_face, cache_face):
5436 Check for size calculation overflow.
5437 (cache_face): Treat size calculation overflows as if they were
5438 memory exhaustion (the usual treatment), rather than aborting.
5440 * xfns.c (x_encode_text, x_set_name_internal)
5441 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5442 sizes, since they can exceed INT_MAX in size. Check for size
5443 calculation overflow.
5445 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5446 (xg_select): Check for size calculation overflow.
5447 Don't update size until alloc done.
5449 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5450 as sprintf is limited to int lengths.
5452 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5453 (X_LONG_MIN): New macros.
5454 Use them to make the following changes clearer.
5455 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5456 This change doesn't affect the value now, but it may help remind
5457 future maintainers not to raise the value too much later.
5458 (SELECTION_QUANTUM): Remove, replacing with ...
5459 (selection_quantum): ... new function, which avoids overflow.
5461 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5462 assumption that selection length fits in 'int'.
5463 (x_reply_selection_request, x_handle_selection_request)
5464 (x_get_window_property, receive_incremental_selection)
5465 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5466 (lisp_data_to_selection_data, clean_local_selection_data):
5467 Use ptrdiff_t, not int, to record length of selection.
5468 (x_reply_selection_request, x_get_window_property)
5469 (receive_incremental_selection, x_property_data_to_lisp):
5470 Redo calculations to avoid overflow.
5471 (x_reply_selection_request): When sending hint, ceiling it at
5472 X_LONG_MAX rather than relying on wraparound overflow to send
5474 (x_get_window_property, receive_incremental_selection)
5475 (lisp_data_to_selection_data, x_property_data_to_lisp):
5476 Check for size-calculation overflow.
5477 (x_get_window_property, receive_incremental_selection)
5478 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5479 Don't store size until memory allocation succeeds.
5480 (x_get_window_property): Plug memory leak on memory exhaustion.
5481 Don't double-block input; malloc is safe here. Don't assume 2**34
5482 - 4 fits in unsigned long. Add an xassert to check
5483 XGetWindowProperty overflow. Be more careful about overflow
5484 calculations, and distinguish size from memory overflow better.
5485 (receive_incremental_selection): When tracing, don't assume
5486 unsigned int is less than INT_MAX.
5487 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5488 harmful) conversions of unsigned short to int.
5489 (lisp_data_to_selection_data): Don't assume that integers
5490 in the range -65535 through -1 fit in an X unsigned short.
5491 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5492 result parameters unless successful. Rely on cons_to_unsigned
5493 to report problems with elements; the old code wasn't right anyway.
5494 (x_check_property_data): Check for int overflow; we cannot use
5495 a wider type due to X limits.
5496 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5498 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5500 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5501 (x_term_init): Check for size calculation overflow.
5502 (x_color_cells): Don't store size until memory allocation succeeds.
5503 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5504 Don't assume alloca size is less than MAX_ALLOCA.
5505 (x_term_init): Don't assume length fits in int (sprintf is limited
5508 Use ptrdiff_t for composition IDs.
5509 * character.c (lisp_string_width):
5510 * composite.c (composition_table_size, n_compositions)
5511 (get_composition_id, composition_gstring_from_id):
5512 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5513 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5514 * window.c (Frecenter):
5515 Use ptrdiff_t, not int, for composition IDs.
5516 * composite.c (get_composition_id): Check for integer overflow.
5517 * composite.h: Adjust prototypes to match the above changes.
5519 Use ptrdiff_t for hash table indexes.
5520 * category.c (hash_get_category_set):
5521 * ccl.c (ccl_driver):
5522 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5523 * coding.c (coding_system_charset_list, detect_coding_system):
5524 * coding.h (struct coding_system.id):
5525 * composite.c (get_composition_id, gstring_lookup_cache):
5526 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5527 * image.c (xpm_get_color_table_h):
5528 * lisp.h (hash_lookup, hash_put):
5529 * minibuf.c (Ftest_completion):
5530 Use ptrdiff_t for hash table indexes, not int (which is too
5531 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5532 32-bit --with-wide-int hosts).
5534 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5535 Add a FIXME comment about memory leaks.
5536 (syms_of_charset): Don't assume xmalloc returns.
5538 Don't assume that stated character widths fit in int.
5539 * character.c (Fchar_width, c_string_width, lisp_string_width):
5540 * character.h (CHAR_WIDTH):
5541 * indent.c (MULTIBYTE_BYTES_WIDTH):
5542 Use sanitize_char_width to avoid undefined and/or bad behavior
5543 with outlandish widths.
5544 * character.h (sanitize_tab_width): Rename from sanitize_width,
5545 now that we have two such functions. All uses changed.
5546 (sanitize_char_width): New inline function.
5548 Don't assume that tab-width fits in int.
5549 * character.h (sanitize_width): New inline function.
5550 (SANE_TAB_WIDTH): New macro.
5551 (ASCII_CHAR_WIDTH): Use it.
5552 * indent.c (sane_tab_width): Remove. All uses replaced by
5553 SANE_TAB_WIDTH (current_buffer).
5554 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5556 * fileio.c: Integer overflow issues with file modes.
5557 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5559 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5560 Remove unreachable code.
5561 (read_hex, load_charset_map_from_file): Check for integer overflow.
5563 * xterm.c: Don't go over XClientMessageEvent limit.
5564 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5565 (x_send_scroll_bar_event): Likewise. Check that the size does not
5566 exceed limits imposed by XClientMessageEvent, as well as the usual
5567 ptrdiff_t and size_t limits.
5569 * keyboard.c: Overflow, signedness and related fixes.
5570 (make_lispy_movement): Use same integer type in forward decl
5571 that is used in the definition.
5572 (read_key_sequence, keyremap_step):
5573 Change bufsize argument back to int, undoing my 2011-03-30 change.
5574 We prefer signed types, and int is wide enough here.
5575 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5576 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5577 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5578 length, not size_t. Use ptrdiff_t for index, not int.
5579 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5580 possibility of integer overflow.
5582 Overflow, signedness and related fixes for images.
5584 * dispextern.h (struct it.stack[0].u.image.image_id)
5585 (struct_it.image_id, struct image.id, struct image_cache.size)
5586 (struct image_cache.used, struct image_cache.ref_count):
5587 * gtkutil.c (update_frame_tool_bar):
5588 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5589 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5590 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5591 * nsmenu.m (update_frame_tool_bar):
5592 * xdisp.c (calc_pixel_width_or_height):
5593 * xfns.c (image_cache_refcount):
5594 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5595 on typical 64-bit hosts.
5597 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5598 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5599 Omit unnecessary casts to int.
5600 (parse_image_spec): Check that integers fall into 'int' range
5601 when the callers expect that.
5602 (image_ascent): Redo ascent calculation to avoid int overflow.
5603 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5604 (lookup_image): Remove unnecessary tests.
5605 (xbm_image_p): Locals are now of int, not EMACS_INT,
5606 since parse_image_check makes sure they fit into int.
5607 (png_load, gif_load, svg_load_image):
5608 Prefer int to unsigned where either will do.
5609 (tiff_handler): New function, combining the cores of the
5610 old tiff_error_handler and tiff_warning_handler.
5611 This function is rewritten to use vsnprintf and thereby avoid
5612 stack buffer overflows. It uses only the features of vsnprintf
5613 that are common to both POSIX and native Microsoft.
5614 (tiff_error_handler, tiff_warning_handler): Use it.
5615 (tiff_load, gif_load, imagemagick_load_image):
5616 Don't assume :index value fits in 'int'.
5617 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5618 (imagemagick_load_image): Check that crop parameters fit into
5619 the integer types that MagickCropImage accepts. Don't assume
5620 Vimagemagick_render_type has a nonnegative value. Don't assume
5621 size_t fits in 'long'.
5622 (gs_load): Use printmax_t to print the widest integers possible.
5623 Check for integer overflow when computing image height and width.
5625 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5627 * xdisp.c (redisplay_window): Don't force window start if point
5628 will be invisible in the resulting window. (Bug#9324)
5630 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5632 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5633 the display spec is of the form `(space ...)'.
5634 (handle_display_spec): Return the value returned by
5635 handle_single_display_spec, not just 1 or zero.
5636 (handle_single_display_spec): If the display spec is of the form
5637 `(space ...)', and specifies display in the text area, return 2
5639 (try_cursor_movement): Check for the need to scroll more
5640 accurately, and prefer exact match for point under bidi.
5641 Don't advance `row' beyond the last row of the window.
5643 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5644 into disp_prop; all users changed.
5646 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5647 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5648 for the text covered by the display property.
5650 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5652 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5653 Change return value to nil.
5654 (Frecord_buffer): Delete unused function.
5656 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5658 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5659 buffers, return left-to-right.
5660 (set_cursor_from_row): Consider candidate row a win if its glyph
5661 represents a newline and point is on that newline. Fixes cursor
5662 positioning on the newline at EOL of R2L text within L2R
5663 paragraph, and vice versa.
5664 (try_cursor_movement): Check continued rows, in addition to
5665 continuation rows. Fixes unwarranted scroll when point enters a
5666 continued line of R2L text within an L2R paragraph, or vice versa.
5667 (cursor_row_p): Consider the case of point being equal to
5668 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5669 from the end of a short line to the beginning of a continued line
5670 of R2L text within L2R paragraph.
5671 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5672 composed characters.
5674 * bidi.c (bidi_check_type): Use xassert.
5675 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5678 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5680 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5683 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5685 * nsfont.m (ns_otf_to_script): Fix typo.
5687 2011-08-22 Kenichi Handa <handa@m17n.org>
5689 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5690 extra slot even if the purpose is char-code-property-table.
5692 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5694 * xdisp.c (redisplay_window): When computing centering_position,
5695 account for the height of the header line. (Bug#8874)
5697 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5698 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5699 candidate is selected by the mouse, and that candidate has a
5700 composed character under the mouse.
5702 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5703 coordinates reported by pos-visible-in-window-p for a composed
5704 character in column zero.
5706 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5708 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5710 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5712 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5713 consider it a hit if to_charpos is anywhere in the range of the
5714 composed buffer positions.
5716 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5718 * image.c (gif_load): Don't assume that each subimage has the same
5719 dimensions as the base image. Handle disposal method that is
5720 "undefined" by the gif spec (Bug#9335).
5722 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5724 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5725 (Fcondition_case): Document `debug' symbol in error handler.
5727 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5729 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5730 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5731 from an Org mode buffer to a Speedbar frame.
5733 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5734 a composition, take its buffer position from IT->cmp_it.charpos.
5735 Fixes cursor positioning at the beginning of a line that begins
5736 with a composed character.
5738 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5740 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5741 character bidirectional type, use STRONG_L instead. Fixes crashes
5742 in a buffer produced by `describe-categories'.
5744 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5745 members before the level stack, so they would be saved and
5746 restored when copying iterator state. Fixes incorrect reordering
5747 around TABs covered by display properties.
5749 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5751 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5753 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5755 * eval.c (internal_condition_case, internal_condition_case_1)
5756 (internal_condition_case_2, internal_condition_case_n):
5757 Remove unnecessary aborts (Bug#9081).
5759 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5761 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5762 has no `load' handler, try opening the file locally. (Bug#9311)
5764 2011-08-16 Ken Brown <kbrown@cornell.edu>
5766 * gmalloc.c: Expand comment.
5768 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5770 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5771 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5773 2011-08-16 Ken Brown <kbrown@cornell.edu>
5775 Fix memory allocation problems in Cygwin build (Bug#9273).
5777 * unexcw.c ( __malloc_initialized): Declare external variable.
5778 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5780 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5782 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5784 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5786 [CYGWIN] (special_realloc): New function.
5787 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5788 requests to realloc storage in the static heap.
5790 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5792 * bidi.c (bidi_initialize): Remove unused local.
5794 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5797 * biditype.h: Remove file.
5798 * makefile.w32-in ($(BLD)/bidi.$(O)):
5799 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5801 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5803 * chartab.c: Improve commentary for the uniprop_table API.
5805 * bidi.c (bidi_paragraph_init): Support zero value of
5806 bidi_ignore_explicit_marks_for_paragraph_level.
5807 (bidi_initialize): Use uniprop_table instead of including
5808 biditype.h and bidimirror.h.
5810 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5811 coordinates of the iterator when restoring from ppos_it.
5814 2011-08-14 Kenichi Handa <handa@m17n.org>
5816 * process.c (create_process): Call setup_process_coding_systems
5817 after the pid of the process is set to -1 (Bug#8162).
5819 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5821 * xdisp.c (move_it_in_display_line_to): Don't invoke
5822 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5823 ppos_it. Fixes vertical cursor motion when line beginning is
5824 covered by an image. (Bug#9296)
5826 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5828 * nsterm.h (ns_run_ascript): Declare.
5829 (NSAPP_DATA2_RUNASSCRIPT): Define.
5831 * nsfns.m (as_script, as_result, as_status): New static variables.
5832 (ns_run_ascript): New function.
5833 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5834 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5835 the event loop. Get status from as_status (Bug#7276).
5837 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5838 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5839 the event loop (Bug#7276).
5841 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5843 * gnutls.c (QCgnutls_bootprop_priority)
5844 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5845 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5846 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5847 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5848 (QCgnutls_bootprop_verify_hostname_error)
5849 (QCgnutls_bootprop_callbacks_verify): Rename from
5850 Qgnutls_bootprop_..., all uses changed.
5852 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5855 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5857 * xfaces.c (Qframe_set_background_mode): Now static.
5858 * dispextern.h (Qframe_set_background_mode): Remove decl.
5860 * process.c (Fnetwork_interface_info): Declare local only if needed.
5862 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5864 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5865 (Fnetwork_interface_list): Allocate in increments of bytes instead
5866 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5867 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5869 (struct ifflag_def): notrailers is smart on OSX.
5870 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5871 Get hardware address with getifaddrs if available.
5873 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5875 * xdisp.c (iterate_out_of_display_property): xassert that
5876 IT->position is set to within IT->object's boundaries. Break from
5877 the loop as soon as EOB is reached; avoids infloops in redisplay
5878 when IT->position is set up wrongly due to some bug.
5879 Set IT->current to match the bidi iterator unconditionally.
5880 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5881 entry. Force push_it to save on the stack the current
5882 buffer/string position, to be restored by pop_it. Fix flags in
5883 the iterator structure wrt the object coming from a display
5884 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5885 properties. (Bug#9284)
5887 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5889 * fontset.c (fontset_get_font_group): Add proper type checks.
5892 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5894 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5895 and LC_VERSION_MIN_MACOSX.
5896 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5897 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5899 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5901 * xdisp.c (forward_to_next_line_start): Allow to use the
5902 no-display-properties-and-no-overlays under bidi display.
5903 Set disp_pos in the bidi iterator to avoid searches for display
5904 properties and overlays.
5906 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5908 * editfns.c (Fset_time_zone_rule): Document relationship with the
5911 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5912 the font entity extracted from the cache (Bug#8109).
5914 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5916 * composite.c (autocmp_chars): Don't reset point. That is done by
5917 restore_point_unwind (Bug#5984).
5919 2011-08-07 Juri Linkov <juri@jurta.org>
5921 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5922 to show the arg `TIME' instead of `TIMEVAL'.
5924 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5926 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5927 display property strides EOL and includes a newline, as in
5928 longlines-mode. (Bug#9254)
5929 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5930 word-wrap under bidirectional display. (Bug#9224)
5932 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5933 is non-zero, even if the data buffer is NULL. Fixes a crash in
5934 vertical-motion with longlines-mode. (Bug#9254)
5936 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5938 * bidi.c <bidi_cache_total_alloc>: Now static.
5939 (bidi_initialize): Initialize bidi_cache_total_alloc.
5941 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5944 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5945 amount allocated this far in `bidi_cache_total_alloc'.
5946 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5947 non-zero, only free the data buffer without restoring the cache
5948 contents. All callers changed.
5950 * dispextern.h (bidi_unshelve_cache): Update prototype.
5952 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5953 (move_it_in_display_line, move_it_to)
5954 (move_it_vertically_backward, move_it_by_lines): Replace the call
5955 to xfree to an equivalent call to bidi_unshelve_cache.
5956 (move_it_in_display_line_to): Fix logic of returning
5957 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5959 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5961 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5962 came from a string character with a `cursor' property. (Bug#9229)
5964 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5966 * Makefile.in (LIB_PTHREAD): New variable.
5967 (LIBES): Add LIB_PTHREAD (Bug#9216).
5969 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5970 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5972 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5974 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5976 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5978 * xterm.c (x_find_topmost_parent): New function.
5979 (x_set_frame_alpha): Find topmost parent window with
5980 x_find_topmost_parent and set the property there also (bug#9181).
5981 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5983 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5985 * callproc.c (Fcall_process): Avoid vfork clobbering
5986 the local vars buffer, coding_systems, current_dir.
5988 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5990 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5992 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5994 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5995 so that it is not optimized away.
5997 * xdisp.c (compute_display_string_pos): Remove unused local.
5999 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6001 Fix slow cursor motion and scrolling in large buffers with
6002 selective display, like Org Mode buffers. (Bug#9218)
6004 * dispextern.h (struct bidi_it): New member disp_prop_p.
6006 * xdisp.c: Remove one-slot cache of display string positions.
6007 (compute_display_string_pos): Accept an additional argument
6008 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6009 for a display string or property. If found, set DISP_PROP_P
6012 * bidi.c (bidi_fetch_char): Accept an additional argument
6013 DISP_PROP_P, and pass it to compute_display_string_pos.
6014 Only handle text covered by a display string if DISP_PROP_P is returned
6015 non-zero. All callers of bidi_fetch_char changed.
6017 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6019 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6021 2010-12-03 Don March <don@ohspite.net>
6023 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6024 last character M-[char] is translated to ESC [char] (bug#7541).
6026 2011-08-02 Kenichi Handa <handa@m17n.org>
6028 * lisp.h (uniprop_table): Extern it.
6030 * chartab.c (uniprop_table): Make it non-static.
6032 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6034 * xdisp.c (forward_to_next_line_start): Accept additional argument
6035 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6037 (reseat_at_next_visible_line_start): Use the bidi iterator state
6038 returned by forward_to_next_line_start to restore the state of
6039 it->bidi_it after backing up to previous newline. (Bug#9212)
6041 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6043 * regex.c (re_comp): Protoize.
6044 (re_exec): Fix return type.
6045 (regexec): Fix type of `ret'. (Bug#9203)
6047 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6049 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6050 This is needed if max-image-size is a floating-point number.
6052 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6054 * print.c (print_object): Print empty symbol as ##.
6056 * lread.c (read1): Read ## as empty symbol.
6058 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6060 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6061 setting frame foreground color (Bug#9175).
6062 (x_set_background_color): Likewise.
6064 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6065 contents (Bug#9176).
6066 (EmacsTooltip -init): Remove bezels and add shadows to
6069 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6070 or scroll bar (Bug#8470).
6072 * nsfont.m (nsfont_open): Remove assignment to voffset and
6073 unnecessary vars hshink, expand, hd, full_height, min_height.
6074 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6076 * nsterm.h (nsfont_info): Remove voffset field.
6078 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6080 Implement strike-through and overline on NextStep (Bug#8863).
6082 * nsfont.m (nsfont_open): Use underline position provided by font,
6083 instead of hard-coded value of 2.
6084 (nsfont_draw): Call ns_draw_text_decoration instead.
6086 * nsterm.h: Add declaration for ns_draw_text_decoration.
6088 * nsterm.m (ns_draw_text_decoration): New function for drawing
6089 underline, overline, and strike-through.
6090 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6091 ns_draw_text_decoration. Change treatment of cursor drawing to
6092 accommodate underlining, etc.
6094 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6096 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6099 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6101 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6102 Without this fix, if a signal arrives just after memory fills up,
6103 'malloc' might be invoked reentrantly.
6105 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6106 In other words, assume that every image size is allowed, on non-X
6107 hosts. This assumption is probably wrong, but it lets Emacs compile.
6109 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6111 * regex.c (re_iswctype): Convert return values to boolean.
6113 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6115 * xdisp.c (compute_display_string_pos): Don't use cached display
6116 string position if the buffer had its restriction changed.
6119 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6121 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6123 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6125 Integer signedness and overflow and related fixes. (Bug#9079)
6127 * bidi.c: Integer size and overflow fixes.
6128 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6129 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6130 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6131 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6132 (bidi_find_other_level_edge):
6133 Use ptrdiff_t instead of EMACS_INT where either will do.
6134 This works better on 32-bit hosts configured --with-wide-int.
6135 (bidi_cache_ensure_space): Check for size-calculation overflow.
6136 Use % rather than repeated addition, for better worst-case speed.
6137 Don't set bidi_cache_size until after xrealloc returns, because it
6139 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6140 (bidi_cache_ensure_space): Also check that the bidi cache size
6141 does not exceed that of the largest Lisp string or buffer. See Eli
6142 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6144 * alloc.c (__malloc_size_t): Remove.
6145 All uses replaced by size_t. See Andreas Schwab's note
6146 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6148 * image.c: Improve checking for integer overflow.
6149 (check_image_size): Assume that f is nonnull, since
6150 it is always nonnull in practice. This is one less thing to
6151 worry about when checking for integer overflow later.
6152 (x_check_image_size): New function, which checks for integer
6153 overflow issues inside X.
6154 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6155 This removes the need for a memory_full check.
6156 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6157 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6158 (xbm_read_bitmap_data): Change locals back to 'int', since
6159 their values must fit in 'int'.
6160 (xpm_load_image, png_load, tiff_load):
6161 Invoke x_create_x_image_and_pixmap earlier,
6162 to avoid much needless work if the image is too large.
6163 (tiff_load): Treat overly large images as if
6164 x_create_x_image_and_pixmap failed, not as malloc failures.
6165 (gs_load): Use x_check_image_size.
6167 * gtkutil.c: Omit integer casts.
6168 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6169 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6171 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6173 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6174 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6175 would wrongly return t on a 64-bit host.
6177 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6178 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6179 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6180 and therefore cause GCC to emit a bogus diagnostic in some cases.
6182 * image.c: Integer signedness and overflow and related fixes.
6183 This is not an exhaustive set of fixes, but it's time to
6184 record what I've got.
6185 (lookup_pixel_color, check_image_size): Remove redundant decls.
6186 (check_image_size): Don't assume that arbitrary EMACS_INT values
6187 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6188 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6189 (tiff_load, imagemagick_load_image):
6190 Check for overflow in size calculations.
6191 (x_create_x_image_and_pixmap): Remove unnecessary test for
6192 xmalloc returning NULL; that can't happen.
6193 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6194 (xpm_color_bucket): Use better integer hashing function.
6195 (xpm_cache_color): Don't possibly over-allocate memory.
6196 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6197 (gif_memory_source):
6198 Use ptrdiff_t, not int or size_t, to record sizes.
6199 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6200 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6201 either works, as we prefer signed integers.
6202 (tiff_read_from_memory, tiff_write_from_memory):
6203 Return tsize_t, not size_t, since that's what the TIFF API wants.
6204 (tiff_read_from_memory): Don't fail simply because the read would
6205 go past EOF; instead, return a short read.
6206 (tiff_load): Omit no-longer-needed casts.
6207 (Fimagemagick_types): Don't assume size fits into 'int'.
6209 Improve hashing quality when configured --with-wide-int.
6210 * fns.c (hash_string): New function, taken from sxhash_string.
6211 Do not discard information about ASCII character case; this
6212 discarding is no longer needed.
6213 (sxhash-string): Use it. Change sig to match it. Caller changed.
6214 * lisp.h: Declare it.
6215 * lread.c (hash_string): Remove, since we now use fns.c's version.
6216 The fns.c version returns a wider integer if --with-wide-int is
6217 specified, so this should help the quality of the hashing a bit.
6219 * emacs.c: Integer overflow minor fix.
6220 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6221 Define only if GNU_LINUX.
6222 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6224 * dispnew.c: Integer signedness and overflow fixes.
6225 Remove unnecessary forward decls, that were a maintenance hassle.
6226 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6228 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6229 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6230 (prepare_desired_row, line_draw_cost):
6231 Use int, not unsigned, where either works.
6232 (save_current_matrix, restore_current_matrix):
6233 Use ptrdiff_t, not size_t, where either works.
6234 (init_display): Check for overflow more accurately, and without
6235 relying on undefined behavior.
6237 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6238 Remove, replacing with the new symbols in lisp.h. All uses changed.
6239 * fileio.c (make_temp_name):
6240 * filelock.c (lock_file_1, lock_file):
6241 * xdisp.c (message_dolog):
6242 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6243 Use pMd etc. instead.
6244 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6245 replacing the pWIDE etc. symbols removed from editfns.c.
6247 * keyboard.h (num_input_events): Now uintmax_t.
6248 This is (very slightly) less likely to mess up due to wraparound.
6251 * buffer.c: Integer signedness fixes.
6252 (alloc_buffer_text, enlarge_buffer_text):
6253 Use ptrdiff_t rather than size_t when either will do, as we prefer
6256 * alloc.c: Integer signedness and overflow fixes.
6257 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6258 (__malloc_size_t): Default to size_t, not to int.
6259 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6260 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6261 Prefer ptrdiff_t to size_t when either would do, as we prefer
6263 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6264 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6265 Now const. Initialize with values that are in range even if char
6267 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6268 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6269 These functions do the right thing with sizes > 2**32.
6270 (check_depth): Now ptrdiff_t, not int.
6271 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6272 Adjust to new way of storing sizes. Check for size overflow bugs
6274 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6275 slightly wrong anyway, as it missed one instance of
6276 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6277 (refill_memory_reserve): Omit needless cast to size_t.
6278 (mark_object_loop_halt): Mark as externally visible.
6280 * xselect.c: Integer signedness and overflow fixes.
6281 (Fx_register_dnd_atom, x_handle_dnd_message):
6282 Use ptrdiff_t, not size_t, since we prefer signed.
6283 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6284 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6285 x_dnd_atoms_size and x_dnd_atoms_length.
6287 * doprnt.c: Prefer signed to unsigned when either works.
6289 * doprnt.c (doprnt):
6291 * xdisp.c (vmessage):
6292 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6293 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6294 prefer signed arithmetic to avoid comparison confusion.
6295 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6296 but is a bit tricky.
6298 Assume freestanding C89 headers, string.h, stdlib.h.
6299 * data.c, doprnt.c, floatfns.c, print.c:
6300 Include float.h unconditionally.
6301 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6302 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6303 * regex.c: Likewise for stddef.h, string.h.
6304 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6305 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6306 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6307 (STDC_HEADERS): Remove obsolete defines.
6308 * sysdep.c: Include limits.h unconditionally.
6310 Assume support for memcmp, memcpy, memmove, memset.
6311 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6312 * regex.c (memcmp, memcpy):
6313 Remove; we assume C89 now.
6315 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6316 (__malloc_safe_bcopy): Remove; no longer needed.
6318 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6319 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6320 well either way, and we prefer signed to unsigned.
6322 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6324 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6325 closes the connection while we're reading (bug#9182).
6327 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6329 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6330 are specified (Bug#9168).
6332 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6334 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6335 Found by GCC static checking and --with-wide-int on a 32-bit host.
6337 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6339 * xdisp.c (compute_display_string_pos): Fix logic of caching
6340 previous display string position. Initialize cached_prev_pos to
6341 -1. Fixes slow-down at the beginning of a buffer.
6343 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6345 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6346 for attrs[LFACE_FONTSET_INDEX].
6348 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6350 * xml.c (parse_region): Remove unused local
6351 that was recently introduced.
6353 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6355 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6356 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6358 * xdisp.c (move_it_in_display_line_to): Record the best matching
6359 position for TO_CHARPOS while scanning the line, and restore it on
6360 exit if none of the characters scanned was an exact match.
6361 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6362 when exact match is impossible due to invisible text, and the
6363 lines are truncated.
6365 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6367 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6370 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6372 Fix a significant slow-down of cursor motion with C-n, C-p,
6373 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6374 auto-repeat under bidi redisplay in fontified buffers.
6375 * xdisp.c (compute_stop_pos_backwards): New function.
6376 (next_element_from_buffer): Call compute_stop_pos_backwards to
6377 find a suitable prev_stop when we find ourselves before
6379 (reseat): Don't look for prev_stop, as that could mean a very long
6381 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6382 <cached_disp_overlay_modiff>: Cache for last found display string
6384 (compute_display_string_pos): Return the cached position if asked
6385 about the same buffer in the same area of character positions, and
6386 the buffer wasn't changed since the time the display string
6387 position was cached.
6389 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6391 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6392 is an integer, which is important for empty lines. (Bug#9149)
6394 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6396 * frame.c (Fmodify_frame_parameters): In tty case, update the
6397 default face if necessary (Bug#4238).
6399 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6401 * editfns.c (Fstring_to_char): No need to explain what a character
6402 is in the docstring (Bug#6576).
6404 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6406 * xml.c (parse_region): Make sure we always return a tree.
6408 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6410 * xml.c (parse_region): If a document contains only comments,
6413 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6415 * xml.c (make_dom): Return comments, too.
6417 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6420 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6421 and the surrounding thread.
6422 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6423 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6424 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6426 * s/openbsd.h (BROKEN_SIGIO): Define.
6427 * unexelf.c (unexec) [__OpenBSD__]:
6428 Don't update the .mdebug section of the Alpha COFF symbol table.
6430 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6432 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6435 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6437 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6438 This fixes some race conditions on the permissions of any newly
6441 * alloc.c (valid_pointer_p): Use pipe, not open.
6442 This fixes some permissions issues when debugging.
6444 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6445 If fchown fails to set both uid and gid, try to set just gid,
6446 as that is sometimes allowed. Adjust the file's mode to eliminate
6447 setuid or setgid bits that are inappropriate if fchown fails.
6449 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6451 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6452 to compare Lisp_Objects.
6453 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6454 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6455 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6457 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6459 * lread.c (read_integer): Unread even EOF character.
6460 (read1): Likewise. Properly record start position of symbol.
6462 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6463 symbol character follows.
6465 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6467 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6468 This works around a problem with the previous change to Fcopy_file.
6469 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6470 and without this change, GCC might complain about discarding
6471 fchown's return value.
6473 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6475 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6477 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6479 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6481 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6483 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6484 it's used from the C level.
6486 * process.c: Use the same condition for POLL_FOR_INPUT in both
6487 keyboard.c and process.c (bug#1858).
6489 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6491 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6492 (Fgnutls_boot): Use it.
6494 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6496 * doc.c (Fsubstitute_command_keys): Revert last change.
6498 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6500 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6501 quotes the next character, and doesn't affect other longer
6502 sequences (bug#8935).
6504 * lread.c (syms_of_lread): Clarify that is isn't only
6505 `eval-buffer' and `eval-defun' that's affected by
6506 `lexical-binding' (bug#8460).
6508 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6510 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6511 bidi redisplay when a line includes both an image and is truncated.
6513 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6515 Fix minor problems found by static checking.
6516 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6517 (elsz): Now a signed constant, not a size_t var. We prefer signed
6518 types to unsigned, to avoid integer comparison confusion. Without
6519 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6520 "cannot optimize loop, the loop counter may overflow", a symptom
6522 * indent.c (Fvertical_motion): Mark locals as initialized.
6523 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6525 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6527 * search.c (Fre_search_backward): Mention `case-fold-search' in
6528 all the re_search_* functions (bug#8138).
6530 * keyboard.c (Fopen_dribble_file): Document when the file is
6533 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6535 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6538 Support bidi reordering of display and overlay strings.
6539 * xdisp.c (compute_display_string_pos)
6540 (compute_display_string_end): Accept additional argument STRING.
6541 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6542 (reseat_to_string): Initialize bidi_it->string.s and
6543 bidi_it->string.schars.
6544 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6545 NULL (avoids a crash in bidi_paragraph_init).
6546 Initialize itb.string.lstring.
6547 (init_iterator): Call bidi_init_it only of a valid
6548 buffer position was specified. Initialize paragraph_embedding to
6550 (reseat_to_string): Initialize the bidi iterator.
6551 (display_string): If we need to ignore text properties of
6552 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6553 original value of -1 will not work with bidi.)
6554 (compute_display_string_pos): First arg is now struct
6555 `text_pos *'; all callers changed. Support display properties on
6557 (compute_display_string_end): Support display properties on Lisp
6559 (init_iterator, reseat_1, reseat_to_string): Initialize the
6560 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6561 when iterating on a string not from display properties).
6562 (compute_display_string_pos, compute_display_string_end):
6563 Fix calculation of the object to scan. Fixes an error when using
6565 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6566 base_level_stop; instead, set base_level_stop to BEGV.
6567 Fixes crashes in vertical-motion.
6568 (next_element_from_buffer): Improve commentary for when
6569 the iterator is before prev_stop.
6570 (init_iterator): Initialize bidi_p from the default value of
6571 bidi-display-reordering, not from buffer-local value. Use the
6572 buffer-local value only if initializing for buffer iteration.
6573 (handle_invisible_prop): Support invisible properties on strings
6574 that are being bidi-reordered.
6575 (set_iterator_to_next): Support bidi reordering of C strings and
6577 (next_element_from_string): Support bidi reordering of Lisp
6579 (handle_stop_backwards): Support Lisp strings as well.
6580 (display_string): Support display of R2L glyph rows.
6581 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6582 (init_iterator): Don't initialize it->bidi_p for strings
6584 (reseat_to_string): Initialize it->bidi_p for strings here.
6585 (next_element_from_string, next_element_from_c_string)
6586 (next_element_from_buffer): Add xassert's for correspondence
6587 between IT's object being iterated and it->bidi_it.string
6589 (face_before_or_after_it_pos): Support bidi iteration.
6590 (next_element_from_c_string): Handle the case of the first string
6591 character that is not the first one in the visual order.
6592 (get_visually_first_element): New function, refactored from common
6593 parts of next_element_from_buffer, next_element_from_string, and
6594 next_element_from_c_string.
6595 (tool_bar_lines_needed, redisplay_tool_bar)
6596 (display_menu_bar): Force left-to-right direction. Add a FIXME
6597 comment for making that be controlled by a user option.
6598 (push_it, pop_it): Save and restore the state of the
6599 bidi iterator. Save and restore the bidi_p flag.
6600 (pop_it): Iterate out of display property for string iteration as
6602 (iterate_out_of_display_property): Support iteration over strings.
6603 (handle_single_display_spec): Set up it->bidi_it for iteration
6604 over a display string, and call bidi_init_it.
6605 (handle_single_display_spec, next_overlay_string)
6606 (get_overlay_strings_1, push_display_prop): Set up the bidi
6607 iterator for displaying display or overlay strings.
6608 (forward_to_next_line_start): Don't use the shortcut if
6610 (back_to_previous_visible_line_start): If handle_display_prop
6611 pushed the iterator stack, restore the internal state of the bidi
6612 iterator by calling bidi_pop_it same number of times.
6613 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6614 and we are bidi-iterating, don't decrement the iterator position;
6615 instead, set the first_elt flag in the bidi iterator, to produce
6617 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6618 (push_display_prop): xassert that we are iterating a buffer.
6619 (push_it, pop_it): Save and restore paragraph_embedding member.
6620 (handle_single_display_spec, next_overlay_string)
6621 (get_overlay_strings_1, reseat_1, reseat_to_string)
6622 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6623 correctly. Don't assume unibyte strings are not bidi-reordered.
6624 (compute_display_string_pos)
6625 (compute_display_string_end): Fix handling the case of C string.
6626 (push_it, pop_it): Save and restore from_disp_prop_p.
6627 (handle_single_display_spec, push_display_prop): Set the
6628 from_disp_prop_p flag.
6629 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6630 (pop_it): Call iterate_out_of_display_property only if we are
6631 popping after iteration over a string that came from a display
6632 property. Fix a typo in popping stretch info. Add an assertion
6633 for verifying that the iterator position is in sync with the bidi
6635 (handle_single_display_spec, get_overlay_strings_1)
6636 (push_display_prop): Fix initialization of paragraph direction for
6637 string when that of the parent object is not yet determined.
6638 (reseat_1): Call bidi_init_it to resync the bidi
6639 iterator with IT's position. (Bug#7616)
6640 (find_row_edges): If ROW->start.pos gives position
6641 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6642 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6643 Reset the from_disp_prop_p flag.
6644 (SAVE_IT, RESTORE_IT): New macros.
6645 (pos_visible_p, face_before_or_after_it_pos)
6646 (back_to_previous_visible_line_start)
6647 (move_it_in_display_line_to, move_it_in_display_line)
6648 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6649 (try_scrolling, redisplay_window, display_line): Use them when
6650 saving a temporary copy of the iterator and restoring it back.
6651 (back_to_previous_visible_line_start, reseat_1)
6652 (init_iterator): Empty the bidi cache "stack".
6653 (move_it_in_display_line_to): If iterator ended up at
6654 EOL, but we never saw any buffer positions smaller than
6655 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6656 motion in bidi-reordered lines.
6657 (move_it_in_display_line_to): Record prev_method and prev_pos
6658 immediately before the call to set_iterator_to_next. Fixes cursor
6659 motion in bidi-reordered lines with stretch glyphs and strings
6660 displayed in margins. (Bug#8133) (Bug#8867)
6661 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6663 (pos_visible_p): Support positions in bidi-reordered lines.
6664 Save and restore bidi cache.
6666 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6667 (bidi_paragraph_info): Delete unused struct.
6668 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6669 (bidi_cache_start): New variable.
6670 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6672 (bidi_cache_fetch_state, bidi_cache_search)
6673 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6674 (bidi_cache_find, bidi_peek_at_next_level)
6675 (bidi_level_of_next_char, bidi_find_other_level_edge)
6676 (bidi_move_to_visually_next): Compare cache index with
6677 bidi_cache_start rather than with zero.
6678 (bidi_fetch_char): Accept new argument STRING; all callers
6679 changed. Support iteration over a string. Support strings with
6680 display properties. Support unibyte strings. Fix the type of
6681 `len' according to what STRING_CHAR_AND_LENGTH expects.
6682 (bidi_paragraph_init, bidi_resolve_explicit_1)
6683 (bidi_resolve_explicit, bidi_resolve_weak)
6684 (bidi_level_of_next_char, bidi_move_to_visually_next):
6685 Support iteration over a string.
6686 (bidi_set_sor_type, bidi_resolve_explicit_1)
6687 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6688 can now be zero (for strings); special values 0 and -1 were
6689 changed to -1 and -2, respectively.
6690 (bidi_char_at_pos): New function.
6691 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6692 Call it instead of FETCH_MULTIBYTE_CHAR.
6693 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6694 initialized to valid values.
6695 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6697 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6698 the test for valid cached positions. Fix the logic for looking up
6699 the sentinel state in the cache. GCPRO the Lisp string we are
6701 (bidi_push_it, bidi_pop_it): New functions.
6702 (bidi_initialize): Initialize the bidi cache start stack pointer.
6703 (bidi_cache_ensure_space): New function, refactored from part of
6704 bidi_cache_iterator_state. Don't assume the required size is just
6705 one BIDI_CACHE_CHUNK away.
6706 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6707 (bidi_count_bytes, bidi_char_at_pos): New functions.
6708 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6709 always valid if bidi_cache_idx is valid.
6710 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6711 is valid if it's going to be used.
6712 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6713 (bidi_cache_fetch_state, bidi_cache_search)
6714 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6715 (bidi_cache_iterator_state, bidi_cache_find)
6716 (bidi_find_other_level_edge, bidi_cache_start_stack):
6717 All variables related to cache indices are now EMACS_INT.
6719 * dispextern.h (struct bidi_string_data): New structure.
6720 (struct bidi_it): New member `string'. Make flag members be 1-bit
6721 fields, and put them last in the struct.
6722 (compute_display_string_pos, compute_display_string_end):
6724 (bidi_push_it, bidi_pop_it): Add prototypes.
6725 (struct iterator_stack_entry): New members bidi_p,
6726 paragraph_embedding, and from_disp_prop_p.
6727 (struct it): Member bidi_p is now a bit field 1 bit wide.
6728 (bidi_shelve_cache, bidi_unshelve_cache):
6731 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6732 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6733 and vector-like objects.
6735 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6736 cache around display iteration.
6738 * window.c (Fwindow_end, window_scroll_pixel_based)
6739 (displayed_window_lines, Frecenter): Save and restore the bidi
6740 cache around display iteration.
6742 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6744 * editfns.c (Fdelete_region): Clarify the use of the named
6745 parameters (bug#6788).
6747 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6749 * indent.c (Fvertical_motion): Set and restore w->pointm when
6750 saving and restoring the window's buffer (Bug#9006).
6752 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6754 * editfns.c (Fstring_to_char): Clarify just what is returned
6755 (bug#6576). Text by Eli Zaretskii.
6757 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6759 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6761 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6763 * buffer.c (mmap_find): Fix a typo.
6765 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6767 Fix execution of x selection hooks.
6768 * xselect.c (Qx_lost_selection_functions)
6769 (Qx_sent_selection_functions): New vars.
6770 (syms_of_xselect): DEFSYM them.
6771 (x_handle_selection_request): Pass Qx_sent_selection_functions
6772 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6773 (x_handle_selection_clear,x_clear_frame_selections):
6774 Pass Qx_lost_selection_functions rather than
6775 Vx_lost_selection_functions to Frun_hook_with_args.
6777 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6779 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6780 The old code sometimes used this field without initializing it.
6782 * alloc.c (gc_sweep): Don't read past end of array.
6783 In theory, the old code could also have corrupted Emacs internals,
6784 though it'd be very unlikely.
6786 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6788 * character.c (Fcharacterp): Don't advertise optional ignored
6789 argument. (Bug#4026)
6791 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6793 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6796 * window.c (Fset_window_start): Doc fix (bug#4199).
6797 (Fset_window_hscroll): Ditto.
6799 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6801 Fix minor new problems caught by GCC 4.6.1.
6802 * term.c (init_tty): Remove unused local.
6803 * xsettings.c (store_monospaced_changed): Define this function only
6804 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6807 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6809 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6811 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6813 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6814 are the mini-buffer and the echo area (bug#3320).
6816 * term.c (init_tty): Remove support for supdup, c10 and perq
6817 terminals, which are no longer supported (bug#1482).
6819 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6821 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6823 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6825 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6826 for non-popups (Bug#3642).
6828 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6830 * alloc.c (reset_malloc_hooks): Protoize.
6831 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6832 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6833 * cm.c (losecursor): Likewise.
6834 * data.c (fmod): Likewise.
6835 * dispnew.c (swap_glyphs_in_rows): Likewise.
6836 * emacs.c (memory_warning_signal): Likewise.
6837 * floatfns.c (float_error): Likewise.
6838 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6839 (otf_open, font_otf_capability, generate_otf_features)
6840 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6842 * image.c (pbm_read_file): Likewise.
6843 * indent.c (string_display_width): Likewise.
6844 * intervals.c (check_for_interval, search_for_interval)
6845 (inc_interval_count, count_intervals, root_interval)
6846 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6847 * lread.c (defalias): Likewise.
6848 * ralloc.c (r_alloc_check): Likewise.
6849 * regex.c (set_image_of_range_1, set_image_of_range)
6850 (regex_grow_registers): Likewise.
6851 * sysdep.c (strerror): Likewise.
6852 * termcap.c (valid_filename_p, tprint, main): Likewise.
6853 * tparam.c (main): Likewise.
6854 * unexhp9k800.c (run_time_remap, save_data_space)
6855 (update_file_ptrs, read_header, write_header, calculate_checksum)
6856 (copy_file, copy_rest, display_header): Likewise.
6857 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6859 * xdisp.c (check_it): Likewise.
6860 * xfaces.c (register_color, unregister_color, unregister_colors):
6862 * xfns.c (print_fontset_result): Likewise.
6863 * xrdb.c (member, fatal, main): Likewise.
6865 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6867 Fix minor problems found by static checking (Bug#9031).
6868 * chartab.c (char_table_set_range, map_sub_char_table):
6869 Remove unused locals.
6870 (uniprop_table): Now static.
6871 * composite.c (_work_char): Remove unused static var.
6873 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6875 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6877 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6879 * gtkutil.c (qttip_cb): Remove code without function.
6881 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6883 * w32.c (pthread_sigmask): New stub.
6885 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6887 Use pthread_sigmask, not sigprocmask (Bug#9010).
6888 sigprocmask is portable only for single-threaded applications, and
6889 Emacs can be multi-threaded when it uses GTK.
6890 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6892 * callproc.c (Fcall_process):
6893 * process.c (create_process):
6894 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6895 Use pthread_sigmask, not sigprocmask.
6897 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6899 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6900 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6903 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6905 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6906 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6907 (xg_hide_tooltip): Fix comment.
6909 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6910 in registerServicesMenuSendTypes.
6911 (validRequestorForSendType): Don't check ns_return_types.
6913 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6916 2011-07-08 Jason Rumney <jasonr@gnu.org>
6918 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6919 SH_SHOW for hidden windows (Bug#5482).
6921 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6922 frame struct members of non-existent frames (Bug#6284).
6924 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6926 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6927 variable firstTime not needed on OSX >= 10.6.
6928 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6929 >= 10.5. Use setKnobProportion, setDoubleValue.
6931 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6932 (MAC_OS_X_VERSION_10_5): Define if not defined.
6933 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6934 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6935 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6937 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6938 cString and lossyCString on OSX >= 10.4
6940 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6941 sizeToFit on OSX >= 10.2.
6943 * nsimage.m (allocInitFromFile): Don't use deprecated method
6944 bestRepresentationForDevice on OSX >= 10.6.
6946 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6949 * emacs.c: Declare unexec_init_emacs_zone.
6951 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6953 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6955 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6956 on svcsMenu (Bug#8842).
6958 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6960 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6962 * nsterm.m (QUTF8_STRING): Declare.
6963 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6964 (validRequestorForSendType): Return type is (id).
6965 Change indexOfObjectIdenticalTo to indexOfObject.
6966 Check if we have local selection before returning self (Bug#8842).
6967 (writeSelectionToPasteboard): Put local selection into paste board
6968 if we have a local selection (Bug#8842).
6969 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6971 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6972 (ns_get_local_selection): Declare.
6974 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6976 * keymap.c (describe_map_tree): Don't insert a double newline at
6977 the end of the buffer (bug#1169) and return whether we inserted
6980 * callint.c (Fcall_interactively): Change "reading args" to
6981 "providing args" to try to clarify what it does (bug#1010).
6983 2011-07-07 Kenichi Handa <handa@m17n.org>
6985 * composite.c (composition_compute_stop_pos): Ignore a static
6986 composition starting before CHARPOS (Bug#8915).
6988 * xdisp.c (handle_composition_prop): Likewise.
6990 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6992 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6995 2011-07-07 Kenichi Handa <handa@m17n.org>
6997 * character.h (unicode_category_t): New enum type.
6999 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7000 (Qchar_code_property_table): New variable.
7001 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7002 (UNIPROP_COMPRESSED_FORM_P): New macros.
7003 (char_table_ascii): Uncompress the compressed values.
7004 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7005 Uncompress the compressed values.
7006 (sub_char_table_ref_and_range): Likewise.
7007 (char_table_ref_and_range): Uncompress the compressed values.
7008 (sub_char_table_set): New arg is_uniprop. Callers changed.
7009 Uncompress the compressed values.
7010 (sub_char_table_set_range): Args changed. Callers changed.
7011 (char_table_set_range): Adjuted for the above change.
7012 (map_sub_char_table): Delete args default_val and parent. Add arg
7013 top. Give decoded values to a Lisp function.
7014 (map_char_table): Adjust for the above change. Give decoded
7015 values to a Lisp function. Gcpro more variables.
7016 (uniprop_table_uncompress)
7017 (uniprop_decode_value_run_length): New functions.
7018 (uniprop_decoder, uniprop_decoder_count): New variables.
7019 (uniprop_get_decoder, uniprop_encode_value_character)
7020 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7022 (uniprop_encoder, uniprop_encoder_count): New variables.
7023 (uniprop_get_encoder, uniprop_table)
7024 (Funicode_property_table_internal, Fget_unicode_property_internal)
7025 (Fput_unicode_property_internal): New functions.
7026 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7027 Sunicode_property_table_internal, Sget_unicode_property_internal,
7028 and Sput_unicode_property_internal. Defvar_lisp
7029 char-code-property-alist.
7031 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7032 Vunicode_category_table.
7034 * font.c (font_range): Adjust for the change of
7035 Vunicode_category_table.
7037 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7039 * m/iris4d.h: Remove file, move contents ...
7040 * s/irix6-5.h: ... here.
7042 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7044 Remove unportable assumption about struct layout (Bug#8884).
7045 * alloc.c (mark_buffer):
7046 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7047 (clone_per_buffer_values): Don't assume that
7048 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7049 This isn't true in general, and it's particularly not true
7050 if Emacs is configured with --with-wide-int.
7051 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7052 New macros, used in the buffer.c change.
7054 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7056 * xsettings.c: Use both GConf and GSettings if both are available.
7057 (store_config_changed_event): Add comment.
7058 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7059 (store_tool_bar_style_changed): New functions.
7060 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7061 (struct xsettings): Move font inside HAVE_XFT.
7062 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7063 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7064 Move inside HAVE_XFT.
7065 (something_changed_gsettingsCB): Rename from something_changedCB.
7066 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7068 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7069 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7070 (something_changed_gconfCB): Rename from something_changedCB.
7071 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7072 (parse_settings): Move check for font inside HAVE_XFT.
7073 (read_settings, apply_xft_settings): Add comment.
7074 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7075 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7076 call store_font_name_changed.
7077 (xft_settings_event): Add comment.
7078 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7079 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7080 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7081 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7082 (xsettings_initialize): Call init_gsettings last.
7083 (xsettings_get_system_font, xsettings_get_system_normal_font):
7086 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7088 Random fixes. E.g., (random) never returned negative values.
7089 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7090 subseconds part to the entropy, as that's a bit more random.
7091 Prefer signed to unsigned, since the signedness doesn't matter and
7092 in general we prefer signed. When given a limit, use a
7093 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7094 latter isn't right if USE_2_TAGS_FOR_INTS.
7095 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7096 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7098 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7100 * textprop.c (text_property_stickiness):
7101 Obey Vtext_property_default_nonsticky.
7102 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7103 * w32fns.c (syms_of_w32fns):
7104 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7106 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7108 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7109 This is more efficient than Ffile_directory_p and avoids a minor race.
7111 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7113 * buffer.c (Foverlay_put): Say what the return value is
7116 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7117 is a directory before asking whether to use the file name
7119 (barf_or_query_if_file_exists): Make the "File is a directory"
7120 error be more correct.
7122 * fns.c (Frequire): Remove the mention of the .gz files, since
7123 that's installation-specific, but keep the mention of
7124 `get-load-suffixes'.
7126 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7128 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7129 Report string overflow if the output is too long.
7131 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7133 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7134 (syms_of_gnutls): Remove duplicate DEFSYM for
7135 Qgnutls_bootprop_verify_hostname_error, an error for
7136 Qgnutls_bootprop_verify_error (which is no longer used).
7138 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7139 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7140 Also (re)move comments that are misplaced or no longer relevant.
7142 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7144 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7146 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7148 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7149 and background color parameters if they have been changed.
7151 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7153 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7155 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7157 * xsettings.c (SYSTEM_FONT): Define only when used.
7158 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7160 * keymap.c (access_keymap_1): Now static.
7162 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7164 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7165 leave any prefix arg for the up event (Bug#1586).
7167 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7169 * lread.c (syms_of_lread): Mention single symbols defined by
7170 `defvar' or `defconst' (bug#7154).
7172 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7173 (Frequire): Mention get-load-suffixes.
7175 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7177 * window.h (window): Remove clone_number slot.
7178 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7180 (make_parent_window, make_window, saved_window)
7181 (Fset_window_configuration, save_window_save): Don't deal with
7183 * buffer.c (Qclone_number): Remove declaration.
7184 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7186 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7188 Add multiple inheritance to keymaps.
7189 * keymap.c (Fmake_composed_keymap): New function.
7190 (Fset_keymap_parent): Simplify.
7191 (fix_submap_inheritance): Remove.
7192 (access_keymap_1): New function extracted from access_keymap to handle
7193 embedded parents and handle lists of maps.
7194 (access_keymap): Use it.
7195 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7196 (Fcopy_keymap): Handle embedded parents.
7197 (Fcommand_remapping, define_as_prefix): Simplify.
7198 (Fkey_binding): Simplify.
7199 (syms_of_keymap): Move minibuffer-local-completion-map,
7200 minibuffer-local-filename-completion-map,
7201 minibuffer-local-must-match-map, and
7202 minibuffer-local-filename-must-match-map to Elisp.
7203 (syms_of_keymap): Defsubr make-composed-keymap.
7204 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7205 (parse_menu_item): Trivial simplification.
7207 2011-07-01 Glenn Morris <rgm@gnu.org>
7209 * Makefile.in (SETTINGS_LIBS): Fix typo.
7211 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7213 * coding.c (Fencode_coding_string): Record the last coding system
7214 used, as the function doc string says (bug#8738).
7216 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7218 * xsettings.c (store_monospaced_changed): Take new font as arg and
7219 check for change against current_mono_font.
7220 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7221 (emacs_settings_constructor, emacs_settings_get_property)
7222 (emacs_settings_set_property, emacs_settings_class_init)
7223 (emacs_settings_init, gsettings_obj): Remove.
7224 (something_changedCB): New function for HAVE_GSETTINGS.
7225 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7226 with value as argument.
7227 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7228 g_settings_new (Bug#8967). Do not create gsettings_obj.
7229 Remove calls to g_settings_bind. Connect something_changedCB to
7232 * xgselect.c: Add defined (HAVE_GSETTINGS).
7233 (xgselect_initialize): Ditto.
7235 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7236 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7239 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7241 * eval.c (struct backtrace): Simplify and port the data structure.
7242 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7243 signed bit field, as this assumption is not portable and it makes
7244 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7245 "char debug_on_exit : 1" as this is not portable either; instead,
7246 use the portable "unsigned int debug_on_exit : 1". Remove unused
7247 member evalargs. Remove obsolete comments about cc bombing out.
7249 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7251 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7252 Let HAVE_GSETTINGS override HAVE_GCONF.
7253 (store_monospaced_changed): New function.
7254 (EMACS_SETTINGS): A new type derived from GObject to handle
7255 GSettings notifications.
7256 (emacs_settings_constructor, emacs_settings_get_property)
7257 (emacs_settings_set_property, emacs_settings_class_init):
7259 (gsettings_client, gsettings_obj): New variables.
7260 (GSETTINGS_SCHEMA): New define.
7261 (something_changedCB): Call store_monospaced_changed.
7262 (init_gsettings): New function.
7263 (xsettings_initialize): Call init_gsettings.
7264 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7267 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7270 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7272 * window.c (resize_root_window, grow_mini_window)
7273 (shrink_mini_window): Rename Qresize_root_window to
7274 Qwindow_resize_root_window and Qresize_root_window_vertically to
7275 Qwindow_resize_root_window_vertically.
7277 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7279 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7281 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7283 * makefile.w32-in: Redesign dependencies so they reflect more
7284 clearly which files are directly included by each source file,
7285 and not through other includes.
7287 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7289 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7290 (sort_overlays, overlay_strings): When an overlay's clone number
7291 matches the window's clone number process the overlay even if
7292 the overlay's window property doesn't match the current window.
7294 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7295 (Fwindow_hchild): Rename to Fwindow_left_child.
7296 (Fwindow_next): Rename to Fwindow_next_sibling.
7297 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7298 (resize_window_check): Rename to window_resize_check.
7299 (resize_window_apply): Rename to window_resize_apply.
7300 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7301 (Fdelete_other_windows_internal, resize_frame_windows)
7302 (Fsplit_window_internal, Fdelete_window_internal)
7303 (grow_mini_window, shrink_mini_window)
7304 (Fresize_mini_window_internal): Fix callers accordingly.
7306 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7308 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7309 (emacs_fixed_set_min_size): Remove.
7310 (emacs_fixed_new): Take frame as argument.
7312 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7313 (_EmacsFixedPrivate): Remove minwidth/height.
7314 Add struct frame *f.
7315 (emacs_fixed_init): Initialize priv->f.
7316 (get_parent_class, emacs_fixed_set_min_size): Remove.
7317 (emacs_fixed_new): Set priv->f to argument.
7318 (emacs_fixed_get_preferred_width)
7319 (emacs_fixed_get_preferred_height): Use min_width/height from
7320 frames size_hint to set minimum and natural (Bug#8919).
7321 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7322 and use min_width/height from frames size_hint to set
7323 min_width/height (Bug#8919).
7325 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7326 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7329 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7331 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7332 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7335 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7337 * process.c (wait_reading_process_output): Bypass select if
7338 waiting for a cell while ignoring keyboard input, and input is
7339 pending. Suggested by Jan Djärv (Bug#8869).
7341 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7343 Use gnulib's dup2 module instead of rolling our own.
7344 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7346 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7348 * dispnew.c (scrolling_window): Before scrolling, turn off a
7349 mouse-highlight in the window being scrolled.
7351 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7353 Move DEFSYM to lisp.h and use everywhere.
7355 * character.h (DEFSYM): Move declaration...
7356 * lisp.h (DEFSYM): ...here.
7362 * w32select.c: Don't include character.h.
7364 * alloc.c (syms_of_alloc):
7365 * buffer.c (syms_of_buffer):
7366 * bytecode.c (syms_of_bytecode):
7367 * callint.c (syms_of_callint):
7368 * casefiddle.c (syms_of_casefiddle):
7369 * casetab.c (init_casetab_once):
7370 * category.c (init_category_once, syms_of_category):
7371 * ccl.c (syms_of_ccl):
7372 * cmds.c (syms_of_cmds):
7373 * composite.c (syms_of_composite):
7374 * dbusbind.c (syms_of_dbusbind):
7375 * dired.c (syms_of_dired):
7376 * dispnew.c (syms_of_display):
7377 * doc.c (syms_of_doc):
7378 * editfns.c (syms_of_editfns):
7379 * emacs.c (syms_of_emacs):
7380 * eval.c (syms_of_eval):
7381 * fileio.c (syms_of_fileio):
7382 * fns.c (syms_of_fns):
7383 * frame.c (syms_of_frame):
7384 * fringe.c (syms_of_fringe):
7385 * insdel.c (syms_of_insdel):
7386 * keymap.c (syms_of_keymap):
7387 * lread.c (init_obarray, syms_of_lread):
7388 * macros.c (syms_of_macros):
7389 * msdos.c (syms_of_msdos):
7390 * print.c (syms_of_print):
7391 * process.c (syms_of_process):
7392 * search.c (syms_of_search):
7393 * sound.c (syms_of_sound):
7394 * syntax.c (init_syntax_once, syms_of_syntax):
7395 * terminal.c (syms_of_terminal):
7396 * textprop.c (syms_of_textprop):
7397 * undo.c (syms_of_undo):
7398 * w32.c (globals_of_w32):
7399 * window.c (syms_of_window):
7400 * xdisp.c (syms_of_xdisp):
7401 * xfaces.c (syms_of_xfaces):
7402 * xfns.c (syms_of_xfns):
7403 * xmenu.c (syms_of_xmenu):
7404 * xsettings.c (syms_of_xsettings):
7405 * xterm.c (syms_of_xterm): Use DEFSYM.
7407 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7409 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7411 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7413 Integer and buffer overflow fixes (Bug#8873).
7415 * print.c (printchar, strout): Check for string overflow.
7416 (PRINTPREPARE, printchar, strout):
7417 Don't set size unless allocation succeeds.
7419 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7420 for sizes. Check for string overflow more accurately.
7421 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7423 * macros.c: Integer and buffer overflow fixes.
7424 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7425 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7426 Use ptrdiff_t, not int, for sizes.
7427 Don't increment bufsize until after realloc succeeds.
7428 Check for size-calculation overflow.
7429 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7431 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7433 * lread.c: Integer overflow fixes.
7434 (read_integer): Radix is now EMACS_INT, not int,
7435 to improve quality of diagnostics for out-of-range radices.
7436 Calculate buffer size correctly for out-of-range radices.
7437 (read1): Check for integer overflow in radices, and in
7438 read-circle numbers.
7439 (read_escape): Avoid int overflow.
7440 (Fload, openp, read_buffer_size, read1)
7441 (substitute_object_recurse, read_vector, read_list, map_obarray):
7442 Use ptrdiff_t, not int, for sizes.
7443 (read1): Use EMACS_INT, not int, for sizes.
7444 Check for size overflow.
7446 * image.c (cache_image): Check for size arithmetic overflow.
7448 * lread.c: Integer overflow issues.
7449 (saved_doc_string_size, saved_doc_string_length)
7450 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7451 Now ptrdiff_t, not int.
7452 (read1): Don't assume doc string length fits in int. Check for
7453 out-of-range doc string lengths.
7454 (read_list): Don't assume file position fits in int.
7455 (read_escape): Check for hex character overflow.
7457 2011-06-22 Leo Liu <sdl.web@gmail.com>
7459 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7460 Move to minibuffer.el.
7462 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7464 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7465 The following patches are for when GLYPH_DEBUG && !XASSERT.
7466 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7467 * dispnew.c (flush_stdout):
7468 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7469 Mark as externally visible.
7470 * dispnew.c (check_window_matrix_pointers): Now static.
7471 * dispnew.c (window_to_frame_vpos):
7472 * xfns.c (unwind_create_frame):
7473 * xterm.c (x_check_font): Remove unused local.
7474 * scroll.c (CHECK_BOUNDS):
7475 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7476 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7477 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7478 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7479 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7481 (debug_method_add): Use va_list and vsprintf rather than relying
7482 on undefined behavior with wrong number of arguments.
7483 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7484 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7485 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7486 since we're not interested in debugging glyphs with old libraries.
7487 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7488 GCC 4.6.0's static checking.
7490 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7492 Integer overflow and signedness fixes (Bug#8873).
7493 A few related buffer overrun fixes, too.
7495 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7497 * dispextern.h (struct face.stipple):
7498 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7499 (x_bitmap_mask, x_allocate_bitmap_record)
7500 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7501 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7502 (x_create_bitmap_from_xpm_data):
7503 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7504 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7506 * xfaces.c (load_pixmap):
7507 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7508 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7509 (.bitmaps_last, struct x_output.icon_bitmap):
7510 Use ptrdiff_t, not int, for bitmap indexes.
7511 (x_allocate_bitmap_record): Check for size overflow.
7512 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7514 Use ptrdiff_t, not int, for overlay counts.
7515 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7516 * editfns.c (overlays_around, get_pos_property):
7517 * textprop.c (get_char_property_and_overlay):
7518 * xdisp.c (next_overlay_change, note_mouse_highlight):
7519 * xfaces.c (face_at_buffer_position):
7520 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7521 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7522 (Fnext_overlay_change, Fprevious_overlay_change)
7523 (mouse_face_overlay_overlaps, Foverlays_in):
7524 Use ptrdiff_t, not int, for sizes.
7525 (overlays_at, overlays_in): Check for size-calculation overflow.
7527 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7529 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7530 (x_session_initialize): Do not assume string length fits in int.
7532 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7533 This is unlikely, but can occur if DPI is outlandish.
7535 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7536 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7538 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7539 * xrdb.c (magic_file_p, search_magic_path):
7540 Omit last arg SUFFIX; it was always 0. All callers changed.
7541 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7543 * xfont.c (xfont_match): Avoid need for strlen.
7545 * xfns.c: Don't assume strlen fits in int.
7546 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7548 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7549 not unsigned long, as we prefer signed integers. All callers changed.
7550 Detect integer overflow in repeat count.
7551 (message_dolog): Don't assume print length fits in 39 bytes.
7552 (display_mode_element): Don't assume strlen fits in int.
7554 * termcap.c: Don't assume sizes fit in int and never overflow.
7555 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7556 (gobble_line): Check for size-calculation overflow.
7558 * minibuf.c (Fread_buffer):
7559 * lread.c (intern, intern_c_string):
7560 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7561 Don't assume string length fits in int.
7563 * keyboard.c (parse_tool_bar_item):
7564 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7566 * font.c: Don't assume string length fits in int.
7567 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7568 Use ptrdiff_t, not int.
7569 (font_intern_prop): Don't assume string length fits in int.
7570 Don't assume integer property fits in fixnum.
7571 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7573 * filelock.c: Fix some buffer overrun and integer overflow issues.
7574 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7575 Reformulate so as not to need the command string.
7576 Invoke gzip -cd rather than gunzip, as it's more portable.
7577 (lock_info_type, lock_file_1, lock_file):
7578 Don't assume pid_t and time_t fit in unsigned long.
7579 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7580 (current_lock_owner): Prefer signed type for sizes.
7581 Use memcpy, not strncpy, where memcpy is what is really wanted.
7582 Don't assume (via atoi) that time_t and pid_t fit in int.
7583 Check for time_t and/or pid_t out of range, e.g., via a network share.
7584 Don't alloca where an auto var works fine.
7586 * fileio.c: Fix some integer overflow issues.
7587 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7588 Don't assume string length fits in int.
7589 (directory_file_name): Don't assume string length fits in long.
7590 (make_temp_name): Don't assume pid fits in int, or that its print
7591 length is less than 20.
7593 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7595 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7597 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7599 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7600 We prefer signed integers, even for size calculations.
7602 * emacs.c: Don't assume string length fits in 'int'.
7603 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7604 (main): Don't invoke strlen when not needed.
7606 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7607 (XD_DEBUG_MESSAGE): Don't waste a byte.
7609 * callproc.c (getenv_internal_1, getenv_internal)
7611 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7613 * lread.c (invalid_syntax): Omit length argument.
7614 All uses changed. This doesn't fix a bug, but it simplifies the
7615 code away from its former Hollerith-constant appearance, and it's
7616 one less 'int' to worry about when looking at integer-overflow issues.
7617 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7619 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7620 This didn't break anything, but it didn't help either.
7621 It's confusing to put a bogus integer in a place where the actual
7622 value does not matter.
7623 (LIST_END_P): Remove unused macro and its bogus comment.
7624 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7626 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7627 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7629 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7630 We prefer signed types, and the value cannot exceed the EMACS_INT
7631 range anyway (because otherwise the length would not be representable).
7632 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7633 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7634 This avoids a GCC warning when WIDE_EMACS_INT.
7636 * indent.c (sane_tab_width): New function.
7637 (current_column, scan_for_column, Findent_to, position_indentation)
7638 (compute_motion): Use it. This is just for clarity.
7639 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7641 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7643 * lisp.h (lint_assume): New macro.
7644 * composite.c (composition_gstring_put_cache):
7645 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7647 * editfns.c, insdel.c:
7648 Omit unnecessary forward decls, to simplify future changes.
7650 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7652 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7654 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7655 Use much-faster test for byte-length change.
7656 Don't assume string byte-length fits in 'int'.
7657 Check that character arg fits in 'int'.
7658 (mapcar1): Declare byte as byte, for clarity.
7660 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7662 * fns.c (concat): Catch string overflow earlier.
7663 Do not rely on integer wraparound.
7665 * dispextern.h (struct it.overlay_strings_charpos)
7666 (struct it.selective): Now EMACS_INT, not int.
7667 * xdisp.c (forward_to_next_line_start)
7668 (back_to_previous_visible_line_start)
7669 (reseat_at_next_visible_line_start, next_element_from_buffer):
7670 Don't arbitrarily truncate the value of 'selective' to int.
7672 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7674 * composite.c: Don't truncate sizes to 'int'.
7675 (composition_gstring_p, composition_reseat_it)
7676 (composition_adjust_point): Use EMACS_INT, not int.
7677 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7678 not EMACS_UINT, for indexes.
7680 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7682 * buffer.c: Include <verify.h>.
7683 (struct sortvec.priority, struct sortstr.priority):
7684 Now EMACS_INT, not int.
7685 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7686 (struct sortstr.size, record_overlay_string)
7687 (struct sortstrlist.size, struct sortlist.used):
7688 Don't truncate size to int.
7689 (record_overlay_string): Check for size-calculation overflow.
7690 (init_buffer_once): Check at compile-time, not run-time.
7692 2011-06-22 Jim Meyering <meyering@redhat.com>
7694 Don't leak an XBM-image-sized buffer
7695 * image.c (xbm_load): Free the image buffer after using it.
7697 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7700 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7701 that Sun C diagnosed.
7702 * fns.c (secure_hash): Fix pointer signedness issue.
7703 * intervals.c (static_offset_intervals): New function.
7704 (offset_intervals): Use it.
7706 2011-06-21 Leo Liu <sdl.web@gmail.com>
7709 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7712 * fns.c (secure_hash): Rename from crypto_hash_function and change
7713 the first arg to accept symbols.
7714 (Fsecure_hash): New primitive.
7715 (syms_of_fns): New symbols.
7717 2011-06-20 Deniz Dogan <deniz@dogan.se>
7719 * process.c (Fset_process_buffer): Clarify return value in
7722 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7724 * dispnew.c (add_window_display_history): Use BVAR.
7726 * xdisp.c (debug_method_add): Use BVAR.
7727 (check_window_end, dump_glyph_matrix, dump_glyph)
7728 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7730 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7733 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7734 check till after the cache is created in init_frame_faces.
7736 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7738 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7740 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7742 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7743 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7744 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7746 Improve buffer-overflow checking (Bug#8873).
7747 * fileio.c (Finsert_file_contents):
7748 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7749 Remove the old (too-loose) buffer overflow checks.
7750 They weren't needed, since make_gap checks for buffer overflow.
7751 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7752 The old code merely checked for Emacs fixnum overflow, and relied
7753 on undefined (wraparound) behavior. The new code avoids undefined
7754 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7756 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7757 Tune. Don't use wider integers than needed. Don't use alloca.
7758 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7760 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7762 * insdel.c, lisp.h (buffer_overflow): New function.
7763 (insert_from_buffer_1, replace_range, replace_range_2):
7764 * insdel.c (make_gap_larger):
7765 * editfns.c (Finsert_char):
7766 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7768 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7770 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7772 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7774 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7775 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7777 * fileio.c: Don't assume EMACS_INT fits in off_t.
7778 (emacs_lseek): New static function.
7779 (Finsert_file_contents, Fwrite_region): Use it.
7780 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7782 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7784 * fns.c: Don't overflow int when computing a list length.
7785 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7786 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7787 truncation on 64-bit hosts. Check for QUIT every
7788 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7789 faster and is responsive enough.
7790 (Flength): Report an error instead of overflowing an integer.
7791 (Fsafe_length): Return a float if the value is not representable
7792 as a fixnum. This shouldn't happen except in contrived situations.
7793 (Fnthcdr, Fsort): Don't assume list length fits in int.
7794 (Fcopy_sequence): Don't assume vector length fits in int.
7796 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7797 (header_size, word_size): New constants.
7798 (allocate_vectorlike): Don't check size overflow here.
7799 (allocate_vector): Check it here instead, since this is the only
7800 caller of allocate_vectorlike that could cause overflow.
7801 Check that the new vector's length is representable as a fixnum.
7803 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7804 The previous code was bogus. For example, next_almost_prime (32)
7805 returned 39, which is undesirable as it is a multiple of 3; and
7806 next_almost_prime (24) returned 25, which is a multiple of 5 so
7807 why was the code bothering to check for multiples of 7?
7809 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7811 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7813 Variadic C functions now count arguments with ptrdiff_t.
7814 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7815 Back then I didn't know that the Emacs coding style prefers signed int.
7816 Also, in the meantime I found a few more instances where arguments
7817 were being counted with int, which may truncate counts on 64-bit
7818 machines, or EMACS_INT, which may be unnecessarily wide.
7819 * lisp.h (struct Lisp_Subr.function.aMANY)
7820 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7821 Arg counts are now ptrdiff_t, not size_t.
7822 All variadic functions and their callers changed accordingly.
7823 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7824 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7825 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7826 * callint.c (Fcall_interactively): Check arg count for overflow,
7827 to avoid potential buffer overrun. Use signed char, not 'int',
7828 for 'varies' array, so that we needn't bother to check its size
7829 calculation for overflow.
7830 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7831 * eval.c (apply_lambda):
7832 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7833 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7834 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7836 * callint.c (Fcall_interactively): Don't use index var as event count.
7838 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7839 * mem-limits.h (SIZE): Remove; no longer used.
7841 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7843 Remove unnecessary casts.
7844 * xterm.c (x_term_init):
7845 * xfns.c (x_set_border_pixel):
7846 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7847 These aren't needed now that we assume ANSI C.
7849 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7850 It's more likely to cause problems (due to unsigned overflow)
7853 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7855 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7857 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7859 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7861 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7863 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7865 GLYPH_CODE_FACE returns EMACS_INT, not int.
7866 * dispextern.h (merge_faces):
7867 * xfaces.c (merge_faces):
7868 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7869 Don't assume EMACS_INT fits in int.
7871 * character.h (CHAR_VALID_P): Remove unused parameter.
7872 * fontset.c, lisp.h, xdisp.c: All uses changed.
7874 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7876 * fns.c (concat): Minor tuning based on overflow analysis.
7877 This doesn't fix any bugs. Use int to hold character, instead
7878 of constantly refetching from Emacs object. Use XFASTINT, not
7879 XINT, for value known to be a character. Don't bother comparing
7880 a single byte to 0400, as it's always less.
7882 * floatfns.c (Fexpt):
7883 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7885 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7888 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7890 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7891 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7892 incorrectly succeed when S was a string, because 4294967386 was
7893 truncated before it was used.
7895 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7896 Otherwise, an out-of-range integer could cause undefined behavior
7899 * composite.c: Use int, not EMACS_INT, for characters.
7900 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7901 EMACS_INT, for values that are known to be in character range.
7902 This doesn't fix any bugs but is the usual style inside Emacs and
7903 may generate better code on 32-bit machines.
7905 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7906 This is for reasons similar to the recent CHAR_STRING fix.
7907 * charset.c (Fencode_char): Check that character arg is actually
7908 a character. Pass an int to ENCODE_CHAR.
7909 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7910 wider than 'int', as a compile-time check to prevent future regressions
7913 * character.c (char_string): Remove unnecessary casts.
7915 Make sure a 64-bit char is never passed to CHAR_STRING.
7916 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7917 by silently ignoring the top 32 bits, allowing some values
7918 that were far too large to be valid characters.
7919 * character.h: Include <verify.h>.
7920 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7921 arguments are no wider than unsigned, as a compile-time check
7922 to prevent future regressions in this area.
7924 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7925 (Fsubst_char_in_region):
7927 * xdisp.c (decode_mode_spec_coding):
7928 Adjust to CHAR_STRING's new requirement.
7929 * editfns.c (Finsert_char, Fsubst_char_in_region):
7930 * fns.c (concat): Check that character args are actually
7931 characters. Without this test, these functions did the wrong
7932 thing with wildly out-of-range values on 64-bit hosts.
7934 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7935 These casts should not be needed on 32-bit hosts, either.
7936 * keyboard.c (read_char):
7937 * lread.c (Fload): Remove casts to unsigned.
7939 * lisp.h (UNSIGNED_CMP): New macro.
7940 This fixes comparison bugs on 64-bit hosts.
7941 (ASCII_CHAR_P): Use it.
7942 * casefiddle.c (casify_object):
7943 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7944 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7945 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7946 * dispextern.h (FACE_FROM_ID):
7947 * keyboard.c (read_char): Use UNSIGNED_CMP.
7949 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7950 not to EMACS_INT, to avoid GCC warning.
7952 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7954 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7955 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7956 isn't needed on 32-bit machines.
7958 * buffer.c (Fgenerate_new_buffer_name):
7959 Use EMACS_INT for count, not int.
7960 (advance_to_char_boundary): Return EMACS_INT, not int.
7962 * data.c (Qcompiled_function): Now static.
7964 * window.c (window_body_lines): Now static.
7966 * image.c (gif_load): Rename local to avoid shadowing.
7968 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7969 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7970 * alloc.c (make_save_value): Integer argument is now of type
7972 (mark_object): Use ptrdiff_t, not int.
7973 * lisp.h (pD): New macro.
7974 * print.c (print_object): Use it.
7976 * alloc.c: Use EMACS_INT, not int, to count objects.
7977 (total_conses, total_markers, total_symbols, total_vector_size)
7978 (total_free_conses, total_free_markers, total_free_symbols)
7979 (total_free_floats, total_floats, total_free_intervals)
7980 (total_intervals, total_strings, total_free_strings):
7981 Now EMACS_INT, not int. All uses changed.
7982 (Fgarbage_collect): Compute overall total using a double, so that
7983 integer overflow is less likely to be a problem. Check for overflow
7984 when converting back to an integer.
7985 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7986 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7987 These were 'int' variables that could overflow on 64-bit hosts;
7988 they were never used, so remove them instead of repairing them.
7989 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7990 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7991 Previously, this ceilinged at INT_MAX, but that doesn't work on
7993 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7995 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7996 (allocate_vectorlike): Check for ptrdiff_t overflow.
7997 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7998 when a (possibly-narrower) signed value would do just as well.
7999 We prefer using signed arithmetic, to avoid comparison confusion.
8001 * alloc.c: Catch some string size overflows that we were missing.
8002 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8003 for convenience in STRING_BYTES_MAX.
8004 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8005 The definition here is exact; the one in lisp.h was approximate.
8006 (allocate_string_data): Check for string overflow. This catches
8007 some instances we weren't catching before. Also, it catches
8008 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8009 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8010 and ptrdiff_t and EMACS_INT are both 64 bits.
8012 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8013 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8014 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8016 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8018 * alloc.c (Fmake_string): Check for out-of-range init.
8020 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8022 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8024 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8026 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8027 xg_get_default_scrollbar_width.
8029 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8030 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8031 (style_changed_cb): Call update_theme_scrollbar_width and call
8032 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8033 all frames (Bug#8505).
8034 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8035 Call gtk_window_set_resizable if HAVE_GTK3.
8036 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8037 and height if HAVE_GTK3 (Bug#8505).
8038 (scroll_bar_width_for_theme): New variable.
8039 (update_theme_scrollbar_width): New function.
8040 (xg_get_default_scrollbar_width): Move code to
8041 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8042 (xg_initialize): Call update_theme_scrollbar_width.
8044 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8046 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8048 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8050 * frame.c (make_frame): Call other_buffer_safely instead of
8053 * window.c (temp_output_buffer_show): Call display_buffer with
8054 second argument Vtemp_buffer_show_specifiers and reset latter
8055 immediately after the call.
8056 (Vtemp_buffer_show_specifiers): New variable.
8057 (auto_window_vscroll_p, next_screen_context_lines)
8058 (Vscroll_preserve_screen_position): Remove leading asterisks from
8061 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8063 Fix minor problems found by GCC 4.6.0 static checking.
8064 * buffer.c (Qclone_number): Remove for now, as it's unused.
8065 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8066 (record_buffer): Remove unused local.
8067 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8068 (set_frame_buffer_list): Remove; unused.
8069 * frame.h (other_visible_frames): Remove decl.
8070 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8071 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8072 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8074 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8075 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8076 Define only if HAVE_GPM.
8077 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8078 (update_hints_inhibit): Remove; never set. All uses removed.
8079 * widgetprv.h (emacsFrameClassRec): Remove decl.
8080 * window.c (delete_deletable_window): Now returns void, since it
8081 wasn't returning anything.
8082 (compare_window_configurations): Remove unused locals.
8083 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8084 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8085 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8086 the same widths as pointers. This follows up on the 2011-05-06 patch.
8087 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8088 * xterm.h: Likewise.
8089 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8091 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8093 * makefile.w32-in: Update dependencies.
8094 (LISP_H): Add lib/intprops.h.
8096 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8098 * image.c (gif_load): Add animation frame delay to the metadata.
8099 (syms_of_image): Use DEFSYM. New symbol `delay'.
8101 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8103 * window.c (delete_deletable_window): Re-add.
8104 (Fset_window_configuration): Rewrite to handle dead buffers and
8105 consequently deletable windows.
8106 (window_tree, Fwindow_tree): Remove. Supply functionality in
8108 (compare_window_configurations): Simplify code.
8110 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8112 * image.c (imagemagick_load_image): Fix type mismatch.
8113 (Fimagemagick_types): Likewise.
8115 * window.h (replace_buffer_in_windows): Declare.
8117 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8119 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8120 Qclone_number. Remove external declaration of Qdelete_window.
8121 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8123 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8124 Run Qbuffer_list_update_hook if allowed.
8125 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8126 buffer list implementation.
8127 (other_buffer_safely): New function.
8128 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8129 calls to replace_buffer_in_windows and
8130 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8132 (record_buffer): Inhibit quitting and rewrite using quittable
8133 functions. Run Qbuffer_list_update_hook if allowed.
8134 (Frecord_buffer, Funrecord_buffer): New functions.
8135 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8136 Move switch-to-buffer to window.el.
8137 (bury-buffer): Move to window.el.
8138 (Vbuffer_list_update_hook): New variable.
8140 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8143 * window.h (resize_frame_windows): Move up in code.
8144 (Fwindow_frame): Remove EXFUN.
8145 (replace_buffer_in_all_windows): Remove prototype.
8146 (replace_buffer_in_windows_safely): Add prototype.
8148 * window.c: Declare Qdelete_window static again. Move down
8149 declaration of select_count.
8150 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8151 (Fother_window): Move to window.el.
8152 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8153 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8154 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8156 (replace_buffer_in_windows): Implement by calling
8157 Qreplace_buffer_in_windows.
8158 (replace_buffer_in_all_windows): Remove with some functionality
8159 moved into replace_buffer_in_windows_safely.
8160 (replace_buffer_in_windows_safely): New function.
8161 (select_window_norecord, select_frame_norecord): Move in front
8162 of run_window_configuration_change_hook. Remove now obsolete
8164 (Fset_window_buffer): Rewrite doc-string.
8165 Call Qrecord_window_buffer.
8166 (keys_of_window): Move binding for other-window to window.el.
8168 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8170 * dispextern.h (struct image): Replace data member, whose int_val
8171 and ptr_val fields were not used by anything, with a single
8174 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8175 (gif_clear_image, gif_load, imagemagick_load_image)
8176 (gs_clear_image, gs_load): Callers changed.
8178 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8180 * buffer.h: Include <time.h>, for time_t.
8181 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8183 Fix minor problems found by static checking.
8185 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8187 Make identifiers static if they are not used in other modules.
8188 * data.c (Qcompiled_function, Qframe, Qvector):
8189 * image.c (QimageMagick, Qsvg):
8190 * minibuf.c (Qmetadata):
8191 * window.c (resize_window_check, resize_root_window): Now static.
8192 * window.h (resize_window_check, resize_root_window): Remove decls.
8194 * window.c (window_deletion_count, delete_deletable_window):
8196 (window_body_lines): Now static.
8197 (Fdelete_other_windows_internal): Mark vars as initialized.
8198 Make sure 'resize_failed' is initialized.
8199 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8200 (resize_window_apply): Remove unused local.
8201 * window.h (delete_deletable_window): Remove decl.
8203 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8204 (imagemagick_load_image): Fix pointer signedness problem by changing
8205 last arg from unsigned char * to char *. All uses changed.
8206 Also, fix a local for similar reasons.
8207 Remove unused locals. Remove locals to avoid shadowing.
8208 (fn_rsvg_handle_free): Remove; unused.
8209 (svg_load, svg_load_image): Fix pointer signedness problem.
8210 (imagemagick_load_image): Don't use garbage pointer image_wand.
8212 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8214 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8216 * image.c (gif_load): Fix omitted cast error introduced by
8219 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8221 * window.h (resize_proportionally, orig_total_lines)
8222 (orig_top_line): Remove from window structure.
8223 (set_window_height, set_window_width, change_window_heights)
8224 (Fdelete_window): Remove prototypes.
8225 (resize_frame_windows): Remove duplicate declaration.
8227 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8229 * window.h (resize_frame_windows, resize_window_check)
8230 (delete_deletable_window, resize_root_window)
8231 (resize_frame_windows): Declare prototypes.
8233 * window.c (resize_window_apply): Make definition be "static" to
8234 match the prototype.
8236 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8238 * window.c: Remove declarations of Qwindow_size_fixed,
8239 window_min_size_1, window_min_size_2, window_min_size,
8240 size_window, window_fixed_size_p, enlarge_window, delete_window.
8241 Remove static from declaration of Qdelete_window, it's
8242 temporarily needed by Fbury_buffer.
8243 (replace_window): Don't assign orig_top_line and
8245 (Fdelete_window, delete_window): Remove. Window deletion is
8246 handled by window.el.
8247 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8248 Replace Fdelete_window calls with calls to Qdelete_window.
8249 (Fdelete_other_windows): Remove. Deleting other windows is
8250 handled by window.el.
8251 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8252 handled in window.el.
8253 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8254 Window minimum sizes are handled in window.el.
8255 (shrink_windows, size_window, set_window_height)
8256 (set_window_width, change_window_heights, window_height)
8257 (window_width, CURBEG, CURSIZE, enlarge_window)
8258 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8259 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8260 handled in window.el.
8261 (make_dummy_parent): Rename to make_parent_window and give it a
8262 second argument horflag.
8263 (make_window): Don't set resize_proportionally any more.
8264 (Fsplit_window): Remove. Windows are split in window.el.
8265 (save_restore_action, save_restore_orig_size)
8266 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8267 Resize mini windows in window.el.
8268 (grow_mini_window, shrink_mini_window): Implement by calling
8269 Qresize_root_window_vertically, resize_window_check and
8270 resize_window_apply.
8271 (saved_window, Fset_window_configuration, save_window_save):
8272 Do not handle orig_top_line, orig_total_lines, and
8273 resize_proportionally.
8274 (window_min_height, window_min_width): Move to window.el.
8275 (keys_of_window): Move bindings for delete-other-windows,
8276 split-window, delete-window and enlarge-window to window.el.
8278 * buffer.c: Temporarily extern Qdelete_window.
8279 (Fbury_buffer): Temporarily call Qdelete_window instead of
8280 Fdelete_window (Fbury_buffer will move to window.el soon).
8282 * frame.c (set_menu_bar_lines_1): Remove code handling
8283 orig_top_line and orig_total_lines.
8285 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8286 set_window_height but set heights directly.
8287 (change_frame_size_1): Use resize_frame_windows.
8289 * xdisp.c (init_xdisp): Don't use set_window_height but set
8292 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8293 Use resize_frame_windows instead of change_window_heights and run
8294 run_window_configuration_change_hook.
8296 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8297 instead of change_window_heights and run
8298 run_window_configuration_change_hook.
8300 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8302 * window.c (replace_window): Rename second argument REPLACEMENT to
8303 NEW. New third argument SETFLAG. Rewrite.
8304 (delete_window, make_dummy_parent): Call replace_window with
8306 (window_list_1): Move down in code.
8307 (run_window_configuration_change_hook): Move set_buffer part
8308 before select_frame_norecord part in order to unwind correctly.
8309 Rename count1 to count.
8310 (recombine_windows, delete_deletable_window, resize_root_window)
8311 (Fdelete_other_windows_internal)
8312 (Frun_window_configuration_change_hook, make_parent_window)
8313 (resize_window_check, resize_window_apply, Fresize_window_apply)
8314 (resize_frame_windows, Fsplit_window_internal)
8315 (Fdelete_window_internal, Fresize_mini_window_internal):
8317 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8319 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8321 * window.h (window): Add some new members to window structure -
8322 normal_lines, normal_cols, new_total, new_normal, clone_number,
8323 splits, nest, prev_buffers, next_buffers.
8324 (WINDOW_TOTAL_SIZE): Move here from window.c.
8325 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8327 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8329 (make_dummy_parent): Set new members of windows structure.
8330 (make_window): Move down in code. Handle new members of window
8332 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8333 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8334 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8335 (Fset_window_prev_buffers, Fwindow_next_buffers)
8336 (Fset_window_next_buffers, Fset_window_clone_number):
8338 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8339 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8341 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8342 Argument WINDOW can be now internal window too.
8343 (Fwindow_use_time): Move up in code.
8344 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8346 (Fset_window_configuration, saved_window)
8347 (Fcurrent_window_configuration, save_window_save): Handle new
8348 members of window structure.
8349 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8350 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8351 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8352 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8353 Qget_mru_window, Qresize_root_window,
8354 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8355 Qauto_buffer_name; staticpro them.
8357 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8359 * window.c (Fwindow_total_size, Fwindow_left_column)
8360 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8361 (Fwindow_list_1): New functions.
8362 (window_box_text_cols): Replace with window_body_cols.
8363 (Fwindow_width, Fscroll_left, Fscroll_right):
8364 Use window_body_cols instead of window_box_text_cols.
8365 (delete_window, Fset_window_configuration):
8366 Call delete_all_subwindows with window as argument.
8367 (delete_all_subwindows): Take a window as argument and not a
8369 (window_loop): Remove handling of GET_LRU_WINDOW and
8371 (Fget_lru_window, Fget_largest_window): Move to window.el.
8373 * window.h: Extern window_body_cols instead of
8374 window_box_text_cols. delete_all_subwindows now takes a
8375 Lisp_Object as argument.
8377 * indent.c (compute_motion, Fcompute_motion):
8378 Use window_body_cols instead of window_box_text_cols.
8380 * frame.c (delete_frame): Call delete_all_subwindows with root
8383 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8385 * fns.c (Fputhash): Document return value.
8387 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8389 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8391 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8393 Cons<->int and similar integer overflow fixes (Bug#8794).
8395 Check for overflow when converting integer to cons and back.
8396 * charset.c (Fdefine_charset_internal, Fdecode_char):
8397 Use cons_to_unsigned to catch overflow.
8398 (Fencode_char): Use INTEGER_TO_CONS.
8399 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8400 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8401 * data.c (long_to_cons, cons_to_long): Remove.
8402 (cons_to_unsigned, cons_to_signed): New functions.
8403 These signal an error for invalid or out-of-range values.
8404 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8405 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8406 * font.c (Ffont_variation_glyphs):
8407 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8408 * lisp.h: Include <intprops.h>.
8409 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8410 (cons_to_signed, cons_to_unsigned): New decls.
8411 (long_to_cons, cons_to_long): Remove decls.
8412 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8413 (Fprimitive_undo): Use CONS_TO_INTEGER.
8414 * xfns.c (Fx_window_property): Likewise.
8415 * xselect.c: Include <limits.h>.
8416 (x_own_selection, selection_data_to_lisp_data):
8417 Use INTEGER_TO_CONS.
8418 (x_handle_selection_request, x_handle_selection_clear)
8419 (x_get_foreign_selection, Fx_disown_selection_internal)
8420 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8421 (lisp_data_to_selection_data): Use cons_to_unsigned.
8422 (x_fill_property_data): Use cons_to_signed.
8423 Report values out of range.
8425 Check for buffer and string overflow more precisely.
8426 * buffer.h (BUF_BYTES_MAX): New macro.
8427 * lisp.h (STRING_BYTES_MAX): New macro.
8428 * alloc.c (Fmake_string):
8429 * character.c (string_escape_byte8):
8430 * coding.c (coding_alloc_by_realloc):
8431 * doprnt.c (doprnt):
8432 * editfns.c (Fformat):
8434 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8435 since they may not be the same number.
8436 * editfns.c (Finsert_char):
8437 * fileio.c (Finsert_file_contents):
8438 Likewise for BUF_BYTES_MAX.
8440 * image.c: Use ptrdiff_t, not int, for sizes.
8441 (slurp_file): Switch from int to ptrdiff_t.
8443 (slurp_file): Check that file size fits in both size_t (for
8444 malloc) and ptrdiff_t (for sanity and safety).
8446 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8447 if b->modtime has its maximal value.
8449 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8451 Don't assume time_t can fit into int.
8452 * buffer.h (struct buffer.modtime): Now time_t, not int.
8453 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8454 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8456 Minor fixes for signed vs unsigned integers.
8457 * character.h (MAYBE_UNIFY_CHAR):
8458 * charset.c (maybe_unify_char):
8459 * keyboard.c (read_char, reorder_modifiers):
8460 XINT -> XFASTINT, since the integer must be nonnegative.
8461 * ftfont.c (ftfont_spec_pattern):
8462 * keymap.c (access_keymap, silly_event_symbol_error):
8463 XUINT -> XFASTINT, since the integer must be nonnegative.
8464 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8465 since it makes no difference and we prefer signed.
8466 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8467 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8470 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8472 * window.h (Fwindow_frame): Declare.
8474 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8476 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8477 (SPARE_MEMORY): Always define.
8478 (LARGE_REQUEST): Remove.
8479 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8481 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8483 * lisp.h: Move EXFUNS for Fframe_root_window,
8484 Fframe_first_window and Fset_frame_selected_window to window.h.
8486 * window.h: Move EXFUNS for Fframe_root_window,
8487 Fframe_first_window and Fset_frame_selected_window here from
8490 * frame.c (Fwindow_frame, Fframe_first_window)
8491 (Fframe_root_window, Fframe_selected_window)
8492 (Fset_frame_selected_window): Move to window.c.
8493 (Factive_minibuffer_window): Move to minibuf.c.
8494 (Fother_visible_frames_p): New function.
8496 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8498 * window.c (decode_window, decode_any_window): Move up in code.
8499 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8500 (inhibit_frame_unsplittable): Remove unused variable.
8501 (Fwindow_buffer): Move up and rewrite doc-string.
8502 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8503 (Fwindow_prev): New functions.
8504 (Fwindow_frame): Move here from frame.c. Accept any window as
8506 (Fframe_root_window, Fframe_first_window)
8507 (Fframe_selected_window): Move here from frame.c. Accept frame
8508 or arbitrary window as argument. Update doc-strings.
8509 (Fminibuffer_window): Move up in code.
8510 (Fwindow_minibuffer_p): Move up in code and simplify.
8511 (Fset_frame_selected_window): Move here from frame.c.
8513 (Fselected_window, select_window, Fselect_window): Move up in
8514 code. Minor doc-string fixes.
8516 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8518 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8519 Do not assume that spare memory exists; that assumption is valid
8520 only if SYSTEM_MALLOC.
8521 (LARGE_REQUEST): New macro, so that the issue of large requests
8522 is separated from the issue of spare memory.
8524 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8526 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8529 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8531 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8534 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8536 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8538 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8540 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8541 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8543 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8545 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8547 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8549 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8550 (x_clipboard_manager_save): Add return value.
8551 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8553 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8554 Obey Vx_select_enable_clipboard_manager. Catch errors in
8555 x_clipboard_manager_save (Bug#8779).
8556 (Vx_select_enable_clipboard_manager): New variable.
8557 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8559 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8561 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8563 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8565 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8566 in the current matrix if keep_current_p is non-zero.
8568 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8570 * bidi.c (bidi_level_of_next_char): Fix last change.
8572 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8574 Support bidi reordering of text covered by display properties.
8576 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8577 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8578 (bidi_cache_search, bidi_cache_iterator_state)
8579 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8580 (bidi_level_of_next_char, bidi_move_to_visually_next):
8581 Support character positions inside a run of characters covered by a
8583 (bidi_paragraph_init, bidi_resolve_explicit_1)
8584 (bidi_level_of_next_char): Call bidi_fetch_char and
8585 bidi_fetch_char_advance instead of FETCH_CHAR and
8587 (bidi_init_it): Initialize new members.
8588 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8590 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8591 instead of using explicit *_CHAR codes.
8592 (bidi_resolve_explicit, bidi_resolve_weak):
8593 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8594 bidirectional text is supported only in multibyte buffers.
8595 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8596 it to initialize the frame_window_p member of struct bidi_it.
8597 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8598 (bidi_resolve_explicit, bidi_resolve_weak)
8599 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8600 bidi_it->nchars is non-positive.
8601 (bidi_level_of_next_char): Don't try to lookup the cache for the
8602 next/previous character if nothing is cached there yet, or if we
8603 were just reseat()'ed to a new position.
8605 * xdisp.c (set_cursor_from_row): Set start and stop points
8606 according to the row's direction when priming the loop that looks
8607 for the glyph on which to display cursor.
8608 (single_display_spec_intangible_p): Function deleted.
8609 (display_prop_intangible_p): Reimplement to call
8610 handle_display_spec instead of single_display_spec_intangible_p.
8611 Accept 3 additional arguments needed by handle_display_spec.
8612 This fixes incorrect cursor motion across display property with complex
8613 values: lists, `(when COND...)' forms, etc.
8614 (single_display_spec_string_p): Support property values that are
8615 lists with the argument STRING its top-level element.
8616 (display_prop_string_p): Fix the condition for processing a
8617 property that is a list to be consistent with handle_display_spec.
8618 (handle_display_spec): New function, refactored from the
8619 last portion of handle_display_prop.
8620 (compute_display_string_pos): Accept additional argument
8621 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8622 value of a `display' property is a "replacing spec".
8623 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8624 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8625 the display property, but just return a value indicating whether
8626 the display property will replace the characters it covers.
8627 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8628 frame_window_p members of struct bidi_it.
8629 (compute_display_string_pos, compute_display_string_end):
8631 (push_it): Accept second argument POSITION, where pop_it should
8632 jump to continue iteration.
8633 (reseat_1): Initialize bidi_it.disp_pos.
8635 * keyboard.c (adjust_point_for_property): Adjust the call to
8636 display_prop_intangible_p to its new signature.
8638 * dispextern.h (struct bidi_it): New member frame_window_p.
8639 (bidi_init_it): Update prototypes.
8640 (display_prop_intangible_p): Update prototype.
8641 (compute_display_string_pos, compute_display_string_end):
8643 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8646 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8648 Malloc failure behavior now depends on size of allocation.
8649 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8650 * lisp.h: Change signatures accordingly.
8651 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8652 All callers changed. (Bug#8762)
8654 * gnutls.c: Use Emacs's memory allocators.
8655 Without this change, the gnutls library would invoke malloc etc.
8656 directly, which causes problems on non-SYNC_INPUT hosts, and which
8657 runs afoul of improving memory_full behavior. (Bug#8761)
8658 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8659 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8660 xfree instead of the default malloc, realloc, free.
8661 (Fgnutls_boot): No need to check for memory allocation failure,
8662 since xmalloc does that for us.
8664 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8665 * category.c (hash_get_category_set):
8666 * ccl.c (ccl_driver):
8667 * charset.c (Fdefine_charset_internal):
8668 * charset.h (struct charset.hash_index):
8669 * composite.c (get_composition_id, gstring_lookup_cache)
8670 (composition_gstring_put_cache):
8671 * composite.h (struct composition.hash_index):
8672 * dispextern.h (struct image.hash):
8673 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8674 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8675 (hashfn_equal, hashfn_user_defined, make_hash_table)
8676 (maybe_resize_hash_table, hash_lookup, hash_put)
8677 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8678 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8679 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8680 * image.c (make_image, search_image_cache, lookup_image)
8681 (xpm_put_color_table_h):
8682 * lisp.h (struct Lisp_Hash_Table):
8683 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8684 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8685 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8686 * alloc.c (allocate_vectorlike):
8687 Check for overflow in vector size calculations.
8688 * ccl.c (ccl_driver):
8689 Check for overflow when converting EMACS_INT to int.
8690 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8691 need to be updated by these changes.
8692 * fns.c (make_hash_table, maybe_resize_hash_table):
8693 Check for integer overflow with large hash tables.
8694 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8695 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8696 (SXHASH_REDUCE): New macro.
8697 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8698 Use it instead of discarding useful hash info with large hash values.
8699 (sxhash_float): New function.
8700 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8701 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8702 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8703 Rewrite to use FIXNUM_BITS, as this simplifies things.
8704 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8705 Adjust signatures to match updated version of code.
8706 (consing_since_gc): Now EMACS_INT, since a single hash table can
8707 use more than INT_MAX bytes.
8709 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8711 Make it possible to build with GCC-4.6+ -O2 -flto.
8713 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8715 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8717 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8718 Call minibuffer-inactive-mode.
8720 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8722 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8723 Update dependencies.
8725 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8727 * data.c (init_data): Remove code for UTS, this system is not
8730 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8732 Don't force ./temacs to start in terminal mode.
8734 * frame.c (make_initial_frame): Initialize faces in all cases, not
8735 only when CANNOT_DUMP is defined.
8736 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8738 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8740 * dispnew.c (add_window_display_history): Use const for the string
8741 pointer. Remove declaration, not needed.
8743 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8745 Use 'inline', not 'INLINE'.
8746 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8747 * alloc.c, fontset.c (INLINE): Remove.
8748 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8749 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8750 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8751 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8752 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8754 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8756 Make it possible to run ./temacs.
8758 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8759 syms_of_callproc does the same thing. Remove test for
8760 "initialized", do it in the caller.
8761 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8763 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8765 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8766 (read_minibuf): Use get_minibuffer.
8767 (syms_of_minibuf): Use DEFSYM.
8768 (Qmetadata): New var.
8769 * data.c (Qbuffer): Don't make it static.
8770 (syms_of_data): Use DEFSYM.
8772 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8774 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8775 (CCL_CODE_MIN): New macro.
8777 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8779 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8781 * eval.c (Qdebug): Now static.
8782 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8783 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8784 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8786 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8788 * image.c: Various fixes to ImageMagick code comments.
8789 (Fimagemagick_types): Doc fix.
8791 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8793 Minor fixes prompted by GCC 4.6.0 warnings.
8795 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8797 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8798 (x_clipboard_manager_save_all): Move extern decl to ...
8799 * xterm.h: ... here, so that it can be checked for consistency.
8801 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8803 * xselect.c (x_clipboard_manager_save_frame)
8804 (x_clipboard_manager_save_all): New functions.
8805 (Fx_clipboard_manager_save): Lisp function deleted.
8807 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8808 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8810 * xterm.h: Update prototype.
8812 2011-05-28 William Xu <william.xwl@gmail.com>
8814 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8817 2011-05-28 Jim Meyering <meyering@redhat.com>
8819 Avoid a sign-extension bug in crypto_hash_function.
8820 * fns.c (to_uchar): Define.
8821 (crypto_hash_function): Use it to convert some newly-signed
8822 variables to unsigned, to avoid sign-extension bugs. For example,
8823 without this change, (md5 "truc") would evaluate to
8824 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8825 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8826 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8828 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8830 Integer overflow fixes.
8832 * dbusbind.c: Serial number integer overflow fixes.
8833 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8834 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8835 to hold a serial number that is too large for a fixnum.
8836 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8837 Check for serial numbers out of range. Decode any serial number
8838 that was so large that it became a float. (Bug#8722)
8840 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8841 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8842 Use XFASTINT rather than XUINT when numbers are nonnegative.
8843 (xd_append_arg, Fdbus_method_return_internal):
8844 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8845 arguments, check that Lisp number is nonnegative, rather than
8846 silently wrapping negative numbers around. (Bug#8722)
8847 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8850 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8852 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8854 ccl: Add integer overflow checks.
8855 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8856 (IN_INT_RANGE): New macros.
8857 (ccl_driver): Use them to check for integer overflow when
8858 decoding a CCL program. Many of the new checks are whether XINT (x)
8859 fits in int; it doesn't always, on 64-bit hosts. The new version
8860 doesn't catch all possible integer overflows, but it's an
8861 improvement. (Bug#8719)
8863 * alloc.c (make_event_array): Use XINT, not XUINT.
8864 There's no need for unsigned here.
8866 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8867 This follows up to the 2011-05-06 change that substituted uintptr_t
8868 for EMACS_INT. This case wasn't caught back then.
8870 Rework Fformat to avoid integer overflow issues.
8871 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8872 now (part of C89). Include <verify.h>.
8873 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8874 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8875 (Fformat): Avoid the prepass trying to compute sizes; it was only
8876 approximate and thus did not catch overflow reliably. Instead, walk
8877 through the format just once, formatting and computing sizes as we go,
8878 checking for integer overflow at every step, and allocating a larger
8879 buffer as needed. Keep track separately whether the format is
8880 multibyte. Keep only the most-recently calculated precision, rather
8881 than them all. Record whether each argument has been converted to
8882 string. Use EMACS_INT, not int, for byte and char and arg counts.
8883 Support field widths and precisions larger than INT_MAX. Avoid
8884 sprintf's undefined behavior with conversion specifications such as %#d
8885 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8886 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8887 formatting out-of-range floating point numbers with int
8890 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8892 * data.c: Avoid integer truncation in expressions involving floats.
8893 * data.c: Include <intprops.h>.
8894 (arith_driver): When there's an integer overflow in an expression
8895 involving floating point, convert the integers to floating point
8896 so that the resulting value does not suffer from catastrophic
8897 integer truncation. For example, on a 64-bit host (* 4
8898 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8899 Do not rely on undefined behavior after integer overflow.
8901 merge count_size_as_multibyte, parse_str_to_multibyte
8902 * character.c, character.h (count_size_as_multibyte):
8903 Rename from parse_str_to_multibyte; all uses changed.
8904 Check for integer overflow.
8905 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8906 since it's now a duplicate of the other. This is more of
8907 a character than a buffer op, so better that it's in character.c.
8908 * fns.c, print.c: Adjust to above changes.
8910 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8912 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8914 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8916 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8917 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8918 (x_clipboard_manager_save): Now static.
8919 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8921 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8922 (crypto_hash_function): Now static.
8923 Fix pointer signedness problems. Avoid unnecessary initializations.
8925 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8927 * termhooks.h (Vselection_alist): Make it terminal-local.
8929 * terminal.c (create_terminal): Initialize it.
8931 * xselect.c: Support for clipboard managers.
8932 (Vselection_alist): Move to termhooks.h as terminal-local var.
8933 (LOCAL_SELECTION): New macro.
8934 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8935 (symbol_to_x_atom): Remove gratuitous arg.
8936 (x_handle_selection_request, lisp_data_to_selection_data)
8937 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8938 (x_own_selection, x_get_local_selection, x_convert_selection):
8939 New arg, specifying work frame. Use terminal-local Vselection_alist.
8940 (some_frame_on_display): Delete unused function.
8941 (Fx_own_selection_internal, Fx_get_selection_internal)
8942 (Fx_disown_selection_internal, Fx_selection_owner_p)
8943 (Fx_selection_exists_p): New optional frame arg.
8944 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8945 (x_handle_selection_clear): Don't treat other terminals with the
8946 same keyboard specially. Use the terminal-local Vselection_alist.
8947 (x_clear_frame_selections): Use Frun_hook_with_args.
8949 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8951 * xterm.h: Add support for those atoms.
8953 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8955 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8956 (converted_selections, conversion_fail_tag): New global variables.
8957 (x_selection_request_lisp_error): Free the above.
8958 (x_get_local_selection): Remove unnecessary code.
8959 (x_reply_selection_request): Args changed; handle arbitrary array
8960 of converted selections stored in converted_selections.
8961 Separate the XChangeProperty and SelectionNotify steps.
8962 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8963 (x_convert_selection): New function.
8964 (x_handle_selection_event): Simplify.
8965 (x_get_foreign_selection): Don't ignore incoming requests while
8966 waiting for an answer; this will fail when we implement
8967 SAVE_TARGETS, and seems unnecessary anyway.
8968 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8969 (Vx_sent_selection_functions): Doc fix.
8971 2011-05-26 Leo Liu <sdl.web@gmail.com>
8973 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8975 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8977 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8979 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8980 for fringe update if it has periodic bitmap.
8981 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8982 and fringe_bitmap_periodic_p.
8984 * fringe.c (get_fringe_bitmap_data): New function.
8985 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8986 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8987 row. Mark glyph row for fringe update if periodicity changed.
8989 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8990 for fringe update unless it has periodic bitmap.
8992 2011-05-25 Kenichi Handa <handa@m17n.org>
8994 * xdisp.c (get_next_display_element): Set correct it->face_id for
8995 a static composition.
8997 2011-05-24 Leo Liu <sdl.web@gmail.com>
9000 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9002 * fns.c (crypto_hash_function, Fsha1): New function.
9003 (Fmd5): Use crypto_hash_function.
9004 (syms_of_fns): Add Ssha1.
9006 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9008 * gnutls.c: Remove unused macros.
9009 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9010 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9011 Remove macros that are defined and never used.
9012 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9014 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9016 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9017 (Fx_get_selection_internal): Minor cleanup.
9018 (Fx_own_selection_internal): Rename arguments for consistency with
9021 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9023 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9025 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9027 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9029 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9031 * dispnew.c (scrolling_window): Don't exclude the case that the
9032 last enabled row in the desired matrix touches the bottom boundary.
9034 2011-05-21 Glenn Morris <rgm@gnu.org>
9036 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9037 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9038 and add some more files.
9040 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9042 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9043 report_file_error introduced by the change from 2011-05-07.
9045 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9047 * systime.h (Time): Define only if emacs is defined.
9048 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9049 where the include path doesn't have X11/X.h by default. See
9050 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9052 2011-05-20 Kenichi Handa <handa@m17n.org>
9054 * composite.c (find_automatic_composition): Fix previous change.
9056 2011-05-20 Glenn Morris <rgm@gnu.org>
9058 * lisp.mk: New file, split from Makefile.in.
9059 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9060 (shortlisp): Remove.
9061 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9063 2011-05-19 Glenn Morris <rgm@gnu.org>
9065 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9066 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9067 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9068 (lisp): Set the order to that of loadup.el.
9069 (shortlisp): Make it a copy of $lisp.
9070 (SOME_MACHINE_LISP): Remove.
9071 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9072 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9074 2011-05-18 Kenichi Handa <handa@m17n.org>
9076 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9077 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9078 (find_automatic_composition): Mostly rewrite for efficiency.
9080 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9082 * makefile.w32-in: Update dependencies.
9084 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9086 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9087 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9089 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9091 Fix some integer overflow issues, such as string length overflow.
9093 * insdel.c (count_size_as_multibyte): Check for string overflow.
9095 * character.c (lisp_string_width): Check for string overflow.
9096 Use EMACS_INT, not int, for string indexes and lengths; in
9097 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9098 the resulting string length overflows an EMACS_INT; instead,
9099 report a string overflow if no precision given. When checking for
9100 precision exhaustion, use a check that cannot possibly have
9101 integer overflow. (Bug#8675)
9102 * character.h (lisp_string_width): Adjust to new signature.
9104 * alloc.c (string_overflow): New function.
9105 (Fmake_string): Use it. This doesn't change behavior, but saves
9106 a few bytes and will simplify future changes.
9107 * character.c (string_escape_byte8): Likewise.
9108 * lisp.h (string_overflow): New decl.
9110 Fixups, following up to the user-interface timestamp change.
9111 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9112 for UI timestamps, instead of unsigned long.
9113 * msdos.c (mouse_get_pos): Likewise.
9114 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9115 * w32gui.h (Time): Define by including "systime.h" rather than by
9116 declaring it ourselves. (Bug#8664)
9118 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9119 * image.c (clear_image_cache): Likewise.
9121 * term.c (term_mouse_position): Don't assume time_t wraparound.
9123 Be more systematic about user-interface timestamps.
9124 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9125 and sometimes 'EMACS_UINT', to represent these timestamps.
9126 This change causes it to use 'Time' uniformly, as that's what X uses.
9127 This makes the code easier to follow, and makes it easier to catch
9128 integer overflow bugs such as Bug#8664.
9129 * frame.c (Fmouse_position, Fmouse_pixel_position):
9130 Use Time, not unsigned long, for user-interface timestamps.
9131 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9132 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9133 * keyboard.h (last_event_timestamp): Likewise.
9134 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9135 * menu.h (xmenu_show): Likewise.
9136 * term.c (term_mouse_position): Likewise.
9137 * termhooks.h (struct input_event.timestamp): Likewise.
9138 (struct terminal.mouse_position_hook): Likewise.
9139 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9140 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9141 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9142 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9144 * menu.h, termhooks.h: Include "systime.h", for Time.
9146 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9147 Don't assume that the difference between two unsigned long values
9148 can fit into an integer. At this point, we know button_down_time
9149 <= event->timestamp, so the difference must be nonnegative, so
9150 there's no need to cast the result if double-click-time is
9151 nonnegative, as it should be; check that it's nonnegative, just in
9152 case. This bug is triggered when events are more than 2**31 ms
9153 apart (about 25 days). (Bug#8664)
9155 * xselect.c (last_event_timestamp): Remove duplicate decl.
9156 (x_own_selection): Remove needless cast to unsigned long.
9158 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9159 that always fit in int. Use a sentinel instead of a counter, to
9160 avoid a temp and to allay GCC's concerns about possible int overflow.
9161 * frame.h (struct frame): Use int for menu_bar_items_used
9162 instead of EMACS_INT, since it always fits in int.
9164 * menu.c (grow_menu_items): Check for int overflow.
9166 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9168 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9169 Before, the code was not consistent. These values cannot exceed
9170 2**31 - 1 so there's no need to make them unsigned.
9171 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9172 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9173 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9175 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9177 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9178 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9179 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9180 presumably because the widths might not match.
9182 * window.c (size_window): Avoid needless test at loop start.
9184 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9186 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9188 2011-05-12 Drew Adams <drew.adams@oracle.com>
9190 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9192 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9194 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9195 `width' to `bar_area_x' and `bar_area_width', respectively.
9196 (x_scroll_run): Take account of fringe background extension.
9198 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9199 Rename local vars `left' and `width' to `bar_area_x' and
9200 `bar_area_width', respectively.
9201 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9202 background extension.
9204 2011-05-10 Jim Meyering <meyering@redhat.com>
9206 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9208 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9210 * image.c (Finit_image_library): Return t for built-in image types,
9211 like pbm and xbm. (Bug#8640)
9213 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9215 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9217 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9219 * w32console.c (Fset_screen_color): Doc fix.
9220 (Fget_screen_color): New function.
9221 (syms_of_ntterm): Defsubr it.
9223 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9224 unlink the temporary file if Fcall_process didn't create it in the
9226 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9227 child process will be redirected to a file specified with `:file'.
9228 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9229 cue to call_process_cleanup not to close that handle.
9231 2011-05-07 Ben Key <bkey76@gmail.com>
9233 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9234 one of two shell specific rules, either bootstrap-temacs-CMD or
9235 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9236 to the previous implementation of the bootstrap-temacs rule.
9237 The bootstrap-temacs-CMD rule is similar to the previous
9238 implementation of the bootstrap-temacs rule except that it
9239 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9242 These changes, along with some changes to nt/configure.bat,
9243 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9244 earlier fix to add support for --cflags and --ldflags options
9245 that include quotes so that it works whether make uses cmd or
9248 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9250 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9251 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9253 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9254 a string. Handle both cases.
9255 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9256 (Fdbus_register_method): Use Qinvalid_function.
9258 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9260 * makefile.w32-in: Update dependencies.
9261 (LISP_H): Add inttypes.h and stdin.h.
9262 (PROCESS_H): Add unistd.h.
9264 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9266 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9267 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9269 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9271 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9273 * term.c (vfatal): Remove stray call to va_end.
9274 It's not needed and the C Standard doesn't allow it here anyway.
9276 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9277 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9279 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9282 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9284 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9286 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9288 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9290 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9292 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9293 * charset.c (Fdefine_charset_internal): Don't initialize
9294 charset.code_space[15]. The value was garbage, on hosts with
9295 32-bit int (Bug#8600).
9297 * lread.c (read_integer): Be more consistent with string-to-number.
9298 Use string_to_number to do the actual conversion; this avoids
9299 rounding errors and fixes some other screwups. Without this fix,
9300 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9301 (digit_to_number): Move earlier, for benefit of read_integer.
9302 Return -1 if the digit is out of range for the base, -2 if it is
9303 not a digit in any supported base. (Bug#8602)
9305 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9307 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9308 to match comment at start of function. This also removes a
9309 GCC warning about overflow in a 32+64-bit port.
9311 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9313 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9314 Reported by Stefan Monnier in
9315 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9316 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9317 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9319 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9320 (EMACS_UINTPTR): Likewise, with uintptr_t.
9322 * lisp.h: Prefer 64-bit EMACS_INT if available.
9323 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9324 on 32-bit hosts that have 64-bit int, so that they can access
9326 However, temporarily disable this change unless the temporary
9327 symbol WIDE_EMACS_INT is defined.
9329 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9331 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9332 This removes an assumption that EMACS_INT and long are the same
9333 width as pointers. The assumption is true for Emacs porting targets
9334 now, but we want to make other targets possible.
9335 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9336 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9337 In the rest of the code, change types of integers that hold casted
9338 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9339 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9340 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9341 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9342 No need to cast type when ORing.
9343 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9344 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9345 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9346 assume EMACS_INT is the same width as char *.
9347 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9348 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9349 Remove no-longer-needed casts.
9350 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9351 (xg_tool_bar_help_callback, xg_make_tool_item):
9352 Use EMACS_INTPTR to hold an integer
9353 that will be cast to void *; this can avoid a GCC warning
9354 if EMACS_INT is not the same width as void *.
9355 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9356 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9357 (current_message_1, set_message_1):
9358 Use a local to convert to proper width without a cast.
9359 * xmenu.c (dialog_selection_callback): Likewise.
9361 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9362 Also, don't assume VALBITS / RAND_BITS is less than 5,
9363 and don't rely on undefined behavior when shifting a 1 left into
9365 * lisp.h (get_random): Change signature to match.
9367 * lread.c (hash_string): Use size_t, not int, for hash computation.
9368 Normally we prefer signed values; but hashing is special, because
9369 it's better to use unsigned division on hash table sizes so that
9370 the remainder is nonnegative. Also, size_t is the natural width
9371 for hashing into memory. The previous code used 'int', which doesn't
9372 retain enough info to hash well into very large tables.
9373 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9375 * dbusbind.c: Don't possibly lose pointer info when converting.
9376 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9377 Use XPNTR rather than XHASH, so that the high-order bits of
9378 the pointer aren't lost when converting through void *.
9380 * eval.c (Fautoload): Don't double-shift a pointer.
9382 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9384 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9386 * gnutls.c (DEF_GNUTLS_FN):
9387 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9389 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9391 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9394 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9396 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9397 New version that can reserve upto 2GB of heap space.
9399 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9401 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9403 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9405 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9406 `gnutls_certificate_set_x509_key_file'.
9408 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9410 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9411 Update dependencies.
9413 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9415 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9416 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9417 Remove unused parameter `fildes'.
9418 * process.c (read_process_output, send_process): Don't pass it.
9420 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9422 Fix previous change: the library cache is defined in w32.c.
9423 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9424 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9426 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9428 Implement dynamic loading of GnuTLS on Windows.
9430 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9431 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9432 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9435 * gnutls.c (Qgnutls_dll): Define.
9436 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9437 (gnutls_*): Declare function pointers.
9438 (init_gnutls_functions): New function to initialize function pointers.
9439 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9440 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9441 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9442 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9443 (emacs_gnutls_write, emacs_gnutls_read)
9444 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9445 (Fgnutls_available_p): New function.
9446 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9447 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9448 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9450 * image.c: Include w32.h.
9451 (Vimage_type_cache): Delete.
9452 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9453 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9454 (w32_delayed_load): Move to w32.c.
9456 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9458 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9459 (w32_delayed_load): Move from image.c. When loading a library, record
9460 its filename in the :loaded-from property of the library id.
9461 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9462 Initialize and staticpro them.
9463 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9465 * process.c: Include lisp.h before w32.h, not after.
9466 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9467 instead of gnutls_record_check_pending.
9469 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9471 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9473 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9474 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9477 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9479 * xterm.c (x_set_frame_alpha): Do not set property on anything
9480 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9482 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9484 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9486 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9488 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9489 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9490 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9491 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9492 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9493 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9494 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9495 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9496 (Qgnutls_bootprop_callbacks_verify): Make static.
9498 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9500 * callproc.c: Indentation fixup.
9502 * sysdep.c (wait_for_termination_1): Make static.
9503 (wait_for_termination, interruptible_wait_for_termination):
9504 Move after wait_for_termination_1.
9506 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9508 * sysdep.c (interruptible_wait_for_termination): New function
9509 which is like wait_for_termination, but allows keyboard
9512 * callproc.c (Fcall_process): Add (:file "file") as an option for
9514 (Fcall_process_region): Ditto.
9516 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9518 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9519 rather than `XVECTOR (FOO)->size'.
9521 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9522 inttypes.h, as a gnulib replacement is used if it not available in
9525 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9527 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9528 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9529 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9531 * coding.c (coding_alloc_by_realloc): Error out if destination
9532 will grow beyond MOST_POSITIVE_FIXNUM.
9533 (decode_coding_emacs_mule): Abort if there isn't enough place in
9534 charbuf for the composition carryover bytes. Reserve an extra
9535 space for up to 2 characters produced in a loop.
9536 (decode_coding_iso_2022): Abort if there isn't enough place in
9537 charbuf for the composition carryover bytes.
9539 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9541 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9542 aborting when %lld or %lll format is passed.
9543 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9544 %llo or %llx format is passed. (Bug#8545)
9546 * window.c (window_scroll_line_based): Use a marker instead of
9547 simple variables to record original value of point. (Bug#7952)
9549 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9550 produced by %s or %c overflows available buffer space. (Bug#8545)
9552 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9554 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9555 (SIZE_MAX): Move defn after all includes, as they might #define it.
9557 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9559 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9561 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9563 * keyboard.c (Qdelayed_warnings_hook): Define.
9564 (command_loop_1): Run `delayed-warnings-hook'
9565 if Vdelayed_warnings_list is non-nil.
9566 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9567 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9569 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9571 * doprnt.c (doprnt): Don't return value smaller than the buffer
9572 size if the message was truncated. (Bug#8545).
9574 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9576 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9577 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9579 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9581 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9583 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9585 * makefile.w32-in: Update dependencies.
9587 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9589 Improve `doprnt' and its usage. (Bug#8545)
9590 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9591 `format_end'. Remove support for %l as a conversion specifier.
9592 Don't use xrealloc. Improve diagnostics when the %l size modifier
9593 is used. Update the commentary.
9595 * eval.c (verror): Simplify calculation of size_t.
9597 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9600 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9602 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9605 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9607 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9608 This makes this file independent of the recent pseudovector change.
9610 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9612 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9614 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9615 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9616 Remove unused local.
9617 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9619 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9620 GCC 4.6.0 optimizes based on type-based alias analysis.
9621 For example, if b is of type struct buffer * and v of type struct
9622 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9623 != &v->size, and therefore "v->size = 1; b->size = 2; return
9624 v->size;" must therefore return 1. This assumption is incorrect
9625 for Emacs, since it type-puns struct Lisp_Vector * with many other
9626 types. To fix this problem, this patch adds a new type struct
9627 vectorlike_header that documents the constraints on layout of vectors
9628 and pseudovectors, and helps optimizing compilers not get fooled
9629 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9630 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9631 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9633 (XSETPVECTYPE): Rewrite in terms of new macro.
9634 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9635 This is a bit clearer, and further avoids the possibility of
9636 undesirable aliasing.
9637 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9638 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9639 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9640 since Lisp_Subr is a special case (no "next" field).
9641 (ASIZE): Now uses header.size rather than size.
9642 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9643 to avoid the hassle of writing XVECTOR (foo)->header.size.
9644 (struct vectorlike_header): New type.
9645 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9646 object, to help avoid aliasing.
9647 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9648 (SUBRP): Likewise, since Lisp_Subr is a special case.
9649 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9650 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9651 (struct Lisp_Hash_Table): Combine first two members into a single
9652 struct vectorlike_header member. All uses of "size" and "next" members
9653 changed to be "header.size" and "header.next".
9654 * buffer.h (struct buffer): Likewise.
9655 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9656 * frame.h (struct frame): Likewise.
9657 * process.h (struct Lisp_Process): Likewise.
9658 * termhooks.h (struct terminal): Likewise.
9659 * window.c (struct save_window_data, struct saved_window): Likewise.
9660 * window.h (struct window): Likewise.
9661 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9662 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9663 * buffer.c (init_buffer_once): Likewise.
9664 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9666 * process.c (Fformat_network_address): Use local var for size,
9669 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9671 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9672 * data.c (atof): Remove decl; no longer used or needed.
9673 (digit_to_number): Move to lread.c.
9674 (Fstring_to_number): Use new string_to_number function, to be
9675 consistent with how the Lisp reader treats infinities and NaNs.
9676 Do not assume that floating-point numbers represent EMACS_INT
9677 without losing information; this is not true on most 64-bit hosts.
9678 Avoid double-rounding errors, by insisting on integers when
9679 parsing non-base-10 numbers, as the documentation specifies.
9680 * lisp.h (string_to_number): New decl, replacing ...
9681 (isfloat_string): Remove.
9682 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9683 (read1): Do not accept +. and -. as integers; this
9684 appears to have been a coding error. Similarly, do not accept
9685 strings like +-1e0 as floating point numbers. Do not report
9686 overflow for integer overflows unless the base is not 10 which
9687 means we have no simple and reliable way to continue.
9688 Break out the floating-point parsing into a new
9689 function string_to_number, so that Fstring_to_number parses
9690 floating point numbers consistently with the Lisp reader.
9691 (digit_to_number): Move here from data.c. Make it static inline.
9692 (E_CHAR, EXP_INT): Remove, replacing with ...
9693 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9694 (string_to_number): New function, replacing isfloat_string.
9695 This function checks for valid syntax and produces the resulting
9696 Lisp float number too. Rework it so that string-to-number
9697 no longer mishandles examples like "1.0e+". Use strtoumax,
9698 so that overflow for non-base-10 numbers is reported only when
9699 there's no portable and simple way to convert to floating point.
9701 * textprop.c (set_text_properties_1): Rewrite for clarity,
9702 and to avoid GCC warning about integer overflow.
9704 * intervals.h (struct interval): Use EMACS_INT for members
9705 where EMACS_UINT might cause problems. See
9706 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9707 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9708 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9710 (offset_intervals): Tell GCC not to worry about length overflow
9711 when negating a negative length.
9713 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9714 (overrun_check_free): Likewise.
9716 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9717 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9720 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9721 (gnutls_make_error): Rename local to avoid shadowing.
9722 (gnutls_emacs_global_deinit): ifdef out; not used.
9723 (Fgnutls_boot): Use const for pointer to readonly storage.
9724 Comment out unused local. Fix pointer signedness problems.
9726 * lread.c (openp): Don't stuff size_t into an 'int'.
9727 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9728 about possible signed overflow.
9730 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9731 (GDK_KEY_g): Don't define if already defined.
9732 (xg_prepare_tooltip): Avoid pointer signedness problem.
9733 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9735 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9736 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9738 * xfns.c (Fx_window_property): Simplify a bit,
9739 to make a bit faster and to avoid GCC 4.6.0 warning.
9740 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9742 * fns.c (internal_equal): Don't assume size_t fits in int.
9744 * alloc.c (compact_small_strings): Tighten assertion a little.
9746 Replace pEd with more-general pI, and fix some printf arg casts.
9747 * lisp.h (pI): New macro, generalizing old pEd macro to other
9748 conversion specifiers. For example, use "...%"pI"d..." rather
9749 than "...%"pEd"...".
9750 (pEd): Remove. All uses replaced with similar uses of pI.
9751 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9752 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9753 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9754 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9755 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9756 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9757 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9759 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9760 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9761 * print.c (safe_debug_print, print_object): Likewise.
9762 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9764 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9765 avoiding the 0 flag, which is not portable.
9766 * process.c (Fmake_network_process): Use pI to avoid cast.
9767 * region-cache.c (pp_cache): Likewise.
9768 * xdisp.c (decode_mode_spec): Likewise.
9769 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9770 behavior on 64-bit hosts with printf arg.
9771 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9772 (x_stop_queuing_selection_requests): Likewise.
9773 (x_get_window_property): Don't truncate byte count to an 'int'
9776 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9777 here, since it parses constructs like leading '-' and spaces,
9778 which are not wanted; and it overflows with large numbers.
9779 Instead, simply match F[0-9]+, which is what is wanted anyway.
9781 * alloc.c: Remove unportable assumptions about struct layout.
9782 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9783 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9784 (allocate_vectorlike, make_pure_vector): Use the new macros,
9785 plus offsetof, to remove unportable assumptions about struct layout.
9786 These assumptions hold on all porting targets that I know of, but
9787 they are not guaranteed, they're easy to remove, and removing them
9788 makes further changes easier.
9790 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9791 This doesn't fix a bug but makes the code clearer.
9792 (string_overrun_cookie): Now const. Use initializers that
9793 don't formally overflow signed char, to avoid warnings.
9794 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9795 can cause Emacs to crash when string overrun checking is enabled.
9796 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9797 multiple of sizeof (EMACS_INT); it need not be, if
9798 alignof(EMACS_INT) < sizeof (EMACS_INT).
9799 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9801 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9803 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9805 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9807 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9808 supposed to be handshaking. (Bug#8556)
9809 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9811 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9813 * lisp.h (Qdebug): List symbol.
9814 * eval.c (Qdebug): Restore global linkage.
9815 * keyboard.c (debug-on-event): New variable.
9816 (handle_user_signal): Break into debugger when debug-on-event
9817 matches the current signal symbol.
9819 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9821 * alloc.c (check_sblock, check_string_bytes)
9822 (check_string_free_list): Convert to standard C.
9824 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9826 * w32.c (emacs_gnutls_push): Fix typo.
9828 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9830 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9831 "cast to pointer from integer of different size".
9833 Improve doprnt and its use in verror. (Bug#8545)
9834 * doprnt.c (doprnt): Document the set of format control sequences
9835 supported by the function. Use SAFE_ALLOCA instead of always
9838 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9839 is one byte too soon. Don't use xrealloc; instead xfree and
9842 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9844 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9847 * gnutls.c: Renamed global_initialized to
9848 gnutls_global_initialized. Added internals for the
9849 :verify-hostname-error, :verify-error, and :verify-flags
9850 parameters of `gnutls-boot' and documented those parameters in the
9851 docstring. Start callback support.
9852 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9853 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9854 on error. Return error code.
9855 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9856 (emacs_gnutls_read): Likewise.
9857 (Fgnutls_boot): Return handshake error code.
9858 (emacs_gnutls_handle_error): New function.
9859 (wsaerror_to_errno): Likewise.
9861 * w32.h (emacs_gnutls_pull): Add prototype.
9862 (emacs_gnutls_push): Likewise.
9864 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9865 (emacs_gnutls_push): Likewise.
9867 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9869 * process.c (wait_reading_process_output): Check if GnuTLS
9870 buffered some data internally if no FDs are set for TLS
9873 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9874 (LIBS): Link to USER_LIBS.
9875 ($(BLD)/gnutls.$(0)): New target.
9877 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9879 * xdisp.c (handle_single_display_spec): Rename the
9880 display_replaced_before_p argument into display_replaced_p, to
9881 make it consistent with the commentary. Fix typos in the
9884 * textprop.c (syms_of_textprop): Remove dead code.
9885 (copy_text_properties): Delete obsolete commentary about an
9886 interface that was deleted long ago. Fix typos in the description
9889 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9890 to changes in oldXMenu/XMenu.h from 2011-04-16.
9891 <menu_help_message, prev_menu_help_message>: Constify.
9892 (IT_menu_make_room): menu->help_text is now `const char **';
9895 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9896 to changes in oldXMenu/XMenu.h from 2011-04-16.
9897 (struct XMenu): Declare `help_text' `const char **'.
9899 * xfaces.c <Qunspecified>: Make extern again.
9901 * syntax.c: Include sys/types.h before including regex.h, as
9904 * doc.c (get_doc_string): Improve the format passed to `error'.
9906 * doprnt.c (doprnt): Improve commentary.
9908 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9910 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9913 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9914 changes in globals.h immediately force recompilation.
9915 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9916 $(CURDIR)/s/ms-w32.h.
9917 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9919 * character.c (Fchar_direction): Function deleted.
9920 (syms_of_character): Don't defsubr it.
9921 <char-direction-table>: Deleted.
9923 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9925 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9926 * doprnt.c: Include limits.h.
9927 (SIZE_MAX): New macro.
9928 (doprnt): Return a size_t value. 2nd arg is now size_t.
9929 Many local variables are now size_t instead of int or unsigned.
9930 Improve overflow protection. Support `l' modifier for integer
9931 conversions. Support %l conversion. Don't assume an EMACS_INT
9932 argument for integer conversions and for %c.
9934 * lisp.h (doprnt): Restore prototype.
9936 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9939 * Makefile.in (base_obj): Add back doprnt.o.
9941 * deps.mk (doprnt.o): Add back prerequisites.
9942 (callint.o): Depend on character.h.
9944 * eval.c (internal_lisp_condition_case): Include the handler
9945 representation in the error message.
9946 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9947 when breaking from the loop.
9949 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9951 * callint.c (Fcall_interactively): When displaying error message
9952 about invalid control letter, pass the character's codepoint, not
9953 a pointer to its multibyte form. Improve display of the character
9954 in octal and display also its hex code.
9956 * character.c (char_string): Use %x to display the (unsigned)
9957 codepoint of an invalid character, to avoid displaying a bogus
9960 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9961 `error', not SYMBOL_NAME itself.
9963 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9964 character arguments to `error'.
9966 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9967 to `error' in error message about FINAL_CHAR argument. Make sure
9968 FINAL_CHAR is a character, and use %c when it is passed as
9969 argument to `error'.
9971 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9973 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9975 * w32.c: Include <time.h>.
9976 (sys_localtime): New function.
9978 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9980 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9982 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9984 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9986 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9989 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9991 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9992 gl_state.e_property when gl_state.object is Qt.
9994 * insdel.c (make_gap_larger): Remove limitation of buffer size
9997 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9999 * xdisp.c (lookup_glyphless_char_display)
10000 (produce_glyphless_glyph): Handle cons cell entry in
10001 glyphless-char-display.
10002 (Vglyphless_char_display): Document it.
10004 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10005 glyphless-char-display.
10007 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10009 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10011 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10013 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10014 definition for no-X builds.
10016 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10018 Static checks with GCC 4.6.0 and non-default toolkits.
10020 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10022 * process.c (keyboard_bit_set): Define only if SIGIO.
10023 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10024 (send_process): Repair possible setjmp clobbering.
10026 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10028 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10030 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10032 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10033 Define only if needed.
10035 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10036 by pacifying GCC about it. Maybe it's time to retire it?
10037 * xfaces.c (USG, __TIMEVAL__): Likewise.
10039 * dispextern.h (struct redisplay_interface): Rename param
10040 to avoid shadowing.
10041 * termhooks.h (struct terminal): Likewise.
10042 * xterm.c (xembed_send_message): Likewise.
10044 * insdel.c (make_gap_smaller): Define only if
10045 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10047 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10050 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10051 so that we aren't warned about unused symbols.
10053 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10055 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10057 * xfns.c (x_real_positions): Mark locals as initialized.
10059 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10061 * xterm.c: Fix problems found by static analysis with other toolkits.
10062 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10063 (x_dispatch_event): Declare static if USE_GTK, and
10064 define if USE_GTK || USE_X_TOOLKIT.
10065 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10066 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10067 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10068 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10070 * xmenu.c (menu_help_callback): Pointer type fixes.
10071 Use const pointers when pointing at readonly data. Avoid pointer
10072 signedness clashes.
10073 (FALSE): Remove unused macro.
10074 (update_frame_menubar): Remove unused decl.
10076 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10078 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10079 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10080 (single_menu_item): Rename local to avoid shadowing.
10082 * keyboard.c (make_lispy_event): Remove unused local var.
10084 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10085 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10087 * bitmaps: Change bitmaps from unsigned char back to the X11
10088 compatible char. Avoid the old compiler warnings about
10089 out-of-range initializers by using, for example, '\xab' rather
10092 * xgselect.c (xgselect_initialize): Check vs interface
10093 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10095 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10097 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10098 to read-only memory.
10100 * fns.c (vector): Remove; this old hack is no longer needed.
10102 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10104 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10106 * xrdb.c (x_load_resources): Omit unused local.
10108 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10109 (x_window): Rename locals to avoid shadowing.
10110 (USG): Use the kludged USG macro, to pacify gcc.
10112 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10113 (x_term_init): Remove local to avoid shadowing.
10115 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10117 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10118 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10120 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10122 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10124 Fix regex.c, syntax.c and friends for buffers > 2GB.
10125 * syntax.h (struct gl_state_s): Declare character position members
10128 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10130 * textprop.c (verify_interval_modification, interval_of):
10131 Declare arguments EMACS_INT.
10133 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10136 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10138 * indent.c (Fvertical_motion): Local variable it_start is now
10141 * regex.c (re_match, re_match_2, re_match_2_internal)
10142 (bcmp_translate, regcomp, regexec, print_double_string)
10143 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10144 (re_compile_pattern, re_exec): Declare arguments and local
10145 variables `size_t' and `ssize_t' and return values `regoff_t', as
10147 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10148 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10149 <compile_stack_type>: `size' and `avail' are now `size_t'.
10151 * regex.h <regoff_t>: Use ssize_t, not int.
10152 (re_search, re_search_2, re_match, re_match_2): Arguments that
10153 specify buffer/string position and length are now ssize_t and
10154 size_t. Return type is regoff_t.
10156 2011-04-16 Ben Key <bkey76@gmail.com>
10158 * nsfont.m: Fixed bugs in ns_get_family and
10159 ns_descriptor_to_entity that were caused by using free to
10160 deallocate memory blocks that were allocated by xmalloc (via
10161 xstrdup). This caused Emacs to crash when compiled with
10162 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10163 --enable-checking=xmallocoverrun). xfree is now used to
10164 deallocate these memory blocks.
10166 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10168 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10170 emacs_write: Accept and return EMACS_INT for sizes.
10171 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10173 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10174 Accept and return EMACS_INT.
10175 (emacs_gnutls_write): Return the number of bytes written on
10177 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10178 (emacs_read, emacs_write): Remove check for negative size, as the
10179 Emacs source code has been audited now.
10180 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10181 (emacs_read, emacs_write): Use it.
10182 * process.c (send_process): Adjust to the new signatures of
10183 emacs_write and emacs_gnutls_write. Do not attempt to store
10184 a byte offset into an 'int'; it might overflow.
10185 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10187 * sound.c: Don't assume sizes fit in 'int'.
10188 (struct sound_device.period_size, alsa_period_size):
10189 Return EMACS_INT, not int.
10190 (struct sound_device.write, vox_write, alsa_write):
10191 Accept EMACS_INT, not int.
10192 (wav_play, au_play): Use EMACS_INT to store sizes and to
10193 record read return values.
10195 2011-04-15 Ben Key <bkey76@gmail.com>
10197 * keyboard.c (Qundefined): Don't declare static since it is used
10199 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10200 static since they are used in nsfont.m.
10202 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10204 * process.c (Qprocessp): Don't declare static.
10205 * lisp.h (Qprocessp): Declare again.
10207 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10209 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10211 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10213 Improve C-level modularity by making more things 'static'.
10215 Don't publish debugger-only interfaces to other modules.
10216 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10217 (verify_bytepos, count_markers): Move decls to the only modules
10219 * region-cache.h (pp_cache): Likewise.
10220 * window.h (check_all_windows): Likewise.
10221 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10223 * sysdep.c (croak): Now static, if
10224 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10225 * syssignal.h (croak): Declare only if not static.
10227 * alloc.c (refill_memory_reserve): Now static if
10228 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10229 * lisp.h (refill_memory_reserve): Declare only if not static.
10231 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10232 Define only if USE_LUCID.
10234 * xrdb.c (x_customization_string, x_rm_string): Now static.
10236 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10237 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10239 * xdisp.c (draw_row_with_mouse_face): Now static.
10240 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10242 * window.h (check_all_windows): Mark externally visible.
10244 * window.c (window_deletion_count): Now static.
10246 * undo.c: Make symbols static if they're not exported.
10247 (last_undo_buffer, last_boundary_position, pending_boundary):
10250 * textprop.c (interval_insert_behind_hooks): Now static.
10251 (interval_insert_in_front_hooks): Likewise.
10253 * term.c: Make symbols static if they're not exported.
10254 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10255 (max_frame_lines, tty_set_terminal_modes):
10256 (tty_reset_terminal_modes, tty_turn_off_highlight):
10257 (get_tty_terminal): Now static.
10258 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10259 * termhooks.h (term_mouse_moveto): Do not declare if
10260 HAVE_WINDOW_SYSTEM.
10261 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10262 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10264 * sysdep.c: Make symbols static if they're not exported.
10265 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10267 (sigprocmask_set, full_mask): Remove; unused.
10268 (wait_debugging): Mark as visible.
10269 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10270 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10272 * syntax.c (syntax_temp): Define only if !__GNUC__.
10274 * sound.c (current_sound_device, current_sound): Now static.
10276 * search.c (searchbufs, searchbuf_head): Now static.
10278 * scroll.c (scroll_cost): Remove; unused.
10279 * dispextern.h (scroll_cost): Remove decl.
10281 * region-cache.h (pp_cache): Mark as externally visible.
10283 * process.c: Make symbols static if they're not exported.
10284 (process_tick, update_tick, create_process, chan_process):
10285 (Vprocess_alist, proc_buffered_char, datagram_access):
10286 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10287 (deactivate_process): Mark defn as static, as well as decl.
10288 * lisp.h (create_process): Remove decl.
10289 * process.h (chan_process, Vprocess_alist): Remove decls.
10291 * print.c: Make symbols static if they're not exported.
10292 (print_depth, new_backquote_output, being_printed, print_buffer):
10293 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10294 (print_interval, print_number_index, initial_stderr_stream):
10296 * lisp.h (Fprinc): Remove decl.
10297 (debug_output_compilation_hack): Mark as externally visible.
10299 * sysdep.c (croak): Move decl from here to syssignal.h.
10300 * syssignal.h (croak): Put it here, so the API can be checked when
10301 'croak' is called from dissociate_if_controlling_tty.
10303 * minibuf.c: Make symbols static if they're not exported.
10304 (minibuf_save_list, choose_minibuf_frame): Now static.
10305 * lisp.h (choose_minibuf_frame): Remove decl.
10307 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10309 * lread.c: Make symbols static if they're not exported.
10310 (read_objects, initial_obarray, oblookup_last_bucket_number):
10312 (make_symbol): Remove; unused.
10313 * lisp.h (initial_obarray, make_symbol): Remove decls.
10315 * keyboard.c: Make symbols static if they're not exported.
10316 (single_kboard, recent_keys_index, total_keys, recent_keys):
10317 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10318 (this_single_command_key_start, echoing, last_auto_save):
10319 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10320 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10321 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10322 (Vlispy_mouse_stem, double_click_count):
10324 (force_auto_save_soon): Define only if SIGDANGER.
10325 (ignore_mouse_drag_p): Now static if
10326 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10327 (print_help): Remove; unused.
10328 (stop_character, last_timer_event): Mark as externally visible.
10329 * keyboard.h (ignore_mouse_drag_p): Declare only if
10330 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10331 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10332 * lisp.h (echoing): Remove decl.
10333 (force_auto_save_soon): Declare only if SIGDANGER.
10334 * xdisp.c (redisplay_window): Simplify code, to make it more
10335 obvious that ignore_mouse_drag_p is not accessed if !defined
10336 USE_GTK && !defined HAVE_NS.
10338 * intervals.c: Make symbols static if they're not exported.
10339 (merge_properties_sticky, merge_interval_right, delete_interval):
10341 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10343 * insdel.c: Make symbols static if they're not exported.
10344 However, leave prepare_to_modify_buffer alone. It's never
10345 called from outside this function, but that appears to be a bug.
10346 (combine_after_change_list, combine_after_change_buffer):
10347 (adjust_after_replace, signal_before_change): Now static.
10348 (adjust_after_replace_noundo): Remove; unused.
10349 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10350 (signal_before_change): Remove decls.
10352 * indent.c (val_compute_motion, val_vmotion): Now static.
10354 * image.c: Make symbols static if they're not exported.
10355 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10357 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10358 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10360 * fringe.c (standard_bitmaps): Now static.
10361 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10363 * frame.c: Make symbols static if they're not exported.
10364 (x_report_frame_params, make_terminal_frame): Now static.
10365 (get_frame_param): Now static, unless HAVE_NS.
10366 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10367 (x_get_resource_string): Remove; not used.
10368 * frame.h (make_terminal_frame, x_report_frame_params):
10369 (x_get_resource_string); Remove decls.
10370 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10371 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10373 * font.c, fontset.c: Make symbols static if they're not exported.
10374 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10375 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10376 * font.c (font_close_object): Now static.
10377 * font.h (font_close_object): Remove.
10378 * fontset.c (FONTSET_OBJLIST): Remove.
10379 (free_realized_fontset) #if-0 the body, which does nothing.
10380 (face_suitable_for_char_p): #if-0, as it's never called.
10381 * fontset.h (face_suitable_for_char_p): Remove decl.
10382 * xfaces.c (face_at_string_position):
10383 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10384 since 0 is always ASCII.
10386 * fns.c (weak_hash_tables): Now static.
10388 * fileio.c: Make symbols static if they're not exported.
10389 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10390 (Vwrite_region_annotation_buffers): Now static.
10392 * eval.c: Make symbols static if they're not exported.
10393 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10394 * lisp.h (backtrace_list): Remove decl.
10396 * emacs.c: Make symbols static if they're not exported.
10397 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10398 (fatal_error_code, fatal_error_signal_hook, standard_args):
10400 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10401 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10402 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10403 * lisp.h (fatal_error_signal_hook): Remove decl.
10404 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10406 * editfns.c: Move a (normally-unused) function to its only use.
10407 * editfns.c, lisp.h (get_operating_system_release): Remove.
10408 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10409 worth the hassle of breaking this out.
10411 * xterm.c: Make symbols static if they're not exported.
10412 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10413 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10414 (x_destroy_window, x_delete_display):
10416 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10417 (x_mouse_leave): Remove; unused.
10418 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10419 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10420 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10422 (x_mouse_leave): Declare only if WINDOWSNT.
10423 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10424 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10427 * ftxfont.c: Make symbols static if they're not exported.
10428 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10430 * font.h (ftxfont_driver): Likewise.
10432 * xfns.c: Make symbols static if they're not exported.
10433 (x_last_font_name, x_display_info_for_name):
10434 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10435 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10436 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10437 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10438 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10439 (last_show_tip_args): Now static.
10440 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10441 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10442 (x_screen_planes): Remove; unused.
10443 * dispextern.h (x_screen_planes): Remove decl.
10445 * dispnew.c: Make symbols static if they're not exported.
10446 * dispextern.h (redraw_garbaged_frames, scrolling):
10447 (increment_row_positions): Remove.
10448 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10449 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10451 (redraw_garbaged_frames): Remove; unused.
10453 * xfaces.c: Make symbols static if they're not exported.
10454 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10456 * xterm.h (defined_color): Remove decls.
10457 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10458 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10459 (menu_face_changed_default, defined_color, free_realized_face):
10460 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10461 (ascii_face_of_lisp_face): Remove; unused.
10463 * xdisp.c: Make symbols static if they're not exported.
10464 * dispextern.h (scratch_glyph_row, window_box_edges):
10465 (glyph_to_pixel_coords, set_cursor_from_row):
10466 (get_next_display_element, set_iterator_to_next):
10467 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10468 (show_mouse_face): Remove decls
10469 * frame.h (message_buf_print): Likewise.
10470 * lisp.h (pop_message, set_message, check_point_in_composition):
10472 * xterm.h (set_vertical_scroll_bar): Likewise.
10473 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10474 (message_buf_print, scratch_glyph_row, displayed_buffer):
10475 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10476 (get_next_display_element, show_mouse_face, window_box_edges):
10477 (frame_to_window_pixel_xy, check_point_in_composition):
10478 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10479 (glyph_to_pixel_coords): Remove; unused.
10481 * dired.c (file_name_completion): Now static.
10483 * dbusbind.c (xd_in_read_queued_messages): Now static.
10485 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10486 * data.c (circular_list_error): Remove.
10488 * commands.h (last_point_position, last_point_position_buffer):
10489 (last_point_position_window): Remove decls.
10490 * keyboard.c: Make these variables static.
10492 * coding.h (coding, code_convert_region, encode_coding_gap):
10494 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10495 (iso_code_class, detect_coding, code_convert_region): Now static.
10496 (encode_coding_gap): Remove; unused.
10498 * chartab.c (chartab_chars, chartab_bits): Now static.
10500 * charset.h (charset_iso_8859_1): Remove decl.
10501 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10504 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10505 * ccl.c (Vccl_program_table): Now static.
10506 (check_ccl_update): Remove; unused.
10508 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10509 * category.h: ... from here.
10510 * category.c (check_category_table, set_category_set): Now static.
10512 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10513 * lisp.h: Remove these decls.
10515 * buffer.c (buffer_count): Remove unused var.
10517 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10518 so that it's not optimized away.
10519 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10520 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10521 exported only to the debugger.
10523 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10524 * atimer.h (run_all_atimers): Remove; not exported.
10526 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10527 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10528 was inaccessible from Lisp.
10529 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10530 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10532 alloc.c: Import and export fewer symbols, and remove unused items.
10533 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10535 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10536 it's not optimized away by whole-program optimization.
10537 (message_enable_multibyte, free_misc): Remove.
10538 (catchlist, handlerlist, mark_backtrace):
10539 Declare only if BYTE_MARK_STACK.
10540 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10541 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10542 (message_enable_multibyte): Remove decl.
10543 (free_misc, interval_free_list, float_block, float_block_index):
10544 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10545 (cons_free_list, last_marked_index):
10547 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10548 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10549 (mark_backtrace): Define only if BYTE_MARK_STACK.
10550 * xdisp.c (message_enable_multibyte): Now static.
10552 Declare Lisp_Object Q* variables to be 'static' if not exported.
10553 This makes it easier for human readers (and static analyzers)
10554 to see whether these variables are used from other modules.
10555 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10556 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10557 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10558 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10559 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10560 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10561 * xmenu.c, xselect.c:
10562 Declare Q* vars static if they are not used in other modules.
10563 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10564 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10565 Remove decls of unexported vars.
10566 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10568 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10570 Make Emacs functions such as Fatom 'static' by default.
10571 This makes it easier for human readers (and static analyzers)
10572 to see whether these functions can be called from other modules.
10573 DEFUN now defines a static function. To make the function external
10574 so that it can be used in other C modules, use the new macro DEFUE.
10575 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10576 (Finit_image_library):
10577 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10578 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10579 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10580 Remove decls, since these functions are now static.
10581 (Funintern, Fget_internal_run_time): New decls, since these functions
10582 were already external.
10584 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10585 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10586 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10587 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10588 * keyboard.c, keymap.c, lread.c:
10589 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10590 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10591 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10592 Mark functions with DEFUE instead of DEFUN,
10593 if they are used in other modules.
10594 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10595 decls for now-static functions.
10596 * buffer.h (Fdelete_overlay): Remove decl.
10597 * callproc.c (Fgetenv_internal): Mark as internal.
10598 * composite.c (Fremove_list_of_text_properties): Remove decl.
10599 (Fcomposition_get_gstring): New forward static decl.
10600 * composite.h (Fcomposite_get_gstring): Remove decl.
10601 * dired.c (Ffile_attributes): New forward static decl.
10602 * doc.c (Fdocumntation_property): New forward static decl.
10603 * eval.c (Ffetch_bytecode): New forward static decl.
10604 (Funintern): Remove extern decl; now in .h file where it belongs.
10605 * fileio.c (Fmake_symbolic_link): New forward static decl.
10606 * image.c (Finit_image_library): New forward static decl.
10607 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10608 * intervals.h (Fprevious_property_change):
10609 (Fremove_list_of_text_properties): Remove decls.
10610 * keyboard.c (Fthis_command_keys): Remove decl.
10611 (Fcommand_execute): New forward static decl.
10612 * keymap.c (Flookup_key): New forward static decl.
10613 (Fcopy_keymap): Now static.
10614 * keymap.h (Flookup_key): Remove decl.
10615 * process.c (Fget_process): New forward static decl.
10616 (Fprocess_datagram_address): Mark as internal.
10617 * syntax.c (Fsyntax_table_p): New forward static decl.
10618 (skip_chars): Remove duplicate decl.
10619 * textprop.c (Fprevious_property_change): New forward static decl.
10620 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10622 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10623 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10625 * editfns.c (Fformat): Remove unreachable code.
10627 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10629 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10632 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10634 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10635 when at ZV. (Bug#8487)
10637 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10639 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10641 * keyboard.c (parse_tool_bar_item): Likewise.
10642 * sound.c (sound_cleanup, alsa_close): Likewise.
10643 * termcap.c (tgetent): Likewise.
10644 * xfns.c (x_default_font_parameter): Likewise.
10645 * xsettings.c (read_and_apply_settings): Likewise.
10647 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10648 (overrun_check_free): Protoize.
10650 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10652 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10653 since callers should never pass a negative size.
10654 Change the signature to match that of plain 'read' and 'write'; see
10655 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10656 * lisp.h: Update prototypes of emacs_write and emacs_read.
10658 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10660 * xdisp.c (redisplay_window): Don't try to determine the character
10661 position of the scroll margin if the window start point w->startp
10662 is outside the buffer's accessible region. (Bug#8468)
10664 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10666 Fix write-region and its subroutines for buffers > 2GB.
10667 * fileio.c (a_write, e_write): Modify declaration of arguments and
10668 local variables to support buffers larger than 2GB.
10669 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10671 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10672 argument, local variables, and return value.
10674 * lisp.h: Update prototypes of emacs_write and emacs_read.
10676 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10678 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10680 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10682 Fix more problems found by GCC 4.6.0's static checks.
10684 * xdisp.c (vmessage): Use a better test for character truncation.
10686 * charset.c (load_charset_map): <, not <=, for optimization,
10687 and to avoid potential problems with integer overflow.
10688 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10689 * casetab.c (set_identity, shuffle): Likewise.
10690 * editfns.c (Fformat): Likewise.
10691 * syntax.c (skip_chars): Likewise.
10693 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10694 This also lets GCC 4.6.0 generate slightly better loop code.
10696 * callint.c (Fcall_interactively): <, not <=, for optimization.
10697 (Fcall_interactively): Count the number of arguments produced,
10698 not the number of arguments given. This is simpler and lets GCC
10699 4.6.0 generate slightly better code.
10701 * ftfont.c: Distingish more carefully between FcChar8 and char.
10702 The previous code passed unsigned char * to a functions like
10703 strlen and xstrcasecmp that expect char *, which does not
10704 conform to the C standard.
10705 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10706 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10707 char * when the C standard requires it.
10709 * keyboard.c (read_char): Remove unused var.
10711 * eval.c: Port to Windows vsnprintf (Bug#8435).
10712 Include <limits.h>.
10713 (SIZE_MAX): Define if the headers do not.
10714 (verror): Do not give up if vsnprintf returns a negative count.
10715 Instead, grow the buffer. This ports to Windows vsnprintf, which
10716 does not conform to C99. Problem reported by Eli Zaretskii.
10717 Also, simplify the allocation scheme, by avoiding the need for
10718 calling realloc, and removing the ALLOCATED variable.
10720 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10722 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10723 But keep the doprint source code for now, as we might revamp it
10724 and use it again (Bug#8435).
10725 * lisp.h (doprnt): Remove.
10726 * Makefile.in (base_obj): Remove doprnt.o.
10727 * deps.mk (doprnt.o): Remove.
10729 error: Print 32- and 64-bit integers portably (Bug#8435).
10730 Without this change, on typical 64-bit hosts error ("...%d...", N)
10731 was used to print both 32- and 64-bit integers N, which relied on
10732 undefined behavior.
10733 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10734 * lisp.h (error, verror): Mark as printf-like functions.
10735 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10736 Report overflow in size calculations when allocating printf buffer.
10737 Do not truncate output string at its first null byte.
10738 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10739 Truncate the output at a character boundary, since vsnprintf does not
10741 * charset.c (check_iso_charset_parameter): Convert internal
10742 character to string before calling 'error', since %c now has the
10744 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10745 overflow when computing char to be passed to 'error'. Do not
10746 pass Lisp_Object to 'error'; pass the integer instead.
10747 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10748 formatted with plain %d.
10750 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10752 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10754 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10756 * xterm.c (x_catch_errors): Remove duplicate declaration.
10758 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10760 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10762 2011-04-10 Jim Meyering <meyering@redhat.com>
10764 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10765 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10766 return ssize_t not "int", and use size_t as the buffer length.
10767 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10768 * gnutls.h: Update declarations.
10769 * process.c (read_process_output): Use ssize_t, to match.
10770 (send_process): Likewise.
10772 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10774 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10776 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10778 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10779 Use unsigned char, to match FcChar8 type definition.
10781 * xterm.c (handle_one_xevent):
10782 * xmenu.c (create_and_show_popup_menu):
10783 * xselect.c (x_decline_selection_request)
10784 (x_reply_selection_request): Avoid type-punned deref of X events.
10786 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10788 Fix some uses of `int' instead of EMACS_INT.
10789 * search.c (string_match_1, fast_string_match)
10790 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10791 (scan_buffer, find_next_newline_no_quit)
10792 (find_before_next_newline, search_command, Freplace_match)
10793 (Fmatch_data): Make some `int' variables be EMACS_INT.
10795 * xdisp.c (display_count_lines): 3rd argument and return value now
10796 EMACS_INT. All callers changed.
10797 (pint2hrstr): Last argument is now EMACS_INT.
10799 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10800 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10801 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10802 (decode_coding_utf_16, decode_coding_emacs_mule)
10803 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10804 (decode_coding_ccl, decode_coding_charset)
10805 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10806 (decode_coding_iso_2022, decode_coding_emacs_mule)
10807 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10808 <char_offset, last_offset>: Declare EMACS_INT.
10809 (encode_coding_utf_8, encode_coding_utf_16)
10810 (encode_coding_emacs_mule, encode_invocation_designation)
10811 (encode_designation_at_bol, encode_coding_iso_2022)
10812 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10813 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10815 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10816 (encode_invocation_designation): Last argument P_NCHARS is now
10818 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10819 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10821 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10824 * ccl.c (Fccl_execute_on_string): Declare some variables
10827 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10829 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10831 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10833 * process.c (Fformat_network_address): Doc fix.
10835 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10837 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10839 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10841 * keyboard.c (read_char): Call Lisp function help-form-show,
10842 instead of using internal_with_output_to_temp_buffer.
10843 (Qhelp_form_show): New var.
10844 (syms_of_keyboard): Use DEFSYM macro.
10846 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10848 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10850 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10852 * process.c (Flist_processes): Remove to Lisp.
10853 (list_processes_1): Delete.
10855 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10857 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10859 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10861 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10863 Fix more problems found by GCC 4.6.0's static checks.
10865 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10867 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10869 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10871 * xdisp.c (vmessage): Mark as a printf-like function.
10873 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10875 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10877 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10878 printf-like functions.
10879 (tiff_load): Add casts to remove these marks before passing them
10880 to system-supplied API.
10882 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10884 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10885 This avoids several warnings with gcc -Wstrict-overflow.
10886 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10887 directly, rather than having caller test rule sign. This avoids
10888 some unnecessary tests.
10889 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10890 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10891 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10893 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10894 (xfont_open): Avoid unnecessary tests.
10896 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10898 * composite.h, composite.c (composition_gstring_put_cache):
10899 Use EMACS_INT, not int, for length.
10901 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10902 breaking out part of COMPOSITION_DECODE_RULE.
10903 (COMPOSITION_DECODE_RULE): Use it.
10904 * composite.c (get_composition_id): Remove unused local vars,
10905 by using the new macro.
10907 * textprop.c (set_text_properties_1): Change while to do-while,
10908 since the condition is always true at first.
10910 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10911 (interval_deletion_adjustment): Return unsigned value.
10914 * process.c (list_processes_1, create_pty, read_process_output):
10915 (exec_sentinel): Remove vars that were set but not used.
10916 (create_pty): Remove unnecessary "volatile"s.
10917 (Fnetwork_interface_info): Avoid possibility of int overflow.
10918 (read_process_output): Do adaptive read buffering even if carryover.
10919 (read_process_output): Simplify nbytes computation if buffered.
10921 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10923 * syntax.c (scan_words): Remove var that was set but not used.
10924 (update_syntax_table): Use unsigned instead of int.
10926 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10927 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10928 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10930 * print.c (print_error_message): Avoid int overflow.
10932 * font.c (font_list_entities): Redo for clarity,
10933 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10935 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10936 (font_score): Avoid potential overflow in diff calculation.
10938 * fns.c (substring_both): Remove var that is set but not used.
10939 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10941 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10943 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10944 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10945 can always succeed if overflow has undefined behavior.
10947 * search.c (boyer_moore, wordify): Remove vars set but not used.
10948 (wordify): Omit three unnecessary tests.
10950 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10951 All callers changed. This avoids the need for an unused var.
10953 * casefiddle.c (casify_region): Remove var that is set but not used.
10955 * dired.c (file_name_completion): Remove var that is set but not used.
10957 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10959 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10960 (Finsert_file_contents): Remove unnecessary code checking fd.
10962 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10963 Check for integer overflow on size calculations.
10965 * buffer.c (Fprevious_overlay_change): Remove var that is set
10968 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10969 Remove vars that are set but not used.
10970 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10971 (timer_check_2): Mark vars as initialized.
10973 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10975 * image.c (lookup_image): Remove var that is set but not used.
10976 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10978 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10979 that are set but not used.
10981 * xfns.c (make_invisible_cursor): Don't return garbage
10982 if XCreateBitmapFromData fails (Bug#8410).
10984 * xselect.c (x_get_local_selection, x_handle_property_notify):
10985 Remove vars that are set but not used.
10987 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10988 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10990 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10991 Remove var that is set but not used.
10992 (scroll_bar_windows_size): Now size_t, not int.
10993 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10994 Check for overflow.
10996 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10997 (map_tty_color) [!defined MSDOS]: Likewise.
10999 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11001 * coding.c: Remove vars that are set but not used.
11002 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11003 All callers changed.
11004 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11005 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11006 (decode_coding_charset): Remove vars that are set but not used.
11008 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11009 that is set but not used.
11011 * print.c (print_object): Remove var that is set but not used.
11013 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11014 The gnulib version avoids calling malloc in the usual case,
11015 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11016 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11017 * filelock.c (current_lock_owner): Likewise.
11018 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11019 * sysdep.c: Include allocator.h, careadlinkat.h.
11020 (emacs_no_realloc_allocator): New static constant.
11021 (emacs_readlink): New function.
11022 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11023 ../lib/careadlinkat.h.
11025 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11027 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11028 first non-nil return value).
11030 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11032 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11033 if not defined (Bug#8403).
11035 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11037 * xdisp.c (display_count_lines): Remove parameter `start',
11038 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11039 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11040 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11041 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11042 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11043 and thereabouts. All callers changed.
11044 (get_per_char_metric): Remove parameter `f', unused since
11045 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11047 2011-04-02 Jim Meyering <meyering@redhat.com>
11049 do not dereference NULL upon failed strdup
11050 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11051 (ns_get_family): Likewise.
11053 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11055 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11057 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11059 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11062 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11064 Add lexical binding.
11066 * window.c (Ftemp_output_buffer_show): New fun.
11067 (Fsave_window_excursion):
11068 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11070 * lread.c (lisp_file_lexically_bound_p): New function.
11071 (Fload): Bind Qlexical_binding.
11072 (readevalloop): Remove `evalfun' arg.
11073 Bind Qinternal_interpreter_environment.
11074 (Feval_buffer): Bind Qlexical_binding.
11075 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11077 (syms_of_lread): Declare `lexical-binding'.
11079 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11081 * keyboard.c (eval_dyn): New fun.
11082 (menu_item_eval_property): Use it.
11084 * image.c (parse_image_spec): Use Ffunctionp.
11086 * fns.c (concat, mapcar1): Accept byte-code-functions.
11088 * eval.c (Fsetq): Handle lexical vars.
11089 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11090 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11091 (FletX, Flet): Obey lexical binding.
11092 (Fcommandp): Handle closures.
11093 (Feval): New `lexical' arg.
11094 (eval_sub): New function extracted from Feval. Use it almost
11095 everywhere where Feval was used. Look up vars in lexical env.
11097 (Ffunctionp): Move from subr.el.
11098 (Ffuncall): Handle closures.
11099 (apply_lambda): Remove `eval_flags'.
11100 (funcall_lambda): Handle closures and new byte-code-functions.
11101 (Fspecial_variable_p): New function.
11102 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11103 but without exporting it to Lisp.
11105 * doc.c (Fdocumentation, store_function_docstring):
11106 * data.c (Finteractive_form): Handle closures.
11108 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11111 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11113 (exec_byte_code): New function extracted from Fbyte_code to handle new
11114 calling convention for byte-code-functions. Add new byte-codes.
11116 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11118 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11120 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11122 * xdisp.c (redisplay_internal): Fix prototype.
11124 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11126 * xdisp.c (SCROLL_LIMIT): New macro.
11127 (try_scrolling): Use it when setting scroll_limit.
11128 Limit scrolling to 100 screen lines.
11129 (redisplay_window): Even when falling back on "recentering",
11130 position point in the window according to scroll-conservatively,
11131 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11133 (try_scrolling): When point is above the window, allow searching
11134 as far as scroll_max, or one screenful, to compute vertical
11135 distance from PT to the scroll margin position. This prevents
11136 try_scrolling from unnecessarily failing when
11137 scroll-conservatively is set to a value slightly larger than the
11138 window height. Clean up the case of PT below the margin at bottom
11139 of window: scroll_max can no longer be INT_MAX. When aggressive
11140 scrolling is in use, don't let point enter the opposite scroll
11141 margin as result of the scroll.
11142 (syms_of_xdisp) <scroll-conservatively>: Document the
11143 threshold of 100 lines for never-recentering scrolling.
11145 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11147 * dispextern.h (move_it_by_lines):
11148 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11149 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11150 (message_log_check_duplicate): Remove parameters `prev_bol' and
11151 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11152 (redisplay_internal): Remove parameter `preserve_echo_area',
11153 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11155 * indent.c (Fvertical_motion):
11156 * window.c (window_scroll_pixel_based, Frecenter):
11157 Don't pass `need_y_p' to `move_it_by_lines'.
11159 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11161 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11162 steal a few bits to be more compact.
11163 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11164 Remove unneeded casts.
11166 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11168 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11170 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11171 binding" message (bug#7967).
11173 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11175 Fix more problems found by GCC 4.6.0's static checks.
11177 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11178 Remove unused local var.
11180 * editfns.c (Fmessage_box): Remove unused local var.
11182 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11183 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11184 Omit unused local vars.
11185 * window.c (shrink_windows): Omit unused local var.
11186 * menu.c (digest_single_submenu): Omit unused local var.
11187 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11188 Omit unused local var.
11190 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11191 Don't assume string length fits in int.
11192 (keyremap_step, read_key_sequence): Use size_t for sizes.
11193 (read_key_sequence): Don't check last_real_key_start redundantly.
11195 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11196 instead of alloca (Bug#8344).
11198 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11199 (Fbacktrace_frame): Don't assume nframes fits in int.
11201 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11203 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11206 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11208 * cm.c (calccost): Turn while-do into do-while, for clarity.
11210 * keyboard.c (syms_of_keyboard): Use the same style as later
11211 in this function when indexing through an array. This also
11212 works around GCC bug 48267.
11214 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11216 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11218 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11219 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11221 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11222 This avoids undefined behavior on integer overflow, and is a bit
11223 more convenient anyway since it is compared to a size_t variable.
11225 Variadic C functions now count arguments with size_t, not int.
11226 This avoids an unnecessary limitation on 64-bit machines, which
11227 caused (substring ...) to crash on large vectors (Bug#8344).
11228 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11229 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11230 All variadic functions and their callers changed accordingly.
11231 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11232 * data.c (arith_driver, float_arith_driver): Likewise.
11233 * editfns.c (general_insert_function): Likewise.
11234 * eval.c (struct backtrace.nargs, interactive_p)
11235 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11236 (funcall_lambda, mark_backtrace): Likewise.
11237 * fns.c (concat): Likewise.
11238 * frame.c (x_set_frame_parameters): Likewise.
11239 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11240 0 if not found, not -1. All callers changed.
11242 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11243 (stack_copy_size): Now size_t, not int.
11244 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11246 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11248 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11249 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11250 All callers changed.
11252 * lisp.h (multibyte_char_to_unibyte):
11253 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11254 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11255 * character.h (CHAR_TO_BYTE8):
11256 * cmds.c (internal_self_insert):
11257 * editfns.c (general_insert_function):
11258 * keymap.c (push_key_description):
11259 * search.c (Freplace_match):
11260 * xdisp.c (message_dolog, set_message_1): All callers changed.
11262 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11264 * keyboard.c (safe_run_hook_funcall): New function.
11265 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11266 don't set the hook to nil, but remove the offending function instead.
11267 (Qcommand_hook_internal): Remove, unused.
11268 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11269 Vcommand_hook_internal.
11271 * eval.c (enum run_hooks_condition): Remove.
11272 (funcall_nil, funcall_not): New functions.
11273 (run_hook_with_args): Call each function through a `funcall' argument.
11274 Remove `cond' argument, now redundant.
11275 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11276 (Frun_hook_with_args_until_failure): Adjust accordingly.
11277 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11279 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11281 * dispextern.h (string_buffer_position): Remove declaration.
11283 * print.c (strout): Remove parameter `multibyte', unused since
11284 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11286 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11287 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11288 All callers changed.
11290 * w32.c (_wsa_errlist): Use braces for struct initializers.
11292 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11293 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11294 All callers changed.
11295 (string_buffer_position): Likewise. Also, make static (it's never
11296 used outside xdisp.c).
11297 (cursor_row_p): Remove parameter `w', unused since
11298 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11299 (decode_mode_spec): Remove parameter `precision', introduced during
11300 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11301 All callers changed.
11303 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11305 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11307 2011-03-27 Anders Lindgren <andlind@gmail.com>
11309 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11310 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11311 (ns_update_auto_hide_menu_bar): New functions.
11312 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11313 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11314 ns_constrain_all_frames.
11315 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11316 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11318 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11320 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11322 2011-03-27 Glenn Morris <rgm@gnu.org>
11324 * syssignal.h: Replace RETSIGTYPE with void.
11325 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11326 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11327 Replace SIGTYPE with void everywhere.
11328 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11329 * s/template.h (SIGTYPE): Remove commented out definition.
11331 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11333 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11334 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11336 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11338 * w32.c (read_unc_volume): Use parameter `henum', instead of
11339 global variable `wget_enum_handle'.
11341 * keymap.c (describe_vector): Remove parameters `indices' and
11342 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11343 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11345 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11347 * keyboard.c (timer_check): Remove parameter `do_it_now',
11348 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11349 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11350 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11352 * keyboard.c (read_char):
11353 * w32menu.c (w32_menu_display_help):
11354 * xmenu.c (show_help_event, menu_help_callback):
11355 Adjust calls to `show_help_echo'.
11357 * gtkutil.c (xg_maybe_add_timer):
11358 * keyboard.c (readable_events):
11359 * process.c (wait_reading_process_output):
11360 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11362 * insdel.c (adjust_markers_gap_motion):
11363 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11364 (gap_left, gap_right): Don't call it.
11366 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11368 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11369 incurred during fontification.
11371 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11373 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11374 (DEFVAR_PER_BUFFER): Don't pass it.
11376 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11377 (scrolling_window): Don't pass it.
11379 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11381 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11383 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11385 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11386 of variables specific to SELinux and computation of `encoded_absname'.
11388 * image.c (XPutPixel): Remove unused variable `height'.
11390 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11392 * unexw32.c (get_section_info): Remove unused variable `section'.
11394 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11395 (system_process_attributes): Remove unused variable `sess'.
11396 (sys_read): Remove unused variable `err'.
11398 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11399 (w32_wnd_proc): Remove unused variable `isdead'.
11400 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11401 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11402 (x_create_tip_frame): Remove unused variable `tem'.
11404 * w32inevt.c (w32_console_read_socket):
11405 Remove unused variable `no_events'.
11407 * w32term.c (x_draw_composite_glyph_string_foreground):
11408 Remove unused variable `width'.
11410 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11412 * w32term.c (x_set_glyph_string_clipping):
11413 Don't pass uninitialized region to CombineRgn.
11415 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11417 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11418 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11419 (Fx_close_connection): Remove unused variable `i'.
11421 * w32font.c (w32font_draw): Return number of glyphs.
11422 (w32font_open_internal): Remove unused variable `i'.
11423 (w32font_driver): Add missing initializer.
11425 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11426 (fill_in_menu): Remove unused variable `items_added'.
11428 * w32term.c (last_mouse_press_frame): Remove static global variable.
11429 (w32_clip_to_row): Remove unused variable `f'.
11430 (x_delete_terminal): Remove unused variable `i'.
11432 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11433 (NOTHING): Remove unused static global variable.
11434 (uniscribe_check_otf): Remove unused variable `table'.
11435 (uniscribe_font_driver): Add missing initializers.
11437 2011-03-23 Julien Danjou <julien@danjou.info>
11439 * term.c (Fsuspend_tty, Fresume_tty):
11440 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11441 * window.c (temp_output_buffer_show):
11442 * insdel.c (signal_before_change):
11443 * frame.c (Fhandle_switch_frame):
11444 * fileio.c (Fdo_auto_save):
11445 * emacs.c (Fkill_emacs):
11446 * editfns.c (save_excursion_restore):
11447 * cmds.c (internal_self_insert):
11448 * callint.c (Fcall_interactively):
11449 * buffer.c (Fkill_all_local_variables):
11450 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11452 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11453 unconditionally since it does the check itself.
11455 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11457 Fix more problems found by GCC 4.5.2's static checks.
11459 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11460 the first time through the loop, since we know p0 < p1 then.
11461 This also avoids a gcc -Wstrict-overflow warning.
11463 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11464 leading to a memory leak, possible in functions like
11465 load_charset_map_from_file that can allocate an unbounded number
11466 of objects (Bug#8318).
11468 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11469 that could (at least in theory) be that large.
11471 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11472 This is less likely to overflow, and avoids undefined behavior if
11473 overflow does occur. All callers changed. Use strtoul to scan
11474 for the unsigned long integer.
11475 (pint2hrstr): Simplify and tune code slightly.
11476 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11478 * scroll.c (do_scrolling): Work around GCC bug 48228.
11479 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11481 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11482 This also avoids a warning with gcc -Wstrict-overflow.
11483 (validate_x_resource_name): Simplify count usage.
11484 This also avoids a warning with gcc -Wstrict-overflow.
11486 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11489 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11491 * process.c (Fmake_network_process): Use socklen_t, not int,
11492 where POSIX says socklen_t is required in portable programs.
11493 This fixes a porting bug on hosts like 64-bit HP-UX, where
11494 socklen_t is wider than int (Bug#8277).
11495 (Fmake_network_process, server_accept_connection):
11496 (wait_reading_process_output, read_process_output):
11499 * process.c: Rename or move locals to avoid shadowing.
11500 (list_processes_1, Fmake_network_process):
11501 (read_process_output_error_handler, exec_sentinel_error_handler):
11502 Rename or move locals.
11503 (Fmake_network_process): Define label "retry_connect" only if needed.
11504 (Fnetwork_interface_info): Fix pointer signedness.
11505 (process_send_signal): Add cast to avoid pointer signedness problem.
11506 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11507 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11509 Make tparam.h and terminfo.c consistent.
11510 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11511 Include tparam.h instead, since it declares them.
11512 * cm.h (PC): Remove extern decl; tparam.h now does this.
11513 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11514 * terminfo.c: Include tparam.h, to check interfaces.
11515 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11516 (tparam): Adjust signature to match interface in tparam.h;
11517 this removes some undefined behavior. Check that outstring and len
11518 are zero, which they always are with Emacs.
11519 * tparam.h (PC, BC, UP): New extern decls.
11521 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11522 (xftfont_open): Rename locals to avoid shadowing.
11524 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11525 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11526 (OTF_TAG_SYM): Omit macro if not needed.
11527 (ftfont_list): Remove unused local.
11528 (get_adstyle_property, ftfont_pattern_entity):
11529 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11530 Rename locals to avoid shadowing.
11532 * xfont.c (xfont_list_family): Mark var as initialized.
11534 * xml.c (make_dom): Now static.
11536 * composite.c (composition_compute_stop_pos): Rename local to
11538 (composition_reseat_it): Remove unused locals.
11539 (find_automatic_composition, composition_adjust_point): Likewise.
11540 (composition_update_it): Mark var as initialized.
11541 (find_automatic_composition): Mark vars as initialized,
11542 with a FIXME (Bug#8290).
11544 character.h: Rename locals to avoid shadowing.
11545 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11546 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11547 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11548 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11549 to avoid shadowing.
11551 * textprop.c (property_change_between_p): Remove; unused.
11553 * intervals.c (interval_start_pos): Now static.
11555 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11557 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11558 Rename locals to avoid shadowing.
11560 * sound.c (wav_play, au_play, Fplay_sound_internal):
11561 Fix pointer signedness.
11562 (alsa_choose_format): Remove unused local var.
11563 (wav_play): Initialize a variable to 0, to prevent undefined
11564 behavior (Bug#8278).
11566 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11568 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11570 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11571 clobbering (Bug#8298).
11572 * sysdep.c (sys_subshell): Likewise.
11573 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11575 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11576 This should get cleaned up, so that child_setup has the
11577 same signature on all platforms.
11579 * callproc.c (call_process_cleanup): Now static.
11580 (relocate_fd): Rename locals to avoid shadowing.
11582 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11584 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11585 not to be necessary, and produces flickering.
11587 2011-03-20 Glenn Morris <rgm@gnu.org>
11589 * config.in: Remove file.
11591 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11593 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11594 are now in src/globals.h.
11595 (syms_of_minibuf): Remove spurious & from previous change.
11597 2011-03-20 Leo Liu <sdl.web@gmail.com>
11599 * minibuf.c (completing-read-function): New variable.
11600 (completing-read-default): Rename from completing-read.
11601 (completing-read): Call completing-read-function.
11603 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11605 * xfaces.c (Fx_load_color_file):
11606 Read color file from absolute filename (bug#8250).
11608 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11610 * makefile.w32-in: Update dependencies.
11612 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11614 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11616 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11618 Fix more problems found by GCC 4.5.2's static checks.
11620 * process.c (make_serial_process_unwind, send_process_trap):
11621 (sigchld_handler): Now static.
11623 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11624 That way, the code declares only the vars that it needs.
11625 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11626 * s/cygwin.h (PTY_ITERATION): Likewise.
11627 * s/darwin.h (PTY_ITERATION): Likewise.
11628 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11630 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11631 * process.c (allocate_pty): Don't declare stb unless it's needed.
11633 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11634 (CONSTANTLIM): Remove; unused.
11635 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11636 Define only if needed.
11638 * unexelf.c (unexec): Name an expression,
11639 to avoid gcc -Wbad-function-cast warning.
11640 Use a different way to cause a compilation error if anyone uses
11641 n rather than nn, a way that does not involve shadowing.
11642 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11644 * deps.mk (unexalpha.o): Remove; unused.
11646 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11647 * unexec.h: New file.
11648 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11649 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11650 Depend on unexec.h.
11651 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11652 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11653 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11654 Change as necessary to match prototype in unexec.h.
11656 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11658 (back_comment, skip_chars): Mark vars as initialized.
11660 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11661 Rename locals to avoid shadowing.
11663 * lread.c (read1): Rewrite so as not to use empty "else".
11664 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11666 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11668 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11669 warning when compiling print.c.
11671 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11672 instead of using an uninitialized var.
11673 (font_sort_entities): Mark var as initialized.
11675 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11677 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11678 pointers to constants.
11679 (font_parse_fcname): Remove unused vars.
11680 (font_delete_unmatched): Now static.
11681 (font_get_spec): Remove; unused.
11682 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11683 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11684 Rename or move locals to avoid shadowing.
11686 * fns.c (require_nesting_list, require_unwind): Now static.
11687 (Ffillarray): Rename locals to avoid shadowing.
11689 * floatfns.c (domain_error2): Define only if needed.
11690 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11692 * alloc.c (mark_backtrace): Move decl from here ...
11693 * lisp.h: ... to here, so that it can be checked.
11695 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11696 (Fdefvar): Rewrite so as not to use empty "else".
11697 (lisp_indirect_variable): Name an expression,
11698 to avoid gcc -Wbad-function-cast warning.
11699 (Fdefvar): Rename locals to avoid shadowing.
11701 * callint.c (quotify_arg, quotify_args): Now static.
11702 (Fcall_interactively): Rename locals to avoid shadowing.
11703 Use const pointer when appropriate.
11705 * lisp.h (get_system_name, get_operating_system_release):
11706 Move decls here, to check interfaces.
11707 * process.c (get_operating_system_release): Move decl to lisp.h.
11708 * xrdb.c (get_system_name): Likewise.
11709 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11710 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11711 some of which prompt warnings from gcc -Wbad-function-cast.
11712 (Fformat_time_string, Fencode_time, Finsert_char):
11713 (Ftranslate_region_internal, Fformat):
11714 Rename or remove local vars to avoid shadowing.
11715 (Ftranslate_region_internal): Mark var as initialized.
11717 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11720 * lisp.h (eassert): Check that the argument compiles, even if
11721 ENABLE_CHECKING is not defined.
11723 * data.c (Findirect_variable): Name an expression, to avoid
11724 gcc -Wbad-function-cast warning.
11725 (default_value, arithcompare, arith_driver, arith_error): Now static.
11726 (store_symval_forwarding): Rename local to avoid shadowing.
11727 (Fmake_variable_buffer_local, Fmake_local_variable):
11728 Mark variables as initialized.
11729 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11731 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11732 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11733 Rename locals to avoid shadowing.
11734 (mark_stack): Move local variables into the #ifdef region where
11736 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11737 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11739 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11740 (GC_STRING_CHARS): Remove; not used.
11741 (Fmemory_limit): Cast sbrk's returned value to char *.
11743 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11744 avoids undefined behavior in theory.
11746 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11748 Use functions, not macros, for up- and down-casing (Bug#8254).
11749 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11750 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11751 to use the following functions instead of these macros.
11752 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11753 EMACS_INT, since callers assume the returned value fits in int.
11754 (upcase1): Likewise, for UPCASE_TABLE.
11755 (uppercasep, lowercasep, upcase): New static inline functions.
11756 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11757 the race-condition problem in the old DOWNCASE.
11759 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11760 Rename locals to avoid shadowing.
11761 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11762 (regex_compile, re_search_2, re_match_2_internal):
11763 Remove unused local vars.
11764 (FREE_VAR): Rewrite so as not to use empty "else",
11765 which gcc can warn about.
11766 (regex_compile, re_match_2_internal): Mark locals as initialized.
11767 (RETALLOC_IF): Define only if needed.
11768 (WORDCHAR_P): Likewise. This one is never needed, but is used
11769 only in a comment talking about a compiler bug, so put inside
11770 the #if 0 of that comment.
11771 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11772 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11775 * search.c (boyer_moore): Rename locals to avoid shadowing.
11776 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11777 (PREV_CHAR_BOUNDARY): Likewise.
11779 * search.c (simple_search): Remove unused var.
11781 * dired.c (compile_pattern): Move decl from here ...
11782 * lisp.h: ... to here, so that it can be checked.
11783 (struct re_registers): New forward decl.
11785 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11787 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11789 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11790 Rename locals to avoid shadowing.
11791 (Fvertical_motion): Mark locals as initialized.
11793 * casefiddle.c (casify_object, casify_region): Now static.
11794 (casify_region): Mark local as initialized.
11796 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11798 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11799 New macros, so that the caller can use some names other than
11800 gcpro1, gcpro2, etc.
11801 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11803 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11804 argument, for consistency with GCPRO2_VAR, etc: it is now the
11805 prefix of the variable, not the variable itself. All uses
11807 * dired.c (directory_files_internal, file_name_completion):
11808 Rename locals to avoid shadowing.
11810 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11811 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11812 dired.c's scmp function, had undefined behavior.
11813 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11814 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11815 * buffer.h: ... to here, because these macros use current_buffer,
11816 and the new implementation with inline functions needs to have
11817 current_buffer in scope now, rather than later when the macros
11819 (downcase, upcase1): New static inline functions.
11820 (DOWNCASE, UPCASE1): Reimplement using these functions.
11821 This avoids undefined behavior in expressions like
11822 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11823 from race conditions in accessing the global variables
11824 case_temp1 and case_temp2.
11825 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11826 * lisp.h (case_temp1, case_temp2): Remove their decls.
11827 * character.h (ASCII_CHAR_P): Move from here ...
11828 * lisp.h: ... to here, so that the inline functions mentioned
11829 above can use them.
11831 * dired.c (directory_files_internal_unwind): Now static.
11833 * fileio.c (file_name_as_directory, directory_file_name):
11834 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11836 (file_name_as_directory): Use const pointers when appropriate.
11837 (Fexpand_file_name): Likewise. In particular, newdir might
11838 point at constant storage, so make it a const pointer.
11839 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11840 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11842 (Fset_file_times, Finsert_file_contents, auto_save_error):
11843 Rename locals to avoid shadowing.
11845 * minibuf.c (choose_minibuf_frame_1): Now static.
11846 (Ftry_completion, Fall_completions): Rename or remove locals
11847 to avoid shadowing.
11849 * marker.c (bytepos_to_charpos): Remove; unused.
11851 * lisp.h (verify_bytepos, count_markers): New decls,
11852 so that gcc does not warn that these functions aren't declared.
11854 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11855 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11856 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11857 (copy_text): Remove unused local var.
11859 * filelock.c (within_one_second): Now static.
11860 (lock_file_1): Rename local to avoid shadowing.
11862 * buffer.c (fix_overlays_before): Mark locals as initialized.
11863 (fix_start_end_in_overlays): Likewise. This function should be
11864 simplified by using pointers-to-pointers, but that's a different
11866 (switch_to_buffer_1): Now static.
11867 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11868 (report_overlay_modification): Rename locals to avoid shadowing.
11870 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11871 Fix pointer signedness issue.
11872 (sys_subshell): Mark local as volatile if checking for lint,
11873 to suppress a gcc -Wclobbered warning that does not seem to be right.
11874 (MAXPATHLEN): Define only if needed.
11876 * process.c (serial_open, serial_configure): Move decls from here ...
11877 * systty.h: ... to here, so that they can be checked.
11879 * fns.c (get_random, seed_random): Move extern decls from here ...
11880 * lisp.h: ... to here, so that they can be checked.
11882 * sysdep.c (reset_io): Now static.
11883 (wait_for_termination_signal): Remove; unused.
11885 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11886 (copy_keymap_item, append_key, push_text_char_description):
11888 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11889 (DENSE_TABLE_SIZE): Remove; unused.
11890 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11891 (describe_map_tree):
11892 Rename locals to avoid shadowing.
11894 * keyboard.c: Declare functions static if they are not used elsewhere.
11895 (echo_char, echo_dash, cmd_error, top_level_2):
11896 (poll_for_input, handle_async_input): Now static.
11897 (read_char, kbd_buffer_get_event, make_lispy_position):
11898 (make_lispy_event, make_lispy_movement, apply_modifiers):
11899 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11900 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11901 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11902 (read_key_sequence, read_char): Mark locals as initialized.
11903 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11905 * keyboard.h (make_ctrl_char): New decl.
11906 (mark_kboards): Move decl here ...
11907 * alloc.c (mark_kboards): ... from here.
11909 * lisp.h (force_auto_save_soon): New decl.
11911 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11912 (DEFINE_DUMMY_FUNCTION): New macro.
11913 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11915 (main): Add casts to avoid warnings
11916 if GCC considers string literals to be constants.
11918 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11920 * dbusbind.c: Pointer signedness fixes.
11921 (xd_signature, xd_append_arg, xd_initialize):
11922 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11923 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11924 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11925 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11927 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11928 if GCC considers string literals to be constants.
11929 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11931 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11933 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11934 (print_preprocess, print_object): New macro to fix last change.
11936 * print.c (print_preprocess): Don't forget font objects.
11938 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11940 * emacs.c (USAGE3): Doc fixes.
11942 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11944 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11947 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11949 * lisp.h (VWindow_system, Qfile_name_history):
11950 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11951 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11952 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11954 * w32select.c: Don't #include "keyboard.h".
11955 (run_protected): Add extern declaration for waiting_for_input.
11957 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11958 * w32console.c (detect_input_pending, read_input_pending)
11959 (encode_terminal_code):
11960 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11961 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11962 (w32_system_caret_y, Qfile_name_history):
11963 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11964 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11965 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11966 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11967 * w32proc.c (Qlocal, report_file_error):
11968 * w32term.c (Vwindow_system, updating_frame):
11969 * w32uniscribe.c (initialized, uniscribe_font_driver):
11970 Remove unneeded extern declarations.
11972 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11974 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11976 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11978 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11979 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11980 These macros can no longer be used for assignment.
11982 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11983 Assign struct members directly, instead of using BUF_BEGV etc.
11984 (record_buffer_markers, fetch_buffer_markers): New functions for
11985 recording and fetching special buffer markers.
11986 (set_buffer_internal_1, set_buffer_temp): Use them.
11988 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11990 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11992 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11993 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11995 * xdisp.c (hscroll_window_tree):
11996 (reconsider_clip_changes): Use PT instead of BUF_PT.
11998 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12000 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12001 $(EMACS_ROOT)/lib/intprops.h.
12003 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12005 Fix more problems found by GCC 4.5.2's static checks.
12007 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12008 to unsigned char * to avoid compiler diagnostic.
12009 (xg_free_frame_widgets): Make it clear that a local variable is
12010 needed only if USE_GTK_TOOLTIP.
12011 (gdk_window_get_screen): Make it clear that this macro is needed
12012 only if USE_GTK_TOOLTIP.
12013 (int_gtk_range_get_value): New function, which avoids a diagnostic
12014 from gcc -Wbad-function-cast.
12015 (xg_set_toolkit_scroll_bar_thumb): Use it.
12016 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12017 diagnostic from gcc -Wbad-function-cast.
12018 (get_utf8_string, xg_get_file_with_chooser):
12019 Rename locals to avoid shadowing.
12020 (create_dialog): Move locals to avoid shadowing.
12022 * xgselect.c (xg_select): Remove unused var.
12024 * image.c (four_corners_best): Mark locals as initialized.
12025 (gif_load): Initialize transparent_p to zero (Bug#8238).
12026 Mark another local as initialized.
12027 (my_png_error, my_error_exit): Mark with NO_RETURN.
12029 * image.c (clear_image_cache): Now static.
12030 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12031 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12032 (x_edge_detection): Remove unnecessary cast that
12033 gcc -Wbad-function-cast diagnoses.
12034 (gif_load): Fix pointer signedness.
12035 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12036 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12038 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12040 Improve quality of tests for time stamp overflow.
12041 For example, without this patch (encode-time 0 0 0 1 1
12042 1152921504606846976) returns the obviously-bogus value (-948597
12043 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12044 reports time overflow. See
12045 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12046 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12047 * editfns.c: Include limits.h and intprops.h.
12048 (TIME_T_MIN, TIME_T_MAX): New macros.
12049 (time_overflow): Move earlier, to before first use.
12050 (hi_time, lo_time): New functions, for an accurate test for
12051 out-of-range times.
12052 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12053 (Fget_internal_run_time): Don't assume time_t fits in int.
12054 (make_time): Use list2 instead of Fcons twice.
12055 (Fdecode_time): More accurate test for out-of-range times.
12056 (check_tm_member): New function.
12057 (Fencode_time): Use it, to test for out-of-range times.
12058 (lisp_time_argument): Don't rely on undefined left-shift and
12059 right-shift behavior when checking for time stamp overflow.
12061 * editfns.c (time_overflow): New function, refactoring common code.
12062 (Fformat_time_string, Fdecode_time, Fencode_time):
12063 (Fcurrent_time_string): Use it.
12065 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12066 * dired.c (make_time): Move to ...
12067 * editfns.c (make_time): ... here.
12068 * systime.h: Note the move.
12070 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12072 * fringe.c (update_window_fringes): Remove unused variables.
12074 * unexmacosx.c (copy_data_segment): Also copy __got section.
12077 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12079 * termcap.c [MSDOS]: Include "msdos.h".
12080 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12081 Constify `char *' arguments and their references according to
12082 prototypes in tparam.h.
12084 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12086 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12087 Adapt all references accordingly.
12089 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12091 2011-03-11 Tom Tromey <tromey@redhat.com>
12093 * buffer.c (syms_of_buffer): Remove obsolete comment.
12095 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12097 * termhooks.h (encode_terminal_code): Declare prototype.
12099 * msdos.c (encode_terminal_code): Don't declare prototype.
12101 * term.c (encode_terminal_code): Now external again, used by
12102 w32console.c and msdos.c.
12104 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12105 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12107 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12109 Fix some minor problems found by GCC 4.5.2's static checks.
12111 * fringe.c (update_window_fringes): Mark locals as initialized
12113 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12115 * alloc.c (mark_fringe_data): Move decl from here ...
12116 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12117 to check its interface.
12118 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12120 * fontset.c (free_realized_fontset): Now static.
12121 (Fset_fontset_font): Rename local to avoid shadowing.
12122 (fontset_font): Mark local as initialized.
12123 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12125 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12127 * xselect.c (x_disown_buffer_selections): Remove; not used.
12128 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12129 (x_own_selection, Fx_disown_selection_internal): Rename locals
12130 to avoid shadowing.
12131 (x_handle_dnd_message): Remove local to avoid shadowing.
12133 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12134 so that the caller can use some name other than gcpro1.
12135 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12136 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12137 (Fx_backspace_delete_keys_p):
12138 Use them to avoid shadowing, and rename vars to avoid shadowing.
12139 (x_decode_color, x_set_name, x_window): Now static.
12140 (Fx_create_frame): Add braces to silence GCC warning.
12141 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12142 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12143 Remove unused locals.
12144 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12145 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12146 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12149 * xterm.h (x_mouse_leave): New decl.
12151 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12152 Remove unused functions.
12153 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12154 (x_calc_absolute_position): Now static.
12155 (XTread_socket): Don't define label "out" unless it's used.
12156 Don't declare local "event" unless it's used.
12157 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12158 unless they are used.
12159 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12160 (x_fatal_error_signal): Remove; not used.
12161 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12162 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12163 (x_error_catcher, x_connection_closed, x_error_handler):
12164 (x_error_quitter, xembed_send_message, x_iconify_frame):
12165 (my_log_handler): Rename locals to avoid shadowing.
12166 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12167 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12169 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12170 Rename or move locals to avoid shadowing.
12171 (tty_defined_color, merge_face_heights): Now static.
12172 (free_realized_faces_for_fontset): Remove; not used.
12173 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12174 does not deduce is never used uninitialized.
12175 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12176 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12178 * terminal.c (store_terminal_param): Now static.
12180 * xmenu.c (menu_highlight_callback): Now static.
12181 (set_frame_menubar): Remove unused local.
12182 (xmenu_show): Rename parameter to avoid shadowing.
12183 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12184 since they might point to immutable storage.
12185 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12186 since it's unused otherwise.
12188 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12189 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12190 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12191 avoids a gcc -Wuninitialized diagnostic.
12192 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12193 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12194 does not deduce are never used uninitialized.
12196 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12198 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12199 * window.c (window_loop, size_window):
12200 (run_window_configuration_change_hook, enlarge_window): Likewise.
12202 * window.c (display_buffer): Now static.
12203 (size_window): Mark variables that gcc -Wuninitialized
12204 does not deduce are never used uninitialized.
12205 * window.h (check_all_windows): New decl, to forestall
12206 gcc -Wmissing-prototypes diagnostic.
12207 * dispextern.h (bidi_dump_cached_states): Likewise.
12209 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12211 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12212 Include <limits.h>.
12213 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12214 and to avoid gcc -Wuninitialized warning.
12215 (load_charset_map): Mark variables that gcc -Wuninitialized
12216 does not deduce are never used uninitialized.
12217 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12219 * coding.c (coding_set_source, coding_set_destination):
12220 Use "else { /* comment */ }" rather than "else /* comment */;"
12221 for clarity, and to avoid gcc -Wempty-body warning.
12222 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12223 a block, when the outer 'i' will do.
12224 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12225 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12226 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12227 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12228 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12229 Rename locals to avoid shadowing.
12230 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12231 * coding.c (emacs_mule_char, encode_invocation_designation):
12232 Now static, since they're not used elsewhere.
12233 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12234 (decode_coding_object, encode_coding_object, detect_coding_system):
12235 (decode_coding_emacs_mule): Mark variables that gcc
12236 -Wuninitialized does not deduce are never used uninitialized.
12237 (detect_coding_iso_2022): Initialize a local variable that might
12238 be used uninitialized. Leave a FIXME because it's not clear that
12239 this initialization is needed. (Bug#8211)
12240 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12241 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12242 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12243 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12244 Remove unused macros.
12246 * category.c (hash_get_category_set): Remove unused local var.
12247 (copy_category_table): Now static, since it's not used elsewhere.
12248 * character.c (string_count_byte8): Likewise.
12250 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12251 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12253 * chartab.c (copy_sub_char_table): Now static, since it's not used
12255 (sub_char_table_ref_and_range, char_table_ref_and_range):
12256 Rename locals to avoid shadowing.
12257 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12259 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12260 (BIDI_BOB): Remove unused macro.
12262 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12263 deduce are never used uninitialized.
12264 * term.c (encode_terminal_code): Likewise.
12266 * term.c (encode_terminal_code): Now static. Remove unused local.
12268 * tparam.h: New file.
12269 * term.c, tparam.h: Include it.
12270 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12271 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12272 Move these decls to tparam.h, and make them agree with what
12273 is actually in tparam.c. The previous trick of using incompatible
12274 decls in different modules does not conform to the C standard.
12275 All callers of tparam changed to use tparam's actual API.
12276 * tparam.c (tparam1, tparam, tgoto):
12277 Use const pointers where appropriate.
12279 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12280 * cm.h (struct cm): Likewise.
12281 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12282 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12283 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12284 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12285 (turn_on_face, init_tty): Likewise.
12286 * termchar.h (struct tty_display_info): Likewise.
12288 * term.c (term_mouse_position): Rename local to avoid shadowing.
12290 * alloc.c (mark_ttys): Move decl from here ...
12291 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12293 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12295 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12297 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12299 * search.c (compile_pattern_1): Remove argument regp, unused since
12300 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12301 (compile_pattern): Don't pass it.
12303 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12305 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12306 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12308 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12310 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12312 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12313 gdk_window_get_screen, gdk_window_get_geometry,
12314 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12315 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12316 (xg_get_pixbuf_from_pixmap): New function.
12317 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12318 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12319 Call xg_get_pixbuf_from_pixmap instead of
12320 gdk_pixbuf_get_from_drawable.
12321 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12322 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12323 (xg_check_special_colors): Use GtkStyleContext and its functions
12325 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12326 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12327 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12328 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12329 Call gtk_widget_get_preferred_size.
12330 (xg_frame_resized): gdk_window_get_geometry only takes 5
12332 (xg_win_to_widget, xg_event_is_for_menubar):
12333 Call gdk_x11_window_lookup_for_display.
12334 (xg_set_widget_bg): New function.
12335 (delete_cb): New function.
12336 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12337 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12338 (xg_set_background_color): Call xg_set_widget_bg.
12339 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12340 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12341 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12342 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12344 (update_frame_tool_bar): Call gtk_widget_hide.
12345 (xg_initialize): Use GDK_KEY_g.
12347 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12349 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12351 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12352 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12353 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12355 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12357 * w32xfns.c (select_palette): Check success of RealizePalette against
12358 GDI_ERROR, not zero.
12360 See ChangeLog.11 for earlier changes.
12362 ;; Local Variables:
12366 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12368 This file is part of GNU Emacs.
12370 GNU Emacs is free software: you can redistribute it and/or modify
12371 it under the terms of the GNU General Public License as published by
12372 the Free Software Foundation, either version 3 of the License, or
12373 (at your option) any later version.
12375 GNU Emacs is distributed in the hope that it will be useful,
12376 but WITHOUT ANY WARRANTY; without even the implied warranty of
12377 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12378 GNU General Public License for more details.
12380 You should have received a copy of the GNU General Public License
12381 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.