1 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from
6 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8 Integer and buffer overflow fixes (Bug#8873).
10 * print.c (printchar, strout): Check for string overflow.
11 (PRINTPREPARE, printchar, strout):
12 Don't set size unless allocation succeeds.
14 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
15 for sizes. Check for string overflow more accurately.
16 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
18 * macros.c: Integer and buffer overflow fixes.
19 * keyboard.h (struct keyboard.kbd_macro_bufsize):
20 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
21 Use ptrdiff_t, not int, for sizes.
22 Don't increment bufsize until after realloc succeeds.
23 Check for size-calculation overflow.
24 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
26 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
28 * lread.c: Integer overflow fixes.
29 (read_integer): Radix is now EMACS_INT, not int,
30 to improve quality of diagnostics for out-of-range radices.
31 Calculate buffer size correctly for out-of-range radices.
32 (read1): Check for integer overflow in radices, and in
34 (read_escape): Avoid int overflow.
35 (Fload, openp, read_buffer_size, read1)
36 (substitute_object_recurse, read_vector, read_list, map_obarray):
37 Use ptrdiff_t, not int, for sizes.
38 (read1): Use EMACS_INT, not int, for sizes.
39 Check for size overflow.
41 * image.c (cache_image): Check for size arithmetic overflow.
43 * lread.c: Integer overflow issues.
44 (saved_doc_string_size, saved_doc_string_length)
45 (prev_saved_doc_string_size, prev_saved_doc_string_length):
46 Now ptrdiff_t, not int.
47 (read1): Don't assume doc string length fits in int. Check for
48 out-of-range doc string lengths.
49 (read_list): Don't assume file position fits in int.
50 (read_escape): Check for hex character overflow.
52 2011-06-22 Leo Liu <sdl.web@gmail.com>
54 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
55 Move to minibuffer.el.
57 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
59 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
60 The following patches are for when GLYPH_DEBUG && !XASSERT.
61 * dispextern.h (trace_redisplay_p, dump_glyph_string):
62 * dispnew.c (flush_stdout):
63 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
64 Mark as externally visible.
65 * dispnew.c (check_window_matrix_pointers): Now static.
66 * dispnew.c (window_to_frame_vpos):
67 * xfns.c (unwind_create_frame):
68 * xterm.c (x_check_font): Remove unused local.
69 * scroll.c (CHECK_BOUNDS):
70 * xfaces.c (cache_fache): Rename local to avoid shadowing.
71 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
72 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
73 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
74 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
76 (debug_method_add): Use va_list and vsprintf rather than relying
77 on undefined behavior with wrong number of arguments.
78 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
79 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
80 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
81 since we're not interested in debugging glyphs with old libraries.
82 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
83 GCC 4.6.0's static checking.
85 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
87 Integer overflow and signedness fixes (Bug#8873).
88 A few related buffer overrun fixes, too.
90 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
92 * dispextern.h (struct face.stipple):
93 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
94 (x_bitmap_mask, x_allocate_bitmap_record)
95 (x_create_bitmap_from_data, x_create_bitmap_from_file)
96 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
97 (x_create_bitmap_from_xpm_data):
98 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
99 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
101 * xfaces.c (load_pixmap):
102 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
103 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
104 (.bitmaps_last, struct x_output.icon_bitmap):
105 Use ptrdiff_t, not int, for bitmap indexes.
106 (x_allocate_bitmap_record): Check for size overflow.
107 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
109 Use ptrdiff_t, not int, for overlay counts.
110 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
111 * editfns.c (overlays_around, get_pos_property):
112 * textprop.c (get_char_property_and_overlay):
113 * xdisp.c (next_overlay_change, note_mouse_highlight):
114 * xfaces.c (face_at_buffer_position):
115 * buffer.c (OVERLAY_COUNT_MAX): New macro.
116 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
117 (Fnext_overlay_change, Fprevious_overlay_change)
118 (mouse_face_overlay_overlaps, Foverlays_in):
119 Use ptrdiff_t, not int, for sizes.
120 (overlays_at, overlays_in): Check for size-calculation overflow.
122 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
124 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
125 (x_session_initialize): Do not assume string length fits in int.
127 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
128 This is unlikely, but can occur if DPI is outlandish.
130 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
131 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
133 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
134 * xrdb.c (magic_file_p, search_magic_path):
135 Omit last arg SUFFIX; it was always 0. All callers changed.
136 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
138 * xfont.c (xfont_match): Avoid need for strlen.
140 * xfns.c: Don't assume strlen fits in int.
141 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
143 * xdisp.c (message_log_check_duplicate): Return intmax_t,
144 not unsigned long, as we prefer signed integers. All callers changed.
145 Detect integer overflow in repeat count.
146 (message_dolog): Don't assume print length fits in 39 bytes.
147 (display_mode_element): Don't assume strlen fits in int.
149 * termcap.c: Don't assume sizes fit in int and never overflow.
150 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
151 (gobble_line): Check for size-calculation overflow.
153 * minibuf.c (Fread_buffer):
154 * lread.c (intern, intern_c_string):
155 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
156 Don't assume string length fits in int.
158 * keyboard.c (parse_tool_bar_item):
159 * gtkutil.c (style_changed_cb): Avoid need for strlen.
161 * font.c: Don't assume string length fits in int.
162 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
163 Use ptrdiff_t, not int.
164 (font_intern_prop): Don't assume string length fits in int.
165 Don't assume integer property fits in fixnum.
166 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
168 * filelock.c: Fix some buffer overrun and integer overflow issues.
169 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
170 Reformulate so as not to need the command string.
171 Invoke gzip -cd rather than gunzip, as it's more portable.
172 (lock_info_type, lock_file_1, lock_file):
173 Don't assume pid_t and time_t fit in unsigned long.
174 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
175 (current_lock_owner): Prefer signed type for sizes.
176 Use memcpy, not strncpy, where memcpy is what is really wanted.
177 Don't assume (via atoi) that time_t and pid_t fit in int.
178 Check for time_t and/or pid_t out of range, e.g., via a network share.
179 Don't alloca where an auto var works fine.
181 * fileio.c: Fix some integer overflow issues.
182 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
183 Don't assume string length fits in int.
184 (directory_file_name): Don't assume string length fits in long.
185 (make_temp_name): Don't assume pid fits in int, or that its print
186 length is less than 20.
188 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
190 * coding.c (make_subsidiaries): Don't assume string length fits in int.
192 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
194 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
195 We prefer signed integers, even for size calculations.
197 * emacs.c: Don't assume string length fits in 'int'.
198 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
199 (main): Don't invoke strlen when not needed.
201 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
202 (XD_DEBUG_MESSAGE): Don't waste a byte.
204 * callproc.c (getenv_internal_1, getenv_internal)
206 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
208 * lread.c (invalid_syntax): Omit length argument.
209 All uses changed. This doesn't fix a bug, but it simplifies the
210 code away from its former Hollerith-constant appearance, and it's
211 one less 'int' to worry about when looking at integer-overflow issues.
212 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
214 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
215 This didn't break anything, but it didn't help either.
216 It's confusing to put a bogus integer in a place where the actual
217 value does not matter.
218 (LIST_END_P): Remove unused macro and its bogus comment.
219 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
221 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
222 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
224 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
225 We prefer signed types, and the value cannot exceed the EMACS_INT
226 range anyway (because otherwise the length would not be representable).
227 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
228 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
229 This avoids a GCC warning when WIDE_EMACS_INT.
231 * indent.c (sane_tab_width): New function.
232 (current_column, scan_for_column, Findent_to, position_indentation)
233 (compute_motion): Use it. This is just for clarity.
234 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
236 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
238 * lisp.h (lint_assume): New macro.
239 * composite.c (composition_gstring_put_cache):
240 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
242 * editfns.c, insdel.c:
243 Omit unnecessary forward decls, to simplify future changes.
245 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
247 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
249 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
250 Use much-faster test for byte-length change.
251 Don't assume string byte-length fits in 'int'.
252 Check that character arg fits in 'int'.
253 (mapcar1): Declare byte as byte, for clarity.
255 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
257 * fns.c (concat): Catch string overflow earlier.
258 Do not rely on integer wraparound.
260 * dispextern.h (struct it.overlay_strings_charpos)
261 (struct it.selective): Now EMACS_INT, not int.
262 * xdisp.c (forward_to_next_line_start)
263 (back_to_previous_visible_line_start)
264 (reseat_at_next_visible_line_start, next_element_from_buffer):
265 Don't arbitrarily truncate the value of 'selective' to int.
267 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
269 * composite.c: Don't truncate sizes to 'int'.
270 (composition_gstring_p, composition_reseat_it)
271 (composition_adjust_point): Use EMACS_INT, not int.
272 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
273 not EMACS_UINT, for indexes.
275 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
277 * buffer.c: Include <verify.h>.
278 (struct sortvec.priority, struct sortstr.priority):
279 Now EMACS_INT, not int.
280 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
281 (struct sortstr.size, record_overlay_string)
282 (struct sortstrlist.size, struct sortlist.used):
283 Don't truncate size to int.
284 (record_overlay_string): Check for size-calculation overflow.
285 (init_buffer_once): Check at compile-time, not run-time.
287 2011-06-22 Jim Meyering <meyering@redhat.com>
289 don't leak an XBM-image-sized buffer
290 * image.c (xbm_load): Free the image buffer after using it.
292 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
295 * composite.c (find_automatic_composition): Omit needless 'return 0;'
296 that Sun C diagnosed.
297 * fns.c (secure_hash): Fix pointer signedness issue.
298 * intervals.c (static_offset_intervals): New function.
299 (offset_intervals): Use it.
301 2011-06-21 Leo Liu <sdl.web@gmail.com>
304 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
307 * fns.c (secure_hash): Rename from crypto_hash_function and change
308 the first arg to accept symbols.
309 (Fsecure_hash): New primtive.
310 (syms_of_fns): New symbols.
312 2011-06-20 Deniz Dogan <deniz@dogan.se>
314 * process.c (Fset_process_buffer): Clarify return value in
317 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
319 * dispnew.c (add_window_display_history): Use BVAR.
321 * xdisp.c (debug_method_add): Use BVAR.
322 (check_window_end, dump_glyph_matrix, dump_glyph)
323 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
325 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
328 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
329 check till after the cache is created in init_frame_faces.
331 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
333 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
335 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
337 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
338 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
339 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
341 Improve buffer-overflow checking (Bug#8873).
342 * fileio.c (Finsert_file_contents):
343 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
344 Remove the old (too-loose) buffer overflow checks.
345 They weren't needed, since make_gap checks for buffer overflow.
346 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
347 The old code merely checked for Emacs fixnum overflow, and relied
348 on undefined (wraparound) behavior. The new code avoids undefined
349 behavior, and also checks for ptrdiff_t and/or size_t overflow.
351 * editfns.c (Finsert_char): Don't dump core with very negative counts.
352 Tune. Don't use wider integers than needed. Don't use alloca.
353 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
355 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
357 * insdel.c, lisp.h (buffer_overflow): New function.
358 (insert_from_buffer_1, replace_range, replace_range_2):
359 * insdel.c (make_gap_larger):
360 * editfns.c (Finsert_char):
361 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
363 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
365 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
367 Integer overflow and signedness fixes (Bug#8873).
369 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
370 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
372 * fileio.c: Don't assume EMACS_INT fits in off_t.
373 (emacs_lseek): New static function.
374 (Finsert_file_contents, Fwrite_region): Use it.
375 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
377 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
379 * fns.c: Don't overflow int when computing a list length.
380 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
381 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
382 truncation on 64-bit hosts. Check for QUIT every
383 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
384 faster and is responsive enough.
385 (Flength): Report an error instead of overflowing an integer.
386 (Fsafe_length): Return a float if the value is not representable
387 as a fixnum. This shouldn't happen except in contrived situations.
388 (Fnthcdr, Fsort): Don't assume list length fits in int.
389 (Fcopy_sequence): Don't assume vector length fits in int.
391 * alloc.c: Check that resized vectors' lengths fit in fixnums.
392 (header_size, word_size): New constants.
393 (allocate_vectorlike): Don't check size overflow here.
394 (allocate_vector): Check it here instead, since this is the only
395 caller of allocate_vectorlike that could cause overflow.
396 Check that the new vector's length is representable as a fixnum.
398 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
399 The previous code was bogus. For example, next_almost_prime (32)
400 returned 39, which is undesirable as it is a multiple of 3; and
401 next_almost_prime (24) returned 25, which is a multiple of 5 so
402 why was the code bothering to check for multiples of 7?
404 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
406 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
408 Variadic C functions now count arguments with ptrdiff_t.
409 This partly undoes my 2011-03-30 change, which replaced int with size_t.
410 Back then I didn't know that the Emacs coding style prefers signed int.
411 Also, in the meantime I found a few more instances where arguments
412 were being counted with int, which may truncate counts on 64-bit
413 machines, or EMACS_INT, which may be unnecessarily wide.
414 * lisp.h (struct Lisp_Subr.function.aMANY)
415 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
416 Arg counts are now ptrdiff_t, not size_t.
417 All variadic functions and their callers changed accordingly.
418 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
419 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
420 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
421 * callint.c (Fcall_interactively): Check arg count for overflow,
422 to avoid potential buffer overrun. Use signed char, not 'int',
423 for 'varies' array, so that we needn't bother to check its size
424 calculation for overflow.
425 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
426 * eval.c (apply_lambda):
427 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
428 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
429 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
431 * callint.c (Fcall_interactively): Don't use index var as event count.
433 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
434 * mem-limits.h (SIZE): Remove; no longer used.
436 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
438 Remove unnecessary casts.
439 * xterm.c (x_term_init):
440 * xfns.c (x_set_border_pixel):
441 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
442 These aren't needed now that we assume ANSI C.
444 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
445 It's more likely to cause problems (due to unsigned overflow)
448 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
450 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
452 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
454 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
456 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
458 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
460 GLYPH_CODE_FACE returns EMACS_INT, not int.
461 * dispextern.h (merge_faces):
462 * xfaces.c (merge_faces):
463 * xdisp.c (get_next_display_element, next_element_from_display_vector):
464 Don't assume EMACS_INT fits in int.
466 * character.h (CHAR_VALID_P): Remove unused parameter.
467 * fontset.c, lisp.h, xdisp.c: All uses changed.
469 * editfns.c (Ftranslate_region_internal): Omit redundant test.
471 * fns.c (concat): Minor tuning based on overflow analysis.
472 This doesn't fix any bugs. Use int to hold character, instead
473 of constantly refetching from Emacs object. Use XFASTINT, not
474 XINT, for value known to be a character. Don't bother comparing
475 a single byte to 0400, as it's always less.
477 * floatfns.c (Fexpt):
478 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
480 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
483 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
485 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
486 Without this fix, on a 64-bit host (aset S 0 4294967386) would
487 incorrectly succeed when S was a string, because 4294967386 was
488 truncated before it was used.
490 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
491 Otherwise, an out-of-range integer could cause undefined behavior
494 * composite.c: Use int, not EMACS_INT, for characters.
495 (fill_gstring_body, composition_compute_stop_pos): Use int, not
496 EMACS_INT, for values that are known to be in character range.
497 This doesn't fix any bugs but is the usual style inside Emacs and
498 may generate better code on 32-bit machines.
500 Make sure a 64-bit char is never passed to ENCODE_CHAR.
501 This is for reasons similar to the recent CHAR_STRING fix.
502 * charset.c (Fencode_char): Check that character arg is actually
503 a character. Pass an int to ENCODE_CHAR.
504 * charset.h (ENCODE_CHAR): Verify that the character argument is no
505 wider than 'int', as a compile-time check to prevent future regressions
508 * character.c (char_string): Remove unnecessary casts.
510 Make sure a 64-bit char is never passed to CHAR_STRING.
511 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
512 by silently ignoring the top 32 bits, allowing some values
513 that were far too large to be valid characters.
514 * character.h: Include <verify.h>.
515 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
516 arguments are no wider than unsigned, as a compile-time check
517 to prevent future regressions in this area.
519 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
520 (Fsubst_char_in_region):
522 * xdisp.c (decode_mode_spec_coding):
523 Adjust to CHAR_STRING's new requirement.
524 * editfns.c (Finsert_char, Fsubst_char_in_region):
525 * fns.c (concat): Check that character args are actually
526 characters. Without this test, these functions did the wrong
527 thing with wildly out-of-range values on 64-bit hosts.
529 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
530 These casts should not be needed on 32-bit hosts, either.
531 * keyboard.c (read_char):
532 * lread.c (Fload): Remove casts to unsigned.
534 * lisp.h (UNSIGNED_CMP): New macro.
535 This fixes comparison bugs on 64-bit hosts.
536 (ASCII_CHAR_P): Use it.
537 * casefiddle.c (casify_object):
538 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
539 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
540 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
541 * dispextern.h (FACE_FROM_ID):
542 * keyboard.c (read_char): Use UNSIGNED_CMP.
544 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
545 not to EMACS_INT, to avoid GCC warning.
547 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
549 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
550 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
551 isn't needed on 32-bit machines.
553 * buffer.c (Fgenerate_new_buffer_name):
554 Use EMACS_INT for count, not int.
555 (advance_to_char_boundary): Return EMACS_INT, not int.
557 * data.c (Qcompiled_function): Now static.
559 * window.c (window_body_lines): Now static.
561 * image.c (gif_load): Rename local to avoid shadowing.
563 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
564 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
565 * alloc.c (make_save_value): Integer argument is now of type
567 (mark_object): Use ptrdiff_t, not int.
568 * lisp.h (pD): New macro.
569 * print.c (print_object): Use it.
571 * alloc.c: Use EMACS_INT, not int, to count objects.
572 (total_conses, total_markers, total_symbols, total_vector_size)
573 (total_free_conses, total_free_markers, total_free_symbols)
574 (total_free_floats, total_floats, total_free_intervals)
575 (total_intervals, total_strings, total_free_strings):
576 Now EMACS_INT, not int. All uses changed.
577 (Fgarbage_collect): Compute overall total using a double, so that
578 integer overflow is less likely to be a problem. Check for overflow
579 when converting back to an integer.
580 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
581 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
582 These were 'int' variables that could overflow on 64-bit hosts;
583 they were never used, so remove them instead of repairing them.
584 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
585 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
586 Previously, this ceilinged at INT_MAX, but that doesn't work on
588 (allocate_pseudovector): Don't use EMACS_INT when int would do.
590 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
591 (allocate_vectorlike): Check for ptrdiff_t overflow.
592 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
593 when a (possibly-narrower) signed value would do just as well.
594 We prefer using signed arithmetic, to avoid comparison confusion.
596 * alloc.c: Catch some string size overflows that we were missing.
597 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
598 for convenience in STRING_BYTES_MAX.
599 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
600 The definition here is exact; the one in lisp.h was approximate.
601 (allocate_string_data): Check for string overflow. This catches
602 some instances we weren't catching before. Also, it catches
603 size_t overflow on (unusual) hosts where SIZE_MAX <= min
604 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
605 and ptrdiff_t and EMACS_INT are both 64 bits.
607 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
608 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
609 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
611 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
613 * alloc.c (Fmake_string): Check for out-of-range init.
615 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
617 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
619 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
621 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
622 xg_get_default_scrollbar_width.
624 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
625 (int_gtk_range_get_value): Move to the scroll bar part of the file.
626 (style_changed_cb): Call update_theme_scrollbar_width and call
627 x_set_scroll_bar_default_width and xg_frame_set_char_size for
628 all frames (Bug#8505).
629 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
630 Call gtk_window_set_resizable if HAVE_GTK3.
631 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
632 and height if HAVE_GTK3 (Bug#8505).
633 (scroll_bar_width_for_theme): New variable.
634 (update_theme_scrollbar_width): New function.
635 (xg_get_default_scrollbar_width): Move code to
636 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
637 (xg_initialize): Call update_theme_scrollbar_width.
639 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
641 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
643 2011-06-12 Martin Rudalics <rudalics@gmx.at>
645 * frame.c (make_frame): Call other_buffer_safely instead of
648 * window.c (temp_output_buffer_show): Call display_buffer with
649 second argument Vtemp_buffer_show_specifiers and reset latter
650 immediately after the call.
651 (Vtemp_buffer_show_specifiers): New variable.
652 (auto_window_vscroll_p, next_screen_context_lines)
653 (Vscroll_preserve_screen_position): Remove leading asterisks from
656 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
658 Fix minor problems found by GCC 4.6.0 static checking.
659 * buffer.c (Qclone_number): Remove for now, as it's unused.
660 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
661 (record_buffer): Remove unused local.
662 * frame.c (other_visible_frames, frame_buffer_list): Now static.
663 (set_frame_buffer_list): Remove; unused.
664 * frame.h (other_visible_frames): Remove decl.
665 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
666 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
667 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
669 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
670 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
671 Define only if HAVE_GPM.
672 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
673 (update_hints_inhibit): Remove; never set. All uses removed.
674 * widgetprv.h (emacsFrameClassRec): Remove decl.
675 * window.c (delete_deletable_window): Now returns void, since it
676 wasn't returning anything.
677 (compare_window_configurations): Remove unused locals.
678 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
679 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
680 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
681 the same widths as pointers. This follows up on the 2011-05-06 patch.
682 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
684 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
686 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
688 * makefile.w32-in: Update dependencies.
689 (LISP_H): Add lib/intprops.h.
691 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
693 * image.c (gif_load): Add animation frame delay to the metadata.
694 (syms_of_image): Use DEFSYM. New symbol `delay'.
696 2011-06-11 Martin Rudalics <rudalics@gmx.at>
698 * window.c (delete_deletable_window): Re-add.
699 (Fset_window_configuration): Rewrite to handle dead buffers and
700 consequently deletable windows.
701 (window_tree, Fwindow_tree): Remove. Supply functionality in
703 (compare_window_configurations): Simplify code.
705 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
707 * image.c (imagemagick_load_image): Fix type mismatch.
708 (Fimagemagick_types): Likewise.
710 * window.h (replace_buffer_in_windows): Declare.
712 2011-06-11 Martin Rudalics <rudalics@gmx.at>
714 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
715 Qclone_number. Remove external declaration of Qdelete_window.
716 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
718 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
719 Qbuffer_list_update_hook if allowed.
720 (Fother_buffer): Rewrite doc-string. Major rewrite for new
721 buffer list implementation.
722 (other_buffer_safely): New function.
723 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
724 calls to replace_buffer_in_windows and
725 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
727 (record_buffer): Inhibit quitting and rewrite using quittable
728 functions. Run Qbuffer_list_update_hook if allowed.
729 (Frecord_buffer, Funrecord_buffer): New functions.
730 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
731 switch-to-buffer to window.el.
732 (bury-buffer): Move to window.el.
733 (Vbuffer_list_update_hook): New variable.
735 * lisp.h (other_buffer_safely): Add prototype in buffer.c
738 * window.h (resize_frame_windows): Move up in code.
739 (Fwindow_frame): Remove EXFUN.
740 (replace_buffer_in_all_windows): Remove prototype.
741 (replace_buffer_in_windows_safely): Add prototype.
743 * window.c: Declare Qdelete_window static again. Move down
744 declaration of select_count.
745 (Fnext_window, Fprevious_window): Rewrite doc-strings.
746 (Fother_window): Move to window.el.
747 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
748 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
749 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
751 (replace_buffer_in_windows): Implement by calling
752 Qreplace_buffer_in_windows.
753 (replace_buffer_in_all_windows): Remove with some functionality
754 moved into replace_buffer_in_windows_safely.
755 (replace_buffer_in_windows_safely): New function.
756 (select_window_norecord, select_frame_norecord): Move in front
757 of run_window_configuration_change_hook. Remove now obsolete
759 (Fset_window_buffer): Rewrite doc-string. Call
760 Qrecord_window_buffer.
761 (keys_of_window): Move binding for other-window to window.el.
763 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
765 * dispextern.h (struct image): Replace data member, whose int_val
766 and ptr_val fields were not used by anything, with a single
769 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
770 (gif_clear_image, gif_load, imagemagick_load_image)
771 (gs_clear_image, gs_load): Callers changed.
773 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
775 * buffer.h: Include <time.h>, for time_t.
776 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
778 Fix minor problems found by static checking.
780 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
782 Make identifiers static if they are not used in other modules.
783 * data.c (Qcompiled_function, Qframe, Qvector):
784 * image.c (QimageMagick, Qsvg):
785 * minibuf.c (Qmetadata):
786 * window.c (resize_window_check, resize_root_window): Now static.
787 * window.h (resize_window_check, resize_root_window): Remove decls.
789 * window.c (window_deletion_count, delete_deletable_window):
791 (window_body_lines): Now static.
792 (Fdelete_other_windows_internal): Mark vars as initialized.
793 Make sure 'resize_failed' is initialized.
794 (run_window_configuration_change_hook): Rename local to avoid shadowing.
795 (resize_window_apply): Remove unused local.
796 * window.h (delete_deletable_window): Remove decl.
798 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
799 (imagemagick_load_image): Fix pointer signedness problem by changing
800 last arg from unsigned char * to char *. All uses changed.
801 Also, fix a local for similar reasons.
802 Remove unused locals. Remove locals to avoid shadowing.
803 (fn_rsvg_handle_free): Remove; unused.
804 (svg_load, svg_load_image): Fix pointer signedness problem.
805 (imagemagick_load_image): Don't use garbage pointer image_wand.
807 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
809 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
811 * image.c (gif_load): Fix omitted cast error introduced by
814 2011-06-10 Martin Rudalics <rudalics@gmx.at>
816 * window.h (resize_proportionally, orig_total_lines)
817 (orig_top_line): Remove from window structure.
818 (set_window_height, set_window_width, change_window_heights)
819 (Fdelete_window): Remove prototypes.
820 (resize_frame_windows): Remove duplicate declaration.
822 2011-06-10 Eli Zaretskii <eliz@gnu.org>
824 * window.h (resize_frame_windows, resize_window_check)
825 (delete_deletable_window, resize_root_window)
826 (resize_frame_windows): Declare prototypes.
828 * window.c (resize_window_apply): Make definition be "static" to
831 2011-06-10 Martin Rudalics <rudalics@gmx.at>
833 * window.c: Remove declarations of Qwindow_size_fixed,
834 window_min_size_1, window_min_size_2, window_min_size,
835 size_window, window_fixed_size_p, enlarge_window, delete_window.
836 Remove static from declaration of Qdelete_window, it's
837 temporarily needed by Fbury_buffer.
838 (replace_window): Don't assign orig_top_line and
840 (Fdelete_window, delete_window): Remove. Window deletion is
841 handled by window.el.
842 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
843 Fdelete_window calls with calls to Qdelete_window.
844 (Fdelete_other_windows): Remove. Deleting other windows is
845 handled by window.el.
846 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
847 handled in window.el.
848 (window_min_size_2, window_min_size_1, window_min_size): Remove.
849 Window minimum sizes are handled in window.el.
850 (shrink_windows, size_window, set_window_height)
851 (set_window_width, change_window_heights, window_height)
852 (window_width, CURBEG, CURSIZE, enlarge_window)
853 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
854 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
855 handled in window.el.
856 (make_dummy_parent): Rename to make_parent_window and give it a
857 second argument horflag.
858 (make_window): Don't set resize_proportionally any more.
859 (Fsplit_window): Remove. Windows are split in window.el.
860 (save_restore_action, save_restore_orig_size)
861 (shrink_window_lowest_first, save_restore_orig_size): Remove.
862 Resize mini windows in window.el.
863 (grow_mini_window, shrink_mini_window): Implement by calling
864 Qresize_root_window_vertically, resize_window_check and
866 (saved_window, Fset_window_configuration, save_window_save): Do
867 not handle orig_top_line, orig_total_lines, and
868 resize_proportionally.
869 (window_min_height, window_min_width): Move to window.el.
870 (keys_of_window): Move bindings for delete-other-windows,
871 split-window, delete-window and enlarge-window to window.el.
873 * buffer.c: Temporarily extern Qdelete_window.
874 (Fbury_buffer): Temporarily call Qdelete_window instead of
875 Fdelete_window (Fbury_buffer will move to window.el soon).
877 * frame.c (set_menu_bar_lines_1): Remove code handling
878 orig_top_line and orig_total_lines.
880 * dispnew.c (adjust_frame_glyphs_initially): Don't use
881 set_window_height but set heights directly.
882 (change_frame_size_1): Use resize_frame_windows.
884 * xdisp.c (init_xdisp): Don't use set_window_height but set
887 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
888 resize_frame_windows instead of change_window_heights and run
889 run_window_configuration_change_hook.
891 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
892 instead of change_window_heights and run
893 run_window_configuration_change_hook.
895 2011-06-09 Martin Rudalics <rudalics@gmx.at>
897 * window.c (replace_window): Rename second argument REPLACEMENT to
898 NEW. New third argument SETFLAG. Rewrite.
899 (delete_window, make_dummy_parent): Call replace_window with
901 (window_list_1): Move down in code.
902 (run_window_configuration_change_hook): Move set_buffer part
903 before select_frame_norecord part in order to unwind correctly.
904 Rename count1 to count.
905 (recombine_windows, delete_deletable_window, resize_root_window)
906 (Fdelete_other_windows_internal)
907 (Frun_window_configuration_change_hook, make_parent_window)
908 (resize_window_check, resize_window_apply, Fresize_window_apply)
909 (resize_frame_windows, Fsplit_window_internal)
910 (Fdelete_window_internal, Fresize_mini_window_internal): New
912 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
914 2011-06-08 Martin Rudalics <rudalics@gmx.at>
916 * window.h (window): Add some new members to window structure -
917 normal_lines, normal_cols, new_total, new_normal, clone_number,
918 splits, nest, prev_buffers, next_buffers.
919 (WINDOW_TOTAL_SIZE): Move here from window.c.
920 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
922 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
924 (make_dummy_parent): Set new members of windows structure.
925 (make_window): Move down in code. Handle new members of window
927 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
928 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
929 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
930 (Fset_window_prev_buffers, Fwindow_next_buffers)
931 (Fset_window_next_buffers, Fset_window_clone_number): New
933 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
934 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
936 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
937 Argument WINDOW can be now internal window too.
938 (Fwindow_use_time): Move up in code.
939 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
941 (Fset_window_configuration, saved_window)
942 (Fcurrent_window_configuration, save_window_save): Handle new
943 members of window structure.
944 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
945 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
946 (syms_of_window): New Lisp objects Qrecord_window_buffer,
947 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
948 Qget_mru_window, Qresize_root_window,
949 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
950 Qauto_buffer_name; staticpro them.
952 2011-06-07 Martin Rudalics <rudalics@gmx.at>
954 * window.c (Fwindow_total_size, Fwindow_left_column)
955 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
956 (Fwindow_list_1): New functions.
957 (window_box_text_cols): Replace with window_body_cols.
958 (Fwindow_width, Fscroll_left, Fscroll_right): Use
959 window_body_cols instead of window_box_text_cols.
960 (delete_window, Fset_window_configuration): Call
961 delete_all_subwindows with window as argument.
962 (delete_all_subwindows): Take a window as argument and not a
964 (window_loop): Remove handling of GET_LRU_WINDOW and
966 (Fget_lru_window, Fget_largest_window): Move to window.el.
968 * window.h: Extern window_body_cols instead of
969 window_box_text_cols. delete_all_subwindows now takes a
970 Lisp_Object as argument.
972 * indent.c (compute_motion, Fcompute_motion): Use
973 window_body_cols instead of window_box_text_cols.
975 * frame.c (delete_frame): Call delete_all_subwindows with root
978 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
980 * fns.c (Fputhash): Document return value.
982 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
984 * image.c (gif_load): Implement gif89a spec "no disposal" method.
986 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
988 Cons<->int and similar integer overflow fixes (Bug#8794).
990 Check for overflow when converting integer to cons and back.
991 * charset.c (Fdefine_charset_internal, Fdecode_char):
992 Use cons_to_unsigned to catch overflow.
993 (Fencode_char): Use INTEGER_TO_CONS.
994 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
995 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
996 * data.c (long_to_cons, cons_to_long): Remove.
997 (cons_to_unsigned, cons_to_signed): New functions.
998 These signal an error for invalid or out-of-range values.
999 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1000 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1001 * font.c (Ffont_variation_glyphs):
1002 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1003 * lisp.h: Include <intprops.h>.
1004 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1005 (cons_to_signed, cons_to_unsigned): New decls.
1006 (long_to_cons, cons_to_long): Remove decls.
1007 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1008 (Fprimitive_undo): Use CONS_TO_INTEGER.
1009 * xfns.c (Fx_window_property): Likewise.
1010 * xselect.c: Include <limits.h>.
1011 (x_own_selection, selection_data_to_lisp_data):
1012 Use INTEGER_TO_CONS.
1013 (x_handle_selection_request, x_handle_selection_clear)
1014 (x_get_foreign_selection, Fx_disown_selection_internal)
1015 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1016 (lisp_data_to_selection_data): Use cons_to_unsigned.
1017 (x_fill_property_data): Use cons_to_signed.
1018 Report values out of range.
1020 Check for buffer and string overflow more precisely.
1021 * buffer.h (BUF_BYTES_MAX): New macro.
1022 * lisp.h (STRING_BYTES_MAX): New macro.
1023 * alloc.c (Fmake_string):
1024 * character.c (string_escape_byte8):
1025 * coding.c (coding_alloc_by_realloc):
1026 * doprnt.c (doprnt):
1027 * editfns.c (Fformat):
1029 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1030 since they may not be the same number.
1031 * editfns.c (Finsert_char):
1032 * fileio.c (Finsert_file_contents):
1033 Likewise for BUF_BYTES_MAX.
1035 * image.c: Use ptrdiff_t, not int, for sizes.
1036 (slurp_file): Switch from int to ptrdiff_t.
1038 (slurp_file): Check that file size fits in both size_t (for
1039 malloc) and ptrdiff_t (for sanity and safety).
1041 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1042 if b->modtime has its maximal value.
1044 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1046 Don't assume time_t can fit into int.
1047 * buffer.h (struct buffer.modtime): Now time_t, not int.
1048 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1049 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1051 Minor fixes for signed vs unsigned integers.
1052 * character.h (MAYBE_UNIFY_CHAR):
1053 * charset.c (maybe_unify_char):
1054 * keyboard.c (read_char, reorder_modifiers):
1055 XINT -> XFASTINT, since the integer must be nonnegative.
1056 * ftfont.c (ftfont_spec_pattern):
1057 * keymap.c (access_keymap, silly_event_symbol_error):
1058 XUINT -> XFASTINT, since the integer must be nonnegative.
1059 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1060 since it makes no difference and we prefer signed.
1061 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1062 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1065 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1067 * window.h (Fwindow_frame): Declare.
1069 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1071 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1072 (SPARE_MEMORY): Always define.
1073 (LARGE_REQUEST): Remove.
1074 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1076 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1078 * lisp.h: Move EXFUNS for Fframe_root_window,
1079 Fframe_first_window and Fset_frame_selected_window to window.h.
1081 * window.h: Move EXFUNS for Fframe_root_window,
1082 Fframe_first_window and Fset_frame_selected_window here from
1085 * frame.c (Fwindow_frame, Fframe_first_window)
1086 (Fframe_root_window, Fframe_selected_window)
1087 (Fset_frame_selected_window): Move to window.c.
1088 (Factive_minibuffer_window): Move to minibuf.c.
1089 (Fother_visible_frames_p): New function.
1091 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1093 * window.c (decode_window, decode_any_window): Move up in code.
1094 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1095 (inhibit_frame_unsplittable): Remove unused variable.
1096 (Fwindow_buffer): Move up and rewrite doc-string.
1097 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1098 (Fwindow_prev): New functions.
1099 (Fwindow_frame): Move here from frame.c. Accept any window as
1101 (Fframe_root_window, Fframe_first_window)
1102 (Fframe_selected_window): Move here from frame.c. Accept frame
1103 or arbitrary window as argument. Update doc-strings.
1104 (Fminibuffer_window): Move up in code.
1105 (Fwindow_minibuffer_p): Move up in code and simplify.
1106 (Fset_frame_selected_window): Move here from frame.c.
1108 (Fselected_window, select_window, Fselect_window): Move up in
1109 code. Minor doc-string fixes.
1111 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1113 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1114 Do not assume that spare memory exists; that assumption is valid
1115 only if SYSTEM_MALLOC.
1116 (LARGE_REQUEST): New macro, so that the issue of large requests
1117 is separated from the issue of spare memory.
1119 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1121 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1124 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1126 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1129 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1131 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1133 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1135 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1136 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1138 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1140 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1142 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1144 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1145 (x_clipboard_manager_save): Add return value.
1146 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1148 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1149 Obey Vx_select_enable_clipboard_manager. Catch errors in
1150 x_clipboard_manager_save (Bug#8779).
1151 (Vx_select_enable_clipboard_manager): New variable.
1152 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1154 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1156 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1158 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1160 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1161 in the current matrix if keep_current_p is non-zero.
1163 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1165 * bidi.c (bidi_level_of_next_char): Fix last change.
1167 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1169 Support bidi reordering of text covered by display properties.
1171 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1172 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1173 (bidi_cache_search, bidi_cache_iterator_state)
1174 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1175 (bidi_level_of_next_char, bidi_move_to_visually_next):
1176 Support character positions inside a run of characters covered by a
1178 (bidi_paragraph_init, bidi_resolve_explicit_1)
1179 (bidi_level_of_next_char): Call bidi_fetch_char and
1180 bidi_fetch_char_advance instead of FETCH_CHAR and
1182 (bidi_init_it): Initialize new members.
1183 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1185 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1186 instead of using explicit *_CHAR codes.
1187 (bidi_resolve_explicit, bidi_resolve_weak):
1188 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1189 bidirectional text is supported only in multibyte buffers.
1190 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1191 it to initialize the frame_window_p member of struct bidi_it.
1192 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1193 (bidi_resolve_explicit, bidi_resolve_weak)
1194 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1195 bidi_it->nchars is non-positive.
1196 (bidi_level_of_next_char): Don't try to lookup the cache for the
1197 next/previous character if nothing is cached there yet, or if we
1198 were just reseat()'ed to a new position.
1200 * xdisp.c (set_cursor_from_row): Set start and stop points
1201 according to the row's direction when priming the loop that looks
1202 for the glyph on which to display cursor.
1203 (single_display_spec_intangible_p): Function deleted.
1204 (display_prop_intangible_p): Reimplement to call
1205 handle_display_spec instead of single_display_spec_intangible_p.
1206 Accept 3 additional arguments needed by handle_display_spec.
1207 This fixes incorrect cursor motion across display property with complex
1208 values: lists, `(when COND...)' forms, etc.
1209 (single_display_spec_string_p): Support property values that are
1210 lists with the argument STRING its top-level element.
1211 (display_prop_string_p): Fix the condition for processing a
1212 property that is a list to be consistent with handle_display_spec.
1213 (handle_display_spec): New function, refactored from the
1214 last portion of handle_display_prop.
1215 (compute_display_string_pos): Accept additional argument
1216 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1217 value of a `display' property is a "replacing spec".
1218 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1219 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1220 the display property, but just return a value indicating whether
1221 the display property will replace the characters it covers.
1222 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1223 frame_window_p members of struct bidi_it.
1224 (compute_display_string_pos, compute_display_string_end):
1226 (push_it): Accept second argument POSITION, where pop_it should
1227 jump to continue iteration.
1228 (reseat_1): Initialize bidi_it.disp_pos.
1230 * keyboard.c (adjust_point_for_property): Adjust the call to
1231 display_prop_intangible_p to its new signature.
1233 * dispextern.h (struct bidi_it): New member frame_window_p.
1234 (bidi_init_it): Update prototypes.
1235 (display_prop_intangible_p): Update prototype.
1236 (compute_display_string_pos, compute_display_string_end):
1238 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1241 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1243 Malloc failure behavior now depends on size of allocation.
1244 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1245 * lisp.h: Change signatures accordingly.
1246 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1247 All callers changed. (Bug#8762)
1249 * gnutls.c: Use Emacs's memory allocators.
1250 Without this change, the gnutls library would invoke malloc etc.
1251 directly, which causes problems on non-SYNC_INPUT hosts, and which
1252 runs afoul of improving memory_full behavior. (Bug#8761)
1253 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1254 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1255 xfree instead of the default malloc, realloc, free.
1256 (Fgnutls_boot): No need to check for memory allocation failure,
1257 since xmalloc does that for us.
1259 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1260 * category.c (hash_get_category_set):
1261 * ccl.c (ccl_driver):
1262 * charset.c (Fdefine_charset_internal):
1263 * charset.h (struct charset.hash_index):
1264 * composite.c (get_composition_id, gstring_lookup_cache)
1265 (composition_gstring_put_cache):
1266 * composite.h (struct composition.hash_index):
1267 * dispextern.h (struct image.hash):
1268 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1269 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1270 (hashfn_equal, hashfn_user_defined, make_hash_table)
1271 (maybe_resize_hash_table, hash_lookup, hash_put)
1272 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1273 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1274 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1275 * image.c (make_image, search_image_cache, lookup_image)
1276 (xpm_put_color_table_h):
1277 * lisp.h (struct Lisp_Hash_Table):
1278 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1279 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1280 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1281 * alloc.c (allocate_vectorlike):
1282 Check for overflow in vector size calculations.
1283 * ccl.c (ccl_driver):
1284 Check for overflow when converting EMACS_INT to int.
1285 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1286 need to be updated by these changes.
1287 * fns.c (make_hash_table, maybe_resize_hash_table):
1288 Check for integer overflow with large hash tables.
1289 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1290 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1291 (SXHASH_REDUCE): New macro.
1292 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1293 Use it instead of discarding useful hash info with large hash values.
1294 (sxhash_float): New function.
1295 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1296 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1297 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1298 Rewrite to use FIXNUM_BITS, as this simplifies things.
1299 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1300 Adjust signatures to match updated version of code.
1301 (consing_since_gc): Now EMACS_INT, since a single hash table can
1302 use more than INT_MAX bytes.
1304 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1306 Make it possible to build with GCC-4.6+ -O2 -flto.
1308 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1310 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1312 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1313 Call minibuffer-inactive-mode.
1315 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1317 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1318 Update dependencies.
1320 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1322 * data.c (init_data): Remove code for UTS, this system is not
1325 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1327 Don't force ./temacs to start in terminal mode.
1329 * frame.c (make_initial_frame): Initialize faces in all cases, not
1330 only when CANNOT_DUMP is defined.
1331 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1333 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1335 * dispnew.c (add_window_display_history): Use const for the string
1336 pointer. Remove declaration, not needed.
1338 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1340 Use 'inline', not 'INLINE'.
1341 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1342 * alloc.c, fontset.c (INLINE): Remove.
1343 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1344 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1345 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1346 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1347 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1349 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1351 Make it possible to run ./temacs.
1353 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1354 syms_of_callproc does the same thing. Remove test for
1355 "initialized", do it in the caller.
1356 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1358 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1360 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1361 (read_minibuf): Use get_minibuffer.
1362 (syms_of_minibuf): Use DEFSYM.
1363 (Qmetadata): New var.
1364 * data.c (Qbuffer): Don't make it static.
1365 (syms_of_data): Use DEFSYM.
1367 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1369 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1370 (CCL_CODE_MIN): New macro.
1372 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1374 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1376 * eval.c (Qdebug): Now static.
1377 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1378 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1379 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1381 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1383 * image.c: Various fixes to ImageMagick code comments.
1384 (Fimagemagick_types): Doc fix.
1386 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1388 Minor fixes prompted by GCC 4.6.0 warnings.
1390 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1392 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1393 (x_clipboard_manager_save_all): Move extern decl to ...
1394 * xterm.h: ... here, so that it can be checked for consistency.
1396 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1398 * xselect.c (x_clipboard_manager_save_frame)
1399 (x_clipboard_manager_save_all): New functions.
1400 (Fx_clipboard_manager_save): Lisp function deleted.
1402 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1403 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1405 * xterm.h: Update prototype.
1407 2011-05-28 William Xu <william.xwl@gmail.com>
1409 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1412 2011-05-28 Jim Meyering <meyering@redhat.com>
1414 Avoid a sign-extension bug in crypto_hash_function.
1415 * fns.c (to_uchar): Define.
1416 (crypto_hash_function): Use it to convert some newly-signed
1417 variables to unsigned, to avoid sign-extension bugs. For example,
1418 without this change, (md5 "truc") would evaluate to
1419 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1420 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1421 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1423 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1425 Integer overflow fixes.
1427 * dbusbind.c: Serial number integer overflow fixes.
1428 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1429 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1430 to hold a serial number that is too large for a fixnum.
1431 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1432 Check for serial numbers out of range. Decode any serial number
1433 that was so large that it became a float. (Bug#8722)
1435 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1436 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1437 Use XFASTINT rather than XUINT when numbers are nonnegative.
1438 (xd_append_arg, Fdbus_method_return_internal):
1439 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1440 arguments, check that Lisp number is nonnegative, rather than
1441 silently wrapping negative numbers around. (Bug#8722)
1442 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1445 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1447 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1449 ccl: add integer overflow checks
1450 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1451 (IN_INT_RANGE): New macros.
1452 (ccl_driver): Use them to check for integer overflow when
1453 decoding a CCL program. Many of the new checks are whether XINT (x)
1454 fits in int; it doesn't always, on 64-bit hosts. The new version
1455 doesn't catch all possible integer overflows, but it's an
1456 improvement. (Bug#8719)
1458 * alloc.c (make_event_array): Use XINT, not XUINT.
1459 There's no need for unsigned here.
1461 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1462 This follows up to the 2011-05-06 change that substituted uintptr_t
1463 for EMACS_INT. This case wasn't caught back then.
1465 Rework Fformat to avoid integer overflow issues.
1466 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1467 now (part of C89). Include <verify.h>.
1468 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1469 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1470 (Fformat): Avoid the prepass trying to compute sizes; it was only
1471 approximate and thus did not catch overflow reliably. Instead, walk
1472 through the format just once, formatting and computing sizes as we go,
1473 checking for integer overflow at every step, and allocating a larger
1474 buffer as needed. Keep track separately whether the format is
1475 multibyte. Keep only the most-recently calculated precision, rather
1476 than them all. Record whether each argument has been converted to
1477 string. Use EMACS_INT, not int, for byte and char and arg counts.
1478 Support field widths and precisions larger than INT_MAX. Avoid
1479 sprintf's undefined behavior with conversion specifications such as %#d
1480 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1481 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1482 formatting out-of-range floating point numbers with int
1485 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1487 * data.c: Avoid integer truncation in expressions involving floats.
1488 * data.c: Include <intprops.h>.
1489 (arith_driver): When there's an integer overflow in an expression
1490 involving floating point, convert the integers to floating point
1491 so that the resulting value does not suffer from catastrophic
1492 integer truncation. For example, on a 64-bit host (* 4
1493 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1494 Do not rely on undefined behavior after integer overflow.
1496 merge count_size_as_multibyte, parse_str_to_multibyte
1497 * character.c, character.h (count_size_as_multibyte):
1498 Rename from parse_str_to_multibyte; all uses changed.
1499 Check for integer overflow.
1500 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1501 since it's now a duplicate of the other. This is more of
1502 a character than a buffer op, so better that it's in character.c.
1503 * fns.c, print.c: Adjust to above changes.
1505 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1507 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1509 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1511 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1512 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1513 (x_clipboard_manager_save): Now static.
1514 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1516 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1517 (crypto_hash_function): Now static.
1518 Fix pointer signedness problems. Avoid unnecessary initializations.
1520 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1522 * termhooks.h (Vselection_alist): Make it terminal-local.
1524 * terminal.c (create_terminal): Initialize it.
1526 * xselect.c: Support for clipboard managers.
1527 (Vselection_alist): Move to termhooks.h as terminal-local var.
1528 (LOCAL_SELECTION): New macro.
1529 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1530 (symbol_to_x_atom): Remove gratuitous arg.
1531 (x_handle_selection_request, lisp_data_to_selection_data)
1532 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1533 (x_own_selection, x_get_local_selection, x_convert_selection):
1534 New arg, specifying work frame. Use terminal-local Vselection_alist.
1535 (some_frame_on_display): Delete unused function.
1536 (Fx_own_selection_internal, Fx_get_selection_internal)
1537 (Fx_disown_selection_internal, Fx_selection_owner_p)
1538 (Fx_selection_exists_p): New optional frame arg.
1539 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1540 (x_handle_selection_clear): Don't treat other terminals with the
1541 same keyboard specially. Use the terminal-local Vselection_alist.
1542 (x_clear_frame_selections): Use Frun_hook_with_args.
1544 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1546 * xterm.h: Add support for those atoms.
1548 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1550 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1551 (converted_selections, conversion_fail_tag): New global variables.
1552 (x_selection_request_lisp_error): Free the above.
1553 (x_get_local_selection): Remove unnecessary code.
1554 (x_reply_selection_request): Args changed; handle arbitrary array
1555 of converted selections stored in converted_selections.
1556 Separate the XChangeProperty and SelectionNotify steps.
1557 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1558 (x_convert_selection): New function.
1559 (x_handle_selection_event): Simplify.
1560 (x_get_foreign_selection): Don't ignore incoming requests while
1561 waiting for an answer; this will fail when we implement
1562 SAVE_TARGETS, and seems unnecessary anyway.
1563 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1564 (Vx_sent_selection_functions): Doc fix.
1566 2011-05-26 Leo Liu <sdl.web@gmail.com>
1568 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1570 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1572 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1574 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1575 for fringe update if it has periodic bitmap.
1576 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1577 and fringe_bitmap_periodic_p.
1579 * fringe.c (get_fringe_bitmap_data): New function.
1580 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1581 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1582 row. Mark glyph row for fringe update if periodicity changed.
1584 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1585 for fringe update unless it has periodic bitmap.
1587 2011-05-25 Kenichi Handa <handa@m17n.org>
1589 * xdisp.c (get_next_display_element): Set correct it->face_id for
1590 a static composition.
1592 2011-05-24 Leo Liu <sdl.web@gmail.com>
1595 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1597 * fns.c (crypto_hash_function, Fsha1): New function.
1598 (Fmd5): Use crypto_hash_function.
1599 (syms_of_fns): Add Ssha1.
1601 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1603 * gnutls.c: Remove unused macros.
1604 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1605 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1606 Remove macros that are defined and never used.
1607 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1609 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1611 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1612 (Fx_get_selection_internal): Minor cleanup.
1613 (Fx_own_selection_internal): Rename arguments for consistency with
1616 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1618 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1620 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1622 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1624 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1626 * dispnew.c (scrolling_window): Don't exclude the case that the
1627 last enabled row in the desired matrix touches the bottom boundary.
1629 2011-05-21 Glenn Morris <rgm@gnu.org>
1631 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1632 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1633 and add some more files.
1635 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1637 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1638 report_file_error introduced by the change from 2011-05-07.
1640 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1642 * systime.h (Time): Define only if emacs is defined.
1643 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1644 where the include path doesn't have X11/X.h by default. See
1645 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1647 2011-05-20 Kenichi Handa <handa@m17n.org>
1649 * composite.c (find_automatic_composition): Fix previous change.
1651 2011-05-20 Glenn Morris <rgm@gnu.org>
1653 * lisp.mk: New file, split from Makefile.in.
1654 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1655 (shortlisp): Remove.
1656 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1658 2011-05-19 Glenn Morris <rgm@gnu.org>
1660 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1661 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1662 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1663 (lisp): Set the order to that of loadup.el.
1664 (shortlisp): Make it a copy of $lisp.
1665 (SOME_MACHINE_LISP): Remove.
1666 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1667 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1669 2011-05-18 Kenichi Handa <handa@m17n.org>
1671 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1672 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1673 (find_automatic_composition): Mostly rewrite for efficiency.
1675 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1677 * makefile.w32-in: Update dependencies.
1679 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1681 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1682 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1684 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1686 Fix some integer overflow issues, such as string length overflow.
1688 * insdel.c (count_size_as_multibyte): Check for string overflow.
1690 * character.c (lisp_string_width): Check for string overflow.
1691 Use EMACS_INT, not int, for string indexes and lengths; in
1692 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1693 the resulting string length overflows an EMACS_INT; instead,
1694 report a string overflow if no precision given. When checking for
1695 precision exhaustion, use a check that cannot possibly have
1696 integer overflow. (Bug#8675)
1697 * character.h (lisp_string_width): Adjust to new signature.
1699 * alloc.c (string_overflow): New function.
1700 (Fmake_string): Use it. This doesn't change behavior, but saves
1701 a few bytes and will simplify future changes.
1702 * character.c (string_escape_byte8): Likewise.
1703 * lisp.h (string_overflow): New decl.
1705 Fixups, following up to the user-interface timestamp change.
1706 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1707 for UI timestamps, instead of unsigned long.
1708 * msdos.c (mouse_get_pos): Likewise.
1709 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1710 * w32gui.h (Time): Define by including "systime.h" rather than by
1711 declaring it ourselves. (Bug#8664)
1713 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1714 * image.c (clear_image_cache): Likewise.
1716 * term.c (term_mouse_position): Don't assume time_t wraparound.
1718 Be more systematic about user-interface timestamps.
1719 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1720 and sometimes 'EMACS_UINT', to represent these timestamps.
1721 This change causes it to use 'Time' uniformly, as that's what X uses.
1722 This makes the code easier to follow, and makes it easier to catch
1723 integer overflow bugs such as Bug#8664.
1724 * frame.c (Fmouse_position, Fmouse_pixel_position):
1725 Use Time, not unsigned long, for user-interface timestamps.
1726 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1727 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1728 * keyboard.h (last_event_timestamp): Likewise.
1729 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1730 * menu.h (xmenu_show): Likewise.
1731 * term.c (term_mouse_position): Likewise.
1732 * termhooks.h (struct input_event.timestamp): Likewise.
1733 (struct terminal.mouse_position_hook): Likewise.
1734 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1735 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1736 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1737 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1739 * menu.h, termhooks.h: Include "systime.h", for Time.
1741 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1742 Don't assume that the difference between two unsigned long values
1743 can fit into an integer. At this point, we know button_down_time
1744 <= event->timestamp, so the difference must be nonnegative, so
1745 there's no need to cast the result if double-click-time is
1746 nonnegative, as it should be; check that it's nonnegative, just in
1747 case. This bug is triggered when events are more than 2**31 ms
1748 apart (about 25 days). (Bug#8664)
1750 * xselect.c (last_event_timestamp): Remove duplicate decl.
1751 (x_own_selection): Remove needless cast to unsigned long.
1753 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1754 that always fit in int. Use a sentinel instead of a counter, to
1755 avoid a temp and to allay GCC's concerns about possible int overflow.
1756 * frame.h (struct frame): Use int for menu_bar_items_used
1757 instead of EMACS_INT, since it always fits in int.
1759 * menu.c (grow_menu_items): Check for int overflow.
1761 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1763 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1764 Before, the code was not consistent. These values cannot exceed
1765 2**31 - 1 so there's no need to make them unsigned.
1766 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1767 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1768 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1770 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1772 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1773 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1774 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1775 presumably because the widths might not match.
1777 * window.c (size_window): Avoid needless test at loop start.
1779 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1781 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1783 2011-05-12 Drew Adams <drew.adams@oracle.com>
1785 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1787 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1789 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1790 `width' to `bar_area_x' and `bar_area_width', respectively.
1791 (x_scroll_run): Take account of fringe background extension.
1793 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1794 Rename local vars `left' and `width' to `bar_area_x' and
1795 `bar_area_width', respectively.
1796 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1797 background extension.
1799 2011-05-10 Jim Meyering <meyering@redhat.com>
1801 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1803 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1805 * image.c (Finit_image_library): Return t for built-in image types,
1806 like pbm and xbm. (Bug#8640)
1808 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1810 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1812 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1814 * w32console.c (Fset_screen_color): Doc fix.
1815 (Fget_screen_color): New function.
1816 (syms_of_ntterm): Defsubr it.
1818 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1819 unlink the temporary file if Fcall_process didn't create it in the
1821 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1822 child process will be redirected to a file specified with `:file'.
1823 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1824 cue to call_process_cleanup not to close that handle.
1826 2011-05-07 Ben Key <bkey76@gmail.com>
1828 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1829 one of two shell specific rules, either bootstrap-temacs-CMD or
1830 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1831 to the previous implementation of the bootstrap-temacs rule.
1832 The bootstrap-temacs-CMD rule is similar to the previous
1833 implementation of the bootstrap-temacs rule except that it
1834 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1837 These changes, along with some changes to nt/configure.bat,
1838 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1839 earlier fix to add support for --cflags and --ldflags options
1840 that include quotes so that it works whether make uses cmd or
1843 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1845 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1846 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1848 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1849 a string. Handle both cases.
1850 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1851 (Fdbus_register_method): Use Qinvalid_function.
1853 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1855 * makefile.w32-in: Update dependencies.
1856 (LISP_H): Add inttypes.h and stdin.h.
1857 (PROCESS_H): Add unistd.h.
1859 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1861 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1862 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1864 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1866 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1868 * term.c (vfatal): Remove stray call to va_end.
1869 It's not needed and the C Standard doesn't allow it here anyway.
1871 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1872 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1874 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1877 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1879 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1881 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1883 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1885 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1887 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1888 * charset.c (Fdefine_charset_internal): Don't initialize
1889 charset.code_space[15]. The value was garbage, on hosts with
1890 32-bit int (Bug#8600).
1892 * lread.c (read_integer): Be more consistent with string-to-number.
1893 Use string_to_number to do the actual conversion; this avoids
1894 rounding errors and fixes some other screwups. Without this fix,
1895 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1896 (digit_to_number): Move earlier, for benefit of read_integer.
1897 Return -1 if the digit is out of range for the base, -2 if it is
1898 not a digit in any supported base. (Bug#8602)
1900 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1902 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1903 to match comment at start of function. This also removes a
1904 GCC warning about overflow in a 32+64-bit port.
1906 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1908 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1909 Reported by Stefan Monnier in
1910 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1911 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1912 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1914 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1915 (EMACS_UINTPTR): Likewise, with uintptr_t.
1917 * lisp.h: Prefer 64-bit EMACS_INT if available.
1918 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1919 on 32-bit hosts that have 64-bit int, so that they can access
1921 However, temporarily disable this change unless the temporary
1922 symbol WIDE_EMACS_INT is defined.
1924 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1926 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1927 This removes an assumption that EMACS_INT and long are the same
1928 width as pointers. The assumption is true for Emacs porting targets
1929 now, but we want to make other targets possible.
1930 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1931 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1932 In the rest of the code, change types of integers that hold casted
1933 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1934 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1935 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1936 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1937 No need to cast type when ORing.
1938 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1939 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1940 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1941 assume EMACS_INT is the same width as char *.
1942 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1943 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1944 Remove no-longer-needed casts.
1945 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1946 (xg_tool_bar_help_callback, xg_make_tool_item):
1947 Use EMACS_INTPTR to hold an integer
1948 that will be cast to void *; this can avoid a GCC warning
1949 if EMACS_INT is not the same width as void *.
1950 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1951 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1952 (current_message_1, set_message_1):
1953 Use a local to convert to proper width without a cast.
1954 * xmenu.c (dialog_selection_callback): Likewise.
1956 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1957 Also, don't assume VALBITS / RAND_BITS is less than 5,
1958 and don't rely on undefined behavior when shifting a 1 left into
1960 * lisp.h (get_random): Change signature to match.
1962 * lread.c (hash_string): Use size_t, not int, for hash computation.
1963 Normally we prefer signed values; but hashing is special, because
1964 it's better to use unsigned division on hash table sizes so that
1965 the remainder is nonnegative. Also, size_t is the natural width
1966 for hashing into memory. The previous code used 'int', which doesn't
1967 retain enough info to hash well into very large tables.
1968 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1970 * dbusbind.c: Don't possibly lose pointer info when converting.
1971 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1972 Use XPNTR rather than XHASH, so that the high-order bits of
1973 the pointer aren't lost when converting through void *.
1975 * eval.c (Fautoload): Don't double-shift a pointer.
1977 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1979 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1981 * gnutls.c (DEF_GNUTLS_FN):
1982 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1984 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1986 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1989 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1991 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1992 New version that can reserve upto 2GB of heap space.
1994 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1996 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1998 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2000 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2001 `gnutls_certificate_set_x509_key_file'.
2003 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2005 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2006 Update dependencies.
2008 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2010 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2011 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2012 Remove unused parameter `fildes'.
2013 * process.c (read_process_output, send_process): Don't pass it.
2015 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2017 Fix previous change: the library cache is defined in w32.c.
2018 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2019 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2021 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2023 Implement dynamic loading of GnuTLS on Windows.
2025 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2026 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2027 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2030 * gnutls.c (Qgnutls_dll): Define.
2031 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2032 (gnutls_*): Declare function pointers.
2033 (init_gnutls_functions): New function to initialize function pointers.
2034 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2035 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2036 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2037 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2038 (emacs_gnutls_write, emacs_gnutls_read)
2039 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2040 (Fgnutls_available_p): New function.
2041 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2042 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2043 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2045 * image.c: Include w32.h.
2046 (Vimage_type_cache): Delete.
2047 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2048 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2049 (w32_delayed_load): Move to w32.c.
2051 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2053 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2054 (w32_delayed_load): Move from image.c. When loading a library, record
2055 its filename in the :loaded-from property of the library id.
2056 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2057 Initialize and staticpro them.
2058 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2060 * process.c: Include lisp.h before w32.h, not after.
2061 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2062 instead of gnutls_record_check_pending.
2064 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2066 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2068 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2069 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2072 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2074 * xterm.c (x_set_frame_alpha): Do not set property on anything
2075 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2077 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2079 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2081 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2083 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2084 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2085 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2086 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2087 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2088 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2089 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2090 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2091 (Qgnutls_bootprop_callbacks_verify): Make static.
2093 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2095 * callproc.c: Indentation fixup.
2097 * sysdep.c (wait_for_termination_1): Make static.
2098 (wait_for_termination, interruptible_wait_for_termination):
2099 Move after wait_for_termination_1.
2101 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2103 * sysdep.c (interruptible_wait_for_termination): New function
2104 which is like wait_for_termination, but allows keyboard
2107 * callproc.c (Fcall_process): Add (:file "file") as an option for
2109 (Fcall_process_region): Ditto.
2111 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2113 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2114 rather than `XVECTOR (FOO)->size'.
2116 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2117 inttypes.h, as a gnulib replacement is used if it not available in
2120 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2122 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2123 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2124 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2126 * coding.c (coding_alloc_by_realloc): Error out if destination
2127 will grow beyond MOST_POSITIVE_FIXNUM.
2128 (decode_coding_emacs_mule): Abort if there isn't enough place in
2129 charbuf for the composition carryover bytes. Reserve an extra
2130 space for up to 2 characters produced in a loop.
2131 (decode_coding_iso_2022): Abort if there isn't enough place in
2132 charbuf for the composition carryover bytes.
2134 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2136 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2137 aborting when %lld or %lll format is passed.
2138 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2139 %llo or %llx format is passed. (Bug#8545)
2141 * window.c (window_scroll_line_based): Use a marker instead of
2142 simple variables to record original value of point. (Bug#7952)
2144 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2145 produced by %s or %c overflows available buffer space. (Bug#8545)
2147 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2149 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2150 (SIZE_MAX): Move defn after all includes, as they might #define it.
2152 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2154 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2156 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2158 * keyboard.c (Qdelayed_warnings_hook): Define.
2159 (command_loop_1): Run `delayed-warnings-hook'
2160 if Vdelayed_warnings_list is non-nil.
2161 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2162 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2164 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2166 * doprnt.c (doprnt): Don't return value smaller than the buffer
2167 size if the message was truncated. (Bug#8545).
2169 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2171 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2172 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2174 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2176 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2178 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2180 * makefile.w32-in: Update dependencies.
2182 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2184 Improve `doprnt' and its usage. (Bug#8545)
2185 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2186 `format_end'. Remove support for %l as a conversion specifier.
2187 Don't use xrealloc. Improve diagnostics when the %l size modifier
2188 is used. Update the commentary.
2190 * eval.c (verror): Simplify calculation of size_t.
2192 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2195 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2197 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2200 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2202 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2203 This makes this file independent of the recent pseudovector change.
2205 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2207 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2209 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2210 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2211 Remove unused local.
2212 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2214 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2215 GCC 4.6.0 optimizes based on type-based alias analysis.
2216 For example, if b is of type struct buffer * and v of type struct
2217 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2218 != &v->size, and therefore "v->size = 1; b->size = 2; return
2219 v->size;" must therefore return 1. This assumption is incorrect
2220 for Emacs, since it type-puns struct Lisp_Vector * with many other
2221 types. To fix this problem, this patch adds a new type struct
2222 vectorlike_header that documents the constraints on layout of vectors
2223 and pseudovectors, and helps optimizing compilers not get fooled
2224 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2225 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2226 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2228 (XSETPVECTYPE): Rewrite in terms of new macro.
2229 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2230 This is a bit clearer, and further avoids the possibility of
2231 undesirable aliasing.
2232 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2233 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2234 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2235 since Lisp_Subr is a special case (no "next" field).
2236 (ASIZE): Now uses header.size rather than size.
2237 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2238 to avoid the hassle of writing XVECTOR (foo)->header.size.
2239 (struct vectorlike_header): New type.
2240 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2241 object, to help avoid aliasing.
2242 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2243 (SUBRP): Likewise, since Lisp_Subr is a special case.
2244 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2245 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2246 (struct Lisp_Hash_Table): Combine first two members into a single
2247 struct vectorlike_header member. All uses of "size" and "next" members
2248 changed to be "header.size" and "header.next".
2249 * buffer.h (struct buffer): Likewise.
2250 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2251 * frame.h (struct frame): Likewise.
2252 * process.h (struct Lisp_Process): Likewise.
2253 * termhooks.h (struct terminal): Likewise.
2254 * window.c (struct save_window_data, struct saved_window): Likewise.
2255 * window.h (struct window): Likewise.
2256 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2257 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2258 * buffer.c (init_buffer_once): Likewise.
2259 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2261 * process.c (Fformat_network_address): Use local var for size,
2264 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2266 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2267 * data.c (atof): Remove decl; no longer used or needed.
2268 (digit_to_number): Move to lread.c.
2269 (Fstring_to_number): Use new string_to_number function, to be
2270 consistent with how the Lisp reader treats infinities and NaNs.
2271 Do not assume that floating-point numbers represent EMACS_INT
2272 without losing information; this is not true on most 64-bit hosts.
2273 Avoid double-rounding errors, by insisting on integers when
2274 parsing non-base-10 numbers, as the documentation specifies.
2275 * lisp.h (string_to_number): New decl, replacing ...
2276 (isfloat_string): Remove.
2277 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2278 (read1): Do not accept +. and -. as integers; this
2279 appears to have been a coding error. Similarly, do not accept
2280 strings like +-1e0 as floating point numbers. Do not report
2281 overflow for integer overflows unless the base is not 10 which
2282 means we have no simple and reliable way to continue.
2283 Break out the floating-point parsing into a new
2284 function string_to_number, so that Fstring_to_number parses
2285 floating point numbers consistently with the Lisp reader.
2286 (digit_to_number): Move here from data.c. Make it static inline.
2287 (E_CHAR, EXP_INT): Remove, replacing with ...
2288 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2289 (string_to_number): New function, replacing isfloat_string.
2290 This function checks for valid syntax and produces the resulting
2291 Lisp float number too. Rework it so that string-to-number
2292 no longer mishandles examples like "1.0e+". Use strtoumax,
2293 so that overflow for non-base-10 numbers is reported only when
2294 there's no portable and simple way to convert to floating point.
2296 * textprop.c (set_text_properties_1): Rewrite for clarity,
2297 and to avoid GCC warning about integer overflow.
2299 * intervals.h (struct interval): Use EMACS_INT for members
2300 where EMACS_UINT might cause problems. See
2301 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2302 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2303 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2305 (offset_intervals): Tell GCC not to worry about length overflow
2306 when negating a negative length.
2308 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2309 (overrun_check_free): Likewise.
2311 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2312 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2315 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2316 (gnutls_make_error): Rename local to avoid shadowing.
2317 (gnutls_emacs_global_deinit): ifdef out; not used.
2318 (Fgnutls_boot): Use const for pointer to readonly storage.
2319 Comment out unused local. Fix pointer signedness problems.
2321 * lread.c (openp): Don't stuff size_t into an 'int'.
2322 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2323 about possible signed overflow.
2325 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2326 (GDK_KEY_g): Don't define if already defined.
2327 (xg_prepare_tooltip): Avoid pointer signedness problem.
2328 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2330 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2331 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2333 * xfns.c (Fx_window_property): Simplify a bit,
2334 to make a bit faster and to avoid GCC 4.6.0 warning.
2335 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2337 * fns.c (internal_equal): Don't assume size_t fits in int.
2339 * alloc.c (compact_small_strings): Tighten assertion a little.
2341 Replace pEd with more-general pI, and fix some printf arg casts.
2342 * lisp.h (pI): New macro, generalizing old pEd macro to other
2343 conversion specifiers. For example, use "...%"pI"d..." rather
2344 than "...%"pEd"...".
2345 (pEd): Remove. All uses replaced with similar uses of pI.
2346 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2347 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2348 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2349 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2350 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2351 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2352 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2354 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2355 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2356 * print.c (safe_debug_print, print_object): Likewise.
2357 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2359 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2360 avoiding the 0 flag, which is not portable.
2361 * process.c (Fmake_network_process): Use pI to avoid cast.
2362 * region-cache.c (pp_cache): Likewise.
2363 * xdisp.c (decode_mode_spec): Likewise.
2364 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2365 behavior on 64-bit hosts with printf arg.
2366 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2367 (x_stop_queuing_selection_requests): Likewise.
2368 (x_get_window_property): Don't truncate byte count to an 'int'
2371 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2372 here, since it parses constructs like leading '-' and spaces,
2373 which are not wanted; and it overflows with large numbers.
2374 Instead, simply match F[0-9]+, which is what is wanted anyway.
2376 * alloc.c: Remove unportable assumptions about struct layout.
2377 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2378 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2379 (allocate_vectorlike, make_pure_vector): Use the new macros,
2380 plus offsetof, to remove unportable assumptions about struct layout.
2381 These assumptions hold on all porting targets that I know of, but
2382 they are not guaranteed, they're easy to remove, and removing them
2383 makes further changes easier.
2385 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2386 This doesn't fix a bug but makes the code clearer.
2387 (string_overrun_cookie): Now const. Use initializers that
2388 don't formally overflow signed char, to avoid warnings.
2389 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2390 can cause Emacs to crash when string overrun checking is enabled.
2391 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2392 multiple of sizeof (EMACS_INT); it need not be, if
2393 alignof(EMACS_INT) < sizeof (EMACS_INT).
2394 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2396 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2398 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2400 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2402 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2403 supposed to be handshaking. (Bug#8556)
2404 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2406 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2408 * lisp.h (Qdebug): List symbol.
2409 * eval.c (Qdebug): Restore global linkage.
2410 * keyboard.c (debug-on-event): New variable.
2411 (handle_user_signal): Break into debugger when debug-on-event
2412 matches the current signal symbol.
2414 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2416 * alloc.c (check_sblock, check_string_bytes)
2417 (check_string_free_list): Convert to standard C.
2419 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2421 * w32.c (emacs_gnutls_push): Fix typo.
2423 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2425 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2426 "cast to pointer from integer of different size".
2428 Improve doprnt and its use in verror. (Bug#8545)
2429 * doprnt.c (doprnt): Document the set of format control sequences
2430 supported by the function. Use SAFE_ALLOCA instead of always
2433 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2434 is one byte too soon. Don't use xrealloc; instead xfree and
2437 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2439 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2442 * gnutls.c: Renamed global_initialized to
2443 gnutls_global_initialized. Added internals for the
2444 :verify-hostname-error, :verify-error, and :verify-flags
2445 parameters of `gnutls-boot' and documented those parameters in the
2446 docstring. Start callback support.
2447 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2448 unless a fatal error occured. Call gnutls_alert_send_appropriate
2449 on error. Return error code.
2450 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2451 (emacs_gnutls_read): Likewise.
2452 (Fgnutls_boot): Return handshake error code.
2453 (emacs_gnutls_handle_error): New function.
2454 (wsaerror_to_errno): Likewise.
2456 * w32.h (emacs_gnutls_pull): Add prototype.
2457 (emacs_gnutls_push): Likewise.
2459 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2460 (emacs_gnutls_push): Likewise.
2462 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2464 * process.c (wait_reading_process_output): Check if GnuTLS
2465 buffered some data internally if no FDs are set for TLS
2468 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2469 (LIBS): Link to USER_LIBS.
2470 ($(BLD)/gnutls.$(0)): New target.
2472 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2474 * xdisp.c (handle_single_display_spec): Rename the
2475 display_replaced_before_p argument into display_replaced_p, to
2476 make it consistent with the commentary. Fix typos in the
2479 * textprop.c (syms_of_textprop): Remove dead code.
2480 (copy_text_properties): Delete obsolete commentary about an
2481 interface that was deleted long ago. Fix typos in the description
2484 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2485 to changes in oldXMenu/XMenu.h from 2011-04-16.
2486 <menu_help_message, prev_menu_help_message>: Constify.
2487 (IT_menu_make_room): menu->help_text is now `const char **';
2490 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2491 to changes in oldXMenu/XMenu.h from 2011-04-16.
2492 (struct XMenu): Declare `help_text' `const char **'.
2494 * xfaces.c <Qunspecified>: Make extern again.
2496 * syntax.c: Include sys/types.h before including regex.h, as
2499 * doc.c (get_doc_string): Improve the format passed to `error'.
2501 * doprnt.c (doprnt): Improve commentary.
2503 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2505 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2508 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2509 changes in globals.h immediately force recompilation.
2510 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2511 $(CURDIR)/s/ms-w32.h.
2512 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2514 * character.c (Fchar_direction): Function deleted.
2515 (syms_of_character): Don't defsubr it.
2516 <char-direction-table>: Deleted.
2518 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2520 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2521 * doprnt.c: Include limits.h.
2522 (SIZE_MAX): New macro.
2523 (doprnt): Return a size_t value. 2nd arg is now size_t.
2524 Many local variables are now size_t instead of int or unsigned.
2525 Improve overflow protection. Support `l' modifier for integer
2526 conversions. Support %l conversion. Don't assume an EMACS_INT
2527 argument for integer conversions and for %c.
2529 * lisp.h (doprnt): Restore prototype.
2531 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2534 * Makefile.in (base_obj): Add back doprnt.o.
2536 * deps.mk (doprnt.o): Add back prerequisites.
2537 (callint.o): Depend on character.h.
2539 * eval.c (internal_lisp_condition_case): Include the handler
2540 representation in the error message.
2541 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2542 when breaking from the loop.
2544 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2546 * callint.c (Fcall_interactively): When displaying error message
2547 about invalid control letter, pass the character's codepoint, not
2548 a pointer to its multibyte form. Improve display of the character
2549 in octal and display also its hex code.
2551 * character.c (char_string): Use %x to display the (unsigned)
2552 codepoint of an invalid character, to avoid displaying a bogus
2555 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2556 `error', not SYMBOL_NAME itself.
2558 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2559 character arguments to `error'.
2561 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2562 to `error' in error message about FINAL_CHAR argument. Make sure
2563 FINAL_CHAR is a character, and use %c when it is passed as
2564 argument to `error'.
2566 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2568 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2570 * w32.c: Include <time.h>.
2571 (sys_localtime): New function.
2573 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2575 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2577 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2579 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2581 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2584 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2586 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2587 gl_state.e_property when gl_state.object is Qt.
2589 * insdel.c (make_gap_larger): Remove limitation of buffer size
2592 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2594 * xdisp.c (lookup_glyphless_char_display)
2595 (produce_glyphless_glyph): Handle cons cell entry in
2596 glyphless-char-display.
2597 (Vglyphless_char_display): Document it.
2599 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2600 glyphless-char-display.
2602 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2604 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2606 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2608 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2609 definition for no-X builds.
2611 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2613 Static checks with GCC 4.6.0 and non-default toolkits.
2615 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2617 * process.c (keyboard_bit_set): Define only if SIGIO.
2618 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2619 (send_process): Repair possible setjmp clobbering.
2621 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2623 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2625 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2627 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2628 Define only if needed.
2630 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2631 by pacifying GCC about it. Maybe it's time to retire it?
2632 * xfaces.c (USG, __TIMEVAL__): Likewise.
2634 * dispextern.h (struct redisplay_interface): Rename param
2636 * termhooks.h (struct terminal): Likewise.
2637 * xterm.c (xembed_send_message): Likewise.
2639 * insdel.c (make_gap_smaller): Define only if
2640 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2642 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2645 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2646 so that we aren't warned about unused symbols.
2648 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2650 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2652 * xfns.c (x_real_positions): Mark locals as initialized.
2654 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2656 * xterm.c: Fix problems found by static analysis with other toolkits.
2657 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2658 (x_dispatch_event): Declare static if USE_GTK, and
2659 define if USE_GTK || USE_X_TOOLKIT.
2660 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2661 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2662 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2663 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2665 * xmenu.c (menu_help_callback): Pointer type fixes.
2666 Use const pointers when pointing at readonly data. Avoid pointer
2668 (FALSE): Remove unused macro.
2669 (update_frame_menubar): Remove unused decl.
2671 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2673 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2674 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2675 (single_menu_item): Rename local to avoid shadowing.
2677 * keyboard.c (make_lispy_event): Remove unused local var.
2679 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2680 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2682 * bitmaps: Change bitmaps from unsigned char back to the X11
2683 compatible char. Avoid the old compiler warnings about
2684 out-of-range initializers by using, for example, '\xab' rather
2687 * xgselect.c (xgselect_initialize): Check vs interface
2688 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2690 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2692 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2693 to read-only memory.
2695 * fns.c (vector): Remove; this old hack is no longer needed.
2697 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2699 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2701 * xrdb.c (x_load_resources): Omit unused local.
2703 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2704 (x_window): Rename locals to avoid shadowing.
2705 (USG): Use the kludged USG macro, to pacify gcc.
2707 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2708 (x_term_init): Remove local to avoid shadowing.
2710 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2712 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2713 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2715 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2717 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2719 Fix regex.c, syntax.c and friends for buffers > 2GB.
2720 * syntax.h (struct gl_state_s): Declare character position members
2723 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2725 * textprop.c (verify_interval_modification, interval_of):
2726 Declare arguments EMACS_INT.
2728 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2731 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2733 * indent.c (Fvertical_motion): Local variable it_start is now
2736 * regex.c (re_match, re_match_2, re_match_2_internal)
2737 (bcmp_translate, regcomp, regexec, print_double_string)
2738 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2739 (re_compile_pattern, re_exec): Declare arguments and local
2740 variables `size_t' and `ssize_t' and return values `regoff_t', as
2742 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2743 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2744 <compile_stack_type>: `size' and `avail' are now `size_t'.
2746 * regex.h <regoff_t>: Use ssize_t, not int.
2747 (re_search, re_search_2, re_match, re_match_2): Arguments that
2748 specify buffer/string position and length are now ssize_t and
2749 size_t. Return type is regoff_t.
2751 2011-04-16 Ben Key <bkey76@gmail.com>
2753 * nsfont.m: Fixed bugs in ns_get_family and
2754 ns_descriptor_to_entity that were caused by using free to
2755 deallocate memory blocks that were allocated by xmalloc (via
2756 xstrdup). This caused Emacs to crash when compiled with
2757 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2758 --enable-checking=xmallocoverrun). xfree is now used to
2759 deallocate these memory blocks.
2761 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2763 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2765 emacs_write: Accept and return EMACS_INT for sizes.
2766 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2768 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2769 Accept and return EMACS_INT.
2770 (emacs_gnutls_write): Return the number of bytes written on
2772 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2773 (emacs_read, emacs_write): Remove check for negative size, as the
2774 Emacs source code has been audited now.
2775 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2776 (emacs_read, emacs_write): Use it.
2777 * process.c (send_process): Adjust to the new signatures of
2778 emacs_write and emacs_gnutls_write. Do not attempt to store
2779 a byte offset into an 'int'; it might overflow.
2780 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2782 * sound.c: Don't assume sizes fit in 'int'.
2783 (struct sound_device.period_size, alsa_period_size):
2784 Return EMACS_INT, not int.
2785 (struct sound_device.write, vox_write, alsa_write):
2786 Accept EMACS_INT, not int.
2787 (wav_play, au_play): Use EMACS_INT to store sizes and to
2788 record read return values.
2790 2011-04-15 Ben Key <bkey76@gmail.com>
2792 * keyboard.c (Qundefined): Don't declare static since it is used
2794 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2795 static since they are used in nsfont.m.
2797 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2799 * process.c (Qprocessp): Don't declare static.
2800 * lisp.h (Qprocessp): Declare again.
2802 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2804 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2806 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2808 Improve C-level modularity by making more things 'static'.
2810 Don't publish debugger-only interfaces to other modules.
2811 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2812 (verify_bytepos, count_markers): Move decls to the only modules
2814 * region-cache.h (pp_cache): Likewise.
2815 * window.h (check_all_windows): Likewise.
2816 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2818 * sysdep.c (croak): Now static, if
2819 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2820 * syssignal.h (croak): Declare only if not static.
2822 * alloc.c (refill_memory_reserve): Now static if
2823 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2824 * lisp.h (refill_memory_reserve): Declare only if not static.
2826 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2827 Define only if USE_LUCID.
2829 * xrdb.c (x_customization_string, x_rm_string): Now static.
2831 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2832 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2834 * xdisp.c (draw_row_with_mouse_face): Now static.
2835 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2837 * window.h (check_all_windows): Mark externally visible.
2839 * window.c (window_deletion_count): Now static.
2841 * undo.c: Make symbols static if they're not exported.
2842 (last_undo_buffer, last_boundary_position, pending_boundary):
2845 * textprop.c (interval_insert_behind_hooks): Now static.
2846 (interval_insert_in_front_hooks): Likewise.
2848 * term.c: Make symbols static if they're not exported.
2849 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2850 (max_frame_lines, tty_set_terminal_modes):
2851 (tty_reset_terminal_modes, tty_turn_off_highlight):
2852 (get_tty_terminal): Now static.
2853 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2854 * termhooks.h (term_mouse_moveto): Do not declare if
2856 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2857 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2859 * sysdep.c: Make symbols static if they're not exported.
2860 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2862 (sigprocmask_set, full_mask): Remove; unused.
2863 (wait_debugging): Mark as visible.
2864 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2865 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2867 * syntax.c (syntax_temp): Define only if !__GNUC__.
2869 * sound.c (current_sound_device, current_sound): Now static.
2871 * search.c (searchbufs, searchbuf_head): Now static.
2873 * scroll.c (scroll_cost): Remove; unused.
2874 * dispextern.h (scroll_cost): Remove decl.
2876 * region-cache.h (pp_cache): Mark as externally visible.
2878 * process.c: Make symbols static if they're not exported.
2879 (process_tick, update_tick, create_process, chan_process):
2880 (Vprocess_alist, proc_buffered_char, datagram_access):
2881 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2882 (deactivate_process): Mark defn as static, as well as decl.
2883 * lisp.h (create_process): Remove decl.
2884 * process.h (chan_process, Vprocess_alist): Remove decls.
2886 * print.c: Make symbols static if they're not exported.
2887 (print_depth, new_backquote_output, being_printed, print_buffer):
2888 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2889 (print_interval, print_number_index, initial_stderr_stream):
2891 * lisp.h (Fprinc): Remove decl.
2892 (debug_output_compilation_hack): Mark as externally visible.
2894 * sysdep.c (croak): Move decl from here to syssignal.h.
2895 * syssignal.h (croak): Put it here, so the API can be checked when
2896 'croak' is called from dissociate_if_controlling_tty.
2898 * minibuf.c: Make symbols static if they're not exported.
2899 (minibuf_save_list, choose_minibuf_frame): Now static.
2900 * lisp.h (choose_minibuf_frame): Remove decl.
2902 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2904 * lread.c: Make symbols static if they're not exported.
2905 (read_objects, initial_obarray, oblookup_last_bucket_number):
2907 (make_symbol): Remove; unused.
2908 * lisp.h (initial_obarray, make_symbol): Remove decls.
2910 * keyboard.c: Make symbols static if they're not exported.
2911 (single_kboard, recent_keys_index, total_keys, recent_keys):
2912 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2913 (this_single_command_key_start, echoing, last_auto_save):
2914 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2915 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2916 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2917 (Vlispy_mouse_stem, double_click_count):
2919 (force_auto_save_soon): Define only if SIGDANGER.
2920 (ignore_mouse_drag_p): Now static if
2921 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2922 (print_help): Remove; unused.
2923 (stop_character, last_timer_event): Mark as externally visible.
2924 * keyboard.h (ignore_mouse_drag_p): Declare only if
2925 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2926 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2927 * lisp.h (echoing): Remove decl.
2928 (force_auto_save_soon): Declare only if SIGDANGER.
2929 * xdisp.c (redisplay_window): Simplify code, to make it more
2930 obvious that ignore_mouse_drag_p is not accessed if !defined
2931 USE_GTK && !defined HAVE_NS.
2933 * intervals.c: Make symbols static if they're not exported.
2934 (merge_properties_sticky, merge_interval_right, delete_interval):
2936 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2938 * insdel.c: Make symbols static if they're not exported.
2939 However, leave prepare_to_modify_buffer alone. It's never
2940 called from outside this function, but that appears to be a bug.
2941 (combine_after_change_list, combine_after_change_buffer):
2942 (adjust_after_replace, signal_before_change): Now static.
2943 (adjust_after_replace_noundo): Remove; unused.
2944 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2945 (signal_before_change): Remove decls.
2947 * indent.c (val_compute_motion, val_vmotion): Now static.
2949 * image.c: Make symbols static if they're not exported.
2950 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2952 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2953 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2955 * fringe.c (standard_bitmaps): Now static.
2956 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2958 * frame.c: Make symbols static if they're not exported.
2959 (x_report_frame_params, make_terminal_frame): Now static.
2960 (get_frame_param): Now static, unless HAVE_NS.
2961 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2962 (x_get_resource_string): Remove; not used.
2963 * frame.h (make_terminal_frame, x_report_frame_params):
2964 (x_get_resource_string); Remove decls.
2965 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2966 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2968 * font.c, fontset.c: Make symbols static if they're not exported.
2969 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2970 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2971 * font.c (font_close_object): Now static.
2972 * font.h (font_close_object): Remove.
2973 * fontset.c (FONTSET_OBJLIST): Remove.
2974 (free_realized_fontset) #if-0 the body, which does nothing.
2975 (face_suitable_for_char_p): #if-0, as it's never called.
2976 * fontset.h (face_suitable_for_char_p): Remove decl.
2977 * xfaces.c (face_at_string_position):
2978 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2979 since 0 is always ASCII.
2981 * fns.c (weak_hash_tables): Now static.
2983 * fileio.c: Make symbols static if they're not exported.
2984 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2985 (Vwrite_region_annotation_buffers): Now static.
2987 * eval.c: Make symbols static if they're not exported.
2988 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2989 * lisp.h (backtrace_list): Remove decl.
2991 * emacs.c: Make symbols static if they're not exported.
2992 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2993 (fatal_error_code, fatal_error_signal_hook, standard_args):
2995 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2996 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2997 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2998 * lisp.h (fatal_error_signal_hook): Remove decl.
2999 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3001 * editfns.c: Move a (normally-unused) function to its only use.
3002 * editfns.c, lisp.h (get_operating_system_release): Remove.
3003 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3004 worth the hassle of breaking this out.
3006 * xterm.c: Make symbols static if they're not exported.
3007 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3008 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3009 (x_destroy_window, x_delete_display):
3011 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3012 (x_mouse_leave): Remove; unused.
3013 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3014 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3015 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3017 (x_mouse_leave): Declare only if WINDOWSNT.
3018 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3019 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3022 * ftxfont.c: Make symbols static if they're not exported.
3023 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3025 * font.h (ftxfont_driver): Likewise.
3027 * xfns.c: Make symbols static if they're not exported.
3028 (x_last_font_name, x_display_info_for_name):
3029 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3030 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3031 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3032 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3033 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3034 (last_show_tip_args): Now static.
3035 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3036 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3037 (x_screen_planes): Remove; unused.
3038 * dispextern.h (x_screen_planes): Remove decl.
3040 * dispnew.c: Make symbols static if they're not exported.
3041 * dispextern.h (redraw_garbaged_frames, scrolling):
3042 (increment_row_positions): Remove.
3043 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3044 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3046 (redraw_garbaged_frames): Remove; unused.
3048 * xfaces.c: Make symbols static if they're not exported.
3049 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3051 * xterm.h (defined_color): Remove decls.
3052 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3053 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3054 (menu_face_changed_default, defined_color, free_realized_face):
3055 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3056 (ascii_face_of_lisp_face): Remove; unused.
3058 * xdisp.c: Make symbols static if they're not exported.
3059 * dispextern.h (scratch_glyph_row, window_box_edges):
3060 (glyph_to_pixel_coords, set_cursor_from_row):
3061 (get_next_display_element, set_iterator_to_next):
3062 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3063 (show_mouse_face): Remove decls
3064 * frame.h (message_buf_print): Likewise.
3065 * lisp.h (pop_message, set_message, check_point_in_composition):
3067 * xterm.h (set_vertical_scroll_bar): Likewise.
3068 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3069 (message_buf_print, scratch_glyph_row, displayed_buffer):
3070 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3071 (get_next_display_element, show_mouse_face, window_box_edges):
3072 (frame_to_window_pixel_xy, check_point_in_composition):
3073 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3074 (glyph_to_pixel_coords): Remove; unused.
3076 * dired.c (file_name_completion): Now static.
3078 * dbusbind.c (xd_in_read_queued_messages): Now static.
3080 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3081 * data.c (circular_list_error): Remove.
3083 * commands.h (last_point_position, last_point_position_buffer):
3084 (last_point_position_window): Remove decls.
3085 * keyboard.c: Make these variables static.
3087 * coding.h (coding, code_convert_region, encode_coding_gap):
3089 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3090 (iso_code_class, detect_coding, code_convert_region): Now static.
3091 (encode_coding_gap): Remove; unused.
3093 * chartab.c (chartab_chars, chartab_bits): Now static.
3095 * charset.h (charset_iso_8859_1): Remove decl.
3096 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3099 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3100 * ccl.c (Vccl_program_table): Now static.
3101 (check_ccl_update): Remove; unused.
3103 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3104 * category.h: ... from here.
3105 * category.c (check_category_table, set_category_set): Now static.
3107 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3108 * lisp.h: Remove these decls.
3110 * buffer.c (buffer_count): Remove unused var.
3112 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3113 so that it's not optimized away.
3114 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3115 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3116 exported only to the debugger.
3118 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3119 * atimer.h (run_all_atimers): Remove; not exported.
3121 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3122 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3123 was inaccessible from Lisp.
3124 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3125 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3127 alloc.c: Import and export fewer symbols, and remove unused items.
3128 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3130 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3131 it's not optimized away by whole-program optimization.
3132 (message_enable_multibyte, free_misc): Remove.
3133 (catchlist, handlerlist, mark_backtrace):
3134 Declare only if BYTE_MARK_STACK.
3135 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3136 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3137 (message_enable_multibyte): Remove decl.
3138 (free_misc, interval_free_list, float_block, float_block_index):
3139 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3140 (cons_free_list, last_marked_index):
3142 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3143 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3144 (mark_backtrace): Define only if BYTE_MARK_STACK.
3145 * xdisp.c (message_enable_multibyte): Now static.
3147 Declare Lisp_Object Q* variables to be 'static' if not exported.
3148 This makes it easier for human readers (and static analyzers)
3149 to see whether these variables are used from other modules.
3150 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3151 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3152 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3153 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3154 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3155 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3156 * xmenu.c, xselect.c:
3157 Declare Q* vars static if they are not used in other modules.
3158 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3159 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3160 Remove decls of unexported vars.
3161 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3163 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3165 Make Emacs functions such as Fatom 'static' by default.
3166 This makes it easier for human readers (and static analyzers)
3167 to see whether these functions can be called from other modules.
3168 DEFUN now defines a static function. To make the function external
3169 so that it can be used in other C modules, use the new macro DEFUE.
3170 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3171 (Finit_image_library):
3172 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3173 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3174 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3175 Remove decls, since these functions are now static.
3176 (Funintern, Fget_internal_run_time): New decls, since these functions
3177 were already external.
3179 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3180 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3181 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3182 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3183 * keyboard.c, keymap.c, lread.c:
3184 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3185 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3186 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3187 Mark functions with DEFUE instead of DEFUN,
3188 if they are used in other modules.
3189 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3190 decls for now-static functions.
3191 * buffer.h (Fdelete_overlay): Remove decl.
3192 * callproc.c (Fgetenv_internal): Mark as internal.
3193 * composite.c (Fremove_list_of_text_properties): Remove decl.
3194 (Fcomposition_get_gstring): New forward static decl.
3195 * composite.h (Fcomposite_get_gstring): Remove decl.
3196 * dired.c (Ffile_attributes): New forward static decl.
3197 * doc.c (Fdocumntation_property): New forward static decl.
3198 * eval.c (Ffetch_bytecode): New forward static decl.
3199 (Funintern): Remove extern decl; now in .h file where it belongs.
3200 * fileio.c (Fmake_symbolic_link): New forward static decl.
3201 * image.c (Finit_image_library): New forward static decl.
3202 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3203 * intervals.h (Fprevious_property_change):
3204 (Fremove_list_of_text_properties): Remove decls.
3205 * keyboard.c (Fthis_command_keys): Remove decl.
3206 (Fcommand_execute): New forward static decl.
3207 * keymap.c (Flookup_key): New forward static decl.
3208 (Fcopy_keymap): Now static.
3209 * keymap.h (Flookup_key): Remove decl.
3210 * process.c (Fget_process): New forward static decl.
3211 (Fprocess_datagram_address): Mark as internal.
3212 * syntax.c (Fsyntax_table_p): New forward static decl.
3213 (skip_chars): Remove duplicate decl.
3214 * textprop.c (Fprevious_property_change): New forward static decl.
3215 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3217 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3218 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3220 * editfns.c (Fformat): Remove unreachable code.
3222 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3224 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3227 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3229 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3230 when at ZV. (Bug#8487)
3232 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3234 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3236 * keyboard.c (parse_tool_bar_item): Likewise.
3237 * sound.c (sound_cleanup, alsa_close): Likewise.
3238 * termcap.c (tgetent): Likewise.
3239 * xfns.c (x_default_font_parameter): Likewise.
3240 * xsettings.c (read_and_apply_settings): Likewise.
3242 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3243 (overrun_check_free): Protoize.
3245 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3247 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3248 since callers should never pass a negative size.
3249 Change the signature to match that of plain 'read' and 'write'; see
3250 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3251 * lisp.h: Update prototypes of emacs_write and emacs_read.
3253 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3255 * xdisp.c (redisplay_window): Don't try to determine the character
3256 position of the scroll margin if the window start point w->startp
3257 is outside the buffer's accessible region. (Bug#8468)
3259 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3261 Fix write-region and its subroutines for buffers > 2GB.
3262 * fileio.c (a_write, e_write): Modify declaration of arguments and
3263 local variables to support buffers larger than 2GB.
3264 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3266 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3267 argument, local variables, and return value.
3269 * lisp.h: Update prototypes of emacs_write and emacs_read.
3271 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3273 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3275 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3277 Fix more problems found by GCC 4.6.0's static checks.
3279 * xdisp.c (vmessage): Use a better test for character truncation.
3281 * charset.c (load_charset_map): <, not <=, for optimization,
3282 and to avoid potential problems with integer overflow.
3283 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3284 * casetab.c (set_identity, shuffle): Likewise.
3285 * editfns.c (Fformat): Likewise.
3286 * syntax.c (skip_chars): Likewise.
3288 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3289 This also lets GCC 4.6.0 generate slightly better loop code.
3291 * callint.c (Fcall_interactively): <, not <=, for optimization.
3292 (Fcall_interactively): Count the number of arguments produced,
3293 not the number of arguments given. This is simpler and lets GCC
3294 4.6.0 generate slightly better code.
3296 * ftfont.c: Distingish more carefully between FcChar8 and char.
3297 The previous code passed unsigned char * to a functions like
3298 strlen and xstrcasecmp that expect char *, which does not
3299 conform to the C standard.
3300 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3301 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3302 char * when the C standard requires it.
3304 * keyboard.c (read_char): Remove unused var.
3306 * eval.c: Port to Windows vsnprintf (Bug#8435).
3308 (SIZE_MAX): Define if the headers do not.
3309 (verror): Do not give up if vsnprintf returns a negative count.
3310 Instead, grow the buffer. This ports to Windows vsnprintf, which
3311 does not conform to C99. Problem reported by Eli Zaretskii.
3312 Also, simplify the allocation scheme, by avoiding the need for
3313 calling realloc, and removing the ALLOCATED variable.
3315 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3317 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3318 But keep the doprint source code for now, as we might revamp it
3319 and use it again (Bug#8435).
3320 * lisp.h (doprnt): Remove.
3321 * Makefile.in (base_obj): Remove doprnt.o.
3322 * deps.mk (doprnt.o): Remove.
3324 error: Print 32- and 64-bit integers portably (Bug#8435).
3325 Without this change, on typical 64-bit hosts error ("...%d...", N)
3326 was used to print both 32- and 64-bit integers N, which relied on
3328 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3330 * lisp.h (error, verror): Mark as printf-like functions.
3331 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3332 Report overflow in size calculations when allocating printf buffer.
3333 Do not truncate output string at its first null byte.
3334 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3335 Truncate the output at a character boundary, since vsnprintf does not
3337 * charset.c (check_iso_charset_parameter): Convert internal
3338 character to string before calling 'error', since %c now has the
3340 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3341 overflow when computing char to be passed to 'error'. Do not
3342 pass Lisp_Object to 'error'; pass the integer instead.
3343 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3344 formatted with plain %d.
3346 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3348 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3350 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3352 * xterm.c (x_catch_errors): Remove duplicate declaration.
3354 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3356 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3358 2011-04-10 Jim Meyering <meyering@redhat.com>
3360 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3361 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3362 return ssize_t not "int", and use size_t as the buffer length.
3363 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3364 * gnutls.h: Update declarations.
3365 * process.c (read_process_output): Use ssize_t, to match.
3366 (send_process): Likewise.
3368 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3370 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3372 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3374 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3375 Use unsigned char, to match FcChar8 type definition.
3377 * xterm.c (handle_one_xevent):
3378 * xmenu.c (create_and_show_popup_menu):
3379 * xselect.c (x_decline_selection_request)
3380 (x_reply_selection_request): Avoid type-punned deref of X events.
3382 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3384 Fix some uses of `int' instead of EMACS_INT.
3385 * search.c (string_match_1, fast_string_match)
3386 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3387 (scan_buffer, find_next_newline_no_quit)
3388 (find_before_next_newline, search_command, Freplace_match)
3389 (Fmatch_data): Make some `int' variables be EMACS_INT.
3391 * xdisp.c (display_count_lines): 3rd argument and return value now
3392 EMACS_INT. All callers changed.
3393 (pint2hrstr): Last argument is now EMACS_INT.
3395 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3396 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3397 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3398 (decode_coding_utf_16, decode_coding_emacs_mule)
3399 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3400 (decode_coding_ccl, decode_coding_charset)
3401 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3402 (decode_coding_iso_2022, decode_coding_emacs_mule)
3403 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3404 <char_offset, last_offset>: Declare EMACS_INT.
3405 (encode_coding_utf_8, encode_coding_utf_16)
3406 (encode_coding_emacs_mule, encode_invocation_designation)
3407 (encode_designation_at_bol, encode_coding_iso_2022)
3408 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3409 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3411 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3412 (encode_invocation_designation): Last argument P_NCHARS is now
3414 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3415 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3417 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3420 * ccl.c (Fccl_execute_on_string): Declare some variables
3423 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3425 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3427 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3429 * process.c (Fformat_network_address): Doc fix.
3431 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3433 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3435 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3437 * keyboard.c (read_char): Call Lisp function help-form-show,
3438 instead of using internal_with_output_to_temp_buffer.
3439 (Qhelp_form_show): New var.
3440 (syms_of_keyboard): Use DEFSYM macro.
3442 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3444 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3446 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3448 * process.c (Flist_processes): Remove to Lisp.
3449 (list_processes_1): Delete.
3451 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3453 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3455 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3457 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3459 Fix more problems found by GCC 4.6.0's static checks.
3461 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3463 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3465 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3467 * xdisp.c (vmessage): Mark as a printf-like function.
3469 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3471 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3473 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3474 printf-like functions.
3475 (tiff_load): Add casts to remove these marks before passing them
3476 to system-supplied API.
3478 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3480 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3481 This avoids several warnings with gcc -Wstrict-overflow.
3482 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3483 directly, rather than having caller test rule sign. This avoids
3484 some unnecessary tests.
3485 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3486 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3487 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3489 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3490 (xfont_open): Avoid unnecessary tests.
3492 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3494 * composite.h, composite.c (composition_gstring_put_cache):
3495 Use EMACS_INT, not int, for length.
3497 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3498 breaking out part of COMPOSITION_DECODE_RULE.
3499 (COMPOSITION_DECODE_RULE): Use it.
3500 * composite.c (get_composition_id): Remove unused local vars,
3501 by using the new macro.
3503 * textprop.c (set_text_properties_1): Change while to do-while,
3504 since the condition is always true at first.
3506 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3507 (interval_deletion_adjustment): Return unsigned value.
3510 * process.c (list_processes_1, create_pty, read_process_output):
3511 (exec_sentinel): Remove vars that were set but not used.
3512 (create_pty): Remove unnecessary "volatile"s.
3513 (Fnetwork_interface_info): Avoid possibility of int overflow.
3514 (read_process_output): Do adaptive read buffering even if carryover.
3515 (read_process_output): Simplify nbytes computation if buffered.
3517 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3519 * syntax.c (scan_words): Remove var that was set but not used.
3520 (update_syntax_table): Use unsigned instead of int.
3522 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3523 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3524 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3526 * print.c (print_error_message): Avoid int overflow.
3528 * font.c (font_list_entities): Redo for clarity,
3529 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3531 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3532 (font_score): Avoid potential overflow in diff calculation.
3534 * fns.c (substring_both): Remove var that is set but not used.
3535 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3537 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3539 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3540 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3541 can always succeed if overflow has undefined behavior.
3543 * search.c (boyer_moore, wordify): Remove vars set but not used.
3544 (wordify): Omit three unnecessary tests.
3546 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3547 All callers changed. This avoids the need for an unused var.
3549 * casefiddle.c (casify_region): Remove var that is set but not used.
3551 * dired.c (file_name_completion): Remove var that is set but not used.
3553 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3555 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3556 (Finsert_file_contents): Remove unnecessary code checking fd.
3558 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3559 Check for integer overflow on size calculations.
3561 * buffer.c (Fprevious_overlay_change): Remove var that is set
3564 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3565 Remove vars that are set but not used.
3566 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3567 (timer_check_2): Mark vars as initialized.
3569 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3571 * image.c (lookup_image): Remove var that is set but not used.
3572 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3574 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3575 that are set but not used.
3577 * xfns.c (make_invisible_cursor): Don't return garbage
3578 if XCreateBitmapFromData fails (Bug#8410).
3580 * xselect.c (x_get_local_selection, x_handle_property_notify):
3581 Remove vars that are set but not used.
3583 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3584 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3586 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3587 Remove var that is set but not used.
3588 (scroll_bar_windows_size): Now size_t, not int.
3589 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3592 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3593 (map_tty_color) [!defined MSDOS]: Likewise.
3595 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3597 * coding.c: Remove vars that are set but not used.
3598 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3599 All callers changed.
3600 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3601 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3602 (decode_coding_charset): Remove vars that are set but not used.
3604 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3605 that is set but not used.
3607 * print.c (print_object): Remove var that is set but not used.
3609 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3610 The gnulib version avoids calling malloc in the usual case,
3611 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3612 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3613 * filelock.c (current_lock_owner): Likewise.
3614 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3615 * sysdep.c: Include allocator.h, careadlinkat.h.
3616 (emacs_no_realloc_allocator): New static constant.
3617 (emacs_readlink): New function.
3618 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3619 ../lib/careadlinkat.h.
3621 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3623 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3624 first non-nil return value).
3626 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3628 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3629 if not defined (Bug#8403).
3631 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3633 * xdisp.c (display_count_lines): Remove parameter `start',
3634 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3635 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3636 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3637 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3638 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3639 and thereabouts. All callers changed.
3640 (get_per_char_metric): Remove parameter `f', unused since
3641 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3643 2011-04-02 Jim Meyering <meyering@redhat.com>
3645 do not dereference NULL upon failed strdup
3646 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3647 (ns_get_family): Likewise.
3649 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3651 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3653 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3655 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3658 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3660 Add lexical binding.
3662 * window.c (Ftemp_output_buffer_show): New fun.
3663 (Fsave_window_excursion):
3664 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3666 * lread.c (lisp_file_lexically_bound_p): New function.
3667 (Fload): Bind Qlexical_binding.
3668 (readevalloop): Remove `evalfun' arg.
3669 Bind Qinternal_interpreter_environment.
3670 (Feval_buffer): Bind Qlexical_binding.
3671 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3673 (syms_of_lread): Declare `lexical-binding'.
3675 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3677 * keyboard.c (eval_dyn): New fun.
3678 (menu_item_eval_property): Use it.
3680 * image.c (parse_image_spec): Use Ffunctionp.
3682 * fns.c (concat, mapcar1): Accept byte-code-functions.
3684 * eval.c (Fsetq): Handle lexical vars.
3685 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3686 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3687 (FletX, Flet): Obey lexical binding.
3688 (Fcommandp): Handle closures.
3689 (Feval): New `lexical' arg.
3690 (eval_sub): New function extracted from Feval. Use it almost
3691 everywhere where Feval was used. Look up vars in lexical env.
3693 (Ffunctionp): Move from subr.el.
3694 (Ffuncall): Handle closures.
3695 (apply_lambda): Remove `eval_flags'.
3696 (funcall_lambda): Handle closures and new byte-code-functions.
3697 (Fspecial_variable_p): New function.
3698 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3699 but without exporting it to Lisp.
3701 * doc.c (Fdocumentation, store_function_docstring):
3702 * data.c (Finteractive_form): Handle closures.
3704 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3707 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3709 (exec_byte_code): New function extracted from Fbyte_code to handle new
3710 calling convention for byte-code-functions. Add new byte-codes.
3712 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3714 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3716 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3718 * xdisp.c (redisplay_internal): Fix prototype.
3720 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3722 * xdisp.c (SCROLL_LIMIT): New macro.
3723 (try_scrolling): Use it when setting scroll_limit.
3724 Limit scrolling to 100 screen lines.
3725 (redisplay_window): Even when falling back on "recentering",
3726 position point in the window according to scroll-conservatively,
3727 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3729 (try_scrolling): When point is above the window, allow searching
3730 as far as scroll_max, or one screenful, to compute vertical
3731 distance from PT to the scroll margin position. This prevents
3732 try_scrolling from unnecessarily failing when
3733 scroll-conservatively is set to a value slightly larger than the
3734 window height. Clean up the case of PT below the margin at bottom
3735 of window: scroll_max can no longer be INT_MAX. When aggressive
3736 scrolling is in use, don't let point enter the opposite scroll
3737 margin as result of the scroll.
3738 (syms_of_xdisp) <scroll-conservatively>: Document the
3739 threshold of 100 lines for never-recentering scrolling.
3741 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3743 * dispextern.h (move_it_by_lines):
3744 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3745 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3746 (message_log_check_duplicate): Remove parameters `prev_bol' and
3747 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3748 (redisplay_internal): Remove parameter `preserve_echo_area',
3749 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3751 * indent.c (Fvertical_motion):
3752 * window.c (window_scroll_pixel_based, Frecenter):
3753 Don't pass `need_y_p' to `move_it_by_lines'.
3755 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3757 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3758 steal a few bits to be more compact.
3759 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3760 Remove unneeded casts.
3762 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3764 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3766 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3767 binding" message (bug#7967).
3769 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3771 Fix more problems found by GCC 4.6.0's static checks.
3773 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3774 Remove unused local var.
3776 * editfns.c (Fmessage_box): Remove unused local var.
3778 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3779 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3780 Omit unused local vars.
3781 * window.c (shrink_windows): Omit unused local var.
3782 * menu.c (digest_single_submenu): Omit unused local var.
3783 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3784 Omit unused local var.
3786 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3787 Don't assume string length fits in int.
3788 (keyremap_step, read_key_sequence): Use size_t for sizes.
3789 (read_key_sequence): Don't check last_real_key_start redundantly.
3791 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3792 instead of alloca (Bug#8344).
3794 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3795 (Fbacktrace_frame): Don't assume nframes fits in int.
3797 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3799 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3802 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3804 * cm.c (calccost): Turn while-do into do-while, for clarity.
3806 * keyboard.c (syms_of_keyboard): Use the same style as later
3807 in this function when indexing through an array. This also
3808 works around GCC bug 48267.
3810 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3812 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3814 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3815 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3817 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3818 This avoids undefined behavior on integer overflow, and is a bit
3819 more convenient anyway since it is compared to a size_t variable.
3821 Variadic C functions now count arguments with size_t, not int.
3822 This avoids an unnecessary limitation on 64-bit machines, which
3823 caused (substring ...) to crash on large vectors (Bug#8344).
3824 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3825 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3826 All variadic functions and their callers changed accordingly.
3827 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3828 * data.c (arith_driver, float_arith_driver): Likewise.
3829 * editfns.c (general_insert_function): Likewise.
3830 * eval.c (struct backtrace.nargs, interactive_p)
3831 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3832 (funcall_lambda, mark_backtrace): Likewise.
3833 * fns.c (concat): Likewise.
3834 * frame.c (x_set_frame_parameters): Likewise.
3835 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3836 0 if not found, not -1. All callers changed.
3838 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3839 (stack_copy_size): Now size_t, not int.
3840 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3842 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3844 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3845 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3846 All callers changed.
3848 * lisp.h (multibyte_char_to_unibyte):
3849 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3850 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3851 * character.h (CHAR_TO_BYTE8):
3852 * cmds.c (internal_self_insert):
3853 * editfns.c (general_insert_function):
3854 * keymap.c (push_key_description):
3855 * search.c (Freplace_match):
3856 * xdisp.c (message_dolog, set_message_1): All callers changed.
3858 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3860 * keyboard.c (safe_run_hook_funcall): New function.
3861 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3862 don't set the hook to nil, but remove the offending function instead.
3863 (Qcommand_hook_internal): Remove, unused.
3864 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3865 Vcommand_hook_internal.
3867 * eval.c (enum run_hooks_condition): Remove.
3868 (funcall_nil, funcall_not): New functions.
3869 (run_hook_with_args): Call each function through a `funcall' argument.
3870 Remove `cond' argument, now redundant.
3871 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3872 (Frun_hook_with_args_until_failure): Adjust accordingly.
3873 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3875 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3877 * dispextern.h (string_buffer_position): Remove declaration.
3879 * print.c (strout): Remove parameter `multibyte', unused since
3880 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3882 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3883 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3884 All callers changed.
3886 * w32.c (_wsa_errlist): Use braces for struct initializers.
3888 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3889 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3890 All callers changed.
3891 (string_buffer_position): Likewise. Also, make static (it's never
3892 used outside xdisp.c).
3893 (cursor_row_p): Remove parameter `w', unused since
3894 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3895 (decode_mode_spec): Remove parameter `precision', introduced during
3896 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3897 All callers changed.
3899 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3901 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3903 2011-03-27 Anders Lindgren <andlind@gmail.com>
3905 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3906 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3907 (ns_update_auto_hide_menu_bar): New functions.
3908 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3909 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3910 ns_constrain_all_frames.
3911 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3912 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3914 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3916 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3918 2011-03-27 Glenn Morris <rgm@gnu.org>
3920 * syssignal.h: Replace RETSIGTYPE with void.
3921 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3922 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3923 Replace SIGTYPE with void everywhere.
3924 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3925 * s/template.h (SIGTYPE): Remove commented out definition.
3927 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3929 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3930 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3932 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3934 * w32.c (read_unc_volume): Use parameter `henum', instead of
3935 global variable `wget_enum_handle'.
3937 * keymap.c (describe_vector): Remove parameters `indices' and
3938 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3939 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3941 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3943 * keyboard.c (timer_check): Remove parameter `do_it_now',
3944 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3945 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3946 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3948 * keyboard.c (read_char):
3949 * w32menu.c (w32_menu_display_help):
3950 * xmenu.c (show_help_event, menu_help_callback):
3951 Adjust calls to `show_help_echo'.
3953 * gtkutil.c (xg_maybe_add_timer):
3954 * keyboard.c (readable_events):
3955 * process.c (wait_reading_process_output):
3956 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3958 * insdel.c (adjust_markers_gap_motion):
3959 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3960 (gap_left, gap_right): Don't call it.
3962 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3964 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3965 incurred during fontification.
3967 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3969 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3970 (DEFVAR_PER_BUFFER): Don't pass it.
3972 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3973 (scrolling_window): Don't pass it.
3975 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3977 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3979 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3981 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3982 of variables specific to SELinux and computation of `encoded_absname'.
3984 * image.c (XPutPixel): Remove unused variable `height'.
3986 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3988 * unexw32.c (get_section_info): Remove unused variable `section'.
3990 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3991 (system_process_attributes): Remove unused variable `sess'.
3992 (sys_read): Remove unused variable `err'.
3994 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3995 (w32_wnd_proc): Remove unused variable `isdead'.
3996 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3997 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3998 (x_create_tip_frame): Remove unused variable `tem'.
4000 * w32inevt.c (w32_console_read_socket):
4001 Remove unused variable `no_events'.
4003 * w32term.c (x_draw_composite_glyph_string_foreground):
4004 Remove unused variable `width'.
4006 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4008 * w32term.c (x_set_glyph_string_clipping):
4009 Don't pass uninitialized region to CombineRgn.
4011 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4013 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4014 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4015 (Fx_close_connection): Remove unused variable `i'.
4017 * w32font.c (w32font_draw): Return number of glyphs.
4018 (w32font_open_internal): Remove unused variable `i'.
4019 (w32font_driver): Add missing initializer.
4021 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4022 (fill_in_menu): Remove unused variable `items_added'.
4024 * w32term.c (last_mouse_press_frame): Remove static global variable.
4025 (w32_clip_to_row): Remove unused variable `f'.
4026 (x_delete_terminal): Remove unused variable `i'.
4028 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4029 (NOTHING): Remove unused static global variable.
4030 (uniscribe_check_otf): Remove unused variable `table'.
4031 (uniscribe_font_driver): Add missing initializers.
4033 2011-03-23 Julien Danjou <julien@danjou.info>
4035 * term.c (Fsuspend_tty, Fresume_tty):
4036 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4037 * window.c (temp_output_buffer_show):
4038 * insdel.c (signal_before_change):
4039 * frame.c (Fhandle_switch_frame):
4040 * fileio.c (Fdo_auto_save):
4041 * emacs.c (Fkill_emacs):
4042 * editfns.c (save_excursion_restore):
4043 * cmds.c (internal_self_insert):
4044 * callint.c (Fcall_interactively):
4045 * buffer.c (Fkill_all_local_variables):
4046 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4048 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4049 unconditionnaly since it does the check itself.
4051 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4053 Fix more problems found by GCC 4.5.2's static checks.
4055 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4056 the first time through the loop, since we know p0 < p1 then.
4057 This also avoids a gcc -Wstrict-overflow warning.
4059 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4060 leading to a memory leak, possible in functions like
4061 load_charset_map_from_file that can allocate an unbounded number
4062 of objects (Bug#8318).
4064 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4065 that could (at least in theory) be that large.
4067 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4068 This is less likely to overflow, and avoids undefined behavior if
4069 overflow does occur. All callers changed. Use strtoul to scan
4070 for the unsigned long integer.
4071 (pint2hrstr): Simplify and tune code slightly.
4072 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4074 * scroll.c (do_scrolling): Work around GCC bug 48228.
4075 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4077 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4078 This also avoids a warning with gcc -Wstrict-overflow.
4079 (validate_x_resource_name): Simplify count usage.
4080 This also avoids a warning with gcc -Wstrict-overflow.
4082 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4085 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4087 * process.c (Fmake_network_process): Use socklen_t, not int,
4088 where POSIX says socklen_t is required in portable programs.
4089 This fixes a porting bug on hosts like 64-bit HP-UX, where
4090 socklen_t is wider than int (Bug#8277).
4091 (Fmake_network_process, server_accept_connection):
4092 (wait_reading_process_output, read_process_output):
4095 * process.c: Rename or move locals to avoid shadowing.
4096 (list_processes_1, Fmake_network_process):
4097 (read_process_output_error_handler, exec_sentinel_error_handler):
4098 Rename or move locals.
4099 (Fmake_network_process): Define label "retry_connect" only if needed.
4100 (Fnetwork_interface_info): Fix pointer signedness.
4101 (process_send_signal): Add cast to avoid pointer signedness problem.
4102 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4103 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4105 Make tparam.h and terminfo.c consistent.
4106 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4107 Include tparam.h instead, since it declares them.
4108 * cm.h (PC): Remove extern decl; tparam.h now does this.
4109 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4110 * terminfo.c: Include tparam.h, to check interfaces.
4111 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4112 (tparam): Adjust signature to match interface in tparam.h;
4113 this removes some undefined behavior. Check that outstring and len
4114 are zero, which they always are with Emacs.
4115 * tparam.h (PC, BC, UP): New extern decls.
4117 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4118 (xftfont_open): Rename locals to avoid shadowing.
4120 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4121 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4122 (OTF_TAG_SYM): Omit macro if not needed.
4123 (ftfont_list): Remove unused local.
4124 (get_adstyle_property, ftfont_pattern_entity):
4125 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4126 Rename locals to avoid shadowing.
4128 * xfont.c (xfont_list_family): Mark var as initialized.
4130 * xml.c (make_dom): Now static.
4132 * composite.c (composition_compute_stop_pos): Rename local to
4134 (composition_reseat_it): Remove unused locals.
4135 (find_automatic_composition, composition_adjust_point): Likewise.
4136 (composition_update_it): Mark var as initialized.
4137 (find_automatic_composition): Mark vars as initialized,
4138 with a FIXME (Bug#8290).
4140 character.h: Rename locals to avoid shadowing.
4141 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4142 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4143 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4144 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4147 * textprop.c (property_change_between_p): Remove; unused.
4149 * intervals.c (interval_start_pos): Now static.
4151 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4153 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4154 Rename locals to avoid shadowing.
4156 * sound.c (wav_play, au_play, Fplay_sound_internal):
4157 Fix pointer signedness.
4158 (alsa_choose_format): Remove unused local var.
4159 (wav_play): Initialize a variable to 0, to prevent undefined
4160 behavior (Bug#8278).
4162 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4164 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4166 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4167 clobbering (Bug#8298).
4168 * sysdep.c (sys_subshell): Likewise.
4169 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4171 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4172 This should get cleaned up, so that child_setup has the
4173 same signature on all platforms.
4175 * callproc.c (call_process_cleanup): Now static.
4176 (relocate_fd): Rename locals to avoid shadowing.
4178 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4180 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4181 not to be necessary, and produces flickering.
4183 2011-03-20 Glenn Morris <rgm@gnu.org>
4185 * config.in: Remove file.
4187 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4189 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4190 are now in src/globals.h.
4191 (syms_of_minibuf): Remove spurious & from previous change.
4193 2011-03-20 Leo <sdl.web@gmail.com>
4195 * minibuf.c (completing-read-function): New variable.
4196 (completing-read-default): Rename from completing-read.
4197 (completing-read): Call completing-read-function.
4199 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4201 * xfaces.c (Fx_load_color_file):
4202 Read color file from absolute filename (bug#8250).
4204 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4206 * makefile.w32-in: Update dependencies.
4208 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4210 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4212 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4214 Fix more problems found by GCC 4.5.2's static checks.
4216 * process.c (make_serial_process_unwind, send_process_trap):
4217 (sigchld_handler): Now static.
4219 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4220 That way, the code declares only the vars that it needs.
4221 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4222 * s/cygwin.h (PTY_ITERATION): Likewise.
4223 * s/darwin.h (PTY_ITERATION): Likewise.
4224 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4226 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4227 * process.c (allocate_pty): Don't declare stb unless it's needed.
4229 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4230 (CONSTANTLIM): Remove; unused.
4231 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4232 Define only if needed.
4234 * unexelf.c (unexec): Name an expression,
4235 to avoid gcc -Wbad-function-cast warning.
4236 Use a different way to cause a compilation error if anyone uses
4237 n rather than nn, a way that does not involve shadowing.
4238 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4240 * deps.mk (unexalpha.o): Remove; unused.
4242 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4243 * unexec.h: New file.
4244 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4245 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4247 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4248 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4249 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4250 Change as necessary to match prototype in unexec.h.
4252 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4254 (back_comment, skip_chars): Mark vars as initialized.
4256 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4257 Rename locals to avoid shadowing.
4259 * lread.c (read1): Rewrite so as not to use empty "else".
4260 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4262 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4264 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4265 warning when compiling print.c.
4267 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4268 instead of using an uninitialized var.
4269 (font_sort_entities): Mark var as initialized.
4271 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4273 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4274 pointers to constants.
4275 (font_parse_fcname): Remove unused vars.
4276 (font_delete_unmatched): Now static.
4277 (font_get_spec): Remove; unused.
4278 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4279 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4280 Rename or move locals to avoid shadowing.
4282 * fns.c (require_nesting_list, require_unwind): Now static.
4283 (Ffillarray): Rename locals to avoid shadowing.
4285 * floatfns.c (domain_error2): Define only if needed.
4286 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4288 * alloc.c (mark_backtrace): Move decl from here ...
4289 * lisp.h: ... to here, so that it can be checked.
4291 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4292 (Fdefvar): Rewrite so as not to use empty "else".
4293 (lisp_indirect_variable): Name an expression,
4294 to avoid gcc -Wbad-function-cast warning.
4295 (Fdefvar): Rename locals to avoid shadowing.
4297 * callint.c (quotify_arg, quotify_args): Now static.
4298 (Fcall_interactively): Rename locals to avoid shadowing.
4299 Use const pointer when appropriate.
4301 * lisp.h (get_system_name, get_operating_system_release):
4302 Move decls here, to check interfaces.
4303 * process.c (get_operating_system_release): Move decl to lisp.h.
4304 * xrdb.c (get_system_name): Likewise.
4305 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4306 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4307 some of which prompt warnings from gcc -Wbad-function-cast.
4308 (Fformat_time_string, Fencode_time, Finsert_char):
4309 (Ftranslate_region_internal, Fformat):
4310 Rename or remove local vars to avoid shadowing.
4311 (Ftranslate_region_internal): Mark var as initialized.
4313 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4316 * lisp.h (eassert): Check that the argument compiles, even if
4317 ENABLE_CHECKING is not defined.
4319 * data.c (Findirect_variable): Name an expression, to avoid
4320 gcc -Wbad-function-cast warning.
4321 (default_value, arithcompare, arith_driver, arith_error): Now static.
4322 (store_symval_forwarding): Rename local to avoid shadowing.
4323 (Fmake_variable_buffer_local, Fmake_local_variable):
4324 Mark variables as initialized.
4325 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4327 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4328 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4329 Rename locals to avoid shadowing.
4330 (mark_stack): Move local variables into the #ifdef region where
4332 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4333 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4335 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4336 (GC_STRING_CHARS): Remove; not used.
4337 (Fmemory_limit): Cast sbrk's returned value to char *.
4339 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4340 avoids undefined behavior in theory.
4342 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4344 Use functions, not macros, for up- and down-casing (Bug#8254).
4345 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4346 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4347 to use the following functions instead of these macros.
4348 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4349 EMACS_INT, since callers assume the returned value fits in int.
4350 (upcase1): Likewise, for UPCASE_TABLE.
4351 (uppercasep, lowercasep, upcase): New static inline functions.
4352 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4353 the race-condition problem in the old DOWNCASE.
4355 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4356 Rename locals to avoid shadowing.
4357 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4358 (regex_compile, re_search_2, re_match_2_internal):
4359 Remove unused local vars.
4360 (FREE_VAR): Rewrite so as not to use empty "else",
4361 which gcc can warn about.
4362 (regex_compile, re_match_2_internal): Mark locals as initialized.
4363 (RETALLOC_IF): Define only if needed.
4364 (WORDCHAR_P): Likewise. This one is never needed, but is used
4365 only in a comment talking about a compiler bug, so put inside
4366 the #if 0 of that comment.
4367 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4368 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4371 * search.c (boyer_moore): Rename locals to avoid shadowing.
4372 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4373 (PREV_CHAR_BOUNDARY): Likewise.
4375 * search.c (simple_search): Remove unused var.
4377 * dired.c (compile_pattern): Move decl from here ...
4378 * lisp.h: ... to here, so that it can be checked.
4379 (struct re_registers): New forward decl.
4381 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4383 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4385 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4386 Rename locals to avoid shadowing.
4387 (Fvertical_motion): Mark locals as initialized.
4389 * casefiddle.c (casify_object, casify_region): Now static.
4390 (casify_region): Mark local as initialized.
4392 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4394 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4395 New macros, so that the caller can use some names other than
4396 gcpro1, gcpro2, etc.
4397 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4399 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4400 argument, for consistency with GCPRO2_VAR, etc: it is now the
4401 prefix of the variable, not the variable itself. All uses
4403 * dired.c (directory_files_internal, file_name_completion):
4404 Rename locals to avoid shadowing.
4406 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4407 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4408 dired.c's scmp function, had undefined behavior.
4409 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4410 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4411 * buffer.h: ... to here, because these macros use current_buffer,
4412 and the new implementation with inline functions needs to have
4413 current_buffer in scope now, rather than later when the macros
4415 (downcase, upcase1): New static inline functions.
4416 (DOWNCASE, UPCASE1): Reimplement using these functions.
4417 This avoids undefined behavior in expressions like
4418 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4419 from race conditions in accessing the global variables
4420 case_temp1 and case_temp2.
4421 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4422 * lisp.h (case_temp1, case_temp2): Remove their decls.
4423 * character.h (ASCII_CHAR_P): Move from here ...
4424 * lisp.h: ... to here, so that the inline functions mentioned
4427 * dired.c (directory_files_internal_unwind): Now static.
4429 * fileio.c (file_name_as_directory, directory_file_name):
4430 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4432 (file_name_as_directory): Use const pointers when appropriate.
4433 (Fexpand_file_name): Likewise. In particular, newdir might
4434 point at constant storage, so make it a const pointer.
4435 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4436 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4438 (Fset_file_times, Finsert_file_contents, auto_save_error):
4439 Rename locals to avoid shadowing.
4441 * minibuf.c (choose_minibuf_frame_1): Now static.
4442 (Ftry_completion, Fall_completions): Rename or remove locals
4445 * marker.c (bytepos_to_charpos): Remove; unused.
4447 * lisp.h (verify_bytepos, count_markers): New decls,
4448 so that gcc does not warn that these functions aren't declared.
4450 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4451 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4452 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4453 (copy_text): Remove unused local var.
4455 * filelock.c (within_one_second): Now static.
4456 (lock_file_1): Rename local to avoid shadowing.
4458 * buffer.c (fix_overlays_before): Mark locals as initialized.
4459 (fix_start_end_in_overlays): Likewise. This function should be
4460 simplified by using pointers-to-pointers, but that's a different
4462 (switch_to_buffer_1): Now static.
4463 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4464 (report_overlay_modification): Rename locals to avoid shadowing.
4466 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4467 Fix pointer signedness issue.
4468 (sys_subshell): Mark local as volatile if checking for lint,
4469 to suppress a gcc -Wclobbered warning that does not seem to be right.
4470 (MAXPATHLEN): Define only if needed.
4472 * process.c (serial_open, serial_configure): Move decls from here ...
4473 * systty.h: ... to here, so that they can be checked.
4475 * fns.c (get_random, seed_random): Move extern decls from here ...
4476 * lisp.h: ... to here, so that they can be checked.
4478 * sysdep.c (reset_io): Now static.
4479 (wait_for_termination_signal): Remove; unused.
4481 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4482 (copy_keymap_item, append_key, push_text_char_description):
4484 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4485 (DENSE_TABLE_SIZE): Remove; unused.
4486 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4487 (describe_map_tree):
4488 Rename locals to avoid shadowing.
4490 * keyboard.c: Declare functions static if they are not used elsewhere.
4491 (echo_char, echo_dash, cmd_error, top_level_2):
4492 (poll_for_input, handle_async_input): Now static.
4493 (read_char, kbd_buffer_get_event, make_lispy_position):
4494 (make_lispy_event, make_lispy_movement, apply_modifiers):
4495 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4496 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4497 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4498 (read_key_sequence, read_char): Mark locals as initialized.
4499 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4501 * keyboard.h (make_ctrl_char): New decl.
4502 (mark_kboards): Move decl here ...
4503 * alloc.c (mark_kboards): ... from here.
4505 * lisp.h (force_auto_save_soon): New decl.
4507 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4508 (DEFINE_DUMMY_FUNCTION): New macro.
4509 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4511 (main): Add casts to avoid warnings
4512 if GCC considers string literals to be constants.
4514 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4516 * dbusbind.c: Pointer signedness fixes.
4517 (xd_signature, xd_append_arg, xd_initialize):
4518 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4519 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4520 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4521 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4523 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4524 if GCC considers string literals to be constants.
4525 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4527 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4529 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4530 (print_preprocess, print_object): New macro to fix last change.
4532 * print.c (print_preprocess): Don't forget font objects.
4534 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4536 * emacs.c (USAGE3): Doc fixes.
4538 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4540 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4543 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4545 * lisp.h (VWindow_system, Qfile_name_history):
4546 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4547 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4548 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4550 * w32select.c: Don't #include "keyboard.h".
4551 (run_protected): Add extern declaration for waiting_for_input.
4553 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4554 * w32console.c (detect_input_pending, read_input_pending)
4555 (encode_terminal_code):
4556 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4557 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4558 (w32_system_caret_y, Qfile_name_history):
4559 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4560 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4561 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4562 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4563 * w32proc.c (Qlocal, report_file_error):
4564 * w32term.c (Vwindow_system, updating_frame):
4565 * w32uniscribe.c (initialized, uniscribe_font_driver):
4566 Remove unneeded extern declarations.
4568 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4570 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4572 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4574 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4575 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4576 These macros can no longer be used for assignment.
4578 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4579 Assign struct members directly, instead of using BUF_BEGV etc.
4580 (record_buffer_markers, fetch_buffer_markers): New functions for
4581 recording and fetching special buffer markers.
4582 (set_buffer_internal_1, set_buffer_temp): Use them.
4584 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4586 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4588 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4589 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4591 * xdisp.c (hscroll_window_tree):
4592 (reconsider_clip_changes): Use PT instead of BUF_PT.
4594 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4596 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4597 $(EMACS_ROOT)/lib/intprops.h.
4599 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4601 Fix more problems found by GCC 4.5.2's static checks.
4603 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4604 to unsigned char * to avoid compiler diagnostic.
4605 (xg_free_frame_widgets): Make it clear that a local variable is
4606 needed only if USE_GTK_TOOLTIP.
4607 (gdk_window_get_screen): Make it clear that this macro is needed
4608 only if USE_GTK_TOOLTIP.
4609 (int_gtk_range_get_value): New function, which avoids a diagnostic
4610 from gcc -Wbad-function-cast.
4611 (xg_set_toolkit_scroll_bar_thumb): Use it.
4612 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4613 diagnostic from gcc -Wbad-function-cast.
4614 (get_utf8_string, xg_get_file_with_chooser):
4615 Rename locals to avoid shadowing.
4616 (create_dialog): Move locals to avoid shadowing.
4618 * xgselect.c (xg_select): Remove unused var.
4620 * image.c (four_corners_best): Mark locals as initialized.
4621 (gif_load): Initialize transparent_p to zero (Bug#8238).
4622 Mark another local as initialized.
4623 (my_png_error, my_error_exit): Mark with NO_RETURN.
4625 * image.c (clear_image_cache): Now static.
4626 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4627 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4628 (x_edge_detection): Remove unnecessary cast that
4629 gcc -Wbad-function-cast diagnoses.
4630 (gif_load): Fix pointer signedness.
4631 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4632 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4634 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4636 Improve quality of tests for time stamp overflow.
4637 For example, without this patch (encode-time 0 0 0 1 1
4638 1152921504606846976) returns the obviously-bogus value (-948597
4639 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4640 reports time overflow. See
4641 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4642 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4643 * editfns.c: Include limits.h and intprops.h.
4644 (TIME_T_MIN, TIME_T_MAX): New macros.
4645 (time_overflow): Move earlier, to before first use.
4646 (hi_time, lo_time): New functions, for an accurate test for
4648 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4649 (Fget_internal_run_time): Don't assume time_t fits in int.
4650 (make_time): Use list2 instead of Fcons twice.
4651 (Fdecode_time): More accurate test for out-of-range times.
4652 (check_tm_member): New function.
4653 (Fencode_time): Use it, to test for out-of-range times.
4654 (lisp_time_argument): Don't rely on undefined left-shift and
4655 right-shift behavior when checking for time stamp overflow.
4657 * editfns.c (time_overflow): New function, refactoring common code.
4658 (Fformat_time_string, Fdecode_time, Fencode_time):
4659 (Fcurrent_time_string): Use it.
4661 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4662 * dired.c (make_time): Move to ...
4663 * editfns.c (make_time): ... here.
4664 * systime.h: Note the move.
4666 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4668 * fringe.c (update_window_fringes): Remove unused variables.
4670 * unexmacosx.c (copy_data_segment): Also copy __got section.
4673 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4675 * termcap.c [MSDOS]: Include "msdos.h".
4676 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4677 Constify `char *' arguments and their references according to
4678 prototypes in tparam.h.
4680 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4682 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4683 Adapt all references accordingly.
4685 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4687 2011-03-11 Tom Tromey <tromey@redhat.com>
4689 * buffer.c (syms_of_buffer): Remove obsolete comment.
4691 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4693 * termhooks.h (encode_terminal_code): Declare prototype.
4695 * msdos.c (encode_terminal_code): Don't declare prototype.
4697 * term.c (encode_terminal_code): Now external again, used by
4698 w32console.c and msdos.c.
4700 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4701 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4703 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4705 Fix some minor problems found by GCC 4.5.2's static checks.
4707 * fringe.c (update_window_fringes): Mark locals as initialized
4709 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4711 * alloc.c (mark_fringe_data): Move decl from here ...
4712 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4713 to check its interface.
4714 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4716 * fontset.c (free_realized_fontset): Now static.
4717 (Fset_fontset_font): Rename local to avoid shadowing.
4718 (fontset_font): Mark local as initialized.
4719 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4721 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4723 * xselect.c (x_disown_buffer_selections): Remove; not used.
4724 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4725 (x_own_selection, Fx_disown_selection_internal): Rename locals
4727 (x_handle_dnd_message): Remove local to avoid shadowing.
4729 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4730 so that the caller can use some name other than gcpro1.
4731 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4732 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4733 (Fx_backspace_delete_keys_p):
4734 Use them to avoid shadowing, and rename vars to avoid shadowing.
4735 (x_decode_color, x_set_name, x_window): Now static.
4736 (Fx_create_frame): Add braces to silence GCC warning.
4737 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4738 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4739 Remove unused locals.
4740 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4741 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4742 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4745 * xterm.h (x_mouse_leave): New decl.
4747 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4748 Remove unused functions.
4749 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4750 (x_calc_absolute_position): Now static.
4751 (XTread_socket): Don't define label "out" unless it's used.
4752 Don't declare local "event" unless it's used.
4753 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4754 unless they are used.
4755 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4756 (x_fatal_error_signal): Remove; not used.
4757 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4758 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4759 (x_error_catcher, x_connection_closed, x_error_handler):
4760 (x_error_quitter, xembed_send_message, x_iconify_frame):
4761 (my_log_handler): Rename locals to avoid shadowing.
4762 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4763 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4765 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4766 Rename or move locals to avoid shadowing.
4767 (tty_defined_color, merge_face_heights): Now static.
4768 (free_realized_faces_for_fontset): Remove; not used.
4769 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4770 does not deduce is never used uninitialized.
4771 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4772 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4774 * terminal.c (store_terminal_param): Now static.
4776 * xmenu.c (menu_highlight_callback): Now static.
4777 (set_frame_menubar): Remove unused local.
4778 (xmenu_show): Rename parameter to avoid shadowing.
4779 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4780 since they might point to immutable storage.
4781 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4782 since it's unused otherwise.
4784 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4785 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4786 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4787 avoids a gcc -Wuninitialized diagnostic.
4788 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4789 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4790 does not deduce are never used uninitialized.
4792 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4794 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4795 * window.c (window_loop, size_window):
4796 (run_window_configuration_change_hook, enlarge_window): Likewise.
4798 * window.c (display_buffer): Now static.
4799 (size_window): Mark variables that gcc -Wuninitialized
4800 does not deduce are never used uninitialized.
4801 * window.h (check_all_windows): New decl, to forestall
4802 gcc -Wmissing-prototypes diagnostic.
4803 * dispextern.h (bidi_dump_cached_states): Likewise.
4805 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4807 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4809 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4810 and to avoid gcc -Wuninitialized warning.
4811 (load_charset_map): Mark variables that gcc -Wuninitialized
4812 does not deduce are never used uninitialized.
4813 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4815 * coding.c (coding_set_source, coding_set_destination):
4816 Use "else { /* comment */ }" rather than "else /* comment */;"
4817 for clarity, and to avoid gcc -Wempty-body warning.
4818 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4819 a block, when the outer 'i' will do.
4820 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4821 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4822 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4823 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4824 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4825 Rename locals to avoid shadowing.
4826 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4827 * coding.c (emacs_mule_char, encode_invocation_designation):
4828 Now static, since they're not used elsewhere.
4829 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4830 (decode_coding_object, encode_coding_object, detect_coding_system):
4831 (decode_coding_emacs_mule): Mark variables that gcc
4832 -Wuninitialized does not deduce are never used uninitialized.
4833 (detect_coding_iso_2022): Initialize a local variable that might
4834 be used uninitialized. Leave a FIXME because it's not clear that
4835 this initialization is needed. (Bug#8211)
4836 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4837 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4838 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4839 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4840 Remove unused macros.
4842 * category.c (hash_get_category_set): Remove unused local var.
4843 (copy_category_table): Now static, since it's not used elsewhere.
4844 * character.c (string_count_byte8): Likewise.
4846 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4847 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4849 * chartab.c (copy_sub_char_table): Now static, since it's not used
4851 (sub_char_table_ref_and_range, char_table_ref_and_range):
4852 Rename locals to avoid shadowing.
4853 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4855 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4856 (BIDI_BOB): Remove unused macro.
4858 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4859 deduce are never used uninitialized.
4860 * term.c (encode_terminal_code): Likewise.
4862 * term.c (encode_terminal_code): Now static. Remove unused local.
4864 * tparam.h: New file.
4865 * term.c, tparam.h: Include it.
4866 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4867 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4868 Move these decls to tparam.h, and make them agree with what
4869 is actually in tparam.c. The previous trick of using incompatible
4870 decls in different modules does not conform to the C standard.
4871 All callers of tparam changed to use tparam's actual API.
4872 * tparam.c (tparam1, tparam, tgoto):
4873 Use const pointers where appropriate.
4875 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4876 * cm.h (struct cm): Likewise.
4877 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4878 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4879 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4880 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4881 (turn_on_face, init_tty): Likewise.
4882 * termchar.h (struct tty_display_info): Likewise.
4884 * term.c (term_mouse_position): Rename local to avoid shadowing.
4886 * alloc.c (mark_ttys): Move decl from here ...
4887 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4889 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4891 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4893 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4895 * search.c (compile_pattern_1): Remove argument regp, unused since
4896 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4897 (compile_pattern): Don't pass it.
4899 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4901 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4902 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4904 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4906 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4908 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4909 gdk_window_get_screen, gdk_window_get_geometry,
4910 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4911 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4912 (xg_get_pixbuf_from_pixmap): New function.
4913 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4914 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4915 Call xg_get_pixbuf_from_pixmap instead of
4916 gdk_pixbuf_get_from_drawable.
4917 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4918 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4919 (xg_check_special_colors): Use GtkStyleContext and its functions
4921 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4922 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4923 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4924 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4925 Call gtk_widget_get_preferred_size.
4926 (xg_frame_resized): gdk_window_get_geometry only takes 5
4928 (xg_win_to_widget, xg_event_is_for_menubar):
4929 Call gdk_x11_window_lookup_for_display.
4930 (xg_set_widget_bg): New function.
4931 (delete_cb): New function.
4932 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4933 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4934 (xg_set_background_color): Call xg_set_widget_bg.
4935 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4936 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4937 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4938 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4940 (update_frame_tool_bar): Call gtk_widget_hide.
4941 (xg_initialize): Use GDK_KEY_g.
4943 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4945 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4947 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4948 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4949 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4951 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4953 * w32xfns.c (select_palette): Check success of RealizePalette against
4954 GDI_ERROR, not zero.
4956 See ChangeLog.11 for earlier changes.
4962 Copyright (C) 2011 Free Software Foundation, Inc.
4964 This file is part of GNU Emacs.
4966 GNU Emacs is free software: you can redistribute it and/or modify
4967 it under the terms of the GNU General Public License as published by
4968 the Free Software Foundation, either version 3 of the License, or
4969 (at your option) any later version.
4971 GNU Emacs is distributed in the hope that it will be useful,
4972 but WITHOUT ANY WARRANTY; without even the implied warranty of
4973 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4974 GNU General Public License for more details.
4976 You should have received a copy of the GNU General Public License
4977 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.