1 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3 * nsterm.m (openFiles): Fix previous checkin.
5 2012-07-31 Paul Eggert <eggert@cs.ucla.edu>
7 * indent.c (compute_motion): Remove unused local.
9 2012-07-31 Glenn Morris <rgm@gnu.org>
11 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
13 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
14 * s/irix6-5.h: Remove file.
16 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
17 * s/darwin.h: Remove file.
19 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
20 * s/hpux10-20.h: Remove file, which is now empty.
22 2012-07-30 Glenn Morris <rgm@gnu.org>
24 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
25 * Makefile.in (config_h): Add conf_post.h.
26 * makefile.w32-in (CONFIG_H): Add conf_post.h.
28 2012-07-30 Jan Djärv <jan.h.d@swipnet.se>
30 * nsterm.m (ns_do_open_file): New variable.
31 (ns_term_init): Set ns_do_open_file to NO after run returns.
32 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
33 files only if ns_do_open_file.
35 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
37 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
38 This no-op macro hasn't been needed for many years.
39 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
41 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
42 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
43 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
44 gdb_make_enums_visible.
45 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
46 (DIRECTORY_SEP): Now a constant, not a macro.
48 2012-07-30 Eli Zaretskii <eliz@gnu.org>
50 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
51 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
53 * w32term.c <w32_keyboard_codepage>: Renamed from
54 keyboard_codepage and now external. All users changed.
56 * w32term.h: Add declaration of w32_keyboard_codepage.
58 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
59 the codepage to translate keys to Unicode. If this argument is
60 -1, use the value returned by GetConsoleCP. All callers changed.
62 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
64 Update .PHONY listings in makefiles.
65 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
66 bootstrap-clean, distclean, maintainer-clean, versioclean,
69 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
70 This is a bit clearer. Fix some commentary typos.
72 2012-07-30 Glenn Morris <rgm@gnu.org>
74 * s/netbsd.h: Let configure include signal.h if needed.
75 Remove file, which is now empty.
77 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
78 Let configure set them.
79 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
80 No more need to undefine.
82 2012-07-30 Andreas Schwab <schwab@linux-m68k.org>
84 * keymap.c (Fkey_description): Don't remove 0x80 bit from
85 non-single-byte char when adding meta modifier. (Bug#12090)
87 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
89 Convert safe_call to use variable number of arguments.
90 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
91 (safe_call2): Fix comment.
92 * lisp.h (safe_call): Adjust prototype.
93 * coding.c (encode_coding_object): Change to use safe_call2.
94 * xfaces.c (merge_face_heights): Change to use safe_call1.
96 2012-07-30 Glenn Morris <rgm@gnu.org>
98 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
99 does that unconditionally. Remove file, which is now empty.
101 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
104 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
106 Export to GDB most of lisp.h's remaining object-like macros.
107 * lisp.h (min, max): Move earlier, because they're used earlier now.
108 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
109 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
110 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
111 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
112 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
113 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
114 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
115 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
116 Now constants, for GDB. They need not be macros.
117 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
118 Now constants, for GDB, as well as macros, for static initializers.
119 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
120 Move to after the definition of struct Lisp_Char_Table,
121 since the former now needs that type defined.
122 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
123 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
124 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
125 New enums, for gdb_make_enums_visible.
126 (GLYPH_MODE_LINE_FACE): Remove; unused.
127 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
128 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
129 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
130 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
131 enum maxargs, enum MAX_ALLOCA.
132 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
133 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
134 no longer needed, now that they are done in lisp.h.
136 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
138 Cleanup string bytes checking.
139 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
140 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
141 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
142 (check_sblock, compact_small_strings): Simplify.
144 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
146 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
147 These macros are confusing and no longer need to be defined, as
148 the enum values now suffice. All uses replaced with definiens.
149 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
151 2012-07-29 Juanma Barranquero <lekktu@gmail.com>
153 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
154 ($(BLD)/w32console.$(O)): Update dependencies.
156 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
158 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
159 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
161 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
163 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
165 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
166 setting sitelisp (Bug#12010).
168 2012-07-29 Eli Zaretskii <eliz@gnu.org>
170 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
172 * w32heap.c (cache_system_info):
173 * w32.c (sys_rename):
174 * w32proc.c (find_child_console, sys_kill): All users changed.
176 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
178 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
180 2012-07-29 Eli Zaretskii <eliz@gnu.org>
182 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
184 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
186 Cleanup statistics calculation in Fgarbage_collect.
187 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
188 zombies percentage calculation. Simplify elapsed time calculation.
190 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
192 Generalize marker debugging code under MARKER_DEBUG and use eassert.
193 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
194 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
195 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
196 (replace_range, replace_range_2, del_range_2): Change to eassert.
197 * marker.c (byte_char_debug_check): Adjust style.
199 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
201 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
202 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
203 long-ago-commented-out code that talks about "WIN32".
204 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
207 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
209 Use Gnulib stdalign module (Bug#9772, Bug#9960).
210 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
211 Simplify by using alignof.
212 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
213 * lisp.h: Include <stdalign.h>.
214 (GCALIGNMENT): New macro and constant.
215 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
216 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
217 (stdalign): New macro, if not already defined.
219 2012-07-28 Eli Zaretskii <eliz@gnu.org>
221 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
222 * w32inevt.c: Include w32inevt.h.
223 (w32_read_console_input): New inline function, calls either
224 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
225 w32_console_unicode_input.
226 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
227 (w32_kbd_patch_key, key_event): Use the codepage returned by
228 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
229 (key_event): use uChar.UnicodeChar only if
230 w32_console_unicode_input is non-zero.
232 * w32console.c: Include w32heap.h.
233 <w32_console_unicode_input>: New global variable.
234 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
235 family of Windows, zero otherwise.
237 * w32inevt.h: Declare w32_console_unicode_input.
239 * xdisp.c (init_iterator): Don't reference tip_frame in a build
240 --without-x. (Bug#11742)
242 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
244 Adjust GDB to reflect pvec_type changes (Bug#12036).
245 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
246 2012-07-04 changes to pseudovector representation. Problem
247 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
249 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
251 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
253 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
255 2012-07-27 Eli Zaretskii <eliz@gnu.org>
257 * alloc.c (listn): Fix the order the arguments are consed onto the
260 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
261 enumeration constants, as PURE and HEAP are too general, and clash
262 with other headers and sources, such as gmalloc.c and the
263 MS-Windows system headers. All users changed.
265 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
267 Revert last save_excursion_save and save_excursion_restore changes.
268 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
269 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
271 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
273 Fix recently-introduced typos in Windows port.
274 Reported by Martin Rudalics <rudalics@gmx.at>.
275 * w32.c (init_environment): Replace comma with semicolon.
276 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
278 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
280 Improve GDB symbol export (Bug#12036).
281 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
282 arms of an 'if', not using conditional expressions; otherwise GDB
283 complains about the types in the unevaluated arm when the argument
284 is an integer literal.
285 (xgetint): Simplify expression.
286 * alloc.c (gdb_make_enums_visible): New constant. This ports to
287 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
288 Zaretskii in <http://bugs.gnu.org/12036#13>.
289 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
290 needed now that we have gdb_make_enums_visible.
291 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
292 (enum enum_USE_LSB_TAG):
293 New enum types, packaging up enums that need to be exported to GDB.
295 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
297 Utility function to make a list from specified amount of objects.
298 * lisp.h (enum constype): New datatype.
299 (listn): New prototype.
300 * alloc.c (listn): New function.
301 (Fmemory_use_count, syms_of_alloc): Use it.
302 * buffer.c (syms_of_buffer): Likewise.
303 * callint.c (syms_of_callint): Likewise.
304 * charset.c (define_charset_internal): Likewise.
305 * coding.c (syms_of_coding): Likewise.
306 * keymap.c (syms_of_keymap): Likewise.
307 * search.c (syms_of_search): Likewise.
308 * syntax.c (syms_of_syntax): Likewise.
309 * w32.c (init_environment): Likewise.
310 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
311 * xdisp.c (syms_of_xdisp): Likewise.
312 * xfns.c (syms_of_xfns): Likewise.
314 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
316 Fast save_excursion_save and save_excursion_restore.
317 * lisp.h (struct Lisp_Excursion): New data type.
318 (PVEC_EXCURSION): New pseudovector type.
319 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
320 to deal with it. Adjust comments.
321 (init_marker, attach_marker): New prototype.
322 (unchain_marker): Adjust prototype.
323 * marker.c (attach_marker): Change to global.
324 (init_marker): New function.
325 * alloc.c (Fmake_marker, build_marker): Use it.
326 (build_marker): More easserts.
327 (mark_object): Handle struct Lisp_Excursion.
328 * editfns.c (save_excursion_save, save_excursion_restore):
329 Reimplement to use struct Lisp_Excursion. Add comments.
331 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
333 Fix export of symbols to GDB (Bug#12036).
334 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
335 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
336 emacs.c, as this is a more-suitable home. Had this been done earlier
337 the fix for 12036 would have avoided some of the problems noted in
338 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
339 would have been more obvious.
340 * emacs.c: Do not include <verify.h>; no longer needed.
341 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
342 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
343 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
344 Remove; now done in lisp.h.
345 * lisp.h (PUBLISH_TO_GDB): New macro.
346 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
347 (DATA_SEG_BITS): Use it.
348 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
349 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
350 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
351 not be usable in #if. This simplifies things.
353 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
355 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
357 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
359 Simplify export of symbols to GDB (Bug#12036).
360 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
361 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
362 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
363 Adjust to changes in lisp.h and emacs.c, by using
364 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
365 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
366 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
367 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
368 instead of gdb_valbits.
369 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
370 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
371 instead of gdb_array_mark_flag.
372 (xboolvector): Get size from $->size, not $->header.size.
373 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
374 (xreload, hook-run, hookpost-run): Remove.
375 * emacs.c: Include <verify.h>.
376 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
377 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
379 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
380 (gdb_USE_LSB_TAG): New enum constants.
381 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
382 Also define these as enum constants, so they're visible to GDB.
383 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
384 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
385 as constants, so they're visible to GDB.
386 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
387 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
388 Now enum constants, not macros, so they're visible to GDB.
389 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
390 more convenient now. All uses changed.
391 (VALMASK) [USE_LSB_TAG]: Also define in this case.
392 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
394 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
396 Explicitly free restriction data that are not needed anymore.
397 * editfns.c (save_restriction_restore): Free restriction data.
399 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
401 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
402 add argument, tune behavior, and adjust all callers.
404 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
406 Use typedef for EMACS_INT, EMACS_UINT.
407 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
408 than macros. This simplifies debugging in the usual case, since
409 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
410 and it allows expressions involving EMACS_INT casts.
411 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
413 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
415 * nsterm.m (ns_read_socket): Return early if there is a modal
418 2012-07-25 Martin Rudalics <rudalics@gmx.at>
420 * frame.c (Fredirect_frame_focus): In doc-string don't mention
421 that FOCUS-FRAME can be omitted.
423 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
425 Adjust buffer text indirection counters at the end of Fkill_buffer.
426 * buffer.c (Fkill_buffer): Adjust indirection counters when the
427 buffer is definitely dead. This should really fix an issue reported
428 by Christoph Scholtes again. (Bug#12007).
429 (init_buffer_once): Initialize indirection counters of
430 buffer_defaults and buffer_local_symbols (for sanity and safety).
432 2012-07-24 Eli Zaretskii <eliz@gnu.org>
434 * xdisp.c (init_iterator): Don't compute dimensions of truncation
435 and continuation glyphs on tooltip frames, leave them at zero.
436 Avoids continued lines in tooltips. (Bug#11832)
438 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
440 Simplify copy_overlay.
441 * buffer.c (copy_overlay): Simplify. Use build_marker.
442 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
444 2012-07-23 Eli Zaretskii <eliz@gnu.org>
446 * print.c (print_object): Don't crash when a frame's name is nil
447 or invalid. (Bug#12025)
449 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
450 it signals an error when a tooltip frame is being created.
452 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
454 Cleanup miscellaneous objects allocation and initialization.
455 * alloc.c (allocate_misc): Change to static. Add argument to
456 specify the subtype. Adjust comment and users.
457 (build_overlay): New function.
458 * buffer.c (copy_overlays, Fmake_overlay): Use it.
459 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
460 (allocate_misc): Remove prototype.
461 (build_overlay): Add prototype.
463 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
465 Swap buffer text indirection counters in Fbuffer_swap_text.
466 * buffer.c (Fbuffer_swap_text): Swap indirections too.
467 This avoids crash reported by Christoph Scholtes at
468 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
470 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
472 * nsmenu.m (Popdown_data): New struct.
473 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
475 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
476 (initWithContentRect): Make imgView and contentView non-static
477 and autorelease them. Also autorelease img and matrix (Bug#12005).
478 (dealloc): Remove (Bug#12005).
480 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
482 Adjust consing_since_gc when objects are explicitly freed.
483 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
484 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
485 (free_cons, free_misc): Subtract object size from consing_since_gc.
487 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
489 Simplify and cleanup markers positioning code.
490 * marker.c (attach_marker): More useful eassert.
491 (live_buffer, set_marker_internal): New function.
492 (Fset_marker, set_marker_restricted): Use set_marker_internal.
493 (set_marker_both, set_marker_restricted_both): Use live_buffer.
495 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
497 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
498 as it's limited by the amount of memory, not by INT_MAX.
500 2012-07-21 Eli Zaretskii <eliz@gnu.org>
502 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
503 in special-event-map. See the discussion at
504 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
507 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
508 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
509 Fabrice Popineau <fabrice.popineau@supelec.fr>.
511 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
513 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
514 (conversationIdentifier): Return value is NSInteger.
515 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
517 2012-07-21 Chong Yidong <cyd@gnu.org>
519 * window.c (decode_any_window): Signal an error if the window is
520 on a dead frame (Bug#11984).
522 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
524 Add indirection counting to speed up Fkill_buffer.
525 * buffer.h (struct buffer): New member.
526 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
527 (Fmake_indirect_buffer): Set indirection counter to -1, increment
528 base buffer indirection counter.
529 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
530 (Fkill_buffer): Adjust indirection counters as needed, don't walk
531 through buffer list if indirection counter is 0.
533 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
535 Extend the value returned by Fgarbage_collect with heap statistics.
536 * alloc.c (Qheap): New symbol.
537 (syms_of_alloc): DEFSYM it.
538 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
539 (Fmemory_free): Remove.
540 (syms_of_alloc): Don't defsubr it.
541 * buffer.c (Fcompact_buffer): Remove.
542 (syms_of_buffer): Don't defsubr it.
544 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
546 Make maybe_gc inline.
547 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
548 * lisp.h (consing_since_gc, gc_relative_threshold)
549 (memory_full_cons_threshold): Revert declaration.
550 (maybe_gc): Remove prototype, define as inline.
551 * alloc.c: Remove old commented-out code.
552 (consing_since_gc, gc_relative_threshold)
553 (memory_full_cons_threshold): Revert to global.
556 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
558 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
559 * lisp.h (build_unibyte_string): New function.
560 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
561 * sysdep.c, w32fns.c, xfns.c: Use it.
562 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
563 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
564 Adjust users accordingly.
565 * font.h (font_open_by_name): Adjust prototype.
567 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
569 Cleanup calls to Fgarbage_collect.
570 * lisp.h (maybe_gc): New prototype.
571 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
573 * alloc.c (maybe_gc): New function.
574 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
576 * bytecode.c (MAYBE_GC): Use maybe_gc.
577 * eval.c (eval_sub, Ffuncall): Likewise.
578 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
579 to avoid dependency from auto-save feature.
581 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
583 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
584 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
585 'for_each_per_buffer_object_at'.
586 All uses changed. It's better to use upper-case for macros that
587 cannot be implemented as functions, to give the reader a clue
588 that they're special.
590 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
592 * alloc.c (Fgarbage_collect): Tweak docstring.
594 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
596 Tweak the value returned from Fgarbage_collect again.
597 * alloc.c (Fgarbage_collect): New return value, as confirmed in
598 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
599 Adjust documentation.
600 (total_vector_bytes): Rename to total_vector_slots, adjust
602 (total_free_vector_bytes): Rename to total_free_vector_slots,
604 (Qstring_bytes, Qvector_slots): New symbols.
605 (syms_of_alloc): DEFSYM them.
607 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
609 Buffer compaction primitive which may be used from Lisp.
610 * buffer.c (compact_buffer, Fcompact_buffer): New function.
611 (syms_of_buffer): Register Fcompact_buffer.
612 * alloc.c (Fgarbage_collect): Use compact_buffer.
613 * buffer.h (compact_buffer): New prototype.
614 (struct buffer_text): New member.
616 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
618 New macro to iterate over all buffers, miscellaneous cleanups.
619 * lisp.h (all_buffers): Remove declaration.
620 * buffer.h (all_buffers): Add declaration, with comment.
621 (for_each_buffer): New macro.
622 * alloc.c (Fgarbage_collect, mark_object): Use it.
623 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
624 (init_buffer): Likewise.
625 * data.c (Fset_default): Likewise.
626 * coding.c (code_conversion_restore): Remove redundant check
628 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
630 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
632 Fix bug that created negative-length intervals.
633 * intervals.c (merge_interval_right, merge_interval_left):
634 Do not zero out this interval if it is absorbed by its children,
635 as this interval's total length doesn't change in that case. See
636 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
638 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
640 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
641 when invoking (make-bool-vector N t) and N is a positive
642 multiple of 8 -- the last 8 bits were mistakenly cleared.
644 Remove some struct layout assumptions in bool vectors.
645 * alloc.c (bool_header_size): New constant.
646 (header_size, word_size): Move earlier, as they're now used earlier.
647 Use 'word_size' in a few more places, where it's appropriate.
648 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
649 padding before the data member of a bool vector.
650 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
651 than doing the check by hand with an abort ().
653 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
655 * eval.c (Fdefvar): Don't check constants since we only set the var if
656 it's not yet defined anyway (bug#11904).
658 * lisp.h (last_undo_boundary): Declare new var.
659 * keyboard.c (command_loop_1): Set it.
660 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
661 were auto-added by the command loop (bug#11774).
663 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
665 * w32font.c (Qsymbol): Remove local definition.
666 (syms_of_w32font): Don't DEFSYM it.
668 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
670 Fix sweep_vectors to handle large bool vectors correctly.
671 * alloc.c (sweep_vectors): Account total_vector_bytes for
672 bool vectors larger than VBLOCK_BYTES_MAX.
674 2012-07-18 Chong Yidong <cyd@gnu.org>
676 * frame.c (x_set_frame_parameters): Revert bogus change introduced
677 in 2012-05-25 commit by Paul Eggert (Bug#11738).
679 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
681 Return more descriptive data from Fgarbage_collect.
682 Suggested by Stefan Monnier in
683 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
684 * alloc.c (bounded_number): New function.
685 (total_buffers, total_vectors): New variable.
686 (total_string_size): Rename to total_string_bytes, adjust users.
687 (total_vector_size): Rename to total_vector_bytes, adjust users.
688 (sweep_vectors): Account total_vectors and total_vector_bytes.
689 (Fgarbage_collect): New return value. Adjust documentation.
690 (gc_sweep): Account total_buffers.
691 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
692 (VECTOR_SIZE): Remove.
693 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
694 (Qinterval, Qmisc): New symbols.
695 (syms_of_data): Initialize them.
696 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
697 (Qcons, Qbuffer): New declarations.
699 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
701 * alloc.c (Fmemory_free): Account for memory-free's own storage.
702 Round up, not down. Improve doc.
704 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
706 Restore old code in allocate_string_data to avoid Faset breakage.
707 Reported by Julien Danjou <julien@danjou.info> in
708 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
709 * alloc.c (allocate_string_data): Restore old code with minor
710 adjustments, fix comment to explain this subtle issue.
712 2012-07-17 Eli Zaretskii <eliz@gnu.org>
714 Remove FILE_SYSTEM_CASE.
715 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
717 * fileio.c (FILE_SYSTEM_CASE): Don't define.
718 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
719 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
720 call-process-region passes it through expand-file-name.
722 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
724 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
726 Fix crash when creating indirect buffer (Bug#11917)
727 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
728 Don't handle unbound variables specially if non-zero.
729 (Fbuffer_local_variables): Pass zero.
730 (clone_per_buffer_values): Pass non-zero.
732 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
734 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
735 to make the loop interruptible.
737 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
739 * gnutls.c (emacs_gnutls_handshake): Only retry if
740 GNUTLS_E_INTERRUPTED.
742 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
744 Cleanup and convert miscellaneous checks to eassert.
745 * alloc.c (mark_interval): Fix comment, partially rephrase
746 old comment from intervals.h (see below).
747 * intervals.c (find_interval, adjust_intervals_for_insertion)
748 (delete_interval, adjust_intervals_for_deletion)
749 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
751 (adjust_intervals_for_insertion, make_new_interval):
752 Remove obsolete and unused code.
753 * intervals.h (struct interval): Remove obsolete comment.
754 * textprotp.c (erase_properties): Remove unused code.
755 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
756 (Fremove_list_of_text_properties): Convert to eassert.
758 2012-07-17 Chong Yidong <cyd@gnu.org>
760 * editfns.c (Finsert_char): Doc fix.
762 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
764 Fix previous change to make Fmemory_free always accurate.
765 * alloc.c (make_interval): Update total_free_intervals.
766 (make_float): Likewise for total_free_floats.
767 (free_cons, Fcons): Likewise for total_free_conses.
768 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
769 Likewise for total_free_vector_bytes.
770 (Fmake_symbol): Likewise for total_free_symbols.
771 (bytes_free): Remove.
773 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
775 Simple free memory accounting feature.
776 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
777 (sweep_vectors): Accumulate size of free vectors.
778 (Fgarbage_collect): Setup bytes_free.
779 (Fmemory_free): New function.
780 (syms_of_alloc): Register it.
782 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
784 Cleanup overlays checking.
785 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
786 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
787 eassert and OVERLAYP.
788 (sort_overlays): Change to use OVERLAYP.
790 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
792 * editfns.c (Finsert_char): Make it interactive, and make the
793 second arg optional. Copy interactive spec and docstring from
796 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
798 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
799 Unlike the other wrapped functions, fabs has an unspecified
802 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
804 * nsterm.m (keyDown): Interpret flags without left/right bits
805 as the left key (Bug#11670).
807 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
809 Remove empty and useless init functions.
810 * lisp.h (init_character_once, init_fns, init_image)
811 (init_filelock, init_sound): Remove prototype.
812 * character.c (init_character_once): Remove.
813 * filelock.c (init_filelock): Likewise.
814 * fns.c (init_fns): Likewise.
815 * image.c (init_image): Likewise.
816 * sound.c (init_sound): Likewise.
817 * emacs.c (main): Adjust accordingly.
819 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
821 * gtkutil.h: Tiny cleanups.
822 (use_old_gtk_file_dialog): Remove useless declaration.
823 (xg_uses_old_file_dialog): Add suggested const attribute.
825 2012-07-15 Eli Zaretskii <eliz@gnu.org>
827 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
828 (bidi_paragraph_init): Use it to limit search forward for a strong
829 directional character in abnormally large paragraphs full of
830 neutral or weak characters. (Bug#11943)
832 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
834 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
835 the toolbar (Bug#9451).
836 (xg_make_tool_item): Give the widget event box a transparent
839 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
841 Cleanup basic allocation variables and functions.
842 * alloc.c (ignore_warnings, init_intervals, init_float)
843 (init_cons, init_symbol, init_marker): Remove.
844 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
845 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
846 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
847 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
848 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
849 (staticidx, init_alloc_once, init_strings, free_ablock):
850 Remove redundant initialization.
851 * fns.c (init_weak_hash_tables): Remove.
852 * lisp.h (init_weak_hash_tables): Remove prototype.
854 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
856 Use zero_vector where appropriate.
857 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
859 * lisp.h (zero_vector): New declaration.
860 * font.c (null_vector): Remove.
861 (syms_of_font): Remove initialization and staticpro.
862 (font_list_entities, font_find_for_lface): Change to use zero_vector.
863 * keymap.c (Faccessible_keymaps): Likewise.
865 2012-07-15 Leo Liu <sdl.web@gmail.com>
867 * fringe.c: Fix typo in comments.
869 2012-07-14 Leo Liu <sdl.web@gmail.com>
871 * fringe.c: Add a new bitmap exclamation-mark.
873 2012-07-14 Eli Zaretskii <eliz@gnu.org>
875 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
877 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
878 (HAVE_MENUS): Don't define, defined by editing config.in with
880 (GMALLOC_INHIBIT_VALLOC): Don't define.
881 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
883 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
885 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
887 2012-07-14 Glenn Morris <rgm@gnu.org>
889 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
890 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
891 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
893 2012-07-13 Glenn Morris <rgm@gnu.org>
895 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
897 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
898 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
900 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
902 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
903 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
904 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
905 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
907 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
908 as boolean expression.
909 (x_set_window_size): Remove unused variable toolbar.
910 (ns_get_color_default, ns_mod_to_lisp): Remove.
911 (ns_mouse_position): Remove unused variables xchar and ychar.
912 (ns_compute_glyph_string_overhangs): Remove unused variable face.
913 (ns_set_vertical_scroll_bar): Remove unused variable count.
914 (ns_delete_terminal): Remove unused variable i.
915 (ns_term_init): Remove unused variables r, g and b.
916 (mouseDown): Remove unused variable window.
917 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
918 (initFrameFromEmacs): Remove unused variable vbextra.
919 (mouseEntered): Remove unused variables p and dpyinfo.
920 (mouseExited): Remove unused variables p and r.
921 (ns_define_frame_cursor, ns_clear_frame_area)
922 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
923 (menuDown): Assign [sender tag] to variable and cast the variable.
925 * nsterm.h (menuDown): Add id as type to argument sender.
926 (ns_display_info_for_name): Add Lisp_Object argument.
927 (ns_term_init): Add Lisp_Object argument.
928 (ns_map_event_to_object): Add void argument.
929 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
930 prototype with arguments and only declare if __OBJC__.
931 (nxatoms_of_nsselect): Add void argument.
932 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
933 (ns_alloc_autorelease_pool): Add void argument.
934 (ns_release_autorelease_pool): Add void* argument.
935 (ns_get_defaults_value): Add const char* argument.
937 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
938 (initFromContents): Use SSDATA where appropriate.
939 (ns_update_menubar): Add braces to ambigous if-else.
940 (initWithTitle): Put () around assignment in if statement.
941 (ns_menu_show): Remove unused variables window and keymap.
942 (update_frame_tool_bar): Remove unused variable selected_p.
943 (initWithContentRect): Remove unused variable this_cmd_name.
945 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
947 (setXBMColor): Remove unused variable len.
948 (setPixmapData): Put () around assignment in loop statement.
950 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
951 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
953 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
954 around assignment in loop statement.
955 (nsfont_open): Remove unused variable i.
956 (nsfont_open): Remove unused variable len.
957 (nsfont_draw): Remove unused variable cs.
959 * nsfns.m (x_set_icon_name, ns_set_name_internal)
960 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
961 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
962 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
963 (Fns_font_name, Fns_perform_service)
964 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
965 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
966 (ns_set_name): Remove unused variable view.
967 (x_set_menu_bar_lines): Remove unused variable olines.
968 (x_set_tool_bar_lines): Remove unused variable root_window.
969 (Fns_list_colors): Put () around assignment in while statement.
970 (Fns_perform_service): Remove unused variable len.
971 (Fns_display_usable_bounds): Remove unused variable top.
972 (syms_of_nsfns): Remove unused variable i.
974 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
977 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
979 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
980 and free it with DestroyExceptionInfo (Bug#11558).
982 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
984 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
985 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
986 Set here, not in nt/config.nt.
988 2012-07-13 Eli Zaretskii <eliz@gnu.org>
990 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
991 cursor overflow into the last glyph on display line when the right
992 fringe is off. (Bug#11832)
994 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
996 * xdisp.c (produce_special_glyphs): Now static.
997 * dispextern.h (produce_special_glyphs): Remove decl.
999 2012-07-13 Glenn Morris <rgm@gnu.org>
1001 * s/bsd-common, s/cygwin.h: Remove empty files.
1002 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1004 * s/usg5-4-common.h (USG, USG5):
1005 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1006 * s/sol2-6.h (SOLARIS2):
1007 * s/irix6-5.h (IRIX6_5):
1008 * s/hpux10-20.h (USG, USG5, HPUX):
1009 * s/gnu-linux.h (USG, GNU_LINUX):
1010 * s/freebsd.h (BSD_SYSTEM):
1011 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1012 * s/cygwin.h (CYGWIN):
1013 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1014 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1016 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
1018 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
1020 2012-07-13 Glenn Morris <rgm@gnu.org>
1022 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1024 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1026 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1027 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1029 2012-07-12 Glenn Morris <rgm@gnu.org>
1031 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
1033 * process.c (init_process_emacs): Rename from init_process.
1034 The old name is also the name of a Mach system call.
1035 * lisp.h, emacs.c: Update for this name change.
1036 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1039 2012-07-12 Eli Zaretskii <eliz@gnu.org>
1041 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1042 memmove call that removes glyphs covered by the left truncation
1043 glyph. Improve commentary.
1044 (display_line): Fix display of continuation glyphs on GUI frames
1045 when the right fringe is turned off and variable-size fonts are
1046 used in the window. Move the code that appends a stretch glyph to
1047 produce_special_glyphs, so that it could be used for truncation
1048 and continuation glyphs alike.
1049 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1050 glyph of a suitably computed width, to align the special glyphs at
1051 the window margin. Code moved from display_line. (Bug#11832)
1053 2012-07-12 Glenn Morris <rgm@gnu.org>
1055 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1057 * s/gnu-linux.h, s/hpux10-20.h:
1058 Do not unconditionally define HAVE_XRMSETDATABASE.
1060 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1062 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1064 Fix typos that broke OS X build.
1065 Reported by Randal L. Schwartz in
1066 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1067 * nsterm.m (ns_timeout): Add missing local decl.
1068 (ns_get_color): snprintf -> sprintf, to fix typo.
1070 2012-07-12 Glenn Morris <rgm@gnu.org>
1072 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1073 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1074 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1075 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1077 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1078 Move PTY_OPEN to configure.
1080 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1081 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1082 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1084 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1086 Use empty_unibyte_string where applicable.
1087 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1088 * lread.c (read1): Likewise.
1089 * xsettings.c (syms_of_xsettings): Likewise.
1091 2012-07-12 Glenn Morris <rgm@gnu.org>
1093 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1094 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
1095 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1096 * s/hpux10-20.h (RUN_TIME_REMAP):
1097 * s/bsd-common.h (TABDLY): Move to configure.
1099 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1101 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1103 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1104 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
1106 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
1108 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1109 * s/template.h: Move NARROWPROTO to configure.
1111 2012-07-11 Glenn Morris <rgm@gnu.org>
1113 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1114 unused since 2011-01-17 change to systty.h.
1116 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1117 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1118 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1120 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1122 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1124 2012-07-11 Glenn Morris <rgm@gnu.org>
1126 * s/darwin.h, s/gnu-linux.h, s/template.h:
1127 Move INTERRUPT_INPUT to configure.
1129 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1131 Minor adjustments to interning code.
1132 * lisp.h (intern, intern_c_string): Redefine as static inline
1133 wrappers for intern_1 and intern_c_string_1, respectively.
1134 (intern_1, intern_c_string_1): Rename prototypes.
1135 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1137 * font.c (font_intern_prop): Likewise. Adjust comment.
1138 * w32font.c (intern_font_name): Likewise.
1140 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1142 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1144 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1145 of Fcar/Fcdr if possible.
1146 * font.c (check_otf_features): Likewise.
1147 * fontset.c (Fnew_fontset): Likewise.
1148 * gnutls.c (Fgnutls_boot): Likewise.
1149 * minibuf.c (read_minibuf): Likewise.
1150 * msdos.c (IT_set_frame_parameters): Likewise.
1151 * xmenu.c (Fx_popup_dialog): Likewise.
1152 * w32menu.c (Fx_popup_dialog): Likewise.
1154 2012-07-11 Glenn Morris <rgm@gnu.org>
1156 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1157 since nothing has defined it on these platforms.
1159 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1160 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1162 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1163 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1164 Move CLASH_DETECTION to configure.
1166 * s/gnu.h: Remove file, which is now empty.
1168 * s/gnu.h, s/gnu-linux.h:
1169 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1171 2012-07-11 John Wiegley <johnw@newartisans.com>
1173 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1174 function attribute, so we only use it if it exists in the
1177 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1179 Avoid call to strlen in fast_c_string_match_ignore_case.
1180 * search.c (fast_c_string_match_ignore_case): Change to use
1181 length argument. Adjust users accordingly.
1182 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1184 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1186 Assume mkdir, rmdir.
1187 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1188 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1191 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1194 * s/hpux10-20.h (HAVE_PERROR): Remove.
1195 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1196 Remove dummy definition, as this problem was obsolete long ago.
1199 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1201 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1203 Avoid calls to strlen in font processing functions.
1204 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1205 (font_open_by_name): Change to use length argument. Adjust
1207 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1209 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1210 Change to return ptrdiff_t.
1211 (xfont_list_pattern, xfont_match): Use length returned by
1212 xfont_decode_coding_xlfd.
1213 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1215 2012-07-11 Glenn Morris <rgm@gnu.org>
1217 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1218 Move DONT_REOPEN_PTY to configure.
1220 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1221 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1223 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1225 Remove "#define unix" that is no longer needed (Bug#11905).
1226 * s/aix4-2.h (unix): Remove; no longer needed.
1228 EMACS_TIME simplification (Bug#11875).
1229 This replaces macros (which typically do not work in GDB)
1230 with functions, typedefs and enums, making the code easier to debug.
1231 The functional style also makes code easier to read and maintain.
1232 * systime.h: Include <sys/time.h> on all hosts, not just if
1233 WINDOWSNT, since 'struct timeval' is needed in general.
1234 (EMACS_TIME): Now a typedef, not a macro.
1235 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1237 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1238 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1239 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1240 (EMACS_TIME_LE): Now functions, not macros.
1241 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1242 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1243 which are not functions. All uses rewritten to use:
1244 (make_emacs_time): New function.
1245 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1246 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1247 not functions. All uses rewritten to use the following, respectively:
1248 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1249 (add_emacs_time, sub_emacs_time): New functions.
1250 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1251 * fileio.c (Fcopy_file):
1252 * xterm.c (XTflash): Get the current time closer to when it's used.
1253 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1255 * bytecode.c (targets): Suppress -Woverride-init warnings.
1257 Simplify by avoiding confusing use of strncpy etc.
1258 * doc.c (Fsnarf_documentation):
1259 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1260 * frame.c (Fmake_terminal_frame):
1261 * gtkutil.c (get_utf8_string):
1263 * nsmenu.m (ns_update_menubar):
1264 * regex.c (regerror):
1265 Prefer memcpy to strncpy and strncat when either will do.
1266 * fileio.c (Fsubstitute_in_file_name):
1267 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1268 (menu_separator_name_p):
1269 * nsmenu.m (ns_update_menubar):
1270 Prefer memcmp to strncmp when either will do.
1271 * nsterm.m: Include <ftoastr.h>.
1273 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1274 Prefer snprintf to strncpy.
1275 * nsterm.m (ns_term_init):
1276 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1277 * nsterm.m (ns_term_init):
1278 Avoid the need for strncpy, by using build_string or
1279 make_unibyte_string directly. Use dtoastr, not snprintf.
1280 * process.c (Fmake_network_process): Diagnose service names that
1281 are too long, rather than silently truncating them or creating
1282 non-null-terminated names.
1283 (Fnetwork_interface_info): Likewise, for interface names.
1284 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1285 Prefer sprintf to strncat.
1286 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1287 Prefer vsnprintf to vsprintf + strncpy.
1289 2012-07-10 Glenn Morris <rgm@gnu.org>
1291 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1292 Clarify fallback case.
1294 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1296 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1297 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1298 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1299 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1300 where argument type is known to be a Lisp_Cons.
1302 2012-07-10 Tom Tromey <tromey@redhat.com>
1304 * bytecode.c (BYTE_CODE_THREADED): New macro.
1305 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1306 (enum byte_code_op): New type.
1307 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1308 (exec_byte_code): Use them. Use token threading when applicable.
1310 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1312 Optimize pure C strings initialization.
1313 * lisp.h (make_pure_string): Fix prototype.
1314 (build_pure_c_string): New function, defined as static inline. This
1315 provides a better opportunity to optimize away calls to strlen when
1316 the function is called with compile-time constant argument.
1317 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1318 argument, adjust users accordingly. Use build_pure_c_string where
1320 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1321 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1322 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1324 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1326 Avoid calls to strlen in miscellaneous functions.
1327 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1328 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1329 * lread.c (openp): Likewise.
1331 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1333 Avoid calls to strlen in path processing functions.
1334 * fileio.c (file_name_as_directory): Add comment. Change to add
1335 srclen argument and return the length of result. Adjust users
1337 (directory_file_name): Fix comment. Change to add srclen argument,
1338 swap 1st and 2nd arguments to obey the common convention. Adjust
1340 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1342 2012-07-10 Glenn Morris <rgm@gnu.org>
1344 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1345 Move PENDING_OUTPUT_COUNT definition to configure.
1347 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1348 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1349 * s/gnu.h (DATA_START): Move definitions to configure.
1351 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1352 We include usg5-4-common.h, which defines them both.
1354 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1355 O_RDONLY already includes it).
1357 Stop ns builds setting the EMACSLOADPATH environment variable.
1358 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1359 Now it does not set EMACSLOADPATH, just returns the load-path string.
1360 * nsterm.h: Update accordingly.
1361 * lread.c [HAVE_NS]: Include nsterm.h.
1362 (init_lread) [HAVE_NS]: Use ns_load_path.
1363 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1365 2012-07-09 Glenn Morris <rgm@gnu.org>
1367 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1368 since the included bsd-common.h does so.
1370 Stop ns builds setting the EMACSPATH environment variable.
1371 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1372 (ns_init_paths): Do not set EMACSPATH.
1373 * nsterm.h (ns_exec_path): Add it.
1374 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1377 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1379 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1381 * process.c (wait_reading_process_output): 'waitchannels' was unset
1382 when read_kbd || !NILP (wait_for_cell); fix this.
1384 Add GCC-style 'const' attribute to functions that can use it.
1385 * character.h (char_resolve_modifier_mask):
1386 * keyboard.h (make_ctrl_char):
1387 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1388 (init_character_once, next_almost_prime, init_fns, init_image)
1389 (flush_pending_output, init_sound):
1390 * mem-limits.h (start_of_data):
1391 * menu.h (finish_menu_items):
1392 Add ATTRIBUTE_CONST.
1393 * emacs.c (DEFINE_DUMMY_FUNCTION):
1394 Declare the dummy function with ATTRIBUTE_CONST.
1395 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1396 Add decls with ATTRIBUTE_CONST.
1398 Minor improvements to make_formatted_string.
1399 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1400 where int is good enough, as vsprintf returns an int.
1401 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1403 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1405 Use make_formatted_string to avoid double length calculation.
1406 * lisp.h (make_formatted_string): New prototype.
1407 * alloc.c (make_formatted_string): New function.
1408 * buffer.c (Fgenerate_new_buffer_name): Use it.
1409 * dbus.c (syms_of_dbusbind): Likewise.
1410 * editfns.c (Fcurrent_time_zone): Likewise.
1411 * filelock.c (get_boot_time): Likewise.
1412 * frame.c (make_terminal_frame, set_term_frame_name)
1413 (x_report_frame_params): Likewise.
1414 * image.c (gs_load): Likewise.
1415 * minibuf.c (get_minibuffer): Likewise.
1416 * msdos.c (dos_set_window_size): Likewise.
1417 * process.c (make_process): Likewise.
1418 * xdisp.c (ensure_echo_area_buffers): Likewise.
1419 * xsettings.c (apply_xft_settings): Likewise.
1421 2012-07-09 Glenn Morris <rgm@gnu.org>
1423 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1424 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1425 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1426 * nsterm.h (ns_etc_directory): Add it.
1427 * callproc.c [HAVE_NS]: Include nsterm.h.
1428 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1430 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1432 Move marker debugging code under MARKER_DEBUG.
1433 * marker.c (MARKER_DEBUG): Move marker debugging code under
1434 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1435 for bootstrap with --enable-checking (~3x slowdown reported
1436 by Juanma Barranquero <lekktu@gmail.com>).
1437 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1439 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1441 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1442 See <http://bugs.gnu.org/11825#29>.
1444 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1446 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1447 has no font, use the frame's font. (Bug#11813)
1448 (display_line): Add commentary about displaying truncation glyphs
1450 (produce_special_glyphs): Move here from term.c.
1452 * term.c (produce_special_glyphs): Move to xdisp.c.
1454 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1457 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1459 * xdisp.c (display_line): Avoid warning about implicit declaration
1462 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1464 * lisp.h: Remove empty conditional.
1466 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1468 * lread.c (load_path_check): Now static.
1470 Fix some minor --with-ns problems found by static checking.
1471 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1472 (x_set_font) [!HAVE_X_WINDOWS]:
1473 * image.c (xpm_load_image) [HAVE_NS]:
1474 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1475 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1476 Remove unused local.
1477 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1478 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1479 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1480 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1481 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1482 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1483 Fix pointer signedness problem.
1484 * xfaces.c (FRAME_X_FONT_TABLE):
1485 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1487 2012-07-07 Glenn Morris <rgm@gnu.org>
1489 * lread.c (load_path_check): New function, split from init_lread.
1490 (init_lread): Reorganize. Motivation:
1491 If EMACSLOADPATH is set, check/warn about that rather than the
1492 defaults, which we are not going to use. Hence we can remove
1493 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1494 Don't warn if site-lisp directories are missing.
1495 If not installed, start from a blank load-path, since
1496 PATH_LOADSEARCH refers to the eventual installation directories.
1498 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1500 Support truncation and continuation glyphs on GUI frames, when
1501 fringes are disabled. (Bug#11832)
1502 * xdisp.c (init_iterator): Get dimensions of truncation and
1503 continuation glyphs even if on GUI frames. Adjust
1504 it->last_visible_x on GUI frames when the left or right fringes,
1505 or both, are absent.
1506 (start_display, move_it_in_display_line_to): Handle the case of a
1507 GUI frame without a fringe to display continuation or truncation
1509 (insert_left_trunc_glyphs): Support GUI frames: make sure
1510 truncation glyphs overwrite enough glyphs from the current line to
1511 have sufficient space in pixels.
1512 (display_line): Support truncation and continuation glyphs on GUI
1513 frames. If some spare pixels are left on the line after inserting
1514 the truncation glyphs, fill that space with a stretch glyph of a
1515 suitably computed width.
1517 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1518 produce_glyphs, to support GUI sessions.
1520 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1522 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1524 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1526 Do not require float-time's arg to fit in time_t (Bug#11825).
1527 This works better on hosts where time_t is unsigned, and where
1528 float-time is applied to the (negative) difference between two times.
1529 * editfns.c (decode_time_components): Last arg is now double *,
1530 not int *, and means to store all the result as a double, without
1531 worrying about whether the seconds part fits in time_t.
1532 All callers changed.
1533 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1534 All callers changed.
1535 (Ffloat_time): Do not fail merely because the specified time falls
1536 outside of time_t range.
1538 2012-07-07 Glenn Morris <rgm@gnu.org>
1540 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1541 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1542 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1544 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1546 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1547 Update dependencies.
1549 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1551 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1553 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1554 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1555 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1556 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1557 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1558 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1560 * xfont.c (compare_font_names): Redo to omit the need for casts.
1562 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1564 * xfns.c (Fx_change_window_property): Doc fix.
1565 * w32fns.c (Fx_change_window_property): Doc fix.
1567 * w32fns.c (Fx_window_property): Accept the same arguments as the
1568 X Windows version. Doc fix.
1569 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1571 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1572 Eli Zaretskii <eliz@gnu.org>
1574 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1575 Windows-specific code from nt/config.nt moved here.
1576 Obsolete settings removed.
1578 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1580 * process.c: Avoid unnecessary calls to gettime.
1581 (wait_reading_process_output): Don't get the time of day
1582 when gobbling data immediately and not waiting, as there's no need
1583 for it in that case. This removes a FIXME.
1585 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1587 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1588 is defined (Bug#11768).
1590 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1592 Fix marker debugging code.
1593 * marker.c (byte_char_debug_check): Do not perform the check
1594 if buffer is not multibyte.
1595 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1596 Call byte_char_debug_check with correct arguments.
1598 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1600 Compile marker debugging code only if ENABLE_CHECKING is defined.
1601 * marker.c (byte_char_debug_check, count_markers):
1602 Use only if ENABLE_CHECKING is defined.
1603 (byte_debug_flag): Remove.
1604 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1605 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1607 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1609 Avoid code repetition in marker-related functions.
1610 * marker.c (attach_marker): New function.
1611 (Fset_marker, set_marker_restricted, set_marker_both)
1612 (set_marker_restricted_both): Use it.
1613 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1614 Consistently rename charno to charpos.
1615 (marker_position): Add eassert.
1616 (marker_byte_position): Convert to eassert.
1618 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1620 Simplify list operations in unchain_overlay and unchain_marker.
1621 * buffer.c (unchain_overlay): Simplify. Add comment.
1622 * marker.c (unchain_marker): Simplify. Fix comments.
1624 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1626 Introduce fast path for the widely used marker operation.
1627 * alloc.c (build_marker): New function.
1628 * lisp.h (build_marker): New prototype.
1629 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1630 * composite.c (autocmp_chars): Likewise.
1631 * editfns.c (buildmark): Remove.
1632 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1633 (save_restriction_save): Use build_marker.
1634 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1635 * window.c (save_window_save): Likewise.
1637 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1639 Do not use Fdelete_overlay in delete_all_overlays
1640 to avoid redundant calls to unchain_overlay.
1641 * buffer.c (drop_overlay): New function.
1642 (delete_all_overlays, Fdelete_overlay): Use it.
1643 * minibuf.c (get_minibuffer): Fix comment.
1645 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1647 Port to OpenBSD 5.1 amd64.
1648 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1649 This is needed for OpenBSD, and should be harmless on all BSD systems.
1650 Also, include <sys/sysctl.h>, as it should be available on all
1651 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1652 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1653 use p_pid member, not kp_proc.pid.
1655 2012-07-06 Glenn Morris <rgm@gnu.org>
1657 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1659 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1661 More xmalloc and related cleanup.
1662 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1663 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1664 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1665 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1666 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1667 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1668 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1669 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1670 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1672 Omit needless casts involving void * pointers and allocation.
1673 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1674 as the former is more robust if P's type is changed.
1675 Prefer xzalloc to xmalloc + memset 0.
1676 Simplify malloc-or-realloc to realloc.
1677 Don't worry about xmalloc returning a null pointer.
1678 Prefer xstrdup to xmalloc + strcpy.
1679 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1681 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1682 alloca of a constant.
1684 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1686 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1687 hscroll is larger than the line width. Fixes long and futile
1688 looping inside extend_face_to_end_of_line (on a TTY) producing
1689 glyphs that are not needed and thrown away.
1691 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1693 * marker.c (set_marker_restricted_both): Simplify by using
1696 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1698 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1700 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1702 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1703 not defined (Bug#11768).
1704 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1705 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1706 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1707 followed by gtk_box_set_homogeneous (Bug#11768).
1708 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1709 (update_theme_scrollbar_width, xg_create_scroll_bar):
1710 Use gtk_scrollbar_new (Bug#11768).
1711 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1712 (is_box_type): New function (Bug#11768).
1713 (xg_tool_item_stale_p): Call is_box_type.
1714 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1715 with default display (Bug#11768).
1717 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1719 * xdisp.c (window_hscroll_limited): New function.
1720 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1721 coordinates when window's hscroll is set to insanely large
1724 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1726 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1727 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1729 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1732 * lisp.h (xzalloc): New prototype. Omit needless casts.
1733 * alloc.c (xzalloc): New function. Omit needless casts.
1734 * charset.c: Omit needless casts. Convert all calls to
1735 xmalloc with following memset to xzalloc.
1736 * dispnew.c: Likewise.
1737 * fringe.c: Likewise.
1738 * image.c: Likewise.
1739 * sound.c: Likewise.
1741 * w32fns.c: Likewise.
1742 * w32font.c: Likewise.
1743 * w32term.c: Likewise.
1744 * xfaces.c: Likewise.
1746 * xterm.c: Likewise.
1747 * atimer.c: Omit needless casts.
1748 * buffer.c: Likewise.
1749 * callproc.c: Likewise.
1751 * coding.c: Likewise.
1752 * composite.c: Likewise.
1754 * doprnt.c: Likewise.
1755 * editfns.c: Likewise.
1756 * emacs.c: Likewise.
1758 * filelock.c: Likewise.
1760 * gtkutil.c: Likewise.
1761 * keyboard.c: Likewise.
1763 * lread.c: Likewise.
1764 * minibuf.c: Likewise.
1765 * msdos.c: Likewise.
1766 * print.c: Likewise.
1767 * process.c: Likewise.
1768 * region-cache.c: Likewise.
1769 * search.c: Likewise.
1770 * sysdep.c: Likewise.
1771 * termcap.c: Likewise.
1772 * terminal.c: Likewise.
1773 * tparam.c: Likewise.
1774 * w16select.c: Likewise.
1776 * w32reg.c: Likewise.
1777 * w32select.c: Likewise.
1778 * w32uniscribe.c: Likewise.
1779 * widget.c: Likewise.
1780 * xdisp.c: Likewise.
1781 * xmenu.c: Likewise.
1783 * xselect.c: Likewise.
1785 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1787 * fileio.c (time_error_value): Check the right error number.
1788 Problem reported by Troels Nielsen in
1789 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1791 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1793 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1794 This should be fixed in a better way; see Eli Zaretskii in
1795 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1796 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1798 * fileio.c (time_error_value): Rename from special_mtime.
1799 The old name's problems were noted by Eli Zaretskii in
1800 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1802 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1803 This variable's comment says Emacs needs at least one GDB-visible
1804 symbol of type enum pvec_type, to work around GDB problems.
1805 The symbol's value doesn't matter.
1807 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1808 that causes compilation to fail on pre-C99 compilers.
1810 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1812 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1813 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1815 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1817 * buffer.c (init_buffer_once): Fix initialization of
1818 headers for buffer_defaults and buffer_local_symbols.
1819 Reported by Juanma Barranquero <lekktu@gmail.com>.
1821 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1823 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1824 * lisp.h (enum pvec_type): Use fewer bits.
1825 (PSEUDOVECTOR_SIZE_BITS): New constant.
1826 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1827 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1828 change in pvec_type.
1829 (PSEUDOVECTOR_TYPEP): New macro.
1830 (TYPED_PSEUDOVECTORP): Use it.
1831 * fns.c (internal_equal): Adapt code to extract pvectype.
1832 * emacs.c (gdb_pvec_type): Update type.
1833 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1834 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1835 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1836 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1837 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1838 abusing vector->header.next.nbytes.
1839 (live_vector_p): Use PVEC_TYPE.
1840 (mark_object): Adapt code to extract pvectype. Use switch.
1842 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1844 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1845 Tighten new eassert a bit.
1847 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1849 Fix compilation with --enable-gcc-warnings and -O1
1851 * doprnt.c (doprnt): Change type of tem to int, initialize
1852 to avoid compiler warning. Add eassert.
1853 * search.c (simple_search): Initialize match_byte to avoid
1854 compiler warning. Add eassert.
1856 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1858 Avoid weird behavior with large horizontal scrolls.
1859 Without this change, for example, large hscroll values would
1860 mess up Emacs's display on Fedora 15 x86, presumably due to
1861 overflows in int calculations in the display code.
1862 Also, if buffers had long lines, Emacs would freeze.
1863 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1864 (set_window_hscroll): New function, containing the old guts of
1865 Fset_window_hscroll. Return the clipped value.
1866 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1867 This avoids the need to check against PTRDIFF_MAX.
1869 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1871 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1873 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1875 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1877 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1878 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1879 since GCC 4.4.6 issues a bogus warning for them.
1881 Fix bugs in file timestamp newness comparisons.
1882 * fileio.c (Ffile_newer_than_file_p):
1883 * lread.c (Fload): Use full timestamp resolution of files,
1884 not just the 1-second resolution, so that files that are only
1885 slightly newer still count as newer.
1886 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1887 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1889 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1891 * fileio.c: Improve handling of file time marker. (Bug#11852)
1892 (special_mtime): New function.
1893 (Finsert_file_contents, Fverify_visited_file_modtime):
1894 Use it to set special mtime values consistently.
1896 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1898 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1899 marker for non-existing file. (Bug#11852)
1901 2012-07-03 Glenn Morris <rgm@gnu.org>
1903 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1904 and did not make it into globals.h).
1906 2012-07-03 Tom Tromey <tromey@redhat.com>
1908 * window.c (Fset_window_margins, Fset_window_fringes)
1909 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1910 * textprop.c (Fprevious_property_change): No longer static.
1911 * syntax.c (Fsyntax_table_p): No longer static.
1912 * process.c (Fget_process, Fprocess_datagram_address): No longer
1914 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1915 * keyboard.c (Fcommand_execute): No longer static.
1917 * insdel.c (Fcombine_after_change_execute): No longer static.
1918 * image.c (Finit_image_library): No longer static.
1919 * fileio.c (Fmake_symbolic_link): No longer static.
1920 * eval.c (Ffetch_bytecode): No longer static.
1921 * editfns.c (Fuser_full_name): No longer static.
1922 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1924 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1926 * dired.c (Ffile_attributes): No longer static.
1927 * composite.c (Fcomposition_get_gstring): No longer static.
1928 * callproc.c (Fgetenv_internal): No longer static.
1930 * ccl.h: Remove EXFUNs.
1931 * buffer.h: Remove EXFUNs.
1932 * dispextern.h: Remove EXFUNs.
1933 * intervals.h: Remove EXFUNs.
1934 * fontset.h: Remove EXFUN.
1935 * font.h: Remove EXFUNs.
1936 * dosfns.c (system_process_attributes): Remove EXFUN.
1937 * keymap.h: Remove EXFUNs.
1938 * lisp.h: Remove EXFUNs.
1939 * w32term.h: Remove EXFUNs.
1940 * window.h: Remove EXFUNs.
1941 * xsettings.h: Remove EXFUN.
1942 * xterm.h: Remove EXFUN.
1944 2012-07-03 Glenn Morris <rgm@gnu.org>
1946 * lisp.h (Frandom): Make it visible to C.
1947 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1948 buffer for invisible buffers. (Bug#1229)
1950 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1952 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1953 values which aren't power of 2.
1954 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1955 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1958 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1960 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1962 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1964 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1966 * alloc.c (allocate_vector_block): Remove redundant
1967 calls to mallopt if DOUG_LEA_MALLOC is defined.
1968 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1969 avoid calls to mallopt if zero_vector is returned.
1971 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1973 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1974 is enabled, avoid dereferencing NULL current_sblock if
1977 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1979 Cleanup basic buffer management.
1980 * buffer.h (struct buffer): Change layout to use generic vector
1981 marking code. Fix some comments. Change type of 'clip_changed'
1982 to bitfield. Remove unused #ifndef old.
1983 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1984 (GET_OVERLAYS_AT): Fix indentation.
1985 (for_each_per_buffer_object_at): New macro.
1986 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1987 (Fbuffer_local_variables): Use it.
1988 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1989 * alloc.c (allocate_buffer): Adjust to match new layout of
1990 struct buffer. Fix comment.
1991 (mark_overlay): New function.
1992 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1993 Lisp area of struct buffer.
1994 (mark_object): Use it. Adjust marking of misc objects
1995 and related comments.
1997 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1999 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2000 wrapper that is not needed because the wrapped code is a no-op (zero
2001 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2002 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2004 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2006 * alloc.c (mark_buffer): Simplify. Remove prototype.
2007 (mark_object): Add comment. Reorganize marking of vector-like
2008 objects. Use CHECK_LIVE for all vector-like objects except buffers
2009 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2010 redundant calls to mark_vectorlike for bool vectors.
2012 2012-06-30 Glenn Morris <rgm@gnu.org>
2014 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2016 * epaths.in (PATH_SITELOADSEARCH): New.
2017 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2018 This is rather than relying on --enable-locallisppath elements
2019 having "site-lisp" in their names. (Bug#10208#25, 11658)
2021 2012-06-30 Eli Zaretskii <eliz@gnu.org>
2023 * w32proc.c (sys_select): Accept and ignore one more argument.
2025 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2027 * sysselect.h [DOS_NT]: Don't include sys/select.h.
2028 (pselect) [!MS_DOS]: Redirect to sys_select.
2030 * sysdep.c: Don't include dos.h and dosfns.h.
2032 * process.c (sys_select):
2033 * msdos.c (sys_select): Accept one more argument and ignore it.
2035 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2036 adapt data types and code to that.
2039 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2040 which clashes with the gnulib function of the same name.
2042 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2044 * font.c (font_style_to_value, font_style_symbolic)
2045 (font_prop_validate_style): Add type checks for values in
2048 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2050 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2053 2012-06-29 Eli Zaretskii <eliz@gnu.org>
2055 * xdisp.c (try_window_id): Undo last change.
2057 * w32.c (getwd): Adjust commentary about startup_dir.
2058 (init_environment): Always call sys_access, even in non-MSVC
2059 builds. Don't chdir to the directory of the Emacs executable.
2060 This undoes code from 1997 which was justified by the need to
2061 "avoid conflicts when removing and renaming directories". But its
2062 downside was that every relative file name was being interpreted
2063 relative to the directory of the Emacs executable, which can never
2064 be TRT. In particular, it broke sys_access when called with
2065 relative file names.
2066 (sys_access): Map GetLastError to errno.
2068 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2070 * window.h (struct window): Change type of 'fringes_outside_margins'
2071 to bitfield. Fix comment. Adjust users accordingly.
2072 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2074 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2077 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2079 * gnutls.c (emacs_gnutls_handshake):
2080 Add QUIT to make the loop interruptible.
2082 2012-06-29 Glenn Morris <rgm@gnu.org>
2084 * charset.c (init_charset): Make lack of etc/charsets fatal.
2086 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2088 * editfns.c (region_limit): Fix type mismatch.
2090 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2092 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2093 undefined. Convert from xassert to eassert.
2094 * nsmenu.m: Convert from xassert to eassert.
2095 * nsterm.m: Likewise.
2097 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2099 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2101 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2103 Avoid integer overflow on scroll-left and scroll-right.
2104 * window.c (HSCROLL_MAX): New macro.
2105 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2106 overflow when requested scroll falls outside ptrdiff_t range.
2108 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2110 * window.h (struct window): Change type of 'hscroll',
2111 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2112 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2113 Adjust users accordingly.
2114 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2115 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2116 from EMACS_INT to ptrdiff_t.
2117 (make_window): Omit redundant initialization.
2119 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
2121 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2123 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2125 * window.h (struct window): Change type of 'use_time' and
2126 'sequence_number' from Lisp_Object to int.
2127 * frame.c (make_frame): Adjust users accordingly.
2128 * print.c (print_object): Likewise.
2129 * window.c (select_window, Fwindow_use_time, make_parent_window)
2130 (make_window): Likewise.
2132 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2134 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2135 enabled with --enable-checking=[all,glyphs] configure option.
2136 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2137 adjust comments accordingly.
2138 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2139 undefined, adjust comments accordingly.
2140 * image.c: Likewise.
2141 * scroll.c: Likewise.
2142 * w32fns.c: Likewise.
2143 * w32term.c: Likewise.
2144 * xdisp.c: Likewise.
2145 * xfaces.c: Likewise.
2147 * xterm.c: Likewise.
2149 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2151 Generalize run-time debugging checks.
2152 * dispextern.h (XASSERTS): Remove.
2153 * fontset.c (xassert): Remove.
2154 Convert from xassert to eassert.
2155 * alloc.c: Convert from xassert to eassert.
2157 * dispnew.c: Likewise.
2159 * fringe.c: Likewise.
2160 * ftfont.c: Likewise.
2161 * gtkutil.c: Likewise.
2162 * image.c: Likewise.
2163 * keyboard.c: Likewise.
2165 * process.c: Likewise.
2166 * scroll.c: Likewise.
2167 * sound.c: Likewise.
2169 * w32console.c: Likewise.
2170 * w32fns.c: Likewise.
2171 * w32term.c: Likewise.
2172 * window.c: Likewise.
2173 * xdisp.c: Likewise.
2174 * xfaces.c: Likewise.
2176 * xselect.c: Likewise.
2177 * xterm.c: Likewise.
2179 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2181 * fns.c (maybe_resize_hash_table): Output message when growing the
2184 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2186 * alloc.c (allocate_string_data): Remove dead code.
2187 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2188 avoid GCC warning about unused macro.
2190 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2192 * alloc.c (allocate_string): Omit intervals initialization.
2193 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2194 as in make_pure_string and make_pure_c_string.
2196 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2198 * alloc.c (allocate_string): Fix last change.
2200 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2202 * alloc.c (allocate_string): Remove two redundant calls
2203 to memset, add explicit initialization where appropriate.
2205 2012-06-27 Glenn Morris <rgm@gnu.org>
2207 * lisp.mk (lisp): Remove paths.elc.
2209 2012-06-27 Chong Yidong <cyd@gnu.org>
2211 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2213 2012-06-26 John Wiegley <johnw@newartisans.com>
2215 * unexmacosx.c (copy_data_segment): Add two section names used
2216 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2218 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2219 when building with Clang.
2221 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2223 * eval.c (Fapply): Allow calling it with a single argument.
2225 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2227 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2228 _stricmp and _strnicmp.
2229 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2231 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2233 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2235 (allocate_process): Likewise for new process.
2236 (allocate_terminal): Change to use offsetof.
2237 (allocate_frame): Likewise.
2238 * frame.c (make_frame): Omit redundant initialization.
2239 * window.c (make_parent_window): Use memset.
2240 (make_window): Omit redundant initialization.
2241 * process.c (make_process): Omit redundant initialization.
2242 * terminal.c (create_terminal): Likewise.
2244 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2246 * term.c (delete_tty): Remove redundant call to memset.
2248 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2250 * alloc.c: Remove build_string.
2251 * lisp.h: Define build_string as static inline. This provides
2252 a better opportunity to optimize away calls to strlen when the
2253 function is called with compile-time constant argument.
2254 * image.c (imagemagick_error): Convert to build_string.
2255 * w32proc.c (sys_spawnve): Likewise.
2256 * xterm.c (x_term_init): Likewise.
2258 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2260 Use sprintf return value instead of invoking strlen on result.
2261 In the old days this wasn't portable, since some sprintf
2262 implementations returned char *. But they died out years ago and
2263 Emacs already assumes sprintf returns int.
2264 Similarly for float_to_string.
2265 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2266 * ccl.c (ccl_driver):
2267 * character.c (string_escape_byte8):
2268 * data.c (Fnumber_to_string):
2269 * doprnt.c (doprnt):
2270 * print.c (print_object):
2271 * xdisp.c (message_dolog):
2272 * xfns.c (syms_of_xfns):
2273 Use sprintf or float_to_string result to avoid need to call strlen.
2274 * data.c (Fnumber_to_string):
2275 Use make_unibyte_string, since the string must be ASCII.
2276 * lisp.h, print.c (float_to_string): Now returns int length.
2277 * term.c (produce_glyphless_glyph):
2278 Use sprintf result rather than recomputing it.
2280 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2281 * Makefile.in (ALL_CFLAGS):
2282 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2283 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2285 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2287 * dispextern.h (xstrcasecmp): Define to library function
2288 strcasecmp if available.
2289 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2291 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2293 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2294 Avoid comma operator.
2295 * menu.c (push_submenu_start, push_submenu_end)
2296 (push_left_right_boundary, push_menu_pane): Likewise.
2297 * msdos.c (dos_rawgetc): Likewise.
2299 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2301 * xfns.c (xic_create_fontsetname): Remove redundant calls
2304 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2306 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2307 sprintf already null-terminates its output.
2309 * xfns.c (x_window): Remove redundant cast.
2311 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2313 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2314 `const char *' to `char *' to avoid compiler warning.
2316 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2318 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2319 instead of truncating it to 63 (admittedly a generous limit).
2321 * process.c: Fix spelling and caps in comments.
2323 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2325 * emacs.c (setpgrp): Remove definition, unused.
2326 * sysdep.c (setpgrp): Remove definition, not used in this file.
2328 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2330 * makefile.w32-in: Update dependencies.
2332 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2334 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2335 (SYSTIME_H): Add nt/inc/sys/time.h.
2337 * systime.h [WINDOWSNT]: Include sys/time.h.
2339 * s/ms-w32.h (struct timespec): Definition moved from
2340 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2342 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2344 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2345 * buffer.h (buffer_slot_type_mismatch):
2346 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2347 * eval.c (unwind_to_catch):
2348 * image.c (my_png_error, my_error_exit):
2349 * keyboard.c (quit_throw_to_read_char, user_error)
2350 (Fexit_recursive_edit, Fabort_recursive_edit):
2351 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2352 (wrong_type_argument, buffer_overflow, __executable_start)
2353 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2354 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2355 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2357 (child_setup) [!DOS_NT]:
2358 * lread.c (end_of_file_error, invalid_syntax):
2359 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2360 * puresize.h (pure_write_error):
2361 * search.c (matcher_overflow):
2362 * sound.c (sound_perror, alsa_sound_perror):
2363 * sysdep.c, syssignal.h (croak):
2364 * term.c (maybe_fatal, vfatal):
2365 * textprop.c (text_read_only):
2366 * undo.c (user_error):
2367 * unexmacosx.c (unexec_error):
2368 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2369 Use _Noreturn rather than NO_RETURN.
2370 No need for separate decl merely because of _Noreturn.
2371 * sound.c (sound_warning, parse_sound):
2372 Remove unnecessary forward decls.
2374 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2376 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2377 * lisp.h (WAIT_READING_MAX): New macro.
2378 * dispnew.c (Fsleep_for, sit_for):
2379 * keyboard.c (kbd_buffer_get_event):
2380 * process.c (Faccept_process_output):
2381 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2382 This improves on the previous patch, which introduced a bug
2383 when time_t is unsigned and as wide as intmax_t.
2384 See <http://bugs.gnu.org/9000#51>.
2386 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2388 * dispnew.c (sit_for, Fsleep_for):
2389 * keyboard.c (kbd_buffer_get_event):
2390 * process.c (Faccept_process_output): Avoid compiler warnings when
2391 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2393 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2395 * makefile.w32-in: Update dependencies.
2397 * w32.c (ltime): Add return type and declare static.
2398 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2400 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2402 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2403 Privately reported by Herbert J. Skuhra.
2404 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2406 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2407 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2409 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2411 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2412 last argument of make_unibyte_string.
2414 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2415 language ID in the event parameters.
2417 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2418 event.code, not the obscure "character set ID".
2420 2012-06-23 Chong Yidong <cyd@gnu.org>
2422 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2424 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2426 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2427 * w32.c (fdutimens): New function.
2429 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2431 * s/ms-w32.h (pselect): Redirect to sys_select.
2433 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2435 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2436 in the logic of incrementing and decrementing the value of
2437 use_relocatable_buffers.
2439 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2441 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2442 Privately reported by Herbert J. Skuhra.
2443 [__FreeBSD__]: Remove "*/" typo after "#include".
2444 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2445 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2446 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2447 Don't assume EMACS_TIME and struct timeval are the same type.
2449 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2451 Support higher-resolution time stamps (Bug#9000).
2452 The time stamps are only nanosecond-resolution at the C level,
2453 since that's the best that any real-world system supports now.
2454 But they are picosecond-resolution at the Lisp level, as that's
2455 easy, and leaves room for future OS improvements.
2457 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2460 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2461 Don't get current time unless it's needed.
2463 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2464 now provides it if it's absent.
2465 (start_atimer): Port to higher-res time stamps.
2466 Check for time stamp overflow. Don't get current time more
2467 often than is needed.
2469 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2470 Include systime.h, not time.h.
2471 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2473 * dired.c: Include stat-time.h.
2474 (Ffile-attributes): File times now have higher resolution.
2476 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2477 (struct image): Timestamp now has higher resolution.
2479 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2480 has at least microseconds now. All uses removed.
2481 (update_frame, update_single_window, update_window, update_frame_1)
2482 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2484 * editfns.c (time_overflow): Now extern.
2485 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2486 (float-time, Fformat_time_string, Fcurrent_time_string)
2487 (Fcurrent_time_zone): Accept and generate higher-resolution
2489 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2490 (decode_time_components, lisp_seconds_argument): New functions.
2491 (make_time): Now static.
2492 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2493 Report an error if the time is invalid, rather than having the caller
2496 * fileio.c: Include <stat-time.h>
2497 (Fcopy_file): Copy higher-resolution time stamps.
2498 Prefer to set the time stamp via a file descriptor if that works.
2499 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2500 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2501 (Fvisited_file_modtime, Fset_visited_file_modtime):
2502 Support higher-resolution time stamps.
2504 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2506 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2508 * image.c (prepare_image_for_display, clear_image_cache)
2509 (lookup_image): Port to higer-resolution time stamps.
2511 * keyboard.c (start_polling, bind_polling_period):
2512 Check for time stamp overflow.
2513 (read_char, kbd_buffer_get_event, timer_start_idle)
2514 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2515 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2516 Port to higher-resolution time stamps. Do not assume time_t is signed.
2517 (decode_timer): New function. Timers are now vectors of length 9,
2518 not 8, to accommodate the picosecond component.
2519 (timer_check_2): Use it.
2521 * nsterm.m (select_timeout, timeval_subtract): Remove.
2522 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2523 as they're a bit more accurate and handle overflow better.
2524 (ns_select): Change prototype to be compatible with pselect.
2525 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2526 * nsterm.h (ns_select): Adjust prototype.
2528 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2529 us-resolution time stamps.
2530 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2532 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2534 * lisp.h (time_overflow): New decl.
2535 (wait_reading_process_output): First arg is now intmax_t, not int,
2536 to accommodate larger waits.
2538 * process.h (struct Lisp_Process.read_output_delay):
2539 Now counts nanoseconds, not microseconds.
2540 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2542 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2543 (wait_reading_process_output):
2544 Port to ns-resolution time stamps.
2545 (Faccept_process_output, wait_reading_process_output):
2546 Check for time stamp overflow. Do not assume time_t is signed.
2547 (select_wrapper): Remove; we now use pselect.
2548 (Fprocess_attributes): Now generates ns-resolution time stamps.
2550 * sysdep.c: Include utimens.h. Don't include utime.h
2551 or worry about struct utimbuf; gnulib does that for us now.
2552 (gettimeofday): Remove; gnulib provides a substitute.
2553 (make_timeval): New function.
2554 (set_file_times): Now sets ns-resolution time stamps.
2555 New arg FD; all uses changed.
2556 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2557 (system_process_attributes):
2558 Now returns ns-resolution time stamp. All uses changed.
2559 Check for time stamp overflow.
2561 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2562 provides a substitute now.
2564 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2565 since it guarantees struct timespec.
2566 (EMACS_TIME): Now struct timespec, so that we can support
2567 ns-resolution time stamps.
2568 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2569 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2570 (EMACS_USECS): Remove.
2571 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2572 so multiply the arg by 1000 before storing it.
2573 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2575 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2576 Port to ns-resolution time stamps.
2577 (EMACS_TIME_NEG_P): Remove; replaced by....
2578 (EMACS_TIME_SIGN): New macro.
2579 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2580 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2581 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2582 (make_timeval, make_lisp_time, decode_time_components): New decls.
2583 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2584 that it mishandled time_t overflow. You can't compare by subtracting!
2585 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2586 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2588 * term.c: Include <sys/time.h>.
2589 (timeval_to_Time): New function, for proper overflow wraparound.
2590 (term_mouse_position, term_mouse_click): Use it.
2592 * undo.c (record_first_change): Support higher-resolution time stamps
2594 (Fprimitive_undo): Use them when restoring time stamps.
2596 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2597 (w32_get_internal_run_time):
2598 Port to higher-resolution Emacs time stamps.
2599 (ltime): Now accepts single 64-bit integer, as that's more convenient
2602 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2604 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2605 for compatibility with pselect. Support ns-resolution time stamps.
2607 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2609 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2610 Check for time stamp overflow, and support ns-resolution time stamps.
2612 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2613 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2614 (timeval_subtract): Remove; no longer needed.
2615 (XTflash, XTring_bell, x_wait_for_event):
2616 Port to ns-resolution time stamps. Don't assume time_t is signed.
2618 2012-06-22 Chong Yidong <cyd@gnu.org>
2620 * xdisp.c (x_consider_frame_title): Revert last change.
2622 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2624 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2625 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2626 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2627 staticidx goes up to 1597 out of 1600 = 0x640.)
2629 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2631 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2632 Otherwise, the umask might be mistakenly 0 while handling input signals.
2634 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2636 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2638 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2640 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2641 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2642 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2643 access to `contents' member of Lisp_Vector objects with AREF and ASET
2646 2012-06-19 Chong Yidong <cyd@gnu.org>
2648 * frame.c (delete_frame): When selecting a frame on a different
2649 text terminal, do not alter the terminal's top-frame.
2651 * xdisp.c (format_mode_line_unwind_data): Record the target
2652 frame's selected window and its terminal's top-frame.
2653 (unwind_format_mode_line): Restore them.
2654 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2656 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2657 since tty frames can be explicitly named.
2658 (prepare_menu_bars): Likewise.
2660 * term.c (Ftty_top_frame): New function.
2662 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2664 Port byte-code-meter to modern targets.
2665 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2666 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2667 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2668 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2669 (METER_1, METER_2): Simplify.
2671 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2673 * data.c (Fdefalias): Return `symbol' (bug#11686).
2675 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2677 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2678 gets killed during executing of this function (Bug#11665).
2679 Try to always return Qt when the buffer has been actually killed.
2680 (Vkill_buffer_query_functions): In doc-string say that functions
2681 run by this hook should not change the current buffer.
2683 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2685 Fix recently-introduced process.c problems found by static checking.
2686 * process.c (write_queue_push, write_queue_pop, send_process):
2687 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2688 (write_queue_pop): Fix pointer signedness problem.
2689 (send_process): Remove unused local.
2691 2012-06-17 Chong Yidong <cyd@gnu.org>
2693 * xdisp.c (redisplay_internal): No need to redisplay terminal
2694 frames that are not on top.
2696 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2698 * process.c (make_process): Initialize write_queue.
2699 (write_queue_push, write_queue_pop): New functions.
2700 (send_process): Use them to maintain correct ordering of process
2703 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2705 * lisp.h (eassert): Assume C89 or later.
2706 This removes the need for CHECK.
2707 (CHECK): Remove. Its comments about always evaluating its
2708 argument were confusing, as 'eassert' typically does not evaluate
2711 * coding.c (produce_chars): Use ptrdiff_t, not int.
2713 * xterm.c (x_draw_underwave): Check for integer overflow.
2714 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2716 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2718 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2719 referenced (Bug#11583).
2721 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2723 Implement wave-style variant of underlining.
2724 * dispextern.h (face_underline_type): New enum.
2725 (face): Add field for underline type.
2726 * nsterm.m (ns_draw_underwave): New function.
2727 (ns_draw_text_decoration): Use it.
2728 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2730 (x_draw_glyph_string): Use them.
2731 * xfaces.c (Qline, Qwave): New Lisp objects.
2732 (check_lface_attrs, merge_face_ref)
2733 (Finternal_set_lisp_face_attribute, realize_x_face):
2734 Handle wave-style underline face attributes.
2735 * xterm.c (x_draw_underwave): New function.
2736 (x_draw_glyph_string): Use it.
2738 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2740 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2741 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2742 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2743 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2744 ($(BLD)/w32select.$(O)): Update dependencies.
2746 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2748 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2749 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2750 * character.c (_fetch_multibyte_char_p): Remove.
2751 * alloc.c: Include "character.h" before "buffer.h".
2753 * buffer.c: Likewise.
2754 * bytecode.c: Likewise.
2755 * callint.c: Likewise.
2756 * callproc.c: Likewise.
2757 * casefiddle.c: Likewise.
2758 * casetab.c: Likewise.
2759 * category.c: Likewise.
2761 * coding.c: Likewise.
2762 * composite.c: Likewise.
2763 * dired.c: Likewise.
2764 * dispnew.c: Likewise.
2766 * dosfns.c: Likewise.
2767 * editfns.c: Likewise.
2768 * emacs.c: Likewise.
2769 * fileio.c: Likewise.
2770 * filelock.c: Likewise.
2772 * fontset.c: Likewise.
2773 * fringe.c: Likewise.
2774 * indent.c: Likewise.
2775 * insdel.c: Likewise.
2776 * intervals.c: Likewise.
2777 * keyboard.c: Likewise.
2778 * keymap.c: Likewise.
2779 * lread.c: Likewise.
2780 * macros.c: Likewise.
2781 * marker.c: Likewise.
2782 * minibuf.c: Likewise.
2783 * nsfns.m: Likewise.
2784 * nsmenu.m: Likewise.
2785 * print.c: Likewise.
2786 * process.c: Likewise.
2787 * regex.c: Likewise.
2788 * region-cache.c: Likewise.
2789 * search.c: Likewise.
2790 * syntax.c: Likewise.
2792 * textprop.c: Likewise.
2794 * unexsol.c: Likewise.
2795 * w16select.c: Likewise.
2796 * w32fns.c: Likewise.
2797 * w32menu.c: Likewise.
2798 * window.c: Likewise.
2799 * xdisp.c: Likewise.
2801 * xmenu.c: Likewise.
2803 * xselect.c: Likewise.
2805 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2807 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2808 If all the glyphs of the glyph row came from strings, and we have no
2809 cursor positioning clues, put the cursor on the first glyph of the
2811 (handle_face_prop): Use chunk-relative overlay string index when
2812 indexing into it->string_overlays array. (Bug#11653)
2813 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2814 the rightmost. (Bug#11720)
2816 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2818 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2819 (CATEGORY_MEMBER): Enforce 1/0 value.
2820 * category.c (_temp_category_set): Remove.
2822 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2824 * window.c (Fdelete_other_windows_internal)
2825 (Fdelete_window_internal): Don't access frame's mouse highlight
2826 info of the initial frame. (Bug#11677)
2828 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2830 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2831 Assume USE_2_TAGS_FOR_INTS.
2832 (xreload): Adjust $tagmask width to match recent lisp.h change.
2834 Simplify lisp.h in minor ways that should not affect code.
2835 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2836 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2837 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2838 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2839 (INTTYPEBITS): New macro, for clarity.
2840 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2841 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2842 Simplify now that USE_LSB_TAG is always defined.
2843 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2844 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2846 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2848 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2850 2012-06-13 Glenn Morris <rgm@gnu.org>
2852 * s/bsd-common.h (BSD4_3):
2853 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2855 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2857 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2860 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2862 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2863 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2864 * alloc.c (widen_to_Lisp_Object): Remove.
2865 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2866 * frame.c (delete_frame): Remove outdated comment.
2867 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2868 USE_LISP_UNION_TYPE.
2869 (Fw32_unregister_hot_key): Likewise.
2870 (Fw32_toggle_lock_key): Likewise.
2871 * w32menu.c (add_menu_item): Likewise.
2872 (w32_menu_display_help): Use XIL instead of checking
2873 USE_LISP_UNION_TYPE.
2874 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2875 (init_heap): Likewise.
2876 * w32term.c (w32_read_socket): Update comment.
2878 2012-06-13 Glenn Morris <rgm@gnu.org>
2880 * s/usg5-4-common.h, src/s/unixware.h:
2881 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2883 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2885 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2887 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2888 * alloc.c (make_number) [!defined make_number]:
2889 Remove, as lisp.h always defines this now.
2890 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2891 (roundup_size): Verify that it is a power of 2.
2892 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2893 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2894 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2895 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2896 USE_LSB_TAG now is always defined to be either 0 or 1.
2898 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2899 code works fine either way, and efficiency is not a concern here,
2900 as the union type is for debugging, not for production.
2901 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2902 Use an inline function on all platforms when using the union type,
2903 since this is simpler and 'static inline' can be used portably
2905 (LISP_INITIALLY_ZERO): New macro.
2906 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2907 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2909 2012-06-12 Glenn Morris <rgm@gnu.org>
2911 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2913 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2915 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2916 Move BROKEN_SIGIO to configure.
2918 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2919 Move NO_TERMIO to configure.
2921 2012-06-12 Chong Yidong <cyd@gnu.org>
2923 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2924 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2925 MagickExportImagePixels is undefined.
2927 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2929 * image.c (imagemagick_load_image): Remove unused label.
2931 2012-06-11 Glenn Morris <rgm@gnu.org>
2933 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2934 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2935 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2936 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2938 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2940 * alloc.c (make_byte_code): New function.
2941 (Fmake_byte_code): Use it. Don't purify here.
2942 * lread.c (read1): Use it as well to avoid extra allocation.
2944 2012-06-11 Chong Yidong <cyd@gnu.org>
2946 * image.c (imagemagick_load_image): Implement transparency.
2948 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2950 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2951 account for preceding backslashes. (Bug#11663)
2953 2012-06-09 Chong Yidong <cyd@gnu.org>
2955 * term.c: Support italics in capable terminals (Bug#9652).
2956 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2957 (turn_on_face): Output using TS_enter_italic_mode if available.
2958 Don't handle unused blinking and alt-charset cases.
2959 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2960 and tty_alt_charset_p cases.
2961 (tty_capable_p, init_tty): Support italics.
2963 * termchar.h (struct tty_display_info): Add field for italics.
2964 Remove unused blink field.
2966 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2969 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2970 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2971 tty_alt_charset_p. Add tty_italic_p.
2973 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2975 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2976 dbus_type_is_basic if available.
2977 (xd_extract_signed, xd_extract_unsigned): Rename from
2978 extract_signed and extract_unsigned, respectively. Adapt callers.
2980 2012-06-09 Chong Yidong <cyd@gnu.org>
2982 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2984 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2987 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2989 * xdisp.c (vmessage): Treat frame message as multibyte.
2990 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2991 would generate the diagnostic "Making \302\247 buffer-local while
2994 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2996 * dispnew.c (showing_window_margins_p): Undo last change, which
2997 was done due to an inadvertent commit.
2998 (adjust_frame_glyphs_for_frame_redisplay): Do call
2999 showing_window_margins_p.
3001 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3003 * eval.c (Fmake_var_non_special): New primitive.
3004 (syms_of_eval): Defsubr it.
3005 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3007 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3009 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3010 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3012 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3014 * alloc.c (allocate_vectorlike): Fix last change.
3016 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3018 Block-based vector allocation of small vectors.
3019 * lisp.h (struct vectorlike_header): New field `nbytes',
3020 adjust comment accordingly.
3021 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3022 to denote vector blocks. Adjust users (live_vector_p,
3023 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3024 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3025 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3026 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3027 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3028 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3029 (roundup_size): New constant.
3030 (struct vector_block): New data type.
3031 (vector_blocks, vector_free_lists, zero_vector): New variables.
3032 (all_vectors): Rename to `large_vectors'.
3033 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3034 (sweep_vectors): New functions.
3035 (allocate_vectorlike): Return `zero_vector' as the only vector of
3036 0 items. Allocate new vector from block if vector size is less than
3037 or equal to VBLOCK_BYTES_MAX.
3038 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3039 (init_alloc_once): Add call to init_vectors.
3041 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3043 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3045 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3047 * doprnt.c (doprnt): Truncate multibyte char correctly.
3048 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3049 would mishandle a string argument "Xc" if X was a multibyte
3050 character of length 2: it would truncate after X's first byte
3051 rather than including all of X.
3053 2012-06-06 Chong Yidong <cyd@gnu.org>
3055 * buffer.c (word_wrap): Doc fix.
3057 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3059 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3061 2012-06-03 Glenn Morris <rgm@gnu.org>
3063 * xdisp.c (tool-bar-style): Doc fix.
3065 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3067 * Makefile.in (PAXCTL): Define.
3068 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3069 binary via PaX flags if the paxctl utility is available.
3070 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3071 Restore PaX flags to their default. (Bug#11398)
3073 2012-06-03 Chong Yidong <cyd@gnu.org>
3075 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3078 2012-06-03 Chong Yidong <cyd@gnu.org>
3080 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3081 (note_mode_line_or_margin_highlight): If there is no help echo,
3082 use mode-line-default-help-echo. Handle the case where the mouse
3083 position is past the end of the mode line string.
3085 * buffer.c (buffer_local_value_1): New function, split from
3086 Fbuffer_local_value; can return Qunbound.
3087 (Fbuffer_local_value): Use it.
3088 (Vmode_line_format): Docstring tweaks.
3090 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3092 * sysdep.c (system_process_attributes): Improve comment.
3094 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3096 * keyboard.c: Export real-this-command to Elisp.
3097 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3098 and DEFVAR it. Update all users.
3100 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3102 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3104 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3105 Convert pctcpu and pctmem to Lisp float properly.
3106 Let the compiler fold better, as 100.0/0x8000 is exact.
3108 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3110 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3113 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3115 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3117 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3119 For a 'struct window', replace some Lisp_Object fields to
3120 bitfields where appropriate, remove unused fields.
3121 * window.h (struct window): Remove unused 'last_mark_x' and
3122 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3123 change it's type from Lisp_Object to bitfield.
3124 Change type of 'force_start', 'optional_new_start',
3125 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3126 fields from Lisp_Object to bitfield. Adjust users accordingly.
3128 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3130 Pacify gcc -Wdouble-precision when using Xaw.
3131 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3132 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3133 Use 'float' consistently, rather than 'float' in most places
3134 and 'double' in a couple of places.
3136 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3138 * xdisp.c (handle_stop): Detect whether we have overlay strings
3139 loaded by testing it->current.overlay_string_index to be
3140 non-negative, instead of checking whether n_overlay_strings is
3141 positive. (Bug#11587)
3143 2012-05-31 Chong Yidong <cyd@gnu.org>
3145 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3147 * doc.c (Fsubstitute_command_keys): Doc fix.
3149 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3151 * search.c (search_buffer): Remove calls to
3152 r_alloc_inhibit_buffer_relocation, as it is now called by
3153 maybe_unify_char, which was the cause of relocation of buffer text
3156 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3158 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3159 for the duration of call to load_charset, to avoid problems with
3160 callers of maybe_unify_char that access buffer text through C
3163 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3164 decrement the inhibition flag, instead of just setting or
3167 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3169 Remove obsolete '#define static' cruft.
3170 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3171 This #undef was "temporary" in 2000; it is no longer needed
3172 now that '#define static' has gone away.
3173 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3174 (gray_bitmap_bits): Remove; no longer needed.
3175 All uses replaced with definiens.
3176 * xterm.c: Include "bitmaps/gray.xbm".
3178 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3180 Clean up __executable_start, monstartup when --enable-profiling.
3181 The following changes affect the code only when profiling.
3182 * dispnew.c (__executable_start): Rename from safe_bcopy.
3183 Define only on platforms that need it.
3184 * emacs.c: Include <sys/gmon.h> when profiling.
3185 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3186 (__executable_start): Remove decl, since lisp.h does it now.
3187 (safe_bcopy): Remove decl; no longer has that name.
3188 (main): Coalesce #if into single bit of code, for simplicity.
3189 Cast pointers to uintptr_t, since standard libraries want integers
3191 * lisp.h (__executable_start): New decl.
3193 2012-05-31 Glenn Morris <rgm@gnu.org>
3195 * image.c (Fimagemagick_types): Doc fix.
3197 2012-05-30 Jim Meyering <meyering@redhat.com>
3199 * callproc.c (Fcall_process_region): Include directory component
3200 in mkstemp error message (Bug#11586).
3202 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3204 * alloc.c, lisp.h (make_pure_vector): Now static.
3206 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3208 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3209 Move to byte-run.el.
3210 (Fautoload): Do the hash-doc more carefully.
3211 * data.c (Fdefalias): Purify definition, except for keymaps.
3212 (Qdefun): Move from eval.c.
3213 * lisp.h (Qdefun): Remove.
3214 * lread.c (read1): Tiny simplification.
3216 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3218 Do not create empty overlays with the evaporate property (Bug#9642).
3219 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3220 Bug#9642, but explicitly check that the buffer the overlay would
3221 be moved to is live and rearrange lines to make sure that errors
3222 will not put the overlay in an inconsistent state.
3223 (Fdelete_overlay): Cosmetics.
3225 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3227 * w32term.c (my_bring_window_to_top): New function.
3228 (x_raise_frame): Use handle returned by DeferWindowPos, which
3229 could be different from the original one.
3230 Call my_bring_window_to_top instead of my_set_foreground_window.
3233 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3234 by calling BringWindowToTop.
3236 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3237 (WM_EMACS_END): Increase by one.
3239 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3241 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3242 This avoids undefined behavior that might cause the eassert
3243 to not catch an out-of-range value.
3245 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3247 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3248 Update dependencies.
3250 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3252 * bidi.c (bidi_mirror_char): Fix last change.
3254 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3256 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3257 when referring to sectname field in printf format.
3259 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3261 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3262 Only r_alloc_inhibit_buffer_relocation needed to be added;
3263 the others were already declared.
3265 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3266 before checking whether it's out of range. Put the check inside
3268 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3270 2012-05-27 Ken Brown <kbrown@cornell.edu>
3272 * callproc.c (Fcall_process): Restore a line that was accidentally
3273 commented out in the 2011-02-13 change (bug#11547).
3275 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3277 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3278 defined on ralloc.c.
3280 * buffer.c [REL_ALLOC]: Remove prototypes of
3281 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3282 they are now on lisp.h.
3284 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3286 * search.c (search_buffer): Use it to inhibit relocation of buffer
3287 text while re_search_2 is doing its job, because re_search_2 is
3288 passed C pointers to buffer text. (Bug#11519)
3290 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3293 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3294 state after an additional call to move_it_in_display_line_to, keep
3295 the values of it->max_ascent and it->max_descent found for the
3297 (pos_visible_p): Revert the comparison against bottom_y to what it
3298 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3301 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3303 Fix coding-related core dumps with gcc -ftrapv.
3304 The code was computing A - B, where A and B are pointers, and B is
3305 random garbage. This can lead to core dumps on platforms that
3306 have special pointer registers, and it also leads to core dumps on
3307 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3308 A - B only when B is initialized properly.
3309 * coding.c (coding_set_source, coding_set_destination): Return void.
3310 (coding_change_source, coding_change_destinations): New functions,
3311 with the old behaviors of coding_set_source and coding_set_destination.
3312 All callers that need an offset changed to use these new functions.
3314 2012-05-26 Glenn Morris <rgm@gnu.org>
3316 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3318 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3320 Extend mouse support on W32 text-mode console.
3321 * xdisp.c (draw_row_with_mouse_face):
3322 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3324 * w32console.c: Include window.h.
3325 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3327 (initialize_w32_display): Initialize mouse-highlight data.
3329 * w32inevt.c: Include termchar.h and window.h.
3330 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3331 moves, call note_mouse_highlight. If help_echo changed, call
3332 gen_help_event to produce help-echo message in the echo area.
3333 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3336 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3338 * lread.c (read1): Simplify slightly to avoid an overflow warning
3339 with GCC 4.7.0 on x86-64.
3341 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3343 * bidi.c (bidi_mirror_char): Revert last change: an int is
3344 definitely wide enough here.
3346 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3348 Fix integer width and related bugs (Bug#9874).
3349 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3350 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3351 (string_bytes, check_sblock, allocate_string_data):
3352 (compact_small_strings, Fmake_bool_vector, make_string)
3353 (make_unibyte_string, make_multibyte_string)
3354 (make_string_from_bytes, make_specified_string)
3355 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3356 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3359 (allocate_pseudovector):
3360 Use int, not EMACS_INT, where int is wide enough.
3361 (inhibit_garbage_collection, Fgarbage_collect):
3362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3363 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3364 int might not be wide enough.
3365 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3366 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3367 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3368 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3369 (bidi_level_of_next_char, bidi_move_to_visually_next):
3370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3371 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3372 (Fkill_buffer, Fset_buffer_major_mode)
3373 (advance_to_char_boundary, Fbuffer_swap_text)
3374 (Fset_buffer_multibyte, overlays_at, overlays_in)
3375 (overlay_touches_p, struct sortvec, record_overlay_string)
3376 (overlay_strings, recenter_overlay_lists)
3377 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3378 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3379 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3380 (Foverlay_recenter, last_overlay_modification_hooks_used)
3381 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3383 (validate_region): Omit unnecessary test for b <= e,
3384 since that's guaranteed by the previous test.
3385 (adjust_overlays_for_delete): Avoid pos + length overflow.
3386 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3387 (report_overlay_modification):
3388 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3389 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3390 Omit pointer cast, which isn't needed anyway, and doesn't work
3391 after the EMACS_INT -> ptrdiff_t change.
3392 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3393 * buffer.h: Adjust decls to match defn changes elsewhere.
3394 (struct buffer_text, struct buffer):
3395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3396 Use EMACS_INT, not int, where int might not be wide enough.
3397 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3398 not int, to avoid needless 32-bit limit on 64-bit hosts.
3399 (exec_byte_code): Use tighter memory-full test, one that checks
3400 for alloca overflow. Don't compute the address of the object just
3401 before an array, as that's not portable. Use EMACS_INT, not
3402 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3403 * callint.c (Fcall_interactively):
3404 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3405 * callproc.c (call_process_kill, Fcall_process):
3406 Don't assume pid_t fits into an Emacs fixnum.
3407 (call_process_cleanup, Fcall_process, child_setup):
3408 Don't assume pid_t fits into int.
3409 (call_process_cleanup, Fcall_process, delete_temp_file)
3410 (Fcall_process_region):
3411 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3412 (Fcall_process): Simplify handling of volatile integers.
3413 Use int, not EMACS_INT, where int will do.
3414 * casefiddle.c (casify_object, casify_region, operate_on_word)
3415 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3417 (casify_object): Avoid integer overflow when overallocating buffer.
3418 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3419 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3420 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3421 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3422 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3423 integers are now checked earlier. All uses replaced with XINT.
3425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3426 For CCL_MapSingle, check that content and value are in int range.
3427 (ccl_driver, Fregister_code_conversion_map):
3428 Check that Vcode_version_map_vector is a vector.
3429 (resolve_symbol_ccl_program): Check that vector header is in range.
3430 Always copy the vector, so that we can check its contents reliably
3431 now rather than having to recheck each instruction as it's being
3432 executed. Check that vector words fit in 'int'.
3433 (ccl_get_compiled_code, Fregister_ccl_program)
3434 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3435 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3436 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3437 contents are in range.
3438 (Fccl_execute_on_string): Check that status is in range.
3439 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3440 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3441 Accept and return EMACS_INT, not int, because callers can pass values
3443 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3444 (multibyte_chars_in_text, parse_str_as_multibyte)
3445 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3446 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3447 (string_escape_byte8, Fget_byte):
3448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3449 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3450 avoid mishandling large integers.
3451 * character.h: Adjust decls to match defn changes elsewhere.
3452 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3453 (Ffind_charset_region):
3454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3455 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3456 (load_charset_map_from_vector, Fdefine_charset_internal):
3457 Don't assume fixnum fits in int.
3458 (load_charset_map_from_vector, Fmap_charset_chars):
3459 Remove now-unnecessary CHECK_NATNUMs.
3460 (Fdefine_charset_internal): Check ranges here, more carefully.
3461 Don't rely on undefined behavior with signed left shift overflow.
3462 Don't assume unsigned int fits into fixnum, or that fixnum fits
3463 into unsigned int. Don't require max_code to be a valid fixnum;
3464 that's not true for gb10830 4-byte on a 32-bit host. Allow
3465 invalid_code to be a cons, for the same reason. Require code_offset
3466 to be a character. Avoid int overflow if max_char is close
3468 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3469 this is intended anyway and avoids some undefined behavior.
3470 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3471 INDEX_TO_CODE_POINT, as that's what it expects.
3472 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3473 * charset.h (DECODE_CHAR): Return int, not unsigned;
3474 this is what was intended anyway, and it avoids undefined behavior.
3475 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3476 integer-overflow issues.
3477 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3478 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3479 where the argument is EMACS_INT, and this behavior is not intended.
3480 * chartab.c (Fmake_char_table, Fset_char_table_range)
3481 (uniprop_get_decoder, uniprop_get_encoder):
3482 Don't assume fixnum fits in int.
3483 * cmds.c (move_point): New function, that does the gist of
3484 Fforward_char and Fbackward_char, but does so while checking
3485 for integer overflow more accurately.
3486 (Fforward_char, Fbackward_char): Use it.
3487 (Fforward_line, Fend_of_line, internal_self_insert)
3488 (internal_self_insert):
3489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3490 Fix a FIXME, by checking for integer overflow when calculating
3491 target_clm and actual_clm.
3492 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3493 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3494 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3495 (coding_alloc_by_making_gap, alloc_destination)
3496 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3497 (encode_coding_utf_16, detect_coding_emacs_mule)
3498 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3499 (detect_coding_iso_2022, decode_coding_iso_2022)
3500 (encode_invocation_designation, encode_designation_at_bol)
3501 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3502 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3503 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3504 (encode_coding_ccl, encode_coding_raw_text)
3505 (detect_coding_charset, decode_coding_charset)
3506 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3507 (produce_composition, produce_charset, produce_annotation)
3508 (decode_coding, handle_composition_annotation)
3509 (handle_charset_annotation, consume_chars, decode_coding_gap)
3510 (decode_coding_object, encode_coding_object, detect_coding_system)
3511 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3512 (code_convert_region, code_convert_string)
3513 (Fdefine_coding_system_internal)
3514 (coding_set_source, coding_set_destination):
3515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3516 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3517 (Fdefine_coding_system_internal):
3518 Don't assume fixnums fit in int.
3519 (decode_coding_gap, decode_coding_object, encode_coding_object)
3520 (Fread_coding_system, Fdetect_coding_region)
3521 (Funencodable_char_position, Fcheck_coding_systems_region)
3522 (get_translation, handle_composition_annotation, consume_chars):
3523 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3524 (consume_chars): Rewrite to not calculate an address outside buffer.
3525 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3526 Don't access memory outside of the args array.
3527 (Fdefine_coding_system_internal): Check for charset-id overflow.
3528 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3529 result of ENCODE_CHAR.
3530 * coding.h: Adjust decls to match defn changes elsewhere.
3531 (struct coding_system):
3532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3533 * composite.c (get_composition_id, find_composition)
3534 (run_composition_function, update_compositions)
3535 (compose_text, composition_gstring_put_cache)
3536 (composition_gstring_p, composition_gstring_width)
3537 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3538 (composition_compute_stop_pos, composition_reseat_it)
3539 (composition_update_it, struct position_record)
3540 (find_automatic_composition, composition_adjust_point)
3541 (Fcomposition_get_gstring, Ffind_composition_internal):
3542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3543 (update_compositions):
3544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3545 * composite.h: Adjust decls to match defn changes elsewhere.
3546 (struct composition):
3547 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3548 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3549 Do not attempt to compute the address of the object just before a
3550 buffer; this is not portable.
3552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3553 (Faset): Use int, not EMACS_INT, where int is wide enough.
3554 (Fstring_to_number): Don't assume fixnums fit in int.
3555 (Frem): Don't assume arg is nonnegative.
3556 * dbusbind.c (xd_append_arg): Check for integers out of range.
3557 (Fdbus_call_method): Don't overflow the timeout int.
3558 (extract_signed, extract_unsigned): New functions.
3559 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3560 (xd_get_connection_references): Return ptrdiff_t, not int.
3562 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3563 (xd_read_message_1):
3564 Use int, not unsigned, where the dbus API uses int.
3565 (Fdbus_message_internal): Don't overflow mtype.
3566 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3567 * dired.c (directory_files_internal, file_name_completion, scmp)
3568 (file_name_completion_stat):
3569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3570 (file_name_completion): Don't overflow matchcount.
3571 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3572 * dispextern.h: Adjust decls to match defn changes elsewhere.
3573 (struct text_pos, struct glyph, struct bidi_saved_info)
3574 (struct bidi_string_data, struct bidi_it, struct composition_it)
3576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3577 (struct display_pos, struct composition_it, struct it):
3578 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3579 * dispnew.c (increment_matrix_positions)
3580 (increment_row_positions, mode_line_string)
3581 (marginal_area_string):
3582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3583 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3585 (duration_to_sec_usec): New function, to check for overflow better.
3586 (Fsleep_for, sit_for): Use it.
3587 * doc.c (get_doc_string, store_function_docstring):
3588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3589 (get_doc_string, Fsnarf_documentation):
3590 Use int, not EMACS_INT, where int is wide enough.
3592 Use SAFE_ALLOCA, not alloca.
3593 Check for overflow when converting EMACS_INT to off_t.
3594 * doprnt.c (doprnt):
3595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3596 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3597 Don't assume uid_t fits into fixnum.
3598 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3599 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3600 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3601 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3602 (general_insert_function)
3603 (Finsert_char, make_buffer_string, make_buffer_string_both)
3604 (update_buffer_properties, Fbuffer_substring)
3605 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3606 (Fsubst_char_in_region, check_translation)
3607 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3608 (transpose_markers, Ftranspose_regions):
3609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3610 (clip_to_bounds): Move to lisp.h as an inline function).
3611 (Fconstrain_to_field): Don't assume integers are nonnegative.
3612 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3613 (Fsubst_char_in_region, Fsave_restriction):
3614 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3615 (Femacs_pid): Don't assume pid_t fits into fixnum.
3616 (lo_time): Use int, not EMACS_INT, when int suffices.
3617 (lisp_time_argument): Check for usec out of range.
3618 (Fencode_time): Don't assume fixnum fits in int.
3619 (Fuser_login_name, Fuser_full_name): Signal an error
3620 if a uid argument is out of range, rather than relying on
3622 (Fformat_time_string): Remove now-unnecessary check.
3623 lisp_time_argument checks for out-of-range usec now.
3624 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3625 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3626 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3627 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3628 (init_cmdargs, Fdump_emacs):
3629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3630 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3631 the bottom (typically) 32 bits of the fixnum.
3632 * eval.c (specpdl_size, call_debugger):
3633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3634 (when_entered_debugger, Fbacktrace_debug):
3635 Don't assume fixnum can fit in int.
3636 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3637 the object just before a buffer; this is not portable.
3638 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3639 (grow_specpdl, unbind_to):
3640 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3641 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3642 (grow_specpdl): Simplify allocation by using xpalloc.
3643 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3644 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3645 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3646 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3647 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3650 (Fcopy_file, non_regular_nbytes, read_non_regular)
3651 (Finsert_file_contents):
3652 Use int, not EMACS_INT, where int is wide enough.
3653 (READ_BUF_SIZE): Verify that it fits in int.
3654 (Finsert_file_contents): Check that counts are in proper range,
3655 rather than assuming fixnums fit into ptrdiff_t etc.
3656 Don't assume fixnums fit into int.
3657 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3658 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3659 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3660 (string_char_to_byte, string_byte_to_char)
3661 (string_make_multibyte, string_to_multibyte)
3662 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3663 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3664 (substring_both, Fdelete, internal_equal, Ffillarray)
3665 (Fclear_string, mapcar1)
3666 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3667 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3668 (larger_vector, make_hash_table, maybe_resize_hash_table)
3669 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3670 (Fmaphash, secure_hash):
3671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3672 (concat): Check for string index and length overflow.
3673 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3675 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3676 (larger_vector): New API (vec, incr_min, size_max) replaces old
3677 one (vec, new_size, init). This catches size overflow.
3678 INIT was removed because it was always Qnil.
3679 All callers changed.
3680 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3681 the upper bound on a hash table index size.
3682 (make_hash_table, maybe_resize_hash_table): Use it.
3683 (secure_hash): Computer start_byte and end_byte only after
3684 they're known to be in ptrdiff_t range.
3685 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3686 (Ffont_get_glyphs, Ffont_at):
3687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3688 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3689 (Flist_fonts, Fopen_font):
3690 Don't assume fixnum can fit in int.
3691 (check_gstring): Don't assume index can fit in int.
3692 (font_match_p): Check that fixnum is a character, not a nonnegative
3693 fixnum, since the later code needs to stuff it into an int.
3694 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3695 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3696 conversion overflow issues.
3697 (Fopen_font): Check for integer out of range.
3698 (Ffont_get_glyphs): Don't assume index can fit in int.
3699 * font.h: Adjust decls to match defn changes elsewhere.
3700 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3702 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3703 printmax_t, where ptrdiff_t is wide enough.
3704 (Finternal_char_font):
3705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3706 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3707 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3708 (Fset_frame_position, x_set_frame_parameters)
3709 (x_set_line_spacing, x_set_border_width)
3710 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3711 Check that fixnums are in proper range for system types.
3712 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3714 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3715 Use SAFE_ALLOCA_LISP, not alloca.
3716 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3717 intptr_t is wide enough.
3718 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3719 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3720 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3721 Check for fixnum out of range.
3722 * ftfont.c (ftfont_list): Don't assume index fits in int.
3723 Check that fixnums are in proper range for system types.
3724 (ftfont_shape_by_flt):
3725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3726 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3728 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3729 Check that fixnums are in proper range for system types.
3730 * gnutls.h: Adjust decls to match defn changes elsewhere.
3731 * gtkutil.c (xg_dialog_run):
3732 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3733 (update_frame_tool_bar):
3734 Check that fixnums are in proper range for system types.
3735 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3736 (lookup_image): Check that fixnums are in range for system types.
3737 * indent.c (last_known_column, last_known_column_point):
3738 (current_column_bol_cache):
3739 (skip_invisible, current_column, check_display_width):
3740 (check_display_width, scan_for_column, current_column_1)
3741 (Findent_to, Fcurrent_indentation, position_indentation)
3742 (indented_beyond_p, Fmove_to_column, compute_motion):
3743 (Fcompute_motion, Fvertical_motion):
3744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3745 (last_known_column_modified): Use EMACS_INT, not int.
3746 (check_display_width):
3748 Check that fixnums and floats are in proper range for system types.
3749 (compute_motion): Don't assume index or fixnum fits in int.
3750 (compute_motion, Fcompute_motion):
3751 Use int, not EMACS_INT, when it is wide enough.
3752 (vmotion): Omit local var start_hpos that is always 0; that way
3753 we don't need to worry about overflow in expressions involving it.
3754 * indent.h: Adjust decls to match defn changes elsewhere.
3756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3757 Use int, not EMACS_INT, where int is wide enough.
3758 Remove unused members ovstring_chars_done and tab_offset;
3760 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3761 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3762 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3763 (make_gap, copy_text, insert, insert_and_inherit)
3764 (insert_before_markers, insert_before_markers_and_inherit)
3765 (insert_1, count_combining_before, count_combining_after)
3766 (insert_1_both, insert_from_string)
3767 (insert_from_string_before_markers, insert_from_string_1)
3768 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3769 (adjust_after_replace, adjust_after_insert, replace_range)
3770 (replace_range_2, del_range, del_range_1, del_range_byte)
3771 (del_range_both, del_range_2, modify_region)
3772 (prepare_to_modify_buffer, signal_before_change)
3773 (signal_after_change, Fcombine_after_change_execute):
3774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3775 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3776 (balance_an_interval, split_interval_right, split_interval_left)
3777 (find_interval, next_interval, update_interval)
3778 (adjust_intervals_for_insertion, delete_node, delete_interval)
3779 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3780 (static_offset_intervals, offset_intervals)
3781 (merge_interval_right, merge_interval_left, make_new_interval)
3782 (graft_intervals_into_buffer, temp_set_point_both)
3783 (temp_set_point, set_point, adjust_for_invis_intang)
3784 (set_point_both, move_if_not_intangible, get_property_and_range)
3785 (get_local_map, copy_intervals, copy_intervals_to_string)
3786 (compare_string_intervals, set_intervals_multibyte_1):
3787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3788 * intervals.h: Adjust decls to match defn changes elsewhere.
3790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3791 * keyboard.c (this_command_key_count, this_single_command_key_start)
3792 (before_command_key_count, before_command_echo_length, echo_now)
3793 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3794 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3795 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3796 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3798 (last_non_minibuf_size, last_point_position, echo_truncate)
3799 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3800 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3801 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3802 (stuff_buffered_input):
3803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3804 (last_auto_save, command_loop_1, read_char):
3805 Use EMACS_INT, not int, to avoid integer overflow.
3806 (record_char): Avoid overflow in total_keys computation.
3807 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3808 * keyboard.h: Adjust decls to match defn changes elsewhere.
3809 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3810 (Fkey_description, Fdescribe_vector, Flookup_key):
3811 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3812 (click_position): New function, to check that positions are in range.
3813 (Fcurrent_active_maps):
3815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3816 (Faccessible_keymaps, Fkey_description):
3817 (preferred_sequence_p):
3818 Don't assume fixnum can fit into int.
3819 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3820 Check for integer overflow in size calculations.
3821 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3822 avoid mishandling large integers.
3823 * lisp.h: Adjust decls to match defn changes elsewhere.
3824 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3825 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3826 (struct Lisp_Marker):
3827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3828 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3829 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3830 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3831 All callers changed.
3832 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3833 Assume the arg has valid form, since it always does.
3834 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3835 unsigned integer system type.
3836 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3837 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3839 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3840 (duration_to_sec_usec): New decl.
3841 * lread.c (read_from_string_index, read_from_string_index_byte)
3842 (read_from_string_limit, readchar, unreadchar, openp)
3843 (read_internal_start, read1, oblookup):
3844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3845 (Fload, readevalloop, Feval_buffer, Feval_region):
3846 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3847 (openp): Check for out-of-range argument to 'access'.
3848 (read1): Use int, not EMACS_INT, where int is wide enough.
3849 Don't assume fixnum fits into int.
3850 Fix off-by-one error that can read outside a buffer.
3851 (read_filtered_event): Use duration_to_sec_usec
3852 to do proper overflow checking on durations.
3853 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3854 in size calculation.
3855 (Fexecute_kbd_macro):
3856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3857 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3858 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3859 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3860 (set_marker_both, set_marker_restricted_both, marker_position)
3861 (marker_byte_position, Fbuffer_has_markers_at):
3862 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3863 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3864 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3865 It now merely ensures that the menu is large enough, without
3866 necessarily growing it, as this avoids some integer overflow issues.
3867 All callers changed.
3868 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3869 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3870 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3871 Use SAFE_ALLOCA_LISP, not alloca.
3872 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3873 to EMACS_INT. Check that fixnums are in proper range for system types.
3874 * minibuf.c (minibuf_prompt_width, string_to_object)
3875 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3876 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3877 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3878 (get_minibuffer, read_minibuf_unwind):
3879 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3880 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3881 this simplifies overflow checking. All callers changed.
3882 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3885 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3886 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3887 Check that fixnums are in proper range for system types.
3888 (Fx_create_frame, Fx_show_tip):
3889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3890 * nsfont.m (ns_findfonts, nsfont_list_family):
3891 Don't assume fixnum fits in long.
3892 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3893 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3894 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3896 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3898 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3899 (PRINTDECLARE, PRINTPREPARE):
3900 (strout, print_string):
3901 (print, print_preprocess, print_check_string_charset_prop)
3903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3905 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3907 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3908 (printchar, strout): Use xpalloc to catch size calculation overflow.
3909 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3910 (print_error_message): Use SAFE_ALLOCA, not alloca.
3911 (print_object): Use int, not EMACS_INT, where int is wide enough.
3912 (print_depth, new_backquote_output, print_number_index):
3913 Use ptrdiff_t, not int, where int might not be wide enough.
3914 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3915 (Fset_process_window_size, Fformat_network_address)
3916 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3918 Check that fixnums are in proper range for system types.
3919 (Fsignal_process): Simplify by avoiding a goto.
3920 Check for process-ids out of pid_t range rather than relying on
3922 (process_tick, update_tick): Use EMACS_INT, not int.
3923 (Fformat_network_address, read_process_output, send_process)
3924 (Fprocess_send_region, status_notify):
3925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3926 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3927 (wait_reading_process_output, read_process_output, exec_sentinel):
3928 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3929 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3930 (Faccept_process_output): Use duration_to_sec_usec to do proper
3931 overflow checking on durations.
3932 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3933 Don't assume pid_t fits in int.
3934 * process.h (struct Lisp_Process): Members tick and update_tick
3935 are now of type EMACS_INT, not int.
3936 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3937 configured --with-wide-int.
3938 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3939 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3940 * search.c (looking_at_1, string_match_1):
3941 (fast_string_match, fast_c_string_match_ignore_case)
3942 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3943 (scan_newline, find_before_next_newline, search_command)
3944 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3945 (set_search_regs, wordify):
3948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3949 (string_match_1, search_buffer, set_search_regs):
3951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3952 (wordify): Check for overflow in size calculation.
3953 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3954 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3955 Check that fixnums are in proper range for system types.
3956 * sound.c (struct sound_device)
3957 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3959 (Fplay_sound_internal):
3960 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3961 * syntax.c (struct lisp_parse_state, find_start_modiff)
3962 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3963 (Fparse_partial_sexp):
3964 Don't assume fixnums can fit in int.
3965 (struct lisp_parse_state, find_start_pos, find_start_value)
3966 (find_start_value_byte, find_start_begv)
3967 (update_syntax_table, char_quoted, dec_bytepos)
3968 (find_defun_start, prev_char_comend_first, back_comment):
3969 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3970 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3972 (Finternal_describe_syntax_value): Check that match_lisp is a
3973 character, not an integer, since the code stuffs it into int.
3974 (scan_words, scan_sexps_forward):
3975 Check that fixnums are in proper range for system types.
3977 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3978 (scan_sexps_forward):
3979 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3980 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3981 * syntax.h: Adjust decls to match defn changes elsewhere.
3982 (struct gl_state_s):
3983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3984 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3985 MOST_POSITIVE_FIXNUM.
3986 * sysdep.c (wait_for_termination_1, wait_for_termination)
3987 (interruptible_wait_for_termination, mkdir):
3988 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3989 (emacs_read, emacs_write):
3990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3991 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3992 and double all fit in int.
3993 * term.c (set_tty_color_mode):
3994 Check that fixnums are in proper range for system types.
3995 * termhooks.h (struct input_event):
3996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3997 * textprop.c (validate_interval_range, interval_of)
3998 (Fadd_text_properties, set_text_properties_1)
3999 (Fremove_text_properties, Fremove_list_of_text_properties)
4000 (Ftext_property_any, Ftext_property_not_all)
4001 (copy_text_properties, text_property_list, extend_property_ranges)
4002 (verify_interval_modification):
4003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4004 (Fnext_single_char_property_change)
4005 (Fprevious_single_char_property_change):
4006 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4007 (copy_text_properties):
4008 Check for integer overflow in index calculation.
4009 * undo.c (last_boundary_position, record_point, record_insert)
4010 (record_delete, record_marker_adjustment, record_change)
4011 (record_property_change):
4012 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4013 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4015 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4016 (Fx_hide_tip, Fx_file_dialog):
4017 * w32menu.c (set_frame_menubar):
4018 Use ptrdiff_t, not int, for consistency with rest of code.
4019 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4020 (select_window, Fdelete_other_windows_internal)
4021 (window_scroll_pixel_based, window_scroll_line_based)
4022 (Frecenter, Fset_window_configuration):
4023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4024 (Fset_window_hscroll, run_window_configuration_change_hook)
4025 (set_window_buffer, temp_output_buffer_show, scroll_command)
4026 (Fscroll_other_window, Frecenter):
4027 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4028 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4029 Don't assume fixnum fits in int.
4030 (Fset_window_scroll_bars):
4031 Check that fixnums are in proper range for system types.
4032 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4033 (string_pos, c_string_pos, number_of_chars, init_iterator)
4034 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4035 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4036 (compute_display_string_end, handle_face_prop)
4037 (face_before_or_after_it_pos, handle_invisible_prop)
4038 (handle_display_prop, handle_display_spec, handle_single_display_spec)
4039 (display_prop_intangible_p, string_buffer_position_lim)
4040 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4041 (get_overlay_strings_1, get_overlay_strings)
4042 (iterate_out_of_display_property, forward_to_next_line_start)
4043 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4044 (get_next_display_element, set_iterator_to_next)
4045 (get_visually_first_element, compute_stop_pos_backwards)
4046 (handle_stop_backwards, next_element_from_buffer)
4047 (move_it_in_display_line_to, move_it_in_display_line)
4048 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4049 (add_to_log, message_dolog, message_log_check_duplicate)
4050 (message2, message2_nolog, message3, message3_nolog
4051 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4052 (current_message_1, truncate_echo_area, truncate_message_1)
4053 (set_message, set_message_1, store_mode_line_noprop)
4054 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4055 (text_outside_line_unchanged_p, check_point_in_composition)
4056 (reconsider_clip_changes)
4057 (redisplay_internal, set_cursor_from_row, try_scrolling)
4058 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4059 (redisplay_window, find_last_unchanged_at_beg_row)
4060 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4061 (trailing_whitespace_p, find_row_edges, display_line)
4062 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4063 (display_mode_element, store_mode_line_string)
4064 (pint2str, pint2hrstr, decode_mode_spec)
4065 (display_count_lines, display_string, draw_glyphs)
4066 (x_produce_glyphs, x_insert_glyphs)
4067 (rows_from_pos_range, mouse_face_from_buffer_pos)
4068 (fast_find_string_pos, mouse_face_from_string_pos)
4069 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4070 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4071 (safe_call, init_from_display_pos, handle_fontified_prop)
4072 (handle_single_display_spec, load_overlay_strings)
4073 (with_echo_area_buffer, setup_echo_area_for_printing)
4074 (display_echo_area, echo_area_display)
4075 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4076 (update_tool_bar, hscroll_window_tree, redisplay_internal)
4077 (redisplay_window, dump_glyph_row, display_mode_line)
4078 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
4079 (handle_display_spec, display_prop_string_p):
4080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4081 (handle_single_display_spec, build_desired_tool_bar_string)
4082 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4083 (get_specified_cursor_type):
4084 Check that fixnums are in proper range for system types.
4085 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4086 (Flookup_image_map):
4087 Don't assume fixnums fit in int.
4088 (compare_overlay_entries):
4089 Avoid mishandling comparisons due to subtraction overflow.
4090 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4091 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4092 (handle_tool_bar_click):
4093 Use int, not unsigned, since we prefer signed and the signedness
4094 doesn't matter here.
4095 (get_next_display_element, next_element_from_display_vector):
4096 Use int, not EMACS_INT, when int is wide enough.
4097 (start_hourglass): Use duration_to_sec_usec to do proper
4098 overflow checking on durations.
4099 * xfaces.c (Fbitmap_spec_p):
4100 Check that fixnums are in proper range for system types.
4101 (compare_fonts_by_sort_order):
4102 Avoid mishandling comparisons due to subtraction overflow.
4103 (Fx_family_fonts, realize_basic_faces):
4104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4106 Don't assume fixnum fits in int.
4107 Use SAFE_ALLOCA_LISP, not alloca.
4108 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4109 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4110 (face_at_buffer_position, face_for_overlay_string)
4111 (face_at_string_position):
4112 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4113 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4114 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4116 Check that fixnums are in proper range for system types.
4117 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4118 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4120 (Fx_change_window_property): Don't assume fixnums fit in int.
4121 * xfont.c (xfont_chars_supported):
4122 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4123 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4124 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4125 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4126 * xml.c (parse_region):
4127 * xrdb.c (magic_file_p):
4128 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4129 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4130 (x_get_local_selection, x_reply_selection_request)
4131 (x_handle_selection_request, wait_for_property_change):
4132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4133 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4134 short is wide enough.
4135 (x_send_client_event): Don't assume fixnum fits in int.
4136 * xterm.c (x_x_to_emacs_modifiers):
4137 Don't assume EMACS_INT overflows nicely into int.
4138 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4140 (handle_one_xevent): NATNUMP can eval its arg twice.
4141 (x_connection_closed):
4142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4143 * xterm.h: Adjust decls to match defn changes elsewhere.
4144 (struct scroll_bar): Use struct vectorlike_header
4145 rather than rolling our own approximation.
4146 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4148 2012-05-25 Glenn Morris <rgm@gnu.org>
4150 * lisp.mk (lisp): Update for more files being compiled now.
4152 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4154 * lread.c: Remove `read_pure' which makes no difference.
4155 (read_pure): Remove var.
4156 (unreadpure): Remove function.
4157 (readevalloop): Don't call read_list with -1 flag.
4158 (read1, read_vector): Don't test read_pure any more.
4159 (read_list): Simplify.
4161 * fileio.c, character.h: Minor style tweaks.
4163 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4165 * window.h (clip_changed): Remove useless declaration.
4167 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4169 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4170 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4172 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4175 This directory predates autoconf and is no longer needed nowadays.
4176 Move its few remaining bits of functionality to where they're needed.
4177 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4178 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4179 * m/template.h: Remove.
4180 * Makefile.in (M_FILE): Remove. All uses removed.
4181 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4182 * lisp.h (USE_LSB_TAG):
4183 * mem-limits.h (EXCEEDS_LISP_PTR):
4184 Use VAL_MAX, not VALBITS, in #if.
4185 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4186 (EMACS_UINT): Define unconditionally now.
4187 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4188 (BITS_PER_EMACS_INT): New constants, replacing
4189 what used to be in config.h, but not useful in #if.
4190 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4191 define them any more.
4192 (VAL_MAX): New macro.
4194 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4195 BITS_PER_EMACS_INT, in #if.
4196 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4197 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4198 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4199 * s/ms-w32.h (DATA_START):
4200 Move here from removed file m/intel386.h.
4201 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4202 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4204 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4206 Assume C89 or later.
4207 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4208 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4210 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4211 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4212 * textprop.c, tparam.c (NULL): Remove.
4213 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4214 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4215 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4216 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4217 * xterm.c (input_signal_count): Assume volatile works.
4219 2012-05-21 Ken Brown <kbrown@cornell.edu>
4221 * xgselect.c (xg_select): Fix first argument in call to 'select'
4224 2012-05-20 Ken Brown <kbrown@cornell.edu>
4226 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4227 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4229 2012-05-19 Ken Brown <kbrown@cornell.edu>
4231 * xfns.c (x_in_use): Remove `static' qualifier.
4232 * xterm.h (x_in_use): Declare.
4233 * xgselect.c: Include xterm.h.
4234 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4235 and `display_arg' (bug#9754).
4237 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4239 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4241 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4242 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4244 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4246 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4248 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4249 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4251 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4252 reference to image_cache->refcount.
4253 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4255 2012-05-17 Juri Linkov <juri@jurta.org>
4257 * search.c (Fword_search_regexp, Fword_search_backward)
4258 (Fword_search_forward, Fword_search_backward_lax)
4259 (Fword_search_forward_lax): Move functions to isearch.el
4260 (bug#10145, bug#11381).
4262 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4264 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4266 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4268 * lread.c (init_obarray): Declare Qt and Qnil as special.
4270 2012-05-14 Glenn Morris <rgm@gnu.org>
4272 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4273 Put "libexec" before "bin", for the sake of init_callproc_1.
4275 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4277 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4279 * unexaix.c: Port to more-recent AIX compilers.
4280 (report_error, report_error_1, make_hdr, copy_sym)
4281 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4282 Make arguments const char *, not char *, to avoid violations of C
4283 standard and to fix some AIX warnings reported by Gilles Pion.
4285 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4287 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4288 already have overlays loaded.
4289 (handle_single_display_spec): Before returning without displaying
4290 fringe bitmap, synchronize the bidi iterator with the main display
4291 iterator, by calling iterate_out_of_display_property.
4292 (iterate_out_of_display_property): Detect buffer iteration by
4293 testing that it->string is a Lisp string.
4294 (get_next_display_element): When the current object is exhausted,
4295 and there's something on it->stack, call set_iterator_to_next to
4296 proceed with what's on the stack, instead of returning zero.
4297 (set_iterator_to_next): If called at the end of a Lisp string,
4298 proceed to consider_string_end without incrementing string
4299 position. Don't increment display vector index past the end of
4300 the display vector. (Bug#11417)
4301 (pos_visible_p): Don't report a position visible when move_it_to
4302 stopped at the last line of window, which happens to be scanned
4303 backwards by the bidi iteration. (Bug#11464)
4305 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4307 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4308 and right-margin display specs even if the spec is invalid or we
4309 are on a TTY, and thus unable to display on the fringes.
4310 That's because the text with the property will not be displayed anyway,
4311 so we need to signal to the caller that this is a "replacing"
4312 display spec. This fixes display when the spec is invalid or we
4315 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4317 * unexaix.c (make_hdr): Fix typo in prototype.
4318 This bug broke the build on AIX. Problem reported by Gilles Pion.
4320 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4322 * keyboard.c (kbd_buffer_get_event): Read special events also in
4323 batch mode. (Bug#11415)
4325 2012-05-12 Glenn Morris <rgm@gnu.org>
4327 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4329 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4331 * lisp.mk (lisp): Add newcomment.elc.
4333 2012-05-12 Glenn Morris <rgm@gnu.org>
4335 * Makefile.in (MKDIR_P): New, set by configure.
4336 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4338 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4340 Remove unused function hourglass_started.
4341 * dispextern.h (hourglass_started):
4342 * w32fns.c (hourglass_started):
4343 * xdisp.c (hourglass_started): Remove.
4345 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4347 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4348 Update dependencies.
4350 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4352 * xgselect.c (xg_select): Put maxfds+1 into a var.
4353 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4355 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4357 2012-05-10 Dave Abrahams <dave@boostpro.com>
4359 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4360 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4362 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4364 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4365 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4366 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4367 Initialize xd_registered_buses.
4369 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4371 Untag more efficiently if USE_LSB_TAG.
4372 This is based on a proposal by YAMAMOTO Mitsuharu in
4373 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4374 For an admittedly artificial (nth 8000 longlist) benchmark on
4375 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4376 Emacs's overall text size by 1%.
4377 * lisp.h (XUNTAG): New macro.
4378 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4379 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4380 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4381 * eval.c (Fautoload):
4382 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4383 * frame.h (XFRAME): Use XUNTAG.
4385 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4386 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4387 Remove unportable assumptions about print widths of types like
4389 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4390 intptr_t when converting between pointer and integer, to avoid GCC
4391 warnings about wrong width.
4393 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4395 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4396 stack for each reader_thread, instead of defaulting to 8MB
4397 determined by the linker. This avoids failures in creating
4398 subprocesses on Windows 7, see the discussion in this thread:
4399 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4401 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4403 Fix up display of the *Minibuf-0* buffer in the mini window.
4404 * keyboard.c (read_char): Don't clear the echo area if there's no
4406 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4407 contents of *Minibuf-0*) if there's no message displayed in its stead.
4409 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4411 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4414 2012-05-06 Chong Yidong <cyd@gnu.org>
4416 * lisp.mk (lisp): Update.
4418 2012-05-05 Jim Meyering <meyering@redhat.com>
4420 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4422 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4424 * data.c (PUT_ERROR): New macro.
4425 (syms_of_data): Use it. Add new error type `user-error'.
4426 * undo.c (user_error): New function.
4427 (Fprimitive_undo): Use it.
4428 * print.c (print_error_message): Adjust print style for `user-error'.
4429 * keyboard.c (user_error): New function.
4430 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4432 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4434 Do not limit current-time-string to years 1000..9999.
4435 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4436 (Fcurrent_time_string): Support any year that is supported by the
4437 underlying localtime representation. Don't use asctime, as it
4438 has undefined behavior for years outside the range -999..9999.
4440 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4442 Fix race conditions involving setenv, gmtime, localtime, asctime.
4443 Without this fix, interrupts could mess up code that uses these
4444 nonreentrant functions, since setting TZ invalidates existing
4445 tm_zone or tzname values, and since most of these functions return
4446 pointers to static storage.
4447 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4448 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4449 Grow the critical sections to include not just invoking
4450 localtime/gmtime, but also accessing these functions' results
4451 including their tm_zone values if any, and any related TZ setting.
4452 (format_time_string): Last arg is now struct tm *, not struct tm **,
4453 so that the struct tm is saved in the critical section.
4454 All callers changed. Simplify allocation of initial buffer, partly
4455 motivated by the fact that memory allocation needs to be outside
4456 the critical section.
4458 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4460 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4461 with RESET_INTERVAL.
4463 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4464 Remove duplicated buffer name initialization.
4466 2012-05-02 Jim Meyering <jim@meyering.net>
4468 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4470 * xfns.c (x_window): Use xstrdup (Bug#11375).
4472 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4474 * xdisp.c (pos_visible_p): If already at a newline from the
4475 display string before the 'while' loop, don't walk back the glyphs
4476 from it3.glyph_row. Solves assertion violation when the display
4477 string begins with a newline (egg.el). (Bug#11367)
4479 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4481 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4484 2012-05-01 Glenn Morris <rgm@gnu.org>
4486 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4487 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4488 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4489 All were removed before 23.1.
4491 * dispnew.c: Remove HAVE_LIBNCURSES test;
4492 it is always true on relevant platforms.
4494 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4495 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4497 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4499 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4501 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4502 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4505 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4507 Do not avoid creating empty evaporating overlays (Bug#9642).
4508 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4509 That is, do not delete an evaporating overlay if it becomes
4510 empty after its bounds are adjusted to fit within its buffer.
4511 This fix caused other problems, and I'm reverting it until we get
4512 to the bottom of them.
4514 2012-04-27 Chong Yidong <cyd@gnu.org>
4516 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4518 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4520 * xdisp.c (pos_visible_p): If the window start position is beyond
4521 ZV, start the display from buffer beginning. Prevents assertion
4522 violation in init_iterator when the minibuffer window is scrolled
4525 * window.c (window_scroll_pixel_based): Likewise.
4527 2012-04-27 Chong Yidong <cyd@gnu.org>
4529 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4531 2012-04-27 Glenn Morris <rgm@gnu.org>
4533 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4534 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4536 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4538 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4539 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4541 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4543 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4544 display element, check also the underlying string or buffer
4545 character. (Bug#11341)
4547 * w32menu.c: Include w32heap.h.
4548 (add_menu_item): If the call to AppendMenuW (via
4549 unicode_append_menu) fails, disable Unicode menus only if we are
4550 running on Windows 9X/Me.
4552 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4554 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4555 (xgetint): Add missing shift for LSB tags.
4557 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4559 * keyboard.c (read_char): Don't wipe echo area for select window
4560 events: These might get delayed via `mouse-autoselect-window'
4563 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4565 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4566 manipulation of :loaded-from data.
4568 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4570 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4571 now a cons (bug#11311).
4573 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4575 Do not create empty overlays with the evaporate property (Bug#9642).
4576 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4577 if it becomes empty after its bounds are adjusted to fit within
4578 its buffer. Without this fix, in a nonempty buffer (let ((o
4579 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4580 yields an empty overlay that has the evaporate property, which is
4581 not supposed to happen.
4583 Fix minor GTK3 problems found by static checking.
4584 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4585 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4586 (struct _EmacsFixedClass, emacs_fixed_get_type):
4587 Move decls here from emacsgtkfixed.h, since they needn't be public.
4588 (emacs_fixed_get_type): Now static.
4589 (emacs_fixed_class_init): Omit unused local.
4590 (emacs_fixed_child_type): Remove; unused.
4591 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4592 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4593 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4594 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4595 (EMACS_FIXED_GET_CLASS): Remove; unused.
4596 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4598 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4599 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4601 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4603 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4604 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4605 (__malloc_size_t, __malloc_ptrdiff_t):
4606 Remove. All uses removed, replaced by the definiens if needed,
4607 since we can assume C89 or better now.
4608 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4609 (protect_malloc_state, align, get_contiguous_space)
4610 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4611 (malloc_atfork_handler_child, malloc_enable_thread)
4612 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4613 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4614 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4615 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4616 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4617 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4618 Define using prototypes, not old style.
4619 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4620 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4621 (align): Don't assume that signed integer overflow wraps around.
4622 Omit unused local var.
4623 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4624 (_free_internal_nolock, memalign, mallochook, reallochook):
4625 Omit no-longer-needed casts.
4626 (valloc): Use getpagesize, not __getpagesize.
4627 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4628 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4630 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4632 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4634 Move functions from C to Lisp. Make non-blocking method calls
4635 the default. Implement further D-Bus standard interfaces.
4637 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4638 (QCdbus_request_name_allow_replacement)
4639 (QCdbus_request_name_replace_existing)
4640 (QCdbus_request_name_do_not_queue)
4641 (QCdbus_request_name_reply_primary_owner)
4642 (QCdbus_request_name_reply_in_queue)
4643 (QCdbus_request_name_reply_exists)
4644 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4645 (QCdbus_registered_serial, QCdbus_registered_method)
4646 (QCdbus_registered_signal): New Lisp objects.
4647 (XD_DEBUG_MESSAGE): Use sizeof.
4648 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4649 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4650 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4651 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4652 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4653 (xd_signature, xd_append_arg): Allow float for integer types.
4654 (xd_get_connection_references): New function.
4655 (xd_get_connection_address): Rename from xd_initialize.
4656 Return cached address.
4657 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4658 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4660 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4661 Return number of refcounts.
4662 (Fdbus_get_unique_name): Make stronger parameter check.
4663 (Fdbus_message_internal): New defun.
4664 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4665 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4666 (Fdbus_send_signal, Fdbus_register_service)
4667 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4668 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4669 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4670 (Vdbus_compiled_version, Vdbus_runtime_version)
4671 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4672 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4673 (Vdbus_message_type_signal): New defvars.
4674 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4677 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4679 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4680 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4681 Do not assume ptrdiff_t is the same width as 'int'.
4683 * alloc.c: Handle unusual debugging option combinations.
4684 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4685 since the two debugging options are incompatible.
4686 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4688 (mem_init, mem_insert, mem_insert_fixup):
4689 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4690 (NEED_MEM_INSERT): Remove; no longer needed.
4692 2012-04-22 Leo Liu <sdl.web@gmail.com>
4694 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4696 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4698 * sysdep.c [__FreeBSD__]: Minor cleanups.
4699 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4700 Use Emacs indenting style more consistently. Avoid some casts.
4701 Use 'double' consistently rather than mixing 'float' and 'double'.
4703 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4705 * sysdep.c (list_system_processes, system_process_attributes):
4706 Add implementation for FreeBSD (Bug#5243).
4708 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4710 * lisp.mk (lisp): Update.
4712 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4714 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4715 It is never used otherwise.
4717 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4719 * print.c (print_preprocess): Only check print_depth if print-circle
4721 (print_object): Check for cycles even when print-circle is nil and
4722 print-gensym is t, but only check print_depth if print-circle is nil.
4724 2012-04-20 Chong Yidong <cyd@gnu.org>
4726 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4727 set the status to "failed" and ensure that sentinel is run.
4729 2012-04-20 Glenn Morris <rgm@gnu.org>
4731 * process.c (Fset_process_inherit_coding_system_flag)
4732 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4733 (Fmake_network_process, Fmake_serial_process): Doc fix.
4735 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4737 * xdisp.c (string_buffer_position_lim): Limit starting position to
4739 (set_cursor_from_row): If called for a mode-line or header-line
4740 row, return zero immediately.
4741 (try_cursor_movement): If inside continuation line, don't back up
4742 farther than the first row after the header line, if any.
4743 Don't consider the header-line row as "partially visible", even if
4744 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4746 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4748 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4751 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4752 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4754 configure: new option --enable-gcc-warnings (Bug#11207)
4755 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4756 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4757 (ALL_CFLAGS): Use new macros rather than old.
4758 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4759 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4760 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4761 -Wunused-result, -Wunused-variable. This should go away once
4762 the Emacs and Gnulib regex code is merged.
4763 (xmalloc, xrealloc): Now static.
4765 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4767 * dired.c (Fsystem_groups): Remove unused local.
4769 2012-04-17 Glenn Morris <rgm@gnu.org>
4771 * dired.c (Fsystem_users): Doc fix.
4773 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4775 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4776 (syms_of_dired): Add them.
4778 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4780 Fix minor alloc.c problems found by static checking.
4781 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4782 New extern decls, to avoid calling undeclared functions.
4783 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4784 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4785 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4786 (NEED_MEM_INSERT): New macro.
4787 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4788 Remove one incorrect comment and fix another.
4790 Fix minor ralloc.c problems found by static checking.
4791 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4792 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4793 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4794 (r_alloc_sbrk): Now static.
4796 Improve ralloc.c interface checking.
4797 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4798 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4799 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4800 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4801 [REL_ALLOC]: ... to here, to check interface.
4802 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4803 Remove decls. This fixes an "It stinks!".
4805 * alloc.c (which_symbols): Fix alignment issue / type clash.
4807 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4809 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4810 (struct Lisp_Misc_Any): Likewise.
4811 (struct Lisp_Free): Likewise.
4812 * alloc.c (union aligned_Lisp_Symbol): Define.
4813 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4814 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4815 (union aligned_Lisp_Misc): Define.
4816 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4817 aligned_Lisp_Misc instead of union Lisp_Misc.
4818 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4820 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4822 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4823 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4824 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4825 * s/netbsd.h, s/sol2-6.h:
4826 Remove definition of GC_MARK_STACK, since the default now works.
4827 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4828 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4829 no longer the default.
4830 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4832 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4834 * lread.c (lisp_file_lexically_bound_p):
4835 Fix hang at ";-*-\n" (bug#11238).
4837 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4839 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4840 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4842 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4844 * nsterm.m (constrainFrameRect): Always constrain when there is only
4845 one screen (Bug#10962).
4847 2012-04-13 Ken Brown <kbrown@cornell.edu>
4849 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4851 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4853 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4855 2012-04-11 Daniel Colascione <dancol@dancol.org>
4857 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4858 against is gone. It's better to use vfork now so that when Cygwin
4859 gains a new, working vfork, we use it automatically (bug#10398).
4861 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4863 * window.c (save_window_save): Obey window-point-insertion-type.
4865 2012-04-11 Glenn Morris <rgm@gnu.org>
4867 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4869 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4871 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4873 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4875 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4876 (force_quit_count): New var.
4877 (handle_interrupt): Use it.
4879 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4881 * w32.c (w32_delayed_load): Record the full path of the library
4882 being loaded (bug#10424).
4884 2012-04-09 Glenn Morris <rgm@gnu.org>
4886 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4887 not just in the obarray, before snarfing them. (Bug#11036)
4889 * Makefile.in ($(leimdir)/leim-list.el):
4890 Pass EMACS rather than BUILT_EMACS.
4892 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4894 * process.c (make_process):
4895 * process.h: Add integer `gnutls_handshakes_tried' member to
4898 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4899 Add convenience `GNUTLS_LOG2i' macro.
4901 * gnutls.c (gnutls_log_function2i): Convenience log function.
4902 (emacs_gnutls_read): Use new log functions,
4903 `gnutls_handshakes_tried' process member, and
4904 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4905 attempts per process (connection).
4907 2012-04-09 Chong Yidong <cyd@gnu.org>
4909 * eval.c (Fuser_variable_p, user_variable_p_eh)
4910 (lisp_indirect_variable): Functions deleted.
4911 (Fdefvar): Caller changed.
4913 * callint.c (Finteractive, Fcall_interactively):
4914 * minibuf.c (Fread_variable): Callers changed.
4916 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4918 * xdisp.c (set_cursor_from_row): If the display string appears in
4919 the buffer at position that is closer to point than the position
4920 after the display string, display the cursor on the first glyph of
4921 the display string. Fixes cursor display when a 'display' text
4922 property immediately follows invisible text. (Bug#11094)
4924 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4926 composite.c: use 'double' consistently
4927 * composite.c (get_composition_id): Use 'double' consistently
4928 instead of converting 'float' to 'double' and vice versa; this is
4929 easier to understand and avoids a GCC warning.
4931 2012-04-09 Glenn Morris <rgm@gnu.org>
4933 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4934 preparation for dumping it with emacs. (Bug#4789)
4935 (leimdir): New variable.
4936 ($(leimdir)/leim-list.el): New rule.
4937 (emacs$(EXEEXT)): Depend on leim-list.el.
4939 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4940 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4941 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4943 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4945 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4948 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4950 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4951 Remove unused local variable.
4953 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4955 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4956 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4957 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4958 objects, as mark_maybe_pointer will catch them otherwise.
4959 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4960 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4962 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4964 Fix typo that broke non-Windows builds.
4965 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4967 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4969 Support building on MS-Windows with libxml2.
4971 * makefile.w32-in (OBJ2): Add xml.$(O).
4972 (GLOBAL_SOURCES): Add xml.c.
4973 ($(BLD)/xml.$(O)): New dependency list.
4975 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4976 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4977 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4978 [!WINDOWSNT]: New macros.
4979 (init_libxml2_functions, libxml2_loaded_p): New functions.
4980 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4981 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4982 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4983 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4985 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4986 Call init_libxml2_functions before calling libxml2 functions.
4987 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4989 * emacs.c: Don't include libxml/parser.h.
4990 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4991 xmlCleanupParser directly.
4993 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4995 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4997 * indent.c (Fvertical_motion): If there is a display string at
4998 point, use it.vpos to compute how many lines to backtrack after
4999 move_it_to point. (Bug#11133)
5001 2012-04-06 Eli Zaretskii <eliz@gnu.org>
5003 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5004 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5005 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5006 macros related to unification of CJK characters. For the details,
5007 see the discussion following the message here:
5008 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5010 2012-04-04 Chong Yidong <cyd@gnu.org>
5012 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5014 2012-04-01 Eli Zaretskii <eliz@gnu.org>
5016 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5017 instead of alloca. (Bug#11138)
5019 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5021 * w32menu.c (is_simple_dialog): Properly check lisp types.
5024 2012-03-31 Eli Zaretskii <eliz@gnu.org>
5026 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5027 position we get to after a call to move_it_to fails the
5028 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5029 only if we wind up in a string from display property. (Bug#11063)
5031 * window.c (Fdelete_other_windows_internal): Invalidate the row
5032 and column information about mouse highlight, so that redisplay
5033 restores it after reallocating the glyph matrices. (Bug#7464)
5035 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5036 string comes from a `display' text property, use the buffer
5037 position of that property as if we actually saw that position in
5039 (move_it_by_lines): Remove the assertion that
5040 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5041 violated when there's a before-string at the beginning of a line.
5044 2012-03-30 Eli Zaretskii <eliz@gnu.org>
5046 * xdisp.c (append_space_for_newline): If the default face was
5047 remapped, use the remapped face for the appended newline.
5048 (extend_face_to_end_of_line): Use the remapped default face for
5049 extending the face to the end of the line.
5050 (display_line): Call extend_face_to_end_of_line when the default
5051 face was remapped. (Bug#11068)
5053 2012-03-29 Eli Zaretskii <eliz@gnu.org>
5055 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5057 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5059 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5061 2012-03-27 Glenn Morris <rgm@gnu.org>
5063 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5066 2012-03-26 Kenichi Handa <handa@m17n.org>
5068 * dispextern.h (struct glyph): Fix previous change. Change the
5069 bit length of glyphless.ch to 25 (Bug#11082).
5071 2012-03-26 Chong Yidong <cyd@gnu.org>
5073 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5074 (command_loop_1): Use it; inhibit selection update for
5075 handle-select-window too (Bug#8996).
5077 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5079 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
5081 2012-03-25 Kenichi Handa <handa@m17n.org>
5083 * dispextern.h (struct glyph): Change the bit length of
5084 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5086 2012-03-24 Eli Zaretskii <eliz@gnu.org>
5088 * s/ms-w32.h (tzname): Include time.h before redirecting to
5089 _tzname. Fixes the MSVC build. (Bug#9960)
5091 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5093 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5096 * xterm.c (XTread_socket): Only modify handling_signal if
5097 !SYNC_INPUT. (Bug#11080)
5099 2012-03-23 Eli Zaretskii <eliz@gnu.org>
5101 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5102 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5103 when fetching a multibyte character consumes more bytes than
5104 CHAR_BYTES returns, due to unification of CJK characters in
5105 string_char. (Bug#11073)
5107 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5109 * process.c (wait_reading_process_output): Handle pty disconnect
5110 by refraining from sending oneself a SIGCHLD (bug#10933).
5112 2012-03-22 Chong Yidong <cyd@gnu.org>
5114 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5116 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
5117 Mark string as coming from a prefix property.
5118 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5119 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5121 2012-03-21 Chong Yidong <cyd@gnu.org>
5123 * xfaces.c (Vface_remapping_alist): Doc fix.
5125 2012-03-20 Eli Zaretskii <eliz@gnu.org>
5127 * w32proc.c (Fw32_set_console_codepage)
5128 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5131 2012-03-20 Chong Yidong <cyd@gnu.org>
5133 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5134 to reflect default non-nil value of redisplay-dont-pause.
5136 2012-03-19 Kenichi Handa <handa@m17n.org>
5138 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5139 it fit in a valid range (Bug#11003).
5141 2012-03-18 Eli Zaretskii <eliz@gnu.org>
5143 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5144 that is not from display property, accept the row as a "cursor
5145 row" if one of the string's character has a non-nil `cursor'
5146 property. Fixes cursor positioning when there are newlines in
5147 overlay strings, e.g. in icomplete.el. (Bug#11035)
5149 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5151 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5153 2012-03-12 Chong Yidong <cyd@gnu.org>
5155 * eval.c (inhibit_lisp_code): Rename from
5156 inhibit_window_configuration_change_hook; move from window.c.
5158 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5159 * window.c (run_window_configuration_change_hook)
5160 (syms_of_window): Callers changed.
5162 2012-03-11 Chong Yidong <cyd@gnu.org>
5164 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5166 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5168 2012-03-10 Chong Yidong <cyd@gnu.org>
5170 * frame.c (other_visible_frames): Don't assume the selected frame
5171 is visible (Bug#10955).
5173 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5175 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5177 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5179 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5180 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5183 2012-03-03 Glenn Morris <rgm@gnu.org>
5185 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5187 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5189 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5190 position past the first glyph_row that ends at ZV. (Bug#10902)
5191 (redisplay_window, next_element_from_string): Fix typos in
5193 (redisplay_window): Pass to move_it_vertically the margin in
5194 pixels, not in screen lines.
5196 2012-03-02 Glenn Morris <rgm@gnu.org>
5198 * buffer.c (buffer-list-update-hook): Doc fix.
5200 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5202 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5203 push_it before setting up the iterator for the first overlay
5204 string, even if we have an empty string loaded.
5205 (next_overlay_string): If there's an empty string on the iterator
5206 stack, pop the stack. (Bug#10903)
5208 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5210 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5211 Suggested by Stefan Monnier in
5212 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5213 * alloc.c (widen_to_Lisp_Object): New static function.
5214 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5215 and widening them to Lisp_Objects. This would work even if
5216 USE_LSB_TAG is defined and wide integers are used, which might
5217 happen in a future version of Emacs.
5219 2012-02-25 Chong Yidong <cyd@gnu.org>
5221 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5224 * xselect.c (Fx_selection_exists_p): Doc fix.
5225 (x_clipboard_manager_save_all): Print an informative message
5226 before saving to clipboard manager.
5228 2012-02-24 Chong Yidong <cyd@gnu.org>
5230 * keyboard.c (process_special_events): Handle all X selection
5231 requests in kbd_buffer, not just the next one (Bug#8869).
5233 2012-02-23 Chong Yidong <cyd@gnu.org>
5235 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5236 call when setting menu-bar-lines and tool-bar-lines parameters.
5237 (unwind_create_frame_1): New helper function.
5239 * window.c (inhibit_window_configuration_change_hook): New var.
5240 (run_window_configuration_change_hook): Obey it.
5241 (syms_of_window): Initialize it.
5243 2012-02-22 Chong Yidong <cyd@gnu.org>
5245 * xterm.c (x_draw_image_relief): Add missing type check for
5246 Vtool_bar_button_margin (Bug#10743).
5248 2012-02-21 Chong Yidong <cyd@gnu.org>
5250 * fileio.c (Vfile_name_handler_alist): Doc fix.
5252 * buffer.c (Fget_file_buffer): Protect against invalid file
5253 handler return value.
5255 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5257 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5258 when computing $valmask.
5260 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5261 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5262 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5263 It's useless in that case, and it can cause problems on hosts
5264 that allocate halves of EMACS_INT values separately.
5265 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5266 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5267 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5268 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5269 it avoids undefined behavior on hosts where shifting right by more
5270 than the word width has undefined behavior.
5272 2012-02-19 Chong Yidong <cyd@gnu.org>
5274 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5275 (Funhandled_file_name_directory, Ffile_name_as_directory)
5276 (Fdirectory_file_name, Fexpand_file_name)
5277 (Fsubstitute_in_file_name): Protect against invalid file handler
5278 return values (Bug#10845).
5280 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5282 * .gdbinit (pitx): Fix incorrect references to fields of the
5285 2012-02-17 Chong Yidong <cyd@gnu.org>
5287 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5289 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5291 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5292 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5294 2012-02-15 Chong Yidong <cyd@gnu.org>
5296 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5297 marked as special. Also, starting docstrings with * is obsolete.
5299 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5301 * gnutls.c (emacs_gnutls_write): Fix last change.
5303 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5305 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5308 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5310 * keymap.c (Fsingle_key_description): Handle char ranges.
5312 2012-02-12 Chong Yidong <cyd@gnu.org>
5314 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5315 as that creates a dangerous corner case.
5317 * window.c (Fdelete_window_internal): Invalidate the mouse
5318 highlight (Bug#9904).
5320 2012-02-12 Glenn Morris <rgm@gnu.org>
5322 * xselect.c (Fx_own_selection_internal)
5323 (Fx_get_selection_internal, Fx_disown_selection_internal)
5324 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5325 * nsselect.m (Fx_own_selection_internal)
5326 (Fx_disown_selection_internal, Fx_selection_exists_p)
5327 (Fx_selection_owner_p, Fx_get_selection_internal):
5328 Sync docs and argument specs with the xselect.c versions.
5330 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5332 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5334 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5336 * w32select.c (Fx_selection_exists_p): Sync doc string and
5337 argument list with xselect.c. (Bug#10783)
5339 * w16select.c (Fx_selection_exists_p): Sync doc string and
5340 argument list with xselect.c. (Bug#10783)
5342 2012-02-10 Glenn Morris <rgm@gnu.org>
5344 * fns.c (Fsecure_hash): Doc fix.
5346 2012-02-09 Kenichi Handa <handa@m17n.org>
5348 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5350 2012-02-07 Chong Yidong <cyd@gnu.org>
5352 * buffer.c (Fbuffer_local_variables)
5353 (buffer_lisp_local_variables): Handle unbound vars correctly;
5354 don't let Qunbound leak into Lisp.
5356 2012-02-07 Glenn Morris <rgm@gnu.org>
5358 * image.c (Fimagemagick_types): Doc fix.
5360 * image.c (imagemagick-render-type): Change it from a lisp object
5361 to an integer. Move the doc here from the lisp manual.
5362 Treat all values not equal to 0 the same.
5364 2012-02-06 Chong Yidong <cyd@gnu.org>
5366 * doc.c (store_function_docstring): Avoid applying docstring of
5367 alias to base function (Bug#2603).
5369 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5371 * .gdbinit (pp1, pv1): Remove redundant defines.
5374 2012-02-04 Chong Yidong <cyd@gnu.org>
5376 * nsterm.m: Declare a global (Bug#10694).
5378 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5380 * w32.c (get_emacs_configuration_options):
5381 Include --enable-checking, if specified, in the return value.
5383 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5385 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5386 after rounding frame sizes. (Bug#9723)
5388 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5390 * keyboard.c (adjust_point_for_property): Don't position point
5391 before BEGV. (Bug#10696)
5393 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5395 Handle overflow when computing char display width (Bug#9496).
5396 * character.c (char_width): Return EMACS_INT, not int.
5397 (char_width, c_string_width): Check for overflow when
5398 computing the width; this is possible now that individual
5399 characters can have unbounded width. Problem introduced
5400 by merge from Emacs 23 on 2012-01-19.
5402 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5404 * dbusbind.c (Fdbus_register_method): Mention the return value
5405 :ignore in the docstring.
5407 2012-02-02 Glenn Morris <rgm@gnu.org>
5409 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5411 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5412 Unconditionally set to t. (Bug#10673)
5413 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5414 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5415 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5417 2012-02-02 Kenichi Handa <handa@m17n.org>
5419 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5420 0, do not call append_composite_glyph.
5422 2012-02-02 Kenichi Handa <handa@m17n.org>
5424 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5426 (x_produce_glyphs): If the component of a composition is a null
5427 string, set it->pixel_width to 1 to avoid zero-width glyph.
5429 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5431 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5432 first 2 arguments are identical. This makes inserting large
5433 output from a subprocess an order of magnitude faster on
5434 MS-Windows, where all sbrk'ed memory is always contiguous.
5436 2012-01-31 Glenn Morris <rgm@gnu.org>
5438 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5439 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5440 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5442 2012-01-29 Glenn Morris <rgm@gnu.org>
5444 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5446 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5448 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5450 2012-01-28 Chong Yidong <cyd@gnu.org>
5452 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5454 2012-01-26 Chong Yidong <cyd@gnu.org>
5456 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5458 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5459 repeat counts (Bug#10507).
5461 2012-01-26 Glenn Morris <rgm@gnu.org>
5463 * lread.c (syms_of_lread): Doc fix.
5465 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5467 * coding.c (encode_designation_at_bol): Change return value to
5470 2012-01-25 Chong Yidong <cyd@gnu.org>
5472 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5474 2012-01-21 Chong Yidong <cyd@gnu.org>
5476 * floatfns.c (Fcopysign): Make the second argument non-optional,
5477 since nil is not allowed anyway.
5479 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5481 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5482 (send_process): Likewise.
5484 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5486 * window.c (save_window_save, Fcurrent_window_configuration)
5487 (Vwindow_persistent_parameters): Do not use Qstate.
5488 Rewrite doc-strings.
5490 2012-01-19 Kenichi Handa <handa@m17n.org>
5492 * character.c (char_width): New function.
5493 (Fchar_width, c_string_width, lisp_string_width):
5494 Use char_width (Bug#9496).
5496 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5498 * window.c (Vwindow_persistent_parameters): New variable.
5499 (Fset_window_configuration, save_window_save): Handle persistent
5502 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5504 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5505 thrashing the stack of the thread. (Bug#9087)
5507 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5509 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5511 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5513 * xdisp.c (rows_from_pos_range): Handle the case where the
5514 highlight ends on a newline. (Bug#10464)
5515 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5516 he end column for display of highlight that ends on a newline
5519 2012-01-11 Glenn Morris <rgm@gnu.org>
5521 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5522 from load-path also when installation-directory is nil. (Bug#10208)
5524 2012-01-10 Glenn Morris <rgm@gnu.org>
5526 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5528 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5529 Update template values to be closer to their typical values these days.
5531 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5533 * xdisp.c (rows_from_pos_range): Accept additional argument
5534 DISP_STRING, and accept any glyph in a row whose object is that
5535 string as eligible for mouse highlight. Fixes mouse highlight of
5536 display strings from overlays. (Bug#10464)
5538 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5540 emacs: fix an auto-save permissions race condition (Bug#10400)
5541 * fileio.c (auto_saving_dir_umask): New static var.
5542 (Fmake_directory_internal): Use it.
5543 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5544 creating the directory. The old code temporarily assigns
5545 too-generous permissions to the directory.
5546 (do_auto_save_eh): Clear it.
5547 (Fdo_auto_save): Catch all errors, not just file errors, so
5548 that the var is always cleared.
5550 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5552 * search.c (scan_buffer): Pass character positions to
5553 know_region_cache, not byte positions. (Bug#6540)
5555 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5557 * w32.c (sys_rename): Report EXDEV when rename of a directory
5558 fails because the target is on another logical disk. (Bug#10284)
5560 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5562 * xterm.c (x_embed_request_focus): New function.
5564 * xterm.h: Add prototype.
5566 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5568 2012-01-05 Glenn Morris <rgm@gnu.org>
5570 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5572 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5574 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5575 Load gnutls_transport_set_lowat only if GnuTLS version is below
5577 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5578 GnuTLS versions below 2.11.1.
5580 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5582 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5583 to the doc string advising against its use for altering the way
5584 windows are scrolled.
5586 2011-12-28 Kenichi Handa <handa@m17n.org>
5588 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5589 coding-system ASCII compatible only when it does not produce BOM
5590 on encoding (Bug#10383).
5592 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5594 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5596 (create_and_show_popup_menu): Always use menu_position_func for
5599 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5601 * callint.c (Fcall_interactively): Don't truncate prompt string.
5603 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5605 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5606 property that ends at ZV, so that the bidi iteration could be
5607 resumed from there (after widening). (Bug#10360)
5609 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5611 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5613 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5615 * nsterm.m (x_free_frame_resources):
5616 Release f->output_data.ns->miniimage.
5617 (ns_index_color): Fix indentation. Do not retain
5618 color_table->colors[i].
5620 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5623 * nsfns.m (x_set_background_color): Assign return value from
5624 ns_index_color to face-background instead of NSColor*.
5625 (ns_implicitly_set_icon_type): Fix indentation.
5626 Change assignment in for loop to comparison.
5628 * emacs.c (ns_pool): New variable.
5629 (main): Assign ns_pool.
5630 (Fkill_emacs): Call ns_release_autorelease_pool.
5632 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5633 autorelease fdesc, release fdAttrs and tdict.
5634 (ns_get_covering_families): Release charset.
5635 (ns_findfonts): Release NSFontDescriptor created with new.
5636 (ns_uni_to_glyphs): Fix indentation.
5637 (setString): Release attrStr before assigning new value.
5639 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5641 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5643 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5644 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5646 2011-12-18 David Reitter <reitter@cmu.edu>
5648 * nsterm.m (ns_term_init): Subscribe for notifications
5649 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5650 to method trackingNotification in EmacsMenu.
5652 * nsmenu.m (trackingMenu): New variable.
5653 (trackingNotification): New method (from Aquamacs).
5654 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5655 from Aquamacs (Bug#7030).
5657 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5659 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5660 (symbol_to_nsstring): Fix indentation.
5661 (ns_symbol_to_pb): New function.
5662 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5663 (Fns_rotate_cut_buffers_internal): Remove.
5664 (Fns_store_selection_internal): Rename from
5665 Fns_store_cut_buffer_internal.
5666 (ns_get_foreign_selection, Fx_own_selection_internal)
5667 (Fx_disown_selection_internal, Fx_selection_exists_p)
5668 (Fns_get_selection_internal, Fns_store_selection_internal):
5669 Use ns_symbol_to_pb and check if return value is nil.
5670 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5671 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5672 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5673 renamed to Sns_store_selection_internal.
5674 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5675 and remove this function.
5676 (ns_handle_selection_clear): Remove, never used.
5677 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5680 2011-12-17 Ken Brown <kbrown@cornell.edu>
5682 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5683 GID is unknown (Bug#10257).
5685 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5687 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5688 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5689 which caused a build failure on GNU/Linux IA-64. This problem was
5690 introduced by my 2011-10-07 patch.
5692 2011-12-15 Juri Linkov <juri@jurta.org>
5694 * image.c (imagemagick_error): New function. (Bug#10112)
5695 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5696 Use `imagemagick_error' where ImageMagick functions return
5698 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5701 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5703 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5704 fill background (Bug#8992).
5706 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5708 * window.c (Vwindow_combination_resize)
5709 (Vwindow_combination_limit): Use t instead of non-nil in
5711 (Vrecenter_redisplay): Add first sentence of doc-string on
5713 (Frecenter): Fix doc-string typo.
5715 2011-12-11 Kenichi Handa <handa@m17n.org>
5717 * coding.c (Funencodable_char_position): Pay attention to the
5718 buffer text relocation (Bug#9389).
5720 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5722 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5723 gtk_init (Bug#10100).
5725 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5727 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5728 IT->string is nil. (Bug#10263)
5730 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5732 * nsterm.h (x_free_frame_resources): Declare.
5734 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5735 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5737 * nsterm.h (ns_get_defaults_value): Declare.
5739 * nsterm.m (ns_default): Call ns_get_defaults_value.
5741 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5743 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5746 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5748 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5749 that where the value of an _OBJC_* symbol points to is in the .bss
5750 section (Bug#10240).
5752 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5754 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5755 after the loop to call ccl_driver at least once (Bug#8619).
5757 2011-12-08 Kenichi Handa <handa@m17n.org>
5759 * ftfont.c (get_adstyle_property): Fix previous change
5762 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5764 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5765 dirs from the default value of EMACSLOADPATH (bug#10208).
5767 2011-12-07 Glenn Morris <rgm@gnu.org>
5769 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5770 installation and source directories as well. (Bug#10208)
5772 2011-12-06 Chong Yidong <cyd@gnu.org>
5774 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5776 2011-12-06 Glenn Morris <rgm@gnu.org>
5778 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5779 as an error, not just -1. (Bug#10217)
5781 2011-12-05 Chong Yidong <cyd@gnu.org>
5783 * keyboard.c (process_special_events): New function.
5784 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5786 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5788 * coding.c (encode_designation_at_bol): Don't use uninitialized
5789 local variable (Bug#9318).
5791 2011-12-05 Kenichi Handa <handa@m17n.org>
5793 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5794 return Qnil (Bug#8046, Bug#10193).
5796 2011-12-05 Kenichi Handa <handa@m17n.org>
5798 * coding.c (encode_designation_at_bol): New args charbuf_end and
5799 dst. Return the number of produced bytes. Callers changed.
5800 (coding_set_source): Return how many bytes coding->source was
5802 (coding_set_destination): Return how many bytes
5803 coding->destination was relocated.
5804 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5805 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5807 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5809 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5810 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5813 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5815 The following changes are to fix Bug#9318.
5817 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5818 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5819 (encode_coding_iso_2022, encode_coding_sjis)
5820 (encode_coding_big5, encode_coding_charset): Use the above macros.
5822 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5824 * lisp.h (process_quit_flag): Fix external declaration.
5826 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5828 Don't macro-inline non-performance-critical code.
5829 * eval.c (process_quit_flag): New function.
5830 * lisp.h (QUIT): Use it.
5832 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5834 * nsfns.m (get_geometry_from_preferences): New function.
5835 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5837 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5839 * emacs.c (Qkill_emacs): Define.
5840 (syms_of_emacs): Initialize it.
5841 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5842 Qquit_flag to `kill-emacs' instead.
5843 (quit_throw_to_read_char): Add parameter `from_signal'.
5844 All callers changed. Call Fkill_emacs if requested and safe.
5845 * lisp.h (QUIT): Call Fkill_emacs if requested.
5847 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5849 * widget.c (update_wm_hints): Return if wmshell is null.
5850 (widget_update_wm_size_hints): New function.
5852 * widget.h (widget_update_wm_size_hints): Declare.
5854 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5855 widget_update_wm_size_hints (Bug#10104).
5857 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5859 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5860 before a newline, prepare the bidi iterator for consuming the
5861 newline, and keep the current paragraph direction. (Bug#10183)
5862 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5864 2011-12-02 Juri Linkov <juri@jurta.org>
5866 * search.c (Fword_search_regexp): New Lisp function created from
5867 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5868 (Fword_search_backward, Fword_search_forward)
5869 (Fword_search_backward_lax, Fword_search_forward_lax):
5870 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5871 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5873 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5875 * fileio.c (Finsert_file_contents): Move after-change-function call
5876 to before the "handled:" label, since all "goto handled" appear in
5877 cases where the *-change-functions have already been properly called
5880 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5882 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5883 waiting for input. (Bug#10169)
5885 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5887 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5888 verifies glyph row's hash code--we have just reallocated the
5889 glyphs, so their contents can be complete garbage. (Bug#10164)
5891 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5893 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5895 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5897 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5898 attributes are tested _before_ calling verify_row_hash, to protect
5899 against GCC re-ordering of the tests. (Bug#10164)
5901 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5903 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5905 * xterm.c (handle_one_xevent): Only set async_visible and friends
5906 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5907 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5908 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5910 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5912 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5913 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5914 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5915 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5916 All uses changed to use GCPRO1 etc.
5917 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5918 Revert to old implementation (i.e., before 2011-03-11).
5920 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5922 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5923 of scroll runs so as to avoid assigning disabled bogus rows and
5924 unnecessary graphics copy operations.
5926 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5928 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5929 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5930 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5931 (malloc, free, realloc, calloc): Redirect to e_* only when
5934 * lisp.h (GCTYPEBITS): Move before first use.
5935 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5936 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5937 this macro definition.
5939 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5942 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5944 * gtkutil.c (xg_create_frame_widgets):
5945 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5946 present with Gtk+ 2.0.
5948 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5950 * fileio.c (Finsert_file_contents): Undo previous change; see
5951 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5953 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5955 Rename locals to avoid shadowing.
5956 * fileio.c (Finsert_file_contents):
5957 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5958 * process.c (wait_reading_process_output):
5959 Rename inner 'proc' to 'p' to avoid shadowing.
5960 Indent for consistency with usual Emacs style.
5962 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5964 * xdisp.c (redisplay_window): If cursor row is not fully visible
5965 after recentering, and scroll-conservatively is set to a large
5966 number, scroll window by a few more lines to make the cursor fully
5967 visible and out of scroll-margin. (Bug#10105)
5968 (start_display): Don't move to the next line if the display should
5969 start at a newline that is part of a display vector or an overlay
5972 2011-11-24 Juri Linkov <juri@jurta.org>
5974 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5975 after the `MagickPingImage' call. (Bug#10112)
5977 2011-11-23 Chong Yidong <cyd@gnu.org>
5979 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5981 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5983 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5984 making another buffer current. (Bug#10114)
5986 2011-11-23 Glenn Morris <rgm@gnu.org>
5988 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5990 2011-11-23 Chong Yidong <cyd@gnu.org>
5992 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5993 using it (Bug#5984).
5995 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5997 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5998 and header-lines, as they don't have one computed for them.
6001 * .gdbinit (prow): Make displayed values more self-explaining.
6002 Add row's hash code.
6004 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6006 * process.c (wait_reading_process_output): Fix asynchrounous
6007 GnuTLS socket handling on some versions of the GnuTLS library.
6008 (wait_reading_process_output): Add comment and URL.
6010 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6012 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6014 2011-11-21 Chong Yidong <cyd@gnu.org>
6016 * window.c (Fnext_window, Fprevious_window): Doc fix.
6018 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6020 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6022 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6024 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6026 2011-11-20 Martin Rudalics <rudalics@gmx.at>
6028 * window.c (Fset_window_combination_limit): Rename argument
6030 (Vwindow_combination_limit): Remove "status" from doc-string.
6032 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6034 * m/ibms390.h: Remove.
6035 * m/ibms390x.h: Don't include "ibms390.h".
6037 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6039 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6040 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6042 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6044 * casetab.c (Fset_case_table):
6045 * charset.c (Fcharset_after): Fix typos.
6047 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6049 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6050 Otherwise, valgrind does not work on some platforms.
6051 Problem reported by Andreas Schwab in
6052 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6053 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6054 is set, removing the need for VIRT_ADDRESS_VARIES.
6055 (PURE_P): Use a more-efficient implementation that needs just one
6056 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6057 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6058 to 4 (xorl, subq, cmpq, setbe).
6059 * alloc.c (pure): Always extern now, since that's the
6060 VIRT_ADDR_VARIES behavior.
6061 (PURE_POINTER_P): Use a single comparison, not two, for
6062 consistency with the new puresize.h.
6063 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6064 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6065 Remove VIRT_ADDR_VARIES no longer needed.
6067 2011-11-19 Eli Zaretskii <eliz@gnu.org>
6069 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6070 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6071 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6072 behave as if the cursor position were at the window margin.
6074 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6075 and the cursor position is out of bounds, behave as if the cursor
6076 position were at the window margin. (Bug#10075)
6078 2011-11-18 Chong Yidong <cyd@gnu.org>
6080 * window.c (Fwindow_combination_limit): Make first argument
6081 non-optional, since it is meaningless for live windows like the
6084 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6086 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6088 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6090 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6091 (graft_intervals_into_buffer): Simplify.
6093 2011-11-18 Eli Zaretskii <eliz@gnu.org>
6095 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6096 hash values of the two rows.
6097 (copy_row_except_pointers): Preserve the used[] arrays and the
6098 hash values of the two rows. (Bug#10035)
6099 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
6101 * xdisp.c (row_hash): New function, body extracted from
6102 compute_line_metrics.
6103 (compute_line_metrics): Call row_hash, instead of computing the
6106 * dispnew.c (verify_row_hash): Call row_hash for computing the
6107 hash code of a row, instead of duplicating code from xdisp.c.
6109 * dispextern.h (row_hash): Add prototype.
6111 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6113 * frame.c (delete_frame): Don't delete the terminal when the last
6114 X frame is closed if emacs is built with GTK toolkit.
6116 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
6118 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6120 2011-11-17 Martin Rudalics <rudalics@gmx.at>
6122 * window.c (Vwindow_splits): Rename to
6123 Vwindow_combination_resize. Suggested by Juri Linkov.
6124 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6127 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
6129 * nsfns.m (Fns_font_name):
6130 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
6132 2011-11-16 Martin Rudalics <rudalics@gmx.at>
6134 * window.h (window): Rename slot "nest" to "combination_limit".
6135 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6136 (Fset_window_nest): Rename to Fset_window_combination_limit.
6137 (Vwindow_nest): Rename to Vwindow_combination_limit.
6138 (recombine_windows, make_parent_window, make_window)
6139 (Fsplit_window_internal, saved_window)
6140 (Fset_window_configuration, save_window_save): Rename all
6141 occurrences of window_nest to window_combination_limit.
6143 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
6145 * image.c (imagemagick_load_image): Fix typo.
6147 2011-11-14 Eli Zaretskii <eliz@gnu.org>
6149 * xdisp.c (display_line): Move the call to
6150 highlight_trailing_whitespace before the call to
6151 compute_line_metrics, since the latter needs to see the final
6152 faces of all the glyphs to compute ROW's hash value.
6153 Fixes assertion violations in row_equal_p. (Bug#10035)
6155 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6157 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6158 just return (bug#10044).
6160 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6162 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6163 with user-defined heap size. Bump the default size of the temacs
6164 heap to 27MB, to avoid memory warning when running temacs.
6165 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6167 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6168 current_matrix and desired_matrix. (Bug#9990)
6169 (verify_row_hash) [XASSERTS]: New function.
6170 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6171 that the hash value of glyph rows is correct.
6173 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6175 * window.h (window): Remove splits slot.
6176 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6177 (Fdelete_other_windows_internal, make_parent_window)
6178 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6179 (Fset_window_configuration, save_window_save): Don't deal with
6180 split status of windows.
6181 (saved_window): Remove splits slot.
6182 (Vwindow_splits): Rewrite doc-string.
6184 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6186 * xfns.c (unwind_create_frame):
6187 * nsfns.m (unwind_create_frame):
6188 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6189 Vframe_list (Bug#9999).
6191 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6193 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6195 2011-11-11 Kenichi Handa <handa@m17n.org>
6197 * callproc.c (Fcall_process): Set the member dst_multibyte of
6200 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6202 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6203 avoid a crash (bug#9496).
6205 2011-11-09 Chong Yidong <cyd@gnu.org>
6207 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6208 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6210 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6212 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6214 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6216 Avoid some portability problems by eschewing 'extern inline' functions.
6217 The trivial performance wins aren't worth the portability hassles; see
6218 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6220 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6221 (window_box_width, window_box_left, window_box_left_offset)
6222 (window_box_right, window_box_right_offset): Undo previous change,
6223 by removing the "extern"s.
6224 * intervals.c (adjust_intervals_for_insertion)
6225 (adjust_intervals_for_deletion): Undo previous change,
6226 making these static again.
6227 (offset_intervals, temp_set_point_both, temp_set_point)
6228 (copy_intervals_to_string): No longer inline.
6229 * xdisp.c (window_text_bottom_y, window_box_width)
6230 (window_box_height, window_box_left_offset)
6231 (window_box_right_offset, window_box_left, window_box_right)
6232 (window_box): No longer inline.
6234 2011-11-08 Chong Yidong <cyd@gnu.org>
6236 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6237 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6238 Signal an error if not a live window.
6239 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6240 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6242 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6244 * lisp.h (syms_of_abbrev): Remove declaration.
6245 Reported by CHENG Gao <chenggao@royau.me>.
6247 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6249 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6250 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6251 of temacs in GUI mode.
6253 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6255 * window.h: Declare delete_all_child_windows instead of
6256 delete_all_subwindows.
6257 * window.c (Fwindow_nest, Fset_window_nest)
6258 (Fset_window_new_total, Fset_window_new_normal)
6259 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6260 (delete_all_subwindows): Rename to delete_all_child_windows.
6261 (Fdelete_other_windows_internal, Fset_window_configuration):
6262 Call delete_all_child_windows instead of delete_all_subwindows.
6263 * frame.c (delete_frame): Call delete_all_child_windows instead
6264 of delete_all_subwindows.
6266 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6268 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6269 This is also needed for porting to any host where GC_MARK_STACK is
6270 not GC_MAKE_GCPROS_NOOPS.
6271 (which_symbols): Use it.
6273 2011-11-07 Kenichi Handa <handa@m17n.org>
6275 * coding.c (coding_set_destination): Check coding->src_pos only
6276 when coding->src_object is a buffer (bug#9910).
6278 * process.c (send_process): Set the member src_multibyte of coding
6279 to 0 (bug#9911) when sending a unibyte text.
6281 * callproc.c (Fcall_process): Set the member src_multibyte of
6282 process_coding to 0 (bug#9912).
6284 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6286 * xmenu.c (cleanup_widget_value_tree): New function.
6287 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6288 calling free_menubar_widget_value_tree directly (Bug#9830).
6290 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6292 Fix some portability problems with 'inline'.
6293 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6294 (window_box_width, window_box_left, window_box_left_offset)
6295 (window_box_right, window_box_right_offset): Declare extern.
6296 Otherwise, these inline functions do not conform to C99 and
6297 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6298 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6299 * intervals.c (adjust_intervals_for_insertion)
6300 (adjust_intervals_for_deletion): Now extern, because otherwise the
6301 extern inline functions 'offset_intervals' couldn't refer to it.
6302 (static_offset_intervals): Remove.
6303 (offset_intervals): Rewrite using the old contents of
6304 static_offset_intervals. The old version didn't conform to C99
6305 because an extern inline function contained a reference to an
6306 identifier with static linkage.
6308 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6310 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6313 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6315 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6316 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6317 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6318 return Qleft_to_right.
6320 2011-11-06 Chong Yidong <cyd@gnu.org>
6322 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6323 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6324 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6325 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6326 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6327 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6328 (Fwindow_vscroll): Doc fix.
6329 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6330 argument, since it makes no sense to pass a live window and for
6331 consistency with window-child.
6333 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6335 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6338 2011-11-05 Jason Rumney <jasonr@gnu.org>
6340 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6341 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6343 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6344 bitwise arithmetic preventing use of unicode-sip and non-truetype
6347 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6349 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6352 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6353 initialization code to keep similarity to xfns.c after changes
6356 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6358 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6359 (unwind_create_frame): New function (Bug#9943).
6360 (Fx_create_frame): Restructure code to be more similar to the one in
6361 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6362 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6363 Move terminal->reference_count++ just before making the frame official
6366 * nsterm.m (x_free_frame_resources): New function.
6367 (x_destroy_window): Move code to x_free_frame_resources.
6369 * xfns.c (unwind_create_frame): Fix comment.
6370 (Fx_create_frame, x_create_tip_frame):
6371 Move terminal->reference_count++ just before making the frame
6372 official. Move initialization of image_cache_refcount and
6373 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6375 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6377 Support MSVC build with newer versions of Visual Studio.
6378 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6379 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6382 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6383 which are not supported by MSVC.
6384 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6385 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6387 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6389 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6391 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6393 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6395 Support MSVC build with newer versions of Visual Studio.
6396 * w32.c: Don't include w32api.h for MSVC.
6397 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6399 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6400 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6401 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6402 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6404 (alloca) [_MSC_VER]: Define to _alloca.
6406 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6408 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6410 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6412 * xdisp.c (note_mouse_highlight): If either of
6413 previous/next-single-property-change returns nil, treat that as
6414 the beginning or the end of the buffer. (Bug#9955)
6416 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6418 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6419 label is not null (Bug#9951).
6420 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6423 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6425 * window.c (Fwindow_body_size): Mention in the doc string that the
6426 return value is in frame's canonical units. (Bug#9949)
6428 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6430 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6432 * w32fns.c (unwind_create_frame): If needed, free the glyph
6433 matrices of the partially constructed frame. (Bug#9943)
6434 * xfns.c (unwind_create_frame): Likewise.
6436 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6438 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6439 Don't stop backward scan on the continuation glyph, even though
6440 its CHARPOS is positive.
6441 (mouse_face_from_buffer_pos, note_mouse_highlight):
6442 Rename cover_string to disp_string.
6444 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6446 * window.c (temp_output_buffer_show): Don't use
6447 Vtemp_buffer_show_specifiers.
6448 (Vtemp_buffer_show_specifiers): Remove unused variable.
6450 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6452 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6453 past the beginning of the current glyph matrix.
6455 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6457 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6458 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6459 HAVE_GTK3 (Bug#9869).
6461 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6462 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6464 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6466 * xterm.c: Declare x_handle_net_wm_state to return int.
6467 (handle_one_xevent): Check if we are iconified but don't have
6468 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6469 (get_current_wm_state): Return non-zero if not hidden,
6470 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6471 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6472 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6473 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6475 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6477 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6478 so that this new function doesn't get optimized away by a
6479 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6481 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6483 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6485 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6487 Fix the `xbytecode' command.
6488 * .gdbinit (xprintbytestr): New command.
6489 (xwhichsymbols): Rename from `which'; all callers changed.
6490 (xbytecode): Print the byte-code string as well.
6492 2011-10-29 Kim Storm <storm@cua.dk>
6494 * alloc.c (which_symbols): New function.
6496 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6498 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6501 2011-10-29 Glenn Morris <rgm@gnu.org>
6503 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6504 Not clear what it was for, and it causes various bugs. (Bug#9839)
6506 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6508 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6509 possible random value that matches one of those tested as
6510 condition to clear the mouse face.
6512 2011-10-28 Chong Yidong <cyd@gnu.org>
6514 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6516 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6518 * window.c (make_window): Initialize phys_cursor_on_p.
6520 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6522 * lisp.h (struct Lisp_Symbol): Update comments.
6524 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6526 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6528 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6530 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6531 <oslsachem@gmail.com> for helping to debug this.
6533 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6534 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6535 (g_b_init_get_glyph_outline_w): New static variables.
6536 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6537 (GetGlyphOutlineW_Proc): New typedefs.
6538 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6539 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6541 (w32font_open_internal, compute_metrics):
6542 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6543 instead of calling the "wide" APIs directly.
6545 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6547 * w32.h (syms_of_w32font): Add prototype.
6549 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6551 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6552 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6553 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6554 (Fmove_to_window_line): Doc fix.
6556 2011-10-27 Chong Yidong <cyd@gnu.org>
6558 * process.c (make_process): Set gnutls_state to NULL.
6560 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6561 non-NULL, regardless of GNUTLS_INITSTAGE.
6562 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6563 an error. Set process slots as soon as we allocate them.
6565 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6567 2011-10-27 Chong Yidong <cyd@gnu.org>
6569 * gnutls.c (emacs_gnutls_deinit): New function.
6570 Deallocate credentials structures as well as calling gnutls_deinit.
6571 (Fgnutls_deinit, Fgnutls_boot): Use it.
6573 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6574 (deactivate_process): Call emacs_gnutls_deinit.
6576 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6578 * image.c (x_create_x_image_and_pixmap):
6579 * w32.c (sys_rename, w32_delayed_load):
6580 * w32font.c (fill_in_logfont):
6581 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6583 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6585 * w32fns.c (w32_default_color_map): New function,
6586 extracted from Fw32_default_color_map.
6587 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6589 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6591 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6593 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6595 * keyboard.c (test_undefined): New function (bug#9751).
6596 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6598 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6600 * sysdep.c (init_sys_modes): Fix the check for the controlling
6601 terminal (Bug#6649).
6603 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6605 * dispextern.h (struct bidi_it): New member next_en_type.
6607 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6608 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6609 current character, check also for next_en_type being WEAK_EN.
6610 (bidi_resolve_weak): Don't enter the expensive loop if the current
6611 position is before next_en_pos. Record the bidi type of the first
6612 non-ET, non-BN character we find, in addition to its position.
6613 (bidi_level_of_next_char): Invalidate next_en_type when
6614 next_en_pos is over-stepped.
6616 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6618 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6619 * editfns.c: Rewrite current-time-zone so that it invokes
6620 the equivalent of (format-time-string "%Z") to get the time zone name.
6621 This fixes a bug when the time zone name contains characters that
6622 need converting from the system time locale to Emacs internal format.
6623 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6624 that patch fixed format-time-string to do the conversion, but
6625 I forgot to fix current-time-zone.
6626 (format_time_string): New function, containing most of
6627 what Fformat_time_string used to contain.
6628 (Fformat_time_string): Rewrite in terms of format_time_string.
6629 This doesn't change this function's behavior.
6630 (current-time-zone): Rewrite to use format_time_string.
6631 This fixes the bug reported by Michael Schierl in
6632 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6633 Jason Rumney's 2007-06-07 change worked around this bug, but
6635 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6637 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6639 * xdisp.c (start_display): If the character at POS is displayed
6640 via a display vector, reset IT->current.dpvec_index to zero.
6641 (try_window_reusing_current_matrix): If a line ends in a display
6642 vector or the next line starts in a display vector, continue
6643 redrawing the window even though the character position of
6644 start_row was reached.
6647 2011-10-18 Chong Yidong <cyd@gnu.org>
6649 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6650 with nobreak-char-display too.
6652 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6654 Fix part 3 of bug#9771.
6655 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6656 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6657 non-neutral characters if the current character is a paragraph
6658 separator (a.k.a. Newline). This avoids running the same
6659 expensive loop twice, once when we consume the preceding newline
6660 and the other time when the line actually needs to be displayed.
6661 Avoid the loop when we see neutrals on the base embedding level
6662 following a character whose directionality is the same as the
6663 paragraph's. This avoids running the expensive loop when a line
6664 ends in a long sequence of neutrals, like control characters.
6665 Add assertion against STRONG_AL type. Slightly rearrange code
6666 that determines the type of a neutral given the first non-neutral
6668 (bidi_level_of_next_char): Set next_en_pos to zero when
6669 invalidating its info.
6671 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6673 * xdisp.c (push_display_prop): Determine whether to record string
6674 or buffer position by IT->string, not by IT->method. Allow
6675 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6676 (move_it_vertically_backward): Don't look for character position
6677 immediately after the newline when in a continuation line.
6680 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6682 * window.c (coordinates_in_window): Rewrite and delabelize
6683 vertical border check. (Bug#5357) (Bug#9618)
6685 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6687 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6688 errors in XSetWindowBorder (bug#9310).
6690 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6692 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6693 avoid crash when xmalloc overrun checking is enabled.
6695 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6697 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6698 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6699 cursor motion with <left> and <right> arrow keys.
6701 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6702 some callers set that themselves.
6704 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6706 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6707 display string and the previous row comes from the same string and
6708 is empty. (Bug#9739) (Bug#9738)
6710 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6712 * doc.c (get_doc_string): Encode file name (bug#9735).
6714 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6716 * bidi.c (bidi_level_of_next_char):
6717 * xdisp.c (get_visually_first_element): Remove old incorrect
6718 comments regarding the Unicode Line Separator character.
6720 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6722 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6724 * alloc.c (Fgc_status): Do not access beyond zombies array
6725 boundary if nzombies > MAX_ZOMBIES.
6726 * alloc.c (dump_zombies): Add missing format specifier.
6728 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6730 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6731 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6733 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6734 Some packages use them to denote characters with modifiers.
6736 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6738 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6739 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6740 matching a pp-number. Rename parameter var to var1.
6742 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6744 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6746 2011-10-08 Glenn Morris <rgm@gnu.org>
6748 * callint.c (Fcall_interactively): Give a more explicit error for the
6749 'c' case with a non-character input. (Bug#8479)
6751 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6753 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6755 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6756 lines that are hscrolled on the left.
6758 * dispnew.c (buffer_posn_from_coords): Account for a possible
6759 presence of header-line. (Bug#4426)
6761 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6763 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6764 Don't advertise functionality which we discourage or doesn't work.
6766 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6768 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6769 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6770 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6771 this makes Emacs dump core during garbage collection on rare
6772 occasions. sizeof is obviously inferior to offsetof here, so
6773 stick with offsetof.
6774 (GC_POINTER_ALIGNMENT): New macro.
6775 (mark_memory): Omit 3rd (offset) arg; caller changed.
6776 Don't assume EMACS_INT alignment is the same as pointer alignment.
6778 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6780 * keyboard.c (read_key_sequence_remapped): New var.
6781 (read_key_sequence): Compute remapping in the right buffer.
6782 (command_loop_1): Use read_key_sequence's remapping directly.
6784 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6786 * dired.c (file_name_completion): Don't expand file name.
6787 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6788 before checking file name handler.
6790 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6791 they've been requested explicitly (bug#9591).
6793 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6795 * keymap.c (Fsingle_key_description): Use make_specified_string
6796 instead of build_string to build string from push_key_description.
6799 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6801 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6802 This fixes a Y2038 bug on 64-bit hosts.
6803 * buffer.c (reset_buffer):
6804 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6805 (Fclear_buffer_auto_save_failure):
6806 Use 0, not -1, to represent an unset failure time, since time_t
6807 might not be signed.
6809 Remove dependency on glibc malloc internals.
6810 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6811 Move back here from lisp.h, but with their new implementations.
6812 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6813 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6814 * charset.c (charset_table_init): New static var.
6815 (syms_of_charset): Use it instead of xmalloc. This removes a
6816 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6817 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6818 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6819 Move back to alloc.c.
6820 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6821 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6823 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6825 * nsterm.m (windowDidResize): Call x_set_window_size only when
6826 ns_in_resize is true. Otherwise set pixelwidth/height and
6827 call change_frame_size (Bug#9628).
6829 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6831 Port --enable-checking=all to Fedora 14 x86-64.
6832 * charset.c (syms_of_charset): Also account for glibc malloc's
6833 internal overhead when calculating the initial malloc maximum.
6835 Port --enable-checking=all to Fedora 14 x86.
6836 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6838 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6839 (overrun_check_realloc, overrun_check_free):
6840 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6841 That way, xmalloc returns a properly-aligned pointer even if
6842 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6843 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6844 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6845 into account when calculating the initial malloc maximum.
6846 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6847 Move here from alloc.c, so that charset.c can use it too.
6848 Properly align; the old code wasn't right for common 32-bit hosts
6849 when configured with --enable-checking=all.
6850 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6851 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6853 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6855 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6858 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6860 * xdisp.c (compute_display_string_end): If there's no display
6861 string at CHARPOS, return -1.
6863 * bidi.c (bidi_fetch_char): When compute_display_string_end
6864 returns a negative value, treat the character as a normal
6865 character not covered by a display string. (Bug#9624)
6867 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6869 * lread.c (Fread_from_string): Fix typo in docstring.
6871 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6873 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6874 newline, reseat the iterator instead of bidi-iterating there one
6875 character at a time. (Bug#9610)
6876 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6877 TO_CHARPOS if the bidi iterator is at base embedding level.
6879 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6881 * lread.c (readevalloop): Use correct code for NBSP.
6882 (read1): Likewise. (Bug#9608)
6884 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6886 * dbusbind.c (Fdbus_register_signal): When service is not
6887 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6889 2011-09-25 Glenn Morris <rgm@gnu.org>
6891 * buffer.c (truncate-lines): Doc fix.
6893 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6895 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6896 (Fset_window_next_buffers): Doc fix.
6898 2011-09-24 Glenn Morris <rgm@gnu.org>
6900 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6902 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6904 Fix minor problems found by static checking.
6905 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6906 * indent.c (Fvertical_motion): Fix == vs = typo.
6908 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6910 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6911 Default value is now t. Doc fix.
6913 * indent.c (Fvertical_motion): Compute and apply the overshoot
6914 logic when moving up, not only when moving down. Fix the
6915 confusing name and values of the it_overshoot_expected variable;
6916 logic changes accordingly. (Bug#9254) (Bug#9549)
6918 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6919 CHARPOS is covered by a display string which includes newlines.
6920 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6921 is covered by a display string with embedded newlines.
6923 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6925 * dbusbind.c (Fdbus_register_signal): Add match rule to
6926 Vdbus_registered_objects_table. (Bug#9581)
6927 (Fdbus_register_method, Vdbus_registered_objects_table):
6930 2011-09-24 Jim Meyering <meyering@redhat.com>
6932 do not ignore write error for any output size
6933 The previous change was incomplete.
6934 While it makes emacs --batch detect the vast majority of stdout
6935 write failures, errors were still ignored whenever the output size is
6936 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6937 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6938 && echo FAIL: ignored write error
6939 FAIL: ignored write error
6940 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6941 && echo FAIL: ignored write error
6942 FAIL: ignored write error
6943 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6945 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6947 * emacs.c (Fkill_emacs): In noninteractive mode exit
6948 non-successfully if a write error occurred on stdout. (Bug#9574)
6950 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6952 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6955 * dispextern.h (struct it): Update the comment documenting what
6958 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6960 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6961 a display string, extend search for cursor position to end of row.
6962 (find_row_edges): If the row ends in a newline from a display
6963 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6964 Handle the case of a display string with multiple newlines.
6965 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6966 non-empty line. Fixes confusing cursor motion with arrow keys at
6967 the beginning of a line that starts with whitespace.
6969 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6971 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6974 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6976 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6979 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6981 * xdisp.c (display_line): Record maximum and minimum buffer
6982 positions even if no glyphs were produced (e.g., by a zero-width
6983 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6984 buffer positions that will be removed from the glyph row because
6986 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6987 column is beyond frame width: don't subtract 1 "pixel" when
6988 computing width of the stretch.
6989 (reseat_at_next_visible_line_start): Undo the change made on
6990 2011-09-17 that saved paragraph information and restored it after
6991 the call to `reseat'. (Bug#9545)
6993 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6995 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6996 and turn window cursor on if cleared (Bug#9415).
6998 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
7000 * search.c (boyer_moore): Take unibyte characters from pattern
7001 literally. (Bug#9458)
7003 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7005 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7007 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7009 Fix minor problem found by static checking.
7010 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7011 initialized, to pacify gcc -Wuninitialized.
7013 * fileio.c: Report proper errno when syscall falls.
7014 (Finsert_file_contents): Save and restore errno,
7015 so that report_file_error outputs the correct diagnostic.
7016 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7018 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7020 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7022 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7024 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7025 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7027 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7029 * xdisp.c (reseat_at_next_visible_line_start): Keep information
7030 about the current paragraph and restore it after the call to reseat.
7032 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7033 (bidi_find_paragraph_start): Search back for paragraph beginning
7034 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7035 (bidi_move_to_visually_next): Only trigger paragraph-related
7036 computations when the last character is a newline or at EOB, not
7037 just any NEUTRAL_B. (Bug#9470)
7039 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7040 truncated lines if point is covered by a display string. (Bug#9524)
7042 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7044 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7045 (cons_to_x_long): New function.
7046 (lisp_data_to_selection_data): Use it. Correct the test for
7047 short-versus-long data; it was negated. Break out of vector
7048 loop, for efficiency, when a long datum is discovered.
7050 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7052 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7054 2011-09-16 Eli Zaretskii <eliz@gnu.org>
7056 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7057 GCC PR/17406) by declaring this function with external scope.
7059 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7061 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7062 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7064 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7066 * editfns.c (Fformat): Correctly handle text properties on "%%".
7068 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7070 * xterm.c (x_draw_composite_glyph_string_foreground):
7071 * w32term.c (x_draw_composite_glyph_string_foreground):
7072 * term.c (encode_terminal_code):
7073 * composite.c (composition_update_it, get_composition_id):
7074 * xdisp.c (get_next_display_element)
7075 (fill_composite_glyph_string): Add comments about special meaning
7076 of TAB characters in a composition.
7078 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7080 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
7081 This occurs when processing a multibyte format.
7082 Problem reported by Wolfgang Jenker.
7084 2011-09-15 Johan Bockgård <bojohan@gnu.org>
7086 * xdisp.c (try_cursor_movement): Only check for exact match if
7087 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7089 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7091 Remove unused external symbols.
7092 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7093 * xdisp.c (calc_pixel_width_or_height): Now static.
7094 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7095 * indent.c (check_display_width):
7096 * w32term.c: Fix comment to match code.
7097 * xterm.c, xterm.h (x_catching_errors): Remove.
7099 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7101 * xselect.c: Use signed conversions more consistently (Bug#9498).
7102 (selection_data_to_lisp_data): Assume incoming selection data are
7103 signed integers, not unsigned. This is to be consistent with
7104 outgoing selection data, which was modified to use signed integers
7105 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7106 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7107 expects long, not unsigned long.
7109 2011-09-14 Eli Zaretskii <eliz@gnu.org>
7111 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7112 computation of loop end. Reported by Johan Bockgård
7115 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
7117 * frame.c (Fother_visible_frames_p): Function deleted.
7119 2011-09-12 Eli Zaretskii <eliz@gnu.org>
7121 * indent.c (compute_motion): Process display vector front to back
7122 rather than the other way around. (Bug#2496)
7124 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7126 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7128 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
7130 * minibuf.c (Fread_from_minibuffer): Doc fix.
7132 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7134 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7135 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7137 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7139 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7140 value for non-existent files.
7142 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7144 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7145 set its "size" to -1. This will set the modtime_size field of
7146 the corresponding buffer to -1, which is what
7147 verify-visited-file-modtime expects for files that do not exist.
7150 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7152 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7154 * lisp.h: ... from here. push_key_description is no longer
7155 defined in keyboard.c, so its declaration should not be in
7156 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7157 logically belongs with push_key_description.
7159 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7161 * buffer.h: Include <sys/types.h> instead of <time.h>.
7162 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7163 Problem reported by Herbert J. Skuhra.
7165 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7167 * xml.c (parse_region): Make the parsing work for
7168 non-comment-starting XML files again (bug#9144).
7170 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7172 * image.c (gif_load): Fix calculation of bottom and right corner.
7175 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7177 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7178 redisplay in small windows.
7180 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7182 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7184 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7186 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7187 Operate on live windows only.
7189 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7191 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7193 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7195 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7196 only under bidi iteration.
7198 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7200 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7202 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7204 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7205 Without this fix, the command to link temacs failed due to an
7206 undefined symbol __builtin_isnan. This is because
7207 /usr/include/iso/math_c99.h #defines isnan(x) to
7208 __builtin_isnan(x), but the bundled gcc, which identifies itself
7209 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7211 * floatfns.c (isnan): #undef, and then #define to a clone of
7213 (Fisnan): Always define, since it's always available now.
7214 (syms_of_floatfns): Always define isnan at the Lisp level.
7216 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7218 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7220 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7222 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7223 The previous code assumed that file offsets (off_t values) fit in
7224 EMACS_INT variables, which is not true on typical 32-bit hosts.
7225 The code messed up by falsely reporting buffer overflow in cases
7226 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7227 when "big" contains more than 2**29 bytes, even though this
7228 inserts just one byte and does not overflow the buffer.
7229 (Finsert_file_contents): Store file offsets as off_t
7230 values, not as EMACS_INT values. Check for overflow when
7231 converting between EMACS_INT and off_t. When checking for
7232 buffer overflow or for overlap, take the offsets into account.
7233 Don't use EMACS_INT for small values where int suffices.
7234 When checking for overlap, fix a typo: ZV was used where
7235 ZV_BYTE was intended.
7236 (Fwrite_region): Don't assume off_t fits into 'long'.
7237 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7239 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7241 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7243 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7245 sprintf-related integer and memory overflow issues (Bug#9412).
7247 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7248 (esprintf, exprintf, evxprintf): New functions.
7249 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7250 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7251 (modify_event_symbol): Do not assume that the length of
7252 name_alist_or_stem is safe to alloca and fits in int.
7253 (Fexecute_extended_command): Likewise for function name and binding.
7254 (Frecursion_depth): Wrap around reliably on integer overflow.
7255 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7256 since some callers pass EMACS_INT values.
7257 (Fsingle_key_description): Don't crash if symbol name contains more
7258 than MAX_ALLOCA bytes.
7259 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7260 (get_minibuffer): Arg is now EMACS_INT, not int.
7261 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7262 (esprintf, exprintf, evxprintf): New decls.
7263 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7265 * dbusbind.c (signature_cat): New function.
7266 (xd_signature, Fdbus_register_signal):
7267 Do not overrun buffer; instead, report string overflow.
7269 * dispnew.c (add_window_display_history): Don't overrun buffer.
7270 Truncate instead; this is OK since it's just a log.
7272 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7273 even if the time zone offset is outlandishly large.
7274 Don't mishandle offset == INT_MIN.
7276 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7277 when creating daemon; the previous buffer-overflow check was incorrect.
7279 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7280 which has the guts of the old verror function.
7282 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7283 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7285 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7286 (font_unparse_xlfd): Don't blindly alloca long strings.
7287 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7288 fits in int, when using sprintf. Use single snprintf to count
7289 length of string rather than counting it via multiple sprintfs;
7290 that's simpler and more reliable.
7291 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7292 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7293 sprintf, in case result does not fit in int.
7295 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7296 (fontset_from_font): Print it.
7298 * frame.c (tty_frame_count): Now printmax_t, not int.
7299 (make_terminal_frame, set_term_frame_name): Print it.
7300 (x_report_frame_params): In X, window IDs are unsigned long,
7301 not signed long, so print them as unsigned.
7302 (validate_x_resource_name): Check for implausibly long names,
7303 and don't assume name length fits in 'int'.
7304 (x_get_resource_string): Don't blindly alloca invocation name;
7305 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7308 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7309 (xg_check_special_colors, xg_set_geometry):
7310 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7312 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7313 Use esprintf, not sprintf, in case result does not fit in int.
7315 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7316 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7317 it as a large positive number.
7318 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7319 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7321 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7322 in case result does not fit in int.
7324 * print.c (float_to_string): Detect width overflow more reliably.
7325 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7326 buffer overrun. Don't assume list length fits in 'int'. Treat
7327 print length of 0 as 0, not as infinity; to be consistent with other
7328 uses of print length in this function. Don't overflow print length
7329 index. Don't assume hash table size fits in 'long', or that
7330 vectorlike size fits in 'unsigned long'.
7332 * process.c (make_process): Use printmax_t, not int, to format
7333 process-name gensyms.
7335 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7337 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7338 to avoid potential buffer overrun.
7340 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7341 if X resource line is longer than 512 bytes.
7343 * xfns.c (x_window): Make sprintf buffer a bit bigger
7344 to avoid potential buffer overrun.
7346 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7348 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7350 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7352 Integer overflow fixes for scrolling, etc.
7353 Without these, Emacs silently mishandles large integers sometimes.
7354 For example, "C-u 4294967297 M-x recenter" was treated as if
7355 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7357 * xdisp.c (try_window_id): Check Emacs fixnum range before
7358 converting to 'int'.
7360 * window.c (window_scroll_line_based, Frecenter):
7361 Check that an Emacs fixnum is in range before assigning it to 'int'.
7362 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7363 values converted from Emacs fixnums.
7364 (Frecenter): Don't wrap around a line count if it is out of 'int'
7365 range; instead, treat it as an extreme value.
7366 (Fset_window_configuration, compare_window_configurations):
7367 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7369 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7370 that can exceed INT_MAX. Check that EMACS_INT value is in range
7371 before assigning it to the (possibly-narrower) index.
7372 (match_limit): Don't assume that a fixnum can fit in 'int'.
7374 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7377 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7378 (Fvertical_motion): Don't wrap around LINES values that don't fit
7379 in 'int'. Instead, treat them as extreme values. This is good
7380 enough for windows, which can't have more than INT_MAX lines anyway.
7382 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7384 * Require libxml/parser.h to avoid compilation warning.
7386 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7388 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7389 since this reportedly can destroy thread storage.
7391 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7393 * syntax.c (find_defun_start): Update all cache variables if
7394 exiting early (Bug#9401).
7396 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7398 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7400 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7401 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7402 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7404 * term.c (tty_append_glyph): New function.
7405 (produce_stretch_glyph): Static function and its prototype deleted.
7407 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7410 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7412 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7413 when checking :margin (Bug#9390).
7414 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7415 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7416 so that the name doesn't mislead. All uses changed.
7418 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7420 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7423 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7425 * xdisp.c (move_it_to): Don't bail out early when reaching
7426 position beyond to_charpos, if we are scanning backwards.
7427 (move_it_vertically_backward): When DY == 0, make sure we get to
7428 the first character in the line after the newline.
7430 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7432 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7433 (ccl_driver): Do not generate an out-of-range pointer.
7434 (Fccl_execute_on_string): Remove unnecessary check for
7435 integer overflow, noted by Stefan Monnier in
7436 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7437 Remove a FIXME that didn't need fixing.
7438 Simplify the newly-introduced buffer reallocation code.
7440 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7442 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7444 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7446 Integer and memory overflow issues (Bug#9196).
7448 * doc.c (get_doc_string): Rework so that
7449 get_doc_string_buffer_size is the actual buffer size, rather than
7450 being 1 less than the actual buffer size; this makes xpalloc more
7453 * image.c (x_allocate_bitmap_record, cache_image):
7454 * xselect.c (Fx_register_dnd_atom):
7455 Simplify previous changes by using xpalloc.
7457 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7458 since either will do and ptrdiff_t is convenient with xpalloc.
7460 * charset.c (charset_table_size)
7461 (struct charset_sort_data.priority): Now ptrdiff_t.
7462 (charset_compare): Don't overflow if priorities differ greatly.
7463 (Fsort_charsets): Don't assume list length fits in int.
7464 Check for size-calculation overflow when allocating sort data.
7465 (syms_of_charset): Allocate an initial charset table that is
7466 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7468 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7470 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7471 The actual value is always <= INT_MAX, and leaving it unsigned made
7472 overflow checking harder.
7474 * dispextern.h (struct glyph_matrix.rows_allocated)
7475 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7476 with xpalloc. The values are still always <= INT_MAX.
7478 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7480 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7481 (SAFE_NALLOCA): New macro.
7483 * region-cache.c (struct boundary.pos, find_cache_boundary)
7484 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7485 (set_cache_region, invalidate_region_cache)
7486 (revalidate_region_cache, know_region_cache, region_cache_forward)
7487 (region_cache_backward, pp_cache):
7488 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7489 so that ptrdiff_t * can be passed to xpalloc.
7490 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7491 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7492 (pp_cache): Don't assume cache_len fits in int.
7493 * region-cache.h: Adjust extern decls to match.
7495 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7496 EMACS_INT, since either will do, for xpalloc.
7498 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7499 (xnmalloc, xnrealloc, xpalloc): New functions.
7501 * bidi.c (bidi_shelve_header_size): New constant.
7502 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7503 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7505 * bidi.c (bidi_cache_shrink):
7506 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7508 Don't update size of array until after memory allocation succeeds,
7509 because xmalloc/xrealloc may not return.
7510 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7511 now that we have proper integer overflow checking.
7512 (record_overlay_string, overlay_strings): Catch overflows when
7513 calculating size of overlay_str_buf.
7515 * callproc.c (Fcall_process): Check for size overflow when
7516 calculating size of args2.
7517 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7518 Normally we prefer signed values, but sticking with ptrdiff_t would
7519 require adding more-complicated checks.
7521 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7522 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7523 Redo buffer-overflow calculations to avoid integer overflow.
7524 Add a FIXME comment where memory seems to be over-allocated.
7526 * character.c (Fstring): Check for size-calculation overflow.
7528 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7529 unnecessary integer overflow. Check for size overflow.
7530 (encode_coding_object): Don't update size until xmalloc succeeds.
7532 * composite.c (get_composition_id): Check for overflow in glyph
7533 length calculations.
7535 Integer and memory overflow fixes for display code.
7536 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7537 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7538 (scrolling_window): Check for overflow in size calculations.
7539 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7540 Don't assume glyph table len fits in int.
7541 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7542 (row_table_size): Now ptrdiff_t, not int.
7543 (scrolling_window): Avoid overflow in size calculations.
7544 Don't update size until allocation succeeds.
7545 * fns.c (concat): Check for overflow in size calculations.
7546 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7547 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7548 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7550 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7551 (get_doc_string): Check for size calculation overflow.
7552 Don't update size until allocation succeeds.
7553 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7554 EMACS_INT, where ptrdiff_t will do.
7555 (Fsubstitute_command_keys): Check for string overflow.
7557 * editfns.c (set_time_zone_rule): Don't assume environment length
7559 (message_length): Now ptrdiff_t, not int.
7560 (Fmessage_box): Don't update size until allocation succeeds.
7561 Don't assume message length fits in int.
7562 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7564 * emacs.c (main): Do not reallocate argv, since there is a null at
7565 the end that can be overwritten, and this way there's no need to
7566 worry about size-calculation overflow.
7567 (sort_args): Check for size-calculation overflow.
7569 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7571 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7573 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7574 (x_set_scroll_bar_width, x_figure_window_size):
7575 Check for integer overflow.
7576 (x_set_alpha): Do not assume XINT fits in int.
7578 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7579 This is for the members text_lines, text_cols, total_lines, total_cols,
7580 where the system imposes an 'int' limit.
7582 * fringe.c (Fdefine_fringe_bitmap):
7583 Don't update size until alloc works.
7585 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7586 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7588 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7589 Check for size-calculation overflow.
7590 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7591 do, as we prefer signed integers.
7592 (id_to_widget.max_size, id_to_widget.used)
7593 (xg_store_widget_in_map, xg_remove_widget_from_map)
7594 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7595 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7596 Use and return ptrdiff_t, not int.
7597 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7598 * gtkutil.h: Change prototypes to match the above.
7600 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7601 are duplicate now that they've been promoted to lisp.h.
7602 (x_allocate_bitmap_record, x_alloc_image_color)
7603 (make_image_cache, cache_image, xpm_load):
7604 Don't update size until alloc is done.
7605 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7607 Check for size calculation overflow.
7608 (ct_colors_allocated_max): New constant.
7609 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7612 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7613 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7614 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7615 Use ptrdiff_t, not int, to count maps.
7616 (read_char_minibuf_menu_prompt): Check for overflow in size
7617 calculations. Don't update size until allocation succeeds.
7618 Redo calculations to avoid overflow.
7619 * keyboard.h: Change prototypes to match the above.
7621 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7623 (current_minor_maps): Check for size calculation overflow.
7624 * keymap.h: Change prototypes to match the above.
7626 * lread.c (read1, init_obarray): Don't update size until alloc done.
7628 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7629 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7631 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7632 Now ptrdiff_t, not int.
7633 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7634 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7636 * process.c (Fnetwork_interface_list): Check for overflow
7637 in size calculation.
7639 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7641 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7642 overflow. Don't bother calling xmalloc when xrealloc will do.
7644 * search.c (Freplace_match): Check for size calculation overflow.
7645 (Fset_match_data): Don't assume list lengths fit in 'int'.
7647 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7648 for command line length. Do not attempt to address one before the
7649 beginning of an array, as that's not portable.
7651 * term.c (max_frame_lines): Remove; unused.
7652 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7654 (encode_terminal_code, calculate_costs): Check for size
7655 calculation overflow.
7656 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7657 table lengths and related sizes. Don't update size until alloc
7658 done. Redo calculations to avoid overflow.
7659 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7661 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7662 subtracting pointers.
7663 (gobble_line): Check for overflow more carefully. Don't update size
7666 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7667 Don't update size until alloc done.
7668 Redo size calculations to avoid overflow.
7669 Check for size calculation overflow.
7670 (main) [DEBUG]: Fix typo in invoking tparam1.
7672 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7673 Use ptrdiff_t, not int, for sizes.
7674 (store_mode_line_noprop_char): Don't update size until alloc done.
7676 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7677 Use ptrdiff_t, not int, for sizes.
7678 (Finternal_make_lisp_face, cache_face):
7679 Check for size calculation overflow.
7680 (cache_face): Treat size calculation overflows as if they were
7681 memory exhaustion (the usual treatment), rather than aborting.
7683 * xfns.c (x_encode_text, x_set_name_internal)
7684 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7685 sizes, since they can exceed INT_MAX in size. Check for size
7686 calculation overflow.
7688 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7689 (xg_select): Check for size calculation overflow.
7690 Don't update size until alloc done.
7692 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7693 as sprintf is limited to int lengths.
7695 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7696 (X_LONG_MIN): New macros.
7697 Use them to make the following changes clearer.
7698 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7699 This change doesn't affect the value now, but it may help remind
7700 future maintainers not to raise the value too much later.
7701 (SELECTION_QUANTUM): Remove, replacing with ...
7702 (selection_quantum): ... new function, which avoids overflow.
7704 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7705 assumption that selection length fits in 'int'.
7706 (x_reply_selection_request, x_handle_selection_request)
7707 (x_get_window_property, receive_incremental_selection)
7708 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7709 (lisp_data_to_selection_data, clean_local_selection_data):
7710 Use ptrdiff_t, not int, to record length of selection.
7711 (x_reply_selection_request, x_get_window_property)
7712 (receive_incremental_selection, x_property_data_to_lisp):
7713 Redo calculations to avoid overflow.
7714 (x_reply_selection_request): When sending hint, ceiling it at
7715 X_LONG_MAX rather than relying on wraparound overflow to send
7717 (x_get_window_property, receive_incremental_selection)
7718 (lisp_data_to_selection_data, x_property_data_to_lisp):
7719 Check for size-calculation overflow.
7720 (x_get_window_property, receive_incremental_selection)
7721 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7722 Don't store size until memory allocation succeeds.
7723 (x_get_window_property): Plug memory leak on memory exhaustion.
7724 Don't double-block input; malloc is safe here. Don't assume 2**34
7725 - 4 fits in unsigned long. Add an xassert to check
7726 XGetWindowProperty overflow. Be more careful about overflow
7727 calculations, and distinguish size from memory overflow better.
7728 (receive_incremental_selection): When tracing, don't assume
7729 unsigned int is less than INT_MAX.
7730 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7731 harmful) conversions of unsigned short to int.
7732 (lisp_data_to_selection_data): Don't assume that integers
7733 in the range -65535 through -1 fit in an X unsigned short.
7734 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7735 result parameters unless successful. Rely on cons_to_unsigned
7736 to report problems with elements; the old code wasn't right anyway.
7737 (x_check_property_data): Check for int overflow; we cannot use
7738 a wider type due to X limits.
7739 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7741 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7743 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7744 (x_term_init): Check for size calculation overflow.
7745 (x_color_cells): Don't store size until memory allocation succeeds.
7746 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7747 Don't assume alloca size is less than MAX_ALLOCA.
7748 (x_term_init): Don't assume length fits in int (sprintf is limited
7751 Use ptrdiff_t for composition IDs.
7752 * character.c (lisp_string_width):
7753 * composite.c (composition_table_size, n_compositions)
7754 (get_composition_id, composition_gstring_from_id):
7755 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7756 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7757 * window.c (Frecenter):
7758 Use ptrdiff_t, not int, for composition IDs.
7759 * composite.c (get_composition_id): Check for integer overflow.
7760 * composite.h: Adjust prototypes to match the above changes.
7762 Use ptrdiff_t for hash table indexes.
7763 * category.c (hash_get_category_set):
7764 * ccl.c (ccl_driver):
7765 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7766 * coding.c (coding_system_charset_list, detect_coding_system):
7767 * coding.h (struct coding_system.id):
7768 * composite.c (get_composition_id, gstring_lookup_cache):
7769 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7770 * image.c (xpm_get_color_table_h):
7771 * lisp.h (hash_lookup, hash_put):
7772 * minibuf.c (Ftest_completion):
7773 Use ptrdiff_t for hash table indexes, not int (which is too
7774 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7775 32-bit --with-wide-int hosts).
7777 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7778 Add a FIXME comment about memory leaks.
7779 (syms_of_charset): Don't assume xmalloc returns.
7781 Don't assume that stated character widths fit in int.
7782 * character.c (Fchar_width, c_string_width, lisp_string_width):
7783 * character.h (CHAR_WIDTH):
7784 * indent.c (MULTIBYTE_BYTES_WIDTH):
7785 Use sanitize_char_width to avoid undefined and/or bad behavior
7786 with outlandish widths.
7787 * character.h (sanitize_tab_width): Rename from sanitize_width,
7788 now that we have two such functions. All uses changed.
7789 (sanitize_char_width): New inline function.
7791 Don't assume that tab-width fits in int.
7792 * character.h (sanitize_width): New inline function.
7793 (SANE_TAB_WIDTH): New macro.
7794 (ASCII_CHAR_WIDTH): Use it.
7795 * indent.c (sane_tab_width): Remove. All uses replaced by
7796 SANE_TAB_WIDTH (current_buffer).
7797 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7799 * fileio.c: Integer overflow issues with file modes.
7800 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7802 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7803 Remove unreachable code.
7804 (read_hex, load_charset_map_from_file): Check for integer overflow.
7806 * xterm.c: Don't go over XClientMessageEvent limit.
7807 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7808 (x_send_scroll_bar_event): Likewise. Check that the size does not
7809 exceed limits imposed by XClientMessageEvent, as well as the usual
7810 ptrdiff_t and size_t limits.
7812 * keyboard.c: Overflow, signedness and related fixes.
7813 (make_lispy_movement): Use same integer type in forward decl
7814 that is used in the definition.
7815 (read_key_sequence, keyremap_step):
7816 Change bufsize argument back to int, undoing my 2011-03-30 change.
7817 We prefer signed types, and int is wide enough here.
7818 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7819 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7820 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7821 length, not size_t. Use ptrdiff_t for index, not int.
7822 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7823 possibility of integer overflow.
7825 Overflow, signedness and related fixes for images.
7827 * dispextern.h (struct it.stack[0].u.image.image_id)
7828 (struct_it.image_id, struct image.id, struct image_cache.size)
7829 (struct image_cache.used, struct image_cache.ref_count):
7830 * gtkutil.c (update_frame_tool_bar):
7831 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7832 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7833 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7834 * nsmenu.m (update_frame_tool_bar):
7835 * xdisp.c (calc_pixel_width_or_height):
7836 * xfns.c (image_cache_refcount):
7837 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7838 on typical 64-bit hosts.
7840 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7841 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7842 Omit unnecessary casts to int.
7843 (parse_image_spec): Check that integers fall into 'int' range
7844 when the callers expect that.
7845 (image_ascent): Redo ascent calculation to avoid int overflow.
7846 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7847 (lookup_image): Remove unnecessary tests.
7848 (xbm_image_p): Locals are now of int, not EMACS_INT,
7849 since parse_image_check makes sure they fit into int.
7850 (png_load, gif_load, svg_load_image):
7851 Prefer int to unsigned where either will do.
7852 (tiff_handler): New function, combining the cores of the
7853 old tiff_error_handler and tiff_warning_handler.
7854 This function is rewritten to use vsnprintf and thereby avoid
7855 stack buffer overflows. It uses only the features of vsnprintf
7856 that are common to both POSIX and native Microsoft.
7857 (tiff_error_handler, tiff_warning_handler): Use it.
7858 (tiff_load, gif_load, imagemagick_load_image):
7859 Don't assume :index value fits in 'int'.
7860 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7861 (imagemagick_load_image): Check that crop parameters fit into
7862 the integer types that MagickCropImage accepts. Don't assume
7863 Vimagemagick_render_type has a nonnegative value. Don't assume
7864 size_t fits in 'long'.
7865 (gs_load): Use printmax_t to print the widest integers possible.
7866 Check for integer overflow when computing image height and width.
7868 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7870 * xdisp.c (redisplay_window): Don't force window start if point
7871 will be invisible in the resulting window. (Bug#9324)
7873 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7875 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7876 the display spec is of the form `(space ...)'.
7877 (handle_display_spec): Return the value returned by
7878 handle_single_display_spec, not just 1 or zero.
7879 (handle_single_display_spec): If the display spec is of the form
7880 `(space ...)', and specifies display in the text area, return 2
7882 (try_cursor_movement): Check for the need to scroll more
7883 accurately, and prefer exact match for point under bidi.
7884 Don't advance `row' beyond the last row of the window.
7886 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7887 into disp_prop; all users changed.
7889 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7890 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7891 for the text covered by the display property.
7893 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7895 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7896 Change return value to nil.
7897 (Frecord_buffer): Delete unused function.
7899 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7901 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7902 buffers, return left-to-right.
7903 (set_cursor_from_row): Consider candidate row a win if its glyph
7904 represents a newline and point is on that newline. Fixes cursor
7905 positioning on the newline at EOL of R2L text within L2R
7906 paragraph, and vice versa.
7907 (try_cursor_movement): Check continued rows, in addition to
7908 continuation rows. Fixes unwarranted scroll when point enters a
7909 continued line of R2L text within an L2R paragraph, or vice versa.
7910 (cursor_row_p): Consider the case of point being equal to
7911 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7912 from the end of a short line to the beginning of a continued line
7913 of R2L text within L2R paragraph.
7914 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7915 composed characters.
7917 * bidi.c (bidi_check_type): Use xassert.
7918 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7921 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7923 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7926 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7928 * nsfont.m (ns_otf_to_script): Fix typo.
7930 2011-08-22 Kenichi Handa <handa@m17n.org>
7932 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7933 extra slot even if the purpose is char-code-property-table.
7935 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7937 * xdisp.c (redisplay_window): When computing centering_position,
7938 account for the height of the header line. (Bug#8874)
7940 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7941 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7942 candidate is selected by the mouse, and that candidate has a
7943 composed character under the mouse.
7945 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7946 coordinates reported by pos-visible-in-window-p for a composed
7947 character in column zero.
7949 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7951 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7953 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7955 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7956 consider it a hit if to_charpos is anywhere in the range of the
7957 composed buffer positions.
7959 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7961 * image.c (gif_load): Don't assume that each subimage has the same
7962 dimensions as the base image. Handle disposal method that is
7963 "undefined" by the gif spec (Bug#9335).
7965 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7967 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7968 (Fcondition_case): Document `debug' symbol in error handler.
7970 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7972 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7973 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7974 from an Org mode buffer to a Speedbar frame.
7976 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7977 a composition, take its buffer position from IT->cmp_it.charpos.
7978 Fixes cursor positioning at the beginning of a line that begins
7979 with a composed character.
7981 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7983 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7984 character bidirectional type, use STRONG_L instead. Fixes crashes
7985 in a buffer produced by `describe-categories'.
7987 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7988 members before the level stack, so they would be saved and
7989 restored when copying iterator state. Fixes incorrect reordering
7990 around TABs covered by display properties.
7992 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7994 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7996 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7998 * eval.c (internal_condition_case, internal_condition_case_1)
7999 (internal_condition_case_2, internal_condition_case_n):
8000 Remove unnecessary aborts (Bug#9081).
8002 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8004 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8005 has no `load' handler, try opening the file locally. (Bug#9311)
8007 2011-08-16 Ken Brown <kbrown@cornell.edu>
8009 * gmalloc.c: Expand comment.
8011 2011-08-16 Eli Zaretskii <eliz@gnu.org>
8013 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8014 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8016 2011-08-16 Ken Brown <kbrown@cornell.edu>
8018 Fix memory allocation problems in Cygwin build (Bug#9273).
8020 * unexcw.c ( __malloc_initialized): Declare external variable.
8021 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8023 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8025 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8027 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8029 [CYGWIN] (special_realloc): New function.
8030 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8031 requests to realloc storage in the static heap.
8033 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8035 * bidi.c (bidi_initialize): Remove unused local.
8037 2011-08-15 Eli Zaretskii <eliz@gnu.org>
8040 * biditype.h: Remove file.
8041 * makefile.w32-in ($(BLD)/bidi.$(O)):
8042 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
8044 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8046 * chartab.c: Improve commentary for the uniprop_table API.
8048 * bidi.c (bidi_paragraph_init): Support zero value of
8049 bidi_ignore_explicit_marks_for_paragraph_level.
8050 (bidi_initialize): Use uniprop_table instead of including
8051 biditype.h and bidimirror.h.
8053 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8054 coordinates of the iterator when restoring from ppos_it.
8057 2011-08-14 Kenichi Handa <handa@m17n.org>
8059 * process.c (create_process): Call setup_process_coding_systems
8060 after the pid of the process is set to -1 (Bug#8162).
8062 2011-08-14 Eli Zaretskii <eliz@gnu.org>
8064 * xdisp.c (move_it_in_display_line_to): Don't invoke
8065 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8066 ppos_it. Fixes vertical cursor motion when line beginning is
8067 covered by an image. (Bug#9296)
8069 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8071 * nsterm.h (ns_run_ascript): Declare.
8072 (NSAPP_DATA2_RUNASSCRIPT): Define.
8074 * nsfns.m (as_script, as_result, as_status): New static variables.
8075 (ns_run_ascript): New function.
8076 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
8077 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8078 the event loop. Get status from as_status (Bug#7276).
8080 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8081 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8082 the event loop (Bug#7276).
8084 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8086 * gnutls.c (QCgnutls_bootprop_priority)
8087 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8088 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8089 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8090 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8091 (QCgnutls_bootprop_verify_hostname_error)
8092 (QCgnutls_bootprop_callbacks_verify): Rename from
8093 Qgnutls_bootprop_..., all uses changed.
8095 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8098 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8100 * xfaces.c (Qframe_set_background_mode): Now static.
8101 * dispextern.h (Qframe_set_background_mode): Remove decl.
8103 * process.c (Fnetwork_interface_info): Declare local only if needed.
8105 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8107 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8108 (Fnetwork_interface_list): Allocate in increments of bytes instead
8109 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8110 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8112 (struct ifflag_def): notrailers is smart on OSX.
8113 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8114 Get hardware address with getifaddrs if available.
8116 2011-08-12 Eli Zaretskii <eliz@gnu.org>
8118 * xdisp.c (iterate_out_of_display_property): xassert that
8119 IT->position is set to within IT->object's boundaries. Break from
8120 the loop as soon as EOB is reached; avoids infloops in redisplay
8121 when IT->position is set up wrongly due to some bug.
8122 Set IT->current to match the bidi iterator unconditionally.
8123 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8124 entry. Force push_it to save on the stack the current
8125 buffer/string position, to be restored by pop_it. Fix flags in
8126 the iterator structure wrt the object coming from a display
8127 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8128 properties. (Bug#9284)
8130 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
8132 * fontset.c (fontset_get_font_group): Add proper type checks.
8135 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8137 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8138 and LC_VERSION_MIN_MACOSX.
8139 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8140 (dump_it) [LC_FUNCTION_STARTS]: Use it.
8142 2011-08-08 Eli Zaretskii <eliz@gnu.org>
8144 * xdisp.c (forward_to_next_line_start): Allow to use the
8145 no-display-properties-and-no-overlays under bidi display.
8146 Set disp_pos in the bidi iterator to avoid searches for display
8147 properties and overlays.
8149 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8151 * editfns.c (Fset_time_zone_rule): Document relationship with the
8154 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8155 the font entity extracted from the cache (Bug#8109).
8157 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8159 * composite.c (autocmp_chars): Don't reset point. That is done by
8160 restore_point_unwind (Bug#5984).
8162 2011-08-07 Juri Linkov <juri@jurta.org>
8164 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8165 to show the arg `TIME' instead of `TIMEVAL'.
8167 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8169 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8170 display property strides EOL and includes a newline, as in
8171 longlines-mode. (Bug#9254)
8172 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8173 word-wrap under bidirectional display. (Bug#9224)
8175 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8176 is non-zero, even if the data buffer is NULL. Fixes a crash in
8177 vertical-motion with longlines-mode. (Bug#9254)
8179 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8181 * bidi.c <bidi_cache_total_alloc>: Now static.
8182 (bidi_initialize): Initialize bidi_cache_total_alloc.
8184 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8187 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8188 amount allocated this far in `bidi_cache_total_alloc'.
8189 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8190 non-zero, only free the data buffer without restoring the cache
8191 contents. All callers changed.
8193 * dispextern.h (bidi_unshelve_cache): Update prototype.
8195 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8196 (move_it_in_display_line, move_it_to)
8197 (move_it_vertically_backward, move_it_by_lines): Replace the call
8198 to xfree to an equivalent call to bidi_unshelve_cache.
8199 (move_it_in_display_line_to): Fix logic of returning
8200 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8202 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8204 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8205 came from a string character with a `cursor' property. (Bug#9229)
8207 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8209 * Makefile.in (LIB_PTHREAD): New variable.
8210 (LIBES): Add LIB_PTHREAD (Bug#9216).
8212 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8213 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8215 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8217 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8219 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8221 * xterm.c (x_find_topmost_parent): New function.
8222 (x_set_frame_alpha): Find topmost parent window with
8223 x_find_topmost_parent and set the property there also (bug#9181).
8224 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8226 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8228 * callproc.c (Fcall_process): Avoid vfork clobbering
8229 the local vars buffer, coding_systems, current_dir.
8231 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8233 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8235 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8237 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8238 so that it is not optimized away.
8240 * xdisp.c (compute_display_string_pos): Remove unused local.
8242 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8244 Fix slow cursor motion and scrolling in large buffers with
8245 selective display, like Org Mode buffers. (Bug#9218)
8247 * dispextern.h (struct bidi_it): New member disp_prop_p.
8249 * xdisp.c: Remove one-slot cache of display string positions.
8250 (compute_display_string_pos): Accept an additional argument
8251 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8252 for a display string or property. If found, set DISP_PROP_P
8255 * bidi.c (bidi_fetch_char): Accept an additional argument
8256 DISP_PROP_P, and pass it to compute_display_string_pos.
8257 Only handle text covered by a display string if DISP_PROP_P is returned
8258 non-zero. All callers of bidi_fetch_char changed.
8260 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8262 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8264 2010-12-03 Don March <don@ohspite.net>
8266 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8267 last character M-[char] is translated to ESC [char] (bug#7541).
8269 2011-08-02 Kenichi Handa <handa@m17n.org>
8271 * lisp.h (uniprop_table): Extern it.
8273 * chartab.c (uniprop_table): Make it non-static.
8275 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8277 * xdisp.c (forward_to_next_line_start): Accept additional argument
8278 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8280 (reseat_at_next_visible_line_start): Use the bidi iterator state
8281 returned by forward_to_next_line_start to restore the state of
8282 it->bidi_it after backing up to previous newline. (Bug#9212)
8284 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8286 * regex.c (re_comp): Protoize.
8287 (re_exec): Fix return type.
8288 (regexec): Fix type of `ret'. (Bug#9203)
8290 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8292 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8293 This is needed if max-image-size is a floating-point number.
8295 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8297 * print.c (print_object): Print empty symbol as ##.
8299 * lread.c (read1): Read ## as empty symbol.
8301 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8303 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8304 setting frame foreground color (Bug#9175).
8305 (x_set_background_color): Likewise.
8307 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8308 contents (Bug#9176).
8309 (EmacsTooltip -init): Remove bezels and add shadows to
8312 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8313 or scroll bar (Bug#8470).
8315 * nsfont.m (nsfont_open): Remove assignment to voffset and
8316 unnecessary vars hshink, expand, hd, full_height, min_height.
8317 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8319 * nsterm.h (nsfont_info): Remove voffset field.
8321 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8323 Implement strike-through and overline on NextStep (Bug#8863).
8325 * nsfont.m (nsfont_open): Use underline position provided by font,
8326 instead of hard-coded value of 2.
8327 (nsfont_draw): Call ns_draw_text_decoration instead.
8329 * nsterm.h: Add declaration for ns_draw_text_decoration.
8331 * nsterm.m (ns_draw_text_decoration): New function for drawing
8332 underline, overline, and strike-through.
8333 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8334 ns_draw_text_decoration. Change treatment of cursor drawing to
8335 accommodate underlining, etc.
8337 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8339 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8342 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8344 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8345 Without this fix, if a signal arrives just after memory fills up,
8346 'malloc' might be invoked reentrantly.
8348 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8349 In other words, assume that every image size is allowed, on non-X
8350 hosts. This assumption is probably wrong, but it lets Emacs compile.
8352 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8354 * regex.c (re_iswctype): Convert return values to boolean.
8356 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8358 * xdisp.c (compute_display_string_pos): Don't use cached display
8359 string position if the buffer had its restriction changed.
8362 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8364 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8366 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8368 Integer signedness and overflow and related fixes. (Bug#9079)
8370 * bidi.c: Integer size and overflow fixes.
8371 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8372 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8373 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8374 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8375 (bidi_find_other_level_edge):
8376 Use ptrdiff_t instead of EMACS_INT where either will do.
8377 This works better on 32-bit hosts configured --with-wide-int.
8378 (bidi_cache_ensure_space): Check for size-calculation overflow.
8379 Use % rather than repeated addition, for better worst-case speed.
8380 Don't set bidi_cache_size until after xrealloc returns, because it
8382 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8383 (bidi_cache_ensure_space): Also check that the bidi cache size
8384 does not exceed that of the largest Lisp string or buffer. See Eli
8385 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8387 * alloc.c (__malloc_size_t): Remove.
8388 All uses replaced by size_t. See Andreas Schwab's note
8389 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8391 * image.c: Improve checking for integer overflow.
8392 (check_image_size): Assume that f is nonnull, since
8393 it is always nonnull in practice. This is one less thing to
8394 worry about when checking for integer overflow later.
8395 (x_check_image_size): New function, which checks for integer
8396 overflow issues inside X.
8397 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8398 This removes the need for a memory_full check.
8399 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8400 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8401 (xbm_read_bitmap_data): Change locals back to 'int', since
8402 their values must fit in 'int'.
8403 (xpm_load_image, png_load, tiff_load):
8404 Invoke x_create_x_image_and_pixmap earlier,
8405 to avoid much needless work if the image is too large.
8406 (tiff_load): Treat overly large images as if
8407 x_create_x_image_and_pixmap failed, not as malloc failures.
8408 (gs_load): Use x_check_image_size.
8410 * gtkutil.c: Omit integer casts.
8411 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8412 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8414 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8416 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8417 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8418 would wrongly return t on a 64-bit host.
8420 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8421 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8422 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8423 and therefore cause GCC to emit a bogus diagnostic in some cases.
8425 * image.c: Integer signedness and overflow and related fixes.
8426 This is not an exhaustive set of fixes, but it's time to
8427 record what I've got.
8428 (lookup_pixel_color, check_image_size): Remove redundant decls.
8429 (check_image_size): Don't assume that arbitrary EMACS_INT values
8430 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8431 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8432 (tiff_load, imagemagick_load_image):
8433 Check for overflow in size calculations.
8434 (x_create_x_image_and_pixmap): Remove unnecessary test for
8435 xmalloc returning NULL; that can't happen.
8436 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8437 (xpm_color_bucket): Use better integer hashing function.
8438 (xpm_cache_color): Don't possibly over-allocate memory.
8439 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8440 (gif_memory_source):
8441 Use ptrdiff_t, not int or size_t, to record sizes.
8442 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8443 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8444 either works, as we prefer signed integers.
8445 (tiff_read_from_memory, tiff_write_from_memory):
8446 Return tsize_t, not size_t, since that's what the TIFF API wants.
8447 (tiff_read_from_memory): Don't fail simply because the read would
8448 go past EOF; instead, return a short read.
8449 (tiff_load): Omit no-longer-needed casts.
8450 (Fimagemagick_types): Don't assume size fits into 'int'.
8452 Improve hashing quality when configured --with-wide-int.
8453 * fns.c (hash_string): New function, taken from sxhash_string.
8454 Do not discard information about ASCII character case; this
8455 discarding is no longer needed.
8456 (sxhash-string): Use it. Change sig to match it. Caller changed.
8457 * lisp.h: Declare it.
8458 * lread.c (hash_string): Remove, since we now use fns.c's version.
8459 The fns.c version returns a wider integer if --with-wide-int is
8460 specified, so this should help the quality of the hashing a bit.
8462 * emacs.c: Integer overflow minor fix.
8463 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8464 Define only if GNU_LINUX.
8465 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8467 * dispnew.c: Integer signedness and overflow fixes.
8468 Remove unnecessary forward decls, that were a maintenance hassle.
8469 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8471 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8472 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8473 (prepare_desired_row, line_draw_cost):
8474 Use int, not unsigned, where either works.
8475 (save_current_matrix, restore_current_matrix):
8476 Use ptrdiff_t, not size_t, where either works.
8477 (init_display): Check for overflow more accurately, and without
8478 relying on undefined behavior.
8480 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8481 Remove, replacing with the new symbols in lisp.h. All uses changed.
8482 * fileio.c (make_temp_name):
8483 * filelock.c (lock_file_1, lock_file):
8484 * xdisp.c (message_dolog):
8485 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8486 Use pMd etc. instead.
8487 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8488 replacing the pWIDE etc. symbols removed from editfns.c.
8490 * keyboard.h (num_input_events): Now uintmax_t.
8491 This is (very slightly) less likely to mess up due to wraparound.
8494 * buffer.c: Integer signedness fixes.
8495 (alloc_buffer_text, enlarge_buffer_text):
8496 Use ptrdiff_t rather than size_t when either will do, as we prefer
8499 * alloc.c: Integer signedness and overflow fixes.
8500 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8501 (__malloc_size_t): Default to size_t, not to int.
8502 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8503 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8504 Prefer ptrdiff_t to size_t when either would do, as we prefer
8506 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8507 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8508 Now const. Initialize with values that are in range even if char
8510 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8511 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8512 These functions do the right thing with sizes > 2**32.
8513 (check_depth): Now ptrdiff_t, not int.
8514 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8515 Adjust to new way of storing sizes. Check for size overflow bugs
8517 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8518 slightly wrong anyway, as it missed one instance of
8519 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8520 (refill_memory_reserve): Omit needless cast to size_t.
8521 (mark_object_loop_halt): Mark as externally visible.
8523 * xselect.c: Integer signedness and overflow fixes.
8524 (Fx_register_dnd_atom, x_handle_dnd_message):
8525 Use ptrdiff_t, not size_t, since we prefer signed.
8526 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8527 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8528 x_dnd_atoms_size and x_dnd_atoms_length.
8530 * doprnt.c: Prefer signed to unsigned when either works.
8532 * doprnt.c (doprnt):
8534 * xdisp.c (vmessage):
8535 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8536 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8537 prefer signed arithmetic to avoid comparison confusion.
8538 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8539 but is a bit tricky.
8541 Assume freestanding C89 headers, string.h, stdlib.h.
8542 * data.c, doprnt.c, floatfns.c, print.c:
8543 Include float.h unconditionally.
8544 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8545 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8546 * regex.c: Likewise for stddef.h, string.h.
8547 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8548 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8549 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8550 (STDC_HEADERS): Remove obsolete defines.
8551 * sysdep.c: Include limits.h unconditionally.
8553 Assume support for memcmp, memcpy, memmove, memset.
8554 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8555 * regex.c (memcmp, memcpy):
8556 Remove; we assume C89 now.
8558 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8559 (__malloc_safe_bcopy): Remove; no longer needed.
8561 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8562 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8563 well either way, and we prefer signed to unsigned.
8565 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8567 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8568 closes the connection while we're reading (bug#9182).
8570 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8572 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8573 are specified (Bug#9168).
8575 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8577 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8578 Found by GCC static checking and --with-wide-int on a 32-bit host.
8580 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8582 * xdisp.c (compute_display_string_pos): Fix logic of caching
8583 previous display string position. Initialize cached_prev_pos to
8584 -1. Fixes slow-down at the beginning of a buffer.
8586 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8588 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8589 for attrs[LFACE_FONTSET_INDEX].
8591 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8593 * xml.c (parse_region): Remove unused local
8594 that was recently introduced.
8596 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8598 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8599 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8601 * xdisp.c (move_it_in_display_line_to): Record the best matching
8602 position for TO_CHARPOS while scanning the line, and restore it on
8603 exit if none of the characters scanned was an exact match.
8604 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8605 when exact match is impossible due to invisible text, and the
8606 lines are truncated.
8608 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8610 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8613 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8615 Fix a significant slow-down of cursor motion with C-n, C-p,
8616 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8617 auto-repeat under bidi redisplay in fontified buffers.
8618 * xdisp.c (compute_stop_pos_backwards): New function.
8619 (next_element_from_buffer): Call compute_stop_pos_backwards to
8620 find a suitable prev_stop when we find ourselves before
8622 (reseat): Don't look for prev_stop, as that could mean a very long
8624 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8625 <cached_disp_overlay_modiff>: Cache for last found display string
8627 (compute_display_string_pos): Return the cached position if asked
8628 about the same buffer in the same area of character positions, and
8629 the buffer wasn't changed since the time the display string
8630 position was cached.
8632 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8634 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8635 is an integer, which is important for empty lines. (Bug#9149)
8637 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8639 * frame.c (Fmodify_frame_parameters): In tty case, update the
8640 default face if necessary (Bug#4238).
8642 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8644 * editfns.c (Fstring_to_char): No need to explain what a character
8645 is in the docstring (Bug#6576).
8647 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8649 * xml.c (parse_region): Make sure we always return a tree.
8651 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8653 * xml.c (parse_region): If a document contains only comments,
8656 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8658 * xml.c (make_dom): Return comments, too.
8660 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8663 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8664 and the surrounding thread.
8665 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8666 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8667 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8669 * s/openbsd.h (BROKEN_SIGIO): Define.
8670 * unexelf.c (unexec) [__OpenBSD__]:
8671 Don't update the .mdebug section of the Alpha COFF symbol table.
8673 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8675 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8678 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8680 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8681 This fixes some race conditions on the permissions of any newly
8684 * alloc.c (valid_pointer_p): Use pipe, not open.
8685 This fixes some permissions issues when debugging.
8687 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8688 If fchown fails to set both uid and gid, try to set just gid,
8689 as that is sometimes allowed. Adjust the file's mode to eliminate
8690 setuid or setgid bits that are inappropriate if fchown fails.
8692 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8694 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8695 to compare Lisp_Objects.
8696 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8697 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8698 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8700 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8702 * lread.c (read_integer): Unread even EOF character.
8703 (read1): Likewise. Properly record start position of symbol.
8705 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8706 symbol character follows.
8708 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8710 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8711 This works around a problem with the previous change to Fcopy_file.
8712 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8713 and without this change, GCC might complain about discarding
8714 fchown's return value.
8716 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8718 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8720 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8722 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8724 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8726 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8727 it's used from the C level.
8729 * process.c: Use the same condition for POLL_FOR_INPUT in both
8730 keyboard.c and process.c (bug#1858).
8732 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8734 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8735 (Fgnutls_boot): Use it.
8737 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8739 * doc.c (Fsubstitute_command_keys): Revert last change.
8741 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8743 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8744 quotes the next character, and doesn't affect other longer
8745 sequences (bug#8935).
8747 * lread.c (syms_of_lread): Clarify that is isn't only
8748 `eval-buffer' and `eval-defun' that's affected by
8749 `lexical-binding' (bug#8460).
8751 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8753 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8754 bidi redisplay when a line includes both an image and is truncated.
8756 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8758 Fix minor problems found by static checking.
8759 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8760 (elsz): Now a signed constant, not a size_t var. We prefer signed
8761 types to unsigned, to avoid integer comparison confusion. Without
8762 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8763 "cannot optimize loop, the loop counter may overflow", a symptom
8765 * indent.c (Fvertical_motion): Mark locals as initialized.
8766 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8768 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8770 * search.c (Fre_search_backward): Mention `case-fold-search' in
8771 all the re_search_* functions (bug#8138).
8773 * keyboard.c (Fopen_dribble_file): Document when the file is
8776 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8778 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8781 Support bidi reordering of display and overlay strings.
8782 * xdisp.c (compute_display_string_pos)
8783 (compute_display_string_end): Accept additional argument STRING.
8784 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8785 (reseat_to_string): Initialize bidi_it->string.s and
8786 bidi_it->string.schars.
8787 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8788 NULL (avoids a crash in bidi_paragraph_init).
8789 Initialize itb.string.lstring.
8790 (init_iterator): Call bidi_init_it only of a valid
8791 buffer position was specified. Initialize paragraph_embedding to
8793 (reseat_to_string): Initialize the bidi iterator.
8794 (display_string): If we need to ignore text properties of
8795 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8796 original value of -1 will not work with bidi.)
8797 (compute_display_string_pos): First arg is now struct
8798 `text_pos *'; all callers changed. Support display properties on
8800 (compute_display_string_end): Support display properties on Lisp
8802 (init_iterator, reseat_1, reseat_to_string): Initialize the
8803 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8804 when iterating on a string not from display properties).
8805 (compute_display_string_pos, compute_display_string_end):
8806 Fix calculation of the object to scan. Fixes an error when using
8808 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8809 base_level_stop; instead, set base_level_stop to BEGV.
8810 Fixes crashes in vertical-motion.
8811 (next_element_from_buffer): Improve commentary for when
8812 the iterator is before prev_stop.
8813 (init_iterator): Initialize bidi_p from the default value of
8814 bidi-display-reordering, not from buffer-local value. Use the
8815 buffer-local value only if initializing for buffer iteration.
8816 (handle_invisible_prop): Support invisible properties on strings
8817 that are being bidi-reordered.
8818 (set_iterator_to_next): Support bidi reordering of C strings and
8820 (next_element_from_string): Support bidi reordering of Lisp
8822 (handle_stop_backwards): Support Lisp strings as well.
8823 (display_string): Support display of R2L glyph rows.
8824 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8825 (init_iterator): Don't initialize it->bidi_p for strings
8827 (reseat_to_string): Initialize it->bidi_p for strings here.
8828 (next_element_from_string, next_element_from_c_string)
8829 (next_element_from_buffer): Add xassert's for correspondence
8830 between IT's object being iterated and it->bidi_it.string
8832 (face_before_or_after_it_pos): Support bidi iteration.
8833 (next_element_from_c_string): Handle the case of the first string
8834 character that is not the first one in the visual order.
8835 (get_visually_first_element): New function, refactored from common
8836 parts of next_element_from_buffer, next_element_from_string, and
8837 next_element_from_c_string.
8838 (tool_bar_lines_needed, redisplay_tool_bar)
8839 (display_menu_bar): Force left-to-right direction. Add a FIXME
8840 comment for making that be controlled by a user option.
8841 (push_it, pop_it): Save and restore the state of the
8842 bidi iterator. Save and restore the bidi_p flag.
8843 (pop_it): Iterate out of display property for string iteration as
8845 (iterate_out_of_display_property): Support iteration over strings.
8846 (handle_single_display_spec): Set up it->bidi_it for iteration
8847 over a display string, and call bidi_init_it.
8848 (handle_single_display_spec, next_overlay_string)
8849 (get_overlay_strings_1, push_display_prop): Set up the bidi
8850 iterator for displaying display or overlay strings.
8851 (forward_to_next_line_start): Don't use the shortcut if
8853 (back_to_previous_visible_line_start): If handle_display_prop
8854 pushed the iterator stack, restore the internal state of the bidi
8855 iterator by calling bidi_pop_it same number of times.
8856 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8857 and we are bidi-iterating, don't decrement the iterator position;
8858 instead, set the first_elt flag in the bidi iterator, to produce
8860 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8861 (push_display_prop): xassert that we are iterating a buffer.
8862 (push_it, pop_it): Save and restore paragraph_embedding member.
8863 (handle_single_display_spec, next_overlay_string)
8864 (get_overlay_strings_1, reseat_1, reseat_to_string)
8865 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8866 correctly. Don't assume unibyte strings are not bidi-reordered.
8867 (compute_display_string_pos)
8868 (compute_display_string_end): Fix handling the case of C string.
8869 (push_it, pop_it): Save and restore from_disp_prop_p.
8870 (handle_single_display_spec, push_display_prop): Set the
8871 from_disp_prop_p flag.
8872 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8873 (pop_it): Call iterate_out_of_display_property only if we are
8874 popping after iteration over a string that came from a display
8875 property. Fix a typo in popping stretch info. Add an assertion
8876 for verifying that the iterator position is in sync with the bidi
8878 (handle_single_display_spec, get_overlay_strings_1)
8879 (push_display_prop): Fix initialization of paragraph direction for
8880 string when that of the parent object is not yet determined.
8881 (reseat_1): Call bidi_init_it to resync the bidi
8882 iterator with IT's position. (Bug#7616)
8883 (find_row_edges): If ROW->start.pos gives position
8884 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8885 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8886 Reset the from_disp_prop_p flag.
8887 (SAVE_IT, RESTORE_IT): New macros.
8888 (pos_visible_p, face_before_or_after_it_pos)
8889 (back_to_previous_visible_line_start)
8890 (move_it_in_display_line_to, move_it_in_display_line)
8891 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8892 (try_scrolling, redisplay_window, display_line): Use them when
8893 saving a temporary copy of the iterator and restoring it back.
8894 (back_to_previous_visible_line_start, reseat_1)
8895 (init_iterator): Empty the bidi cache "stack".
8896 (move_it_in_display_line_to): If iterator ended up at
8897 EOL, but we never saw any buffer positions smaller than
8898 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8899 motion in bidi-reordered lines.
8900 (move_it_in_display_line_to): Record prev_method and prev_pos
8901 immediately before the call to set_iterator_to_next. Fixes cursor
8902 motion in bidi-reordered lines with stretch glyphs and strings
8903 displayed in margins. (Bug#8133) (Bug#8867)
8904 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8906 (pos_visible_p): Support positions in bidi-reordered lines.
8907 Save and restore bidi cache.
8909 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8910 (bidi_paragraph_info): Delete unused struct.
8911 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8912 (bidi_cache_start): New variable.
8913 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8915 (bidi_cache_fetch_state, bidi_cache_search)
8916 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8917 (bidi_cache_find, bidi_peek_at_next_level)
8918 (bidi_level_of_next_char, bidi_find_other_level_edge)
8919 (bidi_move_to_visually_next): Compare cache index with
8920 bidi_cache_start rather than with zero.
8921 (bidi_fetch_char): Accept new argument STRING; all callers
8922 changed. Support iteration over a string. Support strings with
8923 display properties. Support unibyte strings. Fix the type of
8924 `len' according to what STRING_CHAR_AND_LENGTH expects.
8925 (bidi_paragraph_init, bidi_resolve_explicit_1)
8926 (bidi_resolve_explicit, bidi_resolve_weak)
8927 (bidi_level_of_next_char, bidi_move_to_visually_next):
8928 Support iteration over a string.
8929 (bidi_set_sor_type, bidi_resolve_explicit_1)
8930 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8931 can now be zero (for strings); special values 0 and -1 were
8932 changed to -1 and -2, respectively.
8933 (bidi_char_at_pos): New function.
8934 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8935 Call it instead of FETCH_MULTIBYTE_CHAR.
8936 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8937 initialized to valid values.
8938 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8940 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8941 the test for valid cached positions. Fix the logic for looking up
8942 the sentinel state in the cache. GCPRO the Lisp string we are
8944 (bidi_push_it, bidi_pop_it): New functions.
8945 (bidi_initialize): Initialize the bidi cache start stack pointer.
8946 (bidi_cache_ensure_space): New function, refactored from part of
8947 bidi_cache_iterator_state. Don't assume the required size is just
8948 one BIDI_CACHE_CHUNK away.
8949 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8950 (bidi_count_bytes, bidi_char_at_pos): New functions.
8951 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8952 always valid if bidi_cache_idx is valid.
8953 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8954 is valid if it's going to be used.
8955 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8956 (bidi_cache_fetch_state, bidi_cache_search)
8957 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8958 (bidi_cache_iterator_state, bidi_cache_find)
8959 (bidi_find_other_level_edge, bidi_cache_start_stack):
8960 All variables related to cache indices are now EMACS_INT.
8962 * dispextern.h (struct bidi_string_data): New structure.
8963 (struct bidi_it): New member `string'. Make flag members be 1-bit
8964 fields, and put them last in the struct.
8965 (compute_display_string_pos, compute_display_string_end):
8967 (bidi_push_it, bidi_pop_it): Add prototypes.
8968 (struct iterator_stack_entry): New members bidi_p,
8969 paragraph_embedding, and from_disp_prop_p.
8970 (struct it): Member bidi_p is now a bit field 1 bit wide.
8971 (bidi_shelve_cache, bidi_unshelve_cache):
8974 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8975 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8976 and vector-like objects.
8978 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8979 cache around display iteration.
8981 * window.c (Fwindow_end, window_scroll_pixel_based)
8982 (displayed_window_lines, Frecenter): Save and restore the bidi
8983 cache around display iteration.
8985 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8987 * editfns.c (Fdelete_region): Clarify the use of the named
8988 parameters (bug#6788).
8990 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8992 * indent.c (Fvertical_motion): Set and restore w->pointm when
8993 saving and restoring the window's buffer (Bug#9006).
8995 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8997 * editfns.c (Fstring_to_char): Clarify just what is returned
8998 (bug#6576). Text by Eli Zaretskii.
9000 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
9002 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9004 2011-07-13 Eli Zaretskii <eliz@gnu.org>
9006 * buffer.c (mmap_find): Fix a typo.
9008 2011-07-13 Johan Bockgård <bojohan@gnu.org>
9010 Fix execution of x selection hooks.
9011 * xselect.c (Qx_lost_selection_functions)
9012 (Qx_sent_selection_functions): New vars.
9013 (syms_of_xselect): DEFSYM them.
9014 (x_handle_selection_request): Pass Qx_sent_selection_functions
9015 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9016 (x_handle_selection_clear,x_clear_frame_selections):
9017 Pass Qx_lost_selection_functions rather than
9018 Vx_lost_selection_functions to Frun_hook_with_args.
9020 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9022 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
9023 The old code sometimes used this field without initializing it.
9025 * alloc.c (gc_sweep): Don't read past end of array.
9026 In theory, the old code could also have corrupted Emacs internals,
9027 though it'd be very unlikely.
9029 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9031 * character.c (Fcharacterp): Don't advertise optional ignored
9032 argument. (Bug#4026)
9034 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9036 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9039 * window.c (Fset_window_start): Doc fix (bug#4199).
9040 (Fset_window_hscroll): Ditto.
9042 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9044 Fix minor new problems caught by GCC 4.6.1.
9045 * term.c (init_tty): Remove unused local.
9046 * xsettings.c (store_monospaced_changed): Define this function only
9047 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
9050 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
9052 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9054 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9056 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9057 are the mini-buffer and the echo area (bug#3320).
9059 * term.c (init_tty): Remove support for supdup, c10 and perq
9060 terminals, which are no longer supported (bug#1482).
9062 2011-07-10 Johan Bockgård <bojohan@gnu.org>
9064 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9066 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9068 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9069 for non-popups (Bug#3642).
9071 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9073 * alloc.c (reset_malloc_hooks): Protoize.
9074 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
9075 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9076 * cm.c (losecursor): Likewise.
9077 * data.c (fmod): Likewise.
9078 * dispnew.c (swap_glyphs_in_rows): Likewise.
9079 * emacs.c (memory_warning_signal): Likewise.
9080 * floatfns.c (float_error): Likewise.
9081 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9082 (otf_open, font_otf_capability, generate_otf_features)
9083 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9085 * image.c (pbm_read_file): Likewise.
9086 * indent.c (string_display_width): Likewise.
9087 * intervals.c (check_for_interval, search_for_interval)
9088 (inc_interval_count, count_intervals, root_interval)
9089 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9090 * lread.c (defalias): Likewise.
9091 * ralloc.c (r_alloc_check): Likewise.
9092 * regex.c (set_image_of_range_1, set_image_of_range)
9093 (regex_grow_registers): Likewise.
9094 * sysdep.c (strerror): Likewise.
9095 * termcap.c (valid_filename_p, tprint, main): Likewise.
9096 * tparam.c (main): Likewise.
9097 * unexhp9k800.c (run_time_remap, save_data_space)
9098 (update_file_ptrs, read_header, write_header, calculate_checksum)
9099 (copy_file, copy_rest, display_header): Likewise.
9100 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9102 * xdisp.c (check_it): Likewise.
9103 * xfaces.c (register_color, unregister_color, unregister_colors):
9105 * xfns.c (print_fontset_result): Likewise.
9106 * xrdb.c (member, fatal, main): Likewise.
9108 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9110 Fix minor problems found by static checking (Bug#9031).
9111 * chartab.c (char_table_set_range, map_sub_char_table):
9112 Remove unused locals.
9113 (uniprop_table): Now static.
9114 * composite.c (_work_char): Remove unused static var.
9116 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
9118 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9120 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9122 * gtkutil.c (qttip_cb): Remove code without function.
9124 2011-07-09 Eli Zaretskii <eliz@gnu.org>
9126 * w32.c (pthread_sigmask): New stub.
9128 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
9130 Use pthread_sigmask, not sigprocmask (Bug#9010).
9131 sigprocmask is portable only for single-threaded applications, and
9132 Emacs can be multi-threaded when it uses GTK.
9133 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9135 * callproc.c (Fcall_process):
9136 * process.c (create_process):
9137 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9138 Use pthread_sigmask, not sigprocmask.
9140 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9142 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9143 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9146 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9148 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9149 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9150 (xg_hide_tooltip): Fix comment.
9152 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9153 in registerServicesMenuSendTypes.
9154 (validRequestorForSendType): Don't check ns_return_types.
9156 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9159 2011-07-08 Jason Rumney <jasonr@gnu.org>
9161 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9162 SH_SHOW for hidden windows (Bug#5482).
9164 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9165 frame struct members of non-existent frames (Bug#6284).
9167 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9169 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9170 variable firstTime not needed on OSX >= 10.6.
9171 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9172 >= 10.5. Use setKnobProportion, setDoubleValue.
9174 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9175 (MAC_OS_X_VERSION_10_5): Define if not defined.
9176 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9177 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9178 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9180 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9181 cString and lossyCString on OSX >= 10.4.
9183 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9184 sizeToFit on OSX >= 10.2.
9186 * nsimage.m (allocInitFromFile): Don't use deprecated method
9187 bestRepresentationForDevice on OSX >= 10.6.
9189 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9192 * emacs.c: Declare unexec_init_emacs_zone.
9194 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9196 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9198 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9199 on svcsMenu (Bug#8842).
9201 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9203 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9205 * nsterm.m (QUTF8_STRING): Declare.
9206 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9207 (validRequestorForSendType): Return type is (id).
9208 Change indexOfObjectIdenticalTo to indexOfObject.
9209 Check if we have local selection before returning self (Bug#8842).
9210 (writeSelectionToPasteboard): Put local selection into paste board
9211 if we have a local selection (Bug#8842).
9212 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9214 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9215 (ns_get_local_selection): Declare.
9217 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9219 * keymap.c (describe_map_tree): Don't insert a double newline at
9220 the end of the buffer (bug#1169) and return whether we inserted
9223 * callint.c (Fcall_interactively): Change "reading args" to
9224 "providing args" to try to clarify what it does (bug#1010).
9226 2011-07-07 Kenichi Handa <handa@m17n.org>
9228 * composite.c (composition_compute_stop_pos): Ignore a static
9229 composition starting before CHARPOS (Bug#8915).
9231 * xdisp.c (handle_composition_prop): Likewise.
9233 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9235 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9238 2011-07-07 Kenichi Handa <handa@m17n.org>
9240 * character.h (unicode_category_t): New enum type.
9242 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9243 (Qchar_code_property_table): New variable.
9244 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9245 (UNIPROP_COMPRESSED_FORM_P): New macros.
9246 (char_table_ascii): Uncompress the compressed values.
9247 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9248 Uncompress the compressed values.
9249 (sub_char_table_ref_and_range): Likewise.
9250 (char_table_ref_and_range): Uncompress the compressed values.
9251 (sub_char_table_set): New arg is_uniprop. Callers changed.
9252 Uncompress the compressed values.
9253 (sub_char_table_set_range): Args changed. Callers changed.
9254 (char_table_set_range): Adjuted for the above change.
9255 (map_sub_char_table): Delete args default_val and parent. Add arg
9256 top. Give decoded values to a Lisp function.
9257 (map_char_table): Adjust for the above change. Give decoded
9258 values to a Lisp function. Gcpro more variables.
9259 (uniprop_table_uncompress)
9260 (uniprop_decode_value_run_length): New functions.
9261 (uniprop_decoder, uniprop_decoder_count): New variables.
9262 (uniprop_get_decoder, uniprop_encode_value_character)
9263 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9265 (uniprop_encoder, uniprop_encoder_count): New variables.
9266 (uniprop_get_encoder, uniprop_table)
9267 (Funicode_property_table_internal, Fget_unicode_property_internal)
9268 (Fput_unicode_property_internal): New functions.
9269 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9270 Sunicode_property_table_internal, Sget_unicode_property_internal,
9271 and Sput_unicode_property_internal. Defvar_lisp
9272 char-code-property-alist.
9274 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9275 Vunicode_category_table.
9277 * font.c (font_range): Adjust for the change of
9278 Vunicode_category_table.
9280 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9282 * m/iris4d.h: Remove file, move contents ...
9283 * s/irix6-5.h: ... here.
9285 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9287 Remove unportable assumption about struct layout (Bug#8884).
9288 * alloc.c (mark_buffer):
9289 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9290 (clone_per_buffer_values): Don't assume that
9291 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9292 This isn't true in general, and it's particularly not true
9293 if Emacs is configured with --with-wide-int.
9294 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9295 New macros, used in the buffer.c change.
9297 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9299 * xsettings.c: Use both GConf and GSettings if both are available.
9300 (store_config_changed_event): Add comment.
9301 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9302 (store_tool_bar_style_changed): New functions.
9303 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9304 (struct xsettings): Move font inside HAVE_XFT.
9305 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9306 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9307 Move inside HAVE_XFT.
9308 (something_changed_gsettingsCB): Rename from something_changedCB.
9309 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9311 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9312 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9313 (something_changed_gconfCB): Rename from something_changedCB.
9314 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9315 (parse_settings): Move check for font inside HAVE_XFT.
9316 (read_settings, apply_xft_settings): Add comment.
9317 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9318 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9319 call store_font_name_changed.
9320 (xft_settings_event): Add comment.
9321 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9322 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9323 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9324 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9325 (xsettings_initialize): Call init_gsettings last.
9326 (xsettings_get_system_font, xsettings_get_system_normal_font):
9329 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9331 Random fixes. E.g., (random) never returned negative values.
9332 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9333 subseconds part to the entropy, as that's a bit more random.
9334 Prefer signed to unsigned, since the signedness doesn't matter and
9335 in general we prefer signed. When given a limit, use a
9336 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9337 latter isn't right if USE_2_TAGS_FOR_INTS.
9338 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9339 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9341 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9343 * textprop.c (text_property_stickiness):
9344 Obey Vtext_property_default_nonsticky.
9345 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9346 * w32fns.c (syms_of_w32fns):
9347 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9349 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9351 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9352 This is more efficient than Ffile_directory_p and avoids a minor race.
9354 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9356 * buffer.c (Foverlay_put): Say what the return value is
9359 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9360 is a directory before asking whether to use the file name
9362 (barf_or_query_if_file_exists): Make the "File is a directory"
9363 error be more correct.
9365 * fns.c (Frequire): Remove the mention of the .gz files, since
9366 that's installation-specific, but keep the mention of
9367 `get-load-suffixes'.
9369 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9371 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9372 Report string overflow if the output is too long.
9374 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9376 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9377 (syms_of_gnutls): Remove duplicate DEFSYM for
9378 Qgnutls_bootprop_verify_hostname_error, an error for
9379 Qgnutls_bootprop_verify_error (which is no longer used).
9381 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9382 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9383 Also (re)move comments that are misplaced or no longer relevant.
9385 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9387 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9389 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9391 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9392 and background color parameters if they have been changed.
9394 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9396 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9398 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9400 * xsettings.c (SYSTEM_FONT): Define only when used.
9401 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9403 * keymap.c (access_keymap_1): Now static.
9405 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9407 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9408 leave any prefix arg for the up event (Bug#1586).
9410 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9412 * lread.c (syms_of_lread): Mention single symbols defined by
9413 `defvar' or `defconst' (bug#7154).
9415 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9416 (Frequire): Mention get-load-suffixes.
9418 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9420 * window.h (window): Remove clone_number slot.
9421 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9423 (make_parent_window, make_window, saved_window)
9424 (Fset_window_configuration, save_window_save): Don't deal with
9426 * buffer.c (Qclone_number): Remove declaration.
9427 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9429 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9431 Add multiple inheritance to keymaps.
9432 * keymap.c (Fmake_composed_keymap): New function.
9433 (Fset_keymap_parent): Simplify.
9434 (fix_submap_inheritance): Remove.
9435 (access_keymap_1): New function extracted from access_keymap to handle
9436 embedded parents and handle lists of maps.
9437 (access_keymap): Use it.
9438 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9439 (Fcopy_keymap): Handle embedded parents.
9440 (Fcommand_remapping, define_as_prefix): Simplify.
9441 (Fkey_binding): Simplify.
9442 (syms_of_keymap): Move minibuffer-local-completion-map,
9443 minibuffer-local-filename-completion-map,
9444 minibuffer-local-must-match-map, and
9445 minibuffer-local-filename-must-match-map to Elisp.
9446 (syms_of_keymap): Defsubr make-composed-keymap.
9447 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9448 (parse_menu_item): Trivial simplification.
9450 2011-07-01 Glenn Morris <rgm@gnu.org>
9452 * Makefile.in (SETTINGS_LIBS): Fix typo.
9454 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9456 * coding.c (Fencode_coding_string): Record the last coding system
9457 used, as the function doc string says (bug#8738).
9459 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9461 * xsettings.c (store_monospaced_changed): Take new font as arg and
9462 check for change against current_mono_font.
9463 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9464 (emacs_settings_constructor, emacs_settings_get_property)
9465 (emacs_settings_set_property, emacs_settings_class_init)
9466 (emacs_settings_init, gsettings_obj): Remove.
9467 (something_changedCB): New function for HAVE_GSETTINGS.
9468 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9469 with value as argument.
9470 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9471 g_settings_new (Bug#8967). Do not create gsettings_obj.
9472 Remove calls to g_settings_bind. Connect something_changedCB to
9475 * xgselect.c: Add defined (HAVE_GSETTINGS).
9476 (xgselect_initialize): Ditto.
9478 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9479 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9482 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9484 * eval.c (struct backtrace): Simplify and port the data structure.
9485 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9486 signed bit field, as this assumption is not portable and it makes
9487 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9488 "char debug_on_exit : 1" as this is not portable either; instead,
9489 use the portable "unsigned int debug_on_exit : 1". Remove unused
9490 member evalargs. Remove obsolete comments about cc bombing out.
9492 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9494 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9495 Let HAVE_GSETTINGS override HAVE_GCONF.
9496 (store_monospaced_changed): New function.
9497 (EMACS_SETTINGS): A new type derived from GObject to handle
9498 GSettings notifications.
9499 (emacs_settings_constructor, emacs_settings_get_property)
9500 (emacs_settings_set_property, emacs_settings_class_init):
9502 (gsettings_client, gsettings_obj): New variables.
9503 (GSETTINGS_SCHEMA): New define.
9504 (something_changedCB): Call store_monospaced_changed.
9505 (init_gsettings): New function.
9506 (xsettings_initialize): Call init_gsettings.
9507 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9510 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9513 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9515 * window.c (resize_root_window, grow_mini_window)
9516 (shrink_mini_window): Rename Qresize_root_window to
9517 Qwindow_resize_root_window and Qresize_root_window_vertically to
9518 Qwindow_resize_root_window_vertically.
9520 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9522 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9524 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9526 * makefile.w32-in: Redesign dependencies so they reflect more
9527 clearly which files are directly included by each source file,
9528 and not through other includes.
9530 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9532 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9533 (sort_overlays, overlay_strings): When an overlay's clone number
9534 matches the window's clone number process the overlay even if
9535 the overlay's window property doesn't match the current window.
9537 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9538 (Fwindow_hchild): Rename to Fwindow_left_child.
9539 (Fwindow_next): Rename to Fwindow_next_sibling.
9540 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9541 (resize_window_check): Rename to window_resize_check.
9542 (resize_window_apply): Rename to window_resize_apply.
9543 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9544 (Fdelete_other_windows_internal, resize_frame_windows)
9545 (Fsplit_window_internal, Fdelete_window_internal)
9546 (grow_mini_window, shrink_mini_window)
9547 (Fresize_mini_window_internal): Fix callers accordingly.
9549 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9551 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9552 (emacs_fixed_set_min_size): Remove.
9553 (emacs_fixed_new): Take frame as argument.
9555 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9556 (_EmacsFixedPrivate): Remove minwidth/height.
9557 Add struct frame *f.
9558 (emacs_fixed_init): Initialize priv->f.
9559 (get_parent_class, emacs_fixed_set_min_size): Remove.
9560 (emacs_fixed_new): Set priv->f to argument.
9561 (emacs_fixed_get_preferred_width)
9562 (emacs_fixed_get_preferred_height): Use min_width/height from
9563 frames size_hint to set minimum and natural (Bug#8919).
9564 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9565 and use min_width/height from frames size_hint to set
9566 min_width/height (Bug#8919).
9568 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9569 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9572 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9574 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9575 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9578 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9580 * process.c (wait_reading_process_output): Bypass select if
9581 waiting for a cell while ignoring keyboard input, and input is
9582 pending. Suggested by Jan Djärv (Bug#8869).
9584 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9586 Use gnulib's dup2 module instead of rolling our own.
9587 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9589 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9591 * dispnew.c (scrolling_window): Before scrolling, turn off a
9592 mouse-highlight in the window being scrolled.
9594 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9596 Move DEFSYM to lisp.h and use everywhere.
9598 * character.h (DEFSYM): Move declaration...
9599 * lisp.h (DEFSYM): ...here.
9605 * w32select.c: Don't include character.h.
9607 * alloc.c (syms_of_alloc):
9608 * buffer.c (syms_of_buffer):
9609 * bytecode.c (syms_of_bytecode):
9610 * callint.c (syms_of_callint):
9611 * casefiddle.c (syms_of_casefiddle):
9612 * casetab.c (init_casetab_once):
9613 * category.c (init_category_once, syms_of_category):
9614 * ccl.c (syms_of_ccl):
9615 * cmds.c (syms_of_cmds):
9616 * composite.c (syms_of_composite):
9617 * dbusbind.c (syms_of_dbusbind):
9618 * dired.c (syms_of_dired):
9619 * dispnew.c (syms_of_display):
9620 * doc.c (syms_of_doc):
9621 * editfns.c (syms_of_editfns):
9622 * emacs.c (syms_of_emacs):
9623 * eval.c (syms_of_eval):
9624 * fileio.c (syms_of_fileio):
9625 * fns.c (syms_of_fns):
9626 * frame.c (syms_of_frame):
9627 * fringe.c (syms_of_fringe):
9628 * insdel.c (syms_of_insdel):
9629 * keymap.c (syms_of_keymap):
9630 * lread.c (init_obarray, syms_of_lread):
9631 * macros.c (syms_of_macros):
9632 * msdos.c (syms_of_msdos):
9633 * print.c (syms_of_print):
9634 * process.c (syms_of_process):
9635 * search.c (syms_of_search):
9636 * sound.c (syms_of_sound):
9637 * syntax.c (init_syntax_once, syms_of_syntax):
9638 * terminal.c (syms_of_terminal):
9639 * textprop.c (syms_of_textprop):
9640 * undo.c (syms_of_undo):
9641 * w32.c (globals_of_w32):
9642 * window.c (syms_of_window):
9643 * xdisp.c (syms_of_xdisp):
9644 * xfaces.c (syms_of_xfaces):
9645 * xfns.c (syms_of_xfns):
9646 * xmenu.c (syms_of_xmenu):
9647 * xsettings.c (syms_of_xsettings):
9648 * xterm.c (syms_of_xterm): Use DEFSYM.
9650 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9652 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9654 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9656 Integer and buffer overflow fixes (Bug#8873).
9658 * print.c (printchar, strout): Check for string overflow.
9659 (PRINTPREPARE, printchar, strout):
9660 Don't set size unless allocation succeeds.
9662 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9663 for sizes. Check for string overflow more accurately.
9664 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9666 * macros.c: Integer and buffer overflow fixes.
9667 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9668 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9669 Use ptrdiff_t, not int, for sizes.
9670 Don't increment bufsize until after realloc succeeds.
9671 Check for size-calculation overflow.
9672 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9674 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9676 * lread.c: Integer overflow fixes.
9677 (read_integer): Radix is now EMACS_INT, not int,
9678 to improve quality of diagnostics for out-of-range radices.
9679 Calculate buffer size correctly for out-of-range radices.
9680 (read1): Check for integer overflow in radices, and in
9681 read-circle numbers.
9682 (read_escape): Avoid int overflow.
9683 (Fload, openp, read_buffer_size, read1)
9684 (substitute_object_recurse, read_vector, read_list, map_obarray):
9685 Use ptrdiff_t, not int, for sizes.
9686 (read1): Use EMACS_INT, not int, for sizes.
9687 Check for size overflow.
9689 * image.c (cache_image): Check for size arithmetic overflow.
9691 * lread.c: Integer overflow issues.
9692 (saved_doc_string_size, saved_doc_string_length)
9693 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9694 Now ptrdiff_t, not int.
9695 (read1): Don't assume doc string length fits in int. Check for
9696 out-of-range doc string lengths.
9697 (read_list): Don't assume file position fits in int.
9698 (read_escape): Check for hex character overflow.
9700 2011-06-22 Leo Liu <sdl.web@gmail.com>
9702 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9703 Move to minibuffer.el.
9705 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9707 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9708 The following patches are for when GLYPH_DEBUG && !XASSERT.
9709 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9710 * dispnew.c (flush_stdout):
9711 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9712 Mark as externally visible.
9713 * dispnew.c (check_window_matrix_pointers): Now static.
9714 * dispnew.c (window_to_frame_vpos):
9715 * xfns.c (unwind_create_frame):
9716 * xterm.c (x_check_font): Remove unused local.
9717 * scroll.c (CHECK_BOUNDS):
9718 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9719 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9720 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9721 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9722 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9724 (debug_method_add): Use va_list and vsprintf rather than relying
9725 on undefined behavior with wrong number of arguments.
9726 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9727 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9728 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9729 since we're not interested in debugging glyphs with old libraries.
9730 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9731 GCC 4.6.0's static checking.
9733 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9735 Integer overflow and signedness fixes (Bug#8873).
9736 A few related buffer overrun fixes, too.
9738 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9740 * dispextern.h (struct face.stipple):
9741 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9742 (x_bitmap_mask, x_allocate_bitmap_record)
9743 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9744 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9745 (x_create_bitmap_from_xpm_data):
9746 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9747 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9749 * xfaces.c (load_pixmap):
9750 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9751 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9752 (.bitmaps_last, struct x_output.icon_bitmap):
9753 Use ptrdiff_t, not int, for bitmap indexes.
9754 (x_allocate_bitmap_record): Check for size overflow.
9755 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9757 Use ptrdiff_t, not int, for overlay counts.
9758 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9759 * editfns.c (overlays_around, get_pos_property):
9760 * textprop.c (get_char_property_and_overlay):
9761 * xdisp.c (next_overlay_change, note_mouse_highlight):
9762 * xfaces.c (face_at_buffer_position):
9763 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9764 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9765 (Fnext_overlay_change, Fprevious_overlay_change)
9766 (mouse_face_overlay_overlaps, Foverlays_in):
9767 Use ptrdiff_t, not int, for sizes.
9768 (overlays_at, overlays_in): Check for size-calculation overflow.
9770 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9772 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9773 (x_session_initialize): Do not assume string length fits in int.
9775 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9776 This is unlikely, but can occur if DPI is outlandish.
9778 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9779 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9781 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9782 * xrdb.c (magic_file_p, search_magic_path):
9783 Omit last arg SUFFIX; it was always 0. All callers changed.
9784 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9786 * xfont.c (xfont_match): Avoid need for strlen.
9788 * xfns.c: Don't assume strlen fits in int.
9789 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9791 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9792 not unsigned long, as we prefer signed integers. All callers changed.
9793 Detect integer overflow in repeat count.
9794 (message_dolog): Don't assume print length fits in 39 bytes.
9795 (display_mode_element): Don't assume strlen fits in int.
9797 * termcap.c: Don't assume sizes fit in int and never overflow.
9798 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9799 (gobble_line): Check for size-calculation overflow.
9801 * minibuf.c (Fread_buffer):
9802 * lread.c (intern, intern_c_string):
9803 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9804 Don't assume string length fits in int.
9806 * keyboard.c (parse_tool_bar_item):
9807 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9809 * font.c: Don't assume string length fits in int.
9810 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9811 Use ptrdiff_t, not int.
9812 (font_intern_prop): Don't assume string length fits in int.
9813 Don't assume integer property fits in fixnum.
9814 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9816 * filelock.c: Fix some buffer overrun and integer overflow issues.
9817 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9818 Reformulate so as not to need the command string.
9819 Invoke gzip -cd rather than gunzip, as it's more portable.
9820 (lock_info_type, lock_file_1, lock_file):
9821 Don't assume pid_t and time_t fit in unsigned long.
9822 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9823 (current_lock_owner): Prefer signed type for sizes.
9824 Use memcpy, not strncpy, where memcpy is what is really wanted.
9825 Don't assume (via atoi) that time_t and pid_t fit in int.
9826 Check for time_t and/or pid_t out of range, e.g., via a network share.
9827 Don't alloca where an auto var works fine.
9829 * fileio.c: Fix some integer overflow issues.
9830 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9831 Don't assume string length fits in int.
9832 (directory_file_name): Don't assume string length fits in long.
9833 (make_temp_name): Don't assume pid fits in int, or that its print
9834 length is less than 20.
9836 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9838 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9840 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9842 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9843 We prefer signed integers, even for size calculations.
9845 * emacs.c: Don't assume string length fits in 'int'.
9846 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9847 (main): Don't invoke strlen when not needed.
9849 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9850 (XD_DEBUG_MESSAGE): Don't waste a byte.
9852 * callproc.c (getenv_internal_1, getenv_internal)
9854 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9856 * lread.c (invalid_syntax): Omit length argument.
9857 All uses changed. This doesn't fix a bug, but it simplifies the
9858 code away from its former Hollerith-constant appearance, and it's
9859 one less 'int' to worry about when looking at integer-overflow issues.
9860 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9862 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9863 This didn't break anything, but it didn't help either.
9864 It's confusing to put a bogus integer in a place where the actual
9865 value does not matter.
9866 (LIST_END_P): Remove unused macro and its bogus comment.
9867 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9869 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9870 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9872 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9873 We prefer signed types, and the value cannot exceed the EMACS_INT
9874 range anyway (because otherwise the length would not be representable).
9875 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9876 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9877 This avoids a GCC warning when WIDE_EMACS_INT.
9879 * indent.c (sane_tab_width): New function.
9880 (current_column, scan_for_column, Findent_to, position_indentation)
9881 (compute_motion): Use it. This is just for clarity.
9882 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9884 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9886 * lisp.h (lint_assume): New macro.
9887 * composite.c (composition_gstring_put_cache):
9888 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9890 * editfns.c, insdel.c:
9891 Omit unnecessary forward decls, to simplify future changes.
9893 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9895 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9897 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9898 Use much-faster test for byte-length change.
9899 Don't assume string byte-length fits in 'int'.
9900 Check that character arg fits in 'int'.
9901 (mapcar1): Declare byte as byte, for clarity.
9903 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9905 * fns.c (concat): Catch string overflow earlier.
9906 Do not rely on integer wraparound.
9908 * dispextern.h (struct it.overlay_strings_charpos)
9909 (struct it.selective): Now EMACS_INT, not int.
9910 * xdisp.c (forward_to_next_line_start)
9911 (back_to_previous_visible_line_start)
9912 (reseat_at_next_visible_line_start, next_element_from_buffer):
9913 Don't arbitrarily truncate the value of 'selective' to int.
9915 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9917 * composite.c: Don't truncate sizes to 'int'.
9918 (composition_gstring_p, composition_reseat_it)
9919 (composition_adjust_point): Use EMACS_INT, not int.
9920 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9921 not EMACS_UINT, for indexes.
9923 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9925 * buffer.c: Include <verify.h>.
9926 (struct sortvec.priority, struct sortstr.priority):
9927 Now EMACS_INT, not int.
9928 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9929 (struct sortstr.size, record_overlay_string)
9930 (struct sortstrlist.size, struct sortlist.used):
9931 Don't truncate size to int.
9932 (record_overlay_string): Check for size-calculation overflow.
9933 (init_buffer_once): Check at compile-time, not run-time.
9935 2011-06-22 Jim Meyering <meyering@redhat.com>
9937 Don't leak an XBM-image-sized buffer
9938 * image.c (xbm_load): Free the image buffer after using it.
9940 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9943 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9944 that Sun C diagnosed.
9945 * fns.c (secure_hash): Fix pointer signedness issue.
9946 * intervals.c (static_offset_intervals): New function.
9947 (offset_intervals): Use it.
9949 2011-06-21 Leo Liu <sdl.web@gmail.com>
9952 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9955 * fns.c (secure_hash): Rename from crypto_hash_function and change
9956 the first arg to accept symbols.
9957 (Fsecure_hash): New primitive.
9958 (syms_of_fns): New symbols.
9960 2011-06-20 Deniz Dogan <deniz@dogan.se>
9962 * process.c (Fset_process_buffer): Clarify return value in
9965 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9967 * dispnew.c (add_window_display_history): Use BVAR.
9969 * xdisp.c (debug_method_add): Use BVAR.
9970 (check_window_end, dump_glyph_matrix, dump_glyph)
9971 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9973 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9976 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9977 check till after the cache is created in init_frame_faces.
9979 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9981 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9983 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9985 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9986 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9987 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9989 Improve buffer-overflow checking (Bug#8873).
9990 * fileio.c (Finsert_file_contents):
9991 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9992 Remove the old (too-loose) buffer overflow checks.
9993 They weren't needed, since make_gap checks for buffer overflow.
9994 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9995 The old code merely checked for Emacs fixnum overflow, and relied
9996 on undefined (wraparound) behavior. The new code avoids undefined
9997 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9999 * editfns.c (Finsert_char): Don't dump core with very negative counts.
10000 Tune. Don't use wider integers than needed. Don't use alloca.
10001 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
10003 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10005 * insdel.c, lisp.h (buffer_overflow): New function.
10006 (insert_from_buffer_1, replace_range, replace_range_2):
10007 * insdel.c (make_gap_larger):
10008 * editfns.c (Finsert_char):
10009 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10011 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10013 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10015 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
10017 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10018 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10020 * fileio.c: Don't assume EMACS_INT fits in off_t.
10021 (emacs_lseek): New static function.
10022 (Finsert_file_contents, Fwrite_region): Use it.
10023 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10025 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10027 * fns.c: Don't overflow int when computing a list length.
10028 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10029 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10030 truncation on 64-bit hosts. Check for QUIT every
10031 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10032 faster and is responsive enough.
10033 (Flength): Report an error instead of overflowing an integer.
10034 (Fsafe_length): Return a float if the value is not representable
10035 as a fixnum. This shouldn't happen except in contrived situations.
10036 (Fnthcdr, Fsort): Don't assume list length fits in int.
10037 (Fcopy_sequence): Don't assume vector length fits in int.
10039 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10040 (header_size, word_size): New constants.
10041 (allocate_vectorlike): Don't check size overflow here.
10042 (allocate_vector): Check it here instead, since this is the only
10043 caller of allocate_vectorlike that could cause overflow.
10044 Check that the new vector's length is representable as a fixnum.
10046 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10047 The previous code was bogus. For example, next_almost_prime (32)
10048 returned 39, which is undesirable as it is a multiple of 3; and
10049 next_almost_prime (24) returned 25, which is a multiple of 5 so
10050 why was the code bothering to check for multiples of 7?
10052 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10054 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10056 Variadic C functions now count arguments with ptrdiff_t.
10057 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10058 Back then I didn't know that the Emacs coding style prefers signed int.
10059 Also, in the meantime I found a few more instances where arguments
10060 were being counted with int, which may truncate counts on 64-bit
10061 machines, or EMACS_INT, which may be unnecessarily wide.
10062 * lisp.h (struct Lisp_Subr.function.aMANY)
10063 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10064 Arg counts are now ptrdiff_t, not size_t.
10065 All variadic functions and their callers changed accordingly.
10066 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10067 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10068 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10069 * callint.c (Fcall_interactively): Check arg count for overflow,
10070 to avoid potential buffer overrun. Use signed char, not 'int',
10071 for 'varies' array, so that we needn't bother to check its size
10072 calculation for overflow.
10073 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10074 * eval.c (apply_lambda):
10075 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10076 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10077 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10079 * callint.c (Fcall_interactively): Don't use index var as event count.
10081 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10082 * mem-limits.h (SIZE): Remove; no longer used.
10084 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
10086 Remove unnecessary casts.
10087 * xterm.c (x_term_init):
10088 * xfns.c (x_set_border_pixel):
10089 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10090 These aren't needed now that we assume ANSI C.
10092 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10093 It's more likely to cause problems (due to unsigned overflow)
10096 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10098 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10100 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10102 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10104 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10106 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10108 GLYPH_CODE_FACE returns EMACS_INT, not int.
10109 * dispextern.h (merge_faces):
10110 * xfaces.c (merge_faces):
10111 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10112 Don't assume EMACS_INT fits in int.
10114 * character.h (CHAR_VALID_P): Remove unused parameter.
10115 * fontset.c, lisp.h, xdisp.c: All uses changed.
10117 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10119 * fns.c (concat): Minor tuning based on overflow analysis.
10120 This doesn't fix any bugs. Use int to hold character, instead
10121 of constantly refetching from Emacs object. Use XFASTINT, not
10122 XINT, for value known to be a character. Don't bother comparing
10123 a single byte to 0400, as it's always less.
10125 * floatfns.c (Fexpt):
10126 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10128 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10131 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10133 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10134 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10135 incorrectly succeed when S was a string, because 4294967386 was
10136 truncated before it was used.
10138 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10139 Otherwise, an out-of-range integer could cause undefined behavior
10142 * composite.c: Use int, not EMACS_INT, for characters.
10143 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10144 EMACS_INT, for values that are known to be in character range.
10145 This doesn't fix any bugs but is the usual style inside Emacs and
10146 may generate better code on 32-bit machines.
10148 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10149 This is for reasons similar to the recent CHAR_STRING fix.
10150 * charset.c (Fencode_char): Check that character arg is actually
10151 a character. Pass an int to ENCODE_CHAR.
10152 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10153 wider than 'int', as a compile-time check to prevent future regressions
10156 * character.c (char_string): Remove unnecessary casts.
10158 Make sure a 64-bit char is never passed to CHAR_STRING.
10159 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10160 by silently ignoring the top 32 bits, allowing some values
10161 that were far too large to be valid characters.
10162 * character.h: Include <verify.h>.
10163 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10164 arguments are no wider than unsigned, as a compile-time check
10165 to prevent future regressions in this area.
10167 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10168 (Fsubst_char_in_region):
10170 * xdisp.c (decode_mode_spec_coding):
10171 Adjust to CHAR_STRING's new requirement.
10172 * editfns.c (Finsert_char, Fsubst_char_in_region):
10173 * fns.c (concat): Check that character args are actually
10174 characters. Without this test, these functions did the wrong
10175 thing with wildly out-of-range values on 64-bit hosts.
10177 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10178 These casts should not be needed on 32-bit hosts, either.
10179 * keyboard.c (read_char):
10180 * lread.c (Fload): Remove casts to unsigned.
10182 * lisp.h (UNSIGNED_CMP): New macro.
10183 This fixes comparison bugs on 64-bit hosts.
10184 (ASCII_CHAR_P): Use it.
10185 * casefiddle.c (casify_object):
10186 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10187 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10188 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10189 * dispextern.h (FACE_FROM_ID):
10190 * keyboard.c (read_char): Use UNSIGNED_CMP.
10192 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10193 not to EMACS_INT, to avoid GCC warning.
10195 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10197 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10198 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10199 isn't needed on 32-bit machines.
10201 * buffer.c (Fgenerate_new_buffer_name):
10202 Use EMACS_INT for count, not int.
10203 (advance_to_char_boundary): Return EMACS_INT, not int.
10205 * data.c (Qcompiled_function): Now static.
10207 * window.c (window_body_lines): Now static.
10209 * image.c (gif_load): Rename local to avoid shadowing.
10211 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10212 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10213 * alloc.c (make_save_value): Integer argument is now of type
10214 ptrdiff_t, not int.
10215 (mark_object): Use ptrdiff_t, not int.
10216 * lisp.h (pD): New macro.
10217 * print.c (print_object): Use it.
10219 * alloc.c: Use EMACS_INT, not int, to count objects.
10220 (total_conses, total_markers, total_symbols, total_vector_size)
10221 (total_free_conses, total_free_markers, total_free_symbols)
10222 (total_free_floats, total_floats, total_free_intervals)
10223 (total_intervals, total_strings, total_free_strings):
10224 Now EMACS_INT, not int. All uses changed.
10225 (Fgarbage_collect): Compute overall total using a double, so that
10226 integer overflow is less likely to be a problem. Check for overflow
10227 when converting back to an integer.
10228 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10229 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10230 These were 'int' variables that could overflow on 64-bit hosts;
10231 they were never used, so remove them instead of repairing them.
10232 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10233 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10234 Previously, this ceilinged at INT_MAX, but that doesn't work on
10236 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10238 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10239 (allocate_vectorlike): Check for ptrdiff_t overflow.
10240 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10241 when a (possibly-narrower) signed value would do just as well.
10242 We prefer using signed arithmetic, to avoid comparison confusion.
10244 * alloc.c: Catch some string size overflows that we were missing.
10245 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10246 for convenience in STRING_BYTES_MAX.
10247 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10248 The definition here is exact; the one in lisp.h was approximate.
10249 (allocate_string_data): Check for string overflow. This catches
10250 some instances we weren't catching before. Also, it catches
10251 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10252 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10253 and ptrdiff_t and EMACS_INT are both 64 bits.
10255 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10256 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10257 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10259 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10261 * alloc.c (Fmake_string): Check for out-of-range init.
10263 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10265 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10267 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10269 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10270 xg_get_default_scrollbar_width.
10272 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10273 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10274 (style_changed_cb): Call update_theme_scrollbar_width and call
10275 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10276 all frames (Bug#8505).
10277 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10278 Call gtk_window_set_resizable if HAVE_GTK3.
10279 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10280 and height if HAVE_GTK3 (Bug#8505).
10281 (scroll_bar_width_for_theme): New variable.
10282 (update_theme_scrollbar_width): New function.
10283 (xg_get_default_scrollbar_width): Move code to
10284 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10285 (xg_initialize): Call update_theme_scrollbar_width.
10287 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10289 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10291 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10293 * frame.c (make_frame): Call other_buffer_safely instead of
10296 * window.c (temp_output_buffer_show): Call display_buffer with
10297 second argument Vtemp_buffer_show_specifiers and reset latter
10298 immediately after the call.
10299 (Vtemp_buffer_show_specifiers): New variable.
10300 (auto_window_vscroll_p, next_screen_context_lines)
10301 (Vscroll_preserve_screen_position): Remove leading asterisks from
10304 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10306 Fix minor problems found by GCC 4.6.0 static checking.
10307 * buffer.c (Qclone_number): Remove for now, as it's unused.
10308 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10309 (record_buffer): Remove unused local.
10310 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10311 (set_frame_buffer_list): Remove; unused.
10312 * frame.h (other_visible_frames): Remove decl.
10313 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10314 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10315 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10317 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10318 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10319 Define only if HAVE_GPM.
10320 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10321 (update_hints_inhibit): Remove; never set. All uses removed.
10322 * widgetprv.h (emacsFrameClassRec): Remove decl.
10323 * window.c (delete_deletable_window): Now returns void, since it
10324 wasn't returning anything.
10325 (compare_window_configurations): Remove unused locals.
10326 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10327 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10328 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10329 the same widths as pointers. This follows up on the 2011-05-06 patch.
10330 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10331 * xterm.h: Likewise.
10332 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10334 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10336 * makefile.w32-in: Update dependencies.
10337 (LISP_H): Add lib/intprops.h.
10339 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10341 * image.c (gif_load): Add animation frame delay to the metadata.
10342 (syms_of_image): Use DEFSYM. New symbol `delay'.
10344 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10346 * window.c (delete_deletable_window): Re-add.
10347 (Fset_window_configuration): Rewrite to handle dead buffers and
10348 consequently deletable windows.
10349 (window_tree, Fwindow_tree): Remove. Supply functionality in
10351 (compare_window_configurations): Simplify code.
10353 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10355 * image.c (imagemagick_load_image): Fix type mismatch.
10356 (Fimagemagick_types): Likewise.
10358 * window.h (replace_buffer_in_windows): Declare.
10360 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10362 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10363 Qclone_number. Remove external declaration of Qdelete_window.
10364 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10366 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10367 Run Qbuffer_list_update_hook if allowed.
10368 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10369 buffer list implementation.
10370 (other_buffer_safely): New function.
10371 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10372 calls to replace_buffer_in_windows and
10373 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10375 (record_buffer): Inhibit quitting and rewrite using quittable
10376 functions. Run Qbuffer_list_update_hook if allowed.
10377 (Frecord_buffer, Funrecord_buffer): New functions.
10378 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10379 Move switch-to-buffer to window.el.
10380 (bury-buffer): Move to window.el.
10381 (Vbuffer_list_update_hook): New variable.
10383 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10386 * window.h (resize_frame_windows): Move up in code.
10387 (Fwindow_frame): Remove EXFUN.
10388 (replace_buffer_in_all_windows): Remove prototype.
10389 (replace_buffer_in_windows_safely): Add prototype.
10391 * window.c: Declare Qdelete_window static again. Move down
10392 declaration of select_count.
10393 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10394 (Fother_window): Move to window.el.
10395 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10396 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10397 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10399 (replace_buffer_in_windows): Implement by calling
10400 Qreplace_buffer_in_windows.
10401 (replace_buffer_in_all_windows): Remove with some functionality
10402 moved into replace_buffer_in_windows_safely.
10403 (replace_buffer_in_windows_safely): New function.
10404 (select_window_norecord, select_frame_norecord): Move in front
10405 of run_window_configuration_change_hook. Remove now obsolete
10407 (Fset_window_buffer): Rewrite doc-string.
10408 Call Qrecord_window_buffer.
10409 (keys_of_window): Move binding for other-window to window.el.
10411 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10413 * dispextern.h (struct image): Replace data member, whose int_val
10414 and ptr_val fields were not used by anything, with a single
10417 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10418 (gif_clear_image, gif_load, imagemagick_load_image)
10419 (gs_clear_image, gs_load): Callers changed.
10421 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10423 * buffer.h: Include <time.h>, for time_t.
10424 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10426 Fix minor problems found by static checking.
10428 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10430 Make identifiers static if they are not used in other modules.
10431 * data.c (Qcompiled_function, Qframe, Qvector):
10432 * image.c (QimageMagick, Qsvg):
10433 * minibuf.c (Qmetadata):
10434 * window.c (resize_window_check, resize_root_window): Now static.
10435 * window.h (resize_window_check, resize_root_window): Remove decls.
10437 * window.c (window_deletion_count, delete_deletable_window):
10439 (window_body_lines): Now static.
10440 (Fdelete_other_windows_internal): Mark vars as initialized.
10441 Make sure 'resize_failed' is initialized.
10442 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10443 (resize_window_apply): Remove unused local.
10444 * window.h (delete_deletable_window): Remove decl.
10446 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10447 (imagemagick_load_image): Fix pointer signedness problem by changing
10448 last arg from unsigned char * to char *. All uses changed.
10449 Also, fix a local for similar reasons.
10450 Remove unused locals. Remove locals to avoid shadowing.
10451 (fn_rsvg_handle_free): Remove; unused.
10452 (svg_load, svg_load_image): Fix pointer signedness problem.
10453 (imagemagick_load_image): Don't use garbage pointer image_wand.
10455 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10457 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10459 * image.c (gif_load): Fix omitted cast error introduced by
10462 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10464 * window.h (resize_proportionally, orig_total_lines)
10465 (orig_top_line): Remove from window structure.
10466 (set_window_height, set_window_width, change_window_heights)
10467 (Fdelete_window): Remove prototypes.
10468 (resize_frame_windows): Remove duplicate declaration.
10470 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10472 * window.h (resize_frame_windows, resize_window_check)
10473 (delete_deletable_window, resize_root_window)
10474 (resize_frame_windows): Declare prototypes.
10476 * window.c (resize_window_apply): Make definition be "static" to
10477 match the prototype.
10479 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10481 * window.c: Remove declarations of Qwindow_size_fixed,
10482 window_min_size_1, window_min_size_2, window_min_size,
10483 size_window, window_fixed_size_p, enlarge_window, delete_window.
10484 Remove static from declaration of Qdelete_window, it's
10485 temporarily needed by Fbury_buffer.
10486 (replace_window): Don't assign orig_top_line and
10488 (Fdelete_window, delete_window): Remove. Window deletion is
10489 handled by window.el.
10490 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10491 Replace Fdelete_window calls with calls to Qdelete_window.
10492 (Fdelete_other_windows): Remove. Deleting other windows is
10493 handled by window.el.
10494 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10495 handled in window.el.
10496 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10497 Window minimum sizes are handled in window.el.
10498 (shrink_windows, size_window, set_window_height)
10499 (set_window_width, change_window_heights, window_height)
10500 (window_width, CURBEG, CURSIZE, enlarge_window)
10501 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10502 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10503 handled in window.el.
10504 (make_dummy_parent): Rename to make_parent_window and give it a
10505 second argument horflag.
10506 (make_window): Don't set resize_proportionally any more.
10507 (Fsplit_window): Remove. Windows are split in window.el.
10508 (save_restore_action, save_restore_orig_size)
10509 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10510 Resize mini windows in window.el.
10511 (grow_mini_window, shrink_mini_window): Implement by calling
10512 Qresize_root_window_vertically, resize_window_check and
10513 resize_window_apply.
10514 (saved_window, Fset_window_configuration, save_window_save):
10515 Do not handle orig_top_line, orig_total_lines, and
10516 resize_proportionally.
10517 (window_min_height, window_min_width): Move to window.el.
10518 (keys_of_window): Move bindings for delete-other-windows,
10519 split-window, delete-window and enlarge-window to window.el.
10521 * buffer.c: Temporarily extern Qdelete_window.
10522 (Fbury_buffer): Temporarily call Qdelete_window instead of
10523 Fdelete_window (Fbury_buffer will move to window.el soon).
10525 * frame.c (set_menu_bar_lines_1): Remove code handling
10526 orig_top_line and orig_total_lines.
10528 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10529 set_window_height but set heights directly.
10530 (change_frame_size_1): Use resize_frame_windows.
10532 * xdisp.c (init_xdisp): Don't use set_window_height but set
10535 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10536 Use resize_frame_windows instead of change_window_heights and run
10537 run_window_configuration_change_hook.
10539 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10540 instead of change_window_heights and run
10541 run_window_configuration_change_hook.
10543 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10545 * window.c (replace_window): Rename second argument REPLACEMENT to
10546 NEW. New third argument SETFLAG. Rewrite.
10547 (delete_window, make_dummy_parent): Call replace_window with
10549 (window_list_1): Move down in code.
10550 (run_window_configuration_change_hook): Move set_buffer part
10551 before select_frame_norecord part in order to unwind correctly.
10552 Rename count1 to count.
10553 (recombine_windows, delete_deletable_window, resize_root_window)
10554 (Fdelete_other_windows_internal)
10555 (Frun_window_configuration_change_hook, make_parent_window)
10556 (resize_window_check, resize_window_apply, Fresize_window_apply)
10557 (resize_frame_windows, Fsplit_window_internal)
10558 (Fdelete_window_internal, Fresize_mini_window_internal):
10560 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10562 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10564 * window.h (window): Add some new members to window structure -
10565 normal_lines, normal_cols, new_total, new_normal, clone_number,
10566 splits, nest, prev_buffers, next_buffers.
10567 (WINDOW_TOTAL_SIZE): Move here from window.c.
10568 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10570 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10572 (make_dummy_parent): Set new members of windows structure.
10573 (make_window): Move down in code. Handle new members of window
10575 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10576 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10577 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10578 (Fset_window_prev_buffers, Fwindow_next_buffers)
10579 (Fset_window_next_buffers, Fset_window_clone_number):
10581 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10582 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10584 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10585 Argument WINDOW can be now internal window too.
10586 (Fwindow_use_time): Move up in code.
10587 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10588 Rewrite doc-string.
10589 (Fset_window_configuration, saved_window)
10590 (Fcurrent_window_configuration, save_window_save): Handle new
10591 members of window structure.
10592 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10593 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10594 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10595 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10596 Qget_mru_window, Qresize_root_window,
10597 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10598 Qauto_buffer_name; staticpro them.
10600 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10602 * window.c (Fwindow_total_size, Fwindow_left_column)
10603 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10604 (Fwindow_list_1): New functions.
10605 (window_box_text_cols): Replace with window_body_cols.
10606 (Fwindow_width, Fscroll_left, Fscroll_right):
10607 Use window_body_cols instead of window_box_text_cols.
10608 (delete_window, Fset_window_configuration):
10609 Call delete_all_subwindows with window as argument.
10610 (delete_all_subwindows): Take a window as argument and not a
10611 structure. Rewrite.
10612 (window_loop): Remove handling of GET_LRU_WINDOW and
10613 GET_LARGEST_WINDOW.
10614 (Fget_lru_window, Fget_largest_window): Move to window.el.
10616 * window.h: Extern window_body_cols instead of
10617 window_box_text_cols. delete_all_subwindows now takes a
10618 Lisp_Object as argument.
10620 * indent.c (compute_motion, Fcompute_motion):
10621 Use window_body_cols instead of window_box_text_cols.
10623 * frame.c (delete_frame): Call delete_all_subwindows with root
10624 window as argument.
10626 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10628 * fns.c (Fputhash): Document return value.
10630 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10632 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10634 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10636 Cons<->int and similar integer overflow fixes (Bug#8794).
10638 Check for overflow when converting integer to cons and back.
10639 * charset.c (Fdefine_charset_internal, Fdecode_char):
10640 Use cons_to_unsigned to catch overflow.
10641 (Fencode_char): Use INTEGER_TO_CONS.
10642 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10643 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10644 * data.c (long_to_cons, cons_to_long): Remove.
10645 (cons_to_unsigned, cons_to_signed): New functions.
10646 These signal an error for invalid or out-of-range values.
10647 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10648 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10649 * font.c (Ffont_variation_glyphs):
10650 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10651 * lisp.h: Include <intprops.h>.
10652 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10653 (cons_to_signed, cons_to_unsigned): New decls.
10654 (long_to_cons, cons_to_long): Remove decls.
10655 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10656 (Fprimitive_undo): Use CONS_TO_INTEGER.
10657 * xfns.c (Fx_window_property): Likewise.
10658 * xselect.c: Include <limits.h>.
10659 (x_own_selection, selection_data_to_lisp_data):
10660 Use INTEGER_TO_CONS.
10661 (x_handle_selection_request, x_handle_selection_clear)
10662 (x_get_foreign_selection, Fx_disown_selection_internal)
10663 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10664 (lisp_data_to_selection_data): Use cons_to_unsigned.
10665 (x_fill_property_data): Use cons_to_signed.
10666 Report values out of range.
10668 Check for buffer and string overflow more precisely.
10669 * buffer.h (BUF_BYTES_MAX): New macro.
10670 * lisp.h (STRING_BYTES_MAX): New macro.
10671 * alloc.c (Fmake_string):
10672 * character.c (string_escape_byte8):
10673 * coding.c (coding_alloc_by_realloc):
10674 * doprnt.c (doprnt):
10675 * editfns.c (Fformat):
10677 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10678 since they may not be the same number.
10679 * editfns.c (Finsert_char):
10680 * fileio.c (Finsert_file_contents):
10681 Likewise for BUF_BYTES_MAX.
10683 * image.c: Use ptrdiff_t, not int, for sizes.
10684 (slurp_file): Switch from int to ptrdiff_t.
10686 (slurp_file): Check that file size fits in both size_t (for
10687 malloc) and ptrdiff_t (for sanity and safety).
10689 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10690 if b->modtime has its maximal value.
10692 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10694 Don't assume time_t can fit into int.
10695 * buffer.h (struct buffer.modtime): Now time_t, not int.
10696 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10697 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10699 Minor fixes for signed vs unsigned integers.
10700 * character.h (MAYBE_UNIFY_CHAR):
10701 * charset.c (maybe_unify_char):
10702 * keyboard.c (read_char, reorder_modifiers):
10703 XINT -> XFASTINT, since the integer must be nonnegative.
10704 * ftfont.c (ftfont_spec_pattern):
10705 * keymap.c (access_keymap, silly_event_symbol_error):
10706 XUINT -> XFASTINT, since the integer must be nonnegative.
10707 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10708 since it makes no difference and we prefer signed.
10709 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10710 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10713 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10715 * window.h (Fwindow_frame): Declare.
10717 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10719 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10720 (SPARE_MEMORY): Always define.
10721 (LARGE_REQUEST): Remove.
10722 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10724 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10726 * lisp.h: Move EXFUNS for Fframe_root_window,
10727 Fframe_first_window and Fset_frame_selected_window to window.h.
10729 * window.h: Move EXFUNS for Fframe_root_window,
10730 Fframe_first_window and Fset_frame_selected_window here from
10733 * frame.c (Fwindow_frame, Fframe_first_window)
10734 (Fframe_root_window, Fframe_selected_window)
10735 (Fset_frame_selected_window): Move to window.c.
10736 (Factive_minibuffer_window): Move to minibuf.c.
10737 (Fother_visible_frames_p): New function.
10739 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10741 * window.c (decode_window, decode_any_window): Move up in code.
10742 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10743 (inhibit_frame_unsplittable): Remove unused variable.
10744 (Fwindow_buffer): Move up and rewrite doc-string.
10745 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10746 (Fwindow_prev): New functions.
10747 (Fwindow_frame): Move here from frame.c. Accept any window as
10749 (Fframe_root_window, Fframe_first_window)
10750 (Fframe_selected_window): Move here from frame.c. Accept frame
10751 or arbitrary window as argument. Update doc-strings.
10752 (Fminibuffer_window): Move up in code.
10753 (Fwindow_minibuffer_p): Move up in code and simplify.
10754 (Fset_frame_selected_window): Move here from frame.c.
10756 (Fselected_window, select_window, Fselect_window): Move up in
10757 code. Minor doc-string fixes.
10759 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10761 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10762 Do not assume that spare memory exists; that assumption is valid
10763 only if SYSTEM_MALLOC.
10764 (LARGE_REQUEST): New macro, so that the issue of large requests
10765 is separated from the issue of spare memory.
10767 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10769 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10772 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10774 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10777 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10779 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10781 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10783 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10784 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10786 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10788 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10790 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10792 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10793 (x_clipboard_manager_save): Add return value.
10794 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10795 New error handlers.
10796 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10797 Obey Vx_select_enable_clipboard_manager. Catch errors in
10798 x_clipboard_manager_save (Bug#8779).
10799 (Vx_select_enable_clipboard_manager): New variable.
10800 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10802 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10804 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10806 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10808 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10809 in the current matrix if keep_current_p is non-zero.
10811 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10813 * bidi.c (bidi_level_of_next_char): Fix last change.
10815 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10817 Support bidi reordering of text covered by display properties.
10819 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10820 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10821 (bidi_cache_search, bidi_cache_iterator_state)
10822 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10823 (bidi_level_of_next_char, bidi_move_to_visually_next):
10824 Support character positions inside a run of characters covered by a
10826 (bidi_paragraph_init, bidi_resolve_explicit_1)
10827 (bidi_level_of_next_char): Call bidi_fetch_char and
10828 bidi_fetch_char_advance instead of FETCH_CHAR and
10829 FETCH_CHAR_ADVANCE.
10830 (bidi_init_it): Initialize new members.
10831 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10833 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10834 instead of using explicit *_CHAR codes.
10835 (bidi_resolve_explicit, bidi_resolve_weak):
10836 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10837 bidirectional text is supported only in multibyte buffers.
10838 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10839 it to initialize the frame_window_p member of struct bidi_it.
10840 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10841 (bidi_resolve_explicit, bidi_resolve_weak)
10842 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10843 bidi_it->nchars is non-positive.
10844 (bidi_level_of_next_char): Don't try to lookup the cache for the
10845 next/previous character if nothing is cached there yet, or if we
10846 were just reseat()'ed to a new position.
10848 * xdisp.c (set_cursor_from_row): Set start and stop points
10849 according to the row's direction when priming the loop that looks
10850 for the glyph on which to display cursor.
10851 (single_display_spec_intangible_p): Function deleted.
10852 (display_prop_intangible_p): Reimplement to call
10853 handle_display_spec instead of single_display_spec_intangible_p.
10854 Accept 3 additional arguments needed by handle_display_spec.
10855 This fixes incorrect cursor motion across display property with complex
10856 values: lists, `(when COND...)' forms, etc.
10857 (single_display_spec_string_p): Support property values that are
10858 lists with the argument STRING its top-level element.
10859 (display_prop_string_p): Fix the condition for processing a
10860 property that is a list to be consistent with handle_display_spec.
10861 (handle_display_spec): New function, refactored from the
10862 last portion of handle_display_prop.
10863 (compute_display_string_pos): Accept additional argument
10864 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10865 value of a `display' property is a "replacing spec".
10866 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10867 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10868 the display property, but just return a value indicating whether
10869 the display property will replace the characters it covers.
10870 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10871 frame_window_p members of struct bidi_it.
10872 (compute_display_string_pos, compute_display_string_end):
10874 (push_it): Accept second argument POSITION, where pop_it should
10875 jump to continue iteration.
10876 (reseat_1): Initialize bidi_it.disp_pos.
10878 * keyboard.c (adjust_point_for_property): Adjust the call to
10879 display_prop_intangible_p to its new signature.
10881 * dispextern.h (struct bidi_it): New member frame_window_p.
10882 (bidi_init_it): Update prototypes.
10883 (display_prop_intangible_p): Update prototype.
10884 (compute_display_string_pos, compute_display_string_end):
10885 Declare prototypes.
10886 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10889 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10891 Malloc failure behavior now depends on size of allocation.
10892 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10893 * lisp.h: Change signatures accordingly.
10894 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10895 All callers changed. (Bug#8762)
10897 * gnutls.c: Use Emacs's memory allocators.
10898 Without this change, the gnutls library would invoke malloc etc.
10899 directly, which causes problems on non-SYNC_INPUT hosts, and which
10900 runs afoul of improving memory_full behavior. (Bug#8761)
10901 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10902 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10903 xfree instead of the default malloc, realloc, free.
10904 (Fgnutls_boot): No need to check for memory allocation failure,
10905 since xmalloc does that for us.
10907 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10908 * category.c (hash_get_category_set):
10909 * ccl.c (ccl_driver):
10910 * charset.c (Fdefine_charset_internal):
10911 * charset.h (struct charset.hash_index):
10912 * composite.c (get_composition_id, gstring_lookup_cache)
10913 (composition_gstring_put_cache):
10914 * composite.h (struct composition.hash_index):
10915 * dispextern.h (struct image.hash):
10916 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10917 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10918 (hashfn_equal, hashfn_user_defined, make_hash_table)
10919 (maybe_resize_hash_table, hash_lookup, hash_put)
10920 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10921 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10922 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10923 * image.c (make_image, search_image_cache, lookup_image)
10924 (xpm_put_color_table_h):
10925 * lisp.h (struct Lisp_Hash_Table):
10926 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10927 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10928 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10929 * alloc.c (allocate_vectorlike):
10930 Check for overflow in vector size calculations.
10931 * ccl.c (ccl_driver):
10932 Check for overflow when converting EMACS_INT to int.
10933 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10934 need to be updated by these changes.
10935 * fns.c (make_hash_table, maybe_resize_hash_table):
10936 Check for integer overflow with large hash tables.
10937 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10938 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10939 (SXHASH_REDUCE): New macro.
10940 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10941 Use it instead of discarding useful hash info with large hash values.
10942 (sxhash_float): New function.
10943 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10944 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10945 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10946 Rewrite to use FIXNUM_BITS, as this simplifies things.
10947 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10948 Adjust signatures to match updated version of code.
10949 (consing_since_gc): Now EMACS_INT, since a single hash table can
10950 use more than INT_MAX bytes.
10952 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10954 Make it possible to build with GCC-4.6+ -O2 -flto.
10956 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10958 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10960 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10961 Call minibuffer-inactive-mode.
10963 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10965 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10966 Update dependencies.
10968 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10970 * data.c (init_data): Remove code for UTS, this system is not
10973 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10975 Don't force ./temacs to start in terminal mode.
10977 * frame.c (make_initial_frame): Initialize faces in all cases, not
10978 only when CANNOT_DUMP is defined.
10979 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10981 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10983 * dispnew.c (add_window_display_history): Use const for the string
10984 pointer. Remove declaration, not needed.
10986 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10988 Use 'inline', not 'INLINE'.
10989 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10990 * alloc.c, fontset.c (INLINE): Remove.
10991 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10992 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10993 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10994 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10995 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10997 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10999 Make it possible to run ./temacs.
11001 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11002 syms_of_callproc does the same thing. Remove test for
11003 "initialized", do it in the caller.
11004 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11006 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11008 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11009 (read_minibuf): Use get_minibuffer.
11010 (syms_of_minibuf): Use DEFSYM.
11011 (Qmetadata): New var.
11012 * data.c (Qbuffer): Don't make it static.
11013 (syms_of_data): Use DEFSYM.
11015 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11017 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11018 (CCL_CODE_MIN): New macro.
11020 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11022 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11024 * eval.c (Qdebug): Now static.
11025 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11026 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11027 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11029 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11031 * image.c: Various fixes to ImageMagick code comments.
11032 (Fimagemagick_types): Doc fix.
11034 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11036 Minor fixes prompted by GCC 4.6.0 warnings.
11038 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11040 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11041 (x_clipboard_manager_save_all): Move extern decl to ...
11042 * xterm.h: ... here, so that it can be checked for consistency.
11044 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11046 * xselect.c (x_clipboard_manager_save_frame)
11047 (x_clipboard_manager_save_all): New functions.
11048 (Fx_clipboard_manager_save): Lisp function deleted.
11050 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11051 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11053 * xterm.h: Update prototype.
11055 2011-05-28 William Xu <william.xwl@gmail.com>
11057 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11058 exiting (Bug#8239).
11060 2011-05-28 Jim Meyering <meyering@redhat.com>
11062 Avoid a sign-extension bug in crypto_hash_function.
11063 * fns.c (to_uchar): Define.
11064 (crypto_hash_function): Use it to convert some newly-signed
11065 variables to unsigned, to avoid sign-extension bugs. For example,
11066 without this change, (md5 "truc") would evaluate to
11067 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11068 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
11069 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
11071 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11073 Integer overflow fixes.
11075 * dbusbind.c: Serial number integer overflow fixes.
11076 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
11077 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11078 to hold a serial number that is too large for a fixnum.
11079 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11080 Check for serial numbers out of range. Decode any serial number
11081 that was so large that it became a float. (Bug#8722)
11083 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11084 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11085 Use XFASTINT rather than XUINT when numbers are nonnegative.
11086 (xd_append_arg, Fdbus_method_return_internal):
11087 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11088 arguments, check that Lisp number is nonnegative, rather than
11089 silently wrapping negative numbers around. (Bug#8722)
11090 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
11093 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11095 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11097 ccl: Add integer overflow checks.
11098 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11099 (IN_INT_RANGE): New macros.
11100 (ccl_driver): Use them to check for integer overflow when
11101 decoding a CCL program. Many of the new checks are whether XINT (x)
11102 fits in int; it doesn't always, on 64-bit hosts. The new version
11103 doesn't catch all possible integer overflows, but it's an
11104 improvement. (Bug#8719)
11106 * alloc.c (make_event_array): Use XINT, not XUINT.
11107 There's no need for unsigned here.
11109 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11110 This follows up to the 2011-05-06 change that substituted uintptr_t
11111 for EMACS_INT. This case wasn't caught back then.
11113 Rework Fformat to avoid integer overflow issues.
11114 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11115 now (part of C89). Include <verify.h>.
11116 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11117 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11118 (Fformat): Avoid the prepass trying to compute sizes; it was only
11119 approximate and thus did not catch overflow reliably. Instead, walk
11120 through the format just once, formatting and computing sizes as we go,
11121 checking for integer overflow at every step, and allocating a larger
11122 buffer as needed. Keep track separately whether the format is
11123 multibyte. Keep only the most-recently calculated precision, rather
11124 than them all. Record whether each argument has been converted to
11125 string. Use EMACS_INT, not int, for byte and char and arg counts.
11126 Support field widths and precisions larger than INT_MAX. Avoid
11127 sprintf's undefined behavior with conversion specifications such as %#d
11128 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11129 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11130 formatting out-of-range floating point numbers with int
11131 formats. (Bug#8668)
11133 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11135 * data.c: Avoid integer truncation in expressions involving floats.
11136 * data.c: Include <intprops.h>.
11137 (arith_driver): When there's an integer overflow in an expression
11138 involving floating point, convert the integers to floating point
11139 so that the resulting value does not suffer from catastrophic
11140 integer truncation. For example, on a 64-bit host (* 4
11141 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11142 Do not rely on undefined behavior after integer overflow.
11144 merge count_size_as_multibyte, parse_str_to_multibyte
11145 * character.c, character.h (count_size_as_multibyte):
11146 Rename from parse_str_to_multibyte; all uses changed.
11147 Check for integer overflow.
11148 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11149 since it's now a duplicate of the other. This is more of
11150 a character than a buffer op, so better that it's in character.c.
11151 * fns.c, print.c: Adjust to above changes.
11153 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11155 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11157 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11159 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11160 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11161 (x_clipboard_manager_save): Now static.
11162 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11164 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11165 (crypto_hash_function): Now static.
11166 Fix pointer signedness problems. Avoid unnecessary initializations.
11168 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11170 * termhooks.h (Vselection_alist): Make it terminal-local.
11172 * terminal.c (create_terminal): Initialize it.
11174 * xselect.c: Support for clipboard managers.
11175 (Vselection_alist): Move to termhooks.h as terminal-local var.
11176 (LOCAL_SELECTION): New macro.
11177 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11178 (symbol_to_x_atom): Remove gratuitous arg.
11179 (x_handle_selection_request, lisp_data_to_selection_data)
11180 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11181 (x_own_selection, x_get_local_selection, x_convert_selection):
11182 New arg, specifying work frame. Use terminal-local Vselection_alist.
11183 (some_frame_on_display): Delete unused function.
11184 (Fx_own_selection_internal, Fx_get_selection_internal)
11185 (Fx_disown_selection_internal, Fx_selection_owner_p)
11186 (Fx_selection_exists_p): New optional frame arg.
11187 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11188 (x_handle_selection_clear): Don't treat other terminals with the
11189 same keyboard specially. Use the terminal-local Vselection_alist.
11190 (x_clear_frame_selections): Use Frun_hook_with_args.
11192 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11194 * xterm.h: Add support for those atoms.
11196 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11198 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11199 (converted_selections, conversion_fail_tag): New global variables.
11200 (x_selection_request_lisp_error): Free the above.
11201 (x_get_local_selection): Remove unnecessary code.
11202 (x_reply_selection_request): Args changed; handle arbitrary array
11203 of converted selections stored in converted_selections.
11204 Separate the XChangeProperty and SelectionNotify steps.
11205 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11206 (x_convert_selection): New function.
11207 (x_handle_selection_event): Simplify.
11208 (x_get_foreign_selection): Don't ignore incoming requests while
11209 waiting for an answer; this will fail when we implement
11210 SAVE_TARGETS, and seems unnecessary anyway.
11211 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11212 (Vx_sent_selection_functions): Doc fix.
11214 2011-05-26 Leo Liu <sdl.web@gmail.com>
11216 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11218 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11220 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11222 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11223 for fringe update if it has periodic bitmap.
11224 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11225 and fringe_bitmap_periodic_p.
11227 * fringe.c (get_fringe_bitmap_data): New function.
11228 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11229 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11230 row. Mark glyph row for fringe update if periodicity changed.
11232 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11233 for fringe update unless it has periodic bitmap.
11235 2011-05-25 Kenichi Handa <handa@m17n.org>
11237 * xdisp.c (get_next_display_element): Set correct it->face_id for
11238 a static composition.
11240 2011-05-24 Leo Liu <sdl.web@gmail.com>
11243 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11245 * fns.c (crypto_hash_function, Fsha1): New function.
11246 (Fmd5): Use crypto_hash_function.
11247 (syms_of_fns): Add Ssha1.
11249 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11251 * gnutls.c: Remove unused macros.
11252 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11253 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11254 Remove macros that are defined and never used.
11255 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11257 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11259 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11260 (Fx_get_selection_internal): Minor cleanup.
11261 (Fx_own_selection_internal): Rename arguments for consistency with
11264 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11266 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11268 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11270 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11272 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11274 * dispnew.c (scrolling_window): Don't exclude the case that the
11275 last enabled row in the desired matrix touches the bottom boundary.
11277 2011-05-21 Glenn Morris <rgm@gnu.org>
11279 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11280 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11281 and add some more files.
11283 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11285 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11286 report_file_error introduced by the change from 2011-05-07.
11288 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11290 * systime.h (Time): Define only if emacs is defined.
11291 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11292 where the include path doesn't have X11/X.h by default. See
11293 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11295 2011-05-20 Kenichi Handa <handa@m17n.org>
11297 * composite.c (find_automatic_composition): Fix previous change.
11299 2011-05-20 Glenn Morris <rgm@gnu.org>
11301 * lisp.mk: New file, split from Makefile.in.
11302 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11303 (shortlisp): Remove.
11304 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11306 2011-05-19 Glenn Morris <rgm@gnu.org>
11308 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11309 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11310 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11311 (lisp): Set the order to that of loadup.el.
11312 (shortlisp): Make it a copy of $lisp.
11313 (SOME_MACHINE_LISP): Remove.
11314 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11315 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11317 2011-05-18 Kenichi Handa <handa@m17n.org>
11319 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11320 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11321 (find_automatic_composition): Mostly rewrite for efficiency.
11323 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11325 * makefile.w32-in: Update dependencies.
11327 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11329 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11330 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11332 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11334 Fix some integer overflow issues, such as string length overflow.
11336 * insdel.c (count_size_as_multibyte): Check for string overflow.
11338 * character.c (lisp_string_width): Check for string overflow.
11339 Use EMACS_INT, not int, for string indexes and lengths; in
11340 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11341 the resulting string length overflows an EMACS_INT; instead,
11342 report a string overflow if no precision given. When checking for
11343 precision exhaustion, use a check that cannot possibly have
11344 integer overflow. (Bug#8675)
11345 * character.h (lisp_string_width): Adjust to new signature.
11347 * alloc.c (string_overflow): New function.
11348 (Fmake_string): Use it. This doesn't change behavior, but saves
11349 a few bytes and will simplify future changes.
11350 * character.c (string_escape_byte8): Likewise.
11351 * lisp.h (string_overflow): New decl.
11353 Fixups, following up to the user-interface timestamp change.
11354 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11355 for UI timestamps, instead of unsigned long.
11356 * msdos.c (mouse_get_pos): Likewise.
11357 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11358 * w32gui.h (Time): Define by including "systime.h" rather than by
11359 declaring it ourselves. (Bug#8664)
11361 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11362 * image.c (clear_image_cache): Likewise.
11364 * term.c (term_mouse_position): Don't assume time_t wraparound.
11366 Be more systematic about user-interface timestamps.
11367 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11368 and sometimes 'EMACS_UINT', to represent these timestamps.
11369 This change causes it to use 'Time' uniformly, as that's what X uses.
11370 This makes the code easier to follow, and makes it easier to catch
11371 integer overflow bugs such as Bug#8664.
11372 * frame.c (Fmouse_position, Fmouse_pixel_position):
11373 Use Time, not unsigned long, for user-interface timestamps.
11374 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11375 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11376 * keyboard.h (last_event_timestamp): Likewise.
11377 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11378 * menu.h (xmenu_show): Likewise.
11379 * term.c (term_mouse_position): Likewise.
11380 * termhooks.h (struct input_event.timestamp): Likewise.
11381 (struct terminal.mouse_position_hook): Likewise.
11382 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11383 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11384 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11385 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11386 what it was before.
11387 * menu.h, termhooks.h: Include "systime.h", for Time.
11389 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11390 Don't assume that the difference between two unsigned long values
11391 can fit into an integer. At this point, we know button_down_time
11392 <= event->timestamp, so the difference must be nonnegative, so
11393 there's no need to cast the result if double-click-time is
11394 nonnegative, as it should be; check that it's nonnegative, just in
11395 case. This bug is triggered when events are more than 2**31 ms
11396 apart (about 25 days). (Bug#8664)
11398 * xselect.c (last_event_timestamp): Remove duplicate decl.
11399 (x_own_selection): Remove needless cast to unsigned long.
11401 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11402 that always fit in int. Use a sentinel instead of a counter, to
11403 avoid a temp and to allay GCC's concerns about possible int overflow.
11404 * frame.h (struct frame): Use int for menu_bar_items_used
11405 instead of EMACS_INT, since it always fits in int.
11407 * menu.c (grow_menu_items): Check for int overflow.
11409 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11411 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11412 Before, the code was not consistent. These values cannot exceed
11413 2**31 - 1 so there's no need to make them unsigned.
11414 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11415 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11416 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11418 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11420 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11421 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11422 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11423 presumably because the widths might not match.
11425 * window.c (size_window): Avoid needless test at loop start.
11427 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11429 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11431 2011-05-12 Drew Adams <drew.adams@oracle.com>
11433 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11435 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11437 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11438 `width' to `bar_area_x' and `bar_area_width', respectively.
11439 (x_scroll_run): Take account of fringe background extension.
11441 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11442 Rename local vars `left' and `width' to `bar_area_x' and
11443 `bar_area_width', respectively.
11444 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11445 background extension.
11447 2011-05-10 Jim Meyering <meyering@redhat.com>
11449 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11451 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11453 * image.c (Finit_image_library): Return t for built-in image types,
11454 like pbm and xbm. (Bug#8640)
11456 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11458 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11460 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11462 * w32console.c (Fset_screen_color): Doc fix.
11463 (Fget_screen_color): New function.
11464 (syms_of_ntterm): Defsubr it.
11466 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11467 unlink the temporary file if Fcall_process didn't create it in the
11469 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11470 child process will be redirected to a file specified with `:file'.
11471 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11472 cue to call_process_cleanup not to close that handle.
11474 2011-05-07 Ben Key <bkey76@gmail.com>
11476 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11477 one of two shell specific rules, either bootstrap-temacs-CMD or
11478 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11479 to the previous implementation of the bootstrap-temacs rule.
11480 The bootstrap-temacs-CMD rule is similar to the previous
11481 implementation of the bootstrap-temacs rule except that it
11482 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11485 These changes, along with some changes to nt/configure.bat,
11486 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11487 earlier fix to add support for --cflags and --ldflags options
11488 that include quotes so that it works whether make uses cmd or
11491 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11493 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11494 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11496 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11497 a string. Handle both cases.
11498 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11499 (Fdbus_register_method): Use Qinvalid_function.
11501 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11503 * makefile.w32-in: Update dependencies.
11504 (LISP_H): Add inttypes.h and stdin.h.
11505 (PROCESS_H): Add unistd.h.
11507 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11509 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11510 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11512 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11514 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11516 * term.c (vfatal): Remove stray call to va_end.
11517 It's not needed and the C Standard doesn't allow it here anyway.
11519 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11520 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11522 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11525 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11527 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11529 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11531 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11533 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11535 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11536 * charset.c (Fdefine_charset_internal): Don't initialize
11537 charset.code_space[15]. The value was garbage, on hosts with
11538 32-bit int (Bug#8600).
11540 * lread.c (read_integer): Be more consistent with string-to-number.
11541 Use string_to_number to do the actual conversion; this avoids
11542 rounding errors and fixes some other screwups. Without this fix,
11543 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11544 (digit_to_number): Move earlier, for benefit of read_integer.
11545 Return -1 if the digit is out of range for the base, -2 if it is
11546 not a digit in any supported base. (Bug#8602)
11548 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11550 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11551 to match comment at start of function. This also removes a
11552 GCC warning about overflow in a 32+64-bit port.
11554 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11556 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11557 Reported by Stefan Monnier in
11558 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11559 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11560 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11562 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11563 (EMACS_UINTPTR): Likewise, with uintptr_t.
11565 * lisp.h: Prefer 64-bit EMACS_INT if available.
11566 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11567 on 32-bit hosts that have 64-bit int, so that they can access
11569 However, temporarily disable this change unless the temporary
11570 symbol WIDE_EMACS_INT is defined.
11572 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11574 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11575 This removes an assumption that EMACS_INT and long are the same
11576 width as pointers. The assumption is true for Emacs porting targets
11577 now, but we want to make other targets possible.
11578 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11579 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11580 In the rest of the code, change types of integers that hold casted
11581 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11582 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11583 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11584 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11585 No need to cast type when ORing.
11586 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11587 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11588 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11589 assume EMACS_INT is the same width as char *.
11590 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11591 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11592 Remove no-longer-needed casts.
11593 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11594 (xg_tool_bar_help_callback, xg_make_tool_item):
11595 Use EMACS_INTPTR to hold an integer
11596 that will be cast to void *; this can avoid a GCC warning
11597 if EMACS_INT is not the same width as void *.
11598 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11599 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11600 (current_message_1, set_message_1):
11601 Use a local to convert to proper width without a cast.
11602 * xmenu.c (dialog_selection_callback): Likewise.
11604 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11605 Also, don't assume VALBITS / RAND_BITS is less than 5,
11606 and don't rely on undefined behavior when shifting a 1 left into
11608 * lisp.h (get_random): Change signature to match.
11610 * lread.c (hash_string): Use size_t, not int, for hash computation.
11611 Normally we prefer signed values; but hashing is special, because
11612 it's better to use unsigned division on hash table sizes so that
11613 the remainder is nonnegative. Also, size_t is the natural width
11614 for hashing into memory. The previous code used 'int', which doesn't
11615 retain enough info to hash well into very large tables.
11616 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11618 * dbusbind.c: Don't possibly lose pointer info when converting.
11619 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11620 Use XPNTR rather than XHASH, so that the high-order bits of
11621 the pointer aren't lost when converting through void *.
11623 * eval.c (Fautoload): Don't double-shift a pointer.
11625 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11627 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11629 * gnutls.c (DEF_GNUTLS_FN):
11630 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11632 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11634 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11637 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11639 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11640 New version that can reserve upto 2GB of heap space.
11642 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11644 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11646 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11648 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11649 `gnutls_certificate_set_x509_key_file'.
11651 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11653 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11654 Update dependencies.
11656 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11658 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11659 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11660 Remove unused parameter `fildes'.
11661 * process.c (read_process_output, send_process): Don't pass it.
11663 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11665 Fix previous change: the library cache is defined in w32.c.
11666 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11667 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11669 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11671 Implement dynamic loading of GnuTLS on Windows.
11673 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11674 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11675 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11678 * gnutls.c (Qgnutls_dll): Define.
11679 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11680 (gnutls_*): Declare function pointers.
11681 (init_gnutls_functions): New function to initialize function pointers.
11682 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11683 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11684 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11685 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11686 (emacs_gnutls_write, emacs_gnutls_read)
11687 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11688 (Fgnutls_available_p): New function.
11689 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11690 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11691 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11693 * image.c: Include w32.h.
11694 (Vimage_type_cache): Delete.
11695 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11696 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11697 (w32_delayed_load): Move to w32.c.
11699 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11701 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11702 (w32_delayed_load): Move from image.c. When loading a library, record
11703 its filename in the :loaded-from property of the library id.
11704 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11705 Initialize and staticpro them.
11706 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11708 * process.c: Include lisp.h before w32.h, not after.
11709 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11710 instead of gnutls_record_check_pending.
11712 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11714 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11716 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11717 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11720 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11722 * xterm.c (x_set_frame_alpha): Do not set property on anything
11723 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11725 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11727 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11729 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11731 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11732 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11733 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11734 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11735 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11736 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11737 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11738 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11739 (Qgnutls_bootprop_callbacks_verify): Make static.
11741 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11743 * callproc.c: Indentation fixup.
11745 * sysdep.c (wait_for_termination_1): Make static.
11746 (wait_for_termination, interruptible_wait_for_termination):
11747 Move after wait_for_termination_1.
11749 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11751 * sysdep.c (interruptible_wait_for_termination): New function
11752 which is like wait_for_termination, but allows keyboard
11755 * callproc.c (Fcall_process): Add (:file "file") as an option for
11757 (Fcall_process_region): Ditto.
11759 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11761 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11762 rather than `XVECTOR (FOO)->size'.
11764 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11765 inttypes.h, as a gnulib replacement is used if it not available in
11768 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11770 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11771 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11772 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11774 * coding.c (coding_alloc_by_realloc): Error out if destination
11775 will grow beyond MOST_POSITIVE_FIXNUM.
11776 (decode_coding_emacs_mule): Abort if there isn't enough place in
11777 charbuf for the composition carryover bytes. Reserve an extra
11778 space for up to 2 characters produced in a loop.
11779 (decode_coding_iso_2022): Abort if there isn't enough place in
11780 charbuf for the composition carryover bytes.
11782 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11784 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11785 aborting when %lld or %lll format is passed.
11786 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11787 %llo or %llx format is passed. (Bug#8545)
11789 * window.c (window_scroll_line_based): Use a marker instead of
11790 simple variables to record original value of point. (Bug#7952)
11792 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11793 produced by %s or %c overflows available buffer space. (Bug#8545)
11795 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11797 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11798 (SIZE_MAX): Move defn after all includes, as they might #define it.
11800 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11802 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11804 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11806 * keyboard.c (Qdelayed_warnings_hook): Define.
11807 (command_loop_1): Run `delayed-warnings-hook'
11808 if Vdelayed_warnings_list is non-nil.
11809 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11810 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11812 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11814 * doprnt.c (doprnt): Don't return value smaller than the buffer
11815 size if the message was truncated. (Bug#8545).
11817 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11819 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11820 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11822 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11824 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11826 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11828 * makefile.w32-in: Update dependencies.
11830 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11832 Improve `doprnt' and its usage. (Bug#8545)
11833 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11834 `format_end'. Remove support for %l as a conversion specifier.
11835 Don't use xrealloc. Improve diagnostics when the %l size modifier
11836 is used. Update the commentary.
11838 * eval.c (verror): Simplify calculation of size_t.
11840 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11843 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11845 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11848 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11850 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11851 This makes this file independent of the recent pseudovector change.
11853 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11855 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11857 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11858 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11859 Remove unused local.
11860 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11862 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11863 GCC 4.6.0 optimizes based on type-based alias analysis.
11864 For example, if b is of type struct buffer * and v of type struct
11865 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11866 != &v->size, and therefore "v->size = 1; b->size = 2; return
11867 v->size;" must therefore return 1. This assumption is incorrect
11868 for Emacs, since it type-puns struct Lisp_Vector * with many other
11869 types. To fix this problem, this patch adds a new type struct
11870 vectorlike_header that documents the constraints on layout of vectors
11871 and pseudovectors, and helps optimizing compilers not get fooled
11872 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11873 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11874 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11876 (XSETPVECTYPE): Rewrite in terms of new macro.
11877 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11878 This is a bit clearer, and further avoids the possibility of
11879 undesirable aliasing.
11880 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11881 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11882 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11883 since Lisp_Subr is a special case (no "next" field).
11884 (ASIZE): Now uses header.size rather than size.
11885 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11886 to avoid the hassle of writing XVECTOR (foo)->header.size.
11887 (struct vectorlike_header): New type.
11888 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11889 object, to help avoid aliasing.
11890 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11891 (SUBRP): Likewise, since Lisp_Subr is a special case.
11892 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11893 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11894 (struct Lisp_Hash_Table): Combine first two members into a single
11895 struct vectorlike_header member. All uses of "size" and "next" members
11896 changed to be "header.size" and "header.next".
11897 * buffer.h (struct buffer): Likewise.
11898 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11899 * frame.h (struct frame): Likewise.
11900 * process.h (struct Lisp_Process): Likewise.
11901 * termhooks.h (struct terminal): Likewise.
11902 * window.c (struct save_window_data, struct saved_window): Likewise.
11903 * window.h (struct window): Likewise.
11904 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11905 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11906 * buffer.c (init_buffer_once): Likewise.
11907 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11909 * process.c (Fformat_network_address): Use local var for size,
11912 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11914 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11915 * data.c (atof): Remove decl; no longer used or needed.
11916 (digit_to_number): Move to lread.c.
11917 (Fstring_to_number): Use new string_to_number function, to be
11918 consistent with how the Lisp reader treats infinities and NaNs.
11919 Do not assume that floating-point numbers represent EMACS_INT
11920 without losing information; this is not true on most 64-bit hosts.
11921 Avoid double-rounding errors, by insisting on integers when
11922 parsing non-base-10 numbers, as the documentation specifies.
11923 * lisp.h (string_to_number): New decl, replacing ...
11924 (isfloat_string): Remove.
11925 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11926 (read1): Do not accept +. and -. as integers; this
11927 appears to have been a coding error. Similarly, do not accept
11928 strings like +-1e0 as floating point numbers. Do not report
11929 overflow for integer overflows unless the base is not 10 which
11930 means we have no simple and reliable way to continue.
11931 Break out the floating-point parsing into a new
11932 function string_to_number, so that Fstring_to_number parses
11933 floating point numbers consistently with the Lisp reader.
11934 (digit_to_number): Move here from data.c. Make it static inline.
11935 (E_CHAR, EXP_INT): Remove, replacing with ...
11936 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11937 (string_to_number): New function, replacing isfloat_string.
11938 This function checks for valid syntax and produces the resulting
11939 Lisp float number too. Rework it so that string-to-number
11940 no longer mishandles examples like "1.0e+". Use strtoumax,
11941 so that overflow for non-base-10 numbers is reported only when
11942 there's no portable and simple way to convert to floating point.
11944 * textprop.c (set_text_properties_1): Rewrite for clarity,
11945 and to avoid GCC warning about integer overflow.
11947 * intervals.h (struct interval): Use EMACS_INT for members
11948 where EMACS_UINT might cause problems. See
11949 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11950 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11951 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11953 (offset_intervals): Tell GCC not to worry about length overflow
11954 when negating a negative length.
11956 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11957 (overrun_check_free): Likewise.
11959 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11960 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11963 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11964 (gnutls_make_error): Rename local to avoid shadowing.
11965 (gnutls_emacs_global_deinit): ifdef out; not used.
11966 (Fgnutls_boot): Use const for pointer to readonly storage.
11967 Comment out unused local. Fix pointer signedness problems.
11969 * lread.c (openp): Don't stuff size_t into an 'int'.
11970 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11971 about possible signed overflow.
11973 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11974 (GDK_KEY_g): Don't define if already defined.
11975 (xg_prepare_tooltip): Avoid pointer signedness problem.
11976 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11978 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11979 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11981 * xfns.c (Fx_window_property): Simplify a bit,
11982 to make a bit faster and to avoid GCC 4.6.0 warning.
11983 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11985 * fns.c (internal_equal): Don't assume size_t fits in int.
11987 * alloc.c (compact_small_strings): Tighten assertion a little.
11989 Replace pEd with more-general pI, and fix some printf arg casts.
11990 * lisp.h (pI): New macro, generalizing old pEd macro to other
11991 conversion specifiers. For example, use "...%"pI"d..." rather
11992 than "...%"pEd"...".
11993 (pEd): Remove. All uses replaced with similar uses of pI.
11994 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11995 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11996 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11997 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11998 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11999 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12000 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12002 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12003 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12004 * print.c (safe_debug_print, print_object): Likewise.
12005 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12007 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12008 avoiding the 0 flag, which is not portable.
12009 * process.c (Fmake_network_process): Use pI to avoid cast.
12010 * region-cache.c (pp_cache): Likewise.
12011 * xdisp.c (decode_mode_spec): Likewise.
12012 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12013 behavior on 64-bit hosts with printf arg.
12014 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
12015 (x_stop_queuing_selection_requests): Likewise.
12016 (x_get_window_property): Don't truncate byte count to an 'int'
12019 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12020 here, since it parses constructs like leading '-' and spaces,
12021 which are not wanted; and it overflows with large numbers.
12022 Instead, simply match F[0-9]+, which is what is wanted anyway.
12024 * alloc.c: Remove unportable assumptions about struct layout.
12025 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12026 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12027 (allocate_vectorlike, make_pure_vector): Use the new macros,
12028 plus offsetof, to remove unportable assumptions about struct layout.
12029 These assumptions hold on all porting targets that I know of, but
12030 they are not guaranteed, they're easy to remove, and removing them
12031 makes further changes easier.
12033 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12034 This doesn't fix a bug but makes the code clearer.
12035 (string_overrun_cookie): Now const. Use initializers that
12036 don't formally overflow signed char, to avoid warnings.
12037 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12038 can cause Emacs to crash when string overrun checking is enabled.
12039 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12040 multiple of sizeof (EMACS_INT); it need not be, if
12041 alignof(EMACS_INT) < sizeof (EMACS_INT).
12042 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
12044 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
12046 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12048 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12050 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
12051 supposed to be handshaking. (Bug#8556)
12052 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12054 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12056 * lisp.h (Qdebug): List symbol.
12057 * eval.c (Qdebug): Restore global linkage.
12058 * keyboard.c (debug-on-event): New variable.
12059 (handle_user_signal): Break into debugger when debug-on-event
12060 matches the current signal symbol.
12062 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12064 * alloc.c (check_sblock, check_string_bytes)
12065 (check_string_free_list): Convert to standard C.
12067 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12069 * w32.c (emacs_gnutls_push): Fix typo.
12071 2011-04-25 Eli Zaretskii <eliz@gnu.org>
12073 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12074 "cast to pointer from integer of different size".
12076 Improve doprnt and its use in verror. (Bug#8545)
12077 * doprnt.c (doprnt): Document the set of format control sequences
12078 supported by the function. Use SAFE_ALLOCA instead of always
12081 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12082 is one byte too soon. Don't use xrealloc; instead xfree and
12085 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12087 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12090 * gnutls.c: Renamed global_initialized to
12091 gnutls_global_initialized. Added internals for the
12092 :verify-hostname-error, :verify-error, and :verify-flags
12093 parameters of `gnutls-boot' and documented those parameters in the
12094 docstring. Start callback support.
12095 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12096 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12097 on error. Return error code.
12098 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12099 (emacs_gnutls_read): Likewise.
12100 (Fgnutls_boot): Return handshake error code.
12101 (emacs_gnutls_handle_error): New function.
12102 (wsaerror_to_errno): Likewise.
12104 * w32.h (emacs_gnutls_pull): Add prototype.
12105 (emacs_gnutls_push): Likewise.
12107 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12108 (emacs_gnutls_push): Likewise.
12110 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12112 * process.c (wait_reading_process_output): Check if GnuTLS
12113 buffered some data internally if no FDs are set for TLS
12116 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12117 (LIBS): Link to USER_LIBS.
12118 ($(BLD)/gnutls.$(0)): New target.
12120 2011-04-24 Eli Zaretskii <eliz@gnu.org>
12122 * xdisp.c (handle_single_display_spec): Rename the
12123 display_replaced_before_p argument into display_replaced_p, to
12124 make it consistent with the commentary. Fix typos in the
12127 * textprop.c (syms_of_textprop): Remove dead code.
12128 (copy_text_properties): Delete obsolete commentary about an
12129 interface that was deleted long ago. Fix typos in the description
12132 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12133 to changes in oldXMenu/XMenu.h from 2011-04-16.
12134 <menu_help_message, prev_menu_help_message>: Constify.
12135 (IT_menu_make_room): menu->help_text is now `const char **';
12138 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12139 to changes in oldXMenu/XMenu.h from 2011-04-16.
12140 (struct XMenu): Declare `help_text' `const char **'.
12142 * xfaces.c <Qunspecified>: Make extern again.
12144 * syntax.c: Include sys/types.h before including regex.h, as
12147 * doc.c (get_doc_string): Improve the format passed to `error'.
12149 * doprnt.c (doprnt): Improve commentary.
12151 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12153 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12156 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12157 changes in globals.h immediately force recompilation.
12158 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12159 $(CURDIR)/s/ms-w32.h.
12160 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12162 * character.c (Fchar_direction): Function deleted.
12163 (syms_of_character): Don't defsubr it.
12164 <char-direction-table>: Deleted.
12166 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12168 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12169 * doprnt.c: Include limits.h.
12170 (SIZE_MAX): New macro.
12171 (doprnt): Return a size_t value. 2nd arg is now size_t.
12172 Many local variables are now size_t instead of int or unsigned.
12173 Improve overflow protection. Support `l' modifier for integer
12174 conversions. Support %l conversion. Don't assume an EMACS_INT
12175 argument for integer conversions and for %c.
12177 * lisp.h (doprnt): Restore prototype.
12179 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12180 $(SRC)/character.h.
12182 * Makefile.in (base_obj): Add back doprnt.o.
12184 * deps.mk (doprnt.o): Add back prerequisites.
12185 (callint.o): Depend on character.h.
12187 * eval.c (internal_lisp_condition_case): Include the handler
12188 representation in the error message.
12189 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12190 when breaking from the loop.
12192 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12194 * callint.c (Fcall_interactively): When displaying error message
12195 about invalid control letter, pass the character's codepoint, not
12196 a pointer to its multibyte form. Improve display of the character
12197 in octal and display also its hex code.
12199 * character.c (char_string): Use %x to display the (unsigned)
12200 codepoint of an invalid character, to avoid displaying a bogus
12203 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12204 `error', not SYMBOL_NAME itself.
12206 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12207 character arguments to `error'.
12209 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12210 to `error' in error message about FINAL_CHAR argument. Make sure
12211 FINAL_CHAR is a character, and use %c when it is passed as
12212 argument to `error'.
12214 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12216 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12218 * w32.c: Include <time.h>.
12219 (sys_localtime): New function.
12221 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12223 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12225 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12227 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12229 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12230 zombies (Bug#8467).
12232 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12234 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12235 gl_state.e_property when gl_state.object is Qt.
12237 * insdel.c (make_gap_larger): Remove limitation of buffer size
12240 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12242 * xdisp.c (lookup_glyphless_char_display)
12243 (produce_glyphless_glyph): Handle cons cell entry in
12244 glyphless-char-display.
12245 (Vglyphless_char_display): Document it.
12247 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12248 glyphless-char-display.
12250 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12252 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12254 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12256 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12257 definition for no-X builds.
12259 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12261 Static checks with GCC 4.6.0 and non-default toolkits.
12263 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12265 * process.c (keyboard_bit_set): Define only if SIGIO.
12266 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12267 (send_process): Repair possible setjmp clobbering.
12269 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12271 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12273 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12275 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12276 Define only if needed.
12278 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12279 by pacifying GCC about it. Maybe it's time to retire it?
12280 * xfaces.c (USG, __TIMEVAL__): Likewise.
12282 * dispextern.h (struct redisplay_interface): Rename param
12283 to avoid shadowing.
12284 * termhooks.h (struct terminal): Likewise.
12285 * xterm.c (xembed_send_message): Likewise.
12287 * insdel.c (make_gap_smaller): Define only if
12288 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12290 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12293 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12294 so that we aren't warned about unused symbols.
12296 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12298 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12300 * xfns.c (x_real_positions): Mark locals as initialized.
12302 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12304 * xterm.c: Fix problems found by static analysis with other toolkits.
12305 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12306 (x_dispatch_event): Declare static if USE_GTK, and
12307 define if USE_GTK || USE_X_TOOLKIT.
12308 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12309 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12310 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12311 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12313 * xmenu.c (menu_help_callback): Pointer type fixes.
12314 Use const pointers when pointing at readonly data. Avoid pointer
12315 signedness clashes.
12316 (FALSE): Remove unused macro.
12317 (update_frame_menubar): Remove unused decl.
12319 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12321 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12322 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12323 (single_menu_item): Rename local to avoid shadowing.
12325 * keyboard.c (make_lispy_event): Remove unused local var.
12327 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12328 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12330 * bitmaps: Change bitmaps from unsigned char back to the X11
12331 compatible char. Avoid the old compiler warnings about
12332 out-of-range initializers by using, for example, '\xab' rather
12335 * xgselect.c (xgselect_initialize): Check vs interface
12336 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12338 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12340 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12341 to read-only memory.
12343 * fns.c (vector): Remove; this old hack is no longer needed.
12345 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12347 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12349 * xrdb.c (x_load_resources): Omit unused local.
12351 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12352 (x_window): Rename locals to avoid shadowing.
12353 (USG): Use the kludged USG macro, to pacify gcc.
12355 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12356 (x_term_init): Remove local to avoid shadowing.
12358 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12360 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12361 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12363 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12365 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12367 Fix regex.c, syntax.c and friends for buffers > 2GB.
12368 * syntax.h (struct gl_state_s): Declare character position members
12371 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12373 * textprop.c (verify_interval_modification, interval_of):
12374 Declare arguments EMACS_INT.
12376 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12379 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12381 * indent.c (Fvertical_motion): Local variable it_start is now
12384 * regex.c (re_match, re_match_2, re_match_2_internal)
12385 (bcmp_translate, regcomp, regexec, print_double_string)
12386 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12387 (re_compile_pattern, re_exec): Declare arguments and local
12388 variables `size_t' and `ssize_t' and return values `regoff_t', as
12390 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12391 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12392 <compile_stack_type>: `size' and `avail' are now `size_t'.
12394 * regex.h <regoff_t>: Use ssize_t, not int.
12395 (re_search, re_search_2, re_match, re_match_2): Arguments that
12396 specify buffer/string position and length are now ssize_t and
12397 size_t. Return type is regoff_t.
12399 2011-04-16 Ben Key <bkey76@gmail.com>
12401 * nsfont.m: Fixed bugs in ns_get_family and
12402 ns_descriptor_to_entity that were caused by using free to
12403 deallocate memory blocks that were allocated by xmalloc (via
12404 xstrdup). This caused Emacs to crash when compiled with
12405 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12406 --enable-checking=xmallocoverrun). xfree is now used to
12407 deallocate these memory blocks.
12409 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12411 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12413 emacs_write: Accept and return EMACS_INT for sizes.
12414 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12416 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12417 Accept and return EMACS_INT.
12418 (emacs_gnutls_write): Return the number of bytes written on
12420 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12421 (emacs_read, emacs_write): Remove check for negative size, as the
12422 Emacs source code has been audited now.
12423 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12424 (emacs_read, emacs_write): Use it.
12425 * process.c (send_process): Adjust to the new signatures of
12426 emacs_write and emacs_gnutls_write. Do not attempt to store
12427 a byte offset into an 'int'; it might overflow.
12428 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12430 * sound.c: Don't assume sizes fit in 'int'.
12431 (struct sound_device.period_size, alsa_period_size):
12432 Return EMACS_INT, not int.
12433 (struct sound_device.write, vox_write, alsa_write):
12434 Accept EMACS_INT, not int.
12435 (wav_play, au_play): Use EMACS_INT to store sizes and to
12436 record read return values.
12438 2011-04-15 Ben Key <bkey76@gmail.com>
12440 * keyboard.c (Qundefined): Don't declare static since it is used
12442 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12443 static since they are used in nsfont.m.
12445 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12447 * process.c (Qprocessp): Don't declare static.
12448 * lisp.h (Qprocessp): Declare again.
12450 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12452 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12454 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12456 Improve C-level modularity by making more things 'static'.
12458 Don't publish debugger-only interfaces to other modules.
12459 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12460 (verify_bytepos, count_markers): Move decls to the only modules
12462 * region-cache.h (pp_cache): Likewise.
12463 * window.h (check_all_windows): Likewise.
12464 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12466 * sysdep.c (croak): Now static, if
12467 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12468 * syssignal.h (croak): Declare only if not static.
12470 * alloc.c (refill_memory_reserve): Now static if
12471 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12472 * lisp.h (refill_memory_reserve): Declare only if not static.
12474 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12475 Define only if USE_LUCID.
12477 * xrdb.c (x_customization_string, x_rm_string): Now static.
12479 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12480 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12482 * xdisp.c (draw_row_with_mouse_face): Now static.
12483 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12485 * window.h (check_all_windows): Mark externally visible.
12487 * window.c (window_deletion_count): Now static.
12489 * undo.c: Make symbols static if they're not exported.
12490 (last_undo_buffer, last_boundary_position, pending_boundary):
12493 * textprop.c (interval_insert_behind_hooks): Now static.
12494 (interval_insert_in_front_hooks): Likewise.
12496 * term.c: Make symbols static if they're not exported.
12497 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12498 (max_frame_lines, tty_set_terminal_modes):
12499 (tty_reset_terminal_modes, tty_turn_off_highlight):
12500 (get_tty_terminal): Now static.
12501 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12502 * termhooks.h (term_mouse_moveto): Do not declare if
12503 HAVE_WINDOW_SYSTEM.
12504 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12505 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12507 * sysdep.c: Make symbols static if they're not exported.
12508 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12510 (sigprocmask_set, full_mask): Remove; unused.
12511 (wait_debugging): Mark as visible.
12512 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12513 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12515 * syntax.c (syntax_temp): Define only if !__GNUC__.
12517 * sound.c (current_sound_device, current_sound): Now static.
12519 * search.c (searchbufs, searchbuf_head): Now static.
12521 * scroll.c (scroll_cost): Remove; unused.
12522 * dispextern.h (scroll_cost): Remove decl.
12524 * region-cache.h (pp_cache): Mark as externally visible.
12526 * process.c: Make symbols static if they're not exported.
12527 (process_tick, update_tick, create_process, chan_process):
12528 (Vprocess_alist, proc_buffered_char, datagram_access):
12529 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12530 (deactivate_process): Mark defn as static, as well as decl.
12531 * lisp.h (create_process): Remove decl.
12532 * process.h (chan_process, Vprocess_alist): Remove decls.
12534 * print.c: Make symbols static if they're not exported.
12535 (print_depth, new_backquote_output, being_printed, print_buffer):
12536 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12537 (print_interval, print_number_index, initial_stderr_stream):
12539 * lisp.h (Fprinc): Remove decl.
12540 (debug_output_compilation_hack): Mark as externally visible.
12542 * sysdep.c (croak): Move decl from here to syssignal.h.
12543 * syssignal.h (croak): Put it here, so the API can be checked when
12544 'croak' is called from dissociate_if_controlling_tty.
12546 * minibuf.c: Make symbols static if they're not exported.
12547 (minibuf_save_list, choose_minibuf_frame): Now static.
12548 * lisp.h (choose_minibuf_frame): Remove decl.
12550 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12552 * lread.c: Make symbols static if they're not exported.
12553 (read_objects, initial_obarray, oblookup_last_bucket_number):
12555 (make_symbol): Remove; unused.
12556 * lisp.h (initial_obarray, make_symbol): Remove decls.
12558 * keyboard.c: Make symbols static if they're not exported.
12559 (single_kboard, recent_keys_index, total_keys, recent_keys):
12560 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12561 (this_single_command_key_start, echoing, last_auto_save):
12562 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12563 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12564 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12565 (Vlispy_mouse_stem, double_click_count):
12567 (force_auto_save_soon): Define only if SIGDANGER.
12568 (ignore_mouse_drag_p): Now static if
12569 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12570 (print_help): Remove; unused.
12571 (stop_character, last_timer_event): Mark as externally visible.
12572 * keyboard.h (ignore_mouse_drag_p): Declare only if
12573 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12574 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12575 * lisp.h (echoing): Remove decl.
12576 (force_auto_save_soon): Declare only if SIGDANGER.
12577 * xdisp.c (redisplay_window): Simplify code, to make it more
12578 obvious that ignore_mouse_drag_p is not accessed if !defined
12579 USE_GTK && !defined HAVE_NS.
12581 * intervals.c: Make symbols static if they're not exported.
12582 (merge_properties_sticky, merge_interval_right, delete_interval):
12584 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12586 * insdel.c: Make symbols static if they're not exported.
12587 However, leave prepare_to_modify_buffer alone. It's never
12588 called from outside this function, but that appears to be a bug.
12589 (combine_after_change_list, combine_after_change_buffer):
12590 (adjust_after_replace, signal_before_change): Now static.
12591 (adjust_after_replace_noundo): Remove; unused.
12592 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12593 (signal_before_change): Remove decls.
12595 * indent.c (val_compute_motion, val_vmotion): Now static.
12597 * image.c: Make symbols static if they're not exported.
12598 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12600 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12601 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12603 * fringe.c (standard_bitmaps): Now static.
12604 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12606 * frame.c: Make symbols static if they're not exported.
12607 (x_report_frame_params, make_terminal_frame): Now static.
12608 (get_frame_param): Now static, unless HAVE_NS.
12609 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12610 (x_get_resource_string): Remove; not used.
12611 * frame.h (make_terminal_frame, x_report_frame_params):
12612 (x_get_resource_string); Remove decls.
12613 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12614 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12616 * font.c, fontset.c: Make symbols static if they're not exported.
12617 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12618 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12619 * font.c (font_close_object): Now static.
12620 * font.h (font_close_object): Remove.
12621 * fontset.c (FONTSET_OBJLIST): Remove.
12622 (free_realized_fontset) #if-0 the body, which does nothing.
12623 (face_suitable_for_char_p): #if-0, as it's never called.
12624 * fontset.h (face_suitable_for_char_p): Remove decl.
12625 * xfaces.c (face_at_string_position):
12626 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12627 since 0 is always ASCII.
12629 * fns.c (weak_hash_tables): Now static.
12631 * fileio.c: Make symbols static if they're not exported.
12632 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12633 (Vwrite_region_annotation_buffers): Now static.
12635 * eval.c: Make symbols static if they're not exported.
12636 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12637 * lisp.h (backtrace_list): Remove decl.
12639 * emacs.c: Make symbols static if they're not exported.
12640 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12641 (fatal_error_code, fatal_error_signal_hook, standard_args):
12643 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12644 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12645 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12646 * lisp.h (fatal_error_signal_hook): Remove decl.
12647 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12649 * editfns.c: Move a (normally-unused) function to its only use.
12650 * editfns.c, lisp.h (get_operating_system_release): Remove.
12651 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12652 worth the hassle of breaking this out.
12654 * xterm.c: Make symbols static if they're not exported.
12655 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12656 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12657 (x_destroy_window, x_delete_display):
12659 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12660 (x_mouse_leave): Remove; unused.
12661 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12662 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12663 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12665 (x_mouse_leave): Declare only if WINDOWSNT.
12666 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12667 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12670 * ftxfont.c: Make symbols static if they're not exported.
12671 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12673 * font.h (ftxfont_driver): Likewise.
12675 * xfns.c: Make symbols static if they're not exported.
12676 (x_last_font_name, x_display_info_for_name):
12677 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12678 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12679 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12680 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12681 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12682 (last_show_tip_args): Now static.
12683 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12684 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12685 (x_screen_planes): Remove; unused.
12686 * dispextern.h (x_screen_planes): Remove decl.
12688 * dispnew.c: Make symbols static if they're not exported.
12689 * dispextern.h (redraw_garbaged_frames, scrolling):
12690 (increment_row_positions): Remove.
12691 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12692 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12694 (redraw_garbaged_frames): Remove; unused.
12696 * xfaces.c: Make symbols static if they're not exported.
12697 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12699 * xterm.h (defined_color): Remove decls.
12700 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12701 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12702 (menu_face_changed_default, defined_color, free_realized_face):
12703 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12704 (ascii_face_of_lisp_face): Remove; unused.
12706 * xdisp.c: Make symbols static if they're not exported.
12707 * dispextern.h (scratch_glyph_row, window_box_edges):
12708 (glyph_to_pixel_coords, set_cursor_from_row):
12709 (get_next_display_element, set_iterator_to_next):
12710 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12711 (show_mouse_face): Remove decls
12712 * frame.h (message_buf_print): Likewise.
12713 * lisp.h (pop_message, set_message, check_point_in_composition):
12715 * xterm.h (set_vertical_scroll_bar): Likewise.
12716 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12717 (message_buf_print, scratch_glyph_row, displayed_buffer):
12718 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12719 (get_next_display_element, show_mouse_face, window_box_edges):
12720 (frame_to_window_pixel_xy, check_point_in_composition):
12721 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12722 (glyph_to_pixel_coords): Remove; unused.
12724 * dired.c (file_name_completion): Now static.
12726 * dbusbind.c (xd_in_read_queued_messages): Now static.
12728 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12729 * data.c (circular_list_error): Remove.
12731 * commands.h (last_point_position, last_point_position_buffer):
12732 (last_point_position_window): Remove decls.
12733 * keyboard.c: Make these variables static.
12735 * coding.h (coding, code_convert_region, encode_coding_gap):
12737 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12738 (iso_code_class, detect_coding, code_convert_region): Now static.
12739 (encode_coding_gap): Remove; unused.
12741 * chartab.c (chartab_chars, chartab_bits): Now static.
12743 * charset.h (charset_iso_8859_1): Remove decl.
12744 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12747 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12748 * ccl.c (Vccl_program_table): Now static.
12749 (check_ccl_update): Remove; unused.
12751 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12752 * category.h: ... from here.
12753 * category.c (check_category_table, set_category_set): Now static.
12755 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12756 * lisp.h: Remove these decls.
12758 * buffer.c (buffer_count): Remove unused var.
12760 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12761 so that it's not optimized away.
12762 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12763 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12764 exported only to the debugger.
12766 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12767 * atimer.h (run_all_atimers): Remove; not exported.
12769 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12770 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12771 was inaccessible from Lisp.
12772 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12773 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12775 alloc.c: Import and export fewer symbols, and remove unused items.
12776 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12778 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12779 it's not optimized away by whole-program optimization.
12780 (message_enable_multibyte, free_misc): Remove.
12781 (catchlist, handlerlist, mark_backtrace):
12782 Declare only if BYTE_MARK_STACK.
12783 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12784 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12785 (message_enable_multibyte): Remove decl.
12786 (free_misc, interval_free_list, float_block, float_block_index):
12787 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12788 (cons_free_list, last_marked_index):
12790 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12791 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12792 (mark_backtrace): Define only if BYTE_MARK_STACK.
12793 * xdisp.c (message_enable_multibyte): Now static.
12795 Declare Lisp_Object Q* variables to be 'static' if not exported.
12796 This makes it easier for human readers (and static analyzers)
12797 to see whether these variables are used from other modules.
12798 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12799 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12800 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12801 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12802 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12803 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12804 * xmenu.c, xselect.c:
12805 Declare Q* vars static if they are not used in other modules.
12806 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12807 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12808 Remove decls of unexported vars.
12809 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12811 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12813 Make Emacs functions such as Fatom 'static' by default.
12814 This makes it easier for human readers (and static analyzers)
12815 to see whether these functions can be called from other modules.
12816 DEFUN now defines a static function. To make the function external
12817 so that it can be used in other C modules, use the new macro DEFUE.
12818 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12819 (Finit_image_library):
12820 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12821 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12822 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12823 Remove decls, since these functions are now static.
12824 (Funintern, Fget_internal_run_time): New decls, since these functions
12825 were already external.
12827 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12828 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12829 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12830 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12831 * keyboard.c, keymap.c, lread.c:
12832 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12833 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12834 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12835 Mark functions with DEFUE instead of DEFUN,
12836 if they are used in other modules.
12837 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12838 decls for now-static functions.
12839 * buffer.h (Fdelete_overlay): Remove decl.
12840 * callproc.c (Fgetenv_internal): Mark as internal.
12841 * composite.c (Fremove_list_of_text_properties): Remove decl.
12842 (Fcomposition_get_gstring): New forward static decl.
12843 * composite.h (Fcomposite_get_gstring): Remove decl.
12844 * dired.c (Ffile_attributes): New forward static decl.
12845 * doc.c (Fdocumntation_property): New forward static decl.
12846 * eval.c (Ffetch_bytecode): New forward static decl.
12847 (Funintern): Remove extern decl; now in .h file where it belongs.
12848 * fileio.c (Fmake_symbolic_link): New forward static decl.
12849 * image.c (Finit_image_library): New forward static decl.
12850 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12851 * intervals.h (Fprevious_property_change):
12852 (Fremove_list_of_text_properties): Remove decls.
12853 * keyboard.c (Fthis_command_keys): Remove decl.
12854 (Fcommand_execute): New forward static decl.
12855 * keymap.c (Flookup_key): New forward static decl.
12856 (Fcopy_keymap): Now static.
12857 * keymap.h (Flookup_key): Remove decl.
12858 * process.c (Fget_process): New forward static decl.
12859 (Fprocess_datagram_address): Mark as internal.
12860 * syntax.c (Fsyntax_table_p): New forward static decl.
12861 (skip_chars): Remove duplicate decl.
12862 * textprop.c (Fprevious_property_change): New forward static decl.
12863 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12865 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12866 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12868 * editfns.c (Fformat): Remove unreachable code.
12870 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12872 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12875 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12877 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12878 when at ZV. (Bug#8487)
12880 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12882 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12884 * keyboard.c (parse_tool_bar_item): Likewise.
12885 * sound.c (sound_cleanup, alsa_close): Likewise.
12886 * termcap.c (tgetent): Likewise.
12887 * xfns.c (x_default_font_parameter): Likewise.
12888 * xsettings.c (read_and_apply_settings): Likewise.
12890 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12891 (overrun_check_free): Protoize.
12893 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12895 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12896 since callers should never pass a negative size.
12897 Change the signature to match that of plain 'read' and 'write'; see
12898 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12899 * lisp.h: Update prototypes of emacs_write and emacs_read.
12901 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12903 * xdisp.c (redisplay_window): Don't try to determine the character
12904 position of the scroll margin if the window start point w->startp
12905 is outside the buffer's accessible region. (Bug#8468)
12907 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12909 Fix write-region and its subroutines for buffers > 2GB.
12910 * fileio.c (a_write, e_write): Modify declaration of arguments and
12911 local variables to support buffers larger than 2GB.
12912 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12914 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12915 argument, local variables, and return value.
12917 * lisp.h: Update prototypes of emacs_write and emacs_read.
12919 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12921 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12923 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12925 Fix more problems found by GCC 4.6.0's static checks.
12927 * xdisp.c (vmessage): Use a better test for character truncation.
12929 * charset.c (load_charset_map): <, not <=, for optimization,
12930 and to avoid potential problems with integer overflow.
12931 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12932 * casetab.c (set_identity, shuffle): Likewise.
12933 * editfns.c (Fformat): Likewise.
12934 * syntax.c (skip_chars): Likewise.
12936 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12937 This also lets GCC 4.6.0 generate slightly better loop code.
12939 * callint.c (Fcall_interactively): <, not <=, for optimization.
12940 (Fcall_interactively): Count the number of arguments produced,
12941 not the number of arguments given. This is simpler and lets GCC
12942 4.6.0 generate slightly better code.
12944 * ftfont.c: Distingish more carefully between FcChar8 and char.
12945 The previous code passed unsigned char * to a functions like
12946 strlen and xstrcasecmp that expect char *, which does not
12947 conform to the C standard.
12948 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12949 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12950 char * when the C standard requires it.
12952 * keyboard.c (read_char): Remove unused var.
12954 * eval.c: Port to Windows vsnprintf (Bug#8435).
12955 Include <limits.h>.
12956 (SIZE_MAX): Define if the headers do not.
12957 (verror): Do not give up if vsnprintf returns a negative count.
12958 Instead, grow the buffer. This ports to Windows vsnprintf, which
12959 does not conform to C99. Problem reported by Eli Zaretskii.
12960 Also, simplify the allocation scheme, by avoiding the need for
12961 calling realloc, and removing the ALLOCATED variable.
12963 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12965 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12966 But keep the doprint source code for now, as we might revamp it
12967 and use it again (Bug#8435).
12968 * lisp.h (doprnt): Remove.
12969 * Makefile.in (base_obj): Remove doprnt.o.
12970 * deps.mk (doprnt.o): Remove.
12972 error: Print 32- and 64-bit integers portably (Bug#8435).
12973 Without this change, on typical 64-bit hosts error ("...%d...", N)
12974 was used to print both 32- and 64-bit integers N, which relied on
12975 undefined behavior.
12976 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12977 * lisp.h (error, verror): Mark as printf-like functions.
12978 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12979 Report overflow in size calculations when allocating printf buffer.
12980 Do not truncate output string at its first null byte.
12981 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12982 Truncate the output at a character boundary, since vsnprintf does not
12984 * charset.c (check_iso_charset_parameter): Convert internal
12985 character to string before calling 'error', since %c now has the
12987 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12988 overflow when computing char to be passed to 'error'. Do not
12989 pass Lisp_Object to 'error'; pass the integer instead.
12990 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12991 formatted with plain %d.
12993 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12995 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12997 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12999 * xterm.c (x_catch_errors): Remove duplicate declaration.
13001 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13003 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13005 2011-04-10 Jim Meyering <meyering@redhat.com>
13007 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13008 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13009 return ssize_t not "int", and use size_t as the buffer length.
13010 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13011 * gnutls.h: Update declarations.
13012 * process.c (read_process_output): Use ssize_t, to match.
13013 (send_process): Likewise.
13015 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13017 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13019 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13021 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13022 Use unsigned char, to match FcChar8 type definition.
13024 * xterm.c (handle_one_xevent):
13025 * xmenu.c (create_and_show_popup_menu):
13026 * xselect.c (x_decline_selection_request)
13027 (x_reply_selection_request): Avoid type-punned deref of X events.
13029 2011-04-09 Eli Zaretskii <eliz@gnu.org>
13031 Fix some uses of `int' instead of EMACS_INT.
13032 * search.c (string_match_1, fast_string_match)
13033 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13034 (scan_buffer, find_next_newline_no_quit)
13035 (find_before_next_newline, search_command, Freplace_match)
13036 (Fmatch_data): Make some `int' variables be EMACS_INT.
13038 * xdisp.c (display_count_lines): 3rd argument and return value now
13039 EMACS_INT. All callers changed.
13040 (pint2hrstr): Last argument is now EMACS_INT.
13042 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13043 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13044 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13045 (decode_coding_utf_16, decode_coding_emacs_mule)
13046 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13047 (decode_coding_ccl, decode_coding_charset)
13048 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13049 (decode_coding_iso_2022, decode_coding_emacs_mule)
13050 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13051 <char_offset, last_offset>: Declare EMACS_INT.
13052 (encode_coding_utf_8, encode_coding_utf_16)
13053 (encode_coding_emacs_mule, encode_invocation_designation)
13054 (encode_designation_at_bol, encode_coding_iso_2022)
13055 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13056 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13058 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13059 (encode_invocation_designation): Last argument P_NCHARS is now
13061 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13062 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13064 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13067 * ccl.c (Fccl_execute_on_string): Declare some variables
13070 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
13072 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13074 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13076 * process.c (Fformat_network_address): Doc fix.
13078 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13080 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
13082 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
13084 * keyboard.c (read_char): Call Lisp function help-form-show,
13085 instead of using internal_with_output_to_temp_buffer.
13086 (Qhelp_form_show): New var.
13087 (syms_of_keyboard): Use DEFSYM macro.
13089 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13091 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13093 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
13095 * process.c (Flist_processes): Remove to Lisp.
13096 (list_processes_1): Delete.
13098 2011-04-06 Eli Zaretskii <eliz@gnu.org>
13100 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13102 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13104 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13106 Fix more problems found by GCC 4.6.0's static checks.
13108 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13110 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13112 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
13114 * xdisp.c (vmessage): Mark as a printf-like function.
13116 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13118 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13120 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13121 printf-like functions.
13122 (tiff_load): Add casts to remove these marks before passing them
13123 to system-supplied API.
13125 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13127 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13128 This avoids several warnings with gcc -Wstrict-overflow.
13129 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13130 directly, rather than having caller test rule sign. This avoids
13131 some unnecessary tests.
13132 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13133 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13134 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
13136 * xfont.c (xfont_text_extents): Remove var that was set but not used.
13137 (xfont_open): Avoid unnecessary tests.
13139 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13141 * composite.h, composite.c (composition_gstring_put_cache):
13142 Use EMACS_INT, not int, for length.
13144 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13145 breaking out part of COMPOSITION_DECODE_RULE.
13146 (COMPOSITION_DECODE_RULE): Use it.
13147 * composite.c (get_composition_id): Remove unused local vars,
13148 by using the new macro.
13150 * textprop.c (set_text_properties_1): Change while to do-while,
13151 since the condition is always true at first.
13153 * intervals.c (graft_intervals_into_buffer): Mark var as used.
13154 (interval_deletion_adjustment): Return unsigned value.
13157 * process.c (list_processes_1, create_pty, read_process_output):
13158 (exec_sentinel): Remove vars that were set but not used.
13159 (create_pty): Remove unnecessary "volatile"s.
13160 (Fnetwork_interface_info): Avoid possibility of int overflow.
13161 (read_process_output): Do adaptive read buffering even if carryover.
13162 (read_process_output): Simplify nbytes computation if buffered.
13164 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13166 * syntax.c (scan_words): Remove var that was set but not used.
13167 (update_syntax_table): Use unsigned instead of int.
13169 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13170 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13171 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13173 * print.c (print_error_message): Avoid int overflow.
13175 * font.c (font_list_entities): Redo for clarity,
13176 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13178 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13179 (font_score): Avoid potential overflow in diff calculation.
13181 * fns.c (substring_both): Remove var that is set but not used.
13182 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13184 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13186 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13187 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13188 can always succeed if overflow has undefined behavior.
13190 * search.c (boyer_moore, wordify): Remove vars set but not used.
13191 (wordify): Omit three unnecessary tests.
13193 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13194 All callers changed. This avoids the need for an unused var.
13196 * casefiddle.c (casify_region): Remove var that is set but not used.
13198 * dired.c (file_name_completion): Remove var that is set but not used.
13200 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13202 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13203 (Finsert_file_contents): Remove unnecessary code checking fd.
13205 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13206 Check for integer overflow on size calculations.
13208 * buffer.c (Fprevious_overlay_change): Remove var that is set
13211 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13212 Remove vars that are set but not used.
13213 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13214 (timer_check_2): Mark vars as initialized.
13216 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13218 * image.c (lookup_image): Remove var that is set but not used.
13219 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13221 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13222 that are set but not used.
13224 * xfns.c (make_invisible_cursor): Don't return garbage
13225 if XCreateBitmapFromData fails (Bug#8410).
13227 * xselect.c (x_get_local_selection, x_handle_property_notify):
13228 Remove vars that are set but not used.
13230 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13231 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13233 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13234 Remove var that is set but not used.
13235 (scroll_bar_windows_size): Now size_t, not int.
13236 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13237 Check for overflow.
13239 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13240 (map_tty_color) [!defined MSDOS]: Likewise.
13242 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13244 * coding.c: Remove vars that are set but not used.
13245 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13246 All callers changed.
13247 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13248 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13249 (decode_coding_charset): Remove vars that are set but not used.
13251 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13252 that is set but not used.
13254 * print.c (print_object): Remove var that is set but not used.
13256 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13257 The gnulib version avoids calling malloc in the usual case,
13258 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13259 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13260 * filelock.c (current_lock_owner): Likewise.
13261 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13262 * sysdep.c: Include allocator.h, careadlinkat.h.
13263 (emacs_no_realloc_allocator): New static constant.
13264 (emacs_readlink): New function.
13265 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13266 ../lib/careadlinkat.h.
13268 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13270 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13271 first non-nil return value).
13273 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13275 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13276 if not defined (Bug#8403).
13278 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13280 * xdisp.c (display_count_lines): Remove parameter `start',
13281 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13282 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13283 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13284 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13285 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13286 and thereabouts. All callers changed.
13287 (get_per_char_metric): Remove parameter `f', unused since
13288 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13290 2011-04-02 Jim Meyering <meyering@redhat.com>
13292 do not dereference NULL upon failed strdup
13293 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13294 (ns_get_family): Likewise.
13296 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13298 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13300 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13302 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13305 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13307 Add lexical binding.
13309 * window.c (Ftemp_output_buffer_show): New fun.
13310 (Fsave_window_excursion):
13311 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13313 * lread.c (lisp_file_lexically_bound_p): New function.
13314 (Fload): Bind Qlexical_binding.
13315 (readevalloop): Remove `evalfun' arg.
13316 Bind Qinternal_interpreter_environment.
13317 (Feval_buffer): Bind Qlexical_binding.
13318 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13320 (syms_of_lread): Declare `lexical-binding'.
13322 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13324 * keyboard.c (eval_dyn): New fun.
13325 (menu_item_eval_property): Use it.
13327 * image.c (parse_image_spec): Use Ffunctionp.
13329 * fns.c (concat, mapcar1): Accept byte-code-functions.
13331 * eval.c (Fsetq): Handle lexical vars.
13332 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13333 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13334 (FletX, Flet): Obey lexical binding.
13335 (Fcommandp): Handle closures.
13336 (Feval): New `lexical' arg.
13337 (eval_sub): New function extracted from Feval. Use it almost
13338 everywhere where Feval was used. Look up vars in lexical env.
13340 (Ffunctionp): Move from subr.el.
13341 (Ffuncall): Handle closures.
13342 (apply_lambda): Remove `eval_flags'.
13343 (funcall_lambda): Handle closures and new byte-code-functions.
13344 (Fspecial_variable_p): New function.
13345 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13346 but without exporting it to Lisp.
13348 * doc.c (Fdocumentation, store_function_docstring):
13349 * data.c (Finteractive_form): Handle closures.
13351 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13354 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13356 (exec_byte_code): New function extracted from Fbyte_code to handle new
13357 calling convention for byte-code-functions. Add new byte-codes.
13359 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13361 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13363 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13365 * xdisp.c (redisplay_internal): Fix prototype.
13367 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13369 * xdisp.c (SCROLL_LIMIT): New macro.
13370 (try_scrolling): Use it when setting scroll_limit.
13371 Limit scrolling to 100 screen lines.
13372 (redisplay_window): Even when falling back on "recentering",
13373 position point in the window according to scroll-conservatively,
13374 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13376 (try_scrolling): When point is above the window, allow searching
13377 as far as scroll_max, or one screenful, to compute vertical
13378 distance from PT to the scroll margin position. This prevents
13379 try_scrolling from unnecessarily failing when
13380 scroll-conservatively is set to a value slightly larger than the
13381 window height. Clean up the case of PT below the margin at bottom
13382 of window: scroll_max can no longer be INT_MAX. When aggressive
13383 scrolling is in use, don't let point enter the opposite scroll
13384 margin as result of the scroll.
13385 (syms_of_xdisp) <scroll-conservatively>: Document the
13386 threshold of 100 lines for never-recentering scrolling.
13388 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13390 * dispextern.h (move_it_by_lines):
13391 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13392 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13393 (message_log_check_duplicate): Remove parameters `prev_bol' and
13394 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13395 (redisplay_internal): Remove parameter `preserve_echo_area',
13396 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13398 * indent.c (Fvertical_motion):
13399 * window.c (window_scroll_pixel_based, Frecenter):
13400 Don't pass `need_y_p' to `move_it_by_lines'.
13402 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13404 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13405 steal a few bits to be more compact.
13406 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13407 Remove unneeded casts.
13409 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13411 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13413 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13414 binding" message (bug#7967).
13416 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13418 Fix more problems found by GCC 4.6.0's static checks.
13420 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13421 Remove unused local var.
13423 * editfns.c (Fmessage_box): Remove unused local var.
13425 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13426 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13427 Omit unused local vars.
13428 * window.c (shrink_windows): Omit unused local var.
13429 * menu.c (digest_single_submenu): Omit unused local var.
13430 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13431 Omit unused local var.
13433 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13434 Don't assume string length fits in int.
13435 (keyremap_step, read_key_sequence): Use size_t for sizes.
13436 (read_key_sequence): Don't check last_real_key_start redundantly.
13438 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13439 instead of alloca (Bug#8344).
13441 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13442 (Fbacktrace_frame): Don't assume nframes fits in int.
13444 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13446 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13449 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13451 * cm.c (calccost): Turn while-do into do-while, for clarity.
13453 * keyboard.c (syms_of_keyboard): Use the same style as later
13454 in this function when indexing through an array. This also
13455 works around GCC bug 48267.
13457 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13459 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13461 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13462 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13464 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13465 This avoids undefined behavior on integer overflow, and is a bit
13466 more convenient anyway since it is compared to a size_t variable.
13468 Variadic C functions now count arguments with size_t, not int.
13469 This avoids an unnecessary limitation on 64-bit machines, which
13470 caused (substring ...) to crash on large vectors (Bug#8344).
13471 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13472 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13473 All variadic functions and their callers changed accordingly.
13474 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13475 * data.c (arith_driver, float_arith_driver): Likewise.
13476 * editfns.c (general_insert_function): Likewise.
13477 * eval.c (struct backtrace.nargs, interactive_p)
13478 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13479 (funcall_lambda, mark_backtrace): Likewise.
13480 * fns.c (concat): Likewise.
13481 * frame.c (x_set_frame_parameters): Likewise.
13482 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13483 0 if not found, not -1. All callers changed.
13485 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13486 (stack_copy_size): Now size_t, not int.
13487 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13489 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13491 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13492 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13493 All callers changed.
13495 * lisp.h (multibyte_char_to_unibyte):
13496 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13497 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13498 * character.h (CHAR_TO_BYTE8):
13499 * cmds.c (internal_self_insert):
13500 * editfns.c (general_insert_function):
13501 * keymap.c (push_key_description):
13502 * search.c (Freplace_match):
13503 * xdisp.c (message_dolog, set_message_1): All callers changed.
13505 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13507 * keyboard.c (safe_run_hook_funcall): New function.
13508 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13509 don't set the hook to nil, but remove the offending function instead.
13510 (Qcommand_hook_internal): Remove, unused.
13511 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13512 Vcommand_hook_internal.
13514 * eval.c (enum run_hooks_condition): Remove.
13515 (funcall_nil, funcall_not): New functions.
13516 (run_hook_with_args): Call each function through a `funcall' argument.
13517 Remove `cond' argument, now redundant.
13518 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13519 (Frun_hook_with_args_until_failure): Adjust accordingly.
13520 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13522 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13524 * dispextern.h (string_buffer_position): Remove declaration.
13526 * print.c (strout): Remove parameter `multibyte', unused since
13527 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13529 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13530 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13531 All callers changed.
13533 * w32.c (_wsa_errlist): Use braces for struct initializers.
13535 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13536 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13537 All callers changed.
13538 (string_buffer_position): Likewise. Also, make static (it's never
13539 used outside xdisp.c).
13540 (cursor_row_p): Remove parameter `w', unused since
13541 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13542 (decode_mode_spec): Remove parameter `precision', introduced during
13543 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13544 All callers changed.
13546 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13548 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13550 2011-03-27 Anders Lindgren <andlind@gmail.com>
13552 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13553 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13554 (ns_update_auto_hide_menu_bar): New functions.
13555 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13556 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13557 ns_constrain_all_frames.
13558 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13559 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13561 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13563 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13565 2011-03-27 Glenn Morris <rgm@gnu.org>
13567 * syssignal.h: Replace RETSIGTYPE with void.
13568 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13569 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13570 Replace SIGTYPE with void everywhere.
13571 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13572 * s/template.h (SIGTYPE): Remove commented out definition.
13574 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13576 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13577 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13579 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13581 * w32.c (read_unc_volume): Use parameter `henum', instead of
13582 global variable `wget_enum_handle'.
13584 * keymap.c (describe_vector): Remove parameters `indices' and
13585 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13586 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13588 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13590 * keyboard.c (timer_check): Remove parameter `do_it_now',
13591 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13592 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13593 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13595 * keyboard.c (read_char):
13596 * w32menu.c (w32_menu_display_help):
13597 * xmenu.c (show_help_event, menu_help_callback):
13598 Adjust calls to `show_help_echo'.
13600 * gtkutil.c (xg_maybe_add_timer):
13601 * keyboard.c (readable_events):
13602 * process.c (wait_reading_process_output):
13603 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13605 * insdel.c (adjust_markers_gap_motion):
13606 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13607 (gap_left, gap_right): Don't call it.
13609 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13611 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13612 incurred during fontification.
13614 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13616 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13617 (DEFVAR_PER_BUFFER): Don't pass it.
13619 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13620 (scrolling_window): Don't pass it.
13622 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13624 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13626 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13628 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13629 of variables specific to SELinux and computation of `encoded_absname'.
13631 * image.c (XPutPixel): Remove unused variable `height'.
13633 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13635 * unexw32.c (get_section_info): Remove unused variable `section'.
13637 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13638 (system_process_attributes): Remove unused variable `sess'.
13639 (sys_read): Remove unused variable `err'.
13641 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13642 (w32_wnd_proc): Remove unused variable `isdead'.
13643 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13644 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13645 (x_create_tip_frame): Remove unused variable `tem'.
13647 * w32inevt.c (w32_console_read_socket):
13648 Remove unused variable `no_events'.
13650 * w32term.c (x_draw_composite_glyph_string_foreground):
13651 Remove unused variable `width'.
13653 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13655 * w32term.c (x_set_glyph_string_clipping):
13656 Don't pass uninitialized region to CombineRgn.
13658 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13660 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13661 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13662 (Fx_close_connection): Remove unused variable `i'.
13664 * w32font.c (w32font_draw): Return number of glyphs.
13665 (w32font_open_internal): Remove unused variable `i'.
13666 (w32font_driver): Add missing initializer.
13668 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13669 (fill_in_menu): Remove unused variable `items_added'.
13671 * w32term.c (last_mouse_press_frame): Remove static global variable.
13672 (w32_clip_to_row): Remove unused variable `f'.
13673 (x_delete_terminal): Remove unused variable `i'.
13675 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13676 (NOTHING): Remove unused static global variable.
13677 (uniscribe_check_otf): Remove unused variable `table'.
13678 (uniscribe_font_driver): Add missing initializers.
13680 2011-03-23 Julien Danjou <julien@danjou.info>
13682 * term.c (Fsuspend_tty, Fresume_tty):
13683 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13684 * window.c (temp_output_buffer_show):
13685 * insdel.c (signal_before_change):
13686 * frame.c (Fhandle_switch_frame):
13687 * fileio.c (Fdo_auto_save):
13688 * emacs.c (Fkill_emacs):
13689 * editfns.c (save_excursion_restore):
13690 * cmds.c (internal_self_insert):
13691 * callint.c (Fcall_interactively):
13692 * buffer.c (Fkill_all_local_variables):
13693 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13695 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13696 unconditionally since it does the check itself.
13698 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13700 Fix more problems found by GCC 4.5.2's static checks.
13702 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13703 the first time through the loop, since we know p0 < p1 then.
13704 This also avoids a gcc -Wstrict-overflow warning.
13706 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13707 leading to a memory leak, possible in functions like
13708 load_charset_map_from_file that can allocate an unbounded number
13709 of objects (Bug#8318).
13711 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13712 that could (at least in theory) be that large.
13714 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13715 This is less likely to overflow, and avoids undefined behavior if
13716 overflow does occur. All callers changed. Use strtoul to scan
13717 for the unsigned long integer.
13718 (pint2hrstr): Simplify and tune code slightly.
13719 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13721 * scroll.c (do_scrolling): Work around GCC bug 48228.
13722 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13724 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13725 This also avoids a warning with gcc -Wstrict-overflow.
13726 (validate_x_resource_name): Simplify count usage.
13727 This also avoids a warning with gcc -Wstrict-overflow.
13729 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13732 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13734 * process.c (Fmake_network_process): Use socklen_t, not int,
13735 where POSIX says socklen_t is required in portable programs.
13736 This fixes a porting bug on hosts like 64-bit HP-UX, where
13737 socklen_t is wider than int (Bug#8277).
13738 (Fmake_network_process, server_accept_connection):
13739 (wait_reading_process_output, read_process_output):
13742 * process.c: Rename or move locals to avoid shadowing.
13743 (list_processes_1, Fmake_network_process):
13744 (read_process_output_error_handler, exec_sentinel_error_handler):
13745 Rename or move locals.
13746 (Fmake_network_process): Define label "retry_connect" only if needed.
13747 (Fnetwork_interface_info): Fix pointer signedness.
13748 (process_send_signal): Add cast to avoid pointer signedness problem.
13749 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13750 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13752 Make tparam.h and terminfo.c consistent.
13753 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13754 Include tparam.h instead, since it declares them.
13755 * cm.h (PC): Remove extern decl; tparam.h now does this.
13756 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13757 * terminfo.c: Include tparam.h, to check interfaces.
13758 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13759 (tparam): Adjust signature to match interface in tparam.h;
13760 this removes some undefined behavior. Check that outstring and len
13761 are zero, which they always are with Emacs.
13762 * tparam.h (PC, BC, UP): New extern decls.
13764 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13765 (xftfont_open): Rename locals to avoid shadowing.
13767 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13768 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13769 (OTF_TAG_SYM): Omit macro if not needed.
13770 (ftfont_list): Remove unused local.
13771 (get_adstyle_property, ftfont_pattern_entity):
13772 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13773 Rename locals to avoid shadowing.
13775 * xfont.c (xfont_list_family): Mark var as initialized.
13777 * xml.c (make_dom): Now static.
13779 * composite.c (composition_compute_stop_pos): Rename local to
13781 (composition_reseat_it): Remove unused locals.
13782 (find_automatic_composition, composition_adjust_point): Likewise.
13783 (composition_update_it): Mark var as initialized.
13784 (find_automatic_composition): Mark vars as initialized,
13785 with a FIXME (Bug#8290).
13787 character.h: Rename locals to avoid shadowing.
13788 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13789 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13790 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13791 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13792 to avoid shadowing.
13794 * textprop.c (property_change_between_p): Remove; unused.
13796 * intervals.c (interval_start_pos): Now static.
13798 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13800 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13801 Rename locals to avoid shadowing.
13803 * sound.c (wav_play, au_play, Fplay_sound_internal):
13804 Fix pointer signedness.
13805 (alsa_choose_format): Remove unused local var.
13806 (wav_play): Initialize a variable to 0, to prevent undefined
13807 behavior (Bug#8278).
13809 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13811 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13813 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13814 clobbering (Bug#8298).
13815 * sysdep.c (sys_subshell): Likewise.
13816 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13818 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13819 This should get cleaned up, so that child_setup has the
13820 same signature on all platforms.
13822 * callproc.c (call_process_cleanup): Now static.
13823 (relocate_fd): Rename locals to avoid shadowing.
13825 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13827 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13828 not to be necessary, and produces flickering.
13830 2011-03-20 Glenn Morris <rgm@gnu.org>
13832 * config.in: Remove file.
13834 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13836 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13837 are now in src/globals.h.
13838 (syms_of_minibuf): Remove spurious & from previous change.
13840 2011-03-20 Leo Liu <sdl.web@gmail.com>
13842 * minibuf.c (completing-read-function): New variable.
13843 (completing-read-default): Rename from completing-read.
13844 (completing-read): Call completing-read-function.
13846 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13848 * xfaces.c (Fx_load_color_file):
13849 Read color file from absolute filename (bug#8250).
13851 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13853 * makefile.w32-in: Update dependencies.
13855 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13857 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13859 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13861 Fix more problems found by GCC 4.5.2's static checks.
13863 * process.c (make_serial_process_unwind, send_process_trap):
13864 (sigchld_handler): Now static.
13866 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13867 That way, the code declares only the vars that it needs.
13868 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13869 * s/cygwin.h (PTY_ITERATION): Likewise.
13870 * s/darwin.h (PTY_ITERATION): Likewise.
13871 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13873 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13874 * process.c (allocate_pty): Don't declare stb unless it's needed.
13876 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13877 (CONSTANTLIM): Remove; unused.
13878 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13879 Define only if needed.
13881 * unexelf.c (unexec): Name an expression,
13882 to avoid gcc -Wbad-function-cast warning.
13883 Use a different way to cause a compilation error if anyone uses
13884 n rather than nn, a way that does not involve shadowing.
13885 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13887 * deps.mk (unexalpha.o): Remove; unused.
13889 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13890 * unexec.h: New file.
13891 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13892 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13893 Depend on unexec.h.
13894 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13895 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13896 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13897 Change as necessary to match prototype in unexec.h.
13899 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13901 (back_comment, skip_chars): Mark vars as initialized.
13903 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13904 Rename locals to avoid shadowing.
13906 * lread.c (read1): Rewrite so as not to use empty "else".
13907 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13909 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13911 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13912 warning when compiling print.c.
13914 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13915 instead of using an uninitialized var.
13916 (font_sort_entities): Mark var as initialized.
13918 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13920 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13921 pointers to constants.
13922 (font_parse_fcname): Remove unused vars.
13923 (font_delete_unmatched): Now static.
13924 (font_get_spec): Remove; unused.
13925 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13926 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13927 Rename or move locals to avoid shadowing.
13929 * fns.c (require_nesting_list, require_unwind): Now static.
13930 (Ffillarray): Rename locals to avoid shadowing.
13932 * floatfns.c (domain_error2): Define only if needed.
13933 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13935 * alloc.c (mark_backtrace): Move decl from here ...
13936 * lisp.h: ... to here, so that it can be checked.
13938 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13939 (Fdefvar): Rewrite so as not to use empty "else".
13940 (lisp_indirect_variable): Name an expression,
13941 to avoid gcc -Wbad-function-cast warning.
13942 (Fdefvar): Rename locals to avoid shadowing.
13944 * callint.c (quotify_arg, quotify_args): Now static.
13945 (Fcall_interactively): Rename locals to avoid shadowing.
13946 Use const pointer when appropriate.
13948 * lisp.h (get_system_name, get_operating_system_release):
13949 Move decls here, to check interfaces.
13950 * process.c (get_operating_system_release): Move decl to lisp.h.
13951 * xrdb.c (get_system_name): Likewise.
13952 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13953 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13954 some of which prompt warnings from gcc -Wbad-function-cast.
13955 (Fformat_time_string, Fencode_time, Finsert_char):
13956 (Ftranslate_region_internal, Fformat):
13957 Rename or remove local vars to avoid shadowing.
13958 (Ftranslate_region_internal): Mark var as initialized.
13960 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13963 * lisp.h (eassert): Check that the argument compiles, even if
13964 ENABLE_CHECKING is not defined.
13966 * data.c (Findirect_variable): Name an expression, to avoid
13967 gcc -Wbad-function-cast warning.
13968 (default_value, arithcompare, arith_driver, arith_error): Now static.
13969 (store_symval_forwarding): Rename local to avoid shadowing.
13970 (Fmake_variable_buffer_local, Fmake_local_variable):
13971 Mark variables as initialized.
13972 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13974 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13975 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13976 Rename locals to avoid shadowing.
13977 (mark_stack): Move local variables into the #ifdef region where
13979 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13980 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13982 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13983 (GC_STRING_CHARS): Remove; not used.
13984 (Fmemory_limit): Cast sbrk's returned value to char *.
13986 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13987 avoids undefined behavior in theory.
13989 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13991 Use functions, not macros, for up- and down-casing (Bug#8254).
13992 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13993 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13994 to use the following functions instead of these macros.
13995 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13996 EMACS_INT, since callers assume the returned value fits in int.
13997 (upcase1): Likewise, for UPCASE_TABLE.
13998 (uppercasep, lowercasep, upcase): New static inline functions.
13999 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
14000 the race-condition problem in the old DOWNCASE.
14002 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14003 Rename locals to avoid shadowing.
14004 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
14005 (regex_compile, re_search_2, re_match_2_internal):
14006 Remove unused local vars.
14007 (FREE_VAR): Rewrite so as not to use empty "else",
14008 which gcc can warn about.
14009 (regex_compile, re_match_2_internal): Mark locals as initialized.
14010 (RETALLOC_IF): Define only if needed.
14011 (WORDCHAR_P): Likewise. This one is never needed, but is used
14012 only in a comment talking about a compiler bug, so put inside
14013 the #if 0 of that comment.
14014 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14015 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14018 * search.c (boyer_moore): Rename locals to avoid shadowing.
14019 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14020 (PREV_CHAR_BOUNDARY): Likewise.
14022 * search.c (simple_search): Remove unused var.
14024 * dired.c (compile_pattern): Move decl from here ...
14025 * lisp.h: ... to here, so that it can be checked.
14026 (struct re_registers): New forward decl.
14028 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14030 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14032 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14033 Rename locals to avoid shadowing.
14034 (Fvertical_motion): Mark locals as initialized.
14036 * casefiddle.c (casify_object, casify_region): Now static.
14037 (casify_region): Mark local as initialized.
14039 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14041 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14042 New macros, so that the caller can use some names other than
14043 gcpro1, gcpro2, etc.
14044 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14046 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14047 argument, for consistency with GCPRO2_VAR, etc: it is now the
14048 prefix of the variable, not the variable itself. All uses
14050 * dired.c (directory_files_internal, file_name_completion):
14051 Rename locals to avoid shadowing.
14053 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14054 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14055 dired.c's scmp function, had undefined behavior.
14056 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14057 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14058 * buffer.h: ... to here, because these macros use current_buffer,
14059 and the new implementation with inline functions needs to have
14060 current_buffer in scope now, rather than later when the macros
14062 (downcase, upcase1): New static inline functions.
14063 (DOWNCASE, UPCASE1): Reimplement using these functions.
14064 This avoids undefined behavior in expressions like
14065 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14066 from race conditions in accessing the global variables
14067 case_temp1 and case_temp2.
14068 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14069 * lisp.h (case_temp1, case_temp2): Remove their decls.
14070 * character.h (ASCII_CHAR_P): Move from here ...
14071 * lisp.h: ... to here, so that the inline functions mentioned
14072 above can use them.
14074 * dired.c (directory_files_internal_unwind): Now static.
14076 * fileio.c (file_name_as_directory, directory_file_name):
14077 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14079 (file_name_as_directory): Use const pointers when appropriate.
14080 (Fexpand_file_name): Likewise. In particular, newdir might
14081 point at constant storage, so make it a const pointer.
14082 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
14083 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14085 (Fset_file_times, Finsert_file_contents, auto_save_error):
14086 Rename locals to avoid shadowing.
14088 * minibuf.c (choose_minibuf_frame_1): Now static.
14089 (Ftry_completion, Fall_completions): Rename or remove locals
14090 to avoid shadowing.
14092 * marker.c (bytepos_to_charpos): Remove; unused.
14094 * lisp.h (verify_bytepos, count_markers): New decls,
14095 so that gcc does not warn that these functions aren't declared.
14097 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14098 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
14099 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
14100 (copy_text): Remove unused local var.
14102 * filelock.c (within_one_second): Now static.
14103 (lock_file_1): Rename local to avoid shadowing.
14105 * buffer.c (fix_overlays_before): Mark locals as initialized.
14106 (fix_start_end_in_overlays): Likewise. This function should be
14107 simplified by using pointers-to-pointers, but that's a different
14109 (switch_to_buffer_1): Now static.
14110 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14111 (report_overlay_modification): Rename locals to avoid shadowing.
14113 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
14114 Fix pointer signedness issue.
14115 (sys_subshell): Mark local as volatile if checking for lint,
14116 to suppress a gcc -Wclobbered warning that does not seem to be right.
14117 (MAXPATHLEN): Define only if needed.
14119 * process.c (serial_open, serial_configure): Move decls from here ...
14120 * systty.h: ... to here, so that they can be checked.
14122 * fns.c (get_random, seed_random): Move extern decls from here ...
14123 * lisp.h: ... to here, so that they can be checked.
14125 * sysdep.c (reset_io): Now static.
14126 (wait_for_termination_signal): Remove; unused.
14128 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14129 (copy_keymap_item, append_key, push_text_char_description):
14131 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
14132 (DENSE_TABLE_SIZE): Remove; unused.
14133 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14134 (describe_map_tree):
14135 Rename locals to avoid shadowing.
14137 * keyboard.c: Declare functions static if they are not used elsewhere.
14138 (echo_char, echo_dash, cmd_error, top_level_2):
14139 (poll_for_input, handle_async_input): Now static.
14140 (read_char, kbd_buffer_get_event, make_lispy_position):
14141 (make_lispy_event, make_lispy_movement, apply_modifiers):
14142 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14143 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14144 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
14145 (read_key_sequence, read_char): Mark locals as initialized.
14146 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
14148 * keyboard.h (make_ctrl_char): New decl.
14149 (mark_kboards): Move decl here ...
14150 * alloc.c (mark_kboards): ... from here.
14152 * lisp.h (force_auto_save_soon): New decl.
14154 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14155 (DEFINE_DUMMY_FUNCTION): New macro.
14156 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14158 (main): Add casts to avoid warnings
14159 if GCC considers string literals to be constants.
14161 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14163 * dbusbind.c: Pointer signedness fixes.
14164 (xd_signature, xd_append_arg, xd_initialize):
14165 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14166 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14167 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14168 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14170 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14171 if GCC considers string literals to be constants.
14172 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14174 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14176 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14177 (print_preprocess, print_object): New macro to fix last change.
14179 * print.c (print_preprocess): Don't forget font objects.
14181 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14183 * emacs.c (USAGE3): Doc fixes.
14185 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14187 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14190 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14192 * lisp.h (VWindow_system, Qfile_name_history):
14193 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14194 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14195 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14197 * w32select.c: Don't #include "keyboard.h".
14198 (run_protected): Add extern declaration for waiting_for_input.
14200 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14201 * w32console.c (detect_input_pending, read_input_pending)
14202 (encode_terminal_code):
14203 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14204 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14205 (w32_system_caret_y, Qfile_name_history):
14206 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14207 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14208 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14209 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14210 * w32proc.c (Qlocal, report_file_error):
14211 * w32term.c (Vwindow_system, updating_frame):
14212 * w32uniscribe.c (initialized, uniscribe_font_driver):
14213 Remove unneeded extern declarations.
14215 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14217 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14219 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14221 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14222 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14223 These macros can no longer be used for assignment.
14225 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14226 Assign struct members directly, instead of using BUF_BEGV etc.
14227 (record_buffer_markers, fetch_buffer_markers): New functions for
14228 recording and fetching special buffer markers.
14229 (set_buffer_internal_1, set_buffer_temp): Use them.
14231 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14233 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14235 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14236 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14238 * xdisp.c (hscroll_window_tree):
14239 (reconsider_clip_changes): Use PT instead of BUF_PT.
14241 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14243 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14244 $(EMACS_ROOT)/lib/intprops.h.
14246 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14248 Fix more problems found by GCC 4.5.2's static checks.
14250 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14251 to unsigned char * to avoid compiler diagnostic.
14252 (xg_free_frame_widgets): Make it clear that a local variable is
14253 needed only if USE_GTK_TOOLTIP.
14254 (gdk_window_get_screen): Make it clear that this macro is needed
14255 only if USE_GTK_TOOLTIP.
14256 (int_gtk_range_get_value): New function, which avoids a diagnostic
14257 from gcc -Wbad-function-cast.
14258 (xg_set_toolkit_scroll_bar_thumb): Use it.
14259 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14260 diagnostic from gcc -Wbad-function-cast.
14261 (get_utf8_string, xg_get_file_with_chooser):
14262 Rename locals to avoid shadowing.
14263 (create_dialog): Move locals to avoid shadowing.
14265 * xgselect.c (xg_select): Remove unused var.
14267 * image.c (four_corners_best): Mark locals as initialized.
14268 (gif_load): Initialize transparent_p to zero (Bug#8238).
14269 Mark another local as initialized.
14270 (my_png_error, my_error_exit): Mark with NO_RETURN.
14272 * image.c (clear_image_cache): Now static.
14273 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14274 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14275 (x_edge_detection): Remove unnecessary cast that
14276 gcc -Wbad-function-cast diagnoses.
14277 (gif_load): Fix pointer signedness.
14278 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14279 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14281 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14283 Improve quality of tests for time stamp overflow.
14284 For example, without this patch (encode-time 0 0 0 1 1
14285 1152921504606846976) returns the obviously-bogus value (-948597
14286 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14287 reports time overflow. See
14288 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14289 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14290 * editfns.c: Include limits.h and intprops.h.
14291 (TIME_T_MIN, TIME_T_MAX): New macros.
14292 (time_overflow): Move earlier, to before first use.
14293 (hi_time, lo_time): New functions, for an accurate test for
14294 out-of-range times.
14295 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14296 (Fget_internal_run_time): Don't assume time_t fits in int.
14297 (make_time): Use list2 instead of Fcons twice.
14298 (Fdecode_time): More accurate test for out-of-range times.
14299 (check_tm_member): New function.
14300 (Fencode_time): Use it, to test for out-of-range times.
14301 (lisp_time_argument): Don't rely on undefined left-shift and
14302 right-shift behavior when checking for time stamp overflow.
14304 * editfns.c (time_overflow): New function, refactoring common code.
14305 (Fformat_time_string, Fdecode_time, Fencode_time):
14306 (Fcurrent_time_string): Use it.
14308 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14309 * dired.c (make_time): Move to ...
14310 * editfns.c (make_time): ... here.
14311 * systime.h: Note the move.
14313 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14315 * fringe.c (update_window_fringes): Remove unused variables.
14317 * unexmacosx.c (copy_data_segment): Also copy __got section.
14320 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14322 * termcap.c [MSDOS]: Include "msdos.h".
14323 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14324 Constify `char *' arguments and their references according to
14325 prototypes in tparam.h.
14327 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14329 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14330 Adapt all references accordingly.
14332 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14334 2011-03-11 Tom Tromey <tromey@redhat.com>
14336 * buffer.c (syms_of_buffer): Remove obsolete comment.
14338 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14340 * termhooks.h (encode_terminal_code): Declare prototype.
14342 * msdos.c (encode_terminal_code): Don't declare prototype.
14344 * term.c (encode_terminal_code): Now external again, used by
14345 w32console.c and msdos.c.
14347 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14348 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14350 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14352 Fix some minor problems found by GCC 4.5.2's static checks.
14354 * fringe.c (update_window_fringes): Mark locals as initialized
14356 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14358 * alloc.c (mark_fringe_data): Move decl from here ...
14359 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14360 to check its interface.
14361 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14363 * fontset.c (free_realized_fontset): Now static.
14364 (Fset_fontset_font): Rename local to avoid shadowing.
14365 (fontset_font): Mark local as initialized.
14366 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14368 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14370 * xselect.c (x_disown_buffer_selections): Remove; not used.
14371 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14372 (x_own_selection, Fx_disown_selection_internal): Rename locals
14373 to avoid shadowing.
14374 (x_handle_dnd_message): Remove local to avoid shadowing.
14376 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14377 so that the caller can use some name other than gcpro1.
14378 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14379 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14380 (Fx_backspace_delete_keys_p):
14381 Use them to avoid shadowing, and rename vars to avoid shadowing.
14382 (x_decode_color, x_set_name, x_window): Now static.
14383 (Fx_create_frame): Add braces to silence GCC warning.
14384 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14385 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14386 Remove unused locals.
14387 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14388 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14389 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14392 * xterm.h (x_mouse_leave): New decl.
14394 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14395 Remove unused functions.
14396 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14397 (x_calc_absolute_position): Now static.
14398 (XTread_socket): Don't define label "out" unless it's used.
14399 Don't declare local "event" unless it's used.
14400 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14401 unless they are used.
14402 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14403 (x_fatal_error_signal): Remove; not used.
14404 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14405 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14406 (x_error_catcher, x_connection_closed, x_error_handler):
14407 (x_error_quitter, xembed_send_message, x_iconify_frame):
14408 (my_log_handler): Rename locals to avoid shadowing.
14409 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14410 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14412 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14413 Rename or move locals to avoid shadowing.
14414 (tty_defined_color, merge_face_heights): Now static.
14415 (free_realized_faces_for_fontset): Remove; not used.
14416 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14417 does not deduce is never used uninitialized.
14418 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14419 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14421 * terminal.c (store_terminal_param): Now static.
14423 * xmenu.c (menu_highlight_callback): Now static.
14424 (set_frame_menubar): Remove unused local.
14425 (xmenu_show): Rename parameter to avoid shadowing.
14426 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14427 since they might point to immutable storage.
14428 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14429 since it's unused otherwise.
14431 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14432 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14433 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14434 avoids a gcc -Wuninitialized diagnostic.
14435 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14436 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14437 does not deduce are never used uninitialized.
14439 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14441 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14442 * window.c (window_loop, size_window):
14443 (run_window_configuration_change_hook, enlarge_window): Likewise.
14445 * window.c (display_buffer): Now static.
14446 (size_window): Mark variables that gcc -Wuninitialized
14447 does not deduce are never used uninitialized.
14448 * window.h (check_all_windows): New decl, to forestall
14449 gcc -Wmissing-prototypes diagnostic.
14450 * dispextern.h (bidi_dump_cached_states): Likewise.
14452 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14454 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14455 Include <limits.h>.
14456 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14457 and to avoid gcc -Wuninitialized warning.
14458 (load_charset_map): Mark variables that gcc -Wuninitialized
14459 does not deduce are never used uninitialized.
14460 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14462 * coding.c (coding_set_source, coding_set_destination):
14463 Use "else { /* comment */ }" rather than "else /* comment */;"
14464 for clarity, and to avoid gcc -Wempty-body warning.
14465 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14466 a block, when the outer 'i' will do.
14467 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14468 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14469 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14470 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14471 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14472 Rename locals to avoid shadowing.
14473 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14474 * coding.c (emacs_mule_char, encode_invocation_designation):
14475 Now static, since they're not used elsewhere.
14476 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14477 (decode_coding_object, encode_coding_object, detect_coding_system):
14478 (decode_coding_emacs_mule): Mark variables that gcc
14479 -Wuninitialized does not deduce are never used uninitialized.
14480 (detect_coding_iso_2022): Initialize a local variable that might
14481 be used uninitialized. Leave a FIXME because it's not clear that
14482 this initialization is needed. (Bug#8211)
14483 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14484 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14485 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14486 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14487 Remove unused macros.
14489 * category.c (hash_get_category_set): Remove unused local var.
14490 (copy_category_table): Now static, since it's not used elsewhere.
14491 * character.c (string_count_byte8): Likewise.
14493 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14494 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14496 * chartab.c (copy_sub_char_table): Now static, since it's not used
14498 (sub_char_table_ref_and_range, char_table_ref_and_range):
14499 Rename locals to avoid shadowing.
14500 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14502 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14503 (BIDI_BOB): Remove unused macro.
14505 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14506 deduce are never used uninitialized.
14507 * term.c (encode_terminal_code): Likewise.
14509 * term.c (encode_terminal_code): Now static. Remove unused local.
14511 * tparam.h: New file.
14512 * term.c, tparam.h: Include it.
14513 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14514 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14515 Move these decls to tparam.h, and make them agree with what
14516 is actually in tparam.c. The previous trick of using incompatible
14517 decls in different modules does not conform to the C standard.
14518 All callers of tparam changed to use tparam's actual API.
14519 * tparam.c (tparam1, tparam, tgoto):
14520 Use const pointers where appropriate.
14522 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14523 * cm.h (struct cm): Likewise.
14524 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14525 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14526 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14527 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14528 (turn_on_face, init_tty): Likewise.
14529 * termchar.h (struct tty_display_info): Likewise.
14531 * term.c (term_mouse_position): Rename local to avoid shadowing.
14533 * alloc.c (mark_ttys): Move decl from here ...
14534 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14536 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14538 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14540 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14542 * search.c (compile_pattern_1): Remove argument regp, unused since
14543 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14544 (compile_pattern): Don't pass it.
14546 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14548 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14549 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14551 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14553 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14555 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14556 gdk_window_get_screen, gdk_window_get_geometry,
14557 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14558 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14559 (xg_get_pixbuf_from_pixmap): New function.
14560 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14561 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14562 Call xg_get_pixbuf_from_pixmap instead of
14563 gdk_pixbuf_get_from_drawable.
14564 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14565 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14566 (xg_check_special_colors): Use GtkStyleContext and its functions
14568 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14569 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14570 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14571 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14572 Call gtk_widget_get_preferred_size.
14573 (xg_frame_resized): gdk_window_get_geometry only takes 5
14575 (xg_win_to_widget, xg_event_is_for_menubar):
14576 Call gdk_x11_window_lookup_for_display.
14577 (xg_set_widget_bg): New function.
14578 (delete_cb): New function.
14579 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14580 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14581 (xg_set_background_color): Call xg_set_widget_bg.
14582 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14583 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14584 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14585 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14587 (update_frame_tool_bar): Call gtk_widget_hide.
14588 (xg_initialize): Use GDK_KEY_g.
14590 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14592 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14594 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14595 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14596 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14598 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14600 * w32xfns.c (select_palette): Check success of RealizePalette against
14601 GDI_ERROR, not zero.
14603 See ChangeLog.11 for earlier changes.
14605 ;; Local Variables:
14609 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14611 This file is part of GNU Emacs.
14613 GNU Emacs is free software: you can redistribute it and/or modify
14614 it under the terms of the GNU General Public License as published by
14615 the Free Software Foundation, either version 3 of the License, or
14616 (at your option) any later version.
14618 GNU Emacs is distributed in the hope that it will be useful,
14619 but WITHOUT ANY WARRANTY; without even the implied warranty of
14620 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14621 GNU General Public License for more details.
14623 You should have received a copy of the GNU General Public License
14624 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.